gdb/ChangeLog

   1 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
   2
   3         * source.c (prepare_path_for_appending): New function.
   4         (openp): Make use of new function.
   5         (find_and_open_source): Search for the compilation directory and
   6         source file as a relative path beneath the directory search path.
   7
   8 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
   9
  10         * source-cache.c (source_cache::get_line_charpos): Catch
  11         exceptions and return false, this matches the behaviour documented
  12         in the header file.
  13
  14 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
  15
  16         * ada-tasks.c (info_task): Remove quoting of the task's name.
  17
  18 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * symfile.c (auto_solib_add): Replace comment with a reference
  21         to the header file.
  22
  23 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
  24
  25         * NEWS: Mention that gdb can now be compiled with Python 3
  26         on Windows.
  27
  28 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  29
  30         * maint.c (maint_print_section_data::maint_print_section_data):
  31         Force use of 'float log10 (float)' by casting the argument to
  32         float.
  33
  34 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  35
  36         * maint.c: Add 'cmath' include.
  37         (struct maint_print_section_data): New structure.
  38         (print_section_index): New function.
  39         (print_bfd_section_info): Add header comment, small whitespace
  40         cleanup, and update to call new print_section_index function.
  41         (print_objfile_section_info): Likewise.
  42         (maint_obj_section_from_bfd_section): New function.
  43         (print_bfd_section_info_maybe_relocated): New function.
  44         (maintenance_info_sections): Add header comment, always use
  45         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
  46
  47 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  48
  49         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
  50         inner scope, add check that the objfile has psymtabs before
  51         checking psymtabs_addrmap.
  52         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
  53
  54 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  55
  56         * NEWS: Announce that Ada task names are now shown at more places,
  57         and between quotes (except in info task output).
  58         * gdb/ada-tasks.c (task_to_str): New function.
  59         (display_current_task_id): Call task_to_str.
  60         (task_command_1): Likewise.
  61         (print_ada_task_info): In non-mi mode, Properly align headers and data
  62         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
  63
  64 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  65
  66         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
  67         prstatus.pr_lwp.pr_info instead of making it up.
  68
  69 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  70
  71         * auto-load.c (auto_load_expand_dir_vars): Update.
  72         * defs.h (gdb_datadir): Change to std::string.
  73         (python_libdir): Likewise.
  74         (relocate_gdb_directory): Change return type to std::string.
  75         * guile/guile.c (gdbscm_data_directory): Update.
  76         (initialize_scheme_side): Update.
  77         * jit.c (jit_reader_dir): Change to std::string.
  78         (jit_reader_load_command): Update.
  79         * main.c (gdb_datadir): Change to std::string.
  80         (python_libdir): Likewise.
  81         (set_gdb_data_directory): Update.
  82         (relocate_path): Change to return std::string.
  83         (relocate_gdb_directory): Change to return std::string.
  84         (relocate_gdbinit_path_maybe_in_datadir): Update.
  85         (captured_main_1): Update.
  86         * python/python.c (do_start_initialization): Update.
  87         * top.c (show_gdb_datadir): Update.
  88         * xml-syscall.c (xml_init_syscalls_info): Update.
  89         (init_syscalls_info): Update.
  90
  91 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  92
  93         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
  94         out of get_init_files.
  95         (get_init_files): Update.
  96
  97 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * main.c (get_init_files): Change to use std::string.
 100         (captured_main_1): Update.
 101         (print_gdb_help): Update.
 102
 103 2019-09-11  Ali Tamur  <tamur@google.com>
 104
 105         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 106         implementation.
 107
 108 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 109
 110         * dbxread.c (read_dbx_symtab): Update.
 111         * dwarf2read.c (load_partial_dies): Update.
 112         * mdebugread.c (parse_partial_symbols): Update.
 113         (handle_psymbol_enumerators): Update.
 114         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 115         * psymtab.c (add_psymbol_to_bcache): Likewise.
 116         (add_psymbol_to_list): Likewise.
 117         * symtab.c (symbol_set_names): Likewise.
 118         * symtab.h (symbol_set_names): Likewise.
 119         * xcoffread.c (scan_xcoff_symtab): Update.
 120
 121 2019-09-11  Tom Tromey  <tom@tromey.com>
 122
 123         * symfile-mem.c (symbol_file_add_from_memory): Use
 124         bfd_set_filename.
 125         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 126         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 127
 128 2019-09-10  Tom Tromey  <tromey@adacore.com>
 129
 130         * dwarf-index-write.c (write_psymbols): Extend error message.
 131         (debug_names::insert): Add Ada code.
 132         (debug_names::write_psymbols): Remove Ada check.
 133         (debug_names) <m_string_obstack>: New member.
 134         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 135         (gdb_index_symbol_name_matcher::matches): Remove.
 136         (mapped_index_base::find_name_components_bounds): Add "lang"
 137         parameter.
 138         (mapped_index_base::build_name_components): Also split names
 139         according to Ada syntax.
 140         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 141         type of "match_callback".
 142         (check_match, check_find_bounds_finds)
 143         (dw2_expand_symtabs_matching): Update.
 144         (dw2_debug_names_iterator): Add new constructor.
 145         (dw2_debug_names_map_matching_symbols): New function.
 146         (dw2_debug_names_expand_symtabs_matching): Update.
 147         (dwarf2_debug_names_functions): Use
 148         dw2_debug_names_map_matching_symbols.
 149
 150 2019-09-10  Tom Tromey  <tromey@adacore.com>
 151
 152         * dwarf2read.c (dw2_get_file_names_reader): Add the
 153         CU's file name to the results.
 154
 155 2019-09-10  Tom Tromey  <tromey@adacore.com>
 156
 157         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 158         map_matching_symbols.  Update.
 159         * dwarf2read.c (dw2_map_matching_symbols): Update.
 160         * psymtab.c (match_partial_symbol): Change type; update.
 161         (psym_map_matching_symbols): Likewise.
 162         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 163         type; update.
 164         * symfile.h (struct quick_symbol_functions)
 165         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 166         Remove "match".
 167
 168 2019-09-10  Tom Tromey  <tromey@adacore.com>
 169
 170         * psymtab.c (map_block): Remove.
 171         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 172         * symtab.c (iterate_over_symbols_terminated): New function.
 173         * symtab.c (iterate_over_symbols_terminated): Declare.
 174
 175 2019-09-10  Tom Tromey  <tromey@adacore.com>
 176
 177         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 178         * language.h (struct language_defn) <la_iterate_over_symbols>:
 179         Return bool.
 180         * symtab.c (iterate_over_symbols): Return bool.
 181         * symtab.h (iterate_over_symbols): Return bool.
 182
 183 2019-09-10  Tom Tromey  <tromey@adacore.com>
 184
 185         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 186         (add_nonlocal_symbols): Update.
 187         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 188         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 189         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 190         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 191         Change type of "callback".  Remove "data".
 192
 193
 194 2019-09-09  Ali Tamur  <tamur@google.com>
 195
 196         * dwarf2read.c (comp_unit_head): Update comment.
 197         (dwarf2_dwo_name): New function declaration.
 198         (dwarf_unit_type_name): New function declaration.
 199         (read_comp_unit_head): Add support for new compilation units,
 200         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 201         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 202         (currently named as "signature") in their header. Also clarify error
 203         messages.
 204         (lookup_dwo_id): New function. Returns the dwo id of the given
 205         compile unit.
 206         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 207         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 208         functions.
 209         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 210         (dwarf2_dwo_name): Get the dwo name if present.
 211         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 212         purposes.
 213
 214 2019-09-09  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 217
 218 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 219
 220         * python/python.c (do_start_initialization): Make progname_copy static,
 221         to avoid a leak report.
 222
 223 2019-09-08  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 226
 227 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 228
 229         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 230         Change type to gdb::optional<block_enum>.
 231         (dw2_symtab_iter_init): Change block_index parameter type
 232         to gdb::optional<block_enum>.
 233         (dw2_lookup_symbol): Change block_index parameter
 234         type to block_enum.c
 235         (dw2_debug_names_lookup_symbol): Likewise.
 236         * psymtab.c (psym_lookup_symbol): Likewise.
 237         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 238         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 239         Likewise.
 240
 241 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 242
 243         * defs.h (relocate_gdb_directory): Change int to bool in
 244         signature and rename flag to relocatable.
 245         * main.c (relocate_path): Likewise.
 246         (relocate_gdb_directory): Likewise.
 247
 248 2019-09-06  Alan Modra  <amodra@gmail.com>
 249
 250         * coffread.c (coff_symfile_read): Constify filename variable.
 251         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 252         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 253         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 254         * solib.c (reload_shared_libraries_1): Likewise.
 255         * symfile.c (reread_symbols): Likewise.
 256         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 257         * solib-darwin.c (darwin_bfd_open): Likewise.
 258         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 259
 260 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 263         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 264
 265 2019-09-03  Tom Tromey  <tromey@adacore.com>
 266
 267         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 268         types.
 269         (has_negatives): Unbias a range type bound.
 270         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 271         * gdbtypes.c (operator==): Handle new field.
 272         (create_range_type): Add "bias" parameter.
 273         (create_static_range_type, resolve_dynamic_range): Update.
 274         * gdbtypes.h (struct range_bounds) <bias>: New member.
 275         (create_range_type): Add bias parameter.
 276         * printcmd.c (print_scalar_formatted): Unbias range types.
 277         * value.c (unpack_long): Unbias range types.
 278         (pack_long): Bias range types.
 279
 280 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 281
 282         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 283         probe arguments.
 284
 285 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 286
 287         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 288         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 289         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 290         (compile_probe_arg): Likewise.
 291         * probe.h (get_argument_count): Likewise.
 292         * solib-svr4.c (solib_event_probe_action): Likewise.
 293         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 294
 295 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 296
 297         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 298         code to here...
 299         (svr4_create_solib_event_breakpoints): ...from here.
 300
 301 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 302
 303         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 304         suffix from warning message.
 305
 306 2019-08-30  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-winsource.h (struct tui_source_window_base)
 309         <refresh_all>: Don't declare.
 310         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 311         Remove.
 312         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 313         tui_show_locator_content.
 314         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 315         declare.
 316         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 317         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 318         declare.
 319
 320 2019-08-30  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 323
 324 2019-08-30  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 327         Remove unnecessary forward declarations.
 328
 329 2019-08-30  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 332         rerender.
 333         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 334         tui_show_locator_content.
 335
 336 2019-08-30  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 339         (tui_locator_window::rerender): Rewrite using body of previous
 340         tui_show_locator_content.
 341
 342 2019-08-30  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 345         set_locator_fullname>: New methods.
 346         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 347         Rename from tui_set_locator_fullname.
 348         (tui_locator_window::set_locator_info): Rename from
 349         tui_set_locator_info.  Return bool.
 350         (tui_update_locator_fullname, tui_show_frame_info): Update.
 351
 352 2019-08-30  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 355
 356 2019-08-30  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 359         call touchwin.
 360
 361 2019-08-30  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-wingeneral.c (box_win): Assume win_info and
 364         win_info->handle cannot be NULL.
 365
 366 2019-08-30  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 369         refresh_window>: Declare.
 370         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 371         resize.
 372         (tui_data_item_window::rerender): Rename from
 373         tui_display_register.
 374         (tui_data_item_window::refresh_window): New method.
 375         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 376         no-op.
 377
 378 2019-08-30  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 381         regs_column_count, current_group>: Move later.  Now private.
 382         <get_current_group>: New method.
 383         * tui/tui-regs.c (tui_reg_command): Update.
 384         * tui/tui-layout.c (tui_set_layout): Update.
 385
 386 2019-08-30  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 389         (tui_data_window::rerender): Don't call
 390         check_and_display_highlight_if_needed.
 391         (tui_data_window::refresh_all): Remove call to
 392         erase_data_content.
 393
 394 2019-08-30  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 397         (tui_data_window::display_registers_from)
 398         (tui_data_window::display_reg_element_at_line)
 399         (tui_data_window::display_registers_from_line): Remove checks of
 400         "empty".
 401
 402 2019-08-30  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 405         Don't declare.
 406         * tui/tui-regs.c (tui_data_window::show_registers): Call
 407         rerender.
 408         (tui_data_window::rerender): Rename from display_all_data.
 409         (tui_data_window::rerender): Remove old implementation.
 410
 411 2019-08-30  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 414         text.
 415         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 416
 417 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 418             Sergio Durigan Junior  <sergiodj@redhat.com>
 419
 420         PR win32/24284
 421         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 422
 423 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 424
 425         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 426         when searching for types.
 427
 428 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 429
 430         * f-lang.c (f_language_defn): Use f_print_typedef.
 431         * f-lang.h (f_print_typedef): Declare.
 432         * f-typeprint.c (f_print_typedef): Define.
 433
 434 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 435
 436         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 437
 438 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 439
 440         * cli/cli-utils.c (info_print_options_defs): Delete.
 441         (make_info_print_options_def_group): Delete.
 442         (extract_info_print_options): Delete.
 443         (info_print_command_completer): Delete.
 444         (info_print_args_help): Add extra parameter, and optionally
 445         include text about -n flag.
 446         * cli/cli-utils.h (struct info_print_options): Delete.
 447         (extract_info_print_options): Delete declaration.
 448         (info_print_command_completer): Delete declaration.
 449         (info_print_args_help): Add extra parameter, extend header
 450         comment.
 451         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 452         search_symbols.
 453         * stack.c (struct info_print_options): New type.
 454         (info_print_options_defs): New file scoped variable.
 455         (make_info_print_options_def_group): New static function.
 456         (info_print_command_completer): New static function.
 457         (info_locals_command): Update to use new local functions.
 458         (info_args_command): Likewise.
 459         (_initialize_stack): Add extra parameter to calls to
 460         info_print_args_help.
 461         * symtab.c (search_symbols): Add extra parameter, use this to
 462         possibly excluse non-debug symbols.
 463         (symtab_symbol_info): Add extra parameter, which is passed on to
 464         search_symbols.
 465         (struct info_print_options): New type.
 466         (info_print_options_defs): New file scoped variable.
 467         (make_info_print_options_def_group): New static function.
 468         (info_print_command_completer): New static function.
 469         (info_variables_command): Update to use local functions, and pass
 470         extra parameter through to symtab_symbol_info.
 471         (info_functions_command): Likewise.
 472         (info_types_command): Pass additional argument through to
 473         symtab_symbol_info.
 474         (rbreak_command): Pass extra argument to search_symbols.
 475         (_initialize_symtab): Add extra arguments for calls to
 476         info_print_args_help, and update help text for 'info variables',
 477         'whereis', and 'info functions' commands.
 478         * symtab.h (search_symbols): Add extra argument to declaration.
 479         * NEWS: Mention new flags.
 480
 481 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 482
 483         * symtab.c (lookup_static_symbol): Call the new function (and move
 484         it down to be next to lookup_global_symbol).
 485         (struct global_sym_lookup_data): Add block_enum member and rename to...
 486         (struct global_or_static_sym_lookup_data): ...this.
 487         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 488         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 489         (lookup_symbol_global_or_static_iterator_cb): ...this.
 490         (lookup_global_or_static_symbol): New function.
 491         (lookup_global_symbol): Call new function.
 492
 493 2019-08-26  Tom de Vries  <tdevries@suse.de>
 494
 495         PR c++/24852
 496         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 497         when pc_probe.prob == NULL.
 498
 499 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 500
 501         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 502         variable symbol_linkage to symbol_linkage_.
 503
 504 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 505
 506         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 507         represent whether the symbol is static, dynamic, or we don't
 508         know.
 509
 510 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 511
 512         * gdb/rx-tdep.c (rx_register_names): New.
 513         (rx_register_name): Delete.
 514         (rx_psw_type): Delete.
 515         (rx_fpsw_type): Delete.
 516         (rx_register_type): Delete.
 517         (rx_gdbarch_init): Convert target-descriptions.
 518         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 519         * gdb/features/Makefile: Add rx.xml.
 520         * gdb/features/rx.xml: New.
 521         * gdb/features/rx.c: Generated.
 522         * gdb/NEWS: Mention target description support.
 523
 524 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 525
 526         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 527         *slot_ptr.
 528
 529 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 530
 531         * configure.ac: Don't check for 'dlfcn.h' (moved to
 532         gdbsupport/common.m4).
 533         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 534         'gdbsupport/'.
 535         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 536         * compile/compile-c-support.c: Include
 537         'gdbsupport/gdb-dlfcn.h'.
 538         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 539         * gdb-dlfcn.c: Move to...
 540         * gdbsupport/gdb-dlfcn.c: ... here.
 541         * gdb-dlfcn.h: Move to...
 542         * gdbsupport/gdb-dlfcn.h: ... here.
 543
 544 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 545
 546         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 547         the offset field signed.
 548
 549 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 550
 551         * python/lib/gdb/__init__.py (_execute_file): New function.
 552         * python/python.c (python_run_simple_file): Call gdb._execute_file
 553         on Windows.
 554
 555 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 556
 557         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 558         all uses as this was never set to anything but a zero value.
 559
 560 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 561
 562         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 563
 564 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 565
 566         * tui/tui-data.h (tui_gen_win_info): Add an =default
 567         move constructor, required by some GCC versions.
 568
 569 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 570
 571         * go32-nat.c (go32_sysinfo): Add hygon_p.
 572
 573 2019-08-20  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 576         line_from_reg_element_no, first_reg_element_no_inline,
 577         display_all_data, delete_data_content_windows,
 578         erase_data_content>: Now private.
 579
 580 2019-08-20  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 583         (tui_unhighlight_win, tui_highlight_win)
 584         (tui_win_info::make_window): Update.
 585         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 586
 587 2019-08-20  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 590         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 591         (MAX_PID_WIDTH): Move to tui-stack.c.
 592         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 593         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 594         (MAX_PID_WIDTH): Move from tui-data.h.
 595
 596 2019-08-20  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 599         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 600         (box_win): Update.
 601         (tui_gen_win_info::make_window): Rename from tui_make_window.
 602         (tui_win_info::make_window): New method.
 603         (tui_gen_win_info::make_visible): Update.
 604         * tui/tui-source.c (tui_source_window::set_contents): Update.
 605         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 606         (tui_data_window::display_registers_from): Update.
 607         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 608         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 609         Declare.
 610         <can_box>: Remove.
 611         <title>: Remove.
 612         (struct tui_win_info) <make_window>: Declare.
 613         <can_box>: Now virtual.
 614         <title>: New member.
 615         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 616         * tui/tui-command.c (tui_cmd_window::resize): Update.
 617
 618 2019-08-20  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 621         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 622         (tui_data_window::check_register_values): Update.
 623
 624 2019-08-20  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-regs.h (struct tui_data_window): Use
 627         DISABLE_COPY_AND_ASSIGN.
 628         <regs_content>: Change type, removing unique_ptr.
 629         <tui_data_window>: Add move constructor.
 630         * tui/tui-regs.c (tui_data_window::show_registers)
 631         (tui_data_window::show_register_group)
 632         (tui_data_window::display_registers_from)
 633         (tui_data_window::display_registers_from)
 634         (tui_data_window::first_data_item_displayed)
 635         (tui_data_window::delete_data_content_windows)
 636         (tui_data_window::rerender, tui_data_window::refresh_window)
 637         (tui_data_window::check_register_values): Update.
 638
 639 2019-08-20  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 642         show_register_group>: Declare.
 643         (tui_show_register_group): Don't declare.
 644         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 645         tui_show_registers.
 646         (tui_data_window::show_register_group): Rename from
 647         tui_show_register_group.
 648         (tui_data_window::check_register_values, tui_reg_command):
 649         Update.
 650         * tui/tui-layout.c (tui_set_layout): Update.
 651
 652 2019-08-20  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 655         Declare.
 656         (tui_check_register_values): Don't declare.
 657         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 658         from tui_check_register_values.
 659         * tui/tui-hooks.c (tui_register_changed): Update.
 660
 661 2019-08-20  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-regs.c (tui_reg_layout): Move later.
 664         (tui_show_registers): Don't enable TUI mode or change layout.
 665
 666 2019-08-20  Tom Tromey  <tom@tromey.com>
 667
 668         * tui/tui-regs.h (struct tui_data_item_window)
 669         <~tui_data_item_window>: Remove.
 670         <content>: Now a unique_xmalloc_ptr.
 671         * tui/tui-regs.c (tui_register_format): Return a
 672         unique_xmalloc_ptr.
 673         (tui_get_register): Update.
 674         (~tui_data_item_window): Remove.
 675         (tui_data_window::display_registers_from, tui_display_register):
 676         Update.
 677         * tui/tui-io.h (tui_expand_tabs): Update.
 678         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 679         Remove "col" parameter.
 680
 681 2019-08-20  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 684         field.
 685         * tui/tui-regs.c (~tui_data_item_window): Update.
 686
 687 2019-08-20  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 690         earlier.
 691
 692 2019-08-20  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 695
 696 2019-08-20  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui-source.h (struct tui_source_window): Update.
 699         * tui/tui-regs.c (tui_show_registers): Update.
 700         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 701         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 702         (NO_REGS_STRING): Remove defines.
 703
 704 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 705
 706         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 707         unnecessary thread walk if remote doesn't support the packet.
 708
 709 2019-08-19  Tom Tromey  <tromey@adacore.com>
 710
 711         * python/py-value.c (value_has_field): Fix indentation.
 712
 713 2019-08-19  Tom Tromey  <tromey@adacore.com>
 714
 715         * printcmd.c (do_one_display, info_display_command): Update.
 716         * block.h (contained_in): Return bool.  Add allow_nested
 717         parameter.
 718         * block.c (contained_in): Return bool.  Add allow_nested
 719         parameter.
 720
 721 2019-08-19  Tom Tromey  <tom@tromey.com>
 722
 723         * configure: Rebuild.
 724         * configure.ac: Disallow the combination of -static-libstdc++ and
 725         source highlight.
 726         * source-cache.c (get_language_name): Handle rust.
 727         (source_cache::get_source_lines): Ignore highlighting exceptions.
 728
 729 2019-08-16  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 732         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 733         (struct tui_source_window_base) <make_visible, refresh_window,
 734         resize>: Remove methods.
 735         <execution_info>: Remove field.
 736         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 737         (tui_show_source_line, tui_source_window_base)
 738         (~tui_source_window_base): Update.
 739         (tui_source_window_base::resize)
 740         (tui_source_window_base::make_visible)
 741         (tui_source_window_base::refresh_window): Remove.
 742         (tui_source_window_base::update_exec_info): Update.
 743         * tui/tui-source.c (tui_source_window::set_contents): Update.
 744         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 745
 746 2019-08-16  Tom Tromey  <tom@tromey.com>
 747
 748         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 749         deprecated_query_hook.
 750
 751 2019-08-16  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 754         (tui_update_source_windows_with_line): Update.
 755         * tui/tui-source.h (struct tui_source_window)
 756         <show_symtab_source>: Declare.
 757         (tui_show_symtab_source): Don't declare.
 758         * tui/tui-source.c (tui_show_symtab_source): Rename from
 759         tui_show_symtab_source.
 760
 761 2019-08-16  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-winsource.h (struct tui_source_window_base)
 764         <set_contents>: Declare.
 765         * tui/tui-winsource.c
 766         (tui_source_window_base::update_source_window_as_is): Update.
 767         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 768         Declare.
 769         (tui_set_source_content): Don't declare.
 770         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 771         tui_set_source_content.
 772         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 773         Declare.
 774         (tui_set_disassem_content): Don't declare.
 775         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 776         tui_set_disassem_content.
 777
 778 2019-08-16  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-winsource.h (struct tui_source_window_base)
 781         <update_breakpoint_info>: Declare.
 782         (tui_update_breakpoint_info): Don't declare.
 783         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 784         (tui_update_all_breakpoint_info): Update.
 785         (tui_source_window_base::update_breakpoint_info): Rename from
 786         tui_update_breakpoint_info.
 787         (tui_source_window_base::update_exec_info): Update.
 788
 789 2019-08-16  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-winsource.h (struct tui_source_window_base)
 792         <update_source_window>: Declare.
 793         (tui_update_source_window): Don't declare.
 794         * tui/tui-winsource.c
 795         (tui_source_window_base::update_source_window): Rename from
 796         tui_update_source_window.
 797         (tui_source_window_base::rerender): Update.
 798         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 799         * tui/tui-disasm.c (tui_show_disassem)
 800         (tui_show_disassem_and_update_source)
 801         (tui_disasm_window::maybe_update): Update.
 802
 803 2019-08-16  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-winsource.h (struct tui_source_window_base)
 806         <update_source_window_as_is>: Declare.
 807         (tui_update_source_window_as_is): Don't declare.
 808         * tui/tui-winsource.c (tui_update_source_window): Update
 809         (tui_source_window_base::update_source_window_as_is): Rename from
 810         tui_update_source_window_as_is.
 811         (tui_source_window_base::refill): Update.
 812         * tui/tui-source.c (tui_show_symtab_source): Update.
 813         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 814         Update.
 815
 816 2019-08-16  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-winsource.h (tui_update_source_window)
 819         (tui_update_source_window_as_is): Remove "noerror" parameter.
 820         * tui/tui-winsource.c (tui_update_source_window)
 821         (tui_update_source_window_as_is): Remove "noerror" parameter.
 822         (tui_update_source_windows_with_addr)
 823         (tui_update_source_windows_with_line)
 824         (tui_source_window_base::rerender)
 825         (tui_source_window_base::refill): Update.
 826         * tui/tui-source.h (tui_set_source_content)
 827         (tui_show_symtab_source): Remove "noerror" parameter.
 828         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 829         parameter.
 830         (tui_show_symtab_source): Likewise.
 831         (tui_source_window::maybe_update): Update.
 832         * tui/tui-disasm.c (tui_show_disassem)
 833         (tui_show_disassem_and_update_source)
 834         (tui_disasm_window::do_scroll_vertical)
 835         (tui_disasm_window::maybe_update): Update.
 836
 837 2019-08-16  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui.c (tui_is_window_visible): Update.
 840         * tui/tui-wingeneral.c (tui_make_window)
 841         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 842         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 843         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 844         (tui_set_win_height_command, parse_scrolling_args): Update.
 845         * tui/tui-source.c (tui_source_window::style_changed): Update.
 846         * tui/tui-regs.c (tui_show_registers)
 847         (tui_data_window::first_data_item_displayed)
 848         (tui_data_window::delete_data_content_windows)
 849         (tui_check_register_values, tui_reg_command): Update.
 850         * tui/tui-disasm.c (tui_show_disassem): Update.
 851         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 852         method.
 853         <is_visible>: Remove field.
 854         * tui/tui-data.c (tui_next_win, tui_prev_win)
 855         (tui_delete_invisible_windows): Update.
 856
 857 2019-08-16  Tom Tromey  <tom@tromey.com>
 858
 859         * tui/tui-winsource.h (struct tui_source_window_base)
 860         <m_has_locator>: Remove.
 861         * tui/tui-layout.c (show_source_disasm_command, show_data)
 862         (show_source_or_disasm_and_command): Update.
 863
 864 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 865
 866         * NEWS (Other MI changes): New subsection.
 867         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 868         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 869         * arch-utils.c (default_get_pc_address_flags): New function.
 870         * arch-utils.h (default_get_pc_address_flags): New declaration.
 871         * gdbarch.sh: Add get_pc_address_flags.
 872         * gdbarch.c: Regenerate.
 873         * gdbarch.h: Likewise.
 874         * stack.c (print_pc): New function.
 875         (print_frame_info) (print_frame): Call print_pc.
 876
 877 2019-08-16  Tom de Vries  <tdevries@suse.de>
 878
 879         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 880         print_objfile_section_info.
 881
 882 2019-08-15  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 885         calling update_cmdwin_start_line.
 886         * tui/tui-winsource.h (struct tui_source_window_base)
 887         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 888         <rerender>: Declare.
 889         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 890         Call rerender.
 891         (tui_source_window_base::set_new_height): Remove.
 892         (tui_source_window_base::rerender): Rename from
 893         do_make_visible_with_new_height.
 894         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 895         resize method.
 896         (tui_win_info::make_invisible_and_set_new_height)
 897         (tui_win_info::make_visible_with_new_height): Remove.
 898         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 899         Declare.
 900         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 901         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 902         do_make_visible_with_new_height>: Don't declare.
 903         <rerender>: Declare.
 904         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 905         set_new_height.
 906         (tui_data_window::do_make_visible_with_new_height): Remove.
 907         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 908         call tui_show_locator_content.
 909         (tui_gen_win_info::resize): Call rerender.
 910         (show_source_or_disasm_and_command): Don't call
 911         tui_show_locator_content.
 912         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 913         method.
 914         (struct tui_win_info) <rerender>: Declare.
 915         <set_new_height, make_invisible_and_set_new_height,
 916         make_visible_with_new_height>: Don't declare.
 917         * tui/tui-data.c (tui_win_list::rerender): New method.
 918         * tui/tui-command.h (struct tui_cmd_window)
 919         <do_make_visible_with_new_height>: Don't declare.
 920         * tui/tui-command.c
 921         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 922
 923 2019-08-15  Tom Tromey  <tromey@adacore.com>
 924
 925         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 926         * ada-lang.c (ada_enum_name): Likewise.
 927
 928 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 929
 930         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 931         leading underscore.
 932         (GdbOutputErrorFile): Likewise.
 933         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 934         accordingly.
 935         (execute_unwinders): Rename to have a leading underscore.
 936         (auto_load_packages): Likewise.
 937         (global scope): Adjust call to auto_load_packages accordingly.
 938         (GdbSetPythonDirectory): Likewise.
 939         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 940         instead of execute_unwinders.
 941
 942 2019-08-15  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 945         (show_data): Don't change window visibility.
 946         (tui_gen_win_info::resize): Remove special case for command
 947         window.  Use wresize, when available.
 948         (show_source_or_disasm_and_command): Don't change window
 949         visibility.
 950         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 951         <make_visible>: New method.
 952         * tui/tui-command.c (tui_cmd_window::resize): New method.
 953
 954 2019-08-15  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 957         (struct tui_source_windows): New.
 958         * tui/tui-winsource.c (tui_display_main): Update.
 959         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 960         (new_height_ok, parse_scrolling_args): Update.
 961         * tui/tui-layout.c (show_layout, show_data): Update.
 962         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 963         (tui_add_to_source_windows): Don't declare.
 964         * tui/tui-data.c (source_windows, tui_source_windows)
 965         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 966
 967 2019-08-15  Tom Tromey  <tom@tromey.com>
 968
 969         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 970         Rename from reset.
 971         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 972         * tui/tui-layout.c (show_source_disasm_command, show_data):
 973         Update.
 974         (tui_gen_win_info::resize): Rename.
 975         (show_source_or_disasm_and_command): Update.
 976         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 977         reset.
 978
 979 2019-08-15  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 982         * tui/tui-interp.c (tui_interp::init): Don't call
 983         tui_initialize_static_data.
 984         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 985
 986 2019-08-15  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 989         examine tui_win_list.
 990
 991 2019-08-15  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 994         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 995         tui_clear_source_content.
 996         (tui_clear_source_content): Remove.
 997         (tui_source_window_base::do_erase_source_content): Hoist call to
 998         content.clear().
 999         * tui/tui-stack.c (tui_show_frame_info): Don't call
1000         tui_clear_source_content.
1001
1002 2019-08-15  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-winsource.h (struct tui_source_window_base)
1005         <do_erase_source_content>: New method.
1006         <erase_source_content>: New method.
1007         (tui_erase_source_content): Don't declare.
1008         * tui/tui-winsource.c (tui_clear_source_content): Update.
1009         (tui_source_window_base::do_erase_source_content): Rename from
1010         tui_erase_source_content.
1011         (tui_source_window_base::show_source_content): Update.
1012         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1013         * tui/tui-source.h (struct tui_source_window)
1014         <erase_source_content>: New method.
1015         * tui/tui-disasm.h (struct tui_disasm_window)
1016         <erase_source_content>: New method.
1017
1018 2019-08-15  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1021         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1022         constructor.
1023         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1024         * tui/tui-source.c (tui_set_source_content): Update.
1025         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1026
1027 2019-08-15  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1030         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1031         tui-source.c.
1032         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1033         Declare.
1034         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1035         method.
1036         (tui_source_window::maybe_update): Update.
1037
1038 2019-08-15  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1041         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1042         tui-disasm.c.
1043         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1044         Declare.
1045         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1046         method.
1047         (tui_disasm_window::maybe_update): Update.
1048
1049 2019-08-15  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-winsource.h (struct tui_source_window_base)
1052         <maybe_update>: Declare.
1053         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1054         method.
1055         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1056         Declare.
1057         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1058         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1059         Declare.
1060         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1061
1062 2019-08-15  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1065
1066 2019-08-15  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-wingeneral.c: Include tui-stack.h.
1069         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1070         (struct tui_locator_window): Move from tui-data.h.
1071         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1072         (tui_initialize_static_data): Move from tui-data.c.
1073         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1074         (struct tui_locator_window): Move to tui-stack.c.
1075         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1076         (tui_initialize_static_data): Move to tui-stack.c.
1077
1078 2019-08-15  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui-layout.c (show_source_disasm_command)
1081         (show_source_or_disasm_and_command): Use make_visible method, not
1082         tui_make_window.
1083         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1084         Remove.
1085
1086 2019-08-15  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-wingeneral.h (tui_make_window): Update.
1089         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1090         parameter.
1091         (tui_gen_win_info::make_visible): Update.
1092         * tui/tui-regs.c (tui_data_window::display_registers_from):
1093         Update.
1094         * tui/tui-layout.c (show_source_disasm_command)
1095         (show_source_or_disasm_and_command): Update.
1096         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1097         (enum tui_box): Remove.
1098         (struct tui_win_info) <can_box>: New method.
1099         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1100         method.
1101
1102 2019-08-15  Tom de Vries  <tdevries@suse.de>
1103
1104         * linux-nat-trad.c: Include gdbarch.h.
1105
1106 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1107
1108         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1109         register sizes.
1110
1111 2019-08-14  Tom Tromey  <tromey@adacore.com>
1112
1113         * darwin-nat.c: Include gdbarch.h.
1114         * darwin-nat-info.c: Include gdbarch.h.
1115
1116 2019-08-13  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1119         Remove.
1120         * tui/tui-data.c (tui_initialize_static_data): Update.
1121
1122 2019-08-13  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-winsource.h (struct tui_exec_info_window)
1125         <~tui_exec_info_window, maybe_allocate_content, get_content,
1126         m_content>: Remove.
1127         (struct tui_source_window_base) <set_exec_info_content,
1128         show_exec_info_content>: Don't declare.
1129         * tui/tui-winsource.c
1130         (tui_exec_info_window::maybe_allocate_content): Remove.
1131         (tui_source_window_base::update_exec_info): Rename from
1132         set_exec_info_content.
1133         (tui_source_window_base::show_exec_info_content)
1134         (tui_source_window_base::update_exec_info): Remove.
1135
1136 2019-08-13  Tom Tromey  <tom@tromey.com>
1137
1138         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1139         declare.
1140         * tui/tui-winsource.c (tui_update_source_window_as_is)
1141         (tui_update_source_windows_with_addr, tui_erase_source_content):
1142         Update.
1143         (tui_clear_exec_info_content): Remove.
1144
1145 2019-08-13  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1148         declare.
1149         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1150         call tui_erase_exec_info_content.
1151         (tui_clear_exec_info_content): Rename from
1152         tui_erase_exec_info_content.
1153         (tui_clear_exec_info_content): Delete.
1154
1155 2019-08-13  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-winsource.h (struct tui_source_window_base)
1158         <show_exec_info_content>: Declare.
1159         (tui_show_exec_info_content): Don't declare.
1160         * tui/tui-winsource.c
1161         (tui_source_window_base::show_exec_info_content): Rename from
1162         tui_show_exec_info_content.
1163         (tui_source_window_base::update_exec_info): Update.
1164
1165 2019-08-13  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1168         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1169         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1170         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1171         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1172         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1173         ... here.
1174
1175 2019-08-13  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-winsource.h (struct tui_source_window_base)
1178         <update_exec_info>: Declare.
1179         (tui_update_exec_info): Don't declare.
1180         * tui/tui-winsource.c (tui_update_source_window_as_is)
1181         (tui_source_window_base::refresh_all)
1182         (tui_update_all_breakpoint_info): Update.
1183         (tui_source_window_base::update_exec_info): Rename from
1184         tui_update_exec_info.
1185         * tui/tui-stack.c (tui_show_frame_info): Update.
1186
1187 2019-08-13  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-winsource.h (struct tui_source_window_base)
1190         <set_exec_info_content>: Declare.
1191         (tui_set_exec_info_content): Don't declare.
1192         * tui/tui-winsource.c
1193         (tui_source_window_base::set_exec_info_content): Rename from
1194         tui_set_exec_info_content.
1195         (tui_update_exec_info): Update.
1196
1197 2019-08-13  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-winsource.h (struct tui_source_window_base)
1200         <show_source_content>: Declare.
1201         (tui_show_source_content): Don't declare.
1202         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1203         (tui_source_window_base::show_source_content): Rename from
1204         tui_show_source_content.
1205         (tui_source_window_base::refresh_all): Update.
1206         * tui/tui-layout.c (show_source_disasm_command)
1207         (show_source_or_disasm_and_command): Update.
1208
1209 2019-08-13  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-winsource.c (tui_erase_source_content)
1212         (tui_show_source_content, tui_source_window_base::refresh_all):
1213         Update.
1214         * tui/tui-wingeneral.h
1215         (tui_check_and_display_highlight_if_needed): Don't declare.
1216         * tui/tui-wingeneral.c
1217         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1218         check_and_display_highlight_if_needed.
1219         * tui/tui-win.c (tui_rehighlight_all)
1220         (tui_win_info::make_visible_with_new_height): Update.
1221         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1222         (tui_data_window::erase_data_content)
1223         (tui_data_window::display_all_data): Update.
1224         * tui/tui-data.h (struct tui_win_info)
1225         <check_and_display_highlight_if_needed>: Declare.
1226
1227 2019-08-13  Tom Tromey  <tom@tromey.com>
1228
1229         * tui/tui-win.c (tui_resize_all): Call
1230         tui_delete_invisible_windows.
1231         * tui/tui-layout.c (show_layout): Call
1232         tui_delete_invisible_windows.
1233         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1234         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1235
1236 2019-08-13  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1239         tui_add_win_to_layout.
1240
1241 2019-08-13  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1244         * tui/tui-layout.c (tui_default_win_height): Now static.
1245
1246 2019-08-13  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1249         single switch.
1250         (show_source_disasm_command, show_source_or_disasm_and_command):
1251         Don't check current layout.
1252
1253 2019-08-13  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-wingeneral.c (make_all_visible): Remove.
1256         (tui_make_all_invisible): Simplify.
1257         * tui/tui-layout.c (tui_make_all_invisible): Move from
1258         tui-wingeneral.c; simplify.
1259         (show_layout): Hoist call to tui_make_all_invisible.
1260         (show_data): Don't call tui_make_all_invisible.
1261
1262 2019-08-13  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1265         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1266
1267 2019-08-13  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1270         tui-data.c.
1271         (show_source_disasm_command, show_data)
1272         (show_source_or_disasm_and_command): Don't use
1273         tui_set_current_layout_to.
1274         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1275         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1276         tui-layout.c.
1277         (tui_set_current_layout_to): Remove.
1278
1279 2019-08-13  Tom Tromey  <tom@tromey.com>
1280
1281         * tui/tui-layout.c (tui_set_layout): Update.
1282         * tui/tui-data.h (struct tui_layout_def): Remove.
1283         (tui_layout_def): Don't declare.
1284         * tui/tui-data.c (layout_def): Remove.
1285         (tui_layout_def): Remove.
1286
1287 2019-08-13  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-winsource.h (struct tui_source_window_base)
1290         <clear_detail>: No longer "override".
1291         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1292         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1293         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1294         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1295         Remove.
1296         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1297
1298 2019-08-13  Tom Tromey  <tromey@adacore.com>
1299
1300         * tracepoint.c: Don't include readline.h or history.h.
1301
1302 2019-08-12  Tom Tromey  <tom@tromey.com>
1303
1304         * configure: Rebuild.
1305         * configure.ac: Check for readline 7.
1306         * NEWS: Mention readline 7 requirement.
1307         * README: Update.
1308
1309 2019-08-12  Tom Tromey  <tom@tromey.com>
1310
1311         * mingw-hdep.c (gdb_select): Remove readline hack.
1312
1313 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1314
1315         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1316         when the function fails.
1317
1318 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1319
1320         * s390-tdep.c (s390_type_align): New function.
1321         (s390_gdbarch_init): Set it as type_align gdbarch method.
1322
1323 2019-08-09  Tom de Vries  <tdevries@suse.de>
1324
1325         PR gdb/24591
1326         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1327         pc_low with relocation offset.
1328
1329 2019-08-07  Tom Tromey  <tromey@adacore.com>
1330
1331         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1332         (print_frame_args): Update.
1333         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1334         Update.
1335         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1336         * frame.h (struct frame_arg): Add initializers.
1337         <error>: Now a unique_xmalloc_ptr.
1338
1339 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1340
1341         * NEWS: Expand the Pointer Authentication entry.
1342         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1343         (aarch64_frame_unmask_lr): ... to this.
1344         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1345         Call aarch64_frame_unmask_lr.
1346         * frame.c (struct frame_info): Add "masked" variable.
1347         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1348         (fprint_frame): Check for masked pc.
1349         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1350         declarations.
1351         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1352         * stack.c (print_frame): Check for masked pc.
1353
1354 2019-08-06  Tom Tromey  <tom@tromey.com>
1355
1356         * stabsread.c (patch_block_stabs, read_one_struct_field)
1357         (read_enum_type): Use obstack_strndup.
1358         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1359         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1360         * dwarf2read.c (guess_full_die_structure_name)
1361         (anonymous_struct_prefix): Use obstack_strndup.
1362         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1363         * c-exp.y (yylex): Use obstack_strndup.
1364         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1365         (write_var_or_type): Use obstack_strndup.
1366
1367 2019-08-06  Tom Tromey  <tom@tromey.com>
1368
1369         * symfile.c (reread_symbols): Use obstack_strdup.
1370         * stabsread.c (read_type): Use obstack_strdup.
1371         * gdb_obstack.h (obstack_strdup): New overload.
1372         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1373         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1374         (dwarf2_canonicalize_name): Use obstack_strdup.
1375         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1376         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1377         Use obstack_strdup.
1378
1379 2019-08-06  Tom Tromey  <tom@tromey.com>
1380
1381         * gdb_obstack.h (obstack_strdup): Define.
1382         * gdb_obstack.c (obstack_strdup): Don't define.
1383
1384 2019-08-06  Tom Tromey  <tom@tromey.com>
1385
1386         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1387         obstack_strdup.
1388         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1389         obstack_strdup.
1390         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1391         * stabsread.c (common_block_start): Use obstack_strdup.
1392         * objfiles.c (set_objfile_main_name, objfile): Use
1393         obstack_strdup.
1394         * namespace.c (add_using_directive): Use obstack_strdup.
1395         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1396         * jit.c (finalize_symtab): Use obstack_strdup.
1397         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1398         (guess_partial_die_structure_name, partial_die_info::fixup)
1399         (dwarf2_name): Use obstack_strdup.
1400         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1401         obstack_strdup.
1402         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1403         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1404         obstack_strdup.
1405         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1406
1407 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1408
1409         * unittests/help-doc-selftests.c: New file.
1410         * Makefile.in: Add the new file.
1411
1412 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1413
1414         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1415         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1416         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1417         the trailing '.' is not output, and the first character is uppercased.
1418         (print_help_for_command): Update call to print_doc_line.
1419         (print_doc_of_command): Likewise.
1420         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1421         * cli/cli-option.c (append_indented_doc): Do not append newline.
1422         (build_help_option): Append newline after first appended_indented_doc
1423         only if a second call is done.
1424         (build_help): Append 2 new lines before each option, except the first
1425         one.
1426         * compile/compile.c (_initialize_compile): Add new lines after
1427         %OPTIONS%, when not at the end of the help.
1428         Change help doc or code
1429         producing the help doc to respect the invariants.
1430         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1431         Also removed the new line after 'Options:', as all other commands
1432         do not put an empty line between 'Options:' and the first option.
1433         * printcmd.c (_initialize_printcmd): Likewise.
1434         * stack.c (_initialize_stack): Likewise.
1435         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1436         incorrectly telling COMMAND is optional.
1437         * ada-lang.c (_initialize_ada_language): Change help doc or code
1438         producing the help doc to respect the invariants.
1439         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1440         * breakpoint.c (_initialize_breakpoint): Likewise.
1441         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1442         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1443         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1444         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1445         _initialize_cli_style): Likewise.
1446         * corelow.c (core_target_info): Likewise.
1447         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1448         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1449         * filesystem.c (_initialize_filesystem): Likewise.
1450         * frame.c (_initialize_frame): Likewise.
1451         * gnu-nat.c (add_task_commands): Likewise.
1452         * infcall.c (_initialize_infcall): Likewise.
1453         * infcmd.c (_initialize_infcmd): Likewise.
1454         * interps.c (_initialize_interpreter): Likewise.
1455         * language.c (_initialize_language): Likewise.
1456         * linux-fork.c (_initialize_linux_fork): Likewise.
1457         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1458         * maint.c (_initialize_maint_cmds): Likewise.
1459         * memattr.c (_initialize_mem): Likewise.
1460         * printcmd.c (_initialize_printcmd): Likewise.
1461         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1462         _RegEx): Likewise.
1463         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1464         * record-btrace.c (_initialize_record_btrace): Likewise.
1465         * record-full.c (_initialize_record_full): Likewise.
1466         * record.c (_initialize_record): Likewise.
1467         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1468         * regcache.c (_initialize_regcache): Likewise.
1469         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1470         _initialize_remote): Likewise.
1471         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1472         * serial.c (_initialize_serial): Likewise.
1473         * skip.c (_initialize_step_skip): Likewise.
1474         * source.c (_initialize_source): Likewise.
1475         * stack.c (_initialize_stack): Likewise.
1476         * symfile.c (_initialize_symfile): Likewise.
1477         * symtab.c (_initialize_symtab): Likewise.
1478         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1479         * top.c (init_main): Likewise.
1480         * tracefile-tfile.c (tfile_target_info): Likewise.
1481         * tracepoint.c (_initialize_tracepoint): Likewise.
1482         * tui/tui-win.c (_initialize_tui_win): Likewise.
1483         * utils.c (add_internal_problem_command): Likewise.
1484         * valprint.c (value_print_option_defs): Likewise.
1485
1486 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1487
1488         PR build/24886
1489         * configure.ac: Drop enable-libmcheck support.
1490         * configure, config.in: Rebuild.
1491         * libmcheck.m4: Remove.
1492         * acinclude.m4: Don't include it.
1493         * Makefile.in: Don't distribute it.
1494         * top.c (print_gdb_configuration): Don't mention it.
1495
1496 2019-08-06  Tom Tromey  <tom@tromey.com>
1497
1498         * utils.c (set_output_style): Sometimes pass stream to
1499         emit_style_escape.
1500         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1501         * record-btrace.c (btrace_insn_history): Update.
1502         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1503         method.
1504         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1505         Update initializers.
1506         <m_uiout>: New field.
1507         <m_di>: Move lower.
1508         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1509         Remove "uiout" parameter.
1510         (dump_insns): Update.
1511         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1512         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1513
1514 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1515
1516         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1517         (error_in_psymtab_expansion): Likewise.
1518         (lookup_symbol_via_quick_fns): Likewise.
1519         (basic_lookup_transparent_type_quick): Likewise.
1520         (basic_lookup_transparent_type_1): Likewise.
1521
1522 2019-08-06  Tom Tromey  <tromey@adacore.com>
1523
1524         * source.c (last_source_error): Now bool.
1525         (print_source_lines_base): Make "noprint" bool.  Only open
1526         source file when last_source_visited changes.
1527
1528 2019-08-06  Tom Tromey  <tromey@adacore.com>
1529
1530         * annotate.c (annotate_source_line): Use g_source_cache.
1531         * source-cache.c (source_cache::get_plain_source_lines): Change
1532         parameters.  Populate m_offset_cache.
1533         (source_cache::ensure): New method.
1534         (source_cache::get_line_charpos): New method.
1535         (extract_lines): Move lower.  Change parameters.
1536         (source_cache::get_source_lines): Move lower.
1537         * source-cache.h (class source_cache): Update comment.
1538         <get_line_charpos>: New method.
1539         <get_source_lines>: Update comment.
1540         <clear>: Clear m_offset_cache.
1541         <get_plain_source_lines>: Change parameters.
1542         <ensure>: New method
1543         <m_offset_cache>: New member.
1544         * source.c (forget_cached_source_info_for_objfile): Update.
1545         (info_source_command): Use g_source_cache.
1546         (find_source_lines, open_source_file_with_line_charpos): Remove.
1547         (print_source_lines_base, search_command_helper): Use g_source_cache.
1548         * source.h (open_source_file_with_line_charpos): Don't declare.
1549         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1550         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1551         Use g_source_cache.
1552
1553 2019-08-06  Tom Tromey  <tromey@adacore.com>
1554
1555         * source-cache.c (source_cache::get_plain_source_lines):
1556         Remove "first_line" and "last_line" parameters.
1557         (source_cache::get_source_lines): Cache plain text.
1558         * source-cache.h (class source_cache)
1559         <get_plain_source_lines>: Update.
1560
1561 2019-08-06  Tom Tromey  <tromey@adacore.com>
1562
1563         * source-cache.c (extract_lines): No longer a method.
1564         Changed type of parameter.  Include final newline.
1565         (selftests::extract_lines_test): New function.
1566         (_initialize_source_cache): Likewise.
1567         * source-cache.h (class source_cache)
1568         <extract_lines>: Don't declare.
1569
1570 2019-08-06  Tom Tromey  <tromey@adacore.com>
1571
1572         * breakpoint.c (init_breakpoint_sal): Update.
1573         (breakpoint): Update.
1574         * breakpoint.h (struct breakpoint) <filter>: Now a
1575         unique_xmalloc_ptr.
1576
1577 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1578
1579         * NEWS: Mention dictionary access on blocks.
1580         * python/py-block.c (blpy_getitem): New function.
1581         (block_object_as_mapping): New struct.
1582         (block_object_type): Use new struct for tp_as_mapping field.
1583
1584 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1585
1586         * objfiles.h (objfile): Add a comment describing partial symbols.
1587
1588 2019-08-05  Tom Tromey  <tromey@adacore.com>
1589
1590         * compile/compile.c (_initialize_compile): Use _(), not N_().
1591         * thread.c (_initialize_thread): Use _(), not N_().
1592         * stack.c (_initialize_stack): Use _(), not N_().
1593         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1594
1595 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1596
1597         * dwarf2read.c (struct dw2_symtab_iterator):
1598         <want_specific_block>: Remove.
1599         <block_index>: Change type to gdb::optional.
1600         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1601         change type of BLOCK_INDEX parameter to gdb::optional.
1602         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1603         (dw2_lookup_symbol): Don't pass argument for
1604         WANT_SPECIFIC_BLOCK.
1605         (dw2_expand_symtabs_for_function): Don't pass argument for
1606         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1607         (class dw2_debug_names_iterator)
1608         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1609         parameter, change BLOCK_INDEX type to gdb::optional.
1610         <m_want_specific_block>: Remove.
1611         <m_block_index>: Change type to gdb::optional.
1612         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1613         gdb::optional.  Re-write in function of gdb::optional.
1614         (dw2_debug_names_lookup_symbol): Don't pass argument for
1615         WANT_SPECIFIC_BLOCK.
1616         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1617         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1618         BLOCK_INDEX.
1619
1620 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1621
1622         * NEWS: Mention changes to "info sources" command.
1623
1624 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1625
1626         * symtab.c (filename_partial_match_opts): New struct type.
1627         (struct output_source_filename_data): New members
1628         regexp, c_regexp, partial_match.
1629         (output_source_filename): Use new members to decide to print file.
1630         (info_sources_option_defs): New variable.
1631         (make_info_sources_options_def_group, print_info_sources_header,
1632         info_sources_command_completer):
1633         New functions.
1634         (info_sources_command): Read new optional arguments.
1635         (_initialize_symtab): Update info sources help.
1636
1637 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1638
1639         * ada-lang.c (exception_support_info_v0): Renamed from...
1640         (default_exception_support_info): ... this.  Create new
1641         definition for v1.
1642         (ada_has_this_exception_support): Look up catch_handlers_sym.
1643         (ada_exception_support_info_sniffer): Try v0 after default.
1644
1645 2019-08-01  Tom Tromey  <tromey@adacore.com>
1646
1647         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1648         gdbarch.h.
1649
1650 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1651
1652         * s12z-tdep.c: Fix include path for s12z-opc.h.
1653
1654 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1655
1656         * NEWS: Require GNU make 3.82.
1657
1658 2019-07-16  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1661         declare.
1662
1663 2019-07-30  Tom Tromey  <tromey@adacore.com>
1664
1665         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1666
1667 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1668
1669         * printcmd.c (print_address_symbolic): Print negative offsets.
1670         (build_address_symbolic): Force signed arithmetic when computing
1671         offset.
1672
1673 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1674
1675         PR/24474: Add a function to lookup static variables.
1676         * NEWS: Mention this new function.
1677         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1678         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1679         * python/python.c (python_GdbMethods): Add new function.
1680
1681 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1682
1683         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1684         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1685         (objfpy_lookup_static_symbol): New function.
1686         (objfile_object_methods): Add new functions.
1687
1688 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1689
1690         * NEWS: Mention 'set|show print frame-info'.  Mention new
1691         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1692         backtrace argument.  Mention that python frame filtering code
1693         is now consistent with what 'backtrace' command prints.
1694
1695 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1696
1697         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1698         comments.
1699         (print_frame_info_auto, print_frame_info_source_line,
1700         print_frame_info_location, print_frame_info_source_and_location,
1701         print_frame_info_location_and_address, print_frame_info_short_location):
1702         New declarations.
1703         (struct frame_print_options): New member print_frame_info.
1704         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1705         * stack.h (get_user_print_what_frame_info): New declaration.
1706         (frame_show_address): New declaration.
1707         * stack.c (print_frame_arguments_choices): New value 'presence'.
1708         (print_frame_info_auto, print_frame_info_source_line,
1709         print_frame_info_location, print_frame_info_source_and_location,
1710         print_frame_info_location_and_address, print_frame_info_short_location,
1711         print_frame_info_choices, print_frame_info_print_what): New definitions.
1712         (print_frame_args): Only print dots for args if print frame-arguments
1713         is 'presence'.
1714         (frame_print_option_defs): New element for "frame-info".
1715         (get_user_print_what_frame_info): New function.
1716         (frame_show_address): Make non static.  Move comment to stack.h.
1717         (print_frame_info_to_print_what): New function.
1718         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1719         to decide what to print.
1720         (backtrace_command_1): Handle the new print_frame_arguments_presence
1721         value.
1722         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1723         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1724         (py_print_frame): In non-mi mode, use LOCATION as default for
1725         print_what, similarly to frame information printed directly by
1726         backtrace command. Handle frame-info user option in non MI mode.
1727
1728 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1729
1730         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1731         Add case for debugging 32-bit target on 64-bit host.  Revise
1732         comment.
1733
1734 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1735
1736         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1737         instead of find_function_entry_range_from_pc.
1738
1739 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1740
1741         * stack.c (find_frame_funname): Remove code which preferred
1742         minsym over symtab sym in "certain pathological cases".
1743
1744         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1745         parameter.  Change type of "do_demangle" to bool.
1746         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1747         Pass suitable "prefer_sym_over_minsym" flag to
1748         build_address_symbolic().  Don't output "+" for negative offsets.
1749         * printcmd.c (print_address_symbolic): Update invocation of
1750         build_address_symbolic to include a "prefer_sym_over_minsym"
1751         flag.
1752         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1753         Restrict cases in which use of minimal symbol is preferred to that
1754         of a found symbol.  Update comments.
1755
1756         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1757         for entry pc when entry pc is out of range for that FDE.
1758
1759 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1760
1761         PR gdb/24839:
1762         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1763         type.
1764
1765 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1766
1767         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1768         this function's Python signature.
1769
1770
1771 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1772
1773         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1774         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1775         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1776         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1777         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1778
1779
1780 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1781
1782         * h8300-tdep.c (h8300_register_name_common): New.
1783         h8300_register_name): Use h8300_register_name_common.
1784         (h8300s_register_name): Likewise.
1785         (h8300sx_register_name): Likewise.
1786         (h8300h_register_nam): New.
1787         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1788
1789
1790 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1791
1792         * arm-tdep.c (arm_skip_cmse_entry): New function.
1793         (arm_is_sgstubs_section): New function.
1794         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1795
1796 2019-07-22  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1799         Don't self-assign.
1800
1801 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1802
1803         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1804         type_print.
1805
1806 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1807
1808         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1809         so that GDB doesn't match any msymbols when searching in the
1810         TYPES_DOMAIN.
1811         (print_symbol_info): Print using typedef_print or type_print based
1812         on the type of the symbol.  Add updated FIXME comment moved from...
1813         (_initialize_symtab): ... move and update FIXME comment to above.
1814
1815 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1816
1817         * NEWS: Mention adding -q option to "info types".
1818         * symtab.c (struct info_types_options): New struct.
1819         (info_types_options_defs): New variable.
1820         (make_info_types_options_def_group): New function.
1821         (info_types_command): Use gdb::option framework to parse options.
1822         (info_types_command_completer): New function.
1823         (_initialize_symtab): Extend the help text on "info types" and
1824         register command completer.
1825
1826 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1827
1828         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1829         (lookup_symbol_in_objfile): Change int to block_enum and add a
1830         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1831
1832 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1833
1834         * MAINTAINERS (Write After Approval): Add self.
1835
1836 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1837
1838         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1839         instruction to the dummy code region.
1840
1841 2019-07-19  Tom Tromey  <tromey@adacore.com>
1842
1843         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1844         (ARGSUSED, PARAMS, __func__): Remove rules.
1845
1846 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1847
1848         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1849         * features/arm/arm-with-iwmmxt.c: Remove.
1850         * features/arm/arm-with-iwmmxt.xml: Remove.
1851         * features/arm/arm-with-m-fpa-layout.c: Remove.
1852         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1853         * features/arm/arm-with-m-vfp-d16.c: Remove.
1854         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1855         * features/arm/arm-with-m.c: Remove.
1856         * features/arm/arm-with-m.xml: Remove.
1857         * features/arm/arm-with-neon.c: Remove.
1858         * features/arm/arm-with-neon.xml: Remove.
1859         * features/arm/arm-with-vfpv2.c: Remove.
1860         * features/arm/arm-with-vfpv2.xml: Remove.
1861         * features/arm/arm-with-vfpv3.c: Remove.
1862         * features/arm/arm-with-vfpv3.xml: Remove.
1863
1864 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1865
1866         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1867
1868 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1869
1870         * arch/aarch32.c (aarch32_create_target_description): Create
1871         target descriptions using features.
1872         * arch/arm.c (arm_create_target_description)
1873         (arm_create_mprofile_target_description): Likewise.
1874         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1875
1876 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1877
1878         * Makefile.in: Add new files.
1879         * aarch32-tdep.c: New file.
1880         * aarch32-tdep.h: New file.
1881         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1882         Call aarch32_read_description.
1883         * arch/aarch32.c: New file.
1884         * arch/aarch32.h: New file.
1885         * arch/arm.c (arm_create_target_description)
1886         (arm_create_mprofile_target_description): New function.
1887         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1888         (arm_create_target_description)
1889         (arm_create_mprofile_target_description): New declaration.
1890         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1891         read_description functions.
1892         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1893         Likewise.
1894         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1895         * arm-tdep.c (tdesc_arm_list): New variable.
1896         (arm_register_g_packet_guesses): Call create description functions.
1897         (arm_read_description) (arm_read_mprofile_description): New
1898         function.
1899         * arm-tdep.h (arm_read_description)
1900         (arm_read_mprofile_description): Add declaration.
1901         * configure.tgt: Add new files.
1902
1903 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1904
1905         * top.c (new_ui_command): Open specified terminal just once.
1906
1907 2019-07-18  Tom Tromey  <tromey@adacore.com>
1908
1909         * symtab.c (main_name): Constify return type.
1910         * symfile.c (set_initial_language): Update.
1911         * symtab.h (main_name): Constify return type.
1912
1913 2019-07-17  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-winsource.c (tui_update_source_window)
1916         (tui_update_source_window_as_is)
1917         (tui_update_source_windows_with_line): Remove return.
1918         * tui/tui-disasm.c (tui_show_disassem)
1919         (tui_show_disassem_and_update_source): Remove return.
1920         * tui/tui.c (tui_reset): Remove return.
1921         * tui/tui-wingeneral.c
1922         (tui_check_and_display_highlight_if_needed): Remove return.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1927
1928 2019-07-17  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-winsource.h (struct tui_exec_info_window)
1931         (struct tui_source_window_base): Move from tui-data.h.
1932         * tui/tui-winsource.c: Move many method definitions from
1933         elsewhere.  Remove "structuring" comments.
1934         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1935         (tui_source_window_base::refresh_window): Move to
1936         tui-winsource.c.
1937         * tui/tui-win.c (tui_source_window_base::refresh_all)
1938         (tui_source_window_base::update_tab_width)
1939         (tui_source_window_base::set_new_height)
1940         (tui_source_window_base::do_make_visible_with_new_height): Move to
1941         tui-winsource.c.
1942         * tui/tui-source.h: Update.
1943         * tui/tui-source.c (tui_source_window_base::reset): Move to
1944         tui-winsource.c.
1945         * tui/tui-disasm.h: Update.
1946         * tui/tui-data.h (struct tui_exec_info_window): Move to
1947         tui-winsource.h.
1948         (struct tui_source_window_base): Likewise.
1949         * tui/tui-data.c (tui_source_window_base::clear_detail)
1950         (tui_source_window_base, ~tui_source_window_base): Move to
1951         tui-winsource.c.
1952
1953 2019-07-17  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-win.c (tui_resize_all)
1956         (tui_source_window_base::update_tab_width)
1957         (tui_adjust_win_heights): Update.
1958         (tui_win_info::make_invisible_and_set_new_height): Rename from
1959         make_invisible_and_set_new_height.
1960         * tui/tui-data.h (struct tui_win_info)
1961         <make_invisible_and_set_new_height>: New method.
1962
1963 2019-07-17  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui.c: Update.
1966         * tui/tui-source.h (struct tui_source_window): Move from
1967         tui-data.h.
1968         * tui/tui-layout.c: Update.
1969         * tui/tui-disasm.c: Update.
1970         * tui/tui-data.h (struct tui_source_window): Move to
1971         tui-source.h.
1972
1973 2019-07-17  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1976         tui-data.h.
1977         * tui/tui-data.h (struct tui_disasm_window): Move to
1978         tui-disasm.h.
1979
1980 2019-07-17  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-regs.h (struct tui_data_item_window): Move from
1983         tui-data.h.
1984         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1985         * tui/tui-data.h (struct tui_data_item_window): Move to
1986         tui-regs.h.
1987         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1988
1989 2019-07-17  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui.c: Update.
1992         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1993         (tui_cmd_window::max_height): Move to tui-command.c.
1994         * tui/tui-layout.c: Update.
1995         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1996         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1997         tui-command.c.
1998         * tui/tui-command.h (struct tui_cmd_window): Move from
1999         tui-data.h.
2000         * tui/tui-command.c: Remove "structuring" comments.
2001         (tui_cmd_window::clear_detail)
2002         (tui_cmd_window::do_make_visible_with_new_height)
2003         (tui_cmd_window::max_height): Move from elsewhere.
2004
2005 2019-07-17  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2008         Now static.
2009         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2010         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2011
2012 2019-07-17  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui.c: Update.
2015         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2016         tui-regs.c.
2017         * tui/tui-windata.h: Remove file.
2018         * tui/tui-windata.c: Remove file.
2019         * tui/tui-win.c (tui_data_window::set_new_height)
2020         (tui_data_window::do_make_visible_with_new_height): Move to
2021         tui-regs.c.
2022         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2023         * tui/tui-regs.c: Remove "structuring" comments.
2024         (tui_data_window::first_data_item_displayed)
2025         (tui_data_window::delete_data_content_windows)
2026         (tui_data_window::erase_data_content)
2027         (tui_data_window::display_all_data)
2028         (tui_data_window::refresh_all)
2029         (tui_data_window::do_scroll_vertical)
2030         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2031         (tui_data_window::do_make_visible_with_new_height)
2032         (tui_data_window::refresh_window): Move from elsewhere.
2033         (_initialize_tui_regs): Move to end of file.
2034         * tui/tui-layout.c: Update.
2035         * tui/tui-hooks.c: Update.
2036         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2037         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2038         tui-regs.c.
2039         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2040
2041 2019-07-17  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2044         seen.
2045
2046 2019-07-17  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-win.c (tui_source_window_base::set_new_height)
2049         (tui_source_window_base::do_make_visible_with_new_height): Use
2050         m_has_locator field directly.
2051         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2052         method.
2053         (struct tui_source_window_base) <has_locator>: Likewise.
2054
2055 2019-07-17  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2058         Don't declare.
2059         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2060         Remove.
2061         * tui/tui-win.c (tui_source_window_base::set_new_height)
2062         (tui_source_window_base::set_new_height)
2063         (make_invisible_and_set_new_height)
2064         (tui_source_window_base::do_make_visible_with_new_height)
2065         (tui_source_window_base::do_make_visible_with_new_height):
2066         Update.
2067         * tui/tui-layout.c (show_source_disasm_command, show_data)
2068         (show_source_or_disasm_and_command): Update.
2069         * tui/tui-layout.c (show_layout): Update.
2070
2071 2019-07-17  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-layout.c (make_data_window): Remove.
2074         (show_data): Unify creation and re-initialization cases.
2075
2076 2019-07-17  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-layout.c (make_source_window, make_disasm_window):
2079         Remove.
2080         (show_data): Unify creation and re-initialization cases.
2081
2082 2019-07-17  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-layout.c (make_command_window): Remove.
2085         (show_source_disasm_command, show_source_or_disasm_and_command):
2086         Unify creation and re-initialization cases.
2087
2088 2019-07-17  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2091         creation and re-initialization cases.
2092
2093 2019-07-17  Tom Tromey  <tom@tromey.com>
2094
2095         * tui/tui-regs.c (tui_get_register): Return void.
2096
2097 2019-07-17  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2100         Simplify.
2101
2102 2019-07-17  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2105         resetting.
2106
2107 2019-07-17  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2110         * tui/tui-regs.c (tui_reg_layout): New function.
2111         (tui_show_registers, tui_reg_command): Use it.
2112         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2113         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2114         parameters.
2115         (tui_layout_command): Remove.
2116
2117 2019-07-17  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui-layout.h (tui/tui-layout): Return void.
2120         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2121
2122 2019-07-17  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-layout.c (show_source_disasm_command, show_data):
2125         Update.
2126         (reset_locator): Remove.
2127         (show_source_or_disasm_and_command): Update.
2128
2129 2019-07-17  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-source.c (tui_source_window_base::reset): Remove
2132         win_type parameter.
2133         * tui/tui-layout.c (make_command_window, make_source_window)
2134         (make_disasm_window, make_data_window)
2135         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2136         (reset_locator, show_source_or_disasm_and_command): Update.
2137         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2138         win_type parameter.
2139         (struct tui_source_window_base) <reset>: Likewise.
2140
2141 2019-07-17  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-layout.c (show_source_disasm_command): Use
2144         reset_locator.
2145         (reset_locator): New function.
2146         (init_and_make_win): Remove.
2147         (show_source_or_disasm_and_command): Use reset_locator.
2148
2149 2019-07-17  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2152         condition.
2153         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2154         Remove condition.
2155         * tui/tui-source.c (tui_source_window_base::reset): New method.
2156         * tui/tui-layout.c (make_command_window): Don't call
2157         init_and_make_win.
2158         (make_source_window, make_disasm_window): Don't call
2159         make_source_or_disasm_window.
2160         (make_data_window): Don't call init_and_make_win.  Change calling
2161         convention.
2162         (show_source_disasm_command, show_data): Simplify.
2163         (make_source_or_disasm_window): Remove.
2164         (show_source_or_disasm_and_command): Simplify.
2165         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2166         (struct tui_source_window_base) <reset>: Likewise.
2167         <execution_info>: Remove initializer.
2168         * tui/tui-data.c (tui_source_window_base): Initialize
2169         execution_info.
2170
2171 2019-07-17  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2174         variable.
2175
2176 2019-07-17  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui.c (tui_rl_other_window): Update.
2179         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2180         superclass method first.  Always iterate over regs_content.
2181         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2182         method.
2183         * tui/tui-win.c (tui_set_focus_command): Update.
2184
2185 2019-07-17  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-win.c (tui_set_focus_command): Rename from
2188         tui_set_focus.  Call tui_enable.
2189         (tui_set_focus_command): Remove.
2190
2191 2019-07-17  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2194         refresh_window.
2195         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2196         touchwin.
2197         (tui_data_window::refresh_window): Call refresh_window on data
2198         items.  Always call superclass refresh_window.
2199         (tui_win_info::refresh): Remove.
2200         (tui_source_window_base::refresh_window): Update.
2201         (tui_refresh_all): Update.
2202         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2203         refresh_window.
2204         (show_source_or_disasm_and_command): Likewise.
2205         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2206         (struct tui_source_window_base) <refresh>: Likewise.
2207
2208 2019-07-17  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-winsource.c (tui_clear_source_content)
2211         (tui_show_source_content): Update.
2212         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2213         whether content is empty.
2214         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2215         Remove.
2216
2217 2019-07-17  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2220         window's contents.
2221         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2222         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2223
2224 2019-07-17  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2227         (struct tui_data_item_window): Update.
2228
2229 2019-07-17  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2232         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2233         defines.
2234
2235 2019-07-17  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-winsource.h (tui_erase_source_content)
2238         (tui_clear_source_content): Remove "display_prompt" parameter.
2239         * tui/tui-winsource.c (tui_update_source_window_as_is)
2240         (tui_update_source_windows_with_addr): Update.
2241         (tui_clear_source_content): Remove "display_prompt" parameter.
2242         (tui_erase_source_content): Likewise.  Simplify.
2243         (tui_show_source_content): Update.
2244         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2245         * tui/tui-stack.c (tui_show_frame_info): Update.
2246         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2247         Remove defines.
2248
2249 2019-07-17  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2252         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2253         parameter.
2254         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2255         parameter.
2256
2257 2019-07-17  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-winsource.c (tui_clear_source_content)
2260         (tui_show_source_content, tui_show_exec_info_content)
2261         (tui_clear_exec_info_content): Update.
2262         * tui/tui-stack.c (tui_show_locator_content): Update.
2263         (tui_show_frame_info): Update.
2264         * tui/tui-source.h (tui_source_window): Don't declare.
2265         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2266         from tui_source_is_displayed.
2267         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2268         Remove field.
2269         (struct tui_source_window_base) <content_in_use>: New field.  Now
2270         bool.
2271         (struct tui_source_window) <showing_source_p>: New method.
2272         (TUI_SRC_WIN): Change cast.
2273         * tui/tui-data.c (tui_initialize_static_data): Update.
2274
2275 2019-07-17  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2278         location_matches_p.
2279         * tui/tui-source.c (tui_source_window::location_matches_p): New
2280         method.
2281         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2282         method.
2283         * tui/tui-data.h (struct tui_source_window_base)
2284         <location_matches_p>: New method.
2285         (struct tui_source_window, struct tui_disasm_window)
2286         <location_matches_p>: Likewise.
2287
2288 2019-07-17  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-win.c (tui_set_win_height_command): Rename from
2291         tui_set_win_height.
2292         (tui_set_win_height_command): Remove.
2293
2294 2019-07-17  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-source.c (tui_source_window): New constructor.  Add
2297         observer.
2298         (~tui_source_window): New destructor.
2299         (tui_source_window::style_changed): New method.
2300         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2301         (tui_attach_detach_observers): Update.
2302         * tui/tui-data.h (struct tui_source_window): Make constructor not
2303         inline.  Add destructor.
2304         (struct tui_source_window) <style_changed>: New method.
2305         <m_observable>: New member.
2306
2307 2019-07-17  Tom Tromey  <tom@tromey.com>
2308
2309         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2310         * tui/tui-win.c (tui_resize_all): Fix typo.
2311
2312 2019-07-17  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2315         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2316         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2317         * tui/tui-win.c (window_name_completer): Use foreach.
2318         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2319         (update_tab_width): Likewise.
2320         * tui/tui-layout.c (show_layout): Update.
2321         * tui/tui-data.h (class tui_window_iterator): New.
2322         (struct all_tui_windows): New.
2323         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2324
2325 2019-07-17  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2328         parameter.  Don't reference globals.
2329         (tui_reg_command): Update.
2330
2331 2019-07-17  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-regs.c (tui_show_registers): Simplify.
2334
2335 2019-07-17  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-regs.c (tui_show_registers): Update.
2338         (tui_show_register_group): Add win_info parameter.
2339
2340 2019-07-17  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2343         Rename from tui_display_reg_element_at_line.
2344         (tui_data_window::display_registers_from_line): Update.
2345         * tui/tui-data.h (struct tui_data_window)
2346         <display_reg_element_at_line>: New method.
2347
2348 2019-07-17  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-regs.h (tui_display_registers_from)
2351         (tui_display_registers_from_line): Don't declare.
2352         * tui/tui-windata.c (tui_data_window::display_all_data)
2353         (tui_data_window::refresh_all)
2354         (tui_data_window::do_scroll_vertical): Update.
2355         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2356         from tui_display_registers_from.
2357         (tui_display_reg_element_at_line): Update.
2358         (tui_data_window::display_registers_from_line): Rename from
2359         tui_display_registers_from_line.
2360         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2361         display_registers_from_line>: New methods.
2362
2363 2019-07-17  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2366         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2367         from tui_erase_data_content.
2368         (tui_data_window::display_all_data)
2369         (tui_data_window::refresh_all)
2370         (tui_data_window::do_scroll_vertical): Update.
2371         * tui/tui-regs.c (tui_show_registers): Update.
2372         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2373         New method.
2374
2375 2019-07-17  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2378         declare.
2379         * tui/tui-windata.c
2380         (tui_data_window::delete_data_content_windows): Rename from
2381         tui_delete_data_content_windows.
2382         (tui_data_window::display_all_data)
2383         (tui_data_window::do_scroll_vertical): Update.
2384         * tui/tui-data.h (struct tui_data_window)
2385         <delete_data_content_windows>: New method.
2386
2387 2019-07-17  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2390         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2391
2392 2019-07-17  Tom Tromey  <tom@tromey.com>
2393
2394         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2395         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2396         from tui_display_all_data.
2397         * tui/tui-win.c
2398         (tui_data_window::do_make_visible_with_new_height): Update.
2399         * tui/tui-regs.c (tui_show_registers): Update.
2400         * tui/tui-layout.c (tui_set_layout): Update.
2401         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2402         method.
2403
2404 2019-07-17  Tom Tromey  <tom@tromey.com>
2405
2406         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2407         * tui/tui-windata.c (tui_display_data_from): Remove.
2408         (tui_data_window::refresh_all): Update.
2409
2410 2019-07-17  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2413         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2414         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2415         tui_display_registers_from_line.
2416         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2417         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2418         "force_display" parameter.
2419
2420 2019-07-17  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2423         declare.
2424         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2425         Rename from tui_first_reg_element_no_inline.
2426         (tui_display_reg_element_at_line)
2427         (tui_display_registers_from_line): Update.
2428         * tui/tui-data.h (struct tui_data_window)
2429         <first_reg_element_no_inline>: New method.
2430
2431 2019-07-17  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-windata.c (tui_display_data_from)
2434         (tui_data_window::do_scroll_vertical): Update.
2435         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2436         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2437         Rename from tui_line_from_reg_element_no.
2438         (tui_display_registers_from_line): Update.
2439         * tui/tui-data.h (struct tui_data_window)
2440         <line_from_reg_element_no>: New method.
2441
2442 2019-07-17  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2445         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2446         tui_last_regs_line_no.
2447         (tui_display_reg_element_at_line)
2448         (tui_display_registers_from_line): Update.
2449         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2450         method.
2451
2452 2019-07-17  Tom Tromey  <tom@tromey.com>
2453
2454         PR tui/24722:
2455         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2456         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2457         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2458         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2459         (tui_update_breakpoint_info): Likewise.
2460         * tui/tui-hooks.c (tui_event_create_breakpoint)
2461         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2462         Update.
2463
2464 2019-07-17  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2467
2468 2019-07-17  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-winsource.c (tui_update_source_window_as_is)
2471         (tui_update_source_windows_with_addr): Update.
2472         * tui/tui-source.h (tui_set_source_content)
2473         (tui_show_symtab_source): Add "win_info" parameter.
2474         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2475         parameter.
2476         (tui_show_symtab_source): Likewise.
2477
2478 2019-07-17  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-wingeneral.c
2481         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2482
2483 2019-07-17  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2486         (struct tui_cmd_window) <can_scroll>: New method.
2487         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2488         method.
2489
2490 2019-07-17  Tom Tromey  <tromey@adacore.com>
2491
2492         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2493         do_field_signed>: Rename.  Change type of "value".
2494         * ui-out.c (ui_out::field_signed): Rename from field_int.
2495         Change type of "value".
2496         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2497         type of "value".
2498         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2499         do_field_int.  Change type of "value".
2500         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2501         do_field_int.  Change type of "value".
2502         * tracepoint.c (trace_status_mi, tfind_1)
2503         (print_one_static_tracepoint_marker): Update.
2504         * thread.c (print_thread_info_1, print_selected_thread_frame):
2505         Update.
2506         * stack.c (print_frame, print_frame_info): Update.
2507         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2508         Update.
2509         * source.c (print_source_lines_base): Update.
2510         * skip.c (info_skip_command): Update.
2511         * record-btrace.c (btrace_ui_out_decode_error)
2512         (btrace_call_history_src_line): Update.
2513         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2514         Update.
2515         * progspace.c (print_program_space): Update.
2516         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2517         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2518         do_field_int.  Change type of "value".
2519         * mi/mi-out.c (mi_ui_out::do_table_begin)
2520         (mi_ui_out::do_table_header): Update.
2521         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2522         type of "value".
2523         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2524         (mi_cmd_data_list_changed_registers, output_register)
2525         (mi_cmd_data_read_memory, mi_load_progress)
2526         (mi_cmd_trace_frame_collected): Update.
2527         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2528         Update.
2529         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2530         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2531         (mi_cmd_var_list_children, varobj_update_one): Update.
2532         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2533         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2534         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2535         * inferior.c (print_inferior): Update.
2536         * gdb_bfd.c (print_one_bfd): Update.
2537         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2538         Update.
2539         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2540         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2541         do_field_int.  Change type of "value".
2542         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2543         do_field_int.  Change type of "value".
2544         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2545         (print_one_breakpoint_location, print_it_catch_fork)
2546         (print_one_catch_fork, print_it_catch_vfork)
2547         (print_one_catch_vfork, print_it_catch_solib)
2548         (print_it_catch_exec, print_it_ranged_breakpoint)
2549         (print_mention_watchpoint, print_mention_masked_watchpoint)
2550         (bkpt_print_it, update_static_tracepoint): Update.
2551         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2552         * break-catch-syscall.c (print_it_catch_syscall): Update.
2553         * ada-tasks.c (print_ada_task_info): Update.
2554         * ada-lang.c (print_it_exception, print_mention_exception):
2555         Update.
2556
2557 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2558
2559         PR breakpoints/24541
2560         * gdbarch.c: Regenerate.
2561         * gdbarch.h: Regenerate.
2562         * gdbarch.sh: Adjust return type and parameter types for
2563         'stap_adjust_register'.
2564         (i386_stap_adjust_register): Adjust signature and return new
2565         register name.
2566         * stap-probe.c (stap_parse_register_operand): Adjust use of
2567         'gdbarch_stap_adjust_register'.
2568
2569 2019-07-17  Tom Tromey  <tromey@adacore.com>
2570
2571         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2572         declare VEC.
2573         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2574         std::vector.
2575         (struct s390_process_info): Add initializers.
2576         (s390_add_process): Use new.
2577         (s390_linux_nat_target::low_forget_process): Use delete.
2578         (s390_linux_nat_target::low_new_fork)
2579         (s390_linux_nat_target::stopped_by_watchpoint)
2580         (s390_linux_nat_target::low_prepare_to_resume)
2581         (s390_linux_nat_target::insert_watchpoint)
2582         (s390_linux_nat_target::insert_hw_breakpoint)
2583         (s390_linux_nat_target::remove_watchpoint)
2584         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2585
2586 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2587
2588         * aarch64-fbsd-nat.c: Include regcache.h.
2589         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2590         argument.
2591         (aarch64_fbsd_nat_target::fetch_registers)
2592         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2593         variable.
2594         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2595
2596 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2597
2598         * fbsd-nat.c: Include gdbarch.h.
2599
2600 2019-07-15  Tom Tromey  <tromey@adacore.com>
2601
2602         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2603
2604 2019-07-15  Tom Tromey  <tromey@adacore.com>
2605
2606         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2607         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2608         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2609         * cli-out.c (cli_ui_out::do_field_int): New method.
2610         * ui-out.c (ui_out::field_unsigned): New method.
2611         * symfile.c (generic_load): Use field_unsigned.
2612         (print_transfer_performance): Likewise.
2613         * record-btrace.c (ui_out_field_uint): Remove.
2614         (btrace_call_history_insn_range, btrace_call_history): Use
2615         field_unsigned.
2616         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2617         field_unsigned.
2618         * ui-out.h (class ui_out) <field_unsigned>: New method.
2619         <do_field_unsigned>: Likewise.
2620
2621 2019-07-15  Tom Tromey  <tromey@adacore.com>
2622
2623         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2624         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2625         * target.c (flash_erase_command): Use field_string.
2626         * infrun.c (print_signal_received_reason): Use field_string.
2627         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2628         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2629         field_string.
2630         * ada-tasks.c (print_ada_task_info): Use field_string.
2631
2632 2019-07-15  Tom Tromey  <tromey@adacore.com>
2633
2634         * target.c (flash_erase_command): Use field_core_addr.
2635         * symfile.c (generic_load): Use field_core_addr.
2636         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2637         Use field_core_addr.
2638         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2639         field_core_addr.
2640
2641 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2642
2643         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2644         value if its desired type is smaller than a CORE_ADDR and signed.
2645
2646 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2649         of changes to field names, and use new is_reference field to
2650         decide if a property is a reference or not.
2651         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2652         field.
2653         (struct dwarf2_property_baton): Update header comment, rename
2654         'referenced_type' to 'property_type' and update comments.
2655         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2656         default property type, store in property baton, update to take
2657         accound of renamed field.
2658         (read_func_scope): Update call to attr_to_dynamic_prop.
2659         (read_array_type): Likewise.
2660         (dwarf2_per_cu_addr_sized_int_type): New function.
2661         (read_subrange_index_type): Move type finding code to
2662         dwarf2_per_cu_addr_sized_int_type.
2663         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2664         (dwarf2_per_cu_addr_type): New function.
2665         (set_die_type): Update calls to attr_to_dynamic_prop.
2666
2667 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2668
2669         * dwarf2read.c (read_subrange_index_type): New function.
2670         (read_subrange_type): Move code into new function and call it.
2671         * gdbtypes.c (create_range_type): Add some asserts.
2672
2673 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2674
2675         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2676         update return statements.
2677         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2678         declaration, and update comment to match.
2679         * gdbtypes.c (resolve_dynamic_array): Update call to
2680         dwarf2_evaluate_property to match new return type.
2681
2682 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2683
2684         * valarith.c (value_subscripted_rvalue): Change lowerbound
2685         parameter type from int to LONGEST.
2686         * value.h (value_subscripted_rvalue): Likewise in declaration.
2687
2688 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2689
2690         * cli/cli-utils.c (info_print_command_completer): New function.
2691         * cli/cli-utils.h: Add 'completer.h' include, and forward
2692         declaration for 'struct cmd_list_element'.
2693         (info_print_command_completer): Declare.
2694         * stack.c (_initialize_stack): Add completer for 'info locals' and
2695         'info args'.
2696         * symtab.c (_initialize_symtab): Add completer for 'info
2697         variables' and 'info functions'.
2698         * NEWS: Mention completion for additional info commands.
2699
2700 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2701
2702         * cli/cli-utils.c (extract_info_print_args): Delete.
2703         (extract_arg_maybe_quoted): Delete.
2704         (info_print_options_defs): New variable.
2705         (make_info_print_options_def_group): New function.
2706         (extract_info_print_options): Define new function.
2707         * cli/cli-utils.h (extract_info_print_args): Delete.
2708         (struct info_print_options): New structure.
2709         (extract_info_print_options): Declare new function.
2710         * stack.c (info_locals_command): Update to use new
2711         extract_info_print_options, also add a header comment.
2712         (info_args_command): Likewise.
2713         * symtab.c (info_variables_command): Likewise.
2714         (info_functions_command): Likewise.
2715
2716 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2717
2718         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2719         to extract string arguments.
2720         * common/common-utils.c (extract_string_maybe_quoted): New function.
2721         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2722
2723 2019-07-11  Tom Tromey  <tromey@adacore.com>
2724
2725         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2726         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2727         * top.h (gdbinit): Don't declare.
2728         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2729         into...
2730         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2731         * top.c (gdb_init): Don't call init_cli_cmds.
2732         (gdbinit): Remove.
2733         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2734
2735 2019-07-11  Tom Tromey  <tromey@adacore.com>
2736
2737         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2738         after it has been moved.
2739
2740 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2741
2742         * valops.c (value_must_coerce_to_target): Change return type to
2743         bool.
2744         * value.h (value_must_coerce_to_target): Likewise.
2745
2746 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2747
2748         * breakpoint.c (is_hardware_watchpoint): Remove
2749         forward-declaration.
2750         (is_masked_watchpoint): Change return type to bool.
2751         (is_tracepoint): Likewise.
2752         (is_breakpoint): Likewise.
2753         (is_hardware_watchpoint): Likewise.
2754         (is_watchpoint): Likewise.
2755         (is_no_memory_software_watchpoint): Likewise.
2756         (is_catchpoint): Likewise.
2757         (breakpoint_1): Make FILTER parameter's return type bool.
2758         is_masked_watchpoint): Change return type to bool.
2759         (save_breakpoints): Make FILTER parameter's return type bool.
2760         * breakpoint.h (is_breakpoint): Change return type to bool.
2761         (is_watchpoint): Likewise.
2762         (is_catchpoint): Likewise.
2763         (is_tracepoint): Likewise.
2764
2765 2019-07-10  Tom Tromey  <tom@tromey.com>
2766
2767         * defs.h: Don't include gdbarch.h.
2768         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2769         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2770         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2771         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2772         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2773         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2774         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2775         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2776         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2777         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2778         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2779         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2780         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2781         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2782         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2783         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2784         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2785         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2786         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2787         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2788         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2789         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2790         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2791         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2792         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2793         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2794         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2795
2796 2019-07-10  Tom Tromey  <tromey@adacore.com>
2797
2798         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2799         * breakpoint.c (init_ada_exception_breakpoint): Register as
2800         bp_catchpoint.
2801         (print_one_breakpoint_location, print_one_breakpoint): Use
2802         is_ada_exception_catchpoint.
2803         * ada-lang.c (class ada_catchpoint_location): Pass
2804         bp_loc_software_breakpoint to bp_location constructor.
2805         (is_ada_exception_catchpoint): New function.
2806
2807 2019-07-10  Tom Tromey  <tromey@adacore.com>
2808
2809         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2810         VEC.
2811         (struct arm_exidx_entry): New method operator<.
2812         (struct arm_exidx_data) <section_maps>: Change type.
2813         (arm_exidx_data_free): Remove.
2814         (arm_exidx_data_key): Change type.  Move lower.
2815         (arm_exidx_new_objfile): Update.
2816         (arm_compare_exidx_entries): Remove.
2817         (arm_find_exidx_entry, _initialize_arm_tdep)
2818
2819 2019-07-10  Tom Tromey  <tromey@adacore.com>
2820
2821         * solib-spu.c (ocl_program_data_key): Change type.
2822         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2823         Update.
2824
2825 2019-07-10  Tom Tromey  <tromey@adacore.com>
2826
2827         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2828         (struct solib_aix_inferior_data) <library_list>: Change type.
2829         (solib_aix_inferior_data_handle): Change type.
2830         (get_solib_aix_inferior_data): Update.
2831         (solib_aix_free_library_list): Remove.
2832         (library_list_start_library): Update.
2833         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2834         return type.
2835         (solib_aix_get_library_list)
2836         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2837         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2838
2839 2019-07-10  Tom Tromey  <tromey@adacore.com>
2840
2841         * solib-dsbt.c (struct dsbt_info): Add initializers.
2842         (solib_dsbt_pspace_data): Change type.
2843         (dsbt_pspace_data_cleanup): Remove.
2844         (get_dsbt_info, _initialize_dsbt_solib): Update.
2845
2846 2019-07-10  Tom Tromey  <tromey@adacore.com>
2847
2848         * spu-tdep.c (spu_overlay_data): Change type.
2849         (spu_get_overlay_table, spu_overlay_new_objfile)
2850         (_initialize_spu_tdep): Update.
2851
2852 2019-07-10  Tom Tromey  <tromey@adacore.com>
2853
2854         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2855         destructor.
2856         (dbx_objfile_data_key): Change type and declare later.
2857         (DBX_SYMFILE_INFO): Rewrite.
2858         * dbxread.c (dbx_objfile_data_key): Change type.
2859         (dbx_symfile_init): Update.
2860         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2861         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2862         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2863
2864 2019-07-10  Tom Tromey  <tromey@adacore.com>
2865
2866         * jit.c (jit_program_space_key): Change type.  Move lower.
2867         (get_jit_program_space_data): Update.
2868         (jit_program_space_data_cleanup): Remove.
2869         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2870         Update.
2871         (struct jit_program_space_data): Add initializers.
2872
2873 2019-07-10  Tom Tromey  <tromey@adacore.com>
2874
2875         * solib-darwin.c (struct darwin_info): Add initializers.
2876         (solib_darwin_pspace_data): Change type.
2877         (darwin_pspace_data_cleanup): Remove.
2878         (get_darwin_info, _initialize_darwin_solib): Update.
2879
2880 2019-07-10  Tom Tromey  <tromey@adacore.com>
2881
2882         * remote-sim.c (struct sim_inferior_data): Add initializers,
2883         constructor, and destructor.
2884         (sim_inferior_data_key): Change type.  Move lower.
2885         (check_for_duplicate_sim_descriptor): Update.
2886         (get_sim_inferior_data): Use new.  Update.
2887         (~sim_inferior_data_cleanup): Rename from
2888         sim_inferior_data_cleanup.  Simplify.
2889         (gdbsim_close_inferior, simulator_command)
2890         (sim_command_completer, _initialize_remote_sim): Update.
2891         (next_pid, INITIAL_PID): Move earlier.
2892
2893 2019-07-10  Tom Tromey  <tromey@adacore.com>
2894
2895         * python/python-internal.h (create_thread_object): Return
2896         gdbpy_ref.
2897         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2898         * python/py-inferior.c (struct threadlist_entry): Add
2899         constructor.
2900         <thread_obj>: Now a gdbpy_ref.
2901         (thread_to_thread_object): Update.
2902         (add_thread_object): Use new.
2903         (delete_thread_object): Use delete.
2904         (infpy_threads): Update.
2905         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2906         GIL.
2907
2908 2019-07-10  Tom Tromey  <tromey@adacore.com>
2909
2910         * valops.c (value_cast): Specialize error message for Ada.
2911
2912 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2913
2914         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2915
2916 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2917
2918         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2919         bpstat_should_step): Return bool, adjust comments.
2920         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2921         bpstat_should_step): Likewise.
2922
2923 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2924
2925         * features/Makefile: Use feature target descriptions for Arm.
2926         * features/arm/arm-core.c: Generate new file.
2927         * features/arm/arm-fpa.c: Likewise.
2928         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2929         * features/arm/arm-m-profile.c: Likewise.
2930         * features/arm/arm-vfpv2.c: Likewise.
2931         * features/arm/arm-vfpv3.c: Likewise.
2932         * features/arm/xscale-iwmmxt.c: Likewise.
2933         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2934
2935 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2936
2937         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2938         ptrace earlier.
2939
2940 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2941
2942         * features/aarch64-pauth.c: Regenerate.
2943
2944 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2945
2946         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2947         bool.
2948         (bpstat_what): Use false instead of 0.
2949
2950 2019-07-09  Pedro Alves  <palves@redhat.com>
2951
2952         * break-catch-throw.c (is_exception_catchpoint): New.
2953         * breakpoint.c (print_one_breakpoint_location): New parameter
2954         'raw_loc'.  Handle it.  Use
2955         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2956         looking at the breakpoint's type.
2957         (print_one_breakpoint): If handling "maint info breakpoints", also
2958         print locations of exception catchpoints.
2959         * breakpoint.h (is_exception_catchpoint): Declare.
2960
2961 2019-07-09  Pedro Alves  <palves@redhat.com>
2962
2963         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2964         "addr" field.
2965         (allocate_location_exception_catchpoint): New.
2966         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2967         (initialize_throw_catchpoint_ops): Install
2968         allocate_location_exception_catchpoint as allocate_location
2969         method.
2970         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2971         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2972         bp_loc_other.
2973         (breakpoint_address_is_meaningful): Delete.
2974         (bl_address_is_meaningful): New.
2975         (breakpoint_locations_match): Adjust comment.
2976         (bp_location_from_bp_type): New, factored out of...
2977         (bp_location::bp_location(breakpoint *)): ... this.
2978         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2979         factored out of...
2980         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2981         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2982         breakpoint_address_is_meaningful.
2983         (bp_locations_compare): Adjust comment.
2984         (update_global_location_list): Use bl_address_is_meaningful
2985         instead of breakpoint_address_is_meaningful.
2986         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2987         explicit.
2988         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2989         * python/py-breakpoint.c (bppy_get_location): No longer check
2990         whether location is null.
2991
2992 2019-07-09  Pedro Alves  <palves@redhat.com>
2993
2994         PR c++/15468
2995         * breakpoint.c (print_one_breakpoint_location): Remove
2996         single-location assert.
2997
2998 2019-07-09  Tom Tromey  <tom@tromey.com>
2999
3000         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3001         * configure: Rebuild.
3002         * configure.ac: Change common to gdbsupport.
3003         * gdbsupport: Rename from common.
3004         * acinclude.m4: Change common to gdbsupport.
3005         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3006         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3007         gdbsupport.
3008         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3009         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3010         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3011         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3012         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3013         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3014         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3015         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3016         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3017         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3018         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3019         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3020         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3021         coff-pe-read.c, command.h, compile/compile-c-support.c,
3022         compile/compile-c.h, compile/compile-cplus-symbols.c,
3023         compile/compile-cplus-types.c, compile/compile-cplus.h,
3024         compile/compile-loc2c.c, compile/compile.c, completer.c,
3025         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3026         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3027         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3028         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3029         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3030         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3031         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3032         features/aarch64-core.c, features/aarch64-fpu.c,
3033         features/aarch64-pauth.c, features/aarch64-sve.c,
3034         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3035         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3036         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3037         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3038         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3039         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3040         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3041         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3042         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3043         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3044         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3045         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3046         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3047         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3048         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3049         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3050         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3051         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3052         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3053         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3054         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3055         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3056         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3057         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3058         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3059         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3060         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3061         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3062         minsyms.c, mips-linux-tdep.c, namespace.h,
3063         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3064         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3065         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3066         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3067         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3068         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3069         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3070         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3071         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3072         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3073         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3074         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3075         procfs.c, producer.c, progspace.h, psymtab.h,
3076         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3077         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3078         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3079         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3080         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3081         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3082         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3083         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3084         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3085         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3086         target-memory.c, target.c, target.h, target/waitstatus.c,
3087         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3088         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3089         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3090         unittests/array-view-selftests.c,
3091         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3092         unittests/common-utils-selftests.c,
3093         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3094         unittests/format_pieces-selftests.c,
3095         unittests/function-view-selftests.c,
3096         unittests/lookup_name_info-selftests.c,
3097         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3098         unittests/mkdir-recursive-selftests.c,
3099         unittests/observable-selftests.c,
3100         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3101         unittests/parse-connection-spec-selftests.c,
3102         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3103         unittests/scoped_fd-selftests.c,
3104         unittests/scoped_mmap-selftests.c,
3105         unittests/scoped_restore-selftests.c,
3106         unittests/string_view-selftests.c, unittests/style-selftests.c,
3107         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3108         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3109         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3110         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3111         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3112         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3113
3114 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3115
3116         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3117         bool value.
3118         (decode_digits_ordinary): Set explicit_line field in sal.
3119         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3120         symtab_and_line that was set on an explicit line number in
3121         assembler code.  Do always update the recorded symtab and line if
3122         we do skip the prologue.
3123
3124 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3125
3126         * breakpoint.c (set_breakpoint_location_function): Remove
3127         explicit_loc parameter.
3128         (momentary_breakpoint_from_master): Update call to
3129         set_breakpoint_location_function.
3130         (add_location_to_breakpoint): Likewise.
3131
3132 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3133
3134         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3135         required features based on default bfd type when no specific bfd
3136         is present.
3137
3138 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3139
3140         * NEWS: Mention that GDB printf and eval commands can now print
3141         C-style and Ada-style convenience var strings without
3142         calling the inferior.
3143         * printcmd.c (printf_c_string): Locally print GDB internal var
3144         instead of transiting via the inferior.
3145         (printf_wide_c_string): Likewise.
3146
3147 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3148
3149         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3150
3151 2019-07-04  Tom Tromey  <tom@tromey.com>
3152
3153         PR tui/24724:
3154         * tui/tui-winsource.c (tui_clear_source_content): Update.
3155         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3156         (tui_update_breakpoint_info): Update.
3157         (tui_set_exec_info_content): Update.
3158         * tui/tui-source.c (tui_set_source_content_nil): Update.
3159         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3160         has_break.
3161         * tui/tui-data.h (enum tui_bp_flag): New.
3162         (tui_bp_flags): New enum flags type.
3163         (struct tui_source_element) <break_mode>: Change type.  Rename
3164         from has_break.
3165         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3166         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3167         constants.
3168         * tui/tui-winsource.h: Fix comment.
3169
3170 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3171
3172         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3173         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3174         (store_fpregs_to_thread)
3175         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3176         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3177         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3178         (IWMMXT_REGS_SIZE): Add define.
3179         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3180         (fetch_vfp_regs, store_vfp_regs)
3181         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3182         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3183
3184 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3185
3186         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3187         defines.
3188         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3189         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3190         (ARM_INT_REGISTER_SIZE): ...to this.
3191         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3192         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3193         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3194         (arm_linux_collect_gregset, supply_nwfpe_register)
3195         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3196         defines.
3197         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3198         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3199         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3200         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3201         (arm_return_in_memory, arm_store_return_value)
3202         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3203         (arm_record_ld_st_multiple): Likewise.
3204         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3205         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3206
3207 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3208
3209         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3210         AARCH64_DISPLACED_MODIFIED_INSNS.
3211         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3212         (aarch64_displaced_step_copy_insn): Likewise.
3213         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3214         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3215         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3216         ARM_DISPLACED_MODIFIED_INSNS.
3217         * arm-tdep.c (arm_gdbarch_init): Likewise.
3218         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3219         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3220         (struct arm_displaced_step_closure): Use
3221         ARM_DISPLACED_MODIFIED_INSNS.
3222
3223 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3224
3225         * features/Makefile: Remove unused xml files.
3226         * features/aarch64.xml: Remove.
3227         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3228         * features/i386/amd64-avx-avx512.xml: Remove.
3229         * features/i386/amd64-avx-linux.xml: Remove.
3230         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3231         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3232         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3233         * features/i386/amd64-avx-mpx.xml: Remove.
3234         * features/i386/amd64-avx.xml: Remove.
3235         * features/i386/amd64-linux.xml: Remove.
3236         * features/i386/amd64-mpx-linux.xml: Remove.
3237         * features/i386/amd64-mpx.xml: Remove.
3238         * features/i386/amd64.xml: Remove.
3239         * features/i386/i386-avx-avx512-linux.xml: Remove.
3240         * features/i386/i386-avx-avx512.xml: Remove.
3241         * features/i386/i386-avx-linux.xml: Remove.
3242         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3243         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3244         * features/i386/i386-avx-mpx-linux.xml: Remove.
3245         * features/i386/i386-avx-mpx.xml: Remove.
3246         * features/i386/i386-avx.xml: Remove.
3247         * features/i386/i386-linux.xml: Remove.
3248         * features/i386/i386-mmx-linux.xml: Remove.
3249         * features/i386/i386-mmx.xml: Remove.
3250         * features/i386/i386-mpx-linux.xml: Remove.
3251         * features/i386/i386-mpx.xml: Remove.
3252         * features/i386/i386.xml: Remove.
3253         * features/i386/x32-avx-avx512-linux.xml: Remove.
3254         * features/i386/x32-avx-linux.xml: Remove.
3255         * features/i386/x32-linux.xml: Remove.
3256
3257 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3258
3259         * regformats/aarch64.dat: Remove.
3260         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3261         * regformats/i386/amd64-avx-linux.dat: Remove.
3262         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3263         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3264         * regformats/i386/amd64-linux.dat: Remove.
3265         * regformats/i386/amd64-mpx-linux.dat: Remove.
3266         * regformats/i386/amd64.dat: Remove.
3267         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3268         * regformats/i386/i386-avx-linux.dat: Remove.
3269         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3270         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3271         * regformats/i386/i386-linux.dat: Remove.
3272         * regformats/i386/i386-mmx-linux.dat: Remove.
3273         * regformats/i386/i386-mpx-linux.dat: Remove.
3274         * regformats/i386/i386.dat: Remove.
3275         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3276         * regformats/i386/x32-avx-linux.dat: Remove.
3277         * regformats/i386/x32-linux.dat: Remove.
3278
3279 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3280
3281         * aarch64-tdep.c: Remove xml self tests.
3282         * amd64-linux-tdep.c: Likewise.
3283         * amd64-tdep.c: Likewise.
3284         * i386-linux-tdep.c: Likewise.
3285         * i386-tdep.c: Likewise.
3286
3287 2019-07-03  Pedro Alves  <palves@redhat.com>
3288
3289         PR cli/24732
3290         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3291         (pipe_cmd_option_defs): New.
3292         (make_pipe_cmd_options_def_group): New.
3293         (pipe_command): Use gdb::option::process_options.
3294         (pipe_command_completer): New function.
3295         (_initialize_cli_cmds): Install completer for "pipe" command.
3296
3297 2019-07-03  Pedro Alves  <palves@redhat.com>
3298
3299         * cli/cli-option.c (union option_value) <string>: New field.
3300         (struct option_def_and_value): Add ctor, move ctor, dtor and
3301         use DISABLE_COPY_AND_ASSIGN.
3302         (option_def_and_value::clear_value): New.
3303         (parse_option, save_option_value_in_ctx, get_val_type_str)
3304         (add_setshow_cmds_for_options): Handle var_string.
3305         * cli-option.h (union option_def::var_address) <string>: New
3306         field.
3307         (struct string_option_def): New.
3308         * maint-test-options.c (struct test_options_opts): Add default
3309         ctor and use DISABLE_COPY_AND_ASSIGN.
3310         <string_opt>: New field.
3311         (test_options_opts::~test_options_opts): New.
3312         (test_options_opts::dump): Also dump "-string".
3313         (test_options_option_defs): Install "string.
3314
3315 2019-07-03  Pedro Alves  <palves@redhat.com>
3316
3317         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3318         option_value with a null enumeration.
3319         (complete_options): Save the option values in the context.
3320         (save_option_value_in_ctx): New, factored out from ...
3321         (process_options): ... here.
3322         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3323         of the function.
3324         * maint-test-options.c (test_options_opts::dump): New, factored
3325         out from ...
3326         (maintenance_test_options_command_mode): ... here.
3327         (maintenance_test_options_command_completion_result): Delete.
3328         (maintenance_test_options_command_completion_text): Update
3329         comment.
3330         (maintenance_show_test_options_completion_result): Change
3331         prototype.  Just print
3332         maintenance_test_options_command_completion_text.
3333         (save_completion_result): New.
3334         (maintenance_test_options_completer_mode): Pass options context to
3335         complete_options, and then save a dump.
3336         (_initialize_maint_test_options): Use add_cmd to install "maint
3337         show test-options-completion-result".
3338
3339 2019-07-03  Pedro Alves  <palves@redhat.com>
3340
3341         * NEWS (New commands): Mention "with" and "maint with".
3342         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3343         (with_command, with_command_completer): New.
3344         (pipe_command): Adjust to new repeat_previous
3345         interface.
3346         (_initialize_cli_cmds): Install the "with" command and its "w"
3347         alias.
3348         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3349         declarations.
3350         * cli/cli-setshow.c (parse_cli_var_uinteger)
3351         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3352         argument strings for all var_types.
3353         (get_setshow_command_value_string): New, factored out from ...
3354         (do_show_command): ... this.
3355         * cli/cli-setshow.h: Include <string>.
3356         (get_setshow_command_value_string): Declare.
3357         * command.h (repeat_previous): Now returns const char *.  Adjust
3358         comment.
3359         * maint.c: Include "cli/cli-cmds.h".
3360         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3361         (_initialize_maint_cmds): Register the "maintenance with" command.
3362         * top.c (repeat_previous): Move bits from pipe_command here:
3363         Return the saved command line, if any; error out if there's no
3364         command to relaunch.
3365
3366 2019-07-03  Pedro Alves  <palves@redhat.com>
3367
3368         * NEWS (New commands): Mention "maint set/show test-settings"
3369         instead of "maint test-settings".
3370         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3371         (maintenance_test_settings_set_list): Rename to ...
3372         (maintenance_set_test_settings_list): ... this.
3373         (maintenance_test_settings_show_list): Rename to  ...
3374         (maintenance_show_test_settings_list): ... this.
3375         (maintenance_test_settings_cmd): Delete.
3376         (maintenance_test_settings_set_cmd): ...
3377         (maintenance_set_test_settings_cmd): ... this.
3378         (maintenance_test_settings_show_cmd): ...
3379         (maintenance_show_test_settings_cmd): ... this.
3380         (maintenance_test_settings_show_value_cmd):
3381         (maintenance_show_test_settings_value_cmd): ... this.
3382         (_initialize_maint_test_settings): No longer install the "maint
3383         test-settings" prefix command.  Rename "maint test-settings set"
3384         to "maint set test-settings", and "maint test-settings show" to
3385         "maint show test-settings".  Adjust all subcommands.
3386
3387 2019-07-03  Pedro Alves  <palves@redhat.com>
3388
3389         * maint-test-settings.c: Fix file's intro comment.  Replace all
3390         references to "test-options" with references to "test-settings",
3391         in comments.
3392
3393 2019-07-03  Pedro Alves  <palves@redhat.com>
3394
3395         * maint-test-settings.c (maintenance_test_settings_xxx)
3396         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3397         New.
3398         (maintenance_test_settings_enums): Use them.
3399         (maintenance_test_settings_enum): Default to
3400         maintenance_test_settings_xxx.
3401         (_initialize_maint_test_settings): Initialize
3402         MAINTENANCE_TEST_SETTINGS_FILENAME.
3403
3404 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3405
3406         * breakpoint.h (remove_breakpoints_inf): Change return type to
3407         void, move function documentation here.
3408         * breakpoint.c (remove_breakpoints_inf): Change return type to
3409         void, move function documentation to header.
3410
3411 2019-07-02  Pedro Alves  <palves@redhat.com>
3412
3413         * NEWS (Completion improvements): Mention "info threads".
3414         * thread.c (struct info_threads_opts, info_threads_option_defs)
3415         (make_info_threads_options_def_group): New.
3416         (info_threads_command): Use gdb::option::process_options.
3417         (info_threads_command_completer): New.
3418         (_initialize_thread): Use gdb::option::build_help to build the
3419         help text for "info threads".
3420
3421 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3422
3423         * defs.h (generic_load): Move from here...
3424         * symfile.h (generic_load): ... to here.  Rename name parameter
3425         to args.
3426         * symfile.c (generic_load): Add comment.
3427
3428 2019-07-01  Tom Tromey  <tromey@adacore.com>
3429
3430         * dwarf2read.c
3431         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3432         declaration of without_params.  Fix formatting.
3433
3434 2019-07-01  Tom Tromey  <tromey@adacore.com>
3435
3436         * ada-exp.y (find_primitive_type): Update.
3437         * ada-lang.h (ada_lookup_symbol): Update.
3438         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3439         parameter.
3440         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3441
3442 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3443
3444         PR breakpoints/24541
3445         * gdbarch.c: Regenerate.
3446         * gdbarch.h: Regenerate.
3447         * gdbarch.sh: Add 'stap_adjust_register'.
3448         * i386-tdep.c: Include '<unordered_set>'.
3449         (i386_stap_adjust_register): New function.
3450         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3451         * stap-probe.c (stap_parse_register_operand): Call
3452         'gdbarch_stap_adjust_register'.
3453
3454 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3455
3456         PR python/24742
3457         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3458         * python/python.c (do_start_initialization): Use 'xmalloc'
3459         instead of 'PyMem_Malloc'.
3460
3461 2019-06-28  Tom Tromey  <tromey@adacore.com>
3462
3463         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3464         for Ada.
3465
3466 2019-06-27  Tom Tromey  <tromey@adacore.com>
3467
3468         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3469         objfile_key.
3470         (arm_find_mapping_symbol, arm_record_special_symbol)
3471         (_initialize_arm_tdep): Update.
3472         (arm_objfile_data_free): Remove.
3473
3474 2019-06-27  Tom Tromey  <tromey@adacore.com>
3475
3476         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3477         to cp_print_static_field.
3478
3479 2019-06-26  Tom Tromey  <tromey@adacore.com>
3480
3481         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3482         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3483         declare.
3484
3485 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3486
3487         * features/aarch64-core.c (create_feature_aarch64_core):
3488         Regenerate.
3489         * features/aarch64-core.xml: Add cpsr flags.
3490
3491 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3492
3493         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3494         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3495
3496 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3497
3498         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3499         field.
3500         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3501         use.
3502         (arm_record_special_symbol): Don't insert new symbol in sorted
3503         position, push it at the end.
3504
3505 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3506
3507         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3508         (arm_mapping_symbol_s): Remove.
3509         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3510         (arm_mapping_symbol_vec): New typedef.
3511         (struct arm_per_objfile): Add constructor.
3512         <section_maps>: Change type to
3513         std::unique_ptr<arm_mapping_symbol_vec[]>.
3514         (arm_compare_mapping_symbols): Remove.
3515         (arm_find_mapping_symbol): Adjust to section_maps type change.
3516         (arm_objfile_data_free): Call delete on arm_per_objfile.
3517         (arm_record_special_symbol): Adjust to section_maps type change.
3518         Allocate arm_per_objfile with new.
3519
3520 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3521
3522         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3523         with the command prefix.
3524
3525 2019-06-25  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3528         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3529
3530 2019-06-25  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3533         type.
3534         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3535         protected.
3536
3537 2019-06-25  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-winsource.c
3540         (tui_source_window_base::set_is_exec_point_at): Add check against
3541         LOA_ADDRESS.
3542
3543 2019-06-25  Tom Tromey  <tom@tromey.com>
3544
3545         * tui/tui-source.c (tui_set_source_content): Don't check before
3546         xfree.
3547         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3548
3549 2019-06-25  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-winsource.h (tui_update_source_window_as_is)
3552         (tui_alloc_source_buffer, tui_line_is_displayed)
3553         (tui_addr_is_displayed): Change type of win_info.
3554         * tui/tui-winsource.c (tui_update_source_window_as_is)
3555         (tui_clear_source_content, tui_show_source_line)
3556         (tui_show_source_content, tui_source_window_base::refill)
3557         (tui_source_window_base::set_is_exec_point_at)
3558         (tui_source_window_base::set_is_exec_point_at)
3559         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3560         (tui_alloc_source_buffer, tui_line_is_displayed)
3561         (tui_addr_is_displayed): Change type of win_info.  Update.
3562         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3563         (tui_source_window_base::do_make_visible_with_new_height):
3564         Update.
3565         * tui/tui-source.c (tui_set_source_content)
3566         (tui_set_source_content_nil)
3567         (tui_source_window::do_scroll_vertical): Update.
3568         * tui/tui-layout.c (show_layout): Update.
3569         * tui/tui-disasm.c (tui_set_disassem_content)
3570         (tui_disasm_window::do_scroll_vertical): Update.
3571         * tui/tui-data.h (tui_win_content): Remove.
3572         (struct tui_gen_win_info) <content, content_size>: Remove.
3573         (struct tui_source_element): Add initializers and destructor.
3574         (union tui_which_element, struct tui_win_element): Remove.
3575         (struct tui_source_window_base) <content>: New field.
3576         (struct tui_data_window): Remove destructor.
3577         (tui_alloc_content, tui_free_win_content)
3578         (tui_free_all_source_wins_content): Don't declare.
3579         * tui/tui-data.c (tui_initialize_static_data): Update.
3580         (init_content_element, tui_alloc_content): Remove.
3581         (~tui_gen_win_info): Update.
3582         (~tui_data_window, tui_free_all_source_wins_content)
3583         (tui_free_win_content, free_content, free_content_elements):
3584         Remove.
3585
3586 2019-06-25  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui-winsource.h (tui_clear_source_content)
3589         (tui_erase_source_content, tui_show_source_content): Change type
3590         of win_info.
3591         * tui/tui-winsource.c (tui_clear_source_content)
3592         (tui_erase_source_content, tui_show_source_content): Change type
3593         of win_info.
3594         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3595         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3596         win_info.
3597         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3598         win_info.
3599         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3600
3601 2019-06-25  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-winsource.c (tui_clear_source_content)
3604         (tui_source_window_base::set_is_exec_point_at): Update.
3605         * tui/tui-source.c (tui_set_source_content_nil): Update.
3606         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3607         a bool.
3608         * tui/tui-data.c (init_content_element): Update.
3609
3610 2019-06-25  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3613         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3614         * tui/tui-layout.c (init_and_make_win): Update.
3615         * tui/tui.h (enum tui_win_type): Update.
3616         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3617         tui_win_is_auxillary.
3618         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3619         tui_win_is_auxillary.
3620
3621 2019-06-25  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3624         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3625         (tui_delete_data_content_windows, tui_display_all_data)
3626         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3627         Update.
3628         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3629         * tui/tui-regs.c (tui_last_regs_line_no)
3630         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3631         (tui_show_registers): Update.
3632         (tui_show_register_group): Return void.  Update.
3633         (tui_display_registers_from, tui_display_reg_element_at_line)
3634         (tui_display_registers_from_line, tui_check_register_values):
3635         Update.
3636         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3637         member.
3638         (struct tui_data_window) <regs_content>: Now a std::vector.
3639         <regs_content_count>: Remove.
3640         (tui_add_content_elements, tui_free_data_content): Don't declare.
3641         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3642         (init_content_element): Remove DATA_WIN case.  Add assert.
3643         (tui_add_content_elements): Remove.
3644         (tui_data_window): Update.
3645         (tui_free_data_content): Remove.
3646         (free_content_elements): Remove DATA_WIN case.
3647
3648 2019-06-25  Tom Tromey  <tom@tromey.com>
3649
3650         * tui/tui-data.c (tui_data_item_window): Update.
3651         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3652         * tui/tui-windata.c (tui_display_all_data)
3653         (tui_display_data_from_line): Update.
3654         (tui_check_data_values): Remove.
3655         * tui/tui-regs.c (tui_show_register_group)
3656         (tui_display_reg_element_at_line): Update.
3657         * tui/tui-hooks.c (tui_register_changed)
3658         (tui_refresh_frame_and_register_information): Call
3659         tui_check_register_values.
3660         * tui/tui-data.h (struct tui_data_window) <data_content,
3661         data_content_count, data_type>: Remove.
3662         (enum tui_data_type): Remove.
3663
3664         * tui/tui-data.c (tui_data_window::clear_detail)
3665         (~tui_data_window): Update.
3666
3667 2019-06-25  Tom Tromey  <tom@tromey.com>
3668
3669         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3670         declare.
3671         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3672         Rename from tui_first_data_item_displayed.  Update.
3673         (tui_data_window::refresh_all)
3674         (tui_data_window::do_scroll_vertical): Update.
3675         * tui/tui-data.h (struct tui_data_window)
3676         <first_data_item_displayed>: Declare new method.
3677
3678 2019-06-25  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3681         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3682         contents...
3683         (tui_initialize_static_data): ...here.
3684
3685 2019-06-25  Tom Tromey  <tom@tromey.com>
3686
3687         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3688         (tui_display_registers_from, tui_check_register_values): Update.
3689         (tui_display_register): Remove win_info parameter; update.
3690         (tui_get_register): Change type of parameters.
3691         * tui/tui-data.h (struct tui_data_element): Remove.
3692         (union tui_which_element) <data>: Remove.
3693         <data_window>: Change type.
3694         (struct tui_data_item_window): New.
3695         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3696         case.  Add assert.
3697         (~tui_data_item_window): New destructor.
3698         (free_content_elements): Remove DATA_ITEM_WIN case.
3699
3700 2019-06-25  Tom Tromey  <tom@tromey.com>
3701
3702         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3703         Remove.
3704
3705 2019-06-25  Tom Tromey  <tom@tromey.com>
3706
3707         * tui/tui-data.h (struct tui_command_element): Remove.
3708         (union tui_which_element) <command>: Remove.
3709         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3710         assert.
3711         (free_content_elements): Remove CMD_WIN case.
3712
3713 2019-06-25  Tom Tromey  <tom@tromey.com>
3714
3715         * tui/tui-layout.c (tui_set_layout): Update.
3716         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3717         * tui/tui-data.c (layout_def): Update.
3718
3719 2019-06-25  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3722         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3723         (tui_source_window_base::set_new_height): Update.
3724         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3725         Update.
3726         (tui_set_locator_fullname, tui_set_locator_info)
3727         (tui_show_frame_info): Update.
3728         * tui/tui-source.c (tui_set_source_content)
3729         (tui_source_is_displayed): Update.
3730         * tui/tui-layout.c (show_source_disasm_command, show_data)
3731         (show_source_or_disasm_and_command): Update.
3732         * tui/tui-disasm.c (tui_set_disassem_content)
3733         (tui_get_begin_asm_address): Update.
3734         * tui/tui-data.h (struct tui_locator_element): Remove.
3735         (union tui_which_element) <locator>: Remove.
3736         (struct tui_locator_window): New.
3737         (tui_locator_win_info_ptr): Change return type.
3738         * tui/tui-data.c (_locator): Change type.
3739         (tui_locator_win_info_ptr): Change return type.
3740         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3741         (tui_alloc_content): Add assert.
3742
3743 2019-06-25  Tom Tromey  <tom@tromey.com>
3744
3745         * tui/tui-winsource.c
3746         (tui_exec_info_window::maybe_allocate_content): New method.
3747         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3748         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3749         (make_source_or_disasm_window): Add cast.
3750         * tui/tui-data.h (union tui_which_element) <simple_string>:
3751         Remove.
3752         (struct tui_source_info): New.
3753         (struct tui_source_window_base) <execution_info>: Change type.
3754         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3755         case, and add assert.
3756         (tui_alloc_content): Add assert.
3757
3758 2019-06-25  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3761         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3762         * tui/tui-data.c (tui_alloc_win_info): Remove.
3763
3764 2019-06-25  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3767         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3768         can_highlight.
3769
3770 2019-06-25  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3773         make_visible_with_new_height method.
3774         (tui_win_info::make_visible_with_new_height): New method.
3775         (tui_source_window_base::do_make_visible_with_new_height)
3776         (tui_data_window::do_make_visible_with_new_height)
3777         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3778         (make_visible_with_new_height): Remove.
3779         (tui_resize_all, tui_adjust_win_heights): Use
3780         make_visible_with_new_height method.
3781         * tui/tui-data.h (struct tui_win_info)
3782         <do_make_visible_with_new_height, make_visible_with_new_height>:
3783         New methods.
3784         (struct tui_source_window_base, struct tui_data_window)
3785         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3786         methods.
3787
3788 2019-06-25  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3791         method.
3792         (update_tab_width): Call update_tab_width method.
3793         * tui/tui-data.h (struct tui_win_info)
3794         (struct tui_source_window_base) <update_tab_width>: New methods.
3795
3796 2019-06-25  Tom Tromey  <tom@tromey.com>
3797
3798         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3799         parameter.
3800         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3801         parameter.
3802         (tui_gen_win_info::make_visible): Update.
3803         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3804         parameter.
3805         * tui/tui-data.h (enum tui_box): New enum.
3806         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3807
3808 2019-06-25  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3811         init_and_make_win for EXEC_INFO_WIN.
3812         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3813         longer inline.
3814         (struct tui_win_info) <~tui_win_info>: Inline.
3815         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3816         Don't declare.
3817         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3818         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3819         Remove.
3820         (tui_initialize_static_data): Update.
3821         (~tui_gen_win_info): Handle more cleanup here.
3822         (~tui_source_window_base): Delete "execution_info".
3823         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3824
3825 2019-06-25  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-layout.c (make_command_window): Don't set
3828         can_highlight.
3829         (show_source_disasm_command): Call the reset method.
3830         (show_data): Don't set can_highlight.  Call the reset method.
3831         (tui_gen_win_info::reset): Rename from init_gen_win_info
3832         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3833         (show_source_or_disasm_and_command): Call the reset method.
3834         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3835         (struct tui_cmd_window): Set can_highlight.
3836
3837 2019-06-25  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3840         from make_visible.
3841         (tui_make_visible, tui_make_invisible): Rewrite.
3842         (tui_win_info::make_visible): Remove.
3843         (tui_source_window_base::make_visible): Update.
3844         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3845         method.  Moved from...
3846         (struct tui_win_info) <make_visible>: ...here.
3847
3848 2019-06-25  Tom Tromey  <tom@tromey.com>
3849
3850         * tui/tui-winsource.c
3851         (tui_source_window_base::do_scroll_horizontal): Remove direction
3852         parameter.
3853         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3854         direction parameter.
3855         * tui/tui-win.c (tui_win_info::forward_scroll)
3856         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3857         (tui_win_info::right_scroll): Update.
3858         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3859         direction parameter.
3860         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3861         direction parameter.
3862         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3863         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3864         Remove direction parameter.
3865         (struct tui_source_window_base, struct tui_source_window)
3866         (struct tui_disasm_window, struct tui_data_window)
3867         (struct tui_cmd_window): Update.
3868
3869 2019-06-25  Tom Tromey  <tom@tromey.com>
3870
3871         * tui/tui-winsource.h (tui_set_exec_info_content)
3872         (tui_show_exec_info_content, tui_erase_exec_info_content)
3873         (tui_clear_exec_info_content, tui_update_exec_info): Change
3874         argument to tui_source_window_base.
3875         * tui/tui-winsource.c (tui_set_exec_info_content)
3876         (tui_show_exec_info_content, tui_erase_exec_info_content)
3877         (tui_clear_exec_info_content, tui_update_exec_info): Change
3878         argument to tui_source_window_base.
3879
3880 2019-06-25  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3883         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3884
3885 2019-06-25  Tom Tromey  <tom@tromey.com>
3886
3887         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3888         check.
3889
3890 2019-06-25  Tom Tromey  <tom@tromey.com>
3891
3892         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3893         type to void.
3894         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3895         type to void.
3896         * tui/tui-source.c (tui_set_source_content): Update.
3897         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3898
3899 2019-06-25  Tom Tromey  <tom@tromey.com>
3900
3901         * tui/tui-win.c (window_name_completer, tui_set_focus)
3902         (tui_all_windows_info): Use name method.
3903         * tui/tui-data.h (struct tui_gen_win_info)
3904         (struct tui_source_window, struct tui_disasm_window)
3905         (struct tui_data_window, struct tui_cmd_window) <name>: New
3906         method.
3907         (tui_win_name): Don't declare.
3908         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3909         (tui_win_name): Remove.
3910
3911 2019-06-25  Tom Tromey  <tom@tromey.com>
3912
3913         * tui/tui-winsource.h (tui_update_source_window)
3914         (tui_update_source_window_as_is): Change parameter type.
3915         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3916         to be a tui_source_window_base.
3917         (tui_update_source_window_as_is): Likewise.
3918         * tui/tui-win.c (make_visible_with_new_height): Update.
3919
3920 2019-06-25  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui-winsource.c (tui_erase_source_content)
3923         (tui_show_source_content, tui_show_exec_info_content)
3924         (tui_erase_exec_info_content): Use refresh_window method.
3925         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3926         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3927         from tui_refresh_win.
3928         (tui_data_window::refresh_window): New method.
3929         (tui_win_info::refresh, tui_source_window_base::refresh)
3930         (tui_refresh_all): Use refresh_window method.
3931         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3932         method.
3933         * tui/tui-regs.c (tui_display_register): Call refresh_window
3934         method.
3935         * tui/tui-layout.c (show_source_disasm_command)
3936         (show_source_or_disasm_and_command): Call refresh_window method.
3937         * tui/tui-data.h (struct tui_gen_win_info)
3938         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3939         New method.
3940
3941 2019-06-25  Tom Tromey  <tom@tromey.com>
3942
3943         * tui/tui.c (tui_rl_other_window, tui_enable)
3944         (tui_is_window_visible, tui_get_command_dimension): Update.
3945         * tui/tui-winsource.c (tui_update_source_window_as_is)
3946         (tui_clear_source_content, tui_erase_source_content)
3947         (tui_show_source_line, tui_source_window_base::refill)
3948         (tui_source_window_base::do_scroll_horizontal)
3949         (tui_source_window_base::set_is_exec_point_at)
3950         (tui_update_breakpoint_info, tui_set_exec_info_content)
3951         (tui_alloc_source_buffer, tui_line_is_displayed)
3952         (tui_addr_is_displayed): Update.
3953         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3954         (tui_check_and_display_highlight_if_needed)
3955         (tui_win_info::make_visible, tui_win_info::refresh)
3956         (tui_refresh_all): Update.
3957         * tui/tui-windata.c (tui_first_data_item_displayed)
3958         (tui_delete_data_content_windows, tui_erase_data_content)
3959         (tui_display_all_data, tui_data_window::refresh_all)
3960         (tui_check_data_values): Update.
3961         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3962         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3963         (tui_win_info::backward_scroll, tui_refresh_all_win)
3964         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3965         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3966         (tui_source_window_base::set_new_height)
3967         (tui_data_window::set_new_height)
3968         (make_invisible_and_set_new_height)
3969         (make_visible_with_new_height, new_height_ok)
3970         (parse_scrolling_args): Update.
3971         * tui/tui-stack.c (tui_show_frame_info): Update.
3972         * tui/tui-source.c (tui_set_source_content)
3973         (tui_set_source_content_nil, tui_source_is_displayed)
3974         (tui_source_window::do_scroll_vertical): Update.
3975         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3976         (tui_display_registers_from, tui_display_reg_element_at_line)
3977         (tui_check_register_values, tui_reg_command): Update.
3978         * tui/tui-layout.c (tui_default_win_height)
3979         (show_source_disasm_command, show_data, init_and_make_win)
3980         (show_source_or_disasm_and_command): Update.
3981         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3982         (tui_redisplay_readline, tui_mld_flush)
3983         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3984         (tui_getc): Update.
3985         * tui/tui-disasm.c (tui_set_disassem_content)
3986         (tui_disasm_window::do_scroll_vertical): Update.
3987         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3988         Now virtual.
3989         (struct tui_win_info): Derive from tui_gen_win_info.
3990         <~tui_win_info>: Mark as override.
3991         <generic>: Remove member.
3992         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3993         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3994         (~tui_data_window, ~tui_win_info)
3995         (tui_free_all_source_wins_content): Update.
3996         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3997
3998 2019-06-25  Tom Tromey  <tom@tromey.com>
3999
4000         * tui/tui-layout.c (init_and_make_win): Use new.
4001         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4002         destructor, initializers.
4003         (tui_alloc_generic_win_info): Don't declare.
4004         * tui/tui-data.c (_locator): Add argument to constructor.
4005         (source_win, disasm_win): New globals.
4006         (exec_info): Remove.
4007         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4008         Update.
4009         (tui_alloc_generic_win_info): Remove.
4010         (init_content_element): Use new.
4011         (tui_win_info::tui_win_info): Update.
4012         (free_content_elements) <case DATA_WIN>: Use delete.
4013
4014 2019-06-25  Tom Tromey  <tom@tromey.com>
4015
4016         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4017         * tui/tui-windata.c (tui_first_data_item_displayed)
4018         (tui_delete_data_content_windows): Update.
4019         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4020         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4021         (tui_display_registers_from, tui_check_register_values): Update.
4022         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4023         pointer.
4024         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4025         window.
4026         (tui_free_data_content): Update.
4027         (free_content_elements) <case DATA_WIN>: Free the window.
4028
4029 2019-06-25  Tom Tromey  <tom@tromey.com>
4030
4031         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4032         Update.
4033         * tui/tui-layout.c (make_command_window)
4034         (show_source_disasm_command, show_data, init_and_make_win)
4035         (show_source_or_disasm_and_command): Update.
4036         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4037         method.
4038         <can_highight, is_highlighted>: Now bool.
4039         (tui_set_win_highlight): Don't declare.
4040         * tui/tui-data.c (tui_set_win_highlight): Remove.
4041
4042 2019-06-25  Tom Tromey  <tom@tromey.com>
4043
4044         * tui/tui-wingeneral.c (make_visible): Remove check of window
4045         type.
4046
4047 2019-06-25  Tom Tromey  <tom@tromey.com>
4048
4049         * tui/tui-win.c (tui_win_info::max_height)
4050         (tui_cmd_window::max_height): New methods.
4051         (new_height_ok): Call max_height.
4052         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4053         <max_height>: New method.
4054
4055 2019-06-25  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-win.c (tui_source_window_base::set_new_height)
4058         (tui_data_window::set_new_height): New methods.
4059         (make_invisible_and_set_new_height): Call set_new_height method.
4060         * tui/tui-data.h (struct tui_win_info)
4061         (struct tui_source_window_base, struct tui_data_window)
4062         <set_new_height>: New method.
4063
4064 2019-06-25  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4067         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4068         tui_refresh_data_win.
4069         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4070         method.
4071         (tui_refresh_all_win): Call the refresh_all method.
4072         (tui_set_focus): Likewise.
4073         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4074         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4075         Likewise.
4076
4077 2019-06-25  Tom Tromey  <tom@tromey.com>
4078
4079         * tui/tui-winsource.h (tui_refill_source_window)
4080         (tui_set_is_exec_point_at): Don't declare.
4081         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4082         (tui_source_window_base::refill): Rename from
4083         tui_refill_source_window.
4084         (tui_source_window_base::do_scroll_horizontal): Update.
4085         (tui_source_window_base::set_is_exec_point_at): Rename from
4086         tui_set_is_exec_point_at.
4087         (tui_update_all_breakpoint_info): Update.
4088         * tui/tui-stack.c (tui_show_frame_info): Update.
4089         * tui/tui-layout.c (show_data): Add cast.
4090         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4091         * tui/tui-data.h (struct tui_source_window_base) <refill,
4092         set_is_exec_point_at>: New methods.
4093         (tui_source_windows, tui_add_to_source_windows): Update types.
4094         (tui_add_to_source_windows): Remove redundant declaration.
4095         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4096         (tui_source_windows): Change return type.
4097         (tui_clear_source_windows_detail): Update.
4098         (tui_add_to_source_windows): Change type of parameter.
4099         (tui_free_all_source_wins_content): Update.
4100
4101 2019-06-25  Tom Tromey  <tom@tromey.com>
4102
4103         * tui/tui-wingeneral.c (tui_win_info::refresh)
4104         (tui_source_window_base::refresh): New methods.
4105         (tui_refresh_all): Call the refresh method.
4106         * tui/tui-data.h (struct tui_win_info)
4107         (struct tui_source_window_base) <refresh>: New method.
4108
4109 2019-06-25  Tom Tromey  <tom@tromey.com>
4110
4111         * tui/tui.h (tui_is_window_visible): Return bool.
4112         * tui/tui.c (tui_is_window_visible): Return bool.
4113         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4114         (tui_make_visible, tui_make_invisible)
4115         (tui_win_info::make_visible)
4116         (tui_source_window_base::make_visible, make_all_visible)
4117         (tui_make_all_visible, tui_make_all_invisible): Update.
4118         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4119         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4120         bool.
4121         (struct tui_win_info, struct tui_source_window_base)
4122         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4123         * tui/tui-data.c (tui_init_generic_part): Update.
4124
4125 2019-06-25  Tom Tromey  <tom@tromey.com>
4126
4127         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4128         (tui_source_window_base::make_visible): New methods.
4129         (make_all_visible): Make method call.
4130         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4131         (struct tui_source_window_base, struct tui_cmd_window): Override
4132         make_visible.
4133         (tui_win_is_source_type): Don't declare.
4134         * tui/tui-data.c (tui_win_is_source_type): Remove.
4135
4136 2019-06-25  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4139         NULL check.
4140
4141 2019-06-25  Tom Tromey  <tom@tromey.com>
4142
4143         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4144         Inline constructor.  Add initializers for members.
4145         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4146         constructors; now inline in class.
4147
4148 2019-06-25  Tom Tromey  <tom@tromey.com>
4149
4150         * tui/tui-regs.c (tui_show_registers): Update.
4151         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4152         bool.
4153         * tui/tui-data.c (tui_data_window::clear_detail)
4154         (tui_data_window): Update.
4155
4156 2019-06-25  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui-windata.c (tui_display_all_data)
4159         (tui_display_data_from_line, tui_display_data_from)
4160         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4161         Update.
4162         * tui/tui-regs.c (tui_last_regs_line_no)
4163         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4164         (tui_show_registers, tui_show_register_group)
4165         (tui_display_registers_from, tui_display_reg_element_at_line)
4166         (tui_display_registers_from_line, tui_check_register_values)
4167         (tui_reg_next, tui_reg_prev): Update.
4168         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4169         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4170         tui_data_window.
4171         (struct tui_win_info) <detail>: Remove.  Add new fields from
4172         tui_data_info.
4173         (TUI_DATA_WIN): Add cast.
4174         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4175         (~tui_data_window): Simplify.
4176
4177 2019-06-25  Tom Tromey  <tom@tromey.com>
4178
4179         * tui/tui-layout.c (show_source_disasm_command)
4180         (show_source_or_disasm_and_command): Update.
4181         * tui/tui-io.c (update_cmdwin_start_line)
4182         (tui_redisplay_readline): Update.
4183         * tui/tui-data.h (struct tui_command_info): Remove.
4184         (struct tui_win_info) <detail>: Remove command_info member.
4185         (struct tui_data_window) <start_line>: New member, from
4186         tui_command_info.
4187         (TUI_CMD_WIN): Add casts.
4188
4189 2019-06-25  Tom Tromey  <tom@tromey.com>
4190
4191         * tui/tui-winsource.c (tui_update_source_window)
4192         (tui_refill_source_window)
4193         (tui_source_window_base::do_scroll_horizontal)
4194         (tui_update_breakpoint_info, tui_set_exec_info_content)
4195         (tui_show_exec_info_content, tui_erase_exec_info_content)
4196         (tui_clear_exec_info_content): Update.
4197         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4198         Update.
4199         * tui/tui-win.c (make_invisible_and_set_new_height)
4200         (make_visible_with_new_height): Update.
4201         * tui/tui-source.c (tui_set_source_content)
4202         (tui_show_symtab_source): Update.
4203         * tui/tui-layout.c (extract_display_start_addr)
4204         (show_source_disasm_command, show_data)
4205         (make_source_or_disasm_window)
4206         (show_source_or_disasm_and_command): Update.
4207         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4208         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4209         "gdbarch".
4210         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4211         to tui_source_window_base.
4212         (struct tui_win_info) <detail>: Remove source_info member.
4213         (struct tui_source_window_base) <has_locator>: Inline.
4214         Move contents from tui_source_info; rename has_locator member to
4215         m_has_locator.
4216         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4217         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4218         header file.
4219         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4220         Simplify.
4221         (tui_free_all_source_wins_content): Cast to
4222         tui_source_window_base.
4223
4224 2019-06-25  Tom Tromey  <tom@tromey.com>
4225
4226         * tui/tui-win.c (make_invisible_and_set_new_height)
4227         (make_visible_with_new_height): Call has_locator method.
4228         * tui/tui-layout.c (show_source_disasm_command, show_data)
4229         (show_source_or_disasm_and_command): Update for bool change.
4230         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4231         (tui_win_info) <has_locator>: New method.
4232         (struct tui_source_window_base) <has_locator>: New method.
4233         (tui_win_has_locator): Don't declare.
4234         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4235         from tui_win_has_locator.
4236         (tui_source_window_base): Use false, not FALSE.
4237
4238 2019-06-25  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4241         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4242         clear_detail method directly.
4243         (tui_clear_win_detail): Remove.
4244
4245 2019-06-25  Tom Tromey  <tom@tromey.com>
4246
4247         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4248         "this", not TUI_DISASM_WIN.
4249
4250 2019-06-25  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4253         declare.
4254         * tui/tui-winsource.c
4255         (tui_source_window_base::do_scroll_horizontal): Rename from
4256         tui_horizontal_source_scroll.
4257         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4258         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4259         from tui_vertical_data_scroll.
4260         * tui/tui-win.h (tui_scroll): Don't declare.
4261         * tui/tui-win.c (tui_win_info::forward_scroll)
4262         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4263         (tui_win_info::right_scroll): Rename and update.
4264         (tui_scroll_forward_command, tui_scroll_backward_command)
4265         (tui_scroll_left_command, tui_scroll_right_command): Update.
4266         (tui_scroll): Remove.
4267         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4268         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4269         from tui_vertical_source_scroll.
4270         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4271         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4272         from tui_vertical_disassem_scroll.
4273         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4274         do_scroll_horizontal>: New methods.
4275         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4276         Likewise.
4277         (struct tui_source_window_base): Add do_scroll_horizontal.
4278         (struct tui_source_window, struct tui_disasm_window): Add
4279         do_scroll_vertical.
4280         (struct tui_data_window, struct tui_cmd_window): Add
4281         do_scroll_horizontal and do_scroll_vertical.
4282         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4283
4284 2019-06-25  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-data.h (struct tui_source_window_base): New struct.
4287         (struct tui_source_window): Derive from tui_source_window_base.
4288         (struct tui_disasm_window): New struct.
4289         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4290         from tui_source_window::clear_detail.
4291         (tui_source_window_base): Rename from tui_source_window.
4292         (~tui_source_window_base): Rename from ~tui_source_window.
4293         (tui_alloc_win_info): Create a tui_disasm_window.
4294
4295 2019-06-25  Tom Tromey  <tom@tromey.com>
4296
4297         * tui/tui-data.h (struct tui_source_window)
4298         (struct tui_data_window): Declare destructors.
4299         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4300         destructors.
4301         (tui_win_info): Simplify.
4302
4303 2019-06-25  Tom Tromey  <tom@tromey.com>
4304
4305         * tui/tui-winsource.c (tui_display_main)
4306         (tui_update_source_windows_with_addr)
4307         (tui_update_all_breakpoint_info): Update.
4308         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4309         (new_height_ok, parse_scrolling_args): Update.
4310         * tui/tui-stack.c (tui_show_frame_info): Update.
4311         * tui/tui-data.h (struct tui_list): Remove.
4312         (tui_source_windows): Return a reference to a std::vector.
4313         * tui/tui-data.c (source_windows): Now a std::vector.
4314         (tui_source_windows): Change return type.
4315         (tui_clear_source_windows): Rewrite.
4316         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4317         (tui_free_all_source_wins_content): Rewrite.
4318
4319 2019-06-25  Tom Tromey  <tom@tromey.com>
4320
4321         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4322         (struct tui_data_window, struct tui_cmd_window): Declare
4323         clear_detail method.
4324         * tui/tui-data.c (tui_source_window::clear_detail)
4325         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4326         methods.
4327         (tui_clear_win_detail): Simplify.
4328
4329 2019-06-25  Tom Tromey  <tom@tromey.com>
4330
4331         * tui/tui-layout.c (make_source_window, make_disasm_window)
4332         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4333         Return the new window.
4334         (show_source_disasm_command, show_data)
4335         (show_source_or_disasm_and_command): Update.
4336
4337 2019-06-25  Tom Tromey  <tom@tromey.com>
4338
4339         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4340         parameter.  Return the new window.
4341         (show_source_disasm_command): Update and remove NULL check.
4342         (show_source_or_disasm_and_command): Update.
4343
4344 2019-06-25  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4347
4348 2019-06-25  Tom Tromey  <tom@tromey.com>
4349
4350         * tui/tui-data.h (struct tui_win_info): Make constructor
4351         protected.  Make destructor virtual.  Add initializers.
4352         (tui_source_window, tui_data_window, tui_cmd_window): New
4353         classes.
4354         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4355         constructor.  Add "type" parameter.
4356         (tui_source_window, tui_data_window, tui_cmd_window): New
4357         constructors.
4358         (tui_alloc_win_info): Instantiate the appropriate subclass.
4359
4360 2019-06-25  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-win.c (tui_resize_all): Use delete.
4363         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4364         destructor.
4365         (tui_free_window): Don't declare.
4366         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4367         Update.
4368
4369 2019-06-25  Tom Tromey  <tom@tromey.com>
4370
4371         * tui/tui-data.h (struct tui_win_info): Add constructor.
4372         * tui/tui-data.c (tui_alloc_win_info): Use new.
4373         (tui_free_window): Use delete.
4374
4375 2019-06-22  Tom Tromey  <tom@tromey.com>
4376
4377         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4378         declare.
4379         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4380
4381 2019-06-22  Tom Tromey  <tom@tromey.com>
4382
4383         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4384         declare.
4385         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4386
4387 2019-06-22  Tom de Vries  <tdevries@suse.de>
4388
4389         * dwarf2read.c (create_addrmap_from_aranges)
4390         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4391         instead of '%zu'.
4392
4393 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4394
4395         * dwarf2read.h (dwarf2_section_info_def): Remove.
4396         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4397         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4398         std::vector<dwarf2_section_info>.
4399         (struct dwo_file) <~dwo_file>: Remove.
4400         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4401         types field.
4402         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4403         (dwarf2_read_debug_names): Likewise.
4404         (create_debug_types_hash_table): Change parameter type to
4405         array_view, adjust code accordingly.
4406         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4407         (partial_die_info::fixup): Likewise.
4408         (determine_prefix): Likewise.
4409         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4410
4411 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4412
4413         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4414         gdb_bfd_ref_ptr.
4415         <~dwo_file>: Remove call to gdb_bfd_unref.
4416         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4417         gdb_bfd_ref_ptr::get.
4418
4419 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4420
4421         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4422         type to htab_up.
4423         * dwarf2read.c (struct dwo_file): Initialize fields.
4424         <~dwo_file>: New.
4425         (free_dwo_file): Remove, move content to ~dwo_file.
4426         (struct dwo_file_deleter): Remove.
4427         (dwo_file_up>: Remove custom deleter.
4428         (free_dwo_files): Remove.
4429         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4430         dwo_files.
4431         (process_skeletonless_type_units): Call unique_ptr::get.
4432         (allocate_dwo_file_hash_table): Add deleter to created hash
4433         table.  Change return type to htab_up.
4434         (lookup_dwo_file_slot): Don't memset dwo_file, call
4435         unique_ptr::get.
4436         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4437         (create_dwo_unit_in_dwp_v2): Likewise.
4438         (open_and_init_dwo_file): Likewise.
4439         (free_dwo_file_from_slot): Remove.
4440
4441 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4442
4443         * dwarf2read.h (struct dwarf2_section_info) <readin,
4444         is_virtual>: Change type to bool.
4445         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4446         true instead of 1.
4447
4448 2019-06-19  Tom Tromey  <tom@tromey.com>
4449
4450         * tui/tui-data.h (tui_init_content_element): Don't declare.
4451
4452 2019-06-19  Tom Tromey  <tom@tromey.com>
4453
4454         * tui/tui-data.h (tui_init_win_info): Don't declare.
4455
4456 2019-06-19  Tom de Vries  <tdevries@suse.de>
4457
4458         * dwarf2read.h (abstract_to_concrete): Change type to
4459         std::unordered_map<sect_offset, std::vector<sect_offset>,
4460         gdb::hash_enum<sect_offset>>.
4461
4462 2019-06-19  Tom Tromey  <tromey@adacore.com>
4463
4464         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4465         EVAL_AVOID_SIDE_EFFECTS specially.
4466
4467 2019-06-19  Tom Tromey  <tromey@adacore.com>
4468
4469         * source-cache.c (highlighter): New global.
4470         (source_cache::get_source_lines): Create a highlighter on demand.
4471
4472 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4473
4474         * defs.h (deprecated_interactive_hook): Delete declaration.
4475         * interps.c (clear_interpreter_hooks): Remove use of
4476         deprecated_interactive_hook.
4477         * top.c (deprecated_interactive_hook): Delete definition.
4478         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4479
4480 2019-06-18  Tom de Vries  <tdevries@suse.de>
4481
4482         PR gdb/24515
4483         * dwarf2read.h (abstract_to_concrete): Change type from
4484         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4485         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4486         * dwarf2read.c (read_variable): Update.
4487         (dwarf2_fetch_die_loc_sect_off): Update.
4488
4489 2019-06-17  Tom de Vries  <tdevries@suse.de>
4490
4491         PR gdb/24617
4492         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4493         accessing parent[parent_len - 1].
4494
4495 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4496
4497         PR gdb/24364
4498         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4499         call dtrace_process_dof with NULL dof.
4500
4501 2019-06-16  Tom de Vries  <tdevries@suse.de>
4502
4503         PR gdb/24445
4504         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4505
4506 2019-06-16  Tom Tromey  <tom@tromey.com>
4507
4508         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4509         (make_all_visible): Use address of member.
4510
4511 2019-06-16  Tom Tromey  <tom@tromey.com>
4512
4513         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4514         (tui_free_window, free_content, free_content_elements): Remove
4515         unnecessary cast.
4516         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4517         cast.
4518         * tui/tui-regs.c (tui_show_register_group)
4519         (tui_display_registers_from, tui_display_reg_element_at_line):
4520         Remove unnecessary cast.
4521
4522 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4523
4524         * linux-nat.c (normal_mask): Delete.
4525         (_initialize_linux_nat): Don't initialise normal_mask.
4526
4527 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4528
4529         PR gdb/24445
4530         * dwarf-index-write.h (write_psymtabs_to_index): Add
4531         dwz_basename parameter.
4532         * dwarf-index-write.c (write_gdbindex): Move file writing to
4533         write_gdbindex_1.  Change return type void.
4534         (assert_file_size): Move up, remove filename parameter.
4535         (write_gdbindex_1): New function.
4536         (write_debug_names): Change return type to void, call
4537         assert_file_size.
4538         (struct index_wip_file): New struct.
4539         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4540         file logic to index_wip_file.  Write index for dwz file if
4541         needed.
4542         (save_gdb_index_command): Pass basename of dwz file, if present.
4543         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4544         build-id of dwz file, if present.
4545         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4546         (dwarf2_get_dwz_file): Likewise.
4547         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4548         (dwarf2_get_dwz_file): Likewise.
4549
4550 2019-06-16  Tom Tromey  <tom@tromey.com>
4551
4552         * coffread.c (process_coff_symbol): Use xstrdup.
4553         * value.c (create_internalvar): Use xstrdup.
4554
4555 2019-06-16  Tom Tromey  <tom@tromey.com>
4556
4557         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4558         * breakpoint.c (stopin_command, stopat_command)
4559         (until_break_command, decode_location_default): Remove unnecessary
4560         cast.
4561         * utils.c (subset_compare): Remove unnecessary cast.
4562         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4563         cast.
4564         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4565         cast.
4566         * infcmd.c (path_command): Remove unnecessary cast.
4567         * coffread.c (decode_type): Remove unnecessary cast.
4568         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4569         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4570         * tui/tui-stack.c (tui_show_locator_content)
4571         (tui_show_frame_info): Remove unnecessary cast.
4572         * tui/tui-win.c (tui_scroll_forward_command)
4573         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4574         (parse_scrolling_args): Remove unnecessary cast.
4575         * tui/tui-data.c (init_win_info, tui_del_window)
4576         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4577         (free_content_elements): Remove unnecessary cast.
4578         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4579         unnecessary cast.
4580         * tui/tui-source.c (tui_set_source_content)
4581         (tui_vertical_source_scroll): Remove unnecessary cast.
4582         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4583         cast.
4584         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4585         * tui/tui-regs.c (tui_display_registers_from)
4586         (tui_display_register): Remove unnecessary cast.
4587         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4588         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4589         (make_visible): Remove unnecessary cast.
4590         * tui/tui-winsource.c (tui_erase_source_content)
4591         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4592         unnecessary cast.
4593         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4594         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4595         * stabsread.c (read_type, read_array_type, read_range_type):
4596         Remove unnecessary cast.
4597         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4598         (parse_symbol, parse_type, upgrade_type, parse_external)
4599         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4600         unnecessary cast.
4601         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4602
4603 2019-06-16  Tom Tromey  <tom@tromey.com>
4604
4605         * tui/tui-data.c (tui_alloc_generic_win_info)
4606         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4607         checks.
4608
4609 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4610             Andrew Burgess  <andrew.burgess@embecosm.com>
4611
4612         * f-typeprint.c (f_print_type): Don't return early for not
4613         associated or not allocated types.
4614         (f_type_print_varspec_suffix): Add print_rank parameter and print
4615         ranks of array types in case they dangling.
4616         (f_type_print_base): Add print_rank parameter.
4617
4618 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * NEWS: Mention new MI commands.
4621         * break-catch-throw.c (enum exception_event_kind): Move to
4622         breakpoint.h.
4623         (print_mention_exception_catchpoint): Output text as a single
4624         message.
4625         (catch_exception_command_1): Rename to...
4626         (catch_exception_event): ...this, make non-static, update header
4627         command, and change some parameter types.
4628         (catch_catch_command): Update for changes to
4629         catch_exception_command_1.
4630         (catch_throw_command): Likewise.
4631         (catch_rethrow_command): Likewise.
4632         * breakpoint.c (enum exception_event_kind): Delete.
4633         * breakpoint.h (enum exception_event_kind): Moved here from
4634         break-catch-throw.c.
4635         (catch_exception_event): Declare.
4636         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4637         (mi_cmd_catch_throw): New function.
4638         (mi_cmd_catch_rethrow): New function.
4639         (mi_cmd_catch_catch): New function.
4640         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4641         'catch-catch' entries.
4642         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4643         (mi_cmd_catch_rethrow): Declare.
4644         (mi_cmd_catch_catch): Declare.
4645
4646 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4647
4648         * annotate.c (annotate_source_line): Change return type to void,
4649         update implementation to match.
4650         * annotate.h (annotate_source_line): Change return type to void,
4651         update header comment.
4652         * stack.c (print_frame_info): Don't change what frame information
4653         is printed based on whether annotations are on or not.
4654
4655 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4658         (annotate_source): Make static.
4659         (annotate_source_line): Moved from source.c and renamed from
4660         identify_source_line.  Update the return type.
4661         * annotate.h (annotate_source): Delete declaration.
4662         (annotate_source_line): Declaration moved from source.h, and
4663         renamed from identify_source_line.  Return type updated.
4664         * source.c (identify_source_line): Moved to annotate.c and renamed
4665         to annotate_source_line.
4666         (info_line_command): Remove check of annotation_level.
4667         * source.h (identify_source_line): Move declaration to annotate.h
4668         and rename to annotate_source_line.
4669         * stack.c: Add 'annotate.h' include.
4670         (print_frame_info): Remove check of annotation_level before
4671         calling annotate_source_line.
4672
4673 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * source-cache.c (source_cache::get_plain_source_lines): Use
4676         open_source_file_with_line_charpos instead of just
4677         open_source_file, remove call to find_source_lines.
4678         (source_cache::get_source_lines): Likewise.
4679         * source.c (find_source_lines): Make static.
4680         (get_filename_and_charpos): Renamed into...
4681         (open_source_file_with_line_charpos): ..this along with changes to
4682         return a scoped_fd, and some other minor clean ups.
4683         (identify_source_line): Use open_source_file_with_line_charpos.
4684         (search_command_helper): Use open_source_file_with_line_charpos
4685         instead of just open_source_file, remove call to
4686         find_source_lines.
4687         * source.h (open_source_file_with_line_charpos): Declare new
4688         function.
4689         (find_source_lines): Delete declaration.
4690
4691 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4692
4693         * source.c (get_filename_and_charpos): Remove fullname
4694         parameter.
4695         (identify_source_line): Update call to get_filename_and_charpos.
4696
4697 2019-06-14  Tom Tromey  <tromey@adacore.com>
4698
4699         PR gdb/24502:
4700         * ui-style.h (skip_ansi_escape): Update comment.
4701         * ui-file.h (class no_terminal_escape_file): New class.
4702         * ui-file.c (no_terminal_escape_file::write)
4703         (no_terminal_escape_file::puts): New methods.
4704         * cli/cli-logging.c (handle_redirections): Use
4705         no_terminal_escape_file.
4706
4707 2019-06-14  Tom Tromey  <tromey@adacore.com>
4708
4709         * NEWS: Move convenience variable news above Python news.
4710
4711 2019-06-14  Tom Tromey  <tom@tromey.com>
4712
4713         * gnulib: Move directory to top-level.
4714         * configure.ac: Don't configure gnulib.
4715         * configure: Rebuild.
4716         * common/common-defs.h: Use new path to gnulib.
4717         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4718         (GNULIB_H): Remove.
4719         (INCGNU): Look in new gnulib location.
4720         (HFILES_NO_SRCDIR): Remove gnulib files.
4721         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4722         (generated_files): Remove GNULIB_H.
4723         ($(LIBGNU), all-lib): Remove targets.
4724         (distclean): Don't mention GNULIB_BUILDDIR.
4725         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4726
4727 2019-06-14  Tom Tromey  <tromey@adacore.com>
4728
4729         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4730         Warn if symbol file does not provide any symbols.
4731
4732 2019-06-14  Tom Tromey  <tromey@adacore.com>
4733
4734         * source.c (find_and_open_source): Respect basenames_may_differ.
4735
4736 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4737
4738         * annotate.c (annotate_breakpoints_invalid): Make use of
4739         scoped_restore_terminal_state.
4740         (annotate_frames_invalid): Likewise.
4741
4742 2019-06-14  Tom Tromey  <tromey@adacore.com>
4743
4744         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4745         allow assignment to an internalvar.
4746
4747 2019-06-14  Tom Tromey  <tromey@adacore.com>
4748
4749         * ada-lex.l: Allow "_" in attribute names.
4750
4751 2019-06-14  Tom Tromey  <tromey@adacore.com>
4752
4753         PR gdb/24653:
4754         * regcache.c (registers_changed): Don't call alloca.
4755         * top.c (execute_command): Don't call alloca.
4756
4757 2019-06-13  Pedro Alves  <palves@redhat.com>
4758
4759         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4760         'expression'.  When parsing an expression, error out if there's
4761         junk after "unlimited".
4762         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4763         (do_set_command): Adjust calls to is_unlimited_literal.
4764
4765 2019-06-13  Pedro Alves  <palves@redhat.com>
4766
4767         * compile/compile.c (make_compile_options_def_group): Add braces
4768         around array_view initializer.
4769         * thread.c (make_thread_apply_all_options_def_group)
4770         (make_thread_apply_all_options_def_group): Likewise.
4771
4772 2019-06-13  Pedro Alves  <palves@redhat.com>
4773
4774         * NEWS (New commands): Mention "maint test-options
4775         require-delimiter", "maint test-options unknown-is-error", "maint
4776         test-options unknown-is-operand" and "maint show
4777         test-options-completion-result".
4778         (New command options, command completion): New section.
4779         (Completion improvements): New section.
4780         Mention that you can abbreviate "unlimited".
4781
4782 2019-06-13  Pedro Alves  <palves@redhat.com>
4783
4784         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4785         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4786         * unittests/cli-utils-selftests.c (test_parse_flags)
4787         (test_parse_flags_qcs): Delete.
4788         (test_cli_utils): Don't call deleted functions.
4789
4790 2019-06-13  Pedro Alves  <palves@redhat.com>
4791
4792         * thread.c: Include "cli/cli-option.h".
4793         (tp_array_compar_ascending): Global.
4794         (tp_array_compar): Delete function.
4795         (tp_array_compar_ascending, tp_array_compar_descending): New
4796         functions.
4797         (ascending_option_def, qcs_flag_option_def)
4798         (thr_qcs_flags_option_defs)
4799         (make_thread_apply_all_options_def_group)
4800         (make_thread_apply_options_def_group): New.
4801         (thread_apply_all_command): Use gdb::option::process_options.
4802         (thread_apply_command_completer)
4803         (thread_apply_all_command_completer): New.
4804         (thread_apply_command): Use gdb::option::process_options.
4805         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4806         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4807         to generate help text of "thread apply".  Adjust "taas"'s help.
4808         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4809         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4810
4811 2019-06-13  Pedro Alves  <palves@redhat.com>
4812
4813         * thread.c (thread_apply_command): Check for invalid TID with
4814         isdigit instead of !isalpha.
4815
4816 2019-06-13  Pedro Alves  <palves@redhat.com>
4817
4818         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4819         (validate_flags_qcs): New.
4820         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4821         (validate_flags_qcs): Declare.
4822         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4823         (make_frame_apply_options_def_group): New.
4824         (frame_apply_command_count): Process options with
4825         gdb::option::process_options.
4826         (frame_apply_completer): New.
4827         (frame_apply_level_completer, frame_apply_all_completer)
4828         (frame_apply_completer): New.
4829         (_initialize_stack): Update help of "frame apply", "frame apply
4830         level", "frame apply all" and "faas" to mention supported options
4831         and install command completers.
4832         * stack.h (frame_apply_all_completer): Declare.
4833         * thread.c: Include "stack.h".
4834         (tfaas_command): Add "--".
4835         (_initialize_thread): Update help "tfaas" to mention supported
4836         options and install command completer.
4837
4838 2019-06-13  Pedro Alves  <palves@redhat.com>
4839
4840         * completer.c (complete_nested_command_line): New.
4841         (gdb_completion_word_break_characters_throw): Add assertion.
4842         * completer.h (complete_nested_command_line): Declare.
4843
4844 2019-06-13  Pedro Alves  <palves@redhat.com>
4845
4846         * stack.c (parse_backtrace_qualifiers): New.
4847         (backtrace_command): Use it.
4848         (backtrace_command_completer): Complete on qualifiers.
4849
4850 2019-06-13  Pedro Alves  <palves@redhat.com>
4851
4852         * frame.c: Include "cli/cli-option.h.
4853         (user_set_backtrace_options): New.
4854         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4855         Delete.
4856         (get_prev_frame): Adjust.
4857         (boolean_option_def, uinteger_option_def)
4858         (set_backtrace_option_defs): New.
4859         (_initialize_frame): Adjust and use
4860         gdb::option::add_setshow_cmds_for_options to install "set
4861         backtrace past-main" and "set backtrace past-entry".
4862         * frame.h: Include "cli/cli-option.h".
4863         (struct frame_print_options): Forward declare.
4864         (print_frame_arguments_all, print_frame_arguments_scalars)
4865         (print_frame_arguments_none): Declare.
4866         (print_entry_values): Delete declaration.
4867         (struct frame_print_options, user_frame_print_options): New.
4868         (struct set_backtrace_options): New.
4869         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4870         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4871         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4872         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4873         (list_args_or_locals): Add frame_print_options parameter.
4874         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4875         * python/py-framefilter.c (enumerate_args): Pass down
4876         USER_FRAME_PRINT_OPTIONS.
4877         * stack.c: Include "cli/cli-option.h".
4878         (print_frame_arguments_all, print_frame_arguments_scalars)
4879         (print_frame_arguments_none): Declare.
4880         (print_raw_frame_arguments, print_entry_values): Delete.
4881         (user_frame_print_options): New.
4882         (boolean_option_def, enum_option_def, frame_print_option_defs):
4883         New.
4884         (struct backtrace_cmd_options): New.
4885         (bt_flag_option_def): New.
4886         (backtrace_command_option_defs): New.
4887         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4888         (print_frame_arg, read_frame_arg, print_frame_args)
4889         (print_frame_info, print_frame): Add frame_print_options parameter
4890         and use it.
4891         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4892         (backtrace_command_1): Add frame_print_options and
4893         backtrace_cmd_options parameters and use them.
4894         (make_backtrace_options_def_group): New.
4895         (backtrace_command): Process command options with
4896         gdb::option::process_options.
4897         (backtrace_command_completer): New.
4898         (_initialize_stack): Extend "backtrace"'s help to mention
4899         supported options.  Install completer for "backtrace".
4900         Install some settings commands with add_setshow_cmds_for_options.
4901
4902 2019-06-13  Pedro Alves  <palves@redhat.com>
4903
4904         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4905         and that "set/show print raw frame-arguments" are now deprecated.
4906
4907         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4908         command.
4909         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4910         * stack.c (_initialize_stack): Install "set/show print
4911         raw-frame-arguments", and deprecate "set/show print raw
4912         frame-arguments".
4913         * valprint.c (_initialize_valprint): Deprecate "set/show print
4914         raw".
4915
4916 2019-06-13  Pedro Alves  <palves@redhat.com>
4917
4918         * compile/compile.c (struct compile_options): New.
4919         (compile_flag_option_def, compile_command_option_defs)
4920         (make_compile_options_def_group): New.
4921         (compile_file_command): Handle options with
4922         gdb::option::process_options.
4923         (compile_file_command_completer): New function.
4924         (compile_code_command): Handle options with
4925         gdb::option::process_options.
4926         (compile_code_command_completer): New function.
4927         (_initialize_compiler): Install completers for "compile code" and
4928         "compile file".  Mention available options in "compile code" and
4929         "compile code"'s help.
4930         * completer.c (advance_to_completion_word): New, factored out from
4931         ...
4932         (advance_to_expression_complete_word_point): ... this.
4933         (advance_to_filename_complete_word_point): New.
4934         * completer.h (advance_to_filename_complete_word_point): New
4935         declaration.
4936
4937 2019-06-13  Pedro Alves  <palves@redhat.com>
4938
4939         * compile/compile.c: Include "cli/cli-option.h".
4940         (compile_print_value): Scope data pointer is now a
4941         value_print_options pointer; adjust.
4942         (compile_print_command): Process options.  Scope data pointer is
4943         now a value_print_options pointer; adjust.
4944         (_initialize_compile): Update "compile print"'s help to include
4945         supported options.  Install a completer for "compile print".
4946         * cp-valprint.c (show_vtblprint, show_objectprint)
4947         (show_static_field_print): Delete.
4948         (_initialize_cp_valprint): Don't install "set print
4949         static-members", "set print vtbl", "set print object" here.
4950         * printcmd.c: Include "cli/cli-option.h" and
4951         "common/gdb_optional.h".
4952         (print_command_parse_format): Rework to fill in a
4953         value_print_options instead of a format_data.
4954         (print_value): Change parameter type from format_data pointer to
4955         value_print_options reference.  Adjust.
4956         (print_command_1): Process options.  Adjust to pass down a
4957         value_print_options.
4958         (print_command_completer): New.
4959         (_initialize_printcmd): Install print_command_completer as
4960         handle_brkchars completer for the "print" command.  Update
4961         "print"'s help to include supported options.
4962         * valprint.c: Include "cli/cli-option.h".
4963         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4964         here from cp-valprint.c.
4965         (boolean_option_def, uinteger_option_def)
4966         (value_print_option_defs, make_value_print_options_def_group):
4967         New.  Use gdb::option::add_setshow_cmds_for_options to install
4968         "set print elements", "set print null-stop", "set print repeats",
4969         "set print pretty", "set print union", "set print array", "set
4970         print address", "set print symbol", "set print array-indexes".
4971         * valprint.h: Include <string> and "cli/cli-option.h".
4972         (make_value_print_options_def_group): Declare.
4973         (print_value): Change parameter type from format_data pointer to
4974         value_print_options reference.
4975         (print_command_completer): Declare.
4976
4977 2019-06-13  Pedro Alves  <palves@redhat.com>
4978
4979         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4980         (COMMON_SFILES): Add maint-test-settings.c.
4981         * cli/cli-decode.c (boolean_enums): New global, factored out from
4982         ...
4983         (add_setshow_boolean_cmd): ... here.
4984         * cli/cli-decode.h (boolean_enums): Declare.
4985         * cli/cli-option.c: New file.
4986         * cli/cli-option.h: New file.
4987         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4988         factored out from ...
4989         (parse_cli_boolean_value(const char *)): ... this.
4990         (is_unlimited_literal): Change parameter type to pointer to
4991         pointer.  Adjust and advance ARG pointer.
4992         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4993         (parse_cli_var_enum): New, factored out from ...
4994         (do_set_command): ... this.  Adjust.
4995         * cli/cli-setshow.h (parse_cli_boolean_value)
4996         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4997         (parse_cli_var_enum): Declare.
4998         * cli/cli-utils.c: Include "cli/cli-option.h".
4999         (get_ulongest): New.
5000         * cli/cli-utils.h (get_ulongest): Declare.
5001         (check_for_argument): New overloads.
5002         * maint-test-options.c: New file.
5003
5004 2019-06-13  Pedro Alves  <palves@redhat.com>
5005
5006         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5007         parse a range if "-" is at the end of the string.
5008
5009 2019-06-13  Pedro Alves  <palves@redhat.com>
5010
5011         * cli/cli-setshow.c (parse_auto_binary_operation)
5012         (parse_cli_boolean_value): Don't allow "o".
5013
5014 2019-06-13  Pedro Alves  <palves@redhat.com>
5015
5016         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5017         * NEWS: Mention maint test-settings KIND.
5018         * maint-test-settings.c: New file.
5019
5020 2019-06-13  Pedro Alves  <palves@redhat.com>
5021
5022         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5023         completer.
5024         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5025         "set" completers.
5026
5027 2019-06-13  Pedro Alves  <palves@redhat.com>
5028
5029         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5030         after item.
5031
5032 2019-06-13  Pedro Alves  <palves@redhat.com>
5033
5034         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5035
5036 2019-06-13  Pedro Alves <palves@redhat.com>
5037
5038         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5039         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5040         call.
5041         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5042         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5043         calls.
5044         (check_for_argument): Skip spaces after argument.
5045
5046 2019-06-13  Pedro Alves  <palves@redhat.com>
5047
5048         * thread.c (thread_apply_command): Adjust TID parsing.
5049         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5050         detected before end of string.
5051         (tid_is_in_list): Error out if LIST is invalid.
5052
5053 2019-06-13  Pedro Alves  <palves@redhat.com>
5054
5055         * completer.c (complete_line_internal_1): Rewind completion word
5056         point.
5057         (completion_tracker::advance_custom_word_point_by): Change
5058         parameter type to int.
5059         * completer.h (completion_tracker::advance_custom_word_point_by):
5060         Likewise.
5061
5062 2019-06-13  Pedro Alves  <palves@redhat.com>
5063
5064         * completer.c (advance_to_completion_word): Handle delimiters.
5065
5066 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5067
5068         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5069
5070 2019-06-11  Tom Tromey  <tom@tromey.com>
5071
5072         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5073         (xmalloc_failed): Move to alloc.c.
5074         * alloc.c: New file.
5075         * Makefile.in (COMMON_SFILES): Add alloc.c.
5076
5077 2019-06-11  Tom Tromey  <tom@tromey.com>
5078
5079         * nat/linux-waitpid.c: Don't include server.h.
5080         (linux_debug): Remove.
5081         (my_waitpid): Update.
5082
5083 2019-06-11  Tom Tromey  <tromey@adacore.com>
5084
5085         * infcall.c (_initialize_infcall): Remove trailing newline from
5086         help.
5087         * user-regs.c (_initialize_user_regs): Remove trailing newline
5088         from help.
5089         * typeprint.c (_initialize_typeprint): Remove trailing newline
5090         from help.
5091         * reverse.c (_initialize_reverse): Remove trailing newlines from
5092         help.
5093         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5094         from help.
5095         * language.c (add_set_language_command): Remove trailing newline
5096         from help.
5097         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5098         help.
5099         * disasm.c (_initialize_disasm): Remove trailing newline from
5100         help.
5101         * top.c (init_main): Remove trailing newline from help.
5102         * interps.c (_initialize_interpreter): Remove trailing newline
5103         from help.
5104         * btrace.c (_initialize_btrace): Remove trailing newlines from
5105         help.
5106         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5107         from help.
5108         * python/python.c (_initialize_python): Remove trailing newline
5109         from help.
5110         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5111         help.
5112         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5113         from help.  Reformat some text.
5114         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5115         from help.
5116         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5117         newline from help.
5118
5119 2019-06-11  Tom Tromey  <tromey@adacore.com>
5120
5121         * darwin-nat.c (darwin_decode_exception_message)
5122         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5123
5124 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * valops.c (value_slice): Check for not allocated or not
5127         associated values.
5128
5129 2019-06-10  Tom de Vries  <tdevries@suse.de>
5130
5131         PR gdb/24618
5132         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5133         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5134         invalid.
5135
5136 2019-06-10  Tom de Vries  <tdevries@suse.de>
5137
5138         PR gdb/24611
5139         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5140         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5141
5142 2019-06-10  Tom de Vries  <tdevries@suse.de>
5143
5144         PR symtab/24545
5145         * symtab.c (struct demangled_name_entry): Add language field.
5146         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5147         static minimal symbol".  Set and use language field.
5148
5149 2019-06-10  Tom Tromey  <tromey@adacore.com>
5150
5151         * ada-lang.c (_initialize_ada_language): Update help text.
5152
5153 2019-06-10  Tom Tromey  <tromey@adacore.com>
5154
5155         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5156         with a newline.
5157         * guile/guile.c (handle_boot_error): Don't end warning with a
5158         newline.
5159         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5160         warning with a newline.
5161         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5162         newline.
5163         (s12z_frame_cache): Likewise.
5164         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5165         a newline.
5166         * solib-svr4.c (disable_probes_interface): Don't end warning with
5167         a newline.
5168         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5169         newline.
5170         * python/python.c (do_finish_initialization): Don't end warning
5171         with a newline.
5172
5173 2019-06-10  Tom Tromey  <tom@tromey.com>
5174
5175         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5176         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5177         gdbpy_enter.
5178
5179 2019-06-10  Tom Tromey  <tromey@adacore.com>
5180
5181         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5182         data.
5183         (elf_new_init): Don't call stabsread_new_init.
5184         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5185         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5186         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5187
5188 2019-06-10  Tom de Vries  <tdevries@suse.de>
5189
5190         PR symtab/16264
5191         PR symtab/24517
5192         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5193
5194 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5195
5196         * source.c (find_and_open_source): Also rewrite relative file
5197         names.
5198
5199 2019-04-26  Amos Bird  <amosbird@gmail.com>
5200
5201         * annotate.c (annotate_thread_exited): Add "thread-exited"
5202         annotation.
5203
5204 2019-06-06  Tom Tromey  <tromey@adacore.com>
5205
5206         * maint.h (class scoped_command_stats): Use
5207         DISABLE_COPY_AND_ASSIGN.
5208         <print_time>: New method.
5209         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5210         print_time.
5211         (scoped_command_stats::print_time): New method.
5212
5213 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5214
5215         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5216         instructions of lengths 6 or 8 bytes.
5217
5218 2019-06-04  Pedro Alves  <palves@redhat.com>
5219
5220         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5221
5222         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5223         * breakpoint.c (condition_completer): Likewise.
5224         * cli/cli-dump.c (scan_expression): Likewise.
5225         * common/filestuff.c (mkdir_recursive): Likewise.
5226         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5227         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5228         (gdb_abspath): Likewise.
5229         * compile/compile-cplus-types.c
5230         (compile_cplus_instance::decl_name): Likewise.
5231         * completer.c (complete_explicit_location):
5232         (signal_completer, reg_or_group_completer_1): Likewise.
5233         * cp-support.c (cp_remove_params_if_any): Likewise.
5234         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5235         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5236         * infcmd.c (strip_bg_char): Likewise.
5237         * linespec.c (copy_token_string): Likewise.
5238         * mi/mi-main.c (output_cores): Likewise.
5239         * psymtab.c (psymtab_search_name):
5240         * symfile.c (test_set_ext_lang_command): Likewise.
5241         * target.c (target_fileio_read_stralloc): Likewise.
5242         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5243         * value.c (complete_internalvar): Likewise.
5244
5245 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5246
5247         Add objfile property to gdb.Type.
5248         * NEWS: Mention Python API addition.
5249         * python/py-type.c (typy_get_objfile): New method.
5250
5251 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5252
5253         * NEWS: Mention the new set|show style [title|highlight].
5254         Mention changes to "show style", "help" and "apropos".
5255
5256 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5257
5258         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5259         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5260         instead of print_help_for_command.
5261         (print_doc_of_command): New function.
5262         (help_list): Add 'apropos -v word' suggestion.
5263         (print_help_for_command): Style the command name using title style.
5264         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5265         (_initialize_cli_cmds): Describe -v in apropos_command help.
5266
5267 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5268
5269         * cli/cli-style.h (cli_style_option): Add name in constructor,
5270         add m_name class member, add constructor with intensity,
5271         add name class function.
5272         (cli_style_option::add_setshow_commands): Remove name argument.
5273         (highlight_style, title_style): New styles.
5274         * cli/cli-style.c (do_show): New function that shows a style
5275         characteristic styling the style name with itself.
5276         (set_style_name): New function.
5277         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5278         Update all callers according to the changes in cli/cli-style.h.
5279         * utils.h (fputs_highlighted): New function.
5280         * utils.c (fputs_highlighted): Likewise.
5281
5282 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5283
5284         * NEWS: Mention new pipe command and new convenience variables.
5285
5286 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5287
5288         * cli/cli-cmds.c (pipe_command): New function.
5289         (_initialize_cli_cmds): Call add_com for pipe_command.
5290         Define | as an alias for pipe.
5291         (exit_status_set_internal_vars): New function.
5292         (shell_escape): Call exit_status_set_internal_vars.
5293         cli/cli-decode.c (find_command_name_length): Recognize | as
5294         a single character command.
5295
5296 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5297
5298         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5299         top.c (execute_command_to_ui_file): New function, mostly a copy
5300         of execute_command_to_string.
5301         (execute_command_to_string): Implement by calling
5302         execute_command_to_ui_file.
5303
5304 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5305
5306         * top.h (saved_command_line): Remove declaration.
5307         * top.c (previous_saved_command_line, previous_repeat_arguments):
5308         New variables.
5309         (saved_command_line): Make static, define together with other
5310         'repeat variables'.
5311         (dont_repeat): Clear repeat_arguments.
5312         (repeat_previous, get_saved_command_line, save_command_line):
5313         New functions.
5314         (gdb_init): Initialize saved_command_line
5315         and previous_saved_command_line.
5316         * main.c (captured_main_1): Remove saved_command_line initialization.
5317         * event-top.c (handle_line_of_input): Update to use
5318         the new 'repeat' related functions instead of direct access to
5319         saved_command_line.
5320         * command.h (repeat_previous, get_saved_command_line,
5321         save_command_line): New declarations.
5322         (dont_repeat): Add comment.
5323
5324 2019-05-30  Tom Tromey  <tromey@adacore.com>
5325
5326         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5327         Fix comment.
5328         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5329
5330 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5331
5332         PR cli/24587
5333         * completer.c (complete): Initialize variable word.
5334
5335 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5336
5337         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5338         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5339         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5340         'body' is NULL to the outter 'if', protecting the '!is_define'
5341         situation as well.
5342
5343 2019-05-29  Tom Tromey  <tromey@adacore.com>
5344
5345         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5346         (dwarf_unknown): New function.
5347         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5348         (dwarf_type_encoding_name): Use dwarf_unknown.
5349
5350 2019-05-29  Tom Tromey  <tromey@adacore.com>
5351
5352         PR c++/20020:
5353         * cp-valprint.c (cp_print_value_fields): Call
5354         cp_print_static_field inside "try".
5355
5356 2019-05-29  Tom Tromey  <tromey@adacore.com>
5357
5358         * inflow.c (struct terminal_info): Add default operator=.
5359         * configure: Rebuild.
5360         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5361         -Wdeprecated-copy-dtor, -Wredundant-move.
5362
5363 2019-05-29  Tom Tromey  <tromey@adacore.com>
5364
5365         * NEWS: Add entry.
5366         * infcmd.c (print_return_value_1): Handle finish_print
5367         option.
5368         (show_print_finish): New function.
5369         (_initialize_infcmd): Add "set/show print finish" commands.
5370         * valprint.c (user_print_options): Initialize new member.
5371         * valprint.h (struct value_print_options) <finish_print>: New
5372         member.
5373
5374 2019-05-28  Tom Tromey  <tromey@adacore.com>
5375
5376         * ada-lang.c (ada_remove_Xbn_suffix)
5377         (find_old_style_renaming_symbol)
5378         (parse_old_style_renaming): Remove.
5379         (ada_find_renaming_symbol): Don't call
5380         find_old_style_renaming_symbol.
5381         (ada_is_renaming_symbol): Rename from
5382         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5383         bool.  Now static.
5384         (ada_read_var_value): Update and simplify.
5385         * ada-exp.y (write_var_or_type): Remove old code.
5386
5387 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5388
5389         * event-top.c: Remove include comment.
5390         * inflow.c (class scoped_ignore_sigttou): Move from here...
5391         * inflow.h (class scoped_ignore_sigttou): ...to here.
5392         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5393         * top.c:  Remove include comment.
5394
5395 2019-05-27  Tom Tromey  <tom@tromey.com>
5396
5397         * NEWS: Fix typo.
5398
5399 2019-05-22  Tom Tromey  <tromey@adacore.com>
5400
5401         * target.c (target_follow_exec): Constify parameter.
5402         * target-delegates.c: Rebuild.
5403         * remote.c (remote_target::follow_exec): Constify parameter.
5404         * infrun.c (follow_exec): Constify parameter.
5405         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5406         (target_follow_exec): Likewise.
5407
5408 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5409
5410         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5411         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5412
5413 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5414
5415         * NEWS: Add debugredirect and testsuite sections.
5416
5417 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5418
5419         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5420         target descriptions using exclusively floating point register name
5421         aliases.
5422
5423 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5424
5425         PR gdb/18644:
5426         * f-lang.c (build_fortran_types): Handle the case where
5427         gdbarch_floatformat_for_type returns a nullptr.
5428
5429 2019-05-21  Tom de Vries  <tdevries@suse.de>
5430
5431         PR cli/24587
5432         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5433
5434 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5435
5436         PR gdb/18644:
5437         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5438         16-byte floats.
5439         * i386-tdep.c (i386_floatformat_for_type): Use
5440         floatformats_ia64_quad for the 16-byte floating point component
5441         within a fortran 32-byte complex number.
5442
5443 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5444
5445         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5446         delete default constructor.
5447         (find_partial_die): Update to return const struct.
5448         (partial_die_parent_scope): Move variable declaration into scope
5449         of its use and change its type to auto.
5450         (guess_partial_die_structure_name): Likewise.
5451         (partial_die_info::fixup): Likewise.
5452
5453 2019-05-17  Tom Tromey  <tromey@adacore.com>
5454
5455         * source.c (find_and_open_source): Remove cast.
5456
5457 2019-05-17  Tom Tromey  <tromey@adacore.com>
5458
5459         * annotate.c (annotate_source): Make "filename" const.
5460         * annotate.h (annotate_source): Use const.
5461
5462 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5463
5464         * disasm.c (set_disassembler_options): Send errors to stderr.
5465
5466 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5467
5468         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5469         (cli_interp_base::set_logging): Check debug_redirect.
5470         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5471         * cli/cli-logging.c (debug_redirect): Add static variable.
5472         (pop_output_files): Add default param.
5473         (handle_redirections): Print debug setting.
5474         (show_logging_command): Likewise.
5475         (_initialize_cli_logging): Add debugredirect command.
5476         * interps.c (current_interp_set_logging): Add debug_redirect
5477         parameter.
5478         * interps.h (set_logging): Add debug_redirect parameter.
5479         (current_interp_set_logging): Likewise.
5480         * mi/mi-common.h: Likewise.
5481         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5482
5483 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5484             Tom Tromey  <tromey@adacore.com>
5485
5486         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5487         directly.
5488         * cli/cli-interp.h (make_logging_output): Remove declaration.
5489         * cli/cli-logging.c (make_logging_output): Remove function.
5490         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5491         directly.
5492         * ui-file.c (tee_file::tee_file): Remove bools.
5493         (tee_file::~tee_file): Remove deletes.
5494         * ui-file.h (tee_file): Remove bools.
5495
5496 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5497
5498         * mi/mi-cmds.h (mi_cmd_complete): New function.
5499         * mi/mi-main.c (mi_cmd_complete): Likewise.
5500         * mi/mi-cmds.c: Define new MI command -complete.
5501         * NEWS: Mention new -complete command.
5502
5503 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5504
5505         * completer.h (complete): New function.
5506         * completer.c (complete): Likewise.
5507         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5508         function defined in completer.h.
5509
5510 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5511
5512         * MAINTAINERS (Write After Approval): Add myself.
5513
5514 2019-05-17  Tom de Vries  <tdevries@suse.de>
5515
5516         PR gdb/24094
5517         * dwarf2read.c (struct cu_partial_die_info): New struct.
5518         (find_partial_die): Return cu_partial_die_info.
5519         (partial_die_parent_scope, guess_partial_die_structure_name)
5520         (partial_die_info::fixup): Handle new return type of find_partial_die.
5521
5522 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5523
5524         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5525         "std::string", simplifying the algorithm.
5526
5527 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5528
5529         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5530         (stap_static_probe_ops::get_probes): Likewise.
5531
5532 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5533
5534         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5535         '-')" and "else if".
5536         (stap_parse_single_operand): Join checks for
5537         "gdbarch_stap_parse_special_token_p" and
5538         "gdbarch_stap_parse_special_token" in the same "if" statement.
5539         Invert check when verifying for operation on register
5540         displacement.
5541
5542 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5543
5544         * stap-probe.c (stap_get_opcode): Update comment.
5545         (stap_get_expected_argument_type): Likewise.
5546         (handle_stap_probe): Likewise.
5547
5548 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5549
5550         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5551         return type to 'bool'.  Adjust comment.  Use 'bool' when
5552         appropriate.
5553         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5554         * stap-probe.c (stap_parse_argument_1): Likewise.
5555         (stap_is_operator): Likewise.
5556         (stap_is_generic_prefix): Likewise.
5557         (stap_is_register_prefix): Likewise.
5558         (stap_is_register_indirection_prefix): Likewise.
5559         (stap_is_integer_prefix): Likewise.
5560         (stap_generic_check_suffix): Likewise.
5561         (stap_check_integer_suffix): Likewise.
5562         (stap_check_register_suffix): Likewise.
5563         (stap_check_register_indirection_suffix): Likewise.
5564         (stap_parse_register_operand): Likewise.
5565         (stap_parse_single_operand): Likewise.
5566         (stap_parse_argument_1): Likewise.
5567         (stap_probe::get_argument_count): Likewise.
5568         (stap_is_operator): Likewise.
5569
5570 2019-05-16  Tom Tromey  <tromey@adacore.com>
5571
5572         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5573         keyword to foreach.
5574
5575 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5576
5577         * linux-thread-db.c (try_thread_db_load_1): Change return type
5578         to bool.
5579         (try_thread_db_load): Likewise.
5580         (try_thread_db_load_from_pdir_1): Likewise.
5581         (try_thread_db_load_from_pdir): Likewise.
5582         (try_thread_db_load_from_sdir): Likewise.
5583         (try_thread_db_load_from_dir): Likewise.
5584         (thread_db_load_search): Likewise.
5585         (has_libpthread): Likewise.
5586         (thread_db_load): Likewise.
5587
5588 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5589
5590         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5591         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5592         NULL, and complain/return if that's the case.
5593
5594 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5595
5596         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5597         (advance, posn, abstract_read_memory): New functions.
5598         [struct mem_read_abstraction]: New struct.
5599         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5600
5601 2019-05-14  Tom Tromey  <tromey@adacore.com>
5602
5603         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5604         value is not lval_memory.
5605
5606 2019-05-14  Tom Tromey  <tromey@adacore.com>
5607
5608         * solib.c (info_sharedlibrary_command): Style the file name.
5609
5610 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5611
5612         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5613         (aarch64_vnv_type): Likewise.
5614         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5615         * common/tdesc.c: Likewise.
5616         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5617         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5618         * features/aarch64-fpu.xml: Add ieee half view.
5619         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5620         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5621         * gdbtypes.h (struct builtin_type): Likewise.
5622         (struct objfile_type): Likewise.
5623
5624 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5625
5626         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5627         typo.
5628         * location.h (string_to_event_location): Likewise.
5629
5630 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5631
5632         GDB 8.3 released.
5633
5634 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5635
5636         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5637         New variable declaration.
5638         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5639         New variable.
5640         (print_one_breakpoint): Use ui_out::test_flags and new global
5641         variable to compute use_fixed_output.
5642         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5643         Remove.
5644         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5645         (mi_multi_location_breakpoint_output_fixed): Remove.
5646         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5647         new variable.
5648         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5649         fix_multi_location_breakpoint_output flag if version >= 3.
5650         * ui-out.h (enum ui_out_flag)
5651         <fix_multi_location_breakpoint_output>: New enumerator.
5652
5653 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5654
5655         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5656
5657 2019-05-10  Tom Tromey  <tromey@adacore.com>
5658
5659         * ada-lang.c (catch_ada_completer): New function.
5660         (_initialize_ada_language): Use it.
5661
5662 2019-05-10  Tom Tromey  <tromey@adacore.com>
5663
5664         * thread.c (print_thread_info): Make "requested_threads" const.
5665         * gdbthread.h (print_thread_info): Make "requested_threads"
5666         const.
5667         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5668         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5669
5670 2019-05-08  Tom Tromey  <tom@tromey.com>
5671
5672         * gdbtypes.c (objfile_type_data): Change type.
5673         (objfile_type, _initialize_gdbtypes): Update.
5674
5675 2019-05-08  Tom Tromey  <tom@tromey.com>
5676
5677         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5678         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5679         (_initialize_dwarf2_frame): Update.
5680
5681 2019-05-08  Tom Tromey  <tom@tromey.com>
5682
5683         * objc-lang.c (objc_objfile_data): Change type.
5684         (find_methods): Update.
5685         (_initialize_objc_lang): Remove.
5686
5687 2019-05-08  Tom Tromey  <tom@tromey.com>
5688
5689         * stabsread.c (rs6000_builtin_type_data): Change type.
5690         (rs6000_builtin_type, _initialize_stabsread): Update.
5691
5692 2019-05-08  Tom Tromey  <tom@tromey.com>
5693
5694         * mips-tdep.c (mips_pdr_data): Remove.
5695         (_initialize_mips_tdep): Update.
5696
5697 2019-05-08  Tom Tromey  <tom@tromey.com>
5698
5699         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5700         (hppa_init_objfile_priv_data, read_unwind_info)
5701         (find_unwind_entry, _initialize_hppa_tdep): Update.
5702
5703 2019-05-08  Tom Tromey  <tom@tromey.com>
5704
5705         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5706         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5707         on obstack.
5708         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5709
5710 2019-05-08  Tom Tromey  <tom@tromey.com>
5711
5712         * mdebugread.c (basic_type_data): Change type.
5713         (basic_type, _initialize_mdebugread): Update.
5714
5715 2019-05-08  Tom Tromey  <tom@tromey.com>
5716
5717         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5718
5719 2019-05-08  Tom Tromey  <tom@tromey.com>
5720
5721         * nto-tdep.c (nto_inferior_data_reg): Change type.
5722         (nto_inferior_data): Update.
5723         (nto_inferior_data_cleanup, nto_new_inferior_data)
5724         (_initialize_nto_tdep): Remove.
5725         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5726
5727 2019-05-08  Tom Tromey  <tom@tromey.com>
5728
5729         * ada-lang.c (struct ada_inferior_data): Add initializers.
5730         (ada_inferior_data): Change type.
5731         (ada_inferior_data_cleanup): Remove.
5732         (get_ada_inferior_data, ada_inferior_exit)
5733         (struct ada_pspace_data): Add initializers, destructor.
5734         (ada_pspace_data_handle): Change type.
5735         (get_ada_pspace_data): Update.
5736         (ada_pspace_data_cleanup): Remove.
5737
5738 2019-05-08  Tom Tromey  <tom@tromey.com>
5739
5740         * coffread.c (struct coff_symfile_info): Add initializers.
5741         (coff_objfile_data_key): Move lower.  Change type.
5742         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5743         Update.
5744         (coff_free_info): Remove.
5745
5746 2019-05-08  Tom Tromey  <tom@tromey.com>
5747
5748         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5749         (fbsd_pspace_data_handle): Move lower.  Change type.
5750         (get_fbsd_pspace_data): Update.
5751         (fbsd_pspace_data_cleanup): Remove.
5752         (_initialize_fbsd_tdep): Update.
5753
5754 2019-05-08  Tom Tromey  <tom@tromey.com>
5755
5756         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5757         (get_ada_tasks_pspace_data): Update.
5758         (ada_tasks_pspace_data_cleanup): Remove.
5759         (_initialize_tasks): Update.
5760         (ada_tasks_inferior_data_handle): Change type.
5761         (get_ada_tasks_inferior_data): Update.
5762         (ada_tasks_inferior_data_cleanup): Remove.
5763         (struct ada_tasks_pspace_data): Add initializers.
5764
5765 2019-05-08  Tom Tromey  <tom@tromey.com>
5766
5767         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5768         * symfile-debug.c (debug_sym_get_probes): Change type.
5769         * stap-probe.c (handle_stap_probe):
5770         (stap_static_probe_ops::get_probes): Change type.
5771         * probe.h (class static_probe_ops) <get_probes>: Change type.
5772         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5773         (parse_probes_in_pspace): Update.
5774         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5775         Update.
5776         (any_static_probe_ops::get_probes): Change type.
5777         * elfread.c (elfread_data): New typedef.
5778         (probe_key): Change type.
5779         (elf_get_probes): Likewise.  Update.
5780         (probe_key_free): Remove.
5781         (_initialize_elfread): Update.
5782         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5783         Change type.
5784         (dtrace_process_dof_probe, dtrace_process_dof)
5785         (dtrace_static_probe_ops::get_probe): Change type.
5786
5787 2019-05-08  Tom Tromey  <tom@tromey.com>
5788
5789         * xcoffread.c (struct xcoff_symfile_info): Rename from
5790         coff_symfile_info.  Add initializers.
5791         (xcoff_objfile_data_key): Move lower.  Change type.
5792         (XCOFF_DATA): Rewrite.
5793         (xcoff_free_info): Remove.
5794         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5795         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5796         (xcoff_initial_scan): Update.
5797
5798 2019-05-08  Tom Tromey  <tom@tromey.com>
5799
5800         * solib-svr4.c (struct svr4_info): Add initializers and
5801         destructor.
5802         <probes_table>: Now an htab_up.
5803         (solib_svr4_pspace_data): Change type.
5804         (free_probes_table): Simplify.
5805         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5806         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5807         (probes_table_remove_objfile_probes, register_solib_event_probe)
5808         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5809         (_initialize_svr4_solib): Update.
5810
5811 2019-05-08  Tom Tromey  <tom@tromey.com>
5812
5813         * remote.c (remote_pspace_data): Change type.
5814         (remote_pspace_data_cleanup): Remove.
5815         (get_remote_exec_file, set_pspace_remote_exec_file)
5816         (_initialize_remote): Update.
5817
5818 2019-05-08  Tom Tromey  <tom@tromey.com>
5819
5820         * breakpoint.c (breakpoint_objfile_key): Change type.
5821         (get_breakpoint_objfile_data): Update.
5822         (free_breakpoint_objfile_data): Remove.
5823         (_initialize_breakpoint): Update.
5824
5825 2019-05-08  Tom Tromey  <tom@tromey.com>
5826
5827         * linux-tdep.c (struct linux_info): Add initializers.
5828         (linux_inferior_data): Move.  Change type.
5829         (invalidate_linux_cache_inf): Update.
5830         (linux_inferior_data_cleanup): Remove.
5831         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5832
5833 2019-05-08  Tom Tromey  <tom@tromey.com>
5834
5835         * auxv.c (auxv_inferior_data): Move.  Change type.
5836         (auxv_inferior_data_cleanup): Remove.
5837         (invalidate_auxv_cache_inf): Rewrite.
5838         (get_auxv_inferior_data, _initialize_auxv): Update.
5839
5840 2019-05-08  Tom Tromey  <tom@tromey.com>
5841
5842         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5843         (symfile_debug_objfile_data_key): Change type.
5844         (symfile_debug_installed, debug_qf_has_symbols)
5845         (debug_qf_find_last_source_symtab)
5846         (debug_qf_forget_cached_source_info)
5847         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5848         (debug_qf_print_stats, debug_qf_dump)
5849         (debug_qf_expand_symtabs_for_function)
5850         (debug_qf_expand_all_symtabs)
5851         (debug_qf_expand_symtabs_with_fullname)
5852         (debug_qf_map_matching_symbols)
5853         (debug_qf_expand_symtabs_matching)
5854         (debug_qf_find_pc_sect_compunit_symtab)
5855         (debug_qf_map_symbol_filenames)
5856         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5857         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5858         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5859         (debug_sym_read_linetable, debug_sym_relocate): Update.
5860         (symfile_debug_free_objfile): Remove.
5861         (install_symfile_debug_logging, _initialize_symfile_debug):
5862         Update.
5863
5864 2019-05-08  Tom Tromey  <tom@tromey.com>
5865
5866         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5867         allocate_on_obstack.
5868         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5869         (get_dwarf2_per_objfile): Update.
5870         (set_dwarf2_per_objfile): Remove.
5871         (dwarf2_has_info, dwarf2_get_section_info): Update.
5872         (dwarf2_free_objfile): Remove.
5873         (_initialize_dwarf2_read): Update.
5874
5875 2019-05-08  Tom Tromey  <tom@tromey.com>
5876
5877         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5878         initializers.
5879         <unsupported_script_warning_printed,
5880         script_not_found_warning_printed>: Now bool.
5881         (auto_load_pspace_data): Change type.
5882         (~auto_load_pspace_info): Rename from
5883         auto_load_pspace_data_cleanup.
5884         (get_auto_load_pspace_data, init_loaded_scripts_info)
5885         (clear_section_scripts, maybe_print_unsupported_script_warning)
5886         (maybe_print_script_not_found_warning, _initialize_auto_load):
5887         Update.
5888
5889 2019-05-08  Tom Tromey  <tom@tromey.com>
5890
5891         * objfiles.c (objfile_pspace_info): Add destructor and
5892         initializers.
5893         (objfiles_pspace_data): Change type.
5894         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5895         (get_objfile_pspace_data): Update.
5896         (objfiles_bfd_data): Change type.
5897         (get_objfile_bfd_data): Update.
5898         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5899
5900 2019-05-08  Tom Tromey  <tom@tromey.com>
5901
5902         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5903         Change type.
5904         (get_catch_syscall_inferior_data): Update.
5905         (catch_syscall_inferior_data_cleanup): Remove.
5906         (_initialize_break_catch_syscall): Update.
5907
5908 2019-05-08  Tom Tromey  <tom@tromey.com>
5909
5910         * inflow.c (struct terminal_info): Add destructor and
5911         initializers.
5912         (inflow_inferior_data): Change type.
5913         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5914         (get_inflow_inferior_data, inflow_inferior_exit)
5915         (swap_terminal_info, _initialize_inflow): Update.
5916
5917 2019-05-08  Tom Tromey  <tom@tromey.com>
5918
5919         * target-dcache.c (target_dcache_cleanup): Remove.
5920         (target_dcache_aspace_key): Change type.
5921         (target_dcache_init_p, target_dcache_invalidate)
5922         (target_dcache_get, target_dcache_get_or_init)
5923         (_initialize_target_dcache): Update.
5924         * dcache.h (struct dcache_deleter): New.
5925
5926 2019-05-08  Tom Tromey  <tom@tromey.com>
5927
5928         * symtab.c (struct symbol_cache): Add destructor and
5929         initializers.
5930         (symbol_cache_key): Move.  Change type.
5931         (make_symbol_cache, free_symbol_cache): Remove.
5932         (get_symbol_cache): Update.
5933         (symbol_cache_cleanup): Remove.
5934         (ALL_PSPACES, symbol_cache_flush)
5935         (maintenance_print_symbol_cache)
5936         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5937         Update.
5938
5939 2019-05-08  Tom Tromey  <tom@tromey.com>
5940
5941         * symtab.c (struct main_info): Add destructor and initializers.
5942         (main_progspace_key): Move.  Change type.
5943         (get_main_info): Update.
5944         (main_info_cleanup): Remove.
5945         (_initialize_symtab): Update.
5946
5947 2019-05-08  Tom Tromey  <tom@tromey.com>
5948
5949         * registry.h (DECLARE_REGISTRY): Define the _key class.
5950
5951 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5952
5953         * NEWS: Merge two 'New commands' sections.
5954
5955 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5956
5957         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5958         parameter and use Ada language definition instead.
5959         (ada_val_print_ptr): Remove unused language parameter.
5960         (ada_val_print_num): Remove language parameter and use Ada language
5961         definition instead.
5962         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5963         parameter.
5964         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5965         parameter and use Ada language definition instead.
5966         (ada_val_print_1): Update all ada_val_print_xxx calls.
5967         Remove language parameter.
5968         (ada_val_print): Update ada_val_print_1 call.
5969
5970 2019-05-08  Tom Tromey  <tromey@adacore.com>
5971
5972         * remote.c (remote_hw_watchpoint_limit)
5973         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5974         Now static.
5975
5976 2019-05-08  Tom Tromey  <tromey@adacore.com>
5977
5978         * maint.c (_initialize_maint_cmds): Move initialization code to
5979         remote.c.
5980         (watchdog, show_watchdog): Move to remote.c.
5981         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5982         "watchdog" static.
5983         (_initialize_remote): Move initialization code from maint.c.
5984         * defs.h (watchdog): Don't declare.
5985
5986 2019-05-08  Tom Tromey  <tromey@adacore.com>
5987
5988         * tui/tui-interp.c: Include main.h.
5989         * interps.c: Include main.h.
5990         * main.h (interpreter_p): Declare.
5991         * defs.h (interpreter_p): Don't declare.
5992
5993 2019-05-08  Tom Tromey  <tromey@adacore.com>
5994
5995         * dwarf2loc.c: Include dwarf2read.h.
5996         * defs.h (read_unsigned_leb128): Don't declare.
5997         * dwarf2read.h (read_unsigned_leb128): Declare.
5998
5999 2019-05-08  Tom Tromey  <tromey@adacore.com>
6000
6001         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6002         method.
6003
6004 2019-05-08  Tom Tromey  <tromey@adacore.com>
6005
6006         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6007         when no wrap column is set.
6008
6009 2019-05-08  Tom Tromey  <tromey@adacore.com>
6010
6011         * c-lang.c (c_get_string): Handle non-C-style arrays.
6012
6013 2019-05-08  Tom Tromey  <tromey@adacore.com>
6014
6015         * typeprint.c (print_offset_data::update): Print the bit offset,
6016         not the number of bits remaining.
6017
6018 2019-05-08  Tom Tromey  <tromey@adacore.com>
6019
6020         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6021         padding at end of comment.
6022
6023 2019-05-08  Tom Tromey  <tromey@adacore.com>
6024
6025         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6026         Compare main types.
6027
6028 2019-05-06  Tom Tromey  <tom@tromey.com>
6029
6030         * common/scoped_mmap.c: Include common-defs.h.
6031         * common/scoped_mmap.h: Don't include config.h.
6032
6033 2019-05-04  Tom Tromey  <tom@tromey.com>
6034
6035         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6036         (struct aarch64_call_info): Add initializers.
6037         <si>: Now a std::vector.
6038         (pass_on_stack, aarch64_push_dummy_call): Update.
6039
6040 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6041             Tom Tromey  <tom@tromey.com>
6042
6043         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6044         (ppc_threads): Now a std::vector.  Now static.
6045         (hwdebug_find_thread_points_by_tid)
6046         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6047         Update.
6048
6049 2019-05-04  Tom Tromey  <tom@tromey.com>
6050
6051         * arc-tdep.c (arc_tdesc_init): Return bool.
6052
6053 2019-05-04  Tom Tromey  <tom@tromey.com>
6054
6055         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6056         Use gdb_assert_not_reached.
6057
6058 2019-05-04  Tom Tromey  <tom@tromey.com>
6059
6060         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6061         "false".
6062
6063 2019-05-04  Tom Tromey  <tom@tromey.com>
6064
6065         * arc-tdep.c (arc_tdesc_init): Use bool.
6066
6067 2019-05-04  Tom Tromey  <tom@tromey.com>
6068
6069         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6070
6071 2019-05-04  Tom Tromey  <tom@tromey.com>
6072
6073         * cli/cli-cmds.c (valid_command_p): Return bool.
6074
6075 2019-05-04  Tom Tromey  <tom@tromey.com>
6076
6077         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6078         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6079
6080 2019-05-04  Raul Tambre  <raul@tambre.ee>
6081
6082         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6083         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6084         operator for comparison.
6085
6086 2019-05-04  Tom Tromey  <tom@tromey.com>
6087
6088         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6089         (lookup_partial_symbol, print_partial_symbols)
6090         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6091         (psymbol_compare): Update.
6092         (add_psymbol_to_bcache): Clear the entire psymbol.
6093         (maintenance_check_psymtabs): Update.
6094         * psympriv.h (struct partial_symbol): Don't derive from
6095         general_symbol_info.
6096         <obj_section, unrelocated_address, address,
6097         set_unrelocated_address>: Update.
6098         <ginfo>: New member.
6099         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6100         (debug_names::write_psymbols): Update.
6101
6102 2019-05-04  Tom de Vries  <tdevries@suse.de>
6103
6104         * contrib/cc-with-tweaks.sh: Support -n arg.
6105
6106 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6107
6108         * corelow.c (core_target::detach): Ensure frame cache and
6109         register caches are cleared.
6110         inferior.c (exit_inferior_1): Likewise.
6111
6112 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6113             Tom Tromey  <tom@tromey.com>
6114
6115         * dictionary.c (collate_pending_symbols_by_language): Remove
6116         "struct" from foreach.
6117         * symtab.c (lookup_global_symbol_from_objfile)
6118         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6119         foreach.
6120         * ser-tcp.c (net_open): Remove "struct" from foreach.
6121         * objfiles.c (objfile_relocate, objfile_rebase)
6122         (objfile_has_symbols): Remove "struct" from foreach.
6123         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6124         from foreach.
6125         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6126         foreach.
6127         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6128         "struct" from foreach.
6129         * ada-lang.c (create_excep_cond_exprs)
6130         (ada_exception_catchpoint_cond_string): Remove "struct" from
6131         foreach.
6132
6133 2019-05-03  Tom Tromey  <tromey@adacore.com>
6134
6135         * ada-exp.y (convert_char_literal): Check suffix of each
6136         enumerator.
6137
6138 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6139
6140         PR ada/21406:
6141         * ada-exp.y (yywrap): Don't define.
6142         * ada-lex.l (%option): Add noyywrap
6143         (yywrap): Remove.
6144
6145 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6146
6147         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6148         _WIN32_WINNT to the XP level, unless already defined to a higher
6149         level.
6150
6151         * unittests/parse-connection-spec-selftests.c:
6152         * ser-tcp.c:
6153         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6154         override.
6155
6156         * symfile.c (find_separate_debug_file): Remove colon from the
6157         drive spec of DOS/Windows file names of the target, so that the
6158         file name produced from DEBUGDIR and the target's directory will
6159         be valid on DOS/Windows systems.
6160
6161 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * rust-lang.c (val_print_struct): Handle printing structures
6164         containing strings.
6165
6166 2019-05-02  Tom Tromey  <tromey@adacore.com>
6167
6168         * valarith.c (_initialize_valarith): Remove.
6169
6170 2019-05-01  Tom Tromey  <tromey@adacore.com>
6171
6172         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6173         bitfields.
6174
6175 2019-05-01  Tom Tromey  <tromey@adacore.com>
6176
6177         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6178         for big-endian copies.
6179
6180 2019-04-30  Ali Tamur  <tamur@google.com>
6181         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6182         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6183         (read_3_bytes): New function.
6184
6185 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6186
6187         * windows-nat.c (main_thread_id): Delete.
6188         (handle_output_debug_string): Replace main_thread_id by
6189         current_event.dwThreadId.
6190         (fake_create_process): Likewise.
6191         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6192         Do not set main_thread_id.
6193         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6194         current_event.dwThreadId.
6195         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6196
6197 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6198
6199         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6200         Use current_event.dwThreadId instead of main_thread_id.
6201
6202 2019-04-30  Tom Tromey  <tromey@adacore.com>
6203
6204         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6205         (create_excep_cond_exprs): Iterate over program spaces.
6206         (ada_exception_catchpoint_cond_string): Examine all minimal
6207         symbols for exception types.
6208
6209 2019-04-30  Tom Tromey  <tromey@adacore.com>
6210
6211         PR c++/24470:
6212         * dwarf2read.c (process_structure_scope): Handle case where type
6213         has template parameters but no symbol was created.
6214
6215 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6216             Chris January  <chris.january@arm.com>
6217
6218         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6219         qualifier.
6220         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6221
6222 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6223
6224         * f-typeprint.c (f_print_type): Update rules for printing
6225         whitespace.
6226         (f_type_print_varspec_suffix): Likewise.
6227
6228 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6229             Chris January  <chris.january@arm.com>
6230
6231         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6232         function arguments.
6233
6234 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6235
6236         * f-lang.c (build_fortran_types): Change name of void type to
6237         lower case.
6238         * f-typeprint.c (f_type_print_base): Print the name of the void
6239         type, rather than a fixed string.
6240         * f-valprint.c (f_decorations): Use lower case void string.
6241
6242 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6243             Chris January  <chris.january@arm.com>
6244
6245         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6246         types for Fortran.
6247
6248 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6249             Chris January  <chris.january@arm.com>
6250             David Lecomber  <david.lecomber@arm.com>
6251
6252         * f-exp.y (BINOP_INTRINSIC): New token.
6253         (exp): New parser rule handling BINOP_INTRINSIC.
6254         (f77_keywords): Add new builtin procedures.
6255         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6256         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6257         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6258         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6259         (print_unop_subexp_f): New function.
6260         (print_binop_subexp_f): New function.
6261         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6262         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6263         (dump_subexp_body_f): Likewise.
6264         (operator_check_f): Likewise.
6265         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6266         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6267
6268 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6271         UNOP_KIND.
6272         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6273         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6274         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6275         (operator_length_f): New fuction.
6276         (print_subexp_f): New function.
6277         (op_name_f): New function.
6278         (dump_subexp_body_f): New function.
6279         (operator_check_f): New function.
6280         (exp_descriptor_f): Replace standard expression handling functions
6281         with new functions.
6282         * gdb/fortran-operator.def: New file.
6283         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6284         * gdb/std-operator.def: Remove UNOP_KIND.
6285
6286 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6287
6288         * std-operator.def: Remove unbalanced, stray double quote
6289         character.
6290
6291 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6292             Chris January  <chris.january@arm.com>
6293             Daniel Everett  <daniel.everett@arm.com>
6294             Nick Forrington  <nick.forrington@arm.com>
6295             Richard Bunt  <richard.bunt@arm.com>
6296
6297         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6298         of depth when printing anonymous structs or unions.
6299         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6300         Don't print either the top-level value, or the children if the
6301         max-depth is exceeded.
6302         (ppscm_print_children): When printing the key of a map, allow one
6303         extra level of depth.
6304         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6305         print either the top-level value, or the children if the max-depth
6306         is exceeded.
6307         (print_children): When printing the key of a map, allow one extra
6308         level of depth.
6309         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6310         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6311         (user_print_options): Initialise max_depth field.
6312         (val_print_scalar_or_string_type_p): New function.
6313         (val_print): Check to see if the max depth has been reached.
6314         (val_print_check_max_depth): Define new function.
6315         (show_print_max_depth): New function.
6316         (_initialize_valprint): Add 'print max-depth' option.
6317         * valprint.h (struct value_print_options) <max_depth>: New field.
6318         (val_print_check_max_depth): Declare new function.
6319         * NEWS: Document new feature.
6320
6321 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * ada-lang.c (ada_language_defn): Initialise new field.
6324         * c-lang.c (c_is_string_type_p): New function.
6325         (c_language_defn): Initialise new field.
6326         (cplus_language_defn): Initialise new field.
6327         (asm_language_defn): Initialise new field.
6328         (minimal_language_defn): Initialise new field.
6329         * c-lang.h (c_is_string_type_p): Declare new function.
6330         * d-lang.c (d_language_defn): Initialise new field.
6331         * f-lang.c (f_is_string_type_p): New function.
6332         (f_language_defn): Initialise new field.
6333         * go-lang.c (go_is_string_type_p): New function.
6334         (go_language_defn): Initialise new field.
6335         * language.c (default_is_string_type_p): New function.
6336         (unknown_language_defn): Initialise new field.
6337         (auto_language_defn): Initialise new field.
6338         * language.h (struct language_defn) <la_is_string_type_p>: New
6339         member variable.
6340         (default_is_string_type_p): Declare new function.
6341         * m2-lang.c (m2_language_defn): Initialise new field.
6342         * objc-lang.c (objc_language_defn): Initialise new field.
6343         * opencl-lang.c (opencl_language_defn): Initialise new field.
6344         * p-lang.c (pascal_is_string_type_p): New function.
6345         (pascal_language_defn): Initialise new field.
6346         * rust-lang.c (rust_is_string_type_p): New function.
6347         (rust_language_defn): Initialise new field.
6348
6349 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6350
6351         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6352         New field.
6353         * ada-lang.c (ada_language_defn): Initialise new field.
6354         * c-lang.c (c_language_defn): Likewise.
6355         (cplus_language_defn): Likewise.
6356         (asm_language_defn): Likewise.
6357         (minimal_language_defn): Likewise.
6358         * d-lang.c (d_language_defn): Likewise.
6359         * f-lang.c (f_language_defn): Likewise.
6360         * go-lang.c (go_language_defn): Likewise.
6361         * language.c (unknown_language_defn): Likewise.
6362         (auto_language_defn): Likewise.
6363         * m2-lang.c (m2_language_defn): Likewise.
6364         * objc-lang.c (objc_language_defn): Likewise.
6365         * opencl-lang.c (opencl_language_defn): Likewise.
6366         * p-lang.c (pascal_language_defn): Likewise.
6367         * rust-lang.c (rust_language_defn): Likewise.
6368
6369 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6370
6371         * ada-lang.c (ada_is_character_type): Change return type to bool.
6372         (ada_is_string_type): Likewise.
6373         * ada-lang.h (ada_is_character_type): Update declaration
6374         (ada_is_string_type): Likewise.
6375
6376 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6377
6378         Support style in 'frame|thread apply'
6379
6380         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6381         * record.c (record_start, record_stop): Update callers of
6382         execute_command_to_string with false.
6383         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6384         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6385         methods.
6386         (class string_file): New constructor with term_out parameter.
6387         Override methods term_out and can_emit_style_escape.  New member
6388         term_out.
6389         (class stdio_file): Override can_emit_style_escape.
6390         (class tee_file): Override term_out and can_emit_style_escape.
6391         * utils.h (can_emit_style_escape): Remove.
6392         * utils.c (can_emit_style_escape): Likewise.
6393         Update all callers of can_emit_style_escape (SOMESTREAM) to
6394         SOMESTREAM->can_emit_style_escape.
6395         * source-cache.c (source_cache::get_source_lines): Likewise.
6396         * stack.c (frame_apply_command_count): Call execute_command_to_string
6397         passing the term_out characteristic of the current gdb_stdout.
6398         * thread.c (thr_try_catch_cmd): Likewise.
6399         * top.c (execute_command_to_string): pass term_out parameter
6400         to construct the string_file for the command output.
6401         * ui-file.c (term_cli_styling): New function (most code moved
6402         from utils.c can_emit_style_escape).
6403         (string_file::string_file, string_file::can_emit_style_escape,
6404         stdio_file::can_emit_style_escape, tee_file::term_out,
6405         tee_file::can_emit_style_escape): New functions.
6406
6407 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6408
6409         * NEWS: Mention the new set|show may-call-functions.
6410         * infcall.c (may_call_functions_p): New variable.
6411         (show_may_call_functions_p): New function.
6412         (call_function_by_hand_dummy): Throws an error if not
6413         may-call-functions.
6414         (_initialize_infcall): Call add_setshow_boolean_cmd for
6415         may-call-functions.
6416
6417 2019-04-25  Keith Seitz  <keiths@redhat.com>
6418
6419         PR c++/24367
6420         * cp-support.c (inspect_type): Don't attempt substitutions
6421         of symbol with the same name.
6422
6423 2019-04-25  Tom Tromey  <tromey@adacore.com>
6424
6425         PR gdb/24475:
6426         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6427         static.
6428
6429 2019-04-25  Tom Tromey  <tromey@adacore.com>
6430
6431         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6432         rvalue reference.
6433         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6434         (gdb_xml_parser::parse): Use std::move.
6435         * python/python-internal.h (gdbpy_convert_exception): Take a const
6436         reference.
6437         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6438         std::move.
6439         * python/py-utils.c (gdbpy_convert_exception): Take a const
6440         reference.
6441         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6442         Use std::move.
6443         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6444         Use std::move.
6445         * mi/mi-main.c (mi_print_exception): Take a const reference.
6446         * main.c (handle_command_errors): Take a const reference.
6447         * linespec.c (parse_linespec): Use std::move.
6448         * infcall.c (run_inferior_call): Use std::move.
6449         (call_function_by_hand_dummy): Use std::move.
6450         * exec.c (try_open_exec_file): Use std::move.
6451         * exceptions.h (exception_print, exception_fprintf)
6452         (exception_print_same): Update.
6453         * exceptions.c (print_exception, exception_print)
6454         (exception_fprintf, exception_print_same): Change parameters to
6455         const reference.
6456         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6457         * common/new-op.c: Use std::move.
6458         * common/common-exceptions.h (struct gdb_exception): Add move
6459         constructor.
6460         (struct gdb_exception_error, struct gdb_exception_quit, struct
6461         gdb_quit_bad_alloc): Change constructor to move constructor.
6462         (throw_exception): Change parameter to rvalue reference.
6463         * common/common-exceptions.c (throw_exception): Take rvalue
6464         reference.
6465         * cli/cli-interp.c (safe_execute_command): Use std::move.
6466         * breakpoint.c (insert_bp_location, location_to_sals): Use
6467         std::move.
6468
6469 2019-04-25  Tom Tromey  <tromey@adacore.com>
6470
6471         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6472         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6473         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6474         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6475         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6476         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6477         guile/scm-value.c: Use unpack.
6478         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6479         gdbscm_gdb_exception.
6480         (gdbscm_throw_gdb_exception): Likewise.
6481         (struct gdbscm_gdb_exception): New.
6482         (unpack): New function.
6483         (gdbscm_wrap): Use unpack.
6484
6485 2019-04-25  Tom Tromey  <tromey@adacore.com>
6486
6487         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6488         (gdb_rl_callback_handler): Use std::move.
6489         * common/common-exceptions.h (struct gdb_exception): Add move
6490         assignment operator.
6491         (throw_exception_sjlj): Change "exception" to const reference.
6492         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6493         (throw_exception_sjlj): Change "exception" to const reference.
6494
6495 2019-04-25  Tom Tromey  <tromey@adacore.com>
6496
6497         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6498         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6499         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6500         Update.
6501         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6502         Update.
6503         * mi/mi-interp.c (mi_interp::exec): Update.
6504         * linespec.c (parse_linespec): Update.
6505         * infcall.c (run_inferior_call): Update.
6506         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6507         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6508         (gdbscm_lookup_global_symbol): Update.
6509         * guile/scm-param.c (gdbscm_parameter_value): Update.
6510         * guile/scm-frame.c (gdbscm_frame_read_register)
6511         (gdbscm_frame_read_var): Update.
6512         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6513         * exec.c (try_open_exec_file): Update.
6514         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6515         (gdb_rl_callback_handler): Update.
6516         * common/common-exceptions.h (exception_none): Don't declare.
6517         * common/common-exceptions.c (exception_none): Don't define.
6518         (struct catcher) <exception>: Update.
6519         * cli/cli-interp.c (safe_execute_command): Update.
6520         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6521
6522 2019-04-25  Ali Tamur  <tamur@google.com>
6523
6524         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6525         (read_attribute_value): Likewise.
6526         (dwarf2_read_addr_index): Update comment.
6527         (read_str_index): Add DW_FORM_strx.
6528         (dwarf2_string_attr): Likewise.
6529         (dwarf2_const_value_attr): Likewise.
6530         (dump_die_shallow): Likewise.
6531         (dwarf2_fetch_constant_bytes): Likewise.
6532         (skip_form_bytes): Likewise.
6533         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6534
6535 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6536
6537         PR corefiles/11608
6538         PR corefiles/18187
6539         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6540         OFFSET.  Verify if current mapping contains an ELF header.
6541         (linux_find_memory_regions_full): Adjust call to
6542         dump_mapping_p.
6543
6544 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6545             Kang Li <kanglictf@gmail.com>
6546
6547         PR gdb/21600
6548
6549         * dwarf2-frame.c (read_initial_length): Be consistent about using
6550         unsigned representation of length.
6551         (decode_frame_entry_1): Likewise.  Check for wraparound of
6552         end pointer as well as buffer overflow.
6553
6554 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6555
6556         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6557         "vq".
6558
6559 2019-04-24  Tom Tromey  <tromey@adacore.com>
6560
6561         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6562
6563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6564
6565         * s12z-tdep.c (s12z_unwind_pc): Delete.
6566         (s12z_unwind_sp): Delete.
6567         (s12z_gdbarch_init): Don't register deleted functions with
6568         gdbarch.
6569
6570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6571
6572         * rl78-tdep.c (rl78_unwind_sp): Delete.
6573         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6574
6575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6576
6577         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6578         (xstormy16_unwind_pc): Delete.
6579         (xstormy16_dummy_id): Delete.
6580         (xstormy16_gdbarch_init): Don't register deleted functions with
6581         gdbarch.
6582
6583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6584
6585         * vax-tdep.c (vax_unwind_pc): Delete.
6586         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6587
6588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6589
6590         * v850-tdep.c (v850_unwind_sp): Delete.
6591         (v850_unwind_pc): Delete.
6592         (v850_dummy_id): Delete.
6593         (v850_gdbarch_init): Don't register deleted functions with
6594         gdbarch.
6595
6596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6597
6598         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6599         (tilegx_unwind_pc): Delete.
6600         (tilegx_unwind_dummy_id): Delete.
6601         (tilegx_gdbarch_init): Don't register deleted functions with
6602         gdbarch.
6603
6604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6605
6606         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6607         (tic6x_dummy_id): Delete.
6608         (tic6x_gdbarch_init): Don't register deleted functions with
6609         gdbarch.
6610
6611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6612
6613         * sparc-tdep.c (sparc_unwind_pc): Delete.
6614         (sparc32_gdbarch_init): Don't register deleted function with
6615         gdbarch.
6616
6617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6618
6619         * sh-tdep.c (sh_unwind_sp): Delete.
6620         (sh_unwind_pc): Delete.
6621         (sh_dummy_id): Delete.
6622         (sh_gdbarch_init): Don't register deleted functions with
6623         gdbarch.
6624
6625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6626
6627         * score-tdep.c (score_unwind_sp): Delete.
6628         (score_unwind_pc): Delete.
6629         (score_dummy_id): Delete.
6630         (score_gdbarch_init): Don't register deleted functions with
6631         gdbarch.
6632
6633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6634
6635         * rx-tdep.c (rx_unwind_pc): Delete.
6636         (rx_unwind_sp): Delete.
6637         (rx_dummy_id): Delete.
6638         (rx_gdbarch_init): Don't register deleted functions with
6639         gdbarch.  Update comment.
6640
6641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6642
6643         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6644         (rs6000_dummy_id): Delete.
6645         (rs6000_gdbarch_init): Don't register deleted functions with
6646         gdbarch.
6647
6648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6649
6650         * or1k-tdep.c (or1k_dummy_id): Delete.
6651         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6652
6653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6654
6655         * nios2-tdep.c (nios2_dummy_id): Delete.
6656         (nios2_unwind_sp): Delete.
6657         (nios2_gdbarch_init): Don't register deleted functions with
6658         gdbarch.
6659
6660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * nds32-tdep.c (nds32_dummy_id): Delete.
6663         (nds32_unwind_pc): Delete.
6664         (nds32_unwind_sp): Delete.
6665         (nds32_gdbarch_init): Don't register deleted functions with
6666         gdbarch.
6667
6668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6669
6670         * msp430-tdep.c (msp430_unwind_pc): Delete.
6671         (msp430_unwind_sp): Delete.
6672         (msp430_dummy_id): Delete.
6673         (msp430_gdbarch_init): Don't register deleted functions with
6674         gdbarch.
6675
6676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6677
6678         * moxie-tdep.c (moxie_unwind_sp): Delete.
6679         (moxie_unwind_pc): Delete.
6680         (moxie_dummy_id): Delete.
6681         (moxie_gdbarch_init): Don't register deleted functions with
6682         gdbarch.
6683
6684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6685
6686         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6687         (mn10300_unwind_pc): Delete.
6688         (mn10300_unwind_sp): Delete.
6689         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6690         mn10300_unwind_sp.
6691         (mn10300_frame_unwind_init): Don't register deleted functions with
6692         gdbarch.
6693
6694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6695
6696         * mep-tdep.c (mep_unwind_pc): Delete.
6697         (mep_unwind_sp): Delete.
6698         (mep_dummy_id): Delete.
6699         (mep_gdbarch_init): Don't register deleted functions with
6700         gdbarch.
6701
6702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6705         (m68hc11_unwind_sp): Delete.
6706         (m68hc11_gdbarch_init): Don't register deleted functions with
6707         gdbarch.
6708
6709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6710
6711         * m32r-tdep.c (m32r_unwind_sp): Delete.
6712         (m32r_unwind_pc): Delete.
6713         (m32r_dummy_id): Delete.
6714         (m32r_gdbarch_init): Don't register deleted functions with
6715         gdbarch.
6716
6717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6718
6719         * m32c-tdep.c (m32c_unwind_pc): Delete.
6720         (m32c_unwind_sp): Delete.
6721         (m32c_dummy_id): Delete.
6722         (m32c_gdbarch_init): Don't register deleted functions with
6723         gdbarch.
6724
6725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6726
6727         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6728         (lm32_unwind_pc): Delete.
6729         (lm32_dummy_id): Delete.
6730         (lm32_gdbarch_init): Don't register deleted functions with
6731         gdbarch.
6732
6733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6734
6735         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6736         (iq2000_unwind_pc): Delete.
6737         (iq2000_dummy_id): Delete.
6738         (iq2000_gdbarch_init): Don't register deleted functions with
6739         gdbarch.
6740
6741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6742
6743         * nds32-tdep.c (nds32_type_align): Delete.
6744         (nds32_push_dummy_call): Use type_align instead.
6745
6746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6747
6748         * arm-tdep.c (arm_type_align): Only handle vector override case.
6749         (arm_push_dummy_call): Use type_align.
6750         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6751
6752 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6753
6754         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6755         case.
6756         (pass_on_stack): Use type_align.
6757         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6758         function.
6759
6760 2019-04-23  Tom Tromey  <tromey@adacore.com>
6761
6762         * dwarf2read.c (line_header::file_name_at): Remove unused
6763         overload.
6764
6765 2019-04-23  Tom de Vries  <tdevries@suse.de>
6766
6767         PR gdb/24438
6768         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6769         invocation.
6770
6771
6772 2019-03-27  Ali Tamur  <tamur@google.com>
6773
6774         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6775         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6776         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6777         (dwarf_expr_context::get_addr_index): Likewise
6778         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6779         (symbol_needs_eval_context::get_addr_index): Likewise
6780         (disassemble_dwarf_expression): Add DW_OP_addrx
6781         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6782         (read_cutu_die_from_dwo): Update comment
6783         (skip_one_die): Add DW_FORM_addrx
6784         (read_attribute_value): Likewise
6785         (var_decode_location): Add DW_OP_addrx
6786         (dwarf2_const_value_attr): Add DW_FORM_addrx
6787         (dump_die_shallow): Likewise
6788         (dwarf2_fetch_constant_bytes): Likewise
6789         (decode_locdesc): Add DW_OP_addrx
6790         (skip_form_bytes): Add DW_FORM_addrx
6791
6792 2019-04-22  Ali Tamur  <tamur@google.com>
6793
6794         * MAINTAINERS (Write After Approval): Add self.
6795
6796 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6797
6798         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6799         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6800         (open_symbol_file_object): Likewise.
6801         (svr4_default_sos): Add info parameter.
6802         (svr4_read_so_list): Likewise.
6803         (svr4_current_sos_direct): Adjust functions calls to pass down
6804         info.
6805         (svr4_current_sos_1): Add info parameter.
6806         (svr4_current_sos): Call get_svr4_info, pass info down to
6807         svr4_current_sos_1.
6808         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6809         get_svr4_info.
6810         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6811         get_svr4_info.
6812         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6813         to get_svr4_info.
6814         (probes_table_remove_objfile_probes): Likewise.
6815         (register_solib_event_probe): Add info parameter.
6816         (solist_update_incremental): Pass info parameter down to
6817         svr4_read_so_list.
6818         (disable_probes_interface): Add info parameter.
6819         (svr4_handle_solib_event): Pass current_program_space to
6820         get_svr4_info.  Adjust disable_probes_interface cleanup.
6821         (svr4_create_probe_breakpoints): Add info parameter, pass it
6822         down to register_solib_event_probe.
6823         (svr4_create_solib_event_breakpoints): Add info parameter,
6824         pass it down to svr4_create_probe_breakpoints.
6825         (enable_break): Pass info down to
6826         svr4_create_solib_event_breakpoints.
6827         (svr4_solib_create_inferior_hook): Pass current_program_space to
6828         get_svr4_info.
6829         (svr4_clear_solib): Likewise.
6830
6831 2019-04-22  Pedro Alves  <palves@redhat.com>
6832
6833         * solib-svr4.c (svr4_free_objfile_observer): New.
6834         (probe_and_action::objfile): New field.
6835         (probes_table_htab_remove_objfile_probes)
6836         (probes_table_remove_objfile_probes): New functions.
6837         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6838         in the new probe_and_action.  Don't store the probe in 'lookup'.
6839         (svr4_create_probe_breakpoints): Pass objfile to
6840         register_solib_event_probe.
6841         (_initialize_svr4_solib): Register a free_objfile observer.
6842
6843 2019-04-19  Tom Tromey  <tom@tromey.com>
6844
6845         * common/queue.h: Remove.
6846
6847 2019-04-19  Tom Tromey  <tom@tromey.com>
6848
6849         * event-loop.c: Don't include "common/queue.h".
6850
6851 2019-04-19  Tom Tromey  <tom@tromey.com>
6852
6853         * remote.c (remote_target): Use delete.
6854         * remote-notif.h: Include <list>, not "common/queue.h".
6855         (notif_client_p): Remove typedef.
6856         (remote_notif_state): Add constructor, destructor, initializer.
6857         <notif_queue>: Now a std::list.
6858         (remote_notif_state_xfree): Don't declare.
6859         * remote-notif.c (remote_notif_process, handle_notification)
6860         (remote_notif_state_allocate): Update.
6861         (~remote_notif_state): Rename from remote_notif_state_xfree.
6862
6863 2019-04-19  Tom Tromey  <tom@tromey.com>
6864
6865         * symfile.c (reread_symbols): Update.
6866         * objfiles.c (objfile_register_static_link)
6867         (objfile_lookup_static_link): Update
6868         (~objfile) Don't delete static_links.
6869         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6870
6871 2019-04-19  Tom Tromey  <tom@tromey.com>
6872
6873         * type-stack.h (struct type_stack) <insert>: Constify string.
6874         * type-stack.c (type_stack::insert): Constify string.
6875         * gdbtypes.h (lookup_template_type): Update.
6876         (address_space_name_to_int): Update.
6877         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6878         const.
6879         (lookup_template_type): Make name const.
6880         * c-exp.y: Update rules.
6881         (lex_one_token, classify_name, classify_inner_name)
6882         (c_print_token): Update.
6883         * p-exp.y: Update rules.
6884         (yylex): Update.
6885         * f-exp.y: Update rules.
6886         (yylex): Update.
6887         * d-exp.y: Update rules.
6888         (lex_one_token, classify_name, classify_inner_name): Update.
6889         * parse.c (write_dollar_variable, copy_name): Return std::string.
6890         * parser-defs.h (copy_name): Change return type.
6891         * m2-exp.y: Update rules.
6892         (yylex): Update.
6893         * go-exp.y (lex_one_token): Update.
6894         Update rules.
6895         (classify_unsafe_function, classify_packaged_name)
6896         (classify_name, yylex): Update.
6897
6898 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6899
6900         * configure.ac: add --enable-source-highlight switch.
6901         * configure: Regenerate.
6902         * top.c (print_gdb_version): plumb --enable-source-highlight
6903         status to "show configuration".
6904
6905 2019-04-19  Tom Tromey  <tromey@adacore.com>
6906
6907         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6908         Check ADA_TYPE_P.
6909         (empty_record, ada_template_to_fixed_record_type_1)
6910         (template_to_static_fixed_type)
6911         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6912         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6913         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6914         macros.
6915
6916 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6917
6918         PR symtab/24423:
6919         * source.c (print_source_lines_base): Advance "iter" when a
6920         control character is seen.
6921
6922 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6923
6924         * inferior.h (struct infcall_suspend_state_deleter):
6925         Catch exception in destructor to avoid crash.
6926
6927 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6928
6929         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6930         close to the add_com "shell".
6931
6932 2019-04-18  Tom Tromey  <tromey@adacore.com>
6933
6934         * process-stratum-target.h (class process_stratum_target)
6935         <stratum>: Add "final".
6936
6937 2019-04-17  Tom Tromey  <tromey@adacore.com>
6938
6939         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6940         against nullptr before use.
6941
6942 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6943
6944         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6945
6946 2019-04-17  Jim Wilson  <jimw@sifive.com>
6947             Andrew Burgess  <andrew.burgess@embecosm.com>
6948
6949         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6950         code read might fail, assume 4-byte breakpoint in that case.
6951
6952 2019-04-15  Leszek Swirski  <leszeks@google.com>
6953
6954         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6955         rather than a hand-rolled POD check when checking for forced MEMORY
6956         classification.
6957
6958 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6959
6960         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6961         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6962         function.
6963         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6964         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6965         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6966         declaration.
6967
6968 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6969
6970         * aarch64-linux-nat.c
6971         (aarch64_linux_nat_target::thread_architecture): Add override.
6972         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6973         each VQ.
6974
6975 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6976
6977         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6978
6979 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6980
6981         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6982         target types of size 96-bits, add some additional comments, and
6983         check that the builtin type we found was the correct size.
6984
6985 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6986
6987         * utils.c (prompt_for_continue): Don't restore the styling at the
6988         end, as applied_style has the wrong value.  This fixes styling in
6989         long lists of file names that are interrupted by the "Continue?"
6990         prompt.
6991
6992 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6995         * c-lang.c (c_language_defn): Likewise.
6996         (cplus_language_defn): Likewise.
6997         (asm_language_defn): Likewise.
6998         (minimal_language_defn): Likewise.
6999         * d-lang.c (d_language_defn): Likewise.
7000         * f-lang.c (f_language_defn): Likewise.
7001         * go-lang.c (go_language_defn): Likewise.
7002         * language.c (unknown_language_defn): Likewise.
7003         (auto_language_defn): Likewise.
7004         * language.h (struct language_defn): Remove la_magic field.
7005         (LANG_MAGIC): Delete.
7006         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7007         * objc-lang.c (objc_language_defn): Likewise.
7008         * opencl-lang.c (opencl_language_defn): Likewise.
7009         * p-lang.c (pascal_language_defn): Likewise.
7010         * rust-lang.c (rust_language_defn): Likewise.
7011
7012 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7013
7014         * riscv-tdep.c (riscv_type_align): New function.
7015         (riscv_type_alignment): Delete.
7016         (riscv_arg_location): Use 'type_align'.
7017         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7018
7019 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7020
7021         * gdbtypes.c (type_align): A struct with no non-static fields also
7022         has alignment of 1.
7023
7024 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7025
7026         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7027         component to 0.
7028         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7029         member.
7030         (riscv_struct_info::analyse): New implementation using new
7031         analyse_inner member function.
7032         (riscv_struct_info::field_offset): New member function.
7033         (riscv_struct_info::m_offsets): New member variable.
7034         (riscv_struct_info::analyse_inner): New private member function,
7035         takes the old implementation of riscv_struct_info::analyse but
7036         extended to track field offsets.
7037         (riscv_call_arg_struct): Update the struct folding special cases
7038         to handle cases where empty C++ structs, which are non-zero
7039         length, are found.
7040         (riscv_arg_location): Initialise the length of each location, a
7041         non-zero length now indicates the location is in use.
7042         (riscv_push_dummy_call): Allow for the first location having a
7043         non-zero offset when setting up arguments.
7044         (riscv_return_value): Likewise, but for return values.
7045
7046 2019-04-11  Tom Tromey  <tromey@adacore.com>
7047
7048         * utils.c (internal_vproblem): Make "msg" const.
7049
7050 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7051
7052         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7053         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7054         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7055         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7056
7057 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7058
7059         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7060         function.
7061         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7062         of amd64_collect_native_gregset.
7063         (amd64_linux_nat_target::store_registers): Likewise.
7064
7065 2019-04-10  Tom Tromey  <tom@tromey.com>
7066
7067         * symtab.c (lookup_global_symbol_from_objfile)
7068         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7069         * objfiles.h (class separate_debug_iterator): New.
7070         (class separate_debug_range): New.
7071         (struct objfile) <separate_debug_objfiles>: New method.
7072         (objfile_separate_debug_iterate): Don't declare.
7073         * objfiles.c (separate_debug_iterator::operator++): Rename from
7074         objfile_separate_debug_iterate.
7075         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7076         iterator.
7077         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7078         iterator.
7079
7080 2019-04-10  Tom Tromey  <tom@tromey.com>
7081
7082         * symfile.c (reread_symbols): Remove old comment.
7083         * objfiles.c (free_all_objfiles): Fix a typo.
7084
7085 2019-04-10  Tom Tromey  <tom@tromey.com>
7086
7087         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7088         * minsyms.c (lookup_minimal_symbol): Use foreach.
7089         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7090         (lookup_minimal_symbol_solib_trampoline): Likewise.
7091         * symfile.c (reread_symbols): Use foreach.
7092
7093 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7094             Tom Tromey  <tromey@adacore.com>
7095
7096         PR rust/24414:
7097         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7098         (rust_lex_int_test): Change "value" to be LONGEST.
7099         (rust_lex_tests): Add test for long integer literal.
7100
7101 2019-04-09  Tom Tromey  <tromey@adacore.com>
7102
7103         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7104         to bool.
7105         (extended_remote_target::attach): Update.
7106         (remote_target::remote_notice_new_inferior): Update.
7107         (remote_target::add_current_inferior_and_thread): Update.
7108         * inferior.c (exit_inferior_1): Use "false".
7109         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7110
7111 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7112
7113         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7114         the "start" command.
7115
7116 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7117
7118         * python/py-inferior.c (infpy_thread_from_thread_handle):
7119         Adjust comments to reflect renaming of thread_from_thread_handle
7120         to thread_from_handle.  Adjust keywords.  Fix type error message.
7121         (inferior_object_methods): Add thread_from_handle.  Retain
7122         thread_from_thread_handle, but mark it as deprecated.
7123
7124 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7125
7126         * gdbthread.h (find_thread_by_handle): Revise declaration.
7127         * thread.c (find_thread_by_handle): Likewise.  Adjust
7128         implementation too.
7129         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7130         support for buffer objects as handles.
7131
7132 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7133
7134         * python/py-infthread.c (thpy_thread_handle): New function.
7135         (thread_object_methods): Register thpy_thread_handle.
7136
7137 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7138
7139         * gdbthread.h (thread_to_thread_handle): Declare.
7140         * thread.c (gdbtypes.h): Include.
7141         (thread_to_thread_handle): New function.
7142
7143         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7144         (target_thread_info_to_thread_handle): Declare.
7145         * target.c (target_thread_info_to_thread_handle): New function.
7146         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7147         * target-delegates.c: Regenerate.
7148
7149         * linux-thread-db.c (class thread_db_target): Add method
7150         thread_info_to_thread_handle.
7151         (thread_db_target::thread_info_to_thread_handle): Define.
7152         * remote.c (class remote_target): Add new method
7153         thread_info_to_thread_handle.
7154         (remote_target::thread_info_to_thread_handle): Define.
7155
7156 2019-04-08  Pedro Alves  <palves@redhat.com>
7157
7158         * common/common-exceptions.c (throw_exception): Don't create
7159         named object to throw; throw directly.
7160         (throw_it): Likewise.  Don't initialize gdb_exception::message
7161         here, with new; pass FMT and AP to the ctor instead.
7162         * common/common-exceptions.h: Include <string>.
7163         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7164         const char *, va_list)): New ctor.  Use std::make_shared.
7165         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7166         errors)): Delete.
7167         (gdb_exception_error::gdb_exception_error(enum errors, const char
7168         *, va_list)): New.
7169         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7170         Add assertion.
7171         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7172         errors)): Delete.
7173         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7174         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7175         Add assertion.
7176
7177 2019-04-08  Tom Tromey  <tom@tromey.com>
7178
7179         * valops.c (value_rtti_indirect_type): Replace throw_exception
7180         with throw.
7181         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7182         with throw.
7183         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7184         throw.
7185         * target.c (target_translate_tls_address): Replace throw_exception
7186         with throw.
7187         * stack.c (frame_apply_command_count): Replace throw_exception
7188         with throw.
7189         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7190         throw.
7191         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7192         with throw.
7193         * rs6000-tdep.c (rs6000_frame_cache)
7194         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7195         * remote.c: Replace throw_exception with throw.
7196         * record-full.c (record_full_message, record_full_wait_1)
7197         (record_full_restore): Replace throw_exception with throw.
7198         * record-btrace.c:
7199         (get_thread_current_frame_id, record_btrace_start_replaying)
7200         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7201         (cmd_record_btrace_start): Replace throw_exception with throw.
7202         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7203         throw.
7204         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7205         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7206         * linespec.c:
7207         (find_linespec_symbols): Replace throw_exception with throw.
7208         * infrun.c (displaced_step_prepare, resume): Replace
7209         throw_exception with throw.
7210         * infcmd.c (post_create_inferior): Replace throw_exception with
7211         throw.
7212         * inf-loop.c (inferior_event_handler): Replace throw_exception
7213         with throw.
7214         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7215         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7216         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7217         (get_prev_frame_always, get_frame_pc_if_available)
7218         (get_frame_address_in_block_if_available, get_frame_language):
7219         Replace throw_exception with throw.
7220         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7221         throw_exception with throw.
7222         * eval.c (fetch_subexp_value, evaluate_var_value)
7223         (evaluate_funcall, evaluate_subexp_standard): Replace
7224         throw_exception with throw.
7225         * dwarf2loc.c (call_site_find_chain)
7226         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7227         Replace throw_exception with throw.
7228         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7229         with throw.
7230         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7231         throw.
7232         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7233         * completer.c (complete_line_internal): Replace throw_exception
7234         with throw.
7235         * compile/compile-object-run.c (compile_object_run): Replace
7236         throw_exception with throw.
7237         * cli/cli-script.c (process_next_line): Replace throw_exception
7238         with throw.
7239         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7240         (btrace_enable, btrace_maint_update_pt_packets): Replace
7241         throw_exception with throw.
7242         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7243         throw_exception with throw.
7244         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7245         throw_exception with throw.
7246         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7247         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7248         * aarch64-tdep.c (aarch64_make_prologue_cache)
7249         (aarch64_make_stub_cache): Replace throw_exception with throw.
7250
7251 2019-04-08  Tom Tromey  <tom@tromey.com>
7252
7253         * common/common-exceptions.c (throw_exception): Rename from
7254         throw_exception_cxx.  Remove old copy.  Make argument const.
7255         (throw_it): Create and throw exception objects directly.
7256         * common/common-exceptions.h (throw_exception): Make argument
7257         const.
7258         (struct gdb_exception_error): Add constructor.
7259         (struct gdb_exception_quit): Add constructor.
7260
7261 2019-04-08  Tom Tromey  <tom@tromey.com>
7262
7263         * common/common-exceptions.h (exception_rethrow): Don't declare.
7264         (TRY_SJLJ): Update comment.
7265         (TRY, CATCH, END_CATCH): Remove.
7266         * common/common-exceptions.c (exception_rethrow): Remove.
7267
7268 2019-04-08  Tom Tromey  <tom@tromey.com>
7269
7270         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7271         Remove.
7272         (gdb_exception_error): Rename from
7273         gdb_exception_RETURN_MASK_ERROR.
7274         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7275         (gdb_quit_bad_alloc): Update.
7276         * aarch64-tdep.c: Update.
7277         * ada-lang.c: Update.
7278         * ada-typeprint.c: Update.
7279         * ada-valprint.c: Update.
7280         * amd64-tdep.c: Update.
7281         * arch-utils.c: Update.
7282         * break-catch-throw.c: Update.
7283         * breakpoint.c: Update.
7284         * btrace.c: Update.
7285         * c-varobj.c: Update.
7286         * cli/cli-cmds.c: Update.
7287         * cli/cli-interp.c: Update.
7288         * cli/cli-script.c: Update.
7289         * common/common-exceptions.c: Update.
7290         * common/new-op.c: Update.
7291         * common/selftest.c: Update.
7292         * compile/compile-c-symbols.c: Update.
7293         * compile/compile-cplus-symbols.c: Update.
7294         * compile/compile-object-load.c: Update.
7295         * compile/compile-object-run.c: Update.
7296         * completer.c: Update.
7297         * corelow.c: Update.
7298         * cp-abi.c: Update.
7299         * cp-support.c: Update.
7300         * cp-valprint.c: Update.
7301         * darwin-nat.c: Update.
7302         * disasm-selftests.c: Update.
7303         * dtrace-probe.c: Update.
7304         * dwarf-index-cache.c: Update.
7305         * dwarf-index-write.c: Update.
7306         * dwarf2-frame-tailcall.c: Update.
7307         * dwarf2-frame.c: Update.
7308         * dwarf2loc.c: Update.
7309         * dwarf2read.c: Update.
7310         * eval.c: Update.
7311         * event-loop.c: Update.
7312         * event-top.c: Update.
7313         * exec.c: Update.
7314         * f-valprint.c: Update.
7315         * fbsd-tdep.c: Update.
7316         * frame-unwind.c: Update.
7317         * frame.c: Update.
7318         * gdbtypes.c: Update.
7319         * gnu-v3-abi.c: Update.
7320         * guile/guile-internal.h: Update.
7321         * guile/scm-block.c: Update.
7322         * guile/scm-breakpoint.c: Update.
7323         * guile/scm-cmd.c: Update.
7324         * guile/scm-disasm.c: Update.
7325         * guile/scm-frame.c: Update.
7326         * guile/scm-lazy-string.c: Update.
7327         * guile/scm-math.c: Update.
7328         * guile/scm-param.c: Update.
7329         * guile/scm-ports.c: Update.
7330         * guile/scm-pretty-print.c: Update.
7331         * guile/scm-symbol.c: Update.
7332         * guile/scm-symtab.c: Update.
7333         * guile/scm-type.c: Update.
7334         * guile/scm-value.c: Update.
7335         * i386-linux-tdep.c: Update.
7336         * i386-tdep.c: Update.
7337         * inf-loop.c: Update.
7338         * infcall.c: Update.
7339         * infcmd.c: Update.
7340         * infrun.c: Update.
7341         * jit.c: Update.
7342         * language.c: Update.
7343         * linespec.c: Update.
7344         * linux-fork.c: Update.
7345         * linux-nat.c: Update.
7346         * linux-tdep.c: Update.
7347         * linux-thread-db.c: Update.
7348         * main.c: Update.
7349         * mi/mi-cmd-break.c: Update.
7350         * mi/mi-cmd-stack.c: Update.
7351         * mi/mi-interp.c: Update.
7352         * mi/mi-main.c: Update.
7353         * objc-lang.c: Update.
7354         * p-valprint.c: Update.
7355         * parse.c: Update.
7356         * ppc-linux-tdep.c: Update.
7357         * printcmd.c: Update.
7358         * python/py-arch.c: Update.
7359         * python/py-breakpoint.c: Update.
7360         * python/py-cmd.c: Update.
7361         * python/py-finishbreakpoint.c: Update.
7362         * python/py-frame.c: Update.
7363         * python/py-framefilter.c: Update.
7364         * python/py-gdb-readline.c: Update.
7365         * python/py-inferior.c: Update.
7366         * python/py-infthread.c: Update.
7367         * python/py-lazy-string.c: Update.
7368         * python/py-linetable.c: Update.
7369         * python/py-objfile.c: Update.
7370         * python/py-param.c: Update.
7371         * python/py-prettyprint.c: Update.
7372         * python/py-progspace.c: Update.
7373         * python/py-record-btrace.c: Update.
7374         * python/py-record.c: Update.
7375         * python/py-symbol.c: Update.
7376         * python/py-type.c: Update.
7377         * python/py-unwind.c: Update.
7378         * python/py-utils.c: Update.
7379         * python/py-value.c: Update.
7380         * python/python.c: Update.
7381         * record-btrace.c: Update.
7382         * record-full.c: Update.
7383         * remote-fileio.c: Update.
7384         * remote.c: Update.
7385         * riscv-tdep.c: Update.
7386         * rs6000-aix-tdep.c: Update.
7387         * rs6000-tdep.c: Update.
7388         * rust-exp.y: Update.
7389         * rust-lang.c: Update.
7390         * s390-tdep.c: Update.
7391         * selftest-arch.c: Update.
7392         * solib-dsbt.c: Update.
7393         * solib-frv.c: Update.
7394         * solib-spu.c: Update.
7395         * solib-svr4.c: Update.
7396         * solib.c: Update.
7397         * sparc64-linux-tdep.c: Update.
7398         * stack.c: Update.
7399         * symfile-mem.c: Update.
7400         * symmisc.c: Update.
7401         * target.c: Update.
7402         * thread.c: Update.
7403         * top.c: Update.
7404         * tracefile-tfile.c: Update.
7405         * tui/tui.c: Update.
7406         * typeprint.c: Update.
7407         * unittests/cli-utils-selftests.c: Update.
7408         * unittests/parse-connection-spec-selftests.c: Update.
7409         * valops.c: Update.
7410         * valprint.c: Update.
7411         * value.c: Update.
7412         * varobj.c: Update.
7413         * windows-nat.c: Update.
7414         * x86-linux-nat.c: Update.
7415         * xml-support.c: Update.
7416
7417 2019-04-08  Tom Tromey  <tom@tromey.com>
7418
7419         * xml-support.c: Use C++ exception handling.
7420         * x86-linux-nat.c: Use C++ exception handling.
7421         * windows-nat.c: Use C++ exception handling.
7422         * varobj.c: Use C++ exception handling.
7423         * value.c: Use C++ exception handling.
7424         * valprint.c: Use C++ exception handling.
7425         * valops.c: Use C++ exception handling.
7426         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7427         handling.
7428         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7429         * typeprint.c: Use C++ exception handling.
7430         * tui/tui.c: Use C++ exception handling.
7431         * tracefile-tfile.c: Use C++ exception handling.
7432         * top.c: Use C++ exception handling.
7433         * thread.c: Use C++ exception handling.
7434         * target.c: Use C++ exception handling.
7435         * symmisc.c: Use C++ exception handling.
7436         * symfile-mem.c: Use C++ exception handling.
7437         * stack.c: Use C++ exception handling.
7438         * sparc64-linux-tdep.c: Use C++ exception handling.
7439         * solib.c: Use C++ exception handling.
7440         * solib-svr4.c: Use C++ exception handling.
7441         * solib-spu.c: Use C++ exception handling.
7442         * solib-frv.c: Use C++ exception handling.
7443         * solib-dsbt.c: Use C++ exception handling.
7444         * selftest-arch.c: Use C++ exception handling.
7445         * s390-tdep.c: Use C++ exception handling.
7446         * rust-lang.c: Use C++ exception handling.
7447         * rust-exp.y: Use C++ exception handling.
7448         * rs6000-tdep.c: Use C++ exception handling.
7449         * rs6000-aix-tdep.c: Use C++ exception handling.
7450         * riscv-tdep.c: Use C++ exception handling.
7451         * remote.c: Use C++ exception handling.
7452         * remote-fileio.c: Use C++ exception handling.
7453         * record-full.c: Use C++ exception handling.
7454         * record-btrace.c: Use C++ exception handling.
7455         * python/python.c: Use C++ exception handling.
7456         * python/py-value.c: Use C++ exception handling.
7457         * python/py-utils.c: Use C++ exception handling.
7458         * python/py-unwind.c: Use C++ exception handling.
7459         * python/py-type.c: Use C++ exception handling.
7460         * python/py-symbol.c: Use C++ exception handling.
7461         * python/py-record.c: Use C++ exception handling.
7462         * python/py-record-btrace.c: Use C++ exception handling.
7463         * python/py-progspace.c: Use C++ exception handling.
7464         * python/py-prettyprint.c: Use C++ exception handling.
7465         * python/py-param.c: Use C++ exception handling.
7466         * python/py-objfile.c: Use C++ exception handling.
7467         * python/py-linetable.c: Use C++ exception handling.
7468         * python/py-lazy-string.c: Use C++ exception handling.
7469         * python/py-infthread.c: Use C++ exception handling.
7470         * python/py-inferior.c: Use C++ exception handling.
7471         * python/py-gdb-readline.c: Use C++ exception handling.
7472         * python/py-framefilter.c: Use C++ exception handling.
7473         * python/py-frame.c: Use C++ exception handling.
7474         * python/py-finishbreakpoint.c: Use C++ exception handling.
7475         * python/py-cmd.c: Use C++ exception handling.
7476         * python/py-breakpoint.c: Use C++ exception handling.
7477         * python/py-arch.c: Use C++ exception handling.
7478         * printcmd.c: Use C++ exception handling.
7479         * ppc-linux-tdep.c: Use C++ exception handling.
7480         * parse.c: Use C++ exception handling.
7481         * p-valprint.c: Use C++ exception handling.
7482         * objc-lang.c: Use C++ exception handling.
7483         * mi/mi-main.c: Use C++ exception handling.
7484         * mi/mi-interp.c: Use C++ exception handling.
7485         * mi/mi-cmd-stack.c: Use C++ exception handling.
7486         * mi/mi-cmd-break.c: Use C++ exception handling.
7487         * main.c: Use C++ exception handling.
7488         * linux-thread-db.c: Use C++ exception handling.
7489         * linux-tdep.c: Use C++ exception handling.
7490         * linux-nat.c: Use C++ exception handling.
7491         * linux-fork.c: Use C++ exception handling.
7492         * linespec.c: Use C++ exception handling.
7493         * language.c: Use C++ exception handling.
7494         * jit.c: Use C++ exception handling.
7495         * infrun.c: Use C++ exception handling.
7496         * infcmd.c: Use C++ exception handling.
7497         * infcall.c: Use C++ exception handling.
7498         * inf-loop.c: Use C++ exception handling.
7499         * i386-tdep.c: Use C++ exception handling.
7500         * i386-linux-tdep.c: Use C++ exception handling.
7501         * guile/scm-value.c: Use C++ exception handling.
7502         * guile/scm-type.c: Use C++ exception handling.
7503         * guile/scm-symtab.c: Use C++ exception handling.
7504         * guile/scm-symbol.c: Use C++ exception handling.
7505         * guile/scm-pretty-print.c: Use C++ exception handling.
7506         * guile/scm-ports.c: Use C++ exception handling.
7507         * guile/scm-param.c: Use C++ exception handling.
7508         * guile/scm-math.c: Use C++ exception handling.
7509         * guile/scm-lazy-string.c: Use C++ exception handling.
7510         * guile/scm-frame.c: Use C++ exception handling.
7511         * guile/scm-disasm.c: Use C++ exception handling.
7512         * guile/scm-cmd.c: Use C++ exception handling.
7513         * guile/scm-breakpoint.c: Use C++ exception handling.
7514         * guile/scm-block.c: Use C++ exception handling.
7515         * guile/guile-internal.h: Use C++ exception handling.
7516         * gnu-v3-abi.c: Use C++ exception handling.
7517         * gdbtypes.c: Use C++ exception handling.
7518         * frame.c: Use C++ exception handling.
7519         * frame-unwind.c: Use C++ exception handling.
7520         * fbsd-tdep.c: Use C++ exception handling.
7521         * f-valprint.c: Use C++ exception handling.
7522         * exec.c: Use C++ exception handling.
7523         * event-top.c: Use C++ exception handling.
7524         * event-loop.c: Use C++ exception handling.
7525         * eval.c: Use C++ exception handling.
7526         * dwarf2read.c: Use C++ exception handling.
7527         * dwarf2loc.c: Use C++ exception handling.
7528         * dwarf2-frame.c: Use C++ exception handling.
7529         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7530         * dwarf-index-write.c: Use C++ exception handling.
7531         * dwarf-index-cache.c: Use C++ exception handling.
7532         * dtrace-probe.c: Use C++ exception handling.
7533         * disasm-selftests.c: Use C++ exception handling.
7534         * darwin-nat.c: Use C++ exception handling.
7535         * cp-valprint.c: Use C++ exception handling.
7536         * cp-support.c: Use C++ exception handling.
7537         * cp-abi.c: Use C++ exception handling.
7538         * corelow.c: Use C++ exception handling.
7539         * completer.c: Use C++ exception handling.
7540         * compile/compile-object-run.c: Use C++ exception handling.
7541         * compile/compile-object-load.c: Use C++ exception handling.
7542         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7543         * compile/compile-c-symbols.c: Use C++ exception handling.
7544         * common/selftest.c: Use C++ exception handling.
7545         * common/new-op.c: Use C++ exception handling.
7546         * cli/cli-script.c: Use C++ exception handling.
7547         * cli/cli-interp.c: Use C++ exception handling.
7548         * cli/cli-cmds.c: Use C++ exception handling.
7549         * c-varobj.c: Use C++ exception handling.
7550         * btrace.c: Use C++ exception handling.
7551         * breakpoint.c: Use C++ exception handling.
7552         * break-catch-throw.c: Use C++ exception handling.
7553         * arch-utils.c: Use C++ exception handling.
7554         * amd64-tdep.c: Use C++ exception handling.
7555         * ada-valprint.c: Use C++ exception handling.
7556         * ada-typeprint.c: Use C++ exception handling.
7557         * ada-lang.c: Use C++ exception handling.
7558         * aarch64-tdep.c: Use C++ exception handling.
7559
7560 2019-04-08  Tom Tromey  <tom@tromey.com>
7561
7562         * xml-support.c (gdb_xml_parser::parse): Update.
7563         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7564         * value.c (show_convenience): Update.
7565         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7566         (test_parse_flags_qcs): Update.
7567         * thread.c (thr_try_catch_cmd): Update.
7568         * target.c (target_translate_tls_address): Update.
7569         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7570         (info_frame_command_core, frame_apply_command_count): Update.
7571         * rust-exp.y (rust_lex_exception_test): Update.
7572         * riscv-tdep.c (riscv_print_one_register_info): Update.
7573         * remote.c (remote_target::enable_btrace): Update.
7574         * record-btrace.c (record_btrace_enable_warn): Update.
7575         * python/py-utils.c (gdbpy_convert_exception): Update.
7576         * printcmd.c (do_one_display, print_variable_and_value): Update.
7577         * mi/mi-main.c (mi_print_exception): Update.
7578         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7579         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7580         * linux-nat.c (linux_nat_target::attach): Update.
7581         * linux-fork.c (class scoped_switch_fork_info): Update.
7582         * infrun.c (displaced_step_prepare): Update.
7583         * infcall.c (call_function_by_hand_dummy): Update.
7584         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7585         * gnu-v3-abi.c (print_one_vtable): Update.
7586         * frame.c (get_prev_frame_always): Update.
7587         * f-valprint.c (info_common_command_for_block): Update.
7588         * exec.c (try_open_exec_file): Update.
7589         * exceptions.c (print_exception, exception_print)
7590         (exception_fprintf, exception_print_same): Update.
7591         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7592         * dwarf-index-cache.c (index_cache::store)
7593         (index_cache::lookup_gdb_index): Update.
7594         * darwin-nat.c (maybe_cache_shell): Update.
7595         * cp-valprint.c (cp_print_value_fields): Update.
7596         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7597         (gcc_cplus_symbol_address): Update.
7598         * compile/compile-c-symbols.c (gcc_convert_symbol)
7599         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7600         * common/selftest.c: Update.
7601         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7602         a std::string.
7603         (exception_try_scope_entry, exception_try_scope_exit): Don't
7604         declare.
7605         (struct exception_try_scope): Remove.
7606         (TRY): Don't use exception_try_scope.
7607         (struct gdb_exception): Add constructor, operator=.
7608         <what>: New method.
7609         (struct gdb_exception_RETURN_MASK_ALL)
7610         (struct gdb_exception_RETURN_MASK_ERROR)
7611         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7612         (struct gdb_quit_bad_alloc): Update.
7613         * common/common-exceptions.c (exception_none): Change
7614         initializer.
7615         (struct catcher) <state, exception>: Initialize inline.
7616         <prev>: Remove member.
7617         (current_catcher): Remove.
7618         (catchers): New global.
7619         (exceptions_state_mc_init): Simplify.
7620         (catcher_pop): Remove.
7621         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7622         (try_scope_depth, exception_try_scope_entry)
7623         (exception_try_scope_exit): Remove.
7624         (throw_exception_sjlj): Update.
7625         (exception_messages, exception_messages_size): Remove.
7626         (throw_it): Simplify.
7627         (gdb_exception_sliced_copy): Remove.
7628         (throw_exception_cxx): Update.
7629         * cli/cli-script.c (script_from_file): Update.
7630         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7631         Update.
7632         * ada-valprint.c (ada_val_print): Update.
7633         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7634         (create_excep_cond_exprs): Update.
7635
7636 2019-04-08  Tom Tromey  <tom@tromey.com>
7637
7638         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7639         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7640         (TRY, CATCH, END_CATCH): Remove some definitions.
7641         * common/common-exceptions.c: Don't use GDB_XCPT.
7642         (catcher_list_size): Remove.
7643         (throw_exception, throw_it): Simplify.
7644
7645 2019-04-05  Tom Tromey  <tom@tromey.com>
7646
7647         Revert the header-sorting patch.
7648         * ft32-tdep.c: Revert.
7649         * frv-tdep.c: Revert.
7650         * frv-linux-tdep.c: Revert.
7651         * frame.c: Revert.
7652         * frame-unwind.c: Revert.
7653         * frame-base.c: Revert.
7654         * fork-child.c: Revert.
7655         * findvar.c: Revert.
7656         * findcmd.c: Revert.
7657         * filesystem.c: Revert.
7658         * filename-seen-cache.h: Revert.
7659         * filename-seen-cache.c: Revert.
7660         * fbsd-tdep.c: Revert.
7661         * fbsd-nat.h: Revert.
7662         * fbsd-nat.c: Revert.
7663         * f-valprint.c: Revert.
7664         * f-typeprint.c: Revert.
7665         * f-lang.c: Revert.
7666         * extension.h: Revert.
7667         * extension.c: Revert.
7668         * extension-priv.h: Revert.
7669         * expprint.c: Revert.
7670         * exec.h: Revert.
7671         * exec.c: Revert.
7672         * exceptions.c: Revert.
7673         * event-top.c: Revert.
7674         * event-loop.c: Revert.
7675         * eval.c: Revert.
7676         * elfread.c: Revert.
7677         * dwarf2read.h: Revert.
7678         * dwarf2read.c: Revert.
7679         * dwarf2loc.c: Revert.
7680         * dwarf2expr.h: Revert.
7681         * dwarf2expr.c: Revert.
7682         * dwarf2-frame.c: Revert.
7683         * dwarf2-frame-tailcall.c: Revert.
7684         * dwarf-index-write.h: Revert.
7685         * dwarf-index-write.c: Revert.
7686         * dwarf-index-common.c: Revert.
7687         * dwarf-index-cache.h: Revert.
7688         * dwarf-index-cache.c: Revert.
7689         * dummy-frame.c: Revert.
7690         * dtrace-probe.c: Revert.
7691         * disasm.h: Revert.
7692         * disasm.c: Revert.
7693         * disasm-selftests.c: Revert.
7694         * dictionary.c: Revert.
7695         * dicos-tdep.c: Revert.
7696         * demangle.c: Revert.
7697         * dcache.h: Revert.
7698         * dcache.c: Revert.
7699         * darwin-nat.h: Revert.
7700         * darwin-nat.c: Revert.
7701         * darwin-nat-info.c: Revert.
7702         * d-valprint.c: Revert.
7703         * d-namespace.c: Revert.
7704         * d-lang.c: Revert.
7705         * ctf.c: Revert.
7706         * csky-tdep.c: Revert.
7707         * csky-linux-tdep.c: Revert.
7708         * cris-tdep.c: Revert.
7709         * cris-linux-tdep.c: Revert.
7710         * cp-valprint.c: Revert.
7711         * cp-support.c: Revert.
7712         * cp-namespace.c: Revert.
7713         * cp-abi.c: Revert.
7714         * corelow.c: Revert.
7715         * corefile.c: Revert.
7716         * continuations.c: Revert.
7717         * completer.h: Revert.
7718         * completer.c: Revert.
7719         * complaints.c: Revert.
7720         * coffread.c: Revert.
7721         * coff-pe-read.c: Revert.
7722         * cli-out.h: Revert.
7723         * cli-out.c: Revert.
7724         * charset.c: Revert.
7725         * c-varobj.c: Revert.
7726         * c-valprint.c: Revert.
7727         * c-typeprint.c: Revert.
7728         * c-lang.c: Revert.
7729         * buildsym.c: Revert.
7730         * buildsym-legacy.c: Revert.
7731         * build-id.h: Revert.
7732         * build-id.c: Revert.
7733         * btrace.c: Revert.
7734         * bsd-uthread.c: Revert.
7735         * breakpoint.h: Revert.
7736         * breakpoint.c: Revert.
7737         * break-catch-throw.c: Revert.
7738         * break-catch-syscall.c: Revert.
7739         * break-catch-sig.c: Revert.
7740         * blockframe.c: Revert.
7741         * block.c: Revert.
7742         * bfin-tdep.c: Revert.
7743         * bfin-linux-tdep.c: Revert.
7744         * bfd-target.c: Revert.
7745         * bcache.c: Revert.
7746         * ax-general.c: Revert.
7747         * ax-gdb.h: Revert.
7748         * ax-gdb.c: Revert.
7749         * avr-tdep.c: Revert.
7750         * auxv.c: Revert.
7751         * auto-load.c: Revert.
7752         * arm-wince-tdep.c: Revert.
7753         * arm-tdep.c: Revert.
7754         * arm-symbian-tdep.c: Revert.
7755         * arm-pikeos-tdep.c: Revert.
7756         * arm-obsd-tdep.c: Revert.
7757         * arm-nbsd-tdep.c: Revert.
7758         * arm-nbsd-nat.c: Revert.
7759         * arm-linux-tdep.c: Revert.
7760         * arm-linux-nat.c: Revert.
7761         * arm-fbsd-tdep.c: Revert.
7762         * arm-fbsd-nat.c: Revert.
7763         * arm-bsd-tdep.c: Revert.
7764         * arch-utils.c: Revert.
7765         * arc-tdep.c: Revert.
7766         * arc-newlib-tdep.c: Revert.
7767         * annotate.h: Revert.
7768         * annotate.c: Revert.
7769         * amd64-windows-tdep.c: Revert.
7770         * amd64-windows-nat.c: Revert.
7771         * amd64-tdep.c: Revert.
7772         * amd64-sol2-tdep.c: Revert.
7773         * amd64-obsd-tdep.c: Revert.
7774         * amd64-obsd-nat.c: Revert.
7775         * amd64-nbsd-tdep.c: Revert.
7776         * amd64-nbsd-nat.c: Revert.
7777         * amd64-nat.c: Revert.
7778         * amd64-linux-tdep.c: Revert.
7779         * amd64-linux-nat.c: Revert.
7780         * amd64-fbsd-tdep.c: Revert.
7781         * amd64-fbsd-nat.c: Revert.
7782         * amd64-dicos-tdep.c: Revert.
7783         * amd64-darwin-tdep.c: Revert.
7784         * amd64-bsd-nat.c: Revert.
7785         * alpha-tdep.c: Revert.
7786         * alpha-obsd-tdep.c: Revert.
7787         * alpha-nbsd-tdep.c: Revert.
7788         * alpha-mdebug-tdep.c: Revert.
7789         * alpha-linux-tdep.c: Revert.
7790         * alpha-linux-nat.c: Revert.
7791         * alpha-bsd-tdep.c: Revert.
7792         * alpha-bsd-nat.c: Revert.
7793         * aix-thread.c: Revert.
7794         * agent.c: Revert.
7795         * addrmap.c: Revert.
7796         * ada-varobj.c: Revert.
7797         * ada-valprint.c: Revert.
7798         * ada-typeprint.c: Revert.
7799         * ada-tasks.c: Revert.
7800         * ada-lang.c: Revert.
7801         * aarch64-tdep.c: Revert.
7802         * aarch64-ravenscar-thread.c: Revert.
7803         * aarch64-newlib-tdep.c: Revert.
7804         * aarch64-linux-tdep.c: Revert.
7805         * aarch64-linux-nat.c: Revert.
7806         * aarch64-fbsd-tdep.c: Revert.
7807         * aarch64-fbsd-nat.c: Revert.
7808         * aarch32-linux-nat.c: Revert.
7809
7810 2019-04-05  Tom Tromey  <tom@tromey.com>
7811
7812         * ft32-tdep.c: Sort headers.
7813         * frv-tdep.c: Sort headers.
7814         * frv-linux-tdep.c: Sort headers.
7815         * frame.c: Sort headers.
7816         * frame-unwind.c: Sort headers.
7817         * frame-base.c: Sort headers.
7818         * fork-child.c: Sort headers.
7819         * findvar.c: Sort headers.
7820         * findcmd.c: Sort headers.
7821         * filesystem.c: Sort headers.
7822         * filename-seen-cache.h: Sort headers.
7823         * filename-seen-cache.c: Sort headers.
7824         * fbsd-tdep.c: Sort headers.
7825         * fbsd-nat.h: Sort headers.
7826         * fbsd-nat.c: Sort headers.
7827         * f-valprint.c: Sort headers.
7828         * f-typeprint.c: Sort headers.
7829         * f-lang.c: Sort headers.
7830         * extension.h: Sort headers.
7831         * extension.c: Sort headers.
7832         * extension-priv.h: Sort headers.
7833         * expprint.c: Sort headers.
7834         * exec.h: Sort headers.
7835         * exec.c: Sort headers.
7836         * exceptions.c: Sort headers.
7837         * event-top.c: Sort headers.
7838         * event-loop.c: Sort headers.
7839         * eval.c: Sort headers.
7840         * elfread.c: Sort headers.
7841         * dwarf2read.h: Sort headers.
7842         * dwarf2read.c: Sort headers.
7843         * dwarf2loc.c: Sort headers.
7844         * dwarf2expr.h: Sort headers.
7845         * dwarf2expr.c: Sort headers.
7846         * dwarf2-frame.c: Sort headers.
7847         * dwarf2-frame-tailcall.c: Sort headers.
7848         * dwarf-index-write.h: Sort headers.
7849         * dwarf-index-write.c: Sort headers.
7850         * dwarf-index-common.c: Sort headers.
7851         * dwarf-index-cache.h: Sort headers.
7852         * dwarf-index-cache.c: Sort headers.
7853         * dummy-frame.c: Sort headers.
7854         * dtrace-probe.c: Sort headers.
7855         * disasm.h: Sort headers.
7856         * disasm.c: Sort headers.
7857         * disasm-selftests.c: Sort headers.
7858         * dictionary.c: Sort headers.
7859         * dicos-tdep.c: Sort headers.
7860         * demangle.c: Sort headers.
7861         * dcache.h: Sort headers.
7862         * dcache.c: Sort headers.
7863         * darwin-nat.h: Sort headers.
7864         * darwin-nat.c: Sort headers.
7865         * darwin-nat-info.c: Sort headers.
7866         * d-valprint.c: Sort headers.
7867         * d-namespace.c: Sort headers.
7868         * d-lang.c: Sort headers.
7869         * ctf.c: Sort headers.
7870         * csky-tdep.c: Sort headers.
7871         * csky-linux-tdep.c: Sort headers.
7872         * cris-tdep.c: Sort headers.
7873         * cris-linux-tdep.c: Sort headers.
7874         * cp-valprint.c: Sort headers.
7875         * cp-support.c: Sort headers.
7876         * cp-namespace.c: Sort headers.
7877         * cp-abi.c: Sort headers.
7878         * corelow.c: Sort headers.
7879         * corefile.c: Sort headers.
7880         * continuations.c: Sort headers.
7881         * completer.h: Sort headers.
7882         * completer.c: Sort headers.
7883         * complaints.c: Sort headers.
7884         * coffread.c: Sort headers.
7885         * coff-pe-read.c: Sort headers.
7886         * cli-out.h: Sort headers.
7887         * cli-out.c: Sort headers.
7888         * charset.c: Sort headers.
7889         * c-varobj.c: Sort headers.
7890         * c-valprint.c: Sort headers.
7891         * c-typeprint.c: Sort headers.
7892         * c-lang.c: Sort headers.
7893         * buildsym.c: Sort headers.
7894         * buildsym-legacy.c: Sort headers.
7895         * build-id.h: Sort headers.
7896         * build-id.c: Sort headers.
7897         * btrace.c: Sort headers.
7898         * bsd-uthread.c: Sort headers.
7899         * breakpoint.h: Sort headers.
7900         * breakpoint.c: Sort headers.
7901         * break-catch-throw.c: Sort headers.
7902         * break-catch-syscall.c: Sort headers.
7903         * break-catch-sig.c: Sort headers.
7904         * blockframe.c: Sort headers.
7905         * block.c: Sort headers.
7906         * bfin-tdep.c: Sort headers.
7907         * bfin-linux-tdep.c: Sort headers.
7908         * bfd-target.c: Sort headers.
7909         * bcache.c: Sort headers.
7910         * ax-general.c: Sort headers.
7911         * ax-gdb.h: Sort headers.
7912         * ax-gdb.c: Sort headers.
7913         * avr-tdep.c: Sort headers.
7914         * auxv.c: Sort headers.
7915         * auto-load.c: Sort headers.
7916         * arm-wince-tdep.c: Sort headers.
7917         * arm-tdep.c: Sort headers.
7918         * arm-symbian-tdep.c: Sort headers.
7919         * arm-pikeos-tdep.c: Sort headers.
7920         * arm-obsd-tdep.c: Sort headers.
7921         * arm-nbsd-tdep.c: Sort headers.
7922         * arm-nbsd-nat.c: Sort headers.
7923         * arm-linux-tdep.c: Sort headers.
7924         * arm-linux-nat.c: Sort headers.
7925         * arm-fbsd-tdep.c: Sort headers.
7926         * arm-fbsd-nat.c: Sort headers.
7927         * arm-bsd-tdep.c: Sort headers.
7928         * arch-utils.c: Sort headers.
7929         * arc-tdep.c: Sort headers.
7930         * arc-newlib-tdep.c: Sort headers.
7931         * annotate.h: Sort headers.
7932         * annotate.c: Sort headers.
7933         * amd64-windows-tdep.c: Sort headers.
7934         * amd64-windows-nat.c: Sort headers.
7935         * amd64-tdep.c: Sort headers.
7936         * amd64-sol2-tdep.c: Sort headers.
7937         * amd64-obsd-tdep.c: Sort headers.
7938         * amd64-obsd-nat.c: Sort headers.
7939         * amd64-nbsd-tdep.c: Sort headers.
7940         * amd64-nbsd-nat.c: Sort headers.
7941         * amd64-nat.c: Sort headers.
7942         * amd64-linux-tdep.c: Sort headers.
7943         * amd64-linux-nat.c: Sort headers.
7944         * amd64-fbsd-tdep.c: Sort headers.
7945         * amd64-fbsd-nat.c: Sort headers.
7946         * amd64-dicos-tdep.c: Sort headers.
7947         * amd64-darwin-tdep.c: Sort headers.
7948         * amd64-bsd-nat.c: Sort headers.
7949         * alpha-tdep.c: Sort headers.
7950         * alpha-obsd-tdep.c: Sort headers.
7951         * alpha-nbsd-tdep.c: Sort headers.
7952         * alpha-mdebug-tdep.c: Sort headers.
7953         * alpha-linux-tdep.c: Sort headers.
7954         * alpha-linux-nat.c: Sort headers.
7955         * alpha-bsd-tdep.c: Sort headers.
7956         * alpha-bsd-nat.c: Sort headers.
7957         * aix-thread.c: Sort headers.
7958         * agent.c: Sort headers.
7959         * addrmap.c: Sort headers.
7960         * ada-varobj.c: Sort headers.
7961         * ada-valprint.c: Sort headers.
7962         * ada-typeprint.c: Sort headers.
7963         * ada-tasks.c: Sort headers.
7964         * ada-lang.c: Sort headers.
7965         * aarch64-tdep.c: Sort headers.
7966         * aarch64-ravenscar-thread.c: Sort headers.
7967         * aarch64-newlib-tdep.c: Sort headers.
7968         * aarch64-linux-tdep.c: Sort headers.
7969         * aarch64-linux-nat.c: Sort headers.
7970         * aarch64-fbsd-tdep.c: Sort headers.
7971         * aarch64-fbsd-nat.c: Sort headers.
7972         * aarch32-linux-nat.c: Sort headers.
7973
7974 2019-04-04  Tom Tromey  <tom@tromey.com>
7975
7976         * varobj.c (varobj_create): Update.
7977         * rust-exp.y (struct rust_parser) <update_innermost_block,
7978         lookup_symbol>: New methods.
7979         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7980         Rename.
7981         (rust_parser::rust_lookup_type)
7982         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7983         * printcmd.c (display_command, do_one_display): Update.
7984         * parser-defs.h (struct parser_state) <parser_state>: Add
7985         "tracker" parameter.
7986         (block_tracker): New member.
7987         (class innermost_block_tracker) <innermost_block_tracker>: Add
7988         "types" parameter.
7989         <reset>: Remove method.
7990         (innermost_block): Don't declare.
7991         (null_post_parser): Update.
7992         * parse.c (innermost_block): Remove global.
7993         (write_dollar_variable): Update.
7994         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7995         Remove "tracker_types" parameter.
7996         (parse_expression): Add "tracker" parameter.
7997         (parse_expression_for_completion): Update.
7998         (null_post_parser): Add "tracker" parameter.
7999         * p-exp.y: Update rules.
8000         * m2-exp.y: Update rules.
8001         * language.h (struct language_defn) <la_post_parser>: Add
8002         "tracker" parameter.
8003         * go-exp.y: Update rules.
8004         * f-exp.y: Update rules.
8005         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8006         parameter.
8007         * d-exp.y: Update rules.
8008         * c-exp.y: Update rules.
8009         * breakpoint.c (set_breakpoint_condition): Create an
8010         innermost_block_tracker.
8011         (watch_command_1): Likewise.
8012         * ada-lang.c (resolve): Add "tracker" parameter.
8013         (resolve_subexp): Likewise.
8014         * ada-exp.y (write_var_from_sym): Update.
8015
8016 2019-04-04  Tom Tromey  <tom@tromey.com>
8017
8018         * type-stack.h: New file.
8019         * type-stack.c: New file.
8020         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8021         type-stack.h.
8022         (insert_into_type_stack, insert_type, push_type, push_type_int)
8023         (insert_type_address_space, pop_type, pop_type_int)
8024         (pop_typelist, pop_type_stack, append_type_stack)
8025         (push_type_stack, get_type_stack, push_typelist)
8026         (follow_type_instance_flags, follow_types): Don't declare.
8027         * parse.c (type_stack): Remove global.
8028         (parse_exp_in_context): Update.
8029         (insert_into_type_stack, insert_type, push_type, push_type_int)
8030         (insert_type_address_space, pop_type, pop_type_int)
8031         (pop_typelist, pop_type_stack, append_type_stack)
8032         (push_type_stack, get_type_stack, push_typelist)
8033         (follow_type_instance_flags, follow_types): Remove (moved to
8034         type-stack.c).
8035         * f-exp.y (type_stack): New global.
8036         Update rules.
8037         (push_kind_type, f_parse): Update.
8038         * d-exp.y (type_stack): New global.
8039         Update rules.
8040         (d_parse): Update.
8041         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8042         Update rules.
8043         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8044         (HFILES_NO_SRCDIR): Add type-stack.h.
8045
8046 2019-04-04  Tom Tromey  <tom@tromey.com>
8047
8048         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8049         (rust_parser::convert_ast_to_expression, rust_parse)
8050         (rust_lex_test_completion, rust_lex_tests): Update.
8051         * parser-defs.h (struct expr_completion_state): New.
8052         (struct parser_state) <parser_state>: Add completion parameter.
8053         <mark_struct_expression, mark_completion_tag>: New methods.
8054         <parse_completion, m_completion_state>: New members.
8055         (prefixify_expression, null_post_parser): Update.
8056         (mark_struct_expression, mark_completion_tag): Don't declare.
8057         * parse.c (parse_completion, expout_last_struct)
8058         (expout_tag_completion_type, expout_completion_name): Remove
8059         globals.
8060         (parser_state::mark_struct_expression)
8061         (parser_state::mark_completion_tag): Now methods.
8062         (prefixify_expression): Add last_struct parameter.
8063         (prefixify_subexp): Likewise.
8064         (parse_exp_1): Update.
8065         (parse_exp_in_context): Add cstate parameter.  Update.
8066         (parse_expression_for_completion): Create an
8067         expr_completion_state.
8068         (null_post_parser): Add "completion" parameter.
8069         * p-exp.y: Update rules.
8070         (yylex): Update.
8071         * language.h (struct language_defn) <la_post_parser>: Add
8072         "completing" parameter.
8073         * go-exp.y: Update rules.
8074         (lex_one_token): Update.
8075         * expression.h (parse_completion): Don't declare.
8076         * d-exp.y: Update rules.
8077         (lex_one_token): Update rules.
8078         * c-exp.y: Update rules.
8079         (lex_one_token): Update.
8080         * ada-lang.c (resolve): Add "parse_completion" parameter.
8081         (resolve_subexp): Likewise.
8082         (ada_resolve_function): Likewise.
8083
8084 2019-04-04  Tom Tromey  <tom@tromey.com>
8085
8086         * parser-defs.h (struct parser_state) <start_arglist,
8087         end_arglist>: New methods.
8088         <arglist_len, m_funcall_chain>: New members.
8089         (arglist_len, start_arglist, end_arglist): Don't declare.
8090         * parse.c (arglist_len, funcall_chain): Remove global.
8091         (start_arglist, end_arglist): Remove functions.
8092         (parse_exp_in_context): Update.
8093         * p-exp.y: Update rules.
8094         * m2-exp.y: Update rules.
8095         * go-exp.y: Update rules.
8096         * f-exp.y: Update rules.
8097         * d-exp.y: Update rules.
8098         * c-exp.y: Update rules.
8099
8100 2019-04-04  Tom Tromey  <tom@tromey.com>
8101
8102         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8103         lex_operator, push_back>: New methods.
8104         Update all rules.
8105         (rust_parser::lex_hex, lex_escape): Rename and update.
8106         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8107         (rust_parser::lex_operator): Rename and update.
8108         (rust_parser::lex_number, rustyylex, rustyyerror)
8109         (rust_lex_test_init, rust_lex_test_sequence)
8110         (rust_lex_test_push_back, rust_lex_tests): Update.
8111         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8112         parameter.
8113         <lexptr, prev_lexptr>: New members.
8114         (lexptr, prev_lexptr): Don't declare.
8115         * parse.c (lexptr, prev_lexptr): Remove globals.
8116         (parse_exp_in_context): Update.
8117         * p-exp.y (yylex, yyerror): Update.
8118         * m2-exp.y (parse_number, yylex, yyerror): Update.
8119         * go-exp.y (lex_one_token, yyerror): Update.
8120         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8121         * d-exp.y (lex_one_token, yyerror): Update.
8122         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8123         (lex_one_token, yyerror): Update.
8124         * ada-lex.l (YY_INPUT): Update.
8125         (rewind_to_char): Update.
8126         * ada-exp.y (yyerror): Update.
8127
8128 2019-04-04  Tom Tromey  <tom@tromey.com>
8129
8130         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8131         * parser-defs.h (struct parser_state) <parser_state>: Add new
8132         parameter.
8133         <comma_terminates>: New member.
8134         (comma_terminates): Don't declare global.
8135         * parse.c (comma_terminates): Remove global.
8136         (parse_exp_in_context): Update.
8137         * p-exp.y (yylex): Update.
8138         * m2-exp.y (yylex): Update.
8139         * go-exp.y (lex_one_token): Update.
8140         * f-exp.y (yylex): Update.
8141         * d-exp.y (lex_one_token): Update.
8142         * c-exp.y (lex_one_token): Update.
8143         * ada-lex.l: Update.
8144
8145 2019-04-04  Tom Tromey  <tom@tromey.com>
8146
8147         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8148         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8149         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8150         * parser-defs.h (paren_depth): Don't declare.
8151         * parse.c (paren_depth): Remove global.
8152         (parse_exp_in_context): Update.
8153         * p-exp.y (paren_depth): New global.
8154         (pascal_parse): Initialize it.
8155         * m2-exp.y (paren_depth): New global.
8156         (m2_parse): Initialize it.
8157         * go-exp.y (paren_depth): New global.
8158         (go_parse): Initialize it.
8159         * f-exp.y (paren_depth): New global.
8160         (f_parse): Initialize it.
8161         * d-exp.y (paren_depth): New global.
8162         (d_parse): Initialize it.
8163         * c-exp.y (paren_depth): New global.
8164         (c_parse): Initialize it.
8165         * ada-lex.l (paren_depth): New global.
8166         (lexer_init): Initialize it.
8167
8168 2019-04-04  Tom Tromey  <tom@tromey.com>
8169
8170         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8171         (rust_parser::convert_ast_to_type)
8172         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8173         * parser-defs.h (struct parser_state) <parser_state>: Add
8174         parameters.  Initialize new members.
8175         <expression_context_block, expression_context_pc>: New members.
8176         * parse.c (expression_context_block, expression_context_pc):
8177         Remove globals.
8178         (parse_exp_in_context): Update.
8179         * p-exp.y: Update all rules.
8180         (yylex): Update.
8181         * m2-exp.y: Update all rules.
8182         (yylex): Update.
8183         * go-exp.y (yylex): Update.
8184         * f-exp.y (yylex): Update.
8185         * d-exp.y: Update all rules.
8186         (yylex): Update.
8187         * c-exp.y: Update all rules.
8188         (lex_one_token, classify_name, yylex, c_parse): Update.
8189         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8190
8191 2019-04-04  Tom Tromey  <tom@tromey.com>
8192
8193         * gdbarch.h, gdbarch.c: Rebuild.
8194         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8195         * stap-probe.h:
8196         (struct stap_parse_info): Replace "parser_state" with
8197         "expr_builder".
8198         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8199         (parser_state): New class.
8200         * parse.c (expr_builder): Rename.
8201         (expr_builder::release): Rename.
8202         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8203         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8204         (write_exp_elt_longcst, write_exp_elt_floatcst)
8205         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8206         (write_exp_string_vector, write_exp_bitstring)
8207         (write_exp_msymbol, mark_struct_expression)
8208         (write_dollar_variable)
8209         (insert_type_address_space, increase_expout_size): Replace
8210         "parser_state" with "expr_builder".
8211         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8212         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8213         "parser_state" with "expr_builder".
8214
8215 2019-04-04  Tom Tromey  <tom@tromey.com>
8216
8217         * rust-exp.y: Replace "parse_language" with method call.
8218         * p-exp.y:
8219         (yylex): Replace "parse_language" with method call.
8220         * m2-exp.y:
8221         (yylex): Replace "parse_language" with method call.
8222         * go-exp.y (classify_name): Replace "parse_language" with method
8223         call.
8224         * f-exp.y (yylex): Replace "parse_language" with method call.
8225         * d-exp.y (lex_one_token): Replace "parse_language" with method
8226         call.
8227         * c-exp.y:
8228         (lex_one_token, classify_name, yylex): Replace "parse_language"
8229         with method call.
8230         * ada-exp.y (find_primitive_type, type_char)
8231         (type_system_address): Replace "parse_language" with method call.
8232
8233 2019-04-04  Tom Tromey  <tom@tromey.com>
8234
8235         * rust-exp.y: Replace "parse_gdbarch" with method call.
8236         * parse.c (write_dollar_variable, insert_type_address_space):
8237         Replace "parse_gdbarch" with method call.
8238         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8239         call.
8240         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8241         call.
8242         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8243         "parse_gdbarch" with method call.
8244         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8245         with method call.
8246         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8247         "parse_gdbarch" with method call.
8248         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8249         "parse_gdbarch" with method call.
8250         * c-exp.y (parse_type, parse_number, classify_name): Replace
8251         "parse_gdbarch" with method call.
8252         * ada-lex.l: Replace "parse_gdbarch" with method call.
8253         * ada-exp.y (parse_type, find_primitive_type, type_char)
8254         (type_system_address): Replace "parse_gdbarch" with method call.
8255
8256 2019-04-04  Tom Tromey  <tom@tromey.com>
8257
8258         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8259         * stap-probe.c (stap_parse_argument): Update.
8260         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8261         initial_size parameter.
8262         * rust-exp.y (rust_lex_tests): Update.
8263         * parse.c (parser_state): Update.
8264         (parse_exp_in_context): Update.
8265         * parser-defs.h (struct parser_state) <parser_state>: Remove
8266         "initial_size" parameter.
8267
8268 2019-04-04  Tom Tromey  <tom@tromey.com>
8269
8270         * parser-defs.h (increase_expout_size): Don't declare.
8271         * parse.c (increase_expout_size): Now static.
8272
8273 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8274
8275         * gnu-nat.c (gnu_nat_target::wait): Fix
8276         target_waitstatus_to_string call.
8277
8278 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8279
8280         * eval.c (evaluate_subexp_standard): Handle internal functions
8281         during Fortran function call handling.
8282
8283 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8284
8285         * NEWS: Mention new internal functions.
8286         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8287         (read_base_type): Use dwarf2_init_complex_target_type.
8288         * value.c (creal_internal_fn): New function.
8289         (cimag_internal_fn): New function.
8290         (_initialize_values): Register new internal functions.
8291
8292 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8293
8294         * infrun.c (stop_all_threads): If debug_infrun, always
8295         trace the wait status after wait_one, using
8296         target_waitstatus_to_string and target_pid_to_str.
8297         (handle_inferior_event): Replace various trace of
8298         wait status kind by a single trace.
8299         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8300         wait status kind image by target_waitstatus_to_string.
8301         * target/waitstatus.c (target_waitstatus_to_string): Fix
8302         obsolete comment.
8303
8304 2019-04-01  Tom Tromey  <tromey@adacore.com>
8305
8306         PR symtab/23331:
8307         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8308
8309 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8310             Pedro Alves  <palves@redhat.com>
8311
8312         * top.c (quit_force): Call 'finalize_values'.
8313         * value.c (finalize_values): New function.
8314         * value.h (finalize_values): Declare.
8315
8316 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8317
8318         * NEWS: Announce $_gdb_major and $_gdb_minor.
8319
8320         * top.c (init_gdb_version_vars): New function.
8321         (gdb_init): Call init_gdb_version_vars.
8322
8323 2019-03-29  Tom Tromey  <tromey@adacore.com>
8324
8325         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8326         help text.  Remove dead code.
8327
8328 2019-03-29  Keith Seitz  <keiths@redhat.com>
8329
8330         From Siddhesh Poyarekar:
8331         * f-lang.h (f77_get_upperbound): Return LONGEST.
8332         (f77_get_lowerbound): Likewise.
8333         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8334         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8335         print them.
8336         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8337         plongest to format print it.
8338         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8339         (f77_get_upperbound): Likewise.
8340         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8341         LOWER_BOUND to LONGEST.
8342         (f77_create_arrayprint_offset_tbl): Likewise.
8343
8344 2019-03-29  Keith Seitz  <keiths@redhat.com>
8345
8346         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8347         %s/pulongest for TYPE_LENGTH instead of %d in format
8348         strings.
8349         * ada-typerint.c (ada_print_type): Likewise.
8350         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8351         * compile/compile-c-support.c (generate_register_struct): Likewise.
8352         * gdbtypes.c (recursive_dump_type): Likewise.
8353         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8354         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8355         instead of %d in format strings.
8356         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8357         to std::min to ULONGEST.
8358         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8359         instead of %d in format strings.
8360         * tracepoint.c (info_scope_command): Likewise.
8361         * typeprint.c (print_offset_data::update)
8362         (print_offset_data::finish): Likewise.
8363         * xtensa-tdep.c (xtensa_store_return_value)
8364         (xtensa_push_dummy_call): Likewise.
8365
8366 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8367
8368         * windows-nat.c (display_selector): Fixed format specifications
8369         for 64-bit Cygwin.
8370
8371 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8372
8373         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8374
8375 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8376
8377         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8378         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8379         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8380         (nios2_linux_init_abi): Install it.
8381
8382 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8383
8384         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8385
8386 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8387
8388         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8389
8390 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8391             Tom Tromey  <tromey@adacore.com>
8392
8393         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8394
8395 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8396
8397         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8398         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8399         method to compute the bounds of range types. Also print "[evaluated]"
8400         if the bounds' values come from a dynamic evaluation.
8401
8402 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8403
8404         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8405         whitespace when pretty printing is on.
8406
8407 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8408
8409         * ppc-linux-nat.c: Add include.
8410
8411 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8412
8413         * NEWS: Mention AArch64 Pointer Authentication.
8414
8415 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8416
8417         * arm-linux-nat.c: Add include.
8418
8419 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8420
8421         * source-cache.c (source_cache::get_source_lines): Re-read
8422         fullname after calling open_source_file.
8423
8424 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8425
8426         * NEWS: Mention TLS support for FreeBSD.
8427
8428 2019-03-25  Tom Tromey  <tromey@adacore.com>
8429
8430         * minsyms.c (BUNCH_SIZE): Update comment.
8431         (~minimal_symbol_reader): Remove old comment.
8432         (compact_minimal_symbols): Update comment.
8433         (minimal_symbol_reader::install): Remove old comment.  Update
8434         other comments.
8435
8436 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8437
8438         * s390-linux-nat.c: Add include.
8439
8440 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8441
8442         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8443         Call linux_get_hwcap.
8444         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8445         Likewise.
8446         (aarch64_linux_get_hwcap): Remove function.
8447         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8448         declaration.
8449         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8450         linux_get_hwcap.
8451         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8452         * linux-tdep.c (linux_get_hwcap): Add function.
8453         (linux_get_hwcap2): Likewise.
8454         * linux-tdep.h (linux_get_hwcap): Add declaration.
8455         (linux_get_hwcap2): Likewise.
8456         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8457         (ppc_linux_get_hwcap2): Likewise.
8458         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8459         linux_get_hwcap.
8460         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8461         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8462         (ppc_linux_nat_target::read_description): Likewise.
8463         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8464         * s390-linux-nat.c: Likewise.
8465         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8466
8467 2019-03-24  Tom Tromey  <tom@tromey.com>
8468
8469         * ada-lang.c (standard_lookup): Simplify initialization.
8470         (ada_lookup_symbol_nonlocal): Simplify return.
8471         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8472         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8473         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8474         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8475         initialization.
8476         * solib.c (solib_global_lookup): Simplify.
8477         * symtab.c (null_block_symbol): Remove.
8478         (symbol_cache_lookup): Simplify returns.
8479         (lookup_language_this): Simplify returns.
8480         (lookup_symbol_aux): Simplify return.
8481         (lookup_local_symbol): Simplify returns.
8482         (lookup_global_symbol_from_objfile): Simplify return.
8483         (lookup_symbol_in_objfile_symtabs)
8484         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8485         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8486         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8487         * cp-namespace.c (cp_lookup_bare_symbol)
8488         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8489         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8490         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8491         (cp_lookup_symbol_via_imports): Simplify initialization.
8492         (find_symbol_in_baseclass): Likewise.
8493         * symtab.h (null_block_symbol): Remove.
8494         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8495         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8496         (d_lookup_symbol_module): Likewise.
8497         (find_symbol_in_baseclass): Simplify initialization.
8498
8499 2019-03-24  Tom Tromey  <tom@tromey.com>
8500
8501         * expression.h: Don't include symtab.h.
8502         (struct block): Forward declare.
8503
8504 2019-03-24  Tom Tromey  <tom@tromey.com>
8505
8506         * c-exp.y (typebase): Remove casts.
8507         * gdbtypes.c (lookup_unsigned_typename, )
8508         (lookup_signed_typename): Remove cast.
8509         * eval.c (parse_to_comma_and_eval): Remove cast.
8510         * parse.c (write_dollar_variable): Remove cast.
8511         * block.h (struct block) <superblock>: Now const.
8512         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8513         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8514         (map_block): Make "block" const.
8515         * symfile.h (struct quick_symbol_functions)
8516         <map_matching_symbols>: Constify block argument to "callback".
8517         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8518         const.
8519         (find_pc_sect_compunit_symtab): Make "b" const.
8520         (find_symbol_at_address): Likewise.
8521         (search_symbols): Likewise.
8522         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8523         (dw2_debug_names_lookup_symbol): Likewise.
8524         (dw2_map_matching_symbols): Update.
8525         * p-valprint.c (pascal_val_print): Remove "block".
8526         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8527         (aux_add_nonlocal_symbols): Make "block" const.
8528         (resolve_subexp): Remove cast.
8529         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8530         const.
8531         (iterate_over_file_blocks): Likewise.
8532         * f-exp.y (%union) <bval>: Remove.
8533         * coffread.c (patch_opaque_types): Make "b" const.
8534         * spu-tdep.c (spu_catch_start): Make "block" const.
8535         * c-valprint.c (print_unpacked_pointer): Remove "block".
8536         * symmisc.c (dump_symtab_1): Make "b" const.
8537         (block_depth): Make "block" const.
8538         * d-exp.y (%union) <bval>: Remove.
8539         * cp-support.h (cp_lookup_rtti_type): Update.
8540         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8541         * psymtab.c (psym_lookup_symbol): Make "block" const.
8542         (maintenance_check_psymtabs): Make "b" const.
8543         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8544         (enumerate_locals, enumerate_args): Update.
8545         * python/py-symtab.c (stpy_global_block): Make "block" const.
8546         (stpy_static_block): Likewise.
8547         * inline-frame.c (block_starting_point_at): Make "new_block"
8548         const.
8549         * block.c (find_block_in_blockvector): Make return type const.
8550         (blockvector_for_pc_sect): Make "b" const.
8551         (find_block_in_blockvector): Make "b" const.
8552
8553 2019-03-23  Tom Tromey  <tom@tromey.com>
8554
8555         * varobj.c (varobj_create): Update.
8556         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8557         * printcmd.c (display_command, do_one_display): Don't reset
8558         innermost_block.
8559         * parser-defs.h (enum innermost_block_tracker_type): Move to
8560         expression.h.
8561         (innermost_block): Update comment.
8562         * parse.c (parse_exp_1): Add tracker_types parameter.
8563         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8564         tracker_types parameter.  Reset innermost_block.
8565         (parse_exp_in_context): Remove.
8566         (parse_expression_for_completion): Update.
8567         * objfiles.c (~objfile): Don't reset expression_context_block or
8568         innermost_block.
8569         * expression.h (enum innermost_block_tracker_type): Move from
8570         parser-defs.h.
8571         (parse_exp_1): Add tracker_types parameter.
8572         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8573         reset innermost_block.
8574
8575 2019-03-23  Tom Tromey  <tom@tromey.com>
8576
8577         * objfiles.h: Include bcache.h.
8578
8579 2019-03-23  Tom Tromey  <tom@tromey.com>
8580
8581         * linespec.c (get_current_search_block): Use
8582         scoped_restore_current_language.
8583         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8584
8585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8586             Jiong Wang  <jiong.wang@arm.com>
8587
8588         * aarch64-linux-tdep.c
8589         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8590         section.
8591         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8592
8593 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8594             Jiong Wang  <jiong.wang@arm.com>
8595
8596         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8597         instructions.
8598         (aarch64_analyze_prologue_test): Add PACIASP test.
8599         (aarch64_prologue_prev_register): Unmask PC value.
8600
8601 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8602             Jiong Wang  <jiong.wang@arm.com>
8603
8604         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8605         (aarch64_dwarf2_prev_register): Unmask PC value.
8606         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8607         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8608         DW_CFA_AARCH64_negate_ra_state.
8609         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8610
8611 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8612             Jiong Wang  <jiong.wang@arm.com>
8613
8614         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8615         registers.
8616         (aarch64_pseudo_register_name): Likewise.
8617         (aarch64_pseudo_register_type): Likewise.
8618         (aarch64_pseudo_register_reggroup_p): Likewise.
8619         (aarch64_gdbarch_init): Add pauth registers.
8620         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8621         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8622         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8623         (struct gdbarch_tdep): Add regnum for ra_state.
8624
8625 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8626             Jiong Wang  <jiong.wang@arm.com>
8627
8628         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8629
8630 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8631             Jiong Wang  <jiong.wang@arm.com>
8632
8633         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8634         function.
8635         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8636         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8637         (aarch64_gdbarch_init): Add puth registers.
8638         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8639         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8640         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8641
8642 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8643             Jiong Wang  <jiong.wang@arm.com>
8644
8645         * aarch64-linux-nat.c
8646         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8647         * aarch64-linux-tdep.c
8648         (aarch64_linux_core_read_description): Likewise.
8649         (aarch64_linux_get_hwcap): New function.
8650         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8651         (aarch64_linux_get_hwcap): New declaration.
8652
8653 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8654             Jiong Wang  <jiong.wang@arm.com>
8655
8656         * aarch64-linux-nat.c
8657         (aarch64_linux_nat_target::read_description): Add pauth param.
8658         * aarch64-linux-tdep.c
8659         (aarch64_linux_core_read_description): Likewise.
8660         * aarch64-tdep.c (struct target_desc): Add in pauth.
8661         (aarch64_read_description): Add pauth param.
8662         (aarch64_gdbarch_init): Likewise.
8663         * aarch64-tdep.h (aarch64_read_description): Likewise.
8664         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8665         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8666         * features/Makefile: Add new files.
8667         * features/aarch64-pauth.c: New file.
8668         * features/aarch64-pauth.xml: New file.
8669
8670 2019-03-20  Tom Tromey  <tromey@adacore.com>
8671
8672         * infrun.c (handle_inferior_event): Rename from
8673         handle_inferior_event_1.  Create a scoped_value_mark.
8674         (handle_inferior_event): Remove.
8675
8676 2019-03-19  Tom Tromey  <tromey@adacore.com>
8677
8678         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8679         * infrun.h (print_stop_event): Add "displays" parameter.
8680         * infrun.c (print_stop_event): Add "displays" parameter.
8681
8682 2019-03-19  Pedro Alves  <palves@redhat.com>
8683
8684         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8685         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8686         to -1.  Fix TABs vs spaces.
8687         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8688         * tui/tui-out.h (tui_ui_out) Add intro comments.
8689         <m_line, m_start_of_line>: In-class initialize, and add describing
8690         comment.
8691
8692 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8693
8694         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8695         variable names.
8696         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8697
8698 2019-03-18  Pedro Alves  <palves@redhat.com>
8699             Eli Zaretskii <eliz@gnu.org>
8700
8701         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8702         m_line and m_start_of_line.
8703
8704 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8705
8706         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8707         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8708         it returns a newline.  This fixes a regression in TU mode, whereby
8709         the next line is output on the same screen line as the user input.
8710
8711 2019-03-18  Tom Tromey  <tromey@adacore.com>
8712
8713         * minsyms.c (minimal_symbol_reader::install): Remove call to
8714         obstack_blank.
8715
8716 2019-03-18  Pedro Alves  <palves@redhat.com>
8717
8718         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8719         New globals.
8720         (apply_style): New, factored out from ...
8721         (apply_ansi_escape): ... this.  Handle reverse video mode.
8722         (tui_set_reverse_mode): New function.
8723         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8724         * tui/tui-winsource.c (tui_show_source_line): Use
8725         tui_set_reverse_mode instead of setting A_STANDOUT.
8726         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8727         New setter methods.
8728
8729 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8730
8731         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8732         Handle tabs.
8733
8734 2019-03-18  Tom Tromey  <tromey@adacore.com>
8735
8736         * ada-lang.c (empty_array): Add "high" parameter.
8737         (ada_evaluate_subexp): Update.
8738
8739 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8740
8741         * unittests/string_view-selftests.c: Define
8742         _initialize_string_view_selftests unconditionally.
8743
8744 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8745
8746         PR gdb/24350
8747         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8748
8749 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8750
8751         PR gdb/24351
8752         * windows-nat.c (display_selector): Fix format specifiers.
8753
8754 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8755
8756         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8757         tui_refill_source_window instead of tui_refresh_win, to update the
8758         current execution line.  This fixes redisplay of the current line
8759         when stepping through the code with "next" or "step".
8760
8761 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8762
8763         * source-cache.c (source_cache::get_source_lines): Call
8764         find_source_lines to initialize s->nlines.  This fixes vertical
8765         scrolling of TUI source window when the DOWN arrow is pressed.
8766
8767 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8768
8769         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8770         linux-thread-db.c (_initialize_thread_db): Likewise.
8771
8772 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8773
8774         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8775         wclrtoeol in tui_show_source_line".  This reverts changes made in
8776         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8777
8778 2019-03-15  Tom Tromey  <tom@tromey.com>
8779
8780         * symtab.h (struct minimal_symbol): Derive from
8781         general_symbol_info.
8782         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8783         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8784         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8785         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8786         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8787         (MSYMBOL_SEARCH_NAME): Update.
8788         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8789         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8790         * minsyms.c (minimal_symbol_reader::record_full): Update.
8791
8792 2019-03-15  Tom Tromey  <tom@tromey.com>
8793
8794         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8795
8796 2019-03-15  Tom Tromey  <tom@tromey.com>
8797
8798         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8799         unique_xmalloc_ptr.
8800         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8801         Update.
8802         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8803         (build_minimal_symbol_hash_tables)
8804         (minimal_symbol_reader::install): Update.
8805
8806 2019-03-15  Tom Tromey  <tom@tromey.com>
8807
8808         * symtab.c (create_demangled_names_hash): Update.
8809         (symbol_set_names): Update.
8810         * objfiles.h (struct objfile_per_bfd_storage)
8811         <demangled_names_hash>: Now an htab_up.
8812         * objfiles.c (objfile_per_bfd_storage): Simplify.
8813
8814 2019-03-15  Tom Tromey  <tom@tromey.com>
8815
8816         * objfiles.h (struct objfile_per_bfd_storage): Declare
8817         destructor.
8818         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8819         New.
8820         (get_objfile_bfd_data): Use new.  Don't initialize
8821         language_of_main.
8822         (free_objfile_per_bfd_storage): Remove.
8823         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8824
8825 2019-03-15  Tom Tromey  <tom@tromey.com>
8826
8827         * symfile.c (reread_symbols): Update.
8828         * objfiles.c (objfile::objfile): Update.
8829         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8830         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8831         comment.
8832         (minimal_symbol_reader::install): Update.
8833         (terminate_minimal_symbol_table): Remove.
8834         * jit.c (jit_object_close_impl): Update.
8835
8836 2019-03-15  Tom Tromey  <tom@tromey.com>
8837
8838         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8839         initializations.
8840
8841 2019-03-15  Tom Tromey  <tom@tromey.com>
8842
8843         * objfiles.h (struct objfile_per_bfd_storage)
8844         <demangled_hash_languages>: Now a bitset.
8845         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8846         (lookup_minimal_symbol): Update.
8847
8848 2019-03-15  Tom Tromey  <tom@tromey.com>
8849
8850         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8851         Don't return the symbol.
8852         * coffread.c (record_minimal_symbol): Use record_full.
8853
8854 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8855
8856         The MS-Windows port of ncurses fails to switch to a color pair if
8857         one or both of the colors are the implicit default colors.  This
8858         change records the default colors when TUI is initialized, and
8859         then specifies them explicitly when a color pair uses the default
8860         colors.  This allows color styling in TUI mode on MS-Windows.
8861
8862         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8863         ncurses_norm_attr.
8864         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8865         colors in ncurses_norm_attr.
8866         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8867         "none", replace it with the default color recorded in
8868         ncurses_norm_attr.
8869
8870 2019-03-14  Tom Tromey  <tromey@adacore.com>
8871
8872         * source-cache.h (class source_cache) <get_source_lines>: Return
8873         std::string.
8874         * source-cache.c (source_cache::extract_lines): Handle case where
8875         first_pos==npos.  Return std::string.
8876         (source_cache::get_source_lines): Update.
8877
8878 2019-03-14  Tom Tromey  <tromey@adacore.com>
8879
8880         * NEWS: Add item for "style sources" commands.
8881         * source-cache.c (source_cache::get_source_lines): Check
8882         source_styling.
8883         * cli/cli-style.c (source_styling): New global.
8884         (_initialize_cli_style): Add "style sources" commands.
8885         (show_style_sources): New function.
8886         * cli/cli-style.h (source_styling): Declare.
8887
8888 2019-03-14  Pedro Alves  <palves@redhat.com>
8889             Tom Tromey  <tromey@adacore.com>
8890
8891         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8892         * tui/tui-winsource.c (tui_refill_source_window): New function,
8893         from...
8894         (tui_horizontal_source_scroll): ... here.  Move some logic.
8895         * cli/cli-style.c (set_style_enabled): Notify new observable.
8896         * tui/tui-hooks.c (tui_redisplay_source): New function.
8897         (tui_attach_detach_observers): Attach or detach
8898         tui_redisplay_source.
8899         * observable.h (source_styling_changed): New observable.
8900         * observable.c: Define source_styling_changed observable.
8901
8902 2019-03-13  Tom Tromey  <tromey@adacore.com>
8903
8904         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8905         (i386_gnu_nat_target::store_registers): Update.
8906         * target-debug.h (target_debug_print_std_string): New macro.
8907         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8908         * windows-tdep.c (display_one_tib): Update.
8909         * tui/tui-stack.c (tui_make_status_line): Update.
8910         * top.c (print_inferior_quit_action): Update.
8911         * thread.c (thr_try_catch_cmd): Update.
8912         (add_thread_with_info): Update.
8913         (thread_target_id_str): Update.
8914         (thr_try_catch_cmd): Update.
8915         (thread_command): Update.
8916         (thread_find_command): Update.
8917         * record-btrace.c (record_btrace_target::info_record)
8918         (record_btrace_resume_thread, record_btrace_target::resume)
8919         (record_btrace_cancel_resume, record_btrace_step_thread)
8920         (record_btrace_target::wait, record_btrace_target::wait)
8921         (record_btrace_target::wait, record_btrace_target::stop): Update.
8922         * progspace.c (print_program_space): Update.
8923         * process-stratum-target.c
8924         (process_stratum_target::thread_address_space): Update.
8925         * linux-fork.c (linux_fork_mourn_inferior)
8926         (detach_checkpoint_command, info_checkpoints_command)
8927         (linux_fork_context): Update.
8928         (linux_fork_detach): Update.
8929         (class scoped_switch_fork_info): Update.
8930         (delete_checkpoint_command): Update.
8931         * infrun.c (follow_fork_inferior): Update.
8932         (follow_fork_inferior): Update.
8933         (proceed_after_vfork_done): Update.
8934         (handle_vfork_child_exec_or_exit): Update.
8935         (follow_exec): Update.
8936         (displaced_step_prepare_throw): Update.
8937         (displaced_step_restore): Update.
8938         (start_step_over): Update.
8939         (resume_1): Update.
8940         (clear_proceed_status_thread): Update.
8941         (proceed): Update.
8942         (print_target_wait_results): Update.
8943         (do_target_wait): Update.
8944         (context_switch): Update.
8945         (stop_all_threads): Update.
8946         (restart_threads): Update.
8947         (finish_step_over): Update.
8948         (handle_signal_stop): Update.
8949         (switch_back_to_stepped_thread): Update.
8950         (keep_going_pass_signal): Update.
8951         (print_exited_reason): Update.
8952         (normal_stop): Update.
8953         * inferior.c (inferior_pid_to_str): Change return type.
8954         (print_selected_inferior): Update.
8955         (add_inferior): Update.
8956         (detach_inferior): Update.
8957         * dummy-frame.c (fprint_dummy_frames): Update.
8958         * dcache.c (dcache_info_1): Update.
8959         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8960         (btrace_fetch, btrace_clear): Update.
8961         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8962         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8963         type.
8964         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8965         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8966         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8967         * gdbarch.c, gdbarch.h: Rebuild.
8968         * gdbarch.sh (core_pid_to_str): Change return type.
8969         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8970         return type.
8971         (windows_nat_target::pid_to_str): Change return type.
8972         (windows_delete_thread): Update.
8973         (windows_nat_target::attach): Update.
8974         (windows_nat_target::files_info): Update.
8975         * target-delegates.c: Rebuild.
8976         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8977         return type.
8978         (sol_thread_target::pid_to_str): Change return type.
8979         * remote.c (class remote_target) <pid_to_str>: Change return
8980         type.
8981         (remote_target::pid_to_str): Change return type.
8982         (extended_remote_target::attach, remote_target::remote_stop_ns)
8983         (remote_target::remote_notif_remove_queued_reply)
8984         (remote_target::push_stop_reply, remote_target::disable_btrace):
8985         Update.
8986         (extended_remote_target::attach): Update.
8987         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8988         type.
8989         (gdbsim_target::pid_to_str): Change return type.
8990         * ravenscar-thread.c (struct ravenscar_thread_target)
8991         <pid_to_str>: Change return type.
8992         (ravenscar_thread_target::pid_to_str): Change return type.
8993         * procfs.c (class procfs_target) <pid_to_str>: Change return
8994         type.
8995         (procfs_target::pid_to_str): Change return type.
8996         (procfs_target::attach): Update.
8997         (procfs_target::detach): Update.
8998         (procfs_target::fetch_registers): Update.
8999         (procfs_target::store_registers): Update.
9000         (procfs_target::wait): Update.
9001         (procfs_target::files_info): Update.
9002         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9003         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9004         return type.
9005         (nto_procfs_target::pid_to_str): Change return type.
9006         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9007         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9008         return type.
9009         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9010         (exit_lwp): Update.
9011         (attach_proc_task_lwp_callback, get_detach_signal)
9012         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9013         (linux_nat_target::resume, wait_lwp, stop_callback)
9014         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9015         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9016         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9017         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9018         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9019         type.
9020         (inf_ptrace_target::attach): Update.
9021         (inf_ptrace_target::files_info): Update.
9022         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9023         type.
9024         (go32_nat_target::pid_to_str): Change return type.
9025         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9026         (gnu_nat_target::wait): Update.
9027         (gnu_nat_target::wait): Update.
9028         (gnu_nat_target::resume): Update.
9029         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9030         (fbsd_nat_target::wait): Update.
9031         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9032         type.
9033         (darwin_nat_target::attach): Update.
9034         * corelow.c (class core_target) <pid_to_str>: Change return type.
9035         (core_target::pid_to_str): Change return type.
9036         * target.c (normal_pid_to_str): Change return type.
9037         (default_pid_to_str): Likewise.
9038         (target_pid_to_str): Change return type.
9039         (target_translate_tls_address): Update.
9040         (target_announce_detach): Update.
9041         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9042         return type.
9043         (bsd_uthread_target::pid_to_str): Change return type.
9044         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9045         type.
9046         (bsd_kvm_target::pid_to_str): Change return type.
9047         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9048         return type.
9049         (aix_thread_target::pid_to_str): Change return type.
9050         * target.h (struct target_ops) <pid_to_str>: Change return type.
9051         (target_pid_to_str, normal_pid_to_str): Likewise.
9052         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9053         type.
9054         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9055         type.
9056         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9057         return type.
9058         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9059         type.
9060         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9061         type.
9062         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9063         return type.
9064
9065 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9066
9067         * NEWS: Mention that the new default MI version is 3.  Mention
9068         changes to the output of commands and events that deal with
9069         multi-location breakpoints.
9070         * breakpoint.c: Include "mi/mi-out.h".
9071         (print_one_breakpoint): Change output syntax if using MI version
9072         >= 3.
9073         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9074         New.
9075         (mi_multi_location_breakpoint_output_fixed): New.
9076         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9077         (mi_cmd_fix_multi_location_breakpoint_output): New.
9078         (mi_multi_location_breakpoint_output_fixed): New.
9079         * mi/mi-cmds.c (mi_cmds): Register command
9080         -fix-multi-location-breakpoint-output.
9081         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9082         interpreter "mi".
9083
9084 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9085
9086         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9087         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9088         instantiate mi_ui_out based on interpreter name.
9089         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9090         * mi/mi-main.c (mi_load_progress): Likewise.
9091
9092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9093
9094         * NEWS: Combine separate "New targets" sections for 8.3.
9095
9096 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9097
9098         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9099         (ppcfbsd_init_abi): Install gdbarch
9100         "fetch_tls_load_module_address" and "get_thread_local_address"
9101         methods.
9102
9103 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9104
9105         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9106         (riscv_fbsd_init_abi): Install gdbarch
9107         "fetch_tls_load_module_address" and "get_thread_local_address"
9108         methods.
9109
9110 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9111
9112         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9113         (i386fbsd_init_abi): Install gdbarch
9114         "fetch_tls_load_module_address" and "get_thread_local_address"
9115         methods.
9116
9117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9118
9119         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9120         (amd64fbsd_init_abi): Install gdbarch
9121         "fetch_tls_load_module_address" and "get_thread_local_address"
9122         methods.
9123
9124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9125
9126         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9127         (struct fbsd_pspace_data): New type.
9128         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9129         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9130         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9131         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9132         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9133
9134 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9135
9136         * gdbtypes.c (lookup_struct_elt): New function.
9137         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9138         * gdbtypes.h (struct struct_elt): New type.
9139         (lookup_struct_elt): New prototype.
9140
9141 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9142
9143         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9144         remove disabled code block.
9145
9146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9147
9148         * gdbarch.sh (get_thread_local_address): New method.
9149         * gdbarch.h, gdbarch.c: Regenerate.
9150         * target.c (target_translate_tls_address): Use
9151         gdbarch_get_thread_local_address if present instead of
9152         target::get_thread_local_address.
9153
9154 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9155
9156         * target.h (target::get_thread_local_address): Update comment.
9157
9158 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9159
9160         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9161         objfile->separate_debug_objfile_backlink if not NULL.
9162
9163 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9164
9165         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9166         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9167         (amd64bsd_store_inferior_registers): Likewise.
9168         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9169         Enable segment base registers.
9170         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9171         PT_GETFSBASE and PT_GETGSBASE.
9172         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9173         PT_SETGSBASE.
9174         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9175         segment base registers.
9176         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9177
9178 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9179
9180         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9181         Update calls to i386_target_description to add 'segments'
9182         parameter.
9183         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9184         add segment base registers.
9185         * arch/i386.c (i386_create_target_description): Add 'segments'
9186         parameter to enable segment base registers.
9187         * arch/i386.h (i386_create_target_description): Likewise.
9188         * features/i386/32bit-segments.xml: New file.
9189         * features/i386/32bit-segments.c: Generate.
9190         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9191         call to i386_target_description to add 'segments' parameter.
9192         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9193         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9194         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9195         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9196         if feature is present.
9197         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9198         Add 'segments' parameter to call to i386_target_description.
9199         (i386_target_description): Add 'segments' parameter to enable
9200         segment base registers.
9201         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9202         to call to i386_target_description.
9203         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9204         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9205         Define I386_NUM_REGS.
9206         (i386_target_description): Add 'segments' parameter to enable
9207         segment base registers.
9208
9209 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9210
9211         PR/24325
9212         * source-cache.c: #undef open and close, to avoid unresolved
9213         externals during linking.
9214
9215 2019-03-12  Tom Tromey  <tromey@adacore.com>
9216
9217         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9218         const.  Add initializers.
9219         (_initialize_remote): Don't initialize ptid globals.
9220
9221 2019-03-12  Pedro Alves  <palves@redhat.com>
9222
9223         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9224
9225 2019-03-12  Pedro Alves  <palves@redhat.com>
9226
9227         * cp-name-parser.y (main): Remove unused 'len' variable.
9228
9229 2019-03-12  Tom Tromey  <tromey@adacore.com>
9230
9231         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9232         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9233
9234 2019-03-12  Tom Tromey  <tromey@adacore.com>
9235
9236         * linux-nat.c (iterate_over_lwps): Update.
9237         (stop_callback): Remove parameter.
9238         (stop_wait_callback, detach_callback, resume_set_callback)
9239         (select_singlestep_lwp_callback, set_ignore_sigint)
9240         (status_callback, resumed_callback, resume_clear_callback)
9241         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9242         data parameter.
9243         (linux_nat_target::detach, linux_nat_target::resume)
9244         (linux_stop_and_wait_all_lwps, select_event_lwp)
9245         (linux_nat_filter_event, linux_nat_wait_1)
9246         (linux_nat_target::kill, linux_nat_target::stop)
9247         (linux_nat_target::stop): Update.
9248         (linux_nat_resume_callback): Change type.
9249         (resume_stopped_resumed_lwps, count_events_callback)
9250         (select_event_lwp_callback): Likewise.
9251         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9252         * arm-linux-nat.c (struct update_registers_data): Remove.
9253         (update_registers_callback): Change type.
9254         (arm_linux_insert_hw_breakpoint1): Update.
9255         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9256         parameter.
9257         (x86_linux_dr_set_addr): Update.
9258         (x86_linux_dr_set_control): Update.
9259         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9260         (iterate_over_lwps): Use gdb::function_view.
9261         * nat/aarch64-linux-hw-point.c (struct
9262         aarch64_dr_update_callback_param): Remove.
9263         (debug_reg_change_callback): Change type.
9264         (aarch64_notify_debug_reg_change): Update.
9265         * s390-linux-nat.c (s390_refresh_per_info): Update.
9266
9267 2019-03-11  Tom Tromey  <tromey@adacore.com>
9268
9269         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9270         redundant assignment to "this_cu".
9271
9272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9273
9274         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9275
9276 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9277
9278         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9279         from...
9280         (rank_one_type): ... this.
9281
9282 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9283
9284         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9285         from...
9286         (rank_one_type): ... this.
9287
9288 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9289
9290         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9291         from...
9292         (rank_one_type): ... this.
9293
9294 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9295
9296         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9297         from...
9298         (rank_one_type): ... this.
9299
9300 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9301
9302         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9303         from...
9304         (rank_one_type): ... this.
9305
9306 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9307
9308         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9309         from...
9310         (rank_one_type): ... this.
9311
9312 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9313
9314         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9315         from...
9316         (rank_one_type): ... this.
9317
9318 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9319
9320         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9321         from...
9322         (rank_one_type): ... this.
9323
9324 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9325
9326         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9327         from...
9328         (rank_one_type): ... this.
9329
9330 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9331
9332         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9333         from...
9334         (rank_one_type): ... this.
9335
9336 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9337
9338         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9339         from...
9340         (rank_one_type): ... this.
9341
9342 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9343
9344         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9345         from...
9346         (rank_one_type): ... this.
9347
9348 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9349
9350         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9351         inferior-events' shows the example events.
9352
9353 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9354
9355         Support styling on native MS-Windows console
9356
9357         PR/24315
9358         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9359         on MS-Windows if $TERM is not defined.
9360
9361         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9362
9363         * posix-hdep.c (gdb_console_fputs):
9364         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9365         functions.
9366         * ui-file.h (gdb_console_fputs): Add prototype.
9367
9368         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9369         back to fputs only if the former returns zero.
9370
9371 2019-03-07  Tom Tromey  <tom@tromey.com>
9372
9373         * symmisc.c (print_symbol_bcache_statistics): Update.
9374         (print_objfile_statistics): Update.
9375         * symfile.c (allocate_symtab): Update.
9376         * stabsread.c: Don't include bcache.h.
9377         * psymtab.h (struct psymbol_bcache): Don't declare.
9378         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9379         (psymbol_bcache_init, psymbol_bcache_free)
9380         (psymbol_bcache_get_bcache): Don't declare.
9381         * psymtab.c (struct psymbol_bcache): Remove.
9382         (psymtab_storage::psymtab_storage): Update.
9383         (psymtab_storage::~psymtab_storage): Update.
9384         (psymbol_bcache_init, psymbol_bcache_free)
9385         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9386         (add_psymbol_to_bcache): Update.
9387         (allocate_psymtab): Update.
9388         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9389         macro_cache>: No longer pointers.
9390         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9391         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9392         * macrotab.c (macro_bcache): Update.
9393         * macroexp.c: Don't include bcache.h.
9394         * gdbtypes.c (check_types_worklist): Update.
9395         (types_deeply_equal): Remove TRY/CATCH.  Update.
9396         * elfread.c (elf_symtab_read): Update.
9397         * dwarf2read.c: Don't include bcache.h.
9398         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9399         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9400         (print_bcache_statistics, bcache_memory_used): Don't declare.
9401         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9402         methods.  Rename all data members.
9403         * bcache.c (struct bcache): Move to bcache.h.
9404         (bcache::expand_hash_table): Rename from expand_hash_table.
9405         (bcache): Remove.
9406         (bcache::insert): Rename from bcache_full.
9407         (bcache::compare): Rename from bcache_compare.
9408         (bcache_xmalloc): Remove.
9409         (bcache::~bcache): Rename from bcache_xfree.
9410         (bcache::print_statistics): Rename from print_bcache_statistics.
9411         (bcache::memory_used): Rename from bcache_memory_used.
9412
9413 2019-03-07  Pedro Alves  <palves@redhat.com>
9414
9415         * infrun.c (normal_stop): Also check for
9416         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9417
9418 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9419
9420         * f-lang.c (value_from_host_double): Moved to...
9421         * value.c (value_from_host_double): ...here.
9422         * value.h (value_from_host_double): Declare.
9423         * guile/scm-math.c (vlscm_convert_typed_number): Use
9424         value_from_host_double.
9425         (vlscm_convert_number): Likewise.
9426         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9427         * python/py-value.c (convert_value_from_python): Likewise.
9428
9429 2019-03-06  Tom Tromey  <tom@tromey.com>
9430
9431         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9432
9433 2019-03-06  Tom Tromey  <tom@tromey.com>
9434
9435         * utils.h (free_current_contents): Don't declare.
9436         * utils.c (free_current_contents): Remove.
9437
9438 2019-03-06  Tom Tromey  <tom@tromey.com>
9439
9440         * top.c (quit_force): Update.
9441         * main.c (captured_command_loop): Update.
9442         * common/new-op.c (operator new): Update.
9443         * common/common-exceptions.c (struct catcher)
9444         <save_cleanup_chain>: Remove member.
9445         (exceptions_state_mc_init): Update.
9446         (exception_try_scope_entry): Return nullptr.
9447         (exception_try_scope_exit, exception_rethrow)
9448         (throw_exception_sjlj, throw_exception_cxx): Update.
9449         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9450         (all_cleanups, do_cleanups, discard_cleanups)
9451         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9452         (restore_cleanups, restore_final_cleanups): Don't declare.
9453         (do_final_cleanups): Remove parameter.
9454         * common/cleanups.c (cleanup_chain, make_cleanup)
9455         (make_cleanup_dtor, all_cleanups, do_cleanups)
9456         (discard_my_cleanups, discard_cleanups)
9457         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9458         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9459         (null_cleanup): Remove.
9460         (do_final_cleanups): Remove parameter.
9461
9462 2019-03-06  Tom Tromey  <tom@tromey.com>
9463
9464         * remote.c (remote_target::remote_parse_stop_reply): Use
9465         unique_xmalloc_ptr.
9466
9467 2019-03-06  Tom Tromey  <tom@tromey.com>
9468
9469         * stabsread.c (struct stabs_field_info): Rename from field_info.
9470         <list, fnlist>: Add initializers.
9471         <obstack>: New member.
9472         (read_member_functions, read_struct_fields, read_baseclasses):
9473         Allocate on obstack.  Don't use cleanups.
9474         (read_one_struct_field, read_member_functions, read_struct_fields)
9475         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9476         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9477         (read_struct_type): Update.
9478
9479 2019-03-06  Tom Tromey  <tom@tromey.com>
9480
9481         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9482         * common/filestuff.h (make_cleanup_close): Don't declare.
9483         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9484         Remove.
9485
9486 2019-03-06  Tom Tromey  <tom@tromey.com>
9487
9488         * solib-aix.c: Use make_scope_exit.
9489
9490 2019-03-06  Tom Tromey  <tom@tromey.com>
9491
9492         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9493         Use make_scope_exit.
9494
9495 2019-03-06  Tom Tromey  <tom@tromey.com>
9496
9497         * solib-svr4.c (disable_probes_interface): Remove parameter.
9498         (svr4_handle_solib_event): Use make_scope_exit.
9499
9500 2019-03-06  Tom Tromey  <tom@tromey.com>
9501
9502         * remote.c (struct stop_reply_deleter): Remove.
9503         (stop_reply_up): Update.
9504         (struct stop_reply): Derive from notif_event.  Don't typedef.
9505         <regcache>: Now a std::vector.
9506         (stop_reply_xfree): Remove.
9507         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9508         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9509         (remote_target::discard_pending_stop_replies): Use delete.
9510         (remote_target::remote_parse_stop_reply): Update.
9511         (remote_target::process_stop_reply): Update.
9512         * remote-notif.h (struct notif_event): Add virtual destructor.
9513         Remove "dtr" member.
9514         (struct notif_client) <alloc_event>: Return a unique_ptr.
9515         (notif_event_xfree): Don't declare.
9516         (notif_event_up): New typedef.
9517         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9518         (notif_event_xfree, do_notif_event_xfree): Remove.
9519         (remote_notif_state_xfree): Update.
9520
9521 2019-03-06  Tom Tromey  <tom@tromey.com>
9522
9523         * infrun.c (displaced_step_clear_cleanup): Now a
9524         forward_scope_exit type.
9525         (displaced_step_prepare_throw): Update.
9526         (displaced_step_fixup): Update.
9527
9528 2019-03-06  Tom Tromey  <tom@tromey.com>
9529
9530         * inferior.h (class inferior): Update comment.
9531         * gdbthread.h (class thread_info): Update comment.
9532
9533 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9534             Tom Tromey  <tom@tromey.com>
9535
9536         * stabsread.h (struct stab_section_list): Remove.
9537         (coffstab_build_psymtabs): Update.
9538         * dbxread.c (symbuf_sections): Now a std::vector.
9539         (sect_idx): New global.
9540         (fill_symbuf): Update.
9541         (coffstab_build_psymtabs): Change type of stabsects parameter.
9542         Update.
9543         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9544         std::vector.
9545         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9546         (coff_locate_sections): Update.
9547         (coff_symfile_read): Remove cleanups.  Update.
9548         (init_stringtab): Add storage parameter.
9549         (free_stringtab, free_stringtab_cleanup): Remove.
9550         (init_lineno): Add storage parameter.
9551         (free_linetab, free_linetab_cleanup): Remove.
9552
9553 2019-03-06  Pedro Alves  <palves@redhat.com>
9554
9555         * linux-fork.c (fork_info::clobber_regs): Delete.
9556         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9557         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9558         comment.  Adjust.
9559         (scoped_switch_fork_info::scoped_switch_fork_info)
9560         (checkpoint_command, linux_fork_context): Adjust
9561         fork_save_infrun_state calls.
9562
9563 2019-03-06  Pedro Alves  <palves@redhat.com>
9564
9565         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9566         (inf_has_multiple_threads): Return 'bool' and rewrite using
9567         inferior_info::threads().
9568
9569 2019-03-06  Pedro Alves  <palves@redhat.com>
9570
9571         * linux-fork.c: Include <list>.
9572         (fork_list): Now a std::list instance.
9573         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9574         (forks_exist_p, find_last_fork): Adjust.
9575         (new_fork): Delete.
9576         (one_fork_p): New.
9577         (add_fork): Adjust.
9578         (free_fork): Delete, folded into fork_info::~fork_info().
9579         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9580         Adjust.
9581         (init_fork_list): Delete.
9582         (linux_fork_killall, linux_fork_mourn_inferior)
9583         (linux_fork_detach, info_checkpoints_command): Adjust.
9584         (_initialize_linux_fork): No longer call init_fork_list.
9585
9586 2019-03-06  Pedro Alves  <palves@redhat.com>
9587
9588         * linux-fork.c (new_fork): New, split out of ...
9589         (add_fork): ... this.  Return void.  Move "first fork" special
9590         case from here, to ...
9591         (checkpoint_command): ... here.
9592         * linux-linux.h (add_fork): Return void.
9593
9594 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9595
9596         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9597
9598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9599             Chris January  <chris.january@arm.com>
9600             David Lecomber  <david.lecomber@arm.com>
9601
9602         * f-exp.y: New token, UNOP_INTRINSIC.
9603         (exp): New pattern using UNOP_INTRINSIC token.
9604         (f77_keywords): Add 'abs' keyword.
9605         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9606         (value_from_host_double): New function.
9607         (evaluate_subexp_f): Support UNOP_ABS.
9608
9609 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9610
9611         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9612         types.
9613
9614 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9615
9616         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9617         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9618         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9619
9620 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9621
9622         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9623
9624 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9625             Chris January  <chris.january@arm.com>
9626
9627         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9628         * f-exp.y: Define 'KIND' token.
9629         (exp): New pattern for KIND expressions.
9630         (ptype): Handle types with a kind extension.
9631         (direct_abs_decl): Extend to spot kind extensions.
9632         (f77_keywords): Add 'kind' to the list.
9633         (push_kind_type): New function.
9634         (convert_to_kind_type): New function.
9635         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9636         * parse.c (operator_length_standard): Likewise.
9637         * parser-defs.h (enum type_pieces): Add tp_kind.
9638         * std-operator.def: Add UNOP_KIND.
9639
9640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9641
9642         * f-exp.y (f_parse): Set yydebug.
9643
9644 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9645
9646         * f-lang.c (evaluate_subexp_f): New function.
9647         (exp_descriptor_f): New global.
9648         (f_language_defn): Use exp_descriptor_f instead of
9649         exp_descriptor_standard.
9650
9651 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9652
9653         * f-exp.y (struct token): Add comments.
9654         (dot_ops): Remove uppercase versions and the end marker.
9655         (f77_keywords): Likewise.
9656         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9657         entries in the dot_ops array are case insensitive, and use
9658         strncasecmp to compare strings.  Also some whitespace cleanup in
9659         this area.  Similar for the f77_keywords array, except entries in
9660         this list might be case sensitive.
9661
9662 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9663
9664         * f-exp.y (struct f77_boolean_val): Add comments.
9665         (boolean_values): Remove uppercase versions, and end marker.
9666         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9667         and use strncasecmp to achieve case insensitivity.  Additionally,
9668         perform whitespace cleanup around this code.
9669
9670 2019-03-06  Tom Tromey  <tromey@adacore.com>
9671
9672         * remote-sim.c (gdbsim_target_open): Use result of
9673         gdb_argv::release.
9674
9675 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9676         Dirk Schubert  <dirk.schubert@arm.com>
9677         Chris January  <chris.january@arm.com>
9678
9679         * eval.c (evaluate_subexp_standard): Call Fortran argument
9680         wrapping logic.
9681         * f-lang.c (struct value): A value which can be passed into a
9682         Fortran function call.
9683         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9684         where appropriate.
9685         (struct type): Value ready for a Fortran function call.
9686         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9687         is needed.
9688         * f-lang.h (fortran_argument_convert): Declaration.
9689         (fortran_preserve_arg_pointer): Declaration.
9690         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9691
9692 2019-03-05  Tom Tromey  <tromey@adacore.com>
9693
9694         * python/py-prettyprint.c (print_string_repr): Remove #if.
9695         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9696
9697 2019-03-05  Tom Tromey  <tromey@adacore.com>
9698
9699         * target.c (the_dummy_target): Move later.  Change type to
9700         "dummy_target".
9701         (initialize_targets): Don't initialize the_dummy_target.
9702
9703 2019-03-05  Tom Tromey  <tromey@adacore.com>
9704
9705         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9706         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9707
9708 2019-03-05  Tom Tromey  <tromey@adacore.com>
9709
9710         * windows-nat.c (windows_nat_target::attach)
9711         (windows_nat_target::detach): Don't call gdb_flush.
9712         * valprint.c (generic_val_print, val_print, val_print_string):
9713         Don't call gdb_flush.
9714         * utils.c (defaulted_query): Don't call gdb_flush.
9715         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9716         * target.c (target_announce_detach): Don't call gdb_flush.
9717         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9718         * remote.c (extended_remote_target::attach): Don't call
9719         gdb_flush.
9720         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9721         * printcmd.c (do_examine): Don't call gdb_flush.
9722         (info_display_command): Don't call gdb_flush.
9723         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9724         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9725         * memattr.c (info_mem_command): Don't call gdb_flush.
9726         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9727         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9728         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9729         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9730         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9731         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9732         (gnu_nat_target::detach): Don't call gdb_flush.
9733         * f-valprint.c (f_val_print): Don't call gdb_flush.
9734         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9735         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9736         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9737         gdb_flush.
9738         * c-valprint.c (c_val_print): Don't call gdb_flush.
9739         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9740
9741 2019-03-05  Tom Tromey  <tromey@adacore.com>
9742
9743         * varobj.c (update_dynamic_varobj_children): Update.
9744         (install_default_visualizer): Use reset, not release.
9745         * value.c (set_internalvar): Update.
9746         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9747         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9748         ATTRIBUTE_UNUSED_RESULT.
9749
9750 2019-03-05  Tom Tromey  <tromey@adacore.com>
9751
9752         * remote.c (class scoped_remote_fd) <release>: Add
9753         ATTRIBUTE_UNUSED_RESULT.
9754
9755 2019-03-05  Tom Tromey  <tromey@adacore.com>
9756
9757         * macroexp.c (struct macro_buffer) <release>: Add
9758         ATTRIBUTE_UNUSED_RESULT.
9759
9760 2019-03-05  Tom Tromey  <tromey@adacore.com>
9761
9762         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9763         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9764         ATTRIBUTE_UNUSED_RESULT.
9765
9766 2019-03-05  Tom Tromey  <tromey@adacore.com>
9767
9768         * common/scoped_fd.h (class scoped_fd) <release>: Add
9769         ATTRIBUTE_UNUSED_RESULT.
9770
9771 2019-03-05  Tom Tromey  <tromey@adacore.com>
9772
9773         * parser-defs.h (struct parser_state) <release>: Add
9774         ATTRIBUTE_UNUSED_RESULT.
9775
9776 2019-03-05  Tom Tromey  <tromey@adacore.com>
9777
9778         * utils.h (class gdb_argv) <release>: Add
9779         ATTRIBUTE_UNUSED_RESULT.
9780         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9781
9782 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9783
9784         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9785         for-loop range, to avoid compiler warnings.
9786
9787         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9788         avoid compiler warnings about unused variables.
9789
9790         * NEWS: Mention end of support for native debugging on MS-Windows
9791         before XP.
9792
9793         PR gdb/24292
9794         * common/netstuff.c:
9795         * gdbserver/gdbreplay.c
9796         * gdbserver/remote-utils.c:
9797         * ser-tcp.c:
9798         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9799         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9800         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9801         'getaddrinfo' and 'freeaddrinfo' were not available before
9802         Windows XP, and mingw.org's MinGW headers by default define
9803         _WIN32_WINNT to 0x500.
9804
9805 2019-03-01  Gary Benson <gbenson@redhat.com>
9806
9807         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9808
9809 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9810             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9811
9812         PR gdb/8527
9813         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9814         set_sigint_trap, clear_sigint_trap.
9815
9816 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9817
9818         * target.c (target_detach): Clear the regcache and the
9819         frame cache.
9820
9821 2019-02-27  Pedro Alves  <palves@redhat.com>
9822
9823         * utils.c (set_screen_size): When we cap the height/width sizes,
9824         tweak the corresponding command variable to show "unlimited":
9825
9826 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9827             Pedro Alves  <palves@redhat.com>
9828
9829         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9830         before calling rl_set_screen_size.
9831
9832 2019-02-27  Tom Tromey  <tromey@adacore.com>
9833
9834         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9835         define.
9836         * python/py-value.c: Remove Python 2.4 workaround.
9837         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9838         workaround.
9839         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9840         Python 2.4 workaround.
9841         * python/python-internal.h: Remove Python 2.4 comment.
9842         (Py_ssize_t): Don't define.
9843         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9844         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9845         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9846         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9847         * python/python.c (do_start_initialization): Remove Python 2.4
9848         workaround.
9849         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9850         (print_children): Remove Python 2.4 workaround.
9851         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9852         workaround.
9853         (CHARBUFFERPROC_NAME): Remove.
9854         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9855         Python 2.4 workaround.
9856
9857 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9858
9859         * NEWS: Note minimum Python version.
9860
9861 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9862
9863         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9864         code from these functions.  Remove corresponding ifdefs.  Use
9865         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9866         Remove gotos and target of gotos.
9867         (infpy_search_memory): Likewise.
9868
9869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9870
9871         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9872         (hppa_gdbarch_init): Don't register deleted functions with
9873         gdbarch.
9874
9875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9876
9877         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9878         (h8300_unwind_sp): Delete.
9879         (h8300_dummy_id): Delete.
9880         (h8300_gdbarch_init): Don't register deleted functions with
9881         gdbarch.
9882
9883 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9884
9885         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9886         (ft32_unwind_pc): Delete.
9887         (ft32_unwind_sp): Delete.
9888         (ft32_gdbarch_init): Don't register deleted functions with
9889         gdbarch.
9890
9891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9892
9893         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9894         (frv_unwind_pc): Delete.
9895         (frv_unwind_sp): Delete.
9896         (frv_gdbarch_init): Don't register deleted functions with
9897         gdbarch.
9898
9899 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9900
9901         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9902         (riscv_unwind_pc): Delete.
9903         (riscv_unwind_sp): Delete.
9904         (riscv_gdbarch_init): Don't register deleted functions with
9905         gdbarch.
9906
9907 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9908
9909         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9910         (csky_unwind_pc): Delete.
9911         (csky_unwind_sp): Delete.
9912         (csky_gdbarch_init): Don't register deleted functions with
9913         gdbarch.
9914
9915 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9916
9917         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9918         (cris_unwind_pc): Delete.
9919         (cris_unwind_sp): Delete.
9920         (cris_gdbarch_init): Don't register deleted functions with
9921         gdbarch.
9922
9923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9924
9925         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9926         (bfin_unwind_pc): Delete.
9927         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9928
9929 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9930
9931         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9932         (arm_unwind_pc): Delete.
9933         (arm_unwind_sp): Delete.
9934         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9935
9936 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9937
9938         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9939         (arc_unwind_pc): Delete.
9940         (arc_unwind_sp): Delete.
9941         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9942
9943 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9944
9945         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9946         (alpha_unwind_pc): Delete.
9947         (alpha_gdbarch_init): Don't register deleted functions with
9948         gdbarch.
9949
9950 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9951
9952         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9953         (aarch64_unwind_pc): Delete.
9954         (aarch64_unwind_sp): Delete.
9955         (aarch64_gdbarch_init): Don't register deleted functions with
9956         gdbarch.
9957
9958 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9959
9960         * gdbtypes.c (type_align): Don't consider static members when
9961         computing structure alignment.
9962
9963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9964
9965         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9966         return 0 for other types.
9967         * arch-utils.c (default_type_align): Always return 0.
9968         * gdbarch.h: Regenerate.
9969         * gdbarch.sh (type_align): Extend comment.
9970         * gdbtypes.c (type_align): Add additional comments, always call
9971         gdbarch_type_align before applying the default rules.
9972         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9973         generic code will then apply a suitable default.
9974         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9975         types, return 0 for other types.
9976
9977 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9978
9979         * NEWS: Create a new section for the next release branch.
9980         Rename the section of the current branch, now that it has
9981         been cut.
9982
9983 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9984
9985         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9986         * version.in: Bump version to 8.3.50.DATE-git.
9987
9988 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9989
9990         * aix-thread.c (ptid_cmp): Remove unused variable.
9991         (get_signaled_thread): Likewise.
9992         (store_regs_user_thread): Likewise.
9993         (store_regs_kernel_thread): Likewise.
9994         (fetch_regs_kernel_thread): Remove shadowed variable.
9995
9996 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9997
9998         * features/riscv/32bit-cpu.xml: Add register numbers.
9999         * features/riscv/32bit-fpu.c: Regenerate.
10000         * features/riscv/32bit-fpu.xml: Add register numbers.
10001         * features/riscv/64bit-cpu.xml: Add register numbers.
10002         * features/riscv/64bit-fpu.c: Regenerate.
10003         * features/riscv/64bit-fpu.xml: Add register numbers.
10004
10005 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10006
10007         * NEWS: Mention two argument form of gdb.Value constructor.
10008         * python/py-value.c (convert_buffer_and_type_to_value): New
10009         function.
10010         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10011         Add support for handling an optional second argument.  Call
10012         convert_buffer_and_type_to_value as appropriate.
10013         * python/python-internal.h (Py_buffer_deleter): New struct.
10014         (Py_buffer_up): New typedef.
10015
10016 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10017
10018         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10019         instead of releasing ownership.
10020
10021 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10022
10023         * dwarf2read.c (open_and_init_dwp_file): Call
10024         elf_numsections instead of bfd_count_sections to initialize
10025         dwp_file->num_sections.
10026
10027 2019-02-25  Tom Tromey  <tromey@adacore.com>
10028
10029         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10030
10031 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10032
10033         * gcore.in: Add '--readnever' option when invoking GDB.
10034
10035 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10036
10037         * MAINTAINERS: Update my email address.
10038
10039 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10040
10041         * build-id.c (build_id_to_debug_bfd_1): New function.
10042         (build_id_to_debug_bfd): Look for separate debug file in
10043         sysroot.
10044
10045 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10046
10047         * gdbarch.sh: Update the copyright year range that is placed into
10048         generated files.
10049
10050 2019-02-22  Keith Seitz  <keiths@redhat.com>
10051
10052         PR symtab/23853
10053         * linespec.c (create_sals_line_offset): Search for the default
10054         symtab's filename instead of its fullname.
10055
10056 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10057
10058         * NEWS: Update style defaults.
10059
10060 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10061
10062         * main.c (captured_main_1): Disable styling in batch mode.
10063
10064 2019-02-20  Tom Tromey  <tom@tromey.com>
10065
10066         * symtab.c (symtab_symbol_info): Fix typos.
10067
10068 2019-02-20  Tom Tromey  <tromey@adacore.com>
10069
10070         * findcmd.c (_initialize_mem_search): Use upper case for
10071         metasyntactic variables.
10072
10073 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10074
10075         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10076         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10077
10078 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10079
10080         * top.h (source_file_name): Change to std::string.
10081         * top.c (source_file_name): Likewise.
10082         (command_line_input): Adjust.
10083         * cli/cli-script.c (script_from_file): Adjust.
10084
10085 2019-02-19  Tom Tromey  <tromey@adacore.com>
10086
10087         * ravenscar-thread.c
10088         (ravenscar_thread_target::update_thread_list): Don't call
10089         ada_build_task_list.
10090         * ada-lang.h (ada_build_task_list): Don't declare.
10091         * ada-tasks.c (struct ada_tasks_inferior_data)
10092         <task_list_valid_p>: Now bool.
10093         (read_known_tasks, ada_task_list_changed)
10094         (ada_tasks_invalidate_inferior_data): Update.
10095         (read_known_tasks_array): Return bool.
10096         (read_known_tasks_list): Likewise.
10097         (read_known_tasks): Return void.
10098         (ada_build_task_list): Now static.
10099
10100 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10101
10102         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10103         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10104
10105 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10106
10107         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10108         variant for ada_tasks_pspace_data_handle and
10109         ada_tasks_inferior_data_handle.
10110         (ada_tasks_pspace_data_cleanup): New function.
10111         (ada_tasks_inferior_data_cleanup): New function.
10112
10113 2019-02-17  Tom Tromey  <tom@tromey.com>
10114
10115         * macrotab.h (macro_source_fullname): Return a std::string.
10116         * macrotab.c (macro_include, check_for_redefinition)
10117         (macro_undef, macro_lookup_definition, foreach_macro)
10118         (foreach_macro_in_scope): Update.
10119         (macro_source_fullname): Return a std::string.
10120         * macrocmd.c (show_pp_source_pos): Update.
10121
10122 2019-02-17  Tom Tromey  <tom@tromey.com>
10123
10124         * macrocmd.c (show_pp_source_pos): Style the file names.
10125
10126 2019-02-17  Tom Tromey  <tom@tromey.com>
10127
10128         PR tui/24197:
10129         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10130
10131 2019-02-17  Tom Tromey  <tom@tromey.com>
10132
10133         * ada-lang.c (user_select_syms): Use filtered printing.
10134         * utils.c (wrap_style): New global.
10135         (desired_style): Remove.
10136         (emit_style_escape): Add stream parameter.
10137         (set_output_style, reset_terminal_style, prompt_for_continue):
10138         Update.
10139         (flush_wrap_buffer): Only flush gdb_stdout.
10140         (wrap_here): Set wrap_style.
10141         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10142         treat escape sequences as a character.  Change when wrap buffer is
10143         flushed.
10144         (fputs_styled): Do not set the output style when the default is
10145         requested.
10146         * ui-style.h (struct ui_file_style) <is_default>: New method.
10147         * source.c (print_source_lines_base): Emit escape sequences in one
10148         piece.
10149
10150 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10151
10152         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10153         integers and enumeration types.
10154
10155 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10156
10157         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10158         instead of lookup_symbol_in_language
10159         (do_exact_match): New function.
10160         (ada_get_symbol_name_matcher): Return do_exact_match when
10161         doing a verbatim match.
10162
10163 2019-02-15  Tom Tromey  <tromey@adacore.com>
10164
10165         * ravenscar-thread.c (ravenscar_thread_target::resume)
10166         (ravenscar_thread_target::wait): Special case wildcard requests.
10167
10168 2019-02-15  Tom Tromey  <tromey@adacore.com>
10169
10170         * ravenscar-thread.c (base_ptid): Remove.
10171         (struct ravenscar_thread_target) <close>: New method.
10172         <m_base_ptid>: New member.
10173         <update_inferior_ptid, active_task, task_is_currently_active,
10174         runtime_initialized>: Declare methods.
10175         <ravenscar_thread_target>: Add constructor.
10176         (ravenscar_thread_target::task_is_currently_active)
10177         (ravenscar_thread_target::update_inferior_ptid)
10178         (ravenscar_runtime_initialized): Rename.  Now methods.
10179         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10180         (ravenscar_thread_target::update_thread_list): Update.
10181         (ravenscar_thread_target::active_task): Now method.
10182         (ravenscar_thread_target::store_registers)
10183         (ravenscar_thread_target::prepare_to_store)
10184         (ravenscar_thread_target::prepare_to_store)
10185         (ravenscar_thread_target::mourn_inferior): Update.
10186         (ravenscar_inferior_created): Use "new" to create target.
10187         (ravenscar_thread_target::get_ada_task_ptid): Update.
10188         (_initialize_ravenscar): Don't initialize base_ptid.
10189         (ravenscar_ops): Remove global.
10190
10191 2019-02-15  Tom Tromey  <tromey@adacore.com>
10192
10193         * target.h (push_target): Declare new overload.
10194         * target.c (push_target): New overload, taking an rvalue reference.
10195         * remote.c (remote_target::open_1): Use push_target overload.
10196         * corelow.c (core_target_open): Use push_target overload.
10197
10198 2019-02-15  Tom Tromey  <tromey@adacore.com>
10199
10200         * ravenscar-thread.c (is_ravenscar_task)
10201         (ravenscar_task_is_currently_active): Return bool.
10202         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10203         (_initialize_ravenscar): Remove "(void)".
10204         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10205         Return bool.
10206
10207 2019-02-15  Tom Tromey  <tromey@adacore.com>
10208
10209         * ravenscar-thread.c (ravenscar_runtime_initializer)
10210         (has_ravenscar_runtime, get_running_thread_id)
10211         (ravenscar_thread_target::resume): Fix indentation.
10212
10213 2019-02-15  Tom Tromey  <tromey@adacore.com>
10214
10215         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10216         from ravenscar_arch_ops.
10217         (sparc_ravenscar_ops::fetch_registers)
10218         (sparc_ravenscar_ops::store_registers): Now methods.
10219         (sparc_ravenscar_prepare_to_store): Remove.
10220         (sparc_ravenscar_ops): Redefine.
10221         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10222         methods and destructor.  Remove members.
10223         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10224         (ravenscar_thread_target::store_registers)
10225         (ravenscar_thread_target::prepare_to_store): Update.
10226         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10227         Remove.
10228         (struct ppc_ravenscar_powerpc_ops): Derive from
10229         ravenscar_arch_ops.
10230         (ppc_ravenscar_powerpc_ops::fetch_registers)
10231         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10232         (ppc_ravenscar_powerpc_ops): Redefine.
10233         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10234         (ppc_ravenscar_e500_ops::fetch_registers)
10235         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10236         (ppc_ravenscar_e500_ops): Redefine.
10237         * aarch64-ravenscar-thread.c
10238         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10239         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10240         (aarch64_ravenscar_fetch_registers)
10241         (aarch64_ravenscar_store_registers): Now methods.
10242         (aarch64_ravenscar_ops): Redefine.
10243
10244 2019-02-15  Tom Tromey  <tromey@adacore.com>
10245
10246         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10247         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10248         (ravenscar_thread_target::stopped_by_watchpoint)
10249         (ravenscar_thread_target::stopped_data_address)
10250         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10251
10252 2019-02-15  Tom Tromey  <tromey@adacore.com>
10253
10254         * ravenscar-thread.c: Fix some typos.
10255
10256 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10257             Tom Tromey  <tromey@adacore.com>
10258
10259         * ada-lang.c (ada_exception_sal): Change addr_string to a
10260         std::string.
10261         (create_ada_exception_catchpoint): Update.
10262
10263 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10264             Tom Tromey  <tromey@adacore.com>
10265
10266         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10267         (bp_location_ops): Remove.
10268         (base_breakpoint_allocate_location): Update.
10269         (free_bp_location): Update.
10270         * ada-lang.c (class ada_catchpoint_location)
10271         <ada_catchpoint_location>: Remove ops parameter.
10272         (ada_catchpoint_location_dtor): Remove.
10273         (ada_catchpoint_location_ops): Remove.
10274         (allocate_location_exception): Update.
10275         * breakpoint.h (struct bp_location_ops): Remove.
10276         (class bp_location) <bp_location>: Remove bp_location_ops
10277         parameter.
10278         <~bp_location>: Add destructor.
10279         <ops>: Remove.
10280
10281 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10282             Pedro Alves  <palves@redhat.com>
10283
10284         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10285         'PATH_MAX'.
10286
10287 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10288             Samuel Thibault  <samuel.thibault@gnu.org>
10289             Thomas Schwinge  <thomas@codesourcery.com>
10290
10291         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10292         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10293
10294 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10295
10296         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10297         (check_empty): Use "const char *".
10298
10299         * gnu-nat.c (gnu_nat_target::detach): Instead of
10300         'detach_inferior (pid)' call
10301         'detach_inferior (find_inferior_pid (pid))'.
10302
10303         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10304         'nat/fork-inferior.o'.
10305         * gnu-nat.c: #include "nat/fork-inferior.h".
10306
10307         * gnu-nat.c (gnu_nat_target::detach): Instead of
10308         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10309         * gnu-nat.h: #include "inf-child.h".
10310         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10311         'i386_gnu_nat_target::fetch_registers'.
10312         (gnu_store_registers): Rename/move to
10313         'i386_gnu_nat_target::store_registers'.
10314
10315         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10316         * gnu-nat.h (mach_thread_info): New function.
10317         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10318
10319         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10320
10321 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10322
10323         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10324
10325 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10326
10327         * windows-nat.c (windows_add_thread): Add new parameter
10328         "main_thread_p" with default value set to false.  Update
10329         function documentation as well as all callers.
10330         (windows_delete_thread): Likewise.
10331         (fake_create_process): Update call to windows_add_thread.
10332         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10333         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10334         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10335         call to windows_delete_thread.
10336
10337 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10338
10339         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10340
10341 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10342
10343         * symfile.c (find_separate_debug_file): Use canonical path of
10344         sysroot with child_path instead of gdb_sysroot if it is valid.
10345
10346 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10347
10348         * symfile.c (find_separate_debug_file): Use child_path to
10349         determine if an object file is under a sysroot.
10350
10351 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10352
10353         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10354         unittests/child-path-selftests.c.
10355         * common/pathstuff.c (child_path): New function.
10356         * common/pathstuff.h (child_path): New prototype.
10357         * unittests/child-path-selftests.c: New file.
10358
10359 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10360
10361         * symfile.c (find_separate_debug_file): Look for separate debug
10362         files in debug directories under the sysroot.
10363
10364 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10365
10366         * symtab.h (struct minimal_symbol data_p): New const method.
10367         (struct minimal_symbol text_p): Likewise.
10368         * symtab.c (output_source_filename): Use file name style
10369         to print file name.
10370         (print_symbol_info): Likewise.
10371         (print_msymbol_info): Use address style to print addresses.
10372         Use function name style to print executable text symbols.
10373         (expand_symtab_containing_pc): Use data_p.
10374         (find_pc_sect_compunit_symtab): Likewise.
10375
10376 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10377
10378         * breakpoint.c (describe_other_breakpoints): Use address style
10379         to print addresses.
10380         (say_where): Likewise.
10381
10382 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10383
10384         * ada-typeprint.c (print_func_type): Print function name
10385         style to print function name.
10386         * c-typeprint.c (c_print_type_1): Likewise.
10387
10388 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10389
10390         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10391         for execve.
10392
10393 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10394
10395         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10396         type_stack.
10397
10398 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10399
10400         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10401         TYPE_CODE_REF types.
10402
10403 2019-02-08  Jim Wilson  <jimw@sifive.com>
10404
10405         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10406         (riscv_linux_fregset): New.
10407         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10408
10409 2019-02-07  Tom Tromey  <tom@tromey.com>
10410
10411         * thread.c (thread_cancel_execution_command): Update.
10412         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10413         methods.
10414         (struct thread_fsm_ops): Remove.
10415         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10416         (thread_fsm_should_stop, thread_fsm_return_value)
10417         (thread_fsm_set_finished, thread_fsm_finished_p)
10418         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10419         Don't declare.
10420         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10421         * infrun.c (clear_proceed_status_thread)
10422         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10423         (print_stop_event): Update.
10424         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10425         Add constructor.
10426         (step_command_fsm_ops): Remove.
10427         (new_step_command_fsm): Remove.
10428         (step_1): Update.
10429         (step_command_fsm::should_stop): Rename from
10430         step_command_fsm_should_stop.
10431         (step_command_fsm::clean_up): Rename from
10432         step_command_fsm_clean_up.
10433         (step_command_fsm::do_async_reply_reason): Rename from
10434         step_command_fsm_async_reply_reason.
10435         (struct until_next_fsm): Inherit from thread_fsm.  Add
10436         constructor.
10437         (until_next_fsm_ops): Remove.
10438         (new_until_next_fsm): Remove.
10439         (until_next_fsm::should_stop): Rename from
10440         until_next_fsm_should_stop.
10441         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10442         (until_next_fsm::do_async_reply_reason): Rename from
10443         until_next_fsm_async_reply_reason.
10444         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10445         constructor.  Change type of breakpoint.
10446         (finish_command_fsm_ops): Remove.
10447         (new_finish_command_fsm): Remove.
10448         (finish_command_fsm::should_stop): Rename from
10449         finish_command_fsm_should_stop.
10450         (finish_command_fsm::clean_up): Rename from
10451         finish_command_fsm_clean_up.
10452         (finish_command_fsm::return_value): Rename from
10453         finish_command_fsm_return_value.
10454         (finish_command_fsm::do_async_reply_reason): Rename from
10455         finish_command_fsm_async_reply_reason.
10456         (finish_command): Update.
10457         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10458         Add constructor.
10459         (call_thread_fsm_ops): Remove.
10460         (call_thread_fsm::call_thread_fsm): Rename from
10461         new_call_thread_fsm.
10462         (call_thread_fsm::should_stop): Rename from
10463         call_thread_fsm_should_stop.
10464         (call_thread_fsm::should_notify_stop): Rename from
10465         call_thread_fsm_should_notify_stop.
10466         (run_inferior_call, call_function_by_hand_dummy): Update.
10467         * cli/cli-interp.c (should_print_stop_to_console): Update.
10468         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10469         Add constructor.  Change type of location_breakpoint,
10470         caller_breakpoint.
10471         (until_break_fsm_ops): Remove.
10472         (new_until_break_fsm): Remove.
10473         (until_break_fsm::should_stop): Rename from
10474         until_break_fsm_should_stop.
10475         (until_break_fsm::clean_up): Rename from
10476         until_break_fsm_clean_up.
10477         (until_break_fsm::do_async_reply_reason): Rename from
10478         until_break_fsm_async_reply_reason.
10479         (until_break_command): Update.
10480         * thread-fsm.c: Remove.
10481         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10482
10483 2019-02-07  Tom Tromey  <tom@tromey.com>
10484
10485         * yy-remap.h: Add include guard.
10486         * xtensa-tdep.h: Add include guard.
10487         * xcoffread.h: Rename include guard.
10488         * varobj-iter.h: Add include guard.
10489         * tui/tui.h: Rename include guard.
10490         * tui/tui-winsource.h: Rename include guard.
10491         * tui/tui-wingeneral.h: Rename include guard.
10492         * tui/tui-windata.h: Rename include guard.
10493         * tui/tui-win.h: Rename include guard.
10494         * tui/tui-stack.h: Rename include guard.
10495         * tui/tui-source.h: Rename include guard.
10496         * tui/tui-regs.h: Rename include guard.
10497         * tui/tui-out.h: Rename include guard.
10498         * tui/tui-layout.h: Rename include guard.
10499         * tui/tui-io.h: Rename include guard.
10500         * tui/tui-hooks.h: Rename include guard.
10501         * tui/tui-file.h: Rename include guard.
10502         * tui/tui-disasm.h: Rename include guard.
10503         * tui/tui-data.h: Rename include guard.
10504         * tui/tui-command.h: Rename include guard.
10505         * tic6x-tdep.h: Add include guard.
10506         * target/waitstatus.h: Rename include guard.
10507         * target/wait.h: Rename include guard.
10508         * target/target.h: Rename include guard.
10509         * target/resume.h: Rename include guard.
10510         * target-float.h: Rename include guard.
10511         * stabsread.h: Add include guard.
10512         * rs6000-tdep.h: Add include guard.
10513         * riscv-fbsd-tdep.h: Add include guard.
10514         * regformats/regdef.h: Rename include guard.
10515         * record.h: Rename include guard.
10516         * python/python.h: Rename include guard.
10517         * python/python-internal.h: Rename include guard.
10518         * python/py-stopevent.h: Rename include guard.
10519         * python/py-ref.h: Rename include guard.
10520         * python/py-record.h: Rename include guard.
10521         * python/py-record-full.h: Rename include guard.
10522         * python/py-record-btrace.h: Rename include guard.
10523         * python/py-instruction.h: Rename include guard.
10524         * python/py-events.h: Rename include guard.
10525         * python/py-event.h: Rename include guard.
10526         * procfs.h: Add include guard.
10527         * proc-utils.h: Add include guard.
10528         * p-lang.h: Add include guard.
10529         * or1k-tdep.h: Rename include guard.
10530         * observable.h: Rename include guard.
10531         * nto-tdep.h: Rename include guard.
10532         * nat/x86-linux.h: Rename include guard.
10533         * nat/x86-linux-dregs.h: Rename include guard.
10534         * nat/x86-gcc-cpuid.h: Add include guard.
10535         * nat/x86-dregs.h: Rename include guard.
10536         * nat/x86-cpuid.h: Rename include guard.
10537         * nat/ppc-linux.h: Rename include guard.
10538         * nat/mips-linux-watch.h: Rename include guard.
10539         * nat/linux-waitpid.h: Rename include guard.
10540         * nat/linux-ptrace.h: Rename include guard.
10541         * nat/linux-procfs.h: Rename include guard.
10542         * nat/linux-osdata.h: Rename include guard.
10543         * nat/linux-nat.h: Rename include guard.
10544         * nat/linux-namespaces.h: Rename include guard.
10545         * nat/linux-btrace.h: Rename include guard.
10546         * nat/glibc_thread_db.h: Rename include guard.
10547         * nat/gdb_thread_db.h: Rename include guard.
10548         * nat/gdb_ptrace.h: Rename include guard.
10549         * nat/fork-inferior.h: Rename include guard.
10550         * nat/amd64-linux-siginfo.h: Rename include guard.
10551         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10552         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10553         * nat/aarch64-linux.h: Rename include guard.
10554         * nat/aarch64-linux-hw-point.h: Rename include guard.
10555         * mn10300-tdep.h: Add include guard.
10556         * mips-linux-tdep.h: Add include guard.
10557         * mi/mi-parse.h: Rename include guard.
10558         * mi/mi-out.h: Rename include guard.
10559         * mi/mi-main.h: Rename include guard.
10560         * mi/mi-interp.h: Rename include guard.
10561         * mi/mi-getopt.h: Rename include guard.
10562         * mi/mi-console.h: Rename include guard.
10563         * mi/mi-common.h: Rename include guard.
10564         * mi/mi-cmds.h: Rename include guard.
10565         * mi/mi-cmd-break.h: Rename include guard.
10566         * m2-lang.h: Add include guard.
10567         * location.h: Rename include guard.
10568         * linux-record.h: Rename include guard.
10569         * linux-nat.h: Add include guard.
10570         * linux-fork.h: Add include guard.
10571         * i386-darwin-tdep.h: Rename include guard.
10572         * hppa-linux-offsets.h: Add include guard.
10573         * guile/guile.h: Rename include guard.
10574         * guile/guile-internal.h: Rename include guard.
10575         * gnu-nat.h: Rename include guard.
10576         * gdb-stabs.h: Rename include guard.
10577         * frv-tdep.h: Add include guard.
10578         * f-lang.h: Add include guard.
10579         * event-loop.h: Add include guard.
10580         * darwin-nat.h: Rename include guard.
10581         * cp-abi.h: Rename include guard.
10582         * config/sparc/nm-sol2.h: Rename include guard.
10583         * config/nm-nto.h: Rename include guard.
10584         * config/nm-linux.h: Add include guard.
10585         * config/i386/nm-i386gnu.h: Rename include guard.
10586         * config/djgpp/nl_types.h: Rename include guard.
10587         * config/djgpp/langinfo.h: Rename include guard.
10588         * compile/gcc-cp-plugin.h: Add include guard.
10589         * compile/gcc-c-plugin.h: Add include guard.
10590         * compile/compile.h: Rename include guard.
10591         * compile/compile-object-run.h: Rename include guard.
10592         * compile/compile-object-load.h: Rename include guard.
10593         * compile/compile-internal.h: Rename include guard.
10594         * compile/compile-cplus.h: Rename include guard.
10595         * compile/compile-c.h: Rename include guard.
10596         * common/xml-utils.h: Rename include guard.
10597         * common/x86-xstate.h: Rename include guard.
10598         * common/version.h: Rename include guard.
10599         * common/vec.h: Rename include guard.
10600         * common/tdesc.h: Rename include guard.
10601         * common/selftest.h: Rename include guard.
10602         * common/scoped_restore.h: Rename include guard.
10603         * common/scoped_mmap.h: Rename include guard.
10604         * common/scoped_fd.h: Rename include guard.
10605         * common/safe-iterator.h: Rename include guard.
10606         * common/run-time-clock.h: Rename include guard.
10607         * common/refcounted-object.h: Rename include guard.
10608         * common/queue.h: Rename include guard.
10609         * common/ptid.h: Rename include guard.
10610         * common/print-utils.h: Rename include guard.
10611         * common/preprocessor.h: Rename include guard.
10612         * common/pathstuff.h: Rename include guard.
10613         * common/observable.h: Rename include guard.
10614         * common/netstuff.h: Rename include guard.
10615         * common/job-control.h: Rename include guard.
10616         * common/host-defs.h: Rename include guard.
10617         * common/gdb_wait.h: Rename include guard.
10618         * common/gdb_vecs.h: Rename include guard.
10619         * common/gdb_unlinker.h: Rename include guard.
10620         * common/gdb_unique_ptr.h: Rename include guard.
10621         * common/gdb_tilde_expand.h: Rename include guard.
10622         * common/gdb_sys_time.h: Rename include guard.
10623         * common/gdb_string_view.h: Rename include guard.
10624         * common/gdb_splay_tree.h: Rename include guard.
10625         * common/gdb_setjmp.h: Rename include guard.
10626         * common/gdb_ref_ptr.h: Rename include guard.
10627         * common/gdb_optional.h: Rename include guard.
10628         * common/gdb_locale.h: Rename include guard.
10629         * common/gdb_assert.h: Rename include guard.
10630         * common/filtered-iterator.h: Rename include guard.
10631         * common/filestuff.h: Rename include guard.
10632         * common/fileio.h: Rename include guard.
10633         * common/environ.h: Rename include guard.
10634         * common/common-utils.h: Rename include guard.
10635         * common/common-types.h: Rename include guard.
10636         * common/common-regcache.h: Rename include guard.
10637         * common/common-inferior.h: Rename include guard.
10638         * common/common-gdbthread.h: Rename include guard.
10639         * common/common-exceptions.h: Rename include guard.
10640         * common/common-defs.h: Rename include guard.
10641         * common/common-debug.h: Rename include guard.
10642         * common/cleanups.h: Rename include guard.
10643         * common/buffer.h: Rename include guard.
10644         * common/btrace-common.h: Rename include guard.
10645         * common/break-common.h: Rename include guard.
10646         * cli/cli-utils.h: Rename include guard.
10647         * cli/cli-style.h: Rename include guard.
10648         * cli/cli-setshow.h: Rename include guard.
10649         * cli/cli-script.h: Rename include guard.
10650         * cli/cli-interp.h: Rename include guard.
10651         * cli/cli-decode.h: Rename include guard.
10652         * cli/cli-cmds.h: Rename include guard.
10653         * charset-list.h: Add include guard.
10654         * buildsym-legacy.h: Rename include guard.
10655         * bfin-tdep.h: Add include guard.
10656         * ax.h: Rename include guard.
10657         * arm-linux-tdep.h: Add include guard.
10658         * arm-fbsd-tdep.h: Add include guard.
10659         * arch/xtensa.h: Rename include guard.
10660         * arch/tic6x.h: Add include guard.
10661         * arch/i386.h: Add include guard.
10662         * arch/arm.h: Rename include guard.
10663         * arch/arm-linux.h: Rename include guard.
10664         * arch/arm-get-next-pcs.h: Rename include guard.
10665         * arch/amd64.h: Add include guard.
10666         * arch/aarch64-insn.h: Rename include guard.
10667         * arch-utils.h: Rename include guard.
10668         * annotate.h: Add include guard.
10669         * amd64-darwin-tdep.h: Rename include guard.
10670         * aarch64-linux-tdep.h: Add include guard.
10671         * aarch64-fbsd-tdep.h: Add include guard.
10672         * aarch32-linux-nat.h: Add include guard.
10673
10674 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10675
10676         * macrotab.c (macro_define_internal): New function that
10677         factorizes macro_define_object_internal and macro_define_function
10678         code.
10679         (macro_define_object_internal): Use macro_define_internal.
10680         (macro_define_function): Likewise.
10681
10682 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10683
10684         * macrocmd.c (extract_identifier): Return
10685         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10686         callers.
10687
10688 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10689
10690         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10691
10692 2019-02-05  Tom Tromey  <tom@tromey.com>
10693
10694         * target.c (target_stack::unpush): Move assertion earlier.
10695
10696 2019-01-30  Tom Tromey  <tom@tromey.com>
10697
10698         PR python/23615:
10699         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10700         (gdbpy_parse_and_eval): Likewise.
10701         * python/python-internal.h (gdbpy_allow_threads): New class.
10702
10703 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10704
10705         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10706         (aarch64_fbsd_fpregmap): Move earlier.
10707         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10708         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10709         instead of individual calls to trad_frame_set_reg_addr.
10710         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10711         earlier.
10712         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10713         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10714         instead of individual calls to trad_frame_set_reg_addr.
10715
10716 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10717
10718         * CONTRIBUTE: Replace contribution list with wiki link.
10719
10720 2019-01-25  Tom Tromey  <tom@tromey.com>
10721
10722         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10723
10724 2019-01-25  Tom Tromey  <tom@tromey.com>
10725
10726         * xtensa-linux-nat.c: Fix common/ includes.
10727         * xml-support.h: Fix common/ includes.
10728         * xml-support.c: Fix common/ includes.
10729         * x86-linux-nat.c: Fix common/ includes.
10730         * windows-nat.c: Fix common/ includes.
10731         * varobj.h: Fix common/ includes.
10732         * varobj.c: Fix common/ includes.
10733         * value.c: Fix common/ includes.
10734         * valops.c: Fix common/ includes.
10735         * utils.c: Fix common/ includes.
10736         * unittests/xml-utils-selftests.c: Fix common/ includes.
10737         * unittests/utils-selftests.c: Fix common/ includes.
10738         * unittests/unpack-selftests.c: Fix common/ includes.
10739         * unittests/tracepoint-selftests.c: Fix common/ includes.
10740         * unittests/style-selftests.c: Fix common/ includes.
10741         * unittests/string_view-selftests.c: Fix common/ includes.
10742         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10743         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10744         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10745         * unittests/rsp-low-selftests.c: Fix common/ includes.
10746         * unittests/parse-connection-spec-selftests.c: Fix common/
10747         includes.
10748         * unittests/optional-selftests.c: Fix common/ includes.
10749         * unittests/offset-type-selftests.c: Fix common/ includes.
10750         * unittests/observable-selftests.c: Fix common/ includes.
10751         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10752         * unittests/memrange-selftests.c: Fix common/ includes.
10753         * unittests/memory-map-selftests.c: Fix common/ includes.
10754         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10755         * unittests/function-view-selftests.c: Fix common/ includes.
10756         * unittests/environ-selftests.c: Fix common/ includes.
10757         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10758         * unittests/common-utils-selftests.c: Fix common/ includes.
10759         * unittests/cli-utils-selftests.c: Fix common/ includes.
10760         * unittests/array-view-selftests.c: Fix common/ includes.
10761         * ui-file.c: Fix common/ includes.
10762         * tui/tui-io.c: Fix common/ includes.
10763         * tracepoint.h: Fix common/ includes.
10764         * tracepoint.c: Fix common/ includes.
10765         * tracefile-tfile.c: Fix common/ includes.
10766         * top.h: Fix common/ includes.
10767         * top.c: Fix common/ includes.
10768         * thread.c: Fix common/ includes.
10769         * target/waitstatus.h: Fix common/ includes.
10770         * target/waitstatus.c: Fix common/ includes.
10771         * target.h: Fix common/ includes.
10772         * target.c: Fix common/ includes.
10773         * target-memory.c: Fix common/ includes.
10774         * target-descriptions.c: Fix common/ includes.
10775         * symtab.h: Fix common/ includes.
10776         * symfile.c: Fix common/ includes.
10777         * stap-probe.c: Fix common/ includes.
10778         * spu-linux-nat.c: Fix common/ includes.
10779         * sparc-nat.c: Fix common/ includes.
10780         * source.c: Fix common/ includes.
10781         * solib.c: Fix common/ includes.
10782         * solib-target.c: Fix common/ includes.
10783         * ser-unix.c: Fix common/ includes.
10784         * ser-tcp.c: Fix common/ includes.
10785         * ser-pipe.c: Fix common/ includes.
10786         * ser-base.c: Fix common/ includes.
10787         * selftest-arch.c: Fix common/ includes.
10788         * s12z-tdep.c: Fix common/ includes.
10789         * rust-exp.y: Fix common/ includes.
10790         * rs6000-aix-tdep.c: Fix common/ includes.
10791         * riscv-tdep.c: Fix common/ includes.
10792         * remote.c: Fix common/ includes.
10793         * remote-notif.h: Fix common/ includes.
10794         * remote-fileio.h: Fix common/ includes.
10795         * remote-fileio.c: Fix common/ includes.
10796         * regcache.h: Fix common/ includes.
10797         * regcache.c: Fix common/ includes.
10798         * record-btrace.c: Fix common/ includes.
10799         * python/python.c: Fix common/ includes.
10800         * python/py-type.c: Fix common/ includes.
10801         * python/py-inferior.c: Fix common/ includes.
10802         * progspace.h: Fix common/ includes.
10803         * producer.c: Fix common/ includes.
10804         * procfs.c: Fix common/ includes.
10805         * proc-api.c: Fix common/ includes.
10806         * printcmd.c: Fix common/ includes.
10807         * ppc-linux-nat.c: Fix common/ includes.
10808         * parser-defs.h: Fix common/ includes.
10809         * osdata.c: Fix common/ includes.
10810         * obsd-nat.c: Fix common/ includes.
10811         * nat/x86-linux.c: Fix common/ includes.
10812         * nat/x86-linux-dregs.c: Fix common/ includes.
10813         * nat/x86-dregs.h: Fix common/ includes.
10814         * nat/x86-dregs.c: Fix common/ includes.
10815         * nat/ppc-linux.c: Fix common/ includes.
10816         * nat/mips-linux-watch.h: Fix common/ includes.
10817         * nat/mips-linux-watch.c: Fix common/ includes.
10818         * nat/linux-waitpid.c: Fix common/ includes.
10819         * nat/linux-ptrace.h: Fix common/ includes.
10820         * nat/linux-ptrace.c: Fix common/ includes.
10821         * nat/linux-procfs.c: Fix common/ includes.
10822         * nat/linux-personality.c: Fix common/ includes.
10823         * nat/linux-osdata.c: Fix common/ includes.
10824         * nat/linux-namespaces.c: Fix common/ includes.
10825         * nat/linux-btrace.h: Fix common/ includes.
10826         * nat/linux-btrace.c: Fix common/ includes.
10827         * nat/fork-inferior.c: Fix common/ includes.
10828         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10829         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10830         * nat/aarch64-linux.c: Fix common/ includes.
10831         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10832         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10833         * namespace.h: Fix common/ includes.
10834         * mips-linux-tdep.c: Fix common/ includes.
10835         * minsyms.c: Fix common/ includes.
10836         * mi/mi-parse.h: Fix common/ includes.
10837         * mi/mi-main.c: Fix common/ includes.
10838         * mi/mi-cmd-env.c: Fix common/ includes.
10839         * memrange.h: Fix common/ includes.
10840         * memattr.c: Fix common/ includes.
10841         * maint.h: Fix common/ includes.
10842         * maint.c: Fix common/ includes.
10843         * main.c: Fix common/ includes.
10844         * machoread.c: Fix common/ includes.
10845         * location.c: Fix common/ includes.
10846         * linux-thread-db.c: Fix common/ includes.
10847         * linux-nat.c: Fix common/ includes.
10848         * linux-fork.c: Fix common/ includes.
10849         * inline-frame.c: Fix common/ includes.
10850         * infrun.c: Fix common/ includes.
10851         * inflow.c: Fix common/ includes.
10852         * inferior.h: Fix common/ includes.
10853         * inferior.c: Fix common/ includes.
10854         * infcmd.c: Fix common/ includes.
10855         * inf-ptrace.c: Fix common/ includes.
10856         * inf-child.c: Fix common/ includes.
10857         * ia64-linux-nat.c: Fix common/ includes.
10858         * i387-tdep.c: Fix common/ includes.
10859         * i386-tdep.c: Fix common/ includes.
10860         * i386-linux-tdep.c: Fix common/ includes.
10861         * i386-linux-nat.c: Fix common/ includes.
10862         * i386-go32-tdep.c: Fix common/ includes.
10863         * i386-fbsd-tdep.c: Fix common/ includes.
10864         * i386-fbsd-nat.c: Fix common/ includes.
10865         * guile/scm-type.c: Fix common/ includes.
10866         * guile/guile.c: Fix common/ includes.
10867         * go32-nat.c: Fix common/ includes.
10868         * gnu-nat.c: Fix common/ includes.
10869         * gdbthread.h: Fix common/ includes.
10870         * gdbarch-selftests.c: Fix common/ includes.
10871         * gdb_usleep.c: Fix common/ includes.
10872         * gdb_select.h: Fix common/ includes.
10873         * gdb_bfd.c: Fix common/ includes.
10874         * gcore.c: Fix common/ includes.
10875         * fork-child.c: Fix common/ includes.
10876         * findvar.c: Fix common/ includes.
10877         * fbsd-nat.c: Fix common/ includes.
10878         * event-top.c: Fix common/ includes.
10879         * event-loop.c: Fix common/ includes.
10880         * dwarf2read.c: Fix common/ includes.
10881         * dwarf2loc.c: Fix common/ includes.
10882         * dwarf2-frame.c: Fix common/ includes.
10883         * dwarf-index-cache.c: Fix common/ includes.
10884         * dtrace-probe.c: Fix common/ includes.
10885         * disasm-selftests.c: Fix common/ includes.
10886         * defs.h: Fix common/ includes.
10887         * csky-tdep.c: Fix common/ includes.
10888         * cp-valprint.c: Fix common/ includes.
10889         * cp-support.h: Fix common/ includes.
10890         * cp-support.c: Fix common/ includes.
10891         * corelow.c: Fix common/ includes.
10892         * completer.h: Fix common/ includes.
10893         * completer.c: Fix common/ includes.
10894         * compile/compile.c: Fix common/ includes.
10895         * compile/compile-loc2c.c: Fix common/ includes.
10896         * compile/compile-cplus-types.c: Fix common/ includes.
10897         * compile/compile-cplus-symbols.c: Fix common/ includes.
10898         * command.h: Fix common/ includes.
10899         * cli/cli-dump.c: Fix common/ includes.
10900         * cli/cli-cmds.c: Fix common/ includes.
10901         * charset.c: Fix common/ includes.
10902         * build-id.c: Fix common/ includes.
10903         * btrace.h: Fix common/ includes.
10904         * btrace.c: Fix common/ includes.
10905         * breakpoint.h: Fix common/ includes.
10906         * breakpoint.c: Fix common/ includes.
10907         * ax.h:
10908         (enum agent_op): Fix common/ includes.
10909         * ax-general.c (struct aop_map): Fix common/ includes.
10910         * ax-gdb.c: Fix common/ includes.
10911         * auxv.c: Fix common/ includes.
10912         * auto-load.c: Fix common/ includes.
10913         * arm-tdep.c: Fix common/ includes.
10914         * arch/riscv.c: Fix common/ includes.
10915         * arch/ppc-linux-common.c: Fix common/ includes.
10916         * arch/i386.c: Fix common/ includes.
10917         * arch/arm.c: Fix common/ includes.
10918         * arch/arm-linux.c: Fix common/ includes.
10919         * arch/arm-get-next-pcs.c: Fix common/ includes.
10920         * arch/amd64.c: Fix common/ includes.
10921         * arch/aarch64.c: Fix common/ includes.
10922         * arch/aarch64-insn.c: Fix common/ includes.
10923         * arch-utils.c: Fix common/ includes.
10924         * amd64-windows-tdep.c: Fix common/ includes.
10925         * amd64-tdep.c: Fix common/ includes.
10926         * amd64-sol2-tdep.c: Fix common/ includes.
10927         * amd64-obsd-tdep.c: Fix common/ includes.
10928         * amd64-nbsd-tdep.c: Fix common/ includes.
10929         * amd64-linux-tdep.c: Fix common/ includes.
10930         * amd64-linux-nat.c: Fix common/ includes.
10931         * amd64-fbsd-tdep.c: Fix common/ includes.
10932         * amd64-fbsd-nat.c: Fix common/ includes.
10933         * amd64-dicos-tdep.c: Fix common/ includes.
10934         * amd64-darwin-tdep.c: Fix common/ includes.
10935         * agent.c: Fix common/ includes.
10936         * ada-lang.h: Fix common/ includes.
10937         * ada-lang.c: Fix common/ includes.
10938         * aarch64-tdep.c: Fix common/ includes.
10939
10940 2019-01-25  Tom Tromey  <tom@tromey.com>
10941
10942         * common/create-version.sh: Use common/version.h.
10943
10944 2019-01-24  Pedro Alves  <palves@redhat.com>
10945
10946         * infrun.c (signal_stop, signal_print, signal_program)
10947         (signal_catch, signal_pass): Now arrays instead of pointers.
10948         (update_signals_program_target, do_target_resume)
10949         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10950         * linux-nat.c (linux_nat_target::pass_signals)
10951         (linux_nat_target::create_inferior, linux_nat_target::attach):
10952         Adjust.
10953         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10954         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10955         * procfs.c (procfs_target::pass_signals): Adjust.
10956         * record-full.c (record_full_target::resume): Adjust.
10957         * remote.c (remote_target::pass_signals)
10958         (remote_target::program_signals): Adjust.
10959         * target-debug.h (target_debug_print_signals): Now takes a
10960         gdb::array_view as parameter.  Adjust.
10961         * target.h (target_ops) <pass_signals, program_signals>: Replace
10962         pointer and length parameters with gdb::array_view.
10963         (target_pass_signals, target_program_signals): Likewise.
10964         * target-delegates.c: Regenerate.
10965
10966 2019-01-24  Pedro Alves  <palves@redhat.com>
10967
10968         * common/forward-scope-exit.h
10969         (forward_scope_exit::forward_scope_exit): Pass arguments to
10970         m_bind_function directly, instead of creating a std::bind and
10971         copying that.
10972
10973 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10974
10975         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10976         for static members.
10977         (pass_in_v_vfp_candidate): Likewise.
10978
10979 2019-01-23  Tom Tromey  <tom@tromey.com>
10980             Pedro Alves  <palves@redhat.com>
10981
10982         * regcache.c (class regcache_invalidator): Remove.
10983         (regcache::raw_write): Use make_scope_exit.
10984
10985 2019-01-23  Tom Tromey  <tom@tromey.com>
10986
10987         * ui-out.h (class ui_out_emit_type): Update comment.
10988
10989 2019-01-23  Tom Tromey  <tom@tromey.com>
10990
10991         * infrun.c (fetch_inferior_event): Update comment.
10992
10993 2019-01-23  Tom Tromey  <tom@tromey.com>
10994             Pedro Alves  <palves@redhat.com>
10995
10996         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10997         parameter.
10998         (fetch_inferior_event): Use SCOPE_EXIT.
10999
11000
11001 2019-01-23  Tom Tromey  <tom@tromey.com>
11002             Pedro Alves  <palves@redhat.com>
11003
11004         * infrun.c (disable_thread_events): Delete.
11005         (stop_all_threads): Use SCOPE_EXIT.
11006
11007 2019-01-23  Tom Tromey  <tom@tromey.com>
11008             Pedro Alves  <palves@redhat.com>
11009
11010         * symfile.c: Include forward-scope-exit.h.
11011         (clear_symtab_users_cleanup): Replace forward declaration with
11012         a FORWARD_SCOPE_EXIT.
11013         (syms_from_objfile_1): Use the forward_scope_exit and
11014         gdb::optional instead of cleanup_function.
11015         (reread_symbols): Use the forward_scope_exit instead of
11016         cleanup_function.
11017         (clear_symtab_users_cleanup): Remove function.
11018
11019 2019-01-23  Tom Tromey  <tom@tromey.com>
11020             Pedro Alves  <palves@redhat.com>
11021
11022         * linux-nat.c: Include scope-exit.h.
11023         (cleanup_target_stop): Remove.
11024         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11025         SCOPE_EXIT.
11026
11027 2019-01-23  Tom Tromey  <tom@tromey.com>
11028             Pedro Alves  <palves@redhat.com>
11029
11030         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11031         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11032
11033 2019-01-23  Tom Tromey  <tom@tromey.com>
11034             Andrew Burgess  <andrew.burgess@embecosm.com>
11035             Pedro Alves  <palves@redhat.com>
11036
11037         * infrun.c (fetch_inferior_event): Use scope_exit.
11038         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11039         * top.c (execute_command): Use scope_exit.
11040         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11041         * utils.c (do_bpstat_clear_actions_cleanup)
11042         (make_bpstat_clear_actions_cleanup): Remove.
11043
11044 2019-01-23  Tom Tromey  <tom@tromey.com>
11045             Pedro Alves  <palves@redhat.com>
11046
11047         * infrun.c: Include "common/scope-exit.h"
11048         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11049         (wait_for_inferior): Use SCOPE_EXIT.
11050         (fetch_inferior_event): Use scope_exit.
11051
11052 2019-01-23  Tom Tromey  <tom@tromey.com>
11053             Pedro Alves  <palves@redhat.com>
11054
11055         * breakpoint.c (create_breakpoint): Remove cleanup.
11056
11057 2019-01-23  Tom Tromey  <tom@tromey.com>
11058             Andrew Burgess  <andrew.burgess@embecosm.com>
11059             Pedro Alves  <palves@redhat.com>
11060
11061 2019-01-23  Pedro Alves  <palves@redhat.com>
11062
11063         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11064
11065 2019-01-23  Pedro Alves  <palves@redhat.com>
11066             Andrew Burgess  <andrew.burgess@embecosm.com>
11067
11068         * gdbthread.h: Include "common/forward-scope-exit.h".
11069         (scoped_finish_thread_state): Redefine custom class in terms of
11070         forward_scope_exit.
11071
11072 2019-01-23  Pedro Alves  <palves@redhat.com>
11073             Andrew Burgess  <andrew.burgess@embecosm.com>
11074
11075         * common/forward-scope-exit.h: New file.
11076
11077 2019-01-23  Pedro Alves  <palves@redhat.com>
11078             Andrew Burgess  <andrew.burgess@embecosm.com>
11079             Tom Tromey  <tom@tromey.com>
11080
11081         * common/scope-exit.h: New file.
11082
11083 2019-01-23  Pedro Alves  <palves@redhat.com>
11084
11085         * common/preprocessor.h (ESC): Rename to ...
11086         (ESC_PARENS): ... this.
11087         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11088         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11089
11090 2019-01-23  Tom Tromey  <tom@tromey.com>
11091
11092         * language.h (class scoped_switch_to_sym_language_if_auto):
11093         Initialize m_lang in both cases.
11094
11095 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11096
11097         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11098         with XCNEW.
11099
11100 2019-01-22  Tom Tromey  <tom@tromey.com>
11101
11102         * corelow.c: Do not include sys/file.h.
11103
11104 2019-01-22  Tom Tromey  <tom@tromey.com>
11105
11106         * tui/tui-wingeneral.h: Include gdb_curses.h.
11107
11108 2019-01-22  Tom Tromey  <tom@tromey.com>
11109
11110         * source-cache.h (class source_cache) <get_source_lines,
11111         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11112
11113 2019-01-22  Tom Tromey  <tom@tromey.com>
11114
11115         * remote-fileio.h (struct remote_target): Declare.
11116
11117 2019-01-22  Tom Tromey  <tom@tromey.com>
11118
11119         * python/py-arch.c: Do not include py-ref.h.
11120         * python/py-bpevent.c: Do not include py-ref.h.
11121         * python/py-cmd.c: Do not include py-ref.h.
11122         * python/py-continueevent.c: Do not include py-ref.h.
11123         * python/py-event.h: Do not include py-ref.h.
11124         * python/py-evtregistry.c: Do not include py-ref.h.
11125         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11126         * python/py-frame.c: Do not include py-ref.h.
11127         * python/py-framefilter.c: Do not include py-ref.h.
11128         * python/py-function.c: Do not include py-ref.h.
11129         * python/py-infevents.c: Do not include py-ref.h.
11130         * python/py-linetable.c: Do not include py-ref.h.
11131         * python/py-objfile.c: Do not include py-ref.h.
11132         * python/py-param.c: Do not include py-ref.h.
11133         * python/py-prettyprint.c: Do not include py-ref.h.
11134         * python/py-progspace.c: Do not include py-ref.h.
11135         * python/py-symbol.c: Do not include py-ref.h.
11136         * python/py-symtab.c: Do not include py-ref.h.
11137         * python/py-type.c: Do not include py-ref.h.
11138         * python/py-unwind.c: Do not include py-ref.h.
11139         * python/py-utils.c: Do not include py-ref.h.
11140         * python/py-value.c: Do not include py-ref.h.
11141         * python/py-varobj.c: Do not include py-ref.h.
11142         * python/py-xmethods.c: Do not include py-ref.h.
11143         * python/python.c: Do not include py-ref.h.
11144         * varobj.c: Do not include py-ref.h.
11145
11146 2019-01-22  Tom Tromey  <tom@tromey.com>
11147
11148         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11149         keyword for bcache.
11150
11151 2019-01-22  Tom Tromey  <tom@tromey.com>
11152
11153         * compile/compile-cplus-types.c: Remove a comment by #include.
11154
11155 2019-01-22  Tom Tromey  <tom@tromey.com>
11156
11157         * compile/gcc-c-plugin.h: Include compile-internal.h.
11158
11159 2019-01-22  Tom Tromey  <tom@tromey.com>
11160
11161         * stabsread.c (EXTERN): Do not define.
11162         (symnum, next_symbol_text_func, processing_gcc_compilation)
11163         (within_function, global_sym_chain, global_stabs)
11164         (previous_stab_code, this_object_header_files)
11165         (n_this_object_header_files)
11166         (n_allocated_this_object_header_files): Define.
11167         * stabsread.h (EXTERN): Never define.  Use "extern".
11168
11169 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11170
11171         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11172         history_value.
11173
11174 2019-01-21  Tom Tromey  <tom@tromey.com>
11175
11176         * ui-out.c: Fix includes.
11177         * tui/tui-source.c: Fix includes.
11178         * target.c: Fix includes.
11179         * remote.c: Fix includes.
11180         * regcache.c: Fix includes.
11181         * python/py-block.c: Fix includes.
11182         * printcmd.c: Fix includes.
11183         * or1k-tdep.c: Fix includes.
11184         * mi/mi-main.c: Fix includes.
11185         * m32r-tdep.c: Fix includes.
11186         * csky-tdep.c: Fix includes.
11187         * compile/compile-cplus-types.c: Fix includes.
11188         * cli/cli-interp.c: Fix includes.
11189
11190 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11191
11192         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11193         for padding.
11194
11195 2019-01-16  Tom Tromey  <tom@tromey.com>
11196
11197         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11198         earlier.
11199         (struct objfile) <msymbols_range>: Move from top level.
11200         <msymbols>: New method.
11201         (class objfile_msymbols): Remove.
11202         * symtab.c (default_collect_symbol_completion_matches_break_on):
11203         Update.
11204         * symmisc.c (dump_msymbols): Update.
11205         * stabsread.c (scan_file_globals): Update.
11206         * objc-lang.c (info_selectors_command, info_classes_command)
11207         (find_methods): Update.
11208         * minsyms.c (find_solib_trampoline_target): Update.
11209         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11210         * coffread.c (coff_symfile_read): Update.
11211         * ada-lang.c (ada_lookup_simple_minsym)
11212         (ada_collect_symbol_completion_matches): Update.
11213
11214 2019-01-16  Tom Tromey  <tom@tromey.com>
11215
11216         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11217         type.  Remove no-argument constructor.
11218         <iterator::operator++>: Simplify.
11219         <begin>: Update.
11220         <end>: Use minimal_symbol_count.
11221
11222 2019-01-16  Tom Tromey  <tom@tromey.com>
11223
11224         * objfiles.h (struct objfile) <psymtabs>: New method.
11225         (class objfile_psymtabs): Remove.
11226         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11227         typedef.
11228         <range>: New method.
11229         (require_partial_symbols): Change return type.
11230         * psymtab.c (require_partial_symbols)
11231         (psym_expand_symtabs_matching): Update.
11232         * mdebugread.c (parse_partial_symbols): Update.
11233         * dbxread.c (dbx_end_psymtab): Update.
11234
11235 2019-01-15  Tom Tromey  <tom@tromey.com>
11236
11237         * symtab.c (lookup_objfile_from_block)
11238         (lookup_symbol_in_objfile_symtabs)
11239         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11240         (find_line_symtab, info_sources_command)
11241         (default_collect_symbol_completion_matches_break_on)
11242         (make_source_files_completion_list): Update.
11243         * symmisc.c (print_objfile_statistics, dump_objfile)
11244         (maintenance_print_symbols, maintenance_info_symtabs)
11245         (maintenance_check_symtabs, maintenance_info_line_tables):
11246         Update.
11247         * source.c (select_source_symtab)
11248         (forget_cached_source_info_for_objfile): Update.
11249         * objfiles.h (class objfile_compunits): Remove.
11250         (struct objfile) <compunits_range>: New typedef.
11251         (compunits): New method.
11252         * objfiles.c (objfile_relocate1): Update.
11253         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11254         * maint.c (count_symtabs_and_blocks): Update.
11255         * linespec.c (iterate_over_all_matching_symtabs): Update.
11256         * cp-support.c (add_symbol_overload_list_qualified): Update.
11257         * coffread.c (coff_symtab_read): Update.
11258         * ada-lang.c (add_nonlocal_symbols)
11259         (ada_collect_symbol_completion_matches)
11260         (ada_add_global_exceptions): Update.
11261
11262 2019-01-15  Tom Tromey  <tom@tromey.com>
11263
11264         * progspace.h (program_space) <objfiles_safe_range>: New
11265         typedef.
11266         <objfiles_safe>: New method.
11267         * objfiles.h (class all_objfiles_safe): Remove.
11268         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11269         * jit.c (jit_inferior_exit_hook): Update.
11270
11271 2019-01-17  Tom Tromey  <tom@tromey.com>
11272
11273         * progspace.h (program_space) <objfiles_range>: New typedef.
11274         <objfiles>: New method.
11275         <objfiles_head>: Rename from objfiles.
11276         (object_files): Update.
11277         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11278         * guile/scm-pretty-print.c
11279         (ppscm_find_pretty_printer_from_objfiles): Update.
11280         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11281         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11282         Update.
11283         * python/py-progspace.c (pspy_get_objfiles): Update.
11284         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11285         Update.
11286         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11287         (objfpy_lookup_objfile_by_build_id): Update.
11288         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11289         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11290         Update.
11291         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11292         (expand_symtab_containing_pc, lookup_objfile_from_block)
11293         (lookup_static_symbol, basic_lookup_transparent_type)
11294         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11295         (find_line_symtab, info_sources_command)
11296         (default_collect_symbol_completion_matches_break_on)
11297         (make_source_files_completion_list, find_main_name): Update.
11298         * symmisc.c (print_symbol_bcache_statistics)
11299         (print_objfile_statistics, maintenance_print_symbols)
11300         (maintenance_print_msymbols, maintenance_print_objfiles)
11301         (maintenance_info_symtabs, maintenance_check_symtabs)
11302         (maintenance_expand_symtabs, maintenance_info_line_tables):
11303         Update.
11304         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11305         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11306         (map_overlay_command, unmap_overlay_command)
11307         (simple_overlay_update, expand_symtabs_matching)
11308         (map_symbol_filenames): Update.
11309         * symfile-debug.c (set_debug_symfile): Update.
11310         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11311         Update.
11312         * source.c (select_source_symtab, forget_cached_source_info):
11313         Update.
11314         * solib.c (solib_read_symbols): Update.
11315         * solib-spu.c (append_ocl_sos): Update.
11316         * psymtab.c (maintenance_print_psymbols)
11317         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11318         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11319         * printcmd.c (info_symbol_command): Update.
11320         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11321         Update.
11322         * objfiles.h (class all_objfiles): Remove.
11323         * objfiles.c (have_partial_symbols, have_full_symbols)
11324         (have_minimal_symbols, qsort_cmp, update_section_map)
11325         (shared_objfile_contains_address_p)
11326         (default_iterate_over_objfiles_in_search_order): Update.
11327         * objc-lang.c (info_selectors_command, info_classes_command)
11328         (find_methods): Update.
11329         * minsyms.c (find_solib_trampoline_target): Update.
11330         * maint.c (maintenance_info_sections)
11331         (maintenance_translate_address, count_symtabs_and_blocks):
11332         Update.
11333         * main.c (captured_main_1): Update.
11334         * linux-thread-db.c (try_thread_db_load_from_pdir)
11335         (has_libpthread): Update.
11336         * linespec.c (iterate_over_all_matching_symtabs)
11337         (search_minsyms_for_name): Update.
11338         * jit.c (jit_find_objf_with_entry_addr): Update.
11339         * hppa-tdep.c (find_unwind_entry)
11340         (hppa_lookup_stub_minimal_symbol): Update.
11341         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11342         Update.
11343         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11344         (elf_gnu_ifunc_resolve_by_got): Update.
11345         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11346         * dwarf-index-write.c (save_gdb_index_command): Update.
11347         * cp-support.c (add_symbol_overload_list_qualified): Update.
11348         * breakpoint.c (create_overlay_event_breakpoint)
11349         (create_longjmp_master_breakpoint)
11350         (create_std_terminate_master_breakpoint)
11351         (create_exception_master_breakpoint): Update.
11352         * blockframe.c (find_pc_partial_function): Update.
11353         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11354         (ada_collect_symbol_completion_matches)
11355         (ada_add_global_exceptions): Update.
11356
11357 2019-01-17  Tom Tromey  <tom@tromey.com>
11358
11359         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11360         declare VEC.
11361         (solib_target_parse_libraries): Change return type.
11362         (library_list_start_segment, library_list_start_section)
11363         (library_list_end_library, library_list_start_library); Update.
11364         (solib_target_free_library_list): Remove.
11365         (solib_target_parse_libraries): Remove cleanup.  Change return
11366         type.
11367         (solib_target_current_sos): Update.
11368
11369 2019-01-17  Tom Tromey  <tromey@bapiya>
11370
11371         * valprint.c: Replace "the the" with "the".
11372         * symtab.c: Replace "the the" with "the".
11373         * solib.c: Replace "the the" with "the".
11374         * solib-dsbt.c: Replace "the the" with "the".
11375         * linespec.c: Replace "the the" with "the".
11376         * dwarf2loc.h: Replace "the the" with "the".
11377         * amd64-windows-tdep.c: Replace "the the" with "the".
11378         * aarch64-tdep.c: Replace "the the" with "the".
11379
11380 2019-01-16  Keith Seitz  <keiths@redhat.com>
11381
11382         PR gdb/23773
11383         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11384         <builder>: Rename to ..
11385         <m_builder>: ... this and make private.
11386         (dwarf2_cu::get_builder): New method.  Change all users of
11387         `builder' to use this method.
11388         (dwarf2_start_symtab): Move to ...
11389         (dwarf2_cu::start_symtab): ... here.  Update all callers
11390         (setup_type_unit_groups): Move to ...
11391         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11392         callers.
11393         (dwarf2_cu::reset_builder): New method.
11394         (process_full_compunit, process_full_type_unit): Use
11395         dwarf2_cu::reset_builder.
11396         (follow_die_offset): Record the ancestor CU if it is different
11397         from the followed DIE's CU.
11398         (follow_die_sig_1): Likewise.
11399
11400 2019-01-15  Tom Tromey  <tom@tromey.com>
11401
11402         * remote.c (class remote_state) <buf>: Now a char_vector.
11403         <buf_size>: Remove.
11404         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11405         parameter.
11406         (remote_target::getpkt_or_notif_sane_1)
11407         (remote_target::getpkt_sane)
11408         (remote_target::getpkt_or_notif_sane): Likewise.
11409         (class remote_target) <putpkt>: New overload.
11410         (remote_target::read_frame): Change type of "buf_p".  Remove
11411         sizeof_p parameter.
11412         (packet_ok): New overload.
11413         (packet_check_result): New overload.
11414         Update all uses.
11415
11416 2019-01-14  Tom Tromey  <tom@tromey.com>
11417
11418         * remote-notif.c (handle_notification, remote_notif_ack)
11419         (remote_notif_parse): Make "buf" const.
11420         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11421         const.
11422         (remote_notif_parse, remote_notif_ack, handle_notification):
11423         Likewise.
11424         * remote.c (remote_notif_stop_parse): Make "buf" const.
11425         (remote_target::remote_parse_stop_reply): Make "buf" const.
11426         (remote_notif_stop_ack): Make "buf" const.
11427
11428 2019-01-14  Tom Tromey  <tom@tromey.com>
11429
11430         * remote.c (remote_console_output): Make parameter const.
11431
11432 2019-01-14  Tom Tromey  <tom@tromey.com>
11433
11434         * target-debug.h (target_debug_print_signals): Constify.
11435         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11436         * procfs.c (procfs_target::pass_signals): Update.
11437         * linux-nat.c (linux_nat_target::pass_signals): Update.
11438         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11439         * target-delegates.c: Rebuild.
11440         * remote.c (remote_target::program_signals): Update.
11441         (remote_target::pass_signals): Update.
11442         * target.c (target_pass_signals): Constify argument.
11443         (target_program_signals): Likewise.
11444         * target.h (struct target_ops) <pass_signals, program_signals>:
11445         Constify argument.
11446         (target_pass_signals, target_program_signals): Constify argument.
11447
11448 2019-01-14  Tom Tromey  <tom@tromey.com>
11449
11450         PR tui/28819:
11451         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11452
11453 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11454
11455         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11456         field.
11457         * rs6000-tdep.c: Include reggroups.h.
11458         (IS_V_ALIAS_PSEUDOREG): Define.
11459         (rs6000_register_name): Return names for the "vX" aliases.
11460         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11461         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11462         aliases.  Call default_register_reggroup_p for all other
11463         pseudo-registers.
11464         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11465         New functions.
11466         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11467         Handle "vX" aliases.
11468         (v_alias_pseudo_register_collect): New function.
11469         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11470         (rs6000_gdbarch_init): Initialize "vX" aliases as
11471         pseudo-registers.  Restore registration of
11472         rs6000_pseudo_register_reggroup_p with
11473         set_tdesc_pseudo_register_reggroup_p.
11474
11475 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11476
11477         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11478         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11479         set_gdbarch_num_pseudo_regs.
11480
11481 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11482
11483         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11484         Remove arg prefixname, add do_set and do_show.
11485         Add member functions set_list and show_list.
11486         * cli/cli-style.c (class cli_style_option): Update accordingly.
11487         (style_set_list): Move to file scope.
11488         (style_show_list): Likewise.
11489         (set_style): Call help_list.
11490         (show_style): Call cmd_show_list.
11491         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11492         Update to use the new macro.
11493
11494 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11495
11496         * ada-lang.c (_initialize_ada_language): Expand the help text
11497         for the "catch exception" command.
11498
11499 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11500
11501         * symtab.c (matching_obj_sections): Initialize obj,
11502         declare it closer to its usage.
11503
11504 2019-01-10  Tom Tromey  <tom@tromey.com>
11505
11506         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11507         (basic_inf_threads_range): Remove.
11508         (inf_threads_range, inf_non_exited_threads_range)
11509         (safe_inf_threads_range): Use next_adapter.
11510
11511 2019-01-10  Keith Seitz  <keiths@redhat.com>
11512
11513         PR gdb/23712
11514         PR symtab/23010
11515         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11516         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11517
11518 2019-01-10  Keith Seitz  <keiths@redhat.com>
11519
11520         PR gdb/23712
11521         PR symtab/23010
11522         * dictionary.c (pending_to_vector): Remove.
11523         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11524         Remove _1 suffix, replacing functions of the same name.  Update
11525         all callers.
11526         (dict_create_hashed, dict_create_hashed_expandable)
11527         (dict_create_linear, dict_create_linear_expandable, dict_free)
11528         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11529         Make functions static.
11530
11531 2019-01-10  Keith Seitz  <keiths@redhat.com>
11532
11533         PR gdb/23712
11534         PR symtab/23010
11535         * dictionary.h (struct dictionary): Replace declaration with
11536         multidictionary.
11537         (dict_create_hashed, dict_create_hashed_expandable)
11538         (dict_create_linear, dict_create_linear_expandable)
11539         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11540         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11541         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11542         taking multidictionary argument.
11543         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11544         * block.h (struct block) <dict>: Change to multidictionary
11545         and rename `multidict'.
11546         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11547         symmisc.c: Update all dictionary references to multidictionary.
11548
11549 2019-01-10  Keith Seitz  <keiths@redhat.com>
11550
11551         PR gdb/23712
11552         PR symtab/23010
11553         * dictionary.c: Include unordered_map.
11554         (pending_to_vector): New function.
11555         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11556         Rewrite the non-"_1" functions to take vector instead
11557         of linked list.
11558         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11559         "new" _1 versions of the same name.
11560         (multidictionary): Define.
11561         (std::hash<enum language): New definition.
11562         (collate_pending_symbols_by_language, mdict_create_hashed)
11563         (mdict_create_hashed_expandable, mdict_create_linear)
11564         (mdict_create_linear_expandable, mdict_free)
11565         (find_language_dictionary, create_new_language_dictionary)
11566         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11567         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11568         (mdict_size, mdict_empty): New functions.
11569         * dictionary.h (mdict_iterator): Define.
11570
11571 2019-01-10  Pedro Alves  <palves@redhat.com>
11572
11573         * breakpoint.c (read_uploaded_action)
11574         (create_tracepoint_from_upload): Adjust to use
11575         gdb::unique_xmalloc_ptr.
11576         * ctf.c (ctf_write_uploaded_tp):
11577         (SET_ARRAY_FIELD): Use emplace_back.
11578         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11579         * tracefile-tfile.c (tfile_write_uploaded_tp):
11580         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11581         gdb::unique_xmalloc_ptr.
11582         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11583         at_string, cond_string, cmd_strings>: Replace char pointers
11584         with gdb::unique_xmalloc_ptr.
11585
11586 2019-01-10  Pedro Alves  <palves@redhat.com>
11587
11588         * solib-target.c (library_list_start_library): Don't xstrdup name.
11589
11590 2019-01-10  Pedro Alves  <palves@redhat.com>
11591
11592         * mdebugread.c (parse_partial_symbols): Use
11593         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11594
11595 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11596
11597         * linux-fork.c (scoped_switch_fork_info)
11598         <~scoped_switch_fork_info>: Fix incorrect variable name.
11599
11600 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11601
11602         * linux-fork.c (scoped_switch_fork_info)
11603         <scoped_switch_fork_info>: Make explicit.
11604         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11605
11606 2019-01-10  Tom Tromey  <tom@tromey.com>
11607
11608         * objfiles.h (objfile::reset_psymtabs): Update.
11609         * objfiles.c (objfile::objfile): Update.
11610         * psymtab.h (psymtab_storage::obstack): Update.
11611         (psymtab_storage::m_obstack): Use gdb::optional.
11612         (class psymtab_storage): Update comment.  Remove objfile
11613         parameter.
11614         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11615
11616 2019-01-10  Tom Tromey  <tom@tromey.com>
11617
11618         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11619         <free_psymtabs>: Now private.
11620         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11621         (allocate_psymtab): Use new method.
11622
11623 2019-01-10  Tom Tromey  <tom@tromey.com>
11624
11625         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11626         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11627         * mdebugread.c (parse_partial_symbols): Use
11628         allocate_dependencies.
11629         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11630         allocate_dependencies.
11631         (process_psymtab_comp_unit_reader)
11632         (build_type_psymtab_dependencies): Likewise.
11633         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11634
11635 2019-01-10  Tom Tromey  <tom@tromey.com>
11636
11637         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11638         PSYMBOL_SET_LANGUAGE.
11639         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11640
11641 2019-01-10  Tom Tromey  <tom@tromey.com>
11642
11643         * psymtab.h (psymtab_storage::obstack): New method.
11644         <m_obstack>: Rename from obstack; now private.
11645         * psymtab.c (psymtab_storage): Update.
11646         * dwarf2read.c (create_addrmap_from_index)
11647         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11648         Update.
11649
11650 2019-01-10  Tom Tromey  <tom@tromey.com>
11651
11652         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11653         * objfiles.h (objfile::reset_psymtabs): New method.
11654
11655 2019-01-10  Tom Tromey  <tom@tromey.com>
11656
11657         * symmisc.c (print_symbol_bcache_statistics): Update.
11658         (print_objfile_statistics): Update.
11659         * symfile.c (reread_symbols): Update.
11660         * psymtab.h (class psymtab_storage): New.
11661         * psymtab.c (psymtab_storage): New constructor.
11662         (~psymtab_storage): New destructor.
11663         (require_partial_symbols): Update.
11664         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11665         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11666         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11667         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11668         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11669         (start_psymtab_common, end_psymtab_common)
11670         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11671         (allocate_psymtab): Update.
11672         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11673         Update.
11674         (dump_psymtab_addrmap, maintenance_print_psymbols)
11675         (maintenance_check_psymtabs): Update.
11676         (class objfile_psymtabs): Move to objfiles.h.
11677         * psympriv.h (discard_psymtab): Now inline.
11678         (psymtab_discarder::psymtab_discarder): Update.
11679         (psymtab_discarder::~psymtab_discarder): Update.
11680         (ALL_OBJFILE_PSYMTABS): Rewrite.
11681         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11682         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11683         Remove fields.
11684         <partial_symtabs>: New field.
11685         (class objfile_psymtabs): Move from psymtab.h.  Update.
11686         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11687         psymbol_cache.
11688         (objfile::~objfile): Don't destroy psymbol_cache.
11689         * mdebugread.c (parse_partial_symbols): Update.
11690         * dwarf2read.c (create_addrmap_from_index)
11691         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11692         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11693         (add_partial_subprogram, dwarf2_ranges_read): Update.
11694         * dwarf-index-write.c (write_address_map)
11695         (write_one_signatured_type, recursively_write_psymbols)
11696         (class debug_names, class debug_names, write_psymtabs_to_index):
11697         Update.
11698
11699 2019-01-10  Tom Tromey  <tom@tromey.com>
11700
11701         * symtab.h (SYMBOL_SET_NAMES): Update.
11702         (symbol_set_names): Update.
11703         (MSYMBOL_SET_NAMES): Update.
11704         * symtab.c (symbol_set_names): Change argument to be an
11705         objfile_per_bfd_storage.
11706         * psymtab.c (add_psymbol_to_bcache): Update.
11707         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11708
11709 2019-01-10  Tom Tromey  <tom@tromey.com>
11710
11711         * symtab.c (create_demangled_names_hash): Change argument to be an
11712         objfile_per_bfd_storage.
11713         (symbol_set_names): Update.
11714
11715 2019-01-10  Tom Tromey  <tom@tromey.com>
11716
11717         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11718         init_psymbol_list.
11719         * psymtab.c (init_psymbol_list): Do nothing if already called.
11720         * psympriv.h (init_psymbol_list): Add comment.
11721         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11722         init_psymbol_list.
11723         * dbxread.c (dbx_symfile_read): Unconditionally call
11724         init_psymbol_list.
11725
11726 2019-01-10  Tom Tromey  <tom@tromey.com>
11727
11728         * xcoffread.c (scan_xcoff_symtab): Update.
11729         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11730         "where".
11731         * mdebugread.c (parse_partial_symbols)
11732         (handle_psymbol_enumerators): Update.
11733         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11734         * dbxread.c (read_dbx_symtab): Update.
11735         * psympriv.h (psymbol_placement): New enum.
11736         (add_psymbol_to_list): Update.
11737
11738 2019-01-10  Tom Tromey  <tom@tromey.com>
11739
11740         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11741         static_psymbols parameters.
11742         (scan_xcoff_symtab): Update.
11743         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11744         static_psymbols parameters.
11745         * psympriv.h (start_psymtab_common): Update.
11746         * mdebugread.c (parse_partial_symbols): Update.
11747         * dwarf2read.c (create_partial_symtab): Update.
11748         * dbxread.c (read_dbx_symtab): Update.
11749         (start_psymtab): Remove global_psymbols and static_psymbols
11750         parameters.
11751
11752 2019-01-10  Tom Tromey  <tom@tromey.com>
11753
11754         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11755         * psymtab.c (allocate_psymtab): Add comment.
11756         * psympriv.h (allocate_psymtab): Add comment.
11757         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11758         initializations.
11759         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11760
11761 2019-01-10  Tom Tromey  <tom@tromey.com>
11762
11763         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11764         Don't declare.
11765         * mipsread.c: Include mdebugread.h.
11766         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11767         Declare.
11768         * elfread.c: Include mdebugread.h.
11769
11770 2019-01-09  Tom Tromey  <tom@tromey.com>
11771
11772         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11773         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11774         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11775         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11776         (psym_lookup_symbol, psym_find_last_source_symtab)
11777         (psym_forget_cached_source_info, psym_print_stats)
11778         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11779         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11780         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11781         (psym_find_compunit_symtab_by_address)
11782         (maintenance_print_psymbols, maintenance_info_psymtabs)
11783         (maintenance_check_psymtabs): Use ranged for.
11784         * psymtab.h (class objfile_psymtabs): New.
11785         (require_partial_symbols): Return objfile_psymtabs.
11786         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11787
11788 2019-01-09  Tom Tromey  <tom@tromey.com>
11789
11790         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11791         (find_pc_mapped_section, list_overlays_command)
11792         (map_overlay_command, unmap_overlay_command)
11793         (simple_overlay_update): Use all_objfiles.
11794         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11795         * printcmd.c (info_symbol_command): Use all_objfiles.
11796         * objfiles.h (ALL_OBJSECTIONS): Remove.
11797         * maint.c (maintenance_translate_address): Use all_objfiles.
11798         * gcore.c (gcore_create_callback): Use all_objfiles.
11799         (objfile_find_memory_regions): Likewise.
11800
11801 2019-01-09  Tom Tromey  <tom@tromey.com>
11802
11803         * symtab.c (find_line_symtab, info_sources_command)
11804         (make_source_files_completion_list): Use objfile_compunits.
11805         * source.c (select_source_symtab): Use objfile_compunits.
11806         * objfiles.h (struct objfile): Update comment.
11807         (ALL_OBJFILES): Remove.
11808         (ALL_FILETABS): Remove.
11809         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11810         objfile_compunits.
11811
11812 2019-01-09  Tom Tromey  <tom@tromey.com>
11813
11814         * symmisc.c (print_objfile_statistics, dump_objfile)
11815         (maintenance_print_symbols): Use compunit_filetabs.
11816         * source.c (forget_cached_source_info_for_objfile): Use
11817         compunit_filetabs.
11818         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11819         (ALL_FILETABS): Use compunit_filetabs.
11820         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11821         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11822
11823 2019-01-09  Tom Tromey  <tom@tromey.com>
11824
11825         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11826         (compunit_filetabs): New.
11827         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11828         compunit_filetabs.
11829         (info_sources_command, make_source_files_completion_list): Remove
11830         declaration.
11831         * symmisc.c (print_objfile_statistics, dump_objfile)
11832         (maintenance_print_symbols): Remove declaration.
11833         (maintenance_info_symtabs): Use compunit_filetabs.
11834         (maintenance_info_line_tables): Likewise.
11835         * source.c (select_source_symtab): Change local variable name.
11836         (forget_cached_source_info_for_objfile): Remove declaration.
11837         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11838         * objfiles.c (objfile_relocate1): Remove declaration.
11839         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11840         declaration.
11841         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11842         * coffread.c (coff_symtab_read): Remove declaration.
11843         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11844         compunit_filetabs.
11845
11846 2019-01-09  Tom Tromey  <tom@tromey.com>
11847
11848         * symtab.c (lookup_objfile_from_block)
11849         (find_pc_sect_compunit_symtab, search_symbols)
11850         (default_collect_symbol_completion_matches_break_on): Use
11851         objfile_compunits.
11852         * objfiles.h (ALL_COMPUNITS): Remove.
11853         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11854         * cp-support.c (add_symbol_overload_list_qualified): Use
11855         objfile_compunits.
11856         * ada-lang.c (ada_collect_symbol_completion_matches)
11857         (ada_add_global_exceptions): Use objfile_compunits.
11858
11859 2019-01-09  Tom Tromey  <tom@tromey.com>
11860
11861         * source.c (select_source_symtab)
11862         (forget_cached_source_info_for_objfile): Remove declaration.
11863         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11864         declaration.
11865         * maint.c (count_symtabs_and_blocks): Remove declaration.
11866         * cp-support.c (add_symbol_overload_list_qualified): Remove
11867         declaration.
11868         * coffread.c (coff_symtab_read): Remove declaration.
11869         * symtab.c (lookup_symbol_in_objfile_symtabs)
11870         (basic_lookup_transparent_type_1): Use objfile_compunits.
11871         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11872         (info_sources_command, search_symbols)
11873         (default_collect_symbol_completion_matches_break_on)
11874         (make_source_files_completion_list): Remove declaration.
11875         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11876         (ada_collect_symbol_completion_matches)
11877         (ada_add_global_exceptions): Remove declaration.
11878         * linespec.c (iterate_over_all_matching_symtabs): Use
11879         objfile_compunits.
11880         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11881         (class objfile_compunits): New.
11882         (ALL_COMPUNITS): Use objfile_compunits.
11883         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11884         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11885         objfile_compunits.
11886         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11887
11888 2019-01-09  Tom Tromey  <tom@tromey.com>
11889
11890         * symtab.c (search_symbols)
11891         (default_collect_symbol_completion_matches_break_on): Use
11892         objfile_msymbols.
11893         * ada-lang.c (ada_lookup_simple_minsym)
11894         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11895         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11896         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11897         objfile_msymbols.
11898         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11899         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11900         * objc-lang.c (find_methods): Use objfile_msymbols.
11901         (info_selectors_command, info_classes_command): Likewise.
11902         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11903         * objfiles.h (class objfile_msymbols): New.
11904         (ALL_OBJFILE_MSYMBOLS): Remove.
11905         (ALL_MSYMBOLS): Remove.
11906
11907 2019-01-09  Tom Tromey  <tom@tromey.com>
11908
11909         * common/next-iterator.h (next_adapter): Add Iterator template
11910         parameter.
11911         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11912         (class all_objfiles_safe): New.
11913         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11914         * objfiles.c (put_objfile_before): Update comment.
11915         (add_separate_debug_objfile): Likewise.
11916         (free_all_objfiles): Use all_objfiles_safe.
11917         (objfile_purge_solibs): Likewise.
11918
11919 2019-01-09  Tom Tromey  <tom@tromey.com>
11920
11921         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11922         (expand_symtab_containing_pc, lookup_static_symbol)
11923         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11924         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11925         all_objfiles.
11926         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11927         * breakpoint.c (create_overlay_event_breakpoint)
11928         (create_longjmp_master_breakpoint)
11929         (create_std_terminate_master_breakpoint)
11930         (create_exception_master_breakpoint): Use all_objfiles.
11931         * linux-thread-db.c (try_thread_db_load_from_pdir)
11932         (has_libpthread): Use all_objfiles.
11933         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11934         * linespec.c (iterate_over_all_matching_symtabs)
11935         (search_minsyms_for_name): Use all_objfiles.
11936         * maint.c (maintenance_info_sections): Use all_objfiles.
11937         * main.c (captured_main_1): Use all_objfiles.
11938         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11939         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11940         * guile/scm-pretty-print.c
11941         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11942         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11943         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11944         (maintenance_print_msymbols): Use all_objfiles.
11945         * source.c (select_source_symtab): Use all_objfiles.
11946         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11947         * symfile.c (remove_symbol_file_command)
11948         (expand_symtabs_matching, map_symbol_filenames): Use
11949         all_objfiles.
11950         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11951         all_objfiles.
11952         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11953         * objc-lang.c (find_methods): Use all_objfiles.
11954         * objfiles.c (have_partial_symbols, have_full_symbols)
11955         (have_minimal_symbols, qsort_cmp)
11956         (default_iterate_over_objfiles_in_search_order): Use
11957         all_objfiles.
11958         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11959         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11960         (maintenance_check_psymtabs): Use all_objfiles.
11961         (ALL_PSYMTABS): Remove.
11962         * compile/compile-object-run.c (do_module_cleanup): Use
11963         all_objfiles.
11964         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11965         * cp-support.c (add_symbol_overload_list_qualified): Use
11966         all_objfiles.
11967         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11968         Use all_objfiles.
11969         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11970         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11971         all_objfiles.
11972         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11973         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11974         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11975         Uses all_objfiles.
11976         * solib.c (solib_read_symbols): Use all_objfiles
11977
11978 2019-01-09  Tom Tromey  <tom@tromey.com>
11979
11980         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11981         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11982         all_objfiles.
11983         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11984         * symmisc.c (print_symbol_bcache_statistics)
11985         (print_objfile_statistics, maintenance_print_objfiles)
11986         (maintenance_info_symtabs, maintenance_check_symtabs)
11987         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11988         all_objfiles.
11989         * source.c (forget_cached_source_info): Use all_objfiles.
11990         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11991         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11992         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11993         * objfiles.c (update_section_map): Use all_objfiles.
11994         (shared_objfile_contains_address_p): Likewise.
11995         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11996         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11997
11998 2019-01-09  Tom Tromey  <tom@tromey.com>
11999
12000         * common/next-iterator.h: New file.
12001         * objfiles.h (class all_objfiles): New.
12002         (struct objfile_iterator): New.
12003
12004 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12005
12006         * NEWS: Move the description of the changed "frame", "select-frame",
12007          and "info frame" commands to the Changed commands section.
12008
12009 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12010
12011         * gdbtypes.c (check_stub_method_group): Remove handling of old
12012         mangling schemes.
12013         * linespec.c (find_methods): Likewise.
12014         * stabsread.c (read_member_functions): Likewise.
12015         * valops.c (search_struct_method): Likewise.
12016         (value_struct_elt_for_reference): Likewise.
12017         * NEWS: Mention this change.
12018
12019 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12020
12021         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12022         print_source_lines.
12023         * source.c (print_source_lines_base): Update line number check.
12024         (print_source_lines): New function.
12025         (source_lines_range::source_lines_range): New function.
12026         * source.h (class source_lines_range): New class.
12027         (print_source_lines): New declaration.
12028
12029 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12030
12031         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12032
12033 2019-01-08  Tom Tromey  <tom@tromey.com>
12034             Simon Marchi  <simon.marchi@ericsson.com>
12035
12036         PR gdb/24060
12037         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12038         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12039         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12040         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12041         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12042         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12043
12044 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12045
12046         * source.c (select_source_symtab): Move header comment to
12047         declaration in source.h.
12048         (forget_cached_source_info_for_objfile): Likewise.
12049         (forget_cached_source_info): Likewise.
12050         (identify_source_line): Likewise.
12051         * source.h (identify_source_line): Move declaration from symtab.h
12052         and add comment from source.c
12053         (print_source_lines): Likewise.
12054         (forget_cached_source_info_for_objfile): Likewise.
12055         (forget_cached_source_info): Likewise.
12056         (select_source_symtab): Likewise.
12057         (enum print_source_lines_flag): Move definition from symtab.h.
12058         * symtab.h (identify_source_line): Move declaration to source.h.
12059         (print_source_lines): Likewise.
12060         (forget_cached_source_info_for_objfile): Likewise.
12061         (forget_cached_source_info): Likewise.
12062         (select_source_symtab): Likewise.
12063         (enum print_source_lines_flag): Move definition to source.h.
12064         * tui/tui-hooks.c: Add 'source.h' include.
12065
12066 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12067
12068         * source.c (print_source_lines_base): Handle requests to print
12069         reverse line number sequences, and guard against empty lines
12070         string.
12071
12072 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12073
12074         * source.c (print_source_lines_base): Fix skip of '\r' if next
12075         character is '\n'.
12076
12077 2019-01-06  Tom Tromey  <tom@tromey.com>
12078
12079         * c-exp.y (struct c_parse_state) <macro_original_text,
12080         expansion_obstack>: New member.
12081         (macro_original_text, expansion_obstack): Remove globals.
12082         (scan_macro_expansion, scanning_macro_expansion)
12083         (finished_macro_expansion): Update.
12084         (scan_macro_cleanup): Remove.
12085         (yylex, c_parse): Update.
12086
12087 2019-01-06  Tom Tromey  <tom@tromey.com>
12088
12089         * c-exp.y (struct c_parse_state) <strings>: New member.
12090         (operator_stoken): Update.
12091
12092 2019-01-06  Tom Tromey  <tom@tromey.com>
12093
12094         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12095         (union type_stack_elt) <typelist_val>: Now a pointer to
12096         std::vector.
12097         (type_stack_cleanup): Don't declare.
12098         (push_typelist): Update.
12099         * parse.c (pop_typelist): Return a std::vector.
12100         (push_typelist): Take a std::vector.
12101         (follow_types): Update.  Do not free args.
12102         (type_stack_cleanup): Remove.
12103         * c-exp.y (struct c_parse_state): New.
12104         (cpstate): New global.
12105         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12106         (nonempty_typelist): Update.
12107         (func_mod): Create a new vector.
12108         (c_parse): Create a c_parse_state.
12109         (check_parameter_typelist): Do not delete params.
12110         (function_method): Update.  Do not delete type_list.
12111
12112 2019-01-06  Tom Tromey  <tom@tromey.com>
12113
12114         PR gdb/28155:
12115         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12116         check_typedef.
12117         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12118         (print_return_value): Likewise.
12119
12120 2019-01-05  Tom Tromey  <tom@tromey.com>
12121
12122         * contrib/cleanup_check.py: Remove.
12123         * contrib/gcc-with-excheck: Remove.
12124         * contrib/exsummary.py: Remove.
12125         * contrib/excheck.py: Remove.
12126
12127 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12128
12129         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12130         NULL. Initialize tpprev to NULL instead of assigning it
12131         to NULL on the next statement.
12132         * windows-nat.c (windows_delete_thread): Remove check for
12133         main_thread_id before printing thread exit notifications.
12134         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12135         Remove thread ID check against main_thread_id.
12136         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12137         windows_delete_thread.
12138         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12139
12140 2019-01-04  Tom Tromey  <tom@tromey.com>
12141
12142         * compile/compile.c (_initialize_compile): Use upper case for
12143         metasyntactic variables.
12144         * symmisc.c (_initialize_symmisc): Use upper case for
12145         metasyntactic variables.
12146         * psymtab.c (_initialize_psymtab): Use upper case for
12147         metasyntactic variables.
12148         * demangle.c (demangle_command): Use upper case for metasyntactic
12149         variables.
12150         (_initialize_demangler): Likewise.
12151         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12152         variables.
12153
12154 2019-01-03  Tom Tromey  <tom@tromey.com>
12155
12156         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12157
12158 2019-01-03  Tom Tromey  <tom@tromey.com>
12159
12160         * python/py-symtab.c (salpy_str): Update.
12161         (struct salpy_sal_object) <symtab>: Now a PyObject.
12162         (salpy_dealloc): Update.
12163         (del_objfile_sal): Use gdbpy_ref.
12164
12165 2019-01-03  Tom Tromey  <tom@tromey.com>
12166
12167         * python/py-type.c (convert_field): Use new_reference.  Return
12168         gdbpy_ref.
12169         (make_fielditem): Return gdbpy_ref.
12170         (typy_fields): Update.
12171         (typy_getitem): Update.
12172         (field_name): Return gdbpy_ref.  Use new_reference.
12173         (typy_iterator_iternext): Update.
12174
12175 2019-01-03  Tom Tromey  <tom@tromey.com>
12176
12177         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12178
12179 2019-01-03  Tom Tromey  <tom@tromey.com>
12180
12181         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12182         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12183         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12184         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12185         (pspy_set_type_printers): Likewise.
12186         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12187         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12188         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12189         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12190         (objfpy_set_type_printers): Likewise.
12191
12192 2019-01-03  Tom Tromey  <tom@tromey.com>
12193
12194         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12195         (gdbpy_print_stack): Use gdbpy_err_fetch.
12196         * python/python-internal.h (class gdbpy_err_fetch): New class.
12197         (class gdbpy_enter) <m_error_type, m_error_value,
12198         m_error_traceback>: Remove.
12199         <m_error>: New member.
12200         (gdbpy_exception_to_string): Don't declare.
12201         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12202         * python/py-value.c (convert_value_from_python): Use
12203         gdbpy_err_fetch.
12204         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12205         gdbpy_exception_to_string.
12206         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12207         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12208         gdbpy_err_fetch.
12209
12210 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12211
12212         * linux-nat.c (delete_lwp_cleanup): Delete.
12213         (struct lwp_deleter): New struct.
12214         (lwp_info_up): New typedef.
12215         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12216         lwp_info_up.
12217
12218 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12219
12220         * linux-fork.c (class scoped_switch_fork_info): New class.
12221         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12222
12223 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12224
12225         * valops.c (find_overload_match): Remove use of null_cleanup, and
12226         calls to do_cleanups.
12227
12228 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12229
12230         * compile/compile-cplus-types.c
12231         (compile_cplus_instance::decl_name): Handle changes to
12232         cp_func_name.
12233         * cp-support.c (cp_func_name): Update header comment, update
12234         return type.
12235         * cp-support.h (cp_func_name): Update return type in declaration.
12236         * valops.c (find_overload_match): Move temp_func local to top
12237         level of function and change its type.  Use temp_func to hold and
12238         delete temporary string obtained from cp_func_name.
12239
12240 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12241
12242         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12243         gdb::char_vector, remove cleanup, and update uses of `msg`.
12244
12245 2019-01-03  Jim Wilson  <jimw@sifive.com>
12246
12247         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12248
12249 2019-01-02  Tom Tromey  <tom@tromey.com>
12250
12251         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12252         (tdesc_parse_xml): Remove cleanups.
12253         * target-descriptions.h (make_cleanup_free_target_description):
12254         Don't declare.
12255         (target_desc_deleter): New struct.
12256         (target_desc_up): New typedef.
12257         * target-descriptions.c (target_desc_deleter::operator()): Rename
12258         from free_target_description.
12259         (make_cleanup_free_target_description): Remove.
12260
12261 2019-01-02  Tom Tromey  <tom@tromey.com>
12262
12263         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12264         constructor, destructor.
12265         (linespec_parser): Remove typedef.
12266         (~linespec_parser): Rename from linespec_parser_delete.
12267         (linespec_lex_to_end, linespec_complete_label)
12268         (linespec_complete): Update.
12269         (decode_line_full): Remove cleanups.
12270         (decode_line_1): Update.
12271
12272 2019-01-02  Tom Tromey  <tom@tromey.com>
12273
12274         * python/python-internal.h (inferior_to_inferior_object): Change
12275         return type.
12276         * python/py-exitedevent.c (create_exited_event_object): Update.
12277         * python/py-inferior.c (inferior_to_inferior_object): Return
12278         gdbpy_ref.
12279         (python_new_inferior, python_inferior_deleted)
12280         (thread_to_thread_object, delete_thread_object)
12281         (build_inferior_list, gdbpy_selected_inferior): Update.
12282         * python/py-infthread.c (create_thread_object): Update.  Also fail
12283         if inferior_to_inferior_object fails.
12284
12285 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12286
12287         * inferior.h (class inferior) <displaced_step_state>: New field.
12288         * infrun.h (struct displaced_step_state): Move here from
12289         infrun.c.  Initialize fields, add constructor.
12290         <inf>: Remove field.
12291         <reset>: New method.
12292         * infrun.c (struct displaced_step_inferior_state): Move to
12293         infrun.h.
12294         (displaced_step_inferior_states): Remove.
12295         (get_displaced_stepping_state): Adust.
12296         (displaced_step_in_progress_any_inferior): Adjust.
12297         (displaced_step_in_progress_thread): Adjust.
12298         (displaced_step_in_progress): Adjust.
12299         (add_displaced_stepping_state): Remove.
12300         (get_displaced_step_closure_by_addr): Adjust.
12301         (remove_displaced_stepping_state): Remove.
12302         (infrun_inferior_exit): Call displaced_step_state.reset.
12303         (use_displaced_stepping): Don't check for NULL.
12304         (displaced_step_prepare_throw): Call
12305         get_displaced_stepping_state.
12306         (displaced_step_fixup): Don't check for NULL.
12307         (prepare_for_detach): Don't check for NULL.
12308
12309 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12310
12311         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12312          in case of call that did not complete.
12313
12314 2019-01-02  Andrey Utkin  <autkin@undo.io>
12315
12316         * symfile.c (find_separate_debug_file): Fix search of debug files for
12317         remote debuggee.
12318
12319 2019-01-02  Tom Tromey  <tom@tromey.com>
12320
12321         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12322         indentation.
12323         * python/py-frame.c (frapy_older): Remove cast.
12324         (frapy_newer): Likewise.
12325         * python/py-breakpoint.c (local_setattro): Remove cast.
12326         * python/py-arch.c (archpy_name): Remove local variable.
12327         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12328
12329 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12330
12331         * unittests/basic_string_view/element_access/char/empty.cc:
12332         Fix year range in copyright header.
12333
12334 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12335
12336         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12337         Delete.
12338         <operator==>: Update with for removed field.
12339         <hash>: Likewise.
12340         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12341         <isa_features>: ...this.
12342         <abi_features>: New field.
12343         (riscv_isa_flen): Update comment.
12344         (riscv_abi_xlen): New declaration.
12345         (riscv_abi_flen): New declaration.
12346         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12347         isa_features.
12348         (riscv_abi_xlen): New function.
12349         (riscv_isa_flen): Update to get answer from isa_features.
12350         (riscv_abi_flen): New function.
12351         (riscv_has_fp_abi): Update to get answer from abi_features.
12352         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12353         xlen and flen.
12354         (riscv_call_info) <xlen, flen>: Update comment.
12355         (riscv_call_arg_struct): Remove invalid assertions
12356         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12357         is removed.
12358         (riscv_gdbarch_init): Gather isa features and abi features
12359         separately, ensure both match on the gdbarch when reusing an old
12360         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12361         a target with 64-bit float hardware.
12362
12363 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12364
12365         * source.c (search_command_helper): Stop reverse search
12366         when line 1 has been searched.
12367
12368 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12369
12370         * record-full.c (record_full_base_target::close): Rewrite
12371         record_full_core_buf_list free logic.
12372
12373 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12374
12375         * break-catch-syscall.c (print_one_catch_syscall): xfree
12376         the last text.
12377
12378 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12379
12380         * top.c (print_gdb_version): Update Copyright year in version
12381         message.
12382
12383 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12384
12385         Update copyright year range in all GDB files.
12386
12387 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12388
12389         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12390
12391 For older changes see ChangeLog-2018.
12392 \f
12393 Local Variables:
12394 mode: change-log
12395 left-margin: 8
12396 fill-column: 74
12397 version-control: never
12398 coding: utf-8
12399 End:
12400