gdb/ChangeLog

   1 2019-09-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (~tui_source_element): Remove.
   4         (tui_source_element): Update.
   5         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
   6         * tui/tui-winsource.c (tui_show_source_line): Update.
   7         * tui/tui-source.c (tui_source_window::set_contents): Update.
   8         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
   9
  10 2019-09-20  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
  13         declare.
  14         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
  15         tui_clear_source_windows_detail.
  16         * tui/tui-winsource.h (struct tui_source_window_base)
  17         <clear_detail>: Don't declare.
  18         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
  19         Remove.
  20         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
  21
  22 2019-09-20  Tom Tromey  <tromey@adacore.com>
  23
  24         PR ada/24919:
  25         * block.c (contained_in): Fix final return value.
  26
  27 2019-09-20  Alan Modra  <amodra@gmail.com>
  28
  29         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
  30         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
  31         (read_indirect_string_from_dwz): Use bfd accessor.
  32         * dwarf2read.h (struct dwz_file <filename>): Likewise.
  33         * machoread.c (macho_symfile_read_all_oso): Likewise.
  34         * solib.c (solib_bfd_open): Likewise.
  35
  36 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * eval.c: Move declaration of overload_resolution to...
  39         * value.h: ...here.
  40
  41 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
  42
  43         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
  44         * arm-linux-tdep.c: Likewise.
  45         * arm-nbsd-nat.c: Likewise.
  46         * arm-tdep.h: Declare arm_apcs_32.
  47         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
  48
  49 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
  50
  51         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
  52         * dwarf2read.h: Declare dwarf_always_disassemble.
  53
  54 2019-09-19  Tom de Vries  <tdevries@suse.de>
  55
  56         PR gdb/25009
  57         * source-cache.c (source_cache::ensure): Catch exception thrown during
  58         construction of the highlighter.
  59
  60 2019-09-18  Alan Modra  <amodra@gmail.com>
  61
  62         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
  63         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
  64         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
  65         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
  66         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
  67         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
  68         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
  69         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
  70         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
  71         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
  72         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
  73         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
  74         * solib-spu.c, * solib-svr4.c, * solib-target.c,
  75         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
  76         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
  77         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
  78         * mi/mi-interp.c: Update throughout for bfd section macro and
  79         function changes.
  80         * gcore (gcore_create_callback): Use bfd_set_section_lma.
  81         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
  82
  83 2019-09-18  Tom Tromey  <tom@tromey.com>
  84
  85         * NEWS: Add entry.
  86         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
  87         call rl_initialize.
  88         (tui_enable): Do not call rl_initialize.
  89
  90 2019-09-18  Christian Groessler  <chris@groessler.org>
  91
  92         * alpha-linux-nat.c: Include gdbarch.h.
  93
  94 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
  95
  96         * ui-file.c: Include cli/cli-style.h.
  97         (term_cli_styling): Remove cli_styling declaration.
  98
  99 2019-09-18  Alan Modra  <amodra@gmail.com>
 100
 101         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 102         to bfd_asymbol_section.
 103
 104 2019-09-18  Alan Modra  <amodra@gmail.com>
 105
 106         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 107         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 108         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 109
 110 2019-09-18  Alan Modra  <amodra@gmail.com>
 111
 112         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 113         * spu-linux-nat.c (spu_bfd_open): Likewise.
 114
 115 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 116
 117         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 118         to bool to match definition in dwarf2read.c.
 119
 120 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 121
 122         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 123         (print_signatures): Likewise.
 124         (trust_pad_over_xvs): Likewise.
 125         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 126         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 127         * arm-linux-nat.c (arm_apcs_32): Likewise.
 128         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 129         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 130         * arm-tdep.c (arm_debug): Likewise.
 131         (arm_apcs_32): Likewise.
 132         * auto-load.c (debug_auto_load): Likewise.
 133         (auto_load_gdb_scripts): Likewise.
 134         (global_auto_load): Likewise.
 135         (auto_load_local_gdbinit): Likewise.
 136         (auto_load_local_gdbinit_loaded): Likewise.
 137         * auto-load.h (global_auto_load): Likewise.
 138         (auto_load_local_gdbinit): Likewise.
 139         (auto_load_local_gdbinit_loaded): Likewise.
 140         * breakpoint.c (disconnected_dprintf): Likewise.
 141         (breakpoint_proceeded): Likewise.
 142         (automatic_hardware_breakpoints): Likewise.
 143         (always_inserted_mode): Likewise.
 144         (target_exact_watchpoints): Likewise.
 145         (_initialize_breakpoint): Update.
 146         * breakpoint.h (target_exact_watchpoints): Change to bool.
 147         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 148         * cli/cli-cmds.c (trace_commands): Likewise.
 149         * cli/cli-cmds.h (trace_commands): Likewise.
 150         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 151         to bool*.
 152         * cli/cli-logging.c (logging_overwrite): Change to bool.
 153         (logging_redirect): Likewise.
 154         (debug_redirect): Likewise.
 155         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 156         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 157         to bool.
 158         <boolean_option_def>: Update.
 159         (struct flag_option_def): Change default type of Context to bool
 160         from int.
 161         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 162         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 163         (get_setshow_command_value_string): Likewise.
 164         * cli/cli-style.c (cli_styling): Change to bool.
 165         (source_styling): Likewise.
 166         * cli/cli-style.h (source_styling): Likewise.
 167         (cli_styling): Likewise.
 168         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 169         to bool.
 170         * command.h (var_types): Update comment.
 171         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 172         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 173         bool.
 174         (debug_compile_cplus_scopes): Likewise.
 175         * compile/compile-internal.h (compile_debug): Likewise.
 176         * compile/compile.c (compile_debug): Likewise.
 177         (struct compile_options) <raw>: Likewise.
 178         * cp-support.c (catch_demangler_crashes): Likewise.
 179         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 180         (usr_cmd_cris_dwarf2_cfi): Likewise.
 181         * csky-tdep.c (csky_debug): Likewise.
 182         * darwin-nat.c (enable_mach_exceptions): Likewise.
 183         * dcache.c (dcache_enabled_p): Likewise.
 184         * defs.h (info_verbose): Likewise.
 185         * demangle.c (demangle): Likewise.
 186         (asm_demangle): Likewise.
 187         * dwarf-index-cache.c (debug_index_cache): Likewise.
 188         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 189         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 190         * dwarf2read.c (check_physname): Likewise.
 191         (use_deprecated_index_sections): Likewise.
 192         (dwarf_always_disassemble): Likewise.
 193         * eval.c (overload_resolution): Likewise.
 194         * event-top.c (set_editing_cmd_var): Likewise.
 195         (exec_done_display_p): Likewise.
 196         * event-top.h (set_editing_cmd_var): Likewise.
 197         (exec_done_display_p): Likewise.
 198         * exec.c (write_files): Likewise.
 199         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 200         (debug_fbsd_nat): Likewise.
 201         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 202         Likewise.
 203         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 204         <backtrace_past_entry> Likewise.
 205         * gdb-demangle.h (demangle): Likewise.
 206         (asm_demangle): Likewise.
 207         * gdb_bfd.c (bfd_sharing): Likewise.
 208         * gdbcore.h (write_files): Likewise.
 209         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 210         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 211         * gdbthread.h (print_thread_events): Likewise.
 212         * gdbtypes.c (opaque_type_resolution): Likewise.
 213         (strict_type_checking): Likewise.
 214         * gnu-nat.c (gnu_debug_flag): Likewise.
 215         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 216         * guile/scm-param.c (pascm_variable): Add boolval.
 217         (add_setshow_generic): Update.
 218         (pascm_param_value): Update.
 219         (pascm_set_param_value_x): Update.
 220         * hppa-tdep.c (hppa_debug): Change to bool..
 221         * infcall.c (may_call_functions_p): Likewise.
 222         (coerce_float_to_double_p): Likewise.
 223         (unwind_on_signal_p): Likewise.
 224         (unwind_on_terminating_exception_p): Likewise.
 225         * infcmd.c (startup_with_shell): Likewise.
 226         * inferior.c (print_inferior_events): Likewise.
 227         * inferior.h (startup_with_shell): Likewise.
 228         (print_inferior_events): Likewise.
 229         * infrun.c (step_stop_if_no_debug): Likewise.
 230         (detach_fork): Likewise.
 231         (debug_displaced): Likewise.
 232         (disable_randomization): Likewise.
 233         (non_stop): Likewise.
 234         (non_stop_1): Likewise.
 235         (observer_mode): Likewise.
 236         (observer_mode_1): Likewise.
 237         (set_observer_mode): Update.
 238         (sched_multi): Change to bool.
 239         * infrun.h (debug_displaced): Likewise.
 240         (sched_multi): Likewise.
 241         (step_stop_if_no_debug): Likewise.
 242         (non_stop): Likewise.
 243         (disable_randomization): Likewise.
 244         * linux-tdep.c (use_coredump_filter): Likewise.
 245         (dump_excluded_mappings): Likewise.
 246         * linux-thread-db.c (auto_load_thread_db): Likewise.
 247         (check_thread_db_on_load): Likewise.
 248         * main.c (captured_main_1): Update.
 249         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 250         xx2_opt, boolean_opt>: Change to bool.
 251         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 252         * maint.c (maintenance_profile_p): Likewise.
 253         (per_command_time): Likewise.
 254         (per_command_space): Likewise.
 255         (per_command_symtab): Likewise.
 256         * memattr.c (inaccessible_by_default): Likewise.
 257         * mi/mi-main.c (mi_async): Likewise.
 258         (mi_async_1): Likewise.
 259         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 260         * nat/fork-inferior.h (startup_with_shell): Likewise.
 261         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 262         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 263         * nios2-tdep.c (nios2_debug): Likewise.
 264         * or1k-tdep.c (or1k_debug): Likewise.
 265         * parse.c (parser_debug): Likewise.
 266         * parser-defs.h (parser_debug): Likewise.
 267         * printcmd.c (print_symbol_filename): Likewise.
 268         * proc-api.c (procfs_trace): Likewise.
 269         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 270         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 271         (set_parameter_value): Update.
 272         (add_setshow_generic): Update.
 273         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 274         to bool*.
 275         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 276         int*.
 277         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 278         * record-btrace.c (record_btrace_target::store_registers): Update.
 279         * record-full.c (record_full_memory_query): Change to bool.
 280         (record_full_stop_at_limit): Likewise.
 281         * record-full.h (record_full_memory_query): Likewise.
 282         * remote-notif.c (notif_debug): Likewise.
 283         * remote-notif.h (notif_debug): Likewise.
 284         * remote.c (use_range_stepping): Likewise.
 285         (interrupt_on_connect): Likewise.
 286         (remote_break): Likewise.
 287         * ser-tcp.c (tcp_auto_retry): Likewise.
 288         * ser-unix.c (serial_hwflow): Likewise.
 289         * skip.c (debug_skip): Likewise.
 290         * solib-aix.c (solib_aix_debug): Likewise.
 291         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 292         (spu_auto_flush_cache_p): Likewise.
 293         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 294         Likewise.
 295         (struct info_print_options) <quiet>: Likewise.
 296         * symfile-debug.c (debug_symfile): Likewise.
 297         * symfile.c (auto_solib_add): Likewise.
 298         (separate_debug_file_debug): Likewise.
 299         * symfile.h (auto_solib_add): Likewise.
 300         (separate_debug_file_debug): Likewise.
 301         * symtab.c (basenames_may_differ): Likewise.
 302         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 303         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 304         (struct info_types_options) <quiet>: Likewise.
 305         * symtab.h (demangle): Likewise.
 306         (basenames_may_differ): Likewise.
 307         * target-dcache.c (stack_cache_enabled_1): Likewise.
 308         (code_cache_enabled_1): Likewise.
 309         * target.c (trust_readonly): Likewise.
 310         (may_write_registers): Likewise.
 311         (may_write_memory): Likewise.
 312         (may_insert_breakpoints): Likewise.
 313         (may_insert_tracepoints): Likewise.
 314         (may_insert_fast_tracepoints): Likewise.
 315         (may_stop): Likewise.
 316         (auto_connect_native_target): Likewise.
 317         (target_stop_and_wait): Update.
 318         (target_async_permitted): Change to bool.
 319         (target_async_permitted_1): Likewise.
 320         (may_write_registers_1): Likewise.
 321         (may_write_memory_1): Likewise.
 322         (may_insert_breakpoints_1): Likewise.
 323         (may_insert_tracepoints_1): Likewise.
 324         (may_insert_fast_tracepoints_1): Likewise.
 325         (may_stop_1): Likewise.
 326         * target.h (target_async_permitted): Likewise.
 327         (may_write_registers): Likewise.
 328         (may_write_memory): Likewise.
 329         (may_insert_breakpoints): Likewise.
 330         (may_insert_tracepoints): Likewise.
 331         (may_insert_fast_tracepoints): Likewise.
 332         (may_stop): Likewise.
 333         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 334         (make_thread_apply_all_options_def_group): Change argument from int*
 335         to bool*.
 336         (thread_apply_all_command): Update.
 337         (print_thread_events): Change to bool.
 338         * top.c (confirm): Likewise.
 339         (command_editing_p): Likewise.
 340         (history_expansion_p): Likewise.
 341         (write_history_p): Likewise.
 342         (info_verbose): Likewise.
 343         * top.h (confirm): Likewise.
 344         (history_expansion_p): Likewise.
 345         * tracepoint.c (disconnected_tracing): Likewise.
 346         (circular_trace_buffer): Likewise.
 347         * typeprint.c (print_methods): Likewise.
 348         (print_typedefs): Likewise.
 349         * utils.c (debug_timestamp): Likewise.
 350         (sevenbit_strings): Likewise.
 351         (pagination_enabled): Likewise.
 352         * utils.h (sevenbit_strings): Likewise.
 353         (pagination_enabled): Likewise.
 354         * valops.c (overload_resolution): Likewise.
 355         * valprint.h (struct value_print_options) <prettyformat_arrays,
 356         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 357         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 358         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 359         Likewise.
 360         * windows-nat.c (new_console): Likewise.
 361         (cygwin_exceptions): Likewise.
 362         (new_group): Likewise.
 363         (debug_exec): Likewise.
 364         (debug_events): Likewise.
 365         (debug_memory): Likewise.
 366         (debug_exceptions): Likewise.
 367         (useshell): Likewise.
 368         * windows-tdep.c (maint_display_all_tib): Likewise.
 369         * xml-support.c (debug_xml): Likewise.
 370
 371 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 372
 373         * source.c (prepare_path_for_appending): New function.
 374         (openp): Make use of new function.
 375         (find_and_open_source): Search for the compilation directory and
 376         source file as a relative path beneath the directory search path.
 377
 378 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 379
 380         * source-cache.c (source_cache::get_line_charpos): Catch
 381         exceptions and return false, this matches the behaviour documented
 382         in the header file.
 383
 384 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 385
 386         * ada-tasks.c (info_task): Remove quoting of the task's name.
 387
 388 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 389
 390         * symfile.c (auto_solib_add): Replace comment with a reference
 391         to the header file.
 392
 393 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 394
 395         * NEWS: Mention that gdb can now be compiled with Python 3
 396         on Windows.
 397
 398 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * maint.c (maint_print_section_data::maint_print_section_data):
 401         Force use of 'float log10 (float)' by casting the argument to
 402         float.
 403
 404 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * maint.c: Add 'cmath' include.
 407         (struct maint_print_section_data): New structure.
 408         (print_section_index): New function.
 409         (print_bfd_section_info): Add header comment, small whitespace
 410         cleanup, and update to call new print_section_index function.
 411         (print_objfile_section_info): Likewise.
 412         (maint_obj_section_from_bfd_section): New function.
 413         (print_bfd_section_info_maybe_relocated): New function.
 414         (maintenance_info_sections): Add header comment, always use
 415         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 416
 417 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 418
 419         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 420         inner scope, add check that the objfile has psymtabs before
 421         checking psymtabs_addrmap.
 422         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 423
 424 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 425
 426         * NEWS: Announce that Ada task names are now shown at more places,
 427         and between quotes (except in info task output).
 428         * gdb/ada-tasks.c (task_to_str): New function.
 429         (display_current_task_id): Call task_to_str.
 430         (task_command_1): Likewise.
 431         (print_ada_task_info): In non-mi mode, Properly align headers and data
 432         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 433
 434 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 435
 436         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 437         prstatus.pr_lwp.pr_info instead of making it up.
 438
 439 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 440
 441         * auto-load.c (auto_load_expand_dir_vars): Update.
 442         * defs.h (gdb_datadir): Change to std::string.
 443         (python_libdir): Likewise.
 444         (relocate_gdb_directory): Change return type to std::string.
 445         * guile/guile.c (gdbscm_data_directory): Update.
 446         (initialize_scheme_side): Update.
 447         * jit.c (jit_reader_dir): Change to std::string.
 448         (jit_reader_load_command): Update.
 449         * main.c (gdb_datadir): Change to std::string.
 450         (python_libdir): Likewise.
 451         (set_gdb_data_directory): Update.
 452         (relocate_path): Change to return std::string.
 453         (relocate_gdb_directory): Change to return std::string.
 454         (relocate_gdbinit_path_maybe_in_datadir): Update.
 455         (captured_main_1): Update.
 456         * python/python.c (do_start_initialization): Update.
 457         * top.c (show_gdb_datadir): Update.
 458         * xml-syscall.c (xml_init_syscalls_info): Update.
 459         (init_syscalls_info): Update.
 460
 461 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 462
 463         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 464         out of get_init_files.
 465         (get_init_files): Update.
 466
 467 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 468
 469         * main.c (get_init_files): Change to use std::string.
 470         (captured_main_1): Update.
 471         (print_gdb_help): Update.
 472
 473 2019-09-11  Ali Tamur  <tamur@google.com>
 474
 475         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 476         implementation.
 477
 478 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 479
 480         * dbxread.c (read_dbx_symtab): Update.
 481         * dwarf2read.c (load_partial_dies): Update.
 482         * mdebugread.c (parse_partial_symbols): Update.
 483         (handle_psymbol_enumerators): Update.
 484         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 485         * psymtab.c (add_psymbol_to_bcache): Likewise.
 486         (add_psymbol_to_list): Likewise.
 487         * symtab.c (symbol_set_names): Likewise.
 488         * symtab.h (symbol_set_names): Likewise.
 489         * xcoffread.c (scan_xcoff_symtab): Update.
 490
 491 2019-09-11  Tom Tromey  <tom@tromey.com>
 492
 493         * symfile-mem.c (symbol_file_add_from_memory): Use
 494         bfd_set_filename.
 495         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 496         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 497
 498 2019-09-10  Tom Tromey  <tromey@adacore.com>
 499
 500         * dwarf-index-write.c (write_psymbols): Extend error message.
 501         (debug_names::insert): Add Ada code.
 502         (debug_names::write_psymbols): Remove Ada check.
 503         (debug_names) <m_string_obstack>: New member.
 504         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 505         (gdb_index_symbol_name_matcher::matches): Remove.
 506         (mapped_index_base::find_name_components_bounds): Add "lang"
 507         parameter.
 508         (mapped_index_base::build_name_components): Also split names
 509         according to Ada syntax.
 510         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 511         type of "match_callback".
 512         (check_match, check_find_bounds_finds)
 513         (dw2_expand_symtabs_matching): Update.
 514         (dw2_debug_names_iterator): Add new constructor.
 515         (dw2_debug_names_map_matching_symbols): New function.
 516         (dw2_debug_names_expand_symtabs_matching): Update.
 517         (dwarf2_debug_names_functions): Use
 518         dw2_debug_names_map_matching_symbols.
 519
 520 2019-09-10  Tom Tromey  <tromey@adacore.com>
 521
 522         * dwarf2read.c (dw2_get_file_names_reader): Add the
 523         CU's file name to the results.
 524
 525 2019-09-10  Tom Tromey  <tromey@adacore.com>
 526
 527         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 528         map_matching_symbols.  Update.
 529         * dwarf2read.c (dw2_map_matching_symbols): Update.
 530         * psymtab.c (match_partial_symbol): Change type; update.
 531         (psym_map_matching_symbols): Likewise.
 532         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 533         type; update.
 534         * symfile.h (struct quick_symbol_functions)
 535         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 536         Remove "match".
 537
 538 2019-09-10  Tom Tromey  <tromey@adacore.com>
 539
 540         * psymtab.c (map_block): Remove.
 541         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 542         * symtab.c (iterate_over_symbols_terminated): New function.
 543         * symtab.c (iterate_over_symbols_terminated): Declare.
 544
 545 2019-09-10  Tom Tromey  <tromey@adacore.com>
 546
 547         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 548         * language.h (struct language_defn) <la_iterate_over_symbols>:
 549         Return bool.
 550         * symtab.c (iterate_over_symbols): Return bool.
 551         * symtab.h (iterate_over_symbols): Return bool.
 552
 553 2019-09-10  Tom Tromey  <tromey@adacore.com>
 554
 555         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 556         (add_nonlocal_symbols): Update.
 557         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 558         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 559         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 560         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 561         Change type of "callback".  Remove "data".
 562
 563
 564 2019-09-09  Ali Tamur  <tamur@google.com>
 565
 566         * dwarf2read.c (comp_unit_head): Update comment.
 567         (dwarf2_dwo_name): New function declaration.
 568         (dwarf_unit_type_name): New function declaration.
 569         (read_comp_unit_head): Add support for new compilation units,
 570         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 571         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 572         (currently named as "signature") in their header. Also clarify error
 573         messages.
 574         (lookup_dwo_id): New function. Returns the dwo id of the given
 575         compile unit.
 576         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 577         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 578         functions.
 579         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 580         (dwarf2_dwo_name): Get the dwo name if present.
 581         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 582         purposes.
 583
 584 2019-09-09  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 587
 588 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 589
 590         * python/python.c (do_start_initialization): Make progname_copy static,
 591         to avoid a leak report.
 592
 593 2019-09-08  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 596
 597 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 598
 599         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 600         Change type to gdb::optional<block_enum>.
 601         (dw2_symtab_iter_init): Change block_index parameter type
 602         to gdb::optional<block_enum>.
 603         (dw2_lookup_symbol): Change block_index parameter
 604         type to block_enum.c
 605         (dw2_debug_names_lookup_symbol): Likewise.
 606         * psymtab.c (psym_lookup_symbol): Likewise.
 607         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 608         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 609         Likewise.
 610
 611 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 612
 613         * defs.h (relocate_gdb_directory): Change int to bool in
 614         signature and rename flag to relocatable.
 615         * main.c (relocate_path): Likewise.
 616         (relocate_gdb_directory): Likewise.
 617
 618 2019-09-06  Alan Modra  <amodra@gmail.com>
 619
 620         * coffread.c (coff_symfile_read): Constify filename variable.
 621         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 622         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 623         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 624         * solib.c (reload_shared_libraries_1): Likewise.
 625         * symfile.c (reread_symbols): Likewise.
 626         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 627         * solib-darwin.c (darwin_bfd_open): Likewise.
 628         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 629
 630 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 631
 632         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 633         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 634
 635 2019-09-03  Tom Tromey  <tromey@adacore.com>
 636
 637         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 638         types.
 639         (has_negatives): Unbias a range type bound.
 640         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 641         * gdbtypes.c (operator==): Handle new field.
 642         (create_range_type): Add "bias" parameter.
 643         (create_static_range_type, resolve_dynamic_range): Update.
 644         * gdbtypes.h (struct range_bounds) <bias>: New member.
 645         (create_range_type): Add bias parameter.
 646         * printcmd.c (print_scalar_formatted): Unbias range types.
 647         * value.c (unpack_long): Unbias range types.
 648         (pack_long): Bias range types.
 649
 650 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 651
 652         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 653         probe arguments.
 654
 655 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 656
 657         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 658         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 659         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 660         (compile_probe_arg): Likewise.
 661         * probe.h (get_argument_count): Likewise.
 662         * solib-svr4.c (solib_event_probe_action): Likewise.
 663         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 664
 665 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 666
 667         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 668         code to here...
 669         (svr4_create_solib_event_breakpoints): ...from here.
 670
 671 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 672
 673         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 674         suffix from warning message.
 675
 676 2019-08-30  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-winsource.h (struct tui_source_window_base)
 679         <refresh_all>: Don't declare.
 680         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 681         Remove.
 682         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 683         tui_show_locator_content.
 684         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 685         declare.
 686         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 687         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 688         declare.
 689
 690 2019-08-30  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 693
 694 2019-08-30  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 697         Remove unnecessary forward declarations.
 698
 699 2019-08-30  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 702         rerender.
 703         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 704         tui_show_locator_content.
 705
 706 2019-08-30  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 709         (tui_locator_window::rerender): Rewrite using body of previous
 710         tui_show_locator_content.
 711
 712 2019-08-30  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 715         set_locator_fullname>: New methods.
 716         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 717         Rename from tui_set_locator_fullname.
 718         (tui_locator_window::set_locator_info): Rename from
 719         tui_set_locator_info.  Return bool.
 720         (tui_update_locator_fullname, tui_show_frame_info): Update.
 721
 722 2019-08-30  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 725
 726 2019-08-30  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 729         call touchwin.
 730
 731 2019-08-30  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-wingeneral.c (box_win): Assume win_info and
 734         win_info->handle cannot be NULL.
 735
 736 2019-08-30  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 739         refresh_window>: Declare.
 740         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 741         resize.
 742         (tui_data_item_window::rerender): Rename from
 743         tui_display_register.
 744         (tui_data_item_window::refresh_window): New method.
 745         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 746         no-op.
 747
 748 2019-08-30  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 751         regs_column_count, current_group>: Move later.  Now private.
 752         <get_current_group>: New method.
 753         * tui/tui-regs.c (tui_reg_command): Update.
 754         * tui/tui-layout.c (tui_set_layout): Update.
 755
 756 2019-08-30  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 759         (tui_data_window::rerender): Don't call
 760         check_and_display_highlight_if_needed.
 761         (tui_data_window::refresh_all): Remove call to
 762         erase_data_content.
 763
 764 2019-08-30  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 767         (tui_data_window::display_registers_from)
 768         (tui_data_window::display_reg_element_at_line)
 769         (tui_data_window::display_registers_from_line): Remove checks of
 770         "empty".
 771
 772 2019-08-30  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 775         Don't declare.
 776         * tui/tui-regs.c (tui_data_window::show_registers): Call
 777         rerender.
 778         (tui_data_window::rerender): Rename from display_all_data.
 779         (tui_data_window::rerender): Remove old implementation.
 780
 781 2019-08-30  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 784         text.
 785         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 786
 787 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 788             Sergio Durigan Junior  <sergiodj@redhat.com>
 789
 790         PR win32/24284
 791         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 792
 793 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 794
 795         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 796         when searching for types.
 797
 798 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * f-lang.c (f_language_defn): Use f_print_typedef.
 801         * f-lang.h (f_print_typedef): Declare.
 802         * f-typeprint.c (f_print_typedef): Define.
 803
 804 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 805
 806         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 807
 808 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * cli/cli-utils.c (info_print_options_defs): Delete.
 811         (make_info_print_options_def_group): Delete.
 812         (extract_info_print_options): Delete.
 813         (info_print_command_completer): Delete.
 814         (info_print_args_help): Add extra parameter, and optionally
 815         include text about -n flag.
 816         * cli/cli-utils.h (struct info_print_options): Delete.
 817         (extract_info_print_options): Delete declaration.
 818         (info_print_command_completer): Delete declaration.
 819         (info_print_args_help): Add extra parameter, extend header
 820         comment.
 821         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 822         search_symbols.
 823         * stack.c (struct info_print_options): New type.
 824         (info_print_options_defs): New file scoped variable.
 825         (make_info_print_options_def_group): New static function.
 826         (info_print_command_completer): New static function.
 827         (info_locals_command): Update to use new local functions.
 828         (info_args_command): Likewise.
 829         (_initialize_stack): Add extra parameter to calls to
 830         info_print_args_help.
 831         * symtab.c (search_symbols): Add extra parameter, use this to
 832         possibly excluse non-debug symbols.
 833         (symtab_symbol_info): Add extra parameter, which is passed on to
 834         search_symbols.
 835         (struct info_print_options): New type.
 836         (info_print_options_defs): New file scoped variable.
 837         (make_info_print_options_def_group): New static function.
 838         (info_print_command_completer): New static function.
 839         (info_variables_command): Update to use local functions, and pass
 840         extra parameter through to symtab_symbol_info.
 841         (info_functions_command): Likewise.
 842         (info_types_command): Pass additional argument through to
 843         symtab_symbol_info.
 844         (rbreak_command): Pass extra argument to search_symbols.
 845         (_initialize_symtab): Add extra arguments for calls to
 846         info_print_args_help, and update help text for 'info variables',
 847         'whereis', and 'info functions' commands.
 848         * symtab.h (search_symbols): Add extra argument to declaration.
 849         * NEWS: Mention new flags.
 850
 851 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 852
 853         * symtab.c (lookup_static_symbol): Call the new function (and move
 854         it down to be next to lookup_global_symbol).
 855         (struct global_sym_lookup_data): Add block_enum member and rename to...
 856         (struct global_or_static_sym_lookup_data): ...this.
 857         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 858         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 859         (lookup_symbol_global_or_static_iterator_cb): ...this.
 860         (lookup_global_or_static_symbol): New function.
 861         (lookup_global_symbol): Call new function.
 862
 863 2019-08-26  Tom de Vries  <tdevries@suse.de>
 864
 865         PR c++/24852
 866         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 867         when pc_probe.prob == NULL.
 868
 869 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 870
 871         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 872         variable symbol_linkage to symbol_linkage_.
 873
 874 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 875
 876         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 877         represent whether the symbol is static, dynamic, or we don't
 878         know.
 879
 880 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 881
 882         * gdb/rx-tdep.c (rx_register_names): New.
 883         (rx_register_name): Delete.
 884         (rx_psw_type): Delete.
 885         (rx_fpsw_type): Delete.
 886         (rx_register_type): Delete.
 887         (rx_gdbarch_init): Convert target-descriptions.
 888         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 889         * gdb/features/Makefile: Add rx.xml.
 890         * gdb/features/rx.xml: New.
 891         * gdb/features/rx.c: Generated.
 892         * gdb/NEWS: Mention target description support.
 893
 894 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 895
 896         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 897         *slot_ptr.
 898
 899 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 900
 901         * configure.ac: Don't check for 'dlfcn.h' (moved to
 902         gdbsupport/common.m4).
 903         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 904         'gdbsupport/'.
 905         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 906         * compile/compile-c-support.c: Include
 907         'gdbsupport/gdb-dlfcn.h'.
 908         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 909         * gdb-dlfcn.c: Move to...
 910         * gdbsupport/gdb-dlfcn.c: ... here.
 911         * gdb-dlfcn.h: Move to...
 912         * gdbsupport/gdb-dlfcn.h: ... here.
 913
 914 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 915
 916         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 917         the offset field signed.
 918
 919 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 920
 921         * python/lib/gdb/__init__.py (_execute_file): New function.
 922         * python/python.c (python_run_simple_file): Call gdb._execute_file
 923         on Windows.
 924
 925 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 928         all uses as this was never set to anything but a zero value.
 929
 930 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 931
 932         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 933
 934 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 935
 936         * tui/tui-data.h (tui_gen_win_info): Add an =default
 937         move constructor, required by some GCC versions.
 938
 939 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 940
 941         * go32-nat.c (go32_sysinfo): Add hygon_p.
 942
 943 2019-08-20  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 946         line_from_reg_element_no, first_reg_element_no_inline,
 947         display_all_data, delete_data_content_windows,
 948         erase_data_content>: Now private.
 949
 950 2019-08-20  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 953         (tui_unhighlight_win, tui_highlight_win)
 954         (tui_win_info::make_window): Update.
 955         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 956
 957 2019-08-20  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 960         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 961         (MAX_PID_WIDTH): Move to tui-stack.c.
 962         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 963         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 964         (MAX_PID_WIDTH): Move from tui-data.h.
 965
 966 2019-08-20  Tom Tromey  <tom@tromey.com>
 967
 968         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 969         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 970         (box_win): Update.
 971         (tui_gen_win_info::make_window): Rename from tui_make_window.
 972         (tui_win_info::make_window): New method.
 973         (tui_gen_win_info::make_visible): Update.
 974         * tui/tui-source.c (tui_source_window::set_contents): Update.
 975         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 976         (tui_data_window::display_registers_from): Update.
 977         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 978         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 979         Declare.
 980         <can_box>: Remove.
 981         <title>: Remove.
 982         (struct tui_win_info) <make_window>: Declare.
 983         <can_box>: Now virtual.
 984         <title>: New member.
 985         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 986         * tui/tui-command.c (tui_cmd_window::resize): Update.
 987
 988 2019-08-20  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 991         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 992         (tui_data_window::check_register_values): Update.
 993
 994 2019-08-20  Tom Tromey  <tom@tromey.com>
 995
 996         * tui/tui-regs.h (struct tui_data_window): Use
 997         DISABLE_COPY_AND_ASSIGN.
 998         <regs_content>: Change type, removing unique_ptr.
 999         <tui_data_window>: Add move constructor.
1000         * tui/tui-regs.c (tui_data_window::show_registers)
1001         (tui_data_window::show_register_group)
1002         (tui_data_window::display_registers_from)
1003         (tui_data_window::display_registers_from)
1004         (tui_data_window::first_data_item_displayed)
1005         (tui_data_window::delete_data_content_windows)
1006         (tui_data_window::rerender, tui_data_window::refresh_window)
1007         (tui_data_window::check_register_values): Update.
1008
1009 2019-08-20  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1012         show_register_group>: Declare.
1013         (tui_show_register_group): Don't declare.
1014         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1015         tui_show_registers.
1016         (tui_data_window::show_register_group): Rename from
1017         tui_show_register_group.
1018         (tui_data_window::check_register_values, tui_reg_command):
1019         Update.
1020         * tui/tui-layout.c (tui_set_layout): Update.
1021
1022 2019-08-20  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1025         Declare.
1026         (tui_check_register_values): Don't declare.
1027         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1028         from tui_check_register_values.
1029         * tui/tui-hooks.c (tui_register_changed): Update.
1030
1031 2019-08-20  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-regs.c (tui_reg_layout): Move later.
1034         (tui_show_registers): Don't enable TUI mode or change layout.
1035
1036 2019-08-20  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-regs.h (struct tui_data_item_window)
1039         <~tui_data_item_window>: Remove.
1040         <content>: Now a unique_xmalloc_ptr.
1041         * tui/tui-regs.c (tui_register_format): Return a
1042         unique_xmalloc_ptr.
1043         (tui_get_register): Update.
1044         (~tui_data_item_window): Remove.
1045         (tui_data_window::display_registers_from, tui_display_register):
1046         Update.
1047         * tui/tui-io.h (tui_expand_tabs): Update.
1048         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1049         Remove "col" parameter.
1050
1051 2019-08-20  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1054         field.
1055         * tui/tui-regs.c (~tui_data_item_window): Update.
1056
1057 2019-08-20  Tom Tromey  <tom@tromey.com>
1058
1059         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1060         earlier.
1061
1062 2019-08-20  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1065
1066 2019-08-20  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-source.h (struct tui_source_window): Update.
1069         * tui/tui-regs.c (tui_show_registers): Update.
1070         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1071         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1072         (NO_REGS_STRING): Remove defines.
1073
1074 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1075
1076         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1077         unnecessary thread walk if remote doesn't support the packet.
1078
1079 2019-08-19  Tom Tromey  <tromey@adacore.com>
1080
1081         * python/py-value.c (value_has_field): Fix indentation.
1082
1083 2019-08-19  Tom Tromey  <tromey@adacore.com>
1084
1085         * printcmd.c (do_one_display, info_display_command): Update.
1086         * block.h (contained_in): Return bool.  Add allow_nested
1087         parameter.
1088         * block.c (contained_in): Return bool.  Add allow_nested
1089         parameter.
1090
1091 2019-08-19  Tom Tromey  <tom@tromey.com>
1092
1093         * configure: Rebuild.
1094         * configure.ac: Disallow the combination of -static-libstdc++ and
1095         source highlight.
1096         * source-cache.c (get_language_name): Handle rust.
1097         (source_cache::get_source_lines): Ignore highlighting exceptions.
1098
1099 2019-08-16  Tom Tromey  <tom@tromey.com>
1100
1101         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1102         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1103         (struct tui_source_window_base) <make_visible, refresh_window,
1104         resize>: Remove methods.
1105         <execution_info>: Remove field.
1106         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1107         (tui_show_source_line, tui_source_window_base)
1108         (~tui_source_window_base): Update.
1109         (tui_source_window_base::resize)
1110         (tui_source_window_base::make_visible)
1111         (tui_source_window_base::refresh_window): Remove.
1112         (tui_source_window_base::update_exec_info): Update.
1113         * tui/tui-source.c (tui_source_window::set_contents): Update.
1114         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1115
1116 2019-08-16  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1119         deprecated_query_hook.
1120
1121 2019-08-16  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1124         (tui_update_source_windows_with_line): Update.
1125         * tui/tui-source.h (struct tui_source_window)
1126         <show_symtab_source>: Declare.
1127         (tui_show_symtab_source): Don't declare.
1128         * tui/tui-source.c (tui_show_symtab_source): Rename from
1129         tui_show_symtab_source.
1130
1131 2019-08-16  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-winsource.h (struct tui_source_window_base)
1134         <set_contents>: Declare.
1135         * tui/tui-winsource.c
1136         (tui_source_window_base::update_source_window_as_is): Update.
1137         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1138         Declare.
1139         (tui_set_source_content): Don't declare.
1140         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1141         tui_set_source_content.
1142         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1143         Declare.
1144         (tui_set_disassem_content): Don't declare.
1145         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1146         tui_set_disassem_content.
1147
1148 2019-08-16  Tom Tromey  <tom@tromey.com>
1149
1150         * tui/tui-winsource.h (struct tui_source_window_base)
1151         <update_breakpoint_info>: Declare.
1152         (tui_update_breakpoint_info): Don't declare.
1153         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1154         (tui_update_all_breakpoint_info): Update.
1155         (tui_source_window_base::update_breakpoint_info): Rename from
1156         tui_update_breakpoint_info.
1157         (tui_source_window_base::update_exec_info): Update.
1158
1159 2019-08-16  Tom Tromey  <tom@tromey.com>
1160
1161         * tui/tui-winsource.h (struct tui_source_window_base)
1162         <update_source_window>: Declare.
1163         (tui_update_source_window): Don't declare.
1164         * tui/tui-winsource.c
1165         (tui_source_window_base::update_source_window): Rename from
1166         tui_update_source_window.
1167         (tui_source_window_base::rerender): Update.
1168         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1169         * tui/tui-disasm.c (tui_show_disassem)
1170         (tui_show_disassem_and_update_source)
1171         (tui_disasm_window::maybe_update): Update.
1172
1173 2019-08-16  Tom Tromey  <tom@tromey.com>
1174
1175         * tui/tui-winsource.h (struct tui_source_window_base)
1176         <update_source_window_as_is>: Declare.
1177         (tui_update_source_window_as_is): Don't declare.
1178         * tui/tui-winsource.c (tui_update_source_window): Update
1179         (tui_source_window_base::update_source_window_as_is): Rename from
1180         tui_update_source_window_as_is.
1181         (tui_source_window_base::refill): Update.
1182         * tui/tui-source.c (tui_show_symtab_source): Update.
1183         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1184         Update.
1185
1186 2019-08-16  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-winsource.h (tui_update_source_window)
1189         (tui_update_source_window_as_is): Remove "noerror" parameter.
1190         * tui/tui-winsource.c (tui_update_source_window)
1191         (tui_update_source_window_as_is): Remove "noerror" parameter.
1192         (tui_update_source_windows_with_addr)
1193         (tui_update_source_windows_with_line)
1194         (tui_source_window_base::rerender)
1195         (tui_source_window_base::refill): Update.
1196         * tui/tui-source.h (tui_set_source_content)
1197         (tui_show_symtab_source): Remove "noerror" parameter.
1198         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1199         parameter.
1200         (tui_show_symtab_source): Likewise.
1201         (tui_source_window::maybe_update): Update.
1202         * tui/tui-disasm.c (tui_show_disassem)
1203         (tui_show_disassem_and_update_source)
1204         (tui_disasm_window::do_scroll_vertical)
1205         (tui_disasm_window::maybe_update): Update.
1206
1207 2019-08-16  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui.c (tui_is_window_visible): Update.
1210         * tui/tui-wingeneral.c (tui_make_window)
1211         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1212         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1213         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1214         (tui_set_win_height_command, parse_scrolling_args): Update.
1215         * tui/tui-source.c (tui_source_window::style_changed): Update.
1216         * tui/tui-regs.c (tui_show_registers)
1217         (tui_data_window::first_data_item_displayed)
1218         (tui_data_window::delete_data_content_windows)
1219         (tui_check_register_values, tui_reg_command): Update.
1220         * tui/tui-disasm.c (tui_show_disassem): Update.
1221         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1222         method.
1223         <is_visible>: Remove field.
1224         * tui/tui-data.c (tui_next_win, tui_prev_win)
1225         (tui_delete_invisible_windows): Update.
1226
1227 2019-08-16  Tom Tromey  <tom@tromey.com>
1228
1229         * tui/tui-winsource.h (struct tui_source_window_base)
1230         <m_has_locator>: Remove.
1231         * tui/tui-layout.c (show_source_disasm_command, show_data)
1232         (show_source_or_disasm_and_command): Update.
1233
1234 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1235
1236         * NEWS (Other MI changes): New subsection.
1237         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1238         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1239         * arch-utils.c (default_get_pc_address_flags): New function.
1240         * arch-utils.h (default_get_pc_address_flags): New declaration.
1241         * gdbarch.sh: Add get_pc_address_flags.
1242         * gdbarch.c: Regenerate.
1243         * gdbarch.h: Likewise.
1244         * stack.c (print_pc): New function.
1245         (print_frame_info) (print_frame): Call print_pc.
1246
1247 2019-08-16  Tom de Vries  <tdevries@suse.de>
1248
1249         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1250         print_objfile_section_info.
1251
1252 2019-08-15  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1255         calling update_cmdwin_start_line.
1256         * tui/tui-winsource.h (struct tui_source_window_base)
1257         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1258         <rerender>: Declare.
1259         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1260         Call rerender.
1261         (tui_source_window_base::set_new_height): Remove.
1262         (tui_source_window_base::rerender): Rename from
1263         do_make_visible_with_new_height.
1264         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1265         resize method.
1266         (tui_win_info::make_invisible_and_set_new_height)
1267         (tui_win_info::make_visible_with_new_height): Remove.
1268         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1269         Declare.
1270         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1271         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1272         do_make_visible_with_new_height>: Don't declare.
1273         <rerender>: Declare.
1274         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1275         set_new_height.
1276         (tui_data_window::do_make_visible_with_new_height): Remove.
1277         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1278         call tui_show_locator_content.
1279         (tui_gen_win_info::resize): Call rerender.
1280         (show_source_or_disasm_and_command): Don't call
1281         tui_show_locator_content.
1282         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1283         method.
1284         (struct tui_win_info) <rerender>: Declare.
1285         <set_new_height, make_invisible_and_set_new_height,
1286         make_visible_with_new_height>: Don't declare.
1287         * tui/tui-data.c (tui_win_list::rerender): New method.
1288         * tui/tui-command.h (struct tui_cmd_window)
1289         <do_make_visible_with_new_height>: Don't declare.
1290         * tui/tui-command.c
1291         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1292
1293 2019-08-15  Tom Tromey  <tromey@adacore.com>
1294
1295         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1296         * ada-lang.c (ada_enum_name): Likewise.
1297
1298 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1299
1300         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1301         leading underscore.
1302         (GdbOutputErrorFile): Likewise.
1303         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1304         accordingly.
1305         (execute_unwinders): Rename to have a leading underscore.
1306         (auto_load_packages): Likewise.
1307         (global scope): Adjust call to auto_load_packages accordingly.
1308         (GdbSetPythonDirectory): Likewise.
1309         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1310         instead of execute_unwinders.
1311
1312 2019-08-15  Tom Tromey  <tom@tromey.com>
1313
1314         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1315         (show_data): Don't change window visibility.
1316         (tui_gen_win_info::resize): Remove special case for command
1317         window.  Use wresize, when available.
1318         (show_source_or_disasm_and_command): Don't change window
1319         visibility.
1320         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1321         <make_visible>: New method.
1322         * tui/tui-command.c (tui_cmd_window::resize): New method.
1323
1324 2019-08-15  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1327         (struct tui_source_windows): New.
1328         * tui/tui-winsource.c (tui_display_main): Update.
1329         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1330         (new_height_ok, parse_scrolling_args): Update.
1331         * tui/tui-layout.c (show_layout, show_data): Update.
1332         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1333         (tui_add_to_source_windows): Don't declare.
1334         * tui/tui-data.c (source_windows, tui_source_windows)
1335         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1336
1337 2019-08-15  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1340         Rename from reset.
1341         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1342         * tui/tui-layout.c (show_source_disasm_command, show_data):
1343         Update.
1344         (tui_gen_win_info::resize): Rename.
1345         (show_source_or_disasm_and_command): Update.
1346         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1347         reset.
1348
1349 2019-08-15  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1352         * tui/tui-interp.c (tui_interp::init): Don't call
1353         tui_initialize_static_data.
1354         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1355
1356 2019-08-15  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1359         examine tui_win_list.
1360
1361 2019-08-15  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1364         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1365         tui_clear_source_content.
1366         (tui_clear_source_content): Remove.
1367         (tui_source_window_base::do_erase_source_content): Hoist call to
1368         content.clear().
1369         * tui/tui-stack.c (tui_show_frame_info): Don't call
1370         tui_clear_source_content.
1371
1372 2019-08-15  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-winsource.h (struct tui_source_window_base)
1375         <do_erase_source_content>: New method.
1376         <erase_source_content>: New method.
1377         (tui_erase_source_content): Don't declare.
1378         * tui/tui-winsource.c (tui_clear_source_content): Update.
1379         (tui_source_window_base::do_erase_source_content): Rename from
1380         tui_erase_source_content.
1381         (tui_source_window_base::show_source_content): Update.
1382         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1383         * tui/tui-source.h (struct tui_source_window)
1384         <erase_source_content>: New method.
1385         * tui/tui-disasm.h (struct tui_disasm_window)
1386         <erase_source_content>: New method.
1387
1388 2019-08-15  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1391         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1392         constructor.
1393         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1394         * tui/tui-source.c (tui_set_source_content): Update.
1395         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1396
1397 2019-08-15  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1400         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1401         tui-source.c.
1402         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1403         Declare.
1404         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1405         method.
1406         (tui_source_window::maybe_update): Update.
1407
1408 2019-08-15  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1411         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1412         tui-disasm.c.
1413         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1414         Declare.
1415         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1416         method.
1417         (tui_disasm_window::maybe_update): Update.
1418
1419 2019-08-15  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-winsource.h (struct tui_source_window_base)
1422         <maybe_update>: Declare.
1423         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1424         method.
1425         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1426         Declare.
1427         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1428         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1429         Declare.
1430         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1431
1432 2019-08-15  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1435
1436 2019-08-15  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-wingeneral.c: Include tui-stack.h.
1439         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1440         (struct tui_locator_window): Move from tui-data.h.
1441         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1442         (tui_initialize_static_data): Move from tui-data.c.
1443         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1444         (struct tui_locator_window): Move to tui-stack.c.
1445         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1446         (tui_initialize_static_data): Move to tui-stack.c.
1447
1448 2019-08-15  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-layout.c (show_source_disasm_command)
1451         (show_source_or_disasm_and_command): Use make_visible method, not
1452         tui_make_window.
1453         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1454         Remove.
1455
1456 2019-08-15  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-wingeneral.h (tui_make_window): Update.
1459         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1460         parameter.
1461         (tui_gen_win_info::make_visible): Update.
1462         * tui/tui-regs.c (tui_data_window::display_registers_from):
1463         Update.
1464         * tui/tui-layout.c (show_source_disasm_command)
1465         (show_source_or_disasm_and_command): Update.
1466         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1467         (enum tui_box): Remove.
1468         (struct tui_win_info) <can_box>: New method.
1469         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1470         method.
1471
1472 2019-08-15  Tom de Vries  <tdevries@suse.de>
1473
1474         * linux-nat-trad.c: Include gdbarch.h.
1475
1476 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1477
1478         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1479         register sizes.
1480
1481 2019-08-14  Tom Tromey  <tromey@adacore.com>
1482
1483         * darwin-nat.c: Include gdbarch.h.
1484         * darwin-nat-info.c: Include gdbarch.h.
1485
1486 2019-08-13  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1489         Remove.
1490         * tui/tui-data.c (tui_initialize_static_data): Update.
1491
1492 2019-08-13  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-winsource.h (struct tui_exec_info_window)
1495         <~tui_exec_info_window, maybe_allocate_content, get_content,
1496         m_content>: Remove.
1497         (struct tui_source_window_base) <set_exec_info_content,
1498         show_exec_info_content>: Don't declare.
1499         * tui/tui-winsource.c
1500         (tui_exec_info_window::maybe_allocate_content): Remove.
1501         (tui_source_window_base::update_exec_info): Rename from
1502         set_exec_info_content.
1503         (tui_source_window_base::show_exec_info_content)
1504         (tui_source_window_base::update_exec_info): Remove.
1505
1506 2019-08-13  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1509         declare.
1510         * tui/tui-winsource.c (tui_update_source_window_as_is)
1511         (tui_update_source_windows_with_addr, tui_erase_source_content):
1512         Update.
1513         (tui_clear_exec_info_content): Remove.
1514
1515 2019-08-13  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1518         declare.
1519         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1520         call tui_erase_exec_info_content.
1521         (tui_clear_exec_info_content): Rename from
1522         tui_erase_exec_info_content.
1523         (tui_clear_exec_info_content): Delete.
1524
1525 2019-08-13  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-winsource.h (struct tui_source_window_base)
1528         <show_exec_info_content>: Declare.
1529         (tui_show_exec_info_content): Don't declare.
1530         * tui/tui-winsource.c
1531         (tui_source_window_base::show_exec_info_content): Rename from
1532         tui_show_exec_info_content.
1533         (tui_source_window_base::update_exec_info): Update.
1534
1535 2019-08-13  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1538         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1539         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1540         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1541         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1542         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1543         ... here.
1544
1545 2019-08-13  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-winsource.h (struct tui_source_window_base)
1548         <update_exec_info>: Declare.
1549         (tui_update_exec_info): Don't declare.
1550         * tui/tui-winsource.c (tui_update_source_window_as_is)
1551         (tui_source_window_base::refresh_all)
1552         (tui_update_all_breakpoint_info): Update.
1553         (tui_source_window_base::update_exec_info): Rename from
1554         tui_update_exec_info.
1555         * tui/tui-stack.c (tui_show_frame_info): Update.
1556
1557 2019-08-13  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-winsource.h (struct tui_source_window_base)
1560         <set_exec_info_content>: Declare.
1561         (tui_set_exec_info_content): Don't declare.
1562         * tui/tui-winsource.c
1563         (tui_source_window_base::set_exec_info_content): Rename from
1564         tui_set_exec_info_content.
1565         (tui_update_exec_info): Update.
1566
1567 2019-08-13  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-winsource.h (struct tui_source_window_base)
1570         <show_source_content>: Declare.
1571         (tui_show_source_content): Don't declare.
1572         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1573         (tui_source_window_base::show_source_content): Rename from
1574         tui_show_source_content.
1575         (tui_source_window_base::refresh_all): Update.
1576         * tui/tui-layout.c (show_source_disasm_command)
1577         (show_source_or_disasm_and_command): Update.
1578
1579 2019-08-13  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-winsource.c (tui_erase_source_content)
1582         (tui_show_source_content, tui_source_window_base::refresh_all):
1583         Update.
1584         * tui/tui-wingeneral.h
1585         (tui_check_and_display_highlight_if_needed): Don't declare.
1586         * tui/tui-wingeneral.c
1587         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1588         check_and_display_highlight_if_needed.
1589         * tui/tui-win.c (tui_rehighlight_all)
1590         (tui_win_info::make_visible_with_new_height): Update.
1591         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1592         (tui_data_window::erase_data_content)
1593         (tui_data_window::display_all_data): Update.
1594         * tui/tui-data.h (struct tui_win_info)
1595         <check_and_display_highlight_if_needed>: Declare.
1596
1597 2019-08-13  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-win.c (tui_resize_all): Call
1600         tui_delete_invisible_windows.
1601         * tui/tui-layout.c (show_layout): Call
1602         tui_delete_invisible_windows.
1603         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1604         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1605
1606 2019-08-13  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1609         tui_add_win_to_layout.
1610
1611 2019-08-13  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1614         * tui/tui-layout.c (tui_default_win_height): Now static.
1615
1616 2019-08-13  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1619         single switch.
1620         (show_source_disasm_command, show_source_or_disasm_and_command):
1621         Don't check current layout.
1622
1623 2019-08-13  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-wingeneral.c (make_all_visible): Remove.
1626         (tui_make_all_invisible): Simplify.
1627         * tui/tui-layout.c (tui_make_all_invisible): Move from
1628         tui-wingeneral.c; simplify.
1629         (show_layout): Hoist call to tui_make_all_invisible.
1630         (show_data): Don't call tui_make_all_invisible.
1631
1632 2019-08-13  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1635         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1636
1637 2019-08-13  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1640         tui-data.c.
1641         (show_source_disasm_command, show_data)
1642         (show_source_or_disasm_and_command): Don't use
1643         tui_set_current_layout_to.
1644         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1645         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1646         tui-layout.c.
1647         (tui_set_current_layout_to): Remove.
1648
1649 2019-08-13  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-layout.c (tui_set_layout): Update.
1652         * tui/tui-data.h (struct tui_layout_def): Remove.
1653         (tui_layout_def): Don't declare.
1654         * tui/tui-data.c (layout_def): Remove.
1655         (tui_layout_def): Remove.
1656
1657 2019-08-13  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-winsource.h (struct tui_source_window_base)
1660         <clear_detail>: No longer "override".
1661         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1662         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1663         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1664         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1665         Remove.
1666         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1667
1668 2019-08-13  Tom Tromey  <tromey@adacore.com>
1669
1670         * tracepoint.c: Don't include readline.h or history.h.
1671
1672 2019-08-12  Tom Tromey  <tom@tromey.com>
1673
1674         * configure: Rebuild.
1675         * configure.ac: Check for readline 7.
1676         * NEWS: Mention readline 7 requirement.
1677         * README: Update.
1678
1679 2019-08-12  Tom Tromey  <tom@tromey.com>
1680
1681         * mingw-hdep.c (gdb_select): Remove readline hack.
1682
1683 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1684
1685         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1686         when the function fails.
1687
1688 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1689
1690         * s390-tdep.c (s390_type_align): New function.
1691         (s390_gdbarch_init): Set it as type_align gdbarch method.
1692
1693 2019-08-09  Tom de Vries  <tdevries@suse.de>
1694
1695         PR gdb/24591
1696         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1697         pc_low with relocation offset.
1698
1699 2019-08-07  Tom Tromey  <tromey@adacore.com>
1700
1701         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1702         (print_frame_args): Update.
1703         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1704         Update.
1705         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1706         * frame.h (struct frame_arg): Add initializers.
1707         <error>: Now a unique_xmalloc_ptr.
1708
1709 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1710
1711         * NEWS: Expand the Pointer Authentication entry.
1712         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1713         (aarch64_frame_unmask_lr): ... to this.
1714         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1715         Call aarch64_frame_unmask_lr.
1716         * frame.c (struct frame_info): Add "masked" variable.
1717         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1718         (fprint_frame): Check for masked pc.
1719         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1720         declarations.
1721         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1722         * stack.c (print_frame): Check for masked pc.
1723
1724 2019-08-06  Tom Tromey  <tom@tromey.com>
1725
1726         * stabsread.c (patch_block_stabs, read_one_struct_field)
1727         (read_enum_type): Use obstack_strndup.
1728         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1729         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1730         * dwarf2read.c (guess_full_die_structure_name)
1731         (anonymous_struct_prefix): Use obstack_strndup.
1732         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1733         * c-exp.y (yylex): Use obstack_strndup.
1734         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1735         (write_var_or_type): Use obstack_strndup.
1736
1737 2019-08-06  Tom Tromey  <tom@tromey.com>
1738
1739         * symfile.c (reread_symbols): Use obstack_strdup.
1740         * stabsread.c (read_type): Use obstack_strdup.
1741         * gdb_obstack.h (obstack_strdup): New overload.
1742         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1743         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1744         (dwarf2_canonicalize_name): Use obstack_strdup.
1745         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1746         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1747         Use obstack_strdup.
1748
1749 2019-08-06  Tom Tromey  <tom@tromey.com>
1750
1751         * gdb_obstack.h (obstack_strdup): Define.
1752         * gdb_obstack.c (obstack_strdup): Don't define.
1753
1754 2019-08-06  Tom Tromey  <tom@tromey.com>
1755
1756         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1757         obstack_strdup.
1758         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1759         obstack_strdup.
1760         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1761         * stabsread.c (common_block_start): Use obstack_strdup.
1762         * objfiles.c (set_objfile_main_name, objfile): Use
1763         obstack_strdup.
1764         * namespace.c (add_using_directive): Use obstack_strdup.
1765         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1766         * jit.c (finalize_symtab): Use obstack_strdup.
1767         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1768         (guess_partial_die_structure_name, partial_die_info::fixup)
1769         (dwarf2_name): Use obstack_strdup.
1770         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1771         obstack_strdup.
1772         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1773         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1774         obstack_strdup.
1775         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1776
1777 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1778
1779         * unittests/help-doc-selftests.c: New file.
1780         * Makefile.in: Add the new file.
1781
1782 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1783
1784         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1785         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1786         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1787         the trailing '.' is not output, and the first character is uppercased.
1788         (print_help_for_command): Update call to print_doc_line.
1789         (print_doc_of_command): Likewise.
1790         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1791         * cli/cli-option.c (append_indented_doc): Do not append newline.
1792         (build_help_option): Append newline after first appended_indented_doc
1793         only if a second call is done.
1794         (build_help): Append 2 new lines before each option, except the first
1795         one.
1796         * compile/compile.c (_initialize_compile): Add new lines after
1797         %OPTIONS%, when not at the end of the help.
1798         Change help doc or code
1799         producing the help doc to respect the invariants.
1800         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1801         Also removed the new line after 'Options:', as all other commands
1802         do not put an empty line between 'Options:' and the first option.
1803         * printcmd.c (_initialize_printcmd): Likewise.
1804         * stack.c (_initialize_stack): Likewise.
1805         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1806         incorrectly telling COMMAND is optional.
1807         * ada-lang.c (_initialize_ada_language): Change help doc or code
1808         producing the help doc to respect the invariants.
1809         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1810         * breakpoint.c (_initialize_breakpoint): Likewise.
1811         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1812         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1813         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1814         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1815         _initialize_cli_style): Likewise.
1816         * corelow.c (core_target_info): Likewise.
1817         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1818         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1819         * filesystem.c (_initialize_filesystem): Likewise.
1820         * frame.c (_initialize_frame): Likewise.
1821         * gnu-nat.c (add_task_commands): Likewise.
1822         * infcall.c (_initialize_infcall): Likewise.
1823         * infcmd.c (_initialize_infcmd): Likewise.
1824         * interps.c (_initialize_interpreter): Likewise.
1825         * language.c (_initialize_language): Likewise.
1826         * linux-fork.c (_initialize_linux_fork): Likewise.
1827         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1828         * maint.c (_initialize_maint_cmds): Likewise.
1829         * memattr.c (_initialize_mem): Likewise.
1830         * printcmd.c (_initialize_printcmd): Likewise.
1831         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1832         _RegEx): Likewise.
1833         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1834         * record-btrace.c (_initialize_record_btrace): Likewise.
1835         * record-full.c (_initialize_record_full): Likewise.
1836         * record.c (_initialize_record): Likewise.
1837         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1838         * regcache.c (_initialize_regcache): Likewise.
1839         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1840         _initialize_remote): Likewise.
1841         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1842         * serial.c (_initialize_serial): Likewise.
1843         * skip.c (_initialize_step_skip): Likewise.
1844         * source.c (_initialize_source): Likewise.
1845         * stack.c (_initialize_stack): Likewise.
1846         * symfile.c (_initialize_symfile): Likewise.
1847         * symtab.c (_initialize_symtab): Likewise.
1848         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1849         * top.c (init_main): Likewise.
1850         * tracefile-tfile.c (tfile_target_info): Likewise.
1851         * tracepoint.c (_initialize_tracepoint): Likewise.
1852         * tui/tui-win.c (_initialize_tui_win): Likewise.
1853         * utils.c (add_internal_problem_command): Likewise.
1854         * valprint.c (value_print_option_defs): Likewise.
1855
1856 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1857
1858         PR build/24886
1859         * configure.ac: Drop enable-libmcheck support.
1860         * configure, config.in: Rebuild.
1861         * libmcheck.m4: Remove.
1862         * acinclude.m4: Don't include it.
1863         * Makefile.in: Don't distribute it.
1864         * top.c (print_gdb_configuration): Don't mention it.
1865
1866 2019-08-06  Tom Tromey  <tom@tromey.com>
1867
1868         * utils.c (set_output_style): Sometimes pass stream to
1869         emit_style_escape.
1870         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1871         * record-btrace.c (btrace_insn_history): Update.
1872         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1873         method.
1874         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1875         Update initializers.
1876         <m_uiout>: New field.
1877         <m_di>: Move lower.
1878         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1879         Remove "uiout" parameter.
1880         (dump_insns): Update.
1881         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1882         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1883
1884 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1885
1886         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1887         (error_in_psymtab_expansion): Likewise.
1888         (lookup_symbol_via_quick_fns): Likewise.
1889         (basic_lookup_transparent_type_quick): Likewise.
1890         (basic_lookup_transparent_type_1): Likewise.
1891
1892 2019-08-06  Tom Tromey  <tromey@adacore.com>
1893
1894         * source.c (last_source_error): Now bool.
1895         (print_source_lines_base): Make "noprint" bool.  Only open
1896         source file when last_source_visited changes.
1897
1898 2019-08-06  Tom Tromey  <tromey@adacore.com>
1899
1900         * annotate.c (annotate_source_line): Use g_source_cache.
1901         * source-cache.c (source_cache::get_plain_source_lines): Change
1902         parameters.  Populate m_offset_cache.
1903         (source_cache::ensure): New method.
1904         (source_cache::get_line_charpos): New method.
1905         (extract_lines): Move lower.  Change parameters.
1906         (source_cache::get_source_lines): Move lower.
1907         * source-cache.h (class source_cache): Update comment.
1908         <get_line_charpos>: New method.
1909         <get_source_lines>: Update comment.
1910         <clear>: Clear m_offset_cache.
1911         <get_plain_source_lines>: Change parameters.
1912         <ensure>: New method
1913         <m_offset_cache>: New member.
1914         * source.c (forget_cached_source_info_for_objfile): Update.
1915         (info_source_command): Use g_source_cache.
1916         (find_source_lines, open_source_file_with_line_charpos): Remove.
1917         (print_source_lines_base, search_command_helper): Use g_source_cache.
1918         * source.h (open_source_file_with_line_charpos): Don't declare.
1919         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1920         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1921         Use g_source_cache.
1922
1923 2019-08-06  Tom Tromey  <tromey@adacore.com>
1924
1925         * source-cache.c (source_cache::get_plain_source_lines):
1926         Remove "first_line" and "last_line" parameters.
1927         (source_cache::get_source_lines): Cache plain text.
1928         * source-cache.h (class source_cache)
1929         <get_plain_source_lines>: Update.
1930
1931 2019-08-06  Tom Tromey  <tromey@adacore.com>
1932
1933         * source-cache.c (extract_lines): No longer a method.
1934         Changed type of parameter.  Include final newline.
1935         (selftests::extract_lines_test): New function.
1936         (_initialize_source_cache): Likewise.
1937         * source-cache.h (class source_cache)
1938         <extract_lines>: Don't declare.
1939
1940 2019-08-06  Tom Tromey  <tromey@adacore.com>
1941
1942         * breakpoint.c (init_breakpoint_sal): Update.
1943         (breakpoint): Update.
1944         * breakpoint.h (struct breakpoint) <filter>: Now a
1945         unique_xmalloc_ptr.
1946
1947 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1948
1949         * NEWS: Mention dictionary access on blocks.
1950         * python/py-block.c (blpy_getitem): New function.
1951         (block_object_as_mapping): New struct.
1952         (block_object_type): Use new struct for tp_as_mapping field.
1953
1954 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1955
1956         * objfiles.h (objfile): Add a comment describing partial symbols.
1957
1958 2019-08-05  Tom Tromey  <tromey@adacore.com>
1959
1960         * compile/compile.c (_initialize_compile): Use _(), not N_().
1961         * thread.c (_initialize_thread): Use _(), not N_().
1962         * stack.c (_initialize_stack): Use _(), not N_().
1963         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1964
1965 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1966
1967         * dwarf2read.c (struct dw2_symtab_iterator):
1968         <want_specific_block>: Remove.
1969         <block_index>: Change type to gdb::optional.
1970         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1971         change type of BLOCK_INDEX parameter to gdb::optional.
1972         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1973         (dw2_lookup_symbol): Don't pass argument for
1974         WANT_SPECIFIC_BLOCK.
1975         (dw2_expand_symtabs_for_function): Don't pass argument for
1976         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1977         (class dw2_debug_names_iterator)
1978         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1979         parameter, change BLOCK_INDEX type to gdb::optional.
1980         <m_want_specific_block>: Remove.
1981         <m_block_index>: Change type to gdb::optional.
1982         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1983         gdb::optional.  Re-write in function of gdb::optional.
1984         (dw2_debug_names_lookup_symbol): Don't pass argument for
1985         WANT_SPECIFIC_BLOCK.
1986         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1987         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1988         BLOCK_INDEX.
1989
1990 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1991
1992         * NEWS: Mention changes to "info sources" command.
1993
1994 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1995
1996         * symtab.c (filename_partial_match_opts): New struct type.
1997         (struct output_source_filename_data): New members
1998         regexp, c_regexp, partial_match.
1999         (output_source_filename): Use new members to decide to print file.
2000         (info_sources_option_defs): New variable.
2001         (make_info_sources_options_def_group, print_info_sources_header,
2002         info_sources_command_completer):
2003         New functions.
2004         (info_sources_command): Read new optional arguments.
2005         (_initialize_symtab): Update info sources help.
2006
2007 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2008
2009         * ada-lang.c (exception_support_info_v0): Renamed from...
2010         (default_exception_support_info): ... this.  Create new
2011         definition for v1.
2012         (ada_has_this_exception_support): Look up catch_handlers_sym.
2013         (ada_exception_support_info_sniffer): Try v0 after default.
2014
2015 2019-08-01  Tom Tromey  <tromey@adacore.com>
2016
2017         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2018         gdbarch.h.
2019
2020 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2021
2022         * s12z-tdep.c: Fix include path for s12z-opc.h.
2023
2024 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2025
2026         * NEWS: Require GNU make 3.82.
2027
2028 2019-07-16  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2031         declare.
2032
2033 2019-07-30  Tom Tromey  <tromey@adacore.com>
2034
2035         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2036
2037 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2038
2039         * printcmd.c (print_address_symbolic): Print negative offsets.
2040         (build_address_symbolic): Force signed arithmetic when computing
2041         offset.
2042
2043 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2044
2045         PR/24474: Add a function to lookup static variables.
2046         * NEWS: Mention this new function.
2047         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2048         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2049         * python/python.c (python_GdbMethods): Add new function.
2050
2051 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2052
2053         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2054         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2055         (objfpy_lookup_static_symbol): New function.
2056         (objfile_object_methods): Add new functions.
2057
2058 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2059
2060         * NEWS: Mention 'set|show print frame-info'.  Mention new
2061         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2062         backtrace argument.  Mention that python frame filtering code
2063         is now consistent with what 'backtrace' command prints.
2064
2065 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2066
2067         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2068         comments.
2069         (print_frame_info_auto, print_frame_info_source_line,
2070         print_frame_info_location, print_frame_info_source_and_location,
2071         print_frame_info_location_and_address, print_frame_info_short_location):
2072         New declarations.
2073         (struct frame_print_options): New member print_frame_info.
2074         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2075         * stack.h (get_user_print_what_frame_info): New declaration.
2076         (frame_show_address): New declaration.
2077         * stack.c (print_frame_arguments_choices): New value 'presence'.
2078         (print_frame_info_auto, print_frame_info_source_line,
2079         print_frame_info_location, print_frame_info_source_and_location,
2080         print_frame_info_location_and_address, print_frame_info_short_location,
2081         print_frame_info_choices, print_frame_info_print_what): New definitions.
2082         (print_frame_args): Only print dots for args if print frame-arguments
2083         is 'presence'.
2084         (frame_print_option_defs): New element for "frame-info".
2085         (get_user_print_what_frame_info): New function.
2086         (frame_show_address): Make non static.  Move comment to stack.h.
2087         (print_frame_info_to_print_what): New function.
2088         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2089         to decide what to print.
2090         (backtrace_command_1): Handle the new print_frame_arguments_presence
2091         value.
2092         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2093         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2094         (py_print_frame): In non-mi mode, use LOCATION as default for
2095         print_what, similarly to frame information printed directly by
2096         backtrace command. Handle frame-info user option in non MI mode.
2097
2098 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2099
2100         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2101         Add case for debugging 32-bit target on 64-bit host.  Revise
2102         comment.
2103
2104 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2105
2106         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2107         instead of find_function_entry_range_from_pc.
2108
2109 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2110
2111         * stack.c (find_frame_funname): Remove code which preferred
2112         minsym over symtab sym in "certain pathological cases".
2113
2114         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2115         parameter.  Change type of "do_demangle" to bool.
2116         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2117         Pass suitable "prefer_sym_over_minsym" flag to
2118         build_address_symbolic().  Don't output "+" for negative offsets.
2119         * printcmd.c (print_address_symbolic): Update invocation of
2120         build_address_symbolic to include a "prefer_sym_over_minsym"
2121         flag.
2122         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2123         Restrict cases in which use of minimal symbol is preferred to that
2124         of a found symbol.  Update comments.
2125
2126         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2127         for entry pc when entry pc is out of range for that FDE.
2128
2129 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2130
2131         PR gdb/24839:
2132         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2133         type.
2134
2135 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2136
2137         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2138         this function's Python signature.
2139
2140
2141 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2142
2143         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2144         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2145         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2146         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2147         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2148
2149
2150 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2151
2152         * h8300-tdep.c (h8300_register_name_common): New.
2153         h8300_register_name): Use h8300_register_name_common.
2154         (h8300s_register_name): Likewise.
2155         (h8300sx_register_name): Likewise.
2156         (h8300h_register_nam): New.
2157         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2158
2159
2160 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2161
2162         * arm-tdep.c (arm_skip_cmse_entry): New function.
2163         (arm_is_sgstubs_section): New function.
2164         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2165
2166 2019-07-22  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2169         Don't self-assign.
2170
2171 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2172
2173         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2174         type_print.
2175
2176 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2179         so that GDB doesn't match any msymbols when searching in the
2180         TYPES_DOMAIN.
2181         (print_symbol_info): Print using typedef_print or type_print based
2182         on the type of the symbol.  Add updated FIXME comment moved from...
2183         (_initialize_symtab): ... move and update FIXME comment to above.
2184
2185 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2186
2187         * NEWS: Mention adding -q option to "info types".
2188         * symtab.c (struct info_types_options): New struct.
2189         (info_types_options_defs): New variable.
2190         (make_info_types_options_def_group): New function.
2191         (info_types_command): Use gdb::option framework to parse options.
2192         (info_types_command_completer): New function.
2193         (_initialize_symtab): Extend the help text on "info types" and
2194         register command completer.
2195
2196 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2197
2198         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2199         (lookup_symbol_in_objfile): Change int to block_enum and add a
2200         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2201
2202 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2203
2204         * MAINTAINERS (Write After Approval): Add self.
2205
2206 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2209         instruction to the dummy code region.
2210
2211 2019-07-19  Tom Tromey  <tromey@adacore.com>
2212
2213         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2214         (ARGSUSED, PARAMS, __func__): Remove rules.
2215
2216 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2217
2218         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2219         * features/arm/arm-with-iwmmxt.c: Remove.
2220         * features/arm/arm-with-iwmmxt.xml: Remove.
2221         * features/arm/arm-with-m-fpa-layout.c: Remove.
2222         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2223         * features/arm/arm-with-m-vfp-d16.c: Remove.
2224         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2225         * features/arm/arm-with-m.c: Remove.
2226         * features/arm/arm-with-m.xml: Remove.
2227         * features/arm/arm-with-neon.c: Remove.
2228         * features/arm/arm-with-neon.xml: Remove.
2229         * features/arm/arm-with-vfpv2.c: Remove.
2230         * features/arm/arm-with-vfpv2.xml: Remove.
2231         * features/arm/arm-with-vfpv3.c: Remove.
2232         * features/arm/arm-with-vfpv3.xml: Remove.
2233
2234 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2235
2236         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2237
2238 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2239
2240         * arch/aarch32.c (aarch32_create_target_description): Create
2241         target descriptions using features.
2242         * arch/arm.c (arm_create_target_description)
2243         (arm_create_mprofile_target_description): Likewise.
2244         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2245
2246 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2247
2248         * Makefile.in: Add new files.
2249         * aarch32-tdep.c: New file.
2250         * aarch32-tdep.h: New file.
2251         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2252         Call aarch32_read_description.
2253         * arch/aarch32.c: New file.
2254         * arch/aarch32.h: New file.
2255         * arch/arm.c (arm_create_target_description)
2256         (arm_create_mprofile_target_description): New function.
2257         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2258         (arm_create_target_description)
2259         (arm_create_mprofile_target_description): New declaration.
2260         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2261         read_description functions.
2262         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2263         Likewise.
2264         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2265         * arm-tdep.c (tdesc_arm_list): New variable.
2266         (arm_register_g_packet_guesses): Call create description functions.
2267         (arm_read_description) (arm_read_mprofile_description): New
2268         function.
2269         * arm-tdep.h (arm_read_description)
2270         (arm_read_mprofile_description): Add declaration.
2271         * configure.tgt: Add new files.
2272
2273 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2274
2275         * top.c (new_ui_command): Open specified terminal just once.
2276
2277 2019-07-18  Tom Tromey  <tromey@adacore.com>
2278
2279         * symtab.c (main_name): Constify return type.
2280         * symfile.c (set_initial_language): Update.
2281         * symtab.h (main_name): Constify return type.
2282
2283 2019-07-17  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-winsource.c (tui_update_source_window)
2286         (tui_update_source_window_as_is)
2287         (tui_update_source_windows_with_line): Remove return.
2288         * tui/tui-disasm.c (tui_show_disassem)
2289         (tui_show_disassem_and_update_source): Remove return.
2290         * tui/tui.c (tui_reset): Remove return.
2291         * tui/tui-wingeneral.c
2292         (tui_check_and_display_highlight_if_needed): Remove return.
2293
2294 2019-07-17  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2297
2298 2019-07-17  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-winsource.h (struct tui_exec_info_window)
2301         (struct tui_source_window_base): Move from tui-data.h.
2302         * tui/tui-winsource.c: Move many method definitions from
2303         elsewhere.  Remove "structuring" comments.
2304         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2305         (tui_source_window_base::refresh_window): Move to
2306         tui-winsource.c.
2307         * tui/tui-win.c (tui_source_window_base::refresh_all)
2308         (tui_source_window_base::update_tab_width)
2309         (tui_source_window_base::set_new_height)
2310         (tui_source_window_base::do_make_visible_with_new_height): Move to
2311         tui-winsource.c.
2312         * tui/tui-source.h: Update.
2313         * tui/tui-source.c (tui_source_window_base::reset): Move to
2314         tui-winsource.c.
2315         * tui/tui-disasm.h: Update.
2316         * tui/tui-data.h (struct tui_exec_info_window): Move to
2317         tui-winsource.h.
2318         (struct tui_source_window_base): Likewise.
2319         * tui/tui-data.c (tui_source_window_base::clear_detail)
2320         (tui_source_window_base, ~tui_source_window_base): Move to
2321         tui-winsource.c.
2322
2323 2019-07-17  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-win.c (tui_resize_all)
2326         (tui_source_window_base::update_tab_width)
2327         (tui_adjust_win_heights): Update.
2328         (tui_win_info::make_invisible_and_set_new_height): Rename from
2329         make_invisible_and_set_new_height.
2330         * tui/tui-data.h (struct tui_win_info)
2331         <make_invisible_and_set_new_height>: New method.
2332
2333 2019-07-17  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui.c: Update.
2336         * tui/tui-source.h (struct tui_source_window): Move from
2337         tui-data.h.
2338         * tui/tui-layout.c: Update.
2339         * tui/tui-disasm.c: Update.
2340         * tui/tui-data.h (struct tui_source_window): Move to
2341         tui-source.h.
2342
2343 2019-07-17  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2346         tui-data.h.
2347         * tui/tui-data.h (struct tui_disasm_window): Move to
2348         tui-disasm.h.
2349
2350 2019-07-17  Tom Tromey  <tom@tromey.com>
2351
2352         * tui/tui-regs.h (struct tui_data_item_window): Move from
2353         tui-data.h.
2354         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2355         * tui/tui-data.h (struct tui_data_item_window): Move to
2356         tui-regs.h.
2357         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2358
2359 2019-07-17  Tom Tromey  <tom@tromey.com>
2360
2361         * tui/tui.c: Update.
2362         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2363         (tui_cmd_window::max_height): Move to tui-command.c.
2364         * tui/tui-layout.c: Update.
2365         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2366         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2367         tui-command.c.
2368         * tui/tui-command.h (struct tui_cmd_window): Move from
2369         tui-data.h.
2370         * tui/tui-command.c: Remove "structuring" comments.
2371         (tui_cmd_window::clear_detail)
2372         (tui_cmd_window::do_make_visible_with_new_height)
2373         (tui_cmd_window::max_height): Move from elsewhere.
2374
2375 2019-07-17  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2378         Now static.
2379         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2380         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2381
2382 2019-07-17  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui.c: Update.
2385         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2386         tui-regs.c.
2387         * tui/tui-windata.h: Remove file.
2388         * tui/tui-windata.c: Remove file.
2389         * tui/tui-win.c (tui_data_window::set_new_height)
2390         (tui_data_window::do_make_visible_with_new_height): Move to
2391         tui-regs.c.
2392         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2393         * tui/tui-regs.c: Remove "structuring" comments.
2394         (tui_data_window::first_data_item_displayed)
2395         (tui_data_window::delete_data_content_windows)
2396         (tui_data_window::erase_data_content)
2397         (tui_data_window::display_all_data)
2398         (tui_data_window::refresh_all)
2399         (tui_data_window::do_scroll_vertical)
2400         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2401         (tui_data_window::do_make_visible_with_new_height)
2402         (tui_data_window::refresh_window): Move from elsewhere.
2403         (_initialize_tui_regs): Move to end of file.
2404         * tui/tui-layout.c: Update.
2405         * tui/tui-hooks.c: Update.
2406         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2407         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2408         tui-regs.c.
2409         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2410
2411 2019-07-17  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2414         seen.
2415
2416 2019-07-17  Tom Tromey  <tom@tromey.com>
2417
2418         * tui/tui-win.c (tui_source_window_base::set_new_height)
2419         (tui_source_window_base::do_make_visible_with_new_height): Use
2420         m_has_locator field directly.
2421         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2422         method.
2423         (struct tui_source_window_base) <has_locator>: Likewise.
2424
2425 2019-07-17  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2428         Don't declare.
2429         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2430         Remove.
2431         * tui/tui-win.c (tui_source_window_base::set_new_height)
2432         (tui_source_window_base::set_new_height)
2433         (make_invisible_and_set_new_height)
2434         (tui_source_window_base::do_make_visible_with_new_height)
2435         (tui_source_window_base::do_make_visible_with_new_height):
2436         Update.
2437         * tui/tui-layout.c (show_source_disasm_command, show_data)
2438         (show_source_or_disasm_and_command): Update.
2439         * tui/tui-layout.c (show_layout): Update.
2440
2441 2019-07-17  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui-layout.c (make_data_window): Remove.
2444         (show_data): Unify creation and re-initialization cases.
2445
2446 2019-07-17  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-layout.c (make_source_window, make_disasm_window):
2449         Remove.
2450         (show_data): Unify creation and re-initialization cases.
2451
2452 2019-07-17  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-layout.c (make_command_window): Remove.
2455         (show_source_disasm_command, show_source_or_disasm_and_command):
2456         Unify creation and re-initialization cases.
2457
2458 2019-07-17  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2461         creation and re-initialization cases.
2462
2463 2019-07-17  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-regs.c (tui_get_register): Return void.
2466
2467 2019-07-17  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2470         Simplify.
2471
2472 2019-07-17  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2475         resetting.
2476
2477 2019-07-17  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2480         * tui/tui-regs.c (tui_reg_layout): New function.
2481         (tui_show_registers, tui_reg_command): Use it.
2482         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2483         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2484         parameters.
2485         (tui_layout_command): Remove.
2486
2487 2019-07-17  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-layout.h (tui/tui-layout): Return void.
2490         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2491
2492 2019-07-17  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-layout.c (show_source_disasm_command, show_data):
2495         Update.
2496         (reset_locator): Remove.
2497         (show_source_or_disasm_and_command): Update.
2498
2499 2019-07-17  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-source.c (tui_source_window_base::reset): Remove
2502         win_type parameter.
2503         * tui/tui-layout.c (make_command_window, make_source_window)
2504         (make_disasm_window, make_data_window)
2505         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2506         (reset_locator, show_source_or_disasm_and_command): Update.
2507         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2508         win_type parameter.
2509         (struct tui_source_window_base) <reset>: Likewise.
2510
2511 2019-07-17  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-layout.c (show_source_disasm_command): Use
2514         reset_locator.
2515         (reset_locator): New function.
2516         (init_and_make_win): Remove.
2517         (show_source_or_disasm_and_command): Use reset_locator.
2518
2519 2019-07-17  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2522         condition.
2523         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2524         Remove condition.
2525         * tui/tui-source.c (tui_source_window_base::reset): New method.
2526         * tui/tui-layout.c (make_command_window): Don't call
2527         init_and_make_win.
2528         (make_source_window, make_disasm_window): Don't call
2529         make_source_or_disasm_window.
2530         (make_data_window): Don't call init_and_make_win.  Change calling
2531         convention.
2532         (show_source_disasm_command, show_data): Simplify.
2533         (make_source_or_disasm_window): Remove.
2534         (show_source_or_disasm_and_command): Simplify.
2535         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2536         (struct tui_source_window_base) <reset>: Likewise.
2537         <execution_info>: Remove initializer.
2538         * tui/tui-data.c (tui_source_window_base): Initialize
2539         execution_info.
2540
2541 2019-07-17  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2544         variable.
2545
2546 2019-07-17  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui.c (tui_rl_other_window): Update.
2549         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2550         superclass method first.  Always iterate over regs_content.
2551         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2552         method.
2553         * tui/tui-win.c (tui_set_focus_command): Update.
2554
2555 2019-07-17  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-win.c (tui_set_focus_command): Rename from
2558         tui_set_focus.  Call tui_enable.
2559         (tui_set_focus_command): Remove.
2560
2561 2019-07-17  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2564         refresh_window.
2565         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2566         touchwin.
2567         (tui_data_window::refresh_window): Call refresh_window on data
2568         items.  Always call superclass refresh_window.
2569         (tui_win_info::refresh): Remove.
2570         (tui_source_window_base::refresh_window): Update.
2571         (tui_refresh_all): Update.
2572         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2573         refresh_window.
2574         (show_source_or_disasm_and_command): Likewise.
2575         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2576         (struct tui_source_window_base) <refresh>: Likewise.
2577
2578 2019-07-17  Tom Tromey  <tom@tromey.com>
2579
2580         * tui/tui-winsource.c (tui_clear_source_content)
2581         (tui_show_source_content): Update.
2582         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2583         whether content is empty.
2584         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2585         Remove.
2586
2587 2019-07-17  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2590         window's contents.
2591         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2592         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2593
2594 2019-07-17  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2597         (struct tui_data_item_window): Update.
2598
2599 2019-07-17  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2602         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2603         defines.
2604
2605 2019-07-17  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui-winsource.h (tui_erase_source_content)
2608         (tui_clear_source_content): Remove "display_prompt" parameter.
2609         * tui/tui-winsource.c (tui_update_source_window_as_is)
2610         (tui_update_source_windows_with_addr): Update.
2611         (tui_clear_source_content): Remove "display_prompt" parameter.
2612         (tui_erase_source_content): Likewise.  Simplify.
2613         (tui_show_source_content): Update.
2614         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2615         * tui/tui-stack.c (tui_show_frame_info): Update.
2616         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2617         Remove defines.
2618
2619 2019-07-17  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2622         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2623         parameter.
2624         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2625         parameter.
2626
2627 2019-07-17  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-winsource.c (tui_clear_source_content)
2630         (tui_show_source_content, tui_show_exec_info_content)
2631         (tui_clear_exec_info_content): Update.
2632         * tui/tui-stack.c (tui_show_locator_content): Update.
2633         (tui_show_frame_info): Update.
2634         * tui/tui-source.h (tui_source_window): Don't declare.
2635         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2636         from tui_source_is_displayed.
2637         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2638         Remove field.
2639         (struct tui_source_window_base) <content_in_use>: New field.  Now
2640         bool.
2641         (struct tui_source_window) <showing_source_p>: New method.
2642         (TUI_SRC_WIN): Change cast.
2643         * tui/tui-data.c (tui_initialize_static_data): Update.
2644
2645 2019-07-17  Tom Tromey  <tom@tromey.com>
2646
2647         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2648         location_matches_p.
2649         * tui/tui-source.c (tui_source_window::location_matches_p): New
2650         method.
2651         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2652         method.
2653         * tui/tui-data.h (struct tui_source_window_base)
2654         <location_matches_p>: New method.
2655         (struct tui_source_window, struct tui_disasm_window)
2656         <location_matches_p>: Likewise.
2657
2658 2019-07-17  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-win.c (tui_set_win_height_command): Rename from
2661         tui_set_win_height.
2662         (tui_set_win_height_command): Remove.
2663
2664 2019-07-17  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-source.c (tui_source_window): New constructor.  Add
2667         observer.
2668         (~tui_source_window): New destructor.
2669         (tui_source_window::style_changed): New method.
2670         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2671         (tui_attach_detach_observers): Update.
2672         * tui/tui-data.h (struct tui_source_window): Make constructor not
2673         inline.  Add destructor.
2674         (struct tui_source_window) <style_changed>: New method.
2675         <m_observable>: New member.
2676
2677 2019-07-17  Tom Tromey  <tom@tromey.com>
2678
2679         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2680         * tui/tui-win.c (tui_resize_all): Fix typo.
2681
2682 2019-07-17  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2685         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2686         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2687         * tui/tui-win.c (window_name_completer): Use foreach.
2688         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2689         (update_tab_width): Likewise.
2690         * tui/tui-layout.c (show_layout): Update.
2691         * tui/tui-data.h (class tui_window_iterator): New.
2692         (struct all_tui_windows): New.
2693         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2694
2695 2019-07-17  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2698         parameter.  Don't reference globals.
2699         (tui_reg_command): Update.
2700
2701 2019-07-17  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-regs.c (tui_show_registers): Simplify.
2704
2705 2019-07-17  Tom Tromey  <tom@tromey.com>
2706
2707         * tui/tui-regs.c (tui_show_registers): Update.
2708         (tui_show_register_group): Add win_info parameter.
2709
2710 2019-07-17  Tom Tromey  <tom@tromey.com>
2711
2712         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2713         Rename from tui_display_reg_element_at_line.
2714         (tui_data_window::display_registers_from_line): Update.
2715         * tui/tui-data.h (struct tui_data_window)
2716         <display_reg_element_at_line>: New method.
2717
2718 2019-07-17  Tom Tromey  <tom@tromey.com>
2719
2720         * tui/tui-regs.h (tui_display_registers_from)
2721         (tui_display_registers_from_line): Don't declare.
2722         * tui/tui-windata.c (tui_data_window::display_all_data)
2723         (tui_data_window::refresh_all)
2724         (tui_data_window::do_scroll_vertical): Update.
2725         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2726         from tui_display_registers_from.
2727         (tui_display_reg_element_at_line): Update.
2728         (tui_data_window::display_registers_from_line): Rename from
2729         tui_display_registers_from_line.
2730         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2731         display_registers_from_line>: New methods.
2732
2733 2019-07-17  Tom Tromey  <tom@tromey.com>
2734
2735         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2736         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2737         from tui_erase_data_content.
2738         (tui_data_window::display_all_data)
2739         (tui_data_window::refresh_all)
2740         (tui_data_window::do_scroll_vertical): Update.
2741         * tui/tui-regs.c (tui_show_registers): Update.
2742         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2743         New method.
2744
2745 2019-07-17  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2748         declare.
2749         * tui/tui-windata.c
2750         (tui_data_window::delete_data_content_windows): Rename from
2751         tui_delete_data_content_windows.
2752         (tui_data_window::display_all_data)
2753         (tui_data_window::do_scroll_vertical): Update.
2754         * tui/tui-data.h (struct tui_data_window)
2755         <delete_data_content_windows>: New method.
2756
2757 2019-07-17  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2760         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2761
2762 2019-07-17  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2765         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2766         from tui_display_all_data.
2767         * tui/tui-win.c
2768         (tui_data_window::do_make_visible_with_new_height): Update.
2769         * tui/tui-regs.c (tui_show_registers): Update.
2770         * tui/tui-layout.c (tui_set_layout): Update.
2771         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2772         method.
2773
2774 2019-07-17  Tom Tromey  <tom@tromey.com>
2775
2776         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2777         * tui/tui-windata.c (tui_display_data_from): Remove.
2778         (tui_data_window::refresh_all): Update.
2779
2780 2019-07-17  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2783         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2784         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2785         tui_display_registers_from_line.
2786         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2787         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2788         "force_display" parameter.
2789
2790 2019-07-17  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2793         declare.
2794         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2795         Rename from tui_first_reg_element_no_inline.
2796         (tui_display_reg_element_at_line)
2797         (tui_display_registers_from_line): Update.
2798         * tui/tui-data.h (struct tui_data_window)
2799         <first_reg_element_no_inline>: New method.
2800
2801 2019-07-17  Tom Tromey  <tom@tromey.com>
2802
2803         * tui/tui-windata.c (tui_display_data_from)
2804         (tui_data_window::do_scroll_vertical): Update.
2805         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2806         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2807         Rename from tui_line_from_reg_element_no.
2808         (tui_display_registers_from_line): Update.
2809         * tui/tui-data.h (struct tui_data_window)
2810         <line_from_reg_element_no>: New method.
2811
2812 2019-07-17  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2815         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2816         tui_last_regs_line_no.
2817         (tui_display_reg_element_at_line)
2818         (tui_display_registers_from_line): Update.
2819         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2820         method.
2821
2822 2019-07-17  Tom Tromey  <tom@tromey.com>
2823
2824         PR tui/24722:
2825         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2826         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2827         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2828         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2829         (tui_update_breakpoint_info): Likewise.
2830         * tui/tui-hooks.c (tui_event_create_breakpoint)
2831         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2832         Update.
2833
2834 2019-07-17  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2837
2838 2019-07-17  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-winsource.c (tui_update_source_window_as_is)
2841         (tui_update_source_windows_with_addr): Update.
2842         * tui/tui-source.h (tui_set_source_content)
2843         (tui_show_symtab_source): Add "win_info" parameter.
2844         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2845         parameter.
2846         (tui_show_symtab_source): Likewise.
2847
2848 2019-07-17  Tom Tromey  <tom@tromey.com>
2849
2850         * tui/tui-wingeneral.c
2851         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2852
2853 2019-07-17  Tom Tromey  <tom@tromey.com>
2854
2855         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2856         (struct tui_cmd_window) <can_scroll>: New method.
2857         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2858         method.
2859
2860 2019-07-17  Tom Tromey  <tromey@adacore.com>
2861
2862         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2863         do_field_signed>: Rename.  Change type of "value".
2864         * ui-out.c (ui_out::field_signed): Rename from field_int.
2865         Change type of "value".
2866         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2867         type of "value".
2868         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2869         do_field_int.  Change type of "value".
2870         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2871         do_field_int.  Change type of "value".
2872         * tracepoint.c (trace_status_mi, tfind_1)
2873         (print_one_static_tracepoint_marker): Update.
2874         * thread.c (print_thread_info_1, print_selected_thread_frame):
2875         Update.
2876         * stack.c (print_frame, print_frame_info): Update.
2877         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2878         Update.
2879         * source.c (print_source_lines_base): Update.
2880         * skip.c (info_skip_command): Update.
2881         * record-btrace.c (btrace_ui_out_decode_error)
2882         (btrace_call_history_src_line): Update.
2883         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2884         Update.
2885         * progspace.c (print_program_space): Update.
2886         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2887         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2888         do_field_int.  Change type of "value".
2889         * mi/mi-out.c (mi_ui_out::do_table_begin)
2890         (mi_ui_out::do_table_header): Update.
2891         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2892         type of "value".
2893         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2894         (mi_cmd_data_list_changed_registers, output_register)
2895         (mi_cmd_data_read_memory, mi_load_progress)
2896         (mi_cmd_trace_frame_collected): Update.
2897         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2898         Update.
2899         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2900         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2901         (mi_cmd_var_list_children, varobj_update_one): Update.
2902         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2903         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2904         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2905         * inferior.c (print_inferior): Update.
2906         * gdb_bfd.c (print_one_bfd): Update.
2907         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2908         Update.
2909         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2910         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2911         do_field_int.  Change type of "value".
2912         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2913         do_field_int.  Change type of "value".
2914         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2915         (print_one_breakpoint_location, print_it_catch_fork)
2916         (print_one_catch_fork, print_it_catch_vfork)
2917         (print_one_catch_vfork, print_it_catch_solib)
2918         (print_it_catch_exec, print_it_ranged_breakpoint)
2919         (print_mention_watchpoint, print_mention_masked_watchpoint)
2920         (bkpt_print_it, update_static_tracepoint): Update.
2921         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2922         * break-catch-syscall.c (print_it_catch_syscall): Update.
2923         * ada-tasks.c (print_ada_task_info): Update.
2924         * ada-lang.c (print_it_exception, print_mention_exception):
2925         Update.
2926
2927 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2928
2929         PR breakpoints/24541
2930         * gdbarch.c: Regenerate.
2931         * gdbarch.h: Regenerate.
2932         * gdbarch.sh: Adjust return type and parameter types for
2933         'stap_adjust_register'.
2934         (i386_stap_adjust_register): Adjust signature and return new
2935         register name.
2936         * stap-probe.c (stap_parse_register_operand): Adjust use of
2937         'gdbarch_stap_adjust_register'.
2938
2939 2019-07-17  Tom Tromey  <tromey@adacore.com>
2940
2941         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2942         declare VEC.
2943         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2944         std::vector.
2945         (struct s390_process_info): Add initializers.
2946         (s390_add_process): Use new.
2947         (s390_linux_nat_target::low_forget_process): Use delete.
2948         (s390_linux_nat_target::low_new_fork)
2949         (s390_linux_nat_target::stopped_by_watchpoint)
2950         (s390_linux_nat_target::low_prepare_to_resume)
2951         (s390_linux_nat_target::insert_watchpoint)
2952         (s390_linux_nat_target::insert_hw_breakpoint)
2953         (s390_linux_nat_target::remove_watchpoint)
2954         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2955
2956 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2957
2958         * aarch64-fbsd-nat.c: Include regcache.h.
2959         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2960         argument.
2961         (aarch64_fbsd_nat_target::fetch_registers)
2962         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2963         variable.
2964         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2965
2966 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2967
2968         * fbsd-nat.c: Include gdbarch.h.
2969
2970 2019-07-15  Tom Tromey  <tromey@adacore.com>
2971
2972         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2973
2974 2019-07-15  Tom Tromey  <tromey@adacore.com>
2975
2976         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2977         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2978         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2979         * cli-out.c (cli_ui_out::do_field_int): New method.
2980         * ui-out.c (ui_out::field_unsigned): New method.
2981         * symfile.c (generic_load): Use field_unsigned.
2982         (print_transfer_performance): Likewise.
2983         * record-btrace.c (ui_out_field_uint): Remove.
2984         (btrace_call_history_insn_range, btrace_call_history): Use
2985         field_unsigned.
2986         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2987         field_unsigned.
2988         * ui-out.h (class ui_out) <field_unsigned>: New method.
2989         <do_field_unsigned>: Likewise.
2990
2991 2019-07-15  Tom Tromey  <tromey@adacore.com>
2992
2993         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2994         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2995         * target.c (flash_erase_command): Use field_string.
2996         * infrun.c (print_signal_received_reason): Use field_string.
2997         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2998         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2999         field_string.
3000         * ada-tasks.c (print_ada_task_info): Use field_string.
3001
3002 2019-07-15  Tom Tromey  <tromey@adacore.com>
3003
3004         * target.c (flash_erase_command): Use field_core_addr.
3005         * symfile.c (generic_load): Use field_core_addr.
3006         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3007         Use field_core_addr.
3008         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3009         field_core_addr.
3010
3011 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3012
3013         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3014         value if its desired type is smaller than a CORE_ADDR and signed.
3015
3016 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3019         of changes to field names, and use new is_reference field to
3020         decide if a property is a reference or not.
3021         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3022         field.
3023         (struct dwarf2_property_baton): Update header comment, rename
3024         'referenced_type' to 'property_type' and update comments.
3025         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3026         default property type, store in property baton, update to take
3027         accound of renamed field.
3028         (read_func_scope): Update call to attr_to_dynamic_prop.
3029         (read_array_type): Likewise.
3030         (dwarf2_per_cu_addr_sized_int_type): New function.
3031         (read_subrange_index_type): Move type finding code to
3032         dwarf2_per_cu_addr_sized_int_type.
3033         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3034         (dwarf2_per_cu_addr_type): New function.
3035         (set_die_type): Update calls to attr_to_dynamic_prop.
3036
3037 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3038
3039         * dwarf2read.c (read_subrange_index_type): New function.
3040         (read_subrange_type): Move code into new function and call it.
3041         * gdbtypes.c (create_range_type): Add some asserts.
3042
3043 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3044
3045         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3046         update return statements.
3047         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3048         declaration, and update comment to match.
3049         * gdbtypes.c (resolve_dynamic_array): Update call to
3050         dwarf2_evaluate_property to match new return type.
3051
3052 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3053
3054         * valarith.c (value_subscripted_rvalue): Change lowerbound
3055         parameter type from int to LONGEST.
3056         * value.h (value_subscripted_rvalue): Likewise in declaration.
3057
3058 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3059
3060         * cli/cli-utils.c (info_print_command_completer): New function.
3061         * cli/cli-utils.h: Add 'completer.h' include, and forward
3062         declaration for 'struct cmd_list_element'.
3063         (info_print_command_completer): Declare.
3064         * stack.c (_initialize_stack): Add completer for 'info locals' and
3065         'info args'.
3066         * symtab.c (_initialize_symtab): Add completer for 'info
3067         variables' and 'info functions'.
3068         * NEWS: Mention completion for additional info commands.
3069
3070 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3071
3072         * cli/cli-utils.c (extract_info_print_args): Delete.
3073         (extract_arg_maybe_quoted): Delete.
3074         (info_print_options_defs): New variable.
3075         (make_info_print_options_def_group): New function.
3076         (extract_info_print_options): Define new function.
3077         * cli/cli-utils.h (extract_info_print_args): Delete.
3078         (struct info_print_options): New structure.
3079         (extract_info_print_options): Declare new function.
3080         * stack.c (info_locals_command): Update to use new
3081         extract_info_print_options, also add a header comment.
3082         (info_args_command): Likewise.
3083         * symtab.c (info_variables_command): Likewise.
3084         (info_functions_command): Likewise.
3085
3086 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3087
3088         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3089         to extract string arguments.
3090         * common/common-utils.c (extract_string_maybe_quoted): New function.
3091         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3092
3093 2019-07-11  Tom Tromey  <tromey@adacore.com>
3094
3095         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3096         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3097         * top.h (gdbinit): Don't declare.
3098         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3099         into...
3100         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3101         * top.c (gdb_init): Don't call init_cli_cmds.
3102         (gdbinit): Remove.
3103         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3104
3105 2019-07-11  Tom Tromey  <tromey@adacore.com>
3106
3107         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3108         after it has been moved.
3109
3110 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3111
3112         * valops.c (value_must_coerce_to_target): Change return type to
3113         bool.
3114         * value.h (value_must_coerce_to_target): Likewise.
3115
3116 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3117
3118         * breakpoint.c (is_hardware_watchpoint): Remove
3119         forward-declaration.
3120         (is_masked_watchpoint): Change return type to bool.
3121         (is_tracepoint): Likewise.
3122         (is_breakpoint): Likewise.
3123         (is_hardware_watchpoint): Likewise.
3124         (is_watchpoint): Likewise.
3125         (is_no_memory_software_watchpoint): Likewise.
3126         (is_catchpoint): Likewise.
3127         (breakpoint_1): Make FILTER parameter's return type bool.
3128         is_masked_watchpoint): Change return type to bool.
3129         (save_breakpoints): Make FILTER parameter's return type bool.
3130         * breakpoint.h (is_breakpoint): Change return type to bool.
3131         (is_watchpoint): Likewise.
3132         (is_catchpoint): Likewise.
3133         (is_tracepoint): Likewise.
3134
3135 2019-07-10  Tom Tromey  <tom@tromey.com>
3136
3137         * defs.h: Don't include gdbarch.h.
3138         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3139         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3140         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3141         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3142         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3143         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3144         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3145         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3146         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3147         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3148         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3149         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3150         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3151         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3152         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3153         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3154         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3155         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3156         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3157         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3158         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3159         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3160         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3161         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3162         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3163         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3164         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3165
3166 2019-07-10  Tom Tromey  <tromey@adacore.com>
3167
3168         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3169         * breakpoint.c (init_ada_exception_breakpoint): Register as
3170         bp_catchpoint.
3171         (print_one_breakpoint_location, print_one_breakpoint): Use
3172         is_ada_exception_catchpoint.
3173         * ada-lang.c (class ada_catchpoint_location): Pass
3174         bp_loc_software_breakpoint to bp_location constructor.
3175         (is_ada_exception_catchpoint): New function.
3176
3177 2019-07-10  Tom Tromey  <tromey@adacore.com>
3178
3179         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3180         VEC.
3181         (struct arm_exidx_entry): New method operator<.
3182         (struct arm_exidx_data) <section_maps>: Change type.
3183         (arm_exidx_data_free): Remove.
3184         (arm_exidx_data_key): Change type.  Move lower.
3185         (arm_exidx_new_objfile): Update.
3186         (arm_compare_exidx_entries): Remove.
3187         (arm_find_exidx_entry, _initialize_arm_tdep)
3188
3189 2019-07-10  Tom Tromey  <tromey@adacore.com>
3190
3191         * solib-spu.c (ocl_program_data_key): Change type.
3192         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3193         Update.
3194
3195 2019-07-10  Tom Tromey  <tromey@adacore.com>
3196
3197         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3198         (struct solib_aix_inferior_data) <library_list>: Change type.
3199         (solib_aix_inferior_data_handle): Change type.
3200         (get_solib_aix_inferior_data): Update.
3201         (solib_aix_free_library_list): Remove.
3202         (library_list_start_library): Update.
3203         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3204         return type.
3205         (solib_aix_get_library_list)
3206         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3207         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3208
3209 2019-07-10  Tom Tromey  <tromey@adacore.com>
3210
3211         * solib-dsbt.c (struct dsbt_info): Add initializers.
3212         (solib_dsbt_pspace_data): Change type.
3213         (dsbt_pspace_data_cleanup): Remove.
3214         (get_dsbt_info, _initialize_dsbt_solib): Update.
3215
3216 2019-07-10  Tom Tromey  <tromey@adacore.com>
3217
3218         * spu-tdep.c (spu_overlay_data): Change type.
3219         (spu_get_overlay_table, spu_overlay_new_objfile)
3220         (_initialize_spu_tdep): Update.
3221
3222 2019-07-10  Tom Tromey  <tromey@adacore.com>
3223
3224         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3225         destructor.
3226         (dbx_objfile_data_key): Change type and declare later.
3227         (DBX_SYMFILE_INFO): Rewrite.
3228         * dbxread.c (dbx_objfile_data_key): Change type.
3229         (dbx_symfile_init): Update.
3230         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3231         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3232         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3233
3234 2019-07-10  Tom Tromey  <tromey@adacore.com>
3235
3236         * jit.c (jit_program_space_key): Change type.  Move lower.
3237         (get_jit_program_space_data): Update.
3238         (jit_program_space_data_cleanup): Remove.
3239         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3240         Update.
3241         (struct jit_program_space_data): Add initializers.
3242
3243 2019-07-10  Tom Tromey  <tromey@adacore.com>
3244
3245         * solib-darwin.c (struct darwin_info): Add initializers.
3246         (solib_darwin_pspace_data): Change type.
3247         (darwin_pspace_data_cleanup): Remove.
3248         (get_darwin_info, _initialize_darwin_solib): Update.
3249
3250 2019-07-10  Tom Tromey  <tromey@adacore.com>
3251
3252         * remote-sim.c (struct sim_inferior_data): Add initializers,
3253         constructor, and destructor.
3254         (sim_inferior_data_key): Change type.  Move lower.
3255         (check_for_duplicate_sim_descriptor): Update.
3256         (get_sim_inferior_data): Use new.  Update.
3257         (~sim_inferior_data_cleanup): Rename from
3258         sim_inferior_data_cleanup.  Simplify.
3259         (gdbsim_close_inferior, simulator_command)
3260         (sim_command_completer, _initialize_remote_sim): Update.
3261         (next_pid, INITIAL_PID): Move earlier.
3262
3263 2019-07-10  Tom Tromey  <tromey@adacore.com>
3264
3265         * python/python-internal.h (create_thread_object): Return
3266         gdbpy_ref.
3267         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3268         * python/py-inferior.c (struct threadlist_entry): Add
3269         constructor.
3270         <thread_obj>: Now a gdbpy_ref.
3271         (thread_to_thread_object): Update.
3272         (add_thread_object): Use new.
3273         (delete_thread_object): Use delete.
3274         (infpy_threads): Update.
3275         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3276         GIL.
3277
3278 2019-07-10  Tom Tromey  <tromey@adacore.com>
3279
3280         * valops.c (value_cast): Specialize error message for Ada.
3281
3282 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3283
3284         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3285
3286 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3287
3288         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3289         bpstat_should_step): Return bool, adjust comments.
3290         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3291         bpstat_should_step): Likewise.
3292
3293 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3294
3295         * features/Makefile: Use feature target descriptions for Arm.
3296         * features/arm/arm-core.c: Generate new file.
3297         * features/arm/arm-fpa.c: Likewise.
3298         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3299         * features/arm/arm-m-profile.c: Likewise.
3300         * features/arm/arm-vfpv2.c: Likewise.
3301         * features/arm/arm-vfpv3.c: Likewise.
3302         * features/arm/xscale-iwmmxt.c: Likewise.
3303         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3304
3305 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3306
3307         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3308         ptrace earlier.
3309
3310 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3311
3312         * features/aarch64-pauth.c: Regenerate.
3313
3314 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3315
3316         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3317         bool.
3318         (bpstat_what): Use false instead of 0.
3319
3320 2019-07-09  Pedro Alves  <palves@redhat.com>
3321
3322         * break-catch-throw.c (is_exception_catchpoint): New.
3323         * breakpoint.c (print_one_breakpoint_location): New parameter
3324         'raw_loc'.  Handle it.  Use
3325         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3326         looking at the breakpoint's type.
3327         (print_one_breakpoint): If handling "maint info breakpoints", also
3328         print locations of exception catchpoints.
3329         * breakpoint.h (is_exception_catchpoint): Declare.
3330
3331 2019-07-09  Pedro Alves  <palves@redhat.com>
3332
3333         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3334         "addr" field.
3335         (allocate_location_exception_catchpoint): New.
3336         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3337         (initialize_throw_catchpoint_ops): Install
3338         allocate_location_exception_catchpoint as allocate_location
3339         method.
3340         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3341         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3342         bp_loc_other.
3343         (breakpoint_address_is_meaningful): Delete.
3344         (bl_address_is_meaningful): New.
3345         (breakpoint_locations_match): Adjust comment.
3346         (bp_location_from_bp_type): New, factored out of...
3347         (bp_location::bp_location(breakpoint *)): ... this.
3348         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3349         factored out of...
3350         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3351         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3352         breakpoint_address_is_meaningful.
3353         (bp_locations_compare): Adjust comment.
3354         (update_global_location_list): Use bl_address_is_meaningful
3355         instead of breakpoint_address_is_meaningful.
3356         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3357         explicit.
3358         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3359         * python/py-breakpoint.c (bppy_get_location): No longer check
3360         whether location is null.
3361
3362 2019-07-09  Pedro Alves  <palves@redhat.com>
3363
3364         PR c++/15468
3365         * breakpoint.c (print_one_breakpoint_location): Remove
3366         single-location assert.
3367
3368 2019-07-09  Tom Tromey  <tom@tromey.com>
3369
3370         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3371         * configure: Rebuild.
3372         * configure.ac: Change common to gdbsupport.
3373         * gdbsupport: Rename from common.
3374         * acinclude.m4: Change common to gdbsupport.
3375         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3376         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3377         gdbsupport.
3378         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3379         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3380         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3381         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3382         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3383         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3384         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3385         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3386         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3387         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3388         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3389         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3390         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3391         coff-pe-read.c, command.h, compile/compile-c-support.c,
3392         compile/compile-c.h, compile/compile-cplus-symbols.c,
3393         compile/compile-cplus-types.c, compile/compile-cplus.h,
3394         compile/compile-loc2c.c, compile/compile.c, completer.c,
3395         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3396         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3397         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3398         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3399         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3400         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3401         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3402         features/aarch64-core.c, features/aarch64-fpu.c,
3403         features/aarch64-pauth.c, features/aarch64-sve.c,
3404         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3405         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3406         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3407         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3408         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3409         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3410         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3411         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3412         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3413         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3414         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3415         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3416         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3417         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3418         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3419         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3420         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3421         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3422         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3423         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3424         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3425         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3426         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3427         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3428         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3429         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3430         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3431         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3432         minsyms.c, mips-linux-tdep.c, namespace.h,
3433         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3434         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3435         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3436         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3437         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3438         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3439         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3440         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3441         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3442         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3443         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3444         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3445         procfs.c, producer.c, progspace.h, psymtab.h,
3446         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3447         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3448         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3449         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3450         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3451         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3452         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3453         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3454         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3455         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3456         target-memory.c, target.c, target.h, target/waitstatus.c,
3457         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3458         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3459         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3460         unittests/array-view-selftests.c,
3461         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3462         unittests/common-utils-selftests.c,
3463         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3464         unittests/format_pieces-selftests.c,
3465         unittests/function-view-selftests.c,
3466         unittests/lookup_name_info-selftests.c,
3467         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3468         unittests/mkdir-recursive-selftests.c,
3469         unittests/observable-selftests.c,
3470         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3471         unittests/parse-connection-spec-selftests.c,
3472         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3473         unittests/scoped_fd-selftests.c,
3474         unittests/scoped_mmap-selftests.c,
3475         unittests/scoped_restore-selftests.c,
3476         unittests/string_view-selftests.c, unittests/style-selftests.c,
3477         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3478         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3479         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3480         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3481         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3482         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3483
3484 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3485
3486         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3487         bool value.
3488         (decode_digits_ordinary): Set explicit_line field in sal.
3489         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3490         symtab_and_line that was set on an explicit line number in
3491         assembler code.  Do always update the recorded symtab and line if
3492         we do skip the prologue.
3493
3494 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3495
3496         * breakpoint.c (set_breakpoint_location_function): Remove
3497         explicit_loc parameter.
3498         (momentary_breakpoint_from_master): Update call to
3499         set_breakpoint_location_function.
3500         (add_location_to_breakpoint): Likewise.
3501
3502 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3505         required features based on default bfd type when no specific bfd
3506         is present.
3507
3508 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3509
3510         * NEWS: Mention that GDB printf and eval commands can now print
3511         C-style and Ada-style convenience var strings without
3512         calling the inferior.
3513         * printcmd.c (printf_c_string): Locally print GDB internal var
3514         instead of transiting via the inferior.
3515         (printf_wide_c_string): Likewise.
3516
3517 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3518
3519         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3520
3521 2019-07-04  Tom Tromey  <tom@tromey.com>
3522
3523         PR tui/24724:
3524         * tui/tui-winsource.c (tui_clear_source_content): Update.
3525         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3526         (tui_update_breakpoint_info): Update.
3527         (tui_set_exec_info_content): Update.
3528         * tui/tui-source.c (tui_set_source_content_nil): Update.
3529         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3530         has_break.
3531         * tui/tui-data.h (enum tui_bp_flag): New.
3532         (tui_bp_flags): New enum flags type.
3533         (struct tui_source_element) <break_mode>: Change type.  Rename
3534         from has_break.
3535         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3536         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3537         constants.
3538         * tui/tui-winsource.h: Fix comment.
3539
3540 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3541
3542         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3543         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3544         (store_fpregs_to_thread)
3545         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3546         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3547         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3548         (IWMMXT_REGS_SIZE): Add define.
3549         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3550         (fetch_vfp_regs, store_vfp_regs)
3551         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3552         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3553
3554 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3555
3556         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3557         defines.
3558         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3559         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3560         (ARM_INT_REGISTER_SIZE): ...to this.
3561         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3562         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3563         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3564         (arm_linux_collect_gregset, supply_nwfpe_register)
3565         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3566         defines.
3567         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3568         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3569         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3570         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3571         (arm_return_in_memory, arm_store_return_value)
3572         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3573         (arm_record_ld_st_multiple): Likewise.
3574         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3575         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3576
3577 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3578
3579         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3580         AARCH64_DISPLACED_MODIFIED_INSNS.
3581         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3582         (aarch64_displaced_step_copy_insn): Likewise.
3583         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3584         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3585         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3586         ARM_DISPLACED_MODIFIED_INSNS.
3587         * arm-tdep.c (arm_gdbarch_init): Likewise.
3588         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3589         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3590         (struct arm_displaced_step_closure): Use
3591         ARM_DISPLACED_MODIFIED_INSNS.
3592
3593 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3594
3595         * features/Makefile: Remove unused xml files.
3596         * features/aarch64.xml: Remove.
3597         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3598         * features/i386/amd64-avx-avx512.xml: Remove.
3599         * features/i386/amd64-avx-linux.xml: Remove.
3600         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3601         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3602         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3603         * features/i386/amd64-avx-mpx.xml: Remove.
3604         * features/i386/amd64-avx.xml: Remove.
3605         * features/i386/amd64-linux.xml: Remove.
3606         * features/i386/amd64-mpx-linux.xml: Remove.
3607         * features/i386/amd64-mpx.xml: Remove.
3608         * features/i386/amd64.xml: Remove.
3609         * features/i386/i386-avx-avx512-linux.xml: Remove.
3610         * features/i386/i386-avx-avx512.xml: Remove.
3611         * features/i386/i386-avx-linux.xml: Remove.
3612         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3613         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3614         * features/i386/i386-avx-mpx-linux.xml: Remove.
3615         * features/i386/i386-avx-mpx.xml: Remove.
3616         * features/i386/i386-avx.xml: Remove.
3617         * features/i386/i386-linux.xml: Remove.
3618         * features/i386/i386-mmx-linux.xml: Remove.
3619         * features/i386/i386-mmx.xml: Remove.
3620         * features/i386/i386-mpx-linux.xml: Remove.
3621         * features/i386/i386-mpx.xml: Remove.
3622         * features/i386/i386.xml: Remove.
3623         * features/i386/x32-avx-avx512-linux.xml: Remove.
3624         * features/i386/x32-avx-linux.xml: Remove.
3625         * features/i386/x32-linux.xml: Remove.
3626
3627 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3628
3629         * regformats/aarch64.dat: Remove.
3630         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3631         * regformats/i386/amd64-avx-linux.dat: Remove.
3632         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3633         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3634         * regformats/i386/amd64-linux.dat: Remove.
3635         * regformats/i386/amd64-mpx-linux.dat: Remove.
3636         * regformats/i386/amd64.dat: Remove.
3637         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3638         * regformats/i386/i386-avx-linux.dat: Remove.
3639         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3640         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3641         * regformats/i386/i386-linux.dat: Remove.
3642         * regformats/i386/i386-mmx-linux.dat: Remove.
3643         * regformats/i386/i386-mpx-linux.dat: Remove.
3644         * regformats/i386/i386.dat: Remove.
3645         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3646         * regformats/i386/x32-avx-linux.dat: Remove.
3647         * regformats/i386/x32-linux.dat: Remove.
3648
3649 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3650
3651         * aarch64-tdep.c: Remove xml self tests.
3652         * amd64-linux-tdep.c: Likewise.
3653         * amd64-tdep.c: Likewise.
3654         * i386-linux-tdep.c: Likewise.
3655         * i386-tdep.c: Likewise.
3656
3657 2019-07-03  Pedro Alves  <palves@redhat.com>
3658
3659         PR cli/24732
3660         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3661         (pipe_cmd_option_defs): New.
3662         (make_pipe_cmd_options_def_group): New.
3663         (pipe_command): Use gdb::option::process_options.
3664         (pipe_command_completer): New function.
3665         (_initialize_cli_cmds): Install completer for "pipe" command.
3666
3667 2019-07-03  Pedro Alves  <palves@redhat.com>
3668
3669         * cli/cli-option.c (union option_value) <string>: New field.
3670         (struct option_def_and_value): Add ctor, move ctor, dtor and
3671         use DISABLE_COPY_AND_ASSIGN.
3672         (option_def_and_value::clear_value): New.
3673         (parse_option, save_option_value_in_ctx, get_val_type_str)
3674         (add_setshow_cmds_for_options): Handle var_string.
3675         * cli-option.h (union option_def::var_address) <string>: New
3676         field.
3677         (struct string_option_def): New.
3678         * maint-test-options.c (struct test_options_opts): Add default
3679         ctor and use DISABLE_COPY_AND_ASSIGN.
3680         <string_opt>: New field.
3681         (test_options_opts::~test_options_opts): New.
3682         (test_options_opts::dump): Also dump "-string".
3683         (test_options_option_defs): Install "string.
3684
3685 2019-07-03  Pedro Alves  <palves@redhat.com>
3686
3687         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3688         option_value with a null enumeration.
3689         (complete_options): Save the option values in the context.
3690         (save_option_value_in_ctx): New, factored out from ...
3691         (process_options): ... here.
3692         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3693         of the function.
3694         * maint-test-options.c (test_options_opts::dump): New, factored
3695         out from ...
3696         (maintenance_test_options_command_mode): ... here.
3697         (maintenance_test_options_command_completion_result): Delete.
3698         (maintenance_test_options_command_completion_text): Update
3699         comment.
3700         (maintenance_show_test_options_completion_result): Change
3701         prototype.  Just print
3702         maintenance_test_options_command_completion_text.
3703         (save_completion_result): New.
3704         (maintenance_test_options_completer_mode): Pass options context to
3705         complete_options, and then save a dump.
3706         (_initialize_maint_test_options): Use add_cmd to install "maint
3707         show test-options-completion-result".
3708
3709 2019-07-03  Pedro Alves  <palves@redhat.com>
3710
3711         * NEWS (New commands): Mention "with" and "maint with".
3712         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3713         (with_command, with_command_completer): New.
3714         (pipe_command): Adjust to new repeat_previous
3715         interface.
3716         (_initialize_cli_cmds): Install the "with" command and its "w"
3717         alias.
3718         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3719         declarations.
3720         * cli/cli-setshow.c (parse_cli_var_uinteger)
3721         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3722         argument strings for all var_types.
3723         (get_setshow_command_value_string): New, factored out from ...
3724         (do_show_command): ... this.
3725         * cli/cli-setshow.h: Include <string>.
3726         (get_setshow_command_value_string): Declare.
3727         * command.h (repeat_previous): Now returns const char *.  Adjust
3728         comment.
3729         * maint.c: Include "cli/cli-cmds.h".
3730         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3731         (_initialize_maint_cmds): Register the "maintenance with" command.
3732         * top.c (repeat_previous): Move bits from pipe_command here:
3733         Return the saved command line, if any; error out if there's no
3734         command to relaunch.
3735
3736 2019-07-03  Pedro Alves  <palves@redhat.com>
3737
3738         * NEWS (New commands): Mention "maint set/show test-settings"
3739         instead of "maint test-settings".
3740         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3741         (maintenance_test_settings_set_list): Rename to ...
3742         (maintenance_set_test_settings_list): ... this.
3743         (maintenance_test_settings_show_list): Rename to  ...
3744         (maintenance_show_test_settings_list): ... this.
3745         (maintenance_test_settings_cmd): Delete.
3746         (maintenance_test_settings_set_cmd): ...
3747         (maintenance_set_test_settings_cmd): ... this.
3748         (maintenance_test_settings_show_cmd): ...
3749         (maintenance_show_test_settings_cmd): ... this.
3750         (maintenance_test_settings_show_value_cmd):
3751         (maintenance_show_test_settings_value_cmd): ... this.
3752         (_initialize_maint_test_settings): No longer install the "maint
3753         test-settings" prefix command.  Rename "maint test-settings set"
3754         to "maint set test-settings", and "maint test-settings show" to
3755         "maint show test-settings".  Adjust all subcommands.
3756
3757 2019-07-03  Pedro Alves  <palves@redhat.com>
3758
3759         * maint-test-settings.c: Fix file's intro comment.  Replace all
3760         references to "test-options" with references to "test-settings",
3761         in comments.
3762
3763 2019-07-03  Pedro Alves  <palves@redhat.com>
3764
3765         * maint-test-settings.c (maintenance_test_settings_xxx)
3766         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3767         New.
3768         (maintenance_test_settings_enums): Use them.
3769         (maintenance_test_settings_enum): Default to
3770         maintenance_test_settings_xxx.
3771         (_initialize_maint_test_settings): Initialize
3772         MAINTENANCE_TEST_SETTINGS_FILENAME.
3773
3774 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3775
3776         * breakpoint.h (remove_breakpoints_inf): Change return type to
3777         void, move function documentation here.
3778         * breakpoint.c (remove_breakpoints_inf): Change return type to
3779         void, move function documentation to header.
3780
3781 2019-07-02  Pedro Alves  <palves@redhat.com>
3782
3783         * NEWS (Completion improvements): Mention "info threads".
3784         * thread.c (struct info_threads_opts, info_threads_option_defs)
3785         (make_info_threads_options_def_group): New.
3786         (info_threads_command): Use gdb::option::process_options.
3787         (info_threads_command_completer): New.
3788         (_initialize_thread): Use gdb::option::build_help to build the
3789         help text for "info threads".
3790
3791 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3792
3793         * defs.h (generic_load): Move from here...
3794         * symfile.h (generic_load): ... to here.  Rename name parameter
3795         to args.
3796         * symfile.c (generic_load): Add comment.
3797
3798 2019-07-01  Tom Tromey  <tromey@adacore.com>
3799
3800         * dwarf2read.c
3801         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3802         declaration of without_params.  Fix formatting.
3803
3804 2019-07-01  Tom Tromey  <tromey@adacore.com>
3805
3806         * ada-exp.y (find_primitive_type): Update.
3807         * ada-lang.h (ada_lookup_symbol): Update.
3808         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3809         parameter.
3810         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3811
3812 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3813
3814         PR breakpoints/24541
3815         * gdbarch.c: Regenerate.
3816         * gdbarch.h: Regenerate.
3817         * gdbarch.sh: Add 'stap_adjust_register'.
3818         * i386-tdep.c: Include '<unordered_set>'.
3819         (i386_stap_adjust_register): New function.
3820         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3821         * stap-probe.c (stap_parse_register_operand): Call
3822         'gdbarch_stap_adjust_register'.
3823
3824 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3825
3826         PR python/24742
3827         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3828         * python/python.c (do_start_initialization): Use 'xmalloc'
3829         instead of 'PyMem_Malloc'.
3830
3831 2019-06-28  Tom Tromey  <tromey@adacore.com>
3832
3833         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3834         for Ada.
3835
3836 2019-06-27  Tom Tromey  <tromey@adacore.com>
3837
3838         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3839         objfile_key.
3840         (arm_find_mapping_symbol, arm_record_special_symbol)
3841         (_initialize_arm_tdep): Update.
3842         (arm_objfile_data_free): Remove.
3843
3844 2019-06-27  Tom Tromey  <tromey@adacore.com>
3845
3846         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3847         to cp_print_static_field.
3848
3849 2019-06-26  Tom Tromey  <tromey@adacore.com>
3850
3851         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3852         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3853         declare.
3854
3855 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3856
3857         * features/aarch64-core.c (create_feature_aarch64_core):
3858         Regenerate.
3859         * features/aarch64-core.xml: Add cpsr flags.
3860
3861 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3862
3863         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3864         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3865
3866 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3867
3868         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3869         field.
3870         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3871         use.
3872         (arm_record_special_symbol): Don't insert new symbol in sorted
3873         position, push it at the end.
3874
3875 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3876
3877         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3878         (arm_mapping_symbol_s): Remove.
3879         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3880         (arm_mapping_symbol_vec): New typedef.
3881         (struct arm_per_objfile): Add constructor.
3882         <section_maps>: Change type to
3883         std::unique_ptr<arm_mapping_symbol_vec[]>.
3884         (arm_compare_mapping_symbols): Remove.
3885         (arm_find_mapping_symbol): Adjust to section_maps type change.
3886         (arm_objfile_data_free): Call delete on arm_per_objfile.
3887         (arm_record_special_symbol): Adjust to section_maps type change.
3888         Allocate arm_per_objfile with new.
3889
3890 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3891
3892         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3893         with the command prefix.
3894
3895 2019-06-25  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3898         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3899
3900 2019-06-25  Tom Tromey  <tom@tromey.com>
3901
3902         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3903         type.
3904         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3905         protected.
3906
3907 2019-06-25  Tom Tromey  <tom@tromey.com>
3908
3909         * tui/tui-winsource.c
3910         (tui_source_window_base::set_is_exec_point_at): Add check against
3911         LOA_ADDRESS.
3912
3913 2019-06-25  Tom Tromey  <tom@tromey.com>
3914
3915         * tui/tui-source.c (tui_set_source_content): Don't check before
3916         xfree.
3917         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3918
3919 2019-06-25  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui-winsource.h (tui_update_source_window_as_is)
3922         (tui_alloc_source_buffer, tui_line_is_displayed)
3923         (tui_addr_is_displayed): Change type of win_info.
3924         * tui/tui-winsource.c (tui_update_source_window_as_is)
3925         (tui_clear_source_content, tui_show_source_line)
3926         (tui_show_source_content, tui_source_window_base::refill)
3927         (tui_source_window_base::set_is_exec_point_at)
3928         (tui_source_window_base::set_is_exec_point_at)
3929         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3930         (tui_alloc_source_buffer, tui_line_is_displayed)
3931         (tui_addr_is_displayed): Change type of win_info.  Update.
3932         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3933         (tui_source_window_base::do_make_visible_with_new_height):
3934         Update.
3935         * tui/tui-source.c (tui_set_source_content)
3936         (tui_set_source_content_nil)
3937         (tui_source_window::do_scroll_vertical): Update.
3938         * tui/tui-layout.c (show_layout): Update.
3939         * tui/tui-disasm.c (tui_set_disassem_content)
3940         (tui_disasm_window::do_scroll_vertical): Update.
3941         * tui/tui-data.h (tui_win_content): Remove.
3942         (struct tui_gen_win_info) <content, content_size>: Remove.
3943         (struct tui_source_element): Add initializers and destructor.
3944         (union tui_which_element, struct tui_win_element): Remove.
3945         (struct tui_source_window_base) <content>: New field.
3946         (struct tui_data_window): Remove destructor.
3947         (tui_alloc_content, tui_free_win_content)
3948         (tui_free_all_source_wins_content): Don't declare.
3949         * tui/tui-data.c (tui_initialize_static_data): Update.
3950         (init_content_element, tui_alloc_content): Remove.
3951         (~tui_gen_win_info): Update.
3952         (~tui_data_window, tui_free_all_source_wins_content)
3953         (tui_free_win_content, free_content, free_content_elements):
3954         Remove.
3955
3956 2019-06-25  Tom Tromey  <tom@tromey.com>
3957
3958         * tui/tui-winsource.h (tui_clear_source_content)
3959         (tui_erase_source_content, tui_show_source_content): Change type
3960         of win_info.
3961         * tui/tui-winsource.c (tui_clear_source_content)
3962         (tui_erase_source_content, tui_show_source_content): Change type
3963         of win_info.
3964         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3965         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3966         win_info.
3967         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3968         win_info.
3969         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3970
3971 2019-06-25  Tom Tromey  <tom@tromey.com>
3972
3973         * tui/tui-winsource.c (tui_clear_source_content)
3974         (tui_source_window_base::set_is_exec_point_at): Update.
3975         * tui/tui-source.c (tui_set_source_content_nil): Update.
3976         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3977         a bool.
3978         * tui/tui-data.c (init_content_element): Update.
3979
3980 2019-06-25  Tom Tromey  <tom@tromey.com>
3981
3982         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3983         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3984         * tui/tui-layout.c (init_and_make_win): Update.
3985         * tui/tui.h (enum tui_win_type): Update.
3986         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3987         tui_win_is_auxillary.
3988         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3989         tui_win_is_auxillary.
3990
3991 2019-06-25  Tom Tromey  <tom@tromey.com>
3992
3993         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3994         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3995         (tui_delete_data_content_windows, tui_display_all_data)
3996         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3997         Update.
3998         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3999         * tui/tui-regs.c (tui_last_regs_line_no)
4000         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4001         (tui_show_registers): Update.
4002         (tui_show_register_group): Return void.  Update.
4003         (tui_display_registers_from, tui_display_reg_element_at_line)
4004         (tui_display_registers_from_line, tui_check_register_values):
4005         Update.
4006         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4007         member.
4008         (struct tui_data_window) <regs_content>: Now a std::vector.
4009         <regs_content_count>: Remove.
4010         (tui_add_content_elements, tui_free_data_content): Don't declare.
4011         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4012         (init_content_element): Remove DATA_WIN case.  Add assert.
4013         (tui_add_content_elements): Remove.
4014         (tui_data_window): Update.
4015         (tui_free_data_content): Remove.
4016         (free_content_elements): Remove DATA_WIN case.
4017
4018 2019-06-25  Tom Tromey  <tom@tromey.com>
4019
4020         * tui/tui-data.c (tui_data_item_window): Update.
4021         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4022         * tui/tui-windata.c (tui_display_all_data)
4023         (tui_display_data_from_line): Update.
4024         (tui_check_data_values): Remove.
4025         * tui/tui-regs.c (tui_show_register_group)
4026         (tui_display_reg_element_at_line): Update.
4027         * tui/tui-hooks.c (tui_register_changed)
4028         (tui_refresh_frame_and_register_information): Call
4029         tui_check_register_values.
4030         * tui/tui-data.h (struct tui_data_window) <data_content,
4031         data_content_count, data_type>: Remove.
4032         (enum tui_data_type): Remove.
4033
4034         * tui/tui-data.c (tui_data_window::clear_detail)
4035         (~tui_data_window): Update.
4036
4037 2019-06-25  Tom Tromey  <tom@tromey.com>
4038
4039         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4040         declare.
4041         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4042         Rename from tui_first_data_item_displayed.  Update.
4043         (tui_data_window::refresh_all)
4044         (tui_data_window::do_scroll_vertical): Update.
4045         * tui/tui-data.h (struct tui_data_window)
4046         <first_data_item_displayed>: Declare new method.
4047
4048 2019-06-25  Tom Tromey  <tom@tromey.com>
4049
4050         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4051         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4052         contents...
4053         (tui_initialize_static_data): ...here.
4054
4055 2019-06-25  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4058         (tui_display_registers_from, tui_check_register_values): Update.
4059         (tui_display_register): Remove win_info parameter; update.
4060         (tui_get_register): Change type of parameters.
4061         * tui/tui-data.h (struct tui_data_element): Remove.
4062         (union tui_which_element) <data>: Remove.
4063         <data_window>: Change type.
4064         (struct tui_data_item_window): New.
4065         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4066         case.  Add assert.
4067         (~tui_data_item_window): New destructor.
4068         (free_content_elements): Remove DATA_ITEM_WIN case.
4069
4070 2019-06-25  Tom Tromey  <tom@tromey.com>
4071
4072         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4073         Remove.
4074
4075 2019-06-25  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-data.h (struct tui_command_element): Remove.
4078         (union tui_which_element) <command>: Remove.
4079         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4080         assert.
4081         (free_content_elements): Remove CMD_WIN case.
4082
4083 2019-06-25  Tom Tromey  <tom@tromey.com>
4084
4085         * tui/tui-layout.c (tui_set_layout): Update.
4086         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4087         * tui/tui-data.c (layout_def): Update.
4088
4089 2019-06-25  Tom Tromey  <tom@tromey.com>
4090
4091         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4092         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4093         (tui_source_window_base::set_new_height): Update.
4094         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4095         Update.
4096         (tui_set_locator_fullname, tui_set_locator_info)
4097         (tui_show_frame_info): Update.
4098         * tui/tui-source.c (tui_set_source_content)
4099         (tui_source_is_displayed): Update.
4100         * tui/tui-layout.c (show_source_disasm_command, show_data)
4101         (show_source_or_disasm_and_command): Update.
4102         * tui/tui-disasm.c (tui_set_disassem_content)
4103         (tui_get_begin_asm_address): Update.
4104         * tui/tui-data.h (struct tui_locator_element): Remove.
4105         (union tui_which_element) <locator>: Remove.
4106         (struct tui_locator_window): New.
4107         (tui_locator_win_info_ptr): Change return type.
4108         * tui/tui-data.c (_locator): Change type.
4109         (tui_locator_win_info_ptr): Change return type.
4110         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4111         (tui_alloc_content): Add assert.
4112
4113 2019-06-25  Tom Tromey  <tom@tromey.com>
4114
4115         * tui/tui-winsource.c
4116         (tui_exec_info_window::maybe_allocate_content): New method.
4117         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4118         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4119         (make_source_or_disasm_window): Add cast.
4120         * tui/tui-data.h (union tui_which_element) <simple_string>:
4121         Remove.
4122         (struct tui_source_info): New.
4123         (struct tui_source_window_base) <execution_info>: Change type.
4124         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4125         case, and add assert.
4126         (tui_alloc_content): Add assert.
4127
4128 2019-06-25  Tom Tromey  <tom@tromey.com>
4129
4130         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4131         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4132         * tui/tui-data.c (tui_alloc_win_info): Remove.
4133
4134 2019-06-25  Tom Tromey  <tom@tromey.com>
4135
4136         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4137         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4138         can_highlight.
4139
4140 2019-06-25  Tom Tromey  <tom@tromey.com>
4141
4142         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4143         make_visible_with_new_height method.
4144         (tui_win_info::make_visible_with_new_height): New method.
4145         (tui_source_window_base::do_make_visible_with_new_height)
4146         (tui_data_window::do_make_visible_with_new_height)
4147         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4148         (make_visible_with_new_height): Remove.
4149         (tui_resize_all, tui_adjust_win_heights): Use
4150         make_visible_with_new_height method.
4151         * tui/tui-data.h (struct tui_win_info)
4152         <do_make_visible_with_new_height, make_visible_with_new_height>:
4153         New methods.
4154         (struct tui_source_window_base, struct tui_data_window)
4155         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4156         methods.
4157
4158 2019-06-25  Tom Tromey  <tom@tromey.com>
4159
4160         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4161         method.
4162         (update_tab_width): Call update_tab_width method.
4163         * tui/tui-data.h (struct tui_win_info)
4164         (struct tui_source_window_base) <update_tab_width>: New methods.
4165
4166 2019-06-25  Tom Tromey  <tom@tromey.com>
4167
4168         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4169         parameter.
4170         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4171         parameter.
4172         (tui_gen_win_info::make_visible): Update.
4173         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4174         parameter.
4175         * tui/tui-data.h (enum tui_box): New enum.
4176         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4177
4178 2019-06-25  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4181         init_and_make_win for EXEC_INFO_WIN.
4182         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4183         longer inline.
4184         (struct tui_win_info) <~tui_win_info>: Inline.
4185         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4186         Don't declare.
4187         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4188         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4189         Remove.
4190         (tui_initialize_static_data): Update.
4191         (~tui_gen_win_info): Handle more cleanup here.
4192         (~tui_source_window_base): Delete "execution_info".
4193         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4194
4195 2019-06-25  Tom Tromey  <tom@tromey.com>
4196
4197         * tui/tui-layout.c (make_command_window): Don't set
4198         can_highlight.
4199         (show_source_disasm_command): Call the reset method.
4200         (show_data): Don't set can_highlight.  Call the reset method.
4201         (tui_gen_win_info::reset): Rename from init_gen_win_info
4202         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4203         (show_source_or_disasm_and_command): Call the reset method.
4204         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4205         (struct tui_cmd_window): Set can_highlight.
4206
4207 2019-06-25  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4210         from make_visible.
4211         (tui_make_visible, tui_make_invisible): Rewrite.
4212         (tui_win_info::make_visible): Remove.
4213         (tui_source_window_base::make_visible): Update.
4214         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4215         method.  Moved from...
4216         (struct tui_win_info) <make_visible>: ...here.
4217
4218 2019-06-25  Tom Tromey  <tom@tromey.com>
4219
4220         * tui/tui-winsource.c
4221         (tui_source_window_base::do_scroll_horizontal): Remove direction
4222         parameter.
4223         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4224         direction parameter.
4225         * tui/tui-win.c (tui_win_info::forward_scroll)
4226         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4227         (tui_win_info::right_scroll): Update.
4228         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4229         direction parameter.
4230         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4231         direction parameter.
4232         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4233         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4234         Remove direction parameter.
4235         (struct tui_source_window_base, struct tui_source_window)
4236         (struct tui_disasm_window, struct tui_data_window)
4237         (struct tui_cmd_window): Update.
4238
4239 2019-06-25  Tom Tromey  <tom@tromey.com>
4240
4241         * tui/tui-winsource.h (tui_set_exec_info_content)
4242         (tui_show_exec_info_content, tui_erase_exec_info_content)
4243         (tui_clear_exec_info_content, tui_update_exec_info): Change
4244         argument to tui_source_window_base.
4245         * tui/tui-winsource.c (tui_set_exec_info_content)
4246         (tui_show_exec_info_content, tui_erase_exec_info_content)
4247         (tui_clear_exec_info_content, tui_update_exec_info): Change
4248         argument to tui_source_window_base.
4249
4250 2019-06-25  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4253         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4254
4255 2019-06-25  Tom Tromey  <tom@tromey.com>
4256
4257         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4258         check.
4259
4260 2019-06-25  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4263         type to void.
4264         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4265         type to void.
4266         * tui/tui-source.c (tui_set_source_content): Update.
4267         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4268
4269 2019-06-25  Tom Tromey  <tom@tromey.com>
4270
4271         * tui/tui-win.c (window_name_completer, tui_set_focus)
4272         (tui_all_windows_info): Use name method.
4273         * tui/tui-data.h (struct tui_gen_win_info)
4274         (struct tui_source_window, struct tui_disasm_window)
4275         (struct tui_data_window, struct tui_cmd_window) <name>: New
4276         method.
4277         (tui_win_name): Don't declare.
4278         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4279         (tui_win_name): Remove.
4280
4281 2019-06-25  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-winsource.h (tui_update_source_window)
4284         (tui_update_source_window_as_is): Change parameter type.
4285         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4286         to be a tui_source_window_base.
4287         (tui_update_source_window_as_is): Likewise.
4288         * tui/tui-win.c (make_visible_with_new_height): Update.
4289
4290 2019-06-25  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-winsource.c (tui_erase_source_content)
4293         (tui_show_source_content, tui_show_exec_info_content)
4294         (tui_erase_exec_info_content): Use refresh_window method.
4295         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4296         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4297         from tui_refresh_win.
4298         (tui_data_window::refresh_window): New method.
4299         (tui_win_info::refresh, tui_source_window_base::refresh)
4300         (tui_refresh_all): Use refresh_window method.
4301         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4302         method.
4303         * tui/tui-regs.c (tui_display_register): Call refresh_window
4304         method.
4305         * tui/tui-layout.c (show_source_disasm_command)
4306         (show_source_or_disasm_and_command): Call refresh_window method.
4307         * tui/tui-data.h (struct tui_gen_win_info)
4308         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4309         New method.
4310
4311 2019-06-25  Tom Tromey  <tom@tromey.com>
4312
4313         * tui/tui.c (tui_rl_other_window, tui_enable)
4314         (tui_is_window_visible, tui_get_command_dimension): Update.
4315         * tui/tui-winsource.c (tui_update_source_window_as_is)
4316         (tui_clear_source_content, tui_erase_source_content)
4317         (tui_show_source_line, tui_source_window_base::refill)
4318         (tui_source_window_base::do_scroll_horizontal)
4319         (tui_source_window_base::set_is_exec_point_at)
4320         (tui_update_breakpoint_info, tui_set_exec_info_content)
4321         (tui_alloc_source_buffer, tui_line_is_displayed)
4322         (tui_addr_is_displayed): Update.
4323         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4324         (tui_check_and_display_highlight_if_needed)
4325         (tui_win_info::make_visible, tui_win_info::refresh)
4326         (tui_refresh_all): Update.
4327         * tui/tui-windata.c (tui_first_data_item_displayed)
4328         (tui_delete_data_content_windows, tui_erase_data_content)
4329         (tui_display_all_data, tui_data_window::refresh_all)
4330         (tui_check_data_values): Update.
4331         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4332         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4333         (tui_win_info::backward_scroll, tui_refresh_all_win)
4334         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4335         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4336         (tui_source_window_base::set_new_height)
4337         (tui_data_window::set_new_height)
4338         (make_invisible_and_set_new_height)
4339         (make_visible_with_new_height, new_height_ok)
4340         (parse_scrolling_args): Update.
4341         * tui/tui-stack.c (tui_show_frame_info): Update.
4342         * tui/tui-source.c (tui_set_source_content)
4343         (tui_set_source_content_nil, tui_source_is_displayed)
4344         (tui_source_window::do_scroll_vertical): Update.
4345         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4346         (tui_display_registers_from, tui_display_reg_element_at_line)
4347         (tui_check_register_values, tui_reg_command): Update.
4348         * tui/tui-layout.c (tui_default_win_height)
4349         (show_source_disasm_command, show_data, init_and_make_win)
4350         (show_source_or_disasm_and_command): Update.
4351         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4352         (tui_redisplay_readline, tui_mld_flush)
4353         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4354         (tui_getc): Update.
4355         * tui/tui-disasm.c (tui_set_disassem_content)
4356         (tui_disasm_window::do_scroll_vertical): Update.
4357         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4358         Now virtual.
4359         (struct tui_win_info): Derive from tui_gen_win_info.
4360         <~tui_win_info>: Mark as override.
4361         <generic>: Remove member.
4362         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4363         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4364         (~tui_data_window, ~tui_win_info)
4365         (tui_free_all_source_wins_content): Update.
4366         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4367
4368 2019-06-25  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-layout.c (init_and_make_win): Use new.
4371         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4372         destructor, initializers.
4373         (tui_alloc_generic_win_info): Don't declare.
4374         * tui/tui-data.c (_locator): Add argument to constructor.
4375         (source_win, disasm_win): New globals.
4376         (exec_info): Remove.
4377         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4378         Update.
4379         (tui_alloc_generic_win_info): Remove.
4380         (init_content_element): Use new.
4381         (tui_win_info::tui_win_info): Update.
4382         (free_content_elements) <case DATA_WIN>: Use delete.
4383
4384 2019-06-25  Tom Tromey  <tom@tromey.com>
4385
4386         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4387         * tui/tui-windata.c (tui_first_data_item_displayed)
4388         (tui_delete_data_content_windows): Update.
4389         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4390         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4391         (tui_display_registers_from, tui_check_register_values): Update.
4392         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4393         pointer.
4394         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4395         window.
4396         (tui_free_data_content): Update.
4397         (free_content_elements) <case DATA_WIN>: Free the window.
4398
4399 2019-06-25  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4402         Update.
4403         * tui/tui-layout.c (make_command_window)
4404         (show_source_disasm_command, show_data, init_and_make_win)
4405         (show_source_or_disasm_and_command): Update.
4406         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4407         method.
4408         <can_highight, is_highlighted>: Now bool.
4409         (tui_set_win_highlight): Don't declare.
4410         * tui/tui-data.c (tui_set_win_highlight): Remove.
4411
4412 2019-06-25  Tom Tromey  <tom@tromey.com>
4413
4414         * tui/tui-wingeneral.c (make_visible): Remove check of window
4415         type.
4416
4417 2019-06-25  Tom Tromey  <tom@tromey.com>
4418
4419         * tui/tui-win.c (tui_win_info::max_height)
4420         (tui_cmd_window::max_height): New methods.
4421         (new_height_ok): Call max_height.
4422         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4423         <max_height>: New method.
4424
4425 2019-06-25  Tom Tromey  <tom@tromey.com>
4426
4427         * tui/tui-win.c (tui_source_window_base::set_new_height)
4428         (tui_data_window::set_new_height): New methods.
4429         (make_invisible_and_set_new_height): Call set_new_height method.
4430         * tui/tui-data.h (struct tui_win_info)
4431         (struct tui_source_window_base, struct tui_data_window)
4432         <set_new_height>: New method.
4433
4434 2019-06-25  Tom Tromey  <tom@tromey.com>
4435
4436         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4437         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4438         tui_refresh_data_win.
4439         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4440         method.
4441         (tui_refresh_all_win): Call the refresh_all method.
4442         (tui_set_focus): Likewise.
4443         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4444         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4445         Likewise.
4446
4447 2019-06-25  Tom Tromey  <tom@tromey.com>
4448
4449         * tui/tui-winsource.h (tui_refill_source_window)
4450         (tui_set_is_exec_point_at): Don't declare.
4451         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4452         (tui_source_window_base::refill): Rename from
4453         tui_refill_source_window.
4454         (tui_source_window_base::do_scroll_horizontal): Update.
4455         (tui_source_window_base::set_is_exec_point_at): Rename from
4456         tui_set_is_exec_point_at.
4457         (tui_update_all_breakpoint_info): Update.
4458         * tui/tui-stack.c (tui_show_frame_info): Update.
4459         * tui/tui-layout.c (show_data): Add cast.
4460         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4461         * tui/tui-data.h (struct tui_source_window_base) <refill,
4462         set_is_exec_point_at>: New methods.
4463         (tui_source_windows, tui_add_to_source_windows): Update types.
4464         (tui_add_to_source_windows): Remove redundant declaration.
4465         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4466         (tui_source_windows): Change return type.
4467         (tui_clear_source_windows_detail): Update.
4468         (tui_add_to_source_windows): Change type of parameter.
4469         (tui_free_all_source_wins_content): Update.
4470
4471 2019-06-25  Tom Tromey  <tom@tromey.com>
4472
4473         * tui/tui-wingeneral.c (tui_win_info::refresh)
4474         (tui_source_window_base::refresh): New methods.
4475         (tui_refresh_all): Call the refresh method.
4476         * tui/tui-data.h (struct tui_win_info)
4477         (struct tui_source_window_base) <refresh>: New method.
4478
4479 2019-06-25  Tom Tromey  <tom@tromey.com>
4480
4481         * tui/tui.h (tui_is_window_visible): Return bool.
4482         * tui/tui.c (tui_is_window_visible): Return bool.
4483         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4484         (tui_make_visible, tui_make_invisible)
4485         (tui_win_info::make_visible)
4486         (tui_source_window_base::make_visible, make_all_visible)
4487         (tui_make_all_visible, tui_make_all_invisible): Update.
4488         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4489         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4490         bool.
4491         (struct tui_win_info, struct tui_source_window_base)
4492         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4493         * tui/tui-data.c (tui_init_generic_part): Update.
4494
4495 2019-06-25  Tom Tromey  <tom@tromey.com>
4496
4497         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4498         (tui_source_window_base::make_visible): New methods.
4499         (make_all_visible): Make method call.
4500         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4501         (struct tui_source_window_base, struct tui_cmd_window): Override
4502         make_visible.
4503         (tui_win_is_source_type): Don't declare.
4504         * tui/tui-data.c (tui_win_is_source_type): Remove.
4505
4506 2019-06-25  Tom Tromey  <tom@tromey.com>
4507
4508         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4509         NULL check.
4510
4511 2019-06-25  Tom Tromey  <tom@tromey.com>
4512
4513         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4514         Inline constructor.  Add initializers for members.
4515         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4516         constructors; now inline in class.
4517
4518 2019-06-25  Tom Tromey  <tom@tromey.com>
4519
4520         * tui/tui-regs.c (tui_show_registers): Update.
4521         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4522         bool.
4523         * tui/tui-data.c (tui_data_window::clear_detail)
4524         (tui_data_window): Update.
4525
4526 2019-06-25  Tom Tromey  <tom@tromey.com>
4527
4528         * tui/tui-windata.c (tui_display_all_data)
4529         (tui_display_data_from_line, tui_display_data_from)
4530         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4531         Update.
4532         * tui/tui-regs.c (tui_last_regs_line_no)
4533         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4534         (tui_show_registers, tui_show_register_group)
4535         (tui_display_registers_from, tui_display_reg_element_at_line)
4536         (tui_display_registers_from_line, tui_check_register_values)
4537         (tui_reg_next, tui_reg_prev): Update.
4538         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4539         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4540         tui_data_window.
4541         (struct tui_win_info) <detail>: Remove.  Add new fields from
4542         tui_data_info.
4543         (TUI_DATA_WIN): Add cast.
4544         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4545         (~tui_data_window): Simplify.
4546
4547 2019-06-25  Tom Tromey  <tom@tromey.com>
4548
4549         * tui/tui-layout.c (show_source_disasm_command)
4550         (show_source_or_disasm_and_command): Update.
4551         * tui/tui-io.c (update_cmdwin_start_line)
4552         (tui_redisplay_readline): Update.
4553         * tui/tui-data.h (struct tui_command_info): Remove.
4554         (struct tui_win_info) <detail>: Remove command_info member.
4555         (struct tui_data_window) <start_line>: New member, from
4556         tui_command_info.
4557         (TUI_CMD_WIN): Add casts.
4558
4559 2019-06-25  Tom Tromey  <tom@tromey.com>
4560
4561         * tui/tui-winsource.c (tui_update_source_window)
4562         (tui_refill_source_window)
4563         (tui_source_window_base::do_scroll_horizontal)
4564         (tui_update_breakpoint_info, tui_set_exec_info_content)
4565         (tui_show_exec_info_content, tui_erase_exec_info_content)
4566         (tui_clear_exec_info_content): Update.
4567         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4568         Update.
4569         * tui/tui-win.c (make_invisible_and_set_new_height)
4570         (make_visible_with_new_height): Update.
4571         * tui/tui-source.c (tui_set_source_content)
4572         (tui_show_symtab_source): Update.
4573         * tui/tui-layout.c (extract_display_start_addr)
4574         (show_source_disasm_command, show_data)
4575         (make_source_or_disasm_window)
4576         (show_source_or_disasm_and_command): Update.
4577         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4578         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4579         "gdbarch".
4580         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4581         to tui_source_window_base.
4582         (struct tui_win_info) <detail>: Remove source_info member.
4583         (struct tui_source_window_base) <has_locator>: Inline.
4584         Move contents from tui_source_info; rename has_locator member to
4585         m_has_locator.
4586         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4587         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4588         header file.
4589         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4590         Simplify.
4591         (tui_free_all_source_wins_content): Cast to
4592         tui_source_window_base.
4593
4594 2019-06-25  Tom Tromey  <tom@tromey.com>
4595
4596         * tui/tui-win.c (make_invisible_and_set_new_height)
4597         (make_visible_with_new_height): Call has_locator method.
4598         * tui/tui-layout.c (show_source_disasm_command, show_data)
4599         (show_source_or_disasm_and_command): Update for bool change.
4600         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4601         (tui_win_info) <has_locator>: New method.
4602         (struct tui_source_window_base) <has_locator>: New method.
4603         (tui_win_has_locator): Don't declare.
4604         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4605         from tui_win_has_locator.
4606         (tui_source_window_base): Use false, not FALSE.
4607
4608 2019-06-25  Tom Tromey  <tom@tromey.com>
4609
4610         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4611         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4612         clear_detail method directly.
4613         (tui_clear_win_detail): Remove.
4614
4615 2019-06-25  Tom Tromey  <tom@tromey.com>
4616
4617         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4618         "this", not TUI_DISASM_WIN.
4619
4620 2019-06-25  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4623         declare.
4624         * tui/tui-winsource.c
4625         (tui_source_window_base::do_scroll_horizontal): Rename from
4626         tui_horizontal_source_scroll.
4627         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4628         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4629         from tui_vertical_data_scroll.
4630         * tui/tui-win.h (tui_scroll): Don't declare.
4631         * tui/tui-win.c (tui_win_info::forward_scroll)
4632         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4633         (tui_win_info::right_scroll): Rename and update.
4634         (tui_scroll_forward_command, tui_scroll_backward_command)
4635         (tui_scroll_left_command, tui_scroll_right_command): Update.
4636         (tui_scroll): Remove.
4637         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4638         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4639         from tui_vertical_source_scroll.
4640         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4641         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4642         from tui_vertical_disassem_scroll.
4643         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4644         do_scroll_horizontal>: New methods.
4645         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4646         Likewise.
4647         (struct tui_source_window_base): Add do_scroll_horizontal.
4648         (struct tui_source_window, struct tui_disasm_window): Add
4649         do_scroll_vertical.
4650         (struct tui_data_window, struct tui_cmd_window): Add
4651         do_scroll_horizontal and do_scroll_vertical.
4652         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4653
4654 2019-06-25  Tom Tromey  <tom@tromey.com>
4655
4656         * tui/tui-data.h (struct tui_source_window_base): New struct.
4657         (struct tui_source_window): Derive from tui_source_window_base.
4658         (struct tui_disasm_window): New struct.
4659         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4660         from tui_source_window::clear_detail.
4661         (tui_source_window_base): Rename from tui_source_window.
4662         (~tui_source_window_base): Rename from ~tui_source_window.
4663         (tui_alloc_win_info): Create a tui_disasm_window.
4664
4665 2019-06-25  Tom Tromey  <tom@tromey.com>
4666
4667         * tui/tui-data.h (struct tui_source_window)
4668         (struct tui_data_window): Declare destructors.
4669         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4670         destructors.
4671         (tui_win_info): Simplify.
4672
4673 2019-06-25  Tom Tromey  <tom@tromey.com>
4674
4675         * tui/tui-winsource.c (tui_display_main)
4676         (tui_update_source_windows_with_addr)
4677         (tui_update_all_breakpoint_info): Update.
4678         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4679         (new_height_ok, parse_scrolling_args): Update.
4680         * tui/tui-stack.c (tui_show_frame_info): Update.
4681         * tui/tui-data.h (struct tui_list): Remove.
4682         (tui_source_windows): Return a reference to a std::vector.
4683         * tui/tui-data.c (source_windows): Now a std::vector.
4684         (tui_source_windows): Change return type.
4685         (tui_clear_source_windows): Rewrite.
4686         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4687         (tui_free_all_source_wins_content): Rewrite.
4688
4689 2019-06-25  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4692         (struct tui_data_window, struct tui_cmd_window): Declare
4693         clear_detail method.
4694         * tui/tui-data.c (tui_source_window::clear_detail)
4695         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4696         methods.
4697         (tui_clear_win_detail): Simplify.
4698
4699 2019-06-25  Tom Tromey  <tom@tromey.com>
4700
4701         * tui/tui-layout.c (make_source_window, make_disasm_window)
4702         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4703         Return the new window.
4704         (show_source_disasm_command, show_data)
4705         (show_source_or_disasm_and_command): Update.
4706
4707 2019-06-25  Tom Tromey  <tom@tromey.com>
4708
4709         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4710         parameter.  Return the new window.
4711         (show_source_disasm_command): Update and remove NULL check.
4712         (show_source_or_disasm_and_command): Update.
4713
4714 2019-06-25  Tom Tromey  <tom@tromey.com>
4715
4716         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4717
4718 2019-06-25  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-data.h (struct tui_win_info): Make constructor
4721         protected.  Make destructor virtual.  Add initializers.
4722         (tui_source_window, tui_data_window, tui_cmd_window): New
4723         classes.
4724         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4725         constructor.  Add "type" parameter.
4726         (tui_source_window, tui_data_window, tui_cmd_window): New
4727         constructors.
4728         (tui_alloc_win_info): Instantiate the appropriate subclass.
4729
4730 2019-06-25  Tom Tromey  <tom@tromey.com>
4731
4732         * tui/tui-win.c (tui_resize_all): Use delete.
4733         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4734         destructor.
4735         (tui_free_window): Don't declare.
4736         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4737         Update.
4738
4739 2019-06-25  Tom Tromey  <tom@tromey.com>
4740
4741         * tui/tui-data.h (struct tui_win_info): Add constructor.
4742         * tui/tui-data.c (tui_alloc_win_info): Use new.
4743         (tui_free_window): Use delete.
4744
4745 2019-06-22  Tom Tromey  <tom@tromey.com>
4746
4747         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4748         declare.
4749         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4750
4751 2019-06-22  Tom Tromey  <tom@tromey.com>
4752
4753         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4754         declare.
4755         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4756
4757 2019-06-22  Tom de Vries  <tdevries@suse.de>
4758
4759         * dwarf2read.c (create_addrmap_from_aranges)
4760         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4761         instead of '%zu'.
4762
4763 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4764
4765         * dwarf2read.h (dwarf2_section_info_def): Remove.
4766         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4767         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4768         std::vector<dwarf2_section_info>.
4769         (struct dwo_file) <~dwo_file>: Remove.
4770         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4771         types field.
4772         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4773         (dwarf2_read_debug_names): Likewise.
4774         (create_debug_types_hash_table): Change parameter type to
4775         array_view, adjust code accordingly.
4776         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4777         (partial_die_info::fixup): Likewise.
4778         (determine_prefix): Likewise.
4779         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4780
4781 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4782
4783         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4784         gdb_bfd_ref_ptr.
4785         <~dwo_file>: Remove call to gdb_bfd_unref.
4786         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4787         gdb_bfd_ref_ptr::get.
4788
4789 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4790
4791         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4792         type to htab_up.
4793         * dwarf2read.c (struct dwo_file): Initialize fields.
4794         <~dwo_file>: New.
4795         (free_dwo_file): Remove, move content to ~dwo_file.
4796         (struct dwo_file_deleter): Remove.
4797         (dwo_file_up>: Remove custom deleter.
4798         (free_dwo_files): Remove.
4799         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4800         dwo_files.
4801         (process_skeletonless_type_units): Call unique_ptr::get.
4802         (allocate_dwo_file_hash_table): Add deleter to created hash
4803         table.  Change return type to htab_up.
4804         (lookup_dwo_file_slot): Don't memset dwo_file, call
4805         unique_ptr::get.
4806         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4807         (create_dwo_unit_in_dwp_v2): Likewise.
4808         (open_and_init_dwo_file): Likewise.
4809         (free_dwo_file_from_slot): Remove.
4810
4811 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4812
4813         * dwarf2read.h (struct dwarf2_section_info) <readin,
4814         is_virtual>: Change type to bool.
4815         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4816         true instead of 1.
4817
4818 2019-06-19  Tom Tromey  <tom@tromey.com>
4819
4820         * tui/tui-data.h (tui_init_content_element): Don't declare.
4821
4822 2019-06-19  Tom Tromey  <tom@tromey.com>
4823
4824         * tui/tui-data.h (tui_init_win_info): Don't declare.
4825
4826 2019-06-19  Tom de Vries  <tdevries@suse.de>
4827
4828         * dwarf2read.h (abstract_to_concrete): Change type to
4829         std::unordered_map<sect_offset, std::vector<sect_offset>,
4830         gdb::hash_enum<sect_offset>>.
4831
4832 2019-06-19  Tom Tromey  <tromey@adacore.com>
4833
4834         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4835         EVAL_AVOID_SIDE_EFFECTS specially.
4836
4837 2019-06-19  Tom Tromey  <tromey@adacore.com>
4838
4839         * source-cache.c (highlighter): New global.
4840         (source_cache::get_source_lines): Create a highlighter on demand.
4841
4842 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4843
4844         * defs.h (deprecated_interactive_hook): Delete declaration.
4845         * interps.c (clear_interpreter_hooks): Remove use of
4846         deprecated_interactive_hook.
4847         * top.c (deprecated_interactive_hook): Delete definition.
4848         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4849
4850 2019-06-18  Tom de Vries  <tdevries@suse.de>
4851
4852         PR gdb/24515
4853         * dwarf2read.h (abstract_to_concrete): Change type from
4854         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4855         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4856         * dwarf2read.c (read_variable): Update.
4857         (dwarf2_fetch_die_loc_sect_off): Update.
4858
4859 2019-06-17  Tom de Vries  <tdevries@suse.de>
4860
4861         PR gdb/24617
4862         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4863         accessing parent[parent_len - 1].
4864
4865 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4866
4867         PR gdb/24364
4868         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4869         call dtrace_process_dof with NULL dof.
4870
4871 2019-06-16  Tom de Vries  <tdevries@suse.de>
4872
4873         PR gdb/24445
4874         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4875
4876 2019-06-16  Tom Tromey  <tom@tromey.com>
4877
4878         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4879         (make_all_visible): Use address of member.
4880
4881 2019-06-16  Tom Tromey  <tom@tromey.com>
4882
4883         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4884         (tui_free_window, free_content, free_content_elements): Remove
4885         unnecessary cast.
4886         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4887         cast.
4888         * tui/tui-regs.c (tui_show_register_group)
4889         (tui_display_registers_from, tui_display_reg_element_at_line):
4890         Remove unnecessary cast.
4891
4892 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * linux-nat.c (normal_mask): Delete.
4895         (_initialize_linux_nat): Don't initialise normal_mask.
4896
4897 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4898
4899         PR gdb/24445
4900         * dwarf-index-write.h (write_psymtabs_to_index): Add
4901         dwz_basename parameter.
4902         * dwarf-index-write.c (write_gdbindex): Move file writing to
4903         write_gdbindex_1.  Change return type void.
4904         (assert_file_size): Move up, remove filename parameter.
4905         (write_gdbindex_1): New function.
4906         (write_debug_names): Change return type to void, call
4907         assert_file_size.
4908         (struct index_wip_file): New struct.
4909         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4910         file logic to index_wip_file.  Write index for dwz file if
4911         needed.
4912         (save_gdb_index_command): Pass basename of dwz file, if present.
4913         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4914         build-id of dwz file, if present.
4915         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4916         (dwarf2_get_dwz_file): Likewise.
4917         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4918         (dwarf2_get_dwz_file): Likewise.
4919
4920 2019-06-16  Tom Tromey  <tom@tromey.com>
4921
4922         * coffread.c (process_coff_symbol): Use xstrdup.
4923         * value.c (create_internalvar): Use xstrdup.
4924
4925 2019-06-16  Tom Tromey  <tom@tromey.com>
4926
4927         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4928         * breakpoint.c (stopin_command, stopat_command)
4929         (until_break_command, decode_location_default): Remove unnecessary
4930         cast.
4931         * utils.c (subset_compare): Remove unnecessary cast.
4932         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4933         cast.
4934         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4935         cast.
4936         * infcmd.c (path_command): Remove unnecessary cast.
4937         * coffread.c (decode_type): Remove unnecessary cast.
4938         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4939         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4940         * tui/tui-stack.c (tui_show_locator_content)
4941         (tui_show_frame_info): Remove unnecessary cast.
4942         * tui/tui-win.c (tui_scroll_forward_command)
4943         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4944         (parse_scrolling_args): Remove unnecessary cast.
4945         * tui/tui-data.c (init_win_info, tui_del_window)
4946         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4947         (free_content_elements): Remove unnecessary cast.
4948         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4949         unnecessary cast.
4950         * tui/tui-source.c (tui_set_source_content)
4951         (tui_vertical_source_scroll): Remove unnecessary cast.
4952         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4953         cast.
4954         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4955         * tui/tui-regs.c (tui_display_registers_from)
4956         (tui_display_register): Remove unnecessary cast.
4957         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4958         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4959         (make_visible): Remove unnecessary cast.
4960         * tui/tui-winsource.c (tui_erase_source_content)
4961         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4962         unnecessary cast.
4963         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4964         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4965         * stabsread.c (read_type, read_array_type, read_range_type):
4966         Remove unnecessary cast.
4967         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4968         (parse_symbol, parse_type, upgrade_type, parse_external)
4969         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4970         unnecessary cast.
4971         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4972
4973 2019-06-16  Tom Tromey  <tom@tromey.com>
4974
4975         * tui/tui-data.c (tui_alloc_generic_win_info)
4976         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4977         checks.
4978
4979 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4980             Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * f-typeprint.c (f_print_type): Don't return early for not
4983         associated or not allocated types.
4984         (f_type_print_varspec_suffix): Add print_rank parameter and print
4985         ranks of array types in case they dangling.
4986         (f_type_print_base): Add print_rank parameter.
4987
4988 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * NEWS: Mention new MI commands.
4991         * break-catch-throw.c (enum exception_event_kind): Move to
4992         breakpoint.h.
4993         (print_mention_exception_catchpoint): Output text as a single
4994         message.
4995         (catch_exception_command_1): Rename to...
4996         (catch_exception_event): ...this, make non-static, update header
4997         command, and change some parameter types.
4998         (catch_catch_command): Update for changes to
4999         catch_exception_command_1.
5000         (catch_throw_command): Likewise.
5001         (catch_rethrow_command): Likewise.
5002         * breakpoint.c (enum exception_event_kind): Delete.
5003         * breakpoint.h (enum exception_event_kind): Moved here from
5004         break-catch-throw.c.
5005         (catch_exception_event): Declare.
5006         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5007         (mi_cmd_catch_throw): New function.
5008         (mi_cmd_catch_rethrow): New function.
5009         (mi_cmd_catch_catch): New function.
5010         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5011         'catch-catch' entries.
5012         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5013         (mi_cmd_catch_rethrow): Declare.
5014         (mi_cmd_catch_catch): Declare.
5015
5016 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5017
5018         * annotate.c (annotate_source_line): Change return type to void,
5019         update implementation to match.
5020         * annotate.h (annotate_source_line): Change return type to void,
5021         update header comment.
5022         * stack.c (print_frame_info): Don't change what frame information
5023         is printed based on whether annotations are on or not.
5024
5025 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5026
5027         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5028         (annotate_source): Make static.
5029         (annotate_source_line): Moved from source.c and renamed from
5030         identify_source_line.  Update the return type.
5031         * annotate.h (annotate_source): Delete declaration.
5032         (annotate_source_line): Declaration moved from source.h, and
5033         renamed from identify_source_line.  Return type updated.
5034         * source.c (identify_source_line): Moved to annotate.c and renamed
5035         to annotate_source_line.
5036         (info_line_command): Remove check of annotation_level.
5037         * source.h (identify_source_line): Move declaration to annotate.h
5038         and rename to annotate_source_line.
5039         * stack.c: Add 'annotate.h' include.
5040         (print_frame_info): Remove check of annotation_level before
5041         calling annotate_source_line.
5042
5043 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5044
5045         * source-cache.c (source_cache::get_plain_source_lines): Use
5046         open_source_file_with_line_charpos instead of just
5047         open_source_file, remove call to find_source_lines.
5048         (source_cache::get_source_lines): Likewise.
5049         * source.c (find_source_lines): Make static.
5050         (get_filename_and_charpos): Renamed into...
5051         (open_source_file_with_line_charpos): ..this along with changes to
5052         return a scoped_fd, and some other minor clean ups.
5053         (identify_source_line): Use open_source_file_with_line_charpos.
5054         (search_command_helper): Use open_source_file_with_line_charpos
5055         instead of just open_source_file, remove call to
5056         find_source_lines.
5057         * source.h (open_source_file_with_line_charpos): Declare new
5058         function.
5059         (find_source_lines): Delete declaration.
5060
5061 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5062
5063         * source.c (get_filename_and_charpos): Remove fullname
5064         parameter.
5065         (identify_source_line): Update call to get_filename_and_charpos.
5066
5067 2019-06-14  Tom Tromey  <tromey@adacore.com>
5068
5069         PR gdb/24502:
5070         * ui-style.h (skip_ansi_escape): Update comment.
5071         * ui-file.h (class no_terminal_escape_file): New class.
5072         * ui-file.c (no_terminal_escape_file::write)
5073         (no_terminal_escape_file::puts): New methods.
5074         * cli/cli-logging.c (handle_redirections): Use
5075         no_terminal_escape_file.
5076
5077 2019-06-14  Tom Tromey  <tromey@adacore.com>
5078
5079         * NEWS: Move convenience variable news above Python news.
5080
5081 2019-06-14  Tom Tromey  <tom@tromey.com>
5082
5083         * gnulib: Move directory to top-level.
5084         * configure.ac: Don't configure gnulib.
5085         * configure: Rebuild.
5086         * common/common-defs.h: Use new path to gnulib.
5087         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5088         (GNULIB_H): Remove.
5089         (INCGNU): Look in new gnulib location.
5090         (HFILES_NO_SRCDIR): Remove gnulib files.
5091         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5092         (generated_files): Remove GNULIB_H.
5093         ($(LIBGNU), all-lib): Remove targets.
5094         (distclean): Don't mention GNULIB_BUILDDIR.
5095         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5096
5097 2019-06-14  Tom Tromey  <tromey@adacore.com>
5098
5099         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5100         Warn if symbol file does not provide any symbols.
5101
5102 2019-06-14  Tom Tromey  <tromey@adacore.com>
5103
5104         * source.c (find_and_open_source): Respect basenames_may_differ.
5105
5106 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * annotate.c (annotate_breakpoints_invalid): Make use of
5109         scoped_restore_terminal_state.
5110         (annotate_frames_invalid): Likewise.
5111
5112 2019-06-14  Tom Tromey  <tromey@adacore.com>
5113
5114         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5115         allow assignment to an internalvar.
5116
5117 2019-06-14  Tom Tromey  <tromey@adacore.com>
5118
5119         * ada-lex.l: Allow "_" in attribute names.
5120
5121 2019-06-14  Tom Tromey  <tromey@adacore.com>
5122
5123         PR gdb/24653:
5124         * regcache.c (registers_changed): Don't call alloca.
5125         * top.c (execute_command): Don't call alloca.
5126
5127 2019-06-13  Pedro Alves  <palves@redhat.com>
5128
5129         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5130         'expression'.  When parsing an expression, error out if there's
5131         junk after "unlimited".
5132         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5133         (do_set_command): Adjust calls to is_unlimited_literal.
5134
5135 2019-06-13  Pedro Alves  <palves@redhat.com>
5136
5137         * compile/compile.c (make_compile_options_def_group): Add braces
5138         around array_view initializer.
5139         * thread.c (make_thread_apply_all_options_def_group)
5140         (make_thread_apply_all_options_def_group): Likewise.
5141
5142 2019-06-13  Pedro Alves  <palves@redhat.com>
5143
5144         * NEWS (New commands): Mention "maint test-options
5145         require-delimiter", "maint test-options unknown-is-error", "maint
5146         test-options unknown-is-operand" and "maint show
5147         test-options-completion-result".
5148         (New command options, command completion): New section.
5149         (Completion improvements): New section.
5150         Mention that you can abbreviate "unlimited".
5151
5152 2019-06-13  Pedro Alves  <palves@redhat.com>
5153
5154         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5155         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5156         * unittests/cli-utils-selftests.c (test_parse_flags)
5157         (test_parse_flags_qcs): Delete.
5158         (test_cli_utils): Don't call deleted functions.
5159
5160 2019-06-13  Pedro Alves  <palves@redhat.com>
5161
5162         * thread.c: Include "cli/cli-option.h".
5163         (tp_array_compar_ascending): Global.
5164         (tp_array_compar): Delete function.
5165         (tp_array_compar_ascending, tp_array_compar_descending): New
5166         functions.
5167         (ascending_option_def, qcs_flag_option_def)
5168         (thr_qcs_flags_option_defs)
5169         (make_thread_apply_all_options_def_group)
5170         (make_thread_apply_options_def_group): New.
5171         (thread_apply_all_command): Use gdb::option::process_options.
5172         (thread_apply_command_completer)
5173         (thread_apply_all_command_completer): New.
5174         (thread_apply_command): Use gdb::option::process_options.
5175         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5176         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5177         to generate help text of "thread apply".  Adjust "taas"'s help.
5178         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5179         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5180
5181 2019-06-13  Pedro Alves  <palves@redhat.com>
5182
5183         * thread.c (thread_apply_command): Check for invalid TID with
5184         isdigit instead of !isalpha.
5185
5186 2019-06-13  Pedro Alves  <palves@redhat.com>
5187
5188         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5189         (validate_flags_qcs): New.
5190         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5191         (validate_flags_qcs): Declare.
5192         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5193         (make_frame_apply_options_def_group): New.
5194         (frame_apply_command_count): Process options with
5195         gdb::option::process_options.
5196         (frame_apply_completer): New.
5197         (frame_apply_level_completer, frame_apply_all_completer)
5198         (frame_apply_completer): New.
5199         (_initialize_stack): Update help of "frame apply", "frame apply
5200         level", "frame apply all" and "faas" to mention supported options
5201         and install command completers.
5202         * stack.h (frame_apply_all_completer): Declare.
5203         * thread.c: Include "stack.h".
5204         (tfaas_command): Add "--".
5205         (_initialize_thread): Update help "tfaas" to mention supported
5206         options and install command completer.
5207
5208 2019-06-13  Pedro Alves  <palves@redhat.com>
5209
5210         * completer.c (complete_nested_command_line): New.
5211         (gdb_completion_word_break_characters_throw): Add assertion.
5212         * completer.h (complete_nested_command_line): Declare.
5213
5214 2019-06-13  Pedro Alves  <palves@redhat.com>
5215
5216         * stack.c (parse_backtrace_qualifiers): New.
5217         (backtrace_command): Use it.
5218         (backtrace_command_completer): Complete on qualifiers.
5219
5220 2019-06-13  Pedro Alves  <palves@redhat.com>
5221
5222         * frame.c: Include "cli/cli-option.h.
5223         (user_set_backtrace_options): New.
5224         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5225         Delete.
5226         (get_prev_frame): Adjust.
5227         (boolean_option_def, uinteger_option_def)
5228         (set_backtrace_option_defs): New.
5229         (_initialize_frame): Adjust and use
5230         gdb::option::add_setshow_cmds_for_options to install "set
5231         backtrace past-main" and "set backtrace past-entry".
5232         * frame.h: Include "cli/cli-option.h".
5233         (struct frame_print_options): Forward declare.
5234         (print_frame_arguments_all, print_frame_arguments_scalars)
5235         (print_frame_arguments_none): Declare.
5236         (print_entry_values): Delete declaration.
5237         (struct frame_print_options, user_frame_print_options): New.
5238         (struct set_backtrace_options): New.
5239         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5240         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5241         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5242         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5243         (list_args_or_locals): Add frame_print_options parameter.
5244         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5245         * python/py-framefilter.c (enumerate_args): Pass down
5246         USER_FRAME_PRINT_OPTIONS.
5247         * stack.c: Include "cli/cli-option.h".
5248         (print_frame_arguments_all, print_frame_arguments_scalars)
5249         (print_frame_arguments_none): Declare.
5250         (print_raw_frame_arguments, print_entry_values): Delete.
5251         (user_frame_print_options): New.
5252         (boolean_option_def, enum_option_def, frame_print_option_defs):
5253         New.
5254         (struct backtrace_cmd_options): New.
5255         (bt_flag_option_def): New.
5256         (backtrace_command_option_defs): New.
5257         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5258         (print_frame_arg, read_frame_arg, print_frame_args)
5259         (print_frame_info, print_frame): Add frame_print_options parameter
5260         and use it.
5261         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5262         (backtrace_command_1): Add frame_print_options and
5263         backtrace_cmd_options parameters and use them.
5264         (make_backtrace_options_def_group): New.
5265         (backtrace_command): Process command options with
5266         gdb::option::process_options.
5267         (backtrace_command_completer): New.
5268         (_initialize_stack): Extend "backtrace"'s help to mention
5269         supported options.  Install completer for "backtrace".
5270         Install some settings commands with add_setshow_cmds_for_options.
5271
5272 2019-06-13  Pedro Alves  <palves@redhat.com>
5273
5274         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5275         and that "set/show print raw frame-arguments" are now deprecated.
5276
5277         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5278         command.
5279         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5280         * stack.c (_initialize_stack): Install "set/show print
5281         raw-frame-arguments", and deprecate "set/show print raw
5282         frame-arguments".
5283         * valprint.c (_initialize_valprint): Deprecate "set/show print
5284         raw".
5285
5286 2019-06-13  Pedro Alves  <palves@redhat.com>
5287
5288         * compile/compile.c (struct compile_options): New.
5289         (compile_flag_option_def, compile_command_option_defs)
5290         (make_compile_options_def_group): New.
5291         (compile_file_command): Handle options with
5292         gdb::option::process_options.
5293         (compile_file_command_completer): New function.
5294         (compile_code_command): Handle options with
5295         gdb::option::process_options.
5296         (compile_code_command_completer): New function.
5297         (_initialize_compiler): Install completers for "compile code" and
5298         "compile file".  Mention available options in "compile code" and
5299         "compile code"'s help.
5300         * completer.c (advance_to_completion_word): New, factored out from
5301         ...
5302         (advance_to_expression_complete_word_point): ... this.
5303         (advance_to_filename_complete_word_point): New.
5304         * completer.h (advance_to_filename_complete_word_point): New
5305         declaration.
5306
5307 2019-06-13  Pedro Alves  <palves@redhat.com>
5308
5309         * compile/compile.c: Include "cli/cli-option.h".
5310         (compile_print_value): Scope data pointer is now a
5311         value_print_options pointer; adjust.
5312         (compile_print_command): Process options.  Scope data pointer is
5313         now a value_print_options pointer; adjust.
5314         (_initialize_compile): Update "compile print"'s help to include
5315         supported options.  Install a completer for "compile print".
5316         * cp-valprint.c (show_vtblprint, show_objectprint)
5317         (show_static_field_print): Delete.
5318         (_initialize_cp_valprint): Don't install "set print
5319         static-members", "set print vtbl", "set print object" here.
5320         * printcmd.c: Include "cli/cli-option.h" and
5321         "common/gdb_optional.h".
5322         (print_command_parse_format): Rework to fill in a
5323         value_print_options instead of a format_data.
5324         (print_value): Change parameter type from format_data pointer to
5325         value_print_options reference.  Adjust.
5326         (print_command_1): Process options.  Adjust to pass down a
5327         value_print_options.
5328         (print_command_completer): New.
5329         (_initialize_printcmd): Install print_command_completer as
5330         handle_brkchars completer for the "print" command.  Update
5331         "print"'s help to include supported options.
5332         * valprint.c: Include "cli/cli-option.h".
5333         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5334         here from cp-valprint.c.
5335         (boolean_option_def, uinteger_option_def)
5336         (value_print_option_defs, make_value_print_options_def_group):
5337         New.  Use gdb::option::add_setshow_cmds_for_options to install
5338         "set print elements", "set print null-stop", "set print repeats",
5339         "set print pretty", "set print union", "set print array", "set
5340         print address", "set print symbol", "set print array-indexes".
5341         * valprint.h: Include <string> and "cli/cli-option.h".
5342         (make_value_print_options_def_group): Declare.
5343         (print_value): Change parameter type from format_data pointer to
5344         value_print_options reference.
5345         (print_command_completer): Declare.
5346
5347 2019-06-13  Pedro Alves  <palves@redhat.com>
5348
5349         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5350         (COMMON_SFILES): Add maint-test-settings.c.
5351         * cli/cli-decode.c (boolean_enums): New global, factored out from
5352         ...
5353         (add_setshow_boolean_cmd): ... here.
5354         * cli/cli-decode.h (boolean_enums): Declare.
5355         * cli/cli-option.c: New file.
5356         * cli/cli-option.h: New file.
5357         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5358         factored out from ...
5359         (parse_cli_boolean_value(const char *)): ... this.
5360         (is_unlimited_literal): Change parameter type to pointer to
5361         pointer.  Adjust and advance ARG pointer.
5362         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5363         (parse_cli_var_enum): New, factored out from ...
5364         (do_set_command): ... this.  Adjust.
5365         * cli/cli-setshow.h (parse_cli_boolean_value)
5366         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5367         (parse_cli_var_enum): Declare.
5368         * cli/cli-utils.c: Include "cli/cli-option.h".
5369         (get_ulongest): New.
5370         * cli/cli-utils.h (get_ulongest): Declare.
5371         (check_for_argument): New overloads.
5372         * maint-test-options.c: New file.
5373
5374 2019-06-13  Pedro Alves  <palves@redhat.com>
5375
5376         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5377         parse a range if "-" is at the end of the string.
5378
5379 2019-06-13  Pedro Alves  <palves@redhat.com>
5380
5381         * cli/cli-setshow.c (parse_auto_binary_operation)
5382         (parse_cli_boolean_value): Don't allow "o".
5383
5384 2019-06-13  Pedro Alves  <palves@redhat.com>
5385
5386         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5387         * NEWS: Mention maint test-settings KIND.
5388         * maint-test-settings.c: New file.
5389
5390 2019-06-13  Pedro Alves  <palves@redhat.com>
5391
5392         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5393         completer.
5394         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5395         "set" completers.
5396
5397 2019-06-13  Pedro Alves  <palves@redhat.com>
5398
5399         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5400         after item.
5401
5402 2019-06-13  Pedro Alves  <palves@redhat.com>
5403
5404         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5405
5406 2019-06-13  Pedro Alves <palves@redhat.com>
5407
5408         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5409         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5410         call.
5411         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5412         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5413         calls.
5414         (check_for_argument): Skip spaces after argument.
5415
5416 2019-06-13  Pedro Alves  <palves@redhat.com>
5417
5418         * thread.c (thread_apply_command): Adjust TID parsing.
5419         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5420         detected before end of string.
5421         (tid_is_in_list): Error out if LIST is invalid.
5422
5423 2019-06-13  Pedro Alves  <palves@redhat.com>
5424
5425         * completer.c (complete_line_internal_1): Rewind completion word
5426         point.
5427         (completion_tracker::advance_custom_word_point_by): Change
5428         parameter type to int.
5429         * completer.h (completion_tracker::advance_custom_word_point_by):
5430         Likewise.
5431
5432 2019-06-13  Pedro Alves  <palves@redhat.com>
5433
5434         * completer.c (advance_to_completion_word): Handle delimiters.
5435
5436 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5437
5438         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5439
5440 2019-06-11  Tom Tromey  <tom@tromey.com>
5441
5442         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5443         (xmalloc_failed): Move to alloc.c.
5444         * alloc.c: New file.
5445         * Makefile.in (COMMON_SFILES): Add alloc.c.
5446
5447 2019-06-11  Tom Tromey  <tom@tromey.com>
5448
5449         * nat/linux-waitpid.c: Don't include server.h.
5450         (linux_debug): Remove.
5451         (my_waitpid): Update.
5452
5453 2019-06-11  Tom Tromey  <tromey@adacore.com>
5454
5455         * infcall.c (_initialize_infcall): Remove trailing newline from
5456         help.
5457         * user-regs.c (_initialize_user_regs): Remove trailing newline
5458         from help.
5459         * typeprint.c (_initialize_typeprint): Remove trailing newline
5460         from help.
5461         * reverse.c (_initialize_reverse): Remove trailing newlines from
5462         help.
5463         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5464         from help.
5465         * language.c (add_set_language_command): Remove trailing newline
5466         from help.
5467         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5468         help.
5469         * disasm.c (_initialize_disasm): Remove trailing newline from
5470         help.
5471         * top.c (init_main): Remove trailing newline from help.
5472         * interps.c (_initialize_interpreter): Remove trailing newline
5473         from help.
5474         * btrace.c (_initialize_btrace): Remove trailing newlines from
5475         help.
5476         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5477         from help.
5478         * python/python.c (_initialize_python): Remove trailing newline
5479         from help.
5480         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5481         help.
5482         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5483         from help.  Reformat some text.
5484         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5485         from help.
5486         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5487         newline from help.
5488
5489 2019-06-11  Tom Tromey  <tromey@adacore.com>
5490
5491         * darwin-nat.c (darwin_decode_exception_message)
5492         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5493
5494 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5495
5496         * valops.c (value_slice): Check for not allocated or not
5497         associated values.
5498
5499 2019-06-10  Tom de Vries  <tdevries@suse.de>
5500
5501         PR gdb/24618
5502         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5503         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5504         invalid.
5505
5506 2019-06-10  Tom de Vries  <tdevries@suse.de>
5507
5508         PR gdb/24611
5509         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5510         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5511
5512 2019-06-10  Tom de Vries  <tdevries@suse.de>
5513
5514         PR symtab/24545
5515         * symtab.c (struct demangled_name_entry): Add language field.
5516         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5517         static minimal symbol".  Set and use language field.
5518
5519 2019-06-10  Tom Tromey  <tromey@adacore.com>
5520
5521         * ada-lang.c (_initialize_ada_language): Update help text.
5522
5523 2019-06-10  Tom Tromey  <tromey@adacore.com>
5524
5525         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5526         with a newline.
5527         * guile/guile.c (handle_boot_error): Don't end warning with a
5528         newline.
5529         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5530         warning with a newline.
5531         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5532         newline.
5533         (s12z_frame_cache): Likewise.
5534         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5535         a newline.
5536         * solib-svr4.c (disable_probes_interface): Don't end warning with
5537         a newline.
5538         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5539         newline.
5540         * python/python.c (do_finish_initialization): Don't end warning
5541         with a newline.
5542
5543 2019-06-10  Tom Tromey  <tom@tromey.com>
5544
5545         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5546         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5547         gdbpy_enter.
5548
5549 2019-06-10  Tom Tromey  <tromey@adacore.com>
5550
5551         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5552         data.
5553         (elf_new_init): Don't call stabsread_new_init.
5554         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5555         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5556         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5557
5558 2019-06-10  Tom de Vries  <tdevries@suse.de>
5559
5560         PR symtab/16264
5561         PR symtab/24517
5562         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5563
5564 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5565
5566         * source.c (find_and_open_source): Also rewrite relative file
5567         names.
5568
5569 2019-04-26  Amos Bird  <amosbird@gmail.com>
5570
5571         * annotate.c (annotate_thread_exited): Add "thread-exited"
5572         annotation.
5573
5574 2019-06-06  Tom Tromey  <tromey@adacore.com>
5575
5576         * maint.h (class scoped_command_stats): Use
5577         DISABLE_COPY_AND_ASSIGN.
5578         <print_time>: New method.
5579         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5580         print_time.
5581         (scoped_command_stats::print_time): New method.
5582
5583 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5586         instructions of lengths 6 or 8 bytes.
5587
5588 2019-06-04  Pedro Alves  <palves@redhat.com>
5589
5590         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5591
5592         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5593         * breakpoint.c (condition_completer): Likewise.
5594         * cli/cli-dump.c (scan_expression): Likewise.
5595         * common/filestuff.c (mkdir_recursive): Likewise.
5596         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5597         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5598         (gdb_abspath): Likewise.
5599         * compile/compile-cplus-types.c
5600         (compile_cplus_instance::decl_name): Likewise.
5601         * completer.c (complete_explicit_location):
5602         (signal_completer, reg_or_group_completer_1): Likewise.
5603         * cp-support.c (cp_remove_params_if_any): Likewise.
5604         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5605         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5606         * infcmd.c (strip_bg_char): Likewise.
5607         * linespec.c (copy_token_string): Likewise.
5608         * mi/mi-main.c (output_cores): Likewise.
5609         * psymtab.c (psymtab_search_name):
5610         * symfile.c (test_set_ext_lang_command): Likewise.
5611         * target.c (target_fileio_read_stralloc): Likewise.
5612         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5613         * value.c (complete_internalvar): Likewise.
5614
5615 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5616
5617         Add objfile property to gdb.Type.
5618         * NEWS: Mention Python API addition.
5619         * python/py-type.c (typy_get_objfile): New method.
5620
5621 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5622
5623         * NEWS: Mention the new set|show style [title|highlight].
5624         Mention changes to "show style", "help" and "apropos".
5625
5626 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5627
5628         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5629         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5630         instead of print_help_for_command.
5631         (print_doc_of_command): New function.
5632         (help_list): Add 'apropos -v word' suggestion.
5633         (print_help_for_command): Style the command name using title style.
5634         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5635         (_initialize_cli_cmds): Describe -v in apropos_command help.
5636
5637 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5638
5639         * cli/cli-style.h (cli_style_option): Add name in constructor,
5640         add m_name class member, add constructor with intensity,
5641         add name class function.
5642         (cli_style_option::add_setshow_commands): Remove name argument.
5643         (highlight_style, title_style): New styles.
5644         * cli/cli-style.c (do_show): New function that shows a style
5645         characteristic styling the style name with itself.
5646         (set_style_name): New function.
5647         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5648         Update all callers according to the changes in cli/cli-style.h.
5649         * utils.h (fputs_highlighted): New function.
5650         * utils.c (fputs_highlighted): Likewise.
5651
5652 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5653
5654         * NEWS: Mention new pipe command and new convenience variables.
5655
5656 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5657
5658         * cli/cli-cmds.c (pipe_command): New function.
5659         (_initialize_cli_cmds): Call add_com for pipe_command.
5660         Define | as an alias for pipe.
5661         (exit_status_set_internal_vars): New function.
5662         (shell_escape): Call exit_status_set_internal_vars.
5663         cli/cli-decode.c (find_command_name_length): Recognize | as
5664         a single character command.
5665
5666 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5667
5668         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5669         top.c (execute_command_to_ui_file): New function, mostly a copy
5670         of execute_command_to_string.
5671         (execute_command_to_string): Implement by calling
5672         execute_command_to_ui_file.
5673
5674 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5675
5676         * top.h (saved_command_line): Remove declaration.
5677         * top.c (previous_saved_command_line, previous_repeat_arguments):
5678         New variables.
5679         (saved_command_line): Make static, define together with other
5680         'repeat variables'.
5681         (dont_repeat): Clear repeat_arguments.
5682         (repeat_previous, get_saved_command_line, save_command_line):
5683         New functions.
5684         (gdb_init): Initialize saved_command_line
5685         and previous_saved_command_line.
5686         * main.c (captured_main_1): Remove saved_command_line initialization.
5687         * event-top.c (handle_line_of_input): Update to use
5688         the new 'repeat' related functions instead of direct access to
5689         saved_command_line.
5690         * command.h (repeat_previous, get_saved_command_line,
5691         save_command_line): New declarations.
5692         (dont_repeat): Add comment.
5693
5694 2019-05-30  Tom Tromey  <tromey@adacore.com>
5695
5696         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5697         Fix comment.
5698         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5699
5700 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5701
5702         PR cli/24587
5703         * completer.c (complete): Initialize variable word.
5704
5705 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5706
5707         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5708         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5709         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5710         'body' is NULL to the outter 'if', protecting the '!is_define'
5711         situation as well.
5712
5713 2019-05-29  Tom Tromey  <tromey@adacore.com>
5714
5715         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5716         (dwarf_unknown): New function.
5717         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5718         (dwarf_type_encoding_name): Use dwarf_unknown.
5719
5720 2019-05-29  Tom Tromey  <tromey@adacore.com>
5721
5722         PR c++/20020:
5723         * cp-valprint.c (cp_print_value_fields): Call
5724         cp_print_static_field inside "try".
5725
5726 2019-05-29  Tom Tromey  <tromey@adacore.com>
5727
5728         * inflow.c (struct terminal_info): Add default operator=.
5729         * configure: Rebuild.
5730         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5731         -Wdeprecated-copy-dtor, -Wredundant-move.
5732
5733 2019-05-29  Tom Tromey  <tromey@adacore.com>
5734
5735         * NEWS: Add entry.
5736         * infcmd.c (print_return_value_1): Handle finish_print
5737         option.
5738         (show_print_finish): New function.
5739         (_initialize_infcmd): Add "set/show print finish" commands.
5740         * valprint.c (user_print_options): Initialize new member.
5741         * valprint.h (struct value_print_options) <finish_print>: New
5742         member.
5743
5744 2019-05-28  Tom Tromey  <tromey@adacore.com>
5745
5746         * ada-lang.c (ada_remove_Xbn_suffix)
5747         (find_old_style_renaming_symbol)
5748         (parse_old_style_renaming): Remove.
5749         (ada_find_renaming_symbol): Don't call
5750         find_old_style_renaming_symbol.
5751         (ada_is_renaming_symbol): Rename from
5752         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5753         bool.  Now static.
5754         (ada_read_var_value): Update and simplify.
5755         * ada-exp.y (write_var_or_type): Remove old code.
5756
5757 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5758
5759         * event-top.c: Remove include comment.
5760         * inflow.c (class scoped_ignore_sigttou): Move from here...
5761         * inflow.h (class scoped_ignore_sigttou): ...to here.
5762         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5763         * top.c:  Remove include comment.
5764
5765 2019-05-27  Tom Tromey  <tom@tromey.com>
5766
5767         * NEWS: Fix typo.
5768
5769 2019-05-22  Tom Tromey  <tromey@adacore.com>
5770
5771         * target.c (target_follow_exec): Constify parameter.
5772         * target-delegates.c: Rebuild.
5773         * remote.c (remote_target::follow_exec): Constify parameter.
5774         * infrun.c (follow_exec): Constify parameter.
5775         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5776         (target_follow_exec): Likewise.
5777
5778 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5779
5780         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5781         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5782
5783 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5784
5785         * NEWS: Add debugredirect and testsuite sections.
5786
5787 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5788
5789         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5790         target descriptions using exclusively floating point register name
5791         aliases.
5792
5793 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5794
5795         PR gdb/18644:
5796         * f-lang.c (build_fortran_types): Handle the case where
5797         gdbarch_floatformat_for_type returns a nullptr.
5798
5799 2019-05-21  Tom de Vries  <tdevries@suse.de>
5800
5801         PR cli/24587
5802         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5803
5804 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5805
5806         PR gdb/18644:
5807         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5808         16-byte floats.
5809         * i386-tdep.c (i386_floatformat_for_type): Use
5810         floatformats_ia64_quad for the 16-byte floating point component
5811         within a fortran 32-byte complex number.
5812
5813 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5814
5815         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5816         delete default constructor.
5817         (find_partial_die): Update to return const struct.
5818         (partial_die_parent_scope): Move variable declaration into scope
5819         of its use and change its type to auto.
5820         (guess_partial_die_structure_name): Likewise.
5821         (partial_die_info::fixup): Likewise.
5822
5823 2019-05-17  Tom Tromey  <tromey@adacore.com>
5824
5825         * source.c (find_and_open_source): Remove cast.
5826
5827 2019-05-17  Tom Tromey  <tromey@adacore.com>
5828
5829         * annotate.c (annotate_source): Make "filename" const.
5830         * annotate.h (annotate_source): Use const.
5831
5832 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5833
5834         * disasm.c (set_disassembler_options): Send errors to stderr.
5835
5836 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5837
5838         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5839         (cli_interp_base::set_logging): Check debug_redirect.
5840         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5841         * cli/cli-logging.c (debug_redirect): Add static variable.
5842         (pop_output_files): Add default param.
5843         (handle_redirections): Print debug setting.
5844         (show_logging_command): Likewise.
5845         (_initialize_cli_logging): Add debugredirect command.
5846         * interps.c (current_interp_set_logging): Add debug_redirect
5847         parameter.
5848         * interps.h (set_logging): Add debug_redirect parameter.
5849         (current_interp_set_logging): Likewise.
5850         * mi/mi-common.h: Likewise.
5851         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5852
5853 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5854             Tom Tromey  <tromey@adacore.com>
5855
5856         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5857         directly.
5858         * cli/cli-interp.h (make_logging_output): Remove declaration.
5859         * cli/cli-logging.c (make_logging_output): Remove function.
5860         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5861         directly.
5862         * ui-file.c (tee_file::tee_file): Remove bools.
5863         (tee_file::~tee_file): Remove deletes.
5864         * ui-file.h (tee_file): Remove bools.
5865
5866 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5867
5868         * mi/mi-cmds.h (mi_cmd_complete): New function.
5869         * mi/mi-main.c (mi_cmd_complete): Likewise.
5870         * mi/mi-cmds.c: Define new MI command -complete.
5871         * NEWS: Mention new -complete command.
5872
5873 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5874
5875         * completer.h (complete): New function.
5876         * completer.c (complete): Likewise.
5877         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5878         function defined in completer.h.
5879
5880 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5881
5882         * MAINTAINERS (Write After Approval): Add myself.
5883
5884 2019-05-17  Tom de Vries  <tdevries@suse.de>
5885
5886         PR gdb/24094
5887         * dwarf2read.c (struct cu_partial_die_info): New struct.
5888         (find_partial_die): Return cu_partial_die_info.
5889         (partial_die_parent_scope, guess_partial_die_structure_name)
5890         (partial_die_info::fixup): Handle new return type of find_partial_die.
5891
5892 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5893
5894         PR breakpoints/24541
5895         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5896         "std::string", simplifying the algorithm.
5897
5898 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5899
5900         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5901         (stap_static_probe_ops::get_probes): Likewise.
5902
5903 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5904
5905         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5906         '-')" and "else if".
5907         (stap_parse_single_operand): Join checks for
5908         "gdbarch_stap_parse_special_token_p" and
5909         "gdbarch_stap_parse_special_token" in the same "if" statement.
5910         Invert check when verifying for operation on register
5911         displacement.
5912
5913 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5914
5915         * stap-probe.c (stap_get_opcode): Update comment.
5916         (stap_get_expected_argument_type): Likewise.
5917         (handle_stap_probe): Likewise.
5918
5919 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5920
5921         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5922         return type to 'bool'.  Adjust comment.  Use 'bool' when
5923         appropriate.
5924         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5925         * stap-probe.c (stap_parse_argument_1): Likewise.
5926         (stap_is_operator): Likewise.
5927         (stap_is_generic_prefix): Likewise.
5928         (stap_is_register_prefix): Likewise.
5929         (stap_is_register_indirection_prefix): Likewise.
5930         (stap_is_integer_prefix): Likewise.
5931         (stap_generic_check_suffix): Likewise.
5932         (stap_check_integer_suffix): Likewise.
5933         (stap_check_register_suffix): Likewise.
5934         (stap_check_register_indirection_suffix): Likewise.
5935         (stap_parse_register_operand): Likewise.
5936         (stap_parse_single_operand): Likewise.
5937         (stap_parse_argument_1): Likewise.
5938         (stap_probe::get_argument_count): Likewise.
5939         (stap_is_operator): Likewise.
5940
5941 2019-05-16  Tom Tromey  <tromey@adacore.com>
5942
5943         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5944         keyword to foreach.
5945
5946 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5947
5948         * linux-thread-db.c (try_thread_db_load_1): Change return type
5949         to bool.
5950         (try_thread_db_load): Likewise.
5951         (try_thread_db_load_from_pdir_1): Likewise.
5952         (try_thread_db_load_from_pdir): Likewise.
5953         (try_thread_db_load_from_sdir): Likewise.
5954         (try_thread_db_load_from_dir): Likewise.
5955         (thread_db_load_search): Likewise.
5956         (has_libpthread): Likewise.
5957         (thread_db_load): Likewise.
5958
5959 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5960
5961         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5962         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5963         NULL, and complain/return if that's the case.
5964
5965 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5966
5967         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5968         (advance, posn, abstract_read_memory): New functions.
5969         [struct mem_read_abstraction]: New struct.
5970         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5971
5972 2019-05-14  Tom Tromey  <tromey@adacore.com>
5973
5974         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5975         value is not lval_memory.
5976
5977 2019-05-14  Tom Tromey  <tromey@adacore.com>
5978
5979         * solib.c (info_sharedlibrary_command): Style the file name.
5980
5981 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5982
5983         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5984         (aarch64_vnv_type): Likewise.
5985         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5986         * common/tdesc.c: Likewise.
5987         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5988         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5989         * features/aarch64-fpu.xml: Add ieee half view.
5990         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5991         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5992         * gdbtypes.h (struct builtin_type): Likewise.
5993         (struct objfile_type): Likewise.
5994
5995 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5996
5997         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5998         typo.
5999         * location.h (string_to_event_location): Likewise.
6000
6001 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6002
6003         GDB 8.3 released.
6004
6005 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6006
6007         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6008         New variable declaration.
6009         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6010         New variable.
6011         (print_one_breakpoint): Use ui_out::test_flags and new global
6012         variable to compute use_fixed_output.
6013         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6014         Remove.
6015         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6016         (mi_multi_location_breakpoint_output_fixed): Remove.
6017         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6018         new variable.
6019         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6020         fix_multi_location_breakpoint_output flag if version >= 3.
6021         * ui-out.h (enum ui_out_flag)
6022         <fix_multi_location_breakpoint_output>: New enumerator.
6023
6024 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6025
6026         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6027
6028 2019-05-10  Tom Tromey  <tromey@adacore.com>
6029
6030         * ada-lang.c (catch_ada_completer): New function.
6031         (_initialize_ada_language): Use it.
6032
6033 2019-05-10  Tom Tromey  <tromey@adacore.com>
6034
6035         * thread.c (print_thread_info): Make "requested_threads" const.
6036         * gdbthread.h (print_thread_info): Make "requested_threads"
6037         const.
6038         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6039         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6040
6041 2019-05-08  Tom Tromey  <tom@tromey.com>
6042
6043         * gdbtypes.c (objfile_type_data): Change type.
6044         (objfile_type, _initialize_gdbtypes): Update.
6045
6046 2019-05-08  Tom Tromey  <tom@tromey.com>
6047
6048         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6049         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6050         (_initialize_dwarf2_frame): Update.
6051
6052 2019-05-08  Tom Tromey  <tom@tromey.com>
6053
6054         * objc-lang.c (objc_objfile_data): Change type.
6055         (find_methods): Update.
6056         (_initialize_objc_lang): Remove.
6057
6058 2019-05-08  Tom Tromey  <tom@tromey.com>
6059
6060         * stabsread.c (rs6000_builtin_type_data): Change type.
6061         (rs6000_builtin_type, _initialize_stabsread): Update.
6062
6063 2019-05-08  Tom Tromey  <tom@tromey.com>
6064
6065         * mips-tdep.c (mips_pdr_data): Remove.
6066         (_initialize_mips_tdep): Update.
6067
6068 2019-05-08  Tom Tromey  <tom@tromey.com>
6069
6070         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6071         (hppa_init_objfile_priv_data, read_unwind_info)
6072         (find_unwind_entry, _initialize_hppa_tdep): Update.
6073
6074 2019-05-08  Tom Tromey  <tom@tromey.com>
6075
6076         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6077         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6078         on obstack.
6079         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6080
6081 2019-05-08  Tom Tromey  <tom@tromey.com>
6082
6083         * mdebugread.c (basic_type_data): Change type.
6084         (basic_type, _initialize_mdebugread): Update.
6085
6086 2019-05-08  Tom Tromey  <tom@tromey.com>
6087
6088         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6089
6090 2019-05-08  Tom Tromey  <tom@tromey.com>
6091
6092         * nto-tdep.c (nto_inferior_data_reg): Change type.
6093         (nto_inferior_data): Update.
6094         (nto_inferior_data_cleanup, nto_new_inferior_data)
6095         (_initialize_nto_tdep): Remove.
6096         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6097
6098 2019-05-08  Tom Tromey  <tom@tromey.com>
6099
6100         * ada-lang.c (struct ada_inferior_data): Add initializers.
6101         (ada_inferior_data): Change type.
6102         (ada_inferior_data_cleanup): Remove.
6103         (get_ada_inferior_data, ada_inferior_exit)
6104         (struct ada_pspace_data): Add initializers, destructor.
6105         (ada_pspace_data_handle): Change type.
6106         (get_ada_pspace_data): Update.
6107         (ada_pspace_data_cleanup): Remove.
6108
6109 2019-05-08  Tom Tromey  <tom@tromey.com>
6110
6111         * coffread.c (struct coff_symfile_info): Add initializers.
6112         (coff_objfile_data_key): Move lower.  Change type.
6113         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6114         Update.
6115         (coff_free_info): Remove.
6116
6117 2019-05-08  Tom Tromey  <tom@tromey.com>
6118
6119         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6120         (fbsd_pspace_data_handle): Move lower.  Change type.
6121         (get_fbsd_pspace_data): Update.
6122         (fbsd_pspace_data_cleanup): Remove.
6123         (_initialize_fbsd_tdep): Update.
6124
6125 2019-05-08  Tom Tromey  <tom@tromey.com>
6126
6127         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6128         (get_ada_tasks_pspace_data): Update.
6129         (ada_tasks_pspace_data_cleanup): Remove.
6130         (_initialize_tasks): Update.
6131         (ada_tasks_inferior_data_handle): Change type.
6132         (get_ada_tasks_inferior_data): Update.
6133         (ada_tasks_inferior_data_cleanup): Remove.
6134         (struct ada_tasks_pspace_data): Add initializers.
6135
6136 2019-05-08  Tom Tromey  <tom@tromey.com>
6137
6138         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6139         * symfile-debug.c (debug_sym_get_probes): Change type.
6140         * stap-probe.c (handle_stap_probe):
6141         (stap_static_probe_ops::get_probes): Change type.
6142         * probe.h (class static_probe_ops) <get_probes>: Change type.
6143         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6144         (parse_probes_in_pspace): Update.
6145         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6146         Update.
6147         (any_static_probe_ops::get_probes): Change type.
6148         * elfread.c (elfread_data): New typedef.
6149         (probe_key): Change type.
6150         (elf_get_probes): Likewise.  Update.
6151         (probe_key_free): Remove.
6152         (_initialize_elfread): Update.
6153         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6154         Change type.
6155         (dtrace_process_dof_probe, dtrace_process_dof)
6156         (dtrace_static_probe_ops::get_probe): Change type.
6157
6158 2019-05-08  Tom Tromey  <tom@tromey.com>
6159
6160         * xcoffread.c (struct xcoff_symfile_info): Rename from
6161         coff_symfile_info.  Add initializers.
6162         (xcoff_objfile_data_key): Move lower.  Change type.
6163         (XCOFF_DATA): Rewrite.
6164         (xcoff_free_info): Remove.
6165         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6166         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6167         (xcoff_initial_scan): Update.
6168
6169 2019-05-08  Tom Tromey  <tom@tromey.com>
6170
6171         * solib-svr4.c (struct svr4_info): Add initializers and
6172         destructor.
6173         <probes_table>: Now an htab_up.
6174         (solib_svr4_pspace_data): Change type.
6175         (free_probes_table): Simplify.
6176         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6177         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6178         (probes_table_remove_objfile_probes, register_solib_event_probe)
6179         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6180         (_initialize_svr4_solib): Update.
6181
6182 2019-05-08  Tom Tromey  <tom@tromey.com>
6183
6184         * remote.c (remote_pspace_data): Change type.
6185         (remote_pspace_data_cleanup): Remove.
6186         (get_remote_exec_file, set_pspace_remote_exec_file)
6187         (_initialize_remote): Update.
6188
6189 2019-05-08  Tom Tromey  <tom@tromey.com>
6190
6191         * breakpoint.c (breakpoint_objfile_key): Change type.
6192         (get_breakpoint_objfile_data): Update.
6193         (free_breakpoint_objfile_data): Remove.
6194         (_initialize_breakpoint): Update.
6195
6196 2019-05-08  Tom Tromey  <tom@tromey.com>
6197
6198         * linux-tdep.c (struct linux_info): Add initializers.
6199         (linux_inferior_data): Move.  Change type.
6200         (invalidate_linux_cache_inf): Update.
6201         (linux_inferior_data_cleanup): Remove.
6202         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6203
6204 2019-05-08  Tom Tromey  <tom@tromey.com>
6205
6206         * auxv.c (auxv_inferior_data): Move.  Change type.
6207         (auxv_inferior_data_cleanup): Remove.
6208         (invalidate_auxv_cache_inf): Rewrite.
6209         (get_auxv_inferior_data, _initialize_auxv): Update.
6210
6211 2019-05-08  Tom Tromey  <tom@tromey.com>
6212
6213         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6214         (symfile_debug_objfile_data_key): Change type.
6215         (symfile_debug_installed, debug_qf_has_symbols)
6216         (debug_qf_find_last_source_symtab)
6217         (debug_qf_forget_cached_source_info)
6218         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6219         (debug_qf_print_stats, debug_qf_dump)
6220         (debug_qf_expand_symtabs_for_function)
6221         (debug_qf_expand_all_symtabs)
6222         (debug_qf_expand_symtabs_with_fullname)
6223         (debug_qf_map_matching_symbols)
6224         (debug_qf_expand_symtabs_matching)
6225         (debug_qf_find_pc_sect_compunit_symtab)
6226         (debug_qf_map_symbol_filenames)
6227         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6228         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6229         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6230         (debug_sym_read_linetable, debug_sym_relocate): Update.
6231         (symfile_debug_free_objfile): Remove.
6232         (install_symfile_debug_logging, _initialize_symfile_debug):
6233         Update.
6234
6235 2019-05-08  Tom Tromey  <tom@tromey.com>
6236
6237         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6238         allocate_on_obstack.
6239         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6240         (get_dwarf2_per_objfile): Update.
6241         (set_dwarf2_per_objfile): Remove.
6242         (dwarf2_has_info, dwarf2_get_section_info): Update.
6243         (dwarf2_free_objfile): Remove.
6244         (_initialize_dwarf2_read): Update.
6245
6246 2019-05-08  Tom Tromey  <tom@tromey.com>
6247
6248         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6249         initializers.
6250         <unsupported_script_warning_printed,
6251         script_not_found_warning_printed>: Now bool.
6252         (auto_load_pspace_data): Change type.
6253         (~auto_load_pspace_info): Rename from
6254         auto_load_pspace_data_cleanup.
6255         (get_auto_load_pspace_data, init_loaded_scripts_info)
6256         (clear_section_scripts, maybe_print_unsupported_script_warning)
6257         (maybe_print_script_not_found_warning, _initialize_auto_load):
6258         Update.
6259
6260 2019-05-08  Tom Tromey  <tom@tromey.com>
6261
6262         * objfiles.c (objfile_pspace_info): Add destructor and
6263         initializers.
6264         (objfiles_pspace_data): Change type.
6265         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6266         (get_objfile_pspace_data): Update.
6267         (objfiles_bfd_data): Change type.
6268         (get_objfile_bfd_data): Update.
6269         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6270
6271 2019-05-08  Tom Tromey  <tom@tromey.com>
6272
6273         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6274         Change type.
6275         (get_catch_syscall_inferior_data): Update.
6276         (catch_syscall_inferior_data_cleanup): Remove.
6277         (_initialize_break_catch_syscall): Update.
6278
6279 2019-05-08  Tom Tromey  <tom@tromey.com>
6280
6281         * inflow.c (struct terminal_info): Add destructor and
6282         initializers.
6283         (inflow_inferior_data): Change type.
6284         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6285         (get_inflow_inferior_data, inflow_inferior_exit)
6286         (swap_terminal_info, _initialize_inflow): Update.
6287
6288 2019-05-08  Tom Tromey  <tom@tromey.com>
6289
6290         * target-dcache.c (target_dcache_cleanup): Remove.
6291         (target_dcache_aspace_key): Change type.
6292         (target_dcache_init_p, target_dcache_invalidate)
6293         (target_dcache_get, target_dcache_get_or_init)
6294         (_initialize_target_dcache): Update.
6295         * dcache.h (struct dcache_deleter): New.
6296
6297 2019-05-08  Tom Tromey  <tom@tromey.com>
6298
6299         * symtab.c (struct symbol_cache): Add destructor and
6300         initializers.
6301         (symbol_cache_key): Move.  Change type.
6302         (make_symbol_cache, free_symbol_cache): Remove.
6303         (get_symbol_cache): Update.
6304         (symbol_cache_cleanup): Remove.
6305         (ALL_PSPACES, symbol_cache_flush)
6306         (maintenance_print_symbol_cache)
6307         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6308         Update.
6309
6310 2019-05-08  Tom Tromey  <tom@tromey.com>
6311
6312         * symtab.c (struct main_info): Add destructor and initializers.
6313         (main_progspace_key): Move.  Change type.
6314         (get_main_info): Update.
6315         (main_info_cleanup): Remove.
6316         (_initialize_symtab): Update.
6317
6318 2019-05-08  Tom Tromey  <tom@tromey.com>
6319
6320         * registry.h (DECLARE_REGISTRY): Define the _key class.
6321
6322 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6323
6324         * NEWS: Merge two 'New commands' sections.
6325
6326 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6327
6328         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6329         parameter and use Ada language definition instead.
6330         (ada_val_print_ptr): Remove unused language parameter.
6331         (ada_val_print_num): Remove language parameter and use Ada language
6332         definition instead.
6333         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6334         parameter.
6335         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6336         parameter and use Ada language definition instead.
6337         (ada_val_print_1): Update all ada_val_print_xxx calls.
6338         Remove language parameter.
6339         (ada_val_print): Update ada_val_print_1 call.
6340
6341 2019-05-08  Tom Tromey  <tromey@adacore.com>
6342
6343         * remote.c (remote_hw_watchpoint_limit)
6344         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6345         Now static.
6346
6347 2019-05-08  Tom Tromey  <tromey@adacore.com>
6348
6349         * maint.c (_initialize_maint_cmds): Move initialization code to
6350         remote.c.
6351         (watchdog, show_watchdog): Move to remote.c.
6352         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6353         "watchdog" static.
6354         (_initialize_remote): Move initialization code from maint.c.
6355         * defs.h (watchdog): Don't declare.
6356
6357 2019-05-08  Tom Tromey  <tromey@adacore.com>
6358
6359         * tui/tui-interp.c: Include main.h.
6360         * interps.c: Include main.h.
6361         * main.h (interpreter_p): Declare.
6362         * defs.h (interpreter_p): Don't declare.
6363
6364 2019-05-08  Tom Tromey  <tromey@adacore.com>
6365
6366         * dwarf2loc.c: Include dwarf2read.h.
6367         * defs.h (read_unsigned_leb128): Don't declare.
6368         * dwarf2read.h (read_unsigned_leb128): Declare.
6369
6370 2019-05-08  Tom Tromey  <tromey@adacore.com>
6371
6372         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6373         method.
6374
6375 2019-05-08  Tom Tromey  <tromey@adacore.com>
6376
6377         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6378         when no wrap column is set.
6379
6380 2019-05-08  Tom Tromey  <tromey@adacore.com>
6381
6382         * c-lang.c (c_get_string): Handle non-C-style arrays.
6383
6384 2019-05-08  Tom Tromey  <tromey@adacore.com>
6385
6386         * typeprint.c (print_offset_data::update): Print the bit offset,
6387         not the number of bits remaining.
6388
6389 2019-05-08  Tom Tromey  <tromey@adacore.com>
6390
6391         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6392         padding at end of comment.
6393
6394 2019-05-08  Tom Tromey  <tromey@adacore.com>
6395
6396         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6397         Compare main types.
6398
6399 2019-05-06  Tom Tromey  <tom@tromey.com>
6400
6401         * common/scoped_mmap.c: Include common-defs.h.
6402         * common/scoped_mmap.h: Don't include config.h.
6403
6404 2019-05-04  Tom Tromey  <tom@tromey.com>
6405
6406         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6407         (struct aarch64_call_info): Add initializers.
6408         <si>: Now a std::vector.
6409         (pass_on_stack, aarch64_push_dummy_call): Update.
6410
6411 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6412             Tom Tromey  <tom@tromey.com>
6413
6414         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6415         (ppc_threads): Now a std::vector.  Now static.
6416         (hwdebug_find_thread_points_by_tid)
6417         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6418         Update.
6419
6420 2019-05-04  Tom Tromey  <tom@tromey.com>
6421
6422         * arc-tdep.c (arc_tdesc_init): Return bool.
6423
6424 2019-05-04  Tom Tromey  <tom@tromey.com>
6425
6426         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6427         Use gdb_assert_not_reached.
6428
6429 2019-05-04  Tom Tromey  <tom@tromey.com>
6430
6431         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6432         "false".
6433
6434 2019-05-04  Tom Tromey  <tom@tromey.com>
6435
6436         * arc-tdep.c (arc_tdesc_init): Use bool.
6437
6438 2019-05-04  Tom Tromey  <tom@tromey.com>
6439
6440         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6441
6442 2019-05-04  Tom Tromey  <tom@tromey.com>
6443
6444         * cli/cli-cmds.c (valid_command_p): Return bool.
6445
6446 2019-05-04  Tom Tromey  <tom@tromey.com>
6447
6448         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6449         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6450
6451 2019-05-04  Raul Tambre  <raul@tambre.ee>
6452
6453         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6454         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6455         operator for comparison.
6456
6457 2019-05-04  Tom Tromey  <tom@tromey.com>
6458
6459         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6460         (lookup_partial_symbol, print_partial_symbols)
6461         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6462         (psymbol_compare): Update.
6463         (add_psymbol_to_bcache): Clear the entire psymbol.
6464         (maintenance_check_psymtabs): Update.
6465         * psympriv.h (struct partial_symbol): Don't derive from
6466         general_symbol_info.
6467         <obj_section, unrelocated_address, address,
6468         set_unrelocated_address>: Update.
6469         <ginfo>: New member.
6470         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6471         (debug_names::write_psymbols): Update.
6472
6473 2019-05-04  Tom de Vries  <tdevries@suse.de>
6474
6475         * contrib/cc-with-tweaks.sh: Support -n arg.
6476
6477 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6478
6479         * corelow.c (core_target::detach): Ensure frame cache and
6480         register caches are cleared.
6481         inferior.c (exit_inferior_1): Likewise.
6482
6483 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6484             Tom Tromey  <tom@tromey.com>
6485
6486         * dictionary.c (collate_pending_symbols_by_language): Remove
6487         "struct" from foreach.
6488         * symtab.c (lookup_global_symbol_from_objfile)
6489         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6490         foreach.
6491         * ser-tcp.c (net_open): Remove "struct" from foreach.
6492         * objfiles.c (objfile_relocate, objfile_rebase)
6493         (objfile_has_symbols): Remove "struct" from foreach.
6494         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6495         from foreach.
6496         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6497         foreach.
6498         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6499         "struct" from foreach.
6500         * ada-lang.c (create_excep_cond_exprs)
6501         (ada_exception_catchpoint_cond_string): Remove "struct" from
6502         foreach.
6503
6504 2019-05-03  Tom Tromey  <tromey@adacore.com>
6505
6506         * ada-exp.y (convert_char_literal): Check suffix of each
6507         enumerator.
6508
6509 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6510
6511         PR ada/21406:
6512         * ada-exp.y (yywrap): Don't define.
6513         * ada-lex.l (%option): Add noyywrap
6514         (yywrap): Remove.
6515
6516 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6517
6518         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6519         _WIN32_WINNT to the XP level, unless already defined to a higher
6520         level.
6521
6522         * unittests/parse-connection-spec-selftests.c:
6523         * ser-tcp.c:
6524         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6525         override.
6526
6527         * symfile.c (find_separate_debug_file): Remove colon from the
6528         drive spec of DOS/Windows file names of the target, so that the
6529         file name produced from DEBUGDIR and the target's directory will
6530         be valid on DOS/Windows systems.
6531
6532 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6533
6534         * rust-lang.c (val_print_struct): Handle printing structures
6535         containing strings.
6536
6537 2019-05-02  Tom Tromey  <tromey@adacore.com>
6538
6539         * valarith.c (_initialize_valarith): Remove.
6540
6541 2019-05-01  Tom Tromey  <tromey@adacore.com>
6542
6543         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6544         bitfields.
6545
6546 2019-05-01  Tom Tromey  <tromey@adacore.com>
6547
6548         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6549         for big-endian copies.
6550
6551 2019-04-30  Ali Tamur  <tamur@google.com>
6552         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6553         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6554         (read_3_bytes): New function.
6555
6556 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6557
6558         * windows-nat.c (main_thread_id): Delete.
6559         (handle_output_debug_string): Replace main_thread_id by
6560         current_event.dwThreadId.
6561         (fake_create_process): Likewise.
6562         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6563         Do not set main_thread_id.
6564         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6565         current_event.dwThreadId.
6566         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6567
6568 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6569
6570         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6571         Use current_event.dwThreadId instead of main_thread_id.
6572
6573 2019-04-30  Tom Tromey  <tromey@adacore.com>
6574
6575         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6576         (create_excep_cond_exprs): Iterate over program spaces.
6577         (ada_exception_catchpoint_cond_string): Examine all minimal
6578         symbols for exception types.
6579
6580 2019-04-30  Tom Tromey  <tromey@adacore.com>
6581
6582         PR c++/24470:
6583         * dwarf2read.c (process_structure_scope): Handle case where type
6584         has template parameters but no symbol was created.
6585
6586 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6587             Chris January  <chris.january@arm.com>
6588
6589         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6590         qualifier.
6591         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6592
6593 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6594
6595         * f-typeprint.c (f_print_type): Update rules for printing
6596         whitespace.
6597         (f_type_print_varspec_suffix): Likewise.
6598
6599 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6600             Chris January  <chris.january@arm.com>
6601
6602         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6603         function arguments.
6604
6605 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6606
6607         * f-lang.c (build_fortran_types): Change name of void type to
6608         lower case.
6609         * f-typeprint.c (f_type_print_base): Print the name of the void
6610         type, rather than a fixed string.
6611         * f-valprint.c (f_decorations): Use lower case void string.
6612
6613 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6614             Chris January  <chris.january@arm.com>
6615
6616         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6617         types for Fortran.
6618
6619 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6620             Chris January  <chris.january@arm.com>
6621             David Lecomber  <david.lecomber@arm.com>
6622
6623         * f-exp.y (BINOP_INTRINSIC): New token.
6624         (exp): New parser rule handling BINOP_INTRINSIC.
6625         (f77_keywords): Add new builtin procedures.
6626         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6627         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6628         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6629         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6630         (print_unop_subexp_f): New function.
6631         (print_binop_subexp_f): New function.
6632         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6633         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6634         (dump_subexp_body_f): Likewise.
6635         (operator_check_f): Likewise.
6636         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6637         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6638
6639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6640
6641         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6642         UNOP_KIND.
6643         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6644         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6645         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6646         (operator_length_f): New fuction.
6647         (print_subexp_f): New function.
6648         (op_name_f): New function.
6649         (dump_subexp_body_f): New function.
6650         (operator_check_f): New function.
6651         (exp_descriptor_f): Replace standard expression handling functions
6652         with new functions.
6653         * gdb/fortran-operator.def: New file.
6654         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6655         * gdb/std-operator.def: Remove UNOP_KIND.
6656
6657 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6658
6659         * std-operator.def: Remove unbalanced, stray double quote
6660         character.
6661
6662 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6663             Chris January  <chris.january@arm.com>
6664             Daniel Everett  <daniel.everett@arm.com>
6665             Nick Forrington  <nick.forrington@arm.com>
6666             Richard Bunt  <richard.bunt@arm.com>
6667
6668         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6669         of depth when printing anonymous structs or unions.
6670         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6671         Don't print either the top-level value, or the children if the
6672         max-depth is exceeded.
6673         (ppscm_print_children): When printing the key of a map, allow one
6674         extra level of depth.
6675         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6676         print either the top-level value, or the children if the max-depth
6677         is exceeded.
6678         (print_children): When printing the key of a map, allow one extra
6679         level of depth.
6680         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6681         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6682         (user_print_options): Initialise max_depth field.
6683         (val_print_scalar_or_string_type_p): New function.
6684         (val_print): Check to see if the max depth has been reached.
6685         (val_print_check_max_depth): Define new function.
6686         (show_print_max_depth): New function.
6687         (_initialize_valprint): Add 'print max-depth' option.
6688         * valprint.h (struct value_print_options) <max_depth>: New field.
6689         (val_print_check_max_depth): Declare new function.
6690         * NEWS: Document new feature.
6691
6692 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6693
6694         * ada-lang.c (ada_language_defn): Initialise new field.
6695         * c-lang.c (c_is_string_type_p): New function.
6696         (c_language_defn): Initialise new field.
6697         (cplus_language_defn): Initialise new field.
6698         (asm_language_defn): Initialise new field.
6699         (minimal_language_defn): Initialise new field.
6700         * c-lang.h (c_is_string_type_p): Declare new function.
6701         * d-lang.c (d_language_defn): Initialise new field.
6702         * f-lang.c (f_is_string_type_p): New function.
6703         (f_language_defn): Initialise new field.
6704         * go-lang.c (go_is_string_type_p): New function.
6705         (go_language_defn): Initialise new field.
6706         * language.c (default_is_string_type_p): New function.
6707         (unknown_language_defn): Initialise new field.
6708         (auto_language_defn): Initialise new field.
6709         * language.h (struct language_defn) <la_is_string_type_p>: New
6710         member variable.
6711         (default_is_string_type_p): Declare new function.
6712         * m2-lang.c (m2_language_defn): Initialise new field.
6713         * objc-lang.c (objc_language_defn): Initialise new field.
6714         * opencl-lang.c (opencl_language_defn): Initialise new field.
6715         * p-lang.c (pascal_is_string_type_p): New function.
6716         (pascal_language_defn): Initialise new field.
6717         * rust-lang.c (rust_is_string_type_p): New function.
6718         (rust_language_defn): Initialise new field.
6719
6720 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6721
6722         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6723         New field.
6724         * ada-lang.c (ada_language_defn): Initialise new field.
6725         * c-lang.c (c_language_defn): Likewise.
6726         (cplus_language_defn): Likewise.
6727         (asm_language_defn): Likewise.
6728         (minimal_language_defn): Likewise.
6729         * d-lang.c (d_language_defn): Likewise.
6730         * f-lang.c (f_language_defn): Likewise.
6731         * go-lang.c (go_language_defn): Likewise.
6732         * language.c (unknown_language_defn): Likewise.
6733         (auto_language_defn): Likewise.
6734         * m2-lang.c (m2_language_defn): Likewise.
6735         * objc-lang.c (objc_language_defn): Likewise.
6736         * opencl-lang.c (opencl_language_defn): Likewise.
6737         * p-lang.c (pascal_language_defn): Likewise.
6738         * rust-lang.c (rust_language_defn): Likewise.
6739
6740 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6741
6742         * ada-lang.c (ada_is_character_type): Change return type to bool.
6743         (ada_is_string_type): Likewise.
6744         * ada-lang.h (ada_is_character_type): Update declaration
6745         (ada_is_string_type): Likewise.
6746
6747 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6748
6749         Support style in 'frame|thread apply'
6750
6751         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6752         * record.c (record_start, record_stop): Update callers of
6753         execute_command_to_string with false.
6754         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6755         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6756         methods.
6757         (class string_file): New constructor with term_out parameter.
6758         Override methods term_out and can_emit_style_escape.  New member
6759         term_out.
6760         (class stdio_file): Override can_emit_style_escape.
6761         (class tee_file): Override term_out and can_emit_style_escape.
6762         * utils.h (can_emit_style_escape): Remove.
6763         * utils.c (can_emit_style_escape): Likewise.
6764         Update all callers of can_emit_style_escape (SOMESTREAM) to
6765         SOMESTREAM->can_emit_style_escape.
6766         * source-cache.c (source_cache::get_source_lines): Likewise.
6767         * stack.c (frame_apply_command_count): Call execute_command_to_string
6768         passing the term_out characteristic of the current gdb_stdout.
6769         * thread.c (thr_try_catch_cmd): Likewise.
6770         * top.c (execute_command_to_string): pass term_out parameter
6771         to construct the string_file for the command output.
6772         * ui-file.c (term_cli_styling): New function (most code moved
6773         from utils.c can_emit_style_escape).
6774         (string_file::string_file, string_file::can_emit_style_escape,
6775         stdio_file::can_emit_style_escape, tee_file::term_out,
6776         tee_file::can_emit_style_escape): New functions.
6777
6778 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6779
6780         * NEWS: Mention the new set|show may-call-functions.
6781         * infcall.c (may_call_functions_p): New variable.
6782         (show_may_call_functions_p): New function.
6783         (call_function_by_hand_dummy): Throws an error if not
6784         may-call-functions.
6785         (_initialize_infcall): Call add_setshow_boolean_cmd for
6786         may-call-functions.
6787
6788 2019-04-25  Keith Seitz  <keiths@redhat.com>
6789
6790         PR c++/24367
6791         * cp-support.c (inspect_type): Don't attempt substitutions
6792         of symbol with the same name.
6793
6794 2019-04-25  Tom Tromey  <tromey@adacore.com>
6795
6796         PR gdb/24475:
6797         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6798         static.
6799
6800 2019-04-25  Tom Tromey  <tromey@adacore.com>
6801
6802         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6803         rvalue reference.
6804         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6805         (gdb_xml_parser::parse): Use std::move.
6806         * python/python-internal.h (gdbpy_convert_exception): Take a const
6807         reference.
6808         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6809         std::move.
6810         * python/py-utils.c (gdbpy_convert_exception): Take a const
6811         reference.
6812         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6813         Use std::move.
6814         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6815         Use std::move.
6816         * mi/mi-main.c (mi_print_exception): Take a const reference.
6817         * main.c (handle_command_errors): Take a const reference.
6818         * linespec.c (parse_linespec): Use std::move.
6819         * infcall.c (run_inferior_call): Use std::move.
6820         (call_function_by_hand_dummy): Use std::move.
6821         * exec.c (try_open_exec_file): Use std::move.
6822         * exceptions.h (exception_print, exception_fprintf)
6823         (exception_print_same): Update.
6824         * exceptions.c (print_exception, exception_print)
6825         (exception_fprintf, exception_print_same): Change parameters to
6826         const reference.
6827         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6828         * common/new-op.c: Use std::move.
6829         * common/common-exceptions.h (struct gdb_exception): Add move
6830         constructor.
6831         (struct gdb_exception_error, struct gdb_exception_quit, struct
6832         gdb_quit_bad_alloc): Change constructor to move constructor.
6833         (throw_exception): Change parameter to rvalue reference.
6834         * common/common-exceptions.c (throw_exception): Take rvalue
6835         reference.
6836         * cli/cli-interp.c (safe_execute_command): Use std::move.
6837         * breakpoint.c (insert_bp_location, location_to_sals): Use
6838         std::move.
6839
6840 2019-04-25  Tom Tromey  <tromey@adacore.com>
6841
6842         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6843         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6844         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6845         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6846         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6847         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6848         guile/scm-value.c: Use unpack.
6849         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6850         gdbscm_gdb_exception.
6851         (gdbscm_throw_gdb_exception): Likewise.
6852         (struct gdbscm_gdb_exception): New.
6853         (unpack): New function.
6854         (gdbscm_wrap): Use unpack.
6855
6856 2019-04-25  Tom Tromey  <tromey@adacore.com>
6857
6858         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6859         (gdb_rl_callback_handler): Use std::move.
6860         * common/common-exceptions.h (struct gdb_exception): Add move
6861         assignment operator.
6862         (throw_exception_sjlj): Change "exception" to const reference.
6863         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6864         (throw_exception_sjlj): Change "exception" to const reference.
6865
6866 2019-04-25  Tom Tromey  <tromey@adacore.com>
6867
6868         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6869         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6870         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6871         Update.
6872         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6873         Update.
6874         * mi/mi-interp.c (mi_interp::exec): Update.
6875         * linespec.c (parse_linespec): Update.
6876         * infcall.c (run_inferior_call): Update.
6877         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6878         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6879         (gdbscm_lookup_global_symbol): Update.
6880         * guile/scm-param.c (gdbscm_parameter_value): Update.
6881         * guile/scm-frame.c (gdbscm_frame_read_register)
6882         (gdbscm_frame_read_var): Update.
6883         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6884         * exec.c (try_open_exec_file): Update.
6885         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6886         (gdb_rl_callback_handler): Update.
6887         * common/common-exceptions.h (exception_none): Don't declare.
6888         * common/common-exceptions.c (exception_none): Don't define.
6889         (struct catcher) <exception>: Update.
6890         * cli/cli-interp.c (safe_execute_command): Update.
6891         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6892
6893 2019-04-25  Ali Tamur  <tamur@google.com>
6894
6895         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6896         (read_attribute_value): Likewise.
6897         (dwarf2_read_addr_index): Update comment.
6898         (read_str_index): Add DW_FORM_strx.
6899         (dwarf2_string_attr): Likewise.
6900         (dwarf2_const_value_attr): Likewise.
6901         (dump_die_shallow): Likewise.
6902         (dwarf2_fetch_constant_bytes): Likewise.
6903         (skip_form_bytes): Likewise.
6904         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6905
6906 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6907
6908         PR corefiles/11608
6909         PR corefiles/18187
6910         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6911         OFFSET.  Verify if current mapping contains an ELF header.
6912         (linux_find_memory_regions_full): Adjust call to
6913         dump_mapping_p.
6914
6915 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6916             Kang Li <kanglictf@gmail.com>
6917
6918         PR gdb/21600
6919
6920         * dwarf2-frame.c (read_initial_length): Be consistent about using
6921         unsigned representation of length.
6922         (decode_frame_entry_1): Likewise.  Check for wraparound of
6923         end pointer as well as buffer overflow.
6924
6925 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6926
6927         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6928         "vq".
6929
6930 2019-04-24  Tom Tromey  <tromey@adacore.com>
6931
6932         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6933
6934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6935
6936         * s12z-tdep.c (s12z_unwind_pc): Delete.
6937         (s12z_unwind_sp): Delete.
6938         (s12z_gdbarch_init): Don't register deleted functions with
6939         gdbarch.
6940
6941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6942
6943         * rl78-tdep.c (rl78_unwind_sp): Delete.
6944         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6945
6946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6947
6948         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6949         (xstormy16_unwind_pc): Delete.
6950         (xstormy16_dummy_id): Delete.
6951         (xstormy16_gdbarch_init): Don't register deleted functions with
6952         gdbarch.
6953
6954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6955
6956         * vax-tdep.c (vax_unwind_pc): Delete.
6957         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6958
6959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6960
6961         * v850-tdep.c (v850_unwind_sp): Delete.
6962         (v850_unwind_pc): Delete.
6963         (v850_dummy_id): Delete.
6964         (v850_gdbarch_init): Don't register deleted functions with
6965         gdbarch.
6966
6967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6968
6969         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6970         (tilegx_unwind_pc): Delete.
6971         (tilegx_unwind_dummy_id): Delete.
6972         (tilegx_gdbarch_init): Don't register deleted functions with
6973         gdbarch.
6974
6975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6976
6977         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6978         (tic6x_dummy_id): Delete.
6979         (tic6x_gdbarch_init): Don't register deleted functions with
6980         gdbarch.
6981
6982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6983
6984         * sparc-tdep.c (sparc_unwind_pc): Delete.
6985         (sparc32_gdbarch_init): Don't register deleted function with
6986         gdbarch.
6987
6988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6989
6990         * sh-tdep.c (sh_unwind_sp): Delete.
6991         (sh_unwind_pc): Delete.
6992         (sh_dummy_id): Delete.
6993         (sh_gdbarch_init): Don't register deleted functions with
6994         gdbarch.
6995
6996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6997
6998         * score-tdep.c (score_unwind_sp): Delete.
6999         (score_unwind_pc): Delete.
7000         (score_dummy_id): Delete.
7001         (score_gdbarch_init): Don't register deleted functions with
7002         gdbarch.
7003
7004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7005
7006         * rx-tdep.c (rx_unwind_pc): Delete.
7007         (rx_unwind_sp): Delete.
7008         (rx_dummy_id): Delete.
7009         (rx_gdbarch_init): Don't register deleted functions with
7010         gdbarch.  Update comment.
7011
7012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7013
7014         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7015         (rs6000_dummy_id): Delete.
7016         (rs6000_gdbarch_init): Don't register deleted functions with
7017         gdbarch.
7018
7019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7020
7021         * or1k-tdep.c (or1k_dummy_id): Delete.
7022         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7023
7024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7025
7026         * nios2-tdep.c (nios2_dummy_id): Delete.
7027         (nios2_unwind_sp): Delete.
7028         (nios2_gdbarch_init): Don't register deleted functions with
7029         gdbarch.
7030
7031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7032
7033         * nds32-tdep.c (nds32_dummy_id): Delete.
7034         (nds32_unwind_pc): Delete.
7035         (nds32_unwind_sp): Delete.
7036         (nds32_gdbarch_init): Don't register deleted functions with
7037         gdbarch.
7038
7039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7040
7041         * msp430-tdep.c (msp430_unwind_pc): Delete.
7042         (msp430_unwind_sp): Delete.
7043         (msp430_dummy_id): Delete.
7044         (msp430_gdbarch_init): Don't register deleted functions with
7045         gdbarch.
7046
7047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7048
7049         * moxie-tdep.c (moxie_unwind_sp): Delete.
7050         (moxie_unwind_pc): Delete.
7051         (moxie_dummy_id): Delete.
7052         (moxie_gdbarch_init): Don't register deleted functions with
7053         gdbarch.
7054
7055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7056
7057         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7058         (mn10300_unwind_pc): Delete.
7059         (mn10300_unwind_sp): Delete.
7060         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7061         mn10300_unwind_sp.
7062         (mn10300_frame_unwind_init): Don't register deleted functions with
7063         gdbarch.
7064
7065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7066
7067         * mep-tdep.c (mep_unwind_pc): Delete.
7068         (mep_unwind_sp): Delete.
7069         (mep_dummy_id): Delete.
7070         (mep_gdbarch_init): Don't register deleted functions with
7071         gdbarch.
7072
7073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7074
7075         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7076         (m68hc11_unwind_sp): Delete.
7077         (m68hc11_gdbarch_init): Don't register deleted functions with
7078         gdbarch.
7079
7080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7081
7082         * m32r-tdep.c (m32r_unwind_sp): Delete.
7083         (m32r_unwind_pc): Delete.
7084         (m32r_dummy_id): Delete.
7085         (m32r_gdbarch_init): Don't register deleted functions with
7086         gdbarch.
7087
7088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7089
7090         * m32c-tdep.c (m32c_unwind_pc): Delete.
7091         (m32c_unwind_sp): Delete.
7092         (m32c_dummy_id): Delete.
7093         (m32c_gdbarch_init): Don't register deleted functions with
7094         gdbarch.
7095
7096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7097
7098         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7099         (lm32_unwind_pc): Delete.
7100         (lm32_dummy_id): Delete.
7101         (lm32_gdbarch_init): Don't register deleted functions with
7102         gdbarch.
7103
7104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7105
7106         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7107         (iq2000_unwind_pc): Delete.
7108         (iq2000_dummy_id): Delete.
7109         (iq2000_gdbarch_init): Don't register deleted functions with
7110         gdbarch.
7111
7112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * nds32-tdep.c (nds32_type_align): Delete.
7115         (nds32_push_dummy_call): Use type_align instead.
7116
7117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7118
7119         * arm-tdep.c (arm_type_align): Only handle vector override case.
7120         (arm_push_dummy_call): Use type_align.
7121         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7122
7123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7124
7125         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7126         case.
7127         (pass_on_stack): Use type_align.
7128         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7129         function.
7130
7131 2019-04-23  Tom Tromey  <tromey@adacore.com>
7132
7133         * dwarf2read.c (line_header::file_name_at): Remove unused
7134         overload.
7135
7136 2019-04-23  Tom de Vries  <tdevries@suse.de>
7137
7138         PR gdb/24438
7139         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7140         invocation.
7141
7142
7143 2019-03-27  Ali Tamur  <tamur@google.com>
7144
7145         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7146         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7147         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7148         (dwarf_expr_context::get_addr_index): Likewise
7149         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7150         (symbol_needs_eval_context::get_addr_index): Likewise
7151         (disassemble_dwarf_expression): Add DW_OP_addrx
7152         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7153         (read_cutu_die_from_dwo): Update comment
7154         (skip_one_die): Add DW_FORM_addrx
7155         (read_attribute_value): Likewise
7156         (var_decode_location): Add DW_OP_addrx
7157         (dwarf2_const_value_attr): Add DW_FORM_addrx
7158         (dump_die_shallow): Likewise
7159         (dwarf2_fetch_constant_bytes): Likewise
7160         (decode_locdesc): Add DW_OP_addrx
7161         (skip_form_bytes): Add DW_FORM_addrx
7162
7163 2019-04-22  Ali Tamur  <tamur@google.com>
7164
7165         * MAINTAINERS (Write After Approval): Add self.
7166
7167 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7168
7169         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7170         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7171         (open_symbol_file_object): Likewise.
7172         (svr4_default_sos): Add info parameter.
7173         (svr4_read_so_list): Likewise.
7174         (svr4_current_sos_direct): Adjust functions calls to pass down
7175         info.
7176         (svr4_current_sos_1): Add info parameter.
7177         (svr4_current_sos): Call get_svr4_info, pass info down to
7178         svr4_current_sos_1.
7179         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7180         get_svr4_info.
7181         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7182         get_svr4_info.
7183         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7184         to get_svr4_info.
7185         (probes_table_remove_objfile_probes): Likewise.
7186         (register_solib_event_probe): Add info parameter.
7187         (solist_update_incremental): Pass info parameter down to
7188         svr4_read_so_list.
7189         (disable_probes_interface): Add info parameter.
7190         (svr4_handle_solib_event): Pass current_program_space to
7191         get_svr4_info.  Adjust disable_probes_interface cleanup.
7192         (svr4_create_probe_breakpoints): Add info parameter, pass it
7193         down to register_solib_event_probe.
7194         (svr4_create_solib_event_breakpoints): Add info parameter,
7195         pass it down to svr4_create_probe_breakpoints.
7196         (enable_break): Pass info down to
7197         svr4_create_solib_event_breakpoints.
7198         (svr4_solib_create_inferior_hook): Pass current_program_space to
7199         get_svr4_info.
7200         (svr4_clear_solib): Likewise.
7201
7202 2019-04-22  Pedro Alves  <palves@redhat.com>
7203
7204         * solib-svr4.c (svr4_free_objfile_observer): New.
7205         (probe_and_action::objfile): New field.
7206         (probes_table_htab_remove_objfile_probes)
7207         (probes_table_remove_objfile_probes): New functions.
7208         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7209         in the new probe_and_action.  Don't store the probe in 'lookup'.
7210         (svr4_create_probe_breakpoints): Pass objfile to
7211         register_solib_event_probe.
7212         (_initialize_svr4_solib): Register a free_objfile observer.
7213
7214 2019-04-19  Tom Tromey  <tom@tromey.com>
7215
7216         * common/queue.h: Remove.
7217
7218 2019-04-19  Tom Tromey  <tom@tromey.com>
7219
7220         * event-loop.c: Don't include "common/queue.h".
7221
7222 2019-04-19  Tom Tromey  <tom@tromey.com>
7223
7224         * remote.c (remote_target): Use delete.
7225         * remote-notif.h: Include <list>, not "common/queue.h".
7226         (notif_client_p): Remove typedef.
7227         (remote_notif_state): Add constructor, destructor, initializer.
7228         <notif_queue>: Now a std::list.
7229         (remote_notif_state_xfree): Don't declare.
7230         * remote-notif.c (remote_notif_process, handle_notification)
7231         (remote_notif_state_allocate): Update.
7232         (~remote_notif_state): Rename from remote_notif_state_xfree.
7233
7234 2019-04-19  Tom Tromey  <tom@tromey.com>
7235
7236         * symfile.c (reread_symbols): Update.
7237         * objfiles.c (objfile_register_static_link)
7238         (objfile_lookup_static_link): Update
7239         (~objfile) Don't delete static_links.
7240         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7241
7242 2019-04-19  Tom Tromey  <tom@tromey.com>
7243
7244         * type-stack.h (struct type_stack) <insert>: Constify string.
7245         * type-stack.c (type_stack::insert): Constify string.
7246         * gdbtypes.h (lookup_template_type): Update.
7247         (address_space_name_to_int): Update.
7248         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7249         const.
7250         (lookup_template_type): Make name const.
7251         * c-exp.y: Update rules.
7252         (lex_one_token, classify_name, classify_inner_name)
7253         (c_print_token): Update.
7254         * p-exp.y: Update rules.
7255         (yylex): Update.
7256         * f-exp.y: Update rules.
7257         (yylex): Update.
7258         * d-exp.y: Update rules.
7259         (lex_one_token, classify_name, classify_inner_name): Update.
7260         * parse.c (write_dollar_variable, copy_name): Return std::string.
7261         * parser-defs.h (copy_name): Change return type.
7262         * m2-exp.y: Update rules.
7263         (yylex): Update.
7264         * go-exp.y (lex_one_token): Update.
7265         Update rules.
7266         (classify_unsafe_function, classify_packaged_name)
7267         (classify_name, yylex): Update.
7268
7269 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7270
7271         * configure.ac: add --enable-source-highlight switch.
7272         * configure: Regenerate.
7273         * top.c (print_gdb_version): plumb --enable-source-highlight
7274         status to "show configuration".
7275
7276 2019-04-19  Tom Tromey  <tromey@adacore.com>
7277
7278         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7279         Check ADA_TYPE_P.
7280         (empty_record, ada_template_to_fixed_record_type_1)
7281         (template_to_static_fixed_type)
7282         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7283         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7284         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7285         macros.
7286
7287 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7288
7289         PR symtab/24423:
7290         * source.c (print_source_lines_base): Advance "iter" when a
7291         control character is seen.
7292
7293 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7294
7295         * inferior.h (struct infcall_suspend_state_deleter):
7296         Catch exception in destructor to avoid crash.
7297
7298 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7299
7300         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7301         close to the add_com "shell".
7302
7303 2019-04-18  Tom Tromey  <tromey@adacore.com>
7304
7305         * process-stratum-target.h (class process_stratum_target)
7306         <stratum>: Add "final".
7307
7308 2019-04-17  Tom Tromey  <tromey@adacore.com>
7309
7310         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7311         against nullptr before use.
7312
7313 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7314
7315         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7316
7317 2019-04-17  Jim Wilson  <jimw@sifive.com>
7318             Andrew Burgess  <andrew.burgess@embecosm.com>
7319
7320         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7321         code read might fail, assume 4-byte breakpoint in that case.
7322
7323 2019-04-15  Leszek Swirski  <leszeks@google.com>
7324
7325         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7326         rather than a hand-rolled POD check when checking for forced MEMORY
7327         classification.
7328
7329 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7330
7331         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7332         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7333         function.
7334         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7335         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7336         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7337         declaration.
7338
7339 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7340
7341         * aarch64-linux-nat.c
7342         (aarch64_linux_nat_target::thread_architecture): Add override.
7343         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7344         each VQ.
7345
7346 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7347
7348         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7349
7350 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7351
7352         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7353         target types of size 96-bits, add some additional comments, and
7354         check that the builtin type we found was the correct size.
7355
7356 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7357
7358         * utils.c (prompt_for_continue): Don't restore the styling at the
7359         end, as applied_style has the wrong value.  This fixes styling in
7360         long lists of file names that are interrupted by the "Continue?"
7361         prompt.
7362
7363 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7364
7365         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7366         * c-lang.c (c_language_defn): Likewise.
7367         (cplus_language_defn): Likewise.
7368         (asm_language_defn): Likewise.
7369         (minimal_language_defn): Likewise.
7370         * d-lang.c (d_language_defn): Likewise.
7371         * f-lang.c (f_language_defn): Likewise.
7372         * go-lang.c (go_language_defn): Likewise.
7373         * language.c (unknown_language_defn): Likewise.
7374         (auto_language_defn): Likewise.
7375         * language.h (struct language_defn): Remove la_magic field.
7376         (LANG_MAGIC): Delete.
7377         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7378         * objc-lang.c (objc_language_defn): Likewise.
7379         * opencl-lang.c (opencl_language_defn): Likewise.
7380         * p-lang.c (pascal_language_defn): Likewise.
7381         * rust-lang.c (rust_language_defn): Likewise.
7382
7383 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7384
7385         * riscv-tdep.c (riscv_type_align): New function.
7386         (riscv_type_alignment): Delete.
7387         (riscv_arg_location): Use 'type_align'.
7388         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7389
7390 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7391
7392         * gdbtypes.c (type_align): A struct with no non-static fields also
7393         has alignment of 1.
7394
7395 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7396
7397         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7398         component to 0.
7399         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7400         member.
7401         (riscv_struct_info::analyse): New implementation using new
7402         analyse_inner member function.
7403         (riscv_struct_info::field_offset): New member function.
7404         (riscv_struct_info::m_offsets): New member variable.
7405         (riscv_struct_info::analyse_inner): New private member function,
7406         takes the old implementation of riscv_struct_info::analyse but
7407         extended to track field offsets.
7408         (riscv_call_arg_struct): Update the struct folding special cases
7409         to handle cases where empty C++ structs, which are non-zero
7410         length, are found.
7411         (riscv_arg_location): Initialise the length of each location, a
7412         non-zero length now indicates the location is in use.
7413         (riscv_push_dummy_call): Allow for the first location having a
7414         non-zero offset when setting up arguments.
7415         (riscv_return_value): Likewise, but for return values.
7416
7417 2019-04-11  Tom Tromey  <tromey@adacore.com>
7418
7419         * utils.c (internal_vproblem): Make "msg" const.
7420
7421 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7422
7423         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7424         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7425         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7426         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7427
7428 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7429
7430         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7431         function.
7432         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7433         of amd64_collect_native_gregset.
7434         (amd64_linux_nat_target::store_registers): Likewise.
7435
7436 2019-04-10  Tom Tromey  <tom@tromey.com>
7437
7438         * symtab.c (lookup_global_symbol_from_objfile)
7439         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7440         * objfiles.h (class separate_debug_iterator): New.
7441         (class separate_debug_range): New.
7442         (struct objfile) <separate_debug_objfiles>: New method.
7443         (objfile_separate_debug_iterate): Don't declare.
7444         * objfiles.c (separate_debug_iterator::operator++): Rename from
7445         objfile_separate_debug_iterate.
7446         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7447         iterator.
7448         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7449         iterator.
7450
7451 2019-04-10  Tom Tromey  <tom@tromey.com>
7452
7453         * symfile.c (reread_symbols): Remove old comment.
7454         * objfiles.c (free_all_objfiles): Fix a typo.
7455
7456 2019-04-10  Tom Tromey  <tom@tromey.com>
7457
7458         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7459         * minsyms.c (lookup_minimal_symbol): Use foreach.
7460         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7461         (lookup_minimal_symbol_solib_trampoline): Likewise.
7462         * symfile.c (reread_symbols): Use foreach.
7463
7464 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7465             Tom Tromey  <tromey@adacore.com>
7466
7467         PR rust/24414:
7468         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7469         (rust_lex_int_test): Change "value" to be LONGEST.
7470         (rust_lex_tests): Add test for long integer literal.
7471
7472 2019-04-09  Tom Tromey  <tromey@adacore.com>
7473
7474         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7475         to bool.
7476         (extended_remote_target::attach): Update.
7477         (remote_target::remote_notice_new_inferior): Update.
7478         (remote_target::add_current_inferior_and_thread): Update.
7479         * inferior.c (exit_inferior_1): Use "false".
7480         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7481
7482 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7483
7484         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7485         the "start" command.
7486
7487 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7488
7489         * python/py-inferior.c (infpy_thread_from_thread_handle):
7490         Adjust comments to reflect renaming of thread_from_thread_handle
7491         to thread_from_handle.  Adjust keywords.  Fix type error message.
7492         (inferior_object_methods): Add thread_from_handle.  Retain
7493         thread_from_thread_handle, but mark it as deprecated.
7494
7495 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7496
7497         * gdbthread.h (find_thread_by_handle): Revise declaration.
7498         * thread.c (find_thread_by_handle): Likewise.  Adjust
7499         implementation too.
7500         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7501         support for buffer objects as handles.
7502
7503 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7504
7505         * python/py-infthread.c (thpy_thread_handle): New function.
7506         (thread_object_methods): Register thpy_thread_handle.
7507
7508 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7509
7510         * gdbthread.h (thread_to_thread_handle): Declare.
7511         * thread.c (gdbtypes.h): Include.
7512         (thread_to_thread_handle): New function.
7513
7514         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7515         (target_thread_info_to_thread_handle): Declare.
7516         * target.c (target_thread_info_to_thread_handle): New function.
7517         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7518         * target-delegates.c: Regenerate.
7519
7520         * linux-thread-db.c (class thread_db_target): Add method
7521         thread_info_to_thread_handle.
7522         (thread_db_target::thread_info_to_thread_handle): Define.
7523         * remote.c (class remote_target): Add new method
7524         thread_info_to_thread_handle.
7525         (remote_target::thread_info_to_thread_handle): Define.
7526
7527 2019-04-08  Pedro Alves  <palves@redhat.com>
7528
7529         * common/common-exceptions.c (throw_exception): Don't create
7530         named object to throw; throw directly.
7531         (throw_it): Likewise.  Don't initialize gdb_exception::message
7532         here, with new; pass FMT and AP to the ctor instead.
7533         * common/common-exceptions.h: Include <string>.
7534         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7535         const char *, va_list)): New ctor.  Use std::make_shared.
7536         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7537         errors)): Delete.
7538         (gdb_exception_error::gdb_exception_error(enum errors, const char
7539         *, va_list)): New.
7540         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7541         Add assertion.
7542         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7543         errors)): Delete.
7544         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7545         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7546         Add assertion.
7547
7548 2019-04-08  Tom Tromey  <tom@tromey.com>
7549
7550         * valops.c (value_rtti_indirect_type): Replace throw_exception
7551         with throw.
7552         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7553         with throw.
7554         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7555         throw.
7556         * target.c (target_translate_tls_address): Replace throw_exception
7557         with throw.
7558         * stack.c (frame_apply_command_count): Replace throw_exception
7559         with throw.
7560         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7561         throw.
7562         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7563         with throw.
7564         * rs6000-tdep.c (rs6000_frame_cache)
7565         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7566         * remote.c: Replace throw_exception with throw.
7567         * record-full.c (record_full_message, record_full_wait_1)
7568         (record_full_restore): Replace throw_exception with throw.
7569         * record-btrace.c:
7570         (get_thread_current_frame_id, record_btrace_start_replaying)
7571         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7572         (cmd_record_btrace_start): Replace throw_exception with throw.
7573         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7574         throw.
7575         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7576         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7577         * linespec.c:
7578         (find_linespec_symbols): Replace throw_exception with throw.
7579         * infrun.c (displaced_step_prepare, resume): Replace
7580         throw_exception with throw.
7581         * infcmd.c (post_create_inferior): Replace throw_exception with
7582         throw.
7583         * inf-loop.c (inferior_event_handler): Replace throw_exception
7584         with throw.
7585         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7586         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7587         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7588         (get_prev_frame_always, get_frame_pc_if_available)
7589         (get_frame_address_in_block_if_available, get_frame_language):
7590         Replace throw_exception with throw.
7591         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7592         throw_exception with throw.
7593         * eval.c (fetch_subexp_value, evaluate_var_value)
7594         (evaluate_funcall, evaluate_subexp_standard): Replace
7595         throw_exception with throw.
7596         * dwarf2loc.c (call_site_find_chain)
7597         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7598         Replace throw_exception with throw.
7599         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7600         with throw.
7601         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7602         throw.
7603         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7604         * completer.c (complete_line_internal): Replace throw_exception
7605         with throw.
7606         * compile/compile-object-run.c (compile_object_run): Replace
7607         throw_exception with throw.
7608         * cli/cli-script.c (process_next_line): Replace throw_exception
7609         with throw.
7610         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7611         (btrace_enable, btrace_maint_update_pt_packets): Replace
7612         throw_exception with throw.
7613         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7614         throw_exception with throw.
7615         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7616         throw_exception with throw.
7617         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7618         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7619         * aarch64-tdep.c (aarch64_make_prologue_cache)
7620         (aarch64_make_stub_cache): Replace throw_exception with throw.
7621
7622 2019-04-08  Tom Tromey  <tom@tromey.com>
7623
7624         * common/common-exceptions.c (throw_exception): Rename from
7625         throw_exception_cxx.  Remove old copy.  Make argument const.
7626         (throw_it): Create and throw exception objects directly.
7627         * common/common-exceptions.h (throw_exception): Make argument
7628         const.
7629         (struct gdb_exception_error): Add constructor.
7630         (struct gdb_exception_quit): Add constructor.
7631
7632 2019-04-08  Tom Tromey  <tom@tromey.com>
7633
7634         * common/common-exceptions.h (exception_rethrow): Don't declare.
7635         (TRY_SJLJ): Update comment.
7636         (TRY, CATCH, END_CATCH): Remove.
7637         * common/common-exceptions.c (exception_rethrow): Remove.
7638
7639 2019-04-08  Tom Tromey  <tom@tromey.com>
7640
7641         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7642         Remove.
7643         (gdb_exception_error): Rename from
7644         gdb_exception_RETURN_MASK_ERROR.
7645         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7646         (gdb_quit_bad_alloc): Update.
7647         * aarch64-tdep.c: Update.
7648         * ada-lang.c: Update.
7649         * ada-typeprint.c: Update.
7650         * ada-valprint.c: Update.
7651         * amd64-tdep.c: Update.
7652         * arch-utils.c: Update.
7653         * break-catch-throw.c: Update.
7654         * breakpoint.c: Update.
7655         * btrace.c: Update.
7656         * c-varobj.c: Update.
7657         * cli/cli-cmds.c: Update.
7658         * cli/cli-interp.c: Update.
7659         * cli/cli-script.c: Update.
7660         * common/common-exceptions.c: Update.
7661         * common/new-op.c: Update.
7662         * common/selftest.c: Update.
7663         * compile/compile-c-symbols.c: Update.
7664         * compile/compile-cplus-symbols.c: Update.
7665         * compile/compile-object-load.c: Update.
7666         * compile/compile-object-run.c: Update.
7667         * completer.c: Update.
7668         * corelow.c: Update.
7669         * cp-abi.c: Update.
7670         * cp-support.c: Update.
7671         * cp-valprint.c: Update.
7672         * darwin-nat.c: Update.
7673         * disasm-selftests.c: Update.
7674         * dtrace-probe.c: Update.
7675         * dwarf-index-cache.c: Update.
7676         * dwarf-index-write.c: Update.
7677         * dwarf2-frame-tailcall.c: Update.
7678         * dwarf2-frame.c: Update.
7679         * dwarf2loc.c: Update.
7680         * dwarf2read.c: Update.
7681         * eval.c: Update.
7682         * event-loop.c: Update.
7683         * event-top.c: Update.
7684         * exec.c: Update.
7685         * f-valprint.c: Update.
7686         * fbsd-tdep.c: Update.
7687         * frame-unwind.c: Update.
7688         * frame.c: Update.
7689         * gdbtypes.c: Update.
7690         * gnu-v3-abi.c: Update.
7691         * guile/guile-internal.h: Update.
7692         * guile/scm-block.c: Update.
7693         * guile/scm-breakpoint.c: Update.
7694         * guile/scm-cmd.c: Update.
7695         * guile/scm-disasm.c: Update.
7696         * guile/scm-frame.c: Update.
7697         * guile/scm-lazy-string.c: Update.
7698         * guile/scm-math.c: Update.
7699         * guile/scm-param.c: Update.
7700         * guile/scm-ports.c: Update.
7701         * guile/scm-pretty-print.c: Update.
7702         * guile/scm-symbol.c: Update.
7703         * guile/scm-symtab.c: Update.
7704         * guile/scm-type.c: Update.
7705         * guile/scm-value.c: Update.
7706         * i386-linux-tdep.c: Update.
7707         * i386-tdep.c: Update.
7708         * inf-loop.c: Update.
7709         * infcall.c: Update.
7710         * infcmd.c: Update.
7711         * infrun.c: Update.
7712         * jit.c: Update.
7713         * language.c: Update.
7714         * linespec.c: Update.
7715         * linux-fork.c: Update.
7716         * linux-nat.c: Update.
7717         * linux-tdep.c: Update.
7718         * linux-thread-db.c: Update.
7719         * main.c: Update.
7720         * mi/mi-cmd-break.c: Update.
7721         * mi/mi-cmd-stack.c: Update.
7722         * mi/mi-interp.c: Update.
7723         * mi/mi-main.c: Update.
7724         * objc-lang.c: Update.
7725         * p-valprint.c: Update.
7726         * parse.c: Update.
7727         * ppc-linux-tdep.c: Update.
7728         * printcmd.c: Update.
7729         * python/py-arch.c: Update.
7730         * python/py-breakpoint.c: Update.
7731         * python/py-cmd.c: Update.
7732         * python/py-finishbreakpoint.c: Update.
7733         * python/py-frame.c: Update.
7734         * python/py-framefilter.c: Update.
7735         * python/py-gdb-readline.c: Update.
7736         * python/py-inferior.c: Update.
7737         * python/py-infthread.c: Update.
7738         * python/py-lazy-string.c: Update.
7739         * python/py-linetable.c: Update.
7740         * python/py-objfile.c: Update.
7741         * python/py-param.c: Update.
7742         * python/py-prettyprint.c: Update.
7743         * python/py-progspace.c: Update.
7744         * python/py-record-btrace.c: Update.
7745         * python/py-record.c: Update.
7746         * python/py-symbol.c: Update.
7747         * python/py-type.c: Update.
7748         * python/py-unwind.c: Update.
7749         * python/py-utils.c: Update.
7750         * python/py-value.c: Update.
7751         * python/python.c: Update.
7752         * record-btrace.c: Update.
7753         * record-full.c: Update.
7754         * remote-fileio.c: Update.
7755         * remote.c: Update.
7756         * riscv-tdep.c: Update.
7757         * rs6000-aix-tdep.c: Update.
7758         * rs6000-tdep.c: Update.
7759         * rust-exp.y: Update.
7760         * rust-lang.c: Update.
7761         * s390-tdep.c: Update.
7762         * selftest-arch.c: Update.
7763         * solib-dsbt.c: Update.
7764         * solib-frv.c: Update.
7765         * solib-spu.c: Update.
7766         * solib-svr4.c: Update.
7767         * solib.c: Update.
7768         * sparc64-linux-tdep.c: Update.
7769         * stack.c: Update.
7770         * symfile-mem.c: Update.
7771         * symmisc.c: Update.
7772         * target.c: Update.
7773         * thread.c: Update.
7774         * top.c: Update.
7775         * tracefile-tfile.c: Update.
7776         * tui/tui.c: Update.
7777         * typeprint.c: Update.
7778         * unittests/cli-utils-selftests.c: Update.
7779         * unittests/parse-connection-spec-selftests.c: Update.
7780         * valops.c: Update.
7781         * valprint.c: Update.
7782         * value.c: Update.
7783         * varobj.c: Update.
7784         * windows-nat.c: Update.
7785         * x86-linux-nat.c: Update.
7786         * xml-support.c: Update.
7787
7788 2019-04-08  Tom Tromey  <tom@tromey.com>
7789
7790         * xml-support.c: Use C++ exception handling.
7791         * x86-linux-nat.c: Use C++ exception handling.
7792         * windows-nat.c: Use C++ exception handling.
7793         * varobj.c: Use C++ exception handling.
7794         * value.c: Use C++ exception handling.
7795         * valprint.c: Use C++ exception handling.
7796         * valops.c: Use C++ exception handling.
7797         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7798         handling.
7799         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7800         * typeprint.c: Use C++ exception handling.
7801         * tui/tui.c: Use C++ exception handling.
7802         * tracefile-tfile.c: Use C++ exception handling.
7803         * top.c: Use C++ exception handling.
7804         * thread.c: Use C++ exception handling.
7805         * target.c: Use C++ exception handling.
7806         * symmisc.c: Use C++ exception handling.
7807         * symfile-mem.c: Use C++ exception handling.
7808         * stack.c: Use C++ exception handling.
7809         * sparc64-linux-tdep.c: Use C++ exception handling.
7810         * solib.c: Use C++ exception handling.
7811         * solib-svr4.c: Use C++ exception handling.
7812         * solib-spu.c: Use C++ exception handling.
7813         * solib-frv.c: Use C++ exception handling.
7814         * solib-dsbt.c: Use C++ exception handling.
7815         * selftest-arch.c: Use C++ exception handling.
7816         * s390-tdep.c: Use C++ exception handling.
7817         * rust-lang.c: Use C++ exception handling.
7818         * rust-exp.y: Use C++ exception handling.
7819         * rs6000-tdep.c: Use C++ exception handling.
7820         * rs6000-aix-tdep.c: Use C++ exception handling.
7821         * riscv-tdep.c: Use C++ exception handling.
7822         * remote.c: Use C++ exception handling.
7823         * remote-fileio.c: Use C++ exception handling.
7824         * record-full.c: Use C++ exception handling.
7825         * record-btrace.c: Use C++ exception handling.
7826         * python/python.c: Use C++ exception handling.
7827         * python/py-value.c: Use C++ exception handling.
7828         * python/py-utils.c: Use C++ exception handling.
7829         * python/py-unwind.c: Use C++ exception handling.
7830         * python/py-type.c: Use C++ exception handling.
7831         * python/py-symbol.c: Use C++ exception handling.
7832         * python/py-record.c: Use C++ exception handling.
7833         * python/py-record-btrace.c: Use C++ exception handling.
7834         * python/py-progspace.c: Use C++ exception handling.
7835         * python/py-prettyprint.c: Use C++ exception handling.
7836         * python/py-param.c: Use C++ exception handling.
7837         * python/py-objfile.c: Use C++ exception handling.
7838         * python/py-linetable.c: Use C++ exception handling.
7839         * python/py-lazy-string.c: Use C++ exception handling.
7840         * python/py-infthread.c: Use C++ exception handling.
7841         * python/py-inferior.c: Use C++ exception handling.
7842         * python/py-gdb-readline.c: Use C++ exception handling.
7843         * python/py-framefilter.c: Use C++ exception handling.
7844         * python/py-frame.c: Use C++ exception handling.
7845         * python/py-finishbreakpoint.c: Use C++ exception handling.
7846         * python/py-cmd.c: Use C++ exception handling.
7847         * python/py-breakpoint.c: Use C++ exception handling.
7848         * python/py-arch.c: Use C++ exception handling.
7849         * printcmd.c: Use C++ exception handling.
7850         * ppc-linux-tdep.c: Use C++ exception handling.
7851         * parse.c: Use C++ exception handling.
7852         * p-valprint.c: Use C++ exception handling.
7853         * objc-lang.c: Use C++ exception handling.
7854         * mi/mi-main.c: Use C++ exception handling.
7855         * mi/mi-interp.c: Use C++ exception handling.
7856         * mi/mi-cmd-stack.c: Use C++ exception handling.
7857         * mi/mi-cmd-break.c: Use C++ exception handling.
7858         * main.c: Use C++ exception handling.
7859         * linux-thread-db.c: Use C++ exception handling.
7860         * linux-tdep.c: Use C++ exception handling.
7861         * linux-nat.c: Use C++ exception handling.
7862         * linux-fork.c: Use C++ exception handling.
7863         * linespec.c: Use C++ exception handling.
7864         * language.c: Use C++ exception handling.
7865         * jit.c: Use C++ exception handling.
7866         * infrun.c: Use C++ exception handling.
7867         * infcmd.c: Use C++ exception handling.
7868         * infcall.c: Use C++ exception handling.
7869         * inf-loop.c: Use C++ exception handling.
7870         * i386-tdep.c: Use C++ exception handling.
7871         * i386-linux-tdep.c: Use C++ exception handling.
7872         * guile/scm-value.c: Use C++ exception handling.
7873         * guile/scm-type.c: Use C++ exception handling.
7874         * guile/scm-symtab.c: Use C++ exception handling.
7875         * guile/scm-symbol.c: Use C++ exception handling.
7876         * guile/scm-pretty-print.c: Use C++ exception handling.
7877         * guile/scm-ports.c: Use C++ exception handling.
7878         * guile/scm-param.c: Use C++ exception handling.
7879         * guile/scm-math.c: Use C++ exception handling.
7880         * guile/scm-lazy-string.c: Use C++ exception handling.
7881         * guile/scm-frame.c: Use C++ exception handling.
7882         * guile/scm-disasm.c: Use C++ exception handling.
7883         * guile/scm-cmd.c: Use C++ exception handling.
7884         * guile/scm-breakpoint.c: Use C++ exception handling.
7885         * guile/scm-block.c: Use C++ exception handling.
7886         * guile/guile-internal.h: Use C++ exception handling.
7887         * gnu-v3-abi.c: Use C++ exception handling.
7888         * gdbtypes.c: Use C++ exception handling.
7889         * frame.c: Use C++ exception handling.
7890         * frame-unwind.c: Use C++ exception handling.
7891         * fbsd-tdep.c: Use C++ exception handling.
7892         * f-valprint.c: Use C++ exception handling.
7893         * exec.c: Use C++ exception handling.
7894         * event-top.c: Use C++ exception handling.
7895         * event-loop.c: Use C++ exception handling.
7896         * eval.c: Use C++ exception handling.
7897         * dwarf2read.c: Use C++ exception handling.
7898         * dwarf2loc.c: Use C++ exception handling.
7899         * dwarf2-frame.c: Use C++ exception handling.
7900         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7901         * dwarf-index-write.c: Use C++ exception handling.
7902         * dwarf-index-cache.c: Use C++ exception handling.
7903         * dtrace-probe.c: Use C++ exception handling.
7904         * disasm-selftests.c: Use C++ exception handling.
7905         * darwin-nat.c: Use C++ exception handling.
7906         * cp-valprint.c: Use C++ exception handling.
7907         * cp-support.c: Use C++ exception handling.
7908         * cp-abi.c: Use C++ exception handling.
7909         * corelow.c: Use C++ exception handling.
7910         * completer.c: Use C++ exception handling.
7911         * compile/compile-object-run.c: Use C++ exception handling.
7912         * compile/compile-object-load.c: Use C++ exception handling.
7913         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7914         * compile/compile-c-symbols.c: Use C++ exception handling.
7915         * common/selftest.c: Use C++ exception handling.
7916         * common/new-op.c: Use C++ exception handling.
7917         * cli/cli-script.c: Use C++ exception handling.
7918         * cli/cli-interp.c: Use C++ exception handling.
7919         * cli/cli-cmds.c: Use C++ exception handling.
7920         * c-varobj.c: Use C++ exception handling.
7921         * btrace.c: Use C++ exception handling.
7922         * breakpoint.c: Use C++ exception handling.
7923         * break-catch-throw.c: Use C++ exception handling.
7924         * arch-utils.c: Use C++ exception handling.
7925         * amd64-tdep.c: Use C++ exception handling.
7926         * ada-valprint.c: Use C++ exception handling.
7927         * ada-typeprint.c: Use C++ exception handling.
7928         * ada-lang.c: Use C++ exception handling.
7929         * aarch64-tdep.c: Use C++ exception handling.
7930
7931 2019-04-08  Tom Tromey  <tom@tromey.com>
7932
7933         * xml-support.c (gdb_xml_parser::parse): Update.
7934         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7935         * value.c (show_convenience): Update.
7936         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7937         (test_parse_flags_qcs): Update.
7938         * thread.c (thr_try_catch_cmd): Update.
7939         * target.c (target_translate_tls_address): Update.
7940         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7941         (info_frame_command_core, frame_apply_command_count): Update.
7942         * rust-exp.y (rust_lex_exception_test): Update.
7943         * riscv-tdep.c (riscv_print_one_register_info): Update.
7944         * remote.c (remote_target::enable_btrace): Update.
7945         * record-btrace.c (record_btrace_enable_warn): Update.
7946         * python/py-utils.c (gdbpy_convert_exception): Update.
7947         * printcmd.c (do_one_display, print_variable_and_value): Update.
7948         * mi/mi-main.c (mi_print_exception): Update.
7949         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7950         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7951         * linux-nat.c (linux_nat_target::attach): Update.
7952         * linux-fork.c (class scoped_switch_fork_info): Update.
7953         * infrun.c (displaced_step_prepare): Update.
7954         * infcall.c (call_function_by_hand_dummy): Update.
7955         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7956         * gnu-v3-abi.c (print_one_vtable): Update.
7957         * frame.c (get_prev_frame_always): Update.
7958         * f-valprint.c (info_common_command_for_block): Update.
7959         * exec.c (try_open_exec_file): Update.
7960         * exceptions.c (print_exception, exception_print)
7961         (exception_fprintf, exception_print_same): Update.
7962         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7963         * dwarf-index-cache.c (index_cache::store)
7964         (index_cache::lookup_gdb_index): Update.
7965         * darwin-nat.c (maybe_cache_shell): Update.
7966         * cp-valprint.c (cp_print_value_fields): Update.
7967         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7968         (gcc_cplus_symbol_address): Update.
7969         * compile/compile-c-symbols.c (gcc_convert_symbol)
7970         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7971         * common/selftest.c: Update.
7972         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7973         a std::string.
7974         (exception_try_scope_entry, exception_try_scope_exit): Don't
7975         declare.
7976         (struct exception_try_scope): Remove.
7977         (TRY): Don't use exception_try_scope.
7978         (struct gdb_exception): Add constructor, operator=.
7979         <what>: New method.
7980         (struct gdb_exception_RETURN_MASK_ALL)
7981         (struct gdb_exception_RETURN_MASK_ERROR)
7982         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7983         (struct gdb_quit_bad_alloc): Update.
7984         * common/common-exceptions.c (exception_none): Change
7985         initializer.
7986         (struct catcher) <state, exception>: Initialize inline.
7987         <prev>: Remove member.
7988         (current_catcher): Remove.
7989         (catchers): New global.
7990         (exceptions_state_mc_init): Simplify.
7991         (catcher_pop): Remove.
7992         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7993         (try_scope_depth, exception_try_scope_entry)
7994         (exception_try_scope_exit): Remove.
7995         (throw_exception_sjlj): Update.
7996         (exception_messages, exception_messages_size): Remove.
7997         (throw_it): Simplify.
7998         (gdb_exception_sliced_copy): Remove.
7999         (throw_exception_cxx): Update.
8000         * cli/cli-script.c (script_from_file): Update.
8001         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8002         Update.
8003         * ada-valprint.c (ada_val_print): Update.
8004         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8005         (create_excep_cond_exprs): Update.
8006
8007 2019-04-08  Tom Tromey  <tom@tromey.com>
8008
8009         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8010         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8011         (TRY, CATCH, END_CATCH): Remove some definitions.
8012         * common/common-exceptions.c: Don't use GDB_XCPT.
8013         (catcher_list_size): Remove.
8014         (throw_exception, throw_it): Simplify.
8015
8016 2019-04-05  Tom Tromey  <tom@tromey.com>
8017
8018         Revert the header-sorting patch.
8019         * ft32-tdep.c: Revert.
8020         * frv-tdep.c: Revert.
8021         * frv-linux-tdep.c: Revert.
8022         * frame.c: Revert.
8023         * frame-unwind.c: Revert.
8024         * frame-base.c: Revert.
8025         * fork-child.c: Revert.
8026         * findvar.c: Revert.
8027         * findcmd.c: Revert.
8028         * filesystem.c: Revert.
8029         * filename-seen-cache.h: Revert.
8030         * filename-seen-cache.c: Revert.
8031         * fbsd-tdep.c: Revert.
8032         * fbsd-nat.h: Revert.
8033         * fbsd-nat.c: Revert.
8034         * f-valprint.c: Revert.
8035         * f-typeprint.c: Revert.
8036         * f-lang.c: Revert.
8037         * extension.h: Revert.
8038         * extension.c: Revert.
8039         * extension-priv.h: Revert.
8040         * expprint.c: Revert.
8041         * exec.h: Revert.
8042         * exec.c: Revert.
8043         * exceptions.c: Revert.
8044         * event-top.c: Revert.
8045         * event-loop.c: Revert.
8046         * eval.c: Revert.
8047         * elfread.c: Revert.
8048         * dwarf2read.h: Revert.
8049         * dwarf2read.c: Revert.
8050         * dwarf2loc.c: Revert.
8051         * dwarf2expr.h: Revert.
8052         * dwarf2expr.c: Revert.
8053         * dwarf2-frame.c: Revert.
8054         * dwarf2-frame-tailcall.c: Revert.
8055         * dwarf-index-write.h: Revert.
8056         * dwarf-index-write.c: Revert.
8057         * dwarf-index-common.c: Revert.
8058         * dwarf-index-cache.h: Revert.
8059         * dwarf-index-cache.c: Revert.
8060         * dummy-frame.c: Revert.
8061         * dtrace-probe.c: Revert.
8062         * disasm.h: Revert.
8063         * disasm.c: Revert.
8064         * disasm-selftests.c: Revert.
8065         * dictionary.c: Revert.
8066         * dicos-tdep.c: Revert.
8067         * demangle.c: Revert.
8068         * dcache.h: Revert.
8069         * dcache.c: Revert.
8070         * darwin-nat.h: Revert.
8071         * darwin-nat.c: Revert.
8072         * darwin-nat-info.c: Revert.
8073         * d-valprint.c: Revert.
8074         * d-namespace.c: Revert.
8075         * d-lang.c: Revert.
8076         * ctf.c: Revert.
8077         * csky-tdep.c: Revert.
8078         * csky-linux-tdep.c: Revert.
8079         * cris-tdep.c: Revert.
8080         * cris-linux-tdep.c: Revert.
8081         * cp-valprint.c: Revert.
8082         * cp-support.c: Revert.
8083         * cp-namespace.c: Revert.
8084         * cp-abi.c: Revert.
8085         * corelow.c: Revert.
8086         * corefile.c: Revert.
8087         * continuations.c: Revert.
8088         * completer.h: Revert.
8089         * completer.c: Revert.
8090         * complaints.c: Revert.
8091         * coffread.c: Revert.
8092         * coff-pe-read.c: Revert.
8093         * cli-out.h: Revert.
8094         * cli-out.c: Revert.
8095         * charset.c: Revert.
8096         * c-varobj.c: Revert.
8097         * c-valprint.c: Revert.
8098         * c-typeprint.c: Revert.
8099         * c-lang.c: Revert.
8100         * buildsym.c: Revert.
8101         * buildsym-legacy.c: Revert.
8102         * build-id.h: Revert.
8103         * build-id.c: Revert.
8104         * btrace.c: Revert.
8105         * bsd-uthread.c: Revert.
8106         * breakpoint.h: Revert.
8107         * breakpoint.c: Revert.
8108         * break-catch-throw.c: Revert.
8109         * break-catch-syscall.c: Revert.
8110         * break-catch-sig.c: Revert.
8111         * blockframe.c: Revert.
8112         * block.c: Revert.
8113         * bfin-tdep.c: Revert.
8114         * bfin-linux-tdep.c: Revert.
8115         * bfd-target.c: Revert.
8116         * bcache.c: Revert.
8117         * ax-general.c: Revert.
8118         * ax-gdb.h: Revert.
8119         * ax-gdb.c: Revert.
8120         * avr-tdep.c: Revert.
8121         * auxv.c: Revert.
8122         * auto-load.c: Revert.
8123         * arm-wince-tdep.c: Revert.
8124         * arm-tdep.c: Revert.
8125         * arm-symbian-tdep.c: Revert.
8126         * arm-pikeos-tdep.c: Revert.
8127         * arm-obsd-tdep.c: Revert.
8128         * arm-nbsd-tdep.c: Revert.
8129         * arm-nbsd-nat.c: Revert.
8130         * arm-linux-tdep.c: Revert.
8131         * arm-linux-nat.c: Revert.
8132         * arm-fbsd-tdep.c: Revert.
8133         * arm-fbsd-nat.c: Revert.
8134         * arm-bsd-tdep.c: Revert.
8135         * arch-utils.c: Revert.
8136         * arc-tdep.c: Revert.
8137         * arc-newlib-tdep.c: Revert.
8138         * annotate.h: Revert.
8139         * annotate.c: Revert.
8140         * amd64-windows-tdep.c: Revert.
8141         * amd64-windows-nat.c: Revert.
8142         * amd64-tdep.c: Revert.
8143         * amd64-sol2-tdep.c: Revert.
8144         * amd64-obsd-tdep.c: Revert.
8145         * amd64-obsd-nat.c: Revert.
8146         * amd64-nbsd-tdep.c: Revert.
8147         * amd64-nbsd-nat.c: Revert.
8148         * amd64-nat.c: Revert.
8149         * amd64-linux-tdep.c: Revert.
8150         * amd64-linux-nat.c: Revert.
8151         * amd64-fbsd-tdep.c: Revert.
8152         * amd64-fbsd-nat.c: Revert.
8153         * amd64-dicos-tdep.c: Revert.
8154         * amd64-darwin-tdep.c: Revert.
8155         * amd64-bsd-nat.c: Revert.
8156         * alpha-tdep.c: Revert.
8157         * alpha-obsd-tdep.c: Revert.
8158         * alpha-nbsd-tdep.c: Revert.
8159         * alpha-mdebug-tdep.c: Revert.
8160         * alpha-linux-tdep.c: Revert.
8161         * alpha-linux-nat.c: Revert.
8162         * alpha-bsd-tdep.c: Revert.
8163         * alpha-bsd-nat.c: Revert.
8164         * aix-thread.c: Revert.
8165         * agent.c: Revert.
8166         * addrmap.c: Revert.
8167         * ada-varobj.c: Revert.
8168         * ada-valprint.c: Revert.
8169         * ada-typeprint.c: Revert.
8170         * ada-tasks.c: Revert.
8171         * ada-lang.c: Revert.
8172         * aarch64-tdep.c: Revert.
8173         * aarch64-ravenscar-thread.c: Revert.
8174         * aarch64-newlib-tdep.c: Revert.
8175         * aarch64-linux-tdep.c: Revert.
8176         * aarch64-linux-nat.c: Revert.
8177         * aarch64-fbsd-tdep.c: Revert.
8178         * aarch64-fbsd-nat.c: Revert.
8179         * aarch32-linux-nat.c: Revert.
8180
8181 2019-04-05  Tom Tromey  <tom@tromey.com>
8182
8183         * ft32-tdep.c: Sort headers.
8184         * frv-tdep.c: Sort headers.
8185         * frv-linux-tdep.c: Sort headers.
8186         * frame.c: Sort headers.
8187         * frame-unwind.c: Sort headers.
8188         * frame-base.c: Sort headers.
8189         * fork-child.c: Sort headers.
8190         * findvar.c: Sort headers.
8191         * findcmd.c: Sort headers.
8192         * filesystem.c: Sort headers.
8193         * filename-seen-cache.h: Sort headers.
8194         * filename-seen-cache.c: Sort headers.
8195         * fbsd-tdep.c: Sort headers.
8196         * fbsd-nat.h: Sort headers.
8197         * fbsd-nat.c: Sort headers.
8198         * f-valprint.c: Sort headers.
8199         * f-typeprint.c: Sort headers.
8200         * f-lang.c: Sort headers.
8201         * extension.h: Sort headers.
8202         * extension.c: Sort headers.
8203         * extension-priv.h: Sort headers.
8204         * expprint.c: Sort headers.
8205         * exec.h: Sort headers.
8206         * exec.c: Sort headers.
8207         * exceptions.c: Sort headers.
8208         * event-top.c: Sort headers.
8209         * event-loop.c: Sort headers.
8210         * eval.c: Sort headers.
8211         * elfread.c: Sort headers.
8212         * dwarf2read.h: Sort headers.
8213         * dwarf2read.c: Sort headers.
8214         * dwarf2loc.c: Sort headers.
8215         * dwarf2expr.h: Sort headers.
8216         * dwarf2expr.c: Sort headers.
8217         * dwarf2-frame.c: Sort headers.
8218         * dwarf2-frame-tailcall.c: Sort headers.
8219         * dwarf-index-write.h: Sort headers.
8220         * dwarf-index-write.c: Sort headers.
8221         * dwarf-index-common.c: Sort headers.
8222         * dwarf-index-cache.h: Sort headers.
8223         * dwarf-index-cache.c: Sort headers.
8224         * dummy-frame.c: Sort headers.
8225         * dtrace-probe.c: Sort headers.
8226         * disasm.h: Sort headers.
8227         * disasm.c: Sort headers.
8228         * disasm-selftests.c: Sort headers.
8229         * dictionary.c: Sort headers.
8230         * dicos-tdep.c: Sort headers.
8231         * demangle.c: Sort headers.
8232         * dcache.h: Sort headers.
8233         * dcache.c: Sort headers.
8234         * darwin-nat.h: Sort headers.
8235         * darwin-nat.c: Sort headers.
8236         * darwin-nat-info.c: Sort headers.
8237         * d-valprint.c: Sort headers.
8238         * d-namespace.c: Sort headers.
8239         * d-lang.c: Sort headers.
8240         * ctf.c: Sort headers.
8241         * csky-tdep.c: Sort headers.
8242         * csky-linux-tdep.c: Sort headers.
8243         * cris-tdep.c: Sort headers.
8244         * cris-linux-tdep.c: Sort headers.
8245         * cp-valprint.c: Sort headers.
8246         * cp-support.c: Sort headers.
8247         * cp-namespace.c: Sort headers.
8248         * cp-abi.c: Sort headers.
8249         * corelow.c: Sort headers.
8250         * corefile.c: Sort headers.
8251         * continuations.c: Sort headers.
8252         * completer.h: Sort headers.
8253         * completer.c: Sort headers.
8254         * complaints.c: Sort headers.
8255         * coffread.c: Sort headers.
8256         * coff-pe-read.c: Sort headers.
8257         * cli-out.h: Sort headers.
8258         * cli-out.c: Sort headers.
8259         * charset.c: Sort headers.
8260         * c-varobj.c: Sort headers.
8261         * c-valprint.c: Sort headers.
8262         * c-typeprint.c: Sort headers.
8263         * c-lang.c: Sort headers.
8264         * buildsym.c: Sort headers.
8265         * buildsym-legacy.c: Sort headers.
8266         * build-id.h: Sort headers.
8267         * build-id.c: Sort headers.
8268         * btrace.c: Sort headers.
8269         * bsd-uthread.c: Sort headers.
8270         * breakpoint.h: Sort headers.
8271         * breakpoint.c: Sort headers.
8272         * break-catch-throw.c: Sort headers.
8273         * break-catch-syscall.c: Sort headers.
8274         * break-catch-sig.c: Sort headers.
8275         * blockframe.c: Sort headers.
8276         * block.c: Sort headers.
8277         * bfin-tdep.c: Sort headers.
8278         * bfin-linux-tdep.c: Sort headers.
8279         * bfd-target.c: Sort headers.
8280         * bcache.c: Sort headers.
8281         * ax-general.c: Sort headers.
8282         * ax-gdb.h: Sort headers.
8283         * ax-gdb.c: Sort headers.
8284         * avr-tdep.c: Sort headers.
8285         * auxv.c: Sort headers.
8286         * auto-load.c: Sort headers.
8287         * arm-wince-tdep.c: Sort headers.
8288         * arm-tdep.c: Sort headers.
8289         * arm-symbian-tdep.c: Sort headers.
8290         * arm-pikeos-tdep.c: Sort headers.
8291         * arm-obsd-tdep.c: Sort headers.
8292         * arm-nbsd-tdep.c: Sort headers.
8293         * arm-nbsd-nat.c: Sort headers.
8294         * arm-linux-tdep.c: Sort headers.
8295         * arm-linux-nat.c: Sort headers.
8296         * arm-fbsd-tdep.c: Sort headers.
8297         * arm-fbsd-nat.c: Sort headers.
8298         * arm-bsd-tdep.c: Sort headers.
8299         * arch-utils.c: Sort headers.
8300         * arc-tdep.c: Sort headers.
8301         * arc-newlib-tdep.c: Sort headers.
8302         * annotate.h: Sort headers.
8303         * annotate.c: Sort headers.
8304         * amd64-windows-tdep.c: Sort headers.
8305         * amd64-windows-nat.c: Sort headers.
8306         * amd64-tdep.c: Sort headers.
8307         * amd64-sol2-tdep.c: Sort headers.
8308         * amd64-obsd-tdep.c: Sort headers.
8309         * amd64-obsd-nat.c: Sort headers.
8310         * amd64-nbsd-tdep.c: Sort headers.
8311         * amd64-nbsd-nat.c: Sort headers.
8312         * amd64-nat.c: Sort headers.
8313         * amd64-linux-tdep.c: Sort headers.
8314         * amd64-linux-nat.c: Sort headers.
8315         * amd64-fbsd-tdep.c: Sort headers.
8316         * amd64-fbsd-nat.c: Sort headers.
8317         * amd64-dicos-tdep.c: Sort headers.
8318         * amd64-darwin-tdep.c: Sort headers.
8319         * amd64-bsd-nat.c: Sort headers.
8320         * alpha-tdep.c: Sort headers.
8321         * alpha-obsd-tdep.c: Sort headers.
8322         * alpha-nbsd-tdep.c: Sort headers.
8323         * alpha-mdebug-tdep.c: Sort headers.
8324         * alpha-linux-tdep.c: Sort headers.
8325         * alpha-linux-nat.c: Sort headers.
8326         * alpha-bsd-tdep.c: Sort headers.
8327         * alpha-bsd-nat.c: Sort headers.
8328         * aix-thread.c: Sort headers.
8329         * agent.c: Sort headers.
8330         * addrmap.c: Sort headers.
8331         * ada-varobj.c: Sort headers.
8332         * ada-valprint.c: Sort headers.
8333         * ada-typeprint.c: Sort headers.
8334         * ada-tasks.c: Sort headers.
8335         * ada-lang.c: Sort headers.
8336         * aarch64-tdep.c: Sort headers.
8337         * aarch64-ravenscar-thread.c: Sort headers.
8338         * aarch64-newlib-tdep.c: Sort headers.
8339         * aarch64-linux-tdep.c: Sort headers.
8340         * aarch64-linux-nat.c: Sort headers.
8341         * aarch64-fbsd-tdep.c: Sort headers.
8342         * aarch64-fbsd-nat.c: Sort headers.
8343         * aarch32-linux-nat.c: Sort headers.
8344
8345 2019-04-04  Tom Tromey  <tom@tromey.com>
8346
8347         * varobj.c (varobj_create): Update.
8348         * rust-exp.y (struct rust_parser) <update_innermost_block,
8349         lookup_symbol>: New methods.
8350         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8351         Rename.
8352         (rust_parser::rust_lookup_type)
8353         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8354         * printcmd.c (display_command, do_one_display): Update.
8355         * parser-defs.h (struct parser_state) <parser_state>: Add
8356         "tracker" parameter.
8357         (block_tracker): New member.
8358         (class innermost_block_tracker) <innermost_block_tracker>: Add
8359         "types" parameter.
8360         <reset>: Remove method.
8361         (innermost_block): Don't declare.
8362         (null_post_parser): Update.
8363         * parse.c (innermost_block): Remove global.
8364         (write_dollar_variable): Update.
8365         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8366         Remove "tracker_types" parameter.
8367         (parse_expression): Add "tracker" parameter.
8368         (parse_expression_for_completion): Update.
8369         (null_post_parser): Add "tracker" parameter.
8370         * p-exp.y: Update rules.
8371         * m2-exp.y: Update rules.
8372         * language.h (struct language_defn) <la_post_parser>: Add
8373         "tracker" parameter.
8374         * go-exp.y: Update rules.
8375         * f-exp.y: Update rules.
8376         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8377         parameter.
8378         * d-exp.y: Update rules.
8379         * c-exp.y: Update rules.
8380         * breakpoint.c (set_breakpoint_condition): Create an
8381         innermost_block_tracker.
8382         (watch_command_1): Likewise.
8383         * ada-lang.c (resolve): Add "tracker" parameter.
8384         (resolve_subexp): Likewise.
8385         * ada-exp.y (write_var_from_sym): Update.
8386
8387 2019-04-04  Tom Tromey  <tom@tromey.com>
8388
8389         * type-stack.h: New file.
8390         * type-stack.c: New file.
8391         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8392         type-stack.h.
8393         (insert_into_type_stack, insert_type, push_type, push_type_int)
8394         (insert_type_address_space, pop_type, pop_type_int)
8395         (pop_typelist, pop_type_stack, append_type_stack)
8396         (push_type_stack, get_type_stack, push_typelist)
8397         (follow_type_instance_flags, follow_types): Don't declare.
8398         * parse.c (type_stack): Remove global.
8399         (parse_exp_in_context): Update.
8400         (insert_into_type_stack, insert_type, push_type, push_type_int)
8401         (insert_type_address_space, pop_type, pop_type_int)
8402         (pop_typelist, pop_type_stack, append_type_stack)
8403         (push_type_stack, get_type_stack, push_typelist)
8404         (follow_type_instance_flags, follow_types): Remove (moved to
8405         type-stack.c).
8406         * f-exp.y (type_stack): New global.
8407         Update rules.
8408         (push_kind_type, f_parse): Update.
8409         * d-exp.y (type_stack): New global.
8410         Update rules.
8411         (d_parse): Update.
8412         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8413         Update rules.
8414         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8415         (HFILES_NO_SRCDIR): Add type-stack.h.
8416
8417 2019-04-04  Tom Tromey  <tom@tromey.com>
8418
8419         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8420         (rust_parser::convert_ast_to_expression, rust_parse)
8421         (rust_lex_test_completion, rust_lex_tests): Update.
8422         * parser-defs.h (struct expr_completion_state): New.
8423         (struct parser_state) <parser_state>: Add completion parameter.
8424         <mark_struct_expression, mark_completion_tag>: New methods.
8425         <parse_completion, m_completion_state>: New members.
8426         (prefixify_expression, null_post_parser): Update.
8427         (mark_struct_expression, mark_completion_tag): Don't declare.
8428         * parse.c (parse_completion, expout_last_struct)
8429         (expout_tag_completion_type, expout_completion_name): Remove
8430         globals.
8431         (parser_state::mark_struct_expression)
8432         (parser_state::mark_completion_tag): Now methods.
8433         (prefixify_expression): Add last_struct parameter.
8434         (prefixify_subexp): Likewise.
8435         (parse_exp_1): Update.
8436         (parse_exp_in_context): Add cstate parameter.  Update.
8437         (parse_expression_for_completion): Create an
8438         expr_completion_state.
8439         (null_post_parser): Add "completion" parameter.
8440         * p-exp.y: Update rules.
8441         (yylex): Update.
8442         * language.h (struct language_defn) <la_post_parser>: Add
8443         "completing" parameter.
8444         * go-exp.y: Update rules.
8445         (lex_one_token): Update.
8446         * expression.h (parse_completion): Don't declare.
8447         * d-exp.y: Update rules.
8448         (lex_one_token): Update rules.
8449         * c-exp.y: Update rules.
8450         (lex_one_token): Update.
8451         * ada-lang.c (resolve): Add "parse_completion" parameter.
8452         (resolve_subexp): Likewise.
8453         (ada_resolve_function): Likewise.
8454
8455 2019-04-04  Tom Tromey  <tom@tromey.com>
8456
8457         * parser-defs.h (struct parser_state) <start_arglist,
8458         end_arglist>: New methods.
8459         <arglist_len, m_funcall_chain>: New members.
8460         (arglist_len, start_arglist, end_arglist): Don't declare.
8461         * parse.c (arglist_len, funcall_chain): Remove global.
8462         (start_arglist, end_arglist): Remove functions.
8463         (parse_exp_in_context): Update.
8464         * p-exp.y: Update rules.
8465         * m2-exp.y: Update rules.
8466         * go-exp.y: Update rules.
8467         * f-exp.y: Update rules.
8468         * d-exp.y: Update rules.
8469         * c-exp.y: Update rules.
8470
8471 2019-04-04  Tom Tromey  <tom@tromey.com>
8472
8473         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8474         lex_operator, push_back>: New methods.
8475         Update all rules.
8476         (rust_parser::lex_hex, lex_escape): Rename and update.
8477         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8478         (rust_parser::lex_operator): Rename and update.
8479         (rust_parser::lex_number, rustyylex, rustyyerror)
8480         (rust_lex_test_init, rust_lex_test_sequence)
8481         (rust_lex_test_push_back, rust_lex_tests): Update.
8482         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8483         parameter.
8484         <lexptr, prev_lexptr>: New members.
8485         (lexptr, prev_lexptr): Don't declare.
8486         * parse.c (lexptr, prev_lexptr): Remove globals.
8487         (parse_exp_in_context): Update.
8488         * p-exp.y (yylex, yyerror): Update.
8489         * m2-exp.y (parse_number, yylex, yyerror): Update.
8490         * go-exp.y (lex_one_token, yyerror): Update.
8491         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8492         * d-exp.y (lex_one_token, yyerror): Update.
8493         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8494         (lex_one_token, yyerror): Update.
8495         * ada-lex.l (YY_INPUT): Update.
8496         (rewind_to_char): Update.
8497         * ada-exp.y (yyerror): Update.
8498
8499 2019-04-04  Tom Tromey  <tom@tromey.com>
8500
8501         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8502         * parser-defs.h (struct parser_state) <parser_state>: Add new
8503         parameter.
8504         <comma_terminates>: New member.
8505         (comma_terminates): Don't declare global.
8506         * parse.c (comma_terminates): Remove global.
8507         (parse_exp_in_context): Update.
8508         * p-exp.y (yylex): Update.
8509         * m2-exp.y (yylex): Update.
8510         * go-exp.y (lex_one_token): Update.
8511         * f-exp.y (yylex): Update.
8512         * d-exp.y (lex_one_token): Update.
8513         * c-exp.y (lex_one_token): Update.
8514         * ada-lex.l: Update.
8515
8516 2019-04-04  Tom Tromey  <tom@tromey.com>
8517
8518         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8519         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8520         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8521         * parser-defs.h (paren_depth): Don't declare.
8522         * parse.c (paren_depth): Remove global.
8523         (parse_exp_in_context): Update.
8524         * p-exp.y (paren_depth): New global.
8525         (pascal_parse): Initialize it.
8526         * m2-exp.y (paren_depth): New global.
8527         (m2_parse): Initialize it.
8528         * go-exp.y (paren_depth): New global.
8529         (go_parse): Initialize it.
8530         * f-exp.y (paren_depth): New global.
8531         (f_parse): Initialize it.
8532         * d-exp.y (paren_depth): New global.
8533         (d_parse): Initialize it.
8534         * c-exp.y (paren_depth): New global.
8535         (c_parse): Initialize it.
8536         * ada-lex.l (paren_depth): New global.
8537         (lexer_init): Initialize it.
8538
8539 2019-04-04  Tom Tromey  <tom@tromey.com>
8540
8541         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8542         (rust_parser::convert_ast_to_type)
8543         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8544         * parser-defs.h (struct parser_state) <parser_state>: Add
8545         parameters.  Initialize new members.
8546         <expression_context_block, expression_context_pc>: New members.
8547         * parse.c (expression_context_block, expression_context_pc):
8548         Remove globals.
8549         (parse_exp_in_context): Update.
8550         * p-exp.y: Update all rules.
8551         (yylex): Update.
8552         * m2-exp.y: Update all rules.
8553         (yylex): Update.
8554         * go-exp.y (yylex): Update.
8555         * f-exp.y (yylex): Update.
8556         * d-exp.y: Update all rules.
8557         (yylex): Update.
8558         * c-exp.y: Update all rules.
8559         (lex_one_token, classify_name, yylex, c_parse): Update.
8560         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8561
8562 2019-04-04  Tom Tromey  <tom@tromey.com>
8563
8564         * gdbarch.h, gdbarch.c: Rebuild.
8565         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8566         * stap-probe.h:
8567         (struct stap_parse_info): Replace "parser_state" with
8568         "expr_builder".
8569         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8570         (parser_state): New class.
8571         * parse.c (expr_builder): Rename.
8572         (expr_builder::release): Rename.
8573         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8574         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8575         (write_exp_elt_longcst, write_exp_elt_floatcst)
8576         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8577         (write_exp_string_vector, write_exp_bitstring)
8578         (write_exp_msymbol, mark_struct_expression)
8579         (write_dollar_variable)
8580         (insert_type_address_space, increase_expout_size): Replace
8581         "parser_state" with "expr_builder".
8582         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8583         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8584         "parser_state" with "expr_builder".
8585
8586 2019-04-04  Tom Tromey  <tom@tromey.com>
8587
8588         * rust-exp.y: Replace "parse_language" with method call.
8589         * p-exp.y:
8590         (yylex): Replace "parse_language" with method call.
8591         * m2-exp.y:
8592         (yylex): Replace "parse_language" with method call.
8593         * go-exp.y (classify_name): Replace "parse_language" with method
8594         call.
8595         * f-exp.y (yylex): Replace "parse_language" with method call.
8596         * d-exp.y (lex_one_token): Replace "parse_language" with method
8597         call.
8598         * c-exp.y:
8599         (lex_one_token, classify_name, yylex): Replace "parse_language"
8600         with method call.
8601         * ada-exp.y (find_primitive_type, type_char)
8602         (type_system_address): Replace "parse_language" with method call.
8603
8604 2019-04-04  Tom Tromey  <tom@tromey.com>
8605
8606         * rust-exp.y: Replace "parse_gdbarch" with method call.
8607         * parse.c (write_dollar_variable, insert_type_address_space):
8608         Replace "parse_gdbarch" with method call.
8609         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8610         call.
8611         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8612         call.
8613         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8614         "parse_gdbarch" with method call.
8615         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8616         with method call.
8617         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8618         "parse_gdbarch" with method call.
8619         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8620         "parse_gdbarch" with method call.
8621         * c-exp.y (parse_type, parse_number, classify_name): Replace
8622         "parse_gdbarch" with method call.
8623         * ada-lex.l: Replace "parse_gdbarch" with method call.
8624         * ada-exp.y (parse_type, find_primitive_type, type_char)
8625         (type_system_address): Replace "parse_gdbarch" with method call.
8626
8627 2019-04-04  Tom Tromey  <tom@tromey.com>
8628
8629         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8630         * stap-probe.c (stap_parse_argument): Update.
8631         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8632         initial_size parameter.
8633         * rust-exp.y (rust_lex_tests): Update.
8634         * parse.c (parser_state): Update.
8635         (parse_exp_in_context): Update.
8636         * parser-defs.h (struct parser_state) <parser_state>: Remove
8637         "initial_size" parameter.
8638
8639 2019-04-04  Tom Tromey  <tom@tromey.com>
8640
8641         * parser-defs.h (increase_expout_size): Don't declare.
8642         * parse.c (increase_expout_size): Now static.
8643
8644 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8645
8646         * gnu-nat.c (gnu_nat_target::wait): Fix
8647         target_waitstatus_to_string call.
8648
8649 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8650
8651         * eval.c (evaluate_subexp_standard): Handle internal functions
8652         during Fortran function call handling.
8653
8654 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8655
8656         * NEWS: Mention new internal functions.
8657         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8658         (read_base_type): Use dwarf2_init_complex_target_type.
8659         * value.c (creal_internal_fn): New function.
8660         (cimag_internal_fn): New function.
8661         (_initialize_values): Register new internal functions.
8662
8663 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8664
8665         * infrun.c (stop_all_threads): If debug_infrun, always
8666         trace the wait status after wait_one, using
8667         target_waitstatus_to_string and target_pid_to_str.
8668         (handle_inferior_event): Replace various trace of
8669         wait status kind by a single trace.
8670         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8671         wait status kind image by target_waitstatus_to_string.
8672         * target/waitstatus.c (target_waitstatus_to_string): Fix
8673         obsolete comment.
8674
8675 2019-04-01  Tom Tromey  <tromey@adacore.com>
8676
8677         PR symtab/23331:
8678         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8679
8680 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8681             Pedro Alves  <palves@redhat.com>
8682
8683         * top.c (quit_force): Call 'finalize_values'.
8684         * value.c (finalize_values): New function.
8685         * value.h (finalize_values): Declare.
8686
8687 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8688
8689         * NEWS: Announce $_gdb_major and $_gdb_minor.
8690
8691         * top.c (init_gdb_version_vars): New function.
8692         (gdb_init): Call init_gdb_version_vars.
8693
8694 2019-03-29  Tom Tromey  <tromey@adacore.com>
8695
8696         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8697         help text.  Remove dead code.
8698
8699 2019-03-29  Keith Seitz  <keiths@redhat.com>
8700
8701         From Siddhesh Poyarekar:
8702         * f-lang.h (f77_get_upperbound): Return LONGEST.
8703         (f77_get_lowerbound): Likewise.
8704         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8705         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8706         print them.
8707         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8708         plongest to format print it.
8709         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8710         (f77_get_upperbound): Likewise.
8711         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8712         LOWER_BOUND to LONGEST.
8713         (f77_create_arrayprint_offset_tbl): Likewise.
8714
8715 2019-03-29  Keith Seitz  <keiths@redhat.com>
8716
8717         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8718         %s/pulongest for TYPE_LENGTH instead of %d in format
8719         strings.
8720         * ada-typerint.c (ada_print_type): Likewise.
8721         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8722         * compile/compile-c-support.c (generate_register_struct): Likewise.
8723         * gdbtypes.c (recursive_dump_type): Likewise.
8724         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8725         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8726         instead of %d in format strings.
8727         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8728         to std::min to ULONGEST.
8729         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8730         instead of %d in format strings.
8731         * tracepoint.c (info_scope_command): Likewise.
8732         * typeprint.c (print_offset_data::update)
8733         (print_offset_data::finish): Likewise.
8734         * xtensa-tdep.c (xtensa_store_return_value)
8735         (xtensa_push_dummy_call): Likewise.
8736
8737 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8738
8739         * windows-nat.c (display_selector): Fixed format specifications
8740         for 64-bit Cygwin.
8741
8742 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8743
8744         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8745
8746 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8747
8748         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8749         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8750         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8751         (nios2_linux_init_abi): Install it.
8752
8753 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8754
8755         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8756
8757 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8758
8759         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8760
8761 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8762             Tom Tromey  <tromey@adacore.com>
8763
8764         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8765
8766 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8767
8768         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8769         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8770         method to compute the bounds of range types. Also print "[evaluated]"
8771         if the bounds' values come from a dynamic evaluation.
8772
8773 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8774
8775         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8776         whitespace when pretty printing is on.
8777
8778 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8779
8780         * ppc-linux-nat.c: Add include.
8781
8782 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8783
8784         * NEWS: Mention AArch64 Pointer Authentication.
8785
8786 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8787
8788         * arm-linux-nat.c: Add include.
8789
8790 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8791
8792         * source-cache.c (source_cache::get_source_lines): Re-read
8793         fullname after calling open_source_file.
8794
8795 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8796
8797         * NEWS: Mention TLS support for FreeBSD.
8798
8799 2019-03-25  Tom Tromey  <tromey@adacore.com>
8800
8801         * minsyms.c (BUNCH_SIZE): Update comment.
8802         (~minimal_symbol_reader): Remove old comment.
8803         (compact_minimal_symbols): Update comment.
8804         (minimal_symbol_reader::install): Remove old comment.  Update
8805         other comments.
8806
8807 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8808
8809         * s390-linux-nat.c: Add include.
8810
8811 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8812
8813         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8814         Call linux_get_hwcap.
8815         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8816         Likewise.
8817         (aarch64_linux_get_hwcap): Remove function.
8818         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8819         declaration.
8820         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8821         linux_get_hwcap.
8822         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8823         * linux-tdep.c (linux_get_hwcap): Add function.
8824         (linux_get_hwcap2): Likewise.
8825         * linux-tdep.h (linux_get_hwcap): Add declaration.
8826         (linux_get_hwcap2): Likewise.
8827         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8828         (ppc_linux_get_hwcap2): Likewise.
8829         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8830         linux_get_hwcap.
8831         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8832         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8833         (ppc_linux_nat_target::read_description): Likewise.
8834         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8835         * s390-linux-nat.c: Likewise.
8836         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8837
8838 2019-03-24  Tom Tromey  <tom@tromey.com>
8839
8840         * ada-lang.c (standard_lookup): Simplify initialization.
8841         (ada_lookup_symbol_nonlocal): Simplify return.
8842         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8843         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8844         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8845         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8846         initialization.
8847         * solib.c (solib_global_lookup): Simplify.
8848         * symtab.c (null_block_symbol): Remove.
8849         (symbol_cache_lookup): Simplify returns.
8850         (lookup_language_this): Simplify returns.
8851         (lookup_symbol_aux): Simplify return.
8852         (lookup_local_symbol): Simplify returns.
8853         (lookup_global_symbol_from_objfile): Simplify return.
8854         (lookup_symbol_in_objfile_symtabs)
8855         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8856         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8857         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8858         * cp-namespace.c (cp_lookup_bare_symbol)
8859         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8860         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8861         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8862         (cp_lookup_symbol_via_imports): Simplify initialization.
8863         (find_symbol_in_baseclass): Likewise.
8864         * symtab.h (null_block_symbol): Remove.
8865         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8866         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8867         (d_lookup_symbol_module): Likewise.
8868         (find_symbol_in_baseclass): Simplify initialization.
8869
8870 2019-03-24  Tom Tromey  <tom@tromey.com>
8871
8872         * expression.h: Don't include symtab.h.
8873         (struct block): Forward declare.
8874
8875 2019-03-24  Tom Tromey  <tom@tromey.com>
8876
8877         * c-exp.y (typebase): Remove casts.
8878         * gdbtypes.c (lookup_unsigned_typename, )
8879         (lookup_signed_typename): Remove cast.
8880         * eval.c (parse_to_comma_and_eval): Remove cast.
8881         * parse.c (write_dollar_variable): Remove cast.
8882         * block.h (struct block) <superblock>: Now const.
8883         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8884         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8885         (map_block): Make "block" const.
8886         * symfile.h (struct quick_symbol_functions)
8887         <map_matching_symbols>: Constify block argument to "callback".
8888         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8889         const.
8890         (find_pc_sect_compunit_symtab): Make "b" const.
8891         (find_symbol_at_address): Likewise.
8892         (search_symbols): Likewise.
8893         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8894         (dw2_debug_names_lookup_symbol): Likewise.
8895         (dw2_map_matching_symbols): Update.
8896         * p-valprint.c (pascal_val_print): Remove "block".
8897         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8898         (aux_add_nonlocal_symbols): Make "block" const.
8899         (resolve_subexp): Remove cast.
8900         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8901         const.
8902         (iterate_over_file_blocks): Likewise.
8903         * f-exp.y (%union) <bval>: Remove.
8904         * coffread.c (patch_opaque_types): Make "b" const.
8905         * spu-tdep.c (spu_catch_start): Make "block" const.
8906         * c-valprint.c (print_unpacked_pointer): Remove "block".
8907         * symmisc.c (dump_symtab_1): Make "b" const.
8908         (block_depth): Make "block" const.
8909         * d-exp.y (%union) <bval>: Remove.
8910         * cp-support.h (cp_lookup_rtti_type): Update.
8911         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8912         * psymtab.c (psym_lookup_symbol): Make "block" const.
8913         (maintenance_check_psymtabs): Make "b" const.
8914         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8915         (enumerate_locals, enumerate_args): Update.
8916         * python/py-symtab.c (stpy_global_block): Make "block" const.
8917         (stpy_static_block): Likewise.
8918         * inline-frame.c (block_starting_point_at): Make "new_block"
8919         const.
8920         * block.c (find_block_in_blockvector): Make return type const.
8921         (blockvector_for_pc_sect): Make "b" const.
8922         (find_block_in_blockvector): Make "b" const.
8923
8924 2019-03-23  Tom Tromey  <tom@tromey.com>
8925
8926         * varobj.c (varobj_create): Update.
8927         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8928         * printcmd.c (display_command, do_one_display): Don't reset
8929         innermost_block.
8930         * parser-defs.h (enum innermost_block_tracker_type): Move to
8931         expression.h.
8932         (innermost_block): Update comment.
8933         * parse.c (parse_exp_1): Add tracker_types parameter.
8934         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8935         tracker_types parameter.  Reset innermost_block.
8936         (parse_exp_in_context): Remove.
8937         (parse_expression_for_completion): Update.
8938         * objfiles.c (~objfile): Don't reset expression_context_block or
8939         innermost_block.
8940         * expression.h (enum innermost_block_tracker_type): Move from
8941         parser-defs.h.
8942         (parse_exp_1): Add tracker_types parameter.
8943         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8944         reset innermost_block.
8945
8946 2019-03-23  Tom Tromey  <tom@tromey.com>
8947
8948         * objfiles.h: Include bcache.h.
8949
8950 2019-03-23  Tom Tromey  <tom@tromey.com>
8951
8952         * linespec.c (get_current_search_block): Use
8953         scoped_restore_current_language.
8954         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8955
8956 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8957             Jiong Wang  <jiong.wang@arm.com>
8958
8959         * aarch64-linux-tdep.c
8960         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8961         section.
8962         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8963
8964 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8965             Jiong Wang  <jiong.wang@arm.com>
8966
8967         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8968         instructions.
8969         (aarch64_analyze_prologue_test): Add PACIASP test.
8970         (aarch64_prologue_prev_register): Unmask PC value.
8971
8972 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8973             Jiong Wang  <jiong.wang@arm.com>
8974
8975         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8976         (aarch64_dwarf2_prev_register): Unmask PC value.
8977         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8978         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8979         DW_CFA_AARCH64_negate_ra_state.
8980         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8981
8982 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8983             Jiong Wang  <jiong.wang@arm.com>
8984
8985         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8986         registers.
8987         (aarch64_pseudo_register_name): Likewise.
8988         (aarch64_pseudo_register_type): Likewise.
8989         (aarch64_pseudo_register_reggroup_p): Likewise.
8990         (aarch64_gdbarch_init): Add pauth registers.
8991         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8992         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8993         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8994         (struct gdbarch_tdep): Add regnum for ra_state.
8995
8996 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8997             Jiong Wang  <jiong.wang@arm.com>
8998
8999         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9000
9001 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9002             Jiong Wang  <jiong.wang@arm.com>
9003
9004         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9005         function.
9006         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9007         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9008         (aarch64_gdbarch_init): Add puth registers.
9009         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9010         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9011         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9012
9013 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9014             Jiong Wang  <jiong.wang@arm.com>
9015
9016         * aarch64-linux-nat.c
9017         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9018         * aarch64-linux-tdep.c
9019         (aarch64_linux_core_read_description): Likewise.
9020         (aarch64_linux_get_hwcap): New function.
9021         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9022         (aarch64_linux_get_hwcap): New declaration.
9023
9024 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9025             Jiong Wang  <jiong.wang@arm.com>
9026
9027         * aarch64-linux-nat.c
9028         (aarch64_linux_nat_target::read_description): Add pauth param.
9029         * aarch64-linux-tdep.c
9030         (aarch64_linux_core_read_description): Likewise.
9031         * aarch64-tdep.c (struct target_desc): Add in pauth.
9032         (aarch64_read_description): Add pauth param.
9033         (aarch64_gdbarch_init): Likewise.
9034         * aarch64-tdep.h (aarch64_read_description): Likewise.
9035         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9036         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9037         * features/Makefile: Add new files.
9038         * features/aarch64-pauth.c: New file.
9039         * features/aarch64-pauth.xml: New file.
9040
9041 2019-03-20  Tom Tromey  <tromey@adacore.com>
9042
9043         * infrun.c (handle_inferior_event): Rename from
9044         handle_inferior_event_1.  Create a scoped_value_mark.
9045         (handle_inferior_event): Remove.
9046
9047 2019-03-19  Tom Tromey  <tromey@adacore.com>
9048
9049         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9050         * infrun.h (print_stop_event): Add "displays" parameter.
9051         * infrun.c (print_stop_event): Add "displays" parameter.
9052
9053 2019-03-19  Pedro Alves  <palves@redhat.com>
9054
9055         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9056         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9057         to -1.  Fix TABs vs spaces.
9058         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9059         * tui/tui-out.h (tui_ui_out) Add intro comments.
9060         <m_line, m_start_of_line>: In-class initialize, and add describing
9061         comment.
9062
9063 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9064
9065         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9066         variable names.
9067         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9068
9069 2019-03-18  Pedro Alves  <palves@redhat.com>
9070             Eli Zaretskii <eliz@gnu.org>
9071
9072         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9073         m_line and m_start_of_line.
9074
9075 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9076
9077         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9078         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9079         it returns a newline.  This fixes a regression in TU mode, whereby
9080         the next line is output on the same screen line as the user input.
9081
9082 2019-03-18  Tom Tromey  <tromey@adacore.com>
9083
9084         * minsyms.c (minimal_symbol_reader::install): Remove call to
9085         obstack_blank.
9086
9087 2019-03-18  Pedro Alves  <palves@redhat.com>
9088
9089         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9090         New globals.
9091         (apply_style): New, factored out from ...
9092         (apply_ansi_escape): ... this.  Handle reverse video mode.
9093         (tui_set_reverse_mode): New function.
9094         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9095         * tui/tui-winsource.c (tui_show_source_line): Use
9096         tui_set_reverse_mode instead of setting A_STANDOUT.
9097         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9098         New setter methods.
9099
9100 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9101
9102         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9103         Handle tabs.
9104
9105 2019-03-18  Tom Tromey  <tromey@adacore.com>
9106
9107         * ada-lang.c (empty_array): Add "high" parameter.
9108         (ada_evaluate_subexp): Update.
9109
9110 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9111
9112         * unittests/string_view-selftests.c: Define
9113         _initialize_string_view_selftests unconditionally.
9114
9115 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9116
9117         PR gdb/24350
9118         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9119
9120 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9121
9122         PR gdb/24351
9123         * windows-nat.c (display_selector): Fix format specifiers.
9124
9125 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9126
9127         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9128         tui_refill_source_window instead of tui_refresh_win, to update the
9129         current execution line.  This fixes redisplay of the current line
9130         when stepping through the code with "next" or "step".
9131
9132 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9133
9134         * source-cache.c (source_cache::get_source_lines): Call
9135         find_source_lines to initialize s->nlines.  This fixes vertical
9136         scrolling of TUI source window when the DOWN arrow is pressed.
9137
9138 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9139
9140         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9141         linux-thread-db.c (_initialize_thread_db): Likewise.
9142
9143 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9144
9145         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9146         wclrtoeol in tui_show_source_line".  This reverts changes made in
9147         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9148
9149 2019-03-15  Tom Tromey  <tom@tromey.com>
9150
9151         * symtab.h (struct minimal_symbol): Derive from
9152         general_symbol_info.
9153         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9154         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9155         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9156         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9157         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9158         (MSYMBOL_SEARCH_NAME): Update.
9159         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9160         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9161         * minsyms.c (minimal_symbol_reader::record_full): Update.
9162
9163 2019-03-15  Tom Tromey  <tom@tromey.com>
9164
9165         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9166
9167 2019-03-15  Tom Tromey  <tom@tromey.com>
9168
9169         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9170         unique_xmalloc_ptr.
9171         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9172         Update.
9173         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9174         (build_minimal_symbol_hash_tables)
9175         (minimal_symbol_reader::install): Update.
9176
9177 2019-03-15  Tom Tromey  <tom@tromey.com>
9178
9179         * symtab.c (create_demangled_names_hash): Update.
9180         (symbol_set_names): Update.
9181         * objfiles.h (struct objfile_per_bfd_storage)
9182         <demangled_names_hash>: Now an htab_up.
9183         * objfiles.c (objfile_per_bfd_storage): Simplify.
9184
9185 2019-03-15  Tom Tromey  <tom@tromey.com>
9186
9187         * objfiles.h (struct objfile_per_bfd_storage): Declare
9188         destructor.
9189         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9190         New.
9191         (get_objfile_bfd_data): Use new.  Don't initialize
9192         language_of_main.
9193         (free_objfile_per_bfd_storage): Remove.
9194         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9195
9196 2019-03-15  Tom Tromey  <tom@tromey.com>
9197
9198         * symfile.c (reread_symbols): Update.
9199         * objfiles.c (objfile::objfile): Update.
9200         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9201         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9202         comment.
9203         (minimal_symbol_reader::install): Update.
9204         (terminate_minimal_symbol_table): Remove.
9205         * jit.c (jit_object_close_impl): Update.
9206
9207 2019-03-15  Tom Tromey  <tom@tromey.com>
9208
9209         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9210         initializations.
9211
9212 2019-03-15  Tom Tromey  <tom@tromey.com>
9213
9214         * objfiles.h (struct objfile_per_bfd_storage)
9215         <demangled_hash_languages>: Now a bitset.
9216         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9217         (lookup_minimal_symbol): Update.
9218
9219 2019-03-15  Tom Tromey  <tom@tromey.com>
9220
9221         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9222         Don't return the symbol.
9223         * coffread.c (record_minimal_symbol): Use record_full.
9224
9225 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9226
9227         The MS-Windows port of ncurses fails to switch to a color pair if
9228         one or both of the colors are the implicit default colors.  This
9229         change records the default colors when TUI is initialized, and
9230         then specifies them explicitly when a color pair uses the default
9231         colors.  This allows color styling in TUI mode on MS-Windows.
9232
9233         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9234         ncurses_norm_attr.
9235         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9236         colors in ncurses_norm_attr.
9237         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9238         "none", replace it with the default color recorded in
9239         ncurses_norm_attr.
9240
9241 2019-03-14  Tom Tromey  <tromey@adacore.com>
9242
9243         * source-cache.h (class source_cache) <get_source_lines>: Return
9244         std::string.
9245         * source-cache.c (source_cache::extract_lines): Handle case where
9246         first_pos==npos.  Return std::string.
9247         (source_cache::get_source_lines): Update.
9248
9249 2019-03-14  Tom Tromey  <tromey@adacore.com>
9250
9251         * NEWS: Add item for "style sources" commands.
9252         * source-cache.c (source_cache::get_source_lines): Check
9253         source_styling.
9254         * cli/cli-style.c (source_styling): New global.
9255         (_initialize_cli_style): Add "style sources" commands.
9256         (show_style_sources): New function.
9257         * cli/cli-style.h (source_styling): Declare.
9258
9259 2019-03-14  Pedro Alves  <palves@redhat.com>
9260             Tom Tromey  <tromey@adacore.com>
9261
9262         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9263         * tui/tui-winsource.c (tui_refill_source_window): New function,
9264         from...
9265         (tui_horizontal_source_scroll): ... here.  Move some logic.
9266         * cli/cli-style.c (set_style_enabled): Notify new observable.
9267         * tui/tui-hooks.c (tui_redisplay_source): New function.
9268         (tui_attach_detach_observers): Attach or detach
9269         tui_redisplay_source.
9270         * observable.h (source_styling_changed): New observable.
9271         * observable.c: Define source_styling_changed observable.
9272
9273 2019-03-13  Tom Tromey  <tromey@adacore.com>
9274
9275         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9276         (i386_gnu_nat_target::store_registers): Update.
9277         * target-debug.h (target_debug_print_std_string): New macro.
9278         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9279         * windows-tdep.c (display_one_tib): Update.
9280         * tui/tui-stack.c (tui_make_status_line): Update.
9281         * top.c (print_inferior_quit_action): Update.
9282         * thread.c (thr_try_catch_cmd): Update.
9283         (add_thread_with_info): Update.
9284         (thread_target_id_str): Update.
9285         (thr_try_catch_cmd): Update.
9286         (thread_command): Update.
9287         (thread_find_command): Update.
9288         * record-btrace.c (record_btrace_target::info_record)
9289         (record_btrace_resume_thread, record_btrace_target::resume)
9290         (record_btrace_cancel_resume, record_btrace_step_thread)
9291         (record_btrace_target::wait, record_btrace_target::wait)
9292         (record_btrace_target::wait, record_btrace_target::stop): Update.
9293         * progspace.c (print_program_space): Update.
9294         * process-stratum-target.c
9295         (process_stratum_target::thread_address_space): Update.
9296         * linux-fork.c (linux_fork_mourn_inferior)
9297         (detach_checkpoint_command, info_checkpoints_command)
9298         (linux_fork_context): Update.
9299         (linux_fork_detach): Update.
9300         (class scoped_switch_fork_info): Update.
9301         (delete_checkpoint_command): Update.
9302         * infrun.c (follow_fork_inferior): Update.
9303         (follow_fork_inferior): Update.
9304         (proceed_after_vfork_done): Update.
9305         (handle_vfork_child_exec_or_exit): Update.
9306         (follow_exec): Update.
9307         (displaced_step_prepare_throw): Update.
9308         (displaced_step_restore): Update.
9309         (start_step_over): Update.
9310         (resume_1): Update.
9311         (clear_proceed_status_thread): Update.
9312         (proceed): Update.
9313         (print_target_wait_results): Update.
9314         (do_target_wait): Update.
9315         (context_switch): Update.
9316         (stop_all_threads): Update.
9317         (restart_threads): Update.
9318         (finish_step_over): Update.
9319         (handle_signal_stop): Update.
9320         (switch_back_to_stepped_thread): Update.
9321         (keep_going_pass_signal): Update.
9322         (print_exited_reason): Update.
9323         (normal_stop): Update.
9324         * inferior.c (inferior_pid_to_str): Change return type.
9325         (print_selected_inferior): Update.
9326         (add_inferior): Update.
9327         (detach_inferior): Update.
9328         * dummy-frame.c (fprint_dummy_frames): Update.
9329         * dcache.c (dcache_info_1): Update.
9330         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9331         (btrace_fetch, btrace_clear): Update.
9332         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9333         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9334         type.
9335         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9336         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9337         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9338         * gdbarch.c, gdbarch.h: Rebuild.
9339         * gdbarch.sh (core_pid_to_str): Change return type.
9340         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9341         return type.
9342         (windows_nat_target::pid_to_str): Change return type.
9343         (windows_delete_thread): Update.
9344         (windows_nat_target::attach): Update.
9345         (windows_nat_target::files_info): Update.
9346         * target-delegates.c: Rebuild.
9347         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9348         return type.
9349         (sol_thread_target::pid_to_str): Change return type.
9350         * remote.c (class remote_target) <pid_to_str>: Change return
9351         type.
9352         (remote_target::pid_to_str): Change return type.
9353         (extended_remote_target::attach, remote_target::remote_stop_ns)
9354         (remote_target::remote_notif_remove_queued_reply)
9355         (remote_target::push_stop_reply, remote_target::disable_btrace):
9356         Update.
9357         (extended_remote_target::attach): Update.
9358         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9359         type.
9360         (gdbsim_target::pid_to_str): Change return type.
9361         * ravenscar-thread.c (struct ravenscar_thread_target)
9362         <pid_to_str>: Change return type.
9363         (ravenscar_thread_target::pid_to_str): Change return type.
9364         * procfs.c (class procfs_target) <pid_to_str>: Change return
9365         type.
9366         (procfs_target::pid_to_str): Change return type.
9367         (procfs_target::attach): Update.
9368         (procfs_target::detach): Update.
9369         (procfs_target::fetch_registers): Update.
9370         (procfs_target::store_registers): Update.
9371         (procfs_target::wait): Update.
9372         (procfs_target::files_info): Update.
9373         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9374         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9375         return type.
9376         (nto_procfs_target::pid_to_str): Change return type.
9377         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9378         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9379         return type.
9380         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9381         (exit_lwp): Update.
9382         (attach_proc_task_lwp_callback, get_detach_signal)
9383         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9384         (linux_nat_target::resume, wait_lwp, stop_callback)
9385         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9386         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9387         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9388         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9389         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9390         type.
9391         (inf_ptrace_target::attach): Update.
9392         (inf_ptrace_target::files_info): Update.
9393         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9394         type.
9395         (go32_nat_target::pid_to_str): Change return type.
9396         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9397         (gnu_nat_target::wait): Update.
9398         (gnu_nat_target::wait): Update.
9399         (gnu_nat_target::resume): Update.
9400         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9401         (fbsd_nat_target::wait): Update.
9402         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9403         type.
9404         (darwin_nat_target::attach): Update.
9405         * corelow.c (class core_target) <pid_to_str>: Change return type.
9406         (core_target::pid_to_str): Change return type.
9407         * target.c (normal_pid_to_str): Change return type.
9408         (default_pid_to_str): Likewise.
9409         (target_pid_to_str): Change return type.
9410         (target_translate_tls_address): Update.
9411         (target_announce_detach): Update.
9412         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9413         return type.
9414         (bsd_uthread_target::pid_to_str): Change return type.
9415         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9416         type.
9417         (bsd_kvm_target::pid_to_str): Change return type.
9418         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9419         return type.
9420         (aix_thread_target::pid_to_str): Change return type.
9421         * target.h (struct target_ops) <pid_to_str>: Change return type.
9422         (target_pid_to_str, normal_pid_to_str): Likewise.
9423         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9424         type.
9425         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9426         type.
9427         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9428         return type.
9429         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9430         type.
9431         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9432         type.
9433         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9434         return type.
9435
9436 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9437
9438         * NEWS: Mention that the new default MI version is 3.  Mention
9439         changes to the output of commands and events that deal with
9440         multi-location breakpoints.
9441         * breakpoint.c: Include "mi/mi-out.h".
9442         (print_one_breakpoint): Change output syntax if using MI version
9443         >= 3.
9444         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9445         New.
9446         (mi_multi_location_breakpoint_output_fixed): New.
9447         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9448         (mi_cmd_fix_multi_location_breakpoint_output): New.
9449         (mi_multi_location_breakpoint_output_fixed): New.
9450         * mi/mi-cmds.c (mi_cmds): Register command
9451         -fix-multi-location-breakpoint-output.
9452         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9453         interpreter "mi".
9454
9455 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9456
9457         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9458         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9459         instantiate mi_ui_out based on interpreter name.
9460         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9461         * mi/mi-main.c (mi_load_progress): Likewise.
9462
9463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9464
9465         * NEWS: Combine separate "New targets" sections for 8.3.
9466
9467 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9468
9469         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9470         (ppcfbsd_init_abi): Install gdbarch
9471         "fetch_tls_load_module_address" and "get_thread_local_address"
9472         methods.
9473
9474 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9475
9476         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9477         (riscv_fbsd_init_abi): Install gdbarch
9478         "fetch_tls_load_module_address" and "get_thread_local_address"
9479         methods.
9480
9481 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9482
9483         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9484         (i386fbsd_init_abi): Install gdbarch
9485         "fetch_tls_load_module_address" and "get_thread_local_address"
9486         methods.
9487
9488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9489
9490         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9491         (amd64fbsd_init_abi): Install gdbarch
9492         "fetch_tls_load_module_address" and "get_thread_local_address"
9493         methods.
9494
9495 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9496
9497         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9498         (struct fbsd_pspace_data): New type.
9499         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9500         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9501         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9502         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9503         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9504
9505 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9506
9507         * gdbtypes.c (lookup_struct_elt): New function.
9508         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9509         * gdbtypes.h (struct struct_elt): New type.
9510         (lookup_struct_elt): New prototype.
9511
9512 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9513
9514         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9515         remove disabled code block.
9516
9517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9518
9519         * gdbarch.sh (get_thread_local_address): New method.
9520         * gdbarch.h, gdbarch.c: Regenerate.
9521         * target.c (target_translate_tls_address): Use
9522         gdbarch_get_thread_local_address if present instead of
9523         target::get_thread_local_address.
9524
9525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9526
9527         * target.h (target::get_thread_local_address): Update comment.
9528
9529 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9530
9531         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9532         objfile->separate_debug_objfile_backlink if not NULL.
9533
9534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9535
9536         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9537         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9538         (amd64bsd_store_inferior_registers): Likewise.
9539         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9540         Enable segment base registers.
9541         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9542         PT_GETFSBASE and PT_GETGSBASE.
9543         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9544         PT_SETGSBASE.
9545         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9546         segment base registers.
9547         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9548
9549 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9550
9551         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9552         Update calls to i386_target_description to add 'segments'
9553         parameter.
9554         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9555         add segment base registers.
9556         * arch/i386.c (i386_create_target_description): Add 'segments'
9557         parameter to enable segment base registers.
9558         * arch/i386.h (i386_create_target_description): Likewise.
9559         * features/i386/32bit-segments.xml: New file.
9560         * features/i386/32bit-segments.c: Generate.
9561         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9562         call to i386_target_description to add 'segments' parameter.
9563         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9564         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9565         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9566         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9567         if feature is present.
9568         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9569         Add 'segments' parameter to call to i386_target_description.
9570         (i386_target_description): Add 'segments' parameter to enable
9571         segment base registers.
9572         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9573         to call to i386_target_description.
9574         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9575         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9576         Define I386_NUM_REGS.
9577         (i386_target_description): Add 'segments' parameter to enable
9578         segment base registers.
9579
9580 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9581
9582         PR/24325
9583         * source-cache.c: #undef open and close, to avoid unresolved
9584         externals during linking.
9585
9586 2019-03-12  Tom Tromey  <tromey@adacore.com>
9587
9588         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9589         const.  Add initializers.
9590         (_initialize_remote): Don't initialize ptid globals.
9591
9592 2019-03-12  Pedro Alves  <palves@redhat.com>
9593
9594         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9595
9596 2019-03-12  Pedro Alves  <palves@redhat.com>
9597
9598         * cp-name-parser.y (main): Remove unused 'len' variable.
9599
9600 2019-03-12  Tom Tromey  <tromey@adacore.com>
9601
9602         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9603         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9604
9605 2019-03-12  Tom Tromey  <tromey@adacore.com>
9606
9607         * linux-nat.c (iterate_over_lwps): Update.
9608         (stop_callback): Remove parameter.
9609         (stop_wait_callback, detach_callback, resume_set_callback)
9610         (select_singlestep_lwp_callback, set_ignore_sigint)
9611         (status_callback, resumed_callback, resume_clear_callback)
9612         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9613         data parameter.
9614         (linux_nat_target::detach, linux_nat_target::resume)
9615         (linux_stop_and_wait_all_lwps, select_event_lwp)
9616         (linux_nat_filter_event, linux_nat_wait_1)
9617         (linux_nat_target::kill, linux_nat_target::stop)
9618         (linux_nat_target::stop): Update.
9619         (linux_nat_resume_callback): Change type.
9620         (resume_stopped_resumed_lwps, count_events_callback)
9621         (select_event_lwp_callback): Likewise.
9622         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9623         * arm-linux-nat.c (struct update_registers_data): Remove.
9624         (update_registers_callback): Change type.
9625         (arm_linux_insert_hw_breakpoint1): Update.
9626         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9627         parameter.
9628         (x86_linux_dr_set_addr): Update.
9629         (x86_linux_dr_set_control): Update.
9630         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9631         (iterate_over_lwps): Use gdb::function_view.
9632         * nat/aarch64-linux-hw-point.c (struct
9633         aarch64_dr_update_callback_param): Remove.
9634         (debug_reg_change_callback): Change type.
9635         (aarch64_notify_debug_reg_change): Update.
9636         * s390-linux-nat.c (s390_refresh_per_info): Update.
9637
9638 2019-03-11  Tom Tromey  <tromey@adacore.com>
9639
9640         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9641         redundant assignment to "this_cu".
9642
9643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9644
9645         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9646
9647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9648
9649         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9650         from...
9651         (rank_one_type): ... this.
9652
9653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9654
9655         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9656         from...
9657         (rank_one_type): ... this.
9658
9659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9660
9661         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9662         from...
9663         (rank_one_type): ... this.
9664
9665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9666
9667         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9668         from...
9669         (rank_one_type): ... this.
9670
9671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9672
9673         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9674         from...
9675         (rank_one_type): ... this.
9676
9677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9678
9679         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9680         from...
9681         (rank_one_type): ... this.
9682
9683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9684
9685         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9686         from...
9687         (rank_one_type): ... this.
9688
9689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9690
9691         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9692         from...
9693         (rank_one_type): ... this.
9694
9695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9696
9697         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9698         from...
9699         (rank_one_type): ... this.
9700
9701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9702
9703         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9704         from...
9705         (rank_one_type): ... this.
9706
9707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9708
9709         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9710         from...
9711         (rank_one_type): ... this.
9712
9713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9714
9715         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9716         from...
9717         (rank_one_type): ... this.
9718
9719 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9720
9721         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9722         inferior-events' shows the example events.
9723
9724 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9725
9726         Support styling on native MS-Windows console
9727
9728         PR/24315
9729         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9730         on MS-Windows if $TERM is not defined.
9731
9732         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9733
9734         * posix-hdep.c (gdb_console_fputs):
9735         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9736         functions.
9737         * ui-file.h (gdb_console_fputs): Add prototype.
9738
9739         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9740         back to fputs only if the former returns zero.
9741
9742 2019-03-07  Tom Tromey  <tom@tromey.com>
9743
9744         * symmisc.c (print_symbol_bcache_statistics): Update.
9745         (print_objfile_statistics): Update.
9746         * symfile.c (allocate_symtab): Update.
9747         * stabsread.c: Don't include bcache.h.
9748         * psymtab.h (struct psymbol_bcache): Don't declare.
9749         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9750         (psymbol_bcache_init, psymbol_bcache_free)
9751         (psymbol_bcache_get_bcache): Don't declare.
9752         * psymtab.c (struct psymbol_bcache): Remove.
9753         (psymtab_storage::psymtab_storage): Update.
9754         (psymtab_storage::~psymtab_storage): Update.
9755         (psymbol_bcache_init, psymbol_bcache_free)
9756         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9757         (add_psymbol_to_bcache): Update.
9758         (allocate_psymtab): Update.
9759         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9760         macro_cache>: No longer pointers.
9761         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9762         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9763         * macrotab.c (macro_bcache): Update.
9764         * macroexp.c: Don't include bcache.h.
9765         * gdbtypes.c (check_types_worklist): Update.
9766         (types_deeply_equal): Remove TRY/CATCH.  Update.
9767         * elfread.c (elf_symtab_read): Update.
9768         * dwarf2read.c: Don't include bcache.h.
9769         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9770         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9771         (print_bcache_statistics, bcache_memory_used): Don't declare.
9772         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9773         methods.  Rename all data members.
9774         * bcache.c (struct bcache): Move to bcache.h.
9775         (bcache::expand_hash_table): Rename from expand_hash_table.
9776         (bcache): Remove.
9777         (bcache::insert): Rename from bcache_full.
9778         (bcache::compare): Rename from bcache_compare.
9779         (bcache_xmalloc): Remove.
9780         (bcache::~bcache): Rename from bcache_xfree.
9781         (bcache::print_statistics): Rename from print_bcache_statistics.
9782         (bcache::memory_used): Rename from bcache_memory_used.
9783
9784 2019-03-07  Pedro Alves  <palves@redhat.com>
9785
9786         * infrun.c (normal_stop): Also check for
9787         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9788
9789 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9790
9791         * f-lang.c (value_from_host_double): Moved to...
9792         * value.c (value_from_host_double): ...here.
9793         * value.h (value_from_host_double): Declare.
9794         * guile/scm-math.c (vlscm_convert_typed_number): Use
9795         value_from_host_double.
9796         (vlscm_convert_number): Likewise.
9797         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9798         * python/py-value.c (convert_value_from_python): Likewise.
9799
9800 2019-03-06  Tom Tromey  <tom@tromey.com>
9801
9802         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9803
9804 2019-03-06  Tom Tromey  <tom@tromey.com>
9805
9806         * utils.h (free_current_contents): Don't declare.
9807         * utils.c (free_current_contents): Remove.
9808
9809 2019-03-06  Tom Tromey  <tom@tromey.com>
9810
9811         * top.c (quit_force): Update.
9812         * main.c (captured_command_loop): Update.
9813         * common/new-op.c (operator new): Update.
9814         * common/common-exceptions.c (struct catcher)
9815         <save_cleanup_chain>: Remove member.
9816         (exceptions_state_mc_init): Update.
9817         (exception_try_scope_entry): Return nullptr.
9818         (exception_try_scope_exit, exception_rethrow)
9819         (throw_exception_sjlj, throw_exception_cxx): Update.
9820         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9821         (all_cleanups, do_cleanups, discard_cleanups)
9822         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9823         (restore_cleanups, restore_final_cleanups): Don't declare.
9824         (do_final_cleanups): Remove parameter.
9825         * common/cleanups.c (cleanup_chain, make_cleanup)
9826         (make_cleanup_dtor, all_cleanups, do_cleanups)
9827         (discard_my_cleanups, discard_cleanups)
9828         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9829         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9830         (null_cleanup): Remove.
9831         (do_final_cleanups): Remove parameter.
9832
9833 2019-03-06  Tom Tromey  <tom@tromey.com>
9834
9835         * remote.c (remote_target::remote_parse_stop_reply): Use
9836         unique_xmalloc_ptr.
9837
9838 2019-03-06  Tom Tromey  <tom@tromey.com>
9839
9840         * stabsread.c (struct stabs_field_info): Rename from field_info.
9841         <list, fnlist>: Add initializers.
9842         <obstack>: New member.
9843         (read_member_functions, read_struct_fields, read_baseclasses):
9844         Allocate on obstack.  Don't use cleanups.
9845         (read_one_struct_field, read_member_functions, read_struct_fields)
9846         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9847         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9848         (read_struct_type): Update.
9849
9850 2019-03-06  Tom Tromey  <tom@tromey.com>
9851
9852         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9853         * common/filestuff.h (make_cleanup_close): Don't declare.
9854         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9855         Remove.
9856
9857 2019-03-06  Tom Tromey  <tom@tromey.com>
9858
9859         * solib-aix.c: Use make_scope_exit.
9860
9861 2019-03-06  Tom Tromey  <tom@tromey.com>
9862
9863         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9864         Use make_scope_exit.
9865
9866 2019-03-06  Tom Tromey  <tom@tromey.com>
9867
9868         * solib-svr4.c (disable_probes_interface): Remove parameter.
9869         (svr4_handle_solib_event): Use make_scope_exit.
9870
9871 2019-03-06  Tom Tromey  <tom@tromey.com>
9872
9873         * remote.c (struct stop_reply_deleter): Remove.
9874         (stop_reply_up): Update.
9875         (struct stop_reply): Derive from notif_event.  Don't typedef.
9876         <regcache>: Now a std::vector.
9877         (stop_reply_xfree): Remove.
9878         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9879         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9880         (remote_target::discard_pending_stop_replies): Use delete.
9881         (remote_target::remote_parse_stop_reply): Update.
9882         (remote_target::process_stop_reply): Update.
9883         * remote-notif.h (struct notif_event): Add virtual destructor.
9884         Remove "dtr" member.
9885         (struct notif_client) <alloc_event>: Return a unique_ptr.
9886         (notif_event_xfree): Don't declare.
9887         (notif_event_up): New typedef.
9888         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9889         (notif_event_xfree, do_notif_event_xfree): Remove.
9890         (remote_notif_state_xfree): Update.
9891
9892 2019-03-06  Tom Tromey  <tom@tromey.com>
9893
9894         * infrun.c (displaced_step_clear_cleanup): Now a
9895         forward_scope_exit type.
9896         (displaced_step_prepare_throw): Update.
9897         (displaced_step_fixup): Update.
9898
9899 2019-03-06  Tom Tromey  <tom@tromey.com>
9900
9901         * inferior.h (class inferior): Update comment.
9902         * gdbthread.h (class thread_info): Update comment.
9903
9904 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9905             Tom Tromey  <tom@tromey.com>
9906
9907         * stabsread.h (struct stab_section_list): Remove.
9908         (coffstab_build_psymtabs): Update.
9909         * dbxread.c (symbuf_sections): Now a std::vector.
9910         (sect_idx): New global.
9911         (fill_symbuf): Update.
9912         (coffstab_build_psymtabs): Change type of stabsects parameter.
9913         Update.
9914         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9915         std::vector.
9916         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9917         (coff_locate_sections): Update.
9918         (coff_symfile_read): Remove cleanups.  Update.
9919         (init_stringtab): Add storage parameter.
9920         (free_stringtab, free_stringtab_cleanup): Remove.
9921         (init_lineno): Add storage parameter.
9922         (free_linetab, free_linetab_cleanup): Remove.
9923
9924 2019-03-06  Pedro Alves  <palves@redhat.com>
9925
9926         * linux-fork.c (fork_info::clobber_regs): Delete.
9927         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9928         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9929         comment.  Adjust.
9930         (scoped_switch_fork_info::scoped_switch_fork_info)
9931         (checkpoint_command, linux_fork_context): Adjust
9932         fork_save_infrun_state calls.
9933
9934 2019-03-06  Pedro Alves  <palves@redhat.com>
9935
9936         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9937         (inf_has_multiple_threads): Return 'bool' and rewrite using
9938         inferior_info::threads().
9939
9940 2019-03-06  Pedro Alves  <palves@redhat.com>
9941
9942         * linux-fork.c: Include <list>.
9943         (fork_list): Now a std::list instance.
9944         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9945         (forks_exist_p, find_last_fork): Adjust.
9946         (new_fork): Delete.
9947         (one_fork_p): New.
9948         (add_fork): Adjust.
9949         (free_fork): Delete, folded into fork_info::~fork_info().
9950         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9951         Adjust.
9952         (init_fork_list): Delete.
9953         (linux_fork_killall, linux_fork_mourn_inferior)
9954         (linux_fork_detach, info_checkpoints_command): Adjust.
9955         (_initialize_linux_fork): No longer call init_fork_list.
9956
9957 2019-03-06  Pedro Alves  <palves@redhat.com>
9958
9959         * linux-fork.c (new_fork): New, split out of ...
9960         (add_fork): ... this.  Return void.  Move "first fork" special
9961         case from here, to ...
9962         (checkpoint_command): ... here.
9963         * linux-linux.h (add_fork): Return void.
9964
9965 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9966
9967         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9968
9969 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9970             Chris January  <chris.january@arm.com>
9971             David Lecomber  <david.lecomber@arm.com>
9972
9973         * f-exp.y: New token, UNOP_INTRINSIC.
9974         (exp): New pattern using UNOP_INTRINSIC token.
9975         (f77_keywords): Add 'abs' keyword.
9976         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9977         (value_from_host_double): New function.
9978         (evaluate_subexp_f): Support UNOP_ABS.
9979
9980 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9981
9982         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9983         types.
9984
9985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9986
9987         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9988         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9989         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9990
9991 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9992
9993         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9994
9995 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9996             Chris January  <chris.january@arm.com>
9997
9998         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9999         * f-exp.y: Define 'KIND' token.
10000         (exp): New pattern for KIND expressions.
10001         (ptype): Handle types with a kind extension.
10002         (direct_abs_decl): Extend to spot kind extensions.
10003         (f77_keywords): Add 'kind' to the list.
10004         (push_kind_type): New function.
10005         (convert_to_kind_type): New function.
10006         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10007         * parse.c (operator_length_standard): Likewise.
10008         * parser-defs.h (enum type_pieces): Add tp_kind.
10009         * std-operator.def: Add UNOP_KIND.
10010
10011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10012
10013         * f-exp.y (f_parse): Set yydebug.
10014
10015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10016
10017         * f-lang.c (evaluate_subexp_f): New function.
10018         (exp_descriptor_f): New global.
10019         (f_language_defn): Use exp_descriptor_f instead of
10020         exp_descriptor_standard.
10021
10022 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10023
10024         * f-exp.y (struct token): Add comments.
10025         (dot_ops): Remove uppercase versions and the end marker.
10026         (f77_keywords): Likewise.
10027         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10028         entries in the dot_ops array are case insensitive, and use
10029         strncasecmp to compare strings.  Also some whitespace cleanup in
10030         this area.  Similar for the f77_keywords array, except entries in
10031         this list might be case sensitive.
10032
10033 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10034
10035         * f-exp.y (struct f77_boolean_val): Add comments.
10036         (boolean_values): Remove uppercase versions, and end marker.
10037         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10038         and use strncasecmp to achieve case insensitivity.  Additionally,
10039         perform whitespace cleanup around this code.
10040
10041 2019-03-06  Tom Tromey  <tromey@adacore.com>
10042
10043         * remote-sim.c (gdbsim_target_open): Use result of
10044         gdb_argv::release.
10045
10046 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10047         Dirk Schubert  <dirk.schubert@arm.com>
10048         Chris January  <chris.january@arm.com>
10049
10050         * eval.c (evaluate_subexp_standard): Call Fortran argument
10051         wrapping logic.
10052         * f-lang.c (struct value): A value which can be passed into a
10053         Fortran function call.
10054         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10055         where appropriate.
10056         (struct type): Value ready for a Fortran function call.
10057         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10058         is needed.
10059         * f-lang.h (fortran_argument_convert): Declaration.
10060         (fortran_preserve_arg_pointer): Declaration.
10061         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10062
10063 2019-03-05  Tom Tromey  <tromey@adacore.com>
10064
10065         * python/py-prettyprint.c (print_string_repr): Remove #if.
10066         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10067
10068 2019-03-05  Tom Tromey  <tromey@adacore.com>
10069
10070         * target.c (the_dummy_target): Move later.  Change type to
10071         "dummy_target".
10072         (initialize_targets): Don't initialize the_dummy_target.
10073
10074 2019-03-05  Tom Tromey  <tromey@adacore.com>
10075
10076         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10077         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10078
10079 2019-03-05  Tom Tromey  <tromey@adacore.com>
10080
10081         * windows-nat.c (windows_nat_target::attach)
10082         (windows_nat_target::detach): Don't call gdb_flush.
10083         * valprint.c (generic_val_print, val_print, val_print_string):
10084         Don't call gdb_flush.
10085         * utils.c (defaulted_query): Don't call gdb_flush.
10086         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10087         * target.c (target_announce_detach): Don't call gdb_flush.
10088         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10089         * remote.c (extended_remote_target::attach): Don't call
10090         gdb_flush.
10091         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10092         * printcmd.c (do_examine): Don't call gdb_flush.
10093         (info_display_command): Don't call gdb_flush.
10094         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10095         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10096         * memattr.c (info_mem_command): Don't call gdb_flush.
10097         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10098         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10099         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10100         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10101         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10102         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10103         (gnu_nat_target::detach): Don't call gdb_flush.
10104         * f-valprint.c (f_val_print): Don't call gdb_flush.
10105         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10106         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10107         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10108         gdb_flush.
10109         * c-valprint.c (c_val_print): Don't call gdb_flush.
10110         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10111
10112 2019-03-05  Tom Tromey  <tromey@adacore.com>
10113
10114         * varobj.c (update_dynamic_varobj_children): Update.
10115         (install_default_visualizer): Use reset, not release.
10116         * value.c (set_internalvar): Update.
10117         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10118         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10119         ATTRIBUTE_UNUSED_RESULT.
10120
10121 2019-03-05  Tom Tromey  <tromey@adacore.com>
10122
10123         * remote.c (class scoped_remote_fd) <release>: Add
10124         ATTRIBUTE_UNUSED_RESULT.
10125
10126 2019-03-05  Tom Tromey  <tromey@adacore.com>
10127
10128         * macroexp.c (struct macro_buffer) <release>: Add
10129         ATTRIBUTE_UNUSED_RESULT.
10130
10131 2019-03-05  Tom Tromey  <tromey@adacore.com>
10132
10133         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10134         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10135         ATTRIBUTE_UNUSED_RESULT.
10136
10137 2019-03-05  Tom Tromey  <tromey@adacore.com>
10138
10139         * common/scoped_fd.h (class scoped_fd) <release>: Add
10140         ATTRIBUTE_UNUSED_RESULT.
10141
10142 2019-03-05  Tom Tromey  <tromey@adacore.com>
10143
10144         * parser-defs.h (struct parser_state) <release>: Add
10145         ATTRIBUTE_UNUSED_RESULT.
10146
10147 2019-03-05  Tom Tromey  <tromey@adacore.com>
10148
10149         * utils.h (class gdb_argv) <release>: Add
10150         ATTRIBUTE_UNUSED_RESULT.
10151         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10152
10153 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10154
10155         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10156         for-loop range, to avoid compiler warnings.
10157
10158         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10159         avoid compiler warnings about unused variables.
10160
10161         * NEWS: Mention end of support for native debugging on MS-Windows
10162         before XP.
10163
10164         PR gdb/24292
10165         * common/netstuff.c:
10166         * gdbserver/gdbreplay.c
10167         * gdbserver/remote-utils.c:
10168         * ser-tcp.c:
10169         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10170         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10171         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10172         'getaddrinfo' and 'freeaddrinfo' were not available before
10173         Windows XP, and mingw.org's MinGW headers by default define
10174         _WIN32_WINNT to 0x500.
10175
10176 2019-03-01  Gary Benson <gbenson@redhat.com>
10177
10178         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10179
10180 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10181             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10182
10183         PR gdb/8527
10184         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10185         set_sigint_trap, clear_sigint_trap.
10186
10187 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10188
10189         * target.c (target_detach): Clear the regcache and the
10190         frame cache.
10191
10192 2019-02-27  Pedro Alves  <palves@redhat.com>
10193
10194         * utils.c (set_screen_size): When we cap the height/width sizes,
10195         tweak the corresponding command variable to show "unlimited":
10196
10197 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10198             Pedro Alves  <palves@redhat.com>
10199
10200         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10201         before calling rl_set_screen_size.
10202
10203 2019-02-27  Tom Tromey  <tromey@adacore.com>
10204
10205         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10206         define.
10207         * python/py-value.c: Remove Python 2.4 workaround.
10208         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10209         workaround.
10210         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10211         Python 2.4 workaround.
10212         * python/python-internal.h: Remove Python 2.4 comment.
10213         (Py_ssize_t): Don't define.
10214         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10215         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10216         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10217         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10218         * python/python.c (do_start_initialization): Remove Python 2.4
10219         workaround.
10220         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10221         (print_children): Remove Python 2.4 workaround.
10222         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10223         workaround.
10224         (CHARBUFFERPROC_NAME): Remove.
10225         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10226         Python 2.4 workaround.
10227
10228 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10229
10230         * NEWS: Note minimum Python version.
10231
10232 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10233
10234         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10235         code from these functions.  Remove corresponding ifdefs.  Use
10236         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10237         Remove gotos and target of gotos.
10238         (infpy_search_memory): Likewise.
10239
10240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10241
10242         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10243         (hppa_gdbarch_init): Don't register deleted functions with
10244         gdbarch.
10245
10246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10247
10248         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10249         (h8300_unwind_sp): Delete.
10250         (h8300_dummy_id): Delete.
10251         (h8300_gdbarch_init): Don't register deleted functions with
10252         gdbarch.
10253
10254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10255
10256         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10257         (ft32_unwind_pc): Delete.
10258         (ft32_unwind_sp): Delete.
10259         (ft32_gdbarch_init): Don't register deleted functions with
10260         gdbarch.
10261
10262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10263
10264         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10265         (frv_unwind_pc): Delete.
10266         (frv_unwind_sp): Delete.
10267         (frv_gdbarch_init): Don't register deleted functions with
10268         gdbarch.
10269
10270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10271
10272         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10273         (riscv_unwind_pc): Delete.
10274         (riscv_unwind_sp): Delete.
10275         (riscv_gdbarch_init): Don't register deleted functions with
10276         gdbarch.
10277
10278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10279
10280         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10281         (csky_unwind_pc): Delete.
10282         (csky_unwind_sp): Delete.
10283         (csky_gdbarch_init): Don't register deleted functions with
10284         gdbarch.
10285
10286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10287
10288         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10289         (cris_unwind_pc): Delete.
10290         (cris_unwind_sp): Delete.
10291         (cris_gdbarch_init): Don't register deleted functions with
10292         gdbarch.
10293
10294 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10295
10296         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10297         (bfin_unwind_pc): Delete.
10298         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10299
10300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10301
10302         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10303         (arm_unwind_pc): Delete.
10304         (arm_unwind_sp): Delete.
10305         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10306
10307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10308
10309         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10310         (arc_unwind_pc): Delete.
10311         (arc_unwind_sp): Delete.
10312         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10313
10314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10315
10316         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10317         (alpha_unwind_pc): Delete.
10318         (alpha_gdbarch_init): Don't register deleted functions with
10319         gdbarch.
10320
10321 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10322
10323         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10324         (aarch64_unwind_pc): Delete.
10325         (aarch64_unwind_sp): Delete.
10326         (aarch64_gdbarch_init): Don't register deleted functions with
10327         gdbarch.
10328
10329 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10330
10331         * gdbtypes.c (type_align): Don't consider static members when
10332         computing structure alignment.
10333
10334 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10335
10336         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10337         return 0 for other types.
10338         * arch-utils.c (default_type_align): Always return 0.
10339         * gdbarch.h: Regenerate.
10340         * gdbarch.sh (type_align): Extend comment.
10341         * gdbtypes.c (type_align): Add additional comments, always call
10342         gdbarch_type_align before applying the default rules.
10343         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10344         generic code will then apply a suitable default.
10345         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10346         types, return 0 for other types.
10347
10348 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10349
10350         * NEWS: Create a new section for the next release branch.
10351         Rename the section of the current branch, now that it has
10352         been cut.
10353
10354 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10355
10356         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10357         * version.in: Bump version to 8.3.50.DATE-git.
10358
10359 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10360
10361         * aix-thread.c (ptid_cmp): Remove unused variable.
10362         (get_signaled_thread): Likewise.
10363         (store_regs_user_thread): Likewise.
10364         (store_regs_kernel_thread): Likewise.
10365         (fetch_regs_kernel_thread): Remove shadowed variable.
10366
10367 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10368
10369         * features/riscv/32bit-cpu.xml: Add register numbers.
10370         * features/riscv/32bit-fpu.c: Regenerate.
10371         * features/riscv/32bit-fpu.xml: Add register numbers.
10372         * features/riscv/64bit-cpu.xml: Add register numbers.
10373         * features/riscv/64bit-fpu.c: Regenerate.
10374         * features/riscv/64bit-fpu.xml: Add register numbers.
10375
10376 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10377
10378         * NEWS: Mention two argument form of gdb.Value constructor.
10379         * python/py-value.c (convert_buffer_and_type_to_value): New
10380         function.
10381         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10382         Add support for handling an optional second argument.  Call
10383         convert_buffer_and_type_to_value as appropriate.
10384         * python/python-internal.h (Py_buffer_deleter): New struct.
10385         (Py_buffer_up): New typedef.
10386
10387 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10388
10389         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10390         instead of releasing ownership.
10391
10392 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10393
10394         * dwarf2read.c (open_and_init_dwp_file): Call
10395         elf_numsections instead of bfd_count_sections to initialize
10396         dwp_file->num_sections.
10397
10398 2019-02-25  Tom Tromey  <tromey@adacore.com>
10399
10400         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10401
10402 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10403
10404         * gcore.in: Add '--readnever' option when invoking GDB.
10405
10406 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10407
10408         * MAINTAINERS: Update my email address.
10409
10410 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10411
10412         * build-id.c (build_id_to_debug_bfd_1): New function.
10413         (build_id_to_debug_bfd): Look for separate debug file in
10414         sysroot.
10415
10416 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10417
10418         * gdbarch.sh: Update the copyright year range that is placed into
10419         generated files.
10420
10421 2019-02-22  Keith Seitz  <keiths@redhat.com>
10422
10423         PR symtab/23853
10424         * linespec.c (create_sals_line_offset): Search for the default
10425         symtab's filename instead of its fullname.
10426
10427 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10428
10429         * NEWS: Update style defaults.
10430
10431 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10432
10433         * main.c (captured_main_1): Disable styling in batch mode.
10434
10435 2019-02-20  Tom Tromey  <tom@tromey.com>
10436
10437         * symtab.c (symtab_symbol_info): Fix typos.
10438
10439 2019-02-20  Tom Tromey  <tromey@adacore.com>
10440
10441         * findcmd.c (_initialize_mem_search): Use upper case for
10442         metasyntactic variables.
10443
10444 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10445
10446         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10447         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10448
10449 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10450
10451         * top.h (source_file_name): Change to std::string.
10452         * top.c (source_file_name): Likewise.
10453         (command_line_input): Adjust.
10454         * cli/cli-script.c (script_from_file): Adjust.
10455
10456 2019-02-19  Tom Tromey  <tromey@adacore.com>
10457
10458         * ravenscar-thread.c
10459         (ravenscar_thread_target::update_thread_list): Don't call
10460         ada_build_task_list.
10461         * ada-lang.h (ada_build_task_list): Don't declare.
10462         * ada-tasks.c (struct ada_tasks_inferior_data)
10463         <task_list_valid_p>: Now bool.
10464         (read_known_tasks, ada_task_list_changed)
10465         (ada_tasks_invalidate_inferior_data): Update.
10466         (read_known_tasks_array): Return bool.
10467         (read_known_tasks_list): Likewise.
10468         (read_known_tasks): Return void.
10469         (ada_build_task_list): Now static.
10470
10471 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10472
10473         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10474         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10475
10476 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10477
10478         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10479         variant for ada_tasks_pspace_data_handle and
10480         ada_tasks_inferior_data_handle.
10481         (ada_tasks_pspace_data_cleanup): New function.
10482         (ada_tasks_inferior_data_cleanup): New function.
10483
10484 2019-02-17  Tom Tromey  <tom@tromey.com>
10485
10486         * macrotab.h (macro_source_fullname): Return a std::string.
10487         * macrotab.c (macro_include, check_for_redefinition)
10488         (macro_undef, macro_lookup_definition, foreach_macro)
10489         (foreach_macro_in_scope): Update.
10490         (macro_source_fullname): Return a std::string.
10491         * macrocmd.c (show_pp_source_pos): Update.
10492
10493 2019-02-17  Tom Tromey  <tom@tromey.com>
10494
10495         * macrocmd.c (show_pp_source_pos): Style the file names.
10496
10497 2019-02-17  Tom Tromey  <tom@tromey.com>
10498
10499         PR tui/24197:
10500         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10501
10502 2019-02-17  Tom Tromey  <tom@tromey.com>
10503
10504         * ada-lang.c (user_select_syms): Use filtered printing.
10505         * utils.c (wrap_style): New global.
10506         (desired_style): Remove.
10507         (emit_style_escape): Add stream parameter.
10508         (set_output_style, reset_terminal_style, prompt_for_continue):
10509         Update.
10510         (flush_wrap_buffer): Only flush gdb_stdout.
10511         (wrap_here): Set wrap_style.
10512         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10513         treat escape sequences as a character.  Change when wrap buffer is
10514         flushed.
10515         (fputs_styled): Do not set the output style when the default is
10516         requested.
10517         * ui-style.h (struct ui_file_style) <is_default>: New method.
10518         * source.c (print_source_lines_base): Emit escape sequences in one
10519         piece.
10520
10521 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10522
10523         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10524         integers and enumeration types.
10525
10526 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10527
10528         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10529         instead of lookup_symbol_in_language
10530         (do_exact_match): New function.
10531         (ada_get_symbol_name_matcher): Return do_exact_match when
10532         doing a verbatim match.
10533
10534 2019-02-15  Tom Tromey  <tromey@adacore.com>
10535
10536         * ravenscar-thread.c (ravenscar_thread_target::resume)
10537         (ravenscar_thread_target::wait): Special case wildcard requests.
10538
10539 2019-02-15  Tom Tromey  <tromey@adacore.com>
10540
10541         * ravenscar-thread.c (base_ptid): Remove.
10542         (struct ravenscar_thread_target) <close>: New method.
10543         <m_base_ptid>: New member.
10544         <update_inferior_ptid, active_task, task_is_currently_active,
10545         runtime_initialized>: Declare methods.
10546         <ravenscar_thread_target>: Add constructor.
10547         (ravenscar_thread_target::task_is_currently_active)
10548         (ravenscar_thread_target::update_inferior_ptid)
10549         (ravenscar_runtime_initialized): Rename.  Now methods.
10550         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10551         (ravenscar_thread_target::update_thread_list): Update.
10552         (ravenscar_thread_target::active_task): Now method.
10553         (ravenscar_thread_target::store_registers)
10554         (ravenscar_thread_target::prepare_to_store)
10555         (ravenscar_thread_target::prepare_to_store)
10556         (ravenscar_thread_target::mourn_inferior): Update.
10557         (ravenscar_inferior_created): Use "new" to create target.
10558         (ravenscar_thread_target::get_ada_task_ptid): Update.
10559         (_initialize_ravenscar): Don't initialize base_ptid.
10560         (ravenscar_ops): Remove global.
10561
10562 2019-02-15  Tom Tromey  <tromey@adacore.com>
10563
10564         * target.h (push_target): Declare new overload.
10565         * target.c (push_target): New overload, taking an rvalue reference.
10566         * remote.c (remote_target::open_1): Use push_target overload.
10567         * corelow.c (core_target_open): Use push_target overload.
10568
10569 2019-02-15  Tom Tromey  <tromey@adacore.com>
10570
10571         * ravenscar-thread.c (is_ravenscar_task)
10572         (ravenscar_task_is_currently_active): Return bool.
10573         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10574         (_initialize_ravenscar): Remove "(void)".
10575         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10576         Return bool.
10577
10578 2019-02-15  Tom Tromey  <tromey@adacore.com>
10579
10580         * ravenscar-thread.c (ravenscar_runtime_initializer)
10581         (has_ravenscar_runtime, get_running_thread_id)
10582         (ravenscar_thread_target::resume): Fix indentation.
10583
10584 2019-02-15  Tom Tromey  <tromey@adacore.com>
10585
10586         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10587         from ravenscar_arch_ops.
10588         (sparc_ravenscar_ops::fetch_registers)
10589         (sparc_ravenscar_ops::store_registers): Now methods.
10590         (sparc_ravenscar_prepare_to_store): Remove.
10591         (sparc_ravenscar_ops): Redefine.
10592         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10593         methods and destructor.  Remove members.
10594         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10595         (ravenscar_thread_target::store_registers)
10596         (ravenscar_thread_target::prepare_to_store): Update.
10597         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10598         Remove.
10599         (struct ppc_ravenscar_powerpc_ops): Derive from
10600         ravenscar_arch_ops.
10601         (ppc_ravenscar_powerpc_ops::fetch_registers)
10602         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10603         (ppc_ravenscar_powerpc_ops): Redefine.
10604         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10605         (ppc_ravenscar_e500_ops::fetch_registers)
10606         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10607         (ppc_ravenscar_e500_ops): Redefine.
10608         * aarch64-ravenscar-thread.c
10609         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10610         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10611         (aarch64_ravenscar_fetch_registers)
10612         (aarch64_ravenscar_store_registers): Now methods.
10613         (aarch64_ravenscar_ops): Redefine.
10614
10615 2019-02-15  Tom Tromey  <tromey@adacore.com>
10616
10617         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10618         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10619         (ravenscar_thread_target::stopped_by_watchpoint)
10620         (ravenscar_thread_target::stopped_data_address)
10621         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10622
10623 2019-02-15  Tom Tromey  <tromey@adacore.com>
10624
10625         * ravenscar-thread.c: Fix some typos.
10626
10627 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10628             Tom Tromey  <tromey@adacore.com>
10629
10630         * ada-lang.c (ada_exception_sal): Change addr_string to a
10631         std::string.
10632         (create_ada_exception_catchpoint): Update.
10633
10634 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10635             Tom Tromey  <tromey@adacore.com>
10636
10637         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10638         (bp_location_ops): Remove.
10639         (base_breakpoint_allocate_location): Update.
10640         (free_bp_location): Update.
10641         * ada-lang.c (class ada_catchpoint_location)
10642         <ada_catchpoint_location>: Remove ops parameter.
10643         (ada_catchpoint_location_dtor): Remove.
10644         (ada_catchpoint_location_ops): Remove.
10645         (allocate_location_exception): Update.
10646         * breakpoint.h (struct bp_location_ops): Remove.
10647         (class bp_location) <bp_location>: Remove bp_location_ops
10648         parameter.
10649         <~bp_location>: Add destructor.
10650         <ops>: Remove.
10651
10652 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10653             Pedro Alves  <palves@redhat.com>
10654
10655         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10656         'PATH_MAX'.
10657
10658 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10659             Samuel Thibault  <samuel.thibault@gnu.org>
10660             Thomas Schwinge  <thomas@codesourcery.com>
10661
10662         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10663         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10664
10665 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10666
10667         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10668         (check_empty): Use "const char *".
10669
10670         * gnu-nat.c (gnu_nat_target::detach): Instead of
10671         'detach_inferior (pid)' call
10672         'detach_inferior (find_inferior_pid (pid))'.
10673
10674         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10675         'nat/fork-inferior.o'.
10676         * gnu-nat.c: #include "nat/fork-inferior.h".
10677
10678         * gnu-nat.c (gnu_nat_target::detach): Instead of
10679         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10680         * gnu-nat.h: #include "inf-child.h".
10681         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10682         'i386_gnu_nat_target::fetch_registers'.
10683         (gnu_store_registers): Rename/move to
10684         'i386_gnu_nat_target::store_registers'.
10685
10686         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10687         * gnu-nat.h (mach_thread_info): New function.
10688         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10689
10690         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10691
10692 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10693
10694         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10695
10696 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10697
10698         * windows-nat.c (windows_add_thread): Add new parameter
10699         "main_thread_p" with default value set to false.  Update
10700         function documentation as well as all callers.
10701         (windows_delete_thread): Likewise.
10702         (fake_create_process): Update call to windows_add_thread.
10703         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10704         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10705         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10706         call to windows_delete_thread.
10707
10708 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10709
10710         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10711
10712 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10713
10714         * symfile.c (find_separate_debug_file): Use canonical path of
10715         sysroot with child_path instead of gdb_sysroot if it is valid.
10716
10717 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10718
10719         * symfile.c (find_separate_debug_file): Use child_path to
10720         determine if an object file is under a sysroot.
10721
10722 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10723
10724         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10725         unittests/child-path-selftests.c.
10726         * common/pathstuff.c (child_path): New function.
10727         * common/pathstuff.h (child_path): New prototype.
10728         * unittests/child-path-selftests.c: New file.
10729
10730 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10731
10732         * symfile.c (find_separate_debug_file): Look for separate debug
10733         files in debug directories under the sysroot.
10734
10735 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10736
10737         * symtab.h (struct minimal_symbol data_p): New const method.
10738         (struct minimal_symbol text_p): Likewise.
10739         * symtab.c (output_source_filename): Use file name style
10740         to print file name.
10741         (print_symbol_info): Likewise.
10742         (print_msymbol_info): Use address style to print addresses.
10743         Use function name style to print executable text symbols.
10744         (expand_symtab_containing_pc): Use data_p.
10745         (find_pc_sect_compunit_symtab): Likewise.
10746
10747 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10748
10749         * breakpoint.c (describe_other_breakpoints): Use address style
10750         to print addresses.
10751         (say_where): Likewise.
10752
10753 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10754
10755         * ada-typeprint.c (print_func_type): Print function name
10756         style to print function name.
10757         * c-typeprint.c (c_print_type_1): Likewise.
10758
10759 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10760
10761         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10762         for execve.
10763
10764 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10765
10766         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10767         type_stack.
10768
10769 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10770
10771         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10772         TYPE_CODE_REF types.
10773
10774 2019-02-08  Jim Wilson  <jimw@sifive.com>
10775
10776         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10777         (riscv_linux_fregset): New.
10778         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10779
10780 2019-02-07  Tom Tromey  <tom@tromey.com>
10781
10782         * thread.c (thread_cancel_execution_command): Update.
10783         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10784         methods.
10785         (struct thread_fsm_ops): Remove.
10786         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10787         (thread_fsm_should_stop, thread_fsm_return_value)
10788         (thread_fsm_set_finished, thread_fsm_finished_p)
10789         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10790         Don't declare.
10791         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10792         * infrun.c (clear_proceed_status_thread)
10793         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10794         (print_stop_event): Update.
10795         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10796         Add constructor.
10797         (step_command_fsm_ops): Remove.
10798         (new_step_command_fsm): Remove.
10799         (step_1): Update.
10800         (step_command_fsm::should_stop): Rename from
10801         step_command_fsm_should_stop.
10802         (step_command_fsm::clean_up): Rename from
10803         step_command_fsm_clean_up.
10804         (step_command_fsm::do_async_reply_reason): Rename from
10805         step_command_fsm_async_reply_reason.
10806         (struct until_next_fsm): Inherit from thread_fsm.  Add
10807         constructor.
10808         (until_next_fsm_ops): Remove.
10809         (new_until_next_fsm): Remove.
10810         (until_next_fsm::should_stop): Rename from
10811         until_next_fsm_should_stop.
10812         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10813         (until_next_fsm::do_async_reply_reason): Rename from
10814         until_next_fsm_async_reply_reason.
10815         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10816         constructor.  Change type of breakpoint.
10817         (finish_command_fsm_ops): Remove.
10818         (new_finish_command_fsm): Remove.
10819         (finish_command_fsm::should_stop): Rename from
10820         finish_command_fsm_should_stop.
10821         (finish_command_fsm::clean_up): Rename from
10822         finish_command_fsm_clean_up.
10823         (finish_command_fsm::return_value): Rename from
10824         finish_command_fsm_return_value.
10825         (finish_command_fsm::do_async_reply_reason): Rename from
10826         finish_command_fsm_async_reply_reason.
10827         (finish_command): Update.
10828         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10829         Add constructor.
10830         (call_thread_fsm_ops): Remove.
10831         (call_thread_fsm::call_thread_fsm): Rename from
10832         new_call_thread_fsm.
10833         (call_thread_fsm::should_stop): Rename from
10834         call_thread_fsm_should_stop.
10835         (call_thread_fsm::should_notify_stop): Rename from
10836         call_thread_fsm_should_notify_stop.
10837         (run_inferior_call, call_function_by_hand_dummy): Update.
10838         * cli/cli-interp.c (should_print_stop_to_console): Update.
10839         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10840         Add constructor.  Change type of location_breakpoint,
10841         caller_breakpoint.
10842         (until_break_fsm_ops): Remove.
10843         (new_until_break_fsm): Remove.
10844         (until_break_fsm::should_stop): Rename from
10845         until_break_fsm_should_stop.
10846         (until_break_fsm::clean_up): Rename from
10847         until_break_fsm_clean_up.
10848         (until_break_fsm::do_async_reply_reason): Rename from
10849         until_break_fsm_async_reply_reason.
10850         (until_break_command): Update.
10851         * thread-fsm.c: Remove.
10852         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10853
10854 2019-02-07  Tom Tromey  <tom@tromey.com>
10855
10856         * yy-remap.h: Add include guard.
10857         * xtensa-tdep.h: Add include guard.
10858         * xcoffread.h: Rename include guard.
10859         * varobj-iter.h: Add include guard.
10860         * tui/tui.h: Rename include guard.
10861         * tui/tui-winsource.h: Rename include guard.
10862         * tui/tui-wingeneral.h: Rename include guard.
10863         * tui/tui-windata.h: Rename include guard.
10864         * tui/tui-win.h: Rename include guard.
10865         * tui/tui-stack.h: Rename include guard.
10866         * tui/tui-source.h: Rename include guard.
10867         * tui/tui-regs.h: Rename include guard.
10868         * tui/tui-out.h: Rename include guard.
10869         * tui/tui-layout.h: Rename include guard.
10870         * tui/tui-io.h: Rename include guard.
10871         * tui/tui-hooks.h: Rename include guard.
10872         * tui/tui-file.h: Rename include guard.
10873         * tui/tui-disasm.h: Rename include guard.
10874         * tui/tui-data.h: Rename include guard.
10875         * tui/tui-command.h: Rename include guard.
10876         * tic6x-tdep.h: Add include guard.
10877         * target/waitstatus.h: Rename include guard.
10878         * target/wait.h: Rename include guard.
10879         * target/target.h: Rename include guard.
10880         * target/resume.h: Rename include guard.
10881         * target-float.h: Rename include guard.
10882         * stabsread.h: Add include guard.
10883         * rs6000-tdep.h: Add include guard.
10884         * riscv-fbsd-tdep.h: Add include guard.
10885         * regformats/regdef.h: Rename include guard.
10886         * record.h: Rename include guard.
10887         * python/python.h: Rename include guard.
10888         * python/python-internal.h: Rename include guard.
10889         * python/py-stopevent.h: Rename include guard.
10890         * python/py-ref.h: Rename include guard.
10891         * python/py-record.h: Rename include guard.
10892         * python/py-record-full.h: Rename include guard.
10893         * python/py-record-btrace.h: Rename include guard.
10894         * python/py-instruction.h: Rename include guard.
10895         * python/py-events.h: Rename include guard.
10896         * python/py-event.h: Rename include guard.
10897         * procfs.h: Add include guard.
10898         * proc-utils.h: Add include guard.
10899         * p-lang.h: Add include guard.
10900         * or1k-tdep.h: Rename include guard.
10901         * observable.h: Rename include guard.
10902         * nto-tdep.h: Rename include guard.
10903         * nat/x86-linux.h: Rename include guard.
10904         * nat/x86-linux-dregs.h: Rename include guard.
10905         * nat/x86-gcc-cpuid.h: Add include guard.
10906         * nat/x86-dregs.h: Rename include guard.
10907         * nat/x86-cpuid.h: Rename include guard.
10908         * nat/ppc-linux.h: Rename include guard.
10909         * nat/mips-linux-watch.h: Rename include guard.
10910         * nat/linux-waitpid.h: Rename include guard.
10911         * nat/linux-ptrace.h: Rename include guard.
10912         * nat/linux-procfs.h: Rename include guard.
10913         * nat/linux-osdata.h: Rename include guard.
10914         * nat/linux-nat.h: Rename include guard.
10915         * nat/linux-namespaces.h: Rename include guard.
10916         * nat/linux-btrace.h: Rename include guard.
10917         * nat/glibc_thread_db.h: Rename include guard.
10918         * nat/gdb_thread_db.h: Rename include guard.
10919         * nat/gdb_ptrace.h: Rename include guard.
10920         * nat/fork-inferior.h: Rename include guard.
10921         * nat/amd64-linux-siginfo.h: Rename include guard.
10922         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10923         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10924         * nat/aarch64-linux.h: Rename include guard.
10925         * nat/aarch64-linux-hw-point.h: Rename include guard.
10926         * mn10300-tdep.h: Add include guard.
10927         * mips-linux-tdep.h: Add include guard.
10928         * mi/mi-parse.h: Rename include guard.
10929         * mi/mi-out.h: Rename include guard.
10930         * mi/mi-main.h: Rename include guard.
10931         * mi/mi-interp.h: Rename include guard.
10932         * mi/mi-getopt.h: Rename include guard.
10933         * mi/mi-console.h: Rename include guard.
10934         * mi/mi-common.h: Rename include guard.
10935         * mi/mi-cmds.h: Rename include guard.
10936         * mi/mi-cmd-break.h: Rename include guard.
10937         * m2-lang.h: Add include guard.
10938         * location.h: Rename include guard.
10939         * linux-record.h: Rename include guard.
10940         * linux-nat.h: Add include guard.
10941         * linux-fork.h: Add include guard.
10942         * i386-darwin-tdep.h: Rename include guard.
10943         * hppa-linux-offsets.h: Add include guard.
10944         * guile/guile.h: Rename include guard.
10945         * guile/guile-internal.h: Rename include guard.
10946         * gnu-nat.h: Rename include guard.
10947         * gdb-stabs.h: Rename include guard.
10948         * frv-tdep.h: Add include guard.
10949         * f-lang.h: Add include guard.
10950         * event-loop.h: Add include guard.
10951         * darwin-nat.h: Rename include guard.
10952         * cp-abi.h: Rename include guard.
10953         * config/sparc/nm-sol2.h: Rename include guard.
10954         * config/nm-nto.h: Rename include guard.
10955         * config/nm-linux.h: Add include guard.
10956         * config/i386/nm-i386gnu.h: Rename include guard.
10957         * config/djgpp/nl_types.h: Rename include guard.
10958         * config/djgpp/langinfo.h: Rename include guard.
10959         * compile/gcc-cp-plugin.h: Add include guard.
10960         * compile/gcc-c-plugin.h: Add include guard.
10961         * compile/compile.h: Rename include guard.
10962         * compile/compile-object-run.h: Rename include guard.
10963         * compile/compile-object-load.h: Rename include guard.
10964         * compile/compile-internal.h: Rename include guard.
10965         * compile/compile-cplus.h: Rename include guard.
10966         * compile/compile-c.h: Rename include guard.
10967         * common/xml-utils.h: Rename include guard.
10968         * common/x86-xstate.h: Rename include guard.
10969         * common/version.h: Rename include guard.
10970         * common/vec.h: Rename include guard.
10971         * common/tdesc.h: Rename include guard.
10972         * common/selftest.h: Rename include guard.
10973         * common/scoped_restore.h: Rename include guard.
10974         * common/scoped_mmap.h: Rename include guard.
10975         * common/scoped_fd.h: Rename include guard.
10976         * common/safe-iterator.h: Rename include guard.
10977         * common/run-time-clock.h: Rename include guard.
10978         * common/refcounted-object.h: Rename include guard.
10979         * common/queue.h: Rename include guard.
10980         * common/ptid.h: Rename include guard.
10981         * common/print-utils.h: Rename include guard.
10982         * common/preprocessor.h: Rename include guard.
10983         * common/pathstuff.h: Rename include guard.
10984         * common/observable.h: Rename include guard.
10985         * common/netstuff.h: Rename include guard.
10986         * common/job-control.h: Rename include guard.
10987         * common/host-defs.h: Rename include guard.
10988         * common/gdb_wait.h: Rename include guard.
10989         * common/gdb_vecs.h: Rename include guard.
10990         * common/gdb_unlinker.h: Rename include guard.
10991         * common/gdb_unique_ptr.h: Rename include guard.
10992         * common/gdb_tilde_expand.h: Rename include guard.
10993         * common/gdb_sys_time.h: Rename include guard.
10994         * common/gdb_string_view.h: Rename include guard.
10995         * common/gdb_splay_tree.h: Rename include guard.
10996         * common/gdb_setjmp.h: Rename include guard.
10997         * common/gdb_ref_ptr.h: Rename include guard.
10998         * common/gdb_optional.h: Rename include guard.
10999         * common/gdb_locale.h: Rename include guard.
11000         * common/gdb_assert.h: Rename include guard.
11001         * common/filtered-iterator.h: Rename include guard.
11002         * common/filestuff.h: Rename include guard.
11003         * common/fileio.h: Rename include guard.
11004         * common/environ.h: Rename include guard.
11005         * common/common-utils.h: Rename include guard.
11006         * common/common-types.h: Rename include guard.
11007         * common/common-regcache.h: Rename include guard.
11008         * common/common-inferior.h: Rename include guard.
11009         * common/common-gdbthread.h: Rename include guard.
11010         * common/common-exceptions.h: Rename include guard.
11011         * common/common-defs.h: Rename include guard.
11012         * common/common-debug.h: Rename include guard.
11013         * common/cleanups.h: Rename include guard.
11014         * common/buffer.h: Rename include guard.
11015         * common/btrace-common.h: Rename include guard.
11016         * common/break-common.h: Rename include guard.
11017         * cli/cli-utils.h: Rename include guard.
11018         * cli/cli-style.h: Rename include guard.
11019         * cli/cli-setshow.h: Rename include guard.
11020         * cli/cli-script.h: Rename include guard.
11021         * cli/cli-interp.h: Rename include guard.
11022         * cli/cli-decode.h: Rename include guard.
11023         * cli/cli-cmds.h: Rename include guard.
11024         * charset-list.h: Add include guard.
11025         * buildsym-legacy.h: Rename include guard.
11026         * bfin-tdep.h: Add include guard.
11027         * ax.h: Rename include guard.
11028         * arm-linux-tdep.h: Add include guard.
11029         * arm-fbsd-tdep.h: Add include guard.
11030         * arch/xtensa.h: Rename include guard.
11031         * arch/tic6x.h: Add include guard.
11032         * arch/i386.h: Add include guard.
11033         * arch/arm.h: Rename include guard.
11034         * arch/arm-linux.h: Rename include guard.
11035         * arch/arm-get-next-pcs.h: Rename include guard.
11036         * arch/amd64.h: Add include guard.
11037         * arch/aarch64-insn.h: Rename include guard.
11038         * arch-utils.h: Rename include guard.
11039         * annotate.h: Add include guard.
11040         * amd64-darwin-tdep.h: Rename include guard.
11041         * aarch64-linux-tdep.h: Add include guard.
11042         * aarch64-fbsd-tdep.h: Add include guard.
11043         * aarch32-linux-nat.h: Add include guard.
11044
11045 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11046
11047         * macrotab.c (macro_define_internal): New function that
11048         factorizes macro_define_object_internal and macro_define_function
11049         code.
11050         (macro_define_object_internal): Use macro_define_internal.
11051         (macro_define_function): Likewise.
11052
11053 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11054
11055         * macrocmd.c (extract_identifier): Return
11056         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11057         callers.
11058
11059 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11060
11061         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11062
11063 2019-02-05  Tom Tromey  <tom@tromey.com>
11064
11065         * target.c (target_stack::unpush): Move assertion earlier.
11066
11067 2019-01-30  Tom Tromey  <tom@tromey.com>
11068
11069         PR python/23615:
11070         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11071         (gdbpy_parse_and_eval): Likewise.
11072         * python/python-internal.h (gdbpy_allow_threads): New class.
11073
11074 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11075
11076         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11077         (aarch64_fbsd_fpregmap): Move earlier.
11078         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11079         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11080         instead of individual calls to trad_frame_set_reg_addr.
11081         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11082         earlier.
11083         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11084         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11085         instead of individual calls to trad_frame_set_reg_addr.
11086
11087 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11088
11089         * CONTRIBUTE: Replace contribution list with wiki link.
11090
11091 2019-01-25  Tom Tromey  <tom@tromey.com>
11092
11093         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11094
11095 2019-01-25  Tom Tromey  <tom@tromey.com>
11096
11097         * xtensa-linux-nat.c: Fix common/ includes.
11098         * xml-support.h: Fix common/ includes.
11099         * xml-support.c: Fix common/ includes.
11100         * x86-linux-nat.c: Fix common/ includes.
11101         * windows-nat.c: Fix common/ includes.
11102         * varobj.h: Fix common/ includes.
11103         * varobj.c: Fix common/ includes.
11104         * value.c: Fix common/ includes.
11105         * valops.c: Fix common/ includes.
11106         * utils.c: Fix common/ includes.
11107         * unittests/xml-utils-selftests.c: Fix common/ includes.
11108         * unittests/utils-selftests.c: Fix common/ includes.
11109         * unittests/unpack-selftests.c: Fix common/ includes.
11110         * unittests/tracepoint-selftests.c: Fix common/ includes.
11111         * unittests/style-selftests.c: Fix common/ includes.
11112         * unittests/string_view-selftests.c: Fix common/ includes.
11113         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11114         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11115         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11116         * unittests/rsp-low-selftests.c: Fix common/ includes.
11117         * unittests/parse-connection-spec-selftests.c: Fix common/
11118         includes.
11119         * unittests/optional-selftests.c: Fix common/ includes.
11120         * unittests/offset-type-selftests.c: Fix common/ includes.
11121         * unittests/observable-selftests.c: Fix common/ includes.
11122         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11123         * unittests/memrange-selftests.c: Fix common/ includes.
11124         * unittests/memory-map-selftests.c: Fix common/ includes.
11125         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11126         * unittests/function-view-selftests.c: Fix common/ includes.
11127         * unittests/environ-selftests.c: Fix common/ includes.
11128         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11129         * unittests/common-utils-selftests.c: Fix common/ includes.
11130         * unittests/cli-utils-selftests.c: Fix common/ includes.
11131         * unittests/array-view-selftests.c: Fix common/ includes.
11132         * ui-file.c: Fix common/ includes.
11133         * tui/tui-io.c: Fix common/ includes.
11134         * tracepoint.h: Fix common/ includes.
11135         * tracepoint.c: Fix common/ includes.
11136         * tracefile-tfile.c: Fix common/ includes.
11137         * top.h: Fix common/ includes.
11138         * top.c: Fix common/ includes.
11139         * thread.c: Fix common/ includes.
11140         * target/waitstatus.h: Fix common/ includes.
11141         * target/waitstatus.c: Fix common/ includes.
11142         * target.h: Fix common/ includes.
11143         * target.c: Fix common/ includes.
11144         * target-memory.c: Fix common/ includes.
11145         * target-descriptions.c: Fix common/ includes.
11146         * symtab.h: Fix common/ includes.
11147         * symfile.c: Fix common/ includes.
11148         * stap-probe.c: Fix common/ includes.
11149         * spu-linux-nat.c: Fix common/ includes.
11150         * sparc-nat.c: Fix common/ includes.
11151         * source.c: Fix common/ includes.
11152         * solib.c: Fix common/ includes.
11153         * solib-target.c: Fix common/ includes.
11154         * ser-unix.c: Fix common/ includes.
11155         * ser-tcp.c: Fix common/ includes.
11156         * ser-pipe.c: Fix common/ includes.
11157         * ser-base.c: Fix common/ includes.
11158         * selftest-arch.c: Fix common/ includes.
11159         * s12z-tdep.c: Fix common/ includes.
11160         * rust-exp.y: Fix common/ includes.
11161         * rs6000-aix-tdep.c: Fix common/ includes.
11162         * riscv-tdep.c: Fix common/ includes.
11163         * remote.c: Fix common/ includes.
11164         * remote-notif.h: Fix common/ includes.
11165         * remote-fileio.h: Fix common/ includes.
11166         * remote-fileio.c: Fix common/ includes.
11167         * regcache.h: Fix common/ includes.
11168         * regcache.c: Fix common/ includes.
11169         * record-btrace.c: Fix common/ includes.
11170         * python/python.c: Fix common/ includes.
11171         * python/py-type.c: Fix common/ includes.
11172         * python/py-inferior.c: Fix common/ includes.
11173         * progspace.h: Fix common/ includes.
11174         * producer.c: Fix common/ includes.
11175         * procfs.c: Fix common/ includes.
11176         * proc-api.c: Fix common/ includes.
11177         * printcmd.c: Fix common/ includes.
11178         * ppc-linux-nat.c: Fix common/ includes.
11179         * parser-defs.h: Fix common/ includes.
11180         * osdata.c: Fix common/ includes.
11181         * obsd-nat.c: Fix common/ includes.
11182         * nat/x86-linux.c: Fix common/ includes.
11183         * nat/x86-linux-dregs.c: Fix common/ includes.
11184         * nat/x86-dregs.h: Fix common/ includes.
11185         * nat/x86-dregs.c: Fix common/ includes.
11186         * nat/ppc-linux.c: Fix common/ includes.
11187         * nat/mips-linux-watch.h: Fix common/ includes.
11188         * nat/mips-linux-watch.c: Fix common/ includes.
11189         * nat/linux-waitpid.c: Fix common/ includes.
11190         * nat/linux-ptrace.h: Fix common/ includes.
11191         * nat/linux-ptrace.c: Fix common/ includes.
11192         * nat/linux-procfs.c: Fix common/ includes.
11193         * nat/linux-personality.c: Fix common/ includes.
11194         * nat/linux-osdata.c: Fix common/ includes.
11195         * nat/linux-namespaces.c: Fix common/ includes.
11196         * nat/linux-btrace.h: Fix common/ includes.
11197         * nat/linux-btrace.c: Fix common/ includes.
11198         * nat/fork-inferior.c: Fix common/ includes.
11199         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11200         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11201         * nat/aarch64-linux.c: Fix common/ includes.
11202         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11203         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11204         * namespace.h: Fix common/ includes.
11205         * mips-linux-tdep.c: Fix common/ includes.
11206         * minsyms.c: Fix common/ includes.
11207         * mi/mi-parse.h: Fix common/ includes.
11208         * mi/mi-main.c: Fix common/ includes.
11209         * mi/mi-cmd-env.c: Fix common/ includes.
11210         * memrange.h: Fix common/ includes.
11211         * memattr.c: Fix common/ includes.
11212         * maint.h: Fix common/ includes.
11213         * maint.c: Fix common/ includes.
11214         * main.c: Fix common/ includes.
11215         * machoread.c: Fix common/ includes.
11216         * location.c: Fix common/ includes.
11217         * linux-thread-db.c: Fix common/ includes.
11218         * linux-nat.c: Fix common/ includes.
11219         * linux-fork.c: Fix common/ includes.
11220         * inline-frame.c: Fix common/ includes.
11221         * infrun.c: Fix common/ includes.
11222         * inflow.c: Fix common/ includes.
11223         * inferior.h: Fix common/ includes.
11224         * inferior.c: Fix common/ includes.
11225         * infcmd.c: Fix common/ includes.
11226         * inf-ptrace.c: Fix common/ includes.
11227         * inf-child.c: Fix common/ includes.
11228         * ia64-linux-nat.c: Fix common/ includes.
11229         * i387-tdep.c: Fix common/ includes.
11230         * i386-tdep.c: Fix common/ includes.
11231         * i386-linux-tdep.c: Fix common/ includes.
11232         * i386-linux-nat.c: Fix common/ includes.
11233         * i386-go32-tdep.c: Fix common/ includes.
11234         * i386-fbsd-tdep.c: Fix common/ includes.
11235         * i386-fbsd-nat.c: Fix common/ includes.
11236         * guile/scm-type.c: Fix common/ includes.
11237         * guile/guile.c: Fix common/ includes.
11238         * go32-nat.c: Fix common/ includes.
11239         * gnu-nat.c: Fix common/ includes.
11240         * gdbthread.h: Fix common/ includes.
11241         * gdbarch-selftests.c: Fix common/ includes.
11242         * gdb_usleep.c: Fix common/ includes.
11243         * gdb_select.h: Fix common/ includes.
11244         * gdb_bfd.c: Fix common/ includes.
11245         * gcore.c: Fix common/ includes.
11246         * fork-child.c: Fix common/ includes.
11247         * findvar.c: Fix common/ includes.
11248         * fbsd-nat.c: Fix common/ includes.
11249         * event-top.c: Fix common/ includes.
11250         * event-loop.c: Fix common/ includes.
11251         * dwarf2read.c: Fix common/ includes.
11252         * dwarf2loc.c: Fix common/ includes.
11253         * dwarf2-frame.c: Fix common/ includes.
11254         * dwarf-index-cache.c: Fix common/ includes.
11255         * dtrace-probe.c: Fix common/ includes.
11256         * disasm-selftests.c: Fix common/ includes.
11257         * defs.h: Fix common/ includes.
11258         * csky-tdep.c: Fix common/ includes.
11259         * cp-valprint.c: Fix common/ includes.
11260         * cp-support.h: Fix common/ includes.
11261         * cp-support.c: Fix common/ includes.
11262         * corelow.c: Fix common/ includes.
11263         * completer.h: Fix common/ includes.
11264         * completer.c: Fix common/ includes.
11265         * compile/compile.c: Fix common/ includes.
11266         * compile/compile-loc2c.c: Fix common/ includes.
11267         * compile/compile-cplus-types.c: Fix common/ includes.
11268         * compile/compile-cplus-symbols.c: Fix common/ includes.
11269         * command.h: Fix common/ includes.
11270         * cli/cli-dump.c: Fix common/ includes.
11271         * cli/cli-cmds.c: Fix common/ includes.
11272         * charset.c: Fix common/ includes.
11273         * build-id.c: Fix common/ includes.
11274         * btrace.h: Fix common/ includes.
11275         * btrace.c: Fix common/ includes.
11276         * breakpoint.h: Fix common/ includes.
11277         * breakpoint.c: Fix common/ includes.
11278         * ax.h:
11279         (enum agent_op): Fix common/ includes.
11280         * ax-general.c (struct aop_map): Fix common/ includes.
11281         * ax-gdb.c: Fix common/ includes.
11282         * auxv.c: Fix common/ includes.
11283         * auto-load.c: Fix common/ includes.
11284         * arm-tdep.c: Fix common/ includes.
11285         * arch/riscv.c: Fix common/ includes.
11286         * arch/ppc-linux-common.c: Fix common/ includes.
11287         * arch/i386.c: Fix common/ includes.
11288         * arch/arm.c: Fix common/ includes.
11289         * arch/arm-linux.c: Fix common/ includes.
11290         * arch/arm-get-next-pcs.c: Fix common/ includes.
11291         * arch/amd64.c: Fix common/ includes.
11292         * arch/aarch64.c: Fix common/ includes.
11293         * arch/aarch64-insn.c: Fix common/ includes.
11294         * arch-utils.c: Fix common/ includes.
11295         * amd64-windows-tdep.c: Fix common/ includes.
11296         * amd64-tdep.c: Fix common/ includes.
11297         * amd64-sol2-tdep.c: Fix common/ includes.
11298         * amd64-obsd-tdep.c: Fix common/ includes.
11299         * amd64-nbsd-tdep.c: Fix common/ includes.
11300         * amd64-linux-tdep.c: Fix common/ includes.
11301         * amd64-linux-nat.c: Fix common/ includes.
11302         * amd64-fbsd-tdep.c: Fix common/ includes.
11303         * amd64-fbsd-nat.c: Fix common/ includes.
11304         * amd64-dicos-tdep.c: Fix common/ includes.
11305         * amd64-darwin-tdep.c: Fix common/ includes.
11306         * agent.c: Fix common/ includes.
11307         * ada-lang.h: Fix common/ includes.
11308         * ada-lang.c: Fix common/ includes.
11309         * aarch64-tdep.c: Fix common/ includes.
11310
11311 2019-01-25  Tom Tromey  <tom@tromey.com>
11312
11313         * common/create-version.sh: Use common/version.h.
11314
11315 2019-01-24  Pedro Alves  <palves@redhat.com>
11316
11317         * infrun.c (signal_stop, signal_print, signal_program)
11318         (signal_catch, signal_pass): Now arrays instead of pointers.
11319         (update_signals_program_target, do_target_resume)
11320         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11321         * linux-nat.c (linux_nat_target::pass_signals)
11322         (linux_nat_target::create_inferior, linux_nat_target::attach):
11323         Adjust.
11324         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11325         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11326         * procfs.c (procfs_target::pass_signals): Adjust.
11327         * record-full.c (record_full_target::resume): Adjust.
11328         * remote.c (remote_target::pass_signals)
11329         (remote_target::program_signals): Adjust.
11330         * target-debug.h (target_debug_print_signals): Now takes a
11331         gdb::array_view as parameter.  Adjust.
11332         * target.h (target_ops) <pass_signals, program_signals>: Replace
11333         pointer and length parameters with gdb::array_view.
11334         (target_pass_signals, target_program_signals): Likewise.
11335         * target-delegates.c: Regenerate.
11336
11337 2019-01-24  Pedro Alves  <palves@redhat.com>
11338
11339         * common/forward-scope-exit.h
11340         (forward_scope_exit::forward_scope_exit): Pass arguments to
11341         m_bind_function directly, instead of creating a std::bind and
11342         copying that.
11343
11344 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11345
11346         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11347         for static members.
11348         (pass_in_v_vfp_candidate): Likewise.
11349
11350 2019-01-23  Tom Tromey  <tom@tromey.com>
11351             Pedro Alves  <palves@redhat.com>
11352
11353         * regcache.c (class regcache_invalidator): Remove.
11354         (regcache::raw_write): Use make_scope_exit.
11355
11356 2019-01-23  Tom Tromey  <tom@tromey.com>
11357
11358         * ui-out.h (class ui_out_emit_type): Update comment.
11359
11360 2019-01-23  Tom Tromey  <tom@tromey.com>
11361
11362         * infrun.c (fetch_inferior_event): Update comment.
11363
11364 2019-01-23  Tom Tromey  <tom@tromey.com>
11365             Pedro Alves  <palves@redhat.com>
11366
11367         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11368         parameter.
11369         (fetch_inferior_event): Use SCOPE_EXIT.
11370
11371
11372 2019-01-23  Tom Tromey  <tom@tromey.com>
11373             Pedro Alves  <palves@redhat.com>
11374
11375         * infrun.c (disable_thread_events): Delete.
11376         (stop_all_threads): Use SCOPE_EXIT.
11377
11378 2019-01-23  Tom Tromey  <tom@tromey.com>
11379             Pedro Alves  <palves@redhat.com>
11380
11381         * symfile.c: Include forward-scope-exit.h.
11382         (clear_symtab_users_cleanup): Replace forward declaration with
11383         a FORWARD_SCOPE_EXIT.
11384         (syms_from_objfile_1): Use the forward_scope_exit and
11385         gdb::optional instead of cleanup_function.
11386         (reread_symbols): Use the forward_scope_exit instead of
11387         cleanup_function.
11388         (clear_symtab_users_cleanup): Remove function.
11389
11390 2019-01-23  Tom Tromey  <tom@tromey.com>
11391             Pedro Alves  <palves@redhat.com>
11392
11393         * linux-nat.c: Include scope-exit.h.
11394         (cleanup_target_stop): Remove.
11395         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11396         SCOPE_EXIT.
11397
11398 2019-01-23  Tom Tromey  <tom@tromey.com>
11399             Pedro Alves  <palves@redhat.com>
11400
11401         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11402         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11403
11404 2019-01-23  Tom Tromey  <tom@tromey.com>
11405             Andrew Burgess  <andrew.burgess@embecosm.com>
11406             Pedro Alves  <palves@redhat.com>
11407
11408         * infrun.c (fetch_inferior_event): Use scope_exit.
11409         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11410         * top.c (execute_command): Use scope_exit.
11411         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11412         * utils.c (do_bpstat_clear_actions_cleanup)
11413         (make_bpstat_clear_actions_cleanup): Remove.
11414
11415 2019-01-23  Tom Tromey  <tom@tromey.com>
11416             Pedro Alves  <palves@redhat.com>
11417
11418         * infrun.c: Include "common/scope-exit.h"
11419         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11420         (wait_for_inferior): Use SCOPE_EXIT.
11421         (fetch_inferior_event): Use scope_exit.
11422
11423 2019-01-23  Tom Tromey  <tom@tromey.com>
11424             Pedro Alves  <palves@redhat.com>
11425
11426         * breakpoint.c (create_breakpoint): Remove cleanup.
11427
11428 2019-01-23  Tom Tromey  <tom@tromey.com>
11429             Andrew Burgess  <andrew.burgess@embecosm.com>
11430             Pedro Alves  <palves@redhat.com>
11431
11432 2019-01-23  Pedro Alves  <palves@redhat.com>
11433
11434         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11435
11436 2019-01-23  Pedro Alves  <palves@redhat.com>
11437             Andrew Burgess  <andrew.burgess@embecosm.com>
11438
11439         * gdbthread.h: Include "common/forward-scope-exit.h".
11440         (scoped_finish_thread_state): Redefine custom class in terms of
11441         forward_scope_exit.
11442
11443 2019-01-23  Pedro Alves  <palves@redhat.com>
11444             Andrew Burgess  <andrew.burgess@embecosm.com>
11445
11446         * common/forward-scope-exit.h: New file.
11447
11448 2019-01-23  Pedro Alves  <palves@redhat.com>
11449             Andrew Burgess  <andrew.burgess@embecosm.com>
11450             Tom Tromey  <tom@tromey.com>
11451
11452         * common/scope-exit.h: New file.
11453
11454 2019-01-23  Pedro Alves  <palves@redhat.com>
11455
11456         * common/preprocessor.h (ESC): Rename to ...
11457         (ESC_PARENS): ... this.
11458         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11459         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11460
11461 2019-01-23  Tom Tromey  <tom@tromey.com>
11462
11463         * language.h (class scoped_switch_to_sym_language_if_auto):
11464         Initialize m_lang in both cases.
11465
11466 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11467
11468         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11469         with XCNEW.
11470
11471 2019-01-22  Tom Tromey  <tom@tromey.com>
11472
11473         * corelow.c: Do not include sys/file.h.
11474
11475 2019-01-22  Tom Tromey  <tom@tromey.com>
11476
11477         * tui/tui-wingeneral.h: Include gdb_curses.h.
11478
11479 2019-01-22  Tom Tromey  <tom@tromey.com>
11480
11481         * source-cache.h (class source_cache) <get_source_lines,
11482         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11483
11484 2019-01-22  Tom Tromey  <tom@tromey.com>
11485
11486         * remote-fileio.h (struct remote_target): Declare.
11487
11488 2019-01-22  Tom Tromey  <tom@tromey.com>
11489
11490         * python/py-arch.c: Do not include py-ref.h.
11491         * python/py-bpevent.c: Do not include py-ref.h.
11492         * python/py-cmd.c: Do not include py-ref.h.
11493         * python/py-continueevent.c: Do not include py-ref.h.
11494         * python/py-event.h: Do not include py-ref.h.
11495         * python/py-evtregistry.c: Do not include py-ref.h.
11496         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11497         * python/py-frame.c: Do not include py-ref.h.
11498         * python/py-framefilter.c: Do not include py-ref.h.
11499         * python/py-function.c: Do not include py-ref.h.
11500         * python/py-infevents.c: Do not include py-ref.h.
11501         * python/py-linetable.c: Do not include py-ref.h.
11502         * python/py-objfile.c: Do not include py-ref.h.
11503         * python/py-param.c: Do not include py-ref.h.
11504         * python/py-prettyprint.c: Do not include py-ref.h.
11505         * python/py-progspace.c: Do not include py-ref.h.
11506         * python/py-symbol.c: Do not include py-ref.h.
11507         * python/py-symtab.c: Do not include py-ref.h.
11508         * python/py-type.c: Do not include py-ref.h.
11509         * python/py-unwind.c: Do not include py-ref.h.
11510         * python/py-utils.c: Do not include py-ref.h.
11511         * python/py-value.c: Do not include py-ref.h.
11512         * python/py-varobj.c: Do not include py-ref.h.
11513         * python/py-xmethods.c: Do not include py-ref.h.
11514         * python/python.c: Do not include py-ref.h.
11515         * varobj.c: Do not include py-ref.h.
11516
11517 2019-01-22  Tom Tromey  <tom@tromey.com>
11518
11519         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11520         keyword for bcache.
11521
11522 2019-01-22  Tom Tromey  <tom@tromey.com>
11523
11524         * compile/compile-cplus-types.c: Remove a comment by #include.
11525
11526 2019-01-22  Tom Tromey  <tom@tromey.com>
11527
11528         * compile/gcc-c-plugin.h: Include compile-internal.h.
11529
11530 2019-01-22  Tom Tromey  <tom@tromey.com>
11531
11532         * stabsread.c (EXTERN): Do not define.
11533         (symnum, next_symbol_text_func, processing_gcc_compilation)
11534         (within_function, global_sym_chain, global_stabs)
11535         (previous_stab_code, this_object_header_files)
11536         (n_this_object_header_files)
11537         (n_allocated_this_object_header_files): Define.
11538         * stabsread.h (EXTERN): Never define.  Use "extern".
11539
11540 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11541
11542         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11543         history_value.
11544
11545 2019-01-21  Tom Tromey  <tom@tromey.com>
11546
11547         * ui-out.c: Fix includes.
11548         * tui/tui-source.c: Fix includes.
11549         * target.c: Fix includes.
11550         * remote.c: Fix includes.
11551         * regcache.c: Fix includes.
11552         * python/py-block.c: Fix includes.
11553         * printcmd.c: Fix includes.
11554         * or1k-tdep.c: Fix includes.
11555         * mi/mi-main.c: Fix includes.
11556         * m32r-tdep.c: Fix includes.
11557         * csky-tdep.c: Fix includes.
11558         * compile/compile-cplus-types.c: Fix includes.
11559         * cli/cli-interp.c: Fix includes.
11560
11561 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11562
11563         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11564         for padding.
11565
11566 2019-01-16  Tom Tromey  <tom@tromey.com>
11567
11568         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11569         earlier.
11570         (struct objfile) <msymbols_range>: Move from top level.
11571         <msymbols>: New method.
11572         (class objfile_msymbols): Remove.
11573         * symtab.c (default_collect_symbol_completion_matches_break_on):
11574         Update.
11575         * symmisc.c (dump_msymbols): Update.
11576         * stabsread.c (scan_file_globals): Update.
11577         * objc-lang.c (info_selectors_command, info_classes_command)
11578         (find_methods): Update.
11579         * minsyms.c (find_solib_trampoline_target): Update.
11580         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11581         * coffread.c (coff_symfile_read): Update.
11582         * ada-lang.c (ada_lookup_simple_minsym)
11583         (ada_collect_symbol_completion_matches): Update.
11584
11585 2019-01-16  Tom Tromey  <tom@tromey.com>
11586
11587         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11588         type.  Remove no-argument constructor.
11589         <iterator::operator++>: Simplify.
11590         <begin>: Update.
11591         <end>: Use minimal_symbol_count.
11592
11593 2019-01-16  Tom Tromey  <tom@tromey.com>
11594
11595         * objfiles.h (struct objfile) <psymtabs>: New method.
11596         (class objfile_psymtabs): Remove.
11597         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11598         typedef.
11599         <range>: New method.
11600         (require_partial_symbols): Change return type.
11601         * psymtab.c (require_partial_symbols)
11602         (psym_expand_symtabs_matching): Update.
11603         * mdebugread.c (parse_partial_symbols): Update.
11604         * dbxread.c (dbx_end_psymtab): Update.
11605
11606 2019-01-15  Tom Tromey  <tom@tromey.com>
11607
11608         * symtab.c (lookup_objfile_from_block)
11609         (lookup_symbol_in_objfile_symtabs)
11610         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11611         (find_line_symtab, info_sources_command)
11612         (default_collect_symbol_completion_matches_break_on)
11613         (make_source_files_completion_list): Update.
11614         * symmisc.c (print_objfile_statistics, dump_objfile)
11615         (maintenance_print_symbols, maintenance_info_symtabs)
11616         (maintenance_check_symtabs, maintenance_info_line_tables):
11617         Update.
11618         * source.c (select_source_symtab)
11619         (forget_cached_source_info_for_objfile): Update.
11620         * objfiles.h (class objfile_compunits): Remove.
11621         (struct objfile) <compunits_range>: New typedef.
11622         (compunits): New method.
11623         * objfiles.c (objfile_relocate1): Update.
11624         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11625         * maint.c (count_symtabs_and_blocks): Update.
11626         * linespec.c (iterate_over_all_matching_symtabs): Update.
11627         * cp-support.c (add_symbol_overload_list_qualified): Update.
11628         * coffread.c (coff_symtab_read): Update.
11629         * ada-lang.c (add_nonlocal_symbols)
11630         (ada_collect_symbol_completion_matches)
11631         (ada_add_global_exceptions): Update.
11632
11633 2019-01-15  Tom Tromey  <tom@tromey.com>
11634
11635         * progspace.h (program_space) <objfiles_safe_range>: New
11636         typedef.
11637         <objfiles_safe>: New method.
11638         * objfiles.h (class all_objfiles_safe): Remove.
11639         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11640         * jit.c (jit_inferior_exit_hook): Update.
11641
11642 2019-01-17  Tom Tromey  <tom@tromey.com>
11643
11644         * progspace.h (program_space) <objfiles_range>: New typedef.
11645         <objfiles>: New method.
11646         <objfiles_head>: Rename from objfiles.
11647         (object_files): Update.
11648         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11649         * guile/scm-pretty-print.c
11650         (ppscm_find_pretty_printer_from_objfiles): Update.
11651         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11652         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11653         Update.
11654         * python/py-progspace.c (pspy_get_objfiles): Update.
11655         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11656         Update.
11657         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11658         (objfpy_lookup_objfile_by_build_id): Update.
11659         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11660         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11661         Update.
11662         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11663         (expand_symtab_containing_pc, lookup_objfile_from_block)
11664         (lookup_static_symbol, basic_lookup_transparent_type)
11665         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11666         (find_line_symtab, info_sources_command)
11667         (default_collect_symbol_completion_matches_break_on)
11668         (make_source_files_completion_list, find_main_name): Update.
11669         * symmisc.c (print_symbol_bcache_statistics)
11670         (print_objfile_statistics, maintenance_print_symbols)
11671         (maintenance_print_msymbols, maintenance_print_objfiles)
11672         (maintenance_info_symtabs, maintenance_check_symtabs)
11673         (maintenance_expand_symtabs, maintenance_info_line_tables):
11674         Update.
11675         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11676         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11677         (map_overlay_command, unmap_overlay_command)
11678         (simple_overlay_update, expand_symtabs_matching)
11679         (map_symbol_filenames): Update.
11680         * symfile-debug.c (set_debug_symfile): Update.
11681         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11682         Update.
11683         * source.c (select_source_symtab, forget_cached_source_info):
11684         Update.
11685         * solib.c (solib_read_symbols): Update.
11686         * solib-spu.c (append_ocl_sos): Update.
11687         * psymtab.c (maintenance_print_psymbols)
11688         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11689         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11690         * printcmd.c (info_symbol_command): Update.
11691         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11692         Update.
11693         * objfiles.h (class all_objfiles): Remove.
11694         * objfiles.c (have_partial_symbols, have_full_symbols)
11695         (have_minimal_symbols, qsort_cmp, update_section_map)
11696         (shared_objfile_contains_address_p)
11697         (default_iterate_over_objfiles_in_search_order): Update.
11698         * objc-lang.c (info_selectors_command, info_classes_command)
11699         (find_methods): Update.
11700         * minsyms.c (find_solib_trampoline_target): Update.
11701         * maint.c (maintenance_info_sections)
11702         (maintenance_translate_address, count_symtabs_and_blocks):
11703         Update.
11704         * main.c (captured_main_1): Update.
11705         * linux-thread-db.c (try_thread_db_load_from_pdir)
11706         (has_libpthread): Update.
11707         * linespec.c (iterate_over_all_matching_symtabs)
11708         (search_minsyms_for_name): Update.
11709         * jit.c (jit_find_objf_with_entry_addr): Update.
11710         * hppa-tdep.c (find_unwind_entry)
11711         (hppa_lookup_stub_minimal_symbol): Update.
11712         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11713         Update.
11714         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11715         (elf_gnu_ifunc_resolve_by_got): Update.
11716         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11717         * dwarf-index-write.c (save_gdb_index_command): Update.
11718         * cp-support.c (add_symbol_overload_list_qualified): Update.
11719         * breakpoint.c (create_overlay_event_breakpoint)
11720         (create_longjmp_master_breakpoint)
11721         (create_std_terminate_master_breakpoint)
11722         (create_exception_master_breakpoint): Update.
11723         * blockframe.c (find_pc_partial_function): Update.
11724         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11725         (ada_collect_symbol_completion_matches)
11726         (ada_add_global_exceptions): Update.
11727
11728 2019-01-17  Tom Tromey  <tom@tromey.com>
11729
11730         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11731         declare VEC.
11732         (solib_target_parse_libraries): Change return type.
11733         (library_list_start_segment, library_list_start_section)
11734         (library_list_end_library, library_list_start_library); Update.
11735         (solib_target_free_library_list): Remove.
11736         (solib_target_parse_libraries): Remove cleanup.  Change return
11737         type.
11738         (solib_target_current_sos): Update.
11739
11740 2019-01-17  Tom Tromey  <tromey@bapiya>
11741
11742         * valprint.c: Replace "the the" with "the".
11743         * symtab.c: Replace "the the" with "the".
11744         * solib.c: Replace "the the" with "the".
11745         * solib-dsbt.c: Replace "the the" with "the".
11746         * linespec.c: Replace "the the" with "the".
11747         * dwarf2loc.h: Replace "the the" with "the".
11748         * amd64-windows-tdep.c: Replace "the the" with "the".
11749         * aarch64-tdep.c: Replace "the the" with "the".
11750
11751 2019-01-16  Keith Seitz  <keiths@redhat.com>
11752
11753         PR gdb/23773
11754         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11755         <builder>: Rename to ..
11756         <m_builder>: ... this and make private.
11757         (dwarf2_cu::get_builder): New method.  Change all users of
11758         `builder' to use this method.
11759         (dwarf2_start_symtab): Move to ...
11760         (dwarf2_cu::start_symtab): ... here.  Update all callers
11761         (setup_type_unit_groups): Move to ...
11762         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11763         callers.
11764         (dwarf2_cu::reset_builder): New method.
11765         (process_full_compunit, process_full_type_unit): Use
11766         dwarf2_cu::reset_builder.
11767         (follow_die_offset): Record the ancestor CU if it is different
11768         from the followed DIE's CU.
11769         (follow_die_sig_1): Likewise.
11770
11771 2019-01-15  Tom Tromey  <tom@tromey.com>
11772
11773         * remote.c (class remote_state) <buf>: Now a char_vector.
11774         <buf_size>: Remove.
11775         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11776         parameter.
11777         (remote_target::getpkt_or_notif_sane_1)
11778         (remote_target::getpkt_sane)
11779         (remote_target::getpkt_or_notif_sane): Likewise.
11780         (class remote_target) <putpkt>: New overload.
11781         (remote_target::read_frame): Change type of "buf_p".  Remove
11782         sizeof_p parameter.
11783         (packet_ok): New overload.
11784         (packet_check_result): New overload.
11785         Update all uses.
11786
11787 2019-01-14  Tom Tromey  <tom@tromey.com>
11788
11789         * remote-notif.c (handle_notification, remote_notif_ack)
11790         (remote_notif_parse): Make "buf" const.
11791         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11792         const.
11793         (remote_notif_parse, remote_notif_ack, handle_notification):
11794         Likewise.
11795         * remote.c (remote_notif_stop_parse): Make "buf" const.
11796         (remote_target::remote_parse_stop_reply): Make "buf" const.
11797         (remote_notif_stop_ack): Make "buf" const.
11798
11799 2019-01-14  Tom Tromey  <tom@tromey.com>
11800
11801         * remote.c (remote_console_output): Make parameter const.
11802
11803 2019-01-14  Tom Tromey  <tom@tromey.com>
11804
11805         * target-debug.h (target_debug_print_signals): Constify.
11806         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11807         * procfs.c (procfs_target::pass_signals): Update.
11808         * linux-nat.c (linux_nat_target::pass_signals): Update.
11809         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11810         * target-delegates.c: Rebuild.
11811         * remote.c (remote_target::program_signals): Update.
11812         (remote_target::pass_signals): Update.
11813         * target.c (target_pass_signals): Constify argument.
11814         (target_program_signals): Likewise.
11815         * target.h (struct target_ops) <pass_signals, program_signals>:
11816         Constify argument.
11817         (target_pass_signals, target_program_signals): Constify argument.
11818
11819 2019-01-14  Tom Tromey  <tom@tromey.com>
11820
11821         PR tui/28819:
11822         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11823
11824 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11825
11826         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11827         field.
11828         * rs6000-tdep.c: Include reggroups.h.
11829         (IS_V_ALIAS_PSEUDOREG): Define.
11830         (rs6000_register_name): Return names for the "vX" aliases.
11831         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11832         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11833         aliases.  Call default_register_reggroup_p for all other
11834         pseudo-registers.
11835         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11836         New functions.
11837         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11838         Handle "vX" aliases.
11839         (v_alias_pseudo_register_collect): New function.
11840         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11841         (rs6000_gdbarch_init): Initialize "vX" aliases as
11842         pseudo-registers.  Restore registration of
11843         rs6000_pseudo_register_reggroup_p with
11844         set_tdesc_pseudo_register_reggroup_p.
11845
11846 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11847
11848         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11849         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11850         set_gdbarch_num_pseudo_regs.
11851
11852 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11853
11854         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11855         Remove arg prefixname, add do_set and do_show.
11856         Add member functions set_list and show_list.
11857         * cli/cli-style.c (class cli_style_option): Update accordingly.
11858         (style_set_list): Move to file scope.
11859         (style_show_list): Likewise.
11860         (set_style): Call help_list.
11861         (show_style): Call cmd_show_list.
11862         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11863         Update to use the new macro.
11864
11865 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11866
11867         * ada-lang.c (_initialize_ada_language): Expand the help text
11868         for the "catch exception" command.
11869
11870 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11871
11872         * symtab.c (matching_obj_sections): Initialize obj,
11873         declare it closer to its usage.
11874
11875 2019-01-10  Tom Tromey  <tom@tromey.com>
11876
11877         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11878         (basic_inf_threads_range): Remove.
11879         (inf_threads_range, inf_non_exited_threads_range)
11880         (safe_inf_threads_range): Use next_adapter.
11881
11882 2019-01-10  Keith Seitz  <keiths@redhat.com>
11883
11884         PR gdb/23712
11885         PR symtab/23010
11886         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11887         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11888
11889 2019-01-10  Keith Seitz  <keiths@redhat.com>
11890
11891         PR gdb/23712
11892         PR symtab/23010
11893         * dictionary.c (pending_to_vector): Remove.
11894         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11895         Remove _1 suffix, replacing functions of the same name.  Update
11896         all callers.
11897         (dict_create_hashed, dict_create_hashed_expandable)
11898         (dict_create_linear, dict_create_linear_expandable, dict_free)
11899         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11900         Make functions static.
11901
11902 2019-01-10  Keith Seitz  <keiths@redhat.com>
11903
11904         PR gdb/23712
11905         PR symtab/23010
11906         * dictionary.h (struct dictionary): Replace declaration with
11907         multidictionary.
11908         (dict_create_hashed, dict_create_hashed_expandable)
11909         (dict_create_linear, dict_create_linear_expandable)
11910         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11911         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11912         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11913         taking multidictionary argument.
11914         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11915         * block.h (struct block) <dict>: Change to multidictionary
11916         and rename `multidict'.
11917         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11918         symmisc.c: Update all dictionary references to multidictionary.
11919
11920 2019-01-10  Keith Seitz  <keiths@redhat.com>
11921
11922         PR gdb/23712
11923         PR symtab/23010
11924         * dictionary.c: Include unordered_map.
11925         (pending_to_vector): New function.
11926         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11927         Rewrite the non-"_1" functions to take vector instead
11928         of linked list.
11929         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11930         "new" _1 versions of the same name.
11931         (multidictionary): Define.
11932         (std::hash<enum language): New definition.
11933         (collate_pending_symbols_by_language, mdict_create_hashed)
11934         (mdict_create_hashed_expandable, mdict_create_linear)
11935         (mdict_create_linear_expandable, mdict_free)
11936         (find_language_dictionary, create_new_language_dictionary)
11937         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11938         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11939         (mdict_size, mdict_empty): New functions.
11940         * dictionary.h (mdict_iterator): Define.
11941
11942 2019-01-10  Pedro Alves  <palves@redhat.com>
11943
11944         * breakpoint.c (read_uploaded_action)
11945         (create_tracepoint_from_upload): Adjust to use
11946         gdb::unique_xmalloc_ptr.
11947         * ctf.c (ctf_write_uploaded_tp):
11948         (SET_ARRAY_FIELD): Use emplace_back.
11949         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11950         * tracefile-tfile.c (tfile_write_uploaded_tp):
11951         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11952         gdb::unique_xmalloc_ptr.
11953         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11954         at_string, cond_string, cmd_strings>: Replace char pointers
11955         with gdb::unique_xmalloc_ptr.
11956
11957 2019-01-10  Pedro Alves  <palves@redhat.com>
11958
11959         * solib-target.c (library_list_start_library): Don't xstrdup name.
11960
11961 2019-01-10  Pedro Alves  <palves@redhat.com>
11962
11963         * mdebugread.c (parse_partial_symbols): Use
11964         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11965
11966 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11967
11968         * linux-fork.c (scoped_switch_fork_info)
11969         <~scoped_switch_fork_info>: Fix incorrect variable name.
11970
11971 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11972
11973         * linux-fork.c (scoped_switch_fork_info)
11974         <scoped_switch_fork_info>: Make explicit.
11975         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11976
11977 2019-01-10  Tom Tromey  <tom@tromey.com>
11978
11979         * objfiles.h (objfile::reset_psymtabs): Update.
11980         * objfiles.c (objfile::objfile): Update.
11981         * psymtab.h (psymtab_storage::obstack): Update.
11982         (psymtab_storage::m_obstack): Use gdb::optional.
11983         (class psymtab_storage): Update comment.  Remove objfile
11984         parameter.
11985         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11986
11987 2019-01-10  Tom Tromey  <tom@tromey.com>
11988
11989         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11990         <free_psymtabs>: Now private.
11991         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11992         (allocate_psymtab): Use new method.
11993
11994 2019-01-10  Tom Tromey  <tom@tromey.com>
11995
11996         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11997         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11998         * mdebugread.c (parse_partial_symbols): Use
11999         allocate_dependencies.
12000         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12001         allocate_dependencies.
12002         (process_psymtab_comp_unit_reader)
12003         (build_type_psymtab_dependencies): Likewise.
12004         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12005
12006 2019-01-10  Tom Tromey  <tom@tromey.com>
12007
12008         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12009         PSYMBOL_SET_LANGUAGE.
12010         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12011
12012 2019-01-10  Tom Tromey  <tom@tromey.com>
12013
12014         * psymtab.h (psymtab_storage::obstack): New method.
12015         <m_obstack>: Rename from obstack; now private.
12016         * psymtab.c (psymtab_storage): Update.
12017         * dwarf2read.c (create_addrmap_from_index)
12018         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12019         Update.
12020
12021 2019-01-10  Tom Tromey  <tom@tromey.com>
12022
12023         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12024         * objfiles.h (objfile::reset_psymtabs): New method.
12025
12026 2019-01-10  Tom Tromey  <tom@tromey.com>
12027
12028         * symmisc.c (print_symbol_bcache_statistics): Update.
12029         (print_objfile_statistics): Update.
12030         * symfile.c (reread_symbols): Update.
12031         * psymtab.h (class psymtab_storage): New.
12032         * psymtab.c (psymtab_storage): New constructor.
12033         (~psymtab_storage): New destructor.
12034         (require_partial_symbols): Update.
12035         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12036         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12037         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12038         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12039         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12040         (start_psymtab_common, end_psymtab_common)
12041         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12042         (allocate_psymtab): Update.
12043         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12044         Update.
12045         (dump_psymtab_addrmap, maintenance_print_psymbols)
12046         (maintenance_check_psymtabs): Update.
12047         (class objfile_psymtabs): Move to objfiles.h.
12048         * psympriv.h (discard_psymtab): Now inline.
12049         (psymtab_discarder::psymtab_discarder): Update.
12050         (psymtab_discarder::~psymtab_discarder): Update.
12051         (ALL_OBJFILE_PSYMTABS): Rewrite.
12052         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12053         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12054         Remove fields.
12055         <partial_symtabs>: New field.
12056         (class objfile_psymtabs): Move from psymtab.h.  Update.
12057         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12058         psymbol_cache.
12059         (objfile::~objfile): Don't destroy psymbol_cache.
12060         * mdebugread.c (parse_partial_symbols): Update.
12061         * dwarf2read.c (create_addrmap_from_index)
12062         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12063         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12064         (add_partial_subprogram, dwarf2_ranges_read): Update.
12065         * dwarf-index-write.c (write_address_map)
12066         (write_one_signatured_type, recursively_write_psymbols)
12067         (class debug_names, class debug_names, write_psymtabs_to_index):
12068         Update.
12069
12070 2019-01-10  Tom Tromey  <tom@tromey.com>
12071
12072         * symtab.h (SYMBOL_SET_NAMES): Update.
12073         (symbol_set_names): Update.
12074         (MSYMBOL_SET_NAMES): Update.
12075         * symtab.c (symbol_set_names): Change argument to be an
12076         objfile_per_bfd_storage.
12077         * psymtab.c (add_psymbol_to_bcache): Update.
12078         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12079
12080 2019-01-10  Tom Tromey  <tom@tromey.com>
12081
12082         * symtab.c (create_demangled_names_hash): Change argument to be an
12083         objfile_per_bfd_storage.
12084         (symbol_set_names): Update.
12085
12086 2019-01-10  Tom Tromey  <tom@tromey.com>
12087
12088         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12089         init_psymbol_list.
12090         * psymtab.c (init_psymbol_list): Do nothing if already called.
12091         * psympriv.h (init_psymbol_list): Add comment.
12092         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12093         init_psymbol_list.
12094         * dbxread.c (dbx_symfile_read): Unconditionally call
12095         init_psymbol_list.
12096
12097 2019-01-10  Tom Tromey  <tom@tromey.com>
12098
12099         * xcoffread.c (scan_xcoff_symtab): Update.
12100         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12101         "where".
12102         * mdebugread.c (parse_partial_symbols)
12103         (handle_psymbol_enumerators): Update.
12104         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12105         * dbxread.c (read_dbx_symtab): Update.
12106         * psympriv.h (psymbol_placement): New enum.
12107         (add_psymbol_to_list): Update.
12108
12109 2019-01-10  Tom Tromey  <tom@tromey.com>
12110
12111         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12112         static_psymbols parameters.
12113         (scan_xcoff_symtab): Update.
12114         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12115         static_psymbols parameters.
12116         * psympriv.h (start_psymtab_common): Update.
12117         * mdebugread.c (parse_partial_symbols): Update.
12118         * dwarf2read.c (create_partial_symtab): Update.
12119         * dbxread.c (read_dbx_symtab): Update.
12120         (start_psymtab): Remove global_psymbols and static_psymbols
12121         parameters.
12122
12123 2019-01-10  Tom Tromey  <tom@tromey.com>
12124
12125         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12126         * psymtab.c (allocate_psymtab): Add comment.
12127         * psympriv.h (allocate_psymtab): Add comment.
12128         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12129         initializations.
12130         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12131
12132 2019-01-10  Tom Tromey  <tom@tromey.com>
12133
12134         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12135         Don't declare.
12136         * mipsread.c: Include mdebugread.h.
12137         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12138         Declare.
12139         * elfread.c: Include mdebugread.h.
12140
12141 2019-01-09  Tom Tromey  <tom@tromey.com>
12142
12143         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12144         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12145         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12146         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12147         (psym_lookup_symbol, psym_find_last_source_symtab)
12148         (psym_forget_cached_source_info, psym_print_stats)
12149         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12150         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12151         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12152         (psym_find_compunit_symtab_by_address)
12153         (maintenance_print_psymbols, maintenance_info_psymtabs)
12154         (maintenance_check_psymtabs): Use ranged for.
12155         * psymtab.h (class objfile_psymtabs): New.
12156         (require_partial_symbols): Return objfile_psymtabs.
12157         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12158
12159 2019-01-09  Tom Tromey  <tom@tromey.com>
12160
12161         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12162         (find_pc_mapped_section, list_overlays_command)
12163         (map_overlay_command, unmap_overlay_command)
12164         (simple_overlay_update): Use all_objfiles.
12165         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12166         * printcmd.c (info_symbol_command): Use all_objfiles.
12167         * objfiles.h (ALL_OBJSECTIONS): Remove.
12168         * maint.c (maintenance_translate_address): Use all_objfiles.
12169         * gcore.c (gcore_create_callback): Use all_objfiles.
12170         (objfile_find_memory_regions): Likewise.
12171
12172 2019-01-09  Tom Tromey  <tom@tromey.com>
12173
12174         * symtab.c (find_line_symtab, info_sources_command)
12175         (make_source_files_completion_list): Use objfile_compunits.
12176         * source.c (select_source_symtab): Use objfile_compunits.
12177         * objfiles.h (struct objfile): Update comment.
12178         (ALL_OBJFILES): Remove.
12179         (ALL_FILETABS): Remove.
12180         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12181         objfile_compunits.
12182
12183 2019-01-09  Tom Tromey  <tom@tromey.com>
12184
12185         * symmisc.c (print_objfile_statistics, dump_objfile)
12186         (maintenance_print_symbols): Use compunit_filetabs.
12187         * source.c (forget_cached_source_info_for_objfile): Use
12188         compunit_filetabs.
12189         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12190         (ALL_FILETABS): Use compunit_filetabs.
12191         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12192         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12193
12194 2019-01-09  Tom Tromey  <tom@tromey.com>
12195
12196         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12197         (compunit_filetabs): New.
12198         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12199         compunit_filetabs.
12200         (info_sources_command, make_source_files_completion_list): Remove
12201         declaration.
12202         * symmisc.c (print_objfile_statistics, dump_objfile)
12203         (maintenance_print_symbols): Remove declaration.
12204         (maintenance_info_symtabs): Use compunit_filetabs.
12205         (maintenance_info_line_tables): Likewise.
12206         * source.c (select_source_symtab): Change local variable name.
12207         (forget_cached_source_info_for_objfile): Remove declaration.
12208         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12209         * objfiles.c (objfile_relocate1): Remove declaration.
12210         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12211         declaration.
12212         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12213         * coffread.c (coff_symtab_read): Remove declaration.
12214         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12215         compunit_filetabs.
12216
12217 2019-01-09  Tom Tromey  <tom@tromey.com>
12218
12219         * symtab.c (lookup_objfile_from_block)
12220         (find_pc_sect_compunit_symtab, search_symbols)
12221         (default_collect_symbol_completion_matches_break_on): Use
12222         objfile_compunits.
12223         * objfiles.h (ALL_COMPUNITS): Remove.
12224         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12225         * cp-support.c (add_symbol_overload_list_qualified): Use
12226         objfile_compunits.
12227         * ada-lang.c (ada_collect_symbol_completion_matches)
12228         (ada_add_global_exceptions): Use objfile_compunits.
12229
12230 2019-01-09  Tom Tromey  <tom@tromey.com>
12231
12232         * source.c (select_source_symtab)
12233         (forget_cached_source_info_for_objfile): Remove declaration.
12234         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12235         declaration.
12236         * maint.c (count_symtabs_and_blocks): Remove declaration.
12237         * cp-support.c (add_symbol_overload_list_qualified): Remove
12238         declaration.
12239         * coffread.c (coff_symtab_read): Remove declaration.
12240         * symtab.c (lookup_symbol_in_objfile_symtabs)
12241         (basic_lookup_transparent_type_1): Use objfile_compunits.
12242         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12243         (info_sources_command, search_symbols)
12244         (default_collect_symbol_completion_matches_break_on)
12245         (make_source_files_completion_list): Remove declaration.
12246         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12247         (ada_collect_symbol_completion_matches)
12248         (ada_add_global_exceptions): Remove declaration.
12249         * linespec.c (iterate_over_all_matching_symtabs): Use
12250         objfile_compunits.
12251         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12252         (class objfile_compunits): New.
12253         (ALL_COMPUNITS): Use objfile_compunits.
12254         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12255         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12256         objfile_compunits.
12257         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12258
12259 2019-01-09  Tom Tromey  <tom@tromey.com>
12260
12261         * symtab.c (search_symbols)
12262         (default_collect_symbol_completion_matches_break_on): Use
12263         objfile_msymbols.
12264         * ada-lang.c (ada_lookup_simple_minsym)
12265         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12266         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12267         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12268         objfile_msymbols.
12269         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12270         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12271         * objc-lang.c (find_methods): Use objfile_msymbols.
12272         (info_selectors_command, info_classes_command): Likewise.
12273         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12274         * objfiles.h (class objfile_msymbols): New.
12275         (ALL_OBJFILE_MSYMBOLS): Remove.
12276         (ALL_MSYMBOLS): Remove.
12277
12278 2019-01-09  Tom Tromey  <tom@tromey.com>
12279
12280         * common/next-iterator.h (next_adapter): Add Iterator template
12281         parameter.
12282         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12283         (class all_objfiles_safe): New.
12284         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12285         * objfiles.c (put_objfile_before): Update comment.
12286         (add_separate_debug_objfile): Likewise.
12287         (free_all_objfiles): Use all_objfiles_safe.
12288         (objfile_purge_solibs): Likewise.
12289
12290 2019-01-09  Tom Tromey  <tom@tromey.com>
12291
12292         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12293         (expand_symtab_containing_pc, lookup_static_symbol)
12294         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12295         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12296         all_objfiles.
12297         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12298         * breakpoint.c (create_overlay_event_breakpoint)
12299         (create_longjmp_master_breakpoint)
12300         (create_std_terminate_master_breakpoint)
12301         (create_exception_master_breakpoint): Use all_objfiles.
12302         * linux-thread-db.c (try_thread_db_load_from_pdir)
12303         (has_libpthread): Use all_objfiles.
12304         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12305         * linespec.c (iterate_over_all_matching_symtabs)
12306         (search_minsyms_for_name): Use all_objfiles.
12307         * maint.c (maintenance_info_sections): Use all_objfiles.
12308         * main.c (captured_main_1): Use all_objfiles.
12309         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12310         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12311         * guile/scm-pretty-print.c
12312         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12313         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12314         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12315         (maintenance_print_msymbols): Use all_objfiles.
12316         * source.c (select_source_symtab): Use all_objfiles.
12317         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12318         * symfile.c (remove_symbol_file_command)
12319         (expand_symtabs_matching, map_symbol_filenames): Use
12320         all_objfiles.
12321         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12322         all_objfiles.
12323         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12324         * objc-lang.c (find_methods): Use all_objfiles.
12325         * objfiles.c (have_partial_symbols, have_full_symbols)
12326         (have_minimal_symbols, qsort_cmp)
12327         (default_iterate_over_objfiles_in_search_order): Use
12328         all_objfiles.
12329         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12330         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12331         (maintenance_check_psymtabs): Use all_objfiles.
12332         (ALL_PSYMTABS): Remove.
12333         * compile/compile-object-run.c (do_module_cleanup): Use
12334         all_objfiles.
12335         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12336         * cp-support.c (add_symbol_overload_list_qualified): Use
12337         all_objfiles.
12338         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12339         Use all_objfiles.
12340         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12341         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12342         all_objfiles.
12343         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12344         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12345         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12346         Uses all_objfiles.
12347         * solib.c (solib_read_symbols): Use all_objfiles
12348
12349 2019-01-09  Tom Tromey  <tom@tromey.com>
12350
12351         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12352         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12353         all_objfiles.
12354         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12355         * symmisc.c (print_symbol_bcache_statistics)
12356         (print_objfile_statistics, maintenance_print_objfiles)
12357         (maintenance_info_symtabs, maintenance_check_symtabs)
12358         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12359         all_objfiles.
12360         * source.c (forget_cached_source_info): Use all_objfiles.
12361         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12362         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12363         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12364         * objfiles.c (update_section_map): Use all_objfiles.
12365         (shared_objfile_contains_address_p): Likewise.
12366         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12367         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12368
12369 2019-01-09  Tom Tromey  <tom@tromey.com>
12370
12371         * common/next-iterator.h: New file.
12372         * objfiles.h (class all_objfiles): New.
12373         (struct objfile_iterator): New.
12374
12375 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12376
12377         * NEWS: Move the description of the changed "frame", "select-frame",
12378          and "info frame" commands to the Changed commands section.
12379
12380 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12381
12382         * gdbtypes.c (check_stub_method_group): Remove handling of old
12383         mangling schemes.
12384         * linespec.c (find_methods): Likewise.
12385         * stabsread.c (read_member_functions): Likewise.
12386         * valops.c (search_struct_method): Likewise.
12387         (value_struct_elt_for_reference): Likewise.
12388         * NEWS: Mention this change.
12389
12390 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12391
12392         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12393         print_source_lines.
12394         * source.c (print_source_lines_base): Update line number check.
12395         (print_source_lines): New function.
12396         (source_lines_range::source_lines_range): New function.
12397         * source.h (class source_lines_range): New class.
12398         (print_source_lines): New declaration.
12399
12400 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12401
12402         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12403
12404 2019-01-08  Tom Tromey  <tom@tromey.com>
12405             Simon Marchi  <simon.marchi@ericsson.com>
12406
12407         PR gdb/24060
12408         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12409         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12410         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12411         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12412         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12413         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12414
12415 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12416
12417         * source.c (select_source_symtab): Move header comment to
12418         declaration in source.h.
12419         (forget_cached_source_info_for_objfile): Likewise.
12420         (forget_cached_source_info): Likewise.
12421         (identify_source_line): Likewise.
12422         * source.h (identify_source_line): Move declaration from symtab.h
12423         and add comment from source.c
12424         (print_source_lines): Likewise.
12425         (forget_cached_source_info_for_objfile): Likewise.
12426         (forget_cached_source_info): Likewise.
12427         (select_source_symtab): Likewise.
12428         (enum print_source_lines_flag): Move definition from symtab.h.
12429         * symtab.h (identify_source_line): Move declaration to source.h.
12430         (print_source_lines): Likewise.
12431         (forget_cached_source_info_for_objfile): Likewise.
12432         (forget_cached_source_info): Likewise.
12433         (select_source_symtab): Likewise.
12434         (enum print_source_lines_flag): Move definition to source.h.
12435         * tui/tui-hooks.c: Add 'source.h' include.
12436
12437 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12438
12439         * source.c (print_source_lines_base): Handle requests to print
12440         reverse line number sequences, and guard against empty lines
12441         string.
12442
12443 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12444
12445         * source.c (print_source_lines_base): Fix skip of '\r' if next
12446         character is '\n'.
12447
12448 2019-01-06  Tom Tromey  <tom@tromey.com>
12449
12450         * c-exp.y (struct c_parse_state) <macro_original_text,
12451         expansion_obstack>: New member.
12452         (macro_original_text, expansion_obstack): Remove globals.
12453         (scan_macro_expansion, scanning_macro_expansion)
12454         (finished_macro_expansion): Update.
12455         (scan_macro_cleanup): Remove.
12456         (yylex, c_parse): Update.
12457
12458 2019-01-06  Tom Tromey  <tom@tromey.com>
12459
12460         * c-exp.y (struct c_parse_state) <strings>: New member.
12461         (operator_stoken): Update.
12462
12463 2019-01-06  Tom Tromey  <tom@tromey.com>
12464
12465         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12466         (union type_stack_elt) <typelist_val>: Now a pointer to
12467         std::vector.
12468         (type_stack_cleanup): Don't declare.
12469         (push_typelist): Update.
12470         * parse.c (pop_typelist): Return a std::vector.
12471         (push_typelist): Take a std::vector.
12472         (follow_types): Update.  Do not free args.
12473         (type_stack_cleanup): Remove.
12474         * c-exp.y (struct c_parse_state): New.
12475         (cpstate): New global.
12476         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12477         (nonempty_typelist): Update.
12478         (func_mod): Create a new vector.
12479         (c_parse): Create a c_parse_state.
12480         (check_parameter_typelist): Do not delete params.
12481         (function_method): Update.  Do not delete type_list.
12482
12483 2019-01-06  Tom Tromey  <tom@tromey.com>
12484
12485         PR gdb/28155:
12486         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12487         check_typedef.
12488         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12489         (print_return_value): Likewise.
12490
12491 2019-01-05  Tom Tromey  <tom@tromey.com>
12492
12493         * contrib/cleanup_check.py: Remove.
12494         * contrib/gcc-with-excheck: Remove.
12495         * contrib/exsummary.py: Remove.
12496         * contrib/excheck.py: Remove.
12497
12498 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12499
12500         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12501         NULL. Initialize tpprev to NULL instead of assigning it
12502         to NULL on the next statement.
12503         * windows-nat.c (windows_delete_thread): Remove check for
12504         main_thread_id before printing thread exit notifications.
12505         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12506         Remove thread ID check against main_thread_id.
12507         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12508         windows_delete_thread.
12509         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12510
12511 2019-01-04  Tom Tromey  <tom@tromey.com>
12512
12513         * compile/compile.c (_initialize_compile): Use upper case for
12514         metasyntactic variables.
12515         * symmisc.c (_initialize_symmisc): Use upper case for
12516         metasyntactic variables.
12517         * psymtab.c (_initialize_psymtab): Use upper case for
12518         metasyntactic variables.
12519         * demangle.c (demangle_command): Use upper case for metasyntactic
12520         variables.
12521         (_initialize_demangler): Likewise.
12522         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12523         variables.
12524
12525 2019-01-03  Tom Tromey  <tom@tromey.com>
12526
12527         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12528
12529 2019-01-03  Tom Tromey  <tom@tromey.com>
12530
12531         * python/py-symtab.c (salpy_str): Update.
12532         (struct salpy_sal_object) <symtab>: Now a PyObject.
12533         (salpy_dealloc): Update.
12534         (del_objfile_sal): Use gdbpy_ref.
12535
12536 2019-01-03  Tom Tromey  <tom@tromey.com>
12537
12538         * python/py-type.c (convert_field): Use new_reference.  Return
12539         gdbpy_ref.
12540         (make_fielditem): Return gdbpy_ref.
12541         (typy_fields): Update.
12542         (typy_getitem): Update.
12543         (field_name): Return gdbpy_ref.  Use new_reference.
12544         (typy_iterator_iternext): Update.
12545
12546 2019-01-03  Tom Tromey  <tom@tromey.com>
12547
12548         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12549
12550 2019-01-03  Tom Tromey  <tom@tromey.com>
12551
12552         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12553         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12554         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12555         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12556         (pspy_set_type_printers): Likewise.
12557         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12558         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12559         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12560         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12561         (objfpy_set_type_printers): Likewise.
12562
12563 2019-01-03  Tom Tromey  <tom@tromey.com>
12564
12565         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12566         (gdbpy_print_stack): Use gdbpy_err_fetch.
12567         * python/python-internal.h (class gdbpy_err_fetch): New class.
12568         (class gdbpy_enter) <m_error_type, m_error_value,
12569         m_error_traceback>: Remove.
12570         <m_error>: New member.
12571         (gdbpy_exception_to_string): Don't declare.
12572         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12573         * python/py-value.c (convert_value_from_python): Use
12574         gdbpy_err_fetch.
12575         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12576         gdbpy_exception_to_string.
12577         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12578         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12579         gdbpy_err_fetch.
12580
12581 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12582
12583         * linux-nat.c (delete_lwp_cleanup): Delete.
12584         (struct lwp_deleter): New struct.
12585         (lwp_info_up): New typedef.
12586         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12587         lwp_info_up.
12588
12589 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12590
12591         * linux-fork.c (class scoped_switch_fork_info): New class.
12592         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12593
12594 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12595
12596         * valops.c (find_overload_match): Remove use of null_cleanup, and
12597         calls to do_cleanups.
12598
12599 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12600
12601         * compile/compile-cplus-types.c
12602         (compile_cplus_instance::decl_name): Handle changes to
12603         cp_func_name.
12604         * cp-support.c (cp_func_name): Update header comment, update
12605         return type.
12606         * cp-support.h (cp_func_name): Update return type in declaration.
12607         * valops.c (find_overload_match): Move temp_func local to top
12608         level of function and change its type.  Use temp_func to hold and
12609         delete temporary string obtained from cp_func_name.
12610
12611 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12612
12613         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12614         gdb::char_vector, remove cleanup, and update uses of `msg`.
12615
12616 2019-01-03  Jim Wilson  <jimw@sifive.com>
12617
12618         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12619
12620 2019-01-02  Tom Tromey  <tom@tromey.com>
12621
12622         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12623         (tdesc_parse_xml): Remove cleanups.
12624         * target-descriptions.h (make_cleanup_free_target_description):
12625         Don't declare.
12626         (target_desc_deleter): New struct.
12627         (target_desc_up): New typedef.
12628         * target-descriptions.c (target_desc_deleter::operator()): Rename
12629         from free_target_description.
12630         (make_cleanup_free_target_description): Remove.
12631
12632 2019-01-02  Tom Tromey  <tom@tromey.com>
12633
12634         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12635         constructor, destructor.
12636         (linespec_parser): Remove typedef.
12637         (~linespec_parser): Rename from linespec_parser_delete.
12638         (linespec_lex_to_end, linespec_complete_label)
12639         (linespec_complete): Update.
12640         (decode_line_full): Remove cleanups.
12641         (decode_line_1): Update.
12642
12643 2019-01-02  Tom Tromey  <tom@tromey.com>
12644
12645         * python/python-internal.h (inferior_to_inferior_object): Change
12646         return type.
12647         * python/py-exitedevent.c (create_exited_event_object): Update.
12648         * python/py-inferior.c (inferior_to_inferior_object): Return
12649         gdbpy_ref.
12650         (python_new_inferior, python_inferior_deleted)
12651         (thread_to_thread_object, delete_thread_object)
12652         (build_inferior_list, gdbpy_selected_inferior): Update.
12653         * python/py-infthread.c (create_thread_object): Update.  Also fail
12654         if inferior_to_inferior_object fails.
12655
12656 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12657
12658         * inferior.h (class inferior) <displaced_step_state>: New field.
12659         * infrun.h (struct displaced_step_state): Move here from
12660         infrun.c.  Initialize fields, add constructor.
12661         <inf>: Remove field.
12662         <reset>: New method.
12663         * infrun.c (struct displaced_step_inferior_state): Move to
12664         infrun.h.
12665         (displaced_step_inferior_states): Remove.
12666         (get_displaced_stepping_state): Adust.
12667         (displaced_step_in_progress_any_inferior): Adjust.
12668         (displaced_step_in_progress_thread): Adjust.
12669         (displaced_step_in_progress): Adjust.
12670         (add_displaced_stepping_state): Remove.
12671         (get_displaced_step_closure_by_addr): Adjust.
12672         (remove_displaced_stepping_state): Remove.
12673         (infrun_inferior_exit): Call displaced_step_state.reset.
12674         (use_displaced_stepping): Don't check for NULL.
12675         (displaced_step_prepare_throw): Call
12676         get_displaced_stepping_state.
12677         (displaced_step_fixup): Don't check for NULL.
12678         (prepare_for_detach): Don't check for NULL.
12679
12680 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12681
12682         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12683          in case of call that did not complete.
12684
12685 2019-01-02  Andrey Utkin  <autkin@undo.io>
12686
12687         * symfile.c (find_separate_debug_file): Fix search of debug files for
12688         remote debuggee.
12689
12690 2019-01-02  Tom Tromey  <tom@tromey.com>
12691
12692         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12693         indentation.
12694         * python/py-frame.c (frapy_older): Remove cast.
12695         (frapy_newer): Likewise.
12696         * python/py-breakpoint.c (local_setattro): Remove cast.
12697         * python/py-arch.c (archpy_name): Remove local variable.
12698         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12699
12700 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12701
12702         * unittests/basic_string_view/element_access/char/empty.cc:
12703         Fix year range in copyright header.
12704
12705 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12706
12707         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12708         Delete.
12709         <operator==>: Update with for removed field.
12710         <hash>: Likewise.
12711         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12712         <isa_features>: ...this.
12713         <abi_features>: New field.
12714         (riscv_isa_flen): Update comment.
12715         (riscv_abi_xlen): New declaration.
12716         (riscv_abi_flen): New declaration.
12717         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12718         isa_features.
12719         (riscv_abi_xlen): New function.
12720         (riscv_isa_flen): Update to get answer from isa_features.
12721         (riscv_abi_flen): New function.
12722         (riscv_has_fp_abi): Update to get answer from abi_features.
12723         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12724         xlen and flen.
12725         (riscv_call_info) <xlen, flen>: Update comment.
12726         (riscv_call_arg_struct): Remove invalid assertions
12727         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12728         is removed.
12729         (riscv_gdbarch_init): Gather isa features and abi features
12730         separately, ensure both match on the gdbarch when reusing an old
12731         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12732         a target with 64-bit float hardware.
12733
12734 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12735
12736         * source.c (search_command_helper): Stop reverse search
12737         when line 1 has been searched.
12738
12739 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12740
12741         * record-full.c (record_full_base_target::close): Rewrite
12742         record_full_core_buf_list free logic.
12743
12744 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12745
12746         * break-catch-syscall.c (print_one_catch_syscall): xfree
12747         the last text.
12748
12749 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12750
12751         * top.c (print_gdb_version): Update Copyright year in version
12752         message.
12753
12754 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12755
12756         Update copyright year range in all GDB files.
12757
12758 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12759
12760         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12761
12762 For older changes see ChangeLog-2018.
12763 \f
12764 Local Variables:
12765 mode: change-log
12766 left-margin: 8
12767 fill-column: 74
12768 version-control: never
12769 coding: utf-8
12770 End:
12771