gdb/ChangeLog

   1 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * maint.c: Add 'cmath' include.
   4         (struct maint_print_section_data): New structure.
   5         (print_section_index): New function.
   6         (print_bfd_section_info): Add header comment, small whitespace
   7         cleanup, and update to call new print_section_index function.
   8         (print_objfile_section_info): Likewise.
   9         (maint_obj_section_from_bfd_section): New function.
  10         (print_bfd_section_info_maybe_relocated): New function.
  11         (maintenance_info_sections): Add header comment, always use
  12         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
  13
  14 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  15
  16         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
  17         inner scope, add check that the objfile has psymtabs before
  18         checking psymtabs_addrmap.
  19         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
  20
  21 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  22
  23         * NEWS: Announce that Ada task names are now shown at more places,
  24         and between quotes (except in info task output).
  25         * gdb/ada-tasks.c (task_to_str): New function.
  26         (display_current_task_id): Call task_to_str.
  27         (task_command_1): Likewise.
  28         (print_ada_task_info): In non-mi mode, Properly align headers and data
  29         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
  30
  31 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  32
  33         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
  34         prstatus.pr_lwp.pr_info instead of making it up.
  35
  36 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * auto-load.c (auto_load_expand_dir_vars): Update.
  39         * defs.h (gdb_datadir): Change to std::string.
  40         (python_libdir): Likewise.
  41         (relocate_gdb_directory): Change return type to std::string.
  42         * guile/guile.c (gdbscm_data_directory): Update.
  43         (initialize_scheme_side): Update.
  44         * jit.c (jit_reader_dir): Change to std::string.
  45         (jit_reader_load_command): Update.
  46         * main.c (gdb_datadir): Change to std::string.
  47         (python_libdir): Likewise.
  48         (set_gdb_data_directory): Update.
  49         (relocate_path): Change to return std::string.
  50         (relocate_gdb_directory): Change to return std::string.
  51         (relocate_gdbinit_path_maybe_in_datadir): Update.
  52         (captured_main_1): Update.
  53         * python/python.c (do_start_initialization): Update.
  54         * top.c (show_gdb_datadir): Update.
  55         * xml-syscall.c (xml_init_syscalls_info): Update.
  56         (init_syscalls_info): Update.
  57
  58 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  59
  60         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
  61         out of get_init_files.
  62         (get_init_files): Update.
  63
  64 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  65
  66         * main.c (get_init_files): Change to use std::string.
  67         (captured_main_1): Update.
  68         (print_gdb_help): Update.
  69
  70 2019-09-11  Ali Tamur  <tamur@google.com>
  71
  72         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
  73         implementation.
  74
  75 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  76
  77         * dbxread.c (read_dbx_symtab): Update.
  78         * dwarf2read.c (load_partial_dies): Update.
  79         * mdebugread.c (parse_partial_symbols): Update.
  80         (handle_psymbol_enumerators): Update.
  81         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
  82         * psymtab.c (add_psymbol_to_bcache): Likewise.
  83         (add_psymbol_to_list): Likewise.
  84         * symtab.c (symbol_set_names): Likewise.
  85         * symtab.h (symbol_set_names): Likewise.
  86         * xcoffread.c (scan_xcoff_symtab): Update.
  87
  88 2019-09-11  Tom Tromey  <tom@tromey.com>
  89
  90         * symfile-mem.c (symbol_file_add_from_memory): Use
  91         bfd_set_filename.
  92         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
  93         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
  94
  95 2019-09-10  Tom Tromey  <tromey@adacore.com>
  96
  97         * dwarf-index-write.c (write_psymbols): Extend error message.
  98         (debug_names::insert): Add Ada code.
  99         (debug_names::write_psymbols): Remove Ada check.
 100         (debug_names) <m_string_obstack>: New member.
 101         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 102         (gdb_index_symbol_name_matcher::matches): Remove.
 103         (mapped_index_base::find_name_components_bounds): Add "lang"
 104         parameter.
 105         (mapped_index_base::build_name_components): Also split names
 106         according to Ada syntax.
 107         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 108         type of "match_callback".
 109         (check_match, check_find_bounds_finds)
 110         (dw2_expand_symtabs_matching): Update.
 111         (dw2_debug_names_iterator): Add new constructor.
 112         (dw2_debug_names_map_matching_symbols): New function.
 113         (dw2_debug_names_expand_symtabs_matching): Update.
 114         (dwarf2_debug_names_functions): Use
 115         dw2_debug_names_map_matching_symbols.
 116
 117 2019-09-10  Tom Tromey  <tromey@adacore.com>
 118
 119         * dwarf2read.c (dw2_get_file_names_reader): Add the
 120         CU's file name to the results.
 121
 122 2019-09-10  Tom Tromey  <tromey@adacore.com>
 123
 124         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 125         map_matching_symbols.  Update.
 126         * dwarf2read.c (dw2_map_matching_symbols): Update.
 127         * psymtab.c (match_partial_symbol): Change type; update.
 128         (psym_map_matching_symbols): Likewise.
 129         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 130         type; update.
 131         * symfile.h (struct quick_symbol_functions)
 132         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 133         Remove "match".
 134
 135 2019-09-10  Tom Tromey  <tromey@adacore.com>
 136
 137         * psymtab.c (map_block): Remove.
 138         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 139         * symtab.c (iterate_over_symbols_terminated): New function.
 140         * symtab.c (iterate_over_symbols_terminated): Declare.
 141
 142 2019-09-10  Tom Tromey  <tromey@adacore.com>
 143
 144         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 145         * language.h (struct language_defn) <la_iterate_over_symbols>:
 146         Return bool.
 147         * symtab.c (iterate_over_symbols): Return bool.
 148         * symtab.h (iterate_over_symbols): Return bool.
 149
 150 2019-09-10  Tom Tromey  <tromey@adacore.com>
 151
 152         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 153         (add_nonlocal_symbols): Update.
 154         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 155         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 156         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 157         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 158         Change type of "callback".  Remove "data".
 159
 160
 161 2019-09-09  Ali Tamur  <tamur@google.com>
 162
 163         * dwarf2read.c (comp_unit_head): Update comment.
 164         (dwarf2_dwo_name): New function declaration.
 165         (dwarf_unit_type_name): New function declaration.
 166         (read_comp_unit_head): Add support for new compilation units,
 167         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 168         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 169         (currently named as "signature") in their header. Also clarify error
 170         messages.
 171         (lookup_dwo_id): New function. Returns the dwo id of the given
 172         compile unit.
 173         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 174         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 175         functions.
 176         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 177         (dwarf2_dwo_name): Get the dwo name if present.
 178         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 179         purposes.
 180
 181 2019-09-09  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 184
 185 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 186
 187         * python/python.c (do_start_initialization): Make progname_copy static,
 188         to avoid a leak report.
 189
 190 2019-09-08  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 193
 194 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 195
 196         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 197         Change type to gdb::optional<block_enum>.
 198         (dw2_symtab_iter_init): Change block_index parameter type
 199         to gdb::optional<block_enum>.
 200         (dw2_lookup_symbol): Change block_index parameter
 201         type to block_enum.c
 202         (dw2_debug_names_lookup_symbol): Likewise.
 203         * psymtab.c (psym_lookup_symbol): Likewise.
 204         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 205         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 206         Likewise.
 207
 208 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 209
 210         * defs.h (relocate_gdb_directory): Change int to bool in
 211         signature and rename flag to relocatable.
 212         * main.c (relocate_path): Likewise.
 213         (relocate_gdb_directory): Likewise.
 214
 215 2019-09-06  Alan Modra  <amodra@gmail.com>
 216
 217         * coffread.c (coff_symfile_read): Constify filename variable.
 218         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 219         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 220         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 221         * solib.c (reload_shared_libraries_1): Likewise.
 222         * symfile.c (reread_symbols): Likewise.
 223         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 224         * solib-darwin.c (darwin_bfd_open): Likewise.
 225         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 226
 227 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 228
 229         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 230         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 231
 232 2019-09-03  Tom Tromey  <tromey@adacore.com>
 233
 234         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 235         types.
 236         (has_negatives): Unbias a range type bound.
 237         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 238         * gdbtypes.c (operator==): Handle new field.
 239         (create_range_type): Add "bias" parameter.
 240         (create_static_range_type, resolve_dynamic_range): Update.
 241         * gdbtypes.h (struct range_bounds) <bias>: New member.
 242         (create_range_type): Add bias parameter.
 243         * printcmd.c (print_scalar_formatted): Unbias range types.
 244         * value.c (unpack_long): Unbias range types.
 245         (pack_long): Bias range types.
 246
 247 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 248
 249         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 250         probe arguments.
 251
 252 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 253
 254         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 255         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 256         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 257         (compile_probe_arg): Likewise.
 258         * probe.h (get_argument_count): Likewise.
 259         * solib-svr4.c (solib_event_probe_action): Likewise.
 260         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 261
 262 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 263
 264         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 265         code to here...
 266         (svr4_create_solib_event_breakpoints): ...from here.
 267
 268 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 269
 270         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 271         suffix from warning message.
 272
 273 2019-08-30  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-winsource.h (struct tui_source_window_base)
 276         <refresh_all>: Don't declare.
 277         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 278         Remove.
 279         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 280         tui_show_locator_content.
 281         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 282         declare.
 283         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 284         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 285         declare.
 286
 287 2019-08-30  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 290
 291 2019-08-30  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 294         Remove unnecessary forward declarations.
 295
 296 2019-08-30  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 299         rerender.
 300         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 301         tui_show_locator_content.
 302
 303 2019-08-30  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 306         (tui_locator_window::rerender): Rewrite using body of previous
 307         tui_show_locator_content.
 308
 309 2019-08-30  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 312         set_locator_fullname>: New methods.
 313         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 314         Rename from tui_set_locator_fullname.
 315         (tui_locator_window::set_locator_info): Rename from
 316         tui_set_locator_info.  Return bool.
 317         (tui_update_locator_fullname, tui_show_frame_info): Update.
 318
 319 2019-08-30  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 322
 323 2019-08-30  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 326         call touchwin.
 327
 328 2019-08-30  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-wingeneral.c (box_win): Assume win_info and
 331         win_info->handle cannot be NULL.
 332
 333 2019-08-30  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 336         refresh_window>: Declare.
 337         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 338         resize.
 339         (tui_data_item_window::rerender): Rename from
 340         tui_display_register.
 341         (tui_data_item_window::refresh_window): New method.
 342         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 343         no-op.
 344
 345 2019-08-30  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 348         regs_column_count, current_group>: Move later.  Now private.
 349         <get_current_group>: New method.
 350         * tui/tui-regs.c (tui_reg_command): Update.
 351         * tui/tui-layout.c (tui_set_layout): Update.
 352
 353 2019-08-30  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 356         (tui_data_window::rerender): Don't call
 357         check_and_display_highlight_if_needed.
 358         (tui_data_window::refresh_all): Remove call to
 359         erase_data_content.
 360
 361 2019-08-30  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 364         (tui_data_window::display_registers_from)
 365         (tui_data_window::display_reg_element_at_line)
 366         (tui_data_window::display_registers_from_line): Remove checks of
 367         "empty".
 368
 369 2019-08-30  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 372         Don't declare.
 373         * tui/tui-regs.c (tui_data_window::show_registers): Call
 374         rerender.
 375         (tui_data_window::rerender): Rename from display_all_data.
 376         (tui_data_window::rerender): Remove old implementation.
 377
 378 2019-08-30  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 381         text.
 382         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 383
 384 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 385             Sergio Durigan Junior  <sergiodj@redhat.com>
 386
 387         PR win32/24284
 388         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 389
 390 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 393         when searching for types.
 394
 395 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 396
 397         * f-lang.c (f_language_defn): Use f_print_typedef.
 398         * f-lang.h (f_print_typedef): Declare.
 399         * f-typeprint.c (f_print_typedef): Define.
 400
 401 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 402
 403         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 404
 405 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 406
 407         * cli/cli-utils.c (info_print_options_defs): Delete.
 408         (make_info_print_options_def_group): Delete.
 409         (extract_info_print_options): Delete.
 410         (info_print_command_completer): Delete.
 411         (info_print_args_help): Add extra parameter, and optionally
 412         include text about -n flag.
 413         * cli/cli-utils.h (struct info_print_options): Delete.
 414         (extract_info_print_options): Delete declaration.
 415         (info_print_command_completer): Delete declaration.
 416         (info_print_args_help): Add extra parameter, extend header
 417         comment.
 418         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 419         search_symbols.
 420         * stack.c (struct info_print_options): New type.
 421         (info_print_options_defs): New file scoped variable.
 422         (make_info_print_options_def_group): New static function.
 423         (info_print_command_completer): New static function.
 424         (info_locals_command): Update to use new local functions.
 425         (info_args_command): Likewise.
 426         (_initialize_stack): Add extra parameter to calls to
 427         info_print_args_help.
 428         * symtab.c (search_symbols): Add extra parameter, use this to
 429         possibly excluse non-debug symbols.
 430         (symtab_symbol_info): Add extra parameter, which is passed on to
 431         search_symbols.
 432         (struct info_print_options): New type.
 433         (info_print_options_defs): New file scoped variable.
 434         (make_info_print_options_def_group): New static function.
 435         (info_print_command_completer): New static function.
 436         (info_variables_command): Update to use local functions, and pass
 437         extra parameter through to symtab_symbol_info.
 438         (info_functions_command): Likewise.
 439         (info_types_command): Pass additional argument through to
 440         symtab_symbol_info.
 441         (rbreak_command): Pass extra argument to search_symbols.
 442         (_initialize_symtab): Add extra arguments for calls to
 443         info_print_args_help, and update help text for 'info variables',
 444         'whereis', and 'info functions' commands.
 445         * symtab.h (search_symbols): Add extra argument to declaration.
 446         * NEWS: Mention new flags.
 447
 448 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 449
 450         * symtab.c (lookup_static_symbol): Call the new function (and move
 451         it down to be next to lookup_global_symbol).
 452         (struct global_sym_lookup_data): Add block_enum member and rename to...
 453         (struct global_or_static_sym_lookup_data): ...this.
 454         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 455         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 456         (lookup_symbol_global_or_static_iterator_cb): ...this.
 457         (lookup_global_or_static_symbol): New function.
 458         (lookup_global_symbol): Call new function.
 459
 460 2019-08-26  Tom de Vries  <tdevries@suse.de>
 461
 462         PR c++/24852
 463         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 464         when pc_probe.prob == NULL.
 465
 466 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 467
 468         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 469         variable symbol_linkage to symbol_linkage_.
 470
 471 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 472
 473         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 474         represent whether the symbol is static, dynamic, or we don't
 475         know.
 476
 477 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 478
 479         * gdb/rx-tdep.c (rx_register_names): New.
 480         (rx_register_name): Delete.
 481         (rx_psw_type): Delete.
 482         (rx_fpsw_type): Delete.
 483         (rx_register_type): Delete.
 484         (rx_gdbarch_init): Convert target-descriptions.
 485         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 486         * gdb/features/Makefile: Add rx.xml.
 487         * gdb/features/rx.xml: New.
 488         * gdb/features/rx.c: Generated.
 489         * gdb/NEWS: Mention target description support.
 490
 491 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 492
 493         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 494         *slot_ptr.
 495
 496 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 497
 498         * configure.ac: Don't check for 'dlfcn.h' (moved to
 499         gdbsupport/common.m4).
 500         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 501         'gdbsupport/'.
 502         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 503         * compile/compile-c-support.c: Include
 504         'gdbsupport/gdb-dlfcn.h'.
 505         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 506         * gdb-dlfcn.c: Move to...
 507         * gdbsupport/gdb-dlfcn.c: ... here.
 508         * gdb-dlfcn.h: Move to...
 509         * gdbsupport/gdb-dlfcn.h: ... here.
 510
 511 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 512
 513         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 514         the offset field signed.
 515
 516 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 517
 518         * python/lib/gdb/__init__.py (_execute_file): New function.
 519         * python/python.c (python_run_simple_file): Call gdb._execute_file
 520         on Windows.
 521
 522 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 523
 524         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 525         all uses as this was never set to anything but a zero value.
 526
 527 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 528
 529         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 530
 531 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 532
 533         * tui/tui-data.h (tui_gen_win_info): Add an =default
 534         move constructor, required by some GCC versions.
 535
 536 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 537
 538         * go32-nat.c (go32_sysinfo): Add hygon_p.
 539
 540 2019-08-20  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 543         line_from_reg_element_no, first_reg_element_no_inline,
 544         display_all_data, delete_data_content_windows,
 545         erase_data_content>: Now private.
 546
 547 2019-08-20  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 550         (tui_unhighlight_win, tui_highlight_win)
 551         (tui_win_info::make_window): Update.
 552         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 553
 554 2019-08-20  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 557         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 558         (MAX_PID_WIDTH): Move to tui-stack.c.
 559         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 560         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 561         (MAX_PID_WIDTH): Move from tui-data.h.
 562
 563 2019-08-20  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 566         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 567         (box_win): Update.
 568         (tui_gen_win_info::make_window): Rename from tui_make_window.
 569         (tui_win_info::make_window): New method.
 570         (tui_gen_win_info::make_visible): Update.
 571         * tui/tui-source.c (tui_source_window::set_contents): Update.
 572         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 573         (tui_data_window::display_registers_from): Update.
 574         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 575         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 576         Declare.
 577         <can_box>: Remove.
 578         <title>: Remove.
 579         (struct tui_win_info) <make_window>: Declare.
 580         <can_box>: Now virtual.
 581         <title>: New member.
 582         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 583         * tui/tui-command.c (tui_cmd_window::resize): Update.
 584
 585 2019-08-20  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 588         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 589         (tui_data_window::check_register_values): Update.
 590
 591 2019-08-20  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-regs.h (struct tui_data_window): Use
 594         DISABLE_COPY_AND_ASSIGN.
 595         <regs_content>: Change type, removing unique_ptr.
 596         <tui_data_window>: Add move constructor.
 597         * tui/tui-regs.c (tui_data_window::show_registers)
 598         (tui_data_window::show_register_group)
 599         (tui_data_window::display_registers_from)
 600         (tui_data_window::display_registers_from)
 601         (tui_data_window::first_data_item_displayed)
 602         (tui_data_window::delete_data_content_windows)
 603         (tui_data_window::rerender, tui_data_window::refresh_window)
 604         (tui_data_window::check_register_values): Update.
 605
 606 2019-08-20  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 609         show_register_group>: Declare.
 610         (tui_show_register_group): Don't declare.
 611         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 612         tui_show_registers.
 613         (tui_data_window::show_register_group): Rename from
 614         tui_show_register_group.
 615         (tui_data_window::check_register_values, tui_reg_command):
 616         Update.
 617         * tui/tui-layout.c (tui_set_layout): Update.
 618
 619 2019-08-20  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 622         Declare.
 623         (tui_check_register_values): Don't declare.
 624         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 625         from tui_check_register_values.
 626         * tui/tui-hooks.c (tui_register_changed): Update.
 627
 628 2019-08-20  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-regs.c (tui_reg_layout): Move later.
 631         (tui_show_registers): Don't enable TUI mode or change layout.
 632
 633 2019-08-20  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-regs.h (struct tui_data_item_window)
 636         <~tui_data_item_window>: Remove.
 637         <content>: Now a unique_xmalloc_ptr.
 638         * tui/tui-regs.c (tui_register_format): Return a
 639         unique_xmalloc_ptr.
 640         (tui_get_register): Update.
 641         (~tui_data_item_window): Remove.
 642         (tui_data_window::display_registers_from, tui_display_register):
 643         Update.
 644         * tui/tui-io.h (tui_expand_tabs): Update.
 645         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 646         Remove "col" parameter.
 647
 648 2019-08-20  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 651         field.
 652         * tui/tui-regs.c (~tui_data_item_window): Update.
 653
 654 2019-08-20  Tom Tromey  <tom@tromey.com>
 655
 656         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 657         earlier.
 658
 659 2019-08-20  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 662
 663 2019-08-20  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-source.h (struct tui_source_window): Update.
 666         * tui/tui-regs.c (tui_show_registers): Update.
 667         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 668         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 669         (NO_REGS_STRING): Remove defines.
 670
 671 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 672
 673         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 674         unnecessary thread walk if remote doesn't support the packet.
 675
 676 2019-08-19  Tom Tromey  <tromey@adacore.com>
 677
 678         * python/py-value.c (value_has_field): Fix indentation.
 679
 680 2019-08-19  Tom Tromey  <tromey@adacore.com>
 681
 682         * printcmd.c (do_one_display, info_display_command): Update.
 683         * block.h (contained_in): Return bool.  Add allow_nested
 684         parameter.
 685         * block.c (contained_in): Return bool.  Add allow_nested
 686         parameter.
 687
 688 2019-08-19  Tom Tromey  <tom@tromey.com>
 689
 690         * configure: Rebuild.
 691         * configure.ac: Disallow the combination of -static-libstdc++ and
 692         source highlight.
 693         * source-cache.c (get_language_name): Handle rust.
 694         (source_cache::get_source_lines): Ignore highlighting exceptions.
 695
 696 2019-08-16  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 699         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 700         (struct tui_source_window_base) <make_visible, refresh_window,
 701         resize>: Remove methods.
 702         <execution_info>: Remove field.
 703         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 704         (tui_show_source_line, tui_source_window_base)
 705         (~tui_source_window_base): Update.
 706         (tui_source_window_base::resize)
 707         (tui_source_window_base::make_visible)
 708         (tui_source_window_base::refresh_window): Remove.
 709         (tui_source_window_base::update_exec_info): Update.
 710         * tui/tui-source.c (tui_source_window::set_contents): Update.
 711         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 712
 713 2019-08-16  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 716         deprecated_query_hook.
 717
 718 2019-08-16  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 721         (tui_update_source_windows_with_line): Update.
 722         * tui/tui-source.h (struct tui_source_window)
 723         <show_symtab_source>: Declare.
 724         (tui_show_symtab_source): Don't declare.
 725         * tui/tui-source.c (tui_show_symtab_source): Rename from
 726         tui_show_symtab_source.
 727
 728 2019-08-16  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-winsource.h (struct tui_source_window_base)
 731         <set_contents>: Declare.
 732         * tui/tui-winsource.c
 733         (tui_source_window_base::update_source_window_as_is): Update.
 734         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 735         Declare.
 736         (tui_set_source_content): Don't declare.
 737         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 738         tui_set_source_content.
 739         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 740         Declare.
 741         (tui_set_disassem_content): Don't declare.
 742         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 743         tui_set_disassem_content.
 744
 745 2019-08-16  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-winsource.h (struct tui_source_window_base)
 748         <update_breakpoint_info>: Declare.
 749         (tui_update_breakpoint_info): Don't declare.
 750         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 751         (tui_update_all_breakpoint_info): Update.
 752         (tui_source_window_base::update_breakpoint_info): Rename from
 753         tui_update_breakpoint_info.
 754         (tui_source_window_base::update_exec_info): Update.
 755
 756 2019-08-16  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-winsource.h (struct tui_source_window_base)
 759         <update_source_window>: Declare.
 760         (tui_update_source_window): Don't declare.
 761         * tui/tui-winsource.c
 762         (tui_source_window_base::update_source_window): Rename from
 763         tui_update_source_window.
 764         (tui_source_window_base::rerender): Update.
 765         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 766         * tui/tui-disasm.c (tui_show_disassem)
 767         (tui_show_disassem_and_update_source)
 768         (tui_disasm_window::maybe_update): Update.
 769
 770 2019-08-16  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-winsource.h (struct tui_source_window_base)
 773         <update_source_window_as_is>: Declare.
 774         (tui_update_source_window_as_is): Don't declare.
 775         * tui/tui-winsource.c (tui_update_source_window): Update
 776         (tui_source_window_base::update_source_window_as_is): Rename from
 777         tui_update_source_window_as_is.
 778         (tui_source_window_base::refill): Update.
 779         * tui/tui-source.c (tui_show_symtab_source): Update.
 780         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 781         Update.
 782
 783 2019-08-16  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-winsource.h (tui_update_source_window)
 786         (tui_update_source_window_as_is): Remove "noerror" parameter.
 787         * tui/tui-winsource.c (tui_update_source_window)
 788         (tui_update_source_window_as_is): Remove "noerror" parameter.
 789         (tui_update_source_windows_with_addr)
 790         (tui_update_source_windows_with_line)
 791         (tui_source_window_base::rerender)
 792         (tui_source_window_base::refill): Update.
 793         * tui/tui-source.h (tui_set_source_content)
 794         (tui_show_symtab_source): Remove "noerror" parameter.
 795         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 796         parameter.
 797         (tui_show_symtab_source): Likewise.
 798         (tui_source_window::maybe_update): Update.
 799         * tui/tui-disasm.c (tui_show_disassem)
 800         (tui_show_disassem_and_update_source)
 801         (tui_disasm_window::do_scroll_vertical)
 802         (tui_disasm_window::maybe_update): Update.
 803
 804 2019-08-16  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui.c (tui_is_window_visible): Update.
 807         * tui/tui-wingeneral.c (tui_make_window)
 808         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 809         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 810         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 811         (tui_set_win_height_command, parse_scrolling_args): Update.
 812         * tui/tui-source.c (tui_source_window::style_changed): Update.
 813         * tui/tui-regs.c (tui_show_registers)
 814         (tui_data_window::first_data_item_displayed)
 815         (tui_data_window::delete_data_content_windows)
 816         (tui_check_register_values, tui_reg_command): Update.
 817         * tui/tui-disasm.c (tui_show_disassem): Update.
 818         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 819         method.
 820         <is_visible>: Remove field.
 821         * tui/tui-data.c (tui_next_win, tui_prev_win)
 822         (tui_delete_invisible_windows): Update.
 823
 824 2019-08-16  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-winsource.h (struct tui_source_window_base)
 827         <m_has_locator>: Remove.
 828         * tui/tui-layout.c (show_source_disasm_command, show_data)
 829         (show_source_or_disasm_and_command): Update.
 830
 831 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 832
 833         * NEWS (Other MI changes): New subsection.
 834         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 835         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 836         * arch-utils.c (default_get_pc_address_flags): New function.
 837         * arch-utils.h (default_get_pc_address_flags): New declaration.
 838         * gdbarch.sh: Add get_pc_address_flags.
 839         * gdbarch.c: Regenerate.
 840         * gdbarch.h: Likewise.
 841         * stack.c (print_pc): New function.
 842         (print_frame_info) (print_frame): Call print_pc.
 843
 844 2019-08-16  Tom de Vries  <tdevries@suse.de>
 845
 846         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 847         print_objfile_section_info.
 848
 849 2019-08-15  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 852         calling update_cmdwin_start_line.
 853         * tui/tui-winsource.h (struct tui_source_window_base)
 854         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 855         <rerender>: Declare.
 856         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 857         Call rerender.
 858         (tui_source_window_base::set_new_height): Remove.
 859         (tui_source_window_base::rerender): Rename from
 860         do_make_visible_with_new_height.
 861         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 862         resize method.
 863         (tui_win_info::make_invisible_and_set_new_height)
 864         (tui_win_info::make_visible_with_new_height): Remove.
 865         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 866         Declare.
 867         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 868         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 869         do_make_visible_with_new_height>: Don't declare.
 870         <rerender>: Declare.
 871         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 872         set_new_height.
 873         (tui_data_window::do_make_visible_with_new_height): Remove.
 874         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 875         call tui_show_locator_content.
 876         (tui_gen_win_info::resize): Call rerender.
 877         (show_source_or_disasm_and_command): Don't call
 878         tui_show_locator_content.
 879         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 880         method.
 881         (struct tui_win_info) <rerender>: Declare.
 882         <set_new_height, make_invisible_and_set_new_height,
 883         make_visible_with_new_height>: Don't declare.
 884         * tui/tui-data.c (tui_win_list::rerender): New method.
 885         * tui/tui-command.h (struct tui_cmd_window)
 886         <do_make_visible_with_new_height>: Don't declare.
 887         * tui/tui-command.c
 888         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 889
 890 2019-08-15  Tom Tromey  <tromey@adacore.com>
 891
 892         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 893         * ada-lang.c (ada_enum_name): Likewise.
 894
 895 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 896
 897         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 898         leading underscore.
 899         (GdbOutputErrorFile): Likewise.
 900         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 901         accordingly.
 902         (execute_unwinders): Rename to have a leading underscore.
 903         (auto_load_packages): Likewise.
 904         (global scope): Adjust call to auto_load_packages accordingly.
 905         (GdbSetPythonDirectory): Likewise.
 906         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 907         instead of execute_unwinders.
 908
 909 2019-08-15  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 912         (show_data): Don't change window visibility.
 913         (tui_gen_win_info::resize): Remove special case for command
 914         window.  Use wresize, when available.
 915         (show_source_or_disasm_and_command): Don't change window
 916         visibility.
 917         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 918         <make_visible>: New method.
 919         * tui/tui-command.c (tui_cmd_window::resize): New method.
 920
 921 2019-08-15  Tom Tromey  <tom@tromey.com>
 922
 923         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 924         (struct tui_source_windows): New.
 925         * tui/tui-winsource.c (tui_display_main): Update.
 926         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 927         (new_height_ok, parse_scrolling_args): Update.
 928         * tui/tui-layout.c (show_layout, show_data): Update.
 929         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 930         (tui_add_to_source_windows): Don't declare.
 931         * tui/tui-data.c (source_windows, tui_source_windows)
 932         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 933
 934 2019-08-15  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 937         Rename from reset.
 938         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 939         * tui/tui-layout.c (show_source_disasm_command, show_data):
 940         Update.
 941         (tui_gen_win_info::resize): Rename.
 942         (show_source_or_disasm_and_command): Update.
 943         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 944         reset.
 945
 946 2019-08-15  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 949         * tui/tui-interp.c (tui_interp::init): Don't call
 950         tui_initialize_static_data.
 951         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 952
 953 2019-08-15  Tom Tromey  <tom@tromey.com>
 954
 955         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 956         examine tui_win_list.
 957
 958 2019-08-15  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 961         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 962         tui_clear_source_content.
 963         (tui_clear_source_content): Remove.
 964         (tui_source_window_base::do_erase_source_content): Hoist call to
 965         content.clear().
 966         * tui/tui-stack.c (tui_show_frame_info): Don't call
 967         tui_clear_source_content.
 968
 969 2019-08-15  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-winsource.h (struct tui_source_window_base)
 972         <do_erase_source_content>: New method.
 973         <erase_source_content>: New method.
 974         (tui_erase_source_content): Don't declare.
 975         * tui/tui-winsource.c (tui_clear_source_content): Update.
 976         (tui_source_window_base::do_erase_source_content): Rename from
 977         tui_erase_source_content.
 978         (tui_source_window_base::show_source_content): Update.
 979         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 980         * tui/tui-source.h (struct tui_source_window)
 981         <erase_source_content>: New method.
 982         * tui/tui-disasm.h (struct tui_disasm_window)
 983         <erase_source_content>: New method.
 984
 985 2019-08-15  Tom Tromey  <tom@tromey.com>
 986
 987         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 988         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 989         constructor.
 990         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 991         * tui/tui-source.c (tui_set_source_content): Update.
 992         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 993
 994 2019-08-15  Tom Tromey  <tom@tromey.com>
 995
 996         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 997         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 998         tui-source.c.
 999         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1000         Declare.
1001         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1002         method.
1003         (tui_source_window::maybe_update): Update.
1004
1005 2019-08-15  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1008         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1009         tui-disasm.c.
1010         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1011         Declare.
1012         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1013         method.
1014         (tui_disasm_window::maybe_update): Update.
1015
1016 2019-08-15  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-winsource.h (struct tui_source_window_base)
1019         <maybe_update>: Declare.
1020         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1021         method.
1022         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1023         Declare.
1024         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1025         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1026         Declare.
1027         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1028
1029 2019-08-15  Tom Tromey  <tom@tromey.com>
1030
1031         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1032
1033 2019-08-15  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-wingeneral.c: Include tui-stack.h.
1036         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1037         (struct tui_locator_window): Move from tui-data.h.
1038         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1039         (tui_initialize_static_data): Move from tui-data.c.
1040         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1041         (struct tui_locator_window): Move to tui-stack.c.
1042         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1043         (tui_initialize_static_data): Move to tui-stack.c.
1044
1045 2019-08-15  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-layout.c (show_source_disasm_command)
1048         (show_source_or_disasm_and_command): Use make_visible method, not
1049         tui_make_window.
1050         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1051         Remove.
1052
1053 2019-08-15  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-wingeneral.h (tui_make_window): Update.
1056         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1057         parameter.
1058         (tui_gen_win_info::make_visible): Update.
1059         * tui/tui-regs.c (tui_data_window::display_registers_from):
1060         Update.
1061         * tui/tui-layout.c (show_source_disasm_command)
1062         (show_source_or_disasm_and_command): Update.
1063         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1064         (enum tui_box): Remove.
1065         (struct tui_win_info) <can_box>: New method.
1066         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1067         method.
1068
1069 2019-08-15  Tom de Vries  <tdevries@suse.de>
1070
1071         * linux-nat-trad.c: Include gdbarch.h.
1072
1073 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1074
1075         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1076         register sizes.
1077
1078 2019-08-14  Tom Tromey  <tromey@adacore.com>
1079
1080         * darwin-nat.c: Include gdbarch.h.
1081         * darwin-nat-info.c: Include gdbarch.h.
1082
1083 2019-08-13  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1086         Remove.
1087         * tui/tui-data.c (tui_initialize_static_data): Update.
1088
1089 2019-08-13  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-winsource.h (struct tui_exec_info_window)
1092         <~tui_exec_info_window, maybe_allocate_content, get_content,
1093         m_content>: Remove.
1094         (struct tui_source_window_base) <set_exec_info_content,
1095         show_exec_info_content>: Don't declare.
1096         * tui/tui-winsource.c
1097         (tui_exec_info_window::maybe_allocate_content): Remove.
1098         (tui_source_window_base::update_exec_info): Rename from
1099         set_exec_info_content.
1100         (tui_source_window_base::show_exec_info_content)
1101         (tui_source_window_base::update_exec_info): Remove.
1102
1103 2019-08-13  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1106         declare.
1107         * tui/tui-winsource.c (tui_update_source_window_as_is)
1108         (tui_update_source_windows_with_addr, tui_erase_source_content):
1109         Update.
1110         (tui_clear_exec_info_content): Remove.
1111
1112 2019-08-13  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1115         declare.
1116         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1117         call tui_erase_exec_info_content.
1118         (tui_clear_exec_info_content): Rename from
1119         tui_erase_exec_info_content.
1120         (tui_clear_exec_info_content): Delete.
1121
1122 2019-08-13  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-winsource.h (struct tui_source_window_base)
1125         <show_exec_info_content>: Declare.
1126         (tui_show_exec_info_content): Don't declare.
1127         * tui/tui-winsource.c
1128         (tui_source_window_base::show_exec_info_content): Rename from
1129         tui_show_exec_info_content.
1130         (tui_source_window_base::update_exec_info): Update.
1131
1132 2019-08-13  Tom Tromey  <tom@tromey.com>
1133
1134         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1135         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1136         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1137         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1138         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1139         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1140         ... here.
1141
1142 2019-08-13  Tom Tromey  <tom@tromey.com>
1143
1144         * tui/tui-winsource.h (struct tui_source_window_base)
1145         <update_exec_info>: Declare.
1146         (tui_update_exec_info): Don't declare.
1147         * tui/tui-winsource.c (tui_update_source_window_as_is)
1148         (tui_source_window_base::refresh_all)
1149         (tui_update_all_breakpoint_info): Update.
1150         (tui_source_window_base::update_exec_info): Rename from
1151         tui_update_exec_info.
1152         * tui/tui-stack.c (tui_show_frame_info): Update.
1153
1154 2019-08-13  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-winsource.h (struct tui_source_window_base)
1157         <set_exec_info_content>: Declare.
1158         (tui_set_exec_info_content): Don't declare.
1159         * tui/tui-winsource.c
1160         (tui_source_window_base::set_exec_info_content): Rename from
1161         tui_set_exec_info_content.
1162         (tui_update_exec_info): Update.
1163
1164 2019-08-13  Tom Tromey  <tom@tromey.com>
1165
1166         * tui/tui-winsource.h (struct tui_source_window_base)
1167         <show_source_content>: Declare.
1168         (tui_show_source_content): Don't declare.
1169         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1170         (tui_source_window_base::show_source_content): Rename from
1171         tui_show_source_content.
1172         (tui_source_window_base::refresh_all): Update.
1173         * tui/tui-layout.c (show_source_disasm_command)
1174         (show_source_or_disasm_and_command): Update.
1175
1176 2019-08-13  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-winsource.c (tui_erase_source_content)
1179         (tui_show_source_content, tui_source_window_base::refresh_all):
1180         Update.
1181         * tui/tui-wingeneral.h
1182         (tui_check_and_display_highlight_if_needed): Don't declare.
1183         * tui/tui-wingeneral.c
1184         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1185         check_and_display_highlight_if_needed.
1186         * tui/tui-win.c (tui_rehighlight_all)
1187         (tui_win_info::make_visible_with_new_height): Update.
1188         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1189         (tui_data_window::erase_data_content)
1190         (tui_data_window::display_all_data): Update.
1191         * tui/tui-data.h (struct tui_win_info)
1192         <check_and_display_highlight_if_needed>: Declare.
1193
1194 2019-08-13  Tom Tromey  <tom@tromey.com>
1195
1196         * tui/tui-win.c (tui_resize_all): Call
1197         tui_delete_invisible_windows.
1198         * tui/tui-layout.c (show_layout): Call
1199         tui_delete_invisible_windows.
1200         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1201         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1202
1203 2019-08-13  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1206         tui_add_win_to_layout.
1207
1208 2019-08-13  Tom Tromey  <tom@tromey.com>
1209
1210         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1211         * tui/tui-layout.c (tui_default_win_height): Now static.
1212
1213 2019-08-13  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1216         single switch.
1217         (show_source_disasm_command, show_source_or_disasm_and_command):
1218         Don't check current layout.
1219
1220 2019-08-13  Tom Tromey  <tom@tromey.com>
1221
1222         * tui/tui-wingeneral.c (make_all_visible): Remove.
1223         (tui_make_all_invisible): Simplify.
1224         * tui/tui-layout.c (tui_make_all_invisible): Move from
1225         tui-wingeneral.c; simplify.
1226         (show_layout): Hoist call to tui_make_all_invisible.
1227         (show_data): Don't call tui_make_all_invisible.
1228
1229 2019-08-13  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1232         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1233
1234 2019-08-13  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1237         tui-data.c.
1238         (show_source_disasm_command, show_data)
1239         (show_source_or_disasm_and_command): Don't use
1240         tui_set_current_layout_to.
1241         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1242         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1243         tui-layout.c.
1244         (tui_set_current_layout_to): Remove.
1245
1246 2019-08-13  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-layout.c (tui_set_layout): Update.
1249         * tui/tui-data.h (struct tui_layout_def): Remove.
1250         (tui_layout_def): Don't declare.
1251         * tui/tui-data.c (layout_def): Remove.
1252         (tui_layout_def): Remove.
1253
1254 2019-08-13  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui-winsource.h (struct tui_source_window_base)
1257         <clear_detail>: No longer "override".
1258         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1259         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1260         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1261         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1262         Remove.
1263         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1264
1265 2019-08-13  Tom Tromey  <tromey@adacore.com>
1266
1267         * tracepoint.c: Don't include readline.h or history.h.
1268
1269 2019-08-12  Tom Tromey  <tom@tromey.com>
1270
1271         * configure: Rebuild.
1272         * configure.ac: Check for readline 7.
1273         * NEWS: Mention readline 7 requirement.
1274         * README: Update.
1275
1276 2019-08-12  Tom Tromey  <tom@tromey.com>
1277
1278         * mingw-hdep.c (gdb_select): Remove readline hack.
1279
1280 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1281
1282         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1283         when the function fails.
1284
1285 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1286
1287         * s390-tdep.c (s390_type_align): New function.
1288         (s390_gdbarch_init): Set it as type_align gdbarch method.
1289
1290 2019-08-09  Tom de Vries  <tdevries@suse.de>
1291
1292         PR gdb/24591
1293         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1294         pc_low with relocation offset.
1295
1296 2019-08-07  Tom Tromey  <tromey@adacore.com>
1297
1298         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1299         (print_frame_args): Update.
1300         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1301         Update.
1302         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1303         * frame.h (struct frame_arg): Add initializers.
1304         <error>: Now a unique_xmalloc_ptr.
1305
1306 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1307
1308         * NEWS: Expand the Pointer Authentication entry.
1309         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1310         (aarch64_frame_unmask_lr): ... to this.
1311         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1312         Call aarch64_frame_unmask_lr.
1313         * frame.c (struct frame_info): Add "masked" variable.
1314         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1315         (fprint_frame): Check for masked pc.
1316         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1317         declarations.
1318         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1319         * stack.c (print_frame): Check for masked pc.
1320
1321 2019-08-06  Tom Tromey  <tom@tromey.com>
1322
1323         * stabsread.c (patch_block_stabs, read_one_struct_field)
1324         (read_enum_type): Use obstack_strndup.
1325         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1326         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1327         * dwarf2read.c (guess_full_die_structure_name)
1328         (anonymous_struct_prefix): Use obstack_strndup.
1329         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1330         * c-exp.y (yylex): Use obstack_strndup.
1331         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1332         (write_var_or_type): Use obstack_strndup.
1333
1334 2019-08-06  Tom Tromey  <tom@tromey.com>
1335
1336         * symfile.c (reread_symbols): Use obstack_strdup.
1337         * stabsread.c (read_type): Use obstack_strdup.
1338         * gdb_obstack.h (obstack_strdup): New overload.
1339         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1340         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1341         (dwarf2_canonicalize_name): Use obstack_strdup.
1342         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1343         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1344         Use obstack_strdup.
1345
1346 2019-08-06  Tom Tromey  <tom@tromey.com>
1347
1348         * gdb_obstack.h (obstack_strdup): Define.
1349         * gdb_obstack.c (obstack_strdup): Don't define.
1350
1351 2019-08-06  Tom Tromey  <tom@tromey.com>
1352
1353         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1354         obstack_strdup.
1355         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1356         obstack_strdup.
1357         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1358         * stabsread.c (common_block_start): Use obstack_strdup.
1359         * objfiles.c (set_objfile_main_name, objfile): Use
1360         obstack_strdup.
1361         * namespace.c (add_using_directive): Use obstack_strdup.
1362         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1363         * jit.c (finalize_symtab): Use obstack_strdup.
1364         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1365         (guess_partial_die_structure_name, partial_die_info::fixup)
1366         (dwarf2_name): Use obstack_strdup.
1367         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1368         obstack_strdup.
1369         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1370         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1371         obstack_strdup.
1372         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1373
1374 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1375
1376         * unittests/help-doc-selftests.c: New file.
1377         * Makefile.in: Add the new file.
1378
1379 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1380
1381         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1382         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1383         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1384         the trailing '.' is not output, and the first character is uppercased.
1385         (print_help_for_command): Update call to print_doc_line.
1386         (print_doc_of_command): Likewise.
1387         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1388         * cli/cli-option.c (append_indented_doc): Do not append newline.
1389         (build_help_option): Append newline after first appended_indented_doc
1390         only if a second call is done.
1391         (build_help): Append 2 new lines before each option, except the first
1392         one.
1393         * compile/compile.c (_initialize_compile): Add new lines after
1394         %OPTIONS%, when not at the end of the help.
1395         Change help doc or code
1396         producing the help doc to respect the invariants.
1397         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1398         Also removed the new line after 'Options:', as all other commands
1399         do not put an empty line between 'Options:' and the first option.
1400         * printcmd.c (_initialize_printcmd): Likewise.
1401         * stack.c (_initialize_stack): Likewise.
1402         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1403         incorrectly telling COMMAND is optional.
1404         * ada-lang.c (_initialize_ada_language): Change help doc or code
1405         producing the help doc to respect the invariants.
1406         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1407         * breakpoint.c (_initialize_breakpoint): Likewise.
1408         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1409         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1410         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1411         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1412         _initialize_cli_style): Likewise.
1413         * corelow.c (core_target_info): Likewise.
1414         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1415         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1416         * filesystem.c (_initialize_filesystem): Likewise.
1417         * frame.c (_initialize_frame): Likewise.
1418         * gnu-nat.c (add_task_commands): Likewise.
1419         * infcall.c (_initialize_infcall): Likewise.
1420         * infcmd.c (_initialize_infcmd): Likewise.
1421         * interps.c (_initialize_interpreter): Likewise.
1422         * language.c (_initialize_language): Likewise.
1423         * linux-fork.c (_initialize_linux_fork): Likewise.
1424         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1425         * maint.c (_initialize_maint_cmds): Likewise.
1426         * memattr.c (_initialize_mem): Likewise.
1427         * printcmd.c (_initialize_printcmd): Likewise.
1428         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1429         _RegEx): Likewise.
1430         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1431         * record-btrace.c (_initialize_record_btrace): Likewise.
1432         * record-full.c (_initialize_record_full): Likewise.
1433         * record.c (_initialize_record): Likewise.
1434         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1435         * regcache.c (_initialize_regcache): Likewise.
1436         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1437         _initialize_remote): Likewise.
1438         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1439         * serial.c (_initialize_serial): Likewise.
1440         * skip.c (_initialize_step_skip): Likewise.
1441         * source.c (_initialize_source): Likewise.
1442         * stack.c (_initialize_stack): Likewise.
1443         * symfile.c (_initialize_symfile): Likewise.
1444         * symtab.c (_initialize_symtab): Likewise.
1445         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1446         * top.c (init_main): Likewise.
1447         * tracefile-tfile.c (tfile_target_info): Likewise.
1448         * tracepoint.c (_initialize_tracepoint): Likewise.
1449         * tui/tui-win.c (_initialize_tui_win): Likewise.
1450         * utils.c (add_internal_problem_command): Likewise.
1451         * valprint.c (value_print_option_defs): Likewise.
1452
1453 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1454
1455         PR build/24886
1456         * configure.ac: Drop enable-libmcheck support.
1457         * configure, config.in: Rebuild.
1458         * libmcheck.m4: Remove.
1459         * acinclude.m4: Don't include it.
1460         * Makefile.in: Don't distribute it.
1461         * top.c (print_gdb_configuration): Don't mention it.
1462
1463 2019-08-06  Tom Tromey  <tom@tromey.com>
1464
1465         * utils.c (set_output_style): Sometimes pass stream to
1466         emit_style_escape.
1467         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1468         * record-btrace.c (btrace_insn_history): Update.
1469         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1470         method.
1471         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1472         Update initializers.
1473         <m_uiout>: New field.
1474         <m_di>: Move lower.
1475         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1476         Remove "uiout" parameter.
1477         (dump_insns): Update.
1478         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1479         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1480
1481 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1482
1483         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1484         (error_in_psymtab_expansion): Likewise.
1485         (lookup_symbol_via_quick_fns): Likewise.
1486         (basic_lookup_transparent_type_quick): Likewise.
1487         (basic_lookup_transparent_type_1): Likewise.
1488
1489 2019-08-06  Tom Tromey  <tromey@adacore.com>
1490
1491         * source.c (last_source_error): Now bool.
1492         (print_source_lines_base): Make "noprint" bool.  Only open
1493         source file when last_source_visited changes.
1494
1495 2019-08-06  Tom Tromey  <tromey@adacore.com>
1496
1497         * annotate.c (annotate_source_line): Use g_source_cache.
1498         * source-cache.c (source_cache::get_plain_source_lines): Change
1499         parameters.  Populate m_offset_cache.
1500         (source_cache::ensure): New method.
1501         (source_cache::get_line_charpos): New method.
1502         (extract_lines): Move lower.  Change parameters.
1503         (source_cache::get_source_lines): Move lower.
1504         * source-cache.h (class source_cache): Update comment.
1505         <get_line_charpos>: New method.
1506         <get_source_lines>: Update comment.
1507         <clear>: Clear m_offset_cache.
1508         <get_plain_source_lines>: Change parameters.
1509         <ensure>: New method
1510         <m_offset_cache>: New member.
1511         * source.c (forget_cached_source_info_for_objfile): Update.
1512         (info_source_command): Use g_source_cache.
1513         (find_source_lines, open_source_file_with_line_charpos): Remove.
1514         (print_source_lines_base, search_command_helper): Use g_source_cache.
1515         * source.h (open_source_file_with_line_charpos): Don't declare.
1516         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1517         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1518         Use g_source_cache.
1519
1520 2019-08-06  Tom Tromey  <tromey@adacore.com>
1521
1522         * source-cache.c (source_cache::get_plain_source_lines):
1523         Remove "first_line" and "last_line" parameters.
1524         (source_cache::get_source_lines): Cache plain text.
1525         * source-cache.h (class source_cache)
1526         <get_plain_source_lines>: Update.
1527
1528 2019-08-06  Tom Tromey  <tromey@adacore.com>
1529
1530         * source-cache.c (extract_lines): No longer a method.
1531         Changed type of parameter.  Include final newline.
1532         (selftests::extract_lines_test): New function.
1533         (_initialize_source_cache): Likewise.
1534         * source-cache.h (class source_cache)
1535         <extract_lines>: Don't declare.
1536
1537 2019-08-06  Tom Tromey  <tromey@adacore.com>
1538
1539         * breakpoint.c (init_breakpoint_sal): Update.
1540         (breakpoint): Update.
1541         * breakpoint.h (struct breakpoint) <filter>: Now a
1542         unique_xmalloc_ptr.
1543
1544 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1545
1546         * NEWS: Mention dictionary access on blocks.
1547         * python/py-block.c (blpy_getitem): New function.
1548         (block_object_as_mapping): New struct.
1549         (block_object_type): Use new struct for tp_as_mapping field.
1550
1551 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1552
1553         * objfiles.h (objfile): Add a comment describing partial symbols.
1554
1555 2019-08-05  Tom Tromey  <tromey@adacore.com>
1556
1557         * compile/compile.c (_initialize_compile): Use _(), not N_().
1558         * thread.c (_initialize_thread): Use _(), not N_().
1559         * stack.c (_initialize_stack): Use _(), not N_().
1560         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1561
1562 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1563
1564         * dwarf2read.c (struct dw2_symtab_iterator):
1565         <want_specific_block>: Remove.
1566         <block_index>: Change type to gdb::optional.
1567         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1568         change type of BLOCK_INDEX parameter to gdb::optional.
1569         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1570         (dw2_lookup_symbol): Don't pass argument for
1571         WANT_SPECIFIC_BLOCK.
1572         (dw2_expand_symtabs_for_function): Don't pass argument for
1573         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1574         (class dw2_debug_names_iterator)
1575         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1576         parameter, change BLOCK_INDEX type to gdb::optional.
1577         <m_want_specific_block>: Remove.
1578         <m_block_index>: Change type to gdb::optional.
1579         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1580         gdb::optional.  Re-write in function of gdb::optional.
1581         (dw2_debug_names_lookup_symbol): Don't pass argument for
1582         WANT_SPECIFIC_BLOCK.
1583         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1584         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1585         BLOCK_INDEX.
1586
1587 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1588
1589         * NEWS: Mention changes to "info sources" command.
1590
1591 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1592
1593         * symtab.c (filename_partial_match_opts): New struct type.
1594         (struct output_source_filename_data): New members
1595         regexp, c_regexp, partial_match.
1596         (output_source_filename): Use new members to decide to print file.
1597         (info_sources_option_defs): New variable.
1598         (make_info_sources_options_def_group, print_info_sources_header,
1599         info_sources_command_completer):
1600         New functions.
1601         (info_sources_command): Read new optional arguments.
1602         (_initialize_symtab): Update info sources help.
1603
1604 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1605
1606         * ada-lang.c (exception_support_info_v0): Renamed from...
1607         (default_exception_support_info): ... this.  Create new
1608         definition for v1.
1609         (ada_has_this_exception_support): Look up catch_handlers_sym.
1610         (ada_exception_support_info_sniffer): Try v0 after default.
1611
1612 2019-08-01  Tom Tromey  <tromey@adacore.com>
1613
1614         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1615         gdbarch.h.
1616
1617 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1618
1619         * s12z-tdep.c: Fix include path for s12z-opc.h.
1620
1621 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1622
1623         * NEWS: Require GNU make 3.82.
1624
1625 2019-07-16  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1628         declare.
1629
1630 2019-07-30  Tom Tromey  <tromey@adacore.com>
1631
1632         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1633
1634 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1635
1636         * printcmd.c (print_address_symbolic): Print negative offsets.
1637         (build_address_symbolic): Force signed arithmetic when computing
1638         offset.
1639
1640 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1641
1642         PR/24474: Add a function to lookup static variables.
1643         * NEWS: Mention this new function.
1644         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1645         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1646         * python/python.c (python_GdbMethods): Add new function.
1647
1648 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1649
1650         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1651         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1652         (objfpy_lookup_static_symbol): New function.
1653         (objfile_object_methods): Add new functions.
1654
1655 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1656
1657         * NEWS: Mention 'set|show print frame-info'.  Mention new
1658         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1659         backtrace argument.  Mention that python frame filtering code
1660         is now consistent with what 'backtrace' command prints.
1661
1662 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1663
1664         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1665         comments.
1666         (print_frame_info_auto, print_frame_info_source_line,
1667         print_frame_info_location, print_frame_info_source_and_location,
1668         print_frame_info_location_and_address, print_frame_info_short_location):
1669         New declarations.
1670         (struct frame_print_options): New member print_frame_info.
1671         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1672         * stack.h (get_user_print_what_frame_info): New declaration.
1673         (frame_show_address): New declaration.
1674         * stack.c (print_frame_arguments_choices): New value 'presence'.
1675         (print_frame_info_auto, print_frame_info_source_line,
1676         print_frame_info_location, print_frame_info_source_and_location,
1677         print_frame_info_location_and_address, print_frame_info_short_location,
1678         print_frame_info_choices, print_frame_info_print_what): New definitions.
1679         (print_frame_args): Only print dots for args if print frame-arguments
1680         is 'presence'.
1681         (frame_print_option_defs): New element for "frame-info".
1682         (get_user_print_what_frame_info): New function.
1683         (frame_show_address): Make non static.  Move comment to stack.h.
1684         (print_frame_info_to_print_what): New function.
1685         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1686         to decide what to print.
1687         (backtrace_command_1): Handle the new print_frame_arguments_presence
1688         value.
1689         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1690         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1691         (py_print_frame): In non-mi mode, use LOCATION as default for
1692         print_what, similarly to frame information printed directly by
1693         backtrace command. Handle frame-info user option in non MI mode.
1694
1695 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1696
1697         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1698         Add case for debugging 32-bit target on 64-bit host.  Revise
1699         comment.
1700
1701 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1702
1703         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1704         instead of find_function_entry_range_from_pc.
1705
1706 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1707
1708         * stack.c (find_frame_funname): Remove code which preferred
1709         minsym over symtab sym in "certain pathological cases".
1710
1711         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1712         parameter.  Change type of "do_demangle" to bool.
1713         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1714         Pass suitable "prefer_sym_over_minsym" flag to
1715         build_address_symbolic().  Don't output "+" for negative offsets.
1716         * printcmd.c (print_address_symbolic): Update invocation of
1717         build_address_symbolic to include a "prefer_sym_over_minsym"
1718         flag.
1719         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1720         Restrict cases in which use of minimal symbol is preferred to that
1721         of a found symbol.  Update comments.
1722
1723         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1724         for entry pc when entry pc is out of range for that FDE.
1725
1726 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1727
1728         PR gdb/24839:
1729         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1730         type.
1731
1732 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1733
1734         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1735         this function's Python signature.
1736
1737
1738 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1739
1740         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1741         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1742         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1743         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1744         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1745
1746
1747 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1748
1749         * h8300-tdep.c (h8300_register_name_common): New.
1750         h8300_register_name): Use h8300_register_name_common.
1751         (h8300s_register_name): Likewise.
1752         (h8300sx_register_name): Likewise.
1753         (h8300h_register_nam): New.
1754         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1755
1756
1757 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1758
1759         * arm-tdep.c (arm_skip_cmse_entry): New function.
1760         (arm_is_sgstubs_section): New function.
1761         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1762
1763 2019-07-22  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1766         Don't self-assign.
1767
1768 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1771         type_print.
1772
1773 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1776         so that GDB doesn't match any msymbols when searching in the
1777         TYPES_DOMAIN.
1778         (print_symbol_info): Print using typedef_print or type_print based
1779         on the type of the symbol.  Add updated FIXME comment moved from...
1780         (_initialize_symtab): ... move and update FIXME comment to above.
1781
1782 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1783
1784         * NEWS: Mention adding -q option to "info types".
1785         * symtab.c (struct info_types_options): New struct.
1786         (info_types_options_defs): New variable.
1787         (make_info_types_options_def_group): New function.
1788         (info_types_command): Use gdb::option framework to parse options.
1789         (info_types_command_completer): New function.
1790         (_initialize_symtab): Extend the help text on "info types" and
1791         register command completer.
1792
1793 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1794
1795         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1796         (lookup_symbol_in_objfile): Change int to block_enum and add a
1797         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1798
1799 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1800
1801         * MAINTAINERS (Write After Approval): Add self.
1802
1803 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1804
1805         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1806         instruction to the dummy code region.
1807
1808 2019-07-19  Tom Tromey  <tromey@adacore.com>
1809
1810         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1811         (ARGSUSED, PARAMS, __func__): Remove rules.
1812
1813 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1814
1815         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1816         * features/arm/arm-with-iwmmxt.c: Remove.
1817         * features/arm/arm-with-iwmmxt.xml: Remove.
1818         * features/arm/arm-with-m-fpa-layout.c: Remove.
1819         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1820         * features/arm/arm-with-m-vfp-d16.c: Remove.
1821         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1822         * features/arm/arm-with-m.c: Remove.
1823         * features/arm/arm-with-m.xml: Remove.
1824         * features/arm/arm-with-neon.c: Remove.
1825         * features/arm/arm-with-neon.xml: Remove.
1826         * features/arm/arm-with-vfpv2.c: Remove.
1827         * features/arm/arm-with-vfpv2.xml: Remove.
1828         * features/arm/arm-with-vfpv3.c: Remove.
1829         * features/arm/arm-with-vfpv3.xml: Remove.
1830
1831 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1832
1833         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1834
1835 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1836
1837         * arch/aarch32.c (aarch32_create_target_description): Create
1838         target descriptions using features.
1839         * arch/arm.c (arm_create_target_description)
1840         (arm_create_mprofile_target_description): Likewise.
1841         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1842
1843 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1844
1845         * Makefile.in: Add new files.
1846         * aarch32-tdep.c: New file.
1847         * aarch32-tdep.h: New file.
1848         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1849         Call aarch32_read_description.
1850         * arch/aarch32.c: New file.
1851         * arch/aarch32.h: New file.
1852         * arch/arm.c (arm_create_target_description)
1853         (arm_create_mprofile_target_description): New function.
1854         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1855         (arm_create_target_description)
1856         (arm_create_mprofile_target_description): New declaration.
1857         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1858         read_description functions.
1859         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1860         Likewise.
1861         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1862         * arm-tdep.c (tdesc_arm_list): New variable.
1863         (arm_register_g_packet_guesses): Call create description functions.
1864         (arm_read_description) (arm_read_mprofile_description): New
1865         function.
1866         * arm-tdep.h (arm_read_description)
1867         (arm_read_mprofile_description): Add declaration.
1868         * configure.tgt: Add new files.
1869
1870 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1871
1872         * top.c (new_ui_command): Open specified terminal just once.
1873
1874 2019-07-18  Tom Tromey  <tromey@adacore.com>
1875
1876         * symtab.c (main_name): Constify return type.
1877         * symfile.c (set_initial_language): Update.
1878         * symtab.h (main_name): Constify return type.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-winsource.c (tui_update_source_window)
1883         (tui_update_source_window_as_is)
1884         (tui_update_source_windows_with_line): Remove return.
1885         * tui/tui-disasm.c (tui_show_disassem)
1886         (tui_show_disassem_and_update_source): Remove return.
1887         * tui/tui.c (tui_reset): Remove return.
1888         * tui/tui-wingeneral.c
1889         (tui_check_and_display_highlight_if_needed): Remove return.
1890
1891 2019-07-17  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1894
1895 2019-07-17  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-winsource.h (struct tui_exec_info_window)
1898         (struct tui_source_window_base): Move from tui-data.h.
1899         * tui/tui-winsource.c: Move many method definitions from
1900         elsewhere.  Remove "structuring" comments.
1901         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1902         (tui_source_window_base::refresh_window): Move to
1903         tui-winsource.c.
1904         * tui/tui-win.c (tui_source_window_base::refresh_all)
1905         (tui_source_window_base::update_tab_width)
1906         (tui_source_window_base::set_new_height)
1907         (tui_source_window_base::do_make_visible_with_new_height): Move to
1908         tui-winsource.c.
1909         * tui/tui-source.h: Update.
1910         * tui/tui-source.c (tui_source_window_base::reset): Move to
1911         tui-winsource.c.
1912         * tui/tui-disasm.h: Update.
1913         * tui/tui-data.h (struct tui_exec_info_window): Move to
1914         tui-winsource.h.
1915         (struct tui_source_window_base): Likewise.
1916         * tui/tui-data.c (tui_source_window_base::clear_detail)
1917         (tui_source_window_base, ~tui_source_window_base): Move to
1918         tui-winsource.c.
1919
1920 2019-07-17  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-win.c (tui_resize_all)
1923         (tui_source_window_base::update_tab_width)
1924         (tui_adjust_win_heights): Update.
1925         (tui_win_info::make_invisible_and_set_new_height): Rename from
1926         make_invisible_and_set_new_height.
1927         * tui/tui-data.h (struct tui_win_info)
1928         <make_invisible_and_set_new_height>: New method.
1929
1930 2019-07-17  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui.c: Update.
1933         * tui/tui-source.h (struct tui_source_window): Move from
1934         tui-data.h.
1935         * tui/tui-layout.c: Update.
1936         * tui/tui-disasm.c: Update.
1937         * tui/tui-data.h (struct tui_source_window): Move to
1938         tui-source.h.
1939
1940 2019-07-17  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1943         tui-data.h.
1944         * tui/tui-data.h (struct tui_disasm_window): Move to
1945         tui-disasm.h.
1946
1947 2019-07-17  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-regs.h (struct tui_data_item_window): Move from
1950         tui-data.h.
1951         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1952         * tui/tui-data.h (struct tui_data_item_window): Move to
1953         tui-regs.h.
1954         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1955
1956 2019-07-17  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui.c: Update.
1959         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1960         (tui_cmd_window::max_height): Move to tui-command.c.
1961         * tui/tui-layout.c: Update.
1962         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1963         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1964         tui-command.c.
1965         * tui/tui-command.h (struct tui_cmd_window): Move from
1966         tui-data.h.
1967         * tui/tui-command.c: Remove "structuring" comments.
1968         (tui_cmd_window::clear_detail)
1969         (tui_cmd_window::do_make_visible_with_new_height)
1970         (tui_cmd_window::max_height): Move from elsewhere.
1971
1972 2019-07-17  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1975         Now static.
1976         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1977         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1978
1979 2019-07-17  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui.c: Update.
1982         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1983         tui-regs.c.
1984         * tui/tui-windata.h: Remove file.
1985         * tui/tui-windata.c: Remove file.
1986         * tui/tui-win.c (tui_data_window::set_new_height)
1987         (tui_data_window::do_make_visible_with_new_height): Move to
1988         tui-regs.c.
1989         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1990         * tui/tui-regs.c: Remove "structuring" comments.
1991         (tui_data_window::first_data_item_displayed)
1992         (tui_data_window::delete_data_content_windows)
1993         (tui_data_window::erase_data_content)
1994         (tui_data_window::display_all_data)
1995         (tui_data_window::refresh_all)
1996         (tui_data_window::do_scroll_vertical)
1997         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1998         (tui_data_window::do_make_visible_with_new_height)
1999         (tui_data_window::refresh_window): Move from elsewhere.
2000         (_initialize_tui_regs): Move to end of file.
2001         * tui/tui-layout.c: Update.
2002         * tui/tui-hooks.c: Update.
2003         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2004         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2005         tui-regs.c.
2006         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2007
2008 2019-07-17  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2011         seen.
2012
2013 2019-07-17  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-win.c (tui_source_window_base::set_new_height)
2016         (tui_source_window_base::do_make_visible_with_new_height): Use
2017         m_has_locator field directly.
2018         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2019         method.
2020         (struct tui_source_window_base) <has_locator>: Likewise.
2021
2022 2019-07-17  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2025         Don't declare.
2026         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2027         Remove.
2028         * tui/tui-win.c (tui_source_window_base::set_new_height)
2029         (tui_source_window_base::set_new_height)
2030         (make_invisible_and_set_new_height)
2031         (tui_source_window_base::do_make_visible_with_new_height)
2032         (tui_source_window_base::do_make_visible_with_new_height):
2033         Update.
2034         * tui/tui-layout.c (show_source_disasm_command, show_data)
2035         (show_source_or_disasm_and_command): Update.
2036         * tui/tui-layout.c (show_layout): Update.
2037
2038 2019-07-17  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-layout.c (make_data_window): Remove.
2041         (show_data): Unify creation and re-initialization cases.
2042
2043 2019-07-17  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-layout.c (make_source_window, make_disasm_window):
2046         Remove.
2047         (show_data): Unify creation and re-initialization cases.
2048
2049 2019-07-17  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-layout.c (make_command_window): Remove.
2052         (show_source_disasm_command, show_source_or_disasm_and_command):
2053         Unify creation and re-initialization cases.
2054
2055 2019-07-17  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2058         creation and re-initialization cases.
2059
2060 2019-07-17  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-regs.c (tui_get_register): Return void.
2063
2064 2019-07-17  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2067         Simplify.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2072         resetting.
2073
2074 2019-07-17  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2077         * tui/tui-regs.c (tui_reg_layout): New function.
2078         (tui_show_registers, tui_reg_command): Use it.
2079         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2080         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2081         parameters.
2082         (tui_layout_command): Remove.
2083
2084 2019-07-17  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-layout.h (tui/tui-layout): Return void.
2087         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2088
2089 2019-07-17  Tom Tromey  <tom@tromey.com>
2090
2091         * tui/tui-layout.c (show_source_disasm_command, show_data):
2092         Update.
2093         (reset_locator): Remove.
2094         (show_source_or_disasm_and_command): Update.
2095
2096 2019-07-17  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-source.c (tui_source_window_base::reset): Remove
2099         win_type parameter.
2100         * tui/tui-layout.c (make_command_window, make_source_window)
2101         (make_disasm_window, make_data_window)
2102         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2103         (reset_locator, show_source_or_disasm_and_command): Update.
2104         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2105         win_type parameter.
2106         (struct tui_source_window_base) <reset>: Likewise.
2107
2108 2019-07-17  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-layout.c (show_source_disasm_command): Use
2111         reset_locator.
2112         (reset_locator): New function.
2113         (init_and_make_win): Remove.
2114         (show_source_or_disasm_and_command): Use reset_locator.
2115
2116 2019-07-17  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2119         condition.
2120         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2121         Remove condition.
2122         * tui/tui-source.c (tui_source_window_base::reset): New method.
2123         * tui/tui-layout.c (make_command_window): Don't call
2124         init_and_make_win.
2125         (make_source_window, make_disasm_window): Don't call
2126         make_source_or_disasm_window.
2127         (make_data_window): Don't call init_and_make_win.  Change calling
2128         convention.
2129         (show_source_disasm_command, show_data): Simplify.
2130         (make_source_or_disasm_window): Remove.
2131         (show_source_or_disasm_and_command): Simplify.
2132         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2133         (struct tui_source_window_base) <reset>: Likewise.
2134         <execution_info>: Remove initializer.
2135         * tui/tui-data.c (tui_source_window_base): Initialize
2136         execution_info.
2137
2138 2019-07-17  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2141         variable.
2142
2143 2019-07-17  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui.c (tui_rl_other_window): Update.
2146         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2147         superclass method first.  Always iterate over regs_content.
2148         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2149         method.
2150         * tui/tui-win.c (tui_set_focus_command): Update.
2151
2152 2019-07-17  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-win.c (tui_set_focus_command): Rename from
2155         tui_set_focus.  Call tui_enable.
2156         (tui_set_focus_command): Remove.
2157
2158 2019-07-17  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2161         refresh_window.
2162         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2163         touchwin.
2164         (tui_data_window::refresh_window): Call refresh_window on data
2165         items.  Always call superclass refresh_window.
2166         (tui_win_info::refresh): Remove.
2167         (tui_source_window_base::refresh_window): Update.
2168         (tui_refresh_all): Update.
2169         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2170         refresh_window.
2171         (show_source_or_disasm_and_command): Likewise.
2172         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2173         (struct tui_source_window_base) <refresh>: Likewise.
2174
2175 2019-07-17  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-winsource.c (tui_clear_source_content)
2178         (tui_show_source_content): Update.
2179         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2180         whether content is empty.
2181         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2182         Remove.
2183
2184 2019-07-17  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2187         window's contents.
2188         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2189         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2190
2191 2019-07-17  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2194         (struct tui_data_item_window): Update.
2195
2196 2019-07-17  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2199         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2200         defines.
2201
2202 2019-07-17  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-winsource.h (tui_erase_source_content)
2205         (tui_clear_source_content): Remove "display_prompt" parameter.
2206         * tui/tui-winsource.c (tui_update_source_window_as_is)
2207         (tui_update_source_windows_with_addr): Update.
2208         (tui_clear_source_content): Remove "display_prompt" parameter.
2209         (tui_erase_source_content): Likewise.  Simplify.
2210         (tui_show_source_content): Update.
2211         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2212         * tui/tui-stack.c (tui_show_frame_info): Update.
2213         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2214         Remove defines.
2215
2216 2019-07-17  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2219         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2220         parameter.
2221         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2222         parameter.
2223
2224 2019-07-17  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-winsource.c (tui_clear_source_content)
2227         (tui_show_source_content, tui_show_exec_info_content)
2228         (tui_clear_exec_info_content): Update.
2229         * tui/tui-stack.c (tui_show_locator_content): Update.
2230         (tui_show_frame_info): Update.
2231         * tui/tui-source.h (tui_source_window): Don't declare.
2232         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2233         from tui_source_is_displayed.
2234         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2235         Remove field.
2236         (struct tui_source_window_base) <content_in_use>: New field.  Now
2237         bool.
2238         (struct tui_source_window) <showing_source_p>: New method.
2239         (TUI_SRC_WIN): Change cast.
2240         * tui/tui-data.c (tui_initialize_static_data): Update.
2241
2242 2019-07-17  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2245         location_matches_p.
2246         * tui/tui-source.c (tui_source_window::location_matches_p): New
2247         method.
2248         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2249         method.
2250         * tui/tui-data.h (struct tui_source_window_base)
2251         <location_matches_p>: New method.
2252         (struct tui_source_window, struct tui_disasm_window)
2253         <location_matches_p>: Likewise.
2254
2255 2019-07-17  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-win.c (tui_set_win_height_command): Rename from
2258         tui_set_win_height.
2259         (tui_set_win_height_command): Remove.
2260
2261 2019-07-17  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-source.c (tui_source_window): New constructor.  Add
2264         observer.
2265         (~tui_source_window): New destructor.
2266         (tui_source_window::style_changed): New method.
2267         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2268         (tui_attach_detach_observers): Update.
2269         * tui/tui-data.h (struct tui_source_window): Make constructor not
2270         inline.  Add destructor.
2271         (struct tui_source_window) <style_changed>: New method.
2272         <m_observable>: New member.
2273
2274 2019-07-17  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2277         * tui/tui-win.c (tui_resize_all): Fix typo.
2278
2279 2019-07-17  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2282         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2283         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2284         * tui/tui-win.c (window_name_completer): Use foreach.
2285         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2286         (update_tab_width): Likewise.
2287         * tui/tui-layout.c (show_layout): Update.
2288         * tui/tui-data.h (class tui_window_iterator): New.
2289         (struct all_tui_windows): New.
2290         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2291
2292 2019-07-17  Tom Tromey  <tom@tromey.com>
2293
2294         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2295         parameter.  Don't reference globals.
2296         (tui_reg_command): Update.
2297
2298 2019-07-17  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-regs.c (tui_show_registers): Simplify.
2301
2302 2019-07-17  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-regs.c (tui_show_registers): Update.
2305         (tui_show_register_group): Add win_info parameter.
2306
2307 2019-07-17  Tom Tromey  <tom@tromey.com>
2308
2309         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2310         Rename from tui_display_reg_element_at_line.
2311         (tui_data_window::display_registers_from_line): Update.
2312         * tui/tui-data.h (struct tui_data_window)
2313         <display_reg_element_at_line>: New method.
2314
2315 2019-07-17  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-regs.h (tui_display_registers_from)
2318         (tui_display_registers_from_line): Don't declare.
2319         * tui/tui-windata.c (tui_data_window::display_all_data)
2320         (tui_data_window::refresh_all)
2321         (tui_data_window::do_scroll_vertical): Update.
2322         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2323         from tui_display_registers_from.
2324         (tui_display_reg_element_at_line): Update.
2325         (tui_data_window::display_registers_from_line): Rename from
2326         tui_display_registers_from_line.
2327         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2328         display_registers_from_line>: New methods.
2329
2330 2019-07-17  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2333         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2334         from tui_erase_data_content.
2335         (tui_data_window::display_all_data)
2336         (tui_data_window::refresh_all)
2337         (tui_data_window::do_scroll_vertical): Update.
2338         * tui/tui-regs.c (tui_show_registers): Update.
2339         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2340         New method.
2341
2342 2019-07-17  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2345         declare.
2346         * tui/tui-windata.c
2347         (tui_data_window::delete_data_content_windows): Rename from
2348         tui_delete_data_content_windows.
2349         (tui_data_window::display_all_data)
2350         (tui_data_window::do_scroll_vertical): Update.
2351         * tui/tui-data.h (struct tui_data_window)
2352         <delete_data_content_windows>: New method.
2353
2354 2019-07-17  Tom Tromey  <tom@tromey.com>
2355
2356         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2357         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2358
2359 2019-07-17  Tom Tromey  <tom@tromey.com>
2360
2361         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2362         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2363         from tui_display_all_data.
2364         * tui/tui-win.c
2365         (tui_data_window::do_make_visible_with_new_height): Update.
2366         * tui/tui-regs.c (tui_show_registers): Update.
2367         * tui/tui-layout.c (tui_set_layout): Update.
2368         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2369         method.
2370
2371 2019-07-17  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2374         * tui/tui-windata.c (tui_display_data_from): Remove.
2375         (tui_data_window::refresh_all): Update.
2376
2377 2019-07-17  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2380         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2381         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2382         tui_display_registers_from_line.
2383         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2384         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2385         "force_display" parameter.
2386
2387 2019-07-17  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2390         declare.
2391         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2392         Rename from tui_first_reg_element_no_inline.
2393         (tui_display_reg_element_at_line)
2394         (tui_display_registers_from_line): Update.
2395         * tui/tui-data.h (struct tui_data_window)
2396         <first_reg_element_no_inline>: New method.
2397
2398 2019-07-17  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-windata.c (tui_display_data_from)
2401         (tui_data_window::do_scroll_vertical): Update.
2402         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2403         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2404         Rename from tui_line_from_reg_element_no.
2405         (tui_display_registers_from_line): Update.
2406         * tui/tui-data.h (struct tui_data_window)
2407         <line_from_reg_element_no>: New method.
2408
2409 2019-07-17  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2412         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2413         tui_last_regs_line_no.
2414         (tui_display_reg_element_at_line)
2415         (tui_display_registers_from_line): Update.
2416         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2417         method.
2418
2419 2019-07-17  Tom Tromey  <tom@tromey.com>
2420
2421         PR tui/24722:
2422         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2423         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2424         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2425         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2426         (tui_update_breakpoint_info): Likewise.
2427         * tui/tui-hooks.c (tui_event_create_breakpoint)
2428         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2429         Update.
2430
2431 2019-07-17  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2434
2435 2019-07-17  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-winsource.c (tui_update_source_window_as_is)
2438         (tui_update_source_windows_with_addr): Update.
2439         * tui/tui-source.h (tui_set_source_content)
2440         (tui_show_symtab_source): Add "win_info" parameter.
2441         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2442         parameter.
2443         (tui_show_symtab_source): Likewise.
2444
2445 2019-07-17  Tom Tromey  <tom@tromey.com>
2446
2447         * tui/tui-wingeneral.c
2448         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2449
2450 2019-07-17  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2453         (struct tui_cmd_window) <can_scroll>: New method.
2454         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2455         method.
2456
2457 2019-07-17  Tom Tromey  <tromey@adacore.com>
2458
2459         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2460         do_field_signed>: Rename.  Change type of "value".
2461         * ui-out.c (ui_out::field_signed): Rename from field_int.
2462         Change type of "value".
2463         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2464         type of "value".
2465         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2466         do_field_int.  Change type of "value".
2467         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2468         do_field_int.  Change type of "value".
2469         * tracepoint.c (trace_status_mi, tfind_1)
2470         (print_one_static_tracepoint_marker): Update.
2471         * thread.c (print_thread_info_1, print_selected_thread_frame):
2472         Update.
2473         * stack.c (print_frame, print_frame_info): Update.
2474         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2475         Update.
2476         * source.c (print_source_lines_base): Update.
2477         * skip.c (info_skip_command): Update.
2478         * record-btrace.c (btrace_ui_out_decode_error)
2479         (btrace_call_history_src_line): Update.
2480         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2481         Update.
2482         * progspace.c (print_program_space): Update.
2483         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2484         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2485         do_field_int.  Change type of "value".
2486         * mi/mi-out.c (mi_ui_out::do_table_begin)
2487         (mi_ui_out::do_table_header): Update.
2488         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2489         type of "value".
2490         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2491         (mi_cmd_data_list_changed_registers, output_register)
2492         (mi_cmd_data_read_memory, mi_load_progress)
2493         (mi_cmd_trace_frame_collected): Update.
2494         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2495         Update.
2496         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2497         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2498         (mi_cmd_var_list_children, varobj_update_one): Update.
2499         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2500         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2501         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2502         * inferior.c (print_inferior): Update.
2503         * gdb_bfd.c (print_one_bfd): Update.
2504         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2505         Update.
2506         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2507         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2508         do_field_int.  Change type of "value".
2509         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2510         do_field_int.  Change type of "value".
2511         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2512         (print_one_breakpoint_location, print_it_catch_fork)
2513         (print_one_catch_fork, print_it_catch_vfork)
2514         (print_one_catch_vfork, print_it_catch_solib)
2515         (print_it_catch_exec, print_it_ranged_breakpoint)
2516         (print_mention_watchpoint, print_mention_masked_watchpoint)
2517         (bkpt_print_it, update_static_tracepoint): Update.
2518         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2519         * break-catch-syscall.c (print_it_catch_syscall): Update.
2520         * ada-tasks.c (print_ada_task_info): Update.
2521         * ada-lang.c (print_it_exception, print_mention_exception):
2522         Update.
2523
2524 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2525
2526         PR breakpoints/24541
2527         * gdbarch.c: Regenerate.
2528         * gdbarch.h: Regenerate.
2529         * gdbarch.sh: Adjust return type and parameter types for
2530         'stap_adjust_register'.
2531         (i386_stap_adjust_register): Adjust signature and return new
2532         register name.
2533         * stap-probe.c (stap_parse_register_operand): Adjust use of
2534         'gdbarch_stap_adjust_register'.
2535
2536 2019-07-17  Tom Tromey  <tromey@adacore.com>
2537
2538         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2539         declare VEC.
2540         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2541         std::vector.
2542         (struct s390_process_info): Add initializers.
2543         (s390_add_process): Use new.
2544         (s390_linux_nat_target::low_forget_process): Use delete.
2545         (s390_linux_nat_target::low_new_fork)
2546         (s390_linux_nat_target::stopped_by_watchpoint)
2547         (s390_linux_nat_target::low_prepare_to_resume)
2548         (s390_linux_nat_target::insert_watchpoint)
2549         (s390_linux_nat_target::insert_hw_breakpoint)
2550         (s390_linux_nat_target::remove_watchpoint)
2551         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2552
2553 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2554
2555         * aarch64-fbsd-nat.c: Include regcache.h.
2556         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2557         argument.
2558         (aarch64_fbsd_nat_target::fetch_registers)
2559         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2560         variable.
2561         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2562
2563 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2564
2565         * fbsd-nat.c: Include gdbarch.h.
2566
2567 2019-07-15  Tom Tromey  <tromey@adacore.com>
2568
2569         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2570
2571 2019-07-15  Tom Tromey  <tromey@adacore.com>
2572
2573         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2574         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2575         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2576         * cli-out.c (cli_ui_out::do_field_int): New method.
2577         * ui-out.c (ui_out::field_unsigned): New method.
2578         * symfile.c (generic_load): Use field_unsigned.
2579         (print_transfer_performance): Likewise.
2580         * record-btrace.c (ui_out_field_uint): Remove.
2581         (btrace_call_history_insn_range, btrace_call_history): Use
2582         field_unsigned.
2583         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2584         field_unsigned.
2585         * ui-out.h (class ui_out) <field_unsigned>: New method.
2586         <do_field_unsigned>: Likewise.
2587
2588 2019-07-15  Tom Tromey  <tromey@adacore.com>
2589
2590         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2591         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2592         * target.c (flash_erase_command): Use field_string.
2593         * infrun.c (print_signal_received_reason): Use field_string.
2594         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2595         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2596         field_string.
2597         * ada-tasks.c (print_ada_task_info): Use field_string.
2598
2599 2019-07-15  Tom Tromey  <tromey@adacore.com>
2600
2601         * target.c (flash_erase_command): Use field_core_addr.
2602         * symfile.c (generic_load): Use field_core_addr.
2603         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2604         Use field_core_addr.
2605         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2606         field_core_addr.
2607
2608 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2609
2610         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2611         value if its desired type is smaller than a CORE_ADDR and signed.
2612
2613 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2614
2615         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2616         of changes to field names, and use new is_reference field to
2617         decide if a property is a reference or not.
2618         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2619         field.
2620         (struct dwarf2_property_baton): Update header comment, rename
2621         'referenced_type' to 'property_type' and update comments.
2622         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2623         default property type, store in property baton, update to take
2624         accound of renamed field.
2625         (read_func_scope): Update call to attr_to_dynamic_prop.
2626         (read_array_type): Likewise.
2627         (dwarf2_per_cu_addr_sized_int_type): New function.
2628         (read_subrange_index_type): Move type finding code to
2629         dwarf2_per_cu_addr_sized_int_type.
2630         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2631         (dwarf2_per_cu_addr_type): New function.
2632         (set_die_type): Update calls to attr_to_dynamic_prop.
2633
2634 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2635
2636         * dwarf2read.c (read_subrange_index_type): New function.
2637         (read_subrange_type): Move code into new function and call it.
2638         * gdbtypes.c (create_range_type): Add some asserts.
2639
2640 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2643         update return statements.
2644         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2645         declaration, and update comment to match.
2646         * gdbtypes.c (resolve_dynamic_array): Update call to
2647         dwarf2_evaluate_property to match new return type.
2648
2649 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2650
2651         * valarith.c (value_subscripted_rvalue): Change lowerbound
2652         parameter type from int to LONGEST.
2653         * value.h (value_subscripted_rvalue): Likewise in declaration.
2654
2655 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * cli/cli-utils.c (info_print_command_completer): New function.
2658         * cli/cli-utils.h: Add 'completer.h' include, and forward
2659         declaration for 'struct cmd_list_element'.
2660         (info_print_command_completer): Declare.
2661         * stack.c (_initialize_stack): Add completer for 'info locals' and
2662         'info args'.
2663         * symtab.c (_initialize_symtab): Add completer for 'info
2664         variables' and 'info functions'.
2665         * NEWS: Mention completion for additional info commands.
2666
2667 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2668
2669         * cli/cli-utils.c (extract_info_print_args): Delete.
2670         (extract_arg_maybe_quoted): Delete.
2671         (info_print_options_defs): New variable.
2672         (make_info_print_options_def_group): New function.
2673         (extract_info_print_options): Define new function.
2674         * cli/cli-utils.h (extract_info_print_args): Delete.
2675         (struct info_print_options): New structure.
2676         (extract_info_print_options): Declare new function.
2677         * stack.c (info_locals_command): Update to use new
2678         extract_info_print_options, also add a header comment.
2679         (info_args_command): Likewise.
2680         * symtab.c (info_variables_command): Likewise.
2681         (info_functions_command): Likewise.
2682
2683 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2686         to extract string arguments.
2687         * common/common-utils.c (extract_string_maybe_quoted): New function.
2688         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2689
2690 2019-07-11  Tom Tromey  <tromey@adacore.com>
2691
2692         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2693         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2694         * top.h (gdbinit): Don't declare.
2695         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2696         into...
2697         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2698         * top.c (gdb_init): Don't call init_cli_cmds.
2699         (gdbinit): Remove.
2700         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2701
2702 2019-07-11  Tom Tromey  <tromey@adacore.com>
2703
2704         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2705         after it has been moved.
2706
2707 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2708
2709         * valops.c (value_must_coerce_to_target): Change return type to
2710         bool.
2711         * value.h (value_must_coerce_to_target): Likewise.
2712
2713 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2714
2715         * breakpoint.c (is_hardware_watchpoint): Remove
2716         forward-declaration.
2717         (is_masked_watchpoint): Change return type to bool.
2718         (is_tracepoint): Likewise.
2719         (is_breakpoint): Likewise.
2720         (is_hardware_watchpoint): Likewise.
2721         (is_watchpoint): Likewise.
2722         (is_no_memory_software_watchpoint): Likewise.
2723         (is_catchpoint): Likewise.
2724         (breakpoint_1): Make FILTER parameter's return type bool.
2725         is_masked_watchpoint): Change return type to bool.
2726         (save_breakpoints): Make FILTER parameter's return type bool.
2727         * breakpoint.h (is_breakpoint): Change return type to bool.
2728         (is_watchpoint): Likewise.
2729         (is_catchpoint): Likewise.
2730         (is_tracepoint): Likewise.
2731
2732 2019-07-10  Tom Tromey  <tom@tromey.com>
2733
2734         * defs.h: Don't include gdbarch.h.
2735         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2736         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2737         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2738         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2739         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2740         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2741         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2742         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2743         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2744         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2745         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2746         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2747         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2748         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2749         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2750         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2751         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2752         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2753         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2754         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2755         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2756         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2757         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2758         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2759         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2760         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2761         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2762
2763 2019-07-10  Tom Tromey  <tromey@adacore.com>
2764
2765         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2766         * breakpoint.c (init_ada_exception_breakpoint): Register as
2767         bp_catchpoint.
2768         (print_one_breakpoint_location, print_one_breakpoint): Use
2769         is_ada_exception_catchpoint.
2770         * ada-lang.c (class ada_catchpoint_location): Pass
2771         bp_loc_software_breakpoint to bp_location constructor.
2772         (is_ada_exception_catchpoint): New function.
2773
2774 2019-07-10  Tom Tromey  <tromey@adacore.com>
2775
2776         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2777         VEC.
2778         (struct arm_exidx_entry): New method operator<.
2779         (struct arm_exidx_data) <section_maps>: Change type.
2780         (arm_exidx_data_free): Remove.
2781         (arm_exidx_data_key): Change type.  Move lower.
2782         (arm_exidx_new_objfile): Update.
2783         (arm_compare_exidx_entries): Remove.
2784         (arm_find_exidx_entry, _initialize_arm_tdep)
2785
2786 2019-07-10  Tom Tromey  <tromey@adacore.com>
2787
2788         * solib-spu.c (ocl_program_data_key): Change type.
2789         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2790         Update.
2791
2792 2019-07-10  Tom Tromey  <tromey@adacore.com>
2793
2794         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2795         (struct solib_aix_inferior_data) <library_list>: Change type.
2796         (solib_aix_inferior_data_handle): Change type.
2797         (get_solib_aix_inferior_data): Update.
2798         (solib_aix_free_library_list): Remove.
2799         (library_list_start_library): Update.
2800         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2801         return type.
2802         (solib_aix_get_library_list)
2803         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2804         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2805
2806 2019-07-10  Tom Tromey  <tromey@adacore.com>
2807
2808         * solib-dsbt.c (struct dsbt_info): Add initializers.
2809         (solib_dsbt_pspace_data): Change type.
2810         (dsbt_pspace_data_cleanup): Remove.
2811         (get_dsbt_info, _initialize_dsbt_solib): Update.
2812
2813 2019-07-10  Tom Tromey  <tromey@adacore.com>
2814
2815         * spu-tdep.c (spu_overlay_data): Change type.
2816         (spu_get_overlay_table, spu_overlay_new_objfile)
2817         (_initialize_spu_tdep): Update.
2818
2819 2019-07-10  Tom Tromey  <tromey@adacore.com>
2820
2821         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2822         destructor.
2823         (dbx_objfile_data_key): Change type and declare later.
2824         (DBX_SYMFILE_INFO): Rewrite.
2825         * dbxread.c (dbx_objfile_data_key): Change type.
2826         (dbx_symfile_init): Update.
2827         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2828         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2829         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2830
2831 2019-07-10  Tom Tromey  <tromey@adacore.com>
2832
2833         * jit.c (jit_program_space_key): Change type.  Move lower.
2834         (get_jit_program_space_data): Update.
2835         (jit_program_space_data_cleanup): Remove.
2836         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2837         Update.
2838         (struct jit_program_space_data): Add initializers.
2839
2840 2019-07-10  Tom Tromey  <tromey@adacore.com>
2841
2842         * solib-darwin.c (struct darwin_info): Add initializers.
2843         (solib_darwin_pspace_data): Change type.
2844         (darwin_pspace_data_cleanup): Remove.
2845         (get_darwin_info, _initialize_darwin_solib): Update.
2846
2847 2019-07-10  Tom Tromey  <tromey@adacore.com>
2848
2849         * remote-sim.c (struct sim_inferior_data): Add initializers,
2850         constructor, and destructor.
2851         (sim_inferior_data_key): Change type.  Move lower.
2852         (check_for_duplicate_sim_descriptor): Update.
2853         (get_sim_inferior_data): Use new.  Update.
2854         (~sim_inferior_data_cleanup): Rename from
2855         sim_inferior_data_cleanup.  Simplify.
2856         (gdbsim_close_inferior, simulator_command)
2857         (sim_command_completer, _initialize_remote_sim): Update.
2858         (next_pid, INITIAL_PID): Move earlier.
2859
2860 2019-07-10  Tom Tromey  <tromey@adacore.com>
2861
2862         * python/python-internal.h (create_thread_object): Return
2863         gdbpy_ref.
2864         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2865         * python/py-inferior.c (struct threadlist_entry): Add
2866         constructor.
2867         <thread_obj>: Now a gdbpy_ref.
2868         (thread_to_thread_object): Update.
2869         (add_thread_object): Use new.
2870         (delete_thread_object): Use delete.
2871         (infpy_threads): Update.
2872         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2873         GIL.
2874
2875 2019-07-10  Tom Tromey  <tromey@adacore.com>
2876
2877         * valops.c (value_cast): Specialize error message for Ada.
2878
2879 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2880
2881         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2882
2883 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2884
2885         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2886         bpstat_should_step): Return bool, adjust comments.
2887         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2888         bpstat_should_step): Likewise.
2889
2890 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2891
2892         * features/Makefile: Use feature target descriptions for Arm.
2893         * features/arm/arm-core.c: Generate new file.
2894         * features/arm/arm-fpa.c: Likewise.
2895         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2896         * features/arm/arm-m-profile.c: Likewise.
2897         * features/arm/arm-vfpv2.c: Likewise.
2898         * features/arm/arm-vfpv3.c: Likewise.
2899         * features/arm/xscale-iwmmxt.c: Likewise.
2900         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2901
2902 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2903
2904         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2905         ptrace earlier.
2906
2907 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2908
2909         * features/aarch64-pauth.c: Regenerate.
2910
2911 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2912
2913         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2914         bool.
2915         (bpstat_what): Use false instead of 0.
2916
2917 2019-07-09  Pedro Alves  <palves@redhat.com>
2918
2919         * break-catch-throw.c (is_exception_catchpoint): New.
2920         * breakpoint.c (print_one_breakpoint_location): New parameter
2921         'raw_loc'.  Handle it.  Use
2922         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2923         looking at the breakpoint's type.
2924         (print_one_breakpoint): If handling "maint info breakpoints", also
2925         print locations of exception catchpoints.
2926         * breakpoint.h (is_exception_catchpoint): Declare.
2927
2928 2019-07-09  Pedro Alves  <palves@redhat.com>
2929
2930         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2931         "addr" field.
2932         (allocate_location_exception_catchpoint): New.
2933         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2934         (initialize_throw_catchpoint_ops): Install
2935         allocate_location_exception_catchpoint as allocate_location
2936         method.
2937         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2938         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2939         bp_loc_other.
2940         (breakpoint_address_is_meaningful): Delete.
2941         (bl_address_is_meaningful): New.
2942         (breakpoint_locations_match): Adjust comment.
2943         (bp_location_from_bp_type): New, factored out of...
2944         (bp_location::bp_location(breakpoint *)): ... this.
2945         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2946         factored out of...
2947         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2948         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2949         breakpoint_address_is_meaningful.
2950         (bp_locations_compare): Adjust comment.
2951         (update_global_location_list): Use bl_address_is_meaningful
2952         instead of breakpoint_address_is_meaningful.
2953         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2954         explicit.
2955         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2956         * python/py-breakpoint.c (bppy_get_location): No longer check
2957         whether location is null.
2958
2959 2019-07-09  Pedro Alves  <palves@redhat.com>
2960
2961         PR c++/15468
2962         * breakpoint.c (print_one_breakpoint_location): Remove
2963         single-location assert.
2964
2965 2019-07-09  Tom Tromey  <tom@tromey.com>
2966
2967         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2968         * configure: Rebuild.
2969         * configure.ac: Change common to gdbsupport.
2970         * gdbsupport: Rename from common.
2971         * acinclude.m4: Change common to gdbsupport.
2972         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2973         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2974         gdbsupport.
2975         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2976         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2977         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2978         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2979         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2980         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2981         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2982         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2983         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2984         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2985         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2986         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2987         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2988         coff-pe-read.c, command.h, compile/compile-c-support.c,
2989         compile/compile-c.h, compile/compile-cplus-symbols.c,
2990         compile/compile-cplus-types.c, compile/compile-cplus.h,
2991         compile/compile-loc2c.c, compile/compile.c, completer.c,
2992         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2993         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2994         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2995         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2996         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2997         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2998         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2999         features/aarch64-core.c, features/aarch64-fpu.c,
3000         features/aarch64-pauth.c, features/aarch64-sve.c,
3001         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3002         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3003         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3004         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3005         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3006         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3007         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3008         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3009         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3010         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3011         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3012         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3013         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3014         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3015         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3016         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3017         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3018         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3019         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3020         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3021         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3022         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3023         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3024         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3025         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3026         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3027         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3028         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3029         minsyms.c, mips-linux-tdep.c, namespace.h,
3030         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3031         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3032         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3033         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3034         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3035         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3036         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3037         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3038         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3039         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3040         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3041         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3042         procfs.c, producer.c, progspace.h, psymtab.h,
3043         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3044         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3045         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3046         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3047         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3048         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3049         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3050         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3051         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3052         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3053         target-memory.c, target.c, target.h, target/waitstatus.c,
3054         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3055         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3056         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3057         unittests/array-view-selftests.c,
3058         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3059         unittests/common-utils-selftests.c,
3060         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3061         unittests/format_pieces-selftests.c,
3062         unittests/function-view-selftests.c,
3063         unittests/lookup_name_info-selftests.c,
3064         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3065         unittests/mkdir-recursive-selftests.c,
3066         unittests/observable-selftests.c,
3067         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3068         unittests/parse-connection-spec-selftests.c,
3069         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3070         unittests/scoped_fd-selftests.c,
3071         unittests/scoped_mmap-selftests.c,
3072         unittests/scoped_restore-selftests.c,
3073         unittests/string_view-selftests.c, unittests/style-selftests.c,
3074         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3075         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3076         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3077         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3078         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3079         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3080
3081 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3082
3083         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3084         bool value.
3085         (decode_digits_ordinary): Set explicit_line field in sal.
3086         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3087         symtab_and_line that was set on an explicit line number in
3088         assembler code.  Do always update the recorded symtab and line if
3089         we do skip the prologue.
3090
3091 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3092
3093         * breakpoint.c (set_breakpoint_location_function): Remove
3094         explicit_loc parameter.
3095         (momentary_breakpoint_from_master): Update call to
3096         set_breakpoint_location_function.
3097         (add_location_to_breakpoint): Likewise.
3098
3099 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3102         required features based on default bfd type when no specific bfd
3103         is present.
3104
3105 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3106
3107         * NEWS: Mention that GDB printf and eval commands can now print
3108         C-style and Ada-style convenience var strings without
3109         calling the inferior.
3110         * printcmd.c (printf_c_string): Locally print GDB internal var
3111         instead of transiting via the inferior.
3112         (printf_wide_c_string): Likewise.
3113
3114 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3115
3116         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3117
3118 2019-07-04  Tom Tromey  <tom@tromey.com>
3119
3120         PR tui/24724:
3121         * tui/tui-winsource.c (tui_clear_source_content): Update.
3122         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3123         (tui_update_breakpoint_info): Update.
3124         (tui_set_exec_info_content): Update.
3125         * tui/tui-source.c (tui_set_source_content_nil): Update.
3126         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3127         has_break.
3128         * tui/tui-data.h (enum tui_bp_flag): New.
3129         (tui_bp_flags): New enum flags type.
3130         (struct tui_source_element) <break_mode>: Change type.  Rename
3131         from has_break.
3132         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3133         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3134         constants.
3135         * tui/tui-winsource.h: Fix comment.
3136
3137 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3138
3139         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3140         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3141         (store_fpregs_to_thread)
3142         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3143         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3144         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3145         (IWMMXT_REGS_SIZE): Add define.
3146         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3147         (fetch_vfp_regs, store_vfp_regs)
3148         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3149         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3150
3151 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3152
3153         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3154         defines.
3155         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3156         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3157         (ARM_INT_REGISTER_SIZE): ...to this.
3158         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3159         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3160         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3161         (arm_linux_collect_gregset, supply_nwfpe_register)
3162         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3163         defines.
3164         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3165         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3166         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3167         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3168         (arm_return_in_memory, arm_store_return_value)
3169         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3170         (arm_record_ld_st_multiple): Likewise.
3171         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3172         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3173
3174 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3175
3176         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3177         AARCH64_DISPLACED_MODIFIED_INSNS.
3178         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3179         (aarch64_displaced_step_copy_insn): Likewise.
3180         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3181         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3182         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3183         ARM_DISPLACED_MODIFIED_INSNS.
3184         * arm-tdep.c (arm_gdbarch_init): Likewise.
3185         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3186         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3187         (struct arm_displaced_step_closure): Use
3188         ARM_DISPLACED_MODIFIED_INSNS.
3189
3190 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3191
3192         * features/Makefile: Remove unused xml files.
3193         * features/aarch64.xml: Remove.
3194         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3195         * features/i386/amd64-avx-avx512.xml: Remove.
3196         * features/i386/amd64-avx-linux.xml: Remove.
3197         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3198         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3199         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3200         * features/i386/amd64-avx-mpx.xml: Remove.
3201         * features/i386/amd64-avx.xml: Remove.
3202         * features/i386/amd64-linux.xml: Remove.
3203         * features/i386/amd64-mpx-linux.xml: Remove.
3204         * features/i386/amd64-mpx.xml: Remove.
3205         * features/i386/amd64.xml: Remove.
3206         * features/i386/i386-avx-avx512-linux.xml: Remove.
3207         * features/i386/i386-avx-avx512.xml: Remove.
3208         * features/i386/i386-avx-linux.xml: Remove.
3209         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3210         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3211         * features/i386/i386-avx-mpx-linux.xml: Remove.
3212         * features/i386/i386-avx-mpx.xml: Remove.
3213         * features/i386/i386-avx.xml: Remove.
3214         * features/i386/i386-linux.xml: Remove.
3215         * features/i386/i386-mmx-linux.xml: Remove.
3216         * features/i386/i386-mmx.xml: Remove.
3217         * features/i386/i386-mpx-linux.xml: Remove.
3218         * features/i386/i386-mpx.xml: Remove.
3219         * features/i386/i386.xml: Remove.
3220         * features/i386/x32-avx-avx512-linux.xml: Remove.
3221         * features/i386/x32-avx-linux.xml: Remove.
3222         * features/i386/x32-linux.xml: Remove.
3223
3224 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3225
3226         * regformats/aarch64.dat: Remove.
3227         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3228         * regformats/i386/amd64-avx-linux.dat: Remove.
3229         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3230         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3231         * regformats/i386/amd64-linux.dat: Remove.
3232         * regformats/i386/amd64-mpx-linux.dat: Remove.
3233         * regformats/i386/amd64.dat: Remove.
3234         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3235         * regformats/i386/i386-avx-linux.dat: Remove.
3236         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3237         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3238         * regformats/i386/i386-linux.dat: Remove.
3239         * regformats/i386/i386-mmx-linux.dat: Remove.
3240         * regformats/i386/i386-mpx-linux.dat: Remove.
3241         * regformats/i386/i386.dat: Remove.
3242         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3243         * regformats/i386/x32-avx-linux.dat: Remove.
3244         * regformats/i386/x32-linux.dat: Remove.
3245
3246 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3247
3248         * aarch64-tdep.c: Remove xml self tests.
3249         * amd64-linux-tdep.c: Likewise.
3250         * amd64-tdep.c: Likewise.
3251         * i386-linux-tdep.c: Likewise.
3252         * i386-tdep.c: Likewise.
3253
3254 2019-07-03  Pedro Alves  <palves@redhat.com>
3255
3256         PR cli/24732
3257         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3258         (pipe_cmd_option_defs): New.
3259         (make_pipe_cmd_options_def_group): New.
3260         (pipe_command): Use gdb::option::process_options.
3261         (pipe_command_completer): New function.
3262         (_initialize_cli_cmds): Install completer for "pipe" command.
3263
3264 2019-07-03  Pedro Alves  <palves@redhat.com>
3265
3266         * cli/cli-option.c (union option_value) <string>: New field.
3267         (struct option_def_and_value): Add ctor, move ctor, dtor and
3268         use DISABLE_COPY_AND_ASSIGN.
3269         (option_def_and_value::clear_value): New.
3270         (parse_option, save_option_value_in_ctx, get_val_type_str)
3271         (add_setshow_cmds_for_options): Handle var_string.
3272         * cli-option.h (union option_def::var_address) <string>: New
3273         field.
3274         (struct string_option_def): New.
3275         * maint-test-options.c (struct test_options_opts): Add default
3276         ctor and use DISABLE_COPY_AND_ASSIGN.
3277         <string_opt>: New field.
3278         (test_options_opts::~test_options_opts): New.
3279         (test_options_opts::dump): Also dump "-string".
3280         (test_options_option_defs): Install "string.
3281
3282 2019-07-03  Pedro Alves  <palves@redhat.com>
3283
3284         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3285         option_value with a null enumeration.
3286         (complete_options): Save the option values in the context.
3287         (save_option_value_in_ctx): New, factored out from ...
3288         (process_options): ... here.
3289         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3290         of the function.
3291         * maint-test-options.c (test_options_opts::dump): New, factored
3292         out from ...
3293         (maintenance_test_options_command_mode): ... here.
3294         (maintenance_test_options_command_completion_result): Delete.
3295         (maintenance_test_options_command_completion_text): Update
3296         comment.
3297         (maintenance_show_test_options_completion_result): Change
3298         prototype.  Just print
3299         maintenance_test_options_command_completion_text.
3300         (save_completion_result): New.
3301         (maintenance_test_options_completer_mode): Pass options context to
3302         complete_options, and then save a dump.
3303         (_initialize_maint_test_options): Use add_cmd to install "maint
3304         show test-options-completion-result".
3305
3306 2019-07-03  Pedro Alves  <palves@redhat.com>
3307
3308         * NEWS (New commands): Mention "with" and "maint with".
3309         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3310         (with_command, with_command_completer): New.
3311         (pipe_command): Adjust to new repeat_previous
3312         interface.
3313         (_initialize_cli_cmds): Install the "with" command and its "w"
3314         alias.
3315         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3316         declarations.
3317         * cli/cli-setshow.c (parse_cli_var_uinteger)
3318         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3319         argument strings for all var_types.
3320         (get_setshow_command_value_string): New, factored out from ...
3321         (do_show_command): ... this.
3322         * cli/cli-setshow.h: Include <string>.
3323         (get_setshow_command_value_string): Declare.
3324         * command.h (repeat_previous): Now returns const char *.  Adjust
3325         comment.
3326         * maint.c: Include "cli/cli-cmds.h".
3327         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3328         (_initialize_maint_cmds): Register the "maintenance with" command.
3329         * top.c (repeat_previous): Move bits from pipe_command here:
3330         Return the saved command line, if any; error out if there's no
3331         command to relaunch.
3332
3333 2019-07-03  Pedro Alves  <palves@redhat.com>
3334
3335         * NEWS (New commands): Mention "maint set/show test-settings"
3336         instead of "maint test-settings".
3337         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3338         (maintenance_test_settings_set_list): Rename to ...
3339         (maintenance_set_test_settings_list): ... this.
3340         (maintenance_test_settings_show_list): Rename to  ...
3341         (maintenance_show_test_settings_list): ... this.
3342         (maintenance_test_settings_cmd): Delete.
3343         (maintenance_test_settings_set_cmd): ...
3344         (maintenance_set_test_settings_cmd): ... this.
3345         (maintenance_test_settings_show_cmd): ...
3346         (maintenance_show_test_settings_cmd): ... this.
3347         (maintenance_test_settings_show_value_cmd):
3348         (maintenance_show_test_settings_value_cmd): ... this.
3349         (_initialize_maint_test_settings): No longer install the "maint
3350         test-settings" prefix command.  Rename "maint test-settings set"
3351         to "maint set test-settings", and "maint test-settings show" to
3352         "maint show test-settings".  Adjust all subcommands.
3353
3354 2019-07-03  Pedro Alves  <palves@redhat.com>
3355
3356         * maint-test-settings.c: Fix file's intro comment.  Replace all
3357         references to "test-options" with references to "test-settings",
3358         in comments.
3359
3360 2019-07-03  Pedro Alves  <palves@redhat.com>
3361
3362         * maint-test-settings.c (maintenance_test_settings_xxx)
3363         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3364         New.
3365         (maintenance_test_settings_enums): Use them.
3366         (maintenance_test_settings_enum): Default to
3367         maintenance_test_settings_xxx.
3368         (_initialize_maint_test_settings): Initialize
3369         MAINTENANCE_TEST_SETTINGS_FILENAME.
3370
3371 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3372
3373         * breakpoint.h (remove_breakpoints_inf): Change return type to
3374         void, move function documentation here.
3375         * breakpoint.c (remove_breakpoints_inf): Change return type to
3376         void, move function documentation to header.
3377
3378 2019-07-02  Pedro Alves  <palves@redhat.com>
3379
3380         * NEWS (Completion improvements): Mention "info threads".
3381         * thread.c (struct info_threads_opts, info_threads_option_defs)
3382         (make_info_threads_options_def_group): New.
3383         (info_threads_command): Use gdb::option::process_options.
3384         (info_threads_command_completer): New.
3385         (_initialize_thread): Use gdb::option::build_help to build the
3386         help text for "info threads".
3387
3388 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3389
3390         * defs.h (generic_load): Move from here...
3391         * symfile.h (generic_load): ... to here.  Rename name parameter
3392         to args.
3393         * symfile.c (generic_load): Add comment.
3394
3395 2019-07-01  Tom Tromey  <tromey@adacore.com>
3396
3397         * dwarf2read.c
3398         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3399         declaration of without_params.  Fix formatting.
3400
3401 2019-07-01  Tom Tromey  <tromey@adacore.com>
3402
3403         * ada-exp.y (find_primitive_type): Update.
3404         * ada-lang.h (ada_lookup_symbol): Update.
3405         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3406         parameter.
3407         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3408
3409 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3410
3411         PR breakpoints/24541
3412         * gdbarch.c: Regenerate.
3413         * gdbarch.h: Regenerate.
3414         * gdbarch.sh: Add 'stap_adjust_register'.
3415         * i386-tdep.c: Include '<unordered_set>'.
3416         (i386_stap_adjust_register): New function.
3417         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3418         * stap-probe.c (stap_parse_register_operand): Call
3419         'gdbarch_stap_adjust_register'.
3420
3421 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3422
3423         PR python/24742
3424         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3425         * python/python.c (do_start_initialization): Use 'xmalloc'
3426         instead of 'PyMem_Malloc'.
3427
3428 2019-06-28  Tom Tromey  <tromey@adacore.com>
3429
3430         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3431         for Ada.
3432
3433 2019-06-27  Tom Tromey  <tromey@adacore.com>
3434
3435         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3436         objfile_key.
3437         (arm_find_mapping_symbol, arm_record_special_symbol)
3438         (_initialize_arm_tdep): Update.
3439         (arm_objfile_data_free): Remove.
3440
3441 2019-06-27  Tom Tromey  <tromey@adacore.com>
3442
3443         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3444         to cp_print_static_field.
3445
3446 2019-06-26  Tom Tromey  <tromey@adacore.com>
3447
3448         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3449         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3450         declare.
3451
3452 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3453
3454         * features/aarch64-core.c (create_feature_aarch64_core):
3455         Regenerate.
3456         * features/aarch64-core.xml: Add cpsr flags.
3457
3458 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3459
3460         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3461         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3462
3463 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3464
3465         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3466         field.
3467         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3468         use.
3469         (arm_record_special_symbol): Don't insert new symbol in sorted
3470         position, push it at the end.
3471
3472 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3473
3474         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3475         (arm_mapping_symbol_s): Remove.
3476         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3477         (arm_mapping_symbol_vec): New typedef.
3478         (struct arm_per_objfile): Add constructor.
3479         <section_maps>: Change type to
3480         std::unique_ptr<arm_mapping_symbol_vec[]>.
3481         (arm_compare_mapping_symbols): Remove.
3482         (arm_find_mapping_symbol): Adjust to section_maps type change.
3483         (arm_objfile_data_free): Call delete on arm_per_objfile.
3484         (arm_record_special_symbol): Adjust to section_maps type change.
3485         Allocate arm_per_objfile with new.
3486
3487 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3488
3489         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3490         with the command prefix.
3491
3492 2019-06-25  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3495         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3496
3497 2019-06-25  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3500         type.
3501         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3502         protected.
3503
3504 2019-06-25  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-winsource.c
3507         (tui_source_window_base::set_is_exec_point_at): Add check against
3508         LOA_ADDRESS.
3509
3510 2019-06-25  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-source.c (tui_set_source_content): Don't check before
3513         xfree.
3514         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3515
3516 2019-06-25  Tom Tromey  <tom@tromey.com>
3517
3518         * tui/tui-winsource.h (tui_update_source_window_as_is)
3519         (tui_alloc_source_buffer, tui_line_is_displayed)
3520         (tui_addr_is_displayed): Change type of win_info.
3521         * tui/tui-winsource.c (tui_update_source_window_as_is)
3522         (tui_clear_source_content, tui_show_source_line)
3523         (tui_show_source_content, tui_source_window_base::refill)
3524         (tui_source_window_base::set_is_exec_point_at)
3525         (tui_source_window_base::set_is_exec_point_at)
3526         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3527         (tui_alloc_source_buffer, tui_line_is_displayed)
3528         (tui_addr_is_displayed): Change type of win_info.  Update.
3529         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3530         (tui_source_window_base::do_make_visible_with_new_height):
3531         Update.
3532         * tui/tui-source.c (tui_set_source_content)
3533         (tui_set_source_content_nil)
3534         (tui_source_window::do_scroll_vertical): Update.
3535         * tui/tui-layout.c (show_layout): Update.
3536         * tui/tui-disasm.c (tui_set_disassem_content)
3537         (tui_disasm_window::do_scroll_vertical): Update.
3538         * tui/tui-data.h (tui_win_content): Remove.
3539         (struct tui_gen_win_info) <content, content_size>: Remove.
3540         (struct tui_source_element): Add initializers and destructor.
3541         (union tui_which_element, struct tui_win_element): Remove.
3542         (struct tui_source_window_base) <content>: New field.
3543         (struct tui_data_window): Remove destructor.
3544         (tui_alloc_content, tui_free_win_content)
3545         (tui_free_all_source_wins_content): Don't declare.
3546         * tui/tui-data.c (tui_initialize_static_data): Update.
3547         (init_content_element, tui_alloc_content): Remove.
3548         (~tui_gen_win_info): Update.
3549         (~tui_data_window, tui_free_all_source_wins_content)
3550         (tui_free_win_content, free_content, free_content_elements):
3551         Remove.
3552
3553 2019-06-25  Tom Tromey  <tom@tromey.com>
3554
3555         * tui/tui-winsource.h (tui_clear_source_content)
3556         (tui_erase_source_content, tui_show_source_content): Change type
3557         of win_info.
3558         * tui/tui-winsource.c (tui_clear_source_content)
3559         (tui_erase_source_content, tui_show_source_content): Change type
3560         of win_info.
3561         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3562         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3563         win_info.
3564         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3565         win_info.
3566         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3567
3568 2019-06-25  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-winsource.c (tui_clear_source_content)
3571         (tui_source_window_base::set_is_exec_point_at): Update.
3572         * tui/tui-source.c (tui_set_source_content_nil): Update.
3573         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3574         a bool.
3575         * tui/tui-data.c (init_content_element): Update.
3576
3577 2019-06-25  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3580         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3581         * tui/tui-layout.c (init_and_make_win): Update.
3582         * tui/tui.h (enum tui_win_type): Update.
3583         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3584         tui_win_is_auxillary.
3585         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3586         tui_win_is_auxillary.
3587
3588 2019-06-25  Tom Tromey  <tom@tromey.com>
3589
3590         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3591         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3592         (tui_delete_data_content_windows, tui_display_all_data)
3593         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3594         Update.
3595         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3596         * tui/tui-regs.c (tui_last_regs_line_no)
3597         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3598         (tui_show_registers): Update.
3599         (tui_show_register_group): Return void.  Update.
3600         (tui_display_registers_from, tui_display_reg_element_at_line)
3601         (tui_display_registers_from_line, tui_check_register_values):
3602         Update.
3603         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3604         member.
3605         (struct tui_data_window) <regs_content>: Now a std::vector.
3606         <regs_content_count>: Remove.
3607         (tui_add_content_elements, tui_free_data_content): Don't declare.
3608         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3609         (init_content_element): Remove DATA_WIN case.  Add assert.
3610         (tui_add_content_elements): Remove.
3611         (tui_data_window): Update.
3612         (tui_free_data_content): Remove.
3613         (free_content_elements): Remove DATA_WIN case.
3614
3615 2019-06-25  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-data.c (tui_data_item_window): Update.
3618         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3619         * tui/tui-windata.c (tui_display_all_data)
3620         (tui_display_data_from_line): Update.
3621         (tui_check_data_values): Remove.
3622         * tui/tui-regs.c (tui_show_register_group)
3623         (tui_display_reg_element_at_line): Update.
3624         * tui/tui-hooks.c (tui_register_changed)
3625         (tui_refresh_frame_and_register_information): Call
3626         tui_check_register_values.
3627         * tui/tui-data.h (struct tui_data_window) <data_content,
3628         data_content_count, data_type>: Remove.
3629         (enum tui_data_type): Remove.
3630
3631         * tui/tui-data.c (tui_data_window::clear_detail)
3632         (~tui_data_window): Update.
3633
3634 2019-06-25  Tom Tromey  <tom@tromey.com>
3635
3636         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3637         declare.
3638         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3639         Rename from tui_first_data_item_displayed.  Update.
3640         (tui_data_window::refresh_all)
3641         (tui_data_window::do_scroll_vertical): Update.
3642         * tui/tui-data.h (struct tui_data_window)
3643         <first_data_item_displayed>: Declare new method.
3644
3645 2019-06-25  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3648         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3649         contents...
3650         (tui_initialize_static_data): ...here.
3651
3652 2019-06-25  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3655         (tui_display_registers_from, tui_check_register_values): Update.
3656         (tui_display_register): Remove win_info parameter; update.
3657         (tui_get_register): Change type of parameters.
3658         * tui/tui-data.h (struct tui_data_element): Remove.
3659         (union tui_which_element) <data>: Remove.
3660         <data_window>: Change type.
3661         (struct tui_data_item_window): New.
3662         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3663         case.  Add assert.
3664         (~tui_data_item_window): New destructor.
3665         (free_content_elements): Remove DATA_ITEM_WIN case.
3666
3667 2019-06-25  Tom Tromey  <tom@tromey.com>
3668
3669         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3670         Remove.
3671
3672 2019-06-25  Tom Tromey  <tom@tromey.com>
3673
3674         * tui/tui-data.h (struct tui_command_element): Remove.
3675         (union tui_which_element) <command>: Remove.
3676         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3677         assert.
3678         (free_content_elements): Remove CMD_WIN case.
3679
3680 2019-06-25  Tom Tromey  <tom@tromey.com>
3681
3682         * tui/tui-layout.c (tui_set_layout): Update.
3683         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3684         * tui/tui-data.c (layout_def): Update.
3685
3686 2019-06-25  Tom Tromey  <tom@tromey.com>
3687
3688         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3689         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3690         (tui_source_window_base::set_new_height): Update.
3691         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3692         Update.
3693         (tui_set_locator_fullname, tui_set_locator_info)
3694         (tui_show_frame_info): Update.
3695         * tui/tui-source.c (tui_set_source_content)
3696         (tui_source_is_displayed): Update.
3697         * tui/tui-layout.c (show_source_disasm_command, show_data)
3698         (show_source_or_disasm_and_command): Update.
3699         * tui/tui-disasm.c (tui_set_disassem_content)
3700         (tui_get_begin_asm_address): Update.
3701         * tui/tui-data.h (struct tui_locator_element): Remove.
3702         (union tui_which_element) <locator>: Remove.
3703         (struct tui_locator_window): New.
3704         (tui_locator_win_info_ptr): Change return type.
3705         * tui/tui-data.c (_locator): Change type.
3706         (tui_locator_win_info_ptr): Change return type.
3707         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3708         (tui_alloc_content): Add assert.
3709
3710 2019-06-25  Tom Tromey  <tom@tromey.com>
3711
3712         * tui/tui-winsource.c
3713         (tui_exec_info_window::maybe_allocate_content): New method.
3714         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3715         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3716         (make_source_or_disasm_window): Add cast.
3717         * tui/tui-data.h (union tui_which_element) <simple_string>:
3718         Remove.
3719         (struct tui_source_info): New.
3720         (struct tui_source_window_base) <execution_info>: Change type.
3721         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3722         case, and add assert.
3723         (tui_alloc_content): Add assert.
3724
3725 2019-06-25  Tom Tromey  <tom@tromey.com>
3726
3727         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3728         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3729         * tui/tui-data.c (tui_alloc_win_info): Remove.
3730
3731 2019-06-25  Tom Tromey  <tom@tromey.com>
3732
3733         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3734         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3735         can_highlight.
3736
3737 2019-06-25  Tom Tromey  <tom@tromey.com>
3738
3739         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3740         make_visible_with_new_height method.
3741         (tui_win_info::make_visible_with_new_height): New method.
3742         (tui_source_window_base::do_make_visible_with_new_height)
3743         (tui_data_window::do_make_visible_with_new_height)
3744         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3745         (make_visible_with_new_height): Remove.
3746         (tui_resize_all, tui_adjust_win_heights): Use
3747         make_visible_with_new_height method.
3748         * tui/tui-data.h (struct tui_win_info)
3749         <do_make_visible_with_new_height, make_visible_with_new_height>:
3750         New methods.
3751         (struct tui_source_window_base, struct tui_data_window)
3752         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3753         methods.
3754
3755 2019-06-25  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3758         method.
3759         (update_tab_width): Call update_tab_width method.
3760         * tui/tui-data.h (struct tui_win_info)
3761         (struct tui_source_window_base) <update_tab_width>: New methods.
3762
3763 2019-06-25  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3766         parameter.
3767         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3768         parameter.
3769         (tui_gen_win_info::make_visible): Update.
3770         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3771         parameter.
3772         * tui/tui-data.h (enum tui_box): New enum.
3773         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3774
3775 2019-06-25  Tom Tromey  <tom@tromey.com>
3776
3777         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3778         init_and_make_win for EXEC_INFO_WIN.
3779         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3780         longer inline.
3781         (struct tui_win_info) <~tui_win_info>: Inline.
3782         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3783         Don't declare.
3784         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3785         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3786         Remove.
3787         (tui_initialize_static_data): Update.
3788         (~tui_gen_win_info): Handle more cleanup here.
3789         (~tui_source_window_base): Delete "execution_info".
3790         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3791
3792 2019-06-25  Tom Tromey  <tom@tromey.com>
3793
3794         * tui/tui-layout.c (make_command_window): Don't set
3795         can_highlight.
3796         (show_source_disasm_command): Call the reset method.
3797         (show_data): Don't set can_highlight.  Call the reset method.
3798         (tui_gen_win_info::reset): Rename from init_gen_win_info
3799         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3800         (show_source_or_disasm_and_command): Call the reset method.
3801         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3802         (struct tui_cmd_window): Set can_highlight.
3803
3804 2019-06-25  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3807         from make_visible.
3808         (tui_make_visible, tui_make_invisible): Rewrite.
3809         (tui_win_info::make_visible): Remove.
3810         (tui_source_window_base::make_visible): Update.
3811         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3812         method.  Moved from...
3813         (struct tui_win_info) <make_visible>: ...here.
3814
3815 2019-06-25  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-winsource.c
3818         (tui_source_window_base::do_scroll_horizontal): Remove direction
3819         parameter.
3820         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3821         direction parameter.
3822         * tui/tui-win.c (tui_win_info::forward_scroll)
3823         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3824         (tui_win_info::right_scroll): Update.
3825         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3826         direction parameter.
3827         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3828         direction parameter.
3829         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3830         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3831         Remove direction parameter.
3832         (struct tui_source_window_base, struct tui_source_window)
3833         (struct tui_disasm_window, struct tui_data_window)
3834         (struct tui_cmd_window): Update.
3835
3836 2019-06-25  Tom Tromey  <tom@tromey.com>
3837
3838         * tui/tui-winsource.h (tui_set_exec_info_content)
3839         (tui_show_exec_info_content, tui_erase_exec_info_content)
3840         (tui_clear_exec_info_content, tui_update_exec_info): Change
3841         argument to tui_source_window_base.
3842         * tui/tui-winsource.c (tui_set_exec_info_content)
3843         (tui_show_exec_info_content, tui_erase_exec_info_content)
3844         (tui_clear_exec_info_content, tui_update_exec_info): Change
3845         argument to tui_source_window_base.
3846
3847 2019-06-25  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3850         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3851
3852 2019-06-25  Tom Tromey  <tom@tromey.com>
3853
3854         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3855         check.
3856
3857 2019-06-25  Tom Tromey  <tom@tromey.com>
3858
3859         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3860         type to void.
3861         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3862         type to void.
3863         * tui/tui-source.c (tui_set_source_content): Update.
3864         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3865
3866 2019-06-25  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui-win.c (window_name_completer, tui_set_focus)
3869         (tui_all_windows_info): Use name method.
3870         * tui/tui-data.h (struct tui_gen_win_info)
3871         (struct tui_source_window, struct tui_disasm_window)
3872         (struct tui_data_window, struct tui_cmd_window) <name>: New
3873         method.
3874         (tui_win_name): Don't declare.
3875         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3876         (tui_win_name): Remove.
3877
3878 2019-06-25  Tom Tromey  <tom@tromey.com>
3879
3880         * tui/tui-winsource.h (tui_update_source_window)
3881         (tui_update_source_window_as_is): Change parameter type.
3882         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3883         to be a tui_source_window_base.
3884         (tui_update_source_window_as_is): Likewise.
3885         * tui/tui-win.c (make_visible_with_new_height): Update.
3886
3887 2019-06-25  Tom Tromey  <tom@tromey.com>
3888
3889         * tui/tui-winsource.c (tui_erase_source_content)
3890         (tui_show_source_content, tui_show_exec_info_content)
3891         (tui_erase_exec_info_content): Use refresh_window method.
3892         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3893         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3894         from tui_refresh_win.
3895         (tui_data_window::refresh_window): New method.
3896         (tui_win_info::refresh, tui_source_window_base::refresh)
3897         (tui_refresh_all): Use refresh_window method.
3898         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3899         method.
3900         * tui/tui-regs.c (tui_display_register): Call refresh_window
3901         method.
3902         * tui/tui-layout.c (show_source_disasm_command)
3903         (show_source_or_disasm_and_command): Call refresh_window method.
3904         * tui/tui-data.h (struct tui_gen_win_info)
3905         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3906         New method.
3907
3908 2019-06-25  Tom Tromey  <tom@tromey.com>
3909
3910         * tui/tui.c (tui_rl_other_window, tui_enable)
3911         (tui_is_window_visible, tui_get_command_dimension): Update.
3912         * tui/tui-winsource.c (tui_update_source_window_as_is)
3913         (tui_clear_source_content, tui_erase_source_content)
3914         (tui_show_source_line, tui_source_window_base::refill)
3915         (tui_source_window_base::do_scroll_horizontal)
3916         (tui_source_window_base::set_is_exec_point_at)
3917         (tui_update_breakpoint_info, tui_set_exec_info_content)
3918         (tui_alloc_source_buffer, tui_line_is_displayed)
3919         (tui_addr_is_displayed): Update.
3920         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3921         (tui_check_and_display_highlight_if_needed)
3922         (tui_win_info::make_visible, tui_win_info::refresh)
3923         (tui_refresh_all): Update.
3924         * tui/tui-windata.c (tui_first_data_item_displayed)
3925         (tui_delete_data_content_windows, tui_erase_data_content)
3926         (tui_display_all_data, tui_data_window::refresh_all)
3927         (tui_check_data_values): Update.
3928         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3929         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3930         (tui_win_info::backward_scroll, tui_refresh_all_win)
3931         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3932         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3933         (tui_source_window_base::set_new_height)
3934         (tui_data_window::set_new_height)
3935         (make_invisible_and_set_new_height)
3936         (make_visible_with_new_height, new_height_ok)
3937         (parse_scrolling_args): Update.
3938         * tui/tui-stack.c (tui_show_frame_info): Update.
3939         * tui/tui-source.c (tui_set_source_content)
3940         (tui_set_source_content_nil, tui_source_is_displayed)
3941         (tui_source_window::do_scroll_vertical): Update.
3942         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3943         (tui_display_registers_from, tui_display_reg_element_at_line)
3944         (tui_check_register_values, tui_reg_command): Update.
3945         * tui/tui-layout.c (tui_default_win_height)
3946         (show_source_disasm_command, show_data, init_and_make_win)
3947         (show_source_or_disasm_and_command): Update.
3948         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3949         (tui_redisplay_readline, tui_mld_flush)
3950         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3951         (tui_getc): Update.
3952         * tui/tui-disasm.c (tui_set_disassem_content)
3953         (tui_disasm_window::do_scroll_vertical): Update.
3954         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3955         Now virtual.
3956         (struct tui_win_info): Derive from tui_gen_win_info.
3957         <~tui_win_info>: Mark as override.
3958         <generic>: Remove member.
3959         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3960         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3961         (~tui_data_window, ~tui_win_info)
3962         (tui_free_all_source_wins_content): Update.
3963         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3964
3965 2019-06-25  Tom Tromey  <tom@tromey.com>
3966
3967         * tui/tui-layout.c (init_and_make_win): Use new.
3968         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3969         destructor, initializers.
3970         (tui_alloc_generic_win_info): Don't declare.
3971         * tui/tui-data.c (_locator): Add argument to constructor.
3972         (source_win, disasm_win): New globals.
3973         (exec_info): Remove.
3974         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3975         Update.
3976         (tui_alloc_generic_win_info): Remove.
3977         (init_content_element): Use new.
3978         (tui_win_info::tui_win_info): Update.
3979         (free_content_elements) <case DATA_WIN>: Use delete.
3980
3981 2019-06-25  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3984         * tui/tui-windata.c (tui_first_data_item_displayed)
3985         (tui_delete_data_content_windows): Update.
3986         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3987         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3988         (tui_display_registers_from, tui_check_register_values): Update.
3989         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3990         pointer.
3991         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3992         window.
3993         (tui_free_data_content): Update.
3994         (free_content_elements) <case DATA_WIN>: Free the window.
3995
3996 2019-06-25  Tom Tromey  <tom@tromey.com>
3997
3998         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3999         Update.
4000         * tui/tui-layout.c (make_command_window)
4001         (show_source_disasm_command, show_data, init_and_make_win)
4002         (show_source_or_disasm_and_command): Update.
4003         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4004         method.
4005         <can_highight, is_highlighted>: Now bool.
4006         (tui_set_win_highlight): Don't declare.
4007         * tui/tui-data.c (tui_set_win_highlight): Remove.
4008
4009 2019-06-25  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-wingeneral.c (make_visible): Remove check of window
4012         type.
4013
4014 2019-06-25  Tom Tromey  <tom@tromey.com>
4015
4016         * tui/tui-win.c (tui_win_info::max_height)
4017         (tui_cmd_window::max_height): New methods.
4018         (new_height_ok): Call max_height.
4019         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4020         <max_height>: New method.
4021
4022 2019-06-25  Tom Tromey  <tom@tromey.com>
4023
4024         * tui/tui-win.c (tui_source_window_base::set_new_height)
4025         (tui_data_window::set_new_height): New methods.
4026         (make_invisible_and_set_new_height): Call set_new_height method.
4027         * tui/tui-data.h (struct tui_win_info)
4028         (struct tui_source_window_base, struct tui_data_window)
4029         <set_new_height>: New method.
4030
4031 2019-06-25  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4034         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4035         tui_refresh_data_win.
4036         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4037         method.
4038         (tui_refresh_all_win): Call the refresh_all method.
4039         (tui_set_focus): Likewise.
4040         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4041         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4042         Likewise.
4043
4044 2019-06-25  Tom Tromey  <tom@tromey.com>
4045
4046         * tui/tui-winsource.h (tui_refill_source_window)
4047         (tui_set_is_exec_point_at): Don't declare.
4048         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4049         (tui_source_window_base::refill): Rename from
4050         tui_refill_source_window.
4051         (tui_source_window_base::do_scroll_horizontal): Update.
4052         (tui_source_window_base::set_is_exec_point_at): Rename from
4053         tui_set_is_exec_point_at.
4054         (tui_update_all_breakpoint_info): Update.
4055         * tui/tui-stack.c (tui_show_frame_info): Update.
4056         * tui/tui-layout.c (show_data): Add cast.
4057         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4058         * tui/tui-data.h (struct tui_source_window_base) <refill,
4059         set_is_exec_point_at>: New methods.
4060         (tui_source_windows, tui_add_to_source_windows): Update types.
4061         (tui_add_to_source_windows): Remove redundant declaration.
4062         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4063         (tui_source_windows): Change return type.
4064         (tui_clear_source_windows_detail): Update.
4065         (tui_add_to_source_windows): Change type of parameter.
4066         (tui_free_all_source_wins_content): Update.
4067
4068 2019-06-25  Tom Tromey  <tom@tromey.com>
4069
4070         * tui/tui-wingeneral.c (tui_win_info::refresh)
4071         (tui_source_window_base::refresh): New methods.
4072         (tui_refresh_all): Call the refresh method.
4073         * tui/tui-data.h (struct tui_win_info)
4074         (struct tui_source_window_base) <refresh>: New method.
4075
4076 2019-06-25  Tom Tromey  <tom@tromey.com>
4077
4078         * tui/tui.h (tui_is_window_visible): Return bool.
4079         * tui/tui.c (tui_is_window_visible): Return bool.
4080         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4081         (tui_make_visible, tui_make_invisible)
4082         (tui_win_info::make_visible)
4083         (tui_source_window_base::make_visible, make_all_visible)
4084         (tui_make_all_visible, tui_make_all_invisible): Update.
4085         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4086         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4087         bool.
4088         (struct tui_win_info, struct tui_source_window_base)
4089         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4090         * tui/tui-data.c (tui_init_generic_part): Update.
4091
4092 2019-06-25  Tom Tromey  <tom@tromey.com>
4093
4094         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4095         (tui_source_window_base::make_visible): New methods.
4096         (make_all_visible): Make method call.
4097         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4098         (struct tui_source_window_base, struct tui_cmd_window): Override
4099         make_visible.
4100         (tui_win_is_source_type): Don't declare.
4101         * tui/tui-data.c (tui_win_is_source_type): Remove.
4102
4103 2019-06-25  Tom Tromey  <tom@tromey.com>
4104
4105         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4106         NULL check.
4107
4108 2019-06-25  Tom Tromey  <tom@tromey.com>
4109
4110         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4111         Inline constructor.  Add initializers for members.
4112         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4113         constructors; now inline in class.
4114
4115 2019-06-25  Tom Tromey  <tom@tromey.com>
4116
4117         * tui/tui-regs.c (tui_show_registers): Update.
4118         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4119         bool.
4120         * tui/tui-data.c (tui_data_window::clear_detail)
4121         (tui_data_window): Update.
4122
4123 2019-06-25  Tom Tromey  <tom@tromey.com>
4124
4125         * tui/tui-windata.c (tui_display_all_data)
4126         (tui_display_data_from_line, tui_display_data_from)
4127         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4128         Update.
4129         * tui/tui-regs.c (tui_last_regs_line_no)
4130         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4131         (tui_show_registers, tui_show_register_group)
4132         (tui_display_registers_from, tui_display_reg_element_at_line)
4133         (tui_display_registers_from_line, tui_check_register_values)
4134         (tui_reg_next, tui_reg_prev): Update.
4135         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4136         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4137         tui_data_window.
4138         (struct tui_win_info) <detail>: Remove.  Add new fields from
4139         tui_data_info.
4140         (TUI_DATA_WIN): Add cast.
4141         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4142         (~tui_data_window): Simplify.
4143
4144 2019-06-25  Tom Tromey  <tom@tromey.com>
4145
4146         * tui/tui-layout.c (show_source_disasm_command)
4147         (show_source_or_disasm_and_command): Update.
4148         * tui/tui-io.c (update_cmdwin_start_line)
4149         (tui_redisplay_readline): Update.
4150         * tui/tui-data.h (struct tui_command_info): Remove.
4151         (struct tui_win_info) <detail>: Remove command_info member.
4152         (struct tui_data_window) <start_line>: New member, from
4153         tui_command_info.
4154         (TUI_CMD_WIN): Add casts.
4155
4156 2019-06-25  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui-winsource.c (tui_update_source_window)
4159         (tui_refill_source_window)
4160         (tui_source_window_base::do_scroll_horizontal)
4161         (tui_update_breakpoint_info, tui_set_exec_info_content)
4162         (tui_show_exec_info_content, tui_erase_exec_info_content)
4163         (tui_clear_exec_info_content): Update.
4164         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4165         Update.
4166         * tui/tui-win.c (make_invisible_and_set_new_height)
4167         (make_visible_with_new_height): Update.
4168         * tui/tui-source.c (tui_set_source_content)
4169         (tui_show_symtab_source): Update.
4170         * tui/tui-layout.c (extract_display_start_addr)
4171         (show_source_disasm_command, show_data)
4172         (make_source_or_disasm_window)
4173         (show_source_or_disasm_and_command): Update.
4174         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4175         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4176         "gdbarch".
4177         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4178         to tui_source_window_base.
4179         (struct tui_win_info) <detail>: Remove source_info member.
4180         (struct tui_source_window_base) <has_locator>: Inline.
4181         Move contents from tui_source_info; rename has_locator member to
4182         m_has_locator.
4183         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4184         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4185         header file.
4186         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4187         Simplify.
4188         (tui_free_all_source_wins_content): Cast to
4189         tui_source_window_base.
4190
4191 2019-06-25  Tom Tromey  <tom@tromey.com>
4192
4193         * tui/tui-win.c (make_invisible_and_set_new_height)
4194         (make_visible_with_new_height): Call has_locator method.
4195         * tui/tui-layout.c (show_source_disasm_command, show_data)
4196         (show_source_or_disasm_and_command): Update for bool change.
4197         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4198         (tui_win_info) <has_locator>: New method.
4199         (struct tui_source_window_base) <has_locator>: New method.
4200         (tui_win_has_locator): Don't declare.
4201         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4202         from tui_win_has_locator.
4203         (tui_source_window_base): Use false, not FALSE.
4204
4205 2019-06-25  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4208         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4209         clear_detail method directly.
4210         (tui_clear_win_detail): Remove.
4211
4212 2019-06-25  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4215         "this", not TUI_DISASM_WIN.
4216
4217 2019-06-25  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4220         declare.
4221         * tui/tui-winsource.c
4222         (tui_source_window_base::do_scroll_horizontal): Rename from
4223         tui_horizontal_source_scroll.
4224         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4225         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4226         from tui_vertical_data_scroll.
4227         * tui/tui-win.h (tui_scroll): Don't declare.
4228         * tui/tui-win.c (tui_win_info::forward_scroll)
4229         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4230         (tui_win_info::right_scroll): Rename and update.
4231         (tui_scroll_forward_command, tui_scroll_backward_command)
4232         (tui_scroll_left_command, tui_scroll_right_command): Update.
4233         (tui_scroll): Remove.
4234         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4235         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4236         from tui_vertical_source_scroll.
4237         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4238         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4239         from tui_vertical_disassem_scroll.
4240         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4241         do_scroll_horizontal>: New methods.
4242         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4243         Likewise.
4244         (struct tui_source_window_base): Add do_scroll_horizontal.
4245         (struct tui_source_window, struct tui_disasm_window): Add
4246         do_scroll_vertical.
4247         (struct tui_data_window, struct tui_cmd_window): Add
4248         do_scroll_horizontal and do_scroll_vertical.
4249         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4250
4251 2019-06-25  Tom Tromey  <tom@tromey.com>
4252
4253         * tui/tui-data.h (struct tui_source_window_base): New struct.
4254         (struct tui_source_window): Derive from tui_source_window_base.
4255         (struct tui_disasm_window): New struct.
4256         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4257         from tui_source_window::clear_detail.
4258         (tui_source_window_base): Rename from tui_source_window.
4259         (~tui_source_window_base): Rename from ~tui_source_window.
4260         (tui_alloc_win_info): Create a tui_disasm_window.
4261
4262 2019-06-25  Tom Tromey  <tom@tromey.com>
4263
4264         * tui/tui-data.h (struct tui_source_window)
4265         (struct tui_data_window): Declare destructors.
4266         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4267         destructors.
4268         (tui_win_info): Simplify.
4269
4270 2019-06-25  Tom Tromey  <tom@tromey.com>
4271
4272         * tui/tui-winsource.c (tui_display_main)
4273         (tui_update_source_windows_with_addr)
4274         (tui_update_all_breakpoint_info): Update.
4275         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4276         (new_height_ok, parse_scrolling_args): Update.
4277         * tui/tui-stack.c (tui_show_frame_info): Update.
4278         * tui/tui-data.h (struct tui_list): Remove.
4279         (tui_source_windows): Return a reference to a std::vector.
4280         * tui/tui-data.c (source_windows): Now a std::vector.
4281         (tui_source_windows): Change return type.
4282         (tui_clear_source_windows): Rewrite.
4283         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4284         (tui_free_all_source_wins_content): Rewrite.
4285
4286 2019-06-25  Tom Tromey  <tom@tromey.com>
4287
4288         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4289         (struct tui_data_window, struct tui_cmd_window): Declare
4290         clear_detail method.
4291         * tui/tui-data.c (tui_source_window::clear_detail)
4292         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4293         methods.
4294         (tui_clear_win_detail): Simplify.
4295
4296 2019-06-25  Tom Tromey  <tom@tromey.com>
4297
4298         * tui/tui-layout.c (make_source_window, make_disasm_window)
4299         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4300         Return the new window.
4301         (show_source_disasm_command, show_data)
4302         (show_source_or_disasm_and_command): Update.
4303
4304 2019-06-25  Tom Tromey  <tom@tromey.com>
4305
4306         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4307         parameter.  Return the new window.
4308         (show_source_disasm_command): Update and remove NULL check.
4309         (show_source_or_disasm_and_command): Update.
4310
4311 2019-06-25  Tom Tromey  <tom@tromey.com>
4312
4313         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4314
4315 2019-06-25  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-data.h (struct tui_win_info): Make constructor
4318         protected.  Make destructor virtual.  Add initializers.
4319         (tui_source_window, tui_data_window, tui_cmd_window): New
4320         classes.
4321         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4322         constructor.  Add "type" parameter.
4323         (tui_source_window, tui_data_window, tui_cmd_window): New
4324         constructors.
4325         (tui_alloc_win_info): Instantiate the appropriate subclass.
4326
4327 2019-06-25  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-win.c (tui_resize_all): Use delete.
4330         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4331         destructor.
4332         (tui_free_window): Don't declare.
4333         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4334         Update.
4335
4336 2019-06-25  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-data.h (struct tui_win_info): Add constructor.
4339         * tui/tui-data.c (tui_alloc_win_info): Use new.
4340         (tui_free_window): Use delete.
4341
4342 2019-06-22  Tom Tromey  <tom@tromey.com>
4343
4344         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4345         declare.
4346         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4347
4348 2019-06-22  Tom Tromey  <tom@tromey.com>
4349
4350         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4351         declare.
4352         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4353
4354 2019-06-22  Tom de Vries  <tdevries@suse.de>
4355
4356         * dwarf2read.c (create_addrmap_from_aranges)
4357         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4358         instead of '%zu'.
4359
4360 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4361
4362         * dwarf2read.h (dwarf2_section_info_def): Remove.
4363         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4364         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4365         std::vector<dwarf2_section_info>.
4366         (struct dwo_file) <~dwo_file>: Remove.
4367         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4368         types field.
4369         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4370         (dwarf2_read_debug_names): Likewise.
4371         (create_debug_types_hash_table): Change parameter type to
4372         array_view, adjust code accordingly.
4373         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4374         (partial_die_info::fixup): Likewise.
4375         (determine_prefix): Likewise.
4376         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4377
4378 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4379
4380         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4381         gdb_bfd_ref_ptr.
4382         <~dwo_file>: Remove call to gdb_bfd_unref.
4383         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4384         gdb_bfd_ref_ptr::get.
4385
4386 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4387
4388         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4389         type to htab_up.
4390         * dwarf2read.c (struct dwo_file): Initialize fields.
4391         <~dwo_file>: New.
4392         (free_dwo_file): Remove, move content to ~dwo_file.
4393         (struct dwo_file_deleter): Remove.
4394         (dwo_file_up>: Remove custom deleter.
4395         (free_dwo_files): Remove.
4396         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4397         dwo_files.
4398         (process_skeletonless_type_units): Call unique_ptr::get.
4399         (allocate_dwo_file_hash_table): Add deleter to created hash
4400         table.  Change return type to htab_up.
4401         (lookup_dwo_file_slot): Don't memset dwo_file, call
4402         unique_ptr::get.
4403         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4404         (create_dwo_unit_in_dwp_v2): Likewise.
4405         (open_and_init_dwo_file): Likewise.
4406         (free_dwo_file_from_slot): Remove.
4407
4408 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4409
4410         * dwarf2read.h (struct dwarf2_section_info) <readin,
4411         is_virtual>: Change type to bool.
4412         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4413         true instead of 1.
4414
4415 2019-06-19  Tom Tromey  <tom@tromey.com>
4416
4417         * tui/tui-data.h (tui_init_content_element): Don't declare.
4418
4419 2019-06-19  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-data.h (tui_init_win_info): Don't declare.
4422
4423 2019-06-19  Tom de Vries  <tdevries@suse.de>
4424
4425         * dwarf2read.h (abstract_to_concrete): Change type to
4426         std::unordered_map<sect_offset, std::vector<sect_offset>,
4427         gdb::hash_enum<sect_offset>>.
4428
4429 2019-06-19  Tom Tromey  <tromey@adacore.com>
4430
4431         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4432         EVAL_AVOID_SIDE_EFFECTS specially.
4433
4434 2019-06-19  Tom Tromey  <tromey@adacore.com>
4435
4436         * source-cache.c (highlighter): New global.
4437         (source_cache::get_source_lines): Create a highlighter on demand.
4438
4439 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4440
4441         * defs.h (deprecated_interactive_hook): Delete declaration.
4442         * interps.c (clear_interpreter_hooks): Remove use of
4443         deprecated_interactive_hook.
4444         * top.c (deprecated_interactive_hook): Delete definition.
4445         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4446
4447 2019-06-18  Tom de Vries  <tdevries@suse.de>
4448
4449         PR gdb/24515
4450         * dwarf2read.h (abstract_to_concrete): Change type from
4451         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4452         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4453         * dwarf2read.c (read_variable): Update.
4454         (dwarf2_fetch_die_loc_sect_off): Update.
4455
4456 2019-06-17  Tom de Vries  <tdevries@suse.de>
4457
4458         PR gdb/24617
4459         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4460         accessing parent[parent_len - 1].
4461
4462 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4463
4464         PR gdb/24364
4465         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4466         call dtrace_process_dof with NULL dof.
4467
4468 2019-06-16  Tom de Vries  <tdevries@suse.de>
4469
4470         PR gdb/24445
4471         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4472
4473 2019-06-16  Tom Tromey  <tom@tromey.com>
4474
4475         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4476         (make_all_visible): Use address of member.
4477
4478 2019-06-16  Tom Tromey  <tom@tromey.com>
4479
4480         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4481         (tui_free_window, free_content, free_content_elements): Remove
4482         unnecessary cast.
4483         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4484         cast.
4485         * tui/tui-regs.c (tui_show_register_group)
4486         (tui_display_registers_from, tui_display_reg_element_at_line):
4487         Remove unnecessary cast.
4488
4489 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4490
4491         * linux-nat.c (normal_mask): Delete.
4492         (_initialize_linux_nat): Don't initialise normal_mask.
4493
4494 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4495
4496         PR gdb/24445
4497         * dwarf-index-write.h (write_psymtabs_to_index): Add
4498         dwz_basename parameter.
4499         * dwarf-index-write.c (write_gdbindex): Move file writing to
4500         write_gdbindex_1.  Change return type void.
4501         (assert_file_size): Move up, remove filename parameter.
4502         (write_gdbindex_1): New function.
4503         (write_debug_names): Change return type to void, call
4504         assert_file_size.
4505         (struct index_wip_file): New struct.
4506         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4507         file logic to index_wip_file.  Write index for dwz file if
4508         needed.
4509         (save_gdb_index_command): Pass basename of dwz file, if present.
4510         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4511         build-id of dwz file, if present.
4512         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4513         (dwarf2_get_dwz_file): Likewise.
4514         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4515         (dwarf2_get_dwz_file): Likewise.
4516
4517 2019-06-16  Tom Tromey  <tom@tromey.com>
4518
4519         * coffread.c (process_coff_symbol): Use xstrdup.
4520         * value.c (create_internalvar): Use xstrdup.
4521
4522 2019-06-16  Tom Tromey  <tom@tromey.com>
4523
4524         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4525         * breakpoint.c (stopin_command, stopat_command)
4526         (until_break_command, decode_location_default): Remove unnecessary
4527         cast.
4528         * utils.c (subset_compare): Remove unnecessary cast.
4529         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4530         cast.
4531         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4532         cast.
4533         * infcmd.c (path_command): Remove unnecessary cast.
4534         * coffread.c (decode_type): Remove unnecessary cast.
4535         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4536         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4537         * tui/tui-stack.c (tui_show_locator_content)
4538         (tui_show_frame_info): Remove unnecessary cast.
4539         * tui/tui-win.c (tui_scroll_forward_command)
4540         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4541         (parse_scrolling_args): Remove unnecessary cast.
4542         * tui/tui-data.c (init_win_info, tui_del_window)
4543         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4544         (free_content_elements): Remove unnecessary cast.
4545         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4546         unnecessary cast.
4547         * tui/tui-source.c (tui_set_source_content)
4548         (tui_vertical_source_scroll): Remove unnecessary cast.
4549         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4550         cast.
4551         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4552         * tui/tui-regs.c (tui_display_registers_from)
4553         (tui_display_register): Remove unnecessary cast.
4554         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4555         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4556         (make_visible): Remove unnecessary cast.
4557         * tui/tui-winsource.c (tui_erase_source_content)
4558         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4559         unnecessary cast.
4560         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4561         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4562         * stabsread.c (read_type, read_array_type, read_range_type):
4563         Remove unnecessary cast.
4564         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4565         (parse_symbol, parse_type, upgrade_type, parse_external)
4566         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4567         unnecessary cast.
4568         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4569
4570 2019-06-16  Tom Tromey  <tom@tromey.com>
4571
4572         * tui/tui-data.c (tui_alloc_generic_win_info)
4573         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4574         checks.
4575
4576 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4577             Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * f-typeprint.c (f_print_type): Don't return early for not
4580         associated or not allocated types.
4581         (f_type_print_varspec_suffix): Add print_rank parameter and print
4582         ranks of array types in case they dangling.
4583         (f_type_print_base): Add print_rank parameter.
4584
4585 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * NEWS: Mention new MI commands.
4588         * break-catch-throw.c (enum exception_event_kind): Move to
4589         breakpoint.h.
4590         (print_mention_exception_catchpoint): Output text as a single
4591         message.
4592         (catch_exception_command_1): Rename to...
4593         (catch_exception_event): ...this, make non-static, update header
4594         command, and change some parameter types.
4595         (catch_catch_command): Update for changes to
4596         catch_exception_command_1.
4597         (catch_throw_command): Likewise.
4598         (catch_rethrow_command): Likewise.
4599         * breakpoint.c (enum exception_event_kind): Delete.
4600         * breakpoint.h (enum exception_event_kind): Moved here from
4601         break-catch-throw.c.
4602         (catch_exception_event): Declare.
4603         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4604         (mi_cmd_catch_throw): New function.
4605         (mi_cmd_catch_rethrow): New function.
4606         (mi_cmd_catch_catch): New function.
4607         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4608         'catch-catch' entries.
4609         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4610         (mi_cmd_catch_rethrow): Declare.
4611         (mi_cmd_catch_catch): Declare.
4612
4613 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * annotate.c (annotate_source_line): Change return type to void,
4616         update implementation to match.
4617         * annotate.h (annotate_source_line): Change return type to void,
4618         update header comment.
4619         * stack.c (print_frame_info): Don't change what frame information
4620         is printed based on whether annotations are on or not.
4621
4622 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4623
4624         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4625         (annotate_source): Make static.
4626         (annotate_source_line): Moved from source.c and renamed from
4627         identify_source_line.  Update the return type.
4628         * annotate.h (annotate_source): Delete declaration.
4629         (annotate_source_line): Declaration moved from source.h, and
4630         renamed from identify_source_line.  Return type updated.
4631         * source.c (identify_source_line): Moved to annotate.c and renamed
4632         to annotate_source_line.
4633         (info_line_command): Remove check of annotation_level.
4634         * source.h (identify_source_line): Move declaration to annotate.h
4635         and rename to annotate_source_line.
4636         * stack.c: Add 'annotate.h' include.
4637         (print_frame_info): Remove check of annotation_level before
4638         calling annotate_source_line.
4639
4640 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * source-cache.c (source_cache::get_plain_source_lines): Use
4643         open_source_file_with_line_charpos instead of just
4644         open_source_file, remove call to find_source_lines.
4645         (source_cache::get_source_lines): Likewise.
4646         * source.c (find_source_lines): Make static.
4647         (get_filename_and_charpos): Renamed into...
4648         (open_source_file_with_line_charpos): ..this along with changes to
4649         return a scoped_fd, and some other minor clean ups.
4650         (identify_source_line): Use open_source_file_with_line_charpos.
4651         (search_command_helper): Use open_source_file_with_line_charpos
4652         instead of just open_source_file, remove call to
4653         find_source_lines.
4654         * source.h (open_source_file_with_line_charpos): Declare new
4655         function.
4656         (find_source_lines): Delete declaration.
4657
4658 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4659
4660         * source.c (get_filename_and_charpos): Remove fullname
4661         parameter.
4662         (identify_source_line): Update call to get_filename_and_charpos.
4663
4664 2019-06-14  Tom Tromey  <tromey@adacore.com>
4665
4666         PR gdb/24502:
4667         * ui-style.h (skip_ansi_escape): Update comment.
4668         * ui-file.h (class no_terminal_escape_file): New class.
4669         * ui-file.c (no_terminal_escape_file::write)
4670         (no_terminal_escape_file::puts): New methods.
4671         * cli/cli-logging.c (handle_redirections): Use
4672         no_terminal_escape_file.
4673
4674 2019-06-14  Tom Tromey  <tromey@adacore.com>
4675
4676         * NEWS: Move convenience variable news above Python news.
4677
4678 2019-06-14  Tom Tromey  <tom@tromey.com>
4679
4680         * gnulib: Move directory to top-level.
4681         * configure.ac: Don't configure gnulib.
4682         * configure: Rebuild.
4683         * common/common-defs.h: Use new path to gnulib.
4684         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4685         (GNULIB_H): Remove.
4686         (INCGNU): Look in new gnulib location.
4687         (HFILES_NO_SRCDIR): Remove gnulib files.
4688         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4689         (generated_files): Remove GNULIB_H.
4690         ($(LIBGNU), all-lib): Remove targets.
4691         (distclean): Don't mention GNULIB_BUILDDIR.
4692         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4693
4694 2019-06-14  Tom Tromey  <tromey@adacore.com>
4695
4696         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4697         Warn if symbol file does not provide any symbols.
4698
4699 2019-06-14  Tom Tromey  <tromey@adacore.com>
4700
4701         * source.c (find_and_open_source): Respect basenames_may_differ.
4702
4703 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4704
4705         * annotate.c (annotate_breakpoints_invalid): Make use of
4706         scoped_restore_terminal_state.
4707         (annotate_frames_invalid): Likewise.
4708
4709 2019-06-14  Tom Tromey  <tromey@adacore.com>
4710
4711         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4712         allow assignment to an internalvar.
4713
4714 2019-06-14  Tom Tromey  <tromey@adacore.com>
4715
4716         * ada-lex.l: Allow "_" in attribute names.
4717
4718 2019-06-14  Tom Tromey  <tromey@adacore.com>
4719
4720         PR gdb/24653:
4721         * regcache.c (registers_changed): Don't call alloca.
4722         * top.c (execute_command): Don't call alloca.
4723
4724 2019-06-13  Pedro Alves  <palves@redhat.com>
4725
4726         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4727         'expression'.  When parsing an expression, error out if there's
4728         junk after "unlimited".
4729         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4730         (do_set_command): Adjust calls to is_unlimited_literal.
4731
4732 2019-06-13  Pedro Alves  <palves@redhat.com>
4733
4734         * compile/compile.c (make_compile_options_def_group): Add braces
4735         around array_view initializer.
4736         * thread.c (make_thread_apply_all_options_def_group)
4737         (make_thread_apply_all_options_def_group): Likewise.
4738
4739 2019-06-13  Pedro Alves  <palves@redhat.com>
4740
4741         * NEWS (New commands): Mention "maint test-options
4742         require-delimiter", "maint test-options unknown-is-error", "maint
4743         test-options unknown-is-operand" and "maint show
4744         test-options-completion-result".
4745         (New command options, command completion): New section.
4746         (Completion improvements): New section.
4747         Mention that you can abbreviate "unlimited".
4748
4749 2019-06-13  Pedro Alves  <palves@redhat.com>
4750
4751         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4752         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4753         * unittests/cli-utils-selftests.c (test_parse_flags)
4754         (test_parse_flags_qcs): Delete.
4755         (test_cli_utils): Don't call deleted functions.
4756
4757 2019-06-13  Pedro Alves  <palves@redhat.com>
4758
4759         * thread.c: Include "cli/cli-option.h".
4760         (tp_array_compar_ascending): Global.
4761         (tp_array_compar): Delete function.
4762         (tp_array_compar_ascending, tp_array_compar_descending): New
4763         functions.
4764         (ascending_option_def, qcs_flag_option_def)
4765         (thr_qcs_flags_option_defs)
4766         (make_thread_apply_all_options_def_group)
4767         (make_thread_apply_options_def_group): New.
4768         (thread_apply_all_command): Use gdb::option::process_options.
4769         (thread_apply_command_completer)
4770         (thread_apply_all_command_completer): New.
4771         (thread_apply_command): Use gdb::option::process_options.
4772         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4773         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4774         to generate help text of "thread apply".  Adjust "taas"'s help.
4775         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4776         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4777
4778 2019-06-13  Pedro Alves  <palves@redhat.com>
4779
4780         * thread.c (thread_apply_command): Check for invalid TID with
4781         isdigit instead of !isalpha.
4782
4783 2019-06-13  Pedro Alves  <palves@redhat.com>
4784
4785         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4786         (validate_flags_qcs): New.
4787         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4788         (validate_flags_qcs): Declare.
4789         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4790         (make_frame_apply_options_def_group): New.
4791         (frame_apply_command_count): Process options with
4792         gdb::option::process_options.
4793         (frame_apply_completer): New.
4794         (frame_apply_level_completer, frame_apply_all_completer)
4795         (frame_apply_completer): New.
4796         (_initialize_stack): Update help of "frame apply", "frame apply
4797         level", "frame apply all" and "faas" to mention supported options
4798         and install command completers.
4799         * stack.h (frame_apply_all_completer): Declare.
4800         * thread.c: Include "stack.h".
4801         (tfaas_command): Add "--".
4802         (_initialize_thread): Update help "tfaas" to mention supported
4803         options and install command completer.
4804
4805 2019-06-13  Pedro Alves  <palves@redhat.com>
4806
4807         * completer.c (complete_nested_command_line): New.
4808         (gdb_completion_word_break_characters_throw): Add assertion.
4809         * completer.h (complete_nested_command_line): Declare.
4810
4811 2019-06-13  Pedro Alves  <palves@redhat.com>
4812
4813         * stack.c (parse_backtrace_qualifiers): New.
4814         (backtrace_command): Use it.
4815         (backtrace_command_completer): Complete on qualifiers.
4816
4817 2019-06-13  Pedro Alves  <palves@redhat.com>
4818
4819         * frame.c: Include "cli/cli-option.h.
4820         (user_set_backtrace_options): New.
4821         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4822         Delete.
4823         (get_prev_frame): Adjust.
4824         (boolean_option_def, uinteger_option_def)
4825         (set_backtrace_option_defs): New.
4826         (_initialize_frame): Adjust and use
4827         gdb::option::add_setshow_cmds_for_options to install "set
4828         backtrace past-main" and "set backtrace past-entry".
4829         * frame.h: Include "cli/cli-option.h".
4830         (struct frame_print_options): Forward declare.
4831         (print_frame_arguments_all, print_frame_arguments_scalars)
4832         (print_frame_arguments_none): Declare.
4833         (print_entry_values): Delete declaration.
4834         (struct frame_print_options, user_frame_print_options): New.
4835         (struct set_backtrace_options): New.
4836         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4837         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4838         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4839         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4840         (list_args_or_locals): Add frame_print_options parameter.
4841         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4842         * python/py-framefilter.c (enumerate_args): Pass down
4843         USER_FRAME_PRINT_OPTIONS.
4844         * stack.c: Include "cli/cli-option.h".
4845         (print_frame_arguments_all, print_frame_arguments_scalars)
4846         (print_frame_arguments_none): Declare.
4847         (print_raw_frame_arguments, print_entry_values): Delete.
4848         (user_frame_print_options): New.
4849         (boolean_option_def, enum_option_def, frame_print_option_defs):
4850         New.
4851         (struct backtrace_cmd_options): New.
4852         (bt_flag_option_def): New.
4853         (backtrace_command_option_defs): New.
4854         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4855         (print_frame_arg, read_frame_arg, print_frame_args)
4856         (print_frame_info, print_frame): Add frame_print_options parameter
4857         and use it.
4858         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4859         (backtrace_command_1): Add frame_print_options and
4860         backtrace_cmd_options parameters and use them.
4861         (make_backtrace_options_def_group): New.
4862         (backtrace_command): Process command options with
4863         gdb::option::process_options.
4864         (backtrace_command_completer): New.
4865         (_initialize_stack): Extend "backtrace"'s help to mention
4866         supported options.  Install completer for "backtrace".
4867         Install some settings commands with add_setshow_cmds_for_options.
4868
4869 2019-06-13  Pedro Alves  <palves@redhat.com>
4870
4871         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4872         and that "set/show print raw frame-arguments" are now deprecated.
4873
4874         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4875         command.
4876         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4877         * stack.c (_initialize_stack): Install "set/show print
4878         raw-frame-arguments", and deprecate "set/show print raw
4879         frame-arguments".
4880         * valprint.c (_initialize_valprint): Deprecate "set/show print
4881         raw".
4882
4883 2019-06-13  Pedro Alves  <palves@redhat.com>
4884
4885         * compile/compile.c (struct compile_options): New.
4886         (compile_flag_option_def, compile_command_option_defs)
4887         (make_compile_options_def_group): New.
4888         (compile_file_command): Handle options with
4889         gdb::option::process_options.
4890         (compile_file_command_completer): New function.
4891         (compile_code_command): Handle options with
4892         gdb::option::process_options.
4893         (compile_code_command_completer): New function.
4894         (_initialize_compiler): Install completers for "compile code" and
4895         "compile file".  Mention available options in "compile code" and
4896         "compile code"'s help.
4897         * completer.c (advance_to_completion_word): New, factored out from
4898         ...
4899         (advance_to_expression_complete_word_point): ... this.
4900         (advance_to_filename_complete_word_point): New.
4901         * completer.h (advance_to_filename_complete_word_point): New
4902         declaration.
4903
4904 2019-06-13  Pedro Alves  <palves@redhat.com>
4905
4906         * compile/compile.c: Include "cli/cli-option.h".
4907         (compile_print_value): Scope data pointer is now a
4908         value_print_options pointer; adjust.
4909         (compile_print_command): Process options.  Scope data pointer is
4910         now a value_print_options pointer; adjust.
4911         (_initialize_compile): Update "compile print"'s help to include
4912         supported options.  Install a completer for "compile print".
4913         * cp-valprint.c (show_vtblprint, show_objectprint)
4914         (show_static_field_print): Delete.
4915         (_initialize_cp_valprint): Don't install "set print
4916         static-members", "set print vtbl", "set print object" here.
4917         * printcmd.c: Include "cli/cli-option.h" and
4918         "common/gdb_optional.h".
4919         (print_command_parse_format): Rework to fill in a
4920         value_print_options instead of a format_data.
4921         (print_value): Change parameter type from format_data pointer to
4922         value_print_options reference.  Adjust.
4923         (print_command_1): Process options.  Adjust to pass down a
4924         value_print_options.
4925         (print_command_completer): New.
4926         (_initialize_printcmd): Install print_command_completer as
4927         handle_brkchars completer for the "print" command.  Update
4928         "print"'s help to include supported options.
4929         * valprint.c: Include "cli/cli-option.h".
4930         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4931         here from cp-valprint.c.
4932         (boolean_option_def, uinteger_option_def)
4933         (value_print_option_defs, make_value_print_options_def_group):
4934         New.  Use gdb::option::add_setshow_cmds_for_options to install
4935         "set print elements", "set print null-stop", "set print repeats",
4936         "set print pretty", "set print union", "set print array", "set
4937         print address", "set print symbol", "set print array-indexes".
4938         * valprint.h: Include <string> and "cli/cli-option.h".
4939         (make_value_print_options_def_group): Declare.
4940         (print_value): Change parameter type from format_data pointer to
4941         value_print_options reference.
4942         (print_command_completer): Declare.
4943
4944 2019-06-13  Pedro Alves  <palves@redhat.com>
4945
4946         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4947         (COMMON_SFILES): Add maint-test-settings.c.
4948         * cli/cli-decode.c (boolean_enums): New global, factored out from
4949         ...
4950         (add_setshow_boolean_cmd): ... here.
4951         * cli/cli-decode.h (boolean_enums): Declare.
4952         * cli/cli-option.c: New file.
4953         * cli/cli-option.h: New file.
4954         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4955         factored out from ...
4956         (parse_cli_boolean_value(const char *)): ... this.
4957         (is_unlimited_literal): Change parameter type to pointer to
4958         pointer.  Adjust and advance ARG pointer.
4959         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4960         (parse_cli_var_enum): New, factored out from ...
4961         (do_set_command): ... this.  Adjust.
4962         * cli/cli-setshow.h (parse_cli_boolean_value)
4963         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4964         (parse_cli_var_enum): Declare.
4965         * cli/cli-utils.c: Include "cli/cli-option.h".
4966         (get_ulongest): New.
4967         * cli/cli-utils.h (get_ulongest): Declare.
4968         (check_for_argument): New overloads.
4969         * maint-test-options.c: New file.
4970
4971 2019-06-13  Pedro Alves  <palves@redhat.com>
4972
4973         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4974         parse a range if "-" is at the end of the string.
4975
4976 2019-06-13  Pedro Alves  <palves@redhat.com>
4977
4978         * cli/cli-setshow.c (parse_auto_binary_operation)
4979         (parse_cli_boolean_value): Don't allow "o".
4980
4981 2019-06-13  Pedro Alves  <palves@redhat.com>
4982
4983         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4984         * NEWS: Mention maint test-settings KIND.
4985         * maint-test-settings.c: New file.
4986
4987 2019-06-13  Pedro Alves  <palves@redhat.com>
4988
4989         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4990         completer.
4991         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4992         "set" completers.
4993
4994 2019-06-13  Pedro Alves  <palves@redhat.com>
4995
4996         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4997         after item.
4998
4999 2019-06-13  Pedro Alves  <palves@redhat.com>
5000
5001         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5002
5003 2019-06-13  Pedro Alves <palves@redhat.com>
5004
5005         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5006         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5007         call.
5008         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5009         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5010         calls.
5011         (check_for_argument): Skip spaces after argument.
5012
5013 2019-06-13  Pedro Alves  <palves@redhat.com>
5014
5015         * thread.c (thread_apply_command): Adjust TID parsing.
5016         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5017         detected before end of string.
5018         (tid_is_in_list): Error out if LIST is invalid.
5019
5020 2019-06-13  Pedro Alves  <palves@redhat.com>
5021
5022         * completer.c (complete_line_internal_1): Rewind completion word
5023         point.
5024         (completion_tracker::advance_custom_word_point_by): Change
5025         parameter type to int.
5026         * completer.h (completion_tracker::advance_custom_word_point_by):
5027         Likewise.
5028
5029 2019-06-13  Pedro Alves  <palves@redhat.com>
5030
5031         * completer.c (advance_to_completion_word): Handle delimiters.
5032
5033 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5034
5035         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5036
5037 2019-06-11  Tom Tromey  <tom@tromey.com>
5038
5039         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5040         (xmalloc_failed): Move to alloc.c.
5041         * alloc.c: New file.
5042         * Makefile.in (COMMON_SFILES): Add alloc.c.
5043
5044 2019-06-11  Tom Tromey  <tom@tromey.com>
5045
5046         * nat/linux-waitpid.c: Don't include server.h.
5047         (linux_debug): Remove.
5048         (my_waitpid): Update.
5049
5050 2019-06-11  Tom Tromey  <tromey@adacore.com>
5051
5052         * infcall.c (_initialize_infcall): Remove trailing newline from
5053         help.
5054         * user-regs.c (_initialize_user_regs): Remove trailing newline
5055         from help.
5056         * typeprint.c (_initialize_typeprint): Remove trailing newline
5057         from help.
5058         * reverse.c (_initialize_reverse): Remove trailing newlines from
5059         help.
5060         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5061         from help.
5062         * language.c (add_set_language_command): Remove trailing newline
5063         from help.
5064         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5065         help.
5066         * disasm.c (_initialize_disasm): Remove trailing newline from
5067         help.
5068         * top.c (init_main): Remove trailing newline from help.
5069         * interps.c (_initialize_interpreter): Remove trailing newline
5070         from help.
5071         * btrace.c (_initialize_btrace): Remove trailing newlines from
5072         help.
5073         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5074         from help.
5075         * python/python.c (_initialize_python): Remove trailing newline
5076         from help.
5077         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5078         help.
5079         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5080         from help.  Reformat some text.
5081         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5082         from help.
5083         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5084         newline from help.
5085
5086 2019-06-11  Tom Tromey  <tromey@adacore.com>
5087
5088         * darwin-nat.c (darwin_decode_exception_message)
5089         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5090
5091 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5092
5093         * valops.c (value_slice): Check for not allocated or not
5094         associated values.
5095
5096 2019-06-10  Tom de Vries  <tdevries@suse.de>
5097
5098         PR gdb/24618
5099         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5100         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5101         invalid.
5102
5103 2019-06-10  Tom de Vries  <tdevries@suse.de>
5104
5105         PR gdb/24611
5106         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5107         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5108
5109 2019-06-10  Tom de Vries  <tdevries@suse.de>
5110
5111         PR symtab/24545
5112         * symtab.c (struct demangled_name_entry): Add language field.
5113         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5114         static minimal symbol".  Set and use language field.
5115
5116 2019-06-10  Tom Tromey  <tromey@adacore.com>
5117
5118         * ada-lang.c (_initialize_ada_language): Update help text.
5119
5120 2019-06-10  Tom Tromey  <tromey@adacore.com>
5121
5122         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5123         with a newline.
5124         * guile/guile.c (handle_boot_error): Don't end warning with a
5125         newline.
5126         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5127         warning with a newline.
5128         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5129         newline.
5130         (s12z_frame_cache): Likewise.
5131         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5132         a newline.
5133         * solib-svr4.c (disable_probes_interface): Don't end warning with
5134         a newline.
5135         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5136         newline.
5137         * python/python.c (do_finish_initialization): Don't end warning
5138         with a newline.
5139
5140 2019-06-10  Tom Tromey  <tom@tromey.com>
5141
5142         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5143         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5144         gdbpy_enter.
5145
5146 2019-06-10  Tom Tromey  <tromey@adacore.com>
5147
5148         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5149         data.
5150         (elf_new_init): Don't call stabsread_new_init.
5151         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5152         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5153         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5154
5155 2019-06-10  Tom de Vries  <tdevries@suse.de>
5156
5157         PR symtab/16264
5158         PR symtab/24517
5159         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5160
5161 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5162
5163         * source.c (find_and_open_source): Also rewrite relative file
5164         names.
5165
5166 2019-04-26  Amos Bird  <amosbird@gmail.com>
5167
5168         * annotate.c (annotate_thread_exited): Add "thread-exited"
5169         annotation.
5170
5171 2019-06-06  Tom Tromey  <tromey@adacore.com>
5172
5173         * maint.h (class scoped_command_stats): Use
5174         DISABLE_COPY_AND_ASSIGN.
5175         <print_time>: New method.
5176         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5177         print_time.
5178         (scoped_command_stats::print_time): New method.
5179
5180 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5181
5182         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5183         instructions of lengths 6 or 8 bytes.
5184
5185 2019-06-04  Pedro Alves  <palves@redhat.com>
5186
5187         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5188
5189         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5190         * breakpoint.c (condition_completer): Likewise.
5191         * cli/cli-dump.c (scan_expression): Likewise.
5192         * common/filestuff.c (mkdir_recursive): Likewise.
5193         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5194         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5195         (gdb_abspath): Likewise.
5196         * compile/compile-cplus-types.c
5197         (compile_cplus_instance::decl_name): Likewise.
5198         * completer.c (complete_explicit_location):
5199         (signal_completer, reg_or_group_completer_1): Likewise.
5200         * cp-support.c (cp_remove_params_if_any): Likewise.
5201         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5202         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5203         * infcmd.c (strip_bg_char): Likewise.
5204         * linespec.c (copy_token_string): Likewise.
5205         * mi/mi-main.c (output_cores): Likewise.
5206         * psymtab.c (psymtab_search_name):
5207         * symfile.c (test_set_ext_lang_command): Likewise.
5208         * target.c (target_fileio_read_stralloc): Likewise.
5209         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5210         * value.c (complete_internalvar): Likewise.
5211
5212 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5213
5214         Add objfile property to gdb.Type.
5215         * NEWS: Mention Python API addition.
5216         * python/py-type.c (typy_get_objfile): New method.
5217
5218 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5219
5220         * NEWS: Mention the new set|show style [title|highlight].
5221         Mention changes to "show style", "help" and "apropos".
5222
5223 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5224
5225         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5226         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5227         instead of print_help_for_command.
5228         (print_doc_of_command): New function.
5229         (help_list): Add 'apropos -v word' suggestion.
5230         (print_help_for_command): Style the command name using title style.
5231         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5232         (_initialize_cli_cmds): Describe -v in apropos_command help.
5233
5234 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5235
5236         * cli/cli-style.h (cli_style_option): Add name in constructor,
5237         add m_name class member, add constructor with intensity,
5238         add name class function.
5239         (cli_style_option::add_setshow_commands): Remove name argument.
5240         (highlight_style, title_style): New styles.
5241         * cli/cli-style.c (do_show): New function that shows a style
5242         characteristic styling the style name with itself.
5243         (set_style_name): New function.
5244         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5245         Update all callers according to the changes in cli/cli-style.h.
5246         * utils.h (fputs_highlighted): New function.
5247         * utils.c (fputs_highlighted): Likewise.
5248
5249 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5250
5251         * NEWS: Mention new pipe command and new convenience variables.
5252
5253 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5254
5255         * cli/cli-cmds.c (pipe_command): New function.
5256         (_initialize_cli_cmds): Call add_com for pipe_command.
5257         Define | as an alias for pipe.
5258         (exit_status_set_internal_vars): New function.
5259         (shell_escape): Call exit_status_set_internal_vars.
5260         cli/cli-decode.c (find_command_name_length): Recognize | as
5261         a single character command.
5262
5263 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5264
5265         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5266         top.c (execute_command_to_ui_file): New function, mostly a copy
5267         of execute_command_to_string.
5268         (execute_command_to_string): Implement by calling
5269         execute_command_to_ui_file.
5270
5271 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5272
5273         * top.h (saved_command_line): Remove declaration.
5274         * top.c (previous_saved_command_line, previous_repeat_arguments):
5275         New variables.
5276         (saved_command_line): Make static, define together with other
5277         'repeat variables'.
5278         (dont_repeat): Clear repeat_arguments.
5279         (repeat_previous, get_saved_command_line, save_command_line):
5280         New functions.
5281         (gdb_init): Initialize saved_command_line
5282         and previous_saved_command_line.
5283         * main.c (captured_main_1): Remove saved_command_line initialization.
5284         * event-top.c (handle_line_of_input): Update to use
5285         the new 'repeat' related functions instead of direct access to
5286         saved_command_line.
5287         * command.h (repeat_previous, get_saved_command_line,
5288         save_command_line): New declarations.
5289         (dont_repeat): Add comment.
5290
5291 2019-05-30  Tom Tromey  <tromey@adacore.com>
5292
5293         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5294         Fix comment.
5295         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5296
5297 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5298
5299         PR cli/24587
5300         * completer.c (complete): Initialize variable word.
5301
5302 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5303
5304         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5305         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5306         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5307         'body' is NULL to the outter 'if', protecting the '!is_define'
5308         situation as well.
5309
5310 2019-05-29  Tom Tromey  <tromey@adacore.com>
5311
5312         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5313         (dwarf_unknown): New function.
5314         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5315         (dwarf_type_encoding_name): Use dwarf_unknown.
5316
5317 2019-05-29  Tom Tromey  <tromey@adacore.com>
5318
5319         PR c++/20020:
5320         * cp-valprint.c (cp_print_value_fields): Call
5321         cp_print_static_field inside "try".
5322
5323 2019-05-29  Tom Tromey  <tromey@adacore.com>
5324
5325         * inflow.c (struct terminal_info): Add default operator=.
5326         * configure: Rebuild.
5327         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5328         -Wdeprecated-copy-dtor, -Wredundant-move.
5329
5330 2019-05-29  Tom Tromey  <tromey@adacore.com>
5331
5332         * NEWS: Add entry.
5333         * infcmd.c (print_return_value_1): Handle finish_print
5334         option.
5335         (show_print_finish): New function.
5336         (_initialize_infcmd): Add "set/show print finish" commands.
5337         * valprint.c (user_print_options): Initialize new member.
5338         * valprint.h (struct value_print_options) <finish_print>: New
5339         member.
5340
5341 2019-05-28  Tom Tromey  <tromey@adacore.com>
5342
5343         * ada-lang.c (ada_remove_Xbn_suffix)
5344         (find_old_style_renaming_symbol)
5345         (parse_old_style_renaming): Remove.
5346         (ada_find_renaming_symbol): Don't call
5347         find_old_style_renaming_symbol.
5348         (ada_is_renaming_symbol): Rename from
5349         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5350         bool.  Now static.
5351         (ada_read_var_value): Update and simplify.
5352         * ada-exp.y (write_var_or_type): Remove old code.
5353
5354 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5355
5356         * event-top.c: Remove include comment.
5357         * inflow.c (class scoped_ignore_sigttou): Move from here...
5358         * inflow.h (class scoped_ignore_sigttou): ...to here.
5359         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5360         * top.c:  Remove include comment.
5361
5362 2019-05-27  Tom Tromey  <tom@tromey.com>
5363
5364         * NEWS: Fix typo.
5365
5366 2019-05-22  Tom Tromey  <tromey@adacore.com>
5367
5368         * target.c (target_follow_exec): Constify parameter.
5369         * target-delegates.c: Rebuild.
5370         * remote.c (remote_target::follow_exec): Constify parameter.
5371         * infrun.c (follow_exec): Constify parameter.
5372         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5373         (target_follow_exec): Likewise.
5374
5375 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5376
5377         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5378         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5379
5380 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5381
5382         * NEWS: Add debugredirect and testsuite sections.
5383
5384 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5385
5386         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5387         target descriptions using exclusively floating point register name
5388         aliases.
5389
5390 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5391
5392         PR gdb/18644:
5393         * f-lang.c (build_fortran_types): Handle the case where
5394         gdbarch_floatformat_for_type returns a nullptr.
5395
5396 2019-05-21  Tom de Vries  <tdevries@suse.de>
5397
5398         PR cli/24587
5399         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5400
5401 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         PR gdb/18644:
5404         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5405         16-byte floats.
5406         * i386-tdep.c (i386_floatformat_for_type): Use
5407         floatformats_ia64_quad for the 16-byte floating point component
5408         within a fortran 32-byte complex number.
5409
5410 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5411
5412         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5413         delete default constructor.
5414         (find_partial_die): Update to return const struct.
5415         (partial_die_parent_scope): Move variable declaration into scope
5416         of its use and change its type to auto.
5417         (guess_partial_die_structure_name): Likewise.
5418         (partial_die_info::fixup): Likewise.
5419
5420 2019-05-17  Tom Tromey  <tromey@adacore.com>
5421
5422         * source.c (find_and_open_source): Remove cast.
5423
5424 2019-05-17  Tom Tromey  <tromey@adacore.com>
5425
5426         * annotate.c (annotate_source): Make "filename" const.
5427         * annotate.h (annotate_source): Use const.
5428
5429 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5430
5431         * disasm.c (set_disassembler_options): Send errors to stderr.
5432
5433 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5434
5435         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5436         (cli_interp_base::set_logging): Check debug_redirect.
5437         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5438         * cli/cli-logging.c (debug_redirect): Add static variable.
5439         (pop_output_files): Add default param.
5440         (handle_redirections): Print debug setting.
5441         (show_logging_command): Likewise.
5442         (_initialize_cli_logging): Add debugredirect command.
5443         * interps.c (current_interp_set_logging): Add debug_redirect
5444         parameter.
5445         * interps.h (set_logging): Add debug_redirect parameter.
5446         (current_interp_set_logging): Likewise.
5447         * mi/mi-common.h: Likewise.
5448         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5449
5450 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5451             Tom Tromey  <tromey@adacore.com>
5452
5453         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5454         directly.
5455         * cli/cli-interp.h (make_logging_output): Remove declaration.
5456         * cli/cli-logging.c (make_logging_output): Remove function.
5457         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5458         directly.
5459         * ui-file.c (tee_file::tee_file): Remove bools.
5460         (tee_file::~tee_file): Remove deletes.
5461         * ui-file.h (tee_file): Remove bools.
5462
5463 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5464
5465         * mi/mi-cmds.h (mi_cmd_complete): New function.
5466         * mi/mi-main.c (mi_cmd_complete): Likewise.
5467         * mi/mi-cmds.c: Define new MI command -complete.
5468         * NEWS: Mention new -complete command.
5469
5470 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5471
5472         * completer.h (complete): New function.
5473         * completer.c (complete): Likewise.
5474         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5475         function defined in completer.h.
5476
5477 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5478
5479         * MAINTAINERS (Write After Approval): Add myself.
5480
5481 2019-05-17  Tom de Vries  <tdevries@suse.de>
5482
5483         PR gdb/24094
5484         * dwarf2read.c (struct cu_partial_die_info): New struct.
5485         (find_partial_die): Return cu_partial_die_info.
5486         (partial_die_parent_scope, guess_partial_die_structure_name)
5487         (partial_die_info::fixup): Handle new return type of find_partial_die.
5488
5489 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5490
5491         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5492         "std::string", simplifying the algorithm.
5493
5494 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5495
5496         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5497         (stap_static_probe_ops::get_probes): Likewise.
5498
5499 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5500
5501         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5502         '-')" and "else if".
5503         (stap_parse_single_operand): Join checks for
5504         "gdbarch_stap_parse_special_token_p" and
5505         "gdbarch_stap_parse_special_token" in the same "if" statement.
5506         Invert check when verifying for operation on register
5507         displacement.
5508
5509 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5510
5511         * stap-probe.c (stap_get_opcode): Update comment.
5512         (stap_get_expected_argument_type): Likewise.
5513         (handle_stap_probe): Likewise.
5514
5515 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5516
5517         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5518         return type to 'bool'.  Adjust comment.  Use 'bool' when
5519         appropriate.
5520         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5521         * stap-probe.c (stap_parse_argument_1): Likewise.
5522         (stap_is_operator): Likewise.
5523         (stap_is_generic_prefix): Likewise.
5524         (stap_is_register_prefix): Likewise.
5525         (stap_is_register_indirection_prefix): Likewise.
5526         (stap_is_integer_prefix): Likewise.
5527         (stap_generic_check_suffix): Likewise.
5528         (stap_check_integer_suffix): Likewise.
5529         (stap_check_register_suffix): Likewise.
5530         (stap_check_register_indirection_suffix): Likewise.
5531         (stap_parse_register_operand): Likewise.
5532         (stap_parse_single_operand): Likewise.
5533         (stap_parse_argument_1): Likewise.
5534         (stap_probe::get_argument_count): Likewise.
5535         (stap_is_operator): Likewise.
5536
5537 2019-05-16  Tom Tromey  <tromey@adacore.com>
5538
5539         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5540         keyword to foreach.
5541
5542 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5543
5544         * linux-thread-db.c (try_thread_db_load_1): Change return type
5545         to bool.
5546         (try_thread_db_load): Likewise.
5547         (try_thread_db_load_from_pdir_1): Likewise.
5548         (try_thread_db_load_from_pdir): Likewise.
5549         (try_thread_db_load_from_sdir): Likewise.
5550         (try_thread_db_load_from_dir): Likewise.
5551         (thread_db_load_search): Likewise.
5552         (has_libpthread): Likewise.
5553         (thread_db_load): Likewise.
5554
5555 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5556
5557         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5558         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5559         NULL, and complain/return if that's the case.
5560
5561 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5562
5563         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5564         (advance, posn, abstract_read_memory): New functions.
5565         [struct mem_read_abstraction]: New struct.
5566         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5567
5568 2019-05-14  Tom Tromey  <tromey@adacore.com>
5569
5570         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5571         value is not lval_memory.
5572
5573 2019-05-14  Tom Tromey  <tromey@adacore.com>
5574
5575         * solib.c (info_sharedlibrary_command): Style the file name.
5576
5577 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5578
5579         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5580         (aarch64_vnv_type): Likewise.
5581         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5582         * common/tdesc.c: Likewise.
5583         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5584         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5585         * features/aarch64-fpu.xml: Add ieee half view.
5586         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5587         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5588         * gdbtypes.h (struct builtin_type): Likewise.
5589         (struct objfile_type): Likewise.
5590
5591 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5592
5593         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5594         typo.
5595         * location.h (string_to_event_location): Likewise.
5596
5597 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5598
5599         GDB 8.3 released.
5600
5601 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5602
5603         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5604         New variable declaration.
5605         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5606         New variable.
5607         (print_one_breakpoint): Use ui_out::test_flags and new global
5608         variable to compute use_fixed_output.
5609         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5610         Remove.
5611         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5612         (mi_multi_location_breakpoint_output_fixed): Remove.
5613         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5614         new variable.
5615         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5616         fix_multi_location_breakpoint_output flag if version >= 3.
5617         * ui-out.h (enum ui_out_flag)
5618         <fix_multi_location_breakpoint_output>: New enumerator.
5619
5620 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5621
5622         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5623
5624 2019-05-10  Tom Tromey  <tromey@adacore.com>
5625
5626         * ada-lang.c (catch_ada_completer): New function.
5627         (_initialize_ada_language): Use it.
5628
5629 2019-05-10  Tom Tromey  <tromey@adacore.com>
5630
5631         * thread.c (print_thread_info): Make "requested_threads" const.
5632         * gdbthread.h (print_thread_info): Make "requested_threads"
5633         const.
5634         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5635         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5636
5637 2019-05-08  Tom Tromey  <tom@tromey.com>
5638
5639         * gdbtypes.c (objfile_type_data): Change type.
5640         (objfile_type, _initialize_gdbtypes): Update.
5641
5642 2019-05-08  Tom Tromey  <tom@tromey.com>
5643
5644         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5645         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5646         (_initialize_dwarf2_frame): Update.
5647
5648 2019-05-08  Tom Tromey  <tom@tromey.com>
5649
5650         * objc-lang.c (objc_objfile_data): Change type.
5651         (find_methods): Update.
5652         (_initialize_objc_lang): Remove.
5653
5654 2019-05-08  Tom Tromey  <tom@tromey.com>
5655
5656         * stabsread.c (rs6000_builtin_type_data): Change type.
5657         (rs6000_builtin_type, _initialize_stabsread): Update.
5658
5659 2019-05-08  Tom Tromey  <tom@tromey.com>
5660
5661         * mips-tdep.c (mips_pdr_data): Remove.
5662         (_initialize_mips_tdep): Update.
5663
5664 2019-05-08  Tom Tromey  <tom@tromey.com>
5665
5666         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5667         (hppa_init_objfile_priv_data, read_unwind_info)
5668         (find_unwind_entry, _initialize_hppa_tdep): Update.
5669
5670 2019-05-08  Tom Tromey  <tom@tromey.com>
5671
5672         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5673         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5674         on obstack.
5675         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5676
5677 2019-05-08  Tom Tromey  <tom@tromey.com>
5678
5679         * mdebugread.c (basic_type_data): Change type.
5680         (basic_type, _initialize_mdebugread): Update.
5681
5682 2019-05-08  Tom Tromey  <tom@tromey.com>
5683
5684         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5685
5686 2019-05-08  Tom Tromey  <tom@tromey.com>
5687
5688         * nto-tdep.c (nto_inferior_data_reg): Change type.
5689         (nto_inferior_data): Update.
5690         (nto_inferior_data_cleanup, nto_new_inferior_data)
5691         (_initialize_nto_tdep): Remove.
5692         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5693
5694 2019-05-08  Tom Tromey  <tom@tromey.com>
5695
5696         * ada-lang.c (struct ada_inferior_data): Add initializers.
5697         (ada_inferior_data): Change type.
5698         (ada_inferior_data_cleanup): Remove.
5699         (get_ada_inferior_data, ada_inferior_exit)
5700         (struct ada_pspace_data): Add initializers, destructor.
5701         (ada_pspace_data_handle): Change type.
5702         (get_ada_pspace_data): Update.
5703         (ada_pspace_data_cleanup): Remove.
5704
5705 2019-05-08  Tom Tromey  <tom@tromey.com>
5706
5707         * coffread.c (struct coff_symfile_info): Add initializers.
5708         (coff_objfile_data_key): Move lower.  Change type.
5709         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5710         Update.
5711         (coff_free_info): Remove.
5712
5713 2019-05-08  Tom Tromey  <tom@tromey.com>
5714
5715         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5716         (fbsd_pspace_data_handle): Move lower.  Change type.
5717         (get_fbsd_pspace_data): Update.
5718         (fbsd_pspace_data_cleanup): Remove.
5719         (_initialize_fbsd_tdep): Update.
5720
5721 2019-05-08  Tom Tromey  <tom@tromey.com>
5722
5723         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5724         (get_ada_tasks_pspace_data): Update.
5725         (ada_tasks_pspace_data_cleanup): Remove.
5726         (_initialize_tasks): Update.
5727         (ada_tasks_inferior_data_handle): Change type.
5728         (get_ada_tasks_inferior_data): Update.
5729         (ada_tasks_inferior_data_cleanup): Remove.
5730         (struct ada_tasks_pspace_data): Add initializers.
5731
5732 2019-05-08  Tom Tromey  <tom@tromey.com>
5733
5734         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5735         * symfile-debug.c (debug_sym_get_probes): Change type.
5736         * stap-probe.c (handle_stap_probe):
5737         (stap_static_probe_ops::get_probes): Change type.
5738         * probe.h (class static_probe_ops) <get_probes>: Change type.
5739         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5740         (parse_probes_in_pspace): Update.
5741         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5742         Update.
5743         (any_static_probe_ops::get_probes): Change type.
5744         * elfread.c (elfread_data): New typedef.
5745         (probe_key): Change type.
5746         (elf_get_probes): Likewise.  Update.
5747         (probe_key_free): Remove.
5748         (_initialize_elfread): Update.
5749         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5750         Change type.
5751         (dtrace_process_dof_probe, dtrace_process_dof)
5752         (dtrace_static_probe_ops::get_probe): Change type.
5753
5754 2019-05-08  Tom Tromey  <tom@tromey.com>
5755
5756         * xcoffread.c (struct xcoff_symfile_info): Rename from
5757         coff_symfile_info.  Add initializers.
5758         (xcoff_objfile_data_key): Move lower.  Change type.
5759         (XCOFF_DATA): Rewrite.
5760         (xcoff_free_info): Remove.
5761         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5762         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5763         (xcoff_initial_scan): Update.
5764
5765 2019-05-08  Tom Tromey  <tom@tromey.com>
5766
5767         * solib-svr4.c (struct svr4_info): Add initializers and
5768         destructor.
5769         <probes_table>: Now an htab_up.
5770         (solib_svr4_pspace_data): Change type.
5771         (free_probes_table): Simplify.
5772         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5773         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5774         (probes_table_remove_objfile_probes, register_solib_event_probe)
5775         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5776         (_initialize_svr4_solib): Update.
5777
5778 2019-05-08  Tom Tromey  <tom@tromey.com>
5779
5780         * remote.c (remote_pspace_data): Change type.
5781         (remote_pspace_data_cleanup): Remove.
5782         (get_remote_exec_file, set_pspace_remote_exec_file)
5783         (_initialize_remote): Update.
5784
5785 2019-05-08  Tom Tromey  <tom@tromey.com>
5786
5787         * breakpoint.c (breakpoint_objfile_key): Change type.
5788         (get_breakpoint_objfile_data): Update.
5789         (free_breakpoint_objfile_data): Remove.
5790         (_initialize_breakpoint): Update.
5791
5792 2019-05-08  Tom Tromey  <tom@tromey.com>
5793
5794         * linux-tdep.c (struct linux_info): Add initializers.
5795         (linux_inferior_data): Move.  Change type.
5796         (invalidate_linux_cache_inf): Update.
5797         (linux_inferior_data_cleanup): Remove.
5798         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5799
5800 2019-05-08  Tom Tromey  <tom@tromey.com>
5801
5802         * auxv.c (auxv_inferior_data): Move.  Change type.
5803         (auxv_inferior_data_cleanup): Remove.
5804         (invalidate_auxv_cache_inf): Rewrite.
5805         (get_auxv_inferior_data, _initialize_auxv): Update.
5806
5807 2019-05-08  Tom Tromey  <tom@tromey.com>
5808
5809         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5810         (symfile_debug_objfile_data_key): Change type.
5811         (symfile_debug_installed, debug_qf_has_symbols)
5812         (debug_qf_find_last_source_symtab)
5813         (debug_qf_forget_cached_source_info)
5814         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5815         (debug_qf_print_stats, debug_qf_dump)
5816         (debug_qf_expand_symtabs_for_function)
5817         (debug_qf_expand_all_symtabs)
5818         (debug_qf_expand_symtabs_with_fullname)
5819         (debug_qf_map_matching_symbols)
5820         (debug_qf_expand_symtabs_matching)
5821         (debug_qf_find_pc_sect_compunit_symtab)
5822         (debug_qf_map_symbol_filenames)
5823         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5824         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5825         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5826         (debug_sym_read_linetable, debug_sym_relocate): Update.
5827         (symfile_debug_free_objfile): Remove.
5828         (install_symfile_debug_logging, _initialize_symfile_debug):
5829         Update.
5830
5831 2019-05-08  Tom Tromey  <tom@tromey.com>
5832
5833         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5834         allocate_on_obstack.
5835         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5836         (get_dwarf2_per_objfile): Update.
5837         (set_dwarf2_per_objfile): Remove.
5838         (dwarf2_has_info, dwarf2_get_section_info): Update.
5839         (dwarf2_free_objfile): Remove.
5840         (_initialize_dwarf2_read): Update.
5841
5842 2019-05-08  Tom Tromey  <tom@tromey.com>
5843
5844         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5845         initializers.
5846         <unsupported_script_warning_printed,
5847         script_not_found_warning_printed>: Now bool.
5848         (auto_load_pspace_data): Change type.
5849         (~auto_load_pspace_info): Rename from
5850         auto_load_pspace_data_cleanup.
5851         (get_auto_load_pspace_data, init_loaded_scripts_info)
5852         (clear_section_scripts, maybe_print_unsupported_script_warning)
5853         (maybe_print_script_not_found_warning, _initialize_auto_load):
5854         Update.
5855
5856 2019-05-08  Tom Tromey  <tom@tromey.com>
5857
5858         * objfiles.c (objfile_pspace_info): Add destructor and
5859         initializers.
5860         (objfiles_pspace_data): Change type.
5861         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5862         (get_objfile_pspace_data): Update.
5863         (objfiles_bfd_data): Change type.
5864         (get_objfile_bfd_data): Update.
5865         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5866
5867 2019-05-08  Tom Tromey  <tom@tromey.com>
5868
5869         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5870         Change type.
5871         (get_catch_syscall_inferior_data): Update.
5872         (catch_syscall_inferior_data_cleanup): Remove.
5873         (_initialize_break_catch_syscall): Update.
5874
5875 2019-05-08  Tom Tromey  <tom@tromey.com>
5876
5877         * inflow.c (struct terminal_info): Add destructor and
5878         initializers.
5879         (inflow_inferior_data): Change type.
5880         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5881         (get_inflow_inferior_data, inflow_inferior_exit)
5882         (swap_terminal_info, _initialize_inflow): Update.
5883
5884 2019-05-08  Tom Tromey  <tom@tromey.com>
5885
5886         * target-dcache.c (target_dcache_cleanup): Remove.
5887         (target_dcache_aspace_key): Change type.
5888         (target_dcache_init_p, target_dcache_invalidate)
5889         (target_dcache_get, target_dcache_get_or_init)
5890         (_initialize_target_dcache): Update.
5891         * dcache.h (struct dcache_deleter): New.
5892
5893 2019-05-08  Tom Tromey  <tom@tromey.com>
5894
5895         * symtab.c (struct symbol_cache): Add destructor and
5896         initializers.
5897         (symbol_cache_key): Move.  Change type.
5898         (make_symbol_cache, free_symbol_cache): Remove.
5899         (get_symbol_cache): Update.
5900         (symbol_cache_cleanup): Remove.
5901         (ALL_PSPACES, symbol_cache_flush)
5902         (maintenance_print_symbol_cache)
5903         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5904         Update.
5905
5906 2019-05-08  Tom Tromey  <tom@tromey.com>
5907
5908         * symtab.c (struct main_info): Add destructor and initializers.
5909         (main_progspace_key): Move.  Change type.
5910         (get_main_info): Update.
5911         (main_info_cleanup): Remove.
5912         (_initialize_symtab): Update.
5913
5914 2019-05-08  Tom Tromey  <tom@tromey.com>
5915
5916         * registry.h (DECLARE_REGISTRY): Define the _key class.
5917
5918 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5919
5920         * NEWS: Merge two 'New commands' sections.
5921
5922 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5923
5924         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5925         parameter and use Ada language definition instead.
5926         (ada_val_print_ptr): Remove unused language parameter.
5927         (ada_val_print_num): Remove language parameter and use Ada language
5928         definition instead.
5929         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5930         parameter.
5931         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5932         parameter and use Ada language definition instead.
5933         (ada_val_print_1): Update all ada_val_print_xxx calls.
5934         Remove language parameter.
5935         (ada_val_print): Update ada_val_print_1 call.
5936
5937 2019-05-08  Tom Tromey  <tromey@adacore.com>
5938
5939         * remote.c (remote_hw_watchpoint_limit)
5940         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5941         Now static.
5942
5943 2019-05-08  Tom Tromey  <tromey@adacore.com>
5944
5945         * maint.c (_initialize_maint_cmds): Move initialization code to
5946         remote.c.
5947         (watchdog, show_watchdog): Move to remote.c.
5948         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5949         "watchdog" static.
5950         (_initialize_remote): Move initialization code from maint.c.
5951         * defs.h (watchdog): Don't declare.
5952
5953 2019-05-08  Tom Tromey  <tromey@adacore.com>
5954
5955         * tui/tui-interp.c: Include main.h.
5956         * interps.c: Include main.h.
5957         * main.h (interpreter_p): Declare.
5958         * defs.h (interpreter_p): Don't declare.
5959
5960 2019-05-08  Tom Tromey  <tromey@adacore.com>
5961
5962         * dwarf2loc.c: Include dwarf2read.h.
5963         * defs.h (read_unsigned_leb128): Don't declare.
5964         * dwarf2read.h (read_unsigned_leb128): Declare.
5965
5966 2019-05-08  Tom Tromey  <tromey@adacore.com>
5967
5968         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5969         method.
5970
5971 2019-05-08  Tom Tromey  <tromey@adacore.com>
5972
5973         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5974         when no wrap column is set.
5975
5976 2019-05-08  Tom Tromey  <tromey@adacore.com>
5977
5978         * c-lang.c (c_get_string): Handle non-C-style arrays.
5979
5980 2019-05-08  Tom Tromey  <tromey@adacore.com>
5981
5982         * typeprint.c (print_offset_data::update): Print the bit offset,
5983         not the number of bits remaining.
5984
5985 2019-05-08  Tom Tromey  <tromey@adacore.com>
5986
5987         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5988         padding at end of comment.
5989
5990 2019-05-08  Tom Tromey  <tromey@adacore.com>
5991
5992         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5993         Compare main types.
5994
5995 2019-05-06  Tom Tromey  <tom@tromey.com>
5996
5997         * common/scoped_mmap.c: Include common-defs.h.
5998         * common/scoped_mmap.h: Don't include config.h.
5999
6000 2019-05-04  Tom Tromey  <tom@tromey.com>
6001
6002         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6003         (struct aarch64_call_info): Add initializers.
6004         <si>: Now a std::vector.
6005         (pass_on_stack, aarch64_push_dummy_call): Update.
6006
6007 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6008             Tom Tromey  <tom@tromey.com>
6009
6010         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6011         (ppc_threads): Now a std::vector.  Now static.
6012         (hwdebug_find_thread_points_by_tid)
6013         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6014         Update.
6015
6016 2019-05-04  Tom Tromey  <tom@tromey.com>
6017
6018         * arc-tdep.c (arc_tdesc_init): Return bool.
6019
6020 2019-05-04  Tom Tromey  <tom@tromey.com>
6021
6022         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6023         Use gdb_assert_not_reached.
6024
6025 2019-05-04  Tom Tromey  <tom@tromey.com>
6026
6027         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6028         "false".
6029
6030 2019-05-04  Tom Tromey  <tom@tromey.com>
6031
6032         * arc-tdep.c (arc_tdesc_init): Use bool.
6033
6034 2019-05-04  Tom Tromey  <tom@tromey.com>
6035
6036         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6037
6038 2019-05-04  Tom Tromey  <tom@tromey.com>
6039
6040         * cli/cli-cmds.c (valid_command_p): Return bool.
6041
6042 2019-05-04  Tom Tromey  <tom@tromey.com>
6043
6044         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6045         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6046
6047 2019-05-04  Raul Tambre  <raul@tambre.ee>
6048
6049         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6050         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6051         operator for comparison.
6052
6053 2019-05-04  Tom Tromey  <tom@tromey.com>
6054
6055         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6056         (lookup_partial_symbol, print_partial_symbols)
6057         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6058         (psymbol_compare): Update.
6059         (add_psymbol_to_bcache): Clear the entire psymbol.
6060         (maintenance_check_psymtabs): Update.
6061         * psympriv.h (struct partial_symbol): Don't derive from
6062         general_symbol_info.
6063         <obj_section, unrelocated_address, address,
6064         set_unrelocated_address>: Update.
6065         <ginfo>: New member.
6066         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6067         (debug_names::write_psymbols): Update.
6068
6069 2019-05-04  Tom de Vries  <tdevries@suse.de>
6070
6071         * contrib/cc-with-tweaks.sh: Support -n arg.
6072
6073 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6074
6075         * corelow.c (core_target::detach): Ensure frame cache and
6076         register caches are cleared.
6077         inferior.c (exit_inferior_1): Likewise.
6078
6079 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6080             Tom Tromey  <tom@tromey.com>
6081
6082         * dictionary.c (collate_pending_symbols_by_language): Remove
6083         "struct" from foreach.
6084         * symtab.c (lookup_global_symbol_from_objfile)
6085         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6086         foreach.
6087         * ser-tcp.c (net_open): Remove "struct" from foreach.
6088         * objfiles.c (objfile_relocate, objfile_rebase)
6089         (objfile_has_symbols): Remove "struct" from foreach.
6090         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6091         from foreach.
6092         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6093         foreach.
6094         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6095         "struct" from foreach.
6096         * ada-lang.c (create_excep_cond_exprs)
6097         (ada_exception_catchpoint_cond_string): Remove "struct" from
6098         foreach.
6099
6100 2019-05-03  Tom Tromey  <tromey@adacore.com>
6101
6102         * ada-exp.y (convert_char_literal): Check suffix of each
6103         enumerator.
6104
6105 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6106
6107         PR ada/21406:
6108         * ada-exp.y (yywrap): Don't define.
6109         * ada-lex.l (%option): Add noyywrap
6110         (yywrap): Remove.
6111
6112 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6113
6114         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6115         _WIN32_WINNT to the XP level, unless already defined to a higher
6116         level.
6117
6118         * unittests/parse-connection-spec-selftests.c:
6119         * ser-tcp.c:
6120         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6121         override.
6122
6123         * symfile.c (find_separate_debug_file): Remove colon from the
6124         drive spec of DOS/Windows file names of the target, so that the
6125         file name produced from DEBUGDIR and the target's directory will
6126         be valid on DOS/Windows systems.
6127
6128 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6129
6130         * rust-lang.c (val_print_struct): Handle printing structures
6131         containing strings.
6132
6133 2019-05-02  Tom Tromey  <tromey@adacore.com>
6134
6135         * valarith.c (_initialize_valarith): Remove.
6136
6137 2019-05-01  Tom Tromey  <tromey@adacore.com>
6138
6139         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6140         bitfields.
6141
6142 2019-05-01  Tom Tromey  <tromey@adacore.com>
6143
6144         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6145         for big-endian copies.
6146
6147 2019-04-30  Ali Tamur  <tamur@google.com>
6148         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6149         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6150         (read_3_bytes): New function.
6151
6152 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6153
6154         * windows-nat.c (main_thread_id): Delete.
6155         (handle_output_debug_string): Replace main_thread_id by
6156         current_event.dwThreadId.
6157         (fake_create_process): Likewise.
6158         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6159         Do not set main_thread_id.
6160         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6161         current_event.dwThreadId.
6162         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6163
6164 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6165
6166         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6167         Use current_event.dwThreadId instead of main_thread_id.
6168
6169 2019-04-30  Tom Tromey  <tromey@adacore.com>
6170
6171         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6172         (create_excep_cond_exprs): Iterate over program spaces.
6173         (ada_exception_catchpoint_cond_string): Examine all minimal
6174         symbols for exception types.
6175
6176 2019-04-30  Tom Tromey  <tromey@adacore.com>
6177
6178         PR c++/24470:
6179         * dwarf2read.c (process_structure_scope): Handle case where type
6180         has template parameters but no symbol was created.
6181
6182 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6183             Chris January  <chris.january@arm.com>
6184
6185         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6186         qualifier.
6187         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6188
6189 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6190
6191         * f-typeprint.c (f_print_type): Update rules for printing
6192         whitespace.
6193         (f_type_print_varspec_suffix): Likewise.
6194
6195 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6196             Chris January  <chris.january@arm.com>
6197
6198         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6199         function arguments.
6200
6201 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * f-lang.c (build_fortran_types): Change name of void type to
6204         lower case.
6205         * f-typeprint.c (f_type_print_base): Print the name of the void
6206         type, rather than a fixed string.
6207         * f-valprint.c (f_decorations): Use lower case void string.
6208
6209 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6210             Chris January  <chris.january@arm.com>
6211
6212         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6213         types for Fortran.
6214
6215 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6216             Chris January  <chris.january@arm.com>
6217             David Lecomber  <david.lecomber@arm.com>
6218
6219         * f-exp.y (BINOP_INTRINSIC): New token.
6220         (exp): New parser rule handling BINOP_INTRINSIC.
6221         (f77_keywords): Add new builtin procedures.
6222         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6223         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6224         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6225         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6226         (print_unop_subexp_f): New function.
6227         (print_binop_subexp_f): New function.
6228         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6229         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6230         (dump_subexp_body_f): Likewise.
6231         (operator_check_f): Likewise.
6232         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6233         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6234
6235 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6236
6237         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6238         UNOP_KIND.
6239         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6240         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6241         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6242         (operator_length_f): New fuction.
6243         (print_subexp_f): New function.
6244         (op_name_f): New function.
6245         (dump_subexp_body_f): New function.
6246         (operator_check_f): New function.
6247         (exp_descriptor_f): Replace standard expression handling functions
6248         with new functions.
6249         * gdb/fortran-operator.def: New file.
6250         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6251         * gdb/std-operator.def: Remove UNOP_KIND.
6252
6253 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6254
6255         * std-operator.def: Remove unbalanced, stray double quote
6256         character.
6257
6258 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6259             Chris January  <chris.january@arm.com>
6260             Daniel Everett  <daniel.everett@arm.com>
6261             Nick Forrington  <nick.forrington@arm.com>
6262             Richard Bunt  <richard.bunt@arm.com>
6263
6264         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6265         of depth when printing anonymous structs or unions.
6266         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6267         Don't print either the top-level value, or the children if the
6268         max-depth is exceeded.
6269         (ppscm_print_children): When printing the key of a map, allow one
6270         extra level of depth.
6271         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6272         print either the top-level value, or the children if the max-depth
6273         is exceeded.
6274         (print_children): When printing the key of a map, allow one extra
6275         level of depth.
6276         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6277         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6278         (user_print_options): Initialise max_depth field.
6279         (val_print_scalar_or_string_type_p): New function.
6280         (val_print): Check to see if the max depth has been reached.
6281         (val_print_check_max_depth): Define new function.
6282         (show_print_max_depth): New function.
6283         (_initialize_valprint): Add 'print max-depth' option.
6284         * valprint.h (struct value_print_options) <max_depth>: New field.
6285         (val_print_check_max_depth): Declare new function.
6286         * NEWS: Document new feature.
6287
6288 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6289
6290         * ada-lang.c (ada_language_defn): Initialise new field.
6291         * c-lang.c (c_is_string_type_p): New function.
6292         (c_language_defn): Initialise new field.
6293         (cplus_language_defn): Initialise new field.
6294         (asm_language_defn): Initialise new field.
6295         (minimal_language_defn): Initialise new field.
6296         * c-lang.h (c_is_string_type_p): Declare new function.
6297         * d-lang.c (d_language_defn): Initialise new field.
6298         * f-lang.c (f_is_string_type_p): New function.
6299         (f_language_defn): Initialise new field.
6300         * go-lang.c (go_is_string_type_p): New function.
6301         (go_language_defn): Initialise new field.
6302         * language.c (default_is_string_type_p): New function.
6303         (unknown_language_defn): Initialise new field.
6304         (auto_language_defn): Initialise new field.
6305         * language.h (struct language_defn) <la_is_string_type_p>: New
6306         member variable.
6307         (default_is_string_type_p): Declare new function.
6308         * m2-lang.c (m2_language_defn): Initialise new field.
6309         * objc-lang.c (objc_language_defn): Initialise new field.
6310         * opencl-lang.c (opencl_language_defn): Initialise new field.
6311         * p-lang.c (pascal_is_string_type_p): New function.
6312         (pascal_language_defn): Initialise new field.
6313         * rust-lang.c (rust_is_string_type_p): New function.
6314         (rust_language_defn): Initialise new field.
6315
6316 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6319         New field.
6320         * ada-lang.c (ada_language_defn): Initialise new field.
6321         * c-lang.c (c_language_defn): Likewise.
6322         (cplus_language_defn): Likewise.
6323         (asm_language_defn): Likewise.
6324         (minimal_language_defn): Likewise.
6325         * d-lang.c (d_language_defn): Likewise.
6326         * f-lang.c (f_language_defn): Likewise.
6327         * go-lang.c (go_language_defn): Likewise.
6328         * language.c (unknown_language_defn): Likewise.
6329         (auto_language_defn): Likewise.
6330         * m2-lang.c (m2_language_defn): Likewise.
6331         * objc-lang.c (objc_language_defn): Likewise.
6332         * opencl-lang.c (opencl_language_defn): Likewise.
6333         * p-lang.c (pascal_language_defn): Likewise.
6334         * rust-lang.c (rust_language_defn): Likewise.
6335
6336 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6337
6338         * ada-lang.c (ada_is_character_type): Change return type to bool.
6339         (ada_is_string_type): Likewise.
6340         * ada-lang.h (ada_is_character_type): Update declaration
6341         (ada_is_string_type): Likewise.
6342
6343 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6344
6345         Support style in 'frame|thread apply'
6346
6347         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6348         * record.c (record_start, record_stop): Update callers of
6349         execute_command_to_string with false.
6350         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6351         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6352         methods.
6353         (class string_file): New constructor with term_out parameter.
6354         Override methods term_out and can_emit_style_escape.  New member
6355         term_out.
6356         (class stdio_file): Override can_emit_style_escape.
6357         (class tee_file): Override term_out and can_emit_style_escape.
6358         * utils.h (can_emit_style_escape): Remove.
6359         * utils.c (can_emit_style_escape): Likewise.
6360         Update all callers of can_emit_style_escape (SOMESTREAM) to
6361         SOMESTREAM->can_emit_style_escape.
6362         * source-cache.c (source_cache::get_source_lines): Likewise.
6363         * stack.c (frame_apply_command_count): Call execute_command_to_string
6364         passing the term_out characteristic of the current gdb_stdout.
6365         * thread.c (thr_try_catch_cmd): Likewise.
6366         * top.c (execute_command_to_string): pass term_out parameter
6367         to construct the string_file for the command output.
6368         * ui-file.c (term_cli_styling): New function (most code moved
6369         from utils.c can_emit_style_escape).
6370         (string_file::string_file, string_file::can_emit_style_escape,
6371         stdio_file::can_emit_style_escape, tee_file::term_out,
6372         tee_file::can_emit_style_escape): New functions.
6373
6374 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6375
6376         * NEWS: Mention the new set|show may-call-functions.
6377         * infcall.c (may_call_functions_p): New variable.
6378         (show_may_call_functions_p): New function.
6379         (call_function_by_hand_dummy): Throws an error if not
6380         may-call-functions.
6381         (_initialize_infcall): Call add_setshow_boolean_cmd for
6382         may-call-functions.
6383
6384 2019-04-25  Keith Seitz  <keiths@redhat.com>
6385
6386         PR c++/24367
6387         * cp-support.c (inspect_type): Don't attempt substitutions
6388         of symbol with the same name.
6389
6390 2019-04-25  Tom Tromey  <tromey@adacore.com>
6391
6392         PR gdb/24475:
6393         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6394         static.
6395
6396 2019-04-25  Tom Tromey  <tromey@adacore.com>
6397
6398         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6399         rvalue reference.
6400         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6401         (gdb_xml_parser::parse): Use std::move.
6402         * python/python-internal.h (gdbpy_convert_exception): Take a const
6403         reference.
6404         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6405         std::move.
6406         * python/py-utils.c (gdbpy_convert_exception): Take a const
6407         reference.
6408         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6409         Use std::move.
6410         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6411         Use std::move.
6412         * mi/mi-main.c (mi_print_exception): Take a const reference.
6413         * main.c (handle_command_errors): Take a const reference.
6414         * linespec.c (parse_linespec): Use std::move.
6415         * infcall.c (run_inferior_call): Use std::move.
6416         (call_function_by_hand_dummy): Use std::move.
6417         * exec.c (try_open_exec_file): Use std::move.
6418         * exceptions.h (exception_print, exception_fprintf)
6419         (exception_print_same): Update.
6420         * exceptions.c (print_exception, exception_print)
6421         (exception_fprintf, exception_print_same): Change parameters to
6422         const reference.
6423         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6424         * common/new-op.c: Use std::move.
6425         * common/common-exceptions.h (struct gdb_exception): Add move
6426         constructor.
6427         (struct gdb_exception_error, struct gdb_exception_quit, struct
6428         gdb_quit_bad_alloc): Change constructor to move constructor.
6429         (throw_exception): Change parameter to rvalue reference.
6430         * common/common-exceptions.c (throw_exception): Take rvalue
6431         reference.
6432         * cli/cli-interp.c (safe_execute_command): Use std::move.
6433         * breakpoint.c (insert_bp_location, location_to_sals): Use
6434         std::move.
6435
6436 2019-04-25  Tom Tromey  <tromey@adacore.com>
6437
6438         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6439         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6440         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6441         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6442         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6443         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6444         guile/scm-value.c: Use unpack.
6445         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6446         gdbscm_gdb_exception.
6447         (gdbscm_throw_gdb_exception): Likewise.
6448         (struct gdbscm_gdb_exception): New.
6449         (unpack): New function.
6450         (gdbscm_wrap): Use unpack.
6451
6452 2019-04-25  Tom Tromey  <tromey@adacore.com>
6453
6454         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6455         (gdb_rl_callback_handler): Use std::move.
6456         * common/common-exceptions.h (struct gdb_exception): Add move
6457         assignment operator.
6458         (throw_exception_sjlj): Change "exception" to const reference.
6459         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6460         (throw_exception_sjlj): Change "exception" to const reference.
6461
6462 2019-04-25  Tom Tromey  <tromey@adacore.com>
6463
6464         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6465         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6466         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6467         Update.
6468         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6469         Update.
6470         * mi/mi-interp.c (mi_interp::exec): Update.
6471         * linespec.c (parse_linespec): Update.
6472         * infcall.c (run_inferior_call): Update.
6473         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6474         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6475         (gdbscm_lookup_global_symbol): Update.
6476         * guile/scm-param.c (gdbscm_parameter_value): Update.
6477         * guile/scm-frame.c (gdbscm_frame_read_register)
6478         (gdbscm_frame_read_var): Update.
6479         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6480         * exec.c (try_open_exec_file): Update.
6481         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6482         (gdb_rl_callback_handler): Update.
6483         * common/common-exceptions.h (exception_none): Don't declare.
6484         * common/common-exceptions.c (exception_none): Don't define.
6485         (struct catcher) <exception>: Update.
6486         * cli/cli-interp.c (safe_execute_command): Update.
6487         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6488
6489 2019-04-25  Ali Tamur  <tamur@google.com>
6490
6491         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6492         (read_attribute_value): Likewise.
6493         (dwarf2_read_addr_index): Update comment.
6494         (read_str_index): Add DW_FORM_strx.
6495         (dwarf2_string_attr): Likewise.
6496         (dwarf2_const_value_attr): Likewise.
6497         (dump_die_shallow): Likewise.
6498         (dwarf2_fetch_constant_bytes): Likewise.
6499         (skip_form_bytes): Likewise.
6500         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6501
6502 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6503
6504         PR corefiles/11608
6505         PR corefiles/18187
6506         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6507         OFFSET.  Verify if current mapping contains an ELF header.
6508         (linux_find_memory_regions_full): Adjust call to
6509         dump_mapping_p.
6510
6511 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6512             Kang Li <kanglictf@gmail.com>
6513
6514         PR gdb/21600
6515
6516         * dwarf2-frame.c (read_initial_length): Be consistent about using
6517         unsigned representation of length.
6518         (decode_frame_entry_1): Likewise.  Check for wraparound of
6519         end pointer as well as buffer overflow.
6520
6521 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6522
6523         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6524         "vq".
6525
6526 2019-04-24  Tom Tromey  <tromey@adacore.com>
6527
6528         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6529
6530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6531
6532         * s12z-tdep.c (s12z_unwind_pc): Delete.
6533         (s12z_unwind_sp): Delete.
6534         (s12z_gdbarch_init): Don't register deleted functions with
6535         gdbarch.
6536
6537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         * rl78-tdep.c (rl78_unwind_sp): Delete.
6540         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6541
6542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6543
6544         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6545         (xstormy16_unwind_pc): Delete.
6546         (xstormy16_dummy_id): Delete.
6547         (xstormy16_gdbarch_init): Don't register deleted functions with
6548         gdbarch.
6549
6550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6551
6552         * vax-tdep.c (vax_unwind_pc): Delete.
6553         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6554
6555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6556
6557         * v850-tdep.c (v850_unwind_sp): Delete.
6558         (v850_unwind_pc): Delete.
6559         (v850_dummy_id): Delete.
6560         (v850_gdbarch_init): Don't register deleted functions with
6561         gdbarch.
6562
6563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6564
6565         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6566         (tilegx_unwind_pc): Delete.
6567         (tilegx_unwind_dummy_id): Delete.
6568         (tilegx_gdbarch_init): Don't register deleted functions with
6569         gdbarch.
6570
6571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6574         (tic6x_dummy_id): Delete.
6575         (tic6x_gdbarch_init): Don't register deleted functions with
6576         gdbarch.
6577
6578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6579
6580         * sparc-tdep.c (sparc_unwind_pc): Delete.
6581         (sparc32_gdbarch_init): Don't register deleted function with
6582         gdbarch.
6583
6584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6585
6586         * sh-tdep.c (sh_unwind_sp): Delete.
6587         (sh_unwind_pc): Delete.
6588         (sh_dummy_id): Delete.
6589         (sh_gdbarch_init): Don't register deleted functions with
6590         gdbarch.
6591
6592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6593
6594         * score-tdep.c (score_unwind_sp): Delete.
6595         (score_unwind_pc): Delete.
6596         (score_dummy_id): Delete.
6597         (score_gdbarch_init): Don't register deleted functions with
6598         gdbarch.
6599
6600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6601
6602         * rx-tdep.c (rx_unwind_pc): Delete.
6603         (rx_unwind_sp): Delete.
6604         (rx_dummy_id): Delete.
6605         (rx_gdbarch_init): Don't register deleted functions with
6606         gdbarch.  Update comment.
6607
6608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6609
6610         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6611         (rs6000_dummy_id): Delete.
6612         (rs6000_gdbarch_init): Don't register deleted functions with
6613         gdbarch.
6614
6615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6616
6617         * or1k-tdep.c (or1k_dummy_id): Delete.
6618         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6619
6620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6621
6622         * nios2-tdep.c (nios2_dummy_id): Delete.
6623         (nios2_unwind_sp): Delete.
6624         (nios2_gdbarch_init): Don't register deleted functions with
6625         gdbarch.
6626
6627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6628
6629         * nds32-tdep.c (nds32_dummy_id): Delete.
6630         (nds32_unwind_pc): Delete.
6631         (nds32_unwind_sp): Delete.
6632         (nds32_gdbarch_init): Don't register deleted functions with
6633         gdbarch.
6634
6635 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6636
6637         * msp430-tdep.c (msp430_unwind_pc): Delete.
6638         (msp430_unwind_sp): Delete.
6639         (msp430_dummy_id): Delete.
6640         (msp430_gdbarch_init): Don't register deleted functions with
6641         gdbarch.
6642
6643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6644
6645         * moxie-tdep.c (moxie_unwind_sp): Delete.
6646         (moxie_unwind_pc): Delete.
6647         (moxie_dummy_id): Delete.
6648         (moxie_gdbarch_init): Don't register deleted functions with
6649         gdbarch.
6650
6651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6652
6653         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6654         (mn10300_unwind_pc): Delete.
6655         (mn10300_unwind_sp): Delete.
6656         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6657         mn10300_unwind_sp.
6658         (mn10300_frame_unwind_init): Don't register deleted functions with
6659         gdbarch.
6660
6661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6662
6663         * mep-tdep.c (mep_unwind_pc): Delete.
6664         (mep_unwind_sp): Delete.
6665         (mep_dummy_id): Delete.
6666         (mep_gdbarch_init): Don't register deleted functions with
6667         gdbarch.
6668
6669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6670
6671         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6672         (m68hc11_unwind_sp): Delete.
6673         (m68hc11_gdbarch_init): Don't register deleted functions with
6674         gdbarch.
6675
6676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6677
6678         * m32r-tdep.c (m32r_unwind_sp): Delete.
6679         (m32r_unwind_pc): Delete.
6680         (m32r_dummy_id): Delete.
6681         (m32r_gdbarch_init): Don't register deleted functions with
6682         gdbarch.
6683
6684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6685
6686         * m32c-tdep.c (m32c_unwind_pc): Delete.
6687         (m32c_unwind_sp): Delete.
6688         (m32c_dummy_id): Delete.
6689         (m32c_gdbarch_init): Don't register deleted functions with
6690         gdbarch.
6691
6692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6693
6694         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6695         (lm32_unwind_pc): Delete.
6696         (lm32_dummy_id): Delete.
6697         (lm32_gdbarch_init): Don't register deleted functions with
6698         gdbarch.
6699
6700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6701
6702         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6703         (iq2000_unwind_pc): Delete.
6704         (iq2000_dummy_id): Delete.
6705         (iq2000_gdbarch_init): Don't register deleted functions with
6706         gdbarch.
6707
6708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6709
6710         * nds32-tdep.c (nds32_type_align): Delete.
6711         (nds32_push_dummy_call): Use type_align instead.
6712
6713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6714
6715         * arm-tdep.c (arm_type_align): Only handle vector override case.
6716         (arm_push_dummy_call): Use type_align.
6717         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6718
6719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6720
6721         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6722         case.
6723         (pass_on_stack): Use type_align.
6724         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6725         function.
6726
6727 2019-04-23  Tom Tromey  <tromey@adacore.com>
6728
6729         * dwarf2read.c (line_header::file_name_at): Remove unused
6730         overload.
6731
6732 2019-04-23  Tom de Vries  <tdevries@suse.de>
6733
6734         PR gdb/24438
6735         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6736         invocation.
6737
6738
6739 2019-03-27  Ali Tamur  <tamur@google.com>
6740
6741         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6742         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6743         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6744         (dwarf_expr_context::get_addr_index): Likewise
6745         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6746         (symbol_needs_eval_context::get_addr_index): Likewise
6747         (disassemble_dwarf_expression): Add DW_OP_addrx
6748         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6749         (read_cutu_die_from_dwo): Update comment
6750         (skip_one_die): Add DW_FORM_addrx
6751         (read_attribute_value): Likewise
6752         (var_decode_location): Add DW_OP_addrx
6753         (dwarf2_const_value_attr): Add DW_FORM_addrx
6754         (dump_die_shallow): Likewise
6755         (dwarf2_fetch_constant_bytes): Likewise
6756         (decode_locdesc): Add DW_OP_addrx
6757         (skip_form_bytes): Add DW_FORM_addrx
6758
6759 2019-04-22  Ali Tamur  <tamur@google.com>
6760
6761         * MAINTAINERS (Write After Approval): Add self.
6762
6763 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6764
6765         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6766         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6767         (open_symbol_file_object): Likewise.
6768         (svr4_default_sos): Add info parameter.
6769         (svr4_read_so_list): Likewise.
6770         (svr4_current_sos_direct): Adjust functions calls to pass down
6771         info.
6772         (svr4_current_sos_1): Add info parameter.
6773         (svr4_current_sos): Call get_svr4_info, pass info down to
6774         svr4_current_sos_1.
6775         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6776         get_svr4_info.
6777         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6778         get_svr4_info.
6779         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6780         to get_svr4_info.
6781         (probes_table_remove_objfile_probes): Likewise.
6782         (register_solib_event_probe): Add info parameter.
6783         (solist_update_incremental): Pass info parameter down to
6784         svr4_read_so_list.
6785         (disable_probes_interface): Add info parameter.
6786         (svr4_handle_solib_event): Pass current_program_space to
6787         get_svr4_info.  Adjust disable_probes_interface cleanup.
6788         (svr4_create_probe_breakpoints): Add info parameter, pass it
6789         down to register_solib_event_probe.
6790         (svr4_create_solib_event_breakpoints): Add info parameter,
6791         pass it down to svr4_create_probe_breakpoints.
6792         (enable_break): Pass info down to
6793         svr4_create_solib_event_breakpoints.
6794         (svr4_solib_create_inferior_hook): Pass current_program_space to
6795         get_svr4_info.
6796         (svr4_clear_solib): Likewise.
6797
6798 2019-04-22  Pedro Alves  <palves@redhat.com>
6799
6800         * solib-svr4.c (svr4_free_objfile_observer): New.
6801         (probe_and_action::objfile): New field.
6802         (probes_table_htab_remove_objfile_probes)
6803         (probes_table_remove_objfile_probes): New functions.
6804         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6805         in the new probe_and_action.  Don't store the probe in 'lookup'.
6806         (svr4_create_probe_breakpoints): Pass objfile to
6807         register_solib_event_probe.
6808         (_initialize_svr4_solib): Register a free_objfile observer.
6809
6810 2019-04-19  Tom Tromey  <tom@tromey.com>
6811
6812         * common/queue.h: Remove.
6813
6814 2019-04-19  Tom Tromey  <tom@tromey.com>
6815
6816         * event-loop.c: Don't include "common/queue.h".
6817
6818 2019-04-19  Tom Tromey  <tom@tromey.com>
6819
6820         * remote.c (remote_target): Use delete.
6821         * remote-notif.h: Include <list>, not "common/queue.h".
6822         (notif_client_p): Remove typedef.
6823         (remote_notif_state): Add constructor, destructor, initializer.
6824         <notif_queue>: Now a std::list.
6825         (remote_notif_state_xfree): Don't declare.
6826         * remote-notif.c (remote_notif_process, handle_notification)
6827         (remote_notif_state_allocate): Update.
6828         (~remote_notif_state): Rename from remote_notif_state_xfree.
6829
6830 2019-04-19  Tom Tromey  <tom@tromey.com>
6831
6832         * symfile.c (reread_symbols): Update.
6833         * objfiles.c (objfile_register_static_link)
6834         (objfile_lookup_static_link): Update
6835         (~objfile) Don't delete static_links.
6836         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6837
6838 2019-04-19  Tom Tromey  <tom@tromey.com>
6839
6840         * type-stack.h (struct type_stack) <insert>: Constify string.
6841         * type-stack.c (type_stack::insert): Constify string.
6842         * gdbtypes.h (lookup_template_type): Update.
6843         (address_space_name_to_int): Update.
6844         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6845         const.
6846         (lookup_template_type): Make name const.
6847         * c-exp.y: Update rules.
6848         (lex_one_token, classify_name, classify_inner_name)
6849         (c_print_token): Update.
6850         * p-exp.y: Update rules.
6851         (yylex): Update.
6852         * f-exp.y: Update rules.
6853         (yylex): Update.
6854         * d-exp.y: Update rules.
6855         (lex_one_token, classify_name, classify_inner_name): Update.
6856         * parse.c (write_dollar_variable, copy_name): Return std::string.
6857         * parser-defs.h (copy_name): Change return type.
6858         * m2-exp.y: Update rules.
6859         (yylex): Update.
6860         * go-exp.y (lex_one_token): Update.
6861         Update rules.
6862         (classify_unsafe_function, classify_packaged_name)
6863         (classify_name, yylex): Update.
6864
6865 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6866
6867         * configure.ac: add --enable-source-highlight switch.
6868         * configure: Regenerate.
6869         * top.c (print_gdb_version): plumb --enable-source-highlight
6870         status to "show configuration".
6871
6872 2019-04-19  Tom Tromey  <tromey@adacore.com>
6873
6874         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6875         Check ADA_TYPE_P.
6876         (empty_record, ada_template_to_fixed_record_type_1)
6877         (template_to_static_fixed_type)
6878         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6879         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6880         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6881         macros.
6882
6883 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6884
6885         PR symtab/24423:
6886         * source.c (print_source_lines_base): Advance "iter" when a
6887         control character is seen.
6888
6889 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6890
6891         * inferior.h (struct infcall_suspend_state_deleter):
6892         Catch exception in destructor to avoid crash.
6893
6894 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6895
6896         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6897         close to the add_com "shell".
6898
6899 2019-04-18  Tom Tromey  <tromey@adacore.com>
6900
6901         * process-stratum-target.h (class process_stratum_target)
6902         <stratum>: Add "final".
6903
6904 2019-04-17  Tom Tromey  <tromey@adacore.com>
6905
6906         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6907         against nullptr before use.
6908
6909 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6910
6911         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6912
6913 2019-04-17  Jim Wilson  <jimw@sifive.com>
6914             Andrew Burgess  <andrew.burgess@embecosm.com>
6915
6916         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6917         code read might fail, assume 4-byte breakpoint in that case.
6918
6919 2019-04-15  Leszek Swirski  <leszeks@google.com>
6920
6921         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6922         rather than a hand-rolled POD check when checking for forced MEMORY
6923         classification.
6924
6925 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6926
6927         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6928         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6929         function.
6930         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6931         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6932         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6933         declaration.
6934
6935 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6936
6937         * aarch64-linux-nat.c
6938         (aarch64_linux_nat_target::thread_architecture): Add override.
6939         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6940         each VQ.
6941
6942 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6943
6944         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6945
6946 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6947
6948         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6949         target types of size 96-bits, add some additional comments, and
6950         check that the builtin type we found was the correct size.
6951
6952 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6953
6954         * utils.c (prompt_for_continue): Don't restore the styling at the
6955         end, as applied_style has the wrong value.  This fixes styling in
6956         long lists of file names that are interrupted by the "Continue?"
6957         prompt.
6958
6959 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6960
6961         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6962         * c-lang.c (c_language_defn): Likewise.
6963         (cplus_language_defn): Likewise.
6964         (asm_language_defn): Likewise.
6965         (minimal_language_defn): Likewise.
6966         * d-lang.c (d_language_defn): Likewise.
6967         * f-lang.c (f_language_defn): Likewise.
6968         * go-lang.c (go_language_defn): Likewise.
6969         * language.c (unknown_language_defn): Likewise.
6970         (auto_language_defn): Likewise.
6971         * language.h (struct language_defn): Remove la_magic field.
6972         (LANG_MAGIC): Delete.
6973         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6974         * objc-lang.c (objc_language_defn): Likewise.
6975         * opencl-lang.c (opencl_language_defn): Likewise.
6976         * p-lang.c (pascal_language_defn): Likewise.
6977         * rust-lang.c (rust_language_defn): Likewise.
6978
6979 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6980
6981         * riscv-tdep.c (riscv_type_align): New function.
6982         (riscv_type_alignment): Delete.
6983         (riscv_arg_location): Use 'type_align'.
6984         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6985
6986 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6987
6988         * gdbtypes.c (type_align): A struct with no non-static fields also
6989         has alignment of 1.
6990
6991 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6992
6993         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6994         component to 0.
6995         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6996         member.
6997         (riscv_struct_info::analyse): New implementation using new
6998         analyse_inner member function.
6999         (riscv_struct_info::field_offset): New member function.
7000         (riscv_struct_info::m_offsets): New member variable.
7001         (riscv_struct_info::analyse_inner): New private member function,
7002         takes the old implementation of riscv_struct_info::analyse but
7003         extended to track field offsets.
7004         (riscv_call_arg_struct): Update the struct folding special cases
7005         to handle cases where empty C++ structs, which are non-zero
7006         length, are found.
7007         (riscv_arg_location): Initialise the length of each location, a
7008         non-zero length now indicates the location is in use.
7009         (riscv_push_dummy_call): Allow for the first location having a
7010         non-zero offset when setting up arguments.
7011         (riscv_return_value): Likewise, but for return values.
7012
7013 2019-04-11  Tom Tromey  <tromey@adacore.com>
7014
7015         * utils.c (internal_vproblem): Make "msg" const.
7016
7017 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7018
7019         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7020         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7021         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7022         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7023
7024 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7025
7026         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7027         function.
7028         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7029         of amd64_collect_native_gregset.
7030         (amd64_linux_nat_target::store_registers): Likewise.
7031
7032 2019-04-10  Tom Tromey  <tom@tromey.com>
7033
7034         * symtab.c (lookup_global_symbol_from_objfile)
7035         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7036         * objfiles.h (class separate_debug_iterator): New.
7037         (class separate_debug_range): New.
7038         (struct objfile) <separate_debug_objfiles>: New method.
7039         (objfile_separate_debug_iterate): Don't declare.
7040         * objfiles.c (separate_debug_iterator::operator++): Rename from
7041         objfile_separate_debug_iterate.
7042         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7043         iterator.
7044         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7045         iterator.
7046
7047 2019-04-10  Tom Tromey  <tom@tromey.com>
7048
7049         * symfile.c (reread_symbols): Remove old comment.
7050         * objfiles.c (free_all_objfiles): Fix a typo.
7051
7052 2019-04-10  Tom Tromey  <tom@tromey.com>
7053
7054         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7055         * minsyms.c (lookup_minimal_symbol): Use foreach.
7056         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7057         (lookup_minimal_symbol_solib_trampoline): Likewise.
7058         * symfile.c (reread_symbols): Use foreach.
7059
7060 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7061             Tom Tromey  <tromey@adacore.com>
7062
7063         PR rust/24414:
7064         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7065         (rust_lex_int_test): Change "value" to be LONGEST.
7066         (rust_lex_tests): Add test for long integer literal.
7067
7068 2019-04-09  Tom Tromey  <tromey@adacore.com>
7069
7070         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7071         to bool.
7072         (extended_remote_target::attach): Update.
7073         (remote_target::remote_notice_new_inferior): Update.
7074         (remote_target::add_current_inferior_and_thread): Update.
7075         * inferior.c (exit_inferior_1): Use "false".
7076         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7077
7078 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7079
7080         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7081         the "start" command.
7082
7083 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7084
7085         * python/py-inferior.c (infpy_thread_from_thread_handle):
7086         Adjust comments to reflect renaming of thread_from_thread_handle
7087         to thread_from_handle.  Adjust keywords.  Fix type error message.
7088         (inferior_object_methods): Add thread_from_handle.  Retain
7089         thread_from_thread_handle, but mark it as deprecated.
7090
7091 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7092
7093         * gdbthread.h (find_thread_by_handle): Revise declaration.
7094         * thread.c (find_thread_by_handle): Likewise.  Adjust
7095         implementation too.
7096         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7097         support for buffer objects as handles.
7098
7099 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7100
7101         * python/py-infthread.c (thpy_thread_handle): New function.
7102         (thread_object_methods): Register thpy_thread_handle.
7103
7104 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7105
7106         * gdbthread.h (thread_to_thread_handle): Declare.
7107         * thread.c (gdbtypes.h): Include.
7108         (thread_to_thread_handle): New function.
7109
7110         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7111         (target_thread_info_to_thread_handle): Declare.
7112         * target.c (target_thread_info_to_thread_handle): New function.
7113         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7114         * target-delegates.c: Regenerate.
7115
7116         * linux-thread-db.c (class thread_db_target): Add method
7117         thread_info_to_thread_handle.
7118         (thread_db_target::thread_info_to_thread_handle): Define.
7119         * remote.c (class remote_target): Add new method
7120         thread_info_to_thread_handle.
7121         (remote_target::thread_info_to_thread_handle): Define.
7122
7123 2019-04-08  Pedro Alves  <palves@redhat.com>
7124
7125         * common/common-exceptions.c (throw_exception): Don't create
7126         named object to throw; throw directly.
7127         (throw_it): Likewise.  Don't initialize gdb_exception::message
7128         here, with new; pass FMT and AP to the ctor instead.
7129         * common/common-exceptions.h: Include <string>.
7130         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7131         const char *, va_list)): New ctor.  Use std::make_shared.
7132         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7133         errors)): Delete.
7134         (gdb_exception_error::gdb_exception_error(enum errors, const char
7135         *, va_list)): New.
7136         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7137         Add assertion.
7138         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7139         errors)): Delete.
7140         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7141         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7142         Add assertion.
7143
7144 2019-04-08  Tom Tromey  <tom@tromey.com>
7145
7146         * valops.c (value_rtti_indirect_type): Replace throw_exception
7147         with throw.
7148         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7149         with throw.
7150         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7151         throw.
7152         * target.c (target_translate_tls_address): Replace throw_exception
7153         with throw.
7154         * stack.c (frame_apply_command_count): Replace throw_exception
7155         with throw.
7156         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7157         throw.
7158         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7159         with throw.
7160         * rs6000-tdep.c (rs6000_frame_cache)
7161         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7162         * remote.c: Replace throw_exception with throw.
7163         * record-full.c (record_full_message, record_full_wait_1)
7164         (record_full_restore): Replace throw_exception with throw.
7165         * record-btrace.c:
7166         (get_thread_current_frame_id, record_btrace_start_replaying)
7167         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7168         (cmd_record_btrace_start): Replace throw_exception with throw.
7169         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7170         throw.
7171         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7172         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7173         * linespec.c:
7174         (find_linespec_symbols): Replace throw_exception with throw.
7175         * infrun.c (displaced_step_prepare, resume): Replace
7176         throw_exception with throw.
7177         * infcmd.c (post_create_inferior): Replace throw_exception with
7178         throw.
7179         * inf-loop.c (inferior_event_handler): Replace throw_exception
7180         with throw.
7181         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7182         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7183         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7184         (get_prev_frame_always, get_frame_pc_if_available)
7185         (get_frame_address_in_block_if_available, get_frame_language):
7186         Replace throw_exception with throw.
7187         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7188         throw_exception with throw.
7189         * eval.c (fetch_subexp_value, evaluate_var_value)
7190         (evaluate_funcall, evaluate_subexp_standard): Replace
7191         throw_exception with throw.
7192         * dwarf2loc.c (call_site_find_chain)
7193         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7194         Replace throw_exception with throw.
7195         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7196         with throw.
7197         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7198         throw.
7199         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7200         * completer.c (complete_line_internal): Replace throw_exception
7201         with throw.
7202         * compile/compile-object-run.c (compile_object_run): Replace
7203         throw_exception with throw.
7204         * cli/cli-script.c (process_next_line): Replace throw_exception
7205         with throw.
7206         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7207         (btrace_enable, btrace_maint_update_pt_packets): Replace
7208         throw_exception with throw.
7209         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7210         throw_exception with throw.
7211         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7212         throw_exception with throw.
7213         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7214         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7215         * aarch64-tdep.c (aarch64_make_prologue_cache)
7216         (aarch64_make_stub_cache): Replace throw_exception with throw.
7217
7218 2019-04-08  Tom Tromey  <tom@tromey.com>
7219
7220         * common/common-exceptions.c (throw_exception): Rename from
7221         throw_exception_cxx.  Remove old copy.  Make argument const.
7222         (throw_it): Create and throw exception objects directly.
7223         * common/common-exceptions.h (throw_exception): Make argument
7224         const.
7225         (struct gdb_exception_error): Add constructor.
7226         (struct gdb_exception_quit): Add constructor.
7227
7228 2019-04-08  Tom Tromey  <tom@tromey.com>
7229
7230         * common/common-exceptions.h (exception_rethrow): Don't declare.
7231         (TRY_SJLJ): Update comment.
7232         (TRY, CATCH, END_CATCH): Remove.
7233         * common/common-exceptions.c (exception_rethrow): Remove.
7234
7235 2019-04-08  Tom Tromey  <tom@tromey.com>
7236
7237         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7238         Remove.
7239         (gdb_exception_error): Rename from
7240         gdb_exception_RETURN_MASK_ERROR.
7241         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7242         (gdb_quit_bad_alloc): Update.
7243         * aarch64-tdep.c: Update.
7244         * ada-lang.c: Update.
7245         * ada-typeprint.c: Update.
7246         * ada-valprint.c: Update.
7247         * amd64-tdep.c: Update.
7248         * arch-utils.c: Update.
7249         * break-catch-throw.c: Update.
7250         * breakpoint.c: Update.
7251         * btrace.c: Update.
7252         * c-varobj.c: Update.
7253         * cli/cli-cmds.c: Update.
7254         * cli/cli-interp.c: Update.
7255         * cli/cli-script.c: Update.
7256         * common/common-exceptions.c: Update.
7257         * common/new-op.c: Update.
7258         * common/selftest.c: Update.
7259         * compile/compile-c-symbols.c: Update.
7260         * compile/compile-cplus-symbols.c: Update.
7261         * compile/compile-object-load.c: Update.
7262         * compile/compile-object-run.c: Update.
7263         * completer.c: Update.
7264         * corelow.c: Update.
7265         * cp-abi.c: Update.
7266         * cp-support.c: Update.
7267         * cp-valprint.c: Update.
7268         * darwin-nat.c: Update.
7269         * disasm-selftests.c: Update.
7270         * dtrace-probe.c: Update.
7271         * dwarf-index-cache.c: Update.
7272         * dwarf-index-write.c: Update.
7273         * dwarf2-frame-tailcall.c: Update.
7274         * dwarf2-frame.c: Update.
7275         * dwarf2loc.c: Update.
7276         * dwarf2read.c: Update.
7277         * eval.c: Update.
7278         * event-loop.c: Update.
7279         * event-top.c: Update.
7280         * exec.c: Update.
7281         * f-valprint.c: Update.
7282         * fbsd-tdep.c: Update.
7283         * frame-unwind.c: Update.
7284         * frame.c: Update.
7285         * gdbtypes.c: Update.
7286         * gnu-v3-abi.c: Update.
7287         * guile/guile-internal.h: Update.
7288         * guile/scm-block.c: Update.
7289         * guile/scm-breakpoint.c: Update.
7290         * guile/scm-cmd.c: Update.
7291         * guile/scm-disasm.c: Update.
7292         * guile/scm-frame.c: Update.
7293         * guile/scm-lazy-string.c: Update.
7294         * guile/scm-math.c: Update.
7295         * guile/scm-param.c: Update.
7296         * guile/scm-ports.c: Update.
7297         * guile/scm-pretty-print.c: Update.
7298         * guile/scm-symbol.c: Update.
7299         * guile/scm-symtab.c: Update.
7300         * guile/scm-type.c: Update.
7301         * guile/scm-value.c: Update.
7302         * i386-linux-tdep.c: Update.
7303         * i386-tdep.c: Update.
7304         * inf-loop.c: Update.
7305         * infcall.c: Update.
7306         * infcmd.c: Update.
7307         * infrun.c: Update.
7308         * jit.c: Update.
7309         * language.c: Update.
7310         * linespec.c: Update.
7311         * linux-fork.c: Update.
7312         * linux-nat.c: Update.
7313         * linux-tdep.c: Update.
7314         * linux-thread-db.c: Update.
7315         * main.c: Update.
7316         * mi/mi-cmd-break.c: Update.
7317         * mi/mi-cmd-stack.c: Update.
7318         * mi/mi-interp.c: Update.
7319         * mi/mi-main.c: Update.
7320         * objc-lang.c: Update.
7321         * p-valprint.c: Update.
7322         * parse.c: Update.
7323         * ppc-linux-tdep.c: Update.
7324         * printcmd.c: Update.
7325         * python/py-arch.c: Update.
7326         * python/py-breakpoint.c: Update.
7327         * python/py-cmd.c: Update.
7328         * python/py-finishbreakpoint.c: Update.
7329         * python/py-frame.c: Update.
7330         * python/py-framefilter.c: Update.
7331         * python/py-gdb-readline.c: Update.
7332         * python/py-inferior.c: Update.
7333         * python/py-infthread.c: Update.
7334         * python/py-lazy-string.c: Update.
7335         * python/py-linetable.c: Update.
7336         * python/py-objfile.c: Update.
7337         * python/py-param.c: Update.
7338         * python/py-prettyprint.c: Update.
7339         * python/py-progspace.c: Update.
7340         * python/py-record-btrace.c: Update.
7341         * python/py-record.c: Update.
7342         * python/py-symbol.c: Update.
7343         * python/py-type.c: Update.
7344         * python/py-unwind.c: Update.
7345         * python/py-utils.c: Update.
7346         * python/py-value.c: Update.
7347         * python/python.c: Update.
7348         * record-btrace.c: Update.
7349         * record-full.c: Update.
7350         * remote-fileio.c: Update.
7351         * remote.c: Update.
7352         * riscv-tdep.c: Update.
7353         * rs6000-aix-tdep.c: Update.
7354         * rs6000-tdep.c: Update.
7355         * rust-exp.y: Update.
7356         * rust-lang.c: Update.
7357         * s390-tdep.c: Update.
7358         * selftest-arch.c: Update.
7359         * solib-dsbt.c: Update.
7360         * solib-frv.c: Update.
7361         * solib-spu.c: Update.
7362         * solib-svr4.c: Update.
7363         * solib.c: Update.
7364         * sparc64-linux-tdep.c: Update.
7365         * stack.c: Update.
7366         * symfile-mem.c: Update.
7367         * symmisc.c: Update.
7368         * target.c: Update.
7369         * thread.c: Update.
7370         * top.c: Update.
7371         * tracefile-tfile.c: Update.
7372         * tui/tui.c: Update.
7373         * typeprint.c: Update.
7374         * unittests/cli-utils-selftests.c: Update.
7375         * unittests/parse-connection-spec-selftests.c: Update.
7376         * valops.c: Update.
7377         * valprint.c: Update.
7378         * value.c: Update.
7379         * varobj.c: Update.
7380         * windows-nat.c: Update.
7381         * x86-linux-nat.c: Update.
7382         * xml-support.c: Update.
7383
7384 2019-04-08  Tom Tromey  <tom@tromey.com>
7385
7386         * xml-support.c: Use C++ exception handling.
7387         * x86-linux-nat.c: Use C++ exception handling.
7388         * windows-nat.c: Use C++ exception handling.
7389         * varobj.c: Use C++ exception handling.
7390         * value.c: Use C++ exception handling.
7391         * valprint.c: Use C++ exception handling.
7392         * valops.c: Use C++ exception handling.
7393         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7394         handling.
7395         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7396         * typeprint.c: Use C++ exception handling.
7397         * tui/tui.c: Use C++ exception handling.
7398         * tracefile-tfile.c: Use C++ exception handling.
7399         * top.c: Use C++ exception handling.
7400         * thread.c: Use C++ exception handling.
7401         * target.c: Use C++ exception handling.
7402         * symmisc.c: Use C++ exception handling.
7403         * symfile-mem.c: Use C++ exception handling.
7404         * stack.c: Use C++ exception handling.
7405         * sparc64-linux-tdep.c: Use C++ exception handling.
7406         * solib.c: Use C++ exception handling.
7407         * solib-svr4.c: Use C++ exception handling.
7408         * solib-spu.c: Use C++ exception handling.
7409         * solib-frv.c: Use C++ exception handling.
7410         * solib-dsbt.c: Use C++ exception handling.
7411         * selftest-arch.c: Use C++ exception handling.
7412         * s390-tdep.c: Use C++ exception handling.
7413         * rust-lang.c: Use C++ exception handling.
7414         * rust-exp.y: Use C++ exception handling.
7415         * rs6000-tdep.c: Use C++ exception handling.
7416         * rs6000-aix-tdep.c: Use C++ exception handling.
7417         * riscv-tdep.c: Use C++ exception handling.
7418         * remote.c: Use C++ exception handling.
7419         * remote-fileio.c: Use C++ exception handling.
7420         * record-full.c: Use C++ exception handling.
7421         * record-btrace.c: Use C++ exception handling.
7422         * python/python.c: Use C++ exception handling.
7423         * python/py-value.c: Use C++ exception handling.
7424         * python/py-utils.c: Use C++ exception handling.
7425         * python/py-unwind.c: Use C++ exception handling.
7426         * python/py-type.c: Use C++ exception handling.
7427         * python/py-symbol.c: Use C++ exception handling.
7428         * python/py-record.c: Use C++ exception handling.
7429         * python/py-record-btrace.c: Use C++ exception handling.
7430         * python/py-progspace.c: Use C++ exception handling.
7431         * python/py-prettyprint.c: Use C++ exception handling.
7432         * python/py-param.c: Use C++ exception handling.
7433         * python/py-objfile.c: Use C++ exception handling.
7434         * python/py-linetable.c: Use C++ exception handling.
7435         * python/py-lazy-string.c: Use C++ exception handling.
7436         * python/py-infthread.c: Use C++ exception handling.
7437         * python/py-inferior.c: Use C++ exception handling.
7438         * python/py-gdb-readline.c: Use C++ exception handling.
7439         * python/py-framefilter.c: Use C++ exception handling.
7440         * python/py-frame.c: Use C++ exception handling.
7441         * python/py-finishbreakpoint.c: Use C++ exception handling.
7442         * python/py-cmd.c: Use C++ exception handling.
7443         * python/py-breakpoint.c: Use C++ exception handling.
7444         * python/py-arch.c: Use C++ exception handling.
7445         * printcmd.c: Use C++ exception handling.
7446         * ppc-linux-tdep.c: Use C++ exception handling.
7447         * parse.c: Use C++ exception handling.
7448         * p-valprint.c: Use C++ exception handling.
7449         * objc-lang.c: Use C++ exception handling.
7450         * mi/mi-main.c: Use C++ exception handling.
7451         * mi/mi-interp.c: Use C++ exception handling.
7452         * mi/mi-cmd-stack.c: Use C++ exception handling.
7453         * mi/mi-cmd-break.c: Use C++ exception handling.
7454         * main.c: Use C++ exception handling.
7455         * linux-thread-db.c: Use C++ exception handling.
7456         * linux-tdep.c: Use C++ exception handling.
7457         * linux-nat.c: Use C++ exception handling.
7458         * linux-fork.c: Use C++ exception handling.
7459         * linespec.c: Use C++ exception handling.
7460         * language.c: Use C++ exception handling.
7461         * jit.c: Use C++ exception handling.
7462         * infrun.c: Use C++ exception handling.
7463         * infcmd.c: Use C++ exception handling.
7464         * infcall.c: Use C++ exception handling.
7465         * inf-loop.c: Use C++ exception handling.
7466         * i386-tdep.c: Use C++ exception handling.
7467         * i386-linux-tdep.c: Use C++ exception handling.
7468         * guile/scm-value.c: Use C++ exception handling.
7469         * guile/scm-type.c: Use C++ exception handling.
7470         * guile/scm-symtab.c: Use C++ exception handling.
7471         * guile/scm-symbol.c: Use C++ exception handling.
7472         * guile/scm-pretty-print.c: Use C++ exception handling.
7473         * guile/scm-ports.c: Use C++ exception handling.
7474         * guile/scm-param.c: Use C++ exception handling.
7475         * guile/scm-math.c: Use C++ exception handling.
7476         * guile/scm-lazy-string.c: Use C++ exception handling.
7477         * guile/scm-frame.c: Use C++ exception handling.
7478         * guile/scm-disasm.c: Use C++ exception handling.
7479         * guile/scm-cmd.c: Use C++ exception handling.
7480         * guile/scm-breakpoint.c: Use C++ exception handling.
7481         * guile/scm-block.c: Use C++ exception handling.
7482         * guile/guile-internal.h: Use C++ exception handling.
7483         * gnu-v3-abi.c: Use C++ exception handling.
7484         * gdbtypes.c: Use C++ exception handling.
7485         * frame.c: Use C++ exception handling.
7486         * frame-unwind.c: Use C++ exception handling.
7487         * fbsd-tdep.c: Use C++ exception handling.
7488         * f-valprint.c: Use C++ exception handling.
7489         * exec.c: Use C++ exception handling.
7490         * event-top.c: Use C++ exception handling.
7491         * event-loop.c: Use C++ exception handling.
7492         * eval.c: Use C++ exception handling.
7493         * dwarf2read.c: Use C++ exception handling.
7494         * dwarf2loc.c: Use C++ exception handling.
7495         * dwarf2-frame.c: Use C++ exception handling.
7496         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7497         * dwarf-index-write.c: Use C++ exception handling.
7498         * dwarf-index-cache.c: Use C++ exception handling.
7499         * dtrace-probe.c: Use C++ exception handling.
7500         * disasm-selftests.c: Use C++ exception handling.
7501         * darwin-nat.c: Use C++ exception handling.
7502         * cp-valprint.c: Use C++ exception handling.
7503         * cp-support.c: Use C++ exception handling.
7504         * cp-abi.c: Use C++ exception handling.
7505         * corelow.c: Use C++ exception handling.
7506         * completer.c: Use C++ exception handling.
7507         * compile/compile-object-run.c: Use C++ exception handling.
7508         * compile/compile-object-load.c: Use C++ exception handling.
7509         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7510         * compile/compile-c-symbols.c: Use C++ exception handling.
7511         * common/selftest.c: Use C++ exception handling.
7512         * common/new-op.c: Use C++ exception handling.
7513         * cli/cli-script.c: Use C++ exception handling.
7514         * cli/cli-interp.c: Use C++ exception handling.
7515         * cli/cli-cmds.c: Use C++ exception handling.
7516         * c-varobj.c: Use C++ exception handling.
7517         * btrace.c: Use C++ exception handling.
7518         * breakpoint.c: Use C++ exception handling.
7519         * break-catch-throw.c: Use C++ exception handling.
7520         * arch-utils.c: Use C++ exception handling.
7521         * amd64-tdep.c: Use C++ exception handling.
7522         * ada-valprint.c: Use C++ exception handling.
7523         * ada-typeprint.c: Use C++ exception handling.
7524         * ada-lang.c: Use C++ exception handling.
7525         * aarch64-tdep.c: Use C++ exception handling.
7526
7527 2019-04-08  Tom Tromey  <tom@tromey.com>
7528
7529         * xml-support.c (gdb_xml_parser::parse): Update.
7530         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7531         * value.c (show_convenience): Update.
7532         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7533         (test_parse_flags_qcs): Update.
7534         * thread.c (thr_try_catch_cmd): Update.
7535         * target.c (target_translate_tls_address): Update.
7536         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7537         (info_frame_command_core, frame_apply_command_count): Update.
7538         * rust-exp.y (rust_lex_exception_test): Update.
7539         * riscv-tdep.c (riscv_print_one_register_info): Update.
7540         * remote.c (remote_target::enable_btrace): Update.
7541         * record-btrace.c (record_btrace_enable_warn): Update.
7542         * python/py-utils.c (gdbpy_convert_exception): Update.
7543         * printcmd.c (do_one_display, print_variable_and_value): Update.
7544         * mi/mi-main.c (mi_print_exception): Update.
7545         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7546         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7547         * linux-nat.c (linux_nat_target::attach): Update.
7548         * linux-fork.c (class scoped_switch_fork_info): Update.
7549         * infrun.c (displaced_step_prepare): Update.
7550         * infcall.c (call_function_by_hand_dummy): Update.
7551         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7552         * gnu-v3-abi.c (print_one_vtable): Update.
7553         * frame.c (get_prev_frame_always): Update.
7554         * f-valprint.c (info_common_command_for_block): Update.
7555         * exec.c (try_open_exec_file): Update.
7556         * exceptions.c (print_exception, exception_print)
7557         (exception_fprintf, exception_print_same): Update.
7558         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7559         * dwarf-index-cache.c (index_cache::store)
7560         (index_cache::lookup_gdb_index): Update.
7561         * darwin-nat.c (maybe_cache_shell): Update.
7562         * cp-valprint.c (cp_print_value_fields): Update.
7563         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7564         (gcc_cplus_symbol_address): Update.
7565         * compile/compile-c-symbols.c (gcc_convert_symbol)
7566         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7567         * common/selftest.c: Update.
7568         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7569         a std::string.
7570         (exception_try_scope_entry, exception_try_scope_exit): Don't
7571         declare.
7572         (struct exception_try_scope): Remove.
7573         (TRY): Don't use exception_try_scope.
7574         (struct gdb_exception): Add constructor, operator=.
7575         <what>: New method.
7576         (struct gdb_exception_RETURN_MASK_ALL)
7577         (struct gdb_exception_RETURN_MASK_ERROR)
7578         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7579         (struct gdb_quit_bad_alloc): Update.
7580         * common/common-exceptions.c (exception_none): Change
7581         initializer.
7582         (struct catcher) <state, exception>: Initialize inline.
7583         <prev>: Remove member.
7584         (current_catcher): Remove.
7585         (catchers): New global.
7586         (exceptions_state_mc_init): Simplify.
7587         (catcher_pop): Remove.
7588         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7589         (try_scope_depth, exception_try_scope_entry)
7590         (exception_try_scope_exit): Remove.
7591         (throw_exception_sjlj): Update.
7592         (exception_messages, exception_messages_size): Remove.
7593         (throw_it): Simplify.
7594         (gdb_exception_sliced_copy): Remove.
7595         (throw_exception_cxx): Update.
7596         * cli/cli-script.c (script_from_file): Update.
7597         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7598         Update.
7599         * ada-valprint.c (ada_val_print): Update.
7600         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7601         (create_excep_cond_exprs): Update.
7602
7603 2019-04-08  Tom Tromey  <tom@tromey.com>
7604
7605         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7606         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7607         (TRY, CATCH, END_CATCH): Remove some definitions.
7608         * common/common-exceptions.c: Don't use GDB_XCPT.
7609         (catcher_list_size): Remove.
7610         (throw_exception, throw_it): Simplify.
7611
7612 2019-04-05  Tom Tromey  <tom@tromey.com>
7613
7614         Revert the header-sorting patch.
7615         * ft32-tdep.c: Revert.
7616         * frv-tdep.c: Revert.
7617         * frv-linux-tdep.c: Revert.
7618         * frame.c: Revert.
7619         * frame-unwind.c: Revert.
7620         * frame-base.c: Revert.
7621         * fork-child.c: Revert.
7622         * findvar.c: Revert.
7623         * findcmd.c: Revert.
7624         * filesystem.c: Revert.
7625         * filename-seen-cache.h: Revert.
7626         * filename-seen-cache.c: Revert.
7627         * fbsd-tdep.c: Revert.
7628         * fbsd-nat.h: Revert.
7629         * fbsd-nat.c: Revert.
7630         * f-valprint.c: Revert.
7631         * f-typeprint.c: Revert.
7632         * f-lang.c: Revert.
7633         * extension.h: Revert.
7634         * extension.c: Revert.
7635         * extension-priv.h: Revert.
7636         * expprint.c: Revert.
7637         * exec.h: Revert.
7638         * exec.c: Revert.
7639         * exceptions.c: Revert.
7640         * event-top.c: Revert.
7641         * event-loop.c: Revert.
7642         * eval.c: Revert.
7643         * elfread.c: Revert.
7644         * dwarf2read.h: Revert.
7645         * dwarf2read.c: Revert.
7646         * dwarf2loc.c: Revert.
7647         * dwarf2expr.h: Revert.
7648         * dwarf2expr.c: Revert.
7649         * dwarf2-frame.c: Revert.
7650         * dwarf2-frame-tailcall.c: Revert.
7651         * dwarf-index-write.h: Revert.
7652         * dwarf-index-write.c: Revert.
7653         * dwarf-index-common.c: Revert.
7654         * dwarf-index-cache.h: Revert.
7655         * dwarf-index-cache.c: Revert.
7656         * dummy-frame.c: Revert.
7657         * dtrace-probe.c: Revert.
7658         * disasm.h: Revert.
7659         * disasm.c: Revert.
7660         * disasm-selftests.c: Revert.
7661         * dictionary.c: Revert.
7662         * dicos-tdep.c: Revert.
7663         * demangle.c: Revert.
7664         * dcache.h: Revert.
7665         * dcache.c: Revert.
7666         * darwin-nat.h: Revert.
7667         * darwin-nat.c: Revert.
7668         * darwin-nat-info.c: Revert.
7669         * d-valprint.c: Revert.
7670         * d-namespace.c: Revert.
7671         * d-lang.c: Revert.
7672         * ctf.c: Revert.
7673         * csky-tdep.c: Revert.
7674         * csky-linux-tdep.c: Revert.
7675         * cris-tdep.c: Revert.
7676         * cris-linux-tdep.c: Revert.
7677         * cp-valprint.c: Revert.
7678         * cp-support.c: Revert.
7679         * cp-namespace.c: Revert.
7680         * cp-abi.c: Revert.
7681         * corelow.c: Revert.
7682         * corefile.c: Revert.
7683         * continuations.c: Revert.
7684         * completer.h: Revert.
7685         * completer.c: Revert.
7686         * complaints.c: Revert.
7687         * coffread.c: Revert.
7688         * coff-pe-read.c: Revert.
7689         * cli-out.h: Revert.
7690         * cli-out.c: Revert.
7691         * charset.c: Revert.
7692         * c-varobj.c: Revert.
7693         * c-valprint.c: Revert.
7694         * c-typeprint.c: Revert.
7695         * c-lang.c: Revert.
7696         * buildsym.c: Revert.
7697         * buildsym-legacy.c: Revert.
7698         * build-id.h: Revert.
7699         * build-id.c: Revert.
7700         * btrace.c: Revert.
7701         * bsd-uthread.c: Revert.
7702         * breakpoint.h: Revert.
7703         * breakpoint.c: Revert.
7704         * break-catch-throw.c: Revert.
7705         * break-catch-syscall.c: Revert.
7706         * break-catch-sig.c: Revert.
7707         * blockframe.c: Revert.
7708         * block.c: Revert.
7709         * bfin-tdep.c: Revert.
7710         * bfin-linux-tdep.c: Revert.
7711         * bfd-target.c: Revert.
7712         * bcache.c: Revert.
7713         * ax-general.c: Revert.
7714         * ax-gdb.h: Revert.
7715         * ax-gdb.c: Revert.
7716         * avr-tdep.c: Revert.
7717         * auxv.c: Revert.
7718         * auto-load.c: Revert.
7719         * arm-wince-tdep.c: Revert.
7720         * arm-tdep.c: Revert.
7721         * arm-symbian-tdep.c: Revert.
7722         * arm-pikeos-tdep.c: Revert.
7723         * arm-obsd-tdep.c: Revert.
7724         * arm-nbsd-tdep.c: Revert.
7725         * arm-nbsd-nat.c: Revert.
7726         * arm-linux-tdep.c: Revert.
7727         * arm-linux-nat.c: Revert.
7728         * arm-fbsd-tdep.c: Revert.
7729         * arm-fbsd-nat.c: Revert.
7730         * arm-bsd-tdep.c: Revert.
7731         * arch-utils.c: Revert.
7732         * arc-tdep.c: Revert.
7733         * arc-newlib-tdep.c: Revert.
7734         * annotate.h: Revert.
7735         * annotate.c: Revert.
7736         * amd64-windows-tdep.c: Revert.
7737         * amd64-windows-nat.c: Revert.
7738         * amd64-tdep.c: Revert.
7739         * amd64-sol2-tdep.c: Revert.
7740         * amd64-obsd-tdep.c: Revert.
7741         * amd64-obsd-nat.c: Revert.
7742         * amd64-nbsd-tdep.c: Revert.
7743         * amd64-nbsd-nat.c: Revert.
7744         * amd64-nat.c: Revert.
7745         * amd64-linux-tdep.c: Revert.
7746         * amd64-linux-nat.c: Revert.
7747         * amd64-fbsd-tdep.c: Revert.
7748         * amd64-fbsd-nat.c: Revert.
7749         * amd64-dicos-tdep.c: Revert.
7750         * amd64-darwin-tdep.c: Revert.
7751         * amd64-bsd-nat.c: Revert.
7752         * alpha-tdep.c: Revert.
7753         * alpha-obsd-tdep.c: Revert.
7754         * alpha-nbsd-tdep.c: Revert.
7755         * alpha-mdebug-tdep.c: Revert.
7756         * alpha-linux-tdep.c: Revert.
7757         * alpha-linux-nat.c: Revert.
7758         * alpha-bsd-tdep.c: Revert.
7759         * alpha-bsd-nat.c: Revert.
7760         * aix-thread.c: Revert.
7761         * agent.c: Revert.
7762         * addrmap.c: Revert.
7763         * ada-varobj.c: Revert.
7764         * ada-valprint.c: Revert.
7765         * ada-typeprint.c: Revert.
7766         * ada-tasks.c: Revert.
7767         * ada-lang.c: Revert.
7768         * aarch64-tdep.c: Revert.
7769         * aarch64-ravenscar-thread.c: Revert.
7770         * aarch64-newlib-tdep.c: Revert.
7771         * aarch64-linux-tdep.c: Revert.
7772         * aarch64-linux-nat.c: Revert.
7773         * aarch64-fbsd-tdep.c: Revert.
7774         * aarch64-fbsd-nat.c: Revert.
7775         * aarch32-linux-nat.c: Revert.
7776
7777 2019-04-05  Tom Tromey  <tom@tromey.com>
7778
7779         * ft32-tdep.c: Sort headers.
7780         * frv-tdep.c: Sort headers.
7781         * frv-linux-tdep.c: Sort headers.
7782         * frame.c: Sort headers.
7783         * frame-unwind.c: Sort headers.
7784         * frame-base.c: Sort headers.
7785         * fork-child.c: Sort headers.
7786         * findvar.c: Sort headers.
7787         * findcmd.c: Sort headers.
7788         * filesystem.c: Sort headers.
7789         * filename-seen-cache.h: Sort headers.
7790         * filename-seen-cache.c: Sort headers.
7791         * fbsd-tdep.c: Sort headers.
7792         * fbsd-nat.h: Sort headers.
7793         * fbsd-nat.c: Sort headers.
7794         * f-valprint.c: Sort headers.
7795         * f-typeprint.c: Sort headers.
7796         * f-lang.c: Sort headers.
7797         * extension.h: Sort headers.
7798         * extension.c: Sort headers.
7799         * extension-priv.h: Sort headers.
7800         * expprint.c: Sort headers.
7801         * exec.h: Sort headers.
7802         * exec.c: Sort headers.
7803         * exceptions.c: Sort headers.
7804         * event-top.c: Sort headers.
7805         * event-loop.c: Sort headers.
7806         * eval.c: Sort headers.
7807         * elfread.c: Sort headers.
7808         * dwarf2read.h: Sort headers.
7809         * dwarf2read.c: Sort headers.
7810         * dwarf2loc.c: Sort headers.
7811         * dwarf2expr.h: Sort headers.
7812         * dwarf2expr.c: Sort headers.
7813         * dwarf2-frame.c: Sort headers.
7814         * dwarf2-frame-tailcall.c: Sort headers.
7815         * dwarf-index-write.h: Sort headers.
7816         * dwarf-index-write.c: Sort headers.
7817         * dwarf-index-common.c: Sort headers.
7818         * dwarf-index-cache.h: Sort headers.
7819         * dwarf-index-cache.c: Sort headers.
7820         * dummy-frame.c: Sort headers.
7821         * dtrace-probe.c: Sort headers.
7822         * disasm.h: Sort headers.
7823         * disasm.c: Sort headers.
7824         * disasm-selftests.c: Sort headers.
7825         * dictionary.c: Sort headers.
7826         * dicos-tdep.c: Sort headers.
7827         * demangle.c: Sort headers.
7828         * dcache.h: Sort headers.
7829         * dcache.c: Sort headers.
7830         * darwin-nat.h: Sort headers.
7831         * darwin-nat.c: Sort headers.
7832         * darwin-nat-info.c: Sort headers.
7833         * d-valprint.c: Sort headers.
7834         * d-namespace.c: Sort headers.
7835         * d-lang.c: Sort headers.
7836         * ctf.c: Sort headers.
7837         * csky-tdep.c: Sort headers.
7838         * csky-linux-tdep.c: Sort headers.
7839         * cris-tdep.c: Sort headers.
7840         * cris-linux-tdep.c: Sort headers.
7841         * cp-valprint.c: Sort headers.
7842         * cp-support.c: Sort headers.
7843         * cp-namespace.c: Sort headers.
7844         * cp-abi.c: Sort headers.
7845         * corelow.c: Sort headers.
7846         * corefile.c: Sort headers.
7847         * continuations.c: Sort headers.
7848         * completer.h: Sort headers.
7849         * completer.c: Sort headers.
7850         * complaints.c: Sort headers.
7851         * coffread.c: Sort headers.
7852         * coff-pe-read.c: Sort headers.
7853         * cli-out.h: Sort headers.
7854         * cli-out.c: Sort headers.
7855         * charset.c: Sort headers.
7856         * c-varobj.c: Sort headers.
7857         * c-valprint.c: Sort headers.
7858         * c-typeprint.c: Sort headers.
7859         * c-lang.c: Sort headers.
7860         * buildsym.c: Sort headers.
7861         * buildsym-legacy.c: Sort headers.
7862         * build-id.h: Sort headers.
7863         * build-id.c: Sort headers.
7864         * btrace.c: Sort headers.
7865         * bsd-uthread.c: Sort headers.
7866         * breakpoint.h: Sort headers.
7867         * breakpoint.c: Sort headers.
7868         * break-catch-throw.c: Sort headers.
7869         * break-catch-syscall.c: Sort headers.
7870         * break-catch-sig.c: Sort headers.
7871         * blockframe.c: Sort headers.
7872         * block.c: Sort headers.
7873         * bfin-tdep.c: Sort headers.
7874         * bfin-linux-tdep.c: Sort headers.
7875         * bfd-target.c: Sort headers.
7876         * bcache.c: Sort headers.
7877         * ax-general.c: Sort headers.
7878         * ax-gdb.h: Sort headers.
7879         * ax-gdb.c: Sort headers.
7880         * avr-tdep.c: Sort headers.
7881         * auxv.c: Sort headers.
7882         * auto-load.c: Sort headers.
7883         * arm-wince-tdep.c: Sort headers.
7884         * arm-tdep.c: Sort headers.
7885         * arm-symbian-tdep.c: Sort headers.
7886         * arm-pikeos-tdep.c: Sort headers.
7887         * arm-obsd-tdep.c: Sort headers.
7888         * arm-nbsd-tdep.c: Sort headers.
7889         * arm-nbsd-nat.c: Sort headers.
7890         * arm-linux-tdep.c: Sort headers.
7891         * arm-linux-nat.c: Sort headers.
7892         * arm-fbsd-tdep.c: Sort headers.
7893         * arm-fbsd-nat.c: Sort headers.
7894         * arm-bsd-tdep.c: Sort headers.
7895         * arch-utils.c: Sort headers.
7896         * arc-tdep.c: Sort headers.
7897         * arc-newlib-tdep.c: Sort headers.
7898         * annotate.h: Sort headers.
7899         * annotate.c: Sort headers.
7900         * amd64-windows-tdep.c: Sort headers.
7901         * amd64-windows-nat.c: Sort headers.
7902         * amd64-tdep.c: Sort headers.
7903         * amd64-sol2-tdep.c: Sort headers.
7904         * amd64-obsd-tdep.c: Sort headers.
7905         * amd64-obsd-nat.c: Sort headers.
7906         * amd64-nbsd-tdep.c: Sort headers.
7907         * amd64-nbsd-nat.c: Sort headers.
7908         * amd64-nat.c: Sort headers.
7909         * amd64-linux-tdep.c: Sort headers.
7910         * amd64-linux-nat.c: Sort headers.
7911         * amd64-fbsd-tdep.c: Sort headers.
7912         * amd64-fbsd-nat.c: Sort headers.
7913         * amd64-dicos-tdep.c: Sort headers.
7914         * amd64-darwin-tdep.c: Sort headers.
7915         * amd64-bsd-nat.c: Sort headers.
7916         * alpha-tdep.c: Sort headers.
7917         * alpha-obsd-tdep.c: Sort headers.
7918         * alpha-nbsd-tdep.c: Sort headers.
7919         * alpha-mdebug-tdep.c: Sort headers.
7920         * alpha-linux-tdep.c: Sort headers.
7921         * alpha-linux-nat.c: Sort headers.
7922         * alpha-bsd-tdep.c: Sort headers.
7923         * alpha-bsd-nat.c: Sort headers.
7924         * aix-thread.c: Sort headers.
7925         * agent.c: Sort headers.
7926         * addrmap.c: Sort headers.
7927         * ada-varobj.c: Sort headers.
7928         * ada-valprint.c: Sort headers.
7929         * ada-typeprint.c: Sort headers.
7930         * ada-tasks.c: Sort headers.
7931         * ada-lang.c: Sort headers.
7932         * aarch64-tdep.c: Sort headers.
7933         * aarch64-ravenscar-thread.c: Sort headers.
7934         * aarch64-newlib-tdep.c: Sort headers.
7935         * aarch64-linux-tdep.c: Sort headers.
7936         * aarch64-linux-nat.c: Sort headers.
7937         * aarch64-fbsd-tdep.c: Sort headers.
7938         * aarch64-fbsd-nat.c: Sort headers.
7939         * aarch32-linux-nat.c: Sort headers.
7940
7941 2019-04-04  Tom Tromey  <tom@tromey.com>
7942
7943         * varobj.c (varobj_create): Update.
7944         * rust-exp.y (struct rust_parser) <update_innermost_block,
7945         lookup_symbol>: New methods.
7946         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7947         Rename.
7948         (rust_parser::rust_lookup_type)
7949         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7950         * printcmd.c (display_command, do_one_display): Update.
7951         * parser-defs.h (struct parser_state) <parser_state>: Add
7952         "tracker" parameter.
7953         (block_tracker): New member.
7954         (class innermost_block_tracker) <innermost_block_tracker>: Add
7955         "types" parameter.
7956         <reset>: Remove method.
7957         (innermost_block): Don't declare.
7958         (null_post_parser): Update.
7959         * parse.c (innermost_block): Remove global.
7960         (write_dollar_variable): Update.
7961         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7962         Remove "tracker_types" parameter.
7963         (parse_expression): Add "tracker" parameter.
7964         (parse_expression_for_completion): Update.
7965         (null_post_parser): Add "tracker" parameter.
7966         * p-exp.y: Update rules.
7967         * m2-exp.y: Update rules.
7968         * language.h (struct language_defn) <la_post_parser>: Add
7969         "tracker" parameter.
7970         * go-exp.y: Update rules.
7971         * f-exp.y: Update rules.
7972         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7973         parameter.
7974         * d-exp.y: Update rules.
7975         * c-exp.y: Update rules.
7976         * breakpoint.c (set_breakpoint_condition): Create an
7977         innermost_block_tracker.
7978         (watch_command_1): Likewise.
7979         * ada-lang.c (resolve): Add "tracker" parameter.
7980         (resolve_subexp): Likewise.
7981         * ada-exp.y (write_var_from_sym): Update.
7982
7983 2019-04-04  Tom Tromey  <tom@tromey.com>
7984
7985         * type-stack.h: New file.
7986         * type-stack.c: New file.
7987         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7988         type-stack.h.
7989         (insert_into_type_stack, insert_type, push_type, push_type_int)
7990         (insert_type_address_space, pop_type, pop_type_int)
7991         (pop_typelist, pop_type_stack, append_type_stack)
7992         (push_type_stack, get_type_stack, push_typelist)
7993         (follow_type_instance_flags, follow_types): Don't declare.
7994         * parse.c (type_stack): Remove global.
7995         (parse_exp_in_context): Update.
7996         (insert_into_type_stack, insert_type, push_type, push_type_int)
7997         (insert_type_address_space, pop_type, pop_type_int)
7998         (pop_typelist, pop_type_stack, append_type_stack)
7999         (push_type_stack, get_type_stack, push_typelist)
8000         (follow_type_instance_flags, follow_types): Remove (moved to
8001         type-stack.c).
8002         * f-exp.y (type_stack): New global.
8003         Update rules.
8004         (push_kind_type, f_parse): Update.
8005         * d-exp.y (type_stack): New global.
8006         Update rules.
8007         (d_parse): Update.
8008         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8009         Update rules.
8010         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8011         (HFILES_NO_SRCDIR): Add type-stack.h.
8012
8013 2019-04-04  Tom Tromey  <tom@tromey.com>
8014
8015         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8016         (rust_parser::convert_ast_to_expression, rust_parse)
8017         (rust_lex_test_completion, rust_lex_tests): Update.
8018         * parser-defs.h (struct expr_completion_state): New.
8019         (struct parser_state) <parser_state>: Add completion parameter.
8020         <mark_struct_expression, mark_completion_tag>: New methods.
8021         <parse_completion, m_completion_state>: New members.
8022         (prefixify_expression, null_post_parser): Update.
8023         (mark_struct_expression, mark_completion_tag): Don't declare.
8024         * parse.c (parse_completion, expout_last_struct)
8025         (expout_tag_completion_type, expout_completion_name): Remove
8026         globals.
8027         (parser_state::mark_struct_expression)
8028         (parser_state::mark_completion_tag): Now methods.
8029         (prefixify_expression): Add last_struct parameter.
8030         (prefixify_subexp): Likewise.
8031         (parse_exp_1): Update.
8032         (parse_exp_in_context): Add cstate parameter.  Update.
8033         (parse_expression_for_completion): Create an
8034         expr_completion_state.
8035         (null_post_parser): Add "completion" parameter.
8036         * p-exp.y: Update rules.
8037         (yylex): Update.
8038         * language.h (struct language_defn) <la_post_parser>: Add
8039         "completing" parameter.
8040         * go-exp.y: Update rules.
8041         (lex_one_token): Update.
8042         * expression.h (parse_completion): Don't declare.
8043         * d-exp.y: Update rules.
8044         (lex_one_token): Update rules.
8045         * c-exp.y: Update rules.
8046         (lex_one_token): Update.
8047         * ada-lang.c (resolve): Add "parse_completion" parameter.
8048         (resolve_subexp): Likewise.
8049         (ada_resolve_function): Likewise.
8050
8051 2019-04-04  Tom Tromey  <tom@tromey.com>
8052
8053         * parser-defs.h (struct parser_state) <start_arglist,
8054         end_arglist>: New methods.
8055         <arglist_len, m_funcall_chain>: New members.
8056         (arglist_len, start_arglist, end_arglist): Don't declare.
8057         * parse.c (arglist_len, funcall_chain): Remove global.
8058         (start_arglist, end_arglist): Remove functions.
8059         (parse_exp_in_context): Update.
8060         * p-exp.y: Update rules.
8061         * m2-exp.y: Update rules.
8062         * go-exp.y: Update rules.
8063         * f-exp.y: Update rules.
8064         * d-exp.y: Update rules.
8065         * c-exp.y: Update rules.
8066
8067 2019-04-04  Tom Tromey  <tom@tromey.com>
8068
8069         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8070         lex_operator, push_back>: New methods.
8071         Update all rules.
8072         (rust_parser::lex_hex, lex_escape): Rename and update.
8073         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8074         (rust_parser::lex_operator): Rename and update.
8075         (rust_parser::lex_number, rustyylex, rustyyerror)
8076         (rust_lex_test_init, rust_lex_test_sequence)
8077         (rust_lex_test_push_back, rust_lex_tests): Update.
8078         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8079         parameter.
8080         <lexptr, prev_lexptr>: New members.
8081         (lexptr, prev_lexptr): Don't declare.
8082         * parse.c (lexptr, prev_lexptr): Remove globals.
8083         (parse_exp_in_context): Update.
8084         * p-exp.y (yylex, yyerror): Update.
8085         * m2-exp.y (parse_number, yylex, yyerror): Update.
8086         * go-exp.y (lex_one_token, yyerror): Update.
8087         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8088         * d-exp.y (lex_one_token, yyerror): Update.
8089         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8090         (lex_one_token, yyerror): Update.
8091         * ada-lex.l (YY_INPUT): Update.
8092         (rewind_to_char): Update.
8093         * ada-exp.y (yyerror): Update.
8094
8095 2019-04-04  Tom Tromey  <tom@tromey.com>
8096
8097         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8098         * parser-defs.h (struct parser_state) <parser_state>: Add new
8099         parameter.
8100         <comma_terminates>: New member.
8101         (comma_terminates): Don't declare global.
8102         * parse.c (comma_terminates): Remove global.
8103         (parse_exp_in_context): Update.
8104         * p-exp.y (yylex): Update.
8105         * m2-exp.y (yylex): Update.
8106         * go-exp.y (lex_one_token): Update.
8107         * f-exp.y (yylex): Update.
8108         * d-exp.y (lex_one_token): Update.
8109         * c-exp.y (lex_one_token): Update.
8110         * ada-lex.l: Update.
8111
8112 2019-04-04  Tom Tromey  <tom@tromey.com>
8113
8114         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8115         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8116         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8117         * parser-defs.h (paren_depth): Don't declare.
8118         * parse.c (paren_depth): Remove global.
8119         (parse_exp_in_context): Update.
8120         * p-exp.y (paren_depth): New global.
8121         (pascal_parse): Initialize it.
8122         * m2-exp.y (paren_depth): New global.
8123         (m2_parse): Initialize it.
8124         * go-exp.y (paren_depth): New global.
8125         (go_parse): Initialize it.
8126         * f-exp.y (paren_depth): New global.
8127         (f_parse): Initialize it.
8128         * d-exp.y (paren_depth): New global.
8129         (d_parse): Initialize it.
8130         * c-exp.y (paren_depth): New global.
8131         (c_parse): Initialize it.
8132         * ada-lex.l (paren_depth): New global.
8133         (lexer_init): Initialize it.
8134
8135 2019-04-04  Tom Tromey  <tom@tromey.com>
8136
8137         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8138         (rust_parser::convert_ast_to_type)
8139         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8140         * parser-defs.h (struct parser_state) <parser_state>: Add
8141         parameters.  Initialize new members.
8142         <expression_context_block, expression_context_pc>: New members.
8143         * parse.c (expression_context_block, expression_context_pc):
8144         Remove globals.
8145         (parse_exp_in_context): Update.
8146         * p-exp.y: Update all rules.
8147         (yylex): Update.
8148         * m2-exp.y: Update all rules.
8149         (yylex): Update.
8150         * go-exp.y (yylex): Update.
8151         * f-exp.y (yylex): Update.
8152         * d-exp.y: Update all rules.
8153         (yylex): Update.
8154         * c-exp.y: Update all rules.
8155         (lex_one_token, classify_name, yylex, c_parse): Update.
8156         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8157
8158 2019-04-04  Tom Tromey  <tom@tromey.com>
8159
8160         * gdbarch.h, gdbarch.c: Rebuild.
8161         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8162         * stap-probe.h:
8163         (struct stap_parse_info): Replace "parser_state" with
8164         "expr_builder".
8165         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8166         (parser_state): New class.
8167         * parse.c (expr_builder): Rename.
8168         (expr_builder::release): Rename.
8169         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8170         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8171         (write_exp_elt_longcst, write_exp_elt_floatcst)
8172         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8173         (write_exp_string_vector, write_exp_bitstring)
8174         (write_exp_msymbol, mark_struct_expression)
8175         (write_dollar_variable)
8176         (insert_type_address_space, increase_expout_size): Replace
8177         "parser_state" with "expr_builder".
8178         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8179         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8180         "parser_state" with "expr_builder".
8181
8182 2019-04-04  Tom Tromey  <tom@tromey.com>
8183
8184         * rust-exp.y: Replace "parse_language" with method call.
8185         * p-exp.y:
8186         (yylex): Replace "parse_language" with method call.
8187         * m2-exp.y:
8188         (yylex): Replace "parse_language" with method call.
8189         * go-exp.y (classify_name): Replace "parse_language" with method
8190         call.
8191         * f-exp.y (yylex): Replace "parse_language" with method call.
8192         * d-exp.y (lex_one_token): Replace "parse_language" with method
8193         call.
8194         * c-exp.y:
8195         (lex_one_token, classify_name, yylex): Replace "parse_language"
8196         with method call.
8197         * ada-exp.y (find_primitive_type, type_char)
8198         (type_system_address): Replace "parse_language" with method call.
8199
8200 2019-04-04  Tom Tromey  <tom@tromey.com>
8201
8202         * rust-exp.y: Replace "parse_gdbarch" with method call.
8203         * parse.c (write_dollar_variable, insert_type_address_space):
8204         Replace "parse_gdbarch" with method call.
8205         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8206         call.
8207         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8208         call.
8209         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8210         "parse_gdbarch" with method call.
8211         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8212         with method call.
8213         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8214         "parse_gdbarch" with method call.
8215         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8216         "parse_gdbarch" with method call.
8217         * c-exp.y (parse_type, parse_number, classify_name): Replace
8218         "parse_gdbarch" with method call.
8219         * ada-lex.l: Replace "parse_gdbarch" with method call.
8220         * ada-exp.y (parse_type, find_primitive_type, type_char)
8221         (type_system_address): Replace "parse_gdbarch" with method call.
8222
8223 2019-04-04  Tom Tromey  <tom@tromey.com>
8224
8225         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8226         * stap-probe.c (stap_parse_argument): Update.
8227         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8228         initial_size parameter.
8229         * rust-exp.y (rust_lex_tests): Update.
8230         * parse.c (parser_state): Update.
8231         (parse_exp_in_context): Update.
8232         * parser-defs.h (struct parser_state) <parser_state>: Remove
8233         "initial_size" parameter.
8234
8235 2019-04-04  Tom Tromey  <tom@tromey.com>
8236
8237         * parser-defs.h (increase_expout_size): Don't declare.
8238         * parse.c (increase_expout_size): Now static.
8239
8240 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8241
8242         * gnu-nat.c (gnu_nat_target::wait): Fix
8243         target_waitstatus_to_string call.
8244
8245 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8246
8247         * eval.c (evaluate_subexp_standard): Handle internal functions
8248         during Fortran function call handling.
8249
8250 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8251
8252         * NEWS: Mention new internal functions.
8253         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8254         (read_base_type): Use dwarf2_init_complex_target_type.
8255         * value.c (creal_internal_fn): New function.
8256         (cimag_internal_fn): New function.
8257         (_initialize_values): Register new internal functions.
8258
8259 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8260
8261         * infrun.c (stop_all_threads): If debug_infrun, always
8262         trace the wait status after wait_one, using
8263         target_waitstatus_to_string and target_pid_to_str.
8264         (handle_inferior_event): Replace various trace of
8265         wait status kind by a single trace.
8266         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8267         wait status kind image by target_waitstatus_to_string.
8268         * target/waitstatus.c (target_waitstatus_to_string): Fix
8269         obsolete comment.
8270
8271 2019-04-01  Tom Tromey  <tromey@adacore.com>
8272
8273         PR symtab/23331:
8274         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8275
8276 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8277             Pedro Alves  <palves@redhat.com>
8278
8279         * top.c (quit_force): Call 'finalize_values'.
8280         * value.c (finalize_values): New function.
8281         * value.h (finalize_values): Declare.
8282
8283 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8284
8285         * NEWS: Announce $_gdb_major and $_gdb_minor.
8286
8287         * top.c (init_gdb_version_vars): New function.
8288         (gdb_init): Call init_gdb_version_vars.
8289
8290 2019-03-29  Tom Tromey  <tromey@adacore.com>
8291
8292         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8293         help text.  Remove dead code.
8294
8295 2019-03-29  Keith Seitz  <keiths@redhat.com>
8296
8297         From Siddhesh Poyarekar:
8298         * f-lang.h (f77_get_upperbound): Return LONGEST.
8299         (f77_get_lowerbound): Likewise.
8300         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8301         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8302         print them.
8303         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8304         plongest to format print it.
8305         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8306         (f77_get_upperbound): Likewise.
8307         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8308         LOWER_BOUND to LONGEST.
8309         (f77_create_arrayprint_offset_tbl): Likewise.
8310
8311 2019-03-29  Keith Seitz  <keiths@redhat.com>
8312
8313         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8314         %s/pulongest for TYPE_LENGTH instead of %d in format
8315         strings.
8316         * ada-typerint.c (ada_print_type): Likewise.
8317         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8318         * compile/compile-c-support.c (generate_register_struct): Likewise.
8319         * gdbtypes.c (recursive_dump_type): Likewise.
8320         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8321         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8322         instead of %d in format strings.
8323         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8324         to std::min to ULONGEST.
8325         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8326         instead of %d in format strings.
8327         * tracepoint.c (info_scope_command): Likewise.
8328         * typeprint.c (print_offset_data::update)
8329         (print_offset_data::finish): Likewise.
8330         * xtensa-tdep.c (xtensa_store_return_value)
8331         (xtensa_push_dummy_call): Likewise.
8332
8333 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8334
8335         * windows-nat.c (display_selector): Fixed format specifications
8336         for 64-bit Cygwin.
8337
8338 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8339
8340         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8341
8342 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8343
8344         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8345         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8346         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8347         (nios2_linux_init_abi): Install it.
8348
8349 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8350
8351         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8352
8353 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8354
8355         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8356
8357 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8358             Tom Tromey  <tromey@adacore.com>
8359
8360         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8361
8362 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8363
8364         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8365         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8366         method to compute the bounds of range types. Also print "[evaluated]"
8367         if the bounds' values come from a dynamic evaluation.
8368
8369 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8370
8371         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8372         whitespace when pretty printing is on.
8373
8374 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8375
8376         * ppc-linux-nat.c: Add include.
8377
8378 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8379
8380         * NEWS: Mention AArch64 Pointer Authentication.
8381
8382 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8383
8384         * arm-linux-nat.c: Add include.
8385
8386 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8387
8388         * source-cache.c (source_cache::get_source_lines): Re-read
8389         fullname after calling open_source_file.
8390
8391 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8392
8393         * NEWS: Mention TLS support for FreeBSD.
8394
8395 2019-03-25  Tom Tromey  <tromey@adacore.com>
8396
8397         * minsyms.c (BUNCH_SIZE): Update comment.
8398         (~minimal_symbol_reader): Remove old comment.
8399         (compact_minimal_symbols): Update comment.
8400         (minimal_symbol_reader::install): Remove old comment.  Update
8401         other comments.
8402
8403 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8404
8405         * s390-linux-nat.c: Add include.
8406
8407 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8408
8409         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8410         Call linux_get_hwcap.
8411         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8412         Likewise.
8413         (aarch64_linux_get_hwcap): Remove function.
8414         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8415         declaration.
8416         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8417         linux_get_hwcap.
8418         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8419         * linux-tdep.c (linux_get_hwcap): Add function.
8420         (linux_get_hwcap2): Likewise.
8421         * linux-tdep.h (linux_get_hwcap): Add declaration.
8422         (linux_get_hwcap2): Likewise.
8423         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8424         (ppc_linux_get_hwcap2): Likewise.
8425         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8426         linux_get_hwcap.
8427         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8428         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8429         (ppc_linux_nat_target::read_description): Likewise.
8430         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8431         * s390-linux-nat.c: Likewise.
8432         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8433
8434 2019-03-24  Tom Tromey  <tom@tromey.com>
8435
8436         * ada-lang.c (standard_lookup): Simplify initialization.
8437         (ada_lookup_symbol_nonlocal): Simplify return.
8438         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8439         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8440         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8441         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8442         initialization.
8443         * solib.c (solib_global_lookup): Simplify.
8444         * symtab.c (null_block_symbol): Remove.
8445         (symbol_cache_lookup): Simplify returns.
8446         (lookup_language_this): Simplify returns.
8447         (lookup_symbol_aux): Simplify return.
8448         (lookup_local_symbol): Simplify returns.
8449         (lookup_global_symbol_from_objfile): Simplify return.
8450         (lookup_symbol_in_objfile_symtabs)
8451         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8452         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8453         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8454         * cp-namespace.c (cp_lookup_bare_symbol)
8455         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8456         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8457         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8458         (cp_lookup_symbol_via_imports): Simplify initialization.
8459         (find_symbol_in_baseclass): Likewise.
8460         * symtab.h (null_block_symbol): Remove.
8461         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8462         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8463         (d_lookup_symbol_module): Likewise.
8464         (find_symbol_in_baseclass): Simplify initialization.
8465
8466 2019-03-24  Tom Tromey  <tom@tromey.com>
8467
8468         * expression.h: Don't include symtab.h.
8469         (struct block): Forward declare.
8470
8471 2019-03-24  Tom Tromey  <tom@tromey.com>
8472
8473         * c-exp.y (typebase): Remove casts.
8474         * gdbtypes.c (lookup_unsigned_typename, )
8475         (lookup_signed_typename): Remove cast.
8476         * eval.c (parse_to_comma_and_eval): Remove cast.
8477         * parse.c (write_dollar_variable): Remove cast.
8478         * block.h (struct block) <superblock>: Now const.
8479         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8480         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8481         (map_block): Make "block" const.
8482         * symfile.h (struct quick_symbol_functions)
8483         <map_matching_symbols>: Constify block argument to "callback".
8484         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8485         const.
8486         (find_pc_sect_compunit_symtab): Make "b" const.
8487         (find_symbol_at_address): Likewise.
8488         (search_symbols): Likewise.
8489         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8490         (dw2_debug_names_lookup_symbol): Likewise.
8491         (dw2_map_matching_symbols): Update.
8492         * p-valprint.c (pascal_val_print): Remove "block".
8493         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8494         (aux_add_nonlocal_symbols): Make "block" const.
8495         (resolve_subexp): Remove cast.
8496         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8497         const.
8498         (iterate_over_file_blocks): Likewise.
8499         * f-exp.y (%union) <bval>: Remove.
8500         * coffread.c (patch_opaque_types): Make "b" const.
8501         * spu-tdep.c (spu_catch_start): Make "block" const.
8502         * c-valprint.c (print_unpacked_pointer): Remove "block".
8503         * symmisc.c (dump_symtab_1): Make "b" const.
8504         (block_depth): Make "block" const.
8505         * d-exp.y (%union) <bval>: Remove.
8506         * cp-support.h (cp_lookup_rtti_type): Update.
8507         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8508         * psymtab.c (psym_lookup_symbol): Make "block" const.
8509         (maintenance_check_psymtabs): Make "b" const.
8510         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8511         (enumerate_locals, enumerate_args): Update.
8512         * python/py-symtab.c (stpy_global_block): Make "block" const.
8513         (stpy_static_block): Likewise.
8514         * inline-frame.c (block_starting_point_at): Make "new_block"
8515         const.
8516         * block.c (find_block_in_blockvector): Make return type const.
8517         (blockvector_for_pc_sect): Make "b" const.
8518         (find_block_in_blockvector): Make "b" const.
8519
8520 2019-03-23  Tom Tromey  <tom@tromey.com>
8521
8522         * varobj.c (varobj_create): Update.
8523         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8524         * printcmd.c (display_command, do_one_display): Don't reset
8525         innermost_block.
8526         * parser-defs.h (enum innermost_block_tracker_type): Move to
8527         expression.h.
8528         (innermost_block): Update comment.
8529         * parse.c (parse_exp_1): Add tracker_types parameter.
8530         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8531         tracker_types parameter.  Reset innermost_block.
8532         (parse_exp_in_context): Remove.
8533         (parse_expression_for_completion): Update.
8534         * objfiles.c (~objfile): Don't reset expression_context_block or
8535         innermost_block.
8536         * expression.h (enum innermost_block_tracker_type): Move from
8537         parser-defs.h.
8538         (parse_exp_1): Add tracker_types parameter.
8539         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8540         reset innermost_block.
8541
8542 2019-03-23  Tom Tromey  <tom@tromey.com>
8543
8544         * objfiles.h: Include bcache.h.
8545
8546 2019-03-23  Tom Tromey  <tom@tromey.com>
8547
8548         * linespec.c (get_current_search_block): Use
8549         scoped_restore_current_language.
8550         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8551
8552 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8553             Jiong Wang  <jiong.wang@arm.com>
8554
8555         * aarch64-linux-tdep.c
8556         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8557         section.
8558         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8559
8560 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8561             Jiong Wang  <jiong.wang@arm.com>
8562
8563         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8564         instructions.
8565         (aarch64_analyze_prologue_test): Add PACIASP test.
8566         (aarch64_prologue_prev_register): Unmask PC value.
8567
8568 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8569             Jiong Wang  <jiong.wang@arm.com>
8570
8571         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8572         (aarch64_dwarf2_prev_register): Unmask PC value.
8573         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8574         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8575         DW_CFA_AARCH64_negate_ra_state.
8576         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8577
8578 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8579             Jiong Wang  <jiong.wang@arm.com>
8580
8581         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8582         registers.
8583         (aarch64_pseudo_register_name): Likewise.
8584         (aarch64_pseudo_register_type): Likewise.
8585         (aarch64_pseudo_register_reggroup_p): Likewise.
8586         (aarch64_gdbarch_init): Add pauth registers.
8587         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8588         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8589         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8590         (struct gdbarch_tdep): Add regnum for ra_state.
8591
8592 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8593             Jiong Wang  <jiong.wang@arm.com>
8594
8595         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8596
8597 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8598             Jiong Wang  <jiong.wang@arm.com>
8599
8600         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8601         function.
8602         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8603         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8604         (aarch64_gdbarch_init): Add puth registers.
8605         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8606         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8607         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8608
8609 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8610             Jiong Wang  <jiong.wang@arm.com>
8611
8612         * aarch64-linux-nat.c
8613         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8614         * aarch64-linux-tdep.c
8615         (aarch64_linux_core_read_description): Likewise.
8616         (aarch64_linux_get_hwcap): New function.
8617         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8618         (aarch64_linux_get_hwcap): New declaration.
8619
8620 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8621             Jiong Wang  <jiong.wang@arm.com>
8622
8623         * aarch64-linux-nat.c
8624         (aarch64_linux_nat_target::read_description): Add pauth param.
8625         * aarch64-linux-tdep.c
8626         (aarch64_linux_core_read_description): Likewise.
8627         * aarch64-tdep.c (struct target_desc): Add in pauth.
8628         (aarch64_read_description): Add pauth param.
8629         (aarch64_gdbarch_init): Likewise.
8630         * aarch64-tdep.h (aarch64_read_description): Likewise.
8631         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8632         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8633         * features/Makefile: Add new files.
8634         * features/aarch64-pauth.c: New file.
8635         * features/aarch64-pauth.xml: New file.
8636
8637 2019-03-20  Tom Tromey  <tromey@adacore.com>
8638
8639         * infrun.c (handle_inferior_event): Rename from
8640         handle_inferior_event_1.  Create a scoped_value_mark.
8641         (handle_inferior_event): Remove.
8642
8643 2019-03-19  Tom Tromey  <tromey@adacore.com>
8644
8645         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8646         * infrun.h (print_stop_event): Add "displays" parameter.
8647         * infrun.c (print_stop_event): Add "displays" parameter.
8648
8649 2019-03-19  Pedro Alves  <palves@redhat.com>
8650
8651         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8652         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8653         to -1.  Fix TABs vs spaces.
8654         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8655         * tui/tui-out.h (tui_ui_out) Add intro comments.
8656         <m_line, m_start_of_line>: In-class initialize, and add describing
8657         comment.
8658
8659 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8660
8661         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8662         variable names.
8663         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8664
8665 2019-03-18  Pedro Alves  <palves@redhat.com>
8666             Eli Zaretskii <eliz@gnu.org>
8667
8668         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8669         m_line and m_start_of_line.
8670
8671 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8672
8673         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8674         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8675         it returns a newline.  This fixes a regression in TU mode, whereby
8676         the next line is output on the same screen line as the user input.
8677
8678 2019-03-18  Tom Tromey  <tromey@adacore.com>
8679
8680         * minsyms.c (minimal_symbol_reader::install): Remove call to
8681         obstack_blank.
8682
8683 2019-03-18  Pedro Alves  <palves@redhat.com>
8684
8685         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8686         New globals.
8687         (apply_style): New, factored out from ...
8688         (apply_ansi_escape): ... this.  Handle reverse video mode.
8689         (tui_set_reverse_mode): New function.
8690         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8691         * tui/tui-winsource.c (tui_show_source_line): Use
8692         tui_set_reverse_mode instead of setting A_STANDOUT.
8693         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8694         New setter methods.
8695
8696 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8697
8698         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8699         Handle tabs.
8700
8701 2019-03-18  Tom Tromey  <tromey@adacore.com>
8702
8703         * ada-lang.c (empty_array): Add "high" parameter.
8704         (ada_evaluate_subexp): Update.
8705
8706 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8707
8708         * unittests/string_view-selftests.c: Define
8709         _initialize_string_view_selftests unconditionally.
8710
8711 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8712
8713         PR gdb/24350
8714         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8715
8716 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8717
8718         PR gdb/24351
8719         * windows-nat.c (display_selector): Fix format specifiers.
8720
8721 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8722
8723         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8724         tui_refill_source_window instead of tui_refresh_win, to update the
8725         current execution line.  This fixes redisplay of the current line
8726         when stepping through the code with "next" or "step".
8727
8728 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8729
8730         * source-cache.c (source_cache::get_source_lines): Call
8731         find_source_lines to initialize s->nlines.  This fixes vertical
8732         scrolling of TUI source window when the DOWN arrow is pressed.
8733
8734 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8735
8736         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8737         linux-thread-db.c (_initialize_thread_db): Likewise.
8738
8739 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8740
8741         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8742         wclrtoeol in tui_show_source_line".  This reverts changes made in
8743         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8744
8745 2019-03-15  Tom Tromey  <tom@tromey.com>
8746
8747         * symtab.h (struct minimal_symbol): Derive from
8748         general_symbol_info.
8749         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8750         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8751         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8752         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8753         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8754         (MSYMBOL_SEARCH_NAME): Update.
8755         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8756         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8757         * minsyms.c (minimal_symbol_reader::record_full): Update.
8758
8759 2019-03-15  Tom Tromey  <tom@tromey.com>
8760
8761         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8762
8763 2019-03-15  Tom Tromey  <tom@tromey.com>
8764
8765         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8766         unique_xmalloc_ptr.
8767         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8768         Update.
8769         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8770         (build_minimal_symbol_hash_tables)
8771         (minimal_symbol_reader::install): Update.
8772
8773 2019-03-15  Tom Tromey  <tom@tromey.com>
8774
8775         * symtab.c (create_demangled_names_hash): Update.
8776         (symbol_set_names): Update.
8777         * objfiles.h (struct objfile_per_bfd_storage)
8778         <demangled_names_hash>: Now an htab_up.
8779         * objfiles.c (objfile_per_bfd_storage): Simplify.
8780
8781 2019-03-15  Tom Tromey  <tom@tromey.com>
8782
8783         * objfiles.h (struct objfile_per_bfd_storage): Declare
8784         destructor.
8785         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8786         New.
8787         (get_objfile_bfd_data): Use new.  Don't initialize
8788         language_of_main.
8789         (free_objfile_per_bfd_storage): Remove.
8790         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8791
8792 2019-03-15  Tom Tromey  <tom@tromey.com>
8793
8794         * symfile.c (reread_symbols): Update.
8795         * objfiles.c (objfile::objfile): Update.
8796         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8797         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8798         comment.
8799         (minimal_symbol_reader::install): Update.
8800         (terminate_minimal_symbol_table): Remove.
8801         * jit.c (jit_object_close_impl): Update.
8802
8803 2019-03-15  Tom Tromey  <tom@tromey.com>
8804
8805         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8806         initializations.
8807
8808 2019-03-15  Tom Tromey  <tom@tromey.com>
8809
8810         * objfiles.h (struct objfile_per_bfd_storage)
8811         <demangled_hash_languages>: Now a bitset.
8812         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8813         (lookup_minimal_symbol): Update.
8814
8815 2019-03-15  Tom Tromey  <tom@tromey.com>
8816
8817         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8818         Don't return the symbol.
8819         * coffread.c (record_minimal_symbol): Use record_full.
8820
8821 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8822
8823         The MS-Windows port of ncurses fails to switch to a color pair if
8824         one or both of the colors are the implicit default colors.  This
8825         change records the default colors when TUI is initialized, and
8826         then specifies them explicitly when a color pair uses the default
8827         colors.  This allows color styling in TUI mode on MS-Windows.
8828
8829         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8830         ncurses_norm_attr.
8831         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8832         colors in ncurses_norm_attr.
8833         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8834         "none", replace it with the default color recorded in
8835         ncurses_norm_attr.
8836
8837 2019-03-14  Tom Tromey  <tromey@adacore.com>
8838
8839         * source-cache.h (class source_cache) <get_source_lines>: Return
8840         std::string.
8841         * source-cache.c (source_cache::extract_lines): Handle case where
8842         first_pos==npos.  Return std::string.
8843         (source_cache::get_source_lines): Update.
8844
8845 2019-03-14  Tom Tromey  <tromey@adacore.com>
8846
8847         * NEWS: Add item for "style sources" commands.
8848         * source-cache.c (source_cache::get_source_lines): Check
8849         source_styling.
8850         * cli/cli-style.c (source_styling): New global.
8851         (_initialize_cli_style): Add "style sources" commands.
8852         (show_style_sources): New function.
8853         * cli/cli-style.h (source_styling): Declare.
8854
8855 2019-03-14  Pedro Alves  <palves@redhat.com>
8856             Tom Tromey  <tromey@adacore.com>
8857
8858         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8859         * tui/tui-winsource.c (tui_refill_source_window): New function,
8860         from...
8861         (tui_horizontal_source_scroll): ... here.  Move some logic.
8862         * cli/cli-style.c (set_style_enabled): Notify new observable.
8863         * tui/tui-hooks.c (tui_redisplay_source): New function.
8864         (tui_attach_detach_observers): Attach or detach
8865         tui_redisplay_source.
8866         * observable.h (source_styling_changed): New observable.
8867         * observable.c: Define source_styling_changed observable.
8868
8869 2019-03-13  Tom Tromey  <tromey@adacore.com>
8870
8871         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8872         (i386_gnu_nat_target::store_registers): Update.
8873         * target-debug.h (target_debug_print_std_string): New macro.
8874         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8875         * windows-tdep.c (display_one_tib): Update.
8876         * tui/tui-stack.c (tui_make_status_line): Update.
8877         * top.c (print_inferior_quit_action): Update.
8878         * thread.c (thr_try_catch_cmd): Update.
8879         (add_thread_with_info): Update.
8880         (thread_target_id_str): Update.
8881         (thr_try_catch_cmd): Update.
8882         (thread_command): Update.
8883         (thread_find_command): Update.
8884         * record-btrace.c (record_btrace_target::info_record)
8885         (record_btrace_resume_thread, record_btrace_target::resume)
8886         (record_btrace_cancel_resume, record_btrace_step_thread)
8887         (record_btrace_target::wait, record_btrace_target::wait)
8888         (record_btrace_target::wait, record_btrace_target::stop): Update.
8889         * progspace.c (print_program_space): Update.
8890         * process-stratum-target.c
8891         (process_stratum_target::thread_address_space): Update.
8892         * linux-fork.c (linux_fork_mourn_inferior)
8893         (detach_checkpoint_command, info_checkpoints_command)
8894         (linux_fork_context): Update.
8895         (linux_fork_detach): Update.
8896         (class scoped_switch_fork_info): Update.
8897         (delete_checkpoint_command): Update.
8898         * infrun.c (follow_fork_inferior): Update.
8899         (follow_fork_inferior): Update.
8900         (proceed_after_vfork_done): Update.
8901         (handle_vfork_child_exec_or_exit): Update.
8902         (follow_exec): Update.
8903         (displaced_step_prepare_throw): Update.
8904         (displaced_step_restore): Update.
8905         (start_step_over): Update.
8906         (resume_1): Update.
8907         (clear_proceed_status_thread): Update.
8908         (proceed): Update.
8909         (print_target_wait_results): Update.
8910         (do_target_wait): Update.
8911         (context_switch): Update.
8912         (stop_all_threads): Update.
8913         (restart_threads): Update.
8914         (finish_step_over): Update.
8915         (handle_signal_stop): Update.
8916         (switch_back_to_stepped_thread): Update.
8917         (keep_going_pass_signal): Update.
8918         (print_exited_reason): Update.
8919         (normal_stop): Update.
8920         * inferior.c (inferior_pid_to_str): Change return type.
8921         (print_selected_inferior): Update.
8922         (add_inferior): Update.
8923         (detach_inferior): Update.
8924         * dummy-frame.c (fprint_dummy_frames): Update.
8925         * dcache.c (dcache_info_1): Update.
8926         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8927         (btrace_fetch, btrace_clear): Update.
8928         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8929         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8930         type.
8931         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8932         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8933         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8934         * gdbarch.c, gdbarch.h: Rebuild.
8935         * gdbarch.sh (core_pid_to_str): Change return type.
8936         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8937         return type.
8938         (windows_nat_target::pid_to_str): Change return type.
8939         (windows_delete_thread): Update.
8940         (windows_nat_target::attach): Update.
8941         (windows_nat_target::files_info): Update.
8942         * target-delegates.c: Rebuild.
8943         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8944         return type.
8945         (sol_thread_target::pid_to_str): Change return type.
8946         * remote.c (class remote_target) <pid_to_str>: Change return
8947         type.
8948         (remote_target::pid_to_str): Change return type.
8949         (extended_remote_target::attach, remote_target::remote_stop_ns)
8950         (remote_target::remote_notif_remove_queued_reply)
8951         (remote_target::push_stop_reply, remote_target::disable_btrace):
8952         Update.
8953         (extended_remote_target::attach): Update.
8954         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8955         type.
8956         (gdbsim_target::pid_to_str): Change return type.
8957         * ravenscar-thread.c (struct ravenscar_thread_target)
8958         <pid_to_str>: Change return type.
8959         (ravenscar_thread_target::pid_to_str): Change return type.
8960         * procfs.c (class procfs_target) <pid_to_str>: Change return
8961         type.
8962         (procfs_target::pid_to_str): Change return type.
8963         (procfs_target::attach): Update.
8964         (procfs_target::detach): Update.
8965         (procfs_target::fetch_registers): Update.
8966         (procfs_target::store_registers): Update.
8967         (procfs_target::wait): Update.
8968         (procfs_target::files_info): Update.
8969         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8970         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8971         return type.
8972         (nto_procfs_target::pid_to_str): Change return type.
8973         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8974         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8975         return type.
8976         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8977         (exit_lwp): Update.
8978         (attach_proc_task_lwp_callback, get_detach_signal)
8979         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8980         (linux_nat_target::resume, wait_lwp, stop_callback)
8981         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8982         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8983         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8984         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8985         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8986         type.
8987         (inf_ptrace_target::attach): Update.
8988         (inf_ptrace_target::files_info): Update.
8989         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8990         type.
8991         (go32_nat_target::pid_to_str): Change return type.
8992         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8993         (gnu_nat_target::wait): Update.
8994         (gnu_nat_target::wait): Update.
8995         (gnu_nat_target::resume): Update.
8996         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8997         (fbsd_nat_target::wait): Update.
8998         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8999         type.
9000         (darwin_nat_target::attach): Update.
9001         * corelow.c (class core_target) <pid_to_str>: Change return type.
9002         (core_target::pid_to_str): Change return type.
9003         * target.c (normal_pid_to_str): Change return type.
9004         (default_pid_to_str): Likewise.
9005         (target_pid_to_str): Change return type.
9006         (target_translate_tls_address): Update.
9007         (target_announce_detach): Update.
9008         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9009         return type.
9010         (bsd_uthread_target::pid_to_str): Change return type.
9011         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9012         type.
9013         (bsd_kvm_target::pid_to_str): Change return type.
9014         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9015         return type.
9016         (aix_thread_target::pid_to_str): Change return type.
9017         * target.h (struct target_ops) <pid_to_str>: Change return type.
9018         (target_pid_to_str, normal_pid_to_str): Likewise.
9019         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9020         type.
9021         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9022         type.
9023         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9024         return type.
9025         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9026         type.
9027         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9028         type.
9029         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9030         return type.
9031
9032 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9033
9034         * NEWS: Mention that the new default MI version is 3.  Mention
9035         changes to the output of commands and events that deal with
9036         multi-location breakpoints.
9037         * breakpoint.c: Include "mi/mi-out.h".
9038         (print_one_breakpoint): Change output syntax if using MI version
9039         >= 3.
9040         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9041         New.
9042         (mi_multi_location_breakpoint_output_fixed): New.
9043         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9044         (mi_cmd_fix_multi_location_breakpoint_output): New.
9045         (mi_multi_location_breakpoint_output_fixed): New.
9046         * mi/mi-cmds.c (mi_cmds): Register command
9047         -fix-multi-location-breakpoint-output.
9048         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9049         interpreter "mi".
9050
9051 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9052
9053         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9054         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9055         instantiate mi_ui_out based on interpreter name.
9056         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9057         * mi/mi-main.c (mi_load_progress): Likewise.
9058
9059 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9060
9061         * NEWS: Combine separate "New targets" sections for 8.3.
9062
9063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9064
9065         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9066         (ppcfbsd_init_abi): Install gdbarch
9067         "fetch_tls_load_module_address" and "get_thread_local_address"
9068         methods.
9069
9070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9071
9072         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9073         (riscv_fbsd_init_abi): Install gdbarch
9074         "fetch_tls_load_module_address" and "get_thread_local_address"
9075         methods.
9076
9077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9078
9079         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9080         (i386fbsd_init_abi): Install gdbarch
9081         "fetch_tls_load_module_address" and "get_thread_local_address"
9082         methods.
9083
9084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9085
9086         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9087         (amd64fbsd_init_abi): Install gdbarch
9088         "fetch_tls_load_module_address" and "get_thread_local_address"
9089         methods.
9090
9091 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9092
9093         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9094         (struct fbsd_pspace_data): New type.
9095         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9096         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9097         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9098         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9099         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9100
9101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9102
9103         * gdbtypes.c (lookup_struct_elt): New function.
9104         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9105         * gdbtypes.h (struct struct_elt): New type.
9106         (lookup_struct_elt): New prototype.
9107
9108 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9109
9110         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9111         remove disabled code block.
9112
9113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9114
9115         * gdbarch.sh (get_thread_local_address): New method.
9116         * gdbarch.h, gdbarch.c: Regenerate.
9117         * target.c (target_translate_tls_address): Use
9118         gdbarch_get_thread_local_address if present instead of
9119         target::get_thread_local_address.
9120
9121 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9122
9123         * target.h (target::get_thread_local_address): Update comment.
9124
9125 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9126
9127         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9128         objfile->separate_debug_objfile_backlink if not NULL.
9129
9130 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9131
9132         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9133         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9134         (amd64bsd_store_inferior_registers): Likewise.
9135         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9136         Enable segment base registers.
9137         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9138         PT_GETFSBASE and PT_GETGSBASE.
9139         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9140         PT_SETGSBASE.
9141         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9142         segment base registers.
9143         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9144
9145 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9146
9147         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9148         Update calls to i386_target_description to add 'segments'
9149         parameter.
9150         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9151         add segment base registers.
9152         * arch/i386.c (i386_create_target_description): Add 'segments'
9153         parameter to enable segment base registers.
9154         * arch/i386.h (i386_create_target_description): Likewise.
9155         * features/i386/32bit-segments.xml: New file.
9156         * features/i386/32bit-segments.c: Generate.
9157         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9158         call to i386_target_description to add 'segments' parameter.
9159         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9160         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9161         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9162         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9163         if feature is present.
9164         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9165         Add 'segments' parameter to call to i386_target_description.
9166         (i386_target_description): Add 'segments' parameter to enable
9167         segment base registers.
9168         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9169         to call to i386_target_description.
9170         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9171         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9172         Define I386_NUM_REGS.
9173         (i386_target_description): Add 'segments' parameter to enable
9174         segment base registers.
9175
9176 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9177
9178         PR/24325
9179         * source-cache.c: #undef open and close, to avoid unresolved
9180         externals during linking.
9181
9182 2019-03-12  Tom Tromey  <tromey@adacore.com>
9183
9184         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9185         const.  Add initializers.
9186         (_initialize_remote): Don't initialize ptid globals.
9187
9188 2019-03-12  Pedro Alves  <palves@redhat.com>
9189
9190         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9191
9192 2019-03-12  Pedro Alves  <palves@redhat.com>
9193
9194         * cp-name-parser.y (main): Remove unused 'len' variable.
9195
9196 2019-03-12  Tom Tromey  <tromey@adacore.com>
9197
9198         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9199         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9200
9201 2019-03-12  Tom Tromey  <tromey@adacore.com>
9202
9203         * linux-nat.c (iterate_over_lwps): Update.
9204         (stop_callback): Remove parameter.
9205         (stop_wait_callback, detach_callback, resume_set_callback)
9206         (select_singlestep_lwp_callback, set_ignore_sigint)
9207         (status_callback, resumed_callback, resume_clear_callback)
9208         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9209         data parameter.
9210         (linux_nat_target::detach, linux_nat_target::resume)
9211         (linux_stop_and_wait_all_lwps, select_event_lwp)
9212         (linux_nat_filter_event, linux_nat_wait_1)
9213         (linux_nat_target::kill, linux_nat_target::stop)
9214         (linux_nat_target::stop): Update.
9215         (linux_nat_resume_callback): Change type.
9216         (resume_stopped_resumed_lwps, count_events_callback)
9217         (select_event_lwp_callback): Likewise.
9218         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9219         * arm-linux-nat.c (struct update_registers_data): Remove.
9220         (update_registers_callback): Change type.
9221         (arm_linux_insert_hw_breakpoint1): Update.
9222         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9223         parameter.
9224         (x86_linux_dr_set_addr): Update.
9225         (x86_linux_dr_set_control): Update.
9226         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9227         (iterate_over_lwps): Use gdb::function_view.
9228         * nat/aarch64-linux-hw-point.c (struct
9229         aarch64_dr_update_callback_param): Remove.
9230         (debug_reg_change_callback): Change type.
9231         (aarch64_notify_debug_reg_change): Update.
9232         * s390-linux-nat.c (s390_refresh_per_info): Update.
9233
9234 2019-03-11  Tom Tromey  <tromey@adacore.com>
9235
9236         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9237         redundant assignment to "this_cu".
9238
9239 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9240
9241         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9242
9243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9244
9245         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9246         from...
9247         (rank_one_type): ... this.
9248
9249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9250
9251         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9252         from...
9253         (rank_one_type): ... this.
9254
9255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9256
9257         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9258         from...
9259         (rank_one_type): ... this.
9260
9261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9262
9263         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9264         from...
9265         (rank_one_type): ... this.
9266
9267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9268
9269         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9270         from...
9271         (rank_one_type): ... this.
9272
9273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9274
9275         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9276         from...
9277         (rank_one_type): ... this.
9278
9279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9280
9281         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9282         from...
9283         (rank_one_type): ... this.
9284
9285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9286
9287         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9288         from...
9289         (rank_one_type): ... this.
9290
9291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9292
9293         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9294         from...
9295         (rank_one_type): ... this.
9296
9297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9298
9299         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9300         from...
9301         (rank_one_type): ... this.
9302
9303 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9304
9305         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9306         from...
9307         (rank_one_type): ... this.
9308
9309 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9310
9311         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9312         from...
9313         (rank_one_type): ... this.
9314
9315 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9316
9317         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9318         inferior-events' shows the example events.
9319
9320 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9321
9322         Support styling on native MS-Windows console
9323
9324         PR/24315
9325         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9326         on MS-Windows if $TERM is not defined.
9327
9328         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9329
9330         * posix-hdep.c (gdb_console_fputs):
9331         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9332         functions.
9333         * ui-file.h (gdb_console_fputs): Add prototype.
9334
9335         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9336         back to fputs only if the former returns zero.
9337
9338 2019-03-07  Tom Tromey  <tom@tromey.com>
9339
9340         * symmisc.c (print_symbol_bcache_statistics): Update.
9341         (print_objfile_statistics): Update.
9342         * symfile.c (allocate_symtab): Update.
9343         * stabsread.c: Don't include bcache.h.
9344         * psymtab.h (struct psymbol_bcache): Don't declare.
9345         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9346         (psymbol_bcache_init, psymbol_bcache_free)
9347         (psymbol_bcache_get_bcache): Don't declare.
9348         * psymtab.c (struct psymbol_bcache): Remove.
9349         (psymtab_storage::psymtab_storage): Update.
9350         (psymtab_storage::~psymtab_storage): Update.
9351         (psymbol_bcache_init, psymbol_bcache_free)
9352         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9353         (add_psymbol_to_bcache): Update.
9354         (allocate_psymtab): Update.
9355         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9356         macro_cache>: No longer pointers.
9357         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9358         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9359         * macrotab.c (macro_bcache): Update.
9360         * macroexp.c: Don't include bcache.h.
9361         * gdbtypes.c (check_types_worklist): Update.
9362         (types_deeply_equal): Remove TRY/CATCH.  Update.
9363         * elfread.c (elf_symtab_read): Update.
9364         * dwarf2read.c: Don't include bcache.h.
9365         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9366         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9367         (print_bcache_statistics, bcache_memory_used): Don't declare.
9368         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9369         methods.  Rename all data members.
9370         * bcache.c (struct bcache): Move to bcache.h.
9371         (bcache::expand_hash_table): Rename from expand_hash_table.
9372         (bcache): Remove.
9373         (bcache::insert): Rename from bcache_full.
9374         (bcache::compare): Rename from bcache_compare.
9375         (bcache_xmalloc): Remove.
9376         (bcache::~bcache): Rename from bcache_xfree.
9377         (bcache::print_statistics): Rename from print_bcache_statistics.
9378         (bcache::memory_used): Rename from bcache_memory_used.
9379
9380 2019-03-07  Pedro Alves  <palves@redhat.com>
9381
9382         * infrun.c (normal_stop): Also check for
9383         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9384
9385 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9386
9387         * f-lang.c (value_from_host_double): Moved to...
9388         * value.c (value_from_host_double): ...here.
9389         * value.h (value_from_host_double): Declare.
9390         * guile/scm-math.c (vlscm_convert_typed_number): Use
9391         value_from_host_double.
9392         (vlscm_convert_number): Likewise.
9393         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9394         * python/py-value.c (convert_value_from_python): Likewise.
9395
9396 2019-03-06  Tom Tromey  <tom@tromey.com>
9397
9398         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9399
9400 2019-03-06  Tom Tromey  <tom@tromey.com>
9401
9402         * utils.h (free_current_contents): Don't declare.
9403         * utils.c (free_current_contents): Remove.
9404
9405 2019-03-06  Tom Tromey  <tom@tromey.com>
9406
9407         * top.c (quit_force): Update.
9408         * main.c (captured_command_loop): Update.
9409         * common/new-op.c (operator new): Update.
9410         * common/common-exceptions.c (struct catcher)
9411         <save_cleanup_chain>: Remove member.
9412         (exceptions_state_mc_init): Update.
9413         (exception_try_scope_entry): Return nullptr.
9414         (exception_try_scope_exit, exception_rethrow)
9415         (throw_exception_sjlj, throw_exception_cxx): Update.
9416         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9417         (all_cleanups, do_cleanups, discard_cleanups)
9418         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9419         (restore_cleanups, restore_final_cleanups): Don't declare.
9420         (do_final_cleanups): Remove parameter.
9421         * common/cleanups.c (cleanup_chain, make_cleanup)
9422         (make_cleanup_dtor, all_cleanups, do_cleanups)
9423         (discard_my_cleanups, discard_cleanups)
9424         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9425         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9426         (null_cleanup): Remove.
9427         (do_final_cleanups): Remove parameter.
9428
9429 2019-03-06  Tom Tromey  <tom@tromey.com>
9430
9431         * remote.c (remote_target::remote_parse_stop_reply): Use
9432         unique_xmalloc_ptr.
9433
9434 2019-03-06  Tom Tromey  <tom@tromey.com>
9435
9436         * stabsread.c (struct stabs_field_info): Rename from field_info.
9437         <list, fnlist>: Add initializers.
9438         <obstack>: New member.
9439         (read_member_functions, read_struct_fields, read_baseclasses):
9440         Allocate on obstack.  Don't use cleanups.
9441         (read_one_struct_field, read_member_functions, read_struct_fields)
9442         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9443         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9444         (read_struct_type): Update.
9445
9446 2019-03-06  Tom Tromey  <tom@tromey.com>
9447
9448         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9449         * common/filestuff.h (make_cleanup_close): Don't declare.
9450         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9451         Remove.
9452
9453 2019-03-06  Tom Tromey  <tom@tromey.com>
9454
9455         * solib-aix.c: Use make_scope_exit.
9456
9457 2019-03-06  Tom Tromey  <tom@tromey.com>
9458
9459         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9460         Use make_scope_exit.
9461
9462 2019-03-06  Tom Tromey  <tom@tromey.com>
9463
9464         * solib-svr4.c (disable_probes_interface): Remove parameter.
9465         (svr4_handle_solib_event): Use make_scope_exit.
9466
9467 2019-03-06  Tom Tromey  <tom@tromey.com>
9468
9469         * remote.c (struct stop_reply_deleter): Remove.
9470         (stop_reply_up): Update.
9471         (struct stop_reply): Derive from notif_event.  Don't typedef.
9472         <regcache>: Now a std::vector.
9473         (stop_reply_xfree): Remove.
9474         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9475         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9476         (remote_target::discard_pending_stop_replies): Use delete.
9477         (remote_target::remote_parse_stop_reply): Update.
9478         (remote_target::process_stop_reply): Update.
9479         * remote-notif.h (struct notif_event): Add virtual destructor.
9480         Remove "dtr" member.
9481         (struct notif_client) <alloc_event>: Return a unique_ptr.
9482         (notif_event_xfree): Don't declare.
9483         (notif_event_up): New typedef.
9484         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9485         (notif_event_xfree, do_notif_event_xfree): Remove.
9486         (remote_notif_state_xfree): Update.
9487
9488 2019-03-06  Tom Tromey  <tom@tromey.com>
9489
9490         * infrun.c (displaced_step_clear_cleanup): Now a
9491         forward_scope_exit type.
9492         (displaced_step_prepare_throw): Update.
9493         (displaced_step_fixup): Update.
9494
9495 2019-03-06  Tom Tromey  <tom@tromey.com>
9496
9497         * inferior.h (class inferior): Update comment.
9498         * gdbthread.h (class thread_info): Update comment.
9499
9500 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9501             Tom Tromey  <tom@tromey.com>
9502
9503         * stabsread.h (struct stab_section_list): Remove.
9504         (coffstab_build_psymtabs): Update.
9505         * dbxread.c (symbuf_sections): Now a std::vector.
9506         (sect_idx): New global.
9507         (fill_symbuf): Update.
9508         (coffstab_build_psymtabs): Change type of stabsects parameter.
9509         Update.
9510         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9511         std::vector.
9512         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9513         (coff_locate_sections): Update.
9514         (coff_symfile_read): Remove cleanups.  Update.
9515         (init_stringtab): Add storage parameter.
9516         (free_stringtab, free_stringtab_cleanup): Remove.
9517         (init_lineno): Add storage parameter.
9518         (free_linetab, free_linetab_cleanup): Remove.
9519
9520 2019-03-06  Pedro Alves  <palves@redhat.com>
9521
9522         * linux-fork.c (fork_info::clobber_regs): Delete.
9523         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9524         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9525         comment.  Adjust.
9526         (scoped_switch_fork_info::scoped_switch_fork_info)
9527         (checkpoint_command, linux_fork_context): Adjust
9528         fork_save_infrun_state calls.
9529
9530 2019-03-06  Pedro Alves  <palves@redhat.com>
9531
9532         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9533         (inf_has_multiple_threads): Return 'bool' and rewrite using
9534         inferior_info::threads().
9535
9536 2019-03-06  Pedro Alves  <palves@redhat.com>
9537
9538         * linux-fork.c: Include <list>.
9539         (fork_list): Now a std::list instance.
9540         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9541         (forks_exist_p, find_last_fork): Adjust.
9542         (new_fork): Delete.
9543         (one_fork_p): New.
9544         (add_fork): Adjust.
9545         (free_fork): Delete, folded into fork_info::~fork_info().
9546         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9547         Adjust.
9548         (init_fork_list): Delete.
9549         (linux_fork_killall, linux_fork_mourn_inferior)
9550         (linux_fork_detach, info_checkpoints_command): Adjust.
9551         (_initialize_linux_fork): No longer call init_fork_list.
9552
9553 2019-03-06  Pedro Alves  <palves@redhat.com>
9554
9555         * linux-fork.c (new_fork): New, split out of ...
9556         (add_fork): ... this.  Return void.  Move "first fork" special
9557         case from here, to ...
9558         (checkpoint_command): ... here.
9559         * linux-linux.h (add_fork): Return void.
9560
9561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9562
9563         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9564
9565 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9566             Chris January  <chris.january@arm.com>
9567             David Lecomber  <david.lecomber@arm.com>
9568
9569         * f-exp.y: New token, UNOP_INTRINSIC.
9570         (exp): New pattern using UNOP_INTRINSIC token.
9571         (f77_keywords): Add 'abs' keyword.
9572         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9573         (value_from_host_double): New function.
9574         (evaluate_subexp_f): Support UNOP_ABS.
9575
9576 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9577
9578         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9579         types.
9580
9581 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9582
9583         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9584         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9585         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9586
9587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9588
9589         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9590
9591 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9592             Chris January  <chris.january@arm.com>
9593
9594         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9595         * f-exp.y: Define 'KIND' token.
9596         (exp): New pattern for KIND expressions.
9597         (ptype): Handle types with a kind extension.
9598         (direct_abs_decl): Extend to spot kind extensions.
9599         (f77_keywords): Add 'kind' to the list.
9600         (push_kind_type): New function.
9601         (convert_to_kind_type): New function.
9602         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9603         * parse.c (operator_length_standard): Likewise.
9604         * parser-defs.h (enum type_pieces): Add tp_kind.
9605         * std-operator.def: Add UNOP_KIND.
9606
9607 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9608
9609         * f-exp.y (f_parse): Set yydebug.
9610
9611 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9612
9613         * f-lang.c (evaluate_subexp_f): New function.
9614         (exp_descriptor_f): New global.
9615         (f_language_defn): Use exp_descriptor_f instead of
9616         exp_descriptor_standard.
9617
9618 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9619
9620         * f-exp.y (struct token): Add comments.
9621         (dot_ops): Remove uppercase versions and the end marker.
9622         (f77_keywords): Likewise.
9623         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9624         entries in the dot_ops array are case insensitive, and use
9625         strncasecmp to compare strings.  Also some whitespace cleanup in
9626         this area.  Similar for the f77_keywords array, except entries in
9627         this list might be case sensitive.
9628
9629 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9630
9631         * f-exp.y (struct f77_boolean_val): Add comments.
9632         (boolean_values): Remove uppercase versions, and end marker.
9633         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9634         and use strncasecmp to achieve case insensitivity.  Additionally,
9635         perform whitespace cleanup around this code.
9636
9637 2019-03-06  Tom Tromey  <tromey@adacore.com>
9638
9639         * remote-sim.c (gdbsim_target_open): Use result of
9640         gdb_argv::release.
9641
9642 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9643         Dirk Schubert  <dirk.schubert@arm.com>
9644         Chris January  <chris.january@arm.com>
9645
9646         * eval.c (evaluate_subexp_standard): Call Fortran argument
9647         wrapping logic.
9648         * f-lang.c (struct value): A value which can be passed into a
9649         Fortran function call.
9650         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9651         where appropriate.
9652         (struct type): Value ready for a Fortran function call.
9653         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9654         is needed.
9655         * f-lang.h (fortran_argument_convert): Declaration.
9656         (fortran_preserve_arg_pointer): Declaration.
9657         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9658
9659 2019-03-05  Tom Tromey  <tromey@adacore.com>
9660
9661         * python/py-prettyprint.c (print_string_repr): Remove #if.
9662         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9663
9664 2019-03-05  Tom Tromey  <tromey@adacore.com>
9665
9666         * target.c (the_dummy_target): Move later.  Change type to
9667         "dummy_target".
9668         (initialize_targets): Don't initialize the_dummy_target.
9669
9670 2019-03-05  Tom Tromey  <tromey@adacore.com>
9671
9672         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9673         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9674
9675 2019-03-05  Tom Tromey  <tromey@adacore.com>
9676
9677         * windows-nat.c (windows_nat_target::attach)
9678         (windows_nat_target::detach): Don't call gdb_flush.
9679         * valprint.c (generic_val_print, val_print, val_print_string):
9680         Don't call gdb_flush.
9681         * utils.c (defaulted_query): Don't call gdb_flush.
9682         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9683         * target.c (target_announce_detach): Don't call gdb_flush.
9684         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9685         * remote.c (extended_remote_target::attach): Don't call
9686         gdb_flush.
9687         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9688         * printcmd.c (do_examine): Don't call gdb_flush.
9689         (info_display_command): Don't call gdb_flush.
9690         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9691         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9692         * memattr.c (info_mem_command): Don't call gdb_flush.
9693         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9694         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9695         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9696         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9697         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9698         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9699         (gnu_nat_target::detach): Don't call gdb_flush.
9700         * f-valprint.c (f_val_print): Don't call gdb_flush.
9701         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9702         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9703         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9704         gdb_flush.
9705         * c-valprint.c (c_val_print): Don't call gdb_flush.
9706         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9707
9708 2019-03-05  Tom Tromey  <tromey@adacore.com>
9709
9710         * varobj.c (update_dynamic_varobj_children): Update.
9711         (install_default_visualizer): Use reset, not release.
9712         * value.c (set_internalvar): Update.
9713         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9714         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9715         ATTRIBUTE_UNUSED_RESULT.
9716
9717 2019-03-05  Tom Tromey  <tromey@adacore.com>
9718
9719         * remote.c (class scoped_remote_fd) <release>: Add
9720         ATTRIBUTE_UNUSED_RESULT.
9721
9722 2019-03-05  Tom Tromey  <tromey@adacore.com>
9723
9724         * macroexp.c (struct macro_buffer) <release>: Add
9725         ATTRIBUTE_UNUSED_RESULT.
9726
9727 2019-03-05  Tom Tromey  <tromey@adacore.com>
9728
9729         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9730         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9731         ATTRIBUTE_UNUSED_RESULT.
9732
9733 2019-03-05  Tom Tromey  <tromey@adacore.com>
9734
9735         * common/scoped_fd.h (class scoped_fd) <release>: Add
9736         ATTRIBUTE_UNUSED_RESULT.
9737
9738 2019-03-05  Tom Tromey  <tromey@adacore.com>
9739
9740         * parser-defs.h (struct parser_state) <release>: Add
9741         ATTRIBUTE_UNUSED_RESULT.
9742
9743 2019-03-05  Tom Tromey  <tromey@adacore.com>
9744
9745         * utils.h (class gdb_argv) <release>: Add
9746         ATTRIBUTE_UNUSED_RESULT.
9747         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9748
9749 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9750
9751         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9752         for-loop range, to avoid compiler warnings.
9753
9754         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9755         avoid compiler warnings about unused variables.
9756
9757         * NEWS: Mention end of support for native debugging on MS-Windows
9758         before XP.
9759
9760         PR gdb/24292
9761         * common/netstuff.c:
9762         * gdbserver/gdbreplay.c
9763         * gdbserver/remote-utils.c:
9764         * ser-tcp.c:
9765         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9766         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9767         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9768         'getaddrinfo' and 'freeaddrinfo' were not available before
9769         Windows XP, and mingw.org's MinGW headers by default define
9770         _WIN32_WINNT to 0x500.
9771
9772 2019-03-01  Gary Benson <gbenson@redhat.com>
9773
9774         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9775
9776 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9777             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9778
9779         PR gdb/8527
9780         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9781         set_sigint_trap, clear_sigint_trap.
9782
9783 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9784
9785         * target.c (target_detach): Clear the regcache and the
9786         frame cache.
9787
9788 2019-02-27  Pedro Alves  <palves@redhat.com>
9789
9790         * utils.c (set_screen_size): When we cap the height/width sizes,
9791         tweak the corresponding command variable to show "unlimited":
9792
9793 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9794             Pedro Alves  <palves@redhat.com>
9795
9796         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9797         before calling rl_set_screen_size.
9798
9799 2019-02-27  Tom Tromey  <tromey@adacore.com>
9800
9801         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9802         define.
9803         * python/py-value.c: Remove Python 2.4 workaround.
9804         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9805         workaround.
9806         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9807         Python 2.4 workaround.
9808         * python/python-internal.h: Remove Python 2.4 comment.
9809         (Py_ssize_t): Don't define.
9810         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9811         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9812         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9813         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9814         * python/python.c (do_start_initialization): Remove Python 2.4
9815         workaround.
9816         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9817         (print_children): Remove Python 2.4 workaround.
9818         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9819         workaround.
9820         (CHARBUFFERPROC_NAME): Remove.
9821         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9822         Python 2.4 workaround.
9823
9824 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9825
9826         * NEWS: Note minimum Python version.
9827
9828 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9829
9830         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9831         code from these functions.  Remove corresponding ifdefs.  Use
9832         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9833         Remove gotos and target of gotos.
9834         (infpy_search_memory): Likewise.
9835
9836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9837
9838         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9839         (hppa_gdbarch_init): Don't register deleted functions with
9840         gdbarch.
9841
9842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9843
9844         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9845         (h8300_unwind_sp): Delete.
9846         (h8300_dummy_id): Delete.
9847         (h8300_gdbarch_init): Don't register deleted functions with
9848         gdbarch.
9849
9850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9851
9852         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9853         (ft32_unwind_pc): Delete.
9854         (ft32_unwind_sp): Delete.
9855         (ft32_gdbarch_init): Don't register deleted functions with
9856         gdbarch.
9857
9858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9859
9860         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9861         (frv_unwind_pc): Delete.
9862         (frv_unwind_sp): Delete.
9863         (frv_gdbarch_init): Don't register deleted functions with
9864         gdbarch.
9865
9866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9867
9868         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9869         (riscv_unwind_pc): Delete.
9870         (riscv_unwind_sp): Delete.
9871         (riscv_gdbarch_init): Don't register deleted functions with
9872         gdbarch.
9873
9874 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9875
9876         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9877         (csky_unwind_pc): Delete.
9878         (csky_unwind_sp): Delete.
9879         (csky_gdbarch_init): Don't register deleted functions with
9880         gdbarch.
9881
9882 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9883
9884         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9885         (cris_unwind_pc): Delete.
9886         (cris_unwind_sp): Delete.
9887         (cris_gdbarch_init): Don't register deleted functions with
9888         gdbarch.
9889
9890 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9891
9892         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9893         (bfin_unwind_pc): Delete.
9894         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9895
9896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9897
9898         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9899         (arm_unwind_pc): Delete.
9900         (arm_unwind_sp): Delete.
9901         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9902
9903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9904
9905         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9906         (arc_unwind_pc): Delete.
9907         (arc_unwind_sp): Delete.
9908         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9909
9910 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9911
9912         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9913         (alpha_unwind_pc): Delete.
9914         (alpha_gdbarch_init): Don't register deleted functions with
9915         gdbarch.
9916
9917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9918
9919         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9920         (aarch64_unwind_pc): Delete.
9921         (aarch64_unwind_sp): Delete.
9922         (aarch64_gdbarch_init): Don't register deleted functions with
9923         gdbarch.
9924
9925 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9926
9927         * gdbtypes.c (type_align): Don't consider static members when
9928         computing structure alignment.
9929
9930 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9931
9932         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9933         return 0 for other types.
9934         * arch-utils.c (default_type_align): Always return 0.
9935         * gdbarch.h: Regenerate.
9936         * gdbarch.sh (type_align): Extend comment.
9937         * gdbtypes.c (type_align): Add additional comments, always call
9938         gdbarch_type_align before applying the default rules.
9939         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9940         generic code will then apply a suitable default.
9941         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9942         types, return 0 for other types.
9943
9944 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9945
9946         * NEWS: Create a new section for the next release branch.
9947         Rename the section of the current branch, now that it has
9948         been cut.
9949
9950 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9951
9952         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9953         * version.in: Bump version to 8.3.50.DATE-git.
9954
9955 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9956
9957         * aix-thread.c (ptid_cmp): Remove unused variable.
9958         (get_signaled_thread): Likewise.
9959         (store_regs_user_thread): Likewise.
9960         (store_regs_kernel_thread): Likewise.
9961         (fetch_regs_kernel_thread): Remove shadowed variable.
9962
9963 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9964
9965         * features/riscv/32bit-cpu.xml: Add register numbers.
9966         * features/riscv/32bit-fpu.c: Regenerate.
9967         * features/riscv/32bit-fpu.xml: Add register numbers.
9968         * features/riscv/64bit-cpu.xml: Add register numbers.
9969         * features/riscv/64bit-fpu.c: Regenerate.
9970         * features/riscv/64bit-fpu.xml: Add register numbers.
9971
9972 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9973
9974         * NEWS: Mention two argument form of gdb.Value constructor.
9975         * python/py-value.c (convert_buffer_and_type_to_value): New
9976         function.
9977         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9978         Add support for handling an optional second argument.  Call
9979         convert_buffer_and_type_to_value as appropriate.
9980         * python/python-internal.h (Py_buffer_deleter): New struct.
9981         (Py_buffer_up): New typedef.
9982
9983 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9984
9985         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9986         instead of releasing ownership.
9987
9988 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9989
9990         * dwarf2read.c (open_and_init_dwp_file): Call
9991         elf_numsections instead of bfd_count_sections to initialize
9992         dwp_file->num_sections.
9993
9994 2019-02-25  Tom Tromey  <tromey@adacore.com>
9995
9996         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9997
9998 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9999
10000         * gcore.in: Add '--readnever' option when invoking GDB.
10001
10002 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10003
10004         * MAINTAINERS: Update my email address.
10005
10006 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10007
10008         * build-id.c (build_id_to_debug_bfd_1): New function.
10009         (build_id_to_debug_bfd): Look for separate debug file in
10010         sysroot.
10011
10012 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10013
10014         * gdbarch.sh: Update the copyright year range that is placed into
10015         generated files.
10016
10017 2019-02-22  Keith Seitz  <keiths@redhat.com>
10018
10019         PR symtab/23853
10020         * linespec.c (create_sals_line_offset): Search for the default
10021         symtab's filename instead of its fullname.
10022
10023 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10024
10025         * NEWS: Update style defaults.
10026
10027 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10028
10029         * main.c (captured_main_1): Disable styling in batch mode.
10030
10031 2019-02-20  Tom Tromey  <tom@tromey.com>
10032
10033         * symtab.c (symtab_symbol_info): Fix typos.
10034
10035 2019-02-20  Tom Tromey  <tromey@adacore.com>
10036
10037         * findcmd.c (_initialize_mem_search): Use upper case for
10038         metasyntactic variables.
10039
10040 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10041
10042         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10043         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10044
10045 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10046
10047         * top.h (source_file_name): Change to std::string.
10048         * top.c (source_file_name): Likewise.
10049         (command_line_input): Adjust.
10050         * cli/cli-script.c (script_from_file): Adjust.
10051
10052 2019-02-19  Tom Tromey  <tromey@adacore.com>
10053
10054         * ravenscar-thread.c
10055         (ravenscar_thread_target::update_thread_list): Don't call
10056         ada_build_task_list.
10057         * ada-lang.h (ada_build_task_list): Don't declare.
10058         * ada-tasks.c (struct ada_tasks_inferior_data)
10059         <task_list_valid_p>: Now bool.
10060         (read_known_tasks, ada_task_list_changed)
10061         (ada_tasks_invalidate_inferior_data): Update.
10062         (read_known_tasks_array): Return bool.
10063         (read_known_tasks_list): Likewise.
10064         (read_known_tasks): Return void.
10065         (ada_build_task_list): Now static.
10066
10067 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10068
10069         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10070         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10071
10072 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10073
10074         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10075         variant for ada_tasks_pspace_data_handle and
10076         ada_tasks_inferior_data_handle.
10077         (ada_tasks_pspace_data_cleanup): New function.
10078         (ada_tasks_inferior_data_cleanup): New function.
10079
10080 2019-02-17  Tom Tromey  <tom@tromey.com>
10081
10082         * macrotab.h (macro_source_fullname): Return a std::string.
10083         * macrotab.c (macro_include, check_for_redefinition)
10084         (macro_undef, macro_lookup_definition, foreach_macro)
10085         (foreach_macro_in_scope): Update.
10086         (macro_source_fullname): Return a std::string.
10087         * macrocmd.c (show_pp_source_pos): Update.
10088
10089 2019-02-17  Tom Tromey  <tom@tromey.com>
10090
10091         * macrocmd.c (show_pp_source_pos): Style the file names.
10092
10093 2019-02-17  Tom Tromey  <tom@tromey.com>
10094
10095         PR tui/24197:
10096         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10097
10098 2019-02-17  Tom Tromey  <tom@tromey.com>
10099
10100         * ada-lang.c (user_select_syms): Use filtered printing.
10101         * utils.c (wrap_style): New global.
10102         (desired_style): Remove.
10103         (emit_style_escape): Add stream parameter.
10104         (set_output_style, reset_terminal_style, prompt_for_continue):
10105         Update.
10106         (flush_wrap_buffer): Only flush gdb_stdout.
10107         (wrap_here): Set wrap_style.
10108         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10109         treat escape sequences as a character.  Change when wrap buffer is
10110         flushed.
10111         (fputs_styled): Do not set the output style when the default is
10112         requested.
10113         * ui-style.h (struct ui_file_style) <is_default>: New method.
10114         * source.c (print_source_lines_base): Emit escape sequences in one
10115         piece.
10116
10117 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10118
10119         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10120         integers and enumeration types.
10121
10122 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10123
10124         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10125         instead of lookup_symbol_in_language
10126         (do_exact_match): New function.
10127         (ada_get_symbol_name_matcher): Return do_exact_match when
10128         doing a verbatim match.
10129
10130 2019-02-15  Tom Tromey  <tromey@adacore.com>
10131
10132         * ravenscar-thread.c (ravenscar_thread_target::resume)
10133         (ravenscar_thread_target::wait): Special case wildcard requests.
10134
10135 2019-02-15  Tom Tromey  <tromey@adacore.com>
10136
10137         * ravenscar-thread.c (base_ptid): Remove.
10138         (struct ravenscar_thread_target) <close>: New method.
10139         <m_base_ptid>: New member.
10140         <update_inferior_ptid, active_task, task_is_currently_active,
10141         runtime_initialized>: Declare methods.
10142         <ravenscar_thread_target>: Add constructor.
10143         (ravenscar_thread_target::task_is_currently_active)
10144         (ravenscar_thread_target::update_inferior_ptid)
10145         (ravenscar_runtime_initialized): Rename.  Now methods.
10146         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10147         (ravenscar_thread_target::update_thread_list): Update.
10148         (ravenscar_thread_target::active_task): Now method.
10149         (ravenscar_thread_target::store_registers)
10150         (ravenscar_thread_target::prepare_to_store)
10151         (ravenscar_thread_target::prepare_to_store)
10152         (ravenscar_thread_target::mourn_inferior): Update.
10153         (ravenscar_inferior_created): Use "new" to create target.
10154         (ravenscar_thread_target::get_ada_task_ptid): Update.
10155         (_initialize_ravenscar): Don't initialize base_ptid.
10156         (ravenscar_ops): Remove global.
10157
10158 2019-02-15  Tom Tromey  <tromey@adacore.com>
10159
10160         * target.h (push_target): Declare new overload.
10161         * target.c (push_target): New overload, taking an rvalue reference.
10162         * remote.c (remote_target::open_1): Use push_target overload.
10163         * corelow.c (core_target_open): Use push_target overload.
10164
10165 2019-02-15  Tom Tromey  <tromey@adacore.com>
10166
10167         * ravenscar-thread.c (is_ravenscar_task)
10168         (ravenscar_task_is_currently_active): Return bool.
10169         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10170         (_initialize_ravenscar): Remove "(void)".
10171         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10172         Return bool.
10173
10174 2019-02-15  Tom Tromey  <tromey@adacore.com>
10175
10176         * ravenscar-thread.c (ravenscar_runtime_initializer)
10177         (has_ravenscar_runtime, get_running_thread_id)
10178         (ravenscar_thread_target::resume): Fix indentation.
10179
10180 2019-02-15  Tom Tromey  <tromey@adacore.com>
10181
10182         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10183         from ravenscar_arch_ops.
10184         (sparc_ravenscar_ops::fetch_registers)
10185         (sparc_ravenscar_ops::store_registers): Now methods.
10186         (sparc_ravenscar_prepare_to_store): Remove.
10187         (sparc_ravenscar_ops): Redefine.
10188         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10189         methods and destructor.  Remove members.
10190         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10191         (ravenscar_thread_target::store_registers)
10192         (ravenscar_thread_target::prepare_to_store): Update.
10193         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10194         Remove.
10195         (struct ppc_ravenscar_powerpc_ops): Derive from
10196         ravenscar_arch_ops.
10197         (ppc_ravenscar_powerpc_ops::fetch_registers)
10198         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10199         (ppc_ravenscar_powerpc_ops): Redefine.
10200         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10201         (ppc_ravenscar_e500_ops::fetch_registers)
10202         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10203         (ppc_ravenscar_e500_ops): Redefine.
10204         * aarch64-ravenscar-thread.c
10205         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10206         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10207         (aarch64_ravenscar_fetch_registers)
10208         (aarch64_ravenscar_store_registers): Now methods.
10209         (aarch64_ravenscar_ops): Redefine.
10210
10211 2019-02-15  Tom Tromey  <tromey@adacore.com>
10212
10213         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10214         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10215         (ravenscar_thread_target::stopped_by_watchpoint)
10216         (ravenscar_thread_target::stopped_data_address)
10217         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10218
10219 2019-02-15  Tom Tromey  <tromey@adacore.com>
10220
10221         * ravenscar-thread.c: Fix some typos.
10222
10223 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10224             Tom Tromey  <tromey@adacore.com>
10225
10226         * ada-lang.c (ada_exception_sal): Change addr_string to a
10227         std::string.
10228         (create_ada_exception_catchpoint): Update.
10229
10230 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10231             Tom Tromey  <tromey@adacore.com>
10232
10233         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10234         (bp_location_ops): Remove.
10235         (base_breakpoint_allocate_location): Update.
10236         (free_bp_location): Update.
10237         * ada-lang.c (class ada_catchpoint_location)
10238         <ada_catchpoint_location>: Remove ops parameter.
10239         (ada_catchpoint_location_dtor): Remove.
10240         (ada_catchpoint_location_ops): Remove.
10241         (allocate_location_exception): Update.
10242         * breakpoint.h (struct bp_location_ops): Remove.
10243         (class bp_location) <bp_location>: Remove bp_location_ops
10244         parameter.
10245         <~bp_location>: Add destructor.
10246         <ops>: Remove.
10247
10248 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10249             Pedro Alves  <palves@redhat.com>
10250
10251         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10252         'PATH_MAX'.
10253
10254 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10255             Samuel Thibault  <samuel.thibault@gnu.org>
10256             Thomas Schwinge  <thomas@codesourcery.com>
10257
10258         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10259         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10260
10261 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10262
10263         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10264         (check_empty): Use "const char *".
10265
10266         * gnu-nat.c (gnu_nat_target::detach): Instead of
10267         'detach_inferior (pid)' call
10268         'detach_inferior (find_inferior_pid (pid))'.
10269
10270         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10271         'nat/fork-inferior.o'.
10272         * gnu-nat.c: #include "nat/fork-inferior.h".
10273
10274         * gnu-nat.c (gnu_nat_target::detach): Instead of
10275         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10276         * gnu-nat.h: #include "inf-child.h".
10277         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10278         'i386_gnu_nat_target::fetch_registers'.
10279         (gnu_store_registers): Rename/move to
10280         'i386_gnu_nat_target::store_registers'.
10281
10282         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10283         * gnu-nat.h (mach_thread_info): New function.
10284         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10285
10286         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10287
10288 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10289
10290         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10291
10292 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10293
10294         * windows-nat.c (windows_add_thread): Add new parameter
10295         "main_thread_p" with default value set to false.  Update
10296         function documentation as well as all callers.
10297         (windows_delete_thread): Likewise.
10298         (fake_create_process): Update call to windows_add_thread.
10299         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10300         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10301         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10302         call to windows_delete_thread.
10303
10304 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10305
10306         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10307
10308 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10309
10310         * symfile.c (find_separate_debug_file): Use canonical path of
10311         sysroot with child_path instead of gdb_sysroot if it is valid.
10312
10313 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10314
10315         * symfile.c (find_separate_debug_file): Use child_path to
10316         determine if an object file is under a sysroot.
10317
10318 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10319
10320         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10321         unittests/child-path-selftests.c.
10322         * common/pathstuff.c (child_path): New function.
10323         * common/pathstuff.h (child_path): New prototype.
10324         * unittests/child-path-selftests.c: New file.
10325
10326 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10327
10328         * symfile.c (find_separate_debug_file): Look for separate debug
10329         files in debug directories under the sysroot.
10330
10331 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10332
10333         * symtab.h (struct minimal_symbol data_p): New const method.
10334         (struct minimal_symbol text_p): Likewise.
10335         * symtab.c (output_source_filename): Use file name style
10336         to print file name.
10337         (print_symbol_info): Likewise.
10338         (print_msymbol_info): Use address style to print addresses.
10339         Use function name style to print executable text symbols.
10340         (expand_symtab_containing_pc): Use data_p.
10341         (find_pc_sect_compunit_symtab): Likewise.
10342
10343 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10344
10345         * breakpoint.c (describe_other_breakpoints): Use address style
10346         to print addresses.
10347         (say_where): Likewise.
10348
10349 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10350
10351         * ada-typeprint.c (print_func_type): Print function name
10352         style to print function name.
10353         * c-typeprint.c (c_print_type_1): Likewise.
10354
10355 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10356
10357         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10358         for execve.
10359
10360 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10361
10362         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10363         type_stack.
10364
10365 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10366
10367         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10368         TYPE_CODE_REF types.
10369
10370 2019-02-08  Jim Wilson  <jimw@sifive.com>
10371
10372         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10373         (riscv_linux_fregset): New.
10374         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10375
10376 2019-02-07  Tom Tromey  <tom@tromey.com>
10377
10378         * thread.c (thread_cancel_execution_command): Update.
10379         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10380         methods.
10381         (struct thread_fsm_ops): Remove.
10382         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10383         (thread_fsm_should_stop, thread_fsm_return_value)
10384         (thread_fsm_set_finished, thread_fsm_finished_p)
10385         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10386         Don't declare.
10387         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10388         * infrun.c (clear_proceed_status_thread)
10389         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10390         (print_stop_event): Update.
10391         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10392         Add constructor.
10393         (step_command_fsm_ops): Remove.
10394         (new_step_command_fsm): Remove.
10395         (step_1): Update.
10396         (step_command_fsm::should_stop): Rename from
10397         step_command_fsm_should_stop.
10398         (step_command_fsm::clean_up): Rename from
10399         step_command_fsm_clean_up.
10400         (step_command_fsm::do_async_reply_reason): Rename from
10401         step_command_fsm_async_reply_reason.
10402         (struct until_next_fsm): Inherit from thread_fsm.  Add
10403         constructor.
10404         (until_next_fsm_ops): Remove.
10405         (new_until_next_fsm): Remove.
10406         (until_next_fsm::should_stop): Rename from
10407         until_next_fsm_should_stop.
10408         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10409         (until_next_fsm::do_async_reply_reason): Rename from
10410         until_next_fsm_async_reply_reason.
10411         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10412         constructor.  Change type of breakpoint.
10413         (finish_command_fsm_ops): Remove.
10414         (new_finish_command_fsm): Remove.
10415         (finish_command_fsm::should_stop): Rename from
10416         finish_command_fsm_should_stop.
10417         (finish_command_fsm::clean_up): Rename from
10418         finish_command_fsm_clean_up.
10419         (finish_command_fsm::return_value): Rename from
10420         finish_command_fsm_return_value.
10421         (finish_command_fsm::do_async_reply_reason): Rename from
10422         finish_command_fsm_async_reply_reason.
10423         (finish_command): Update.
10424         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10425         Add constructor.
10426         (call_thread_fsm_ops): Remove.
10427         (call_thread_fsm::call_thread_fsm): Rename from
10428         new_call_thread_fsm.
10429         (call_thread_fsm::should_stop): Rename from
10430         call_thread_fsm_should_stop.
10431         (call_thread_fsm::should_notify_stop): Rename from
10432         call_thread_fsm_should_notify_stop.
10433         (run_inferior_call, call_function_by_hand_dummy): Update.
10434         * cli/cli-interp.c (should_print_stop_to_console): Update.
10435         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10436         Add constructor.  Change type of location_breakpoint,
10437         caller_breakpoint.
10438         (until_break_fsm_ops): Remove.
10439         (new_until_break_fsm): Remove.
10440         (until_break_fsm::should_stop): Rename from
10441         until_break_fsm_should_stop.
10442         (until_break_fsm::clean_up): Rename from
10443         until_break_fsm_clean_up.
10444         (until_break_fsm::do_async_reply_reason): Rename from
10445         until_break_fsm_async_reply_reason.
10446         (until_break_command): Update.
10447         * thread-fsm.c: Remove.
10448         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10449
10450 2019-02-07  Tom Tromey  <tom@tromey.com>
10451
10452         * yy-remap.h: Add include guard.
10453         * xtensa-tdep.h: Add include guard.
10454         * xcoffread.h: Rename include guard.
10455         * varobj-iter.h: Add include guard.
10456         * tui/tui.h: Rename include guard.
10457         * tui/tui-winsource.h: Rename include guard.
10458         * tui/tui-wingeneral.h: Rename include guard.
10459         * tui/tui-windata.h: Rename include guard.
10460         * tui/tui-win.h: Rename include guard.
10461         * tui/tui-stack.h: Rename include guard.
10462         * tui/tui-source.h: Rename include guard.
10463         * tui/tui-regs.h: Rename include guard.
10464         * tui/tui-out.h: Rename include guard.
10465         * tui/tui-layout.h: Rename include guard.
10466         * tui/tui-io.h: Rename include guard.
10467         * tui/tui-hooks.h: Rename include guard.
10468         * tui/tui-file.h: Rename include guard.
10469         * tui/tui-disasm.h: Rename include guard.
10470         * tui/tui-data.h: Rename include guard.
10471         * tui/tui-command.h: Rename include guard.
10472         * tic6x-tdep.h: Add include guard.
10473         * target/waitstatus.h: Rename include guard.
10474         * target/wait.h: Rename include guard.
10475         * target/target.h: Rename include guard.
10476         * target/resume.h: Rename include guard.
10477         * target-float.h: Rename include guard.
10478         * stabsread.h: Add include guard.
10479         * rs6000-tdep.h: Add include guard.
10480         * riscv-fbsd-tdep.h: Add include guard.
10481         * regformats/regdef.h: Rename include guard.
10482         * record.h: Rename include guard.
10483         * python/python.h: Rename include guard.
10484         * python/python-internal.h: Rename include guard.
10485         * python/py-stopevent.h: Rename include guard.
10486         * python/py-ref.h: Rename include guard.
10487         * python/py-record.h: Rename include guard.
10488         * python/py-record-full.h: Rename include guard.
10489         * python/py-record-btrace.h: Rename include guard.
10490         * python/py-instruction.h: Rename include guard.
10491         * python/py-events.h: Rename include guard.
10492         * python/py-event.h: Rename include guard.
10493         * procfs.h: Add include guard.
10494         * proc-utils.h: Add include guard.
10495         * p-lang.h: Add include guard.
10496         * or1k-tdep.h: Rename include guard.
10497         * observable.h: Rename include guard.
10498         * nto-tdep.h: Rename include guard.
10499         * nat/x86-linux.h: Rename include guard.
10500         * nat/x86-linux-dregs.h: Rename include guard.
10501         * nat/x86-gcc-cpuid.h: Add include guard.
10502         * nat/x86-dregs.h: Rename include guard.
10503         * nat/x86-cpuid.h: Rename include guard.
10504         * nat/ppc-linux.h: Rename include guard.
10505         * nat/mips-linux-watch.h: Rename include guard.
10506         * nat/linux-waitpid.h: Rename include guard.
10507         * nat/linux-ptrace.h: Rename include guard.
10508         * nat/linux-procfs.h: Rename include guard.
10509         * nat/linux-osdata.h: Rename include guard.
10510         * nat/linux-nat.h: Rename include guard.
10511         * nat/linux-namespaces.h: Rename include guard.
10512         * nat/linux-btrace.h: Rename include guard.
10513         * nat/glibc_thread_db.h: Rename include guard.
10514         * nat/gdb_thread_db.h: Rename include guard.
10515         * nat/gdb_ptrace.h: Rename include guard.
10516         * nat/fork-inferior.h: Rename include guard.
10517         * nat/amd64-linux-siginfo.h: Rename include guard.
10518         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10519         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10520         * nat/aarch64-linux.h: Rename include guard.
10521         * nat/aarch64-linux-hw-point.h: Rename include guard.
10522         * mn10300-tdep.h: Add include guard.
10523         * mips-linux-tdep.h: Add include guard.
10524         * mi/mi-parse.h: Rename include guard.
10525         * mi/mi-out.h: Rename include guard.
10526         * mi/mi-main.h: Rename include guard.
10527         * mi/mi-interp.h: Rename include guard.
10528         * mi/mi-getopt.h: Rename include guard.
10529         * mi/mi-console.h: Rename include guard.
10530         * mi/mi-common.h: Rename include guard.
10531         * mi/mi-cmds.h: Rename include guard.
10532         * mi/mi-cmd-break.h: Rename include guard.
10533         * m2-lang.h: Add include guard.
10534         * location.h: Rename include guard.
10535         * linux-record.h: Rename include guard.
10536         * linux-nat.h: Add include guard.
10537         * linux-fork.h: Add include guard.
10538         * i386-darwin-tdep.h: Rename include guard.
10539         * hppa-linux-offsets.h: Add include guard.
10540         * guile/guile.h: Rename include guard.
10541         * guile/guile-internal.h: Rename include guard.
10542         * gnu-nat.h: Rename include guard.
10543         * gdb-stabs.h: Rename include guard.
10544         * frv-tdep.h: Add include guard.
10545         * f-lang.h: Add include guard.
10546         * event-loop.h: Add include guard.
10547         * darwin-nat.h: Rename include guard.
10548         * cp-abi.h: Rename include guard.
10549         * config/sparc/nm-sol2.h: Rename include guard.
10550         * config/nm-nto.h: Rename include guard.
10551         * config/nm-linux.h: Add include guard.
10552         * config/i386/nm-i386gnu.h: Rename include guard.
10553         * config/djgpp/nl_types.h: Rename include guard.
10554         * config/djgpp/langinfo.h: Rename include guard.
10555         * compile/gcc-cp-plugin.h: Add include guard.
10556         * compile/gcc-c-plugin.h: Add include guard.
10557         * compile/compile.h: Rename include guard.
10558         * compile/compile-object-run.h: Rename include guard.
10559         * compile/compile-object-load.h: Rename include guard.
10560         * compile/compile-internal.h: Rename include guard.
10561         * compile/compile-cplus.h: Rename include guard.
10562         * compile/compile-c.h: Rename include guard.
10563         * common/xml-utils.h: Rename include guard.
10564         * common/x86-xstate.h: Rename include guard.
10565         * common/version.h: Rename include guard.
10566         * common/vec.h: Rename include guard.
10567         * common/tdesc.h: Rename include guard.
10568         * common/selftest.h: Rename include guard.
10569         * common/scoped_restore.h: Rename include guard.
10570         * common/scoped_mmap.h: Rename include guard.
10571         * common/scoped_fd.h: Rename include guard.
10572         * common/safe-iterator.h: Rename include guard.
10573         * common/run-time-clock.h: Rename include guard.
10574         * common/refcounted-object.h: Rename include guard.
10575         * common/queue.h: Rename include guard.
10576         * common/ptid.h: Rename include guard.
10577         * common/print-utils.h: Rename include guard.
10578         * common/preprocessor.h: Rename include guard.
10579         * common/pathstuff.h: Rename include guard.
10580         * common/observable.h: Rename include guard.
10581         * common/netstuff.h: Rename include guard.
10582         * common/job-control.h: Rename include guard.
10583         * common/host-defs.h: Rename include guard.
10584         * common/gdb_wait.h: Rename include guard.
10585         * common/gdb_vecs.h: Rename include guard.
10586         * common/gdb_unlinker.h: Rename include guard.
10587         * common/gdb_unique_ptr.h: Rename include guard.
10588         * common/gdb_tilde_expand.h: Rename include guard.
10589         * common/gdb_sys_time.h: Rename include guard.
10590         * common/gdb_string_view.h: Rename include guard.
10591         * common/gdb_splay_tree.h: Rename include guard.
10592         * common/gdb_setjmp.h: Rename include guard.
10593         * common/gdb_ref_ptr.h: Rename include guard.
10594         * common/gdb_optional.h: Rename include guard.
10595         * common/gdb_locale.h: Rename include guard.
10596         * common/gdb_assert.h: Rename include guard.
10597         * common/filtered-iterator.h: Rename include guard.
10598         * common/filestuff.h: Rename include guard.
10599         * common/fileio.h: Rename include guard.
10600         * common/environ.h: Rename include guard.
10601         * common/common-utils.h: Rename include guard.
10602         * common/common-types.h: Rename include guard.
10603         * common/common-regcache.h: Rename include guard.
10604         * common/common-inferior.h: Rename include guard.
10605         * common/common-gdbthread.h: Rename include guard.
10606         * common/common-exceptions.h: Rename include guard.
10607         * common/common-defs.h: Rename include guard.
10608         * common/common-debug.h: Rename include guard.
10609         * common/cleanups.h: Rename include guard.
10610         * common/buffer.h: Rename include guard.
10611         * common/btrace-common.h: Rename include guard.
10612         * common/break-common.h: Rename include guard.
10613         * cli/cli-utils.h: Rename include guard.
10614         * cli/cli-style.h: Rename include guard.
10615         * cli/cli-setshow.h: Rename include guard.
10616         * cli/cli-script.h: Rename include guard.
10617         * cli/cli-interp.h: Rename include guard.
10618         * cli/cli-decode.h: Rename include guard.
10619         * cli/cli-cmds.h: Rename include guard.
10620         * charset-list.h: Add include guard.
10621         * buildsym-legacy.h: Rename include guard.
10622         * bfin-tdep.h: Add include guard.
10623         * ax.h: Rename include guard.
10624         * arm-linux-tdep.h: Add include guard.
10625         * arm-fbsd-tdep.h: Add include guard.
10626         * arch/xtensa.h: Rename include guard.
10627         * arch/tic6x.h: Add include guard.
10628         * arch/i386.h: Add include guard.
10629         * arch/arm.h: Rename include guard.
10630         * arch/arm-linux.h: Rename include guard.
10631         * arch/arm-get-next-pcs.h: Rename include guard.
10632         * arch/amd64.h: Add include guard.
10633         * arch/aarch64-insn.h: Rename include guard.
10634         * arch-utils.h: Rename include guard.
10635         * annotate.h: Add include guard.
10636         * amd64-darwin-tdep.h: Rename include guard.
10637         * aarch64-linux-tdep.h: Add include guard.
10638         * aarch64-fbsd-tdep.h: Add include guard.
10639         * aarch32-linux-nat.h: Add include guard.
10640
10641 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10642
10643         * macrotab.c (macro_define_internal): New function that
10644         factorizes macro_define_object_internal and macro_define_function
10645         code.
10646         (macro_define_object_internal): Use macro_define_internal.
10647         (macro_define_function): Likewise.
10648
10649 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10650
10651         * macrocmd.c (extract_identifier): Return
10652         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10653         callers.
10654
10655 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10656
10657         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10658
10659 2019-02-05  Tom Tromey  <tom@tromey.com>
10660
10661         * target.c (target_stack::unpush): Move assertion earlier.
10662
10663 2019-01-30  Tom Tromey  <tom@tromey.com>
10664
10665         PR python/23615:
10666         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10667         (gdbpy_parse_and_eval): Likewise.
10668         * python/python-internal.h (gdbpy_allow_threads): New class.
10669
10670 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10671
10672         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10673         (aarch64_fbsd_fpregmap): Move earlier.
10674         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10675         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10676         instead of individual calls to trad_frame_set_reg_addr.
10677         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10678         earlier.
10679         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10680         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10681         instead of individual calls to trad_frame_set_reg_addr.
10682
10683 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10684
10685         * CONTRIBUTE: Replace contribution list with wiki link.
10686
10687 2019-01-25  Tom Tromey  <tom@tromey.com>
10688
10689         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10690
10691 2019-01-25  Tom Tromey  <tom@tromey.com>
10692
10693         * xtensa-linux-nat.c: Fix common/ includes.
10694         * xml-support.h: Fix common/ includes.
10695         * xml-support.c: Fix common/ includes.
10696         * x86-linux-nat.c: Fix common/ includes.
10697         * windows-nat.c: Fix common/ includes.
10698         * varobj.h: Fix common/ includes.
10699         * varobj.c: Fix common/ includes.
10700         * value.c: Fix common/ includes.
10701         * valops.c: Fix common/ includes.
10702         * utils.c: Fix common/ includes.
10703         * unittests/xml-utils-selftests.c: Fix common/ includes.
10704         * unittests/utils-selftests.c: Fix common/ includes.
10705         * unittests/unpack-selftests.c: Fix common/ includes.
10706         * unittests/tracepoint-selftests.c: Fix common/ includes.
10707         * unittests/style-selftests.c: Fix common/ includes.
10708         * unittests/string_view-selftests.c: Fix common/ includes.
10709         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10710         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10711         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10712         * unittests/rsp-low-selftests.c: Fix common/ includes.
10713         * unittests/parse-connection-spec-selftests.c: Fix common/
10714         includes.
10715         * unittests/optional-selftests.c: Fix common/ includes.
10716         * unittests/offset-type-selftests.c: Fix common/ includes.
10717         * unittests/observable-selftests.c: Fix common/ includes.
10718         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10719         * unittests/memrange-selftests.c: Fix common/ includes.
10720         * unittests/memory-map-selftests.c: Fix common/ includes.
10721         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10722         * unittests/function-view-selftests.c: Fix common/ includes.
10723         * unittests/environ-selftests.c: Fix common/ includes.
10724         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10725         * unittests/common-utils-selftests.c: Fix common/ includes.
10726         * unittests/cli-utils-selftests.c: Fix common/ includes.
10727         * unittests/array-view-selftests.c: Fix common/ includes.
10728         * ui-file.c: Fix common/ includes.
10729         * tui/tui-io.c: Fix common/ includes.
10730         * tracepoint.h: Fix common/ includes.
10731         * tracepoint.c: Fix common/ includes.
10732         * tracefile-tfile.c: Fix common/ includes.
10733         * top.h: Fix common/ includes.
10734         * top.c: Fix common/ includes.
10735         * thread.c: Fix common/ includes.
10736         * target/waitstatus.h: Fix common/ includes.
10737         * target/waitstatus.c: Fix common/ includes.
10738         * target.h: Fix common/ includes.
10739         * target.c: Fix common/ includes.
10740         * target-memory.c: Fix common/ includes.
10741         * target-descriptions.c: Fix common/ includes.
10742         * symtab.h: Fix common/ includes.
10743         * symfile.c: Fix common/ includes.
10744         * stap-probe.c: Fix common/ includes.
10745         * spu-linux-nat.c: Fix common/ includes.
10746         * sparc-nat.c: Fix common/ includes.
10747         * source.c: Fix common/ includes.
10748         * solib.c: Fix common/ includes.
10749         * solib-target.c: Fix common/ includes.
10750         * ser-unix.c: Fix common/ includes.
10751         * ser-tcp.c: Fix common/ includes.
10752         * ser-pipe.c: Fix common/ includes.
10753         * ser-base.c: Fix common/ includes.
10754         * selftest-arch.c: Fix common/ includes.
10755         * s12z-tdep.c: Fix common/ includes.
10756         * rust-exp.y: Fix common/ includes.
10757         * rs6000-aix-tdep.c: Fix common/ includes.
10758         * riscv-tdep.c: Fix common/ includes.
10759         * remote.c: Fix common/ includes.
10760         * remote-notif.h: Fix common/ includes.
10761         * remote-fileio.h: Fix common/ includes.
10762         * remote-fileio.c: Fix common/ includes.
10763         * regcache.h: Fix common/ includes.
10764         * regcache.c: Fix common/ includes.
10765         * record-btrace.c: Fix common/ includes.
10766         * python/python.c: Fix common/ includes.
10767         * python/py-type.c: Fix common/ includes.
10768         * python/py-inferior.c: Fix common/ includes.
10769         * progspace.h: Fix common/ includes.
10770         * producer.c: Fix common/ includes.
10771         * procfs.c: Fix common/ includes.
10772         * proc-api.c: Fix common/ includes.
10773         * printcmd.c: Fix common/ includes.
10774         * ppc-linux-nat.c: Fix common/ includes.
10775         * parser-defs.h: Fix common/ includes.
10776         * osdata.c: Fix common/ includes.
10777         * obsd-nat.c: Fix common/ includes.
10778         * nat/x86-linux.c: Fix common/ includes.
10779         * nat/x86-linux-dregs.c: Fix common/ includes.
10780         * nat/x86-dregs.h: Fix common/ includes.
10781         * nat/x86-dregs.c: Fix common/ includes.
10782         * nat/ppc-linux.c: Fix common/ includes.
10783         * nat/mips-linux-watch.h: Fix common/ includes.
10784         * nat/mips-linux-watch.c: Fix common/ includes.
10785         * nat/linux-waitpid.c: Fix common/ includes.
10786         * nat/linux-ptrace.h: Fix common/ includes.
10787         * nat/linux-ptrace.c: Fix common/ includes.
10788         * nat/linux-procfs.c: Fix common/ includes.
10789         * nat/linux-personality.c: Fix common/ includes.
10790         * nat/linux-osdata.c: Fix common/ includes.
10791         * nat/linux-namespaces.c: Fix common/ includes.
10792         * nat/linux-btrace.h: Fix common/ includes.
10793         * nat/linux-btrace.c: Fix common/ includes.
10794         * nat/fork-inferior.c: Fix common/ includes.
10795         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10796         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10797         * nat/aarch64-linux.c: Fix common/ includes.
10798         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10799         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10800         * namespace.h: Fix common/ includes.
10801         * mips-linux-tdep.c: Fix common/ includes.
10802         * minsyms.c: Fix common/ includes.
10803         * mi/mi-parse.h: Fix common/ includes.
10804         * mi/mi-main.c: Fix common/ includes.
10805         * mi/mi-cmd-env.c: Fix common/ includes.
10806         * memrange.h: Fix common/ includes.
10807         * memattr.c: Fix common/ includes.
10808         * maint.h: Fix common/ includes.
10809         * maint.c: Fix common/ includes.
10810         * main.c: Fix common/ includes.
10811         * machoread.c: Fix common/ includes.
10812         * location.c: Fix common/ includes.
10813         * linux-thread-db.c: Fix common/ includes.
10814         * linux-nat.c: Fix common/ includes.
10815         * linux-fork.c: Fix common/ includes.
10816         * inline-frame.c: Fix common/ includes.
10817         * infrun.c: Fix common/ includes.
10818         * inflow.c: Fix common/ includes.
10819         * inferior.h: Fix common/ includes.
10820         * inferior.c: Fix common/ includes.
10821         * infcmd.c: Fix common/ includes.
10822         * inf-ptrace.c: Fix common/ includes.
10823         * inf-child.c: Fix common/ includes.
10824         * ia64-linux-nat.c: Fix common/ includes.
10825         * i387-tdep.c: Fix common/ includes.
10826         * i386-tdep.c: Fix common/ includes.
10827         * i386-linux-tdep.c: Fix common/ includes.
10828         * i386-linux-nat.c: Fix common/ includes.
10829         * i386-go32-tdep.c: Fix common/ includes.
10830         * i386-fbsd-tdep.c: Fix common/ includes.
10831         * i386-fbsd-nat.c: Fix common/ includes.
10832         * guile/scm-type.c: Fix common/ includes.
10833         * guile/guile.c: Fix common/ includes.
10834         * go32-nat.c: Fix common/ includes.
10835         * gnu-nat.c: Fix common/ includes.
10836         * gdbthread.h: Fix common/ includes.
10837         * gdbarch-selftests.c: Fix common/ includes.
10838         * gdb_usleep.c: Fix common/ includes.
10839         * gdb_select.h: Fix common/ includes.
10840         * gdb_bfd.c: Fix common/ includes.
10841         * gcore.c: Fix common/ includes.
10842         * fork-child.c: Fix common/ includes.
10843         * findvar.c: Fix common/ includes.
10844         * fbsd-nat.c: Fix common/ includes.
10845         * event-top.c: Fix common/ includes.
10846         * event-loop.c: Fix common/ includes.
10847         * dwarf2read.c: Fix common/ includes.
10848         * dwarf2loc.c: Fix common/ includes.
10849         * dwarf2-frame.c: Fix common/ includes.
10850         * dwarf-index-cache.c: Fix common/ includes.
10851         * dtrace-probe.c: Fix common/ includes.
10852         * disasm-selftests.c: Fix common/ includes.
10853         * defs.h: Fix common/ includes.
10854         * csky-tdep.c: Fix common/ includes.
10855         * cp-valprint.c: Fix common/ includes.
10856         * cp-support.h: Fix common/ includes.
10857         * cp-support.c: Fix common/ includes.
10858         * corelow.c: Fix common/ includes.
10859         * completer.h: Fix common/ includes.
10860         * completer.c: Fix common/ includes.
10861         * compile/compile.c: Fix common/ includes.
10862         * compile/compile-loc2c.c: Fix common/ includes.
10863         * compile/compile-cplus-types.c: Fix common/ includes.
10864         * compile/compile-cplus-symbols.c: Fix common/ includes.
10865         * command.h: Fix common/ includes.
10866         * cli/cli-dump.c: Fix common/ includes.
10867         * cli/cli-cmds.c: Fix common/ includes.
10868         * charset.c: Fix common/ includes.
10869         * build-id.c: Fix common/ includes.
10870         * btrace.h: Fix common/ includes.
10871         * btrace.c: Fix common/ includes.
10872         * breakpoint.h: Fix common/ includes.
10873         * breakpoint.c: Fix common/ includes.
10874         * ax.h:
10875         (enum agent_op): Fix common/ includes.
10876         * ax-general.c (struct aop_map): Fix common/ includes.
10877         * ax-gdb.c: Fix common/ includes.
10878         * auxv.c: Fix common/ includes.
10879         * auto-load.c: Fix common/ includes.
10880         * arm-tdep.c: Fix common/ includes.
10881         * arch/riscv.c: Fix common/ includes.
10882         * arch/ppc-linux-common.c: Fix common/ includes.
10883         * arch/i386.c: Fix common/ includes.
10884         * arch/arm.c: Fix common/ includes.
10885         * arch/arm-linux.c: Fix common/ includes.
10886         * arch/arm-get-next-pcs.c: Fix common/ includes.
10887         * arch/amd64.c: Fix common/ includes.
10888         * arch/aarch64.c: Fix common/ includes.
10889         * arch/aarch64-insn.c: Fix common/ includes.
10890         * arch-utils.c: Fix common/ includes.
10891         * amd64-windows-tdep.c: Fix common/ includes.
10892         * amd64-tdep.c: Fix common/ includes.
10893         * amd64-sol2-tdep.c: Fix common/ includes.
10894         * amd64-obsd-tdep.c: Fix common/ includes.
10895         * amd64-nbsd-tdep.c: Fix common/ includes.
10896         * amd64-linux-tdep.c: Fix common/ includes.
10897         * amd64-linux-nat.c: Fix common/ includes.
10898         * amd64-fbsd-tdep.c: Fix common/ includes.
10899         * amd64-fbsd-nat.c: Fix common/ includes.
10900         * amd64-dicos-tdep.c: Fix common/ includes.
10901         * amd64-darwin-tdep.c: Fix common/ includes.
10902         * agent.c: Fix common/ includes.
10903         * ada-lang.h: Fix common/ includes.
10904         * ada-lang.c: Fix common/ includes.
10905         * aarch64-tdep.c: Fix common/ includes.
10906
10907 2019-01-25  Tom Tromey  <tom@tromey.com>
10908
10909         * common/create-version.sh: Use common/version.h.
10910
10911 2019-01-24  Pedro Alves  <palves@redhat.com>
10912
10913         * infrun.c (signal_stop, signal_print, signal_program)
10914         (signal_catch, signal_pass): Now arrays instead of pointers.
10915         (update_signals_program_target, do_target_resume)
10916         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10917         * linux-nat.c (linux_nat_target::pass_signals)
10918         (linux_nat_target::create_inferior, linux_nat_target::attach):
10919         Adjust.
10920         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10921         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10922         * procfs.c (procfs_target::pass_signals): Adjust.
10923         * record-full.c (record_full_target::resume): Adjust.
10924         * remote.c (remote_target::pass_signals)
10925         (remote_target::program_signals): Adjust.
10926         * target-debug.h (target_debug_print_signals): Now takes a
10927         gdb::array_view as parameter.  Adjust.
10928         * target.h (target_ops) <pass_signals, program_signals>: Replace
10929         pointer and length parameters with gdb::array_view.
10930         (target_pass_signals, target_program_signals): Likewise.
10931         * target-delegates.c: Regenerate.
10932
10933 2019-01-24  Pedro Alves  <palves@redhat.com>
10934
10935         * common/forward-scope-exit.h
10936         (forward_scope_exit::forward_scope_exit): Pass arguments to
10937         m_bind_function directly, instead of creating a std::bind and
10938         copying that.
10939
10940 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10941
10942         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10943         for static members.
10944         (pass_in_v_vfp_candidate): Likewise.
10945
10946 2019-01-23  Tom Tromey  <tom@tromey.com>
10947             Pedro Alves  <palves@redhat.com>
10948
10949         * regcache.c (class regcache_invalidator): Remove.
10950         (regcache::raw_write): Use make_scope_exit.
10951
10952 2019-01-23  Tom Tromey  <tom@tromey.com>
10953
10954         * ui-out.h (class ui_out_emit_type): Update comment.
10955
10956 2019-01-23  Tom Tromey  <tom@tromey.com>
10957
10958         * infrun.c (fetch_inferior_event): Update comment.
10959
10960 2019-01-23  Tom Tromey  <tom@tromey.com>
10961             Pedro Alves  <palves@redhat.com>
10962
10963         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10964         parameter.
10965         (fetch_inferior_event): Use SCOPE_EXIT.
10966
10967
10968 2019-01-23  Tom Tromey  <tom@tromey.com>
10969             Pedro Alves  <palves@redhat.com>
10970
10971         * infrun.c (disable_thread_events): Delete.
10972         (stop_all_threads): Use SCOPE_EXIT.
10973
10974 2019-01-23  Tom Tromey  <tom@tromey.com>
10975             Pedro Alves  <palves@redhat.com>
10976
10977         * symfile.c: Include forward-scope-exit.h.
10978         (clear_symtab_users_cleanup): Replace forward declaration with
10979         a FORWARD_SCOPE_EXIT.
10980         (syms_from_objfile_1): Use the forward_scope_exit and
10981         gdb::optional instead of cleanup_function.
10982         (reread_symbols): Use the forward_scope_exit instead of
10983         cleanup_function.
10984         (clear_symtab_users_cleanup): Remove function.
10985
10986 2019-01-23  Tom Tromey  <tom@tromey.com>
10987             Pedro Alves  <palves@redhat.com>
10988
10989         * linux-nat.c: Include scope-exit.h.
10990         (cleanup_target_stop): Remove.
10991         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10992         SCOPE_EXIT.
10993
10994 2019-01-23  Tom Tromey  <tom@tromey.com>
10995             Pedro Alves  <palves@redhat.com>
10996
10997         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10998         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10999
11000 2019-01-23  Tom Tromey  <tom@tromey.com>
11001             Andrew Burgess  <andrew.burgess@embecosm.com>
11002             Pedro Alves  <palves@redhat.com>
11003
11004         * infrun.c (fetch_inferior_event): Use scope_exit.
11005         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11006         * top.c (execute_command): Use scope_exit.
11007         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11008         * utils.c (do_bpstat_clear_actions_cleanup)
11009         (make_bpstat_clear_actions_cleanup): Remove.
11010
11011 2019-01-23  Tom Tromey  <tom@tromey.com>
11012             Pedro Alves  <palves@redhat.com>
11013
11014         * infrun.c: Include "common/scope-exit.h"
11015         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11016         (wait_for_inferior): Use SCOPE_EXIT.
11017         (fetch_inferior_event): Use scope_exit.
11018
11019 2019-01-23  Tom Tromey  <tom@tromey.com>
11020             Pedro Alves  <palves@redhat.com>
11021
11022         * breakpoint.c (create_breakpoint): Remove cleanup.
11023
11024 2019-01-23  Tom Tromey  <tom@tromey.com>
11025             Andrew Burgess  <andrew.burgess@embecosm.com>
11026             Pedro Alves  <palves@redhat.com>
11027
11028 2019-01-23  Pedro Alves  <palves@redhat.com>
11029
11030         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11031
11032 2019-01-23  Pedro Alves  <palves@redhat.com>
11033             Andrew Burgess  <andrew.burgess@embecosm.com>
11034
11035         * gdbthread.h: Include "common/forward-scope-exit.h".
11036         (scoped_finish_thread_state): Redefine custom class in terms of
11037         forward_scope_exit.
11038
11039 2019-01-23  Pedro Alves  <palves@redhat.com>
11040             Andrew Burgess  <andrew.burgess@embecosm.com>
11041
11042         * common/forward-scope-exit.h: New file.
11043
11044 2019-01-23  Pedro Alves  <palves@redhat.com>
11045             Andrew Burgess  <andrew.burgess@embecosm.com>
11046             Tom Tromey  <tom@tromey.com>
11047
11048         * common/scope-exit.h: New file.
11049
11050 2019-01-23  Pedro Alves  <palves@redhat.com>
11051
11052         * common/preprocessor.h (ESC): Rename to ...
11053         (ESC_PARENS): ... this.
11054         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11055         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11056
11057 2019-01-23  Tom Tromey  <tom@tromey.com>
11058
11059         * language.h (class scoped_switch_to_sym_language_if_auto):
11060         Initialize m_lang in both cases.
11061
11062 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11063
11064         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11065         with XCNEW.
11066
11067 2019-01-22  Tom Tromey  <tom@tromey.com>
11068
11069         * corelow.c: Do not include sys/file.h.
11070
11071 2019-01-22  Tom Tromey  <tom@tromey.com>
11072
11073         * tui/tui-wingeneral.h: Include gdb_curses.h.
11074
11075 2019-01-22  Tom Tromey  <tom@tromey.com>
11076
11077         * source-cache.h (class source_cache) <get_source_lines,
11078         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11079
11080 2019-01-22  Tom Tromey  <tom@tromey.com>
11081
11082         * remote-fileio.h (struct remote_target): Declare.
11083
11084 2019-01-22  Tom Tromey  <tom@tromey.com>
11085
11086         * python/py-arch.c: Do not include py-ref.h.
11087         * python/py-bpevent.c: Do not include py-ref.h.
11088         * python/py-cmd.c: Do not include py-ref.h.
11089         * python/py-continueevent.c: Do not include py-ref.h.
11090         * python/py-event.h: Do not include py-ref.h.
11091         * python/py-evtregistry.c: Do not include py-ref.h.
11092         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11093         * python/py-frame.c: Do not include py-ref.h.
11094         * python/py-framefilter.c: Do not include py-ref.h.
11095         * python/py-function.c: Do not include py-ref.h.
11096         * python/py-infevents.c: Do not include py-ref.h.
11097         * python/py-linetable.c: Do not include py-ref.h.
11098         * python/py-objfile.c: Do not include py-ref.h.
11099         * python/py-param.c: Do not include py-ref.h.
11100         * python/py-prettyprint.c: Do not include py-ref.h.
11101         * python/py-progspace.c: Do not include py-ref.h.
11102         * python/py-symbol.c: Do not include py-ref.h.
11103         * python/py-symtab.c: Do not include py-ref.h.
11104         * python/py-type.c: Do not include py-ref.h.
11105         * python/py-unwind.c: Do not include py-ref.h.
11106         * python/py-utils.c: Do not include py-ref.h.
11107         * python/py-value.c: Do not include py-ref.h.
11108         * python/py-varobj.c: Do not include py-ref.h.
11109         * python/py-xmethods.c: Do not include py-ref.h.
11110         * python/python.c: Do not include py-ref.h.
11111         * varobj.c: Do not include py-ref.h.
11112
11113 2019-01-22  Tom Tromey  <tom@tromey.com>
11114
11115         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11116         keyword for bcache.
11117
11118 2019-01-22  Tom Tromey  <tom@tromey.com>
11119
11120         * compile/compile-cplus-types.c: Remove a comment by #include.
11121
11122 2019-01-22  Tom Tromey  <tom@tromey.com>
11123
11124         * compile/gcc-c-plugin.h: Include compile-internal.h.
11125
11126 2019-01-22  Tom Tromey  <tom@tromey.com>
11127
11128         * stabsread.c (EXTERN): Do not define.
11129         (symnum, next_symbol_text_func, processing_gcc_compilation)
11130         (within_function, global_sym_chain, global_stabs)
11131         (previous_stab_code, this_object_header_files)
11132         (n_this_object_header_files)
11133         (n_allocated_this_object_header_files): Define.
11134         * stabsread.h (EXTERN): Never define.  Use "extern".
11135
11136 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11137
11138         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11139         history_value.
11140
11141 2019-01-21  Tom Tromey  <tom@tromey.com>
11142
11143         * ui-out.c: Fix includes.
11144         * tui/tui-source.c: Fix includes.
11145         * target.c: Fix includes.
11146         * remote.c: Fix includes.
11147         * regcache.c: Fix includes.
11148         * python/py-block.c: Fix includes.
11149         * printcmd.c: Fix includes.
11150         * or1k-tdep.c: Fix includes.
11151         * mi/mi-main.c: Fix includes.
11152         * m32r-tdep.c: Fix includes.
11153         * csky-tdep.c: Fix includes.
11154         * compile/compile-cplus-types.c: Fix includes.
11155         * cli/cli-interp.c: Fix includes.
11156
11157 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11158
11159         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11160         for padding.
11161
11162 2019-01-16  Tom Tromey  <tom@tromey.com>
11163
11164         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11165         earlier.
11166         (struct objfile) <msymbols_range>: Move from top level.
11167         <msymbols>: New method.
11168         (class objfile_msymbols): Remove.
11169         * symtab.c (default_collect_symbol_completion_matches_break_on):
11170         Update.
11171         * symmisc.c (dump_msymbols): Update.
11172         * stabsread.c (scan_file_globals): Update.
11173         * objc-lang.c (info_selectors_command, info_classes_command)
11174         (find_methods): Update.
11175         * minsyms.c (find_solib_trampoline_target): Update.
11176         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11177         * coffread.c (coff_symfile_read): Update.
11178         * ada-lang.c (ada_lookup_simple_minsym)
11179         (ada_collect_symbol_completion_matches): Update.
11180
11181 2019-01-16  Tom Tromey  <tom@tromey.com>
11182
11183         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11184         type.  Remove no-argument constructor.
11185         <iterator::operator++>: Simplify.
11186         <begin>: Update.
11187         <end>: Use minimal_symbol_count.
11188
11189 2019-01-16  Tom Tromey  <tom@tromey.com>
11190
11191         * objfiles.h (struct objfile) <psymtabs>: New method.
11192         (class objfile_psymtabs): Remove.
11193         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11194         typedef.
11195         <range>: New method.
11196         (require_partial_symbols): Change return type.
11197         * psymtab.c (require_partial_symbols)
11198         (psym_expand_symtabs_matching): Update.
11199         * mdebugread.c (parse_partial_symbols): Update.
11200         * dbxread.c (dbx_end_psymtab): Update.
11201
11202 2019-01-15  Tom Tromey  <tom@tromey.com>
11203
11204         * symtab.c (lookup_objfile_from_block)
11205         (lookup_symbol_in_objfile_symtabs)
11206         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11207         (find_line_symtab, info_sources_command)
11208         (default_collect_symbol_completion_matches_break_on)
11209         (make_source_files_completion_list): Update.
11210         * symmisc.c (print_objfile_statistics, dump_objfile)
11211         (maintenance_print_symbols, maintenance_info_symtabs)
11212         (maintenance_check_symtabs, maintenance_info_line_tables):
11213         Update.
11214         * source.c (select_source_symtab)
11215         (forget_cached_source_info_for_objfile): Update.
11216         * objfiles.h (class objfile_compunits): Remove.
11217         (struct objfile) <compunits_range>: New typedef.
11218         (compunits): New method.
11219         * objfiles.c (objfile_relocate1): Update.
11220         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11221         * maint.c (count_symtabs_and_blocks): Update.
11222         * linespec.c (iterate_over_all_matching_symtabs): Update.
11223         * cp-support.c (add_symbol_overload_list_qualified): Update.
11224         * coffread.c (coff_symtab_read): Update.
11225         * ada-lang.c (add_nonlocal_symbols)
11226         (ada_collect_symbol_completion_matches)
11227         (ada_add_global_exceptions): Update.
11228
11229 2019-01-15  Tom Tromey  <tom@tromey.com>
11230
11231         * progspace.h (program_space) <objfiles_safe_range>: New
11232         typedef.
11233         <objfiles_safe>: New method.
11234         * objfiles.h (class all_objfiles_safe): Remove.
11235         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11236         * jit.c (jit_inferior_exit_hook): Update.
11237
11238 2019-01-17  Tom Tromey  <tom@tromey.com>
11239
11240         * progspace.h (program_space) <objfiles_range>: New typedef.
11241         <objfiles>: New method.
11242         <objfiles_head>: Rename from objfiles.
11243         (object_files): Update.
11244         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11245         * guile/scm-pretty-print.c
11246         (ppscm_find_pretty_printer_from_objfiles): Update.
11247         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11248         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11249         Update.
11250         * python/py-progspace.c (pspy_get_objfiles): Update.
11251         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11252         Update.
11253         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11254         (objfpy_lookup_objfile_by_build_id): Update.
11255         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11256         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11257         Update.
11258         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11259         (expand_symtab_containing_pc, lookup_objfile_from_block)
11260         (lookup_static_symbol, basic_lookup_transparent_type)
11261         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11262         (find_line_symtab, info_sources_command)
11263         (default_collect_symbol_completion_matches_break_on)
11264         (make_source_files_completion_list, find_main_name): Update.
11265         * symmisc.c (print_symbol_bcache_statistics)
11266         (print_objfile_statistics, maintenance_print_symbols)
11267         (maintenance_print_msymbols, maintenance_print_objfiles)
11268         (maintenance_info_symtabs, maintenance_check_symtabs)
11269         (maintenance_expand_symtabs, maintenance_info_line_tables):
11270         Update.
11271         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11272         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11273         (map_overlay_command, unmap_overlay_command)
11274         (simple_overlay_update, expand_symtabs_matching)
11275         (map_symbol_filenames): Update.
11276         * symfile-debug.c (set_debug_symfile): Update.
11277         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11278         Update.
11279         * source.c (select_source_symtab, forget_cached_source_info):
11280         Update.
11281         * solib.c (solib_read_symbols): Update.
11282         * solib-spu.c (append_ocl_sos): Update.
11283         * psymtab.c (maintenance_print_psymbols)
11284         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11285         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11286         * printcmd.c (info_symbol_command): Update.
11287         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11288         Update.
11289         * objfiles.h (class all_objfiles): Remove.
11290         * objfiles.c (have_partial_symbols, have_full_symbols)
11291         (have_minimal_symbols, qsort_cmp, update_section_map)
11292         (shared_objfile_contains_address_p)
11293         (default_iterate_over_objfiles_in_search_order): Update.
11294         * objc-lang.c (info_selectors_command, info_classes_command)
11295         (find_methods): Update.
11296         * minsyms.c (find_solib_trampoline_target): Update.
11297         * maint.c (maintenance_info_sections)
11298         (maintenance_translate_address, count_symtabs_and_blocks):
11299         Update.
11300         * main.c (captured_main_1): Update.
11301         * linux-thread-db.c (try_thread_db_load_from_pdir)
11302         (has_libpthread): Update.
11303         * linespec.c (iterate_over_all_matching_symtabs)
11304         (search_minsyms_for_name): Update.
11305         * jit.c (jit_find_objf_with_entry_addr): Update.
11306         * hppa-tdep.c (find_unwind_entry)
11307         (hppa_lookup_stub_minimal_symbol): Update.
11308         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11309         Update.
11310         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11311         (elf_gnu_ifunc_resolve_by_got): Update.
11312         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11313         * dwarf-index-write.c (save_gdb_index_command): Update.
11314         * cp-support.c (add_symbol_overload_list_qualified): Update.
11315         * breakpoint.c (create_overlay_event_breakpoint)
11316         (create_longjmp_master_breakpoint)
11317         (create_std_terminate_master_breakpoint)
11318         (create_exception_master_breakpoint): Update.
11319         * blockframe.c (find_pc_partial_function): Update.
11320         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11321         (ada_collect_symbol_completion_matches)
11322         (ada_add_global_exceptions): Update.
11323
11324 2019-01-17  Tom Tromey  <tom@tromey.com>
11325
11326         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11327         declare VEC.
11328         (solib_target_parse_libraries): Change return type.
11329         (library_list_start_segment, library_list_start_section)
11330         (library_list_end_library, library_list_start_library); Update.
11331         (solib_target_free_library_list): Remove.
11332         (solib_target_parse_libraries): Remove cleanup.  Change return
11333         type.
11334         (solib_target_current_sos): Update.
11335
11336 2019-01-17  Tom Tromey  <tromey@bapiya>
11337
11338         * valprint.c: Replace "the the" with "the".
11339         * symtab.c: Replace "the the" with "the".
11340         * solib.c: Replace "the the" with "the".
11341         * solib-dsbt.c: Replace "the the" with "the".
11342         * linespec.c: Replace "the the" with "the".
11343         * dwarf2loc.h: Replace "the the" with "the".
11344         * amd64-windows-tdep.c: Replace "the the" with "the".
11345         * aarch64-tdep.c: Replace "the the" with "the".
11346
11347 2019-01-16  Keith Seitz  <keiths@redhat.com>
11348
11349         PR gdb/23773
11350         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11351         <builder>: Rename to ..
11352         <m_builder>: ... this and make private.
11353         (dwarf2_cu::get_builder): New method.  Change all users of
11354         `builder' to use this method.
11355         (dwarf2_start_symtab): Move to ...
11356         (dwarf2_cu::start_symtab): ... here.  Update all callers
11357         (setup_type_unit_groups): Move to ...
11358         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11359         callers.
11360         (dwarf2_cu::reset_builder): New method.
11361         (process_full_compunit, process_full_type_unit): Use
11362         dwarf2_cu::reset_builder.
11363         (follow_die_offset): Record the ancestor CU if it is different
11364         from the followed DIE's CU.
11365         (follow_die_sig_1): Likewise.
11366
11367 2019-01-15  Tom Tromey  <tom@tromey.com>
11368
11369         * remote.c (class remote_state) <buf>: Now a char_vector.
11370         <buf_size>: Remove.
11371         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11372         parameter.
11373         (remote_target::getpkt_or_notif_sane_1)
11374         (remote_target::getpkt_sane)
11375         (remote_target::getpkt_or_notif_sane): Likewise.
11376         (class remote_target) <putpkt>: New overload.
11377         (remote_target::read_frame): Change type of "buf_p".  Remove
11378         sizeof_p parameter.
11379         (packet_ok): New overload.
11380         (packet_check_result): New overload.
11381         Update all uses.
11382
11383 2019-01-14  Tom Tromey  <tom@tromey.com>
11384
11385         * remote-notif.c (handle_notification, remote_notif_ack)
11386         (remote_notif_parse): Make "buf" const.
11387         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11388         const.
11389         (remote_notif_parse, remote_notif_ack, handle_notification):
11390         Likewise.
11391         * remote.c (remote_notif_stop_parse): Make "buf" const.
11392         (remote_target::remote_parse_stop_reply): Make "buf" const.
11393         (remote_notif_stop_ack): Make "buf" const.
11394
11395 2019-01-14  Tom Tromey  <tom@tromey.com>
11396
11397         * remote.c (remote_console_output): Make parameter const.
11398
11399 2019-01-14  Tom Tromey  <tom@tromey.com>
11400
11401         * target-debug.h (target_debug_print_signals): Constify.
11402         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11403         * procfs.c (procfs_target::pass_signals): Update.
11404         * linux-nat.c (linux_nat_target::pass_signals): Update.
11405         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11406         * target-delegates.c: Rebuild.
11407         * remote.c (remote_target::program_signals): Update.
11408         (remote_target::pass_signals): Update.
11409         * target.c (target_pass_signals): Constify argument.
11410         (target_program_signals): Likewise.
11411         * target.h (struct target_ops) <pass_signals, program_signals>:
11412         Constify argument.
11413         (target_pass_signals, target_program_signals): Constify argument.
11414
11415 2019-01-14  Tom Tromey  <tom@tromey.com>
11416
11417         PR tui/28819:
11418         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11419
11420 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11421
11422         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11423         field.
11424         * rs6000-tdep.c: Include reggroups.h.
11425         (IS_V_ALIAS_PSEUDOREG): Define.
11426         (rs6000_register_name): Return names for the "vX" aliases.
11427         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11428         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11429         aliases.  Call default_register_reggroup_p for all other
11430         pseudo-registers.
11431         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11432         New functions.
11433         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11434         Handle "vX" aliases.
11435         (v_alias_pseudo_register_collect): New function.
11436         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11437         (rs6000_gdbarch_init): Initialize "vX" aliases as
11438         pseudo-registers.  Restore registration of
11439         rs6000_pseudo_register_reggroup_p with
11440         set_tdesc_pseudo_register_reggroup_p.
11441
11442 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11443
11444         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11445         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11446         set_gdbarch_num_pseudo_regs.
11447
11448 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11449
11450         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11451         Remove arg prefixname, add do_set and do_show.
11452         Add member functions set_list and show_list.
11453         * cli/cli-style.c (class cli_style_option): Update accordingly.
11454         (style_set_list): Move to file scope.
11455         (style_show_list): Likewise.
11456         (set_style): Call help_list.
11457         (show_style): Call cmd_show_list.
11458         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11459         Update to use the new macro.
11460
11461 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11462
11463         * ada-lang.c (_initialize_ada_language): Expand the help text
11464         for the "catch exception" command.
11465
11466 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11467
11468         * symtab.c (matching_obj_sections): Initialize obj,
11469         declare it closer to its usage.
11470
11471 2019-01-10  Tom Tromey  <tom@tromey.com>
11472
11473         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11474         (basic_inf_threads_range): Remove.
11475         (inf_threads_range, inf_non_exited_threads_range)
11476         (safe_inf_threads_range): Use next_adapter.
11477
11478 2019-01-10  Keith Seitz  <keiths@redhat.com>
11479
11480         PR gdb/23712
11481         PR symtab/23010
11482         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11483         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11484
11485 2019-01-10  Keith Seitz  <keiths@redhat.com>
11486
11487         PR gdb/23712
11488         PR symtab/23010
11489         * dictionary.c (pending_to_vector): Remove.
11490         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11491         Remove _1 suffix, replacing functions of the same name.  Update
11492         all callers.
11493         (dict_create_hashed, dict_create_hashed_expandable)
11494         (dict_create_linear, dict_create_linear_expandable, dict_free)
11495         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11496         Make functions static.
11497
11498 2019-01-10  Keith Seitz  <keiths@redhat.com>
11499
11500         PR gdb/23712
11501         PR symtab/23010
11502         * dictionary.h (struct dictionary): Replace declaration with
11503         multidictionary.
11504         (dict_create_hashed, dict_create_hashed_expandable)
11505         (dict_create_linear, dict_create_linear_expandable)
11506         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11507         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11508         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11509         taking multidictionary argument.
11510         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11511         * block.h (struct block) <dict>: Change to multidictionary
11512         and rename `multidict'.
11513         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11514         symmisc.c: Update all dictionary references to multidictionary.
11515
11516 2019-01-10  Keith Seitz  <keiths@redhat.com>
11517
11518         PR gdb/23712
11519         PR symtab/23010
11520         * dictionary.c: Include unordered_map.
11521         (pending_to_vector): New function.
11522         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11523         Rewrite the non-"_1" functions to take vector instead
11524         of linked list.
11525         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11526         "new" _1 versions of the same name.
11527         (multidictionary): Define.
11528         (std::hash<enum language): New definition.
11529         (collate_pending_symbols_by_language, mdict_create_hashed)
11530         (mdict_create_hashed_expandable, mdict_create_linear)
11531         (mdict_create_linear_expandable, mdict_free)
11532         (find_language_dictionary, create_new_language_dictionary)
11533         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11534         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11535         (mdict_size, mdict_empty): New functions.
11536         * dictionary.h (mdict_iterator): Define.
11537
11538 2019-01-10  Pedro Alves  <palves@redhat.com>
11539
11540         * breakpoint.c (read_uploaded_action)
11541         (create_tracepoint_from_upload): Adjust to use
11542         gdb::unique_xmalloc_ptr.
11543         * ctf.c (ctf_write_uploaded_tp):
11544         (SET_ARRAY_FIELD): Use emplace_back.
11545         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11546         * tracefile-tfile.c (tfile_write_uploaded_tp):
11547         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11548         gdb::unique_xmalloc_ptr.
11549         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11550         at_string, cond_string, cmd_strings>: Replace char pointers
11551         with gdb::unique_xmalloc_ptr.
11552
11553 2019-01-10  Pedro Alves  <palves@redhat.com>
11554
11555         * solib-target.c (library_list_start_library): Don't xstrdup name.
11556
11557 2019-01-10  Pedro Alves  <palves@redhat.com>
11558
11559         * mdebugread.c (parse_partial_symbols): Use
11560         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11561
11562 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11563
11564         * linux-fork.c (scoped_switch_fork_info)
11565         <~scoped_switch_fork_info>: Fix incorrect variable name.
11566
11567 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11568
11569         * linux-fork.c (scoped_switch_fork_info)
11570         <scoped_switch_fork_info>: Make explicit.
11571         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11572
11573 2019-01-10  Tom Tromey  <tom@tromey.com>
11574
11575         * objfiles.h (objfile::reset_psymtabs): Update.
11576         * objfiles.c (objfile::objfile): Update.
11577         * psymtab.h (psymtab_storage::obstack): Update.
11578         (psymtab_storage::m_obstack): Use gdb::optional.
11579         (class psymtab_storage): Update comment.  Remove objfile
11580         parameter.
11581         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11582
11583 2019-01-10  Tom Tromey  <tom@tromey.com>
11584
11585         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11586         <free_psymtabs>: Now private.
11587         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11588         (allocate_psymtab): Use new method.
11589
11590 2019-01-10  Tom Tromey  <tom@tromey.com>
11591
11592         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11593         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11594         * mdebugread.c (parse_partial_symbols): Use
11595         allocate_dependencies.
11596         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11597         allocate_dependencies.
11598         (process_psymtab_comp_unit_reader)
11599         (build_type_psymtab_dependencies): Likewise.
11600         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11601
11602 2019-01-10  Tom Tromey  <tom@tromey.com>
11603
11604         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11605         PSYMBOL_SET_LANGUAGE.
11606         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11607
11608 2019-01-10  Tom Tromey  <tom@tromey.com>
11609
11610         * psymtab.h (psymtab_storage::obstack): New method.
11611         <m_obstack>: Rename from obstack; now private.
11612         * psymtab.c (psymtab_storage): Update.
11613         * dwarf2read.c (create_addrmap_from_index)
11614         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11615         Update.
11616
11617 2019-01-10  Tom Tromey  <tom@tromey.com>
11618
11619         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11620         * objfiles.h (objfile::reset_psymtabs): New method.
11621
11622 2019-01-10  Tom Tromey  <tom@tromey.com>
11623
11624         * symmisc.c (print_symbol_bcache_statistics): Update.
11625         (print_objfile_statistics): Update.
11626         * symfile.c (reread_symbols): Update.
11627         * psymtab.h (class psymtab_storage): New.
11628         * psymtab.c (psymtab_storage): New constructor.
11629         (~psymtab_storage): New destructor.
11630         (require_partial_symbols): Update.
11631         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11632         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11633         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11634         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11635         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11636         (start_psymtab_common, end_psymtab_common)
11637         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11638         (allocate_psymtab): Update.
11639         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11640         Update.
11641         (dump_psymtab_addrmap, maintenance_print_psymbols)
11642         (maintenance_check_psymtabs): Update.
11643         (class objfile_psymtabs): Move to objfiles.h.
11644         * psympriv.h (discard_psymtab): Now inline.
11645         (psymtab_discarder::psymtab_discarder): Update.
11646         (psymtab_discarder::~psymtab_discarder): Update.
11647         (ALL_OBJFILE_PSYMTABS): Rewrite.
11648         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11649         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11650         Remove fields.
11651         <partial_symtabs>: New field.
11652         (class objfile_psymtabs): Move from psymtab.h.  Update.
11653         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11654         psymbol_cache.
11655         (objfile::~objfile): Don't destroy psymbol_cache.
11656         * mdebugread.c (parse_partial_symbols): Update.
11657         * dwarf2read.c (create_addrmap_from_index)
11658         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11659         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11660         (add_partial_subprogram, dwarf2_ranges_read): Update.
11661         * dwarf-index-write.c (write_address_map)
11662         (write_one_signatured_type, recursively_write_psymbols)
11663         (class debug_names, class debug_names, write_psymtabs_to_index):
11664         Update.
11665
11666 2019-01-10  Tom Tromey  <tom@tromey.com>
11667
11668         * symtab.h (SYMBOL_SET_NAMES): Update.
11669         (symbol_set_names): Update.
11670         (MSYMBOL_SET_NAMES): Update.
11671         * symtab.c (symbol_set_names): Change argument to be an
11672         objfile_per_bfd_storage.
11673         * psymtab.c (add_psymbol_to_bcache): Update.
11674         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11675
11676 2019-01-10  Tom Tromey  <tom@tromey.com>
11677
11678         * symtab.c (create_demangled_names_hash): Change argument to be an
11679         objfile_per_bfd_storage.
11680         (symbol_set_names): Update.
11681
11682 2019-01-10  Tom Tromey  <tom@tromey.com>
11683
11684         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11685         init_psymbol_list.
11686         * psymtab.c (init_psymbol_list): Do nothing if already called.
11687         * psympriv.h (init_psymbol_list): Add comment.
11688         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11689         init_psymbol_list.
11690         * dbxread.c (dbx_symfile_read): Unconditionally call
11691         init_psymbol_list.
11692
11693 2019-01-10  Tom Tromey  <tom@tromey.com>
11694
11695         * xcoffread.c (scan_xcoff_symtab): Update.
11696         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11697         "where".
11698         * mdebugread.c (parse_partial_symbols)
11699         (handle_psymbol_enumerators): Update.
11700         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11701         * dbxread.c (read_dbx_symtab): Update.
11702         * psympriv.h (psymbol_placement): New enum.
11703         (add_psymbol_to_list): Update.
11704
11705 2019-01-10  Tom Tromey  <tom@tromey.com>
11706
11707         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11708         static_psymbols parameters.
11709         (scan_xcoff_symtab): Update.
11710         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11711         static_psymbols parameters.
11712         * psympriv.h (start_psymtab_common): Update.
11713         * mdebugread.c (parse_partial_symbols): Update.
11714         * dwarf2read.c (create_partial_symtab): Update.
11715         * dbxread.c (read_dbx_symtab): Update.
11716         (start_psymtab): Remove global_psymbols and static_psymbols
11717         parameters.
11718
11719 2019-01-10  Tom Tromey  <tom@tromey.com>
11720
11721         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11722         * psymtab.c (allocate_psymtab): Add comment.
11723         * psympriv.h (allocate_psymtab): Add comment.
11724         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11725         initializations.
11726         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11727
11728 2019-01-10  Tom Tromey  <tom@tromey.com>
11729
11730         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11731         Don't declare.
11732         * mipsread.c: Include mdebugread.h.
11733         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11734         Declare.
11735         * elfread.c: Include mdebugread.h.
11736
11737 2019-01-09  Tom Tromey  <tom@tromey.com>
11738
11739         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11740         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11741         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11742         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11743         (psym_lookup_symbol, psym_find_last_source_symtab)
11744         (psym_forget_cached_source_info, psym_print_stats)
11745         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11746         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11747         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11748         (psym_find_compunit_symtab_by_address)
11749         (maintenance_print_psymbols, maintenance_info_psymtabs)
11750         (maintenance_check_psymtabs): Use ranged for.
11751         * psymtab.h (class objfile_psymtabs): New.
11752         (require_partial_symbols): Return objfile_psymtabs.
11753         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11754
11755 2019-01-09  Tom Tromey  <tom@tromey.com>
11756
11757         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11758         (find_pc_mapped_section, list_overlays_command)
11759         (map_overlay_command, unmap_overlay_command)
11760         (simple_overlay_update): Use all_objfiles.
11761         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11762         * printcmd.c (info_symbol_command): Use all_objfiles.
11763         * objfiles.h (ALL_OBJSECTIONS): Remove.
11764         * maint.c (maintenance_translate_address): Use all_objfiles.
11765         * gcore.c (gcore_create_callback): Use all_objfiles.
11766         (objfile_find_memory_regions): Likewise.
11767
11768 2019-01-09  Tom Tromey  <tom@tromey.com>
11769
11770         * symtab.c (find_line_symtab, info_sources_command)
11771         (make_source_files_completion_list): Use objfile_compunits.
11772         * source.c (select_source_symtab): Use objfile_compunits.
11773         * objfiles.h (struct objfile): Update comment.
11774         (ALL_OBJFILES): Remove.
11775         (ALL_FILETABS): Remove.
11776         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11777         objfile_compunits.
11778
11779 2019-01-09  Tom Tromey  <tom@tromey.com>
11780
11781         * symmisc.c (print_objfile_statistics, dump_objfile)
11782         (maintenance_print_symbols): Use compunit_filetabs.
11783         * source.c (forget_cached_source_info_for_objfile): Use
11784         compunit_filetabs.
11785         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11786         (ALL_FILETABS): Use compunit_filetabs.
11787         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11788         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11789
11790 2019-01-09  Tom Tromey  <tom@tromey.com>
11791
11792         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11793         (compunit_filetabs): New.
11794         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11795         compunit_filetabs.
11796         (info_sources_command, make_source_files_completion_list): Remove
11797         declaration.
11798         * symmisc.c (print_objfile_statistics, dump_objfile)
11799         (maintenance_print_symbols): Remove declaration.
11800         (maintenance_info_symtabs): Use compunit_filetabs.
11801         (maintenance_info_line_tables): Likewise.
11802         * source.c (select_source_symtab): Change local variable name.
11803         (forget_cached_source_info_for_objfile): Remove declaration.
11804         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11805         * objfiles.c (objfile_relocate1): Remove declaration.
11806         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11807         declaration.
11808         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11809         * coffread.c (coff_symtab_read): Remove declaration.
11810         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11811         compunit_filetabs.
11812
11813 2019-01-09  Tom Tromey  <tom@tromey.com>
11814
11815         * symtab.c (lookup_objfile_from_block)
11816         (find_pc_sect_compunit_symtab, search_symbols)
11817         (default_collect_symbol_completion_matches_break_on): Use
11818         objfile_compunits.
11819         * objfiles.h (ALL_COMPUNITS): Remove.
11820         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11821         * cp-support.c (add_symbol_overload_list_qualified): Use
11822         objfile_compunits.
11823         * ada-lang.c (ada_collect_symbol_completion_matches)
11824         (ada_add_global_exceptions): Use objfile_compunits.
11825
11826 2019-01-09  Tom Tromey  <tom@tromey.com>
11827
11828         * source.c (select_source_symtab)
11829         (forget_cached_source_info_for_objfile): Remove declaration.
11830         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11831         declaration.
11832         * maint.c (count_symtabs_and_blocks): Remove declaration.
11833         * cp-support.c (add_symbol_overload_list_qualified): Remove
11834         declaration.
11835         * coffread.c (coff_symtab_read): Remove declaration.
11836         * symtab.c (lookup_symbol_in_objfile_symtabs)
11837         (basic_lookup_transparent_type_1): Use objfile_compunits.
11838         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11839         (info_sources_command, search_symbols)
11840         (default_collect_symbol_completion_matches_break_on)
11841         (make_source_files_completion_list): Remove declaration.
11842         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11843         (ada_collect_symbol_completion_matches)
11844         (ada_add_global_exceptions): Remove declaration.
11845         * linespec.c (iterate_over_all_matching_symtabs): Use
11846         objfile_compunits.
11847         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11848         (class objfile_compunits): New.
11849         (ALL_COMPUNITS): Use objfile_compunits.
11850         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11851         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11852         objfile_compunits.
11853         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11854
11855 2019-01-09  Tom Tromey  <tom@tromey.com>
11856
11857         * symtab.c (search_symbols)
11858         (default_collect_symbol_completion_matches_break_on): Use
11859         objfile_msymbols.
11860         * ada-lang.c (ada_lookup_simple_minsym)
11861         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11862         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11863         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11864         objfile_msymbols.
11865         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11866         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11867         * objc-lang.c (find_methods): Use objfile_msymbols.
11868         (info_selectors_command, info_classes_command): Likewise.
11869         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11870         * objfiles.h (class objfile_msymbols): New.
11871         (ALL_OBJFILE_MSYMBOLS): Remove.
11872         (ALL_MSYMBOLS): Remove.
11873
11874 2019-01-09  Tom Tromey  <tom@tromey.com>
11875
11876         * common/next-iterator.h (next_adapter): Add Iterator template
11877         parameter.
11878         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11879         (class all_objfiles_safe): New.
11880         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11881         * objfiles.c (put_objfile_before): Update comment.
11882         (add_separate_debug_objfile): Likewise.
11883         (free_all_objfiles): Use all_objfiles_safe.
11884         (objfile_purge_solibs): Likewise.
11885
11886 2019-01-09  Tom Tromey  <tom@tromey.com>
11887
11888         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11889         (expand_symtab_containing_pc, lookup_static_symbol)
11890         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11891         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11892         all_objfiles.
11893         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11894         * breakpoint.c (create_overlay_event_breakpoint)
11895         (create_longjmp_master_breakpoint)
11896         (create_std_terminate_master_breakpoint)
11897         (create_exception_master_breakpoint): Use all_objfiles.
11898         * linux-thread-db.c (try_thread_db_load_from_pdir)
11899         (has_libpthread): Use all_objfiles.
11900         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11901         * linespec.c (iterate_over_all_matching_symtabs)
11902         (search_minsyms_for_name): Use all_objfiles.
11903         * maint.c (maintenance_info_sections): Use all_objfiles.
11904         * main.c (captured_main_1): Use all_objfiles.
11905         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11906         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11907         * guile/scm-pretty-print.c
11908         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11909         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11910         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11911         (maintenance_print_msymbols): Use all_objfiles.
11912         * source.c (select_source_symtab): Use all_objfiles.
11913         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11914         * symfile.c (remove_symbol_file_command)
11915         (expand_symtabs_matching, map_symbol_filenames): Use
11916         all_objfiles.
11917         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11918         all_objfiles.
11919         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11920         * objc-lang.c (find_methods): Use all_objfiles.
11921         * objfiles.c (have_partial_symbols, have_full_symbols)
11922         (have_minimal_symbols, qsort_cmp)
11923         (default_iterate_over_objfiles_in_search_order): Use
11924         all_objfiles.
11925         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11926         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11927         (maintenance_check_psymtabs): Use all_objfiles.
11928         (ALL_PSYMTABS): Remove.
11929         * compile/compile-object-run.c (do_module_cleanup): Use
11930         all_objfiles.
11931         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11932         * cp-support.c (add_symbol_overload_list_qualified): Use
11933         all_objfiles.
11934         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11935         Use all_objfiles.
11936         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11937         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11938         all_objfiles.
11939         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11940         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11941         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11942         Uses all_objfiles.
11943         * solib.c (solib_read_symbols): Use all_objfiles
11944
11945 2019-01-09  Tom Tromey  <tom@tromey.com>
11946
11947         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11948         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11949         all_objfiles.
11950         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11951         * symmisc.c (print_symbol_bcache_statistics)
11952         (print_objfile_statistics, maintenance_print_objfiles)
11953         (maintenance_info_symtabs, maintenance_check_symtabs)
11954         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11955         all_objfiles.
11956         * source.c (forget_cached_source_info): Use all_objfiles.
11957         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11958         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11959         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11960         * objfiles.c (update_section_map): Use all_objfiles.
11961         (shared_objfile_contains_address_p): Likewise.
11962         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11963         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11964
11965 2019-01-09  Tom Tromey  <tom@tromey.com>
11966
11967         * common/next-iterator.h: New file.
11968         * objfiles.h (class all_objfiles): New.
11969         (struct objfile_iterator): New.
11970
11971 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11972
11973         * NEWS: Move the description of the changed "frame", "select-frame",
11974          and "info frame" commands to the Changed commands section.
11975
11976 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11977
11978         * gdbtypes.c (check_stub_method_group): Remove handling of old
11979         mangling schemes.
11980         * linespec.c (find_methods): Likewise.
11981         * stabsread.c (read_member_functions): Likewise.
11982         * valops.c (search_struct_method): Likewise.
11983         (value_struct_elt_for_reference): Likewise.
11984         * NEWS: Mention this change.
11985
11986 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11987
11988         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11989         print_source_lines.
11990         * source.c (print_source_lines_base): Update line number check.
11991         (print_source_lines): New function.
11992         (source_lines_range::source_lines_range): New function.
11993         * source.h (class source_lines_range): New class.
11994         (print_source_lines): New declaration.
11995
11996 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11997
11998         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11999
12000 2019-01-08  Tom Tromey  <tom@tromey.com>
12001             Simon Marchi  <simon.marchi@ericsson.com>
12002
12003         PR gdb/24060
12004         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12005         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12006         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12007         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12008         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12009         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12010
12011 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12012
12013         * source.c (select_source_symtab): Move header comment to
12014         declaration in source.h.
12015         (forget_cached_source_info_for_objfile): Likewise.
12016         (forget_cached_source_info): Likewise.
12017         (identify_source_line): Likewise.
12018         * source.h (identify_source_line): Move declaration from symtab.h
12019         and add comment from source.c
12020         (print_source_lines): Likewise.
12021         (forget_cached_source_info_for_objfile): Likewise.
12022         (forget_cached_source_info): Likewise.
12023         (select_source_symtab): Likewise.
12024         (enum print_source_lines_flag): Move definition from symtab.h.
12025         * symtab.h (identify_source_line): Move declaration to source.h.
12026         (print_source_lines): Likewise.
12027         (forget_cached_source_info_for_objfile): Likewise.
12028         (forget_cached_source_info): Likewise.
12029         (select_source_symtab): Likewise.
12030         (enum print_source_lines_flag): Move definition to source.h.
12031         * tui/tui-hooks.c: Add 'source.h' include.
12032
12033 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12034
12035         * source.c (print_source_lines_base): Handle requests to print
12036         reverse line number sequences, and guard against empty lines
12037         string.
12038
12039 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12040
12041         * source.c (print_source_lines_base): Fix skip of '\r' if next
12042         character is '\n'.
12043
12044 2019-01-06  Tom Tromey  <tom@tromey.com>
12045
12046         * c-exp.y (struct c_parse_state) <macro_original_text,
12047         expansion_obstack>: New member.
12048         (macro_original_text, expansion_obstack): Remove globals.
12049         (scan_macro_expansion, scanning_macro_expansion)
12050         (finished_macro_expansion): Update.
12051         (scan_macro_cleanup): Remove.
12052         (yylex, c_parse): Update.
12053
12054 2019-01-06  Tom Tromey  <tom@tromey.com>
12055
12056         * c-exp.y (struct c_parse_state) <strings>: New member.
12057         (operator_stoken): Update.
12058
12059 2019-01-06  Tom Tromey  <tom@tromey.com>
12060
12061         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12062         (union type_stack_elt) <typelist_val>: Now a pointer to
12063         std::vector.
12064         (type_stack_cleanup): Don't declare.
12065         (push_typelist): Update.
12066         * parse.c (pop_typelist): Return a std::vector.
12067         (push_typelist): Take a std::vector.
12068         (follow_types): Update.  Do not free args.
12069         (type_stack_cleanup): Remove.
12070         * c-exp.y (struct c_parse_state): New.
12071         (cpstate): New global.
12072         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12073         (nonempty_typelist): Update.
12074         (func_mod): Create a new vector.
12075         (c_parse): Create a c_parse_state.
12076         (check_parameter_typelist): Do not delete params.
12077         (function_method): Update.  Do not delete type_list.
12078
12079 2019-01-06  Tom Tromey  <tom@tromey.com>
12080
12081         PR gdb/28155:
12082         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12083         check_typedef.
12084         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12085         (print_return_value): Likewise.
12086
12087 2019-01-05  Tom Tromey  <tom@tromey.com>
12088
12089         * contrib/cleanup_check.py: Remove.
12090         * contrib/gcc-with-excheck: Remove.
12091         * contrib/exsummary.py: Remove.
12092         * contrib/excheck.py: Remove.
12093
12094 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12095
12096         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12097         NULL. Initialize tpprev to NULL instead of assigning it
12098         to NULL on the next statement.
12099         * windows-nat.c (windows_delete_thread): Remove check for
12100         main_thread_id before printing thread exit notifications.
12101         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12102         Remove thread ID check against main_thread_id.
12103         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12104         windows_delete_thread.
12105         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12106
12107 2019-01-04  Tom Tromey  <tom@tromey.com>
12108
12109         * compile/compile.c (_initialize_compile): Use upper case for
12110         metasyntactic variables.
12111         * symmisc.c (_initialize_symmisc): Use upper case for
12112         metasyntactic variables.
12113         * psymtab.c (_initialize_psymtab): Use upper case for
12114         metasyntactic variables.
12115         * demangle.c (demangle_command): Use upper case for metasyntactic
12116         variables.
12117         (_initialize_demangler): Likewise.
12118         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12119         variables.
12120
12121 2019-01-03  Tom Tromey  <tom@tromey.com>
12122
12123         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12124
12125 2019-01-03  Tom Tromey  <tom@tromey.com>
12126
12127         * python/py-symtab.c (salpy_str): Update.
12128         (struct salpy_sal_object) <symtab>: Now a PyObject.
12129         (salpy_dealloc): Update.
12130         (del_objfile_sal): Use gdbpy_ref.
12131
12132 2019-01-03  Tom Tromey  <tom@tromey.com>
12133
12134         * python/py-type.c (convert_field): Use new_reference.  Return
12135         gdbpy_ref.
12136         (make_fielditem): Return gdbpy_ref.
12137         (typy_fields): Update.
12138         (typy_getitem): Update.
12139         (field_name): Return gdbpy_ref.  Use new_reference.
12140         (typy_iterator_iternext): Update.
12141
12142 2019-01-03  Tom Tromey  <tom@tromey.com>
12143
12144         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12145
12146 2019-01-03  Tom Tromey  <tom@tromey.com>
12147
12148         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12149         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12150         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12151         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12152         (pspy_set_type_printers): Likewise.
12153         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12154         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12155         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12156         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12157         (objfpy_set_type_printers): Likewise.
12158
12159 2019-01-03  Tom Tromey  <tom@tromey.com>
12160
12161         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12162         (gdbpy_print_stack): Use gdbpy_err_fetch.
12163         * python/python-internal.h (class gdbpy_err_fetch): New class.
12164         (class gdbpy_enter) <m_error_type, m_error_value,
12165         m_error_traceback>: Remove.
12166         <m_error>: New member.
12167         (gdbpy_exception_to_string): Don't declare.
12168         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12169         * python/py-value.c (convert_value_from_python): Use
12170         gdbpy_err_fetch.
12171         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12172         gdbpy_exception_to_string.
12173         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12174         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12175         gdbpy_err_fetch.
12176
12177 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12178
12179         * linux-nat.c (delete_lwp_cleanup): Delete.
12180         (struct lwp_deleter): New struct.
12181         (lwp_info_up): New typedef.
12182         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12183         lwp_info_up.
12184
12185 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12186
12187         * linux-fork.c (class scoped_switch_fork_info): New class.
12188         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12189
12190 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12191
12192         * valops.c (find_overload_match): Remove use of null_cleanup, and
12193         calls to do_cleanups.
12194
12195 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12196
12197         * compile/compile-cplus-types.c
12198         (compile_cplus_instance::decl_name): Handle changes to
12199         cp_func_name.
12200         * cp-support.c (cp_func_name): Update header comment, update
12201         return type.
12202         * cp-support.h (cp_func_name): Update return type in declaration.
12203         * valops.c (find_overload_match): Move temp_func local to top
12204         level of function and change its type.  Use temp_func to hold and
12205         delete temporary string obtained from cp_func_name.
12206
12207 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12208
12209         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12210         gdb::char_vector, remove cleanup, and update uses of `msg`.
12211
12212 2019-01-03  Jim Wilson  <jimw@sifive.com>
12213
12214         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12215
12216 2019-01-02  Tom Tromey  <tom@tromey.com>
12217
12218         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12219         (tdesc_parse_xml): Remove cleanups.
12220         * target-descriptions.h (make_cleanup_free_target_description):
12221         Don't declare.
12222         (target_desc_deleter): New struct.
12223         (target_desc_up): New typedef.
12224         * target-descriptions.c (target_desc_deleter::operator()): Rename
12225         from free_target_description.
12226         (make_cleanup_free_target_description): Remove.
12227
12228 2019-01-02  Tom Tromey  <tom@tromey.com>
12229
12230         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12231         constructor, destructor.
12232         (linespec_parser): Remove typedef.
12233         (~linespec_parser): Rename from linespec_parser_delete.
12234         (linespec_lex_to_end, linespec_complete_label)
12235         (linespec_complete): Update.
12236         (decode_line_full): Remove cleanups.
12237         (decode_line_1): Update.
12238
12239 2019-01-02  Tom Tromey  <tom@tromey.com>
12240
12241         * python/python-internal.h (inferior_to_inferior_object): Change
12242         return type.
12243         * python/py-exitedevent.c (create_exited_event_object): Update.
12244         * python/py-inferior.c (inferior_to_inferior_object): Return
12245         gdbpy_ref.
12246         (python_new_inferior, python_inferior_deleted)
12247         (thread_to_thread_object, delete_thread_object)
12248         (build_inferior_list, gdbpy_selected_inferior): Update.
12249         * python/py-infthread.c (create_thread_object): Update.  Also fail
12250         if inferior_to_inferior_object fails.
12251
12252 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12253
12254         * inferior.h (class inferior) <displaced_step_state>: New field.
12255         * infrun.h (struct displaced_step_state): Move here from
12256         infrun.c.  Initialize fields, add constructor.
12257         <inf>: Remove field.
12258         <reset>: New method.
12259         * infrun.c (struct displaced_step_inferior_state): Move to
12260         infrun.h.
12261         (displaced_step_inferior_states): Remove.
12262         (get_displaced_stepping_state): Adust.
12263         (displaced_step_in_progress_any_inferior): Adjust.
12264         (displaced_step_in_progress_thread): Adjust.
12265         (displaced_step_in_progress): Adjust.
12266         (add_displaced_stepping_state): Remove.
12267         (get_displaced_step_closure_by_addr): Adjust.
12268         (remove_displaced_stepping_state): Remove.
12269         (infrun_inferior_exit): Call displaced_step_state.reset.
12270         (use_displaced_stepping): Don't check for NULL.
12271         (displaced_step_prepare_throw): Call
12272         get_displaced_stepping_state.
12273         (displaced_step_fixup): Don't check for NULL.
12274         (prepare_for_detach): Don't check for NULL.
12275
12276 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12277
12278         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12279          in case of call that did not complete.
12280
12281 2019-01-02  Andrey Utkin  <autkin@undo.io>
12282
12283         * symfile.c (find_separate_debug_file): Fix search of debug files for
12284         remote debuggee.
12285
12286 2019-01-02  Tom Tromey  <tom@tromey.com>
12287
12288         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12289         indentation.
12290         * python/py-frame.c (frapy_older): Remove cast.
12291         (frapy_newer): Likewise.
12292         * python/py-breakpoint.c (local_setattro): Remove cast.
12293         * python/py-arch.c (archpy_name): Remove local variable.
12294         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12295
12296 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12297
12298         * unittests/basic_string_view/element_access/char/empty.cc:
12299         Fix year range in copyright header.
12300
12301 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12302
12303         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12304         Delete.
12305         <operator==>: Update with for removed field.
12306         <hash>: Likewise.
12307         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12308         <isa_features>: ...this.
12309         <abi_features>: New field.
12310         (riscv_isa_flen): Update comment.
12311         (riscv_abi_xlen): New declaration.
12312         (riscv_abi_flen): New declaration.
12313         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12314         isa_features.
12315         (riscv_abi_xlen): New function.
12316         (riscv_isa_flen): Update to get answer from isa_features.
12317         (riscv_abi_flen): New function.
12318         (riscv_has_fp_abi): Update to get answer from abi_features.
12319         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12320         xlen and flen.
12321         (riscv_call_info) <xlen, flen>: Update comment.
12322         (riscv_call_arg_struct): Remove invalid assertions
12323         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12324         is removed.
12325         (riscv_gdbarch_init): Gather isa features and abi features
12326         separately, ensure both match on the gdbarch when reusing an old
12327         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12328         a target with 64-bit float hardware.
12329
12330 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12331
12332         * source.c (search_command_helper): Stop reverse search
12333         when line 1 has been searched.
12334
12335 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12336
12337         * record-full.c (record_full_base_target::close): Rewrite
12338         record_full_core_buf_list free logic.
12339
12340 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12341
12342         * break-catch-syscall.c (print_one_catch_syscall): xfree
12343         the last text.
12344
12345 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12346
12347         * top.c (print_gdb_version): Update Copyright year in version
12348         message.
12349
12350 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12351
12352         Update copyright year range in all GDB files.
12353
12354 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12355
12356         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12357
12358 For older changes see ChangeLog-2018.
12359 \f
12360 Local Variables:
12361 mode: change-log
12362 left-margin: 8
12363 fill-column: 74
12364 version-control: never
12365 coding: utf-8
12366 End:
12367