gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
   4         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
   5         * tui/tui-data.c (tui_alloc_win_info): Remove.
   6
   7 2019-06-25  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
  10         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
  11         can_highlight.
  12
  13 2019-06-25  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
  16         make_visible_with_new_height method.
  17         (tui_win_info::make_visible_with_new_height): New method.
  18         (tui_source_window_base::do_make_visible_with_new_height)
  19         (tui_data_window::do_make_visible_with_new_height)
  20         (tui_cmd_window::do_make_visible_with_new_height): New methods.
  21         (make_visible_with_new_height): Remove.
  22         (tui_resize_all, tui_adjust_win_heights): Use
  23         make_visible_with_new_height method.
  24         * tui/tui-data.h (struct tui_win_info)
  25         <do_make_visible_with_new_height, make_visible_with_new_height>:
  26         New methods.
  27         (struct tui_source_window_base, struct tui_data_window)
  28         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
  29         methods.
  30
  31 2019-06-25  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
  34         method.
  35         (update_tab_width): Call update_tab_width method.
  36         * tui/tui-data.h (struct tui_win_info)
  37         (struct tui_source_window_base) <update_tab_width>: New methods.
  38
  39 2019-06-25  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
  42         parameter.
  43         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
  44         parameter.
  45         (tui_gen_win_info::make_visible): Update.
  46         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
  47         parameter.
  48         * tui/tui-data.h (enum tui_box): New enum.
  49         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
  50
  51 2019-06-25  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-layout.c (make_source_or_disasm_window): Always use
  54         init_and_make_win for EXEC_INFO_WIN.
  55         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
  56         longer inline.
  57         (struct tui_win_info) <~tui_win_info>: Inline.
  58         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
  59         Don't declare.
  60         * tui/tui-data.c (source_win, disasm_win): Remove globals.
  61         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
  62         Remove.
  63         (tui_initialize_static_data): Update.
  64         (~tui_gen_win_info): Handle more cleanup here.
  65         (~tui_source_window_base): Delete "execution_info".
  66         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
  67
  68 2019-06-25  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-layout.c (make_command_window): Don't set
  71         can_highlight.
  72         (show_source_disasm_command): Call the reset method.
  73         (show_data): Don't set can_highlight.  Call the reset method.
  74         (tui_gen_win_info::reset): Rename from init_gen_win_info
  75         (init_and_make_win): Simplify.  Return tui_gen_win_info.
  76         (show_source_or_disasm_and_command): Call the reset method.
  77         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
  78         (struct tui_cmd_window): Set can_highlight.
  79
  80 2019-06-25  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
  83         from make_visible.
  84         (tui_make_visible, tui_make_invisible): Rewrite.
  85         (tui_win_info::make_visible): Remove.
  86         (tui_source_window_base::make_visible): Update.
  87         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
  88         method.  Moved from...
  89         (struct tui_win_info) <make_visible>: ...here.
  90
  91 2019-06-25  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-winsource.c
  94         (tui_source_window_base::do_scroll_horizontal): Remove direction
  95         parameter.
  96         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
  97         direction parameter.
  98         * tui/tui-win.c (tui_win_info::forward_scroll)
  99         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 100         (tui_win_info::right_scroll): Update.
 101         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 102         direction parameter.
 103         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 104         direction parameter.
 105         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 106         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 107         Remove direction parameter.
 108         (struct tui_source_window_base, struct tui_source_window)
 109         (struct tui_disasm_window, struct tui_data_window)
 110         (struct tui_cmd_window): Update.
 111
 112 2019-06-25  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-winsource.h (tui_set_exec_info_content)
 115         (tui_show_exec_info_content, tui_erase_exec_info_content)
 116         (tui_clear_exec_info_content, tui_update_exec_info): Change
 117         argument to tui_source_window_base.
 118         * tui/tui-winsource.c (tui_set_exec_info_content)
 119         (tui_show_exec_info_content, tui_erase_exec_info_content)
 120         (tui_clear_exec_info_content, tui_update_exec_info): Change
 121         argument to tui_source_window_base.
 122
 123 2019-06-25  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 126         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 127
 128 2019-06-25  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 131         check.
 132
 133 2019-06-25  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 136         type to void.
 137         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 138         type to void.
 139         * tui/tui-source.c (tui_set_source_content): Update.
 140         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 141
 142 2019-06-25  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-win.c (window_name_completer, tui_set_focus)
 145         (tui_all_windows_info): Use name method.
 146         * tui/tui-data.h (struct tui_gen_win_info)
 147         (struct tui_source_window, struct tui_disasm_window)
 148         (struct tui_data_window, struct tui_cmd_window) <name>: New
 149         method.
 150         (tui_win_name): Don't declare.
 151         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 152         (tui_win_name): Remove.
 153
 154 2019-06-25  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-winsource.h (tui_update_source_window)
 157         (tui_update_source_window_as_is): Change parameter type.
 158         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 159         to be a tui_source_window_base.
 160         (tui_update_source_window_as_is): Likewise.
 161         * tui/tui-win.c (make_visible_with_new_height): Update.
 162
 163 2019-06-25  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-winsource.c (tui_erase_source_content)
 166         (tui_show_source_content, tui_show_exec_info_content)
 167         (tui_erase_exec_info_content): Use refresh_window method.
 168         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 169         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 170         from tui_refresh_win.
 171         (tui_data_window::refresh_window): New method.
 172         (tui_win_info::refresh, tui_source_window_base::refresh)
 173         (tui_refresh_all): Use refresh_window method.
 174         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 175         method.
 176         * tui/tui-regs.c (tui_display_register): Call refresh_window
 177         method.
 178         * tui/tui-layout.c (show_source_disasm_command)
 179         (show_source_or_disasm_and_command): Call refresh_window method.
 180         * tui/tui-data.h (struct tui_gen_win_info)
 181         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 182         New method.
 183
 184 2019-06-25  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui.c (tui_rl_other_window, tui_enable)
 187         (tui_is_window_visible, tui_get_command_dimension): Update.
 188         * tui/tui-winsource.c (tui_update_source_window_as_is)
 189         (tui_clear_source_content, tui_erase_source_content)
 190         (tui_show_source_line, tui_source_window_base::refill)
 191         (tui_source_window_base::do_scroll_horizontal)
 192         (tui_source_window_base::set_is_exec_point_at)
 193         (tui_update_breakpoint_info, tui_set_exec_info_content)
 194         (tui_alloc_source_buffer, tui_line_is_displayed)
 195         (tui_addr_is_displayed): Update.
 196         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 197         (tui_check_and_display_highlight_if_needed)
 198         (tui_win_info::make_visible, tui_win_info::refresh)
 199         (tui_refresh_all): Update.
 200         * tui/tui-windata.c (tui_first_data_item_displayed)
 201         (tui_delete_data_content_windows, tui_erase_data_content)
 202         (tui_display_all_data, tui_data_window::refresh_all)
 203         (tui_check_data_values): Update.
 204         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 205         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 206         (tui_win_info::backward_scroll, tui_refresh_all_win)
 207         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 208         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 209         (tui_source_window_base::set_new_height)
 210         (tui_data_window::set_new_height)
 211         (make_invisible_and_set_new_height)
 212         (make_visible_with_new_height, new_height_ok)
 213         (parse_scrolling_args): Update.
 214         * tui/tui-stack.c (tui_show_frame_info): Update.
 215         * tui/tui-source.c (tui_set_source_content)
 216         (tui_set_source_content_nil, tui_source_is_displayed)
 217         (tui_source_window::do_scroll_vertical): Update.
 218         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 219         (tui_display_registers_from, tui_display_reg_element_at_line)
 220         (tui_check_register_values, tui_reg_command): Update.
 221         * tui/tui-layout.c (tui_default_win_height)
 222         (show_source_disasm_command, show_data, init_and_make_win)
 223         (show_source_or_disasm_and_command): Update.
 224         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 225         (tui_redisplay_readline, tui_mld_flush)
 226         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 227         (tui_getc): Update.
 228         * tui/tui-disasm.c (tui_set_disassem_content)
 229         (tui_disasm_window::do_scroll_vertical): Update.
 230         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 231         Now virtual.
 232         (struct tui_win_info): Derive from tui_gen_win_info.
 233         <~tui_win_info>: Mark as override.
 234         <generic>: Remove member.
 235         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 236         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 237         (~tui_data_window, ~tui_win_info)
 238         (tui_free_all_source_wins_content): Update.
 239         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 240
 241 2019-06-25  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-layout.c (init_and_make_win): Use new.
 244         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 245         destructor, initializers.
 246         (tui_alloc_generic_win_info): Don't declare.
 247         * tui/tui-data.c (_locator): Add argument to constructor.
 248         (source_win, disasm_win): New globals.
 249         (exec_info): Remove.
 250         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 251         Update.
 252         (tui_alloc_generic_win_info): Remove.
 253         (init_content_element): Use new.
 254         (tui_win_info::tui_win_info): Update.
 255         (free_content_elements) <case DATA_WIN>: Use delete.
 256
 257 2019-06-25  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 260         * tui/tui-windata.c (tui_first_data_item_displayed)
 261         (tui_delete_data_content_windows): Update.
 262         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 263         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 264         (tui_display_registers_from, tui_check_register_values): Update.
 265         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 266         pointer.
 267         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 268         window.
 269         (tui_free_data_content): Update.
 270         (free_content_elements) <case DATA_WIN>: Free the window.
 271
 272 2019-06-25  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 275         Update.
 276         * tui/tui-layout.c (make_command_window)
 277         (show_source_disasm_command, show_data, init_and_make_win)
 278         (show_source_or_disasm_and_command): Update.
 279         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 280         method.
 281         <can_highight, is_highlighted>: Now bool.
 282         (tui_set_win_highlight): Don't declare.
 283         * tui/tui-data.c (tui_set_win_highlight): Remove.
 284
 285 2019-06-25  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-wingeneral.c (make_visible): Remove check of window
 288         type.
 289
 290 2019-06-25  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-win.c (tui_win_info::max_height)
 293         (tui_cmd_window::max_height): New methods.
 294         (new_height_ok): Call max_height.
 295         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 296         <max_height>: New method.
 297
 298 2019-06-25  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-win.c (tui_source_window_base::set_new_height)
 301         (tui_data_window::set_new_height): New methods.
 302         (make_invisible_and_set_new_height): Call set_new_height method.
 303         * tui/tui-data.h (struct tui_win_info)
 304         (struct tui_source_window_base, struct tui_data_window)
 305         <set_new_height>: New method.
 306
 307 2019-06-25  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 310         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 311         tui_refresh_data_win.
 312         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 313         method.
 314         (tui_refresh_all_win): Call the refresh_all method.
 315         (tui_set_focus): Likewise.
 316         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 317         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 318         Likewise.
 319
 320 2019-06-25  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-winsource.h (tui_refill_source_window)
 323         (tui_set_is_exec_point_at): Don't declare.
 324         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 325         (tui_source_window_base::refill): Rename from
 326         tui_refill_source_window.
 327         (tui_source_window_base::do_scroll_horizontal): Update.
 328         (tui_source_window_base::set_is_exec_point_at): Rename from
 329         tui_set_is_exec_point_at.
 330         (tui_update_all_breakpoint_info): Update.
 331         * tui/tui-stack.c (tui_show_frame_info): Update.
 332         * tui/tui-layout.c (show_data): Add cast.
 333         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 334         * tui/tui-data.h (struct tui_source_window_base) <refill,
 335         set_is_exec_point_at>: New methods.
 336         (tui_source_windows, tui_add_to_source_windows): Update types.
 337         (tui_add_to_source_windows): Remove redundant declaration.
 338         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 339         (tui_source_windows): Change return type.
 340         (tui_clear_source_windows_detail): Update.
 341         (tui_add_to_source_windows): Change type of parameter.
 342         (tui_free_all_source_wins_content): Update.
 343
 344 2019-06-25  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-wingeneral.c (tui_win_info::refresh)
 347         (tui_source_window_base::refresh): New methods.
 348         (tui_refresh_all): Call the refresh method.
 349         * tui/tui-data.h (struct tui_win_info)
 350         (struct tui_source_window_base) <refresh>: New method.
 351
 352 2019-06-25  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui.h (tui_is_window_visible): Return bool.
 355         * tui/tui.c (tui_is_window_visible): Return bool.
 356         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 357         (tui_make_visible, tui_make_invisible)
 358         (tui_win_info::make_visible)
 359         (tui_source_window_base::make_visible, make_all_visible)
 360         (tui_make_all_visible, tui_make_all_invisible): Update.
 361         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 362         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 363         bool.
 364         (struct tui_win_info, struct tui_source_window_base)
 365         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 366         * tui/tui-data.c (tui_init_generic_part): Update.
 367
 368 2019-06-25  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 371         (tui_source_window_base::make_visible): New methods.
 372         (make_all_visible): Make method call.
 373         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 374         (struct tui_source_window_base, struct tui_cmd_window): Override
 375         make_visible.
 376         (tui_win_is_source_type): Don't declare.
 377         * tui/tui-data.c (tui_win_is_source_type): Remove.
 378
 379 2019-06-25  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 382         NULL check.
 383
 384 2019-06-25  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 387         Inline constructor.  Add initializers for members.
 388         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 389         constructors; now inline in class.
 390
 391 2019-06-25  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-regs.c (tui_show_registers): Update.
 394         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 395         bool.
 396         * tui/tui-data.c (tui_data_window::clear_detail)
 397         (tui_data_window): Update.
 398
 399 2019-06-25  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-windata.c (tui_display_all_data)
 402         (tui_display_data_from_line, tui_display_data_from)
 403         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 404         Update.
 405         * tui/tui-regs.c (tui_last_regs_line_no)
 406         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 407         (tui_show_registers, tui_show_register_group)
 408         (tui_display_registers_from, tui_display_reg_element_at_line)
 409         (tui_display_registers_from_line, tui_check_register_values)
 410         (tui_reg_next, tui_reg_prev): Update.
 411         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 412         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 413         tui_data_window.
 414         (struct tui_win_info) <detail>: Remove.  Add new fields from
 415         tui_data_info.
 416         (TUI_DATA_WIN): Add cast.
 417         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 418         (~tui_data_window): Simplify.
 419
 420 2019-06-25  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-layout.c (show_source_disasm_command)
 423         (show_source_or_disasm_and_command): Update.
 424         * tui/tui-io.c (update_cmdwin_start_line)
 425         (tui_redisplay_readline): Update.
 426         * tui/tui-data.h (struct tui_command_info): Remove.
 427         (struct tui_win_info) <detail>: Remove command_info member.
 428         (struct tui_data_window) <start_line>: New member, from
 429         tui_command_info.
 430         (TUI_CMD_WIN): Add casts.
 431
 432 2019-06-25  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-winsource.c (tui_update_source_window)
 435         (tui_refill_source_window)
 436         (tui_source_window_base::do_scroll_horizontal)
 437         (tui_update_breakpoint_info, tui_set_exec_info_content)
 438         (tui_show_exec_info_content, tui_erase_exec_info_content)
 439         (tui_clear_exec_info_content): Update.
 440         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 441         Update.
 442         * tui/tui-win.c (make_invisible_and_set_new_height)
 443         (make_visible_with_new_height): Update.
 444         * tui/tui-source.c (tui_set_source_content)
 445         (tui_show_symtab_source): Update.
 446         * tui/tui-layout.c (extract_display_start_addr)
 447         (show_source_disasm_command, show_data)
 448         (make_source_or_disasm_window)
 449         (show_source_or_disasm_and_command): Update.
 450         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 451         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 452         "gdbarch".
 453         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 454         to tui_source_window_base.
 455         (struct tui_win_info) <detail>: Remove source_info member.
 456         (struct tui_source_window_base) <has_locator>: Inline.
 457         Move contents from tui_source_info; rename has_locator member to
 458         m_has_locator.
 459         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 460         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 461         header file.
 462         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 463         Simplify.
 464         (tui_free_all_source_wins_content): Cast to
 465         tui_source_window_base.
 466
 467 2019-06-25  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-win.c (make_invisible_and_set_new_height)
 470         (make_visible_with_new_height): Call has_locator method.
 471         * tui/tui-layout.c (show_source_disasm_command, show_data)
 472         (show_source_or_disasm_and_command): Update for bool change.
 473         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 474         (tui_win_info) <has_locator>: New method.
 475         (struct tui_source_window_base) <has_locator>: New method.
 476         (tui_win_has_locator): Don't declare.
 477         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 478         from tui_win_has_locator.
 479         (tui_source_window_base): Use false, not FALSE.
 480
 481 2019-06-25  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 484         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 485         clear_detail method directly.
 486         (tui_clear_win_detail): Remove.
 487
 488 2019-06-25  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 491         "this", not TUI_DISASM_WIN.
 492
 493 2019-06-25  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 496         declare.
 497         * tui/tui-winsource.c
 498         (tui_source_window_base::do_scroll_horizontal): Rename from
 499         tui_horizontal_source_scroll.
 500         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 501         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 502         from tui_vertical_data_scroll.
 503         * tui/tui-win.h (tui_scroll): Don't declare.
 504         * tui/tui-win.c (tui_win_info::forward_scroll)
 505         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 506         (tui_win_info::right_scroll): Rename and update.
 507         (tui_scroll_forward_command, tui_scroll_backward_command)
 508         (tui_scroll_left_command, tui_scroll_right_command): Update.
 509         (tui_scroll): Remove.
 510         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 511         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 512         from tui_vertical_source_scroll.
 513         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 514         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 515         from tui_vertical_disassem_scroll.
 516         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 517         do_scroll_horizontal>: New methods.
 518         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 519         Likewise.
 520         (struct tui_source_window_base): Add do_scroll_horizontal.
 521         (struct tui_source_window, struct tui_disasm_window): Add
 522         do_scroll_vertical.
 523         (struct tui_data_window, struct tui_cmd_window): Add
 524         do_scroll_horizontal and do_scroll_vertical.
 525         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 526
 527 2019-06-25  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-data.h (struct tui_source_window_base): New struct.
 530         (struct tui_source_window): Derive from tui_source_window_base.
 531         (struct tui_disasm_window): New struct.
 532         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 533         from tui_source_window::clear_detail.
 534         (tui_source_window_base): Rename from tui_source_window.
 535         (~tui_source_window_base): Rename from ~tui_source_window.
 536         (tui_alloc_win_info): Create a tui_disasm_window.
 537
 538 2019-06-25  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-data.h (struct tui_source_window)
 541         (struct tui_data_window): Declare destructors.
 542         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 543         destructors.
 544         (tui_win_info): Simplify.
 545
 546 2019-06-25  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-winsource.c (tui_display_main)
 549         (tui_update_source_windows_with_addr)
 550         (tui_update_all_breakpoint_info): Update.
 551         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 552         (new_height_ok, parse_scrolling_args): Update.
 553         * tui/tui-stack.c (tui_show_frame_info): Update.
 554         * tui/tui-data.h (struct tui_list): Remove.
 555         (tui_source_windows): Return a reference to a std::vector.
 556         * tui/tui-data.c (source_windows): Now a std::vector.
 557         (tui_source_windows): Change return type.
 558         (tui_clear_source_windows): Rewrite.
 559         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 560         (tui_free_all_source_wins_content): Rewrite.
 561
 562 2019-06-25  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 565         (struct tui_data_window, struct tui_cmd_window): Declare
 566         clear_detail method.
 567         * tui/tui-data.c (tui_source_window::clear_detail)
 568         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 569         methods.
 570         (tui_clear_win_detail): Simplify.
 571
 572 2019-06-25  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-layout.c (make_source_window, make_disasm_window)
 575         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 576         Return the new window.
 577         (show_source_disasm_command, show_data)
 578         (show_source_or_disasm_and_command): Update.
 579
 580 2019-06-25  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 583         parameter.  Return the new window.
 584         (show_source_disasm_command): Update and remove NULL check.
 585         (show_source_or_disasm_and_command): Update.
 586
 587 2019-06-25  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 590
 591 2019-06-25  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-data.h (struct tui_win_info): Make constructor
 594         protected.  Make destructor virtual.  Add initializers.
 595         (tui_source_window, tui_data_window, tui_cmd_window): New
 596         classes.
 597         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 598         constructor.  Add "type" parameter.
 599         (tui_source_window, tui_data_window, tui_cmd_window): New
 600         constructors.
 601         (tui_alloc_win_info): Instantiate the appropriate subclass.
 602
 603 2019-06-25  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-win.c (tui_resize_all): Use delete.
 606         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 607         destructor.
 608         (tui_free_window): Don't declare.
 609         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 610         Update.
 611
 612 2019-06-25  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-data.h (struct tui_win_info): Add constructor.
 615         * tui/tui-data.c (tui_alloc_win_info): Use new.
 616         (tui_free_window): Use delete.
 617
 618 2019-06-22  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 621         declare.
 622         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 623
 624 2019-06-22  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 627         declare.
 628         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 629
 630 2019-06-22  Tom de Vries  <tdevries@suse.de>
 631
 632         * dwarf2read.c (create_addrmap_from_aranges)
 633         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 634         instead of '%zu'.
 635
 636 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 637
 638         * dwarf2read.h (dwarf2_section_info_def): Remove.
 639         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 640         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 641         std::vector<dwarf2_section_info>.
 642         (struct dwo_file) <~dwo_file>: Remove.
 643         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 644         types field.
 645         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 646         (dwarf2_read_debug_names): Likewise.
 647         (create_debug_types_hash_table): Change parameter type to
 648         array_view, adjust code accordingly.
 649         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 650         (partial_die_info::fixup): Likewise.
 651         (determine_prefix): Likewise.
 652         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 653
 654 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 655
 656         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 657         gdb_bfd_ref_ptr.
 658         <~dwo_file>: Remove call to gdb_bfd_unref.
 659         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 660         gdb_bfd_ref_ptr::get.
 661
 662 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 663
 664         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 665         type to htab_up.
 666         * dwarf2read.c (struct dwo_file): Initialize fields.
 667         <~dwo_file>: New.
 668         (free_dwo_file): Remove, move content to ~dwo_file.
 669         (struct dwo_file_deleter): Remove.
 670         (dwo_file_up>: Remove custom deleter.
 671         (free_dwo_files): Remove.
 672         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 673         dwo_files.
 674         (process_skeletonless_type_units): Call unique_ptr::get.
 675         (allocate_dwo_file_hash_table): Add deleter to created hash
 676         table.  Change return type to htab_up.
 677         (lookup_dwo_file_slot): Don't memset dwo_file, call
 678         unique_ptr::get.
 679         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 680         (create_dwo_unit_in_dwp_v2): Likewise.
 681         (open_and_init_dwo_file): Likewise.
 682         (free_dwo_file_from_slot): Remove.
 683
 684 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 685
 686         * dwarf2read.h (struct dwarf2_section_info) <readin,
 687         is_virtual>: Change type to bool.
 688         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 689         true instead of 1.
 690
 691 2019-06-19  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-data.h (tui_init_content_element): Don't declare.
 694
 695 2019-06-19  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-data.h (tui_init_win_info): Don't declare.
 698
 699 2019-06-19  Tom de Vries  <tdevries@suse.de>
 700
 701         * dwarf2read.h (abstract_to_concrete): Change type to
 702         std::unordered_map<sect_offset, std::vector<sect_offset>,
 703         gdb::hash_enum<sect_offset>>.
 704
 705 2019-06-19  Tom Tromey  <tromey@adacore.com>
 706
 707         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 708         EVAL_AVOID_SIDE_EFFECTS specially.
 709
 710 2019-06-19  Tom Tromey  <tromey@adacore.com>
 711
 712         * source-cache.c (highlighter): New global.
 713         (source_cache::get_source_lines): Create a highlighter on demand.
 714
 715 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 716
 717         * defs.h (deprecated_interactive_hook): Delete declaration.
 718         * interps.c (clear_interpreter_hooks): Remove use of
 719         deprecated_interactive_hook.
 720         * top.c (deprecated_interactive_hook): Delete definition.
 721         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 722
 723 2019-06-18  Tom de Vries  <tdevries@suse.de>
 724
 725         PR gdb/24515
 726         * dwarf2read.h (abstract_to_concrete): Change type from
 727         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 728         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 729         * dwarf2read.c (read_variable): Update.
 730         (dwarf2_fetch_die_loc_sect_off): Update.
 731
 732 2019-06-17  Tom de Vries  <tdevries@suse.de>
 733
 734         PR gdb/24617
 735         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 736         accessing parent[parent_len - 1].
 737
 738 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 739
 740         PR gdb/24364
 741         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 742         call dtrace_process_dof with NULL dof.
 743
 744 2019-06-16  Tom de Vries  <tdevries@suse.de>
 745
 746         PR gdb/24445
 747         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 748
 749 2019-06-16  Tom Tromey  <tom@tromey.com>
 750
 751         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 752         (make_all_visible): Use address of member.
 753
 754 2019-06-16  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 757         (tui_free_window, free_content, free_content_elements): Remove
 758         unnecessary cast.
 759         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 760         cast.
 761         * tui/tui-regs.c (tui_show_register_group)
 762         (tui_display_registers_from, tui_display_reg_element_at_line):
 763         Remove unnecessary cast.
 764
 765 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 766
 767         * linux-nat.c (normal_mask): Delete.
 768         (_initialize_linux_nat): Don't initialise normal_mask.
 769
 770 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 771
 772         PR gdb/24445
 773         * dwarf-index-write.h (write_psymtabs_to_index): Add
 774         dwz_basename parameter.
 775         * dwarf-index-write.c (write_gdbindex): Move file writing to
 776         write_gdbindex_1.  Change return type void.
 777         (assert_file_size): Move up, remove filename parameter.
 778         (write_gdbindex_1): New function.
 779         (write_debug_names): Change return type to void, call
 780         assert_file_size.
 781         (struct index_wip_file): New struct.
 782         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 783         file logic to index_wip_file.  Write index for dwz file if
 784         needed.
 785         (save_gdb_index_command): Pass basename of dwz file, if present.
 786         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 787         build-id of dwz file, if present.
 788         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 789         (dwarf2_get_dwz_file): Likewise.
 790         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 791         (dwarf2_get_dwz_file): Likewise.
 792
 793 2019-06-16  Tom Tromey  <tom@tromey.com>
 794
 795         * coffread.c (process_coff_symbol): Use xstrdup.
 796         * value.c (create_internalvar): Use xstrdup.
 797
 798 2019-06-16  Tom Tromey  <tom@tromey.com>
 799
 800         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 801         * breakpoint.c (stopin_command, stopat_command)
 802         (until_break_command, decode_location_default): Remove unnecessary
 803         cast.
 804         * utils.c (subset_compare): Remove unnecessary cast.
 805         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 806         cast.
 807         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 808         cast.
 809         * infcmd.c (path_command): Remove unnecessary cast.
 810         * coffread.c (decode_type): Remove unnecessary cast.
 811         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 812         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 813         * tui/tui-stack.c (tui_show_locator_content)
 814         (tui_show_frame_info): Remove unnecessary cast.
 815         * tui/tui-win.c (tui_scroll_forward_command)
 816         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 817         (parse_scrolling_args): Remove unnecessary cast.
 818         * tui/tui-data.c (init_win_info, tui_del_window)
 819         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 820         (free_content_elements): Remove unnecessary cast.
 821         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 822         unnecessary cast.
 823         * tui/tui-source.c (tui_set_source_content)
 824         (tui_vertical_source_scroll): Remove unnecessary cast.
 825         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 826         cast.
 827         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 828         * tui/tui-regs.c (tui_display_registers_from)
 829         (tui_display_register): Remove unnecessary cast.
 830         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 831         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 832         (make_visible): Remove unnecessary cast.
 833         * tui/tui-winsource.c (tui_erase_source_content)
 834         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 835         unnecessary cast.
 836         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 837         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 838         * stabsread.c (read_type, read_array_type, read_range_type):
 839         Remove unnecessary cast.
 840         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 841         (parse_symbol, parse_type, upgrade_type, parse_external)
 842         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 843         unnecessary cast.
 844         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 845
 846 2019-06-16  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-data.c (tui_alloc_generic_win_info)
 849         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 850         checks.
 851
 852 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 853             Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * f-typeprint.c (f_print_type): Don't return early for not
 856         associated or not allocated types.
 857         (f_type_print_varspec_suffix): Add print_rank parameter and print
 858         ranks of array types in case they dangling.
 859         (f_type_print_base): Add print_rank parameter.
 860
 861 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 862
 863         * NEWS: Mention new MI commands.
 864         * break-catch-throw.c (enum exception_event_kind): Move to
 865         breakpoint.h.
 866         (print_mention_exception_catchpoint): Output text as a single
 867         message.
 868         (catch_exception_command_1): Rename to...
 869         (catch_exception_event): ...this, make non-static, update header
 870         command, and change some parameter types.
 871         (catch_catch_command): Update for changes to
 872         catch_exception_command_1.
 873         (catch_throw_command): Likewise.
 874         (catch_rethrow_command): Likewise.
 875         * breakpoint.c (enum exception_event_kind): Delete.
 876         * breakpoint.h (enum exception_event_kind): Moved here from
 877         break-catch-throw.c.
 878         (catch_exception_event): Declare.
 879         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 880         (mi_cmd_catch_throw): New function.
 881         (mi_cmd_catch_rethrow): New function.
 882         (mi_cmd_catch_catch): New function.
 883         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 884         'catch-catch' entries.
 885         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 886         (mi_cmd_catch_rethrow): Declare.
 887         (mi_cmd_catch_catch): Declare.
 888
 889 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 890
 891         * annotate.c (annotate_source_line): Change return type to void,
 892         update implementation to match.
 893         * annotate.h (annotate_source_line): Change return type to void,
 894         update header comment.
 895         * stack.c (print_frame_info): Don't change what frame information
 896         is printed based on whether annotations are on or not.
 897
 898 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 901         (annotate_source): Make static.
 902         (annotate_source_line): Moved from source.c and renamed from
 903         identify_source_line.  Update the return type.
 904         * annotate.h (annotate_source): Delete declaration.
 905         (annotate_source_line): Declaration moved from source.h, and
 906         renamed from identify_source_line.  Return type updated.
 907         * source.c (identify_source_line): Moved to annotate.c and renamed
 908         to annotate_source_line.
 909         (info_line_command): Remove check of annotation_level.
 910         * source.h (identify_source_line): Move declaration to annotate.h
 911         and rename to annotate_source_line.
 912         * stack.c: Add 'annotate.h' include.
 913         (print_frame_info): Remove check of annotation_level before
 914         calling annotate_source_line.
 915
 916 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * source-cache.c (source_cache::get_plain_source_lines): Use
 919         open_source_file_with_line_charpos instead of just
 920         open_source_file, remove call to find_source_lines.
 921         (source_cache::get_source_lines): Likewise.
 922         * source.c (find_source_lines): Make static.
 923         (get_filename_and_charpos): Renamed into...
 924         (open_source_file_with_line_charpos): ..this along with changes to
 925         return a scoped_fd, and some other minor clean ups.
 926         (identify_source_line): Use open_source_file_with_line_charpos.
 927         (search_command_helper): Use open_source_file_with_line_charpos
 928         instead of just open_source_file, remove call to
 929         find_source_lines.
 930         * source.h (open_source_file_with_line_charpos): Declare new
 931         function.
 932         (find_source_lines): Delete declaration.
 933
 934 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * source.c (get_filename_and_charpos): Remove fullname
 937         parameter.
 938         (identify_source_line): Update call to get_filename_and_charpos.
 939
 940 2019-06-14  Tom Tromey  <tromey@adacore.com>
 941
 942         PR gdb/24502:
 943         * ui-style.h (skip_ansi_escape): Update comment.
 944         * ui-file.h (class no_terminal_escape_file): New class.
 945         * ui-file.c (no_terminal_escape_file::write)
 946         (no_terminal_escape_file::puts): New methods.
 947         * cli/cli-logging.c (handle_redirections): Use
 948         no_terminal_escape_file.
 949
 950 2019-06-14  Tom Tromey  <tromey@adacore.com>
 951
 952         * NEWS: Move convenience variable news above Python news.
 953
 954 2019-06-14  Tom Tromey  <tom@tromey.com>
 955
 956         * gnulib: Move directory to top-level.
 957         * configure.ac: Don't configure gnulib.
 958         * configure: Rebuild.
 959         * common/common-defs.h: Use new path to gnulib.
 960         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 961         (GNULIB_H): Remove.
 962         (INCGNU): Look in new gnulib location.
 963         (HFILES_NO_SRCDIR): Remove gnulib files.
 964         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 965         (generated_files): Remove GNULIB_H.
 966         ($(LIBGNU), all-lib): Remove targets.
 967         (distclean): Don't mention GNULIB_BUILDDIR.
 968         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 969
 970 2019-06-14  Tom Tromey  <tromey@adacore.com>
 971
 972         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 973         Warn if symbol file does not provide any symbols.
 974
 975 2019-06-14  Tom Tromey  <tromey@adacore.com>
 976
 977         * source.c (find_and_open_source): Respect basenames_may_differ.
 978
 979 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * annotate.c (annotate_breakpoints_invalid): Make use of
 982         scoped_restore_terminal_state.
 983         (annotate_frames_invalid): Likewise.
 984
 985 2019-06-14  Tom Tromey  <tromey@adacore.com>
 986
 987         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 988         allow assignment to an internalvar.
 989
 990 2019-06-14  Tom Tromey  <tromey@adacore.com>
 991
 992         * ada-lex.l: Allow "_" in attribute names.
 993
 994 2019-06-14  Tom Tromey  <tromey@adacore.com>
 995
 996         PR gdb/24653:
 997         * regcache.c (registers_changed): Don't call alloca.
 998         * top.c (execute_command): Don't call alloca.
 999
1000 2019-06-13  Pedro Alves  <palves@redhat.com>
1001
1002         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1003         'expression'.  When parsing an expression, error out if there's
1004         junk after "unlimited".
1005         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1006         (do_set_command): Adjust calls to is_unlimited_literal.
1007
1008 2019-06-13  Pedro Alves  <palves@redhat.com>
1009
1010         * compile/compile.c (make_compile_options_def_group): Add braces
1011         around array_view initializer.
1012         * thread.c (make_thread_apply_all_options_def_group)
1013         (make_thread_apply_all_options_def_group): Likewise.
1014
1015 2019-06-13  Pedro Alves  <palves@redhat.com>
1016
1017         * NEWS (New commands): Mention "maint test-options
1018         require-delimiter", "maint test-options unknown-is-error", "maint
1019         test-options unknown-is-operand" and "maint show
1020         test-options-completion-result".
1021         (New command options, command completion): New section.
1022         (Completion improvements): New section.
1023         Mention that you can abbreviate "unlimited".
1024
1025 2019-06-13  Pedro Alves  <palves@redhat.com>
1026
1027         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1028         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1029         * unittests/cli-utils-selftests.c (test_parse_flags)
1030         (test_parse_flags_qcs): Delete.
1031         (test_cli_utils): Don't call deleted functions.
1032
1033 2019-06-13  Pedro Alves  <palves@redhat.com>
1034
1035         * thread.c: Include "cli/cli-option.h".
1036         (tp_array_compar_ascending): Global.
1037         (tp_array_compar): Delete function.
1038         (tp_array_compar_ascending, tp_array_compar_descending): New
1039         functions.
1040         (ascending_option_def, qcs_flag_option_def)
1041         (thr_qcs_flags_option_defs)
1042         (make_thread_apply_all_options_def_group)
1043         (make_thread_apply_options_def_group): New.
1044         (thread_apply_all_command): Use gdb::option::process_options.
1045         (thread_apply_command_completer)
1046         (thread_apply_all_command_completer): New.
1047         (thread_apply_command): Use gdb::option::process_options.
1048         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1049         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1050         to generate help text of "thread apply".  Adjust "taas"'s help.
1051         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1052         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1053
1054 2019-06-13  Pedro Alves  <palves@redhat.com>
1055
1056         * thread.c (thread_apply_command): Check for invalid TID with
1057         isdigit instead of !isalpha.
1058
1059 2019-06-13  Pedro Alves  <palves@redhat.com>
1060
1061         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1062         (validate_flags_qcs): New.
1063         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1064         (validate_flags_qcs): Declare.
1065         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1066         (make_frame_apply_options_def_group): New.
1067         (frame_apply_command_count): Process options with
1068         gdb::option::process_options.
1069         (frame_apply_completer): New.
1070         (frame_apply_level_completer, frame_apply_all_completer)
1071         (frame_apply_completer): New.
1072         (_initialize_stack): Update help of "frame apply", "frame apply
1073         level", "frame apply all" and "faas" to mention supported options
1074         and install command completers.
1075         * stack.h (frame_apply_all_completer): Declare.
1076         * thread.c: Include "stack.h".
1077         (tfaas_command): Add "--".
1078         (_initialize_thread): Update help "tfaas" to mention supported
1079         options and install command completer.
1080
1081 2019-06-13  Pedro Alves  <palves@redhat.com>
1082
1083         * completer.c (complete_nested_command_line): New.
1084         (gdb_completion_word_break_characters_throw): Add assertion.
1085         * completer.h (complete_nested_command_line): Declare.
1086
1087 2019-06-13  Pedro Alves  <palves@redhat.com>
1088
1089         * stack.c (parse_backtrace_qualifiers): New.
1090         (backtrace_command): Use it.
1091         (backtrace_command_completer): Complete on qualifiers.
1092
1093 2019-06-13  Pedro Alves  <palves@redhat.com>
1094
1095         * frame.c: Include "cli/cli-option.h.
1096         (user_set_backtrace_options): New.
1097         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1098         Delete.
1099         (get_prev_frame): Adjust.
1100         (boolean_option_def, uinteger_option_def)
1101         (set_backtrace_option_defs): New.
1102         (_initialize_frame): Adjust and use
1103         gdb::option::add_setshow_cmds_for_options to install "set
1104         backtrace past-main" and "set backtrace past-entry".
1105         * frame.h: Include "cli/cli-option.h".
1106         (struct frame_print_options): Forward declare.
1107         (print_frame_arguments_all, print_frame_arguments_scalars)
1108         (print_frame_arguments_none): Declare.
1109         (print_entry_values): Delete declaration.
1110         (struct frame_print_options, user_frame_print_options): New.
1111         (struct set_backtrace_options): New.
1112         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1113         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1114         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1115         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1116         (list_args_or_locals): Add frame_print_options parameter.
1117         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1118         * python/py-framefilter.c (enumerate_args): Pass down
1119         USER_FRAME_PRINT_OPTIONS.
1120         * stack.c: Include "cli/cli-option.h".
1121         (print_frame_arguments_all, print_frame_arguments_scalars)
1122         (print_frame_arguments_none): Declare.
1123         (print_raw_frame_arguments, print_entry_values): Delete.
1124         (user_frame_print_options): New.
1125         (boolean_option_def, enum_option_def, frame_print_option_defs):
1126         New.
1127         (struct backtrace_cmd_options): New.
1128         (bt_flag_option_def): New.
1129         (backtrace_command_option_defs): New.
1130         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1131         (print_frame_arg, read_frame_arg, print_frame_args)
1132         (print_frame_info, print_frame): Add frame_print_options parameter
1133         and use it.
1134         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1135         (backtrace_command_1): Add frame_print_options and
1136         backtrace_cmd_options parameters and use them.
1137         (make_backtrace_options_def_group): New.
1138         (backtrace_command): Process command options with
1139         gdb::option::process_options.
1140         (backtrace_command_completer): New.
1141         (_initialize_stack): Extend "backtrace"'s help to mention
1142         supported options.  Install completer for "backtrace".
1143         Install some settings commands with add_setshow_cmds_for_options.
1144
1145 2019-06-13  Pedro Alves  <palves@redhat.com>
1146
1147         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1148         and that "set/show print raw frame-arguments" are now deprecated.
1149
1150         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1151         command.
1152         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1153         * stack.c (_initialize_stack): Install "set/show print
1154         raw-frame-arguments", and deprecate "set/show print raw
1155         frame-arguments".
1156         * valprint.c (_initialize_valprint): Deprecate "set/show print
1157         raw".
1158
1159 2019-06-13  Pedro Alves  <palves@redhat.com>
1160
1161         * compile/compile.c (struct compile_options): New.
1162         (compile_flag_option_def, compile_command_option_defs)
1163         (make_compile_options_def_group): New.
1164         (compile_file_command): Handle options with
1165         gdb::option::process_options.
1166         (compile_file_command_completer): New function.
1167         (compile_code_command): Handle options with
1168         gdb::option::process_options.
1169         (compile_code_command_completer): New function.
1170         (_initialize_compiler): Install completers for "compile code" and
1171         "compile file".  Mention available options in "compile code" and
1172         "compile code"'s help.
1173         * completer.c (advance_to_completion_word): New, factored out from
1174         ...
1175         (advance_to_expression_complete_word_point): ... this.
1176         (advance_to_filename_complete_word_point): New.
1177         * completer.h (advance_to_filename_complete_word_point): New
1178         declaration.
1179
1180 2019-06-13  Pedro Alves  <palves@redhat.com>
1181
1182         * compile/compile.c: Include "cli/cli-option.h".
1183         (compile_print_value): Scope data pointer is now a
1184         value_print_options pointer; adjust.
1185         (compile_print_command): Process options.  Scope data pointer is
1186         now a value_print_options pointer; adjust.
1187         (_initialize_compile): Update "compile print"'s help to include
1188         supported options.  Install a completer for "compile print".
1189         * cp-valprint.c (show_vtblprint, show_objectprint)
1190         (show_static_field_print): Delete.
1191         (_initialize_cp_valprint): Don't install "set print
1192         static-members", "set print vtbl", "set print object" here.
1193         * printcmd.c: Include "cli/cli-option.h" and
1194         "common/gdb_optional.h".
1195         (print_command_parse_format): Rework to fill in a
1196         value_print_options instead of a format_data.
1197         (print_value): Change parameter type from format_data pointer to
1198         value_print_options reference.  Adjust.
1199         (print_command_1): Process options.  Adjust to pass down a
1200         value_print_options.
1201         (print_command_completer): New.
1202         (_initialize_printcmd): Install print_command_completer as
1203         handle_brkchars completer for the "print" command.  Update
1204         "print"'s help to include supported options.
1205         * valprint.c: Include "cli/cli-option.h".
1206         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1207         here from cp-valprint.c.
1208         (boolean_option_def, uinteger_option_def)
1209         (value_print_option_defs, make_value_print_options_def_group):
1210         New.  Use gdb::option::add_setshow_cmds_for_options to install
1211         "set print elements", "set print null-stop", "set print repeats",
1212         "set print pretty", "set print union", "set print array", "set
1213         print address", "set print symbol", "set print array-indexes".
1214         * valprint.h: Include <string> and "cli/cli-option.h".
1215         (make_value_print_options_def_group): Declare.
1216         (print_value): Change parameter type from format_data pointer to
1217         value_print_options reference.
1218         (print_command_completer): Declare.
1219
1220 2019-06-13  Pedro Alves  <palves@redhat.com>
1221
1222         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1223         (COMMON_SFILES): Add maint-test-settings.c.
1224         * cli/cli-decode.c (boolean_enums): New global, factored out from
1225         ...
1226         (add_setshow_boolean_cmd): ... here.
1227         * cli/cli-decode.h (boolean_enums): Declare.
1228         * cli/cli-option.c: New file.
1229         * cli/cli-option.h: New file.
1230         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1231         factored out from ...
1232         (parse_cli_boolean_value(const char *)): ... this.
1233         (is_unlimited_literal): Change parameter type to pointer to
1234         pointer.  Adjust and advance ARG pointer.
1235         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1236         (parse_cli_var_enum): New, factored out from ...
1237         (do_set_command): ... this.  Adjust.
1238         * cli/cli-setshow.h (parse_cli_boolean_value)
1239         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1240         (parse_cli_var_enum): Declare.
1241         * cli/cli-utils.c: Include "cli/cli-option.h".
1242         (get_ulongest): New.
1243         * cli/cli-utils.h (get_ulongest): Declare.
1244         (check_for_argument): New overloads.
1245         * maint-test-options.c: New file.
1246
1247 2019-06-13  Pedro Alves  <palves@redhat.com>
1248
1249         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1250         parse a range if "-" is at the end of the string.
1251
1252 2019-06-13  Pedro Alves  <palves@redhat.com>
1253
1254         * cli/cli-setshow.c (parse_auto_binary_operation)
1255         (parse_cli_boolean_value): Don't allow "o".
1256
1257 2019-06-13  Pedro Alves  <palves@redhat.com>
1258
1259         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1260         * NEWS: Mention maint test-settings KIND.
1261         * maint-test-settings.c: New file.
1262
1263 2019-06-13  Pedro Alves  <palves@redhat.com>
1264
1265         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1266         completer.
1267         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1268         "set" completers.
1269
1270 2019-06-13  Pedro Alves  <palves@redhat.com>
1271
1272         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1273         after item.
1274
1275 2019-06-13  Pedro Alves  <palves@redhat.com>
1276
1277         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1278
1279 2019-06-13  Pedro Alves <palves@redhat.com>
1280
1281         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1282         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1283         call.
1284         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1285         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1286         calls.
1287         (check_for_argument): Skip spaces after argument.
1288
1289 2019-06-13  Pedro Alves  <palves@redhat.com>
1290
1291         * thread.c (thread_apply_command): Adjust TID parsing.
1292         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1293         detected before end of string.
1294         (tid_is_in_list): Error out if LIST is invalid.
1295
1296 2019-06-13  Pedro Alves  <palves@redhat.com>
1297
1298         * completer.c (complete_line_internal_1): Rewind completion word
1299         point.
1300         (completion_tracker::advance_custom_word_point_by): Change
1301         parameter type to int.
1302         * completer.h (completion_tracker::advance_custom_word_point_by):
1303         Likewise.
1304
1305 2019-06-13  Pedro Alves  <palves@redhat.com>
1306
1307         * completer.c (advance_to_completion_word): Handle delimiters.
1308
1309 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1310
1311         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1312
1313 2019-06-11  Tom Tromey  <tom@tromey.com>
1314
1315         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1316         (xmalloc_failed): Move to alloc.c.
1317         * alloc.c: New file.
1318         * Makefile.in (COMMON_SFILES): Add alloc.c.
1319
1320 2019-06-11  Tom Tromey  <tom@tromey.com>
1321
1322         * nat/linux-waitpid.c: Don't include server.h.
1323         (linux_debug): Remove.
1324         (my_waitpid): Update.
1325
1326 2019-06-11  Tom Tromey  <tromey@adacore.com>
1327
1328         * infcall.c (_initialize_infcall): Remove trailing newline from
1329         help.
1330         * user-regs.c (_initialize_user_regs): Remove trailing newline
1331         from help.
1332         * typeprint.c (_initialize_typeprint): Remove trailing newline
1333         from help.
1334         * reverse.c (_initialize_reverse): Remove trailing newlines from
1335         help.
1336         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1337         from help.
1338         * language.c (add_set_language_command): Remove trailing newline
1339         from help.
1340         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1341         help.
1342         * disasm.c (_initialize_disasm): Remove trailing newline from
1343         help.
1344         * top.c (init_main): Remove trailing newline from help.
1345         * interps.c (_initialize_interpreter): Remove trailing newline
1346         from help.
1347         * btrace.c (_initialize_btrace): Remove trailing newlines from
1348         help.
1349         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1350         from help.
1351         * python/python.c (_initialize_python): Remove trailing newline
1352         from help.
1353         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1354         help.
1355         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1356         from help.  Reformat some text.
1357         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1358         from help.
1359         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1360         newline from help.
1361
1362 2019-06-11  Tom Tromey  <tromey@adacore.com>
1363
1364         * darwin-nat.c (darwin_decode_exception_message)
1365         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1366
1367 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1368
1369         * valops.c (value_slice): Check for not allocated or not
1370         associated values.
1371
1372 2019-06-10  Tom de Vries  <tdevries@suse.de>
1373
1374         PR gdb/24618
1375         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1376         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1377         invalid.
1378
1379 2019-06-10  Tom de Vries  <tdevries@suse.de>
1380
1381         PR gdb/24611
1382         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1383         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1384
1385 2019-06-10  Tom de Vries  <tdevries@suse.de>
1386
1387         PR symtab/24545
1388         * symtab.c (struct demangled_name_entry): Add language field.
1389         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1390         static minimal symbol".  Set and use language field.
1391
1392 2019-06-10  Tom Tromey  <tromey@adacore.com>
1393
1394         * ada-lang.c (_initialize_ada_language): Update help text.
1395
1396 2019-06-10  Tom Tromey  <tromey@adacore.com>
1397
1398         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1399         with a newline.
1400         * guile/guile.c (handle_boot_error): Don't end warning with a
1401         newline.
1402         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1403         warning with a newline.
1404         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1405         newline.
1406         (s12z_frame_cache): Likewise.
1407         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1408         a newline.
1409         * solib-svr4.c (disable_probes_interface): Don't end warning with
1410         a newline.
1411         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1412         newline.
1413         * python/python.c (do_finish_initialization): Don't end warning
1414         with a newline.
1415
1416 2019-06-10  Tom Tromey  <tom@tromey.com>
1417
1418         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1419         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1420         gdbpy_enter.
1421
1422 2019-06-10  Tom Tromey  <tromey@adacore.com>
1423
1424         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1425         data.
1426         (elf_new_init): Don't call stabsread_new_init.
1427         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1428         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1429         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1430
1431 2019-06-10  Tom de Vries  <tdevries@suse.de>
1432
1433         PR symtab/16264
1434         PR symtab/24517
1435         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1436
1437 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1438
1439         * source.c (find_and_open_source): Also rewrite relative file
1440         names.
1441
1442 2019-04-26  Amos Bird  <amosbird@gmail.com>
1443
1444         * annotate.c (annotate_thread_exited): Add "thread-exited"
1445         annotation.
1446
1447 2019-06-06  Tom Tromey  <tromey@adacore.com>
1448
1449         * maint.h (class scoped_command_stats): Use
1450         DISABLE_COPY_AND_ASSIGN.
1451         <print_time>: New method.
1452         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1453         print_time.
1454         (scoped_command_stats::print_time): New method.
1455
1456 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1459         instructions of lengths 6 or 8 bytes.
1460
1461 2019-06-04  Pedro Alves  <palves@redhat.com>
1462
1463         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1464
1465         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1466         * breakpoint.c (condition_completer): Likewise.
1467         * cli/cli-dump.c (scan_expression): Likewise.
1468         * common/filestuff.c (mkdir_recursive): Likewise.
1469         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1470         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1471         (gdb_abspath): Likewise.
1472         * compile/compile-cplus-types.c
1473         (compile_cplus_instance::decl_name): Likewise.
1474         * completer.c (complete_explicit_location):
1475         (signal_completer, reg_or_group_completer_1): Likewise.
1476         * cp-support.c (cp_remove_params_if_any): Likewise.
1477         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1478         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1479         * infcmd.c (strip_bg_char): Likewise.
1480         * linespec.c (copy_token_string): Likewise.
1481         * mi/mi-main.c (output_cores): Likewise.
1482         * psymtab.c (psymtab_search_name):
1483         * symfile.c (test_set_ext_lang_command): Likewise.
1484         * target.c (target_fileio_read_stralloc): Likewise.
1485         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1486         * value.c (complete_internalvar): Likewise.
1487
1488 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1489
1490         Add objfile property to gdb.Type.
1491         * NEWS: Mention Python API addition.
1492         * python/py-type.c (typy_get_objfile): New method.
1493
1494 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1495
1496         * NEWS: Mention the new set|show style [title|highlight].
1497         Mention changes to "show style", "help" and "apropos".
1498
1499 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1500
1501         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1502         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1503         instead of print_help_for_command.
1504         (print_doc_of_command): New function.
1505         (help_list): Add 'apropos -v word' suggestion.
1506         (print_help_for_command): Style the command name using title style.
1507         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1508         (_initialize_cli_cmds): Describe -v in apropos_command help.
1509
1510 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1511
1512         * cli/cli-style.h (cli_style_option): Add name in constructor,
1513         add m_name class member, add constructor with intensity,
1514         add name class function.
1515         (cli_style_option::add_setshow_commands): Remove name argument.
1516         (highlight_style, title_style): New styles.
1517         * cli/cli-style.c (do_show): New function that shows a style
1518         characteristic styling the style name with itself.
1519         (set_style_name): New function.
1520         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1521         Update all callers according to the changes in cli/cli-style.h.
1522         * utils.h (fputs_highlighted): New function.
1523         * utils.c (fputs_highlighted): Likewise.
1524
1525 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1526
1527         * NEWS: Mention new pipe command and new convenience variables.
1528
1529 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1530
1531         * cli/cli-cmds.c (pipe_command): New function.
1532         (_initialize_cli_cmds): Call add_com for pipe_command.
1533         Define | as an alias for pipe.
1534         (exit_status_set_internal_vars): New function.
1535         (shell_escape): Call exit_status_set_internal_vars.
1536         cli/cli-decode.c (find_command_name_length): Recognize | as
1537         a single character command.
1538
1539 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1540
1541         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1542         top.c (execute_command_to_ui_file): New function, mostly a copy
1543         of execute_command_to_string.
1544         (execute_command_to_string): Implement by calling
1545         execute_command_to_ui_file.
1546
1547 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1548
1549         * top.h (saved_command_line): Remove declaration.
1550         * top.c (previous_saved_command_line, previous_repeat_arguments):
1551         New variables.
1552         (saved_command_line): Make static, define together with other
1553         'repeat variables'.
1554         (dont_repeat): Clear repeat_arguments.
1555         (repeat_previous, get_saved_command_line, save_command_line):
1556         New functions.
1557         (gdb_init): Initialize saved_command_line
1558         and previous_saved_command_line.
1559         * main.c (captured_main_1): Remove saved_command_line initialization.
1560         * event-top.c (handle_line_of_input): Update to use
1561         the new 'repeat' related functions instead of direct access to
1562         saved_command_line.
1563         * command.h (repeat_previous, get_saved_command_line,
1564         save_command_line): New declarations.
1565         (dont_repeat): Add comment.
1566
1567 2019-05-30  Tom Tromey  <tromey@adacore.com>
1568
1569         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1570         Fix comment.
1571         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1572
1573 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1574
1575         PR cli/24587
1576         * completer.c (complete): Initialize variable word.
1577
1578 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1579
1580         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1581         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1582         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1583         'body' is NULL to the outter 'if', protecting the '!is_define'
1584         situation as well.
1585
1586 2019-05-29  Tom Tromey  <tromey@adacore.com>
1587
1588         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1589         (dwarf_unknown): New function.
1590         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1591         (dwarf_type_encoding_name): Use dwarf_unknown.
1592
1593 2019-05-29  Tom Tromey  <tromey@adacore.com>
1594
1595         PR c++/20020:
1596         * cp-valprint.c (cp_print_value_fields): Call
1597         cp_print_static_field inside "try".
1598
1599 2019-05-29  Tom Tromey  <tromey@adacore.com>
1600
1601         * inflow.c (struct terminal_info): Add default operator=.
1602         * configure: Rebuild.
1603         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1604         -Wdeprecated-copy-dtor, -Wredundant-move.
1605
1606 2019-05-29  Tom Tromey  <tromey@adacore.com>
1607
1608         * NEWS: Add entry.
1609         * infcmd.c (print_return_value_1): Handle finish_print
1610         option.
1611         (show_print_finish): New function.
1612         (_initialize_infcmd): Add "set/show print finish" commands.
1613         * valprint.c (user_print_options): Initialize new member.
1614         * valprint.h (struct value_print_options) <finish_print>: New
1615         member.
1616
1617 2019-05-28  Tom Tromey  <tromey@adacore.com>
1618
1619         * ada-lang.c (ada_remove_Xbn_suffix)
1620         (find_old_style_renaming_symbol)
1621         (parse_old_style_renaming): Remove.
1622         (ada_find_renaming_symbol): Don't call
1623         find_old_style_renaming_symbol.
1624         (ada_is_renaming_symbol): Rename from
1625         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1626         bool.  Now static.
1627         (ada_read_var_value): Update and simplify.
1628         * ada-exp.y (write_var_or_type): Remove old code.
1629
1630 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1631
1632         * event-top.c: Remove include comment.
1633         * inflow.c (class scoped_ignore_sigttou): Move from here...
1634         * inflow.h (class scoped_ignore_sigttou): ...to here.
1635         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1636         * top.c:  Remove include comment.
1637
1638 2019-05-27  Tom Tromey  <tom@tromey.com>
1639
1640         * NEWS: Fix typo.
1641
1642 2019-05-22  Tom Tromey  <tromey@adacore.com>
1643
1644         * target.c (target_follow_exec): Constify parameter.
1645         * target-delegates.c: Rebuild.
1646         * remote.c (remote_target::follow_exec): Constify parameter.
1647         * infrun.c (follow_exec): Constify parameter.
1648         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1649         (target_follow_exec): Likewise.
1650
1651 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1652
1653         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1654         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1655
1656 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1657
1658         * NEWS: Add debugredirect and testsuite sections.
1659
1660 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1661
1662         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1663         target descriptions using exclusively floating point register name
1664         aliases.
1665
1666 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1667
1668         PR gdb/18644:
1669         * f-lang.c (build_fortran_types): Handle the case where
1670         gdbarch_floatformat_for_type returns a nullptr.
1671
1672 2019-05-21  Tom de Vries  <tdevries@suse.de>
1673
1674         PR cli/24587
1675         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1676
1677 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1678
1679         PR gdb/18644:
1680         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1681         16-byte floats.
1682         * i386-tdep.c (i386_floatformat_for_type): Use
1683         floatformats_ia64_quad for the 16-byte floating point component
1684         within a fortran 32-byte complex number.
1685
1686 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1687
1688         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1689         delete default constructor.
1690         (find_partial_die): Update to return const struct.
1691         (partial_die_parent_scope): Move variable declaration into scope
1692         of its use and change its type to auto.
1693         (guess_partial_die_structure_name): Likewise.
1694         (partial_die_info::fixup): Likewise.
1695
1696 2019-05-17  Tom Tromey  <tromey@adacore.com>
1697
1698         * source.c (find_and_open_source): Remove cast.
1699
1700 2019-05-17  Tom Tromey  <tromey@adacore.com>
1701
1702         * annotate.c (annotate_source): Make "filename" const.
1703         * annotate.h (annotate_source): Use const.
1704
1705 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1706
1707         * disasm.c (set_disassembler_options): Send errors to stderr.
1708
1709 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1710
1711         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1712         (cli_interp_base::set_logging): Check debug_redirect.
1713         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1714         * cli/cli-logging.c (debug_redirect): Add static variable.
1715         (pop_output_files): Add default param.
1716         (handle_redirections): Print debug setting.
1717         (show_logging_command): Likewise.
1718         (_initialize_cli_logging): Add debugredirect command.
1719         * interps.c (current_interp_set_logging): Add debug_redirect
1720         parameter.
1721         * interps.h (set_logging): Add debug_redirect parameter.
1722         (current_interp_set_logging): Likewise.
1723         * mi/mi-common.h: Likewise.
1724         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1725
1726 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1727             Tom Tromey  <tromey@adacore.com>
1728
1729         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1730         directly.
1731         * cli/cli-interp.h (make_logging_output): Remove declaration.
1732         * cli/cli-logging.c (make_logging_output): Remove function.
1733         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1734         directly.
1735         * ui-file.c (tee_file::tee_file): Remove bools.
1736         (tee_file::~tee_file): Remove deletes.
1737         * ui-file.h (tee_file): Remove bools.
1738
1739 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1740
1741         * mi/mi-cmds.h (mi_cmd_complete): New function.
1742         * mi/mi-main.c (mi_cmd_complete): Likewise.
1743         * mi/mi-cmds.c: Define new MI command -complete.
1744         * NEWS: Mention new -complete command.
1745
1746 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1747
1748         * completer.h (complete): New function.
1749         * completer.c (complete): Likewise.
1750         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1751         function defined in completer.h.
1752
1753 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1754
1755         * MAINTAINERS (Write After Approval): Add myself.
1756
1757 2019-05-17  Tom de Vries  <tdevries@suse.de>
1758
1759         PR gdb/24094
1760         * dwarf2read.c (struct cu_partial_die_info): New struct.
1761         (find_partial_die): Return cu_partial_die_info.
1762         (partial_die_parent_scope, guess_partial_die_structure_name)
1763         (partial_die_info::fixup): Handle new return type of find_partial_die.
1764
1765 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1766
1767         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1768         "std::string", simplifying the algorithm.
1769
1770 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1771
1772         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1773         (stap_static_probe_ops::get_probes): Likewise.
1774
1775 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1776
1777         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1778         '-')" and "else if".
1779         (stap_parse_single_operand): Join checks for
1780         "gdbarch_stap_parse_special_token_p" and
1781         "gdbarch_stap_parse_special_token" in the same "if" statement.
1782         Invert check when verifying for operation on register
1783         displacement.
1784
1785 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1786
1787         * stap-probe.c (stap_get_opcode): Update comment.
1788         (stap_get_expected_argument_type): Likewise.
1789         (handle_stap_probe): Likewise.
1790
1791 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1792
1793         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1794         return type to 'bool'.  Adjust comment.  Use 'bool' when
1795         appropriate.
1796         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1797         * stap-probe.c (stap_parse_argument_1): Likewise.
1798         (stap_is_operator): Likewise.
1799         (stap_is_generic_prefix): Likewise.
1800         (stap_is_register_prefix): Likewise.
1801         (stap_is_register_indirection_prefix): Likewise.
1802         (stap_is_integer_prefix): Likewise.
1803         (stap_generic_check_suffix): Likewise.
1804         (stap_check_integer_suffix): Likewise.
1805         (stap_check_register_suffix): Likewise.
1806         (stap_check_register_indirection_suffix): Likewise.
1807         (stap_parse_register_operand): Likewise.
1808         (stap_parse_single_operand): Likewise.
1809         (stap_parse_argument_1): Likewise.
1810         (stap_probe::get_argument_count): Likewise.
1811         (stap_is_operator): Likewise.
1812
1813 2019-05-16  Tom Tromey  <tromey@adacore.com>
1814
1815         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1816         keyword to foreach.
1817
1818 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1819
1820         * linux-thread-db.c (try_thread_db_load_1): Change return type
1821         to bool.
1822         (try_thread_db_load): Likewise.
1823         (try_thread_db_load_from_pdir_1): Likewise.
1824         (try_thread_db_load_from_pdir): Likewise.
1825         (try_thread_db_load_from_sdir): Likewise.
1826         (try_thread_db_load_from_dir): Likewise.
1827         (thread_db_load_search): Likewise.
1828         (has_libpthread): Likewise.
1829         (thread_db_load): Likewise.
1830
1831 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1832
1833         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1834         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1835         NULL, and complain/return if that's the case.
1836
1837 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1838
1839         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1840         (advance, posn, abstract_read_memory): New functions.
1841         [struct mem_read_abstraction]: New struct.
1842         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1843
1844 2019-05-14  Tom Tromey  <tromey@adacore.com>
1845
1846         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1847         value is not lval_memory.
1848
1849 2019-05-14  Tom Tromey  <tromey@adacore.com>
1850
1851         * solib.c (info_sharedlibrary_command): Style the file name.
1852
1853 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1854
1855         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1856         (aarch64_vnv_type): Likewise.
1857         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1858         * common/tdesc.c: Likewise.
1859         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1860         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1861         * features/aarch64-fpu.xml: Add ieee half view.
1862         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1863         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1864         * gdbtypes.h (struct builtin_type): Likewise.
1865         (struct objfile_type): Likewise.
1866
1867 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1868
1869         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1870         typo.
1871         * location.h (string_to_event_location): Likewise.
1872
1873 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1874
1875         GDB 8.3 released.
1876
1877 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1878
1879         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1880         New variable declaration.
1881         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1882         New variable.
1883         (print_one_breakpoint): Use ui_out::test_flags and new global
1884         variable to compute use_fixed_output.
1885         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1886         Remove.
1887         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1888         (mi_multi_location_breakpoint_output_fixed): Remove.
1889         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1890         new variable.
1891         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1892         fix_multi_location_breakpoint_output flag if version >= 3.
1893         * ui-out.h (enum ui_out_flag)
1894         <fix_multi_location_breakpoint_output>: New enumerator.
1895
1896 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1897
1898         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1899
1900 2019-05-10  Tom Tromey  <tromey@adacore.com>
1901
1902         * ada-lang.c (catch_ada_completer): New function.
1903         (_initialize_ada_language): Use it.
1904
1905 2019-05-10  Tom Tromey  <tromey@adacore.com>
1906
1907         * thread.c (print_thread_info): Make "requested_threads" const.
1908         * gdbthread.h (print_thread_info): Make "requested_threads"
1909         const.
1910         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1911         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1912
1913 2019-05-08  Tom Tromey  <tom@tromey.com>
1914
1915         * gdbtypes.c (objfile_type_data): Change type.
1916         (objfile_type, _initialize_gdbtypes): Update.
1917
1918 2019-05-08  Tom Tromey  <tom@tromey.com>
1919
1920         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1921         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1922         (_initialize_dwarf2_frame): Update.
1923
1924 2019-05-08  Tom Tromey  <tom@tromey.com>
1925
1926         * objc-lang.c (objc_objfile_data): Change type.
1927         (find_methods): Update.
1928         (_initialize_objc_lang): Remove.
1929
1930 2019-05-08  Tom Tromey  <tom@tromey.com>
1931
1932         * stabsread.c (rs6000_builtin_type_data): Change type.
1933         (rs6000_builtin_type, _initialize_stabsread): Update.
1934
1935 2019-05-08  Tom Tromey  <tom@tromey.com>
1936
1937         * mips-tdep.c (mips_pdr_data): Remove.
1938         (_initialize_mips_tdep): Update.
1939
1940 2019-05-08  Tom Tromey  <tom@tromey.com>
1941
1942         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1943         (hppa_init_objfile_priv_data, read_unwind_info)
1944         (find_unwind_entry, _initialize_hppa_tdep): Update.
1945
1946 2019-05-08  Tom Tromey  <tom@tromey.com>
1947
1948         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1949         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1950         on obstack.
1951         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1952
1953 2019-05-08  Tom Tromey  <tom@tromey.com>
1954
1955         * mdebugread.c (basic_type_data): Change type.
1956         (basic_type, _initialize_mdebugread): Update.
1957
1958 2019-05-08  Tom Tromey  <tom@tromey.com>
1959
1960         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1961
1962 2019-05-08  Tom Tromey  <tom@tromey.com>
1963
1964         * nto-tdep.c (nto_inferior_data_reg): Change type.
1965         (nto_inferior_data): Update.
1966         (nto_inferior_data_cleanup, nto_new_inferior_data)
1967         (_initialize_nto_tdep): Remove.
1968         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1969
1970 2019-05-08  Tom Tromey  <tom@tromey.com>
1971
1972         * ada-lang.c (struct ada_inferior_data): Add initializers.
1973         (ada_inferior_data): Change type.
1974         (ada_inferior_data_cleanup): Remove.
1975         (get_ada_inferior_data, ada_inferior_exit)
1976         (struct ada_pspace_data): Add initializers, destructor.
1977         (ada_pspace_data_handle): Change type.
1978         (get_ada_pspace_data): Update.
1979         (ada_pspace_data_cleanup): Remove.
1980
1981 2019-05-08  Tom Tromey  <tom@tromey.com>
1982
1983         * coffread.c (struct coff_symfile_info): Add initializers.
1984         (coff_objfile_data_key): Move lower.  Change type.
1985         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1986         Update.
1987         (coff_free_info): Remove.
1988
1989 2019-05-08  Tom Tromey  <tom@tromey.com>
1990
1991         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1992         (fbsd_pspace_data_handle): Move lower.  Change type.
1993         (get_fbsd_pspace_data): Update.
1994         (fbsd_pspace_data_cleanup): Remove.
1995         (_initialize_fbsd_tdep): Update.
1996
1997 2019-05-08  Tom Tromey  <tom@tromey.com>
1998
1999         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2000         (get_ada_tasks_pspace_data): Update.
2001         (ada_tasks_pspace_data_cleanup): Remove.
2002         (_initialize_tasks): Update.
2003         (ada_tasks_inferior_data_handle): Change type.
2004         (get_ada_tasks_inferior_data): Update.
2005         (ada_tasks_inferior_data_cleanup): Remove.
2006         (struct ada_tasks_pspace_data): Add initializers.
2007
2008 2019-05-08  Tom Tromey  <tom@tromey.com>
2009
2010         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2011         * symfile-debug.c (debug_sym_get_probes): Change type.
2012         * stap-probe.c (handle_stap_probe):
2013         (stap_static_probe_ops::get_probes): Change type.
2014         * probe.h (class static_probe_ops) <get_probes>: Change type.
2015         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2016         (parse_probes_in_pspace): Update.
2017         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2018         Update.
2019         (any_static_probe_ops::get_probes): Change type.
2020         * elfread.c (elfread_data): New typedef.
2021         (probe_key): Change type.
2022         (elf_get_probes): Likewise.  Update.
2023         (probe_key_free): Remove.
2024         (_initialize_elfread): Update.
2025         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2026         Change type.
2027         (dtrace_process_dof_probe, dtrace_process_dof)
2028         (dtrace_static_probe_ops::get_probe): Change type.
2029
2030 2019-05-08  Tom Tromey  <tom@tromey.com>
2031
2032         * xcoffread.c (struct xcoff_symfile_info): Rename from
2033         coff_symfile_info.  Add initializers.
2034         (xcoff_objfile_data_key): Move lower.  Change type.
2035         (XCOFF_DATA): Rewrite.
2036         (xcoff_free_info): Remove.
2037         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2038         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2039         (xcoff_initial_scan): Update.
2040
2041 2019-05-08  Tom Tromey  <tom@tromey.com>
2042
2043         * solib-svr4.c (struct svr4_info): Add initializers and
2044         destructor.
2045         <probes_table>: Now an htab_up.
2046         (solib_svr4_pspace_data): Change type.
2047         (free_probes_table): Simplify.
2048         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2049         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2050         (probes_table_remove_objfile_probes, register_solib_event_probe)
2051         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2052         (_initialize_svr4_solib): Update.
2053
2054 2019-05-08  Tom Tromey  <tom@tromey.com>
2055
2056         * remote.c (remote_pspace_data): Change type.
2057         (remote_pspace_data_cleanup): Remove.
2058         (get_remote_exec_file, set_pspace_remote_exec_file)
2059         (_initialize_remote): Update.
2060
2061 2019-05-08  Tom Tromey  <tom@tromey.com>
2062
2063         * breakpoint.c (breakpoint_objfile_key): Change type.
2064         (get_breakpoint_objfile_data): Update.
2065         (free_breakpoint_objfile_data): Remove.
2066         (_initialize_breakpoint): Update.
2067
2068 2019-05-08  Tom Tromey  <tom@tromey.com>
2069
2070         * linux-tdep.c (struct linux_info): Add initializers.
2071         (linux_inferior_data): Move.  Change type.
2072         (invalidate_linux_cache_inf): Update.
2073         (linux_inferior_data_cleanup): Remove.
2074         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2075
2076 2019-05-08  Tom Tromey  <tom@tromey.com>
2077
2078         * auxv.c (auxv_inferior_data): Move.  Change type.
2079         (auxv_inferior_data_cleanup): Remove.
2080         (invalidate_auxv_cache_inf): Rewrite.
2081         (get_auxv_inferior_data, _initialize_auxv): Update.
2082
2083 2019-05-08  Tom Tromey  <tom@tromey.com>
2084
2085         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2086         (symfile_debug_objfile_data_key): Change type.
2087         (symfile_debug_installed, debug_qf_has_symbols)
2088         (debug_qf_find_last_source_symtab)
2089         (debug_qf_forget_cached_source_info)
2090         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2091         (debug_qf_print_stats, debug_qf_dump)
2092         (debug_qf_expand_symtabs_for_function)
2093         (debug_qf_expand_all_symtabs)
2094         (debug_qf_expand_symtabs_with_fullname)
2095         (debug_qf_map_matching_symbols)
2096         (debug_qf_expand_symtabs_matching)
2097         (debug_qf_find_pc_sect_compunit_symtab)
2098         (debug_qf_map_symbol_filenames)
2099         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2100         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2101         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2102         (debug_sym_read_linetable, debug_sym_relocate): Update.
2103         (symfile_debug_free_objfile): Remove.
2104         (install_symfile_debug_logging, _initialize_symfile_debug):
2105         Update.
2106
2107 2019-05-08  Tom Tromey  <tom@tromey.com>
2108
2109         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2110         allocate_on_obstack.
2111         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2112         (get_dwarf2_per_objfile): Update.
2113         (set_dwarf2_per_objfile): Remove.
2114         (dwarf2_has_info, dwarf2_get_section_info): Update.
2115         (dwarf2_free_objfile): Remove.
2116         (_initialize_dwarf2_read): Update.
2117
2118 2019-05-08  Tom Tromey  <tom@tromey.com>
2119
2120         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2121         initializers.
2122         <unsupported_script_warning_printed,
2123         script_not_found_warning_printed>: Now bool.
2124         (auto_load_pspace_data): Change type.
2125         (~auto_load_pspace_info): Rename from
2126         auto_load_pspace_data_cleanup.
2127         (get_auto_load_pspace_data, init_loaded_scripts_info)
2128         (clear_section_scripts, maybe_print_unsupported_script_warning)
2129         (maybe_print_script_not_found_warning, _initialize_auto_load):
2130         Update.
2131
2132 2019-05-08  Tom Tromey  <tom@tromey.com>
2133
2134         * objfiles.c (objfile_pspace_info): Add destructor and
2135         initializers.
2136         (objfiles_pspace_data): Change type.
2137         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2138         (get_objfile_pspace_data): Update.
2139         (objfiles_bfd_data): Change type.
2140         (get_objfile_bfd_data): Update.
2141         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2142
2143 2019-05-08  Tom Tromey  <tom@tromey.com>
2144
2145         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2146         Change type.
2147         (get_catch_syscall_inferior_data): Update.
2148         (catch_syscall_inferior_data_cleanup): Remove.
2149         (_initialize_break_catch_syscall): Update.
2150
2151 2019-05-08  Tom Tromey  <tom@tromey.com>
2152
2153         * inflow.c (struct terminal_info): Add destructor and
2154         initializers.
2155         (inflow_inferior_data): Change type.
2156         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2157         (get_inflow_inferior_data, inflow_inferior_exit)
2158         (swap_terminal_info, _initialize_inflow): Update.
2159
2160 2019-05-08  Tom Tromey  <tom@tromey.com>
2161
2162         * target-dcache.c (target_dcache_cleanup): Remove.
2163         (target_dcache_aspace_key): Change type.
2164         (target_dcache_init_p, target_dcache_invalidate)
2165         (target_dcache_get, target_dcache_get_or_init)
2166         (_initialize_target_dcache): Update.
2167         * dcache.h (struct dcache_deleter): New.
2168
2169 2019-05-08  Tom Tromey  <tom@tromey.com>
2170
2171         * symtab.c (struct symbol_cache): Add destructor and
2172         initializers.
2173         (symbol_cache_key): Move.  Change type.
2174         (make_symbol_cache, free_symbol_cache): Remove.
2175         (get_symbol_cache): Update.
2176         (symbol_cache_cleanup): Remove.
2177         (ALL_PSPACES, symbol_cache_flush)
2178         (maintenance_print_symbol_cache)
2179         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2180         Update.
2181
2182 2019-05-08  Tom Tromey  <tom@tromey.com>
2183
2184         * symtab.c (struct main_info): Add destructor and initializers.
2185         (main_progspace_key): Move.  Change type.
2186         (get_main_info): Update.
2187         (main_info_cleanup): Remove.
2188         (_initialize_symtab): Update.
2189
2190 2019-05-08  Tom Tromey  <tom@tromey.com>
2191
2192         * registry.h (DECLARE_REGISTRY): Define the _key class.
2193
2194 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * NEWS: Merge two 'New commands' sections.
2197
2198 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2199
2200         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2201         parameter and use Ada language definition instead.
2202         (ada_val_print_ptr): Remove unused language parameter.
2203         (ada_val_print_num): Remove language parameter and use Ada language
2204         definition instead.
2205         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2206         parameter.
2207         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2208         parameter and use Ada language definition instead.
2209         (ada_val_print_1): Update all ada_val_print_xxx calls.
2210         Remove language parameter.
2211         (ada_val_print): Update ada_val_print_1 call.
2212
2213 2019-05-08  Tom Tromey  <tromey@adacore.com>
2214
2215         * remote.c (remote_hw_watchpoint_limit)
2216         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2217         Now static.
2218
2219 2019-05-08  Tom Tromey  <tromey@adacore.com>
2220
2221         * maint.c (_initialize_maint_cmds): Move initialization code to
2222         remote.c.
2223         (watchdog, show_watchdog): Move to remote.c.
2224         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2225         "watchdog" static.
2226         (_initialize_remote): Move initialization code from maint.c.
2227         * defs.h (watchdog): Don't declare.
2228
2229 2019-05-08  Tom Tromey  <tromey@adacore.com>
2230
2231         * tui/tui-interp.c: Include main.h.
2232         * interps.c: Include main.h.
2233         * main.h (interpreter_p): Declare.
2234         * defs.h (interpreter_p): Don't declare.
2235
2236 2019-05-08  Tom Tromey  <tromey@adacore.com>
2237
2238         * dwarf2loc.c: Include dwarf2read.h.
2239         * defs.h (read_unsigned_leb128): Don't declare.
2240         * dwarf2read.h (read_unsigned_leb128): Declare.
2241
2242 2019-05-08  Tom Tromey  <tromey@adacore.com>
2243
2244         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2245         method.
2246
2247 2019-05-08  Tom Tromey  <tromey@adacore.com>
2248
2249         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2250         when no wrap column is set.
2251
2252 2019-05-08  Tom Tromey  <tromey@adacore.com>
2253
2254         * c-lang.c (c_get_string): Handle non-C-style arrays.
2255
2256 2019-05-08  Tom Tromey  <tromey@adacore.com>
2257
2258         * typeprint.c (print_offset_data::update): Print the bit offset,
2259         not the number of bits remaining.
2260
2261 2019-05-08  Tom Tromey  <tromey@adacore.com>
2262
2263         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2264         padding at end of comment.
2265
2266 2019-05-08  Tom Tromey  <tromey@adacore.com>
2267
2268         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2269         Compare main types.
2270
2271 2019-05-06  Tom Tromey  <tom@tromey.com>
2272
2273         * common/scoped_mmap.c: Include common-defs.h.
2274         * common/scoped_mmap.h: Don't include config.h.
2275
2276 2019-05-04  Tom Tromey  <tom@tromey.com>
2277
2278         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2279         (struct aarch64_call_info): Add initializers.
2280         <si>: Now a std::vector.
2281         (pass_on_stack, aarch64_push_dummy_call): Update.
2282
2283 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2284             Tom Tromey  <tom@tromey.com>
2285
2286         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2287         (ppc_threads): Now a std::vector.  Now static.
2288         (hwdebug_find_thread_points_by_tid)
2289         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2290         Update.
2291
2292 2019-05-04  Tom Tromey  <tom@tromey.com>
2293
2294         * arc-tdep.c (arc_tdesc_init): Return bool.
2295
2296 2019-05-04  Tom Tromey  <tom@tromey.com>
2297
2298         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2299         Use gdb_assert_not_reached.
2300
2301 2019-05-04  Tom Tromey  <tom@tromey.com>
2302
2303         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2304         "false".
2305
2306 2019-05-04  Tom Tromey  <tom@tromey.com>
2307
2308         * arc-tdep.c (arc_tdesc_init): Use bool.
2309
2310 2019-05-04  Tom Tromey  <tom@tromey.com>
2311
2312         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2313
2314 2019-05-04  Tom Tromey  <tom@tromey.com>
2315
2316         * cli/cli-cmds.c (valid_command_p): Return bool.
2317
2318 2019-05-04  Tom Tromey  <tom@tromey.com>
2319
2320         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2321         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2322
2323 2019-05-04  Raul Tambre  <raul@tambre.ee>
2324
2325         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2326         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2327         operator for comparison.
2328
2329 2019-05-04  Tom Tromey  <tom@tromey.com>
2330
2331         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2332         (lookup_partial_symbol, print_partial_symbols)
2333         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2334         (psymbol_compare): Update.
2335         (add_psymbol_to_bcache): Clear the entire psymbol.
2336         (maintenance_check_psymtabs): Update.
2337         * psympriv.h (struct partial_symbol): Don't derive from
2338         general_symbol_info.
2339         <obj_section, unrelocated_address, address,
2340         set_unrelocated_address>: Update.
2341         <ginfo>: New member.
2342         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2343         (debug_names::write_psymbols): Update.
2344
2345 2019-05-04  Tom de Vries  <tdevries@suse.de>
2346
2347         * contrib/cc-with-tweaks.sh: Support -n arg.
2348
2349 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2350
2351         * corelow.c (core_target::detach): Ensure frame cache and
2352         register caches are cleared.
2353         inferior.c (exit_inferior_1): Likewise.
2354
2355 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2356             Tom Tromey  <tom@tromey.com>
2357
2358         * dictionary.c (collate_pending_symbols_by_language): Remove
2359         "struct" from foreach.
2360         * symtab.c (lookup_global_symbol_from_objfile)
2361         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2362         foreach.
2363         * ser-tcp.c (net_open): Remove "struct" from foreach.
2364         * objfiles.c (objfile_relocate, objfile_rebase)
2365         (objfile_has_symbols): Remove "struct" from foreach.
2366         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2367         from foreach.
2368         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2369         foreach.
2370         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2371         "struct" from foreach.
2372         * ada-lang.c (create_excep_cond_exprs)
2373         (ada_exception_catchpoint_cond_string): Remove "struct" from
2374         foreach.
2375
2376 2019-05-03  Tom Tromey  <tromey@adacore.com>
2377
2378         * ada-exp.y (convert_char_literal): Check suffix of each
2379         enumerator.
2380
2381 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2382
2383         PR ada/21406:
2384         * ada-exp.y (yywrap): Don't define.
2385         * ada-lex.l (%option): Add noyywrap
2386         (yywrap): Remove.
2387
2388 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2389
2390         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2391         _WIN32_WINNT to the XP level, unless already defined to a higher
2392         level.
2393
2394         * unittests/parse-connection-spec-selftests.c:
2395         * ser-tcp.c:
2396         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2397         override.
2398
2399         * symfile.c (find_separate_debug_file): Remove colon from the
2400         drive spec of DOS/Windows file names of the target, so that the
2401         file name produced from DEBUGDIR and the target's directory will
2402         be valid on DOS/Windows systems.
2403
2404 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * rust-lang.c (val_print_struct): Handle printing structures
2407         containing strings.
2408
2409 2019-05-02  Tom Tromey  <tromey@adacore.com>
2410
2411         * valarith.c (_initialize_valarith): Remove.
2412
2413 2019-05-01  Tom Tromey  <tromey@adacore.com>
2414
2415         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2416         bitfields.
2417
2418 2019-05-01  Tom Tromey  <tromey@adacore.com>
2419
2420         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2421         for big-endian copies.
2422
2423 2019-04-30  Ali Tamur  <tamur@google.com>
2424         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2425         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2426         (read_3_bytes): New function.
2427
2428 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2429
2430         * windows-nat.c (main_thread_id): Delete.
2431         (handle_output_debug_string): Replace main_thread_id by
2432         current_event.dwThreadId.
2433         (fake_create_process): Likewise.
2434         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2435         Do not set main_thread_id.
2436         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2437         current_event.dwThreadId.
2438         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2439
2440 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2441
2442         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2443         Use current_event.dwThreadId instead of main_thread_id.
2444
2445 2019-04-30  Tom Tromey  <tromey@adacore.com>
2446
2447         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2448         (create_excep_cond_exprs): Iterate over program spaces.
2449         (ada_exception_catchpoint_cond_string): Examine all minimal
2450         symbols for exception types.
2451
2452 2019-04-30  Tom Tromey  <tromey@adacore.com>
2453
2454         PR c++/24470:
2455         * dwarf2read.c (process_structure_scope): Handle case where type
2456         has template parameters but no symbol was created.
2457
2458 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2459             Chris January  <chris.january@arm.com>
2460
2461         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2462         qualifier.
2463         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2464
2465 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * f-typeprint.c (f_print_type): Update rules for printing
2468         whitespace.
2469         (f_type_print_varspec_suffix): Likewise.
2470
2471 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2472             Chris January  <chris.january@arm.com>
2473
2474         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2475         function arguments.
2476
2477 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2478
2479         * f-lang.c (build_fortran_types): Change name of void type to
2480         lower case.
2481         * f-typeprint.c (f_type_print_base): Print the name of the void
2482         type, rather than a fixed string.
2483         * f-valprint.c (f_decorations): Use lower case void string.
2484
2485 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2486             Chris January  <chris.january@arm.com>
2487
2488         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2489         types for Fortran.
2490
2491 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2492             Chris January  <chris.january@arm.com>
2493             David Lecomber  <david.lecomber@arm.com>
2494
2495         * f-exp.y (BINOP_INTRINSIC): New token.
2496         (exp): New parser rule handling BINOP_INTRINSIC.
2497         (f77_keywords): Add new builtin procedures.
2498         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2499         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2500         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2501         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2502         (print_unop_subexp_f): New function.
2503         (print_binop_subexp_f): New function.
2504         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2505         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2506         (dump_subexp_body_f): Likewise.
2507         (operator_check_f): Likewise.
2508         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2509         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2510
2511 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2512
2513         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2514         UNOP_KIND.
2515         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2516         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2517         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2518         (operator_length_f): New fuction.
2519         (print_subexp_f): New function.
2520         (op_name_f): New function.
2521         (dump_subexp_body_f): New function.
2522         (operator_check_f): New function.
2523         (exp_descriptor_f): Replace standard expression handling functions
2524         with new functions.
2525         * gdb/fortran-operator.def: New file.
2526         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2527         * gdb/std-operator.def: Remove UNOP_KIND.
2528
2529 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * std-operator.def: Remove unbalanced, stray double quote
2532         character.
2533
2534 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2535             Chris January  <chris.january@arm.com>
2536             Daniel Everett  <daniel.everett@arm.com>
2537             Nick Forrington  <nick.forrington@arm.com>
2538             Richard Bunt  <richard.bunt@arm.com>
2539
2540         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2541         of depth when printing anonymous structs or unions.
2542         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2543         Don't print either the top-level value, or the children if the
2544         max-depth is exceeded.
2545         (ppscm_print_children): When printing the key of a map, allow one
2546         extra level of depth.
2547         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2548         print either the top-level value, or the children if the max-depth
2549         is exceeded.
2550         (print_children): When printing the key of a map, allow one extra
2551         level of depth.
2552         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2553         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2554         (user_print_options): Initialise max_depth field.
2555         (val_print_scalar_or_string_type_p): New function.
2556         (val_print): Check to see if the max depth has been reached.
2557         (val_print_check_max_depth): Define new function.
2558         (show_print_max_depth): New function.
2559         (_initialize_valprint): Add 'print max-depth' option.
2560         * valprint.h (struct value_print_options) <max_depth>: New field.
2561         (val_print_check_max_depth): Declare new function.
2562         * NEWS: Document new feature.
2563
2564 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * ada-lang.c (ada_language_defn): Initialise new field.
2567         * c-lang.c (c_is_string_type_p): New function.
2568         (c_language_defn): Initialise new field.
2569         (cplus_language_defn): Initialise new field.
2570         (asm_language_defn): Initialise new field.
2571         (minimal_language_defn): Initialise new field.
2572         * c-lang.h (c_is_string_type_p): Declare new function.
2573         * d-lang.c (d_language_defn): Initialise new field.
2574         * f-lang.c (f_is_string_type_p): New function.
2575         (f_language_defn): Initialise new field.
2576         * go-lang.c (go_is_string_type_p): New function.
2577         (go_language_defn): Initialise new field.
2578         * language.c (default_is_string_type_p): New function.
2579         (unknown_language_defn): Initialise new field.
2580         (auto_language_defn): Initialise new field.
2581         * language.h (struct language_defn) <la_is_string_type_p>: New
2582         member variable.
2583         (default_is_string_type_p): Declare new function.
2584         * m2-lang.c (m2_language_defn): Initialise new field.
2585         * objc-lang.c (objc_language_defn): Initialise new field.
2586         * opencl-lang.c (opencl_language_defn): Initialise new field.
2587         * p-lang.c (pascal_is_string_type_p): New function.
2588         (pascal_language_defn): Initialise new field.
2589         * rust-lang.c (rust_is_string_type_p): New function.
2590         (rust_language_defn): Initialise new field.
2591
2592 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2595         New field.
2596         * ada-lang.c (ada_language_defn): Initialise new field.
2597         * c-lang.c (c_language_defn): Likewise.
2598         (cplus_language_defn): Likewise.
2599         (asm_language_defn): Likewise.
2600         (minimal_language_defn): Likewise.
2601         * d-lang.c (d_language_defn): Likewise.
2602         * f-lang.c (f_language_defn): Likewise.
2603         * go-lang.c (go_language_defn): Likewise.
2604         * language.c (unknown_language_defn): Likewise.
2605         (auto_language_defn): Likewise.
2606         * m2-lang.c (m2_language_defn): Likewise.
2607         * objc-lang.c (objc_language_defn): Likewise.
2608         * opencl-lang.c (opencl_language_defn): Likewise.
2609         * p-lang.c (pascal_language_defn): Likewise.
2610         * rust-lang.c (rust_language_defn): Likewise.
2611
2612 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2613
2614         * ada-lang.c (ada_is_character_type): Change return type to bool.
2615         (ada_is_string_type): Likewise.
2616         * ada-lang.h (ada_is_character_type): Update declaration
2617         (ada_is_string_type): Likewise.
2618
2619 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2620
2621         Support style in 'frame|thread apply'
2622
2623         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2624         * record.c (record_start, record_stop): Update callers of
2625         execute_command_to_string with false.
2626         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2627         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2628         methods.
2629         (class string_file): New constructor with term_out parameter.
2630         Override methods term_out and can_emit_style_escape.  New member
2631         term_out.
2632         (class stdio_file): Override can_emit_style_escape.
2633         (class tee_file): Override term_out and can_emit_style_escape.
2634         * utils.h (can_emit_style_escape): Remove.
2635         * utils.c (can_emit_style_escape): Likewise.
2636         Update all callers of can_emit_style_escape (SOMESTREAM) to
2637         SOMESTREAM->can_emit_style_escape.
2638         * source-cache.c (source_cache::get_source_lines): Likewise.
2639         * stack.c (frame_apply_command_count): Call execute_command_to_string
2640         passing the term_out characteristic of the current gdb_stdout.
2641         * thread.c (thr_try_catch_cmd): Likewise.
2642         * top.c (execute_command_to_string): pass term_out parameter
2643         to construct the string_file for the command output.
2644         * ui-file.c (term_cli_styling): New function (most code moved
2645         from utils.c can_emit_style_escape).
2646         (string_file::string_file, string_file::can_emit_style_escape,
2647         stdio_file::can_emit_style_escape, tee_file::term_out,
2648         tee_file::can_emit_style_escape): New functions.
2649
2650 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2651
2652         * NEWS: Mention the new set|show may-call-functions.
2653         * infcall.c (may_call_functions_p): New variable.
2654         (show_may_call_functions_p): New function.
2655         (call_function_by_hand_dummy): Throws an error if not
2656         may-call-functions.
2657         (_initialize_infcall): Call add_setshow_boolean_cmd for
2658         may-call-functions.
2659
2660 2019-04-25  Keith Seitz  <keiths@redhat.com>
2661
2662         PR c++/24367
2663         * cp-support.c (inspect_type): Don't attempt substitutions
2664         of symbol with the same name.
2665
2666 2019-04-25  Tom Tromey  <tromey@adacore.com>
2667
2668         PR gdb/24475:
2669         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2670         static.
2671
2672 2019-04-25  Tom Tromey  <tromey@adacore.com>
2673
2674         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2675         rvalue reference.
2676         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2677         (gdb_xml_parser::parse): Use std::move.
2678         * python/python-internal.h (gdbpy_convert_exception): Take a const
2679         reference.
2680         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2681         std::move.
2682         * python/py-utils.c (gdbpy_convert_exception): Take a const
2683         reference.
2684         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2685         Use std::move.
2686         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2687         Use std::move.
2688         * mi/mi-main.c (mi_print_exception): Take a const reference.
2689         * main.c (handle_command_errors): Take a const reference.
2690         * linespec.c (parse_linespec): Use std::move.
2691         * infcall.c (run_inferior_call): Use std::move.
2692         (call_function_by_hand_dummy): Use std::move.
2693         * exec.c (try_open_exec_file): Use std::move.
2694         * exceptions.h (exception_print, exception_fprintf)
2695         (exception_print_same): Update.
2696         * exceptions.c (print_exception, exception_print)
2697         (exception_fprintf, exception_print_same): Change parameters to
2698         const reference.
2699         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2700         * common/new-op.c: Use std::move.
2701         * common/common-exceptions.h (struct gdb_exception): Add move
2702         constructor.
2703         (struct gdb_exception_error, struct gdb_exception_quit, struct
2704         gdb_quit_bad_alloc): Change constructor to move constructor.
2705         (throw_exception): Change parameter to rvalue reference.
2706         * common/common-exceptions.c (throw_exception): Take rvalue
2707         reference.
2708         * cli/cli-interp.c (safe_execute_command): Use std::move.
2709         * breakpoint.c (insert_bp_location, location_to_sals): Use
2710         std::move.
2711
2712 2019-04-25  Tom Tromey  <tromey@adacore.com>
2713
2714         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2715         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2716         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2717         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2718         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2719         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2720         guile/scm-value.c: Use unpack.
2721         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2722         gdbscm_gdb_exception.
2723         (gdbscm_throw_gdb_exception): Likewise.
2724         (struct gdbscm_gdb_exception): New.
2725         (unpack): New function.
2726         (gdbscm_wrap): Use unpack.
2727
2728 2019-04-25  Tom Tromey  <tromey@adacore.com>
2729
2730         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2731         (gdb_rl_callback_handler): Use std::move.
2732         * common/common-exceptions.h (struct gdb_exception): Add move
2733         assignment operator.
2734         (throw_exception_sjlj): Change "exception" to const reference.
2735         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2736         (throw_exception_sjlj): Change "exception" to const reference.
2737
2738 2019-04-25  Tom Tromey  <tromey@adacore.com>
2739
2740         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2741         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2742         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2743         Update.
2744         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2745         Update.
2746         * mi/mi-interp.c (mi_interp::exec): Update.
2747         * linespec.c (parse_linespec): Update.
2748         * infcall.c (run_inferior_call): Update.
2749         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2750         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2751         (gdbscm_lookup_global_symbol): Update.
2752         * guile/scm-param.c (gdbscm_parameter_value): Update.
2753         * guile/scm-frame.c (gdbscm_frame_read_register)
2754         (gdbscm_frame_read_var): Update.
2755         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2756         * exec.c (try_open_exec_file): Update.
2757         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2758         (gdb_rl_callback_handler): Update.
2759         * common/common-exceptions.h (exception_none): Don't declare.
2760         * common/common-exceptions.c (exception_none): Don't define.
2761         (struct catcher) <exception>: Update.
2762         * cli/cli-interp.c (safe_execute_command): Update.
2763         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2764
2765 2019-04-25  Ali Tamur  <tamur@google.com>
2766
2767         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2768         (read_attribute_value): Likewise.
2769         (dwarf2_read_addr_index): Update comment.
2770         (read_str_index): Add DW_FORM_strx.
2771         (dwarf2_string_attr): Likewise.
2772         (dwarf2_const_value_attr): Likewise.
2773         (dump_die_shallow): Likewise.
2774         (dwarf2_fetch_constant_bytes): Likewise.
2775         (skip_form_bytes): Likewise.
2776         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2777
2778 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2779
2780         PR corefiles/11608
2781         PR corefiles/18187
2782         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2783         OFFSET.  Verify if current mapping contains an ELF header.
2784         (linux_find_memory_regions_full): Adjust call to
2785         dump_mapping_p.
2786
2787 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2788             Kang Li <kanglictf@gmail.com>
2789
2790         PR gdb/21600
2791
2792         * dwarf2-frame.c (read_initial_length): Be consistent about using
2793         unsigned representation of length.
2794         (decode_frame_entry_1): Likewise.  Check for wraparound of
2795         end pointer as well as buffer overflow.
2796
2797 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2798
2799         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2800         "vq".
2801
2802 2019-04-24  Tom Tromey  <tromey@adacore.com>
2803
2804         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2805
2806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2807
2808         * s12z-tdep.c (s12z_unwind_pc): Delete.
2809         (s12z_unwind_sp): Delete.
2810         (s12z_gdbarch_init): Don't register deleted functions with
2811         gdbarch.
2812
2813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2814
2815         * rl78-tdep.c (rl78_unwind_sp): Delete.
2816         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2817
2818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2819
2820         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2821         (xstormy16_unwind_pc): Delete.
2822         (xstormy16_dummy_id): Delete.
2823         (xstormy16_gdbarch_init): Don't register deleted functions with
2824         gdbarch.
2825
2826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2827
2828         * vax-tdep.c (vax_unwind_pc): Delete.
2829         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2830
2831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         * v850-tdep.c (v850_unwind_sp): Delete.
2834         (v850_unwind_pc): Delete.
2835         (v850_dummy_id): Delete.
2836         (v850_gdbarch_init): Don't register deleted functions with
2837         gdbarch.
2838
2839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2842         (tilegx_unwind_pc): Delete.
2843         (tilegx_unwind_dummy_id): Delete.
2844         (tilegx_gdbarch_init): Don't register deleted functions with
2845         gdbarch.
2846
2847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2848
2849         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2850         (tic6x_dummy_id): Delete.
2851         (tic6x_gdbarch_init): Don't register deleted functions with
2852         gdbarch.
2853
2854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2855
2856         * sparc-tdep.c (sparc_unwind_pc): Delete.
2857         (sparc32_gdbarch_init): Don't register deleted function with
2858         gdbarch.
2859
2860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * sh-tdep.c (sh_unwind_sp): Delete.
2863         (sh_unwind_pc): Delete.
2864         (sh_dummy_id): Delete.
2865         (sh_gdbarch_init): Don't register deleted functions with
2866         gdbarch.
2867
2868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2869
2870         * score-tdep.c (score_unwind_sp): Delete.
2871         (score_unwind_pc): Delete.
2872         (score_dummy_id): Delete.
2873         (score_gdbarch_init): Don't register deleted functions with
2874         gdbarch.
2875
2876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * rx-tdep.c (rx_unwind_pc): Delete.
2879         (rx_unwind_sp): Delete.
2880         (rx_dummy_id): Delete.
2881         (rx_gdbarch_init): Don't register deleted functions with
2882         gdbarch.  Update comment.
2883
2884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2887         (rs6000_dummy_id): Delete.
2888         (rs6000_gdbarch_init): Don't register deleted functions with
2889         gdbarch.
2890
2891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2892
2893         * or1k-tdep.c (or1k_dummy_id): Delete.
2894         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2895
2896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * nios2-tdep.c (nios2_dummy_id): Delete.
2899         (nios2_unwind_sp): Delete.
2900         (nios2_gdbarch_init): Don't register deleted functions with
2901         gdbarch.
2902
2903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2904
2905         * nds32-tdep.c (nds32_dummy_id): Delete.
2906         (nds32_unwind_pc): Delete.
2907         (nds32_unwind_sp): Delete.
2908         (nds32_gdbarch_init): Don't register deleted functions with
2909         gdbarch.
2910
2911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * msp430-tdep.c (msp430_unwind_pc): Delete.
2914         (msp430_unwind_sp): Delete.
2915         (msp430_dummy_id): Delete.
2916         (msp430_gdbarch_init): Don't register deleted functions with
2917         gdbarch.
2918
2919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2920
2921         * moxie-tdep.c (moxie_unwind_sp): Delete.
2922         (moxie_unwind_pc): Delete.
2923         (moxie_dummy_id): Delete.
2924         (moxie_gdbarch_init): Don't register deleted functions with
2925         gdbarch.
2926
2927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2928
2929         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2930         (mn10300_unwind_pc): Delete.
2931         (mn10300_unwind_sp): Delete.
2932         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2933         mn10300_unwind_sp.
2934         (mn10300_frame_unwind_init): Don't register deleted functions with
2935         gdbarch.
2936
2937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2938
2939         * mep-tdep.c (mep_unwind_pc): Delete.
2940         (mep_unwind_sp): Delete.
2941         (mep_dummy_id): Delete.
2942         (mep_gdbarch_init): Don't register deleted functions with
2943         gdbarch.
2944
2945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2946
2947         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2948         (m68hc11_unwind_sp): Delete.
2949         (m68hc11_gdbarch_init): Don't register deleted functions with
2950         gdbarch.
2951
2952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2953
2954         * m32r-tdep.c (m32r_unwind_sp): Delete.
2955         (m32r_unwind_pc): Delete.
2956         (m32r_dummy_id): Delete.
2957         (m32r_gdbarch_init): Don't register deleted functions with
2958         gdbarch.
2959
2960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         * m32c-tdep.c (m32c_unwind_pc): Delete.
2963         (m32c_unwind_sp): Delete.
2964         (m32c_dummy_id): Delete.
2965         (m32c_gdbarch_init): Don't register deleted functions with
2966         gdbarch.
2967
2968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2969
2970         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2971         (lm32_unwind_pc): Delete.
2972         (lm32_dummy_id): Delete.
2973         (lm32_gdbarch_init): Don't register deleted functions with
2974         gdbarch.
2975
2976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2977
2978         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2979         (iq2000_unwind_pc): Delete.
2980         (iq2000_dummy_id): Delete.
2981         (iq2000_gdbarch_init): Don't register deleted functions with
2982         gdbarch.
2983
2984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * nds32-tdep.c (nds32_type_align): Delete.
2987         (nds32_push_dummy_call): Use type_align instead.
2988
2989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2990
2991         * arm-tdep.c (arm_type_align): Only handle vector override case.
2992         (arm_push_dummy_call): Use type_align.
2993         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2994
2995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2998         case.
2999         (pass_on_stack): Use type_align.
3000         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3001         function.
3002
3003 2019-04-23  Tom Tromey  <tromey@adacore.com>
3004
3005         * dwarf2read.c (line_header::file_name_at): Remove unused
3006         overload.
3007
3008 2019-04-23  Tom de Vries  <tdevries@suse.de>
3009
3010         PR gdb/24438
3011         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3012         invocation.
3013
3014
3015 2019-03-27  Ali Tamur  <tamur@google.com>
3016
3017         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3018         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3019         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3020         (dwarf_expr_context::get_addr_index): Likewise
3021         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3022         (symbol_needs_eval_context::get_addr_index): Likewise
3023         (disassemble_dwarf_expression): Add DW_OP_addrx
3024         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3025         (read_cutu_die_from_dwo): Update comment
3026         (skip_one_die): Add DW_FORM_addrx
3027         (read_attribute_value): Likewise
3028         (var_decode_location): Add DW_OP_addrx
3029         (dwarf2_const_value_attr): Add DW_FORM_addrx
3030         (dump_die_shallow): Likewise
3031         (dwarf2_fetch_constant_bytes): Likewise
3032         (decode_locdesc): Add DW_OP_addrx
3033         (skip_form_bytes): Add DW_FORM_addrx
3034
3035 2019-04-22  Ali Tamur  <tamur@google.com>
3036
3037         * MAINTAINERS (Write After Approval): Add self.
3038
3039 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3040
3041         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3042         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3043         (open_symbol_file_object): Likewise.
3044         (svr4_default_sos): Add info parameter.
3045         (svr4_read_so_list): Likewise.
3046         (svr4_current_sos_direct): Adjust functions calls to pass down
3047         info.
3048         (svr4_current_sos_1): Add info parameter.
3049         (svr4_current_sos): Call get_svr4_info, pass info down to
3050         svr4_current_sos_1.
3051         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3052         get_svr4_info.
3053         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3054         get_svr4_info.
3055         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3056         to get_svr4_info.
3057         (probes_table_remove_objfile_probes): Likewise.
3058         (register_solib_event_probe): Add info parameter.
3059         (solist_update_incremental): Pass info parameter down to
3060         svr4_read_so_list.
3061         (disable_probes_interface): Add info parameter.
3062         (svr4_handle_solib_event): Pass current_program_space to
3063         get_svr4_info.  Adjust disable_probes_interface cleanup.
3064         (svr4_create_probe_breakpoints): Add info parameter, pass it
3065         down to register_solib_event_probe.
3066         (svr4_create_solib_event_breakpoints): Add info parameter,
3067         pass it down to svr4_create_probe_breakpoints.
3068         (enable_break): Pass info down to
3069         svr4_create_solib_event_breakpoints.
3070         (svr4_solib_create_inferior_hook): Pass current_program_space to
3071         get_svr4_info.
3072         (svr4_clear_solib): Likewise.
3073
3074 2019-04-22  Pedro Alves  <palves@redhat.com>
3075
3076         * solib-svr4.c (svr4_free_objfile_observer): New.
3077         (probe_and_action::objfile): New field.
3078         (probes_table_htab_remove_objfile_probes)
3079         (probes_table_remove_objfile_probes): New functions.
3080         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3081         in the new probe_and_action.  Don't store the probe in 'lookup'.
3082         (svr4_create_probe_breakpoints): Pass objfile to
3083         register_solib_event_probe.
3084         (_initialize_svr4_solib): Register a free_objfile observer.
3085
3086 2019-04-19  Tom Tromey  <tom@tromey.com>
3087
3088         * common/queue.h: Remove.
3089
3090 2019-04-19  Tom Tromey  <tom@tromey.com>
3091
3092         * event-loop.c: Don't include "common/queue.h".
3093
3094 2019-04-19  Tom Tromey  <tom@tromey.com>
3095
3096         * remote.c (remote_target): Use delete.
3097         * remote-notif.h: Include <list>, not "common/queue.h".
3098         (notif_client_p): Remove typedef.
3099         (remote_notif_state): Add constructor, destructor, initializer.
3100         <notif_queue>: Now a std::list.
3101         (remote_notif_state_xfree): Don't declare.
3102         * remote-notif.c (remote_notif_process, handle_notification)
3103         (remote_notif_state_allocate): Update.
3104         (~remote_notif_state): Rename from remote_notif_state_xfree.
3105
3106 2019-04-19  Tom Tromey  <tom@tromey.com>
3107
3108         * symfile.c (reread_symbols): Update.
3109         * objfiles.c (objfile_register_static_link)
3110         (objfile_lookup_static_link): Update
3111         (~objfile) Don't delete static_links.
3112         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3113
3114 2019-04-19  Tom Tromey  <tom@tromey.com>
3115
3116         * type-stack.h (struct type_stack) <insert>: Constify string.
3117         * type-stack.c (type_stack::insert): Constify string.
3118         * gdbtypes.h (lookup_template_type): Update.
3119         (address_space_name_to_int): Update.
3120         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3121         const.
3122         (lookup_template_type): Make name const.
3123         * c-exp.y: Update rules.
3124         (lex_one_token, classify_name, classify_inner_name)
3125         (c_print_token): Update.
3126         * p-exp.y: Update rules.
3127         (yylex): Update.
3128         * f-exp.y: Update rules.
3129         (yylex): Update.
3130         * d-exp.y: Update rules.
3131         (lex_one_token, classify_name, classify_inner_name): Update.
3132         * parse.c (write_dollar_variable, copy_name): Return std::string.
3133         * parser-defs.h (copy_name): Change return type.
3134         * m2-exp.y: Update rules.
3135         (yylex): Update.
3136         * go-exp.y (lex_one_token): Update.
3137         Update rules.
3138         (classify_unsafe_function, classify_packaged_name)
3139         (classify_name, yylex): Update.
3140
3141 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3142
3143         * configure.ac: add --enable-source-highlight switch.
3144         * configure: Regenerate.
3145         * top.c (print_gdb_version): plumb --enable-source-highlight
3146         status to "show configuration".
3147
3148 2019-04-19  Tom Tromey  <tromey@adacore.com>
3149
3150         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3151         Check ADA_TYPE_P.
3152         (empty_record, ada_template_to_fixed_record_type_1)
3153         (template_to_static_fixed_type)
3154         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3155         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3156         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3157         macros.
3158
3159 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3160
3161         PR symtab/24423:
3162         * source.c (print_source_lines_base): Advance "iter" when a
3163         control character is seen.
3164
3165 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3166
3167         * inferior.h (struct infcall_suspend_state_deleter):
3168         Catch exception in destructor to avoid crash.
3169
3170 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3171
3172         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3173         close to the add_com "shell".
3174
3175 2019-04-18  Tom Tromey  <tromey@adacore.com>
3176
3177         * process-stratum-target.h (class process_stratum_target)
3178         <stratum>: Add "final".
3179
3180 2019-04-17  Tom Tromey  <tromey@adacore.com>
3181
3182         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3183         against nullptr before use.
3184
3185 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3186
3187         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3188
3189 2019-04-17  Jim Wilson  <jimw@sifive.com>
3190             Andrew Burgess  <andrew.burgess@embecosm.com>
3191
3192         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3193         code read might fail, assume 4-byte breakpoint in that case.
3194
3195 2019-04-15  Leszek Swirski  <leszeks@google.com>
3196
3197         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3198         rather than a hand-rolled POD check when checking for forced MEMORY
3199         classification.
3200
3201 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3202
3203         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3204         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3205         function.
3206         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3207         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3208         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3209         declaration.
3210
3211 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3212
3213         * aarch64-linux-nat.c
3214         (aarch64_linux_nat_target::thread_architecture): Add override.
3215         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3216         each VQ.
3217
3218 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3219
3220         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3221
3222 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3223
3224         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3225         target types of size 96-bits, add some additional comments, and
3226         check that the builtin type we found was the correct size.
3227
3228 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3229
3230         * utils.c (prompt_for_continue): Don't restore the styling at the
3231         end, as applied_style has the wrong value.  This fixes styling in
3232         long lists of file names that are interrupted by the "Continue?"
3233         prompt.
3234
3235 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3236
3237         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3238         * c-lang.c (c_language_defn): Likewise.
3239         (cplus_language_defn): Likewise.
3240         (asm_language_defn): Likewise.
3241         (minimal_language_defn): Likewise.
3242         * d-lang.c (d_language_defn): Likewise.
3243         * f-lang.c (f_language_defn): Likewise.
3244         * go-lang.c (go_language_defn): Likewise.
3245         * language.c (unknown_language_defn): Likewise.
3246         (auto_language_defn): Likewise.
3247         * language.h (struct language_defn): Remove la_magic field.
3248         (LANG_MAGIC): Delete.
3249         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3250         * objc-lang.c (objc_language_defn): Likewise.
3251         * opencl-lang.c (opencl_language_defn): Likewise.
3252         * p-lang.c (pascal_language_defn): Likewise.
3253         * rust-lang.c (rust_language_defn): Likewise.
3254
3255 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3256
3257         * riscv-tdep.c (riscv_type_align): New function.
3258         (riscv_type_alignment): Delete.
3259         (riscv_arg_location): Use 'type_align'.
3260         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3261
3262 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3263
3264         * gdbtypes.c (type_align): A struct with no non-static fields also
3265         has alignment of 1.
3266
3267 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3270         component to 0.
3271         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3272         member.
3273         (riscv_struct_info::analyse): New implementation using new
3274         analyse_inner member function.
3275         (riscv_struct_info::field_offset): New member function.
3276         (riscv_struct_info::m_offsets): New member variable.
3277         (riscv_struct_info::analyse_inner): New private member function,
3278         takes the old implementation of riscv_struct_info::analyse but
3279         extended to track field offsets.
3280         (riscv_call_arg_struct): Update the struct folding special cases
3281         to handle cases where empty C++ structs, which are non-zero
3282         length, are found.
3283         (riscv_arg_location): Initialise the length of each location, a
3284         non-zero length now indicates the location is in use.
3285         (riscv_push_dummy_call): Allow for the first location having a
3286         non-zero offset when setting up arguments.
3287         (riscv_return_value): Likewise, but for return values.
3288
3289 2019-04-11  Tom Tromey  <tromey@adacore.com>
3290
3291         * utils.c (internal_vproblem): Make "msg" const.
3292
3293 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3294
3295         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3296         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3297         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3298         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3299
3300 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3301
3302         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3303         function.
3304         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3305         of amd64_collect_native_gregset.
3306         (amd64_linux_nat_target::store_registers): Likewise.
3307
3308 2019-04-10  Tom Tromey  <tom@tromey.com>
3309
3310         * symtab.c (lookup_global_symbol_from_objfile)
3311         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3312         * objfiles.h (class separate_debug_iterator): New.
3313         (class separate_debug_range): New.
3314         (struct objfile) <separate_debug_objfiles>: New method.
3315         (objfile_separate_debug_iterate): Don't declare.
3316         * objfiles.c (separate_debug_iterator::operator++): Rename from
3317         objfile_separate_debug_iterate.
3318         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3319         iterator.
3320         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3321         iterator.
3322
3323 2019-04-10  Tom Tromey  <tom@tromey.com>
3324
3325         * symfile.c (reread_symbols): Remove old comment.
3326         * objfiles.c (free_all_objfiles): Fix a typo.
3327
3328 2019-04-10  Tom Tromey  <tom@tromey.com>
3329
3330         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3331         * minsyms.c (lookup_minimal_symbol): Use foreach.
3332         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3333         (lookup_minimal_symbol_solib_trampoline): Likewise.
3334         * symfile.c (reread_symbols): Use foreach.
3335
3336 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3337             Tom Tromey  <tromey@adacore.com>
3338
3339         PR rust/24414:
3340         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3341         (rust_lex_int_test): Change "value" to be LONGEST.
3342         (rust_lex_tests): Add test for long integer literal.
3343
3344 2019-04-09  Tom Tromey  <tromey@adacore.com>
3345
3346         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3347         to bool.
3348         (extended_remote_target::attach): Update.
3349         (remote_target::remote_notice_new_inferior): Update.
3350         (remote_target::add_current_inferior_and_thread): Update.
3351         * inferior.c (exit_inferior_1): Use "false".
3352         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3353
3354 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3355
3356         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3357         the "start" command.
3358
3359 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3360
3361         * python/py-inferior.c (infpy_thread_from_thread_handle):
3362         Adjust comments to reflect renaming of thread_from_thread_handle
3363         to thread_from_handle.  Adjust keywords.  Fix type error message.
3364         (inferior_object_methods): Add thread_from_handle.  Retain
3365         thread_from_thread_handle, but mark it as deprecated.
3366
3367 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3368
3369         * gdbthread.h (find_thread_by_handle): Revise declaration.
3370         * thread.c (find_thread_by_handle): Likewise.  Adjust
3371         implementation too.
3372         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3373         support for buffer objects as handles.
3374
3375 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3376
3377         * python/py-infthread.c (thpy_thread_handle): New function.
3378         (thread_object_methods): Register thpy_thread_handle.
3379
3380 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3381
3382         * gdbthread.h (thread_to_thread_handle): Declare.
3383         * thread.c (gdbtypes.h): Include.
3384         (thread_to_thread_handle): New function.
3385
3386         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3387         (target_thread_info_to_thread_handle): Declare.
3388         * target.c (target_thread_info_to_thread_handle): New function.
3389         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3390         * target-delegates.c: Regenerate.
3391
3392         * linux-thread-db.c (class thread_db_target): Add method
3393         thread_info_to_thread_handle.
3394         (thread_db_target::thread_info_to_thread_handle): Define.
3395         * remote.c (class remote_target): Add new method
3396         thread_info_to_thread_handle.
3397         (remote_target::thread_info_to_thread_handle): Define.
3398
3399 2019-04-08  Pedro Alves  <palves@redhat.com>
3400
3401         * common/common-exceptions.c (throw_exception): Don't create
3402         named object to throw; throw directly.
3403         (throw_it): Likewise.  Don't initialize gdb_exception::message
3404         here, with new; pass FMT and AP to the ctor instead.
3405         * common/common-exceptions.h: Include <string>.
3406         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3407         const char *, va_list)): New ctor.  Use std::make_shared.
3408         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3409         errors)): Delete.
3410         (gdb_exception_error::gdb_exception_error(enum errors, const char
3411         *, va_list)): New.
3412         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3413         Add assertion.
3414         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3415         errors)): Delete.
3416         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3417         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3418         Add assertion.
3419
3420 2019-04-08  Tom Tromey  <tom@tromey.com>
3421
3422         * valops.c (value_rtti_indirect_type): Replace throw_exception
3423         with throw.
3424         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3425         with throw.
3426         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3427         throw.
3428         * target.c (target_translate_tls_address): Replace throw_exception
3429         with throw.
3430         * stack.c (frame_apply_command_count): Replace throw_exception
3431         with throw.
3432         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3433         throw.
3434         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3435         with throw.
3436         * rs6000-tdep.c (rs6000_frame_cache)
3437         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3438         * remote.c: Replace throw_exception with throw.
3439         * record-full.c (record_full_message, record_full_wait_1)
3440         (record_full_restore): Replace throw_exception with throw.
3441         * record-btrace.c:
3442         (get_thread_current_frame_id, record_btrace_start_replaying)
3443         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3444         (cmd_record_btrace_start): Replace throw_exception with throw.
3445         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3446         throw.
3447         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3448         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3449         * linespec.c:
3450         (find_linespec_symbols): Replace throw_exception with throw.
3451         * infrun.c (displaced_step_prepare, resume): Replace
3452         throw_exception with throw.
3453         * infcmd.c (post_create_inferior): Replace throw_exception with
3454         throw.
3455         * inf-loop.c (inferior_event_handler): Replace throw_exception
3456         with throw.
3457         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3458         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3459         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3460         (get_prev_frame_always, get_frame_pc_if_available)
3461         (get_frame_address_in_block_if_available, get_frame_language):
3462         Replace throw_exception with throw.
3463         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3464         throw_exception with throw.
3465         * eval.c (fetch_subexp_value, evaluate_var_value)
3466         (evaluate_funcall, evaluate_subexp_standard): Replace
3467         throw_exception with throw.
3468         * dwarf2loc.c (call_site_find_chain)
3469         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3470         Replace throw_exception with throw.
3471         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3472         with throw.
3473         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3474         throw.
3475         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3476         * completer.c (complete_line_internal): Replace throw_exception
3477         with throw.
3478         * compile/compile-object-run.c (compile_object_run): Replace
3479         throw_exception with throw.
3480         * cli/cli-script.c (process_next_line): Replace throw_exception
3481         with throw.
3482         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3483         (btrace_enable, btrace_maint_update_pt_packets): Replace
3484         throw_exception with throw.
3485         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3486         throw_exception with throw.
3487         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3488         throw_exception with throw.
3489         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3490         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3491         * aarch64-tdep.c (aarch64_make_prologue_cache)
3492         (aarch64_make_stub_cache): Replace throw_exception with throw.
3493
3494 2019-04-08  Tom Tromey  <tom@tromey.com>
3495
3496         * common/common-exceptions.c (throw_exception): Rename from
3497         throw_exception_cxx.  Remove old copy.  Make argument const.
3498         (throw_it): Create and throw exception objects directly.
3499         * common/common-exceptions.h (throw_exception): Make argument
3500         const.
3501         (struct gdb_exception_error): Add constructor.
3502         (struct gdb_exception_quit): Add constructor.
3503
3504 2019-04-08  Tom Tromey  <tom@tromey.com>
3505
3506         * common/common-exceptions.h (exception_rethrow): Don't declare.
3507         (TRY_SJLJ): Update comment.
3508         (TRY, CATCH, END_CATCH): Remove.
3509         * common/common-exceptions.c (exception_rethrow): Remove.
3510
3511 2019-04-08  Tom Tromey  <tom@tromey.com>
3512
3513         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3514         Remove.
3515         (gdb_exception_error): Rename from
3516         gdb_exception_RETURN_MASK_ERROR.
3517         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3518         (gdb_quit_bad_alloc): Update.
3519         * aarch64-tdep.c: Update.
3520         * ada-lang.c: Update.
3521         * ada-typeprint.c: Update.
3522         * ada-valprint.c: Update.
3523         * amd64-tdep.c: Update.
3524         * arch-utils.c: Update.
3525         * break-catch-throw.c: Update.
3526         * breakpoint.c: Update.
3527         * btrace.c: Update.
3528         * c-varobj.c: Update.
3529         * cli/cli-cmds.c: Update.
3530         * cli/cli-interp.c: Update.
3531         * cli/cli-script.c: Update.
3532         * common/common-exceptions.c: Update.
3533         * common/new-op.c: Update.
3534         * common/selftest.c: Update.
3535         * compile/compile-c-symbols.c: Update.
3536         * compile/compile-cplus-symbols.c: Update.
3537         * compile/compile-object-load.c: Update.
3538         * compile/compile-object-run.c: Update.
3539         * completer.c: Update.
3540         * corelow.c: Update.
3541         * cp-abi.c: Update.
3542         * cp-support.c: Update.
3543         * cp-valprint.c: Update.
3544         * darwin-nat.c: Update.
3545         * disasm-selftests.c: Update.
3546         * dtrace-probe.c: Update.
3547         * dwarf-index-cache.c: Update.
3548         * dwarf-index-write.c: Update.
3549         * dwarf2-frame-tailcall.c: Update.
3550         * dwarf2-frame.c: Update.
3551         * dwarf2loc.c: Update.
3552         * dwarf2read.c: Update.
3553         * eval.c: Update.
3554         * event-loop.c: Update.
3555         * event-top.c: Update.
3556         * exec.c: Update.
3557         * f-valprint.c: Update.
3558         * fbsd-tdep.c: Update.
3559         * frame-unwind.c: Update.
3560         * frame.c: Update.
3561         * gdbtypes.c: Update.
3562         * gnu-v3-abi.c: Update.
3563         * guile/guile-internal.h: Update.
3564         * guile/scm-block.c: Update.
3565         * guile/scm-breakpoint.c: Update.
3566         * guile/scm-cmd.c: Update.
3567         * guile/scm-disasm.c: Update.
3568         * guile/scm-frame.c: Update.
3569         * guile/scm-lazy-string.c: Update.
3570         * guile/scm-math.c: Update.
3571         * guile/scm-param.c: Update.
3572         * guile/scm-ports.c: Update.
3573         * guile/scm-pretty-print.c: Update.
3574         * guile/scm-symbol.c: Update.
3575         * guile/scm-symtab.c: Update.
3576         * guile/scm-type.c: Update.
3577         * guile/scm-value.c: Update.
3578         * i386-linux-tdep.c: Update.
3579         * i386-tdep.c: Update.
3580         * inf-loop.c: Update.
3581         * infcall.c: Update.
3582         * infcmd.c: Update.
3583         * infrun.c: Update.
3584         * jit.c: Update.
3585         * language.c: Update.
3586         * linespec.c: Update.
3587         * linux-fork.c: Update.
3588         * linux-nat.c: Update.
3589         * linux-tdep.c: Update.
3590         * linux-thread-db.c: Update.
3591         * main.c: Update.
3592         * mi/mi-cmd-break.c: Update.
3593         * mi/mi-cmd-stack.c: Update.
3594         * mi/mi-interp.c: Update.
3595         * mi/mi-main.c: Update.
3596         * objc-lang.c: Update.
3597         * p-valprint.c: Update.
3598         * parse.c: Update.
3599         * ppc-linux-tdep.c: Update.
3600         * printcmd.c: Update.
3601         * python/py-arch.c: Update.
3602         * python/py-breakpoint.c: Update.
3603         * python/py-cmd.c: Update.
3604         * python/py-finishbreakpoint.c: Update.
3605         * python/py-frame.c: Update.
3606         * python/py-framefilter.c: Update.
3607         * python/py-gdb-readline.c: Update.
3608         * python/py-inferior.c: Update.
3609         * python/py-infthread.c: Update.
3610         * python/py-lazy-string.c: Update.
3611         * python/py-linetable.c: Update.
3612         * python/py-objfile.c: Update.
3613         * python/py-param.c: Update.
3614         * python/py-prettyprint.c: Update.
3615         * python/py-progspace.c: Update.
3616         * python/py-record-btrace.c: Update.
3617         * python/py-record.c: Update.
3618         * python/py-symbol.c: Update.
3619         * python/py-type.c: Update.
3620         * python/py-unwind.c: Update.
3621         * python/py-utils.c: Update.
3622         * python/py-value.c: Update.
3623         * python/python.c: Update.
3624         * record-btrace.c: Update.
3625         * record-full.c: Update.
3626         * remote-fileio.c: Update.
3627         * remote.c: Update.
3628         * riscv-tdep.c: Update.
3629         * rs6000-aix-tdep.c: Update.
3630         * rs6000-tdep.c: Update.
3631         * rust-exp.y: Update.
3632         * rust-lang.c: Update.
3633         * s390-tdep.c: Update.
3634         * selftest-arch.c: Update.
3635         * solib-dsbt.c: Update.
3636         * solib-frv.c: Update.
3637         * solib-spu.c: Update.
3638         * solib-svr4.c: Update.
3639         * solib.c: Update.
3640         * sparc64-linux-tdep.c: Update.
3641         * stack.c: Update.
3642         * symfile-mem.c: Update.
3643         * symmisc.c: Update.
3644         * target.c: Update.
3645         * thread.c: Update.
3646         * top.c: Update.
3647         * tracefile-tfile.c: Update.
3648         * tui/tui.c: Update.
3649         * typeprint.c: Update.
3650         * unittests/cli-utils-selftests.c: Update.
3651         * unittests/parse-connection-spec-selftests.c: Update.
3652         * valops.c: Update.
3653         * valprint.c: Update.
3654         * value.c: Update.
3655         * varobj.c: Update.
3656         * windows-nat.c: Update.
3657         * x86-linux-nat.c: Update.
3658         * xml-support.c: Update.
3659
3660 2019-04-08  Tom Tromey  <tom@tromey.com>
3661
3662         * xml-support.c: Use C++ exception handling.
3663         * x86-linux-nat.c: Use C++ exception handling.
3664         * windows-nat.c: Use C++ exception handling.
3665         * varobj.c: Use C++ exception handling.
3666         * value.c: Use C++ exception handling.
3667         * valprint.c: Use C++ exception handling.
3668         * valops.c: Use C++ exception handling.
3669         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3670         handling.
3671         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3672         * typeprint.c: Use C++ exception handling.
3673         * tui/tui.c: Use C++ exception handling.
3674         * tracefile-tfile.c: Use C++ exception handling.
3675         * top.c: Use C++ exception handling.
3676         * thread.c: Use C++ exception handling.
3677         * target.c: Use C++ exception handling.
3678         * symmisc.c: Use C++ exception handling.
3679         * symfile-mem.c: Use C++ exception handling.
3680         * stack.c: Use C++ exception handling.
3681         * sparc64-linux-tdep.c: Use C++ exception handling.
3682         * solib.c: Use C++ exception handling.
3683         * solib-svr4.c: Use C++ exception handling.
3684         * solib-spu.c: Use C++ exception handling.
3685         * solib-frv.c: Use C++ exception handling.
3686         * solib-dsbt.c: Use C++ exception handling.
3687         * selftest-arch.c: Use C++ exception handling.
3688         * s390-tdep.c: Use C++ exception handling.
3689         * rust-lang.c: Use C++ exception handling.
3690         * rust-exp.y: Use C++ exception handling.
3691         * rs6000-tdep.c: Use C++ exception handling.
3692         * rs6000-aix-tdep.c: Use C++ exception handling.
3693         * riscv-tdep.c: Use C++ exception handling.
3694         * remote.c: Use C++ exception handling.
3695         * remote-fileio.c: Use C++ exception handling.
3696         * record-full.c: Use C++ exception handling.
3697         * record-btrace.c: Use C++ exception handling.
3698         * python/python.c: Use C++ exception handling.
3699         * python/py-value.c: Use C++ exception handling.
3700         * python/py-utils.c: Use C++ exception handling.
3701         * python/py-unwind.c: Use C++ exception handling.
3702         * python/py-type.c: Use C++ exception handling.
3703         * python/py-symbol.c: Use C++ exception handling.
3704         * python/py-record.c: Use C++ exception handling.
3705         * python/py-record-btrace.c: Use C++ exception handling.
3706         * python/py-progspace.c: Use C++ exception handling.
3707         * python/py-prettyprint.c: Use C++ exception handling.
3708         * python/py-param.c: Use C++ exception handling.
3709         * python/py-objfile.c: Use C++ exception handling.
3710         * python/py-linetable.c: Use C++ exception handling.
3711         * python/py-lazy-string.c: Use C++ exception handling.
3712         * python/py-infthread.c: Use C++ exception handling.
3713         * python/py-inferior.c: Use C++ exception handling.
3714         * python/py-gdb-readline.c: Use C++ exception handling.
3715         * python/py-framefilter.c: Use C++ exception handling.
3716         * python/py-frame.c: Use C++ exception handling.
3717         * python/py-finishbreakpoint.c: Use C++ exception handling.
3718         * python/py-cmd.c: Use C++ exception handling.
3719         * python/py-breakpoint.c: Use C++ exception handling.
3720         * python/py-arch.c: Use C++ exception handling.
3721         * printcmd.c: Use C++ exception handling.
3722         * ppc-linux-tdep.c: Use C++ exception handling.
3723         * parse.c: Use C++ exception handling.
3724         * p-valprint.c: Use C++ exception handling.
3725         * objc-lang.c: Use C++ exception handling.
3726         * mi/mi-main.c: Use C++ exception handling.
3727         * mi/mi-interp.c: Use C++ exception handling.
3728         * mi/mi-cmd-stack.c: Use C++ exception handling.
3729         * mi/mi-cmd-break.c: Use C++ exception handling.
3730         * main.c: Use C++ exception handling.
3731         * linux-thread-db.c: Use C++ exception handling.
3732         * linux-tdep.c: Use C++ exception handling.
3733         * linux-nat.c: Use C++ exception handling.
3734         * linux-fork.c: Use C++ exception handling.
3735         * linespec.c: Use C++ exception handling.
3736         * language.c: Use C++ exception handling.
3737         * jit.c: Use C++ exception handling.
3738         * infrun.c: Use C++ exception handling.
3739         * infcmd.c: Use C++ exception handling.
3740         * infcall.c: Use C++ exception handling.
3741         * inf-loop.c: Use C++ exception handling.
3742         * i386-tdep.c: Use C++ exception handling.
3743         * i386-linux-tdep.c: Use C++ exception handling.
3744         * guile/scm-value.c: Use C++ exception handling.
3745         * guile/scm-type.c: Use C++ exception handling.
3746         * guile/scm-symtab.c: Use C++ exception handling.
3747         * guile/scm-symbol.c: Use C++ exception handling.
3748         * guile/scm-pretty-print.c: Use C++ exception handling.
3749         * guile/scm-ports.c: Use C++ exception handling.
3750         * guile/scm-param.c: Use C++ exception handling.
3751         * guile/scm-math.c: Use C++ exception handling.
3752         * guile/scm-lazy-string.c: Use C++ exception handling.
3753         * guile/scm-frame.c: Use C++ exception handling.
3754         * guile/scm-disasm.c: Use C++ exception handling.
3755         * guile/scm-cmd.c: Use C++ exception handling.
3756         * guile/scm-breakpoint.c: Use C++ exception handling.
3757         * guile/scm-block.c: Use C++ exception handling.
3758         * guile/guile-internal.h: Use C++ exception handling.
3759         * gnu-v3-abi.c: Use C++ exception handling.
3760         * gdbtypes.c: Use C++ exception handling.
3761         * frame.c: Use C++ exception handling.
3762         * frame-unwind.c: Use C++ exception handling.
3763         * fbsd-tdep.c: Use C++ exception handling.
3764         * f-valprint.c: Use C++ exception handling.
3765         * exec.c: Use C++ exception handling.
3766         * event-top.c: Use C++ exception handling.
3767         * event-loop.c: Use C++ exception handling.
3768         * eval.c: Use C++ exception handling.
3769         * dwarf2read.c: Use C++ exception handling.
3770         * dwarf2loc.c: Use C++ exception handling.
3771         * dwarf2-frame.c: Use C++ exception handling.
3772         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3773         * dwarf-index-write.c: Use C++ exception handling.
3774         * dwarf-index-cache.c: Use C++ exception handling.
3775         * dtrace-probe.c: Use C++ exception handling.
3776         * disasm-selftests.c: Use C++ exception handling.
3777         * darwin-nat.c: Use C++ exception handling.
3778         * cp-valprint.c: Use C++ exception handling.
3779         * cp-support.c: Use C++ exception handling.
3780         * cp-abi.c: Use C++ exception handling.
3781         * corelow.c: Use C++ exception handling.
3782         * completer.c: Use C++ exception handling.
3783         * compile/compile-object-run.c: Use C++ exception handling.
3784         * compile/compile-object-load.c: Use C++ exception handling.
3785         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3786         * compile/compile-c-symbols.c: Use C++ exception handling.
3787         * common/selftest.c: Use C++ exception handling.
3788         * common/new-op.c: Use C++ exception handling.
3789         * cli/cli-script.c: Use C++ exception handling.
3790         * cli/cli-interp.c: Use C++ exception handling.
3791         * cli/cli-cmds.c: Use C++ exception handling.
3792         * c-varobj.c: Use C++ exception handling.
3793         * btrace.c: Use C++ exception handling.
3794         * breakpoint.c: Use C++ exception handling.
3795         * break-catch-throw.c: Use C++ exception handling.
3796         * arch-utils.c: Use C++ exception handling.
3797         * amd64-tdep.c: Use C++ exception handling.
3798         * ada-valprint.c: Use C++ exception handling.
3799         * ada-typeprint.c: Use C++ exception handling.
3800         * ada-lang.c: Use C++ exception handling.
3801         * aarch64-tdep.c: Use C++ exception handling.
3802
3803 2019-04-08  Tom Tromey  <tom@tromey.com>
3804
3805         * xml-support.c (gdb_xml_parser::parse): Update.
3806         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3807         * value.c (show_convenience): Update.
3808         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3809         (test_parse_flags_qcs): Update.
3810         * thread.c (thr_try_catch_cmd): Update.
3811         * target.c (target_translate_tls_address): Update.
3812         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3813         (info_frame_command_core, frame_apply_command_count): Update.
3814         * rust-exp.y (rust_lex_exception_test): Update.
3815         * riscv-tdep.c (riscv_print_one_register_info): Update.
3816         * remote.c (remote_target::enable_btrace): Update.
3817         * record-btrace.c (record_btrace_enable_warn): Update.
3818         * python/py-utils.c (gdbpy_convert_exception): Update.
3819         * printcmd.c (do_one_display, print_variable_and_value): Update.
3820         * mi/mi-main.c (mi_print_exception): Update.
3821         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3822         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3823         * linux-nat.c (linux_nat_target::attach): Update.
3824         * linux-fork.c (class scoped_switch_fork_info): Update.
3825         * infrun.c (displaced_step_prepare): Update.
3826         * infcall.c (call_function_by_hand_dummy): Update.
3827         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3828         * gnu-v3-abi.c (print_one_vtable): Update.
3829         * frame.c (get_prev_frame_always): Update.
3830         * f-valprint.c (info_common_command_for_block): Update.
3831         * exec.c (try_open_exec_file): Update.
3832         * exceptions.c (print_exception, exception_print)
3833         (exception_fprintf, exception_print_same): Update.
3834         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3835         * dwarf-index-cache.c (index_cache::store)
3836         (index_cache::lookup_gdb_index): Update.
3837         * darwin-nat.c (maybe_cache_shell): Update.
3838         * cp-valprint.c (cp_print_value_fields): Update.
3839         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3840         (gcc_cplus_symbol_address): Update.
3841         * compile/compile-c-symbols.c (gcc_convert_symbol)
3842         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3843         * common/selftest.c: Update.
3844         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3845         a std::string.
3846         (exception_try_scope_entry, exception_try_scope_exit): Don't
3847         declare.
3848         (struct exception_try_scope): Remove.
3849         (TRY): Don't use exception_try_scope.
3850         (struct gdb_exception): Add constructor, operator=.
3851         <what>: New method.
3852         (struct gdb_exception_RETURN_MASK_ALL)
3853         (struct gdb_exception_RETURN_MASK_ERROR)
3854         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3855         (struct gdb_quit_bad_alloc): Update.
3856         * common/common-exceptions.c (exception_none): Change
3857         initializer.
3858         (struct catcher) <state, exception>: Initialize inline.
3859         <prev>: Remove member.
3860         (current_catcher): Remove.
3861         (catchers): New global.
3862         (exceptions_state_mc_init): Simplify.
3863         (catcher_pop): Remove.
3864         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3865         (try_scope_depth, exception_try_scope_entry)
3866         (exception_try_scope_exit): Remove.
3867         (throw_exception_sjlj): Update.
3868         (exception_messages, exception_messages_size): Remove.
3869         (throw_it): Simplify.
3870         (gdb_exception_sliced_copy): Remove.
3871         (throw_exception_cxx): Update.
3872         * cli/cli-script.c (script_from_file): Update.
3873         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3874         Update.
3875         * ada-valprint.c (ada_val_print): Update.
3876         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3877         (create_excep_cond_exprs): Update.
3878
3879 2019-04-08  Tom Tromey  <tom@tromey.com>
3880
3881         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3882         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3883         (TRY, CATCH, END_CATCH): Remove some definitions.
3884         * common/common-exceptions.c: Don't use GDB_XCPT.
3885         (catcher_list_size): Remove.
3886         (throw_exception, throw_it): Simplify.
3887
3888 2019-04-05  Tom Tromey  <tom@tromey.com>
3889
3890         Revert the header-sorting patch.
3891         * ft32-tdep.c: Revert.
3892         * frv-tdep.c: Revert.
3893         * frv-linux-tdep.c: Revert.
3894         * frame.c: Revert.
3895         * frame-unwind.c: Revert.
3896         * frame-base.c: Revert.
3897         * fork-child.c: Revert.
3898         * findvar.c: Revert.
3899         * findcmd.c: Revert.
3900         * filesystem.c: Revert.
3901         * filename-seen-cache.h: Revert.
3902         * filename-seen-cache.c: Revert.
3903         * fbsd-tdep.c: Revert.
3904         * fbsd-nat.h: Revert.
3905         * fbsd-nat.c: Revert.
3906         * f-valprint.c: Revert.
3907         * f-typeprint.c: Revert.
3908         * f-lang.c: Revert.
3909         * extension.h: Revert.
3910         * extension.c: Revert.
3911         * extension-priv.h: Revert.
3912         * expprint.c: Revert.
3913         * exec.h: Revert.
3914         * exec.c: Revert.
3915         * exceptions.c: Revert.
3916         * event-top.c: Revert.
3917         * event-loop.c: Revert.
3918         * eval.c: Revert.
3919         * elfread.c: Revert.
3920         * dwarf2read.h: Revert.
3921         * dwarf2read.c: Revert.
3922         * dwarf2loc.c: Revert.
3923         * dwarf2expr.h: Revert.
3924         * dwarf2expr.c: Revert.
3925         * dwarf2-frame.c: Revert.
3926         * dwarf2-frame-tailcall.c: Revert.
3927         * dwarf-index-write.h: Revert.
3928         * dwarf-index-write.c: Revert.
3929         * dwarf-index-common.c: Revert.
3930         * dwarf-index-cache.h: Revert.
3931         * dwarf-index-cache.c: Revert.
3932         * dummy-frame.c: Revert.
3933         * dtrace-probe.c: Revert.
3934         * disasm.h: Revert.
3935         * disasm.c: Revert.
3936         * disasm-selftests.c: Revert.
3937         * dictionary.c: Revert.
3938         * dicos-tdep.c: Revert.
3939         * demangle.c: Revert.
3940         * dcache.h: Revert.
3941         * dcache.c: Revert.
3942         * darwin-nat.h: Revert.
3943         * darwin-nat.c: Revert.
3944         * darwin-nat-info.c: Revert.
3945         * d-valprint.c: Revert.
3946         * d-namespace.c: Revert.
3947         * d-lang.c: Revert.
3948         * ctf.c: Revert.
3949         * csky-tdep.c: Revert.
3950         * csky-linux-tdep.c: Revert.
3951         * cris-tdep.c: Revert.
3952         * cris-linux-tdep.c: Revert.
3953         * cp-valprint.c: Revert.
3954         * cp-support.c: Revert.
3955         * cp-namespace.c: Revert.
3956         * cp-abi.c: Revert.
3957         * corelow.c: Revert.
3958         * corefile.c: Revert.
3959         * continuations.c: Revert.
3960         * completer.h: Revert.
3961         * completer.c: Revert.
3962         * complaints.c: Revert.
3963         * coffread.c: Revert.
3964         * coff-pe-read.c: Revert.
3965         * cli-out.h: Revert.
3966         * cli-out.c: Revert.
3967         * charset.c: Revert.
3968         * c-varobj.c: Revert.
3969         * c-valprint.c: Revert.
3970         * c-typeprint.c: Revert.
3971         * c-lang.c: Revert.
3972         * buildsym.c: Revert.
3973         * buildsym-legacy.c: Revert.
3974         * build-id.h: Revert.
3975         * build-id.c: Revert.
3976         * btrace.c: Revert.
3977         * bsd-uthread.c: Revert.
3978         * breakpoint.h: Revert.
3979         * breakpoint.c: Revert.
3980         * break-catch-throw.c: Revert.
3981         * break-catch-syscall.c: Revert.
3982         * break-catch-sig.c: Revert.
3983         * blockframe.c: Revert.
3984         * block.c: Revert.
3985         * bfin-tdep.c: Revert.
3986         * bfin-linux-tdep.c: Revert.
3987         * bfd-target.c: Revert.
3988         * bcache.c: Revert.
3989         * ax-general.c: Revert.
3990         * ax-gdb.h: Revert.
3991         * ax-gdb.c: Revert.
3992         * avr-tdep.c: Revert.
3993         * auxv.c: Revert.
3994         * auto-load.c: Revert.
3995         * arm-wince-tdep.c: Revert.
3996         * arm-tdep.c: Revert.
3997         * arm-symbian-tdep.c: Revert.
3998         * arm-pikeos-tdep.c: Revert.
3999         * arm-obsd-tdep.c: Revert.
4000         * arm-nbsd-tdep.c: Revert.
4001         * arm-nbsd-nat.c: Revert.
4002         * arm-linux-tdep.c: Revert.
4003         * arm-linux-nat.c: Revert.
4004         * arm-fbsd-tdep.c: Revert.
4005         * arm-fbsd-nat.c: Revert.
4006         * arm-bsd-tdep.c: Revert.
4007         * arch-utils.c: Revert.
4008         * arc-tdep.c: Revert.
4009         * arc-newlib-tdep.c: Revert.
4010         * annotate.h: Revert.
4011         * annotate.c: Revert.
4012         * amd64-windows-tdep.c: Revert.
4013         * amd64-windows-nat.c: Revert.
4014         * amd64-tdep.c: Revert.
4015         * amd64-sol2-tdep.c: Revert.
4016         * amd64-obsd-tdep.c: Revert.
4017         * amd64-obsd-nat.c: Revert.
4018         * amd64-nbsd-tdep.c: Revert.
4019         * amd64-nbsd-nat.c: Revert.
4020         * amd64-nat.c: Revert.
4021         * amd64-linux-tdep.c: Revert.
4022         * amd64-linux-nat.c: Revert.
4023         * amd64-fbsd-tdep.c: Revert.
4024         * amd64-fbsd-nat.c: Revert.
4025         * amd64-dicos-tdep.c: Revert.
4026         * amd64-darwin-tdep.c: Revert.
4027         * amd64-bsd-nat.c: Revert.
4028         * alpha-tdep.c: Revert.
4029         * alpha-obsd-tdep.c: Revert.
4030         * alpha-nbsd-tdep.c: Revert.
4031         * alpha-mdebug-tdep.c: Revert.
4032         * alpha-linux-tdep.c: Revert.
4033         * alpha-linux-nat.c: Revert.
4034         * alpha-bsd-tdep.c: Revert.
4035         * alpha-bsd-nat.c: Revert.
4036         * aix-thread.c: Revert.
4037         * agent.c: Revert.
4038         * addrmap.c: Revert.
4039         * ada-varobj.c: Revert.
4040         * ada-valprint.c: Revert.
4041         * ada-typeprint.c: Revert.
4042         * ada-tasks.c: Revert.
4043         * ada-lang.c: Revert.
4044         * aarch64-tdep.c: Revert.
4045         * aarch64-ravenscar-thread.c: Revert.
4046         * aarch64-newlib-tdep.c: Revert.
4047         * aarch64-linux-tdep.c: Revert.
4048         * aarch64-linux-nat.c: Revert.
4049         * aarch64-fbsd-tdep.c: Revert.
4050         * aarch64-fbsd-nat.c: Revert.
4051         * aarch32-linux-nat.c: Revert.
4052
4053 2019-04-05  Tom Tromey  <tom@tromey.com>
4054
4055         * ft32-tdep.c: Sort headers.
4056         * frv-tdep.c: Sort headers.
4057         * frv-linux-tdep.c: Sort headers.
4058         * frame.c: Sort headers.
4059         * frame-unwind.c: Sort headers.
4060         * frame-base.c: Sort headers.
4061         * fork-child.c: Sort headers.
4062         * findvar.c: Sort headers.
4063         * findcmd.c: Sort headers.
4064         * filesystem.c: Sort headers.
4065         * filename-seen-cache.h: Sort headers.
4066         * filename-seen-cache.c: Sort headers.
4067         * fbsd-tdep.c: Sort headers.
4068         * fbsd-nat.h: Sort headers.
4069         * fbsd-nat.c: Sort headers.
4070         * f-valprint.c: Sort headers.
4071         * f-typeprint.c: Sort headers.
4072         * f-lang.c: Sort headers.
4073         * extension.h: Sort headers.
4074         * extension.c: Sort headers.
4075         * extension-priv.h: Sort headers.
4076         * expprint.c: Sort headers.
4077         * exec.h: Sort headers.
4078         * exec.c: Sort headers.
4079         * exceptions.c: Sort headers.
4080         * event-top.c: Sort headers.
4081         * event-loop.c: Sort headers.
4082         * eval.c: Sort headers.
4083         * elfread.c: Sort headers.
4084         * dwarf2read.h: Sort headers.
4085         * dwarf2read.c: Sort headers.
4086         * dwarf2loc.c: Sort headers.
4087         * dwarf2expr.h: Sort headers.
4088         * dwarf2expr.c: Sort headers.
4089         * dwarf2-frame.c: Sort headers.
4090         * dwarf2-frame-tailcall.c: Sort headers.
4091         * dwarf-index-write.h: Sort headers.
4092         * dwarf-index-write.c: Sort headers.
4093         * dwarf-index-common.c: Sort headers.
4094         * dwarf-index-cache.h: Sort headers.
4095         * dwarf-index-cache.c: Sort headers.
4096         * dummy-frame.c: Sort headers.
4097         * dtrace-probe.c: Sort headers.
4098         * disasm.h: Sort headers.
4099         * disasm.c: Sort headers.
4100         * disasm-selftests.c: Sort headers.
4101         * dictionary.c: Sort headers.
4102         * dicos-tdep.c: Sort headers.
4103         * demangle.c: Sort headers.
4104         * dcache.h: Sort headers.
4105         * dcache.c: Sort headers.
4106         * darwin-nat.h: Sort headers.
4107         * darwin-nat.c: Sort headers.
4108         * darwin-nat-info.c: Sort headers.
4109         * d-valprint.c: Sort headers.
4110         * d-namespace.c: Sort headers.
4111         * d-lang.c: Sort headers.
4112         * ctf.c: Sort headers.
4113         * csky-tdep.c: Sort headers.
4114         * csky-linux-tdep.c: Sort headers.
4115         * cris-tdep.c: Sort headers.
4116         * cris-linux-tdep.c: Sort headers.
4117         * cp-valprint.c: Sort headers.
4118         * cp-support.c: Sort headers.
4119         * cp-namespace.c: Sort headers.
4120         * cp-abi.c: Sort headers.
4121         * corelow.c: Sort headers.
4122         * corefile.c: Sort headers.
4123         * continuations.c: Sort headers.
4124         * completer.h: Sort headers.
4125         * completer.c: Sort headers.
4126         * complaints.c: Sort headers.
4127         * coffread.c: Sort headers.
4128         * coff-pe-read.c: Sort headers.
4129         * cli-out.h: Sort headers.
4130         * cli-out.c: Sort headers.
4131         * charset.c: Sort headers.
4132         * c-varobj.c: Sort headers.
4133         * c-valprint.c: Sort headers.
4134         * c-typeprint.c: Sort headers.
4135         * c-lang.c: Sort headers.
4136         * buildsym.c: Sort headers.
4137         * buildsym-legacy.c: Sort headers.
4138         * build-id.h: Sort headers.
4139         * build-id.c: Sort headers.
4140         * btrace.c: Sort headers.
4141         * bsd-uthread.c: Sort headers.
4142         * breakpoint.h: Sort headers.
4143         * breakpoint.c: Sort headers.
4144         * break-catch-throw.c: Sort headers.
4145         * break-catch-syscall.c: Sort headers.
4146         * break-catch-sig.c: Sort headers.
4147         * blockframe.c: Sort headers.
4148         * block.c: Sort headers.
4149         * bfin-tdep.c: Sort headers.
4150         * bfin-linux-tdep.c: Sort headers.
4151         * bfd-target.c: Sort headers.
4152         * bcache.c: Sort headers.
4153         * ax-general.c: Sort headers.
4154         * ax-gdb.h: Sort headers.
4155         * ax-gdb.c: Sort headers.
4156         * avr-tdep.c: Sort headers.
4157         * auxv.c: Sort headers.
4158         * auto-load.c: Sort headers.
4159         * arm-wince-tdep.c: Sort headers.
4160         * arm-tdep.c: Sort headers.
4161         * arm-symbian-tdep.c: Sort headers.
4162         * arm-pikeos-tdep.c: Sort headers.
4163         * arm-obsd-tdep.c: Sort headers.
4164         * arm-nbsd-tdep.c: Sort headers.
4165         * arm-nbsd-nat.c: Sort headers.
4166         * arm-linux-tdep.c: Sort headers.
4167         * arm-linux-nat.c: Sort headers.
4168         * arm-fbsd-tdep.c: Sort headers.
4169         * arm-fbsd-nat.c: Sort headers.
4170         * arm-bsd-tdep.c: Sort headers.
4171         * arch-utils.c: Sort headers.
4172         * arc-tdep.c: Sort headers.
4173         * arc-newlib-tdep.c: Sort headers.
4174         * annotate.h: Sort headers.
4175         * annotate.c: Sort headers.
4176         * amd64-windows-tdep.c: Sort headers.
4177         * amd64-windows-nat.c: Sort headers.
4178         * amd64-tdep.c: Sort headers.
4179         * amd64-sol2-tdep.c: Sort headers.
4180         * amd64-obsd-tdep.c: Sort headers.
4181         * amd64-obsd-nat.c: Sort headers.
4182         * amd64-nbsd-tdep.c: Sort headers.
4183         * amd64-nbsd-nat.c: Sort headers.
4184         * amd64-nat.c: Sort headers.
4185         * amd64-linux-tdep.c: Sort headers.
4186         * amd64-linux-nat.c: Sort headers.
4187         * amd64-fbsd-tdep.c: Sort headers.
4188         * amd64-fbsd-nat.c: Sort headers.
4189         * amd64-dicos-tdep.c: Sort headers.
4190         * amd64-darwin-tdep.c: Sort headers.
4191         * amd64-bsd-nat.c: Sort headers.
4192         * alpha-tdep.c: Sort headers.
4193         * alpha-obsd-tdep.c: Sort headers.
4194         * alpha-nbsd-tdep.c: Sort headers.
4195         * alpha-mdebug-tdep.c: Sort headers.
4196         * alpha-linux-tdep.c: Sort headers.
4197         * alpha-linux-nat.c: Sort headers.
4198         * alpha-bsd-tdep.c: Sort headers.
4199         * alpha-bsd-nat.c: Sort headers.
4200         * aix-thread.c: Sort headers.
4201         * agent.c: Sort headers.
4202         * addrmap.c: Sort headers.
4203         * ada-varobj.c: Sort headers.
4204         * ada-valprint.c: Sort headers.
4205         * ada-typeprint.c: Sort headers.
4206         * ada-tasks.c: Sort headers.
4207         * ada-lang.c: Sort headers.
4208         * aarch64-tdep.c: Sort headers.
4209         * aarch64-ravenscar-thread.c: Sort headers.
4210         * aarch64-newlib-tdep.c: Sort headers.
4211         * aarch64-linux-tdep.c: Sort headers.
4212         * aarch64-linux-nat.c: Sort headers.
4213         * aarch64-fbsd-tdep.c: Sort headers.
4214         * aarch64-fbsd-nat.c: Sort headers.
4215         * aarch32-linux-nat.c: Sort headers.
4216
4217 2019-04-04  Tom Tromey  <tom@tromey.com>
4218
4219         * varobj.c (varobj_create): Update.
4220         * rust-exp.y (struct rust_parser) <update_innermost_block,
4221         lookup_symbol>: New methods.
4222         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4223         Rename.
4224         (rust_parser::rust_lookup_type)
4225         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4226         * printcmd.c (display_command, do_one_display): Update.
4227         * parser-defs.h (struct parser_state) <parser_state>: Add
4228         "tracker" parameter.
4229         (block_tracker): New member.
4230         (class innermost_block_tracker) <innermost_block_tracker>: Add
4231         "types" parameter.
4232         <reset>: Remove method.
4233         (innermost_block): Don't declare.
4234         (null_post_parser): Update.
4235         * parse.c (innermost_block): Remove global.
4236         (write_dollar_variable): Update.
4237         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4238         Remove "tracker_types" parameter.
4239         (parse_expression): Add "tracker" parameter.
4240         (parse_expression_for_completion): Update.
4241         (null_post_parser): Add "tracker" parameter.
4242         * p-exp.y: Update rules.
4243         * m2-exp.y: Update rules.
4244         * language.h (struct language_defn) <la_post_parser>: Add
4245         "tracker" parameter.
4246         * go-exp.y: Update rules.
4247         * f-exp.y: Update rules.
4248         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4249         parameter.
4250         * d-exp.y: Update rules.
4251         * c-exp.y: Update rules.
4252         * breakpoint.c (set_breakpoint_condition): Create an
4253         innermost_block_tracker.
4254         (watch_command_1): Likewise.
4255         * ada-lang.c (resolve): Add "tracker" parameter.
4256         (resolve_subexp): Likewise.
4257         * ada-exp.y (write_var_from_sym): Update.
4258
4259 2019-04-04  Tom Tromey  <tom@tromey.com>
4260
4261         * type-stack.h: New file.
4262         * type-stack.c: New file.
4263         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4264         type-stack.h.
4265         (insert_into_type_stack, insert_type, push_type, push_type_int)
4266         (insert_type_address_space, pop_type, pop_type_int)
4267         (pop_typelist, pop_type_stack, append_type_stack)
4268         (push_type_stack, get_type_stack, push_typelist)
4269         (follow_type_instance_flags, follow_types): Don't declare.
4270         * parse.c (type_stack): Remove global.
4271         (parse_exp_in_context): Update.
4272         (insert_into_type_stack, insert_type, push_type, push_type_int)
4273         (insert_type_address_space, pop_type, pop_type_int)
4274         (pop_typelist, pop_type_stack, append_type_stack)
4275         (push_type_stack, get_type_stack, push_typelist)
4276         (follow_type_instance_flags, follow_types): Remove (moved to
4277         type-stack.c).
4278         * f-exp.y (type_stack): New global.
4279         Update rules.
4280         (push_kind_type, f_parse): Update.
4281         * d-exp.y (type_stack): New global.
4282         Update rules.
4283         (d_parse): Update.
4284         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4285         Update rules.
4286         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4287         (HFILES_NO_SRCDIR): Add type-stack.h.
4288
4289 2019-04-04  Tom Tromey  <tom@tromey.com>
4290
4291         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4292         (rust_parser::convert_ast_to_expression, rust_parse)
4293         (rust_lex_test_completion, rust_lex_tests): Update.
4294         * parser-defs.h (struct expr_completion_state): New.
4295         (struct parser_state) <parser_state>: Add completion parameter.
4296         <mark_struct_expression, mark_completion_tag>: New methods.
4297         <parse_completion, m_completion_state>: New members.
4298         (prefixify_expression, null_post_parser): Update.
4299         (mark_struct_expression, mark_completion_tag): Don't declare.
4300         * parse.c (parse_completion, expout_last_struct)
4301         (expout_tag_completion_type, expout_completion_name): Remove
4302         globals.
4303         (parser_state::mark_struct_expression)
4304         (parser_state::mark_completion_tag): Now methods.
4305         (prefixify_expression): Add last_struct parameter.
4306         (prefixify_subexp): Likewise.
4307         (parse_exp_1): Update.
4308         (parse_exp_in_context): Add cstate parameter.  Update.
4309         (parse_expression_for_completion): Create an
4310         expr_completion_state.
4311         (null_post_parser): Add "completion" parameter.
4312         * p-exp.y: Update rules.
4313         (yylex): Update.
4314         * language.h (struct language_defn) <la_post_parser>: Add
4315         "completing" parameter.
4316         * go-exp.y: Update rules.
4317         (lex_one_token): Update.
4318         * expression.h (parse_completion): Don't declare.
4319         * d-exp.y: Update rules.
4320         (lex_one_token): Update rules.
4321         * c-exp.y: Update rules.
4322         (lex_one_token): Update.
4323         * ada-lang.c (resolve): Add "parse_completion" parameter.
4324         (resolve_subexp): Likewise.
4325         (ada_resolve_function): Likewise.
4326
4327 2019-04-04  Tom Tromey  <tom@tromey.com>
4328
4329         * parser-defs.h (struct parser_state) <start_arglist,
4330         end_arglist>: New methods.
4331         <arglist_len, m_funcall_chain>: New members.
4332         (arglist_len, start_arglist, end_arglist): Don't declare.
4333         * parse.c (arglist_len, funcall_chain): Remove global.
4334         (start_arglist, end_arglist): Remove functions.
4335         (parse_exp_in_context): Update.
4336         * p-exp.y: Update rules.
4337         * m2-exp.y: Update rules.
4338         * go-exp.y: Update rules.
4339         * f-exp.y: Update rules.
4340         * d-exp.y: Update rules.
4341         * c-exp.y: Update rules.
4342
4343 2019-04-04  Tom Tromey  <tom@tromey.com>
4344
4345         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4346         lex_operator, push_back>: New methods.
4347         Update all rules.
4348         (rust_parser::lex_hex, lex_escape): Rename and update.
4349         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4350         (rust_parser::lex_operator): Rename and update.
4351         (rust_parser::lex_number, rustyylex, rustyyerror)
4352         (rust_lex_test_init, rust_lex_test_sequence)
4353         (rust_lex_test_push_back, rust_lex_tests): Update.
4354         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4355         parameter.
4356         <lexptr, prev_lexptr>: New members.
4357         (lexptr, prev_lexptr): Don't declare.
4358         * parse.c (lexptr, prev_lexptr): Remove globals.
4359         (parse_exp_in_context): Update.
4360         * p-exp.y (yylex, yyerror): Update.
4361         * m2-exp.y (parse_number, yylex, yyerror): Update.
4362         * go-exp.y (lex_one_token, yyerror): Update.
4363         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4364         * d-exp.y (lex_one_token, yyerror): Update.
4365         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4366         (lex_one_token, yyerror): Update.
4367         * ada-lex.l (YY_INPUT): Update.
4368         (rewind_to_char): Update.
4369         * ada-exp.y (yyerror): Update.
4370
4371 2019-04-04  Tom Tromey  <tom@tromey.com>
4372
4373         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4374         * parser-defs.h (struct parser_state) <parser_state>: Add new
4375         parameter.
4376         <comma_terminates>: New member.
4377         (comma_terminates): Don't declare global.
4378         * parse.c (comma_terminates): Remove global.
4379         (parse_exp_in_context): Update.
4380         * p-exp.y (yylex): Update.
4381         * m2-exp.y (yylex): Update.
4382         * go-exp.y (lex_one_token): Update.
4383         * f-exp.y (yylex): Update.
4384         * d-exp.y (lex_one_token): Update.
4385         * c-exp.y (lex_one_token): Update.
4386         * ada-lex.l: Update.
4387
4388 2019-04-04  Tom Tromey  <tom@tromey.com>
4389
4390         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4391         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4392         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4393         * parser-defs.h (paren_depth): Don't declare.
4394         * parse.c (paren_depth): Remove global.
4395         (parse_exp_in_context): Update.
4396         * p-exp.y (paren_depth): New global.
4397         (pascal_parse): Initialize it.
4398         * m2-exp.y (paren_depth): New global.
4399         (m2_parse): Initialize it.
4400         * go-exp.y (paren_depth): New global.
4401         (go_parse): Initialize it.
4402         * f-exp.y (paren_depth): New global.
4403         (f_parse): Initialize it.
4404         * d-exp.y (paren_depth): New global.
4405         (d_parse): Initialize it.
4406         * c-exp.y (paren_depth): New global.
4407         (c_parse): Initialize it.
4408         * ada-lex.l (paren_depth): New global.
4409         (lexer_init): Initialize it.
4410
4411 2019-04-04  Tom Tromey  <tom@tromey.com>
4412
4413         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4414         (rust_parser::convert_ast_to_type)
4415         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4416         * parser-defs.h (struct parser_state) <parser_state>: Add
4417         parameters.  Initialize new members.
4418         <expression_context_block, expression_context_pc>: New members.
4419         * parse.c (expression_context_block, expression_context_pc):
4420         Remove globals.
4421         (parse_exp_in_context): Update.
4422         * p-exp.y: Update all rules.
4423         (yylex): Update.
4424         * m2-exp.y: Update all rules.
4425         (yylex): Update.
4426         * go-exp.y (yylex): Update.
4427         * f-exp.y (yylex): Update.
4428         * d-exp.y: Update all rules.
4429         (yylex): Update.
4430         * c-exp.y: Update all rules.
4431         (lex_one_token, classify_name, yylex, c_parse): Update.
4432         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4433
4434 2019-04-04  Tom Tromey  <tom@tromey.com>
4435
4436         * gdbarch.h, gdbarch.c: Rebuild.
4437         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4438         * stap-probe.h:
4439         (struct stap_parse_info): Replace "parser_state" with
4440         "expr_builder".
4441         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4442         (parser_state): New class.
4443         * parse.c (expr_builder): Rename.
4444         (expr_builder::release): Rename.
4445         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4446         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4447         (write_exp_elt_longcst, write_exp_elt_floatcst)
4448         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4449         (write_exp_string_vector, write_exp_bitstring)
4450         (write_exp_msymbol, mark_struct_expression)
4451         (write_dollar_variable)
4452         (insert_type_address_space, increase_expout_size): Replace
4453         "parser_state" with "expr_builder".
4454         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4455         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4456         "parser_state" with "expr_builder".
4457
4458 2019-04-04  Tom Tromey  <tom@tromey.com>
4459
4460         * rust-exp.y: Replace "parse_language" with method call.
4461         * p-exp.y:
4462         (yylex): Replace "parse_language" with method call.
4463         * m2-exp.y:
4464         (yylex): Replace "parse_language" with method call.
4465         * go-exp.y (classify_name): Replace "parse_language" with method
4466         call.
4467         * f-exp.y (yylex): Replace "parse_language" with method call.
4468         * d-exp.y (lex_one_token): Replace "parse_language" with method
4469         call.
4470         * c-exp.y:
4471         (lex_one_token, classify_name, yylex): Replace "parse_language"
4472         with method call.
4473         * ada-exp.y (find_primitive_type, type_char)
4474         (type_system_address): Replace "parse_language" with method call.
4475
4476 2019-04-04  Tom Tromey  <tom@tromey.com>
4477
4478         * rust-exp.y: Replace "parse_gdbarch" with method call.
4479         * parse.c (write_dollar_variable, insert_type_address_space):
4480         Replace "parse_gdbarch" with method call.
4481         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4482         call.
4483         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4484         call.
4485         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4486         "parse_gdbarch" with method call.
4487         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4488         with method call.
4489         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4490         "parse_gdbarch" with method call.
4491         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4492         "parse_gdbarch" with method call.
4493         * c-exp.y (parse_type, parse_number, classify_name): Replace
4494         "parse_gdbarch" with method call.
4495         * ada-lex.l: Replace "parse_gdbarch" with method call.
4496         * ada-exp.y (parse_type, find_primitive_type, type_char)
4497         (type_system_address): Replace "parse_gdbarch" with method call.
4498
4499 2019-04-04  Tom Tromey  <tom@tromey.com>
4500
4501         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4502         * stap-probe.c (stap_parse_argument): Update.
4503         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4504         initial_size parameter.
4505         * rust-exp.y (rust_lex_tests): Update.
4506         * parse.c (parser_state): Update.
4507         (parse_exp_in_context): Update.
4508         * parser-defs.h (struct parser_state) <parser_state>: Remove
4509         "initial_size" parameter.
4510
4511 2019-04-04  Tom Tromey  <tom@tromey.com>
4512
4513         * parser-defs.h (increase_expout_size): Don't declare.
4514         * parse.c (increase_expout_size): Now static.
4515
4516 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4517
4518         * gnu-nat.c (gnu_nat_target::wait): Fix
4519         target_waitstatus_to_string call.
4520
4521 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * eval.c (evaluate_subexp_standard): Handle internal functions
4524         during Fortran function call handling.
4525
4526 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4527
4528         * NEWS: Mention new internal functions.
4529         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4530         (read_base_type): Use dwarf2_init_complex_target_type.
4531         * value.c (creal_internal_fn): New function.
4532         (cimag_internal_fn): New function.
4533         (_initialize_values): Register new internal functions.
4534
4535 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4536
4537         * infrun.c (stop_all_threads): If debug_infrun, always
4538         trace the wait status after wait_one, using
4539         target_waitstatus_to_string and target_pid_to_str.
4540         (handle_inferior_event): Replace various trace of
4541         wait status kind by a single trace.
4542         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4543         wait status kind image by target_waitstatus_to_string.
4544         * target/waitstatus.c (target_waitstatus_to_string): Fix
4545         obsolete comment.
4546
4547 2019-04-01  Tom Tromey  <tromey@adacore.com>
4548
4549         PR symtab/23331:
4550         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4551
4552 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4553             Pedro Alves  <palves@redhat.com>
4554
4555         * top.c (quit_force): Call 'finalize_values'.
4556         * value.c (finalize_values): New function.
4557         * value.h (finalize_values): Declare.
4558
4559 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4560
4561         * NEWS: Announce $_gdb_major and $_gdb_minor.
4562
4563         * top.c (init_gdb_version_vars): New function.
4564         (gdb_init): Call init_gdb_version_vars.
4565
4566 2019-03-29  Tom Tromey  <tromey@adacore.com>
4567
4568         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4569         help text.  Remove dead code.
4570
4571 2019-03-29  Keith Seitz  <keiths@redhat.com>
4572
4573         From Siddhesh Poyarekar:
4574         * f-lang.h (f77_get_upperbound): Return LONGEST.
4575         (f77_get_lowerbound): Likewise.
4576         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4577         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4578         print them.
4579         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4580         plongest to format print it.
4581         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4582         (f77_get_upperbound): Likewise.
4583         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4584         LOWER_BOUND to LONGEST.
4585         (f77_create_arrayprint_offset_tbl): Likewise.
4586
4587 2019-03-29  Keith Seitz  <keiths@redhat.com>
4588
4589         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4590         %s/pulongest for TYPE_LENGTH instead of %d in format
4591         strings.
4592         * ada-typerint.c (ada_print_type): Likewise.
4593         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4594         * compile/compile-c-support.c (generate_register_struct): Likewise.
4595         * gdbtypes.c (recursive_dump_type): Likewise.
4596         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4597         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4598         instead of %d in format strings.
4599         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4600         to std::min to ULONGEST.
4601         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4602         instead of %d in format strings.
4603         * tracepoint.c (info_scope_command): Likewise.
4604         * typeprint.c (print_offset_data::update)
4605         (print_offset_data::finish): Likewise.
4606         * xtensa-tdep.c (xtensa_store_return_value)
4607         (xtensa_push_dummy_call): Likewise.
4608
4609 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4610
4611         * windows-nat.c (display_selector): Fixed format specifications
4612         for 64-bit Cygwin.
4613
4614 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4615
4616         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4617
4618 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4619
4620         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4621         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4622         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4623         (nios2_linux_init_abi): Install it.
4624
4625 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4626
4627         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4628
4629 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4630
4631         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4632
4633 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4634             Tom Tromey  <tromey@adacore.com>
4635
4636         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4637
4638 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4639
4640         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4641         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4642         method to compute the bounds of range types. Also print "[evaluated]"
4643         if the bounds' values come from a dynamic evaluation.
4644
4645 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4648         whitespace when pretty printing is on.
4649
4650 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4651
4652         * ppc-linux-nat.c: Add include.
4653
4654 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4655
4656         * NEWS: Mention AArch64 Pointer Authentication.
4657
4658 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4659
4660         * arm-linux-nat.c: Add include.
4661
4662 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4663
4664         * source-cache.c (source_cache::get_source_lines): Re-read
4665         fullname after calling open_source_file.
4666
4667 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4668
4669         * NEWS: Mention TLS support for FreeBSD.
4670
4671 2019-03-25  Tom Tromey  <tromey@adacore.com>
4672
4673         * minsyms.c (BUNCH_SIZE): Update comment.
4674         (~minimal_symbol_reader): Remove old comment.
4675         (compact_minimal_symbols): Update comment.
4676         (minimal_symbol_reader::install): Remove old comment.  Update
4677         other comments.
4678
4679 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4680
4681         * s390-linux-nat.c: Add include.
4682
4683 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4684
4685         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4686         Call linux_get_hwcap.
4687         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4688         Likewise.
4689         (aarch64_linux_get_hwcap): Remove function.
4690         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4691         declaration.
4692         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4693         linux_get_hwcap.
4694         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4695         * linux-tdep.c (linux_get_hwcap): Add function.
4696         (linux_get_hwcap2): Likewise.
4697         * linux-tdep.h (linux_get_hwcap): Add declaration.
4698         (linux_get_hwcap2): Likewise.
4699         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4700         (ppc_linux_get_hwcap2): Likewise.
4701         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4702         linux_get_hwcap.
4703         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4704         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4705         (ppc_linux_nat_target::read_description): Likewise.
4706         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4707         * s390-linux-nat.c: Likewise.
4708         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4709
4710 2019-03-24  Tom Tromey  <tom@tromey.com>
4711
4712         * ada-lang.c (standard_lookup): Simplify initialization.
4713         (ada_lookup_symbol_nonlocal): Simplify return.
4714         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4715         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4716         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4717         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4718         initialization.
4719         * solib.c (solib_global_lookup): Simplify.
4720         * symtab.c (null_block_symbol): Remove.
4721         (symbol_cache_lookup): Simplify returns.
4722         (lookup_language_this): Simplify returns.
4723         (lookup_symbol_aux): Simplify return.
4724         (lookup_local_symbol): Simplify returns.
4725         (lookup_global_symbol_from_objfile): Simplify return.
4726         (lookup_symbol_in_objfile_symtabs)
4727         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4728         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4729         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4730         * cp-namespace.c (cp_lookup_bare_symbol)
4731         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4732         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4733         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4734         (cp_lookup_symbol_via_imports): Simplify initialization.
4735         (find_symbol_in_baseclass): Likewise.
4736         * symtab.h (null_block_symbol): Remove.
4737         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4738         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4739         (d_lookup_symbol_module): Likewise.
4740         (find_symbol_in_baseclass): Simplify initialization.
4741
4742 2019-03-24  Tom Tromey  <tom@tromey.com>
4743
4744         * expression.h: Don't include symtab.h.
4745         (struct block): Forward declare.
4746
4747 2019-03-24  Tom Tromey  <tom@tromey.com>
4748
4749         * c-exp.y (typebase): Remove casts.
4750         * gdbtypes.c (lookup_unsigned_typename, )
4751         (lookup_signed_typename): Remove cast.
4752         * eval.c (parse_to_comma_and_eval): Remove cast.
4753         * parse.c (write_dollar_variable): Remove cast.
4754         * block.h (struct block) <superblock>: Now const.
4755         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4756         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4757         (map_block): Make "block" const.
4758         * symfile.h (struct quick_symbol_functions)
4759         <map_matching_symbols>: Constify block argument to "callback".
4760         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4761         const.
4762         (find_pc_sect_compunit_symtab): Make "b" const.
4763         (find_symbol_at_address): Likewise.
4764         (search_symbols): Likewise.
4765         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4766         (dw2_debug_names_lookup_symbol): Likewise.
4767         (dw2_map_matching_symbols): Update.
4768         * p-valprint.c (pascal_val_print): Remove "block".
4769         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4770         (aux_add_nonlocal_symbols): Make "block" const.
4771         (resolve_subexp): Remove cast.
4772         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4773         const.
4774         (iterate_over_file_blocks): Likewise.
4775         * f-exp.y (%union) <bval>: Remove.
4776         * coffread.c (patch_opaque_types): Make "b" const.
4777         * spu-tdep.c (spu_catch_start): Make "block" const.
4778         * c-valprint.c (print_unpacked_pointer): Remove "block".
4779         * symmisc.c (dump_symtab_1): Make "b" const.
4780         (block_depth): Make "block" const.
4781         * d-exp.y (%union) <bval>: Remove.
4782         * cp-support.h (cp_lookup_rtti_type): Update.
4783         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4784         * psymtab.c (psym_lookup_symbol): Make "block" const.
4785         (maintenance_check_psymtabs): Make "b" const.
4786         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4787         (enumerate_locals, enumerate_args): Update.
4788         * python/py-symtab.c (stpy_global_block): Make "block" const.
4789         (stpy_static_block): Likewise.
4790         * inline-frame.c (block_starting_point_at): Make "new_block"
4791         const.
4792         * block.c (find_block_in_blockvector): Make return type const.
4793         (blockvector_for_pc_sect): Make "b" const.
4794         (find_block_in_blockvector): Make "b" const.
4795
4796 2019-03-23  Tom Tromey  <tom@tromey.com>
4797
4798         * varobj.c (varobj_create): Update.
4799         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4800         * printcmd.c (display_command, do_one_display): Don't reset
4801         innermost_block.
4802         * parser-defs.h (enum innermost_block_tracker_type): Move to
4803         expression.h.
4804         (innermost_block): Update comment.
4805         * parse.c (parse_exp_1): Add tracker_types parameter.
4806         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4807         tracker_types parameter.  Reset innermost_block.
4808         (parse_exp_in_context): Remove.
4809         (parse_expression_for_completion): Update.
4810         * objfiles.c (~objfile): Don't reset expression_context_block or
4811         innermost_block.
4812         * expression.h (enum innermost_block_tracker_type): Move from
4813         parser-defs.h.
4814         (parse_exp_1): Add tracker_types parameter.
4815         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4816         reset innermost_block.
4817
4818 2019-03-23  Tom Tromey  <tom@tromey.com>
4819
4820         * objfiles.h: Include bcache.h.
4821
4822 2019-03-23  Tom Tromey  <tom@tromey.com>
4823
4824         * linespec.c (get_current_search_block): Use
4825         scoped_restore_current_language.
4826         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4827
4828 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4829             Jiong Wang  <jiong.wang@arm.com>
4830
4831         * aarch64-linux-tdep.c
4832         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4833         section.
4834         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4835
4836 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4837             Jiong Wang  <jiong.wang@arm.com>
4838
4839         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4840         instructions.
4841         (aarch64_analyze_prologue_test): Add PACIASP test.
4842         (aarch64_prologue_prev_register): Unmask PC value.
4843
4844 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4845             Jiong Wang  <jiong.wang@arm.com>
4846
4847         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4848         (aarch64_dwarf2_prev_register): Unmask PC value.
4849         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4850         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4851         DW_CFA_AARCH64_negate_ra_state.
4852         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4853
4854 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4855             Jiong Wang  <jiong.wang@arm.com>
4856
4857         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4858         registers.
4859         (aarch64_pseudo_register_name): Likewise.
4860         (aarch64_pseudo_register_type): Likewise.
4861         (aarch64_pseudo_register_reggroup_p): Likewise.
4862         (aarch64_gdbarch_init): Add pauth registers.
4863         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4864         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4865         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4866         (struct gdbarch_tdep): Add regnum for ra_state.
4867
4868 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4869             Jiong Wang  <jiong.wang@arm.com>
4870
4871         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4872
4873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4874             Jiong Wang  <jiong.wang@arm.com>
4875
4876         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4877         function.
4878         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4879         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4880         (aarch64_gdbarch_init): Add puth registers.
4881         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4882         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4883         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4884
4885 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4886             Jiong Wang  <jiong.wang@arm.com>
4887
4888         * aarch64-linux-nat.c
4889         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4890         * aarch64-linux-tdep.c
4891         (aarch64_linux_core_read_description): Likewise.
4892         (aarch64_linux_get_hwcap): New function.
4893         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4894         (aarch64_linux_get_hwcap): New declaration.
4895
4896 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4897             Jiong Wang  <jiong.wang@arm.com>
4898
4899         * aarch64-linux-nat.c
4900         (aarch64_linux_nat_target::read_description): Add pauth param.
4901         * aarch64-linux-tdep.c
4902         (aarch64_linux_core_read_description): Likewise.
4903         * aarch64-tdep.c (struct target_desc): Add in pauth.
4904         (aarch64_read_description): Add pauth param.
4905         (aarch64_gdbarch_init): Likewise.
4906         * aarch64-tdep.h (aarch64_read_description): Likewise.
4907         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4908         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4909         * features/Makefile: Add new files.
4910         * features/aarch64-pauth.c: New file.
4911         * features/aarch64-pauth.xml: New file.
4912
4913 2019-03-20  Tom Tromey  <tromey@adacore.com>
4914
4915         * infrun.c (handle_inferior_event): Rename from
4916         handle_inferior_event_1.  Create a scoped_value_mark.
4917         (handle_inferior_event): Remove.
4918
4919 2019-03-19  Tom Tromey  <tromey@adacore.com>
4920
4921         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4922         * infrun.h (print_stop_event): Add "displays" parameter.
4923         * infrun.c (print_stop_event): Add "displays" parameter.
4924
4925 2019-03-19  Pedro Alves  <palves@redhat.com>
4926
4927         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4928         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4929         to -1.  Fix TABs vs spaces.
4930         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4931         * tui/tui-out.h (tui_ui_out) Add intro comments.
4932         <m_line, m_start_of_line>: In-class initialize, and add describing
4933         comment.
4934
4935 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4936
4937         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4938         variable names.
4939         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4940
4941 2019-03-18  Pedro Alves  <palves@redhat.com>
4942             Eli Zaretskii <eliz@gnu.org>
4943
4944         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4945         m_line and m_start_of_line.
4946
4947 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4948
4949         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4950         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4951         it returns a newline.  This fixes a regression in TU mode, whereby
4952         the next line is output on the same screen line as the user input.
4953
4954 2019-03-18  Tom Tromey  <tromey@adacore.com>
4955
4956         * minsyms.c (minimal_symbol_reader::install): Remove call to
4957         obstack_blank.
4958
4959 2019-03-18  Pedro Alves  <palves@redhat.com>
4960
4961         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4962         New globals.
4963         (apply_style): New, factored out from ...
4964         (apply_ansi_escape): ... this.  Handle reverse video mode.
4965         (tui_set_reverse_mode): New function.
4966         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4967         * tui/tui-winsource.c (tui_show_source_line): Use
4968         tui_set_reverse_mode instead of setting A_STANDOUT.
4969         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4970         New setter methods.
4971
4972 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4973
4974         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4975         Handle tabs.
4976
4977 2019-03-18  Tom Tromey  <tromey@adacore.com>
4978
4979         * ada-lang.c (empty_array): Add "high" parameter.
4980         (ada_evaluate_subexp): Update.
4981
4982 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4983
4984         * unittests/string_view-selftests.c: Define
4985         _initialize_string_view_selftests unconditionally.
4986
4987 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4988
4989         PR gdb/24350
4990         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4991
4992 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4993
4994         PR gdb/24351
4995         * windows-nat.c (display_selector): Fix format specifiers.
4996
4997 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4998
4999         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5000         tui_refill_source_window instead of tui_refresh_win, to update the
5001         current execution line.  This fixes redisplay of the current line
5002         when stepping through the code with "next" or "step".
5003
5004 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5005
5006         * source-cache.c (source_cache::get_source_lines): Call
5007         find_source_lines to initialize s->nlines.  This fixes vertical
5008         scrolling of TUI source window when the DOWN arrow is pressed.
5009
5010 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5011
5012         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5013         linux-thread-db.c (_initialize_thread_db): Likewise.
5014
5015 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5016
5017         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5018         wclrtoeol in tui_show_source_line".  This reverts changes made in
5019         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5020
5021 2019-03-15  Tom Tromey  <tom@tromey.com>
5022
5023         * symtab.h (struct minimal_symbol): Derive from
5024         general_symbol_info.
5025         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5026         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5027         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5028         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5029         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5030         (MSYMBOL_SEARCH_NAME): Update.
5031         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5032         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5033         * minsyms.c (minimal_symbol_reader::record_full): Update.
5034
5035 2019-03-15  Tom Tromey  <tom@tromey.com>
5036
5037         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5038
5039 2019-03-15  Tom Tromey  <tom@tromey.com>
5040
5041         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5042         unique_xmalloc_ptr.
5043         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5044         Update.
5045         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5046         (build_minimal_symbol_hash_tables)
5047         (minimal_symbol_reader::install): Update.
5048
5049 2019-03-15  Tom Tromey  <tom@tromey.com>
5050
5051         * symtab.c (create_demangled_names_hash): Update.
5052         (symbol_set_names): Update.
5053         * objfiles.h (struct objfile_per_bfd_storage)
5054         <demangled_names_hash>: Now an htab_up.
5055         * objfiles.c (objfile_per_bfd_storage): Simplify.
5056
5057 2019-03-15  Tom Tromey  <tom@tromey.com>
5058
5059         * objfiles.h (struct objfile_per_bfd_storage): Declare
5060         destructor.
5061         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5062         New.
5063         (get_objfile_bfd_data): Use new.  Don't initialize
5064         language_of_main.
5065         (free_objfile_per_bfd_storage): Remove.
5066         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5067
5068 2019-03-15  Tom Tromey  <tom@tromey.com>
5069
5070         * symfile.c (reread_symbols): Update.
5071         * objfiles.c (objfile::objfile): Update.
5072         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5073         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5074         comment.
5075         (minimal_symbol_reader::install): Update.
5076         (terminate_minimal_symbol_table): Remove.
5077         * jit.c (jit_object_close_impl): Update.
5078
5079 2019-03-15  Tom Tromey  <tom@tromey.com>
5080
5081         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5082         initializations.
5083
5084 2019-03-15  Tom Tromey  <tom@tromey.com>
5085
5086         * objfiles.h (struct objfile_per_bfd_storage)
5087         <demangled_hash_languages>: Now a bitset.
5088         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5089         (lookup_minimal_symbol): Update.
5090
5091 2019-03-15  Tom Tromey  <tom@tromey.com>
5092
5093         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5094         Don't return the symbol.
5095         * coffread.c (record_minimal_symbol): Use record_full.
5096
5097 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5098
5099         The MS-Windows port of ncurses fails to switch to a color pair if
5100         one or both of the colors are the implicit default colors.  This
5101         change records the default colors when TUI is initialized, and
5102         then specifies them explicitly when a color pair uses the default
5103         colors.  This allows color styling in TUI mode on MS-Windows.
5104
5105         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5106         ncurses_norm_attr.
5107         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5108         colors in ncurses_norm_attr.
5109         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5110         "none", replace it with the default color recorded in
5111         ncurses_norm_attr.
5112
5113 2019-03-14  Tom Tromey  <tromey@adacore.com>
5114
5115         * source-cache.h (class source_cache) <get_source_lines>: Return
5116         std::string.
5117         * source-cache.c (source_cache::extract_lines): Handle case where
5118         first_pos==npos.  Return std::string.
5119         (source_cache::get_source_lines): Update.
5120
5121 2019-03-14  Tom Tromey  <tromey@adacore.com>
5122
5123         * NEWS: Add item for "style sources" commands.
5124         * source-cache.c (source_cache::get_source_lines): Check
5125         source_styling.
5126         * cli/cli-style.c (source_styling): New global.
5127         (_initialize_cli_style): Add "style sources" commands.
5128         (show_style_sources): New function.
5129         * cli/cli-style.h (source_styling): Declare.
5130
5131 2019-03-14  Pedro Alves  <palves@redhat.com>
5132             Tom Tromey  <tromey@adacore.com>
5133
5134         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5135         * tui/tui-winsource.c (tui_refill_source_window): New function,
5136         from...
5137         (tui_horizontal_source_scroll): ... here.  Move some logic.
5138         * cli/cli-style.c (set_style_enabled): Notify new observable.
5139         * tui/tui-hooks.c (tui_redisplay_source): New function.
5140         (tui_attach_detach_observers): Attach or detach
5141         tui_redisplay_source.
5142         * observable.h (source_styling_changed): New observable.
5143         * observable.c: Define source_styling_changed observable.
5144
5145 2019-03-13  Tom Tromey  <tromey@adacore.com>
5146
5147         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5148         (i386_gnu_nat_target::store_registers): Update.
5149         * target-debug.h (target_debug_print_std_string): New macro.
5150         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5151         * windows-tdep.c (display_one_tib): Update.
5152         * tui/tui-stack.c (tui_make_status_line): Update.
5153         * top.c (print_inferior_quit_action): Update.
5154         * thread.c (thr_try_catch_cmd): Update.
5155         (add_thread_with_info): Update.
5156         (thread_target_id_str): Update.
5157         (thr_try_catch_cmd): Update.
5158         (thread_command): Update.
5159         (thread_find_command): Update.
5160         * record-btrace.c (record_btrace_target::info_record)
5161         (record_btrace_resume_thread, record_btrace_target::resume)
5162         (record_btrace_cancel_resume, record_btrace_step_thread)
5163         (record_btrace_target::wait, record_btrace_target::wait)
5164         (record_btrace_target::wait, record_btrace_target::stop): Update.
5165         * progspace.c (print_program_space): Update.
5166         * process-stratum-target.c
5167         (process_stratum_target::thread_address_space): Update.
5168         * linux-fork.c (linux_fork_mourn_inferior)
5169         (detach_checkpoint_command, info_checkpoints_command)
5170         (linux_fork_context): Update.
5171         (linux_fork_detach): Update.
5172         (class scoped_switch_fork_info): Update.
5173         (delete_checkpoint_command): Update.
5174         * infrun.c (follow_fork_inferior): Update.
5175         (follow_fork_inferior): Update.
5176         (proceed_after_vfork_done): Update.
5177         (handle_vfork_child_exec_or_exit): Update.
5178         (follow_exec): Update.
5179         (displaced_step_prepare_throw): Update.
5180         (displaced_step_restore): Update.
5181         (start_step_over): Update.
5182         (resume_1): Update.
5183         (clear_proceed_status_thread): Update.
5184         (proceed): Update.
5185         (print_target_wait_results): Update.
5186         (do_target_wait): Update.
5187         (context_switch): Update.
5188         (stop_all_threads): Update.
5189         (restart_threads): Update.
5190         (finish_step_over): Update.
5191         (handle_signal_stop): Update.
5192         (switch_back_to_stepped_thread): Update.
5193         (keep_going_pass_signal): Update.
5194         (print_exited_reason): Update.
5195         (normal_stop): Update.
5196         * inferior.c (inferior_pid_to_str): Change return type.
5197         (print_selected_inferior): Update.
5198         (add_inferior): Update.
5199         (detach_inferior): Update.
5200         * dummy-frame.c (fprint_dummy_frames): Update.
5201         * dcache.c (dcache_info_1): Update.
5202         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5203         (btrace_fetch, btrace_clear): Update.
5204         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5205         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5206         type.
5207         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5208         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5209         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5210         * gdbarch.c, gdbarch.h: Rebuild.
5211         * gdbarch.sh (core_pid_to_str): Change return type.
5212         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5213         return type.
5214         (windows_nat_target::pid_to_str): Change return type.
5215         (windows_delete_thread): Update.
5216         (windows_nat_target::attach): Update.
5217         (windows_nat_target::files_info): Update.
5218         * target-delegates.c: Rebuild.
5219         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5220         return type.
5221         (sol_thread_target::pid_to_str): Change return type.
5222         * remote.c (class remote_target) <pid_to_str>: Change return
5223         type.
5224         (remote_target::pid_to_str): Change return type.
5225         (extended_remote_target::attach, remote_target::remote_stop_ns)
5226         (remote_target::remote_notif_remove_queued_reply)
5227         (remote_target::push_stop_reply, remote_target::disable_btrace):
5228         Update.
5229         (extended_remote_target::attach): Update.
5230         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5231         type.
5232         (gdbsim_target::pid_to_str): Change return type.
5233         * ravenscar-thread.c (struct ravenscar_thread_target)
5234         <pid_to_str>: Change return type.
5235         (ravenscar_thread_target::pid_to_str): Change return type.
5236         * procfs.c (class procfs_target) <pid_to_str>: Change return
5237         type.
5238         (procfs_target::pid_to_str): Change return type.
5239         (procfs_target::attach): Update.
5240         (procfs_target::detach): Update.
5241         (procfs_target::fetch_registers): Update.
5242         (procfs_target::store_registers): Update.
5243         (procfs_target::wait): Update.
5244         (procfs_target::files_info): Update.
5245         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5246         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5247         return type.
5248         (nto_procfs_target::pid_to_str): Change return type.
5249         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5250         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5251         return type.
5252         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5253         (exit_lwp): Update.
5254         (attach_proc_task_lwp_callback, get_detach_signal)
5255         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5256         (linux_nat_target::resume, wait_lwp, stop_callback)
5257         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5258         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5259         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5260         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5261         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5262         type.
5263         (inf_ptrace_target::attach): Update.
5264         (inf_ptrace_target::files_info): Update.
5265         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5266         type.
5267         (go32_nat_target::pid_to_str): Change return type.
5268         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5269         (gnu_nat_target::wait): Update.
5270         (gnu_nat_target::wait): Update.
5271         (gnu_nat_target::resume): Update.
5272         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5273         (fbsd_nat_target::wait): Update.
5274         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5275         type.
5276         (darwin_nat_target::attach): Update.
5277         * corelow.c (class core_target) <pid_to_str>: Change return type.
5278         (core_target::pid_to_str): Change return type.
5279         * target.c (normal_pid_to_str): Change return type.
5280         (default_pid_to_str): Likewise.
5281         (target_pid_to_str): Change return type.
5282         (target_translate_tls_address): Update.
5283         (target_announce_detach): Update.
5284         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5285         return type.
5286         (bsd_uthread_target::pid_to_str): Change return type.
5287         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5288         type.
5289         (bsd_kvm_target::pid_to_str): Change return type.
5290         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5291         return type.
5292         (aix_thread_target::pid_to_str): Change return type.
5293         * target.h (struct target_ops) <pid_to_str>: Change return type.
5294         (target_pid_to_str, normal_pid_to_str): Likewise.
5295         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5296         type.
5297         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5298         type.
5299         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5300         return type.
5301         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5302         type.
5303         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5304         type.
5305         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5306         return type.
5307
5308 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5309
5310         * NEWS: Mention that the new default MI version is 3.  Mention
5311         changes to the output of commands and events that deal with
5312         multi-location breakpoints.
5313         * breakpoint.c: Include "mi/mi-out.h".
5314         (print_one_breakpoint): Change output syntax if using MI version
5315         >= 3.
5316         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5317         New.
5318         (mi_multi_location_breakpoint_output_fixed): New.
5319         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5320         (mi_cmd_fix_multi_location_breakpoint_output): New.
5321         (mi_multi_location_breakpoint_output_fixed): New.
5322         * mi/mi-cmds.c (mi_cmds): Register command
5323         -fix-multi-location-breakpoint-output.
5324         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5325         interpreter "mi".
5326
5327 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5328
5329         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5330         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5331         instantiate mi_ui_out based on interpreter name.
5332         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5333         * mi/mi-main.c (mi_load_progress): Likewise.
5334
5335 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5336
5337         * NEWS: Combine separate "New targets" sections for 8.3.
5338
5339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5340
5341         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5342         (ppcfbsd_init_abi): Install gdbarch
5343         "fetch_tls_load_module_address" and "get_thread_local_address"
5344         methods.
5345
5346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5347
5348         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5349         (riscv_fbsd_init_abi): Install gdbarch
5350         "fetch_tls_load_module_address" and "get_thread_local_address"
5351         methods.
5352
5353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5354
5355         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5356         (i386fbsd_init_abi): Install gdbarch
5357         "fetch_tls_load_module_address" and "get_thread_local_address"
5358         methods.
5359
5360 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5361
5362         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5363         (amd64fbsd_init_abi): Install gdbarch
5364         "fetch_tls_load_module_address" and "get_thread_local_address"
5365         methods.
5366
5367 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5368
5369         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5370         (struct fbsd_pspace_data): New type.
5371         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5372         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5373         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5374         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5375         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5376
5377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5378
5379         * gdbtypes.c (lookup_struct_elt): New function.
5380         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5381         * gdbtypes.h (struct struct_elt): New type.
5382         (lookup_struct_elt): New prototype.
5383
5384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5385
5386         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5387         remove disabled code block.
5388
5389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5390
5391         * gdbarch.sh (get_thread_local_address): New method.
5392         * gdbarch.h, gdbarch.c: Regenerate.
5393         * target.c (target_translate_tls_address): Use
5394         gdbarch_get_thread_local_address if present instead of
5395         target::get_thread_local_address.
5396
5397 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5398
5399         * target.h (target::get_thread_local_address): Update comment.
5400
5401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5402
5403         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5404         objfile->separate_debug_objfile_backlink if not NULL.
5405
5406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5407
5408         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5409         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5410         (amd64bsd_store_inferior_registers): Likewise.
5411         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5412         Enable segment base registers.
5413         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5414         PT_GETFSBASE and PT_GETGSBASE.
5415         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5416         PT_SETGSBASE.
5417         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5418         segment base registers.
5419         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5420
5421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5422
5423         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5424         Update calls to i386_target_description to add 'segments'
5425         parameter.
5426         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5427         add segment base registers.
5428         * arch/i386.c (i386_create_target_description): Add 'segments'
5429         parameter to enable segment base registers.
5430         * arch/i386.h (i386_create_target_description): Likewise.
5431         * features/i386/32bit-segments.xml: New file.
5432         * features/i386/32bit-segments.c: Generate.
5433         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5434         call to i386_target_description to add 'segments' parameter.
5435         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5436         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5437         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5438         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5439         if feature is present.
5440         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5441         Add 'segments' parameter to call to i386_target_description.
5442         (i386_target_description): Add 'segments' parameter to enable
5443         segment base registers.
5444         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5445         to call to i386_target_description.
5446         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5447         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5448         Define I386_NUM_REGS.
5449         (i386_target_description): Add 'segments' parameter to enable
5450         segment base registers.
5451
5452 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5453
5454         PR/24325
5455         * source-cache.c: #undef open and close, to avoid unresolved
5456         externals during linking.
5457
5458 2019-03-12  Tom Tromey  <tromey@adacore.com>
5459
5460         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5461         const.  Add initializers.
5462         (_initialize_remote): Don't initialize ptid globals.
5463
5464 2019-03-12  Pedro Alves  <palves@redhat.com>
5465
5466         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5467
5468 2019-03-12  Pedro Alves  <palves@redhat.com>
5469
5470         * cp-name-parser.y (main): Remove unused 'len' variable.
5471
5472 2019-03-12  Tom Tromey  <tromey@adacore.com>
5473
5474         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5475         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5476
5477 2019-03-12  Tom Tromey  <tromey@adacore.com>
5478
5479         * linux-nat.c (iterate_over_lwps): Update.
5480         (stop_callback): Remove parameter.
5481         (stop_wait_callback, detach_callback, resume_set_callback)
5482         (select_singlestep_lwp_callback, set_ignore_sigint)
5483         (status_callback, resumed_callback, resume_clear_callback)
5484         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5485         data parameter.
5486         (linux_nat_target::detach, linux_nat_target::resume)
5487         (linux_stop_and_wait_all_lwps, select_event_lwp)
5488         (linux_nat_filter_event, linux_nat_wait_1)
5489         (linux_nat_target::kill, linux_nat_target::stop)
5490         (linux_nat_target::stop): Update.
5491         (linux_nat_resume_callback): Change type.
5492         (resume_stopped_resumed_lwps, count_events_callback)
5493         (select_event_lwp_callback): Likewise.
5494         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5495         * arm-linux-nat.c (struct update_registers_data): Remove.
5496         (update_registers_callback): Change type.
5497         (arm_linux_insert_hw_breakpoint1): Update.
5498         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5499         parameter.
5500         (x86_linux_dr_set_addr): Update.
5501         (x86_linux_dr_set_control): Update.
5502         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5503         (iterate_over_lwps): Use gdb::function_view.
5504         * nat/aarch64-linux-hw-point.c (struct
5505         aarch64_dr_update_callback_param): Remove.
5506         (debug_reg_change_callback): Change type.
5507         (aarch64_notify_debug_reg_change): Update.
5508         * s390-linux-nat.c (s390_refresh_per_info): Update.
5509
5510 2019-03-11  Tom Tromey  <tromey@adacore.com>
5511
5512         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5513         redundant assignment to "this_cu".
5514
5515 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5516
5517         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5518
5519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5520
5521         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5522         from...
5523         (rank_one_type): ... this.
5524
5525 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5526
5527         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5528         from...
5529         (rank_one_type): ... this.
5530
5531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5532
5533         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5534         from...
5535         (rank_one_type): ... this.
5536
5537 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5538
5539         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5540         from...
5541         (rank_one_type): ... this.
5542
5543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5544
5545         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5546         from...
5547         (rank_one_type): ... this.
5548
5549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5550
5551         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5552         from...
5553         (rank_one_type): ... this.
5554
5555 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5556
5557         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5558         from...
5559         (rank_one_type): ... this.
5560
5561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5562
5563         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5564         from...
5565         (rank_one_type): ... this.
5566
5567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5568
5569         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5570         from...
5571         (rank_one_type): ... this.
5572
5573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5574
5575         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5576         from...
5577         (rank_one_type): ... this.
5578
5579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5580
5581         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5582         from...
5583         (rank_one_type): ... this.
5584
5585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5586
5587         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5588         from...
5589         (rank_one_type): ... this.
5590
5591 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5592
5593         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5594         inferior-events' shows the example events.
5595
5596 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5597
5598         Support styling on native MS-Windows console
5599
5600         PR/24315
5601         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5602         on MS-Windows if $TERM is not defined.
5603
5604         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5605
5606         * posix-hdep.c (gdb_console_fputs):
5607         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5608         functions.
5609         * ui-file.h (gdb_console_fputs): Add prototype.
5610
5611         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5612         back to fputs only if the former returns zero.
5613
5614 2019-03-07  Tom Tromey  <tom@tromey.com>
5615
5616         * symmisc.c (print_symbol_bcache_statistics): Update.
5617         (print_objfile_statistics): Update.
5618         * symfile.c (allocate_symtab): Update.
5619         * stabsread.c: Don't include bcache.h.
5620         * psymtab.h (struct psymbol_bcache): Don't declare.
5621         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5622         (psymbol_bcache_init, psymbol_bcache_free)
5623         (psymbol_bcache_get_bcache): Don't declare.
5624         * psymtab.c (struct psymbol_bcache): Remove.
5625         (psymtab_storage::psymtab_storage): Update.
5626         (psymtab_storage::~psymtab_storage): Update.
5627         (psymbol_bcache_init, psymbol_bcache_free)
5628         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5629         (add_psymbol_to_bcache): Update.
5630         (allocate_psymtab): Update.
5631         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5632         macro_cache>: No longer pointers.
5633         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5634         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5635         * macrotab.c (macro_bcache): Update.
5636         * macroexp.c: Don't include bcache.h.
5637         * gdbtypes.c (check_types_worklist): Update.
5638         (types_deeply_equal): Remove TRY/CATCH.  Update.
5639         * elfread.c (elf_symtab_read): Update.
5640         * dwarf2read.c: Don't include bcache.h.
5641         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5642         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5643         (print_bcache_statistics, bcache_memory_used): Don't declare.
5644         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5645         methods.  Rename all data members.
5646         * bcache.c (struct bcache): Move to bcache.h.
5647         (bcache::expand_hash_table): Rename from expand_hash_table.
5648         (bcache): Remove.
5649         (bcache::insert): Rename from bcache_full.
5650         (bcache::compare): Rename from bcache_compare.
5651         (bcache_xmalloc): Remove.
5652         (bcache::~bcache): Rename from bcache_xfree.
5653         (bcache::print_statistics): Rename from print_bcache_statistics.
5654         (bcache::memory_used): Rename from bcache_memory_used.
5655
5656 2019-03-07  Pedro Alves  <palves@redhat.com>
5657
5658         * infrun.c (normal_stop): Also check for
5659         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5660
5661 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5662
5663         * f-lang.c (value_from_host_double): Moved to...
5664         * value.c (value_from_host_double): ...here.
5665         * value.h (value_from_host_double): Declare.
5666         * guile/scm-math.c (vlscm_convert_typed_number): Use
5667         value_from_host_double.
5668         (vlscm_convert_number): Likewise.
5669         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5670         * python/py-value.c (convert_value_from_python): Likewise.
5671
5672 2019-03-06  Tom Tromey  <tom@tromey.com>
5673
5674         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5675
5676 2019-03-06  Tom Tromey  <tom@tromey.com>
5677
5678         * utils.h (free_current_contents): Don't declare.
5679         * utils.c (free_current_contents): Remove.
5680
5681 2019-03-06  Tom Tromey  <tom@tromey.com>
5682
5683         * top.c (quit_force): Update.
5684         * main.c (captured_command_loop): Update.
5685         * common/new-op.c (operator new): Update.
5686         * common/common-exceptions.c (struct catcher)
5687         <save_cleanup_chain>: Remove member.
5688         (exceptions_state_mc_init): Update.
5689         (exception_try_scope_entry): Return nullptr.
5690         (exception_try_scope_exit, exception_rethrow)
5691         (throw_exception_sjlj, throw_exception_cxx): Update.
5692         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5693         (all_cleanups, do_cleanups, discard_cleanups)
5694         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5695         (restore_cleanups, restore_final_cleanups): Don't declare.
5696         (do_final_cleanups): Remove parameter.
5697         * common/cleanups.c (cleanup_chain, make_cleanup)
5698         (make_cleanup_dtor, all_cleanups, do_cleanups)
5699         (discard_my_cleanups, discard_cleanups)
5700         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5701         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5702         (null_cleanup): Remove.
5703         (do_final_cleanups): Remove parameter.
5704
5705 2019-03-06  Tom Tromey  <tom@tromey.com>
5706
5707         * remote.c (remote_target::remote_parse_stop_reply): Use
5708         unique_xmalloc_ptr.
5709
5710 2019-03-06  Tom Tromey  <tom@tromey.com>
5711
5712         * stabsread.c (struct stabs_field_info): Rename from field_info.
5713         <list, fnlist>: Add initializers.
5714         <obstack>: New member.
5715         (read_member_functions, read_struct_fields, read_baseclasses):
5716         Allocate on obstack.  Don't use cleanups.
5717         (read_one_struct_field, read_member_functions, read_struct_fields)
5718         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5719         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5720         (read_struct_type): Update.
5721
5722 2019-03-06  Tom Tromey  <tom@tromey.com>
5723
5724         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5725         * common/filestuff.h (make_cleanup_close): Don't declare.
5726         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5727         Remove.
5728
5729 2019-03-06  Tom Tromey  <tom@tromey.com>
5730
5731         * solib-aix.c: Use make_scope_exit.
5732
5733 2019-03-06  Tom Tromey  <tom@tromey.com>
5734
5735         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5736         Use make_scope_exit.
5737
5738 2019-03-06  Tom Tromey  <tom@tromey.com>
5739
5740         * solib-svr4.c (disable_probes_interface): Remove parameter.
5741         (svr4_handle_solib_event): Use make_scope_exit.
5742
5743 2019-03-06  Tom Tromey  <tom@tromey.com>
5744
5745         * remote.c (struct stop_reply_deleter): Remove.
5746         (stop_reply_up): Update.
5747         (struct stop_reply): Derive from notif_event.  Don't typedef.
5748         <regcache>: Now a std::vector.
5749         (stop_reply_xfree): Remove.
5750         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5751         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5752         (remote_target::discard_pending_stop_replies): Use delete.
5753         (remote_target::remote_parse_stop_reply): Update.
5754         (remote_target::process_stop_reply): Update.
5755         * remote-notif.h (struct notif_event): Add virtual destructor.
5756         Remove "dtr" member.
5757         (struct notif_client) <alloc_event>: Return a unique_ptr.
5758         (notif_event_xfree): Don't declare.
5759         (notif_event_up): New typedef.
5760         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5761         (notif_event_xfree, do_notif_event_xfree): Remove.
5762         (remote_notif_state_xfree): Update.
5763
5764 2019-03-06  Tom Tromey  <tom@tromey.com>
5765
5766         * infrun.c (displaced_step_clear_cleanup): Now a
5767         forward_scope_exit type.
5768         (displaced_step_prepare_throw): Update.
5769         (displaced_step_fixup): Update.
5770
5771 2019-03-06  Tom Tromey  <tom@tromey.com>
5772
5773         * inferior.h (class inferior): Update comment.
5774         * gdbthread.h (class thread_info): Update comment.
5775
5776 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5777             Tom Tromey  <tom@tromey.com>
5778
5779         * stabsread.h (struct stab_section_list): Remove.
5780         (coffstab_build_psymtabs): Update.
5781         * dbxread.c (symbuf_sections): Now a std::vector.
5782         (sect_idx): New global.
5783         (fill_symbuf): Update.
5784         (coffstab_build_psymtabs): Change type of stabsects parameter.
5785         Update.
5786         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5787         std::vector.
5788         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5789         (coff_locate_sections): Update.
5790         (coff_symfile_read): Remove cleanups.  Update.
5791         (init_stringtab): Add storage parameter.
5792         (free_stringtab, free_stringtab_cleanup): Remove.
5793         (init_lineno): Add storage parameter.
5794         (free_linetab, free_linetab_cleanup): Remove.
5795
5796 2019-03-06  Pedro Alves  <palves@redhat.com>
5797
5798         * linux-fork.c (fork_info::clobber_regs): Delete.
5799         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5800         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5801         comment.  Adjust.
5802         (scoped_switch_fork_info::scoped_switch_fork_info)
5803         (checkpoint_command, linux_fork_context): Adjust
5804         fork_save_infrun_state calls.
5805
5806 2019-03-06  Pedro Alves  <palves@redhat.com>
5807
5808         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5809         (inf_has_multiple_threads): Return 'bool' and rewrite using
5810         inferior_info::threads().
5811
5812 2019-03-06  Pedro Alves  <palves@redhat.com>
5813
5814         * linux-fork.c: Include <list>.
5815         (fork_list): Now a std::list instance.
5816         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5817         (forks_exist_p, find_last_fork): Adjust.
5818         (new_fork): Delete.
5819         (one_fork_p): New.
5820         (add_fork): Adjust.
5821         (free_fork): Delete, folded into fork_info::~fork_info().
5822         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5823         Adjust.
5824         (init_fork_list): Delete.
5825         (linux_fork_killall, linux_fork_mourn_inferior)
5826         (linux_fork_detach, info_checkpoints_command): Adjust.
5827         (_initialize_linux_fork): No longer call init_fork_list.
5828
5829 2019-03-06  Pedro Alves  <palves@redhat.com>
5830
5831         * linux-fork.c (new_fork): New, split out of ...
5832         (add_fork): ... this.  Return void.  Move "first fork" special
5833         case from here, to ...
5834         (checkpoint_command): ... here.
5835         * linux-linux.h (add_fork): Return void.
5836
5837 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5838
5839         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5840
5841 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5842             Chris January  <chris.january@arm.com>
5843             David Lecomber  <david.lecomber@arm.com>
5844
5845         * f-exp.y: New token, UNOP_INTRINSIC.
5846         (exp): New pattern using UNOP_INTRINSIC token.
5847         (f77_keywords): Add 'abs' keyword.
5848         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5849         (value_from_host_double): New function.
5850         (evaluate_subexp_f): Support UNOP_ABS.
5851
5852 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5853
5854         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5855         types.
5856
5857 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5858
5859         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5860         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5861         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5862
5863 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5864
5865         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5866
5867 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5868             Chris January  <chris.january@arm.com>
5869
5870         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5871         * f-exp.y: Define 'KIND' token.
5872         (exp): New pattern for KIND expressions.
5873         (ptype): Handle types with a kind extension.
5874         (direct_abs_decl): Extend to spot kind extensions.
5875         (f77_keywords): Add 'kind' to the list.
5876         (push_kind_type): New function.
5877         (convert_to_kind_type): New function.
5878         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5879         * parse.c (operator_length_standard): Likewise.
5880         * parser-defs.h (enum type_pieces): Add tp_kind.
5881         * std-operator.def: Add UNOP_KIND.
5882
5883 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5884
5885         * f-exp.y (f_parse): Set yydebug.
5886
5887 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * f-lang.c (evaluate_subexp_f): New function.
5890         (exp_descriptor_f): New global.
5891         (f_language_defn): Use exp_descriptor_f instead of
5892         exp_descriptor_standard.
5893
5894 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5895
5896         * f-exp.y (struct token): Add comments.
5897         (dot_ops): Remove uppercase versions and the end marker.
5898         (f77_keywords): Likewise.
5899         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5900         entries in the dot_ops array are case insensitive, and use
5901         strncasecmp to compare strings.  Also some whitespace cleanup in
5902         this area.  Similar for the f77_keywords array, except entries in
5903         this list might be case sensitive.
5904
5905 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * f-exp.y (struct f77_boolean_val): Add comments.
5908         (boolean_values): Remove uppercase versions, and end marker.
5909         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5910         and use strncasecmp to achieve case insensitivity.  Additionally,
5911         perform whitespace cleanup around this code.
5912
5913 2019-03-06  Tom Tromey  <tromey@adacore.com>
5914
5915         * remote-sim.c (gdbsim_target_open): Use result of
5916         gdb_argv::release.
5917
5918 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5919         Dirk Schubert  <dirk.schubert@arm.com>
5920         Chris January  <chris.january@arm.com>
5921
5922         * eval.c (evaluate_subexp_standard): Call Fortran argument
5923         wrapping logic.
5924         * f-lang.c (struct value): A value which can be passed into a
5925         Fortran function call.
5926         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5927         where appropriate.
5928         (struct type): Value ready for a Fortran function call.
5929         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5930         is needed.
5931         * f-lang.h (fortran_argument_convert): Declaration.
5932         (fortran_preserve_arg_pointer): Declaration.
5933         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5934
5935 2019-03-05  Tom Tromey  <tromey@adacore.com>
5936
5937         * python/py-prettyprint.c (print_string_repr): Remove #if.
5938         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5939
5940 2019-03-05  Tom Tromey  <tromey@adacore.com>
5941
5942         * target.c (the_dummy_target): Move later.  Change type to
5943         "dummy_target".
5944         (initialize_targets): Don't initialize the_dummy_target.
5945
5946 2019-03-05  Tom Tromey  <tromey@adacore.com>
5947
5948         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5949         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5950
5951 2019-03-05  Tom Tromey  <tromey@adacore.com>
5952
5953         * windows-nat.c (windows_nat_target::attach)
5954         (windows_nat_target::detach): Don't call gdb_flush.
5955         * valprint.c (generic_val_print, val_print, val_print_string):
5956         Don't call gdb_flush.
5957         * utils.c (defaulted_query): Don't call gdb_flush.
5958         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5959         * target.c (target_announce_detach): Don't call gdb_flush.
5960         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5961         * remote.c (extended_remote_target::attach): Don't call
5962         gdb_flush.
5963         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5964         * printcmd.c (do_examine): Don't call gdb_flush.
5965         (info_display_command): Don't call gdb_flush.
5966         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5967         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5968         * memattr.c (info_mem_command): Don't call gdb_flush.
5969         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5970         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5971         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5972         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5973         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5974         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5975         (gnu_nat_target::detach): Don't call gdb_flush.
5976         * f-valprint.c (f_val_print): Don't call gdb_flush.
5977         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5978         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5979         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5980         gdb_flush.
5981         * c-valprint.c (c_val_print): Don't call gdb_flush.
5982         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5983
5984 2019-03-05  Tom Tromey  <tromey@adacore.com>
5985
5986         * varobj.c (update_dynamic_varobj_children): Update.
5987         (install_default_visualizer): Use reset, not release.
5988         * value.c (set_internalvar): Update.
5989         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5990         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5991         ATTRIBUTE_UNUSED_RESULT.
5992
5993 2019-03-05  Tom Tromey  <tromey@adacore.com>
5994
5995         * remote.c (class scoped_remote_fd) <release>: Add
5996         ATTRIBUTE_UNUSED_RESULT.
5997
5998 2019-03-05  Tom Tromey  <tromey@adacore.com>
5999
6000         * macroexp.c (struct macro_buffer) <release>: Add
6001         ATTRIBUTE_UNUSED_RESULT.
6002
6003 2019-03-05  Tom Tromey  <tromey@adacore.com>
6004
6005         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6006         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6007         ATTRIBUTE_UNUSED_RESULT.
6008
6009 2019-03-05  Tom Tromey  <tromey@adacore.com>
6010
6011         * common/scoped_fd.h (class scoped_fd) <release>: Add
6012         ATTRIBUTE_UNUSED_RESULT.
6013
6014 2019-03-05  Tom Tromey  <tromey@adacore.com>
6015
6016         * parser-defs.h (struct parser_state) <release>: Add
6017         ATTRIBUTE_UNUSED_RESULT.
6018
6019 2019-03-05  Tom Tromey  <tromey@adacore.com>
6020
6021         * utils.h (class gdb_argv) <release>: Add
6022         ATTRIBUTE_UNUSED_RESULT.
6023         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6024
6025 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6026
6027         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6028         for-loop range, to avoid compiler warnings.
6029
6030         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6031         avoid compiler warnings about unused variables.
6032
6033         * NEWS: Mention end of support for native debugging on MS-Windows
6034         before XP.
6035
6036         PR gdb/24292
6037         * common/netstuff.c:
6038         * gdbserver/gdbreplay.c
6039         * gdbserver/remote-utils.c:
6040         * ser-tcp.c:
6041         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6042         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6043         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6044         'getaddrinfo' and 'freeaddrinfo' were not available before
6045         Windows XP, and mingw.org's MinGW headers by default define
6046         _WIN32_WINNT to 0x500.
6047
6048 2019-03-01  Gary Benson <gbenson@redhat.com>
6049
6050         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6051
6052 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6053             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6054
6055         PR gdb/8527
6056         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6057         set_sigint_trap, clear_sigint_trap.
6058
6059 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6060
6061         * target.c (target_detach): Clear the regcache and the
6062         frame cache.
6063
6064 2019-02-27  Pedro Alves  <palves@redhat.com>
6065
6066         * utils.c (set_screen_size): When we cap the height/width sizes,
6067         tweak the corresponding command variable to show "unlimited":
6068
6069 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6070             Pedro Alves  <palves@redhat.com>
6071
6072         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6073         before calling rl_set_screen_size.
6074
6075 2019-02-27  Tom Tromey  <tromey@adacore.com>
6076
6077         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6078         define.
6079         * python/py-value.c: Remove Python 2.4 workaround.
6080         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6081         workaround.
6082         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6083         Python 2.4 workaround.
6084         * python/python-internal.h: Remove Python 2.4 comment.
6085         (Py_ssize_t): Don't define.
6086         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6087         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6088         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6089         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6090         * python/python.c (do_start_initialization): Remove Python 2.4
6091         workaround.
6092         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6093         (print_children): Remove Python 2.4 workaround.
6094         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6095         workaround.
6096         (CHARBUFFERPROC_NAME): Remove.
6097         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6098         Python 2.4 workaround.
6099
6100 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6101
6102         * NEWS: Note minimum Python version.
6103
6104 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6105
6106         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6107         code from these functions.  Remove corresponding ifdefs.  Use
6108         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6109         Remove gotos and target of gotos.
6110         (infpy_search_memory): Likewise.
6111
6112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6113
6114         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6115         (hppa_gdbarch_init): Don't register deleted functions with
6116         gdbarch.
6117
6118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6119
6120         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6121         (h8300_unwind_sp): Delete.
6122         (h8300_dummy_id): Delete.
6123         (h8300_gdbarch_init): Don't register deleted functions with
6124         gdbarch.
6125
6126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6127
6128         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6129         (ft32_unwind_pc): Delete.
6130         (ft32_unwind_sp): Delete.
6131         (ft32_gdbarch_init): Don't register deleted functions with
6132         gdbarch.
6133
6134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6135
6136         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6137         (frv_unwind_pc): Delete.
6138         (frv_unwind_sp): Delete.
6139         (frv_gdbarch_init): Don't register deleted functions with
6140         gdbarch.
6141
6142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6143
6144         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6145         (riscv_unwind_pc): Delete.
6146         (riscv_unwind_sp): Delete.
6147         (riscv_gdbarch_init): Don't register deleted functions with
6148         gdbarch.
6149
6150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6151
6152         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6153         (csky_unwind_pc): Delete.
6154         (csky_unwind_sp): Delete.
6155         (csky_gdbarch_init): Don't register deleted functions with
6156         gdbarch.
6157
6158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6159
6160         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6161         (cris_unwind_pc): Delete.
6162         (cris_unwind_sp): Delete.
6163         (cris_gdbarch_init): Don't register deleted functions with
6164         gdbarch.
6165
6166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6167
6168         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6169         (bfin_unwind_pc): Delete.
6170         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6171
6172 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6173
6174         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6175         (arm_unwind_pc): Delete.
6176         (arm_unwind_sp): Delete.
6177         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6178
6179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6180
6181         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6182         (arc_unwind_pc): Delete.
6183         (arc_unwind_sp): Delete.
6184         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6185
6186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6187
6188         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6189         (alpha_unwind_pc): Delete.
6190         (alpha_gdbarch_init): Don't register deleted functions with
6191         gdbarch.
6192
6193 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6194
6195         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6196         (aarch64_unwind_pc): Delete.
6197         (aarch64_unwind_sp): Delete.
6198         (aarch64_gdbarch_init): Don't register deleted functions with
6199         gdbarch.
6200
6201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * gdbtypes.c (type_align): Don't consider static members when
6204         computing structure alignment.
6205
6206 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6209         return 0 for other types.
6210         * arch-utils.c (default_type_align): Always return 0.
6211         * gdbarch.h: Regenerate.
6212         * gdbarch.sh (type_align): Extend comment.
6213         * gdbtypes.c (type_align): Add additional comments, always call
6214         gdbarch_type_align before applying the default rules.
6215         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6216         generic code will then apply a suitable default.
6217         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6218         types, return 0 for other types.
6219
6220 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6221
6222         * NEWS: Create a new section for the next release branch.
6223         Rename the section of the current branch, now that it has
6224         been cut.
6225
6226 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6227
6228         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6229         * version.in: Bump version to 8.3.50.DATE-git.
6230
6231 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6232
6233         * aix-thread.c (ptid_cmp): Remove unused variable.
6234         (get_signaled_thread): Likewise.
6235         (store_regs_user_thread): Likewise.
6236         (store_regs_kernel_thread): Likewise.
6237         (fetch_regs_kernel_thread): Remove shadowed variable.
6238
6239 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6240
6241         * features/riscv/32bit-cpu.xml: Add register numbers.
6242         * features/riscv/32bit-fpu.c: Regenerate.
6243         * features/riscv/32bit-fpu.xml: Add register numbers.
6244         * features/riscv/64bit-cpu.xml: Add register numbers.
6245         * features/riscv/64bit-fpu.c: Regenerate.
6246         * features/riscv/64bit-fpu.xml: Add register numbers.
6247
6248 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6249
6250         * NEWS: Mention two argument form of gdb.Value constructor.
6251         * python/py-value.c (convert_buffer_and_type_to_value): New
6252         function.
6253         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6254         Add support for handling an optional second argument.  Call
6255         convert_buffer_and_type_to_value as appropriate.
6256         * python/python-internal.h (Py_buffer_deleter): New struct.
6257         (Py_buffer_up): New typedef.
6258
6259 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6260
6261         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6262         instead of releasing ownership.
6263
6264 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6265
6266         * dwarf2read.c (open_and_init_dwp_file): Call
6267         elf_numsections instead of bfd_count_sections to initialize
6268         dwp_file->num_sections.
6269
6270 2019-02-25  Tom Tromey  <tromey@adacore.com>
6271
6272         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6273
6274 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6275
6276         * gcore.in: Add '--readnever' option when invoking GDB.
6277
6278 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6279
6280         * MAINTAINERS: Update my email address.
6281
6282 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6283
6284         * build-id.c (build_id_to_debug_bfd_1): New function.
6285         (build_id_to_debug_bfd): Look for separate debug file in
6286         sysroot.
6287
6288 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6289
6290         * gdbarch.sh: Update the copyright year range that is placed into
6291         generated files.
6292
6293 2019-02-22  Keith Seitz  <keiths@redhat.com>
6294
6295         PR symtab/23853
6296         * linespec.c (create_sals_line_offset): Search for the default
6297         symtab's filename instead of its fullname.
6298
6299 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6300
6301         * NEWS: Update style defaults.
6302
6303 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6304
6305         * main.c (captured_main_1): Disable styling in batch mode.
6306
6307 2019-02-20  Tom Tromey  <tom@tromey.com>
6308
6309         * symtab.c (symtab_symbol_info): Fix typos.
6310
6311 2019-02-20  Tom Tromey  <tromey@adacore.com>
6312
6313         * findcmd.c (_initialize_mem_search): Use upper case for
6314         metasyntactic variables.
6315
6316 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6317
6318         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6319         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6320
6321 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6322
6323         * top.h (source_file_name): Change to std::string.
6324         * top.c (source_file_name): Likewise.
6325         (command_line_input): Adjust.
6326         * cli/cli-script.c (script_from_file): Adjust.
6327
6328 2019-02-19  Tom Tromey  <tromey@adacore.com>
6329
6330         * ravenscar-thread.c
6331         (ravenscar_thread_target::update_thread_list): Don't call
6332         ada_build_task_list.
6333         * ada-lang.h (ada_build_task_list): Don't declare.
6334         * ada-tasks.c (struct ada_tasks_inferior_data)
6335         <task_list_valid_p>: Now bool.
6336         (read_known_tasks, ada_task_list_changed)
6337         (ada_tasks_invalidate_inferior_data): Update.
6338         (read_known_tasks_array): Return bool.
6339         (read_known_tasks_list): Likewise.
6340         (read_known_tasks): Return void.
6341         (ada_build_task_list): Now static.
6342
6343 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6344
6345         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6346         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6347
6348 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6349
6350         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6351         variant for ada_tasks_pspace_data_handle and
6352         ada_tasks_inferior_data_handle.
6353         (ada_tasks_pspace_data_cleanup): New function.
6354         (ada_tasks_inferior_data_cleanup): New function.
6355
6356 2019-02-17  Tom Tromey  <tom@tromey.com>
6357
6358         * macrotab.h (macro_source_fullname): Return a std::string.
6359         * macrotab.c (macro_include, check_for_redefinition)
6360         (macro_undef, macro_lookup_definition, foreach_macro)
6361         (foreach_macro_in_scope): Update.
6362         (macro_source_fullname): Return a std::string.
6363         * macrocmd.c (show_pp_source_pos): Update.
6364
6365 2019-02-17  Tom Tromey  <tom@tromey.com>
6366
6367         * macrocmd.c (show_pp_source_pos): Style the file names.
6368
6369 2019-02-17  Tom Tromey  <tom@tromey.com>
6370
6371         PR tui/24197:
6372         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6373
6374 2019-02-17  Tom Tromey  <tom@tromey.com>
6375
6376         * ada-lang.c (user_select_syms): Use filtered printing.
6377         * utils.c (wrap_style): New global.
6378         (desired_style): Remove.
6379         (emit_style_escape): Add stream parameter.
6380         (set_output_style, reset_terminal_style, prompt_for_continue):
6381         Update.
6382         (flush_wrap_buffer): Only flush gdb_stdout.
6383         (wrap_here): Set wrap_style.
6384         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6385         treat escape sequences as a character.  Change when wrap buffer is
6386         flushed.
6387         (fputs_styled): Do not set the output style when the default is
6388         requested.
6389         * ui-style.h (struct ui_file_style) <is_default>: New method.
6390         * source.c (print_source_lines_base): Emit escape sequences in one
6391         piece.
6392
6393 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6394
6395         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6396         integers and enumeration types.
6397
6398 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6399
6400         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6401         instead of lookup_symbol_in_language
6402         (do_exact_match): New function.
6403         (ada_get_symbol_name_matcher): Return do_exact_match when
6404         doing a verbatim match.
6405
6406 2019-02-15  Tom Tromey  <tromey@adacore.com>
6407
6408         * ravenscar-thread.c (ravenscar_thread_target::resume)
6409         (ravenscar_thread_target::wait): Special case wildcard requests.
6410
6411 2019-02-15  Tom Tromey  <tromey@adacore.com>
6412
6413         * ravenscar-thread.c (base_ptid): Remove.
6414         (struct ravenscar_thread_target) <close>: New method.
6415         <m_base_ptid>: New member.
6416         <update_inferior_ptid, active_task, task_is_currently_active,
6417         runtime_initialized>: Declare methods.
6418         <ravenscar_thread_target>: Add constructor.
6419         (ravenscar_thread_target::task_is_currently_active)
6420         (ravenscar_thread_target::update_inferior_ptid)
6421         (ravenscar_runtime_initialized): Rename.  Now methods.
6422         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6423         (ravenscar_thread_target::update_thread_list): Update.
6424         (ravenscar_thread_target::active_task): Now method.
6425         (ravenscar_thread_target::store_registers)
6426         (ravenscar_thread_target::prepare_to_store)
6427         (ravenscar_thread_target::prepare_to_store)
6428         (ravenscar_thread_target::mourn_inferior): Update.
6429         (ravenscar_inferior_created): Use "new" to create target.
6430         (ravenscar_thread_target::get_ada_task_ptid): Update.
6431         (_initialize_ravenscar): Don't initialize base_ptid.
6432         (ravenscar_ops): Remove global.
6433
6434 2019-02-15  Tom Tromey  <tromey@adacore.com>
6435
6436         * target.h (push_target): Declare new overload.
6437         * target.c (push_target): New overload, taking an rvalue reference.
6438         * remote.c (remote_target::open_1): Use push_target overload.
6439         * corelow.c (core_target_open): Use push_target overload.
6440
6441 2019-02-15  Tom Tromey  <tromey@adacore.com>
6442
6443         * ravenscar-thread.c (is_ravenscar_task)
6444         (ravenscar_task_is_currently_active): Return bool.
6445         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6446         (_initialize_ravenscar): Remove "(void)".
6447         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6448         Return bool.
6449
6450 2019-02-15  Tom Tromey  <tromey@adacore.com>
6451
6452         * ravenscar-thread.c (ravenscar_runtime_initializer)
6453         (has_ravenscar_runtime, get_running_thread_id)
6454         (ravenscar_thread_target::resume): Fix indentation.
6455
6456 2019-02-15  Tom Tromey  <tromey@adacore.com>
6457
6458         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6459         from ravenscar_arch_ops.
6460         (sparc_ravenscar_ops::fetch_registers)
6461         (sparc_ravenscar_ops::store_registers): Now methods.
6462         (sparc_ravenscar_prepare_to_store): Remove.
6463         (sparc_ravenscar_ops): Redefine.
6464         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6465         methods and destructor.  Remove members.
6466         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6467         (ravenscar_thread_target::store_registers)
6468         (ravenscar_thread_target::prepare_to_store): Update.
6469         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6470         Remove.
6471         (struct ppc_ravenscar_powerpc_ops): Derive from
6472         ravenscar_arch_ops.
6473         (ppc_ravenscar_powerpc_ops::fetch_registers)
6474         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6475         (ppc_ravenscar_powerpc_ops): Redefine.
6476         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6477         (ppc_ravenscar_e500_ops::fetch_registers)
6478         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6479         (ppc_ravenscar_e500_ops): Redefine.
6480         * aarch64-ravenscar-thread.c
6481         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6482         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6483         (aarch64_ravenscar_fetch_registers)
6484         (aarch64_ravenscar_store_registers): Now methods.
6485         (aarch64_ravenscar_ops): Redefine.
6486
6487 2019-02-15  Tom Tromey  <tromey@adacore.com>
6488
6489         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6490         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6491         (ravenscar_thread_target::stopped_by_watchpoint)
6492         (ravenscar_thread_target::stopped_data_address)
6493         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6494
6495 2019-02-15  Tom Tromey  <tromey@adacore.com>
6496
6497         * ravenscar-thread.c: Fix some typos.
6498
6499 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6500             Tom Tromey  <tromey@adacore.com>
6501
6502         * ada-lang.c (ada_exception_sal): Change addr_string to a
6503         std::string.
6504         (create_ada_exception_catchpoint): Update.
6505
6506 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6507             Tom Tromey  <tromey@adacore.com>
6508
6509         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6510         (bp_location_ops): Remove.
6511         (base_breakpoint_allocate_location): Update.
6512         (free_bp_location): Update.
6513         * ada-lang.c (class ada_catchpoint_location)
6514         <ada_catchpoint_location>: Remove ops parameter.
6515         (ada_catchpoint_location_dtor): Remove.
6516         (ada_catchpoint_location_ops): Remove.
6517         (allocate_location_exception): Update.
6518         * breakpoint.h (struct bp_location_ops): Remove.
6519         (class bp_location) <bp_location>: Remove bp_location_ops
6520         parameter.
6521         <~bp_location>: Add destructor.
6522         <ops>: Remove.
6523
6524 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6525             Pedro Alves  <palves@redhat.com>
6526
6527         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6528         'PATH_MAX'.
6529
6530 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6531             Samuel Thibault  <samuel.thibault@gnu.org>
6532             Thomas Schwinge  <thomas@codesourcery.com>
6533
6534         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6535         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6536
6537 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6538
6539         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6540         (check_empty): Use "const char *".
6541
6542         * gnu-nat.c (gnu_nat_target::detach): Instead of
6543         'detach_inferior (pid)' call
6544         'detach_inferior (find_inferior_pid (pid))'.
6545
6546         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6547         'nat/fork-inferior.o'.
6548         * gnu-nat.c: #include "nat/fork-inferior.h".
6549
6550         * gnu-nat.c (gnu_nat_target::detach): Instead of
6551         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6552         * gnu-nat.h: #include "inf-child.h".
6553         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6554         'i386_gnu_nat_target::fetch_registers'.
6555         (gnu_store_registers): Rename/move to
6556         'i386_gnu_nat_target::store_registers'.
6557
6558         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6559         * gnu-nat.h (mach_thread_info): New function.
6560         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6561
6562         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6563
6564 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6565
6566         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6567
6568 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6569
6570         * windows-nat.c (windows_add_thread): Add new parameter
6571         "main_thread_p" with default value set to false.  Update
6572         function documentation as well as all callers.
6573         (windows_delete_thread): Likewise.
6574         (fake_create_process): Update call to windows_add_thread.
6575         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6576         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6577         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6578         call to windows_delete_thread.
6579
6580 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6581
6582         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6583
6584 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6585
6586         * symfile.c (find_separate_debug_file): Use canonical path of
6587         sysroot with child_path instead of gdb_sysroot if it is valid.
6588
6589 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6590
6591         * symfile.c (find_separate_debug_file): Use child_path to
6592         determine if an object file is under a sysroot.
6593
6594 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6595
6596         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6597         unittests/child-path-selftests.c.
6598         * common/pathstuff.c (child_path): New function.
6599         * common/pathstuff.h (child_path): New prototype.
6600         * unittests/child-path-selftests.c: New file.
6601
6602 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6603
6604         * symfile.c (find_separate_debug_file): Look for separate debug
6605         files in debug directories under the sysroot.
6606
6607 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6608
6609         * symtab.h (struct minimal_symbol data_p): New const method.
6610         (struct minimal_symbol text_p): Likewise.
6611         * symtab.c (output_source_filename): Use file name style
6612         to print file name.
6613         (print_symbol_info): Likewise.
6614         (print_msymbol_info): Use address style to print addresses.
6615         Use function name style to print executable text symbols.
6616         (expand_symtab_containing_pc): Use data_p.
6617         (find_pc_sect_compunit_symtab): Likewise.
6618
6619 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6620
6621         * breakpoint.c (describe_other_breakpoints): Use address style
6622         to print addresses.
6623         (say_where): Likewise.
6624
6625 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6626
6627         * ada-typeprint.c (print_func_type): Print function name
6628         style to print function name.
6629         * c-typeprint.c (c_print_type_1): Likewise.
6630
6631 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6632
6633         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6634         for execve.
6635
6636 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6637
6638         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6639         type_stack.
6640
6641 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6642
6643         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6644         TYPE_CODE_REF types.
6645
6646 2019-02-08  Jim Wilson  <jimw@sifive.com>
6647
6648         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6649         (riscv_linux_fregset): New.
6650         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6651
6652 2019-02-07  Tom Tromey  <tom@tromey.com>
6653
6654         * thread.c (thread_cancel_execution_command): Update.
6655         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6656         methods.
6657         (struct thread_fsm_ops): Remove.
6658         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6659         (thread_fsm_should_stop, thread_fsm_return_value)
6660         (thread_fsm_set_finished, thread_fsm_finished_p)
6661         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6662         Don't declare.
6663         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6664         * infrun.c (clear_proceed_status_thread)
6665         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6666         (print_stop_event): Update.
6667         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6668         Add constructor.
6669         (step_command_fsm_ops): Remove.
6670         (new_step_command_fsm): Remove.
6671         (step_1): Update.
6672         (step_command_fsm::should_stop): Rename from
6673         step_command_fsm_should_stop.
6674         (step_command_fsm::clean_up): Rename from
6675         step_command_fsm_clean_up.
6676         (step_command_fsm::do_async_reply_reason): Rename from
6677         step_command_fsm_async_reply_reason.
6678         (struct until_next_fsm): Inherit from thread_fsm.  Add
6679         constructor.
6680         (until_next_fsm_ops): Remove.
6681         (new_until_next_fsm): Remove.
6682         (until_next_fsm::should_stop): Rename from
6683         until_next_fsm_should_stop.
6684         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6685         (until_next_fsm::do_async_reply_reason): Rename from
6686         until_next_fsm_async_reply_reason.
6687         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6688         constructor.  Change type of breakpoint.
6689         (finish_command_fsm_ops): Remove.
6690         (new_finish_command_fsm): Remove.
6691         (finish_command_fsm::should_stop): Rename from
6692         finish_command_fsm_should_stop.
6693         (finish_command_fsm::clean_up): Rename from
6694         finish_command_fsm_clean_up.
6695         (finish_command_fsm::return_value): Rename from
6696         finish_command_fsm_return_value.
6697         (finish_command_fsm::do_async_reply_reason): Rename from
6698         finish_command_fsm_async_reply_reason.
6699         (finish_command): Update.
6700         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6701         Add constructor.
6702         (call_thread_fsm_ops): Remove.
6703         (call_thread_fsm::call_thread_fsm): Rename from
6704         new_call_thread_fsm.
6705         (call_thread_fsm::should_stop): Rename from
6706         call_thread_fsm_should_stop.
6707         (call_thread_fsm::should_notify_stop): Rename from
6708         call_thread_fsm_should_notify_stop.
6709         (run_inferior_call, call_function_by_hand_dummy): Update.
6710         * cli/cli-interp.c (should_print_stop_to_console): Update.
6711         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6712         Add constructor.  Change type of location_breakpoint,
6713         caller_breakpoint.
6714         (until_break_fsm_ops): Remove.
6715         (new_until_break_fsm): Remove.
6716         (until_break_fsm::should_stop): Rename from
6717         until_break_fsm_should_stop.
6718         (until_break_fsm::clean_up): Rename from
6719         until_break_fsm_clean_up.
6720         (until_break_fsm::do_async_reply_reason): Rename from
6721         until_break_fsm_async_reply_reason.
6722         (until_break_command): Update.
6723         * thread-fsm.c: Remove.
6724         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6725
6726 2019-02-07  Tom Tromey  <tom@tromey.com>
6727
6728         * yy-remap.h: Add include guard.
6729         * xtensa-tdep.h: Add include guard.
6730         * xcoffread.h: Rename include guard.
6731         * varobj-iter.h: Add include guard.
6732         * tui/tui.h: Rename include guard.
6733         * tui/tui-winsource.h: Rename include guard.
6734         * tui/tui-wingeneral.h: Rename include guard.
6735         * tui/tui-windata.h: Rename include guard.
6736         * tui/tui-win.h: Rename include guard.
6737         * tui/tui-stack.h: Rename include guard.
6738         * tui/tui-source.h: Rename include guard.
6739         * tui/tui-regs.h: Rename include guard.
6740         * tui/tui-out.h: Rename include guard.
6741         * tui/tui-layout.h: Rename include guard.
6742         * tui/tui-io.h: Rename include guard.
6743         * tui/tui-hooks.h: Rename include guard.
6744         * tui/tui-file.h: Rename include guard.
6745         * tui/tui-disasm.h: Rename include guard.
6746         * tui/tui-data.h: Rename include guard.
6747         * tui/tui-command.h: Rename include guard.
6748         * tic6x-tdep.h: Add include guard.
6749         * target/waitstatus.h: Rename include guard.
6750         * target/wait.h: Rename include guard.
6751         * target/target.h: Rename include guard.
6752         * target/resume.h: Rename include guard.
6753         * target-float.h: Rename include guard.
6754         * stabsread.h: Add include guard.
6755         * rs6000-tdep.h: Add include guard.
6756         * riscv-fbsd-tdep.h: Add include guard.
6757         * regformats/regdef.h: Rename include guard.
6758         * record.h: Rename include guard.
6759         * python/python.h: Rename include guard.
6760         * python/python-internal.h: Rename include guard.
6761         * python/py-stopevent.h: Rename include guard.
6762         * python/py-ref.h: Rename include guard.
6763         * python/py-record.h: Rename include guard.
6764         * python/py-record-full.h: Rename include guard.
6765         * python/py-record-btrace.h: Rename include guard.
6766         * python/py-instruction.h: Rename include guard.
6767         * python/py-events.h: Rename include guard.
6768         * python/py-event.h: Rename include guard.
6769         * procfs.h: Add include guard.
6770         * proc-utils.h: Add include guard.
6771         * p-lang.h: Add include guard.
6772         * or1k-tdep.h: Rename include guard.
6773         * observable.h: Rename include guard.
6774         * nto-tdep.h: Rename include guard.
6775         * nat/x86-linux.h: Rename include guard.
6776         * nat/x86-linux-dregs.h: Rename include guard.
6777         * nat/x86-gcc-cpuid.h: Add include guard.
6778         * nat/x86-dregs.h: Rename include guard.
6779         * nat/x86-cpuid.h: Rename include guard.
6780         * nat/ppc-linux.h: Rename include guard.
6781         * nat/mips-linux-watch.h: Rename include guard.
6782         * nat/linux-waitpid.h: Rename include guard.
6783         * nat/linux-ptrace.h: Rename include guard.
6784         * nat/linux-procfs.h: Rename include guard.
6785         * nat/linux-osdata.h: Rename include guard.
6786         * nat/linux-nat.h: Rename include guard.
6787         * nat/linux-namespaces.h: Rename include guard.
6788         * nat/linux-btrace.h: Rename include guard.
6789         * nat/glibc_thread_db.h: Rename include guard.
6790         * nat/gdb_thread_db.h: Rename include guard.
6791         * nat/gdb_ptrace.h: Rename include guard.
6792         * nat/fork-inferior.h: Rename include guard.
6793         * nat/amd64-linux-siginfo.h: Rename include guard.
6794         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6795         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6796         * nat/aarch64-linux.h: Rename include guard.
6797         * nat/aarch64-linux-hw-point.h: Rename include guard.
6798         * mn10300-tdep.h: Add include guard.
6799         * mips-linux-tdep.h: Add include guard.
6800         * mi/mi-parse.h: Rename include guard.
6801         * mi/mi-out.h: Rename include guard.
6802         * mi/mi-main.h: Rename include guard.
6803         * mi/mi-interp.h: Rename include guard.
6804         * mi/mi-getopt.h: Rename include guard.
6805         * mi/mi-console.h: Rename include guard.
6806         * mi/mi-common.h: Rename include guard.
6807         * mi/mi-cmds.h: Rename include guard.
6808         * mi/mi-cmd-break.h: Rename include guard.
6809         * m2-lang.h: Add include guard.
6810         * location.h: Rename include guard.
6811         * linux-record.h: Rename include guard.
6812         * linux-nat.h: Add include guard.
6813         * linux-fork.h: Add include guard.
6814         * i386-darwin-tdep.h: Rename include guard.
6815         * hppa-linux-offsets.h: Add include guard.
6816         * guile/guile.h: Rename include guard.
6817         * guile/guile-internal.h: Rename include guard.
6818         * gnu-nat.h: Rename include guard.
6819         * gdb-stabs.h: Rename include guard.
6820         * frv-tdep.h: Add include guard.
6821         * f-lang.h: Add include guard.
6822         * event-loop.h: Add include guard.
6823         * darwin-nat.h: Rename include guard.
6824         * cp-abi.h: Rename include guard.
6825         * config/sparc/nm-sol2.h: Rename include guard.
6826         * config/nm-nto.h: Rename include guard.
6827         * config/nm-linux.h: Add include guard.
6828         * config/i386/nm-i386gnu.h: Rename include guard.
6829         * config/djgpp/nl_types.h: Rename include guard.
6830         * config/djgpp/langinfo.h: Rename include guard.
6831         * compile/gcc-cp-plugin.h: Add include guard.
6832         * compile/gcc-c-plugin.h: Add include guard.
6833         * compile/compile.h: Rename include guard.
6834         * compile/compile-object-run.h: Rename include guard.
6835         * compile/compile-object-load.h: Rename include guard.
6836         * compile/compile-internal.h: Rename include guard.
6837         * compile/compile-cplus.h: Rename include guard.
6838         * compile/compile-c.h: Rename include guard.
6839         * common/xml-utils.h: Rename include guard.
6840         * common/x86-xstate.h: Rename include guard.
6841         * common/version.h: Rename include guard.
6842         * common/vec.h: Rename include guard.
6843         * common/tdesc.h: Rename include guard.
6844         * common/selftest.h: Rename include guard.
6845         * common/scoped_restore.h: Rename include guard.
6846         * common/scoped_mmap.h: Rename include guard.
6847         * common/scoped_fd.h: Rename include guard.
6848         * common/safe-iterator.h: Rename include guard.
6849         * common/run-time-clock.h: Rename include guard.
6850         * common/refcounted-object.h: Rename include guard.
6851         * common/queue.h: Rename include guard.
6852         * common/ptid.h: Rename include guard.
6853         * common/print-utils.h: Rename include guard.
6854         * common/preprocessor.h: Rename include guard.
6855         * common/pathstuff.h: Rename include guard.
6856         * common/observable.h: Rename include guard.
6857         * common/netstuff.h: Rename include guard.
6858         * common/job-control.h: Rename include guard.
6859         * common/host-defs.h: Rename include guard.
6860         * common/gdb_wait.h: Rename include guard.
6861         * common/gdb_vecs.h: Rename include guard.
6862         * common/gdb_unlinker.h: Rename include guard.
6863         * common/gdb_unique_ptr.h: Rename include guard.
6864         * common/gdb_tilde_expand.h: Rename include guard.
6865         * common/gdb_sys_time.h: Rename include guard.
6866         * common/gdb_string_view.h: Rename include guard.
6867         * common/gdb_splay_tree.h: Rename include guard.
6868         * common/gdb_setjmp.h: Rename include guard.
6869         * common/gdb_ref_ptr.h: Rename include guard.
6870         * common/gdb_optional.h: Rename include guard.
6871         * common/gdb_locale.h: Rename include guard.
6872         * common/gdb_assert.h: Rename include guard.
6873         * common/filtered-iterator.h: Rename include guard.
6874         * common/filestuff.h: Rename include guard.
6875         * common/fileio.h: Rename include guard.
6876         * common/environ.h: Rename include guard.
6877         * common/common-utils.h: Rename include guard.
6878         * common/common-types.h: Rename include guard.
6879         * common/common-regcache.h: Rename include guard.
6880         * common/common-inferior.h: Rename include guard.
6881         * common/common-gdbthread.h: Rename include guard.
6882         * common/common-exceptions.h: Rename include guard.
6883         * common/common-defs.h: Rename include guard.
6884         * common/common-debug.h: Rename include guard.
6885         * common/cleanups.h: Rename include guard.
6886         * common/buffer.h: Rename include guard.
6887         * common/btrace-common.h: Rename include guard.
6888         * common/break-common.h: Rename include guard.
6889         * cli/cli-utils.h: Rename include guard.
6890         * cli/cli-style.h: Rename include guard.
6891         * cli/cli-setshow.h: Rename include guard.
6892         * cli/cli-script.h: Rename include guard.
6893         * cli/cli-interp.h: Rename include guard.
6894         * cli/cli-decode.h: Rename include guard.
6895         * cli/cli-cmds.h: Rename include guard.
6896         * charset-list.h: Add include guard.
6897         * buildsym-legacy.h: Rename include guard.
6898         * bfin-tdep.h: Add include guard.
6899         * ax.h: Rename include guard.
6900         * arm-linux-tdep.h: Add include guard.
6901         * arm-fbsd-tdep.h: Add include guard.
6902         * arch/xtensa.h: Rename include guard.
6903         * arch/tic6x.h: Add include guard.
6904         * arch/i386.h: Add include guard.
6905         * arch/arm.h: Rename include guard.
6906         * arch/arm-linux.h: Rename include guard.
6907         * arch/arm-get-next-pcs.h: Rename include guard.
6908         * arch/amd64.h: Add include guard.
6909         * arch/aarch64-insn.h: Rename include guard.
6910         * arch-utils.h: Rename include guard.
6911         * annotate.h: Add include guard.
6912         * amd64-darwin-tdep.h: Rename include guard.
6913         * aarch64-linux-tdep.h: Add include guard.
6914         * aarch64-fbsd-tdep.h: Add include guard.
6915         * aarch32-linux-nat.h: Add include guard.
6916
6917 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6918
6919         * macrotab.c (macro_define_internal): New function that
6920         factorizes macro_define_object_internal and macro_define_function
6921         code.
6922         (macro_define_object_internal): Use macro_define_internal.
6923         (macro_define_function): Likewise.
6924
6925 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6926
6927         * macrocmd.c (extract_identifier): Return
6928         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6929         callers.
6930
6931 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6932
6933         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6934
6935 2019-02-05  Tom Tromey  <tom@tromey.com>
6936
6937         * target.c (target_stack::unpush): Move assertion earlier.
6938
6939 2019-01-30  Tom Tromey  <tom@tromey.com>
6940
6941         PR python/23615:
6942         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6943         (gdbpy_parse_and_eval): Likewise.
6944         * python/python-internal.h (gdbpy_allow_threads): New class.
6945
6946 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6947
6948         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6949         (aarch64_fbsd_fpregmap): Move earlier.
6950         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6951         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6952         instead of individual calls to trad_frame_set_reg_addr.
6953         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6954         earlier.
6955         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6956         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6957         instead of individual calls to trad_frame_set_reg_addr.
6958
6959 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6960
6961         * CONTRIBUTE: Replace contribution list with wiki link.
6962
6963 2019-01-25  Tom Tromey  <tom@tromey.com>
6964
6965         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6966
6967 2019-01-25  Tom Tromey  <tom@tromey.com>
6968
6969         * xtensa-linux-nat.c: Fix common/ includes.
6970         * xml-support.h: Fix common/ includes.
6971         * xml-support.c: Fix common/ includes.
6972         * x86-linux-nat.c: Fix common/ includes.
6973         * windows-nat.c: Fix common/ includes.
6974         * varobj.h: Fix common/ includes.
6975         * varobj.c: Fix common/ includes.
6976         * value.c: Fix common/ includes.
6977         * valops.c: Fix common/ includes.
6978         * utils.c: Fix common/ includes.
6979         * unittests/xml-utils-selftests.c: Fix common/ includes.
6980         * unittests/utils-selftests.c: Fix common/ includes.
6981         * unittests/unpack-selftests.c: Fix common/ includes.
6982         * unittests/tracepoint-selftests.c: Fix common/ includes.
6983         * unittests/style-selftests.c: Fix common/ includes.
6984         * unittests/string_view-selftests.c: Fix common/ includes.
6985         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6986         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6987         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6988         * unittests/rsp-low-selftests.c: Fix common/ includes.
6989         * unittests/parse-connection-spec-selftests.c: Fix common/
6990         includes.
6991         * unittests/optional-selftests.c: Fix common/ includes.
6992         * unittests/offset-type-selftests.c: Fix common/ includes.
6993         * unittests/observable-selftests.c: Fix common/ includes.
6994         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6995         * unittests/memrange-selftests.c: Fix common/ includes.
6996         * unittests/memory-map-selftests.c: Fix common/ includes.
6997         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6998         * unittests/function-view-selftests.c: Fix common/ includes.
6999         * unittests/environ-selftests.c: Fix common/ includes.
7000         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7001         * unittests/common-utils-selftests.c: Fix common/ includes.
7002         * unittests/cli-utils-selftests.c: Fix common/ includes.
7003         * unittests/array-view-selftests.c: Fix common/ includes.
7004         * ui-file.c: Fix common/ includes.
7005         * tui/tui-io.c: Fix common/ includes.
7006         * tracepoint.h: Fix common/ includes.
7007         * tracepoint.c: Fix common/ includes.
7008         * tracefile-tfile.c: Fix common/ includes.
7009         * top.h: Fix common/ includes.
7010         * top.c: Fix common/ includes.
7011         * thread.c: Fix common/ includes.
7012         * target/waitstatus.h: Fix common/ includes.
7013         * target/waitstatus.c: Fix common/ includes.
7014         * target.h: Fix common/ includes.
7015         * target.c: Fix common/ includes.
7016         * target-memory.c: Fix common/ includes.
7017         * target-descriptions.c: Fix common/ includes.
7018         * symtab.h: Fix common/ includes.
7019         * symfile.c: Fix common/ includes.
7020         * stap-probe.c: Fix common/ includes.
7021         * spu-linux-nat.c: Fix common/ includes.
7022         * sparc-nat.c: Fix common/ includes.
7023         * source.c: Fix common/ includes.
7024         * solib.c: Fix common/ includes.
7025         * solib-target.c: Fix common/ includes.
7026         * ser-unix.c: Fix common/ includes.
7027         * ser-tcp.c: Fix common/ includes.
7028         * ser-pipe.c: Fix common/ includes.
7029         * ser-base.c: Fix common/ includes.
7030         * selftest-arch.c: Fix common/ includes.
7031         * s12z-tdep.c: Fix common/ includes.
7032         * rust-exp.y: Fix common/ includes.
7033         * rs6000-aix-tdep.c: Fix common/ includes.
7034         * riscv-tdep.c: Fix common/ includes.
7035         * remote.c: Fix common/ includes.
7036         * remote-notif.h: Fix common/ includes.
7037         * remote-fileio.h: Fix common/ includes.
7038         * remote-fileio.c: Fix common/ includes.
7039         * regcache.h: Fix common/ includes.
7040         * regcache.c: Fix common/ includes.
7041         * record-btrace.c: Fix common/ includes.
7042         * python/python.c: Fix common/ includes.
7043         * python/py-type.c: Fix common/ includes.
7044         * python/py-inferior.c: Fix common/ includes.
7045         * progspace.h: Fix common/ includes.
7046         * producer.c: Fix common/ includes.
7047         * procfs.c: Fix common/ includes.
7048         * proc-api.c: Fix common/ includes.
7049         * printcmd.c: Fix common/ includes.
7050         * ppc-linux-nat.c: Fix common/ includes.
7051         * parser-defs.h: Fix common/ includes.
7052         * osdata.c: Fix common/ includes.
7053         * obsd-nat.c: Fix common/ includes.
7054         * nat/x86-linux.c: Fix common/ includes.
7055         * nat/x86-linux-dregs.c: Fix common/ includes.
7056         * nat/x86-dregs.h: Fix common/ includes.
7057         * nat/x86-dregs.c: Fix common/ includes.
7058         * nat/ppc-linux.c: Fix common/ includes.
7059         * nat/mips-linux-watch.h: Fix common/ includes.
7060         * nat/mips-linux-watch.c: Fix common/ includes.
7061         * nat/linux-waitpid.c: Fix common/ includes.
7062         * nat/linux-ptrace.h: Fix common/ includes.
7063         * nat/linux-ptrace.c: Fix common/ includes.
7064         * nat/linux-procfs.c: Fix common/ includes.
7065         * nat/linux-personality.c: Fix common/ includes.
7066         * nat/linux-osdata.c: Fix common/ includes.
7067         * nat/linux-namespaces.c: Fix common/ includes.
7068         * nat/linux-btrace.h: Fix common/ includes.
7069         * nat/linux-btrace.c: Fix common/ includes.
7070         * nat/fork-inferior.c: Fix common/ includes.
7071         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7072         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7073         * nat/aarch64-linux.c: Fix common/ includes.
7074         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7075         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7076         * namespace.h: Fix common/ includes.
7077         * mips-linux-tdep.c: Fix common/ includes.
7078         * minsyms.c: Fix common/ includes.
7079         * mi/mi-parse.h: Fix common/ includes.
7080         * mi/mi-main.c: Fix common/ includes.
7081         * mi/mi-cmd-env.c: Fix common/ includes.
7082         * memrange.h: Fix common/ includes.
7083         * memattr.c: Fix common/ includes.
7084         * maint.h: Fix common/ includes.
7085         * maint.c: Fix common/ includes.
7086         * main.c: Fix common/ includes.
7087         * machoread.c: Fix common/ includes.
7088         * location.c: Fix common/ includes.
7089         * linux-thread-db.c: Fix common/ includes.
7090         * linux-nat.c: Fix common/ includes.
7091         * linux-fork.c: Fix common/ includes.
7092         * inline-frame.c: Fix common/ includes.
7093         * infrun.c: Fix common/ includes.
7094         * inflow.c: Fix common/ includes.
7095         * inferior.h: Fix common/ includes.
7096         * inferior.c: Fix common/ includes.
7097         * infcmd.c: Fix common/ includes.
7098         * inf-ptrace.c: Fix common/ includes.
7099         * inf-child.c: Fix common/ includes.
7100         * ia64-linux-nat.c: Fix common/ includes.
7101         * i387-tdep.c: Fix common/ includes.
7102         * i386-tdep.c: Fix common/ includes.
7103         * i386-linux-tdep.c: Fix common/ includes.
7104         * i386-linux-nat.c: Fix common/ includes.
7105         * i386-go32-tdep.c: Fix common/ includes.
7106         * i386-fbsd-tdep.c: Fix common/ includes.
7107         * i386-fbsd-nat.c: Fix common/ includes.
7108         * guile/scm-type.c: Fix common/ includes.
7109         * guile/guile.c: Fix common/ includes.
7110         * go32-nat.c: Fix common/ includes.
7111         * gnu-nat.c: Fix common/ includes.
7112         * gdbthread.h: Fix common/ includes.
7113         * gdbarch-selftests.c: Fix common/ includes.
7114         * gdb_usleep.c: Fix common/ includes.
7115         * gdb_select.h: Fix common/ includes.
7116         * gdb_bfd.c: Fix common/ includes.
7117         * gcore.c: Fix common/ includes.
7118         * fork-child.c: Fix common/ includes.
7119         * findvar.c: Fix common/ includes.
7120         * fbsd-nat.c: Fix common/ includes.
7121         * event-top.c: Fix common/ includes.
7122         * event-loop.c: Fix common/ includes.
7123         * dwarf2read.c: Fix common/ includes.
7124         * dwarf2loc.c: Fix common/ includes.
7125         * dwarf2-frame.c: Fix common/ includes.
7126         * dwarf-index-cache.c: Fix common/ includes.
7127         * dtrace-probe.c: Fix common/ includes.
7128         * disasm-selftests.c: Fix common/ includes.
7129         * defs.h: Fix common/ includes.
7130         * csky-tdep.c: Fix common/ includes.
7131         * cp-valprint.c: Fix common/ includes.
7132         * cp-support.h: Fix common/ includes.
7133         * cp-support.c: Fix common/ includes.
7134         * corelow.c: Fix common/ includes.
7135         * completer.h: Fix common/ includes.
7136         * completer.c: Fix common/ includes.
7137         * compile/compile.c: Fix common/ includes.
7138         * compile/compile-loc2c.c: Fix common/ includes.
7139         * compile/compile-cplus-types.c: Fix common/ includes.
7140         * compile/compile-cplus-symbols.c: Fix common/ includes.
7141         * command.h: Fix common/ includes.
7142         * cli/cli-dump.c: Fix common/ includes.
7143         * cli/cli-cmds.c: Fix common/ includes.
7144         * charset.c: Fix common/ includes.
7145         * build-id.c: Fix common/ includes.
7146         * btrace.h: Fix common/ includes.
7147         * btrace.c: Fix common/ includes.
7148         * breakpoint.h: Fix common/ includes.
7149         * breakpoint.c: Fix common/ includes.
7150         * ax.h:
7151         (enum agent_op): Fix common/ includes.
7152         * ax-general.c (struct aop_map): Fix common/ includes.
7153         * ax-gdb.c: Fix common/ includes.
7154         * auxv.c: Fix common/ includes.
7155         * auto-load.c: Fix common/ includes.
7156         * arm-tdep.c: Fix common/ includes.
7157         * arch/riscv.c: Fix common/ includes.
7158         * arch/ppc-linux-common.c: Fix common/ includes.
7159         * arch/i386.c: Fix common/ includes.
7160         * arch/arm.c: Fix common/ includes.
7161         * arch/arm-linux.c: Fix common/ includes.
7162         * arch/arm-get-next-pcs.c: Fix common/ includes.
7163         * arch/amd64.c: Fix common/ includes.
7164         * arch/aarch64.c: Fix common/ includes.
7165         * arch/aarch64-insn.c: Fix common/ includes.
7166         * arch-utils.c: Fix common/ includes.
7167         * amd64-windows-tdep.c: Fix common/ includes.
7168         * amd64-tdep.c: Fix common/ includes.
7169         * amd64-sol2-tdep.c: Fix common/ includes.
7170         * amd64-obsd-tdep.c: Fix common/ includes.
7171         * amd64-nbsd-tdep.c: Fix common/ includes.
7172         * amd64-linux-tdep.c: Fix common/ includes.
7173         * amd64-linux-nat.c: Fix common/ includes.
7174         * amd64-fbsd-tdep.c: Fix common/ includes.
7175         * amd64-fbsd-nat.c: Fix common/ includes.
7176         * amd64-dicos-tdep.c: Fix common/ includes.
7177         * amd64-darwin-tdep.c: Fix common/ includes.
7178         * agent.c: Fix common/ includes.
7179         * ada-lang.h: Fix common/ includes.
7180         * ada-lang.c: Fix common/ includes.
7181         * aarch64-tdep.c: Fix common/ includes.
7182
7183 2019-01-25  Tom Tromey  <tom@tromey.com>
7184
7185         * common/create-version.sh: Use common/version.h.
7186
7187 2019-01-24  Pedro Alves  <palves@redhat.com>
7188
7189         * infrun.c (signal_stop, signal_print, signal_program)
7190         (signal_catch, signal_pass): Now arrays instead of pointers.
7191         (update_signals_program_target, do_target_resume)
7192         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7193         * linux-nat.c (linux_nat_target::pass_signals)
7194         (linux_nat_target::create_inferior, linux_nat_target::attach):
7195         Adjust.
7196         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7197         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7198         * procfs.c (procfs_target::pass_signals): Adjust.
7199         * record-full.c (record_full_target::resume): Adjust.
7200         * remote.c (remote_target::pass_signals)
7201         (remote_target::program_signals): Adjust.
7202         * target-debug.h (target_debug_print_signals): Now takes a
7203         gdb::array_view as parameter.  Adjust.
7204         * target.h (target_ops) <pass_signals, program_signals>: Replace
7205         pointer and length parameters with gdb::array_view.
7206         (target_pass_signals, target_program_signals): Likewise.
7207         * target-delegates.c: Regenerate.
7208
7209 2019-01-24  Pedro Alves  <palves@redhat.com>
7210
7211         * common/forward-scope-exit.h
7212         (forward_scope_exit::forward_scope_exit): Pass arguments to
7213         m_bind_function directly, instead of creating a std::bind and
7214         copying that.
7215
7216 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7217
7218         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7219         for static members.
7220         (pass_in_v_vfp_candidate): Likewise.
7221
7222 2019-01-23  Tom Tromey  <tom@tromey.com>
7223             Pedro Alves  <palves@redhat.com>
7224
7225         * regcache.c (class regcache_invalidator): Remove.
7226         (regcache::raw_write): Use make_scope_exit.
7227
7228 2019-01-23  Tom Tromey  <tom@tromey.com>
7229
7230         * ui-out.h (class ui_out_emit_type): Update comment.
7231
7232 2019-01-23  Tom Tromey  <tom@tromey.com>
7233
7234         * infrun.c (fetch_inferior_event): Update comment.
7235
7236 2019-01-23  Tom Tromey  <tom@tromey.com>
7237             Pedro Alves  <palves@redhat.com>
7238
7239         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7240         parameter.
7241         (fetch_inferior_event): Use SCOPE_EXIT.
7242
7243
7244 2019-01-23  Tom Tromey  <tom@tromey.com>
7245             Pedro Alves  <palves@redhat.com>
7246
7247         * infrun.c (disable_thread_events): Delete.
7248         (stop_all_threads): Use SCOPE_EXIT.
7249
7250 2019-01-23  Tom Tromey  <tom@tromey.com>
7251             Pedro Alves  <palves@redhat.com>
7252
7253         * symfile.c: Include forward-scope-exit.h.
7254         (clear_symtab_users_cleanup): Replace forward declaration with
7255         a FORWARD_SCOPE_EXIT.
7256         (syms_from_objfile_1): Use the forward_scope_exit and
7257         gdb::optional instead of cleanup_function.
7258         (reread_symbols): Use the forward_scope_exit instead of
7259         cleanup_function.
7260         (clear_symtab_users_cleanup): Remove function.
7261
7262 2019-01-23  Tom Tromey  <tom@tromey.com>
7263             Pedro Alves  <palves@redhat.com>
7264
7265         * linux-nat.c: Include scope-exit.h.
7266         (cleanup_target_stop): Remove.
7267         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7268         SCOPE_EXIT.
7269
7270 2019-01-23  Tom Tromey  <tom@tromey.com>
7271             Pedro Alves  <palves@redhat.com>
7272
7273         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7274         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7275
7276 2019-01-23  Tom Tromey  <tom@tromey.com>
7277             Andrew Burgess  <andrew.burgess@embecosm.com>
7278             Pedro Alves  <palves@redhat.com>
7279
7280         * infrun.c (fetch_inferior_event): Use scope_exit.
7281         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7282         * top.c (execute_command): Use scope_exit.
7283         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7284         * utils.c (do_bpstat_clear_actions_cleanup)
7285         (make_bpstat_clear_actions_cleanup): Remove.
7286
7287 2019-01-23  Tom Tromey  <tom@tromey.com>
7288             Pedro Alves  <palves@redhat.com>
7289
7290         * infrun.c: Include "common/scope-exit.h"
7291         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7292         (wait_for_inferior): Use SCOPE_EXIT.
7293         (fetch_inferior_event): Use scope_exit.
7294
7295 2019-01-23  Tom Tromey  <tom@tromey.com>
7296             Pedro Alves  <palves@redhat.com>
7297
7298         * breakpoint.c (create_breakpoint): Remove cleanup.
7299
7300 2019-01-23  Tom Tromey  <tom@tromey.com>
7301             Andrew Burgess  <andrew.burgess@embecosm.com>
7302             Pedro Alves  <palves@redhat.com>
7303
7304 2019-01-23  Pedro Alves  <palves@redhat.com>
7305
7306         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7307
7308 2019-01-23  Pedro Alves  <palves@redhat.com>
7309             Andrew Burgess  <andrew.burgess@embecosm.com>
7310
7311         * gdbthread.h: Include "common/forward-scope-exit.h".
7312         (scoped_finish_thread_state): Redefine custom class in terms of
7313         forward_scope_exit.
7314
7315 2019-01-23  Pedro Alves  <palves@redhat.com>
7316             Andrew Burgess  <andrew.burgess@embecosm.com>
7317
7318         * common/forward-scope-exit.h: New file.
7319
7320 2019-01-23  Pedro Alves  <palves@redhat.com>
7321             Andrew Burgess  <andrew.burgess@embecosm.com>
7322             Tom Tromey  <tom@tromey.com>
7323
7324         * common/scope-exit.h: New file.
7325
7326 2019-01-23  Pedro Alves  <palves@redhat.com>
7327
7328         * common/preprocessor.h (ESC): Rename to ...
7329         (ESC_PARENS): ... this.
7330         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7331         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7332
7333 2019-01-23  Tom Tromey  <tom@tromey.com>
7334
7335         * language.h (class scoped_switch_to_sym_language_if_auto):
7336         Initialize m_lang in both cases.
7337
7338 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7339
7340         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7341         with XCNEW.
7342
7343 2019-01-22  Tom Tromey  <tom@tromey.com>
7344
7345         * corelow.c: Do not include sys/file.h.
7346
7347 2019-01-22  Tom Tromey  <tom@tromey.com>
7348
7349         * tui/tui-wingeneral.h: Include gdb_curses.h.
7350
7351 2019-01-22  Tom Tromey  <tom@tromey.com>
7352
7353         * source-cache.h (class source_cache) <get_source_lines,
7354         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7355
7356 2019-01-22  Tom Tromey  <tom@tromey.com>
7357
7358         * remote-fileio.h (struct remote_target): Declare.
7359
7360 2019-01-22  Tom Tromey  <tom@tromey.com>
7361
7362         * python/py-arch.c: Do not include py-ref.h.
7363         * python/py-bpevent.c: Do not include py-ref.h.
7364         * python/py-cmd.c: Do not include py-ref.h.
7365         * python/py-continueevent.c: Do not include py-ref.h.
7366         * python/py-event.h: Do not include py-ref.h.
7367         * python/py-evtregistry.c: Do not include py-ref.h.
7368         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7369         * python/py-frame.c: Do not include py-ref.h.
7370         * python/py-framefilter.c: Do not include py-ref.h.
7371         * python/py-function.c: Do not include py-ref.h.
7372         * python/py-infevents.c: Do not include py-ref.h.
7373         * python/py-linetable.c: Do not include py-ref.h.
7374         * python/py-objfile.c: Do not include py-ref.h.
7375         * python/py-param.c: Do not include py-ref.h.
7376         * python/py-prettyprint.c: Do not include py-ref.h.
7377         * python/py-progspace.c: Do not include py-ref.h.
7378         * python/py-symbol.c: Do not include py-ref.h.
7379         * python/py-symtab.c: Do not include py-ref.h.
7380         * python/py-type.c: Do not include py-ref.h.
7381         * python/py-unwind.c: Do not include py-ref.h.
7382         * python/py-utils.c: Do not include py-ref.h.
7383         * python/py-value.c: Do not include py-ref.h.
7384         * python/py-varobj.c: Do not include py-ref.h.
7385         * python/py-xmethods.c: Do not include py-ref.h.
7386         * python/python.c: Do not include py-ref.h.
7387         * varobj.c: Do not include py-ref.h.
7388
7389 2019-01-22  Tom Tromey  <tom@tromey.com>
7390
7391         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7392         keyword for bcache.
7393
7394 2019-01-22  Tom Tromey  <tom@tromey.com>
7395
7396         * compile/compile-cplus-types.c: Remove a comment by #include.
7397
7398 2019-01-22  Tom Tromey  <tom@tromey.com>
7399
7400         * compile/gcc-c-plugin.h: Include compile-internal.h.
7401
7402 2019-01-22  Tom Tromey  <tom@tromey.com>
7403
7404         * stabsread.c (EXTERN): Do not define.
7405         (symnum, next_symbol_text_func, processing_gcc_compilation)
7406         (within_function, global_sym_chain, global_stabs)
7407         (previous_stab_code, this_object_header_files)
7408         (n_this_object_header_files)
7409         (n_allocated_this_object_header_files): Define.
7410         * stabsread.h (EXTERN): Never define.  Use "extern".
7411
7412 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7413
7414         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7415         history_value.
7416
7417 2019-01-21  Tom Tromey  <tom@tromey.com>
7418
7419         * ui-out.c: Fix includes.
7420         * tui/tui-source.c: Fix includes.
7421         * target.c: Fix includes.
7422         * remote.c: Fix includes.
7423         * regcache.c: Fix includes.
7424         * python/py-block.c: Fix includes.
7425         * printcmd.c: Fix includes.
7426         * or1k-tdep.c: Fix includes.
7427         * mi/mi-main.c: Fix includes.
7428         * m32r-tdep.c: Fix includes.
7429         * csky-tdep.c: Fix includes.
7430         * compile/compile-cplus-types.c: Fix includes.
7431         * cli/cli-interp.c: Fix includes.
7432
7433 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7434
7435         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7436         for padding.
7437
7438 2019-01-16  Tom Tromey  <tom@tromey.com>
7439
7440         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7441         earlier.
7442         (struct objfile) <msymbols_range>: Move from top level.
7443         <msymbols>: New method.
7444         (class objfile_msymbols): Remove.
7445         * symtab.c (default_collect_symbol_completion_matches_break_on):
7446         Update.
7447         * symmisc.c (dump_msymbols): Update.
7448         * stabsread.c (scan_file_globals): Update.
7449         * objc-lang.c (info_selectors_command, info_classes_command)
7450         (find_methods): Update.
7451         * minsyms.c (find_solib_trampoline_target): Update.
7452         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7453         * coffread.c (coff_symfile_read): Update.
7454         * ada-lang.c (ada_lookup_simple_minsym)
7455         (ada_collect_symbol_completion_matches): Update.
7456
7457 2019-01-16  Tom Tromey  <tom@tromey.com>
7458
7459         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7460         type.  Remove no-argument constructor.
7461         <iterator::operator++>: Simplify.
7462         <begin>: Update.
7463         <end>: Use minimal_symbol_count.
7464
7465 2019-01-16  Tom Tromey  <tom@tromey.com>
7466
7467         * objfiles.h (struct objfile) <psymtabs>: New method.
7468         (class objfile_psymtabs): Remove.
7469         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7470         typedef.
7471         <range>: New method.
7472         (require_partial_symbols): Change return type.
7473         * psymtab.c (require_partial_symbols)
7474         (psym_expand_symtabs_matching): Update.
7475         * mdebugread.c (parse_partial_symbols): Update.
7476         * dbxread.c (dbx_end_psymtab): Update.
7477
7478 2019-01-15  Tom Tromey  <tom@tromey.com>
7479
7480         * symtab.c (lookup_objfile_from_block)
7481         (lookup_symbol_in_objfile_symtabs)
7482         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7483         (find_line_symtab, info_sources_command)
7484         (default_collect_symbol_completion_matches_break_on)
7485         (make_source_files_completion_list): Update.
7486         * symmisc.c (print_objfile_statistics, dump_objfile)
7487         (maintenance_print_symbols, maintenance_info_symtabs)
7488         (maintenance_check_symtabs, maintenance_info_line_tables):
7489         Update.
7490         * source.c (select_source_symtab)
7491         (forget_cached_source_info_for_objfile): Update.
7492         * objfiles.h (class objfile_compunits): Remove.
7493         (struct objfile) <compunits_range>: New typedef.
7494         (compunits): New method.
7495         * objfiles.c (objfile_relocate1): Update.
7496         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7497         * maint.c (count_symtabs_and_blocks): Update.
7498         * linespec.c (iterate_over_all_matching_symtabs): Update.
7499         * cp-support.c (add_symbol_overload_list_qualified): Update.
7500         * coffread.c (coff_symtab_read): Update.
7501         * ada-lang.c (add_nonlocal_symbols)
7502         (ada_collect_symbol_completion_matches)
7503         (ada_add_global_exceptions): Update.
7504
7505 2019-01-15  Tom Tromey  <tom@tromey.com>
7506
7507         * progspace.h (program_space) <objfiles_safe_range>: New
7508         typedef.
7509         <objfiles_safe>: New method.
7510         * objfiles.h (class all_objfiles_safe): Remove.
7511         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7512         * jit.c (jit_inferior_exit_hook): Update.
7513
7514 2019-01-17  Tom Tromey  <tom@tromey.com>
7515
7516         * progspace.h (program_space) <objfiles_range>: New typedef.
7517         <objfiles>: New method.
7518         <objfiles_head>: Rename from objfiles.
7519         (object_files): Update.
7520         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7521         * guile/scm-pretty-print.c
7522         (ppscm_find_pretty_printer_from_objfiles): Update.
7523         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7524         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7525         Update.
7526         * python/py-progspace.c (pspy_get_objfiles): Update.
7527         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7528         Update.
7529         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7530         (objfpy_lookup_objfile_by_build_id): Update.
7531         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7532         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7533         Update.
7534         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7535         (expand_symtab_containing_pc, lookup_objfile_from_block)
7536         (lookup_static_symbol, basic_lookup_transparent_type)
7537         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7538         (find_line_symtab, info_sources_command)
7539         (default_collect_symbol_completion_matches_break_on)
7540         (make_source_files_completion_list, find_main_name): Update.
7541         * symmisc.c (print_symbol_bcache_statistics)
7542         (print_objfile_statistics, maintenance_print_symbols)
7543         (maintenance_print_msymbols, maintenance_print_objfiles)
7544         (maintenance_info_symtabs, maintenance_check_symtabs)
7545         (maintenance_expand_symtabs, maintenance_info_line_tables):
7546         Update.
7547         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7548         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7549         (map_overlay_command, unmap_overlay_command)
7550         (simple_overlay_update, expand_symtabs_matching)
7551         (map_symbol_filenames): Update.
7552         * symfile-debug.c (set_debug_symfile): Update.
7553         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7554         Update.
7555         * source.c (select_source_symtab, forget_cached_source_info):
7556         Update.
7557         * solib.c (solib_read_symbols): Update.
7558         * solib-spu.c (append_ocl_sos): Update.
7559         * psymtab.c (maintenance_print_psymbols)
7560         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7561         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7562         * printcmd.c (info_symbol_command): Update.
7563         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7564         Update.
7565         * objfiles.h (class all_objfiles): Remove.
7566         * objfiles.c (have_partial_symbols, have_full_symbols)
7567         (have_minimal_symbols, qsort_cmp, update_section_map)
7568         (shared_objfile_contains_address_p)
7569         (default_iterate_over_objfiles_in_search_order): Update.
7570         * objc-lang.c (info_selectors_command, info_classes_command)
7571         (find_methods): Update.
7572         * minsyms.c (find_solib_trampoline_target): Update.
7573         * maint.c (maintenance_info_sections)
7574         (maintenance_translate_address, count_symtabs_and_blocks):
7575         Update.
7576         * main.c (captured_main_1): Update.
7577         * linux-thread-db.c (try_thread_db_load_from_pdir)
7578         (has_libpthread): Update.
7579         * linespec.c (iterate_over_all_matching_symtabs)
7580         (search_minsyms_for_name): Update.
7581         * jit.c (jit_find_objf_with_entry_addr): Update.
7582         * hppa-tdep.c (find_unwind_entry)
7583         (hppa_lookup_stub_minimal_symbol): Update.
7584         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7585         Update.
7586         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7587         (elf_gnu_ifunc_resolve_by_got): Update.
7588         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7589         * dwarf-index-write.c (save_gdb_index_command): Update.
7590         * cp-support.c (add_symbol_overload_list_qualified): Update.
7591         * breakpoint.c (create_overlay_event_breakpoint)
7592         (create_longjmp_master_breakpoint)
7593         (create_std_terminate_master_breakpoint)
7594         (create_exception_master_breakpoint): Update.
7595         * blockframe.c (find_pc_partial_function): Update.
7596         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7597         (ada_collect_symbol_completion_matches)
7598         (ada_add_global_exceptions): Update.
7599
7600 2019-01-17  Tom Tromey  <tom@tromey.com>
7601
7602         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7603         declare VEC.
7604         (solib_target_parse_libraries): Change return type.
7605         (library_list_start_segment, library_list_start_section)
7606         (library_list_end_library, library_list_start_library); Update.
7607         (solib_target_free_library_list): Remove.
7608         (solib_target_parse_libraries): Remove cleanup.  Change return
7609         type.
7610         (solib_target_current_sos): Update.
7611
7612 2019-01-17  Tom Tromey  <tromey@bapiya>
7613
7614         * valprint.c: Replace "the the" with "the".
7615         * symtab.c: Replace "the the" with "the".
7616         * solib.c: Replace "the the" with "the".
7617         * solib-dsbt.c: Replace "the the" with "the".
7618         * linespec.c: Replace "the the" with "the".
7619         * dwarf2loc.h: Replace "the the" with "the".
7620         * amd64-windows-tdep.c: Replace "the the" with "the".
7621         * aarch64-tdep.c: Replace "the the" with "the".
7622
7623 2019-01-16  Keith Seitz  <keiths@redhat.com>
7624
7625         PR gdb/23773
7626         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7627         <builder>: Rename to ..
7628         <m_builder>: ... this and make private.
7629         (dwarf2_cu::get_builder): New method.  Change all users of
7630         `builder' to use this method.
7631         (dwarf2_start_symtab): Move to ...
7632         (dwarf2_cu::start_symtab): ... here.  Update all callers
7633         (setup_type_unit_groups): Move to ...
7634         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7635         callers.
7636         (dwarf2_cu::reset_builder): New method.
7637         (process_full_compunit, process_full_type_unit): Use
7638         dwarf2_cu::reset_builder.
7639         (follow_die_offset): Record the ancestor CU if it is different
7640         from the followed DIE's CU.
7641         (follow_die_sig_1): Likewise.
7642
7643 2019-01-15  Tom Tromey  <tom@tromey.com>
7644
7645         * remote.c (class remote_state) <buf>: Now a char_vector.
7646         <buf_size>: Remove.
7647         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7648         parameter.
7649         (remote_target::getpkt_or_notif_sane_1)
7650         (remote_target::getpkt_sane)
7651         (remote_target::getpkt_or_notif_sane): Likewise.
7652         (class remote_target) <putpkt>: New overload.
7653         (remote_target::read_frame): Change type of "buf_p".  Remove
7654         sizeof_p parameter.
7655         (packet_ok): New overload.
7656         (packet_check_result): New overload.
7657         Update all uses.
7658
7659 2019-01-14  Tom Tromey  <tom@tromey.com>
7660
7661         * remote-notif.c (handle_notification, remote_notif_ack)
7662         (remote_notif_parse): Make "buf" const.
7663         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7664         const.
7665         (remote_notif_parse, remote_notif_ack, handle_notification):
7666         Likewise.
7667         * remote.c (remote_notif_stop_parse): Make "buf" const.
7668         (remote_target::remote_parse_stop_reply): Make "buf" const.
7669         (remote_notif_stop_ack): Make "buf" const.
7670
7671 2019-01-14  Tom Tromey  <tom@tromey.com>
7672
7673         * remote.c (remote_console_output): Make parameter const.
7674
7675 2019-01-14  Tom Tromey  <tom@tromey.com>
7676
7677         * target-debug.h (target_debug_print_signals): Constify.
7678         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7679         * procfs.c (procfs_target::pass_signals): Update.
7680         * linux-nat.c (linux_nat_target::pass_signals): Update.
7681         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7682         * target-delegates.c: Rebuild.
7683         * remote.c (remote_target::program_signals): Update.
7684         (remote_target::pass_signals): Update.
7685         * target.c (target_pass_signals): Constify argument.
7686         (target_program_signals): Likewise.
7687         * target.h (struct target_ops) <pass_signals, program_signals>:
7688         Constify argument.
7689         (target_pass_signals, target_program_signals): Constify argument.
7690
7691 2019-01-14  Tom Tromey  <tom@tromey.com>
7692
7693         PR tui/28819:
7694         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7695
7696 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7697
7698         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7699         field.
7700         * rs6000-tdep.c: Include reggroups.h.
7701         (IS_V_ALIAS_PSEUDOREG): Define.
7702         (rs6000_register_name): Return names for the "vX" aliases.
7703         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7704         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7705         aliases.  Call default_register_reggroup_p for all other
7706         pseudo-registers.
7707         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7708         New functions.
7709         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7710         Handle "vX" aliases.
7711         (v_alias_pseudo_register_collect): New function.
7712         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7713         (rs6000_gdbarch_init): Initialize "vX" aliases as
7714         pseudo-registers.  Restore registration of
7715         rs6000_pseudo_register_reggroup_p with
7716         set_tdesc_pseudo_register_reggroup_p.
7717
7718 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7719
7720         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7721         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7722         set_gdbarch_num_pseudo_regs.
7723
7724 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7725
7726         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7727         Remove arg prefixname, add do_set and do_show.
7728         Add member functions set_list and show_list.
7729         * cli/cli-style.c (class cli_style_option): Update accordingly.
7730         (style_set_list): Move to file scope.
7731         (style_show_list): Likewise.
7732         (set_style): Call help_list.
7733         (show_style): Call cmd_show_list.
7734         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7735         Update to use the new macro.
7736
7737 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7738
7739         * ada-lang.c (_initialize_ada_language): Expand the help text
7740         for the "catch exception" command.
7741
7742 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7743
7744         * symtab.c (matching_obj_sections): Initialize obj,
7745         declare it closer to its usage.
7746
7747 2019-01-10  Tom Tromey  <tom@tromey.com>
7748
7749         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7750         (basic_inf_threads_range): Remove.
7751         (inf_threads_range, inf_non_exited_threads_range)
7752         (safe_inf_threads_range): Use next_adapter.
7753
7754 2019-01-10  Keith Seitz  <keiths@redhat.com>
7755
7756         PR gdb/23712
7757         PR symtab/23010
7758         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7759         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7760
7761 2019-01-10  Keith Seitz  <keiths@redhat.com>
7762
7763         PR gdb/23712
7764         PR symtab/23010
7765         * dictionary.c (pending_to_vector): Remove.
7766         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7767         Remove _1 suffix, replacing functions of the same name.  Update
7768         all callers.
7769         (dict_create_hashed, dict_create_hashed_expandable)
7770         (dict_create_linear, dict_create_linear_expandable, dict_free)
7771         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7772         Make functions static.
7773
7774 2019-01-10  Keith Seitz  <keiths@redhat.com>
7775
7776         PR gdb/23712
7777         PR symtab/23010
7778         * dictionary.h (struct dictionary): Replace declaration with
7779         multidictionary.
7780         (dict_create_hashed, dict_create_hashed_expandable)
7781         (dict_create_linear, dict_create_linear_expandable)
7782         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7783         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7784         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7785         taking multidictionary argument.
7786         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7787         * block.h (struct block) <dict>: Change to multidictionary
7788         and rename `multidict'.
7789         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7790         symmisc.c: Update all dictionary references to multidictionary.
7791
7792 2019-01-10  Keith Seitz  <keiths@redhat.com>
7793
7794         PR gdb/23712
7795         PR symtab/23010
7796         * dictionary.c: Include unordered_map.
7797         (pending_to_vector): New function.
7798         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7799         Rewrite the non-"_1" functions to take vector instead
7800         of linked list.
7801         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7802         "new" _1 versions of the same name.
7803         (multidictionary): Define.
7804         (std::hash<enum language): New definition.
7805         (collate_pending_symbols_by_language, mdict_create_hashed)
7806         (mdict_create_hashed_expandable, mdict_create_linear)
7807         (mdict_create_linear_expandable, mdict_free)
7808         (find_language_dictionary, create_new_language_dictionary)
7809         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7810         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7811         (mdict_size, mdict_empty): New functions.
7812         * dictionary.h (mdict_iterator): Define.
7813
7814 2019-01-10  Pedro Alves  <palves@redhat.com>
7815
7816         * breakpoint.c (read_uploaded_action)
7817         (create_tracepoint_from_upload): Adjust to use
7818         gdb::unique_xmalloc_ptr.
7819         * ctf.c (ctf_write_uploaded_tp):
7820         (SET_ARRAY_FIELD): Use emplace_back.
7821         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7822         * tracefile-tfile.c (tfile_write_uploaded_tp):
7823         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7824         gdb::unique_xmalloc_ptr.
7825         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7826         at_string, cond_string, cmd_strings>: Replace char pointers
7827         with gdb::unique_xmalloc_ptr.
7828
7829 2019-01-10  Pedro Alves  <palves@redhat.com>
7830
7831         * solib-target.c (library_list_start_library): Don't xstrdup name.
7832
7833 2019-01-10  Pedro Alves  <palves@redhat.com>
7834
7835         * mdebugread.c (parse_partial_symbols): Use
7836         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7837
7838 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7839
7840         * linux-fork.c (scoped_switch_fork_info)
7841         <~scoped_switch_fork_info>: Fix incorrect variable name.
7842
7843 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7844
7845         * linux-fork.c (scoped_switch_fork_info)
7846         <scoped_switch_fork_info>: Make explicit.
7847         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7848
7849 2019-01-10  Tom Tromey  <tom@tromey.com>
7850
7851         * objfiles.h (objfile::reset_psymtabs): Update.
7852         * objfiles.c (objfile::objfile): Update.
7853         * psymtab.h (psymtab_storage::obstack): Update.
7854         (psymtab_storage::m_obstack): Use gdb::optional.
7855         (class psymtab_storage): Update comment.  Remove objfile
7856         parameter.
7857         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7858
7859 2019-01-10  Tom Tromey  <tom@tromey.com>
7860
7861         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7862         <free_psymtabs>: Now private.
7863         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7864         (allocate_psymtab): Use new method.
7865
7866 2019-01-10  Tom Tromey  <tom@tromey.com>
7867
7868         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7869         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7870         * mdebugread.c (parse_partial_symbols): Use
7871         allocate_dependencies.
7872         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7873         allocate_dependencies.
7874         (process_psymtab_comp_unit_reader)
7875         (build_type_psymtab_dependencies): Likewise.
7876         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7877
7878 2019-01-10  Tom Tromey  <tom@tromey.com>
7879
7880         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7881         PSYMBOL_SET_LANGUAGE.
7882         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7883
7884 2019-01-10  Tom Tromey  <tom@tromey.com>
7885
7886         * psymtab.h (psymtab_storage::obstack): New method.
7887         <m_obstack>: Rename from obstack; now private.
7888         * psymtab.c (psymtab_storage): Update.
7889         * dwarf2read.c (create_addrmap_from_index)
7890         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7891         Update.
7892
7893 2019-01-10  Tom Tromey  <tom@tromey.com>
7894
7895         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7896         * objfiles.h (objfile::reset_psymtabs): New method.
7897
7898 2019-01-10  Tom Tromey  <tom@tromey.com>
7899
7900         * symmisc.c (print_symbol_bcache_statistics): Update.
7901         (print_objfile_statistics): Update.
7902         * symfile.c (reread_symbols): Update.
7903         * psymtab.h (class psymtab_storage): New.
7904         * psymtab.c (psymtab_storage): New constructor.
7905         (~psymtab_storage): New destructor.
7906         (require_partial_symbols): Update.
7907         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7908         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7909         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7910         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7911         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7912         (start_psymtab_common, end_psymtab_common)
7913         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7914         (allocate_psymtab): Update.
7915         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7916         Update.
7917         (dump_psymtab_addrmap, maintenance_print_psymbols)
7918         (maintenance_check_psymtabs): Update.
7919         (class objfile_psymtabs): Move to objfiles.h.
7920         * psympriv.h (discard_psymtab): Now inline.
7921         (psymtab_discarder::psymtab_discarder): Update.
7922         (psymtab_discarder::~psymtab_discarder): Update.
7923         (ALL_OBJFILE_PSYMTABS): Rewrite.
7924         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7925         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7926         Remove fields.
7927         <partial_symtabs>: New field.
7928         (class objfile_psymtabs): Move from psymtab.h.  Update.
7929         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7930         psymbol_cache.
7931         (objfile::~objfile): Don't destroy psymbol_cache.
7932         * mdebugread.c (parse_partial_symbols): Update.
7933         * dwarf2read.c (create_addrmap_from_index)
7934         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7935         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7936         (add_partial_subprogram, dwarf2_ranges_read): Update.
7937         * dwarf-index-write.c (write_address_map)
7938         (write_one_signatured_type, recursively_write_psymbols)
7939         (class debug_names, class debug_names, write_psymtabs_to_index):
7940         Update.
7941
7942 2019-01-10  Tom Tromey  <tom@tromey.com>
7943
7944         * symtab.h (SYMBOL_SET_NAMES): Update.
7945         (symbol_set_names): Update.
7946         (MSYMBOL_SET_NAMES): Update.
7947         * symtab.c (symbol_set_names): Change argument to be an
7948         objfile_per_bfd_storage.
7949         * psymtab.c (add_psymbol_to_bcache): Update.
7950         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7951
7952 2019-01-10  Tom Tromey  <tom@tromey.com>
7953
7954         * symtab.c (create_demangled_names_hash): Change argument to be an
7955         objfile_per_bfd_storage.
7956         (symbol_set_names): Update.
7957
7958 2019-01-10  Tom Tromey  <tom@tromey.com>
7959
7960         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7961         init_psymbol_list.
7962         * psymtab.c (init_psymbol_list): Do nothing if already called.
7963         * psympriv.h (init_psymbol_list): Add comment.
7964         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7965         init_psymbol_list.
7966         * dbxread.c (dbx_symfile_read): Unconditionally call
7967         init_psymbol_list.
7968
7969 2019-01-10  Tom Tromey  <tom@tromey.com>
7970
7971         * xcoffread.c (scan_xcoff_symtab): Update.
7972         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7973         "where".
7974         * mdebugread.c (parse_partial_symbols)
7975         (handle_psymbol_enumerators): Update.
7976         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7977         * dbxread.c (read_dbx_symtab): Update.
7978         * psympriv.h (psymbol_placement): New enum.
7979         (add_psymbol_to_list): Update.
7980
7981 2019-01-10  Tom Tromey  <tom@tromey.com>
7982
7983         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7984         static_psymbols parameters.
7985         (scan_xcoff_symtab): Update.
7986         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7987         static_psymbols parameters.
7988         * psympriv.h (start_psymtab_common): Update.
7989         * mdebugread.c (parse_partial_symbols): Update.
7990         * dwarf2read.c (create_partial_symtab): Update.
7991         * dbxread.c (read_dbx_symtab): Update.
7992         (start_psymtab): Remove global_psymbols and static_psymbols
7993         parameters.
7994
7995 2019-01-10  Tom Tromey  <tom@tromey.com>
7996
7997         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7998         * psymtab.c (allocate_psymtab): Add comment.
7999         * psympriv.h (allocate_psymtab): Add comment.
8000         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8001         initializations.
8002         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8003
8004 2019-01-10  Tom Tromey  <tom@tromey.com>
8005
8006         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8007         Don't declare.
8008         * mipsread.c: Include mdebugread.h.
8009         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8010         Declare.
8011         * elfread.c: Include mdebugread.h.
8012
8013 2019-01-09  Tom Tromey  <tom@tromey.com>
8014
8015         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8016         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8017         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8018         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8019         (psym_lookup_symbol, psym_find_last_source_symtab)
8020         (psym_forget_cached_source_info, psym_print_stats)
8021         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8022         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8023         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8024         (psym_find_compunit_symtab_by_address)
8025         (maintenance_print_psymbols, maintenance_info_psymtabs)
8026         (maintenance_check_psymtabs): Use ranged for.
8027         * psymtab.h (class objfile_psymtabs): New.
8028         (require_partial_symbols): Return objfile_psymtabs.
8029         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8030
8031 2019-01-09  Tom Tromey  <tom@tromey.com>
8032
8033         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8034         (find_pc_mapped_section, list_overlays_command)
8035         (map_overlay_command, unmap_overlay_command)
8036         (simple_overlay_update): Use all_objfiles.
8037         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8038         * printcmd.c (info_symbol_command): Use all_objfiles.
8039         * objfiles.h (ALL_OBJSECTIONS): Remove.
8040         * maint.c (maintenance_translate_address): Use all_objfiles.
8041         * gcore.c (gcore_create_callback): Use all_objfiles.
8042         (objfile_find_memory_regions): Likewise.
8043
8044 2019-01-09  Tom Tromey  <tom@tromey.com>
8045
8046         * symtab.c (find_line_symtab, info_sources_command)
8047         (make_source_files_completion_list): Use objfile_compunits.
8048         * source.c (select_source_symtab): Use objfile_compunits.
8049         * objfiles.h (struct objfile): Update comment.
8050         (ALL_OBJFILES): Remove.
8051         (ALL_FILETABS): Remove.
8052         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8053         objfile_compunits.
8054
8055 2019-01-09  Tom Tromey  <tom@tromey.com>
8056
8057         * symmisc.c (print_objfile_statistics, dump_objfile)
8058         (maintenance_print_symbols): Use compunit_filetabs.
8059         * source.c (forget_cached_source_info_for_objfile): Use
8060         compunit_filetabs.
8061         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8062         (ALL_FILETABS): Use compunit_filetabs.
8063         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8064         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8065
8066 2019-01-09  Tom Tromey  <tom@tromey.com>
8067
8068         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8069         (compunit_filetabs): New.
8070         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8071         compunit_filetabs.
8072         (info_sources_command, make_source_files_completion_list): Remove
8073         declaration.
8074         * symmisc.c (print_objfile_statistics, dump_objfile)
8075         (maintenance_print_symbols): Remove declaration.
8076         (maintenance_info_symtabs): Use compunit_filetabs.
8077         (maintenance_info_line_tables): Likewise.
8078         * source.c (select_source_symtab): Change local variable name.
8079         (forget_cached_source_info_for_objfile): Remove declaration.
8080         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8081         * objfiles.c (objfile_relocate1): Remove declaration.
8082         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8083         declaration.
8084         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8085         * coffread.c (coff_symtab_read): Remove declaration.
8086         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8087         compunit_filetabs.
8088
8089 2019-01-09  Tom Tromey  <tom@tromey.com>
8090
8091         * symtab.c (lookup_objfile_from_block)
8092         (find_pc_sect_compunit_symtab, search_symbols)
8093         (default_collect_symbol_completion_matches_break_on): Use
8094         objfile_compunits.
8095         * objfiles.h (ALL_COMPUNITS): Remove.
8096         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8097         * cp-support.c (add_symbol_overload_list_qualified): Use
8098         objfile_compunits.
8099         * ada-lang.c (ada_collect_symbol_completion_matches)
8100         (ada_add_global_exceptions): Use objfile_compunits.
8101
8102 2019-01-09  Tom Tromey  <tom@tromey.com>
8103
8104         * source.c (select_source_symtab)
8105         (forget_cached_source_info_for_objfile): Remove declaration.
8106         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8107         declaration.
8108         * maint.c (count_symtabs_and_blocks): Remove declaration.
8109         * cp-support.c (add_symbol_overload_list_qualified): Remove
8110         declaration.
8111         * coffread.c (coff_symtab_read): Remove declaration.
8112         * symtab.c (lookup_symbol_in_objfile_symtabs)
8113         (basic_lookup_transparent_type_1): Use objfile_compunits.
8114         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8115         (info_sources_command, search_symbols)
8116         (default_collect_symbol_completion_matches_break_on)
8117         (make_source_files_completion_list): Remove declaration.
8118         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8119         (ada_collect_symbol_completion_matches)
8120         (ada_add_global_exceptions): Remove declaration.
8121         * linespec.c (iterate_over_all_matching_symtabs): Use
8122         objfile_compunits.
8123         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8124         (class objfile_compunits): New.
8125         (ALL_COMPUNITS): Use objfile_compunits.
8126         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8127         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8128         objfile_compunits.
8129         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8130
8131 2019-01-09  Tom Tromey  <tom@tromey.com>
8132
8133         * symtab.c (search_symbols)
8134         (default_collect_symbol_completion_matches_break_on): Use
8135         objfile_msymbols.
8136         * ada-lang.c (ada_lookup_simple_minsym)
8137         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8138         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8139         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8140         objfile_msymbols.
8141         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8142         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8143         * objc-lang.c (find_methods): Use objfile_msymbols.
8144         (info_selectors_command, info_classes_command): Likewise.
8145         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8146         * objfiles.h (class objfile_msymbols): New.
8147         (ALL_OBJFILE_MSYMBOLS): Remove.
8148         (ALL_MSYMBOLS): Remove.
8149
8150 2019-01-09  Tom Tromey  <tom@tromey.com>
8151
8152         * common/next-iterator.h (next_adapter): Add Iterator template
8153         parameter.
8154         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8155         (class all_objfiles_safe): New.
8156         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8157         * objfiles.c (put_objfile_before): Update comment.
8158         (add_separate_debug_objfile): Likewise.
8159         (free_all_objfiles): Use all_objfiles_safe.
8160         (objfile_purge_solibs): Likewise.
8161
8162 2019-01-09  Tom Tromey  <tom@tromey.com>
8163
8164         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8165         (expand_symtab_containing_pc, lookup_static_symbol)
8166         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8167         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8168         all_objfiles.
8169         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8170         * breakpoint.c (create_overlay_event_breakpoint)
8171         (create_longjmp_master_breakpoint)
8172         (create_std_terminate_master_breakpoint)
8173         (create_exception_master_breakpoint): Use all_objfiles.
8174         * linux-thread-db.c (try_thread_db_load_from_pdir)
8175         (has_libpthread): Use all_objfiles.
8176         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8177         * linespec.c (iterate_over_all_matching_symtabs)
8178         (search_minsyms_for_name): Use all_objfiles.
8179         * maint.c (maintenance_info_sections): Use all_objfiles.
8180         * main.c (captured_main_1): Use all_objfiles.
8181         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8182         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8183         * guile/scm-pretty-print.c
8184         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8185         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8186         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8187         (maintenance_print_msymbols): Use all_objfiles.
8188         * source.c (select_source_symtab): Use all_objfiles.
8189         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8190         * symfile.c (remove_symbol_file_command)
8191         (expand_symtabs_matching, map_symbol_filenames): Use
8192         all_objfiles.
8193         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8194         all_objfiles.
8195         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8196         * objc-lang.c (find_methods): Use all_objfiles.
8197         * objfiles.c (have_partial_symbols, have_full_symbols)
8198         (have_minimal_symbols, qsort_cmp)
8199         (default_iterate_over_objfiles_in_search_order): Use
8200         all_objfiles.
8201         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8202         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8203         (maintenance_check_psymtabs): Use all_objfiles.
8204         (ALL_PSYMTABS): Remove.
8205         * compile/compile-object-run.c (do_module_cleanup): Use
8206         all_objfiles.
8207         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8208         * cp-support.c (add_symbol_overload_list_qualified): Use
8209         all_objfiles.
8210         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8211         Use all_objfiles.
8212         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8213         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8214         all_objfiles.
8215         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8216         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8217         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8218         Uses all_objfiles.
8219         * solib.c (solib_read_symbols): Use all_objfiles
8220
8221 2019-01-09  Tom Tromey  <tom@tromey.com>
8222
8223         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8224         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8225         all_objfiles.
8226         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8227         * symmisc.c (print_symbol_bcache_statistics)
8228         (print_objfile_statistics, maintenance_print_objfiles)
8229         (maintenance_info_symtabs, maintenance_check_symtabs)
8230         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8231         all_objfiles.
8232         * source.c (forget_cached_source_info): Use all_objfiles.
8233         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8234         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8235         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8236         * objfiles.c (update_section_map): Use all_objfiles.
8237         (shared_objfile_contains_address_p): Likewise.
8238         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8239         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8240
8241 2019-01-09  Tom Tromey  <tom@tromey.com>
8242
8243         * common/next-iterator.h: New file.
8244         * objfiles.h (class all_objfiles): New.
8245         (struct objfile_iterator): New.
8246
8247 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8248
8249         * NEWS: Move the description of the changed "frame", "select-frame",
8250          and "info frame" commands to the Changed commands section.
8251
8252 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8253
8254         * gdbtypes.c (check_stub_method_group): Remove handling of old
8255         mangling schemes.
8256         * linespec.c (find_methods): Likewise.
8257         * stabsread.c (read_member_functions): Likewise.
8258         * valops.c (search_struct_method): Likewise.
8259         (value_struct_elt_for_reference): Likewise.
8260         * NEWS: Mention this change.
8261
8262 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8263
8264         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8265         print_source_lines.
8266         * source.c (print_source_lines_base): Update line number check.
8267         (print_source_lines): New function.
8268         (source_lines_range::source_lines_range): New function.
8269         * source.h (class source_lines_range): New class.
8270         (print_source_lines): New declaration.
8271
8272 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8273
8274         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8275
8276 2019-01-08  Tom Tromey  <tom@tromey.com>
8277             Simon Marchi  <simon.marchi@ericsson.com>
8278
8279         PR gdb/24060
8280         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8281         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8282         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8283         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8284         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8285         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8286
8287 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8288
8289         * source.c (select_source_symtab): Move header comment to
8290         declaration in source.h.
8291         (forget_cached_source_info_for_objfile): Likewise.
8292         (forget_cached_source_info): Likewise.
8293         (identify_source_line): Likewise.
8294         * source.h (identify_source_line): Move declaration from symtab.h
8295         and add comment from source.c
8296         (print_source_lines): Likewise.
8297         (forget_cached_source_info_for_objfile): Likewise.
8298         (forget_cached_source_info): Likewise.
8299         (select_source_symtab): Likewise.
8300         (enum print_source_lines_flag): Move definition from symtab.h.
8301         * symtab.h (identify_source_line): Move declaration to source.h.
8302         (print_source_lines): Likewise.
8303         (forget_cached_source_info_for_objfile): Likewise.
8304         (forget_cached_source_info): Likewise.
8305         (select_source_symtab): Likewise.
8306         (enum print_source_lines_flag): Move definition to source.h.
8307         * tui/tui-hooks.c: Add 'source.h' include.
8308
8309 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8310
8311         * source.c (print_source_lines_base): Handle requests to print
8312         reverse line number sequences, and guard against empty lines
8313         string.
8314
8315 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8316
8317         * source.c (print_source_lines_base): Fix skip of '\r' if next
8318         character is '\n'.
8319
8320 2019-01-06  Tom Tromey  <tom@tromey.com>
8321
8322         * c-exp.y (struct c_parse_state) <macro_original_text,
8323         expansion_obstack>: New member.
8324         (macro_original_text, expansion_obstack): Remove globals.
8325         (scan_macro_expansion, scanning_macro_expansion)
8326         (finished_macro_expansion): Update.
8327         (scan_macro_cleanup): Remove.
8328         (yylex, c_parse): Update.
8329
8330 2019-01-06  Tom Tromey  <tom@tromey.com>
8331
8332         * c-exp.y (struct c_parse_state) <strings>: New member.
8333         (operator_stoken): Update.
8334
8335 2019-01-06  Tom Tromey  <tom@tromey.com>
8336
8337         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8338         (union type_stack_elt) <typelist_val>: Now a pointer to
8339         std::vector.
8340         (type_stack_cleanup): Don't declare.
8341         (push_typelist): Update.
8342         * parse.c (pop_typelist): Return a std::vector.
8343         (push_typelist): Take a std::vector.
8344         (follow_types): Update.  Do not free args.
8345         (type_stack_cleanup): Remove.
8346         * c-exp.y (struct c_parse_state): New.
8347         (cpstate): New global.
8348         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8349         (nonempty_typelist): Update.
8350         (func_mod): Create a new vector.
8351         (c_parse): Create a c_parse_state.
8352         (check_parameter_typelist): Do not delete params.
8353         (function_method): Update.  Do not delete type_list.
8354
8355 2019-01-06  Tom Tromey  <tom@tromey.com>
8356
8357         PR gdb/28155:
8358         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8359         check_typedef.
8360         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8361         (print_return_value): Likewise.
8362
8363 2019-01-05  Tom Tromey  <tom@tromey.com>
8364
8365         * contrib/cleanup_check.py: Remove.
8366         * contrib/gcc-with-excheck: Remove.
8367         * contrib/exsummary.py: Remove.
8368         * contrib/excheck.py: Remove.
8369
8370 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8371
8372         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8373         NULL. Initialize tpprev to NULL instead of assigning it
8374         to NULL on the next statement.
8375         * windows-nat.c (windows_delete_thread): Remove check for
8376         main_thread_id before printing thread exit notifications.
8377         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8378         Remove thread ID check against main_thread_id.
8379         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8380         windows_delete_thread.
8381         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8382
8383 2019-01-04  Tom Tromey  <tom@tromey.com>
8384
8385         * compile/compile.c (_initialize_compile): Use upper case for
8386         metasyntactic variables.
8387         * symmisc.c (_initialize_symmisc): Use upper case for
8388         metasyntactic variables.
8389         * psymtab.c (_initialize_psymtab): Use upper case for
8390         metasyntactic variables.
8391         * demangle.c (demangle_command): Use upper case for metasyntactic
8392         variables.
8393         (_initialize_demangler): Likewise.
8394         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8395         variables.
8396
8397 2019-01-03  Tom Tromey  <tom@tromey.com>
8398
8399         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8400
8401 2019-01-03  Tom Tromey  <tom@tromey.com>
8402
8403         * python/py-symtab.c (salpy_str): Update.
8404         (struct salpy_sal_object) <symtab>: Now a PyObject.
8405         (salpy_dealloc): Update.
8406         (del_objfile_sal): Use gdbpy_ref.
8407
8408 2019-01-03  Tom Tromey  <tom@tromey.com>
8409
8410         * python/py-type.c (convert_field): Use new_reference.  Return
8411         gdbpy_ref.
8412         (make_fielditem): Return gdbpy_ref.
8413         (typy_fields): Update.
8414         (typy_getitem): Update.
8415         (field_name): Return gdbpy_ref.  Use new_reference.
8416         (typy_iterator_iternext): Update.
8417
8418 2019-01-03  Tom Tromey  <tom@tromey.com>
8419
8420         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8421
8422 2019-01-03  Tom Tromey  <tom@tromey.com>
8423
8424         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8425         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8426         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8427         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8428         (pspy_set_type_printers): Likewise.
8429         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8430         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8431         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8432         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8433         (objfpy_set_type_printers): Likewise.
8434
8435 2019-01-03  Tom Tromey  <tom@tromey.com>
8436
8437         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8438         (gdbpy_print_stack): Use gdbpy_err_fetch.
8439         * python/python-internal.h (class gdbpy_err_fetch): New class.
8440         (class gdbpy_enter) <m_error_type, m_error_value,
8441         m_error_traceback>: Remove.
8442         <m_error>: New member.
8443         (gdbpy_exception_to_string): Don't declare.
8444         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8445         * python/py-value.c (convert_value_from_python): Use
8446         gdbpy_err_fetch.
8447         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8448         gdbpy_exception_to_string.
8449         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8450         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8451         gdbpy_err_fetch.
8452
8453 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8454
8455         * linux-nat.c (delete_lwp_cleanup): Delete.
8456         (struct lwp_deleter): New struct.
8457         (lwp_info_up): New typedef.
8458         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8459         lwp_info_up.
8460
8461 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8462
8463         * linux-fork.c (class scoped_switch_fork_info): New class.
8464         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8465
8466 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8467
8468         * valops.c (find_overload_match): Remove use of null_cleanup, and
8469         calls to do_cleanups.
8470
8471 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8472
8473         * compile/compile-cplus-types.c
8474         (compile_cplus_instance::decl_name): Handle changes to
8475         cp_func_name.
8476         * cp-support.c (cp_func_name): Update header comment, update
8477         return type.
8478         * cp-support.h (cp_func_name): Update return type in declaration.
8479         * valops.c (find_overload_match): Move temp_func local to top
8480         level of function and change its type.  Use temp_func to hold and
8481         delete temporary string obtained from cp_func_name.
8482
8483 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8484
8485         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8486         gdb::char_vector, remove cleanup, and update uses of `msg`.
8487
8488 2019-01-03  Jim Wilson  <jimw@sifive.com>
8489
8490         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8491
8492 2019-01-02  Tom Tromey  <tom@tromey.com>
8493
8494         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8495         (tdesc_parse_xml): Remove cleanups.
8496         * target-descriptions.h (make_cleanup_free_target_description):
8497         Don't declare.
8498         (target_desc_deleter): New struct.
8499         (target_desc_up): New typedef.
8500         * target-descriptions.c (target_desc_deleter::operator()): Rename
8501         from free_target_description.
8502         (make_cleanup_free_target_description): Remove.
8503
8504 2019-01-02  Tom Tromey  <tom@tromey.com>
8505
8506         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8507         constructor, destructor.
8508         (linespec_parser): Remove typedef.
8509         (~linespec_parser): Rename from linespec_parser_delete.
8510         (linespec_lex_to_end, linespec_complete_label)
8511         (linespec_complete): Update.
8512         (decode_line_full): Remove cleanups.
8513         (decode_line_1): Update.
8514
8515 2019-01-02  Tom Tromey  <tom@tromey.com>
8516
8517         * python/python-internal.h (inferior_to_inferior_object): Change
8518         return type.
8519         * python/py-exitedevent.c (create_exited_event_object): Update.
8520         * python/py-inferior.c (inferior_to_inferior_object): Return
8521         gdbpy_ref.
8522         (python_new_inferior, python_inferior_deleted)
8523         (thread_to_thread_object, delete_thread_object)
8524         (build_inferior_list, gdbpy_selected_inferior): Update.
8525         * python/py-infthread.c (create_thread_object): Update.  Also fail
8526         if inferior_to_inferior_object fails.
8527
8528 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8529
8530         * inferior.h (class inferior) <displaced_step_state>: New field.
8531         * infrun.h (struct displaced_step_state): Move here from
8532         infrun.c.  Initialize fields, add constructor.
8533         <inf>: Remove field.
8534         <reset>: New method.
8535         * infrun.c (struct displaced_step_inferior_state): Move to
8536         infrun.h.
8537         (displaced_step_inferior_states): Remove.
8538         (get_displaced_stepping_state): Adust.
8539         (displaced_step_in_progress_any_inferior): Adjust.
8540         (displaced_step_in_progress_thread): Adjust.
8541         (displaced_step_in_progress): Adjust.
8542         (add_displaced_stepping_state): Remove.
8543         (get_displaced_step_closure_by_addr): Adjust.
8544         (remove_displaced_stepping_state): Remove.
8545         (infrun_inferior_exit): Call displaced_step_state.reset.
8546         (use_displaced_stepping): Don't check for NULL.
8547         (displaced_step_prepare_throw): Call
8548         get_displaced_stepping_state.
8549         (displaced_step_fixup): Don't check for NULL.
8550         (prepare_for_detach): Don't check for NULL.
8551
8552 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8553
8554         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8555          in case of call that did not complete.
8556
8557 2019-01-02  Andrey Utkin  <autkin@undo.io>
8558
8559         * symfile.c (find_separate_debug_file): Fix search of debug files for
8560         remote debuggee.
8561
8562 2019-01-02  Tom Tromey  <tom@tromey.com>
8563
8564         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8565         indentation.
8566         * python/py-frame.c (frapy_older): Remove cast.
8567         (frapy_newer): Likewise.
8568         * python/py-breakpoint.c (local_setattro): Remove cast.
8569         * python/py-arch.c (archpy_name): Remove local variable.
8570         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8571
8572 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8573
8574         * unittests/basic_string_view/element_access/char/empty.cc:
8575         Fix year range in copyright header.
8576
8577 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8578
8579         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8580         Delete.
8581         <operator==>: Update with for removed field.
8582         <hash>: Likewise.
8583         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8584         <isa_features>: ...this.
8585         <abi_features>: New field.
8586         (riscv_isa_flen): Update comment.
8587         (riscv_abi_xlen): New declaration.
8588         (riscv_abi_flen): New declaration.
8589         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8590         isa_features.
8591         (riscv_abi_xlen): New function.
8592         (riscv_isa_flen): Update to get answer from isa_features.
8593         (riscv_abi_flen): New function.
8594         (riscv_has_fp_abi): Update to get answer from abi_features.
8595         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8596         xlen and flen.
8597         (riscv_call_info) <xlen, flen>: Update comment.
8598         (riscv_call_arg_struct): Remove invalid assertions
8599         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8600         is removed.
8601         (riscv_gdbarch_init): Gather isa features and abi features
8602         separately, ensure both match on the gdbarch when reusing an old
8603         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8604         a target with 64-bit float hardware.
8605
8606 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8607
8608         * source.c (search_command_helper): Stop reverse search
8609         when line 1 has been searched.
8610
8611 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8612
8613         * record-full.c (record_full_base_target::close): Rewrite
8614         record_full_core_buf_list free logic.
8615
8616 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8617
8618         * break-catch-syscall.c (print_one_catch_syscall): xfree
8619         the last text.
8620
8621 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8622
8623         * top.c (print_gdb_version): Update Copyright year in version
8624         message.
8625
8626 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8627
8628         Update copyright year range in all GDB files.
8629
8630 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8631
8632         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8633
8634 For older changes see ChangeLog-2018.
8635 \f
8636 Local Variables:
8637 mode: change-log
8638 left-margin: 8
8639 fill-column: 74
8640 version-control: never
8641 coding: utf-8
8642 End:
8643