gdb/ChangeLog

   1 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
   4         (aarch64_vnv_type): Likewise.
   5         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
   6         * common/tdesc.c: Likewise.
   7         * common/tdesc.h (enum tdesc_type_kind): Likewise.
   8         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
   9         * features/aarch64-fpu.xml: Add ieee half view.
  10         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
  11         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
  12         * gdbtypes.h (struct builtin_type): Likewise.
  13         (struct objfile_type): Likewise.
  14
  15 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
  16
  17         * language.c (language_sniff_from_mangled_name): Fix "langauge"
  18         typo.
  19         * location.h (string_to_event_location): Likewise.
  20
  21 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  22
  23         GDB 8.3 released.
  24
  25 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
  26
  27         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
  28         New variable declaration.
  29         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
  30         New variable.
  31         (print_one_breakpoint): Use ui_out::test_flags and new global
  32         variable to compute use_fixed_output.
  33         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
  34         Remove.
  35         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
  36         (mi_multi_location_breakpoint_output_fixed): Remove.
  37         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
  38         new variable.
  39         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
  40         fix_multi_location_breakpoint_output flag if version >= 3.
  41         * ui-out.h (enum ui_out_flag)
  42         <fix_multi_location_breakpoint_output>: New enumerator.
  43
  44 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
  45
  46         * contrib/cc-with-tweaks.sh: Validate dwz's work.
  47
  48 2019-05-10  Tom Tromey  <tromey@adacore.com>
  49
  50         * ada-lang.c (catch_ada_completer): New function.
  51         (_initialize_ada_language): Use it.
  52
  53 2019-05-10  Tom Tromey  <tromey@adacore.com>
  54
  55         * thread.c (print_thread_info): Make "requested_threads" const.
  56         * gdbthread.h (print_thread_info): Make "requested_threads"
  57         const.
  58         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
  59         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
  60
  61 2019-05-08  Tom Tromey  <tom@tromey.com>
  62
  63         * gdbtypes.c (objfile_type_data): Change type.
  64         (objfile_type, _initialize_gdbtypes): Update.
  65
  66 2019-05-08  Tom Tromey  <tom@tromey.com>
  67
  68         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
  69         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
  70         (_initialize_dwarf2_frame): Update.
  71
  72 2019-05-08  Tom Tromey  <tom@tromey.com>
  73
  74         * objc-lang.c (objc_objfile_data): Change type.
  75         (find_methods): Update.
  76         (_initialize_objc_lang): Remove.
  77
  78 2019-05-08  Tom Tromey  <tom@tromey.com>
  79
  80         * stabsread.c (rs6000_builtin_type_data): Change type.
  81         (rs6000_builtin_type, _initialize_stabsread): Update.
  82
  83 2019-05-08  Tom Tromey  <tom@tromey.com>
  84
  85         * mips-tdep.c (mips_pdr_data): Remove.
  86         (_initialize_mips_tdep): Update.
  87
  88 2019-05-08  Tom Tromey  <tom@tromey.com>
  89
  90         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
  91         (hppa_init_objfile_priv_data, read_unwind_info)
  92         (find_unwind_entry, _initialize_hppa_tdep): Update.
  93
  94 2019-05-08  Tom Tromey  <tom@tromey.com>
  95
  96         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
  97         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
  98         on obstack.
  99         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 100
 101 2019-05-08  Tom Tromey  <tom@tromey.com>
 102
 103         * mdebugread.c (basic_type_data): Change type.
 104         (basic_type, _initialize_mdebugread): Update.
 105
 106 2019-05-08  Tom Tromey  <tom@tromey.com>
 107
 108         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 109
 110 2019-05-08  Tom Tromey  <tom@tromey.com>
 111
 112         * nto-tdep.c (nto_inferior_data_reg): Change type.
 113         (nto_inferior_data): Update.
 114         (nto_inferior_data_cleanup, nto_new_inferior_data)
 115         (_initialize_nto_tdep): Remove.
 116         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 117
 118 2019-05-08  Tom Tromey  <tom@tromey.com>
 119
 120         * ada-lang.c (struct ada_inferior_data): Add initializers.
 121         (ada_inferior_data): Change type.
 122         (ada_inferior_data_cleanup): Remove.
 123         (get_ada_inferior_data, ada_inferior_exit)
 124         (struct ada_pspace_data): Add initializers, destructor.
 125         (ada_pspace_data_handle): Change type.
 126         (get_ada_pspace_data): Update.
 127         (ada_pspace_data_cleanup): Remove.
 128
 129 2019-05-08  Tom Tromey  <tom@tromey.com>
 130
 131         * coffread.c (struct coff_symfile_info): Add initializers.
 132         (coff_objfile_data_key): Move lower.  Change type.
 133         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 134         Update.
 135         (coff_free_info): Remove.
 136
 137 2019-05-08  Tom Tromey  <tom@tromey.com>
 138
 139         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 140         (fbsd_pspace_data_handle): Move lower.  Change type.
 141         (get_fbsd_pspace_data): Update.
 142         (fbsd_pspace_data_cleanup): Remove.
 143         (_initialize_fbsd_tdep): Update.
 144
 145 2019-05-08  Tom Tromey  <tom@tromey.com>
 146
 147         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 148         (get_ada_tasks_pspace_data): Update.
 149         (ada_tasks_pspace_data_cleanup): Remove.
 150         (_initialize_tasks): Update.
 151         (ada_tasks_inferior_data_handle): Change type.
 152         (get_ada_tasks_inferior_data): Update.
 153         (ada_tasks_inferior_data_cleanup): Remove.
 154         (struct ada_tasks_pspace_data): Add initializers.
 155
 156 2019-05-08  Tom Tromey  <tom@tromey.com>
 157
 158         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 159         * symfile-debug.c (debug_sym_get_probes): Change type.
 160         * stap-probe.c (handle_stap_probe):
 161         (stap_static_probe_ops::get_probes): Change type.
 162         * probe.h (class static_probe_ops) <get_probes>: Change type.
 163         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 164         (parse_probes_in_pspace): Update.
 165         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 166         Update.
 167         (any_static_probe_ops::get_probes): Change type.
 168         * elfread.c (elfread_data): New typedef.
 169         (probe_key): Change type.
 170         (elf_get_probes): Likewise.  Update.
 171         (probe_key_free): Remove.
 172         (_initialize_elfread): Update.
 173         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 174         Change type.
 175         (dtrace_process_dof_probe, dtrace_process_dof)
 176         (dtrace_static_probe_ops::get_probe): Change type.
 177
 178 2019-05-08  Tom Tromey  <tom@tromey.com>
 179
 180         * xcoffread.c (struct xcoff_symfile_info): Rename from
 181         coff_symfile_info.  Add initializers.
 182         (xcoff_objfile_data_key): Move lower.  Change type.
 183         (XCOFF_DATA): Rewrite.
 184         (xcoff_free_info): Remove.
 185         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 186         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 187         (xcoff_initial_scan): Update.
 188
 189 2019-05-08  Tom Tromey  <tom@tromey.com>
 190
 191         * solib-svr4.c (struct svr4_info): Add initializers and
 192         destructor.
 193         <probes_table>: Now an htab_up.
 194         (solib_svr4_pspace_data): Change type.
 195         (free_probes_table): Simplify.
 196         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 197         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 198         (probes_table_remove_objfile_probes, register_solib_event_probe)
 199         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 200         (_initialize_svr4_solib): Update.
 201
 202 2019-05-08  Tom Tromey  <tom@tromey.com>
 203
 204         * remote.c (remote_pspace_data): Change type.
 205         (remote_pspace_data_cleanup): Remove.
 206         (get_remote_exec_file, set_pspace_remote_exec_file)
 207         (_initialize_remote): Update.
 208
 209 2019-05-08  Tom Tromey  <tom@tromey.com>
 210
 211         * breakpoint.c (breakpoint_objfile_key): Change type.
 212         (get_breakpoint_objfile_data): Update.
 213         (free_breakpoint_objfile_data): Remove.
 214         (_initialize_breakpoint): Update.
 215
 216 2019-05-08  Tom Tromey  <tom@tromey.com>
 217
 218         * linux-tdep.c (struct linux_info): Add initializers.
 219         (linux_inferior_data): Move.  Change type.
 220         (invalidate_linux_cache_inf): Update.
 221         (linux_inferior_data_cleanup): Remove.
 222         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 223
 224 2019-05-08  Tom Tromey  <tom@tromey.com>
 225
 226         * auxv.c (auxv_inferior_data): Move.  Change type.
 227         (auxv_inferior_data_cleanup): Remove.
 228         (invalidate_auxv_cache_inf): Rewrite.
 229         (get_auxv_inferior_data, _initialize_auxv): Update.
 230
 231 2019-05-08  Tom Tromey  <tom@tromey.com>
 232
 233         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 234         (symfile_debug_objfile_data_key): Change type.
 235         (symfile_debug_installed, debug_qf_has_symbols)
 236         (debug_qf_find_last_source_symtab)
 237         (debug_qf_forget_cached_source_info)
 238         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 239         (debug_qf_print_stats, debug_qf_dump)
 240         (debug_qf_expand_symtabs_for_function)
 241         (debug_qf_expand_all_symtabs)
 242         (debug_qf_expand_symtabs_with_fullname)
 243         (debug_qf_map_matching_symbols)
 244         (debug_qf_expand_symtabs_matching)
 245         (debug_qf_find_pc_sect_compunit_symtab)
 246         (debug_qf_map_symbol_filenames)
 247         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 248         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 249         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 250         (debug_sym_read_linetable, debug_sym_relocate): Update.
 251         (symfile_debug_free_objfile): Remove.
 252         (install_symfile_debug_logging, _initialize_symfile_debug):
 253         Update.
 254
 255 2019-05-08  Tom Tromey  <tom@tromey.com>
 256
 257         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 258         allocate_on_obstack.
 259         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 260         (get_dwarf2_per_objfile): Update.
 261         (set_dwarf2_per_objfile): Remove.
 262         (dwarf2_has_info, dwarf2_get_section_info): Update.
 263         (dwarf2_free_objfile): Remove.
 264         (_initialize_dwarf2_read): Update.
 265
 266 2019-05-08  Tom Tromey  <tom@tromey.com>
 267
 268         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 269         initializers.
 270         <unsupported_script_warning_printed,
 271         script_not_found_warning_printed>: Now bool.
 272         (auto_load_pspace_data): Change type.
 273         (~auto_load_pspace_info): Rename from
 274         auto_load_pspace_data_cleanup.
 275         (get_auto_load_pspace_data, init_loaded_scripts_info)
 276         (clear_section_scripts, maybe_print_unsupported_script_warning)
 277         (maybe_print_script_not_found_warning, _initialize_auto_load):
 278         Update.
 279
 280 2019-05-08  Tom Tromey  <tom@tromey.com>
 281
 282         * objfiles.c (objfile_pspace_info): Add destructor and
 283         initializers.
 284         (objfiles_pspace_data): Change type.
 285         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 286         (get_objfile_pspace_data): Update.
 287         (objfiles_bfd_data): Change type.
 288         (get_objfile_bfd_data): Update.
 289         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 290
 291 2019-05-08  Tom Tromey  <tom@tromey.com>
 292
 293         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 294         Change type.
 295         (get_catch_syscall_inferior_data): Update.
 296         (catch_syscall_inferior_data_cleanup): Remove.
 297         (_initialize_break_catch_syscall): Update.
 298
 299 2019-05-08  Tom Tromey  <tom@tromey.com>
 300
 301         * inflow.c (struct terminal_info): Add destructor and
 302         initializers.
 303         (inflow_inferior_data): Change type.
 304         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 305         (get_inflow_inferior_data, inflow_inferior_exit)
 306         (swap_terminal_info, _initialize_inflow): Update.
 307
 308 2019-05-08  Tom Tromey  <tom@tromey.com>
 309
 310         * target-dcache.c (target_dcache_cleanup): Remove.
 311         (target_dcache_aspace_key): Change type.
 312         (target_dcache_init_p, target_dcache_invalidate)
 313         (target_dcache_get, target_dcache_get_or_init)
 314         (_initialize_target_dcache): Update.
 315         * dcache.h (struct dcache_deleter): New.
 316
 317 2019-05-08  Tom Tromey  <tom@tromey.com>
 318
 319         * symtab.c (struct symbol_cache): Add destructor and
 320         initializers.
 321         (symbol_cache_key): Move.  Change type.
 322         (make_symbol_cache, free_symbol_cache): Remove.
 323         (get_symbol_cache): Update.
 324         (symbol_cache_cleanup): Remove.
 325         (ALL_PSPACES, symbol_cache_flush)
 326         (maintenance_print_symbol_cache)
 327         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 328         Update.
 329
 330 2019-05-08  Tom Tromey  <tom@tromey.com>
 331
 332         * symtab.c (struct main_info): Add destructor and initializers.
 333         (main_progspace_key): Move.  Change type.
 334         (get_main_info): Update.
 335         (main_info_cleanup): Remove.
 336         (_initialize_symtab): Update.
 337
 338 2019-05-08  Tom Tromey  <tom@tromey.com>
 339
 340         * registry.h (DECLARE_REGISTRY): Define the _key class.
 341
 342 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 343
 344         * NEWS: Merge two 'New commands' sections.
 345
 346 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 347
 348         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 349         parameter and use Ada language definition instead.
 350         (ada_val_print_ptr): Remove unused language parameter.
 351         (ada_val_print_num): Remove language parameter and use Ada language
 352         definition instead.
 353         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 354         parameter.
 355         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 356         parameter and use Ada language definition instead.
 357         (ada_val_print_1): Update all ada_val_print_xxx calls.
 358         Remove language parameter.
 359         (ada_val_print): Update ada_val_print_1 call.
 360
 361 2019-05-08  Tom Tromey  <tromey@adacore.com>
 362
 363         * remote.c (remote_hw_watchpoint_limit)
 364         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 365         Now static.
 366
 367 2019-05-08  Tom Tromey  <tromey@adacore.com>
 368
 369         * maint.c (_initialize_maint_cmds): Move initialization code to
 370         remote.c.
 371         (watchdog, show_watchdog): Move to remote.c.
 372         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 373         "watchdog" static.
 374         (_initialize_remote): Move initialization code from maint.c.
 375         * defs.h (watchdog): Don't declare.
 376
 377 2019-05-08  Tom Tromey  <tromey@adacore.com>
 378
 379         * tui/tui-interp.c: Include main.h.
 380         * interps.c: Include main.h.
 381         * main.h (interpreter_p): Declare.
 382         * defs.h (interpreter_p): Don't declare.
 383
 384 2019-05-08  Tom Tromey  <tromey@adacore.com>
 385
 386         * dwarf2loc.c: Include dwarf2read.h.
 387         * defs.h (read_unsigned_leb128): Don't declare.
 388         * dwarf2read.h (read_unsigned_leb128): Declare.
 389
 390 2019-05-08  Tom Tromey  <tromey@adacore.com>
 391
 392         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 393         method.
 394
 395 2019-05-08  Tom Tromey  <tromey@adacore.com>
 396
 397         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 398         when no wrap column is set.
 399
 400 2019-05-08  Tom Tromey  <tromey@adacore.com>
 401
 402         * c-lang.c (c_get_string): Handle non-C-style arrays.
 403
 404 2019-05-08  Tom Tromey  <tromey@adacore.com>
 405
 406         * typeprint.c (print_offset_data::update): Print the bit offset,
 407         not the number of bits remaining.
 408
 409 2019-05-08  Tom Tromey  <tromey@adacore.com>
 410
 411         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 412         padding at end of comment.
 413
 414 2019-05-08  Tom Tromey  <tromey@adacore.com>
 415
 416         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 417         Compare main types.
 418
 419 2019-05-06  Tom Tromey  <tom@tromey.com>
 420
 421         * common/scoped_mmap.c: Include common-defs.h.
 422         * common/scoped_mmap.h: Don't include config.h.
 423
 424 2019-05-04  Tom Tromey  <tom@tromey.com>
 425
 426         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 427         (struct aarch64_call_info): Add initializers.
 428         <si>: Now a std::vector.
 429         (pass_on_stack, aarch64_push_dummy_call): Update.
 430
 431 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 432             Tom Tromey  <tom@tromey.com>
 433
 434         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 435         (ppc_threads): Now a std::vector.  Now static.
 436         (hwdebug_find_thread_points_by_tid)
 437         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 438         Update.
 439
 440 2019-05-04  Tom Tromey  <tom@tromey.com>
 441
 442         * arc-tdep.c (arc_tdesc_init): Return bool.
 443
 444 2019-05-04  Tom Tromey  <tom@tromey.com>
 445
 446         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 447         Use gdb_assert_not_reached.
 448
 449 2019-05-04  Tom Tromey  <tom@tromey.com>
 450
 451         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 452         "false".
 453
 454 2019-05-04  Tom Tromey  <tom@tromey.com>
 455
 456         * arc-tdep.c (arc_tdesc_init): Use bool.
 457
 458 2019-05-04  Tom Tromey  <tom@tromey.com>
 459
 460         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 461
 462 2019-05-04  Tom Tromey  <tom@tromey.com>
 463
 464         * cli/cli-cmds.c (valid_command_p): Return bool.
 465
 466 2019-05-04  Tom Tromey  <tom@tromey.com>
 467
 468         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 469         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 470
 471 2019-05-04  Raul Tambre  <raul@tambre.ee>
 472
 473         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 474         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 475         operator for comparison.
 476
 477 2019-05-04  Tom Tromey  <tom@tromey.com>
 478
 479         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 480         (lookup_partial_symbol, print_partial_symbols)
 481         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 482         (psymbol_compare): Update.
 483         (add_psymbol_to_bcache): Clear the entire psymbol.
 484         (maintenance_check_psymtabs): Update.
 485         * psympriv.h (struct partial_symbol): Don't derive from
 486         general_symbol_info.
 487         <obj_section, unrelocated_address, address,
 488         set_unrelocated_address>: Update.
 489         <ginfo>: New member.
 490         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 491         (debug_names::write_psymbols): Update.
 492
 493 2019-05-04  Tom de Vries  <tdevries@suse.de>
 494
 495         * contrib/cc-with-tweaks.sh: Support -n arg.
 496
 497 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 498
 499         * corelow.c (core_target::detach): Ensure frame cache and
 500         register caches are cleared.
 501         inferior.c (exit_inferior_1): Likewise.
 502
 503 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 504             Tom Tromey  <tom@tromey.com>
 505
 506         * dictionary.c (collate_pending_symbols_by_language): Remove
 507         "struct" from foreach.
 508         * symtab.c (lookup_global_symbol_from_objfile)
 509         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 510         foreach.
 511         * ser-tcp.c (net_open): Remove "struct" from foreach.
 512         * objfiles.c (objfile_relocate, objfile_rebase)
 513         (objfile_has_symbols): Remove "struct" from foreach.
 514         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 515         from foreach.
 516         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 517         foreach.
 518         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 519         "struct" from foreach.
 520         * ada-lang.c (create_excep_cond_exprs)
 521         (ada_exception_catchpoint_cond_string): Remove "struct" from
 522         foreach.
 523
 524 2019-05-03  Tom Tromey  <tromey@adacore.com>
 525
 526         * ada-exp.y (convert_char_literal): Check suffix of each
 527         enumerator.
 528
 529 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 530
 531         PR ada/21406:
 532         * ada-exp.y (yywrap): Don't define.
 533         * ada-lex.l (%option): Add noyywrap
 534         (yywrap): Remove.
 535
 536 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 537
 538         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 539         _WIN32_WINNT to the XP level, unless already defined to a higher
 540         level.
 541
 542         * unittests/parse-connection-spec-selftests.c:
 543         * ser-tcp.c:
 544         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 545         override.
 546
 547         * symfile.c (find_separate_debug_file): Remove colon from the
 548         drive spec of DOS/Windows file names of the target, so that the
 549         file name produced from DEBUGDIR and the target's directory will
 550         be valid on DOS/Windows systems.
 551
 552 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 553
 554         * rust-lang.c (val_print_struct): Handle printing structures
 555         containing strings.
 556
 557 2019-05-02  Tom Tromey  <tromey@adacore.com>
 558
 559         * valarith.c (_initialize_valarith): Remove.
 560
 561 2019-05-01  Tom Tromey  <tromey@adacore.com>
 562
 563         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 564         bitfields.
 565
 566 2019-05-01  Tom Tromey  <tromey@adacore.com>
 567
 568         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 569         for big-endian copies.
 570
 571 2019-04-30  Ali Tamur  <tamur@google.com>
 572         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 573         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 574         (read_3_bytes): New function.
 575
 576 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 577
 578         * windows-nat.c (main_thread_id): Delete.
 579         (handle_output_debug_string): Replace main_thread_id by
 580         current_event.dwThreadId.
 581         (fake_create_process): Likewise.
 582         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 583         Do not set main_thread_id.
 584         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 585         current_event.dwThreadId.
 586         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 587
 588 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 589
 590         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 591         Use current_event.dwThreadId instead of main_thread_id.
 592
 593 2019-04-30  Tom Tromey  <tromey@adacore.com>
 594
 595         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 596         (create_excep_cond_exprs): Iterate over program spaces.
 597         (ada_exception_catchpoint_cond_string): Examine all minimal
 598         symbols for exception types.
 599
 600 2019-04-30  Tom Tromey  <tromey@adacore.com>
 601
 602         PR c++/24470:
 603         * dwarf2read.c (process_structure_scope): Handle case where type
 604         has template parameters but no symbol was created.
 605
 606 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 607             Chris January  <chris.january@arm.com>
 608
 609         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 610         qualifier.
 611         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 612
 613 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         * f-typeprint.c (f_print_type): Update rules for printing
 616         whitespace.
 617         (f_type_print_varspec_suffix): Likewise.
 618
 619 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 620             Chris January  <chris.january@arm.com>
 621
 622         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 623         function arguments.
 624
 625 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 626
 627         * f-lang.c (build_fortran_types): Change name of void type to
 628         lower case.
 629         * f-typeprint.c (f_type_print_base): Print the name of the void
 630         type, rather than a fixed string.
 631         * f-valprint.c (f_decorations): Use lower case void string.
 632
 633 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 634             Chris January  <chris.january@arm.com>
 635
 636         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 637         types for Fortran.
 638
 639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 640             Chris January  <chris.january@arm.com>
 641             David Lecomber  <david.lecomber@arm.com>
 642
 643         * f-exp.y (BINOP_INTRINSIC): New token.
 644         (exp): New parser rule handling BINOP_INTRINSIC.
 645         (f77_keywords): Add new builtin procedures.
 646         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 647         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 648         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 649         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 650         (print_unop_subexp_f): New function.
 651         (print_binop_subexp_f): New function.
 652         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 653         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 654         (dump_subexp_body_f): Likewise.
 655         (operator_check_f): Likewise.
 656         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 657         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 658
 659 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 660
 661         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 662         UNOP_KIND.
 663         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 664         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 665         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 666         (operator_length_f): New fuction.
 667         (print_subexp_f): New function.
 668         (op_name_f): New function.
 669         (dump_subexp_body_f): New function.
 670         (operator_check_f): New function.
 671         (exp_descriptor_f): Replace standard expression handling functions
 672         with new functions.
 673         * gdb/fortran-operator.def: New file.
 674         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 675         * gdb/std-operator.def: Remove UNOP_KIND.
 676
 677 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 678
 679         * std-operator.def: Remove unbalanced, stray double quote
 680         character.
 681
 682 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 683             Chris January  <chris.january@arm.com>
 684             Daniel Everett  <daniel.everett@arm.com>
 685             Nick Forrington  <nick.forrington@arm.com>
 686             Richard Bunt  <richard.bunt@arm.com>
 687
 688         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 689         of depth when printing anonymous structs or unions.
 690         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 691         Don't print either the top-level value, or the children if the
 692         max-depth is exceeded.
 693         (ppscm_print_children): When printing the key of a map, allow one
 694         extra level of depth.
 695         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 696         print either the top-level value, or the children if the max-depth
 697         is exceeded.
 698         (print_children): When printing the key of a map, allow one extra
 699         level of depth.
 700         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 701         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 702         (user_print_options): Initialise max_depth field.
 703         (val_print_scalar_or_string_type_p): New function.
 704         (val_print): Check to see if the max depth has been reached.
 705         (val_print_check_max_depth): Define new function.
 706         (show_print_max_depth): New function.
 707         (_initialize_valprint): Add 'print max-depth' option.
 708         * valprint.h (struct value_print_options) <max_depth>: New field.
 709         (val_print_check_max_depth): Declare new function.
 710         * NEWS: Document new feature.
 711
 712 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 713
 714         * ada-lang.c (ada_language_defn): Initialise new field.
 715         * c-lang.c (c_is_string_type_p): New function.
 716         (c_language_defn): Initialise new field.
 717         (cplus_language_defn): Initialise new field.
 718         (asm_language_defn): Initialise new field.
 719         (minimal_language_defn): Initialise new field.
 720         * c-lang.h (c_is_string_type_p): Declare new function.
 721         * d-lang.c (d_language_defn): Initialise new field.
 722         * f-lang.c (f_is_string_type_p): New function.
 723         (f_language_defn): Initialise new field.
 724         * go-lang.c (go_is_string_type_p): New function.
 725         (go_language_defn): Initialise new field.
 726         * language.c (default_is_string_type_p): New function.
 727         (unknown_language_defn): Initialise new field.
 728         (auto_language_defn): Initialise new field.
 729         * language.h (struct language_defn) <la_is_string_type_p>: New
 730         member variable.
 731         (default_is_string_type_p): Declare new function.
 732         * m2-lang.c (m2_language_defn): Initialise new field.
 733         * objc-lang.c (objc_language_defn): Initialise new field.
 734         * opencl-lang.c (opencl_language_defn): Initialise new field.
 735         * p-lang.c (pascal_is_string_type_p): New function.
 736         (pascal_language_defn): Initialise new field.
 737         * rust-lang.c (rust_is_string_type_p): New function.
 738         (rust_language_defn): Initialise new field.
 739
 740 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 743         New field.
 744         * ada-lang.c (ada_language_defn): Initialise new field.
 745         * c-lang.c (c_language_defn): Likewise.
 746         (cplus_language_defn): Likewise.
 747         (asm_language_defn): Likewise.
 748         (minimal_language_defn): Likewise.
 749         * d-lang.c (d_language_defn): Likewise.
 750         * f-lang.c (f_language_defn): Likewise.
 751         * go-lang.c (go_language_defn): Likewise.
 752         * language.c (unknown_language_defn): Likewise.
 753         (auto_language_defn): Likewise.
 754         * m2-lang.c (m2_language_defn): Likewise.
 755         * objc-lang.c (objc_language_defn): Likewise.
 756         * opencl-lang.c (opencl_language_defn): Likewise.
 757         * p-lang.c (pascal_language_defn): Likewise.
 758         * rust-lang.c (rust_language_defn): Likewise.
 759
 760 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 761
 762         * ada-lang.c (ada_is_character_type): Change return type to bool.
 763         (ada_is_string_type): Likewise.
 764         * ada-lang.h (ada_is_character_type): Update declaration
 765         (ada_is_string_type): Likewise.
 766
 767 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 768
 769         Support style in 'frame|thread apply'
 770
 771         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 772         * record.c (record_start, record_stop): Update callers of
 773         execute_command_to_string with false.
 774         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 775         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 776         methods.
 777         (class string_file): New constructor with term_out parameter.
 778         Override methods term_out and can_emit_style_escape.  New member
 779         term_out.
 780         (class stdio_file): Override can_emit_style_escape.
 781         (class tee_file): Override term_out and can_emit_style_escape.
 782         * utils.h (can_emit_style_escape): Remove.
 783         * utils.c (can_emit_style_escape): Likewise.
 784         Update all callers of can_emit_style_escape (SOMESTREAM) to
 785         SOMESTREAM->can_emit_style_escape.
 786         * source-cache.c (source_cache::get_source_lines): Likewise.
 787         * stack.c (frame_apply_command_count): Call execute_command_to_string
 788         passing the term_out characteristic of the current gdb_stdout.
 789         * thread.c (thr_try_catch_cmd): Likewise.
 790         * top.c (execute_command_to_string): pass term_out parameter
 791         to construct the string_file for the command output.
 792         * ui-file.c (term_cli_styling): New function (most code moved
 793         from utils.c can_emit_style_escape).
 794         (string_file::string_file, string_file::can_emit_style_escape,
 795         stdio_file::can_emit_style_escape, tee_file::term_out,
 796         tee_file::can_emit_style_escape): New functions.
 797
 798 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 799
 800         * NEWS: Mention the new set|show may-call-functions.
 801         * infcall.c (may_call_functions_p): New variable.
 802         (show_may_call_functions_p): New function.
 803         (call_function_by_hand_dummy): Throws an error if not
 804         may-call-functions.
 805         (_initialize_infcall): Call add_setshow_boolean_cmd for
 806         may-call-functions.
 807
 808 2019-04-25  Keith Seitz  <keiths@redhat.com>
 809
 810         PR c++/24367
 811         * cp-support.c (inspect_type): Don't attempt substitutions
 812         of symbol with the same name.
 813
 814 2019-04-25  Tom Tromey  <tromey@adacore.com>
 815
 816         PR gdb/24475:
 817         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 818         static.
 819
 820 2019-04-25  Tom Tromey  <tromey@adacore.com>
 821
 822         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 823         rvalue reference.
 824         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 825         (gdb_xml_parser::parse): Use std::move.
 826         * python/python-internal.h (gdbpy_convert_exception): Take a const
 827         reference.
 828         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 829         std::move.
 830         * python/py-utils.c (gdbpy_convert_exception): Take a const
 831         reference.
 832         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 833         Use std::move.
 834         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 835         Use std::move.
 836         * mi/mi-main.c (mi_print_exception): Take a const reference.
 837         * main.c (handle_command_errors): Take a const reference.
 838         * linespec.c (parse_linespec): Use std::move.
 839         * infcall.c (run_inferior_call): Use std::move.
 840         (call_function_by_hand_dummy): Use std::move.
 841         * exec.c (try_open_exec_file): Use std::move.
 842         * exceptions.h (exception_print, exception_fprintf)
 843         (exception_print_same): Update.
 844         * exceptions.c (print_exception, exception_print)
 845         (exception_fprintf, exception_print_same): Change parameters to
 846         const reference.
 847         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 848         * common/new-op.c: Use std::move.
 849         * common/common-exceptions.h (struct gdb_exception): Add move
 850         constructor.
 851         (struct gdb_exception_error, struct gdb_exception_quit, struct
 852         gdb_quit_bad_alloc): Change constructor to move constructor.
 853         (throw_exception): Change parameter to rvalue reference.
 854         * common/common-exceptions.c (throw_exception): Take rvalue
 855         reference.
 856         * cli/cli-interp.c (safe_execute_command): Use std::move.
 857         * breakpoint.c (insert_bp_location, location_to_sals): Use
 858         std::move.
 859
 860 2019-04-25  Tom Tromey  <tromey@adacore.com>
 861
 862         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 863         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 864         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 865         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 866         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 867         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 868         guile/scm-value.c: Use unpack.
 869         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 870         gdbscm_gdb_exception.
 871         (gdbscm_throw_gdb_exception): Likewise.
 872         (struct gdbscm_gdb_exception): New.
 873         (unpack): New function.
 874         (gdbscm_wrap): Use unpack.
 875
 876 2019-04-25  Tom Tromey  <tromey@adacore.com>
 877
 878         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 879         (gdb_rl_callback_handler): Use std::move.
 880         * common/common-exceptions.h (struct gdb_exception): Add move
 881         assignment operator.
 882         (throw_exception_sjlj): Change "exception" to const reference.
 883         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 884         (throw_exception_sjlj): Change "exception" to const reference.
 885
 886 2019-04-25  Tom Tromey  <tromey@adacore.com>
 887
 888         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 889         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 890         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 891         Update.
 892         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 893         Update.
 894         * mi/mi-interp.c (mi_interp::exec): Update.
 895         * linespec.c (parse_linespec): Update.
 896         * infcall.c (run_inferior_call): Update.
 897         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 898         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 899         (gdbscm_lookup_global_symbol): Update.
 900         * guile/scm-param.c (gdbscm_parameter_value): Update.
 901         * guile/scm-frame.c (gdbscm_frame_read_register)
 902         (gdbscm_frame_read_var): Update.
 903         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 904         * exec.c (try_open_exec_file): Update.
 905         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 906         (gdb_rl_callback_handler): Update.
 907         * common/common-exceptions.h (exception_none): Don't declare.
 908         * common/common-exceptions.c (exception_none): Don't define.
 909         (struct catcher) <exception>: Update.
 910         * cli/cli-interp.c (safe_execute_command): Update.
 911         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 912
 913 2019-04-25  Ali Tamur  <tamur@google.com>
 914
 915         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 916         (read_attribute_value): Likewise.
 917         (dwarf2_read_addr_index): Update comment.
 918         (read_str_index): Add DW_FORM_strx.
 919         (dwarf2_string_attr): Likewise.
 920         (dwarf2_const_value_attr): Likewise.
 921         (dump_die_shallow): Likewise.
 922         (dwarf2_fetch_constant_bytes): Likewise.
 923         (skip_form_bytes): Likewise.
 924         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 925
 926 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 927
 928         PR corefiles/11608
 929         PR corefiles/18187
 930         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 931         OFFSET.  Verify if current mapping contains an ELF header.
 932         (linux_find_memory_regions_full): Adjust call to
 933         dump_mapping_p.
 934
 935 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 936             Kang Li <kanglictf@gmail.com>
 937
 938         PR gdb/21600
 939
 940         * dwarf2-frame.c (read_initial_length): Be consistent about using
 941         unsigned representation of length.
 942         (decode_frame_entry_1): Likewise.  Check for wraparound of
 943         end pointer as well as buffer overflow.
 944
 945 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 946
 947         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 948         "vq".
 949
 950 2019-04-24  Tom Tromey  <tromey@adacore.com>
 951
 952         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 953
 954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * s12z-tdep.c (s12z_unwind_pc): Delete.
 957         (s12z_unwind_sp): Delete.
 958         (s12z_gdbarch_init): Don't register deleted functions with
 959         gdbarch.
 960
 961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 962
 963         * rl78-tdep.c (rl78_unwind_sp): Delete.
 964         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 965
 966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 967
 968         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 969         (xstormy16_unwind_pc): Delete.
 970         (xstormy16_dummy_id): Delete.
 971         (xstormy16_gdbarch_init): Don't register deleted functions with
 972         gdbarch.
 973
 974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 975
 976         * vax-tdep.c (vax_unwind_pc): Delete.
 977         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 978
 979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * v850-tdep.c (v850_unwind_sp): Delete.
 982         (v850_unwind_pc): Delete.
 983         (v850_dummy_id): Delete.
 984         (v850_gdbarch_init): Don't register deleted functions with
 985         gdbarch.
 986
 987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 988
 989         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 990         (tilegx_unwind_pc): Delete.
 991         (tilegx_unwind_dummy_id): Delete.
 992         (tilegx_gdbarch_init): Don't register deleted functions with
 993         gdbarch.
 994
 995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 996
 997         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 998         (tic6x_dummy_id): Delete.
 999         (tic6x_gdbarch_init): Don't register deleted functions with
1000         gdbarch.
1001
1002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * sparc-tdep.c (sparc_unwind_pc): Delete.
1005         (sparc32_gdbarch_init): Don't register deleted function with
1006         gdbarch.
1007
1008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1009
1010         * sh-tdep.c (sh_unwind_sp): Delete.
1011         (sh_unwind_pc): Delete.
1012         (sh_dummy_id): Delete.
1013         (sh_gdbarch_init): Don't register deleted functions with
1014         gdbarch.
1015
1016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * score-tdep.c (score_unwind_sp): Delete.
1019         (score_unwind_pc): Delete.
1020         (score_dummy_id): Delete.
1021         (score_gdbarch_init): Don't register deleted functions with
1022         gdbarch.
1023
1024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * rx-tdep.c (rx_unwind_pc): Delete.
1027         (rx_unwind_sp): Delete.
1028         (rx_dummy_id): Delete.
1029         (rx_gdbarch_init): Don't register deleted functions with
1030         gdbarch.  Update comment.
1031
1032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1033
1034         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1035         (rs6000_dummy_id): Delete.
1036         (rs6000_gdbarch_init): Don't register deleted functions with
1037         gdbarch.
1038
1039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * or1k-tdep.c (or1k_dummy_id): Delete.
1042         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1043
1044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * nios2-tdep.c (nios2_dummy_id): Delete.
1047         (nios2_unwind_sp): Delete.
1048         (nios2_gdbarch_init): Don't register deleted functions with
1049         gdbarch.
1050
1051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * nds32-tdep.c (nds32_dummy_id): Delete.
1054         (nds32_unwind_pc): Delete.
1055         (nds32_unwind_sp): Delete.
1056         (nds32_gdbarch_init): Don't register deleted functions with
1057         gdbarch.
1058
1059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * msp430-tdep.c (msp430_unwind_pc): Delete.
1062         (msp430_unwind_sp): Delete.
1063         (msp430_dummy_id): Delete.
1064         (msp430_gdbarch_init): Don't register deleted functions with
1065         gdbarch.
1066
1067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * moxie-tdep.c (moxie_unwind_sp): Delete.
1070         (moxie_unwind_pc): Delete.
1071         (moxie_dummy_id): Delete.
1072         (moxie_gdbarch_init): Don't register deleted functions with
1073         gdbarch.
1074
1075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1076
1077         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1078         (mn10300_unwind_pc): Delete.
1079         (mn10300_unwind_sp): Delete.
1080         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1081         mn10300_unwind_sp.
1082         (mn10300_frame_unwind_init): Don't register deleted functions with
1083         gdbarch.
1084
1085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1086
1087         * mep-tdep.c (mep_unwind_pc): Delete.
1088         (mep_unwind_sp): Delete.
1089         (mep_dummy_id): Delete.
1090         (mep_gdbarch_init): Don't register deleted functions with
1091         gdbarch.
1092
1093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1094
1095         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1096         (m68hc11_unwind_sp): Delete.
1097         (m68hc11_gdbarch_init): Don't register deleted functions with
1098         gdbarch.
1099
1100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1101
1102         * m32r-tdep.c (m32r_unwind_sp): Delete.
1103         (m32r_unwind_pc): Delete.
1104         (m32r_dummy_id): Delete.
1105         (m32r_gdbarch_init): Don't register deleted functions with
1106         gdbarch.
1107
1108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * m32c-tdep.c (m32c_unwind_pc): Delete.
1111         (m32c_unwind_sp): Delete.
1112         (m32c_dummy_id): Delete.
1113         (m32c_gdbarch_init): Don't register deleted functions with
1114         gdbarch.
1115
1116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1119         (lm32_unwind_pc): Delete.
1120         (lm32_dummy_id): Delete.
1121         (lm32_gdbarch_init): Don't register deleted functions with
1122         gdbarch.
1123
1124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1127         (iq2000_unwind_pc): Delete.
1128         (iq2000_dummy_id): Delete.
1129         (iq2000_gdbarch_init): Don't register deleted functions with
1130         gdbarch.
1131
1132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1133
1134         * nds32-tdep.c (nds32_type_align): Delete.
1135         (nds32_push_dummy_call): Use type_align instead.
1136
1137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * arm-tdep.c (arm_type_align): Only handle vector override case.
1140         (arm_push_dummy_call): Use type_align.
1141         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1142
1143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1144
1145         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1146         case.
1147         (pass_on_stack): Use type_align.
1148         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1149         function.
1150
1151 2019-04-23  Tom Tromey  <tromey@adacore.com>
1152
1153         * dwarf2read.c (line_header::file_name_at): Remove unused
1154         overload.
1155
1156 2019-04-23  Tom de Vries  <tdevries@suse.de>
1157
1158         PR gdb/24438
1159         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1160         invocation.
1161
1162
1163 2019-03-27  Ali Tamur  <tamur@google.com>
1164
1165         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1166         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1167         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1168         (dwarf_expr_context::get_addr_index): Likewise
1169         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1170         (symbol_needs_eval_context::get_addr_index): Likewise
1171         (disassemble_dwarf_expression): Add DW_OP_addrx
1172         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1173         (read_cutu_die_from_dwo): Update comment
1174         (skip_one_die): Add DW_FORM_addrx
1175         (read_attribute_value): Likewise
1176         (var_decode_location): Add DW_OP_addrx
1177         (dwarf2_const_value_attr): Add DW_FORM_addrx
1178         (dump_die_shallow): Likewise
1179         (dwarf2_fetch_constant_bytes): Likewise
1180         (decode_locdesc): Add DW_OP_addrx
1181         (skip_form_bytes): Add DW_FORM_addrx
1182
1183 2019-04-22  Ali Tamur  <tamur@google.com>
1184
1185         * MAINTAINERS (Write After Approval): Add self.
1186
1187 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1188
1189         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1190         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1191         (open_symbol_file_object): Likewise.
1192         (svr4_default_sos): Add info parameter.
1193         (svr4_read_so_list): Likewise.
1194         (svr4_current_sos_direct): Adjust functions calls to pass down
1195         info.
1196         (svr4_current_sos_1): Add info parameter.
1197         (svr4_current_sos): Call get_svr4_info, pass info down to
1198         svr4_current_sos_1.
1199         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1200         get_svr4_info.
1201         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1202         get_svr4_info.
1203         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1204         to get_svr4_info.
1205         (probes_table_remove_objfile_probes): Likewise.
1206         (register_solib_event_probe): Add info parameter.
1207         (solist_update_incremental): Pass info parameter down to
1208         svr4_read_so_list.
1209         (disable_probes_interface): Add info parameter.
1210         (svr4_handle_solib_event): Pass current_program_space to
1211         get_svr4_info.  Adjust disable_probes_interface cleanup.
1212         (svr4_create_probe_breakpoints): Add info parameter, pass it
1213         down to register_solib_event_probe.
1214         (svr4_create_solib_event_breakpoints): Add info parameter,
1215         pass it down to svr4_create_probe_breakpoints.
1216         (enable_break): Pass info down to
1217         svr4_create_solib_event_breakpoints.
1218         (svr4_solib_create_inferior_hook): Pass current_program_space to
1219         get_svr4_info.
1220         (svr4_clear_solib): Likewise.
1221
1222 2019-04-22  Pedro Alves  <palves@redhat.com>
1223
1224         * solib-svr4.c (svr4_free_objfile_observer): New.
1225         (probe_and_action::objfile): New field.
1226         (probes_table_htab_remove_objfile_probes)
1227         (probes_table_remove_objfile_probes): New functions.
1228         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1229         in the new probe_and_action.  Don't store the probe in 'lookup'.
1230         (svr4_create_probe_breakpoints): Pass objfile to
1231         register_solib_event_probe.
1232         (_initialize_svr4_solib): Register a free_objfile observer.
1233
1234 2019-04-19  Tom Tromey  <tom@tromey.com>
1235
1236         * common/queue.h: Remove.
1237
1238 2019-04-19  Tom Tromey  <tom@tromey.com>
1239
1240         * event-loop.c: Don't include "common/queue.h".
1241
1242 2019-04-19  Tom Tromey  <tom@tromey.com>
1243
1244         * remote.c (remote_target): Use delete.
1245         * remote-notif.h: Include <list>, not "common/queue.h".
1246         (notif_client_p): Remove typedef.
1247         (remote_notif_state): Add constructor, destructor, initializer.
1248         <notif_queue>: Now a std::list.
1249         (remote_notif_state_xfree): Don't declare.
1250         * remote-notif.c (remote_notif_process, handle_notification)
1251         (remote_notif_state_allocate): Update.
1252         (~remote_notif_state): Rename from remote_notif_state_xfree.
1253
1254 2019-04-19  Tom Tromey  <tom@tromey.com>
1255
1256         * symfile.c (reread_symbols): Update.
1257         * objfiles.c (objfile_register_static_link)
1258         (objfile_lookup_static_link): Update
1259         (~objfile) Don't delete static_links.
1260         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1261
1262 2019-04-19  Tom Tromey  <tom@tromey.com>
1263
1264         * type-stack.h (struct type_stack) <insert>: Constify string.
1265         * type-stack.c (type_stack::insert): Constify string.
1266         * gdbtypes.h (lookup_template_type): Update.
1267         (address_space_name_to_int): Update.
1268         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1269         const.
1270         (lookup_template_type): Make name const.
1271         * c-exp.y: Update rules.
1272         (lex_one_token, classify_name, classify_inner_name)
1273         (c_print_token): Update.
1274         * p-exp.y: Update rules.
1275         (yylex): Update.
1276         * f-exp.y: Update rules.
1277         (yylex): Update.
1278         * d-exp.y: Update rules.
1279         (lex_one_token, classify_name, classify_inner_name): Update.
1280         * parse.c (write_dollar_variable, copy_name): Return std::string.
1281         * parser-defs.h (copy_name): Change return type.
1282         * m2-exp.y: Update rules.
1283         (yylex): Update.
1284         * go-exp.y (lex_one_token): Update.
1285         Update rules.
1286         (classify_unsafe_function, classify_packaged_name)
1287         (classify_name, yylex): Update.
1288
1289 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1290
1291         * configure.ac: add --enable-source-highlight switch.
1292         * configure: Regenerate.
1293         * top.c (print_gdb_version): plumb --enable-source-highlight
1294         status to "show configuration".
1295
1296 2019-04-19  Tom Tromey  <tromey@adacore.com>
1297
1298         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1299         Check ADA_TYPE_P.
1300         (empty_record, ada_template_to_fixed_record_type_1)
1301         (template_to_static_fixed_type)
1302         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1303         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1304         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1305         macros.
1306
1307 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1308
1309         PR symtab/24423:
1310         * source.c (print_source_lines_base): Advance "iter" when a
1311         control character is seen.
1312
1313 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1314
1315         * inferior.h (struct infcall_suspend_state_deleter):
1316         Catch exception in destructor to avoid crash.
1317
1318 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1319
1320         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1321         close to the add_com "shell".
1322
1323 2019-04-18  Tom Tromey  <tromey@adacore.com>
1324
1325         * process-stratum-target.h (class process_stratum_target)
1326         <stratum>: Add "final".
1327
1328 2019-04-17  Tom Tromey  <tromey@adacore.com>
1329
1330         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1331         against nullptr before use.
1332
1333 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1334
1335         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1336
1337 2019-04-17  Jim Wilson  <jimw@sifive.com>
1338             Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1341         code read might fail, assume 4-byte breakpoint in that case.
1342
1343 2019-04-15  Leszek Swirski  <leszeks@google.com>
1344
1345         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1346         rather than a hand-rolled POD check when checking for forced MEMORY
1347         classification.
1348
1349 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1350
1351         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1352         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1353         function.
1354         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1355         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1356         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1357         declaration.
1358
1359 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1360
1361         * aarch64-linux-nat.c
1362         (aarch64_linux_nat_target::thread_architecture): Add override.
1363         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1364         each VQ.
1365
1366 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1367
1368         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1369
1370 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1371
1372         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1373         target types of size 96-bits, add some additional comments, and
1374         check that the builtin type we found was the correct size.
1375
1376 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1377
1378         * utils.c (prompt_for_continue): Don't restore the styling at the
1379         end, as applied_style has the wrong value.  This fixes styling in
1380         long lists of file names that are interrupted by the "Continue?"
1381         prompt.
1382
1383 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1386         * c-lang.c (c_language_defn): Likewise.
1387         (cplus_language_defn): Likewise.
1388         (asm_language_defn): Likewise.
1389         (minimal_language_defn): Likewise.
1390         * d-lang.c (d_language_defn): Likewise.
1391         * f-lang.c (f_language_defn): Likewise.
1392         * go-lang.c (go_language_defn): Likewise.
1393         * language.c (unknown_language_defn): Likewise.
1394         (auto_language_defn): Likewise.
1395         * language.h (struct language_defn): Remove la_magic field.
1396         (LANG_MAGIC): Delete.
1397         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1398         * objc-lang.c (objc_language_defn): Likewise.
1399         * opencl-lang.c (opencl_language_defn): Likewise.
1400         * p-lang.c (pascal_language_defn): Likewise.
1401         * rust-lang.c (rust_language_defn): Likewise.
1402
1403 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         * riscv-tdep.c (riscv_type_align): New function.
1406         (riscv_type_alignment): Delete.
1407         (riscv_arg_location): Use 'type_align'.
1408         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1409
1410 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1411
1412         * gdbtypes.c (type_align): A struct with no non-static fields also
1413         has alignment of 1.
1414
1415 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1416
1417         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1418         component to 0.
1419         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1420         member.
1421         (riscv_struct_info::analyse): New implementation using new
1422         analyse_inner member function.
1423         (riscv_struct_info::field_offset): New member function.
1424         (riscv_struct_info::m_offsets): New member variable.
1425         (riscv_struct_info::analyse_inner): New private member function,
1426         takes the old implementation of riscv_struct_info::analyse but
1427         extended to track field offsets.
1428         (riscv_call_arg_struct): Update the struct folding special cases
1429         to handle cases where empty C++ structs, which are non-zero
1430         length, are found.
1431         (riscv_arg_location): Initialise the length of each location, a
1432         non-zero length now indicates the location is in use.
1433         (riscv_push_dummy_call): Allow for the first location having a
1434         non-zero offset when setting up arguments.
1435         (riscv_return_value): Likewise, but for return values.
1436
1437 2019-04-11  Tom Tromey  <tromey@adacore.com>
1438
1439         * utils.c (internal_vproblem): Make "msg" const.
1440
1441 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1442
1443         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1444         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1445         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1446         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1447
1448 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1449
1450         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1451         function.
1452         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1453         of amd64_collect_native_gregset.
1454         (amd64_linux_nat_target::store_registers): Likewise.
1455
1456 2019-04-10  Tom Tromey  <tom@tromey.com>
1457
1458         * symtab.c (lookup_global_symbol_from_objfile)
1459         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1460         * objfiles.h (class separate_debug_iterator): New.
1461         (class separate_debug_range): New.
1462         (struct objfile) <separate_debug_objfiles>: New method.
1463         (objfile_separate_debug_iterate): Don't declare.
1464         * objfiles.c (separate_debug_iterator::operator++): Rename from
1465         objfile_separate_debug_iterate.
1466         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1467         iterator.
1468         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1469         iterator.
1470
1471 2019-04-10  Tom Tromey  <tom@tromey.com>
1472
1473         * symfile.c (reread_symbols): Remove old comment.
1474         * objfiles.c (free_all_objfiles): Fix a typo.
1475
1476 2019-04-10  Tom Tromey  <tom@tromey.com>
1477
1478         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1479         * minsyms.c (lookup_minimal_symbol): Use foreach.
1480         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1481         (lookup_minimal_symbol_solib_trampoline): Likewise.
1482         * symfile.c (reread_symbols): Use foreach.
1483
1484 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1485             Tom Tromey  <tromey@adacore.com>
1486
1487         PR rust/24414:
1488         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1489         (rust_lex_int_test): Change "value" to be LONGEST.
1490         (rust_lex_tests): Add test for long integer literal.
1491
1492 2019-04-09  Tom Tromey  <tromey@adacore.com>
1493
1494         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1495         to bool.
1496         (extended_remote_target::attach): Update.
1497         (remote_target::remote_notice_new_inferior): Update.
1498         (remote_target::add_current_inferior_and_thread): Update.
1499         * inferior.c (exit_inferior_1): Use "false".
1500         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1501
1502 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1503
1504         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1505         the "start" command.
1506
1507 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1508
1509         * python/py-inferior.c (infpy_thread_from_thread_handle):
1510         Adjust comments to reflect renaming of thread_from_thread_handle
1511         to thread_from_handle.  Adjust keywords.  Fix type error message.
1512         (inferior_object_methods): Add thread_from_handle.  Retain
1513         thread_from_thread_handle, but mark it as deprecated.
1514
1515 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1516
1517         * gdbthread.h (find_thread_by_handle): Revise declaration.
1518         * thread.c (find_thread_by_handle): Likewise.  Adjust
1519         implementation too.
1520         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1521         support for buffer objects as handles.
1522
1523 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1524
1525         * python/py-infthread.c (thpy_thread_handle): New function.
1526         (thread_object_methods): Register thpy_thread_handle.
1527
1528 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1529
1530         * gdbthread.h (thread_to_thread_handle): Declare.
1531         * thread.c (gdbtypes.h): Include.
1532         (thread_to_thread_handle): New function.
1533
1534         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1535         (target_thread_info_to_thread_handle): Declare.
1536         * target.c (target_thread_info_to_thread_handle): New function.
1537         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1538         * target-delegates.c: Regenerate.
1539
1540         * linux-thread-db.c (class thread_db_target): Add method
1541         thread_info_to_thread_handle.
1542         (thread_db_target::thread_info_to_thread_handle): Define.
1543         * remote.c (class remote_target): Add new method
1544         thread_info_to_thread_handle.
1545         (remote_target::thread_info_to_thread_handle): Define.
1546
1547 2019-04-08  Pedro Alves  <palves@redhat.com>
1548
1549         * common/common-exceptions.c (throw_exception): Don't create
1550         named object to throw; throw directly.
1551         (throw_it): Likewise.  Don't initialize gdb_exception::message
1552         here, with new; pass FMT and AP to the ctor instead.
1553         * common/common-exceptions.h: Include <string>.
1554         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1555         const char *, va_list)): New ctor.  Use std::make_shared.
1556         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1557         errors)): Delete.
1558         (gdb_exception_error::gdb_exception_error(enum errors, const char
1559         *, va_list)): New.
1560         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1561         Add assertion.
1562         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1563         errors)): Delete.
1564         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1565         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1566         Add assertion.
1567
1568 2019-04-08  Tom Tromey  <tom@tromey.com>
1569
1570         * valops.c (value_rtti_indirect_type): Replace throw_exception
1571         with throw.
1572         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1573         with throw.
1574         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1575         throw.
1576         * target.c (target_translate_tls_address): Replace throw_exception
1577         with throw.
1578         * stack.c (frame_apply_command_count): Replace throw_exception
1579         with throw.
1580         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1581         throw.
1582         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1583         with throw.
1584         * rs6000-tdep.c (rs6000_frame_cache)
1585         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1586         * remote.c: Replace throw_exception with throw.
1587         * record-full.c (record_full_message, record_full_wait_1)
1588         (record_full_restore): Replace throw_exception with throw.
1589         * record-btrace.c:
1590         (get_thread_current_frame_id, record_btrace_start_replaying)
1591         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1592         (cmd_record_btrace_start): Replace throw_exception with throw.
1593         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1594         throw.
1595         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1596         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1597         * linespec.c:
1598         (find_linespec_symbols): Replace throw_exception with throw.
1599         * infrun.c (displaced_step_prepare, resume): Replace
1600         throw_exception with throw.
1601         * infcmd.c (post_create_inferior): Replace throw_exception with
1602         throw.
1603         * inf-loop.c (inferior_event_handler): Replace throw_exception
1604         with throw.
1605         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1606         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1607         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1608         (get_prev_frame_always, get_frame_pc_if_available)
1609         (get_frame_address_in_block_if_available, get_frame_language):
1610         Replace throw_exception with throw.
1611         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1612         throw_exception with throw.
1613         * eval.c (fetch_subexp_value, evaluate_var_value)
1614         (evaluate_funcall, evaluate_subexp_standard): Replace
1615         throw_exception with throw.
1616         * dwarf2loc.c (call_site_find_chain)
1617         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1618         Replace throw_exception with throw.
1619         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1620         with throw.
1621         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1622         throw.
1623         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1624         * completer.c (complete_line_internal): Replace throw_exception
1625         with throw.
1626         * compile/compile-object-run.c (compile_object_run): Replace
1627         throw_exception with throw.
1628         * cli/cli-script.c (process_next_line): Replace throw_exception
1629         with throw.
1630         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1631         (btrace_enable, btrace_maint_update_pt_packets): Replace
1632         throw_exception with throw.
1633         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1634         throw_exception with throw.
1635         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1636         throw_exception with throw.
1637         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1638         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1639         * aarch64-tdep.c (aarch64_make_prologue_cache)
1640         (aarch64_make_stub_cache): Replace throw_exception with throw.
1641
1642 2019-04-08  Tom Tromey  <tom@tromey.com>
1643
1644         * common/common-exceptions.c (throw_exception): Rename from
1645         throw_exception_cxx.  Remove old copy.  Make argument const.
1646         (throw_it): Create and throw exception objects directly.
1647         * common/common-exceptions.h (throw_exception): Make argument
1648         const.
1649         (struct gdb_exception_error): Add constructor.
1650         (struct gdb_exception_quit): Add constructor.
1651
1652 2019-04-08  Tom Tromey  <tom@tromey.com>
1653
1654         * common/common-exceptions.h (exception_rethrow): Don't declare.
1655         (TRY_SJLJ): Update comment.
1656         (TRY, CATCH, END_CATCH): Remove.
1657         * common/common-exceptions.c (exception_rethrow): Remove.
1658
1659 2019-04-08  Tom Tromey  <tom@tromey.com>
1660
1661         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1662         Remove.
1663         (gdb_exception_error): Rename from
1664         gdb_exception_RETURN_MASK_ERROR.
1665         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1666         (gdb_quit_bad_alloc): Update.
1667         * aarch64-tdep.c: Update.
1668         * ada-lang.c: Update.
1669         * ada-typeprint.c: Update.
1670         * ada-valprint.c: Update.
1671         * amd64-tdep.c: Update.
1672         * arch-utils.c: Update.
1673         * break-catch-throw.c: Update.
1674         * breakpoint.c: Update.
1675         * btrace.c: Update.
1676         * c-varobj.c: Update.
1677         * cli/cli-cmds.c: Update.
1678         * cli/cli-interp.c: Update.
1679         * cli/cli-script.c: Update.
1680         * common/common-exceptions.c: Update.
1681         * common/new-op.c: Update.
1682         * common/selftest.c: Update.
1683         * compile/compile-c-symbols.c: Update.
1684         * compile/compile-cplus-symbols.c: Update.
1685         * compile/compile-object-load.c: Update.
1686         * compile/compile-object-run.c: Update.
1687         * completer.c: Update.
1688         * corelow.c: Update.
1689         * cp-abi.c: Update.
1690         * cp-support.c: Update.
1691         * cp-valprint.c: Update.
1692         * darwin-nat.c: Update.
1693         * disasm-selftests.c: Update.
1694         * dtrace-probe.c: Update.
1695         * dwarf-index-cache.c: Update.
1696         * dwarf-index-write.c: Update.
1697         * dwarf2-frame-tailcall.c: Update.
1698         * dwarf2-frame.c: Update.
1699         * dwarf2loc.c: Update.
1700         * dwarf2read.c: Update.
1701         * eval.c: Update.
1702         * event-loop.c: Update.
1703         * event-top.c: Update.
1704         * exec.c: Update.
1705         * f-valprint.c: Update.
1706         * fbsd-tdep.c: Update.
1707         * frame-unwind.c: Update.
1708         * frame.c: Update.
1709         * gdbtypes.c: Update.
1710         * gnu-v3-abi.c: Update.
1711         * guile/guile-internal.h: Update.
1712         * guile/scm-block.c: Update.
1713         * guile/scm-breakpoint.c: Update.
1714         * guile/scm-cmd.c: Update.
1715         * guile/scm-disasm.c: Update.
1716         * guile/scm-frame.c: Update.
1717         * guile/scm-lazy-string.c: Update.
1718         * guile/scm-math.c: Update.
1719         * guile/scm-param.c: Update.
1720         * guile/scm-ports.c: Update.
1721         * guile/scm-pretty-print.c: Update.
1722         * guile/scm-symbol.c: Update.
1723         * guile/scm-symtab.c: Update.
1724         * guile/scm-type.c: Update.
1725         * guile/scm-value.c: Update.
1726         * i386-linux-tdep.c: Update.
1727         * i386-tdep.c: Update.
1728         * inf-loop.c: Update.
1729         * infcall.c: Update.
1730         * infcmd.c: Update.
1731         * infrun.c: Update.
1732         * jit.c: Update.
1733         * language.c: Update.
1734         * linespec.c: Update.
1735         * linux-fork.c: Update.
1736         * linux-nat.c: Update.
1737         * linux-tdep.c: Update.
1738         * linux-thread-db.c: Update.
1739         * main.c: Update.
1740         * mi/mi-cmd-break.c: Update.
1741         * mi/mi-cmd-stack.c: Update.
1742         * mi/mi-interp.c: Update.
1743         * mi/mi-main.c: Update.
1744         * objc-lang.c: Update.
1745         * p-valprint.c: Update.
1746         * parse.c: Update.
1747         * ppc-linux-tdep.c: Update.
1748         * printcmd.c: Update.
1749         * python/py-arch.c: Update.
1750         * python/py-breakpoint.c: Update.
1751         * python/py-cmd.c: Update.
1752         * python/py-finishbreakpoint.c: Update.
1753         * python/py-frame.c: Update.
1754         * python/py-framefilter.c: Update.
1755         * python/py-gdb-readline.c: Update.
1756         * python/py-inferior.c: Update.
1757         * python/py-infthread.c: Update.
1758         * python/py-lazy-string.c: Update.
1759         * python/py-linetable.c: Update.
1760         * python/py-objfile.c: Update.
1761         * python/py-param.c: Update.
1762         * python/py-prettyprint.c: Update.
1763         * python/py-progspace.c: Update.
1764         * python/py-record-btrace.c: Update.
1765         * python/py-record.c: Update.
1766         * python/py-symbol.c: Update.
1767         * python/py-type.c: Update.
1768         * python/py-unwind.c: Update.
1769         * python/py-utils.c: Update.
1770         * python/py-value.c: Update.
1771         * python/python.c: Update.
1772         * record-btrace.c: Update.
1773         * record-full.c: Update.
1774         * remote-fileio.c: Update.
1775         * remote.c: Update.
1776         * riscv-tdep.c: Update.
1777         * rs6000-aix-tdep.c: Update.
1778         * rs6000-tdep.c: Update.
1779         * rust-exp.y: Update.
1780         * rust-lang.c: Update.
1781         * s390-tdep.c: Update.
1782         * selftest-arch.c: Update.
1783         * solib-dsbt.c: Update.
1784         * solib-frv.c: Update.
1785         * solib-spu.c: Update.
1786         * solib-svr4.c: Update.
1787         * solib.c: Update.
1788         * sparc64-linux-tdep.c: Update.
1789         * stack.c: Update.
1790         * symfile-mem.c: Update.
1791         * symmisc.c: Update.
1792         * target.c: Update.
1793         * thread.c: Update.
1794         * top.c: Update.
1795         * tracefile-tfile.c: Update.
1796         * tui/tui.c: Update.
1797         * typeprint.c: Update.
1798         * unittests/cli-utils-selftests.c: Update.
1799         * unittests/parse-connection-spec-selftests.c: Update.
1800         * valops.c: Update.
1801         * valprint.c: Update.
1802         * value.c: Update.
1803         * varobj.c: Update.
1804         * windows-nat.c: Update.
1805         * x86-linux-nat.c: Update.
1806         * xml-support.c: Update.
1807
1808 2019-04-08  Tom Tromey  <tom@tromey.com>
1809
1810         * xml-support.c: Use C++ exception handling.
1811         * x86-linux-nat.c: Use C++ exception handling.
1812         * windows-nat.c: Use C++ exception handling.
1813         * varobj.c: Use C++ exception handling.
1814         * value.c: Use C++ exception handling.
1815         * valprint.c: Use C++ exception handling.
1816         * valops.c: Use C++ exception handling.
1817         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1818         handling.
1819         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1820         * typeprint.c: Use C++ exception handling.
1821         * tui/tui.c: Use C++ exception handling.
1822         * tracefile-tfile.c: Use C++ exception handling.
1823         * top.c: Use C++ exception handling.
1824         * thread.c: Use C++ exception handling.
1825         * target.c: Use C++ exception handling.
1826         * symmisc.c: Use C++ exception handling.
1827         * symfile-mem.c: Use C++ exception handling.
1828         * stack.c: Use C++ exception handling.
1829         * sparc64-linux-tdep.c: Use C++ exception handling.
1830         * solib.c: Use C++ exception handling.
1831         * solib-svr4.c: Use C++ exception handling.
1832         * solib-spu.c: Use C++ exception handling.
1833         * solib-frv.c: Use C++ exception handling.
1834         * solib-dsbt.c: Use C++ exception handling.
1835         * selftest-arch.c: Use C++ exception handling.
1836         * s390-tdep.c: Use C++ exception handling.
1837         * rust-lang.c: Use C++ exception handling.
1838         * rust-exp.y: Use C++ exception handling.
1839         * rs6000-tdep.c: Use C++ exception handling.
1840         * rs6000-aix-tdep.c: Use C++ exception handling.
1841         * riscv-tdep.c: Use C++ exception handling.
1842         * remote.c: Use C++ exception handling.
1843         * remote-fileio.c: Use C++ exception handling.
1844         * record-full.c: Use C++ exception handling.
1845         * record-btrace.c: Use C++ exception handling.
1846         * python/python.c: Use C++ exception handling.
1847         * python/py-value.c: Use C++ exception handling.
1848         * python/py-utils.c: Use C++ exception handling.
1849         * python/py-unwind.c: Use C++ exception handling.
1850         * python/py-type.c: Use C++ exception handling.
1851         * python/py-symbol.c: Use C++ exception handling.
1852         * python/py-record.c: Use C++ exception handling.
1853         * python/py-record-btrace.c: Use C++ exception handling.
1854         * python/py-progspace.c: Use C++ exception handling.
1855         * python/py-prettyprint.c: Use C++ exception handling.
1856         * python/py-param.c: Use C++ exception handling.
1857         * python/py-objfile.c: Use C++ exception handling.
1858         * python/py-linetable.c: Use C++ exception handling.
1859         * python/py-lazy-string.c: Use C++ exception handling.
1860         * python/py-infthread.c: Use C++ exception handling.
1861         * python/py-inferior.c: Use C++ exception handling.
1862         * python/py-gdb-readline.c: Use C++ exception handling.
1863         * python/py-framefilter.c: Use C++ exception handling.
1864         * python/py-frame.c: Use C++ exception handling.
1865         * python/py-finishbreakpoint.c: Use C++ exception handling.
1866         * python/py-cmd.c: Use C++ exception handling.
1867         * python/py-breakpoint.c: Use C++ exception handling.
1868         * python/py-arch.c: Use C++ exception handling.
1869         * printcmd.c: Use C++ exception handling.
1870         * ppc-linux-tdep.c: Use C++ exception handling.
1871         * parse.c: Use C++ exception handling.
1872         * p-valprint.c: Use C++ exception handling.
1873         * objc-lang.c: Use C++ exception handling.
1874         * mi/mi-main.c: Use C++ exception handling.
1875         * mi/mi-interp.c: Use C++ exception handling.
1876         * mi/mi-cmd-stack.c: Use C++ exception handling.
1877         * mi/mi-cmd-break.c: Use C++ exception handling.
1878         * main.c: Use C++ exception handling.
1879         * linux-thread-db.c: Use C++ exception handling.
1880         * linux-tdep.c: Use C++ exception handling.
1881         * linux-nat.c: Use C++ exception handling.
1882         * linux-fork.c: Use C++ exception handling.
1883         * linespec.c: Use C++ exception handling.
1884         * language.c: Use C++ exception handling.
1885         * jit.c: Use C++ exception handling.
1886         * infrun.c: Use C++ exception handling.
1887         * infcmd.c: Use C++ exception handling.
1888         * infcall.c: Use C++ exception handling.
1889         * inf-loop.c: Use C++ exception handling.
1890         * i386-tdep.c: Use C++ exception handling.
1891         * i386-linux-tdep.c: Use C++ exception handling.
1892         * guile/scm-value.c: Use C++ exception handling.
1893         * guile/scm-type.c: Use C++ exception handling.
1894         * guile/scm-symtab.c: Use C++ exception handling.
1895         * guile/scm-symbol.c: Use C++ exception handling.
1896         * guile/scm-pretty-print.c: Use C++ exception handling.
1897         * guile/scm-ports.c: Use C++ exception handling.
1898         * guile/scm-param.c: Use C++ exception handling.
1899         * guile/scm-math.c: Use C++ exception handling.
1900         * guile/scm-lazy-string.c: Use C++ exception handling.
1901         * guile/scm-frame.c: Use C++ exception handling.
1902         * guile/scm-disasm.c: Use C++ exception handling.
1903         * guile/scm-cmd.c: Use C++ exception handling.
1904         * guile/scm-breakpoint.c: Use C++ exception handling.
1905         * guile/scm-block.c: Use C++ exception handling.
1906         * guile/guile-internal.h: Use C++ exception handling.
1907         * gnu-v3-abi.c: Use C++ exception handling.
1908         * gdbtypes.c: Use C++ exception handling.
1909         * frame.c: Use C++ exception handling.
1910         * frame-unwind.c: Use C++ exception handling.
1911         * fbsd-tdep.c: Use C++ exception handling.
1912         * f-valprint.c: Use C++ exception handling.
1913         * exec.c: Use C++ exception handling.
1914         * event-top.c: Use C++ exception handling.
1915         * event-loop.c: Use C++ exception handling.
1916         * eval.c: Use C++ exception handling.
1917         * dwarf2read.c: Use C++ exception handling.
1918         * dwarf2loc.c: Use C++ exception handling.
1919         * dwarf2-frame.c: Use C++ exception handling.
1920         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1921         * dwarf-index-write.c: Use C++ exception handling.
1922         * dwarf-index-cache.c: Use C++ exception handling.
1923         * dtrace-probe.c: Use C++ exception handling.
1924         * disasm-selftests.c: Use C++ exception handling.
1925         * darwin-nat.c: Use C++ exception handling.
1926         * cp-valprint.c: Use C++ exception handling.
1927         * cp-support.c: Use C++ exception handling.
1928         * cp-abi.c: Use C++ exception handling.
1929         * corelow.c: Use C++ exception handling.
1930         * completer.c: Use C++ exception handling.
1931         * compile/compile-object-run.c: Use C++ exception handling.
1932         * compile/compile-object-load.c: Use C++ exception handling.
1933         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1934         * compile/compile-c-symbols.c: Use C++ exception handling.
1935         * common/selftest.c: Use C++ exception handling.
1936         * common/new-op.c: Use C++ exception handling.
1937         * cli/cli-script.c: Use C++ exception handling.
1938         * cli/cli-interp.c: Use C++ exception handling.
1939         * cli/cli-cmds.c: Use C++ exception handling.
1940         * c-varobj.c: Use C++ exception handling.
1941         * btrace.c: Use C++ exception handling.
1942         * breakpoint.c: Use C++ exception handling.
1943         * break-catch-throw.c: Use C++ exception handling.
1944         * arch-utils.c: Use C++ exception handling.
1945         * amd64-tdep.c: Use C++ exception handling.
1946         * ada-valprint.c: Use C++ exception handling.
1947         * ada-typeprint.c: Use C++ exception handling.
1948         * ada-lang.c: Use C++ exception handling.
1949         * aarch64-tdep.c: Use C++ exception handling.
1950
1951 2019-04-08  Tom Tromey  <tom@tromey.com>
1952
1953         * xml-support.c (gdb_xml_parser::parse): Update.
1954         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1955         * value.c (show_convenience): Update.
1956         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1957         (test_parse_flags_qcs): Update.
1958         * thread.c (thr_try_catch_cmd): Update.
1959         * target.c (target_translate_tls_address): Update.
1960         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1961         (info_frame_command_core, frame_apply_command_count): Update.
1962         * rust-exp.y (rust_lex_exception_test): Update.
1963         * riscv-tdep.c (riscv_print_one_register_info): Update.
1964         * remote.c (remote_target::enable_btrace): Update.
1965         * record-btrace.c (record_btrace_enable_warn): Update.
1966         * python/py-utils.c (gdbpy_convert_exception): Update.
1967         * printcmd.c (do_one_display, print_variable_and_value): Update.
1968         * mi/mi-main.c (mi_print_exception): Update.
1969         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1970         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1971         * linux-nat.c (linux_nat_target::attach): Update.
1972         * linux-fork.c (class scoped_switch_fork_info): Update.
1973         * infrun.c (displaced_step_prepare): Update.
1974         * infcall.c (call_function_by_hand_dummy): Update.
1975         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1976         * gnu-v3-abi.c (print_one_vtable): Update.
1977         * frame.c (get_prev_frame_always): Update.
1978         * f-valprint.c (info_common_command_for_block): Update.
1979         * exec.c (try_open_exec_file): Update.
1980         * exceptions.c (print_exception, exception_print)
1981         (exception_fprintf, exception_print_same): Update.
1982         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1983         * dwarf-index-cache.c (index_cache::store)
1984         (index_cache::lookup_gdb_index): Update.
1985         * darwin-nat.c (maybe_cache_shell): Update.
1986         * cp-valprint.c (cp_print_value_fields): Update.
1987         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1988         (gcc_cplus_symbol_address): Update.
1989         * compile/compile-c-symbols.c (gcc_convert_symbol)
1990         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1991         * common/selftest.c: Update.
1992         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1993         a std::string.
1994         (exception_try_scope_entry, exception_try_scope_exit): Don't
1995         declare.
1996         (struct exception_try_scope): Remove.
1997         (TRY): Don't use exception_try_scope.
1998         (struct gdb_exception): Add constructor, operator=.
1999         <what>: New method.
2000         (struct gdb_exception_RETURN_MASK_ALL)
2001         (struct gdb_exception_RETURN_MASK_ERROR)
2002         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2003         (struct gdb_quit_bad_alloc): Update.
2004         * common/common-exceptions.c (exception_none): Change
2005         initializer.
2006         (struct catcher) <state, exception>: Initialize inline.
2007         <prev>: Remove member.
2008         (current_catcher): Remove.
2009         (catchers): New global.
2010         (exceptions_state_mc_init): Simplify.
2011         (catcher_pop): Remove.
2012         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2013         (try_scope_depth, exception_try_scope_entry)
2014         (exception_try_scope_exit): Remove.
2015         (throw_exception_sjlj): Update.
2016         (exception_messages, exception_messages_size): Remove.
2017         (throw_it): Simplify.
2018         (gdb_exception_sliced_copy): Remove.
2019         (throw_exception_cxx): Update.
2020         * cli/cli-script.c (script_from_file): Update.
2021         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2022         Update.
2023         * ada-valprint.c (ada_val_print): Update.
2024         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2025         (create_excep_cond_exprs): Update.
2026
2027 2019-04-08  Tom Tromey  <tom@tromey.com>
2028
2029         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2030         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2031         (TRY, CATCH, END_CATCH): Remove some definitions.
2032         * common/common-exceptions.c: Don't use GDB_XCPT.
2033         (catcher_list_size): Remove.
2034         (throw_exception, throw_it): Simplify.
2035
2036 2019-04-05  Tom Tromey  <tom@tromey.com>
2037
2038         Revert the header-sorting patch.
2039         * ft32-tdep.c: Revert.
2040         * frv-tdep.c: Revert.
2041         * frv-linux-tdep.c: Revert.
2042         * frame.c: Revert.
2043         * frame-unwind.c: Revert.
2044         * frame-base.c: Revert.
2045         * fork-child.c: Revert.
2046         * findvar.c: Revert.
2047         * findcmd.c: Revert.
2048         * filesystem.c: Revert.
2049         * filename-seen-cache.h: Revert.
2050         * filename-seen-cache.c: Revert.
2051         * fbsd-tdep.c: Revert.
2052         * fbsd-nat.h: Revert.
2053         * fbsd-nat.c: Revert.
2054         * f-valprint.c: Revert.
2055         * f-typeprint.c: Revert.
2056         * f-lang.c: Revert.
2057         * extension.h: Revert.
2058         * extension.c: Revert.
2059         * extension-priv.h: Revert.
2060         * expprint.c: Revert.
2061         * exec.h: Revert.
2062         * exec.c: Revert.
2063         * exceptions.c: Revert.
2064         * event-top.c: Revert.
2065         * event-loop.c: Revert.
2066         * eval.c: Revert.
2067         * elfread.c: Revert.
2068         * dwarf2read.h: Revert.
2069         * dwarf2read.c: Revert.
2070         * dwarf2loc.c: Revert.
2071         * dwarf2expr.h: Revert.
2072         * dwarf2expr.c: Revert.
2073         * dwarf2-frame.c: Revert.
2074         * dwarf2-frame-tailcall.c: Revert.
2075         * dwarf-index-write.h: Revert.
2076         * dwarf-index-write.c: Revert.
2077         * dwarf-index-common.c: Revert.
2078         * dwarf-index-cache.h: Revert.
2079         * dwarf-index-cache.c: Revert.
2080         * dummy-frame.c: Revert.
2081         * dtrace-probe.c: Revert.
2082         * disasm.h: Revert.
2083         * disasm.c: Revert.
2084         * disasm-selftests.c: Revert.
2085         * dictionary.c: Revert.
2086         * dicos-tdep.c: Revert.
2087         * demangle.c: Revert.
2088         * dcache.h: Revert.
2089         * dcache.c: Revert.
2090         * darwin-nat.h: Revert.
2091         * darwin-nat.c: Revert.
2092         * darwin-nat-info.c: Revert.
2093         * d-valprint.c: Revert.
2094         * d-namespace.c: Revert.
2095         * d-lang.c: Revert.
2096         * ctf.c: Revert.
2097         * csky-tdep.c: Revert.
2098         * csky-linux-tdep.c: Revert.
2099         * cris-tdep.c: Revert.
2100         * cris-linux-tdep.c: Revert.
2101         * cp-valprint.c: Revert.
2102         * cp-support.c: Revert.
2103         * cp-namespace.c: Revert.
2104         * cp-abi.c: Revert.
2105         * corelow.c: Revert.
2106         * corefile.c: Revert.
2107         * continuations.c: Revert.
2108         * completer.h: Revert.
2109         * completer.c: Revert.
2110         * complaints.c: Revert.
2111         * coffread.c: Revert.
2112         * coff-pe-read.c: Revert.
2113         * cli-out.h: Revert.
2114         * cli-out.c: Revert.
2115         * charset.c: Revert.
2116         * c-varobj.c: Revert.
2117         * c-valprint.c: Revert.
2118         * c-typeprint.c: Revert.
2119         * c-lang.c: Revert.
2120         * buildsym.c: Revert.
2121         * buildsym-legacy.c: Revert.
2122         * build-id.h: Revert.
2123         * build-id.c: Revert.
2124         * btrace.c: Revert.
2125         * bsd-uthread.c: Revert.
2126         * breakpoint.h: Revert.
2127         * breakpoint.c: Revert.
2128         * break-catch-throw.c: Revert.
2129         * break-catch-syscall.c: Revert.
2130         * break-catch-sig.c: Revert.
2131         * blockframe.c: Revert.
2132         * block.c: Revert.
2133         * bfin-tdep.c: Revert.
2134         * bfin-linux-tdep.c: Revert.
2135         * bfd-target.c: Revert.
2136         * bcache.c: Revert.
2137         * ax-general.c: Revert.
2138         * ax-gdb.h: Revert.
2139         * ax-gdb.c: Revert.
2140         * avr-tdep.c: Revert.
2141         * auxv.c: Revert.
2142         * auto-load.c: Revert.
2143         * arm-wince-tdep.c: Revert.
2144         * arm-tdep.c: Revert.
2145         * arm-symbian-tdep.c: Revert.
2146         * arm-pikeos-tdep.c: Revert.
2147         * arm-obsd-tdep.c: Revert.
2148         * arm-nbsd-tdep.c: Revert.
2149         * arm-nbsd-nat.c: Revert.
2150         * arm-linux-tdep.c: Revert.
2151         * arm-linux-nat.c: Revert.
2152         * arm-fbsd-tdep.c: Revert.
2153         * arm-fbsd-nat.c: Revert.
2154         * arm-bsd-tdep.c: Revert.
2155         * arch-utils.c: Revert.
2156         * arc-tdep.c: Revert.
2157         * arc-newlib-tdep.c: Revert.
2158         * annotate.h: Revert.
2159         * annotate.c: Revert.
2160         * amd64-windows-tdep.c: Revert.
2161         * amd64-windows-nat.c: Revert.
2162         * amd64-tdep.c: Revert.
2163         * amd64-sol2-tdep.c: Revert.
2164         * amd64-obsd-tdep.c: Revert.
2165         * amd64-obsd-nat.c: Revert.
2166         * amd64-nbsd-tdep.c: Revert.
2167         * amd64-nbsd-nat.c: Revert.
2168         * amd64-nat.c: Revert.
2169         * amd64-linux-tdep.c: Revert.
2170         * amd64-linux-nat.c: Revert.
2171         * amd64-fbsd-tdep.c: Revert.
2172         * amd64-fbsd-nat.c: Revert.
2173         * amd64-dicos-tdep.c: Revert.
2174         * amd64-darwin-tdep.c: Revert.
2175         * amd64-bsd-nat.c: Revert.
2176         * alpha-tdep.c: Revert.
2177         * alpha-obsd-tdep.c: Revert.
2178         * alpha-nbsd-tdep.c: Revert.
2179         * alpha-mdebug-tdep.c: Revert.
2180         * alpha-linux-tdep.c: Revert.
2181         * alpha-linux-nat.c: Revert.
2182         * alpha-bsd-tdep.c: Revert.
2183         * alpha-bsd-nat.c: Revert.
2184         * aix-thread.c: Revert.
2185         * agent.c: Revert.
2186         * addrmap.c: Revert.
2187         * ada-varobj.c: Revert.
2188         * ada-valprint.c: Revert.
2189         * ada-typeprint.c: Revert.
2190         * ada-tasks.c: Revert.
2191         * ada-lang.c: Revert.
2192         * aarch64-tdep.c: Revert.
2193         * aarch64-ravenscar-thread.c: Revert.
2194         * aarch64-newlib-tdep.c: Revert.
2195         * aarch64-linux-tdep.c: Revert.
2196         * aarch64-linux-nat.c: Revert.
2197         * aarch64-fbsd-tdep.c: Revert.
2198         * aarch64-fbsd-nat.c: Revert.
2199         * aarch32-linux-nat.c: Revert.
2200
2201 2019-04-05  Tom Tromey  <tom@tromey.com>
2202
2203         * ft32-tdep.c: Sort headers.
2204         * frv-tdep.c: Sort headers.
2205         * frv-linux-tdep.c: Sort headers.
2206         * frame.c: Sort headers.
2207         * frame-unwind.c: Sort headers.
2208         * frame-base.c: Sort headers.
2209         * fork-child.c: Sort headers.
2210         * findvar.c: Sort headers.
2211         * findcmd.c: Sort headers.
2212         * filesystem.c: Sort headers.
2213         * filename-seen-cache.h: Sort headers.
2214         * filename-seen-cache.c: Sort headers.
2215         * fbsd-tdep.c: Sort headers.
2216         * fbsd-nat.h: Sort headers.
2217         * fbsd-nat.c: Sort headers.
2218         * f-valprint.c: Sort headers.
2219         * f-typeprint.c: Sort headers.
2220         * f-lang.c: Sort headers.
2221         * extension.h: Sort headers.
2222         * extension.c: Sort headers.
2223         * extension-priv.h: Sort headers.
2224         * expprint.c: Sort headers.
2225         * exec.h: Sort headers.
2226         * exec.c: Sort headers.
2227         * exceptions.c: Sort headers.
2228         * event-top.c: Sort headers.
2229         * event-loop.c: Sort headers.
2230         * eval.c: Sort headers.
2231         * elfread.c: Sort headers.
2232         * dwarf2read.h: Sort headers.
2233         * dwarf2read.c: Sort headers.
2234         * dwarf2loc.c: Sort headers.
2235         * dwarf2expr.h: Sort headers.
2236         * dwarf2expr.c: Sort headers.
2237         * dwarf2-frame.c: Sort headers.
2238         * dwarf2-frame-tailcall.c: Sort headers.
2239         * dwarf-index-write.h: Sort headers.
2240         * dwarf-index-write.c: Sort headers.
2241         * dwarf-index-common.c: Sort headers.
2242         * dwarf-index-cache.h: Sort headers.
2243         * dwarf-index-cache.c: Sort headers.
2244         * dummy-frame.c: Sort headers.
2245         * dtrace-probe.c: Sort headers.
2246         * disasm.h: Sort headers.
2247         * disasm.c: Sort headers.
2248         * disasm-selftests.c: Sort headers.
2249         * dictionary.c: Sort headers.
2250         * dicos-tdep.c: Sort headers.
2251         * demangle.c: Sort headers.
2252         * dcache.h: Sort headers.
2253         * dcache.c: Sort headers.
2254         * darwin-nat.h: Sort headers.
2255         * darwin-nat.c: Sort headers.
2256         * darwin-nat-info.c: Sort headers.
2257         * d-valprint.c: Sort headers.
2258         * d-namespace.c: Sort headers.
2259         * d-lang.c: Sort headers.
2260         * ctf.c: Sort headers.
2261         * csky-tdep.c: Sort headers.
2262         * csky-linux-tdep.c: Sort headers.
2263         * cris-tdep.c: Sort headers.
2264         * cris-linux-tdep.c: Sort headers.
2265         * cp-valprint.c: Sort headers.
2266         * cp-support.c: Sort headers.
2267         * cp-namespace.c: Sort headers.
2268         * cp-abi.c: Sort headers.
2269         * corelow.c: Sort headers.
2270         * corefile.c: Sort headers.
2271         * continuations.c: Sort headers.
2272         * completer.h: Sort headers.
2273         * completer.c: Sort headers.
2274         * complaints.c: Sort headers.
2275         * coffread.c: Sort headers.
2276         * coff-pe-read.c: Sort headers.
2277         * cli-out.h: Sort headers.
2278         * cli-out.c: Sort headers.
2279         * charset.c: Sort headers.
2280         * c-varobj.c: Sort headers.
2281         * c-valprint.c: Sort headers.
2282         * c-typeprint.c: Sort headers.
2283         * c-lang.c: Sort headers.
2284         * buildsym.c: Sort headers.
2285         * buildsym-legacy.c: Sort headers.
2286         * build-id.h: Sort headers.
2287         * build-id.c: Sort headers.
2288         * btrace.c: Sort headers.
2289         * bsd-uthread.c: Sort headers.
2290         * breakpoint.h: Sort headers.
2291         * breakpoint.c: Sort headers.
2292         * break-catch-throw.c: Sort headers.
2293         * break-catch-syscall.c: Sort headers.
2294         * break-catch-sig.c: Sort headers.
2295         * blockframe.c: Sort headers.
2296         * block.c: Sort headers.
2297         * bfin-tdep.c: Sort headers.
2298         * bfin-linux-tdep.c: Sort headers.
2299         * bfd-target.c: Sort headers.
2300         * bcache.c: Sort headers.
2301         * ax-general.c: Sort headers.
2302         * ax-gdb.h: Sort headers.
2303         * ax-gdb.c: Sort headers.
2304         * avr-tdep.c: Sort headers.
2305         * auxv.c: Sort headers.
2306         * auto-load.c: Sort headers.
2307         * arm-wince-tdep.c: Sort headers.
2308         * arm-tdep.c: Sort headers.
2309         * arm-symbian-tdep.c: Sort headers.
2310         * arm-pikeos-tdep.c: Sort headers.
2311         * arm-obsd-tdep.c: Sort headers.
2312         * arm-nbsd-tdep.c: Sort headers.
2313         * arm-nbsd-nat.c: Sort headers.
2314         * arm-linux-tdep.c: Sort headers.
2315         * arm-linux-nat.c: Sort headers.
2316         * arm-fbsd-tdep.c: Sort headers.
2317         * arm-fbsd-nat.c: Sort headers.
2318         * arm-bsd-tdep.c: Sort headers.
2319         * arch-utils.c: Sort headers.
2320         * arc-tdep.c: Sort headers.
2321         * arc-newlib-tdep.c: Sort headers.
2322         * annotate.h: Sort headers.
2323         * annotate.c: Sort headers.
2324         * amd64-windows-tdep.c: Sort headers.
2325         * amd64-windows-nat.c: Sort headers.
2326         * amd64-tdep.c: Sort headers.
2327         * amd64-sol2-tdep.c: Sort headers.
2328         * amd64-obsd-tdep.c: Sort headers.
2329         * amd64-obsd-nat.c: Sort headers.
2330         * amd64-nbsd-tdep.c: Sort headers.
2331         * amd64-nbsd-nat.c: Sort headers.
2332         * amd64-nat.c: Sort headers.
2333         * amd64-linux-tdep.c: Sort headers.
2334         * amd64-linux-nat.c: Sort headers.
2335         * amd64-fbsd-tdep.c: Sort headers.
2336         * amd64-fbsd-nat.c: Sort headers.
2337         * amd64-dicos-tdep.c: Sort headers.
2338         * amd64-darwin-tdep.c: Sort headers.
2339         * amd64-bsd-nat.c: Sort headers.
2340         * alpha-tdep.c: Sort headers.
2341         * alpha-obsd-tdep.c: Sort headers.
2342         * alpha-nbsd-tdep.c: Sort headers.
2343         * alpha-mdebug-tdep.c: Sort headers.
2344         * alpha-linux-tdep.c: Sort headers.
2345         * alpha-linux-nat.c: Sort headers.
2346         * alpha-bsd-tdep.c: Sort headers.
2347         * alpha-bsd-nat.c: Sort headers.
2348         * aix-thread.c: Sort headers.
2349         * agent.c: Sort headers.
2350         * addrmap.c: Sort headers.
2351         * ada-varobj.c: Sort headers.
2352         * ada-valprint.c: Sort headers.
2353         * ada-typeprint.c: Sort headers.
2354         * ada-tasks.c: Sort headers.
2355         * ada-lang.c: Sort headers.
2356         * aarch64-tdep.c: Sort headers.
2357         * aarch64-ravenscar-thread.c: Sort headers.
2358         * aarch64-newlib-tdep.c: Sort headers.
2359         * aarch64-linux-tdep.c: Sort headers.
2360         * aarch64-linux-nat.c: Sort headers.
2361         * aarch64-fbsd-tdep.c: Sort headers.
2362         * aarch64-fbsd-nat.c: Sort headers.
2363         * aarch32-linux-nat.c: Sort headers.
2364
2365 2019-04-04  Tom Tromey  <tom@tromey.com>
2366
2367         * varobj.c (varobj_create): Update.
2368         * rust-exp.y (struct rust_parser) <update_innermost_block,
2369         lookup_symbol>: New methods.
2370         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2371         Rename.
2372         (rust_parser::rust_lookup_type)
2373         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2374         * printcmd.c (display_command, do_one_display): Update.
2375         * parser-defs.h (struct parser_state) <parser_state>: Add
2376         "tracker" parameter.
2377         (block_tracker): New member.
2378         (class innermost_block_tracker) <innermost_block_tracker>: Add
2379         "types" parameter.
2380         <reset>: Remove method.
2381         (innermost_block): Don't declare.
2382         (null_post_parser): Update.
2383         * parse.c (innermost_block): Remove global.
2384         (write_dollar_variable): Update.
2385         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2386         Remove "tracker_types" parameter.
2387         (parse_expression): Add "tracker" parameter.
2388         (parse_expression_for_completion): Update.
2389         (null_post_parser): Add "tracker" parameter.
2390         * p-exp.y: Update rules.
2391         * m2-exp.y: Update rules.
2392         * language.h (struct language_defn) <la_post_parser>: Add
2393         "tracker" parameter.
2394         * go-exp.y: Update rules.
2395         * f-exp.y: Update rules.
2396         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2397         parameter.
2398         * d-exp.y: Update rules.
2399         * c-exp.y: Update rules.
2400         * breakpoint.c (set_breakpoint_condition): Create an
2401         innermost_block_tracker.
2402         (watch_command_1): Likewise.
2403         * ada-lang.c (resolve): Add "tracker" parameter.
2404         (resolve_subexp): Likewise.
2405         * ada-exp.y (write_var_from_sym): Update.
2406
2407 2019-04-04  Tom Tromey  <tom@tromey.com>
2408
2409         * type-stack.h: New file.
2410         * type-stack.c: New file.
2411         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2412         type-stack.h.
2413         (insert_into_type_stack, insert_type, push_type, push_type_int)
2414         (insert_type_address_space, pop_type, pop_type_int)
2415         (pop_typelist, pop_type_stack, append_type_stack)
2416         (push_type_stack, get_type_stack, push_typelist)
2417         (follow_type_instance_flags, follow_types): Don't declare.
2418         * parse.c (type_stack): Remove global.
2419         (parse_exp_in_context): Update.
2420         (insert_into_type_stack, insert_type, push_type, push_type_int)
2421         (insert_type_address_space, pop_type, pop_type_int)
2422         (pop_typelist, pop_type_stack, append_type_stack)
2423         (push_type_stack, get_type_stack, push_typelist)
2424         (follow_type_instance_flags, follow_types): Remove (moved to
2425         type-stack.c).
2426         * f-exp.y (type_stack): New global.
2427         Update rules.
2428         (push_kind_type, f_parse): Update.
2429         * d-exp.y (type_stack): New global.
2430         Update rules.
2431         (d_parse): Update.
2432         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2433         Update rules.
2434         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2435         (HFILES_NO_SRCDIR): Add type-stack.h.
2436
2437 2019-04-04  Tom Tromey  <tom@tromey.com>
2438
2439         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2440         (rust_parser::convert_ast_to_expression, rust_parse)
2441         (rust_lex_test_completion, rust_lex_tests): Update.
2442         * parser-defs.h (struct expr_completion_state): New.
2443         (struct parser_state) <parser_state>: Add completion parameter.
2444         <mark_struct_expression, mark_completion_tag>: New methods.
2445         <parse_completion, m_completion_state>: New members.
2446         (prefixify_expression, null_post_parser): Update.
2447         (mark_struct_expression, mark_completion_tag): Don't declare.
2448         * parse.c (parse_completion, expout_last_struct)
2449         (expout_tag_completion_type, expout_completion_name): Remove
2450         globals.
2451         (parser_state::mark_struct_expression)
2452         (parser_state::mark_completion_tag): Now methods.
2453         (prefixify_expression): Add last_struct parameter.
2454         (prefixify_subexp): Likewise.
2455         (parse_exp_1): Update.
2456         (parse_exp_in_context): Add cstate parameter.  Update.
2457         (parse_expression_for_completion): Create an
2458         expr_completion_state.
2459         (null_post_parser): Add "completion" parameter.
2460         * p-exp.y: Update rules.
2461         (yylex): Update.
2462         * language.h (struct language_defn) <la_post_parser>: Add
2463         "completing" parameter.
2464         * go-exp.y: Update rules.
2465         (lex_one_token): Update.
2466         * expression.h (parse_completion): Don't declare.
2467         * d-exp.y: Update rules.
2468         (lex_one_token): Update rules.
2469         * c-exp.y: Update rules.
2470         (lex_one_token): Update.
2471         * ada-lang.c (resolve): Add "parse_completion" parameter.
2472         (resolve_subexp): Likewise.
2473         (ada_resolve_function): Likewise.
2474
2475 2019-04-04  Tom Tromey  <tom@tromey.com>
2476
2477         * parser-defs.h (struct parser_state) <start_arglist,
2478         end_arglist>: New methods.
2479         <arglist_len, m_funcall_chain>: New members.
2480         (arglist_len, start_arglist, end_arglist): Don't declare.
2481         * parse.c (arglist_len, funcall_chain): Remove global.
2482         (start_arglist, end_arglist): Remove functions.
2483         (parse_exp_in_context): Update.
2484         * p-exp.y: Update rules.
2485         * m2-exp.y: Update rules.
2486         * go-exp.y: Update rules.
2487         * f-exp.y: Update rules.
2488         * d-exp.y: Update rules.
2489         * c-exp.y: Update rules.
2490
2491 2019-04-04  Tom Tromey  <tom@tromey.com>
2492
2493         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2494         lex_operator, push_back>: New methods.
2495         Update all rules.
2496         (rust_parser::lex_hex, lex_escape): Rename and update.
2497         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2498         (rust_parser::lex_operator): Rename and update.
2499         (rust_parser::lex_number, rustyylex, rustyyerror)
2500         (rust_lex_test_init, rust_lex_test_sequence)
2501         (rust_lex_test_push_back, rust_lex_tests): Update.
2502         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2503         parameter.
2504         <lexptr, prev_lexptr>: New members.
2505         (lexptr, prev_lexptr): Don't declare.
2506         * parse.c (lexptr, prev_lexptr): Remove globals.
2507         (parse_exp_in_context): Update.
2508         * p-exp.y (yylex, yyerror): Update.
2509         * m2-exp.y (parse_number, yylex, yyerror): Update.
2510         * go-exp.y (lex_one_token, yyerror): Update.
2511         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2512         * d-exp.y (lex_one_token, yyerror): Update.
2513         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2514         (lex_one_token, yyerror): Update.
2515         * ada-lex.l (YY_INPUT): Update.
2516         (rewind_to_char): Update.
2517         * ada-exp.y (yyerror): Update.
2518
2519 2019-04-04  Tom Tromey  <tom@tromey.com>
2520
2521         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2522         * parser-defs.h (struct parser_state) <parser_state>: Add new
2523         parameter.
2524         <comma_terminates>: New member.
2525         (comma_terminates): Don't declare global.
2526         * parse.c (comma_terminates): Remove global.
2527         (parse_exp_in_context): Update.
2528         * p-exp.y (yylex): Update.
2529         * m2-exp.y (yylex): Update.
2530         * go-exp.y (lex_one_token): Update.
2531         * f-exp.y (yylex): Update.
2532         * d-exp.y (lex_one_token): Update.
2533         * c-exp.y (lex_one_token): Update.
2534         * ada-lex.l: Update.
2535
2536 2019-04-04  Tom Tromey  <tom@tromey.com>
2537
2538         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2539         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2540         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2541         * parser-defs.h (paren_depth): Don't declare.
2542         * parse.c (paren_depth): Remove global.
2543         (parse_exp_in_context): Update.
2544         * p-exp.y (paren_depth): New global.
2545         (pascal_parse): Initialize it.
2546         * m2-exp.y (paren_depth): New global.
2547         (m2_parse): Initialize it.
2548         * go-exp.y (paren_depth): New global.
2549         (go_parse): Initialize it.
2550         * f-exp.y (paren_depth): New global.
2551         (f_parse): Initialize it.
2552         * d-exp.y (paren_depth): New global.
2553         (d_parse): Initialize it.
2554         * c-exp.y (paren_depth): New global.
2555         (c_parse): Initialize it.
2556         * ada-lex.l (paren_depth): New global.
2557         (lexer_init): Initialize it.
2558
2559 2019-04-04  Tom Tromey  <tom@tromey.com>
2560
2561         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2562         (rust_parser::convert_ast_to_type)
2563         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2564         * parser-defs.h (struct parser_state) <parser_state>: Add
2565         parameters.  Initialize new members.
2566         <expression_context_block, expression_context_pc>: New members.
2567         * parse.c (expression_context_block, expression_context_pc):
2568         Remove globals.
2569         (parse_exp_in_context): Update.
2570         * p-exp.y: Update all rules.
2571         (yylex): Update.
2572         * m2-exp.y: Update all rules.
2573         (yylex): Update.
2574         * go-exp.y (yylex): Update.
2575         * f-exp.y (yylex): Update.
2576         * d-exp.y: Update all rules.
2577         (yylex): Update.
2578         * c-exp.y: Update all rules.
2579         (lex_one_token, classify_name, yylex, c_parse): Update.
2580         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2581
2582 2019-04-04  Tom Tromey  <tom@tromey.com>
2583
2584         * gdbarch.h, gdbarch.c: Rebuild.
2585         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2586         * stap-probe.h:
2587         (struct stap_parse_info): Replace "parser_state" with
2588         "expr_builder".
2589         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2590         (parser_state): New class.
2591         * parse.c (expr_builder): Rename.
2592         (expr_builder::release): Rename.
2593         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2594         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2595         (write_exp_elt_longcst, write_exp_elt_floatcst)
2596         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2597         (write_exp_string_vector, write_exp_bitstring)
2598         (write_exp_msymbol, mark_struct_expression)
2599         (write_dollar_variable)
2600         (insert_type_address_space, increase_expout_size): Replace
2601         "parser_state" with "expr_builder".
2602         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2603         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2604         "parser_state" with "expr_builder".
2605
2606 2019-04-04  Tom Tromey  <tom@tromey.com>
2607
2608         * rust-exp.y: Replace "parse_language" with method call.
2609         * p-exp.y:
2610         (yylex): Replace "parse_language" with method call.
2611         * m2-exp.y:
2612         (yylex): Replace "parse_language" with method call.
2613         * go-exp.y (classify_name): Replace "parse_language" with method
2614         call.
2615         * f-exp.y (yylex): Replace "parse_language" with method call.
2616         * d-exp.y (lex_one_token): Replace "parse_language" with method
2617         call.
2618         * c-exp.y:
2619         (lex_one_token, classify_name, yylex): Replace "parse_language"
2620         with method call.
2621         * ada-exp.y (find_primitive_type, type_char)
2622         (type_system_address): Replace "parse_language" with method call.
2623
2624 2019-04-04  Tom Tromey  <tom@tromey.com>
2625
2626         * rust-exp.y: Replace "parse_gdbarch" with method call.
2627         * parse.c (write_dollar_variable, insert_type_address_space):
2628         Replace "parse_gdbarch" with method call.
2629         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2630         call.
2631         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2632         call.
2633         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2634         "parse_gdbarch" with method call.
2635         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2636         with method call.
2637         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2638         "parse_gdbarch" with method call.
2639         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2640         "parse_gdbarch" with method call.
2641         * c-exp.y (parse_type, parse_number, classify_name): Replace
2642         "parse_gdbarch" with method call.
2643         * ada-lex.l: Replace "parse_gdbarch" with method call.
2644         * ada-exp.y (parse_type, find_primitive_type, type_char)
2645         (type_system_address): Replace "parse_gdbarch" with method call.
2646
2647 2019-04-04  Tom Tromey  <tom@tromey.com>
2648
2649         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2650         * stap-probe.c (stap_parse_argument): Update.
2651         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2652         initial_size parameter.
2653         * rust-exp.y (rust_lex_tests): Update.
2654         * parse.c (parser_state): Update.
2655         (parse_exp_in_context): Update.
2656         * parser-defs.h (struct parser_state) <parser_state>: Remove
2657         "initial_size" parameter.
2658
2659 2019-04-04  Tom Tromey  <tom@tromey.com>
2660
2661         * parser-defs.h (increase_expout_size): Don't declare.
2662         * parse.c (increase_expout_size): Now static.
2663
2664 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2665
2666         * gnu-nat.c (gnu_nat_target::wait): Fix
2667         target_waitstatus_to_string call.
2668
2669 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2670
2671         * eval.c (evaluate_subexp_standard): Handle internal functions
2672         during Fortran function call handling.
2673
2674 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * NEWS: Mention new internal functions.
2677         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2678         (read_base_type): Use dwarf2_init_complex_target_type.
2679         * value.c (creal_internal_fn): New function.
2680         (cimag_internal_fn): New function.
2681         (_initialize_values): Register new internal functions.
2682
2683 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2684
2685         * infrun.c (stop_all_threads): If debug_infrun, always
2686         trace the wait status after wait_one, using
2687         target_waitstatus_to_string and target_pid_to_str.
2688         (handle_inferior_event): Replace various trace of
2689         wait status kind by a single trace.
2690         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2691         wait status kind image by target_waitstatus_to_string.
2692         * target/waitstatus.c (target_waitstatus_to_string): Fix
2693         obsolete comment.
2694
2695 2019-04-01  Tom Tromey  <tromey@adacore.com>
2696
2697         PR symtab/23331:
2698         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2699
2700 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2701             Pedro Alves  <palves@redhat.com>
2702
2703         * top.c (quit_force): Call 'finalize_values'.
2704         * value.c (finalize_values): New function.
2705         * value.h (finalize_values): Declare.
2706
2707 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2708
2709         * NEWS: Announce $_gdb_major and $_gdb_minor.
2710
2711         * top.c (init_gdb_version_vars): New function.
2712         (gdb_init): Call init_gdb_version_vars.
2713
2714 2019-03-29  Tom Tromey  <tromey@adacore.com>
2715
2716         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2717         help text.  Remove dead code.
2718
2719 2019-03-29  Keith Seitz  <keiths@redhat.com>
2720
2721         From Siddhesh Poyarekar:
2722         * f-lang.h (f77_get_upperbound): Return LONGEST.
2723         (f77_get_lowerbound): Likewise.
2724         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2725         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2726         print them.
2727         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2728         plongest to format print it.
2729         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2730         (f77_get_upperbound): Likewise.
2731         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2732         LOWER_BOUND to LONGEST.
2733         (f77_create_arrayprint_offset_tbl): Likewise.
2734
2735 2019-03-29  Keith Seitz  <keiths@redhat.com>
2736
2737         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2738         %s/pulongest for TYPE_LENGTH instead of %d in format
2739         strings.
2740         * ada-typerint.c (ada_print_type): Likewise.
2741         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2742         * compile/compile-c-support.c (generate_register_struct): Likewise.
2743         * gdbtypes.c (recursive_dump_type): Likewise.
2744         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2745         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2746         instead of %d in format strings.
2747         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2748         to std::min to ULONGEST.
2749         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2750         instead of %d in format strings.
2751         * tracepoint.c (info_scope_command): Likewise.
2752         * typeprint.c (print_offset_data::update)
2753         (print_offset_data::finish): Likewise.
2754         * xtensa-tdep.c (xtensa_store_return_value)
2755         (xtensa_push_dummy_call): Likewise.
2756
2757 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2758
2759         * windows-nat.c (display_selector): Fixed format specifications
2760         for 64-bit Cygwin.
2761
2762 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2763
2764         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2765
2766 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2767
2768         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2769         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2770         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2771         (nios2_linux_init_abi): Install it.
2772
2773 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2774
2775         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2776
2777 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2778
2779         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2780
2781 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2782             Tom Tromey  <tromey@adacore.com>
2783
2784         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2785
2786 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2787
2788         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2789         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2790         method to compute the bounds of range types. Also print "[evaluated]"
2791         if the bounds' values come from a dynamic evaluation.
2792
2793 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2794
2795         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2796         whitespace when pretty printing is on.
2797
2798 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2799
2800         * ppc-linux-nat.c: Add include.
2801
2802 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2803
2804         * NEWS: Mention AArch64 Pointer Authentication.
2805
2806 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2807
2808         * arm-linux-nat.c: Add include.
2809
2810 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2811
2812         * source-cache.c (source_cache::get_source_lines): Re-read
2813         fullname after calling open_source_file.
2814
2815 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2816
2817         * NEWS: Mention TLS support for FreeBSD.
2818
2819 2019-03-25  Tom Tromey  <tromey@adacore.com>
2820
2821         * minsyms.c (BUNCH_SIZE): Update comment.
2822         (~minimal_symbol_reader): Remove old comment.
2823         (compact_minimal_symbols): Update comment.
2824         (minimal_symbol_reader::install): Remove old comment.  Update
2825         other comments.
2826
2827 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2828
2829         * s390-linux-nat.c: Add include.
2830
2831 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2832
2833         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2834         Call linux_get_hwcap.
2835         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2836         Likewise.
2837         (aarch64_linux_get_hwcap): Remove function.
2838         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2839         declaration.
2840         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2841         linux_get_hwcap.
2842         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2843         * linux-tdep.c (linux_get_hwcap): Add function.
2844         (linux_get_hwcap2): Likewise.
2845         * linux-tdep.h (linux_get_hwcap): Add declaration.
2846         (linux_get_hwcap2): Likewise.
2847         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2848         (ppc_linux_get_hwcap2): Likewise.
2849         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2850         linux_get_hwcap.
2851         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2852         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2853         (ppc_linux_nat_target::read_description): Likewise.
2854         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2855         * s390-linux-nat.c: Likewise.
2856         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2857
2858 2019-03-24  Tom Tromey  <tom@tromey.com>
2859
2860         * ada-lang.c (standard_lookup): Simplify initialization.
2861         (ada_lookup_symbol_nonlocal): Simplify return.
2862         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2863         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2864         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2865         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2866         initialization.
2867         * solib.c (solib_global_lookup): Simplify.
2868         * symtab.c (null_block_symbol): Remove.
2869         (symbol_cache_lookup): Simplify returns.
2870         (lookup_language_this): Simplify returns.
2871         (lookup_symbol_aux): Simplify return.
2872         (lookup_local_symbol): Simplify returns.
2873         (lookup_global_symbol_from_objfile): Simplify return.
2874         (lookup_symbol_in_objfile_symtabs)
2875         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2876         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2877         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2878         * cp-namespace.c (cp_lookup_bare_symbol)
2879         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2880         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2881         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2882         (cp_lookup_symbol_via_imports): Simplify initialization.
2883         (find_symbol_in_baseclass): Likewise.
2884         * symtab.h (null_block_symbol): Remove.
2885         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2886         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2887         (d_lookup_symbol_module): Likewise.
2888         (find_symbol_in_baseclass): Simplify initialization.
2889
2890 2019-03-24  Tom Tromey  <tom@tromey.com>
2891
2892         * expression.h: Don't include symtab.h.
2893         (struct block): Forward declare.
2894
2895 2019-03-24  Tom Tromey  <tom@tromey.com>
2896
2897         * c-exp.y (typebase): Remove casts.
2898         * gdbtypes.c (lookup_unsigned_typename, )
2899         (lookup_signed_typename): Remove cast.
2900         * eval.c (parse_to_comma_and_eval): Remove cast.
2901         * parse.c (write_dollar_variable): Remove cast.
2902         * block.h (struct block) <superblock>: Now const.
2903         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2904         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2905         (map_block): Make "block" const.
2906         * symfile.h (struct quick_symbol_functions)
2907         <map_matching_symbols>: Constify block argument to "callback".
2908         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2909         const.
2910         (find_pc_sect_compunit_symtab): Make "b" const.
2911         (find_symbol_at_address): Likewise.
2912         (search_symbols): Likewise.
2913         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2914         (dw2_debug_names_lookup_symbol): Likewise.
2915         (dw2_map_matching_symbols): Update.
2916         * p-valprint.c (pascal_val_print): Remove "block".
2917         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2918         (aux_add_nonlocal_symbols): Make "block" const.
2919         (resolve_subexp): Remove cast.
2920         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2921         const.
2922         (iterate_over_file_blocks): Likewise.
2923         * f-exp.y (%union) <bval>: Remove.
2924         * coffread.c (patch_opaque_types): Make "b" const.
2925         * spu-tdep.c (spu_catch_start): Make "block" const.
2926         * c-valprint.c (print_unpacked_pointer): Remove "block".
2927         * symmisc.c (dump_symtab_1): Make "b" const.
2928         (block_depth): Make "block" const.
2929         * d-exp.y (%union) <bval>: Remove.
2930         * cp-support.h (cp_lookup_rtti_type): Update.
2931         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2932         * psymtab.c (psym_lookup_symbol): Make "block" const.
2933         (maintenance_check_psymtabs): Make "b" const.
2934         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2935         (enumerate_locals, enumerate_args): Update.
2936         * python/py-symtab.c (stpy_global_block): Make "block" const.
2937         (stpy_static_block): Likewise.
2938         * inline-frame.c (block_starting_point_at): Make "new_block"
2939         const.
2940         * block.c (find_block_in_blockvector): Make return type const.
2941         (blockvector_for_pc_sect): Make "b" const.
2942         (find_block_in_blockvector): Make "b" const.
2943
2944 2019-03-23  Tom Tromey  <tom@tromey.com>
2945
2946         * varobj.c (varobj_create): Update.
2947         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2948         * printcmd.c (display_command, do_one_display): Don't reset
2949         innermost_block.
2950         * parser-defs.h (enum innermost_block_tracker_type): Move to
2951         expression.h.
2952         (innermost_block): Update comment.
2953         * parse.c (parse_exp_1): Add tracker_types parameter.
2954         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2955         tracker_types parameter.  Reset innermost_block.
2956         (parse_exp_in_context): Remove.
2957         (parse_expression_for_completion): Update.
2958         * objfiles.c (~objfile): Don't reset expression_context_block or
2959         innermost_block.
2960         * expression.h (enum innermost_block_tracker_type): Move from
2961         parser-defs.h.
2962         (parse_exp_1): Add tracker_types parameter.
2963         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2964         reset innermost_block.
2965
2966 2019-03-23  Tom Tromey  <tom@tromey.com>
2967
2968         * objfiles.h: Include bcache.h.
2969
2970 2019-03-23  Tom Tromey  <tom@tromey.com>
2971
2972         * linespec.c (get_current_search_block): Use
2973         scoped_restore_current_language.
2974         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2975
2976 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2977             Jiong Wang  <jiong.wang@arm.com>
2978
2979         * aarch64-linux-tdep.c
2980         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2981         section.
2982         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2983
2984 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2985             Jiong Wang  <jiong.wang@arm.com>
2986
2987         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2988         instructions.
2989         (aarch64_analyze_prologue_test): Add PACIASP test.
2990         (aarch64_prologue_prev_register): Unmask PC value.
2991
2992 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2993             Jiong Wang  <jiong.wang@arm.com>
2994
2995         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2996         (aarch64_dwarf2_prev_register): Unmask PC value.
2997         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2998         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2999         DW_CFA_AARCH64_negate_ra_state.
3000         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3001
3002 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3003             Jiong Wang  <jiong.wang@arm.com>
3004
3005         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3006         registers.
3007         (aarch64_pseudo_register_name): Likewise.
3008         (aarch64_pseudo_register_type): Likewise.
3009         (aarch64_pseudo_register_reggroup_p): Likewise.
3010         (aarch64_gdbarch_init): Add pauth registers.
3011         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3012         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3013         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3014         (struct gdbarch_tdep): Add regnum for ra_state.
3015
3016 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3017             Jiong Wang  <jiong.wang@arm.com>
3018
3019         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3020
3021 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3022             Jiong Wang  <jiong.wang@arm.com>
3023
3024         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3025         function.
3026         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3027         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3028         (aarch64_gdbarch_init): Add puth registers.
3029         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3030         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3031         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3032
3033 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3034             Jiong Wang  <jiong.wang@arm.com>
3035
3036         * aarch64-linux-nat.c
3037         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3038         * aarch64-linux-tdep.c
3039         (aarch64_linux_core_read_description): Likewise.
3040         (aarch64_linux_get_hwcap): New function.
3041         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3042         (aarch64_linux_get_hwcap): New declaration.
3043
3044 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3045             Jiong Wang  <jiong.wang@arm.com>
3046
3047         * aarch64-linux-nat.c
3048         (aarch64_linux_nat_target::read_description): Add pauth param.
3049         * aarch64-linux-tdep.c
3050         (aarch64_linux_core_read_description): Likewise.
3051         * aarch64-tdep.c (struct target_desc): Add in pauth.
3052         (aarch64_read_description): Add pauth param.
3053         (aarch64_gdbarch_init): Likewise.
3054         * aarch64-tdep.h (aarch64_read_description): Likewise.
3055         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3056         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3057         * features/Makefile: Add new files.
3058         * features/aarch64-pauth.c: New file.
3059         * features/aarch64-pauth.xml: New file.
3060
3061 2019-03-20  Tom Tromey  <tromey@adacore.com>
3062
3063         * infrun.c (handle_inferior_event): Rename from
3064         handle_inferior_event_1.  Create a scoped_value_mark.
3065         (handle_inferior_event): Remove.
3066
3067 2019-03-19  Tom Tromey  <tromey@adacore.com>
3068
3069         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3070         * infrun.h (print_stop_event): Add "displays" parameter.
3071         * infrun.c (print_stop_event): Add "displays" parameter.
3072
3073 2019-03-19  Pedro Alves  <palves@redhat.com>
3074
3075         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3076         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3077         to -1.  Fix TABs vs spaces.
3078         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3079         * tui/tui-out.h (tui_ui_out) Add intro comments.
3080         <m_line, m_start_of_line>: In-class initialize, and add describing
3081         comment.
3082
3083 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3084
3085         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3086         variable names.
3087         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3088
3089 2019-03-18  Pedro Alves  <palves@redhat.com>
3090             Eli Zaretskii <eliz@gnu.org>
3091
3092         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3093         m_line and m_start_of_line.
3094
3095 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3096
3097         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3098         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3099         it returns a newline.  This fixes a regression in TU mode, whereby
3100         the next line is output on the same screen line as the user input.
3101
3102 2019-03-18  Tom Tromey  <tromey@adacore.com>
3103
3104         * minsyms.c (minimal_symbol_reader::install): Remove call to
3105         obstack_blank.
3106
3107 2019-03-18  Pedro Alves  <palves@redhat.com>
3108
3109         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3110         New globals.
3111         (apply_style): New, factored out from ...
3112         (apply_ansi_escape): ... this.  Handle reverse video mode.
3113         (tui_set_reverse_mode): New function.
3114         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3115         * tui/tui-winsource.c (tui_show_source_line): Use
3116         tui_set_reverse_mode instead of setting A_STANDOUT.
3117         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3118         New setter methods.
3119
3120 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3121
3122         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3123         Handle tabs.
3124
3125 2019-03-18  Tom Tromey  <tromey@adacore.com>
3126
3127         * ada-lang.c (empty_array): Add "high" parameter.
3128         (ada_evaluate_subexp): Update.
3129
3130 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3131
3132         * unittests/string_view-selftests.c: Define
3133         _initialize_string_view_selftests unconditionally.
3134
3135 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3136
3137         PR gdb/24350
3138         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3139
3140 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3141
3142         PR gdb/24351
3143         * windows-nat.c (display_selector): Fix format specifiers.
3144
3145 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3146
3147         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3148         tui_refill_source_window instead of tui_refresh_win, to update the
3149         current execution line.  This fixes redisplay of the current line
3150         when stepping through the code with "next" or "step".
3151
3152 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3153
3154         * source-cache.c (source_cache::get_source_lines): Call
3155         find_source_lines to initialize s->nlines.  This fixes vertical
3156         scrolling of TUI source window when the DOWN arrow is pressed.
3157
3158 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3159
3160         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3161         linux-thread-db.c (_initialize_thread_db): Likewise.
3162
3163 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3164
3165         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3166         wclrtoeol in tui_show_source_line".  This reverts changes made in
3167         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3168
3169 2019-03-15  Tom Tromey  <tom@tromey.com>
3170
3171         * symtab.h (struct minimal_symbol): Derive from
3172         general_symbol_info.
3173         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3174         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3175         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3176         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3177         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3178         (MSYMBOL_SEARCH_NAME): Update.
3179         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3180         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3181         * minsyms.c (minimal_symbol_reader::record_full): Update.
3182
3183 2019-03-15  Tom Tromey  <tom@tromey.com>
3184
3185         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3186
3187 2019-03-15  Tom Tromey  <tom@tromey.com>
3188
3189         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3190         unique_xmalloc_ptr.
3191         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3192         Update.
3193         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3194         (build_minimal_symbol_hash_tables)
3195         (minimal_symbol_reader::install): Update.
3196
3197 2019-03-15  Tom Tromey  <tom@tromey.com>
3198
3199         * symtab.c (create_demangled_names_hash): Update.
3200         (symbol_set_names): Update.
3201         * objfiles.h (struct objfile_per_bfd_storage)
3202         <demangled_names_hash>: Now an htab_up.
3203         * objfiles.c (objfile_per_bfd_storage): Simplify.
3204
3205 2019-03-15  Tom Tromey  <tom@tromey.com>
3206
3207         * objfiles.h (struct objfile_per_bfd_storage): Declare
3208         destructor.
3209         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3210         New.
3211         (get_objfile_bfd_data): Use new.  Don't initialize
3212         language_of_main.
3213         (free_objfile_per_bfd_storage): Remove.
3214         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3215
3216 2019-03-15  Tom Tromey  <tom@tromey.com>
3217
3218         * symfile.c (reread_symbols): Update.
3219         * objfiles.c (objfile::objfile): Update.
3220         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3221         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3222         comment.
3223         (minimal_symbol_reader::install): Update.
3224         (terminate_minimal_symbol_table): Remove.
3225         * jit.c (jit_object_close_impl): Update.
3226
3227 2019-03-15  Tom Tromey  <tom@tromey.com>
3228
3229         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3230         initializations.
3231
3232 2019-03-15  Tom Tromey  <tom@tromey.com>
3233
3234         * objfiles.h (struct objfile_per_bfd_storage)
3235         <demangled_hash_languages>: Now a bitset.
3236         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3237         (lookup_minimal_symbol): Update.
3238
3239 2019-03-15  Tom Tromey  <tom@tromey.com>
3240
3241         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3242         Don't return the symbol.
3243         * coffread.c (record_minimal_symbol): Use record_full.
3244
3245 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3246
3247         The MS-Windows port of ncurses fails to switch to a color pair if
3248         one or both of the colors are the implicit default colors.  This
3249         change records the default colors when TUI is initialized, and
3250         then specifies them explicitly when a color pair uses the default
3251         colors.  This allows color styling in TUI mode on MS-Windows.
3252
3253         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3254         ncurses_norm_attr.
3255         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3256         colors in ncurses_norm_attr.
3257         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3258         "none", replace it with the default color recorded in
3259         ncurses_norm_attr.
3260
3261 2019-03-14  Tom Tromey  <tromey@adacore.com>
3262
3263         * source-cache.h (class source_cache) <get_source_lines>: Return
3264         std::string.
3265         * source-cache.c (source_cache::extract_lines): Handle case where
3266         first_pos==npos.  Return std::string.
3267         (source_cache::get_source_lines): Update.
3268
3269 2019-03-14  Tom Tromey  <tromey@adacore.com>
3270
3271         * NEWS: Add item for "style sources" commands.
3272         * source-cache.c (source_cache::get_source_lines): Check
3273         source_styling.
3274         * cli/cli-style.c (source_styling): New global.
3275         (_initialize_cli_style): Add "style sources" commands.
3276         (show_style_sources): New function.
3277         * cli/cli-style.h (source_styling): Declare.
3278
3279 2019-03-14  Pedro Alves  <palves@redhat.com>
3280             Tom Tromey  <tromey@adacore.com>
3281
3282         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3283         * tui/tui-winsource.c (tui_refill_source_window): New function,
3284         from...
3285         (tui_horizontal_source_scroll): ... here.  Move some logic.
3286         * cli/cli-style.c (set_style_enabled): Notify new observable.
3287         * tui/tui-hooks.c (tui_redisplay_source): New function.
3288         (tui_attach_detach_observers): Attach or detach
3289         tui_redisplay_source.
3290         * observable.h (source_styling_changed): New observable.
3291         * observable.c: Define source_styling_changed observable.
3292
3293 2019-03-13  Tom Tromey  <tromey@adacore.com>
3294
3295         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3296         (i386_gnu_nat_target::store_registers): Update.
3297         * target-debug.h (target_debug_print_std_string): New macro.
3298         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3299         * windows-tdep.c (display_one_tib): Update.
3300         * tui/tui-stack.c (tui_make_status_line): Update.
3301         * top.c (print_inferior_quit_action): Update.
3302         * thread.c (thr_try_catch_cmd): Update.
3303         (add_thread_with_info): Update.
3304         (thread_target_id_str): Update.
3305         (thr_try_catch_cmd): Update.
3306         (thread_command): Update.
3307         (thread_find_command): Update.
3308         * record-btrace.c (record_btrace_target::info_record)
3309         (record_btrace_resume_thread, record_btrace_target::resume)
3310         (record_btrace_cancel_resume, record_btrace_step_thread)
3311         (record_btrace_target::wait, record_btrace_target::wait)
3312         (record_btrace_target::wait, record_btrace_target::stop): Update.
3313         * progspace.c (print_program_space): Update.
3314         * process-stratum-target.c
3315         (process_stratum_target::thread_address_space): Update.
3316         * linux-fork.c (linux_fork_mourn_inferior)
3317         (detach_checkpoint_command, info_checkpoints_command)
3318         (linux_fork_context): Update.
3319         (linux_fork_detach): Update.
3320         (class scoped_switch_fork_info): Update.
3321         (delete_checkpoint_command): Update.
3322         * infrun.c (follow_fork_inferior): Update.
3323         (follow_fork_inferior): Update.
3324         (proceed_after_vfork_done): Update.
3325         (handle_vfork_child_exec_or_exit): Update.
3326         (follow_exec): Update.
3327         (displaced_step_prepare_throw): Update.
3328         (displaced_step_restore): Update.
3329         (start_step_over): Update.
3330         (resume_1): Update.
3331         (clear_proceed_status_thread): Update.
3332         (proceed): Update.
3333         (print_target_wait_results): Update.
3334         (do_target_wait): Update.
3335         (context_switch): Update.
3336         (stop_all_threads): Update.
3337         (restart_threads): Update.
3338         (finish_step_over): Update.
3339         (handle_signal_stop): Update.
3340         (switch_back_to_stepped_thread): Update.
3341         (keep_going_pass_signal): Update.
3342         (print_exited_reason): Update.
3343         (normal_stop): Update.
3344         * inferior.c (inferior_pid_to_str): Change return type.
3345         (print_selected_inferior): Update.
3346         (add_inferior): Update.
3347         (detach_inferior): Update.
3348         * dummy-frame.c (fprint_dummy_frames): Update.
3349         * dcache.c (dcache_info_1): Update.
3350         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3351         (btrace_fetch, btrace_clear): Update.
3352         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3353         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3354         type.
3355         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3356         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3357         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3358         * gdbarch.c, gdbarch.h: Rebuild.
3359         * gdbarch.sh (core_pid_to_str): Change return type.
3360         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3361         return type.
3362         (windows_nat_target::pid_to_str): Change return type.
3363         (windows_delete_thread): Update.
3364         (windows_nat_target::attach): Update.
3365         (windows_nat_target::files_info): Update.
3366         * target-delegates.c: Rebuild.
3367         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3368         return type.
3369         (sol_thread_target::pid_to_str): Change return type.
3370         * remote.c (class remote_target) <pid_to_str>: Change return
3371         type.
3372         (remote_target::pid_to_str): Change return type.
3373         (extended_remote_target::attach, remote_target::remote_stop_ns)
3374         (remote_target::remote_notif_remove_queued_reply)
3375         (remote_target::push_stop_reply, remote_target::disable_btrace):
3376         Update.
3377         (extended_remote_target::attach): Update.
3378         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3379         type.
3380         (gdbsim_target::pid_to_str): Change return type.
3381         * ravenscar-thread.c (struct ravenscar_thread_target)
3382         <pid_to_str>: Change return type.
3383         (ravenscar_thread_target::pid_to_str): Change return type.
3384         * procfs.c (class procfs_target) <pid_to_str>: Change return
3385         type.
3386         (procfs_target::pid_to_str): Change return type.
3387         (procfs_target::attach): Update.
3388         (procfs_target::detach): Update.
3389         (procfs_target::fetch_registers): Update.
3390         (procfs_target::store_registers): Update.
3391         (procfs_target::wait): Update.
3392         (procfs_target::files_info): Update.
3393         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3394         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3395         return type.
3396         (nto_procfs_target::pid_to_str): Change return type.
3397         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3398         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3399         return type.
3400         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3401         (exit_lwp): Update.
3402         (attach_proc_task_lwp_callback, get_detach_signal)
3403         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3404         (linux_nat_target::resume, wait_lwp, stop_callback)
3405         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3406         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3407         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3408         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3409         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3410         type.
3411         (inf_ptrace_target::attach): Update.
3412         (inf_ptrace_target::files_info): Update.
3413         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3414         type.
3415         (go32_nat_target::pid_to_str): Change return type.
3416         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3417         (gnu_nat_target::wait): Update.
3418         (gnu_nat_target::wait): Update.
3419         (gnu_nat_target::resume): Update.
3420         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3421         (fbsd_nat_target::wait): Update.
3422         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3423         type.
3424         (darwin_nat_target::attach): Update.
3425         * corelow.c (class core_target) <pid_to_str>: Change return type.
3426         (core_target::pid_to_str): Change return type.
3427         * target.c (normal_pid_to_str): Change return type.
3428         (default_pid_to_str): Likewise.
3429         (target_pid_to_str): Change return type.
3430         (target_translate_tls_address): Update.
3431         (target_announce_detach): Update.
3432         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3433         return type.
3434         (bsd_uthread_target::pid_to_str): Change return type.
3435         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3436         type.
3437         (bsd_kvm_target::pid_to_str): Change return type.
3438         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3439         return type.
3440         (aix_thread_target::pid_to_str): Change return type.
3441         * target.h (struct target_ops) <pid_to_str>: Change return type.
3442         (target_pid_to_str, normal_pid_to_str): Likewise.
3443         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3444         type.
3445         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3446         type.
3447         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3448         return type.
3449         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3450         type.
3451         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3452         type.
3453         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3454         return type.
3455
3456 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3457
3458         * NEWS: Mention that the new default MI version is 3.  Mention
3459         changes to the output of commands and events that deal with
3460         multi-location breakpoints.
3461         * breakpoint.c: Include "mi/mi-out.h".
3462         (print_one_breakpoint): Change output syntax if using MI version
3463         >= 3.
3464         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3465         New.
3466         (mi_multi_location_breakpoint_output_fixed): New.
3467         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3468         (mi_cmd_fix_multi_location_breakpoint_output): New.
3469         (mi_multi_location_breakpoint_output_fixed): New.
3470         * mi/mi-cmds.c (mi_cmds): Register command
3471         -fix-multi-location-breakpoint-output.
3472         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3473         interpreter "mi".
3474
3475 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3476
3477         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3478         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3479         instantiate mi_ui_out based on interpreter name.
3480         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3481         * mi/mi-main.c (mi_load_progress): Likewise.
3482
3483 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3484
3485         * NEWS: Combine separate "New targets" sections for 8.3.
3486
3487 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3488
3489         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3490         (ppcfbsd_init_abi): Install gdbarch
3491         "fetch_tls_load_module_address" and "get_thread_local_address"
3492         methods.
3493
3494 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3495
3496         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3497         (riscv_fbsd_init_abi): Install gdbarch
3498         "fetch_tls_load_module_address" and "get_thread_local_address"
3499         methods.
3500
3501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3502
3503         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3504         (i386fbsd_init_abi): Install gdbarch
3505         "fetch_tls_load_module_address" and "get_thread_local_address"
3506         methods.
3507
3508 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3509
3510         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3511         (amd64fbsd_init_abi): Install gdbarch
3512         "fetch_tls_load_module_address" and "get_thread_local_address"
3513         methods.
3514
3515 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3516
3517         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3518         (struct fbsd_pspace_data): New type.
3519         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3520         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3521         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3522         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3523         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3524
3525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3526
3527         * gdbtypes.c (lookup_struct_elt): New function.
3528         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3529         * gdbtypes.h (struct struct_elt): New type.
3530         (lookup_struct_elt): New prototype.
3531
3532 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3533
3534         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3535         remove disabled code block.
3536
3537 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3538
3539         * gdbarch.sh (get_thread_local_address): New method.
3540         * gdbarch.h, gdbarch.c: Regenerate.
3541         * target.c (target_translate_tls_address): Use
3542         gdbarch_get_thread_local_address if present instead of
3543         target::get_thread_local_address.
3544
3545 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3546
3547         * target.h (target::get_thread_local_address): Update comment.
3548
3549 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3550
3551         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3552         objfile->separate_debug_objfile_backlink if not NULL.
3553
3554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3555
3556         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3557         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3558         (amd64bsd_store_inferior_registers): Likewise.
3559         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3560         Enable segment base registers.
3561         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3562         PT_GETFSBASE and PT_GETGSBASE.
3563         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3564         PT_SETGSBASE.
3565         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3566         segment base registers.
3567         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3568
3569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3570
3571         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3572         Update calls to i386_target_description to add 'segments'
3573         parameter.
3574         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3575         add segment base registers.
3576         * arch/i386.c (i386_create_target_description): Add 'segments'
3577         parameter to enable segment base registers.
3578         * arch/i386.h (i386_create_target_description): Likewise.
3579         * features/i386/32bit-segments.xml: New file.
3580         * features/i386/32bit-segments.c: Generate.
3581         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3582         call to i386_target_description to add 'segments' parameter.
3583         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3584         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3585         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3586         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3587         if feature is present.
3588         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3589         Add 'segments' parameter to call to i386_target_description.
3590         (i386_target_description): Add 'segments' parameter to enable
3591         segment base registers.
3592         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3593         to call to i386_target_description.
3594         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3595         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3596         Define I386_NUM_REGS.
3597         (i386_target_description): Add 'segments' parameter to enable
3598         segment base registers.
3599
3600 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3601
3602         PR/24325
3603         * source-cache.c: #undef open and close, to avoid unresolved
3604         externals during linking.
3605
3606 2019-03-12  Tom Tromey  <tromey@adacore.com>
3607
3608         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3609         const.  Add initializers.
3610         (_initialize_remote): Don't initialize ptid globals.
3611
3612 2019-03-12  Pedro Alves  <palves@redhat.com>
3613
3614         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3615
3616 2019-03-12  Pedro Alves  <palves@redhat.com>
3617
3618         * cp-name-parser.y (main): Remove unused 'len' variable.
3619
3620 2019-03-12  Tom Tromey  <tromey@adacore.com>
3621
3622         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3623         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3624
3625 2019-03-12  Tom Tromey  <tromey@adacore.com>
3626
3627         * linux-nat.c (iterate_over_lwps): Update.
3628         (stop_callback): Remove parameter.
3629         (stop_wait_callback, detach_callback, resume_set_callback)
3630         (select_singlestep_lwp_callback, set_ignore_sigint)
3631         (status_callback, resumed_callback, resume_clear_callback)
3632         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3633         data parameter.
3634         (linux_nat_target::detach, linux_nat_target::resume)
3635         (linux_stop_and_wait_all_lwps, select_event_lwp)
3636         (linux_nat_filter_event, linux_nat_wait_1)
3637         (linux_nat_target::kill, linux_nat_target::stop)
3638         (linux_nat_target::stop): Update.
3639         (linux_nat_resume_callback): Change type.
3640         (resume_stopped_resumed_lwps, count_events_callback)
3641         (select_event_lwp_callback): Likewise.
3642         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3643         * arm-linux-nat.c (struct update_registers_data): Remove.
3644         (update_registers_callback): Change type.
3645         (arm_linux_insert_hw_breakpoint1): Update.
3646         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3647         parameter.
3648         (x86_linux_dr_set_addr): Update.
3649         (x86_linux_dr_set_control): Update.
3650         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3651         (iterate_over_lwps): Use gdb::function_view.
3652         * nat/aarch64-linux-hw-point.c (struct
3653         aarch64_dr_update_callback_param): Remove.
3654         (debug_reg_change_callback): Change type.
3655         (aarch64_notify_debug_reg_change): Update.
3656         * s390-linux-nat.c (s390_refresh_per_info): Update.
3657
3658 2019-03-11  Tom Tromey  <tromey@adacore.com>
3659
3660         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3661         redundant assignment to "this_cu".
3662
3663 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3664
3665         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3666
3667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3668
3669         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3670         from...
3671         (rank_one_type): ... this.
3672
3673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3674
3675         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3676         from...
3677         (rank_one_type): ... this.
3678
3679 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3680
3681         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3682         from...
3683         (rank_one_type): ... this.
3684
3685 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3686
3687         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3688         from...
3689         (rank_one_type): ... this.
3690
3691 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3692
3693         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3694         from...
3695         (rank_one_type): ... this.
3696
3697 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3698
3699         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3700         from...
3701         (rank_one_type): ... this.
3702
3703 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3704
3705         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3706         from...
3707         (rank_one_type): ... this.
3708
3709 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3710
3711         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3712         from...
3713         (rank_one_type): ... this.
3714
3715 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3716
3717         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3718         from...
3719         (rank_one_type): ... this.
3720
3721 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3722
3723         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3724         from...
3725         (rank_one_type): ... this.
3726
3727 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3728
3729         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3730         from...
3731         (rank_one_type): ... this.
3732
3733 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3734
3735         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3736         from...
3737         (rank_one_type): ... this.
3738
3739 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3740
3741         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3742         inferior-events' shows the example events.
3743
3744 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3745
3746         Support styling on native MS-Windows console
3747
3748         PR/24315
3749         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3750         on MS-Windows if $TERM is not defined.
3751
3752         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3753
3754         * posix-hdep.c (gdb_console_fputs):
3755         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3756         functions.
3757         * ui-file.h (gdb_console_fputs): Add prototype.
3758
3759         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3760         back to fputs only if the former returns zero.
3761
3762 2019-03-07  Tom Tromey  <tom@tromey.com>
3763
3764         * symmisc.c (print_symbol_bcache_statistics): Update.
3765         (print_objfile_statistics): Update.
3766         * symfile.c (allocate_symtab): Update.
3767         * stabsread.c: Don't include bcache.h.
3768         * psymtab.h (struct psymbol_bcache): Don't declare.
3769         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3770         (psymbol_bcache_init, psymbol_bcache_free)
3771         (psymbol_bcache_get_bcache): Don't declare.
3772         * psymtab.c (struct psymbol_bcache): Remove.
3773         (psymtab_storage::psymtab_storage): Update.
3774         (psymtab_storage::~psymtab_storage): Update.
3775         (psymbol_bcache_init, psymbol_bcache_free)
3776         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3777         (add_psymbol_to_bcache): Update.
3778         (allocate_psymtab): Update.
3779         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3780         macro_cache>: No longer pointers.
3781         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3782         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3783         * macrotab.c (macro_bcache): Update.
3784         * macroexp.c: Don't include bcache.h.
3785         * gdbtypes.c (check_types_worklist): Update.
3786         (types_deeply_equal): Remove TRY/CATCH.  Update.
3787         * elfread.c (elf_symtab_read): Update.
3788         * dwarf2read.c: Don't include bcache.h.
3789         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3790         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3791         (print_bcache_statistics, bcache_memory_used): Don't declare.
3792         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3793         methods.  Rename all data members.
3794         * bcache.c (struct bcache): Move to bcache.h.
3795         (bcache::expand_hash_table): Rename from expand_hash_table.
3796         (bcache): Remove.
3797         (bcache::insert): Rename from bcache_full.
3798         (bcache::compare): Rename from bcache_compare.
3799         (bcache_xmalloc): Remove.
3800         (bcache::~bcache): Rename from bcache_xfree.
3801         (bcache::print_statistics): Rename from print_bcache_statistics.
3802         (bcache::memory_used): Rename from bcache_memory_used.
3803
3804 2019-03-07  Pedro Alves  <palves@redhat.com>
3805
3806         * infrun.c (normal_stop): Also check for
3807         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3808
3809 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * f-lang.c (value_from_host_double): Moved to...
3812         * value.c (value_from_host_double): ...here.
3813         * value.h (value_from_host_double): Declare.
3814         * guile/scm-math.c (vlscm_convert_typed_number): Use
3815         value_from_host_double.
3816         (vlscm_convert_number): Likewise.
3817         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3818         * python/py-value.c (convert_value_from_python): Likewise.
3819
3820 2019-03-06  Tom Tromey  <tom@tromey.com>
3821
3822         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3823
3824 2019-03-06  Tom Tromey  <tom@tromey.com>
3825
3826         * utils.h (free_current_contents): Don't declare.
3827         * utils.c (free_current_contents): Remove.
3828
3829 2019-03-06  Tom Tromey  <tom@tromey.com>
3830
3831         * top.c (quit_force): Update.
3832         * main.c (captured_command_loop): Update.
3833         * common/new-op.c (operator new): Update.
3834         * common/common-exceptions.c (struct catcher)
3835         <save_cleanup_chain>: Remove member.
3836         (exceptions_state_mc_init): Update.
3837         (exception_try_scope_entry): Return nullptr.
3838         (exception_try_scope_exit, exception_rethrow)
3839         (throw_exception_sjlj, throw_exception_cxx): Update.
3840         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3841         (all_cleanups, do_cleanups, discard_cleanups)
3842         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3843         (restore_cleanups, restore_final_cleanups): Don't declare.
3844         (do_final_cleanups): Remove parameter.
3845         * common/cleanups.c (cleanup_chain, make_cleanup)
3846         (make_cleanup_dtor, all_cleanups, do_cleanups)
3847         (discard_my_cleanups, discard_cleanups)
3848         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3849         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3850         (null_cleanup): Remove.
3851         (do_final_cleanups): Remove parameter.
3852
3853 2019-03-06  Tom Tromey  <tom@tromey.com>
3854
3855         * remote.c (remote_target::remote_parse_stop_reply): Use
3856         unique_xmalloc_ptr.
3857
3858 2019-03-06  Tom Tromey  <tom@tromey.com>
3859
3860         * stabsread.c (struct stabs_field_info): Rename from field_info.
3861         <list, fnlist>: Add initializers.
3862         <obstack>: New member.
3863         (read_member_functions, read_struct_fields, read_baseclasses):
3864         Allocate on obstack.  Don't use cleanups.
3865         (read_one_struct_field, read_member_functions, read_struct_fields)
3866         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3867         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3868         (read_struct_type): Update.
3869
3870 2019-03-06  Tom Tromey  <tom@tromey.com>
3871
3872         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3873         * common/filestuff.h (make_cleanup_close): Don't declare.
3874         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3875         Remove.
3876
3877 2019-03-06  Tom Tromey  <tom@tromey.com>
3878
3879         * solib-aix.c: Use make_scope_exit.
3880
3881 2019-03-06  Tom Tromey  <tom@tromey.com>
3882
3883         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3884         Use make_scope_exit.
3885
3886 2019-03-06  Tom Tromey  <tom@tromey.com>
3887
3888         * solib-svr4.c (disable_probes_interface): Remove parameter.
3889         (svr4_handle_solib_event): Use make_scope_exit.
3890
3891 2019-03-06  Tom Tromey  <tom@tromey.com>
3892
3893         * remote.c (struct stop_reply_deleter): Remove.
3894         (stop_reply_up): Update.
3895         (struct stop_reply): Derive from notif_event.  Don't typedef.
3896         <regcache>: Now a std::vector.
3897         (stop_reply_xfree): Remove.
3898         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3899         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3900         (remote_target::discard_pending_stop_replies): Use delete.
3901         (remote_target::remote_parse_stop_reply): Update.
3902         (remote_target::process_stop_reply): Update.
3903         * remote-notif.h (struct notif_event): Add virtual destructor.
3904         Remove "dtr" member.
3905         (struct notif_client) <alloc_event>: Return a unique_ptr.
3906         (notif_event_xfree): Don't declare.
3907         (notif_event_up): New typedef.
3908         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3909         (notif_event_xfree, do_notif_event_xfree): Remove.
3910         (remote_notif_state_xfree): Update.
3911
3912 2019-03-06  Tom Tromey  <tom@tromey.com>
3913
3914         * infrun.c (displaced_step_clear_cleanup): Now a
3915         forward_scope_exit type.
3916         (displaced_step_prepare_throw): Update.
3917         (displaced_step_fixup): Update.
3918
3919 2019-03-06  Tom Tromey  <tom@tromey.com>
3920
3921         * inferior.h (class inferior): Update comment.
3922         * gdbthread.h (class thread_info): Update comment.
3923
3924 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3925             Tom Tromey  <tom@tromey.com>
3926
3927         * stabsread.h (struct stab_section_list): Remove.
3928         (coffstab_build_psymtabs): Update.
3929         * dbxread.c (symbuf_sections): Now a std::vector.
3930         (sect_idx): New global.
3931         (fill_symbuf): Update.
3932         (coffstab_build_psymtabs): Change type of stabsects parameter.
3933         Update.
3934         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3935         std::vector.
3936         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3937         (coff_locate_sections): Update.
3938         (coff_symfile_read): Remove cleanups.  Update.
3939         (init_stringtab): Add storage parameter.
3940         (free_stringtab, free_stringtab_cleanup): Remove.
3941         (init_lineno): Add storage parameter.
3942         (free_linetab, free_linetab_cleanup): Remove.
3943
3944 2019-03-06  Pedro Alves  <palves@redhat.com>
3945
3946         * linux-fork.c (fork_info::clobber_regs): Delete.
3947         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3948         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3949         comment.  Adjust.
3950         (scoped_switch_fork_info::scoped_switch_fork_info)
3951         (checkpoint_command, linux_fork_context): Adjust
3952         fork_save_infrun_state calls.
3953
3954 2019-03-06  Pedro Alves  <palves@redhat.com>
3955
3956         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3957         (inf_has_multiple_threads): Return 'bool' and rewrite using
3958         inferior_info::threads().
3959
3960 2019-03-06  Pedro Alves  <palves@redhat.com>
3961
3962         * linux-fork.c: Include <list>.
3963         (fork_list): Now a std::list instance.
3964         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3965         (forks_exist_p, find_last_fork): Adjust.
3966         (new_fork): Delete.
3967         (one_fork_p): New.
3968         (add_fork): Adjust.
3969         (free_fork): Delete, folded into fork_info::~fork_info().
3970         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3971         Adjust.
3972         (init_fork_list): Delete.
3973         (linux_fork_killall, linux_fork_mourn_inferior)
3974         (linux_fork_detach, info_checkpoints_command): Adjust.
3975         (_initialize_linux_fork): No longer call init_fork_list.
3976
3977 2019-03-06  Pedro Alves  <palves@redhat.com>
3978
3979         * linux-fork.c (new_fork): New, split out of ...
3980         (add_fork): ... this.  Return void.  Move "first fork" special
3981         case from here, to ...
3982         (checkpoint_command): ... here.
3983         * linux-linux.h (add_fork): Return void.
3984
3985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3986
3987         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3988
3989 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3990             Chris January  <chris.january@arm.com>
3991             David Lecomber  <david.lecomber@arm.com>
3992
3993         * f-exp.y: New token, UNOP_INTRINSIC.
3994         (exp): New pattern using UNOP_INTRINSIC token.
3995         (f77_keywords): Add 'abs' keyword.
3996         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3997         (value_from_host_double): New function.
3998         (evaluate_subexp_f): Support UNOP_ABS.
3999
4000 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4001
4002         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4003         types.
4004
4005 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4006
4007         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4008         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4009         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4010
4011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4012
4013         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4014
4015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4016             Chris January  <chris.january@arm.com>
4017
4018         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4019         * f-exp.y: Define 'KIND' token.
4020         (exp): New pattern for KIND expressions.
4021         (ptype): Handle types with a kind extension.
4022         (direct_abs_decl): Extend to spot kind extensions.
4023         (f77_keywords): Add 'kind' to the list.
4024         (push_kind_type): New function.
4025         (convert_to_kind_type): New function.
4026         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4027         * parse.c (operator_length_standard): Likewise.
4028         * parser-defs.h (enum type_pieces): Add tp_kind.
4029         * std-operator.def: Add UNOP_KIND.
4030
4031 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4032
4033         * f-exp.y (f_parse): Set yydebug.
4034
4035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4036
4037         * f-lang.c (evaluate_subexp_f): New function.
4038         (exp_descriptor_f): New global.
4039         (f_language_defn): Use exp_descriptor_f instead of
4040         exp_descriptor_standard.
4041
4042 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4043
4044         * f-exp.y (struct token): Add comments.
4045         (dot_ops): Remove uppercase versions and the end marker.
4046         (f77_keywords): Likewise.
4047         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4048         entries in the dot_ops array are case insensitive, and use
4049         strncasecmp to compare strings.  Also some whitespace cleanup in
4050         this area.  Similar for the f77_keywords array, except entries in
4051         this list might be case sensitive.
4052
4053 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4054
4055         * f-exp.y (struct f77_boolean_val): Add comments.
4056         (boolean_values): Remove uppercase versions, and end marker.
4057         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4058         and use strncasecmp to achieve case insensitivity.  Additionally,
4059         perform whitespace cleanup around this code.
4060
4061 2019-03-06  Tom Tromey  <tromey@adacore.com>
4062
4063         * remote-sim.c (gdbsim_target_open): Use result of
4064         gdb_argv::release.
4065
4066 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4067         Dirk Schubert  <dirk.schubert@arm.com>
4068         Chris January  <chris.january@arm.com>
4069
4070         * eval.c (evaluate_subexp_standard): Call Fortran argument
4071         wrapping logic.
4072         * f-lang.c (struct value): A value which can be passed into a
4073         Fortran function call.
4074         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4075         where appropriate.
4076         (struct type): Value ready for a Fortran function call.
4077         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4078         is needed.
4079         * f-lang.h (fortran_argument_convert): Declaration.
4080         (fortran_preserve_arg_pointer): Declaration.
4081         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4082
4083 2019-03-05  Tom Tromey  <tromey@adacore.com>
4084
4085         * python/py-prettyprint.c (print_string_repr): Remove #if.
4086         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4087
4088 2019-03-05  Tom Tromey  <tromey@adacore.com>
4089
4090         * target.c (the_dummy_target): Move later.  Change type to
4091         "dummy_target".
4092         (initialize_targets): Don't initialize the_dummy_target.
4093
4094 2019-03-05  Tom Tromey  <tromey@adacore.com>
4095
4096         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4097         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4098
4099 2019-03-05  Tom Tromey  <tromey@adacore.com>
4100
4101         * windows-nat.c (windows_nat_target::attach)
4102         (windows_nat_target::detach): Don't call gdb_flush.
4103         * valprint.c (generic_val_print, val_print, val_print_string):
4104         Don't call gdb_flush.
4105         * utils.c (defaulted_query): Don't call gdb_flush.
4106         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4107         * target.c (target_announce_detach): Don't call gdb_flush.
4108         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4109         * remote.c (extended_remote_target::attach): Don't call
4110         gdb_flush.
4111         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4112         * printcmd.c (do_examine): Don't call gdb_flush.
4113         (info_display_command): Don't call gdb_flush.
4114         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4115         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4116         * memattr.c (info_mem_command): Don't call gdb_flush.
4117         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4118         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4119         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4120         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4121         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4122         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4123         (gnu_nat_target::detach): Don't call gdb_flush.
4124         * f-valprint.c (f_val_print): Don't call gdb_flush.
4125         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4126         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4127         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4128         gdb_flush.
4129         * c-valprint.c (c_val_print): Don't call gdb_flush.
4130         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4131
4132 2019-03-05  Tom Tromey  <tromey@adacore.com>
4133
4134         * varobj.c (update_dynamic_varobj_children): Update.
4135         (install_default_visualizer): Use reset, not release.
4136         * value.c (set_internalvar): Update.
4137         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4138         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4139         ATTRIBUTE_UNUSED_RESULT.
4140
4141 2019-03-05  Tom Tromey  <tromey@adacore.com>
4142
4143         * remote.c (class scoped_remote_fd) <release>: Add
4144         ATTRIBUTE_UNUSED_RESULT.
4145
4146 2019-03-05  Tom Tromey  <tromey@adacore.com>
4147
4148         * macroexp.c (struct macro_buffer) <release>: Add
4149         ATTRIBUTE_UNUSED_RESULT.
4150
4151 2019-03-05  Tom Tromey  <tromey@adacore.com>
4152
4153         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4154         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4155         ATTRIBUTE_UNUSED_RESULT.
4156
4157 2019-03-05  Tom Tromey  <tromey@adacore.com>
4158
4159         * common/scoped_fd.h (class scoped_fd) <release>: Add
4160         ATTRIBUTE_UNUSED_RESULT.
4161
4162 2019-03-05  Tom Tromey  <tromey@adacore.com>
4163
4164         * parser-defs.h (struct parser_state) <release>: Add
4165         ATTRIBUTE_UNUSED_RESULT.
4166
4167 2019-03-05  Tom Tromey  <tromey@adacore.com>
4168
4169         * utils.h (class gdb_argv) <release>: Add
4170         ATTRIBUTE_UNUSED_RESULT.
4171         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4172
4173 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4174
4175         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4176         for-loop range, to avoid compiler warnings.
4177
4178         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4179         avoid compiler warnings about unused variables.
4180
4181         * NEWS: Mention end of support for native debugging on MS-Windows
4182         before XP.
4183
4184         PR gdb/24292
4185         * common/netstuff.c:
4186         * gdbserver/gdbreplay.c
4187         * gdbserver/remote-utils.c:
4188         * ser-tcp.c:
4189         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4190         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4191         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4192         'getaddrinfo' and 'freeaddrinfo' were not available before
4193         Windows XP, and mingw.org's MinGW headers by default define
4194         _WIN32_WINNT to 0x500.
4195
4196 2019-03-01  Gary Benson <gbenson@redhat.com>
4197
4198         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4199
4200 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4201             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4202
4203         PR gdb/8527
4204         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4205         set_sigint_trap, clear_sigint_trap.
4206
4207 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4208
4209         * target.c (target_detach): Clear the regcache and the
4210         frame cache.
4211
4212 2019-02-27  Pedro Alves  <palves@redhat.com>
4213
4214         * utils.c (set_screen_size): When we cap the height/width sizes,
4215         tweak the corresponding command variable to show "unlimited":
4216
4217 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4218             Pedro Alves  <palves@redhat.com>
4219
4220         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4221         before calling rl_set_screen_size.
4222
4223 2019-02-27  Tom Tromey  <tromey@adacore.com>
4224
4225         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4226         define.
4227         * python/py-value.c: Remove Python 2.4 workaround.
4228         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4229         workaround.
4230         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4231         Python 2.4 workaround.
4232         * python/python-internal.h: Remove Python 2.4 comment.
4233         (Py_ssize_t): Don't define.
4234         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4235         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4236         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4237         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4238         * python/python.c (do_start_initialization): Remove Python 2.4
4239         workaround.
4240         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4241         (print_children): Remove Python 2.4 workaround.
4242         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4243         workaround.
4244         (CHARBUFFERPROC_NAME): Remove.
4245         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4246         Python 2.4 workaround.
4247
4248 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4249
4250         * NEWS: Note minimum Python version.
4251
4252 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4253
4254         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4255         code from these functions.  Remove corresponding ifdefs.  Use
4256         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4257         Remove gotos and target of gotos.
4258         (infpy_search_memory): Likewise.
4259
4260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4261
4262         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4263         (hppa_gdbarch_init): Don't register deleted functions with
4264         gdbarch.
4265
4266 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4267
4268         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4269         (h8300_unwind_sp): Delete.
4270         (h8300_dummy_id): Delete.
4271         (h8300_gdbarch_init): Don't register deleted functions with
4272         gdbarch.
4273
4274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4275
4276         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4277         (ft32_unwind_pc): Delete.
4278         (ft32_unwind_sp): Delete.
4279         (ft32_gdbarch_init): Don't register deleted functions with
4280         gdbarch.
4281
4282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4285         (frv_unwind_pc): Delete.
4286         (frv_unwind_sp): Delete.
4287         (frv_gdbarch_init): Don't register deleted functions with
4288         gdbarch.
4289
4290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4293         (riscv_unwind_pc): Delete.
4294         (riscv_unwind_sp): Delete.
4295         (riscv_gdbarch_init): Don't register deleted functions with
4296         gdbarch.
4297
4298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4301         (csky_unwind_pc): Delete.
4302         (csky_unwind_sp): Delete.
4303         (csky_gdbarch_init): Don't register deleted functions with
4304         gdbarch.
4305
4306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4309         (cris_unwind_pc): Delete.
4310         (cris_unwind_sp): Delete.
4311         (cris_gdbarch_init): Don't register deleted functions with
4312         gdbarch.
4313
4314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4317         (bfin_unwind_pc): Delete.
4318         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4319
4320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4323         (arm_unwind_pc): Delete.
4324         (arm_unwind_sp): Delete.
4325         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4326
4327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4328
4329         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4330         (arc_unwind_pc): Delete.
4331         (arc_unwind_sp): Delete.
4332         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4333
4334 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4335
4336         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4337         (alpha_unwind_pc): Delete.
4338         (alpha_gdbarch_init): Don't register deleted functions with
4339         gdbarch.
4340
4341 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4342
4343         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4344         (aarch64_unwind_pc): Delete.
4345         (aarch64_unwind_sp): Delete.
4346         (aarch64_gdbarch_init): Don't register deleted functions with
4347         gdbarch.
4348
4349 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * gdbtypes.c (type_align): Don't consider static members when
4352         computing structure alignment.
4353
4354 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4355
4356         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4357         return 0 for other types.
4358         * arch-utils.c (default_type_align): Always return 0.
4359         * gdbarch.h: Regenerate.
4360         * gdbarch.sh (type_align): Extend comment.
4361         * gdbtypes.c (type_align): Add additional comments, always call
4362         gdbarch_type_align before applying the default rules.
4363         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4364         generic code will then apply a suitable default.
4365         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4366         types, return 0 for other types.
4367
4368 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4369
4370         * NEWS: Create a new section for the next release branch.
4371         Rename the section of the current branch, now that it has
4372         been cut.
4373
4374 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4375
4376         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4377         * version.in: Bump version to 8.3.50.DATE-git.
4378
4379 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4380
4381         * aix-thread.c (ptid_cmp): Remove unused variable.
4382         (get_signaled_thread): Likewise.
4383         (store_regs_user_thread): Likewise.
4384         (store_regs_kernel_thread): Likewise.
4385         (fetch_regs_kernel_thread): Remove shadowed variable.
4386
4387 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4388
4389         * features/riscv/32bit-cpu.xml: Add register numbers.
4390         * features/riscv/32bit-fpu.c: Regenerate.
4391         * features/riscv/32bit-fpu.xml: Add register numbers.
4392         * features/riscv/64bit-cpu.xml: Add register numbers.
4393         * features/riscv/64bit-fpu.c: Regenerate.
4394         * features/riscv/64bit-fpu.xml: Add register numbers.
4395
4396 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4397
4398         * NEWS: Mention two argument form of gdb.Value constructor.
4399         * python/py-value.c (convert_buffer_and_type_to_value): New
4400         function.
4401         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4402         Add support for handling an optional second argument.  Call
4403         convert_buffer_and_type_to_value as appropriate.
4404         * python/python-internal.h (Py_buffer_deleter): New struct.
4405         (Py_buffer_up): New typedef.
4406
4407 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4408
4409         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4410         instead of releasing ownership.
4411
4412 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4413
4414         * dwarf2read.c (open_and_init_dwp_file): Call
4415         elf_numsections instead of bfd_count_sections to initialize
4416         dwp_file->num_sections.
4417
4418 2019-02-25  Tom Tromey  <tromey@adacore.com>
4419
4420         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4421
4422 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4423
4424         * gcore.in: Add '--readnever' option when invoking GDB.
4425
4426 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4427
4428         * MAINTAINERS: Update my email address.
4429
4430 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4431
4432         * build-id.c (build_id_to_debug_bfd_1): New function.
4433         (build_id_to_debug_bfd): Look for separate debug file in
4434         sysroot.
4435
4436 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4437
4438         * gdbarch.sh: Update the copyright year range that is placed into
4439         generated files.
4440
4441 2019-02-22  Keith Seitz  <keiths@redhat.com>
4442
4443         PR symtab/23853
4444         * linespec.c (create_sals_line_offset): Search for the default
4445         symtab's filename instead of its fullname.
4446
4447 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4448
4449         * NEWS: Update style defaults.
4450
4451 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4452
4453         * main.c (captured_main_1): Disable styling in batch mode.
4454
4455 2019-02-20  Tom Tromey  <tom@tromey.com>
4456
4457         * symtab.c (symtab_symbol_info): Fix typos.
4458
4459 2019-02-20  Tom Tromey  <tromey@adacore.com>
4460
4461         * findcmd.c (_initialize_mem_search): Use upper case for
4462         metasyntactic variables.
4463
4464 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4465
4466         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4467         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4468
4469 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4470
4471         * top.h (source_file_name): Change to std::string.
4472         * top.c (source_file_name): Likewise.
4473         (command_line_input): Adjust.
4474         * cli/cli-script.c (script_from_file): Adjust.
4475
4476 2019-02-19  Tom Tromey  <tromey@adacore.com>
4477
4478         * ravenscar-thread.c
4479         (ravenscar_thread_target::update_thread_list): Don't call
4480         ada_build_task_list.
4481         * ada-lang.h (ada_build_task_list): Don't declare.
4482         * ada-tasks.c (struct ada_tasks_inferior_data)
4483         <task_list_valid_p>: Now bool.
4484         (read_known_tasks, ada_task_list_changed)
4485         (ada_tasks_invalidate_inferior_data): Update.
4486         (read_known_tasks_array): Return bool.
4487         (read_known_tasks_list): Likewise.
4488         (read_known_tasks): Return void.
4489         (ada_build_task_list): Now static.
4490
4491 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4494         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4495
4496 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4497
4498         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4499         variant for ada_tasks_pspace_data_handle and
4500         ada_tasks_inferior_data_handle.
4501         (ada_tasks_pspace_data_cleanup): New function.
4502         (ada_tasks_inferior_data_cleanup): New function.
4503
4504 2019-02-17  Tom Tromey  <tom@tromey.com>
4505
4506         * macrotab.h (macro_source_fullname): Return a std::string.
4507         * macrotab.c (macro_include, check_for_redefinition)
4508         (macro_undef, macro_lookup_definition, foreach_macro)
4509         (foreach_macro_in_scope): Update.
4510         (macro_source_fullname): Return a std::string.
4511         * macrocmd.c (show_pp_source_pos): Update.
4512
4513 2019-02-17  Tom Tromey  <tom@tromey.com>
4514
4515         * macrocmd.c (show_pp_source_pos): Style the file names.
4516
4517 2019-02-17  Tom Tromey  <tom@tromey.com>
4518
4519         PR tui/24197:
4520         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4521
4522 2019-02-17  Tom Tromey  <tom@tromey.com>
4523
4524         * ada-lang.c (user_select_syms): Use filtered printing.
4525         * utils.c (wrap_style): New global.
4526         (desired_style): Remove.
4527         (emit_style_escape): Add stream parameter.
4528         (set_output_style, reset_terminal_style, prompt_for_continue):
4529         Update.
4530         (flush_wrap_buffer): Only flush gdb_stdout.
4531         (wrap_here): Set wrap_style.
4532         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4533         treat escape sequences as a character.  Change when wrap buffer is
4534         flushed.
4535         (fputs_styled): Do not set the output style when the default is
4536         requested.
4537         * ui-style.h (struct ui_file_style) <is_default>: New method.
4538         * source.c (print_source_lines_base): Emit escape sequences in one
4539         piece.
4540
4541 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4542
4543         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4544         integers and enumeration types.
4545
4546 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4547
4548         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4549         instead of lookup_symbol_in_language
4550         (do_exact_match): New function.
4551         (ada_get_symbol_name_matcher): Return do_exact_match when
4552         doing a verbatim match.
4553
4554 2019-02-15  Tom Tromey  <tromey@adacore.com>
4555
4556         * ravenscar-thread.c (ravenscar_thread_target::resume)
4557         (ravenscar_thread_target::wait): Special case wildcard requests.
4558
4559 2019-02-15  Tom Tromey  <tromey@adacore.com>
4560
4561         * ravenscar-thread.c (base_ptid): Remove.
4562         (struct ravenscar_thread_target) <close>: New method.
4563         <m_base_ptid>: New member.
4564         <update_inferior_ptid, active_task, task_is_currently_active,
4565         runtime_initialized>: Declare methods.
4566         <ravenscar_thread_target>: Add constructor.
4567         (ravenscar_thread_target::task_is_currently_active)
4568         (ravenscar_thread_target::update_inferior_ptid)
4569         (ravenscar_runtime_initialized): Rename.  Now methods.
4570         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4571         (ravenscar_thread_target::update_thread_list): Update.
4572         (ravenscar_thread_target::active_task): Now method.
4573         (ravenscar_thread_target::store_registers)
4574         (ravenscar_thread_target::prepare_to_store)
4575         (ravenscar_thread_target::prepare_to_store)
4576         (ravenscar_thread_target::mourn_inferior): Update.
4577         (ravenscar_inferior_created): Use "new" to create target.
4578         (ravenscar_thread_target::get_ada_task_ptid): Update.
4579         (_initialize_ravenscar): Don't initialize base_ptid.
4580         (ravenscar_ops): Remove global.
4581
4582 2019-02-15  Tom Tromey  <tromey@adacore.com>
4583
4584         * target.h (push_target): Declare new overload.
4585         * target.c (push_target): New overload, taking an rvalue reference.
4586         * remote.c (remote_target::open_1): Use push_target overload.
4587         * corelow.c (core_target_open): Use push_target overload.
4588
4589 2019-02-15  Tom Tromey  <tromey@adacore.com>
4590
4591         * ravenscar-thread.c (is_ravenscar_task)
4592         (ravenscar_task_is_currently_active): Return bool.
4593         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4594         (_initialize_ravenscar): Remove "(void)".
4595         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4596         Return bool.
4597
4598 2019-02-15  Tom Tromey  <tromey@adacore.com>
4599
4600         * ravenscar-thread.c (ravenscar_runtime_initializer)
4601         (has_ravenscar_runtime, get_running_thread_id)
4602         (ravenscar_thread_target::resume): Fix indentation.
4603
4604 2019-02-15  Tom Tromey  <tromey@adacore.com>
4605
4606         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4607         from ravenscar_arch_ops.
4608         (sparc_ravenscar_ops::fetch_registers)
4609         (sparc_ravenscar_ops::store_registers): Now methods.
4610         (sparc_ravenscar_prepare_to_store): Remove.
4611         (sparc_ravenscar_ops): Redefine.
4612         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4613         methods and destructor.  Remove members.
4614         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4615         (ravenscar_thread_target::store_registers)
4616         (ravenscar_thread_target::prepare_to_store): Update.
4617         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4618         Remove.
4619         (struct ppc_ravenscar_powerpc_ops): Derive from
4620         ravenscar_arch_ops.
4621         (ppc_ravenscar_powerpc_ops::fetch_registers)
4622         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4623         (ppc_ravenscar_powerpc_ops): Redefine.
4624         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4625         (ppc_ravenscar_e500_ops::fetch_registers)
4626         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4627         (ppc_ravenscar_e500_ops): Redefine.
4628         * aarch64-ravenscar-thread.c
4629         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4630         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4631         (aarch64_ravenscar_fetch_registers)
4632         (aarch64_ravenscar_store_registers): Now methods.
4633         (aarch64_ravenscar_ops): Redefine.
4634
4635 2019-02-15  Tom Tromey  <tromey@adacore.com>
4636
4637         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4638         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4639         (ravenscar_thread_target::stopped_by_watchpoint)
4640         (ravenscar_thread_target::stopped_data_address)
4641         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4642
4643 2019-02-15  Tom Tromey  <tromey@adacore.com>
4644
4645         * ravenscar-thread.c: Fix some typos.
4646
4647 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4648             Tom Tromey  <tromey@adacore.com>
4649
4650         * ada-lang.c (ada_exception_sal): Change addr_string to a
4651         std::string.
4652         (create_ada_exception_catchpoint): Update.
4653
4654 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4655             Tom Tromey  <tromey@adacore.com>
4656
4657         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4658         (bp_location_ops): Remove.
4659         (base_breakpoint_allocate_location): Update.
4660         (free_bp_location): Update.
4661         * ada-lang.c (class ada_catchpoint_location)
4662         <ada_catchpoint_location>: Remove ops parameter.
4663         (ada_catchpoint_location_dtor): Remove.
4664         (ada_catchpoint_location_ops): Remove.
4665         (allocate_location_exception): Update.
4666         * breakpoint.h (struct bp_location_ops): Remove.
4667         (class bp_location) <bp_location>: Remove bp_location_ops
4668         parameter.
4669         <~bp_location>: Add destructor.
4670         <ops>: Remove.
4671
4672 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4673             Pedro Alves  <palves@redhat.com>
4674
4675         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4676         'PATH_MAX'.
4677
4678 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4679             Samuel Thibault  <samuel.thibault@gnu.org>
4680             Thomas Schwinge  <thomas@codesourcery.com>
4681
4682         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4683         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4684
4685 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4686
4687         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4688         (check_empty): Use "const char *".
4689
4690         * gnu-nat.c (gnu_nat_target::detach): Instead of
4691         'detach_inferior (pid)' call
4692         'detach_inferior (find_inferior_pid (pid))'.
4693
4694         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4695         'nat/fork-inferior.o'.
4696         * gnu-nat.c: #include "nat/fork-inferior.h".
4697
4698         * gnu-nat.c (gnu_nat_target::detach): Instead of
4699         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4700         * gnu-nat.h: #include "inf-child.h".
4701         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4702         'i386_gnu_nat_target::fetch_registers'.
4703         (gnu_store_registers): Rename/move to
4704         'i386_gnu_nat_target::store_registers'.
4705
4706         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4707         * gnu-nat.h (mach_thread_info): New function.
4708         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4709
4710         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4711
4712 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4713
4714         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4715
4716 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4717
4718         * windows-nat.c (windows_add_thread): Add new parameter
4719         "main_thread_p" with default value set to false.  Update
4720         function documentation as well as all callers.
4721         (windows_delete_thread): Likewise.
4722         (fake_create_process): Update call to windows_add_thread.
4723         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4724         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4725         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4726         call to windows_delete_thread.
4727
4728 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4729
4730         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4731
4732 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4733
4734         * symfile.c (find_separate_debug_file): Use canonical path of
4735         sysroot with child_path instead of gdb_sysroot if it is valid.
4736
4737 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4738
4739         * symfile.c (find_separate_debug_file): Use child_path to
4740         determine if an object file is under a sysroot.
4741
4742 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4743
4744         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4745         unittests/child-path-selftests.c.
4746         * common/pathstuff.c (child_path): New function.
4747         * common/pathstuff.h (child_path): New prototype.
4748         * unittests/child-path-selftests.c: New file.
4749
4750 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4751
4752         * symfile.c (find_separate_debug_file): Look for separate debug
4753         files in debug directories under the sysroot.
4754
4755 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4756
4757         * symtab.h (struct minimal_symbol data_p): New const method.
4758         (struct minimal_symbol text_p): Likewise.
4759         * symtab.c (output_source_filename): Use file name style
4760         to print file name.
4761         (print_symbol_info): Likewise.
4762         (print_msymbol_info): Use address style to print addresses.
4763         Use function name style to print executable text symbols.
4764         (expand_symtab_containing_pc): Use data_p.
4765         (find_pc_sect_compunit_symtab): Likewise.
4766
4767 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4768
4769         * breakpoint.c (describe_other_breakpoints): Use address style
4770         to print addresses.
4771         (say_where): Likewise.
4772
4773 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4774
4775         * ada-typeprint.c (print_func_type): Print function name
4776         style to print function name.
4777         * c-typeprint.c (c_print_type_1): Likewise.
4778
4779 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4780
4781         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4782         for execve.
4783
4784 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4785
4786         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4787         type_stack.
4788
4789 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4790
4791         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4792         TYPE_CODE_REF types.
4793
4794 2019-02-08  Jim Wilson  <jimw@sifive.com>
4795
4796         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4797         (riscv_linux_fregset): New.
4798         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4799
4800 2019-02-07  Tom Tromey  <tom@tromey.com>
4801
4802         * thread.c (thread_cancel_execution_command): Update.
4803         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4804         methods.
4805         (struct thread_fsm_ops): Remove.
4806         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4807         (thread_fsm_should_stop, thread_fsm_return_value)
4808         (thread_fsm_set_finished, thread_fsm_finished_p)
4809         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4810         Don't declare.
4811         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4812         * infrun.c (clear_proceed_status_thread)
4813         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4814         (print_stop_event): Update.
4815         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4816         Add constructor.
4817         (step_command_fsm_ops): Remove.
4818         (new_step_command_fsm): Remove.
4819         (step_1): Update.
4820         (step_command_fsm::should_stop): Rename from
4821         step_command_fsm_should_stop.
4822         (step_command_fsm::clean_up): Rename from
4823         step_command_fsm_clean_up.
4824         (step_command_fsm::do_async_reply_reason): Rename from
4825         step_command_fsm_async_reply_reason.
4826         (struct until_next_fsm): Inherit from thread_fsm.  Add
4827         constructor.
4828         (until_next_fsm_ops): Remove.
4829         (new_until_next_fsm): Remove.
4830         (until_next_fsm::should_stop): Rename from
4831         until_next_fsm_should_stop.
4832         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4833         (until_next_fsm::do_async_reply_reason): Rename from
4834         until_next_fsm_async_reply_reason.
4835         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4836         constructor.  Change type of breakpoint.
4837         (finish_command_fsm_ops): Remove.
4838         (new_finish_command_fsm): Remove.
4839         (finish_command_fsm::should_stop): Rename from
4840         finish_command_fsm_should_stop.
4841         (finish_command_fsm::clean_up): Rename from
4842         finish_command_fsm_clean_up.
4843         (finish_command_fsm::return_value): Rename from
4844         finish_command_fsm_return_value.
4845         (finish_command_fsm::do_async_reply_reason): Rename from
4846         finish_command_fsm_async_reply_reason.
4847         (finish_command): Update.
4848         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4849         Add constructor.
4850         (call_thread_fsm_ops): Remove.
4851         (call_thread_fsm::call_thread_fsm): Rename from
4852         new_call_thread_fsm.
4853         (call_thread_fsm::should_stop): Rename from
4854         call_thread_fsm_should_stop.
4855         (call_thread_fsm::should_notify_stop): Rename from
4856         call_thread_fsm_should_notify_stop.
4857         (run_inferior_call, call_function_by_hand_dummy): Update.
4858         * cli/cli-interp.c (should_print_stop_to_console): Update.
4859         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4860         Add constructor.  Change type of location_breakpoint,
4861         caller_breakpoint.
4862         (until_break_fsm_ops): Remove.
4863         (new_until_break_fsm): Remove.
4864         (until_break_fsm::should_stop): Rename from
4865         until_break_fsm_should_stop.
4866         (until_break_fsm::clean_up): Rename from
4867         until_break_fsm_clean_up.
4868         (until_break_fsm::do_async_reply_reason): Rename from
4869         until_break_fsm_async_reply_reason.
4870         (until_break_command): Update.
4871         * thread-fsm.c: Remove.
4872         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4873
4874 2019-02-07  Tom Tromey  <tom@tromey.com>
4875
4876         * yy-remap.h: Add include guard.
4877         * xtensa-tdep.h: Add include guard.
4878         * xcoffread.h: Rename include guard.
4879         * varobj-iter.h: Add include guard.
4880         * tui/tui.h: Rename include guard.
4881         * tui/tui-winsource.h: Rename include guard.
4882         * tui/tui-wingeneral.h: Rename include guard.
4883         * tui/tui-windata.h: Rename include guard.
4884         * tui/tui-win.h: Rename include guard.
4885         * tui/tui-stack.h: Rename include guard.
4886         * tui/tui-source.h: Rename include guard.
4887         * tui/tui-regs.h: Rename include guard.
4888         * tui/tui-out.h: Rename include guard.
4889         * tui/tui-layout.h: Rename include guard.
4890         * tui/tui-io.h: Rename include guard.
4891         * tui/tui-hooks.h: Rename include guard.
4892         * tui/tui-file.h: Rename include guard.
4893         * tui/tui-disasm.h: Rename include guard.
4894         * tui/tui-data.h: Rename include guard.
4895         * tui/tui-command.h: Rename include guard.
4896         * tic6x-tdep.h: Add include guard.
4897         * target/waitstatus.h: Rename include guard.
4898         * target/wait.h: Rename include guard.
4899         * target/target.h: Rename include guard.
4900         * target/resume.h: Rename include guard.
4901         * target-float.h: Rename include guard.
4902         * stabsread.h: Add include guard.
4903         * rs6000-tdep.h: Add include guard.
4904         * riscv-fbsd-tdep.h: Add include guard.
4905         * regformats/regdef.h: Rename include guard.
4906         * record.h: Rename include guard.
4907         * python/python.h: Rename include guard.
4908         * python/python-internal.h: Rename include guard.
4909         * python/py-stopevent.h: Rename include guard.
4910         * python/py-ref.h: Rename include guard.
4911         * python/py-record.h: Rename include guard.
4912         * python/py-record-full.h: Rename include guard.
4913         * python/py-record-btrace.h: Rename include guard.
4914         * python/py-instruction.h: Rename include guard.
4915         * python/py-events.h: Rename include guard.
4916         * python/py-event.h: Rename include guard.
4917         * procfs.h: Add include guard.
4918         * proc-utils.h: Add include guard.
4919         * p-lang.h: Add include guard.
4920         * or1k-tdep.h: Rename include guard.
4921         * observable.h: Rename include guard.
4922         * nto-tdep.h: Rename include guard.
4923         * nat/x86-linux.h: Rename include guard.
4924         * nat/x86-linux-dregs.h: Rename include guard.
4925         * nat/x86-gcc-cpuid.h: Add include guard.
4926         * nat/x86-dregs.h: Rename include guard.
4927         * nat/x86-cpuid.h: Rename include guard.
4928         * nat/ppc-linux.h: Rename include guard.
4929         * nat/mips-linux-watch.h: Rename include guard.
4930         * nat/linux-waitpid.h: Rename include guard.
4931         * nat/linux-ptrace.h: Rename include guard.
4932         * nat/linux-procfs.h: Rename include guard.
4933         * nat/linux-osdata.h: Rename include guard.
4934         * nat/linux-nat.h: Rename include guard.
4935         * nat/linux-namespaces.h: Rename include guard.
4936         * nat/linux-btrace.h: Rename include guard.
4937         * nat/glibc_thread_db.h: Rename include guard.
4938         * nat/gdb_thread_db.h: Rename include guard.
4939         * nat/gdb_ptrace.h: Rename include guard.
4940         * nat/fork-inferior.h: Rename include guard.
4941         * nat/amd64-linux-siginfo.h: Rename include guard.
4942         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4943         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4944         * nat/aarch64-linux.h: Rename include guard.
4945         * nat/aarch64-linux-hw-point.h: Rename include guard.
4946         * mn10300-tdep.h: Add include guard.
4947         * mips-linux-tdep.h: Add include guard.
4948         * mi/mi-parse.h: Rename include guard.
4949         * mi/mi-out.h: Rename include guard.
4950         * mi/mi-main.h: Rename include guard.
4951         * mi/mi-interp.h: Rename include guard.
4952         * mi/mi-getopt.h: Rename include guard.
4953         * mi/mi-console.h: Rename include guard.
4954         * mi/mi-common.h: Rename include guard.
4955         * mi/mi-cmds.h: Rename include guard.
4956         * mi/mi-cmd-break.h: Rename include guard.
4957         * m2-lang.h: Add include guard.
4958         * location.h: Rename include guard.
4959         * linux-record.h: Rename include guard.
4960         * linux-nat.h: Add include guard.
4961         * linux-fork.h: Add include guard.
4962         * i386-darwin-tdep.h: Rename include guard.
4963         * hppa-linux-offsets.h: Add include guard.
4964         * guile/guile.h: Rename include guard.
4965         * guile/guile-internal.h: Rename include guard.
4966         * gnu-nat.h: Rename include guard.
4967         * gdb-stabs.h: Rename include guard.
4968         * frv-tdep.h: Add include guard.
4969         * f-lang.h: Add include guard.
4970         * event-loop.h: Add include guard.
4971         * darwin-nat.h: Rename include guard.
4972         * cp-abi.h: Rename include guard.
4973         * config/sparc/nm-sol2.h: Rename include guard.
4974         * config/nm-nto.h: Rename include guard.
4975         * config/nm-linux.h: Add include guard.
4976         * config/i386/nm-i386gnu.h: Rename include guard.
4977         * config/djgpp/nl_types.h: Rename include guard.
4978         * config/djgpp/langinfo.h: Rename include guard.
4979         * compile/gcc-cp-plugin.h: Add include guard.
4980         * compile/gcc-c-plugin.h: Add include guard.
4981         * compile/compile.h: Rename include guard.
4982         * compile/compile-object-run.h: Rename include guard.
4983         * compile/compile-object-load.h: Rename include guard.
4984         * compile/compile-internal.h: Rename include guard.
4985         * compile/compile-cplus.h: Rename include guard.
4986         * compile/compile-c.h: Rename include guard.
4987         * common/xml-utils.h: Rename include guard.
4988         * common/x86-xstate.h: Rename include guard.
4989         * common/version.h: Rename include guard.
4990         * common/vec.h: Rename include guard.
4991         * common/tdesc.h: Rename include guard.
4992         * common/selftest.h: Rename include guard.
4993         * common/scoped_restore.h: Rename include guard.
4994         * common/scoped_mmap.h: Rename include guard.
4995         * common/scoped_fd.h: Rename include guard.
4996         * common/safe-iterator.h: Rename include guard.
4997         * common/run-time-clock.h: Rename include guard.
4998         * common/refcounted-object.h: Rename include guard.
4999         * common/queue.h: Rename include guard.
5000         * common/ptid.h: Rename include guard.
5001         * common/print-utils.h: Rename include guard.
5002         * common/preprocessor.h: Rename include guard.
5003         * common/pathstuff.h: Rename include guard.
5004         * common/observable.h: Rename include guard.
5005         * common/netstuff.h: Rename include guard.
5006         * common/job-control.h: Rename include guard.
5007         * common/host-defs.h: Rename include guard.
5008         * common/gdb_wait.h: Rename include guard.
5009         * common/gdb_vecs.h: Rename include guard.
5010         * common/gdb_unlinker.h: Rename include guard.
5011         * common/gdb_unique_ptr.h: Rename include guard.
5012         * common/gdb_tilde_expand.h: Rename include guard.
5013         * common/gdb_sys_time.h: Rename include guard.
5014         * common/gdb_string_view.h: Rename include guard.
5015         * common/gdb_splay_tree.h: Rename include guard.
5016         * common/gdb_setjmp.h: Rename include guard.
5017         * common/gdb_ref_ptr.h: Rename include guard.
5018         * common/gdb_optional.h: Rename include guard.
5019         * common/gdb_locale.h: Rename include guard.
5020         * common/gdb_assert.h: Rename include guard.
5021         * common/filtered-iterator.h: Rename include guard.
5022         * common/filestuff.h: Rename include guard.
5023         * common/fileio.h: Rename include guard.
5024         * common/environ.h: Rename include guard.
5025         * common/common-utils.h: Rename include guard.
5026         * common/common-types.h: Rename include guard.
5027         * common/common-regcache.h: Rename include guard.
5028         * common/common-inferior.h: Rename include guard.
5029         * common/common-gdbthread.h: Rename include guard.
5030         * common/common-exceptions.h: Rename include guard.
5031         * common/common-defs.h: Rename include guard.
5032         * common/common-debug.h: Rename include guard.
5033         * common/cleanups.h: Rename include guard.
5034         * common/buffer.h: Rename include guard.
5035         * common/btrace-common.h: Rename include guard.
5036         * common/break-common.h: Rename include guard.
5037         * cli/cli-utils.h: Rename include guard.
5038         * cli/cli-style.h: Rename include guard.
5039         * cli/cli-setshow.h: Rename include guard.
5040         * cli/cli-script.h: Rename include guard.
5041         * cli/cli-interp.h: Rename include guard.
5042         * cli/cli-decode.h: Rename include guard.
5043         * cli/cli-cmds.h: Rename include guard.
5044         * charset-list.h: Add include guard.
5045         * buildsym-legacy.h: Rename include guard.
5046         * bfin-tdep.h: Add include guard.
5047         * ax.h: Rename include guard.
5048         * arm-linux-tdep.h: Add include guard.
5049         * arm-fbsd-tdep.h: Add include guard.
5050         * arch/xtensa.h: Rename include guard.
5051         * arch/tic6x.h: Add include guard.
5052         * arch/i386.h: Add include guard.
5053         * arch/arm.h: Rename include guard.
5054         * arch/arm-linux.h: Rename include guard.
5055         * arch/arm-get-next-pcs.h: Rename include guard.
5056         * arch/amd64.h: Add include guard.
5057         * arch/aarch64-insn.h: Rename include guard.
5058         * arch-utils.h: Rename include guard.
5059         * annotate.h: Add include guard.
5060         * amd64-darwin-tdep.h: Rename include guard.
5061         * aarch64-linux-tdep.h: Add include guard.
5062         * aarch64-fbsd-tdep.h: Add include guard.
5063         * aarch32-linux-nat.h: Add include guard.
5064
5065 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5066
5067         * macrotab.c (macro_define_internal): New function that
5068         factorizes macro_define_object_internal and macro_define_function
5069         code.
5070         (macro_define_object_internal): Use macro_define_internal.
5071         (macro_define_function): Likewise.
5072
5073 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5074
5075         * macrocmd.c (extract_identifier): Return
5076         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5077         callers.
5078
5079 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5080
5081         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5082
5083 2019-02-05  Tom Tromey  <tom@tromey.com>
5084
5085         * target.c (target_stack::unpush): Move assertion earlier.
5086
5087 2019-01-30  Tom Tromey  <tom@tromey.com>
5088
5089         PR python/23615:
5090         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5091         (gdbpy_parse_and_eval): Likewise.
5092         * python/python-internal.h (gdbpy_allow_threads): New class.
5093
5094 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5095
5096         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5097         (aarch64_fbsd_fpregmap): Move earlier.
5098         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5099         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5100         instead of individual calls to trad_frame_set_reg_addr.
5101         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5102         earlier.
5103         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5104         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5105         instead of individual calls to trad_frame_set_reg_addr.
5106
5107 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5108
5109         * CONTRIBUTE: Replace contribution list with wiki link.
5110
5111 2019-01-25  Tom Tromey  <tom@tromey.com>
5112
5113         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5114
5115 2019-01-25  Tom Tromey  <tom@tromey.com>
5116
5117         * xtensa-linux-nat.c: Fix common/ includes.
5118         * xml-support.h: Fix common/ includes.
5119         * xml-support.c: Fix common/ includes.
5120         * x86-linux-nat.c: Fix common/ includes.
5121         * windows-nat.c: Fix common/ includes.
5122         * varobj.h: Fix common/ includes.
5123         * varobj.c: Fix common/ includes.
5124         * value.c: Fix common/ includes.
5125         * valops.c: Fix common/ includes.
5126         * utils.c: Fix common/ includes.
5127         * unittests/xml-utils-selftests.c: Fix common/ includes.
5128         * unittests/utils-selftests.c: Fix common/ includes.
5129         * unittests/unpack-selftests.c: Fix common/ includes.
5130         * unittests/tracepoint-selftests.c: Fix common/ includes.
5131         * unittests/style-selftests.c: Fix common/ includes.
5132         * unittests/string_view-selftests.c: Fix common/ includes.
5133         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5134         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5135         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5136         * unittests/rsp-low-selftests.c: Fix common/ includes.
5137         * unittests/parse-connection-spec-selftests.c: Fix common/
5138         includes.
5139         * unittests/optional-selftests.c: Fix common/ includes.
5140         * unittests/offset-type-selftests.c: Fix common/ includes.
5141         * unittests/observable-selftests.c: Fix common/ includes.
5142         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5143         * unittests/memrange-selftests.c: Fix common/ includes.
5144         * unittests/memory-map-selftests.c: Fix common/ includes.
5145         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5146         * unittests/function-view-selftests.c: Fix common/ includes.
5147         * unittests/environ-selftests.c: Fix common/ includes.
5148         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5149         * unittests/common-utils-selftests.c: Fix common/ includes.
5150         * unittests/cli-utils-selftests.c: Fix common/ includes.
5151         * unittests/array-view-selftests.c: Fix common/ includes.
5152         * ui-file.c: Fix common/ includes.
5153         * tui/tui-io.c: Fix common/ includes.
5154         * tracepoint.h: Fix common/ includes.
5155         * tracepoint.c: Fix common/ includes.
5156         * tracefile-tfile.c: Fix common/ includes.
5157         * top.h: Fix common/ includes.
5158         * top.c: Fix common/ includes.
5159         * thread.c: Fix common/ includes.
5160         * target/waitstatus.h: Fix common/ includes.
5161         * target/waitstatus.c: Fix common/ includes.
5162         * target.h: Fix common/ includes.
5163         * target.c: Fix common/ includes.
5164         * target-memory.c: Fix common/ includes.
5165         * target-descriptions.c: Fix common/ includes.
5166         * symtab.h: Fix common/ includes.
5167         * symfile.c: Fix common/ includes.
5168         * stap-probe.c: Fix common/ includes.
5169         * spu-linux-nat.c: Fix common/ includes.
5170         * sparc-nat.c: Fix common/ includes.
5171         * source.c: Fix common/ includes.
5172         * solib.c: Fix common/ includes.
5173         * solib-target.c: Fix common/ includes.
5174         * ser-unix.c: Fix common/ includes.
5175         * ser-tcp.c: Fix common/ includes.
5176         * ser-pipe.c: Fix common/ includes.
5177         * ser-base.c: Fix common/ includes.
5178         * selftest-arch.c: Fix common/ includes.
5179         * s12z-tdep.c: Fix common/ includes.
5180         * rust-exp.y: Fix common/ includes.
5181         * rs6000-aix-tdep.c: Fix common/ includes.
5182         * riscv-tdep.c: Fix common/ includes.
5183         * remote.c: Fix common/ includes.
5184         * remote-notif.h: Fix common/ includes.
5185         * remote-fileio.h: Fix common/ includes.
5186         * remote-fileio.c: Fix common/ includes.
5187         * regcache.h: Fix common/ includes.
5188         * regcache.c: Fix common/ includes.
5189         * record-btrace.c: Fix common/ includes.
5190         * python/python.c: Fix common/ includes.
5191         * python/py-type.c: Fix common/ includes.
5192         * python/py-inferior.c: Fix common/ includes.
5193         * progspace.h: Fix common/ includes.
5194         * producer.c: Fix common/ includes.
5195         * procfs.c: Fix common/ includes.
5196         * proc-api.c: Fix common/ includes.
5197         * printcmd.c: Fix common/ includes.
5198         * ppc-linux-nat.c: Fix common/ includes.
5199         * parser-defs.h: Fix common/ includes.
5200         * osdata.c: Fix common/ includes.
5201         * obsd-nat.c: Fix common/ includes.
5202         * nat/x86-linux.c: Fix common/ includes.
5203         * nat/x86-linux-dregs.c: Fix common/ includes.
5204         * nat/x86-dregs.h: Fix common/ includes.
5205         * nat/x86-dregs.c: Fix common/ includes.
5206         * nat/ppc-linux.c: Fix common/ includes.
5207         * nat/mips-linux-watch.h: Fix common/ includes.
5208         * nat/mips-linux-watch.c: Fix common/ includes.
5209         * nat/linux-waitpid.c: Fix common/ includes.
5210         * nat/linux-ptrace.h: Fix common/ includes.
5211         * nat/linux-ptrace.c: Fix common/ includes.
5212         * nat/linux-procfs.c: Fix common/ includes.
5213         * nat/linux-personality.c: Fix common/ includes.
5214         * nat/linux-osdata.c: Fix common/ includes.
5215         * nat/linux-namespaces.c: Fix common/ includes.
5216         * nat/linux-btrace.h: Fix common/ includes.
5217         * nat/linux-btrace.c: Fix common/ includes.
5218         * nat/fork-inferior.c: Fix common/ includes.
5219         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5220         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5221         * nat/aarch64-linux.c: Fix common/ includes.
5222         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5223         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5224         * namespace.h: Fix common/ includes.
5225         * mips-linux-tdep.c: Fix common/ includes.
5226         * minsyms.c: Fix common/ includes.
5227         * mi/mi-parse.h: Fix common/ includes.
5228         * mi/mi-main.c: Fix common/ includes.
5229         * mi/mi-cmd-env.c: Fix common/ includes.
5230         * memrange.h: Fix common/ includes.
5231         * memattr.c: Fix common/ includes.
5232         * maint.h: Fix common/ includes.
5233         * maint.c: Fix common/ includes.
5234         * main.c: Fix common/ includes.
5235         * machoread.c: Fix common/ includes.
5236         * location.c: Fix common/ includes.
5237         * linux-thread-db.c: Fix common/ includes.
5238         * linux-nat.c: Fix common/ includes.
5239         * linux-fork.c: Fix common/ includes.
5240         * inline-frame.c: Fix common/ includes.
5241         * infrun.c: Fix common/ includes.
5242         * inflow.c: Fix common/ includes.
5243         * inferior.h: Fix common/ includes.
5244         * inferior.c: Fix common/ includes.
5245         * infcmd.c: Fix common/ includes.
5246         * inf-ptrace.c: Fix common/ includes.
5247         * inf-child.c: Fix common/ includes.
5248         * ia64-linux-nat.c: Fix common/ includes.
5249         * i387-tdep.c: Fix common/ includes.
5250         * i386-tdep.c: Fix common/ includes.
5251         * i386-linux-tdep.c: Fix common/ includes.
5252         * i386-linux-nat.c: Fix common/ includes.
5253         * i386-go32-tdep.c: Fix common/ includes.
5254         * i386-fbsd-tdep.c: Fix common/ includes.
5255         * i386-fbsd-nat.c: Fix common/ includes.
5256         * guile/scm-type.c: Fix common/ includes.
5257         * guile/guile.c: Fix common/ includes.
5258         * go32-nat.c: Fix common/ includes.
5259         * gnu-nat.c: Fix common/ includes.
5260         * gdbthread.h: Fix common/ includes.
5261         * gdbarch-selftests.c: Fix common/ includes.
5262         * gdb_usleep.c: Fix common/ includes.
5263         * gdb_select.h: Fix common/ includes.
5264         * gdb_bfd.c: Fix common/ includes.
5265         * gcore.c: Fix common/ includes.
5266         * fork-child.c: Fix common/ includes.
5267         * findvar.c: Fix common/ includes.
5268         * fbsd-nat.c: Fix common/ includes.
5269         * event-top.c: Fix common/ includes.
5270         * event-loop.c: Fix common/ includes.
5271         * dwarf2read.c: Fix common/ includes.
5272         * dwarf2loc.c: Fix common/ includes.
5273         * dwarf2-frame.c: Fix common/ includes.
5274         * dwarf-index-cache.c: Fix common/ includes.
5275         * dtrace-probe.c: Fix common/ includes.
5276         * disasm-selftests.c: Fix common/ includes.
5277         * defs.h: Fix common/ includes.
5278         * csky-tdep.c: Fix common/ includes.
5279         * cp-valprint.c: Fix common/ includes.
5280         * cp-support.h: Fix common/ includes.
5281         * cp-support.c: Fix common/ includes.
5282         * corelow.c: Fix common/ includes.
5283         * completer.h: Fix common/ includes.
5284         * completer.c: Fix common/ includes.
5285         * compile/compile.c: Fix common/ includes.
5286         * compile/compile-loc2c.c: Fix common/ includes.
5287         * compile/compile-cplus-types.c: Fix common/ includes.
5288         * compile/compile-cplus-symbols.c: Fix common/ includes.
5289         * command.h: Fix common/ includes.
5290         * cli/cli-dump.c: Fix common/ includes.
5291         * cli/cli-cmds.c: Fix common/ includes.
5292         * charset.c: Fix common/ includes.
5293         * build-id.c: Fix common/ includes.
5294         * btrace.h: Fix common/ includes.
5295         * btrace.c: Fix common/ includes.
5296         * breakpoint.h: Fix common/ includes.
5297         * breakpoint.c: Fix common/ includes.
5298         * ax.h:
5299         (enum agent_op): Fix common/ includes.
5300         * ax-general.c (struct aop_map): Fix common/ includes.
5301         * ax-gdb.c: Fix common/ includes.
5302         * auxv.c: Fix common/ includes.
5303         * auto-load.c: Fix common/ includes.
5304         * arm-tdep.c: Fix common/ includes.
5305         * arch/riscv.c: Fix common/ includes.
5306         * arch/ppc-linux-common.c: Fix common/ includes.
5307         * arch/i386.c: Fix common/ includes.
5308         * arch/arm.c: Fix common/ includes.
5309         * arch/arm-linux.c: Fix common/ includes.
5310         * arch/arm-get-next-pcs.c: Fix common/ includes.
5311         * arch/amd64.c: Fix common/ includes.
5312         * arch/aarch64.c: Fix common/ includes.
5313         * arch/aarch64-insn.c: Fix common/ includes.
5314         * arch-utils.c: Fix common/ includes.
5315         * amd64-windows-tdep.c: Fix common/ includes.
5316         * amd64-tdep.c: Fix common/ includes.
5317         * amd64-sol2-tdep.c: Fix common/ includes.
5318         * amd64-obsd-tdep.c: Fix common/ includes.
5319         * amd64-nbsd-tdep.c: Fix common/ includes.
5320         * amd64-linux-tdep.c: Fix common/ includes.
5321         * amd64-linux-nat.c: Fix common/ includes.
5322         * amd64-fbsd-tdep.c: Fix common/ includes.
5323         * amd64-fbsd-nat.c: Fix common/ includes.
5324         * amd64-dicos-tdep.c: Fix common/ includes.
5325         * amd64-darwin-tdep.c: Fix common/ includes.
5326         * agent.c: Fix common/ includes.
5327         * ada-lang.h: Fix common/ includes.
5328         * ada-lang.c: Fix common/ includes.
5329         * aarch64-tdep.c: Fix common/ includes.
5330
5331 2019-01-25  Tom Tromey  <tom@tromey.com>
5332
5333         * common/create-version.sh: Use common/version.h.
5334
5335 2019-01-24  Pedro Alves  <palves@redhat.com>
5336
5337         * infrun.c (signal_stop, signal_print, signal_program)
5338         (signal_catch, signal_pass): Now arrays instead of pointers.
5339         (update_signals_program_target, do_target_resume)
5340         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5341         * linux-nat.c (linux_nat_target::pass_signals)
5342         (linux_nat_target::create_inferior, linux_nat_target::attach):
5343         Adjust.
5344         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5345         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5346         * procfs.c (procfs_target::pass_signals): Adjust.
5347         * record-full.c (record_full_target::resume): Adjust.
5348         * remote.c (remote_target::pass_signals)
5349         (remote_target::program_signals): Adjust.
5350         * target-debug.h (target_debug_print_signals): Now takes a
5351         gdb::array_view as parameter.  Adjust.
5352         * target.h (target_ops) <pass_signals, program_signals>: Replace
5353         pointer and length parameters with gdb::array_view.
5354         (target_pass_signals, target_program_signals): Likewise.
5355         * target-delegates.c: Regenerate.
5356
5357 2019-01-24  Pedro Alves  <palves@redhat.com>
5358
5359         * common/forward-scope-exit.h
5360         (forward_scope_exit::forward_scope_exit): Pass arguments to
5361         m_bind_function directly, instead of creating a std::bind and
5362         copying that.
5363
5364 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5365
5366         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5367         for static members.
5368         (pass_in_v_vfp_candidate): Likewise.
5369
5370 2019-01-23  Tom Tromey  <tom@tromey.com>
5371             Pedro Alves  <palves@redhat.com>
5372
5373         * regcache.c (class regcache_invalidator): Remove.
5374         (regcache::raw_write): Use make_scope_exit.
5375
5376 2019-01-23  Tom Tromey  <tom@tromey.com>
5377
5378         * ui-out.h (class ui_out_emit_type): Update comment.
5379
5380 2019-01-23  Tom Tromey  <tom@tromey.com>
5381
5382         * infrun.c (fetch_inferior_event): Update comment.
5383
5384 2019-01-23  Tom Tromey  <tom@tromey.com>
5385             Pedro Alves  <palves@redhat.com>
5386
5387         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5388         parameter.
5389         (fetch_inferior_event): Use SCOPE_EXIT.
5390
5391
5392 2019-01-23  Tom Tromey  <tom@tromey.com>
5393             Pedro Alves  <palves@redhat.com>
5394
5395         * infrun.c (disable_thread_events): Delete.
5396         (stop_all_threads): Use SCOPE_EXIT.
5397
5398 2019-01-23  Tom Tromey  <tom@tromey.com>
5399             Pedro Alves  <palves@redhat.com>
5400
5401         * symfile.c: Include forward-scope-exit.h.
5402         (clear_symtab_users_cleanup): Replace forward declaration with
5403         a FORWARD_SCOPE_EXIT.
5404         (syms_from_objfile_1): Use the forward_scope_exit and
5405         gdb::optional instead of cleanup_function.
5406         (reread_symbols): Use the forward_scope_exit instead of
5407         cleanup_function.
5408         (clear_symtab_users_cleanup): Remove function.
5409
5410 2019-01-23  Tom Tromey  <tom@tromey.com>
5411             Pedro Alves  <palves@redhat.com>
5412
5413         * linux-nat.c: Include scope-exit.h.
5414         (cleanup_target_stop): Remove.
5415         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5416         SCOPE_EXIT.
5417
5418 2019-01-23  Tom Tromey  <tom@tromey.com>
5419             Pedro Alves  <palves@redhat.com>
5420
5421         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5422         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5423
5424 2019-01-23  Tom Tromey  <tom@tromey.com>
5425             Andrew Burgess  <andrew.burgess@embecosm.com>
5426             Pedro Alves  <palves@redhat.com>
5427
5428         * infrun.c (fetch_inferior_event): Use scope_exit.
5429         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5430         * top.c (execute_command): Use scope_exit.
5431         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5432         * utils.c (do_bpstat_clear_actions_cleanup)
5433         (make_bpstat_clear_actions_cleanup): Remove.
5434
5435 2019-01-23  Tom Tromey  <tom@tromey.com>
5436             Pedro Alves  <palves@redhat.com>
5437
5438         * infrun.c: Include "common/scope-exit.h"
5439         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5440         (wait_for_inferior): Use SCOPE_EXIT.
5441         (fetch_inferior_event): Use scope_exit.
5442
5443 2019-01-23  Tom Tromey  <tom@tromey.com>
5444             Pedro Alves  <palves@redhat.com>
5445
5446         * breakpoint.c (create_breakpoint): Remove cleanup.
5447
5448 2019-01-23  Tom Tromey  <tom@tromey.com>
5449             Andrew Burgess  <andrew.burgess@embecosm.com>
5450             Pedro Alves  <palves@redhat.com>
5451
5452 2019-01-23  Pedro Alves  <palves@redhat.com>
5453
5454         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5455
5456 2019-01-23  Pedro Alves  <palves@redhat.com>
5457             Andrew Burgess  <andrew.burgess@embecosm.com>
5458
5459         * gdbthread.h: Include "common/forward-scope-exit.h".
5460         (scoped_finish_thread_state): Redefine custom class in terms of
5461         forward_scope_exit.
5462
5463 2019-01-23  Pedro Alves  <palves@redhat.com>
5464             Andrew Burgess  <andrew.burgess@embecosm.com>
5465
5466         * common/forward-scope-exit.h: New file.
5467
5468 2019-01-23  Pedro Alves  <palves@redhat.com>
5469             Andrew Burgess  <andrew.burgess@embecosm.com>
5470             Tom Tromey  <tom@tromey.com>
5471
5472         * common/scope-exit.h: New file.
5473
5474 2019-01-23  Pedro Alves  <palves@redhat.com>
5475
5476         * common/preprocessor.h (ESC): Rename to ...
5477         (ESC_PARENS): ... this.
5478         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5479         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5480
5481 2019-01-23  Tom Tromey  <tom@tromey.com>
5482
5483         * language.h (class scoped_switch_to_sym_language_if_auto):
5484         Initialize m_lang in both cases.
5485
5486 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5487
5488         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5489         with XCNEW.
5490
5491 2019-01-22  Tom Tromey  <tom@tromey.com>
5492
5493         * corelow.c: Do not include sys/file.h.
5494
5495 2019-01-22  Tom Tromey  <tom@tromey.com>
5496
5497         * tui/tui-wingeneral.h: Include gdb_curses.h.
5498
5499 2019-01-22  Tom Tromey  <tom@tromey.com>
5500
5501         * source-cache.h (class source_cache) <get_source_lines,
5502         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5503
5504 2019-01-22  Tom Tromey  <tom@tromey.com>
5505
5506         * remote-fileio.h (struct remote_target): Declare.
5507
5508 2019-01-22  Tom Tromey  <tom@tromey.com>
5509
5510         * python/py-arch.c: Do not include py-ref.h.
5511         * python/py-bpevent.c: Do not include py-ref.h.
5512         * python/py-cmd.c: Do not include py-ref.h.
5513         * python/py-continueevent.c: Do not include py-ref.h.
5514         * python/py-event.h: Do not include py-ref.h.
5515         * python/py-evtregistry.c: Do not include py-ref.h.
5516         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5517         * python/py-frame.c: Do not include py-ref.h.
5518         * python/py-framefilter.c: Do not include py-ref.h.
5519         * python/py-function.c: Do not include py-ref.h.
5520         * python/py-infevents.c: Do not include py-ref.h.
5521         * python/py-linetable.c: Do not include py-ref.h.
5522         * python/py-objfile.c: Do not include py-ref.h.
5523         * python/py-param.c: Do not include py-ref.h.
5524         * python/py-prettyprint.c: Do not include py-ref.h.
5525         * python/py-progspace.c: Do not include py-ref.h.
5526         * python/py-symbol.c: Do not include py-ref.h.
5527         * python/py-symtab.c: Do not include py-ref.h.
5528         * python/py-type.c: Do not include py-ref.h.
5529         * python/py-unwind.c: Do not include py-ref.h.
5530         * python/py-utils.c: Do not include py-ref.h.
5531         * python/py-value.c: Do not include py-ref.h.
5532         * python/py-varobj.c: Do not include py-ref.h.
5533         * python/py-xmethods.c: Do not include py-ref.h.
5534         * python/python.c: Do not include py-ref.h.
5535         * varobj.c: Do not include py-ref.h.
5536
5537 2019-01-22  Tom Tromey  <tom@tromey.com>
5538
5539         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5540         keyword for bcache.
5541
5542 2019-01-22  Tom Tromey  <tom@tromey.com>
5543
5544         * compile/compile-cplus-types.c: Remove a comment by #include.
5545
5546 2019-01-22  Tom Tromey  <tom@tromey.com>
5547
5548         * compile/gcc-c-plugin.h: Include compile-internal.h.
5549
5550 2019-01-22  Tom Tromey  <tom@tromey.com>
5551
5552         * stabsread.c (EXTERN): Do not define.
5553         (symnum, next_symbol_text_func, processing_gcc_compilation)
5554         (within_function, global_sym_chain, global_stabs)
5555         (previous_stab_code, this_object_header_files)
5556         (n_this_object_header_files)
5557         (n_allocated_this_object_header_files): Define.
5558         * stabsread.h (EXTERN): Never define.  Use "extern".
5559
5560 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5561
5562         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5563         history_value.
5564
5565 2019-01-21  Tom Tromey  <tom@tromey.com>
5566
5567         * ui-out.c: Fix includes.
5568         * tui/tui-source.c: Fix includes.
5569         * target.c: Fix includes.
5570         * remote.c: Fix includes.
5571         * regcache.c: Fix includes.
5572         * python/py-block.c: Fix includes.
5573         * printcmd.c: Fix includes.
5574         * or1k-tdep.c: Fix includes.
5575         * mi/mi-main.c: Fix includes.
5576         * m32r-tdep.c: Fix includes.
5577         * csky-tdep.c: Fix includes.
5578         * compile/compile-cplus-types.c: Fix includes.
5579         * cli/cli-interp.c: Fix includes.
5580
5581 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5582
5583         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5584         for padding.
5585
5586 2019-01-16  Tom Tromey  <tom@tromey.com>
5587
5588         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5589         earlier.
5590         (struct objfile) <msymbols_range>: Move from top level.
5591         <msymbols>: New method.
5592         (class objfile_msymbols): Remove.
5593         * symtab.c (default_collect_symbol_completion_matches_break_on):
5594         Update.
5595         * symmisc.c (dump_msymbols): Update.
5596         * stabsread.c (scan_file_globals): Update.
5597         * objc-lang.c (info_selectors_command, info_classes_command)
5598         (find_methods): Update.
5599         * minsyms.c (find_solib_trampoline_target): Update.
5600         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5601         * coffread.c (coff_symfile_read): Update.
5602         * ada-lang.c (ada_lookup_simple_minsym)
5603         (ada_collect_symbol_completion_matches): Update.
5604
5605 2019-01-16  Tom Tromey  <tom@tromey.com>
5606
5607         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5608         type.  Remove no-argument constructor.
5609         <iterator::operator++>: Simplify.
5610         <begin>: Update.
5611         <end>: Use minimal_symbol_count.
5612
5613 2019-01-16  Tom Tromey  <tom@tromey.com>
5614
5615         * objfiles.h (struct objfile) <psymtabs>: New method.
5616         (class objfile_psymtabs): Remove.
5617         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5618         typedef.
5619         <range>: New method.
5620         (require_partial_symbols): Change return type.
5621         * psymtab.c (require_partial_symbols)
5622         (psym_expand_symtabs_matching): Update.
5623         * mdebugread.c (parse_partial_symbols): Update.
5624         * dbxread.c (dbx_end_psymtab): Update.
5625
5626 2019-01-15  Tom Tromey  <tom@tromey.com>
5627
5628         * symtab.c (lookup_objfile_from_block)
5629         (lookup_symbol_in_objfile_symtabs)
5630         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5631         (find_line_symtab, info_sources_command)
5632         (default_collect_symbol_completion_matches_break_on)
5633         (make_source_files_completion_list): Update.
5634         * symmisc.c (print_objfile_statistics, dump_objfile)
5635         (maintenance_print_symbols, maintenance_info_symtabs)
5636         (maintenance_check_symtabs, maintenance_info_line_tables):
5637         Update.
5638         * source.c (select_source_symtab)
5639         (forget_cached_source_info_for_objfile): Update.
5640         * objfiles.h (class objfile_compunits): Remove.
5641         (struct objfile) <compunits_range>: New typedef.
5642         (compunits): New method.
5643         * objfiles.c (objfile_relocate1): Update.
5644         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5645         * maint.c (count_symtabs_and_blocks): Update.
5646         * linespec.c (iterate_over_all_matching_symtabs): Update.
5647         * cp-support.c (add_symbol_overload_list_qualified): Update.
5648         * coffread.c (coff_symtab_read): Update.
5649         * ada-lang.c (add_nonlocal_symbols)
5650         (ada_collect_symbol_completion_matches)
5651         (ada_add_global_exceptions): Update.
5652
5653 2019-01-15  Tom Tromey  <tom@tromey.com>
5654
5655         * progspace.h (program_space) <objfiles_safe_range>: New
5656         typedef.
5657         <objfiles_safe>: New method.
5658         * objfiles.h (class all_objfiles_safe): Remove.
5659         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5660         * jit.c (jit_inferior_exit_hook): Update.
5661
5662 2019-01-17  Tom Tromey  <tom@tromey.com>
5663
5664         * progspace.h (program_space) <objfiles_range>: New typedef.
5665         <objfiles>: New method.
5666         <objfiles_head>: Rename from objfiles.
5667         (object_files): Update.
5668         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5669         * guile/scm-pretty-print.c
5670         (ppscm_find_pretty_printer_from_objfiles): Update.
5671         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5672         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5673         Update.
5674         * python/py-progspace.c (pspy_get_objfiles): Update.
5675         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5676         Update.
5677         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5678         (objfpy_lookup_objfile_by_build_id): Update.
5679         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5680         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5681         Update.
5682         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5683         (expand_symtab_containing_pc, lookup_objfile_from_block)
5684         (lookup_static_symbol, basic_lookup_transparent_type)
5685         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5686         (find_line_symtab, info_sources_command)
5687         (default_collect_symbol_completion_matches_break_on)
5688         (make_source_files_completion_list, find_main_name): Update.
5689         * symmisc.c (print_symbol_bcache_statistics)
5690         (print_objfile_statistics, maintenance_print_symbols)
5691         (maintenance_print_msymbols, maintenance_print_objfiles)
5692         (maintenance_info_symtabs, maintenance_check_symtabs)
5693         (maintenance_expand_symtabs, maintenance_info_line_tables):
5694         Update.
5695         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5696         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5697         (map_overlay_command, unmap_overlay_command)
5698         (simple_overlay_update, expand_symtabs_matching)
5699         (map_symbol_filenames): Update.
5700         * symfile-debug.c (set_debug_symfile): Update.
5701         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5702         Update.
5703         * source.c (select_source_symtab, forget_cached_source_info):
5704         Update.
5705         * solib.c (solib_read_symbols): Update.
5706         * solib-spu.c (append_ocl_sos): Update.
5707         * psymtab.c (maintenance_print_psymbols)
5708         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5709         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5710         * printcmd.c (info_symbol_command): Update.
5711         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5712         Update.
5713         * objfiles.h (class all_objfiles): Remove.
5714         * objfiles.c (have_partial_symbols, have_full_symbols)
5715         (have_minimal_symbols, qsort_cmp, update_section_map)
5716         (shared_objfile_contains_address_p)
5717         (default_iterate_over_objfiles_in_search_order): Update.
5718         * objc-lang.c (info_selectors_command, info_classes_command)
5719         (find_methods): Update.
5720         * minsyms.c (find_solib_trampoline_target): Update.
5721         * maint.c (maintenance_info_sections)
5722         (maintenance_translate_address, count_symtabs_and_blocks):
5723         Update.
5724         * main.c (captured_main_1): Update.
5725         * linux-thread-db.c (try_thread_db_load_from_pdir)
5726         (has_libpthread): Update.
5727         * linespec.c (iterate_over_all_matching_symtabs)
5728         (search_minsyms_for_name): Update.
5729         * jit.c (jit_find_objf_with_entry_addr): Update.
5730         * hppa-tdep.c (find_unwind_entry)
5731         (hppa_lookup_stub_minimal_symbol): Update.
5732         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5733         Update.
5734         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5735         (elf_gnu_ifunc_resolve_by_got): Update.
5736         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5737         * dwarf-index-write.c (save_gdb_index_command): Update.
5738         * cp-support.c (add_symbol_overload_list_qualified): Update.
5739         * breakpoint.c (create_overlay_event_breakpoint)
5740         (create_longjmp_master_breakpoint)
5741         (create_std_terminate_master_breakpoint)
5742         (create_exception_master_breakpoint): Update.
5743         * blockframe.c (find_pc_partial_function): Update.
5744         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5745         (ada_collect_symbol_completion_matches)
5746         (ada_add_global_exceptions): Update.
5747
5748 2019-01-17  Tom Tromey  <tom@tromey.com>
5749
5750         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5751         declare VEC.
5752         (solib_target_parse_libraries): Change return type.
5753         (library_list_start_segment, library_list_start_section)
5754         (library_list_end_library, library_list_start_library); Update.
5755         (solib_target_free_library_list): Remove.
5756         (solib_target_parse_libraries): Remove cleanup.  Change return
5757         type.
5758         (solib_target_current_sos): Update.
5759
5760 2019-01-17  Tom Tromey  <tromey@bapiya>
5761
5762         * valprint.c: Replace "the the" with "the".
5763         * symtab.c: Replace "the the" with "the".
5764         * solib.c: Replace "the the" with "the".
5765         * solib-dsbt.c: Replace "the the" with "the".
5766         * linespec.c: Replace "the the" with "the".
5767         * dwarf2loc.h: Replace "the the" with "the".
5768         * amd64-windows-tdep.c: Replace "the the" with "the".
5769         * aarch64-tdep.c: Replace "the the" with "the".
5770
5771 2019-01-16  Keith Seitz  <keiths@redhat.com>
5772
5773         PR gdb/23773
5774         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5775         <builder>: Rename to ..
5776         <m_builder>: ... this and make private.
5777         (dwarf2_cu::get_builder): New method.  Change all users of
5778         `builder' to use this method.
5779         (dwarf2_start_symtab): Move to ...
5780         (dwarf2_cu::start_symtab): ... here.  Update all callers
5781         (setup_type_unit_groups): Move to ...
5782         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5783         callers.
5784         (dwarf2_cu::reset_builder): New method.
5785         (process_full_compunit, process_full_type_unit): Use
5786         dwarf2_cu::reset_builder.
5787         (follow_die_offset): Record the ancestor CU if it is different
5788         from the followed DIE's CU.
5789         (follow_die_sig_1): Likewise.
5790
5791 2019-01-15  Tom Tromey  <tom@tromey.com>
5792
5793         * remote.c (class remote_state) <buf>: Now a char_vector.
5794         <buf_size>: Remove.
5795         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5796         parameter.
5797         (remote_target::getpkt_or_notif_sane_1)
5798         (remote_target::getpkt_sane)
5799         (remote_target::getpkt_or_notif_sane): Likewise.
5800         (class remote_target) <putpkt>: New overload.
5801         (remote_target::read_frame): Change type of "buf_p".  Remove
5802         sizeof_p parameter.
5803         (packet_ok): New overload.
5804         (packet_check_result): New overload.
5805         Update all uses.
5806
5807 2019-01-14  Tom Tromey  <tom@tromey.com>
5808
5809         * remote-notif.c (handle_notification, remote_notif_ack)
5810         (remote_notif_parse): Make "buf" const.
5811         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5812         const.
5813         (remote_notif_parse, remote_notif_ack, handle_notification):
5814         Likewise.
5815         * remote.c (remote_notif_stop_parse): Make "buf" const.
5816         (remote_target::remote_parse_stop_reply): Make "buf" const.
5817         (remote_notif_stop_ack): Make "buf" const.
5818
5819 2019-01-14  Tom Tromey  <tom@tromey.com>
5820
5821         * remote.c (remote_console_output): Make parameter const.
5822
5823 2019-01-14  Tom Tromey  <tom@tromey.com>
5824
5825         * target-debug.h (target_debug_print_signals): Constify.
5826         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5827         * procfs.c (procfs_target::pass_signals): Update.
5828         * linux-nat.c (linux_nat_target::pass_signals): Update.
5829         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5830         * target-delegates.c: Rebuild.
5831         * remote.c (remote_target::program_signals): Update.
5832         (remote_target::pass_signals): Update.
5833         * target.c (target_pass_signals): Constify argument.
5834         (target_program_signals): Likewise.
5835         * target.h (struct target_ops) <pass_signals, program_signals>:
5836         Constify argument.
5837         (target_pass_signals, target_program_signals): Constify argument.
5838
5839 2019-01-14  Tom Tromey  <tom@tromey.com>
5840
5841         PR tui/28819:
5842         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5843
5844 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5845
5846         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5847         field.
5848         * rs6000-tdep.c: Include reggroups.h.
5849         (IS_V_ALIAS_PSEUDOREG): Define.
5850         (rs6000_register_name): Return names for the "vX" aliases.
5851         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5852         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5853         aliases.  Call default_register_reggroup_p for all other
5854         pseudo-registers.
5855         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5856         New functions.
5857         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5858         Handle "vX" aliases.
5859         (v_alias_pseudo_register_collect): New function.
5860         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5861         (rs6000_gdbarch_init): Initialize "vX" aliases as
5862         pseudo-registers.  Restore registration of
5863         rs6000_pseudo_register_reggroup_p with
5864         set_tdesc_pseudo_register_reggroup_p.
5865
5866 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5867
5868         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5869         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5870         set_gdbarch_num_pseudo_regs.
5871
5872 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5873
5874         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5875         Remove arg prefixname, add do_set and do_show.
5876         Add member functions set_list and show_list.
5877         * cli/cli-style.c (class cli_style_option): Update accordingly.
5878         (style_set_list): Move to file scope.
5879         (style_show_list): Likewise.
5880         (set_style): Call help_list.
5881         (show_style): Call cmd_show_list.
5882         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5883         Update to use the new macro.
5884
5885 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5886
5887         * ada-lang.c (_initialize_ada_language): Expand the help text
5888         for the "catch exception" command.
5889
5890 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5891
5892         * symtab.c (matching_obj_sections): Initialize obj,
5893         declare it closer to its usage.
5894
5895 2019-01-10  Tom Tromey  <tom@tromey.com>
5896
5897         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5898         (basic_inf_threads_range): Remove.
5899         (inf_threads_range, inf_non_exited_threads_range)
5900         (safe_inf_threads_range): Use next_adapter.
5901
5902 2019-01-10  Keith Seitz  <keiths@redhat.com>
5903
5904         PR gdb/23712
5905         PR symtab/23010
5906         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5907         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5908
5909 2019-01-10  Keith Seitz  <keiths@redhat.com>
5910
5911         PR gdb/23712
5912         PR symtab/23010
5913         * dictionary.c (pending_to_vector): Remove.
5914         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5915         Remove _1 suffix, replacing functions of the same name.  Update
5916         all callers.
5917         (dict_create_hashed, dict_create_hashed_expandable)
5918         (dict_create_linear, dict_create_linear_expandable, dict_free)
5919         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5920         Make functions static.
5921
5922 2019-01-10  Keith Seitz  <keiths@redhat.com>
5923
5924         PR gdb/23712
5925         PR symtab/23010
5926         * dictionary.h (struct dictionary): Replace declaration with
5927         multidictionary.
5928         (dict_create_hashed, dict_create_hashed_expandable)
5929         (dict_create_linear, dict_create_linear_expandable)
5930         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5931         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5932         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5933         taking multidictionary argument.
5934         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5935         * block.h (struct block) <dict>: Change to multidictionary
5936         and rename `multidict'.
5937         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5938         symmisc.c: Update all dictionary references to multidictionary.
5939
5940 2019-01-10  Keith Seitz  <keiths@redhat.com>
5941
5942         PR gdb/23712
5943         PR symtab/23010
5944         * dictionary.c: Include unordered_map.
5945         (pending_to_vector): New function.
5946         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5947         Rewrite the non-"_1" functions to take vector instead
5948         of linked list.
5949         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5950         "new" _1 versions of the same name.
5951         (multidictionary): Define.
5952         (std::hash<enum language): New definition.
5953         (collate_pending_symbols_by_language, mdict_create_hashed)
5954         (mdict_create_hashed_expandable, mdict_create_linear)
5955         (mdict_create_linear_expandable, mdict_free)
5956         (find_language_dictionary, create_new_language_dictionary)
5957         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5958         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5959         (mdict_size, mdict_empty): New functions.
5960         * dictionary.h (mdict_iterator): Define.
5961
5962 2019-01-10  Pedro Alves  <palves@redhat.com>
5963
5964         * breakpoint.c (read_uploaded_action)
5965         (create_tracepoint_from_upload): Adjust to use
5966         gdb::unique_xmalloc_ptr.
5967         * ctf.c (ctf_write_uploaded_tp):
5968         (SET_ARRAY_FIELD): Use emplace_back.
5969         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5970         * tracefile-tfile.c (tfile_write_uploaded_tp):
5971         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5972         gdb::unique_xmalloc_ptr.
5973         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5974         at_string, cond_string, cmd_strings>: Replace char pointers
5975         with gdb::unique_xmalloc_ptr.
5976
5977 2019-01-10  Pedro Alves  <palves@redhat.com>
5978
5979         * solib-target.c (library_list_start_library): Don't xstrdup name.
5980
5981 2019-01-10  Pedro Alves  <palves@redhat.com>
5982
5983         * mdebugread.c (parse_partial_symbols): Use
5984         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5985
5986 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5987
5988         * linux-fork.c (scoped_switch_fork_info)
5989         <~scoped_switch_fork_info>: Fix incorrect variable name.
5990
5991 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5992
5993         * linux-fork.c (scoped_switch_fork_info)
5994         <scoped_switch_fork_info>: Make explicit.
5995         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5996
5997 2019-01-10  Tom Tromey  <tom@tromey.com>
5998
5999         * objfiles.h (objfile::reset_psymtabs): Update.
6000         * objfiles.c (objfile::objfile): Update.
6001         * psymtab.h (psymtab_storage::obstack): Update.
6002         (psymtab_storage::m_obstack): Use gdb::optional.
6003         (class psymtab_storage): Update comment.  Remove objfile
6004         parameter.
6005         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6006
6007 2019-01-10  Tom Tromey  <tom@tromey.com>
6008
6009         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6010         <free_psymtabs>: Now private.
6011         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6012         (allocate_psymtab): Use new method.
6013
6014 2019-01-10  Tom Tromey  <tom@tromey.com>
6015
6016         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6017         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6018         * mdebugread.c (parse_partial_symbols): Use
6019         allocate_dependencies.
6020         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6021         allocate_dependencies.
6022         (process_psymtab_comp_unit_reader)
6023         (build_type_psymtab_dependencies): Likewise.
6024         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6025
6026 2019-01-10  Tom Tromey  <tom@tromey.com>
6027
6028         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6029         PSYMBOL_SET_LANGUAGE.
6030         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6031
6032 2019-01-10  Tom Tromey  <tom@tromey.com>
6033
6034         * psymtab.h (psymtab_storage::obstack): New method.
6035         <m_obstack>: Rename from obstack; now private.
6036         * psymtab.c (psymtab_storage): Update.
6037         * dwarf2read.c (create_addrmap_from_index)
6038         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6039         Update.
6040
6041 2019-01-10  Tom Tromey  <tom@tromey.com>
6042
6043         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6044         * objfiles.h (objfile::reset_psymtabs): New method.
6045
6046 2019-01-10  Tom Tromey  <tom@tromey.com>
6047
6048         * symmisc.c (print_symbol_bcache_statistics): Update.
6049         (print_objfile_statistics): Update.
6050         * symfile.c (reread_symbols): Update.
6051         * psymtab.h (class psymtab_storage): New.
6052         * psymtab.c (psymtab_storage): New constructor.
6053         (~psymtab_storage): New destructor.
6054         (require_partial_symbols): Update.
6055         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6056         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6057         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6058         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6059         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6060         (start_psymtab_common, end_psymtab_common)
6061         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6062         (allocate_psymtab): Update.
6063         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6064         Update.
6065         (dump_psymtab_addrmap, maintenance_print_psymbols)
6066         (maintenance_check_psymtabs): Update.
6067         (class objfile_psymtabs): Move to objfiles.h.
6068         * psympriv.h (discard_psymtab): Now inline.
6069         (psymtab_discarder::psymtab_discarder): Update.
6070         (psymtab_discarder::~psymtab_discarder): Update.
6071         (ALL_OBJFILE_PSYMTABS): Rewrite.
6072         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6073         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6074         Remove fields.
6075         <partial_symtabs>: New field.
6076         (class objfile_psymtabs): Move from psymtab.h.  Update.
6077         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6078         psymbol_cache.
6079         (objfile::~objfile): Don't destroy psymbol_cache.
6080         * mdebugread.c (parse_partial_symbols): Update.
6081         * dwarf2read.c (create_addrmap_from_index)
6082         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6083         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6084         (add_partial_subprogram, dwarf2_ranges_read): Update.
6085         * dwarf-index-write.c (write_address_map)
6086         (write_one_signatured_type, recursively_write_psymbols)
6087         (class debug_names, class debug_names, write_psymtabs_to_index):
6088         Update.
6089
6090 2019-01-10  Tom Tromey  <tom@tromey.com>
6091
6092         * symtab.h (SYMBOL_SET_NAMES): Update.
6093         (symbol_set_names): Update.
6094         (MSYMBOL_SET_NAMES): Update.
6095         * symtab.c (symbol_set_names): Change argument to be an
6096         objfile_per_bfd_storage.
6097         * psymtab.c (add_psymbol_to_bcache): Update.
6098         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6099
6100 2019-01-10  Tom Tromey  <tom@tromey.com>
6101
6102         * symtab.c (create_demangled_names_hash): Change argument to be an
6103         objfile_per_bfd_storage.
6104         (symbol_set_names): Update.
6105
6106 2019-01-10  Tom Tromey  <tom@tromey.com>
6107
6108         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6109         init_psymbol_list.
6110         * psymtab.c (init_psymbol_list): Do nothing if already called.
6111         * psympriv.h (init_psymbol_list): Add comment.
6112         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6113         init_psymbol_list.
6114         * dbxread.c (dbx_symfile_read): Unconditionally call
6115         init_psymbol_list.
6116
6117 2019-01-10  Tom Tromey  <tom@tromey.com>
6118
6119         * xcoffread.c (scan_xcoff_symtab): Update.
6120         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6121         "where".
6122         * mdebugread.c (parse_partial_symbols)
6123         (handle_psymbol_enumerators): Update.
6124         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6125         * dbxread.c (read_dbx_symtab): Update.
6126         * psympriv.h (psymbol_placement): New enum.
6127         (add_psymbol_to_list): Update.
6128
6129 2019-01-10  Tom Tromey  <tom@tromey.com>
6130
6131         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6132         static_psymbols parameters.
6133         (scan_xcoff_symtab): Update.
6134         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6135         static_psymbols parameters.
6136         * psympriv.h (start_psymtab_common): Update.
6137         * mdebugread.c (parse_partial_symbols): Update.
6138         * dwarf2read.c (create_partial_symtab): Update.
6139         * dbxread.c (read_dbx_symtab): Update.
6140         (start_psymtab): Remove global_psymbols and static_psymbols
6141         parameters.
6142
6143 2019-01-10  Tom Tromey  <tom@tromey.com>
6144
6145         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6146         * psymtab.c (allocate_psymtab): Add comment.
6147         * psympriv.h (allocate_psymtab): Add comment.
6148         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6149         initializations.
6150         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6151
6152 2019-01-10  Tom Tromey  <tom@tromey.com>
6153
6154         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6155         Don't declare.
6156         * mipsread.c: Include mdebugread.h.
6157         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6158         Declare.
6159         * elfread.c: Include mdebugread.h.
6160
6161 2019-01-09  Tom Tromey  <tom@tromey.com>
6162
6163         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6164         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6165         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6166         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6167         (psym_lookup_symbol, psym_find_last_source_symtab)
6168         (psym_forget_cached_source_info, psym_print_stats)
6169         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6170         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6171         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6172         (psym_find_compunit_symtab_by_address)
6173         (maintenance_print_psymbols, maintenance_info_psymtabs)
6174         (maintenance_check_psymtabs): Use ranged for.
6175         * psymtab.h (class objfile_psymtabs): New.
6176         (require_partial_symbols): Return objfile_psymtabs.
6177         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6178
6179 2019-01-09  Tom Tromey  <tom@tromey.com>
6180
6181         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6182         (find_pc_mapped_section, list_overlays_command)
6183         (map_overlay_command, unmap_overlay_command)
6184         (simple_overlay_update): Use all_objfiles.
6185         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6186         * printcmd.c (info_symbol_command): Use all_objfiles.
6187         * objfiles.h (ALL_OBJSECTIONS): Remove.
6188         * maint.c (maintenance_translate_address): Use all_objfiles.
6189         * gcore.c (gcore_create_callback): Use all_objfiles.
6190         (objfile_find_memory_regions): Likewise.
6191
6192 2019-01-09  Tom Tromey  <tom@tromey.com>
6193
6194         * symtab.c (find_line_symtab, info_sources_command)
6195         (make_source_files_completion_list): Use objfile_compunits.
6196         * source.c (select_source_symtab): Use objfile_compunits.
6197         * objfiles.h (struct objfile): Update comment.
6198         (ALL_OBJFILES): Remove.
6199         (ALL_FILETABS): Remove.
6200         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6201         objfile_compunits.
6202
6203 2019-01-09  Tom Tromey  <tom@tromey.com>
6204
6205         * symmisc.c (print_objfile_statistics, dump_objfile)
6206         (maintenance_print_symbols): Use compunit_filetabs.
6207         * source.c (forget_cached_source_info_for_objfile): Use
6208         compunit_filetabs.
6209         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6210         (ALL_FILETABS): Use compunit_filetabs.
6211         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6212         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6213
6214 2019-01-09  Tom Tromey  <tom@tromey.com>
6215
6216         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6217         (compunit_filetabs): New.
6218         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6219         compunit_filetabs.
6220         (info_sources_command, make_source_files_completion_list): Remove
6221         declaration.
6222         * symmisc.c (print_objfile_statistics, dump_objfile)
6223         (maintenance_print_symbols): Remove declaration.
6224         (maintenance_info_symtabs): Use compunit_filetabs.
6225         (maintenance_info_line_tables): Likewise.
6226         * source.c (select_source_symtab): Change local variable name.
6227         (forget_cached_source_info_for_objfile): Remove declaration.
6228         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6229         * objfiles.c (objfile_relocate1): Remove declaration.
6230         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6231         declaration.
6232         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6233         * coffread.c (coff_symtab_read): Remove declaration.
6234         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6235         compunit_filetabs.
6236
6237 2019-01-09  Tom Tromey  <tom@tromey.com>
6238
6239         * symtab.c (lookup_objfile_from_block)
6240         (find_pc_sect_compunit_symtab, search_symbols)
6241         (default_collect_symbol_completion_matches_break_on): Use
6242         objfile_compunits.
6243         * objfiles.h (ALL_COMPUNITS): Remove.
6244         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6245         * cp-support.c (add_symbol_overload_list_qualified): Use
6246         objfile_compunits.
6247         * ada-lang.c (ada_collect_symbol_completion_matches)
6248         (ada_add_global_exceptions): Use objfile_compunits.
6249
6250 2019-01-09  Tom Tromey  <tom@tromey.com>
6251
6252         * source.c (select_source_symtab)
6253         (forget_cached_source_info_for_objfile): Remove declaration.
6254         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6255         declaration.
6256         * maint.c (count_symtabs_and_blocks): Remove declaration.
6257         * cp-support.c (add_symbol_overload_list_qualified): Remove
6258         declaration.
6259         * coffread.c (coff_symtab_read): Remove declaration.
6260         * symtab.c (lookup_symbol_in_objfile_symtabs)
6261         (basic_lookup_transparent_type_1): Use objfile_compunits.
6262         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6263         (info_sources_command, search_symbols)
6264         (default_collect_symbol_completion_matches_break_on)
6265         (make_source_files_completion_list): Remove declaration.
6266         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6267         (ada_collect_symbol_completion_matches)
6268         (ada_add_global_exceptions): Remove declaration.
6269         * linespec.c (iterate_over_all_matching_symtabs): Use
6270         objfile_compunits.
6271         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6272         (class objfile_compunits): New.
6273         (ALL_COMPUNITS): Use objfile_compunits.
6274         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6275         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6276         objfile_compunits.
6277         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6278
6279 2019-01-09  Tom Tromey  <tom@tromey.com>
6280
6281         * symtab.c (search_symbols)
6282         (default_collect_symbol_completion_matches_break_on): Use
6283         objfile_msymbols.
6284         * ada-lang.c (ada_lookup_simple_minsym)
6285         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6286         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6287         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6288         objfile_msymbols.
6289         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6290         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6291         * objc-lang.c (find_methods): Use objfile_msymbols.
6292         (info_selectors_command, info_classes_command): Likewise.
6293         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6294         * objfiles.h (class objfile_msymbols): New.
6295         (ALL_OBJFILE_MSYMBOLS): Remove.
6296         (ALL_MSYMBOLS): Remove.
6297
6298 2019-01-09  Tom Tromey  <tom@tromey.com>
6299
6300         * common/next-iterator.h (next_adapter): Add Iterator template
6301         parameter.
6302         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6303         (class all_objfiles_safe): New.
6304         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6305         * objfiles.c (put_objfile_before): Update comment.
6306         (add_separate_debug_objfile): Likewise.
6307         (free_all_objfiles): Use all_objfiles_safe.
6308         (objfile_purge_solibs): Likewise.
6309
6310 2019-01-09  Tom Tromey  <tom@tromey.com>
6311
6312         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6313         (expand_symtab_containing_pc, lookup_static_symbol)
6314         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6315         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6316         all_objfiles.
6317         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6318         * breakpoint.c (create_overlay_event_breakpoint)
6319         (create_longjmp_master_breakpoint)
6320         (create_std_terminate_master_breakpoint)
6321         (create_exception_master_breakpoint): Use all_objfiles.
6322         * linux-thread-db.c (try_thread_db_load_from_pdir)
6323         (has_libpthread): Use all_objfiles.
6324         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6325         * linespec.c (iterate_over_all_matching_symtabs)
6326         (search_minsyms_for_name): Use all_objfiles.
6327         * maint.c (maintenance_info_sections): Use all_objfiles.
6328         * main.c (captured_main_1): Use all_objfiles.
6329         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6330         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6331         * guile/scm-pretty-print.c
6332         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6333         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6334         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6335         (maintenance_print_msymbols): Use all_objfiles.
6336         * source.c (select_source_symtab): Use all_objfiles.
6337         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6338         * symfile.c (remove_symbol_file_command)
6339         (expand_symtabs_matching, map_symbol_filenames): Use
6340         all_objfiles.
6341         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6342         all_objfiles.
6343         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6344         * objc-lang.c (find_methods): Use all_objfiles.
6345         * objfiles.c (have_partial_symbols, have_full_symbols)
6346         (have_minimal_symbols, qsort_cmp)
6347         (default_iterate_over_objfiles_in_search_order): Use
6348         all_objfiles.
6349         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6350         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6351         (maintenance_check_psymtabs): Use all_objfiles.
6352         (ALL_PSYMTABS): Remove.
6353         * compile/compile-object-run.c (do_module_cleanup): Use
6354         all_objfiles.
6355         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6356         * cp-support.c (add_symbol_overload_list_qualified): Use
6357         all_objfiles.
6358         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6359         Use all_objfiles.
6360         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6361         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6362         all_objfiles.
6363         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6364         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6365         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6366         Uses all_objfiles.
6367         * solib.c (solib_read_symbols): Use all_objfiles
6368
6369 2019-01-09  Tom Tromey  <tom@tromey.com>
6370
6371         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6372         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6373         all_objfiles.
6374         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6375         * symmisc.c (print_symbol_bcache_statistics)
6376         (print_objfile_statistics, maintenance_print_objfiles)
6377         (maintenance_info_symtabs, maintenance_check_symtabs)
6378         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6379         all_objfiles.
6380         * source.c (forget_cached_source_info): Use all_objfiles.
6381         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6382         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6383         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6384         * objfiles.c (update_section_map): Use all_objfiles.
6385         (shared_objfile_contains_address_p): Likewise.
6386         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6387         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6388
6389 2019-01-09  Tom Tromey  <tom@tromey.com>
6390
6391         * common/next-iterator.h: New file.
6392         * objfiles.h (class all_objfiles): New.
6393         (struct objfile_iterator): New.
6394
6395 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6396
6397         * NEWS: Move the description of the changed "frame", "select-frame",
6398          and "info frame" commands to the Changed commands section.
6399
6400 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6401
6402         * gdbtypes.c (check_stub_method_group): Remove handling of old
6403         mangling schemes.
6404         * linespec.c (find_methods): Likewise.
6405         * stabsread.c (read_member_functions): Likewise.
6406         * valops.c (search_struct_method): Likewise.
6407         (value_struct_elt_for_reference): Likewise.
6408         * NEWS: Mention this change.
6409
6410 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6411
6412         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6413         print_source_lines.
6414         * source.c (print_source_lines_base): Update line number check.
6415         (print_source_lines): New function.
6416         (source_lines_range::source_lines_range): New function.
6417         * source.h (class source_lines_range): New class.
6418         (print_source_lines): New declaration.
6419
6420 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6421
6422         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6423
6424 2019-01-08  Tom Tromey  <tom@tromey.com>
6425             Simon Marchi  <simon.marchi@ericsson.com>
6426
6427         PR gdb/24060
6428         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6429         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6430         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6431         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6432         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6433         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6434
6435 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6436
6437         * source.c (select_source_symtab): Move header comment to
6438         declaration in source.h.
6439         (forget_cached_source_info_for_objfile): Likewise.
6440         (forget_cached_source_info): Likewise.
6441         (identify_source_line): Likewise.
6442         * source.h (identify_source_line): Move declaration from symtab.h
6443         and add comment from source.c
6444         (print_source_lines): Likewise.
6445         (forget_cached_source_info_for_objfile): Likewise.
6446         (forget_cached_source_info): Likewise.
6447         (select_source_symtab): Likewise.
6448         (enum print_source_lines_flag): Move definition from symtab.h.
6449         * symtab.h (identify_source_line): Move declaration to source.h.
6450         (print_source_lines): Likewise.
6451         (forget_cached_source_info_for_objfile): Likewise.
6452         (forget_cached_source_info): Likewise.
6453         (select_source_symtab): Likewise.
6454         (enum print_source_lines_flag): Move definition to source.h.
6455         * tui/tui-hooks.c: Add 'source.h' include.
6456
6457 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6458
6459         * source.c (print_source_lines_base): Handle requests to print
6460         reverse line number sequences, and guard against empty lines
6461         string.
6462
6463 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6464
6465         * source.c (print_source_lines_base): Fix skip of '\r' if next
6466         character is '\n'.
6467
6468 2019-01-06  Tom Tromey  <tom@tromey.com>
6469
6470         * c-exp.y (struct c_parse_state) <macro_original_text,
6471         expansion_obstack>: New member.
6472         (macro_original_text, expansion_obstack): Remove globals.
6473         (scan_macro_expansion, scanning_macro_expansion)
6474         (finished_macro_expansion): Update.
6475         (scan_macro_cleanup): Remove.
6476         (yylex, c_parse): Update.
6477
6478 2019-01-06  Tom Tromey  <tom@tromey.com>
6479
6480         * c-exp.y (struct c_parse_state) <strings>: New member.
6481         (operator_stoken): Update.
6482
6483 2019-01-06  Tom Tromey  <tom@tromey.com>
6484
6485         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6486         (union type_stack_elt) <typelist_val>: Now a pointer to
6487         std::vector.
6488         (type_stack_cleanup): Don't declare.
6489         (push_typelist): Update.
6490         * parse.c (pop_typelist): Return a std::vector.
6491         (push_typelist): Take a std::vector.
6492         (follow_types): Update.  Do not free args.
6493         (type_stack_cleanup): Remove.
6494         * c-exp.y (struct c_parse_state): New.
6495         (cpstate): New global.
6496         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6497         (nonempty_typelist): Update.
6498         (func_mod): Create a new vector.
6499         (c_parse): Create a c_parse_state.
6500         (check_parameter_typelist): Do not delete params.
6501         (function_method): Update.  Do not delete type_list.
6502
6503 2019-01-06  Tom Tromey  <tom@tromey.com>
6504
6505         PR gdb/28155:
6506         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6507         check_typedef.
6508         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6509         (print_return_value): Likewise.
6510
6511 2019-01-05  Tom Tromey  <tom@tromey.com>
6512
6513         * contrib/cleanup_check.py: Remove.
6514         * contrib/gcc-with-excheck: Remove.
6515         * contrib/exsummary.py: Remove.
6516         * contrib/excheck.py: Remove.
6517
6518 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6519
6520         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6521         NULL. Initialize tpprev to NULL instead of assigning it
6522         to NULL on the next statement.
6523         * windows-nat.c (windows_delete_thread): Remove check for
6524         main_thread_id before printing thread exit notifications.
6525         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6526         Remove thread ID check against main_thread_id.
6527         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6528         windows_delete_thread.
6529         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6530
6531 2019-01-04  Tom Tromey  <tom@tromey.com>
6532
6533         * compile/compile.c (_initialize_compile): Use upper case for
6534         metasyntactic variables.
6535         * symmisc.c (_initialize_symmisc): Use upper case for
6536         metasyntactic variables.
6537         * psymtab.c (_initialize_psymtab): Use upper case for
6538         metasyntactic variables.
6539         * demangle.c (demangle_command): Use upper case for metasyntactic
6540         variables.
6541         (_initialize_demangler): Likewise.
6542         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6543         variables.
6544
6545 2019-01-03  Tom Tromey  <tom@tromey.com>
6546
6547         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6548
6549 2019-01-03  Tom Tromey  <tom@tromey.com>
6550
6551         * python/py-symtab.c (salpy_str): Update.
6552         (struct salpy_sal_object) <symtab>: Now a PyObject.
6553         (salpy_dealloc): Update.
6554         (del_objfile_sal): Use gdbpy_ref.
6555
6556 2019-01-03  Tom Tromey  <tom@tromey.com>
6557
6558         * python/py-type.c (convert_field): Use new_reference.  Return
6559         gdbpy_ref.
6560         (make_fielditem): Return gdbpy_ref.
6561         (typy_fields): Update.
6562         (typy_getitem): Update.
6563         (field_name): Return gdbpy_ref.  Use new_reference.
6564         (typy_iterator_iternext): Update.
6565
6566 2019-01-03  Tom Tromey  <tom@tromey.com>
6567
6568         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6569
6570 2019-01-03  Tom Tromey  <tom@tromey.com>
6571
6572         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6573         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6574         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6575         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6576         (pspy_set_type_printers): Likewise.
6577         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6578         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6579         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6580         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6581         (objfpy_set_type_printers): Likewise.
6582
6583 2019-01-03  Tom Tromey  <tom@tromey.com>
6584
6585         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6586         (gdbpy_print_stack): Use gdbpy_err_fetch.
6587         * python/python-internal.h (class gdbpy_err_fetch): New class.
6588         (class gdbpy_enter) <m_error_type, m_error_value,
6589         m_error_traceback>: Remove.
6590         <m_error>: New member.
6591         (gdbpy_exception_to_string): Don't declare.
6592         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6593         * python/py-value.c (convert_value_from_python): Use
6594         gdbpy_err_fetch.
6595         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6596         gdbpy_exception_to_string.
6597         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6598         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6599         gdbpy_err_fetch.
6600
6601 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6602
6603         * linux-nat.c (delete_lwp_cleanup): Delete.
6604         (struct lwp_deleter): New struct.
6605         (lwp_info_up): New typedef.
6606         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6607         lwp_info_up.
6608
6609 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6610
6611         * linux-fork.c (class scoped_switch_fork_info): New class.
6612         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6613
6614 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6615
6616         * valops.c (find_overload_match): Remove use of null_cleanup, and
6617         calls to do_cleanups.
6618
6619 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6620
6621         * compile/compile-cplus-types.c
6622         (compile_cplus_instance::decl_name): Handle changes to
6623         cp_func_name.
6624         * cp-support.c (cp_func_name): Update header comment, update
6625         return type.
6626         * cp-support.h (cp_func_name): Update return type in declaration.
6627         * valops.c (find_overload_match): Move temp_func local to top
6628         level of function and change its type.  Use temp_func to hold and
6629         delete temporary string obtained from cp_func_name.
6630
6631 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6634         gdb::char_vector, remove cleanup, and update uses of `msg`.
6635
6636 2019-01-03  Jim Wilson  <jimw@sifive.com>
6637
6638         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6639
6640 2019-01-02  Tom Tromey  <tom@tromey.com>
6641
6642         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6643         (tdesc_parse_xml): Remove cleanups.
6644         * target-descriptions.h (make_cleanup_free_target_description):
6645         Don't declare.
6646         (target_desc_deleter): New struct.
6647         (target_desc_up): New typedef.
6648         * target-descriptions.c (target_desc_deleter::operator()): Rename
6649         from free_target_description.
6650         (make_cleanup_free_target_description): Remove.
6651
6652 2019-01-02  Tom Tromey  <tom@tromey.com>
6653
6654         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6655         constructor, destructor.
6656         (linespec_parser): Remove typedef.
6657         (~linespec_parser): Rename from linespec_parser_delete.
6658         (linespec_lex_to_end, linespec_complete_label)
6659         (linespec_complete): Update.
6660         (decode_line_full): Remove cleanups.
6661         (decode_line_1): Update.
6662
6663 2019-01-02  Tom Tromey  <tom@tromey.com>
6664
6665         * python/python-internal.h (inferior_to_inferior_object): Change
6666         return type.
6667         * python/py-exitedevent.c (create_exited_event_object): Update.
6668         * python/py-inferior.c (inferior_to_inferior_object): Return
6669         gdbpy_ref.
6670         (python_new_inferior, python_inferior_deleted)
6671         (thread_to_thread_object, delete_thread_object)
6672         (build_inferior_list, gdbpy_selected_inferior): Update.
6673         * python/py-infthread.c (create_thread_object): Update.  Also fail
6674         if inferior_to_inferior_object fails.
6675
6676 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6677
6678         * inferior.h (class inferior) <displaced_step_state>: New field.
6679         * infrun.h (struct displaced_step_state): Move here from
6680         infrun.c.  Initialize fields, add constructor.
6681         <inf>: Remove field.
6682         <reset>: New method.
6683         * infrun.c (struct displaced_step_inferior_state): Move to
6684         infrun.h.
6685         (displaced_step_inferior_states): Remove.
6686         (get_displaced_stepping_state): Adust.
6687         (displaced_step_in_progress_any_inferior): Adjust.
6688         (displaced_step_in_progress_thread): Adjust.
6689         (displaced_step_in_progress): Adjust.
6690         (add_displaced_stepping_state): Remove.
6691         (get_displaced_step_closure_by_addr): Adjust.
6692         (remove_displaced_stepping_state): Remove.
6693         (infrun_inferior_exit): Call displaced_step_state.reset.
6694         (use_displaced_stepping): Don't check for NULL.
6695         (displaced_step_prepare_throw): Call
6696         get_displaced_stepping_state.
6697         (displaced_step_fixup): Don't check for NULL.
6698         (prepare_for_detach): Don't check for NULL.
6699
6700 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6701
6702         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6703          in case of call that did not complete.
6704
6705 2019-01-02  Andrey Utkin  <autkin@undo.io>
6706
6707         * symfile.c (find_separate_debug_file): Fix search of debug files for
6708         remote debuggee.
6709
6710 2019-01-02  Tom Tromey  <tom@tromey.com>
6711
6712         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6713         indentation.
6714         * python/py-frame.c (frapy_older): Remove cast.
6715         (frapy_newer): Likewise.
6716         * python/py-breakpoint.c (local_setattro): Remove cast.
6717         * python/py-arch.c (archpy_name): Remove local variable.
6718         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6719
6720 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6721
6722         * unittests/basic_string_view/element_access/char/empty.cc:
6723         Fix year range in copyright header.
6724
6725 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6726
6727         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6728         Delete.
6729         <operator==>: Update with for removed field.
6730         <hash>: Likewise.
6731         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6732         <isa_features>: ...this.
6733         <abi_features>: New field.
6734         (riscv_isa_flen): Update comment.
6735         (riscv_abi_xlen): New declaration.
6736         (riscv_abi_flen): New declaration.
6737         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6738         isa_features.
6739         (riscv_abi_xlen): New function.
6740         (riscv_isa_flen): Update to get answer from isa_features.
6741         (riscv_abi_flen): New function.
6742         (riscv_has_fp_abi): Update to get answer from abi_features.
6743         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6744         xlen and flen.
6745         (riscv_call_info) <xlen, flen>: Update comment.
6746         (riscv_call_arg_struct): Remove invalid assertions
6747         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6748         is removed.
6749         (riscv_gdbarch_init): Gather isa features and abi features
6750         separately, ensure both match on the gdbarch when reusing an old
6751         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6752         a target with 64-bit float hardware.
6753
6754 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6755
6756         * source.c (search_command_helper): Stop reverse search
6757         when line 1 has been searched.
6758
6759 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6760
6761         * record-full.c (record_full_base_target::close): Rewrite
6762         record_full_core_buf_list free logic.
6763
6764 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6765
6766         * break-catch-syscall.c (print_one_catch_syscall): xfree
6767         the last text.
6768
6769 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6770
6771         * top.c (print_gdb_version): Update Copyright year in version
6772         message.
6773
6774 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6775
6776         Update copyright year range in all GDB files.
6777
6778 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6779
6780         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6781
6782 For older changes see ChangeLog-2018.
6783 \f
6784 Local Variables:
6785 mode: change-log
6786 left-margin: 8
6787 fill-column: 74
6788 version-control: never
6789 coding: utf-8
6790 End:
6791