gdb/ChangeLog

   1 2020-08-31  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * corelow.c (unordered_set): Include.
   4         (class core_target): Add field 'm_core_unavailable_mappings'.
   5         (core_target::build_file_mappings): Print only one warning
   6         per inaccessible file.  Add unavailable/broken mappings
   7         to m_core_unavailable_mappings.
   8         (core_target::xfer_partial): Call...
   9         (core_target::xfer_memory_via_mappings): New method.
  10
  11 2020-08-31  Simon Marchi  <simon.marchi@polymtl.ca>
  12
  13         * dwarf2/read.c (struct field_info) <non_public_fields>: Change
  14         type to bool.
  15
  16 2020-08-31  Simon Marchi  <simon.marchi@polymtl.ca>
  17
  18         * dwarf2/read.c (struct field_info): Fix indentation.
  19
  20 2020-08-31  Simon Marchi  <simon.marchi@efficios.com>
  21
  22         * frame-unwind.h (frame_prev_register_ftype): Fix adjective
  23         ordering in comment.
  24         * frame.c (frame_id_eq): Fix indentation.
  25
  26 2020-08-31  Scott Linder  <scott@scottlinder.com>
  27             Simon Marchi  <simon.marchi@efficios.com>
  28
  29         * inline-frame.c (inline_frame_this_id): Remove assert that prevents
  30         inline frame ids in outer frame.
  31
  32 2020-08-31  Simon Marchi  <simon.marchi@efficios.com>
  33
  34         * frame.h (enum frame_id_stack_status) <FID_STACK_OUTER>: New.
  35         * frame.c (fprint_frame_id): Handle FID_STACK_OUTER.
  36         (outer_frame_id): Use FID_STACK_OUTER instead of
  37         FID_STACK_INVALID.
  38         (frame_id_p): Don't check for outer_frame_id.
  39
  40 2020-08-31  Simon Marchi  <simon.marchi@efficios.com>
  41
  42         * frame-unwind.c (frame_unwind_got_optimized): Don't set
  43         regnum/frame in value.  Call allocate_value_lazy.
  44         * frame.c (frame_unwind_register_value): Use
  45         val_print_not_saved.
  46
  47 2020-08-31  Simon Marchi  <simon.marchi@efficios.com>
  48
  49         * gdbtypes.h (NULL_TYPE): Remove, change all uses to nullptr.
  50
  51 2020-08-29  Pedro Alves  <pedro@palves.net>
  52
  53         * progspace.c (print_program_space): Use all_inferiors.  Switch to
  54         the inferior before calling target_pid_to_str.
  55
  56 2020-08-28  Tom Tromey  <tom@tromey.com>
  57
  58         * xcoffread.c (xcoff_end_psymtab): Update comment.
  59         * dbxread.c (dbx_end_psymtab): Update comment.
  60
  61 2020-08-28  Tom de Vries  <tdevries@suse.de>
  62
  63         PR breakpoint/26544
  64         * breakpoint.c (parse_breakpoint_sals): Remove const from struct
  65         event_location.
  66         (create_breakpoint): Same.
  67         (base_breakpoint_decode_location): Same.
  68         (bkpt_create_sals_from_location): Same.
  69         (bkpt_decode_location): Same.
  70         (bkpt_probe_create_sals_from_location): Same.
  71         (bkpt_probe_decode_location): Same.
  72         (tracepoint_create_sals_from_location): Same.
  73         (tracepoint_decode_location): Same.
  74         (tracepoint_probe_decode_location): Same.
  75         (strace_marker_create_sals_from_location): Same.
  76         (strace_marker_decode_location): Same.
  77         (create_sals_from_location_default): Same.
  78         (decode_location_default): Same.
  79         * breakpoint.h (struct breakpoint_ops): Same.
  80         (create_breakpoint): Same.
  81         * linespec.h (decode_line_full): Same.
  82         * linespec.c (decode_line_full): Same.  Throw error if
  83         result.size () == 0.
  84
  85 2020-08-27  Pedro Alves  <pedro@palves.net>
  86
  87         PR gdb/26524
  88         * breakpoint.c (until_break_fsm) <location_breakpoint,
  89         caller_breakpoint>: Delete fields.
  90         <breakpoints>: New field.
  91         <until_break_fsm>: Adjust to save a breakpoint vector instead of
  92         two individual breakpoints.
  93         (until_break_fsm::should_stop): Loop over breakpoints in the
  94         breakpoint vector.
  95         (until_break_fsm::clean_up): Adjust to clear the breakpoints
  96         vector.
  97         (until_break_command): Handle location expanding into multiple
  98         sals.
  99
 100 2020-08-27  Pedro Alves  <pedro@palves.net>
 101
 102         PR gdb/26523
 103         * inline-frame.c (stopped_by_user_bp_inline_frame): Also consider
 104         bp_until breakpoints user-specified locations.  Update intro
 105         comment.
 106
 107 2020-08-27  Simon Marchi  <simon.marchi@polymtl.ca>
 108
 109         * gdb_bfd.h (gdb_bfd_section_iterator, gdb_bfd_section_range,
 110         gdb_bfd_sections): New.
 111         * maint.c (print_bfd_section_info): Change param type to
 112         maint_print_section_data.
 113         (print_objfile_section_info): Likewise.
 114         (print_bfd_section_info_maybe_relocated): Likewise.
 115         (maintenance_info_sections): Use gdb_bfd_sections.
 116
 117 2020-08-25  Shahab Vahedi  <shahab@synopsys.com>
 118
 119         * MAINTAINERS: Add ARC target and maintainer.
 120
 121 2020-08-25  Anton Kolesov  <anton.kolesov@synopsys.com>
 122
 123         * configure.tgt: ARC support for GNU/Linux.
 124         * Makefile.in (ALL_TARGET_OBJS): Likewise.
 125         * arc-linux-tdep.c: New file.
 126         * arc-tdep.h (ARC_STATUS32_L_MASK, ARC_STATUS32_DE_MASK): Declare.
 127         * arc-tdep.c (arc_write_pc): Use it.
 128
 129 2020-08-25  Shahab Vahedi  <shahab@synopsys.com>
 130
 131         * arc-tdep.c (arc_check_for_hardware_loop): New.
 132         * arc-tdep.h (gdbarch_tdep): New field has_hw_loops.
 133
 134 2020-08-25  Shahab Vahedi  <shahab@synopsys.com>
 135
 136         * arc-tdep.h: Include "gdbarch.h".
 137
 138 2020-08-25  Shahab Vahedi  <shahab@synopsys.com>
 139
 140         * arch/arc.h
 141         (arc_gdbarch_features): New class to stir the selection of target XML.
 142         (arc_create_target_description): Use FEATURES to choose XML target.
 143         (arc_lookup_target_description): Use arc_create_target_description
 144         to create _new_ target descriptions or return the already created
 145         ones if the FEATURES is the same.
 146         * arch/arc.c: Implementation of prototypes described above.
 147         * gdb/arc-tdep.h (arc_regnum enum): Add more registers.
 148         (arc_gdbarch_features_init): Initialize the FEATURES struct.
 149         * arc-tdep.c (*_feature_name): Make feature names consistent.
 150         (arc_register_feature): A new struct to hold information about
 151         registers of a particular target/feature.
 152         (arc_check_tdesc_feature): Check if XML provides registers in
 153         compliance with ARC_REGISTER_FEATURE structs.
 154         (arc_update_acc_reg_names): Add aliases for r58 and r59.
 155         (determine_*_reg_feature_set): Which feature name to look for.
 156         (arc_gdbarch_features_init): Given MACH and ABFD, initialize FEATURES.
 157         (mach_type_to_arc_isa): Convert from a set of binutils machine types
 158         to expected ISA enums to be used in arc_gdbarch_features structs.
 159         * features/Makefile (FEATURE_XMLFILES): Add new files.
 160         * gdb/features/arc/v1-aux.c: New file.
 161         * gdb/features/arc/v1-aux.xml: Likewise.
 162         * gdb/features/arc/v1-core.c: Likewise.
 163         * gdb/features/arc/v1-core.xml: Likewise.
 164         * gdb/features/arc/v2-aux.c: Likewise.
 165         * gdb/features/arc/v2-aux.xml: Likewise.
 166         * gdb/features/arc/v2-core.c: Likewise.
 167         * gdb/features/arc/v2-core.xml: Likewise.
 168         * NEWS (Changes since GDB 9): Announce obsolence of old feature names.
 169
 170 2020-08-25  Gaius Mulley  <gaiusmod2@gmail.com>
 171             Andrew Burgess  <andrew.burgess@embecosm.com>
 172
 173         PR m2/26372
 174         * m2-exp.y (exp): Improve comment for non_empty_arglist case, add
 175         an assert.  Remove single element array indexing pattern as the
 176         MULTI_SUBSCRIPT support will handle this case too.
 177
 178 2020-08-24  Simon Marchi  <simon.marchi@polymtl.ca>
 179
 180         * value.h (valprint_check_validity): Move declaration from
 181         here...
 182         * valprint.h (valprint_check_validity): ... to here.
 183
 184 2020-08-24  Simon Marchi  <simon.marchi@efficios.com>
 185
 186         * debug.h: New file.
 187         * debug.c (debug_prefixed_vprintf): New function.
 188         * infrun.c (infrun_debug_printf_1): Use debug_prefixed_vprintf.
 189         * linux-nat.c (linux_nat_debug_printf_1): Likewise.
 190
 191 2020-08-24  Simon Marchi  <simon.marchi@efficios.com>
 192
 193         * infrun.h (infrun_debug_printf_1): New function declaration.
 194         (infrun_debug_printf): New macro.
 195         * infrun.c (infrun_debug_printf_1): Use infrun_debug_printf
 196         throughout.
 197         (infrun_debug_printf): New function.
 198         * breakpoint.c (should_be_inserted): Use infrun_debug_printf.
 199         (handle_jit_event): Likewise.
 200
 201 2020-08-21  Mark Wielaard  <mark@klomp.org>
 202
 203         * ada-lex.l: Extend register warnings diagnostics comment for g++.
 204
 205 2020-08-22  Simon Marchi  <simon.marchi@efficios.com>
 206
 207         * frame.c (enum class frame_id_status): New.
 208         (struct frame_info) <this_id::p>: Change type to frame_id_status.
 209         (fprintf_frame): Update.
 210         (compute_frame_id): Set frame id status to "computing" on entry.
 211         Set it back to "not_computed" on failure and to "computed" on
 212         success.
 213         (get_frame_id): Assert the frame id is not being computed.
 214         (create_sentinel_frame): Use frame_id_status::COMPUTED.
 215         (create_new_frame): Likewise.
 216         (frame_cleanup_after_sniffer): Update assert.
 217
 218 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
 219
 220         * regcache.c (pid_ptid_regcache_map): New type.
 221         (target_ptid_regcache_map): Remove.
 222         (target_pid_ptid_regcache_map): New type.
 223         (regcaches): Change type to target_pid_ptid_regcache_map.
 224         (get_thread_arch_aspace_regcache): Update.
 225         (regcache_thread_ptid_changed): Update, handle pid-like ptid
 226         case.
 227         (regcaches_size): Update.
 228         (regcache_count): Update.
 229         (registers_changed_ptid_target_pid_test): New.
 230         (_initialize_regcache): Register new test.
 231
 232 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
 233
 234         * regcache.c (regcache_count): New.
 235         (struct regcache_test_data): New.
 236         (regcache_test_data_up): New.
 237         (populate_regcaches_for_test): New.
 238         (regcaches_test): Remove.
 239         (get_thread_arch_aspace_regcache_test): New.
 240         (registers_changed_ptid_all_test): New.
 241         (registers_changed_ptid_target_test): New.
 242         (registers_changed_ptid_target_ptid_test): New.
 243         (regcache_thread_ptid_changed): Remove regcache_count lambda.
 244         (_initialize_regcache): Register new tests.
 245
 246 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
 247
 248         * regcache.c (test_get_thread_arch_aspace_regcache): Rename to...
 249         (get_thread_arch_aspace_regcache_and_check): ... this.  Remove
 250         gdbarch and aspace parameter.  Use current inferior's aspace.
 251         Validate regcache's arch value.
 252         (regcaches_test): Update.
 253
 254 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
 255
 256         * regcache.c (regcaches_test): Call registers_changed.
 257
 258 2020-08-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 259
 260         * infrun.c (process_event_stop_test): Fix typo "breapoint".
 261
 262 2020-08-19  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 263
 264         * amd64-tdep.c (amd64_skip_prologue): Using symbol table
 265         to find the end of prologue for flang compiled binaries.
 266         * arm-tdep.c (arm_skip_prologue): Likewise.
 267         * i386-tdep.c (i386_skip_prologue): Likewise.
 268         * producer.c (producer_is_llvm): New function.
 269         (producer_parsing_tests): Added new tests for clang/flang.
 270         * producer.h (producer_is_llvm): New declaration.
 271
 272 2020-08-18  Simon Marchi  <simon.marchi@efficios.com>
 273
 274         * linux-nat.c (linux_nat_debug_printf): New function.
 275         (linux_nat_debug_printf_1): New macro.  Use throughout the file.
 276
 277 2020-08-18  Aaron Merey  <amerey@redhat.com>
 278
 279         * Makefile.in (DEBUGINFOD_CFLAGS, DEBUGINFOD_LIBS): New variables.
 280         (INTERNAL_CFLAGS_BASE): Add DEBUGINFOD_CFLAGS.
 281         (CLIBS): Add DEBUGINFOD_LIBS.
 282
 283 2020-08-17  Sergei Trofimovich  <siarheit@google.com>
 284
 285         * ia64-linux-nat.c: Include "gdbarch.h" to declare used
 286         'gdbarch_num_regs'.
 287
 288 2020-08-17  Tom Tromey  <tromey@adacore.com>
 289
 290         * ada-varobj.c (ada_varobj_decode_var): Handle case where
 291         ada_get_decoded_value returns NULL.
 292
 293 2020-08-17  Tom Tromey  <tromey@adacore.com>
 294
 295         * python/py-inferior.c (infpy_search_memory): Use
 296         gdb_py_object_from_ulongest.
 297         * python/py-infevents.c (create_inferior_call_event_object)
 298         (create_memory_changed_event_object): Use
 299         gdb_py_object_from_ulongest.
 300         * python/py-linetable.c (ltpy_entry_get_pc): Use
 301         gdb_py_object_from_ulongest.
 302
 303 2020-08-17  Simon Marchi  <simon.marchi@polymtl.ca>
 304
 305         * loc.c (class symbol_needs_eval_context): Fix indentation.
 306
 307 2020-08-17  Simon Marchi  <simon.marchi@polymtl.ca>
 308
 309         * dwarf2/loc.c (dwarf2_loc_desc_get_symbol_read_needs): Use
 310         bool.
 311
 312 2020-08-17  Tom de Vries  <tdevries@suse.de>
 313
 314         PR gdb/26393
 315         * gdbtypes.c (dump_dynamic_prop): New function.
 316         (recursive_dump_type): Use dump_dynamic_prop for TYPE_CODE_RANGE.
 317
 318 2020-08-15  Tom de Vries  <tdevries@suse.de>
 319
 320         PR backtrace/26390
 321         * stack.c (print_frame_args): Temporarily set the selected
 322         frame to FRAME while printing the frame's arguments.
 323
 324 2020-08-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 325
 326         PR breakpoints/26385
 327         * ppc-linux-nat.c (ppc_linux_nat_target::low_prepare_to_resume):
 328         Always clear watchpoint with PTRACE_SET_DEBUGREG.
 329
 330 2020-08-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 331
 332         * ppc-linux-nat.c (ppc_linux_dreg_interface::detect)
 333         (ppc_linux_nat_target::low_prepare_to_resume): Use ptrace () < 0
 334         and >= to check return value instead of == -1 and != -1.
 335
 336 2020-08-14  Simon Marchi  <simon.marchi@polymtl.ca>
 337
 338         * utils.h (class gdb_argv) <as_array_view>: New method.
 339         * utils.c (gdb_argv_as_array_view_test): New.
 340         (_initialize_utils): Register selftest.
 341         * maint.c (maintenance_selftest): Use the new method.
 342
 343 2020-08-13  Kamil Rytarowski  <n54@gmx.com>
 344
 345         * target.h (supports_dumpcore, dumpcore): New
 346         function declarations.
 347         * target.c (supports_dumpcore, dumpcore): New
 348         functions.
 349         * target-delegates.c: Rebuild.
 350         * gcore.c (gcore_command): Use target_supports_dumpcore ()
 351         and target_dumpcore ().
 352
 353 2020-08-13  Aaron Merey  <amerey@redhat.com>
 354
 355         * debuginfod-support.c: Replace global variables with user_data.
 356
 357 2020-08-13  Simon Marchi  <simon.marchi@polymtl.ca>
 358
 359         * maint.c (maintenance_selftest): Split args and pass array_view
 360         to run_tests.
 361
 362 2020-08-12  Luis Machado  <luis.machado@linaro.org>
 363
 364         * value.c (check_type_length_before_alloc): Use ULONGEST to store a
 365         type's length.
 366         Use %s and pulongest to print the length.
 367
 368 2020-08-12  Pedro Alves  <palves@redhat.com>
 369
 370         * NEWS: Move "Multi-target debugging support" item to the
 371         "Changes since GDB 9" section.
 372
 373 2020-08-12  Pedro Alves  <palves@redhat.com>
 374
 375         PR gdb/26336
 376         * progspace.c (program_space::remove_objfile): Invalidate the
 377         frame cache.
 378
 379 2020-08-11  Tom de Vries  <tdevries@suse.de>
 380
 381         * MAINTAINERS: Mark ms1 as deleted.
 382
 383 2020-08-10  Luis Machado  <luis.machado@linaro.org>
 384
 385         PR gdb/26310
 386
 387         * aarch64-tdep.c (aarch64_analyze_prologue): Track use of SP/FP and
 388         act accordingly.
 389         (aarch64_analyze_prologue_test): Add more unit tests to exercise
 390         movz/str/stur/stp skipping behavior.
 391
 392 2020-08-10  Luis Machado  <luis.machado@linaro.org>
 393
 394         * nat/aarch64-sve-linux-sigcontext.h (SVE_PT_REGS_OFFSET): Use
 395         struct user_sve_header instead of struct sve_context.
 396
 397 2020-08-09  Simon Marchi  <simon.marchi@polymtl.ca>
 398
 399         * read.h (dwarf2_fetch_die_loc_sect_off,
 400         dwarf2_fetch_die_loc_cu_off): Replace function pointer +
 401         `void *` parameter with function_view.
 402         * read.c (dwarf2_fetch_die_loc_sect_off,
 403         dwarf2_fetch_die_loc_cu_off): Likewise.
 404         * loc.c (get_frame_pc_for_per_cu_dwarf_call): Remove.
 405         (per_cu_dwarf_call): Adjust.
 406         (get_frame_address_in_block_wrapper): Remove.
 407         (indirect_synthetic_pointer): Adjust.
 408         (get_ax_pc): Remove.
 409         (dwarf2_compile_expr_to_ax): Adjust.
 410
 411 2020-08-08  Tom de Vries  <tdevries@suse.de>
 412
 413         PR build/26344
 414         * arch/riscv.c (riscv_lookup_target_description): Use an explicit
 415         constructor.
 416         * regcache.c (get_thread_arch_aspace_regcache): Same.
 417
 418 2020-08-07  Tom Tromey  <tromey@adacore.com>
 419
 420         * ravenscar-thread.c
 421         (ravenscar_thread_target::set_base_thread_from_ravenscar_task):
 422         New method.
 423         (ravenscar_thread_target::wait): Check
 424         runtime_initialized.
 425         (ravenscar_thread_target::prepare_to_store)
 426         (ravenscar_thread_target::stopped_by_sw_breakpoint)
 427         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 428         (ravenscar_thread_target::stopped_by_watchpoint)
 429         (ravenscar_thread_target::stopped_data_address)
 430         (ravenscar_thread_target::core_of_thread): Use
 431         scoped_restore_current_thread and
 432         set_base_thread_from_ravenscar_task.
 433
 434 2020-08-07  Tom Tromey  <tromey@adacore.com>
 435
 436         * ravenscar-thread.c (update_thread_list): Set inferior_ptid.
 437
 438 2020-08-07  Tom Tromey  <tromey@adacore.com>
 439
 440         * ravenscar-thread.c (ravenscar_thread_target::wait): Call
 441         update_inferior_ptid before update_thread_list.
 442         (temporarily_change_regcache_ptid): New class.
 443         (ravenscar_thread_target::fetch_registers)
 444         (ravenscar_thread_target::store_registers)
 445         (ravenscar_thread_target::prepare_to_store): Use base thread when
 446         forwarding operation.
 447
 448 2020-08-07  Tom Tromey  <tromey@adacore.com>
 449
 450         * ravenscar-thread.c (ravenscar_thread_target::resume): Handle
 451         "is_pid" case.
 452
 453 2020-08-07  Tom Tromey  <tromey@adacore.com>
 454
 455         * ravenscar-thread.c (xfer_partial, enable_btrace, add_thread):
 456         New methods.
 457         (ravenscar_thread_target::get_thread_base_cpu): Check m_cpu_map
 458         first.
 459         (ravenscar_thread_target::add_thread): Rename from
 460         ravenscar_add_thread.
 461         (ravenscar_thread_target::update_thread_list): Use a lambda.
 462         (ravenscar_thread_target::xfer_partial): New method.
 463
 464 2020-08-07  Tom Tromey  <tromey@adacore.com>
 465
 466         * ada-lang.h (ada_task_list_iterator_ftype): Now a
 467         gdb::function_view.
 468         (iterate_over_live_ada_tasks): Change type of argument.
 469         * ada-tasks.c (iterate_over_live_ada_tasks): Change type
 470         of argument.
 471
 472 2020-08-07  Tom Tromey  <tromey@adacore.com>
 473
 474         * ravenscar-thread.c (ravenscar_thread_target) <extra_thread_info>:
 475         Remove.
 476         (ravenscar_thread_target::extra_thread_info): Remove.
 477         (ravenscar_thread_target::pid_to_str): Mention Ravenscar in result;
 478         defer to target beneath for non-Ravenscar threads.
 479
 480 2020-08-07  Tom Tromey  <tromey@adacore.com>
 481
 482         * ravenscar-thread.c (ravenscar_thread_target) <get_base_cpu,
 483         get_base_thread_from_ravenscar_task>: Now methods.
 484         <m_cpu_map>: New member.
 485         (ravenscar_thread_target::get_thread_base_cpu): Rename from
 486         ravenscar_get_thread_base_cpu.  Check m_cpu_map.
 487         (ravenscar_thread_target::task_is_currently_active): Update.
 488         (ravenscar_thread_target::get_base_thread_from_ravenscar_task):
 489         Now a method.
 490         (ravenscar_thread_target::add_active_thread): Put initial thread
 491         into the m_cpu_map.
 492
 493 2020-08-07  Tom Tromey  <tromey@adacore.com>
 494
 495         * ravenscar-thread.c (ravenscar_thread_target::wait): Return
 496         event_ptid.
 497
 498 2020-08-07  Tom Tromey  <tromey@adacore.com>
 499
 500         * ravenscar-thread.c (ravenscar_thread_target::wait): Check
 501         runtime_initialized.
 502
 503 2020-08-07  Tom Tromey  <tromey@adacore.com>
 504
 505         * ravenscar-thread.c (ravenscar_thread_target): Don't call
 506         add_active_thread.
 507         (ravenscar_thread_target::add_active_thread): Now public.
 508         (ravenscar_inferior_created): Call add_active_thread after pushing
 509         the target.
 510
 511 2020-08-07  Simon Marchi  <simon.marchi@polymtl.ca>
 512
 513         * regcache.c (ptid_regcache_map): New type.
 514         (target_ptid_regcache_map): New type.
 515         (regcaches): Change type to target_ptid_regcache_map.
 516         (get_thread_arch_aspace_regcache): Update to regcaches' new
 517         type.
 518         (regcache_thread_ptid_changed): Likewise.
 519         (registers_changed_ptid): Likewise.
 520         (regcaches_size): Likewise.
 521         (regcaches_test): Update.
 522         (regcache_thread_ptid_changed): Update.
 523         * regcache.h (regcache_up): New type.
 524         * gdbsupport/ptid.h (hash_ptid): New struct.
 525
 526 2020-08-07  Simon Marchi  <simon.marchi@efficios.com>
 527
 528         * observable.h (thread_ptid_changed): Add parameter
 529         `process_stratum_target *`.
 530         * infrun.c (infrun_thread_ptid_changed): Add parameter
 531         `process_stratum_target *` and use it.
 532         (selftests): New namespace.
 533         (infrun_thread_ptid_changed): New function.
 534         (_initialize_infrun): Register selftest.
 535         * regcache.c (regcache_thread_ptid_changed): Add parameter
 536         `process_stratum_target *` and use it.
 537         (regcache_thread_ptid_changed): New function.
 538         (_initialize_regcache): Register selftest.
 539         * thread.c (thread_change_ptid): Pass target to
 540         thread_ptid_changed observable.
 541
 542 2020-08-06  Caroline Tice <cmtice@google.com>
 543
 544         * dwarf2/read.c (struct dwo_file): Update comment on 'sections' field.
 545         (struct dwp_sections): Update field comments.  Add loclists and
 546         rnglists fields.
 547         (struct virtual_v2_dwo_sections): Rename struct to
 548         'virtual_v2_or_v5_dwo_sections'; update comments at top of struct; add
 549         size & offset fields for loclists and rnglists.
 550         (struct dwp_hash_table): Add a 'v5' struct field to the union section.
 551         (create_debug_type_hash_table): Add 'DW_UT_split_type' to the check for
 552         skipping dummy type units.
 553         (create_dwp_hash_table): Update the large comment above the function to
 554         discuss Version 5 DWP files as well, with references.  Update all the
 555         version checks in the function to check for version 5 as well.  Add new
 556         section at the end to create dwp hash table for version 5.
 557         (create_dwp_v2_section): Rename function to
 558         'create_dwp_v2_or_v5_section'.  Update function comment appropriately.
 559         Add V5 to error message text.
 560         (create_dwo_unit_in_dwp_v2): Change calls to create_dwp_v2_section
 561         into calls to create_dwp_v2_or_v5_section.
 562         (create_dwo_unit_in_dwp_v5): New function.
 563         (lookup_dwo_unit_in_dwp): Update conditional statement to explicitly
 564         check for version2; add else clause to handle version 5.
 565         (open_and_init_dwo_file): Add code to check dwarf version & only call
 566         create_debug_types_hash_table (with sections.types) if version is not 5;
 567         else call create_debug_type_hash_table, with sections.info.
 568         (dwarf2_locate_v2_dwp_sections): Update function comment to mention
 569         version 5.
 570         (dwarf2_locate_v5_dwp_sections): New function.
 571         (open_and_init_dwp_file): Add else-if clause for version 5 to call
 572         bfd_map_over_sections with dwarf2_locate_v5_dwp_sections.
 573
 574 2020-08-06  Simon Marchi  <simon.marchi@efficios.com>
 575
 576         * regcache.h (class regcache): Remove friend
 577         registers_changed_ptid.
 578         <regcache_thread_ptid_changed>: Remove.
 579         <regcaches>: Remove.
 580         * regcache.c (regcache::regcaches): Rename to...
 581         (regcaches): ... this.  Make static.
 582         (get_thread_arch_aspace_regcache): Update.
 583         (regcache::regcache_thread_ptid_changed): Rename to...
 584         (regcache_thread_ptid_changed): ... this.  Update.
 585         (class regcache_access): Remove.
 586         (regcaches_test): Update.
 587         (_initialize_regcache): Update.
 588         * sparc64-tdep.c, dwarf2/index-write.c, record-btrace.c: Include
 589         <forward_list>.
 590
 591 2020-08-06  Simon Marchi  <simon.marchi@efficios.com>
 592
 593         * regcache.h (class regcache) <current_regcache>: Rename to...
 594         <regcaches>: ... this.  Move doc here.
 595         * regcache.c (regcache::current_regcache) Rename to...
 596         (regcache::regcaches): ... this.  Move doc to header.
 597         (get_thread_arch_aspace_regcache): Update.
 598         (regcache::regcache_thread_ptid_changed): Update.
 599         (registers_changed_ptid): Update.
 600         (class regcache_access) <current_regcache_size>: Rename to...
 601         <regcaches_size>: ... this.
 602         (current_regcache_test): Rename to...
 603         (regcaches_test): ... this.
 604         (_initialize_regcache): Update.
 605
 606 2020-08-06  Victor Collod  <vcollod@nvidia.com>
 607
 608         * amd64-tdep.c (amd64_analyze_prologue): Fix incorrect comment.
 609
 610 2020-08-05  Kevin Buettner  <kevinb@redhat.com>
 611
 612         * corelow.c (core_target::build_file_mappings): Don't output
 613         null pathname in warning.
 614
 615 2020-08-05  Simon Marchi  <simon.marchi@polymtl.ca>
 616
 617         * gdb.dwarf2/clztest.exp, gdb.dwarf2/dw2-common-block.exp,
 618         gdb.dwarf2/dw2-dup-frame.exp, gdb.dwarf2/dw2-reg-undefined.exp,
 619         gdb.dwarf2/dw2-single-line-discriminators.exp,
 620         dw2-undefined-ret-addr.exp: Pass nopie to compilation options.
 621
 622 2020-08-05  Tom Tromey  <tromey@adacore.com>
 623
 624         PR rust/26197:
 625         * dwarf2/read.c (alloc_rust_variant): Handle univariant case.
 626         (quirk_rust_enum): Call alloc_rust_variant for univariant case.
 627         Fix off-by-one and type size errors in ordinary case.
 628
 629 2020-08-05  Tom de Vries  <tdevries@suse.de>
 630
 631         * gdbtypes.c (type_not_allocated, type_not_associated): Use
 632         "prop->const_val () == 0" instead of "prop->const_val () != 0".
 633
 634 2020-08-04  Simon Marchi  <simon.marchi@efficios.com>
 635
 636         * frame.h (frame_id_p): Return bool.
 637         (frame_id_artificial_p): Return bool.
 638         (frame_id_eq): Return bool.
 639         (has_stack_frames): Return bool.
 640         (get_selected_frame): Fix typo in comment.
 641         (get_frame_pc_if_available): Return bool.
 642         (get_frame_address_in_block_if_available): Return bool.
 643         (get_frame_func_if_available): Return bool.
 644         (read_frame_register_unsigned): Return bool.
 645         (get_frame_register_bytes): Return bool.
 646         (safe_frame_unwind_memory): Return bool.
 647         (deprecated_frame_register_read): Return bool.
 648         (frame_unwinder_is): Return bool.
 649         * frame.c (struct frame_info) <prev_arch::p>: Change type to
 650         bool.
 651         <this_id::p>: Likewise.
 652         <prev_p>: Likewise.
 653         (frame_stash_add): Return bool.
 654         (get_frame_id): Use bool.
 655         (frame_id_build_special) Use bool.
 656         (frame_id_build_unavailable_stack): Use bool.
 657         (frame_id_build): Use bool.
 658         (frame_id_p): Return bool, use true/false instead of 1/0.
 659         (frame_id_artificial_p): Likewise.
 660         (frame_id_eq): Likewise.
 661         (frame_id_inner): Likewise.
 662         (get_frame_func_if_available): Likewise.
 663         (read_frame_register_unsigned): Likewise.
 664         (deprecated_frame_register_read): Likewise.
 665         (get_frame_register_bytes): Likewise.
 666         (has_stack_frames): Likewise.
 667         (inside_main_func): Likewise.
 668         (inside_entry_func): Likewise.
 669         (get_frame_pc_if_available): Likewise.
 670         (get_frame_address_in_block_if_available): Likewise.
 671         (frame_unwinder_is): Likewise.
 672         (safe_frame_unwind_memory): Likewise.
 673         (frame_unwind_arch): Likewise.
 674
 675 2020-08-04  Simon Marchi  <simon.marchi@efficios.com>
 676
 677         * frame.c (frame_info) <prev_func> <p>: Rename to status, change
 678         type to cached_copy_status.
 679         (fprintf_frame): Adjust.
 680         (get_frame_func_if_available): Adjust.
 681         (frame_cleanup_after_sniffer): Adjust.
 682
 683 2020-08-04  Mark Wielaard  <mark@klomp.org>
 684
 685         * MAINTAINERS (Write After Approval): Update email address.
 686
 687 2020-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 688
 689         * gdbtypes.h (TYPE_DYN_PROP_ADDR): Remove, replace uses with
 690         dynamic_prop::const_val.
 691
 692 2020-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 693
 694         * gdbtypes.h (TYPE_DYN_PROP_KIND): Remove, replace uses with
 695         dynamic_prop::kind.
 696
 697 2020-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 698
 699         * gdbtypes.h (TYPE_DYN_PROP_BATON): Remove.
 700
 701 2020-08-04  Jose E. Marchesi  <jose.marchesi@oracle.com>
 702
 703         * configure.tgt: Set gdb_sim for bpf-*-* targets.
 704
 705 2020-08-04  Weimin Pan <weimin.pan@oracle.com>
 706             Jose E. Marchesi  <jose.marchesi@oracle.com>
 707
 708         * configure.tgt: Add entry for bpf-*-*.
 709         * Makefile.in (ALL_TARGET_OBS): Add bpf-tdep.o
 710         (ALLDEPFILES): Add bpf-tdep.c.
 711         * bpf-tdep.c: New file.
 712         * MAINTAINERS: Add bpf target and maintainer.
 713         * NEWS: Mention the support for the new target.
 714
 715 2020-08-04  Tom de Vries  <tdevries@suse.de>
 716
 717         PR symtab/23270
 718         * dwarf2/read.c (find_partial_die): Change internal error into Dwarf
 719         Error.
 720
 721 2020-08-03  John Baldwin  <jhb@FreeBSD.org>
 722
 723         * syscalls/freebsd.xml: Regenerate.
 724
 725 2020-08-03  John Baldwin  <jhb@FreeBSD.org>
 726
 727         * syscalls/update-freebsd.sh: Fix usage and year range.
 728
 729 2020-08-03  Tom de Vries  <tdevries@suse.de>
 730
 731         PR symtab/26333
 732         * dwarf2/read.c (dwarf_decode_lines_1): Ignore
 733         DW_LNE_lo_user/DW_LNE_hi_user range.
 734
 735 2020-07-30  Simon Marchi  <simon.marchi@polymtl.ca>
 736
 737         PR ada/26318
 738         * ada-lang.c (ada_modulus): Return 0 if property is not of const
 739         kind.
 740
 741 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 742
 743         * breakpoint.c (set_breakpoint_condition): Do minor refactoring.
 744
 745 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 746
 747         * breakpoint.c (set_breakpoint_condition): Update the condition
 748         expressions after checking that the input condition string parses
 749         successfully and does not contain junk at the end.
 750
 751 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 752
 753         * breakpoint.c (set_breakpoint_condition): Update the
 754         condition string after parsing the new condition successfully.
 755
 756 2020-07-30  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 757
 758         * proc-api.c (_STRUCTURED_PROC): Don't define.
 759         * proc-events.c: Likewise.
 760         * proc-flags.c: Likewise.
 761         * proc-why.c: Likewise.
 762         * procfs.c: Likewise.
 763
 764         * Makefile.in (INTERNAL_CPPFLAGS): Add LARGEFILE_CPPFLAGS.
 765         * configure, config.in: Regenerate.
 766
 767 2020-07-30  Tom de Vries  <tdevries@suse.de>
 768
 769         PR build/26320
 770         * ui-style.h (struct ui_file_style::color): Wrap m_value and
 771         m_red/m_green/m_blue in a union.
 772
 773 2020-07-29  Tom de Vries  <tdevries@suse.de>
 774
 775         PR tdep/26280
 776         * s390-tdep.c (s390_displaced_step_fixup): Fix Wmaybe-uninitialized.
 777
 778 2020-07-28  Tom Tromey  <tromey@adacore.com>
 779
 780         PR symtab/26270:
 781         * symtab.h (find_pc_partial_function_sym): Declare.
 782         * cli/cli-cmds.c (disassemble_command): Use
 783         find_pc_partial_function_sym.  Check asm_demangle.
 784         * blockframe.c (cache_pc_function_sym): New global.
 785         (cache_pc_function_name): Remove.
 786         (clear_pc_function_cache): Update.
 787         (find_pc_partial_function_sym): New function, from
 788         find_pc_partial_function.
 789         (find_pc_partial_function): Rewrite using
 790         find_pc_partial_function_sym.
 791
 792 2020-07-28  Tom Tromey  <tromey@adacore.com>
 793
 794         * cli/cli-cmds.c (_initialize_cli_cmds): Rearrange "disassemble"
 795         help.  Add usage.
 796
 797 2020-07-28  Tom Tromey  <tromey@adacore.com>
 798
 799         * dwarf2/expr.c (dwarf_expr_context::execute_stack_op)
 800         <DW_OP_GNU_variable_value>: Cast to address type.
 801
 802 2020-07-28  Kamil Rytarowski  <n54@gmx.com>
 803
 804         * nbsd-nat.h (nbsd_nat_target::xfer_partial): New declaration.
 805         * nbsd-nat.c (nbsd_nat_target::xfer_partial): New function.
 806         * nbsd-tdep.c (nbsd_gdbarch_data_handle, struct nbsd_gdbarch_data)
 807         (init_nbsd_gdbarch_data, get_nbsd_gdbarch_data)
 808         (nbsd_get_siginfo_type): New.
 809         (nbsd_init_abi): Install gdbarch "get_siginfo_type" method.
 810         (_initialize_nbsd_tdep): New.
 811
 812 2020-07-28  H.J. Lu  <hongjiu.lu@intel.com>
 813
 814         PR binutils/26301
 815         * configure: Regenerated.
 816
 817 2020-07-28  H.J. Lu  <hongjiu.lu@intel.com>
 818
 819         PR binutils/26301
 820         * configure: Regenerated.
 821
 822 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 823
 824         * python/py-frame.c: Remove 'user-regs.h' include.
 825         (frapy_read_register): Rewrite to make use of
 826         gdbpy_parse_register_id.
 827         * python/py-registers.c (gdbpy_parse_register_id): New function,
 828         moved here from python/py-unwind.c.  Updated the return type, and
 829         also accepts register descriptor objects.
 830         * python/py-unwind.c: Remove 'user-regs.h' include.
 831         (pyuw_parse_register_id): Moved to python/py-registers.c.
 832         (unwind_infopy_add_saved_register): Update to use
 833         gdbpy_parse_register_id.
 834         (pending_framepy_read_register): Likewise.
 835         * python/python-internal.h (gdbpy_parse_register_id): Declare.
 836
 837 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * python/py-registers.c: Add 'user-regs.h' include.
 840         (register_descriptor_iter_find): New function.
 841         (register_descriptor_iterator_object_methods): New static global
 842         methods array.
 843         (register_descriptor_iterator_object_type): Add pointer to methods
 844         array.
 845
 846 2020-07-27  John Baldwin  <jhb@FreeBSD.org>
 847
 848         * fbsd-nat.h: Include <osreldate.h>.  Define USE_SIGTRAP_SIGINFO
 849         for all architectures on FreeBSD 11.3 and later.
 850
 851 2020-07-27  Tom Tromey  <tromey@adacore.com>
 852
 853         * gcore.h (load_corefile): Don't declare.
 854
 855 2020-07-27  Tom de Vries  <tdevries@suse.de>
 856
 857         * configure.ac: Fix sys/sockets.h -> sys/socket.h typo.
 858         * config.in: Regenerate.
 859         * configure: Regenerate.
 860
 861 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
 862
 863         * configure.ac (AC_CHECK_HEADERS): Check for sys/socket.h and
 864         ws2tcpip.h.  When checking whether socklen_t type is defined, use
 865         ws2tcpip.h if it is available and sys/socket.h isn't.
 866         * configure: Regenerate.
 867         * config.in: Regenerate.
 868
 869 2020-07-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 870
 871         PR fortran/23051
 872         PR fortran/26139
 873         * valops.c (value_ind): Pass address to
 874         readjust_indirect_value_type.
 875         * value.c (readjust_indirect_value_type): Make parameter
 876         non-const, and add extra address parameter.  Resolve original type
 877         before using it.
 878         * value.h (readjust_indirect_value_type): Update function
 879         signature and comment.
 880
 881 2020-07-25  Tom de Vries  <tdevries@suse.de>
 882
 883         PR symtab/26243
 884         * dwarf2/read.c (lnp_state_machine::record_line): Ignore zero line
 885         entries.
 886
 887 2020-07-24  Aaron Merey  <amerey@redhat.com>
 888
 889         * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS.
 890         * configure: Rebuild.
 891
 892 2020-07-23  Kevin Buettner  <kevinb@redhat.com>
 893
 894         PR corefiles/26294
 895         * corelow.c (_initialize_corelow): Add period to help text
 896         for "maintenance print core-file-backed-mappings".
 897
 898 2020-07-23  Pedro Alves  <pedro@palves.net>
 899
 900         * frame-unwind.c (frame_unwind_try_unwinder): On exception, don't
 901         touch THIS_CACHE/THIS_FRAME if the frame cache was cleared
 902         meanwhile.
 903         * frame.c (frame_cache_generation, get_frame_cache_generation):
 904         New.
 905         (reinit_frame_cache): Increment FRAME_CACHE_GENERATION.
 906         (get_prev_frame_if_no_cycle): On exception, don't touch
 907         PREV_FRAME/THIS_FRAME if the frame cache was cleared meanwhile.
 908         * frame.h (get_frame_cache_generation): Declare.
 909
 910 2020-07-23  Tom de Vries  <tdevries@suse.de>
 911
 912         PR tui/26282
 913         * tui/tui-winsource.h (struct tui_source_windows::tui_source_windows):
 914         New default constructor.
 915
 916 2020-07-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * disasm.c (do_mixed_source_and_assembly_deprecated): Don't
 919         exclude non-statement entries.
 920
 921 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 922
 923         * NEWS (New commands): Mention new command
 924         "maintenance print core-file-backed-mappings".
 925
 926 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 927
 928         * corelow.c (gdbcmd.h): Include.
 929         (core_target::info_proc_mappings): New method.
 930         (get_current_core_target): New function.
 931         (maintenance_print_core_file_backed_mappings): New function.
 932         (_initialize_corelow): Add core-file-backed-mappings to
 933         "maint print" commands.
 934
 935 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 936
 937         * linux-tdep.c (dump_note_entry_p): New function.
 938         (linux_dump_mapping_p_ftype): New typedef.
 939         (linux_find_memory_regions_full): Add new parameter,
 940         should_dump_mapping_p.
 941         (linux_find_memory_regions): Adjust call to
 942         linux_find_memory_regions_full.
 943         (linux_make_mappings_core_file_notes): Use dump_note_entry_p in
 944         call to linux_find_memory_regions_full.
 945
 946 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 947
 948         * corelow.c (solist.h, unordered_map): Include.
 949         (class core_target): Add field m_core_file_mappings and
 950         method build_file_mappings.
 951         (core_target::core_target): Call build_file_mappings.
 952         (core_target::~core_target): Free memory associated with
 953         m_core_file_mappings.
 954         (core_target::build_file_mappings): New method.
 955         (core_target::xfer_partial): Use m_core_file_mappings
 956         for memory transfers.
 957         * linux-tdep.c (linux_read_core_file_mappings): New
 958         function.
 959         (linux_core_info_proc_mappings): Rewrite to use
 960         linux_read_core_file_mappings.
 961         (linux_init_abi): Register linux_read_core_file_mappings.
 962
 963 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 964
 965         * arch-utils.c (default_read_core_file_mappings): New function.
 966         * arch-utils.c (default_read_core_file_mappings): Declare.
 967         * gdbarch.sh (read_core_file_mappings): New gdbarch method.
 968         * gdbarch.h, gdbarch.c: Regenerate.
 969
 970 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 971
 972         PR corefiles/25631
 973         * corelow.c (core_target:xfer_partial):  Revise
 974         TARGET_OBJECT_MEMORY case to consider non-SEC_HAS_CONTENTS
 975         case after first checking the stratum beneath the core
 976         target.
 977         (has_all_memory): Return true.
 978         * target.c (raw_memory_xfer_partial): Revise comment
 979         regarding use of has_all_memory.
 980
 981 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 982
 983         * exec.h (section_table_xfer_memory): Revise declaration,
 984         replacing section name parameter with an optional callback
 985         predicate.
 986         * exec.c (section_table_xfer_memory): Likewise.
 987         * bfd-target.c, exec.c, target.c, corelow.c: Adjust all callers
 988         of section_table_xfer_memory.
 989
 990 2020-07-22  Tom Tromey  <tromey@adacore.com>
 991
 992         * mi/mi-cmd-stack.c (list_args_or_locals): Use
 993         lookup_symbol_search_name.
 994
 995 2020-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 996
 997         * python/py-registers.c (gdbpy_register_object_data_init): Remove
 998         redundant local variable.
 999         (gdbpy_get_register_descriptor): Extract descriptor vector as a
1000         reference, not pointer, update code accordingly.
1001
1002 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1003             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1004
1005         * objfiles.h (struct objfile) <skip_jit_symbol_lookup>: New field.
1006         * jit.c (jit_breakpoint_re_set_internal): Use the
1007         `skip_jit_symbol_lookup` field.
1008
1009 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1010             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1011
1012         * jit.c (jit_read_descriptor): Define the descriptor address once,
1013         use twice.
1014         (jit_breakpoint_deleted): Move the declaration of the loop variable
1015         `iter` into the loop header.
1016         (jit_breakpoint_re_set_internal): Move the declaration of the local
1017         variable `objf_data` to the first point of definition.
1018         (jit_event_handler): Move the declaration of local variables
1019         `code_entry`, `entry_addr`, and `objf` to their first point of use.
1020         Rename `objf` to `jited`.
1021
1022 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1023
1024         * jit.h (struct jiter_objfile_data) <jiter_objfile_data, objfile>:
1025         Remove.
1026         * jit.c (get_jiter_objfile_data): Update.
1027
1028 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1029             Simon Marchi  <simon.marchi@polymtl.ca>
1030
1031         * jit.c (struct jit_program_space_data): Remove.
1032         (jit_program_space_key): Remove.
1033         (jiter_objfile_data::~jiter_objfile_data): Remove program space
1034         stuff.
1035         (get_jit_program_space_data): Remove.
1036         (jit_breakpoint_deleted): Iterate on all of the program space's
1037         objfiles.
1038         (jit_inferior_init): Likewise.
1039         (jit_breakpoint_re_set_internal): Likewise.  Also change return
1040         type to void.
1041         (jit_breakpoint_re_set): Pass current_program_space to
1042         jit_breakpoint_re_set_internal.
1043
1044 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1045
1046         * jit.h (struct jiter_objfile_data) <cached_code_address,
1047         jit_breakpoint>: Move to here from ...
1048         * jit.c (jit_program_space_data): ... here.
1049         (jiter_objfile_data::~jiter_objfile_data): Update.
1050         (jit_breakpoint_deleted): Update.
1051         (jit_breakpoint_re_set_internal): Update.
1052
1053 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1054
1055         * jit.c (jiter_objfile_data::~jiter_objfile_data): Remove some
1056         checks.
1057         (jit_read_descriptor): Remove NULL check.
1058         (jit_event_handler): Add an assertion.
1059
1060 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1061
1062         * jit.h (struct jit_objfile_data):  Split into...
1063         (struct jiter_objfile_data): ... this ...
1064         (struct jited_objfile_data): ... and this.
1065         * objfiles.h (struct objfile) <jit_data>: Remove.
1066         <jiter_data, jited_data>: New fields.
1067         * jit.c (jit_objfile_data::~jit_objfile_data): Rename to ...
1068         (jiter_objfile_data::~jiter_objfile_data): ... this.
1069         (get_jit_objfile_data): Rename to ...
1070         (get_jiter_objfile_data): ... this.
1071         (add_objfile_entry): Update.
1072         (jit_read_descriptor): Use get_jiter_objfile_data.
1073         (jit_find_objf_with_entry_addr): Use objfile's jited_data field.
1074         (jit_breakpoint_re_set_internal): Use get_jiter_objfile_data.
1075         (jit_inferior_exit_hook): Use objfile's jited_data field.
1076
1077 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1078
1079         * jit.h: Forward-declare `struct minimal_symbol`.
1080         (struct jit_objfile_data): Migrate to here from jit.c; also add a
1081         constructor, destructor, and an objfile* field.
1082         * jit.c (jit_objfile_data): Remove.
1083         (struct jit_objfile_data): Migrate from here to jit.h.
1084         (jit_objfile_data::~jit_objfile_data): New destructor
1085         implementation with code moved from free_objfile_data.
1086         (free_objfile_data): Delete.
1087         (get_jit_objfile_data): Update to use the jit_data field of objfile.
1088         (jit_find_objf_with_entry_addr): Ditto.
1089         (jit_inferior_exit_hook): Ditto.
1090         (_initialize_jit): Remove the call to
1091         register_objfile_data_with_cleanup.
1092         * objfiles.h (struct objfile) <jit_data>: New field.
1093
1094 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1095
1096         * jit.h: Forward-declare `struct objfile`.
1097         (jit_event_handler): Add a second parameter, the JITer objfile.
1098         * jit.c (jit_read_descriptor): Change the signature to take the
1099         JITer objfile as an argument instead of the jit_program_space_data.
1100         (jit_inferior_init): Update the call to jit_read_descriptor.
1101         (jit_event_handler): Use the new JITer objfile argument when calling
1102         jit_read_descriptor.
1103         * breakpoint.c (handle_jit_event): Update the call to
1104         jit_event_handler to pass the JITer objfile.
1105
1106 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1107
1108         * gdbarch.c: Regenerate.
1109         * gdbarch.h: Regenerate.
1110         * gdbarch.sh (handle_segmentation_fault): Remove method.
1111         * infrun.c (handle_segmentation_fault): Remove.
1112         (print_signal_received_reason): Remove call to
1113         handle_segmentation_fault.
1114
1115 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1116
1117         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1118         Rename to sparc64_linux_report_signal_info and add siggnal
1119         argument.
1120         (sparc64_linux_init_abi): Use sparc64_linux_report_signal_info
1121         instead of sparc64_linux_handle_segmentation_fault.
1122
1123 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1124
1125         * amd64-linux-tdep.c (amd64_linux_init_abi_common): Use
1126         i386_linux_report_signal_info instead of
1127         i386_linux_handle_segmentation_fault.
1128         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Rename
1129         to i386_linux_report_signal_info and add siggnal argument.
1130         (i386_linux_init_abi): Use i386_linux_report_signal_info instead
1131         of i386_linux_handle_segmentation_fault.
1132         * i386-linux-tdep.h (i386_linux_handle_segmentation_fault): Rename
1133         to i386_linux_report_signal_info and add siggnal argument.
1134
1135 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1136
1137         * corelow.c (core_target_open): Invoke gdbarch report_signal_info
1138         hook if present.
1139
1140 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1141
1142         * gdbarch.c: Regenerate.
1143         * gdbarch.h: Regenerate.
1144         * gdbarch.sh (report_signal_info): New method.
1145         * infrun.c (print_signal_received_reason): Invoke gdbarch
1146         report_signal_info hook if present.
1147
1148 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1149
1150         * python/py-registers.c : Add 'unordered_map' include.
1151         (gdbpy_new_reggroup): Renamed to...
1152         (gdbpy_get_reggroup): ...this.  Update to only create register
1153         group descriptors when needed.
1154         (gdbpy_reggroup_iter_next): Update.
1155
1156 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * python/py-registers.c (gdbpy_register_object_data): New static
1159         global.
1160         (gdbpy_register_object_data_init): New function.
1161         (gdbpy_new_register_descriptor): Renamed to...
1162         (gdbpy_get_register_descriptor): ...this, and update to reuse
1163         existing register descriptors where possible.
1164         (gdbpy_register_descriptor_iter_next): Update.
1165         (gdbpy_initialize_registers): Register new gdbarch data.
1166
1167 2020-07-21  Simon Marchi  <simon.marchi@efficios.com>
1168
1169         * linux-nat.c (stopped_pids): Make static.
1170
1171 2020-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
1172
1173         PR ada/26235
1174         * gdbtypes.c (ada_discrete_type_low_bound,
1175         ada_discrete_type_high_bound): Handle undefined bounds.
1176
1177 2020-07-21  Kamil Rytarowski  <n54@gmx.com>
1178
1179         * nbsd-nat.h (nbsd_nat_target::supports_multi_process): New
1180         declaration.
1181         * nbsd-nat.c (nbsd_nat_target::supports_multi_process): New
1182         function.
1183
1184 2020-07-20  John Baldwin  <jhb@FreeBSD.org>
1185
1186         * fbsd-tdep.c (fbsd_skip_solib_resolver): New function.
1187         (fbsd_init_abi): Install gdbarch "skip_solib_resolver" method.
1188         * fbsd-tdep.h (fbsd_skip_solib_resolver): New prototype.
1189         * mips-fbsd-tdep.c (mips_fbsd_skip_solib_resolver): New function.
1190         (mips_fbsd_init_abi): Install gdbarch "skip_solib_resolver"
1191         method.
1192
1193 2020-07-20 Ludovic Courtès  <ludo@gnu.org>
1194
1195         * guile/scm-math.c (vlscm_integer_fits_p): Use 'uintmax_t'
1196         and 'intmax_t' instead of 'scm_t_uintmax' and 'scm_t_intmax',
1197         which are deprecated in Guile 3.0.
1198         * configure.ac (try_guile_versions): Add "guile-3.0".
1199         * configure (try_guile_versions): Regenerate.
1200         * NEWS: Update entry.
1201
1202 2020-07-20  Ludovic Courtès  <ludo@gnu.org>
1203             Doug Evans  <dje@google.com>
1204
1205         PR gdb/21104
1206         * guile/scm-ports.c (USING_GUILE_BEFORE_2_2): New macro.
1207         (ioscm_memory_port)[read_buf_size, write_buf_size]: Wrap in #if
1208         USING_GUILE_BEFORE_2_2.
1209         (stdio_port_desc, memory_port_desc) [!USING_GUILE_BEFORE_2_2]:
1210         Change type to 'scm_t_port_type *'.
1211         (natural_buffer_size) [!USING_GUILE_BEFORE_2_2]: New variable.
1212         (ioscm_open_port) [USING_GUILE_BEFORE_2_2]: Add 'stream'
1213         parameter and honor it.  Update callers.
1214         (ioscm_open_port) [!USING_GUILE_BEFORE_2_2]: New function.
1215         (ioscm_read_from_port, ioscm_write) [!USING_GUILE_BEFORE_2_2]: New
1216         functions.
1217         (ioscm_fill_input, ioscm_input_waiting, ioscm_flush): Wrap in #if
1218         USING_GUILE_BEFORE_2_2.
1219         (ioscm_init_gdb_stdio_port) [!USING_GUILE_BEFORE_2_2]: Use
1220         'ioscm_read_from_port'.  Call 'scm_set_port_read_wait_fd'.
1221         (ioscm_init_stdio_buffers) [!USING_GUILE_BEFORE_2_2]: New function.
1222         (gdbscm_stdio_port_p) [!USING_GUILE_BEFORE_2_2]: Use 'SCM_PORTP'
1223         and 'SCM_PORT_TYPE'.
1224         (gdbscm_memory_port_end_input, gdbscm_memory_port_seek)
1225         (ioscm_reinit_memory_port): Wrap in #if USING_GUILE_BEFORE_2_2.
1226         (gdbscm_memory_port_read, gdbscm_memory_port_write)
1227         (gdbscm_memory_port_seek, gdbscm_memory_port_close)
1228         [!USING_GUILE_BEFORE_2_2]: New functions.
1229         (gdbscm_memory_port_print): Remove use of 'SCM_PTOB_NAME'.
1230         (ioscm_init_memory_port_type) [!USING_GUILE_BEFORE_2_2]: Use
1231         'gdbscm_memory_port_read'.
1232         Wrap 'scm_set_port_end_input', 'scm_set_port_flush', and
1233         'scm_set_port_free' calls in #if USING_GUILE_BEFORE_2_2.
1234         (gdbscm_get_natural_buffer_sizes) [!USING_GUILE_BEFORE_2_2]: New
1235         function.
1236         (ioscm_init_memory_port): Remove.
1237         (ioscm_init_memory_port_stream): New function
1238         (ioscm_init_memory_port_buffers) [USING_GUILE_BEFORE_2_2]: New
1239         function.
1240         (gdbscm_memory_port_read_buffer_size) [!USING_GUILE_BEFORE_2_2]:
1241         Return scm_from_uint (0).
1242         (gdbscm_set_memory_port_read_buffer_size_x)
1243         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
1244         (gdbscm_memory_port_write_buffer_size) [!USING_GUILE_BEFORE_2_2]:
1245         Return scm_from_uint (0).
1246         (gdbscm_set_memory_port_write_buffer_size_x)
1247         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
1248         * configure.ac (try_guile_versions): Add "guile-2.2".
1249         * configure: Regenerate.
1250         * NEWS: Add entry.
1251
1252 2020-07-18  Tom Tromey  <tom@tromey.com>
1253
1254         * linux-nat.c (linux_multi_process): Remove.
1255         (linux_nat_target::supports_multi_process): Return true.
1256
1257 2020-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * arch/riscv.c (riscv_tdesc_cache): Change map type.
1260         (riscv_lookup_target_description): Return pointer out of
1261         unique_ptr.
1262         * target-descriptions.c (allocate_target_description): Add
1263         comment.
1264         (target_desc_deleter::operator()): Likewise.
1265         * target-descriptions.h (struct target_desc_deleter): Moved to
1266         gdbsupport/tdesc.h.
1267         (target_desc_up): Likewise.
1268
1269 2020-07-17  Tom Tromey  <tromey@adacore.com>
1270
1271         * linux-nat.c (linux_nat_target::supports_non_stop)
1272         (linux_nat_target::always_non_stop_p): Use "true".
1273         (linux_nat_target::supports_disable_randomization): Use "true" and
1274         "false".
1275
1276 2020-07-16  Caroline Tice  <cmtice@google.com>
1277
1278         * dwarf2/read.c (RNGLIST_HEADER_SIZE32) New constant definition.
1279         (RNGLIST_HEADER_SIZE64): New constant definition.
1280         (struct dwop_section_names): Add rnglists_dwo.
1281         (dwop_section_names): Add .debug_rnglists.dwo, .zdebug_rnglists.dwo.
1282         (struct loclist_header): Rename to 'loclists_rnglists_header'.
1283         (struct dwo_sections): Add rnglists field.
1284         (read_attribut_reprocess): Add tag parameter.
1285         (dwarf2_ranges_read): Add tag parameter & remove forward function decl.
1286         (cu_debug_rnglists_section): New function (decl & definition).
1287         (dwarf2_locate_dwo_sections): Add code to read rnglists_dwo section.
1288         (dwarf2_rnglists_process): Add a dwarf_tag parameter, for the kind of
1289         die whose range is being checked; get rnglist section from
1290         cu_debug_rnglists_section, to get from either objfile or dwo file as
1291         appropriate.  Add cases for DW_RLE_base_addressx,
1292         DW_RLE_startx_length, DW_RLE_startx_endx.  Also, update to only add
1293         the base address to DW_RLE_offset_pairs (not to all ranges), moving
1294         test inside if-condition and updating complaint message.
1295         (dwarf2_ranges_process): Add dwarf tag parameter and pass it to
1296         dwarf2_rnglists_process.
1297         (dwarf2_ranges_read): Add dwarf tag parameter and pass it to
1298         dwarf2_ranges_process.
1299         (dwarf2_get_pc_bounds): Check for DW_FORM_rnglistx when setting
1300         need_ranges_base and update comment appropriately.  Also pass die tag
1301         to dwarf2_ranges_read.
1302         (dwarf2_record_block_ranges): Check for DW_FORM_rnglistx when setting
1303         need_ranges_base and update comment appropriately.  Also pass die tag
1304         to dwarf2_ranges_process.
1305         (read_full_die_1): Add code to read DW_AT_rnglists_base and assign to
1306         cu->ranges_base.  Also pass die tag to read_attribute_reprocess.
1307         (partial_die_info::read): Check for DW_FORM_rnglistx when setting
1308         need_ranges_base and update comment appropriately.  Also pass die tag
1309         to read_attribute_reprocess and dwarf2_ranges_read.
1310         (read_loclist_header): Rename function to read_loclists_rnglists_header,
1311         and update function comment appropriately.
1312         (read_loclist_index): Call read_loclists_rnglists_header instead of
1313         read_loclist_header.
1314         (read_rnglist_index): New function.
1315         (read_attribute_reprocess):  Add tag parameter. Add code for
1316         DW_FORM_rnglistx, passing tag to read_rnglist_index.
1317         (read_attribute_value): Mark DW_FORM_rnglistx with need_reprocess.
1318
1319 2020-07-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * f-typeprint.c (f_type_print_base): Allow for dynamic types not
1322         being resolved.
1323
1324 2020-07-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * arch-utils.c (show_architecture): Update formatting of messages.
1327
1328 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1329
1330         * gdbtypes.h (struct type) <bounds>: Handle array and string
1331         types.
1332         * ada-lang.c (assign_aggregate): Use type::bounds on
1333         array/string type.
1334         * c-typeprint.c (c_type_print_varspec_suffix): Likewise.
1335         * c-varobj.c (c_number_of_children): Likewise.
1336         (c_describe_child): Likewise.
1337         * eval.c (evaluate_subexp_for_sizeof): Likewise.
1338         * f-typeprint.c (f_type_print_varspec_suffix): Likewise.
1339         (f_type_print_base): Likewise.
1340         * f-valprint.c (f77_array_offset_tbl): Likewise.
1341         (f77_get_upperbound): Likewise.
1342         (f77_print_array_1): Likewise.
1343         * guile/scm-type.c (gdbscm_type_range): Likewise.
1344         * m2-typeprint.c (m2_array): Likewise.
1345         (m2_is_long_set_of_type): Likewise.
1346         * m2-valprint.c (get_long_set_bounds): Likewise.
1347         * p-typeprint.c (pascal_type_print_varspec_prefix): Likewise.
1348         * python/py-type.c (typy_range): Likewise.
1349         * rust-lang.c (rust_internal_print_type): Likewise.
1350         * type-stack.c (type_stack::follow_types): Likewise.
1351         * valarith.c (value_subscripted_rvalue): Likewise.
1352         * valops.c (value_cast): Likewise.
1353
1354 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1355
1356         * gdbtypes.c (TYPE_ARRAY_BIT_STRIDE): Remove.  Update all
1357         callers to use the equivalent accessor methods.
1358
1359 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1360
1361         * gdbtypes.h (struct range_bounds) <bit_stride>: New method.
1362         (struct type) <bit_stride>: New method.
1363         (TYPE_BIT_STRIDE): Remove.
1364         * gdbtypes.c (update_static_array_size): Use type::bit_stride.
1365
1366 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1367
1368         * gdbtypes.h (TYPE_ARRAY_LOWER_BOUND_VALUE,
1369         TYPE_ARRAY_UPPER_BOUND_VALUE): Remove.  Update all
1370         callers to use the equivalent accessor methods instead.
1371
1372 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1373
1374         * gdbtypes.h (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED,
1375         TYPE_ARRAY_LOWER_BOUND_IS_UNDEFINED): Remove.  Update all
1376         callers to use the equivalent accessor methods instead.
1377
1378 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1379
1380         * gdbtypes.h (TYPE_LOW_BOUND_KIND,
1381         TYPE_HIGH_BOUND_KIND): Remove.  Update all callers
1382         to use dynamic_prop::kind.
1383
1384 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1385
1386         * gdbtypes.h (TYPE_LOW_BOUND_UNDEFINED,
1387         TYPE_HIGH_BOUND_UNDEFINED): Remove.  Update all callers
1388         to get the bound property's kind and check against
1389         PROP_UNDEFINED.
1390
1391 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1392
1393         * gdbtypes.h (TYPE_LOW_BOUND, TYPE_HIGH_BOUND): Remove.  Update
1394         all callers to use type::range_bounds followed by
1395         dynamic_prop::{low,high}.
1396
1397 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
1398
1399         * gdbtypes.h (struct dynamic_prop) <kind, set_undefined,
1400         const_val, set_const_val, baton, set_locexpr, set_loclist,
1401         set_addr_offset, variant_parts, set_variant_parts,
1402         original_type, set_original_type>: New methods.
1403         <kind>: Rename to...
1404         <m_kind>: ... this.  Update all users to use the new methods
1405         instead.
1406         <data>: Rename to...
1407         <m_data>: ... this.  Update all users to use the new methods
1408         instead.
1409
1410 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1411
1412         * gdbtypes.c (get_discrete_bounds): Return failure if
1413         the range type's bounds are not both defined and constant
1414         values.
1415         (get_array_bounds): Update comment.  Remove undefined bound check.
1416
1417 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
1418
1419         * gdbtypes.h (TYPE_RANGE_DATA): Remove.  Update callers to use
1420         the type::bounds method directly.
1421
1422 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1423
1424         * gdbtypes.h (struct type) <bounds, set_bounds>: New methods.
1425         (TYPE_RANGE_DATA): Use type::bounds.  Change all uses that
1426         are used to set the range type's bounds to use set_bounds.
1427
1428 2020-07-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1429
1430         * exec.c (_initialize_exec): Update exec-file-mismatch help.
1431
1432 2020-07-10  Pedro Alves  <pedro@palves.net>
1433
1434         * gdbthread.h (inferior_ref): Define.
1435         (scoped_restore_current_thread) <m_thread>: Now a thread_info_ref.
1436         (scoped_restore_current_thread) <m_inf>: Now an inferior_ref.
1437         * thread.c
1438         (scoped_restore_current_thread::restore):
1439         Adjust to gdb::ref_ptr.
1440         (scoped_restore_current_thread::~scoped_restore_current_thread):
1441         Remove manual decref handling.
1442         (scoped_restore_current_thread::scoped_restore_current_thread):
1443         Adjust to use
1444         inferior_ref::new_reference/thread_info_ref::new_reference.
1445         Incref the thread before calling get_frame_id instead of after.
1446         Let TARGET_CLOSE_ERROR propagate.
1447
1448 2020-07-10  Pedro Alves  <pedro@palves.net>
1449
1450         * frame-tailcall.c (dwarf2_tailcall_sniffer_first): Only swallow
1451         NO_ENTRY_VALUE_ERROR / MEMORY_ERROR / OPTIMIZED_OUT_ERROR /
1452         NOT_AVAILABLE_ERROR.
1453         * value.c (value_optimized_out): Only swallow MEMORY_ERROR /
1454         OPTIMIZED_OUT_ERROR / NOT_AVAILABLE_ERROR.
1455
1456 2020-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1457             Pedro Alves  <pedro@palves.net>
1458
1459         PR gdb/26199
1460         * infrun.c (threads_are_resumed_pending_p): Delete.
1461         (do_target_wait): Remove threads_are_executing and
1462         threads_are_resumed_pending_p checks from the inferior_matches
1463         lambda.  Update comments.
1464
1465 2020-07-10  Pedro Alves  <pedro@palves.net>
1466
1467         PR gdb/26199
1468         * infrun.c (handle_no_resumed): Transfer terminal to inferior with
1469         executing threads.
1470
1471 2020-07-10  Pedro Alves  <pedro@palves.net>
1472
1473         PR gdb/26199
1474         * infrun.c (handle_no_resumed): Handle multiple targets.
1475
1476 2020-07-10  Pedro Alves  <pedro@palves.net>
1477
1478         PR gdb/26199
1479         * infrun.c (prepare_to_wait): Check target_can_async_p instead of
1480         target_is_async_p.
1481
1482 2020-07-10  Pedro Alves  <pedro@palves.net>
1483
1484         PR gdb/26199
1485         * target.c (target_pass_ctrlc): Look at the inferior's non-exited
1486         threads, not all threads.
1487
1488 2020-07-10  Pedro Alves  <pedro@palves.net>
1489
1490         PR gdb/26199
1491         * remote.c (remote_target::open_1): Pass remote target pointer as
1492         data to create_async_event_handler.
1493         (remote_async_inferior_event_handler): Mark async event handler
1494         before returning if the remote target still has either pending
1495         events or unacknowledged notifications.
1496
1497 2020-07-10  John Baldwin  <jhb@FreeBSD.org>
1498
1499         * fbsd-nat.h (fbsd_nat_target::supports_multi_process): New
1500         declaration.
1501         * fbsd-nat.c (fbsd_nat_target::supports_multi_process): New
1502         function.
1503
1504 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
1505
1506         * inf-ptrace.c (inf_ptrace_target::wait): Don't compare against
1507         inferior_ptid.
1508
1509 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
1510
1511         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_ARGC,
1512         AT_FREEBSD_ARGV, AT_FREEBSD_ENVC, AT_FREEBSD_ENVV,
1513         AT_FREEBSD_PS_STRINGS.
1514
1515 2020-07-08  Hannes Domani  <ssbssa@yahoo.de>
1516
1517         * auto-load.c (auto_load_objfile_script_1): Convert drive part
1518         of debugfile path on Windows.
1519
1520 2020-07-08  John Baldwin  <jhb@FreeBSD.org>
1521
1522         * fbsd-nat.c (fbsd_nat_target::find_memory_regions): Rename 'obfd'
1523         argument to 'data'.
1524
1525 2020-07-08  Tom Tromey  <tromey@adacore.com>
1526
1527         * ada-lang.c (ada_exception_message_1): Use read_memory.
1528
1529 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1530
1531         PR python/22748
1532         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Remove
1533         special handling for inline frames.
1534         * findvar.c (value_of_register_lazy): Skip inline frames when
1535         creating lazy register values.
1536         * frame.c (frame_id_computed_p): Delete definition.
1537         * frame.h (frame_id_computed_p): Delete declaration.
1538
1539 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1540
1541         * NEWS: Mention additions to Python API.
1542         * python/py-arch.c (archpy_register_groups): New function.
1543         (arch_object_methods): Add 'register_groups' method.
1544         * python/py-registers.c (reggroup_iterator_object): New struct.
1545         (reggroup_object): New struct.
1546         (gdbpy_new_reggroup): New function.
1547         (gdbpy_reggroup_to_string): New function.
1548         (gdbpy_reggroup_name): New function.
1549         (gdbpy_reggroup_iter): New function.
1550         (gdbpy_reggroup_iter_next): New function.
1551         (gdbpy_new_reggroup_iterator): New function
1552         (gdbpy_initialize_registers): Register new types.
1553         (reggroup_iterator_object_type): Define new Python type.
1554         (gdbpy_reggroup_getset): New static global.
1555         (reggroup_object_type): Define new Python type.
1556         * python/python-internal.h
1557
1558 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1559
1560         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-registers.c
1561         * python/py-arch.c (archpy_registers): New function.
1562         (arch_object_methods): Add 'registers' method.
1563         * python/py-registers.c: New file.
1564         * python/python-internal.h
1565         (gdbpy_new_register_descriptor_iterator): Declare.
1566         (gdbpy_initialize_registers): Declare.
1567         * python/python.c (do_start_initialization): Call
1568         gdbpy_initialize_registers.
1569         * NEWS: Mention additions to the Python API.
1570
1571 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1572
1573         * NEWS: Mention new Python API method.
1574         * python/py-unwind.c (pending_framepy_architecture): New function.
1575         (pending_frame_object_methods): Add architecture method.
1576
1577 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1578
1579         * gdbarch.c: Regenerate.
1580         * gdbarch.h: Regenerate.
1581         * gdbarch.sh (deprecated_set_gdbarch_data): Delete.
1582         (gdbarch_data): Use internal_error for the case where
1583         deprecated_set_gdbarch_data was originally needed.
1584         * ia64-libunwind-tdep.c (libunwind_descr_init): Update parameters,
1585         and use passed in obstack.
1586         (libunwind_frame_set_descr): Should no longer get back NULL from
1587         gdbarch_data.
1588         (_initialize_libunwind_frame): Register as a pre-init gdbarch data
1589         type.
1590         * user-regs.c (user_regs_init): Update parameters, and use passed
1591         in obstack.
1592         (user_reg_add): Should no longer get back NULL from gdbarch_data.
1593         (_initialize_user_regs): Register as a pre-init gdbarch data type.
1594
1595 2020-07-06  Tom de Vries  <tdevries@suse.de>
1596
1597         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Handle
1598         End-Of-Sequence in lte_is_less_than.
1599         * symtab.c (find_pc_sect_line): Revert change from commit 3d92a3e313
1600         "gdb: Don't reorder line table entries too much when sorting".
1601
1602 2020-07-06  Tom de Vries  <tdevries@suse.de>
1603
1604         PR tui/26205
1605         * tui/tui-win.c (tui_partial_win_by_name): Don't test for NULL name.
1606
1607 2020-07-05  Tom de Vries  <tdevries@suse.de>
1608
1609         PR build/26187
1610         * inferior.h (struct infcall_suspend_state_deleter): If available, use
1611         std::uncaught_exceptions instead of deprecated
1612         std::uncaught_exception.
1613
1614 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1615
1616         * macroexp.h (macro_stringify): Return
1617         gdb::unique_xmalloc_ptr<char>.
1618         * macroexp.c (macro_stringify): Likewise.
1619         * macrotab.c (fixup_definition): Update.
1620
1621 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1622
1623         * c-exp.y (scan_macro_expansion): Don't free `expansion`.
1624         (lex_one_token): Update.
1625         * macroexp.c (struct macro_buffer) <release>: Return
1626         gdb::unique_xmalloc_ptr<char>.
1627         (macro_stringify): Update.
1628         (macro_expand): Update.
1629         (macro_expand_next): Return gdb::unique_xmalloc_ptr<char>.
1630         * macroexp.h (macro_expand_next): Likewise.
1631
1632 2020-07-02  Simon Marchi  <simon.marchi@efficios.com>
1633
1634         * macroexp.h (macro_lookup_ftype): Remove.
1635         (macro_expand, macro_expand_once, macro_expand_next): Remove
1636         lookup function parameters, add scope parameter.
1637         * macroexp.c (scan, substitute_args, expand, maybe_expand,
1638         macro_expand, macro_expand_once, macro_expand_next): Likewise.
1639         * macroscope.h (standard_macro_lookup): Change parameter type
1640         to macro_scope.
1641         * macroscope.c (standard_macro_lookup): Likewise.
1642         * c-exp.y (lex_one_token): Update.
1643         * macrocmd.c (macro_expand_command): Likewise.
1644         (macro_expand_once_command): Likewise.
1645
1646 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1647
1648         * inf-loop.c (inferior_event_handler): Remove client_data param.
1649         * inf-loop.h (inferior_event_handler): Likewise.
1650         * infcmd.c (step_1): Adjust.
1651         * infrun.c (proceed): Adjust.
1652         (fetch_inferior_event): Remove client_data param.
1653         (infrun_async_inferior_event_handler): Adjust.
1654         * infrun.h (fetch_inferior_event): Remove `void *` param.
1655         * linux-nat.c (handle_target_event): Adjust.
1656         * record-btrace.c (record_btrace_handle_async_inferior_event):
1657         Adjust.
1658         * record-full.c (record_full_async_inferior_event_handler):
1659         Adjust.
1660         * remote.c (remote_async_inferior_event_handler): Adjust.
1661
1662 2020-07-01  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-data.h (struct tui_win_info) <name>: Now pure virtual.
1665         * tui/tui-stack.h (struct tui_locator_window) <name>: New method.
1666
1667 2020-07-01  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-wingeneral.c (tui_win_info::refresh_window): Move from
1670         tui_gen_win_info.
1671         (tui_win_info::make_window): Merge with
1672         tui_gen_win_info::make_window.
1673         (tui_win_info::make_visible): Move from tui_gen_win_info.
1674         * tui/tui-win.c (tui_win_info::max_width): Move from
1675         tui_gen_win_info.
1676         * tui/tui-layout.h (class tui_layout_window) <m_window>: Change
1677         type.
1678         <window_factory>: Likewise.
1679         * tui/tui-layout.c (tui_win_info::resize): Move from
1680         tui_gen_win_info.
1681         (make_standard_window): Change return type.
1682         (get_locator_window, tui_get_window_by_name): Likewise.
1683         (tui_layout_window::apply): Remove a cast.
1684         * tui/tui-data.h (MIN_WIN_HEIGHT): Move earlier.
1685         (struct tui_win_info): Merge with tui_gen_win_info.
1686         (struct tui_gen_win_info): Remove.
1687
1688 2020-07-01  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-stack.h (struct tui_locator_window): Derive from
1691         tui_win_info.
1692         <do_scroll_horizontal, do_scroll_vertical>: New methods.
1693         <can_box>: New method.
1694
1695 2020-07-01  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-stack.h (struct tui_locator_window): Remove body.
1698
1699 2020-07-01  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-regs.c (tui_data_window::display_registers_from)
1702         (tui_data_window::display_registers_from)
1703         (tui_data_window::first_data_item_displayed)
1704         (tui_data_window::delete_data_content_windows): Update.
1705         (tui_data_window::refresh_window, tui_data_window::no_refresh):
1706         Remove.
1707         (tui_data_window::check_register_values): Update.
1708         (tui_data_item_window::rerender): Add parameters.  Update.
1709         (tui_data_item_window::refresh_window): Remove.
1710         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: No longer
1711         virtual.
1712         * tui/tui-regs.h (struct tui_data_item_window): Don't derive from
1713         tui_gen_win_info.
1714         <refresh_window, max_height, min_height>: Remove.
1715         <rerender>: Add parameters.
1716         <x, y, visible>: New members.
1717         (struct tui_data_window) <refresh_window, no_refresh>: Remove.
1718         <m_item_width>: New member.
1719
1720 2020-07-01  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-regs.c (tui_data_window::show_register_group)
1723         (tui_data_window::check_register_values): Update.
1724         * tui/tui-regs.h (struct tui_data_item_window) <regno>: Rename
1725         from item_no.
1726
1727 2020-07-01  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-regs.c (tui_data_window::show_register_group): Remove
1730         useless "if".
1731
1732 2020-07-01  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1735         * tui/tui-regs.h (struct tui_data_item_window) <name>: Remove.
1736
1737 2020-07-01  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-stack.c (SINGLE_KEY): Move from tui-data.h
1740         * tui/tui-winsource.h (enum tui_line_or_address_kind)
1741         (struct tui_line_or_address): Move from tui-data.h.
1742         * tui/tui-win.c (DEFAULT_TAB_LEN): Move from tui-data.h.
1743         * tui/tui-data.h (DEFAULT_TAB_LEN): Move to tui-win.c.
1744         (tui_cmd_window, tui_source_window_base, tui_source_window)
1745         (tui_disasm_window): Don't declare.
1746         (enum tui_line_or_address_kind, struct tui_line_or_address): Move
1747         to tui-winsource.h.
1748         (SINGLE_KEY): Move to tui-stack.c.
1749
1750 2020-07-01  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-regs.h (struct tui_data_item_window) <content>: Now a
1753         std::string.
1754         * tui/tui-regs.c (class tab_expansion_file): New.
1755         (tab_expansion_file::write): New method.
1756         (tui_register_format): Change return type.  Use
1757         tab_expansion_file.
1758         (tui_get_register, tui_data_window::display_registers_from)
1759         (tui_data_item_window::rerender): Update.
1760         * tui/tui-io.h (tui_expand_tabs): Don't declare.
1761         * tui/tui-io.c (tui_expand_tabs): Remove.
1762
1763 2020-07-01  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.
1766
1767 2020-07-01  Fangrui Song  <maskray@google.com>
1768
1769         * dwarf2/read.c (lnp_state_machine::check_line_address): Test -1.
1770
1771 2020-07-01  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1772
1773         * dwarf2/read.c (set_die_type): Removed conditions to restrict
1774         forms for DW_AT_associated and DW_AT_allocated attributes,
1775         which is already checked in function attr_to_dynamic_prop.
1776
1777 2020-06-30  Tom Tromey  <tromey@adacore.com>
1778
1779         * dwarf2/read.c (quirk_rust_enum): Correctly call
1780         alloc_rust_variant for default-less enum.
1781
1782 2020-06-30  Tom Tromey  <tromey@adacore.com>
1783
1784         PR build/26183:
1785         * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
1786         gdb::to_string.
1787
1788 2020-06-29  Simon Marchi  <simon.marchi@efficios.com>
1789
1790         * gdbarch.sh (displaced_step_copy_insn): Update doc.
1791         * gdbarch.h: Re-generate.
1792
1793 2020-06-28  Tom Tromey  <tom@tromey.com>
1794
1795         * command.h (cmd_types): Remove.
1796         (cmd_type): Don't declare.
1797         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
1798         typedef.
1799         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
1800         * cli/cli-decode.c (cmd_type): Remove.
1801
1802 2020-06-27  Pedro Alves  <palves@redhat.com>
1803
1804         * fork-child.c (prefork_hook): Adjust.
1805         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
1806         Delete.
1807         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
1808         * inferior.c (inferior::set_tty, inferior::tty): New methods.
1809         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
1810         Remove declarations.
1811         (struct inferior) <set_tty, tty>: New methods.
1812         (struct inferior) <terminal>: Rename to ...
1813         (struct inferior) <m_terminal>: ... this and make private.
1814         * main.c (captured_main_1): Adjust.
1815         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
1816         (mi_cmd_inferior_tty_show): Adjust.
1817         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
1818         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
1819
1820 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
1821
1822         * configure.ac: Add --enable-libctf: handle --disable-static
1823         properly.
1824         * acinclude.m4: sinclude ../config/enable.m4.
1825         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
1826         (LIBCTF): Substitute in.
1827         (CTF_DEPS): New, likewise.
1828         (CLIBS): libctf needs symbols from libbfd: move earlier.
1829         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
1830         flags.
1831         * ctfread.c: Surround in ENABLE_LIBCTF.
1832         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
1833         * configure: Regenerate.
1834         * config.in: Likewise.
1835
1836 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
1837
1838         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
1839
1840 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
1841
1842         * inferior.h (struct inferior) <terminal>: Change type to
1843         gdb::unique_xmalloc_ptr<char>.
1844         * inferior.c (inferior::~inferior): Don't free inf->terminal.
1845         * infcmd.c (set_inferior_io_terminal): Don't free terminal
1846         field, adjust to unique pointer.
1847         (get_inferior_io_terminal): Adjust to unique pointer.
1848
1849 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1850
1851         * riscv-tdep.c (riscv_print_registers_info): Loop over all
1852         registers, not just the known core set of registers.
1853
1854 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1855
1856         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
1857         fflags, frm, and fcsr registers.
1858         (riscv_register_reggroup_p): Remove unknown CSRs from save and
1859         restore groups.
1860         (riscv_tdesc_unknown_reg): New function.
1861         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
1862         tdesc_use_registers.
1863         * riscv-tdep.h (struct gdbarch_tdep): Add
1864         unknown_csrs_first_regnum, unknown_csrs_count,
1865         duplicate_fflags_regnum, duplicate_frm_regnum, and
1866         duplicate_fcsr_regnum fields.
1867
1868 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1869
1870         * target-descriptions.c (tdesc_use_registers): Add new parameter a
1871         callback, use the callback (when not null) to help number unknown
1872         registers.
1873         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
1874         (tdesc_use_registers): Add extra parameter to declaration.
1875
1876 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1877
1878         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
1879         in the file.
1880         (class riscv_pending_register_alias): Likewise.
1881         (riscv_register_feature::register_info): Change 'required_p' field
1882         to 'required', and change its type.  Add 'check' member function.
1883         (riscv_register_feature::register_info::check): Define new member
1884         function.
1885         (riscv_xreg_feature): Change initialisation of 'required' field.
1886         (riscv_freg_feature): Likewise.
1887         (riscv_virtual_feature): Likewise.
1888         (riscv_csr_feature): Likewise.
1889         (riscv_check_tdesc_feature): Take extra parameter, the csr
1890         tdesc_feature, rewrite the function to use the new
1891         riscv_register_feature::register_info::check function.
1892         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
1893
1894 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * features/Makefile: Remove all references to the deleted files
1897         below.
1898         * features/riscv/32bit-csr.c: Deleted.
1899         * features/riscv/32bit-csr.xml: Deleted.
1900         * features/riscv/64bit-csr.c: Deleted.
1901         * features/riscv/64bit-csr.xml: Deleted.
1902         * features/riscv/rebuild-csr-xml.sh: Deleted.
1903
1904 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1905
1906         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
1907         whitespace error for declaration of names member variable.
1908         (struct riscv_register_feature): Add new prefer_first_name member
1909         variable, and fix whitespace error in declaration of registers.
1910         (riscv_xreg_feature): Initialize prefer_first_name field.
1911         (riscv_freg_feature): Likewise.
1912         (riscv_virtual_feature): Likewise.
1913         (riscv_csr_feature): Likewise.
1914         (riscv_register_name): Expand on comments.  Remove register name
1915         modifications for CSR and virtual registers.
1916
1917 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1918
1919         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
1920         errors.
1921
1922 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1923
1924         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
1925         riscv-opc.h.
1926         (class riscv_pending_register_alias): New class.
1927         (riscv_check_tdesc_feature): Take vector of pending aliases and
1928         populate it as appropriate.
1929         (riscv_setup_register_aliases): Delete.
1930         (riscv_gdbarch_init): Create vector of pending aliases and pass it
1931         to riscv_check_tdesc_feature in all cases.  Use the vector to
1932         create the register aliases.
1933
1934 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1935
1936         * sol2-tdep.c (sol2_static_transform_name): Remove.
1937         (sol2_init_abi): Don't register it.
1938         * gdbarch.sh (static_transform_name): Remove.
1939         * gdbarch.c, gdbarch.h: Regenerate.
1940
1941         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
1942         gdbarch_static_transform_name.
1943         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
1944         * stabsread.c (define_symbol) <'X'>: Remove.
1945         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
1946         handling.
1947         <'V'>: Likewise.
1948         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
1949         <'S'>: Remove call to gdbarch_static_transform_name.
1950
1951 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1952
1953         * procfs.c (procfs_pre_trace): New function.
1954         (procfs_target::create_inferior): Pass it to fork_inferior.
1955
1956 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1957
1958         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
1959         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
1960         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
1961         sol2-tdep.o, sparc-sol2-tdep.o.
1962         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
1963         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
1964         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
1965         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
1966
1967 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1968
1969         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
1970         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
1971         Call sol2_init_abi.
1972         Remove calls to set_gdbarch_skip_solib_resolver,
1973         set_gdbarch_core_pid_to_str.
1974         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
1975         (i386_sol2_static_transform_name): Remove.
1976         (i386_sol2_init_abi): Call sol2_init_abi.
1977         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1978         set_gdbarch_static_transform_name,
1979         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
1980         Use sol2_sigtramp_p.
1981         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
1982         (sol2_sigtramp_p): New function.
1983         (sol2_static_transform_name): New function.
1984         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
1985         (sol2_init_abi): New function.
1986         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
1987         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
1988         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
1989         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
1990         (sparc_sol2_static_transform_name): Remove.
1991         (sparc32_sol2_init_abi): Call sol2_init_abi.
1992         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1993         set_gdbarch_static_transform_name,
1994         set_gdbarch_skip_solib_resolver,
1995         set_gdbarch_core_pid_to_str.
1996         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
1997         (sparc_sol2_static_transform_name): Remove
1998         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
1999         call sol2_sigtramp_p.
2000         (sparc64_sol2_init_abi): Call sol2_init_abi.
2001         Remove calls to set_gdbarch_sofun_address_maybe_missing,
2002         set_gdbarch_static_transform_name,
2003         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
2004
2005 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2006
2007         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
2008         * exec.c (validate_exec_file): If from_tty, set both
2009         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
2010         * symfile.c (symbol_file_add_with_addrs): if always_confirm
2011         and from_tty, unconditionally ask a confirmation.
2012
2013 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2014
2015         * target-descriptions.c (tdesc_architecture_name): Protect against
2016         NULL pointer dereference.
2017         (maint_print_xml_tdesc_cmd): New function.
2018         (_initialize_target_descriptions): Register new 'maint print
2019         xml-tdesc' command and give it the filename completer.
2020         * NEWS: Mention new 'maint print xml-tdesc' command.
2021
2022 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2023
2024         * target-descriptions.c (class tdesc_compatible_info): New class.
2025         (struct target_desc): Change type of compatible vector.
2026         (tdesc_compatible_p): Update for change in type of
2027         target_desc::compatible.
2028         (tdesc_compatible_info_list): New function.
2029         (tdesc_compatible_info_arch_name): New function.
2030         (tdesc_add_compatible): Update for change in type of
2031         target_desc::compatible.
2032         (print_c_tdesc::visit_pre): Likewise.
2033
2034 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2035
2036         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
2037         whitespace to underscore.
2038         (maint_print_c_tdesc_cmd): Use fake filename for target
2039         descriptions that came from the target.
2040         (_initialize_target_descriptions): Add filename command completion
2041         for 'maint print c-tdesc'.
2042
2043 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
2044
2045         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
2046         lines.
2047
2048 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
2049
2050         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
2051         lines.
2052         (dwarf2_find_location_expression): Likewise.
2053         (call_site_parameter_matches): Likewise.
2054         (dwarf2_compile_expr_to_ax): Likewise.
2055         (disassemble_dwarf_expression): Likewise.
2056         (loclist_describe_location): Likewise.
2057
2058 2020-06-23  Pedro Alves  <palves@redhat.com>
2059
2060         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
2061         progspace-and-thread.h.  Include scoped-mock-context.h instead.
2062         (register_to_value_test): Use scoped_mock_context.
2063         * regcache.c: Include "scoped-mock-context.h".
2064         (cooked_read_test): Don't error out if a target is already pushed.
2065         Use scoped_mock_context.  Adjust.
2066         * scoped-mock-context.h: New file.
2067
2068 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2069
2070         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
2071         initializer.
2072         (ada_language::is_string_type_p): New member function.
2073         * c-lang.c (c_language_data): Delete la_is_string_type_p
2074         initializer.
2075         (cplus_language_data): Likewise.
2076         (asm_language_data): Likewise.
2077         (minimal_language_data): Likewise.
2078         * d-lang.c (d_language_data): Likewise.
2079         * f-lang.c (f_is_string_type_p): Delete function, implementation
2080         moved to f_language::is_string_type_p.
2081         (f_language_data): Delete la_is_string_type_p initializer.
2082         (f_language::is_string_type_p): New member function,
2083         implementation from f_is_string_type_p.
2084         * go-lang.c (go_is_string_type_p): Delete function, implementation
2085         moved to go_language::is_string_type_p.
2086         (go_language_data): Delete la_is_string_type_p initializer.
2087         (go_language::is_string_type_p): New member function,
2088         implementation from go_is_string_type_p.
2089         * language.c (language_defn::is_string_type_p): Define new member
2090         function.
2091         (default_is_string_type_p): Make static, add comment copied from
2092         header file.
2093         (unknown_language_data): Delete la_is_string_type_p initializer.
2094         (unknown_language::is_string_type_p): New member function.
2095         (auto_language_data): Delete la_is_string_type_p initializer.
2096         (auto_language::is_string_type_p): New member function.
2097         * language.h (language_data): Delete la_is_string_type_p field.
2098         (language_defn::is_string_type_p): Declare new function.
2099         (default_is_string_type_p): Delete desclaration, move comment to
2100         definition.
2101         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
2102         moved to m2_language::is_string_type_p.
2103         (m2_language_data): Delete la_is_string_type_p initializer.
2104         (m2_language::is_string_type_p): New member function,
2105         implementation from m2_is_string_type_p.
2106         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
2107         initializer.
2108         * opencl-lang.c (opencl_language_data): Likewise.
2109         * p-lang.c (pascal_is_string_type_p): Delete function,
2110         implementation moved to pascal_language::is_string_type_p.
2111         (pascal_language_data): Delete la_is_string_type_p initializer.
2112         (pascal_language::is_string_type_p): New member function,
2113         implementation from pascal_is_string_type_p.
2114         * rust-lang.c (rust_is_string_type_p): Delete function,
2115         implementation moved to rust_language::is_string_type_p.
2116         (rust_language_data): Delete la_is_string_type_p initializer.
2117         (rust_language::is_string_type_p): New member function,
2118         implementation from rust_is_string_type_p.
2119         * valprint.c (val_print_scalar_or_string_type_p): Update call to
2120         is_string_type_p.
2121
2122 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2123
2124         * ada-lang.c (ada_language_data): Delete la_print_typedef
2125         initializer.
2126         (ada_language::print_typedef): New member function.
2127         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
2128         (cplus_language_data): Likewise.
2129         (asm_language_data): Likewise.
2130         (minimal_language_data): Likewise.
2131         * d-lang.c (d_language_data): Likewise.
2132         * f-lang.c (f_language_data): Likewise.
2133         (f_language::print_typedef): New member function.
2134         * go-lang.c (go_language_data): Delete la_print_typedef
2135         initializer.
2136         * language.c (language_defn::print_typedef): Define member
2137         function.
2138         (unknown_language_data): Delete la_print_typedef initializer.
2139         (unknown_language::print_typedef): New member function.
2140         (auto_language_data): Delete la_print_typedef initializer.
2141         (auto_language::print_typedef): New member function.
2142         * language.h (language_data): Delete la_print_typedef field.
2143         (language_defn::print_typedef): Declare new member function.
2144         (LA_PRINT_TYPEDEF): Update call to print_typedef.
2145         (default_print_typedef): Delete declaration.
2146         * m2-lang.c (m2_language_data): Delete la_print_typedef
2147         initializer.
2148         (m2_language::print_typedef): New member function.
2149         * objc-lang.c (objc_language_data): Delete la_print_typedef
2150         initializer.
2151         * opencl-lang.c (opencl_language_data): Likewise.
2152         * p-lang.c (pascal_language_data): Likewise.
2153         (pascal_language::print_typedef): New member function.
2154         * rust-lang.c (rust_print_typedef): Delete function,
2155         implementation moved to rust_language::print_typedef.
2156         (rust_language): Delete la_print_typedef initializer.
2157         (rust_language::print_typedef): New member function,
2158         implementation from rust_print_typedef.
2159         * typeprint.c (default_print_typedef): Delete.
2160
2161 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2162
2163         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
2164         (ada_language::printstr): New member function.
2165         * c-lang.c (c_language_data): Delete la_printstr initializer.
2166         (cplus_language_data): Likewise.
2167         (asm_language_data): Likewise.
2168         (minimal_language_data): Likewise.
2169         * d-lang.c (d_language_data): Likewise.
2170         * f-lang.c (f_printstr): Rename to f_language::printstr.
2171         (f_language_data): Delete la_printstr initializer.
2172         (f_language::printstr): New member function, implementation from
2173         f_printstr.
2174         * go-lang.c (go_language_data): Delete la_printstr initializer.
2175         * language.c (language_defn::printstr): Define new member
2176         function.
2177         (unk_lang_printstr): Delete.
2178         (unknown_language_data): Delete la_printstr initializer.
2179         (unknown_language::printstr): New member function.
2180         (auto_language_data): Delete la_printstr initializer.
2181         (auto_language::printstr): New member function.
2182         * language.h (language_data): Delete la_printstr field.
2183         (language_defn::printstr): Declare new member function.
2184         (LA_PRINT_STRING): Update call to printstr.
2185         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
2186         (m2_language_data): Delete la_printstr initializer.
2187         (m2_language::printstr): New member function, implementation from
2188         m2_printstr.
2189         * objc-lang.c (objc_language_data): Delete la_printstr
2190         initializer.
2191         * opencl-lang.c (opencl_language_data): Likewise.
2192         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
2193         (pascal_language_data): Delete la_printstr initializer.
2194         (pascal_language::printstr): New member function, implementation
2195         from pascal_printstr.
2196         * p-lang.h (pascal_printstr): Delete declaration.
2197         * rust-lang.c (rust_printstr): Update header comment.
2198         (rust_language_data): Delete la_printstr initializer.
2199         (rust_language::printstr): New member function.
2200
2201 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
2204         (ada_language::printchar): New member function.
2205         * c-lang.c (c_language_data): Delete la_printchar initializer.
2206         (cplus_language_data): Likewise.
2207         (asm_language_data): Likewise.
2208         (minimal_language_data): Likewise.
2209         * d-lang.c (d_language_data): Likewise.
2210         * f-lang.c (f_printchar): Rename to f_language::printchar.
2211         (f_language_data): Delete la_printchar initializer.
2212         (f_language::printchar): New member function, implementation from
2213         f_printchar.
2214         * go-lang.c (go_language_data): Delete la_printchar initializer.
2215         * language.c (unk_lang_printchar): Delete.
2216         (language_defn::printchar): Define new member function.
2217         (unknown_language_data): Delete la_printchar initializer.
2218         (unknown_language::printchar): New member function.
2219         (auto_language_data): Delete la_printchar initializer.
2220         (auto_language::printchar): New member function.
2221         * language.h (language_data): Delete la_printchar field.
2222         (language_defn::printchar): Declare new member function.
2223         (LA_PRINT_CHAR): Update call to printchar.
2224         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
2225         (m2_language::printchar): New member function.
2226         * objc-lang.c (objc_language_data): Delete la_printchar
2227         initializer.
2228         * opencl-lang.c (opencl_language_data): Likewise.
2229         * p-lang.c (pascal_language_data): Delete la_printchar
2230         initializer.
2231         (pascal_language::printchar): New member function.
2232         * rust-lang.c (rust_printchar): Rename to
2233         rust_language::printchar.
2234         (rust_language_data): Delete la_printchar initializer.
2235         (rust_language::printchar): New member function, implementation
2236         from rust_printchar.
2237
2238 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
2241         (ada_language_data): Delete la_emitchar initializer.
2242         (ada_language::emitchar): New member function, implementation from
2243         emit_char.
2244         * c-lang.c (c_language_data): Delete la_emitchar initializer.
2245         (cplus_language_data): Likewise.
2246         (asm_language_data): Likewise.
2247         (minimal_language_data): Likewise.
2248         * d-lang.c (d_language_data): Likewise.
2249         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
2250         (f_language_data): Delete la_emitchar initializer.
2251         (f_language::emitchar): New member function, implementation from
2252         f_emit_char.
2253         * go-lang.c (go_language_data): Delete la_emitchar initializer.
2254         * language.c (unk_lang_emit_char): Delete.
2255         (language_defn::emitchar): New member function definition.
2256         (unknown_language_data): Delete la_emitchar initializer.
2257         (unknown_language::emitchar): New member function.
2258         (auto_language_data): Delete la_emitchar initializer.
2259         (auto_language::emitchar): New member function.
2260         * language.h (language_data): Delete la_emitchar field.
2261         (language_defn::emitchar): New member field declaration.
2262         (LA_EMIT_CHAR): Update call to emitchar.
2263         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
2264         (m2_language_data): Delete la_emitchar initializer.
2265         (m2_language::emitchar): New member function, implementation from
2266         m2_emit_char.
2267         * objc-lang.c (objc_language_data): Delete la_emitchar
2268         initializer.
2269         * opencl-lang.c (opencl_language_data): Likewise.
2270         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
2271         (pascal_language_data): Delete la_emitchar initializer.
2272         (pascal_language::emitchar): New member function, implementation
2273         from pascal_emit_char.
2274         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
2275         (rust_language_data): Delete la_emitchar initializer.
2276         (rust_language::emitchar): New member function, implementation
2277         from rust_emitchar.
2278
2279 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * ada-lang.c (resolve): Rename to ada_language::post_parser.
2282         (ada_language_data): Delete la_post_parser initializer.
2283         (ada_language::post_parser): New member function.
2284         * c-lang.c (c_language_data): Delete la_post_parser initializer.
2285         (cplus_language_data): Likewise.
2286         (asm_language_data): Likewise.
2287         (minimal_language_data): Likewise.
2288         * d-lang.c (d_language_data): Likewise.
2289         * f-lang.c (f_language_data): Likewise.
2290         * go-lang.c (go_language_data): Likewise.
2291         * language.c (unknown_language_data): Likewise.
2292         (auto_language_data): Likewise.
2293         * language.h (language_data): Delete la_post_parser field.
2294         (language_defn::post_parser): New member function.
2295         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
2296         * objc-lang.c (objc_language_data): Likewise.
2297         * opencl-lang.c (opencl_language_data): Likewise.
2298         * p-lang.c (pascal_language_data): Likewise.
2299         * parse.c (parse_exp_in_context): Update call to post_parser.
2300         (null_post_parser): Delete definition.
2301         * parser-defs.h (null_post_parser): Delete declaration.
2302         * rust-lang.c (rust_language_data): Delete la_post_parser
2303         initializer.
2304
2305 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * ada-lang.c (parse): Rename to ada_language::parser.
2308         (ada_language_data): Delete la_parser initializer.
2309         (ada_language::parser): New member function, implementation from
2310         parse.
2311         * c-lang.c (c_language_data): Delete la_parser initializer.
2312         (cplus_language_data): Likewise.
2313         (asm_language_data): Likewise.
2314         (minimal_language_data): Likewise.
2315         * d-lang.c (d_language_data): Likewise.
2316         (d_language::parser): New member function.
2317         * f-lang.c (f_language_data): Delete la_parser initializer.
2318         (f_language::parser): New member function.
2319         * go-lang.c (go_language_data): Delete la_parser initializer.
2320         (go_language::parser): New member function.
2321         * language.c (unk_lang_parser): Delete.
2322         (language_defn::parser): Define new member function.
2323         (unknown_language_data): Delete la_parser initializer.
2324         (unknown_language::parser): New member function.
2325         (auto_language_data): Delete la_parser initializer.
2326         (auto_language::parser): New member function.
2327         * language.h (language_data): Delete la_parser field.
2328         (language_defn::parser): Declare new member function.
2329         * m2-lang.c (m2_language_data): Delete la_parser initializer.
2330         (m2_language::parser): New member function.
2331         * objc-lang.c (objc_language_data): Delete la_parser initializer.
2332         * opencl-lang.c (opencl_language_data): Likewise.
2333         * p-lang.c (pascal_language_data): Likewise.
2334         (pascal_language::parser): New member function.
2335         * parse.c (parse_exp_in_context): Update call to parser.
2336         * rust-lang.c (rust_language_data): Delete la_parser initializer.
2337         (rust_language::parser): New member function.
2338
2339 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * top.c (print_gdb_configuration): Print --with-python-libdir
2342         configuration value.
2343
2344 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2345
2346         * NEWS: Mention change to the alias command.
2347
2348 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2349
2350         * cli/cli-cmds.c (lookup_cmd_for_default_args)
2351         (alias_command_completer)
2352         (make_alias_options_def_group): New functions.
2353         (alias_opts, alias_option_defs): New struct and array.
2354         (alias_usage_error): Update usage.
2355         (alias_command): Handles optional DEFAULT-ARGS... arguments.
2356         Use option framework.
2357         (_initialize_cli_cmds): Update alias command help.
2358         Update aliases command help.
2359         (show_user):
2360         Add NULL for new default_args lookup_cmd argument.
2361         (valid_command_p): Rename to validate_aliased_command.
2362         Add NULL for new default_args lookup_cmd argument.  Verify that the
2363         aliased_command has no default args.
2364         * cli/cli-decode.c (help_cmd): Show aliases definitions.
2365         (lookup_cmd_1, lookup_cmd): New argument default_args.
2366         (add_alias_cmd):
2367         Add NULL for new default_args lookup_cmd argument.
2368         (print_help_for_command): Show default args under the layout
2369          alias some_alias = some_aliased_cmd some_alias_default_arg.
2370         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
2371         xfree default_args in destructor.
2372         * cli/cli-script.c (process_next_line, do_define_command):
2373         Add NULL for new default_args lookup_cmd argument.
2374         * command.h: Declare new default_args argument in lookup_cmd
2375         and lookup_cmd_1.
2376         * completer.c (complete_line_internal_1):
2377         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
2378         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
2379         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
2380         Likewise.
2381         * infcmd.c (_initialize_infcmd): Likewise.
2382         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
2383         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
2384         * python/py-param.c (add_setshow_generic): Likewise.
2385         * remote.c (_initialize_remote): Likewise.
2386         * top.c (execute_command): Prepend default_args if command has some.
2387         (set_verbose):
2388         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
2389         * tracepoint.c (validate_actionline, encode_actions_1):
2390         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
2391
2392 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2393
2394         * jit.c (jit_read_descriptor): Use bool as the return type.
2395         (jit_breakpoint_re_set_internal): Use bool as the return type.
2396         Invert the return value logic; return true if the jit breakpoint
2397         has been successfully initialized.
2398         (jit_inferior_init): Update the call to
2399         jit_breakpoint_re_set_internal.
2400
2401 2020-06-22  Pedro Alves  <palves@redhat.com>
2402
2403         PR gdb/25939
2404         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
2405         Use the current inferior instead.  Don't return
2406         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
2407         wait again.
2408         * sol-thread.c (sol_thread_target::wait): Don't reference
2409         inferior_ptid.
2410         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
2411         (sol_update_thread_list_callback): Use the current inferior's pid
2412         instead of inferior_ptid.
2413
2414 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2415
2416         * procfs.c: Cleanup many comments.
2417
2418         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
2419         (AFTER_WATCHFLAG): Replace by value.
2420
2421         (MAIN_PROC_NAME_FORMAT): Inline ...
2422         (create_procinfo): ... here.
2423
2424         (procfs_debug_inferior): Remove SYS_exec handling.
2425         (syscall_is_exec): Likewise.
2426         (procfs_set_exec_trap): Likewise.
2427
2428         (syscall_is_lwp_exit): Inline in callers.
2429         (syscall_is_exit): Likewise.
2430         (syscall_is_exec): Likewise.
2431         (syscall_is_lwp_create): Likewise.
2432
2433         (invalidate_cache): Remove #if 0 code.
2434
2435         (make_signal_thread_runnable):  Remove.
2436         (procfs_target::resume): Remove #if 0 code.
2437
2438 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2439
2440         PR gdb/25939
2441         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
2442         call ...
2443         (procfs_target::create_inferior): ... here.
2444
2445 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2446
2447         * exec.c (validate_exec_file): Ensure the build-id is up to
2448         date by calling reopen_exec_file (that checks file timestamp
2449         to decide to re-read the file).
2450
2451 2020-06-18  Pedro Alves  <palves@redhat.com>
2452
2453         PR gdb/25412
2454         * gdbthread.h (delete_thread, delete_thread_silent)
2455         (find_thread_ptid): Update comments.
2456         * thread.c (current_thread_): New global.
2457         (is_current_thread): Move higher, and reimplement.
2458         (inferior_thread): Reimplement.
2459         (set_thread_exited): Use bool.  Add assertions.
2460         (add_thread_silent): Simplify thread-reuse handling by always
2461         calling delete_thread.
2462         (delete_thread): Remove intro comment.
2463         (find_thread_ptid): Skip exited threads.
2464         (switch_to_thread_no_regs): Write to current_thread_.
2465         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
2466         INFERIOR_PTID.  Clear current_thread_.
2467
2468 2020-06-18  Pedro Alves  <palves@redhat.com>
2469
2470         * aix-thread.c (pd_update): Use switch_to_thread.
2471
2472 2020-06-18  Pedro Alves  <palves@redhat.com>
2473
2474         * ravenscar-thread.c (ravenscar_thread_target): Update.
2475         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
2476         (ravenscar_thread_target::add_active_thread): ... this.  Don't
2477         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
2478         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
2479
2480 2020-06-18  Pedro Alves  <palves@redhat.com>
2481
2482         * nat/windows-nat.c (current_windows_thread): Remove.
2483         * nat/windows-nat.h (current_windows_thread): Remove.
2484         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
2485         Adjust.
2486         (display_selectors): Adjust to fetch the current
2487         windows_thread_info based on inferior_ptid.
2488         (fake_create_process): No longer write to current_windows_thread.
2489         (windows_nat_target::get_windows_debug_event):
2490         Don't set inferior_ptid or current_windows_thread.
2491         (windows_nat_target::wait): Adjust to not rely on
2492         current_windows_thread.
2493         (do_initial_windows_stuff): Now a method of windows_nat_target.
2494         Switch to the last_ptid thread.
2495         (windows_nat_target::attach): Adjust.
2496         (windows_nat_target::detach): Use switch_to_no_thread instead of
2497         writing to inferior_ptid directly.
2498         (windows_nat_target::create_inferior): Adjust.
2499
2500 2020-06-18  Pedro Alves  <palves@redhat.com>
2501
2502         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
2503
2504 2020-06-18  Pedro Alves  <palves@redhat.com>
2505
2506         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
2507         after creating it, instead of writing to inferior_ptid.  Don't
2508         write to inferior_ptid.
2509
2510 2020-06-18  Pedro Alves  <palves@redhat.com>
2511
2512         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
2513
2514 2020-06-18  Pedro Alves  <palves@redhat.com>
2515
2516         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
2517         it, instead of writing to inferior_ptid.
2518
2519 2020-06-18  Pedro Alves  <palves@redhat.com>
2520
2521         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
2522         to inferior_ptid.
2523
2524 2020-06-18  Pedro Alves  <palves@redhat.com>
2525
2526         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
2527         instead of writing to inferior_ptid directly.
2528
2529 2020-06-18  Pedro Alves  <palves@redhat.com>
2530
2531         * corelow.c (core_target::close): Use switch_to_no_thread instead
2532         of writing to inferior_ptid directly.
2533         (add_to_thread_list, core_target_open): Use switch_to_thread
2534         instead of writing to inferior_ptid directly.
2535
2536 2020-06-18  Pedro Alves  <palves@redhat.com>
2537
2538         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
2539         inferior_ptid.
2540         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
2541         inferior_ptid.
2542         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
2543         inferior_ptid directly.
2544         (darwin_nat_target::init_thread_list): Switch to thread, instead
2545         of writing to inferior_ptid.
2546         (darwin_nat_target::attach): Don't write to inferior_ptid.
2547         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
2548
2549 2020-06-18  Pedro Alves  <palves@redhat.com>
2550
2551         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
2552         thread.
2553         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
2554         Instead use switch_to_thread.
2555         (gnu_nat_target::detach): Use switch_to_no_thread
2556         instead of writing to inferior_ptid directly.  Used passed-in
2557         inferior instead of looking up the inferior by pid.
2558
2559 2020-06-18  Pedro Alves  <palves@redhat.com>
2560
2561         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
2562         inferior_ptid.
2563
2564 2020-06-18  Pedro Alves  <palves@redhat.com>
2565
2566         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
2567         inferior_ptid.
2568         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
2569         thread.
2570         (nto_procfs_target::detach): Avoid referencing
2571         inferior_ptid.  Use switch_to_no_thread instead of writing to
2572         inferior_ptid directly.
2573         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
2574         instead of writing to inferior_ptid directly.
2575         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
2576         to thread.
2577
2578 2020-06-18  Pedro Alves  <palves@redhat.com>
2579
2580         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
2581         after creating it, instead of writing to inferior_ptid.
2582         (gdbsim_target_open): Use switch_to_no_thread instead of writing
2583         to inferior_ptid directly.
2584         (gdbsim_target::wait): Don't write to inferior_ptid.
2585
2586 2020-06-18  Pedro Alves  <palves@redhat.com>
2587
2588         * remote.c (remote_target::remote_notice_new_inferior): Use
2589         switch_to_thread instead of writing to inferior_ptid directly.
2590         (remote_target::add_current_inferior_and_thread): Use
2591         switch_to_no_thread instead of writing to inferior_ptid directly.
2592         (extended_remote_target::attach): Use switch_to_inferior_no_thread
2593         and switch_to_thread instead of using set_current_inferior or
2594         writing to inferior_ptid directly.
2595
2596 2020-06-18  Pedro Alves  <palves@redhat.com>
2597
2598         * tracectf.c (ctf_target_open): Switch to added thread instead of
2599         writing to inferior_ptid directly.
2600         (ctf_target::close): Use switch_to_no_thread instead of writing to
2601         inferior_ptid directly.
2602
2603 2020-06-18  Pedro Alves  <palves@redhat.com>
2604
2605         * tracefile-tfile.c (tfile_target_open): Don't write to
2606         inferior_ptid directly, instead switch to added thread.
2607         (tfile_target::close): Use switch_to_no_thread instead of writing
2608         to inferior_ptid directly.
2609
2610 2020-06-18  Pedro Alves  <palves@redhat.com>
2611
2612         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
2613         (procfs_target::detach): Use switch_to_no_thread
2614         instead of writing to inferior_ptid directly.
2615         (do_attach): Change return type to void.  Switch to the added
2616         thread.
2617         (procfs_target::create_inferior): Switch to the added thread.
2618         (procfs_do_thread_registers): Don't write to inferior_ptid.
2619
2620 2020-06-18  Pedro Alves  <palves@redhat.com>
2621
2622         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
2623         of writing to inferior_ptid.
2624         (scoped_restore_exited_inferior): Delete.
2625         (handle_vfork_child_exec_or_exit): Simplify using
2626         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
2627         instead of writing to inferior_ptid.
2628         (THREAD_STOPPED_BY): Delete.
2629         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
2630         (thread_stopped_by_hw_breakpoint): Delete.
2631         (save_waitstatus): Use
2632         scoped_restore_current_thread+switch_to_thread, and call
2633         target_stopped_by_watchpoint instead of
2634         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
2635         instead of thread_stopped_by_sw_breakpoint, and
2636         target_stopped_by_hw_breakpoint instead of
2637         thread_stopped_by_hw_breakpoint.
2638         (handle_inferior_event)
2639         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
2640         inferior_ptid directly, nor
2641         set_current_inferior/set_current_program_space.  Use
2642         switch_to_thread / switch_to_inferior_no_thread instead.
2643
2644 2020-06-18  Pedro Alves  <palves@redhat.com>
2645
2646         * target.c (generic_mourn_inferior): Use switch_to_no_thread
2647         instead of writing to inferior_ptid.
2648
2649 2020-06-18  Pedro Alves  <palves@redhat.com>
2650
2651         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
2652         added thread.
2653         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
2654         to the added thread.
2655         (inf_ptrace_target::detach_success): Use switch_to_no_thread
2656         instead of writing to inferior_ptid.
2657
2658 2020-06-18  Pedro Alves  <palves@redhat.com>
2659
2660         * gdbarch-selftests.c: Include "progspace-and-thread.h".
2661         (register_to_value_test): Mock a program_space too.  Heap-allocate
2662         the address space.  Don't write to inferior_ptid.  Use
2663         switch_to_thread instead.
2664
2665 2020-06-18  Pedro Alves  <palves@redhat.com>
2666
2667         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
2668         Delete.
2669         (find_signalled_thread()): New, factored out from
2670         linux_make_corefile_notes and adjusted to handle exited threads.
2671         (linux_make_corefile_notes): Adjust to use the new
2672         find_signalled_thread.
2673
2674 2020-06-18  Pedro Alves  <palves@redhat.com>
2675
2676         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
2677         of saving/restoring inferior_ptid.
2678
2679 2020-06-17  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
2682         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
2683         declare.
2684         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
2685
2686 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
2687
2688         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
2689         of partial symtabs.
2690
2691 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
2692
2693         * regformats/reg-arm.dat: Remove.
2694         * regformats/reg-bfin.dat: Remove.
2695         * regformats/reg-cris.dat: Remove.
2696         * regformats/reg-crisv32.dat: Remove.
2697         * regformats/reg-m32r.dat: Remove.
2698         * regformats/reg-tilegx.dat: Remove.
2699         * regformats/reg-tilegx32.dat: Remove.
2700
2701 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
2702
2703         * features/Makefile (WHICH): Remove arm files.
2704         * regformats/arm/arm-with-iwmmxt.dat: Remove.
2705         * regformats/arm/arm-with-neon.dat: Remove.
2706         * regformats/arm/arm-with-vfpv2.dat: Remove.
2707         * regformats/arm/arm-with-vfpv3.dat: Remove.
2708
2709 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
2710
2711         * features/Makefile (XMLTOC): Remove rx.xml.
2712
2713 2020-06-17  Pedro Alves  <palves@redhat.com>
2714
2715         * gdbthread.h (thread_control_state) <trap_expected> Update
2716         comments.
2717
2718 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2719
2720         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
2721         ada_language::lookup_symbol_nonlocal.
2722         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
2723         (ada_language::lookup_symbol_nonlocal): New member function,
2724         implementation from ada_lookup_symbol_nonlocal.
2725         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
2726         initializer.
2727         (cplus_language_data): Delete la_lookup_symbol_nonlocal
2728         initializer.
2729         (cplus_language::lookup_symbol_nonlocal): New member function.
2730         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
2731         (minimal_language_data) Likewise.
2732         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
2733         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
2734         initializer.
2735         (d_language::lookup_symbol_nonlocal): New member function.
2736         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
2737         initializer.
2738         (f_language::lookup_symbol_nonlocal): New member function.
2739         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
2740         initializer.
2741         * language.c (unknown_language_data): Likewise.
2742         (auto_language_data): Likewise.
2743         * language.h (language_data): Delete la_lookup_symbol_nonlocal
2744         field.
2745         (language_defn::lookup_symbol_nonlocal): New member function.
2746         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
2747         initializer.
2748         * objc-lang.c (objc_language_data): Likewise.
2749         * opencl-lang.c (opencl_language_data): Likewise.
2750         * p-lang.c (pascal_language_data): Likewise.
2751         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
2752         rust_language::lookup_symbol_nonlocal.
2753         (rust_language_data): Delete la_lookup_symbol_nonlocal
2754         initializer.
2755         (rust_language::lookup_symbol_nonlocal): New member function,
2756         implementation from rust_lookup_symbol_nonlocal.
2757         * symtab.c (lookup_symbol_aux): Update call to
2758         lookup_symbol_nonlocal.
2759         (basic_lookup_symbol_nonlocal): Rename to...
2760         (language_defn::lookup_symbol_nonlocal): ...this, and update
2761         header comment.  Remove language_defn parameter, and replace with
2762         uses of `this'.
2763         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
2764
2765 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2766
2767         * ada-lang.c (ada_language_data): Delete la_value_print_inner
2768         initializer.
2769         (ada_language::value_print_inner): New member function.
2770         * c-lang.c (c_language_data): Delete la_value_print_inner
2771         initializer.
2772         (cplus_language_data): Likewise.
2773         (asm_language_data): Likewise.
2774         (minimal_language_data): Likewise.
2775         * d-lang.c (d_language_data): Likewise.
2776         (d_language::value_print_inner): New member function.
2777         * f-lang.c (f_language_data): Delete la_value_print_inner
2778         initializer.
2779         (f_language::value_print_inner): New member function.
2780         * f-lang.h (f_value_print_innner): Rename to...
2781         (f_value_print_inner): ...this (note spelling of 'inner').
2782         * f-valprint.c (f_value_print_innner): Rename to...
2783         (f_value_print_inner): ...this (note spelling of 'inner').
2784         * go-lang.c (go_language_data): Delete la_value_print_inner
2785         initializer.
2786         (go_language::value_print_inner): New member function.
2787         * language.c (language_defn::value_print_inner): Define new member
2788         function.
2789         (unk_lang_value_print_inner): Delete.
2790         (unknown_language_data): Delete la_value_print_inner initializer.
2791         (unknown_language::value_print_inner): New member function.
2792         (auto_language_data): Delete la_value_print_inner initializer.
2793         (auto_language::value_print_inner): New member function.
2794         * language.h (language_data): Delete la_value_print_inner field.
2795         (language_defn::value_print_inner): Delcare new member function.
2796         * m2-lang.c (m2_language_data): Delete la_value_print_inner
2797         initializer.
2798         (m2_language::value_print_inner): New member function.
2799         * objc-lang.c (objc_language_data): Delete la_value_print_inner
2800         initializer.
2801         * opencl-lang.c (opencl_language_data): Likewise.
2802         * p-lang.c (pascal_language_data): Likewise.
2803         (pascal_language::value_print_inner): New member function.
2804         * rust-lang.c (rust_language_data): Delete la_value_print_inner
2805         initializer.
2806         (rust_language::value_print_inner): New member function.
2807         * valprint.c (do_val_print): Update call to value_print_inner.
2808
2809 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2810
2811         * ada-lang.c (ada_language_data): Delete la_value_print
2812         initializer.
2813         (ada_language::value_print): New member function.
2814         * c-lang.c (c_language_data): Delete la_value_print initializer.
2815         (cplus_language_data): Likewise.
2816         (asm_language_data): Likewise.
2817         (minimal_language_data): Likewise.
2818         * d-lang.c (d_language_data): Likewise.
2819         * f-lang.c (f_language_data): Likewise.
2820         * go-lang.c (go_language_data): Likewise.
2821         * language.c (unk_lang_value_print): Delete.
2822         (language_defn::value_print): Define new member function.
2823         (unknown_language_data): Delete la_value_print initializer.
2824         (unknown_language::value_print): New member function.
2825         (auto_language_data): Delete la_value_print initializer.
2826         (auto_language::value_print): New member function.
2827         * language.h (language_data): Delete la_value_print field.
2828         (language_defn::value_print): Declare new member function.
2829         (LA_VALUE_PRINT): Update call to value_print.
2830         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
2831         * objc-lang.c (objc_language_data): Likewise.
2832         * opencl-lang.c (opencl_language_data): Likewise.
2833         * p-lang.c (pascal_language_data): Likewise.
2834         (pascal_language::value_print): New member function.
2835         * rust-lang.c (rust_language_data): Delete la_value_print
2836         initializer.
2837
2838 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2839
2840         * ada-lang.c (ada_watch_location_expression): Rename to
2841         ada_language::watch_location_expression.
2842         (ada_language_data): Delete la_watch_location_expression
2843         initializer.
2844         (ada_language::watch_location_expression): New member function,
2845         implementation from ada_watch_location_expression.
2846         * breakpoint.c (watch_command_1): Update call to
2847         watch_location_expression.
2848         * c-lang.c (c_watch_location_expression): Rename to
2849         language_defn::watch_location_expression.
2850         (c_language_data): Delete la_watch_location_expression
2851         initializer.
2852         (cplus_language_data): Likewise.
2853         (asm_language_data): Likewise.
2854         (minimal_language_data): Likewise.
2855         * c-lang.h (c_watch_location_expression): Delete declaration.
2856         * d-lang.c (d_language_data): Delete la_watch_location_expression
2857         initializer.
2858         * f-lang.c (f_language_data): Likewise.
2859         * go-lang.c (go_language_data): Likewise.
2860         * language.c (language_defn::watch_location_expression): Member
2861         function implementation from c_watch_location_expression.
2862         (unknown_language_data): Delete la_watch_location_expression
2863         initializer.
2864         (auto_language_data): Likewise.
2865         * language.h (language_data): Delete la_watch_location_expression
2866         field.
2867         (language_defn::watch_location_expression): Declare new member
2868         function.
2869         * m2-lang.c (m2_language_data): Delete
2870         la_watch_location_expression initializer.
2871         * objc-lang.c (objc_language_data): Likewise.
2872         * opencl-lang.c (opencl_language_data): Likewise.
2873         * p-lang.c (pascal_language_data): Likewise.
2874         * rust-lang.c (rust_watch_location_expression): Rename to
2875         rust_language::watch_location_expression.
2876         (rust_language_data): Delete la_watch_location_expression
2877         initializer.
2878         (rust_language::watch_location_expression): New member function,
2879         implementation from rust_watch_location_expression.
2880
2881 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2882
2883         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
2884         ada_language::collect_symbol_completion_matches.
2885         (ada_language_data): Delete la_collect_symbol_completion_matches
2886         initializer.
2887         (ada_language::collect_symbol_completion_matches): New member
2888         function, implementation from
2889         ada_collect_symbol_completion_matches.
2890         * c-lang.c (c_language_data): Delete
2891         la_collect_symbol_completion_matches initializer.
2892         (cplus_language_data): Likewise.
2893         (asm_language_data): Likewise.
2894         (minimal_language_data): Likewise.
2895         * d-lang.c (d_language_data): Likewise.
2896         * f-lang.c (f_collect_symbol_completion_matches): Rename to
2897         f_language::collect_symbol_completion_matches.
2898         (f_language_data): Delete la_collect_symbol_completion_matches
2899         initializer.
2900         (f_language::collect_symbol_completion_matches) New member
2901         function, implementation from f_collect_symbol_completion_matches.
2902         * go-lang.c (go_language_data): Delete
2903         la_collect_symbol_completion_matches initializer.
2904         * language.c (unknown_language_data): Likewise.
2905         (auto_language_data): Likewise.
2906         * language.h (language_data): Delete
2907         la_collect_symbol_completion_matches field.
2908         (language_defn::collect_symbol_completion_matches): New member
2909         function.
2910         * m2-lang.c (m2_language_data): Delete
2911         la_collect_symbol_completion_matches initializer.
2912         * objc-lang.c (objc_language_data): Likewise.
2913         * opencl-lang.c (opencl_language_data): Likewise.
2914         * p-lang.c (pascal_language_data): Likewise.
2915         * rust-lang.c (rust_language_data): Likewise.
2916         * symtab.c (default_collect_symbol_completion_matches): Delete.
2917         (collect_symbol_completion_matches): Update call to
2918         collect_symbol_completion_matches.
2919         (collect_symbol_completion_matches_type): Likewise.
2920         * symtab.h (default_collect_symbol_completion_matches): Delete
2921         declaration.
2922
2923 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2924
2925         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
2926         (ada_language_data): Delete la_word_break_characters initializer.
2927         (ada_language::word_break_characters): New member function.
2928         * c-lang.c (c_language_data): Delete la_word_break_characters
2929         initializer.
2930         (cplus_language_data): Likewise.
2931         (asm_language_data): Likewise.
2932         (minimal_language_data): Likewise.
2933         * completer.c: Update global comment.
2934         (advance_to_expression_complete_word_point): Update call to
2935         word_break_characters.
2936         (complete_files_symbols): Likewise.
2937         (complete_line_internal_1): Likewise.
2938         (default_completer_handle_brkchars): Likewise.
2939         (skip_quoted_chars): Likewise.
2940         * d-lang.c (d_language_data): Delete la_word_break_characters
2941         initializer.
2942         * f-lang.c (f_word_break_characters): Delete.
2943         (f_language_data): Delete la_word_break_characters initializer.
2944         (f_language::word_break_characters): New member function.
2945         * go-lang.c (go_language_data): Delete la_word_break_characters
2946         initializer.
2947         * language.c (unknown_language_data): Likewise.
2948         (auto_language_data): Likewise.
2949         * language.h (default_word_break_characters): Move declaration to
2950         earlier in the file.
2951         (language_data): Delete la_word_break_characters field.
2952         (language_defn::word_break_characters): New member function.
2953         * m2-lang.c (m2_language_data): Delete la_word_break_characters
2954         initializer.
2955         * objc-lang.c (objc_language_data): Likewise.
2956         * opencl-lang.c (opencl_language_data): Likewise.
2957         * p-lang.c (pascal_language_data): Likewise.
2958         * rust-lang.c (rust_language_data): Likewise.
2959
2960 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
2963         (ada_language_data): Delete la_get_symbol_name_matcher
2964         initializer.
2965         (language_defn::get_symbol_name_matcher_inner): New member
2966         function.
2967         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
2968         initializer.
2969         (cplus_language_data): Likewise.
2970         (cplus_language::get_symbol_name_matcher_inner): New member
2971         function.
2972         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
2973         (minimal_language_data): Likewise.
2974         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
2975         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
2976         initializer.
2977         * dictionary.c (iter_match_first_hashed): Update call to
2978         get_symbol_name_matcher.
2979         (iter_match_next_hashed): Likewise.
2980         (iter_match_next_linear): Likewise.
2981         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
2982         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
2983         initializer.
2984         (f_language::get_symbol_name_matcher_inner): New member function.
2985         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
2986         initializer.
2987         * language.c (default_symbol_name_matcher): Update header comment,
2988         make static.
2989         (language_defn::get_symbol_name_matcher): New definition.
2990         (language_defn::get_symbol_name_matcher_inner): Likewise.
2991         (get_symbol_name_matcher): Delete.
2992         (unknown_language_data): Delete la_get_symbol_name_matcher
2993         initializer.
2994         (auto_language_data): Likewise.
2995         * language.h (language_data): Delete la_get_symbol_name_matcher
2996         field.
2997         (language_defn::get_symbol_name_matcher): New member function.
2998         (language_defn::get_symbol_name_matcher_inner): Likewise.
2999         (default_symbol_name_matcher): Delete declaration.
3000         * linespec.c (find_methods): Update call to
3001         get_symbol_name_matcher.
3002         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
3003         initializer.
3004         * minsyms.c (lookup_minimal_symbol): Update call to
3005         get_symbol_name_matcher.
3006         (iterate_over_minimal_symbols): Likewise.
3007         * objc-lang.c (objc_language_data): Delete
3008         la_get_symbol_name_matcher initializer.
3009         * opencl-lang.c (opencl_language_data): Likewise.
3010         * p-lang.c (pascal_language_data): Likewise.
3011         * psymtab.c (psymbol_name_matches): Update call to
3012         get_symbol_name_matcher.
3013         * rust-lang.c (rust_language_data): Delete
3014         la_get_symbol_name_matcher initializer.
3015         * symtab.c (symbol_matches_search_name): Update call to
3016         get_symbol_name_matcher.
3017         (compare_symbol_name): Likewise.
3018
3019 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3020
3021         * ada-lang.c (ada_language_data): Delete la_compute_program
3022         initializer.
3023         * c-lang.c (c_language_data): Likewise.
3024         (c_language::compute_program): New member function.
3025         (cplus_language_data): Delete la_compute_program initializer.
3026         (cplus_language::compute_program): New member function.
3027         (asm_language_data): Delete la_compute_program initializer.
3028         (minimal_language_data): Likewise.
3029         * c-lang.h (c_compute_program): Update comment.
3030         (cplus_compute_program): Likewise.
3031         * compile/compile-c-support.c (c_compute_program): Likewise.
3032         (cplus_compute_program): Likewise.
3033         * compile/compile.c (compile_to_object): Update call to
3034         la_compute_program.
3035         * d-lang.c (d_language_data): Delete la_compute_program
3036         initializer.
3037         * f-lang.c (f_language_data): Likewise.
3038         * go-lang.c (go_language_data): Likewise.
3039         * language.c (unknown_language_data): Likewise.
3040         (auto_language_data): Likewise.
3041         * language.h (language_data): Delete la_compute_program field.
3042         (language_defn::compute_program): New member function.
3043         * m2-lang.c (m2_language_data): Delete la_compute_program
3044         initializer.
3045         * objc-lang.c (objc_language_data): Likewise.
3046         * opencl-lang.c (opencl_language_data): Likewise.
3047         * p-lang.c (pascal_language_data): Likewise.
3048         * rust-lang.c (rust_language_data): Likewise.
3049
3050 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3051
3052         * ada-lang.c (ada_language_data) Delete
3053         la_class_name_from_physname initializer.
3054         * c-lang.c (c_language_data): Likewise.
3055         (cplus_language_data): Likewise.
3056         (cplus_language::class_name_from_physname): New member function.
3057         (asm_language_data): Delete la_class_name_from_physname
3058         initializer.
3059         (minimal_language_data): Likewise.
3060         * d-lang.c (d_language_data): Likewise.
3061         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
3062         method on language_defn class.
3063         (guess_full_die_structure_name): Likewise.
3064         * f-lang.c (f_language_data): Delete la_class_name_from_physname
3065         initializer.
3066         * go-lang.c (go_language_data): Likewise.
3067         * language.c (language_class_name_from_physname): Delete.
3068         (unk_lang_class_name): Delete.
3069         (unknown_language_data): Delete la_class_name_from_physname
3070         initializer.
3071         (auto_language_data): Likewise.
3072         * language.h (language_data): Delete la_class_name_from_physname
3073         field.
3074         (language_defn::class_name_from_physname): New function.
3075         (language_class_name_from_physname): Delete declaration.
3076         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
3077         initializer.
3078         * objc-lang.c (objc_language_data): Likewise.
3079         * opencl-lang.c (opencl_language_data): Likewise.
3080         * p-lang.c (pascal_language_data): Likewise.
3081         * rust-lang.c (rust_language_data): Likewise.
3082
3083 2020-06-16  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-data.h (STATUS_NAME): New macro.
3086         * tui/tui-layout.c (tui_remove_some_windows)
3087         (initialize_known_windows, tui_register_window)
3088         (tui_layout_split::remove_windows, initialize_layouts)
3089         (tui_new_layout_command): Don't use hard-coded window names.
3090
3091 2020-06-16  Tom Tromey  <tom@tromey.com>
3092
3093         PR tui/25348:
3094         * tui/tui.c (tui_ensure_readline_initialized): Rename from
3095         tui_initialize_readline.  Only run once.  Call rl_initialize.
3096         * tui/tui.h (tui_ensure_readline_initialized): Rename from
3097         tui_initialize_readline.
3098         * tui/tui-io.c (tui_setup_io): Call
3099         tui_ensure_readline_initialized.
3100         * tui/tui-interp.c (tui_interp::init): Update.
3101
3102 2020-06-16  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
3105         Also preserve the status window.
3106
3107 2020-06-16  Tom Tromey  <tom@tromey.com>
3108
3109         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
3110         where m_window==nullptr.
3111
3112 2020-06-15  Tom Tromey  <tromey@adacore.com>
3113
3114         * windows-nat.c (windows_nat::handle_output_debug_string):
3115         Update.
3116         (windows_nat::handle_ms_vc_exception): Update.
3117         * target.h (target_read_string): Change API.
3118         * target.c (target_read_string): Change API.
3119         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
3120         Update.
3121         * solib-frv.c (frv_current_sos): Update.
3122         * solib-dsbt.c (dsbt_current_sos): Update.
3123         * solib-darwin.c (darwin_current_sos): Update.
3124         * linux-thread-db.c (inferior_has_bug): Update.
3125         * expprint.c (print_subexp_standard): Update.
3126         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
3127         (ada_exception_message_1): Update.
3128
3129 2020-06-15  Tom Tromey  <tromey@adacore.com>
3130
3131         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
3132
3133 2020-06-15  Tom Tromey  <tromey@adacore.com>
3134
3135         * valprint.c (read_string): Update comment.
3136         * target.c (MIN): Remove.
3137         (target_read_string): Rewrite.
3138
3139 2020-06-15  Tom Tromey  <tromey@adacore.com>
3140
3141         * corefile.c (read_memory_string): Remove.
3142         * ada-valprint.c (ada_value_print_ptr): Update.
3143         * ada-lang.h (ada_tag_name): Change return type.
3144         * ada-lang.c (type_from_tag): Update.
3145         (ada_tag_name_from_tsd): Change return type.  Use
3146         target_read_string.
3147         (ada_tag_name): Likewise.
3148         * gdbcore.h (read_memory_string): Don't declare.
3149
3150 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
3151
3152         * symtab.c (rbreak_command): Ignore Windows drive colon.
3153
3154 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
3155
3156         * NEWS: Mention removed GDBserver host support.
3157
3158 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
3159
3160         * features/riscv/rebuild-csr-xml.sh: Updated.
3161
3162 2020-06-11  Tom Tromey  <tom@tromey.com>
3163
3164         PR gdb/18318:
3165         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
3166
3167 2020-06-09  Jonny Grant  <jg@jguk.org>
3168 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
3169
3170         * main.c (captured_main_1): Don't print new line after help.
3171         (print_gdb_help): add mailing list and IRC channel information
3172         to --help.  Add new lines between items in the footer.  Remove
3173         quotes around bug url.
3174
3175 2020-06-11  Keith Seitz  <keiths@redhat.com>
3176
3177         PR gdb/21356
3178         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
3179         Resolve typedefs for type length calculations.
3180
3181 2020-06-10  Tom de Vries  <tdevries@suse.de>
3182
3183         PR ada/24713
3184         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
3185         (write_psymbols): Enable .gdb_index for ada.
3186         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
3187         ada.
3188
3189 2020-06-10  Tom de Vries  <tdevries@suse.de>
3190
3191         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
3192         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
3193         namei" instead of "const char *name" argument.
3194         (dw2_map_matching_symbols): Use "offset_type namei" variant of
3195         dw2_symtab_iter_init.
3196
3197 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3198
3199         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
3200         to use type::field and field::type instead.
3201
3202 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3203
3204         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
3205         to use field::type instead.
3206
3207 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3208
3209         * gdbtypes.h (struct field) <type, set_type>: New methods.
3210         Rename `type` field to...
3211         <m_type>: ... this.  Change references throughout to use type or
3212         set_type methods.
3213         (FIELD_TYPE): Use field::type.  Change call sites that modify
3214         the field's type to use field::set_type instead.
3215
3216 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3217
3218         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
3219         to use type::index_type instead.
3220
3221 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3222
3223         * gdbtypes.h (struct type) <index_type, set_index_type>: New
3224         methods.
3225         (TYPE_INDEX_TYPE): Use type::index_type.
3226         * gdbtypes.c (create_array_type_with_stride): Likewise.
3227
3228 2020-06-07  Tom Tromey  <tom@tromey.com>
3229
3230         * valprint.c (generic_val_print_float): Remove "embedded_offset"
3231         parameter.
3232         (generic_value_print): Update.
3233
3234 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3235
3236         Revert commit 982a38f60b0.
3237         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
3238
3239 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3240
3241         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
3242         avoid use after free.
3243
3244 2020-06-05  Tom de Vries  <tdevries@suse.de>
3245
3246         * NEWS: Fix typos.
3247
3248 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
3249
3250         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
3251         the per_bfd object.
3252         (dwarf2_read_debug_names): Likewise.
3253         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
3254         object when re-using a per_bfd object with an index.
3255
3256 2020-06-03  Tom de Vries  <tdevries@suse.de>
3257
3258         PR symtab/26046
3259         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
3260         children for C++.
3261         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
3262         DW_TAG_subprogram.
3263
3264 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3265
3266         * ada-lang.c (ada_language_data): Delete skip_trampoline
3267         initializer.
3268         * c-lang.c (c_language_data): Likewise.
3269         (cplus_language_data): Likewise.
3270         (cplus_language::skip_trampoline): New member function.
3271         (asm_language_data): Delete skip_trampoline initializer.
3272         (minimal_language_data): Likewise.
3273         * d-lang.c (d_language_data): Likewise.
3274         * f-lang.c (f_language_data): Likewise.
3275         * go-lang.c (go_language_data): Likewise.
3276         * language.c (unk_lang_trampoline): Delete function.
3277         (skip_language_trampoline): Update.
3278         (unknown_language_data): Delete skip_trampoline initializer.
3279         (auto_language_data): Likewise.
3280         * language.h (language_data): Delete skip_trampoline field.
3281         (language_defn::skip_trampoline): New function.
3282         * m2-lang.c (m2_language_data): Delete skip_trampoline
3283         initializer.
3284         * objc-lang.c (objc_skip_trampoline): Delete function, move
3285         implementation to objc_language::skip_trampoline.
3286         (objc_language_data): Delete skip_trampoline initializer.
3287         (objc_language::skip_trampoline): New member function with
3288         implementation from objc_skip_trampoline.
3289         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
3290         initializer.
3291         * p-lang.c (pascal_language_data): Likewise.
3292         * rust-lang.c (rust_language_data): Likewise.
3293
3294 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3295
3296         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
3297         (ada_language::demangle): New member function.
3298         * c-lang.c (c_language_data): Delete la_demangle initializer.
3299         (cplus_language_data): Delete la_demangle initializer.
3300         (cplus_language::demangle): New member function.
3301         (asm_language_data): Delete la_demangle initializer.
3302         (minimal_language_data): Delete la_demangle initializer.
3303         * d-lang.c (d_language_data): Delete la_demangle initializer.
3304         (d_language::demangle): New member function.
3305         * f-lang.c (f_language_data): Delete la_demangle initializer.
3306         (f_language::demangle): New member function.
3307         * go-lang.c (go_language_data): Delete la_demangle initializer.
3308         (go_language::demangle): New member function.
3309         * language.c (language_demangle): Update.
3310         (unk_lang_demangle): Delete.
3311         (unknown_language_data): Delete la_demangle initializer.
3312         (unknown_language::demangle): New member function.
3313         (auto_language_data): Delete la_demangle initializer.
3314         (auto_language::demangle): New member function.
3315         * language.h (language_data): Delete la_demangle field.
3316         (language_defn::demangle): New function.
3317         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
3318         * objc-lang.c (objc_language_data): Delete la_demangle
3319         initializer.
3320         (objc_language::demangle): New member function.
3321         * opencl-lang.c (opencl_language_data): Delete la_demangle
3322         initializer.
3323         * p-lang.c (pascal_language_data): Likewise.
3324         * rust-lang.c (rust_language_data): Likewise.
3325         (rust_language::demangle): New member function.
3326
3327 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3328
3329         * ada-lang.c (ada_language_data): Delete la_print_type
3330         initializer.
3331         (ada_language::print_type): New member function.
3332         * c-lang.c (c_language_data): Delete la_print_type initializer.
3333         (c_language::print_type): New member function.
3334         (cplus_language_data): Delete la_print_type initializer.
3335         (cplus_language::print_type): New member function.
3336         (asm_language_data): Delete la_print_type initializer.
3337         (asm_language::print_type): New member function.
3338         (minimal_language_data): Delete la_print_type initializer.
3339         (minimal_language::print_type): New member function.
3340         * d-lang.c (d_language_data): Delete la_print_type initializer.
3341         (d_language::print_type): New member function.
3342         * f-lang.c (f_language_data): Delete la_print_type initializer.
3343         (f_language::print_type): New member function.
3344         * go-lang.c (go_language_data): Delete la_print_type initializer.
3345         (go_language::print_type): New member function.
3346         * language.c (unk_lang_print_type): Delete.
3347         (unknown_language_data): Delete la_print_type initializer.
3348         (unknown_language::print_type): New member function.
3349         (auto_language_data): Delete la_print_type initializer.
3350         (auto_language::print_type): New member function.
3351         * language.h (language_data): Delete la_print_type field.
3352         (language_defn::print_type): New function.
3353         (LA_PRINT_TYPE): Update.
3354         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
3355         (m2_language::print_type): New member function.
3356         * objc-lang.c (objc_language_data): Delete la_print_type
3357         initializer.
3358         (objc_language::print_type): New member function.
3359         * opencl-lang.c (opencl_print_type): Delete, implementation moved
3360         to opencl_language::print_type.
3361         (opencl_language_data): Delete la_print_type initializer.
3362         (opencl_language::print_type): New member function, implementation
3363         from opencl_print_type.
3364         * p-lang.c (pascal_language_data): Delete la_print_type
3365         initializer.
3366         (pascal_language::print_type): New member function.
3367         * rust-lang.c (rust_print_type): Delete, implementation moved to
3368         rust_language::print_type.
3369         (rust_language_data): Delete la_print_type initializer.
3370         (rust_language::print_type): New member function, implementation
3371         from rust_print_type.
3372
3373 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3374
3375         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
3376         implementation moves to...
3377         (ada_language::sniff_from_mangled_name): ...here.  Update return
3378         type.
3379         (ada_language_data): Delete la_sniff_from_mangled_name
3380         initializer.
3381         * c-lang.c (c_language_data): Likewise.
3382         (cplus_language_data): Likewise.
3383         (cplus_language::sniff_from_mangled_name): New member function,
3384         implementation taken from gdb_sniff_from_mangled_name.
3385         (asm_language_data): Delete la_sniff_from_mangled_name
3386         initializer.
3387         (minimal_language_data): Likewise.
3388         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
3389         implementation moves to cplus_language::sniff_from_mangled_name.
3390         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
3391         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
3392         moves to...
3393         (d_language::sniff_from_mangled_name): ...here.
3394         (d_language_data): Delete la_sniff_from_mangled_name initializer.
3395         * f-lang.c (f_language_data): Likewise.
3396         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
3397         moves to...
3398         (go_language::sniff_from_mangled_name): ...here.
3399         (go_language_data): Delete la_sniff_from_mangled_name initializer.
3400         * language.c (language_sniff_from_mangled_name): Delete.
3401         (unknown_language_data): Delete la_sniff_from_mangled_name
3402         initializer.
3403         (auto_language_data): Likewise.
3404         * language.h (language_data): Delete la_sniff_from_mangled_name
3405         field.
3406         (language_defn::sniff_from_mangled_name): New function.
3407         (language_sniff_from_mangled_name): Delete declaration.
3408         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
3409         field.
3410         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
3411         implementation moves to...
3412         (objc_language::sniff_from_mangled_name): ...here.
3413         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
3414         * opencl-lang.c (opencl_language_data): Likewise.
3415         * p-lang.c (pascal_language_data): Likewise.
3416         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
3417         implementation moves to...
3418         (rust_language::sniff_from_mangled_name): ...here.
3419         (rust_language_data): Delete la_sniff_from_mangled_name
3420         initializer.
3421         * symtab.c (symbol_find_demangled_name): Call
3422         sniff_from_mangled_name member function.
3423
3424 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3425
3426         * ada-lang.c (ada_language_data): Delete la_search_name_hash
3427         initializer.
3428         * c-lang.c (c_language_data): Likewise.
3429         (cplus_language_data): Likewise.
3430         (cplus_language::search_name_hash): New member function.
3431         (asm_language_data): Delete la_search_name_hash initializer.
3432         (minimal_language_data): Likewise.
3433         * d-lang.c (d_language_data): Likewise.
3434         * dictionary.c (default_search_name_hash): Rename to...
3435         (language_defn::search_name_hash): ...this.
3436         * f-lang.c (f_language_data): Likewise.
3437         (f_language::search_name_hash): New member function.
3438         * go-lang.c (go_language_data): Delete la_search_name_hash
3439         initializer.
3440         * language.c (unknown_language_data): Likewise.
3441         (auto_language_data): Likewise.
3442         * language.h (struct language_data): Delete la_search_name_hash
3443         field.
3444         (language_defn::search_name_hash): Declare new member function.
3445         (default_search_name_hash): Delete declaration.
3446         * m2-lang.c (m2_language_data): Delete la_search_name_hash
3447         initializer.
3448         * objc-lang.c (objc_language_data): Likewise.
3449         * opencl-lang.c (opencl_language_data): Likewise.
3450         * p-lang.c (pascal_language_data): Likewise.
3451         * rust-lang.c (rust_language_data): Likewise.
3452         * symtab.c (search_name_hash): Update call.
3453
3454 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3455
3456         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
3457         initializer.
3458         * c-lang.c (class compile_instance): Declare.
3459         (c_language_data): Delete la_get_compile_instance initializer.
3460         (c_language::get_compile_instance): New member function.
3461         (cplus_language_data): Delete la_get_compile_instance initializer.
3462         (cplus_language::get_compile_instance): New member function.
3463         (asm_language_data): Delete la_get_compile_instance initializer.
3464         (minimal_language_data): Likewise.
3465         * c-lang.h (c_get_compile_context): Update comment.
3466         (cplus_get_compile_context): Update comment.
3467         * compile/compile.c (compile_to_object): Update calls, don't rely
3468         on function pointer being NULL.
3469         * d-lang.c (d_language_data): Delete la_get_compile_instance
3470         initializer.
3471         * f-lang.c (f_language_data): Likewise.
3472         * go-lang.c (go_language_data): Likewise.
3473         * language.c (unknown_language_data): Likewise.
3474         (auto_language_data): Likewise.
3475         * language.h (language_data): Delete la_get_compile_instance field.
3476         (language_defn::get_compile_instance): New member function.
3477         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
3478         initializer.
3479         * objc-lang.c (objc_language_data): Likewise.
3480         * opencl-lang.c (opencl_language_data): Likewise.
3481         * p-lang.c (pascal_language_data): Likewise.
3482         * rust-lang.c (rust_language_data): Likewise.
3483
3484 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3485
3486         * ada-lang.c (ada_add_all_symbols): Update comment.
3487         (ada_iterate_over_symbols): Delete, move implementation to...
3488         (ada_language::iterate_over_symbols): ...here, a new member
3489         function, rewrite to use range based for loop.
3490         (ada_language_data): Delete la_iterate_over_symbols initializer.
3491         * c-lang.c (c_language_data): Likewise.
3492         (cplus_language_data): Likewise.
3493         (asm_language_data): Likewise.
3494         (minimal_language_data): Likewise.
3495         * d-lang.c (d_language_data): Likewise.
3496         * f-lang.c (f_language_data): Likewise.
3497         * go-lang.c (go_language_data): Likewise.
3498         * language.c (unknown_language_data): Likewise.
3499         (auto_language_data): Likewise.
3500         * language.h (language_data): Delete la_iterate_over_symbols field.
3501         (language_defn::iterate_over_symbols): New member function.
3502         (LA_ITERATE_OVER_SYMBOLS): Update.
3503         * linespec.c (iterate_over_all_matching_symtabs): Update.
3504         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
3505         initializer.
3506         * objc-lang.c (objc_language_data): Likewise.
3507         * opencl-lang.c (opencl_language_data): Likewise.
3508         * p-lang.c (pascal_language_data): Likewise.
3509         * rust-lang.c (rust_language_data): Likewise.
3510
3511 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         * ada-lang.c (ada_language_data): Delete
3514         la_lookup_transparent_type initializer.
3515         * c-lang.c (c_language_data): Likewise.
3516         (cplus_language_data): Likewise.
3517         (cplus_language::lookup_transparent_type): New member function.
3518         (asm_language_data): Delete la_lookup_transparent_type
3519         initializer.
3520         (minimal_language_data): Likewise.
3521         * d-lang.c (d_language_data): Likewise.
3522         * f-lang.c (f_language_data): Likewise.
3523         * go-lang.c (go_language_data): Likewise.
3524         * language.c (unknown_language_data): Likewise.
3525         (auto_language_data): Likewise.
3526         * language.h (struct language_data): Delete
3527         la_lookup_transparent_type field.
3528         (language_defn::lookup_transparent_type): New member function.
3529         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
3530         initializer.
3531         * objc-lang.c (objc_language_data): Likewise.
3532         * opencl-lang.c (opencl_language_data): Likewise.
3533         * p-lang.c (pascal_language_data): Likewise.
3534         * rust-lang.c (rust_language_data): Likewise.
3535         * symtab.c (symbol_matches_domain): Update call.
3536
3537 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * ada-lang.c (ada_language_arch_info): Delete function, move
3540         implementation to...
3541         (ada_language::language_arch_info): ...here, a new member
3542         function.
3543         (ada_language_data): Delete la_language_arch_info.
3544         * c-lang.c (c_language_data): Likewise.
3545         (c_language::language_arch_info): New member function.
3546         (cplus_language_arch_info): Delete function, move
3547         implementation to...
3548         (cplus_language::language_arch_info): ...here, a new member
3549         function.
3550         (cplus_language_data): Delete la_language_arch_info.
3551         (asm_language_data): Likewise.
3552         (asm_language::language_arch_info): New member function.
3553         (minimal_language_data): Delete la_language_arch_info.
3554         (minimal_language::language_arch_info): New member function.
3555         * d-lang.c (d_language_arch_info): Delete function, move
3556         implementation to...
3557         (d_language::language_arch_info): ...here, a new member
3558         function.
3559         (d_language_data): Delete la_language_arch_info.
3560         * f-lang.c (f_language_arch_info): Delete function, move
3561         implementation to...
3562         (f_language::language_arch_info): ...here, a new member
3563         function.
3564         (f_language_data): Delete la_language_arch_info.
3565         * go-lang.c (go_language_arch_info): Delete function, move
3566         implementation to...
3567         (go_language::language_arch_info): ...here, a new member
3568         function.
3569         (go_language_data): Delete la_language_arch_info.
3570         * language.c (unknown_language_data): Likewise.
3571         (unknown_language::language_arch_info): New member function.
3572         (auto_language_data): Delete la_language_arch_info.
3573         (auto_language::language_arch_info): New member function.
3574         (language_gdbarch_post_init): Update call to
3575         la_language_arch_info.
3576         * language.h (language_data): Delete la_language_arch_info
3577         function pointer.
3578         (language_defn::language_arch_info): New function.
3579         * m2-lang.c (m2_language_arch_info): Delete function, move
3580         implementation to...
3581         (m2_language::language_arch_info): ...here, a new member
3582         function.
3583         (m2_language_data): Delete la_language_arch_info.
3584         * objc-lang.c (objc_language_arch_info): Delete function, move
3585         implementation to...
3586         (objc_language::language_arch_info): ...here, a new member
3587         function.
3588         (objc_language_data): Delete la_language_arch_info.
3589         * opencl-lang.c (opencl_language_arch_info): Delete function, move
3590         implementation to...
3591         (opencl_language::language_arch_info): ...here, a new member
3592         function.
3593         (opencl_language_data): Delete la_language_arch_info.
3594         * p-lang.c (pascal_language_arch_info): Delete function, move
3595         implementation to...
3596         (pascal_language::language_arch_info): ...here, a new member
3597         function.
3598         (pascal_language_data): Delete la_language_arch_info.
3599         * rust-lang.c (rust_language_arch_info): Delete function, move
3600         implementation to...
3601         (rust_language::language_arch_info): ...here, a new member
3602         function.
3603         (rust_language_data): Delete la_language_arch_info.
3604
3605 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3606
3607         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
3608         initializer.
3609         * c-lang.c (c_language_data): Likewise.
3610         (cplus_language_data): Likewise.
3611         (cplus_language::pass_by_reference_info): New method.
3612         (asm_language_data): Delete la_pass_by_reference initializer.
3613         (minimal_language_data): Likewise.
3614         * cp-abi.c (cp_pass_by_reference): Remove use of
3615         default_pass_by_reference.
3616         * d-lang.c (d_language_data): Likewise.
3617         * f-lang.c (f_language_data): Likewise.
3618         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
3619         default_pass_by_reference.
3620         * go-lang.c (go_language_data): Likewise.
3621         * language.c (language_pass_by_reference): Update.
3622         (default_pass_by_reference): Delete.
3623         (unknown_language_data): Delete la_pass_by_reference
3624         initializer.
3625         (auto_language_data): Likewise.
3626         * language.h (struct language_data): Delete la_pass_by_reference
3627         field.
3628         (language_defn::pass_by_reference_info): New member function.
3629         (default_pass_by_reference): Delete declaration.
3630         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
3631         initializer.
3632         * objc-lang.c (objc_language_data): Likewise.
3633         * opencl-lang.c (opencl_language_data): Likewise.
3634         * p-lang.c (pascal_language_data): Likewise.
3635         * rust-lang.c (rust_language_data): Likewise.
3636
3637 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3638
3639         * ada-lang.c (ada_read_var_value): Delete function, move
3640         implementation to...
3641         (ada_language::read_var_value): ...here.
3642         (ada_language_data): Delete la_read_var_value initializer.
3643         * c-lang.c (c_language_data): Likewise.
3644         (cplus_language_data): Likewise.
3645         (minimal_language_data): Likewise.
3646         * d-lang.c (d_language_data): Likewise.
3647         * f-lang.c (f_language_data): Likewise.
3648         * findvar.c (default_read_var_value): Rename to...
3649         (language_defn::read_var_value): ...this.
3650         * findvar.c (read_var_value): Update header comment, and change to
3651         call member function instead of function pointer.
3652         * go-lang.c (go_language_data): Likewise.
3653         * language.c (unknown_language_data): Delete la_read_var_value
3654         initializer.
3655         (auto_language_data): Likewise.
3656         * language.h (struct language_data): Delete la_read_var_value
3657         field.
3658         (language_defn::read_var_value): New member function.
3659         (default_read_var_value): Delete declaration.
3660         * m2-lang.c (m2_language_data): Delete la_read_var_value
3661         initializer.
3662         * objc-lang.c (objc_language_data): Likewise.
3663         * opencl-lang.c (opencl_language_data): Likewise.
3664         * p-lang.c (pascal_language_data): Likewise.
3665         * rust-lang.c (rust_language_data): Likewise.
3666         * value.h (default_read_var_value): Delete declaration.
3667
3668 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * ada-lang.c (ada_print_array_index): Delete function, move
3671         implementation to...
3672         (ada_language::print_array_index): ...here.
3673         (ada_language_data): Delete la_print_array_index initializer.
3674         * c-lang.c (c_language_data): Likewise.
3675         (cplus_language_data): Likewise.
3676         (minimal_language_data): Likewise.
3677         * d-lang.c (d_language_data): Likewise.
3678         * f-lang.c (f_language_data): Likewise.
3679         * go-lang.c (go_language_data): Likewise.
3680         * language.c (default_print_array_index): Delete function, move
3681         implementation to...
3682         (language_defn::print_array_index): ...here.
3683         (unknown_language_data): Delete la_print_array_index initializer.
3684         (auto_language_data): Likewise.
3685         * language.h (struct language_data): Delete la_print_array_index
3686         field.
3687         (language_defn::print_array_index): New member function.
3688         (LA_PRINT_ARRAY_INDEX): Update.
3689         (default_print_array_index): Delete declaration.
3690         * m2-lang.c (m2_language_data): Delete la_print_array_index
3691         initializer.
3692         * objc-lang.c (objc_language_data): Likewise.
3693         * opencl-lang.c (opencl_language_data): Likewise.
3694         * p-lang.c (pascal_language_data): Likewise.
3695         * rust-lang.c (rust_language_data): Likewise.
3696
3697 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3698
3699         * gdb/ada-lang.c (ada_language_defn): Convert to...
3700         (ada_language_data): ...this.
3701         (class ada_language): New class.
3702         (ada_language_defn): New static global.
3703         * gdb/c-lang.c (c_language_defn): Convert to...
3704         (c_language_data): ...this.
3705         (class c_language): New class.
3706         (c_language_defn): New static global.
3707         (cplus_language_defn): Convert to...
3708         (cplus_language_data): ...this.
3709         (class cplus_language): New class.
3710         (cplus_language_defn): New static global.
3711         (asm_language_defn): Convert to...
3712         (asm_language_data): ...this.
3713         (class asm_language): New class.
3714         (asm_language_defn): New static global.
3715         (minimal_language_defn): Convert to...
3716         (minimal_language_data): ...this.
3717         (class minimal_language): New class.
3718         (minimal_language_defn): New static global.
3719         * gdb/d-lang.c (d_language_defn): Convert to...
3720         (d_language_data): ...this.
3721         (class d_language): New class.
3722         (d_language_defn): New static global.
3723         * gdb/f-lang.c (f_language_defn): Convert to...
3724         (f_language_data): ...this.
3725         (class f_language): New class.
3726         (f_language_defn): New static global.
3727         * gdb/go-lang.c (go_language_defn): Convert to...
3728         (go_language_data): ...this.
3729         (class go_language): New class.
3730         (go_language_defn): New static global.
3731         * gdb/language.c (unknown_language_defn): Remove declaration.
3732         (current_language): Initialize to nullptr, real initialization is
3733         moved to _initialize_language.
3734         (languages): Delete global.
3735         (language_defn::languages): Define.
3736         (set_language_command): Use language_defn::languages.
3737         (set_language): Likewise.
3738         (range_error): Likewise.
3739         (language_enum): Likewise.
3740         (language_def): Likewise.
3741         (add_set_language_command): Use language_def::languages for the
3742         language list, and language_def to lookup language pointers.
3743         (skip_language_trampoline): Use language_defn::languages.
3744         (unknown_language_defn): Convert to...
3745         (unknown_language_data): ...this.
3746         (class unknown_language): New class.
3747         (unknown_language_defn): New static global.
3748         (auto_language_defn): Convert to...
3749         (auto_language_data): ...this.
3750         (class auto_language): New class.
3751         (auto_language_defn): New static global.
3752         (language_gdbarch_post_init): Use language_defn::languages.
3753         (_initialize_language): Initialize current_language.
3754         * gdb/language.h (struct language_defn): Rename to...
3755         (struct language_data): ...this.
3756         (struct language_defn): New.
3757         (auto_language_defn): Delete.
3758         (unknown_language_defn): Delete.
3759         (minimal_language_defn): Delete.
3760         (ada_language_defn): Delete.
3761         (asm_language_defn): Delete.
3762         (c_language_defn): Delete.
3763         (cplus_language_defn): Delete.
3764         (d_language_defn): Delete.
3765         (f_language_defn): Delete.
3766         (go_language_defn): Delete.
3767         (m2_language_defn): Delete.
3768         (objc_language_defn): Delete.
3769         (opencl_language_defn): Delete.
3770         (pascal_language_defn): Delete.
3771         (rust_language_defn): Delete.
3772         * gdb/m2-lang.c (m2_language_defn): Convert to...
3773         (m2_language_data): ...this.
3774         (class m2_language): New class.
3775         (m2_language_defn): New static global.
3776         * gdb/objc-lang.c (objc_language_defn): Convert to...
3777         (objc_language_data): ...this.
3778         (class objc_language): New class.
3779         (objc_language_defn): New static global.
3780         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
3781         (opencl_language_data): ...this.
3782         (class opencl_language): New class.
3783         (opencl_language_defn): New static global.
3784         * gdb/p-lang.c (pascal_language_defn): Convert to...
3785         (pascal_language_data): ...this.
3786         (class pascal_language): New class.
3787         (pascal_language_defn): New static global.
3788         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
3789         language pointer, update comment format.
3790         * gdb/rust-lang.c (rust_language_defn): Convert to...
3791         (rust_language_data): ...this.
3792         (class rust_language): New class.
3793         (rust_language_defn): New static global.
3794
3795 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3796
3797         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
3798         member variable.
3799         <m_stmt_at_address>: New member variable.
3800         (lnp_state_machine::record_line): Don't record some lines, update
3801         tracking of is_stmt at the same address.
3802         (lnp_state_machine::lnp_state_machine): Initialise new member
3803         variables.
3804
3805 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3806
3807         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
3808         "-include gnu-nat-mig.h".
3809         * gnu-nat-mig.h: New file.
3810         * gnu-nat.c: Include "gnu-nat-mig.h".
3811         (exc_server, msg_reply_server, notify_server,
3812         process_reply_server): Remove declarations.
3813
3814 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3815
3816         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
3817         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
3818         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
3819         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
3820         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
3821         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
3822         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
3823         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
3824         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
3825         to gnu_nat_target class.
3826         * gnu-nat.c: Likewise.
3827         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
3828         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
3829         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
3830         object.
3831         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
3832         instead of `gnu_target'.
3833
3834 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3835
3836         * i386-gnu-tdep.c: Include "gdbcore.h"
3837         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
3838         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
3839         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
3840         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
3841         i386_gnu_sigcontext_addr): New functions
3842         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
3843         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
3844         tdep.
3845
3846 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3847
3848         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
3849         before fork_inferior call. Avoid calling it if target_is_pushed returns
3850         true.
3851
3852 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3853
3854         * gnu-nat.h (gnu_target): New variable declaration.
3855         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
3856         gnu_target.
3857         * gnu-nat.c (gnu_target): New variable.
3858         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
3859         add_thread_silent, and add_thread calls.
3860         (gnu_nat_target::create_inferior): Pass gnu_target to
3861         add_thread_silent, thread_change_ptid call.
3862         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
3863         call.
3864
3865 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3866
3867         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
3868         (gnu_nat_target::find_memory_regions): Remove unused
3869         `old_address' variable.
3870
3871 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3872
3873         * gnu-nat.c: Include "gdbarch.h".
3874
3875 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3876
3877         * reply_mig_hack.awk (Error return): Cast function through
3878         void *, to bypass compiler function call check.
3879
3880 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3881
3882         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
3883         $(srcdir)/reply_mig_hack.awk.
3884
3885 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3886
3887         * gnu-nat.h (gnu_debug_flag): Set type to bool.
3888
3889 2020-05-30  Jonny Grant  <jg@jguk.org>
3890
3891         * configure.ac (ACX_BUGURL): change bug URL to https.
3892
3893 2020-05-30  Pedro Alves  <palves@redhat.com>
3894
3895         * cp-support.c (replace_typedefs_template): New.
3896         (replace_typedefs_qualified_name): Handle
3897         DEMANGLE_COMPONENT_TEMPLATE.
3898
3899 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
3900
3901         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
3902         dwarf2/index-cache.h, dwarf2/index-write.c,
3903         dwarf2/index-write.h, dwarf2/line-header.c,
3904         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
3905         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
3906         variables and fields from `dwarf2_per_objfile` to just
3907         `per_objfile` throughout.
3908
3909 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
3910
3911         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3912         <push_dwarf_reg_entry_value>: Add comment.
3913
3914 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
3915             Keith Seitz  <keiths@redhat.com>
3916
3917         * python/python.c (do_start_initialization): Call PyEval_SaveThread
3918         instead of PyEval_ReleaseLock.
3919         (class gdbpy_gil): Move to earlier in file.
3920         (finalize_python): Set gdb_python_initialized.
3921         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
3922         when not initialized.
3923
3924 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
3925
3926         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3927         <push_dwarf_reg_entry_value>: Remove assert.  Override
3928         per_objfile with caller_per_objfile.
3929
3930 2020-05-28  Tom de Vries  <tdevries@suse.de>
3931
3932         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
3933         PR gold/15646 workaround to symbol kind "type".
3934
3935 2020-05-27  Tom Tromey  <tromey@adacore.com>
3936
3937         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
3938
3939 2020-05-27  Tom Tromey  <tromey@adacore.com>
3940
3941         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
3942         Use htab_find_with_hash.
3943         <add_abbrev>: Remove "abbrev_number" parameter.
3944         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
3945         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
3946         (hash_abbrev): Add comment.
3947         (abbrev_table::lookup_abbrev): Move to header file.
3948         (abbrev_table::read): Update.
3949
3950 2020-05-27  Tom Tromey  <tromey@adacore.com>
3951
3952         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
3953         method.
3954         <canonical_name>: New member.
3955         <raw_name>: Rename from "name".
3956         (partial_die_info): Initialize canonical_name.
3957         (scan_partial_symbols): Check raw_name.
3958         (partial_die_parent_scope, partial_die_full_name)
3959         (add_partial_symbol, add_partial_subprogram)
3960         (add_partial_enumeration, load_partial_dies): Use "name" method.
3961         (partial_die_info::name): New method.
3962         (partial_die_info::read, guess_partial_die_structure_name)
3963         (partial_die_info::fixup): Update.
3964
3965 2020-05-27  Tom Tromey  <tromey@adacore.com>
3966
3967         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
3968         <get_ref_die_offset>: Inline.
3969         <get_ref_die_offset_complaint>: New method.
3970         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
3971         (attribute::get_ref_die_offset_complaint): Rename from
3972         get_ref_die_offset.  Just issue complaint.
3973
3974 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3975
3976         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
3977
3978 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3979
3980         * exec.c (exec_file_attach): Use errno value of first openp failure.
3981
3982 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3983
3984         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
3985         Don't close thread handle.
3986
3987 2020-05-27  Tom Tromey  <tom@tromey.com>
3988             Simon Marchi  <simon.marchi@efficios.com>
3989
3990         * objfiles.h (struct objfile) <partial_symtabs>: Now a
3991         shared_ptr.
3992         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
3993         member.
3994         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
3995         dwarf2_per_bfd_objfile_data_key>: New globals.
3996         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
3997         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
3998         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
3999         shared.
4000         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
4001         short-circuit when sharing.
4002         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
4003         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
4004
4005 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4006
4007         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
4008         to...
4009         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
4010         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
4011
4012 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4013
4014         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
4015         build_name_components, find_name_components_bounds>:
4016         Add per_objfile parameter.
4017         (struct mapped_index) <symbol_name_at>: Likewise.
4018         (struct mapped_debug_names): Remove constructor.
4019         <dwarf2_per_objfile>: Remove field.
4020         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
4021         (mapped_index_base::find_name_components_bounds,
4022         mapped_index_base::build_name_components,
4023         dw2_expand_symtabs_matching_symbol): Likewise.
4024         (class mock_mapped_index) <symbol_name_at>: Likewise.
4025         (check_match): Likewise.
4026         (check_find_bounds_finds): Likewise.
4027         (test_mapped_index_find_name_component_bounds): Update.
4028         (CHECK_MATCH): Update.
4029         (dw2_expand_symtabs_matching): Update.
4030         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
4031         per_objfile parameter.
4032         <find_vec_in_debug_names>: Likewise.
4033         <m_per_objfile>: New field.
4034         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
4035         parameter.
4036         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
4037         (dw2_debug_names_iterator::next): Update.
4038         (dw2_debug_names_lookup_symbol): Update.
4039         (dw2_debug_names_expand_symtabs_for_function): Update.
4040         (dw2_debug_names_map_matching_symbols): Update.
4041         (dw2_debug_names_expand_symtabs_matching): Update.
4042         (dwarf2_read_debug_names): Update.
4043
4044 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4045
4046         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
4047         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
4048         move to dwarf2_per_objfile.
4049         <read_in_chain>: Remove.
4050         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
4051         remove_all_cus, age_comp_units>: New methods.
4052         <m_dwarf2_cus>: New member.
4053         (struct dwarf2_per_cu_data) <cu>: Remove.
4054         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
4055         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
4056         moved to methods of dwarf2_per_objfile.
4057         (dwarf2_clear_marks): Remove.
4058         (dwarf2_queue_item::~dwarf2_queue_item): Update.
4059         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
4060         (dwarf2_per_bfd::free_cached_comp_units): Remove.
4061         (dwarf2_per_objfile::remove_all_cus): New.
4062         (class free_cached_comp_units) <~free_cached_comp_units>:
4063         Update.
4064         (load_cu): Update.
4065         (dw2_do_instantiate_symtab): Adjust.
4066         (fill_in_sig_entry_from_dwo_entry): Adjust.
4067         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4068         (cutu_reader::cutu_reader): Likewise.
4069         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
4070         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
4071         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
4072         and dwarf2_per_objfile::age_comp_units.
4073         (load_partial_comp_unit): Update.
4074         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
4075         (process_queue): Likewise.
4076         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
4077         backlink.
4078         (dwarf2_read_addr_index): Likewise.
4079         (follow_die_offset): Likewise.
4080         (dwarf2_fetch_die_loc_sect_off): Likewise.
4081         (dwarf2_fetch_constant_bytes): Likewise.
4082         (dwarf2_fetch_die_type_sect_off): Likewise.
4083         (follow_die_sig_1): Likewise.
4084         (load_full_type_unit): Likewise.
4085         (read_signatured_type): Likewise.
4086         (dwarf2_cu::dwarf2_cu): Don't set cu field.
4087         (dwarf2_cu::~dwarf2_cu): Remove.
4088         (dwarf2_per_objfile::get_cu): New.
4089         (dwarf2_per_objfile::set_cu): New.
4090         (age_cached_comp_units): Rename to...
4091         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
4092         to std::unordered_map.
4093         (free_one_cached_comp_unit): Rename to...
4094         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
4095         to std::unordered_map.
4096         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
4097         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
4098         a dwarf2_per_objfile in data.
4099         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
4100         (dwarf2_clear_marks): Remove.
4101
4102 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4103
4104         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
4105         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
4106         (init_tu_and_read_dwo_dies): Likewise.
4107         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
4108         (cutu_reader::cutu_reader): Likewise.
4109         (load_partial_comp_unit): Likewise.
4110         (process_psymtab_comp_unit): Update.
4111         (build_type_psymtabs_1): Update.
4112         (process_skeletonless_type_unit): Update.
4113         (load_full_comp_unit): Update.
4114         (find_partial_die): Update.
4115         (dwarf2_read_addr_index): Update.
4116         (read_signatured_type): Update.
4117
4118 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4119
4120         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
4121         m_header_read_in>: New fields.
4122         <get_header>: New method.
4123         * dwarf2/read.c (per_cu_header_read_in): Remove.
4124         (dwarf2_per_cu_data::get_header): New.
4125         (dwarf2_per_cu_data::addr_size): Update.
4126         (dwarf2_per_cu_data::offset_size): Update.
4127         (dwarf2_per_cu_data::ref_addr_size): Update.
4128
4129 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4130
4131         * dwarf2/read.c (load_cu): Return dwarf2_cu.
4132         (dw2_do_instantiate_symtab): Update.
4133         (queue_and_load_all_dwo_tus): Change parameter from
4134         dwarf2_per_cu_data to dwarf2_cu.
4135         (dwarf2_fetch_die_loc_sect_off): Update.
4136         (dwarf2_fetch_constant_bytes): Update.
4137         (dwarf2_fetch_die_type_sect_off): Update.
4138
4139 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4140
4141         * dwarf2/read.c (process_full_comp_unit,
4142         process_full_type_unit): Remove per_cu, per_objfile paramters.
4143         Add dwarf2_cu parameter.
4144         (process_queue): Update.
4145
4146 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4147
4148         * dwarf2/read.c (create_cu_from_index_list): Replace
4149         dwarf2_per_objfile parameter with dwarf2_per_bfd.
4150         (create_cus_from_index_list): Likewise.
4151         (create_cus_from_index): Likewise.
4152         (create_signatured_type_table_from_index): Likewise.
4153         (create_cus_from_debug_names_list): Likewise.
4154         (create_cus_from_debug_names): Likewise.
4155         (dwarf2_read_gdb_index): Update.
4156         (dwarf2_read_debug_names): Update.
4157
4158 2020-05-27  Tom Tromey  <tom@tromey.com>
4159             Simon Marchi  <simon.marchi@efficios.com>
4160
4161         * dwarf2/read.h (struct dwarf2_per_objfile)
4162         <get_type_for_signatured_type, set_type_for_signatured_type>:
4163         New methods.
4164         <m_type_map>: New member.
4165         (struct signatured_type) <type>: Remove.
4166         * dwarf2/read.c
4167         (dwarf2_per_objfile::get_type_for_signatured_type,
4168         dwarf2_per_objfile::set_type_for_signatured_type): New.
4169         (get_signatured_type): Use new methods.
4170
4171 2020-05-27  Tom Tromey  <tom@tromey.com>
4172             Simon Marchi  <simon.marchi@efficios.com>
4173
4174         * dwarf2/read.h (struct type_unit_group_unshareable): New.
4175         (struct dwarf2_per_objfile) <type_units>: New member.
4176         <get_type_unit_group_unshareable>: New method.
4177         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
4178         num_symtabs, symtabs>: Remove; move to
4179         type_unit_group_unshareable.
4180         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
4181         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
4182         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
4183
4184 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4185
4186         * dwarf2/read.h (struct dwarf2_per_cu_data):
4187         <dwarf2_per_objfile>: Remove.
4188         * dwarf2/read.c (create_cu_from_index_list): Don't assign
4189         dwarf2_per_objfile.
4190         (create_signatured_type_table_from_index): Likewise.
4191         (create_signatured_type_table_from_debug_names): Likewise.
4192         (create_debug_type_hash_table): Likewise.
4193         (fill_in_sig_entry_from_dwo_entry): Likewise.
4194         (create_type_unit_group): Likewise.
4195         (read_comp_units_from_section): Likewise.
4196         (create_cus_hash_table): Likewise.
4197
4198 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4199
4200         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
4201         dwarf2_per_cu_data::dwarf2_per_objfile.
4202         (compute_compunit_symtab_includes): Likewise.
4203         (dwarf2_cu::start_symtab): Likewise.
4204
4205 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4206
4207         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
4208         parameter.
4209         * dwarf2/read.c (get_die_type_at_offset): Likewise.
4210         (read_namespace_alias): Update.
4211         (lookup_die_type): Update.
4212         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
4213         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
4214         Update.
4215         (disassemble_dwarf_expression): Update.
4216
4217 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4218
4219         * dwarf2/read.h (struct dwarf2_queue_item): Add
4220         dwarf2_per_objfile parameter, assign new parameter.
4221         <per_objfile>: New field.
4222         * dwarf2/read.c (free_one_cached_comp_unit): Add
4223         dwarf2_per_objfile parameter.
4224         (queue_comp_unit): Likewise.
4225         (dw2_do_instantiate_symtab): Update.
4226         (process_psymtab_comp_unit): Update.
4227         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
4228         (process_imported_unit_die): Update.
4229         (queue_and_load_dwo_tu): Update.
4230         (follow_die_offset): Update.
4231         (follow_die_sig_1): Update.
4232
4233 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4234
4235         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
4236         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
4237         (read_call_site_scope): Assign per_objfile.
4238         (dwarf2_per_cu_data::objfile): Remove.
4239         * gdbtypes.h (struct call_site) <per_objfile>: New member.
4240         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
4241         dwarf2_per_objfile parameter.
4242         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
4243         dwarf2_per_objfile parameter.
4244         (dwarf_expr_reg_to_entry_parameter): Add output
4245         dwarf2_per_objfile parameter.
4246         (locexpr_get_frame_base): Update.
4247         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
4248         <push_dwarf_reg_entry_value>: Update.
4249         <call_site_to_target_addr>: Update.
4250         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
4251         parameter.
4252         (value_of_dwarf_reg_entry): Update.
4253         (rw_pieced_value): Update.
4254         (indirect_synthetic_pointer): Update.
4255         (dwarf2_evaluate_property): Update.
4256         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
4257         parameter.
4258         (locexpr_read_variable): Update.
4259         (locexpr_get_symbol_read_needs): Update.
4260         (loclist_read_variable): Update.
4261
4262 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4263
4264         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
4265         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
4266         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
4267         parameter.
4268         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
4269         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
4270         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
4271         parameter.
4272         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
4273         sect_variable_value): Add dwarf2_per_objfile parameter.
4274         (class dwarf_evaluate_loc_desc) <dwarf_call,
4275         dwarf_variable_value>: Update.
4276         (fetch_const_value_from_synthetic_pointer): Add
4277         dwarf2_per_objfile parameter.
4278         (fetch_const_value_from_synthetic_pointer): Update.
4279         (coerced_pieced_ref): Update.
4280         (class symbol_needs_eval_context) <dwarf_call,
4281         dwarf_variable_value>: Update.
4282         (dwarf2_compile_expr_to_ax): Update.
4283
4284 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4285
4286         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
4287         parameter.
4288         (dwarf2_evaluate_loc_desc_full): Update.
4289
4290 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4291
4292         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
4293         parameter.
4294         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
4295         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
4296         dwarf2_per_objfile parameter.
4297         (decode_debug_loc_dwo_addresses): Likewise.
4298         (dwarf2_find_location_expression): Update.
4299         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
4300         (locexpr_describe_location_piece): Add dwarf2_per_objfile
4301         parameter.
4302         (disassemble_dwarf_expression): Add dwarf2_per_objfile
4303         parameter.
4304         (locexpr_describe_location_1): Likewise.
4305         (locexpr_describe_location): Update.
4306
4307 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4308
4309         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
4310         Remove.
4311         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
4312         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
4313         (dwarf2_compile_property_to_c): Update.
4314         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
4315         use text offset from objfile.
4316         (locexpr_tracepoint_var_ref): Update.
4317         (locexpr_generate_c_location): Update.
4318         (loclist_describe_location): Update.
4319         (loclist_tracepoint_var_ref): Update.
4320         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
4321         dwarf2_per_objfile parameter.
4322         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
4323         use text offset from objfile.
4324         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
4325
4326 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4327
4328         * dwarf2/expr.h (struct dwarf_expr_context)
4329         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
4330         <offset>: Remove.
4331         <per_objfile>: New member.
4332         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
4333         dwarf2_per_objfile parameter.  Don't set offset, set
4334         per_objfile.
4335         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
4336         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
4337         a dwarf2_per_objfile object instead of an offset.
4338         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
4339         constructor.
4340         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
4341         to dwarf2_expr_executor constructor.  Don't set offset.
4342         (dwarf2_fetch_cfa_info): Update.
4343         (struct dwarf2_frame_cache) <text_offset>: Remove.
4344         <per_objfile>: New field.
4345         (dwarf2_frame_cache): Update.
4346         (dwarf2_frame_prev_register): Update.
4347         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
4348         <dwarf_evaluate_loc_desc>: Add constructor.
4349         (dwarf2_evaluate_loc_desc_full): Update.
4350         (dwarf2_locexpr_baton_eval): Update.
4351         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
4352         Add constructor.
4353         (dwarf2_loc_desc_get_symbol_read_needs): Update.
4354
4355 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4356
4357         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
4358         addr_sized_int_type>: Move to dwarf2_cu.
4359         <int_type>: Move to dwarf2_per_objfile.
4360         (struct dwarf2_per_objfile) <int_type>: Move here.
4361         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
4362         addr_sized_int_type>: Move here.
4363         (read_func_scope): Update.
4364         (read_array_type): Update.
4365         (read_tag_string_type): Update.
4366         (attr_to_dynamic_prop): Update.
4367         (dwarf2_per_cu_data::int_type): Rename to...
4368         (dwarf2_per_objfile::int_type): ... this.
4369         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
4370         (dwarf2_cu::addr_sized_int_type): ... this.
4371         (read_subrange_type): Update.
4372         (dwarf2_per_cu_data::addr_type): Rename to...
4373         (dwarf2_cu::addr_type): ... this.
4374         (set_die_type): Update.
4375
4376 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4377
4378         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
4379         data through per_cu->cu.
4380
4381 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4382
4383         * dwarf2/read.c (lookup_dwo_comp_unit): Change
4384         dwarf2_per_cu_data parameter fo dwarf2_cu.
4385         (lookup_dwo_type_unit): Likewise.
4386         (read_cutu_die_from_dwo): Likewise.
4387         (lookup_dwo_unit): Likewise.
4388         (open_and_init_dwo_file): Likewise.
4389         (lookup_dwo_cutu): Likewise.
4390         (lookup_dwo_comp_unit): Likewise.
4391         (lookup_dwo_type_unit): Likewise.
4392         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4393         (cutu_reader::cutu_reader): Update.
4394
4395 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4396
4397         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
4398         parameter.
4399         (process_full_type_unit): Likewise.
4400         (process_queue): Update.
4401
4402 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4403
4404         * dwarf2/read.c (recursively_compute_inclusions): Add
4405         dwarf2_per_objfile parameter.
4406         (compute_compunit_symtab_includes): Likewise.
4407         (process_cu_includes): Update.
4408
4409 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4410
4411         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
4412         parameter.
4413         (create_type_unit_group): Update.
4414         (process_psymtab_comp_unit_reader): Update.
4415         (build_type_psymtabs_reader): Update.
4416
4417 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4418
4419         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
4420         object through m_this_cu->cu.
4421
4422 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4423
4424         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
4425         the info parameter.
4426         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
4427
4428 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4429
4430         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
4431         per_objfile parameter.
4432         (load_full_type_unit): Add per_objfile parameter.
4433         (read_signatured_type): Likewise.
4434         (load_full_comp_unit): Likewise.
4435         (load_cu): Likewise.
4436         (dw2_do_instantiate_symtab): Likewise.
4437         (dw2_get_file_names): Likewise.
4438         (dw2_map_symtabs_matching_filename): Update.
4439         (dw_expand_symtabs_matching_file_matcher): Update.
4440         (dw2_map_symbol_filenames): Update.
4441         (process_psymtab_comp_unit): Add per_objfile parameter.
4442         (build_type_psymtabs_1): Update.
4443         (process_skeletonless_type_unit): Update.
4444         (dwarf2_build_psymtabs_hard): Update.
4445         (load_partial_comp_unit): Add per_objfile parameter.
4446         (scan_partial_symbols): Update.
4447         (load_full_comp_unit): Add per_objfile parameter.
4448         (process_imported_unit_die): Update.
4449         (create_cus_hash_table): Update.
4450         (find_partial_die): Update.
4451         (dwarf2_read_addr_index): Update.
4452         (follow_die_offset): Update.
4453         (dwarf2_fetch_die_loc_sect_off): Update.
4454         (dwarf2_fetch_constant_bytes): Update.
4455         (dwarf2_fetch_die_type_sect_off): Update.
4456         (follow_die_sig_1): Update.
4457         (load_full_type_unit): Add per_objfile parameter.
4458         (read_signatured_type): Likewise.
4459
4460 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4461
4462         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
4463         of objfile_name.
4464
4465 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4466
4467         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
4468         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
4469         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
4470         field.
4471         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
4472         (create_cus_from_index): Update.
4473         (dwarf2_read_gdb_index): Update.
4474         (create_cus_from_debug_names): Update.
4475         (dwarf2_read_debug_names): Update.
4476         (get_abbrev_section_for_cu): Update.
4477         (create_all_comp_units): Update.
4478         (read_attribute_value): Update.
4479         (get_debug_line_section): Update.
4480         * dwarf2/index-cache.c (index_cache::store): Update.
4481         * dwarf2/index-write.c (save_gdb_index_command): Update.
4482         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
4483
4484 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4485
4486         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
4487         member.
4488         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
4489         dwarf2_per_cu_data::per_bfd.
4490         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
4491         (create_type_unit_group): Likewise.
4492         (queue_comp_unit): Remove reference to
4493         per_cu->dwarf2_per_objfile.
4494         (maybe_queue_comp_unit): Likewise.
4495         (fill_in_sig_entry_from_dwo_entry): Assign new field.
4496         (create_cus_hash_table): Assign new field.
4497
4498 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4499
4500         * dwarf2/read.c: Replace
4501         dwarf2_cu->per_cu->dwarf2_per_objfile references with
4502         dwarf2_cu->per_objfile throughout.
4503
4504 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4505
4506         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
4507         parameter, don't use per_cu->dwarf2_per_objfile.
4508         (dw2_instantiate_symtab): Likewise.
4509         (dw2_find_last_source_symtab): Update.
4510         (dw2_map_expand_apply): Update.
4511         (dw2_lookup_symbol): Update.
4512         (dw2_expand_symtabs_for_function): Update.
4513         (dw2_expand_all_symtabs): Update.
4514         (dw2_expand_symtabs_with_fullname): Update.
4515         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
4516         don't use per_cu->dwarf2_per_objfile.
4517         (dw2_expand_marked_cus): Update.
4518         (dw2_find_pc_sect_compunit_symtab): Update.
4519         (dw2_debug_names_lookup_symbol): Update.
4520         (dw2_debug_names_expand_symtabs_for_function): Update.
4521         (dw2_debug_names_map_matching_symbols): Update.
4522         (dwarf2_psymtab::expand_psymtab): Update.
4523
4524 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4525
4526         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
4527         <per_objfile>: New member.
4528         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
4529         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
4530         call to dwarf2_cu.
4531         (cutu_reader::cutu_reader): Update.
4532         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
4533
4534 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4535
4536         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
4537         struct dwarf2_per_objfile.
4538         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
4539         dwarf2_per_bfd.
4540         * dwarf2/read.c (set_die_type): Update.
4541         (get_die_type_at_offset): Update.
4542
4543 2020-05-27  Tom Tromey  <tom@tromey.com>
4544             Simon Marchi  <simon.marchi@efficios.com>
4545
4546         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
4547         method.
4548         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
4549         get_symtab, set_symtab>: New methods.
4550         <m_symtabs>: New field.
4551         (struct dwarf2_psymtab): Derive from partial_symtab.
4552         <readin_p, get_compunit_symtab>: Declare methods.
4553         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
4554         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
4555         New methods.
4556         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
4557         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
4558         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
4559         (dw2_symtab_iter_next, dw2_print_stats)
4560         (dw2_expand_symtabs_with_fullname)
4561         (dw2_expand_symtabs_matching_one)
4562         (dw_expand_symtabs_matching_file_matcher)
4563         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
4564         (dw2_debug_names_iterator::next)
4565         (dw2_debug_names_map_matching_symbols)
4566         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
4567         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
4568         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
4569         New methods.
4570         (get_compunit_symtab, process_full_comp_unit)
4571         (process_full_type_unit): Update.
4572         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
4573
4574 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4575
4576         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
4577         then introduce a new dwarf2_per_objfile type.
4578         <read_line_string>: Move to the new dwarf2_per_objfile type.
4579         <objfile>: Likewise.
4580         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
4581         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
4582         dwarf2_per_objfile->per_bfd.
4583         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
4584         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
4585         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
4586         (dwarf2_per_bfd::free_cached_comp_units): ... this.
4587         (dwarf2_has_info): Allocate dwarf2_per_bfd.
4588         (dwarf2_per_objfile::locate_sections): Rename to...
4589         (dwarf2_per_bfd::locate_sections): ... this.
4590         (dwarf2_per_objfile::get_cutu): Rename to...
4591         (dwarf2_per_bfd::get_cutu): ... this.
4592         (dwarf2_per_objfile::get_cu): Rename to...
4593         (dwarf2_per_bfd::get_cu): ... this.
4594         (dwarf2_per_objfile::get_tu): Rename to...
4595         (dwarf2_per_bfd::get_tu): ... this.
4596         (dwarf2_per_objfile::allocate_per_cu): Rename to...
4597         (dwarf2_per_bfd::allocate_per_cu): ... this.
4598         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
4599         (dwarf2_per_bfd::allocate_signatured_type): ... this.
4600         (get_gdb_index_contents_ftype): Change parameter from
4601         dwarf2_per_objfile to dwarf2_per_bfd.
4602         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
4603         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
4604
4605 2020-05-27  Tom Tromey  <tom@tromey.com>
4606             Simon Marchi  <simon.marchi@efficios.com>
4607
4608         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
4609         (allocate_piece_closure): Set "per_objfile" member.
4610         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
4611         (locexpr_describe_location, loclist_describe_location): Use new
4612         member.
4613         * dwarf2/read.c (read_call_site_scope)
4614         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
4615         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
4616         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
4617         handle_data_member_location): Set per_objfile member.
4618         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
4619         member.
4620         (struct dwarf2_loclist_baton) <per_objfile>: New member.
4621
4622 2020-05-27  Tom Tromey  <tom@tromey.com>
4623
4624         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
4625         allocate_signatured_type>: Declare new methods.
4626         <m_num_psymtabs>: New member.
4627         (struct dwarf2_per_cu_data) <index>: New member.
4628         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
4629         (dwarf2_per_objfile::allocate_signatured_type): New methods.
4630         (create_cu_from_index_list): Use allocate_per_cu.
4631         (create_signatured_type_table_from_index)
4632         (create_signatured_type_table_from_debug_names)
4633         (create_debug_type_hash_table, add_type_unit)
4634         (read_comp_units_from_section): Use allocate_signatured_type.
4635
4636 2020-05-27  Tom Tromey  <tom@tromey.com>
4637
4638         * psymtab.c (partial_map_expand_apply)
4639         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4640         (psym_lookup_global_symbol_language)
4641         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4642         (psym_print_stats, psym_expand_symtabs_for_function)
4643         (psym_map_symbol_filenames, psym_map_matching_symbols)
4644         (psym_expand_symtabs_matching)
4645         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4646         (maintenance_check_psymtabs): Update.
4647         * psympriv.h (struct partial_symtab) <readin_p,
4648         get_compunit_symtab>: Add objfile parameter.
4649         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
4650         Likewise.
4651         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
4652         get_compunit_symtab>: Likewise.
4653         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
4654
4655 2020-05-27  Tom Tromey  <tom@tromey.com>
4656
4657         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
4658         member.
4659         * dwarf2/read.c (delete_file_name_entry): Fix comment.
4660         (create_cu_from_index_list)
4661         (create_signatured_type_table_from_index)
4662         (create_signatured_type_table_from_debug_names)
4663         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
4664         (dwarf2_create_include_psymtab)
4665         (create_debug_type_hash_table, add_type_unit)
4666         (create_type_unit_group, read_comp_units_from_section)
4667         (dwarf2_compute_name, create_cus_hash_table)
4668         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4669         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
4670         obstack.
4671         (dw2_get_real_path): Likewise.  Change argument to
4672         dwarf2_per_objfile.
4673
4674 2020-05-27  Luis Machado  <luis.machado@linaro.org>
4675
4676         PR tdep/26000
4677         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
4678         for ldrd (immediate).
4679
4680 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4681
4682         * command.h: Add comment giving the name of class_tui.
4683         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
4684         create the fake command for the help for class_tui.
4685
4686 2020-05-26  Tom Tromey  <tromey@adacore.com>
4687
4688         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
4689         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
4690         (val_atr): New function.
4691         (value_val_atr): Use it.
4692         * ada-valprint.c (print_optional_low_bound): Change low bound
4693         handling for enums.
4694         (val_print_packed_array_elements): Don't call discrete_position.
4695         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
4696         discrete_position for enum types.
4697         * language.c (default_print_array_index): Change type.
4698         * language.h (struct language_defn) <la_print_array_index>: Add
4699         index_type parameter, change type of index_value.
4700         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
4701         (default_print_array_index): Update.
4702         * valprint.c (maybe_print_array_index): Don't call
4703         value_from_longest.  Update.
4704         (value_print_array_elements): Don't call discrete_position.
4705
4706 2020-05-26  Tom Tromey  <tromey@adacore.com>
4707
4708         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
4709         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
4710
4711 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
4712
4713         PR gdb/13519
4714         * avr-tdep.c (avr_integer_to_address): Return data or code
4715         address accordingly to the second 'type' argument of the
4716         function.
4717
4718 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
4719
4720         * infcmd.c, inferior.h: (construct_inferior_arguments):
4721         Moved function from here to gdbsupport/common-inferior.{h,cc}
4722
4723 2020-05-23  Tom Tromey  <tom@tromey.com>
4724
4725         Revert commit eca1f90c:
4726         * NEWS: Remove entry for completion styling.
4727         * completer.c (_rl_completion_prefix_display_length): Move
4728         declaration later.
4729         (gdb_fnprint): Revert.
4730         (gdb_display_match_list_1): Likewise.
4731         * cli/cli-style.c (completion_prefix_style)
4732         (completion_difference_style, completion_suffix_style): Remove.
4733         (_initialize_cli_style): Revert.
4734         * cli/cli-style.h (completion_prefix_style)
4735         (completion_difference_style, completion_suffix_style): Don't
4736         declare.
4737
4738 2020-05-24  Pedro Alves  <palves@redhat.com>
4739
4740         * symtab.c (completion_list_add_name): Return boolean indication
4741         of whether the symbol matched.
4742         (completion_list_add_symbol): Don't try to remove C++ aliases if
4743         the symbol didn't match in the first place.
4744         * symtab.h (completion_list_add_name): Return bool.
4745
4746 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
4747
4748         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
4749         type::field.
4750
4751 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
4752
4753         GDB 9.2 released.
4754
4755 2020-05-23  Tom Tromey  <tom@tromey.com>
4756
4757         * NEWS: Add entry for completion styling.
4758         * completer.c (_rl_completion_prefix_display_length): Move
4759         declaration earlier.
4760         (gdb_fnprint): Use completion_style.
4761         (gdb_display_match_list_1): Likewise.
4762         * cli/cli-style.c (completion_prefix_style)
4763         (completion_difference_style, completion_suffix_style): New
4764         globals.
4765         (_initialize_cli_style): Register new globals.
4766         * cli/cli-style.h (completion_prefix_style)
4767         (completion_difference_style, completion_suffix_style): Declare.
4768
4769 2020-05-23  Pedro Alves  <palves@redhat.com>
4770
4771         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
4772         (parse_escape): Use ISDIGIT instead of isdigit.
4773         (puts_debug): Use gdb_isprint instead of isprint.
4774         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
4775         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
4776         ISSPACE instead of isspace.
4777         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
4778         instead of isspace.
4779         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
4780         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
4781         instead of isxdigit and ISDIGIT instead of isdigit.
4782
4783 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4784
4785         * gdbtypes.h (struct type) <field>: New method.
4786         (TYPE_FIELDS): Remove, replace all uses with either type::fields
4787         or type::field.
4788
4789 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4790
4791         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
4792         (TYPE_FIELDS): Use type::fields.  Change all call sites that
4793         modify the propery to use type::set_fields instead.
4794
4795 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4796
4797         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
4798         type::num_fields instead.
4799
4800 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4801
4802         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
4803         methods.
4804         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
4805         that modify the number of fields to use type::set_num_fields
4806         instead.
4807
4808 2020-05-22  Tom Tromey  <tromey@adacore.com>
4809
4810         * compile/compile-object-load.h (munmap_list_free): Don't
4811         declare.
4812
4813 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * annotate.c (annotate_source_line): Update return type, add call
4816         to update current symtab and line.
4817         * annotate.h (annotate_source_line): Update return type, and
4818         extend header comment.
4819         * source.c (info_line_command): Check annotation_level before
4820         calling annotate_source_line.
4821         * stack.c (print_frame_info): If calling annotate_source_line
4822         returns true, then don't print any other source line information.
4823
4824 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
4825
4826         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
4827
4828 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
4829
4830         * coffread.c (patch_type): Remove NULL check before xfree.
4831         * corefile.c (set_gnutarget): Likewise.
4832         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
4833         * exec.c (build_section_table): Likewise.
4834         * remote.c (remote_target::pass_signals): Likewise.
4835         * utils.c (n_spaces): Likewise.
4836         * cli/cli-script.c (document_command): Likewise.
4837         * i386-windows-tdep.c (core_process_module_section): Likewise.
4838         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
4839
4840 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
4841
4842         * symfile.c (reread_symbols): Clear objfile's section_offsets
4843         vector and section indices, re-compute them by calling
4844         sym_offsets.
4845
4846 2020-05-20  Tom Tromey  <tromey@adacore.com>
4847
4848         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
4849         (desc_one_bound, desc_index_type): Compute field name.
4850
4851 2020-05-20  Tom de Vries  <tdevries@suse.de>
4852
4853         PR symtab/25833
4854         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
4855
4856 2020-05-20  Alan Modra  <amodra@gmail.com>
4857
4858         PR 25993
4859         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
4860         bfd_set_filename.
4861         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
4862         passed to bfd_set_filename.
4863         * symfile-mem.c (add_vsyscall_page): Likewise for string
4864         passed to symbol_file_add_from_memory.
4865         (symbol_file_add_from_memory): Make name param a const char* and
4866         don't strdup.
4867
4868 2020-05-20  Alan Modra  <amodra@gmail.com>
4869
4870         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
4871         rather than accessing bfd->filename directly.
4872         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
4873         and use bfd_section_name.
4874         * dwarf2/frame.c (decode_frame_entry): Likewise.
4875         * exec.c (exec_set_section_address): Likewise.
4876         * solib-aix.c (solib_aix_bfd_open): Likewise.
4877         * stap-probe.c (get_stap_base_address): Likewise.
4878         * symfile.c (reread_symbols): Likewise.
4879
4880 2020-05-19  Tom Tromey  <tromey@adacore.com>
4881
4882         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
4883
4884 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4885
4886         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
4887
4888 2020-05-19  Pedro Alves  <palves@redhat.com>
4889
4890         * NEWS (set exec-file-mismatch): Adjust entry.
4891         * exec.c: Include "build-id.h".
4892         (validate_exec_file): Try to match build IDs instead of filenames.
4893         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
4894         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
4895         and pass down 'warn_if_slow'.
4896         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
4897         gdb_bfd_open_closure to pass it down.
4898         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
4899
4900 2020-05-19  Pedro Alves  <palves@redhat.com>
4901
4902         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
4903         * target.c (target_fileio_open_1): Rename to target_fileio_open
4904         and make extern.  Use bool.
4905         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
4906         (target_fileio_read_alloc_1): Adjust.
4907         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
4908         (target_fileio_open_warn_if_slow): Delete declaration.
4909
4910 2020-05-19  Pedro Alves  <palves@redhat.com>
4911
4912         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
4913         Adjust all callers.
4914
4915 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
4916
4917         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
4918         whether disp is negative.
4919
4920 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4921
4922         * symfile.h (struct symfile_segment_data)
4923         <~symfile_segment_data>: Remove.
4924         <segment_info>: Change to std::vector.
4925         * symfile.c (default_symfile_segments): Update.
4926         * elfread.c (elf_symfile_segments): Update.
4927
4928 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4929
4930         * symfile.h (struct symfile_segment_data) <struct segment>: New.
4931         <segments>: New.
4932         <segment_bases, segment_sizes>: Remove.
4933         * symfile.c (default_symfile_segments): Update.
4934         * elfread.c (elf_symfile_segments): Update.
4935         * remote.c (remote_target::get_offsets): Update.
4936         * solib-target.c (solib_target_relocate_section_addresses):
4937         Update.
4938
4939 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4940
4941         * symfile.h (struct symfile_segment_data): Initialize fields.
4942         <~symfile_segment_data>: Add.
4943         (symfile_segment_data_up): New.
4944         (struct sym_fns) <sym_segments>: Return a
4945         symfile_segment_data_up.
4946         (default_symfile_segments): Return a symfile_segment_data_up.
4947         (free_symfile_segment_data): Remove.
4948         (get_symfile_segment_data): Return a symfile_segment_data_up.
4949         * symfile.c (default_symfile_segments): Likewise.
4950         (get_symfile_segment_data): Likewise.
4951         (free_symfile_segment_data): Remove.
4952         (symfile_find_segment_sections): Update.
4953         * elfread.c (elf_symfile_segments): Return a
4954         symfile_segment_data_up.
4955         * remote.c (remote_target::get_offsets): Update.
4956         * solib-target.c (solib_target_relocate_section_addresses):
4957         Update.
4958         * symfile-debug.c (debug_sym_segments): Return a
4959         symfile_segment_data_up.
4960
4961 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4962
4963         PR build/25981
4964         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
4965         Hardcode register numbers.
4966
4967         PR build/25981
4968         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
4969         procfs_find_LDT_entry): Remove.
4970         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
4971         procfs_find_LDT_entry): Remove.
4972         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
4973         Remove.
4974
4975 2020-05-17  Pedro Alves  <palves@redhat.com>
4976             Andrew Burgess  <andrew.burgess@embecosm.com>
4977             Keno Fischer  <keno@juliacomputing.com>
4978
4979         PR gdb/25741
4980         * breakpoint.c (build_target_condition_list): Update comments.
4981         (build_target_command_list): Update comments and skip matching
4982         locations.
4983         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
4984         a separate function.  Simplify "set breakpoint auto-hw off"
4985         handling.
4986         (insert_breakpoints): Update comment.
4987         (tracepoint_locations_match): New parameter.  For breakpoints,
4988         compare location types too, if the caller wants to.
4989         (handle_automatic_hardware_breakpoints): New functions.
4990         (bp_location_is_less_than): Also sort by location type and
4991         hardware breakpoint length.
4992         (update_global_location_list): Handle "set breakpoint auto-hw on"
4993         here.
4994         (update_breakpoint_locations): Ask breakpoint_locations_match to
4995         ignore location types.
4996
4997 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4998
4999         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
5000         type::name instead.
5001
5002 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
5003
5004         * gdbtypes.h (struct type) <name, set_name>: New methods.
5005         (TYPE_CODE): Use type::name.  Change all call sites used to set
5006         the name to use type::set_name instead.
5007
5008 2020-05-16  Tom Tromey  <tom@tromey.com>
5009
5010         * top.c (quit_force): Update.
5011         * infrun.c (handle_no_resumed): Update.
5012         * top.h (all_uis): New function.
5013         (ALL_UIS): Remove.
5014
5015 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
5016
5017         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
5018
5019 2020-05-16  Pedro Alves  <palves@redhat.com>
5020
5021         * ia64-linux-nat.c
5022         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
5023         Declare method.
5024         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
5025
5026 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
5027
5028         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
5029         (sparc64_adi_info): Likewise.
5030
5031 2020-05-15  Tom Tromey  <tom@tromey.com>
5032
5033         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
5034         block_objfile.
5035         (lookup_objfile_from_block): Remove.
5036         (lookup_symbol_in_block, lookup_symbol_in_static_block)
5037         (lookup_global_symbol): Use block_objfile.
5038         * symtab.h (lookup_objfile_from_block): Don't declare.
5039         * printcmd.c (clear_dangling_display_expressions): Use
5040         block_objfile.
5041         * parse.c (operator_check_standard): Use block_objfile.
5042
5043 2020-05-15  Tom Tromey  <tom@tromey.com>
5044
5045         * language.c (language_alloc_type_symbol): Set
5046         SYMBOL_SECTION.
5047         * symtab.c (initialize_objfile_symbol): Remove.
5048         (allocate_symbol): Remove.
5049         (allocate_template_symbol): Remove.
5050         * dwarf2/read.c (fixup_go_packaging): Use "new".
5051         (new_symbol): Use "new".
5052         (read_variable): Don't call initialize_objfile_symbol.  Use
5053         "new".
5054         (read_func_scope): Use "new".
5055         * xcoffread.c (process_xcoff_symbol): Don't call
5056         initialize_objfile_symbol.
5057         (SYMBOL_DUP): Remove.
5058         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
5059         "new".
5060         * symtab.h (allocate_symbol, initialize_objfile_symbol)
5061         (allocate_template_symbol): Don't declare.
5062         (struct symbol): Add copy constructor.  Change defaults.
5063         * jit.c (finalize_symtab): Use "new".
5064         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
5065         Use "new".
5066         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
5067         (common_block_end): Use "new".
5068         * mdebugread.c (parse_symbol): Use "new".
5069         (new_symbol): Likewise.
5070
5071 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5072
5073         * NEWS: Mention changes to help and apropos.
5074
5075 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5076
5077         * command.h (enum command_class): Improve comments, document
5078         that class_alias is for user-defined aliases, give the class
5079         name for each class, remove unused class_xdb.
5080         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
5081         * breakpoint.c (_initialize_breakpoint): Replace class_alias
5082         by a precise class.
5083         * infcmd.c (_initialize_infcmd): Likewise.
5084         * reverse.c (_initialize_reverse): Likewise.
5085         * stack.c (_initialize_stack): Likewise.
5086         * symfile.c (_initialize_symfile): Likewise.
5087         * tracepoint.c (_initialize_tracepoint): Likewise.
5088
5089 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5090
5091         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
5092         when their aliased command is traversed.
5093         (help_cmd): Add fput_command_names_styled call to
5094         output command name and aliases when command has an alias.
5095
5096 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5097
5098         * cli/cli-decode.h (help_cmd_list): Remove declaration.
5099         * cli/cli-decode.c (help_cmd_list): Declare as static,
5100         remove prefix argument, use bool for recurse arg, rework to show the aliases of
5101         a command together with the command.
5102         (fput_command_name_styled, fput_command_names_styled): New functions.
5103         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
5104         fput_command_name_styled.
5105         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
5106         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
5107
5108 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5109
5110         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
5111         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
5112         * command.h (cmd_show_list): Likewise.
5113         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
5114         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
5115
5116 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5117
5118         * unittests/command-def-selftests.c (traverse_command_structure):
5119         Verify all commands of a list have the same prefix command and
5120         that only the top cmdlist commands have a null prefix.
5121
5122 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5123
5124         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
5125         as prefix, not one of its aliases.
5126         (set_cmd_prefix): Remove.
5127         (do_add_cmd): Centralize the setting of the prefix of a command, when
5128         command is defined after its full chain of prefix commands.
5129         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
5130         (add_setshow_cmd_full): Likewise.
5131         (update_prefix_field_of_prefixed_commands): New function.
5132         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
5133         update_prefix_field_of_prefixed_commands.
5134         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
5135         addresses of remote_set_cmdlist and remote_show_cmdlist given
5136         as argument, not the address of an argument.
5137         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
5138         * gdb/remote.c (_initialize_remote): Likewise.
5139
5140 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5141
5142         * cli/cli-cmds.c (alias_command): Check for an existing alias
5143         using lookup_cmd_composition, as valid_command_p is too strict
5144         and forbids aliases that are the prefix of an existing alias
5145         or command.
5146         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
5147         command is properly recognised as a valid command.
5148
5149 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5150
5151         * unittests/help-doc-selftests.c: Rename to
5152         unittests/command-def-selftests.c
5153         * unittests/command-def-selftests.c (help_doc_tests): Update some
5154         comments.
5155         (command_structure_tests, traverse_command_structure): New namespace
5156         and function.
5157         (command_structure_invariants_tests): New function.
5158         (_initialize_command_def_selftests) Renamed from
5159         _initialize_help_doc_selftests, register command_structure_invariants
5160         selftest.
5161
5162 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5163
5164         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
5165         an alias of 'show'.
5166
5167 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
5168
5169         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
5170         ada_is_fixed_point_type.  Update all callers.
5171         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
5172         all callers.
5173         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
5174         Update all callers.
5175         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
5176         print_fixed_point_type.  Update all callers.
5177         * ada-valprint.c (ada_value_print_num): Replace call to
5178         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
5179
5180 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
5181
5182         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
5183         processors.
5184         (cpu_supports_bts): Add CV_AMD case.
5185
5186 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
5187             Simon Marchi  <simon.marchi@efficios.com>
5188
5189         * infrun.c (stop_all_threads): Collect multiple wait events at
5190         each pass.
5191
5192 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
5193
5194         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
5195         type::code instead.
5196
5197 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
5198
5199         * gdbtypes.h (struct type) <code, set_code>: New methods.
5200         (TYPE_CODE): Use type::code.  Change all call sites used to set
5201         the code to use type::set_code instead.
5202
5203 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5204             Tom de Vries  <tdevries@suse.de>
5205             Pedro Alves  <palves@redhat.com>
5206
5207         PR threads/25478
5208         * infrun.c (stop_all_threads): Do NOT ignore
5209         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
5210         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
5211         received.
5212         (handle_no_resumed): Remove code handling a live inferior with no
5213         threads.
5214         * remote.c (has_single_non_exited_thread): New.
5215         (remote_target::update_thread_list): Do not delete a thread if is
5216         the last thread of the process.
5217         * thread.c (thread_select): Call delete_exited_threads instead of
5218         prune_threads.
5219
5220 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5221
5222         * infrun.c (stop_all_threads): Enable/disable thread events of all
5223         targets.  Move a debug message denoting the end of the function
5224         into the SCOPED_EXIT block.
5225
5226 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5227
5228         * process-stratum-target.h: Include <set>.
5229         (all_non_exited_process_targets, switch_to_target_no_thread): New
5230         function declarations.
5231         * process-stratum-target.c (all_non_exited_process_targets)
5232         (switch_to_target_no_thread): New function implementations.
5233
5234 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5235
5236         * infrun.c (handle_inferior_event): Extract out a piece of code
5237         into...
5238         (mark_non_executing_threads): ...this new function.
5239
5240 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5241
5242         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
5243         use.
5244
5245 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5246
5247         * regcache.c (regcache_read_pc_protected): New function
5248         implementation that returns 0 if the PC cannot read via
5249         'regcache_read_pc'.
5250         * infrun.c (proceed): Call 'regcache_read_pc_protected'
5251         instead of 'regcache_read_pc'.
5252         (keep_going_pass_signal): Ditto.
5253
5254 2020-05-13  Tom Tromey  <tromey@adacore.com>
5255
5256         * ada-lang.c (align_value): Remove.
5257         (ada_template_to_fixed_record_type_1): Use align_up.
5258
5259 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5260
5261         * async-event.c: Update the copyright year.
5262         * async-event.h: Update the copyright year.
5263
5264 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
5265
5266         * objfiles.h (is_addr_in_objfile,
5267         shared_objfile_contains_address_p): Return bool.
5268         * objfile.c (is_addr_in_objfile,
5269         shared_objfile_contains_address_p): Return bool.
5270
5271 2020-05-11  Tom Tromey  <tromey@adacore.com>
5272
5273         * cli/cli-cmds.c (info_command): Restore.
5274         (_initialize_cli_cmds): Use add_prefix_command for "info".
5275         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
5276
5277 2020-05-11  Tom Tromey  <tromey@adacore.com>
5278
5279         * ada-lang.c (ada_value_primitive_field): Now public.
5280         * ada-lang.h (ada_value_primitive_field): Declare.
5281         * ada-valprint.c (print_field_values): Use
5282         ada_value_primitive_field for wrapper fields.
5283
5284 2020-05-11  Tom de Vries  <tdevries@suse.de>
5285
5286         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
5287         MODULE_DOMAIN.
5288
5289 2020-05-11  Tom de Vries  <tdevries@suse.de>
5290
5291         PR symtab/25941
5292         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
5293         with length 0, if not gdb-produced.
5294         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
5295
5296 2020-05-09  Tom de Vries  <tdevries@suse.de>
5297
5298         PR gdb/25955
5299         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
5300         calculation.
5301
5302 2020-05-09  Tom Tromey  <tom@tromey.com>
5303
5304         * top.c (server_command): Now bool.
5305         * top.h (server_command): Now bool.
5306
5307 2020-05-08  Tom Tromey  <tromey@adacore.com>
5308
5309         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
5310         already being processed.
5311
5312 2020-05-08  Tom Tromey  <tom@tromey.com>
5313
5314         * printcmd.c (struct display) <next>: Remove.
5315         <display>: New constructor.
5316         <exp_string>: Now a std::string.
5317         <enabled_p>: Now a bool.
5318         (display_number): Move definition earlier.
5319         (displays): Rename from display_chain.  Now a std::vector.
5320         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
5321         (display_command): Update.
5322         (do_one_display, disable_display)
5323         (enable_disable_display_command, do_enable_disable_display):
5324         Update.
5325         (free_display): Remove.
5326         (clear_displays): Rewrite.
5327         (delete_display): Update.
5328         (map_display_numbers): Use function_view.  Remove "data"
5329         parameter.  Update.
5330         (do_delete_display): Remove.
5331         (undisplay_command): Update.
5332         (do_one_display, do_displays, disable_display)
5333         (info_display_command): Update.
5334         (do_enable_disable_display): Remove.
5335         (enable_disable_display_command)
5336         (clear_dangling_display_expressions): Update.
5337
5338 2020-05-08  Tom Tromey  <tom@tromey.com>
5339
5340         * symtab.c (set_symbol_cache_size)
5341         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
5342         (maintenance_print_symbol_cache_statistics): Update.
5343         * symmisc.c (print_symbol_bcache_statistics)
5344         (print_objfile_statistics, maintenance_print_objfiles)
5345         (maintenance_info_symtabs, maintenance_check_symtabs)
5346         (maintenance_expand_symtabs, maintenance_info_line_tables):
5347         Update.
5348         * symfile-debug.c (set_debug_symfile): Update.
5349         * source.c (forget_cached_source_info): Update.
5350         * python/python.c (gdbpy_progspaces): Update.
5351         * psymtab.c (maintenance_info_psymtabs): Update.
5352         * probe.c (parse_probes): Update.
5353         * linespec.c (iterate_over_all_matching_symtabs)
5354         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
5355         * guile/scm-progspace.c (gdbscm_progspaces): Update.
5356         * exec.c (exec_target::close): Update.
5357         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
5358         * breakpoint.c (print_one_breakpoint_location)
5359         (create_longjmp_master_breakpoint)
5360         (create_std_terminate_master_breakpoint): Update.
5361         * progspace.c (program_spaces): Now a std::vector.
5362         (maybe_new_address_space): Update.
5363         (add_program_space): Remove.
5364         (program_space::program_space): Update.
5365         (remove_program_space): Update.
5366         (number_of_program_spaces): Remove.
5367         (print_program_space, update_address_spaces): Update.
5368         * progspace.h (program_spaces): Change type.
5369         (ALL_PSPACES): Remove.
5370         (number_of_program_spaces): Don't declare.
5371         (struct program_space) <next>: Remove.
5372
5373 2020-05-08  Tom Tromey  <tom@tromey.com>
5374
5375         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
5376         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
5377         (enable_break): Update.
5378         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
5379         (frv_fdpic_find_canonical_descriptor): Update.
5380         (frv_fetch_objfile_link_map): Update.
5381         * progspace.c (program_space::free_all_objfiles): Update.
5382         (program_space::solibs): New method.
5383         * progspace.h (struct program_space) <solibs>: New method.
5384         * solist.h (master_so_list): Don't declare.
5385         (ALL_SO_LIBS): Remove.
5386         * solib.h (so_list_head): Remove.
5387         (update_solib_list): Update comment.
5388         * solib.c (master_so_list): Remove.
5389         (solib_used, update_solib_list, solib_add)
5390         (info_sharedlibrary_command, clear_solib)
5391         (reload_shared_libraries_1, remove_user_added_objfile): Update.
5392
5393 2020-05-08  Tom Tromey  <tom@tromey.com>
5394
5395         * extension.c (extension_languages): Now a std::array.
5396         (ALL_EXTENSION_LANGUAGES): Remove.
5397         (get_ext_lang_defn, get_ext_lang_of_file)
5398         (eval_ext_lang_from_control_command): Update.
5399         (finish_ext_lang_initialization)
5400         (auto_load_ext_lang_scripts_for_objfile)
5401         (ext_lang_type_printers::ext_lang_type_printers)
5402         (apply_ext_lang_type_printers)
5403         (ext_lang_type_printers::~ext_lang_type_printers)
5404         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
5405         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
5406         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
5407         (get_matching_xmethod_workers, ext_lang_colorize)
5408         (ext_lang_before_prompt): Update.
5409         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
5410
5411 2020-05-08  Tom Tromey  <tom@tromey.com>
5412
5413         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
5414         overload.
5415         <swap_string, m_string>: Remove.
5416         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
5417         Update.
5418         * stabsread.c (define_symbol, read_type): Update.
5419         * linespec.c (find_linespec_symbols): Update.
5420         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
5421         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
5422         * dbxread.c (read_dbx_symtab): Update.
5423         * cp-support.h (cp_canonicalize_string_full)
5424         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
5425         Return unique_xmalloc_ptr.
5426         * cp-support.c (inspect_type): Update.
5427         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
5428         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
5429         Likewise.
5430         * c-typeprint.c (print_name_maybe_canonical): Update.
5431         * break-catch-throw.c (check_status_exception_catchpoint):
5432         Update.
5433
5434 2020-05-08  Tom de Vries  <tdevries@suse.de>
5435
5436         * infrun.c (follow_fork): Copy current_line and current_symtab to
5437         child thread.
5438
5439 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5440
5441         * async-event.c (struct async_signal_handler, struct
5442         async_event_handler): Reformat, remove typedef.
5443
5444 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5445
5446         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
5447         access thistype->main_type->dyn_prop_list directly.
5448
5449 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5450
5451         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
5452         (remove_dyn_prop): Remove.  Update all users to use
5453         type::remove_dyn_prop.
5454         * gdbtypes.c (remove_dyn_prop): Rename to...
5455         (type::remove_dyn_prop): ... this.
5456
5457 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
5458
5459         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
5460         (add_dyn_prop): Remove.  Update all users to use
5461         type::add_dyn_prop.
5462         * gdbtypes.c (add_dyn_prop): Rename to...
5463         (type::add_dyn_prop): ... this.
5464
5465 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5466
5467         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
5468         (get_dyn_prop): Remove.  Update all users to use
5469         type::dyn_prop.
5470         * gdbtypes.c (get_dyn_prop): Rename to...
5471         (type::dyn_prop): ... this.
5472
5473 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
5474
5475         * gdbtypes.h (struct main_type) <flag_static>: Remove.
5476
5477 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
5478
5479         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
5480         instruction, skip it if it's there.
5481
5482 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
5483
5484         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
5485
5486 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
5487
5488         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
5489         * gdbtypes.c (recursive_dump_type): Remove use of
5490         TYPE_INCOMPLETE.
5491
5492 2020-05-03  Tom Tromey  <tom@tromey.com>
5493
5494         * breakpoint.c (catch_command, tcatch_command): Remove.
5495         (_initialize_breakpoint): Use add_basic_prefix_cmd,
5496         add_show_prefix_cmd.
5497         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
5498         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
5499         Remove.
5500         (add_internal_problem_command): Use add_basic_prefix_cmd,
5501         add_show_prefix_cmd.
5502         * mips-tdep.c (set_mipsfpu_command): Remove.
5503         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
5504         * dwarf2/index-cache.c (set_index_cache_command): Remove.
5505         (_initialize_index_cache): Use add_basic_prefix_cmd.
5506         * memattr.c (dummy_cmd): Remove.
5507         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
5508         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
5509         (_initialize_tui_win): Use add_basic_prefix_cmd,
5510         add_show_prefix_cmd.
5511         * cli/cli-logging.c (set_logging_command): Remove.
5512         (_initialize_cli_logging): Use add_basic_prefix_cmd,
5513         add_show_prefix_cmd.
5514         (show_logging_command): Remove.
5515         * target.c (target_command): Remove.
5516         (add_target): Use add_basic_prefix_cmd.
5517
5518 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
5519
5520         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
5521
5522 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5523
5524         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
5525         info_command.
5526
5527 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
5528
5529         * nbsd-nat.c (nbsd_enable_proc_events)
5530         (nbsd_nat_target::post_startup_inferior): Add.
5531         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
5532         (nbsd_nat_target::update_thread_list): Rewrite.
5533         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
5534         "PTRACE_LWP_CREATE".
5535         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
5536
5537 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5538
5539         * stack.c (_initialize_stack): Remove duplicated creation
5540         of "frame" command and "f" alias.
5541
5542 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
5543
5544         PR gdb/18706
5545         * gdbtypes.c (check_typedef): Calculate size of array of
5546         stubbed type.
5547
5548 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
5549
5550         PR gdb/15559
5551         * i386-tdep.c (i386_push_dummy_call): Call
5552         i386_thiscall_push_dummy_call.
5553         (i386_thiscall_push_dummy_call): New function.
5554         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
5555         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
5556         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
5557
5558 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5559
5560         * gdbarch.sh (do_read): Add shellcheck disable directive for
5561         warning SC2162.
5562
5563 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5564
5565         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
5566         "referenced but not assigned" warning.
5567
5568 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5569
5570         * gdbarch.sh: Remove code that sets fallbackdefault.
5571
5572 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5573
5574         * gdbarch.sh: Use shell operators && and || instead of
5575         -a and -o.
5576
5577 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5578
5579         * gdbarch.sh: Use $(...) instead of `...`.
5580
5581 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5582
5583         * gdbarch.sh: Use double quotes around variables.
5584
5585 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5586
5587         * gdbarch.sh: Use %s with printf, instead of variables in the
5588         format string.
5589
5590 2020-04-29  Tom Tromey  <tromey@adacore.com>
5591
5592         PR ada/25875:
5593         * dwarf2/read.c (update_enumeration_type_from_children): Compute
5594         type fields here.
5595         (read_enumeration_type): Call
5596         update_enumeration_type_from_children later.  Update comments.
5597         (process_enumeration_scope): Don't create type fields.
5598
5599 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
5600
5601         * nbsd-tdep.c: Include "xml-syscall.h".
5602         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
5603
5604 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
5605
5606         * nbsd-nat.c: Include "sys/wait.h".
5607         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
5608         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
5609         (nbsd_nat_target::remove_exec_catchpoint)
5610         (nbsd_nat_target::set_syscall_catchpoint): Add.
5611         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
5612         (nbsd_nat_target::insert_exec_catchpoint)
5613         (nbsd_nat_target::remove_exec_catchpoint)
5614         (nbsd_nat_target::set_syscall_catchpoint): Add.
5615         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
5616         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
5617         `nbsd_get_syscall_number'.
5618
5619 2020-04-29  Tom Tromey  <tom@tromey.com>
5620
5621         * stack.c (print_block_frame_labels): Remove.
5622
5623 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
5624
5625         PR gdb/17320
5626         * ada-valprint.c (val_print_packed_array_elements): Move array
5627         end bracket to new line.
5628         (ada_val_print_string): Remove extra spaces before first array
5629         element.
5630         * c-valprint.c (c_value_print_array): Likewise.
5631         * m2-valprint.c (m2_print_array_contents): Likewise.
5632         (m2_value_print_inner): Likewise.
5633         * p-valprint.c (pascal_value_print_inner): Likewise.
5634         * valprint.c (generic_val_print_array): Likewise.
5635         (value_print_array_elements): Move first array element and array
5636         end bracket to new line.
5637
5638 2020-04-29  Tom de Vries  <tdevries@suse.de>
5639
5640         PR symtab/25889
5641         * linespec.c (find_method): Fix ix calculation.
5642
5643 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
5644
5645         * syscalls/update-netbsd.sh: New file.
5646         * syscalls/netbsd.xml: Regenerate.
5647         * data-directory/Makefile.in: Register `netbsd.xml' in
5648         `SYSCALLS_FILES'.
5649
5650 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
5651
5652         * syscalls/update-freebsd.sh: Add double quotes.
5653
5654 2020-04-28  Tom Tromey  <tom@tromey.com>
5655
5656         * NEWS: Update.
5657         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
5658         (cmdpy_init): Allow class_tui.
5659
5660 2020-04-28 Mark Williams <mark@myosotissp.com>
5661
5662         PR gdb/24480
5663         * dwarf2read.c: Add missing assingments to list_in_scope when
5664         start_symtab was already called.
5665
5666 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
5667
5668         PR gdb/25881
5669         * dwarf2/read.c (offset_map_type): Use
5670         gdb:hash_enum<sect_offset> as hash function.
5671
5672 2020-04-28  Tom de Vries  <tdevries@suse.de>
5673
5674         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
5675         with DW_AT_signature.
5676
5677 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
5678
5679         * configure.ac: Remove check for fs_base/gs_base in
5680         user_regs_struct.
5681         * configure: Re-generate.
5682         * config.in: Re-generate.
5683         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
5684         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
5685         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
5686
5687 2020-04-27  Luis Machado  <luis.machado@linaro.org>
5688
5689         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
5690         problematic inline frame unwinding situation.
5691         * frame.c (frame_id_computed_p): New function.
5692         * frame.h (frame_id_computed_p): New prototype.
5693
5694 2020-04-26  Tom Tromey  <tom@tromey.com>
5695
5696         * command.h (enum command_class) <class_pseudo>: Remove.
5697
5698 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5699
5700         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
5701         and whitespace.
5702
5703 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
5704
5705         * inf-ptrace.c (inf_ptrace_target::wait): Remove
5706         `PT_GET_PROCESS_STATE' block.
5707
5708 2020-04-24  Tom Tromey  <tom@tromey.com>
5709
5710         * symtab.h (symbol_get_demangled_name): Don't declare.
5711         * symtab.c (symbol_get_demangled_name): Remove.
5712         (general_symbol_info::natural_name)
5713         (general_symbol_info::demangled_name): Update.
5714
5715 2020-04-24  Tom Tromey  <tom@tromey.com>
5716
5717         PR rust/25025:
5718         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
5719
5720 2020-04-24  Tom Tromey  <tom@tromey.com>
5721
5722         PR symtab/12707:
5723         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
5724         exists.
5725         (new_symbol): Likewise.
5726         * compile/compile-object-load.c (get_out_value_type): Use
5727         symbol_matches_search_name.
5728
5729 2020-04-24  Tom Tromey  <tom@tromey.com>
5730
5731         * dwarf2/read.c (add_partial_symbol): Do not call
5732         compute_and_set_names.
5733
5734 2020-04-24  Tom Tromey  <tom@tromey.com>
5735
5736         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
5737         overload.
5738
5739 2020-04-24  Tom Tromey  <tom@tromey.com>
5740
5741         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
5742         (add_psymbol_to_list): New overload.  Make old overload call new
5743         one.
5744         * psympriv.h (add_psymbol_to_list): New overload.
5745
5746 2020-04-24  Tom Tromey  <tom@tromey.com>
5747
5748         * dwarf2/read.c (partial_die_info::read) <case
5749         DW_AT_linkage_name>: Use value_as_string.
5750         (dwarf2_string_attr): Use value_as_string.
5751         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
5752         method.
5753         * dwarf2/attribute.c (attribute::value_as_string): New method.
5754
5755 2020-04-24  Tom Tromey  <tom@tromey.com>
5756
5757         * symtab.c (general_symbol_info::natural_name)
5758         (general_symbol_info::demangled_name): Check for language_rust.
5759
5760 2020-04-24  Tom Tromey  <tom@tromey.com>
5761
5762         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
5763         (dwarf2_physname): ... from here.
5764         (partial_die_info::read): Add Rust "{" hack.
5765
5766 2020-04-24  Tom Tromey  <tom@tromey.com>
5767
5768         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
5769         method.
5770         (symbol_set_demangled_name): Don't declare.
5771         * symtab.c (general_symbol_info::set_demangled_name): Rename from
5772         symbol_set_demangled_name.
5773         (general_symbol_info::set_language)
5774         (general_symbol_info::compute_and_set_names): Update.
5775         * minsyms.c (minimal_symbol_reader::install): Update.
5776         * dwarf2/read.c (new_symbol): Update.
5777
5778 2020-04-24  Tom Tromey  <tromey@adacore.com>
5779
5780         PR python/23662:
5781         * python/py-type.c (convert_field): Handle
5782         FIELD_LOC_KIND_DWARF_BLOCK.
5783         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
5784         (typy_get_dynamic): Nw function.
5785         (type_object_getset): Add "dynamic".
5786         * NEWS: Add entry.
5787
5788 2020-04-24  Tom Tromey  <tromey@adacore.com>
5789
5790         * ada-typeprint.c (print_choices, print_variant_part)
5791         (print_record_field_types_dynamic): New functions.
5792         (print_record_field_types): Use print_record_field_types_dynamic.
5793
5794 2020-04-24  Tom Tromey  <tromey@adacore.com>
5795
5796         * dwarf2/read.c (handle_data_member_location): New overload.
5797         (dwarf2_add_field): Use it.
5798         (decode_locdesc): Add "computed" parameter.  Update comment.
5799         * gdbtypes.c (is_dynamic_type_internal): Also look for
5800         FIELD_LOC_KIND_DWARF_BLOCK.
5801         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
5802         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
5803         virtual base classes.
5804         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
5805         FIELD_LOC_KIND_DWARF_BLOCK.
5806
5807 2020-04-24  Tom Tromey  <tromey@adacore.com>
5808
5809         * dwarf2/read.c (read_structure_type): Handle dynamic length.
5810         * gdbtypes.c (is_dynamic_type_internal): Check
5811         TYPE_HAS_DYNAMIC_LENGTH.
5812         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
5813         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
5814         New macros.
5815         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
5816         constant.
5817
5818 2020-04-24  Tom Tromey  <tromey@adacore.com>
5819
5820         * dwarf2/read.c (struct variant_field): Rewrite.
5821         (struct variant_part_builder): New.
5822         (struct nextfield): Remove "variant" field.  Add "offset".
5823         (struct field_info): Add "current_variant_part" and
5824         "variant_parts".
5825         (alloc_discriminant_info): Remove.
5826         (alloc_rust_variant): New function.
5827         (quirk_rust_enum): Update.
5828         (dwarf2_add_field): Set "offset" member.  Don't handle
5829         DW_TAG_variant_part.
5830         (offset_map_type): New typedef.
5831         (convert_variant_range, create_one_variant)
5832         (create_one_variant_part, create_variant_parts)
5833         (add_variant_property): New functions.
5834         (dwarf2_attach_fields_to_type): Call add_variant_property.
5835         (read_structure_type): Don't handle DW_TAG_variant_part.
5836         (handle_variant_part, handle_variant): New functions.
5837         (handle_struct_member_die): Use them.
5838         (process_structure_scope): Don't handle variant parts.
5839         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
5840         (struct discriminant_info): Remove.
5841         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
5842         (struct main_type) <flag_discriminated_union>: Remove.
5843         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
5844         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
5845         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
5846         Update.
5847         * valops.c (value_union_variant): Remove.
5848         * value.h (value_union_variant): Don't declare.
5849
5850 2020-04-24  Tom Tromey  <tromey@adacore.com>
5851
5852         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
5853         (ada_value_primitive_packed_val): Update.
5854         * ada-valprint.c (ada_value_print_1): Update.
5855         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
5856         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
5857         just an address.  Use evaluate_for_locexpr_baton.
5858         (dwarf2_evaluate_property): Update.
5859         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
5860         array_view.
5861         * findvar.c (default_read_var_value): Update.
5862         * gdbtypes.c (compute_variant_fields_inner)
5863         (resolve_dynamic_type_internal): Update.
5864         (resolve_dynamic_type): Change type of valaddr parameter.
5865         * gdbtypes.h (resolve_dynamic_type): Update.
5866         * valarith.c (value_subscripted_rvalue): Update.
5867         * value.c (value_from_contents_and_address): Update.
5868
5869 2020-04-24  Tom Tromey  <tromey@adacore.com>
5870
5871         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
5872         "push_initial_value" parameter.
5873         (dwarf2_evaluate_property): Likewise.
5874         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
5875
5876 2020-04-24  Tom Tromey  <tromey@adacore.com>
5877
5878         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
5879         (variant::matches, compute_variant_fields_recurse)
5880         (compute_variant_fields_inner, compute_variant_fields): New
5881         functions.
5882         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
5883         Use resolved_type after type is made.
5884         (operator==): Add new cases.
5885         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
5886         (struct discriminant_range, struct variant, struct variant_part):
5887         New.
5888         (union dynamic_prop_data) <variant_parts, original_type>: New
5889         members.
5890         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
5891         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
5892         constants.
5893         * value.c (unpack_bits_as_long): Now public.
5894         * value.h (unpack_bits_as_long): Declare.
5895
5896 2020-04-24  Tom Tromey  <tromey@adacore.com>
5897
5898         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
5899         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
5900
5901 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
5902
5903         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
5904
5905 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
5906
5907         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
5908         (remove_fork_catchpoint, post_startup_inferior)
5909         (post_attach): Move...
5910         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
5911         (remove_fork_catchpoint, post_startup_inferior)
5912         (post_attach): ...here.
5913         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
5914         (remove_fork_catchpoint, post_startup_inferior)
5915         (post_attach): Move...
5916         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
5917         (remove_fork_catchpoint, post_startup_inferior)
5918         (post_attach): ...here.
5919
5920 2020-04-24  Tom Tromey  <tromey@adacore.com>
5921
5922         * nat/windows-nat.h (struct windows_thread_info)
5923         <pc_adjusted>: New member.
5924         * windows-nat.c (windows_fetch_one_register): Check
5925         pc_adjusted.
5926         (windows_nat_target::get_windows_debug_event)
5927         (windows_nat_target::wait): Set pc_adjusted.
5928
5929 2020-04-24  Tom de Vries  <tdevries@suse.de>
5930
5931         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
5932         Run gdb-add-index inside temp dir.
5933
5934 2020-04-23  Tom Tromey  <tromey@adacore.com>
5935
5936         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
5937         in loop.
5938
5939 2020-04-23  Luis Machado  <luis.machado@linaro.org>
5940
5941         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
5942         get_frame_register instead of gdbarch_unwind_pc.
5943
5944 2020-04-23  Tom de Vries  <tdevries@suse.de>
5945
5946         * symtab.c (lookup_global_symbol): Prefer def over decl.
5947
5948 2020-04-23  Tom de Vries  <tdevries@suse.de>
5949
5950         PR symtab/25807
5951         * block.c (best_symbol, better_symbol): Promote to external.
5952         * block.h (best_symbol, better_symbol): Declare.
5953         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
5954         decl.
5955
5956 2020-04-23  Tom Tromey  <tromey@adacore.com>
5957
5958         PR ada/25837:
5959         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
5960         "const char *", not a "const std::string &".
5961         <name_and_matcher::operator==>: Update.
5962         * unittests/lookup_name_info-selftests.c: Change type of
5963         "result".
5964
5965 2020-04-23  Tom Tromey  <tom@tromey.com>
5966
5967         * inferior.h (iterate_over_inferiors): Don't declare.
5968         * inferior.c (iterate_over_inferiors): Remove.
5969         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
5970         Remove.
5971         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
5972         use iterate_over_inferiors.
5973         (darwin_resume_inferior_it)
5974         (struct resume_inferior_threads_param)
5975         (darwin_resume_inferior_threads_it): Remove.
5976         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
5977
5978 2020-04-23  Tom de Vries  <tdevries@suse.de>
5979
5980         * blockframe.c (find_pc_partial_function): Use
5981         find_pc_sect_compunit_symtab rather than
5982         objfile->sf->qf->find_pc_sect_compunit_symtab.
5983
5984 2020-04-22  Tom de Vries  <tdevries@suse.de>
5985
5986         PR symtab/25764
5987         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
5988         in psymtabs.
5989
5990 2020-04-22  Tom de Vries  <tdevries@suse.de>
5991
5992         PR symtab/25801
5993         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
5994         symtabs.
5995
5996 2020-04-22  Tom de Vries  <tdevries@suse.de>
5997
5998         PR symtab/25700
5999         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
6000         CU if already created.
6001
6002 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6003
6004         * infrun.c (displaced_step_fixup): Switch to the event_thread
6005         before calling displaced_step_restore, not after.
6006
6007 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
6008
6009         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
6010         its inferior is not recorded by us.
6011         (record_btrace_target_open): Replace call to
6012         all_non_exited_threads () with call to current_inferior
6013         ()->non_exited_threads ().
6014         (record_btrace_target::stop_recording): Likewise.
6015         (record_btrace_target::close): Likewise.
6016         (record_btrace_target::wait): Likewise.
6017         (record_btrace_target::record_stop_replaying): Likewise.
6018
6019 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
6020
6021         * btrace.c (btrace_enable): Throw an error on double enables and
6022         when enabling recording fails.
6023         (btrace_disable): Throw an error if the thread is not recorded.
6024
6025 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
6026
6027         * record-btrace.c (record_btrace_target::fetch_registers): Forward
6028         request if we do not have a thread_info.
6029
6030 2020-04-21  Tom de Vries  <tdevries@suse.de>
6031
6032         PR gdb/25471
6033         * thread.c
6034         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
6035         exception in get_frame_id.
6036
6037 2020-04-20  Tom Tromey  <tromey@adacore.com>
6038
6039         * python/python.c (struct gdbpy_event): Mark move constructor as
6040         noexcept.
6041         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
6042         constructor as noexcept.
6043         * completer.h (struct completion_result): Mark move constructor as
6044         noexcept.
6045         * completer.c (completion_result::completion_result): Use
6046         initialization style.  Don't call reset_match_list.
6047
6048 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
6049
6050         * MAINTAINERS (Write After Approval): Add myself.
6051
6052 2020-04-18  Tom Tromey  <tom@tromey.com>
6053
6054         * windows-tdep.c (init_w32_command_list)
6055         (w32_prefix_command_valid): Restore.
6056         (_initialize_windows_tdep): Call init_w32_command_list.
6057
6058 2020-04-18  Tom Tromey  <tom@tromey.com>
6059
6060         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
6061         * value.c (value_fn_field): Update.
6062         * valops.c (find_function_in_inferior)
6063         (value_allocate_space_in_inferior): Update.
6064         * tui/tui-winsource.c (tui_update_source_windows_with_line):
6065         Update.
6066         * tui/tui-source.c (tui_source_window::set_contents): Update.
6067         * symtab.c (lookup_global_or_static_symbol)
6068         (find_function_start_sal_1, skip_prologue_sal)
6069         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
6070         * symmisc.c (dump_msymbols, dump_symtab_1)
6071         (maintenance_print_one_line_table): Update.
6072         * symfile.c (init_entry_point_info, section_is_mapped)
6073         (list_overlays_command, simple_read_overlay_table)
6074         (simple_overlay_update_1): Update.
6075         * stap-probe.c (handle_stap_probe): Update.
6076         * stabsread.c (dbx_init_float_type, define_symbol)
6077         (read_one_struct_field, read_enum_type, read_range_type): Update.
6078         * source.c (info_line_command): Update.
6079         * python/python.c (gdbpy_source_objfile_script)
6080         (gdbpy_execute_objfile_script): Update.
6081         * python/py-type.c (save_objfile_types): Update.
6082         * python/py-objfile.c (py_free_objfile): Update.
6083         * python/py-inferior.c (python_new_objfile): Update.
6084         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
6085         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
6086         (maintenance_check_psymtabs): Update.
6087         * printcmd.c (info_address_command): Update.
6088         * objfiles.h (struct objfile) <arch>: New method, from
6089         get_objfile_arch.
6090         (get_objfile_arch): Don't declare.
6091         * objfiles.c (get_objfile_arch): Remove.
6092         (filter_overlapping_sections): Update.
6093         * minsyms.c (msymbol_is_function): Update.
6094         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
6095         (output_nondebug_symbol): Update.
6096         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
6097         (mdebug_expand_psymtab): Update.
6098         * machoread.c (macho_add_oso_symfile): Update.
6099         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
6100         Update.
6101         * linux-fork.c (checkpoint_command): Update.
6102         * linespec.c (convert_linespec_to_sals): Update.
6103         * jit.c (finalize_symtab): Update.
6104         * infrun.c (insert_exception_resume_from_probe): Update.
6105         * ia64-tdep.c (ia64_find_unwind_table): Update.
6106         * hppa-tdep.c (internalize_unwinds): Update.
6107         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
6108         Update.
6109         * gcore.c (call_target_sbrk): Update.
6110         * elfread.c (record_minimal_symbol, elf_symtab_read)
6111         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
6112         (elf_gnu_ifunc_resolve_by_got): Update.
6113         * dwarf2/read.c (create_addrmap_from_index)
6114         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6115         (read_debug_names_from_section)
6116         (process_psymtab_comp_unit_reader, add_partial_symbol)
6117         (add_partial_subprogram, process_full_comp_unit)
6118         (read_file_scope, read_func_scope, read_lexical_block_scope)
6119         (read_call_site_scope, dwarf2_ranges_read)
6120         (dwarf2_record_block_ranges, dwarf2_add_field)
6121         (mark_common_block_symbol_computed, read_tag_pointer_type)
6122         (read_tag_string_type, dwarf2_init_float_type)
6123         (dwarf2_init_complex_target_type, read_base_type)
6124         (partial_die_info::read, partial_die_info::read)
6125         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
6126         (dwarf2_fetch_die_loc_sect_off): Update.
6127         * dwarf2/loc.c (dwarf2_find_location_expression)
6128         (class dwarf_evaluate_loc_desc, rw_pieced_value)
6129         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
6130         (dwarf2_loc_desc_get_symbol_read_needs)
6131         (locexpr_describe_location_piece, locexpr_describe_location_1)
6132         (loclist_describe_location): Update.
6133         * dwarf2/index-write.c (write_debug_names): Update.
6134         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
6135         * dtrace-probe.c (dtrace_process_dof): Update.
6136         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
6137         (process_one_symbol): Update.
6138         * ctfread.c (ctf_init_float_type, read_base_type): Update.
6139         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
6140         (coff_read_enum_type): Update.
6141         * cli/cli-cmds.c (edit_command, list_command): Update.
6142         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
6143         * breakpoint.c (create_overlay_event_breakpoint)
6144         (create_longjmp_master_breakpoint)
6145         (create_std_terminate_master_breakpoint)
6146         (create_exception_master_breakpoint, get_sal_arch): Update.
6147         * block.c (block_gdbarch): Update.
6148         * annotate.c (annotate_source_line): Update.
6149
6150 2020-04-17  Tom Tromey  <tromey@adacore.com>
6151
6152         * auto-load.c (show_auto_load_cmd): Remove.
6153         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
6154         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
6155         (maintenance_print_arc_command): Remove.
6156         * tui/tui-win.c (tui_command): Remove.
6157         (tui_get_cmd_list): Use add_basic_prefix_cmd.
6158         * tui/tui-layout.c (tui_layout_command): Remove.
6159         (_initialize_tui_layout): Use add_basic_prefix_cmd.
6160         * python/python.c (user_set_python, user_show_python): Remove.
6161         (_initialize_python): Use add_basic_prefix_cmd,
6162         add_show_prefix_cmd.
6163         * guile/guile.c (set_guile_command, show_guile_command): Remove.
6164         (install_gdb_commands): Use add_basic_prefix_cmd,
6165         add_show_prefix_cmd.
6166         (info_guile_command): Remove.
6167         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
6168         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
6169         add_show_prefix_cmd.
6170         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
6171         Remove do_set and do_show parameters.
6172         * cli/cli-style.c (set_style, show_style): Remove.
6173         (_initialize_cli_style): Use add_basic_prefix_cmd,
6174         add_show_prefix_cmd.
6175         (cli_style_option::add_setshow_commands): Remove do_set and
6176         do_show parameters.
6177         (cli_style_option::add_setshow_commands): Use
6178         add_basic_prefix_cmd, add_show_prefix_cmd.
6179         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
6180         (set_style_name): Remove.
6181         * cli/cli-dump.c (dump_command, append_command): Remove.
6182         (srec_dump_command, ihex_dump_command, verilog_dump_command)
6183         (tekhex_dump_command, binary_dump_command)
6184         (binary_append_command): Remove.
6185         (_initialize_cli_dump): Use add_basic_prefix_cmd.
6186         * windows-tdep.c (w32_prefix_command_valid): Remove global.
6187         (init_w32_command_list): Remove; move into ...
6188         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
6189         * valprint.c (set_print, show_print, set_print_raw)
6190         (show_print_raw): Remove.
6191         (_initialize_valprint): Use add_basic_prefix_cmd,
6192         add_show_prefix_cmd.
6193         * typeprint.c (set_print_type, show_print_type): Remove.
6194         (_initialize_typeprint): Use add_basic_prefix_cmd,
6195         add_show_prefix_cmd.
6196         * record.c (set_record_command, show_record_command): Remove.
6197         (_initialize_record): Use add_basic_prefix_cmd,
6198         add_show_prefix_cmd.
6199         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
6200         add_show_prefix_cmd.
6201         (info_command, show_command, set_debug, show_debug): Remove.
6202         * top.h (set_history, show_history): Don't declare.
6203         * top.c (set_history, show_history): Remove.
6204         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
6205         (unset_tdesc_cmd): Remove.
6206         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
6207         add_show_prefix_cmd.
6208         * symtab.c (info_module_command): Remove.
6209         (_initialize_symtab): Use add_basic_prefix_cmd.
6210         * symfile.c (overlay_command): Remove.
6211         (_initialize_symfile): Use add_basic_prefix_cmd.
6212         * sparc64-tdep.c (info_adi_command): Remove.
6213         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
6214         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
6215         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
6216         add_show_prefix_cmd.
6217         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
6218         (_initialize_serial): Use add_basic_prefix_cmd,
6219         add_show_prefix_cmd.
6220         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
6221         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
6222         add_show_prefix_cmd.
6223         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
6224         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
6225         add_show_prefix_cmd.
6226         * riscv-tdep.c (show_riscv_command, set_riscv_command)
6227         (show_debug_riscv_command, set_debug_riscv_command): Remove.
6228         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
6229         add_show_prefix_cmd.
6230         * remote.c (remote_command, set_remote_cmd): Remove.
6231         (_initialize_remote): Use add_basic_prefix_cmd.
6232         * record-full.c (set_record_full_command)
6233         (show_record_full_command): Remove.
6234         (_initialize_record_full): Use add_basic_prefix_cmd,
6235         add_show_prefix_cmd.
6236         * record-btrace.c (cmd_set_record_btrace)
6237         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
6238         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
6239         (cmd_show_record_btrace_pt): Remove.
6240         (_initialize_record_btrace): Use add_basic_prefix_cmd,
6241         add_show_prefix_cmd.
6242         * ravenscar-thread.c (set_ravenscar_command)
6243         (show_ravenscar_command): Remove.
6244         (_initialize_ravenscar): Use add_basic_prefix_cmd,
6245         add_show_prefix_cmd.
6246         * mips-tdep.c (show_mips_command, set_mips_command)
6247         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
6248         add_show_prefix_cmd.
6249         * maint.c (maintenance_command, maintenance_info_command)
6250         (maintenance_check_command, maintenance_print_command)
6251         (maintenance_set_cmd, maintenance_show_cmd): Remove.
6252         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
6253         add_show_prefix_cmd.
6254         (show_per_command_cmd): Remove.
6255         * maint-test-settings.c (maintenance_set_test_settings_cmd):
6256         Remove.
6257         (maintenance_show_test_settings_cmd): Remove.
6258         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
6259         add_show_prefix_cmd.
6260         * maint-test-options.c (maintenance_test_options_command):
6261         Remove.
6262         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
6263         * macrocmd.c (macro_command): Remove
6264         (_initialize_macrocmd): Use add_basic_prefix_cmd.
6265         * language.c (set_check, show_check): Remove.
6266         (_initialize_language): Use add_basic_prefix_cmd,
6267         add_show_prefix_cmd.
6268         * infcmd.c (unset_command): Remove.
6269         (_initialize_infcmd): Use add_basic_prefix_cmd.
6270         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
6271         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
6272         add_show_prefix_cmd.
6273         * go32-nat.c (go32_info_dos_command): Remove.
6274         (_initialize_go32_nat): Use add_basic_prefix_cmd.
6275         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
6276         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
6277         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
6278         (_initialize_frame): Use add_basic_prefix_cmd,
6279         add_show_prefix_cmd.
6280         * dcache.c (set_dcache_command, show_dcache_command): Remove.
6281         (_initialize_dcache): Use add_basic_prefix_cmd,
6282         add_show_prefix_cmd.
6283         * cp-support.c (maint_cplus_command): Remove.
6284         (_initialize_cp_support): Use add_basic_prefix_cmd.
6285         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
6286         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
6287         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
6288         add_basic_prefix_cmd, add_show_prefix_cmd.
6289         * breakpoint.c (save_command): Remove.
6290         (_initialize_breakpoint): Use add_basic_prefix_cmd.
6291         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
6292         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
6293         add_show_prefix_cmd.
6294         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
6295         (set_ada_command, show_ada_command): Remove.
6296         (_initialize_ada_language): Use add_basic_prefix_cmd,
6297         add_show_prefix_cmd.
6298         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
6299
6300 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
6301
6302         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
6303         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
6304
6305 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
6306
6307         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
6308         warning messages.
6309
6310 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
6311
6312         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
6313         import table is not at beginning of .idata section.
6314
6315 2020-04-16  Pedro Alves  <palves@redhat.com>
6316
6317         * inferior.c (delete_inferior): Use delete operator directly
6318         instead of delete_program_space.
6319         * progspace.c (add_program_space): New, factored out from
6320         program_space::program_space.
6321         (remove_program_space): New, factored out from
6322         delete_program_space.
6323         (program_space::program_space): Remove intro comment.  Rewrite.
6324         (program_space::~program_space): Remove intro comment.  Call
6325         remove_program_space.
6326         (delete_program_space): Delete.
6327         * progspace.h (program_space::program_space): Make explicit.  Move
6328         intro comment here, adjusted.
6329         (program_space::~program_space): Move intro comment here,
6330         adjusted.
6331         (delete_program_space): Remove.
6332
6333 2020-04-16  Tom Tromey  <tromey@adacore.com>
6334
6335         * windows-nat.c (windows_nat::handle_access_violation): New
6336         function.
6337         * nat/windows-nat.h (handle_access_violation): Declare.
6338         * nat/windows-nat.c (handle_exception): Move Cygwin code to
6339         windows-nat.c.  Call handle_access_violation.
6340
6341 2020-04-16  Tom de Vries  <tdevries@suse.de>
6342
6343         PR symtab/25791
6344         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
6345         CUs without psymtab.
6346
6347 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
6348
6349         * python/python.c (do_start_initialization): Don't call
6350         PyEval_InitThreads for Python 3.9 and beyond.
6351
6352 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
6353
6354         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
6355         thread functions.
6356         (obsd_nat_target::wait): Likewise.
6357
6358 2020-04-15  Tom Tromey  <tromey@adacore.com>
6359
6360         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
6361         (DEBUG_EXCEPT): Use debug_printf.
6362
6363 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6364
6365         * completer.c (class completion_tracker::completion_hash_entry)
6366         <hash_name>: New member function.
6367         (completion_tracker::discard_completions): New callback to hash a
6368         completion_hash_entry, pass this to htab_create_alloc.
6369
6370 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
6371
6372         * windows-nat.c (windows_make_so): Warn rather than stopping with
6373         an error if realpath() fails.
6374
6375 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
6376
6377         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
6378         (nbsd_nat_target::info_proc): Add do_status.
6379
6380 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
6381             Tom de Vries  <tdevries@suse.de>
6382
6383         PR symtab/25718
6384         * psympriv.h (struct partial_symtab::read_symtab)
6385         (struct partial_symtab::expand_psymtab)
6386         (struct partial_symtab::read_dependencies): Update comments.
6387         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
6388         read_symtab for includer.
6389         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
6390         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
6391         (struct dwarf2_include_psymtab::m_readin): Remove.
6392         (struct dwarf2_include_psymtab::includer): New member function.
6393         (dwarf2_psymtab::expand_psymtab): Assert !readin.
6394
6395 2020-04-14  Tom de Vries  <tdevries@suse.de>
6396
6397         PR symtab/25720
6398         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
6399         with NULL symbol_matcher and lookup_name.
6400         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
6401         and lookup_name.
6402         * dwarf2/read.c (dw2_expand_symtabs_matching)
6403         (dw2_debug_names_expand_symtabs_matching): Same.
6404         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
6405         Make lookup_name a pointer.  Update comment.
6406         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
6407         lookup_name being a pointer.
6408         * symfile.c (expand_symtabs_matching): Same.
6409         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
6410         * linespec.c (iterate_over_all_matching_symtabs): Same.
6411
6412 2020-04-13  Tom Tromey  <tom@tromey.com>
6413
6414         * run-on-main-thread.c: Update include.
6415         * unittests/main-thread-selftests.c: Update include.
6416         * tui/tui-win.c: Update include.
6417         * tui/tui-io.c: Update include.
6418         * tui/tui-interp.c: Update include.
6419         * tui/tui-hooks.c: Update include.
6420         * top.h: Update include.
6421         * top.c: Update include.
6422         * ser-base.c: Update include.
6423         * remote.c: Update include.
6424         * remote-notif.c: Update include.
6425         * remote-fileio.c: Update include.
6426         * record-full.c: Update include.
6427         * record-btrace.c: Update include.
6428         * python/python.c: Update include.
6429         * posix-hdep.c: Update include.
6430         * mingw-hdep.c: Update include.
6431         * mi/mi-main.c: Update include.
6432         * mi/mi-interp.c: Update include.
6433         * main.c: Update include.
6434         * linux-nat.c: Update include.
6435         * interps.c: Update include.
6436         * infrun.c: Update include.
6437         * inf-loop.c: Update include.
6438         * event-top.c: Update include.
6439         * event-loop.c: Move to ../gdbsupport/.
6440         * event-loop.h: Move to ../gdbsupport/.
6441         * async-event.h: Update include.
6442         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
6443
6444 2020-04-13  Tom Tromey  <tom@tromey.com>
6445
6446         * tui/tui-win.c: Include async-event.h.
6447         * remote.c: Include async-event.h.
6448         * remote-notif.c: Include async-event.h.
6449         * record-full.c: Include async-event.h.
6450         * record-btrace.c: Include async-event.h.
6451         * infrun.c: Include async-event.h.
6452         * event-top.c: Include async-event.h.
6453         * event-loop.h: Move some declarations to async-event.h.
6454         * event-loop.c: Don't include ser-event.h or top.h.  Move some
6455         code to async-event.c.
6456         * async-event.h: New file.
6457         * async-event.c: New file.
6458         * Makefile.in (COMMON_SFILES): Add async-event.c.
6459         (HFILES_NO_SRCDIR): Add async-event.h.
6460
6461 2020-04-13  Tom Tromey  <tom@tromey.com>
6462
6463         * utils.c (flush_streams): New function.
6464         * event-loop.c (gdb_wait_for_event): Call flush_streams.
6465
6466 2020-04-13  Tom Tromey  <tom@tromey.com>
6467
6468         * event-loop.c (handle_file_event): Use warning, not
6469         printf_unfiltered.
6470
6471 2020-04-13  Tom Tromey  <tom@tromey.com>
6472
6473         * event-loop.c: Include <chrono>.
6474
6475 2020-04-13  Tom Tromey  <tom@tromey.com>
6476
6477         * gdb_select.h: Move to ../gdbsupport/.
6478         * event-loop.c: Update include path.
6479         * top.c: Update include path.
6480         * ser-base.c: Update include path.
6481         * ui-file.c: Update include path.
6482         * ser-tcp.c: Update include path.
6483         * guile/scm-ports.c: Update include path.
6484         * posix-hdep.c: Update include path.
6485         * ser-unix.c: Update include path.
6486         * gdb_usleep.c: Update include path.
6487         * mingw-hdep.c: Update include path.
6488         * inflow.c: Update include path.
6489         * infrun.c: Update include path.
6490         * event-top.c: Update include path.
6491
6492 2020-04-13  Tom Tromey  <tom@tromey.com>
6493
6494         * configure: Rebuild.
6495         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
6496
6497 2020-04-13  Tom Tromey  <tom@tromey.com>
6498
6499         * event-loop.h (start_event_loop): Don't declare.
6500         * event-loop.c (start_event_loop): Move...
6501         * main.c (start_event_loop): ...here.  Now static.
6502
6503 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
6504
6505         * MAINTAINERS: Update my email address.
6506
6507 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6508
6509         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
6510         IP_ALL.
6511
6512 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6513
6514         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
6515         (nbsd_nat_target::info_proc): Add do_cmdline.
6516
6517 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6518
6519         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
6520         (nbsd_nat_target::info_proc): Add do_cwd.
6521
6522 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6523
6524         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
6525
6526 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
6527
6528         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
6529         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
6530         (nbsd_nat_target::info_proc): New functions.
6531         * nbsd-nat.c (kinfo_get_vmmap): New function.
6532         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
6533         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
6534         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
6535         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
6536         functions.
6537         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
6538         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6539         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6540         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
6541         (KINFO_VME_FLAG_GROWS_DOWN): New.
6542
6543 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
6544
6545         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
6546         bit shift.
6547
6548 2020-04-10  Tom Tromey  <tromey@adacore.com>
6549
6550         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
6551
6552 2020-04-10  Tom Tromey  <tromey@adacore.com>
6553
6554         * symtab.c (get_symbol_address, get_msymbol_address): Skip
6555         separate debug files.
6556
6557 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
6558
6559         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
6560         Move to...
6561         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
6562         ... here.
6563         * windows-nat.c (windows_nat_target::get_windows_debug_event):
6564         Check for STATUS_WX86_BREAKPOINT.
6565         (windows_nat_target::wait): Same.
6566
6567 2020-04-10  Tom de Vries  <tdevries@suse.de>
6568
6569         PR cli/25808
6570         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
6571
6572 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
6573
6574         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
6575         (Write After Approval): Remove Tom de Vries.
6576
6577 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6578
6579         revert partially:
6580         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6581
6582         * buildsym.c (record_line): Fix undefined behavior and preserve
6583         lines at eof.
6584
6585 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
6586
6587         * auxv.h (svr4_auxv_parse): New.
6588         * auxv.c (default_auxv_parse): Split into default_auxv_parse
6589         and generic_auxv_parse.
6590         (svr4_auxv_parse): Add.
6591         * obsd-tdep.c: Include "auxv.h".
6592         (obsd_auxv_parse): Remove.
6593         (obsd_init_abi): Remove comment.
6594         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
6595         from `obsd_auxv_parse' to `svr4_auxv_parse'.
6596         * nbsd-tdep.c: Include "auxv.h".
6597         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
6598
6599 2020-04-08  Tom Tromey  <tromey@adacore.com>
6600
6601         * nat/windows-nat.h (last_wait_event): Don't declare.
6602         (wait_for_debug_event): Update comment.
6603         * nat/windows-nat.c (last_wait_event): Now static.
6604
6605 2020-04-08  Tom Tromey  <tromey@adacore.com>
6606
6607         * windows-nat.c (wait_for_debug_event): Move to
6608         nat/windows-nat.c.
6609         * nat/windows-nat.h (wait_for_debug_event): Declare.
6610         * nat/windows-nat.c (wait_for_debug_event): Move from
6611         windows-nat.c.  No longer static.
6612
6613 2020-04-08  Tom Tromey  <tromey@adacore.com>
6614
6615         * windows-nat.c (get_windows_debug_event): Use
6616         fetch_pending_stop.
6617         * nat/windows-nat.h (fetch_pending_stop): Declare.
6618         * nat/windows-nat.c (fetch_pending_stop): New function.
6619
6620 2020-04-08  Tom Tromey  <tromey@adacore.com>
6621
6622         * windows-nat.c (windows_continue): Use matching_pending_stop and
6623         continue_last_debug_event.
6624         * nat/windows-nat.h (matching_pending_stop)
6625         (continue_last_debug_event): Declare.
6626         * nat/windows-nat.c (DEBUG_EVENTS): New define.
6627         (matching_pending_stop, continue_last_debug_event): New
6628         functions.
6629
6630 2020-04-08  Tom Tromey  <tromey@adacore.com>
6631
6632         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
6633         (handle_exception_result): Move to nat/windows-nat.h.
6634         (DEBUG_EXCEPTION_SIMPLE): Remove.
6635         (windows_nat::handle_ms_vc_exception): New function.
6636         (handle_exception): Move to nat/windows-nat.c.
6637         (get_windows_debug_event): Update.
6638         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
6639         nat/windows-nat.c.
6640         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
6641         (handle_exception_result): Move from windows-nat.c.
6642         (handle_exception): Declare.
6643         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
6644         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
6645         windows-nat.c.
6646
6647 2020-04-08  Tom Tromey  <tromey@adacore.com>
6648
6649         * windows-nat.c (exception_count, event_count): Remove.
6650         (handle_exception, get_windows_debug_event)
6651         (do_initial_windows_stuff): Update.
6652
6653 2020-04-08  Tom Tromey  <tromey@adacore.com>
6654
6655         * windows-nat.c (windows_nat::handle_load_dll)
6656         (windows_nat::handle_unload_dll): Rename.  No longer static.
6657         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
6658         Declare.
6659
6660 2020-04-08  Tom Tromey  <tromey@adacore.com>
6661
6662         * complaints.h (stop_whining): Declare at top-level.
6663         (complaint): Don't declare stop_whining.
6664
6665 2020-04-08  Tom Tromey  <tromey@adacore.com>
6666
6667         * windows-nat.c (windows_nat::handle_output_debug_string):
6668         Rename.  No longer static.
6669         * nat/windows-nat.h (handle_output_debug_string): Declare.
6670
6671 2020-04-08  Tom Tromey  <tromey@adacore.com>
6672
6673         * windows-nat.c (current_process_handle, current_process_id)
6674         (main_thread_id, last_sig, current_event, last_wait_event)
6675         (current_windows_thread, desired_stop_thread_id, pending_stops)
6676         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
6677         (display_selectors, fake_create_process)
6678         (get_windows_debug_event): Update.
6679         * nat/windows-nat.h (current_process_handle, current_process_id)
6680         (main_thread_id, last_sig, current_event, last_wait_event)
6681         (current_windows_thread, desired_stop_thread_id, pending_stops)
6682         (struct pending_stop, siginfo_er): Move from windows-nat.c.
6683         * nat/windows-nat.c (current_process_handle, current_process_id)
6684         (main_thread_id, last_sig, current_event, last_wait_event)
6685         (current_windows_thread, desired_stop_thread_id, pending_stops)
6686         (siginfo_er): New globals.  Move from windows-nat.c.
6687
6688 2020-04-08  Tom Tromey  <tromey@adacore.com>
6689
6690         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
6691         (handle_load_dll): Update.
6692         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
6693
6694 2020-04-08  Tom Tromey  <tromey@adacore.com>
6695
6696         * windows-nat.c (enum thread_disposition_type): Move to
6697         nat/windows-nat.h.
6698         (windows_nat::thread_rec): Rename from thread_rec.  No longer
6699         static.
6700         (windows_add_thread, windows_nat_target::fetch_registers)
6701         (windows_nat_target::store_registers, handle_exception)
6702         (windows_nat_target::resume, get_windows_debug_event)
6703         (windows_nat_target::get_tib_address)
6704         (windows_nat_target::thread_name)
6705         (windows_nat_target::thread_alive): Update.
6706         * nat/windows-nat.h (enum thread_disposition_type): Move from
6707         windows-nat.c.
6708         (thread_rec): Declare.
6709
6710 2020-04-08  Tom Tromey  <tromey@adacore.com>
6711
6712         * windows-nat.c: Add "using namespace".
6713         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
6714         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
6715
6716 2020-04-08  Tom Tromey  <tromey@adacore.com>
6717
6718         * nat/windows-nat.h (struct windows_thread_info): Declare
6719         destructor.
6720         * nat/windows-nat.c (~windows_thread_info): New.
6721
6722 2020-04-08  Tom Tromey  <tromey@adacore.com>
6723
6724         PR gdb/22992
6725         * windows-nat.c (current_event): Update comment.
6726         (last_wait_event, desired_stop_thread_id): New globals.
6727         (struct pending_stop): New.
6728         (pending_stops): New global.
6729         (windows_nat_target) <stopped_by_sw_breakpoint>
6730         <supports_stopped_by_sw_breakpoint>: New methods.
6731         (windows_fetch_one_register): Add assertions.  Adjust PC.
6732         (windows_continue): Handle pending stops.  Suspend other threads
6733         when stepping.  Use last_wait_event
6734         (wait_for_debug_event): New function.
6735         (get_windows_debug_event): Use wait_for_debug_event.  Handle
6736         pending stops.  Queue spurious stops.
6737         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
6738         (windows_nat_target::kill): Use wait_for_debug_event.
6739         * nat/windows-nat.h (struct windows_thread_info)
6740         <stopped_at_software_breakpoint>: New field.
6741         * nat/windows-nat.c (windows_thread_info::resume): Clear
6742         stopped_at_software_breakpoint.
6743
6744 2020-04-08  Tom Tromey  <tromey@adacore.com>
6745
6746         * windows-nat.c (enum thread_disposition_type): New.
6747         (thread_rec): Replace "get_context" parameter with "disposition";
6748         change type.
6749         (windows_add_thread, windows_nat_target::fetch_registers)
6750         (windows_nat_target::store_registers, handle_exception)
6751         (windows_nat_target::resume, get_windows_debug_event)
6752         (windows_nat_target::get_tib_address)
6753         (windows_nat_target::thread_name)
6754         (windows_nat_target::thread_alive): Update.
6755
6756 2020-04-08  Tom Tromey  <tromey@adacore.com>
6757
6758         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
6759         (windows_continue): Use windows_continue::resume.
6760         * nat/windows-nat.h (struct windows_thread_info) <suspend,
6761         resume>: Declare new methods.
6762         * nat/windows-nat.c: New file.
6763         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
6764
6765 2020-04-08  Tom Tromey  <tromey@adacore.com>
6766
6767         * windows-nat.c (windows_add_thread, windows_delete_thread)
6768         (windows_nat_target::fetch_registers)
6769         (windows_nat_target::store_registers, fake_create_process)
6770         (windows_nat_target::resume, windows_nat_target::resume)
6771         (get_windows_debug_event, windows_nat_target::wait)
6772         (windows_nat_target::pid_to_str)
6773         (windows_nat_target::get_tib_address)
6774         (windows_nat_target::get_ada_task_ptid)
6775         (windows_nat_target::thread_name)
6776         (windows_nat_target::thread_alive): Use lwp, not tid.
6777
6778 2020-04-08  Tom Tromey  <tromey@adacore.com>
6779
6780         * windows-nat.c (handle_exception)
6781         (windows_nat_target::thread_name): Update.
6782         * nat/windows-nat.h (windows_thread_info): Remove destructor.
6783         <name>: Now unique_xmalloc_ptr.
6784
6785 2020-04-08  Tom Tromey  <tromey@adacore.com>
6786
6787         * windows-nat.c (thread_rec)
6788         (windows_nat_target::fetch_registers): Update.
6789         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
6790         Update comment.
6791         <debug_registers_changed, reload_context>: Now bool.
6792
6793 2020-04-08  Tom Tromey  <tromey@adacore.com>
6794
6795         * windows-nat.c (windows_add_thread): Use new.
6796         (windows_init_thread_list, windows_delete_thread): Use delete.
6797         (get_windows_debug_event): Update.
6798         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
6799         destructor, and initializers.
6800
6801 2020-04-08  Tom Tromey  <tromey@adacore.com>
6802
6803         * windows-nat.c (struct windows_thread_info): Remove.
6804         * nat/windows-nat.h: New file.
6805
6806 2020-04-08  Tom Tromey  <tromey@adacore.com>
6807
6808         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
6809         (thread_rec, windows_add_thread, windows_delete_thread)
6810         (windows_continue): Update.
6811
6812 2020-04-08  Tom Tromey  <tromey@adacore.com>
6813
6814         * windows-nat.c (struct windows_thread_info): Remove typedef.
6815         (thread_head): Remove.
6816         (thread_list): New global.
6817         (thread_rec, windows_add_thread, windows_init_thread_list)
6818         (windows_delete_thread, windows_continue): Update.
6819
6820 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
6821
6822         * windows-tdep.h (windows_init_abi): Add comment.
6823         (cygwin_init_abi): New declaration.
6824         * windows-tdep.c: Split signal enumeration in two, one for
6825         Windows and one for Cygwin.
6826         (windows_gdb_signal_to_target): Only deal with signal of the
6827         Windows OS ABI.
6828         (cygwin_gdb_signal_to_target): New function.
6829         (windows_init_abi): Rename to windows_init_abi_common, don't set
6830         gdb_signal_to_target gdbarch method.  Add new new function with
6831         this name.
6832         (cygwin_init_abi): New function.
6833         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
6834         comment.  Don't call windows_init_abi.
6835         (amd64_windows_init_abi): Add comment, call windows_init_abi.
6836         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
6837         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
6838         i386_windows_init_abi_common, don't call windows_init_abi.  Add
6839         a new function of this name.
6840         (i386_cygwin_init_abi): New function.
6841         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
6842         OS ABI Cygwin.
6843
6844 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
6845
6846         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
6847         parameter.c.
6848         (dwarf2_read_gdb_index): Update.
6849
6850 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
6851
6852         * nbsd-tdep.c: Include "objfiles.h".
6853         (nbsd_skip_solib_resolver): New.
6854         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
6855
6856 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6857
6858         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
6859         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
6860         with DW_LLE_base_addressx are being emitted in DWARFv5.
6861         Add the newly added kind DW_LOC_OFFSET_PAIR also.
6862         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
6863         unsigned integer.
6864
6865 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6866
6867         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
6868         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
6869         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
6870         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
6871         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
6872         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
6873         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
6874
6875
6876 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6877
6878         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
6879         (read_loclist_index): New function definition.
6880         (lookup_loclist_base): New function definition.
6881         (read_loclist_header): New function definition.
6882         (dwarf2_cu): Add loclist_base and loclist_header field.
6883         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
6884         (read_full_die_1): Read the value of DW_AT_loclists_base.
6885         (read_attribute_reprocess): Handle DW_FORM_loclistx.
6886         (read_attribute_value): Handle DW_FORM_loclistx.
6887         (skip_one_die): Handle DW_FORM_loclistx.
6888         (loclist_header): New structure declaration.
6889         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
6890
6891 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
6892
6893         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
6894         constructor.  Remove `addr` parameter from other constructor and
6895         add `per_cu` parameter.
6896         * dwarf2/read.c (create_partial_symtab): Update.
6897
6898 2020-04-07  Tom de Vries  <tdevries@suse.de>
6899
6900         PR symtab/25796
6901         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
6902         (partial_die_info::fixup): Inherit has_const_value.
6903
6904 2020-04-07  Tom de Vries  <tdevries@suse.de>
6905
6906         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
6907         symbols without address.
6908
6909 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
6910
6911         * nbsd-nat.h (struct thread_info): Add forward declaration.
6912         (nbsd_nat_target::thread_alive): Add.
6913         (nbsd_nat_target::thread_name): Likewise.
6914         (nbsd_nat_target::update_thread_list): Likewise.
6915         (update_thread_list::post_attach): Likewise.
6916         (post_attach::pid_to_str): Likewise.
6917         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
6918         (nbsd_thread_lister): Add.
6919         (nbsd_nat_target::thread_alive): Likewise.
6920         (nbsd_nat_target::thread_name): Likewise.
6921         (nbsd_add_threads): Likewise.
6922         (update_thread_list::post_attach): Likewise.
6923         (nbsd_nat_target::update_thread_list): Likewise.
6924         (post_attach::pid_to_str): Likewise.
6925
6926 2020-04-06  Tom Tromey  <tromey@adacore.com>
6927
6928         * ada-valprint.c (print_variant_part): Extract the variant field.
6929         (print_field_values): Use the field as the outer value when
6930         recursing.
6931
6932 2020-04-06  Tom Tromey  <tromey@adacore.com>
6933
6934         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
6935         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
6936         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
6937         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
6938         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
6939
6940 2020-04-06  Tom Tromey  <tromey@adacore.com>
6941
6942         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
6943         TYPE_CODE_ERROR.
6944
6945 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
6946
6947         * nbsd-tdep.c: Include "gdbarch.h".
6948         Define enum with NetBSD signal numbers.
6949         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
6950         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
6951         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
6952         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
6953         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
6954         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
6955         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
6956         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
6957         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
6958         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
6959         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
6960         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
6961
6962 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
6963
6964         PR gdb/25325
6965         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
6966
6967 2020-04-03  Tom Tromey  <tromey@adacore.com>
6968
6969         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
6970         Read constant block.
6971
6972 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
6973
6974         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
6975         (gdb_bfd_get_full_section_contents): New declaration.
6976         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
6977         * windows-tdep.c (is_linked_with_cygwin_dll): Use
6978         gdb_bfd_get_full_section_contents.
6979
6980 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
6981
6982         * exec.c (build_section_table): Replace internal_error with
6983         gdb_assert.
6984         (section_table_xfer_memory_partial): Likewise.
6985         * mdebugread.c (parse_partial_symbols): Likewise.
6986         * psymtab.c (lookup_partial_symbol): Likewise.
6987         * utils.c (wrap_here): Likewise.
6988
6989 2020-04-02  Tom Tromey  <tromey@adacore.com>
6990
6991         * f-lang.c (build_fortran_types): Use arch_type to initialize
6992         builtin_complex_s32 in the TYPE_CODE_ERROR case.
6993
6994 2020-04-02  Tom Tromey  <tromey@adacore.com>
6995
6996         * dwarf2/read.c (partial_die_info::read): Do not create a vector
6997         of attributes.
6998
6999 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7000             Bernd Edlinger <bernd.edlinger@hotmail.de>
7001             Tom Tromey  <tromey@adacore.com>
7002
7003         * buildsym.c (buildsym_compunit::record_line): Remove
7004         deduplication code.
7005
7006 2020-04-02  Tom de Vries  <tdevries@suse.de>
7007
7008         PR ada/24671
7009         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
7010
7011 2020-04-02  Tom de Vries  <tdevries@suse.de>
7012
7013         * dwarf2/read.c (dwarf2_gdb_index_functions,
7014         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
7015         NULL.
7016         * psymtab.c (psym_lookup_global_symbol_language): New function.
7017         (psym_functions): Init psym_lookup_global_symbol_language with
7018         psym_lookup_global_symbol_language.
7019         * symfile-debug.c (debug_sym_quick_functions): Init
7020         lookup_global_symbol_language with NULL.
7021         * symfile.c (set_initial_language): Remove fixme comment.
7022         * symfile.h (struct quick_symbol_functions): Add
7023         lookup_global_symbol_language.
7024         * symtab.c (find_quick_global_symbol_language): New function.
7025         (find_main_name): Use find_quick_global_symbol_language.
7026
7027 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
7028
7029         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
7030
7031 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7032
7033         * buildsym.c (record_line): Fix undefined behavior and preserve
7034         lines at eof.
7035
7036 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7037
7038         * buildsym.c (record_line): Fix the resizing condition.
7039
7040 2020-04-01  Tom Tromey  <tom@tromey.com>
7041
7042         * value.h (value_literal_complex): Add comment.
7043         * valops.c (value_literal_complex): Refer to value.h.
7044
7045 2020-04-01  Tom Tromey  <tom@tromey.com>
7046
7047         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
7048         (scalar_type): New rule, from typebase.
7049         (typebase): Use scalar_type.  Recognize complex types.
7050         (field_name): Handle FLOAT_KEYWORD.
7051         (ident_tokens): Add _Complex and __complex__.
7052
7053 2020-04-01  Tom Tromey  <tom@tromey.com>
7054
7055         PR exp/25299:
7056         * valarith.c (promotion_type, complex_binop): New functions.
7057         (scalar_binop): Handle complex numbers.  Use promotion_type.
7058         (value_pos, value_neg, value_complement): Handle complex numbers.
7059
7060 2020-04-01  Tom Tromey  <tom@tromey.com>
7061
7062         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
7063         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
7064         (parse_number): Handle complex numbers.
7065
7066 2020-04-01  Tom Tromey  <tom@tromey.com>
7067
7068         * c-valprint.c (c_decorations): Change complex suffix to "i".
7069
7070 2020-04-01  Tom Tromey  <tom@tromey.com>
7071
7072         * valprint.c (generic_value_print_complex): Use accessors.
7073         * value.h (value_real_part, value_imaginary_part): Declare.
7074         * valops.c (value_real_part, value_imaginary_part): New
7075         functions.
7076         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
7077
7078 2020-04-01  Tom Tromey  <tom@tromey.com>
7079
7080         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
7081         (read_range_type): Update.
7082         * mdebugread.c (basic_type): Update.
7083         * go-lang.c (build_go_types): Use init_complex_type.
7084         * gdbtypes.h (struct main_type) <complex_type>: New member.
7085         (init_complex_type): Update.
7086         (arch_complex_type): Don't declare.
7087         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
7088         Make name if none given.  Use alloc_type_copy.  Look for cached
7089         complex type.
7090         (arch_complex_type): Remove.
7091         (gdbtypes_post_init): Use init_complex_type.
7092         * f-lang.c (build_fortran_types): Use init_complex_type.
7093         * dwarf2/read.c (read_base_type): Update.
7094         * d-lang.c (build_d_types): Use init_complex_type.
7095         * ctfread.c (read_base_type): Update.
7096
7097 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7098
7099         * infrun.c (stop_all_threads): Update assertion, plus when
7100         stopping threads, take into account that we might be trying
7101         to stop an all-stop target.
7102         (stop_waiting): Call 'stop_all_threads' if there exists a
7103         non-stop target.
7104
7105 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7106
7107         * target.h (exists_non_stop_target): New function declaration.
7108         * target.c (exists_non_stop_target): New function.
7109
7110 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
7111
7112         PR gdb/24789
7113         * eval.c (is_integral_or_integral_reference): New function.
7114         (evaluate_subexp_standard): Allow integer references in
7115         pointer arithmetic.
7116
7117 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7118
7119         * remote.c (remote_target::remote_parse_stop_reply): Remove the
7120         check for no ptid in the stop reply when the target is non-stop.
7121
7122 2020-04-01  Tom Tromey  <tromey@adacore.com>
7123
7124         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
7125         "name" parameter to rvalue reference.  Initialize m_name_holder.
7126         <lookup_name_info>: New overloads.
7127         <name>: Return gdb::string_view.
7128         <c_str>: New method.
7129         <make_ignore_params>: Update.
7130         <search_name_hash>: Update.
7131         <language_lookup_name>: Return const char *.
7132         <m_name>: Change type.
7133         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
7134         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
7135         (lookup_name_info::match_any): Update.
7136         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
7137         Update.
7138         * minsyms.c (linkage_name_str): Update.
7139         * language.c (default_symbol_name_matcher): Update.
7140         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
7141         Update.
7142         * ada-lang.c (ada_fold_name): Change parameter to string_view.
7143         (ada_lookup_name_info::ada_lookup_name_info): Update.
7144         (literal_symbol_name_matcher): Update.
7145
7146 2020-04-01  Tom Tromey  <tromey@adacore.com>
7147
7148         * psymtab.c (psymtab_search_name): Remove function.
7149         (psym_lookup_symbol): Create search name and lookup name here.
7150         (lookup_partial_symbol): Remove "name" parameter; add
7151         lookup_name.
7152         (psym_expand_symtabs_for_function): Update.
7153
7154 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
7155
7156         PR tui/25597:
7157         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
7158
7159 2020-03-31  Tom Tromey  <tromey@adacore.com>
7160
7161         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
7162         memcpy.
7163
7164 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
7165
7166         * features/riscv/32bit-csr.xml: Regenerated.
7167         * features/riscv/64bit-csr.xml: Regenerated.
7168
7169 2020-03-30  Tom Tromey  <tromey@adacore.com>
7170
7171         * ada-valprint.c (print_variant_part): Update.
7172         * ada-lang.h (ada_which_variant_applies): Update.
7173         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
7174         outer_valaddr parameters; replace with "outer" value parameter.
7175         (to_fixed_variant_branch_type): Update.
7176
7177 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7178
7179         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
7180         <list>.  Remove inclusion of observable.h.
7181         (PPC_DEBUG_CURRENT_VERSION): Move up define.
7182         (struct arch_lwp_info): New struct.
7183         (class ppc_linux_dreg_interface): New class.
7184         (struct ppc_linux_process_info): New struct.
7185         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
7186         <low_new_clone, low_forget_process, low_prepare_to_resume>
7187         <copy_thread_dreg_state, mark_thread_stale>
7188         <mark_debug_registers_changed, register_hw_breakpoint>
7189         <clear_hw_breakpoint, register_wp, clear_wp>
7190         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
7191         <num_memory_accesses, get_trigger_type>
7192         <create_watchpoint_request, hwdebug_point_cmp>
7193         <init_arch_lwp_info, get_arch_lwp_info>
7194         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
7195         methods.
7196         <struct ptid_hash>: New inner struct.
7197         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
7198         members.
7199         (saved_dabr_value, hwdebug_info, max_slots_number)
7200         (struct hw_break_tuple, struct thread_points, ppc_threads)
7201         (have_ptrace_hwdebug_interface)
7202         (hwdebug_find_thread_points_by_tid)
7203         (hwdebug_insert_point, hwdebug_remove_point): Remove.
7204         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
7205         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
7206         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
7207         use m_dreg_interface.
7208         (hwdebug_point_cmp): Change to...
7209         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
7210         reference arguments instead of pointers.
7211         (ppc_linux_nat_target::ranged_break_num_registers): Use
7212         m_dreg_interface.
7213         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
7214         m_dreg_interface.  Call register_hw_breakpoint.
7215         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
7216         m_dreg_interface.  Call clear_hw_breakpoint.
7217         (get_trigger_type): Change to...
7218         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
7219         comment.
7220         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
7221         use m_dreg_interface.  Call register_hw_breakpoint.
7222         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
7223         use m_dreg_interface.  Call clear_hw_breakpoint.
7224         (can_use_watchpoint_cond_accel): Change to...
7225         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
7226         method.  Update comment, use m_dreg_interface and
7227         m_process_info.
7228         (calculate_dvc): Change to...
7229         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
7230         m_dreg_interface.
7231         (num_memory_accesses): Change to...
7232         (ppc_linux_nat_target::num_memory_accesses): ...this method.
7233         (check_condition): Change to...
7234         (ppc_linux_nat_target::check_condition): ...this method.
7235         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
7236         comment, use m_dreg_interface.
7237         (create_watchpoint_request): Change to...
7238         (ppc_linux_nat_target::create_watchpoint_request): ...this
7239         method.  Use m_dreg_interface.
7240         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
7241         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
7242         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
7243         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
7244         (ppc_linux_nat_target::low_forget_process)
7245         (ppc_linux_nat_target::low_new_fork)
7246         (ppc_linux_nat_target::low_new_clone)
7247         (ppc_linux_nat_target::low_delete_thread)
7248         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
7249         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
7250         only call mark_thread_stale.
7251         (ppc_linux_thread_exit): Remove.
7252         (ppc_linux_nat_target::stopped_data_address): Change to...
7253         (ppc_linux_nat_target::low_stopped_data_address): This. Add
7254         comment, use m_dreg_interface and m_thread_hw_breakpoints.
7255         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
7256         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
7257         comment.  Call low_stopped_data_address.
7258         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
7259         m_dreg_interface.
7260         (ppc_linux_nat_target::masked_watch_num_registers): Use
7261         m_dreg_interface.
7262         (ppc_linux_nat_target::copy_thread_dreg_state)
7263         (ppc_linux_nat_target::mark_thread_stale)
7264         (ppc_linux_nat_target::mark_debug_registers_changed)
7265         (ppc_linux_nat_target::register_hw_breakpoint)
7266         (ppc_linux_nat_target::clear_hw_breakpoint)
7267         (ppc_linux_nat_target::register_wp)
7268         (ppc_linux_nat_target::clear_wp)
7269         (ppc_linux_nat_target::init_arch_lwp_info)
7270         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
7271         (_initialize_ppc_linux_nat): Remove observer callback.
7272
7273 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7274
7275         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
7276         (ppc_linux_nat_target::auxv_parse)
7277         (ppc_linux_nat_target::read_description)
7278         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
7279         Move up.
7280
7281 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7282
7283         * linux-nat.h (low_new_clone): New method.
7284         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
7285
7286 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
7287
7288         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
7289         (dbx_expand_psymtab): ... this.
7290         (start_psymtab): Update.
7291         * mdebugread.c (psymtab_to_symtab_1): Rename to...
7292         (mdebug_expand_psymtab): ... this.
7293         (parse_partial_symbols): Update.
7294         (new_psymtab): Update.
7295         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
7296         (xcoff_expand_psymtab): ... this.
7297         (xcoff_start_psymtab): Update.
7298
7299 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
7300
7301         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
7302         <expand_dependencies>: ... this.
7303         * psymtab.c (partial_symtab::read_dependencies): Rename to...
7304         (partial_symtab::expand_dependencies): ... this.
7305         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
7306         Update.
7307         (dwarf2_psymtab::expand_psymtab): Update.
7308         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
7309         * mdebugread.c (psymtab_to_symtab_1): Update.
7310         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
7311
7312 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
7313
7314         * psympriv.h (discard_psymtab): Remove.
7315         * dbxread.c (dbx_end_psymtab): Update.
7316         * xcoffread.c (xcoff_end_psymtab): Update.
7317
7318 2020-03-28  Tom Tromey  <tom@tromey.com>
7319
7320         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
7321         comment.
7322
7323 2020-03-28  Tom Tromey  <tom@tromey.com>
7324
7325         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
7326
7327 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
7328
7329         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
7330
7331 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
7332
7333         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
7334
7335 2020-03-26  Tom Tromey  <tom@tromey.com>
7336
7337         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
7338         (mark_common_block_symbol_computed, read_tag_string_type)
7339         (attr_to_dynamic_prop, read_subrange_type): Update.
7340         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
7341         to be methods on struct attribute.
7342         (skip_one_die, process_imported_unit_die, read_namespace_alias)
7343         (read_call_site_scope, partial_die_info::read)
7344         (partial_die_info::read, lookup_die_type, follow_die_ref):
7345         Update.
7346         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
7347         from dwarf2_get_ref_die_offset.
7348         (attribute::constant_value): New method, from
7349         dwarf2_get_attr_constant_value.
7350         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
7351         Declare method.
7352         <constant_value>: New method.
7353
7354 2020-03-26  Tom Tromey  <tom@tromey.com>
7355
7356         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
7357         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
7358         (dwarf_type_encoding_name): Move to stringify.c.
7359         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
7360         * dwarf2/stringify.c: New file.
7361         * dwarf2/stringify.h: New file.
7362
7363 2020-03-26  Tom Tromey  <tom@tromey.com>
7364
7365         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
7366         Rewrite.
7367
7368 2020-03-26  Tom Tromey  <tom@tromey.com>
7369
7370         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
7371         methods.
7372         * dwarf2/read.c (lookup_addr_base): Move to die.h.
7373         (lookup_ranges_base): Likewise.
7374         (read_cutu_die_from_dwo, read_full_die_1): Update.
7375
7376 2020-03-26  Tom Tromey  <tom@tromey.com>
7377
7378         * dwarf2/read.c (read_import_statement, read_file_scope)
7379         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
7380         (read_lexical_block_scope, read_call_site_scope)
7381         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
7382         (handle_struct_member_die, process_structure_scope)
7383         (update_enumeration_type_from_children)
7384         (process_enumeration_scope, read_array_type, read_common_block)
7385         (read_namespace, read_module, read_subroutine_type): Update.
7386         (sibling_die): Remove.
7387
7388 2020-03-26  Tom Tromey  <tom@tromey.com>
7389
7390         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
7391         (build_type_psymtabs_reader, read_structure_type)
7392         (read_enumeration_type, read_full_die_1): Update.
7393         (dwarf2_attr_no_follow): Move to die.h.
7394         * dwarf2/die.h (struct die_info) <attr>: New method.
7395
7396 2020-03-26  Tom Tromey  <tom@tromey.com>
7397
7398         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
7399         <base_address>: Now an optional.
7400         (dwarf2_find_base_address, dwarf2_rnglists_process)
7401         (dwarf2_ranges_process, fill_in_loclist_baton)
7402         (dwarf2_symbol_mark_computed): Update.
7403
7404 2020-03-26  Tom Tromey  <tom@tromey.com>
7405
7406         * dwarf2/read.c (struct die_info): Move to die.h.
7407         * dwarf2/die.h: New file.
7408
7409 2020-03-26  Tom Tromey  <tom@tromey.com>
7410
7411         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
7412         * dwarf2/read.c
7413         (dwarf2_statement_list_fits_in_line_number_section_complaint):
7414         Move to line-header.c.
7415         (read_checked_initial_length_and_offset, read_formatted_entries):
7416         Likewise.
7417         (dwarf_decode_line_header): Split into two.
7418         * dwarf2/line-header.c
7419         (dwarf2_statement_list_fits_in_line_number_section_complaint):
7420         Move from read.c.
7421         (read_checked_initial_length_and_offset, read_formatted_entries):
7422         Likewise.
7423         (dwarf_decode_line_header): New function, split from read.c.
7424
7425 2020-03-26  Tom Tromey  <tom@tromey.com>
7426
7427         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
7428         Declare method.
7429         * dwarf2/read.c (read_attribute_value): Update.
7430         (dwarf2_per_objfile::read_line_string): Rename from
7431         read_indirect_line_string.
7432         (read_formatted_entries): Update.
7433
7434 2020-03-26  Tom Tromey  <tom@tromey.com>
7435
7436         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
7437         variable.
7438
7439 2020-03-26  Tom Tromey  <tom@tromey.com>
7440
7441         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
7442         const.
7443         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
7444         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
7445         parameter const.
7446
7447 2020-03-26  Tom Tromey  <tom@tromey.com>
7448
7449         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
7450         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
7451         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
7452         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
7453
7454 2020-03-26  Tom Tromey  <tom@tromey.com>
7455
7456         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
7457         file_names_size, file_full_name, file_file_name>: Use const.
7458         <file_name_at, file_names>: Add const overload.
7459         * dwarf2/line-header.c (line_header::file_file_name)
7460         (line_header::file_full_name): Update.
7461
7462 2020-03-26  Tom Tromey  <tom@tromey.com>
7463
7464         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
7465         (macro_start_file, consume_improper_spaces)
7466         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
7467         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
7468         (dwarf_decode_macros): Move to macro.c.
7469         * dwarf2/macro.c: New file.
7470         * dwarf2/macro.h: New file.
7471         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
7472
7473 2020-03-26  Tom Tromey  <tom@tromey.com>
7474
7475         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
7476         method.
7477         * dwarf2/section.c: New method.  From
7478         read_indirect_string_at_offset_from.
7479         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
7480         (read_indirect_string_at_offset_from): Move to section.c.
7481         (read_indirect_string_at_offset): Rewrite.
7482         (read_indirect_line_string_at_offset): Remove.
7483         (read_indirect_string, read_indirect_line_string)
7484         (dwarf_decode_macro_bytes): Update.
7485
7486 2020-03-26  Tom Tromey  <tom@tromey.com>
7487
7488         * dwarf2/section.h (struct dwarf2_section_info)
7489         <overload_complaint>: Declare.
7490         (dwarf2_section_buffer_overflow_complaint): Don't declare.
7491         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
7492         Rename from dwarf2_section_buffer_overflow_complaint.
7493         * dwarf2/read.c (skip_one_die, partial_die_info::read)
7494         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
7495
7496 2020-03-26  Tom Tromey  <tom@tromey.com>
7497
7498         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
7499         Declare.
7500         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
7501         Move from read.c.
7502         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
7503         to section.c.
7504
7505 2020-03-26  Tom Tromey  <tom@tromey.com>
7506
7507         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
7508
7509 2020-03-26  Tom Tromey  <tom@tromey.com>
7510
7511         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
7512         "builder".
7513         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
7514         parameter.
7515         (dwarf_decode_macros): Update.
7516
7517 2020-03-26  Tom Tromey  <tom@tromey.com>
7518
7519         * dwarf2/read.c (read_attribute_value): Update.
7520         (read_indirect_string_from_dwz): Move to dwz.c; change into
7521         method.
7522         (dwarf_decode_macro_bytes): Update.
7523         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
7524         * dwarf2/dwz.c: New file.
7525         * Makefile.in (COMMON_SFILES): Add dwz.c.
7526
7527 2020-03-26  Tom Tromey  <tom@tromey.com>
7528
7529         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
7530         * dwarf2/read.c: Add include.
7531         * dwarf2/index-write.c: Add include.
7532         * dwarf2/index-cache.c: Add include.
7533         * dwarf2/dwz.h: New file.
7534
7535 2020-03-25  Tom Tromey  <tom@tromey.com>
7536
7537         * compile/compile-object-load.c (get_out_value_type): Mention
7538         correct symbol name in error message.
7539
7540 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
7541
7542         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
7543
7544 2020-03-25  Tom de Vries  <tdevries@suse.de>
7545
7546         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
7547         * symmisc.c (dump_symtab_1): Print user and includes fields.
7548         (maintenance_info_symtabs): Same.
7549
7550 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
7551
7552         PR gdb/25534
7553         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
7554         (riscv_regcache_cooked_write): New function.
7555         (riscv_push_dummy_call): Use new function.
7556         (riscv_return_value): Likewise.
7557
7558 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
7559
7560         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
7561         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
7562         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
7563         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
7564         * infrun.c (follow_fork): Likewise.
7565         (follow_fork_inferior): Likewise.
7566         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
7567         * linux-nat.h (class linux_nat_target): Likewise.
7568         * remote.c (class remote_target) <follow_fork>: Likewise.
7569         (remote_target::follow_fork): Likewise.
7570         * target-delegates.c: Re-generate.
7571         * target.c (default_follow_fork): Likewise.
7572         (target_follow_fork): Likewise.
7573         * target.h (struct target_ops) <follow_fork>: Likewise.
7574         (target_follow_fork): Likewise.
7575
7576 2020-03-24  Tom de Vries  <tdevries@suse.de>
7577
7578         * psymtab.c (maintenance_info_psymtabs): Print user field.
7579
7580 2020-03-20  Tom Tromey  <tromey@adacore.com>
7581
7582         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
7583         const.
7584         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
7585         const.
7586
7587 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
7588
7589         * ptrace.m4: Don't check for ptrace declaration.
7590         * config.in: Re-generate.
7591         * configure: Re-generate.
7592         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
7593         not defined.
7594
7595 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7596
7597         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
7598         `PTRACE_TYPE_RET'.
7599         * i386-bsd-nat.c (gdb_ptrace): Likewise.
7600         * sparc-nat.c (gdb_ptrace): Likewise.
7601         * x86-bsd-nat.c (gdb_ptrace): Likewise.
7602
7603 2020-03-20  Tom Tromey  <tromey@adacore.com>
7604
7605         * c-exp.y (lex_one_token): Fix assert.
7606
7607 2020-03-20  Tom Tromey  <tromey@adacore.com>
7608
7609         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
7610         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
7611         strncpy call.
7612
7613 2020-03-20  Tom Tromey  <tromey@adacore.com>
7614
7615         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
7616
7617 2020-03-20  Tom Tromey  <tromey@adacore.com>
7618
7619         * ada-valprint.c (print_variant_part): Remove parameters; switch
7620         to value-based API.
7621         (print_field_values): Likewise.
7622         (ada_val_print_struct_union): Likewise.
7623         (ada_value_print_1): Update.
7624
7625 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7626
7627         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
7628         nbsd_nat_target instead of inf_ptrace_target.
7629         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7630         nbsd_nat_target.
7631
7632 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7633
7634         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
7635         it to the ptrace call.
7636         * (store_registers): Likewise.
7637
7638 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7639
7640         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
7641         it to the ptrace call.
7642         * (store_registers): Likewise.
7643
7644 2020-03-19  Luis Machado  <luis.machado@linaro.org>
7645
7646         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
7647         valid, fetch vg value from ptrace.
7648
7649 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
7650         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
7651         * inf-ptrace.c: Likewise.
7652         * (gdb_ptrace): Add.
7653         * (inf_ptrace_target::resume): Update.
7654         * (inf_ptrace_target::xfer_partial): Likewise.
7655         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
7656         * (inf_ptrace_peek_poke): Update.
7657
7658 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
7659
7660         * x86-bsd-nat.c (gdb_ptrace): New.
7661         * (x86bsd_dr_set): Add new argument `ptid'.
7662         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
7663         x86bsd_dr_set_addr): Update.
7664
7665 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7666
7667         * remote.c (remote_target::process_stop_reply): Handle events for
7668         all threads differently.
7669
7670 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7671
7672         * completer.c (completion_tracker::remove_completion): Define new
7673         function.
7674         * completer.h (completion_tracker::remove_completion): Declare new
7675         function.
7676         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
7677         when adding a C++ function symbol.
7678
7679 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7680
7681         * completer.c (completion_tracker::completion_hash_entry): Define
7682         new class.
7683         (advance_to_filename_complete_word_point): Call
7684         recompute_lowest_common_denominator.
7685         (completion_tracker::completion_tracker): Call discard_completions
7686         to setup the hash table.
7687         (completion_tracker::discard_completions): Allow for being called
7688         from the constructor, pass new equal function, and element deleter
7689         when constructing the hash table.  Initialise new class member
7690         variables.
7691         (completion_tracker::maybe_add_completion): Remove use of
7692         m_entries_vec, and store more information into m_entries_hash.
7693         (completion_tracker::recompute_lcd_visitor): New function, most
7694         content taken from...
7695         (completion_tracker::recompute_lowest_common_denominator):
7696         ...here, this now just visits each item in the hash calling the
7697         above visitor.
7698         (completion_tracker::build_completion_result): Remove use of
7699         m_entries_vec, call recompute_lowest_common_denominator.
7700         * completer.h (completion_tracker::have_completions): Remove use
7701         of m_entries_vec.
7702         (completion_tracker::completion_hash_entry): Declare new class.
7703         (completion_tracker::recompute_lowest_common_denominator): Change
7704         function signature.
7705         (completion_tracker::recompute_lcd_visitor): Declare new function.
7706         (completion_tracker::m_entries_vec): Delete.
7707         (completion_tracker::m_entries_hash): Initialize to NULL.
7708         (completion_tracker::m_lowest_common_denominator_valid): New
7709         member variable.
7710         (completion_tracker::m_lowest_common_denominator_max_length): New
7711         member variable.
7712
7713 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7714
7715         * regformats/regdef.h: Put reg in gdb namespace.
7716
7717 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7718
7719         * i386-bsd-nat.c (gdb_ptrace): New.
7720         * (i386bsd_fetch_inferior_registers,
7721         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
7722         * (i386bsd_fetch_inferior_registers,
7723         i386bsd_store_inferior_registers) Use gdb_ptrace.
7724
7725 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7726
7727         * amd64-bsd-nat.c (gdb_ptrace): New.
7728         * (amd64bsd_fetch_inferior_registers,
7729         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
7730         * (amd64bsd_fetch_inferior_registers,
7731         amd64bsd_store_inferior_registers) Use gdb_ptrace.
7732
7733 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7734
7735         * user-regs.c (user_reg::read): Rename to...
7736         (user_reg::xread): ...this.
7737         * (append_user_reg): Rename argument `read' to `xread'.
7738         * (user_reg_add_builtin): Likewise.
7739         * (user_reg_add): Likewise.
7740         * (value_of_user_reg): Likewise.
7741
7742 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7743
7744         * sparc-nat.c (gdb_ptrace): New.
7745         * sparc-nat.c (sparc_fetch_inferior_registers)
7746         (sparc_store_inferior_registers) Remove obsolete comment.
7747         * sparc-nat.c (sparc_fetch_inferior_registers)
7748         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
7749         * sparc-nat.c (sparc_fetch_inferior_registers)
7750         (sparc_store_inferior_registers) Use gdb_ptrace.
7751
7752 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7753
7754         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
7755         it to the ptrace call.
7756         * sh-nbsd-nat.c (store_registers): Likewise.
7757
7758 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7759
7760         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
7761         nbsd_nat_target instead of inf_ptrace_target.
7762         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7763         nbsd_nat_target.
7764
7765 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7766
7767         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
7768
7769 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7770
7771         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
7772         <sys/sysctl.h>.
7773         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
7774
7775 2020-03-17  Tom de Vries  <tdevries@suse.de>
7776
7777         PR gdb/23710
7778         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
7779         fields.
7780         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
7781         fields.
7782         (process_imported_unit_die): Skip import of c++ CUs.
7783
7784 2020-03-16  Tom Tromey  <tom@tromey.com>
7785
7786         * p-valprint.c (pascal_object_print_value): Initialize
7787         base_value.
7788
7789 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
7790             Shahab Vahedi  <shahab@synopsys.com>
7791
7792         * Makefile.in: Add arch/arc.o
7793         * configure.tgt: Likewise.
7794         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
7795         (_initialize_arc_tdep): Don't initialize old target descriptions.
7796         (arc_read_description): New function to cache target descriptions.
7797         * arc-tdep.h (arc_read_description): Add proto type.
7798         * arch/arc.c: New file.
7799         * arch/arc.h: Likewise.
7800         * features/Makefile: Replace old target descriptions with new.
7801         * features/arc-arcompact.c: Remove.
7802         * features/arc-arcompact.xml: Likewise.
7803         * features/arc-v2.c: Likewise
7804         * features/arc-v2.xml: Likewise
7805         * features/arc/aux-arcompact.xml: New file.
7806         * features/arc/aux-v2.xml: Likewise.
7807         * features/arc/core-arcompact.xml: Likewise.
7808         * features/arc/core-v2.xml: Likewise.
7809         * features/arc/aux-arcompact.c: Generate.
7810         * features/arc/aux-v2.c: Likewise.
7811         * features/arc/core-arcompact.c: Likewise.
7812         * features/arc/core-v2.c: Likewise.
7813         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
7814
7815 2020-03-16  Tom Tromey  <tromey@adacore.com>
7816
7817         PR gdb/25663:
7818         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
7819         putting value into bcache.
7820
7821 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7822
7823         PR gdb/21500
7824         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
7825         to...
7826         (amd64_windows_init_abi_common): ... this.  Don't set size of
7827         long type.
7828         (amd64_windows_init_abi): New function.
7829         (amd64_cygwin_init_abi): New function.
7830         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
7831         the Cygwin OS ABI.
7832         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
7833         comment.
7834
7835 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7836
7837         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
7838         * windows-tdep.c (CYGWIN_DLL_NAME): New.
7839         (pe_import_directory_entry): New struct type.
7840         (is_linked_with_cygwin_dll): New function.
7841         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
7842         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
7843         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
7844
7845 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7846
7847         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
7848         i386_cygwin_core_osabi_sniffer.
7849
7850 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7851
7852         * i386-cygwin-tdep.c: Rename to...
7853         * i386-windows-tdep.c: ... this.
7854         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
7855         i386-windows-tdep.c.
7856         * configure.tgt: Likewise.
7857
7858 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7859
7860         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
7861         * osabi.c (gdb_osabi_names): Add "Windows".
7862         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
7863         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
7864         (i386_cygwin_core_osabi_sniffer): New function, extracted from
7865         i386_cygwin_osabi_sniffer.
7866         (_initialize_i386_cygwin_tdep): Register OS ABI
7867         GDB_OSABI_WINDOWS for i386.
7868         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
7869         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
7870         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
7871         for x86-64.
7872         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
7873         when the target matches '*-*-mingw*'.
7874
7875 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7876
7877         * defs.h (enum gdb_osabi): Move to...
7878         * osabi.h (enum gdb_osabi): ... here.
7879         * gdbarch.sh: Include osabi.h in gdbarch.h.
7880         * gdbarch.h: Re-generate.
7881
7882 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7883
7884         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
7885         function.
7886         (_initialize_amd64_windows_tdep): Register osabi sniffer.
7887
7888 2020-03-14  Tom Tromey  <tom@tromey.com>
7889
7890         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
7891         for C++.
7892         (c_type_print_modifier): Likewise.  Add "language" parameter.
7893         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
7894         (c_type_print_base_1): Update.
7895         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
7896         constants.
7897         * type-stack.c (type_stack::insert): Handle tp_atomic and
7898         tp_restrict.
7899         (type_stack::follow_type_instance_flags): Likewise.
7900         (type_stack::follow_types): Likewise.  Merge type-following code.
7901         * c-exp.y (RESTRICT, ATOMIC): New tokens.
7902         (space_identifier, cv_with_space_id)
7903         (const_or_volatile_or_space_identifier_noopt)
7904         (const_or_volatile_or_space_identifier): Remove.
7905         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
7906         rules.
7907         (ptr_operator, typebase): Update.
7908         (enum token_flag) <FLAG_C>: New constant.
7909         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
7910         "_Atomic".
7911         (lex_one_token): Handle FLAG_C.
7912
7913 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7914
7915         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
7916         it to the ptrace call.
7917         * m68k-bsd-nat.c (store_registers): Likewise.
7918
7919 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7920
7921         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
7922         gdb_byte *.
7923         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
7924         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
7925         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
7926
7927 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7928
7929         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
7930         nbsd_nat_target instead of inf_ptrace_target.
7931         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7932         nbsd_nat_target.
7933
7934 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7935
7936         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
7937         register_t.
7938
7939 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7940
7941         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
7942         it to the ptrace call.
7943         * alpha-bsd-nat.c (store_registers): Likewise.
7944
7945 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7946
7947         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
7948         includes.
7949         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
7950         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
7951         fill_fpregset): Likewise.
7952
7953 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7954
7955         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
7956         nbsd_nat_target instead of inf_ptrace_target.
7957         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7958         nbsd_nat_target.
7959
7960 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7961
7962         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
7963         register_t.
7964
7965 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7966
7967         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
7968         it to the ptrace call.
7969         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
7970         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
7971         * arm-nbsd-nat.c (store_register): Likewise.
7972         * arm-nbsd-nat.c (store_regs): Likewise.
7973         * arm-nbsd-nat.c (store_fp_register): Likewise.
7974         * arm-nbsd-nat.c (store_fp_regs): Likewise.
7975
7976 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7977
7978         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
7979         nbsd_nat_target instead of inf_ptrace_target.
7980         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7981         nbsd_nat_target.
7982
7983 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7984
7985         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
7986         it to the ptrace call.
7987         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
7988
7989 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7990
7991         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
7992         it to the ptrace call.
7993         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
7994
7995 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7996
7997         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
7998         gdb_byte *.
7999         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
8000
8001 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8002
8003         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
8004         instead of inf_ptrace_target.
8005         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
8006         nbsd_nat_target.
8007
8008 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8009
8010         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8011         register_t.
8012
8013 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8014
8015         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8016         register_t.
8017
8018 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8019
8020         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
8021         register_t.
8022
8023 2020-03-13  Tom Tromey  <tom@tromey.com>
8024
8025         * value.h (val_print): Don't declare.
8026         * valprint.h (val_print_array_elements)
8027         (val_print_scalar_formatted, generic_val_print): Don't declare.
8028         * valprint.c (generic_val_print_array): Take a struct value.
8029         (generic_val_print_ptr, generic_val_print_memberptr)
8030         (generic_val_print_bool, generic_val_print_int)
8031         (generic_val_print_char, generic_val_print_complex)
8032         (generic_val_print): Remove.
8033         (generic_value_print): Update.
8034         (do_val_print): Remove unused parameters.  Don't call
8035         la_val_print.
8036         (val_print): Remove.
8037         (common_val_print): Update.  Don't call value_check_printable.
8038         (val_print_scalar_formatted, val_print_array_elements): Remove.
8039         * rust-lang.c (rust_val_print): Remove.
8040         (rust_language_defn): Update.
8041         * p-valprint.c (pascal_val_print): Remove.
8042         (pascal_value_print_inner): Update.
8043         (pascal_object_print_val_fields, pascal_object_print_val):
8044         Remove.
8045         (pascal_object_print_static_field): Update.
8046         * p-lang.h (pascal_val_print): Don't declare.
8047         * p-lang.c (pascal_language_defn): Update.
8048         * opencl-lang.c (opencl_language_defn): Update.
8049         * objc-lang.c (objc_language_defn): Update.
8050         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
8051         * m2-lang.h (m2_val_print): Don't declare.
8052         * m2-lang.c (m2_language_defn): Update.
8053         * language.h (struct language_defn) <la_val_print>: Remove.
8054         * language.c (unk_lang_value_print_inner): Rename.  Change
8055         argument types.
8056         (unknown_language_defn, auto_language_defn): Update.
8057         * go-valprint.c (go_val_print): Remove.
8058         * go-lang.h (go_val_print): Don't declare.
8059         * go-lang.c (go_language_defn): Update.
8060         * f-valprint.c (f_val_print): Remove.
8061         * f-lang.h (f_value_print): Don't declare.
8062         * f-lang.c (f_language_defn): Update.
8063         * d-valprint.c (d_val_print): Remove.
8064         * d-lang.h (d_value_print): Don't declare.
8065         * d-lang.c (d_language_defn): Update.
8066         * cp-valprint.c (cp_print_value_fields)
8067         (cp_print_value_fields_rtti, cp_print_value): Remove.
8068         (cp_print_static_field): Update.
8069         * c-valprint.c (c_val_print_array, c_val_print_ptr)
8070         (c_val_print_struct, c_val_print_union, c_val_print_int)
8071         (c_val_print_memberptr, c_val_print): Remove.
8072         * c-lang.h (c_val_print_array, cp_print_value_fields)
8073         (cp_print_value_fields_rtti): Don't declare.
8074         * c-lang.c (c_language_defn, cplus_language_defn)
8075         (asm_language_defn, minimal_language_defn): Update.
8076         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
8077         (ada_val_print_enum): Take a struct value.
8078         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
8079         (ada_val_print): Remove.
8080         (ada_value_print_1): Update.
8081         (printable_val_type): Remove.
8082         * ada-lang.h (ada_val_print): Don't declare.
8083         * ada-lang.c (ada_language_defn): Update.
8084
8085 2020-03-13  Tom Tromey  <tom@tromey.com>
8086
8087         * valprint.c (do_val_print): Update.
8088         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
8089         a struct value.
8090         (value_to_value_object_no_release): Declare.
8091         * python/py-value.c (value_to_value_object_no_release): New
8092         function.
8093         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
8094         struct value.
8095         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
8096         function.
8097         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
8098         a struct value.
8099         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
8100         Declare.
8101         (gdbscm_apply_val_pretty_printer): Take a struct value.
8102         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
8103         value.
8104         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
8105         value.
8106         * extension-priv.h (struct extension_language_ops)
8107         <apply_val_pretty_printer>: Take a struct value.
8108         * cp-valprint.c (cp_print_value): Create a struct value.
8109         (cp_print_value): Update.
8110
8111 2020-03-13  Tom Tromey  <tom@tromey.com>
8112
8113         * ada-valprint.c (print_field_values): Call common_val_print.
8114
8115 2020-03-13  Tom Tromey  <tom@tromey.com>
8116
8117         * ada-valprint.c (val_print_packed_array_elements): Remove
8118         bitoffset and val parameters.  Call common_val_print.
8119         (ada_val_print_string): Remove offset, address, and original_value
8120         parameters.
8121         (ada_val_print_array): Update.
8122         (ada_value_print_array): New function.
8123         (ada_value_print_1): Call it.
8124
8125 2020-03-13  Tom Tromey  <tom@tromey.com>
8126
8127         * ada-valprint.c (ada_value_print): Use common_val_print.
8128
8129 2020-03-13  Tom Tromey  <tom@tromey.com>
8130
8131         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
8132
8133 2020-03-13  Tom Tromey  <tom@tromey.com>
8134
8135         * ada-valprint.c (ada_value_print_num): New function.
8136         (ada_value_print_1): Use it.
8137
8138 2020-03-13  Tom Tromey  <tom@tromey.com>
8139
8140         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
8141
8142 2020-03-13  Tom Tromey  <tom@tromey.com>
8143
8144         * ada-valprint.c (ada_value_print_ptr): New function.
8145         (ada_value_print_1): Use it.
8146
8147 2020-03-13  Tom Tromey  <tom@tromey.com>
8148
8149         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
8150         call common_val_print.
8151         (ada_val_print_1): Update.
8152         (ada_value_print_1): New function.
8153         (ada_value_print_inner): Rewrite.
8154
8155 2020-03-13  Tom Tromey  <tom@tromey.com>
8156
8157         * cp-valprint.c (cp_print_value_fields): Update.
8158         (cp_print_value): New function.
8159
8160 2020-03-13  Tom Tromey  <tom@tromey.com>
8161
8162         * m2-valprint.c (m2_value_print_inner): Use
8163         cp_print_value_fields.
8164         * cp-valprint.c (cp_print_value_fields): New function.
8165         * c-valprint.c (c_value_print_struct): New function.
8166         (c_value_print_inner): Use c_value_print_struct.
8167         * c-lang.h (cp_print_value_fields): Declare.
8168
8169 2020-03-13  Tom Tromey  <tom@tromey.com>
8170
8171         * c-valprint.c (c_value_print_array): New function.
8172         (c_value_print_inner): Use it.
8173
8174 2020-03-13  Tom Tromey  <tom@tromey.com>
8175
8176         * c-valprint.c (c_value_print_memberptr): New function.
8177         (c_value_print_inner): Use it.
8178
8179 2020-03-13  Tom Tromey  <tom@tromey.com>
8180
8181         * c-valprint.c (c_value_print_int): New function.
8182         (c_value_print_inner): Use it.
8183
8184 2020-03-13  Tom Tromey  <tom@tromey.com>
8185
8186         * c-valprint.c (c_value_print_ptr): New function.
8187         (c_value_print_inner): Use it.
8188
8189 2020-03-13  Tom Tromey  <tom@tromey.com>
8190
8191         * c-valprint.c (c_value_print_inner): Rewrite.
8192
8193 2020-03-13  Tom Tromey  <tom@tromey.com>
8194
8195         * valprint.c (generic_value_print_complex): New function.
8196         (generic_value_print): Use it.
8197
8198 2020-03-13  Tom Tromey  <tom@tromey.com>
8199
8200         * valprint.c (generic_val_print_float): Don't call
8201         val_print_scalar_formatted.
8202         (generic_val_print, generic_value_print): Update.
8203
8204 2020-03-13  Tom Tromey  <tom@tromey.com>
8205
8206         * valprint.c (generic_value_print_char): New function
8207         (generic_value_print): Use it.
8208
8209 2020-03-13  Tom Tromey  <tom@tromey.com>
8210
8211         * valprint.c (generic_value_print_int): New function.
8212         (generic_value_print): Use it.
8213
8214 2020-03-13  Tom Tromey  <tom@tromey.com>
8215
8216         * valprint.c (generic_value_print_bool): New function.
8217         (generic_value_print): Use it.
8218
8219 2020-03-13  Tom Tromey  <tom@tromey.com>
8220
8221         * valprint.c (generic_val_print_func): Simplify.
8222         (generic_val_print, generic_value_print): Update.
8223
8224 2020-03-13  Tom Tromey  <tom@tromey.com>
8225
8226         * valprint.c (generic_val_print_flags): Remove.
8227         (generic_val_print, generic_value_print): Update.
8228         (val_print_type_code_flags): Add original_value parameter.
8229
8230 2020-03-13  Tom Tromey  <tom@tromey.com>
8231
8232         * valprint.c (generic_val_print): Update.
8233         (generic_value_print): Update.
8234         * valprint.c (generic_val_print_enum): Don't call
8235         val_print_scalar_formatted.
8236
8237 2020-03-13  Tom Tromey  <tom@tromey.com>
8238
8239         * valprint.c (generic_value_print): Call generic_value_print_ptr.
8240         * valprint.c (generic_value_print_ptr): New function.
8241
8242 2020-03-13  Tom Tromey  <tom@tromey.com>
8243
8244         * valprint.c (generic_value_print): Rewrite.
8245
8246 2020-03-13  Tom Tromey  <tom@tromey.com>
8247
8248         * p-valprint.c (pascal_object_print_value_fields)
8249         (pascal_object_print_value): New functions.
8250
8251 2020-03-13  Tom Tromey  <tom@tromey.com>
8252
8253         * p-valprint.c (pascal_value_print_inner): Rewrite.
8254
8255 2020-03-13  Tom Tromey  <tom@tromey.com>
8256
8257         * f-valprint.c (f_value_print_innner): Rewrite.
8258
8259 2020-03-13  Tom Tromey  <tom@tromey.com>
8260
8261         * m2-valprint.c (m2_print_unbounded_array): New overload.
8262         (m2_print_unbounded_array): Update.
8263         (m2_print_array_contents): Take a struct value.
8264         (m2_value_print_inner): Rewrite.
8265
8266 2020-03-13  Tom Tromey  <tom@tromey.com>
8267
8268         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
8269         (d_value_print_inner): New function.
8270         * d-lang.h (d_value_print_inner): Declare.
8271         * d-lang.c (d_language_defn): Use d_value_print_inner.
8272
8273 2020-03-13  Tom Tromey  <tom@tromey.com>
8274
8275         * go-valprint.c (go_value_print_inner): New function.
8276         * go-lang.h (go_value_print_inner): Declare.
8277         * go-lang.c (go_language_defn): Use go_value_print_inner.
8278
8279 2020-03-13  Tom Tromey  <tom@tromey.com>
8280
8281         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
8282         API.
8283         (rust_val_print): Rewrite.
8284         (rust_value_print_inner): New function, from rust_val_print.
8285         (rust_language_defn): Use rust_value_print_inner.
8286
8287 2020-03-13  Tom Tromey  <tom@tromey.com>
8288
8289         * ada-valprint.c (ada_value_print_inner): New function.
8290         * ada-lang.h (ada_value_print_inner): Declare.
8291         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
8292
8293 2020-03-13  Tom Tromey  <tom@tromey.com>
8294
8295         * f-valprint.c (f_value_print_innner): New function.
8296         * f-lang.h (f_value_print_innner): Declare.
8297         * f-lang.c (f_language_defn): Use f_value_print_innner.
8298
8299 2020-03-13  Tom Tromey  <tom@tromey.com>
8300
8301         * p-valprint.c (pascal_value_print_inner): New function.
8302         * p-lang.h (pascal_value_print_inner): Declare.
8303         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
8304
8305 2020-03-13  Tom Tromey  <tom@tromey.com>
8306
8307         * m2-valprint.c (m2_value_print_inner): New function.
8308         * m2-lang.h (m2_value_print_inner): Declare.
8309         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
8310
8311 2020-03-13  Tom Tromey  <tom@tromey.com>
8312
8313         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
8314         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
8315         * c-valprint.c (c_value_print_inner): New function.
8316         * c-lang.h (c_value_print_inner): Declare.
8317         * c-lang.c (c_language_defn, cplus_language_defn)
8318         (asm_language_defn, minimal_language_defn): Use
8319         c_value_print_inner.
8320
8321 2020-03-13  Tom Tromey  <tom@tromey.com>
8322
8323         * p-valprint.c (pascal_object_print_value_fields): Now static.
8324         * p-lang.h (pascal_object_print_value_fields): Don't declare.
8325
8326 2020-03-13  Tom Tromey  <tom@tromey.com>
8327
8328         * c-valprint.c (c_val_print_array): Simplify.
8329
8330 2020-03-13  Tom Tromey  <tom@tromey.com>
8331
8332         * valprint.c (value_print_array_elements): New function.
8333         * valprint.h (value_print_array_elements): Declare.
8334
8335 2020-03-13  Tom Tromey  <tom@tromey.com>
8336
8337         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
8338         * mips-tdep.c (mips_print_register): Use
8339         value_print_scalar_formatted.
8340
8341 2020-03-13  Tom Tromey  <tom@tromey.com>
8342
8343         * valprint.h (value_print_scalar_formatted): Declare.
8344         * valprint.c (value_print_scalar_formatted): New function.
8345
8346 2020-03-13  Tom Tromey  <tom@tromey.com>
8347
8348         * valprint.h (generic_value_print): Declare.
8349         * valprint.c (generic_value_print): New function.
8350
8351 2020-03-13  Tom Tromey  <tom@tromey.com>
8352
8353         * valprint.c (do_val_print): Call la_value_print_inner, if
8354         available.
8355         * rust-lang.c (rust_language_defn): Update.
8356         * p-lang.c (pascal_language_defn): Update.
8357         * opencl-lang.c (opencl_language_defn): Update.
8358         * objc-lang.c (objc_language_defn): Update.
8359         * m2-lang.c (m2_language_defn): Update.
8360         * language.h (struct language_defn) <la_value_print_inner>: New
8361         member.
8362         * language.c (unknown_language_defn, auto_language_defn): Update.
8363         * go-lang.c (go_language_defn): Update.
8364         * f-lang.c (f_language_defn): Update.
8365         * d-lang.c (d_language_defn): Update.
8366         * c-lang.c (c_language_defn, cplus_language_defn)
8367         (asm_language_defn, minimal_language_defn): Update.
8368         * ada-lang.c (ada_language_defn): Update.
8369
8370 2020-03-13  Tom Tromey  <tom@tromey.com>
8371
8372         * c-valprint.c (c_value_print): Use common_val_print.
8373
8374 2020-03-13  Tom Tromey  <tom@tromey.com>
8375
8376         * cp-valprint.c (cp_print_static_field): Use common_val_print.
8377
8378 2020-03-13  Tom Tromey  <tom@tromey.com>
8379
8380         * f-valprint.c (f77_print_array_1, f_val_print): Use
8381         common_val_print.
8382
8383 2020-03-13  Tom Tromey  <tom@tromey.com>
8384
8385         * riscv-tdep.c (riscv_print_one_register_info): Use
8386         common_val_print.
8387
8388 2020-03-13  Tom Tromey  <tom@tromey.com>
8389
8390         * mi/mi-main.c (output_register): Use common_val_print.
8391
8392 2020-03-13  Tom Tromey  <tom@tromey.com>
8393
8394         * infcmd.c (default_print_one_register_info): Use
8395         common_val_print.
8396
8397 2020-03-13  Tom Tromey  <tom@tromey.com>
8398
8399         * valprint.h (common_val_print_checked): Declare.
8400         * valprint.c (common_val_print_checked): New function.
8401         * stack.c (print_frame_arg): Use common_val_print_checked.
8402
8403 2020-03-13  Tom Tromey  <tom@tromey.com>
8404
8405         * valprint.c (do_val_print): New function, from val_print.
8406         (val_print): Use do_val_print.
8407         (common_val_print): Use do_val_print.
8408
8409 2020-03-13  Tom Tromey  <tom@tromey.com>
8410
8411         * valprint.c (value_print): Use scoped_value_mark.
8412
8413 2020-03-13  Tom de Vries  <tdevries@suse.de>
8414
8415         PR symtab/25646
8416         * psymtab.c (partial_symtab::partial_symtab): Don't set
8417         globals_offset and statics_offset.  Push element onto
8418         current_global_psymbols and current_static_psymbols stacks.
8419         (concat): New function.
8420         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
8421         element from current_global_psymbols and current_static_psymbols
8422         stacks.  Concat popped elements to global_psymbols and
8423         static_symbols.
8424         (add_psymbol_to_list): Use current_global_psymbols and
8425         current_static_psymbols stacks.
8426         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
8427         current_static_psymbols fields.
8428
8429 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
8430
8431         * corelow.c (sniff_core_bfd): Remove.
8432         (class core_target) <m_core_vec>: Remove.
8433         (core_target::core_target): Update.
8434         (core_file_fns): Remove.
8435         (deprecated_add_core_fns): Remove.
8436         (default_core_sniffer): Remove.
8437         (sniff_core_bfd): Remove.
8438         (default_check_format): Remove.
8439         (gdb_check_format): Remove.
8440         (core_target_open): Update.
8441         (core_target::get_core_register_section): Update.
8442         (get_core_registers_cb): Update.
8443         (core_target::fetch_registers): Update.
8444         * gdbcore.h (struct core_fns): Remove.
8445         (deprecated_add_core_fns): Remove.
8446         (default_core_sniffer): Remove.
8447         (default_check_format): Remove.
8448
8449 2020-03-12  Tom Tromey  <tom@tromey.com>
8450
8451         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
8452         CORE_ADDR.
8453         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
8454
8455 2020-03-12  Tom Tromey  <tom@tromey.com>
8456
8457         * remote.c (remote_target::download_tracepoint)
8458         (remote_target::enable_tracepoint)
8459         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
8460         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
8461         sprintf_vma.
8462
8463 2020-03-12  Tom Tromey  <tom@tromey.com>
8464
8465         * symfile-mem.c: Update CORE_ADDR size assert.
8466
8467 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8468
8469         * selftest.m4: Move to gdbsupport/.
8470         * acinclude.m4: Update path to selftest.m4.
8471
8472 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8473
8474         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
8475         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
8476         gdbarch-selfselftests.c and selftest-arch.c.
8477         (SUBDIR_UNITTESTS_OBS): Rename to...
8478         (SELFTESTS_OBS): ... this.
8479         (COMMON_SFILES): Remove disasm-selftests.c and
8480         gdbarch-selftests.c.
8481         * configure.ac: Don't add selftest-arch.{c,o} to
8482         CONFIG_{SRCS,OBS}.
8483         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
8484         preprocessor conditions.
8485
8486 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8487
8488         * configure.ac: Don't source bfd/development.sh.
8489         * selftest.m4: Modify comment.
8490         * configure: Re-generate.
8491
8492 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8493
8494         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
8495         not "true" or "false".
8496         * configure: Re-generate.
8497
8498 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
8499
8500         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
8501         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
8502         renamed to arm_nbsd_supply_gregset.
8503         (fetch_register): Update to call arm_nbsd_supply_gregset.
8504         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
8505         (arm_netbsd_nat_target::fetch_registers): Update.
8506         (fetch_elfcore_registers): Removed.
8507         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
8508         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
8509         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
8510         not require NetBSD system headers.
8511         (arm_nbsd_regset): New struct.
8512         (arm_nbsd_iterate_over_regset_sections): New function.
8513         (arm_netbsd_init_abi_common): Updated to call
8514         set_gdbarch_iterate_over_regset_sections.
8515         * arm-nbsd-tdep.h: New file.
8516
8517 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
8518
8519         * symtab.c (find_pc_sect_line): Add check which prevents infinite
8520         recursion.
8521
8522 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
8523
8524         * configure: Re-generate.
8525
8526 2020-03-11  Tom Tromey  <tromey@adacore.com>
8527
8528         * ada-typeprint.c (print_choices): Fix comment.
8529
8530 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8531
8532         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
8533         previous item in the list, when the list has no items.
8534
8535 2020-03-11  Tom de Vries  <tdevries@suse.de>
8536
8537         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
8538         PROP_LOCLIST handling code.
8539
8540 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8541
8542         * buildsym-legacy.c (record_line): Pass extra parameter to
8543         record_line.
8544         * buildsym.c (buildsym_compunit::record_line): Take an extra
8545         parameter, reduce duplication in the line table, and record the
8546         is_stmt flag in the line table.
8547         * buildsym.h (buildsym_compunit::record_line): Add extra
8548         parameter.
8549         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
8550         non-statement lines.
8551         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
8552         this to the symtab builder.
8553         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
8554         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
8555         through to dwarf_record_line_1.
8556         * infrun.c (process_event_stop_test): When stepping, don't stop at
8557         a non-statement instruction, and only refresh the step info when
8558         we land in the middle of a line's range.  Also add an extra
8559         comment.
8560         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
8561         field.
8562         * record-btrace.c (btrace_find_line_range): Only record lines
8563         marked as is-statement.
8564         * stack.c (frame_show_address): Show the frame address if we are
8565         in a non-statement sal.
8566         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
8567         (maintenance_print_one_line_table): Print a header for the is_stmt
8568         column, and include is_stmt information in the output.
8569         * symtab.c (find_pc_sect_line): Find lines marked as statements in
8570         preference to non-statements.
8571         (find_pcs_for_symtab_line): Prefer is-statement entries.
8572         (find_line_common): Likewise.
8573         * symtab.h (struct linetable_entry): Add is_stmt field.
8574         (struct symtab_and_line): Likewise.
8575         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
8576         arranging the line table.
8577
8578 2020-03-07  Tom de Vries  <tdevries@suse.de>
8579
8580         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
8581         DIE.
8582
8583 2020-03-07  Tom Tromey  <tom@tromey.com>
8584
8585         * valops.c (value_literal_complex): Remove obsolete comment.
8586         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
8587         comment.
8588
8589 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
8590
8591         * infrun.h: Forward-declare thread_info.
8592         (set_step_info): Add thread_info parameter, add doc.
8593         * infrun.c (set_step_info): Add thread_info parameter, move doc
8594         to header.
8595         * infrun.c (process_event_stop_test): Pass thread to
8596         set_step_info call.
8597         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
8598         set_step_info.
8599         (prepare_one_step): Add thread_info parameter, pass it to
8600         set_step_frame and prepare_one_step (recursive) call.
8601         (step_1): Pass thread to prepare_one_step call.
8602         (step_command_fsm::should_stop): Pass thread to
8603         prepare_one_step.
8604         (until_next_fsm): Pass thread to set_step_frame call.
8605         (finish_command): Pass thread to set_step_info call.
8606
8607 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
8608
8609         * windows-tdep.c (windows_solib_create_inferior_hook):
8610         Check if inferior is running.
8611
8612 2020-03-06  Tom de Vries  <tdevries@suse.de>
8613
8614         * NEWS: Fix "the the".
8615         * ctfread.c: Same.
8616
8617 2020-03-06  Tom de Vries  <tdevries@suse.de>
8618
8619         * psymtab.c (psymtab_to_symtab): Don't print "done.".
8620
8621 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8622
8623         * .dir-locals.el: Add a comment referencing the other copies of
8624         this file.
8625
8626 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
8627
8628         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
8629         psargs.
8630
8631 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
8632
8633         * .gitattributes: New file.
8634
8635 2020-03-04  Tom Tromey  <tom@tromey.com>
8636
8637         * symmisc.c (print_symbol_bcache_statistics)
8638         (print_objfile_statistics): Update.
8639         * symfile.c (allocate_symtab): Use intern.
8640         * psymtab.c (partial_symtab::partial_symtab): Use intern.
8641         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8642         macro_cache>: Remove.
8643         <string_cache>: New member.
8644         (struct objfile) <intern>: New methods.
8645         * elfread.c (elf_symtab_read): Use intern.
8646         * dwarf2/read.c (fixup_go_packaging): Intern package name.
8647         (dwarf2_compute_name, dwarf2_physname)
8648         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
8649         names.
8650         (guess_partial_die_structure_name): Update.
8651         (partial_die_info::fixup): Intern name.
8652         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
8653         name.
8654         (dwarf2_name): Intern name.  Update.
8655         * buildsym.c (buildsym_compunit::get_macro_table): Use
8656         string_cache.
8657
8658 2020-03-04  Tom Tromey  <tom@tromey.com>
8659
8660         * jit.c (bfd_open_from_target_memory): Make "target" const.
8661         * corefile.c (gnutarget): Now const.
8662         * gdbcore.h (gnutarget): Now const.
8663
8664 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
8665
8666         * NEWS: Mention support for WOW64 processes.
8667         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
8668         (amd64_windows_segment_register_p): Remove static.
8669         (_initialize_amd64_windows_nat): Update.
8670         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
8671         * i386-windows-nat.c (context_offset): Update.
8672         (i386_mappings): Rename and remove static.
8673         (i386_windows_segment_register_p): Remove static.
8674         (_initialize_i386_windows_nat): Update.
8675         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
8676         (STATUS_WX86_SINGLE_STEP): New macro.
8677         (EnumProcessModulesEx): New macro.
8678         (Wow64SuspendThread): New macro.
8679         (Wow64GetThreadContext): New macro.
8680         (Wow64SetThreadContext): New macro.
8681         (Wow64GetThreadSelectorEntry): New macro.
8682         (windows_set_context_register_offsets): Add static.
8683         (windows_set_segment_register_p): Likewise.
8684         (windows_add_thread): Adapt for WOW64 processes.
8685         (windows_fetch_one_register): Likewise.
8686         (windows_nat_target::fetch_registers): Likewise.
8687         (windows_store_one_register): Likewise.
8688         (display_selector): Likewise.
8689         (display_selectors): Likewise.
8690         (handle_exception): Likewise.
8691         (windows_continue): Likewise.
8692         (windows_nat_target::resume): Likewise.
8693         (windows_add_all_dlls): Likewise.
8694         (do_initial_windows_stuff): Likewise.
8695         (windows_nat_target::attach): Likewise.
8696         (windows_get_exec_module_filename): Likewise.
8697         (windows_nat_target::create_inferior): Likewise.
8698         (windows_xfer_siginfo): Likewise.
8699         (_initialize_loadable): Initialize Wow64SuspendThread,
8700         Wow64GetThreadContext, Wow64SetThreadContext,
8701         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
8702         * windows-nat.h (windows_set_context_register_offsets):
8703         Remove declaration.
8704         (windows_set_segment_register_p): Likewise.
8705         (i386_windows_segment_register_p): Add declaration.
8706         (amd64_windows_segment_register_p): Likewise.
8707
8708 2020-03-04  Luis Machado  <luis.machado@linaro.org>
8709
8710         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
8711         in "info registers" for AArch64/ARM.
8712
8713         The change caused "info registers" to not print GPR's.
8714
8715         gdb/ChangeLog:
8716
8717         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8718
8719         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8720         when reg->group is empty and reggroup is not.
8721
8722 2020-03-03  Tom Tromey  <tromey@adacore.com>
8723
8724         * dwarf2/frame.c (struct dwarf2_frame_cache)
8725         <checked_tailcall_bottom, entry_cfa_sp_offset,
8726         entry_cfa_sp_offset_p>: Remove members.
8727         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
8728         (dwarf2_frame_prev_register): Don't call
8729         dwarf2_tailcall_sniffer_first.
8730         (dwarf2_append_unwinders): Don't append tailcall unwinder.
8731         * frame-unwind.c (add_unwinder): New fuction.
8732         (frame_unwind_init): Use it.  Add tailcall unwinder.
8733
8734 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8735             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8736
8737         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
8738         value should be printed as true.
8739
8740 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
8741
8742         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
8743         (windows_init_abi): Set and use windows_so_ops.
8744
8745 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
8746
8747         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
8748         when verifying if dealing with a convenience variable.
8749
8750 2020-03-03  Luis Machado  <luis.machado@linaro.org>
8751
8752         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
8753
8754 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8755
8756         * infrun.c (gdbarch_supports_displaced_stepping): New.
8757         (use_displaced_stepping): Break up conditions in smaller pieces.
8758         Use gdbarch_supports_displaced_stepping.
8759         (displaced_step_prepare_throw): Use
8760         gdbarch_supports_displaced_stepping.
8761
8762 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8763
8764         * NEWS: Mention new behaviour of the history filename.
8765         * top.c (write_history_p): Add comment.
8766         (show_write_history_p): Add header comment, give a different
8767         message when history writing is on, but the history filename is
8768         empty.
8769         (history_filename): Add comment.
8770         (history_filename_empty): New function.
8771         (show_history_filename): Add header comment, give a different
8772         message when the filename is empty.
8773         (init_history): Compare history_filename against nullptr, and only
8774         read history if the filename is not empty.
8775         (set_history_filename): Add header comment, and only make
8776         non-empty filenames absolute.
8777         (init_main): Make the filename argument to 'set history filename'
8778         optional.
8779
8780 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
8781
8782         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
8783         (arm_supply_vfpregset): ...this, and update to use VFP registers.
8784         (fetch_fp_register): Update.
8785         (fetch_fp_regs): Update.
8786         (store_fp_register): Update.
8787         (store_fp_regs): Update.
8788         (arm_netbsd_nat_target::read_description): New function.
8789         (fetch_elfcore_registers): Update.
8790
8791 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8792
8793         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
8794         general_thread if the stop reply is missing a thread-id.
8795         (remote_target::process_stop_reply): Use the first non-exited
8796         thread if the target didn't pass a thread-id.
8797         * infrun.c (do_target_wait): Move call to
8798         switch_to_inferior_no_thread to ....
8799         (do_target_wait_1): ... here.
8800
8801 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
8802
8803         * debuginfod-support.c: Include defs.h first.
8804
8805 2020-02-28  Tom de Vries  <tdevries@suse.de>
8806
8807         * symfile.c (set_initial_language): Use default language for lookup.
8808
8809 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
8810
8811         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
8812         reader variable, pass `this` to read_cutu_die_from_dwo.
8813
8814 2020-02-27  Aaron Merey  <amerey@redhat.com>
8815
8816         * source.c (open_source_file): Check for nullptr when computing
8817         srcpath.
8818
8819 2020-02-27  Tom Tromey  <tromey@adacore.com>
8820
8821         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
8822         member.
8823         (dwarf2_add_field): Don't update nfields.
8824         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
8825
8826 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8827
8828         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
8829         abs.
8830
8831 2020-02-26  Tom Tromey  <tom@tromey.com>
8832
8833         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
8834         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
8835         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
8836         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
8837         per_cu_data.
8838
8839 2020-02-26  Tom Tromey  <tom@tromey.com>
8840
8841         * dwarf2/index-write.c (psym_index_map): Change type.
8842         (add_address_entry_worker, write_one_signatured_type)
8843         (recursively_count_psymbols, recursively_write_psymbols)
8844         (class debug_names, psyms_seen_size, write_gdbindex)
8845         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
8846
8847 2020-02-26  Aaron Merey  <amerey@redhat.com>
8848
8849         * Makefile.in: Handle optional debuginfod support.
8850         * NEWS: Update.
8851         * README: Add --with-debuginfod summary.
8852         * config.in: Regenerate.
8853         * configure: Regenerate.
8854         * configure.ac: Handle optional debuginfod support.
8855         * debuginfod-support.c: debuginfod helper functions.
8856         * debuginfod-support.h: Ditto.
8857         * doc/gdb.texinfo: Add --with-debuginfod to configure options
8858         summary.
8859         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
8860         when a dwz file cannot be found.
8861         * elfread.c (elf_symfile_read): Query debuginfod servers when a
8862         debuginfo file cannot be found.
8863         * source.c (open_source_file): Query debuginfod servers when a
8864         source file cannot be found.
8865         * top.c (print_gdb_configuration): Include
8866         --{with,without}-debuginfod in the output.
8867
8868 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
8869
8870         * thread.c (thr_try_catch_cmd): Print thread name.
8871
8872 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
8873
8874         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
8875         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8876         dwarf2_fetch_die_type_sect_off): Move to...
8877         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
8878         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8879         dwarf2_fetch_die_type_sect_off): ... here.
8880         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
8881         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8882         dwarf2_fetch_die_type_sect_off): Move doc to header file.
8883
8884 2020-02-26  Tom de Vries  <tdevries@suse.de>
8885
8886         PR gdb/25603
8887         * symfile.c (set_initial_language): Exit-early if
8888         language_mode == language_mode_manual.
8889
8890 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
8891
8892         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
8893         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
8894         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
8895
8896 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
8897
8898         * gdbtypes.c (create_array_type_with_stride): Handle negative
8899         array strides.
8900         * valarith.c (value_subscripted_rvalue): Likewise.
8901
8902 2020-02-25  Luis Machado  <luis.machado@linaro.org>
8903
8904         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
8905
8906 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
8907
8908         * loc.h (dwarf2_get_die_type): Move to...
8909         * read.h (dwarf2_get_die_type): ... here.
8910         * read.c (dwarf2_get_die_type): Move doc to header.
8911
8912 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
8913
8914         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
8915         'gnulib/Makefile.in' to the list.
8916
8917 2020-02-24  Tom Tromey  <tom@tromey.com>
8918
8919         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
8920         Remove.
8921         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
8922         XOBNEWVEC.
8923
8924 2020-02-24  Tom Tromey  <tom@tromey.com>
8925
8926         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
8927         New method.
8928         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
8929         (dw2_do_instantiate_symtab, dw2_get_file_names)
8930         (build_type_psymtab_dependencies, load_full_type_unit): Update.
8931
8932 2020-02-24  Tom Tromey  <tom@tromey.com>
8933
8934         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
8935         make_scoped_restore.
8936         (dwarf2_psymtab::read_symtab): Don't clear
8937         reading_partial_symbols.
8938
8939 2020-02-24  Tom de Vries  <tdevries@suse.de>
8940
8941         PR gdb/25592
8942         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
8943
8944 2020-02-24  Tom de Vries  <tdevries@suse.de>
8945
8946         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
8947         commands layout next/prev/regs.
8948
8949 2020-02-22  Tom Tromey  <tom@tromey.com>
8950
8951         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
8952         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
8953
8954 2020-02-22  Tom Tromey  <tom@tromey.com>
8955
8956         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
8957
8958 2020-02-22  Tom Tromey  <tom@tromey.com>
8959
8960         * tui/tui-win.c (_initialize_tui_win): Add usage text.
8961         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
8962         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
8963         * tui/tui.c (_initialize_tui): Add usage text.
8964
8965 2020-02-22  Tom Tromey  <tom@tromey.com>
8966
8967         * tui/tui-win.c (tui_set_focus_command)
8968         (tui_set_win_height_command): Use error_no_arg.
8969         (_initialize_tui_win): Update help text.
8970         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
8971
8972 2020-02-22  Tom Tromey  <tom@tromey.com>
8973
8974         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
8975         * tui/tui-disasm.h (struct tui_disasm_window)
8976         <display_start_addr>: Declare.
8977         * tui/tui-source.h (struct tui_source_window)
8978         <display_start_addr>: Declare.
8979         * tui/tui-winsource.h (struct tui_source_window_base)
8980         <show_source_line, display_start_addr>: New methods.
8981         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
8982         Rename and move to protected section.
8983         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
8984         (tui_source_window_base::do_erase_source_content): Update.
8985         (tui_source_window_base::show_source_line): Now a method.
8986         (tui_source_window_base::show_source_content)
8987         (tui_source_window_base::tui_source_window_base)
8988         (tui_source_window_base::rerender)
8989         (tui_source_window_base::refill)
8990         (tui_source_window_base::do_scroll_horizontal)
8991         (tui_source_window_base::set_is_exec_point_at)
8992         (tui_source_window_base::update_breakpoint_info)
8993         (tui_source_window_base::update_exec_info): Update.
8994         * tui/tui-source.c (tui_source_window::set_contents)
8995         (tui_source_window::showing_source_p)
8996         (tui_source_window::do_scroll_vertical)
8997         (tui_source_window::location_matches_p)
8998         (tui_source_window::line_is_displayed): Update.
8999         (tui_source_window::display_start_addr): New method.
9000         * tui/tui-disasm.c (tui_disasm_window::set_contents)
9001         (tui_disasm_window::do_scroll_vertical)
9002         (tui_disasm_window::location_matches_p): Update.
9003         (tui_disasm_window::display_start_addr): New method.
9004
9005 2020-02-22  Tom Tromey  <tom@tromey.com>
9006
9007         * NEWS: Add entry for gdb.register_window_type.
9008         * tui/tui-layout.h (window_factory): New typedef.
9009         (tui_register_window): Declare.
9010         * tui/tui-layout.c (saved_tui_windows): New global.
9011         (tui_apply_current_layout): Use it.
9012         (tui_register_window): New function.
9013         * python/python.c (do_start_initialization): Call
9014         gdbpy_initialize_tui.
9015         (python_GdbMethods): Add "register_window_type" function.
9016         * python/python-internal.h (gdbpy_register_tui_window)
9017         (gdbpy_initialize_tui): Declare.
9018         * python/py-tui.c: New file.
9019         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
9020
9021 2020-02-22  Tom Tromey  <tom@tromey.com>
9022
9023         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
9024
9025 2020-02-22  Tom Tromey  <tom@tromey.com>
9026
9027         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
9028         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
9029         * tui/tui-data.c (tui_set_win_with_focus): Remove.
9030         (tui_set_win_focus_to): Move from tui-win.c.
9031
9032 2020-02-22  Tom Tromey  <tom@tromey.com>
9033
9034         * tui/tui-layout.c (make_standard_window, get_locator_window): New
9035         functions.
9036         (known_window_types): New global.
9037         (tui_get_window_by_name): Reimplement.
9038         (initialize_known_windows): New function.
9039         (validate_window_name): Rewrite.
9040         (_initialize_tui_layout): Call initialize_known_windows.
9041
9042 2020-02-22  Tom Tromey  <tom@tromey.com>
9043
9044         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
9045         Remove constants.
9046         * tui/tui-winsource.h (struct tui_source_window_base)
9047         <tui_source_window_base>: Remove parameter.
9048         * tui/tui-winsource.c
9049         (tui_source_window_base::tui_source_window_base): Remove
9050         parameter.
9051         (tui_source_window_base::refill): Update.
9052         * tui/tui-stack.h (struct tui_locator_window)
9053         <tui_locator_window>: Update.
9054         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
9055         Default the constructor.
9056         * tui/tui-regs.h (struct tui_data_item_window)
9057         <tui_data_item_window>: Default the constructor.
9058         (struct tui_data_window) <tui_data_window>: Likewise.
9059         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
9060         Default the constructor.
9061         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
9062         Default the constructor.
9063         <type>: Remove.
9064         (struct tui_win_info) <tui_win_info>: Default the constructor.
9065         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
9066         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
9067         Default the constructor.
9068
9069 2020-02-22  Tom Tromey  <tom@tromey.com>
9070
9071         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
9072         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
9073         * tui/tui-win.c (tui_resize_all): Don't call
9074         tui_delete_invisible_windows.
9075         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
9076         done.
9077         (tui_set_layout): Update.
9078         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
9079         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
9080         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
9081
9082 2020-02-22  Tom Tromey  <tom@tromey.com>
9083
9084         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
9085         correctly.
9086
9087 2020-02-22  Tom Tromey  <tom@tromey.com>
9088
9089         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
9090
9091 2020-02-22  Tom Tromey  <tom@tromey.com>
9092
9093         * tui/tui-winsource.h (struct tui_source_window_iterator)
9094         <inner_iterator>: New etytypedef.
9095         <tui_source_window_iterator>: Take "end" parameter.
9096         <tui_source_window_iterator>: Take iterator.
9097         <operator*, advance>: Update.
9098         <m_iter>: Change type.
9099         <m_end>: New field.
9100         (struct tui_source_windows) <begin, end>: Update.
9101         * tui/tui-layout.c (tui_windows): New global.
9102         (tui_apply_current_layout): Clear tui_windows.
9103         (tui_layout_window::apply): Update tui_windows.
9104         * tui/tui-data.h (tui_windows): Declare.
9105         (all_tui_windows): Now inline function.
9106         (class tui_window_iterator, struct all_tui_windows): Remove.
9107
9108 2020-02-22  Tom Tromey  <tom@tromey.com>
9109
9110         PR tui/17850:
9111         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
9112         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
9113         "height" argument.
9114         (class tui_layout_window) <get_sizes>: Likewise.
9115         (class tui_layout_split) <tui_layout_split>: Add "vertical"
9116         argument.
9117         <get_sizes>: Add "height" argument.
9118         <m_vertical>: New field.
9119         * tui/tui-layout.c (tui_layout_split::clone): Update.
9120         (tui_layout_split::get_sizes): Add "height" argument.
9121         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
9122         (tui_new_layout_command): Parse "-horizontal".
9123         (_initialize_tui_layout): Update help string.
9124         (tui_layout_split::specification): Add "-horizontal" when needed.
9125         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
9126         argument.
9127         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
9128         New methods.
9129
9130 2020-02-22  Tom Tromey  <tom@tromey.com>
9131
9132         * tui/tui-layout.h (enum tui_adjust_result): New.
9133         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
9134         (class tui_layout_window) <adjust_size>: Return
9135         tui_adjust_result.  Rewrite.
9136         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
9137         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
9138
9139 2020-02-22  Tom Tromey  <tom@tromey.com>
9140
9141         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
9142         parameter and return types.
9143         (class tui_layout_base) <specification>: Add "depth".
9144         (class tui_layout_window) <specification>: Add "depth".
9145         (class tui_layout_split) <specification>: Add "depth".
9146         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
9147         and return types.
9148         (tui_new_layout_command): Parse sub-layouts.
9149         (_initialize_tui_layout): Update help string.
9150         (tui_layout_window::specification): Add "depth".
9151         (add_layout_command): Update.
9152
9153 2020-02-22  Tom Tromey  <tom@tromey.com>
9154
9155         * NEWS: Add "tui new-layout" item.
9156         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
9157         Add new-layout command to help text.
9158         (validate_window_name): New function.
9159         (tui_new_layout_command): New function.
9160         (_initialize_tui_layout): Register "new-layout".
9161         (tui_layout_window::specification): New method.
9162         (tui_layout_window::specification): New method.
9163         * tui/tui-layout.h (class tui_layout_base) <specification>: New
9164         method.
9165         (class tui_layout_window) <specification>: New method.
9166         (class tui_layout_split) <specification>: New method.
9167
9168 2020-02-22  Tom Tromey  <tom@tromey.com>
9169
9170         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
9171         * tui/tui-win.c (window_name_completer): Update comment.
9172         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
9173         Declare method.
9174         (class tui_layout_window) <replace_window>: Likewise.
9175         (class tui_layout_split) <replace_window>: Likewise.
9176         (tui_set_layout): Don't declare.
9177         (tui_set_initial_layout): Declare function.
9178         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
9179         (asm_regs_layout): New globals.
9180         (tui_current_layout, show_layout): Remove.
9181         (tui_set_layout, tui_add_win_to_layout): Rewrite.
9182         (find_layout, tui_apply_layout): New function.
9183         (layout_completer): Remove.
9184         (tui_next_layout): Reimplement.
9185         (tui_next_layout_command): New function.
9186         (tui_set_initial_layout, tui_prev_layout_command): New functions.
9187         (tui_regs_layout): Reimplement.
9188         (tui_regs_layout_command): New function.
9189         (extract_display_start_addr): Rewrite.
9190         (next_layout, prev_layout): Remove.
9191         (tui_layout_window::replace_window): New method.
9192         (tui_layout_split::replace_window): New method.
9193         (destroy_layout): New function.
9194         (layout_list): New global.
9195         (add_layout_command): New function.
9196         (initialize_layouts): Update.
9197         (tui_layout_command): New function.
9198         (_initialize_tui_layout): Install "layout" commands.
9199         * tui/tui-data.h (enum tui_layout_type): Remove.
9200         (tui_current_layout): Don't declare.
9201
9202 2020-02-22  Tom Tromey  <tom@tromey.com>
9203
9204         * tui/tui-regs.c (tui_reg_layout): Remove.
9205         (tui_reg_command): Use tui_regs_layout.
9206         * tui/tui-layout.h (tui_reg_command): Declare.
9207         * tui/tui-layout.c (tui_reg_command): New function.
9208
9209 2020-02-22  Tom Tromey  <tom@tromey.com>
9210
9211         * tui/tui.c (tui_rl_delete_other_windows): Call
9212         tui_remove_some_windows.
9213         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
9214         Declare method.
9215         (class tui_layout_window) <remove_windows>: New method.
9216         (class tui_layout_split) <remove_windows>: Declare.
9217         (tui_remove_some_windows): Declare.
9218         * tui/tui-layout.c (tui_remove_some_windows): New function.
9219         (tui_layout_split::remove_windows): New method.
9220
9221 2020-02-22  Tom Tromey  <tom@tromey.com>
9222
9223         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
9224         * tui/tui-layout.h (tui_next_layout): Declare.
9225         * tui/tui-layout.c (tui_next_layout): New function.
9226
9227 2020-02-22  Tom Tromey  <tom@tromey.com>
9228
9229         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
9230         correct coordinates.
9231
9232 2020-02-22  Tom Tromey  <tom@tromey.com>
9233
9234         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
9235         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
9236         DATA_WIN case.
9237
9238 2020-02-22  Tom Tromey  <tom@tromey.com>
9239
9240         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
9241         TUI_DISASM_WIN, not tui_win_list.
9242
9243 2020-02-22  Tom Tromey  <tom@tromey.com>
9244
9245         * valprint.c (generic_val_print_enum_1)
9246         (val_print_type_code_flags): Style member names.
9247         * rust-lang.c (val_print_struct, rust_print_enum)
9248         (rust_print_struct_def, rust_internal_print_type): Style member
9249         names.
9250         * p-valprint.c (pascal_object_print_value_fields): Style member
9251         names.  Only call fprintf_symbol_filtered for static members.
9252         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
9253         * f-valprint.c (f_val_print): Style member names.
9254         * f-typeprint.c (f_type_print_base): Style member names.
9255         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
9256         call fprintf_symbol_filtered for static members.
9257         (cp_print_class_member): Style member names.
9258         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
9259         member names.
9260         * ada-valprint.c (ada_print_scalar): Style enum names.
9261         (ada_val_print_enum): Likewise.
9262         * ada-typeprint.c (print_enum_type): Style enum names.
9263
9264 2020-02-21  Tom Tromey  <tom@tromey.com>
9265
9266         * psympriv.h (struct partial_symtab): Update comment.
9267
9268 2020-02-21  Tom Tromey  <tromey@adacore.com>
9269
9270         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
9271         type is CORE_ADDR.
9272
9273 2020-02-21  Tom de Vries  <tdevries@suse.de>
9274
9275         PR gdb/25534
9276         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
9277         if dependencies[i]->user != NULL.
9278
9279 2020-02-21  Ali Tamur  <tamur@google.com>
9280
9281         * dwarf2/read.c (dwarf2_name): Add null check.
9282
9283 2020-02-20  Tom Tromey  <tom@tromey.com>
9284
9285         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
9286         ">=", in binary search.
9287         (dwarf2_find_containing_comp_unit): New overload.
9288         (run_test): New self-test.
9289         (_initialize_dwarf2_read): Register new test.
9290
9291 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
9292
9293         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
9294         * riscv-tdep.h: Likewise.
9295         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
9296         rv32-only CSR.
9297         * features/riscv/64bit-csr.xml: Regenerated.
9298
9299 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
9300             Tom Tromey  <tom@tromey.com>
9301
9302         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
9303         of 'fputc_unfiltered'.
9304         (putchar_unfiltered): Call 'fputc_unfiltered'.
9305         (fputc_unfiltered): Call 'fputs_unfiltered'.
9306
9307 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
9308
9309         * config.in: Regenerate.
9310         * configure: Regenerate.
9311         * configure.ac: Add --with-python-libdir option.
9312         * main.c: Use WITH_PYTHON_LIBDIR.
9313
9314 2020-02-19  Tom Tromey  <tom@tromey.com>
9315
9316         * symtab.c (general_symbol_info::compute_and_set_names): Use
9317         obstack_strndup.  Simplify call to symbol_set_demangled_name.
9318
9319 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
9320
9321         * dwarf2/read.c (allocate_signatured_type_table,
9322         allocate_dwo_unit_table, allocate_type_unit_groups_table,
9323         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
9324         Remove objfile parameter, update all callers.
9325
9326 2020-02-19  Doug Evans  <dje@google.com>
9327
9328         PR rust/25535
9329         * rust-lang.c (rust_print_enum): Apply embedded_offset to
9330         rust_enum_variant calculation.
9331
9332 2020-02-19  Tom Tromey  <tromey@adacore.com>
9333
9334         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
9335
9336 2020-02-19  Tom Tromey  <tromey@adacore.com>
9337
9338         * ada-lang.c (cache_symbol): Use obstack_strdup.
9339
9340 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
9341
9342         * configure: Regenerate.
9343
9344 2020-02-19  Tom Tromey  <tromey@adacore.com>
9345
9346         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
9347         NULL check.
9348
9349 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
9350
9351         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
9352
9353 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
9354
9355         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
9356         if GDBSERVER is not defined.
9357         (riscv_tdesc_cache): Likewise, also store const target_desc.
9358         (STATIC_IN_GDB): Define.
9359         (riscv_create_target_description): Update declaration with
9360         STATIC_IN_GDB.
9361         (riscv_lookup_target_description): New function, only define if
9362         GDBSERVER is not defined.
9363         * arch/riscv.h (riscv_create_target_description): Declare only
9364         when GDBSERVER is defined.
9365         (riscv_lookup_target_description): New declaration when GDBSERVER
9366         is not defined.
9367         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
9368         (riscv_linux_read_features): ...this, and return
9369         riscv_gdbarch_features instead of target_desc.
9370         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
9371         (riscv_linux_read_description): Rename to...
9372         (riscv_linux_read_features): ...this.
9373         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
9374         Update to use riscv_gdbarch_features and
9375         riscv_lookup_target_description.
9376         * riscv-tdep.c (riscv_find_default_target_description): Use
9377         riscv_lookup_target_description instead of
9378         riscv_create_target_description.
9379
9380 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9381
9382         * valprint.c (generic_val_print_enum_1): When printing a flag
9383         enum with value 0 and there is no enumerator with value 0, print
9384         just "0" instead of "(unknown: 0x0)".
9385
9386 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9387
9388         * valprint.c (generic_val_print_enum_1): Print unknown part of
9389         flag enum in hex.
9390
9391 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9392
9393         * dwarf2/read.c (update_enumeration_type_from_children): Allow
9394         flag enums to contain duplicate enumerators.
9395         * valprint.c (generic_val_print_enum_1): Update comment.
9396
9397 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9398
9399         * dwarf2/read.c: Include "count-one-bits.h".
9400         (update_enumeration_type_from_children): If an enumerator has
9401         multiple bits set, don't treat the enumeration as a "flag enum".
9402         * valprint.c (generic_val_print_enum_1): Assert that enumerators
9403         of flag enums have 0 or 1 bit set.
9404
9405 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9406
9407         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
9408         conversion.
9409         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
9410         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
9411         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
9412         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
9413         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
9414
9415 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9416
9417         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
9418
9419 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9420
9421         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
9422         displaced_step_closure_up.
9423         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
9424         (struct displaced_step_closure_up):
9425         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
9426         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
9427         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
9428         Likewise.
9429         * gdbarch.sh (displaced_step_copy_insn): Likewise.
9430         * gdbarch.c, gdbarch.h: Re-generate.
9431         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
9432         displaced_step_closure_up.
9433         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
9434         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
9435         * infrun.h (displaced_step_closure_up): New type alias.
9436         (struct displaced_step_inferior_state) <step_closure>: Change
9437         type to displaced_step_closure_up.
9438         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
9439         displaced_step_closure_up.
9440         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
9441
9442 2020-02-14  Tom Tromey  <tom@tromey.com>
9443
9444         * minidebug.c (gnu_debug_key): New global.
9445         (find_separate_debug_file_in_section): Use it.
9446
9447 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9448
9449         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
9450         std::unique_ptr.
9451         * gdbarch.c: Re-generate.
9452         * gdbarch.h: Re-generate.
9453         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
9454         change.
9455         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
9456         type to std::unique_ptr.
9457         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
9458         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
9459         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
9460         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
9461         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
9462         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
9463         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
9464         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
9465         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
9466
9467 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9468
9469         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
9470         std::unique_ptr.
9471         (displaced_step_clear): Rename to...
9472         (displaced_step_reset): ... this.  Just call displaced->reset ().
9473         (displaced_step_clear_cleanup): Rename to...
9474         (displaced_step_reset_cleanup): ... this.
9475         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
9476         (displaced_step_fixup): Likewise.
9477         (resume_1): Likewise.
9478         (handle_inferior_event): Restore child's memory before calling
9479         displaced_step_fixup on the parent.
9480         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
9481         to std::unique_ptr.
9482         <step_closure>: Change type to std::unique_ptr.
9483
9484 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9485
9486         * arm-tdep.c: Include count-one-bits.h.
9487         (cleanup_block_store_pc): Use count_one_bits.
9488         (cleanup_block_load_pc): Use count_one_bits.
9489         (arm_copy_block_xfer): Use count_one_bits.
9490         (thumb2_copy_block_xfer): Use count_one_bits.
9491         (thumb_copy_pop_pc_16bit): Use count_one_bits.
9492         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
9493         (thumb_get_next_pcs_raw): Use count_one_bits.
9494         (arm_get_next_pcs_raw): Use count_one_bits_l.
9495         * arch/arm.c (bitcount): Remove.
9496         * arch/arm.h (bitcount): Remove.
9497
9498 2020-02-14  Tom Tromey  <tromey@adacore.com>
9499
9500         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
9501         Update.
9502         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
9503         * dwarf2/loc.c (call_site_find_chain_1): Return
9504         unique_xmalloc_ptr.
9505         (call_site_find_chain): Likewise.
9506
9507 2020-02-14  Richard Biener  <rguenther@suse.de>
9508
9509         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
9510         on expression with division operators.
9511
9512 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
9513
9514         * MAINTAINERS (Write After Approval): Adding myself.
9515
9516 2020-02-12  Tom Tromey  <tom@tromey.com>
9517
9518         * event-loop.c (event_data, gdb_event, event_handler_func):
9519         Remove.
9520
9521 2020-02-12  Tom Tromey  <tom@tromey.com>
9522
9523         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
9524         (dwarf2_frame_objfile_data): Add comment.
9525         (find_comp_unit, set_comp_unit): New functions.
9526         (dwarf2_frame_find_fde): Use find_comp_unit.
9527         (dwarf2_build_frame_info): Use set_comp_unit.
9528
9529 2020-02-12  Tom Tromey  <tom@tromey.com>
9530
9531         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
9532         (comp_unit): Don't initialize objfile.
9533         (execute_cfa_program): Add text_offset parameter.
9534         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
9535         (dwarf2_frame_cache): Update.
9536         (dwarf2_build_frame_info): Don't set "objfile" member.
9537
9538 2020-02-12  Tom Tromey  <tom@tromey.com>
9539
9540         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
9541         (decode_frame_entry): Likewise.
9542         (dwarf2_build_frame_info): Update.
9543
9544 2020-02-12  Tom Tromey  <tom@tromey.com>
9545
9546         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
9547         (decode_frame_entry_1): Use the comp_unit obstack.
9548
9549 2020-02-12  Tom Tromey  <tom@tromey.com>
9550
9551         * dwarf2/frame.c (struct comp_unit): Add initializers and
9552         constructor.
9553         (dwarf2_frame_objfile_data): Store a comp_unit.
9554         (dwarf2_frame_find_fde): Update.
9555         (dwarf2_build_frame_info): Use "new".
9556
9557 2020-02-12  Tom Tromey  <tom@tromey.com>
9558
9559         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
9560         (dwarf2_fde_table): Typedef for std::vector.
9561         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
9562         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
9563         (decode_frame_entry): Update.
9564         (dwarf2_build_frame_info): Use "new".
9565
9566 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
9567
9568         * arm-tdep.c (arm_gdbarch_init): Update.
9569         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
9570         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
9571         have_neon, is_m>: Change to bool.
9572
9573 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
9574
9575         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
9576
9577 2020-02-12  Tom Tromey  <tom@tromey.com>
9578
9579         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
9580
9581 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
9582
9583         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
9584         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
9585
9586 2020-02-11  Tom Tromey  <tom@tromey.com>
9587
9588         * psymtab.h: Update comment.
9589
9590 2020-02-11  Tom Tromey  <tom@tromey.com>
9591
9592         * gdb_obstack.h (struct auto_obstack): Use
9593         DISABLE_COPY_AND_ASSIGN.
9594
9595 2020-02-11  Tom Tromey  <tom@tromey.com>
9596
9597         * dwarf2/frame.h (struct objfile): Don't forward declare.
9598
9599 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
9600
9601         * cris-tdep.c (cris_supply_gregset): Change signature to match
9602         what struct regset expects.
9603         (cris_regset): New struct.
9604         (fetch_core_registers): Remove.
9605         (cris_iterate_over_regset_sections): New function.
9606         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
9607         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
9608
9609 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
9610
9611         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
9612         registers.
9613
9614 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
9615
9616         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
9617
9618 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
9619
9620         * configure: Re-generate.
9621
9622 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
9623
9624         * configure: Re-generate.
9625
9626 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
9627
9628         * acinclude: Update warning.m4 path.
9629         * warning.m4: Move to gdbsupport.
9630
9631 2020-02-11  Tom Tromey  <tromey@adacore.com>
9632
9633         * remote.c (remote_console_output): Update.
9634         * printcmd.c (printf_command): Update.
9635         * event-loop.c (gdb_wait_for_event): Update.
9636         * linux-nat.c (sigchld_handler): Update.
9637         * remote-sim.c (gdb_os_write_stdout): Update.
9638         (gdb_os_flush_stdout): Update.
9639         (gdb_os_flush_stderr): Update.
9640         (gdb_os_write_stderr): Update.
9641         * exceptions.c (print_exception): Update.
9642         * remote-fileio.c (remote_fileio_func_read): Update.
9643         (remote_fileio_func_write): Update.
9644         * tui/tui.c (tui_enable): Update.
9645         * tui/tui-interp.c (tui_interp::init): Update.
9646         * utils.c (init_page_info): Update.
9647         (putchar_unfiltered, fputc_unfiltered): Update.
9648         (gdb_flush): Update.
9649         (emit_style_escape): Update.
9650         (flush_wrap_buffer, fputs_maybe_filtered): Update.
9651         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
9652         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
9653         (stderr_file::write): Update.
9654         (stderr_file::puts): Update.
9655         * ui-file.h (ui_file_isatty, ui_file_write)
9656         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
9657         (ui_file_puts): Don't declare.
9658
9659 2020-02-10  Tom de Vries  <tdevries@suse.de>
9660
9661         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
9662         sentinel to char *.
9663
9664 2020-02-09  Tom de Vries  <tdevries@suse.de>
9665
9666         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
9667         filename if it matches "<artificial>".
9668
9669 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
9670
9671         * windows-tdep.c (struct enum_value_name): New struct.
9672         (create_enum): New function.
9673         (windows_get_siginfo_type): Create and use enum types.
9674
9675 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
9676
9677         * NEWS: Mention $_siginfo support for Windows.
9678         * windows-nat.c (handle_exception): Set siginfo_er.
9679         (windows_nat_target::mourn_inferior): Reset siginfo_er.
9680         (windows_xfer_siginfo): New function.
9681         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
9682         * windows-tdep.c (struct windows_gdbarch_data): New struct.
9683         (init_windows_gdbarch_data): New function.
9684         (get_windows_gdbarch_data): New function.
9685         (windows_get_siginfo_type): New function.
9686         (windows_init_abi): Register windows_get_siginfo_type.
9687         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
9688
9689 2020-02-08  Tom Tromey  <tom@tromey.com>
9690
9691         * dwarf2/read.c (class cutu_reader) <cutu_reader,
9692         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
9693         <keep>: Declare method.
9694         <m_keep>: Remove member.
9695         <~cutu_reader>: Remove.
9696         (cutu_reader::init_tu_and_read_dwo_dies): Update.
9697         (cutu_reader::cutu_reader): Update.
9698         (cutu_reader::keep): Rename from ~cutu_reader.
9699         (process_psymtab_comp_unit, build_type_psymtabs_1)
9700         (process_skeletonless_type_unit, load_partial_comp_unit)
9701         (load_full_comp_unit, dwarf2_read_addr_index)
9702         (read_signatured_type): Update.
9703
9704 2020-02-08  Tom Tromey  <tom@tromey.com>
9705
9706         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
9707         "want_partial_unit" parameter.
9708         (process_psymtab_comp_unit): Change want_partial_unit to bool.
9709         Inline check for DW_TAG_partial_unit.
9710         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
9711
9712 2020-02-08  Tom Tromey  <tom@tromey.com>
9713
9714         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
9715         read.c.
9716         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
9717         read.c.
9718
9719 2020-02-08  Tom Tromey  <tom@tromey.com>
9720
9721         * dwarf2/read.c (read_address): Move to comp-unit.c.
9722         (dwarf2_rnglists_process, dwarf2_ranges_process)
9723         (read_attribute_value, dwarf_decode_lines_1)
9724         (var_decode_location, decode_locdesc): Update.
9725         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
9726         read.c.  Remove "cu" parameter.
9727         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
9728         method.
9729
9730 2020-02-08  Tom Tromey  <tom@tromey.com>
9731
9732         * dwarf2/read.c (read_attribute_value, read_indirect_string)
9733         (read_indirect_line_string): Update.
9734         * dwarf2/comp-unit.c (read_offset): Remove.
9735         (read_comp_unit_head): Update.
9736         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
9737         method.
9738         (read_offset): Don't declare.
9739
9740 2020-02-08  Tom Tromey  <tom@tromey.com>
9741
9742         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
9743         * dwarf2/read.c (struct comp_unit_head): Move to
9744         dwarf2/comp-unit.h.
9745         (enum class rcuh_kind): Move to comp-unit.h.
9746         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
9747         (read_comp_unit_head, error_check_comp_unit_head)
9748         (read_and_check_comp_unit_head): Move to comp-unit.c.
9749         (read_offset, dwarf_unit_type_name): Likewise.
9750         (create_debug_type_hash_table, read_cutu_die_from_dwo)
9751         (cutu_reader::cutu_reader, read_call_site_scope)
9752         (find_partial_die, follow_die_offset): Update.
9753         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
9754
9755 2020-02-08  Tom Tromey  <tom@tromey.com>
9756
9757         * dwarf2/read.c (read_offset_1): Move to leb.c.
9758         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
9759         (dwarf_decode_macro_bytes): Update.
9760         * dwarf2/leb.c (read_offset): Rename; move from read.c.
9761         * dwarf2/leb.h (read_offset): Declare.
9762
9763 2020-02-08  Tom Tromey  <tom@tromey.com>
9764
9765         * dwarf2/read.c (dwarf2_section_size): Remove.
9766         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
9767         Update.
9768         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
9769
9770 2020-02-08  Tom Tromey  <tom@tromey.com>
9771
9772         * dwarf2/read.c (read_initial_length): Move to leb.c.
9773         * dwarf2/leb.h (read_initial_length): Declare.
9774         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
9775         handle_nonstd parameter.
9776         * dwarf2/frame.c (read_initial_length): Remove.
9777         (decode_frame_entry_1): Update.
9778
9779 2020-02-08  Tom Tromey  <tom@tromey.com>
9780
9781         * dwarf2/loc.c (dwarf2_find_location_expression)
9782         (dwarf_evaluate_loc_desc::get_tls_address)
9783         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
9784         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
9785         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
9786         (dwarf2_compile_property_to_c)
9787         (dwarf2_loc_desc_get_symbol_read_needs)
9788         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
9789         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
9790         (loclist_describe_location, loclist_tracepoint_var_ref)
9791         (loclist_generate_c_location): Update.
9792         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
9793         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
9794         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
9795         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
9796         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
9797         (dwarf2_per_cu_data::addr_size)
9798         (dwarf2_per_cu_data::ref_addr_size)
9799         (dwarf2_per_cu_data::text_offset)
9800         (dwarf2_per_cu_data::addr_type): Now methods.
9801         (per_cu_header_read_in): Make per_cu "const".
9802         (dwarf2_version): Remove.
9803         (dwarf2_per_cu_data::int_type): Now a method.
9804         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
9805         (set_die_type, read_array_type, read_subrange_index_type)
9806         (read_tag_string_type, read_subrange_type): Update.
9807         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
9808         offset_size, ref_addr_size, text_offset, addr_type, version,
9809         objfile, int_type, addr_sized_int_type>: Declare methods.
9810
9811 2020-02-08  Tom Tromey  <tom@tromey.com>
9812
9813         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
9814         Move earlier.
9815
9816 2020-02-08  Tom Tromey  <tom@tromey.com>
9817
9818         * dwarf2/read.h (dwarf_line_debug): Declare.
9819         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
9820         * dwarf2/read.c: Move line_header code to new files.
9821         (dwarf_line_debug): No longer static.
9822         * dwarf2/line-header.c: New file.
9823         * dwarf2/line-header.h: New file.
9824
9825 2020-02-08  Tom Tromey  <tom@tromey.com>
9826
9827         * dwarf2/read.c (struct line_header) <file_full_name,
9828         file_file_name>: Return unique_xmalloc_ptr.
9829         (line_header::file_file_name): Update.
9830         (line_header::file_full_name): Update.
9831         (dw2_get_file_names_reader): Update.
9832         (macro_start_file): Update.
9833
9834 2020-02-08  Tom Tromey  <tom@tromey.com>
9835
9836         * dwarf2/read.c (struct line_header) <file_full_name,
9837         file_file_name>: Declare methods.
9838         (dw2_get_file_names_reader): Update.
9839         (file_file_name): Now a method.
9840         (file_full_name): Likewise.
9841         (macro_start_file): Update.
9842
9843 2020-02-08  Tom Tromey  <tom@tromey.com>
9844
9845         * dwarf2/read.c (dwarf_always_disassemble)
9846         (show_dwarf_always_disassemble): Move to loc.c.
9847         (_initialize_dwarf2_read): Move "always-disassemble" registration
9848         to loc.c.
9849         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
9850         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
9851         static.
9852         (show_dwarf_always_disassemble): Move from read.c.
9853         (_initialize_dwarf2loc): Move always-disassemble from read.c.
9854
9855 2020-02-08  Tom Tromey  <tom@tromey.com>
9856
9857         * dwarf2/read.c (~dwarf2_per_objfile): Update.
9858         (create_quick_file_names_table): Return htab_up.
9859         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
9860         Update.
9861         * dwarf2/read.h (struct dwarf2_per_objfile)
9862         <quick_file_names_table>: Now htab_up.
9863
9864 2020-02-08  Tom Tromey  <tom@tromey.com>
9865
9866         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
9867
9868 2020-02-08  Tom Tromey  <tom@tromey.com>
9869
9870         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
9871         Rewrite.
9872         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
9873         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
9874         (abbrev_table::abbrev_table): No longer inline.
9875         (ABBREV_HASH_SIZE): Remove.
9876         (abbrev_table::m_abbrevs): Now an htab_up.
9877
9878 2020-02-08  Tom Tromey  <tom@tromey.com>
9879
9880         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
9881         (cutu_reader): Update.
9882         (build_type_psymtabs_1): Update.
9883         * dwarf2/abbrev.c (abbrev_table::read): Rename.
9884         (abbrev_table::alloc_abbrev): Update.
9885         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
9886         (abbrev_table::read): New static method, renamed from
9887         abbrev_table_read_table.
9888         (abbrev_table::alloc_abbrev)
9889         (abbrev_table::add_abbrev): Now private.
9890         (abbrev_table::abbrev_table): Now private.
9891         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
9892
9893 2020-02-08  Tom Tromey  <tom@tromey.com>
9894
9895         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
9896         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
9897         htab_up.
9898
9899 2020-02-08  Tom Tromey  <tom@tromey.com>
9900
9901         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
9902         htab_up.
9903         (lookup_dwo_unit_in_dwp): Update.
9904         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
9905         on obstack.
9906
9907 2020-02-08  Tom Tromey  <tom@tromey.com>
9908
9909         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
9910         obstack.
9911
9912 2020-02-08  Tom Tromey  <tom@tromey.com>
9913
9914         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
9915         line_header_hash.
9916         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
9917         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
9918         Change type to htab_up.
9919
9920 2020-02-08  Tom Tromey  <tom@tromey.com>
9921
9922         * dwarf2/read.c (allocate_type_unit_groups_table): Return
9923         htab_up.  Don't allocate on obstack.
9924         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
9925         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
9926         Change type to htab_up.
9927
9928 2020-02-08  Tom Tromey  <tom@tromey.com>
9929
9930         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
9931         Change type to htab_up.
9932         * dwarf2/read.c (create_signatured_type_table_from_index)
9933         (create_signatured_type_table_from_debug_names)
9934         (create_all_type_units, add_type_unit)
9935         (lookup_dwo_signatured_type, lookup_signatured_type)
9936         (process_skeletonless_type_unit): Update.
9937         (create_debug_type_hash_table, create_debug_types_hash_table):
9938         Change type of types_htab.
9939         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
9940         htab_up.  Don't allocate on obstack.
9941         (create_cus_hash_table): Change type of cus_htab parameter.
9942         (struct dwo_file) <cus, tus>: Now htab_up.
9943         (lookup_dwo_signatured_type, lookup_dwo_cutu)
9944         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
9945         (queue_and_load_all_dwo_tus): Update.
9946         * dwarf2/index-write.c (write_gdbindex): Update.
9947         (write_debug_names): Update.
9948
9949 2020-02-08  Tom Tromey  <tom@tromey.com>
9950
9951         * dwarf2/read.h (struct dwarf2_queue_item): Move from
9952         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
9953         destructor.
9954         (struct dwarf2_per_objfile) <queue>: New member.
9955         * dwarf2/read.c (struct dwarf2_queue_item): Move to
9956         dwarf2/read.h.
9957         (dwarf2_queue, dwarf2_queue_tail): Remove.
9958         (class dwarf2_queue_guard): Add parameter to constructor.  Use
9959         DISABLE_COPY_AND_ASSIGN.
9960         <m_per_objfile>: New member.
9961         <~dwarf2_queue_guard>: Rewrite.
9962         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
9963         Update.
9964         (~dwarf2_queue_item): New.
9965
9966 2020-02-08  Tom Tromey  <tom@tromey.com>
9967
9968         * dwarf2/read.c (struct die_info) <has_children>: New member.
9969         (dw2_get_file_names_reader): Remove has_children.
9970         (dw2_get_file_names): Update.
9971         (read_cutu_die_from_dwo): Remove has_children.
9972         (cutu_reader::init_tu_and_read_dwo_dies)
9973         (cutu_reader::cutu_reader): Update.
9974         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
9975         Remove has_children.
9976         (build_type_psymtabs_1, process_skeletonless_type_unit)
9977         (load_partial_comp_unit, load_full_comp_unit): Update.
9978         (create_dwo_cu_reader): Remove has_children.
9979         (create_cus_hash_table, read_die_and_children): Update.
9980         (read_full_die_1,read_full_die): Remove has_children.
9981         (read_signatured_type): Update.
9982         (class cutu_reader) <has_children>: Remove.
9983
9984 2020-02-08  Tom Tromey  <tom@tromey.com>
9985
9986         * dwarf2/expr.c: Rename from dwarf2expr.c.
9987         * dwarf2/expr.h: Rename from dwarf2expr.h.
9988         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
9989         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
9990         * dwarf2/frame.c: Rename from dwarf2-frame.c.
9991         * dwarf2/frame.h: Rename from dwarf2-frame.h.
9992         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
9993         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
9994         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
9995         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
9996         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
9997         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
9998         * dwarf2/loc.c: Rename from dwarf2loc.c.
9999         * dwarf2/loc.h: Rename from dwarf2loc.h.
10000         * dwarf2/read.c: Rename from dwarf2read.c.
10001         * dwarf2/read.h: Rename from dwarf2read.h.
10002         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
10003         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
10004         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
10005         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
10006         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
10007         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
10008         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
10009         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
10010         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
10011         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
10012         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
10013         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
10014         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
10015         Update.
10016         * Makefile.in (COMMON_SFILES): Update.
10017         (HFILES_NO_SRCDIR): Update.
10018
10019 2020-02-08  Tom Tromey  <tom@tromey.com>
10020
10021         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
10022         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
10023
10024 2020-02-08  Tom Tromey  <tom@tromey.com>
10025
10026         * dwarf2read.h (struct die_info): Don't declare.
10027
10028 2020-02-08  Tom Tromey  <tom@tromey.com>
10029
10030         * dwarf2read.h (die_info_ptr): Remove typedef.
10031
10032 2020-02-08  Tom Tromey  <tom@tromey.com>
10033
10034         * dwarf2read.c (read_call_site_scope)
10035         (handle_data_member_location, dwarf2_add_member_fn)
10036         (mark_common_block_symbol_computed, read_common_block)
10037         (attr_to_dynamic_prop, partial_die_info::read)
10038         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
10039         (dwarf2_symbol_mark_computed, set_die_type): Update.
10040         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
10041         method.
10042         (attr_form_is_block): Don't declare.
10043         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
10044
10045 2020-02-08  Tom Tromey  <tom@tromey.com>
10046
10047         * dwarf2read.c (dwarf2_find_base_address, )
10048         (read_call_site_scope, rust_containing_type)
10049         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
10050         (handle_data_member_location, dwarf2_add_member_fn)
10051         (get_alignment, read_structure_type, process_structure_scope)
10052         (mark_common_block_symbol_computed, read_common_block)
10053         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
10054         (partial_die_info::read, read_attribute_value, new_symbol)
10055         (lookup_die_type, dwarf2_get_ref_die_offset)
10056         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
10057         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
10058         (dwarf2_symbol_mark_computed): Update.
10059         * dwarf2/attribute.h (struct attribute) <value_as_address,
10060         form_is_section_offset, form_is_constant, form_is_ref>: Declare
10061         methods.
10062         (value_as_address, attr_form_is_section_offset)
10063         (attr_form_is_constant, attr_form_is_ref): Don't declare.
10064         * dwarf2/attribute.c (attribute::value_as_address)
10065         (attribute::form_is_section_offset, attribute::form_is_constant)
10066         (attribute::form_is_ref): Now methods.
10067
10068 2020-02-08  Tom Tromey  <tom@tromey.com>
10069
10070         * dwarf2read.c (struct attribute, DW_STRING)
10071         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
10072         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
10073         (attr_form_is_block, attr_form_is_section_offset)
10074         (attr_form_is_constant, attr_form_is_ref): Move.
10075         * dwarf2/attribute.h: New file.
10076         * dwarf2/attribute.c: New file, from dwarf2read.c.
10077         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
10078
10079 2020-02-08  Tom Tromey  <tom@tromey.com>
10080
10081         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
10082         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
10083         Move.
10084         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
10085         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
10086         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
10087         abbrev.c.
10088         * dwarf2/abbrev.h: New file.
10089         * dwarf2/abbrev.c: New file, from dwarf2read.c.
10090         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
10091
10092 2020-02-08  Tom Tromey  <tom@tromey.com>
10093
10094         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
10095         (dwarf2_section_size, dwarf2_get_section_info)
10096         (create_signatured_type_table_from_debug_names)
10097         (create_addrmap_from_aranges, read_debug_names_from_section)
10098         (get_gdb_index_contents_from_section, read_comp_unit_head)
10099         (error_check_comp_unit_head, read_abbrev_offset)
10100         (create_debug_type_hash_table, init_cu_die_reader)
10101         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
10102         (read_comp_units_from_section, create_cus_hash_table)
10103         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
10104         (create_dwp_v2_section, dwarf2_rnglists_process)
10105         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
10106         (abbrev_table_read_table, read_indirect_string_at_offset_from)
10107         (read_indirect_string_from_dwz, read_addr_index_1)
10108         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
10109         (dwarf_decode_macro_bytes, dwarf_decode_macros)
10110         (fill_in_loclist_baton): Update.
10111         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
10112         get_containing_section, get_bfd_owner, get_bfd_section,
10113         get_file_name, get_id, get_flags, empty, read>: Declare methods.
10114         (dwarf2_read_section, get_section_name, get_section_file_name)
10115         (get_containing_section, get_section_bfd_owner)
10116         (get_section_bfd_section, get_section_name, get_section_file_name)
10117         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
10118         declare.
10119         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
10120         (dwarf2_section_info::get_bfd_owner)
10121         (dwarf2_section_info::get_bfd_section)
10122         (dwarf2_section_info::get_name)
10123         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
10124         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
10125         (dwarf2_section_info::read): Now methods.
10126         * dwarf-index-write.c (class debug_names): Update.
10127
10128 2020-02-08  Tom Tromey  <tom@tromey.com>
10129
10130         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
10131         Move to dwarf2/section.h.
10132         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
10133         (get_section_bfd_section, get_section_name)
10134         (get_section_file_name, get_section_id, get_section_flags)
10135         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
10136         dwarf2/section.c.
10137         * dwarf2/section.h: New file.
10138         * dwarf2/section.c: New file, from dwarf2read.c.
10139         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
10140
10141 2020-02-08  Tom Tromey  <tom@tromey.com>
10142
10143         * dwarf2read.h (read_unsigned_leb128): Don't declare.
10144         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
10145         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
10146         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
10147         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
10148         * dwarf2/leb.h: New file, from dwarf2read.c.
10149         * dwarf2/leb.c: New file, from dwarf2read.c.
10150         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
10151         Remove.
10152         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
10153         (COMMON_SFILES): Add dwarf2/leb.c.
10154
10155 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
10156
10157         GDB 9.1 released.
10158
10159 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
10160
10161         PR gdb/25190:
10162         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
10163         * gdb/remote.c (remote_console_output): Update.
10164         * gdb/ui-file.c (fputs_unfiltered): Rename to...
10165         (ui_file_puts): ...this.
10166         * gdb/ui-file.h (ui_file_puts): Add declaration.
10167         * gdb/utils.c (emit_style_escape): Update.
10168         (flush_wrap_buffer): Update.
10169         (fputs_maybe_filtered): Update.
10170         (fputs_unfiltered): Add function.
10171
10172 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
10173
10174         * gdb/event-loop.c (gdb_wait_for_event): Update.
10175         * gdb/printcmd.c (printf_command): Update.
10176         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
10177         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
10178         (gdb_os_flush_stderr): Update.
10179         * gdb/remote.c (remote_console_output): Update.
10180         * gdb/ui-file.c (gdb_flush): Rename to...
10181         (ui_file_flush): ...this.
10182         (stderr_file::write): Update.
10183         (stderr_file::puts): Update.
10184         * gdb/ui-file.h (gdb_flush): Rename to...
10185         (ui_file_flush): ...this.
10186         * gdb/utils.c (gdb_flush): Add function.
10187         * gdb/utils.h (gdb_flush): Add declaration.
10188
10189 2020-02-07  Tom Tromey  <tromey@adacore.com>
10190
10191         PR breakpoints/24915:
10192         * source.c (find_and_open_source): Do not check basenames_may_differ.
10193
10194 2020-02-07  Tom Tromey  <tom@tromey.com>
10195
10196         * README: Update gdbserver documentation.
10197         * gdbserver: Move to top level.
10198         * configure.tgt (build_gdbserver): Remove.
10199         * configure.ac: Remove --enable-gdbserver.
10200         * configure: Rebuild.
10201         * Makefile.in (distclean): Don't mention gdbserver.
10202
10203 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
10204
10205         * source-cache.c (source_cache::ensure): Surround
10206         get_plain_source_lines with a try/catch.
10207         (source_cache::get_line_charpos): Get rid of try/catch
10208         and only check for the return value of "ensure".
10209         * tui/tui-source.c (tui_source_window::set_contents):
10210         Simplify "nlines" calculation.
10211
10212 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
10213
10214         * MAINTAINERS (Write After Approval): Add myself.
10215
10216 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
10217
10218         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
10219         function call.
10220
10221 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
10222
10223         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
10224
10225 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
10226
10227         * nat/riscv-linux-tdesc.h: New file.
10228         * nat/riscv-linux-tdesc.c: New file, taking code from...
10229         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
10230         ... here.
10231         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
10232         NATDEPFILES.
10233
10234 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
10235
10236         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
10237         we don't set the fake simulator ptid to the null_ptid.
10238
10239 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
10240
10241         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
10242         * gdbthread.h (class thread_info) <resumed>: Likewise.
10243         * infrun.c (resume_1): Likewise.
10244         (proceed): Likewise.
10245         (infrun_thread_stop_requested): Likewise.
10246         (stop_all_threads): Likewise.
10247         (handle_inferior_event): Likewise.
10248         (restart_threads): Likewise.
10249         (finish_step_over): Likewise.
10250         (keep_going_stepped_thread): Likewise.
10251         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
10252         (linux_handle_extended_wait): Likewise.
10253         * record-btrace.c (get_thread_current_frame_id): Likewise.
10254         * record-full.c (record_full_wait_1): Likewise.
10255         * remote.c (remote_target::process_initial_stop_replies): Likewise.
10256         * target.c (target_resume): Likewise.
10257         * thread.c (set_running_thread): Likewise.
10258
10259 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
10260
10261         * f-valprint.c (f77_print_array_1): Changed datatype of index
10262         variable to LONGEST from int to enable it to contain bound
10263         values correctly.
10264
10265 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
10266
10267         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
10268         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
10269         offsets according to FLEN determined.
10270         (riscv_linux_nat_target::read_description): Determine FLEN
10271         dynamically.
10272         (riscv_linux_nat_target::fetch_registers): Size regset buffer
10273         according to FLEN determined.
10274         (riscv_linux_nat_target::store_registers): Likewise.
10275
10276 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
10277
10278         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
10279         when reg->group is empty and reggroup is not.
10280
10281 2020-01-31  Tom Tromey  <tromey@adacore.com>
10282
10283         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
10284         Call beneath target's mourn_inferior after unpushing.
10285
10286 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
10287
10288         PR tui/9765
10289         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
10290         have enough lines to fill the screen, still return the lowest
10291         address we found.
10292
10293 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
10294
10295         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
10296         '-', '<', and '>' commands.
10297
10298 2020-01-29  Pedro Alves  <palves@redhat.com>
10299             Sergio Durigan Junior  <sergiodj@redhat.com>
10300
10301         * infcmd.c (construct_inferior_arguments): Assert that
10302         'argc' is greater than 0.
10303
10304 2020-01-29  Luis Machado  <luis.machado@linaro.org>
10305
10306         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
10307         (BRK_INSN_MASK): Define to 0xd4200000.
10308         (aarch64_program_breakpoint_here_p): New function.
10309         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
10310         * arch-utils.c (default_program_breakpoint_here_p): Moved from
10311         breakpoint.c.
10312         * arch-utils.h (default_program_breakpoint_here_p): Moved from
10313         breakpoint.h
10314         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
10315         call gdbarch_program_breakpoint_here_p.
10316         (program_breakpoint_here): Moved to arch-utils.c, renamed to
10317         default_program_breakpoint_here_p, changed return type to bool and
10318         simplified.
10319         * breakpoint.h (program_breakpoint_here): Moved prototype to
10320         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
10321         return type to bool.
10322         * gdbarch.c: Regenerate.
10323         * gdbarch.h: Regenerate.
10324         * gdbarch.sh (program_breakpoint_here_p): New method.
10325         * infrun.c (handle_signal_stop): Call
10326         gdbarch_program_breakpoint_here_p.
10327
10328 2020-01-26  Tom Tromey  <tom@tromey.com>
10329
10330         * ctfread.c (struct ctf_fp_info): Reindent.
10331         (_initialize_ctfread): Remove.
10332
10333 2020-01-26  Tom Tromey  <tom@tromey.com>
10334
10335         * psymtab.c (partial_map_expand_apply)
10336         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
10337         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
10338         (psym_print_stats, psym_expand_symtabs_for_function)
10339         (psym_map_symbol_filenames, psym_map_matching_symbols)
10340         (psym_expand_symtabs_matching)
10341         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
10342         (maintenance_check_psymtabs): Use new methods.
10343         * psympriv.h (struct partial_symtab) <readin_p,
10344         get_compunit_symtab>: New methods.
10345         <readin, compunit_symtab>: Remove members.
10346         (struct standard_psymtab): New.
10347         (struct legacy_psymtab): Derive from standard_psymtab.
10348         * dwarf2read.h (struct dwarf2_psymtab): Derive from
10349         standard_psymtab.
10350         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
10351
10352 2020-01-26  Tom Tromey  <tom@tromey.com>
10353
10354         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
10355         read_dependencies.  Add assert.
10356         * psymtab.c (partial_symtab::read_dependencies): New method.
10357         * psympriv.h (struct partial_symtab) <read_dependencies>: New
10358         method.
10359         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
10360         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
10361         read_dependencies.
10362         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
10363         Add assert.
10364
10365 2020-01-26  Tom Tromey  <tom@tromey.com>
10366
10367         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
10368         Call expand_psymtab.
10369         (xcoff_read_symtab): Call expand_psymtab.
10370         (xcoff_start_psymtab, xcoff_end_psymtab): Set
10371         legacy_expand_psymtab.
10372         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
10373         method.
10374         (struct legacy_psymtab) <expand_psymtab>: Implement.
10375         <legacy_expand_psymtab>: New member.
10376         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
10377         (parse_partial_symbols): Set legacy_expand_psymtab.
10378         (psymtab_to_symtab_1): Change argument order.  Call
10379         expand_psymtab.
10380         (new_psymtab): Set legacy_expand_psymtab.
10381         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
10382         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
10383         expand_psymtab.
10384         (dwarf2_psymtab::expand_psymtab): Rename from
10385         psymtab_to_symtab_1.  Call expand_psymtab.
10386         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
10387         (dbx_end_psymtab): Likewise.
10388         (dbx_psymtab_to_symtab_1): Change argument order. Call
10389         expand_psymtab.
10390         (dbx_read_symtab): Call expand_psymtab.
10391         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
10392         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
10393         (ctf_psymtab::read_symtab): Call expand_psymtab.
10394
10395 2020-01-26  Tom Tromey  <tom@tromey.com>
10396
10397         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
10398         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
10399         messages.
10400         * mdebugread.c (mdebug_read_symtab): Remove prints.
10401         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
10402         assert.
10403         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
10404
10405 2020-01-26  Tom Tromey  <tom@tromey.com>
10406
10407         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
10408         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
10409         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
10410         legacy_symtab.
10411         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
10412         * psymtab.c (psymtab_to_symtab): Call method.
10413         (dump_psymtab): Update.
10414         * psympriv.h (struct partial_symtab): Add virtual destructor.
10415         <read_symtab>: New method.
10416         (struct legacy_symtab): New.
10417         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
10418         (struct pst_map) <pst>: Now a legacy_psymtab.
10419         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
10420         (new_psymtab): Use legacy_psymtab.
10421         * dwarf2read.h (struct dwarf2_psymtab): New.
10422         (struct dwarf2_per_cu_data) <psymtab>: Use it.
10423         * dwarf2read.c (dwarf2_create_include_psymtab)
10424         (dwarf2_build_include_psymtabs, create_type_unit_group)
10425         (create_partial_symtab, process_psymtab_comp_unit_reader)
10426         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
10427         (set_partial_user): Use dwarf2_psymtab.
10428         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
10429         (psymtab_to_symtab_1, process_full_comp_unit)
10430         (process_full_type_unit, dwarf2_ranges_read)
10431         (dwarf2_get_pc_bounds, psymtab_include_file_name)
10432         (dwarf_decode_lines): Use dwarf2_psymtab.
10433         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
10434         (add_address_entry_worker, write_one_signatured_type)
10435         (recursively_count_psymbols, recursively_write_psymbols)
10436         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
10437         (write_debug_names): Likewise.
10438         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
10439         <pst>: Now a legacy_psymtab.
10440         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
10441         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
10442         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
10443         * ctfread.c (struct ctf_psymtab): New.
10444         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
10445         ctf_psymtab.
10446         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
10447         (create_partial_symtab): Return a ctf_psymtab.
10448         (scan_partial_symbols): Update.
10449
10450 2020-01-26  Tom Tromey  <tom@tromey.com>
10451
10452         * xcoffread.c (xcoff_start_psymtab): Use new.
10453         * psymtab.c (partial_symtab::partial_symtab): New constructor,
10454         renamed from start_psymtab_common.
10455         * psympriv.h (struct partial_symtab): Add new constructor.
10456         (start_psymtab_common): Don't declare.
10457         * mdebugread.c (parse_partial_symbols): Use new.
10458         * dwarf2read.c (create_partial_symtab): Use new.
10459         * dbxread.c (start_psymtab): Use new.
10460         * ctfread.c (create_partial_symtab): Use new.
10461
10462 2020-01-26  Tom Tromey  <tom@tromey.com>
10463
10464         * xcoffread.c (xcoff_end_psymtab): Use new.
10465         * psymtab.c (start_psymtab_common): Use new.
10466         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
10467         Update.
10468         * psympriv.h (struct partial_symtab): Add parameters to
10469         constructor.  Don't inline.
10470         (allocate_psymtab): Don't declare.
10471         * mdebugread.c (new_psymtab): Use new.
10472         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
10473         * dbxread.c (dbx_end_psymtab): Use new.
10474
10475 2020-01-26  Tom Tromey  <tom@tromey.com>
10476
10477         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
10478         allocate_psymtab.  Update documentation.
10479         * psymtab.c (psymtab_storage::install_psymtab): Rename from
10480         allocate_psymtab.  Do not use new.
10481         (allocate_psymtab): Use new.  Update.
10482
10483 2020-01-26  Tom Tromey  <tom@tromey.com>
10484
10485         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
10486         * psymtab.c (psym_print_stats): Update.
10487         * psympriv.h (struct partial_symtab) <readin,
10488         psymtabs_addrmap_supported, anonymous>: Now bool.
10489         * mdebugread.c (psymtab_to_symtab_1): Update.
10490         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
10491         (build_type_psymtabs_reader, psymtab_to_symtab_1)
10492         (process_full_comp_unit, process_full_type_unit): Update.
10493         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
10494         * ctfread.c (psymtab_to_symtab): Update.
10495
10496 2020-01-26  Tom Tromey  <tom@tromey.com>
10497
10498         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
10499         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
10500         * psymtab.c (psymtab_storage): Delete psymtabs.
10501         (psymtab_storage::allocate_psymtab): Use new.
10502         (psymtab_storage::discard_psymtab): Use delete.
10503         * psympriv.h (struct partial_symtab): Add constructor and
10504         initializers.
10505
10506 2020-01-26  Tom Tromey  <tom@tromey.com>
10507
10508         * machoread.c: Do not include psympriv.h.
10509
10510 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10511
10512         * NEWS: Mention the new option and the set/show commands.
10513
10514 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10515
10516         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
10517         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
10518         (validate_exec_file): New variables, enums, functions.
10519         (exec_file_locate_attach, print_section_info): Style the filenames.
10520         (_initialize_exec): Install show_exec_file_mismatch_command and
10521          set_exec_file_mismatch_command.
10522         * gdbcore.h (validate_exec_file): Declare.
10523         * infcmd.c (attach_command): Call validate_exec_file.
10524         * remote.c ( remote_target::remote_add_inferior): Likewise.
10525
10526 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10527
10528         * frame.c (find_frame_sal): Move call to get_next_frame into more
10529         inner scope.
10530         * inline-frame.c (inilne_state) <inline_state>: Update argument
10531         types.
10532         (inilne_state) <skipped_symbol>: Rename to...
10533         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
10534         (skip_inline_frames): Build vector of skipped symbols and use this
10535         to reate the inline_state.
10536         (inline_skipped_symbol): Add a comment and some assertions, fetch
10537         skipped symbol from the list.
10538
10539 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10540
10541         * buildsym.c (lte_is_less_than): Delete.
10542         (buildsym_compunit::end_symtab_with_blockvector): Create local
10543         lambda function to sort line table entries, and use
10544         std::stable_sort instead of std::sort.
10545         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
10546         markers when looking for a previous line.
10547
10548 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10549
10550         * dwarf2read.c (lnp_state_machine::record_line): Include
10551         end_sequence parameter in debug print out.  Record the line if we
10552         are at an end_sequence marker even if it's not the start of a
10553         statement.
10554         * symmisc.c (maintenance_print_one_line_table): Print end of
10555         sequence markers with 'END' not '0'.
10556
10557 2020-01-24  Pedro Alves  <palves@redhat.com>
10558
10559         PR gdb/25410
10560         * thread.c (scoped_restore_current_thread::restore): Use
10561         switch_to_inferior_no_thread.
10562         * exec.c: Include "progspace-and-thread.h".
10563         (add_target_sections, remove_target_sections):
10564         scoped_restore_current_pspace_and_thread instead of
10565         scoped_restore_current_thread.
10566         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
10567         and aspace to the inferior before calling clone_program_space.
10568         Remove stale comment.
10569
10570 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
10571
10572         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
10573         (arm_netbsd_nat_target::fetch_registers): ...this.
10574         (arm_nbsd_nat_target::store_registers): Rename to...
10575         (arm_netbsd_nat_target::store_registers): ...this.
10576
10577 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
10578
10579         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
10580         register_t.
10581
10582 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
10583
10584         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
10585         Update comment.
10586         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
10587         Likewise.
10588         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
10589         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
10590         the correct replacement (iterate_over_regset_sections).
10591         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
10592         Update comment.
10593
10594 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
10595
10596         PR gdb/23718
10597         * gdb/python/python.c (execute_gdb_command): Call
10598         async_enable_stdin in catch block.
10599
10600 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10601
10602         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
10603         SWITCH_THRU_ALL_UIS.
10604
10605 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10606
10607         PR tui/9765
10608         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
10609         comment, add extra parameter, and update to store previous symbol
10610         when appropriate.
10611         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
10612         add extra parameter.
10613         * tui/tui-disasm.c (tui_disassemble): Update header comment,
10614         remove unneeded parameter, add try/catch around gdb_print_insn,
10615         rewrite to add items to asm_lines vector.
10616         (tui_find_backward_disassembly_start_address): New function.
10617         (tui_find_disassembly_address): Updated throughout.
10618         (tui_disasm_window::set_contents): Update for changes to
10619         tui_disassemble.
10620         (tui_disasm_window::do_scroll_vertical): No need to adjust the
10621         number of lines to scroll.
10622
10623 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
10624
10625         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
10626         (SECT_OFF_DATA): Likewise.
10627         (SECT_OFF_RODATA): Likewise.
10628         (SECT_OFF_TEXT): Likewise.
10629         (SECT_OFF_BSS): Likewise.
10630         (struct objfile) <text_section_offset, data_section_offset>: New
10631         methods.
10632         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
10633         objfile::text_section_offset.
10634         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
10635         * coffread.c (coff_symtab_read): Likewise.
10636         (enter_linenos): Likewise.
10637         (process_coff_symbol): Likewise.
10638         * ctfread.c (get_objfile_text_range): Likewise.
10639         * dtrace-probe.c (dtrace_probe::get_relocated_address):
10640         Use objfile::data_section_offset.
10641         * dwarf2-frame.c (execute_cfa_program): Use
10642         objfile::text_section_offset.
10643         (dwarf2_frame_find_fde): Likewise.
10644         * dwarf2read.c (create_addrmap_from_index): Likewise.
10645         (create_addrmap_from_aranges): Likewise.
10646         (dw2_find_pc_sect_compunit_symtab): Likewise.
10647         (process_psymtab_comp_unit_reader): Likewise.
10648         (add_partial_symbol): Likewise.
10649         (add_partial_subprogram): Likewise.
10650         (process_full_comp_unit): Likewise.
10651         (read_file_scope): Likewise.
10652         (read_func_scope): Likewise.
10653         (read_lexical_block_scope): Likewise.
10654         (read_call_site_scope): Likewise.
10655         (dwarf2_rnglists_process): Likewise.
10656         (dwarf2_ranges_process): Likewise.
10657         (dwarf2_ranges_read): Likewise.
10658         (dwarf_decode_lines_1): Likewise.
10659         (new_symbol): Likewise.
10660         (dwarf2_fetch_die_loc_sect_off): Likewise.
10661         (dwarf2_per_cu_text_offset): Likewise.
10662         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
10663         * hppa-tdep.c (read_unwind_info): Likewise.
10664         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
10665         * psympriv.h (struct partial_symtab): Likewise.
10666         * psymtab.c (find_pc_sect_psymtab): Likewise.
10667         * solib-svr4.c (enable_break): Likewise.
10668         * stap-probe.c (relocate_address): Use
10669         objfile::data_section_offset.
10670         * xcoffread.c (enter_line_range): Use
10671         objfile::text_section_offset.
10672         (read_xcoff_symtab): Likewise.
10673
10674 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
10675
10676         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
10677         declaration to narrower scopes.
10678
10679 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
10680
10681         * darwin-nat.h (struct darwin_exception_msg, enum
10682         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
10683         Move up.
10684         (class darwin_nat_target) <wait_1, check_new_threads,
10685         decode_exception_message, decode_message, stop_inferior,
10686         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
10687         * darwin-nat.c (darwin_check_new_threads): Rename to...
10688         (darwin_nat_target::check_new_threads): ... this.
10689         (darwin_suspend_inferior_it): Remove.
10690         (darwin_decode_exception_message): Rename to...
10691         (darwin_nat_target::decode_exception_message): ... this.
10692         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
10693         (darwin_decode_message): Rename to...
10694         (darwin_nat_target::decode_message): ... this.
10695         (cancel_breakpoint): Rename to...
10696         (darwin_nat_target::cancel_breakpoint): ... this.
10697         (darwin_wait): Rename to...
10698         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
10699         instead of iterate_over_inferiors.
10700         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
10701         (darwin_stop_inferior): Rename to...
10702         (darwin_nat_target::stop_inferior): ... this.
10703         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
10704         (darwin_init_thread_list): Rename to...
10705         (darwin_nat_target::init_thread_list): ... this.
10706         (darwin_ptrace_him): Rename to...
10707         (darwin_nat_target::ptrace_him): ... this.
10708         (darwin_nat_target::create_inferior): Pass lambda function to
10709         fork_inferior.
10710         (darwin_nat_target::detach): Call stop_inferior instead of
10711         darwin_stop_inferior.
10712         * fork-inferior.h (fork_inferior): Change init_trace_fun
10713         parameter to gdb::function_view.
10714         * fork-inferior.c (fork_inferior): Likewise.
10715
10716 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
10717
10718         * i386-cygwin-tdep.c (core_process_module_section): Update.
10719         * windows-nat.c (struct lm_info_windows): Add text_offset.
10720         (windows_xfer_shared_libraries): Update.
10721         * windows-tdep.c (windows_xfer_shared_library):
10722         Add text_offset_cached argument.
10723         * windows-tdep.h (windows_xfer_shared_library): Update.
10724
10725 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
10726
10727         * gdbarch.sh: Add declaration for _initialize_gdbarch.
10728
10729 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
10730
10731         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
10732         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
10733         replace with range-based for.
10734         (gdbsim_interrupt_inferior): Remove.
10735         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
10736         with a range-based for.  Inline code from
10737         gdbsim_interrupt_inferior.
10738
10739 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
10740
10741         * infrun.c (proceed): Fix indentation.
10742
10743 2020-01-21  Tom Tromey  <tromey@adacore.com>
10744
10745         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
10746         * python/python.c (python_extension_ops): Update.
10747         (gdbpy_colorize): New function.
10748         * python/lib/gdb/__init__.py (colorize): New function.
10749         * extension.h (ext_lang_colorize): Declare.
10750         * extension.c (ext_lang_colorize): New function.
10751         * extension-priv.h (struct extension_language_ops) <colorize>: New
10752         member.
10753         * cli/cli-style.c (_initialize_cli_style): Update help text.
10754
10755 2020-01-21  Luis Machado  <luis.machado@linaro.org>
10756
10757         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
10758         <cond>: Change type to bool.
10759         (aarch64_displaced_step_b_cond): Update cond to use bool type.
10760         (aarch64_displaced_step_cb): Likewise.
10761         (aarch64_displaced_step_tb): Likewise.
10762
10763 2020-01-21  Luis Machado  <luis.machado@linaro.org>
10764
10765         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
10766         output.
10767
10768 2020-01-21  Luis Machado  <luis.machado@linaro.org>
10769
10770         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
10771         <pc_adjust>: Adjust the documentation.
10772         (aarch64_displaced_step_fixup): Check if PC really moved before
10773         adjusting it.
10774
10775 2020-01-19  Tom Tromey  <tom@tromey.com>
10776
10777         * disasm.c (~gdb_disassembler): New destructor.
10778         (gdb_buffered_insn_length): Call disassemble_free_target.
10779         * disasm.h (class gdb_disassembler): Declare destructor.  Use
10780         DISABLE_COPY_AND_ASSIGN.
10781
10782 2020-01-19  Tom Tromey  <tom@tromey.com>
10783
10784         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
10785         (die_reader_func_ftype): Remove.
10786         (cutu_reader): New class.
10787         (dw2_get_file_names_reader): Remove "data" parameter.
10788         (dw2_get_file_names): Use cutu_reader.
10789         (create_debug_type_hash_table): Update.
10790         (read_cutu_die_from_dwo): Update comment.
10791         (lookup_dwo_unit): Add dwo_name parameter.
10792         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
10793         die_reader_func_ftype and data parameters.
10794         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
10795         Remove die_reader_func_ftype and data parameters.
10796         (~cutu_reader): New; from init_cutu_and_read_dies.
10797         (cutu_reader::cutu_reader): Rename from
10798         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
10799         and data parameters.
10800         (init_cutu_and_read_dies_simple): Remove.
10801         (struct process_psymtab_comp_unit_data): Remove.
10802         (process_psymtab_comp_unit_reader): Remove data parameter; add
10803         want_partial_unit and pretend_language parameters.
10804         (process_psymtab_comp_unit): Use cutu_reader.
10805         (build_type_psymtabs_reader): Remove data parameter.
10806         (build_type_psymtabs_1): Use cutu_reader.
10807         (process_skeletonless_type_unit): Likewise.
10808         (load_partial_comp_unit_reader): Remove.
10809         (load_partial_comp_unit): Use cutu_reader.
10810         (load_full_comp_unit_reader): Remove.
10811         (load_full_comp_unit): Use cutu_reader.
10812         (struct create_dwo_cu_data): Remove.
10813         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
10814         dwo_unit parameters.
10815         (create_cus_hash_table): Use cutu_reader.
10816         (struct dwarf2_read_addr_index_data): Remove.
10817         (dwarf2_read_addr_index_reader): Remove.
10818         (dwarf2_read_addr_index): Use cutu_reader.
10819         (read_signatured_type_reader): Remove.
10820         (read_signatured_type): Use cutu_reader.
10821
10822 2020-01-19  Tom Tromey  <tom@tromey.com>
10823
10824         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
10825         * tui/tui-wingeneral.h (class tui_suppress_output): New.
10826         (tui_wrefresh): Declare.
10827         * tui/tui-wingeneral.c (suppress_output): New global.
10828         (tui_suppress_output, ~tui_suppress_output): New constructor and
10829         destructor.
10830         (tui_wrefresh): New function.
10831         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
10832         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
10833         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
10834         method.
10835         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
10836         tui_wrefresh.
10837         (tui_data_window::no_refresh): New method.
10838         (tui_data_item_window::refresh_window): Call tui_wrefresh.
10839         (tui_reg_command): Use tui_suppress_output
10840         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
10841         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
10842         method.
10843         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
10844
10845 2020-01-19  Tom Tromey  <tom@tromey.com>
10846
10847         * tui/tui-winsource.c (tui_update_source_windows_with_line):
10848         Handle case where symtab is null.
10849
10850 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
10851
10852         * linux-fork.c (one_fork_p): Simplify.
10853
10854 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10855
10856         * top.c (struct qt_args): Remove.
10857         (kill_or_detach): Change return type to void, replace `void *`
10858         parameter with a proper one.
10859         (print_inferior_quit_action):  Likewise.
10860         (quit_confirm): Use range-based for loop to iterate over inferiors.
10861         (quit_force): Likewise.
10862
10863 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10864
10865         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
10866         `void *` parameter with proper parameters.
10867         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
10868         (print_one_inferior): Change return type to void, replace `void *`
10869         parameter with proper parameters.
10870         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
10871         inferiors.
10872         (get_other_inferior): Remove.
10873         (mi_cmd_remove_inferior): Use range-based loop to iterate over
10874         inferiors.
10875
10876 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10877
10878         * mi/mi-interp.c (report_initial_inferior): Remove.
10879         (mi_interp::init): Use range-based for to iterate over inferiors.
10880
10881 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10882
10883         * python/py-inferior.c (build_inferior_list): Remove.
10884         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
10885
10886 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
10887
10888         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
10889         (btrace_stitch_trace): Likewise.
10890         * charset.c (intermediate_encoding): Likewise (vaild).
10891         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
10892         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
10893         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
10894
10895 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
10896
10897         * windows-tdep.c (windows_get_tlb_type):
10898         Add rtl_user_process_parameters type.
10899
10900 2020-01-16  Pedro Alves  <palves@redhat.com>
10901             Norbert Lange  <nolange79@gmail.com>
10902
10903         PR build/24805
10904         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
10905         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
10906         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
10907         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
10908         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
10909         (ps_plog): Redeclare exported functions with default visibility.
10910
10911 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
10912
10913         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
10914         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
10915
10916 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
10917
10918         * infcmd.c (post_create_inferior): Use get_thread_regcache
10919         instead of get_current_regcache.
10920
10921 2020-01-14  Tom Tromey  <tom@tromey.com>
10922
10923         PR symtab/12535:
10924         * python/python.c (gdbpy_decode_line): Treat empty string the same
10925         as no argument.
10926
10927 2020-01-14  Tom Tromey  <tom@tromey.com>
10928
10929         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
10930
10931 2020-01-14  Tom Tromey  <tom@tromey.com>
10932
10933         * nat/linux-btrace.c: Don't include <config.h>.
10934         * nat/linux-ptrace.c: Don't include <config.h>.
10935         * nat/x86-linux-dregs.c: Don't include <config.h>.
10936
10937 2020-01-14  Tom Tromey  <tom@tromey.com>
10938
10939         * configure: Rebuild.
10940         * configure.ac: Move many checks to ../gdbsupport/common.m4.
10941
10942 2020-01-14  Tom Tromey  <tom@tromey.com>
10943
10944         * nat/x86-linux-dregs.c: Include configh.h.
10945         * nat/linux-ptrace.c: Include configh.h.
10946         * nat/linux-btrace.c: Include configh.h.
10947         * defs.h: Include config.h, bfd.h.
10948         * configure.ac: Don't source common.host.
10949         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
10950         * configure: Rebuild.
10951         * acinclude.m4: Update path.
10952         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
10953         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
10954         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
10955         (CLIBS): Add LIBSUPPORT.
10956         (CDEPS): Likewise.
10957         (COMMON_SFILES): Remove gdbsupport files.
10958         (HFILES_NO_SRCDIR): Likewise.
10959         (stamp-version): Update path to create-version.sh.
10960         (ALLDEPFILES): Remove gdbsupport files.
10961
10962 2020-01-14  Tom Tromey  <tom@tromey.com>
10963
10964         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
10965         USE_WIN32API when needed.
10966         * configure.ac (USE_WIN32API): Don't define.
10967         (WIN32LIBS): Use WIN32APILIBS.
10968         * configure: Rebuild.
10969
10970 2020-01-14  Tom Tromey  <tom@tromey.com>
10971
10972         * configure: Rebuild.
10973         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
10974
10975 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10976
10977         * skip.c (skip_function_command): Make skip w/o arguments use the
10978         name of the inlined function if pc is inside any inlined function.
10979
10980 2020-01-14  Luis Machado  <luis.machado@linaro.org>
10981
10982         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
10983         * infrun.c (resume_1): Likewise.
10984         (handle_inferior_event): Remove stale comment.
10985         * linux-nat.c (linux_nat_target::resume): Update comments.
10986         (save_stop_reason): Likewise.
10987         (linux_nat_filter_event): Likewise.
10988         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
10989
10990 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10991
10992         * elfread.c (record_minimal_symbol): Set section index to 0 for
10993         non-allocatable sections.
10994
10995
10996 2020-01-13  Ali Tamur <tamur@google.com>
10997
10998         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
10999         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
11000         to gdb::optional.  Update comments.
11001         (dwo_file): Update comments.
11002         (read_attribute): Update API to take an additional out parameter,
11003         need_reprocess.  This is used to mark attributes that need other
11004         attributes (e.g. str_offsets_base) for correct computation which may not
11005         have been read yet.
11006         (read_attribute_reprocess): New function declaration.
11007         (read_addr_index): Likewise.
11008         (read_dwo_str_index): Likewise.
11009         (read_stub_str_index): Likewise.
11010         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
11011         (lookup_addr_base): New function definition.
11012         (lookup_ranges_base): Likewise.
11013         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
11014         lookup_ranges_base.
11015         (init_cutu_and_read_dies): Update comments.
11016         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
11017         unit.  This is used to inherit parent's str_offsets_base and addr_base.
11018         Update comments.
11019         (init_cutu_and_read_dies_simple): Reflect API changes.
11020         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
11021         (create_cus_hash_table): Change API to take parent compile unit.
11022         Reflect API changes.
11023         (open_and_init_dwo_file): Reflect API changes.
11024         (dwarf2_get_pc_bounds): Update comments.
11025         (dwarf2_record_block_ranges): Likewise.
11026         (read_full_die_1): Change implementation to reprocess attributes that
11027         need str_offsets_base and addr_base.
11028         (partial_die_info::read): Likewise.
11029         (read_attribute_reprocess): New function definition.
11030         (read_attribute_value): Change API to take an additional out parameter,
11031         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
11032         when a non-dwo compile unit has index based attributes.
11033         (read_attribute): Reflect API changes.
11034         (read_addr_index_1): Reflect API changes.  Update comments.
11035         (dwarf2_read_addr_index_data): Reflect API changes.
11036         (dwarf2_read_addr_index): Likewise.
11037         (read_str_index): Change API and implementation.  This becomes a helper
11038         to be used by the new string index related methods.  Update error
11039         message and comments.
11040         (read_dwo_str_index): New function definition.
11041         (read_stub_str_index): Likewise.
11042         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
11043         * symfile.h (dwarf2_debug_sections): Likewise.
11044         * xcoffread.c (dwarf2_debug_sections): Likewise.
11045
11046 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
11047
11048         * gdbcore.h (struct core_fns) <core_read_registers>: Change
11049         core_reg_sect type to gdb_byte *.
11050         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
11051         * cris-tdep.c (fetch_core_registers): Likewise.
11052         * corelow.c (core_target::get_core_register_section): Change
11053         type of `contents` to gdb::byte_vector.
11054
11055 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11056
11057         * tui/tui-wingeneral.c (box_win): Position the title in the center
11058         of the border.
11059
11060 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
11061
11062         * corelow.c (core_target::get_core_register_section): Use
11063           std::vector instead of alloca.
11064
11065 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
11066
11067         * warning.m4: Add -Wmissing-declarations to build_warnings.
11068         * configure: Re-generate.
11069
11070 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
11071
11072         * python/python.c (init__gdb_module): Add declaration.
11073
11074 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
11075
11076         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
11077         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
11078         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
11079         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
11080         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
11081         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
11082         * ada-exp.y (_initialize_ada_exp): Add declaration.
11083         * ada-lang.c (_initialize_ada_language): Add declaration.
11084         * ada-tasks.c (_initialize_tasks): Add declaration.
11085         * agent.c (_initialize_agent): Add declaration.
11086         * aix-thread.c (_initialize_aix_thread): Add declaration.
11087         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
11088         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
11089         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
11090         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
11091         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
11092         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
11093         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
11094         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
11095         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
11096         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
11097         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
11098         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
11099         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
11100         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
11101         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
11102         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
11103         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
11104         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
11105         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
11106         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
11107         * annotate.c (_initialize_annotate): Add declaration.
11108         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
11109         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
11110         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
11111         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
11112         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
11113         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
11114         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
11115         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
11116         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
11117         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
11118         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
11119         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
11120         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
11121         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
11122         * auto-load.c (_initialize_auto_load): Add declaration.
11123         * auxv.c (_initialize_auxv): Add declaration.
11124         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
11125         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
11126         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
11127         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
11128         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
11129         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
11130         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
11131         * breakpoint.c (_initialize_breakpoint): Add declaration.
11132         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
11133         * btrace.c (_initialize_btrace): Add declaration.
11134         * charset.c (_initialize_charset): Add declaration.
11135         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
11136         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
11137         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
11138         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
11139         * cli/cli-script.c (_initialize_cli_script): Add declaration.
11140         * cli/cli-style.c (_initialize_cli_style): Add declaration.
11141         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
11142         * coffread.c (_initialize_coffread): Add declaration.
11143         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
11144         * compile/compile.c (_initialize_compile): Add declaration.
11145         * complaints.c (_initialize_complaints): Add declaration.
11146         * completer.c (_initialize_completer): Add declaration.
11147         * copying.c (_initialize_copying): Add declaration.
11148         * corefile.c (_initialize_core): Add declaration.
11149         * corelow.c (_initialize_corelow): Add declaration.
11150         * cp-abi.c (_initialize_cp_abi): Add declaration.
11151         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
11152         * cp-support.c (_initialize_cp_support): Add declaration.
11153         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
11154         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
11155         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
11156         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
11157         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
11158         * ctfread.c (_initialize_ctfread): Add declaration.
11159         * d-lang.c (_initialize_d_language): Add declaration.
11160         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
11161         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
11162         * dbxread.c (_initialize_dbxread): Add declaration.
11163         * dcache.c (_initialize_dcache): Add declaration.
11164         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
11165         * disasm.c (_initialize_disasm): Add declaration.
11166         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
11167         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
11168         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
11169         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
11170         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
11171         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
11172         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
11173         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
11174         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
11175         * elfread.c (_initialize_elfread): Add declaration.
11176         * exec.c (_initialize_exec): Add declaration.
11177         * extension.c (_initialize_extension): Add declaration.
11178         * f-lang.c (_initialize_f_language): Add declaration.
11179         * f-valprint.c (_initialize_f_valprint): Add declaration.
11180         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
11181         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
11182         * filesystem.c (_initialize_filesystem): Add declaration.
11183         * findcmd.c (_initialize_mem_search): Add declaration.
11184         * findvar.c (_initialize_findvar): Add declaration.
11185         * fork-child.c (_initialize_fork_child): Add declaration.
11186         * frame-base.c (_initialize_frame_base): Add declaration.
11187         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
11188         * frame.c (_initialize_frame): Add declaration.
11189         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
11190         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
11191         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
11192         * gcore.c (_initialize_gcore): Add declaration.
11193         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
11194         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
11195         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
11196         * gdbarch.c (_initialize_gdbarch): Add declaration.
11197         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
11198         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
11199         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
11200         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
11201         * go-lang.c (_initialize_go_language): Add declaration.
11202         * go32-nat.c (_initialize_go32_nat): Add declaration.
11203         * guile/guile.c (_initialize_guile): Add declaration.
11204         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
11205         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
11206         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
11207         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
11208         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
11209         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
11210         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
11211         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
11212         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
11213         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
11214         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
11215         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
11216         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
11217         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
11218         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
11219         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
11220         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
11221         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
11222         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
11223         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
11224         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
11225         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
11226         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
11227         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
11228         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
11229         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
11230         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
11231         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
11232         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
11233         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
11234         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
11235         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
11236         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
11237         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
11238         * infcall.c (_initialize_infcall): Add declaration.
11239         * infcmd.c (_initialize_infcmd): Add declaration.
11240         * inflow.c (_initialize_inflow): Add declaration.
11241         * infrun.c (_initialize_infrun): Add declaration.
11242         * interps.c (_initialize_interpreter): Add declaration.
11243         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
11244         * jit.c (_initialize_jit): Add declaration.
11245         * language.c (_initialize_language): Add declaration.
11246         * linux-fork.c (_initialize_linux_fork): Add declaration.
11247         * linux-nat.c (_initialize_linux_nat): Add declaration.
11248         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
11249         * linux-thread-db.c (_initialize_thread_db): Add declaration.
11250         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
11251         * m2-lang.c (_initialize_m2_language): Add declaration.
11252         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
11253         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
11254         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
11255         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
11256         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
11257         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
11258         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
11259         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
11260         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
11261         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
11262         * machoread.c (_initialize_machoread): Add declaration.
11263         * macrocmd.c (_initialize_macrocmd): Add declaration.
11264         * macroscope.c (_initialize_macroscope): Add declaration.
11265         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
11266         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
11267         * maint.c (_initialize_maint_cmds): Add declaration.
11268         * mdebugread.c (_initialize_mdebugread): Add declaration.
11269         * memattr.c (_initialize_mem): Add declaration.
11270         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
11271         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
11272         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
11273         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
11274         * mi/mi-main.c (_initialize_mi_main): Add declaration.
11275         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
11276         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
11277         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
11278         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
11279         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
11280         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
11281         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
11282         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
11283         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
11284         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
11285         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
11286         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
11287         * mipsread.c (_initialize_mipsread): Add declaration.
11288         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
11289         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
11290         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
11291         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
11292         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
11293         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
11294         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
11295         * nto-procfs.c (_initialize_procfs): Add declaration.
11296         * objc-lang.c (_initialize_objc_language): Add declaration.
11297         * observable.c (_initialize_observer): Add declaration.
11298         * opencl-lang.c (_initialize_opencl_language): Add declaration.
11299         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
11300         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
11301         * osabi.c (_initialize_gdb_osabi): Add declaration.
11302         * osdata.c (_initialize_osdata): Add declaration.
11303         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
11304         * parse.c (_initialize_parse): Add declaration.
11305         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
11306         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
11307         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
11308         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
11309         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
11310         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
11311         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
11312         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
11313         * printcmd.c (_initialize_printcmd): Add declaration.
11314         * probe.c (_initialize_probe): Add declaration.
11315         * proc-api.c (_initialize_proc_api): Add declaration.
11316         * proc-events.c (_initialize_proc_events): Add declaration.
11317         * proc-service.c (_initialize_proc_service): Add declaration.
11318         * procfs.c (_initialize_procfs): Add declaration.
11319         * producer.c (_initialize_producer): Add declaration.
11320         * psymtab.c (_initialize_psymtab): Add declaration.
11321         * python/python.c (_initialize_python): Add declaration.
11322         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
11323         * record-btrace.c (_initialize_record_btrace): Add declaration.
11324         * record-full.c (_initialize_record_full): Add declaration.
11325         * record.c (_initialize_record): Add declaration.
11326         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
11327         * regcache.c (_initialize_regcache): Add declaration.
11328         * reggroups.c (_initialize_reggroup): Add declaration.
11329         * remote-notif.c (_initialize_notif): Add declaration.
11330         * remote-sim.c (_initialize_remote_sim): Add declaration.
11331         * remote.c (_initialize_remote): Add declaration.
11332         * reverse.c (_initialize_reverse): Add declaration.
11333         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
11334         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
11335         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
11336         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
11337         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
11338         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
11339         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
11340         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
11341         Add declaration.
11342         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
11343         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
11344         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
11345         * rust-exp.y (_initialize_rust_exp): Add declaration.
11346         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
11347         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
11348         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
11349         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
11350         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
11351         * score-tdep.c (_initialize_score_tdep): Add declaration.
11352         * ser-go32.c (_initialize_ser_dos): Add declaration.
11353         * ser-mingw.c (_initialize_ser_windows): Add declaration.
11354         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
11355         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
11356         * ser-uds.c (_initialize_ser_socket): Add declaration.
11357         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
11358         * serial.c (_initialize_serial): Add declaration.
11359         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
11360         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
11361         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
11362         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
11363         * skip.c (_initialize_step_skip): Add declaration.
11364         * sol-thread.c (_initialize_sol_thread): Add declaration.
11365         * solib-aix.c (_initialize_solib_aix): Add declaration.
11366         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
11367         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
11368         * solib-frv.c (_initialize_frv_solib): Add declaration.
11369         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
11370         * solib-target.c (_initialize_solib_target): Add declaration.
11371         * solib.c (_initialize_solib): Add declaration.
11372         * source-cache.c (_initialize_source_cache): Add declaration.
11373         * source.c (_initialize_source): Add declaration.
11374         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
11375         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
11376         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
11377         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
11378         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
11379         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
11380         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
11381         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
11382         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
11383         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
11384         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
11385         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
11386         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
11387         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
11388         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
11389         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
11390         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
11391         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
11392         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
11393         * stabsread.c (_initialize_stabsread): Add declaration.
11394         * stack.c (_initialize_stack): Add declaration.
11395         * stap-probe.c (_initialize_stap_probe): Add declaration.
11396         * std-regs.c (_initialize_frame_reg): Add declaration.
11397         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
11398         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
11399         * symfile.c (_initialize_symfile): Add declaration.
11400         * symmisc.c (_initialize_symmisc): Add declaration.
11401         * symtab.c (_initialize_symtab): Add declaration.
11402         * target.c (_initialize_target): Add declaration.
11403         * target-connection.c (_initialize_target_connection): Add
11404         declaration.
11405         * target-dcache.c (_initialize_target_dcache): Add declaration.
11406         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
11407         * thread.c (_initialize_thread): Add declaration.
11408         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
11409         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
11410         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
11411         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
11412         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
11413         * tracectf.c (_initialize_ctf): Add declaration.
11414         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
11415         * tracefile.c (_initialize_tracefile): Add declaration.
11416         * tracepoint.c (_initialize_tracepoint): Add declaration.
11417         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
11418         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
11419         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
11420         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
11421         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
11422         * tui/tui-win.c (_initialize_tui_win): Add declaration.
11423         * tui/tui.c (_initialize_tui): Add declaration.
11424         * typeprint.c (_initialize_typeprint): Add declaration.
11425         * ui-style.c (_initialize_ui_style): Add declaration.
11426         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
11427         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
11428         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
11429         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
11430         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
11431         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
11432         * unittests/filtered_iterator-selftests.c
11433         (_initialize_filtered_iterator_selftests): Add declaration.
11434         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
11435         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
11436         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
11437         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
11438         * unittests/main-thread-selftests.c
11439         (_initialize_main_thread_selftests): Add declaration.
11440         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
11441         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
11442         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
11443         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
11444         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
11445         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
11446         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
11447         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
11448         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
11449         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
11450         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
11451         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
11452         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
11453         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
11454         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
11455         declaration.
11456         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
11457         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
11458         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
11459         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
11460         * user-regs.c (_initialize_user_regs): Add declaration.
11461         * utils.c (_initialize_utils): Add declaration.
11462         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
11463         * valops.c (_initialize_valops): Add declaration.
11464         * valprint.c (_initialize_valprint): Add declaration.
11465         * value.c (_initialize_values): Add declaration.
11466         * varobj.c (_initialize_varobj): Add declaration.
11467         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
11468         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
11469         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
11470         * windows-nat.c (_initialize_windows_nat): Add declaration.
11471         (_initialize_check_for_gdb_ini): Add declaration.
11472         (_initialize_loadable): Add declaration.
11473         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
11474         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
11475         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
11476         * xcoffread.c (_initialize_xcoffread): Add declaration.
11477         * xml-support.c (_initialize_xml_support): Add declaration.
11478         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
11479         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
11480         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
11481         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
11482
11483 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
11484
11485         * regformats/regdat.sh: Generate declaration for init function.
11486
11487 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
11488
11489         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
11490         up.
11491         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
11492         close_one_inferior>: New methods.
11493         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
11494         pass down target to find_inferior_pid.
11495         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
11496         Pass down target to find_inferior_ptid.
11497         (gdbsim_target::create_inferior): Pass down target to
11498         add_thread_silent.
11499         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
11500         target down to find_inferior_ptid and switch_to_thread.
11501         (gdbsim_target::close): Update to call close_one_inferior.
11502         (struct resume_data): Remove.
11503         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
11504         directly, rather than through a void pointer.
11505         (gdbsim_target::resume): Update to call resume_one_inferior.
11506
11507 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
11508
11509         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
11510
11511 2020-01-12  Pedro Alves  <palves@redhat.com>
11512
11513         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
11514         directly for the current inferior instead of
11515         discard_all_inferiors.
11516         (discard_all_inferiors): Delete.
11517
11518 2020-01-11  Tom Tromey  <tom@tromey.com>
11519
11520         * tui/tui-wingeneral.c (box_win): Check cli_styling.
11521         * tui/tui-winsource.c (tui_source_window_base::refill): Use
11522         deprecated_safe_get_selected_frame.
11523
11524 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
11525
11526         * inferior.c (print_inferior): Switch inferior before printing it.
11527
11528 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
11529             Pedro Alves  <palves@redhat.com>
11530
11531         * progspace-and-thread.c (switch_to_program_space_and_thread):
11532         Assert there's an inferior for PSPACE.  Use
11533         switch_to_inferior_no_thread to switch the inferior too.
11534         * progspace.c (program_space::~program_space): Call
11535         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
11536         (program_space::free_all_objfiles): Don't call clear_symtab_users
11537         here.
11538         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
11539
11540 2020-01-10  Pedro Alves  <palves@redhat.com>
11541
11542         * NEWS: Mention multi-target debugging, "info connections", and
11543         "add-inferior -no-connection".
11544
11545 2020-01-10  Pedro Alves  <palves@redhat.com>
11546
11547         * infrun.c: Include "target-connection.h".
11548         (check_multi_target_resumption): New.
11549         (proceed): Call it.
11550         * target-connection.c (make_target_connection_string): Make
11551         extern.
11552         * target-connection.h (make_target_connection_string): Declare.
11553
11554 2020-01-10  Pedro Alves  <palves@redhat.com>
11555
11556         * Makefile.in (COMMON_SFILES): Add target-connection.c.
11557         * inferior.c (uiout_field_connection): New function.
11558         (print_inferior): Add new "connection-id" column.
11559         (add_inferior_command): Show connection number/string of added
11560         inferior.
11561         * process-stratum-target.h
11562         (process_stratum_target::connection_string): New virtual method.
11563         (process_stratum_target::connection_number): New field.
11564         * remote.c (remote_target::connection_string): New override.
11565         * target-connection.c: New file.
11566         * target-connection.h: New file.
11567         * target.c (decref_target): Remove process_stratum targets from
11568         the connection list.
11569         (target_stack::push): Add process_stratum targets to the
11570         connection list.
11571
11572 2020-01-10  Pedro Alves  <palves@redhat.com>
11573
11574         Revert:
11575         2016-04-12  Pedro Alves  <palves@redhat.com>
11576         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
11577         Remove references to name.
11578         * serial.h (struct serial) <name>: Delete.
11579
11580 2020-01-10  Pedro Alves  <palves@redhat.com>
11581
11582         * gdbarch-selftests.c (register_to_value_test): Remove "target
11583         already pushed" check.
11584
11585 2020-01-10  Pedro Alves  <palves@redhat.com>
11586             John Baldwin  <jhb@FreeBSD.org>
11587
11588         * aarch64-linux-nat.c
11589         (aarch64_linux_nat_target::thread_architecture): Adjust.
11590         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
11591         (task_command_1): Likewise.
11592         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
11593         (aix_thread_target::wait, aix_thread_target::fetch_registers)
11594         (aix_thread_target::store_registers)
11595         (aix_thread_target::thread_alive): Adjust.
11596         * amd64-fbsd-tdep.c: Include "inferior.h".
11597         (amd64fbsd_get_thread_local_address): Pass down target.
11598         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
11599         thread's gdbarch instead of target_gdbarch.
11600         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
11601         get_last_target_status.
11602         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
11603         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
11604         inferiors.
11605         (update_inserted_breakpoint_locations): Skip if inferiors with no
11606         execution.
11607         (update_global_location_list): When handling moribund locations,
11608         find representative inferior for location's pspace, and use thread
11609         count of its process_stratum target.
11610         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
11611         * bsd-uthread.c (bsd_uthread_target::wait): Use
11612         as_process_stratum_target and adjust thread_change_ptid and
11613         add_thread calls.
11614         (bsd_uthread_target::update_thread_list): Use
11615         as_process_stratum_target and adjust find_thread_ptid,
11616         thread_change_ptid and add_thread calls.
11617         * btrace.c (maint_btrace_packet_history_cmd): Adjust
11618         find_thread_ptid call.
11619         * corelow.c (add_to_thread_list): Adjust add_thread call.
11620         (core_target_open): Adjust add_thread_silent and thread_count
11621         calls.
11622         (core_target::pid_to_str): Adjust find_inferior_ptid call.
11623         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
11624         * event-top.c (async_disconnect): Pop targets from all inferiors.
11625         * exec.c (add_target_sections): Push exec target on all inferiors
11626         sharing the program space.
11627         (remove_target_sections): Remove the exec target from all
11628         inferiors sharing the program space.
11629         (exec_on_vfork): New.
11630         * exec.h (exec_on_vfork): Declare.
11631         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
11632         Pass it down.
11633         (fbsd_nat_target::update_thread_list): Adjust.
11634         (fbsd_nat_target::resume): Adjust.
11635         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
11636         down.
11637         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
11638         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
11639         get_thread_arch_regcache call.
11640         * fork-child.c (gdb_startup_inferior): Pass target down to
11641         startup_inferior and set_executing.
11642         * gdbthread.h (struct process_stratum_target): Forward declare.
11643         (add_thread, add_thread_silent, add_thread_with_info)
11644         (in_thread_list): Add process_stratum_target parameter.
11645         (find_thread_ptid(inferior*, ptid_t)): New overload.
11646         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
11647         parameter.
11648         (all_threads()): Delete overload.
11649         (all_threads, all_non_exited_threads): Add process_stratum_target
11650         parameter.
11651         (all_threads_safe): Use brace initialization.
11652         (thread_count): Add process_stratum_target parameter.
11653         (set_resumed, set_running, set_stop_requested, set_executing)
11654         (threads_are_executing, finish_thread_state): Add
11655         process_stratum_target parameter.
11656         (switch_to_thread): Use is_current_thread.
11657         * i386-fbsd-tdep.c: Include "inferior.h".
11658         (i386fbsd_get_thread_local_address): Pass down target.
11659         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
11660         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
11661         have_inferiors check.
11662         * inf-ptrace.c (inf_ptrace_target::create_inferior)
11663         (inf_ptrace_target::attach): Adjust.
11664         * infcall.c (run_inferior_call): Adjust.
11665         * infcmd.c (run_command_1): Pass target to
11666         scoped_finish_thread_state.
11667         (proceed_thread_callback): Skip inferiors with no execution.
11668         (continue_command): Rename 'all_threads' local to avoid hiding
11669         'all_threads' function.  Adjust get_last_target_status call.
11670         (prepare_one_step): Adjust set_running call.
11671         (signal_command): Use user_visible_resume_target.  Compare thread
11672         pointers instead of inferior_ptid.
11673         (info_program_command): Adjust to pass down target.
11674         (attach_command): Mark target's 'thread_executing' flag.
11675         (stop_current_target_threads_ns): New, factored out from ...
11676         (interrupt_target_1): ... this.  Switch inferior before making
11677         target calls.
11678         * inferior-iter.h
11679         (struct all_inferiors_iterator, struct all_inferiors_range)
11680         (struct all_inferiors_safe_range)
11681         (struct all_non_exited_inferiors_range): Filter on
11682         process_stratum_target too.  Remove explicit.
11683         * inferior.c (inferior::inferior): Push dummy target on target
11684         stack.
11685         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
11686         Add process_stratum_target parameter, and pass it down.
11687         (have_live_inferiors): Adjust.
11688         (switch_to_inferior_and_push_target): New.
11689         (add_inferior_command, clone_inferior_command): Handle
11690         "-no-connection" parameter.  Use
11691         switch_to_inferior_and_push_target.
11692         (_initialize_inferior): Mention "-no-connection" option in
11693         the help of "add-inferior" and "clone-inferior" commands.
11694         * inferior.h: Include "process-stratum-target.h".
11695         (interrupt_target_1): Use bool.
11696         (struct inferior) <push_target, unpush_target, target_is_pushed,
11697         find_target_beneath, top_target, process_target, target_at,
11698         m_stack>: New.
11699         (discard_all_inferiors): Delete.
11700         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
11701         (all_inferiors, all_non_exited_inferiors): Add
11702         process_stratum_target parameter.
11703         * infrun.c: Include "gdb_select.h" and <unordered_map>.
11704         (target_last_proc_target): New global.
11705         (follow_fork_inferior): Push target on new inferior.  Pass target
11706         to add_thread_silent.  Call exec_on_vfork.  Handle target's
11707         reference count.
11708         (follow_fork): Adjust get_last_target_status call.  Also consider
11709         target.
11710         (follow_exec): Push target on new inferior.
11711         (struct execution_control_state) <target>: New field.
11712         (user_visible_resume_target): New.
11713         (do_target_resume): Call target_async.
11714         (resume_1): Set target's threads_executing flag.  Consider resume
11715         target.
11716         (commit_resume_all_targets): New.
11717         (proceed): Also consider resume target.  Skip threads of inferiors
11718         with no execution.  Commit resumtion in all targets.
11719         (start_remote): Pass current inferior to wait_for_inferior.
11720         (infrun_thread_stop_requested): Consider target as well.  Pass
11721         thread_info pointer to clear_inline_frame_state instead of ptid.
11722         (infrun_thread_thread_exit): Consider target as well.
11723         (random_pending_event_thread): New inferior parameter.  Use it.
11724         (do_target_wait): Rename to ...
11725         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
11726         down.
11727         (threads_are_resumed_pending_p, do_target_wait): New.
11728         (prepare_for_detach): Adjust calls.
11729         (wait_for_inferior): New inferior parameter.  Handle it.  Use
11730         do_target_wait_1 instead of do_target_wait.
11731         (fetch_inferior_event): Adjust.  Switch to representative
11732         inferior.  Pass target down.
11733         (set_last_target_status): Add process_stratum_target parameter.
11734         Save target in global.
11735         (get_last_target_status): Add process_stratum_target parameter and
11736         handle it.
11737         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
11738         (context_switch): Check inferior_ptid == null_ptid before calling
11739         inferior_thread().
11740         (get_inferior_stop_soon): Pass down target.
11741         (wait_one): Rename to ...
11742         (poll_one_curr_target): ... this.
11743         (struct wait_one_event): New.
11744         (wait_one): New.
11745         (stop_all_threads): Adjust.
11746         (handle_no_resumed, handle_inferior_event): Adjust to consider the
11747         event's target.
11748         (switch_back_to_stepped_thread): Also consider target.
11749         (print_stop_event): Update.
11750         (normal_stop): Update.  Also consider the resume target.
11751         * infrun.h (wait_for_inferior): Remove declaration.
11752         (user_visible_resume_target): New declaration.
11753         (get_last_target_status, set_last_target_status): New
11754         process_stratum_target parameter.
11755         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
11756         process_stratum_target parameter, and use it.
11757         (clear_inline_frame_state (thread_info*)): New.
11758         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
11759         process_stratum_target parameter.
11760         (clear_inline_frame_state (thread_info*)): Declare.
11761         * linux-fork.c (delete_checkpoint_command): Pass target down to
11762         find_thread_ptid.
11763         (checkpoint_command): Adjust.
11764         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
11765         instead of just tweaking inferior_ptid.
11766         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
11767         (exit_lwp): Pass target down to find_thread_ptid.
11768         (attach_proc_task_lwp_callback): Pass target down to
11769         add_thread/set_running/set_executing.
11770         (linux_nat_target::attach): Pass target down to
11771         thread_change_ptid.
11772         (get_detach_signal): Pass target down to find_thread_ptid.
11773         Consider last target status's target.
11774         (linux_resume_one_lwp_throw, resume_lwp)
11775         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
11776         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
11777         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
11778         (linux_nat_target::async_wait_fd): New.
11779         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
11780         target down.
11781         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
11782         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
11783         * linux-thread-db.c (struct thread_db_info::process_target): New
11784         field.
11785         (add_thread_db_info): Save target.
11786         (get_thread_db_info): New process_stratum_target parameter.  Also
11787         match target.
11788         (delete_thread_db_info): New process_stratum_target parameter.
11789         Also match target.
11790         (thread_from_lwp): Adjust to pass down target.
11791         (thread_db_notice_clone): Pass down target.
11792         (check_thread_db_callback): Pass down target.
11793         (try_thread_db_load_1): Always push the thread_db target.
11794         (try_thread_db_load, record_thread): Pass target down.
11795         (thread_db_target::detach): Pass target down.  Always unpush the
11796         thread_db target.
11797         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
11798         target down.  Always unpush the thread_db target.
11799         (find_new_threads_callback, thread_db_find_new_threads_2)
11800         (thread_db_target::update_thread_list): Pass target down.
11801         (thread_db_target::pid_to_str): Pass current inferior down.
11802         (thread_db_target::get_thread_local_address): Pass target down.
11803         (thread_db_target::resume, maintenance_check_libthread_db): Pass
11804         target down.
11805         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
11806         * procfs.c (procfs_target::procfs_init_inferior): Declare.
11807         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
11808         (procfs_init_inferior): Rename to ...
11809         (procfs_target::procfs_init_inferior): ... this and adjust.
11810         (procfs_target::create_inferior, procfs_notice_thread)
11811         (procfs_do_thread_registers): Adjust.
11812         * ppc-fbsd-tdep.c: Include "inferior.h".
11813         (ppcfbsd_get_thread_local_address): Pass down target.
11814         * proc-service.c (ps_xfer_memory): Switch current inferior and
11815         program space as well.
11816         (get_ps_regcache): Pass target down.
11817         * process-stratum-target.c
11818         (process_stratum_target::thread_address_space)
11819         (process_stratum_target::thread_architecture): Pass target down.
11820         * process-stratum-target.h
11821         (process_stratum_target::threads_executing): New field.
11822         (as_process_stratum_target): New.
11823         * ravenscar-thread.c
11824         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
11825         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
11826         down.
11827         * record-btrace.c (record_btrace_target::info_record): Adjust.
11828         (record_btrace_target::record_method)
11829         (record_btrace_target::record_is_replaying)
11830         (record_btrace_target::fetch_registers)
11831         (get_thread_current_frame_id, record_btrace_target::resume)
11832         (record_btrace_target::wait, record_btrace_target::stop): Pass
11833         target down.
11834         * record-full.c (record_full_wait_1): Switch to event thread.
11835         Pass target down.
11836         * regcache.c (regcache::regcache)
11837         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
11838         process_stratum_target parameter and handle it.
11839         (current_thread_target): New global.
11840         (get_thread_regcache): Add process_stratum_target parameter and
11841         handle it.  Switch inferior before calling target method.
11842         (get_thread_regcache): Pass target down.
11843         (get_thread_regcache_for_ptid): Pass target down.
11844         (registers_changed_ptid): Add process_stratum_target parameter and
11845         handle it.
11846         (registers_changed_thread, registers_changed): Pass target down.
11847         (test_get_thread_arch_aspace_regcache): New.
11848         (current_regcache_test): Define a couple local test_target_ops
11849         instances and use them for testing.
11850         (readwrite_regcache): Pass process_stratum_target parameter.
11851         (cooked_read_test, cooked_write_test): Pass mock_target down.
11852         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
11853         (get_thread_arch_aspace_regcache): Add process_stratum_target
11854         parameter.
11855         (regcache::target): New method.
11856         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
11857         (regcache::registers_changed_ptid): Add process_stratum_target
11858         parameter.
11859         (regcache::m_target): New field.
11860         (registers_changed_ptid): Add process_stratum_target parameter.
11861         * remote.c (remote_state::supports_vCont_probed): New field.
11862         (remote_target::async_wait_fd): New method.
11863         (remote_unpush_and_throw): Add remote_target parameter.
11864         (get_current_remote_target): Adjust.
11865         (remote_target::remote_add_inferior): Push target.
11866         (remote_target::remote_add_thread)
11867         (remote_target::remote_notice_new_inferior)
11868         (get_remote_thread_info): Pass target down.
11869         (remote_target::update_thread_list): Skip threads of inferiors
11870         bound to other targets.  (remote_target::close): Don't discard
11871         inferiors.  (remote_target::add_current_inferior_and_thread)
11872         (remote_target::process_initial_stop_replies)
11873         (remote_target::start_remote)
11874         (remote_target::remote_serial_quit_handler): Pass down target.
11875         (remote_target::remote_unpush_target): New remote_target
11876         parameter.  Unpush the target from all inferiors.
11877         (remote_target::remote_unpush_and_throw): New remote_target
11878         parameter.  Pass it down.
11879         (remote_target::open_1): Check whether the current inferior has
11880         execution instead of checking whether any inferior is live.  Pass
11881         target down.
11882         (remote_target::remote_detach_1): Pass down target.  Use
11883         remote_unpush_target.
11884         (extended_remote_target::attach): Pass down target.
11885         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
11886         (remote_target::append_resumption): Pass down target.
11887         (remote_target::append_pending_thread_resumptions)
11888         (remote_target::remote_resume_with_hc, remote_target::resume)
11889         (remote_target::commit_resume): Pass down target.
11890         (remote_target::remote_stop_ns): Check supports_vCont_probed.
11891         (remote_target::interrupt_query)
11892         (remote_target::remove_new_fork_children)
11893         (remote_target::check_pending_events_prevent_wildcard_vcont)
11894         (remote_target::remote_parse_stop_reply)
11895         (remote_target::process_stop_reply): Pass down target.
11896         (first_remote_resumed_thread): New remote_target parameter.  Pass
11897         it down.
11898         (remote_target::wait_as): Pass down target.
11899         (unpush_and_perror): New remote_target parameter.  Pass it down.
11900         (remote_target::readchar, remote_target::remote_serial_write)
11901         (remote_target::getpkt_or_notif_sane_1)
11902         (remote_target::kill_new_fork_children, remote_target::kill): Pass
11903         down target.
11904         (remote_target::mourn_inferior): Pass down target.  Use
11905         remote_unpush_target.
11906         (remote_target::core_of_thread)
11907         (remote_target::remote_btrace_maybe_reopen): Pass down target.
11908         (remote_target::pid_to_exec_file)
11909         (remote_target::thread_handle_to_thread_info): Pass down target.
11910         (remote_target::async_wait_fd): New.
11911         * riscv-fbsd-tdep.c: Include "inferior.h".
11912         (riscv_fbsd_get_thread_local_address): Pass down target.
11913         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
11914         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
11915         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
11916         Adjust.
11917         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
11918         * solib-svr4.c (enable_break): Pass down target.
11919         * spu-multiarch.c (parse_spufs_run): Pass down target.
11920         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
11921         * target-delegates.c: Regenerate.
11922         * target.c (g_target_stack): Delete.
11923         (current_top_target): Return the current inferior's top target.
11924         (target_has_execution_1): Refer to the passed-in inferior's top
11925         target.
11926         (target_supports_terminal_ours): Check whether the initial
11927         inferior was already created.
11928         (decref_target): New.
11929         (target_stack::push): Incref/decref the target.
11930         (push_target, push_target, unpush_target): Adjust.
11931         (target_stack::unpush): Defref target.
11932         (target_is_pushed): Return bool.  Adjust to refer to the current
11933         inferior's target stack.
11934         (dispose_inferior): Delete, and inline parts ...
11935         (target_preopen): ... here.  Only dispose of the current inferior.
11936         (target_detach): Hold strong target reference while detaching.
11937         Pass target down.
11938         (target_thread_name): Add assertion.
11939         (target_resume): Pass down target.
11940         (target_ops::beneath, find_target_at): Adjust to refer to the
11941         current inferior's target stack.
11942         (get_dummy_target): New.
11943         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
11944         has a thread running.
11945         (initialize_targets): Rename to ...
11946         (_initialize_target): ... this.
11947         * target.h: Include "gdbsupport/refcounted-object.h".
11948         (struct target_ops): Inherit refcounted_object.
11949         (target_ops::shortname, target_ops::longname): Make const.
11950         (target_ops::async_wait_fd): New method.
11951         (decref_target): Declare.
11952         (struct target_ops_ref_policy): New.
11953         (target_ops_ref): New typedef.
11954         (get_dummy_target): Declare function.
11955         (target_is_pushed): Return bool.
11956         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
11957         (all_matching_threads_iterator::all_matching_threads_iterator):
11958         Handle filter target.
11959         * thread-iter.h (struct all_matching_threads_iterator, struct
11960         all_matching_threads_range, class all_non_exited_threads_range):
11961         Filter by target too.  Remove explicit.
11962         * thread.c (threads_executing): Delete.
11963         (inferior_thread): Pass down current inferior.
11964         (clear_thread_inferior_resources): Pass down thread pointer
11965         instead of ptid_t.
11966         (add_thread_silent, add_thread_with_info, add_thread): Add
11967         process_stratum_target parameter.  Use it for thread and inferior
11968         searches.
11969         (is_current_thread): New.
11970         (thread_info::deletable): Use it.
11971         (find_thread_ptid, thread_count, in_thread_list)
11972         (thread_change_ptid, set_resumed, set_running): New
11973         process_stratum_target parameter.  Pass it down.
11974         (set_executing): New process_stratum_target parameter.  Pass it
11975         down.  Adjust reference to 'threads_executing'.
11976         (threads_are_executing): New process_stratum_target parameter.
11977         Adjust reference to 'threads_executing'.
11978         (set_stop_requested, finish_thread_state): New
11979         process_stratum_target parameter.  Pass it down.
11980         (switch_to_thread): Also match inferior.
11981         (switch_to_thread): New process_stratum_target parameter.  Pass it
11982         down.
11983         (update_threads_executing): Reimplement.
11984         * top.c (quit_force): Pop targets from all inferior.
11985         (gdb_init): Don't call initialize_targets.
11986         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
11987         Declare.
11988         (windows_add_thread, windows_delete_thread): Adjust.
11989         (get_windows_debug_event): Rename to ...
11990         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
11991         * tracefile-tfile.c (tfile_target_open): Pass down target.
11992         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
11993         Forward declare.
11994         (switch_to_thread): Add process_stratum_target parameter.
11995         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
11996         parameter.  Use it.
11997         (mi_on_resume): Pass target down.
11998         * nat/fork-inferior.c (startup_inferior): Add
11999         process_stratum_target parameter.  Pass it down.
12000         * nat/fork-inferior.h (startup_inferior): Add
12001         process_stratum_target parameter.
12002         * python/py-threadevent.c (py_get_event_thread): Pass target down.
12003
12004 2020-01-10  Pedro Alves  <palves@redhat.com>
12005
12006         * remote.c (remote_target::start_remote): Don't set inferior_ptid
12007         directly.  Instead find the first thread in the thread list and
12008         use switch_to_thread.
12009
12010 2020-01-10  Pedro Alves  <palves@redhat.com>
12011
12012         * remote.c (remote_target::remote_add_inferior): Don't bind a
12013         process to the current inferior if the current inferior is already
12014         bound to a process.
12015
12016 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
12017             Pedro Alves  <palves@redhat.com>
12018
12019         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
12020         If no process is specified, return null_ptid instead of
12021         inferior_ptid.
12022         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
12023         TARGET_WAITKIND_SIGNALLED with no pid.
12024
12025 2020-01-10  Pedro Alves  <palves@redhat.com>
12026
12027         * remote.c (first_remote_resumed_thread): New.
12028         (remote_target::wait_as): Use it as default event_ptid instead of
12029         inferior_ptid.
12030
12031 2020-01-10  Pedro Alves  <palves@redhat.com>
12032
12033         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
12034
12035 2020-01-10  Pedro Alves  <palves@redhat.com>
12036
12037         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
12038         not -1.
12039
12040 2020-01-10  Pedro Alves  <palves@redhat.com>
12041
12042         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
12043         ptid to get_last_target_status.
12044         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
12045         ptid to get_last_target_status.
12046         * infcmd.c (continue_command): Don't pass a target_waitstatus to
12047         get_last_target_status.
12048         (info_program_command): Don't pass a target_waitstatus to
12049         get_last_target_status.
12050         * infrun.c (init_wait_for_inferior): Use
12051         nullify_last_target_wait_ptid.
12052         (get_last_target_status): Handle nullptr arguments.
12053         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
12054         (print_stop_event): Don't pass a ptid to get_last_target_status.
12055         (normal_stop): Don't pass a ptid to get_last_target_status.
12056         * infrun.h (get_last_target_status, set_last_target_status): Move
12057         comments here and update.
12058         (nullify_last_target_wait_ptid): Declare.
12059         * linux-fork.c (fork_load_infrun_state): Remove local extern
12060         declaration of nullify_last_target_wait_ptid.
12061         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
12062         to get_last_target_status.
12063
12064 2020-01-10  Pedro Alves  <palves@redhat.com>
12065
12066         * gdbthread.h (scoped_restore_current_thread)
12067         <dont_restore, restore, m_dont_restore>: Declare.
12068         * thread.c (thread_alive): Add assertion.  Return bool.
12069         (switch_to_thread_if_alive): New.
12070         (prune_threads): Switch inferior/thread.
12071         (print_thread_info_1): Switch thread before calling target methods.
12072         (scoped_restore_current_thread::restore): New, factored out from
12073         ...
12074         (scoped_restore_current_thread::~scoped_restore_current_thread):
12075         ... this.
12076         (scoped_restore_current_thread::scoped_restore_current_thread):
12077         Add assertion.
12078         (thread_apply_all_command, thread_select): Use
12079         switch_to_thread_if_alive.
12080         * infrun.c (proceed, restart_threads, handle_signal_stop)
12081         (switch_back_to_stepped_thread): Switch current thread before
12082         calling target methods.
12083
12084 2020-01-10  Pedro Alves <palves@redhat.com>
12085
12086         * inferior.c (switch_to_inferior_no_thread): New function,
12087         factored out from ...
12088         (inferior_command): ... here.
12089         * inferior.h (switch_to_inferior_no_thread): Declare.
12090         * mi/mi-main.c (run_one_inferior): Use
12091         switch_to_inferior_no_thread.
12092
12093 2020-01-10  Pedro Alves  <palves@redhat.com>
12094
12095         * infcmd.c (kill_command): Remove dead code.
12096
12097 2020-01-10  Pedro Alves  <palves@redhat.com>
12098
12099         * remote.c (remote_target::mourn_inferior): No longer check
12100         whether the target is running.
12101
12102 2020-01-10  Pedro Alves  <palves@redhat.com>
12103
12104         * corelow.c (core_target::has_execution): Change parameter type to
12105         inferior pointer.
12106         * inferior.c (number_of_live_inferiors): Use
12107         inferior::has_execution instead of target_has_execution_1.
12108         * inferior.h (inferior::has_execution): New.
12109         * linux-thread-db.c (thread_db_target::update_thread_list): Use
12110         inferior::has_execution instead of target_has_execution_1.
12111         * process-stratum-target.c
12112         (process_stratum_target::has_execution): Change parameter type to
12113         inferior pointer.  Check the inferior's PID instead of
12114         inferior_ptid.
12115         * process-stratum-target.h
12116         (process_stratum_target::has_execution): Change parameter type to
12117         inferior pointer.
12118         * record-full.c (record_full_core_target::has_execution): Change
12119         parameter type to inferior pointer.
12120         * target.c (target_has_execution_1): Change parameter type to
12121         inferior pointer.
12122         (target_has_execution_current): Adjust.
12123         * target.h (target_ops::has_execution): Change parameter type to
12124         inferior pointer.
12125         (target_has_execution_1): Change parameter type to inferior
12126         pointer.  Change return type to bool.
12127         * tracefile.h (tracefile_target::has_execution): Change parameter
12128         type to inferior pointer.
12129
12130 2020-01-10  Pedro Alves  <palves@redhat.com>
12131
12132         * exceptions.c (print_flush): Remove current_top_target() check.
12133
12134 2020-01-10  Pedro Alves  <palves@redhat.com>
12135
12136         * remote.c (show_remote_exec_file): Show the current inferior's
12137         exec-file instead of the command variable's value.
12138
12139 2020-01-10  Pedro Alves  <palves@redhat.com>
12140
12141         * record-full.c (record_full_resume_ptid): New global.
12142         (record_full_target::resume): Set it.
12143         (record_full_wait_1): Use record_full_resume_ptid instead of
12144         inferior_ptid.
12145
12146 2020-01-10  Pedro Alves  <palves@redhat.com>
12147
12148         * gdbthread.h (scoped_restore_current_thread)
12149         <dont_restore, restore, m_dont_restore>: Declare.
12150         * thread.c (thread_alive): Add assertion.  Return bool.
12151         (switch_to_thread_if_alive): New.
12152         (prune_threads): Switch inferior/thread.
12153         (print_thread_info_1): Switch thread before calling target methods.
12154         (scoped_restore_current_thread::restore): New, factored out from
12155         ...
12156         (scoped_restore_current_thread::~scoped_restore_current_thread):
12157         ... this.
12158         (scoped_restore_current_thread::scoped_restore_current_thread):
12159         Add assertion.
12160         (thread_apply_all_command, thread_select): Use
12161         switch_to_thread_if_alive.
12162
12163 2020-01-10  George Barrett  <bob@bob131.so>
12164
12165         * stap-probe.c (stap_modify_semaphore): Don't check for null
12166         semaphores.
12167         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
12168         for null semaphores.
12169
12170 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12171
12172         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
12173         all source windows, and maintain horizontal scroll status while
12174         doing so.
12175
12176 2020-01-09  Tom Tromey  <tom@tromey.com>
12177
12178         PR tui/18932:
12179         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
12180         update_source_window, not print_source_lines.
12181
12182 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12183
12184         * tui/tui.c (tui_enable): Register tui hooks after calling
12185         tui_display_main.
12186
12187 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
12188
12189         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
12190
12191 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
12192
12193         * thread.c (print_thread_info_1): Fix indentation.
12194
12195 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
12196
12197         * symtab.c (general_symbol_info::compute_and_set_names): Move the
12198         unique_xmalloc_ptr outside the if to always free the demangled name.
12199
12200 2020-01-08  Tom Tromey  <tromey@adacore.com>
12201
12202         * xcoffread.c (enter_line_range, read_xcoff_symtab)
12203         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
12204         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
12205         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
12206         Remove.
12207         (section_offsets): New typedef.
12208         * symtab.c (fixup_section, get_msymbol_address): Update.
12209         * symmisc.c (dump_msymbols): Update.
12210         * symfile.h (relative_addr_info_to_section_offsets)
12211         (symfile_map_offsets_to_segments): Update.
12212         * symfile.c (build_section_addr_info_from_objfile)
12213         (init_objfile_sect_indices): Update.
12214         (struct place_section_arg): Change type of "offsets".
12215         (place_section): Update.
12216         (relative_addr_info_to_section_offsets): Change type of
12217         "section_offsets".  Remove "num_sections" parameter.
12218         (default_symfile_offsets, syms_from_objfile_1)
12219         (set_objfile_default_section_offset): Update.
12220         (reread_symbols): No need to preserve section offsets by hand.
12221         (symfile_map_offsets_to_segments): Change type of "offsets".
12222         * stap-probe.c (relocate_address): Update.
12223         * stabsread.h (process_one_symbol): Update.
12224         * solib-target.c (struct lm_info_target) <offsets>: Change type.
12225         (solib_target_relocate_section_addresses): Update.
12226         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
12227         Update.
12228         * solib-frv.c (frv_relocate_main_executable): Update.
12229         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
12230         * solib-aix.c (solib_aix_get_section_offsets): Change return
12231         type.
12232         (solib_aix_solib_create_inferior_hook): Update.
12233         * remote.c (remote_target::get_offsets): Update.
12234         * psymtab.c (find_pc_sect_psymtab): Update.
12235         * psympriv.h (struct partial_symbol) <address, text_low,
12236         text_high>: Update.
12237         * objfiles.h (obj_section_offset): Update.
12238         (struct objfile) <section_offsets>: Change type.
12239         <num_sections>: Remove.
12240         (objfile_relocate): Update.
12241         * objfiles.c (entry_point_address_query): Update
12242         (relocate_one_symbol): Change type of "section_offsets".
12243         (objfile_relocate1, objfile_relocate1): Change type of
12244         "new_offsets".
12245         (objfile_rebase1): Update.
12246         * mipsread.c (mipscoff_symfile_read): Update.
12247         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
12248         parameter.
12249         * mdebugread.c (parse_symbol): Change type of "section_offsets".
12250         (parse_external, psymtab_to_symtab_1): Update.
12251         * machoread.c (macho_symfile_offsets): Update.
12252         * ia64-tdep.c (ia64_find_unwind_table): Update.
12253         * hppa-tdep.c (read_unwind_info): Update.
12254         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
12255         * dwarf2read.c (create_addrmap_from_index)
12256         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12257         (process_psymtab_comp_unit_reader, add_partial_symbol)
12258         (add_partial_subprogram, process_full_comp_unit)
12259         (read_file_scope, read_func_scope, read_lexical_block_scope)
12260         (read_call_site_scope, dwarf2_rnglists_process)
12261         (dwarf2_ranges_process, dwarf2_ranges_read)
12262         (dwarf_decode_lines_1, var_decode_location, new_symbol)
12263         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
12264         Update.
12265         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
12266         Update.
12267         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
12268         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
12269         (process_one_symbol): Change type of "section_offsets".
12270         * ctfread.c (get_objfile_text_range): Update.
12271         * coffread.c (coff_symtab_read, enter_linenos)
12272         (process_coff_symbol): Update.
12273         * coff-pe-read.c (add_pe_forwarded_sym): Update.
12274         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
12275
12276 2020-01-08  Tom Tromey  <tromey@adacore.com>
12277
12278         * dwarf2read.c (parse_macro_definition): Use std::string.
12279         (parse_macro_definition): Likewise.
12280
12281 2020-01-08  Tom Tromey  <tromey@adacore.com>
12282
12283         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
12284         (ATTR_ALLOC_CHUNK): Remove.
12285
12286 2020-01-08  Tom Tromey  <tromey@adacore.com>
12287
12288         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
12289
12290 2020-01-08  Tom Tromey  <tromey@adacore.com>
12291
12292         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
12293         (dwarf2_compute_name, open_dwo_file): Likewise.
12294         (process_enumeration_scope): Use std::vector.
12295         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
12296         (partial_die_info::fixup, dwarf2_start_subfile)
12297         (guess_full_die_structure_name, dwarf2_name): Likewise.
12298         (determine_prefix): Update.
12299         (guess_full_die_structure_name): Make return type const.
12300         (partial_die_full_name): Return unique_xmalloc_ptr.
12301         (DW_FIELD_ALLOC_CHUNK): Remove.
12302
12303 2020-01-07  Tom Tromey  <tromey@adacore.com>
12304
12305         PR build/24937:
12306         * stap-probe.c (class stap_static_probe_ops): Add constructor.
12307
12308 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
12309
12310         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
12311
12312 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12313
12314         * stack.c (print_frame_info): Move disassemble_next_line code
12315         inside source_print block.
12316
12317 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12318
12319         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
12320         gdb/signals.h, as we are now using native signal symbols.
12321
12322 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
12323
12324         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
12325         overflow by an early check of content vs threshold.
12326         * tui/tui-source.c (tui_source_window::line_is_displayed):
12327         Likewise.
12328
12329 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12330
12331         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
12332
12333 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
12334
12335         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
12336         export table if no section contains it's RVA.
12337
12338 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12339
12340         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
12341
12342 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
12343
12344         * source.c (print_source_lines_base): Set last_line_listed.
12345
12346 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
12347
12348         * tui/tui-disasm.c: Remove trailing spaces.
12349
12350 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12351             Pedro Alves  <palves@redhat.com>
12352
12353         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
12354         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
12355         (windows_gdb_signal_to_target): New function, uses the above
12356         enumeration to convert GDB internal signal codes to equivalent
12357         Windows codes.
12358         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
12359         * windows-nat.c: Include "gdb_wait.h".
12360         (get_windows_debug_event): Extract the fatal exception from the
12361         exit status and convert to the equivalent Posix signal number.
12362         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
12363         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
12364         * gdbsupport/gdb_wait.c: New file, implements
12365         windows_status_to_termsig.
12366         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
12367         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
12368
12369 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
12370
12371         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
12372         show_layout.
12373
12374 2020-01-05  Luis Machado  <luis.machado@linaro.org>
12375
12376         * aarch64-linux-nat.c
12377         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
12378         and bfd_mach_aarch64.
12379
12380 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12381
12382         * ui-file.c (stdio_file::can_emit_style_escape)
12383         (tee_file::can_emit_style_escape): Ensure style is used also on
12384         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
12385         to gdb_stdout.
12386         * main.c (set_gdb_data_directory): Use file style to output the
12387         warning that the given pathname is not a directory.
12388         * top.c (show_history_filename, gdb_safe_append_history)
12389         (show_gdb_datadir): Use file style.
12390
12391 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
12392
12393         * solib-target.c (struct lm_info_target):
12394         Change offsets to be a unique_xmalloc_ptr.
12395         (solib_target_relocate_section_addresses): Update.
12396
12397 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
12398
12399         * windows-nat.c (windows_clear_solib): Free so_list linked list.
12400
12401 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
12402
12403         * MAINTAINERS (Write After Approval): Add myself.
12404
12405 2020-01-02  Luis Machado  <luis.machado@linaro.org>
12406
12407         * proc-service.c (get_ps_regcache): Remove reference to obsolete
12408         Cell BE architecture.
12409         * target.h (struct target_ops) <thread_architecture>: Likewise.
12410
12411 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
12412
12413         * Makefile.in: Use INSTALL_PROGRAM_ENV.
12414
12415 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
12416
12417         * MAINTAINERS (Write After Approval): Add myself.
12418
12419 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12420
12421         * gdbarch.sh: Update copyright year range of generated files.
12422
12423 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12424
12425         Update copyright year range in all GDB files.
12426
12427 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12428
12429         * copyright.py: Convert to Python 3.
12430
12431 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12432
12433         * copyright.py: Adapt after move of gnulib directory from gdb
12434         directory to toplevel directory.
12435
12436 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12437
12438         * copyright.py (main): Exit if run from the wrong directory.
12439
12440 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12441
12442         * top.c (print_gdb_version): Change copyright year to 2020.
12443
12444 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12445
12446         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
12447
12448 For older changes see ChangeLog-2019.
12449 \f
12450 Local Variables:
12451 mode: change-log
12452 left-margin: 8
12453 fill-column: 74
12454 version-control: never
12455 coding: utf-8
12456 End: