gdb/ChangeLog

   1 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
   4         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
   5         (objfpy_lookup_static_symbol): New function.
   6         (objfile_object_methods): Add new functions.
   7
   8 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   9
  10         * NEWS: Mention 'set|show print frame-info'.  Mention new
  11         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  12         backtrace argument.  Mention that python frame filtering code
  13         is now consistent with what 'backtrace' command prints.
  14
  15 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  16
  17         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  18         comments.
  19         (print_frame_info_auto, print_frame_info_source_line,
  20         print_frame_info_location, print_frame_info_source_and_location,
  21         print_frame_info_location_and_address, print_frame_info_short_location):
  22         New declarations.
  23         (struct frame_print_options): New member print_frame_info.
  24         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  25         * stack.h (get_user_print_what_frame_info): New declaration.
  26         (frame_show_address): New declaration.
  27         * stack.c (print_frame_arguments_choices): New value 'presence'.
  28         (print_frame_info_auto, print_frame_info_source_line,
  29         print_frame_info_location, print_frame_info_source_and_location,
  30         print_frame_info_location_and_address, print_frame_info_short_location,
  31         print_frame_info_choices, print_frame_info_print_what): New definitions.
  32         (print_frame_args): Only print dots for args if print frame-arguments
  33         is 'presence'.
  34         (frame_print_option_defs): New element for "frame-info".
  35         (get_user_print_what_frame_info): New function.
  36         (frame_show_address): Make non static.  Move comment to stack.h.
  37         (print_frame_info_to_print_what): New function.
  38         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  39         to decide what to print.
  40         (backtrace_command_1): Handle the new print_frame_arguments_presence
  41         value.
  42         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  43         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  44         (py_print_frame): In non-mi mode, use LOCATION as default for
  45         print_what, similarly to frame information printed directly by
  46         backtrace command. Handle frame-info user option in non MI mode.
  47
  48 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  49
  50         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  51         Add case for debugging 32-bit target on 64-bit host.  Revise
  52         comment.
  53
  54 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  55
  56         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  57         instead of find_function_entry_range_from_pc.
  58
  59 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  60
  61         * stack.c (find_frame_funname): Remove code which preferred
  62         minsym over symtab sym in "certain pathological cases".
  63
  64         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  65         parameter.  Change type of "do_demangle" to bool.
  66         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  67         Pass suitable "prefer_sym_over_minsym" flag to
  68         build_address_symbolic().  Don't output "+" for negative offsets.
  69         * printcmd.c (print_address_symbolic): Update invocation of
  70         build_address_symbolic to include a "prefer_sym_over_minsym"
  71         flag.
  72         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  73         Restrict cases in which use of minimal symbol is preferred to that
  74         of a found symbol.  Update comments.
  75
  76         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
  77         for entry pc when entry pc is out of range for that FDE.
  78
  79         * printcmd.c (print_address_symbolic): Print negative offsets.
  80         (build_address_symbolic): Force signed arithmetic when computing
  81         offset.
  82
  83 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
  84
  85         PR gdb/24839:
  86         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
  87         type.
  88
  89 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
  90
  91         * python/py-objfile.c (add_separate_debug_file): Fix comment about
  92         this function's Python signature.
  93
  94
  95 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
  96
  97         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
  98         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  99         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 100         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 101         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 102
 103
 104 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 105
 106         * h8300-tdep.c (h8300_register_name_common): New.
 107         h8300_register_name): Use h8300_register_name_common.
 108         (h8300s_register_name): Likewise.
 109         (h8300sx_register_name): Likewise.
 110         (h8300h_register_nam): New.
 111         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 112
 113
 114 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 115
 116         * arm-tdep.c (arm_skip_cmse_entry): New function.
 117         (arm_is_sgstubs_section): New function.
 118         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 119
 120 2019-07-22  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 123         Don't self-assign.
 124
 125 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 126
 127         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 128         type_print.
 129
 130 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 131
 132         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 133         so that GDB doesn't match any msymbols when searching in the
 134         TYPES_DOMAIN.
 135         (print_symbol_info): Print using typedef_print or type_print based
 136         on the type of the symbol.  Add updated FIXME comment moved from...
 137         (_initialize_symtab): ... move and update FIXME comment to above.
 138
 139 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * NEWS: Mention adding -q option to "info types".
 142         * symtab.c (struct info_types_options): New struct.
 143         (info_types_options_defs): New variable.
 144         (make_info_types_options_def_group): New function.
 145         (info_types_command): Use gdb::option framework to parse options.
 146         (info_types_command_completer): New function.
 147         (_initialize_symtab): Extend the help text on "info types" and
 148         register command completer.
 149
 150 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 151
 152         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 153         (lookup_symbol_in_objfile): Change int to block_enum and add a
 154         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 155
 156 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 157
 158         * MAINTAINERS (Write After Approval): Add self.
 159
 160 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 161
 162         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 163         instruction to the dummy code region.
 164
 165 2019-07-19  Tom Tromey  <tromey@adacore.com>
 166
 167         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 168         (ARGSUSED, PARAMS, __func__): Remove rules.
 169
 170 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 171
 172         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 173         * features/arm/arm-with-iwmmxt.c: Remove.
 174         * features/arm/arm-with-iwmmxt.xml: Remove.
 175         * features/arm/arm-with-m-fpa-layout.c: Remove.
 176         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 177         * features/arm/arm-with-m-vfp-d16.c: Remove.
 178         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 179         * features/arm/arm-with-m.c: Remove.
 180         * features/arm/arm-with-m.xml: Remove.
 181         * features/arm/arm-with-neon.c: Remove.
 182         * features/arm/arm-with-neon.xml: Remove.
 183         * features/arm/arm-with-vfpv2.c: Remove.
 184         * features/arm/arm-with-vfpv2.xml: Remove.
 185         * features/arm/arm-with-vfpv3.c: Remove.
 186         * features/arm/arm-with-vfpv3.xml: Remove.
 187
 188 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 189
 190         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 191
 192 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 193
 194         * arch/aarch32.c (aarch32_create_target_description): Create
 195         target descriptions using features.
 196         * arch/arm.c (arm_create_target_description)
 197         (arm_create_mprofile_target_description): Likewise.
 198         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 199
 200 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 201
 202         * Makefile.in: Add new files.
 203         * aarch32-tdep.c: New file.
 204         * aarch32-tdep.h: New file.
 205         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 206         Call aarch32_read_description.
 207         * arch/aarch32.c: New file.
 208         * arch/aarch32.h: New file.
 209         * arch/arm.c (arm_create_target_description)
 210         (arm_create_mprofile_target_description): New function.
 211         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 212         (arm_create_target_description)
 213         (arm_create_mprofile_target_description): New declaration.
 214         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 215         read_description functions.
 216         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 217         Likewise.
 218         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 219         * arm-tdep.c (tdesc_arm_list): New variable.
 220         (arm_register_g_packet_guesses): Call create description functions.
 221         (arm_read_description) (arm_read_mprofile_description): New
 222         function.
 223         * arm-tdep.h (arm_read_description)
 224         (arm_read_mprofile_description): Add declaration.
 225         * configure.tgt: Add new files.
 226
 227 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 228
 229         * top.c (new_ui_command): Open specified terminal just once.
 230
 231 2019-07-18  Tom Tromey  <tromey@adacore.com>
 232
 233         * symtab.c (main_name): Constify return type.
 234         * symfile.c (set_initial_language): Update.
 235         * symtab.h (main_name): Constify return type.
 236
 237 2019-07-17  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-winsource.c (tui_update_source_window)
 240         (tui_update_source_window_as_is)
 241         (tui_update_source_windows_with_line): Remove return.
 242         * tui/tui-disasm.c (tui_show_disassem)
 243         (tui_show_disassem_and_update_source): Remove return.
 244         * tui/tui.c (tui_reset): Remove return.
 245         * tui/tui-wingeneral.c
 246         (tui_check_and_display_highlight_if_needed): Remove return.
 247
 248 2019-07-17  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 251
 252 2019-07-17  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-winsource.h (struct tui_exec_info_window)
 255         (struct tui_source_window_base): Move from tui-data.h.
 256         * tui/tui-winsource.c: Move many method definitions from
 257         elsewhere.  Remove "structuring" comments.
 258         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 259         (tui_source_window_base::refresh_window): Move to
 260         tui-winsource.c.
 261         * tui/tui-win.c (tui_source_window_base::refresh_all)
 262         (tui_source_window_base::update_tab_width)
 263         (tui_source_window_base::set_new_height)
 264         (tui_source_window_base::do_make_visible_with_new_height): Move to
 265         tui-winsource.c.
 266         * tui/tui-source.h: Update.
 267         * tui/tui-source.c (tui_source_window_base::reset): Move to
 268         tui-winsource.c.
 269         * tui/tui-disasm.h: Update.
 270         * tui/tui-data.h (struct tui_exec_info_window): Move to
 271         tui-winsource.h.
 272         (struct tui_source_window_base): Likewise.
 273         * tui/tui-data.c (tui_source_window_base::clear_detail)
 274         (tui_source_window_base, ~tui_source_window_base): Move to
 275         tui-winsource.c.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-win.c (tui_resize_all)
 280         (tui_source_window_base::update_tab_width)
 281         (tui_adjust_win_heights): Update.
 282         (tui_win_info::make_invisible_and_set_new_height): Rename from
 283         make_invisible_and_set_new_height.
 284         * tui/tui-data.h (struct tui_win_info)
 285         <make_invisible_and_set_new_height>: New method.
 286
 287 2019-07-17  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui.c: Update.
 290         * tui/tui-source.h (struct tui_source_window): Move from
 291         tui-data.h.
 292         * tui/tui-layout.c: Update.
 293         * tui/tui-disasm.c: Update.
 294         * tui/tui-data.h (struct tui_source_window): Move to
 295         tui-source.h.
 296
 297 2019-07-17  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 300         tui-data.h.
 301         * tui/tui-data.h (struct tui_disasm_window): Move to
 302         tui-disasm.h.
 303
 304 2019-07-17  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-regs.h (struct tui_data_item_window): Move from
 307         tui-data.h.
 308         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 309         * tui/tui-data.h (struct tui_data_item_window): Move to
 310         tui-regs.h.
 311         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 312
 313 2019-07-17  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui.c: Update.
 316         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 317         (tui_cmd_window::max_height): Move to tui-command.c.
 318         * tui/tui-layout.c: Update.
 319         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 320         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 321         tui-command.c.
 322         * tui/tui-command.h (struct tui_cmd_window): Move from
 323         tui-data.h.
 324         * tui/tui-command.c: Remove "structuring" comments.
 325         (tui_cmd_window::clear_detail)
 326         (tui_cmd_window::do_make_visible_with_new_height)
 327         (tui_cmd_window::max_height): Move from elsewhere.
 328
 329 2019-07-17  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 332         Now static.
 333         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 334         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui.c: Update.
 339         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 340         tui-regs.c.
 341         * tui/tui-windata.h: Remove file.
 342         * tui/tui-windata.c: Remove file.
 343         * tui/tui-win.c (tui_data_window::set_new_height)
 344         (tui_data_window::do_make_visible_with_new_height): Move to
 345         tui-regs.c.
 346         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 347         * tui/tui-regs.c: Remove "structuring" comments.
 348         (tui_data_window::first_data_item_displayed)
 349         (tui_data_window::delete_data_content_windows)
 350         (tui_data_window::erase_data_content)
 351         (tui_data_window::display_all_data)
 352         (tui_data_window::refresh_all)
 353         (tui_data_window::do_scroll_vertical)
 354         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 355         (tui_data_window::do_make_visible_with_new_height)
 356         (tui_data_window::refresh_window): Move from elsewhere.
 357         (_initialize_tui_regs): Move to end of file.
 358         * tui/tui-layout.c: Update.
 359         * tui/tui-hooks.c: Update.
 360         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 361         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 362         tui-regs.c.
 363         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 364
 365 2019-07-17  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 368         seen.
 369
 370 2019-07-17  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-win.c (tui_source_window_base::set_new_height)
 373         (tui_source_window_base::do_make_visible_with_new_height): Use
 374         m_has_locator field directly.
 375         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 376         method.
 377         (struct tui_source_window_base) <has_locator>: Likewise.
 378
 379 2019-07-17  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 382         Don't declare.
 383         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 384         Remove.
 385         * tui/tui-win.c (tui_source_window_base::set_new_height)
 386         (tui_source_window_base::set_new_height)
 387         (make_invisible_and_set_new_height)
 388         (tui_source_window_base::do_make_visible_with_new_height)
 389         (tui_source_window_base::do_make_visible_with_new_height):
 390         Update.
 391         * tui/tui-layout.c (show_source_disasm_command, show_data)
 392         (show_source_or_disasm_and_command): Update.
 393         * tui/tui-layout.c (show_layout): Update.
 394
 395 2019-07-17  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-layout.c (make_data_window): Remove.
 398         (show_data): Unify creation and re-initialization cases.
 399
 400 2019-07-17  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-layout.c (make_source_window, make_disasm_window):
 403         Remove.
 404         (show_data): Unify creation and re-initialization cases.
 405
 406 2019-07-17  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-layout.c (make_command_window): Remove.
 409         (show_source_disasm_command, show_source_or_disasm_and_command):
 410         Unify creation and re-initialization cases.
 411
 412 2019-07-17  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 415         creation and re-initialization cases.
 416
 417 2019-07-17  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-regs.c (tui_get_register): Return void.
 420
 421 2019-07-17  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 424         Simplify.
 425
 426 2019-07-17  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 429         resetting.
 430
 431 2019-07-17  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 434         * tui/tui-regs.c (tui_reg_layout): New function.
 435         (tui_show_registers, tui_reg_command): Use it.
 436         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 437         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 438         parameters.
 439         (tui_layout_command): Remove.
 440
 441 2019-07-17  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-layout.h (tui/tui-layout): Return void.
 444         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 445
 446 2019-07-17  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-layout.c (show_source_disasm_command, show_data):
 449         Update.
 450         (reset_locator): Remove.
 451         (show_source_or_disasm_and_command): Update.
 452
 453 2019-07-17  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-source.c (tui_source_window_base::reset): Remove
 456         win_type parameter.
 457         * tui/tui-layout.c (make_command_window, make_source_window)
 458         (make_disasm_window, make_data_window)
 459         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 460         (reset_locator, show_source_or_disasm_and_command): Update.
 461         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 462         win_type parameter.
 463         (struct tui_source_window_base) <reset>: Likewise.
 464
 465 2019-07-17  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-layout.c (show_source_disasm_command): Use
 468         reset_locator.
 469         (reset_locator): New function.
 470         (init_and_make_win): Remove.
 471         (show_source_or_disasm_and_command): Use reset_locator.
 472
 473 2019-07-17  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 476         condition.
 477         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 478         Remove condition.
 479         * tui/tui-source.c (tui_source_window_base::reset): New method.
 480         * tui/tui-layout.c (make_command_window): Don't call
 481         init_and_make_win.
 482         (make_source_window, make_disasm_window): Don't call
 483         make_source_or_disasm_window.
 484         (make_data_window): Don't call init_and_make_win.  Change calling
 485         convention.
 486         (show_source_disasm_command, show_data): Simplify.
 487         (make_source_or_disasm_window): Remove.
 488         (show_source_or_disasm_and_command): Simplify.
 489         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 490         (struct tui_source_window_base) <reset>: Likewise.
 491         <execution_info>: Remove initializer.
 492         * tui/tui-data.c (tui_source_window_base): Initialize
 493         execution_info.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 498         variable.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui.c (tui_rl_other_window): Update.
 503         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 504         superclass method first.  Always iterate over regs_content.
 505         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 506         method.
 507         * tui/tui-win.c (tui_set_focus_command): Update.
 508
 509 2019-07-17  Tom Tromey  <tom@tromey.com>
 510
 511         * tui/tui-win.c (tui_set_focus_command): Rename from
 512         tui_set_focus.  Call tui_enable.
 513         (tui_set_focus_command): Remove.
 514
 515 2019-07-17  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 518         refresh_window.
 519         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 520         touchwin.
 521         (tui_data_window::refresh_window): Call refresh_window on data
 522         items.  Always call superclass refresh_window.
 523         (tui_win_info::refresh): Remove.
 524         (tui_source_window_base::refresh_window): Update.
 525         (tui_refresh_all): Update.
 526         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 527         refresh_window.
 528         (show_source_or_disasm_and_command): Likewise.
 529         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 530         (struct tui_source_window_base) <refresh>: Likewise.
 531
 532 2019-07-17  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-winsource.c (tui_clear_source_content)
 535         (tui_show_source_content): Update.
 536         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 537         whether content is empty.
 538         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 539         Remove.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 544         window's contents.
 545         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 546         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 547
 548 2019-07-17  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 551         (struct tui_data_item_window): Update.
 552
 553 2019-07-17  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 556         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 557         defines.
 558
 559 2019-07-17  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-winsource.h (tui_erase_source_content)
 562         (tui_clear_source_content): Remove "display_prompt" parameter.
 563         * tui/tui-winsource.c (tui_update_source_window_as_is)
 564         (tui_update_source_windows_with_addr): Update.
 565         (tui_clear_source_content): Remove "display_prompt" parameter.
 566         (tui_erase_source_content): Likewise.  Simplify.
 567         (tui_show_source_content): Update.
 568         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 569         * tui/tui-stack.c (tui_show_frame_info): Update.
 570         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 571         Remove defines.
 572
 573 2019-07-17  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 576         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 577         parameter.
 578         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 579         parameter.
 580
 581 2019-07-17  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-winsource.c (tui_clear_source_content)
 584         (tui_show_source_content, tui_show_exec_info_content)
 585         (tui_clear_exec_info_content): Update.
 586         * tui/tui-stack.c (tui_show_locator_content): Update.
 587         (tui_show_frame_info): Update.
 588         * tui/tui-source.h (tui_source_window): Don't declare.
 589         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 590         from tui_source_is_displayed.
 591         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 592         Remove field.
 593         (struct tui_source_window_base) <content_in_use>: New field.  Now
 594         bool.
 595         (struct tui_source_window) <showing_source_p>: New method.
 596         (TUI_SRC_WIN): Change cast.
 597         * tui/tui-data.c (tui_initialize_static_data): Update.
 598
 599 2019-07-17  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 602         location_matches_p.
 603         * tui/tui-source.c (tui_source_window::location_matches_p): New
 604         method.
 605         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 606         method.
 607         * tui/tui-data.h (struct tui_source_window_base)
 608         <location_matches_p>: New method.
 609         (struct tui_source_window, struct tui_disasm_window)
 610         <location_matches_p>: Likewise.
 611
 612 2019-07-17  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-win.c (tui_set_win_height_command): Rename from
 615         tui_set_win_height.
 616         (tui_set_win_height_command): Remove.
 617
 618 2019-07-17  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-source.c (tui_source_window): New constructor.  Add
 621         observer.
 622         (~tui_source_window): New destructor.
 623         (tui_source_window::style_changed): New method.
 624         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 625         (tui_attach_detach_observers): Update.
 626         * tui/tui-data.h (struct tui_source_window): Make constructor not
 627         inline.  Add destructor.
 628         (struct tui_source_window) <style_changed>: New method.
 629         <m_observable>: New member.
 630
 631 2019-07-17  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 634         * tui/tui-win.c (tui_resize_all): Fix typo.
 635
 636 2019-07-17  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 639         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 640         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 641         * tui/tui-win.c (window_name_completer): Use foreach.
 642         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 643         (update_tab_width): Likewise.
 644         * tui/tui-layout.c (show_layout): Update.
 645         * tui/tui-data.h (class tui_window_iterator): New.
 646         (struct all_tui_windows): New.
 647         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 648
 649 2019-07-17  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 652         parameter.  Don't reference globals.
 653         (tui_reg_command): Update.
 654
 655 2019-07-17  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-regs.c (tui_show_registers): Simplify.
 658
 659 2019-07-17  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-regs.c (tui_show_registers): Update.
 662         (tui_show_register_group): Add win_info parameter.
 663
 664 2019-07-17  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 667         Rename from tui_display_reg_element_at_line.
 668         (tui_data_window::display_registers_from_line): Update.
 669         * tui/tui-data.h (struct tui_data_window)
 670         <display_reg_element_at_line>: New method.
 671
 672 2019-07-17  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-regs.h (tui_display_registers_from)
 675         (tui_display_registers_from_line): Don't declare.
 676         * tui/tui-windata.c (tui_data_window::display_all_data)
 677         (tui_data_window::refresh_all)
 678         (tui_data_window::do_scroll_vertical): Update.
 679         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 680         from tui_display_registers_from.
 681         (tui_display_reg_element_at_line): Update.
 682         (tui_data_window::display_registers_from_line): Rename from
 683         tui_display_registers_from_line.
 684         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 685         display_registers_from_line>: New methods.
 686
 687 2019-07-17  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 690         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 691         from tui_erase_data_content.
 692         (tui_data_window::display_all_data)
 693         (tui_data_window::refresh_all)
 694         (tui_data_window::do_scroll_vertical): Update.
 695         * tui/tui-regs.c (tui_show_registers): Update.
 696         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 697         New method.
 698
 699 2019-07-17  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 702         declare.
 703         * tui/tui-windata.c
 704         (tui_data_window::delete_data_content_windows): Rename from
 705         tui_delete_data_content_windows.
 706         (tui_data_window::display_all_data)
 707         (tui_data_window::do_scroll_vertical): Update.
 708         * tui/tui-data.h (struct tui_data_window)
 709         <delete_data_content_windows>: New method.
 710
 711 2019-07-17  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 714         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 715
 716 2019-07-17  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 719         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 720         from tui_display_all_data.
 721         * tui/tui-win.c
 722         (tui_data_window::do_make_visible_with_new_height): Update.
 723         * tui/tui-regs.c (tui_show_registers): Update.
 724         * tui/tui-layout.c (tui_set_layout): Update.
 725         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 726         method.
 727
 728 2019-07-17  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 731         * tui/tui-windata.c (tui_display_data_from): Remove.
 732         (tui_data_window::refresh_all): Update.
 733
 734 2019-07-17  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 737         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 738         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 739         tui_display_registers_from_line.
 740         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 741         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 742         "force_display" parameter.
 743
 744 2019-07-17  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 747         declare.
 748         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 749         Rename from tui_first_reg_element_no_inline.
 750         (tui_display_reg_element_at_line)
 751         (tui_display_registers_from_line): Update.
 752         * tui/tui-data.h (struct tui_data_window)
 753         <first_reg_element_no_inline>: New method.
 754
 755 2019-07-17  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-windata.c (tui_display_data_from)
 758         (tui_data_window::do_scroll_vertical): Update.
 759         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 760         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 761         Rename from tui_line_from_reg_element_no.
 762         (tui_display_registers_from_line): Update.
 763         * tui/tui-data.h (struct tui_data_window)
 764         <line_from_reg_element_no>: New method.
 765
 766 2019-07-17  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 769         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 770         tui_last_regs_line_no.
 771         (tui_display_reg_element_at_line)
 772         (tui_display_registers_from_line): Update.
 773         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 774         method.
 775
 776 2019-07-17  Tom Tromey  <tom@tromey.com>
 777
 778         PR tui/24722:
 779         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 780         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 781         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 782         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 783         (tui_update_breakpoint_info): Likewise.
 784         * tui/tui-hooks.c (tui_event_create_breakpoint)
 785         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 786         Update.
 787
 788 2019-07-17  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 791
 792 2019-07-17  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-winsource.c (tui_update_source_window_as_is)
 795         (tui_update_source_windows_with_addr): Update.
 796         * tui/tui-source.h (tui_set_source_content)
 797         (tui_show_symtab_source): Add "win_info" parameter.
 798         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 799         parameter.
 800         (tui_show_symtab_source): Likewise.
 801
 802 2019-07-17  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-wingeneral.c
 805         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 806
 807 2019-07-17  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 810         (struct tui_cmd_window) <can_scroll>: New method.
 811         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 812         method.
 813
 814 2019-07-17  Tom Tromey  <tromey@adacore.com>
 815
 816         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 817         do_field_signed>: Rename.  Change type of "value".
 818         * ui-out.c (ui_out::field_signed): Rename from field_int.
 819         Change type of "value".
 820         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 821         type of "value".
 822         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 823         do_field_int.  Change type of "value".
 824         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 825         do_field_int.  Change type of "value".
 826         * tracepoint.c (trace_status_mi, tfind_1)
 827         (print_one_static_tracepoint_marker): Update.
 828         * thread.c (print_thread_info_1, print_selected_thread_frame):
 829         Update.
 830         * stack.c (print_frame, print_frame_info): Update.
 831         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 832         Update.
 833         * source.c (print_source_lines_base): Update.
 834         * skip.c (info_skip_command): Update.
 835         * record-btrace.c (btrace_ui_out_decode_error)
 836         (btrace_call_history_src_line): Update.
 837         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 838         Update.
 839         * progspace.c (print_program_space): Update.
 840         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 841         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 842         do_field_int.  Change type of "value".
 843         * mi/mi-out.c (mi_ui_out::do_table_begin)
 844         (mi_ui_out::do_table_header): Update.
 845         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 846         type of "value".
 847         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 848         (mi_cmd_data_list_changed_registers, output_register)
 849         (mi_cmd_data_read_memory, mi_load_progress)
 850         (mi_cmd_trace_frame_collected): Update.
 851         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 852         Update.
 853         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 854         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 855         (mi_cmd_var_list_children, varobj_update_one): Update.
 856         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 857         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 858         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 859         * inferior.c (print_inferior): Update.
 860         * gdb_bfd.c (print_one_bfd): Update.
 861         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 862         Update.
 863         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 864         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 865         do_field_int.  Change type of "value".
 866         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 867         do_field_int.  Change type of "value".
 868         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 869         (print_one_breakpoint_location, print_it_catch_fork)
 870         (print_one_catch_fork, print_it_catch_vfork)
 871         (print_one_catch_vfork, print_it_catch_solib)
 872         (print_it_catch_exec, print_it_ranged_breakpoint)
 873         (print_mention_watchpoint, print_mention_masked_watchpoint)
 874         (bkpt_print_it, update_static_tracepoint): Update.
 875         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 876         * break-catch-syscall.c (print_it_catch_syscall): Update.
 877         * ada-tasks.c (print_ada_task_info): Update.
 878         * ada-lang.c (print_it_exception, print_mention_exception):
 879         Update.
 880
 881 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 882
 883         PR breakpoints/24541
 884         * gdbarch.c: Regenerate.
 885         * gdbarch.h: Regenerate.
 886         * gdbarch.sh: Adjust return type and parameter types for
 887         'stap_adjust_register'.
 888         (i386_stap_adjust_register): Adjust signature and return new
 889         register name.
 890         * stap-probe.c (stap_parse_register_operand): Adjust use of
 891         'gdbarch_stap_adjust_register'.
 892
 893 2019-07-17  Tom Tromey  <tromey@adacore.com>
 894
 895         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 896         declare VEC.
 897         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 898         std::vector.
 899         (struct s390_process_info): Add initializers.
 900         (s390_add_process): Use new.
 901         (s390_linux_nat_target::low_forget_process): Use delete.
 902         (s390_linux_nat_target::low_new_fork)
 903         (s390_linux_nat_target::stopped_by_watchpoint)
 904         (s390_linux_nat_target::low_prepare_to_resume)
 905         (s390_linux_nat_target::insert_watchpoint)
 906         (s390_linux_nat_target::insert_hw_breakpoint)
 907         (s390_linux_nat_target::remove_watchpoint)
 908         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 909
 910 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 911
 912         * aarch64-fbsd-nat.c: Include regcache.h.
 913         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 914         argument.
 915         (aarch64_fbsd_nat_target::fetch_registers)
 916         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 917         variable.
 918         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 919
 920 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 921
 922         * fbsd-nat.c: Include gdbarch.h.
 923
 924 2019-07-15  Tom Tromey  <tromey@adacore.com>
 925
 926         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 927
 928 2019-07-15  Tom Tromey  <tromey@adacore.com>
 929
 930         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 931         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 932         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 933         * cli-out.c (cli_ui_out::do_field_int): New method.
 934         * ui-out.c (ui_out::field_unsigned): New method.
 935         * symfile.c (generic_load): Use field_unsigned.
 936         (print_transfer_performance): Likewise.
 937         * record-btrace.c (ui_out_field_uint): Remove.
 938         (btrace_call_history_insn_range, btrace_call_history): Use
 939         field_unsigned.
 940         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 941         field_unsigned.
 942         * ui-out.h (class ui_out) <field_unsigned>: New method.
 943         <do_field_unsigned>: Likewise.
 944
 945 2019-07-15  Tom Tromey  <tromey@adacore.com>
 946
 947         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 948         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 949         * target.c (flash_erase_command): Use field_string.
 950         * infrun.c (print_signal_received_reason): Use field_string.
 951         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 952         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 953         field_string.
 954         * ada-tasks.c (print_ada_task_info): Use field_string.
 955
 956 2019-07-15  Tom Tromey  <tromey@adacore.com>
 957
 958         * target.c (flash_erase_command): Use field_core_addr.
 959         * symfile.c (generic_load): Use field_core_addr.
 960         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 961         Use field_core_addr.
 962         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 963         field_core_addr.
 964
 965 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 968         value if its desired type is smaller than a CORE_ADDR and signed.
 969
 970 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 971
 972         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 973         of changes to field names, and use new is_reference field to
 974         decide if a property is a reference or not.
 975         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 976         field.
 977         (struct dwarf2_property_baton): Update header comment, rename
 978         'referenced_type' to 'property_type' and update comments.
 979         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 980         default property type, store in property baton, update to take
 981         accound of renamed field.
 982         (read_func_scope): Update call to attr_to_dynamic_prop.
 983         (read_array_type): Likewise.
 984         (dwarf2_per_cu_addr_sized_int_type): New function.
 985         (read_subrange_index_type): Move type finding code to
 986         dwarf2_per_cu_addr_sized_int_type.
 987         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 988         (dwarf2_per_cu_addr_type): New function.
 989         (set_die_type): Update calls to attr_to_dynamic_prop.
 990
 991 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 992
 993         * dwarf2read.c (read_subrange_index_type): New function.
 994         (read_subrange_type): Move code into new function and call it.
 995         * gdbtypes.c (create_range_type): Add some asserts.
 996
 997 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 998
 999         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1000         update return statements.
1001         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1002         declaration, and update comment to match.
1003         * gdbtypes.c (resolve_dynamic_array): Update call to
1004         dwarf2_evaluate_property to match new return type.
1005
1006 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1007
1008         * valarith.c (value_subscripted_rvalue): Change lowerbound
1009         parameter type from int to LONGEST.
1010         * value.h (value_subscripted_rvalue): Likewise in declaration.
1011
1012 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1013
1014         * cli/cli-utils.c (info_print_command_completer): New function.
1015         * cli/cli-utils.h: Add 'completer.h' include, and forward
1016         declaration for 'struct cmd_list_element'.
1017         (info_print_command_completer): Declare.
1018         * stack.c (_initialize_stack): Add completer for 'info locals' and
1019         'info args'.
1020         * symtab.c (_initialize_symtab): Add completer for 'info
1021         variables' and 'info functions'.
1022         * NEWS: Mention completion for additional info commands.
1023
1024 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * cli/cli-utils.c (extract_info_print_args): Delete.
1027         (extract_arg_maybe_quoted): Delete.
1028         (info_print_options_defs): New variable.
1029         (make_info_print_options_def_group): New function.
1030         (extract_info_print_options): Define new function.
1031         * cli/cli-utils.h (extract_info_print_args): Delete.
1032         (struct info_print_options): New structure.
1033         (extract_info_print_options): Declare new function.
1034         * stack.c (info_locals_command): Update to use new
1035         extract_info_print_options, also add a header comment.
1036         (info_args_command): Likewise.
1037         * symtab.c (info_variables_command): Likewise.
1038         (info_functions_command): Likewise.
1039
1040 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1043         to extract string arguments.
1044         * common/common-utils.c (extract_string_maybe_quoted): New function.
1045         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1046
1047 2019-07-11  Tom Tromey  <tromey@adacore.com>
1048
1049         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1050         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1051         * top.h (gdbinit): Don't declare.
1052         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1053         into...
1054         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1055         * top.c (gdb_init): Don't call init_cli_cmds.
1056         (gdbinit): Remove.
1057         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1058
1059 2019-07-11  Tom Tromey  <tromey@adacore.com>
1060
1061         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1062         after it has been moved.
1063
1064 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1065
1066         * valops.c (value_must_coerce_to_target): Change return type to
1067         bool.
1068         * value.h (value_must_coerce_to_target): Likewise.
1069
1070 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1071
1072         * breakpoint.c (is_hardware_watchpoint): Remove
1073         forward-declaration.
1074         (is_masked_watchpoint): Change return type to bool.
1075         (is_tracepoint): Likewise.
1076         (is_breakpoint): Likewise.
1077         (is_hardware_watchpoint): Likewise.
1078         (is_watchpoint): Likewise.
1079         (is_no_memory_software_watchpoint): Likewise.
1080         (is_catchpoint): Likewise.
1081         (breakpoint_1): Make FILTER parameter's return type bool.
1082         is_masked_watchpoint): Change return type to bool.
1083         (save_breakpoints): Make FILTER parameter's return type bool.
1084         * breakpoint.h (is_breakpoint): Change return type to bool.
1085         (is_watchpoint): Likewise.
1086         (is_catchpoint): Likewise.
1087         (is_tracepoint): Likewise.
1088
1089 2019-07-10  Tom Tromey  <tom@tromey.com>
1090
1091         * defs.h: Don't include gdbarch.h.
1092         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1093         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1094         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1095         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1096         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1097         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1098         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1099         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1100         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1101         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1102         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1103         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1104         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1105         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1106         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1107         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1108         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1109         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1110         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1111         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1112         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1113         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1114         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1115         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1116         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1117         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1118         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1119
1120 2019-07-10  Tom Tromey  <tromey@adacore.com>
1121
1122         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1123         * breakpoint.c (init_ada_exception_breakpoint): Register as
1124         bp_catchpoint.
1125         (print_one_breakpoint_location, print_one_breakpoint): Use
1126         is_ada_exception_catchpoint.
1127         * ada-lang.c (class ada_catchpoint_location): Pass
1128         bp_loc_software_breakpoint to bp_location constructor.
1129         (is_ada_exception_catchpoint): New function.
1130
1131 2019-07-10  Tom Tromey  <tromey@adacore.com>
1132
1133         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1134         VEC.
1135         (struct arm_exidx_entry): New method operator<.
1136         (struct arm_exidx_data) <section_maps>: Change type.
1137         (arm_exidx_data_free): Remove.
1138         (arm_exidx_data_key): Change type.  Move lower.
1139         (arm_exidx_new_objfile): Update.
1140         (arm_compare_exidx_entries): Remove.
1141         (arm_find_exidx_entry, _initialize_arm_tdep)
1142
1143 2019-07-10  Tom Tromey  <tromey@adacore.com>
1144
1145         * solib-spu.c (ocl_program_data_key): Change type.
1146         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1147         Update.
1148
1149 2019-07-10  Tom Tromey  <tromey@adacore.com>
1150
1151         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1152         (struct solib_aix_inferior_data) <library_list>: Change type.
1153         (solib_aix_inferior_data_handle): Change type.
1154         (get_solib_aix_inferior_data): Update.
1155         (solib_aix_free_library_list): Remove.
1156         (library_list_start_library): Update.
1157         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1158         return type.
1159         (solib_aix_get_library_list)
1160         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1161         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1162
1163 2019-07-10  Tom Tromey  <tromey@adacore.com>
1164
1165         * solib-dsbt.c (struct dsbt_info): Add initializers.
1166         (solib_dsbt_pspace_data): Change type.
1167         (dsbt_pspace_data_cleanup): Remove.
1168         (get_dsbt_info, _initialize_dsbt_solib): Update.
1169
1170 2019-07-10  Tom Tromey  <tromey@adacore.com>
1171
1172         * spu-tdep.c (spu_overlay_data): Change type.
1173         (spu_get_overlay_table, spu_overlay_new_objfile)
1174         (_initialize_spu_tdep): Update.
1175
1176 2019-07-10  Tom Tromey  <tromey@adacore.com>
1177
1178         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1179         destructor.
1180         (dbx_objfile_data_key): Change type and declare later.
1181         (DBX_SYMFILE_INFO): Rewrite.
1182         * dbxread.c (dbx_objfile_data_key): Change type.
1183         (dbx_symfile_init): Update.
1184         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1185         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1186         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1187
1188 2019-07-10  Tom Tromey  <tromey@adacore.com>
1189
1190         * jit.c (jit_program_space_key): Change type.  Move lower.
1191         (get_jit_program_space_data): Update.
1192         (jit_program_space_data_cleanup): Remove.
1193         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1194         Update.
1195         (struct jit_program_space_data): Add initializers.
1196
1197 2019-07-10  Tom Tromey  <tromey@adacore.com>
1198
1199         * solib-darwin.c (struct darwin_info): Add initializers.
1200         (solib_darwin_pspace_data): Change type.
1201         (darwin_pspace_data_cleanup): Remove.
1202         (get_darwin_info, _initialize_darwin_solib): Update.
1203
1204 2019-07-10  Tom Tromey  <tromey@adacore.com>
1205
1206         * remote-sim.c (struct sim_inferior_data): Add initializers,
1207         constructor, and destructor.
1208         (sim_inferior_data_key): Change type.  Move lower.
1209         (check_for_duplicate_sim_descriptor): Update.
1210         (get_sim_inferior_data): Use new.  Update.
1211         (~sim_inferior_data_cleanup): Rename from
1212         sim_inferior_data_cleanup.  Simplify.
1213         (gdbsim_close_inferior, simulator_command)
1214         (sim_command_completer, _initialize_remote_sim): Update.
1215         (next_pid, INITIAL_PID): Move earlier.
1216
1217 2019-07-10  Tom Tromey  <tromey@adacore.com>
1218
1219         * python/python-internal.h (create_thread_object): Return
1220         gdbpy_ref.
1221         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1222         * python/py-inferior.c (struct threadlist_entry): Add
1223         constructor.
1224         <thread_obj>: Now a gdbpy_ref.
1225         (thread_to_thread_object): Update.
1226         (add_thread_object): Use new.
1227         (delete_thread_object): Use delete.
1228         (infpy_threads): Update.
1229         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1230         GIL.
1231
1232 2019-07-10  Tom Tromey  <tromey@adacore.com>
1233
1234         * valops.c (value_cast): Specialize error message for Ada.
1235
1236 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1237
1238         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1239
1240 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1241
1242         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1243         bpstat_should_step): Return bool, adjust comments.
1244         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1245         bpstat_should_step): Likewise.
1246
1247 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1248
1249         * features/Makefile: Use feature target descriptions for Arm.
1250         * features/arm/arm-core.c: Generate new file.
1251         * features/arm/arm-fpa.c: Likewise.
1252         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1253         * features/arm/arm-m-profile.c: Likewise.
1254         * features/arm/arm-vfpv2.c: Likewise.
1255         * features/arm/arm-vfpv3.c: Likewise.
1256         * features/arm/xscale-iwmmxt.c: Likewise.
1257         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1258
1259 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1260
1261         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1262         ptrace earlier.
1263
1264 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1265
1266         * features/aarch64-pauth.c: Regenerate.
1267
1268 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1269
1270         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1271         bool.
1272         (bpstat_what): Use false instead of 0.
1273
1274 2019-07-09  Pedro Alves  <palves@redhat.com>
1275
1276         * break-catch-throw.c (is_exception_catchpoint): New.
1277         * breakpoint.c (print_one_breakpoint_location): New parameter
1278         'raw_loc'.  Handle it.  Use
1279         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1280         looking at the breakpoint's type.
1281         (print_one_breakpoint): If handling "maint info breakpoints", also
1282         print locations of exception catchpoints.
1283         * breakpoint.h (is_exception_catchpoint): Declare.
1284
1285 2019-07-09  Pedro Alves  <palves@redhat.com>
1286
1287         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1288         "addr" field.
1289         (allocate_location_exception_catchpoint): New.
1290         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1291         (initialize_throw_catchpoint_ops): Install
1292         allocate_location_exception_catchpoint as allocate_location
1293         method.
1294         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1295         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1296         bp_loc_other.
1297         (breakpoint_address_is_meaningful): Delete.
1298         (bl_address_is_meaningful): New.
1299         (breakpoint_locations_match): Adjust comment.
1300         (bp_location_from_bp_type): New, factored out of...
1301         (bp_location::bp_location(breakpoint *)): ... this.
1302         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1303         factored out of...
1304         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1305         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1306         breakpoint_address_is_meaningful.
1307         (bp_locations_compare): Adjust comment.
1308         (update_global_location_list): Use bl_address_is_meaningful
1309         instead of breakpoint_address_is_meaningful.
1310         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1311         explicit.
1312         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1313         * python/py-breakpoint.c (bppy_get_location): No longer check
1314         whether location is null.
1315
1316 2019-07-09  Pedro Alves  <palves@redhat.com>
1317
1318         PR c++/15468
1319         * breakpoint.c (print_one_breakpoint_location): Remove
1320         single-location assert.
1321
1322 2019-07-09  Tom Tromey  <tom@tromey.com>
1323
1324         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1325         * configure: Rebuild.
1326         * configure.ac: Change common to gdbsupport.
1327         * gdbsupport: Rename from common.
1328         * acinclude.m4: Change common to gdbsupport.
1329         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1330         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1331         gdbsupport.
1332         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1333         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1334         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1335         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1336         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1337         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1338         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1339         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1340         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1341         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1342         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1343         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1344         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1345         coff-pe-read.c, command.h, compile/compile-c-support.c,
1346         compile/compile-c.h, compile/compile-cplus-symbols.c,
1347         compile/compile-cplus-types.c, compile/compile-cplus.h,
1348         compile/compile-loc2c.c, compile/compile.c, completer.c,
1349         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1350         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1351         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1352         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1353         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1354         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1355         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1356         features/aarch64-core.c, features/aarch64-fpu.c,
1357         features/aarch64-pauth.c, features/aarch64-sve.c,
1358         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1359         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1360         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1361         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1362         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1363         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1364         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1365         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1366         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1367         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1368         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1369         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1370         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1371         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1372         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1373         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1374         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1375         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1376         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1377         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1378         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1379         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1380         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1381         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1382         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1383         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1384         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1385         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1386         minsyms.c, mips-linux-tdep.c, namespace.h,
1387         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1388         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1389         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1390         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1391         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1392         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1393         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1394         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1395         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1396         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1397         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1398         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1399         procfs.c, producer.c, progspace.h, psymtab.h,
1400         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1401         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1402         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1403         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1404         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1405         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1406         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1407         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1408         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1409         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1410         target-memory.c, target.c, target.h, target/waitstatus.c,
1411         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1412         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1413         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1414         unittests/array-view-selftests.c,
1415         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1416         unittests/common-utils-selftests.c,
1417         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1418         unittests/format_pieces-selftests.c,
1419         unittests/function-view-selftests.c,
1420         unittests/lookup_name_info-selftests.c,
1421         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1422         unittests/mkdir-recursive-selftests.c,
1423         unittests/observable-selftests.c,
1424         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1425         unittests/parse-connection-spec-selftests.c,
1426         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1427         unittests/scoped_fd-selftests.c,
1428         unittests/scoped_mmap-selftests.c,
1429         unittests/scoped_restore-selftests.c,
1430         unittests/string_view-selftests.c, unittests/style-selftests.c,
1431         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1432         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1433         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1434         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1435         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1436         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1437
1438 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1439
1440         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1441         bool value.
1442         (decode_digits_ordinary): Set explicit_line field in sal.
1443         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1444         symtab_and_line that was set on an explicit line number in
1445         assembler code.  Do always update the recorded symtab and line if
1446         we do skip the prologue.
1447
1448 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * breakpoint.c (set_breakpoint_location_function): Remove
1451         explicit_loc parameter.
1452         (momentary_breakpoint_from_master): Update call to
1453         set_breakpoint_location_function.
1454         (add_location_to_breakpoint): Likewise.
1455
1456 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1459         required features based on default bfd type when no specific bfd
1460         is present.
1461
1462 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1463
1464         * NEWS: Mention that GDB printf and eval commands can now print
1465         C-style and Ada-style convenience var strings without
1466         calling the inferior.
1467         * printcmd.c (printf_c_string): Locally print GDB internal var
1468         instead of transiting via the inferior.
1469         (printf_wide_c_string): Likewise.
1470
1471 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1472
1473         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1474
1475 2019-07-04  Tom Tromey  <tom@tromey.com>
1476
1477         PR tui/24724:
1478         * tui/tui-winsource.c (tui_clear_source_content): Update.
1479         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1480         (tui_update_breakpoint_info): Update.
1481         (tui_set_exec_info_content): Update.
1482         * tui/tui-source.c (tui_set_source_content_nil): Update.
1483         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1484         has_break.
1485         * tui/tui-data.h (enum tui_bp_flag): New.
1486         (tui_bp_flags): New enum flags type.
1487         (struct tui_source_element) <break_mode>: Change type.  Rename
1488         from has_break.
1489         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1490         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1491         constants.
1492         * tui/tui-winsource.h: Fix comment.
1493
1494 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1495
1496         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1497         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1498         (store_fpregs_to_thread)
1499         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1500         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1501         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1502         (IWMMXT_REGS_SIZE): Add define.
1503         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1504         (fetch_vfp_regs, store_vfp_regs)
1505         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1506         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1507
1508 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1509
1510         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1511         defines.
1512         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1513         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1514         (ARM_INT_REGISTER_SIZE): ...to this.
1515         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1516         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1517         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1518         (arm_linux_collect_gregset, supply_nwfpe_register)
1519         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1520         defines.
1521         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1522         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1523         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1524         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1525         (arm_return_in_memory, arm_store_return_value)
1526         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1527         (arm_record_ld_st_multiple): Likewise.
1528         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1529         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1530
1531 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1532
1533         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1534         AARCH64_DISPLACED_MODIFIED_INSNS.
1535         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1536         (aarch64_displaced_step_copy_insn): Likewise.
1537         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1538         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1539         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1540         ARM_DISPLACED_MODIFIED_INSNS.
1541         * arm-tdep.c (arm_gdbarch_init): Likewise.
1542         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1543         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1544         (struct arm_displaced_step_closure): Use
1545         ARM_DISPLACED_MODIFIED_INSNS.
1546
1547 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1548
1549         * features/Makefile: Remove unused xml files.
1550         * features/aarch64.xml: Remove.
1551         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1552         * features/i386/amd64-avx-avx512.xml: Remove.
1553         * features/i386/amd64-avx-linux.xml: Remove.
1554         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1555         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1556         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1557         * features/i386/amd64-avx-mpx.xml: Remove.
1558         * features/i386/amd64-avx.xml: Remove.
1559         * features/i386/amd64-linux.xml: Remove.
1560         * features/i386/amd64-mpx-linux.xml: Remove.
1561         * features/i386/amd64-mpx.xml: Remove.
1562         * features/i386/amd64.xml: Remove.
1563         * features/i386/i386-avx-avx512-linux.xml: Remove.
1564         * features/i386/i386-avx-avx512.xml: Remove.
1565         * features/i386/i386-avx-linux.xml: Remove.
1566         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1567         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1568         * features/i386/i386-avx-mpx-linux.xml: Remove.
1569         * features/i386/i386-avx-mpx.xml: Remove.
1570         * features/i386/i386-avx.xml: Remove.
1571         * features/i386/i386-linux.xml: Remove.
1572         * features/i386/i386-mmx-linux.xml: Remove.
1573         * features/i386/i386-mmx.xml: Remove.
1574         * features/i386/i386-mpx-linux.xml: Remove.
1575         * features/i386/i386-mpx.xml: Remove.
1576         * features/i386/i386.xml: Remove.
1577         * features/i386/x32-avx-avx512-linux.xml: Remove.
1578         * features/i386/x32-avx-linux.xml: Remove.
1579         * features/i386/x32-linux.xml: Remove.
1580
1581 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1582
1583         * regformats/aarch64.dat: Remove.
1584         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1585         * regformats/i386/amd64-avx-linux.dat: Remove.
1586         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1587         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1588         * regformats/i386/amd64-linux.dat: Remove.
1589         * regformats/i386/amd64-mpx-linux.dat: Remove.
1590         * regformats/i386/amd64.dat: Remove.
1591         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1592         * regformats/i386/i386-avx-linux.dat: Remove.
1593         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1594         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1595         * regformats/i386/i386-linux.dat: Remove.
1596         * regformats/i386/i386-mmx-linux.dat: Remove.
1597         * regformats/i386/i386-mpx-linux.dat: Remove.
1598         * regformats/i386/i386.dat: Remove.
1599         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1600         * regformats/i386/x32-avx-linux.dat: Remove.
1601         * regformats/i386/x32-linux.dat: Remove.
1602
1603 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1604
1605         * aarch64-tdep.c: Remove xml self tests.
1606         * amd64-linux-tdep.c: Likewise.
1607         * amd64-tdep.c: Likewise.
1608         * i386-linux-tdep.c: Likewise.
1609         * i386-tdep.c: Likewise.
1610
1611 2019-07-03  Pedro Alves  <palves@redhat.com>
1612
1613         PR cli/24732
1614         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1615         (pipe_cmd_option_defs): New.
1616         (make_pipe_cmd_options_def_group): New.
1617         (pipe_command): Use gdb::option::process_options.
1618         (pipe_command_completer): New function.
1619         (_initialize_cli_cmds): Install completer for "pipe" command.
1620
1621 2019-07-03  Pedro Alves  <palves@redhat.com>
1622
1623         * cli/cli-option.c (union option_value) <string>: New field.
1624         (struct option_def_and_value): Add ctor, move ctor, dtor and
1625         use DISABLE_COPY_AND_ASSIGN.
1626         (option_def_and_value::clear_value): New.
1627         (parse_option, save_option_value_in_ctx, get_val_type_str)
1628         (add_setshow_cmds_for_options): Handle var_string.
1629         * cli-option.h (union option_def::var_address) <string>: New
1630         field.
1631         (struct string_option_def): New.
1632         * maint-test-options.c (struct test_options_opts): Add default
1633         ctor and use DISABLE_COPY_AND_ASSIGN.
1634         <string_opt>: New field.
1635         (test_options_opts::~test_options_opts): New.
1636         (test_options_opts::dump): Also dump "-string".
1637         (test_options_option_defs): Install "string.
1638
1639 2019-07-03  Pedro Alves  <palves@redhat.com>
1640
1641         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1642         option_value with a null enumeration.
1643         (complete_options): Save the option values in the context.
1644         (save_option_value_in_ctx): New, factored out from ...
1645         (process_options): ... here.
1646         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1647         of the function.
1648         * maint-test-options.c (test_options_opts::dump): New, factored
1649         out from ...
1650         (maintenance_test_options_command_mode): ... here.
1651         (maintenance_test_options_command_completion_result): Delete.
1652         (maintenance_test_options_command_completion_text): Update
1653         comment.
1654         (maintenance_show_test_options_completion_result): Change
1655         prototype.  Just print
1656         maintenance_test_options_command_completion_text.
1657         (save_completion_result): New.
1658         (maintenance_test_options_completer_mode): Pass options context to
1659         complete_options, and then save a dump.
1660         (_initialize_maint_test_options): Use add_cmd to install "maint
1661         show test-options-completion-result".
1662
1663 2019-07-03  Pedro Alves  <palves@redhat.com>
1664
1665         * NEWS (New commands): Mention "with" and "maint with".
1666         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1667         (with_command, with_command_completer): New.
1668         (pipe_command): Adjust to new repeat_previous
1669         interface.
1670         (_initialize_cli_cmds): Install the "with" command and its "w"
1671         alias.
1672         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1673         declarations.
1674         * cli/cli-setshow.c (parse_cli_var_uinteger)
1675         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1676         argument strings for all var_types.
1677         (get_setshow_command_value_string): New, factored out from ...
1678         (do_show_command): ... this.
1679         * cli/cli-setshow.h: Include <string>.
1680         (get_setshow_command_value_string): Declare.
1681         * command.h (repeat_previous): Now returns const char *.  Adjust
1682         comment.
1683         * maint.c: Include "cli/cli-cmds.h".
1684         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1685         (_initialize_maint_cmds): Register the "maintenance with" command.
1686         * top.c (repeat_previous): Move bits from pipe_command here:
1687         Return the saved command line, if any; error out if there's no
1688         command to relaunch.
1689
1690 2019-07-03  Pedro Alves  <palves@redhat.com>
1691
1692         * NEWS (New commands): Mention "maint set/show test-settings"
1693         instead of "maint test-settings".
1694         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1695         (maintenance_test_settings_set_list): Rename to ...
1696         (maintenance_set_test_settings_list): ... this.
1697         (maintenance_test_settings_show_list): Rename to  ...
1698         (maintenance_show_test_settings_list): ... this.
1699         (maintenance_test_settings_cmd): Delete.
1700         (maintenance_test_settings_set_cmd): ...
1701         (maintenance_set_test_settings_cmd): ... this.
1702         (maintenance_test_settings_show_cmd): ...
1703         (maintenance_show_test_settings_cmd): ... this.
1704         (maintenance_test_settings_show_value_cmd):
1705         (maintenance_show_test_settings_value_cmd): ... this.
1706         (_initialize_maint_test_settings): No longer install the "maint
1707         test-settings" prefix command.  Rename "maint test-settings set"
1708         to "maint set test-settings", and "maint test-settings show" to
1709         "maint show test-settings".  Adjust all subcommands.
1710
1711 2019-07-03  Pedro Alves  <palves@redhat.com>
1712
1713         * maint-test-settings.c: Fix file's intro comment.  Replace all
1714         references to "test-options" with references to "test-settings",
1715         in comments.
1716
1717 2019-07-03  Pedro Alves  <palves@redhat.com>
1718
1719         * maint-test-settings.c (maintenance_test_settings_xxx)
1720         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1721         New.
1722         (maintenance_test_settings_enums): Use them.
1723         (maintenance_test_settings_enum): Default to
1724         maintenance_test_settings_xxx.
1725         (_initialize_maint_test_settings): Initialize
1726         MAINTENANCE_TEST_SETTINGS_FILENAME.
1727
1728 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1729
1730         * breakpoint.h (remove_breakpoints_inf): Change return type to
1731         void, move function documentation here.
1732         * breakpoint.c (remove_breakpoints_inf): Change return type to
1733         void, move function documentation to header.
1734
1735 2019-07-02  Pedro Alves  <palves@redhat.com>
1736
1737         * NEWS (Completion improvements): Mention "info threads".
1738         * thread.c (struct info_threads_opts, info_threads_option_defs)
1739         (make_info_threads_options_def_group): New.
1740         (info_threads_command): Use gdb::option::process_options.
1741         (info_threads_command_completer): New.
1742         (_initialize_thread): Use gdb::option::build_help to build the
1743         help text for "info threads".
1744
1745 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1746
1747         * defs.h (generic_load): Move from here...
1748         * symfile.h (generic_load): ... to here.  Rename name parameter
1749         to args.
1750         * symfile.c (generic_load): Add comment.
1751
1752 2019-07-01  Tom Tromey  <tromey@adacore.com>
1753
1754         * dwarf2read.c
1755         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1756         declaration of without_params.  Fix formatting.
1757
1758 2019-07-01  Tom Tromey  <tromey@adacore.com>
1759
1760         * ada-exp.y (find_primitive_type): Update.
1761         * ada-lang.h (ada_lookup_symbol): Update.
1762         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1763         parameter.
1764         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1765
1766 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1767
1768         PR breakpoints/24541
1769         * gdbarch.c: Regenerate.
1770         * gdbarch.h: Regenerate.
1771         * gdbarch.sh: Add 'stap_adjust_register'.
1772         * i386-tdep.c: Include '<unordered_set>'.
1773         (i386_stap_adjust_register): New function.
1774         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1775         * stap-probe.c (stap_parse_register_operand): Call
1776         'gdbarch_stap_adjust_register'.
1777
1778 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1779
1780         PR python/24742
1781         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1782         * python/python.c (do_start_initialization): Use 'xmalloc'
1783         instead of 'PyMem_Malloc'.
1784
1785 2019-06-28  Tom Tromey  <tromey@adacore.com>
1786
1787         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1788         for Ada.
1789
1790 2019-06-27  Tom Tromey  <tromey@adacore.com>
1791
1792         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1793         objfile_key.
1794         (arm_find_mapping_symbol, arm_record_special_symbol)
1795         (_initialize_arm_tdep): Update.
1796         (arm_objfile_data_free): Remove.
1797
1798 2019-06-27  Tom Tromey  <tromey@adacore.com>
1799
1800         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1801         to cp_print_static_field.
1802
1803 2019-06-26  Tom Tromey  <tromey@adacore.com>
1804
1805         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1806         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1807         declare.
1808
1809 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1810
1811         * features/aarch64-core.c (create_feature_aarch64_core):
1812         Regenerate.
1813         * features/aarch64-core.xml: Add cpsr flags.
1814
1815 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1816
1817         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1818         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1819
1820 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1821
1822         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1823         field.
1824         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1825         use.
1826         (arm_record_special_symbol): Don't insert new symbol in sorted
1827         position, push it at the end.
1828
1829 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1830
1831         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1832         (arm_mapping_symbol_s): Remove.
1833         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1834         (arm_mapping_symbol_vec): New typedef.
1835         (struct arm_per_objfile): Add constructor.
1836         <section_maps>: Change type to
1837         std::unique_ptr<arm_mapping_symbol_vec[]>.
1838         (arm_compare_mapping_symbols): Remove.
1839         (arm_find_mapping_symbol): Adjust to section_maps type change.
1840         (arm_objfile_data_free): Call delete on arm_per_objfile.
1841         (arm_record_special_symbol): Adjust to section_maps type change.
1842         Allocate arm_per_objfile with new.
1843
1844 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1845
1846         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1847         with the command prefix.
1848
1849 2019-06-25  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1852         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1853
1854 2019-06-25  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1857         type.
1858         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1859         protected.
1860
1861 2019-06-25  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-winsource.c
1864         (tui_source_window_base::set_is_exec_point_at): Add check against
1865         LOA_ADDRESS.
1866
1867 2019-06-25  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-source.c (tui_set_source_content): Don't check before
1870         xfree.
1871         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1872
1873 2019-06-25  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-winsource.h (tui_update_source_window_as_is)
1876         (tui_alloc_source_buffer, tui_line_is_displayed)
1877         (tui_addr_is_displayed): Change type of win_info.
1878         * tui/tui-winsource.c (tui_update_source_window_as_is)
1879         (tui_clear_source_content, tui_show_source_line)
1880         (tui_show_source_content, tui_source_window_base::refill)
1881         (tui_source_window_base::set_is_exec_point_at)
1882         (tui_source_window_base::set_is_exec_point_at)
1883         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1884         (tui_alloc_source_buffer, tui_line_is_displayed)
1885         (tui_addr_is_displayed): Change type of win_info.  Update.
1886         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1887         (tui_source_window_base::do_make_visible_with_new_height):
1888         Update.
1889         * tui/tui-source.c (tui_set_source_content)
1890         (tui_set_source_content_nil)
1891         (tui_source_window::do_scroll_vertical): Update.
1892         * tui/tui-layout.c (show_layout): Update.
1893         * tui/tui-disasm.c (tui_set_disassem_content)
1894         (tui_disasm_window::do_scroll_vertical): Update.
1895         * tui/tui-data.h (tui_win_content): Remove.
1896         (struct tui_gen_win_info) <content, content_size>: Remove.
1897         (struct tui_source_element): Add initializers and destructor.
1898         (union tui_which_element, struct tui_win_element): Remove.
1899         (struct tui_source_window_base) <content>: New field.
1900         (struct tui_data_window): Remove destructor.
1901         (tui_alloc_content, tui_free_win_content)
1902         (tui_free_all_source_wins_content): Don't declare.
1903         * tui/tui-data.c (tui_initialize_static_data): Update.
1904         (init_content_element, tui_alloc_content): Remove.
1905         (~tui_gen_win_info): Update.
1906         (~tui_data_window, tui_free_all_source_wins_content)
1907         (tui_free_win_content, free_content, free_content_elements):
1908         Remove.
1909
1910 2019-06-25  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-winsource.h (tui_clear_source_content)
1913         (tui_erase_source_content, tui_show_source_content): Change type
1914         of win_info.
1915         * tui/tui-winsource.c (tui_clear_source_content)
1916         (tui_erase_source_content, tui_show_source_content): Change type
1917         of win_info.
1918         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1919         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1920         win_info.
1921         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1922         win_info.
1923         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-winsource.c (tui_clear_source_content)
1928         (tui_source_window_base::set_is_exec_point_at): Update.
1929         * tui/tui-source.c (tui_set_source_content_nil): Update.
1930         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1931         a bool.
1932         * tui/tui-data.c (init_content_element): Update.
1933
1934 2019-06-25  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1937         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1938         * tui/tui-layout.c (init_and_make_win): Update.
1939         * tui/tui.h (enum tui_win_type): Update.
1940         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1941         tui_win_is_auxillary.
1942         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1943         tui_win_is_auxillary.
1944
1945 2019-06-25  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1948         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1949         (tui_delete_data_content_windows, tui_display_all_data)
1950         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1951         Update.
1952         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1953         * tui/tui-regs.c (tui_last_regs_line_no)
1954         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1955         (tui_show_registers): Update.
1956         (tui_show_register_group): Return void.  Update.
1957         (tui_display_registers_from, tui_display_reg_element_at_line)
1958         (tui_display_registers_from_line, tui_check_register_values):
1959         Update.
1960         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1961         member.
1962         (struct tui_data_window) <regs_content>: Now a std::vector.
1963         <regs_content_count>: Remove.
1964         (tui_add_content_elements, tui_free_data_content): Don't declare.
1965         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1966         (init_content_element): Remove DATA_WIN case.  Add assert.
1967         (tui_add_content_elements): Remove.
1968         (tui_data_window): Update.
1969         (tui_free_data_content): Remove.
1970         (free_content_elements): Remove DATA_WIN case.
1971
1972 2019-06-25  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-data.c (tui_data_item_window): Update.
1975         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1976         * tui/tui-windata.c (tui_display_all_data)
1977         (tui_display_data_from_line): Update.
1978         (tui_check_data_values): Remove.
1979         * tui/tui-regs.c (tui_show_register_group)
1980         (tui_display_reg_element_at_line): Update.
1981         * tui/tui-hooks.c (tui_register_changed)
1982         (tui_refresh_frame_and_register_information): Call
1983         tui_check_register_values.
1984         * tui/tui-data.h (struct tui_data_window) <data_content,
1985         data_content_count, data_type>: Remove.
1986         (enum tui_data_type): Remove.
1987
1988         * tui/tui-data.c (tui_data_window::clear_detail)
1989         (~tui_data_window): Update.
1990
1991 2019-06-25  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1994         declare.
1995         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1996         Rename from tui_first_data_item_displayed.  Update.
1997         (tui_data_window::refresh_all)
1998         (tui_data_window::do_scroll_vertical): Update.
1999         * tui/tui-data.h (struct tui_data_window)
2000         <first_data_item_displayed>: Declare new method.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2005         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2006         contents...
2007         (tui_initialize_static_data): ...here.
2008
2009 2019-06-25  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2012         (tui_display_registers_from, tui_check_register_values): Update.
2013         (tui_display_register): Remove win_info parameter; update.
2014         (tui_get_register): Change type of parameters.
2015         * tui/tui-data.h (struct tui_data_element): Remove.
2016         (union tui_which_element) <data>: Remove.
2017         <data_window>: Change type.
2018         (struct tui_data_item_window): New.
2019         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2020         case.  Add assert.
2021         (~tui_data_item_window): New destructor.
2022         (free_content_elements): Remove DATA_ITEM_WIN case.
2023
2024 2019-06-25  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2027         Remove.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-data.h (struct tui_command_element): Remove.
2032         (union tui_which_element) <command>: Remove.
2033         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2034         assert.
2035         (free_content_elements): Remove CMD_WIN case.
2036
2037 2019-06-25  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-layout.c (tui_set_layout): Update.
2040         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2041         * tui/tui-data.c (layout_def): Update.
2042
2043 2019-06-25  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2046         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2047         (tui_source_window_base::set_new_height): Update.
2048         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2049         Update.
2050         (tui_set_locator_fullname, tui_set_locator_info)
2051         (tui_show_frame_info): Update.
2052         * tui/tui-source.c (tui_set_source_content)
2053         (tui_source_is_displayed): Update.
2054         * tui/tui-layout.c (show_source_disasm_command, show_data)
2055         (show_source_or_disasm_and_command): Update.
2056         * tui/tui-disasm.c (tui_set_disassem_content)
2057         (tui_get_begin_asm_address): Update.
2058         * tui/tui-data.h (struct tui_locator_element): Remove.
2059         (union tui_which_element) <locator>: Remove.
2060         (struct tui_locator_window): New.
2061         (tui_locator_win_info_ptr): Change return type.
2062         * tui/tui-data.c (_locator): Change type.
2063         (tui_locator_win_info_ptr): Change return type.
2064         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2065         (tui_alloc_content): Add assert.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-winsource.c
2070         (tui_exec_info_window::maybe_allocate_content): New method.
2071         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2072         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2073         (make_source_or_disasm_window): Add cast.
2074         * tui/tui-data.h (union tui_which_element) <simple_string>:
2075         Remove.
2076         (struct tui_source_info): New.
2077         (struct tui_source_window_base) <execution_info>: Change type.
2078         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2079         case, and add assert.
2080         (tui_alloc_content): Add assert.
2081
2082 2019-06-25  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2085         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2086         * tui/tui-data.c (tui_alloc_win_info): Remove.
2087
2088 2019-06-25  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2091         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2092         can_highlight.
2093
2094 2019-06-25  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2097         make_visible_with_new_height method.
2098         (tui_win_info::make_visible_with_new_height): New method.
2099         (tui_source_window_base::do_make_visible_with_new_height)
2100         (tui_data_window::do_make_visible_with_new_height)
2101         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2102         (make_visible_with_new_height): Remove.
2103         (tui_resize_all, tui_adjust_win_heights): Use
2104         make_visible_with_new_height method.
2105         * tui/tui-data.h (struct tui_win_info)
2106         <do_make_visible_with_new_height, make_visible_with_new_height>:
2107         New methods.
2108         (struct tui_source_window_base, struct tui_data_window)
2109         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2110         methods.
2111
2112 2019-06-25  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2115         method.
2116         (update_tab_width): Call update_tab_width method.
2117         * tui/tui-data.h (struct tui_win_info)
2118         (struct tui_source_window_base) <update_tab_width>: New methods.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2123         parameter.
2124         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2125         parameter.
2126         (tui_gen_win_info::make_visible): Update.
2127         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2128         parameter.
2129         * tui/tui-data.h (enum tui_box): New enum.
2130         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2135         init_and_make_win for EXEC_INFO_WIN.
2136         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2137         longer inline.
2138         (struct tui_win_info) <~tui_win_info>: Inline.
2139         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2140         Don't declare.
2141         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2142         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2143         Remove.
2144         (tui_initialize_static_data): Update.
2145         (~tui_gen_win_info): Handle more cleanup here.
2146         (~tui_source_window_base): Delete "execution_info".
2147         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-layout.c (make_command_window): Don't set
2152         can_highlight.
2153         (show_source_disasm_command): Call the reset method.
2154         (show_data): Don't set can_highlight.  Call the reset method.
2155         (tui_gen_win_info::reset): Rename from init_gen_win_info
2156         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2157         (show_source_or_disasm_and_command): Call the reset method.
2158         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2159         (struct tui_cmd_window): Set can_highlight.
2160
2161 2019-06-25  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2164         from make_visible.
2165         (tui_make_visible, tui_make_invisible): Rewrite.
2166         (tui_win_info::make_visible): Remove.
2167         (tui_source_window_base::make_visible): Update.
2168         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2169         method.  Moved from...
2170         (struct tui_win_info) <make_visible>: ...here.
2171
2172 2019-06-25  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-winsource.c
2175         (tui_source_window_base::do_scroll_horizontal): Remove direction
2176         parameter.
2177         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2178         direction parameter.
2179         * tui/tui-win.c (tui_win_info::forward_scroll)
2180         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2181         (tui_win_info::right_scroll): Update.
2182         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2183         direction parameter.
2184         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2185         direction parameter.
2186         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2187         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2188         Remove direction parameter.
2189         (struct tui_source_window_base, struct tui_source_window)
2190         (struct tui_disasm_window, struct tui_data_window)
2191         (struct tui_cmd_window): Update.
2192
2193 2019-06-25  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-winsource.h (tui_set_exec_info_content)
2196         (tui_show_exec_info_content, tui_erase_exec_info_content)
2197         (tui_clear_exec_info_content, tui_update_exec_info): Change
2198         argument to tui_source_window_base.
2199         * tui/tui-winsource.c (tui_set_exec_info_content)
2200         (tui_show_exec_info_content, tui_erase_exec_info_content)
2201         (tui_clear_exec_info_content, tui_update_exec_info): Change
2202         argument to tui_source_window_base.
2203
2204 2019-06-25  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2207         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2208
2209 2019-06-25  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2212         check.
2213
2214 2019-06-25  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2217         type to void.
2218         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2219         type to void.
2220         * tui/tui-source.c (tui_set_source_content): Update.
2221         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2222
2223 2019-06-25  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-win.c (window_name_completer, tui_set_focus)
2226         (tui_all_windows_info): Use name method.
2227         * tui/tui-data.h (struct tui_gen_win_info)
2228         (struct tui_source_window, struct tui_disasm_window)
2229         (struct tui_data_window, struct tui_cmd_window) <name>: New
2230         method.
2231         (tui_win_name): Don't declare.
2232         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2233         (tui_win_name): Remove.
2234
2235 2019-06-25  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-winsource.h (tui_update_source_window)
2238         (tui_update_source_window_as_is): Change parameter type.
2239         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2240         to be a tui_source_window_base.
2241         (tui_update_source_window_as_is): Likewise.
2242         * tui/tui-win.c (make_visible_with_new_height): Update.
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-winsource.c (tui_erase_source_content)
2247         (tui_show_source_content, tui_show_exec_info_content)
2248         (tui_erase_exec_info_content): Use refresh_window method.
2249         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2250         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2251         from tui_refresh_win.
2252         (tui_data_window::refresh_window): New method.
2253         (tui_win_info::refresh, tui_source_window_base::refresh)
2254         (tui_refresh_all): Use refresh_window method.
2255         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2256         method.
2257         * tui/tui-regs.c (tui_display_register): Call refresh_window
2258         method.
2259         * tui/tui-layout.c (show_source_disasm_command)
2260         (show_source_or_disasm_and_command): Call refresh_window method.
2261         * tui/tui-data.h (struct tui_gen_win_info)
2262         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2263         New method.
2264
2265 2019-06-25  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui.c (tui_rl_other_window, tui_enable)
2268         (tui_is_window_visible, tui_get_command_dimension): Update.
2269         * tui/tui-winsource.c (tui_update_source_window_as_is)
2270         (tui_clear_source_content, tui_erase_source_content)
2271         (tui_show_source_line, tui_source_window_base::refill)
2272         (tui_source_window_base::do_scroll_horizontal)
2273         (tui_source_window_base::set_is_exec_point_at)
2274         (tui_update_breakpoint_info, tui_set_exec_info_content)
2275         (tui_alloc_source_buffer, tui_line_is_displayed)
2276         (tui_addr_is_displayed): Update.
2277         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2278         (tui_check_and_display_highlight_if_needed)
2279         (tui_win_info::make_visible, tui_win_info::refresh)
2280         (tui_refresh_all): Update.
2281         * tui/tui-windata.c (tui_first_data_item_displayed)
2282         (tui_delete_data_content_windows, tui_erase_data_content)
2283         (tui_display_all_data, tui_data_window::refresh_all)
2284         (tui_check_data_values): Update.
2285         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2286         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2287         (tui_win_info::backward_scroll, tui_refresh_all_win)
2288         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2289         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2290         (tui_source_window_base::set_new_height)
2291         (tui_data_window::set_new_height)
2292         (make_invisible_and_set_new_height)
2293         (make_visible_with_new_height, new_height_ok)
2294         (parse_scrolling_args): Update.
2295         * tui/tui-stack.c (tui_show_frame_info): Update.
2296         * tui/tui-source.c (tui_set_source_content)
2297         (tui_set_source_content_nil, tui_source_is_displayed)
2298         (tui_source_window::do_scroll_vertical): Update.
2299         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2300         (tui_display_registers_from, tui_display_reg_element_at_line)
2301         (tui_check_register_values, tui_reg_command): Update.
2302         * tui/tui-layout.c (tui_default_win_height)
2303         (show_source_disasm_command, show_data, init_and_make_win)
2304         (show_source_or_disasm_and_command): Update.
2305         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2306         (tui_redisplay_readline, tui_mld_flush)
2307         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2308         (tui_getc): Update.
2309         * tui/tui-disasm.c (tui_set_disassem_content)
2310         (tui_disasm_window::do_scroll_vertical): Update.
2311         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2312         Now virtual.
2313         (struct tui_win_info): Derive from tui_gen_win_info.
2314         <~tui_win_info>: Mark as override.
2315         <generic>: Remove member.
2316         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2317         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2318         (~tui_data_window, ~tui_win_info)
2319         (tui_free_all_source_wins_content): Update.
2320         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2321
2322 2019-06-25  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-layout.c (init_and_make_win): Use new.
2325         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2326         destructor, initializers.
2327         (tui_alloc_generic_win_info): Don't declare.
2328         * tui/tui-data.c (_locator): Add argument to constructor.
2329         (source_win, disasm_win): New globals.
2330         (exec_info): Remove.
2331         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2332         Update.
2333         (tui_alloc_generic_win_info): Remove.
2334         (init_content_element): Use new.
2335         (tui_win_info::tui_win_info): Update.
2336         (free_content_elements) <case DATA_WIN>: Use delete.
2337
2338 2019-06-25  Tom Tromey  <tom@tromey.com>
2339
2340         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2341         * tui/tui-windata.c (tui_first_data_item_displayed)
2342         (tui_delete_data_content_windows): Update.
2343         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2344         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2345         (tui_display_registers_from, tui_check_register_values): Update.
2346         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2347         pointer.
2348         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2349         window.
2350         (tui_free_data_content): Update.
2351         (free_content_elements) <case DATA_WIN>: Free the window.
2352
2353 2019-06-25  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2356         Update.
2357         * tui/tui-layout.c (make_command_window)
2358         (show_source_disasm_command, show_data, init_and_make_win)
2359         (show_source_or_disasm_and_command): Update.
2360         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2361         method.
2362         <can_highight, is_highlighted>: Now bool.
2363         (tui_set_win_highlight): Don't declare.
2364         * tui/tui-data.c (tui_set_win_highlight): Remove.
2365
2366 2019-06-25  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-wingeneral.c (make_visible): Remove check of window
2369         type.
2370
2371 2019-06-25  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-win.c (tui_win_info::max_height)
2374         (tui_cmd_window::max_height): New methods.
2375         (new_height_ok): Call max_height.
2376         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2377         <max_height>: New method.
2378
2379 2019-06-25  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-win.c (tui_source_window_base::set_new_height)
2382         (tui_data_window::set_new_height): New methods.
2383         (make_invisible_and_set_new_height): Call set_new_height method.
2384         * tui/tui-data.h (struct tui_win_info)
2385         (struct tui_source_window_base, struct tui_data_window)
2386         <set_new_height>: New method.
2387
2388 2019-06-25  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2391         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2392         tui_refresh_data_win.
2393         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2394         method.
2395         (tui_refresh_all_win): Call the refresh_all method.
2396         (tui_set_focus): Likewise.
2397         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2398         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2399         Likewise.
2400
2401 2019-06-25  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-winsource.h (tui_refill_source_window)
2404         (tui_set_is_exec_point_at): Don't declare.
2405         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2406         (tui_source_window_base::refill): Rename from
2407         tui_refill_source_window.
2408         (tui_source_window_base::do_scroll_horizontal): Update.
2409         (tui_source_window_base::set_is_exec_point_at): Rename from
2410         tui_set_is_exec_point_at.
2411         (tui_update_all_breakpoint_info): Update.
2412         * tui/tui-stack.c (tui_show_frame_info): Update.
2413         * tui/tui-layout.c (show_data): Add cast.
2414         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2415         * tui/tui-data.h (struct tui_source_window_base) <refill,
2416         set_is_exec_point_at>: New methods.
2417         (tui_source_windows, tui_add_to_source_windows): Update types.
2418         (tui_add_to_source_windows): Remove redundant declaration.
2419         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2420         (tui_source_windows): Change return type.
2421         (tui_clear_source_windows_detail): Update.
2422         (tui_add_to_source_windows): Change type of parameter.
2423         (tui_free_all_source_wins_content): Update.
2424
2425 2019-06-25  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-wingeneral.c (tui_win_info::refresh)
2428         (tui_source_window_base::refresh): New methods.
2429         (tui_refresh_all): Call the refresh method.
2430         * tui/tui-data.h (struct tui_win_info)
2431         (struct tui_source_window_base) <refresh>: New method.
2432
2433 2019-06-25  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui.h (tui_is_window_visible): Return bool.
2436         * tui/tui.c (tui_is_window_visible): Return bool.
2437         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2438         (tui_make_visible, tui_make_invisible)
2439         (tui_win_info::make_visible)
2440         (tui_source_window_base::make_visible, make_all_visible)
2441         (tui_make_all_visible, tui_make_all_invisible): Update.
2442         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2443         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2444         bool.
2445         (struct tui_win_info, struct tui_source_window_base)
2446         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2447         * tui/tui-data.c (tui_init_generic_part): Update.
2448
2449 2019-06-25  Tom Tromey  <tom@tromey.com>
2450
2451         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2452         (tui_source_window_base::make_visible): New methods.
2453         (make_all_visible): Make method call.
2454         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2455         (struct tui_source_window_base, struct tui_cmd_window): Override
2456         make_visible.
2457         (tui_win_is_source_type): Don't declare.
2458         * tui/tui-data.c (tui_win_is_source_type): Remove.
2459
2460 2019-06-25  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2463         NULL check.
2464
2465 2019-06-25  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2468         Inline constructor.  Add initializers for members.
2469         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2470         constructors; now inline in class.
2471
2472 2019-06-25  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-regs.c (tui_show_registers): Update.
2475         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2476         bool.
2477         * tui/tui-data.c (tui_data_window::clear_detail)
2478         (tui_data_window): Update.
2479
2480 2019-06-25  Tom Tromey  <tom@tromey.com>
2481
2482         * tui/tui-windata.c (tui_display_all_data)
2483         (tui_display_data_from_line, tui_display_data_from)
2484         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2485         Update.
2486         * tui/tui-regs.c (tui_last_regs_line_no)
2487         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2488         (tui_show_registers, tui_show_register_group)
2489         (tui_display_registers_from, tui_display_reg_element_at_line)
2490         (tui_display_registers_from_line, tui_check_register_values)
2491         (tui_reg_next, tui_reg_prev): Update.
2492         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2493         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2494         tui_data_window.
2495         (struct tui_win_info) <detail>: Remove.  Add new fields from
2496         tui_data_info.
2497         (TUI_DATA_WIN): Add cast.
2498         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2499         (~tui_data_window): Simplify.
2500
2501 2019-06-25  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-layout.c (show_source_disasm_command)
2504         (show_source_or_disasm_and_command): Update.
2505         * tui/tui-io.c (update_cmdwin_start_line)
2506         (tui_redisplay_readline): Update.
2507         * tui/tui-data.h (struct tui_command_info): Remove.
2508         (struct tui_win_info) <detail>: Remove command_info member.
2509         (struct tui_data_window) <start_line>: New member, from
2510         tui_command_info.
2511         (TUI_CMD_WIN): Add casts.
2512
2513 2019-06-25  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-winsource.c (tui_update_source_window)
2516         (tui_refill_source_window)
2517         (tui_source_window_base::do_scroll_horizontal)
2518         (tui_update_breakpoint_info, tui_set_exec_info_content)
2519         (tui_show_exec_info_content, tui_erase_exec_info_content)
2520         (tui_clear_exec_info_content): Update.
2521         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2522         Update.
2523         * tui/tui-win.c (make_invisible_and_set_new_height)
2524         (make_visible_with_new_height): Update.
2525         * tui/tui-source.c (tui_set_source_content)
2526         (tui_show_symtab_source): Update.
2527         * tui/tui-layout.c (extract_display_start_addr)
2528         (show_source_disasm_command, show_data)
2529         (make_source_or_disasm_window)
2530         (show_source_or_disasm_and_command): Update.
2531         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2532         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2533         "gdbarch".
2534         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2535         to tui_source_window_base.
2536         (struct tui_win_info) <detail>: Remove source_info member.
2537         (struct tui_source_window_base) <has_locator>: Inline.
2538         Move contents from tui_source_info; rename has_locator member to
2539         m_has_locator.
2540         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2541         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2542         header file.
2543         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2544         Simplify.
2545         (tui_free_all_source_wins_content): Cast to
2546         tui_source_window_base.
2547
2548 2019-06-25  Tom Tromey  <tom@tromey.com>
2549
2550         * tui/tui-win.c (make_invisible_and_set_new_height)
2551         (make_visible_with_new_height): Call has_locator method.
2552         * tui/tui-layout.c (show_source_disasm_command, show_data)
2553         (show_source_or_disasm_and_command): Update for bool change.
2554         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2555         (tui_win_info) <has_locator>: New method.
2556         (struct tui_source_window_base) <has_locator>: New method.
2557         (tui_win_has_locator): Don't declare.
2558         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2559         from tui_win_has_locator.
2560         (tui_source_window_base): Use false, not FALSE.
2561
2562 2019-06-25  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2565         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2566         clear_detail method directly.
2567         (tui_clear_win_detail): Remove.
2568
2569 2019-06-25  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2572         "this", not TUI_DISASM_WIN.
2573
2574 2019-06-25  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2577         declare.
2578         * tui/tui-winsource.c
2579         (tui_source_window_base::do_scroll_horizontal): Rename from
2580         tui_horizontal_source_scroll.
2581         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2582         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2583         from tui_vertical_data_scroll.
2584         * tui/tui-win.h (tui_scroll): Don't declare.
2585         * tui/tui-win.c (tui_win_info::forward_scroll)
2586         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2587         (tui_win_info::right_scroll): Rename and update.
2588         (tui_scroll_forward_command, tui_scroll_backward_command)
2589         (tui_scroll_left_command, tui_scroll_right_command): Update.
2590         (tui_scroll): Remove.
2591         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2592         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2593         from tui_vertical_source_scroll.
2594         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2595         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2596         from tui_vertical_disassem_scroll.
2597         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2598         do_scroll_horizontal>: New methods.
2599         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2600         Likewise.
2601         (struct tui_source_window_base): Add do_scroll_horizontal.
2602         (struct tui_source_window, struct tui_disasm_window): Add
2603         do_scroll_vertical.
2604         (struct tui_data_window, struct tui_cmd_window): Add
2605         do_scroll_horizontal and do_scroll_vertical.
2606         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2607
2608 2019-06-25  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-data.h (struct tui_source_window_base): New struct.
2611         (struct tui_source_window): Derive from tui_source_window_base.
2612         (struct tui_disasm_window): New struct.
2613         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2614         from tui_source_window::clear_detail.
2615         (tui_source_window_base): Rename from tui_source_window.
2616         (~tui_source_window_base): Rename from ~tui_source_window.
2617         (tui_alloc_win_info): Create a tui_disasm_window.
2618
2619 2019-06-25  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-data.h (struct tui_source_window)
2622         (struct tui_data_window): Declare destructors.
2623         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2624         destructors.
2625         (tui_win_info): Simplify.
2626
2627 2019-06-25  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-winsource.c (tui_display_main)
2630         (tui_update_source_windows_with_addr)
2631         (tui_update_all_breakpoint_info): Update.
2632         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2633         (new_height_ok, parse_scrolling_args): Update.
2634         * tui/tui-stack.c (tui_show_frame_info): Update.
2635         * tui/tui-data.h (struct tui_list): Remove.
2636         (tui_source_windows): Return a reference to a std::vector.
2637         * tui/tui-data.c (source_windows): Now a std::vector.
2638         (tui_source_windows): Change return type.
2639         (tui_clear_source_windows): Rewrite.
2640         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2641         (tui_free_all_source_wins_content): Rewrite.
2642
2643 2019-06-25  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2646         (struct tui_data_window, struct tui_cmd_window): Declare
2647         clear_detail method.
2648         * tui/tui-data.c (tui_source_window::clear_detail)
2649         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2650         methods.
2651         (tui_clear_win_detail): Simplify.
2652
2653 2019-06-25  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-layout.c (make_source_window, make_disasm_window)
2656         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2657         Return the new window.
2658         (show_source_disasm_command, show_data)
2659         (show_source_or_disasm_and_command): Update.
2660
2661 2019-06-25  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2664         parameter.  Return the new window.
2665         (show_source_disasm_command): Update and remove NULL check.
2666         (show_source_or_disasm_and_command): Update.
2667
2668 2019-06-25  Tom Tromey  <tom@tromey.com>
2669
2670         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2671
2672 2019-06-25  Tom Tromey  <tom@tromey.com>
2673
2674         * tui/tui-data.h (struct tui_win_info): Make constructor
2675         protected.  Make destructor virtual.  Add initializers.
2676         (tui_source_window, tui_data_window, tui_cmd_window): New
2677         classes.
2678         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2679         constructor.  Add "type" parameter.
2680         (tui_source_window, tui_data_window, tui_cmd_window): New
2681         constructors.
2682         (tui_alloc_win_info): Instantiate the appropriate subclass.
2683
2684 2019-06-25  Tom Tromey  <tom@tromey.com>
2685
2686         * tui/tui-win.c (tui_resize_all): Use delete.
2687         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2688         destructor.
2689         (tui_free_window): Don't declare.
2690         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2691         Update.
2692
2693 2019-06-25  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-data.h (struct tui_win_info): Add constructor.
2696         * tui/tui-data.c (tui_alloc_win_info): Use new.
2697         (tui_free_window): Use delete.
2698
2699 2019-06-22  Tom Tromey  <tom@tromey.com>
2700
2701         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2702         declare.
2703         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2704
2705 2019-06-22  Tom Tromey  <tom@tromey.com>
2706
2707         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2708         declare.
2709         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2710
2711 2019-06-22  Tom de Vries  <tdevries@suse.de>
2712
2713         * dwarf2read.c (create_addrmap_from_aranges)
2714         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2715         instead of '%zu'.
2716
2717 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2718
2719         * dwarf2read.h (dwarf2_section_info_def): Remove.
2720         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2721         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2722         std::vector<dwarf2_section_info>.
2723         (struct dwo_file) <~dwo_file>: Remove.
2724         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2725         types field.
2726         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2727         (dwarf2_read_debug_names): Likewise.
2728         (create_debug_types_hash_table): Change parameter type to
2729         array_view, adjust code accordingly.
2730         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2731         (partial_die_info::fixup): Likewise.
2732         (determine_prefix): Likewise.
2733         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2734
2735 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2736
2737         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2738         gdb_bfd_ref_ptr.
2739         <~dwo_file>: Remove call to gdb_bfd_unref.
2740         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2741         gdb_bfd_ref_ptr::get.
2742
2743 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2744
2745         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2746         type to htab_up.
2747         * dwarf2read.c (struct dwo_file): Initialize fields.
2748         <~dwo_file>: New.
2749         (free_dwo_file): Remove, move content to ~dwo_file.
2750         (struct dwo_file_deleter): Remove.
2751         (dwo_file_up>: Remove custom deleter.
2752         (free_dwo_files): Remove.
2753         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2754         dwo_files.
2755         (process_skeletonless_type_units): Call unique_ptr::get.
2756         (allocate_dwo_file_hash_table): Add deleter to created hash
2757         table.  Change return type to htab_up.
2758         (lookup_dwo_file_slot): Don't memset dwo_file, call
2759         unique_ptr::get.
2760         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2761         (create_dwo_unit_in_dwp_v2): Likewise.
2762         (open_and_init_dwo_file): Likewise.
2763         (free_dwo_file_from_slot): Remove.
2764
2765 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2766
2767         * dwarf2read.h (struct dwarf2_section_info) <readin,
2768         is_virtual>: Change type to bool.
2769         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2770         true instead of 1.
2771
2772 2019-06-19  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-data.h (tui_init_content_element): Don't declare.
2775
2776 2019-06-19  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-data.h (tui_init_win_info): Don't declare.
2779
2780 2019-06-19  Tom de Vries  <tdevries@suse.de>
2781
2782         * dwarf2read.h (abstract_to_concrete): Change type to
2783         std::unordered_map<sect_offset, std::vector<sect_offset>,
2784         gdb::hash_enum<sect_offset>>.
2785
2786 2019-06-19  Tom Tromey  <tromey@adacore.com>
2787
2788         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2789         EVAL_AVOID_SIDE_EFFECTS specially.
2790
2791 2019-06-19  Tom Tromey  <tromey@adacore.com>
2792
2793         * source-cache.c (highlighter): New global.
2794         (source_cache::get_source_lines): Create a highlighter on demand.
2795
2796 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * defs.h (deprecated_interactive_hook): Delete declaration.
2799         * interps.c (clear_interpreter_hooks): Remove use of
2800         deprecated_interactive_hook.
2801         * top.c (deprecated_interactive_hook): Delete definition.
2802         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2803
2804 2019-06-18  Tom de Vries  <tdevries@suse.de>
2805
2806         PR gdb/24515
2807         * dwarf2read.h (abstract_to_concrete): Change type from
2808         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2809         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2810         * dwarf2read.c (read_variable): Update.
2811         (dwarf2_fetch_die_loc_sect_off): Update.
2812
2813 2019-06-17  Tom de Vries  <tdevries@suse.de>
2814
2815         PR gdb/24617
2816         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2817         accessing parent[parent_len - 1].
2818
2819 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2820
2821         PR gdb/24364
2822         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2823         call dtrace_process_dof with NULL dof.
2824
2825 2019-06-16  Tom de Vries  <tdevries@suse.de>
2826
2827         PR gdb/24445
2828         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2829
2830 2019-06-16  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2833         (make_all_visible): Use address of member.
2834
2835 2019-06-16  Tom Tromey  <tom@tromey.com>
2836
2837         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2838         (tui_free_window, free_content, free_content_elements): Remove
2839         unnecessary cast.
2840         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2841         cast.
2842         * tui/tui-regs.c (tui_show_register_group)
2843         (tui_display_registers_from, tui_display_reg_element_at_line):
2844         Remove unnecessary cast.
2845
2846 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2847
2848         * linux-nat.c (normal_mask): Delete.
2849         (_initialize_linux_nat): Don't initialise normal_mask.
2850
2851 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2852
2853         PR gdb/24445
2854         * dwarf-index-write.h (write_psymtabs_to_index): Add
2855         dwz_basename parameter.
2856         * dwarf-index-write.c (write_gdbindex): Move file writing to
2857         write_gdbindex_1.  Change return type void.
2858         (assert_file_size): Move up, remove filename parameter.
2859         (write_gdbindex_1): New function.
2860         (write_debug_names): Change return type to void, call
2861         assert_file_size.
2862         (struct index_wip_file): New struct.
2863         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2864         file logic to index_wip_file.  Write index for dwz file if
2865         needed.
2866         (save_gdb_index_command): Pass basename of dwz file, if present.
2867         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2868         build-id of dwz file, if present.
2869         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2870         (dwarf2_get_dwz_file): Likewise.
2871         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2872         (dwarf2_get_dwz_file): Likewise.
2873
2874 2019-06-16  Tom Tromey  <tom@tromey.com>
2875
2876         * coffread.c (process_coff_symbol): Use xstrdup.
2877         * value.c (create_internalvar): Use xstrdup.
2878
2879 2019-06-16  Tom Tromey  <tom@tromey.com>
2880
2881         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2882         * breakpoint.c (stopin_command, stopat_command)
2883         (until_break_command, decode_location_default): Remove unnecessary
2884         cast.
2885         * utils.c (subset_compare): Remove unnecessary cast.
2886         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2887         cast.
2888         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2889         cast.
2890         * infcmd.c (path_command): Remove unnecessary cast.
2891         * coffread.c (decode_type): Remove unnecessary cast.
2892         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2893         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2894         * tui/tui-stack.c (tui_show_locator_content)
2895         (tui_show_frame_info): Remove unnecessary cast.
2896         * tui/tui-win.c (tui_scroll_forward_command)
2897         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2898         (parse_scrolling_args): Remove unnecessary cast.
2899         * tui/tui-data.c (init_win_info, tui_del_window)
2900         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2901         (free_content_elements): Remove unnecessary cast.
2902         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2903         unnecessary cast.
2904         * tui/tui-source.c (tui_set_source_content)
2905         (tui_vertical_source_scroll): Remove unnecessary cast.
2906         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2907         cast.
2908         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2909         * tui/tui-regs.c (tui_display_registers_from)
2910         (tui_display_register): Remove unnecessary cast.
2911         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2912         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2913         (make_visible): Remove unnecessary cast.
2914         * tui/tui-winsource.c (tui_erase_source_content)
2915         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2916         unnecessary cast.
2917         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2918         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2919         * stabsread.c (read_type, read_array_type, read_range_type):
2920         Remove unnecessary cast.
2921         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2922         (parse_symbol, parse_type, upgrade_type, parse_external)
2923         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2924         unnecessary cast.
2925         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2926
2927 2019-06-16  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-data.c (tui_alloc_generic_win_info)
2930         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2931         checks.
2932
2933 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2934             Andrew Burgess  <andrew.burgess@embecosm.com>
2935
2936         * f-typeprint.c (f_print_type): Don't return early for not
2937         associated or not allocated types.
2938         (f_type_print_varspec_suffix): Add print_rank parameter and print
2939         ranks of array types in case they dangling.
2940         (f_type_print_base): Add print_rank parameter.
2941
2942 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2943
2944         * NEWS: Mention new MI commands.
2945         * break-catch-throw.c (enum exception_event_kind): Move to
2946         breakpoint.h.
2947         (print_mention_exception_catchpoint): Output text as a single
2948         message.
2949         (catch_exception_command_1): Rename to...
2950         (catch_exception_event): ...this, make non-static, update header
2951         command, and change some parameter types.
2952         (catch_catch_command): Update for changes to
2953         catch_exception_command_1.
2954         (catch_throw_command): Likewise.
2955         (catch_rethrow_command): Likewise.
2956         * breakpoint.c (enum exception_event_kind): Delete.
2957         * breakpoint.h (enum exception_event_kind): Moved here from
2958         break-catch-throw.c.
2959         (catch_exception_event): Declare.
2960         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2961         (mi_cmd_catch_throw): New function.
2962         (mi_cmd_catch_rethrow): New function.
2963         (mi_cmd_catch_catch): New function.
2964         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2965         'catch-catch' entries.
2966         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2967         (mi_cmd_catch_rethrow): Declare.
2968         (mi_cmd_catch_catch): Declare.
2969
2970 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2971
2972         * annotate.c (annotate_source_line): Change return type to void,
2973         update implementation to match.
2974         * annotate.h (annotate_source_line): Change return type to void,
2975         update header comment.
2976         * stack.c (print_frame_info): Don't change what frame information
2977         is printed based on whether annotations are on or not.
2978
2979 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2980
2981         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2982         (annotate_source): Make static.
2983         (annotate_source_line): Moved from source.c and renamed from
2984         identify_source_line.  Update the return type.
2985         * annotate.h (annotate_source): Delete declaration.
2986         (annotate_source_line): Declaration moved from source.h, and
2987         renamed from identify_source_line.  Return type updated.
2988         * source.c (identify_source_line): Moved to annotate.c and renamed
2989         to annotate_source_line.
2990         (info_line_command): Remove check of annotation_level.
2991         * source.h (identify_source_line): Move declaration to annotate.h
2992         and rename to annotate_source_line.
2993         * stack.c: Add 'annotate.h' include.
2994         (print_frame_info): Remove check of annotation_level before
2995         calling annotate_source_line.
2996
2997 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * source-cache.c (source_cache::get_plain_source_lines): Use
3000         open_source_file_with_line_charpos instead of just
3001         open_source_file, remove call to find_source_lines.
3002         (source_cache::get_source_lines): Likewise.
3003         * source.c (find_source_lines): Make static.
3004         (get_filename_and_charpos): Renamed into...
3005         (open_source_file_with_line_charpos): ..this along with changes to
3006         return a scoped_fd, and some other minor clean ups.
3007         (identify_source_line): Use open_source_file_with_line_charpos.
3008         (search_command_helper): Use open_source_file_with_line_charpos
3009         instead of just open_source_file, remove call to
3010         find_source_lines.
3011         * source.h (open_source_file_with_line_charpos): Declare new
3012         function.
3013         (find_source_lines): Delete declaration.
3014
3015 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3016
3017         * source.c (get_filename_and_charpos): Remove fullname
3018         parameter.
3019         (identify_source_line): Update call to get_filename_and_charpos.
3020
3021 2019-06-14  Tom Tromey  <tromey@adacore.com>
3022
3023         PR gdb/24502:
3024         * ui-style.h (skip_ansi_escape): Update comment.
3025         * ui-file.h (class no_terminal_escape_file): New class.
3026         * ui-file.c (no_terminal_escape_file::write)
3027         (no_terminal_escape_file::puts): New methods.
3028         * cli/cli-logging.c (handle_redirections): Use
3029         no_terminal_escape_file.
3030
3031 2019-06-14  Tom Tromey  <tromey@adacore.com>
3032
3033         * NEWS: Move convenience variable news above Python news.
3034
3035 2019-06-14  Tom Tromey  <tom@tromey.com>
3036
3037         * gnulib: Move directory to top-level.
3038         * configure.ac: Don't configure gnulib.
3039         * configure: Rebuild.
3040         * common/common-defs.h: Use new path to gnulib.
3041         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3042         (GNULIB_H): Remove.
3043         (INCGNU): Look in new gnulib location.
3044         (HFILES_NO_SRCDIR): Remove gnulib files.
3045         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3046         (generated_files): Remove GNULIB_H.
3047         ($(LIBGNU), all-lib): Remove targets.
3048         (distclean): Don't mention GNULIB_BUILDDIR.
3049         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3050
3051 2019-06-14  Tom Tromey  <tromey@adacore.com>
3052
3053         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3054         Warn if symbol file does not provide any symbols.
3055
3056 2019-06-14  Tom Tromey  <tromey@adacore.com>
3057
3058         * source.c (find_and_open_source): Respect basenames_may_differ.
3059
3060 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3061
3062         * annotate.c (annotate_breakpoints_invalid): Make use of
3063         scoped_restore_terminal_state.
3064         (annotate_frames_invalid): Likewise.
3065
3066 2019-06-14  Tom Tromey  <tromey@adacore.com>
3067
3068         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3069         allow assignment to an internalvar.
3070
3071 2019-06-14  Tom Tromey  <tromey@adacore.com>
3072
3073         * ada-lex.l: Allow "_" in attribute names.
3074
3075 2019-06-14  Tom Tromey  <tromey@adacore.com>
3076
3077         PR gdb/24653:
3078         * regcache.c (registers_changed): Don't call alloca.
3079         * top.c (execute_command): Don't call alloca.
3080
3081 2019-06-13  Pedro Alves  <palves@redhat.com>
3082
3083         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3084         'expression'.  When parsing an expression, error out if there's
3085         junk after "unlimited".
3086         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3087         (do_set_command): Adjust calls to is_unlimited_literal.
3088
3089 2019-06-13  Pedro Alves  <palves@redhat.com>
3090
3091         * compile/compile.c (make_compile_options_def_group): Add braces
3092         around array_view initializer.
3093         * thread.c (make_thread_apply_all_options_def_group)
3094         (make_thread_apply_all_options_def_group): Likewise.
3095
3096 2019-06-13  Pedro Alves  <palves@redhat.com>
3097
3098         * NEWS (New commands): Mention "maint test-options
3099         require-delimiter", "maint test-options unknown-is-error", "maint
3100         test-options unknown-is-operand" and "maint show
3101         test-options-completion-result".
3102         (New command options, command completion): New section.
3103         (Completion improvements): New section.
3104         Mention that you can abbreviate "unlimited".
3105
3106 2019-06-13  Pedro Alves  <palves@redhat.com>
3107
3108         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3109         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3110         * unittests/cli-utils-selftests.c (test_parse_flags)
3111         (test_parse_flags_qcs): Delete.
3112         (test_cli_utils): Don't call deleted functions.
3113
3114 2019-06-13  Pedro Alves  <palves@redhat.com>
3115
3116         * thread.c: Include "cli/cli-option.h".
3117         (tp_array_compar_ascending): Global.
3118         (tp_array_compar): Delete function.
3119         (tp_array_compar_ascending, tp_array_compar_descending): New
3120         functions.
3121         (ascending_option_def, qcs_flag_option_def)
3122         (thr_qcs_flags_option_defs)
3123         (make_thread_apply_all_options_def_group)
3124         (make_thread_apply_options_def_group): New.
3125         (thread_apply_all_command): Use gdb::option::process_options.
3126         (thread_apply_command_completer)
3127         (thread_apply_all_command_completer): New.
3128         (thread_apply_command): Use gdb::option::process_options.
3129         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3130         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3131         to generate help text of "thread apply".  Adjust "taas"'s help.
3132         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3133         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3134
3135 2019-06-13  Pedro Alves  <palves@redhat.com>
3136
3137         * thread.c (thread_apply_command): Check for invalid TID with
3138         isdigit instead of !isalpha.
3139
3140 2019-06-13  Pedro Alves  <palves@redhat.com>
3141
3142         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3143         (validate_flags_qcs): New.
3144         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3145         (validate_flags_qcs): Declare.
3146         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3147         (make_frame_apply_options_def_group): New.
3148         (frame_apply_command_count): Process options with
3149         gdb::option::process_options.
3150         (frame_apply_completer): New.
3151         (frame_apply_level_completer, frame_apply_all_completer)
3152         (frame_apply_completer): New.
3153         (_initialize_stack): Update help of "frame apply", "frame apply
3154         level", "frame apply all" and "faas" to mention supported options
3155         and install command completers.
3156         * stack.h (frame_apply_all_completer): Declare.
3157         * thread.c: Include "stack.h".
3158         (tfaas_command): Add "--".
3159         (_initialize_thread): Update help "tfaas" to mention supported
3160         options and install command completer.
3161
3162 2019-06-13  Pedro Alves  <palves@redhat.com>
3163
3164         * completer.c (complete_nested_command_line): New.
3165         (gdb_completion_word_break_characters_throw): Add assertion.
3166         * completer.h (complete_nested_command_line): Declare.
3167
3168 2019-06-13  Pedro Alves  <palves@redhat.com>
3169
3170         * stack.c (parse_backtrace_qualifiers): New.
3171         (backtrace_command): Use it.
3172         (backtrace_command_completer): Complete on qualifiers.
3173
3174 2019-06-13  Pedro Alves  <palves@redhat.com>
3175
3176         * frame.c: Include "cli/cli-option.h.
3177         (user_set_backtrace_options): New.
3178         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3179         Delete.
3180         (get_prev_frame): Adjust.
3181         (boolean_option_def, uinteger_option_def)
3182         (set_backtrace_option_defs): New.
3183         (_initialize_frame): Adjust and use
3184         gdb::option::add_setshow_cmds_for_options to install "set
3185         backtrace past-main" and "set backtrace past-entry".
3186         * frame.h: Include "cli/cli-option.h".
3187         (struct frame_print_options): Forward declare.
3188         (print_frame_arguments_all, print_frame_arguments_scalars)
3189         (print_frame_arguments_none): Declare.
3190         (print_entry_values): Delete declaration.
3191         (struct frame_print_options, user_frame_print_options): New.
3192         (struct set_backtrace_options): New.
3193         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3194         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3195         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3196         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3197         (list_args_or_locals): Add frame_print_options parameter.
3198         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3199         * python/py-framefilter.c (enumerate_args): Pass down
3200         USER_FRAME_PRINT_OPTIONS.
3201         * stack.c: Include "cli/cli-option.h".
3202         (print_frame_arguments_all, print_frame_arguments_scalars)
3203         (print_frame_arguments_none): Declare.
3204         (print_raw_frame_arguments, print_entry_values): Delete.
3205         (user_frame_print_options): New.
3206         (boolean_option_def, enum_option_def, frame_print_option_defs):
3207         New.
3208         (struct backtrace_cmd_options): New.
3209         (bt_flag_option_def): New.
3210         (backtrace_command_option_defs): New.
3211         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3212         (print_frame_arg, read_frame_arg, print_frame_args)
3213         (print_frame_info, print_frame): Add frame_print_options parameter
3214         and use it.
3215         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3216         (backtrace_command_1): Add frame_print_options and
3217         backtrace_cmd_options parameters and use them.
3218         (make_backtrace_options_def_group): New.
3219         (backtrace_command): Process command options with
3220         gdb::option::process_options.
3221         (backtrace_command_completer): New.
3222         (_initialize_stack): Extend "backtrace"'s help to mention
3223         supported options.  Install completer for "backtrace".
3224         Install some settings commands with add_setshow_cmds_for_options.
3225
3226 2019-06-13  Pedro Alves  <palves@redhat.com>
3227
3228         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3229         and that "set/show print raw frame-arguments" are now deprecated.
3230
3231         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3232         command.
3233         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3234         * stack.c (_initialize_stack): Install "set/show print
3235         raw-frame-arguments", and deprecate "set/show print raw
3236         frame-arguments".
3237         * valprint.c (_initialize_valprint): Deprecate "set/show print
3238         raw".
3239
3240 2019-06-13  Pedro Alves  <palves@redhat.com>
3241
3242         * compile/compile.c (struct compile_options): New.
3243         (compile_flag_option_def, compile_command_option_defs)
3244         (make_compile_options_def_group): New.
3245         (compile_file_command): Handle options with
3246         gdb::option::process_options.
3247         (compile_file_command_completer): New function.
3248         (compile_code_command): Handle options with
3249         gdb::option::process_options.
3250         (compile_code_command_completer): New function.
3251         (_initialize_compiler): Install completers for "compile code" and
3252         "compile file".  Mention available options in "compile code" and
3253         "compile code"'s help.
3254         * completer.c (advance_to_completion_word): New, factored out from
3255         ...
3256         (advance_to_expression_complete_word_point): ... this.
3257         (advance_to_filename_complete_word_point): New.
3258         * completer.h (advance_to_filename_complete_word_point): New
3259         declaration.
3260
3261 2019-06-13  Pedro Alves  <palves@redhat.com>
3262
3263         * compile/compile.c: Include "cli/cli-option.h".
3264         (compile_print_value): Scope data pointer is now a
3265         value_print_options pointer; adjust.
3266         (compile_print_command): Process options.  Scope data pointer is
3267         now a value_print_options pointer; adjust.
3268         (_initialize_compile): Update "compile print"'s help to include
3269         supported options.  Install a completer for "compile print".
3270         * cp-valprint.c (show_vtblprint, show_objectprint)
3271         (show_static_field_print): Delete.
3272         (_initialize_cp_valprint): Don't install "set print
3273         static-members", "set print vtbl", "set print object" here.
3274         * printcmd.c: Include "cli/cli-option.h" and
3275         "common/gdb_optional.h".
3276         (print_command_parse_format): Rework to fill in a
3277         value_print_options instead of a format_data.
3278         (print_value): Change parameter type from format_data pointer to
3279         value_print_options reference.  Adjust.
3280         (print_command_1): Process options.  Adjust to pass down a
3281         value_print_options.
3282         (print_command_completer): New.
3283         (_initialize_printcmd): Install print_command_completer as
3284         handle_brkchars completer for the "print" command.  Update
3285         "print"'s help to include supported options.
3286         * valprint.c: Include "cli/cli-option.h".
3287         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3288         here from cp-valprint.c.
3289         (boolean_option_def, uinteger_option_def)
3290         (value_print_option_defs, make_value_print_options_def_group):
3291         New.  Use gdb::option::add_setshow_cmds_for_options to install
3292         "set print elements", "set print null-stop", "set print repeats",
3293         "set print pretty", "set print union", "set print array", "set
3294         print address", "set print symbol", "set print array-indexes".
3295         * valprint.h: Include <string> and "cli/cli-option.h".
3296         (make_value_print_options_def_group): Declare.
3297         (print_value): Change parameter type from format_data pointer to
3298         value_print_options reference.
3299         (print_command_completer): Declare.
3300
3301 2019-06-13  Pedro Alves  <palves@redhat.com>
3302
3303         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3304         (COMMON_SFILES): Add maint-test-settings.c.
3305         * cli/cli-decode.c (boolean_enums): New global, factored out from
3306         ...
3307         (add_setshow_boolean_cmd): ... here.
3308         * cli/cli-decode.h (boolean_enums): Declare.
3309         * cli/cli-option.c: New file.
3310         * cli/cli-option.h: New file.
3311         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3312         factored out from ...
3313         (parse_cli_boolean_value(const char *)): ... this.
3314         (is_unlimited_literal): Change parameter type to pointer to
3315         pointer.  Adjust and advance ARG pointer.
3316         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3317         (parse_cli_var_enum): New, factored out from ...
3318         (do_set_command): ... this.  Adjust.
3319         * cli/cli-setshow.h (parse_cli_boolean_value)
3320         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3321         (parse_cli_var_enum): Declare.
3322         * cli/cli-utils.c: Include "cli/cli-option.h".
3323         (get_ulongest): New.
3324         * cli/cli-utils.h (get_ulongest): Declare.
3325         (check_for_argument): New overloads.
3326         * maint-test-options.c: New file.
3327
3328 2019-06-13  Pedro Alves  <palves@redhat.com>
3329
3330         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3331         parse a range if "-" is at the end of the string.
3332
3333 2019-06-13  Pedro Alves  <palves@redhat.com>
3334
3335         * cli/cli-setshow.c (parse_auto_binary_operation)
3336         (parse_cli_boolean_value): Don't allow "o".
3337
3338 2019-06-13  Pedro Alves  <palves@redhat.com>
3339
3340         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3341         * NEWS: Mention maint test-settings KIND.
3342         * maint-test-settings.c: New file.
3343
3344 2019-06-13  Pedro Alves  <palves@redhat.com>
3345
3346         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3347         completer.
3348         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3349         "set" completers.
3350
3351 2019-06-13  Pedro Alves  <palves@redhat.com>
3352
3353         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3354         after item.
3355
3356 2019-06-13  Pedro Alves  <palves@redhat.com>
3357
3358         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3359
3360 2019-06-13  Pedro Alves <palves@redhat.com>
3361
3362         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3363         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3364         call.
3365         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3366         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3367         calls.
3368         (check_for_argument): Skip spaces after argument.
3369
3370 2019-06-13  Pedro Alves  <palves@redhat.com>
3371
3372         * thread.c (thread_apply_command): Adjust TID parsing.
3373         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3374         detected before end of string.
3375         (tid_is_in_list): Error out if LIST is invalid.
3376
3377 2019-06-13  Pedro Alves  <palves@redhat.com>
3378
3379         * completer.c (complete_line_internal_1): Rewind completion word
3380         point.
3381         (completion_tracker::advance_custom_word_point_by): Change
3382         parameter type to int.
3383         * completer.h (completion_tracker::advance_custom_word_point_by):
3384         Likewise.
3385
3386 2019-06-13  Pedro Alves  <palves@redhat.com>
3387
3388         * completer.c (advance_to_completion_word): Handle delimiters.
3389
3390 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3391
3392         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3393
3394 2019-06-11  Tom Tromey  <tom@tromey.com>
3395
3396         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3397         (xmalloc_failed): Move to alloc.c.
3398         * alloc.c: New file.
3399         * Makefile.in (COMMON_SFILES): Add alloc.c.
3400
3401 2019-06-11  Tom Tromey  <tom@tromey.com>
3402
3403         * nat/linux-waitpid.c: Don't include server.h.
3404         (linux_debug): Remove.
3405         (my_waitpid): Update.
3406
3407 2019-06-11  Tom Tromey  <tromey@adacore.com>
3408
3409         * infcall.c (_initialize_infcall): Remove trailing newline from
3410         help.
3411         * user-regs.c (_initialize_user_regs): Remove trailing newline
3412         from help.
3413         * typeprint.c (_initialize_typeprint): Remove trailing newline
3414         from help.
3415         * reverse.c (_initialize_reverse): Remove trailing newlines from
3416         help.
3417         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3418         from help.
3419         * language.c (add_set_language_command): Remove trailing newline
3420         from help.
3421         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3422         help.
3423         * disasm.c (_initialize_disasm): Remove trailing newline from
3424         help.
3425         * top.c (init_main): Remove trailing newline from help.
3426         * interps.c (_initialize_interpreter): Remove trailing newline
3427         from help.
3428         * btrace.c (_initialize_btrace): Remove trailing newlines from
3429         help.
3430         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3431         from help.
3432         * python/python.c (_initialize_python): Remove trailing newline
3433         from help.
3434         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3435         help.
3436         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3437         from help.  Reformat some text.
3438         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3439         from help.
3440         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3441         newline from help.
3442
3443 2019-06-11  Tom Tromey  <tromey@adacore.com>
3444
3445         * darwin-nat.c (darwin_decode_exception_message)
3446         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3447
3448 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3449
3450         * valops.c (value_slice): Check for not allocated or not
3451         associated values.
3452
3453 2019-06-10  Tom de Vries  <tdevries@suse.de>
3454
3455         PR gdb/24618
3456         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3457         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3458         invalid.
3459
3460 2019-06-10  Tom de Vries  <tdevries@suse.de>
3461
3462         PR gdb/24611
3463         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3464         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3465
3466 2019-06-10  Tom de Vries  <tdevries@suse.de>
3467
3468         PR symtab/24545
3469         * symtab.c (struct demangled_name_entry): Add language field.
3470         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3471         static minimal symbol".  Set and use language field.
3472
3473 2019-06-10  Tom Tromey  <tromey@adacore.com>
3474
3475         * ada-lang.c (_initialize_ada_language): Update help text.
3476
3477 2019-06-10  Tom Tromey  <tromey@adacore.com>
3478
3479         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3480         with a newline.
3481         * guile/guile.c (handle_boot_error): Don't end warning with a
3482         newline.
3483         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3484         warning with a newline.
3485         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3486         newline.
3487         (s12z_frame_cache): Likewise.
3488         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3489         a newline.
3490         * solib-svr4.c (disable_probes_interface): Don't end warning with
3491         a newline.
3492         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3493         newline.
3494         * python/python.c (do_finish_initialization): Don't end warning
3495         with a newline.
3496
3497 2019-06-10  Tom Tromey  <tom@tromey.com>
3498
3499         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3500         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3501         gdbpy_enter.
3502
3503 2019-06-10  Tom Tromey  <tromey@adacore.com>
3504
3505         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3506         data.
3507         (elf_new_init): Don't call stabsread_new_init.
3508         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3509         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3510         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3511
3512 2019-06-10  Tom de Vries  <tdevries@suse.de>
3513
3514         PR symtab/16264
3515         PR symtab/24517
3516         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3517
3518 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3519
3520         * source.c (find_and_open_source): Also rewrite relative file
3521         names.
3522
3523 2019-04-26  Amos Bird  <amosbird@gmail.com>
3524
3525         * annotate.c (annotate_thread_exited): Add "thread-exited"
3526         annotation.
3527
3528 2019-06-06  Tom Tromey  <tromey@adacore.com>
3529
3530         * maint.h (class scoped_command_stats): Use
3531         DISABLE_COPY_AND_ASSIGN.
3532         <print_time>: New method.
3533         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3534         print_time.
3535         (scoped_command_stats::print_time): New method.
3536
3537 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3540         instructions of lengths 6 or 8 bytes.
3541
3542 2019-06-04  Pedro Alves  <palves@redhat.com>
3543
3544         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3545
3546         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3547         * breakpoint.c (condition_completer): Likewise.
3548         * cli/cli-dump.c (scan_expression): Likewise.
3549         * common/filestuff.c (mkdir_recursive): Likewise.
3550         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3551         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3552         (gdb_abspath): Likewise.
3553         * compile/compile-cplus-types.c
3554         (compile_cplus_instance::decl_name): Likewise.
3555         * completer.c (complete_explicit_location):
3556         (signal_completer, reg_or_group_completer_1): Likewise.
3557         * cp-support.c (cp_remove_params_if_any): Likewise.
3558         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3559         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3560         * infcmd.c (strip_bg_char): Likewise.
3561         * linespec.c (copy_token_string): Likewise.
3562         * mi/mi-main.c (output_cores): Likewise.
3563         * psymtab.c (psymtab_search_name):
3564         * symfile.c (test_set_ext_lang_command): Likewise.
3565         * target.c (target_fileio_read_stralloc): Likewise.
3566         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3567         * value.c (complete_internalvar): Likewise.
3568
3569 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3570
3571         Add objfile property to gdb.Type.
3572         * NEWS: Mention Python API addition.
3573         * python/py-type.c (typy_get_objfile): New method.
3574
3575 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3576
3577         * NEWS: Mention the new set|show style [title|highlight].
3578         Mention changes to "show style", "help" and "apropos".
3579
3580 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3581
3582         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3583         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3584         instead of print_help_for_command.
3585         (print_doc_of_command): New function.
3586         (help_list): Add 'apropos -v word' suggestion.
3587         (print_help_for_command): Style the command name using title style.
3588         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3589         (_initialize_cli_cmds): Describe -v in apropos_command help.
3590
3591 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3592
3593         * cli/cli-style.h (cli_style_option): Add name in constructor,
3594         add m_name class member, add constructor with intensity,
3595         add name class function.
3596         (cli_style_option::add_setshow_commands): Remove name argument.
3597         (highlight_style, title_style): New styles.
3598         * cli/cli-style.c (do_show): New function that shows a style
3599         characteristic styling the style name with itself.
3600         (set_style_name): New function.
3601         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3602         Update all callers according to the changes in cli/cli-style.h.
3603         * utils.h (fputs_highlighted): New function.
3604         * utils.c (fputs_highlighted): Likewise.
3605
3606 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3607
3608         * NEWS: Mention new pipe command and new convenience variables.
3609
3610 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3611
3612         * cli/cli-cmds.c (pipe_command): New function.
3613         (_initialize_cli_cmds): Call add_com for pipe_command.
3614         Define | as an alias for pipe.
3615         (exit_status_set_internal_vars): New function.
3616         (shell_escape): Call exit_status_set_internal_vars.
3617         cli/cli-decode.c (find_command_name_length): Recognize | as
3618         a single character command.
3619
3620 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3621
3622         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3623         top.c (execute_command_to_ui_file): New function, mostly a copy
3624         of execute_command_to_string.
3625         (execute_command_to_string): Implement by calling
3626         execute_command_to_ui_file.
3627
3628 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3629
3630         * top.h (saved_command_line): Remove declaration.
3631         * top.c (previous_saved_command_line, previous_repeat_arguments):
3632         New variables.
3633         (saved_command_line): Make static, define together with other
3634         'repeat variables'.
3635         (dont_repeat): Clear repeat_arguments.
3636         (repeat_previous, get_saved_command_line, save_command_line):
3637         New functions.
3638         (gdb_init): Initialize saved_command_line
3639         and previous_saved_command_line.
3640         * main.c (captured_main_1): Remove saved_command_line initialization.
3641         * event-top.c (handle_line_of_input): Update to use
3642         the new 'repeat' related functions instead of direct access to
3643         saved_command_line.
3644         * command.h (repeat_previous, get_saved_command_line,
3645         save_command_line): New declarations.
3646         (dont_repeat): Add comment.
3647
3648 2019-05-30  Tom Tromey  <tromey@adacore.com>
3649
3650         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3651         Fix comment.
3652         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3653
3654 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3655
3656         PR cli/24587
3657         * completer.c (complete): Initialize variable word.
3658
3659 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3660
3661         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3662         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3663         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3664         'body' is NULL to the outter 'if', protecting the '!is_define'
3665         situation as well.
3666
3667 2019-05-29  Tom Tromey  <tromey@adacore.com>
3668
3669         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3670         (dwarf_unknown): New function.
3671         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3672         (dwarf_type_encoding_name): Use dwarf_unknown.
3673
3674 2019-05-29  Tom Tromey  <tromey@adacore.com>
3675
3676         PR c++/20020:
3677         * cp-valprint.c (cp_print_value_fields): Call
3678         cp_print_static_field inside "try".
3679
3680 2019-05-29  Tom Tromey  <tromey@adacore.com>
3681
3682         * inflow.c (struct terminal_info): Add default operator=.
3683         * configure: Rebuild.
3684         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3685         -Wdeprecated-copy-dtor, -Wredundant-move.
3686
3687 2019-05-29  Tom Tromey  <tromey@adacore.com>
3688
3689         * NEWS: Add entry.
3690         * infcmd.c (print_return_value_1): Handle finish_print
3691         option.
3692         (show_print_finish): New function.
3693         (_initialize_infcmd): Add "set/show print finish" commands.
3694         * valprint.c (user_print_options): Initialize new member.
3695         * valprint.h (struct value_print_options) <finish_print>: New
3696         member.
3697
3698 2019-05-28  Tom Tromey  <tromey@adacore.com>
3699
3700         * ada-lang.c (ada_remove_Xbn_suffix)
3701         (find_old_style_renaming_symbol)
3702         (parse_old_style_renaming): Remove.
3703         (ada_find_renaming_symbol): Don't call
3704         find_old_style_renaming_symbol.
3705         (ada_is_renaming_symbol): Rename from
3706         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3707         bool.  Now static.
3708         (ada_read_var_value): Update and simplify.
3709         * ada-exp.y (write_var_or_type): Remove old code.
3710
3711 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3712
3713         * event-top.c: Remove include comment.
3714         * inflow.c (class scoped_ignore_sigttou): Move from here...
3715         * inflow.h (class scoped_ignore_sigttou): ...to here.
3716         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3717         * top.c:  Remove include comment.
3718
3719 2019-05-27  Tom Tromey  <tom@tromey.com>
3720
3721         * NEWS: Fix typo.
3722
3723 2019-05-22  Tom Tromey  <tromey@adacore.com>
3724
3725         * target.c (target_follow_exec): Constify parameter.
3726         * target-delegates.c: Rebuild.
3727         * remote.c (remote_target::follow_exec): Constify parameter.
3728         * infrun.c (follow_exec): Constify parameter.
3729         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3730         (target_follow_exec): Likewise.
3731
3732 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3733
3734         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3735         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3736
3737 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3738
3739         * NEWS: Add debugredirect and testsuite sections.
3740
3741 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3742
3743         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3744         target descriptions using exclusively floating point register name
3745         aliases.
3746
3747 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3748
3749         PR gdb/18644:
3750         * f-lang.c (build_fortran_types): Handle the case where
3751         gdbarch_floatformat_for_type returns a nullptr.
3752
3753 2019-05-21  Tom de Vries  <tdevries@suse.de>
3754
3755         PR cli/24587
3756         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3757
3758 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3759
3760         PR gdb/18644:
3761         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3762         16-byte floats.
3763         * i386-tdep.c (i386_floatformat_for_type): Use
3764         floatformats_ia64_quad for the 16-byte floating point component
3765         within a fortran 32-byte complex number.
3766
3767 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3768
3769         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3770         delete default constructor.
3771         (find_partial_die): Update to return const struct.
3772         (partial_die_parent_scope): Move variable declaration into scope
3773         of its use and change its type to auto.
3774         (guess_partial_die_structure_name): Likewise.
3775         (partial_die_info::fixup): Likewise.
3776
3777 2019-05-17  Tom Tromey  <tromey@adacore.com>
3778
3779         * source.c (find_and_open_source): Remove cast.
3780
3781 2019-05-17  Tom Tromey  <tromey@adacore.com>
3782
3783         * annotate.c (annotate_source): Make "filename" const.
3784         * annotate.h (annotate_source): Use const.
3785
3786 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3787
3788         * disasm.c (set_disassembler_options): Send errors to stderr.
3789
3790 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3791
3792         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3793         (cli_interp_base::set_logging): Check debug_redirect.
3794         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3795         * cli/cli-logging.c (debug_redirect): Add static variable.
3796         (pop_output_files): Add default param.
3797         (handle_redirections): Print debug setting.
3798         (show_logging_command): Likewise.
3799         (_initialize_cli_logging): Add debugredirect command.
3800         * interps.c (current_interp_set_logging): Add debug_redirect
3801         parameter.
3802         * interps.h (set_logging): Add debug_redirect parameter.
3803         (current_interp_set_logging): Likewise.
3804         * mi/mi-common.h: Likewise.
3805         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3806
3807 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3808             Tom Tromey  <tromey@adacore.com>
3809
3810         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3811         directly.
3812         * cli/cli-interp.h (make_logging_output): Remove declaration.
3813         * cli/cli-logging.c (make_logging_output): Remove function.
3814         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3815         directly.
3816         * ui-file.c (tee_file::tee_file): Remove bools.
3817         (tee_file::~tee_file): Remove deletes.
3818         * ui-file.h (tee_file): Remove bools.
3819
3820 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3821
3822         * mi/mi-cmds.h (mi_cmd_complete): New function.
3823         * mi/mi-main.c (mi_cmd_complete): Likewise.
3824         * mi/mi-cmds.c: Define new MI command -complete.
3825         * NEWS: Mention new -complete command.
3826
3827 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3828
3829         * completer.h (complete): New function.
3830         * completer.c (complete): Likewise.
3831         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3832         function defined in completer.h.
3833
3834 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3835
3836         * MAINTAINERS (Write After Approval): Add myself.
3837
3838 2019-05-17  Tom de Vries  <tdevries@suse.de>
3839
3840         PR gdb/24094
3841         * dwarf2read.c (struct cu_partial_die_info): New struct.
3842         (find_partial_die): Return cu_partial_die_info.
3843         (partial_die_parent_scope, guess_partial_die_structure_name)
3844         (partial_die_info::fixup): Handle new return type of find_partial_die.
3845
3846 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3847
3848         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3849         "std::string", simplifying the algorithm.
3850
3851 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3852
3853         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3854         (stap_static_probe_ops::get_probes): Likewise.
3855
3856 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3857
3858         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3859         '-')" and "else if".
3860         (stap_parse_single_operand): Join checks for
3861         "gdbarch_stap_parse_special_token_p" and
3862         "gdbarch_stap_parse_special_token" in the same "if" statement.
3863         Invert check when verifying for operation on register
3864         displacement.
3865
3866 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3867
3868         * stap-probe.c (stap_get_opcode): Update comment.
3869         (stap_get_expected_argument_type): Likewise.
3870         (handle_stap_probe): Likewise.
3871
3872 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3873
3874         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3875         return type to 'bool'.  Adjust comment.  Use 'bool' when
3876         appropriate.
3877         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3878         * stap-probe.c (stap_parse_argument_1): Likewise.
3879         (stap_is_operator): Likewise.
3880         (stap_is_generic_prefix): Likewise.
3881         (stap_is_register_prefix): Likewise.
3882         (stap_is_register_indirection_prefix): Likewise.
3883         (stap_is_integer_prefix): Likewise.
3884         (stap_generic_check_suffix): Likewise.
3885         (stap_check_integer_suffix): Likewise.
3886         (stap_check_register_suffix): Likewise.
3887         (stap_check_register_indirection_suffix): Likewise.
3888         (stap_parse_register_operand): Likewise.
3889         (stap_parse_single_operand): Likewise.
3890         (stap_parse_argument_1): Likewise.
3891         (stap_probe::get_argument_count): Likewise.
3892         (stap_is_operator): Likewise.
3893
3894 2019-05-16  Tom Tromey  <tromey@adacore.com>
3895
3896         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3897         keyword to foreach.
3898
3899 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3900
3901         * linux-thread-db.c (try_thread_db_load_1): Change return type
3902         to bool.
3903         (try_thread_db_load): Likewise.
3904         (try_thread_db_load_from_pdir_1): Likewise.
3905         (try_thread_db_load_from_pdir): Likewise.
3906         (try_thread_db_load_from_sdir): Likewise.
3907         (try_thread_db_load_from_dir): Likewise.
3908         (thread_db_load_search): Likewise.
3909         (has_libpthread): Likewise.
3910         (thread_db_load): Likewise.
3911
3912 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3913
3914         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3915         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3916         NULL, and complain/return if that's the case.
3917
3918 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3919
3920         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3921         (advance, posn, abstract_read_memory): New functions.
3922         [struct mem_read_abstraction]: New struct.
3923         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3924
3925 2019-05-14  Tom Tromey  <tromey@adacore.com>
3926
3927         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3928         value is not lval_memory.
3929
3930 2019-05-14  Tom Tromey  <tromey@adacore.com>
3931
3932         * solib.c (info_sharedlibrary_command): Style the file name.
3933
3934 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3935
3936         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3937         (aarch64_vnv_type): Likewise.
3938         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3939         * common/tdesc.c: Likewise.
3940         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3941         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3942         * features/aarch64-fpu.xml: Add ieee half view.
3943         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3944         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3945         * gdbtypes.h (struct builtin_type): Likewise.
3946         (struct objfile_type): Likewise.
3947
3948 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3949
3950         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3951         typo.
3952         * location.h (string_to_event_location): Likewise.
3953
3954 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3955
3956         GDB 8.3 released.
3957
3958 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3959
3960         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3961         New variable declaration.
3962         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3963         New variable.
3964         (print_one_breakpoint): Use ui_out::test_flags and new global
3965         variable to compute use_fixed_output.
3966         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3967         Remove.
3968         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3969         (mi_multi_location_breakpoint_output_fixed): Remove.
3970         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3971         new variable.
3972         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3973         fix_multi_location_breakpoint_output flag if version >= 3.
3974         * ui-out.h (enum ui_out_flag)
3975         <fix_multi_location_breakpoint_output>: New enumerator.
3976
3977 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3978
3979         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3980
3981 2019-05-10  Tom Tromey  <tromey@adacore.com>
3982
3983         * ada-lang.c (catch_ada_completer): New function.
3984         (_initialize_ada_language): Use it.
3985
3986 2019-05-10  Tom Tromey  <tromey@adacore.com>
3987
3988         * thread.c (print_thread_info): Make "requested_threads" const.
3989         * gdbthread.h (print_thread_info): Make "requested_threads"
3990         const.
3991         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3992         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3993
3994 2019-05-08  Tom Tromey  <tom@tromey.com>
3995
3996         * gdbtypes.c (objfile_type_data): Change type.
3997         (objfile_type, _initialize_gdbtypes): Update.
3998
3999 2019-05-08  Tom Tromey  <tom@tromey.com>
4000
4001         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4002         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4003         (_initialize_dwarf2_frame): Update.
4004
4005 2019-05-08  Tom Tromey  <tom@tromey.com>
4006
4007         * objc-lang.c (objc_objfile_data): Change type.
4008         (find_methods): Update.
4009         (_initialize_objc_lang): Remove.
4010
4011 2019-05-08  Tom Tromey  <tom@tromey.com>
4012
4013         * stabsread.c (rs6000_builtin_type_data): Change type.
4014         (rs6000_builtin_type, _initialize_stabsread): Update.
4015
4016 2019-05-08  Tom Tromey  <tom@tromey.com>
4017
4018         * mips-tdep.c (mips_pdr_data): Remove.
4019         (_initialize_mips_tdep): Update.
4020
4021 2019-05-08  Tom Tromey  <tom@tromey.com>
4022
4023         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4024         (hppa_init_objfile_priv_data, read_unwind_info)
4025         (find_unwind_entry, _initialize_hppa_tdep): Update.
4026
4027 2019-05-08  Tom Tromey  <tom@tromey.com>
4028
4029         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4030         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4031         on obstack.
4032         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4033
4034 2019-05-08  Tom Tromey  <tom@tromey.com>
4035
4036         * mdebugread.c (basic_type_data): Change type.
4037         (basic_type, _initialize_mdebugread): Update.
4038
4039 2019-05-08  Tom Tromey  <tom@tromey.com>
4040
4041         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4042
4043 2019-05-08  Tom Tromey  <tom@tromey.com>
4044
4045         * nto-tdep.c (nto_inferior_data_reg): Change type.
4046         (nto_inferior_data): Update.
4047         (nto_inferior_data_cleanup, nto_new_inferior_data)
4048         (_initialize_nto_tdep): Remove.
4049         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4050
4051 2019-05-08  Tom Tromey  <tom@tromey.com>
4052
4053         * ada-lang.c (struct ada_inferior_data): Add initializers.
4054         (ada_inferior_data): Change type.
4055         (ada_inferior_data_cleanup): Remove.
4056         (get_ada_inferior_data, ada_inferior_exit)
4057         (struct ada_pspace_data): Add initializers, destructor.
4058         (ada_pspace_data_handle): Change type.
4059         (get_ada_pspace_data): Update.
4060         (ada_pspace_data_cleanup): Remove.
4061
4062 2019-05-08  Tom Tromey  <tom@tromey.com>
4063
4064         * coffread.c (struct coff_symfile_info): Add initializers.
4065         (coff_objfile_data_key): Move lower.  Change type.
4066         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4067         Update.
4068         (coff_free_info): Remove.
4069
4070 2019-05-08  Tom Tromey  <tom@tromey.com>
4071
4072         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4073         (fbsd_pspace_data_handle): Move lower.  Change type.
4074         (get_fbsd_pspace_data): Update.
4075         (fbsd_pspace_data_cleanup): Remove.
4076         (_initialize_fbsd_tdep): Update.
4077
4078 2019-05-08  Tom Tromey  <tom@tromey.com>
4079
4080         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4081         (get_ada_tasks_pspace_data): Update.
4082         (ada_tasks_pspace_data_cleanup): Remove.
4083         (_initialize_tasks): Update.
4084         (ada_tasks_inferior_data_handle): Change type.
4085         (get_ada_tasks_inferior_data): Update.
4086         (ada_tasks_inferior_data_cleanup): Remove.
4087         (struct ada_tasks_pspace_data): Add initializers.
4088
4089 2019-05-08  Tom Tromey  <tom@tromey.com>
4090
4091         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4092         * symfile-debug.c (debug_sym_get_probes): Change type.
4093         * stap-probe.c (handle_stap_probe):
4094         (stap_static_probe_ops::get_probes): Change type.
4095         * probe.h (class static_probe_ops) <get_probes>: Change type.
4096         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4097         (parse_probes_in_pspace): Update.
4098         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4099         Update.
4100         (any_static_probe_ops::get_probes): Change type.
4101         * elfread.c (elfread_data): New typedef.
4102         (probe_key): Change type.
4103         (elf_get_probes): Likewise.  Update.
4104         (probe_key_free): Remove.
4105         (_initialize_elfread): Update.
4106         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4107         Change type.
4108         (dtrace_process_dof_probe, dtrace_process_dof)
4109         (dtrace_static_probe_ops::get_probe): Change type.
4110
4111 2019-05-08  Tom Tromey  <tom@tromey.com>
4112
4113         * xcoffread.c (struct xcoff_symfile_info): Rename from
4114         coff_symfile_info.  Add initializers.
4115         (xcoff_objfile_data_key): Move lower.  Change type.
4116         (XCOFF_DATA): Rewrite.
4117         (xcoff_free_info): Remove.
4118         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4119         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4120         (xcoff_initial_scan): Update.
4121
4122 2019-05-08  Tom Tromey  <tom@tromey.com>
4123
4124         * solib-svr4.c (struct svr4_info): Add initializers and
4125         destructor.
4126         <probes_table>: Now an htab_up.
4127         (solib_svr4_pspace_data): Change type.
4128         (free_probes_table): Simplify.
4129         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4130         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4131         (probes_table_remove_objfile_probes, register_solib_event_probe)
4132         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4133         (_initialize_svr4_solib): Update.
4134
4135 2019-05-08  Tom Tromey  <tom@tromey.com>
4136
4137         * remote.c (remote_pspace_data): Change type.
4138         (remote_pspace_data_cleanup): Remove.
4139         (get_remote_exec_file, set_pspace_remote_exec_file)
4140         (_initialize_remote): Update.
4141
4142 2019-05-08  Tom Tromey  <tom@tromey.com>
4143
4144         * breakpoint.c (breakpoint_objfile_key): Change type.
4145         (get_breakpoint_objfile_data): Update.
4146         (free_breakpoint_objfile_data): Remove.
4147         (_initialize_breakpoint): Update.
4148
4149 2019-05-08  Tom Tromey  <tom@tromey.com>
4150
4151         * linux-tdep.c (struct linux_info): Add initializers.
4152         (linux_inferior_data): Move.  Change type.
4153         (invalidate_linux_cache_inf): Update.
4154         (linux_inferior_data_cleanup): Remove.
4155         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4156
4157 2019-05-08  Tom Tromey  <tom@tromey.com>
4158
4159         * auxv.c (auxv_inferior_data): Move.  Change type.
4160         (auxv_inferior_data_cleanup): Remove.
4161         (invalidate_auxv_cache_inf): Rewrite.
4162         (get_auxv_inferior_data, _initialize_auxv): Update.
4163
4164 2019-05-08  Tom Tromey  <tom@tromey.com>
4165
4166         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4167         (symfile_debug_objfile_data_key): Change type.
4168         (symfile_debug_installed, debug_qf_has_symbols)
4169         (debug_qf_find_last_source_symtab)
4170         (debug_qf_forget_cached_source_info)
4171         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4172         (debug_qf_print_stats, debug_qf_dump)
4173         (debug_qf_expand_symtabs_for_function)
4174         (debug_qf_expand_all_symtabs)
4175         (debug_qf_expand_symtabs_with_fullname)
4176         (debug_qf_map_matching_symbols)
4177         (debug_qf_expand_symtabs_matching)
4178         (debug_qf_find_pc_sect_compunit_symtab)
4179         (debug_qf_map_symbol_filenames)
4180         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4181         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4182         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4183         (debug_sym_read_linetable, debug_sym_relocate): Update.
4184         (symfile_debug_free_objfile): Remove.
4185         (install_symfile_debug_logging, _initialize_symfile_debug):
4186         Update.
4187
4188 2019-05-08  Tom Tromey  <tom@tromey.com>
4189
4190         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4191         allocate_on_obstack.
4192         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4193         (get_dwarf2_per_objfile): Update.
4194         (set_dwarf2_per_objfile): Remove.
4195         (dwarf2_has_info, dwarf2_get_section_info): Update.
4196         (dwarf2_free_objfile): Remove.
4197         (_initialize_dwarf2_read): Update.
4198
4199 2019-05-08  Tom Tromey  <tom@tromey.com>
4200
4201         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4202         initializers.
4203         <unsupported_script_warning_printed,
4204         script_not_found_warning_printed>: Now bool.
4205         (auto_load_pspace_data): Change type.
4206         (~auto_load_pspace_info): Rename from
4207         auto_load_pspace_data_cleanup.
4208         (get_auto_load_pspace_data, init_loaded_scripts_info)
4209         (clear_section_scripts, maybe_print_unsupported_script_warning)
4210         (maybe_print_script_not_found_warning, _initialize_auto_load):
4211         Update.
4212
4213 2019-05-08  Tom Tromey  <tom@tromey.com>
4214
4215         * objfiles.c (objfile_pspace_info): Add destructor and
4216         initializers.
4217         (objfiles_pspace_data): Change type.
4218         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4219         (get_objfile_pspace_data): Update.
4220         (objfiles_bfd_data): Change type.
4221         (get_objfile_bfd_data): Update.
4222         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4223
4224 2019-05-08  Tom Tromey  <tom@tromey.com>
4225
4226         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4227         Change type.
4228         (get_catch_syscall_inferior_data): Update.
4229         (catch_syscall_inferior_data_cleanup): Remove.
4230         (_initialize_break_catch_syscall): Update.
4231
4232 2019-05-08  Tom Tromey  <tom@tromey.com>
4233
4234         * inflow.c (struct terminal_info): Add destructor and
4235         initializers.
4236         (inflow_inferior_data): Change type.
4237         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4238         (get_inflow_inferior_data, inflow_inferior_exit)
4239         (swap_terminal_info, _initialize_inflow): Update.
4240
4241 2019-05-08  Tom Tromey  <tom@tromey.com>
4242
4243         * target-dcache.c (target_dcache_cleanup): Remove.
4244         (target_dcache_aspace_key): Change type.
4245         (target_dcache_init_p, target_dcache_invalidate)
4246         (target_dcache_get, target_dcache_get_or_init)
4247         (_initialize_target_dcache): Update.
4248         * dcache.h (struct dcache_deleter): New.
4249
4250 2019-05-08  Tom Tromey  <tom@tromey.com>
4251
4252         * symtab.c (struct symbol_cache): Add destructor and
4253         initializers.
4254         (symbol_cache_key): Move.  Change type.
4255         (make_symbol_cache, free_symbol_cache): Remove.
4256         (get_symbol_cache): Update.
4257         (symbol_cache_cleanup): Remove.
4258         (ALL_PSPACES, symbol_cache_flush)
4259         (maintenance_print_symbol_cache)
4260         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4261         Update.
4262
4263 2019-05-08  Tom Tromey  <tom@tromey.com>
4264
4265         * symtab.c (struct main_info): Add destructor and initializers.
4266         (main_progspace_key): Move.  Change type.
4267         (get_main_info): Update.
4268         (main_info_cleanup): Remove.
4269         (_initialize_symtab): Update.
4270
4271 2019-05-08  Tom Tromey  <tom@tromey.com>
4272
4273         * registry.h (DECLARE_REGISTRY): Define the _key class.
4274
4275 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * NEWS: Merge two 'New commands' sections.
4278
4279 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4280
4281         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4282         parameter and use Ada language definition instead.
4283         (ada_val_print_ptr): Remove unused language parameter.
4284         (ada_val_print_num): Remove language parameter and use Ada language
4285         definition instead.
4286         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4287         parameter.
4288         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4289         parameter and use Ada language definition instead.
4290         (ada_val_print_1): Update all ada_val_print_xxx calls.
4291         Remove language parameter.
4292         (ada_val_print): Update ada_val_print_1 call.
4293
4294 2019-05-08  Tom Tromey  <tromey@adacore.com>
4295
4296         * remote.c (remote_hw_watchpoint_limit)
4297         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4298         Now static.
4299
4300 2019-05-08  Tom Tromey  <tromey@adacore.com>
4301
4302         * maint.c (_initialize_maint_cmds): Move initialization code to
4303         remote.c.
4304         (watchdog, show_watchdog): Move to remote.c.
4305         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4306         "watchdog" static.
4307         (_initialize_remote): Move initialization code from maint.c.
4308         * defs.h (watchdog): Don't declare.
4309
4310 2019-05-08  Tom Tromey  <tromey@adacore.com>
4311
4312         * tui/tui-interp.c: Include main.h.
4313         * interps.c: Include main.h.
4314         * main.h (interpreter_p): Declare.
4315         * defs.h (interpreter_p): Don't declare.
4316
4317 2019-05-08  Tom Tromey  <tromey@adacore.com>
4318
4319         * dwarf2loc.c: Include dwarf2read.h.
4320         * defs.h (read_unsigned_leb128): Don't declare.
4321         * dwarf2read.h (read_unsigned_leb128): Declare.
4322
4323 2019-05-08  Tom Tromey  <tromey@adacore.com>
4324
4325         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4326         method.
4327
4328 2019-05-08  Tom Tromey  <tromey@adacore.com>
4329
4330         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4331         when no wrap column is set.
4332
4333 2019-05-08  Tom Tromey  <tromey@adacore.com>
4334
4335         * c-lang.c (c_get_string): Handle non-C-style arrays.
4336
4337 2019-05-08  Tom Tromey  <tromey@adacore.com>
4338
4339         * typeprint.c (print_offset_data::update): Print the bit offset,
4340         not the number of bits remaining.
4341
4342 2019-05-08  Tom Tromey  <tromey@adacore.com>
4343
4344         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4345         padding at end of comment.
4346
4347 2019-05-08  Tom Tromey  <tromey@adacore.com>
4348
4349         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4350         Compare main types.
4351
4352 2019-05-06  Tom Tromey  <tom@tromey.com>
4353
4354         * common/scoped_mmap.c: Include common-defs.h.
4355         * common/scoped_mmap.h: Don't include config.h.
4356
4357 2019-05-04  Tom Tromey  <tom@tromey.com>
4358
4359         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4360         (struct aarch64_call_info): Add initializers.
4361         <si>: Now a std::vector.
4362         (pass_on_stack, aarch64_push_dummy_call): Update.
4363
4364 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4365             Tom Tromey  <tom@tromey.com>
4366
4367         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4368         (ppc_threads): Now a std::vector.  Now static.
4369         (hwdebug_find_thread_points_by_tid)
4370         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4371         Update.
4372
4373 2019-05-04  Tom Tromey  <tom@tromey.com>
4374
4375         * arc-tdep.c (arc_tdesc_init): Return bool.
4376
4377 2019-05-04  Tom Tromey  <tom@tromey.com>
4378
4379         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4380         Use gdb_assert_not_reached.
4381
4382 2019-05-04  Tom Tromey  <tom@tromey.com>
4383
4384         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4385         "false".
4386
4387 2019-05-04  Tom Tromey  <tom@tromey.com>
4388
4389         * arc-tdep.c (arc_tdesc_init): Use bool.
4390
4391 2019-05-04  Tom Tromey  <tom@tromey.com>
4392
4393         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4394
4395 2019-05-04  Tom Tromey  <tom@tromey.com>
4396
4397         * cli/cli-cmds.c (valid_command_p): Return bool.
4398
4399 2019-05-04  Tom Tromey  <tom@tromey.com>
4400
4401         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4402         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4403
4404 2019-05-04  Raul Tambre  <raul@tambre.ee>
4405
4406         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4407         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4408         operator for comparison.
4409
4410 2019-05-04  Tom Tromey  <tom@tromey.com>
4411
4412         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4413         (lookup_partial_symbol, print_partial_symbols)
4414         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4415         (psymbol_compare): Update.
4416         (add_psymbol_to_bcache): Clear the entire psymbol.
4417         (maintenance_check_psymtabs): Update.
4418         * psympriv.h (struct partial_symbol): Don't derive from
4419         general_symbol_info.
4420         <obj_section, unrelocated_address, address,
4421         set_unrelocated_address>: Update.
4422         <ginfo>: New member.
4423         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4424         (debug_names::write_psymbols): Update.
4425
4426 2019-05-04  Tom de Vries  <tdevries@suse.de>
4427
4428         * contrib/cc-with-tweaks.sh: Support -n arg.
4429
4430 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4431
4432         * corelow.c (core_target::detach): Ensure frame cache and
4433         register caches are cleared.
4434         inferior.c (exit_inferior_1): Likewise.
4435
4436 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4437             Tom Tromey  <tom@tromey.com>
4438
4439         * dictionary.c (collate_pending_symbols_by_language): Remove
4440         "struct" from foreach.
4441         * symtab.c (lookup_global_symbol_from_objfile)
4442         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4443         foreach.
4444         * ser-tcp.c (net_open): Remove "struct" from foreach.
4445         * objfiles.c (objfile_relocate, objfile_rebase)
4446         (objfile_has_symbols): Remove "struct" from foreach.
4447         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4448         from foreach.
4449         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4450         foreach.
4451         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4452         "struct" from foreach.
4453         * ada-lang.c (create_excep_cond_exprs)
4454         (ada_exception_catchpoint_cond_string): Remove "struct" from
4455         foreach.
4456
4457 2019-05-03  Tom Tromey  <tromey@adacore.com>
4458
4459         * ada-exp.y (convert_char_literal): Check suffix of each
4460         enumerator.
4461
4462 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4463
4464         PR ada/21406:
4465         * ada-exp.y (yywrap): Don't define.
4466         * ada-lex.l (%option): Add noyywrap
4467         (yywrap): Remove.
4468
4469 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4470
4471         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4472         _WIN32_WINNT to the XP level, unless already defined to a higher
4473         level.
4474
4475         * unittests/parse-connection-spec-selftests.c:
4476         * ser-tcp.c:
4477         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4478         override.
4479
4480         * symfile.c (find_separate_debug_file): Remove colon from the
4481         drive spec of DOS/Windows file names of the target, so that the
4482         file name produced from DEBUGDIR and the target's directory will
4483         be valid on DOS/Windows systems.
4484
4485 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4486
4487         * rust-lang.c (val_print_struct): Handle printing structures
4488         containing strings.
4489
4490 2019-05-02  Tom Tromey  <tromey@adacore.com>
4491
4492         * valarith.c (_initialize_valarith): Remove.
4493
4494 2019-05-01  Tom Tromey  <tromey@adacore.com>
4495
4496         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4497         bitfields.
4498
4499 2019-05-01  Tom Tromey  <tromey@adacore.com>
4500
4501         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4502         for big-endian copies.
4503
4504 2019-04-30  Ali Tamur  <tamur@google.com>
4505         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4506         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4507         (read_3_bytes): New function.
4508
4509 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4510
4511         * windows-nat.c (main_thread_id): Delete.
4512         (handle_output_debug_string): Replace main_thread_id by
4513         current_event.dwThreadId.
4514         (fake_create_process): Likewise.
4515         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4516         Do not set main_thread_id.
4517         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4518         current_event.dwThreadId.
4519         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4520
4521 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4522
4523         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4524         Use current_event.dwThreadId instead of main_thread_id.
4525
4526 2019-04-30  Tom Tromey  <tromey@adacore.com>
4527
4528         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4529         (create_excep_cond_exprs): Iterate over program spaces.
4530         (ada_exception_catchpoint_cond_string): Examine all minimal
4531         symbols for exception types.
4532
4533 2019-04-30  Tom Tromey  <tromey@adacore.com>
4534
4535         PR c++/24470:
4536         * dwarf2read.c (process_structure_scope): Handle case where type
4537         has template parameters but no symbol was created.
4538
4539 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4540             Chris January  <chris.january@arm.com>
4541
4542         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4543         qualifier.
4544         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4545
4546 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4547
4548         * f-typeprint.c (f_print_type): Update rules for printing
4549         whitespace.
4550         (f_type_print_varspec_suffix): Likewise.
4551
4552 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4553             Chris January  <chris.january@arm.com>
4554
4555         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4556         function arguments.
4557
4558 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4559
4560         * f-lang.c (build_fortran_types): Change name of void type to
4561         lower case.
4562         * f-typeprint.c (f_type_print_base): Print the name of the void
4563         type, rather than a fixed string.
4564         * f-valprint.c (f_decorations): Use lower case void string.
4565
4566 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4567             Chris January  <chris.january@arm.com>
4568
4569         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4570         types for Fortran.
4571
4572 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4573             Chris January  <chris.january@arm.com>
4574             David Lecomber  <david.lecomber@arm.com>
4575
4576         * f-exp.y (BINOP_INTRINSIC): New token.
4577         (exp): New parser rule handling BINOP_INTRINSIC.
4578         (f77_keywords): Add new builtin procedures.
4579         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4580         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4581         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4582         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4583         (print_unop_subexp_f): New function.
4584         (print_binop_subexp_f): New function.
4585         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4586         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4587         (dump_subexp_body_f): Likewise.
4588         (operator_check_f): Likewise.
4589         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4590         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4591
4592 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4593
4594         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4595         UNOP_KIND.
4596         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4597         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4598         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4599         (operator_length_f): New fuction.
4600         (print_subexp_f): New function.
4601         (op_name_f): New function.
4602         (dump_subexp_body_f): New function.
4603         (operator_check_f): New function.
4604         (exp_descriptor_f): Replace standard expression handling functions
4605         with new functions.
4606         * gdb/fortran-operator.def: New file.
4607         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4608         * gdb/std-operator.def: Remove UNOP_KIND.
4609
4610 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4611
4612         * std-operator.def: Remove unbalanced, stray double quote
4613         character.
4614
4615 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4616             Chris January  <chris.january@arm.com>
4617             Daniel Everett  <daniel.everett@arm.com>
4618             Nick Forrington  <nick.forrington@arm.com>
4619             Richard Bunt  <richard.bunt@arm.com>
4620
4621         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4622         of depth when printing anonymous structs or unions.
4623         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4624         Don't print either the top-level value, or the children if the
4625         max-depth is exceeded.
4626         (ppscm_print_children): When printing the key of a map, allow one
4627         extra level of depth.
4628         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4629         print either the top-level value, or the children if the max-depth
4630         is exceeded.
4631         (print_children): When printing the key of a map, allow one extra
4632         level of depth.
4633         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4634         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4635         (user_print_options): Initialise max_depth field.
4636         (val_print_scalar_or_string_type_p): New function.
4637         (val_print): Check to see if the max depth has been reached.
4638         (val_print_check_max_depth): Define new function.
4639         (show_print_max_depth): New function.
4640         (_initialize_valprint): Add 'print max-depth' option.
4641         * valprint.h (struct value_print_options) <max_depth>: New field.
4642         (val_print_check_max_depth): Declare new function.
4643         * NEWS: Document new feature.
4644
4645 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * ada-lang.c (ada_language_defn): Initialise new field.
4648         * c-lang.c (c_is_string_type_p): New function.
4649         (c_language_defn): Initialise new field.
4650         (cplus_language_defn): Initialise new field.
4651         (asm_language_defn): Initialise new field.
4652         (minimal_language_defn): Initialise new field.
4653         * c-lang.h (c_is_string_type_p): Declare new function.
4654         * d-lang.c (d_language_defn): Initialise new field.
4655         * f-lang.c (f_is_string_type_p): New function.
4656         (f_language_defn): Initialise new field.
4657         * go-lang.c (go_is_string_type_p): New function.
4658         (go_language_defn): Initialise new field.
4659         * language.c (default_is_string_type_p): New function.
4660         (unknown_language_defn): Initialise new field.
4661         (auto_language_defn): Initialise new field.
4662         * language.h (struct language_defn) <la_is_string_type_p>: New
4663         member variable.
4664         (default_is_string_type_p): Declare new function.
4665         * m2-lang.c (m2_language_defn): Initialise new field.
4666         * objc-lang.c (objc_language_defn): Initialise new field.
4667         * opencl-lang.c (opencl_language_defn): Initialise new field.
4668         * p-lang.c (pascal_is_string_type_p): New function.
4669         (pascal_language_defn): Initialise new field.
4670         * rust-lang.c (rust_is_string_type_p): New function.
4671         (rust_language_defn): Initialise new field.
4672
4673 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4676         New field.
4677         * ada-lang.c (ada_language_defn): Initialise new field.
4678         * c-lang.c (c_language_defn): Likewise.
4679         (cplus_language_defn): Likewise.
4680         (asm_language_defn): Likewise.
4681         (minimal_language_defn): Likewise.
4682         * d-lang.c (d_language_defn): Likewise.
4683         * f-lang.c (f_language_defn): Likewise.
4684         * go-lang.c (go_language_defn): Likewise.
4685         * language.c (unknown_language_defn): Likewise.
4686         (auto_language_defn): Likewise.
4687         * m2-lang.c (m2_language_defn): Likewise.
4688         * objc-lang.c (objc_language_defn): Likewise.
4689         * opencl-lang.c (opencl_language_defn): Likewise.
4690         * p-lang.c (pascal_language_defn): Likewise.
4691         * rust-lang.c (rust_language_defn): Likewise.
4692
4693 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * ada-lang.c (ada_is_character_type): Change return type to bool.
4696         (ada_is_string_type): Likewise.
4697         * ada-lang.h (ada_is_character_type): Update declaration
4698         (ada_is_string_type): Likewise.
4699
4700 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4701
4702         Support style in 'frame|thread apply'
4703
4704         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4705         * record.c (record_start, record_stop): Update callers of
4706         execute_command_to_string with false.
4707         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4708         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4709         methods.
4710         (class string_file): New constructor with term_out parameter.
4711         Override methods term_out and can_emit_style_escape.  New member
4712         term_out.
4713         (class stdio_file): Override can_emit_style_escape.
4714         (class tee_file): Override term_out and can_emit_style_escape.
4715         * utils.h (can_emit_style_escape): Remove.
4716         * utils.c (can_emit_style_escape): Likewise.
4717         Update all callers of can_emit_style_escape (SOMESTREAM) to
4718         SOMESTREAM->can_emit_style_escape.
4719         * source-cache.c (source_cache::get_source_lines): Likewise.
4720         * stack.c (frame_apply_command_count): Call execute_command_to_string
4721         passing the term_out characteristic of the current gdb_stdout.
4722         * thread.c (thr_try_catch_cmd): Likewise.
4723         * top.c (execute_command_to_string): pass term_out parameter
4724         to construct the string_file for the command output.
4725         * ui-file.c (term_cli_styling): New function (most code moved
4726         from utils.c can_emit_style_escape).
4727         (string_file::string_file, string_file::can_emit_style_escape,
4728         stdio_file::can_emit_style_escape, tee_file::term_out,
4729         tee_file::can_emit_style_escape): New functions.
4730
4731 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4732
4733         * NEWS: Mention the new set|show may-call-functions.
4734         * infcall.c (may_call_functions_p): New variable.
4735         (show_may_call_functions_p): New function.
4736         (call_function_by_hand_dummy): Throws an error if not
4737         may-call-functions.
4738         (_initialize_infcall): Call add_setshow_boolean_cmd for
4739         may-call-functions.
4740
4741 2019-04-25  Keith Seitz  <keiths@redhat.com>
4742
4743         PR c++/24367
4744         * cp-support.c (inspect_type): Don't attempt substitutions
4745         of symbol with the same name.
4746
4747 2019-04-25  Tom Tromey  <tromey@adacore.com>
4748
4749         PR gdb/24475:
4750         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4751         static.
4752
4753 2019-04-25  Tom Tromey  <tromey@adacore.com>
4754
4755         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4756         rvalue reference.
4757         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4758         (gdb_xml_parser::parse): Use std::move.
4759         * python/python-internal.h (gdbpy_convert_exception): Take a const
4760         reference.
4761         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4762         std::move.
4763         * python/py-utils.c (gdbpy_convert_exception): Take a const
4764         reference.
4765         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4766         Use std::move.
4767         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4768         Use std::move.
4769         * mi/mi-main.c (mi_print_exception): Take a const reference.
4770         * main.c (handle_command_errors): Take a const reference.
4771         * linespec.c (parse_linespec): Use std::move.
4772         * infcall.c (run_inferior_call): Use std::move.
4773         (call_function_by_hand_dummy): Use std::move.
4774         * exec.c (try_open_exec_file): Use std::move.
4775         * exceptions.h (exception_print, exception_fprintf)
4776         (exception_print_same): Update.
4777         * exceptions.c (print_exception, exception_print)
4778         (exception_fprintf, exception_print_same): Change parameters to
4779         const reference.
4780         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4781         * common/new-op.c: Use std::move.
4782         * common/common-exceptions.h (struct gdb_exception): Add move
4783         constructor.
4784         (struct gdb_exception_error, struct gdb_exception_quit, struct
4785         gdb_quit_bad_alloc): Change constructor to move constructor.
4786         (throw_exception): Change parameter to rvalue reference.
4787         * common/common-exceptions.c (throw_exception): Take rvalue
4788         reference.
4789         * cli/cli-interp.c (safe_execute_command): Use std::move.
4790         * breakpoint.c (insert_bp_location, location_to_sals): Use
4791         std::move.
4792
4793 2019-04-25  Tom Tromey  <tromey@adacore.com>
4794
4795         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4796         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4797         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4798         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4799         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4800         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4801         guile/scm-value.c: Use unpack.
4802         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4803         gdbscm_gdb_exception.
4804         (gdbscm_throw_gdb_exception): Likewise.
4805         (struct gdbscm_gdb_exception): New.
4806         (unpack): New function.
4807         (gdbscm_wrap): Use unpack.
4808
4809 2019-04-25  Tom Tromey  <tromey@adacore.com>
4810
4811         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4812         (gdb_rl_callback_handler): Use std::move.
4813         * common/common-exceptions.h (struct gdb_exception): Add move
4814         assignment operator.
4815         (throw_exception_sjlj): Change "exception" to const reference.
4816         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4817         (throw_exception_sjlj): Change "exception" to const reference.
4818
4819 2019-04-25  Tom Tromey  <tromey@adacore.com>
4820
4821         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4822         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4823         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4824         Update.
4825         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4826         Update.
4827         * mi/mi-interp.c (mi_interp::exec): Update.
4828         * linespec.c (parse_linespec): Update.
4829         * infcall.c (run_inferior_call): Update.
4830         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4831         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4832         (gdbscm_lookup_global_symbol): Update.
4833         * guile/scm-param.c (gdbscm_parameter_value): Update.
4834         * guile/scm-frame.c (gdbscm_frame_read_register)
4835         (gdbscm_frame_read_var): Update.
4836         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4837         * exec.c (try_open_exec_file): Update.
4838         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4839         (gdb_rl_callback_handler): Update.
4840         * common/common-exceptions.h (exception_none): Don't declare.
4841         * common/common-exceptions.c (exception_none): Don't define.
4842         (struct catcher) <exception>: Update.
4843         * cli/cli-interp.c (safe_execute_command): Update.
4844         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4845
4846 2019-04-25  Ali Tamur  <tamur@google.com>
4847
4848         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4849         (read_attribute_value): Likewise.
4850         (dwarf2_read_addr_index): Update comment.
4851         (read_str_index): Add DW_FORM_strx.
4852         (dwarf2_string_attr): Likewise.
4853         (dwarf2_const_value_attr): Likewise.
4854         (dump_die_shallow): Likewise.
4855         (dwarf2_fetch_constant_bytes): Likewise.
4856         (skip_form_bytes): Likewise.
4857         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4858
4859 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4860
4861         PR corefiles/11608
4862         PR corefiles/18187
4863         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4864         OFFSET.  Verify if current mapping contains an ELF header.
4865         (linux_find_memory_regions_full): Adjust call to
4866         dump_mapping_p.
4867
4868 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4869             Kang Li <kanglictf@gmail.com>
4870
4871         PR gdb/21600
4872
4873         * dwarf2-frame.c (read_initial_length): Be consistent about using
4874         unsigned representation of length.
4875         (decode_frame_entry_1): Likewise.  Check for wraparound of
4876         end pointer as well as buffer overflow.
4877
4878 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4879
4880         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4881         "vq".
4882
4883 2019-04-24  Tom Tromey  <tromey@adacore.com>
4884
4885         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4886
4887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4888
4889         * s12z-tdep.c (s12z_unwind_pc): Delete.
4890         (s12z_unwind_sp): Delete.
4891         (s12z_gdbarch_init): Don't register deleted functions with
4892         gdbarch.
4893
4894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4895
4896         * rl78-tdep.c (rl78_unwind_sp): Delete.
4897         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4898
4899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4900
4901         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4902         (xstormy16_unwind_pc): Delete.
4903         (xstormy16_dummy_id): Delete.
4904         (xstormy16_gdbarch_init): Don't register deleted functions with
4905         gdbarch.
4906
4907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * vax-tdep.c (vax_unwind_pc): Delete.
4910         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4911
4912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4913
4914         * v850-tdep.c (v850_unwind_sp): Delete.
4915         (v850_unwind_pc): Delete.
4916         (v850_dummy_id): Delete.
4917         (v850_gdbarch_init): Don't register deleted functions with
4918         gdbarch.
4919
4920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4923         (tilegx_unwind_pc): Delete.
4924         (tilegx_unwind_dummy_id): Delete.
4925         (tilegx_gdbarch_init): Don't register deleted functions with
4926         gdbarch.
4927
4928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4929
4930         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4931         (tic6x_dummy_id): Delete.
4932         (tic6x_gdbarch_init): Don't register deleted functions with
4933         gdbarch.
4934
4935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4936
4937         * sparc-tdep.c (sparc_unwind_pc): Delete.
4938         (sparc32_gdbarch_init): Don't register deleted function with
4939         gdbarch.
4940
4941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4942
4943         * sh-tdep.c (sh_unwind_sp): Delete.
4944         (sh_unwind_pc): Delete.
4945         (sh_dummy_id): Delete.
4946         (sh_gdbarch_init): Don't register deleted functions with
4947         gdbarch.
4948
4949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4950
4951         * score-tdep.c (score_unwind_sp): Delete.
4952         (score_unwind_pc): Delete.
4953         (score_dummy_id): Delete.
4954         (score_gdbarch_init): Don't register deleted functions with
4955         gdbarch.
4956
4957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4958
4959         * rx-tdep.c (rx_unwind_pc): Delete.
4960         (rx_unwind_sp): Delete.
4961         (rx_dummy_id): Delete.
4962         (rx_gdbarch_init): Don't register deleted functions with
4963         gdbarch.  Update comment.
4964
4965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4966
4967         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4968         (rs6000_dummy_id): Delete.
4969         (rs6000_gdbarch_init): Don't register deleted functions with
4970         gdbarch.
4971
4972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * or1k-tdep.c (or1k_dummy_id): Delete.
4975         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4976
4977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4978
4979         * nios2-tdep.c (nios2_dummy_id): Delete.
4980         (nios2_unwind_sp): Delete.
4981         (nios2_gdbarch_init): Don't register deleted functions with
4982         gdbarch.
4983
4984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4985
4986         * nds32-tdep.c (nds32_dummy_id): Delete.
4987         (nds32_unwind_pc): Delete.
4988         (nds32_unwind_sp): Delete.
4989         (nds32_gdbarch_init): Don't register deleted functions with
4990         gdbarch.
4991
4992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * msp430-tdep.c (msp430_unwind_pc): Delete.
4995         (msp430_unwind_sp): Delete.
4996         (msp430_dummy_id): Delete.
4997         (msp430_gdbarch_init): Don't register deleted functions with
4998         gdbarch.
4999
5000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * moxie-tdep.c (moxie_unwind_sp): Delete.
5003         (moxie_unwind_pc): Delete.
5004         (moxie_dummy_id): Delete.
5005         (moxie_gdbarch_init): Don't register deleted functions with
5006         gdbarch.
5007
5008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5009
5010         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5011         (mn10300_unwind_pc): Delete.
5012         (mn10300_unwind_sp): Delete.
5013         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5014         mn10300_unwind_sp.
5015         (mn10300_frame_unwind_init): Don't register deleted functions with
5016         gdbarch.
5017
5018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5019
5020         * mep-tdep.c (mep_unwind_pc): Delete.
5021         (mep_unwind_sp): Delete.
5022         (mep_dummy_id): Delete.
5023         (mep_gdbarch_init): Don't register deleted functions with
5024         gdbarch.
5025
5026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5027
5028         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5029         (m68hc11_unwind_sp): Delete.
5030         (m68hc11_gdbarch_init): Don't register deleted functions with
5031         gdbarch.
5032
5033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5034
5035         * m32r-tdep.c (m32r_unwind_sp): Delete.
5036         (m32r_unwind_pc): Delete.
5037         (m32r_dummy_id): Delete.
5038         (m32r_gdbarch_init): Don't register deleted functions with
5039         gdbarch.
5040
5041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * m32c-tdep.c (m32c_unwind_pc): Delete.
5044         (m32c_unwind_sp): Delete.
5045         (m32c_dummy_id): Delete.
5046         (m32c_gdbarch_init): Don't register deleted functions with
5047         gdbarch.
5048
5049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5050
5051         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5052         (lm32_unwind_pc): Delete.
5053         (lm32_dummy_id): Delete.
5054         (lm32_gdbarch_init): Don't register deleted functions with
5055         gdbarch.
5056
5057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5058
5059         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5060         (iq2000_unwind_pc): Delete.
5061         (iq2000_dummy_id): Delete.
5062         (iq2000_gdbarch_init): Don't register deleted functions with
5063         gdbarch.
5064
5065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * nds32-tdep.c (nds32_type_align): Delete.
5068         (nds32_push_dummy_call): Use type_align instead.
5069
5070 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5071
5072         * arm-tdep.c (arm_type_align): Only handle vector override case.
5073         (arm_push_dummy_call): Use type_align.
5074         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5075
5076 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5077
5078         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5079         case.
5080         (pass_on_stack): Use type_align.
5081         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5082         function.
5083
5084 2019-04-23  Tom Tromey  <tromey@adacore.com>
5085
5086         * dwarf2read.c (line_header::file_name_at): Remove unused
5087         overload.
5088
5089 2019-04-23  Tom de Vries  <tdevries@suse.de>
5090
5091         PR gdb/24438
5092         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5093         invocation.
5094
5095
5096 2019-03-27  Ali Tamur  <tamur@google.com>
5097
5098         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5099         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5100         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5101         (dwarf_expr_context::get_addr_index): Likewise
5102         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5103         (symbol_needs_eval_context::get_addr_index): Likewise
5104         (disassemble_dwarf_expression): Add DW_OP_addrx
5105         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5106         (read_cutu_die_from_dwo): Update comment
5107         (skip_one_die): Add DW_FORM_addrx
5108         (read_attribute_value): Likewise
5109         (var_decode_location): Add DW_OP_addrx
5110         (dwarf2_const_value_attr): Add DW_FORM_addrx
5111         (dump_die_shallow): Likewise
5112         (dwarf2_fetch_constant_bytes): Likewise
5113         (decode_locdesc): Add DW_OP_addrx
5114         (skip_form_bytes): Add DW_FORM_addrx
5115
5116 2019-04-22  Ali Tamur  <tamur@google.com>
5117
5118         * MAINTAINERS (Write After Approval): Add self.
5119
5120 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5121
5122         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5123         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5124         (open_symbol_file_object): Likewise.
5125         (svr4_default_sos): Add info parameter.
5126         (svr4_read_so_list): Likewise.
5127         (svr4_current_sos_direct): Adjust functions calls to pass down
5128         info.
5129         (svr4_current_sos_1): Add info parameter.
5130         (svr4_current_sos): Call get_svr4_info, pass info down to
5131         svr4_current_sos_1.
5132         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5133         get_svr4_info.
5134         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5135         get_svr4_info.
5136         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5137         to get_svr4_info.
5138         (probes_table_remove_objfile_probes): Likewise.
5139         (register_solib_event_probe): Add info parameter.
5140         (solist_update_incremental): Pass info parameter down to
5141         svr4_read_so_list.
5142         (disable_probes_interface): Add info parameter.
5143         (svr4_handle_solib_event): Pass current_program_space to
5144         get_svr4_info.  Adjust disable_probes_interface cleanup.
5145         (svr4_create_probe_breakpoints): Add info parameter, pass it
5146         down to register_solib_event_probe.
5147         (svr4_create_solib_event_breakpoints): Add info parameter,
5148         pass it down to svr4_create_probe_breakpoints.
5149         (enable_break): Pass info down to
5150         svr4_create_solib_event_breakpoints.
5151         (svr4_solib_create_inferior_hook): Pass current_program_space to
5152         get_svr4_info.
5153         (svr4_clear_solib): Likewise.
5154
5155 2019-04-22  Pedro Alves  <palves@redhat.com>
5156
5157         * solib-svr4.c (svr4_free_objfile_observer): New.
5158         (probe_and_action::objfile): New field.
5159         (probes_table_htab_remove_objfile_probes)
5160         (probes_table_remove_objfile_probes): New functions.
5161         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5162         in the new probe_and_action.  Don't store the probe in 'lookup'.
5163         (svr4_create_probe_breakpoints): Pass objfile to
5164         register_solib_event_probe.
5165         (_initialize_svr4_solib): Register a free_objfile observer.
5166
5167 2019-04-19  Tom Tromey  <tom@tromey.com>
5168
5169         * common/queue.h: Remove.
5170
5171 2019-04-19  Tom Tromey  <tom@tromey.com>
5172
5173         * event-loop.c: Don't include "common/queue.h".
5174
5175 2019-04-19  Tom Tromey  <tom@tromey.com>
5176
5177         * remote.c (remote_target): Use delete.
5178         * remote-notif.h: Include <list>, not "common/queue.h".
5179         (notif_client_p): Remove typedef.
5180         (remote_notif_state): Add constructor, destructor, initializer.
5181         <notif_queue>: Now a std::list.
5182         (remote_notif_state_xfree): Don't declare.
5183         * remote-notif.c (remote_notif_process, handle_notification)
5184         (remote_notif_state_allocate): Update.
5185         (~remote_notif_state): Rename from remote_notif_state_xfree.
5186
5187 2019-04-19  Tom Tromey  <tom@tromey.com>
5188
5189         * symfile.c (reread_symbols): Update.
5190         * objfiles.c (objfile_register_static_link)
5191         (objfile_lookup_static_link): Update
5192         (~objfile) Don't delete static_links.
5193         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5194
5195 2019-04-19  Tom Tromey  <tom@tromey.com>
5196
5197         * type-stack.h (struct type_stack) <insert>: Constify string.
5198         * type-stack.c (type_stack::insert): Constify string.
5199         * gdbtypes.h (lookup_template_type): Update.
5200         (address_space_name_to_int): Update.
5201         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5202         const.
5203         (lookup_template_type): Make name const.
5204         * c-exp.y: Update rules.
5205         (lex_one_token, classify_name, classify_inner_name)
5206         (c_print_token): Update.
5207         * p-exp.y: Update rules.
5208         (yylex): Update.
5209         * f-exp.y: Update rules.
5210         (yylex): Update.
5211         * d-exp.y: Update rules.
5212         (lex_one_token, classify_name, classify_inner_name): Update.
5213         * parse.c (write_dollar_variable, copy_name): Return std::string.
5214         * parser-defs.h (copy_name): Change return type.
5215         * m2-exp.y: Update rules.
5216         (yylex): Update.
5217         * go-exp.y (lex_one_token): Update.
5218         Update rules.
5219         (classify_unsafe_function, classify_packaged_name)
5220         (classify_name, yylex): Update.
5221
5222 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5223
5224         * configure.ac: add --enable-source-highlight switch.
5225         * configure: Regenerate.
5226         * top.c (print_gdb_version): plumb --enable-source-highlight
5227         status to "show configuration".
5228
5229 2019-04-19  Tom Tromey  <tromey@adacore.com>
5230
5231         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5232         Check ADA_TYPE_P.
5233         (empty_record, ada_template_to_fixed_record_type_1)
5234         (template_to_static_fixed_type)
5235         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5236         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5237         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5238         macros.
5239
5240 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5241
5242         PR symtab/24423:
5243         * source.c (print_source_lines_base): Advance "iter" when a
5244         control character is seen.
5245
5246 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5247
5248         * inferior.h (struct infcall_suspend_state_deleter):
5249         Catch exception in destructor to avoid crash.
5250
5251 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5252
5253         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5254         close to the add_com "shell".
5255
5256 2019-04-18  Tom Tromey  <tromey@adacore.com>
5257
5258         * process-stratum-target.h (class process_stratum_target)
5259         <stratum>: Add "final".
5260
5261 2019-04-17  Tom Tromey  <tromey@adacore.com>
5262
5263         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5264         against nullptr before use.
5265
5266 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5267
5268         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5269
5270 2019-04-17  Jim Wilson  <jimw@sifive.com>
5271             Andrew Burgess  <andrew.burgess@embecosm.com>
5272
5273         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5274         code read might fail, assume 4-byte breakpoint in that case.
5275
5276 2019-04-15  Leszek Swirski  <leszeks@google.com>
5277
5278         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5279         rather than a hand-rolled POD check when checking for forced MEMORY
5280         classification.
5281
5282 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5283
5284         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5285         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5286         function.
5287         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5288         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5289         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5290         declaration.
5291
5292 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5293
5294         * aarch64-linux-nat.c
5295         (aarch64_linux_nat_target::thread_architecture): Add override.
5296         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5297         each VQ.
5298
5299 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5300
5301         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5302
5303 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5304
5305         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5306         target types of size 96-bits, add some additional comments, and
5307         check that the builtin type we found was the correct size.
5308
5309 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5310
5311         * utils.c (prompt_for_continue): Don't restore the styling at the
5312         end, as applied_style has the wrong value.  This fixes styling in
5313         long lists of file names that are interrupted by the "Continue?"
5314         prompt.
5315
5316 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5317
5318         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5319         * c-lang.c (c_language_defn): Likewise.
5320         (cplus_language_defn): Likewise.
5321         (asm_language_defn): Likewise.
5322         (minimal_language_defn): Likewise.
5323         * d-lang.c (d_language_defn): Likewise.
5324         * f-lang.c (f_language_defn): Likewise.
5325         * go-lang.c (go_language_defn): Likewise.
5326         * language.c (unknown_language_defn): Likewise.
5327         (auto_language_defn): Likewise.
5328         * language.h (struct language_defn): Remove la_magic field.
5329         (LANG_MAGIC): Delete.
5330         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5331         * objc-lang.c (objc_language_defn): Likewise.
5332         * opencl-lang.c (opencl_language_defn): Likewise.
5333         * p-lang.c (pascal_language_defn): Likewise.
5334         * rust-lang.c (rust_language_defn): Likewise.
5335
5336 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * riscv-tdep.c (riscv_type_align): New function.
5339         (riscv_type_alignment): Delete.
5340         (riscv_arg_location): Use 'type_align'.
5341         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5342
5343 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * gdbtypes.c (type_align): A struct with no non-static fields also
5346         has alignment of 1.
5347
5348 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5349
5350         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5351         component to 0.
5352         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5353         member.
5354         (riscv_struct_info::analyse): New implementation using new
5355         analyse_inner member function.
5356         (riscv_struct_info::field_offset): New member function.
5357         (riscv_struct_info::m_offsets): New member variable.
5358         (riscv_struct_info::analyse_inner): New private member function,
5359         takes the old implementation of riscv_struct_info::analyse but
5360         extended to track field offsets.
5361         (riscv_call_arg_struct): Update the struct folding special cases
5362         to handle cases where empty C++ structs, which are non-zero
5363         length, are found.
5364         (riscv_arg_location): Initialise the length of each location, a
5365         non-zero length now indicates the location is in use.
5366         (riscv_push_dummy_call): Allow for the first location having a
5367         non-zero offset when setting up arguments.
5368         (riscv_return_value): Likewise, but for return values.
5369
5370 2019-04-11  Tom Tromey  <tromey@adacore.com>
5371
5372         * utils.c (internal_vproblem): Make "msg" const.
5373
5374 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5375
5376         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5377         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5378         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5379         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5380
5381 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5382
5383         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5384         function.
5385         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5386         of amd64_collect_native_gregset.
5387         (amd64_linux_nat_target::store_registers): Likewise.
5388
5389 2019-04-10  Tom Tromey  <tom@tromey.com>
5390
5391         * symtab.c (lookup_global_symbol_from_objfile)
5392         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5393         * objfiles.h (class separate_debug_iterator): New.
5394         (class separate_debug_range): New.
5395         (struct objfile) <separate_debug_objfiles>: New method.
5396         (objfile_separate_debug_iterate): Don't declare.
5397         * objfiles.c (separate_debug_iterator::operator++): Rename from
5398         objfile_separate_debug_iterate.
5399         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5400         iterator.
5401         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5402         iterator.
5403
5404 2019-04-10  Tom Tromey  <tom@tromey.com>
5405
5406         * symfile.c (reread_symbols): Remove old comment.
5407         * objfiles.c (free_all_objfiles): Fix a typo.
5408
5409 2019-04-10  Tom Tromey  <tom@tromey.com>
5410
5411         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5412         * minsyms.c (lookup_minimal_symbol): Use foreach.
5413         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5414         (lookup_minimal_symbol_solib_trampoline): Likewise.
5415         * symfile.c (reread_symbols): Use foreach.
5416
5417 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5418             Tom Tromey  <tromey@adacore.com>
5419
5420         PR rust/24414:
5421         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5422         (rust_lex_int_test): Change "value" to be LONGEST.
5423         (rust_lex_tests): Add test for long integer literal.
5424
5425 2019-04-09  Tom Tromey  <tromey@adacore.com>
5426
5427         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5428         to bool.
5429         (extended_remote_target::attach): Update.
5430         (remote_target::remote_notice_new_inferior): Update.
5431         (remote_target::add_current_inferior_and_thread): Update.
5432         * inferior.c (exit_inferior_1): Use "false".
5433         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5434
5435 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5436
5437         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5438         the "start" command.
5439
5440 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5441
5442         * python/py-inferior.c (infpy_thread_from_thread_handle):
5443         Adjust comments to reflect renaming of thread_from_thread_handle
5444         to thread_from_handle.  Adjust keywords.  Fix type error message.
5445         (inferior_object_methods): Add thread_from_handle.  Retain
5446         thread_from_thread_handle, but mark it as deprecated.
5447
5448 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5449
5450         * gdbthread.h (find_thread_by_handle): Revise declaration.
5451         * thread.c (find_thread_by_handle): Likewise.  Adjust
5452         implementation too.
5453         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5454         support for buffer objects as handles.
5455
5456 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5457
5458         * python/py-infthread.c (thpy_thread_handle): New function.
5459         (thread_object_methods): Register thpy_thread_handle.
5460
5461 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5462
5463         * gdbthread.h (thread_to_thread_handle): Declare.
5464         * thread.c (gdbtypes.h): Include.
5465         (thread_to_thread_handle): New function.
5466
5467         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5468         (target_thread_info_to_thread_handle): Declare.
5469         * target.c (target_thread_info_to_thread_handle): New function.
5470         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5471         * target-delegates.c: Regenerate.
5472
5473         * linux-thread-db.c (class thread_db_target): Add method
5474         thread_info_to_thread_handle.
5475         (thread_db_target::thread_info_to_thread_handle): Define.
5476         * remote.c (class remote_target): Add new method
5477         thread_info_to_thread_handle.
5478         (remote_target::thread_info_to_thread_handle): Define.
5479
5480 2019-04-08  Pedro Alves  <palves@redhat.com>
5481
5482         * common/common-exceptions.c (throw_exception): Don't create
5483         named object to throw; throw directly.
5484         (throw_it): Likewise.  Don't initialize gdb_exception::message
5485         here, with new; pass FMT and AP to the ctor instead.
5486         * common/common-exceptions.h: Include <string>.
5487         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5488         const char *, va_list)): New ctor.  Use std::make_shared.
5489         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5490         errors)): Delete.
5491         (gdb_exception_error::gdb_exception_error(enum errors, const char
5492         *, va_list)): New.
5493         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5494         Add assertion.
5495         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5496         errors)): Delete.
5497         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5498         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5499         Add assertion.
5500
5501 2019-04-08  Tom Tromey  <tom@tromey.com>
5502
5503         * valops.c (value_rtti_indirect_type): Replace throw_exception
5504         with throw.
5505         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5506         with throw.
5507         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5508         throw.
5509         * target.c (target_translate_tls_address): Replace throw_exception
5510         with throw.
5511         * stack.c (frame_apply_command_count): Replace throw_exception
5512         with throw.
5513         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5514         throw.
5515         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5516         with throw.
5517         * rs6000-tdep.c (rs6000_frame_cache)
5518         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5519         * remote.c: Replace throw_exception with throw.
5520         * record-full.c (record_full_message, record_full_wait_1)
5521         (record_full_restore): Replace throw_exception with throw.
5522         * record-btrace.c:
5523         (get_thread_current_frame_id, record_btrace_start_replaying)
5524         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5525         (cmd_record_btrace_start): Replace throw_exception with throw.
5526         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5527         throw.
5528         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5529         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5530         * linespec.c:
5531         (find_linespec_symbols): Replace throw_exception with throw.
5532         * infrun.c (displaced_step_prepare, resume): Replace
5533         throw_exception with throw.
5534         * infcmd.c (post_create_inferior): Replace throw_exception with
5535         throw.
5536         * inf-loop.c (inferior_event_handler): Replace throw_exception
5537         with throw.
5538         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5539         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5540         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5541         (get_prev_frame_always, get_frame_pc_if_available)
5542         (get_frame_address_in_block_if_available, get_frame_language):
5543         Replace throw_exception with throw.
5544         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5545         throw_exception with throw.
5546         * eval.c (fetch_subexp_value, evaluate_var_value)
5547         (evaluate_funcall, evaluate_subexp_standard): Replace
5548         throw_exception with throw.
5549         * dwarf2loc.c (call_site_find_chain)
5550         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5551         Replace throw_exception with throw.
5552         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5553         with throw.
5554         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5555         throw.
5556         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5557         * completer.c (complete_line_internal): Replace throw_exception
5558         with throw.
5559         * compile/compile-object-run.c (compile_object_run): Replace
5560         throw_exception with throw.
5561         * cli/cli-script.c (process_next_line): Replace throw_exception
5562         with throw.
5563         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5564         (btrace_enable, btrace_maint_update_pt_packets): Replace
5565         throw_exception with throw.
5566         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5567         throw_exception with throw.
5568         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5569         throw_exception with throw.
5570         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5571         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5572         * aarch64-tdep.c (aarch64_make_prologue_cache)
5573         (aarch64_make_stub_cache): Replace throw_exception with throw.
5574
5575 2019-04-08  Tom Tromey  <tom@tromey.com>
5576
5577         * common/common-exceptions.c (throw_exception): Rename from
5578         throw_exception_cxx.  Remove old copy.  Make argument const.
5579         (throw_it): Create and throw exception objects directly.
5580         * common/common-exceptions.h (throw_exception): Make argument
5581         const.
5582         (struct gdb_exception_error): Add constructor.
5583         (struct gdb_exception_quit): Add constructor.
5584
5585 2019-04-08  Tom Tromey  <tom@tromey.com>
5586
5587         * common/common-exceptions.h (exception_rethrow): Don't declare.
5588         (TRY_SJLJ): Update comment.
5589         (TRY, CATCH, END_CATCH): Remove.
5590         * common/common-exceptions.c (exception_rethrow): Remove.
5591
5592 2019-04-08  Tom Tromey  <tom@tromey.com>
5593
5594         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5595         Remove.
5596         (gdb_exception_error): Rename from
5597         gdb_exception_RETURN_MASK_ERROR.
5598         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5599         (gdb_quit_bad_alloc): Update.
5600         * aarch64-tdep.c: Update.
5601         * ada-lang.c: Update.
5602         * ada-typeprint.c: Update.
5603         * ada-valprint.c: Update.
5604         * amd64-tdep.c: Update.
5605         * arch-utils.c: Update.
5606         * break-catch-throw.c: Update.
5607         * breakpoint.c: Update.
5608         * btrace.c: Update.
5609         * c-varobj.c: Update.
5610         * cli/cli-cmds.c: Update.
5611         * cli/cli-interp.c: Update.
5612         * cli/cli-script.c: Update.
5613         * common/common-exceptions.c: Update.
5614         * common/new-op.c: Update.
5615         * common/selftest.c: Update.
5616         * compile/compile-c-symbols.c: Update.
5617         * compile/compile-cplus-symbols.c: Update.
5618         * compile/compile-object-load.c: Update.
5619         * compile/compile-object-run.c: Update.
5620         * completer.c: Update.
5621         * corelow.c: Update.
5622         * cp-abi.c: Update.
5623         * cp-support.c: Update.
5624         * cp-valprint.c: Update.
5625         * darwin-nat.c: Update.
5626         * disasm-selftests.c: Update.
5627         * dtrace-probe.c: Update.
5628         * dwarf-index-cache.c: Update.
5629         * dwarf-index-write.c: Update.
5630         * dwarf2-frame-tailcall.c: Update.
5631         * dwarf2-frame.c: Update.
5632         * dwarf2loc.c: Update.
5633         * dwarf2read.c: Update.
5634         * eval.c: Update.
5635         * event-loop.c: Update.
5636         * event-top.c: Update.
5637         * exec.c: Update.
5638         * f-valprint.c: Update.
5639         * fbsd-tdep.c: Update.
5640         * frame-unwind.c: Update.
5641         * frame.c: Update.
5642         * gdbtypes.c: Update.
5643         * gnu-v3-abi.c: Update.
5644         * guile/guile-internal.h: Update.
5645         * guile/scm-block.c: Update.
5646         * guile/scm-breakpoint.c: Update.
5647         * guile/scm-cmd.c: Update.
5648         * guile/scm-disasm.c: Update.
5649         * guile/scm-frame.c: Update.
5650         * guile/scm-lazy-string.c: Update.
5651         * guile/scm-math.c: Update.
5652         * guile/scm-param.c: Update.
5653         * guile/scm-ports.c: Update.
5654         * guile/scm-pretty-print.c: Update.
5655         * guile/scm-symbol.c: Update.
5656         * guile/scm-symtab.c: Update.
5657         * guile/scm-type.c: Update.
5658         * guile/scm-value.c: Update.
5659         * i386-linux-tdep.c: Update.
5660         * i386-tdep.c: Update.
5661         * inf-loop.c: Update.
5662         * infcall.c: Update.
5663         * infcmd.c: Update.
5664         * infrun.c: Update.
5665         * jit.c: Update.
5666         * language.c: Update.
5667         * linespec.c: Update.
5668         * linux-fork.c: Update.
5669         * linux-nat.c: Update.
5670         * linux-tdep.c: Update.
5671         * linux-thread-db.c: Update.
5672         * main.c: Update.
5673         * mi/mi-cmd-break.c: Update.
5674         * mi/mi-cmd-stack.c: Update.
5675         * mi/mi-interp.c: Update.
5676         * mi/mi-main.c: Update.
5677         * objc-lang.c: Update.
5678         * p-valprint.c: Update.
5679         * parse.c: Update.
5680         * ppc-linux-tdep.c: Update.
5681         * printcmd.c: Update.
5682         * python/py-arch.c: Update.
5683         * python/py-breakpoint.c: Update.
5684         * python/py-cmd.c: Update.
5685         * python/py-finishbreakpoint.c: Update.
5686         * python/py-frame.c: Update.
5687         * python/py-framefilter.c: Update.
5688         * python/py-gdb-readline.c: Update.
5689         * python/py-inferior.c: Update.
5690         * python/py-infthread.c: Update.
5691         * python/py-lazy-string.c: Update.
5692         * python/py-linetable.c: Update.
5693         * python/py-objfile.c: Update.
5694         * python/py-param.c: Update.
5695         * python/py-prettyprint.c: Update.
5696         * python/py-progspace.c: Update.
5697         * python/py-record-btrace.c: Update.
5698         * python/py-record.c: Update.
5699         * python/py-symbol.c: Update.
5700         * python/py-type.c: Update.
5701         * python/py-unwind.c: Update.
5702         * python/py-utils.c: Update.
5703         * python/py-value.c: Update.
5704         * python/python.c: Update.
5705         * record-btrace.c: Update.
5706         * record-full.c: Update.
5707         * remote-fileio.c: Update.
5708         * remote.c: Update.
5709         * riscv-tdep.c: Update.
5710         * rs6000-aix-tdep.c: Update.
5711         * rs6000-tdep.c: Update.
5712         * rust-exp.y: Update.
5713         * rust-lang.c: Update.
5714         * s390-tdep.c: Update.
5715         * selftest-arch.c: Update.
5716         * solib-dsbt.c: Update.
5717         * solib-frv.c: Update.
5718         * solib-spu.c: Update.
5719         * solib-svr4.c: Update.
5720         * solib.c: Update.
5721         * sparc64-linux-tdep.c: Update.
5722         * stack.c: Update.
5723         * symfile-mem.c: Update.
5724         * symmisc.c: Update.
5725         * target.c: Update.
5726         * thread.c: Update.
5727         * top.c: Update.
5728         * tracefile-tfile.c: Update.
5729         * tui/tui.c: Update.
5730         * typeprint.c: Update.
5731         * unittests/cli-utils-selftests.c: Update.
5732         * unittests/parse-connection-spec-selftests.c: Update.
5733         * valops.c: Update.
5734         * valprint.c: Update.
5735         * value.c: Update.
5736         * varobj.c: Update.
5737         * windows-nat.c: Update.
5738         * x86-linux-nat.c: Update.
5739         * xml-support.c: Update.
5740
5741 2019-04-08  Tom Tromey  <tom@tromey.com>
5742
5743         * xml-support.c: Use C++ exception handling.
5744         * x86-linux-nat.c: Use C++ exception handling.
5745         * windows-nat.c: Use C++ exception handling.
5746         * varobj.c: Use C++ exception handling.
5747         * value.c: Use C++ exception handling.
5748         * valprint.c: Use C++ exception handling.
5749         * valops.c: Use C++ exception handling.
5750         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5751         handling.
5752         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5753         * typeprint.c: Use C++ exception handling.
5754         * tui/tui.c: Use C++ exception handling.
5755         * tracefile-tfile.c: Use C++ exception handling.
5756         * top.c: Use C++ exception handling.
5757         * thread.c: Use C++ exception handling.
5758         * target.c: Use C++ exception handling.
5759         * symmisc.c: Use C++ exception handling.
5760         * symfile-mem.c: Use C++ exception handling.
5761         * stack.c: Use C++ exception handling.
5762         * sparc64-linux-tdep.c: Use C++ exception handling.
5763         * solib.c: Use C++ exception handling.
5764         * solib-svr4.c: Use C++ exception handling.
5765         * solib-spu.c: Use C++ exception handling.
5766         * solib-frv.c: Use C++ exception handling.
5767         * solib-dsbt.c: Use C++ exception handling.
5768         * selftest-arch.c: Use C++ exception handling.
5769         * s390-tdep.c: Use C++ exception handling.
5770         * rust-lang.c: Use C++ exception handling.
5771         * rust-exp.y: Use C++ exception handling.
5772         * rs6000-tdep.c: Use C++ exception handling.
5773         * rs6000-aix-tdep.c: Use C++ exception handling.
5774         * riscv-tdep.c: Use C++ exception handling.
5775         * remote.c: Use C++ exception handling.
5776         * remote-fileio.c: Use C++ exception handling.
5777         * record-full.c: Use C++ exception handling.
5778         * record-btrace.c: Use C++ exception handling.
5779         * python/python.c: Use C++ exception handling.
5780         * python/py-value.c: Use C++ exception handling.
5781         * python/py-utils.c: Use C++ exception handling.
5782         * python/py-unwind.c: Use C++ exception handling.
5783         * python/py-type.c: Use C++ exception handling.
5784         * python/py-symbol.c: Use C++ exception handling.
5785         * python/py-record.c: Use C++ exception handling.
5786         * python/py-record-btrace.c: Use C++ exception handling.
5787         * python/py-progspace.c: Use C++ exception handling.
5788         * python/py-prettyprint.c: Use C++ exception handling.
5789         * python/py-param.c: Use C++ exception handling.
5790         * python/py-objfile.c: Use C++ exception handling.
5791         * python/py-linetable.c: Use C++ exception handling.
5792         * python/py-lazy-string.c: Use C++ exception handling.
5793         * python/py-infthread.c: Use C++ exception handling.
5794         * python/py-inferior.c: Use C++ exception handling.
5795         * python/py-gdb-readline.c: Use C++ exception handling.
5796         * python/py-framefilter.c: Use C++ exception handling.
5797         * python/py-frame.c: Use C++ exception handling.
5798         * python/py-finishbreakpoint.c: Use C++ exception handling.
5799         * python/py-cmd.c: Use C++ exception handling.
5800         * python/py-breakpoint.c: Use C++ exception handling.
5801         * python/py-arch.c: Use C++ exception handling.
5802         * printcmd.c: Use C++ exception handling.
5803         * ppc-linux-tdep.c: Use C++ exception handling.
5804         * parse.c: Use C++ exception handling.
5805         * p-valprint.c: Use C++ exception handling.
5806         * objc-lang.c: Use C++ exception handling.
5807         * mi/mi-main.c: Use C++ exception handling.
5808         * mi/mi-interp.c: Use C++ exception handling.
5809         * mi/mi-cmd-stack.c: Use C++ exception handling.
5810         * mi/mi-cmd-break.c: Use C++ exception handling.
5811         * main.c: Use C++ exception handling.
5812         * linux-thread-db.c: Use C++ exception handling.
5813         * linux-tdep.c: Use C++ exception handling.
5814         * linux-nat.c: Use C++ exception handling.
5815         * linux-fork.c: Use C++ exception handling.
5816         * linespec.c: Use C++ exception handling.
5817         * language.c: Use C++ exception handling.
5818         * jit.c: Use C++ exception handling.
5819         * infrun.c: Use C++ exception handling.
5820         * infcmd.c: Use C++ exception handling.
5821         * infcall.c: Use C++ exception handling.
5822         * inf-loop.c: Use C++ exception handling.
5823         * i386-tdep.c: Use C++ exception handling.
5824         * i386-linux-tdep.c: Use C++ exception handling.
5825         * guile/scm-value.c: Use C++ exception handling.
5826         * guile/scm-type.c: Use C++ exception handling.
5827         * guile/scm-symtab.c: Use C++ exception handling.
5828         * guile/scm-symbol.c: Use C++ exception handling.
5829         * guile/scm-pretty-print.c: Use C++ exception handling.
5830         * guile/scm-ports.c: Use C++ exception handling.
5831         * guile/scm-param.c: Use C++ exception handling.
5832         * guile/scm-math.c: Use C++ exception handling.
5833         * guile/scm-lazy-string.c: Use C++ exception handling.
5834         * guile/scm-frame.c: Use C++ exception handling.
5835         * guile/scm-disasm.c: Use C++ exception handling.
5836         * guile/scm-cmd.c: Use C++ exception handling.
5837         * guile/scm-breakpoint.c: Use C++ exception handling.
5838         * guile/scm-block.c: Use C++ exception handling.
5839         * guile/guile-internal.h: Use C++ exception handling.
5840         * gnu-v3-abi.c: Use C++ exception handling.
5841         * gdbtypes.c: Use C++ exception handling.
5842         * frame.c: Use C++ exception handling.
5843         * frame-unwind.c: Use C++ exception handling.
5844         * fbsd-tdep.c: Use C++ exception handling.
5845         * f-valprint.c: Use C++ exception handling.
5846         * exec.c: Use C++ exception handling.
5847         * event-top.c: Use C++ exception handling.
5848         * event-loop.c: Use C++ exception handling.
5849         * eval.c: Use C++ exception handling.
5850         * dwarf2read.c: Use C++ exception handling.
5851         * dwarf2loc.c: Use C++ exception handling.
5852         * dwarf2-frame.c: Use C++ exception handling.
5853         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5854         * dwarf-index-write.c: Use C++ exception handling.
5855         * dwarf-index-cache.c: Use C++ exception handling.
5856         * dtrace-probe.c: Use C++ exception handling.
5857         * disasm-selftests.c: Use C++ exception handling.
5858         * darwin-nat.c: Use C++ exception handling.
5859         * cp-valprint.c: Use C++ exception handling.
5860         * cp-support.c: Use C++ exception handling.
5861         * cp-abi.c: Use C++ exception handling.
5862         * corelow.c: Use C++ exception handling.
5863         * completer.c: Use C++ exception handling.
5864         * compile/compile-object-run.c: Use C++ exception handling.
5865         * compile/compile-object-load.c: Use C++ exception handling.
5866         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5867         * compile/compile-c-symbols.c: Use C++ exception handling.
5868         * common/selftest.c: Use C++ exception handling.
5869         * common/new-op.c: Use C++ exception handling.
5870         * cli/cli-script.c: Use C++ exception handling.
5871         * cli/cli-interp.c: Use C++ exception handling.
5872         * cli/cli-cmds.c: Use C++ exception handling.
5873         * c-varobj.c: Use C++ exception handling.
5874         * btrace.c: Use C++ exception handling.
5875         * breakpoint.c: Use C++ exception handling.
5876         * break-catch-throw.c: Use C++ exception handling.
5877         * arch-utils.c: Use C++ exception handling.
5878         * amd64-tdep.c: Use C++ exception handling.
5879         * ada-valprint.c: Use C++ exception handling.
5880         * ada-typeprint.c: Use C++ exception handling.
5881         * ada-lang.c: Use C++ exception handling.
5882         * aarch64-tdep.c: Use C++ exception handling.
5883
5884 2019-04-08  Tom Tromey  <tom@tromey.com>
5885
5886         * xml-support.c (gdb_xml_parser::parse): Update.
5887         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5888         * value.c (show_convenience): Update.
5889         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5890         (test_parse_flags_qcs): Update.
5891         * thread.c (thr_try_catch_cmd): Update.
5892         * target.c (target_translate_tls_address): Update.
5893         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5894         (info_frame_command_core, frame_apply_command_count): Update.
5895         * rust-exp.y (rust_lex_exception_test): Update.
5896         * riscv-tdep.c (riscv_print_one_register_info): Update.
5897         * remote.c (remote_target::enable_btrace): Update.
5898         * record-btrace.c (record_btrace_enable_warn): Update.
5899         * python/py-utils.c (gdbpy_convert_exception): Update.
5900         * printcmd.c (do_one_display, print_variable_and_value): Update.
5901         * mi/mi-main.c (mi_print_exception): Update.
5902         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5903         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5904         * linux-nat.c (linux_nat_target::attach): Update.
5905         * linux-fork.c (class scoped_switch_fork_info): Update.
5906         * infrun.c (displaced_step_prepare): Update.
5907         * infcall.c (call_function_by_hand_dummy): Update.
5908         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5909         * gnu-v3-abi.c (print_one_vtable): Update.
5910         * frame.c (get_prev_frame_always): Update.
5911         * f-valprint.c (info_common_command_for_block): Update.
5912         * exec.c (try_open_exec_file): Update.
5913         * exceptions.c (print_exception, exception_print)
5914         (exception_fprintf, exception_print_same): Update.
5915         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5916         * dwarf-index-cache.c (index_cache::store)
5917         (index_cache::lookup_gdb_index): Update.
5918         * darwin-nat.c (maybe_cache_shell): Update.
5919         * cp-valprint.c (cp_print_value_fields): Update.
5920         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5921         (gcc_cplus_symbol_address): Update.
5922         * compile/compile-c-symbols.c (gcc_convert_symbol)
5923         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5924         * common/selftest.c: Update.
5925         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5926         a std::string.
5927         (exception_try_scope_entry, exception_try_scope_exit): Don't
5928         declare.
5929         (struct exception_try_scope): Remove.
5930         (TRY): Don't use exception_try_scope.
5931         (struct gdb_exception): Add constructor, operator=.
5932         <what>: New method.
5933         (struct gdb_exception_RETURN_MASK_ALL)
5934         (struct gdb_exception_RETURN_MASK_ERROR)
5935         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5936         (struct gdb_quit_bad_alloc): Update.
5937         * common/common-exceptions.c (exception_none): Change
5938         initializer.
5939         (struct catcher) <state, exception>: Initialize inline.
5940         <prev>: Remove member.
5941         (current_catcher): Remove.
5942         (catchers): New global.
5943         (exceptions_state_mc_init): Simplify.
5944         (catcher_pop): Remove.
5945         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5946         (try_scope_depth, exception_try_scope_entry)
5947         (exception_try_scope_exit): Remove.
5948         (throw_exception_sjlj): Update.
5949         (exception_messages, exception_messages_size): Remove.
5950         (throw_it): Simplify.
5951         (gdb_exception_sliced_copy): Remove.
5952         (throw_exception_cxx): Update.
5953         * cli/cli-script.c (script_from_file): Update.
5954         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5955         Update.
5956         * ada-valprint.c (ada_val_print): Update.
5957         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5958         (create_excep_cond_exprs): Update.
5959
5960 2019-04-08  Tom Tromey  <tom@tromey.com>
5961
5962         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5963         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5964         (TRY, CATCH, END_CATCH): Remove some definitions.
5965         * common/common-exceptions.c: Don't use GDB_XCPT.
5966         (catcher_list_size): Remove.
5967         (throw_exception, throw_it): Simplify.
5968
5969 2019-04-05  Tom Tromey  <tom@tromey.com>
5970
5971         Revert the header-sorting patch.
5972         * ft32-tdep.c: Revert.
5973         * frv-tdep.c: Revert.
5974         * frv-linux-tdep.c: Revert.
5975         * frame.c: Revert.
5976         * frame-unwind.c: Revert.
5977         * frame-base.c: Revert.
5978         * fork-child.c: Revert.
5979         * findvar.c: Revert.
5980         * findcmd.c: Revert.
5981         * filesystem.c: Revert.
5982         * filename-seen-cache.h: Revert.
5983         * filename-seen-cache.c: Revert.
5984         * fbsd-tdep.c: Revert.
5985         * fbsd-nat.h: Revert.
5986         * fbsd-nat.c: Revert.
5987         * f-valprint.c: Revert.
5988         * f-typeprint.c: Revert.
5989         * f-lang.c: Revert.
5990         * extension.h: Revert.
5991         * extension.c: Revert.
5992         * extension-priv.h: Revert.
5993         * expprint.c: Revert.
5994         * exec.h: Revert.
5995         * exec.c: Revert.
5996         * exceptions.c: Revert.
5997         * event-top.c: Revert.
5998         * event-loop.c: Revert.
5999         * eval.c: Revert.
6000         * elfread.c: Revert.
6001         * dwarf2read.h: Revert.
6002         * dwarf2read.c: Revert.
6003         * dwarf2loc.c: Revert.
6004         * dwarf2expr.h: Revert.
6005         * dwarf2expr.c: Revert.
6006         * dwarf2-frame.c: Revert.
6007         * dwarf2-frame-tailcall.c: Revert.
6008         * dwarf-index-write.h: Revert.
6009         * dwarf-index-write.c: Revert.
6010         * dwarf-index-common.c: Revert.
6011         * dwarf-index-cache.h: Revert.
6012         * dwarf-index-cache.c: Revert.
6013         * dummy-frame.c: Revert.
6014         * dtrace-probe.c: Revert.
6015         * disasm.h: Revert.
6016         * disasm.c: Revert.
6017         * disasm-selftests.c: Revert.
6018         * dictionary.c: Revert.
6019         * dicos-tdep.c: Revert.
6020         * demangle.c: Revert.
6021         * dcache.h: Revert.
6022         * dcache.c: Revert.
6023         * darwin-nat.h: Revert.
6024         * darwin-nat.c: Revert.
6025         * darwin-nat-info.c: Revert.
6026         * d-valprint.c: Revert.
6027         * d-namespace.c: Revert.
6028         * d-lang.c: Revert.
6029         * ctf.c: Revert.
6030         * csky-tdep.c: Revert.
6031         * csky-linux-tdep.c: Revert.
6032         * cris-tdep.c: Revert.
6033         * cris-linux-tdep.c: Revert.
6034         * cp-valprint.c: Revert.
6035         * cp-support.c: Revert.
6036         * cp-namespace.c: Revert.
6037         * cp-abi.c: Revert.
6038         * corelow.c: Revert.
6039         * corefile.c: Revert.
6040         * continuations.c: Revert.
6041         * completer.h: Revert.
6042         * completer.c: Revert.
6043         * complaints.c: Revert.
6044         * coffread.c: Revert.
6045         * coff-pe-read.c: Revert.
6046         * cli-out.h: Revert.
6047         * cli-out.c: Revert.
6048         * charset.c: Revert.
6049         * c-varobj.c: Revert.
6050         * c-valprint.c: Revert.
6051         * c-typeprint.c: Revert.
6052         * c-lang.c: Revert.
6053         * buildsym.c: Revert.
6054         * buildsym-legacy.c: Revert.
6055         * build-id.h: Revert.
6056         * build-id.c: Revert.
6057         * btrace.c: Revert.
6058         * bsd-uthread.c: Revert.
6059         * breakpoint.h: Revert.
6060         * breakpoint.c: Revert.
6061         * break-catch-throw.c: Revert.
6062         * break-catch-syscall.c: Revert.
6063         * break-catch-sig.c: Revert.
6064         * blockframe.c: Revert.
6065         * block.c: Revert.
6066         * bfin-tdep.c: Revert.
6067         * bfin-linux-tdep.c: Revert.
6068         * bfd-target.c: Revert.
6069         * bcache.c: Revert.
6070         * ax-general.c: Revert.
6071         * ax-gdb.h: Revert.
6072         * ax-gdb.c: Revert.
6073         * avr-tdep.c: Revert.
6074         * auxv.c: Revert.
6075         * auto-load.c: Revert.
6076         * arm-wince-tdep.c: Revert.
6077         * arm-tdep.c: Revert.
6078         * arm-symbian-tdep.c: Revert.
6079         * arm-pikeos-tdep.c: Revert.
6080         * arm-obsd-tdep.c: Revert.
6081         * arm-nbsd-tdep.c: Revert.
6082         * arm-nbsd-nat.c: Revert.
6083         * arm-linux-tdep.c: Revert.
6084         * arm-linux-nat.c: Revert.
6085         * arm-fbsd-tdep.c: Revert.
6086         * arm-fbsd-nat.c: Revert.
6087         * arm-bsd-tdep.c: Revert.
6088         * arch-utils.c: Revert.
6089         * arc-tdep.c: Revert.
6090         * arc-newlib-tdep.c: Revert.
6091         * annotate.h: Revert.
6092         * annotate.c: Revert.
6093         * amd64-windows-tdep.c: Revert.
6094         * amd64-windows-nat.c: Revert.
6095         * amd64-tdep.c: Revert.
6096         * amd64-sol2-tdep.c: Revert.
6097         * amd64-obsd-tdep.c: Revert.
6098         * amd64-obsd-nat.c: Revert.
6099         * amd64-nbsd-tdep.c: Revert.
6100         * amd64-nbsd-nat.c: Revert.
6101         * amd64-nat.c: Revert.
6102         * amd64-linux-tdep.c: Revert.
6103         * amd64-linux-nat.c: Revert.
6104         * amd64-fbsd-tdep.c: Revert.
6105         * amd64-fbsd-nat.c: Revert.
6106         * amd64-dicos-tdep.c: Revert.
6107         * amd64-darwin-tdep.c: Revert.
6108         * amd64-bsd-nat.c: Revert.
6109         * alpha-tdep.c: Revert.
6110         * alpha-obsd-tdep.c: Revert.
6111         * alpha-nbsd-tdep.c: Revert.
6112         * alpha-mdebug-tdep.c: Revert.
6113         * alpha-linux-tdep.c: Revert.
6114         * alpha-linux-nat.c: Revert.
6115         * alpha-bsd-tdep.c: Revert.
6116         * alpha-bsd-nat.c: Revert.
6117         * aix-thread.c: Revert.
6118         * agent.c: Revert.
6119         * addrmap.c: Revert.
6120         * ada-varobj.c: Revert.
6121         * ada-valprint.c: Revert.
6122         * ada-typeprint.c: Revert.
6123         * ada-tasks.c: Revert.
6124         * ada-lang.c: Revert.
6125         * aarch64-tdep.c: Revert.
6126         * aarch64-ravenscar-thread.c: Revert.
6127         * aarch64-newlib-tdep.c: Revert.
6128         * aarch64-linux-tdep.c: Revert.
6129         * aarch64-linux-nat.c: Revert.
6130         * aarch64-fbsd-tdep.c: Revert.
6131         * aarch64-fbsd-nat.c: Revert.
6132         * aarch32-linux-nat.c: Revert.
6133
6134 2019-04-05  Tom Tromey  <tom@tromey.com>
6135
6136         * ft32-tdep.c: Sort headers.
6137         * frv-tdep.c: Sort headers.
6138         * frv-linux-tdep.c: Sort headers.
6139         * frame.c: Sort headers.
6140         * frame-unwind.c: Sort headers.
6141         * frame-base.c: Sort headers.
6142         * fork-child.c: Sort headers.
6143         * findvar.c: Sort headers.
6144         * findcmd.c: Sort headers.
6145         * filesystem.c: Sort headers.
6146         * filename-seen-cache.h: Sort headers.
6147         * filename-seen-cache.c: Sort headers.
6148         * fbsd-tdep.c: Sort headers.
6149         * fbsd-nat.h: Sort headers.
6150         * fbsd-nat.c: Sort headers.
6151         * f-valprint.c: Sort headers.
6152         * f-typeprint.c: Sort headers.
6153         * f-lang.c: Sort headers.
6154         * extension.h: Sort headers.
6155         * extension.c: Sort headers.
6156         * extension-priv.h: Sort headers.
6157         * expprint.c: Sort headers.
6158         * exec.h: Sort headers.
6159         * exec.c: Sort headers.
6160         * exceptions.c: Sort headers.
6161         * event-top.c: Sort headers.
6162         * event-loop.c: Sort headers.
6163         * eval.c: Sort headers.
6164         * elfread.c: Sort headers.
6165         * dwarf2read.h: Sort headers.
6166         * dwarf2read.c: Sort headers.
6167         * dwarf2loc.c: Sort headers.
6168         * dwarf2expr.h: Sort headers.
6169         * dwarf2expr.c: Sort headers.
6170         * dwarf2-frame.c: Sort headers.
6171         * dwarf2-frame-tailcall.c: Sort headers.
6172         * dwarf-index-write.h: Sort headers.
6173         * dwarf-index-write.c: Sort headers.
6174         * dwarf-index-common.c: Sort headers.
6175         * dwarf-index-cache.h: Sort headers.
6176         * dwarf-index-cache.c: Sort headers.
6177         * dummy-frame.c: Sort headers.
6178         * dtrace-probe.c: Sort headers.
6179         * disasm.h: Sort headers.
6180         * disasm.c: Sort headers.
6181         * disasm-selftests.c: Sort headers.
6182         * dictionary.c: Sort headers.
6183         * dicos-tdep.c: Sort headers.
6184         * demangle.c: Sort headers.
6185         * dcache.h: Sort headers.
6186         * dcache.c: Sort headers.
6187         * darwin-nat.h: Sort headers.
6188         * darwin-nat.c: Sort headers.
6189         * darwin-nat-info.c: Sort headers.
6190         * d-valprint.c: Sort headers.
6191         * d-namespace.c: Sort headers.
6192         * d-lang.c: Sort headers.
6193         * ctf.c: Sort headers.
6194         * csky-tdep.c: Sort headers.
6195         * csky-linux-tdep.c: Sort headers.
6196         * cris-tdep.c: Sort headers.
6197         * cris-linux-tdep.c: Sort headers.
6198         * cp-valprint.c: Sort headers.
6199         * cp-support.c: Sort headers.
6200         * cp-namespace.c: Sort headers.
6201         * cp-abi.c: Sort headers.
6202         * corelow.c: Sort headers.
6203         * corefile.c: Sort headers.
6204         * continuations.c: Sort headers.
6205         * completer.h: Sort headers.
6206         * completer.c: Sort headers.
6207         * complaints.c: Sort headers.
6208         * coffread.c: Sort headers.
6209         * coff-pe-read.c: Sort headers.
6210         * cli-out.h: Sort headers.
6211         * cli-out.c: Sort headers.
6212         * charset.c: Sort headers.
6213         * c-varobj.c: Sort headers.
6214         * c-valprint.c: Sort headers.
6215         * c-typeprint.c: Sort headers.
6216         * c-lang.c: Sort headers.
6217         * buildsym.c: Sort headers.
6218         * buildsym-legacy.c: Sort headers.
6219         * build-id.h: Sort headers.
6220         * build-id.c: Sort headers.
6221         * btrace.c: Sort headers.
6222         * bsd-uthread.c: Sort headers.
6223         * breakpoint.h: Sort headers.
6224         * breakpoint.c: Sort headers.
6225         * break-catch-throw.c: Sort headers.
6226         * break-catch-syscall.c: Sort headers.
6227         * break-catch-sig.c: Sort headers.
6228         * blockframe.c: Sort headers.
6229         * block.c: Sort headers.
6230         * bfin-tdep.c: Sort headers.
6231         * bfin-linux-tdep.c: Sort headers.
6232         * bfd-target.c: Sort headers.
6233         * bcache.c: Sort headers.
6234         * ax-general.c: Sort headers.
6235         * ax-gdb.h: Sort headers.
6236         * ax-gdb.c: Sort headers.
6237         * avr-tdep.c: Sort headers.
6238         * auxv.c: Sort headers.
6239         * auto-load.c: Sort headers.
6240         * arm-wince-tdep.c: Sort headers.
6241         * arm-tdep.c: Sort headers.
6242         * arm-symbian-tdep.c: Sort headers.
6243         * arm-pikeos-tdep.c: Sort headers.
6244         * arm-obsd-tdep.c: Sort headers.
6245         * arm-nbsd-tdep.c: Sort headers.
6246         * arm-nbsd-nat.c: Sort headers.
6247         * arm-linux-tdep.c: Sort headers.
6248         * arm-linux-nat.c: Sort headers.
6249         * arm-fbsd-tdep.c: Sort headers.
6250         * arm-fbsd-nat.c: Sort headers.
6251         * arm-bsd-tdep.c: Sort headers.
6252         * arch-utils.c: Sort headers.
6253         * arc-tdep.c: Sort headers.
6254         * arc-newlib-tdep.c: Sort headers.
6255         * annotate.h: Sort headers.
6256         * annotate.c: Sort headers.
6257         * amd64-windows-tdep.c: Sort headers.
6258         * amd64-windows-nat.c: Sort headers.
6259         * amd64-tdep.c: Sort headers.
6260         * amd64-sol2-tdep.c: Sort headers.
6261         * amd64-obsd-tdep.c: Sort headers.
6262         * amd64-obsd-nat.c: Sort headers.
6263         * amd64-nbsd-tdep.c: Sort headers.
6264         * amd64-nbsd-nat.c: Sort headers.
6265         * amd64-nat.c: Sort headers.
6266         * amd64-linux-tdep.c: Sort headers.
6267         * amd64-linux-nat.c: Sort headers.
6268         * amd64-fbsd-tdep.c: Sort headers.
6269         * amd64-fbsd-nat.c: Sort headers.
6270         * amd64-dicos-tdep.c: Sort headers.
6271         * amd64-darwin-tdep.c: Sort headers.
6272         * amd64-bsd-nat.c: Sort headers.
6273         * alpha-tdep.c: Sort headers.
6274         * alpha-obsd-tdep.c: Sort headers.
6275         * alpha-nbsd-tdep.c: Sort headers.
6276         * alpha-mdebug-tdep.c: Sort headers.
6277         * alpha-linux-tdep.c: Sort headers.
6278         * alpha-linux-nat.c: Sort headers.
6279         * alpha-bsd-tdep.c: Sort headers.
6280         * alpha-bsd-nat.c: Sort headers.
6281         * aix-thread.c: Sort headers.
6282         * agent.c: Sort headers.
6283         * addrmap.c: Sort headers.
6284         * ada-varobj.c: Sort headers.
6285         * ada-valprint.c: Sort headers.
6286         * ada-typeprint.c: Sort headers.
6287         * ada-tasks.c: Sort headers.
6288         * ada-lang.c: Sort headers.
6289         * aarch64-tdep.c: Sort headers.
6290         * aarch64-ravenscar-thread.c: Sort headers.
6291         * aarch64-newlib-tdep.c: Sort headers.
6292         * aarch64-linux-tdep.c: Sort headers.
6293         * aarch64-linux-nat.c: Sort headers.
6294         * aarch64-fbsd-tdep.c: Sort headers.
6295         * aarch64-fbsd-nat.c: Sort headers.
6296         * aarch32-linux-nat.c: Sort headers.
6297
6298 2019-04-04  Tom Tromey  <tom@tromey.com>
6299
6300         * varobj.c (varobj_create): Update.
6301         * rust-exp.y (struct rust_parser) <update_innermost_block,
6302         lookup_symbol>: New methods.
6303         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6304         Rename.
6305         (rust_parser::rust_lookup_type)
6306         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6307         * printcmd.c (display_command, do_one_display): Update.
6308         * parser-defs.h (struct parser_state) <parser_state>: Add
6309         "tracker" parameter.
6310         (block_tracker): New member.
6311         (class innermost_block_tracker) <innermost_block_tracker>: Add
6312         "types" parameter.
6313         <reset>: Remove method.
6314         (innermost_block): Don't declare.
6315         (null_post_parser): Update.
6316         * parse.c (innermost_block): Remove global.
6317         (write_dollar_variable): Update.
6318         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6319         Remove "tracker_types" parameter.
6320         (parse_expression): Add "tracker" parameter.
6321         (parse_expression_for_completion): Update.
6322         (null_post_parser): Add "tracker" parameter.
6323         * p-exp.y: Update rules.
6324         * m2-exp.y: Update rules.
6325         * language.h (struct language_defn) <la_post_parser>: Add
6326         "tracker" parameter.
6327         * go-exp.y: Update rules.
6328         * f-exp.y: Update rules.
6329         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6330         parameter.
6331         * d-exp.y: Update rules.
6332         * c-exp.y: Update rules.
6333         * breakpoint.c (set_breakpoint_condition): Create an
6334         innermost_block_tracker.
6335         (watch_command_1): Likewise.
6336         * ada-lang.c (resolve): Add "tracker" parameter.
6337         (resolve_subexp): Likewise.
6338         * ada-exp.y (write_var_from_sym): Update.
6339
6340 2019-04-04  Tom Tromey  <tom@tromey.com>
6341
6342         * type-stack.h: New file.
6343         * type-stack.c: New file.
6344         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6345         type-stack.h.
6346         (insert_into_type_stack, insert_type, push_type, push_type_int)
6347         (insert_type_address_space, pop_type, pop_type_int)
6348         (pop_typelist, pop_type_stack, append_type_stack)
6349         (push_type_stack, get_type_stack, push_typelist)
6350         (follow_type_instance_flags, follow_types): Don't declare.
6351         * parse.c (type_stack): Remove global.
6352         (parse_exp_in_context): Update.
6353         (insert_into_type_stack, insert_type, push_type, push_type_int)
6354         (insert_type_address_space, pop_type, pop_type_int)
6355         (pop_typelist, pop_type_stack, append_type_stack)
6356         (push_type_stack, get_type_stack, push_typelist)
6357         (follow_type_instance_flags, follow_types): Remove (moved to
6358         type-stack.c).
6359         * f-exp.y (type_stack): New global.
6360         Update rules.
6361         (push_kind_type, f_parse): Update.
6362         * d-exp.y (type_stack): New global.
6363         Update rules.
6364         (d_parse): Update.
6365         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6366         Update rules.
6367         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6368         (HFILES_NO_SRCDIR): Add type-stack.h.
6369
6370 2019-04-04  Tom Tromey  <tom@tromey.com>
6371
6372         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6373         (rust_parser::convert_ast_to_expression, rust_parse)
6374         (rust_lex_test_completion, rust_lex_tests): Update.
6375         * parser-defs.h (struct expr_completion_state): New.
6376         (struct parser_state) <parser_state>: Add completion parameter.
6377         <mark_struct_expression, mark_completion_tag>: New methods.
6378         <parse_completion, m_completion_state>: New members.
6379         (prefixify_expression, null_post_parser): Update.
6380         (mark_struct_expression, mark_completion_tag): Don't declare.
6381         * parse.c (parse_completion, expout_last_struct)
6382         (expout_tag_completion_type, expout_completion_name): Remove
6383         globals.
6384         (parser_state::mark_struct_expression)
6385         (parser_state::mark_completion_tag): Now methods.
6386         (prefixify_expression): Add last_struct parameter.
6387         (prefixify_subexp): Likewise.
6388         (parse_exp_1): Update.
6389         (parse_exp_in_context): Add cstate parameter.  Update.
6390         (parse_expression_for_completion): Create an
6391         expr_completion_state.
6392         (null_post_parser): Add "completion" parameter.
6393         * p-exp.y: Update rules.
6394         (yylex): Update.
6395         * language.h (struct language_defn) <la_post_parser>: Add
6396         "completing" parameter.
6397         * go-exp.y: Update rules.
6398         (lex_one_token): Update.
6399         * expression.h (parse_completion): Don't declare.
6400         * d-exp.y: Update rules.
6401         (lex_one_token): Update rules.
6402         * c-exp.y: Update rules.
6403         (lex_one_token): Update.
6404         * ada-lang.c (resolve): Add "parse_completion" parameter.
6405         (resolve_subexp): Likewise.
6406         (ada_resolve_function): Likewise.
6407
6408 2019-04-04  Tom Tromey  <tom@tromey.com>
6409
6410         * parser-defs.h (struct parser_state) <start_arglist,
6411         end_arglist>: New methods.
6412         <arglist_len, m_funcall_chain>: New members.
6413         (arglist_len, start_arglist, end_arglist): Don't declare.
6414         * parse.c (arglist_len, funcall_chain): Remove global.
6415         (start_arglist, end_arglist): Remove functions.
6416         (parse_exp_in_context): Update.
6417         * p-exp.y: Update rules.
6418         * m2-exp.y: Update rules.
6419         * go-exp.y: Update rules.
6420         * f-exp.y: Update rules.
6421         * d-exp.y: Update rules.
6422         * c-exp.y: Update rules.
6423
6424 2019-04-04  Tom Tromey  <tom@tromey.com>
6425
6426         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6427         lex_operator, push_back>: New methods.
6428         Update all rules.
6429         (rust_parser::lex_hex, lex_escape): Rename and update.
6430         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6431         (rust_parser::lex_operator): Rename and update.
6432         (rust_parser::lex_number, rustyylex, rustyyerror)
6433         (rust_lex_test_init, rust_lex_test_sequence)
6434         (rust_lex_test_push_back, rust_lex_tests): Update.
6435         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6436         parameter.
6437         <lexptr, prev_lexptr>: New members.
6438         (lexptr, prev_lexptr): Don't declare.
6439         * parse.c (lexptr, prev_lexptr): Remove globals.
6440         (parse_exp_in_context): Update.
6441         * p-exp.y (yylex, yyerror): Update.
6442         * m2-exp.y (parse_number, yylex, yyerror): Update.
6443         * go-exp.y (lex_one_token, yyerror): Update.
6444         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6445         * d-exp.y (lex_one_token, yyerror): Update.
6446         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6447         (lex_one_token, yyerror): Update.
6448         * ada-lex.l (YY_INPUT): Update.
6449         (rewind_to_char): Update.
6450         * ada-exp.y (yyerror): Update.
6451
6452 2019-04-04  Tom Tromey  <tom@tromey.com>
6453
6454         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6455         * parser-defs.h (struct parser_state) <parser_state>: Add new
6456         parameter.
6457         <comma_terminates>: New member.
6458         (comma_terminates): Don't declare global.
6459         * parse.c (comma_terminates): Remove global.
6460         (parse_exp_in_context): Update.
6461         * p-exp.y (yylex): Update.
6462         * m2-exp.y (yylex): Update.
6463         * go-exp.y (lex_one_token): Update.
6464         * f-exp.y (yylex): Update.
6465         * d-exp.y (lex_one_token): Update.
6466         * c-exp.y (lex_one_token): Update.
6467         * ada-lex.l: Update.
6468
6469 2019-04-04  Tom Tromey  <tom@tromey.com>
6470
6471         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6472         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6473         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6474         * parser-defs.h (paren_depth): Don't declare.
6475         * parse.c (paren_depth): Remove global.
6476         (parse_exp_in_context): Update.
6477         * p-exp.y (paren_depth): New global.
6478         (pascal_parse): Initialize it.
6479         * m2-exp.y (paren_depth): New global.
6480         (m2_parse): Initialize it.
6481         * go-exp.y (paren_depth): New global.
6482         (go_parse): Initialize it.
6483         * f-exp.y (paren_depth): New global.
6484         (f_parse): Initialize it.
6485         * d-exp.y (paren_depth): New global.
6486         (d_parse): Initialize it.
6487         * c-exp.y (paren_depth): New global.
6488         (c_parse): Initialize it.
6489         * ada-lex.l (paren_depth): New global.
6490         (lexer_init): Initialize it.
6491
6492 2019-04-04  Tom Tromey  <tom@tromey.com>
6493
6494         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6495         (rust_parser::convert_ast_to_type)
6496         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6497         * parser-defs.h (struct parser_state) <parser_state>: Add
6498         parameters.  Initialize new members.
6499         <expression_context_block, expression_context_pc>: New members.
6500         * parse.c (expression_context_block, expression_context_pc):
6501         Remove globals.
6502         (parse_exp_in_context): Update.
6503         * p-exp.y: Update all rules.
6504         (yylex): Update.
6505         * m2-exp.y: Update all rules.
6506         (yylex): Update.
6507         * go-exp.y (yylex): Update.
6508         * f-exp.y (yylex): Update.
6509         * d-exp.y: Update all rules.
6510         (yylex): Update.
6511         * c-exp.y: Update all rules.
6512         (lex_one_token, classify_name, yylex, c_parse): Update.
6513         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6514
6515 2019-04-04  Tom Tromey  <tom@tromey.com>
6516
6517         * gdbarch.h, gdbarch.c: Rebuild.
6518         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6519         * stap-probe.h:
6520         (struct stap_parse_info): Replace "parser_state" with
6521         "expr_builder".
6522         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6523         (parser_state): New class.
6524         * parse.c (expr_builder): Rename.
6525         (expr_builder::release): Rename.
6526         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6527         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6528         (write_exp_elt_longcst, write_exp_elt_floatcst)
6529         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6530         (write_exp_string_vector, write_exp_bitstring)
6531         (write_exp_msymbol, mark_struct_expression)
6532         (write_dollar_variable)
6533         (insert_type_address_space, increase_expout_size): Replace
6534         "parser_state" with "expr_builder".
6535         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6536         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6537         "parser_state" with "expr_builder".
6538
6539 2019-04-04  Tom Tromey  <tom@tromey.com>
6540
6541         * rust-exp.y: Replace "parse_language" with method call.
6542         * p-exp.y:
6543         (yylex): Replace "parse_language" with method call.
6544         * m2-exp.y:
6545         (yylex): Replace "parse_language" with method call.
6546         * go-exp.y (classify_name): Replace "parse_language" with method
6547         call.
6548         * f-exp.y (yylex): Replace "parse_language" with method call.
6549         * d-exp.y (lex_one_token): Replace "parse_language" with method
6550         call.
6551         * c-exp.y:
6552         (lex_one_token, classify_name, yylex): Replace "parse_language"
6553         with method call.
6554         * ada-exp.y (find_primitive_type, type_char)
6555         (type_system_address): Replace "parse_language" with method call.
6556
6557 2019-04-04  Tom Tromey  <tom@tromey.com>
6558
6559         * rust-exp.y: Replace "parse_gdbarch" with method call.
6560         * parse.c (write_dollar_variable, insert_type_address_space):
6561         Replace "parse_gdbarch" with method call.
6562         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6563         call.
6564         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6565         call.
6566         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6567         "parse_gdbarch" with method call.
6568         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6569         with method call.
6570         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6571         "parse_gdbarch" with method call.
6572         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6573         "parse_gdbarch" with method call.
6574         * c-exp.y (parse_type, parse_number, classify_name): Replace
6575         "parse_gdbarch" with method call.
6576         * ada-lex.l: Replace "parse_gdbarch" with method call.
6577         * ada-exp.y (parse_type, find_primitive_type, type_char)
6578         (type_system_address): Replace "parse_gdbarch" with method call.
6579
6580 2019-04-04  Tom Tromey  <tom@tromey.com>
6581
6582         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6583         * stap-probe.c (stap_parse_argument): Update.
6584         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6585         initial_size parameter.
6586         * rust-exp.y (rust_lex_tests): Update.
6587         * parse.c (parser_state): Update.
6588         (parse_exp_in_context): Update.
6589         * parser-defs.h (struct parser_state) <parser_state>: Remove
6590         "initial_size" parameter.
6591
6592 2019-04-04  Tom Tromey  <tom@tromey.com>
6593
6594         * parser-defs.h (increase_expout_size): Don't declare.
6595         * parse.c (increase_expout_size): Now static.
6596
6597 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6598
6599         * gnu-nat.c (gnu_nat_target::wait): Fix
6600         target_waitstatus_to_string call.
6601
6602 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6603
6604         * eval.c (evaluate_subexp_standard): Handle internal functions
6605         during Fortran function call handling.
6606
6607 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6608
6609         * NEWS: Mention new internal functions.
6610         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6611         (read_base_type): Use dwarf2_init_complex_target_type.
6612         * value.c (creal_internal_fn): New function.
6613         (cimag_internal_fn): New function.
6614         (_initialize_values): Register new internal functions.
6615
6616 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6617
6618         * infrun.c (stop_all_threads): If debug_infrun, always
6619         trace the wait status after wait_one, using
6620         target_waitstatus_to_string and target_pid_to_str.
6621         (handle_inferior_event): Replace various trace of
6622         wait status kind by a single trace.
6623         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6624         wait status kind image by target_waitstatus_to_string.
6625         * target/waitstatus.c (target_waitstatus_to_string): Fix
6626         obsolete comment.
6627
6628 2019-04-01  Tom Tromey  <tromey@adacore.com>
6629
6630         PR symtab/23331:
6631         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6632
6633 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6634             Pedro Alves  <palves@redhat.com>
6635
6636         * top.c (quit_force): Call 'finalize_values'.
6637         * value.c (finalize_values): New function.
6638         * value.h (finalize_values): Declare.
6639
6640 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6641
6642         * NEWS: Announce $_gdb_major and $_gdb_minor.
6643
6644         * top.c (init_gdb_version_vars): New function.
6645         (gdb_init): Call init_gdb_version_vars.
6646
6647 2019-03-29  Tom Tromey  <tromey@adacore.com>
6648
6649         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6650         help text.  Remove dead code.
6651
6652 2019-03-29  Keith Seitz  <keiths@redhat.com>
6653
6654         From Siddhesh Poyarekar:
6655         * f-lang.h (f77_get_upperbound): Return LONGEST.
6656         (f77_get_lowerbound): Likewise.
6657         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6658         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6659         print them.
6660         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6661         plongest to format print it.
6662         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6663         (f77_get_upperbound): Likewise.
6664         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6665         LOWER_BOUND to LONGEST.
6666         (f77_create_arrayprint_offset_tbl): Likewise.
6667
6668 2019-03-29  Keith Seitz  <keiths@redhat.com>
6669
6670         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6671         %s/pulongest for TYPE_LENGTH instead of %d in format
6672         strings.
6673         * ada-typerint.c (ada_print_type): Likewise.
6674         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6675         * compile/compile-c-support.c (generate_register_struct): Likewise.
6676         * gdbtypes.c (recursive_dump_type): Likewise.
6677         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6678         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6679         instead of %d in format strings.
6680         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6681         to std::min to ULONGEST.
6682         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6683         instead of %d in format strings.
6684         * tracepoint.c (info_scope_command): Likewise.
6685         * typeprint.c (print_offset_data::update)
6686         (print_offset_data::finish): Likewise.
6687         * xtensa-tdep.c (xtensa_store_return_value)
6688         (xtensa_push_dummy_call): Likewise.
6689
6690 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6691
6692         * windows-nat.c (display_selector): Fixed format specifications
6693         for 64-bit Cygwin.
6694
6695 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6696
6697         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6698
6699 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6700
6701         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6702         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6703         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6704         (nios2_linux_init_abi): Install it.
6705
6706 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6707
6708         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6709
6710 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6711
6712         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6713
6714 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6715             Tom Tromey  <tromey@adacore.com>
6716
6717         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6718
6719 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6720
6721         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6722         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6723         method to compute the bounds of range types. Also print "[evaluated]"
6724         if the bounds' values come from a dynamic evaluation.
6725
6726 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6727
6728         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6729         whitespace when pretty printing is on.
6730
6731 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6732
6733         * ppc-linux-nat.c: Add include.
6734
6735 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6736
6737         * NEWS: Mention AArch64 Pointer Authentication.
6738
6739 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6740
6741         * arm-linux-nat.c: Add include.
6742
6743 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6744
6745         * source-cache.c (source_cache::get_source_lines): Re-read
6746         fullname after calling open_source_file.
6747
6748 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6749
6750         * NEWS: Mention TLS support for FreeBSD.
6751
6752 2019-03-25  Tom Tromey  <tromey@adacore.com>
6753
6754         * minsyms.c (BUNCH_SIZE): Update comment.
6755         (~minimal_symbol_reader): Remove old comment.
6756         (compact_minimal_symbols): Update comment.
6757         (minimal_symbol_reader::install): Remove old comment.  Update
6758         other comments.
6759
6760 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6761
6762         * s390-linux-nat.c: Add include.
6763
6764 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6765
6766         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6767         Call linux_get_hwcap.
6768         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6769         Likewise.
6770         (aarch64_linux_get_hwcap): Remove function.
6771         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6772         declaration.
6773         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6774         linux_get_hwcap.
6775         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6776         * linux-tdep.c (linux_get_hwcap): Add function.
6777         (linux_get_hwcap2): Likewise.
6778         * linux-tdep.h (linux_get_hwcap): Add declaration.
6779         (linux_get_hwcap2): Likewise.
6780         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6781         (ppc_linux_get_hwcap2): Likewise.
6782         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6783         linux_get_hwcap.
6784         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6785         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6786         (ppc_linux_nat_target::read_description): Likewise.
6787         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6788         * s390-linux-nat.c: Likewise.
6789         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6790
6791 2019-03-24  Tom Tromey  <tom@tromey.com>
6792
6793         * ada-lang.c (standard_lookup): Simplify initialization.
6794         (ada_lookup_symbol_nonlocal): Simplify return.
6795         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6796         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6797         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6798         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6799         initialization.
6800         * solib.c (solib_global_lookup): Simplify.
6801         * symtab.c (null_block_symbol): Remove.
6802         (symbol_cache_lookup): Simplify returns.
6803         (lookup_language_this): Simplify returns.
6804         (lookup_symbol_aux): Simplify return.
6805         (lookup_local_symbol): Simplify returns.
6806         (lookup_global_symbol_from_objfile): Simplify return.
6807         (lookup_symbol_in_objfile_symtabs)
6808         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6809         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6810         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6811         * cp-namespace.c (cp_lookup_bare_symbol)
6812         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6813         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6814         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6815         (cp_lookup_symbol_via_imports): Simplify initialization.
6816         (find_symbol_in_baseclass): Likewise.
6817         * symtab.h (null_block_symbol): Remove.
6818         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6819         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6820         (d_lookup_symbol_module): Likewise.
6821         (find_symbol_in_baseclass): Simplify initialization.
6822
6823 2019-03-24  Tom Tromey  <tom@tromey.com>
6824
6825         * expression.h: Don't include symtab.h.
6826         (struct block): Forward declare.
6827
6828 2019-03-24  Tom Tromey  <tom@tromey.com>
6829
6830         * c-exp.y (typebase): Remove casts.
6831         * gdbtypes.c (lookup_unsigned_typename, )
6832         (lookup_signed_typename): Remove cast.
6833         * eval.c (parse_to_comma_and_eval): Remove cast.
6834         * parse.c (write_dollar_variable): Remove cast.
6835         * block.h (struct block) <superblock>: Now const.
6836         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6837         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6838         (map_block): Make "block" const.
6839         * symfile.h (struct quick_symbol_functions)
6840         <map_matching_symbols>: Constify block argument to "callback".
6841         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6842         const.
6843         (find_pc_sect_compunit_symtab): Make "b" const.
6844         (find_symbol_at_address): Likewise.
6845         (search_symbols): Likewise.
6846         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6847         (dw2_debug_names_lookup_symbol): Likewise.
6848         (dw2_map_matching_symbols): Update.
6849         * p-valprint.c (pascal_val_print): Remove "block".
6850         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6851         (aux_add_nonlocal_symbols): Make "block" const.
6852         (resolve_subexp): Remove cast.
6853         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6854         const.
6855         (iterate_over_file_blocks): Likewise.
6856         * f-exp.y (%union) <bval>: Remove.
6857         * coffread.c (patch_opaque_types): Make "b" const.
6858         * spu-tdep.c (spu_catch_start): Make "block" const.
6859         * c-valprint.c (print_unpacked_pointer): Remove "block".
6860         * symmisc.c (dump_symtab_1): Make "b" const.
6861         (block_depth): Make "block" const.
6862         * d-exp.y (%union) <bval>: Remove.
6863         * cp-support.h (cp_lookup_rtti_type): Update.
6864         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6865         * psymtab.c (psym_lookup_symbol): Make "block" const.
6866         (maintenance_check_psymtabs): Make "b" const.
6867         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6868         (enumerate_locals, enumerate_args): Update.
6869         * python/py-symtab.c (stpy_global_block): Make "block" const.
6870         (stpy_static_block): Likewise.
6871         * inline-frame.c (block_starting_point_at): Make "new_block"
6872         const.
6873         * block.c (find_block_in_blockvector): Make return type const.
6874         (blockvector_for_pc_sect): Make "b" const.
6875         (find_block_in_blockvector): Make "b" const.
6876
6877 2019-03-23  Tom Tromey  <tom@tromey.com>
6878
6879         * varobj.c (varobj_create): Update.
6880         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6881         * printcmd.c (display_command, do_one_display): Don't reset
6882         innermost_block.
6883         * parser-defs.h (enum innermost_block_tracker_type): Move to
6884         expression.h.
6885         (innermost_block): Update comment.
6886         * parse.c (parse_exp_1): Add tracker_types parameter.
6887         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6888         tracker_types parameter.  Reset innermost_block.
6889         (parse_exp_in_context): Remove.
6890         (parse_expression_for_completion): Update.
6891         * objfiles.c (~objfile): Don't reset expression_context_block or
6892         innermost_block.
6893         * expression.h (enum innermost_block_tracker_type): Move from
6894         parser-defs.h.
6895         (parse_exp_1): Add tracker_types parameter.
6896         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6897         reset innermost_block.
6898
6899 2019-03-23  Tom Tromey  <tom@tromey.com>
6900
6901         * objfiles.h: Include bcache.h.
6902
6903 2019-03-23  Tom Tromey  <tom@tromey.com>
6904
6905         * linespec.c (get_current_search_block): Use
6906         scoped_restore_current_language.
6907         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6908
6909 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6910             Jiong Wang  <jiong.wang@arm.com>
6911
6912         * aarch64-linux-tdep.c
6913         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6914         section.
6915         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6916
6917 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6918             Jiong Wang  <jiong.wang@arm.com>
6919
6920         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6921         instructions.
6922         (aarch64_analyze_prologue_test): Add PACIASP test.
6923         (aarch64_prologue_prev_register): Unmask PC value.
6924
6925 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6926             Jiong Wang  <jiong.wang@arm.com>
6927
6928         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6929         (aarch64_dwarf2_prev_register): Unmask PC value.
6930         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6931         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6932         DW_CFA_AARCH64_negate_ra_state.
6933         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6934
6935 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6936             Jiong Wang  <jiong.wang@arm.com>
6937
6938         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6939         registers.
6940         (aarch64_pseudo_register_name): Likewise.
6941         (aarch64_pseudo_register_type): Likewise.
6942         (aarch64_pseudo_register_reggroup_p): Likewise.
6943         (aarch64_gdbarch_init): Add pauth registers.
6944         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6945         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6946         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6947         (struct gdbarch_tdep): Add regnum for ra_state.
6948
6949 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6950             Jiong Wang  <jiong.wang@arm.com>
6951
6952         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6953
6954 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6955             Jiong Wang  <jiong.wang@arm.com>
6956
6957         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6958         function.
6959         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6960         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6961         (aarch64_gdbarch_init): Add puth registers.
6962         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6963         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6964         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6965
6966 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6967             Jiong Wang  <jiong.wang@arm.com>
6968
6969         * aarch64-linux-nat.c
6970         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6971         * aarch64-linux-tdep.c
6972         (aarch64_linux_core_read_description): Likewise.
6973         (aarch64_linux_get_hwcap): New function.
6974         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6975         (aarch64_linux_get_hwcap): New declaration.
6976
6977 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6978             Jiong Wang  <jiong.wang@arm.com>
6979
6980         * aarch64-linux-nat.c
6981         (aarch64_linux_nat_target::read_description): Add pauth param.
6982         * aarch64-linux-tdep.c
6983         (aarch64_linux_core_read_description): Likewise.
6984         * aarch64-tdep.c (struct target_desc): Add in pauth.
6985         (aarch64_read_description): Add pauth param.
6986         (aarch64_gdbarch_init): Likewise.
6987         * aarch64-tdep.h (aarch64_read_description): Likewise.
6988         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6989         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6990         * features/Makefile: Add new files.
6991         * features/aarch64-pauth.c: New file.
6992         * features/aarch64-pauth.xml: New file.
6993
6994 2019-03-20  Tom Tromey  <tromey@adacore.com>
6995
6996         * infrun.c (handle_inferior_event): Rename from
6997         handle_inferior_event_1.  Create a scoped_value_mark.
6998         (handle_inferior_event): Remove.
6999
7000 2019-03-19  Tom Tromey  <tromey@adacore.com>
7001
7002         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7003         * infrun.h (print_stop_event): Add "displays" parameter.
7004         * infrun.c (print_stop_event): Add "displays" parameter.
7005
7006 2019-03-19  Pedro Alves  <palves@redhat.com>
7007
7008         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7009         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7010         to -1.  Fix TABs vs spaces.
7011         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7012         * tui/tui-out.h (tui_ui_out) Add intro comments.
7013         <m_line, m_start_of_line>: In-class initialize, and add describing
7014         comment.
7015
7016 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7017
7018         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7019         variable names.
7020         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7021
7022 2019-03-18  Pedro Alves  <palves@redhat.com>
7023             Eli Zaretskii <eliz@gnu.org>
7024
7025         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7026         m_line and m_start_of_line.
7027
7028 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7029
7030         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7031         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7032         it returns a newline.  This fixes a regression in TU mode, whereby
7033         the next line is output on the same screen line as the user input.
7034
7035 2019-03-18  Tom Tromey  <tromey@adacore.com>
7036
7037         * minsyms.c (minimal_symbol_reader::install): Remove call to
7038         obstack_blank.
7039
7040 2019-03-18  Pedro Alves  <palves@redhat.com>
7041
7042         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7043         New globals.
7044         (apply_style): New, factored out from ...
7045         (apply_ansi_escape): ... this.  Handle reverse video mode.
7046         (tui_set_reverse_mode): New function.
7047         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7048         * tui/tui-winsource.c (tui_show_source_line): Use
7049         tui_set_reverse_mode instead of setting A_STANDOUT.
7050         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7051         New setter methods.
7052
7053 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7054
7055         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7056         Handle tabs.
7057
7058 2019-03-18  Tom Tromey  <tromey@adacore.com>
7059
7060         * ada-lang.c (empty_array): Add "high" parameter.
7061         (ada_evaluate_subexp): Update.
7062
7063 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7064
7065         * unittests/string_view-selftests.c: Define
7066         _initialize_string_view_selftests unconditionally.
7067
7068 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7069
7070         PR gdb/24350
7071         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7072
7073 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7074
7075         PR gdb/24351
7076         * windows-nat.c (display_selector): Fix format specifiers.
7077
7078 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7079
7080         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7081         tui_refill_source_window instead of tui_refresh_win, to update the
7082         current execution line.  This fixes redisplay of the current line
7083         when stepping through the code with "next" or "step".
7084
7085 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7086
7087         * source-cache.c (source_cache::get_source_lines): Call
7088         find_source_lines to initialize s->nlines.  This fixes vertical
7089         scrolling of TUI source window when the DOWN arrow is pressed.
7090
7091 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7092
7093         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7094         linux-thread-db.c (_initialize_thread_db): Likewise.
7095
7096 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7097
7098         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7099         wclrtoeol in tui_show_source_line".  This reverts changes made in
7100         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7101
7102 2019-03-15  Tom Tromey  <tom@tromey.com>
7103
7104         * symtab.h (struct minimal_symbol): Derive from
7105         general_symbol_info.
7106         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7107         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7108         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7109         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7110         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7111         (MSYMBOL_SEARCH_NAME): Update.
7112         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7113         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7114         * minsyms.c (minimal_symbol_reader::record_full): Update.
7115
7116 2019-03-15  Tom Tromey  <tom@tromey.com>
7117
7118         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7119
7120 2019-03-15  Tom Tromey  <tom@tromey.com>
7121
7122         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7123         unique_xmalloc_ptr.
7124         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7125         Update.
7126         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7127         (build_minimal_symbol_hash_tables)
7128         (minimal_symbol_reader::install): Update.
7129
7130 2019-03-15  Tom Tromey  <tom@tromey.com>
7131
7132         * symtab.c (create_demangled_names_hash): Update.
7133         (symbol_set_names): Update.
7134         * objfiles.h (struct objfile_per_bfd_storage)
7135         <demangled_names_hash>: Now an htab_up.
7136         * objfiles.c (objfile_per_bfd_storage): Simplify.
7137
7138 2019-03-15  Tom Tromey  <tom@tromey.com>
7139
7140         * objfiles.h (struct objfile_per_bfd_storage): Declare
7141         destructor.
7142         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7143         New.
7144         (get_objfile_bfd_data): Use new.  Don't initialize
7145         language_of_main.
7146         (free_objfile_per_bfd_storage): Remove.
7147         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7148
7149 2019-03-15  Tom Tromey  <tom@tromey.com>
7150
7151         * symfile.c (reread_symbols): Update.
7152         * objfiles.c (objfile::objfile): Update.
7153         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7154         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7155         comment.
7156         (minimal_symbol_reader::install): Update.
7157         (terminate_minimal_symbol_table): Remove.
7158         * jit.c (jit_object_close_impl): Update.
7159
7160 2019-03-15  Tom Tromey  <tom@tromey.com>
7161
7162         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7163         initializations.
7164
7165 2019-03-15  Tom Tromey  <tom@tromey.com>
7166
7167         * objfiles.h (struct objfile_per_bfd_storage)
7168         <demangled_hash_languages>: Now a bitset.
7169         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7170         (lookup_minimal_symbol): Update.
7171
7172 2019-03-15  Tom Tromey  <tom@tromey.com>
7173
7174         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7175         Don't return the symbol.
7176         * coffread.c (record_minimal_symbol): Use record_full.
7177
7178 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7179
7180         The MS-Windows port of ncurses fails to switch to a color pair if
7181         one or both of the colors are the implicit default colors.  This
7182         change records the default colors when TUI is initialized, and
7183         then specifies them explicitly when a color pair uses the default
7184         colors.  This allows color styling in TUI mode on MS-Windows.
7185
7186         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7187         ncurses_norm_attr.
7188         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7189         colors in ncurses_norm_attr.
7190         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7191         "none", replace it with the default color recorded in
7192         ncurses_norm_attr.
7193
7194 2019-03-14  Tom Tromey  <tromey@adacore.com>
7195
7196         * source-cache.h (class source_cache) <get_source_lines>: Return
7197         std::string.
7198         * source-cache.c (source_cache::extract_lines): Handle case where
7199         first_pos==npos.  Return std::string.
7200         (source_cache::get_source_lines): Update.
7201
7202 2019-03-14  Tom Tromey  <tromey@adacore.com>
7203
7204         * NEWS: Add item for "style sources" commands.
7205         * source-cache.c (source_cache::get_source_lines): Check
7206         source_styling.
7207         * cli/cli-style.c (source_styling): New global.
7208         (_initialize_cli_style): Add "style sources" commands.
7209         (show_style_sources): New function.
7210         * cli/cli-style.h (source_styling): Declare.
7211
7212 2019-03-14  Pedro Alves  <palves@redhat.com>
7213             Tom Tromey  <tromey@adacore.com>
7214
7215         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7216         * tui/tui-winsource.c (tui_refill_source_window): New function,
7217         from...
7218         (tui_horizontal_source_scroll): ... here.  Move some logic.
7219         * cli/cli-style.c (set_style_enabled): Notify new observable.
7220         * tui/tui-hooks.c (tui_redisplay_source): New function.
7221         (tui_attach_detach_observers): Attach or detach
7222         tui_redisplay_source.
7223         * observable.h (source_styling_changed): New observable.
7224         * observable.c: Define source_styling_changed observable.
7225
7226 2019-03-13  Tom Tromey  <tromey@adacore.com>
7227
7228         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7229         (i386_gnu_nat_target::store_registers): Update.
7230         * target-debug.h (target_debug_print_std_string): New macro.
7231         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7232         * windows-tdep.c (display_one_tib): Update.
7233         * tui/tui-stack.c (tui_make_status_line): Update.
7234         * top.c (print_inferior_quit_action): Update.
7235         * thread.c (thr_try_catch_cmd): Update.
7236         (add_thread_with_info): Update.
7237         (thread_target_id_str): Update.
7238         (thr_try_catch_cmd): Update.
7239         (thread_command): Update.
7240         (thread_find_command): Update.
7241         * record-btrace.c (record_btrace_target::info_record)
7242         (record_btrace_resume_thread, record_btrace_target::resume)
7243         (record_btrace_cancel_resume, record_btrace_step_thread)
7244         (record_btrace_target::wait, record_btrace_target::wait)
7245         (record_btrace_target::wait, record_btrace_target::stop): Update.
7246         * progspace.c (print_program_space): Update.
7247         * process-stratum-target.c
7248         (process_stratum_target::thread_address_space): Update.
7249         * linux-fork.c (linux_fork_mourn_inferior)
7250         (detach_checkpoint_command, info_checkpoints_command)
7251         (linux_fork_context): Update.
7252         (linux_fork_detach): Update.
7253         (class scoped_switch_fork_info): Update.
7254         (delete_checkpoint_command): Update.
7255         * infrun.c (follow_fork_inferior): Update.
7256         (follow_fork_inferior): Update.
7257         (proceed_after_vfork_done): Update.
7258         (handle_vfork_child_exec_or_exit): Update.
7259         (follow_exec): Update.
7260         (displaced_step_prepare_throw): Update.
7261         (displaced_step_restore): Update.
7262         (start_step_over): Update.
7263         (resume_1): Update.
7264         (clear_proceed_status_thread): Update.
7265         (proceed): Update.
7266         (print_target_wait_results): Update.
7267         (do_target_wait): Update.
7268         (context_switch): Update.
7269         (stop_all_threads): Update.
7270         (restart_threads): Update.
7271         (finish_step_over): Update.
7272         (handle_signal_stop): Update.
7273         (switch_back_to_stepped_thread): Update.
7274         (keep_going_pass_signal): Update.
7275         (print_exited_reason): Update.
7276         (normal_stop): Update.
7277         * inferior.c (inferior_pid_to_str): Change return type.
7278         (print_selected_inferior): Update.
7279         (add_inferior): Update.
7280         (detach_inferior): Update.
7281         * dummy-frame.c (fprint_dummy_frames): Update.
7282         * dcache.c (dcache_info_1): Update.
7283         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7284         (btrace_fetch, btrace_clear): Update.
7285         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7286         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7287         type.
7288         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7289         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7290         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7291         * gdbarch.c, gdbarch.h: Rebuild.
7292         * gdbarch.sh (core_pid_to_str): Change return type.
7293         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7294         return type.
7295         (windows_nat_target::pid_to_str): Change return type.
7296         (windows_delete_thread): Update.
7297         (windows_nat_target::attach): Update.
7298         (windows_nat_target::files_info): Update.
7299         * target-delegates.c: Rebuild.
7300         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7301         return type.
7302         (sol_thread_target::pid_to_str): Change return type.
7303         * remote.c (class remote_target) <pid_to_str>: Change return
7304         type.
7305         (remote_target::pid_to_str): Change return type.
7306         (extended_remote_target::attach, remote_target::remote_stop_ns)
7307         (remote_target::remote_notif_remove_queued_reply)
7308         (remote_target::push_stop_reply, remote_target::disable_btrace):
7309         Update.
7310         (extended_remote_target::attach): Update.
7311         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7312         type.
7313         (gdbsim_target::pid_to_str): Change return type.
7314         * ravenscar-thread.c (struct ravenscar_thread_target)
7315         <pid_to_str>: Change return type.
7316         (ravenscar_thread_target::pid_to_str): Change return type.
7317         * procfs.c (class procfs_target) <pid_to_str>: Change return
7318         type.
7319         (procfs_target::pid_to_str): Change return type.
7320         (procfs_target::attach): Update.
7321         (procfs_target::detach): Update.
7322         (procfs_target::fetch_registers): Update.
7323         (procfs_target::store_registers): Update.
7324         (procfs_target::wait): Update.
7325         (procfs_target::files_info): Update.
7326         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7327         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7328         return type.
7329         (nto_procfs_target::pid_to_str): Change return type.
7330         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7331         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7332         return type.
7333         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7334         (exit_lwp): Update.
7335         (attach_proc_task_lwp_callback, get_detach_signal)
7336         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7337         (linux_nat_target::resume, wait_lwp, stop_callback)
7338         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7339         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7340         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7341         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7342         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7343         type.
7344         (inf_ptrace_target::attach): Update.
7345         (inf_ptrace_target::files_info): Update.
7346         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7347         type.
7348         (go32_nat_target::pid_to_str): Change return type.
7349         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7350         (gnu_nat_target::wait): Update.
7351         (gnu_nat_target::wait): Update.
7352         (gnu_nat_target::resume): Update.
7353         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7354         (fbsd_nat_target::wait): Update.
7355         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7356         type.
7357         (darwin_nat_target::attach): Update.
7358         * corelow.c (class core_target) <pid_to_str>: Change return type.
7359         (core_target::pid_to_str): Change return type.
7360         * target.c (normal_pid_to_str): Change return type.
7361         (default_pid_to_str): Likewise.
7362         (target_pid_to_str): Change return type.
7363         (target_translate_tls_address): Update.
7364         (target_announce_detach): Update.
7365         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7366         return type.
7367         (bsd_uthread_target::pid_to_str): Change return type.
7368         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7369         type.
7370         (bsd_kvm_target::pid_to_str): Change return type.
7371         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7372         return type.
7373         (aix_thread_target::pid_to_str): Change return type.
7374         * target.h (struct target_ops) <pid_to_str>: Change return type.
7375         (target_pid_to_str, normal_pid_to_str): Likewise.
7376         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7377         type.
7378         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7379         type.
7380         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7381         return type.
7382         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7383         type.
7384         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7385         type.
7386         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7387         return type.
7388
7389 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7390
7391         * NEWS: Mention that the new default MI version is 3.  Mention
7392         changes to the output of commands and events that deal with
7393         multi-location breakpoints.
7394         * breakpoint.c: Include "mi/mi-out.h".
7395         (print_one_breakpoint): Change output syntax if using MI version
7396         >= 3.
7397         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7398         New.
7399         (mi_multi_location_breakpoint_output_fixed): New.
7400         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7401         (mi_cmd_fix_multi_location_breakpoint_output): New.
7402         (mi_multi_location_breakpoint_output_fixed): New.
7403         * mi/mi-cmds.c (mi_cmds): Register command
7404         -fix-multi-location-breakpoint-output.
7405         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7406         interpreter "mi".
7407
7408 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7409
7410         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7411         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7412         instantiate mi_ui_out based on interpreter name.
7413         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7414         * mi/mi-main.c (mi_load_progress): Likewise.
7415
7416 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7417
7418         * NEWS: Combine separate "New targets" sections for 8.3.
7419
7420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7421
7422         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7423         (ppcfbsd_init_abi): Install gdbarch
7424         "fetch_tls_load_module_address" and "get_thread_local_address"
7425         methods.
7426
7427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7428
7429         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7430         (riscv_fbsd_init_abi): Install gdbarch
7431         "fetch_tls_load_module_address" and "get_thread_local_address"
7432         methods.
7433
7434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7435
7436         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7437         (i386fbsd_init_abi): Install gdbarch
7438         "fetch_tls_load_module_address" and "get_thread_local_address"
7439         methods.
7440
7441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7442
7443         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7444         (amd64fbsd_init_abi): Install gdbarch
7445         "fetch_tls_load_module_address" and "get_thread_local_address"
7446         methods.
7447
7448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7449
7450         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7451         (struct fbsd_pspace_data): New type.
7452         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7453         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7454         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7455         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7456         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7457
7458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7459
7460         * gdbtypes.c (lookup_struct_elt): New function.
7461         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7462         * gdbtypes.h (struct struct_elt): New type.
7463         (lookup_struct_elt): New prototype.
7464
7465 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7466
7467         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7468         remove disabled code block.
7469
7470 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7471
7472         * gdbarch.sh (get_thread_local_address): New method.
7473         * gdbarch.h, gdbarch.c: Regenerate.
7474         * target.c (target_translate_tls_address): Use
7475         gdbarch_get_thread_local_address if present instead of
7476         target::get_thread_local_address.
7477
7478 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7479
7480         * target.h (target::get_thread_local_address): Update comment.
7481
7482 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7483
7484         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7485         objfile->separate_debug_objfile_backlink if not NULL.
7486
7487 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7488
7489         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7490         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7491         (amd64bsd_store_inferior_registers): Likewise.
7492         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7493         Enable segment base registers.
7494         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7495         PT_GETFSBASE and PT_GETGSBASE.
7496         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7497         PT_SETGSBASE.
7498         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7499         segment base registers.
7500         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7501
7502 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7503
7504         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7505         Update calls to i386_target_description to add 'segments'
7506         parameter.
7507         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7508         add segment base registers.
7509         * arch/i386.c (i386_create_target_description): Add 'segments'
7510         parameter to enable segment base registers.
7511         * arch/i386.h (i386_create_target_description): Likewise.
7512         * features/i386/32bit-segments.xml: New file.
7513         * features/i386/32bit-segments.c: Generate.
7514         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7515         call to i386_target_description to add 'segments' parameter.
7516         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7517         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7518         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7519         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7520         if feature is present.
7521         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7522         Add 'segments' parameter to call to i386_target_description.
7523         (i386_target_description): Add 'segments' parameter to enable
7524         segment base registers.
7525         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7526         to call to i386_target_description.
7527         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7528         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7529         Define I386_NUM_REGS.
7530         (i386_target_description): Add 'segments' parameter to enable
7531         segment base registers.
7532
7533 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7534
7535         PR/24325
7536         * source-cache.c: #undef open and close, to avoid unresolved
7537         externals during linking.
7538
7539 2019-03-12  Tom Tromey  <tromey@adacore.com>
7540
7541         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7542         const.  Add initializers.
7543         (_initialize_remote): Don't initialize ptid globals.
7544
7545 2019-03-12  Pedro Alves  <palves@redhat.com>
7546
7547         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7548
7549 2019-03-12  Pedro Alves  <palves@redhat.com>
7550
7551         * cp-name-parser.y (main): Remove unused 'len' variable.
7552
7553 2019-03-12  Tom Tromey  <tromey@adacore.com>
7554
7555         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7556         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7557
7558 2019-03-12  Tom Tromey  <tromey@adacore.com>
7559
7560         * linux-nat.c (iterate_over_lwps): Update.
7561         (stop_callback): Remove parameter.
7562         (stop_wait_callback, detach_callback, resume_set_callback)
7563         (select_singlestep_lwp_callback, set_ignore_sigint)
7564         (status_callback, resumed_callback, resume_clear_callback)
7565         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7566         data parameter.
7567         (linux_nat_target::detach, linux_nat_target::resume)
7568         (linux_stop_and_wait_all_lwps, select_event_lwp)
7569         (linux_nat_filter_event, linux_nat_wait_1)
7570         (linux_nat_target::kill, linux_nat_target::stop)
7571         (linux_nat_target::stop): Update.
7572         (linux_nat_resume_callback): Change type.
7573         (resume_stopped_resumed_lwps, count_events_callback)
7574         (select_event_lwp_callback): Likewise.
7575         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7576         * arm-linux-nat.c (struct update_registers_data): Remove.
7577         (update_registers_callback): Change type.
7578         (arm_linux_insert_hw_breakpoint1): Update.
7579         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7580         parameter.
7581         (x86_linux_dr_set_addr): Update.
7582         (x86_linux_dr_set_control): Update.
7583         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7584         (iterate_over_lwps): Use gdb::function_view.
7585         * nat/aarch64-linux-hw-point.c (struct
7586         aarch64_dr_update_callback_param): Remove.
7587         (debug_reg_change_callback): Change type.
7588         (aarch64_notify_debug_reg_change): Update.
7589         * s390-linux-nat.c (s390_refresh_per_info): Update.
7590
7591 2019-03-11  Tom Tromey  <tromey@adacore.com>
7592
7593         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7594         redundant assignment to "this_cu".
7595
7596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7597
7598         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7599
7600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7601
7602         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7603         from...
7604         (rank_one_type): ... this.
7605
7606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7607
7608         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7609         from...
7610         (rank_one_type): ... this.
7611
7612 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7613
7614         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7615         from...
7616         (rank_one_type): ... this.
7617
7618 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7619
7620         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7621         from...
7622         (rank_one_type): ... this.
7623
7624 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7625
7626         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7627         from...
7628         (rank_one_type): ... this.
7629
7630 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7631
7632         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7633         from...
7634         (rank_one_type): ... this.
7635
7636 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7637
7638         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7639         from...
7640         (rank_one_type): ... this.
7641
7642 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7643
7644         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7645         from...
7646         (rank_one_type): ... this.
7647
7648 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7649
7650         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7651         from...
7652         (rank_one_type): ... this.
7653
7654 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7655
7656         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7657         from...
7658         (rank_one_type): ... this.
7659
7660 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7661
7662         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7663         from...
7664         (rank_one_type): ... this.
7665
7666 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7667
7668         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7669         from...
7670         (rank_one_type): ... this.
7671
7672 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7673
7674         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7675         inferior-events' shows the example events.
7676
7677 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7678
7679         Support styling on native MS-Windows console
7680
7681         PR/24315
7682         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7683         on MS-Windows if $TERM is not defined.
7684
7685         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7686
7687         * posix-hdep.c (gdb_console_fputs):
7688         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7689         functions.
7690         * ui-file.h (gdb_console_fputs): Add prototype.
7691
7692         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7693         back to fputs only if the former returns zero.
7694
7695 2019-03-07  Tom Tromey  <tom@tromey.com>
7696
7697         * symmisc.c (print_symbol_bcache_statistics): Update.
7698         (print_objfile_statistics): Update.
7699         * symfile.c (allocate_symtab): Update.
7700         * stabsread.c: Don't include bcache.h.
7701         * psymtab.h (struct psymbol_bcache): Don't declare.
7702         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7703         (psymbol_bcache_init, psymbol_bcache_free)
7704         (psymbol_bcache_get_bcache): Don't declare.
7705         * psymtab.c (struct psymbol_bcache): Remove.
7706         (psymtab_storage::psymtab_storage): Update.
7707         (psymtab_storage::~psymtab_storage): Update.
7708         (psymbol_bcache_init, psymbol_bcache_free)
7709         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7710         (add_psymbol_to_bcache): Update.
7711         (allocate_psymtab): Update.
7712         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7713         macro_cache>: No longer pointers.
7714         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7715         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7716         * macrotab.c (macro_bcache): Update.
7717         * macroexp.c: Don't include bcache.h.
7718         * gdbtypes.c (check_types_worklist): Update.
7719         (types_deeply_equal): Remove TRY/CATCH.  Update.
7720         * elfread.c (elf_symtab_read): Update.
7721         * dwarf2read.c: Don't include bcache.h.
7722         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7723         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7724         (print_bcache_statistics, bcache_memory_used): Don't declare.
7725         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7726         methods.  Rename all data members.
7727         * bcache.c (struct bcache): Move to bcache.h.
7728         (bcache::expand_hash_table): Rename from expand_hash_table.
7729         (bcache): Remove.
7730         (bcache::insert): Rename from bcache_full.
7731         (bcache::compare): Rename from bcache_compare.
7732         (bcache_xmalloc): Remove.
7733         (bcache::~bcache): Rename from bcache_xfree.
7734         (bcache::print_statistics): Rename from print_bcache_statistics.
7735         (bcache::memory_used): Rename from bcache_memory_used.
7736
7737 2019-03-07  Pedro Alves  <palves@redhat.com>
7738
7739         * infrun.c (normal_stop): Also check for
7740         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7741
7742 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7743
7744         * f-lang.c (value_from_host_double): Moved to...
7745         * value.c (value_from_host_double): ...here.
7746         * value.h (value_from_host_double): Declare.
7747         * guile/scm-math.c (vlscm_convert_typed_number): Use
7748         value_from_host_double.
7749         (vlscm_convert_number): Likewise.
7750         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7751         * python/py-value.c (convert_value_from_python): Likewise.
7752
7753 2019-03-06  Tom Tromey  <tom@tromey.com>
7754
7755         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7756
7757 2019-03-06  Tom Tromey  <tom@tromey.com>
7758
7759         * utils.h (free_current_contents): Don't declare.
7760         * utils.c (free_current_contents): Remove.
7761
7762 2019-03-06  Tom Tromey  <tom@tromey.com>
7763
7764         * top.c (quit_force): Update.
7765         * main.c (captured_command_loop): Update.
7766         * common/new-op.c (operator new): Update.
7767         * common/common-exceptions.c (struct catcher)
7768         <save_cleanup_chain>: Remove member.
7769         (exceptions_state_mc_init): Update.
7770         (exception_try_scope_entry): Return nullptr.
7771         (exception_try_scope_exit, exception_rethrow)
7772         (throw_exception_sjlj, throw_exception_cxx): Update.
7773         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7774         (all_cleanups, do_cleanups, discard_cleanups)
7775         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7776         (restore_cleanups, restore_final_cleanups): Don't declare.
7777         (do_final_cleanups): Remove parameter.
7778         * common/cleanups.c (cleanup_chain, make_cleanup)
7779         (make_cleanup_dtor, all_cleanups, do_cleanups)
7780         (discard_my_cleanups, discard_cleanups)
7781         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7782         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7783         (null_cleanup): Remove.
7784         (do_final_cleanups): Remove parameter.
7785
7786 2019-03-06  Tom Tromey  <tom@tromey.com>
7787
7788         * remote.c (remote_target::remote_parse_stop_reply): Use
7789         unique_xmalloc_ptr.
7790
7791 2019-03-06  Tom Tromey  <tom@tromey.com>
7792
7793         * stabsread.c (struct stabs_field_info): Rename from field_info.
7794         <list, fnlist>: Add initializers.
7795         <obstack>: New member.
7796         (read_member_functions, read_struct_fields, read_baseclasses):
7797         Allocate on obstack.  Don't use cleanups.
7798         (read_one_struct_field, read_member_functions, read_struct_fields)
7799         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7800         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7801         (read_struct_type): Update.
7802
7803 2019-03-06  Tom Tromey  <tom@tromey.com>
7804
7805         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7806         * common/filestuff.h (make_cleanup_close): Don't declare.
7807         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7808         Remove.
7809
7810 2019-03-06  Tom Tromey  <tom@tromey.com>
7811
7812         * solib-aix.c: Use make_scope_exit.
7813
7814 2019-03-06  Tom Tromey  <tom@tromey.com>
7815
7816         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7817         Use make_scope_exit.
7818
7819 2019-03-06  Tom Tromey  <tom@tromey.com>
7820
7821         * solib-svr4.c (disable_probes_interface): Remove parameter.
7822         (svr4_handle_solib_event): Use make_scope_exit.
7823
7824 2019-03-06  Tom Tromey  <tom@tromey.com>
7825
7826         * remote.c (struct stop_reply_deleter): Remove.
7827         (stop_reply_up): Update.
7828         (struct stop_reply): Derive from notif_event.  Don't typedef.
7829         <regcache>: Now a std::vector.
7830         (stop_reply_xfree): Remove.
7831         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7832         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7833         (remote_target::discard_pending_stop_replies): Use delete.
7834         (remote_target::remote_parse_stop_reply): Update.
7835         (remote_target::process_stop_reply): Update.
7836         * remote-notif.h (struct notif_event): Add virtual destructor.
7837         Remove "dtr" member.
7838         (struct notif_client) <alloc_event>: Return a unique_ptr.
7839         (notif_event_xfree): Don't declare.
7840         (notif_event_up): New typedef.
7841         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7842         (notif_event_xfree, do_notif_event_xfree): Remove.
7843         (remote_notif_state_xfree): Update.
7844
7845 2019-03-06  Tom Tromey  <tom@tromey.com>
7846
7847         * infrun.c (displaced_step_clear_cleanup): Now a
7848         forward_scope_exit type.
7849         (displaced_step_prepare_throw): Update.
7850         (displaced_step_fixup): Update.
7851
7852 2019-03-06  Tom Tromey  <tom@tromey.com>
7853
7854         * inferior.h (class inferior): Update comment.
7855         * gdbthread.h (class thread_info): Update comment.
7856
7857 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7858             Tom Tromey  <tom@tromey.com>
7859
7860         * stabsread.h (struct stab_section_list): Remove.
7861         (coffstab_build_psymtabs): Update.
7862         * dbxread.c (symbuf_sections): Now a std::vector.
7863         (sect_idx): New global.
7864         (fill_symbuf): Update.
7865         (coffstab_build_psymtabs): Change type of stabsects parameter.
7866         Update.
7867         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7868         std::vector.
7869         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7870         (coff_locate_sections): Update.
7871         (coff_symfile_read): Remove cleanups.  Update.
7872         (init_stringtab): Add storage parameter.
7873         (free_stringtab, free_stringtab_cleanup): Remove.
7874         (init_lineno): Add storage parameter.
7875         (free_linetab, free_linetab_cleanup): Remove.
7876
7877 2019-03-06  Pedro Alves  <palves@redhat.com>
7878
7879         * linux-fork.c (fork_info::clobber_regs): Delete.
7880         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7881         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7882         comment.  Adjust.
7883         (scoped_switch_fork_info::scoped_switch_fork_info)
7884         (checkpoint_command, linux_fork_context): Adjust
7885         fork_save_infrun_state calls.
7886
7887 2019-03-06  Pedro Alves  <palves@redhat.com>
7888
7889         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7890         (inf_has_multiple_threads): Return 'bool' and rewrite using
7891         inferior_info::threads().
7892
7893 2019-03-06  Pedro Alves  <palves@redhat.com>
7894
7895         * linux-fork.c: Include <list>.
7896         (fork_list): Now a std::list instance.
7897         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7898         (forks_exist_p, find_last_fork): Adjust.
7899         (new_fork): Delete.
7900         (one_fork_p): New.
7901         (add_fork): Adjust.
7902         (free_fork): Delete, folded into fork_info::~fork_info().
7903         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7904         Adjust.
7905         (init_fork_list): Delete.
7906         (linux_fork_killall, linux_fork_mourn_inferior)
7907         (linux_fork_detach, info_checkpoints_command): Adjust.
7908         (_initialize_linux_fork): No longer call init_fork_list.
7909
7910 2019-03-06  Pedro Alves  <palves@redhat.com>
7911
7912         * linux-fork.c (new_fork): New, split out of ...
7913         (add_fork): ... this.  Return void.  Move "first fork" special
7914         case from here, to ...
7915         (checkpoint_command): ... here.
7916         * linux-linux.h (add_fork): Return void.
7917
7918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7919
7920         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7921
7922 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7923             Chris January  <chris.january@arm.com>
7924             David Lecomber  <david.lecomber@arm.com>
7925
7926         * f-exp.y: New token, UNOP_INTRINSIC.
7927         (exp): New pattern using UNOP_INTRINSIC token.
7928         (f77_keywords): Add 'abs' keyword.
7929         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7930         (value_from_host_double): New function.
7931         (evaluate_subexp_f): Support UNOP_ABS.
7932
7933 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7934
7935         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7936         types.
7937
7938 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7939
7940         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7941         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7942         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7943
7944 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7945
7946         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7947
7948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7949             Chris January  <chris.january@arm.com>
7950
7951         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7952         * f-exp.y: Define 'KIND' token.
7953         (exp): New pattern for KIND expressions.
7954         (ptype): Handle types with a kind extension.
7955         (direct_abs_decl): Extend to spot kind extensions.
7956         (f77_keywords): Add 'kind' to the list.
7957         (push_kind_type): New function.
7958         (convert_to_kind_type): New function.
7959         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7960         * parse.c (operator_length_standard): Likewise.
7961         * parser-defs.h (enum type_pieces): Add tp_kind.
7962         * std-operator.def: Add UNOP_KIND.
7963
7964 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7965
7966         * f-exp.y (f_parse): Set yydebug.
7967
7968 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7969
7970         * f-lang.c (evaluate_subexp_f): New function.
7971         (exp_descriptor_f): New global.
7972         (f_language_defn): Use exp_descriptor_f instead of
7973         exp_descriptor_standard.
7974
7975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7976
7977         * f-exp.y (struct token): Add comments.
7978         (dot_ops): Remove uppercase versions and the end marker.
7979         (f77_keywords): Likewise.
7980         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7981         entries in the dot_ops array are case insensitive, and use
7982         strncasecmp to compare strings.  Also some whitespace cleanup in
7983         this area.  Similar for the f77_keywords array, except entries in
7984         this list might be case sensitive.
7985
7986 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7987
7988         * f-exp.y (struct f77_boolean_val): Add comments.
7989         (boolean_values): Remove uppercase versions, and end marker.
7990         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7991         and use strncasecmp to achieve case insensitivity.  Additionally,
7992         perform whitespace cleanup around this code.
7993
7994 2019-03-06  Tom Tromey  <tromey@adacore.com>
7995
7996         * remote-sim.c (gdbsim_target_open): Use result of
7997         gdb_argv::release.
7998
7999 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8000         Dirk Schubert  <dirk.schubert@arm.com>
8001         Chris January  <chris.january@arm.com>
8002
8003         * eval.c (evaluate_subexp_standard): Call Fortran argument
8004         wrapping logic.
8005         * f-lang.c (struct value): A value which can be passed into a
8006         Fortran function call.
8007         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8008         where appropriate.
8009         (struct type): Value ready for a Fortran function call.
8010         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8011         is needed.
8012         * f-lang.h (fortran_argument_convert): Declaration.
8013         (fortran_preserve_arg_pointer): Declaration.
8014         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8015
8016 2019-03-05  Tom Tromey  <tromey@adacore.com>
8017
8018         * python/py-prettyprint.c (print_string_repr): Remove #if.
8019         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8020
8021 2019-03-05  Tom Tromey  <tromey@adacore.com>
8022
8023         * target.c (the_dummy_target): Move later.  Change type to
8024         "dummy_target".
8025         (initialize_targets): Don't initialize the_dummy_target.
8026
8027 2019-03-05  Tom Tromey  <tromey@adacore.com>
8028
8029         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8030         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8031
8032 2019-03-05  Tom Tromey  <tromey@adacore.com>
8033
8034         * windows-nat.c (windows_nat_target::attach)
8035         (windows_nat_target::detach): Don't call gdb_flush.
8036         * valprint.c (generic_val_print, val_print, val_print_string):
8037         Don't call gdb_flush.
8038         * utils.c (defaulted_query): Don't call gdb_flush.
8039         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8040         * target.c (target_announce_detach): Don't call gdb_flush.
8041         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8042         * remote.c (extended_remote_target::attach): Don't call
8043         gdb_flush.
8044         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8045         * printcmd.c (do_examine): Don't call gdb_flush.
8046         (info_display_command): Don't call gdb_flush.
8047         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8048         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8049         * memattr.c (info_mem_command): Don't call gdb_flush.
8050         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8051         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8052         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8053         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8054         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8055         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8056         (gnu_nat_target::detach): Don't call gdb_flush.
8057         * f-valprint.c (f_val_print): Don't call gdb_flush.
8058         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8059         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8060         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8061         gdb_flush.
8062         * c-valprint.c (c_val_print): Don't call gdb_flush.
8063         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8064
8065 2019-03-05  Tom Tromey  <tromey@adacore.com>
8066
8067         * varobj.c (update_dynamic_varobj_children): Update.
8068         (install_default_visualizer): Use reset, not release.
8069         * value.c (set_internalvar): Update.
8070         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8071         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8072         ATTRIBUTE_UNUSED_RESULT.
8073
8074 2019-03-05  Tom Tromey  <tromey@adacore.com>
8075
8076         * remote.c (class scoped_remote_fd) <release>: Add
8077         ATTRIBUTE_UNUSED_RESULT.
8078
8079 2019-03-05  Tom Tromey  <tromey@adacore.com>
8080
8081         * macroexp.c (struct macro_buffer) <release>: Add
8082         ATTRIBUTE_UNUSED_RESULT.
8083
8084 2019-03-05  Tom Tromey  <tromey@adacore.com>
8085
8086         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8087         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8088         ATTRIBUTE_UNUSED_RESULT.
8089
8090 2019-03-05  Tom Tromey  <tromey@adacore.com>
8091
8092         * common/scoped_fd.h (class scoped_fd) <release>: Add
8093         ATTRIBUTE_UNUSED_RESULT.
8094
8095 2019-03-05  Tom Tromey  <tromey@adacore.com>
8096
8097         * parser-defs.h (struct parser_state) <release>: Add
8098         ATTRIBUTE_UNUSED_RESULT.
8099
8100 2019-03-05  Tom Tromey  <tromey@adacore.com>
8101
8102         * utils.h (class gdb_argv) <release>: Add
8103         ATTRIBUTE_UNUSED_RESULT.
8104         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8105
8106 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8107
8108         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8109         for-loop range, to avoid compiler warnings.
8110
8111         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8112         avoid compiler warnings about unused variables.
8113
8114         * NEWS: Mention end of support for native debugging on MS-Windows
8115         before XP.
8116
8117         PR gdb/24292
8118         * common/netstuff.c:
8119         * gdbserver/gdbreplay.c
8120         * gdbserver/remote-utils.c:
8121         * ser-tcp.c:
8122         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8123         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8124         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8125         'getaddrinfo' and 'freeaddrinfo' were not available before
8126         Windows XP, and mingw.org's MinGW headers by default define
8127         _WIN32_WINNT to 0x500.
8128
8129 2019-03-01  Gary Benson <gbenson@redhat.com>
8130
8131         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8132
8133 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8134             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8135
8136         PR gdb/8527
8137         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8138         set_sigint_trap, clear_sigint_trap.
8139
8140 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8141
8142         * target.c (target_detach): Clear the regcache and the
8143         frame cache.
8144
8145 2019-02-27  Pedro Alves  <palves@redhat.com>
8146
8147         * utils.c (set_screen_size): When we cap the height/width sizes,
8148         tweak the corresponding command variable to show "unlimited":
8149
8150 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8151             Pedro Alves  <palves@redhat.com>
8152
8153         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8154         before calling rl_set_screen_size.
8155
8156 2019-02-27  Tom Tromey  <tromey@adacore.com>
8157
8158         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8159         define.
8160         * python/py-value.c: Remove Python 2.4 workaround.
8161         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8162         workaround.
8163         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8164         Python 2.4 workaround.
8165         * python/python-internal.h: Remove Python 2.4 comment.
8166         (Py_ssize_t): Don't define.
8167         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8168         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8169         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8170         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8171         * python/python.c (do_start_initialization): Remove Python 2.4
8172         workaround.
8173         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8174         (print_children): Remove Python 2.4 workaround.
8175         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8176         workaround.
8177         (CHARBUFFERPROC_NAME): Remove.
8178         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8179         Python 2.4 workaround.
8180
8181 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8182
8183         * NEWS: Note minimum Python version.
8184
8185 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8186
8187         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8188         code from these functions.  Remove corresponding ifdefs.  Use
8189         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8190         Remove gotos and target of gotos.
8191         (infpy_search_memory): Likewise.
8192
8193 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8194
8195         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8196         (hppa_gdbarch_init): Don't register deleted functions with
8197         gdbarch.
8198
8199 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8200
8201         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8202         (h8300_unwind_sp): Delete.
8203         (h8300_dummy_id): Delete.
8204         (h8300_gdbarch_init): Don't register deleted functions with
8205         gdbarch.
8206
8207 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8208
8209         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8210         (ft32_unwind_pc): Delete.
8211         (ft32_unwind_sp): Delete.
8212         (ft32_gdbarch_init): Don't register deleted functions with
8213         gdbarch.
8214
8215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8216
8217         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8218         (frv_unwind_pc): Delete.
8219         (frv_unwind_sp): Delete.
8220         (frv_gdbarch_init): Don't register deleted functions with
8221         gdbarch.
8222
8223 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8224
8225         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8226         (riscv_unwind_pc): Delete.
8227         (riscv_unwind_sp): Delete.
8228         (riscv_gdbarch_init): Don't register deleted functions with
8229         gdbarch.
8230
8231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8232
8233         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8234         (csky_unwind_pc): Delete.
8235         (csky_unwind_sp): Delete.
8236         (csky_gdbarch_init): Don't register deleted functions with
8237         gdbarch.
8238
8239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8240
8241         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8242         (cris_unwind_pc): Delete.
8243         (cris_unwind_sp): Delete.
8244         (cris_gdbarch_init): Don't register deleted functions with
8245         gdbarch.
8246
8247 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8248
8249         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8250         (bfin_unwind_pc): Delete.
8251         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8252
8253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8254
8255         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8256         (arm_unwind_pc): Delete.
8257         (arm_unwind_sp): Delete.
8258         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8259
8260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8261
8262         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8263         (arc_unwind_pc): Delete.
8264         (arc_unwind_sp): Delete.
8265         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8266
8267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8268
8269         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8270         (alpha_unwind_pc): Delete.
8271         (alpha_gdbarch_init): Don't register deleted functions with
8272         gdbarch.
8273
8274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8275
8276         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8277         (aarch64_unwind_pc): Delete.
8278         (aarch64_unwind_sp): Delete.
8279         (aarch64_gdbarch_init): Don't register deleted functions with
8280         gdbarch.
8281
8282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8283
8284         * gdbtypes.c (type_align): Don't consider static members when
8285         computing structure alignment.
8286
8287 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8288
8289         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8290         return 0 for other types.
8291         * arch-utils.c (default_type_align): Always return 0.
8292         * gdbarch.h: Regenerate.
8293         * gdbarch.sh (type_align): Extend comment.
8294         * gdbtypes.c (type_align): Add additional comments, always call
8295         gdbarch_type_align before applying the default rules.
8296         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8297         generic code will then apply a suitable default.
8298         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8299         types, return 0 for other types.
8300
8301 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8302
8303         * NEWS: Create a new section for the next release branch.
8304         Rename the section of the current branch, now that it has
8305         been cut.
8306
8307 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8308
8309         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8310         * version.in: Bump version to 8.3.50.DATE-git.
8311
8312 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8313
8314         * aix-thread.c (ptid_cmp): Remove unused variable.
8315         (get_signaled_thread): Likewise.
8316         (store_regs_user_thread): Likewise.
8317         (store_regs_kernel_thread): Likewise.
8318         (fetch_regs_kernel_thread): Remove shadowed variable.
8319
8320 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8321
8322         * features/riscv/32bit-cpu.xml: Add register numbers.
8323         * features/riscv/32bit-fpu.c: Regenerate.
8324         * features/riscv/32bit-fpu.xml: Add register numbers.
8325         * features/riscv/64bit-cpu.xml: Add register numbers.
8326         * features/riscv/64bit-fpu.c: Regenerate.
8327         * features/riscv/64bit-fpu.xml: Add register numbers.
8328
8329 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8330
8331         * NEWS: Mention two argument form of gdb.Value constructor.
8332         * python/py-value.c (convert_buffer_and_type_to_value): New
8333         function.
8334         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8335         Add support for handling an optional second argument.  Call
8336         convert_buffer_and_type_to_value as appropriate.
8337         * python/python-internal.h (Py_buffer_deleter): New struct.
8338         (Py_buffer_up): New typedef.
8339
8340 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8341
8342         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8343         instead of releasing ownership.
8344
8345 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8346
8347         * dwarf2read.c (open_and_init_dwp_file): Call
8348         elf_numsections instead of bfd_count_sections to initialize
8349         dwp_file->num_sections.
8350
8351 2019-02-25  Tom Tromey  <tromey@adacore.com>
8352
8353         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8354
8355 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8356
8357         * gcore.in: Add '--readnever' option when invoking GDB.
8358
8359 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8360
8361         * MAINTAINERS: Update my email address.
8362
8363 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8364
8365         * build-id.c (build_id_to_debug_bfd_1): New function.
8366         (build_id_to_debug_bfd): Look for separate debug file in
8367         sysroot.
8368
8369 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8370
8371         * gdbarch.sh: Update the copyright year range that is placed into
8372         generated files.
8373
8374 2019-02-22  Keith Seitz  <keiths@redhat.com>
8375
8376         PR symtab/23853
8377         * linespec.c (create_sals_line_offset): Search for the default
8378         symtab's filename instead of its fullname.
8379
8380 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8381
8382         * NEWS: Update style defaults.
8383
8384 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8385
8386         * main.c (captured_main_1): Disable styling in batch mode.
8387
8388 2019-02-20  Tom Tromey  <tom@tromey.com>
8389
8390         * symtab.c (symtab_symbol_info): Fix typos.
8391
8392 2019-02-20  Tom Tromey  <tromey@adacore.com>
8393
8394         * findcmd.c (_initialize_mem_search): Use upper case for
8395         metasyntactic variables.
8396
8397 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8398
8399         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8400         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8401
8402 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8403
8404         * top.h (source_file_name): Change to std::string.
8405         * top.c (source_file_name): Likewise.
8406         (command_line_input): Adjust.
8407         * cli/cli-script.c (script_from_file): Adjust.
8408
8409 2019-02-19  Tom Tromey  <tromey@adacore.com>
8410
8411         * ravenscar-thread.c
8412         (ravenscar_thread_target::update_thread_list): Don't call
8413         ada_build_task_list.
8414         * ada-lang.h (ada_build_task_list): Don't declare.
8415         * ada-tasks.c (struct ada_tasks_inferior_data)
8416         <task_list_valid_p>: Now bool.
8417         (read_known_tasks, ada_task_list_changed)
8418         (ada_tasks_invalidate_inferior_data): Update.
8419         (read_known_tasks_array): Return bool.
8420         (read_known_tasks_list): Likewise.
8421         (read_known_tasks): Return void.
8422         (ada_build_task_list): Now static.
8423
8424 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8425
8426         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8427         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8428
8429 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8430
8431         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8432         variant for ada_tasks_pspace_data_handle and
8433         ada_tasks_inferior_data_handle.
8434         (ada_tasks_pspace_data_cleanup): New function.
8435         (ada_tasks_inferior_data_cleanup): New function.
8436
8437 2019-02-17  Tom Tromey  <tom@tromey.com>
8438
8439         * macrotab.h (macro_source_fullname): Return a std::string.
8440         * macrotab.c (macro_include, check_for_redefinition)
8441         (macro_undef, macro_lookup_definition, foreach_macro)
8442         (foreach_macro_in_scope): Update.
8443         (macro_source_fullname): Return a std::string.
8444         * macrocmd.c (show_pp_source_pos): Update.
8445
8446 2019-02-17  Tom Tromey  <tom@tromey.com>
8447
8448         * macrocmd.c (show_pp_source_pos): Style the file names.
8449
8450 2019-02-17  Tom Tromey  <tom@tromey.com>
8451
8452         PR tui/24197:
8453         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8454
8455 2019-02-17  Tom Tromey  <tom@tromey.com>
8456
8457         * ada-lang.c (user_select_syms): Use filtered printing.
8458         * utils.c (wrap_style): New global.
8459         (desired_style): Remove.
8460         (emit_style_escape): Add stream parameter.
8461         (set_output_style, reset_terminal_style, prompt_for_continue):
8462         Update.
8463         (flush_wrap_buffer): Only flush gdb_stdout.
8464         (wrap_here): Set wrap_style.
8465         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8466         treat escape sequences as a character.  Change when wrap buffer is
8467         flushed.
8468         (fputs_styled): Do not set the output style when the default is
8469         requested.
8470         * ui-style.h (struct ui_file_style) <is_default>: New method.
8471         * source.c (print_source_lines_base): Emit escape sequences in one
8472         piece.
8473
8474 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8475
8476         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8477         integers and enumeration types.
8478
8479 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8480
8481         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8482         instead of lookup_symbol_in_language
8483         (do_exact_match): New function.
8484         (ada_get_symbol_name_matcher): Return do_exact_match when
8485         doing a verbatim match.
8486
8487 2019-02-15  Tom Tromey  <tromey@adacore.com>
8488
8489         * ravenscar-thread.c (ravenscar_thread_target::resume)
8490         (ravenscar_thread_target::wait): Special case wildcard requests.
8491
8492 2019-02-15  Tom Tromey  <tromey@adacore.com>
8493
8494         * ravenscar-thread.c (base_ptid): Remove.
8495         (struct ravenscar_thread_target) <close>: New method.
8496         <m_base_ptid>: New member.
8497         <update_inferior_ptid, active_task, task_is_currently_active,
8498         runtime_initialized>: Declare methods.
8499         <ravenscar_thread_target>: Add constructor.
8500         (ravenscar_thread_target::task_is_currently_active)
8501         (ravenscar_thread_target::update_inferior_ptid)
8502         (ravenscar_runtime_initialized): Rename.  Now methods.
8503         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8504         (ravenscar_thread_target::update_thread_list): Update.
8505         (ravenscar_thread_target::active_task): Now method.
8506         (ravenscar_thread_target::store_registers)
8507         (ravenscar_thread_target::prepare_to_store)
8508         (ravenscar_thread_target::prepare_to_store)
8509         (ravenscar_thread_target::mourn_inferior): Update.
8510         (ravenscar_inferior_created): Use "new" to create target.
8511         (ravenscar_thread_target::get_ada_task_ptid): Update.
8512         (_initialize_ravenscar): Don't initialize base_ptid.
8513         (ravenscar_ops): Remove global.
8514
8515 2019-02-15  Tom Tromey  <tromey@adacore.com>
8516
8517         * target.h (push_target): Declare new overload.
8518         * target.c (push_target): New overload, taking an rvalue reference.
8519         * remote.c (remote_target::open_1): Use push_target overload.
8520         * corelow.c (core_target_open): Use push_target overload.
8521
8522 2019-02-15  Tom Tromey  <tromey@adacore.com>
8523
8524         * ravenscar-thread.c (is_ravenscar_task)
8525         (ravenscar_task_is_currently_active): Return bool.
8526         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8527         (_initialize_ravenscar): Remove "(void)".
8528         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8529         Return bool.
8530
8531 2019-02-15  Tom Tromey  <tromey@adacore.com>
8532
8533         * ravenscar-thread.c (ravenscar_runtime_initializer)
8534         (has_ravenscar_runtime, get_running_thread_id)
8535         (ravenscar_thread_target::resume): Fix indentation.
8536
8537 2019-02-15  Tom Tromey  <tromey@adacore.com>
8538
8539         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8540         from ravenscar_arch_ops.
8541         (sparc_ravenscar_ops::fetch_registers)
8542         (sparc_ravenscar_ops::store_registers): Now methods.
8543         (sparc_ravenscar_prepare_to_store): Remove.
8544         (sparc_ravenscar_ops): Redefine.
8545         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8546         methods and destructor.  Remove members.
8547         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8548         (ravenscar_thread_target::store_registers)
8549         (ravenscar_thread_target::prepare_to_store): Update.
8550         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8551         Remove.
8552         (struct ppc_ravenscar_powerpc_ops): Derive from
8553         ravenscar_arch_ops.
8554         (ppc_ravenscar_powerpc_ops::fetch_registers)
8555         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8556         (ppc_ravenscar_powerpc_ops): Redefine.
8557         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8558         (ppc_ravenscar_e500_ops::fetch_registers)
8559         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8560         (ppc_ravenscar_e500_ops): Redefine.
8561         * aarch64-ravenscar-thread.c
8562         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8563         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8564         (aarch64_ravenscar_fetch_registers)
8565         (aarch64_ravenscar_store_registers): Now methods.
8566         (aarch64_ravenscar_ops): Redefine.
8567
8568 2019-02-15  Tom Tromey  <tromey@adacore.com>
8569
8570         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8571         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8572         (ravenscar_thread_target::stopped_by_watchpoint)
8573         (ravenscar_thread_target::stopped_data_address)
8574         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8575
8576 2019-02-15  Tom Tromey  <tromey@adacore.com>
8577
8578         * ravenscar-thread.c: Fix some typos.
8579
8580 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8581             Tom Tromey  <tromey@adacore.com>
8582
8583         * ada-lang.c (ada_exception_sal): Change addr_string to a
8584         std::string.
8585         (create_ada_exception_catchpoint): Update.
8586
8587 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8588             Tom Tromey  <tromey@adacore.com>
8589
8590         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8591         (bp_location_ops): Remove.
8592         (base_breakpoint_allocate_location): Update.
8593         (free_bp_location): Update.
8594         * ada-lang.c (class ada_catchpoint_location)
8595         <ada_catchpoint_location>: Remove ops parameter.
8596         (ada_catchpoint_location_dtor): Remove.
8597         (ada_catchpoint_location_ops): Remove.
8598         (allocate_location_exception): Update.
8599         * breakpoint.h (struct bp_location_ops): Remove.
8600         (class bp_location) <bp_location>: Remove bp_location_ops
8601         parameter.
8602         <~bp_location>: Add destructor.
8603         <ops>: Remove.
8604
8605 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8606             Pedro Alves  <palves@redhat.com>
8607
8608         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8609         'PATH_MAX'.
8610
8611 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8612             Samuel Thibault  <samuel.thibault@gnu.org>
8613             Thomas Schwinge  <thomas@codesourcery.com>
8614
8615         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8616         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8617
8618 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8619
8620         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8621         (check_empty): Use "const char *".
8622
8623         * gnu-nat.c (gnu_nat_target::detach): Instead of
8624         'detach_inferior (pid)' call
8625         'detach_inferior (find_inferior_pid (pid))'.
8626
8627         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8628         'nat/fork-inferior.o'.
8629         * gnu-nat.c: #include "nat/fork-inferior.h".
8630
8631         * gnu-nat.c (gnu_nat_target::detach): Instead of
8632         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8633         * gnu-nat.h: #include "inf-child.h".
8634         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8635         'i386_gnu_nat_target::fetch_registers'.
8636         (gnu_store_registers): Rename/move to
8637         'i386_gnu_nat_target::store_registers'.
8638
8639         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8640         * gnu-nat.h (mach_thread_info): New function.
8641         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8642
8643         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8644
8645 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8646
8647         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8648
8649 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8650
8651         * windows-nat.c (windows_add_thread): Add new parameter
8652         "main_thread_p" with default value set to false.  Update
8653         function documentation as well as all callers.
8654         (windows_delete_thread): Likewise.
8655         (fake_create_process): Update call to windows_add_thread.
8656         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8657         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8658         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8659         call to windows_delete_thread.
8660
8661 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8662
8663         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8664
8665 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8666
8667         * symfile.c (find_separate_debug_file): Use canonical path of
8668         sysroot with child_path instead of gdb_sysroot if it is valid.
8669
8670 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8671
8672         * symfile.c (find_separate_debug_file): Use child_path to
8673         determine if an object file is under a sysroot.
8674
8675 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8676
8677         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8678         unittests/child-path-selftests.c.
8679         * common/pathstuff.c (child_path): New function.
8680         * common/pathstuff.h (child_path): New prototype.
8681         * unittests/child-path-selftests.c: New file.
8682
8683 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8684
8685         * symfile.c (find_separate_debug_file): Look for separate debug
8686         files in debug directories under the sysroot.
8687
8688 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8689
8690         * symtab.h (struct minimal_symbol data_p): New const method.
8691         (struct minimal_symbol text_p): Likewise.
8692         * symtab.c (output_source_filename): Use file name style
8693         to print file name.
8694         (print_symbol_info): Likewise.
8695         (print_msymbol_info): Use address style to print addresses.
8696         Use function name style to print executable text symbols.
8697         (expand_symtab_containing_pc): Use data_p.
8698         (find_pc_sect_compunit_symtab): Likewise.
8699
8700 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8701
8702         * breakpoint.c (describe_other_breakpoints): Use address style
8703         to print addresses.
8704         (say_where): Likewise.
8705
8706 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8707
8708         * ada-typeprint.c (print_func_type): Print function name
8709         style to print function name.
8710         * c-typeprint.c (c_print_type_1): Likewise.
8711
8712 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8713
8714         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8715         for execve.
8716
8717 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8718
8719         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8720         type_stack.
8721
8722 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8723
8724         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8725         TYPE_CODE_REF types.
8726
8727 2019-02-08  Jim Wilson  <jimw@sifive.com>
8728
8729         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8730         (riscv_linux_fregset): New.
8731         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8732
8733 2019-02-07  Tom Tromey  <tom@tromey.com>
8734
8735         * thread.c (thread_cancel_execution_command): Update.
8736         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8737         methods.
8738         (struct thread_fsm_ops): Remove.
8739         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8740         (thread_fsm_should_stop, thread_fsm_return_value)
8741         (thread_fsm_set_finished, thread_fsm_finished_p)
8742         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8743         Don't declare.
8744         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8745         * infrun.c (clear_proceed_status_thread)
8746         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8747         (print_stop_event): Update.
8748         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8749         Add constructor.
8750         (step_command_fsm_ops): Remove.
8751         (new_step_command_fsm): Remove.
8752         (step_1): Update.
8753         (step_command_fsm::should_stop): Rename from
8754         step_command_fsm_should_stop.
8755         (step_command_fsm::clean_up): Rename from
8756         step_command_fsm_clean_up.
8757         (step_command_fsm::do_async_reply_reason): Rename from
8758         step_command_fsm_async_reply_reason.
8759         (struct until_next_fsm): Inherit from thread_fsm.  Add
8760         constructor.
8761         (until_next_fsm_ops): Remove.
8762         (new_until_next_fsm): Remove.
8763         (until_next_fsm::should_stop): Rename from
8764         until_next_fsm_should_stop.
8765         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8766         (until_next_fsm::do_async_reply_reason): Rename from
8767         until_next_fsm_async_reply_reason.
8768         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8769         constructor.  Change type of breakpoint.
8770         (finish_command_fsm_ops): Remove.
8771         (new_finish_command_fsm): Remove.
8772         (finish_command_fsm::should_stop): Rename from
8773         finish_command_fsm_should_stop.
8774         (finish_command_fsm::clean_up): Rename from
8775         finish_command_fsm_clean_up.
8776         (finish_command_fsm::return_value): Rename from
8777         finish_command_fsm_return_value.
8778         (finish_command_fsm::do_async_reply_reason): Rename from
8779         finish_command_fsm_async_reply_reason.
8780         (finish_command): Update.
8781         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8782         Add constructor.
8783         (call_thread_fsm_ops): Remove.
8784         (call_thread_fsm::call_thread_fsm): Rename from
8785         new_call_thread_fsm.
8786         (call_thread_fsm::should_stop): Rename from
8787         call_thread_fsm_should_stop.
8788         (call_thread_fsm::should_notify_stop): Rename from
8789         call_thread_fsm_should_notify_stop.
8790         (run_inferior_call, call_function_by_hand_dummy): Update.
8791         * cli/cli-interp.c (should_print_stop_to_console): Update.
8792         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8793         Add constructor.  Change type of location_breakpoint,
8794         caller_breakpoint.
8795         (until_break_fsm_ops): Remove.
8796         (new_until_break_fsm): Remove.
8797         (until_break_fsm::should_stop): Rename from
8798         until_break_fsm_should_stop.
8799         (until_break_fsm::clean_up): Rename from
8800         until_break_fsm_clean_up.
8801         (until_break_fsm::do_async_reply_reason): Rename from
8802         until_break_fsm_async_reply_reason.
8803         (until_break_command): Update.
8804         * thread-fsm.c: Remove.
8805         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8806
8807 2019-02-07  Tom Tromey  <tom@tromey.com>
8808
8809         * yy-remap.h: Add include guard.
8810         * xtensa-tdep.h: Add include guard.
8811         * xcoffread.h: Rename include guard.
8812         * varobj-iter.h: Add include guard.
8813         * tui/tui.h: Rename include guard.
8814         * tui/tui-winsource.h: Rename include guard.
8815         * tui/tui-wingeneral.h: Rename include guard.
8816         * tui/tui-windata.h: Rename include guard.
8817         * tui/tui-win.h: Rename include guard.
8818         * tui/tui-stack.h: Rename include guard.
8819         * tui/tui-source.h: Rename include guard.
8820         * tui/tui-regs.h: Rename include guard.
8821         * tui/tui-out.h: Rename include guard.
8822         * tui/tui-layout.h: Rename include guard.
8823         * tui/tui-io.h: Rename include guard.
8824         * tui/tui-hooks.h: Rename include guard.
8825         * tui/tui-file.h: Rename include guard.
8826         * tui/tui-disasm.h: Rename include guard.
8827         * tui/tui-data.h: Rename include guard.
8828         * tui/tui-command.h: Rename include guard.
8829         * tic6x-tdep.h: Add include guard.
8830         * target/waitstatus.h: Rename include guard.
8831         * target/wait.h: Rename include guard.
8832         * target/target.h: Rename include guard.
8833         * target/resume.h: Rename include guard.
8834         * target-float.h: Rename include guard.
8835         * stabsread.h: Add include guard.
8836         * rs6000-tdep.h: Add include guard.
8837         * riscv-fbsd-tdep.h: Add include guard.
8838         * regformats/regdef.h: Rename include guard.
8839         * record.h: Rename include guard.
8840         * python/python.h: Rename include guard.
8841         * python/python-internal.h: Rename include guard.
8842         * python/py-stopevent.h: Rename include guard.
8843         * python/py-ref.h: Rename include guard.
8844         * python/py-record.h: Rename include guard.
8845         * python/py-record-full.h: Rename include guard.
8846         * python/py-record-btrace.h: Rename include guard.
8847         * python/py-instruction.h: Rename include guard.
8848         * python/py-events.h: Rename include guard.
8849         * python/py-event.h: Rename include guard.
8850         * procfs.h: Add include guard.
8851         * proc-utils.h: Add include guard.
8852         * p-lang.h: Add include guard.
8853         * or1k-tdep.h: Rename include guard.
8854         * observable.h: Rename include guard.
8855         * nto-tdep.h: Rename include guard.
8856         * nat/x86-linux.h: Rename include guard.
8857         * nat/x86-linux-dregs.h: Rename include guard.
8858         * nat/x86-gcc-cpuid.h: Add include guard.
8859         * nat/x86-dregs.h: Rename include guard.
8860         * nat/x86-cpuid.h: Rename include guard.
8861         * nat/ppc-linux.h: Rename include guard.
8862         * nat/mips-linux-watch.h: Rename include guard.
8863         * nat/linux-waitpid.h: Rename include guard.
8864         * nat/linux-ptrace.h: Rename include guard.
8865         * nat/linux-procfs.h: Rename include guard.
8866         * nat/linux-osdata.h: Rename include guard.
8867         * nat/linux-nat.h: Rename include guard.
8868         * nat/linux-namespaces.h: Rename include guard.
8869         * nat/linux-btrace.h: Rename include guard.
8870         * nat/glibc_thread_db.h: Rename include guard.
8871         * nat/gdb_thread_db.h: Rename include guard.
8872         * nat/gdb_ptrace.h: Rename include guard.
8873         * nat/fork-inferior.h: Rename include guard.
8874         * nat/amd64-linux-siginfo.h: Rename include guard.
8875         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8876         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8877         * nat/aarch64-linux.h: Rename include guard.
8878         * nat/aarch64-linux-hw-point.h: Rename include guard.
8879         * mn10300-tdep.h: Add include guard.
8880         * mips-linux-tdep.h: Add include guard.
8881         * mi/mi-parse.h: Rename include guard.
8882         * mi/mi-out.h: Rename include guard.
8883         * mi/mi-main.h: Rename include guard.
8884         * mi/mi-interp.h: Rename include guard.
8885         * mi/mi-getopt.h: Rename include guard.
8886         * mi/mi-console.h: Rename include guard.
8887         * mi/mi-common.h: Rename include guard.
8888         * mi/mi-cmds.h: Rename include guard.
8889         * mi/mi-cmd-break.h: Rename include guard.
8890         * m2-lang.h: Add include guard.
8891         * location.h: Rename include guard.
8892         * linux-record.h: Rename include guard.
8893         * linux-nat.h: Add include guard.
8894         * linux-fork.h: Add include guard.
8895         * i386-darwin-tdep.h: Rename include guard.
8896         * hppa-linux-offsets.h: Add include guard.
8897         * guile/guile.h: Rename include guard.
8898         * guile/guile-internal.h: Rename include guard.
8899         * gnu-nat.h: Rename include guard.
8900         * gdb-stabs.h: Rename include guard.
8901         * frv-tdep.h: Add include guard.
8902         * f-lang.h: Add include guard.
8903         * event-loop.h: Add include guard.
8904         * darwin-nat.h: Rename include guard.
8905         * cp-abi.h: Rename include guard.
8906         * config/sparc/nm-sol2.h: Rename include guard.
8907         * config/nm-nto.h: Rename include guard.
8908         * config/nm-linux.h: Add include guard.
8909         * config/i386/nm-i386gnu.h: Rename include guard.
8910         * config/djgpp/nl_types.h: Rename include guard.
8911         * config/djgpp/langinfo.h: Rename include guard.
8912         * compile/gcc-cp-plugin.h: Add include guard.
8913         * compile/gcc-c-plugin.h: Add include guard.
8914         * compile/compile.h: Rename include guard.
8915         * compile/compile-object-run.h: Rename include guard.
8916         * compile/compile-object-load.h: Rename include guard.
8917         * compile/compile-internal.h: Rename include guard.
8918         * compile/compile-cplus.h: Rename include guard.
8919         * compile/compile-c.h: Rename include guard.
8920         * common/xml-utils.h: Rename include guard.
8921         * common/x86-xstate.h: Rename include guard.
8922         * common/version.h: Rename include guard.
8923         * common/vec.h: Rename include guard.
8924         * common/tdesc.h: Rename include guard.
8925         * common/selftest.h: Rename include guard.
8926         * common/scoped_restore.h: Rename include guard.
8927         * common/scoped_mmap.h: Rename include guard.
8928         * common/scoped_fd.h: Rename include guard.
8929         * common/safe-iterator.h: Rename include guard.
8930         * common/run-time-clock.h: Rename include guard.
8931         * common/refcounted-object.h: Rename include guard.
8932         * common/queue.h: Rename include guard.
8933         * common/ptid.h: Rename include guard.
8934         * common/print-utils.h: Rename include guard.
8935         * common/preprocessor.h: Rename include guard.
8936         * common/pathstuff.h: Rename include guard.
8937         * common/observable.h: Rename include guard.
8938         * common/netstuff.h: Rename include guard.
8939         * common/job-control.h: Rename include guard.
8940         * common/host-defs.h: Rename include guard.
8941         * common/gdb_wait.h: Rename include guard.
8942         * common/gdb_vecs.h: Rename include guard.
8943         * common/gdb_unlinker.h: Rename include guard.
8944         * common/gdb_unique_ptr.h: Rename include guard.
8945         * common/gdb_tilde_expand.h: Rename include guard.
8946         * common/gdb_sys_time.h: Rename include guard.
8947         * common/gdb_string_view.h: Rename include guard.
8948         * common/gdb_splay_tree.h: Rename include guard.
8949         * common/gdb_setjmp.h: Rename include guard.
8950         * common/gdb_ref_ptr.h: Rename include guard.
8951         * common/gdb_optional.h: Rename include guard.
8952         * common/gdb_locale.h: Rename include guard.
8953         * common/gdb_assert.h: Rename include guard.
8954         * common/filtered-iterator.h: Rename include guard.
8955         * common/filestuff.h: Rename include guard.
8956         * common/fileio.h: Rename include guard.
8957         * common/environ.h: Rename include guard.
8958         * common/common-utils.h: Rename include guard.
8959         * common/common-types.h: Rename include guard.
8960         * common/common-regcache.h: Rename include guard.
8961         * common/common-inferior.h: Rename include guard.
8962         * common/common-gdbthread.h: Rename include guard.
8963         * common/common-exceptions.h: Rename include guard.
8964         * common/common-defs.h: Rename include guard.
8965         * common/common-debug.h: Rename include guard.
8966         * common/cleanups.h: Rename include guard.
8967         * common/buffer.h: Rename include guard.
8968         * common/btrace-common.h: Rename include guard.
8969         * common/break-common.h: Rename include guard.
8970         * cli/cli-utils.h: Rename include guard.
8971         * cli/cli-style.h: Rename include guard.
8972         * cli/cli-setshow.h: Rename include guard.
8973         * cli/cli-script.h: Rename include guard.
8974         * cli/cli-interp.h: Rename include guard.
8975         * cli/cli-decode.h: Rename include guard.
8976         * cli/cli-cmds.h: Rename include guard.
8977         * charset-list.h: Add include guard.
8978         * buildsym-legacy.h: Rename include guard.
8979         * bfin-tdep.h: Add include guard.
8980         * ax.h: Rename include guard.
8981         * arm-linux-tdep.h: Add include guard.
8982         * arm-fbsd-tdep.h: Add include guard.
8983         * arch/xtensa.h: Rename include guard.
8984         * arch/tic6x.h: Add include guard.
8985         * arch/i386.h: Add include guard.
8986         * arch/arm.h: Rename include guard.
8987         * arch/arm-linux.h: Rename include guard.
8988         * arch/arm-get-next-pcs.h: Rename include guard.
8989         * arch/amd64.h: Add include guard.
8990         * arch/aarch64-insn.h: Rename include guard.
8991         * arch-utils.h: Rename include guard.
8992         * annotate.h: Add include guard.
8993         * amd64-darwin-tdep.h: Rename include guard.
8994         * aarch64-linux-tdep.h: Add include guard.
8995         * aarch64-fbsd-tdep.h: Add include guard.
8996         * aarch32-linux-nat.h: Add include guard.
8997
8998 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8999
9000         * macrotab.c (macro_define_internal): New function that
9001         factorizes macro_define_object_internal and macro_define_function
9002         code.
9003         (macro_define_object_internal): Use macro_define_internal.
9004         (macro_define_function): Likewise.
9005
9006 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9007
9008         * macrocmd.c (extract_identifier): Return
9009         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9010         callers.
9011
9012 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9013
9014         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9015
9016 2019-02-05  Tom Tromey  <tom@tromey.com>
9017
9018         * target.c (target_stack::unpush): Move assertion earlier.
9019
9020 2019-01-30  Tom Tromey  <tom@tromey.com>
9021
9022         PR python/23615:
9023         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9024         (gdbpy_parse_and_eval): Likewise.
9025         * python/python-internal.h (gdbpy_allow_threads): New class.
9026
9027 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9028
9029         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9030         (aarch64_fbsd_fpregmap): Move earlier.
9031         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9032         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9033         instead of individual calls to trad_frame_set_reg_addr.
9034         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9035         earlier.
9036         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9037         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9038         instead of individual calls to trad_frame_set_reg_addr.
9039
9040 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9041
9042         * CONTRIBUTE: Replace contribution list with wiki link.
9043
9044 2019-01-25  Tom Tromey  <tom@tromey.com>
9045
9046         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9047
9048 2019-01-25  Tom Tromey  <tom@tromey.com>
9049
9050         * xtensa-linux-nat.c: Fix common/ includes.
9051         * xml-support.h: Fix common/ includes.
9052         * xml-support.c: Fix common/ includes.
9053         * x86-linux-nat.c: Fix common/ includes.
9054         * windows-nat.c: Fix common/ includes.
9055         * varobj.h: Fix common/ includes.
9056         * varobj.c: Fix common/ includes.
9057         * value.c: Fix common/ includes.
9058         * valops.c: Fix common/ includes.
9059         * utils.c: Fix common/ includes.
9060         * unittests/xml-utils-selftests.c: Fix common/ includes.
9061         * unittests/utils-selftests.c: Fix common/ includes.
9062         * unittests/unpack-selftests.c: Fix common/ includes.
9063         * unittests/tracepoint-selftests.c: Fix common/ includes.
9064         * unittests/style-selftests.c: Fix common/ includes.
9065         * unittests/string_view-selftests.c: Fix common/ includes.
9066         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9067         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9068         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9069         * unittests/rsp-low-selftests.c: Fix common/ includes.
9070         * unittests/parse-connection-spec-selftests.c: Fix common/
9071         includes.
9072         * unittests/optional-selftests.c: Fix common/ includes.
9073         * unittests/offset-type-selftests.c: Fix common/ includes.
9074         * unittests/observable-selftests.c: Fix common/ includes.
9075         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9076         * unittests/memrange-selftests.c: Fix common/ includes.
9077         * unittests/memory-map-selftests.c: Fix common/ includes.
9078         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9079         * unittests/function-view-selftests.c: Fix common/ includes.
9080         * unittests/environ-selftests.c: Fix common/ includes.
9081         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9082         * unittests/common-utils-selftests.c: Fix common/ includes.
9083         * unittests/cli-utils-selftests.c: Fix common/ includes.
9084         * unittests/array-view-selftests.c: Fix common/ includes.
9085         * ui-file.c: Fix common/ includes.
9086         * tui/tui-io.c: Fix common/ includes.
9087         * tracepoint.h: Fix common/ includes.
9088         * tracepoint.c: Fix common/ includes.
9089         * tracefile-tfile.c: Fix common/ includes.
9090         * top.h: Fix common/ includes.
9091         * top.c: Fix common/ includes.
9092         * thread.c: Fix common/ includes.
9093         * target/waitstatus.h: Fix common/ includes.
9094         * target/waitstatus.c: Fix common/ includes.
9095         * target.h: Fix common/ includes.
9096         * target.c: Fix common/ includes.
9097         * target-memory.c: Fix common/ includes.
9098         * target-descriptions.c: Fix common/ includes.
9099         * symtab.h: Fix common/ includes.
9100         * symfile.c: Fix common/ includes.
9101         * stap-probe.c: Fix common/ includes.
9102         * spu-linux-nat.c: Fix common/ includes.
9103         * sparc-nat.c: Fix common/ includes.
9104         * source.c: Fix common/ includes.
9105         * solib.c: Fix common/ includes.
9106         * solib-target.c: Fix common/ includes.
9107         * ser-unix.c: Fix common/ includes.
9108         * ser-tcp.c: Fix common/ includes.
9109         * ser-pipe.c: Fix common/ includes.
9110         * ser-base.c: Fix common/ includes.
9111         * selftest-arch.c: Fix common/ includes.
9112         * s12z-tdep.c: Fix common/ includes.
9113         * rust-exp.y: Fix common/ includes.
9114         * rs6000-aix-tdep.c: Fix common/ includes.
9115         * riscv-tdep.c: Fix common/ includes.
9116         * remote.c: Fix common/ includes.
9117         * remote-notif.h: Fix common/ includes.
9118         * remote-fileio.h: Fix common/ includes.
9119         * remote-fileio.c: Fix common/ includes.
9120         * regcache.h: Fix common/ includes.
9121         * regcache.c: Fix common/ includes.
9122         * record-btrace.c: Fix common/ includes.
9123         * python/python.c: Fix common/ includes.
9124         * python/py-type.c: Fix common/ includes.
9125         * python/py-inferior.c: Fix common/ includes.
9126         * progspace.h: Fix common/ includes.
9127         * producer.c: Fix common/ includes.
9128         * procfs.c: Fix common/ includes.
9129         * proc-api.c: Fix common/ includes.
9130         * printcmd.c: Fix common/ includes.
9131         * ppc-linux-nat.c: Fix common/ includes.
9132         * parser-defs.h: Fix common/ includes.
9133         * osdata.c: Fix common/ includes.
9134         * obsd-nat.c: Fix common/ includes.
9135         * nat/x86-linux.c: Fix common/ includes.
9136         * nat/x86-linux-dregs.c: Fix common/ includes.
9137         * nat/x86-dregs.h: Fix common/ includes.
9138         * nat/x86-dregs.c: Fix common/ includes.
9139         * nat/ppc-linux.c: Fix common/ includes.
9140         * nat/mips-linux-watch.h: Fix common/ includes.
9141         * nat/mips-linux-watch.c: Fix common/ includes.
9142         * nat/linux-waitpid.c: Fix common/ includes.
9143         * nat/linux-ptrace.h: Fix common/ includes.
9144         * nat/linux-ptrace.c: Fix common/ includes.
9145         * nat/linux-procfs.c: Fix common/ includes.
9146         * nat/linux-personality.c: Fix common/ includes.
9147         * nat/linux-osdata.c: Fix common/ includes.
9148         * nat/linux-namespaces.c: Fix common/ includes.
9149         * nat/linux-btrace.h: Fix common/ includes.
9150         * nat/linux-btrace.c: Fix common/ includes.
9151         * nat/fork-inferior.c: Fix common/ includes.
9152         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9153         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9154         * nat/aarch64-linux.c: Fix common/ includes.
9155         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9156         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9157         * namespace.h: Fix common/ includes.
9158         * mips-linux-tdep.c: Fix common/ includes.
9159         * minsyms.c: Fix common/ includes.
9160         * mi/mi-parse.h: Fix common/ includes.
9161         * mi/mi-main.c: Fix common/ includes.
9162         * mi/mi-cmd-env.c: Fix common/ includes.
9163         * memrange.h: Fix common/ includes.
9164         * memattr.c: Fix common/ includes.
9165         * maint.h: Fix common/ includes.
9166         * maint.c: Fix common/ includes.
9167         * main.c: Fix common/ includes.
9168         * machoread.c: Fix common/ includes.
9169         * location.c: Fix common/ includes.
9170         * linux-thread-db.c: Fix common/ includes.
9171         * linux-nat.c: Fix common/ includes.
9172         * linux-fork.c: Fix common/ includes.
9173         * inline-frame.c: Fix common/ includes.
9174         * infrun.c: Fix common/ includes.
9175         * inflow.c: Fix common/ includes.
9176         * inferior.h: Fix common/ includes.
9177         * inferior.c: Fix common/ includes.
9178         * infcmd.c: Fix common/ includes.
9179         * inf-ptrace.c: Fix common/ includes.
9180         * inf-child.c: Fix common/ includes.
9181         * ia64-linux-nat.c: Fix common/ includes.
9182         * i387-tdep.c: Fix common/ includes.
9183         * i386-tdep.c: Fix common/ includes.
9184         * i386-linux-tdep.c: Fix common/ includes.
9185         * i386-linux-nat.c: Fix common/ includes.
9186         * i386-go32-tdep.c: Fix common/ includes.
9187         * i386-fbsd-tdep.c: Fix common/ includes.
9188         * i386-fbsd-nat.c: Fix common/ includes.
9189         * guile/scm-type.c: Fix common/ includes.
9190         * guile/guile.c: Fix common/ includes.
9191         * go32-nat.c: Fix common/ includes.
9192         * gnu-nat.c: Fix common/ includes.
9193         * gdbthread.h: Fix common/ includes.
9194         * gdbarch-selftests.c: Fix common/ includes.
9195         * gdb_usleep.c: Fix common/ includes.
9196         * gdb_select.h: Fix common/ includes.
9197         * gdb_bfd.c: Fix common/ includes.
9198         * gcore.c: Fix common/ includes.
9199         * fork-child.c: Fix common/ includes.
9200         * findvar.c: Fix common/ includes.
9201         * fbsd-nat.c: Fix common/ includes.
9202         * event-top.c: Fix common/ includes.
9203         * event-loop.c: Fix common/ includes.
9204         * dwarf2read.c: Fix common/ includes.
9205         * dwarf2loc.c: Fix common/ includes.
9206         * dwarf2-frame.c: Fix common/ includes.
9207         * dwarf-index-cache.c: Fix common/ includes.
9208         * dtrace-probe.c: Fix common/ includes.
9209         * disasm-selftests.c: Fix common/ includes.
9210         * defs.h: Fix common/ includes.
9211         * csky-tdep.c: Fix common/ includes.
9212         * cp-valprint.c: Fix common/ includes.
9213         * cp-support.h: Fix common/ includes.
9214         * cp-support.c: Fix common/ includes.
9215         * corelow.c: Fix common/ includes.
9216         * completer.h: Fix common/ includes.
9217         * completer.c: Fix common/ includes.
9218         * compile/compile.c: Fix common/ includes.
9219         * compile/compile-loc2c.c: Fix common/ includes.
9220         * compile/compile-cplus-types.c: Fix common/ includes.
9221         * compile/compile-cplus-symbols.c: Fix common/ includes.
9222         * command.h: Fix common/ includes.
9223         * cli/cli-dump.c: Fix common/ includes.
9224         * cli/cli-cmds.c: Fix common/ includes.
9225         * charset.c: Fix common/ includes.
9226         * build-id.c: Fix common/ includes.
9227         * btrace.h: Fix common/ includes.
9228         * btrace.c: Fix common/ includes.
9229         * breakpoint.h: Fix common/ includes.
9230         * breakpoint.c: Fix common/ includes.
9231         * ax.h:
9232         (enum agent_op): Fix common/ includes.
9233         * ax-general.c (struct aop_map): Fix common/ includes.
9234         * ax-gdb.c: Fix common/ includes.
9235         * auxv.c: Fix common/ includes.
9236         * auto-load.c: Fix common/ includes.
9237         * arm-tdep.c: Fix common/ includes.
9238         * arch/riscv.c: Fix common/ includes.
9239         * arch/ppc-linux-common.c: Fix common/ includes.
9240         * arch/i386.c: Fix common/ includes.
9241         * arch/arm.c: Fix common/ includes.
9242         * arch/arm-linux.c: Fix common/ includes.
9243         * arch/arm-get-next-pcs.c: Fix common/ includes.
9244         * arch/amd64.c: Fix common/ includes.
9245         * arch/aarch64.c: Fix common/ includes.
9246         * arch/aarch64-insn.c: Fix common/ includes.
9247         * arch-utils.c: Fix common/ includes.
9248         * amd64-windows-tdep.c: Fix common/ includes.
9249         * amd64-tdep.c: Fix common/ includes.
9250         * amd64-sol2-tdep.c: Fix common/ includes.
9251         * amd64-obsd-tdep.c: Fix common/ includes.
9252         * amd64-nbsd-tdep.c: Fix common/ includes.
9253         * amd64-linux-tdep.c: Fix common/ includes.
9254         * amd64-linux-nat.c: Fix common/ includes.
9255         * amd64-fbsd-tdep.c: Fix common/ includes.
9256         * amd64-fbsd-nat.c: Fix common/ includes.
9257         * amd64-dicos-tdep.c: Fix common/ includes.
9258         * amd64-darwin-tdep.c: Fix common/ includes.
9259         * agent.c: Fix common/ includes.
9260         * ada-lang.h: Fix common/ includes.
9261         * ada-lang.c: Fix common/ includes.
9262         * aarch64-tdep.c: Fix common/ includes.
9263
9264 2019-01-25  Tom Tromey  <tom@tromey.com>
9265
9266         * common/create-version.sh: Use common/version.h.
9267
9268 2019-01-24  Pedro Alves  <palves@redhat.com>
9269
9270         * infrun.c (signal_stop, signal_print, signal_program)
9271         (signal_catch, signal_pass): Now arrays instead of pointers.
9272         (update_signals_program_target, do_target_resume)
9273         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9274         * linux-nat.c (linux_nat_target::pass_signals)
9275         (linux_nat_target::create_inferior, linux_nat_target::attach):
9276         Adjust.
9277         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9278         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9279         * procfs.c (procfs_target::pass_signals): Adjust.
9280         * record-full.c (record_full_target::resume): Adjust.
9281         * remote.c (remote_target::pass_signals)
9282         (remote_target::program_signals): Adjust.
9283         * target-debug.h (target_debug_print_signals): Now takes a
9284         gdb::array_view as parameter.  Adjust.
9285         * target.h (target_ops) <pass_signals, program_signals>: Replace
9286         pointer and length parameters with gdb::array_view.
9287         (target_pass_signals, target_program_signals): Likewise.
9288         * target-delegates.c: Regenerate.
9289
9290 2019-01-24  Pedro Alves  <palves@redhat.com>
9291
9292         * common/forward-scope-exit.h
9293         (forward_scope_exit::forward_scope_exit): Pass arguments to
9294         m_bind_function directly, instead of creating a std::bind and
9295         copying that.
9296
9297 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9298
9299         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9300         for static members.
9301         (pass_in_v_vfp_candidate): Likewise.
9302
9303 2019-01-23  Tom Tromey  <tom@tromey.com>
9304             Pedro Alves  <palves@redhat.com>
9305
9306         * regcache.c (class regcache_invalidator): Remove.
9307         (regcache::raw_write): Use make_scope_exit.
9308
9309 2019-01-23  Tom Tromey  <tom@tromey.com>
9310
9311         * ui-out.h (class ui_out_emit_type): Update comment.
9312
9313 2019-01-23  Tom Tromey  <tom@tromey.com>
9314
9315         * infrun.c (fetch_inferior_event): Update comment.
9316
9317 2019-01-23  Tom Tromey  <tom@tromey.com>
9318             Pedro Alves  <palves@redhat.com>
9319
9320         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9321         parameter.
9322         (fetch_inferior_event): Use SCOPE_EXIT.
9323
9324
9325 2019-01-23  Tom Tromey  <tom@tromey.com>
9326             Pedro Alves  <palves@redhat.com>
9327
9328         * infrun.c (disable_thread_events): Delete.
9329         (stop_all_threads): Use SCOPE_EXIT.
9330
9331 2019-01-23  Tom Tromey  <tom@tromey.com>
9332             Pedro Alves  <palves@redhat.com>
9333
9334         * symfile.c: Include forward-scope-exit.h.
9335         (clear_symtab_users_cleanup): Replace forward declaration with
9336         a FORWARD_SCOPE_EXIT.
9337         (syms_from_objfile_1): Use the forward_scope_exit and
9338         gdb::optional instead of cleanup_function.
9339         (reread_symbols): Use the forward_scope_exit instead of
9340         cleanup_function.
9341         (clear_symtab_users_cleanup): Remove function.
9342
9343 2019-01-23  Tom Tromey  <tom@tromey.com>
9344             Pedro Alves  <palves@redhat.com>
9345
9346         * linux-nat.c: Include scope-exit.h.
9347         (cleanup_target_stop): Remove.
9348         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9349         SCOPE_EXIT.
9350
9351 2019-01-23  Tom Tromey  <tom@tromey.com>
9352             Pedro Alves  <palves@redhat.com>
9353
9354         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9355         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9356
9357 2019-01-23  Tom Tromey  <tom@tromey.com>
9358             Andrew Burgess  <andrew.burgess@embecosm.com>
9359             Pedro Alves  <palves@redhat.com>
9360
9361         * infrun.c (fetch_inferior_event): Use scope_exit.
9362         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9363         * top.c (execute_command): Use scope_exit.
9364         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9365         * utils.c (do_bpstat_clear_actions_cleanup)
9366         (make_bpstat_clear_actions_cleanup): Remove.
9367
9368 2019-01-23  Tom Tromey  <tom@tromey.com>
9369             Pedro Alves  <palves@redhat.com>
9370
9371         * infrun.c: Include "common/scope-exit.h"
9372         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9373         (wait_for_inferior): Use SCOPE_EXIT.
9374         (fetch_inferior_event): Use scope_exit.
9375
9376 2019-01-23  Tom Tromey  <tom@tromey.com>
9377             Pedro Alves  <palves@redhat.com>
9378
9379         * breakpoint.c (create_breakpoint): Remove cleanup.
9380
9381 2019-01-23  Tom Tromey  <tom@tromey.com>
9382             Andrew Burgess  <andrew.burgess@embecosm.com>
9383             Pedro Alves  <palves@redhat.com>
9384
9385 2019-01-23  Pedro Alves  <palves@redhat.com>
9386
9387         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9388
9389 2019-01-23  Pedro Alves  <palves@redhat.com>
9390             Andrew Burgess  <andrew.burgess@embecosm.com>
9391
9392         * gdbthread.h: Include "common/forward-scope-exit.h".
9393         (scoped_finish_thread_state): Redefine custom class in terms of
9394         forward_scope_exit.
9395
9396 2019-01-23  Pedro Alves  <palves@redhat.com>
9397             Andrew Burgess  <andrew.burgess@embecosm.com>
9398
9399         * common/forward-scope-exit.h: New file.
9400
9401 2019-01-23  Pedro Alves  <palves@redhat.com>
9402             Andrew Burgess  <andrew.burgess@embecosm.com>
9403             Tom Tromey  <tom@tromey.com>
9404
9405         * common/scope-exit.h: New file.
9406
9407 2019-01-23  Pedro Alves  <palves@redhat.com>
9408
9409         * common/preprocessor.h (ESC): Rename to ...
9410         (ESC_PARENS): ... this.
9411         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9412         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9413
9414 2019-01-23  Tom Tromey  <tom@tromey.com>
9415
9416         * language.h (class scoped_switch_to_sym_language_if_auto):
9417         Initialize m_lang in both cases.
9418
9419 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9420
9421         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9422         with XCNEW.
9423
9424 2019-01-22  Tom Tromey  <tom@tromey.com>
9425
9426         * corelow.c: Do not include sys/file.h.
9427
9428 2019-01-22  Tom Tromey  <tom@tromey.com>
9429
9430         * tui/tui-wingeneral.h: Include gdb_curses.h.
9431
9432 2019-01-22  Tom Tromey  <tom@tromey.com>
9433
9434         * source-cache.h (class source_cache) <get_source_lines,
9435         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9436
9437 2019-01-22  Tom Tromey  <tom@tromey.com>
9438
9439         * remote-fileio.h (struct remote_target): Declare.
9440
9441 2019-01-22  Tom Tromey  <tom@tromey.com>
9442
9443         * python/py-arch.c: Do not include py-ref.h.
9444         * python/py-bpevent.c: Do not include py-ref.h.
9445         * python/py-cmd.c: Do not include py-ref.h.
9446         * python/py-continueevent.c: Do not include py-ref.h.
9447         * python/py-event.h: Do not include py-ref.h.
9448         * python/py-evtregistry.c: Do not include py-ref.h.
9449         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9450         * python/py-frame.c: Do not include py-ref.h.
9451         * python/py-framefilter.c: Do not include py-ref.h.
9452         * python/py-function.c: Do not include py-ref.h.
9453         * python/py-infevents.c: Do not include py-ref.h.
9454         * python/py-linetable.c: Do not include py-ref.h.
9455         * python/py-objfile.c: Do not include py-ref.h.
9456         * python/py-param.c: Do not include py-ref.h.
9457         * python/py-prettyprint.c: Do not include py-ref.h.
9458         * python/py-progspace.c: Do not include py-ref.h.
9459         * python/py-symbol.c: Do not include py-ref.h.
9460         * python/py-symtab.c: Do not include py-ref.h.
9461         * python/py-type.c: Do not include py-ref.h.
9462         * python/py-unwind.c: Do not include py-ref.h.
9463         * python/py-utils.c: Do not include py-ref.h.
9464         * python/py-value.c: Do not include py-ref.h.
9465         * python/py-varobj.c: Do not include py-ref.h.
9466         * python/py-xmethods.c: Do not include py-ref.h.
9467         * python/python.c: Do not include py-ref.h.
9468         * varobj.c: Do not include py-ref.h.
9469
9470 2019-01-22  Tom Tromey  <tom@tromey.com>
9471
9472         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9473         keyword for bcache.
9474
9475 2019-01-22  Tom Tromey  <tom@tromey.com>
9476
9477         * compile/compile-cplus-types.c: Remove a comment by #include.
9478
9479 2019-01-22  Tom Tromey  <tom@tromey.com>
9480
9481         * compile/gcc-c-plugin.h: Include compile-internal.h.
9482
9483 2019-01-22  Tom Tromey  <tom@tromey.com>
9484
9485         * stabsread.c (EXTERN): Do not define.
9486         (symnum, next_symbol_text_func, processing_gcc_compilation)
9487         (within_function, global_sym_chain, global_stabs)
9488         (previous_stab_code, this_object_header_files)
9489         (n_this_object_header_files)
9490         (n_allocated_this_object_header_files): Define.
9491         * stabsread.h (EXTERN): Never define.  Use "extern".
9492
9493 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9494
9495         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9496         history_value.
9497
9498 2019-01-21  Tom Tromey  <tom@tromey.com>
9499
9500         * ui-out.c: Fix includes.
9501         * tui/tui-source.c: Fix includes.
9502         * target.c: Fix includes.
9503         * remote.c: Fix includes.
9504         * regcache.c: Fix includes.
9505         * python/py-block.c: Fix includes.
9506         * printcmd.c: Fix includes.
9507         * or1k-tdep.c: Fix includes.
9508         * mi/mi-main.c: Fix includes.
9509         * m32r-tdep.c: Fix includes.
9510         * csky-tdep.c: Fix includes.
9511         * compile/compile-cplus-types.c: Fix includes.
9512         * cli/cli-interp.c: Fix includes.
9513
9514 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9515
9516         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9517         for padding.
9518
9519 2019-01-16  Tom Tromey  <tom@tromey.com>
9520
9521         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9522         earlier.
9523         (struct objfile) <msymbols_range>: Move from top level.
9524         <msymbols>: New method.
9525         (class objfile_msymbols): Remove.
9526         * symtab.c (default_collect_symbol_completion_matches_break_on):
9527         Update.
9528         * symmisc.c (dump_msymbols): Update.
9529         * stabsread.c (scan_file_globals): Update.
9530         * objc-lang.c (info_selectors_command, info_classes_command)
9531         (find_methods): Update.
9532         * minsyms.c (find_solib_trampoline_target): Update.
9533         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9534         * coffread.c (coff_symfile_read): Update.
9535         * ada-lang.c (ada_lookup_simple_minsym)
9536         (ada_collect_symbol_completion_matches): Update.
9537
9538 2019-01-16  Tom Tromey  <tom@tromey.com>
9539
9540         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9541         type.  Remove no-argument constructor.
9542         <iterator::operator++>: Simplify.
9543         <begin>: Update.
9544         <end>: Use minimal_symbol_count.
9545
9546 2019-01-16  Tom Tromey  <tom@tromey.com>
9547
9548         * objfiles.h (struct objfile) <psymtabs>: New method.
9549         (class objfile_psymtabs): Remove.
9550         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9551         typedef.
9552         <range>: New method.
9553         (require_partial_symbols): Change return type.
9554         * psymtab.c (require_partial_symbols)
9555         (psym_expand_symtabs_matching): Update.
9556         * mdebugread.c (parse_partial_symbols): Update.
9557         * dbxread.c (dbx_end_psymtab): Update.
9558
9559 2019-01-15  Tom Tromey  <tom@tromey.com>
9560
9561         * symtab.c (lookup_objfile_from_block)
9562         (lookup_symbol_in_objfile_symtabs)
9563         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9564         (find_line_symtab, info_sources_command)
9565         (default_collect_symbol_completion_matches_break_on)
9566         (make_source_files_completion_list): Update.
9567         * symmisc.c (print_objfile_statistics, dump_objfile)
9568         (maintenance_print_symbols, maintenance_info_symtabs)
9569         (maintenance_check_symtabs, maintenance_info_line_tables):
9570         Update.
9571         * source.c (select_source_symtab)
9572         (forget_cached_source_info_for_objfile): Update.
9573         * objfiles.h (class objfile_compunits): Remove.
9574         (struct objfile) <compunits_range>: New typedef.
9575         (compunits): New method.
9576         * objfiles.c (objfile_relocate1): Update.
9577         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9578         * maint.c (count_symtabs_and_blocks): Update.
9579         * linespec.c (iterate_over_all_matching_symtabs): Update.
9580         * cp-support.c (add_symbol_overload_list_qualified): Update.
9581         * coffread.c (coff_symtab_read): Update.
9582         * ada-lang.c (add_nonlocal_symbols)
9583         (ada_collect_symbol_completion_matches)
9584         (ada_add_global_exceptions): Update.
9585
9586 2019-01-15  Tom Tromey  <tom@tromey.com>
9587
9588         * progspace.h (program_space) <objfiles_safe_range>: New
9589         typedef.
9590         <objfiles_safe>: New method.
9591         * objfiles.h (class all_objfiles_safe): Remove.
9592         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9593         * jit.c (jit_inferior_exit_hook): Update.
9594
9595 2019-01-17  Tom Tromey  <tom@tromey.com>
9596
9597         * progspace.h (program_space) <objfiles_range>: New typedef.
9598         <objfiles>: New method.
9599         <objfiles_head>: Rename from objfiles.
9600         (object_files): Update.
9601         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9602         * guile/scm-pretty-print.c
9603         (ppscm_find_pretty_printer_from_objfiles): Update.
9604         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9605         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9606         Update.
9607         * python/py-progspace.c (pspy_get_objfiles): Update.
9608         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9609         Update.
9610         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9611         (objfpy_lookup_objfile_by_build_id): Update.
9612         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9613         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9614         Update.
9615         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9616         (expand_symtab_containing_pc, lookup_objfile_from_block)
9617         (lookup_static_symbol, basic_lookup_transparent_type)
9618         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9619         (find_line_symtab, info_sources_command)
9620         (default_collect_symbol_completion_matches_break_on)
9621         (make_source_files_completion_list, find_main_name): Update.
9622         * symmisc.c (print_symbol_bcache_statistics)
9623         (print_objfile_statistics, maintenance_print_symbols)
9624         (maintenance_print_msymbols, maintenance_print_objfiles)
9625         (maintenance_info_symtabs, maintenance_check_symtabs)
9626         (maintenance_expand_symtabs, maintenance_info_line_tables):
9627         Update.
9628         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9629         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9630         (map_overlay_command, unmap_overlay_command)
9631         (simple_overlay_update, expand_symtabs_matching)
9632         (map_symbol_filenames): Update.
9633         * symfile-debug.c (set_debug_symfile): Update.
9634         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9635         Update.
9636         * source.c (select_source_symtab, forget_cached_source_info):
9637         Update.
9638         * solib.c (solib_read_symbols): Update.
9639         * solib-spu.c (append_ocl_sos): Update.
9640         * psymtab.c (maintenance_print_psymbols)
9641         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9642         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9643         * printcmd.c (info_symbol_command): Update.
9644         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9645         Update.
9646         * objfiles.h (class all_objfiles): Remove.
9647         * objfiles.c (have_partial_symbols, have_full_symbols)
9648         (have_minimal_symbols, qsort_cmp, update_section_map)
9649         (shared_objfile_contains_address_p)
9650         (default_iterate_over_objfiles_in_search_order): Update.
9651         * objc-lang.c (info_selectors_command, info_classes_command)
9652         (find_methods): Update.
9653         * minsyms.c (find_solib_trampoline_target): Update.
9654         * maint.c (maintenance_info_sections)
9655         (maintenance_translate_address, count_symtabs_and_blocks):
9656         Update.
9657         * main.c (captured_main_1): Update.
9658         * linux-thread-db.c (try_thread_db_load_from_pdir)
9659         (has_libpthread): Update.
9660         * linespec.c (iterate_over_all_matching_symtabs)
9661         (search_minsyms_for_name): Update.
9662         * jit.c (jit_find_objf_with_entry_addr): Update.
9663         * hppa-tdep.c (find_unwind_entry)
9664         (hppa_lookup_stub_minimal_symbol): Update.
9665         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9666         Update.
9667         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9668         (elf_gnu_ifunc_resolve_by_got): Update.
9669         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9670         * dwarf-index-write.c (save_gdb_index_command): Update.
9671         * cp-support.c (add_symbol_overload_list_qualified): Update.
9672         * breakpoint.c (create_overlay_event_breakpoint)
9673         (create_longjmp_master_breakpoint)
9674         (create_std_terminate_master_breakpoint)
9675         (create_exception_master_breakpoint): Update.
9676         * blockframe.c (find_pc_partial_function): Update.
9677         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9678         (ada_collect_symbol_completion_matches)
9679         (ada_add_global_exceptions): Update.
9680
9681 2019-01-17  Tom Tromey  <tom@tromey.com>
9682
9683         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9684         declare VEC.
9685         (solib_target_parse_libraries): Change return type.
9686         (library_list_start_segment, library_list_start_section)
9687         (library_list_end_library, library_list_start_library); Update.
9688         (solib_target_free_library_list): Remove.
9689         (solib_target_parse_libraries): Remove cleanup.  Change return
9690         type.
9691         (solib_target_current_sos): Update.
9692
9693 2019-01-17  Tom Tromey  <tromey@bapiya>
9694
9695         * valprint.c: Replace "the the" with "the".
9696         * symtab.c: Replace "the the" with "the".
9697         * solib.c: Replace "the the" with "the".
9698         * solib-dsbt.c: Replace "the the" with "the".
9699         * linespec.c: Replace "the the" with "the".
9700         * dwarf2loc.h: Replace "the the" with "the".
9701         * amd64-windows-tdep.c: Replace "the the" with "the".
9702         * aarch64-tdep.c: Replace "the the" with "the".
9703
9704 2019-01-16  Keith Seitz  <keiths@redhat.com>
9705
9706         PR gdb/23773
9707         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9708         <builder>: Rename to ..
9709         <m_builder>: ... this and make private.
9710         (dwarf2_cu::get_builder): New method.  Change all users of
9711         `builder' to use this method.
9712         (dwarf2_start_symtab): Move to ...
9713         (dwarf2_cu::start_symtab): ... here.  Update all callers
9714         (setup_type_unit_groups): Move to ...
9715         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9716         callers.
9717         (dwarf2_cu::reset_builder): New method.
9718         (process_full_compunit, process_full_type_unit): Use
9719         dwarf2_cu::reset_builder.
9720         (follow_die_offset): Record the ancestor CU if it is different
9721         from the followed DIE's CU.
9722         (follow_die_sig_1): Likewise.
9723
9724 2019-01-15  Tom Tromey  <tom@tromey.com>
9725
9726         * remote.c (class remote_state) <buf>: Now a char_vector.
9727         <buf_size>: Remove.
9728         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9729         parameter.
9730         (remote_target::getpkt_or_notif_sane_1)
9731         (remote_target::getpkt_sane)
9732         (remote_target::getpkt_or_notif_sane): Likewise.
9733         (class remote_target) <putpkt>: New overload.
9734         (remote_target::read_frame): Change type of "buf_p".  Remove
9735         sizeof_p parameter.
9736         (packet_ok): New overload.
9737         (packet_check_result): New overload.
9738         Update all uses.
9739
9740 2019-01-14  Tom Tromey  <tom@tromey.com>
9741
9742         * remote-notif.c (handle_notification, remote_notif_ack)
9743         (remote_notif_parse): Make "buf" const.
9744         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9745         const.
9746         (remote_notif_parse, remote_notif_ack, handle_notification):
9747         Likewise.
9748         * remote.c (remote_notif_stop_parse): Make "buf" const.
9749         (remote_target::remote_parse_stop_reply): Make "buf" const.
9750         (remote_notif_stop_ack): Make "buf" const.
9751
9752 2019-01-14  Tom Tromey  <tom@tromey.com>
9753
9754         * remote.c (remote_console_output): Make parameter const.
9755
9756 2019-01-14  Tom Tromey  <tom@tromey.com>
9757
9758         * target-debug.h (target_debug_print_signals): Constify.
9759         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9760         * procfs.c (procfs_target::pass_signals): Update.
9761         * linux-nat.c (linux_nat_target::pass_signals): Update.
9762         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9763         * target-delegates.c: Rebuild.
9764         * remote.c (remote_target::program_signals): Update.
9765         (remote_target::pass_signals): Update.
9766         * target.c (target_pass_signals): Constify argument.
9767         (target_program_signals): Likewise.
9768         * target.h (struct target_ops) <pass_signals, program_signals>:
9769         Constify argument.
9770         (target_pass_signals, target_program_signals): Constify argument.
9771
9772 2019-01-14  Tom Tromey  <tom@tromey.com>
9773
9774         PR tui/28819:
9775         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9776
9777 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9778
9779         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9780         field.
9781         * rs6000-tdep.c: Include reggroups.h.
9782         (IS_V_ALIAS_PSEUDOREG): Define.
9783         (rs6000_register_name): Return names for the "vX" aliases.
9784         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9785         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9786         aliases.  Call default_register_reggroup_p for all other
9787         pseudo-registers.
9788         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9789         New functions.
9790         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9791         Handle "vX" aliases.
9792         (v_alias_pseudo_register_collect): New function.
9793         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9794         (rs6000_gdbarch_init): Initialize "vX" aliases as
9795         pseudo-registers.  Restore registration of
9796         rs6000_pseudo_register_reggroup_p with
9797         set_tdesc_pseudo_register_reggroup_p.
9798
9799 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9800
9801         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9802         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9803         set_gdbarch_num_pseudo_regs.
9804
9805 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9806
9807         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9808         Remove arg prefixname, add do_set and do_show.
9809         Add member functions set_list and show_list.
9810         * cli/cli-style.c (class cli_style_option): Update accordingly.
9811         (style_set_list): Move to file scope.
9812         (style_show_list): Likewise.
9813         (set_style): Call help_list.
9814         (show_style): Call cmd_show_list.
9815         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9816         Update to use the new macro.
9817
9818 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9819
9820         * ada-lang.c (_initialize_ada_language): Expand the help text
9821         for the "catch exception" command.
9822
9823 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9824
9825         * symtab.c (matching_obj_sections): Initialize obj,
9826         declare it closer to its usage.
9827
9828 2019-01-10  Tom Tromey  <tom@tromey.com>
9829
9830         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9831         (basic_inf_threads_range): Remove.
9832         (inf_threads_range, inf_non_exited_threads_range)
9833         (safe_inf_threads_range): Use next_adapter.
9834
9835 2019-01-10  Keith Seitz  <keiths@redhat.com>
9836
9837         PR gdb/23712
9838         PR symtab/23010
9839         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9840         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9841
9842 2019-01-10  Keith Seitz  <keiths@redhat.com>
9843
9844         PR gdb/23712
9845         PR symtab/23010
9846         * dictionary.c (pending_to_vector): Remove.
9847         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9848         Remove _1 suffix, replacing functions of the same name.  Update
9849         all callers.
9850         (dict_create_hashed, dict_create_hashed_expandable)
9851         (dict_create_linear, dict_create_linear_expandable, dict_free)
9852         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9853         Make functions static.
9854
9855 2019-01-10  Keith Seitz  <keiths@redhat.com>
9856
9857         PR gdb/23712
9858         PR symtab/23010
9859         * dictionary.h (struct dictionary): Replace declaration with
9860         multidictionary.
9861         (dict_create_hashed, dict_create_hashed_expandable)
9862         (dict_create_linear, dict_create_linear_expandable)
9863         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9864         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9865         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9866         taking multidictionary argument.
9867         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9868         * block.h (struct block) <dict>: Change to multidictionary
9869         and rename `multidict'.
9870         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9871         symmisc.c: Update all dictionary references to multidictionary.
9872
9873 2019-01-10  Keith Seitz  <keiths@redhat.com>
9874
9875         PR gdb/23712
9876         PR symtab/23010
9877         * dictionary.c: Include unordered_map.
9878         (pending_to_vector): New function.
9879         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9880         Rewrite the non-"_1" functions to take vector instead
9881         of linked list.
9882         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9883         "new" _1 versions of the same name.
9884         (multidictionary): Define.
9885         (std::hash<enum language): New definition.
9886         (collate_pending_symbols_by_language, mdict_create_hashed)
9887         (mdict_create_hashed_expandable, mdict_create_linear)
9888         (mdict_create_linear_expandable, mdict_free)
9889         (find_language_dictionary, create_new_language_dictionary)
9890         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9891         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9892         (mdict_size, mdict_empty): New functions.
9893         * dictionary.h (mdict_iterator): Define.
9894
9895 2019-01-10  Pedro Alves  <palves@redhat.com>
9896
9897         * breakpoint.c (read_uploaded_action)
9898         (create_tracepoint_from_upload): Adjust to use
9899         gdb::unique_xmalloc_ptr.
9900         * ctf.c (ctf_write_uploaded_tp):
9901         (SET_ARRAY_FIELD): Use emplace_back.
9902         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9903         * tracefile-tfile.c (tfile_write_uploaded_tp):
9904         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9905         gdb::unique_xmalloc_ptr.
9906         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9907         at_string, cond_string, cmd_strings>: Replace char pointers
9908         with gdb::unique_xmalloc_ptr.
9909
9910 2019-01-10  Pedro Alves  <palves@redhat.com>
9911
9912         * solib-target.c (library_list_start_library): Don't xstrdup name.
9913
9914 2019-01-10  Pedro Alves  <palves@redhat.com>
9915
9916         * mdebugread.c (parse_partial_symbols): Use
9917         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9918
9919 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9920
9921         * linux-fork.c (scoped_switch_fork_info)
9922         <~scoped_switch_fork_info>: Fix incorrect variable name.
9923
9924 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9925
9926         * linux-fork.c (scoped_switch_fork_info)
9927         <scoped_switch_fork_info>: Make explicit.
9928         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9929
9930 2019-01-10  Tom Tromey  <tom@tromey.com>
9931
9932         * objfiles.h (objfile::reset_psymtabs): Update.
9933         * objfiles.c (objfile::objfile): Update.
9934         * psymtab.h (psymtab_storage::obstack): Update.
9935         (psymtab_storage::m_obstack): Use gdb::optional.
9936         (class psymtab_storage): Update comment.  Remove objfile
9937         parameter.
9938         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9939
9940 2019-01-10  Tom Tromey  <tom@tromey.com>
9941
9942         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9943         <free_psymtabs>: Now private.
9944         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9945         (allocate_psymtab): Use new method.
9946
9947 2019-01-10  Tom Tromey  <tom@tromey.com>
9948
9949         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9950         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9951         * mdebugread.c (parse_partial_symbols): Use
9952         allocate_dependencies.
9953         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9954         allocate_dependencies.
9955         (process_psymtab_comp_unit_reader)
9956         (build_type_psymtab_dependencies): Likewise.
9957         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9958
9959 2019-01-10  Tom Tromey  <tom@tromey.com>
9960
9961         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9962         PSYMBOL_SET_LANGUAGE.
9963         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9964
9965 2019-01-10  Tom Tromey  <tom@tromey.com>
9966
9967         * psymtab.h (psymtab_storage::obstack): New method.
9968         <m_obstack>: Rename from obstack; now private.
9969         * psymtab.c (psymtab_storage): Update.
9970         * dwarf2read.c (create_addrmap_from_index)
9971         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9972         Update.
9973
9974 2019-01-10  Tom Tromey  <tom@tromey.com>
9975
9976         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9977         * objfiles.h (objfile::reset_psymtabs): New method.
9978
9979 2019-01-10  Tom Tromey  <tom@tromey.com>
9980
9981         * symmisc.c (print_symbol_bcache_statistics): Update.
9982         (print_objfile_statistics): Update.
9983         * symfile.c (reread_symbols): Update.
9984         * psymtab.h (class psymtab_storage): New.
9985         * psymtab.c (psymtab_storage): New constructor.
9986         (~psymtab_storage): New destructor.
9987         (require_partial_symbols): Update.
9988         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9989         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9990         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9991         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9992         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9993         (start_psymtab_common, end_psymtab_common)
9994         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9995         (allocate_psymtab): Update.
9996         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9997         Update.
9998         (dump_psymtab_addrmap, maintenance_print_psymbols)
9999         (maintenance_check_psymtabs): Update.
10000         (class objfile_psymtabs): Move to objfiles.h.
10001         * psympriv.h (discard_psymtab): Now inline.
10002         (psymtab_discarder::psymtab_discarder): Update.
10003         (psymtab_discarder::~psymtab_discarder): Update.
10004         (ALL_OBJFILE_PSYMTABS): Rewrite.
10005         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10006         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10007         Remove fields.
10008         <partial_symtabs>: New field.
10009         (class objfile_psymtabs): Move from psymtab.h.  Update.
10010         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10011         psymbol_cache.
10012         (objfile::~objfile): Don't destroy psymbol_cache.
10013         * mdebugread.c (parse_partial_symbols): Update.
10014         * dwarf2read.c (create_addrmap_from_index)
10015         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10016         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10017         (add_partial_subprogram, dwarf2_ranges_read): Update.
10018         * dwarf-index-write.c (write_address_map)
10019         (write_one_signatured_type, recursively_write_psymbols)
10020         (class debug_names, class debug_names, write_psymtabs_to_index):
10021         Update.
10022
10023 2019-01-10  Tom Tromey  <tom@tromey.com>
10024
10025         * symtab.h (SYMBOL_SET_NAMES): Update.
10026         (symbol_set_names): Update.
10027         (MSYMBOL_SET_NAMES): Update.
10028         * symtab.c (symbol_set_names): Change argument to be an
10029         objfile_per_bfd_storage.
10030         * psymtab.c (add_psymbol_to_bcache): Update.
10031         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10032
10033 2019-01-10  Tom Tromey  <tom@tromey.com>
10034
10035         * symtab.c (create_demangled_names_hash): Change argument to be an
10036         objfile_per_bfd_storage.
10037         (symbol_set_names): Update.
10038
10039 2019-01-10  Tom Tromey  <tom@tromey.com>
10040
10041         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10042         init_psymbol_list.
10043         * psymtab.c (init_psymbol_list): Do nothing if already called.
10044         * psympriv.h (init_psymbol_list): Add comment.
10045         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10046         init_psymbol_list.
10047         * dbxread.c (dbx_symfile_read): Unconditionally call
10048         init_psymbol_list.
10049
10050 2019-01-10  Tom Tromey  <tom@tromey.com>
10051
10052         * xcoffread.c (scan_xcoff_symtab): Update.
10053         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10054         "where".
10055         * mdebugread.c (parse_partial_symbols)
10056         (handle_psymbol_enumerators): Update.
10057         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10058         * dbxread.c (read_dbx_symtab): Update.
10059         * psympriv.h (psymbol_placement): New enum.
10060         (add_psymbol_to_list): Update.
10061
10062 2019-01-10  Tom Tromey  <tom@tromey.com>
10063
10064         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10065         static_psymbols parameters.
10066         (scan_xcoff_symtab): Update.
10067         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10068         static_psymbols parameters.
10069         * psympriv.h (start_psymtab_common): Update.
10070         * mdebugread.c (parse_partial_symbols): Update.
10071         * dwarf2read.c (create_partial_symtab): Update.
10072         * dbxread.c (read_dbx_symtab): Update.
10073         (start_psymtab): Remove global_psymbols and static_psymbols
10074         parameters.
10075
10076 2019-01-10  Tom Tromey  <tom@tromey.com>
10077
10078         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10079         * psymtab.c (allocate_psymtab): Add comment.
10080         * psympriv.h (allocate_psymtab): Add comment.
10081         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10082         initializations.
10083         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10084
10085 2019-01-10  Tom Tromey  <tom@tromey.com>
10086
10087         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10088         Don't declare.
10089         * mipsread.c: Include mdebugread.h.
10090         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10091         Declare.
10092         * elfread.c: Include mdebugread.h.
10093
10094 2019-01-09  Tom Tromey  <tom@tromey.com>
10095
10096         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10097         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10098         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10099         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10100         (psym_lookup_symbol, psym_find_last_source_symtab)
10101         (psym_forget_cached_source_info, psym_print_stats)
10102         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10103         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10104         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10105         (psym_find_compunit_symtab_by_address)
10106         (maintenance_print_psymbols, maintenance_info_psymtabs)
10107         (maintenance_check_psymtabs): Use ranged for.
10108         * psymtab.h (class objfile_psymtabs): New.
10109         (require_partial_symbols): Return objfile_psymtabs.
10110         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10111
10112 2019-01-09  Tom Tromey  <tom@tromey.com>
10113
10114         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10115         (find_pc_mapped_section, list_overlays_command)
10116         (map_overlay_command, unmap_overlay_command)
10117         (simple_overlay_update): Use all_objfiles.
10118         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10119         * printcmd.c (info_symbol_command): Use all_objfiles.
10120         * objfiles.h (ALL_OBJSECTIONS): Remove.
10121         * maint.c (maintenance_translate_address): Use all_objfiles.
10122         * gcore.c (gcore_create_callback): Use all_objfiles.
10123         (objfile_find_memory_regions): Likewise.
10124
10125 2019-01-09  Tom Tromey  <tom@tromey.com>
10126
10127         * symtab.c (find_line_symtab, info_sources_command)
10128         (make_source_files_completion_list): Use objfile_compunits.
10129         * source.c (select_source_symtab): Use objfile_compunits.
10130         * objfiles.h (struct objfile): Update comment.
10131         (ALL_OBJFILES): Remove.
10132         (ALL_FILETABS): Remove.
10133         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10134         objfile_compunits.
10135
10136 2019-01-09  Tom Tromey  <tom@tromey.com>
10137
10138         * symmisc.c (print_objfile_statistics, dump_objfile)
10139         (maintenance_print_symbols): Use compunit_filetabs.
10140         * source.c (forget_cached_source_info_for_objfile): Use
10141         compunit_filetabs.
10142         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10143         (ALL_FILETABS): Use compunit_filetabs.
10144         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10145         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10146
10147 2019-01-09  Tom Tromey  <tom@tromey.com>
10148
10149         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10150         (compunit_filetabs): New.
10151         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10152         compunit_filetabs.
10153         (info_sources_command, make_source_files_completion_list): Remove
10154         declaration.
10155         * symmisc.c (print_objfile_statistics, dump_objfile)
10156         (maintenance_print_symbols): Remove declaration.
10157         (maintenance_info_symtabs): Use compunit_filetabs.
10158         (maintenance_info_line_tables): Likewise.
10159         * source.c (select_source_symtab): Change local variable name.
10160         (forget_cached_source_info_for_objfile): Remove declaration.
10161         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10162         * objfiles.c (objfile_relocate1): Remove declaration.
10163         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10164         declaration.
10165         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10166         * coffread.c (coff_symtab_read): Remove declaration.
10167         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10168         compunit_filetabs.
10169
10170 2019-01-09  Tom Tromey  <tom@tromey.com>
10171
10172         * symtab.c (lookup_objfile_from_block)
10173         (find_pc_sect_compunit_symtab, search_symbols)
10174         (default_collect_symbol_completion_matches_break_on): Use
10175         objfile_compunits.
10176         * objfiles.h (ALL_COMPUNITS): Remove.
10177         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10178         * cp-support.c (add_symbol_overload_list_qualified): Use
10179         objfile_compunits.
10180         * ada-lang.c (ada_collect_symbol_completion_matches)
10181         (ada_add_global_exceptions): Use objfile_compunits.
10182
10183 2019-01-09  Tom Tromey  <tom@tromey.com>
10184
10185         * source.c (select_source_symtab)
10186         (forget_cached_source_info_for_objfile): Remove declaration.
10187         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10188         declaration.
10189         * maint.c (count_symtabs_and_blocks): Remove declaration.
10190         * cp-support.c (add_symbol_overload_list_qualified): Remove
10191         declaration.
10192         * coffread.c (coff_symtab_read): Remove declaration.
10193         * symtab.c (lookup_symbol_in_objfile_symtabs)
10194         (basic_lookup_transparent_type_1): Use objfile_compunits.
10195         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10196         (info_sources_command, search_symbols)
10197         (default_collect_symbol_completion_matches_break_on)
10198         (make_source_files_completion_list): Remove declaration.
10199         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10200         (ada_collect_symbol_completion_matches)
10201         (ada_add_global_exceptions): Remove declaration.
10202         * linespec.c (iterate_over_all_matching_symtabs): Use
10203         objfile_compunits.
10204         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10205         (class objfile_compunits): New.
10206         (ALL_COMPUNITS): Use objfile_compunits.
10207         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10208         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10209         objfile_compunits.
10210         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10211
10212 2019-01-09  Tom Tromey  <tom@tromey.com>
10213
10214         * symtab.c (search_symbols)
10215         (default_collect_symbol_completion_matches_break_on): Use
10216         objfile_msymbols.
10217         * ada-lang.c (ada_lookup_simple_minsym)
10218         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10219         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10220         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10221         objfile_msymbols.
10222         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10223         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10224         * objc-lang.c (find_methods): Use objfile_msymbols.
10225         (info_selectors_command, info_classes_command): Likewise.
10226         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10227         * objfiles.h (class objfile_msymbols): New.
10228         (ALL_OBJFILE_MSYMBOLS): Remove.
10229         (ALL_MSYMBOLS): Remove.
10230
10231 2019-01-09  Tom Tromey  <tom@tromey.com>
10232
10233         * common/next-iterator.h (next_adapter): Add Iterator template
10234         parameter.
10235         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10236         (class all_objfiles_safe): New.
10237         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10238         * objfiles.c (put_objfile_before): Update comment.
10239         (add_separate_debug_objfile): Likewise.
10240         (free_all_objfiles): Use all_objfiles_safe.
10241         (objfile_purge_solibs): Likewise.
10242
10243 2019-01-09  Tom Tromey  <tom@tromey.com>
10244
10245         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10246         (expand_symtab_containing_pc, lookup_static_symbol)
10247         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10248         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10249         all_objfiles.
10250         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10251         * breakpoint.c (create_overlay_event_breakpoint)
10252         (create_longjmp_master_breakpoint)
10253         (create_std_terminate_master_breakpoint)
10254         (create_exception_master_breakpoint): Use all_objfiles.
10255         * linux-thread-db.c (try_thread_db_load_from_pdir)
10256         (has_libpthread): Use all_objfiles.
10257         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10258         * linespec.c (iterate_over_all_matching_symtabs)
10259         (search_minsyms_for_name): Use all_objfiles.
10260         * maint.c (maintenance_info_sections): Use all_objfiles.
10261         * main.c (captured_main_1): Use all_objfiles.
10262         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10263         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10264         * guile/scm-pretty-print.c
10265         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10266         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10267         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10268         (maintenance_print_msymbols): Use all_objfiles.
10269         * source.c (select_source_symtab): Use all_objfiles.
10270         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10271         * symfile.c (remove_symbol_file_command)
10272         (expand_symtabs_matching, map_symbol_filenames): Use
10273         all_objfiles.
10274         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10275         all_objfiles.
10276         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10277         * objc-lang.c (find_methods): Use all_objfiles.
10278         * objfiles.c (have_partial_symbols, have_full_symbols)
10279         (have_minimal_symbols, qsort_cmp)
10280         (default_iterate_over_objfiles_in_search_order): Use
10281         all_objfiles.
10282         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10283         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10284         (maintenance_check_psymtabs): Use all_objfiles.
10285         (ALL_PSYMTABS): Remove.
10286         * compile/compile-object-run.c (do_module_cleanup): Use
10287         all_objfiles.
10288         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10289         * cp-support.c (add_symbol_overload_list_qualified): Use
10290         all_objfiles.
10291         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10292         Use all_objfiles.
10293         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10294         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10295         all_objfiles.
10296         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10297         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10298         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10299         Uses all_objfiles.
10300         * solib.c (solib_read_symbols): Use all_objfiles
10301
10302 2019-01-09  Tom Tromey  <tom@tromey.com>
10303
10304         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10305         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10306         all_objfiles.
10307         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10308         * symmisc.c (print_symbol_bcache_statistics)
10309         (print_objfile_statistics, maintenance_print_objfiles)
10310         (maintenance_info_symtabs, maintenance_check_symtabs)
10311         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10312         all_objfiles.
10313         * source.c (forget_cached_source_info): Use all_objfiles.
10314         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10315         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10316         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10317         * objfiles.c (update_section_map): Use all_objfiles.
10318         (shared_objfile_contains_address_p): Likewise.
10319         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10320         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10321
10322 2019-01-09  Tom Tromey  <tom@tromey.com>
10323
10324         * common/next-iterator.h: New file.
10325         * objfiles.h (class all_objfiles): New.
10326         (struct objfile_iterator): New.
10327
10328 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10329
10330         * NEWS: Move the description of the changed "frame", "select-frame",
10331          and "info frame" commands to the Changed commands section.
10332
10333 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10334
10335         * gdbtypes.c (check_stub_method_group): Remove handling of old
10336         mangling schemes.
10337         * linespec.c (find_methods): Likewise.
10338         * stabsread.c (read_member_functions): Likewise.
10339         * valops.c (search_struct_method): Likewise.
10340         (value_struct_elt_for_reference): Likewise.
10341         * NEWS: Mention this change.
10342
10343 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10344
10345         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10346         print_source_lines.
10347         * source.c (print_source_lines_base): Update line number check.
10348         (print_source_lines): New function.
10349         (source_lines_range::source_lines_range): New function.
10350         * source.h (class source_lines_range): New class.
10351         (print_source_lines): New declaration.
10352
10353 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10354
10355         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10356
10357 2019-01-08  Tom Tromey  <tom@tromey.com>
10358             Simon Marchi  <simon.marchi@ericsson.com>
10359
10360         PR gdb/24060
10361         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10362         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10363         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10364         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10365         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10366         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10367
10368 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10369
10370         * source.c (select_source_symtab): Move header comment to
10371         declaration in source.h.
10372         (forget_cached_source_info_for_objfile): Likewise.
10373         (forget_cached_source_info): Likewise.
10374         (identify_source_line): Likewise.
10375         * source.h (identify_source_line): Move declaration from symtab.h
10376         and add comment from source.c
10377         (print_source_lines): Likewise.
10378         (forget_cached_source_info_for_objfile): Likewise.
10379         (forget_cached_source_info): Likewise.
10380         (select_source_symtab): Likewise.
10381         (enum print_source_lines_flag): Move definition from symtab.h.
10382         * symtab.h (identify_source_line): Move declaration to source.h.
10383         (print_source_lines): Likewise.
10384         (forget_cached_source_info_for_objfile): Likewise.
10385         (forget_cached_source_info): Likewise.
10386         (select_source_symtab): Likewise.
10387         (enum print_source_lines_flag): Move definition to source.h.
10388         * tui/tui-hooks.c: Add 'source.h' include.
10389
10390 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10391
10392         * source.c (print_source_lines_base): Handle requests to print
10393         reverse line number sequences, and guard against empty lines
10394         string.
10395
10396 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10397
10398         * source.c (print_source_lines_base): Fix skip of '\r' if next
10399         character is '\n'.
10400
10401 2019-01-06  Tom Tromey  <tom@tromey.com>
10402
10403         * c-exp.y (struct c_parse_state) <macro_original_text,
10404         expansion_obstack>: New member.
10405         (macro_original_text, expansion_obstack): Remove globals.
10406         (scan_macro_expansion, scanning_macro_expansion)
10407         (finished_macro_expansion): Update.
10408         (scan_macro_cleanup): Remove.
10409         (yylex, c_parse): Update.
10410
10411 2019-01-06  Tom Tromey  <tom@tromey.com>
10412
10413         * c-exp.y (struct c_parse_state) <strings>: New member.
10414         (operator_stoken): Update.
10415
10416 2019-01-06  Tom Tromey  <tom@tromey.com>
10417
10418         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10419         (union type_stack_elt) <typelist_val>: Now a pointer to
10420         std::vector.
10421         (type_stack_cleanup): Don't declare.
10422         (push_typelist): Update.
10423         * parse.c (pop_typelist): Return a std::vector.
10424         (push_typelist): Take a std::vector.
10425         (follow_types): Update.  Do not free args.
10426         (type_stack_cleanup): Remove.
10427         * c-exp.y (struct c_parse_state): New.
10428         (cpstate): New global.
10429         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10430         (nonempty_typelist): Update.
10431         (func_mod): Create a new vector.
10432         (c_parse): Create a c_parse_state.
10433         (check_parameter_typelist): Do not delete params.
10434         (function_method): Update.  Do not delete type_list.
10435
10436 2019-01-06  Tom Tromey  <tom@tromey.com>
10437
10438         PR gdb/28155:
10439         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10440         check_typedef.
10441         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10442         (print_return_value): Likewise.
10443
10444 2019-01-05  Tom Tromey  <tom@tromey.com>
10445
10446         * contrib/cleanup_check.py: Remove.
10447         * contrib/gcc-with-excheck: Remove.
10448         * contrib/exsummary.py: Remove.
10449         * contrib/excheck.py: Remove.
10450
10451 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10452
10453         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10454         NULL. Initialize tpprev to NULL instead of assigning it
10455         to NULL on the next statement.
10456         * windows-nat.c (windows_delete_thread): Remove check for
10457         main_thread_id before printing thread exit notifications.
10458         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10459         Remove thread ID check against main_thread_id.
10460         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10461         windows_delete_thread.
10462         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10463
10464 2019-01-04  Tom Tromey  <tom@tromey.com>
10465
10466         * compile/compile.c (_initialize_compile): Use upper case for
10467         metasyntactic variables.
10468         * symmisc.c (_initialize_symmisc): Use upper case for
10469         metasyntactic variables.
10470         * psymtab.c (_initialize_psymtab): Use upper case for
10471         metasyntactic variables.
10472         * demangle.c (demangle_command): Use upper case for metasyntactic
10473         variables.
10474         (_initialize_demangler): Likewise.
10475         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10476         variables.
10477
10478 2019-01-03  Tom Tromey  <tom@tromey.com>
10479
10480         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10481
10482 2019-01-03  Tom Tromey  <tom@tromey.com>
10483
10484         * python/py-symtab.c (salpy_str): Update.
10485         (struct salpy_sal_object) <symtab>: Now a PyObject.
10486         (salpy_dealloc): Update.
10487         (del_objfile_sal): Use gdbpy_ref.
10488
10489 2019-01-03  Tom Tromey  <tom@tromey.com>
10490
10491         * python/py-type.c (convert_field): Use new_reference.  Return
10492         gdbpy_ref.
10493         (make_fielditem): Return gdbpy_ref.
10494         (typy_fields): Update.
10495         (typy_getitem): Update.
10496         (field_name): Return gdbpy_ref.  Use new_reference.
10497         (typy_iterator_iternext): Update.
10498
10499 2019-01-03  Tom Tromey  <tom@tromey.com>
10500
10501         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10502
10503 2019-01-03  Tom Tromey  <tom@tromey.com>
10504
10505         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10506         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10507         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10508         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10509         (pspy_set_type_printers): Likewise.
10510         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10511         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10512         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10513         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10514         (objfpy_set_type_printers): Likewise.
10515
10516 2019-01-03  Tom Tromey  <tom@tromey.com>
10517
10518         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10519         (gdbpy_print_stack): Use gdbpy_err_fetch.
10520         * python/python-internal.h (class gdbpy_err_fetch): New class.
10521         (class gdbpy_enter) <m_error_type, m_error_value,
10522         m_error_traceback>: Remove.
10523         <m_error>: New member.
10524         (gdbpy_exception_to_string): Don't declare.
10525         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10526         * python/py-value.c (convert_value_from_python): Use
10527         gdbpy_err_fetch.
10528         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10529         gdbpy_exception_to_string.
10530         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10531         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10532         gdbpy_err_fetch.
10533
10534 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10535
10536         * linux-nat.c (delete_lwp_cleanup): Delete.
10537         (struct lwp_deleter): New struct.
10538         (lwp_info_up): New typedef.
10539         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10540         lwp_info_up.
10541
10542 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10543
10544         * linux-fork.c (class scoped_switch_fork_info): New class.
10545         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10546
10547 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10548
10549         * valops.c (find_overload_match): Remove use of null_cleanup, and
10550         calls to do_cleanups.
10551
10552 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10553
10554         * compile/compile-cplus-types.c
10555         (compile_cplus_instance::decl_name): Handle changes to
10556         cp_func_name.
10557         * cp-support.c (cp_func_name): Update header comment, update
10558         return type.
10559         * cp-support.h (cp_func_name): Update return type in declaration.
10560         * valops.c (find_overload_match): Move temp_func local to top
10561         level of function and change its type.  Use temp_func to hold and
10562         delete temporary string obtained from cp_func_name.
10563
10564 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10565
10566         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10567         gdb::char_vector, remove cleanup, and update uses of `msg`.
10568
10569 2019-01-03  Jim Wilson  <jimw@sifive.com>
10570
10571         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10572
10573 2019-01-02  Tom Tromey  <tom@tromey.com>
10574
10575         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10576         (tdesc_parse_xml): Remove cleanups.
10577         * target-descriptions.h (make_cleanup_free_target_description):
10578         Don't declare.
10579         (target_desc_deleter): New struct.
10580         (target_desc_up): New typedef.
10581         * target-descriptions.c (target_desc_deleter::operator()): Rename
10582         from free_target_description.
10583         (make_cleanup_free_target_description): Remove.
10584
10585 2019-01-02  Tom Tromey  <tom@tromey.com>
10586
10587         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10588         constructor, destructor.
10589         (linespec_parser): Remove typedef.
10590         (~linespec_parser): Rename from linespec_parser_delete.
10591         (linespec_lex_to_end, linespec_complete_label)
10592         (linespec_complete): Update.
10593         (decode_line_full): Remove cleanups.
10594         (decode_line_1): Update.
10595
10596 2019-01-02  Tom Tromey  <tom@tromey.com>
10597
10598         * python/python-internal.h (inferior_to_inferior_object): Change
10599         return type.
10600         * python/py-exitedevent.c (create_exited_event_object): Update.
10601         * python/py-inferior.c (inferior_to_inferior_object): Return
10602         gdbpy_ref.
10603         (python_new_inferior, python_inferior_deleted)
10604         (thread_to_thread_object, delete_thread_object)
10605         (build_inferior_list, gdbpy_selected_inferior): Update.
10606         * python/py-infthread.c (create_thread_object): Update.  Also fail
10607         if inferior_to_inferior_object fails.
10608
10609 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10610
10611         * inferior.h (class inferior) <displaced_step_state>: New field.
10612         * infrun.h (struct displaced_step_state): Move here from
10613         infrun.c.  Initialize fields, add constructor.
10614         <inf>: Remove field.
10615         <reset>: New method.
10616         * infrun.c (struct displaced_step_inferior_state): Move to
10617         infrun.h.
10618         (displaced_step_inferior_states): Remove.
10619         (get_displaced_stepping_state): Adust.
10620         (displaced_step_in_progress_any_inferior): Adjust.
10621         (displaced_step_in_progress_thread): Adjust.
10622         (displaced_step_in_progress): Adjust.
10623         (add_displaced_stepping_state): Remove.
10624         (get_displaced_step_closure_by_addr): Adjust.
10625         (remove_displaced_stepping_state): Remove.
10626         (infrun_inferior_exit): Call displaced_step_state.reset.
10627         (use_displaced_stepping): Don't check for NULL.
10628         (displaced_step_prepare_throw): Call
10629         get_displaced_stepping_state.
10630         (displaced_step_fixup): Don't check for NULL.
10631         (prepare_for_detach): Don't check for NULL.
10632
10633 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10634
10635         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10636          in case of call that did not complete.
10637
10638 2019-01-02  Andrey Utkin  <autkin@undo.io>
10639
10640         * symfile.c (find_separate_debug_file): Fix search of debug files for
10641         remote debuggee.
10642
10643 2019-01-02  Tom Tromey  <tom@tromey.com>
10644
10645         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10646         indentation.
10647         * python/py-frame.c (frapy_older): Remove cast.
10648         (frapy_newer): Likewise.
10649         * python/py-breakpoint.c (local_setattro): Remove cast.
10650         * python/py-arch.c (archpy_name): Remove local variable.
10651         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10652
10653 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10654
10655         * unittests/basic_string_view/element_access/char/empty.cc:
10656         Fix year range in copyright header.
10657
10658 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10659
10660         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10661         Delete.
10662         <operator==>: Update with for removed field.
10663         <hash>: Likewise.
10664         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10665         <isa_features>: ...this.
10666         <abi_features>: New field.
10667         (riscv_isa_flen): Update comment.
10668         (riscv_abi_xlen): New declaration.
10669         (riscv_abi_flen): New declaration.
10670         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10671         isa_features.
10672         (riscv_abi_xlen): New function.
10673         (riscv_isa_flen): Update to get answer from isa_features.
10674         (riscv_abi_flen): New function.
10675         (riscv_has_fp_abi): Update to get answer from abi_features.
10676         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10677         xlen and flen.
10678         (riscv_call_info) <xlen, flen>: Update comment.
10679         (riscv_call_arg_struct): Remove invalid assertions
10680         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10681         is removed.
10682         (riscv_gdbarch_init): Gather isa features and abi features
10683         separately, ensure both match on the gdbarch when reusing an old
10684         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10685         a target with 64-bit float hardware.
10686
10687 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10688
10689         * source.c (search_command_helper): Stop reverse search
10690         when line 1 has been searched.
10691
10692 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10693
10694         * record-full.c (record_full_base_target::close): Rewrite
10695         record_full_core_buf_list free logic.
10696
10697 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10698
10699         * break-catch-syscall.c (print_one_catch_syscall): xfree
10700         the last text.
10701
10702 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10703
10704         * top.c (print_gdb_version): Update Copyright year in version
10705         message.
10706
10707 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10708
10709         Update copyright year range in all GDB files.
10710
10711 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10712
10713         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10714
10715 For older changes see ChangeLog-2018.
10716 \f
10717 Local Variables:
10718 mode: change-log
10719 left-margin: 8
10720 fill-column: 74
10721 version-control: never
10722 coding: utf-8
10723 End:
10724