gdb/ChangeLog

   1 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
   2             Tom Tromey  <tom@tromey.com>
   3
   4         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
   5         (ppc_threads): Now a std::vector.  Now static.
   6         (hwdebug_find_thread_points_by_tid)
   7         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
   8         Update.
   9
  10 2019-05-04  Tom Tromey  <tom@tromey.com>
  11
  12         * arc-tdep.c (arc_tdesc_init): Return bool.
  13
  14 2019-05-04  Tom Tromey  <tom@tromey.com>
  15
  16         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
  17         Use gdb_assert_not_reached.
  18
  19 2019-05-04  Tom Tromey  <tom@tromey.com>
  20
  21         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
  22         "false".
  23
  24 2019-05-04  Tom Tromey  <tom@tromey.com>
  25
  26         * arc-tdep.c (arc_tdesc_init): Use bool.
  27
  28 2019-05-04  Tom Tromey  <tom@tromey.com>
  29
  30         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  31
  32 2019-05-04  Tom Tromey  <tom@tromey.com>
  33
  34         * cli/cli-cmds.c (valid_command_p): Return bool.
  35
  36 2019-05-04  Tom Tromey  <tom@tromey.com>
  37
  38         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  39         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  40
  41 2019-05-04  Raul Tambre  <raul@tambre.ee>
  42
  43         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  44         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  45         operator for comparison.
  46
  47 2019-05-04  Tom Tromey  <tom@tromey.com>
  48
  49         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  50         (lookup_partial_symbol, print_partial_symbols)
  51         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  52         (psymbol_compare): Update.
  53         (add_psymbol_to_bcache): Clear the entire psymbol.
  54         (maintenance_check_psymtabs): Update.
  55         * psympriv.h (struct partial_symbol): Don't derive from
  56         general_symbol_info.
  57         <obj_section, unrelocated_address, address,
  58         set_unrelocated_address>: Update.
  59         <ginfo>: New member.
  60         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  61         (debug_names::write_psymbols): Update.
  62
  63 2019-05-04  Tom de Vries  <tdevries@suse.de>
  64
  65         * contrib/cc-with-tweaks.sh: Support -n arg.
  66
  67 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  68
  69         * corelow.c (core_target::detach): Ensure frame cache and
  70         register caches are cleared.
  71         inferior.c (exit_inferior_1): Likewise.
  72
  73 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  74             Tom Tromey  <tom@tromey.com>
  75
  76         * dictionary.c (collate_pending_symbols_by_language): Remove
  77         "struct" from foreach.
  78         * symtab.c (lookup_global_symbol_from_objfile)
  79         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  80         foreach.
  81         * ser-tcp.c (net_open): Remove "struct" from foreach.
  82         * objfiles.c (objfile_relocate, objfile_rebase)
  83         (objfile_has_symbols): Remove "struct" from foreach.
  84         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  85         from foreach.
  86         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  87         foreach.
  88         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  89         "struct" from foreach.
  90         * ada-lang.c (create_excep_cond_exprs)
  91         (ada_exception_catchpoint_cond_string): Remove "struct" from
  92         foreach.
  93
  94 2019-05-03  Tom Tromey  <tromey@adacore.com>
  95
  96         * ada-exp.y (convert_char_literal): Check suffix of each
  97         enumerator.
  98
  99 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 100
 101         PR ada/21406:
 102         * ada-exp.y (yywrap): Don't define.
 103         * ada-lex.l (%option): Add noyywrap
 104         (yywrap): Remove.
 105
 106 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 107
 108         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 109         _WIN32_WINNT to the XP level, unless already defined to a higher
 110         level.
 111
 112         * unittests/parse-connection-spec-selftests.c:
 113         * ser-tcp.c:
 114         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 115         override.
 116
 117         * symfile.c (find_separate_debug_file): Remove colon from the
 118         drive spec of DOS/Windows file names of the target, so that the
 119         file name produced from DEBUGDIR and the target's directory will
 120         be valid on DOS/Windows systems.
 121
 122 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 123
 124         * rust-lang.c (val_print_struct): Handle printing structures
 125         containing strings.
 126
 127 2019-05-02  Tom Tromey  <tromey@adacore.com>
 128
 129         * valarith.c (_initialize_valarith): Remove.
 130
 131 2019-05-01  Tom Tromey  <tromey@adacore.com>
 132
 133         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 134         bitfields.
 135
 136 2019-05-01  Tom Tromey  <tromey@adacore.com>
 137
 138         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 139         for big-endian copies.
 140
 141 2019-04-30  Ali Tamur  <tamur@google.com>
 142         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 143         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 144         (read_3_bytes): New function.
 145
 146 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 147
 148         * windows-nat.c (main_thread_id): Delete.
 149         (handle_output_debug_string): Replace main_thread_id by
 150         current_event.dwThreadId.
 151         (fake_create_process): Likewise.
 152         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 153         Do not set main_thread_id.
 154         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 155         current_event.dwThreadId.
 156         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 157
 158 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 159
 160         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 161         Use current_event.dwThreadId instead of main_thread_id.
 162
 163 2019-04-30  Tom Tromey  <tromey@adacore.com>
 164
 165         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 166         (create_excep_cond_exprs): Iterate over program spaces.
 167         (ada_exception_catchpoint_cond_string): Examine all minimal
 168         symbols for exception types.
 169
 170 2019-04-30  Tom Tromey  <tromey@adacore.com>
 171
 172         PR c++/24470:
 173         * dwarf2read.c (process_structure_scope): Handle case where type
 174         has template parameters but no symbol was created.
 175
 176 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 177             Chris January  <chris.january@arm.com>
 178
 179         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 180         qualifier.
 181         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 182
 183 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 184
 185         * f-typeprint.c (f_print_type): Update rules for printing
 186         whitespace.
 187         (f_type_print_varspec_suffix): Likewise.
 188
 189 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 190             Chris January  <chris.january@arm.com>
 191
 192         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 193         function arguments.
 194
 195 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 196
 197         * f-lang.c (build_fortran_types): Change name of void type to
 198         lower case.
 199         * f-typeprint.c (f_type_print_base): Print the name of the void
 200         type, rather than a fixed string.
 201         * f-valprint.c (f_decorations): Use lower case void string.
 202
 203 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 204             Chris January  <chris.january@arm.com>
 205
 206         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 207         types for Fortran.
 208
 209 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 210             Chris January  <chris.january@arm.com>
 211             David Lecomber  <david.lecomber@arm.com>
 212
 213         * f-exp.y (BINOP_INTRINSIC): New token.
 214         (exp): New parser rule handling BINOP_INTRINSIC.
 215         (f77_keywords): Add new builtin procedures.
 216         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 217         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 218         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 219         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 220         (print_unop_subexp_f): New function.
 221         (print_binop_subexp_f): New function.
 222         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 223         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 224         (dump_subexp_body_f): Likewise.
 225         (operator_check_f): Likewise.
 226         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 227         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 228
 229 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 230
 231         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 232         UNOP_KIND.
 233         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 234         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 235         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 236         (operator_length_f): New fuction.
 237         (print_subexp_f): New function.
 238         (op_name_f): New function.
 239         (dump_subexp_body_f): New function.
 240         (operator_check_f): New function.
 241         (exp_descriptor_f): Replace standard expression handling functions
 242         with new functions.
 243         * gdb/fortran-operator.def: New file.
 244         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 245         * gdb/std-operator.def: Remove UNOP_KIND.
 246
 247 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 248
 249         * std-operator.def: Remove unbalanced, stray double quote
 250         character.
 251
 252 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 253             Chris January  <chris.january@arm.com>
 254             Daniel Everett  <daniel.everett@arm.com>
 255             Nick Forrington  <nick.forrington@arm.com>
 256             Richard Bunt  <richard.bunt@arm.com>
 257
 258         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 259         of depth when printing anonymous structs or unions.
 260         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 261         Don't print either the top-level value, or the children if the
 262         max-depth is exceeded.
 263         (ppscm_print_children): When printing the key of a map, allow one
 264         extra level of depth.
 265         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 266         print either the top-level value, or the children if the max-depth
 267         is exceeded.
 268         (print_children): When printing the key of a map, allow one extra
 269         level of depth.
 270         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 271         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 272         (user_print_options): Initialise max_depth field.
 273         (val_print_scalar_or_string_type_p): New function.
 274         (val_print): Check to see if the max depth has been reached.
 275         (val_print_check_max_depth): Define new function.
 276         (show_print_max_depth): New function.
 277         (_initialize_valprint): Add 'print max-depth' option.
 278         * valprint.h (struct value_print_options) <max_depth>: New field.
 279         (val_print_check_max_depth): Declare new function.
 280         * NEWS: Document new feature.
 281
 282 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 283
 284         * ada-lang.c (ada_language_defn): Initialise new field.
 285         * c-lang.c (c_is_string_type_p): New function.
 286         (c_language_defn): Initialise new field.
 287         (cplus_language_defn): Initialise new field.
 288         (asm_language_defn): Initialise new field.
 289         (minimal_language_defn): Initialise new field.
 290         * c-lang.h (c_is_string_type_p): Declare new function.
 291         * d-lang.c (d_language_defn): Initialise new field.
 292         * f-lang.c (f_is_string_type_p): New function.
 293         (f_language_defn): Initialise new field.
 294         * go-lang.c (go_is_string_type_p): New function.
 295         (go_language_defn): Initialise new field.
 296         * language.c (default_is_string_type_p): New function.
 297         (unknown_language_defn): Initialise new field.
 298         (auto_language_defn): Initialise new field.
 299         * language.h (struct language_defn) <la_is_string_type_p>: New
 300         member variable.
 301         (default_is_string_type_p): Declare new function.
 302         * m2-lang.c (m2_language_defn): Initialise new field.
 303         * objc-lang.c (objc_language_defn): Initialise new field.
 304         * opencl-lang.c (opencl_language_defn): Initialise new field.
 305         * p-lang.c (pascal_is_string_type_p): New function.
 306         (pascal_language_defn): Initialise new field.
 307         * rust-lang.c (rust_is_string_type_p): New function.
 308         (rust_language_defn): Initialise new field.
 309
 310 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 311
 312         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 313         New field.
 314         * ada-lang.c (ada_language_defn): Initialise new field.
 315         * c-lang.c (c_language_defn): Likewise.
 316         (cplus_language_defn): Likewise.
 317         (asm_language_defn): Likewise.
 318         (minimal_language_defn): Likewise.
 319         * d-lang.c (d_language_defn): Likewise.
 320         * f-lang.c (f_language_defn): Likewise.
 321         * go-lang.c (go_language_defn): Likewise.
 322         * language.c (unknown_language_defn): Likewise.
 323         (auto_language_defn): Likewise.
 324         * m2-lang.c (m2_language_defn): Likewise.
 325         * objc-lang.c (objc_language_defn): Likewise.
 326         * opencl-lang.c (opencl_language_defn): Likewise.
 327         * p-lang.c (pascal_language_defn): Likewise.
 328         * rust-lang.c (rust_language_defn): Likewise.
 329
 330 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * ada-lang.c (ada_is_character_type): Change return type to bool.
 333         (ada_is_string_type): Likewise.
 334         * ada-lang.h (ada_is_character_type): Update declaration
 335         (ada_is_string_type): Likewise.
 336
 337 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 338
 339         Support style in 'frame|thread apply'
 340
 341         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 342         * record.c (record_start, record_stop): Update callers of
 343         execute_command_to_string with false.
 344         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 345         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 346         methods.
 347         (class string_file): New constructor with term_out parameter.
 348         Override methods term_out and can_emit_style_escape.  New member
 349         term_out.
 350         (class stdio_file): Override can_emit_style_escape.
 351         (class tee_file): Override term_out and can_emit_style_escape.
 352         * utils.h (can_emit_style_escape): Remove.
 353         * utils.c (can_emit_style_escape): Likewise.
 354         Update all callers of can_emit_style_escape (SOMESTREAM) to
 355         SOMESTREAM->can_emit_style_escape.
 356         * source-cache.c (source_cache::get_source_lines): Likewise.
 357         * stack.c (frame_apply_command_count): Call execute_command_to_string
 358         passing the term_out characteristic of the current gdb_stdout.
 359         * thread.c (thr_try_catch_cmd): Likewise.
 360         * top.c (execute_command_to_string): pass term_out parameter
 361         to construct the string_file for the command output.
 362         * ui-file.c (term_cli_styling): New function (most code moved
 363         from utils.c can_emit_style_escape).
 364         (string_file::string_file, string_file::can_emit_style_escape,
 365         stdio_file::can_emit_style_escape, tee_file::term_out,
 366         tee_file::can_emit_style_escape): New functions.
 367
 368 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 369
 370         * NEWS: Mention the new set|show may-call-functions.
 371         * infcall.c (may_call_functions_p): New variable.
 372         (show_may_call_functions_p): New function.
 373         (call_function_by_hand_dummy): Throws an error if not
 374         may-call-functions.
 375         (_initialize_infcall): Call add_setshow_boolean_cmd for
 376         may-call-functions.
 377
 378 2019-04-25  Keith Seitz  <keiths@redhat.com>
 379
 380         PR c++/24367
 381         * cp-support.c (inspect_type): Don't attempt substitutions
 382         of symbol with the same name.
 383
 384 2019-04-25  Tom Tromey  <tromey@adacore.com>
 385
 386         PR gdb/24475:
 387         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 388         static.
 389
 390 2019-04-25  Tom Tromey  <tromey@adacore.com>
 391
 392         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 393         rvalue reference.
 394         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 395         (gdb_xml_parser::parse): Use std::move.
 396         * python/python-internal.h (gdbpy_convert_exception): Take a const
 397         reference.
 398         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 399         std::move.
 400         * python/py-utils.c (gdbpy_convert_exception): Take a const
 401         reference.
 402         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 403         Use std::move.
 404         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 405         Use std::move.
 406         * mi/mi-main.c (mi_print_exception): Take a const reference.
 407         * main.c (handle_command_errors): Take a const reference.
 408         * linespec.c (parse_linespec): Use std::move.
 409         * infcall.c (run_inferior_call): Use std::move.
 410         (call_function_by_hand_dummy): Use std::move.
 411         * exec.c (try_open_exec_file): Use std::move.
 412         * exceptions.h (exception_print, exception_fprintf)
 413         (exception_print_same): Update.
 414         * exceptions.c (print_exception, exception_print)
 415         (exception_fprintf, exception_print_same): Change parameters to
 416         const reference.
 417         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 418         * common/new-op.c: Use std::move.
 419         * common/common-exceptions.h (struct gdb_exception): Add move
 420         constructor.
 421         (struct gdb_exception_error, struct gdb_exception_quit, struct
 422         gdb_quit_bad_alloc): Change constructor to move constructor.
 423         (throw_exception): Change parameter to rvalue reference.
 424         * common/common-exceptions.c (throw_exception): Take rvalue
 425         reference.
 426         * cli/cli-interp.c (safe_execute_command): Use std::move.
 427         * breakpoint.c (insert_bp_location, location_to_sals): Use
 428         std::move.
 429
 430 2019-04-25  Tom Tromey  <tromey@adacore.com>
 431
 432         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 433         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 434         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 435         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 436         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 437         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 438         guile/scm-value.c: Use unpack.
 439         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 440         gdbscm_gdb_exception.
 441         (gdbscm_throw_gdb_exception): Likewise.
 442         (struct gdbscm_gdb_exception): New.
 443         (unpack): New function.
 444         (gdbscm_wrap): Use unpack.
 445
 446 2019-04-25  Tom Tromey  <tromey@adacore.com>
 447
 448         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 449         (gdb_rl_callback_handler): Use std::move.
 450         * common/common-exceptions.h (struct gdb_exception): Add move
 451         assignment operator.
 452         (throw_exception_sjlj): Change "exception" to const reference.
 453         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 454         (throw_exception_sjlj): Change "exception" to const reference.
 455
 456 2019-04-25  Tom Tromey  <tromey@adacore.com>
 457
 458         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 459         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 460         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 461         Update.
 462         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 463         Update.
 464         * mi/mi-interp.c (mi_interp::exec): Update.
 465         * linespec.c (parse_linespec): Update.
 466         * infcall.c (run_inferior_call): Update.
 467         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 468         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 469         (gdbscm_lookup_global_symbol): Update.
 470         * guile/scm-param.c (gdbscm_parameter_value): Update.
 471         * guile/scm-frame.c (gdbscm_frame_read_register)
 472         (gdbscm_frame_read_var): Update.
 473         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 474         * exec.c (try_open_exec_file): Update.
 475         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 476         (gdb_rl_callback_handler): Update.
 477         * common/common-exceptions.h (exception_none): Don't declare.
 478         * common/common-exceptions.c (exception_none): Don't define.
 479         (struct catcher) <exception>: Update.
 480         * cli/cli-interp.c (safe_execute_command): Update.
 481         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 482
 483 2019-04-25  Ali Tamur  <tamur@google.com>
 484
 485         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 486         (read_attribute_value): Likewise.
 487         (dwarf2_read_addr_index): Update comment.
 488         (read_str_index): Add DW_FORM_strx.
 489         (dwarf2_string_attr): Likewise.
 490         (dwarf2_const_value_attr): Likewise.
 491         (dump_die_shallow): Likewise.
 492         (dwarf2_fetch_constant_bytes): Likewise.
 493         (skip_form_bytes): Likewise.
 494         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 495
 496 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 497
 498         PR corefiles/11608
 499         PR corefiles/18187
 500         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 501         OFFSET.  Verify if current mapping contains an ELF header.
 502         (linux_find_memory_regions_full): Adjust call to
 503         dump_mapping_p.
 504
 505 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 506             Kang Li <kanglictf@gmail.com>
 507
 508         PR gdb/21600
 509
 510         * dwarf2-frame.c (read_initial_length): Be consistent about using
 511         unsigned representation of length.
 512         (decode_frame_entry_1): Likewise.  Check for wraparound of
 513         end pointer as well as buffer overflow.
 514
 515 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 516
 517         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 518         "vq".
 519
 520 2019-04-24  Tom Tromey  <tromey@adacore.com>
 521
 522         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 523
 524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 525
 526         * s12z-tdep.c (s12z_unwind_pc): Delete.
 527         (s12z_unwind_sp): Delete.
 528         (s12z_gdbarch_init): Don't register deleted functions with
 529         gdbarch.
 530
 531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * rl78-tdep.c (rl78_unwind_sp): Delete.
 534         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 535
 536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 537
 538         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 539         (xstormy16_unwind_pc): Delete.
 540         (xstormy16_dummy_id): Delete.
 541         (xstormy16_gdbarch_init): Don't register deleted functions with
 542         gdbarch.
 543
 544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 545
 546         * vax-tdep.c (vax_unwind_pc): Delete.
 547         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 548
 549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * v850-tdep.c (v850_unwind_sp): Delete.
 552         (v850_unwind_pc): Delete.
 553         (v850_dummy_id): Delete.
 554         (v850_gdbarch_init): Don't register deleted functions with
 555         gdbarch.
 556
 557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 560         (tilegx_unwind_pc): Delete.
 561         (tilegx_unwind_dummy_id): Delete.
 562         (tilegx_gdbarch_init): Don't register deleted functions with
 563         gdbarch.
 564
 565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 568         (tic6x_dummy_id): Delete.
 569         (tic6x_gdbarch_init): Don't register deleted functions with
 570         gdbarch.
 571
 572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * sparc-tdep.c (sparc_unwind_pc): Delete.
 575         (sparc32_gdbarch_init): Don't register deleted function with
 576         gdbarch.
 577
 578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 579
 580         * sh-tdep.c (sh_unwind_sp): Delete.
 581         (sh_unwind_pc): Delete.
 582         (sh_dummy_id): Delete.
 583         (sh_gdbarch_init): Don't register deleted functions with
 584         gdbarch.
 585
 586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 587
 588         * score-tdep.c (score_unwind_sp): Delete.
 589         (score_unwind_pc): Delete.
 590         (score_dummy_id): Delete.
 591         (score_gdbarch_init): Don't register deleted functions with
 592         gdbarch.
 593
 594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 595
 596         * rx-tdep.c (rx_unwind_pc): Delete.
 597         (rx_unwind_sp): Delete.
 598         (rx_dummy_id): Delete.
 599         (rx_gdbarch_init): Don't register deleted functions with
 600         gdbarch.  Update comment.
 601
 602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 603
 604         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 605         (rs6000_dummy_id): Delete.
 606         (rs6000_gdbarch_init): Don't register deleted functions with
 607         gdbarch.
 608
 609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 610
 611         * or1k-tdep.c (or1k_dummy_id): Delete.
 612         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 613
 614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 615
 616         * nios2-tdep.c (nios2_dummy_id): Delete.
 617         (nios2_unwind_sp): Delete.
 618         (nios2_gdbarch_init): Don't register deleted functions with
 619         gdbarch.
 620
 621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 622
 623         * nds32-tdep.c (nds32_dummy_id): Delete.
 624         (nds32_unwind_pc): Delete.
 625         (nds32_unwind_sp): Delete.
 626         (nds32_gdbarch_init): Don't register deleted functions with
 627         gdbarch.
 628
 629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 630
 631         * msp430-tdep.c (msp430_unwind_pc): Delete.
 632         (msp430_unwind_sp): Delete.
 633         (msp430_dummy_id): Delete.
 634         (msp430_gdbarch_init): Don't register deleted functions with
 635         gdbarch.
 636
 637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * moxie-tdep.c (moxie_unwind_sp): Delete.
 640         (moxie_unwind_pc): Delete.
 641         (moxie_dummy_id): Delete.
 642         (moxie_gdbarch_init): Don't register deleted functions with
 643         gdbarch.
 644
 645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 646
 647         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 648         (mn10300_unwind_pc): Delete.
 649         (mn10300_unwind_sp): Delete.
 650         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 651         mn10300_unwind_sp.
 652         (mn10300_frame_unwind_init): Don't register deleted functions with
 653         gdbarch.
 654
 655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 656
 657         * mep-tdep.c (mep_unwind_pc): Delete.
 658         (mep_unwind_sp): Delete.
 659         (mep_dummy_id): Delete.
 660         (mep_gdbarch_init): Don't register deleted functions with
 661         gdbarch.
 662
 663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 664
 665         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 666         (m68hc11_unwind_sp): Delete.
 667         (m68hc11_gdbarch_init): Don't register deleted functions with
 668         gdbarch.
 669
 670 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 671
 672         * m32r-tdep.c (m32r_unwind_sp): Delete.
 673         (m32r_unwind_pc): Delete.
 674         (m32r_dummy_id): Delete.
 675         (m32r_gdbarch_init): Don't register deleted functions with
 676         gdbarch.
 677
 678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 679
 680         * m32c-tdep.c (m32c_unwind_pc): Delete.
 681         (m32c_unwind_sp): Delete.
 682         (m32c_dummy_id): Delete.
 683         (m32c_gdbarch_init): Don't register deleted functions with
 684         gdbarch.
 685
 686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 687
 688         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 689         (lm32_unwind_pc): Delete.
 690         (lm32_dummy_id): Delete.
 691         (lm32_gdbarch_init): Don't register deleted functions with
 692         gdbarch.
 693
 694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 697         (iq2000_unwind_pc): Delete.
 698         (iq2000_dummy_id): Delete.
 699         (iq2000_gdbarch_init): Don't register deleted functions with
 700         gdbarch.
 701
 702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 703
 704         * nds32-tdep.c (nds32_type_align): Delete.
 705         (nds32_push_dummy_call): Use type_align instead.
 706
 707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 708
 709         * arm-tdep.c (arm_type_align): Only handle vector override case.
 710         (arm_push_dummy_call): Use type_align.
 711         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 712
 713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 714
 715         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 716         case.
 717         (pass_on_stack): Use type_align.
 718         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 719         function.
 720
 721 2019-04-23  Tom Tromey  <tromey@adacore.com>
 722
 723         * dwarf2read.c (line_header::file_name_at): Remove unused
 724         overload.
 725
 726 2019-04-23  Tom de Vries  <tdevries@suse.de>
 727
 728         PR gdb/24438
 729         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 730         invocation.
 731
 732
 733 2019-03-27  Ali Tamur  <tamur@google.com>
 734
 735         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 736         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 737         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 738         (dwarf_expr_context::get_addr_index): Likewise
 739         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 740         (symbol_needs_eval_context::get_addr_index): Likewise
 741         (disassemble_dwarf_expression): Add DW_OP_addrx
 742         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 743         (read_cutu_die_from_dwo): Update comment
 744         (skip_one_die): Add DW_FORM_addrx
 745         (read_attribute_value): Likewise
 746         (var_decode_location): Add DW_OP_addrx
 747         (dwarf2_const_value_attr): Add DW_FORM_addrx
 748         (dump_die_shallow): Likewise
 749         (dwarf2_fetch_constant_bytes): Likewise
 750         (decode_locdesc): Add DW_OP_addrx
 751         (skip_form_bytes): Add DW_FORM_addrx
 752
 753 2019-04-22  Ali Tamur  <tamur@google.com>
 754
 755         * MAINTAINERS (Write After Approval): Add self.
 756
 757 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 758
 759         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 760         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 761         (open_symbol_file_object): Likewise.
 762         (svr4_default_sos): Add info parameter.
 763         (svr4_read_so_list): Likewise.
 764         (svr4_current_sos_direct): Adjust functions calls to pass down
 765         info.
 766         (svr4_current_sos_1): Add info parameter.
 767         (svr4_current_sos): Call get_svr4_info, pass info down to
 768         svr4_current_sos_1.
 769         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 770         get_svr4_info.
 771         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 772         get_svr4_info.
 773         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 774         to get_svr4_info.
 775         (probes_table_remove_objfile_probes): Likewise.
 776         (register_solib_event_probe): Add info parameter.
 777         (solist_update_incremental): Pass info parameter down to
 778         svr4_read_so_list.
 779         (disable_probes_interface): Add info parameter.
 780         (svr4_handle_solib_event): Pass current_program_space to
 781         get_svr4_info.  Adjust disable_probes_interface cleanup.
 782         (svr4_create_probe_breakpoints): Add info parameter, pass it
 783         down to register_solib_event_probe.
 784         (svr4_create_solib_event_breakpoints): Add info parameter,
 785         pass it down to svr4_create_probe_breakpoints.
 786         (enable_break): Pass info down to
 787         svr4_create_solib_event_breakpoints.
 788         (svr4_solib_create_inferior_hook): Pass current_program_space to
 789         get_svr4_info.
 790         (svr4_clear_solib): Likewise.
 791
 792 2019-04-22  Pedro Alves  <palves@redhat.com>
 793
 794         * solib-svr4.c (svr4_free_objfile_observer): New.
 795         (probe_and_action::objfile): New field.
 796         (probes_table_htab_remove_objfile_probes)
 797         (probes_table_remove_objfile_probes): New functions.
 798         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 799         in the new probe_and_action.  Don't store the probe in 'lookup'.
 800         (svr4_create_probe_breakpoints): Pass objfile to
 801         register_solib_event_probe.
 802         (_initialize_svr4_solib): Register a free_objfile observer.
 803
 804 2019-04-19  Tom Tromey  <tom@tromey.com>
 805
 806         * common/queue.h: Remove.
 807
 808 2019-04-19  Tom Tromey  <tom@tromey.com>
 809
 810         * event-loop.c: Don't include "common/queue.h".
 811
 812 2019-04-19  Tom Tromey  <tom@tromey.com>
 813
 814         * remote.c (remote_target): Use delete.
 815         * remote-notif.h: Include <list>, not "common/queue.h".
 816         (notif_client_p): Remove typedef.
 817         (remote_notif_state): Add constructor, destructor, initializer.
 818         <notif_queue>: Now a std::list.
 819         (remote_notif_state_xfree): Don't declare.
 820         * remote-notif.c (remote_notif_process, handle_notification)
 821         (remote_notif_state_allocate): Update.
 822         (~remote_notif_state): Rename from remote_notif_state_xfree.
 823
 824 2019-04-19  Tom Tromey  <tom@tromey.com>
 825
 826         * symfile.c (reread_symbols): Update.
 827         * objfiles.c (objfile_register_static_link)
 828         (objfile_lookup_static_link): Update
 829         (~objfile) Don't delete static_links.
 830         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 831
 832 2019-04-19  Tom Tromey  <tom@tromey.com>
 833
 834         * type-stack.h (struct type_stack) <insert>: Constify string.
 835         * type-stack.c (type_stack::insert): Constify string.
 836         * gdbtypes.h (lookup_template_type): Update.
 837         (address_space_name_to_int): Update.
 838         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 839         const.
 840         (lookup_template_type): Make name const.
 841         * c-exp.y: Update rules.
 842         (lex_one_token, classify_name, classify_inner_name)
 843         (c_print_token): Update.
 844         * p-exp.y: Update rules.
 845         (yylex): Update.
 846         * f-exp.y: Update rules.
 847         (yylex): Update.
 848         * d-exp.y: Update rules.
 849         (lex_one_token, classify_name, classify_inner_name): Update.
 850         * parse.c (write_dollar_variable, copy_name): Return std::string.
 851         * parser-defs.h (copy_name): Change return type.
 852         * m2-exp.y: Update rules.
 853         (yylex): Update.
 854         * go-exp.y (lex_one_token): Update.
 855         Update rules.
 856         (classify_unsafe_function, classify_packaged_name)
 857         (classify_name, yylex): Update.
 858
 859 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 860
 861         * configure.ac: add --enable-source-highlight switch.
 862         * configure: Regenerate.
 863         * top.c (print_gdb_version): plumb --enable-source-highlight
 864         status to "show configuration".
 865
 866 2019-04-19  Tom Tromey  <tromey@adacore.com>
 867
 868         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 869         Check ADA_TYPE_P.
 870         (empty_record, ada_template_to_fixed_record_type_1)
 871         (template_to_static_fixed_type)
 872         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 873         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 874         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 875         macros.
 876
 877 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 878
 879         PR symtab/24423:
 880         * source.c (print_source_lines_base): Advance "iter" when a
 881         control character is seen.
 882
 883 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 884
 885         * inferior.h (struct infcall_suspend_state_deleter):
 886         Catch exception in destructor to avoid crash.
 887
 888 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 889
 890         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 891         close to the add_com "shell".
 892
 893 2019-04-18  Tom Tromey  <tromey@adacore.com>
 894
 895         * process-stratum-target.h (class process_stratum_target)
 896         <stratum>: Add "final".
 897
 898 2019-04-17  Tom Tromey  <tromey@adacore.com>
 899
 900         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 901         against nullptr before use.
 902
 903 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 904
 905         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 906
 907 2019-04-17  Jim Wilson  <jimw@sifive.com>
 908             Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 911         code read might fail, assume 4-byte breakpoint in that case.
 912
 913 2019-04-15  Leszek Swirski  <leszeks@google.com>
 914
 915         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 916         rather than a hand-rolled POD check when checking for forced MEMORY
 917         classification.
 918
 919 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 920
 921         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 922         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 923         function.
 924         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 925         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 926         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 927         declaration.
 928
 929 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 930
 931         * aarch64-linux-nat.c
 932         (aarch64_linux_nat_target::thread_architecture): Add override.
 933         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 934         each VQ.
 935
 936 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 937
 938         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 939
 940 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 941
 942         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 943         target types of size 96-bits, add some additional comments, and
 944         check that the builtin type we found was the correct size.
 945
 946 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 947
 948         * utils.c (prompt_for_continue): Don't restore the styling at the
 949         end, as applied_style has the wrong value.  This fixes styling in
 950         long lists of file names that are interrupted by the "Continue?"
 951         prompt.
 952
 953 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 956         * c-lang.c (c_language_defn): Likewise.
 957         (cplus_language_defn): Likewise.
 958         (asm_language_defn): Likewise.
 959         (minimal_language_defn): Likewise.
 960         * d-lang.c (d_language_defn): Likewise.
 961         * f-lang.c (f_language_defn): Likewise.
 962         * go-lang.c (go_language_defn): Likewise.
 963         * language.c (unknown_language_defn): Likewise.
 964         (auto_language_defn): Likewise.
 965         * language.h (struct language_defn): Remove la_magic field.
 966         (LANG_MAGIC): Delete.
 967         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 968         * objc-lang.c (objc_language_defn): Likewise.
 969         * opencl-lang.c (opencl_language_defn): Likewise.
 970         * p-lang.c (pascal_language_defn): Likewise.
 971         * rust-lang.c (rust_language_defn): Likewise.
 972
 973 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         * riscv-tdep.c (riscv_type_align): New function.
 976         (riscv_type_alignment): Delete.
 977         (riscv_arg_location): Use 'type_align'.
 978         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 979
 980 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * gdbtypes.c (type_align): A struct with no non-static fields also
 983         has alignment of 1.
 984
 985 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 986
 987         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 988         component to 0.
 989         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 990         member.
 991         (riscv_struct_info::analyse): New implementation using new
 992         analyse_inner member function.
 993         (riscv_struct_info::field_offset): New member function.
 994         (riscv_struct_info::m_offsets): New member variable.
 995         (riscv_struct_info::analyse_inner): New private member function,
 996         takes the old implementation of riscv_struct_info::analyse but
 997         extended to track field offsets.
 998         (riscv_call_arg_struct): Update the struct folding special cases
 999         to handle cases where empty C++ structs, which are non-zero
1000         length, are found.
1001         (riscv_arg_location): Initialise the length of each location, a
1002         non-zero length now indicates the location is in use.
1003         (riscv_push_dummy_call): Allow for the first location having a
1004         non-zero offset when setting up arguments.
1005         (riscv_return_value): Likewise, but for return values.
1006
1007 2019-04-11  Tom Tromey  <tromey@adacore.com>
1008
1009         * utils.c (internal_vproblem): Make "msg" const.
1010
1011 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1012
1013         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1014         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1015         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1016         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1017
1018 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1019
1020         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1021         function.
1022         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1023         of amd64_collect_native_gregset.
1024         (amd64_linux_nat_target::store_registers): Likewise.
1025
1026 2019-04-10  Tom Tromey  <tom@tromey.com>
1027
1028         * symtab.c (lookup_global_symbol_from_objfile)
1029         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1030         * objfiles.h (class separate_debug_iterator): New.
1031         (class separate_debug_range): New.
1032         (struct objfile) <separate_debug_objfiles>: New method.
1033         (objfile_separate_debug_iterate): Don't declare.
1034         * objfiles.c (separate_debug_iterator::operator++): Rename from
1035         objfile_separate_debug_iterate.
1036         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1037         iterator.
1038         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1039         iterator.
1040
1041 2019-04-10  Tom Tromey  <tom@tromey.com>
1042
1043         * symfile.c (reread_symbols): Remove old comment.
1044         * objfiles.c (free_all_objfiles): Fix a typo.
1045
1046 2019-04-10  Tom Tromey  <tom@tromey.com>
1047
1048         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1049         * minsyms.c (lookup_minimal_symbol): Use foreach.
1050         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1051         (lookup_minimal_symbol_solib_trampoline): Likewise.
1052         * symfile.c (reread_symbols): Use foreach.
1053
1054 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1055             Tom Tromey  <tromey@adacore.com>
1056
1057         PR rust/24414:
1058         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1059         (rust_lex_int_test): Change "value" to be LONGEST.
1060         (rust_lex_tests): Add test for long integer literal.
1061
1062 2019-04-09  Tom Tromey  <tromey@adacore.com>
1063
1064         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1065         to bool.
1066         (extended_remote_target::attach): Update.
1067         (remote_target::remote_notice_new_inferior): Update.
1068         (remote_target::add_current_inferior_and_thread): Update.
1069         * inferior.c (exit_inferior_1): Use "false".
1070         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1071
1072 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1073
1074         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1075         the "start" command.
1076
1077 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1078
1079         * python/py-inferior.c (infpy_thread_from_thread_handle):
1080         Adjust comments to reflect renaming of thread_from_thread_handle
1081         to thread_from_handle.  Adjust keywords.  Fix type error message.
1082         (inferior_object_methods): Add thread_from_handle.  Retain
1083         thread_from_thread_handle, but mark it as deprecated.
1084
1085 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1086
1087         * gdbthread.h (find_thread_by_handle): Revise declaration.
1088         * thread.c (find_thread_by_handle): Likewise.  Adjust
1089         implementation too.
1090         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1091         support for buffer objects as handles.
1092
1093 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1094
1095         * python/py-infthread.c (thpy_thread_handle): New function.
1096         (thread_object_methods): Register thpy_thread_handle.
1097
1098 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1099
1100         * gdbthread.h (thread_to_thread_handle): Declare.
1101         * thread.c (gdbtypes.h): Include.
1102         (thread_to_thread_handle): New function.
1103
1104         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1105         (target_thread_info_to_thread_handle): Declare.
1106         * target.c (target_thread_info_to_thread_handle): New function.
1107         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1108         * target-delegates.c: Regenerate.
1109
1110         * linux-thread-db.c (class thread_db_target): Add method
1111         thread_info_to_thread_handle.
1112         (thread_db_target::thread_info_to_thread_handle): Define.
1113         * remote.c (class remote_target): Add new method
1114         thread_info_to_thread_handle.
1115         (remote_target::thread_info_to_thread_handle): Define.
1116
1117 2019-04-08  Pedro Alves  <palves@redhat.com>
1118
1119         * common/common-exceptions.c (throw_exception): Don't create
1120         named object to throw; throw directly.
1121         (throw_it): Likewise.  Don't initialize gdb_exception::message
1122         here, with new; pass FMT and AP to the ctor instead.
1123         * common/common-exceptions.h: Include <string>.
1124         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1125         const char *, va_list)): New ctor.  Use std::make_shared.
1126         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1127         errors)): Delete.
1128         (gdb_exception_error::gdb_exception_error(enum errors, const char
1129         *, va_list)): New.
1130         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1131         Add assertion.
1132         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1133         errors)): Delete.
1134         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1135         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1136         Add assertion.
1137
1138 2019-04-08  Tom Tromey  <tom@tromey.com>
1139
1140         * valops.c (value_rtti_indirect_type): Replace throw_exception
1141         with throw.
1142         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1143         with throw.
1144         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1145         throw.
1146         * target.c (target_translate_tls_address): Replace throw_exception
1147         with throw.
1148         * stack.c (frame_apply_command_count): Replace throw_exception
1149         with throw.
1150         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1151         throw.
1152         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1153         with throw.
1154         * rs6000-tdep.c (rs6000_frame_cache)
1155         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1156         * remote.c: Replace throw_exception with throw.
1157         * record-full.c (record_full_message, record_full_wait_1)
1158         (record_full_restore): Replace throw_exception with throw.
1159         * record-btrace.c:
1160         (get_thread_current_frame_id, record_btrace_start_replaying)
1161         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1162         (cmd_record_btrace_start): Replace throw_exception with throw.
1163         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1164         throw.
1165         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1166         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1167         * linespec.c:
1168         (find_linespec_symbols): Replace throw_exception with throw.
1169         * infrun.c (displaced_step_prepare, resume): Replace
1170         throw_exception with throw.
1171         * infcmd.c (post_create_inferior): Replace throw_exception with
1172         throw.
1173         * inf-loop.c (inferior_event_handler): Replace throw_exception
1174         with throw.
1175         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1176         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1177         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1178         (get_prev_frame_always, get_frame_pc_if_available)
1179         (get_frame_address_in_block_if_available, get_frame_language):
1180         Replace throw_exception with throw.
1181         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1182         throw_exception with throw.
1183         * eval.c (fetch_subexp_value, evaluate_var_value)
1184         (evaluate_funcall, evaluate_subexp_standard): Replace
1185         throw_exception with throw.
1186         * dwarf2loc.c (call_site_find_chain)
1187         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1188         Replace throw_exception with throw.
1189         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1190         with throw.
1191         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1192         throw.
1193         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1194         * completer.c (complete_line_internal): Replace throw_exception
1195         with throw.
1196         * compile/compile-object-run.c (compile_object_run): Replace
1197         throw_exception with throw.
1198         * cli/cli-script.c (process_next_line): Replace throw_exception
1199         with throw.
1200         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1201         (btrace_enable, btrace_maint_update_pt_packets): Replace
1202         throw_exception with throw.
1203         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1204         throw_exception with throw.
1205         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1206         throw_exception with throw.
1207         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1208         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1209         * aarch64-tdep.c (aarch64_make_prologue_cache)
1210         (aarch64_make_stub_cache): Replace throw_exception with throw.
1211
1212 2019-04-08  Tom Tromey  <tom@tromey.com>
1213
1214         * common/common-exceptions.c (throw_exception): Rename from
1215         throw_exception_cxx.  Remove old copy.  Make argument const.
1216         (throw_it): Create and throw exception objects directly.
1217         * common/common-exceptions.h (throw_exception): Make argument
1218         const.
1219         (struct gdb_exception_error): Add constructor.
1220         (struct gdb_exception_quit): Add constructor.
1221
1222 2019-04-08  Tom Tromey  <tom@tromey.com>
1223
1224         * common/common-exceptions.h (exception_rethrow): Don't declare.
1225         (TRY_SJLJ): Update comment.
1226         (TRY, CATCH, END_CATCH): Remove.
1227         * common/common-exceptions.c (exception_rethrow): Remove.
1228
1229 2019-04-08  Tom Tromey  <tom@tromey.com>
1230
1231         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1232         Remove.
1233         (gdb_exception_error): Rename from
1234         gdb_exception_RETURN_MASK_ERROR.
1235         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1236         (gdb_quit_bad_alloc): Update.
1237         * aarch64-tdep.c: Update.
1238         * ada-lang.c: Update.
1239         * ada-typeprint.c: Update.
1240         * ada-valprint.c: Update.
1241         * amd64-tdep.c: Update.
1242         * arch-utils.c: Update.
1243         * break-catch-throw.c: Update.
1244         * breakpoint.c: Update.
1245         * btrace.c: Update.
1246         * c-varobj.c: Update.
1247         * cli/cli-cmds.c: Update.
1248         * cli/cli-interp.c: Update.
1249         * cli/cli-script.c: Update.
1250         * common/common-exceptions.c: Update.
1251         * common/new-op.c: Update.
1252         * common/selftest.c: Update.
1253         * compile/compile-c-symbols.c: Update.
1254         * compile/compile-cplus-symbols.c: Update.
1255         * compile/compile-object-load.c: Update.
1256         * compile/compile-object-run.c: Update.
1257         * completer.c: Update.
1258         * corelow.c: Update.
1259         * cp-abi.c: Update.
1260         * cp-support.c: Update.
1261         * cp-valprint.c: Update.
1262         * darwin-nat.c: Update.
1263         * disasm-selftests.c: Update.
1264         * dtrace-probe.c: Update.
1265         * dwarf-index-cache.c: Update.
1266         * dwarf-index-write.c: Update.
1267         * dwarf2-frame-tailcall.c: Update.
1268         * dwarf2-frame.c: Update.
1269         * dwarf2loc.c: Update.
1270         * dwarf2read.c: Update.
1271         * eval.c: Update.
1272         * event-loop.c: Update.
1273         * event-top.c: Update.
1274         * exec.c: Update.
1275         * f-valprint.c: Update.
1276         * fbsd-tdep.c: Update.
1277         * frame-unwind.c: Update.
1278         * frame.c: Update.
1279         * gdbtypes.c: Update.
1280         * gnu-v3-abi.c: Update.
1281         * guile/guile-internal.h: Update.
1282         * guile/scm-block.c: Update.
1283         * guile/scm-breakpoint.c: Update.
1284         * guile/scm-cmd.c: Update.
1285         * guile/scm-disasm.c: Update.
1286         * guile/scm-frame.c: Update.
1287         * guile/scm-lazy-string.c: Update.
1288         * guile/scm-math.c: Update.
1289         * guile/scm-param.c: Update.
1290         * guile/scm-ports.c: Update.
1291         * guile/scm-pretty-print.c: Update.
1292         * guile/scm-symbol.c: Update.
1293         * guile/scm-symtab.c: Update.
1294         * guile/scm-type.c: Update.
1295         * guile/scm-value.c: Update.
1296         * i386-linux-tdep.c: Update.
1297         * i386-tdep.c: Update.
1298         * inf-loop.c: Update.
1299         * infcall.c: Update.
1300         * infcmd.c: Update.
1301         * infrun.c: Update.
1302         * jit.c: Update.
1303         * language.c: Update.
1304         * linespec.c: Update.
1305         * linux-fork.c: Update.
1306         * linux-nat.c: Update.
1307         * linux-tdep.c: Update.
1308         * linux-thread-db.c: Update.
1309         * main.c: Update.
1310         * mi/mi-cmd-break.c: Update.
1311         * mi/mi-cmd-stack.c: Update.
1312         * mi/mi-interp.c: Update.
1313         * mi/mi-main.c: Update.
1314         * objc-lang.c: Update.
1315         * p-valprint.c: Update.
1316         * parse.c: Update.
1317         * ppc-linux-tdep.c: Update.
1318         * printcmd.c: Update.
1319         * python/py-arch.c: Update.
1320         * python/py-breakpoint.c: Update.
1321         * python/py-cmd.c: Update.
1322         * python/py-finishbreakpoint.c: Update.
1323         * python/py-frame.c: Update.
1324         * python/py-framefilter.c: Update.
1325         * python/py-gdb-readline.c: Update.
1326         * python/py-inferior.c: Update.
1327         * python/py-infthread.c: Update.
1328         * python/py-lazy-string.c: Update.
1329         * python/py-linetable.c: Update.
1330         * python/py-objfile.c: Update.
1331         * python/py-param.c: Update.
1332         * python/py-prettyprint.c: Update.
1333         * python/py-progspace.c: Update.
1334         * python/py-record-btrace.c: Update.
1335         * python/py-record.c: Update.
1336         * python/py-symbol.c: Update.
1337         * python/py-type.c: Update.
1338         * python/py-unwind.c: Update.
1339         * python/py-utils.c: Update.
1340         * python/py-value.c: Update.
1341         * python/python.c: Update.
1342         * record-btrace.c: Update.
1343         * record-full.c: Update.
1344         * remote-fileio.c: Update.
1345         * remote.c: Update.
1346         * riscv-tdep.c: Update.
1347         * rs6000-aix-tdep.c: Update.
1348         * rs6000-tdep.c: Update.
1349         * rust-exp.y: Update.
1350         * rust-lang.c: Update.
1351         * s390-tdep.c: Update.
1352         * selftest-arch.c: Update.
1353         * solib-dsbt.c: Update.
1354         * solib-frv.c: Update.
1355         * solib-spu.c: Update.
1356         * solib-svr4.c: Update.
1357         * solib.c: Update.
1358         * sparc64-linux-tdep.c: Update.
1359         * stack.c: Update.
1360         * symfile-mem.c: Update.
1361         * symmisc.c: Update.
1362         * target.c: Update.
1363         * thread.c: Update.
1364         * top.c: Update.
1365         * tracefile-tfile.c: Update.
1366         * tui/tui.c: Update.
1367         * typeprint.c: Update.
1368         * unittests/cli-utils-selftests.c: Update.
1369         * unittests/parse-connection-spec-selftests.c: Update.
1370         * valops.c: Update.
1371         * valprint.c: Update.
1372         * value.c: Update.
1373         * varobj.c: Update.
1374         * windows-nat.c: Update.
1375         * x86-linux-nat.c: Update.
1376         * xml-support.c: Update.
1377
1378 2019-04-08  Tom Tromey  <tom@tromey.com>
1379
1380         * xml-support.c: Use C++ exception handling.
1381         * x86-linux-nat.c: Use C++ exception handling.
1382         * windows-nat.c: Use C++ exception handling.
1383         * varobj.c: Use C++ exception handling.
1384         * value.c: Use C++ exception handling.
1385         * valprint.c: Use C++ exception handling.
1386         * valops.c: Use C++ exception handling.
1387         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1388         handling.
1389         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1390         * typeprint.c: Use C++ exception handling.
1391         * tui/tui.c: Use C++ exception handling.
1392         * tracefile-tfile.c: Use C++ exception handling.
1393         * top.c: Use C++ exception handling.
1394         * thread.c: Use C++ exception handling.
1395         * target.c: Use C++ exception handling.
1396         * symmisc.c: Use C++ exception handling.
1397         * symfile-mem.c: Use C++ exception handling.
1398         * stack.c: Use C++ exception handling.
1399         * sparc64-linux-tdep.c: Use C++ exception handling.
1400         * solib.c: Use C++ exception handling.
1401         * solib-svr4.c: Use C++ exception handling.
1402         * solib-spu.c: Use C++ exception handling.
1403         * solib-frv.c: Use C++ exception handling.
1404         * solib-dsbt.c: Use C++ exception handling.
1405         * selftest-arch.c: Use C++ exception handling.
1406         * s390-tdep.c: Use C++ exception handling.
1407         * rust-lang.c: Use C++ exception handling.
1408         * rust-exp.y: Use C++ exception handling.
1409         * rs6000-tdep.c: Use C++ exception handling.
1410         * rs6000-aix-tdep.c: Use C++ exception handling.
1411         * riscv-tdep.c: Use C++ exception handling.
1412         * remote.c: Use C++ exception handling.
1413         * remote-fileio.c: Use C++ exception handling.
1414         * record-full.c: Use C++ exception handling.
1415         * record-btrace.c: Use C++ exception handling.
1416         * python/python.c: Use C++ exception handling.
1417         * python/py-value.c: Use C++ exception handling.
1418         * python/py-utils.c: Use C++ exception handling.
1419         * python/py-unwind.c: Use C++ exception handling.
1420         * python/py-type.c: Use C++ exception handling.
1421         * python/py-symbol.c: Use C++ exception handling.
1422         * python/py-record.c: Use C++ exception handling.
1423         * python/py-record-btrace.c: Use C++ exception handling.
1424         * python/py-progspace.c: Use C++ exception handling.
1425         * python/py-prettyprint.c: Use C++ exception handling.
1426         * python/py-param.c: Use C++ exception handling.
1427         * python/py-objfile.c: Use C++ exception handling.
1428         * python/py-linetable.c: Use C++ exception handling.
1429         * python/py-lazy-string.c: Use C++ exception handling.
1430         * python/py-infthread.c: Use C++ exception handling.
1431         * python/py-inferior.c: Use C++ exception handling.
1432         * python/py-gdb-readline.c: Use C++ exception handling.
1433         * python/py-framefilter.c: Use C++ exception handling.
1434         * python/py-frame.c: Use C++ exception handling.
1435         * python/py-finishbreakpoint.c: Use C++ exception handling.
1436         * python/py-cmd.c: Use C++ exception handling.
1437         * python/py-breakpoint.c: Use C++ exception handling.
1438         * python/py-arch.c: Use C++ exception handling.
1439         * printcmd.c: Use C++ exception handling.
1440         * ppc-linux-tdep.c: Use C++ exception handling.
1441         * parse.c: Use C++ exception handling.
1442         * p-valprint.c: Use C++ exception handling.
1443         * objc-lang.c: Use C++ exception handling.
1444         * mi/mi-main.c: Use C++ exception handling.
1445         * mi/mi-interp.c: Use C++ exception handling.
1446         * mi/mi-cmd-stack.c: Use C++ exception handling.
1447         * mi/mi-cmd-break.c: Use C++ exception handling.
1448         * main.c: Use C++ exception handling.
1449         * linux-thread-db.c: Use C++ exception handling.
1450         * linux-tdep.c: Use C++ exception handling.
1451         * linux-nat.c: Use C++ exception handling.
1452         * linux-fork.c: Use C++ exception handling.
1453         * linespec.c: Use C++ exception handling.
1454         * language.c: Use C++ exception handling.
1455         * jit.c: Use C++ exception handling.
1456         * infrun.c: Use C++ exception handling.
1457         * infcmd.c: Use C++ exception handling.
1458         * infcall.c: Use C++ exception handling.
1459         * inf-loop.c: Use C++ exception handling.
1460         * i386-tdep.c: Use C++ exception handling.
1461         * i386-linux-tdep.c: Use C++ exception handling.
1462         * guile/scm-value.c: Use C++ exception handling.
1463         * guile/scm-type.c: Use C++ exception handling.
1464         * guile/scm-symtab.c: Use C++ exception handling.
1465         * guile/scm-symbol.c: Use C++ exception handling.
1466         * guile/scm-pretty-print.c: Use C++ exception handling.
1467         * guile/scm-ports.c: Use C++ exception handling.
1468         * guile/scm-param.c: Use C++ exception handling.
1469         * guile/scm-math.c: Use C++ exception handling.
1470         * guile/scm-lazy-string.c: Use C++ exception handling.
1471         * guile/scm-frame.c: Use C++ exception handling.
1472         * guile/scm-disasm.c: Use C++ exception handling.
1473         * guile/scm-cmd.c: Use C++ exception handling.
1474         * guile/scm-breakpoint.c: Use C++ exception handling.
1475         * guile/scm-block.c: Use C++ exception handling.
1476         * guile/guile-internal.h: Use C++ exception handling.
1477         * gnu-v3-abi.c: Use C++ exception handling.
1478         * gdbtypes.c: Use C++ exception handling.
1479         * frame.c: Use C++ exception handling.
1480         * frame-unwind.c: Use C++ exception handling.
1481         * fbsd-tdep.c: Use C++ exception handling.
1482         * f-valprint.c: Use C++ exception handling.
1483         * exec.c: Use C++ exception handling.
1484         * event-top.c: Use C++ exception handling.
1485         * event-loop.c: Use C++ exception handling.
1486         * eval.c: Use C++ exception handling.
1487         * dwarf2read.c: Use C++ exception handling.
1488         * dwarf2loc.c: Use C++ exception handling.
1489         * dwarf2-frame.c: Use C++ exception handling.
1490         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1491         * dwarf-index-write.c: Use C++ exception handling.
1492         * dwarf-index-cache.c: Use C++ exception handling.
1493         * dtrace-probe.c: Use C++ exception handling.
1494         * disasm-selftests.c: Use C++ exception handling.
1495         * darwin-nat.c: Use C++ exception handling.
1496         * cp-valprint.c: Use C++ exception handling.
1497         * cp-support.c: Use C++ exception handling.
1498         * cp-abi.c: Use C++ exception handling.
1499         * corelow.c: Use C++ exception handling.
1500         * completer.c: Use C++ exception handling.
1501         * compile/compile-object-run.c: Use C++ exception handling.
1502         * compile/compile-object-load.c: Use C++ exception handling.
1503         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1504         * compile/compile-c-symbols.c: Use C++ exception handling.
1505         * common/selftest.c: Use C++ exception handling.
1506         * common/new-op.c: Use C++ exception handling.
1507         * cli/cli-script.c: Use C++ exception handling.
1508         * cli/cli-interp.c: Use C++ exception handling.
1509         * cli/cli-cmds.c: Use C++ exception handling.
1510         * c-varobj.c: Use C++ exception handling.
1511         * btrace.c: Use C++ exception handling.
1512         * breakpoint.c: Use C++ exception handling.
1513         * break-catch-throw.c: Use C++ exception handling.
1514         * arch-utils.c: Use C++ exception handling.
1515         * amd64-tdep.c: Use C++ exception handling.
1516         * ada-valprint.c: Use C++ exception handling.
1517         * ada-typeprint.c: Use C++ exception handling.
1518         * ada-lang.c: Use C++ exception handling.
1519         * aarch64-tdep.c: Use C++ exception handling.
1520
1521 2019-04-08  Tom Tromey  <tom@tromey.com>
1522
1523         * xml-support.c (gdb_xml_parser::parse): Update.
1524         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1525         * value.c (show_convenience): Update.
1526         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1527         (test_parse_flags_qcs): Update.
1528         * thread.c (thr_try_catch_cmd): Update.
1529         * target.c (target_translate_tls_address): Update.
1530         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1531         (info_frame_command_core, frame_apply_command_count): Update.
1532         * rust-exp.y (rust_lex_exception_test): Update.
1533         * riscv-tdep.c (riscv_print_one_register_info): Update.
1534         * remote.c (remote_target::enable_btrace): Update.
1535         * record-btrace.c (record_btrace_enable_warn): Update.
1536         * python/py-utils.c (gdbpy_convert_exception): Update.
1537         * printcmd.c (do_one_display, print_variable_and_value): Update.
1538         * mi/mi-main.c (mi_print_exception): Update.
1539         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1540         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1541         * linux-nat.c (linux_nat_target::attach): Update.
1542         * linux-fork.c (class scoped_switch_fork_info): Update.
1543         * infrun.c (displaced_step_prepare): Update.
1544         * infcall.c (call_function_by_hand_dummy): Update.
1545         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1546         * gnu-v3-abi.c (print_one_vtable): Update.
1547         * frame.c (get_prev_frame_always): Update.
1548         * f-valprint.c (info_common_command_for_block): Update.
1549         * exec.c (try_open_exec_file): Update.
1550         * exceptions.c (print_exception, exception_print)
1551         (exception_fprintf, exception_print_same): Update.
1552         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1553         * dwarf-index-cache.c (index_cache::store)
1554         (index_cache::lookup_gdb_index): Update.
1555         * darwin-nat.c (maybe_cache_shell): Update.
1556         * cp-valprint.c (cp_print_value_fields): Update.
1557         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1558         (gcc_cplus_symbol_address): Update.
1559         * compile/compile-c-symbols.c (gcc_convert_symbol)
1560         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1561         * common/selftest.c: Update.
1562         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1563         a std::string.
1564         (exception_try_scope_entry, exception_try_scope_exit): Don't
1565         declare.
1566         (struct exception_try_scope): Remove.
1567         (TRY): Don't use exception_try_scope.
1568         (struct gdb_exception): Add constructor, operator=.
1569         <what>: New method.
1570         (struct gdb_exception_RETURN_MASK_ALL)
1571         (struct gdb_exception_RETURN_MASK_ERROR)
1572         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1573         (struct gdb_quit_bad_alloc): Update.
1574         * common/common-exceptions.c (exception_none): Change
1575         initializer.
1576         (struct catcher) <state, exception>: Initialize inline.
1577         <prev>: Remove member.
1578         (current_catcher): Remove.
1579         (catchers): New global.
1580         (exceptions_state_mc_init): Simplify.
1581         (catcher_pop): Remove.
1582         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1583         (try_scope_depth, exception_try_scope_entry)
1584         (exception_try_scope_exit): Remove.
1585         (throw_exception_sjlj): Update.
1586         (exception_messages, exception_messages_size): Remove.
1587         (throw_it): Simplify.
1588         (gdb_exception_sliced_copy): Remove.
1589         (throw_exception_cxx): Update.
1590         * cli/cli-script.c (script_from_file): Update.
1591         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1592         Update.
1593         * ada-valprint.c (ada_val_print): Update.
1594         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1595         (create_excep_cond_exprs): Update.
1596
1597 2019-04-08  Tom Tromey  <tom@tromey.com>
1598
1599         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1600         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1601         (TRY, CATCH, END_CATCH): Remove some definitions.
1602         * common/common-exceptions.c: Don't use GDB_XCPT.
1603         (catcher_list_size): Remove.
1604         (throw_exception, throw_it): Simplify.
1605
1606 2019-04-05  Tom Tromey  <tom@tromey.com>
1607
1608         Revert the header-sorting patch.
1609         * ft32-tdep.c: Revert.
1610         * frv-tdep.c: Revert.
1611         * frv-linux-tdep.c: Revert.
1612         * frame.c: Revert.
1613         * frame-unwind.c: Revert.
1614         * frame-base.c: Revert.
1615         * fork-child.c: Revert.
1616         * findvar.c: Revert.
1617         * findcmd.c: Revert.
1618         * filesystem.c: Revert.
1619         * filename-seen-cache.h: Revert.
1620         * filename-seen-cache.c: Revert.
1621         * fbsd-tdep.c: Revert.
1622         * fbsd-nat.h: Revert.
1623         * fbsd-nat.c: Revert.
1624         * f-valprint.c: Revert.
1625         * f-typeprint.c: Revert.
1626         * f-lang.c: Revert.
1627         * extension.h: Revert.
1628         * extension.c: Revert.
1629         * extension-priv.h: Revert.
1630         * expprint.c: Revert.
1631         * exec.h: Revert.
1632         * exec.c: Revert.
1633         * exceptions.c: Revert.
1634         * event-top.c: Revert.
1635         * event-loop.c: Revert.
1636         * eval.c: Revert.
1637         * elfread.c: Revert.
1638         * dwarf2read.h: Revert.
1639         * dwarf2read.c: Revert.
1640         * dwarf2loc.c: Revert.
1641         * dwarf2expr.h: Revert.
1642         * dwarf2expr.c: Revert.
1643         * dwarf2-frame.c: Revert.
1644         * dwarf2-frame-tailcall.c: Revert.
1645         * dwarf-index-write.h: Revert.
1646         * dwarf-index-write.c: Revert.
1647         * dwarf-index-common.c: Revert.
1648         * dwarf-index-cache.h: Revert.
1649         * dwarf-index-cache.c: Revert.
1650         * dummy-frame.c: Revert.
1651         * dtrace-probe.c: Revert.
1652         * disasm.h: Revert.
1653         * disasm.c: Revert.
1654         * disasm-selftests.c: Revert.
1655         * dictionary.c: Revert.
1656         * dicos-tdep.c: Revert.
1657         * demangle.c: Revert.
1658         * dcache.h: Revert.
1659         * dcache.c: Revert.
1660         * darwin-nat.h: Revert.
1661         * darwin-nat.c: Revert.
1662         * darwin-nat-info.c: Revert.
1663         * d-valprint.c: Revert.
1664         * d-namespace.c: Revert.
1665         * d-lang.c: Revert.
1666         * ctf.c: Revert.
1667         * csky-tdep.c: Revert.
1668         * csky-linux-tdep.c: Revert.
1669         * cris-tdep.c: Revert.
1670         * cris-linux-tdep.c: Revert.
1671         * cp-valprint.c: Revert.
1672         * cp-support.c: Revert.
1673         * cp-namespace.c: Revert.
1674         * cp-abi.c: Revert.
1675         * corelow.c: Revert.
1676         * corefile.c: Revert.
1677         * continuations.c: Revert.
1678         * completer.h: Revert.
1679         * completer.c: Revert.
1680         * complaints.c: Revert.
1681         * coffread.c: Revert.
1682         * coff-pe-read.c: Revert.
1683         * cli-out.h: Revert.
1684         * cli-out.c: Revert.
1685         * charset.c: Revert.
1686         * c-varobj.c: Revert.
1687         * c-valprint.c: Revert.
1688         * c-typeprint.c: Revert.
1689         * c-lang.c: Revert.
1690         * buildsym.c: Revert.
1691         * buildsym-legacy.c: Revert.
1692         * build-id.h: Revert.
1693         * build-id.c: Revert.
1694         * btrace.c: Revert.
1695         * bsd-uthread.c: Revert.
1696         * breakpoint.h: Revert.
1697         * breakpoint.c: Revert.
1698         * break-catch-throw.c: Revert.
1699         * break-catch-syscall.c: Revert.
1700         * break-catch-sig.c: Revert.
1701         * blockframe.c: Revert.
1702         * block.c: Revert.
1703         * bfin-tdep.c: Revert.
1704         * bfin-linux-tdep.c: Revert.
1705         * bfd-target.c: Revert.
1706         * bcache.c: Revert.
1707         * ax-general.c: Revert.
1708         * ax-gdb.h: Revert.
1709         * ax-gdb.c: Revert.
1710         * avr-tdep.c: Revert.
1711         * auxv.c: Revert.
1712         * auto-load.c: Revert.
1713         * arm-wince-tdep.c: Revert.
1714         * arm-tdep.c: Revert.
1715         * arm-symbian-tdep.c: Revert.
1716         * arm-pikeos-tdep.c: Revert.
1717         * arm-obsd-tdep.c: Revert.
1718         * arm-nbsd-tdep.c: Revert.
1719         * arm-nbsd-nat.c: Revert.
1720         * arm-linux-tdep.c: Revert.
1721         * arm-linux-nat.c: Revert.
1722         * arm-fbsd-tdep.c: Revert.
1723         * arm-fbsd-nat.c: Revert.
1724         * arm-bsd-tdep.c: Revert.
1725         * arch-utils.c: Revert.
1726         * arc-tdep.c: Revert.
1727         * arc-newlib-tdep.c: Revert.
1728         * annotate.h: Revert.
1729         * annotate.c: Revert.
1730         * amd64-windows-tdep.c: Revert.
1731         * amd64-windows-nat.c: Revert.
1732         * amd64-tdep.c: Revert.
1733         * amd64-sol2-tdep.c: Revert.
1734         * amd64-obsd-tdep.c: Revert.
1735         * amd64-obsd-nat.c: Revert.
1736         * amd64-nbsd-tdep.c: Revert.
1737         * amd64-nbsd-nat.c: Revert.
1738         * amd64-nat.c: Revert.
1739         * amd64-linux-tdep.c: Revert.
1740         * amd64-linux-nat.c: Revert.
1741         * amd64-fbsd-tdep.c: Revert.
1742         * amd64-fbsd-nat.c: Revert.
1743         * amd64-dicos-tdep.c: Revert.
1744         * amd64-darwin-tdep.c: Revert.
1745         * amd64-bsd-nat.c: Revert.
1746         * alpha-tdep.c: Revert.
1747         * alpha-obsd-tdep.c: Revert.
1748         * alpha-nbsd-tdep.c: Revert.
1749         * alpha-mdebug-tdep.c: Revert.
1750         * alpha-linux-tdep.c: Revert.
1751         * alpha-linux-nat.c: Revert.
1752         * alpha-bsd-tdep.c: Revert.
1753         * alpha-bsd-nat.c: Revert.
1754         * aix-thread.c: Revert.
1755         * agent.c: Revert.
1756         * addrmap.c: Revert.
1757         * ada-varobj.c: Revert.
1758         * ada-valprint.c: Revert.
1759         * ada-typeprint.c: Revert.
1760         * ada-tasks.c: Revert.
1761         * ada-lang.c: Revert.
1762         * aarch64-tdep.c: Revert.
1763         * aarch64-ravenscar-thread.c: Revert.
1764         * aarch64-newlib-tdep.c: Revert.
1765         * aarch64-linux-tdep.c: Revert.
1766         * aarch64-linux-nat.c: Revert.
1767         * aarch64-fbsd-tdep.c: Revert.
1768         * aarch64-fbsd-nat.c: Revert.
1769         * aarch32-linux-nat.c: Revert.
1770
1771 2019-04-05  Tom Tromey  <tom@tromey.com>
1772
1773         * ft32-tdep.c: Sort headers.
1774         * frv-tdep.c: Sort headers.
1775         * frv-linux-tdep.c: Sort headers.
1776         * frame.c: Sort headers.
1777         * frame-unwind.c: Sort headers.
1778         * frame-base.c: Sort headers.
1779         * fork-child.c: Sort headers.
1780         * findvar.c: Sort headers.
1781         * findcmd.c: Sort headers.
1782         * filesystem.c: Sort headers.
1783         * filename-seen-cache.h: Sort headers.
1784         * filename-seen-cache.c: Sort headers.
1785         * fbsd-tdep.c: Sort headers.
1786         * fbsd-nat.h: Sort headers.
1787         * fbsd-nat.c: Sort headers.
1788         * f-valprint.c: Sort headers.
1789         * f-typeprint.c: Sort headers.
1790         * f-lang.c: Sort headers.
1791         * extension.h: Sort headers.
1792         * extension.c: Sort headers.
1793         * extension-priv.h: Sort headers.
1794         * expprint.c: Sort headers.
1795         * exec.h: Sort headers.
1796         * exec.c: Sort headers.
1797         * exceptions.c: Sort headers.
1798         * event-top.c: Sort headers.
1799         * event-loop.c: Sort headers.
1800         * eval.c: Sort headers.
1801         * elfread.c: Sort headers.
1802         * dwarf2read.h: Sort headers.
1803         * dwarf2read.c: Sort headers.
1804         * dwarf2loc.c: Sort headers.
1805         * dwarf2expr.h: Sort headers.
1806         * dwarf2expr.c: Sort headers.
1807         * dwarf2-frame.c: Sort headers.
1808         * dwarf2-frame-tailcall.c: Sort headers.
1809         * dwarf-index-write.h: Sort headers.
1810         * dwarf-index-write.c: Sort headers.
1811         * dwarf-index-common.c: Sort headers.
1812         * dwarf-index-cache.h: Sort headers.
1813         * dwarf-index-cache.c: Sort headers.
1814         * dummy-frame.c: Sort headers.
1815         * dtrace-probe.c: Sort headers.
1816         * disasm.h: Sort headers.
1817         * disasm.c: Sort headers.
1818         * disasm-selftests.c: Sort headers.
1819         * dictionary.c: Sort headers.
1820         * dicos-tdep.c: Sort headers.
1821         * demangle.c: Sort headers.
1822         * dcache.h: Sort headers.
1823         * dcache.c: Sort headers.
1824         * darwin-nat.h: Sort headers.
1825         * darwin-nat.c: Sort headers.
1826         * darwin-nat-info.c: Sort headers.
1827         * d-valprint.c: Sort headers.
1828         * d-namespace.c: Sort headers.
1829         * d-lang.c: Sort headers.
1830         * ctf.c: Sort headers.
1831         * csky-tdep.c: Sort headers.
1832         * csky-linux-tdep.c: Sort headers.
1833         * cris-tdep.c: Sort headers.
1834         * cris-linux-tdep.c: Sort headers.
1835         * cp-valprint.c: Sort headers.
1836         * cp-support.c: Sort headers.
1837         * cp-namespace.c: Sort headers.
1838         * cp-abi.c: Sort headers.
1839         * corelow.c: Sort headers.
1840         * corefile.c: Sort headers.
1841         * continuations.c: Sort headers.
1842         * completer.h: Sort headers.
1843         * completer.c: Sort headers.
1844         * complaints.c: Sort headers.
1845         * coffread.c: Sort headers.
1846         * coff-pe-read.c: Sort headers.
1847         * cli-out.h: Sort headers.
1848         * cli-out.c: Sort headers.
1849         * charset.c: Sort headers.
1850         * c-varobj.c: Sort headers.
1851         * c-valprint.c: Sort headers.
1852         * c-typeprint.c: Sort headers.
1853         * c-lang.c: Sort headers.
1854         * buildsym.c: Sort headers.
1855         * buildsym-legacy.c: Sort headers.
1856         * build-id.h: Sort headers.
1857         * build-id.c: Sort headers.
1858         * btrace.c: Sort headers.
1859         * bsd-uthread.c: Sort headers.
1860         * breakpoint.h: Sort headers.
1861         * breakpoint.c: Sort headers.
1862         * break-catch-throw.c: Sort headers.
1863         * break-catch-syscall.c: Sort headers.
1864         * break-catch-sig.c: Sort headers.
1865         * blockframe.c: Sort headers.
1866         * block.c: Sort headers.
1867         * bfin-tdep.c: Sort headers.
1868         * bfin-linux-tdep.c: Sort headers.
1869         * bfd-target.c: Sort headers.
1870         * bcache.c: Sort headers.
1871         * ax-general.c: Sort headers.
1872         * ax-gdb.h: Sort headers.
1873         * ax-gdb.c: Sort headers.
1874         * avr-tdep.c: Sort headers.
1875         * auxv.c: Sort headers.
1876         * auto-load.c: Sort headers.
1877         * arm-wince-tdep.c: Sort headers.
1878         * arm-tdep.c: Sort headers.
1879         * arm-symbian-tdep.c: Sort headers.
1880         * arm-pikeos-tdep.c: Sort headers.
1881         * arm-obsd-tdep.c: Sort headers.
1882         * arm-nbsd-tdep.c: Sort headers.
1883         * arm-nbsd-nat.c: Sort headers.
1884         * arm-linux-tdep.c: Sort headers.
1885         * arm-linux-nat.c: Sort headers.
1886         * arm-fbsd-tdep.c: Sort headers.
1887         * arm-fbsd-nat.c: Sort headers.
1888         * arm-bsd-tdep.c: Sort headers.
1889         * arch-utils.c: Sort headers.
1890         * arc-tdep.c: Sort headers.
1891         * arc-newlib-tdep.c: Sort headers.
1892         * annotate.h: Sort headers.
1893         * annotate.c: Sort headers.
1894         * amd64-windows-tdep.c: Sort headers.
1895         * amd64-windows-nat.c: Sort headers.
1896         * amd64-tdep.c: Sort headers.
1897         * amd64-sol2-tdep.c: Sort headers.
1898         * amd64-obsd-tdep.c: Sort headers.
1899         * amd64-obsd-nat.c: Sort headers.
1900         * amd64-nbsd-tdep.c: Sort headers.
1901         * amd64-nbsd-nat.c: Sort headers.
1902         * amd64-nat.c: Sort headers.
1903         * amd64-linux-tdep.c: Sort headers.
1904         * amd64-linux-nat.c: Sort headers.
1905         * amd64-fbsd-tdep.c: Sort headers.
1906         * amd64-fbsd-nat.c: Sort headers.
1907         * amd64-dicos-tdep.c: Sort headers.
1908         * amd64-darwin-tdep.c: Sort headers.
1909         * amd64-bsd-nat.c: Sort headers.
1910         * alpha-tdep.c: Sort headers.
1911         * alpha-obsd-tdep.c: Sort headers.
1912         * alpha-nbsd-tdep.c: Sort headers.
1913         * alpha-mdebug-tdep.c: Sort headers.
1914         * alpha-linux-tdep.c: Sort headers.
1915         * alpha-linux-nat.c: Sort headers.
1916         * alpha-bsd-tdep.c: Sort headers.
1917         * alpha-bsd-nat.c: Sort headers.
1918         * aix-thread.c: Sort headers.
1919         * agent.c: Sort headers.
1920         * addrmap.c: Sort headers.
1921         * ada-varobj.c: Sort headers.
1922         * ada-valprint.c: Sort headers.
1923         * ada-typeprint.c: Sort headers.
1924         * ada-tasks.c: Sort headers.
1925         * ada-lang.c: Sort headers.
1926         * aarch64-tdep.c: Sort headers.
1927         * aarch64-ravenscar-thread.c: Sort headers.
1928         * aarch64-newlib-tdep.c: Sort headers.
1929         * aarch64-linux-tdep.c: Sort headers.
1930         * aarch64-linux-nat.c: Sort headers.
1931         * aarch64-fbsd-tdep.c: Sort headers.
1932         * aarch64-fbsd-nat.c: Sort headers.
1933         * aarch32-linux-nat.c: Sort headers.
1934
1935 2019-04-04  Tom Tromey  <tom@tromey.com>
1936
1937         * varobj.c (varobj_create): Update.
1938         * rust-exp.y (struct rust_parser) <update_innermost_block,
1939         lookup_symbol>: New methods.
1940         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1941         Rename.
1942         (rust_parser::rust_lookup_type)
1943         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1944         * printcmd.c (display_command, do_one_display): Update.
1945         * parser-defs.h (struct parser_state) <parser_state>: Add
1946         "tracker" parameter.
1947         (block_tracker): New member.
1948         (class innermost_block_tracker) <innermost_block_tracker>: Add
1949         "types" parameter.
1950         <reset>: Remove method.
1951         (innermost_block): Don't declare.
1952         (null_post_parser): Update.
1953         * parse.c (innermost_block): Remove global.
1954         (write_dollar_variable): Update.
1955         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1956         Remove "tracker_types" parameter.
1957         (parse_expression): Add "tracker" parameter.
1958         (parse_expression_for_completion): Update.
1959         (null_post_parser): Add "tracker" parameter.
1960         * p-exp.y: Update rules.
1961         * m2-exp.y: Update rules.
1962         * language.h (struct language_defn) <la_post_parser>: Add
1963         "tracker" parameter.
1964         * go-exp.y: Update rules.
1965         * f-exp.y: Update rules.
1966         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1967         parameter.
1968         * d-exp.y: Update rules.
1969         * c-exp.y: Update rules.
1970         * breakpoint.c (set_breakpoint_condition): Create an
1971         innermost_block_tracker.
1972         (watch_command_1): Likewise.
1973         * ada-lang.c (resolve): Add "tracker" parameter.
1974         (resolve_subexp): Likewise.
1975         * ada-exp.y (write_var_from_sym): Update.
1976
1977 2019-04-04  Tom Tromey  <tom@tromey.com>
1978
1979         * type-stack.h: New file.
1980         * type-stack.c: New file.
1981         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1982         type-stack.h.
1983         (insert_into_type_stack, insert_type, push_type, push_type_int)
1984         (insert_type_address_space, pop_type, pop_type_int)
1985         (pop_typelist, pop_type_stack, append_type_stack)
1986         (push_type_stack, get_type_stack, push_typelist)
1987         (follow_type_instance_flags, follow_types): Don't declare.
1988         * parse.c (type_stack): Remove global.
1989         (parse_exp_in_context): Update.
1990         (insert_into_type_stack, insert_type, push_type, push_type_int)
1991         (insert_type_address_space, pop_type, pop_type_int)
1992         (pop_typelist, pop_type_stack, append_type_stack)
1993         (push_type_stack, get_type_stack, push_typelist)
1994         (follow_type_instance_flags, follow_types): Remove (moved to
1995         type-stack.c).
1996         * f-exp.y (type_stack): New global.
1997         Update rules.
1998         (push_kind_type, f_parse): Update.
1999         * d-exp.y (type_stack): New global.
2000         Update rules.
2001         (d_parse): Update.
2002         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2003         Update rules.
2004         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2005         (HFILES_NO_SRCDIR): Add type-stack.h.
2006
2007 2019-04-04  Tom Tromey  <tom@tromey.com>
2008
2009         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2010         (rust_parser::convert_ast_to_expression, rust_parse)
2011         (rust_lex_test_completion, rust_lex_tests): Update.
2012         * parser-defs.h (struct expr_completion_state): New.
2013         (struct parser_state) <parser_state>: Add completion parameter.
2014         <mark_struct_expression, mark_completion_tag>: New methods.
2015         <parse_completion, m_completion_state>: New members.
2016         (prefixify_expression, null_post_parser): Update.
2017         (mark_struct_expression, mark_completion_tag): Don't declare.
2018         * parse.c (parse_completion, expout_last_struct)
2019         (expout_tag_completion_type, expout_completion_name): Remove
2020         globals.
2021         (parser_state::mark_struct_expression)
2022         (parser_state::mark_completion_tag): Now methods.
2023         (prefixify_expression): Add last_struct parameter.
2024         (prefixify_subexp): Likewise.
2025         (parse_exp_1): Update.
2026         (parse_exp_in_context): Add cstate parameter.  Update.
2027         (parse_expression_for_completion): Create an
2028         expr_completion_state.
2029         (null_post_parser): Add "completion" parameter.
2030         * p-exp.y: Update rules.
2031         (yylex): Update.
2032         * language.h (struct language_defn) <la_post_parser>: Add
2033         "completing" parameter.
2034         * go-exp.y: Update rules.
2035         (lex_one_token): Update.
2036         * expression.h (parse_completion): Don't declare.
2037         * d-exp.y: Update rules.
2038         (lex_one_token): Update rules.
2039         * c-exp.y: Update rules.
2040         (lex_one_token): Update.
2041         * ada-lang.c (resolve): Add "parse_completion" parameter.
2042         (resolve_subexp): Likewise.
2043         (ada_resolve_function): Likewise.
2044
2045 2019-04-04  Tom Tromey  <tom@tromey.com>
2046
2047         * parser-defs.h (struct parser_state) <start_arglist,
2048         end_arglist>: New methods.
2049         <arglist_len, m_funcall_chain>: New members.
2050         (arglist_len, start_arglist, end_arglist): Don't declare.
2051         * parse.c (arglist_len, funcall_chain): Remove global.
2052         (start_arglist, end_arglist): Remove functions.
2053         (parse_exp_in_context): Update.
2054         * p-exp.y: Update rules.
2055         * m2-exp.y: Update rules.
2056         * go-exp.y: Update rules.
2057         * f-exp.y: Update rules.
2058         * d-exp.y: Update rules.
2059         * c-exp.y: Update rules.
2060
2061 2019-04-04  Tom Tromey  <tom@tromey.com>
2062
2063         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2064         lex_operator, push_back>: New methods.
2065         Update all rules.
2066         (rust_parser::lex_hex, lex_escape): Rename and update.
2067         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2068         (rust_parser::lex_operator): Rename and update.
2069         (rust_parser::lex_number, rustyylex, rustyyerror)
2070         (rust_lex_test_init, rust_lex_test_sequence)
2071         (rust_lex_test_push_back, rust_lex_tests): Update.
2072         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2073         parameter.
2074         <lexptr, prev_lexptr>: New members.
2075         (lexptr, prev_lexptr): Don't declare.
2076         * parse.c (lexptr, prev_lexptr): Remove globals.
2077         (parse_exp_in_context): Update.
2078         * p-exp.y (yylex, yyerror): Update.
2079         * m2-exp.y (parse_number, yylex, yyerror): Update.
2080         * go-exp.y (lex_one_token, yyerror): Update.
2081         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2082         * d-exp.y (lex_one_token, yyerror): Update.
2083         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2084         (lex_one_token, yyerror): Update.
2085         * ada-lex.l (YY_INPUT): Update.
2086         (rewind_to_char): Update.
2087         * ada-exp.y (yyerror): Update.
2088
2089 2019-04-04  Tom Tromey  <tom@tromey.com>
2090
2091         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2092         * parser-defs.h (struct parser_state) <parser_state>: Add new
2093         parameter.
2094         <comma_terminates>: New member.
2095         (comma_terminates): Don't declare global.
2096         * parse.c (comma_terminates): Remove global.
2097         (parse_exp_in_context): Update.
2098         * p-exp.y (yylex): Update.
2099         * m2-exp.y (yylex): Update.
2100         * go-exp.y (lex_one_token): Update.
2101         * f-exp.y (yylex): Update.
2102         * d-exp.y (lex_one_token): Update.
2103         * c-exp.y (lex_one_token): Update.
2104         * ada-lex.l: Update.
2105
2106 2019-04-04  Tom Tromey  <tom@tromey.com>
2107
2108         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2109         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2110         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2111         * parser-defs.h (paren_depth): Don't declare.
2112         * parse.c (paren_depth): Remove global.
2113         (parse_exp_in_context): Update.
2114         * p-exp.y (paren_depth): New global.
2115         (pascal_parse): Initialize it.
2116         * m2-exp.y (paren_depth): New global.
2117         (m2_parse): Initialize it.
2118         * go-exp.y (paren_depth): New global.
2119         (go_parse): Initialize it.
2120         * f-exp.y (paren_depth): New global.
2121         (f_parse): Initialize it.
2122         * d-exp.y (paren_depth): New global.
2123         (d_parse): Initialize it.
2124         * c-exp.y (paren_depth): New global.
2125         (c_parse): Initialize it.
2126         * ada-lex.l (paren_depth): New global.
2127         (lexer_init): Initialize it.
2128
2129 2019-04-04  Tom Tromey  <tom@tromey.com>
2130
2131         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2132         (rust_parser::convert_ast_to_type)
2133         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2134         * parser-defs.h (struct parser_state) <parser_state>: Add
2135         parameters.  Initialize new members.
2136         <expression_context_block, expression_context_pc>: New members.
2137         * parse.c (expression_context_block, expression_context_pc):
2138         Remove globals.
2139         (parse_exp_in_context): Update.
2140         * p-exp.y: Update all rules.
2141         (yylex): Update.
2142         * m2-exp.y: Update all rules.
2143         (yylex): Update.
2144         * go-exp.y (yylex): Update.
2145         * f-exp.y (yylex): Update.
2146         * d-exp.y: Update all rules.
2147         (yylex): Update.
2148         * c-exp.y: Update all rules.
2149         (lex_one_token, classify_name, yylex, c_parse): Update.
2150         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2151
2152 2019-04-04  Tom Tromey  <tom@tromey.com>
2153
2154         * gdbarch.h, gdbarch.c: Rebuild.
2155         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2156         * stap-probe.h:
2157         (struct stap_parse_info): Replace "parser_state" with
2158         "expr_builder".
2159         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2160         (parser_state): New class.
2161         * parse.c (expr_builder): Rename.
2162         (expr_builder::release): Rename.
2163         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2164         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2165         (write_exp_elt_longcst, write_exp_elt_floatcst)
2166         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2167         (write_exp_string_vector, write_exp_bitstring)
2168         (write_exp_msymbol, mark_struct_expression)
2169         (write_dollar_variable)
2170         (insert_type_address_space, increase_expout_size): Replace
2171         "parser_state" with "expr_builder".
2172         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2173         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2174         "parser_state" with "expr_builder".
2175
2176 2019-04-04  Tom Tromey  <tom@tromey.com>
2177
2178         * rust-exp.y: Replace "parse_language" with method call.
2179         * p-exp.y:
2180         (yylex): Replace "parse_language" with method call.
2181         * m2-exp.y:
2182         (yylex): Replace "parse_language" with method call.
2183         * go-exp.y (classify_name): Replace "parse_language" with method
2184         call.
2185         * f-exp.y (yylex): Replace "parse_language" with method call.
2186         * d-exp.y (lex_one_token): Replace "parse_language" with method
2187         call.
2188         * c-exp.y:
2189         (lex_one_token, classify_name, yylex): Replace "parse_language"
2190         with method call.
2191         * ada-exp.y (find_primitive_type, type_char)
2192         (type_system_address): Replace "parse_language" with method call.
2193
2194 2019-04-04  Tom Tromey  <tom@tromey.com>
2195
2196         * rust-exp.y: Replace "parse_gdbarch" with method call.
2197         * parse.c (write_dollar_variable, insert_type_address_space):
2198         Replace "parse_gdbarch" with method call.
2199         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2200         call.
2201         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2202         call.
2203         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2204         "parse_gdbarch" with method call.
2205         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2206         with method call.
2207         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2208         "parse_gdbarch" with method call.
2209         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2210         "parse_gdbarch" with method call.
2211         * c-exp.y (parse_type, parse_number, classify_name): Replace
2212         "parse_gdbarch" with method call.
2213         * ada-lex.l: Replace "parse_gdbarch" with method call.
2214         * ada-exp.y (parse_type, find_primitive_type, type_char)
2215         (type_system_address): Replace "parse_gdbarch" with method call.
2216
2217 2019-04-04  Tom Tromey  <tom@tromey.com>
2218
2219         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2220         * stap-probe.c (stap_parse_argument): Update.
2221         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2222         initial_size parameter.
2223         * rust-exp.y (rust_lex_tests): Update.
2224         * parse.c (parser_state): Update.
2225         (parse_exp_in_context): Update.
2226         * parser-defs.h (struct parser_state) <parser_state>: Remove
2227         "initial_size" parameter.
2228
2229 2019-04-04  Tom Tromey  <tom@tromey.com>
2230
2231         * parser-defs.h (increase_expout_size): Don't declare.
2232         * parse.c (increase_expout_size): Now static.
2233
2234 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2235
2236         * gnu-nat.c (gnu_nat_target::wait): Fix
2237         target_waitstatus_to_string call.
2238
2239 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2240
2241         * eval.c (evaluate_subexp_standard): Handle internal functions
2242         during Fortran function call handling.
2243
2244 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2245
2246         * NEWS: Mention new internal functions.
2247         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2248         (read_base_type): Use dwarf2_init_complex_target_type.
2249         * value.c (creal_internal_fn): New function.
2250         (cimag_internal_fn): New function.
2251         (_initialize_values): Register new internal functions.
2252
2253 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2254
2255         * infrun.c (stop_all_threads): If debug_infrun, always
2256         trace the wait status after wait_one, using
2257         target_waitstatus_to_string and target_pid_to_str.
2258         (handle_inferior_event): Replace various trace of
2259         wait status kind by a single trace.
2260         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2261         wait status kind image by target_waitstatus_to_string.
2262         * target/waitstatus.c (target_waitstatus_to_string): Fix
2263         obsolete comment.
2264
2265 2019-04-01  Tom Tromey  <tromey@adacore.com>
2266
2267         PR symtab/23331:
2268         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2269
2270 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2271             Pedro Alves  <palves@redhat.com>
2272
2273         * top.c (quit_force): Call 'finalize_values'.
2274         * value.c (finalize_values): New function.
2275         * value.h (finalize_values): Declare.
2276
2277 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2278
2279         * NEWS: Announce $_gdb_major and $_gdb_minor.
2280
2281         * top.c (init_gdb_version_vars): New function.
2282         (gdb_init): Call init_gdb_version_vars.
2283
2284 2019-03-29  Tom Tromey  <tromey@adacore.com>
2285
2286         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2287         help text.  Remove dead code.
2288
2289 2019-03-29  Keith Seitz  <keiths@redhat.com>
2290
2291         From Siddhesh Poyarekar:
2292         * f-lang.h (f77_get_upperbound): Return LONGEST.
2293         (f77_get_lowerbound): Likewise.
2294         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2295         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2296         print them.
2297         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2298         plongest to format print it.
2299         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2300         (f77_get_upperbound): Likewise.
2301         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2302         LOWER_BOUND to LONGEST.
2303         (f77_create_arrayprint_offset_tbl): Likewise.
2304
2305 2019-03-29  Keith Seitz  <keiths@redhat.com>
2306
2307         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2308         %s/pulongest for TYPE_LENGTH instead of %d in format
2309         strings.
2310         * ada-typerint.c (ada_print_type): Likewise.
2311         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2312         * compile/compile-c-support.c (generate_register_struct): Likewise.
2313         * gdbtypes.c (recursive_dump_type): Likewise.
2314         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2315         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2316         instead of %d in format strings.
2317         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2318         to std::min to ULONGEST.
2319         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2320         instead of %d in format strings.
2321         * tracepoint.c (info_scope_command): Likewise.
2322         * typeprint.c (print_offset_data::update)
2323         (print_offset_data::finish): Likewise.
2324         * xtensa-tdep.c (xtensa_store_return_value)
2325         (xtensa_push_dummy_call): Likewise.
2326
2327 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2328
2329         * windows-nat.c (display_selector): Fixed format specifications
2330         for 64-bit Cygwin.
2331
2332 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2333
2334         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2335
2336 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2337
2338         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2339         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2340         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2341         (nios2_linux_init_abi): Install it.
2342
2343 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2344
2345         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2346
2347 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2348
2349         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2350
2351 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2352             Tom Tromey  <tromey@adacore.com>
2353
2354         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2355
2356 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2357
2358         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2359         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2360         method to compute the bounds of range types. Also print "[evaluated]"
2361         if the bounds' values come from a dynamic evaluation.
2362
2363 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2364
2365         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2366         whitespace when pretty printing is on.
2367
2368 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2369
2370         * ppc-linux-nat.c: Add include.
2371
2372 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2373
2374         * NEWS: Mention AArch64 Pointer Authentication.
2375
2376 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2377
2378         * arm-linux-nat.c: Add include.
2379
2380 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2381
2382         * source-cache.c (source_cache::get_source_lines): Re-read
2383         fullname after calling open_source_file.
2384
2385 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2386
2387         * NEWS: Mention TLS support for FreeBSD.
2388
2389 2019-03-25  Tom Tromey  <tromey@adacore.com>
2390
2391         * minsyms.c (BUNCH_SIZE): Update comment.
2392         (~minimal_symbol_reader): Remove old comment.
2393         (compact_minimal_symbols): Update comment.
2394         (minimal_symbol_reader::install): Remove old comment.  Update
2395         other comments.
2396
2397 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2398
2399         * s390-linux-nat.c: Add include.
2400
2401 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2402
2403         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2404         Call linux_get_hwcap.
2405         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2406         Likewise.
2407         (aarch64_linux_get_hwcap): Remove function.
2408         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2409         declaration.
2410         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2411         linux_get_hwcap.
2412         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2413         * linux-tdep.c (linux_get_hwcap): Add function.
2414         (linux_get_hwcap2): Likewise.
2415         * linux-tdep.h (linux_get_hwcap): Add declaration.
2416         (linux_get_hwcap2): Likewise.
2417         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2418         (ppc_linux_get_hwcap2): Likewise.
2419         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2420         linux_get_hwcap.
2421         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2422         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2423         (ppc_linux_nat_target::read_description): Likewise.
2424         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2425         * s390-linux-nat.c: Likewise.
2426         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2427
2428 2019-03-24  Tom Tromey  <tom@tromey.com>
2429
2430         * ada-lang.c (standard_lookup): Simplify initialization.
2431         (ada_lookup_symbol_nonlocal): Simplify return.
2432         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2433         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2434         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2435         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2436         initialization.
2437         * solib.c (solib_global_lookup): Simplify.
2438         * symtab.c (null_block_symbol): Remove.
2439         (symbol_cache_lookup): Simplify returns.
2440         (lookup_language_this): Simplify returns.
2441         (lookup_symbol_aux): Simplify return.
2442         (lookup_local_symbol): Simplify returns.
2443         (lookup_global_symbol_from_objfile): Simplify return.
2444         (lookup_symbol_in_objfile_symtabs)
2445         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2446         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2447         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2448         * cp-namespace.c (cp_lookup_bare_symbol)
2449         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2450         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2451         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2452         (cp_lookup_symbol_via_imports): Simplify initialization.
2453         (find_symbol_in_baseclass): Likewise.
2454         * symtab.h (null_block_symbol): Remove.
2455         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2456         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2457         (d_lookup_symbol_module): Likewise.
2458         (find_symbol_in_baseclass): Simplify initialization.
2459
2460 2019-03-24  Tom Tromey  <tom@tromey.com>
2461
2462         * expression.h: Don't include symtab.h.
2463         (struct block): Forward declare.
2464
2465 2019-03-24  Tom Tromey  <tom@tromey.com>
2466
2467         * c-exp.y (typebase): Remove casts.
2468         * gdbtypes.c (lookup_unsigned_typename, )
2469         (lookup_signed_typename): Remove cast.
2470         * eval.c (parse_to_comma_and_eval): Remove cast.
2471         * parse.c (write_dollar_variable): Remove cast.
2472         * block.h (struct block) <superblock>: Now const.
2473         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2474         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2475         (map_block): Make "block" const.
2476         * symfile.h (struct quick_symbol_functions)
2477         <map_matching_symbols>: Constify block argument to "callback".
2478         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2479         const.
2480         (find_pc_sect_compunit_symtab): Make "b" const.
2481         (find_symbol_at_address): Likewise.
2482         (search_symbols): Likewise.
2483         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2484         (dw2_debug_names_lookup_symbol): Likewise.
2485         (dw2_map_matching_symbols): Update.
2486         * p-valprint.c (pascal_val_print): Remove "block".
2487         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2488         (aux_add_nonlocal_symbols): Make "block" const.
2489         (resolve_subexp): Remove cast.
2490         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2491         const.
2492         (iterate_over_file_blocks): Likewise.
2493         * f-exp.y (%union) <bval>: Remove.
2494         * coffread.c (patch_opaque_types): Make "b" const.
2495         * spu-tdep.c (spu_catch_start): Make "block" const.
2496         * c-valprint.c (print_unpacked_pointer): Remove "block".
2497         * symmisc.c (dump_symtab_1): Make "b" const.
2498         (block_depth): Make "block" const.
2499         * d-exp.y (%union) <bval>: Remove.
2500         * cp-support.h (cp_lookup_rtti_type): Update.
2501         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2502         * psymtab.c (psym_lookup_symbol): Make "block" const.
2503         (maintenance_check_psymtabs): Make "b" const.
2504         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2505         (enumerate_locals, enumerate_args): Update.
2506         * python/py-symtab.c (stpy_global_block): Make "block" const.
2507         (stpy_static_block): Likewise.
2508         * inline-frame.c (block_starting_point_at): Make "new_block"
2509         const.
2510         * block.c (find_block_in_blockvector): Make return type const.
2511         (blockvector_for_pc_sect): Make "b" const.
2512         (find_block_in_blockvector): Make "b" const.
2513
2514 2019-03-23  Tom Tromey  <tom@tromey.com>
2515
2516         * varobj.c (varobj_create): Update.
2517         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2518         * printcmd.c (display_command, do_one_display): Don't reset
2519         innermost_block.
2520         * parser-defs.h (enum innermost_block_tracker_type): Move to
2521         expression.h.
2522         (innermost_block): Update comment.
2523         * parse.c (parse_exp_1): Add tracker_types parameter.
2524         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2525         tracker_types parameter.  Reset innermost_block.
2526         (parse_exp_in_context): Remove.
2527         (parse_expression_for_completion): Update.
2528         * objfiles.c (~objfile): Don't reset expression_context_block or
2529         innermost_block.
2530         * expression.h (enum innermost_block_tracker_type): Move from
2531         parser-defs.h.
2532         (parse_exp_1): Add tracker_types parameter.
2533         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2534         reset innermost_block.
2535
2536 2019-03-23  Tom Tromey  <tom@tromey.com>
2537
2538         * objfiles.h: Include bcache.h.
2539
2540 2019-03-23  Tom Tromey  <tom@tromey.com>
2541
2542         * linespec.c (get_current_search_block): Use
2543         scoped_restore_current_language.
2544         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2545
2546 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2547             Jiong Wang  <jiong.wang@arm.com>
2548
2549         * aarch64-linux-tdep.c
2550         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2551         section.
2552         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2553
2554 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2555             Jiong Wang  <jiong.wang@arm.com>
2556
2557         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2558         instructions.
2559         (aarch64_analyze_prologue_test): Add PACIASP test.
2560         (aarch64_prologue_prev_register): Unmask PC value.
2561
2562 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2563             Jiong Wang  <jiong.wang@arm.com>
2564
2565         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2566         (aarch64_dwarf2_prev_register): Unmask PC value.
2567         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2568         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2569         DW_CFA_AARCH64_negate_ra_state.
2570         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2571
2572 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2573             Jiong Wang  <jiong.wang@arm.com>
2574
2575         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2576         registers.
2577         (aarch64_pseudo_register_name): Likewise.
2578         (aarch64_pseudo_register_type): Likewise.
2579         (aarch64_pseudo_register_reggroup_p): Likewise.
2580         (aarch64_gdbarch_init): Add pauth registers.
2581         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2582         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2583         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2584         (struct gdbarch_tdep): Add regnum for ra_state.
2585
2586 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2587             Jiong Wang  <jiong.wang@arm.com>
2588
2589         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2590
2591 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2592             Jiong Wang  <jiong.wang@arm.com>
2593
2594         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2595         function.
2596         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2597         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2598         (aarch64_gdbarch_init): Add puth registers.
2599         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2600         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2601         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2602
2603 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2604             Jiong Wang  <jiong.wang@arm.com>
2605
2606         * aarch64-linux-nat.c
2607         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2608         * aarch64-linux-tdep.c
2609         (aarch64_linux_core_read_description): Likewise.
2610         (aarch64_linux_get_hwcap): New function.
2611         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2612         (aarch64_linux_get_hwcap): New declaration.
2613
2614 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2615             Jiong Wang  <jiong.wang@arm.com>
2616
2617         * aarch64-linux-nat.c
2618         (aarch64_linux_nat_target::read_description): Add pauth param.
2619         * aarch64-linux-tdep.c
2620         (aarch64_linux_core_read_description): Likewise.
2621         * aarch64-tdep.c (struct target_desc): Add in pauth.
2622         (aarch64_read_description): Add pauth param.
2623         (aarch64_gdbarch_init): Likewise.
2624         * aarch64-tdep.h (aarch64_read_description): Likewise.
2625         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2626         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2627         * features/Makefile: Add new files.
2628         * features/aarch64-pauth.c: New file.
2629         * features/aarch64-pauth.xml: New file.
2630
2631 2019-03-20  Tom Tromey  <tromey@adacore.com>
2632
2633         * infrun.c (handle_inferior_event): Rename from
2634         handle_inferior_event_1.  Create a scoped_value_mark.
2635         (handle_inferior_event): Remove.
2636
2637 2019-03-19  Tom Tromey  <tromey@adacore.com>
2638
2639         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2640         * infrun.h (print_stop_event): Add "displays" parameter.
2641         * infrun.c (print_stop_event): Add "displays" parameter.
2642
2643 2019-03-19  Pedro Alves  <palves@redhat.com>
2644
2645         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2646         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2647         to -1.  Fix TABs vs spaces.
2648         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2649         * tui/tui-out.h (tui_ui_out) Add intro comments.
2650         <m_line, m_start_of_line>: In-class initialize, and add describing
2651         comment.
2652
2653 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2654
2655         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2656         variable names.
2657         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2658
2659 2019-03-18  Pedro Alves  <palves@redhat.com>
2660             Eli Zaretskii <eliz@gnu.org>
2661
2662         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2663         m_line and m_start_of_line.
2664
2665 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2666
2667         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2668         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2669         it returns a newline.  This fixes a regression in TU mode, whereby
2670         the next line is output on the same screen line as the user input.
2671
2672 2019-03-18  Tom Tromey  <tromey@adacore.com>
2673
2674         * minsyms.c (minimal_symbol_reader::install): Remove call to
2675         obstack_blank.
2676
2677 2019-03-18  Pedro Alves  <palves@redhat.com>
2678
2679         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2680         New globals.
2681         (apply_style): New, factored out from ...
2682         (apply_ansi_escape): ... this.  Handle reverse video mode.
2683         (tui_set_reverse_mode): New function.
2684         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2685         * tui/tui-winsource.c (tui_show_source_line): Use
2686         tui_set_reverse_mode instead of setting A_STANDOUT.
2687         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2688         New setter methods.
2689
2690 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2691
2692         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2693         Handle tabs.
2694
2695 2019-03-18  Tom Tromey  <tromey@adacore.com>
2696
2697         * ada-lang.c (empty_array): Add "high" parameter.
2698         (ada_evaluate_subexp): Update.
2699
2700 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2701
2702         * unittests/string_view-selftests.c: Define
2703         _initialize_string_view_selftests unconditionally.
2704
2705 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2706
2707         PR gdb/24350
2708         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2709
2710 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2711
2712         PR gdb/24351
2713         * windows-nat.c (display_selector): Fix format specifiers.
2714
2715 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2716
2717         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2718         tui_refill_source_window instead of tui_refresh_win, to update the
2719         current execution line.  This fixes redisplay of the current line
2720         when stepping through the code with "next" or "step".
2721
2722 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2723
2724         * source-cache.c (source_cache::get_source_lines): Call
2725         find_source_lines to initialize s->nlines.  This fixes vertical
2726         scrolling of TUI source window when the DOWN arrow is pressed.
2727
2728 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2729
2730         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2731         linux-thread-db.c (_initialize_thread_db): Likewise.
2732
2733 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2734
2735         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2736         wclrtoeol in tui_show_source_line".  This reverts changes made in
2737         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2738
2739 2019-03-15  Tom Tromey  <tom@tromey.com>
2740
2741         * symtab.h (struct minimal_symbol): Derive from
2742         general_symbol_info.
2743         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2744         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2745         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2746         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2747         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2748         (MSYMBOL_SEARCH_NAME): Update.
2749         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2750         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2751         * minsyms.c (minimal_symbol_reader::record_full): Update.
2752
2753 2019-03-15  Tom Tromey  <tom@tromey.com>
2754
2755         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2756
2757 2019-03-15  Tom Tromey  <tom@tromey.com>
2758
2759         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2760         unique_xmalloc_ptr.
2761         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2762         Update.
2763         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2764         (build_minimal_symbol_hash_tables)
2765         (minimal_symbol_reader::install): Update.
2766
2767 2019-03-15  Tom Tromey  <tom@tromey.com>
2768
2769         * symtab.c (create_demangled_names_hash): Update.
2770         (symbol_set_names): Update.
2771         * objfiles.h (struct objfile_per_bfd_storage)
2772         <demangled_names_hash>: Now an htab_up.
2773         * objfiles.c (objfile_per_bfd_storage): Simplify.
2774
2775 2019-03-15  Tom Tromey  <tom@tromey.com>
2776
2777         * objfiles.h (struct objfile_per_bfd_storage): Declare
2778         destructor.
2779         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2780         New.
2781         (get_objfile_bfd_data): Use new.  Don't initialize
2782         language_of_main.
2783         (free_objfile_per_bfd_storage): Remove.
2784         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2785
2786 2019-03-15  Tom Tromey  <tom@tromey.com>
2787
2788         * symfile.c (reread_symbols): Update.
2789         * objfiles.c (objfile::objfile): Update.
2790         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2791         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2792         comment.
2793         (minimal_symbol_reader::install): Update.
2794         (terminate_minimal_symbol_table): Remove.
2795         * jit.c (jit_object_close_impl): Update.
2796
2797 2019-03-15  Tom Tromey  <tom@tromey.com>
2798
2799         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2800         initializations.
2801
2802 2019-03-15  Tom Tromey  <tom@tromey.com>
2803
2804         * objfiles.h (struct objfile_per_bfd_storage)
2805         <demangled_hash_languages>: Now a bitset.
2806         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2807         (lookup_minimal_symbol): Update.
2808
2809 2019-03-15  Tom Tromey  <tom@tromey.com>
2810
2811         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2812         Don't return the symbol.
2813         * coffread.c (record_minimal_symbol): Use record_full.
2814
2815 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2816
2817         The MS-Windows port of ncurses fails to switch to a color pair if
2818         one or both of the colors are the implicit default colors.  This
2819         change records the default colors when TUI is initialized, and
2820         then specifies them explicitly when a color pair uses the default
2821         colors.  This allows color styling in TUI mode on MS-Windows.
2822
2823         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2824         ncurses_norm_attr.
2825         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2826         colors in ncurses_norm_attr.
2827         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2828         "none", replace it with the default color recorded in
2829         ncurses_norm_attr.
2830
2831 2019-03-14  Tom Tromey  <tromey@adacore.com>
2832
2833         * source-cache.h (class source_cache) <get_source_lines>: Return
2834         std::string.
2835         * source-cache.c (source_cache::extract_lines): Handle case where
2836         first_pos==npos.  Return std::string.
2837         (source_cache::get_source_lines): Update.
2838
2839 2019-03-14  Tom Tromey  <tromey@adacore.com>
2840
2841         * NEWS: Add item for "style sources" commands.
2842         * source-cache.c (source_cache::get_source_lines): Check
2843         source_styling.
2844         * cli/cli-style.c (source_styling): New global.
2845         (_initialize_cli_style): Add "style sources" commands.
2846         (show_style_sources): New function.
2847         * cli/cli-style.h (source_styling): Declare.
2848
2849 2019-03-14  Pedro Alves  <palves@redhat.com>
2850             Tom Tromey  <tromey@adacore.com>
2851
2852         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2853         * tui/tui-winsource.c (tui_refill_source_window): New function,
2854         from...
2855         (tui_horizontal_source_scroll): ... here.  Move some logic.
2856         * cli/cli-style.c (set_style_enabled): Notify new observable.
2857         * tui/tui-hooks.c (tui_redisplay_source): New function.
2858         (tui_attach_detach_observers): Attach or detach
2859         tui_redisplay_source.
2860         * observable.h (source_styling_changed): New observable.
2861         * observable.c: Define source_styling_changed observable.
2862
2863 2019-03-13  Tom Tromey  <tromey@adacore.com>
2864
2865         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2866         (i386_gnu_nat_target::store_registers): Update.
2867         * target-debug.h (target_debug_print_std_string): New macro.
2868         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2869         * windows-tdep.c (display_one_tib): Update.
2870         * tui/tui-stack.c (tui_make_status_line): Update.
2871         * top.c (print_inferior_quit_action): Update.
2872         * thread.c (thr_try_catch_cmd): Update.
2873         (add_thread_with_info): Update.
2874         (thread_target_id_str): Update.
2875         (thr_try_catch_cmd): Update.
2876         (thread_command): Update.
2877         (thread_find_command): Update.
2878         * record-btrace.c (record_btrace_target::info_record)
2879         (record_btrace_resume_thread, record_btrace_target::resume)
2880         (record_btrace_cancel_resume, record_btrace_step_thread)
2881         (record_btrace_target::wait, record_btrace_target::wait)
2882         (record_btrace_target::wait, record_btrace_target::stop): Update.
2883         * progspace.c (print_program_space): Update.
2884         * process-stratum-target.c
2885         (process_stratum_target::thread_address_space): Update.
2886         * linux-fork.c (linux_fork_mourn_inferior)
2887         (detach_checkpoint_command, info_checkpoints_command)
2888         (linux_fork_context): Update.
2889         (linux_fork_detach): Update.
2890         (class scoped_switch_fork_info): Update.
2891         (delete_checkpoint_command): Update.
2892         * infrun.c (follow_fork_inferior): Update.
2893         (follow_fork_inferior): Update.
2894         (proceed_after_vfork_done): Update.
2895         (handle_vfork_child_exec_or_exit): Update.
2896         (follow_exec): Update.
2897         (displaced_step_prepare_throw): Update.
2898         (displaced_step_restore): Update.
2899         (start_step_over): Update.
2900         (resume_1): Update.
2901         (clear_proceed_status_thread): Update.
2902         (proceed): Update.
2903         (print_target_wait_results): Update.
2904         (do_target_wait): Update.
2905         (context_switch): Update.
2906         (stop_all_threads): Update.
2907         (restart_threads): Update.
2908         (finish_step_over): Update.
2909         (handle_signal_stop): Update.
2910         (switch_back_to_stepped_thread): Update.
2911         (keep_going_pass_signal): Update.
2912         (print_exited_reason): Update.
2913         (normal_stop): Update.
2914         * inferior.c (inferior_pid_to_str): Change return type.
2915         (print_selected_inferior): Update.
2916         (add_inferior): Update.
2917         (detach_inferior): Update.
2918         * dummy-frame.c (fprint_dummy_frames): Update.
2919         * dcache.c (dcache_info_1): Update.
2920         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2921         (btrace_fetch, btrace_clear): Update.
2922         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2923         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2924         type.
2925         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2926         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2927         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2928         * gdbarch.c, gdbarch.h: Rebuild.
2929         * gdbarch.sh (core_pid_to_str): Change return type.
2930         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2931         return type.
2932         (windows_nat_target::pid_to_str): Change return type.
2933         (windows_delete_thread): Update.
2934         (windows_nat_target::attach): Update.
2935         (windows_nat_target::files_info): Update.
2936         * target-delegates.c: Rebuild.
2937         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2938         return type.
2939         (sol_thread_target::pid_to_str): Change return type.
2940         * remote.c (class remote_target) <pid_to_str>: Change return
2941         type.
2942         (remote_target::pid_to_str): Change return type.
2943         (extended_remote_target::attach, remote_target::remote_stop_ns)
2944         (remote_target::remote_notif_remove_queued_reply)
2945         (remote_target::push_stop_reply, remote_target::disable_btrace):
2946         Update.
2947         (extended_remote_target::attach): Update.
2948         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2949         type.
2950         (gdbsim_target::pid_to_str): Change return type.
2951         * ravenscar-thread.c (struct ravenscar_thread_target)
2952         <pid_to_str>: Change return type.
2953         (ravenscar_thread_target::pid_to_str): Change return type.
2954         * procfs.c (class procfs_target) <pid_to_str>: Change return
2955         type.
2956         (procfs_target::pid_to_str): Change return type.
2957         (procfs_target::attach): Update.
2958         (procfs_target::detach): Update.
2959         (procfs_target::fetch_registers): Update.
2960         (procfs_target::store_registers): Update.
2961         (procfs_target::wait): Update.
2962         (procfs_target::files_info): Update.
2963         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2964         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2965         return type.
2966         (nto_procfs_target::pid_to_str): Change return type.
2967         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2968         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2969         return type.
2970         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2971         (exit_lwp): Update.
2972         (attach_proc_task_lwp_callback, get_detach_signal)
2973         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2974         (linux_nat_target::resume, wait_lwp, stop_callback)
2975         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2976         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2977         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2978         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2979         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2980         type.
2981         (inf_ptrace_target::attach): Update.
2982         (inf_ptrace_target::files_info): Update.
2983         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2984         type.
2985         (go32_nat_target::pid_to_str): Change return type.
2986         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2987         (gnu_nat_target::wait): Update.
2988         (gnu_nat_target::wait): Update.
2989         (gnu_nat_target::resume): Update.
2990         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2991         (fbsd_nat_target::wait): Update.
2992         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2993         type.
2994         (darwin_nat_target::attach): Update.
2995         * corelow.c (class core_target) <pid_to_str>: Change return type.
2996         (core_target::pid_to_str): Change return type.
2997         * target.c (normal_pid_to_str): Change return type.
2998         (default_pid_to_str): Likewise.
2999         (target_pid_to_str): Change return type.
3000         (target_translate_tls_address): Update.
3001         (target_announce_detach): Update.
3002         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3003         return type.
3004         (bsd_uthread_target::pid_to_str): Change return type.
3005         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3006         type.
3007         (bsd_kvm_target::pid_to_str): Change return type.
3008         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3009         return type.
3010         (aix_thread_target::pid_to_str): Change return type.
3011         * target.h (struct target_ops) <pid_to_str>: Change return type.
3012         (target_pid_to_str, normal_pid_to_str): Likewise.
3013         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3014         type.
3015         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3016         type.
3017         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3018         return type.
3019         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3020         type.
3021         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3022         type.
3023         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3024         return type.
3025
3026 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3027
3028         * NEWS: Mention that the new default MI version is 3.  Mention
3029         changes to the output of commands and events that deal with
3030         multi-location breakpoints.
3031         * breakpoint.c: Include "mi/mi-out.h".
3032         (print_one_breakpoint): Change output syntax if using MI version
3033         >= 3.
3034         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3035         New.
3036         (mi_multi_location_breakpoint_output_fixed): New.
3037         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3038         (mi_cmd_fix_multi_location_breakpoint_output): New.
3039         (mi_multi_location_breakpoint_output_fixed): New.
3040         * mi/mi-cmds.c (mi_cmds): Register command
3041         -fix-multi-location-breakpoint-output.
3042         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3043         interpreter "mi".
3044
3045 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3046
3047         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3048         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3049         instantiate mi_ui_out based on interpreter name.
3050         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3051         * mi/mi-main.c (mi_load_progress): Likewise.
3052
3053 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3054
3055         * NEWS: Combine separate "New targets" sections for 8.3.
3056
3057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3058
3059         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3060         (ppcfbsd_init_abi): Install gdbarch
3061         "fetch_tls_load_module_address" and "get_thread_local_address"
3062         methods.
3063
3064 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3065
3066         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3067         (riscv_fbsd_init_abi): Install gdbarch
3068         "fetch_tls_load_module_address" and "get_thread_local_address"
3069         methods.
3070
3071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3072
3073         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3074         (i386fbsd_init_abi): Install gdbarch
3075         "fetch_tls_load_module_address" and "get_thread_local_address"
3076         methods.
3077
3078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3079
3080         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3081         (amd64fbsd_init_abi): Install gdbarch
3082         "fetch_tls_load_module_address" and "get_thread_local_address"
3083         methods.
3084
3085 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3086
3087         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3088         (struct fbsd_pspace_data): New type.
3089         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3090         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3091         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3092         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3093         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3094
3095 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3096
3097         * gdbtypes.c (lookup_struct_elt): New function.
3098         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3099         * gdbtypes.h (struct struct_elt): New type.
3100         (lookup_struct_elt): New prototype.
3101
3102 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3103
3104         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3105         remove disabled code block.
3106
3107 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3108
3109         * gdbarch.sh (get_thread_local_address): New method.
3110         * gdbarch.h, gdbarch.c: Regenerate.
3111         * target.c (target_translate_tls_address): Use
3112         gdbarch_get_thread_local_address if present instead of
3113         target::get_thread_local_address.
3114
3115 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3116
3117         * target.h (target::get_thread_local_address): Update comment.
3118
3119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3120
3121         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3122         objfile->separate_debug_objfile_backlink if not NULL.
3123
3124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3125
3126         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3127         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3128         (amd64bsd_store_inferior_registers): Likewise.
3129         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3130         Enable segment base registers.
3131         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3132         PT_GETFSBASE and PT_GETGSBASE.
3133         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3134         PT_SETGSBASE.
3135         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3136         segment base registers.
3137         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3138
3139 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3140
3141         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3142         Update calls to i386_target_description to add 'segments'
3143         parameter.
3144         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3145         add segment base registers.
3146         * arch/i386.c (i386_create_target_description): Add 'segments'
3147         parameter to enable segment base registers.
3148         * arch/i386.h (i386_create_target_description): Likewise.
3149         * features/i386/32bit-segments.xml: New file.
3150         * features/i386/32bit-segments.c: Generate.
3151         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3152         call to i386_target_description to add 'segments' parameter.
3153         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3154         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3155         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3156         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3157         if feature is present.
3158         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3159         Add 'segments' parameter to call to i386_target_description.
3160         (i386_target_description): Add 'segments' parameter to enable
3161         segment base registers.
3162         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3163         to call to i386_target_description.
3164         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3165         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3166         Define I386_NUM_REGS.
3167         (i386_target_description): Add 'segments' parameter to enable
3168         segment base registers.
3169
3170 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3171
3172         PR/24325
3173         * source-cache.c: #undef open and close, to avoid unresolved
3174         externals during linking.
3175
3176 2019-03-12  Tom Tromey  <tromey@adacore.com>
3177
3178         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3179         const.  Add initializers.
3180         (_initialize_remote): Don't initialize ptid globals.
3181
3182 2019-03-12  Pedro Alves  <palves@redhat.com>
3183
3184         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3185
3186 2019-03-12  Pedro Alves  <palves@redhat.com>
3187
3188         * cp-name-parser.y (main): Remove unused 'len' variable.
3189
3190 2019-03-12  Tom Tromey  <tromey@adacore.com>
3191
3192         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3193         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3194
3195 2019-03-12  Tom Tromey  <tromey@adacore.com>
3196
3197         * linux-nat.c (iterate_over_lwps): Update.
3198         (stop_callback): Remove parameter.
3199         (stop_wait_callback, detach_callback, resume_set_callback)
3200         (select_singlestep_lwp_callback, set_ignore_sigint)
3201         (status_callback, resumed_callback, resume_clear_callback)
3202         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3203         data parameter.
3204         (linux_nat_target::detach, linux_nat_target::resume)
3205         (linux_stop_and_wait_all_lwps, select_event_lwp)
3206         (linux_nat_filter_event, linux_nat_wait_1)
3207         (linux_nat_target::kill, linux_nat_target::stop)
3208         (linux_nat_target::stop): Update.
3209         (linux_nat_resume_callback): Change type.
3210         (resume_stopped_resumed_lwps, count_events_callback)
3211         (select_event_lwp_callback): Likewise.
3212         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3213         * arm-linux-nat.c (struct update_registers_data): Remove.
3214         (update_registers_callback): Change type.
3215         (arm_linux_insert_hw_breakpoint1): Update.
3216         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3217         parameter.
3218         (x86_linux_dr_set_addr): Update.
3219         (x86_linux_dr_set_control): Update.
3220         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3221         (iterate_over_lwps): Use gdb::function_view.
3222         * nat/aarch64-linux-hw-point.c (struct
3223         aarch64_dr_update_callback_param): Remove.
3224         (debug_reg_change_callback): Change type.
3225         (aarch64_notify_debug_reg_change): Update.
3226         * s390-linux-nat.c (s390_refresh_per_info): Update.
3227
3228 2019-03-11  Tom Tromey  <tromey@adacore.com>
3229
3230         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3231         redundant assignment to "this_cu".
3232
3233 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3234
3235         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3236
3237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3238
3239         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3240         from...
3241         (rank_one_type): ... this.
3242
3243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3244
3245         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3246         from...
3247         (rank_one_type): ... this.
3248
3249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3250
3251         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3252         from...
3253         (rank_one_type): ... this.
3254
3255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3256
3257         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3258         from...
3259         (rank_one_type): ... this.
3260
3261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3262
3263         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3264         from...
3265         (rank_one_type): ... this.
3266
3267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3268
3269         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3270         from...
3271         (rank_one_type): ... this.
3272
3273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3274
3275         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3276         from...
3277         (rank_one_type): ... this.
3278
3279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3280
3281         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3282         from...
3283         (rank_one_type): ... this.
3284
3285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3286
3287         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3288         from...
3289         (rank_one_type): ... this.
3290
3291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3292
3293         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3294         from...
3295         (rank_one_type): ... this.
3296
3297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3298
3299         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3300         from...
3301         (rank_one_type): ... this.
3302
3303 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3304
3305         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3306         from...
3307         (rank_one_type): ... this.
3308
3309 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3310
3311         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3312         inferior-events' shows the example events.
3313
3314 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3315
3316         Support styling on native MS-Windows console
3317
3318         PR/24315
3319         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3320         on MS-Windows if $TERM is not defined.
3321
3322         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3323
3324         * posix-hdep.c (gdb_console_fputs):
3325         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3326         functions.
3327         * ui-file.h (gdb_console_fputs): Add prototype.
3328
3329         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3330         back to fputs only if the former returns zero.
3331
3332 2019-03-07  Tom Tromey  <tom@tromey.com>
3333
3334         * symmisc.c (print_symbol_bcache_statistics): Update.
3335         (print_objfile_statistics): Update.
3336         * symfile.c (allocate_symtab): Update.
3337         * stabsread.c: Don't include bcache.h.
3338         * psymtab.h (struct psymbol_bcache): Don't declare.
3339         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3340         (psymbol_bcache_init, psymbol_bcache_free)
3341         (psymbol_bcache_get_bcache): Don't declare.
3342         * psymtab.c (struct psymbol_bcache): Remove.
3343         (psymtab_storage::psymtab_storage): Update.
3344         (psymtab_storage::~psymtab_storage): Update.
3345         (psymbol_bcache_init, psymbol_bcache_free)
3346         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3347         (add_psymbol_to_bcache): Update.
3348         (allocate_psymtab): Update.
3349         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3350         macro_cache>: No longer pointers.
3351         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3352         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3353         * macrotab.c (macro_bcache): Update.
3354         * macroexp.c: Don't include bcache.h.
3355         * gdbtypes.c (check_types_worklist): Update.
3356         (types_deeply_equal): Remove TRY/CATCH.  Update.
3357         * elfread.c (elf_symtab_read): Update.
3358         * dwarf2read.c: Don't include bcache.h.
3359         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3360         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3361         (print_bcache_statistics, bcache_memory_used): Don't declare.
3362         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3363         methods.  Rename all data members.
3364         * bcache.c (struct bcache): Move to bcache.h.
3365         (bcache::expand_hash_table): Rename from expand_hash_table.
3366         (bcache): Remove.
3367         (bcache::insert): Rename from bcache_full.
3368         (bcache::compare): Rename from bcache_compare.
3369         (bcache_xmalloc): Remove.
3370         (bcache::~bcache): Rename from bcache_xfree.
3371         (bcache::print_statistics): Rename from print_bcache_statistics.
3372         (bcache::memory_used): Rename from bcache_memory_used.
3373
3374 2019-03-07  Pedro Alves  <palves@redhat.com>
3375
3376         * infrun.c (normal_stop): Also check for
3377         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3378
3379 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3380
3381         * f-lang.c (value_from_host_double): Moved to...
3382         * value.c (value_from_host_double): ...here.
3383         * value.h (value_from_host_double): Declare.
3384         * guile/scm-math.c (vlscm_convert_typed_number): Use
3385         value_from_host_double.
3386         (vlscm_convert_number): Likewise.
3387         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3388         * python/py-value.c (convert_value_from_python): Likewise.
3389
3390 2019-03-06  Tom Tromey  <tom@tromey.com>
3391
3392         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3393
3394 2019-03-06  Tom Tromey  <tom@tromey.com>
3395
3396         * utils.h (free_current_contents): Don't declare.
3397         * utils.c (free_current_contents): Remove.
3398
3399 2019-03-06  Tom Tromey  <tom@tromey.com>
3400
3401         * top.c (quit_force): Update.
3402         * main.c (captured_command_loop): Update.
3403         * common/new-op.c (operator new): Update.
3404         * common/common-exceptions.c (struct catcher)
3405         <save_cleanup_chain>: Remove member.
3406         (exceptions_state_mc_init): Update.
3407         (exception_try_scope_entry): Return nullptr.
3408         (exception_try_scope_exit, exception_rethrow)
3409         (throw_exception_sjlj, throw_exception_cxx): Update.
3410         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3411         (all_cleanups, do_cleanups, discard_cleanups)
3412         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3413         (restore_cleanups, restore_final_cleanups): Don't declare.
3414         (do_final_cleanups): Remove parameter.
3415         * common/cleanups.c (cleanup_chain, make_cleanup)
3416         (make_cleanup_dtor, all_cleanups, do_cleanups)
3417         (discard_my_cleanups, discard_cleanups)
3418         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3419         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3420         (null_cleanup): Remove.
3421         (do_final_cleanups): Remove parameter.
3422
3423 2019-03-06  Tom Tromey  <tom@tromey.com>
3424
3425         * remote.c (remote_target::remote_parse_stop_reply): Use
3426         unique_xmalloc_ptr.
3427
3428 2019-03-06  Tom Tromey  <tom@tromey.com>
3429
3430         * stabsread.c (struct stabs_field_info): Rename from field_info.
3431         <list, fnlist>: Add initializers.
3432         <obstack>: New member.
3433         (read_member_functions, read_struct_fields, read_baseclasses):
3434         Allocate on obstack.  Don't use cleanups.
3435         (read_one_struct_field, read_member_functions, read_struct_fields)
3436         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3437         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3438         (read_struct_type): Update.
3439
3440 2019-03-06  Tom Tromey  <tom@tromey.com>
3441
3442         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3443         * common/filestuff.h (make_cleanup_close): Don't declare.
3444         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3445         Remove.
3446
3447 2019-03-06  Tom Tromey  <tom@tromey.com>
3448
3449         * solib-aix.c: Use make_scope_exit.
3450
3451 2019-03-06  Tom Tromey  <tom@tromey.com>
3452
3453         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3454         Use make_scope_exit.
3455
3456 2019-03-06  Tom Tromey  <tom@tromey.com>
3457
3458         * solib-svr4.c (disable_probes_interface): Remove parameter.
3459         (svr4_handle_solib_event): Use make_scope_exit.
3460
3461 2019-03-06  Tom Tromey  <tom@tromey.com>
3462
3463         * remote.c (struct stop_reply_deleter): Remove.
3464         (stop_reply_up): Update.
3465         (struct stop_reply): Derive from notif_event.  Don't typedef.
3466         <regcache>: Now a std::vector.
3467         (stop_reply_xfree): Remove.
3468         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3469         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3470         (remote_target::discard_pending_stop_replies): Use delete.
3471         (remote_target::remote_parse_stop_reply): Update.
3472         (remote_target::process_stop_reply): Update.
3473         * remote-notif.h (struct notif_event): Add virtual destructor.
3474         Remove "dtr" member.
3475         (struct notif_client) <alloc_event>: Return a unique_ptr.
3476         (notif_event_xfree): Don't declare.
3477         (notif_event_up): New typedef.
3478         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3479         (notif_event_xfree, do_notif_event_xfree): Remove.
3480         (remote_notif_state_xfree): Update.
3481
3482 2019-03-06  Tom Tromey  <tom@tromey.com>
3483
3484         * infrun.c (displaced_step_clear_cleanup): Now a
3485         forward_scope_exit type.
3486         (displaced_step_prepare_throw): Update.
3487         (displaced_step_fixup): Update.
3488
3489 2019-03-06  Tom Tromey  <tom@tromey.com>
3490
3491         * inferior.h (class inferior): Update comment.
3492         * gdbthread.h (class thread_info): Update comment.
3493
3494 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3495             Tom Tromey  <tom@tromey.com>
3496
3497         * stabsread.h (struct stab_section_list): Remove.
3498         (coffstab_build_psymtabs): Update.
3499         * dbxread.c (symbuf_sections): Now a std::vector.
3500         (sect_idx): New global.
3501         (fill_symbuf): Update.
3502         (coffstab_build_psymtabs): Change type of stabsects parameter.
3503         Update.
3504         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3505         std::vector.
3506         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3507         (coff_locate_sections): Update.
3508         (coff_symfile_read): Remove cleanups.  Update.
3509         (init_stringtab): Add storage parameter.
3510         (free_stringtab, free_stringtab_cleanup): Remove.
3511         (init_lineno): Add storage parameter.
3512         (free_linetab, free_linetab_cleanup): Remove.
3513
3514 2019-03-06  Pedro Alves  <palves@redhat.com>
3515
3516         * linux-fork.c (fork_info::clobber_regs): Delete.
3517         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3518         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3519         comment.  Adjust.
3520         (scoped_switch_fork_info::scoped_switch_fork_info)
3521         (checkpoint_command, linux_fork_context): Adjust
3522         fork_save_infrun_state calls.
3523
3524 2019-03-06  Pedro Alves  <palves@redhat.com>
3525
3526         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3527         (inf_has_multiple_threads): Return 'bool' and rewrite using
3528         inferior_info::threads().
3529
3530 2019-03-06  Pedro Alves  <palves@redhat.com>
3531
3532         * linux-fork.c: Include <list>.
3533         (fork_list): Now a std::list instance.
3534         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3535         (forks_exist_p, find_last_fork): Adjust.
3536         (new_fork): Delete.
3537         (one_fork_p): New.
3538         (add_fork): Adjust.
3539         (free_fork): Delete, folded into fork_info::~fork_info().
3540         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3541         Adjust.
3542         (init_fork_list): Delete.
3543         (linux_fork_killall, linux_fork_mourn_inferior)
3544         (linux_fork_detach, info_checkpoints_command): Adjust.
3545         (_initialize_linux_fork): No longer call init_fork_list.
3546
3547 2019-03-06  Pedro Alves  <palves@redhat.com>
3548
3549         * linux-fork.c (new_fork): New, split out of ...
3550         (add_fork): ... this.  Return void.  Move "first fork" special
3551         case from here, to ...
3552         (checkpoint_command): ... here.
3553         * linux-linux.h (add_fork): Return void.
3554
3555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3558
3559 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3560             Chris January  <chris.january@arm.com>
3561             David Lecomber  <david.lecomber@arm.com>
3562
3563         * f-exp.y: New token, UNOP_INTRINSIC.
3564         (exp): New pattern using UNOP_INTRINSIC token.
3565         (f77_keywords): Add 'abs' keyword.
3566         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3567         (value_from_host_double): New function.
3568         (evaluate_subexp_f): Support UNOP_ABS.
3569
3570 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3571
3572         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3573         types.
3574
3575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3576
3577         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3578         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3579         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3580
3581 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3582
3583         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3584
3585 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3586             Chris January  <chris.january@arm.com>
3587
3588         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3589         * f-exp.y: Define 'KIND' token.
3590         (exp): New pattern for KIND expressions.
3591         (ptype): Handle types with a kind extension.
3592         (direct_abs_decl): Extend to spot kind extensions.
3593         (f77_keywords): Add 'kind' to the list.
3594         (push_kind_type): New function.
3595         (convert_to_kind_type): New function.
3596         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3597         * parse.c (operator_length_standard): Likewise.
3598         * parser-defs.h (enum type_pieces): Add tp_kind.
3599         * std-operator.def: Add UNOP_KIND.
3600
3601 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3602
3603         * f-exp.y (f_parse): Set yydebug.
3604
3605 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3606
3607         * f-lang.c (evaluate_subexp_f): New function.
3608         (exp_descriptor_f): New global.
3609         (f_language_defn): Use exp_descriptor_f instead of
3610         exp_descriptor_standard.
3611
3612 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3613
3614         * f-exp.y (struct token): Add comments.
3615         (dot_ops): Remove uppercase versions and the end marker.
3616         (f77_keywords): Likewise.
3617         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3618         entries in the dot_ops array are case insensitive, and use
3619         strncasecmp to compare strings.  Also some whitespace cleanup in
3620         this area.  Similar for the f77_keywords array, except entries in
3621         this list might be case sensitive.
3622
3623 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         * f-exp.y (struct f77_boolean_val): Add comments.
3626         (boolean_values): Remove uppercase versions, and end marker.
3627         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3628         and use strncasecmp to achieve case insensitivity.  Additionally,
3629         perform whitespace cleanup around this code.
3630
3631 2019-03-06  Tom Tromey  <tromey@adacore.com>
3632
3633         * remote-sim.c (gdbsim_target_open): Use result of
3634         gdb_argv::release.
3635
3636 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3637         Dirk Schubert  <dirk.schubert@arm.com>
3638         Chris January  <chris.january@arm.com>
3639
3640         * eval.c (evaluate_subexp_standard): Call Fortran argument
3641         wrapping logic.
3642         * f-lang.c (struct value): A value which can be passed into a
3643         Fortran function call.
3644         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3645         where appropriate.
3646         (struct type): Value ready for a Fortran function call.
3647         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3648         is needed.
3649         * f-lang.h (fortran_argument_convert): Declaration.
3650         (fortran_preserve_arg_pointer): Declaration.
3651         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3652
3653 2019-03-05  Tom Tromey  <tromey@adacore.com>
3654
3655         * python/py-prettyprint.c (print_string_repr): Remove #if.
3656         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3657
3658 2019-03-05  Tom Tromey  <tromey@adacore.com>
3659
3660         * target.c (the_dummy_target): Move later.  Change type to
3661         "dummy_target".
3662         (initialize_targets): Don't initialize the_dummy_target.
3663
3664 2019-03-05  Tom Tromey  <tromey@adacore.com>
3665
3666         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3667         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3668
3669 2019-03-05  Tom Tromey  <tromey@adacore.com>
3670
3671         * windows-nat.c (windows_nat_target::attach)
3672         (windows_nat_target::detach): Don't call gdb_flush.
3673         * valprint.c (generic_val_print, val_print, val_print_string):
3674         Don't call gdb_flush.
3675         * utils.c (defaulted_query): Don't call gdb_flush.
3676         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3677         * target.c (target_announce_detach): Don't call gdb_flush.
3678         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3679         * remote.c (extended_remote_target::attach): Don't call
3680         gdb_flush.
3681         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3682         * printcmd.c (do_examine): Don't call gdb_flush.
3683         (info_display_command): Don't call gdb_flush.
3684         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3685         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3686         * memattr.c (info_mem_command): Don't call gdb_flush.
3687         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3688         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3689         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3690         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3691         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3692         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3693         (gnu_nat_target::detach): Don't call gdb_flush.
3694         * f-valprint.c (f_val_print): Don't call gdb_flush.
3695         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3696         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3697         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3698         gdb_flush.
3699         * c-valprint.c (c_val_print): Don't call gdb_flush.
3700         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3701
3702 2019-03-05  Tom Tromey  <tromey@adacore.com>
3703
3704         * varobj.c (update_dynamic_varobj_children): Update.
3705         (install_default_visualizer): Use reset, not release.
3706         * value.c (set_internalvar): Update.
3707         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3708         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3709         ATTRIBUTE_UNUSED_RESULT.
3710
3711 2019-03-05  Tom Tromey  <tromey@adacore.com>
3712
3713         * remote.c (class scoped_remote_fd) <release>: Add
3714         ATTRIBUTE_UNUSED_RESULT.
3715
3716 2019-03-05  Tom Tromey  <tromey@adacore.com>
3717
3718         * macroexp.c (struct macro_buffer) <release>: Add
3719         ATTRIBUTE_UNUSED_RESULT.
3720
3721 2019-03-05  Tom Tromey  <tromey@adacore.com>
3722
3723         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3724         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3725         ATTRIBUTE_UNUSED_RESULT.
3726
3727 2019-03-05  Tom Tromey  <tromey@adacore.com>
3728
3729         * common/scoped_fd.h (class scoped_fd) <release>: Add
3730         ATTRIBUTE_UNUSED_RESULT.
3731
3732 2019-03-05  Tom Tromey  <tromey@adacore.com>
3733
3734         * parser-defs.h (struct parser_state) <release>: Add
3735         ATTRIBUTE_UNUSED_RESULT.
3736
3737 2019-03-05  Tom Tromey  <tromey@adacore.com>
3738
3739         * utils.h (class gdb_argv) <release>: Add
3740         ATTRIBUTE_UNUSED_RESULT.
3741         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3742
3743 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3744
3745         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3746         for-loop range, to avoid compiler warnings.
3747
3748         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3749         avoid compiler warnings about unused variables.
3750
3751         * NEWS: Mention end of support for native debugging on MS-Windows
3752         before XP.
3753
3754         PR gdb/24292
3755         * common/netstuff.c:
3756         * gdbserver/gdbreplay.c
3757         * gdbserver/remote-utils.c:
3758         * ser-tcp.c:
3759         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3760         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3761         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3762         'getaddrinfo' and 'freeaddrinfo' were not available before
3763         Windows XP, and mingw.org's MinGW headers by default define
3764         _WIN32_WINNT to 0x500.
3765
3766 2019-03-01  Gary Benson <gbenson@redhat.com>
3767
3768         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3769
3770 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3771             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3772
3773         PR gdb/8527
3774         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3775         set_sigint_trap, clear_sigint_trap.
3776
3777 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3778
3779         * target.c (target_detach): Clear the regcache and the
3780         frame cache.
3781
3782 2019-02-27  Pedro Alves  <palves@redhat.com>
3783
3784         * utils.c (set_screen_size): When we cap the height/width sizes,
3785         tweak the corresponding command variable to show "unlimited":
3786
3787 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3788             Pedro Alves  <palves@redhat.com>
3789
3790         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3791         before calling rl_set_screen_size.
3792
3793 2019-02-27  Tom Tromey  <tromey@adacore.com>
3794
3795         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3796         define.
3797         * python/py-value.c: Remove Python 2.4 workaround.
3798         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3799         workaround.
3800         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3801         Python 2.4 workaround.
3802         * python/python-internal.h: Remove Python 2.4 comment.
3803         (Py_ssize_t): Don't define.
3804         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3805         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3806         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3807         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3808         * python/python.c (do_start_initialization): Remove Python 2.4
3809         workaround.
3810         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3811         (print_children): Remove Python 2.4 workaround.
3812         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3813         workaround.
3814         (CHARBUFFERPROC_NAME): Remove.
3815         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3816         Python 2.4 workaround.
3817
3818 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3819
3820         * NEWS: Note minimum Python version.
3821
3822 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3823
3824         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3825         code from these functions.  Remove corresponding ifdefs.  Use
3826         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3827         Remove gotos and target of gotos.
3828         (infpy_search_memory): Likewise.
3829
3830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3833         (hppa_gdbarch_init): Don't register deleted functions with
3834         gdbarch.
3835
3836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3839         (h8300_unwind_sp): Delete.
3840         (h8300_dummy_id): Delete.
3841         (h8300_gdbarch_init): Don't register deleted functions with
3842         gdbarch.
3843
3844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3847         (ft32_unwind_pc): Delete.
3848         (ft32_unwind_sp): Delete.
3849         (ft32_gdbarch_init): Don't register deleted functions with
3850         gdbarch.
3851
3852 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3853
3854         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3855         (frv_unwind_pc): Delete.
3856         (frv_unwind_sp): Delete.
3857         (frv_gdbarch_init): Don't register deleted functions with
3858         gdbarch.
3859
3860 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3863         (riscv_unwind_pc): Delete.
3864         (riscv_unwind_sp): Delete.
3865         (riscv_gdbarch_init): Don't register deleted functions with
3866         gdbarch.
3867
3868 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3869
3870         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3871         (csky_unwind_pc): Delete.
3872         (csky_unwind_sp): Delete.
3873         (csky_gdbarch_init): Don't register deleted functions with
3874         gdbarch.
3875
3876 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3879         (cris_unwind_pc): Delete.
3880         (cris_unwind_sp): Delete.
3881         (cris_gdbarch_init): Don't register deleted functions with
3882         gdbarch.
3883
3884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3885
3886         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3887         (bfin_unwind_pc): Delete.
3888         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3889
3890 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3891
3892         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3893         (arm_unwind_pc): Delete.
3894         (arm_unwind_sp): Delete.
3895         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3896
3897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3900         (arc_unwind_pc): Delete.
3901         (arc_unwind_sp): Delete.
3902         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3903
3904 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3905
3906         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3907         (alpha_unwind_pc): Delete.
3908         (alpha_gdbarch_init): Don't register deleted functions with
3909         gdbarch.
3910
3911 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3914         (aarch64_unwind_pc): Delete.
3915         (aarch64_unwind_sp): Delete.
3916         (aarch64_gdbarch_init): Don't register deleted functions with
3917         gdbarch.
3918
3919 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3920
3921         * gdbtypes.c (type_align): Don't consider static members when
3922         computing structure alignment.
3923
3924 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3927         return 0 for other types.
3928         * arch-utils.c (default_type_align): Always return 0.
3929         * gdbarch.h: Regenerate.
3930         * gdbarch.sh (type_align): Extend comment.
3931         * gdbtypes.c (type_align): Add additional comments, always call
3932         gdbarch_type_align before applying the default rules.
3933         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3934         generic code will then apply a suitable default.
3935         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3936         types, return 0 for other types.
3937
3938 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3939
3940         * NEWS: Create a new section for the next release branch.
3941         Rename the section of the current branch, now that it has
3942         been cut.
3943
3944 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3945
3946         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3947         * version.in: Bump version to 8.3.50.DATE-git.
3948
3949 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3950
3951         * aix-thread.c (ptid_cmp): Remove unused variable.
3952         (get_signaled_thread): Likewise.
3953         (store_regs_user_thread): Likewise.
3954         (store_regs_kernel_thread): Likewise.
3955         (fetch_regs_kernel_thread): Remove shadowed variable.
3956
3957 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3958
3959         * features/riscv/32bit-cpu.xml: Add register numbers.
3960         * features/riscv/32bit-fpu.c: Regenerate.
3961         * features/riscv/32bit-fpu.xml: Add register numbers.
3962         * features/riscv/64bit-cpu.xml: Add register numbers.
3963         * features/riscv/64bit-fpu.c: Regenerate.
3964         * features/riscv/64bit-fpu.xml: Add register numbers.
3965
3966 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3967
3968         * NEWS: Mention two argument form of gdb.Value constructor.
3969         * python/py-value.c (convert_buffer_and_type_to_value): New
3970         function.
3971         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3972         Add support for handling an optional second argument.  Call
3973         convert_buffer_and_type_to_value as appropriate.
3974         * python/python-internal.h (Py_buffer_deleter): New struct.
3975         (Py_buffer_up): New typedef.
3976
3977 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3978
3979         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3980         instead of releasing ownership.
3981
3982 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3983
3984         * dwarf2read.c (open_and_init_dwp_file): Call
3985         elf_numsections instead of bfd_count_sections to initialize
3986         dwp_file->num_sections.
3987
3988 2019-02-25  Tom Tromey  <tromey@adacore.com>
3989
3990         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3991
3992 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3993
3994         * gcore.in: Add '--readnever' option when invoking GDB.
3995
3996 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3997
3998         * MAINTAINERS: Update my email address.
3999
4000 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4001
4002         * build-id.c (build_id_to_debug_bfd_1): New function.
4003         (build_id_to_debug_bfd): Look for separate debug file in
4004         sysroot.
4005
4006 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4007
4008         * gdbarch.sh: Update the copyright year range that is placed into
4009         generated files.
4010
4011 2019-02-22  Keith Seitz  <keiths@redhat.com>
4012
4013         PR symtab/23853
4014         * linespec.c (create_sals_line_offset): Search for the default
4015         symtab's filename instead of its fullname.
4016
4017 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4018
4019         * NEWS: Update style defaults.
4020
4021 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4022
4023         * main.c (captured_main_1): Disable styling in batch mode.
4024
4025 2019-02-20  Tom Tromey  <tom@tromey.com>
4026
4027         * symtab.c (symtab_symbol_info): Fix typos.
4028
4029 2019-02-20  Tom Tromey  <tromey@adacore.com>
4030
4031         * findcmd.c (_initialize_mem_search): Use upper case for
4032         metasyntactic variables.
4033
4034 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4035
4036         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4037         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4038
4039 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4040
4041         * top.h (source_file_name): Change to std::string.
4042         * top.c (source_file_name): Likewise.
4043         (command_line_input): Adjust.
4044         * cli/cli-script.c (script_from_file): Adjust.
4045
4046 2019-02-19  Tom Tromey  <tromey@adacore.com>
4047
4048         * ravenscar-thread.c
4049         (ravenscar_thread_target::update_thread_list): Don't call
4050         ada_build_task_list.
4051         * ada-lang.h (ada_build_task_list): Don't declare.
4052         * ada-tasks.c (struct ada_tasks_inferior_data)
4053         <task_list_valid_p>: Now bool.
4054         (read_known_tasks, ada_task_list_changed)
4055         (ada_tasks_invalidate_inferior_data): Update.
4056         (read_known_tasks_array): Return bool.
4057         (read_known_tasks_list): Likewise.
4058         (read_known_tasks): Return void.
4059         (ada_build_task_list): Now static.
4060
4061 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4062
4063         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4064         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4065
4066 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4067
4068         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4069         variant for ada_tasks_pspace_data_handle and
4070         ada_tasks_inferior_data_handle.
4071         (ada_tasks_pspace_data_cleanup): New function.
4072         (ada_tasks_inferior_data_cleanup): New function.
4073
4074 2019-02-17  Tom Tromey  <tom@tromey.com>
4075
4076         * macrotab.h (macro_source_fullname): Return a std::string.
4077         * macrotab.c (macro_include, check_for_redefinition)
4078         (macro_undef, macro_lookup_definition, foreach_macro)
4079         (foreach_macro_in_scope): Update.
4080         (macro_source_fullname): Return a std::string.
4081         * macrocmd.c (show_pp_source_pos): Update.
4082
4083 2019-02-17  Tom Tromey  <tom@tromey.com>
4084
4085         * macrocmd.c (show_pp_source_pos): Style the file names.
4086
4087 2019-02-17  Tom Tromey  <tom@tromey.com>
4088
4089         PR tui/24197:
4090         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4091
4092 2019-02-17  Tom Tromey  <tom@tromey.com>
4093
4094         * ada-lang.c (user_select_syms): Use filtered printing.
4095         * utils.c (wrap_style): New global.
4096         (desired_style): Remove.
4097         (emit_style_escape): Add stream parameter.
4098         (set_output_style, reset_terminal_style, prompt_for_continue):
4099         Update.
4100         (flush_wrap_buffer): Only flush gdb_stdout.
4101         (wrap_here): Set wrap_style.
4102         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4103         treat escape sequences as a character.  Change when wrap buffer is
4104         flushed.
4105         (fputs_styled): Do not set the output style when the default is
4106         requested.
4107         * ui-style.h (struct ui_file_style) <is_default>: New method.
4108         * source.c (print_source_lines_base): Emit escape sequences in one
4109         piece.
4110
4111 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4112
4113         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4114         integers and enumeration types.
4115
4116 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4117
4118         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4119         instead of lookup_symbol_in_language
4120         (do_exact_match): New function.
4121         (ada_get_symbol_name_matcher): Return do_exact_match when
4122         doing a verbatim match.
4123
4124 2019-02-15  Tom Tromey  <tromey@adacore.com>
4125
4126         * ravenscar-thread.c (ravenscar_thread_target::resume)
4127         (ravenscar_thread_target::wait): Special case wildcard requests.
4128
4129 2019-02-15  Tom Tromey  <tromey@adacore.com>
4130
4131         * ravenscar-thread.c (base_ptid): Remove.
4132         (struct ravenscar_thread_target) <close>: New method.
4133         <m_base_ptid>: New member.
4134         <update_inferior_ptid, active_task, task_is_currently_active,
4135         runtime_initialized>: Declare methods.
4136         <ravenscar_thread_target>: Add constructor.
4137         (ravenscar_thread_target::task_is_currently_active)
4138         (ravenscar_thread_target::update_inferior_ptid)
4139         (ravenscar_runtime_initialized): Rename.  Now methods.
4140         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4141         (ravenscar_thread_target::update_thread_list): Update.
4142         (ravenscar_thread_target::active_task): Now method.
4143         (ravenscar_thread_target::store_registers)
4144         (ravenscar_thread_target::prepare_to_store)
4145         (ravenscar_thread_target::prepare_to_store)
4146         (ravenscar_thread_target::mourn_inferior): Update.
4147         (ravenscar_inferior_created): Use "new" to create target.
4148         (ravenscar_thread_target::get_ada_task_ptid): Update.
4149         (_initialize_ravenscar): Don't initialize base_ptid.
4150         (ravenscar_ops): Remove global.
4151
4152 2019-02-15  Tom Tromey  <tromey@adacore.com>
4153
4154         * target.h (push_target): Declare new overload.
4155         * target.c (push_target): New overload, taking an rvalue reference.
4156         * remote.c (remote_target::open_1): Use push_target overload.
4157         * corelow.c (core_target_open): Use push_target overload.
4158
4159 2019-02-15  Tom Tromey  <tromey@adacore.com>
4160
4161         * ravenscar-thread.c (is_ravenscar_task)
4162         (ravenscar_task_is_currently_active): Return bool.
4163         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4164         (_initialize_ravenscar): Remove "(void)".
4165         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4166         Return bool.
4167
4168 2019-02-15  Tom Tromey  <tromey@adacore.com>
4169
4170         * ravenscar-thread.c (ravenscar_runtime_initializer)
4171         (has_ravenscar_runtime, get_running_thread_id)
4172         (ravenscar_thread_target::resume): Fix indentation.
4173
4174 2019-02-15  Tom Tromey  <tromey@adacore.com>
4175
4176         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4177         from ravenscar_arch_ops.
4178         (sparc_ravenscar_ops::fetch_registers)
4179         (sparc_ravenscar_ops::store_registers): Now methods.
4180         (sparc_ravenscar_prepare_to_store): Remove.
4181         (sparc_ravenscar_ops): Redefine.
4182         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4183         methods and destructor.  Remove members.
4184         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4185         (ravenscar_thread_target::store_registers)
4186         (ravenscar_thread_target::prepare_to_store): Update.
4187         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4188         Remove.
4189         (struct ppc_ravenscar_powerpc_ops): Derive from
4190         ravenscar_arch_ops.
4191         (ppc_ravenscar_powerpc_ops::fetch_registers)
4192         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4193         (ppc_ravenscar_powerpc_ops): Redefine.
4194         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4195         (ppc_ravenscar_e500_ops::fetch_registers)
4196         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4197         (ppc_ravenscar_e500_ops): Redefine.
4198         * aarch64-ravenscar-thread.c
4199         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4200         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4201         (aarch64_ravenscar_fetch_registers)
4202         (aarch64_ravenscar_store_registers): Now methods.
4203         (aarch64_ravenscar_ops): Redefine.
4204
4205 2019-02-15  Tom Tromey  <tromey@adacore.com>
4206
4207         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4208         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4209         (ravenscar_thread_target::stopped_by_watchpoint)
4210         (ravenscar_thread_target::stopped_data_address)
4211         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4212
4213 2019-02-15  Tom Tromey  <tromey@adacore.com>
4214
4215         * ravenscar-thread.c: Fix some typos.
4216
4217 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4218             Tom Tromey  <tromey@adacore.com>
4219
4220         * ada-lang.c (ada_exception_sal): Change addr_string to a
4221         std::string.
4222         (create_ada_exception_catchpoint): Update.
4223
4224 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4225             Tom Tromey  <tromey@adacore.com>
4226
4227         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4228         (bp_location_ops): Remove.
4229         (base_breakpoint_allocate_location): Update.
4230         (free_bp_location): Update.
4231         * ada-lang.c (class ada_catchpoint_location)
4232         <ada_catchpoint_location>: Remove ops parameter.
4233         (ada_catchpoint_location_dtor): Remove.
4234         (ada_catchpoint_location_ops): Remove.
4235         (allocate_location_exception): Update.
4236         * breakpoint.h (struct bp_location_ops): Remove.
4237         (class bp_location) <bp_location>: Remove bp_location_ops
4238         parameter.
4239         <~bp_location>: Add destructor.
4240         <ops>: Remove.
4241
4242 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4243             Pedro Alves  <palves@redhat.com>
4244
4245         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4246         'PATH_MAX'.
4247
4248 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4249             Samuel Thibault  <samuel.thibault@gnu.org>
4250             Thomas Schwinge  <thomas@codesourcery.com>
4251
4252         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4253         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4254
4255 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4256
4257         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4258         (check_empty): Use "const char *".
4259
4260         * gnu-nat.c (gnu_nat_target::detach): Instead of
4261         'detach_inferior (pid)' call
4262         'detach_inferior (find_inferior_pid (pid))'.
4263
4264         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4265         'nat/fork-inferior.o'.
4266         * gnu-nat.c: #include "nat/fork-inferior.h".
4267
4268         * gnu-nat.c (gnu_nat_target::detach): Instead of
4269         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4270         * gnu-nat.h: #include "inf-child.h".
4271         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4272         'i386_gnu_nat_target::fetch_registers'.
4273         (gnu_store_registers): Rename/move to
4274         'i386_gnu_nat_target::store_registers'.
4275
4276         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4277         * gnu-nat.h (mach_thread_info): New function.
4278         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4279
4280         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4281
4282 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4283
4284         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4285
4286 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4287
4288         * windows-nat.c (windows_add_thread): Add new parameter
4289         "main_thread_p" with default value set to false.  Update
4290         function documentation as well as all callers.
4291         (windows_delete_thread): Likewise.
4292         (fake_create_process): Update call to windows_add_thread.
4293         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4294         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4295         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4296         call to windows_delete_thread.
4297
4298 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4299
4300         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4301
4302 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4303
4304         * symfile.c (find_separate_debug_file): Use canonical path of
4305         sysroot with child_path instead of gdb_sysroot if it is valid.
4306
4307 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4308
4309         * symfile.c (find_separate_debug_file): Use child_path to
4310         determine if an object file is under a sysroot.
4311
4312 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4313
4314         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4315         unittests/child-path-selftests.c.
4316         * common/pathstuff.c (child_path): New function.
4317         * common/pathstuff.h (child_path): New prototype.
4318         * unittests/child-path-selftests.c: New file.
4319
4320 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4321
4322         * symfile.c (find_separate_debug_file): Look for separate debug
4323         files in debug directories under the sysroot.
4324
4325 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4326
4327         * symtab.h (struct minimal_symbol data_p): New const method.
4328         (struct minimal_symbol text_p): Likewise.
4329         * symtab.c (output_source_filename): Use file name style
4330         to print file name.
4331         (print_symbol_info): Likewise.
4332         (print_msymbol_info): Use address style to print addresses.
4333         Use function name style to print executable text symbols.
4334         (expand_symtab_containing_pc): Use data_p.
4335         (find_pc_sect_compunit_symtab): Likewise.
4336
4337 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4338
4339         * breakpoint.c (describe_other_breakpoints): Use address style
4340         to print addresses.
4341         (say_where): Likewise.
4342
4343 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4344
4345         * ada-typeprint.c (print_func_type): Print function name
4346         style to print function name.
4347         * c-typeprint.c (c_print_type_1): Likewise.
4348
4349 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4350
4351         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4352         for execve.
4353
4354 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4355
4356         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4357         type_stack.
4358
4359 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4360
4361         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4362         TYPE_CODE_REF types.
4363
4364 2019-02-08  Jim Wilson  <jimw@sifive.com>
4365
4366         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4367         (riscv_linux_fregset): New.
4368         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4369
4370 2019-02-07  Tom Tromey  <tom@tromey.com>
4371
4372         * thread.c (thread_cancel_execution_command): Update.
4373         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4374         methods.
4375         (struct thread_fsm_ops): Remove.
4376         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4377         (thread_fsm_should_stop, thread_fsm_return_value)
4378         (thread_fsm_set_finished, thread_fsm_finished_p)
4379         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4380         Don't declare.
4381         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4382         * infrun.c (clear_proceed_status_thread)
4383         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4384         (print_stop_event): Update.
4385         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4386         Add constructor.
4387         (step_command_fsm_ops): Remove.
4388         (new_step_command_fsm): Remove.
4389         (step_1): Update.
4390         (step_command_fsm::should_stop): Rename from
4391         step_command_fsm_should_stop.
4392         (step_command_fsm::clean_up): Rename from
4393         step_command_fsm_clean_up.
4394         (step_command_fsm::do_async_reply_reason): Rename from
4395         step_command_fsm_async_reply_reason.
4396         (struct until_next_fsm): Inherit from thread_fsm.  Add
4397         constructor.
4398         (until_next_fsm_ops): Remove.
4399         (new_until_next_fsm): Remove.
4400         (until_next_fsm::should_stop): Rename from
4401         until_next_fsm_should_stop.
4402         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4403         (until_next_fsm::do_async_reply_reason): Rename from
4404         until_next_fsm_async_reply_reason.
4405         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4406         constructor.  Change type of breakpoint.
4407         (finish_command_fsm_ops): Remove.
4408         (new_finish_command_fsm): Remove.
4409         (finish_command_fsm::should_stop): Rename from
4410         finish_command_fsm_should_stop.
4411         (finish_command_fsm::clean_up): Rename from
4412         finish_command_fsm_clean_up.
4413         (finish_command_fsm::return_value): Rename from
4414         finish_command_fsm_return_value.
4415         (finish_command_fsm::do_async_reply_reason): Rename from
4416         finish_command_fsm_async_reply_reason.
4417         (finish_command): Update.
4418         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4419         Add constructor.
4420         (call_thread_fsm_ops): Remove.
4421         (call_thread_fsm::call_thread_fsm): Rename from
4422         new_call_thread_fsm.
4423         (call_thread_fsm::should_stop): Rename from
4424         call_thread_fsm_should_stop.
4425         (call_thread_fsm::should_notify_stop): Rename from
4426         call_thread_fsm_should_notify_stop.
4427         (run_inferior_call, call_function_by_hand_dummy): Update.
4428         * cli/cli-interp.c (should_print_stop_to_console): Update.
4429         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4430         Add constructor.  Change type of location_breakpoint,
4431         caller_breakpoint.
4432         (until_break_fsm_ops): Remove.
4433         (new_until_break_fsm): Remove.
4434         (until_break_fsm::should_stop): Rename from
4435         until_break_fsm_should_stop.
4436         (until_break_fsm::clean_up): Rename from
4437         until_break_fsm_clean_up.
4438         (until_break_fsm::do_async_reply_reason): Rename from
4439         until_break_fsm_async_reply_reason.
4440         (until_break_command): Update.
4441         * thread-fsm.c: Remove.
4442         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4443
4444 2019-02-07  Tom Tromey  <tom@tromey.com>
4445
4446         * yy-remap.h: Add include guard.
4447         * xtensa-tdep.h: Add include guard.
4448         * xcoffread.h: Rename include guard.
4449         * varobj-iter.h: Add include guard.
4450         * tui/tui.h: Rename include guard.
4451         * tui/tui-winsource.h: Rename include guard.
4452         * tui/tui-wingeneral.h: Rename include guard.
4453         * tui/tui-windata.h: Rename include guard.
4454         * tui/tui-win.h: Rename include guard.
4455         * tui/tui-stack.h: Rename include guard.
4456         * tui/tui-source.h: Rename include guard.
4457         * tui/tui-regs.h: Rename include guard.
4458         * tui/tui-out.h: Rename include guard.
4459         * tui/tui-layout.h: Rename include guard.
4460         * tui/tui-io.h: Rename include guard.
4461         * tui/tui-hooks.h: Rename include guard.
4462         * tui/tui-file.h: Rename include guard.
4463         * tui/tui-disasm.h: Rename include guard.
4464         * tui/tui-data.h: Rename include guard.
4465         * tui/tui-command.h: Rename include guard.
4466         * tic6x-tdep.h: Add include guard.
4467         * target/waitstatus.h: Rename include guard.
4468         * target/wait.h: Rename include guard.
4469         * target/target.h: Rename include guard.
4470         * target/resume.h: Rename include guard.
4471         * target-float.h: Rename include guard.
4472         * stabsread.h: Add include guard.
4473         * rs6000-tdep.h: Add include guard.
4474         * riscv-fbsd-tdep.h: Add include guard.
4475         * regformats/regdef.h: Rename include guard.
4476         * record.h: Rename include guard.
4477         * python/python.h: Rename include guard.
4478         * python/python-internal.h: Rename include guard.
4479         * python/py-stopevent.h: Rename include guard.
4480         * python/py-ref.h: Rename include guard.
4481         * python/py-record.h: Rename include guard.
4482         * python/py-record-full.h: Rename include guard.
4483         * python/py-record-btrace.h: Rename include guard.
4484         * python/py-instruction.h: Rename include guard.
4485         * python/py-events.h: Rename include guard.
4486         * python/py-event.h: Rename include guard.
4487         * procfs.h: Add include guard.
4488         * proc-utils.h: Add include guard.
4489         * p-lang.h: Add include guard.
4490         * or1k-tdep.h: Rename include guard.
4491         * observable.h: Rename include guard.
4492         * nto-tdep.h: Rename include guard.
4493         * nat/x86-linux.h: Rename include guard.
4494         * nat/x86-linux-dregs.h: Rename include guard.
4495         * nat/x86-gcc-cpuid.h: Add include guard.
4496         * nat/x86-dregs.h: Rename include guard.
4497         * nat/x86-cpuid.h: Rename include guard.
4498         * nat/ppc-linux.h: Rename include guard.
4499         * nat/mips-linux-watch.h: Rename include guard.
4500         * nat/linux-waitpid.h: Rename include guard.
4501         * nat/linux-ptrace.h: Rename include guard.
4502         * nat/linux-procfs.h: Rename include guard.
4503         * nat/linux-osdata.h: Rename include guard.
4504         * nat/linux-nat.h: Rename include guard.
4505         * nat/linux-namespaces.h: Rename include guard.
4506         * nat/linux-btrace.h: Rename include guard.
4507         * nat/glibc_thread_db.h: Rename include guard.
4508         * nat/gdb_thread_db.h: Rename include guard.
4509         * nat/gdb_ptrace.h: Rename include guard.
4510         * nat/fork-inferior.h: Rename include guard.
4511         * nat/amd64-linux-siginfo.h: Rename include guard.
4512         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4513         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4514         * nat/aarch64-linux.h: Rename include guard.
4515         * nat/aarch64-linux-hw-point.h: Rename include guard.
4516         * mn10300-tdep.h: Add include guard.
4517         * mips-linux-tdep.h: Add include guard.
4518         * mi/mi-parse.h: Rename include guard.
4519         * mi/mi-out.h: Rename include guard.
4520         * mi/mi-main.h: Rename include guard.
4521         * mi/mi-interp.h: Rename include guard.
4522         * mi/mi-getopt.h: Rename include guard.
4523         * mi/mi-console.h: Rename include guard.
4524         * mi/mi-common.h: Rename include guard.
4525         * mi/mi-cmds.h: Rename include guard.
4526         * mi/mi-cmd-break.h: Rename include guard.
4527         * m2-lang.h: Add include guard.
4528         * location.h: Rename include guard.
4529         * linux-record.h: Rename include guard.
4530         * linux-nat.h: Add include guard.
4531         * linux-fork.h: Add include guard.
4532         * i386-darwin-tdep.h: Rename include guard.
4533         * hppa-linux-offsets.h: Add include guard.
4534         * guile/guile.h: Rename include guard.
4535         * guile/guile-internal.h: Rename include guard.
4536         * gnu-nat.h: Rename include guard.
4537         * gdb-stabs.h: Rename include guard.
4538         * frv-tdep.h: Add include guard.
4539         * f-lang.h: Add include guard.
4540         * event-loop.h: Add include guard.
4541         * darwin-nat.h: Rename include guard.
4542         * cp-abi.h: Rename include guard.
4543         * config/sparc/nm-sol2.h: Rename include guard.
4544         * config/nm-nto.h: Rename include guard.
4545         * config/nm-linux.h: Add include guard.
4546         * config/i386/nm-i386gnu.h: Rename include guard.
4547         * config/djgpp/nl_types.h: Rename include guard.
4548         * config/djgpp/langinfo.h: Rename include guard.
4549         * compile/gcc-cp-plugin.h: Add include guard.
4550         * compile/gcc-c-plugin.h: Add include guard.
4551         * compile/compile.h: Rename include guard.
4552         * compile/compile-object-run.h: Rename include guard.
4553         * compile/compile-object-load.h: Rename include guard.
4554         * compile/compile-internal.h: Rename include guard.
4555         * compile/compile-cplus.h: Rename include guard.
4556         * compile/compile-c.h: Rename include guard.
4557         * common/xml-utils.h: Rename include guard.
4558         * common/x86-xstate.h: Rename include guard.
4559         * common/version.h: Rename include guard.
4560         * common/vec.h: Rename include guard.
4561         * common/tdesc.h: Rename include guard.
4562         * common/selftest.h: Rename include guard.
4563         * common/scoped_restore.h: Rename include guard.
4564         * common/scoped_mmap.h: Rename include guard.
4565         * common/scoped_fd.h: Rename include guard.
4566         * common/safe-iterator.h: Rename include guard.
4567         * common/run-time-clock.h: Rename include guard.
4568         * common/refcounted-object.h: Rename include guard.
4569         * common/queue.h: Rename include guard.
4570         * common/ptid.h: Rename include guard.
4571         * common/print-utils.h: Rename include guard.
4572         * common/preprocessor.h: Rename include guard.
4573         * common/pathstuff.h: Rename include guard.
4574         * common/observable.h: Rename include guard.
4575         * common/netstuff.h: Rename include guard.
4576         * common/job-control.h: Rename include guard.
4577         * common/host-defs.h: Rename include guard.
4578         * common/gdb_wait.h: Rename include guard.
4579         * common/gdb_vecs.h: Rename include guard.
4580         * common/gdb_unlinker.h: Rename include guard.
4581         * common/gdb_unique_ptr.h: Rename include guard.
4582         * common/gdb_tilde_expand.h: Rename include guard.
4583         * common/gdb_sys_time.h: Rename include guard.
4584         * common/gdb_string_view.h: Rename include guard.
4585         * common/gdb_splay_tree.h: Rename include guard.
4586         * common/gdb_setjmp.h: Rename include guard.
4587         * common/gdb_ref_ptr.h: Rename include guard.
4588         * common/gdb_optional.h: Rename include guard.
4589         * common/gdb_locale.h: Rename include guard.
4590         * common/gdb_assert.h: Rename include guard.
4591         * common/filtered-iterator.h: Rename include guard.
4592         * common/filestuff.h: Rename include guard.
4593         * common/fileio.h: Rename include guard.
4594         * common/environ.h: Rename include guard.
4595         * common/common-utils.h: Rename include guard.
4596         * common/common-types.h: Rename include guard.
4597         * common/common-regcache.h: Rename include guard.
4598         * common/common-inferior.h: Rename include guard.
4599         * common/common-gdbthread.h: Rename include guard.
4600         * common/common-exceptions.h: Rename include guard.
4601         * common/common-defs.h: Rename include guard.
4602         * common/common-debug.h: Rename include guard.
4603         * common/cleanups.h: Rename include guard.
4604         * common/buffer.h: Rename include guard.
4605         * common/btrace-common.h: Rename include guard.
4606         * common/break-common.h: Rename include guard.
4607         * cli/cli-utils.h: Rename include guard.
4608         * cli/cli-style.h: Rename include guard.
4609         * cli/cli-setshow.h: Rename include guard.
4610         * cli/cli-script.h: Rename include guard.
4611         * cli/cli-interp.h: Rename include guard.
4612         * cli/cli-decode.h: Rename include guard.
4613         * cli/cli-cmds.h: Rename include guard.
4614         * charset-list.h: Add include guard.
4615         * buildsym-legacy.h: Rename include guard.
4616         * bfin-tdep.h: Add include guard.
4617         * ax.h: Rename include guard.
4618         * arm-linux-tdep.h: Add include guard.
4619         * arm-fbsd-tdep.h: Add include guard.
4620         * arch/xtensa.h: Rename include guard.
4621         * arch/tic6x.h: Add include guard.
4622         * arch/i386.h: Add include guard.
4623         * arch/arm.h: Rename include guard.
4624         * arch/arm-linux.h: Rename include guard.
4625         * arch/arm-get-next-pcs.h: Rename include guard.
4626         * arch/amd64.h: Add include guard.
4627         * arch/aarch64-insn.h: Rename include guard.
4628         * arch-utils.h: Rename include guard.
4629         * annotate.h: Add include guard.
4630         * amd64-darwin-tdep.h: Rename include guard.
4631         * aarch64-linux-tdep.h: Add include guard.
4632         * aarch64-fbsd-tdep.h: Add include guard.
4633         * aarch32-linux-nat.h: Add include guard.
4634
4635 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4636
4637         * macrotab.c (macro_define_internal): New function that
4638         factorizes macro_define_object_internal and macro_define_function
4639         code.
4640         (macro_define_object_internal): Use macro_define_internal.
4641         (macro_define_function): Likewise.
4642
4643 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4644
4645         * macrocmd.c (extract_identifier): Return
4646         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4647         callers.
4648
4649 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4650
4651         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4652
4653 2019-02-05  Tom Tromey  <tom@tromey.com>
4654
4655         * target.c (target_stack::unpush): Move assertion earlier.
4656
4657 2019-01-30  Tom Tromey  <tom@tromey.com>
4658
4659         PR python/23615:
4660         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4661         (gdbpy_parse_and_eval): Likewise.
4662         * python/python-internal.h (gdbpy_allow_threads): New class.
4663
4664 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4665
4666         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4667         (aarch64_fbsd_fpregmap): Move earlier.
4668         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4669         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4670         instead of individual calls to trad_frame_set_reg_addr.
4671         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4672         earlier.
4673         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4674         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4675         instead of individual calls to trad_frame_set_reg_addr.
4676
4677 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4678
4679         * CONTRIBUTE: Replace contribution list with wiki link.
4680
4681 2019-01-25  Tom Tromey  <tom@tromey.com>
4682
4683         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4684
4685 2019-01-25  Tom Tromey  <tom@tromey.com>
4686
4687         * xtensa-linux-nat.c: Fix common/ includes.
4688         * xml-support.h: Fix common/ includes.
4689         * xml-support.c: Fix common/ includes.
4690         * x86-linux-nat.c: Fix common/ includes.
4691         * windows-nat.c: Fix common/ includes.
4692         * varobj.h: Fix common/ includes.
4693         * varobj.c: Fix common/ includes.
4694         * value.c: Fix common/ includes.
4695         * valops.c: Fix common/ includes.
4696         * utils.c: Fix common/ includes.
4697         * unittests/xml-utils-selftests.c: Fix common/ includes.
4698         * unittests/utils-selftests.c: Fix common/ includes.
4699         * unittests/unpack-selftests.c: Fix common/ includes.
4700         * unittests/tracepoint-selftests.c: Fix common/ includes.
4701         * unittests/style-selftests.c: Fix common/ includes.
4702         * unittests/string_view-selftests.c: Fix common/ includes.
4703         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4704         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4705         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4706         * unittests/rsp-low-selftests.c: Fix common/ includes.
4707         * unittests/parse-connection-spec-selftests.c: Fix common/
4708         includes.
4709         * unittests/optional-selftests.c: Fix common/ includes.
4710         * unittests/offset-type-selftests.c: Fix common/ includes.
4711         * unittests/observable-selftests.c: Fix common/ includes.
4712         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4713         * unittests/memrange-selftests.c: Fix common/ includes.
4714         * unittests/memory-map-selftests.c: Fix common/ includes.
4715         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4716         * unittests/function-view-selftests.c: Fix common/ includes.
4717         * unittests/environ-selftests.c: Fix common/ includes.
4718         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4719         * unittests/common-utils-selftests.c: Fix common/ includes.
4720         * unittests/cli-utils-selftests.c: Fix common/ includes.
4721         * unittests/array-view-selftests.c: Fix common/ includes.
4722         * ui-file.c: Fix common/ includes.
4723         * tui/tui-io.c: Fix common/ includes.
4724         * tracepoint.h: Fix common/ includes.
4725         * tracepoint.c: Fix common/ includes.
4726         * tracefile-tfile.c: Fix common/ includes.
4727         * top.h: Fix common/ includes.
4728         * top.c: Fix common/ includes.
4729         * thread.c: Fix common/ includes.
4730         * target/waitstatus.h: Fix common/ includes.
4731         * target/waitstatus.c: Fix common/ includes.
4732         * target.h: Fix common/ includes.
4733         * target.c: Fix common/ includes.
4734         * target-memory.c: Fix common/ includes.
4735         * target-descriptions.c: Fix common/ includes.
4736         * symtab.h: Fix common/ includes.
4737         * symfile.c: Fix common/ includes.
4738         * stap-probe.c: Fix common/ includes.
4739         * spu-linux-nat.c: Fix common/ includes.
4740         * sparc-nat.c: Fix common/ includes.
4741         * source.c: Fix common/ includes.
4742         * solib.c: Fix common/ includes.
4743         * solib-target.c: Fix common/ includes.
4744         * ser-unix.c: Fix common/ includes.
4745         * ser-tcp.c: Fix common/ includes.
4746         * ser-pipe.c: Fix common/ includes.
4747         * ser-base.c: Fix common/ includes.
4748         * selftest-arch.c: Fix common/ includes.
4749         * s12z-tdep.c: Fix common/ includes.
4750         * rust-exp.y: Fix common/ includes.
4751         * rs6000-aix-tdep.c: Fix common/ includes.
4752         * riscv-tdep.c: Fix common/ includes.
4753         * remote.c: Fix common/ includes.
4754         * remote-notif.h: Fix common/ includes.
4755         * remote-fileio.h: Fix common/ includes.
4756         * remote-fileio.c: Fix common/ includes.
4757         * regcache.h: Fix common/ includes.
4758         * regcache.c: Fix common/ includes.
4759         * record-btrace.c: Fix common/ includes.
4760         * python/python.c: Fix common/ includes.
4761         * python/py-type.c: Fix common/ includes.
4762         * python/py-inferior.c: Fix common/ includes.
4763         * progspace.h: Fix common/ includes.
4764         * producer.c: Fix common/ includes.
4765         * procfs.c: Fix common/ includes.
4766         * proc-api.c: Fix common/ includes.
4767         * printcmd.c: Fix common/ includes.
4768         * ppc-linux-nat.c: Fix common/ includes.
4769         * parser-defs.h: Fix common/ includes.
4770         * osdata.c: Fix common/ includes.
4771         * obsd-nat.c: Fix common/ includes.
4772         * nat/x86-linux.c: Fix common/ includes.
4773         * nat/x86-linux-dregs.c: Fix common/ includes.
4774         * nat/x86-dregs.h: Fix common/ includes.
4775         * nat/x86-dregs.c: Fix common/ includes.
4776         * nat/ppc-linux.c: Fix common/ includes.
4777         * nat/mips-linux-watch.h: Fix common/ includes.
4778         * nat/mips-linux-watch.c: Fix common/ includes.
4779         * nat/linux-waitpid.c: Fix common/ includes.
4780         * nat/linux-ptrace.h: Fix common/ includes.
4781         * nat/linux-ptrace.c: Fix common/ includes.
4782         * nat/linux-procfs.c: Fix common/ includes.
4783         * nat/linux-personality.c: Fix common/ includes.
4784         * nat/linux-osdata.c: Fix common/ includes.
4785         * nat/linux-namespaces.c: Fix common/ includes.
4786         * nat/linux-btrace.h: Fix common/ includes.
4787         * nat/linux-btrace.c: Fix common/ includes.
4788         * nat/fork-inferior.c: Fix common/ includes.
4789         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4790         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4791         * nat/aarch64-linux.c: Fix common/ includes.
4792         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4793         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4794         * namespace.h: Fix common/ includes.
4795         * mips-linux-tdep.c: Fix common/ includes.
4796         * minsyms.c: Fix common/ includes.
4797         * mi/mi-parse.h: Fix common/ includes.
4798         * mi/mi-main.c: Fix common/ includes.
4799         * mi/mi-cmd-env.c: Fix common/ includes.
4800         * memrange.h: Fix common/ includes.
4801         * memattr.c: Fix common/ includes.
4802         * maint.h: Fix common/ includes.
4803         * maint.c: Fix common/ includes.
4804         * main.c: Fix common/ includes.
4805         * machoread.c: Fix common/ includes.
4806         * location.c: Fix common/ includes.
4807         * linux-thread-db.c: Fix common/ includes.
4808         * linux-nat.c: Fix common/ includes.
4809         * linux-fork.c: Fix common/ includes.
4810         * inline-frame.c: Fix common/ includes.
4811         * infrun.c: Fix common/ includes.
4812         * inflow.c: Fix common/ includes.
4813         * inferior.h: Fix common/ includes.
4814         * inferior.c: Fix common/ includes.
4815         * infcmd.c: Fix common/ includes.
4816         * inf-ptrace.c: Fix common/ includes.
4817         * inf-child.c: Fix common/ includes.
4818         * ia64-linux-nat.c: Fix common/ includes.
4819         * i387-tdep.c: Fix common/ includes.
4820         * i386-tdep.c: Fix common/ includes.
4821         * i386-linux-tdep.c: Fix common/ includes.
4822         * i386-linux-nat.c: Fix common/ includes.
4823         * i386-go32-tdep.c: Fix common/ includes.
4824         * i386-fbsd-tdep.c: Fix common/ includes.
4825         * i386-fbsd-nat.c: Fix common/ includes.
4826         * guile/scm-type.c: Fix common/ includes.
4827         * guile/guile.c: Fix common/ includes.
4828         * go32-nat.c: Fix common/ includes.
4829         * gnu-nat.c: Fix common/ includes.
4830         * gdbthread.h: Fix common/ includes.
4831         * gdbarch-selftests.c: Fix common/ includes.
4832         * gdb_usleep.c: Fix common/ includes.
4833         * gdb_select.h: Fix common/ includes.
4834         * gdb_bfd.c: Fix common/ includes.
4835         * gcore.c: Fix common/ includes.
4836         * fork-child.c: Fix common/ includes.
4837         * findvar.c: Fix common/ includes.
4838         * fbsd-nat.c: Fix common/ includes.
4839         * event-top.c: Fix common/ includes.
4840         * event-loop.c: Fix common/ includes.
4841         * dwarf2read.c: Fix common/ includes.
4842         * dwarf2loc.c: Fix common/ includes.
4843         * dwarf2-frame.c: Fix common/ includes.
4844         * dwarf-index-cache.c: Fix common/ includes.
4845         * dtrace-probe.c: Fix common/ includes.
4846         * disasm-selftests.c: Fix common/ includes.
4847         * defs.h: Fix common/ includes.
4848         * csky-tdep.c: Fix common/ includes.
4849         * cp-valprint.c: Fix common/ includes.
4850         * cp-support.h: Fix common/ includes.
4851         * cp-support.c: Fix common/ includes.
4852         * corelow.c: Fix common/ includes.
4853         * completer.h: Fix common/ includes.
4854         * completer.c: Fix common/ includes.
4855         * compile/compile.c: Fix common/ includes.
4856         * compile/compile-loc2c.c: Fix common/ includes.
4857         * compile/compile-cplus-types.c: Fix common/ includes.
4858         * compile/compile-cplus-symbols.c: Fix common/ includes.
4859         * command.h: Fix common/ includes.
4860         * cli/cli-dump.c: Fix common/ includes.
4861         * cli/cli-cmds.c: Fix common/ includes.
4862         * charset.c: Fix common/ includes.
4863         * build-id.c: Fix common/ includes.
4864         * btrace.h: Fix common/ includes.
4865         * btrace.c: Fix common/ includes.
4866         * breakpoint.h: Fix common/ includes.
4867         * breakpoint.c: Fix common/ includes.
4868         * ax.h:
4869         (enum agent_op): Fix common/ includes.
4870         * ax-general.c (struct aop_map): Fix common/ includes.
4871         * ax-gdb.c: Fix common/ includes.
4872         * auxv.c: Fix common/ includes.
4873         * auto-load.c: Fix common/ includes.
4874         * arm-tdep.c: Fix common/ includes.
4875         * arch/riscv.c: Fix common/ includes.
4876         * arch/ppc-linux-common.c: Fix common/ includes.
4877         * arch/i386.c: Fix common/ includes.
4878         * arch/arm.c: Fix common/ includes.
4879         * arch/arm-linux.c: Fix common/ includes.
4880         * arch/arm-get-next-pcs.c: Fix common/ includes.
4881         * arch/amd64.c: Fix common/ includes.
4882         * arch/aarch64.c: Fix common/ includes.
4883         * arch/aarch64-insn.c: Fix common/ includes.
4884         * arch-utils.c: Fix common/ includes.
4885         * amd64-windows-tdep.c: Fix common/ includes.
4886         * amd64-tdep.c: Fix common/ includes.
4887         * amd64-sol2-tdep.c: Fix common/ includes.
4888         * amd64-obsd-tdep.c: Fix common/ includes.
4889         * amd64-nbsd-tdep.c: Fix common/ includes.
4890         * amd64-linux-tdep.c: Fix common/ includes.
4891         * amd64-linux-nat.c: Fix common/ includes.
4892         * amd64-fbsd-tdep.c: Fix common/ includes.
4893         * amd64-fbsd-nat.c: Fix common/ includes.
4894         * amd64-dicos-tdep.c: Fix common/ includes.
4895         * amd64-darwin-tdep.c: Fix common/ includes.
4896         * agent.c: Fix common/ includes.
4897         * ada-lang.h: Fix common/ includes.
4898         * ada-lang.c: Fix common/ includes.
4899         * aarch64-tdep.c: Fix common/ includes.
4900
4901 2019-01-25  Tom Tromey  <tom@tromey.com>
4902
4903         * common/create-version.sh: Use common/version.h.
4904
4905 2019-01-24  Pedro Alves  <palves@redhat.com>
4906
4907         * infrun.c (signal_stop, signal_print, signal_program)
4908         (signal_catch, signal_pass): Now arrays instead of pointers.
4909         (update_signals_program_target, do_target_resume)
4910         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4911         * linux-nat.c (linux_nat_target::pass_signals)
4912         (linux_nat_target::create_inferior, linux_nat_target::attach):
4913         Adjust.
4914         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4915         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4916         * procfs.c (procfs_target::pass_signals): Adjust.
4917         * record-full.c (record_full_target::resume): Adjust.
4918         * remote.c (remote_target::pass_signals)
4919         (remote_target::program_signals): Adjust.
4920         * target-debug.h (target_debug_print_signals): Now takes a
4921         gdb::array_view as parameter.  Adjust.
4922         * target.h (target_ops) <pass_signals, program_signals>: Replace
4923         pointer and length parameters with gdb::array_view.
4924         (target_pass_signals, target_program_signals): Likewise.
4925         * target-delegates.c: Regenerate.
4926
4927 2019-01-24  Pedro Alves  <palves@redhat.com>
4928
4929         * common/forward-scope-exit.h
4930         (forward_scope_exit::forward_scope_exit): Pass arguments to
4931         m_bind_function directly, instead of creating a std::bind and
4932         copying that.
4933
4934 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4935
4936         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4937         for static members.
4938         (pass_in_v_vfp_candidate): Likewise.
4939
4940 2019-01-23  Tom Tromey  <tom@tromey.com>
4941             Pedro Alves  <palves@redhat.com>
4942
4943         * regcache.c (class regcache_invalidator): Remove.
4944         (regcache::raw_write): Use make_scope_exit.
4945
4946 2019-01-23  Tom Tromey  <tom@tromey.com>
4947
4948         * ui-out.h (class ui_out_emit_type): Update comment.
4949
4950 2019-01-23  Tom Tromey  <tom@tromey.com>
4951
4952         * infrun.c (fetch_inferior_event): Update comment.
4953
4954 2019-01-23  Tom Tromey  <tom@tromey.com>
4955             Pedro Alves  <palves@redhat.com>
4956
4957         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4958         parameter.
4959         (fetch_inferior_event): Use SCOPE_EXIT.
4960
4961
4962 2019-01-23  Tom Tromey  <tom@tromey.com>
4963             Pedro Alves  <palves@redhat.com>
4964
4965         * infrun.c (disable_thread_events): Delete.
4966         (stop_all_threads): Use SCOPE_EXIT.
4967
4968 2019-01-23  Tom Tromey  <tom@tromey.com>
4969             Pedro Alves  <palves@redhat.com>
4970
4971         * symfile.c: Include forward-scope-exit.h.
4972         (clear_symtab_users_cleanup): Replace forward declaration with
4973         a FORWARD_SCOPE_EXIT.
4974         (syms_from_objfile_1): Use the forward_scope_exit and
4975         gdb::optional instead of cleanup_function.
4976         (reread_symbols): Use the forward_scope_exit instead of
4977         cleanup_function.
4978         (clear_symtab_users_cleanup): Remove function.
4979
4980 2019-01-23  Tom Tromey  <tom@tromey.com>
4981             Pedro Alves  <palves@redhat.com>
4982
4983         * linux-nat.c: Include scope-exit.h.
4984         (cleanup_target_stop): Remove.
4985         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4986         SCOPE_EXIT.
4987
4988 2019-01-23  Tom Tromey  <tom@tromey.com>
4989             Pedro Alves  <palves@redhat.com>
4990
4991         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4992         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4993
4994 2019-01-23  Tom Tromey  <tom@tromey.com>
4995             Andrew Burgess  <andrew.burgess@embecosm.com>
4996             Pedro Alves  <palves@redhat.com>
4997
4998         * infrun.c (fetch_inferior_event): Use scope_exit.
4999         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5000         * top.c (execute_command): Use scope_exit.
5001         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5002         * utils.c (do_bpstat_clear_actions_cleanup)
5003         (make_bpstat_clear_actions_cleanup): Remove.
5004
5005 2019-01-23  Tom Tromey  <tom@tromey.com>
5006             Pedro Alves  <palves@redhat.com>
5007
5008         * infrun.c: Include "common/scope-exit.h"
5009         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5010         (wait_for_inferior): Use SCOPE_EXIT.
5011         (fetch_inferior_event): Use scope_exit.
5012
5013 2019-01-23  Tom Tromey  <tom@tromey.com>
5014             Pedro Alves  <palves@redhat.com>
5015
5016         * breakpoint.c (create_breakpoint): Remove cleanup.
5017
5018 2019-01-23  Tom Tromey  <tom@tromey.com>
5019             Andrew Burgess  <andrew.burgess@embecosm.com>
5020             Pedro Alves  <palves@redhat.com>
5021
5022 2019-01-23  Pedro Alves  <palves@redhat.com>
5023
5024         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5025
5026 2019-01-23  Pedro Alves  <palves@redhat.com>
5027             Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * gdbthread.h: Include "common/forward-scope-exit.h".
5030         (scoped_finish_thread_state): Redefine custom class in terms of
5031         forward_scope_exit.
5032
5033 2019-01-23  Pedro Alves  <palves@redhat.com>
5034             Andrew Burgess  <andrew.burgess@embecosm.com>
5035
5036         * common/forward-scope-exit.h: New file.
5037
5038 2019-01-23  Pedro Alves  <palves@redhat.com>
5039             Andrew Burgess  <andrew.burgess@embecosm.com>
5040             Tom Tromey  <tom@tromey.com>
5041
5042         * common/scope-exit.h: New file.
5043
5044 2019-01-23  Pedro Alves  <palves@redhat.com>
5045
5046         * common/preprocessor.h (ESC): Rename to ...
5047         (ESC_PARENS): ... this.
5048         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5049         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5050
5051 2019-01-23  Tom Tromey  <tom@tromey.com>
5052
5053         * language.h (class scoped_switch_to_sym_language_if_auto):
5054         Initialize m_lang in both cases.
5055
5056 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5057
5058         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5059         with XCNEW.
5060
5061 2019-01-22  Tom Tromey  <tom@tromey.com>
5062
5063         * corelow.c: Do not include sys/file.h.
5064
5065 2019-01-22  Tom Tromey  <tom@tromey.com>
5066
5067         * tui/tui-wingeneral.h: Include gdb_curses.h.
5068
5069 2019-01-22  Tom Tromey  <tom@tromey.com>
5070
5071         * source-cache.h (class source_cache) <get_source_lines,
5072         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5073
5074 2019-01-22  Tom Tromey  <tom@tromey.com>
5075
5076         * remote-fileio.h (struct remote_target): Declare.
5077
5078 2019-01-22  Tom Tromey  <tom@tromey.com>
5079
5080         * python/py-arch.c: Do not include py-ref.h.
5081         * python/py-bpevent.c: Do not include py-ref.h.
5082         * python/py-cmd.c: Do not include py-ref.h.
5083         * python/py-continueevent.c: Do not include py-ref.h.
5084         * python/py-event.h: Do not include py-ref.h.
5085         * python/py-evtregistry.c: Do not include py-ref.h.
5086         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5087         * python/py-frame.c: Do not include py-ref.h.
5088         * python/py-framefilter.c: Do not include py-ref.h.
5089         * python/py-function.c: Do not include py-ref.h.
5090         * python/py-infevents.c: Do not include py-ref.h.
5091         * python/py-linetable.c: Do not include py-ref.h.
5092         * python/py-objfile.c: Do not include py-ref.h.
5093         * python/py-param.c: Do not include py-ref.h.
5094         * python/py-prettyprint.c: Do not include py-ref.h.
5095         * python/py-progspace.c: Do not include py-ref.h.
5096         * python/py-symbol.c: Do not include py-ref.h.
5097         * python/py-symtab.c: Do not include py-ref.h.
5098         * python/py-type.c: Do not include py-ref.h.
5099         * python/py-unwind.c: Do not include py-ref.h.
5100         * python/py-utils.c: Do not include py-ref.h.
5101         * python/py-value.c: Do not include py-ref.h.
5102         * python/py-varobj.c: Do not include py-ref.h.
5103         * python/py-xmethods.c: Do not include py-ref.h.
5104         * python/python.c: Do not include py-ref.h.
5105         * varobj.c: Do not include py-ref.h.
5106
5107 2019-01-22  Tom Tromey  <tom@tromey.com>
5108
5109         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5110         keyword for bcache.
5111
5112 2019-01-22  Tom Tromey  <tom@tromey.com>
5113
5114         * compile/compile-cplus-types.c: Remove a comment by #include.
5115
5116 2019-01-22  Tom Tromey  <tom@tromey.com>
5117
5118         * compile/gcc-c-plugin.h: Include compile-internal.h.
5119
5120 2019-01-22  Tom Tromey  <tom@tromey.com>
5121
5122         * stabsread.c (EXTERN): Do not define.
5123         (symnum, next_symbol_text_func, processing_gcc_compilation)
5124         (within_function, global_sym_chain, global_stabs)
5125         (previous_stab_code, this_object_header_files)
5126         (n_this_object_header_files)
5127         (n_allocated_this_object_header_files): Define.
5128         * stabsread.h (EXTERN): Never define.  Use "extern".
5129
5130 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5131
5132         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5133         history_value.
5134
5135 2019-01-21  Tom Tromey  <tom@tromey.com>
5136
5137         * ui-out.c: Fix includes.
5138         * tui/tui-source.c: Fix includes.
5139         * target.c: Fix includes.
5140         * remote.c: Fix includes.
5141         * regcache.c: Fix includes.
5142         * python/py-block.c: Fix includes.
5143         * printcmd.c: Fix includes.
5144         * or1k-tdep.c: Fix includes.
5145         * mi/mi-main.c: Fix includes.
5146         * m32r-tdep.c: Fix includes.
5147         * csky-tdep.c: Fix includes.
5148         * compile/compile-cplus-types.c: Fix includes.
5149         * cli/cli-interp.c: Fix includes.
5150
5151 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5152
5153         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5154         for padding.
5155
5156 2019-01-16  Tom Tromey  <tom@tromey.com>
5157
5158         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5159         earlier.
5160         (struct objfile) <msymbols_range>: Move from top level.
5161         <msymbols>: New method.
5162         (class objfile_msymbols): Remove.
5163         * symtab.c (default_collect_symbol_completion_matches_break_on):
5164         Update.
5165         * symmisc.c (dump_msymbols): Update.
5166         * stabsread.c (scan_file_globals): Update.
5167         * objc-lang.c (info_selectors_command, info_classes_command)
5168         (find_methods): Update.
5169         * minsyms.c (find_solib_trampoline_target): Update.
5170         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5171         * coffread.c (coff_symfile_read): Update.
5172         * ada-lang.c (ada_lookup_simple_minsym)
5173         (ada_collect_symbol_completion_matches): Update.
5174
5175 2019-01-16  Tom Tromey  <tom@tromey.com>
5176
5177         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5178         type.  Remove no-argument constructor.
5179         <iterator::operator++>: Simplify.
5180         <begin>: Update.
5181         <end>: Use minimal_symbol_count.
5182
5183 2019-01-16  Tom Tromey  <tom@tromey.com>
5184
5185         * objfiles.h (struct objfile) <psymtabs>: New method.
5186         (class objfile_psymtabs): Remove.
5187         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5188         typedef.
5189         <range>: New method.
5190         (require_partial_symbols): Change return type.
5191         * psymtab.c (require_partial_symbols)
5192         (psym_expand_symtabs_matching): Update.
5193         * mdebugread.c (parse_partial_symbols): Update.
5194         * dbxread.c (dbx_end_psymtab): Update.
5195
5196 2019-01-15  Tom Tromey  <tom@tromey.com>
5197
5198         * symtab.c (lookup_objfile_from_block)
5199         (lookup_symbol_in_objfile_symtabs)
5200         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5201         (find_line_symtab, info_sources_command)
5202         (default_collect_symbol_completion_matches_break_on)
5203         (make_source_files_completion_list): Update.
5204         * symmisc.c (print_objfile_statistics, dump_objfile)
5205         (maintenance_print_symbols, maintenance_info_symtabs)
5206         (maintenance_check_symtabs, maintenance_info_line_tables):
5207         Update.
5208         * source.c (select_source_symtab)
5209         (forget_cached_source_info_for_objfile): Update.
5210         * objfiles.h (class objfile_compunits): Remove.
5211         (struct objfile) <compunits_range>: New typedef.
5212         (compunits): New method.
5213         * objfiles.c (objfile_relocate1): Update.
5214         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5215         * maint.c (count_symtabs_and_blocks): Update.
5216         * linespec.c (iterate_over_all_matching_symtabs): Update.
5217         * cp-support.c (add_symbol_overload_list_qualified): Update.
5218         * coffread.c (coff_symtab_read): Update.
5219         * ada-lang.c (add_nonlocal_symbols)
5220         (ada_collect_symbol_completion_matches)
5221         (ada_add_global_exceptions): Update.
5222
5223 2019-01-15  Tom Tromey  <tom@tromey.com>
5224
5225         * progspace.h (program_space) <objfiles_safe_range>: New
5226         typedef.
5227         <objfiles_safe>: New method.
5228         * objfiles.h (class all_objfiles_safe): Remove.
5229         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5230         * jit.c (jit_inferior_exit_hook): Update.
5231
5232 2019-01-17  Tom Tromey  <tom@tromey.com>
5233
5234         * progspace.h (program_space) <objfiles_range>: New typedef.
5235         <objfiles>: New method.
5236         <objfiles_head>: Rename from objfiles.
5237         (object_files): Update.
5238         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5239         * guile/scm-pretty-print.c
5240         (ppscm_find_pretty_printer_from_objfiles): Update.
5241         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5242         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5243         Update.
5244         * python/py-progspace.c (pspy_get_objfiles): Update.
5245         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5246         Update.
5247         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5248         (objfpy_lookup_objfile_by_build_id): Update.
5249         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5250         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5251         Update.
5252         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5253         (expand_symtab_containing_pc, lookup_objfile_from_block)
5254         (lookup_static_symbol, basic_lookup_transparent_type)
5255         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5256         (find_line_symtab, info_sources_command)
5257         (default_collect_symbol_completion_matches_break_on)
5258         (make_source_files_completion_list, find_main_name): Update.
5259         * symmisc.c (print_symbol_bcache_statistics)
5260         (print_objfile_statistics, maintenance_print_symbols)
5261         (maintenance_print_msymbols, maintenance_print_objfiles)
5262         (maintenance_info_symtabs, maintenance_check_symtabs)
5263         (maintenance_expand_symtabs, maintenance_info_line_tables):
5264         Update.
5265         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5266         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5267         (map_overlay_command, unmap_overlay_command)
5268         (simple_overlay_update, expand_symtabs_matching)
5269         (map_symbol_filenames): Update.
5270         * symfile-debug.c (set_debug_symfile): Update.
5271         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5272         Update.
5273         * source.c (select_source_symtab, forget_cached_source_info):
5274         Update.
5275         * solib.c (solib_read_symbols): Update.
5276         * solib-spu.c (append_ocl_sos): Update.
5277         * psymtab.c (maintenance_print_psymbols)
5278         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5279         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5280         * printcmd.c (info_symbol_command): Update.
5281         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5282         Update.
5283         * objfiles.h (class all_objfiles): Remove.
5284         * objfiles.c (have_partial_symbols, have_full_symbols)
5285         (have_minimal_symbols, qsort_cmp, update_section_map)
5286         (shared_objfile_contains_address_p)
5287         (default_iterate_over_objfiles_in_search_order): Update.
5288         * objc-lang.c (info_selectors_command, info_classes_command)
5289         (find_methods): Update.
5290         * minsyms.c (find_solib_trampoline_target): Update.
5291         * maint.c (maintenance_info_sections)
5292         (maintenance_translate_address, count_symtabs_and_blocks):
5293         Update.
5294         * main.c (captured_main_1): Update.
5295         * linux-thread-db.c (try_thread_db_load_from_pdir)
5296         (has_libpthread): Update.
5297         * linespec.c (iterate_over_all_matching_symtabs)
5298         (search_minsyms_for_name): Update.
5299         * jit.c (jit_find_objf_with_entry_addr): Update.
5300         * hppa-tdep.c (find_unwind_entry)
5301         (hppa_lookup_stub_minimal_symbol): Update.
5302         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5303         Update.
5304         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5305         (elf_gnu_ifunc_resolve_by_got): Update.
5306         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5307         * dwarf-index-write.c (save_gdb_index_command): Update.
5308         * cp-support.c (add_symbol_overload_list_qualified): Update.
5309         * breakpoint.c (create_overlay_event_breakpoint)
5310         (create_longjmp_master_breakpoint)
5311         (create_std_terminate_master_breakpoint)
5312         (create_exception_master_breakpoint): Update.
5313         * blockframe.c (find_pc_partial_function): Update.
5314         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5315         (ada_collect_symbol_completion_matches)
5316         (ada_add_global_exceptions): Update.
5317
5318 2019-01-17  Tom Tromey  <tom@tromey.com>
5319
5320         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5321         declare VEC.
5322         (solib_target_parse_libraries): Change return type.
5323         (library_list_start_segment, library_list_start_section)
5324         (library_list_end_library, library_list_start_library); Update.
5325         (solib_target_free_library_list): Remove.
5326         (solib_target_parse_libraries): Remove cleanup.  Change return
5327         type.
5328         (solib_target_current_sos): Update.
5329
5330 2019-01-17  Tom Tromey  <tromey@bapiya>
5331
5332         * valprint.c: Replace "the the" with "the".
5333         * symtab.c: Replace "the the" with "the".
5334         * solib.c: Replace "the the" with "the".
5335         * solib-dsbt.c: Replace "the the" with "the".
5336         * linespec.c: Replace "the the" with "the".
5337         * dwarf2loc.h: Replace "the the" with "the".
5338         * amd64-windows-tdep.c: Replace "the the" with "the".
5339         * aarch64-tdep.c: Replace "the the" with "the".
5340
5341 2019-01-16  Keith Seitz  <keiths@redhat.com>
5342
5343         PR gdb/23773
5344         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5345         <builder>: Rename to ..
5346         <m_builder>: ... this and make private.
5347         (dwarf2_cu::get_builder): New method.  Change all users of
5348         `builder' to use this method.
5349         (dwarf2_start_symtab): Move to ...
5350         (dwarf2_cu::start_symtab): ... here.  Update all callers
5351         (setup_type_unit_groups): Move to ...
5352         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5353         callers.
5354         (dwarf2_cu::reset_builder): New method.
5355         (process_full_compunit, process_full_type_unit): Use
5356         dwarf2_cu::reset_builder.
5357         (follow_die_offset): Record the ancestor CU if it is different
5358         from the followed DIE's CU.
5359         (follow_die_sig_1): Likewise.
5360
5361 2019-01-15  Tom Tromey  <tom@tromey.com>
5362
5363         * remote.c (class remote_state) <buf>: Now a char_vector.
5364         <buf_size>: Remove.
5365         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5366         parameter.
5367         (remote_target::getpkt_or_notif_sane_1)
5368         (remote_target::getpkt_sane)
5369         (remote_target::getpkt_or_notif_sane): Likewise.
5370         (class remote_target) <putpkt>: New overload.
5371         (remote_target::read_frame): Change type of "buf_p".  Remove
5372         sizeof_p parameter.
5373         (packet_ok): New overload.
5374         (packet_check_result): New overload.
5375         Update all uses.
5376
5377 2019-01-14  Tom Tromey  <tom@tromey.com>
5378
5379         * remote-notif.c (handle_notification, remote_notif_ack)
5380         (remote_notif_parse): Make "buf" const.
5381         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5382         const.
5383         (remote_notif_parse, remote_notif_ack, handle_notification):
5384         Likewise.
5385         * remote.c (remote_notif_stop_parse): Make "buf" const.
5386         (remote_target::remote_parse_stop_reply): Make "buf" const.
5387         (remote_notif_stop_ack): Make "buf" const.
5388
5389 2019-01-14  Tom Tromey  <tom@tromey.com>
5390
5391         * remote.c (remote_console_output): Make parameter const.
5392
5393 2019-01-14  Tom Tromey  <tom@tromey.com>
5394
5395         * target-debug.h (target_debug_print_signals): Constify.
5396         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5397         * procfs.c (procfs_target::pass_signals): Update.
5398         * linux-nat.c (linux_nat_target::pass_signals): Update.
5399         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5400         * target-delegates.c: Rebuild.
5401         * remote.c (remote_target::program_signals): Update.
5402         (remote_target::pass_signals): Update.
5403         * target.c (target_pass_signals): Constify argument.
5404         (target_program_signals): Likewise.
5405         * target.h (struct target_ops) <pass_signals, program_signals>:
5406         Constify argument.
5407         (target_pass_signals, target_program_signals): Constify argument.
5408
5409 2019-01-14  Tom Tromey  <tom@tromey.com>
5410
5411         PR tui/28819:
5412         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5413
5414 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5415
5416         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5417         field.
5418         * rs6000-tdep.c: Include reggroups.h.
5419         (IS_V_ALIAS_PSEUDOREG): Define.
5420         (rs6000_register_name): Return names for the "vX" aliases.
5421         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5422         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5423         aliases.  Call default_register_reggroup_p for all other
5424         pseudo-registers.
5425         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5426         New functions.
5427         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5428         Handle "vX" aliases.
5429         (v_alias_pseudo_register_collect): New function.
5430         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5431         (rs6000_gdbarch_init): Initialize "vX" aliases as
5432         pseudo-registers.  Restore registration of
5433         rs6000_pseudo_register_reggroup_p with
5434         set_tdesc_pseudo_register_reggroup_p.
5435
5436 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5437
5438         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5439         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5440         set_gdbarch_num_pseudo_regs.
5441
5442 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5443
5444         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5445         Remove arg prefixname, add do_set and do_show.
5446         Add member functions set_list and show_list.
5447         * cli/cli-style.c (class cli_style_option): Update accordingly.
5448         (style_set_list): Move to file scope.
5449         (style_show_list): Likewise.
5450         (set_style): Call help_list.
5451         (show_style): Call cmd_show_list.
5452         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5453         Update to use the new macro.
5454
5455 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5456
5457         * ada-lang.c (_initialize_ada_language): Expand the help text
5458         for the "catch exception" command.
5459
5460 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5461
5462         * symtab.c (matching_obj_sections): Initialize obj,
5463         declare it closer to its usage.
5464
5465 2019-01-10  Tom Tromey  <tom@tromey.com>
5466
5467         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5468         (basic_inf_threads_range): Remove.
5469         (inf_threads_range, inf_non_exited_threads_range)
5470         (safe_inf_threads_range): Use next_adapter.
5471
5472 2019-01-10  Keith Seitz  <keiths@redhat.com>
5473
5474         PR gdb/23712
5475         PR symtab/23010
5476         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5477         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5478
5479 2019-01-10  Keith Seitz  <keiths@redhat.com>
5480
5481         PR gdb/23712
5482         PR symtab/23010
5483         * dictionary.c (pending_to_vector): Remove.
5484         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5485         Remove _1 suffix, replacing functions of the same name.  Update
5486         all callers.
5487         (dict_create_hashed, dict_create_hashed_expandable)
5488         (dict_create_linear, dict_create_linear_expandable, dict_free)
5489         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5490         Make functions static.
5491
5492 2019-01-10  Keith Seitz  <keiths@redhat.com>
5493
5494         PR gdb/23712
5495         PR symtab/23010
5496         * dictionary.h (struct dictionary): Replace declaration with
5497         multidictionary.
5498         (dict_create_hashed, dict_create_hashed_expandable)
5499         (dict_create_linear, dict_create_linear_expandable)
5500         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5501         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5502         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5503         taking multidictionary argument.
5504         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5505         * block.h (struct block) <dict>: Change to multidictionary
5506         and rename `multidict'.
5507         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5508         symmisc.c: Update all dictionary references to multidictionary.
5509
5510 2019-01-10  Keith Seitz  <keiths@redhat.com>
5511
5512         PR gdb/23712
5513         PR symtab/23010
5514         * dictionary.c: Include unordered_map.
5515         (pending_to_vector): New function.
5516         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5517         Rewrite the non-"_1" functions to take vector instead
5518         of linked list.
5519         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5520         "new" _1 versions of the same name.
5521         (multidictionary): Define.
5522         (std::hash<enum language): New definition.
5523         (collate_pending_symbols_by_language, mdict_create_hashed)
5524         (mdict_create_hashed_expandable, mdict_create_linear)
5525         (mdict_create_linear_expandable, mdict_free)
5526         (find_language_dictionary, create_new_language_dictionary)
5527         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5528         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5529         (mdict_size, mdict_empty): New functions.
5530         * dictionary.h (mdict_iterator): Define.
5531
5532 2019-01-10  Pedro Alves  <palves@redhat.com>
5533
5534         * breakpoint.c (read_uploaded_action)
5535         (create_tracepoint_from_upload): Adjust to use
5536         gdb::unique_xmalloc_ptr.
5537         * ctf.c (ctf_write_uploaded_tp):
5538         (SET_ARRAY_FIELD): Use emplace_back.
5539         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5540         * tracefile-tfile.c (tfile_write_uploaded_tp):
5541         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5542         gdb::unique_xmalloc_ptr.
5543         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5544         at_string, cond_string, cmd_strings>: Replace char pointers
5545         with gdb::unique_xmalloc_ptr.
5546
5547 2019-01-10  Pedro Alves  <palves@redhat.com>
5548
5549         * solib-target.c (library_list_start_library): Don't xstrdup name.
5550
5551 2019-01-10  Pedro Alves  <palves@redhat.com>
5552
5553         * mdebugread.c (parse_partial_symbols): Use
5554         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5555
5556 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5557
5558         * linux-fork.c (scoped_switch_fork_info)
5559         <~scoped_switch_fork_info>: Fix incorrect variable name.
5560
5561 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5562
5563         * linux-fork.c (scoped_switch_fork_info)
5564         <scoped_switch_fork_info>: Make explicit.
5565         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5566
5567 2019-01-10  Tom Tromey  <tom@tromey.com>
5568
5569         * objfiles.h (objfile::reset_psymtabs): Update.
5570         * objfiles.c (objfile::objfile): Update.
5571         * psymtab.h (psymtab_storage::obstack): Update.
5572         (psymtab_storage::m_obstack): Use gdb::optional.
5573         (class psymtab_storage): Update comment.  Remove objfile
5574         parameter.
5575         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5576
5577 2019-01-10  Tom Tromey  <tom@tromey.com>
5578
5579         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5580         <free_psymtabs>: Now private.
5581         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5582         (allocate_psymtab): Use new method.
5583
5584 2019-01-10  Tom Tromey  <tom@tromey.com>
5585
5586         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5587         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5588         * mdebugread.c (parse_partial_symbols): Use
5589         allocate_dependencies.
5590         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5591         allocate_dependencies.
5592         (process_psymtab_comp_unit_reader)
5593         (build_type_psymtab_dependencies): Likewise.
5594         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5595
5596 2019-01-10  Tom Tromey  <tom@tromey.com>
5597
5598         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5599         PSYMBOL_SET_LANGUAGE.
5600         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5601
5602 2019-01-10  Tom Tromey  <tom@tromey.com>
5603
5604         * psymtab.h (psymtab_storage::obstack): New method.
5605         <m_obstack>: Rename from obstack; now private.
5606         * psymtab.c (psymtab_storage): Update.
5607         * dwarf2read.c (create_addrmap_from_index)
5608         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5609         Update.
5610
5611 2019-01-10  Tom Tromey  <tom@tromey.com>
5612
5613         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5614         * objfiles.h (objfile::reset_psymtabs): New method.
5615
5616 2019-01-10  Tom Tromey  <tom@tromey.com>
5617
5618         * symmisc.c (print_symbol_bcache_statistics): Update.
5619         (print_objfile_statistics): Update.
5620         * symfile.c (reread_symbols): Update.
5621         * psymtab.h (class psymtab_storage): New.
5622         * psymtab.c (psymtab_storage): New constructor.
5623         (~psymtab_storage): New destructor.
5624         (require_partial_symbols): Update.
5625         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5626         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5627         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5628         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5629         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5630         (start_psymtab_common, end_psymtab_common)
5631         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5632         (allocate_psymtab): Update.
5633         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5634         Update.
5635         (dump_psymtab_addrmap, maintenance_print_psymbols)
5636         (maintenance_check_psymtabs): Update.
5637         (class objfile_psymtabs): Move to objfiles.h.
5638         * psympriv.h (discard_psymtab): Now inline.
5639         (psymtab_discarder::psymtab_discarder): Update.
5640         (psymtab_discarder::~psymtab_discarder): Update.
5641         (ALL_OBJFILE_PSYMTABS): Rewrite.
5642         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5643         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5644         Remove fields.
5645         <partial_symtabs>: New field.
5646         (class objfile_psymtabs): Move from psymtab.h.  Update.
5647         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5648         psymbol_cache.
5649         (objfile::~objfile): Don't destroy psymbol_cache.
5650         * mdebugread.c (parse_partial_symbols): Update.
5651         * dwarf2read.c (create_addrmap_from_index)
5652         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5653         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5654         (add_partial_subprogram, dwarf2_ranges_read): Update.
5655         * dwarf-index-write.c (write_address_map)
5656         (write_one_signatured_type, recursively_write_psymbols)
5657         (class debug_names, class debug_names, write_psymtabs_to_index):
5658         Update.
5659
5660 2019-01-10  Tom Tromey  <tom@tromey.com>
5661
5662         * symtab.h (SYMBOL_SET_NAMES): Update.
5663         (symbol_set_names): Update.
5664         (MSYMBOL_SET_NAMES): Update.
5665         * symtab.c (symbol_set_names): Change argument to be an
5666         objfile_per_bfd_storage.
5667         * psymtab.c (add_psymbol_to_bcache): Update.
5668         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5669
5670 2019-01-10  Tom Tromey  <tom@tromey.com>
5671
5672         * symtab.c (create_demangled_names_hash): Change argument to be an
5673         objfile_per_bfd_storage.
5674         (symbol_set_names): Update.
5675
5676 2019-01-10  Tom Tromey  <tom@tromey.com>
5677
5678         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5679         init_psymbol_list.
5680         * psymtab.c (init_psymbol_list): Do nothing if already called.
5681         * psympriv.h (init_psymbol_list): Add comment.
5682         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5683         init_psymbol_list.
5684         * dbxread.c (dbx_symfile_read): Unconditionally call
5685         init_psymbol_list.
5686
5687 2019-01-10  Tom Tromey  <tom@tromey.com>
5688
5689         * xcoffread.c (scan_xcoff_symtab): Update.
5690         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5691         "where".
5692         * mdebugread.c (parse_partial_symbols)
5693         (handle_psymbol_enumerators): Update.
5694         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5695         * dbxread.c (read_dbx_symtab): Update.
5696         * psympriv.h (psymbol_placement): New enum.
5697         (add_psymbol_to_list): Update.
5698
5699 2019-01-10  Tom Tromey  <tom@tromey.com>
5700
5701         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5702         static_psymbols parameters.
5703         (scan_xcoff_symtab): Update.
5704         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5705         static_psymbols parameters.
5706         * psympriv.h (start_psymtab_common): Update.
5707         * mdebugread.c (parse_partial_symbols): Update.
5708         * dwarf2read.c (create_partial_symtab): Update.
5709         * dbxread.c (read_dbx_symtab): Update.
5710         (start_psymtab): Remove global_psymbols and static_psymbols
5711         parameters.
5712
5713 2019-01-10  Tom Tromey  <tom@tromey.com>
5714
5715         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5716         * psymtab.c (allocate_psymtab): Add comment.
5717         * psympriv.h (allocate_psymtab): Add comment.
5718         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5719         initializations.
5720         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5721
5722 2019-01-10  Tom Tromey  <tom@tromey.com>
5723
5724         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5725         Don't declare.
5726         * mipsread.c: Include mdebugread.h.
5727         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5728         Declare.
5729         * elfread.c: Include mdebugread.h.
5730
5731 2019-01-09  Tom Tromey  <tom@tromey.com>
5732
5733         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5734         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5735         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5736         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5737         (psym_lookup_symbol, psym_find_last_source_symtab)
5738         (psym_forget_cached_source_info, psym_print_stats)
5739         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5740         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5741         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5742         (psym_find_compunit_symtab_by_address)
5743         (maintenance_print_psymbols, maintenance_info_psymtabs)
5744         (maintenance_check_psymtabs): Use ranged for.
5745         * psymtab.h (class objfile_psymtabs): New.
5746         (require_partial_symbols): Return objfile_psymtabs.
5747         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5748
5749 2019-01-09  Tom Tromey  <tom@tromey.com>
5750
5751         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5752         (find_pc_mapped_section, list_overlays_command)
5753         (map_overlay_command, unmap_overlay_command)
5754         (simple_overlay_update): Use all_objfiles.
5755         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5756         * printcmd.c (info_symbol_command): Use all_objfiles.
5757         * objfiles.h (ALL_OBJSECTIONS): Remove.
5758         * maint.c (maintenance_translate_address): Use all_objfiles.
5759         * gcore.c (gcore_create_callback): Use all_objfiles.
5760         (objfile_find_memory_regions): Likewise.
5761
5762 2019-01-09  Tom Tromey  <tom@tromey.com>
5763
5764         * symtab.c (find_line_symtab, info_sources_command)
5765         (make_source_files_completion_list): Use objfile_compunits.
5766         * source.c (select_source_symtab): Use objfile_compunits.
5767         * objfiles.h (struct objfile): Update comment.
5768         (ALL_OBJFILES): Remove.
5769         (ALL_FILETABS): Remove.
5770         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5771         objfile_compunits.
5772
5773 2019-01-09  Tom Tromey  <tom@tromey.com>
5774
5775         * symmisc.c (print_objfile_statistics, dump_objfile)
5776         (maintenance_print_symbols): Use compunit_filetabs.
5777         * source.c (forget_cached_source_info_for_objfile): Use
5778         compunit_filetabs.
5779         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5780         (ALL_FILETABS): Use compunit_filetabs.
5781         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5782         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5783
5784 2019-01-09  Tom Tromey  <tom@tromey.com>
5785
5786         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5787         (compunit_filetabs): New.
5788         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5789         compunit_filetabs.
5790         (info_sources_command, make_source_files_completion_list): Remove
5791         declaration.
5792         * symmisc.c (print_objfile_statistics, dump_objfile)
5793         (maintenance_print_symbols): Remove declaration.
5794         (maintenance_info_symtabs): Use compunit_filetabs.
5795         (maintenance_info_line_tables): Likewise.
5796         * source.c (select_source_symtab): Change local variable name.
5797         (forget_cached_source_info_for_objfile): Remove declaration.
5798         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5799         * objfiles.c (objfile_relocate1): Remove declaration.
5800         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5801         declaration.
5802         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5803         * coffread.c (coff_symtab_read): Remove declaration.
5804         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5805         compunit_filetabs.
5806
5807 2019-01-09  Tom Tromey  <tom@tromey.com>
5808
5809         * symtab.c (lookup_objfile_from_block)
5810         (find_pc_sect_compunit_symtab, search_symbols)
5811         (default_collect_symbol_completion_matches_break_on): Use
5812         objfile_compunits.
5813         * objfiles.h (ALL_COMPUNITS): Remove.
5814         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5815         * cp-support.c (add_symbol_overload_list_qualified): Use
5816         objfile_compunits.
5817         * ada-lang.c (ada_collect_symbol_completion_matches)
5818         (ada_add_global_exceptions): Use objfile_compunits.
5819
5820 2019-01-09  Tom Tromey  <tom@tromey.com>
5821
5822         * source.c (select_source_symtab)
5823         (forget_cached_source_info_for_objfile): Remove declaration.
5824         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5825         declaration.
5826         * maint.c (count_symtabs_and_blocks): Remove declaration.
5827         * cp-support.c (add_symbol_overload_list_qualified): Remove
5828         declaration.
5829         * coffread.c (coff_symtab_read): Remove declaration.
5830         * symtab.c (lookup_symbol_in_objfile_symtabs)
5831         (basic_lookup_transparent_type_1): Use objfile_compunits.
5832         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5833         (info_sources_command, search_symbols)
5834         (default_collect_symbol_completion_matches_break_on)
5835         (make_source_files_completion_list): Remove declaration.
5836         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5837         (ada_collect_symbol_completion_matches)
5838         (ada_add_global_exceptions): Remove declaration.
5839         * linespec.c (iterate_over_all_matching_symtabs): Use
5840         objfile_compunits.
5841         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5842         (class objfile_compunits): New.
5843         (ALL_COMPUNITS): Use objfile_compunits.
5844         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5845         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5846         objfile_compunits.
5847         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5848
5849 2019-01-09  Tom Tromey  <tom@tromey.com>
5850
5851         * symtab.c (search_symbols)
5852         (default_collect_symbol_completion_matches_break_on): Use
5853         objfile_msymbols.
5854         * ada-lang.c (ada_lookup_simple_minsym)
5855         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5856         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5857         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5858         objfile_msymbols.
5859         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5860         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5861         * objc-lang.c (find_methods): Use objfile_msymbols.
5862         (info_selectors_command, info_classes_command): Likewise.
5863         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5864         * objfiles.h (class objfile_msymbols): New.
5865         (ALL_OBJFILE_MSYMBOLS): Remove.
5866         (ALL_MSYMBOLS): Remove.
5867
5868 2019-01-09  Tom Tromey  <tom@tromey.com>
5869
5870         * common/next-iterator.h (next_adapter): Add Iterator template
5871         parameter.
5872         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5873         (class all_objfiles_safe): New.
5874         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5875         * objfiles.c (put_objfile_before): Update comment.
5876         (add_separate_debug_objfile): Likewise.
5877         (free_all_objfiles): Use all_objfiles_safe.
5878         (objfile_purge_solibs): Likewise.
5879
5880 2019-01-09  Tom Tromey  <tom@tromey.com>
5881
5882         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5883         (expand_symtab_containing_pc, lookup_static_symbol)
5884         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5885         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5886         all_objfiles.
5887         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5888         * breakpoint.c (create_overlay_event_breakpoint)
5889         (create_longjmp_master_breakpoint)
5890         (create_std_terminate_master_breakpoint)
5891         (create_exception_master_breakpoint): Use all_objfiles.
5892         * linux-thread-db.c (try_thread_db_load_from_pdir)
5893         (has_libpthread): Use all_objfiles.
5894         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5895         * linespec.c (iterate_over_all_matching_symtabs)
5896         (search_minsyms_for_name): Use all_objfiles.
5897         * maint.c (maintenance_info_sections): Use all_objfiles.
5898         * main.c (captured_main_1): Use all_objfiles.
5899         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5900         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5901         * guile/scm-pretty-print.c
5902         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5903         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5904         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5905         (maintenance_print_msymbols): Use all_objfiles.
5906         * source.c (select_source_symtab): Use all_objfiles.
5907         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5908         * symfile.c (remove_symbol_file_command)
5909         (expand_symtabs_matching, map_symbol_filenames): Use
5910         all_objfiles.
5911         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5912         all_objfiles.
5913         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5914         * objc-lang.c (find_methods): Use all_objfiles.
5915         * objfiles.c (have_partial_symbols, have_full_symbols)
5916         (have_minimal_symbols, qsort_cmp)
5917         (default_iterate_over_objfiles_in_search_order): Use
5918         all_objfiles.
5919         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5920         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5921         (maintenance_check_psymtabs): Use all_objfiles.
5922         (ALL_PSYMTABS): Remove.
5923         * compile/compile-object-run.c (do_module_cleanup): Use
5924         all_objfiles.
5925         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5926         * cp-support.c (add_symbol_overload_list_qualified): Use
5927         all_objfiles.
5928         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5929         Use all_objfiles.
5930         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5931         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5932         all_objfiles.
5933         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5934         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5935         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5936         Uses all_objfiles.
5937         * solib.c (solib_read_symbols): Use all_objfiles
5938
5939 2019-01-09  Tom Tromey  <tom@tromey.com>
5940
5941         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5942         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5943         all_objfiles.
5944         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5945         * symmisc.c (print_symbol_bcache_statistics)
5946         (print_objfile_statistics, maintenance_print_objfiles)
5947         (maintenance_info_symtabs, maintenance_check_symtabs)
5948         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5949         all_objfiles.
5950         * source.c (forget_cached_source_info): Use all_objfiles.
5951         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5952         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5953         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5954         * objfiles.c (update_section_map): Use all_objfiles.
5955         (shared_objfile_contains_address_p): Likewise.
5956         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5957         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5958
5959 2019-01-09  Tom Tromey  <tom@tromey.com>
5960
5961         * common/next-iterator.h: New file.
5962         * objfiles.h (class all_objfiles): New.
5963         (struct objfile_iterator): New.
5964
5965 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5966
5967         * NEWS: Move the description of the changed "frame", "select-frame",
5968          and "info frame" commands to the Changed commands section.
5969
5970 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5971
5972         * gdbtypes.c (check_stub_method_group): Remove handling of old
5973         mangling schemes.
5974         * linespec.c (find_methods): Likewise.
5975         * stabsread.c (read_member_functions): Likewise.
5976         * valops.c (search_struct_method): Likewise.
5977         (value_struct_elt_for_reference): Likewise.
5978         * NEWS: Mention this change.
5979
5980 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5981
5982         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5983         print_source_lines.
5984         * source.c (print_source_lines_base): Update line number check.
5985         (print_source_lines): New function.
5986         (source_lines_range::source_lines_range): New function.
5987         * source.h (class source_lines_range): New class.
5988         (print_source_lines): New declaration.
5989
5990 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5991
5992         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5993
5994 2019-01-08  Tom Tromey  <tom@tromey.com>
5995             Simon Marchi  <simon.marchi@ericsson.com>
5996
5997         PR gdb/24060
5998         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5999         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6000         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6001         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6002         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6003         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6004
6005 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6006
6007         * source.c (select_source_symtab): Move header comment to
6008         declaration in source.h.
6009         (forget_cached_source_info_for_objfile): Likewise.
6010         (forget_cached_source_info): Likewise.
6011         (identify_source_line): Likewise.
6012         * source.h (identify_source_line): Move declaration from symtab.h
6013         and add comment from source.c
6014         (print_source_lines): Likewise.
6015         (forget_cached_source_info_for_objfile): Likewise.
6016         (forget_cached_source_info): Likewise.
6017         (select_source_symtab): Likewise.
6018         (enum print_source_lines_flag): Move definition from symtab.h.
6019         * symtab.h (identify_source_line): Move declaration to source.h.
6020         (print_source_lines): Likewise.
6021         (forget_cached_source_info_for_objfile): Likewise.
6022         (forget_cached_source_info): Likewise.
6023         (select_source_symtab): Likewise.
6024         (enum print_source_lines_flag): Move definition to source.h.
6025         * tui/tui-hooks.c: Add 'source.h' include.
6026
6027 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6028
6029         * source.c (print_source_lines_base): Handle requests to print
6030         reverse line number sequences, and guard against empty lines
6031         string.
6032
6033 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6034
6035         * source.c (print_source_lines_base): Fix skip of '\r' if next
6036         character is '\n'.
6037
6038 2019-01-06  Tom Tromey  <tom@tromey.com>
6039
6040         * c-exp.y (struct c_parse_state) <macro_original_text,
6041         expansion_obstack>: New member.
6042         (macro_original_text, expansion_obstack): Remove globals.
6043         (scan_macro_expansion, scanning_macro_expansion)
6044         (finished_macro_expansion): Update.
6045         (scan_macro_cleanup): Remove.
6046         (yylex, c_parse): Update.
6047
6048 2019-01-06  Tom Tromey  <tom@tromey.com>
6049
6050         * c-exp.y (struct c_parse_state) <strings>: New member.
6051         (operator_stoken): Update.
6052
6053 2019-01-06  Tom Tromey  <tom@tromey.com>
6054
6055         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6056         (union type_stack_elt) <typelist_val>: Now a pointer to
6057         std::vector.
6058         (type_stack_cleanup): Don't declare.
6059         (push_typelist): Update.
6060         * parse.c (pop_typelist): Return a std::vector.
6061         (push_typelist): Take a std::vector.
6062         (follow_types): Update.  Do not free args.
6063         (type_stack_cleanup): Remove.
6064         * c-exp.y (struct c_parse_state): New.
6065         (cpstate): New global.
6066         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6067         (nonempty_typelist): Update.
6068         (func_mod): Create a new vector.
6069         (c_parse): Create a c_parse_state.
6070         (check_parameter_typelist): Do not delete params.
6071         (function_method): Update.  Do not delete type_list.
6072
6073 2019-01-06  Tom Tromey  <tom@tromey.com>
6074
6075         PR gdb/28155:
6076         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6077         check_typedef.
6078         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6079         (print_return_value): Likewise.
6080
6081 2019-01-05  Tom Tromey  <tom@tromey.com>
6082
6083         * contrib/cleanup_check.py: Remove.
6084         * contrib/gcc-with-excheck: Remove.
6085         * contrib/exsummary.py: Remove.
6086         * contrib/excheck.py: Remove.
6087
6088 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6089
6090         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6091         NULL. Initialize tpprev to NULL instead of assigning it
6092         to NULL on the next statement.
6093         * windows-nat.c (windows_delete_thread): Remove check for
6094         main_thread_id before printing thread exit notifications.
6095         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6096         Remove thread ID check against main_thread_id.
6097         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6098         windows_delete_thread.
6099         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6100
6101 2019-01-04  Tom Tromey  <tom@tromey.com>
6102
6103         * compile/compile.c (_initialize_compile): Use upper case for
6104         metasyntactic variables.
6105         * symmisc.c (_initialize_symmisc): Use upper case for
6106         metasyntactic variables.
6107         * psymtab.c (_initialize_psymtab): Use upper case for
6108         metasyntactic variables.
6109         * demangle.c (demangle_command): Use upper case for metasyntactic
6110         variables.
6111         (_initialize_demangler): Likewise.
6112         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6113         variables.
6114
6115 2019-01-03  Tom Tromey  <tom@tromey.com>
6116
6117         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6118
6119 2019-01-03  Tom Tromey  <tom@tromey.com>
6120
6121         * python/py-symtab.c (salpy_str): Update.
6122         (struct salpy_sal_object) <symtab>: Now a PyObject.
6123         (salpy_dealloc): Update.
6124         (del_objfile_sal): Use gdbpy_ref.
6125
6126 2019-01-03  Tom Tromey  <tom@tromey.com>
6127
6128         * python/py-type.c (convert_field): Use new_reference.  Return
6129         gdbpy_ref.
6130         (make_fielditem): Return gdbpy_ref.
6131         (typy_fields): Update.
6132         (typy_getitem): Update.
6133         (field_name): Return gdbpy_ref.  Use new_reference.
6134         (typy_iterator_iternext): Update.
6135
6136 2019-01-03  Tom Tromey  <tom@tromey.com>
6137
6138         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6139
6140 2019-01-03  Tom Tromey  <tom@tromey.com>
6141
6142         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6143         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6144         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6145         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6146         (pspy_set_type_printers): Likewise.
6147         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6148         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6149         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6150         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6151         (objfpy_set_type_printers): Likewise.
6152
6153 2019-01-03  Tom Tromey  <tom@tromey.com>
6154
6155         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6156         (gdbpy_print_stack): Use gdbpy_err_fetch.
6157         * python/python-internal.h (class gdbpy_err_fetch): New class.
6158         (class gdbpy_enter) <m_error_type, m_error_value,
6159         m_error_traceback>: Remove.
6160         <m_error>: New member.
6161         (gdbpy_exception_to_string): Don't declare.
6162         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6163         * python/py-value.c (convert_value_from_python): Use
6164         gdbpy_err_fetch.
6165         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6166         gdbpy_exception_to_string.
6167         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6168         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6169         gdbpy_err_fetch.
6170
6171 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6172
6173         * linux-nat.c (delete_lwp_cleanup): Delete.
6174         (struct lwp_deleter): New struct.
6175         (lwp_info_up): New typedef.
6176         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6177         lwp_info_up.
6178
6179 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6180
6181         * linux-fork.c (class scoped_switch_fork_info): New class.
6182         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6183
6184 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6185
6186         * valops.c (find_overload_match): Remove use of null_cleanup, and
6187         calls to do_cleanups.
6188
6189 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6190
6191         * compile/compile-cplus-types.c
6192         (compile_cplus_instance::decl_name): Handle changes to
6193         cp_func_name.
6194         * cp-support.c (cp_func_name): Update header comment, update
6195         return type.
6196         * cp-support.h (cp_func_name): Update return type in declaration.
6197         * valops.c (find_overload_match): Move temp_func local to top
6198         level of function and change its type.  Use temp_func to hold and
6199         delete temporary string obtained from cp_func_name.
6200
6201 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6204         gdb::char_vector, remove cleanup, and update uses of `msg`.
6205
6206 2019-01-03  Jim Wilson  <jimw@sifive.com>
6207
6208         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6209
6210 2019-01-02  Tom Tromey  <tom@tromey.com>
6211
6212         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6213         (tdesc_parse_xml): Remove cleanups.
6214         * target-descriptions.h (make_cleanup_free_target_description):
6215         Don't declare.
6216         (target_desc_deleter): New struct.
6217         (target_desc_up): New typedef.
6218         * target-descriptions.c (target_desc_deleter::operator()): Rename
6219         from free_target_description.
6220         (make_cleanup_free_target_description): Remove.
6221
6222 2019-01-02  Tom Tromey  <tom@tromey.com>
6223
6224         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6225         constructor, destructor.
6226         (linespec_parser): Remove typedef.
6227         (~linespec_parser): Rename from linespec_parser_delete.
6228         (linespec_lex_to_end, linespec_complete_label)
6229         (linespec_complete): Update.
6230         (decode_line_full): Remove cleanups.
6231         (decode_line_1): Update.
6232
6233 2019-01-02  Tom Tromey  <tom@tromey.com>
6234
6235         * python/python-internal.h (inferior_to_inferior_object): Change
6236         return type.
6237         * python/py-exitedevent.c (create_exited_event_object): Update.
6238         * python/py-inferior.c (inferior_to_inferior_object): Return
6239         gdbpy_ref.
6240         (python_new_inferior, python_inferior_deleted)
6241         (thread_to_thread_object, delete_thread_object)
6242         (build_inferior_list, gdbpy_selected_inferior): Update.
6243         * python/py-infthread.c (create_thread_object): Update.  Also fail
6244         if inferior_to_inferior_object fails.
6245
6246 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6247
6248         * inferior.h (class inferior) <displaced_step_state>: New field.
6249         * infrun.h (struct displaced_step_state): Move here from
6250         infrun.c.  Initialize fields, add constructor.
6251         <inf>: Remove field.
6252         <reset>: New method.
6253         * infrun.c (struct displaced_step_inferior_state): Move to
6254         infrun.h.
6255         (displaced_step_inferior_states): Remove.
6256         (get_displaced_stepping_state): Adust.
6257         (displaced_step_in_progress_any_inferior): Adjust.
6258         (displaced_step_in_progress_thread): Adjust.
6259         (displaced_step_in_progress): Adjust.
6260         (add_displaced_stepping_state): Remove.
6261         (get_displaced_step_closure_by_addr): Adjust.
6262         (remove_displaced_stepping_state): Remove.
6263         (infrun_inferior_exit): Call displaced_step_state.reset.
6264         (use_displaced_stepping): Don't check for NULL.
6265         (displaced_step_prepare_throw): Call
6266         get_displaced_stepping_state.
6267         (displaced_step_fixup): Don't check for NULL.
6268         (prepare_for_detach): Don't check for NULL.
6269
6270 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6271
6272         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6273          in case of call that did not complete.
6274
6275 2019-01-02  Andrey Utkin  <autkin@undo.io>
6276
6277         * symfile.c (find_separate_debug_file): Fix search of debug files for
6278         remote debuggee.
6279
6280 2019-01-02  Tom Tromey  <tom@tromey.com>
6281
6282         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6283         indentation.
6284         * python/py-frame.c (frapy_older): Remove cast.
6285         (frapy_newer): Likewise.
6286         * python/py-breakpoint.c (local_setattro): Remove cast.
6287         * python/py-arch.c (archpy_name): Remove local variable.
6288         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6289
6290 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6291
6292         * unittests/basic_string_view/element_access/char/empty.cc:
6293         Fix year range in copyright header.
6294
6295 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6296
6297         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6298         Delete.
6299         <operator==>: Update with for removed field.
6300         <hash>: Likewise.
6301         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6302         <isa_features>: ...this.
6303         <abi_features>: New field.
6304         (riscv_isa_flen): Update comment.
6305         (riscv_abi_xlen): New declaration.
6306         (riscv_abi_flen): New declaration.
6307         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6308         isa_features.
6309         (riscv_abi_xlen): New function.
6310         (riscv_isa_flen): Update to get answer from isa_features.
6311         (riscv_abi_flen): New function.
6312         (riscv_has_fp_abi): Update to get answer from abi_features.
6313         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6314         xlen and flen.
6315         (riscv_call_info) <xlen, flen>: Update comment.
6316         (riscv_call_arg_struct): Remove invalid assertions
6317         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6318         is removed.
6319         (riscv_gdbarch_init): Gather isa features and abi features
6320         separately, ensure both match on the gdbarch when reusing an old
6321         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6322         a target with 64-bit float hardware.
6323
6324 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6325
6326         * source.c (search_command_helper): Stop reverse search
6327         when line 1 has been searched.
6328
6329 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6330
6331         * record-full.c (record_full_base_target::close): Rewrite
6332         record_full_core_buf_list free logic.
6333
6334 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6335
6336         * break-catch-syscall.c (print_one_catch_syscall): xfree
6337         the last text.
6338
6339 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6340
6341         * top.c (print_gdb_version): Update Copyright year in version
6342         message.
6343
6344 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6345
6346         Update copyright year range in all GDB files.
6347
6348 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6349
6350         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6351
6352 For older changes see ChangeLog-2018.
6353 \f
6354 Local Variables:
6355 mode: change-log
6356 left-margin: 8
6357 fill-column: 74
6358 version-control: never
6359 coding: utf-8
6360 End:
6361