gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tromey@adacore.com>
   2
   3         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
   4         do_field_signed>: Rename.  Change type of "value".
   5         * ui-out.c (ui_out::field_signed): Rename from field_int.
   6         Change type of "value".
   7         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
   8         type of "value".
   9         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
  10         do_field_int.  Change type of "value".
  11         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
  12         do_field_int.  Change type of "value".
  13         * tracepoint.c (trace_status_mi, tfind_1)
  14         (print_one_static_tracepoint_marker): Update.
  15         * thread.c (print_thread_info_1, print_selected_thread_frame):
  16         Update.
  17         * stack.c (print_frame, print_frame_info): Update.
  18         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
  19         Update.
  20         * source.c (print_source_lines_base): Update.
  21         * skip.c (info_skip_command): Update.
  22         * record-btrace.c (btrace_ui_out_decode_error)
  23         (btrace_call_history_src_line): Update.
  24         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
  25         Update.
  26         * progspace.c (print_program_space): Update.
  27         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
  28         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
  29         do_field_int.  Change type of "value".
  30         * mi/mi-out.c (mi_ui_out::do_table_begin)
  31         (mi_ui_out::do_table_header): Update.
  32         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
  33         type of "value".
  34         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
  35         (mi_cmd_data_list_changed_registers, output_register)
  36         (mi_cmd_data_read_memory, mi_load_progress)
  37         (mi_cmd_trace_frame_collected): Update.
  38         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
  39         Update.
  40         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
  41         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
  42         (mi_cmd_var_list_children, varobj_update_one): Update.
  43         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
  44         (mi_cmd_stack_list_args, list_arg_or_local): Update.
  45         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
  46         * inferior.c (print_inferior): Update.
  47         * gdb_bfd.c (print_one_bfd): Update.
  48         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  49         Update.
  50         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
  51         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
  52         do_field_int.  Change type of "value".
  53         * cli-out.c (cli_ui_out::do_field_signed): Rename from
  54         do_field_int.  Change type of "value".
  55         * breakpoint.c (watchpoint_check, print_breakpoint_location)
  56         (print_one_breakpoint_location, print_it_catch_fork)
  57         (print_one_catch_fork, print_it_catch_vfork)
  58         (print_one_catch_vfork, print_it_catch_solib)
  59         (print_it_catch_exec, print_it_ranged_breakpoint)
  60         (print_mention_watchpoint, print_mention_masked_watchpoint)
  61         (bkpt_print_it, update_static_tracepoint): Update.
  62         * break-catch-throw.c (print_it_exception_catchpoint): Update.
  63         * break-catch-syscall.c (print_it_catch_syscall): Update.
  64         * ada-tasks.c (print_ada_task_info): Update.
  65         * ada-lang.c (print_it_exception, print_mention_exception):
  66         Update.
  67
  68 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
  69
  70         PR breakpoints/24541
  71         * gdbarch.c: Regenerate.
  72         * gdbarch.h: Regenerate.
  73         * gdbarch.sh: Adjust return type and parameter types for
  74         'stap_adjust_register'.
  75         (i386_stap_adjust_register): Adjust signature and return new
  76         register name.
  77         * stap-probe.c (stap_parse_register_operand): Adjust use of
  78         'gdbarch_stap_adjust_register'.
  79
  80 2019-07-17  Tom Tromey  <tromey@adacore.com>
  81
  82         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
  83         declare VEC.
  84         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
  85         std::vector.
  86         (struct s390_process_info): Add initializers.
  87         (s390_add_process): Use new.
  88         (s390_linux_nat_target::low_forget_process): Use delete.
  89         (s390_linux_nat_target::low_new_fork)
  90         (s390_linux_nat_target::stopped_by_watchpoint)
  91         (s390_linux_nat_target::low_prepare_to_resume)
  92         (s390_linux_nat_target::insert_watchpoint)
  93         (s390_linux_nat_target::insert_hw_breakpoint)
  94         (s390_linux_nat_target::remove_watchpoint)
  95         (s390_linux_nat_target::remove_hw_breakpoint): Update.
  96
  97 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
  98
  99         * aarch64-fbsd-nat.c: Include regcache.h.
 100         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 101         argument.
 102         (aarch64_fbsd_nat_target::fetch_registers)
 103         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 104         variable.
 105         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 106
 107 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 108
 109         * fbsd-nat.c: Include gdbarch.h.
 110
 111 2019-07-15  Tom Tromey  <tromey@adacore.com>
 112
 113         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 114
 115 2019-07-15  Tom Tromey  <tromey@adacore.com>
 116
 117         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 118         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 119         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 120         * cli-out.c (cli_ui_out::do_field_int): New method.
 121         * ui-out.c (ui_out::field_unsigned): New method.
 122         * symfile.c (generic_load): Use field_unsigned.
 123         (print_transfer_performance): Likewise.
 124         * record-btrace.c (ui_out_field_uint): Remove.
 125         (btrace_call_history_insn_range, btrace_call_history): Use
 126         field_unsigned.
 127         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 128         field_unsigned.
 129         * ui-out.h (class ui_out) <field_unsigned>: New method.
 130         <do_field_unsigned>: Likewise.
 131
 132 2019-07-15  Tom Tromey  <tromey@adacore.com>
 133
 134         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 135         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 136         * target.c (flash_erase_command): Use field_string.
 137         * infrun.c (print_signal_received_reason): Use field_string.
 138         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 139         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 140         field_string.
 141         * ada-tasks.c (print_ada_task_info): Use field_string.
 142
 143 2019-07-15  Tom Tromey  <tromey@adacore.com>
 144
 145         * target.c (flash_erase_command): Use field_core_addr.
 146         * symfile.c (generic_load): Use field_core_addr.
 147         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 148         Use field_core_addr.
 149         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 150         field_core_addr.
 151
 152 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 153
 154         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 155         value if its desired type is smaller than a CORE_ADDR and signed.
 156
 157 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 160         of changes to field names, and use new is_reference field to
 161         decide if a property is a reference or not.
 162         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 163         field.
 164         (struct dwarf2_property_baton): Update header comment, rename
 165         'referenced_type' to 'property_type' and update comments.
 166         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 167         default property type, store in property baton, update to take
 168         accound of renamed field.
 169         (read_func_scope): Update call to attr_to_dynamic_prop.
 170         (read_array_type): Likewise.
 171         (dwarf2_per_cu_addr_sized_int_type): New function.
 172         (read_subrange_index_type): Move type finding code to
 173         dwarf2_per_cu_addr_sized_int_type.
 174         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 175         (dwarf2_per_cu_addr_type): New function.
 176         (set_die_type): Update calls to attr_to_dynamic_prop.
 177
 178 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 179
 180         * dwarf2read.c (read_subrange_index_type): New function.
 181         (read_subrange_type): Move code into new function and call it.
 182         * gdbtypes.c (create_range_type): Add some asserts.
 183
 184 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 185
 186         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 187         update return statements.
 188         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 189         declaration, and update comment to match.
 190         * gdbtypes.c (resolve_dynamic_array): Update call to
 191         dwarf2_evaluate_property to match new return type.
 192
 193 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 194
 195         * valarith.c (value_subscripted_rvalue): Change lowerbound
 196         parameter type from int to LONGEST.
 197         * value.h (value_subscripted_rvalue): Likewise in declaration.
 198
 199 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 200
 201         * cli/cli-utils.c (info_print_command_completer): New function.
 202         * cli/cli-utils.h: Add 'completer.h' include, and forward
 203         declaration for 'struct cmd_list_element'.
 204         (info_print_command_completer): Declare.
 205         * stack.c (_initialize_stack): Add completer for 'info locals' and
 206         'info args'.
 207         * symtab.c (_initialize_symtab): Add completer for 'info
 208         variables' and 'info functions'.
 209         * NEWS: Mention completion for additional info commands.
 210
 211 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 212
 213         * cli/cli-utils.c (extract_info_print_args): Delete.
 214         (extract_arg_maybe_quoted): Delete.
 215         (info_print_options_defs): New variable.
 216         (make_info_print_options_def_group): New function.
 217         (extract_info_print_options): Define new function.
 218         * cli/cli-utils.h (extract_info_print_args): Delete.
 219         (struct info_print_options): New structure.
 220         (extract_info_print_options): Declare new function.
 221         * stack.c (info_locals_command): Update to use new
 222         extract_info_print_options, also add a header comment.
 223         (info_args_command): Likewise.
 224         * symtab.c (info_variables_command): Likewise.
 225         (info_functions_command): Likewise.
 226
 227 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 228
 229         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 230         to extract string arguments.
 231         * common/common-utils.c (extract_string_maybe_quoted): New function.
 232         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 233
 234 2019-07-11  Tom Tromey  <tromey@adacore.com>
 235
 236         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 237         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 238         * top.h (gdbinit): Don't declare.
 239         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 240         into...
 241         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 242         * top.c (gdb_init): Don't call init_cli_cmds.
 243         (gdbinit): Remove.
 244         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 245
 246 2019-07-11  Tom Tromey  <tromey@adacore.com>
 247
 248         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 249         after it has been moved.
 250
 251 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 252
 253         * valops.c (value_must_coerce_to_target): Change return type to
 254         bool.
 255         * value.h (value_must_coerce_to_target): Likewise.
 256
 257 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 258
 259         * breakpoint.c (is_hardware_watchpoint): Remove
 260         forward-declaration.
 261         (is_masked_watchpoint): Change return type to bool.
 262         (is_tracepoint): Likewise.
 263         (is_breakpoint): Likewise.
 264         (is_hardware_watchpoint): Likewise.
 265         (is_watchpoint): Likewise.
 266         (is_no_memory_software_watchpoint): Likewise.
 267         (is_catchpoint): Likewise.
 268         (breakpoint_1): Make FILTER parameter's return type bool.
 269         is_masked_watchpoint): Change return type to bool.
 270         (save_breakpoints): Make FILTER parameter's return type bool.
 271         * breakpoint.h (is_breakpoint): Change return type to bool.
 272         (is_watchpoint): Likewise.
 273         (is_catchpoint): Likewise.
 274         (is_tracepoint): Likewise.
 275
 276 2019-07-10  Tom Tromey  <tom@tromey.com>
 277
 278         * defs.h: Don't include gdbarch.h.
 279         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 280         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 281         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 282         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 283         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 284         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 285         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 286         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 287         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 288         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 289         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 290         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 291         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 292         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 293         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 294         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 295         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 296         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 297         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 298         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 299         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 300         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 301         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 302         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 303         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 304         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 305         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 306
 307 2019-07-10  Tom Tromey  <tromey@adacore.com>
 308
 309         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 310         * breakpoint.c (init_ada_exception_breakpoint): Register as
 311         bp_catchpoint.
 312         (print_one_breakpoint_location, print_one_breakpoint): Use
 313         is_ada_exception_catchpoint.
 314         * ada-lang.c (class ada_catchpoint_location): Pass
 315         bp_loc_software_breakpoint to bp_location constructor.
 316         (is_ada_exception_catchpoint): New function.
 317
 318 2019-07-10  Tom Tromey  <tromey@adacore.com>
 319
 320         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 321         VEC.
 322         (struct arm_exidx_entry): New method operator<.
 323         (struct arm_exidx_data) <section_maps>: Change type.
 324         (arm_exidx_data_free): Remove.
 325         (arm_exidx_data_key): Change type.  Move lower.
 326         (arm_exidx_new_objfile): Update.
 327         (arm_compare_exidx_entries): Remove.
 328         (arm_find_exidx_entry, _initialize_arm_tdep)
 329
 330 2019-07-10  Tom Tromey  <tromey@adacore.com>
 331
 332         * solib-spu.c (ocl_program_data_key): Change type.
 333         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 334         Update.
 335
 336 2019-07-10  Tom Tromey  <tromey@adacore.com>
 337
 338         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 339         (struct solib_aix_inferior_data) <library_list>: Change type.
 340         (solib_aix_inferior_data_handle): Change type.
 341         (get_solib_aix_inferior_data): Update.
 342         (solib_aix_free_library_list): Remove.
 343         (library_list_start_library): Update.
 344         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 345         return type.
 346         (solib_aix_get_library_list)
 347         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 348         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 349
 350 2019-07-10  Tom Tromey  <tromey@adacore.com>
 351
 352         * solib-dsbt.c (struct dsbt_info): Add initializers.
 353         (solib_dsbt_pspace_data): Change type.
 354         (dsbt_pspace_data_cleanup): Remove.
 355         (get_dsbt_info, _initialize_dsbt_solib): Update.
 356
 357 2019-07-10  Tom Tromey  <tromey@adacore.com>
 358
 359         * spu-tdep.c (spu_overlay_data): Change type.
 360         (spu_get_overlay_table, spu_overlay_new_objfile)
 361         (_initialize_spu_tdep): Update.
 362
 363 2019-07-10  Tom Tromey  <tromey@adacore.com>
 364
 365         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 366         destructor.
 367         (dbx_objfile_data_key): Change type and declare later.
 368         (DBX_SYMFILE_INFO): Rewrite.
 369         * dbxread.c (dbx_objfile_data_key): Change type.
 370         (dbx_symfile_init): Update.
 371         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 372         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 373         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 374
 375 2019-07-10  Tom Tromey  <tromey@adacore.com>
 376
 377         * jit.c (jit_program_space_key): Change type.  Move lower.
 378         (get_jit_program_space_data): Update.
 379         (jit_program_space_data_cleanup): Remove.
 380         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 381         Update.
 382         (struct jit_program_space_data): Add initializers.
 383
 384 2019-07-10  Tom Tromey  <tromey@adacore.com>
 385
 386         * solib-darwin.c (struct darwin_info): Add initializers.
 387         (solib_darwin_pspace_data): Change type.
 388         (darwin_pspace_data_cleanup): Remove.
 389         (get_darwin_info, _initialize_darwin_solib): Update.
 390
 391 2019-07-10  Tom Tromey  <tromey@adacore.com>
 392
 393         * remote-sim.c (struct sim_inferior_data): Add initializers,
 394         constructor, and destructor.
 395         (sim_inferior_data_key): Change type.  Move lower.
 396         (check_for_duplicate_sim_descriptor): Update.
 397         (get_sim_inferior_data): Use new.  Update.
 398         (~sim_inferior_data_cleanup): Rename from
 399         sim_inferior_data_cleanup.  Simplify.
 400         (gdbsim_close_inferior, simulator_command)
 401         (sim_command_completer, _initialize_remote_sim): Update.
 402         (next_pid, INITIAL_PID): Move earlier.
 403
 404 2019-07-10  Tom Tromey  <tromey@adacore.com>
 405
 406         * python/python-internal.h (create_thread_object): Return
 407         gdbpy_ref.
 408         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 409         * python/py-inferior.c (struct threadlist_entry): Add
 410         constructor.
 411         <thread_obj>: Now a gdbpy_ref.
 412         (thread_to_thread_object): Update.
 413         (add_thread_object): Use new.
 414         (delete_thread_object): Use delete.
 415         (infpy_threads): Update.
 416         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 417         GIL.
 418
 419 2019-07-10  Tom Tromey  <tromey@adacore.com>
 420
 421         * valops.c (value_cast): Specialize error message for Ada.
 422
 423 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 424
 425         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 426
 427 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 428
 429         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 430         bpstat_should_step): Return bool, adjust comments.
 431         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 432         bpstat_should_step): Likewise.
 433
 434 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 435
 436         * features/Makefile: Use feature target descriptions for Arm.
 437         * features/arm/arm-core.c: Generate new file.
 438         * features/arm/arm-fpa.c: Likewise.
 439         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 440         * features/arm/arm-m-profile.c: Likewise.
 441         * features/arm/arm-vfpv2.c: Likewise.
 442         * features/arm/arm-vfpv3.c: Likewise.
 443         * features/arm/xscale-iwmmxt.c: Likewise.
 444         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 445
 446 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 447
 448         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 449         ptrace earlier.
 450
 451 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 452
 453         * features/aarch64-pauth.c: Regenerate.
 454
 455 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 456
 457         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 458         bool.
 459         (bpstat_what): Use false instead of 0.
 460
 461 2019-07-09  Pedro Alves  <palves@redhat.com>
 462
 463         * break-catch-throw.c (is_exception_catchpoint): New.
 464         * breakpoint.c (print_one_breakpoint_location): New parameter
 465         'raw_loc'.  Handle it.  Use
 466         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 467         looking at the breakpoint's type.
 468         (print_one_breakpoint): If handling "maint info breakpoints", also
 469         print locations of exception catchpoints.
 470         * breakpoint.h (is_exception_catchpoint): Declare.
 471
 472 2019-07-09  Pedro Alves  <palves@redhat.com>
 473
 474         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 475         "addr" field.
 476         (allocate_location_exception_catchpoint): New.
 477         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 478         (initialize_throw_catchpoint_ops): Install
 479         allocate_location_exception_catchpoint as allocate_location
 480         method.
 481         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 482         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 483         bp_loc_other.
 484         (breakpoint_address_is_meaningful): Delete.
 485         (bl_address_is_meaningful): New.
 486         (breakpoint_locations_match): Adjust comment.
 487         (bp_location_from_bp_type): New, factored out of...
 488         (bp_location::bp_location(breakpoint *)): ... this.
 489         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 490         factored out of...
 491         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 492         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 493         breakpoint_address_is_meaningful.
 494         (bp_locations_compare): Adjust comment.
 495         (update_global_location_list): Use bl_address_is_meaningful
 496         instead of breakpoint_address_is_meaningful.
 497         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 498         explicit.
 499         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 500         * python/py-breakpoint.c (bppy_get_location): No longer check
 501         whether location is null.
 502
 503 2019-07-09  Pedro Alves  <palves@redhat.com>
 504
 505         PR c++/15468
 506         * breakpoint.c (print_one_breakpoint_location): Remove
 507         single-location assert.
 508
 509 2019-07-09  Tom Tromey  <tom@tromey.com>
 510
 511         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 512         * configure: Rebuild.
 513         * configure.ac: Change common to gdbsupport.
 514         * gdbsupport: Rename from common.
 515         * acinclude.m4: Change common to gdbsupport.
 516         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 517         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 518         gdbsupport.
 519         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 520         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 521         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 522         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 523         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 524         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 525         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 526         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 527         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 528         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 529         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 530         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 531         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 532         coff-pe-read.c, command.h, compile/compile-c-support.c,
 533         compile/compile-c.h, compile/compile-cplus-symbols.c,
 534         compile/compile-cplus-types.c, compile/compile-cplus.h,
 535         compile/compile-loc2c.c, compile/compile.c, completer.c,
 536         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 537         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 538         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 539         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 540         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 541         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 542         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 543         features/aarch64-core.c, features/aarch64-fpu.c,
 544         features/aarch64-pauth.c, features/aarch64-sve.c,
 545         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 546         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 547         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 548         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 549         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 550         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 551         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 552         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 553         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 554         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 555         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 556         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 557         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 558         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 559         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 560         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 561         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 562         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 563         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 564         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 565         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 566         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 567         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 568         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 569         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 570         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 571         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 572         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 573         minsyms.c, mips-linux-tdep.c, namespace.h,
 574         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 575         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 576         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 577         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 578         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 579         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 580         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 581         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 582         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 583         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 584         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 585         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 586         procfs.c, producer.c, progspace.h, psymtab.h,
 587         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 588         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 589         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 590         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 591         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 592         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 593         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 594         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 595         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 596         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 597         target-memory.c, target.c, target.h, target/waitstatus.c,
 598         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 599         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 600         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 601         unittests/array-view-selftests.c,
 602         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 603         unittests/common-utils-selftests.c,
 604         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 605         unittests/format_pieces-selftests.c,
 606         unittests/function-view-selftests.c,
 607         unittests/lookup_name_info-selftests.c,
 608         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 609         unittests/mkdir-recursive-selftests.c,
 610         unittests/observable-selftests.c,
 611         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 612         unittests/parse-connection-spec-selftests.c,
 613         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 614         unittests/scoped_fd-selftests.c,
 615         unittests/scoped_mmap-selftests.c,
 616         unittests/scoped_restore-selftests.c,
 617         unittests/string_view-selftests.c, unittests/style-selftests.c,
 618         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 619         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 620         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 621         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 622         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 623         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 624
 625 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 626
 627         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 628         bool value.
 629         (decode_digits_ordinary): Set explicit_line field in sal.
 630         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 631         symtab_and_line that was set on an explicit line number in
 632         assembler code.  Do always update the recorded symtab and line if
 633         we do skip the prologue.
 634
 635 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 636
 637         * breakpoint.c (set_breakpoint_location_function): Remove
 638         explicit_loc parameter.
 639         (momentary_breakpoint_from_master): Update call to
 640         set_breakpoint_location_function.
 641         (add_location_to_breakpoint): Likewise.
 642
 643 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 644
 645         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 646         required features based on default bfd type when no specific bfd
 647         is present.
 648
 649 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 650
 651         * NEWS: Mention that GDB printf and eval commands can now print
 652         C-style and Ada-style convenience var strings without
 653         calling the inferior.
 654         * printcmd.c (printf_c_string): Locally print GDB internal var
 655         instead of transiting via the inferior.
 656         (printf_wide_c_string): Likewise.
 657
 658 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 659
 660         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 661
 662 2019-07-04  Tom Tromey  <tom@tromey.com>
 663
 664         PR tui/24724:
 665         * tui/tui-winsource.c (tui_clear_source_content): Update.
 666         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 667         (tui_update_breakpoint_info): Update.
 668         (tui_set_exec_info_content): Update.
 669         * tui/tui-source.c (tui_set_source_content_nil): Update.
 670         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 671         has_break.
 672         * tui/tui-data.h (enum tui_bp_flag): New.
 673         (tui_bp_flags): New enum flags type.
 674         (struct tui_source_element) <break_mode>: Change type.  Rename
 675         from has_break.
 676         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 677         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 678         constants.
 679         * tui/tui-winsource.h: Fix comment.
 680
 681 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 682
 683         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 684         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 685         (store_fpregs_to_thread)
 686         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 687         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 688         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 689         (IWMMXT_REGS_SIZE): Add define.
 690         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 691         (fetch_vfp_regs, store_vfp_regs)
 692         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 693         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 694
 695 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 696
 697         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 698         defines.
 699         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 700         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 701         (ARM_INT_REGISTER_SIZE): ...to this.
 702         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 703         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 704         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 705         (arm_linux_collect_gregset, supply_nwfpe_register)
 706         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 707         defines.
 708         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 709         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 710         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 711         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 712         (arm_return_in_memory, arm_store_return_value)
 713         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 714         (arm_record_ld_st_multiple): Likewise.
 715         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 716         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 717
 718 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 719
 720         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 721         AARCH64_DISPLACED_MODIFIED_INSNS.
 722         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 723         (aarch64_displaced_step_copy_insn): Likewise.
 724         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 725         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 726         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 727         ARM_DISPLACED_MODIFIED_INSNS.
 728         * arm-tdep.c (arm_gdbarch_init): Likewise.
 729         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 730         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 731         (struct arm_displaced_step_closure): Use
 732         ARM_DISPLACED_MODIFIED_INSNS.
 733
 734 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 735
 736         * features/Makefile: Remove unused xml files.
 737         * features/aarch64.xml: Remove.
 738         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 739         * features/i386/amd64-avx-avx512.xml: Remove.
 740         * features/i386/amd64-avx-linux.xml: Remove.
 741         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 742         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 743         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 744         * features/i386/amd64-avx-mpx.xml: Remove.
 745         * features/i386/amd64-avx.xml: Remove.
 746         * features/i386/amd64-linux.xml: Remove.
 747         * features/i386/amd64-mpx-linux.xml: Remove.
 748         * features/i386/amd64-mpx.xml: Remove.
 749         * features/i386/amd64.xml: Remove.
 750         * features/i386/i386-avx-avx512-linux.xml: Remove.
 751         * features/i386/i386-avx-avx512.xml: Remove.
 752         * features/i386/i386-avx-linux.xml: Remove.
 753         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 754         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 755         * features/i386/i386-avx-mpx-linux.xml: Remove.
 756         * features/i386/i386-avx-mpx.xml: Remove.
 757         * features/i386/i386-avx.xml: Remove.
 758         * features/i386/i386-linux.xml: Remove.
 759         * features/i386/i386-mmx-linux.xml: Remove.
 760         * features/i386/i386-mmx.xml: Remove.
 761         * features/i386/i386-mpx-linux.xml: Remove.
 762         * features/i386/i386-mpx.xml: Remove.
 763         * features/i386/i386.xml: Remove.
 764         * features/i386/x32-avx-avx512-linux.xml: Remove.
 765         * features/i386/x32-avx-linux.xml: Remove.
 766         * features/i386/x32-linux.xml: Remove.
 767
 768 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 769
 770         * regformats/aarch64.dat: Remove.
 771         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 772         * regformats/i386/amd64-avx-linux.dat: Remove.
 773         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 774         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 775         * regformats/i386/amd64-linux.dat: Remove.
 776         * regformats/i386/amd64-mpx-linux.dat: Remove.
 777         * regformats/i386/amd64.dat: Remove.
 778         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 779         * regformats/i386/i386-avx-linux.dat: Remove.
 780         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 781         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 782         * regformats/i386/i386-linux.dat: Remove.
 783         * regformats/i386/i386-mmx-linux.dat: Remove.
 784         * regformats/i386/i386-mpx-linux.dat: Remove.
 785         * regformats/i386/i386.dat: Remove.
 786         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 787         * regformats/i386/x32-avx-linux.dat: Remove.
 788         * regformats/i386/x32-linux.dat: Remove.
 789
 790 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 791
 792         * aarch64-tdep.c: Remove xml self tests.
 793         * amd64-linux-tdep.c: Likewise.
 794         * amd64-tdep.c: Likewise.
 795         * i386-linux-tdep.c: Likewise.
 796         * i386-tdep.c: Likewise.
 797
 798 2019-07-03  Pedro Alves  <palves@redhat.com>
 799
 800         PR cli/24732
 801         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 802         (pipe_cmd_option_defs): New.
 803         (make_pipe_cmd_options_def_group): New.
 804         (pipe_command): Use gdb::option::process_options.
 805         (pipe_command_completer): New function.
 806         (_initialize_cli_cmds): Install completer for "pipe" command.
 807
 808 2019-07-03  Pedro Alves  <palves@redhat.com>
 809
 810         * cli/cli-option.c (union option_value) <string>: New field.
 811         (struct option_def_and_value): Add ctor, move ctor, dtor and
 812         use DISABLE_COPY_AND_ASSIGN.
 813         (option_def_and_value::clear_value): New.
 814         (parse_option, save_option_value_in_ctx, get_val_type_str)
 815         (add_setshow_cmds_for_options): Handle var_string.
 816         * cli-option.h (union option_def::var_address) <string>: New
 817         field.
 818         (struct string_option_def): New.
 819         * maint-test-options.c (struct test_options_opts): Add default
 820         ctor and use DISABLE_COPY_AND_ASSIGN.
 821         <string_opt>: New field.
 822         (test_options_opts::~test_options_opts): New.
 823         (test_options_opts::dump): Also dump "-string".
 824         (test_options_option_defs): Install "string.
 825
 826 2019-07-03  Pedro Alves  <palves@redhat.com>
 827
 828         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 829         option_value with a null enumeration.
 830         (complete_options): Save the option values in the context.
 831         (save_option_value_in_ctx): New, factored out from ...
 832         (process_options): ... here.
 833         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 834         of the function.
 835         * maint-test-options.c (test_options_opts::dump): New, factored
 836         out from ...
 837         (maintenance_test_options_command_mode): ... here.
 838         (maintenance_test_options_command_completion_result): Delete.
 839         (maintenance_test_options_command_completion_text): Update
 840         comment.
 841         (maintenance_show_test_options_completion_result): Change
 842         prototype.  Just print
 843         maintenance_test_options_command_completion_text.
 844         (save_completion_result): New.
 845         (maintenance_test_options_completer_mode): Pass options context to
 846         complete_options, and then save a dump.
 847         (_initialize_maint_test_options): Use add_cmd to install "maint
 848         show test-options-completion-result".
 849
 850 2019-07-03  Pedro Alves  <palves@redhat.com>
 851
 852         * NEWS (New commands): Mention "with" and "maint with".
 853         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 854         (with_command, with_command_completer): New.
 855         (pipe_command): Adjust to new repeat_previous
 856         interface.
 857         (_initialize_cli_cmds): Install the "with" command and its "w"
 858         alias.
 859         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 860         declarations.
 861         * cli/cli-setshow.c (parse_cli_var_uinteger)
 862         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 863         argument strings for all var_types.
 864         (get_setshow_command_value_string): New, factored out from ...
 865         (do_show_command): ... this.
 866         * cli/cli-setshow.h: Include <string>.
 867         (get_setshow_command_value_string): Declare.
 868         * command.h (repeat_previous): Now returns const char *.  Adjust
 869         comment.
 870         * maint.c: Include "cli/cli-cmds.h".
 871         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 872         (_initialize_maint_cmds): Register the "maintenance with" command.
 873         * top.c (repeat_previous): Move bits from pipe_command here:
 874         Return the saved command line, if any; error out if there's no
 875         command to relaunch.
 876
 877 2019-07-03  Pedro Alves  <palves@redhat.com>
 878
 879         * NEWS (New commands): Mention "maint set/show test-settings"
 880         instead of "maint test-settings".
 881         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 882         (maintenance_test_settings_set_list): Rename to ...
 883         (maintenance_set_test_settings_list): ... this.
 884         (maintenance_test_settings_show_list): Rename to  ...
 885         (maintenance_show_test_settings_list): ... this.
 886         (maintenance_test_settings_cmd): Delete.
 887         (maintenance_test_settings_set_cmd): ...
 888         (maintenance_set_test_settings_cmd): ... this.
 889         (maintenance_test_settings_show_cmd): ...
 890         (maintenance_show_test_settings_cmd): ... this.
 891         (maintenance_test_settings_show_value_cmd):
 892         (maintenance_show_test_settings_value_cmd): ... this.
 893         (_initialize_maint_test_settings): No longer install the "maint
 894         test-settings" prefix command.  Rename "maint test-settings set"
 895         to "maint set test-settings", and "maint test-settings show" to
 896         "maint show test-settings".  Adjust all subcommands.
 897
 898 2019-07-03  Pedro Alves  <palves@redhat.com>
 899
 900         * maint-test-settings.c: Fix file's intro comment.  Replace all
 901         references to "test-options" with references to "test-settings",
 902         in comments.
 903
 904 2019-07-03  Pedro Alves  <palves@redhat.com>
 905
 906         * maint-test-settings.c (maintenance_test_settings_xxx)
 907         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 908         New.
 909         (maintenance_test_settings_enums): Use them.
 910         (maintenance_test_settings_enum): Default to
 911         maintenance_test_settings_xxx.
 912         (_initialize_maint_test_settings): Initialize
 913         MAINTENANCE_TEST_SETTINGS_FILENAME.
 914
 915 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 916
 917         * breakpoint.h (remove_breakpoints_inf): Change return type to
 918         void, move function documentation here.
 919         * breakpoint.c (remove_breakpoints_inf): Change return type to
 920         void, move function documentation to header.
 921
 922 2019-07-02  Pedro Alves  <palves@redhat.com>
 923
 924         * NEWS (Completion improvements): Mention "info threads".
 925         * thread.c (struct info_threads_opts, info_threads_option_defs)
 926         (make_info_threads_options_def_group): New.
 927         (info_threads_command): Use gdb::option::process_options.
 928         (info_threads_command_completer): New.
 929         (_initialize_thread): Use gdb::option::build_help to build the
 930         help text for "info threads".
 931
 932 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 933
 934         * defs.h (generic_load): Move from here...
 935         * symfile.h (generic_load): ... to here.  Rename name parameter
 936         to args.
 937         * symfile.c (generic_load): Add comment.
 938
 939 2019-07-01  Tom Tromey  <tromey@adacore.com>
 940
 941         * dwarf2read.c
 942         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 943         declaration of without_params.  Fix formatting.
 944
 945 2019-07-01  Tom Tromey  <tromey@adacore.com>
 946
 947         * ada-exp.y (find_primitive_type): Update.
 948         * ada-lang.h (ada_lookup_symbol): Update.
 949         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 950         parameter.
 951         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 952
 953 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 954
 955         PR breakpoints/24541
 956         * gdbarch.c: Regenerate.
 957         * gdbarch.h: Regenerate.
 958         * gdbarch.sh: Add 'stap_adjust_register'.
 959         * i386-tdep.c: Include '<unordered_set>'.
 960         (i386_stap_adjust_register): New function.
 961         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 962         * stap-probe.c (stap_parse_register_operand): Call
 963         'gdbarch_stap_adjust_register'.
 964
 965 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 966
 967         PR python/24742
 968         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 969         * python/python.c (do_start_initialization): Use 'xmalloc'
 970         instead of 'PyMem_Malloc'.
 971
 972 2019-06-28  Tom Tromey  <tromey@adacore.com>
 973
 974         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 975         for Ada.
 976
 977 2019-06-27  Tom Tromey  <tromey@adacore.com>
 978
 979         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 980         objfile_key.
 981         (arm_find_mapping_symbol, arm_record_special_symbol)
 982         (_initialize_arm_tdep): Update.
 983         (arm_objfile_data_free): Remove.
 984
 985 2019-06-27  Tom Tromey  <tromey@adacore.com>
 986
 987         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 988         to cp_print_static_field.
 989
 990 2019-06-26  Tom Tromey  <tromey@adacore.com>
 991
 992         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 993         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 994         declare.
 995
 996 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 997
 998         * features/aarch64-core.c (create_feature_aarch64_core):
 999         Regenerate.
1000         * features/aarch64-core.xml: Add cpsr flags.
1001
1002 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1003
1004         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1005         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1006
1007 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1008
1009         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1010         field.
1011         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1012         use.
1013         (arm_record_special_symbol): Don't insert new symbol in sorted
1014         position, push it at the end.
1015
1016 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1017
1018         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1019         (arm_mapping_symbol_s): Remove.
1020         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1021         (arm_mapping_symbol_vec): New typedef.
1022         (struct arm_per_objfile): Add constructor.
1023         <section_maps>: Change type to
1024         std::unique_ptr<arm_mapping_symbol_vec[]>.
1025         (arm_compare_mapping_symbols): Remove.
1026         (arm_find_mapping_symbol): Adjust to section_maps type change.
1027         (arm_objfile_data_free): Call delete on arm_per_objfile.
1028         (arm_record_special_symbol): Adjust to section_maps type change.
1029         Allocate arm_per_objfile with new.
1030
1031 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1032
1033         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1034         with the command prefix.
1035
1036 2019-06-25  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1039         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1040
1041 2019-06-25  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1044         type.
1045         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1046         protected.
1047
1048 2019-06-25  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-winsource.c
1051         (tui_source_window_base::set_is_exec_point_at): Add check against
1052         LOA_ADDRESS.
1053
1054 2019-06-25  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-source.c (tui_set_source_content): Don't check before
1057         xfree.
1058         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1059
1060 2019-06-25  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-winsource.h (tui_update_source_window_as_is)
1063         (tui_alloc_source_buffer, tui_line_is_displayed)
1064         (tui_addr_is_displayed): Change type of win_info.
1065         * tui/tui-winsource.c (tui_update_source_window_as_is)
1066         (tui_clear_source_content, tui_show_source_line)
1067         (tui_show_source_content, tui_source_window_base::refill)
1068         (tui_source_window_base::set_is_exec_point_at)
1069         (tui_source_window_base::set_is_exec_point_at)
1070         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1071         (tui_alloc_source_buffer, tui_line_is_displayed)
1072         (tui_addr_is_displayed): Change type of win_info.  Update.
1073         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1074         (tui_source_window_base::do_make_visible_with_new_height):
1075         Update.
1076         * tui/tui-source.c (tui_set_source_content)
1077         (tui_set_source_content_nil)
1078         (tui_source_window::do_scroll_vertical): Update.
1079         * tui/tui-layout.c (show_layout): Update.
1080         * tui/tui-disasm.c (tui_set_disassem_content)
1081         (tui_disasm_window::do_scroll_vertical): Update.
1082         * tui/tui-data.h (tui_win_content): Remove.
1083         (struct tui_gen_win_info) <content, content_size>: Remove.
1084         (struct tui_source_element): Add initializers and destructor.
1085         (union tui_which_element, struct tui_win_element): Remove.
1086         (struct tui_source_window_base) <content>: New field.
1087         (struct tui_data_window): Remove destructor.
1088         (tui_alloc_content, tui_free_win_content)
1089         (tui_free_all_source_wins_content): Don't declare.
1090         * tui/tui-data.c (tui_initialize_static_data): Update.
1091         (init_content_element, tui_alloc_content): Remove.
1092         (~tui_gen_win_info): Update.
1093         (~tui_data_window, tui_free_all_source_wins_content)
1094         (tui_free_win_content, free_content, free_content_elements):
1095         Remove.
1096
1097 2019-06-25  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-winsource.h (tui_clear_source_content)
1100         (tui_erase_source_content, tui_show_source_content): Change type
1101         of win_info.
1102         * tui/tui-winsource.c (tui_clear_source_content)
1103         (tui_erase_source_content, tui_show_source_content): Change type
1104         of win_info.
1105         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1106         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1107         win_info.
1108         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1109         win_info.
1110         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1111
1112 2019-06-25  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-winsource.c (tui_clear_source_content)
1115         (tui_source_window_base::set_is_exec_point_at): Update.
1116         * tui/tui-source.c (tui_set_source_content_nil): Update.
1117         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1118         a bool.
1119         * tui/tui-data.c (init_content_element): Update.
1120
1121 2019-06-25  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1124         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1125         * tui/tui-layout.c (init_and_make_win): Update.
1126         * tui/tui.h (enum tui_win_type): Update.
1127         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1128         tui_win_is_auxillary.
1129         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1130         tui_win_is_auxillary.
1131
1132 2019-06-25  Tom Tromey  <tom@tromey.com>
1133
1134         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1135         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1136         (tui_delete_data_content_windows, tui_display_all_data)
1137         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1138         Update.
1139         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1140         * tui/tui-regs.c (tui_last_regs_line_no)
1141         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1142         (tui_show_registers): Update.
1143         (tui_show_register_group): Return void.  Update.
1144         (tui_display_registers_from, tui_display_reg_element_at_line)
1145         (tui_display_registers_from_line, tui_check_register_values):
1146         Update.
1147         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1148         member.
1149         (struct tui_data_window) <regs_content>: Now a std::vector.
1150         <regs_content_count>: Remove.
1151         (tui_add_content_elements, tui_free_data_content): Don't declare.
1152         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1153         (init_content_element): Remove DATA_WIN case.  Add assert.
1154         (tui_add_content_elements): Remove.
1155         (tui_data_window): Update.
1156         (tui_free_data_content): Remove.
1157         (free_content_elements): Remove DATA_WIN case.
1158
1159 2019-06-25  Tom Tromey  <tom@tromey.com>
1160
1161         * tui/tui-data.c (tui_data_item_window): Update.
1162         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1163         * tui/tui-windata.c (tui_display_all_data)
1164         (tui_display_data_from_line): Update.
1165         (tui_check_data_values): Remove.
1166         * tui/tui-regs.c (tui_show_register_group)
1167         (tui_display_reg_element_at_line): Update.
1168         * tui/tui-hooks.c (tui_register_changed)
1169         (tui_refresh_frame_and_register_information): Call
1170         tui_check_register_values.
1171         * tui/tui-data.h (struct tui_data_window) <data_content,
1172         data_content_count, data_type>: Remove.
1173         (enum tui_data_type): Remove.
1174
1175         * tui/tui-data.c (tui_data_window::clear_detail)
1176         (~tui_data_window): Update.
1177
1178 2019-06-25  Tom Tromey  <tom@tromey.com>
1179
1180         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1181         declare.
1182         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1183         Rename from tui_first_data_item_displayed.  Update.
1184         (tui_data_window::refresh_all)
1185         (tui_data_window::do_scroll_vertical): Update.
1186         * tui/tui-data.h (struct tui_data_window)
1187         <first_data_item_displayed>: Declare new method.
1188
1189 2019-06-25  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1192         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1193         contents...
1194         (tui_initialize_static_data): ...here.
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1199         (tui_display_registers_from, tui_check_register_values): Update.
1200         (tui_display_register): Remove win_info parameter; update.
1201         (tui_get_register): Change type of parameters.
1202         * tui/tui-data.h (struct tui_data_element): Remove.
1203         (union tui_which_element) <data>: Remove.
1204         <data_window>: Change type.
1205         (struct tui_data_item_window): New.
1206         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1207         case.  Add assert.
1208         (~tui_data_item_window): New destructor.
1209         (free_content_elements): Remove DATA_ITEM_WIN case.
1210
1211 2019-06-25  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1214         Remove.
1215
1216 2019-06-25  Tom Tromey  <tom@tromey.com>
1217
1218         * tui/tui-data.h (struct tui_command_element): Remove.
1219         (union tui_which_element) <command>: Remove.
1220         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1221         assert.
1222         (free_content_elements): Remove CMD_WIN case.
1223
1224 2019-06-25  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-layout.c (tui_set_layout): Update.
1227         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1228         * tui/tui-data.c (layout_def): Update.
1229
1230 2019-06-25  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1233         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1234         (tui_source_window_base::set_new_height): Update.
1235         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1236         Update.
1237         (tui_set_locator_fullname, tui_set_locator_info)
1238         (tui_show_frame_info): Update.
1239         * tui/tui-source.c (tui_set_source_content)
1240         (tui_source_is_displayed): Update.
1241         * tui/tui-layout.c (show_source_disasm_command, show_data)
1242         (show_source_or_disasm_and_command): Update.
1243         * tui/tui-disasm.c (tui_set_disassem_content)
1244         (tui_get_begin_asm_address): Update.
1245         * tui/tui-data.h (struct tui_locator_element): Remove.
1246         (union tui_which_element) <locator>: Remove.
1247         (struct tui_locator_window): New.
1248         (tui_locator_win_info_ptr): Change return type.
1249         * tui/tui-data.c (_locator): Change type.
1250         (tui_locator_win_info_ptr): Change return type.
1251         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1252         (tui_alloc_content): Add assert.
1253
1254 2019-06-25  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui-winsource.c
1257         (tui_exec_info_window::maybe_allocate_content): New method.
1258         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1259         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1260         (make_source_or_disasm_window): Add cast.
1261         * tui/tui-data.h (union tui_which_element) <simple_string>:
1262         Remove.
1263         (struct tui_source_info): New.
1264         (struct tui_source_window_base) <execution_info>: Change type.
1265         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1266         case, and add assert.
1267         (tui_alloc_content): Add assert.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1272         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1273         * tui/tui-data.c (tui_alloc_win_info): Remove.
1274
1275 2019-06-25  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1278         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1279         can_highlight.
1280
1281 2019-06-25  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1284         make_visible_with_new_height method.
1285         (tui_win_info::make_visible_with_new_height): New method.
1286         (tui_source_window_base::do_make_visible_with_new_height)
1287         (tui_data_window::do_make_visible_with_new_height)
1288         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1289         (make_visible_with_new_height): Remove.
1290         (tui_resize_all, tui_adjust_win_heights): Use
1291         make_visible_with_new_height method.
1292         * tui/tui-data.h (struct tui_win_info)
1293         <do_make_visible_with_new_height, make_visible_with_new_height>:
1294         New methods.
1295         (struct tui_source_window_base, struct tui_data_window)
1296         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1297         methods.
1298
1299 2019-06-25  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1302         method.
1303         (update_tab_width): Call update_tab_width method.
1304         * tui/tui-data.h (struct tui_win_info)
1305         (struct tui_source_window_base) <update_tab_width>: New methods.
1306
1307 2019-06-25  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1310         parameter.
1311         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1312         parameter.
1313         (tui_gen_win_info::make_visible): Update.
1314         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1315         parameter.
1316         * tui/tui-data.h (enum tui_box): New enum.
1317         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1318
1319 2019-06-25  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1322         init_and_make_win for EXEC_INFO_WIN.
1323         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1324         longer inline.
1325         (struct tui_win_info) <~tui_win_info>: Inline.
1326         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1327         Don't declare.
1328         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1329         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1330         Remove.
1331         (tui_initialize_static_data): Update.
1332         (~tui_gen_win_info): Handle more cleanup here.
1333         (~tui_source_window_base): Delete "execution_info".
1334         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1335
1336 2019-06-25  Tom Tromey  <tom@tromey.com>
1337
1338         * tui/tui-layout.c (make_command_window): Don't set
1339         can_highlight.
1340         (show_source_disasm_command): Call the reset method.
1341         (show_data): Don't set can_highlight.  Call the reset method.
1342         (tui_gen_win_info::reset): Rename from init_gen_win_info
1343         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1344         (show_source_or_disasm_and_command): Call the reset method.
1345         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1346         (struct tui_cmd_window): Set can_highlight.
1347
1348 2019-06-25  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1351         from make_visible.
1352         (tui_make_visible, tui_make_invisible): Rewrite.
1353         (tui_win_info::make_visible): Remove.
1354         (tui_source_window_base::make_visible): Update.
1355         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1356         method.  Moved from...
1357         (struct tui_win_info) <make_visible>: ...here.
1358
1359 2019-06-25  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-winsource.c
1362         (tui_source_window_base::do_scroll_horizontal): Remove direction
1363         parameter.
1364         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1365         direction parameter.
1366         * tui/tui-win.c (tui_win_info::forward_scroll)
1367         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1368         (tui_win_info::right_scroll): Update.
1369         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1370         direction parameter.
1371         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1372         direction parameter.
1373         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1374         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1375         Remove direction parameter.
1376         (struct tui_source_window_base, struct tui_source_window)
1377         (struct tui_disasm_window, struct tui_data_window)
1378         (struct tui_cmd_window): Update.
1379
1380 2019-06-25  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-winsource.h (tui_set_exec_info_content)
1383         (tui_show_exec_info_content, tui_erase_exec_info_content)
1384         (tui_clear_exec_info_content, tui_update_exec_info): Change
1385         argument to tui_source_window_base.
1386         * tui/tui-winsource.c (tui_set_exec_info_content)
1387         (tui_show_exec_info_content, tui_erase_exec_info_content)
1388         (tui_clear_exec_info_content, tui_update_exec_info): Change
1389         argument to tui_source_window_base.
1390
1391 2019-06-25  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1394         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1395
1396 2019-06-25  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1399         check.
1400
1401 2019-06-25  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1404         type to void.
1405         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1406         type to void.
1407         * tui/tui-source.c (tui_set_source_content): Update.
1408         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1409
1410 2019-06-25  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-win.c (window_name_completer, tui_set_focus)
1413         (tui_all_windows_info): Use name method.
1414         * tui/tui-data.h (struct tui_gen_win_info)
1415         (struct tui_source_window, struct tui_disasm_window)
1416         (struct tui_data_window, struct tui_cmd_window) <name>: New
1417         method.
1418         (tui_win_name): Don't declare.
1419         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1420         (tui_win_name): Remove.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-winsource.h (tui_update_source_window)
1425         (tui_update_source_window_as_is): Change parameter type.
1426         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1427         to be a tui_source_window_base.
1428         (tui_update_source_window_as_is): Likewise.
1429         * tui/tui-win.c (make_visible_with_new_height): Update.
1430
1431 2019-06-25  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-winsource.c (tui_erase_source_content)
1434         (tui_show_source_content, tui_show_exec_info_content)
1435         (tui_erase_exec_info_content): Use refresh_window method.
1436         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1437         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1438         from tui_refresh_win.
1439         (tui_data_window::refresh_window): New method.
1440         (tui_win_info::refresh, tui_source_window_base::refresh)
1441         (tui_refresh_all): Use refresh_window method.
1442         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1443         method.
1444         * tui/tui-regs.c (tui_display_register): Call refresh_window
1445         method.
1446         * tui/tui-layout.c (show_source_disasm_command)
1447         (show_source_or_disasm_and_command): Call refresh_window method.
1448         * tui/tui-data.h (struct tui_gen_win_info)
1449         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1450         New method.
1451
1452 2019-06-25  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui.c (tui_rl_other_window, tui_enable)
1455         (tui_is_window_visible, tui_get_command_dimension): Update.
1456         * tui/tui-winsource.c (tui_update_source_window_as_is)
1457         (tui_clear_source_content, tui_erase_source_content)
1458         (tui_show_source_line, tui_source_window_base::refill)
1459         (tui_source_window_base::do_scroll_horizontal)
1460         (tui_source_window_base::set_is_exec_point_at)
1461         (tui_update_breakpoint_info, tui_set_exec_info_content)
1462         (tui_alloc_source_buffer, tui_line_is_displayed)
1463         (tui_addr_is_displayed): Update.
1464         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1465         (tui_check_and_display_highlight_if_needed)
1466         (tui_win_info::make_visible, tui_win_info::refresh)
1467         (tui_refresh_all): Update.
1468         * tui/tui-windata.c (tui_first_data_item_displayed)
1469         (tui_delete_data_content_windows, tui_erase_data_content)
1470         (tui_display_all_data, tui_data_window::refresh_all)
1471         (tui_check_data_values): Update.
1472         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1473         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1474         (tui_win_info::backward_scroll, tui_refresh_all_win)
1475         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1476         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1477         (tui_source_window_base::set_new_height)
1478         (tui_data_window::set_new_height)
1479         (make_invisible_and_set_new_height)
1480         (make_visible_with_new_height, new_height_ok)
1481         (parse_scrolling_args): Update.
1482         * tui/tui-stack.c (tui_show_frame_info): Update.
1483         * tui/tui-source.c (tui_set_source_content)
1484         (tui_set_source_content_nil, tui_source_is_displayed)
1485         (tui_source_window::do_scroll_vertical): Update.
1486         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1487         (tui_display_registers_from, tui_display_reg_element_at_line)
1488         (tui_check_register_values, tui_reg_command): Update.
1489         * tui/tui-layout.c (tui_default_win_height)
1490         (show_source_disasm_command, show_data, init_and_make_win)
1491         (show_source_or_disasm_and_command): Update.
1492         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1493         (tui_redisplay_readline, tui_mld_flush)
1494         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1495         (tui_getc): Update.
1496         * tui/tui-disasm.c (tui_set_disassem_content)
1497         (tui_disasm_window::do_scroll_vertical): Update.
1498         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1499         Now virtual.
1500         (struct tui_win_info): Derive from tui_gen_win_info.
1501         <~tui_win_info>: Mark as override.
1502         <generic>: Remove member.
1503         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1504         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1505         (~tui_data_window, ~tui_win_info)
1506         (tui_free_all_source_wins_content): Update.
1507         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1508
1509 2019-06-25  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-layout.c (init_and_make_win): Use new.
1512         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1513         destructor, initializers.
1514         (tui_alloc_generic_win_info): Don't declare.
1515         * tui/tui-data.c (_locator): Add argument to constructor.
1516         (source_win, disasm_win): New globals.
1517         (exec_info): Remove.
1518         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1519         Update.
1520         (tui_alloc_generic_win_info): Remove.
1521         (init_content_element): Use new.
1522         (tui_win_info::tui_win_info): Update.
1523         (free_content_elements) <case DATA_WIN>: Use delete.
1524
1525 2019-06-25  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1528         * tui/tui-windata.c (tui_first_data_item_displayed)
1529         (tui_delete_data_content_windows): Update.
1530         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1531         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1532         (tui_display_registers_from, tui_check_register_values): Update.
1533         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1534         pointer.
1535         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1536         window.
1537         (tui_free_data_content): Update.
1538         (free_content_elements) <case DATA_WIN>: Free the window.
1539
1540 2019-06-25  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1543         Update.
1544         * tui/tui-layout.c (make_command_window)
1545         (show_source_disasm_command, show_data, init_and_make_win)
1546         (show_source_or_disasm_and_command): Update.
1547         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1548         method.
1549         <can_highight, is_highlighted>: Now bool.
1550         (tui_set_win_highlight): Don't declare.
1551         * tui/tui-data.c (tui_set_win_highlight): Remove.
1552
1553 2019-06-25  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-wingeneral.c (make_visible): Remove check of window
1556         type.
1557
1558 2019-06-25  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-win.c (tui_win_info::max_height)
1561         (tui_cmd_window::max_height): New methods.
1562         (new_height_ok): Call max_height.
1563         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1564         <max_height>: New method.
1565
1566 2019-06-25  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-win.c (tui_source_window_base::set_new_height)
1569         (tui_data_window::set_new_height): New methods.
1570         (make_invisible_and_set_new_height): Call set_new_height method.
1571         * tui/tui-data.h (struct tui_win_info)
1572         (struct tui_source_window_base, struct tui_data_window)
1573         <set_new_height>: New method.
1574
1575 2019-06-25  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1578         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1579         tui_refresh_data_win.
1580         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1581         method.
1582         (tui_refresh_all_win): Call the refresh_all method.
1583         (tui_set_focus): Likewise.
1584         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1585         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1586         Likewise.
1587
1588 2019-06-25  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-winsource.h (tui_refill_source_window)
1591         (tui_set_is_exec_point_at): Don't declare.
1592         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1593         (tui_source_window_base::refill): Rename from
1594         tui_refill_source_window.
1595         (tui_source_window_base::do_scroll_horizontal): Update.
1596         (tui_source_window_base::set_is_exec_point_at): Rename from
1597         tui_set_is_exec_point_at.
1598         (tui_update_all_breakpoint_info): Update.
1599         * tui/tui-stack.c (tui_show_frame_info): Update.
1600         * tui/tui-layout.c (show_data): Add cast.
1601         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1602         * tui/tui-data.h (struct tui_source_window_base) <refill,
1603         set_is_exec_point_at>: New methods.
1604         (tui_source_windows, tui_add_to_source_windows): Update types.
1605         (tui_add_to_source_windows): Remove redundant declaration.
1606         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1607         (tui_source_windows): Change return type.
1608         (tui_clear_source_windows_detail): Update.
1609         (tui_add_to_source_windows): Change type of parameter.
1610         (tui_free_all_source_wins_content): Update.
1611
1612 2019-06-25  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-wingeneral.c (tui_win_info::refresh)
1615         (tui_source_window_base::refresh): New methods.
1616         (tui_refresh_all): Call the refresh method.
1617         * tui/tui-data.h (struct tui_win_info)
1618         (struct tui_source_window_base) <refresh>: New method.
1619
1620 2019-06-25  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui.h (tui_is_window_visible): Return bool.
1623         * tui/tui.c (tui_is_window_visible): Return bool.
1624         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1625         (tui_make_visible, tui_make_invisible)
1626         (tui_win_info::make_visible)
1627         (tui_source_window_base::make_visible, make_all_visible)
1628         (tui_make_all_visible, tui_make_all_invisible): Update.
1629         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1630         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1631         bool.
1632         (struct tui_win_info, struct tui_source_window_base)
1633         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1634         * tui/tui-data.c (tui_init_generic_part): Update.
1635
1636 2019-06-25  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1639         (tui_source_window_base::make_visible): New methods.
1640         (make_all_visible): Make method call.
1641         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1642         (struct tui_source_window_base, struct tui_cmd_window): Override
1643         make_visible.
1644         (tui_win_is_source_type): Don't declare.
1645         * tui/tui-data.c (tui_win_is_source_type): Remove.
1646
1647 2019-06-25  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1650         NULL check.
1651
1652 2019-06-25  Tom Tromey  <tom@tromey.com>
1653
1654         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1655         Inline constructor.  Add initializers for members.
1656         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1657         constructors; now inline in class.
1658
1659 2019-06-25  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-regs.c (tui_show_registers): Update.
1662         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1663         bool.
1664         * tui/tui-data.c (tui_data_window::clear_detail)
1665         (tui_data_window): Update.
1666
1667 2019-06-25  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-windata.c (tui_display_all_data)
1670         (tui_display_data_from_line, tui_display_data_from)
1671         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1672         Update.
1673         * tui/tui-regs.c (tui_last_regs_line_no)
1674         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1675         (tui_show_registers, tui_show_register_group)
1676         (tui_display_registers_from, tui_display_reg_element_at_line)
1677         (tui_display_registers_from_line, tui_check_register_values)
1678         (tui_reg_next, tui_reg_prev): Update.
1679         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1680         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1681         tui_data_window.
1682         (struct tui_win_info) <detail>: Remove.  Add new fields from
1683         tui_data_info.
1684         (TUI_DATA_WIN): Add cast.
1685         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1686         (~tui_data_window): Simplify.
1687
1688 2019-06-25  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-layout.c (show_source_disasm_command)
1691         (show_source_or_disasm_and_command): Update.
1692         * tui/tui-io.c (update_cmdwin_start_line)
1693         (tui_redisplay_readline): Update.
1694         * tui/tui-data.h (struct tui_command_info): Remove.
1695         (struct tui_win_info) <detail>: Remove command_info member.
1696         (struct tui_data_window) <start_line>: New member, from
1697         tui_command_info.
1698         (TUI_CMD_WIN): Add casts.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-winsource.c (tui_update_source_window)
1703         (tui_refill_source_window)
1704         (tui_source_window_base::do_scroll_horizontal)
1705         (tui_update_breakpoint_info, tui_set_exec_info_content)
1706         (tui_show_exec_info_content, tui_erase_exec_info_content)
1707         (tui_clear_exec_info_content): Update.
1708         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1709         Update.
1710         * tui/tui-win.c (make_invisible_and_set_new_height)
1711         (make_visible_with_new_height): Update.
1712         * tui/tui-source.c (tui_set_source_content)
1713         (tui_show_symtab_source): Update.
1714         * tui/tui-layout.c (extract_display_start_addr)
1715         (show_source_disasm_command, show_data)
1716         (make_source_or_disasm_window)
1717         (show_source_or_disasm_and_command): Update.
1718         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1719         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1720         "gdbarch".
1721         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1722         to tui_source_window_base.
1723         (struct tui_win_info) <detail>: Remove source_info member.
1724         (struct tui_source_window_base) <has_locator>: Inline.
1725         Move contents from tui_source_info; rename has_locator member to
1726         m_has_locator.
1727         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1728         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1729         header file.
1730         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1731         Simplify.
1732         (tui_free_all_source_wins_content): Cast to
1733         tui_source_window_base.
1734
1735 2019-06-25  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-win.c (make_invisible_and_set_new_height)
1738         (make_visible_with_new_height): Call has_locator method.
1739         * tui/tui-layout.c (show_source_disasm_command, show_data)
1740         (show_source_or_disasm_and_command): Update for bool change.
1741         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1742         (tui_win_info) <has_locator>: New method.
1743         (struct tui_source_window_base) <has_locator>: New method.
1744         (tui_win_has_locator): Don't declare.
1745         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1746         from tui_win_has_locator.
1747         (tui_source_window_base): Use false, not FALSE.
1748
1749 2019-06-25  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1752         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1753         clear_detail method directly.
1754         (tui_clear_win_detail): Remove.
1755
1756 2019-06-25  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1759         "this", not TUI_DISASM_WIN.
1760
1761 2019-06-25  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1764         declare.
1765         * tui/tui-winsource.c
1766         (tui_source_window_base::do_scroll_horizontal): Rename from
1767         tui_horizontal_source_scroll.
1768         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1769         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1770         from tui_vertical_data_scroll.
1771         * tui/tui-win.h (tui_scroll): Don't declare.
1772         * tui/tui-win.c (tui_win_info::forward_scroll)
1773         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1774         (tui_win_info::right_scroll): Rename and update.
1775         (tui_scroll_forward_command, tui_scroll_backward_command)
1776         (tui_scroll_left_command, tui_scroll_right_command): Update.
1777         (tui_scroll): Remove.
1778         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1779         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1780         from tui_vertical_source_scroll.
1781         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1782         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1783         from tui_vertical_disassem_scroll.
1784         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1785         do_scroll_horizontal>: New methods.
1786         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1787         Likewise.
1788         (struct tui_source_window_base): Add do_scroll_horizontal.
1789         (struct tui_source_window, struct tui_disasm_window): Add
1790         do_scroll_vertical.
1791         (struct tui_data_window, struct tui_cmd_window): Add
1792         do_scroll_horizontal and do_scroll_vertical.
1793         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1794
1795 2019-06-25  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-data.h (struct tui_source_window_base): New struct.
1798         (struct tui_source_window): Derive from tui_source_window_base.
1799         (struct tui_disasm_window): New struct.
1800         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1801         from tui_source_window::clear_detail.
1802         (tui_source_window_base): Rename from tui_source_window.
1803         (~tui_source_window_base): Rename from ~tui_source_window.
1804         (tui_alloc_win_info): Create a tui_disasm_window.
1805
1806 2019-06-25  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-data.h (struct tui_source_window)
1809         (struct tui_data_window): Declare destructors.
1810         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1811         destructors.
1812         (tui_win_info): Simplify.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-winsource.c (tui_display_main)
1817         (tui_update_source_windows_with_addr)
1818         (tui_update_all_breakpoint_info): Update.
1819         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1820         (new_height_ok, parse_scrolling_args): Update.
1821         * tui/tui-stack.c (tui_show_frame_info): Update.
1822         * tui/tui-data.h (struct tui_list): Remove.
1823         (tui_source_windows): Return a reference to a std::vector.
1824         * tui/tui-data.c (source_windows): Now a std::vector.
1825         (tui_source_windows): Change return type.
1826         (tui_clear_source_windows): Rewrite.
1827         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1828         (tui_free_all_source_wins_content): Rewrite.
1829
1830 2019-06-25  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1833         (struct tui_data_window, struct tui_cmd_window): Declare
1834         clear_detail method.
1835         * tui/tui-data.c (tui_source_window::clear_detail)
1836         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1837         methods.
1838         (tui_clear_win_detail): Simplify.
1839
1840 2019-06-25  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-layout.c (make_source_window, make_disasm_window)
1843         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1844         Return the new window.
1845         (show_source_disasm_command, show_data)
1846         (show_source_or_disasm_and_command): Update.
1847
1848 2019-06-25  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1851         parameter.  Return the new window.
1852         (show_source_disasm_command): Update and remove NULL check.
1853         (show_source_or_disasm_and_command): Update.
1854
1855 2019-06-25  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1858
1859 2019-06-25  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-data.h (struct tui_win_info): Make constructor
1862         protected.  Make destructor virtual.  Add initializers.
1863         (tui_source_window, tui_data_window, tui_cmd_window): New
1864         classes.
1865         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1866         constructor.  Add "type" parameter.
1867         (tui_source_window, tui_data_window, tui_cmd_window): New
1868         constructors.
1869         (tui_alloc_win_info): Instantiate the appropriate subclass.
1870
1871 2019-06-25  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-win.c (tui_resize_all): Use delete.
1874         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1875         destructor.
1876         (tui_free_window): Don't declare.
1877         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1878         Update.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-data.h (struct tui_win_info): Add constructor.
1883         * tui/tui-data.c (tui_alloc_win_info): Use new.
1884         (tui_free_window): Use delete.
1885
1886 2019-06-22  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1889         declare.
1890         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1891
1892 2019-06-22  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1895         declare.
1896         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1897
1898 2019-06-22  Tom de Vries  <tdevries@suse.de>
1899
1900         * dwarf2read.c (create_addrmap_from_aranges)
1901         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1902         instead of '%zu'.
1903
1904 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1905
1906         * dwarf2read.h (dwarf2_section_info_def): Remove.
1907         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1908         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1909         std::vector<dwarf2_section_info>.
1910         (struct dwo_file) <~dwo_file>: Remove.
1911         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1912         types field.
1913         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1914         (dwarf2_read_debug_names): Likewise.
1915         (create_debug_types_hash_table): Change parameter type to
1916         array_view, adjust code accordingly.
1917         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1918         (partial_die_info::fixup): Likewise.
1919         (determine_prefix): Likewise.
1920         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1921
1922 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1923
1924         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1925         gdb_bfd_ref_ptr.
1926         <~dwo_file>: Remove call to gdb_bfd_unref.
1927         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1928         gdb_bfd_ref_ptr::get.
1929
1930 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1931
1932         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1933         type to htab_up.
1934         * dwarf2read.c (struct dwo_file): Initialize fields.
1935         <~dwo_file>: New.
1936         (free_dwo_file): Remove, move content to ~dwo_file.
1937         (struct dwo_file_deleter): Remove.
1938         (dwo_file_up>: Remove custom deleter.
1939         (free_dwo_files): Remove.
1940         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1941         dwo_files.
1942         (process_skeletonless_type_units): Call unique_ptr::get.
1943         (allocate_dwo_file_hash_table): Add deleter to created hash
1944         table.  Change return type to htab_up.
1945         (lookup_dwo_file_slot): Don't memset dwo_file, call
1946         unique_ptr::get.
1947         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1948         (create_dwo_unit_in_dwp_v2): Likewise.
1949         (open_and_init_dwo_file): Likewise.
1950         (free_dwo_file_from_slot): Remove.
1951
1952 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1953
1954         * dwarf2read.h (struct dwarf2_section_info) <readin,
1955         is_virtual>: Change type to bool.
1956         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1957         true instead of 1.
1958
1959 2019-06-19  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-data.h (tui_init_content_element): Don't declare.
1962
1963 2019-06-19  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-data.h (tui_init_win_info): Don't declare.
1966
1967 2019-06-19  Tom de Vries  <tdevries@suse.de>
1968
1969         * dwarf2read.h (abstract_to_concrete): Change type to
1970         std::unordered_map<sect_offset, std::vector<sect_offset>,
1971         gdb::hash_enum<sect_offset>>.
1972
1973 2019-06-19  Tom Tromey  <tromey@adacore.com>
1974
1975         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1976         EVAL_AVOID_SIDE_EFFECTS specially.
1977
1978 2019-06-19  Tom Tromey  <tromey@adacore.com>
1979
1980         * source-cache.c (highlighter): New global.
1981         (source_cache::get_source_lines): Create a highlighter on demand.
1982
1983 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1984
1985         * defs.h (deprecated_interactive_hook): Delete declaration.
1986         * interps.c (clear_interpreter_hooks): Remove use of
1987         deprecated_interactive_hook.
1988         * top.c (deprecated_interactive_hook): Delete definition.
1989         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1990
1991 2019-06-18  Tom de Vries  <tdevries@suse.de>
1992
1993         PR gdb/24515
1994         * dwarf2read.h (abstract_to_concrete): Change type from
1995         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1996         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1997         * dwarf2read.c (read_variable): Update.
1998         (dwarf2_fetch_die_loc_sect_off): Update.
1999
2000 2019-06-17  Tom de Vries  <tdevries@suse.de>
2001
2002         PR gdb/24617
2003         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2004         accessing parent[parent_len - 1].
2005
2006 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2007
2008         PR gdb/24364
2009         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2010         call dtrace_process_dof with NULL dof.
2011
2012 2019-06-16  Tom de Vries  <tdevries@suse.de>
2013
2014         PR gdb/24445
2015         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2016
2017 2019-06-16  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2020         (make_all_visible): Use address of member.
2021
2022 2019-06-16  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2025         (tui_free_window, free_content, free_content_elements): Remove
2026         unnecessary cast.
2027         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2028         cast.
2029         * tui/tui-regs.c (tui_show_register_group)
2030         (tui_display_registers_from, tui_display_reg_element_at_line):
2031         Remove unnecessary cast.
2032
2033 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2034
2035         * linux-nat.c (normal_mask): Delete.
2036         (_initialize_linux_nat): Don't initialise normal_mask.
2037
2038 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2039
2040         PR gdb/24445
2041         * dwarf-index-write.h (write_psymtabs_to_index): Add
2042         dwz_basename parameter.
2043         * dwarf-index-write.c (write_gdbindex): Move file writing to
2044         write_gdbindex_1.  Change return type void.
2045         (assert_file_size): Move up, remove filename parameter.
2046         (write_gdbindex_1): New function.
2047         (write_debug_names): Change return type to void, call
2048         assert_file_size.
2049         (struct index_wip_file): New struct.
2050         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2051         file logic to index_wip_file.  Write index for dwz file if
2052         needed.
2053         (save_gdb_index_command): Pass basename of dwz file, if present.
2054         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2055         build-id of dwz file, if present.
2056         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2057         (dwarf2_get_dwz_file): Likewise.
2058         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2059         (dwarf2_get_dwz_file): Likewise.
2060
2061 2019-06-16  Tom Tromey  <tom@tromey.com>
2062
2063         * coffread.c (process_coff_symbol): Use xstrdup.
2064         * value.c (create_internalvar): Use xstrdup.
2065
2066 2019-06-16  Tom Tromey  <tom@tromey.com>
2067
2068         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2069         * breakpoint.c (stopin_command, stopat_command)
2070         (until_break_command, decode_location_default): Remove unnecessary
2071         cast.
2072         * utils.c (subset_compare): Remove unnecessary cast.
2073         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2074         cast.
2075         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2076         cast.
2077         * infcmd.c (path_command): Remove unnecessary cast.
2078         * coffread.c (decode_type): Remove unnecessary cast.
2079         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2080         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2081         * tui/tui-stack.c (tui_show_locator_content)
2082         (tui_show_frame_info): Remove unnecessary cast.
2083         * tui/tui-win.c (tui_scroll_forward_command)
2084         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2085         (parse_scrolling_args): Remove unnecessary cast.
2086         * tui/tui-data.c (init_win_info, tui_del_window)
2087         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2088         (free_content_elements): Remove unnecessary cast.
2089         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2090         unnecessary cast.
2091         * tui/tui-source.c (tui_set_source_content)
2092         (tui_vertical_source_scroll): Remove unnecessary cast.
2093         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2094         cast.
2095         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2096         * tui/tui-regs.c (tui_display_registers_from)
2097         (tui_display_register): Remove unnecessary cast.
2098         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2099         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2100         (make_visible): Remove unnecessary cast.
2101         * tui/tui-winsource.c (tui_erase_source_content)
2102         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2103         unnecessary cast.
2104         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2105         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2106         * stabsread.c (read_type, read_array_type, read_range_type):
2107         Remove unnecessary cast.
2108         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2109         (parse_symbol, parse_type, upgrade_type, parse_external)
2110         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2111         unnecessary cast.
2112         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2113
2114 2019-06-16  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-data.c (tui_alloc_generic_win_info)
2117         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2118         checks.
2119
2120 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2121             Andrew Burgess  <andrew.burgess@embecosm.com>
2122
2123         * f-typeprint.c (f_print_type): Don't return early for not
2124         associated or not allocated types.
2125         (f_type_print_varspec_suffix): Add print_rank parameter and print
2126         ranks of array types in case they dangling.
2127         (f_type_print_base): Add print_rank parameter.
2128
2129 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2130
2131         * NEWS: Mention new MI commands.
2132         * break-catch-throw.c (enum exception_event_kind): Move to
2133         breakpoint.h.
2134         (print_mention_exception_catchpoint): Output text as a single
2135         message.
2136         (catch_exception_command_1): Rename to...
2137         (catch_exception_event): ...this, make non-static, update header
2138         command, and change some parameter types.
2139         (catch_catch_command): Update for changes to
2140         catch_exception_command_1.
2141         (catch_throw_command): Likewise.
2142         (catch_rethrow_command): Likewise.
2143         * breakpoint.c (enum exception_event_kind): Delete.
2144         * breakpoint.h (enum exception_event_kind): Moved here from
2145         break-catch-throw.c.
2146         (catch_exception_event): Declare.
2147         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2148         (mi_cmd_catch_throw): New function.
2149         (mi_cmd_catch_rethrow): New function.
2150         (mi_cmd_catch_catch): New function.
2151         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2152         'catch-catch' entries.
2153         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2154         (mi_cmd_catch_rethrow): Declare.
2155         (mi_cmd_catch_catch): Declare.
2156
2157 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * annotate.c (annotate_source_line): Change return type to void,
2160         update implementation to match.
2161         * annotate.h (annotate_source_line): Change return type to void,
2162         update header comment.
2163         * stack.c (print_frame_info): Don't change what frame information
2164         is printed based on whether annotations are on or not.
2165
2166 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2169         (annotate_source): Make static.
2170         (annotate_source_line): Moved from source.c and renamed from
2171         identify_source_line.  Update the return type.
2172         * annotate.h (annotate_source): Delete declaration.
2173         (annotate_source_line): Declaration moved from source.h, and
2174         renamed from identify_source_line.  Return type updated.
2175         * source.c (identify_source_line): Moved to annotate.c and renamed
2176         to annotate_source_line.
2177         (info_line_command): Remove check of annotation_level.
2178         * source.h (identify_source_line): Move declaration to annotate.h
2179         and rename to annotate_source_line.
2180         * stack.c: Add 'annotate.h' include.
2181         (print_frame_info): Remove check of annotation_level before
2182         calling annotate_source_line.
2183
2184 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2185
2186         * source-cache.c (source_cache::get_plain_source_lines): Use
2187         open_source_file_with_line_charpos instead of just
2188         open_source_file, remove call to find_source_lines.
2189         (source_cache::get_source_lines): Likewise.
2190         * source.c (find_source_lines): Make static.
2191         (get_filename_and_charpos): Renamed into...
2192         (open_source_file_with_line_charpos): ..this along with changes to
2193         return a scoped_fd, and some other minor clean ups.
2194         (identify_source_line): Use open_source_file_with_line_charpos.
2195         (search_command_helper): Use open_source_file_with_line_charpos
2196         instead of just open_source_file, remove call to
2197         find_source_lines.
2198         * source.h (open_source_file_with_line_charpos): Declare new
2199         function.
2200         (find_source_lines): Delete declaration.
2201
2202 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * source.c (get_filename_and_charpos): Remove fullname
2205         parameter.
2206         (identify_source_line): Update call to get_filename_and_charpos.
2207
2208 2019-06-14  Tom Tromey  <tromey@adacore.com>
2209
2210         PR gdb/24502:
2211         * ui-style.h (skip_ansi_escape): Update comment.
2212         * ui-file.h (class no_terminal_escape_file): New class.
2213         * ui-file.c (no_terminal_escape_file::write)
2214         (no_terminal_escape_file::puts): New methods.
2215         * cli/cli-logging.c (handle_redirections): Use
2216         no_terminal_escape_file.
2217
2218 2019-06-14  Tom Tromey  <tromey@adacore.com>
2219
2220         * NEWS: Move convenience variable news above Python news.
2221
2222 2019-06-14  Tom Tromey  <tom@tromey.com>
2223
2224         * gnulib: Move directory to top-level.
2225         * configure.ac: Don't configure gnulib.
2226         * configure: Rebuild.
2227         * common/common-defs.h: Use new path to gnulib.
2228         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2229         (GNULIB_H): Remove.
2230         (INCGNU): Look in new gnulib location.
2231         (HFILES_NO_SRCDIR): Remove gnulib files.
2232         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2233         (generated_files): Remove GNULIB_H.
2234         ($(LIBGNU), all-lib): Remove targets.
2235         (distclean): Don't mention GNULIB_BUILDDIR.
2236         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2237
2238 2019-06-14  Tom Tromey  <tromey@adacore.com>
2239
2240         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2241         Warn if symbol file does not provide any symbols.
2242
2243 2019-06-14  Tom Tromey  <tromey@adacore.com>
2244
2245         * source.c (find_and_open_source): Respect basenames_may_differ.
2246
2247 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2248
2249         * annotate.c (annotate_breakpoints_invalid): Make use of
2250         scoped_restore_terminal_state.
2251         (annotate_frames_invalid): Likewise.
2252
2253 2019-06-14  Tom Tromey  <tromey@adacore.com>
2254
2255         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2256         allow assignment to an internalvar.
2257
2258 2019-06-14  Tom Tromey  <tromey@adacore.com>
2259
2260         * ada-lex.l: Allow "_" in attribute names.
2261
2262 2019-06-14  Tom Tromey  <tromey@adacore.com>
2263
2264         PR gdb/24653:
2265         * regcache.c (registers_changed): Don't call alloca.
2266         * top.c (execute_command): Don't call alloca.
2267
2268 2019-06-13  Pedro Alves  <palves@redhat.com>
2269
2270         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2271         'expression'.  When parsing an expression, error out if there's
2272         junk after "unlimited".
2273         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2274         (do_set_command): Adjust calls to is_unlimited_literal.
2275
2276 2019-06-13  Pedro Alves  <palves@redhat.com>
2277
2278         * compile/compile.c (make_compile_options_def_group): Add braces
2279         around array_view initializer.
2280         * thread.c (make_thread_apply_all_options_def_group)
2281         (make_thread_apply_all_options_def_group): Likewise.
2282
2283 2019-06-13  Pedro Alves  <palves@redhat.com>
2284
2285         * NEWS (New commands): Mention "maint test-options
2286         require-delimiter", "maint test-options unknown-is-error", "maint
2287         test-options unknown-is-operand" and "maint show
2288         test-options-completion-result".
2289         (New command options, command completion): New section.
2290         (Completion improvements): New section.
2291         Mention that you can abbreviate "unlimited".
2292
2293 2019-06-13  Pedro Alves  <palves@redhat.com>
2294
2295         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2296         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2297         * unittests/cli-utils-selftests.c (test_parse_flags)
2298         (test_parse_flags_qcs): Delete.
2299         (test_cli_utils): Don't call deleted functions.
2300
2301 2019-06-13  Pedro Alves  <palves@redhat.com>
2302
2303         * thread.c: Include "cli/cli-option.h".
2304         (tp_array_compar_ascending): Global.
2305         (tp_array_compar): Delete function.
2306         (tp_array_compar_ascending, tp_array_compar_descending): New
2307         functions.
2308         (ascending_option_def, qcs_flag_option_def)
2309         (thr_qcs_flags_option_defs)
2310         (make_thread_apply_all_options_def_group)
2311         (make_thread_apply_options_def_group): New.
2312         (thread_apply_all_command): Use gdb::option::process_options.
2313         (thread_apply_command_completer)
2314         (thread_apply_all_command_completer): New.
2315         (thread_apply_command): Use gdb::option::process_options.
2316         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2317         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2318         to generate help text of "thread apply".  Adjust "taas"'s help.
2319         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2320         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2321
2322 2019-06-13  Pedro Alves  <palves@redhat.com>
2323
2324         * thread.c (thread_apply_command): Check for invalid TID with
2325         isdigit instead of !isalpha.
2326
2327 2019-06-13  Pedro Alves  <palves@redhat.com>
2328
2329         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2330         (validate_flags_qcs): New.
2331         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2332         (validate_flags_qcs): Declare.
2333         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2334         (make_frame_apply_options_def_group): New.
2335         (frame_apply_command_count): Process options with
2336         gdb::option::process_options.
2337         (frame_apply_completer): New.
2338         (frame_apply_level_completer, frame_apply_all_completer)
2339         (frame_apply_completer): New.
2340         (_initialize_stack): Update help of "frame apply", "frame apply
2341         level", "frame apply all" and "faas" to mention supported options
2342         and install command completers.
2343         * stack.h (frame_apply_all_completer): Declare.
2344         * thread.c: Include "stack.h".
2345         (tfaas_command): Add "--".
2346         (_initialize_thread): Update help "tfaas" to mention supported
2347         options and install command completer.
2348
2349 2019-06-13  Pedro Alves  <palves@redhat.com>
2350
2351         * completer.c (complete_nested_command_line): New.
2352         (gdb_completion_word_break_characters_throw): Add assertion.
2353         * completer.h (complete_nested_command_line): Declare.
2354
2355 2019-06-13  Pedro Alves  <palves@redhat.com>
2356
2357         * stack.c (parse_backtrace_qualifiers): New.
2358         (backtrace_command): Use it.
2359         (backtrace_command_completer): Complete on qualifiers.
2360
2361 2019-06-13  Pedro Alves  <palves@redhat.com>
2362
2363         * frame.c: Include "cli/cli-option.h.
2364         (user_set_backtrace_options): New.
2365         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2366         Delete.
2367         (get_prev_frame): Adjust.
2368         (boolean_option_def, uinteger_option_def)
2369         (set_backtrace_option_defs): New.
2370         (_initialize_frame): Adjust and use
2371         gdb::option::add_setshow_cmds_for_options to install "set
2372         backtrace past-main" and "set backtrace past-entry".
2373         * frame.h: Include "cli/cli-option.h".
2374         (struct frame_print_options): Forward declare.
2375         (print_frame_arguments_all, print_frame_arguments_scalars)
2376         (print_frame_arguments_none): Declare.
2377         (print_entry_values): Delete declaration.
2378         (struct frame_print_options, user_frame_print_options): New.
2379         (struct set_backtrace_options): New.
2380         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2381         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2382         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2383         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2384         (list_args_or_locals): Add frame_print_options parameter.
2385         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2386         * python/py-framefilter.c (enumerate_args): Pass down
2387         USER_FRAME_PRINT_OPTIONS.
2388         * stack.c: Include "cli/cli-option.h".
2389         (print_frame_arguments_all, print_frame_arguments_scalars)
2390         (print_frame_arguments_none): Declare.
2391         (print_raw_frame_arguments, print_entry_values): Delete.
2392         (user_frame_print_options): New.
2393         (boolean_option_def, enum_option_def, frame_print_option_defs):
2394         New.
2395         (struct backtrace_cmd_options): New.
2396         (bt_flag_option_def): New.
2397         (backtrace_command_option_defs): New.
2398         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2399         (print_frame_arg, read_frame_arg, print_frame_args)
2400         (print_frame_info, print_frame): Add frame_print_options parameter
2401         and use it.
2402         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2403         (backtrace_command_1): Add frame_print_options and
2404         backtrace_cmd_options parameters and use them.
2405         (make_backtrace_options_def_group): New.
2406         (backtrace_command): Process command options with
2407         gdb::option::process_options.
2408         (backtrace_command_completer): New.
2409         (_initialize_stack): Extend "backtrace"'s help to mention
2410         supported options.  Install completer for "backtrace".
2411         Install some settings commands with add_setshow_cmds_for_options.
2412
2413 2019-06-13  Pedro Alves  <palves@redhat.com>
2414
2415         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2416         and that "set/show print raw frame-arguments" are now deprecated.
2417
2418         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2419         command.
2420         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2421         * stack.c (_initialize_stack): Install "set/show print
2422         raw-frame-arguments", and deprecate "set/show print raw
2423         frame-arguments".
2424         * valprint.c (_initialize_valprint): Deprecate "set/show print
2425         raw".
2426
2427 2019-06-13  Pedro Alves  <palves@redhat.com>
2428
2429         * compile/compile.c (struct compile_options): New.
2430         (compile_flag_option_def, compile_command_option_defs)
2431         (make_compile_options_def_group): New.
2432         (compile_file_command): Handle options with
2433         gdb::option::process_options.
2434         (compile_file_command_completer): New function.
2435         (compile_code_command): Handle options with
2436         gdb::option::process_options.
2437         (compile_code_command_completer): New function.
2438         (_initialize_compiler): Install completers for "compile code" and
2439         "compile file".  Mention available options in "compile code" and
2440         "compile code"'s help.
2441         * completer.c (advance_to_completion_word): New, factored out from
2442         ...
2443         (advance_to_expression_complete_word_point): ... this.
2444         (advance_to_filename_complete_word_point): New.
2445         * completer.h (advance_to_filename_complete_word_point): New
2446         declaration.
2447
2448 2019-06-13  Pedro Alves  <palves@redhat.com>
2449
2450         * compile/compile.c: Include "cli/cli-option.h".
2451         (compile_print_value): Scope data pointer is now a
2452         value_print_options pointer; adjust.
2453         (compile_print_command): Process options.  Scope data pointer is
2454         now a value_print_options pointer; adjust.
2455         (_initialize_compile): Update "compile print"'s help to include
2456         supported options.  Install a completer for "compile print".
2457         * cp-valprint.c (show_vtblprint, show_objectprint)
2458         (show_static_field_print): Delete.
2459         (_initialize_cp_valprint): Don't install "set print
2460         static-members", "set print vtbl", "set print object" here.
2461         * printcmd.c: Include "cli/cli-option.h" and
2462         "common/gdb_optional.h".
2463         (print_command_parse_format): Rework to fill in a
2464         value_print_options instead of a format_data.
2465         (print_value): Change parameter type from format_data pointer to
2466         value_print_options reference.  Adjust.
2467         (print_command_1): Process options.  Adjust to pass down a
2468         value_print_options.
2469         (print_command_completer): New.
2470         (_initialize_printcmd): Install print_command_completer as
2471         handle_brkchars completer for the "print" command.  Update
2472         "print"'s help to include supported options.
2473         * valprint.c: Include "cli/cli-option.h".
2474         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2475         here from cp-valprint.c.
2476         (boolean_option_def, uinteger_option_def)
2477         (value_print_option_defs, make_value_print_options_def_group):
2478         New.  Use gdb::option::add_setshow_cmds_for_options to install
2479         "set print elements", "set print null-stop", "set print repeats",
2480         "set print pretty", "set print union", "set print array", "set
2481         print address", "set print symbol", "set print array-indexes".
2482         * valprint.h: Include <string> and "cli/cli-option.h".
2483         (make_value_print_options_def_group): Declare.
2484         (print_value): Change parameter type from format_data pointer to
2485         value_print_options reference.
2486         (print_command_completer): Declare.
2487
2488 2019-06-13  Pedro Alves  <palves@redhat.com>
2489
2490         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2491         (COMMON_SFILES): Add maint-test-settings.c.
2492         * cli/cli-decode.c (boolean_enums): New global, factored out from
2493         ...
2494         (add_setshow_boolean_cmd): ... here.
2495         * cli/cli-decode.h (boolean_enums): Declare.
2496         * cli/cli-option.c: New file.
2497         * cli/cli-option.h: New file.
2498         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2499         factored out from ...
2500         (parse_cli_boolean_value(const char *)): ... this.
2501         (is_unlimited_literal): Change parameter type to pointer to
2502         pointer.  Adjust and advance ARG pointer.
2503         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2504         (parse_cli_var_enum): New, factored out from ...
2505         (do_set_command): ... this.  Adjust.
2506         * cli/cli-setshow.h (parse_cli_boolean_value)
2507         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2508         (parse_cli_var_enum): Declare.
2509         * cli/cli-utils.c: Include "cli/cli-option.h".
2510         (get_ulongest): New.
2511         * cli/cli-utils.h (get_ulongest): Declare.
2512         (check_for_argument): New overloads.
2513         * maint-test-options.c: New file.
2514
2515 2019-06-13  Pedro Alves  <palves@redhat.com>
2516
2517         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2518         parse a range if "-" is at the end of the string.
2519
2520 2019-06-13  Pedro Alves  <palves@redhat.com>
2521
2522         * cli/cli-setshow.c (parse_auto_binary_operation)
2523         (parse_cli_boolean_value): Don't allow "o".
2524
2525 2019-06-13  Pedro Alves  <palves@redhat.com>
2526
2527         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2528         * NEWS: Mention maint test-settings KIND.
2529         * maint-test-settings.c: New file.
2530
2531 2019-06-13  Pedro Alves  <palves@redhat.com>
2532
2533         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2534         completer.
2535         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2536         "set" completers.
2537
2538 2019-06-13  Pedro Alves  <palves@redhat.com>
2539
2540         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2541         after item.
2542
2543 2019-06-13  Pedro Alves  <palves@redhat.com>
2544
2545         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2546
2547 2019-06-13  Pedro Alves <palves@redhat.com>
2548
2549         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2550         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2551         call.
2552         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2553         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2554         calls.
2555         (check_for_argument): Skip spaces after argument.
2556
2557 2019-06-13  Pedro Alves  <palves@redhat.com>
2558
2559         * thread.c (thread_apply_command): Adjust TID parsing.
2560         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2561         detected before end of string.
2562         (tid_is_in_list): Error out if LIST is invalid.
2563
2564 2019-06-13  Pedro Alves  <palves@redhat.com>
2565
2566         * completer.c (complete_line_internal_1): Rewind completion word
2567         point.
2568         (completion_tracker::advance_custom_word_point_by): Change
2569         parameter type to int.
2570         * completer.h (completion_tracker::advance_custom_word_point_by):
2571         Likewise.
2572
2573 2019-06-13  Pedro Alves  <palves@redhat.com>
2574
2575         * completer.c (advance_to_completion_word): Handle delimiters.
2576
2577 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2578
2579         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2580
2581 2019-06-11  Tom Tromey  <tom@tromey.com>
2582
2583         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2584         (xmalloc_failed): Move to alloc.c.
2585         * alloc.c: New file.
2586         * Makefile.in (COMMON_SFILES): Add alloc.c.
2587
2588 2019-06-11  Tom Tromey  <tom@tromey.com>
2589
2590         * nat/linux-waitpid.c: Don't include server.h.
2591         (linux_debug): Remove.
2592         (my_waitpid): Update.
2593
2594 2019-06-11  Tom Tromey  <tromey@adacore.com>
2595
2596         * infcall.c (_initialize_infcall): Remove trailing newline from
2597         help.
2598         * user-regs.c (_initialize_user_regs): Remove trailing newline
2599         from help.
2600         * typeprint.c (_initialize_typeprint): Remove trailing newline
2601         from help.
2602         * reverse.c (_initialize_reverse): Remove trailing newlines from
2603         help.
2604         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2605         from help.
2606         * language.c (add_set_language_command): Remove trailing newline
2607         from help.
2608         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2609         help.
2610         * disasm.c (_initialize_disasm): Remove trailing newline from
2611         help.
2612         * top.c (init_main): Remove trailing newline from help.
2613         * interps.c (_initialize_interpreter): Remove trailing newline
2614         from help.
2615         * btrace.c (_initialize_btrace): Remove trailing newlines from
2616         help.
2617         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2618         from help.
2619         * python/python.c (_initialize_python): Remove trailing newline
2620         from help.
2621         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2622         help.
2623         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2624         from help.  Reformat some text.
2625         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2626         from help.
2627         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2628         newline from help.
2629
2630 2019-06-11  Tom Tromey  <tromey@adacore.com>
2631
2632         * darwin-nat.c (darwin_decode_exception_message)
2633         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2634
2635 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2636
2637         * valops.c (value_slice): Check for not allocated or not
2638         associated values.
2639
2640 2019-06-10  Tom de Vries  <tdevries@suse.de>
2641
2642         PR gdb/24618
2643         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2644         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2645         invalid.
2646
2647 2019-06-10  Tom de Vries  <tdevries@suse.de>
2648
2649         PR gdb/24611
2650         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2651         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2652
2653 2019-06-10  Tom de Vries  <tdevries@suse.de>
2654
2655         PR symtab/24545
2656         * symtab.c (struct demangled_name_entry): Add language field.
2657         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2658         static minimal symbol".  Set and use language field.
2659
2660 2019-06-10  Tom Tromey  <tromey@adacore.com>
2661
2662         * ada-lang.c (_initialize_ada_language): Update help text.
2663
2664 2019-06-10  Tom Tromey  <tromey@adacore.com>
2665
2666         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2667         with a newline.
2668         * guile/guile.c (handle_boot_error): Don't end warning with a
2669         newline.
2670         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2671         warning with a newline.
2672         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2673         newline.
2674         (s12z_frame_cache): Likewise.
2675         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2676         a newline.
2677         * solib-svr4.c (disable_probes_interface): Don't end warning with
2678         a newline.
2679         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2680         newline.
2681         * python/python.c (do_finish_initialization): Don't end warning
2682         with a newline.
2683
2684 2019-06-10  Tom Tromey  <tom@tromey.com>
2685
2686         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2687         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2688         gdbpy_enter.
2689
2690 2019-06-10  Tom Tromey  <tromey@adacore.com>
2691
2692         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2693         data.
2694         (elf_new_init): Don't call stabsread_new_init.
2695         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2696         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2697         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2698
2699 2019-06-10  Tom de Vries  <tdevries@suse.de>
2700
2701         PR symtab/16264
2702         PR symtab/24517
2703         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2704
2705 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2706
2707         * source.c (find_and_open_source): Also rewrite relative file
2708         names.
2709
2710 2019-04-26  Amos Bird  <amosbird@gmail.com>
2711
2712         * annotate.c (annotate_thread_exited): Add "thread-exited"
2713         annotation.
2714
2715 2019-06-06  Tom Tromey  <tromey@adacore.com>
2716
2717         * maint.h (class scoped_command_stats): Use
2718         DISABLE_COPY_AND_ASSIGN.
2719         <print_time>: New method.
2720         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2721         print_time.
2722         (scoped_command_stats::print_time): New method.
2723
2724 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2725
2726         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2727         instructions of lengths 6 or 8 bytes.
2728
2729 2019-06-04  Pedro Alves  <palves@redhat.com>
2730
2731         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2732
2733         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2734         * breakpoint.c (condition_completer): Likewise.
2735         * cli/cli-dump.c (scan_expression): Likewise.
2736         * common/filestuff.c (mkdir_recursive): Likewise.
2737         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2738         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2739         (gdb_abspath): Likewise.
2740         * compile/compile-cplus-types.c
2741         (compile_cplus_instance::decl_name): Likewise.
2742         * completer.c (complete_explicit_location):
2743         (signal_completer, reg_or_group_completer_1): Likewise.
2744         * cp-support.c (cp_remove_params_if_any): Likewise.
2745         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2746         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2747         * infcmd.c (strip_bg_char): Likewise.
2748         * linespec.c (copy_token_string): Likewise.
2749         * mi/mi-main.c (output_cores): Likewise.
2750         * psymtab.c (psymtab_search_name):
2751         * symfile.c (test_set_ext_lang_command): Likewise.
2752         * target.c (target_fileio_read_stralloc): Likewise.
2753         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2754         * value.c (complete_internalvar): Likewise.
2755
2756 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2757
2758         Add objfile property to gdb.Type.
2759         * NEWS: Mention Python API addition.
2760         * python/py-type.c (typy_get_objfile): New method.
2761
2762 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2763
2764         * NEWS: Mention the new set|show style [title|highlight].
2765         Mention changes to "show style", "help" and "apropos".
2766
2767 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2768
2769         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2770         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2771         instead of print_help_for_command.
2772         (print_doc_of_command): New function.
2773         (help_list): Add 'apropos -v word' suggestion.
2774         (print_help_for_command): Style the command name using title style.
2775         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2776         (_initialize_cli_cmds): Describe -v in apropos_command help.
2777
2778 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2779
2780         * cli/cli-style.h (cli_style_option): Add name in constructor,
2781         add m_name class member, add constructor with intensity,
2782         add name class function.
2783         (cli_style_option::add_setshow_commands): Remove name argument.
2784         (highlight_style, title_style): New styles.
2785         * cli/cli-style.c (do_show): New function that shows a style
2786         characteristic styling the style name with itself.
2787         (set_style_name): New function.
2788         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2789         Update all callers according to the changes in cli/cli-style.h.
2790         * utils.h (fputs_highlighted): New function.
2791         * utils.c (fputs_highlighted): Likewise.
2792
2793 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2794
2795         * NEWS: Mention new pipe command and new convenience variables.
2796
2797 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2798
2799         * cli/cli-cmds.c (pipe_command): New function.
2800         (_initialize_cli_cmds): Call add_com for pipe_command.
2801         Define | as an alias for pipe.
2802         (exit_status_set_internal_vars): New function.
2803         (shell_escape): Call exit_status_set_internal_vars.
2804         cli/cli-decode.c (find_command_name_length): Recognize | as
2805         a single character command.
2806
2807 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2808
2809         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2810         top.c (execute_command_to_ui_file): New function, mostly a copy
2811         of execute_command_to_string.
2812         (execute_command_to_string): Implement by calling
2813         execute_command_to_ui_file.
2814
2815 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2816
2817         * top.h (saved_command_line): Remove declaration.
2818         * top.c (previous_saved_command_line, previous_repeat_arguments):
2819         New variables.
2820         (saved_command_line): Make static, define together with other
2821         'repeat variables'.
2822         (dont_repeat): Clear repeat_arguments.
2823         (repeat_previous, get_saved_command_line, save_command_line):
2824         New functions.
2825         (gdb_init): Initialize saved_command_line
2826         and previous_saved_command_line.
2827         * main.c (captured_main_1): Remove saved_command_line initialization.
2828         * event-top.c (handle_line_of_input): Update to use
2829         the new 'repeat' related functions instead of direct access to
2830         saved_command_line.
2831         * command.h (repeat_previous, get_saved_command_line,
2832         save_command_line): New declarations.
2833         (dont_repeat): Add comment.
2834
2835 2019-05-30  Tom Tromey  <tromey@adacore.com>
2836
2837         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2838         Fix comment.
2839         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2840
2841 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2842
2843         PR cli/24587
2844         * completer.c (complete): Initialize variable word.
2845
2846 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2847
2848         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2849         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2850         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2851         'body' is NULL to the outter 'if', protecting the '!is_define'
2852         situation as well.
2853
2854 2019-05-29  Tom Tromey  <tromey@adacore.com>
2855
2856         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2857         (dwarf_unknown): New function.
2858         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2859         (dwarf_type_encoding_name): Use dwarf_unknown.
2860
2861 2019-05-29  Tom Tromey  <tromey@adacore.com>
2862
2863         PR c++/20020:
2864         * cp-valprint.c (cp_print_value_fields): Call
2865         cp_print_static_field inside "try".
2866
2867 2019-05-29  Tom Tromey  <tromey@adacore.com>
2868
2869         * inflow.c (struct terminal_info): Add default operator=.
2870         * configure: Rebuild.
2871         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2872         -Wdeprecated-copy-dtor, -Wredundant-move.
2873
2874 2019-05-29  Tom Tromey  <tromey@adacore.com>
2875
2876         * NEWS: Add entry.
2877         * infcmd.c (print_return_value_1): Handle finish_print
2878         option.
2879         (show_print_finish): New function.
2880         (_initialize_infcmd): Add "set/show print finish" commands.
2881         * valprint.c (user_print_options): Initialize new member.
2882         * valprint.h (struct value_print_options) <finish_print>: New
2883         member.
2884
2885 2019-05-28  Tom Tromey  <tromey@adacore.com>
2886
2887         * ada-lang.c (ada_remove_Xbn_suffix)
2888         (find_old_style_renaming_symbol)
2889         (parse_old_style_renaming): Remove.
2890         (ada_find_renaming_symbol): Don't call
2891         find_old_style_renaming_symbol.
2892         (ada_is_renaming_symbol): Rename from
2893         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2894         bool.  Now static.
2895         (ada_read_var_value): Update and simplify.
2896         * ada-exp.y (write_var_or_type): Remove old code.
2897
2898 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2899
2900         * event-top.c: Remove include comment.
2901         * inflow.c (class scoped_ignore_sigttou): Move from here...
2902         * inflow.h (class scoped_ignore_sigttou): ...to here.
2903         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2904         * top.c:  Remove include comment.
2905
2906 2019-05-27  Tom Tromey  <tom@tromey.com>
2907
2908         * NEWS: Fix typo.
2909
2910 2019-05-22  Tom Tromey  <tromey@adacore.com>
2911
2912         * target.c (target_follow_exec): Constify parameter.
2913         * target-delegates.c: Rebuild.
2914         * remote.c (remote_target::follow_exec): Constify parameter.
2915         * infrun.c (follow_exec): Constify parameter.
2916         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2917         (target_follow_exec): Likewise.
2918
2919 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2920
2921         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2922         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2923
2924 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2925
2926         * NEWS: Add debugredirect and testsuite sections.
2927
2928 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2929
2930         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2931         target descriptions using exclusively floating point register name
2932         aliases.
2933
2934 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2935
2936         PR gdb/18644:
2937         * f-lang.c (build_fortran_types): Handle the case where
2938         gdbarch_floatformat_for_type returns a nullptr.
2939
2940 2019-05-21  Tom de Vries  <tdevries@suse.de>
2941
2942         PR cli/24587
2943         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2944
2945 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2946
2947         PR gdb/18644:
2948         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2949         16-byte floats.
2950         * i386-tdep.c (i386_floatformat_for_type): Use
2951         floatformats_ia64_quad for the 16-byte floating point component
2952         within a fortran 32-byte complex number.
2953
2954 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2957         delete default constructor.
2958         (find_partial_die): Update to return const struct.
2959         (partial_die_parent_scope): Move variable declaration into scope
2960         of its use and change its type to auto.
2961         (guess_partial_die_structure_name): Likewise.
2962         (partial_die_info::fixup): Likewise.
2963
2964 2019-05-17  Tom Tromey  <tromey@adacore.com>
2965
2966         * source.c (find_and_open_source): Remove cast.
2967
2968 2019-05-17  Tom Tromey  <tromey@adacore.com>
2969
2970         * annotate.c (annotate_source): Make "filename" const.
2971         * annotate.h (annotate_source): Use const.
2972
2973 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2974
2975         * disasm.c (set_disassembler_options): Send errors to stderr.
2976
2977 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2978
2979         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2980         (cli_interp_base::set_logging): Check debug_redirect.
2981         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2982         * cli/cli-logging.c (debug_redirect): Add static variable.
2983         (pop_output_files): Add default param.
2984         (handle_redirections): Print debug setting.
2985         (show_logging_command): Likewise.
2986         (_initialize_cli_logging): Add debugredirect command.
2987         * interps.c (current_interp_set_logging): Add debug_redirect
2988         parameter.
2989         * interps.h (set_logging): Add debug_redirect parameter.
2990         (current_interp_set_logging): Likewise.
2991         * mi/mi-common.h: Likewise.
2992         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2993
2994 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2995             Tom Tromey  <tromey@adacore.com>
2996
2997         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2998         directly.
2999         * cli/cli-interp.h (make_logging_output): Remove declaration.
3000         * cli/cli-logging.c (make_logging_output): Remove function.
3001         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3002         directly.
3003         * ui-file.c (tee_file::tee_file): Remove bools.
3004         (tee_file::~tee_file): Remove deletes.
3005         * ui-file.h (tee_file): Remove bools.
3006
3007 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3008
3009         * mi/mi-cmds.h (mi_cmd_complete): New function.
3010         * mi/mi-main.c (mi_cmd_complete): Likewise.
3011         * mi/mi-cmds.c: Define new MI command -complete.
3012         * NEWS: Mention new -complete command.
3013
3014 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3015
3016         * completer.h (complete): New function.
3017         * completer.c (complete): Likewise.
3018         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3019         function defined in completer.h.
3020
3021 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3022
3023         * MAINTAINERS (Write After Approval): Add myself.
3024
3025 2019-05-17  Tom de Vries  <tdevries@suse.de>
3026
3027         PR gdb/24094
3028         * dwarf2read.c (struct cu_partial_die_info): New struct.
3029         (find_partial_die): Return cu_partial_die_info.
3030         (partial_die_parent_scope, guess_partial_die_structure_name)
3031         (partial_die_info::fixup): Handle new return type of find_partial_die.
3032
3033 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3034
3035         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3036         "std::string", simplifying the algorithm.
3037
3038 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3039
3040         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3041         (stap_static_probe_ops::get_probes): Likewise.
3042
3043 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3044
3045         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3046         '-')" and "else if".
3047         (stap_parse_single_operand): Join checks for
3048         "gdbarch_stap_parse_special_token_p" and
3049         "gdbarch_stap_parse_special_token" in the same "if" statement.
3050         Invert check when verifying for operation on register
3051         displacement.
3052
3053 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3054
3055         * stap-probe.c (stap_get_opcode): Update comment.
3056         (stap_get_expected_argument_type): Likewise.
3057         (handle_stap_probe): Likewise.
3058
3059 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3060
3061         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3062         return type to 'bool'.  Adjust comment.  Use 'bool' when
3063         appropriate.
3064         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3065         * stap-probe.c (stap_parse_argument_1): Likewise.
3066         (stap_is_operator): Likewise.
3067         (stap_is_generic_prefix): Likewise.
3068         (stap_is_register_prefix): Likewise.
3069         (stap_is_register_indirection_prefix): Likewise.
3070         (stap_is_integer_prefix): Likewise.
3071         (stap_generic_check_suffix): Likewise.
3072         (stap_check_integer_suffix): Likewise.
3073         (stap_check_register_suffix): Likewise.
3074         (stap_check_register_indirection_suffix): Likewise.
3075         (stap_parse_register_operand): Likewise.
3076         (stap_parse_single_operand): Likewise.
3077         (stap_parse_argument_1): Likewise.
3078         (stap_probe::get_argument_count): Likewise.
3079         (stap_is_operator): Likewise.
3080
3081 2019-05-16  Tom Tromey  <tromey@adacore.com>
3082
3083         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3084         keyword to foreach.
3085
3086 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3087
3088         * linux-thread-db.c (try_thread_db_load_1): Change return type
3089         to bool.
3090         (try_thread_db_load): Likewise.
3091         (try_thread_db_load_from_pdir_1): Likewise.
3092         (try_thread_db_load_from_pdir): Likewise.
3093         (try_thread_db_load_from_sdir): Likewise.
3094         (try_thread_db_load_from_dir): Likewise.
3095         (thread_db_load_search): Likewise.
3096         (has_libpthread): Likewise.
3097         (thread_db_load): Likewise.
3098
3099 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3100
3101         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3102         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3103         NULL, and complain/return if that's the case.
3104
3105 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3106
3107         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3108         (advance, posn, abstract_read_memory): New functions.
3109         [struct mem_read_abstraction]: New struct.
3110         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3111
3112 2019-05-14  Tom Tromey  <tromey@adacore.com>
3113
3114         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3115         value is not lval_memory.
3116
3117 2019-05-14  Tom Tromey  <tromey@adacore.com>
3118
3119         * solib.c (info_sharedlibrary_command): Style the file name.
3120
3121 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3122
3123         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3124         (aarch64_vnv_type): Likewise.
3125         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3126         * common/tdesc.c: Likewise.
3127         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3128         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3129         * features/aarch64-fpu.xml: Add ieee half view.
3130         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3131         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3132         * gdbtypes.h (struct builtin_type): Likewise.
3133         (struct objfile_type): Likewise.
3134
3135 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3136
3137         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3138         typo.
3139         * location.h (string_to_event_location): Likewise.
3140
3141 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3142
3143         GDB 8.3 released.
3144
3145 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3146
3147         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3148         New variable declaration.
3149         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3150         New variable.
3151         (print_one_breakpoint): Use ui_out::test_flags and new global
3152         variable to compute use_fixed_output.
3153         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3154         Remove.
3155         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3156         (mi_multi_location_breakpoint_output_fixed): Remove.
3157         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3158         new variable.
3159         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3160         fix_multi_location_breakpoint_output flag if version >= 3.
3161         * ui-out.h (enum ui_out_flag)
3162         <fix_multi_location_breakpoint_output>: New enumerator.
3163
3164 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3165
3166         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3167
3168 2019-05-10  Tom Tromey  <tromey@adacore.com>
3169
3170         * ada-lang.c (catch_ada_completer): New function.
3171         (_initialize_ada_language): Use it.
3172
3173 2019-05-10  Tom Tromey  <tromey@adacore.com>
3174
3175         * thread.c (print_thread_info): Make "requested_threads" const.
3176         * gdbthread.h (print_thread_info): Make "requested_threads"
3177         const.
3178         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3179         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3180
3181 2019-05-08  Tom Tromey  <tom@tromey.com>
3182
3183         * gdbtypes.c (objfile_type_data): Change type.
3184         (objfile_type, _initialize_gdbtypes): Update.
3185
3186 2019-05-08  Tom Tromey  <tom@tromey.com>
3187
3188         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3189         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3190         (_initialize_dwarf2_frame): Update.
3191
3192 2019-05-08  Tom Tromey  <tom@tromey.com>
3193
3194         * objc-lang.c (objc_objfile_data): Change type.
3195         (find_methods): Update.
3196         (_initialize_objc_lang): Remove.
3197
3198 2019-05-08  Tom Tromey  <tom@tromey.com>
3199
3200         * stabsread.c (rs6000_builtin_type_data): Change type.
3201         (rs6000_builtin_type, _initialize_stabsread): Update.
3202
3203 2019-05-08  Tom Tromey  <tom@tromey.com>
3204
3205         * mips-tdep.c (mips_pdr_data): Remove.
3206         (_initialize_mips_tdep): Update.
3207
3208 2019-05-08  Tom Tromey  <tom@tromey.com>
3209
3210         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3211         (hppa_init_objfile_priv_data, read_unwind_info)
3212         (find_unwind_entry, _initialize_hppa_tdep): Update.
3213
3214 2019-05-08  Tom Tromey  <tom@tromey.com>
3215
3216         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3217         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3218         on obstack.
3219         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3220
3221 2019-05-08  Tom Tromey  <tom@tromey.com>
3222
3223         * mdebugread.c (basic_type_data): Change type.
3224         (basic_type, _initialize_mdebugread): Update.
3225
3226 2019-05-08  Tom Tromey  <tom@tromey.com>
3227
3228         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3229
3230 2019-05-08  Tom Tromey  <tom@tromey.com>
3231
3232         * nto-tdep.c (nto_inferior_data_reg): Change type.
3233         (nto_inferior_data): Update.
3234         (nto_inferior_data_cleanup, nto_new_inferior_data)
3235         (_initialize_nto_tdep): Remove.
3236         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3237
3238 2019-05-08  Tom Tromey  <tom@tromey.com>
3239
3240         * ada-lang.c (struct ada_inferior_data): Add initializers.
3241         (ada_inferior_data): Change type.
3242         (ada_inferior_data_cleanup): Remove.
3243         (get_ada_inferior_data, ada_inferior_exit)
3244         (struct ada_pspace_data): Add initializers, destructor.
3245         (ada_pspace_data_handle): Change type.
3246         (get_ada_pspace_data): Update.
3247         (ada_pspace_data_cleanup): Remove.
3248
3249 2019-05-08  Tom Tromey  <tom@tromey.com>
3250
3251         * coffread.c (struct coff_symfile_info): Add initializers.
3252         (coff_objfile_data_key): Move lower.  Change type.
3253         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3254         Update.
3255         (coff_free_info): Remove.
3256
3257 2019-05-08  Tom Tromey  <tom@tromey.com>
3258
3259         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3260         (fbsd_pspace_data_handle): Move lower.  Change type.
3261         (get_fbsd_pspace_data): Update.
3262         (fbsd_pspace_data_cleanup): Remove.
3263         (_initialize_fbsd_tdep): Update.
3264
3265 2019-05-08  Tom Tromey  <tom@tromey.com>
3266
3267         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3268         (get_ada_tasks_pspace_data): Update.
3269         (ada_tasks_pspace_data_cleanup): Remove.
3270         (_initialize_tasks): Update.
3271         (ada_tasks_inferior_data_handle): Change type.
3272         (get_ada_tasks_inferior_data): Update.
3273         (ada_tasks_inferior_data_cleanup): Remove.
3274         (struct ada_tasks_pspace_data): Add initializers.
3275
3276 2019-05-08  Tom Tromey  <tom@tromey.com>
3277
3278         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3279         * symfile-debug.c (debug_sym_get_probes): Change type.
3280         * stap-probe.c (handle_stap_probe):
3281         (stap_static_probe_ops::get_probes): Change type.
3282         * probe.h (class static_probe_ops) <get_probes>: Change type.
3283         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3284         (parse_probes_in_pspace): Update.
3285         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3286         Update.
3287         (any_static_probe_ops::get_probes): Change type.
3288         * elfread.c (elfread_data): New typedef.
3289         (probe_key): Change type.
3290         (elf_get_probes): Likewise.  Update.
3291         (probe_key_free): Remove.
3292         (_initialize_elfread): Update.
3293         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3294         Change type.
3295         (dtrace_process_dof_probe, dtrace_process_dof)
3296         (dtrace_static_probe_ops::get_probe): Change type.
3297
3298 2019-05-08  Tom Tromey  <tom@tromey.com>
3299
3300         * xcoffread.c (struct xcoff_symfile_info): Rename from
3301         coff_symfile_info.  Add initializers.
3302         (xcoff_objfile_data_key): Move lower.  Change type.
3303         (XCOFF_DATA): Rewrite.
3304         (xcoff_free_info): Remove.
3305         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3306         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3307         (xcoff_initial_scan): Update.
3308
3309 2019-05-08  Tom Tromey  <tom@tromey.com>
3310
3311         * solib-svr4.c (struct svr4_info): Add initializers and
3312         destructor.
3313         <probes_table>: Now an htab_up.
3314         (solib_svr4_pspace_data): Change type.
3315         (free_probes_table): Simplify.
3316         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3317         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3318         (probes_table_remove_objfile_probes, register_solib_event_probe)
3319         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3320         (_initialize_svr4_solib): Update.
3321
3322 2019-05-08  Tom Tromey  <tom@tromey.com>
3323
3324         * remote.c (remote_pspace_data): Change type.
3325         (remote_pspace_data_cleanup): Remove.
3326         (get_remote_exec_file, set_pspace_remote_exec_file)
3327         (_initialize_remote): Update.
3328
3329 2019-05-08  Tom Tromey  <tom@tromey.com>
3330
3331         * breakpoint.c (breakpoint_objfile_key): Change type.
3332         (get_breakpoint_objfile_data): Update.
3333         (free_breakpoint_objfile_data): Remove.
3334         (_initialize_breakpoint): Update.
3335
3336 2019-05-08  Tom Tromey  <tom@tromey.com>
3337
3338         * linux-tdep.c (struct linux_info): Add initializers.
3339         (linux_inferior_data): Move.  Change type.
3340         (invalidate_linux_cache_inf): Update.
3341         (linux_inferior_data_cleanup): Remove.
3342         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3343
3344 2019-05-08  Tom Tromey  <tom@tromey.com>
3345
3346         * auxv.c (auxv_inferior_data): Move.  Change type.
3347         (auxv_inferior_data_cleanup): Remove.
3348         (invalidate_auxv_cache_inf): Rewrite.
3349         (get_auxv_inferior_data, _initialize_auxv): Update.
3350
3351 2019-05-08  Tom Tromey  <tom@tromey.com>
3352
3353         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3354         (symfile_debug_objfile_data_key): Change type.
3355         (symfile_debug_installed, debug_qf_has_symbols)
3356         (debug_qf_find_last_source_symtab)
3357         (debug_qf_forget_cached_source_info)
3358         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3359         (debug_qf_print_stats, debug_qf_dump)
3360         (debug_qf_expand_symtabs_for_function)
3361         (debug_qf_expand_all_symtabs)
3362         (debug_qf_expand_symtabs_with_fullname)
3363         (debug_qf_map_matching_symbols)
3364         (debug_qf_expand_symtabs_matching)
3365         (debug_qf_find_pc_sect_compunit_symtab)
3366         (debug_qf_map_symbol_filenames)
3367         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3368         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3369         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3370         (debug_sym_read_linetable, debug_sym_relocate): Update.
3371         (symfile_debug_free_objfile): Remove.
3372         (install_symfile_debug_logging, _initialize_symfile_debug):
3373         Update.
3374
3375 2019-05-08  Tom Tromey  <tom@tromey.com>
3376
3377         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3378         allocate_on_obstack.
3379         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3380         (get_dwarf2_per_objfile): Update.
3381         (set_dwarf2_per_objfile): Remove.
3382         (dwarf2_has_info, dwarf2_get_section_info): Update.
3383         (dwarf2_free_objfile): Remove.
3384         (_initialize_dwarf2_read): Update.
3385
3386 2019-05-08  Tom Tromey  <tom@tromey.com>
3387
3388         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3389         initializers.
3390         <unsupported_script_warning_printed,
3391         script_not_found_warning_printed>: Now bool.
3392         (auto_load_pspace_data): Change type.
3393         (~auto_load_pspace_info): Rename from
3394         auto_load_pspace_data_cleanup.
3395         (get_auto_load_pspace_data, init_loaded_scripts_info)
3396         (clear_section_scripts, maybe_print_unsupported_script_warning)
3397         (maybe_print_script_not_found_warning, _initialize_auto_load):
3398         Update.
3399
3400 2019-05-08  Tom Tromey  <tom@tromey.com>
3401
3402         * objfiles.c (objfile_pspace_info): Add destructor and
3403         initializers.
3404         (objfiles_pspace_data): Change type.
3405         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3406         (get_objfile_pspace_data): Update.
3407         (objfiles_bfd_data): Change type.
3408         (get_objfile_bfd_data): Update.
3409         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3410
3411 2019-05-08  Tom Tromey  <tom@tromey.com>
3412
3413         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3414         Change type.
3415         (get_catch_syscall_inferior_data): Update.
3416         (catch_syscall_inferior_data_cleanup): Remove.
3417         (_initialize_break_catch_syscall): Update.
3418
3419 2019-05-08  Tom Tromey  <tom@tromey.com>
3420
3421         * inflow.c (struct terminal_info): Add destructor and
3422         initializers.
3423         (inflow_inferior_data): Change type.
3424         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3425         (get_inflow_inferior_data, inflow_inferior_exit)
3426         (swap_terminal_info, _initialize_inflow): Update.
3427
3428 2019-05-08  Tom Tromey  <tom@tromey.com>
3429
3430         * target-dcache.c (target_dcache_cleanup): Remove.
3431         (target_dcache_aspace_key): Change type.
3432         (target_dcache_init_p, target_dcache_invalidate)
3433         (target_dcache_get, target_dcache_get_or_init)
3434         (_initialize_target_dcache): Update.
3435         * dcache.h (struct dcache_deleter): New.
3436
3437 2019-05-08  Tom Tromey  <tom@tromey.com>
3438
3439         * symtab.c (struct symbol_cache): Add destructor and
3440         initializers.
3441         (symbol_cache_key): Move.  Change type.
3442         (make_symbol_cache, free_symbol_cache): Remove.
3443         (get_symbol_cache): Update.
3444         (symbol_cache_cleanup): Remove.
3445         (ALL_PSPACES, symbol_cache_flush)
3446         (maintenance_print_symbol_cache)
3447         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3448         Update.
3449
3450 2019-05-08  Tom Tromey  <tom@tromey.com>
3451
3452         * symtab.c (struct main_info): Add destructor and initializers.
3453         (main_progspace_key): Move.  Change type.
3454         (get_main_info): Update.
3455         (main_info_cleanup): Remove.
3456         (_initialize_symtab): Update.
3457
3458 2019-05-08  Tom Tromey  <tom@tromey.com>
3459
3460         * registry.h (DECLARE_REGISTRY): Define the _key class.
3461
3462 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * NEWS: Merge two 'New commands' sections.
3465
3466 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3467
3468         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3469         parameter and use Ada language definition instead.
3470         (ada_val_print_ptr): Remove unused language parameter.
3471         (ada_val_print_num): Remove language parameter and use Ada language
3472         definition instead.
3473         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3474         parameter.
3475         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3476         parameter and use Ada language definition instead.
3477         (ada_val_print_1): Update all ada_val_print_xxx calls.
3478         Remove language parameter.
3479         (ada_val_print): Update ada_val_print_1 call.
3480
3481 2019-05-08  Tom Tromey  <tromey@adacore.com>
3482
3483         * remote.c (remote_hw_watchpoint_limit)
3484         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3485         Now static.
3486
3487 2019-05-08  Tom Tromey  <tromey@adacore.com>
3488
3489         * maint.c (_initialize_maint_cmds): Move initialization code to
3490         remote.c.
3491         (watchdog, show_watchdog): Move to remote.c.
3492         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3493         "watchdog" static.
3494         (_initialize_remote): Move initialization code from maint.c.
3495         * defs.h (watchdog): Don't declare.
3496
3497 2019-05-08  Tom Tromey  <tromey@adacore.com>
3498
3499         * tui/tui-interp.c: Include main.h.
3500         * interps.c: Include main.h.
3501         * main.h (interpreter_p): Declare.
3502         * defs.h (interpreter_p): Don't declare.
3503
3504 2019-05-08  Tom Tromey  <tromey@adacore.com>
3505
3506         * dwarf2loc.c: Include dwarf2read.h.
3507         * defs.h (read_unsigned_leb128): Don't declare.
3508         * dwarf2read.h (read_unsigned_leb128): Declare.
3509
3510 2019-05-08  Tom Tromey  <tromey@adacore.com>
3511
3512         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3513         method.
3514
3515 2019-05-08  Tom Tromey  <tromey@adacore.com>
3516
3517         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3518         when no wrap column is set.
3519
3520 2019-05-08  Tom Tromey  <tromey@adacore.com>
3521
3522         * c-lang.c (c_get_string): Handle non-C-style arrays.
3523
3524 2019-05-08  Tom Tromey  <tromey@adacore.com>
3525
3526         * typeprint.c (print_offset_data::update): Print the bit offset,
3527         not the number of bits remaining.
3528
3529 2019-05-08  Tom Tromey  <tromey@adacore.com>
3530
3531         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3532         padding at end of comment.
3533
3534 2019-05-08  Tom Tromey  <tromey@adacore.com>
3535
3536         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3537         Compare main types.
3538
3539 2019-05-06  Tom Tromey  <tom@tromey.com>
3540
3541         * common/scoped_mmap.c: Include common-defs.h.
3542         * common/scoped_mmap.h: Don't include config.h.
3543
3544 2019-05-04  Tom Tromey  <tom@tromey.com>
3545
3546         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3547         (struct aarch64_call_info): Add initializers.
3548         <si>: Now a std::vector.
3549         (pass_on_stack, aarch64_push_dummy_call): Update.
3550
3551 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3552             Tom Tromey  <tom@tromey.com>
3553
3554         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3555         (ppc_threads): Now a std::vector.  Now static.
3556         (hwdebug_find_thread_points_by_tid)
3557         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3558         Update.
3559
3560 2019-05-04  Tom Tromey  <tom@tromey.com>
3561
3562         * arc-tdep.c (arc_tdesc_init): Return bool.
3563
3564 2019-05-04  Tom Tromey  <tom@tromey.com>
3565
3566         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3567         Use gdb_assert_not_reached.
3568
3569 2019-05-04  Tom Tromey  <tom@tromey.com>
3570
3571         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3572         "false".
3573
3574 2019-05-04  Tom Tromey  <tom@tromey.com>
3575
3576         * arc-tdep.c (arc_tdesc_init): Use bool.
3577
3578 2019-05-04  Tom Tromey  <tom@tromey.com>
3579
3580         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3581
3582 2019-05-04  Tom Tromey  <tom@tromey.com>
3583
3584         * cli/cli-cmds.c (valid_command_p): Return bool.
3585
3586 2019-05-04  Tom Tromey  <tom@tromey.com>
3587
3588         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3589         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3590
3591 2019-05-04  Raul Tambre  <raul@tambre.ee>
3592
3593         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3594         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3595         operator for comparison.
3596
3597 2019-05-04  Tom Tromey  <tom@tromey.com>
3598
3599         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3600         (lookup_partial_symbol, print_partial_symbols)
3601         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3602         (psymbol_compare): Update.
3603         (add_psymbol_to_bcache): Clear the entire psymbol.
3604         (maintenance_check_psymtabs): Update.
3605         * psympriv.h (struct partial_symbol): Don't derive from
3606         general_symbol_info.
3607         <obj_section, unrelocated_address, address,
3608         set_unrelocated_address>: Update.
3609         <ginfo>: New member.
3610         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3611         (debug_names::write_psymbols): Update.
3612
3613 2019-05-04  Tom de Vries  <tdevries@suse.de>
3614
3615         * contrib/cc-with-tweaks.sh: Support -n arg.
3616
3617 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3618
3619         * corelow.c (core_target::detach): Ensure frame cache and
3620         register caches are cleared.
3621         inferior.c (exit_inferior_1): Likewise.
3622
3623 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3624             Tom Tromey  <tom@tromey.com>
3625
3626         * dictionary.c (collate_pending_symbols_by_language): Remove
3627         "struct" from foreach.
3628         * symtab.c (lookup_global_symbol_from_objfile)
3629         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3630         foreach.
3631         * ser-tcp.c (net_open): Remove "struct" from foreach.
3632         * objfiles.c (objfile_relocate, objfile_rebase)
3633         (objfile_has_symbols): Remove "struct" from foreach.
3634         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3635         from foreach.
3636         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3637         foreach.
3638         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3639         "struct" from foreach.
3640         * ada-lang.c (create_excep_cond_exprs)
3641         (ada_exception_catchpoint_cond_string): Remove "struct" from
3642         foreach.
3643
3644 2019-05-03  Tom Tromey  <tromey@adacore.com>
3645
3646         * ada-exp.y (convert_char_literal): Check suffix of each
3647         enumerator.
3648
3649 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3650
3651         PR ada/21406:
3652         * ada-exp.y (yywrap): Don't define.
3653         * ada-lex.l (%option): Add noyywrap
3654         (yywrap): Remove.
3655
3656 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3657
3658         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3659         _WIN32_WINNT to the XP level, unless already defined to a higher
3660         level.
3661
3662         * unittests/parse-connection-spec-selftests.c:
3663         * ser-tcp.c:
3664         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3665         override.
3666
3667         * symfile.c (find_separate_debug_file): Remove colon from the
3668         drive spec of DOS/Windows file names of the target, so that the
3669         file name produced from DEBUGDIR and the target's directory will
3670         be valid on DOS/Windows systems.
3671
3672 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3673
3674         * rust-lang.c (val_print_struct): Handle printing structures
3675         containing strings.
3676
3677 2019-05-02  Tom Tromey  <tromey@adacore.com>
3678
3679         * valarith.c (_initialize_valarith): Remove.
3680
3681 2019-05-01  Tom Tromey  <tromey@adacore.com>
3682
3683         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3684         bitfields.
3685
3686 2019-05-01  Tom Tromey  <tromey@adacore.com>
3687
3688         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3689         for big-endian copies.
3690
3691 2019-04-30  Ali Tamur  <tamur@google.com>
3692         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3693         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3694         (read_3_bytes): New function.
3695
3696 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3697
3698         * windows-nat.c (main_thread_id): Delete.
3699         (handle_output_debug_string): Replace main_thread_id by
3700         current_event.dwThreadId.
3701         (fake_create_process): Likewise.
3702         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3703         Do not set main_thread_id.
3704         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3705         current_event.dwThreadId.
3706         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3707
3708 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3709
3710         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3711         Use current_event.dwThreadId instead of main_thread_id.
3712
3713 2019-04-30  Tom Tromey  <tromey@adacore.com>
3714
3715         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3716         (create_excep_cond_exprs): Iterate over program spaces.
3717         (ada_exception_catchpoint_cond_string): Examine all minimal
3718         symbols for exception types.
3719
3720 2019-04-30  Tom Tromey  <tromey@adacore.com>
3721
3722         PR c++/24470:
3723         * dwarf2read.c (process_structure_scope): Handle case where type
3724         has template parameters but no symbol was created.
3725
3726 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3727             Chris January  <chris.january@arm.com>
3728
3729         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3730         qualifier.
3731         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3732
3733 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * f-typeprint.c (f_print_type): Update rules for printing
3736         whitespace.
3737         (f_type_print_varspec_suffix): Likewise.
3738
3739 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3740             Chris January  <chris.january@arm.com>
3741
3742         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3743         function arguments.
3744
3745 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * f-lang.c (build_fortran_types): Change name of void type to
3748         lower case.
3749         * f-typeprint.c (f_type_print_base): Print the name of the void
3750         type, rather than a fixed string.
3751         * f-valprint.c (f_decorations): Use lower case void string.
3752
3753 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3754             Chris January  <chris.january@arm.com>
3755
3756         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3757         types for Fortran.
3758
3759 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3760             Chris January  <chris.january@arm.com>
3761             David Lecomber  <david.lecomber@arm.com>
3762
3763         * f-exp.y (BINOP_INTRINSIC): New token.
3764         (exp): New parser rule handling BINOP_INTRINSIC.
3765         (f77_keywords): Add new builtin procedures.
3766         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3767         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3768         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3769         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3770         (print_unop_subexp_f): New function.
3771         (print_binop_subexp_f): New function.
3772         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3773         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3774         (dump_subexp_body_f): Likewise.
3775         (operator_check_f): Likewise.
3776         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3777         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3778
3779 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3782         UNOP_KIND.
3783         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3784         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3785         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3786         (operator_length_f): New fuction.
3787         (print_subexp_f): New function.
3788         (op_name_f): New function.
3789         (dump_subexp_body_f): New function.
3790         (operator_check_f): New function.
3791         (exp_descriptor_f): Replace standard expression handling functions
3792         with new functions.
3793         * gdb/fortran-operator.def: New file.
3794         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3795         * gdb/std-operator.def: Remove UNOP_KIND.
3796
3797 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * std-operator.def: Remove unbalanced, stray double quote
3800         character.
3801
3802 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3803             Chris January  <chris.january@arm.com>
3804             Daniel Everett  <daniel.everett@arm.com>
3805             Nick Forrington  <nick.forrington@arm.com>
3806             Richard Bunt  <richard.bunt@arm.com>
3807
3808         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3809         of depth when printing anonymous structs or unions.
3810         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3811         Don't print either the top-level value, or the children if the
3812         max-depth is exceeded.
3813         (ppscm_print_children): When printing the key of a map, allow one
3814         extra level of depth.
3815         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3816         print either the top-level value, or the children if the max-depth
3817         is exceeded.
3818         (print_children): When printing the key of a map, allow one extra
3819         level of depth.
3820         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3821         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3822         (user_print_options): Initialise max_depth field.
3823         (val_print_scalar_or_string_type_p): New function.
3824         (val_print): Check to see if the max depth has been reached.
3825         (val_print_check_max_depth): Define new function.
3826         (show_print_max_depth): New function.
3827         (_initialize_valprint): Add 'print max-depth' option.
3828         * valprint.h (struct value_print_options) <max_depth>: New field.
3829         (val_print_check_max_depth): Declare new function.
3830         * NEWS: Document new feature.
3831
3832 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3833
3834         * ada-lang.c (ada_language_defn): Initialise new field.
3835         * c-lang.c (c_is_string_type_p): New function.
3836         (c_language_defn): Initialise new field.
3837         (cplus_language_defn): Initialise new field.
3838         (asm_language_defn): Initialise new field.
3839         (minimal_language_defn): Initialise new field.
3840         * c-lang.h (c_is_string_type_p): Declare new function.
3841         * d-lang.c (d_language_defn): Initialise new field.
3842         * f-lang.c (f_is_string_type_p): New function.
3843         (f_language_defn): Initialise new field.
3844         * go-lang.c (go_is_string_type_p): New function.
3845         (go_language_defn): Initialise new field.
3846         * language.c (default_is_string_type_p): New function.
3847         (unknown_language_defn): Initialise new field.
3848         (auto_language_defn): Initialise new field.
3849         * language.h (struct language_defn) <la_is_string_type_p>: New
3850         member variable.
3851         (default_is_string_type_p): Declare new function.
3852         * m2-lang.c (m2_language_defn): Initialise new field.
3853         * objc-lang.c (objc_language_defn): Initialise new field.
3854         * opencl-lang.c (opencl_language_defn): Initialise new field.
3855         * p-lang.c (pascal_is_string_type_p): New function.
3856         (pascal_language_defn): Initialise new field.
3857         * rust-lang.c (rust_is_string_type_p): New function.
3858         (rust_language_defn): Initialise new field.
3859
3860 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3863         New field.
3864         * ada-lang.c (ada_language_defn): Initialise new field.
3865         * c-lang.c (c_language_defn): Likewise.
3866         (cplus_language_defn): Likewise.
3867         (asm_language_defn): Likewise.
3868         (minimal_language_defn): Likewise.
3869         * d-lang.c (d_language_defn): Likewise.
3870         * f-lang.c (f_language_defn): Likewise.
3871         * go-lang.c (go_language_defn): Likewise.
3872         * language.c (unknown_language_defn): Likewise.
3873         (auto_language_defn): Likewise.
3874         * m2-lang.c (m2_language_defn): Likewise.
3875         * objc-lang.c (objc_language_defn): Likewise.
3876         * opencl-lang.c (opencl_language_defn): Likewise.
3877         * p-lang.c (pascal_language_defn): Likewise.
3878         * rust-lang.c (rust_language_defn): Likewise.
3879
3880 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * ada-lang.c (ada_is_character_type): Change return type to bool.
3883         (ada_is_string_type): Likewise.
3884         * ada-lang.h (ada_is_character_type): Update declaration
3885         (ada_is_string_type): Likewise.
3886
3887 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3888
3889         Support style in 'frame|thread apply'
3890
3891         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3892         * record.c (record_start, record_stop): Update callers of
3893         execute_command_to_string with false.
3894         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3895         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3896         methods.
3897         (class string_file): New constructor with term_out parameter.
3898         Override methods term_out and can_emit_style_escape.  New member
3899         term_out.
3900         (class stdio_file): Override can_emit_style_escape.
3901         (class tee_file): Override term_out and can_emit_style_escape.
3902         * utils.h (can_emit_style_escape): Remove.
3903         * utils.c (can_emit_style_escape): Likewise.
3904         Update all callers of can_emit_style_escape (SOMESTREAM) to
3905         SOMESTREAM->can_emit_style_escape.
3906         * source-cache.c (source_cache::get_source_lines): Likewise.
3907         * stack.c (frame_apply_command_count): Call execute_command_to_string
3908         passing the term_out characteristic of the current gdb_stdout.
3909         * thread.c (thr_try_catch_cmd): Likewise.
3910         * top.c (execute_command_to_string): pass term_out parameter
3911         to construct the string_file for the command output.
3912         * ui-file.c (term_cli_styling): New function (most code moved
3913         from utils.c can_emit_style_escape).
3914         (string_file::string_file, string_file::can_emit_style_escape,
3915         stdio_file::can_emit_style_escape, tee_file::term_out,
3916         tee_file::can_emit_style_escape): New functions.
3917
3918 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3919
3920         * NEWS: Mention the new set|show may-call-functions.
3921         * infcall.c (may_call_functions_p): New variable.
3922         (show_may_call_functions_p): New function.
3923         (call_function_by_hand_dummy): Throws an error if not
3924         may-call-functions.
3925         (_initialize_infcall): Call add_setshow_boolean_cmd for
3926         may-call-functions.
3927
3928 2019-04-25  Keith Seitz  <keiths@redhat.com>
3929
3930         PR c++/24367
3931         * cp-support.c (inspect_type): Don't attempt substitutions
3932         of symbol with the same name.
3933
3934 2019-04-25  Tom Tromey  <tromey@adacore.com>
3935
3936         PR gdb/24475:
3937         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3938         static.
3939
3940 2019-04-25  Tom Tromey  <tromey@adacore.com>
3941
3942         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3943         rvalue reference.
3944         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3945         (gdb_xml_parser::parse): Use std::move.
3946         * python/python-internal.h (gdbpy_convert_exception): Take a const
3947         reference.
3948         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3949         std::move.
3950         * python/py-utils.c (gdbpy_convert_exception): Take a const
3951         reference.
3952         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3953         Use std::move.
3954         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3955         Use std::move.
3956         * mi/mi-main.c (mi_print_exception): Take a const reference.
3957         * main.c (handle_command_errors): Take a const reference.
3958         * linespec.c (parse_linespec): Use std::move.
3959         * infcall.c (run_inferior_call): Use std::move.
3960         (call_function_by_hand_dummy): Use std::move.
3961         * exec.c (try_open_exec_file): Use std::move.
3962         * exceptions.h (exception_print, exception_fprintf)
3963         (exception_print_same): Update.
3964         * exceptions.c (print_exception, exception_print)
3965         (exception_fprintf, exception_print_same): Change parameters to
3966         const reference.
3967         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3968         * common/new-op.c: Use std::move.
3969         * common/common-exceptions.h (struct gdb_exception): Add move
3970         constructor.
3971         (struct gdb_exception_error, struct gdb_exception_quit, struct
3972         gdb_quit_bad_alloc): Change constructor to move constructor.
3973         (throw_exception): Change parameter to rvalue reference.
3974         * common/common-exceptions.c (throw_exception): Take rvalue
3975         reference.
3976         * cli/cli-interp.c (safe_execute_command): Use std::move.
3977         * breakpoint.c (insert_bp_location, location_to_sals): Use
3978         std::move.
3979
3980 2019-04-25  Tom Tromey  <tromey@adacore.com>
3981
3982         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3983         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3984         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3985         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3986         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3987         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3988         guile/scm-value.c: Use unpack.
3989         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3990         gdbscm_gdb_exception.
3991         (gdbscm_throw_gdb_exception): Likewise.
3992         (struct gdbscm_gdb_exception): New.
3993         (unpack): New function.
3994         (gdbscm_wrap): Use unpack.
3995
3996 2019-04-25  Tom Tromey  <tromey@adacore.com>
3997
3998         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3999         (gdb_rl_callback_handler): Use std::move.
4000         * common/common-exceptions.h (struct gdb_exception): Add move
4001         assignment operator.
4002         (throw_exception_sjlj): Change "exception" to const reference.
4003         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4004         (throw_exception_sjlj): Change "exception" to const reference.
4005
4006 2019-04-25  Tom Tromey  <tromey@adacore.com>
4007
4008         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4009         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4010         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4011         Update.
4012         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4013         Update.
4014         * mi/mi-interp.c (mi_interp::exec): Update.
4015         * linespec.c (parse_linespec): Update.
4016         * infcall.c (run_inferior_call): Update.
4017         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4018         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4019         (gdbscm_lookup_global_symbol): Update.
4020         * guile/scm-param.c (gdbscm_parameter_value): Update.
4021         * guile/scm-frame.c (gdbscm_frame_read_register)
4022         (gdbscm_frame_read_var): Update.
4023         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4024         * exec.c (try_open_exec_file): Update.
4025         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4026         (gdb_rl_callback_handler): Update.
4027         * common/common-exceptions.h (exception_none): Don't declare.
4028         * common/common-exceptions.c (exception_none): Don't define.
4029         (struct catcher) <exception>: Update.
4030         * cli/cli-interp.c (safe_execute_command): Update.
4031         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4032
4033 2019-04-25  Ali Tamur  <tamur@google.com>
4034
4035         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4036         (read_attribute_value): Likewise.
4037         (dwarf2_read_addr_index): Update comment.
4038         (read_str_index): Add DW_FORM_strx.
4039         (dwarf2_string_attr): Likewise.
4040         (dwarf2_const_value_attr): Likewise.
4041         (dump_die_shallow): Likewise.
4042         (dwarf2_fetch_constant_bytes): Likewise.
4043         (skip_form_bytes): Likewise.
4044         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4045
4046 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4047
4048         PR corefiles/11608
4049         PR corefiles/18187
4050         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4051         OFFSET.  Verify if current mapping contains an ELF header.
4052         (linux_find_memory_regions_full): Adjust call to
4053         dump_mapping_p.
4054
4055 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4056             Kang Li <kanglictf@gmail.com>
4057
4058         PR gdb/21600
4059
4060         * dwarf2-frame.c (read_initial_length): Be consistent about using
4061         unsigned representation of length.
4062         (decode_frame_entry_1): Likewise.  Check for wraparound of
4063         end pointer as well as buffer overflow.
4064
4065 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4066
4067         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4068         "vq".
4069
4070 2019-04-24  Tom Tromey  <tromey@adacore.com>
4071
4072         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4073
4074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * s12z-tdep.c (s12z_unwind_pc): Delete.
4077         (s12z_unwind_sp): Delete.
4078         (s12z_gdbarch_init): Don't register deleted functions with
4079         gdbarch.
4080
4081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4082
4083         * rl78-tdep.c (rl78_unwind_sp): Delete.
4084         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4085
4086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4087
4088         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4089         (xstormy16_unwind_pc): Delete.
4090         (xstormy16_dummy_id): Delete.
4091         (xstormy16_gdbarch_init): Don't register deleted functions with
4092         gdbarch.
4093
4094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4095
4096         * vax-tdep.c (vax_unwind_pc): Delete.
4097         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4098
4099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4100
4101         * v850-tdep.c (v850_unwind_sp): Delete.
4102         (v850_unwind_pc): Delete.
4103         (v850_dummy_id): Delete.
4104         (v850_gdbarch_init): Don't register deleted functions with
4105         gdbarch.
4106
4107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4110         (tilegx_unwind_pc): Delete.
4111         (tilegx_unwind_dummy_id): Delete.
4112         (tilegx_gdbarch_init): Don't register deleted functions with
4113         gdbarch.
4114
4115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4116
4117         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4118         (tic6x_dummy_id): Delete.
4119         (tic6x_gdbarch_init): Don't register deleted functions with
4120         gdbarch.
4121
4122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4123
4124         * sparc-tdep.c (sparc_unwind_pc): Delete.
4125         (sparc32_gdbarch_init): Don't register deleted function with
4126         gdbarch.
4127
4128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4129
4130         * sh-tdep.c (sh_unwind_sp): Delete.
4131         (sh_unwind_pc): Delete.
4132         (sh_dummy_id): Delete.
4133         (sh_gdbarch_init): Don't register deleted functions with
4134         gdbarch.
4135
4136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4137
4138         * score-tdep.c (score_unwind_sp): Delete.
4139         (score_unwind_pc): Delete.
4140         (score_dummy_id): Delete.
4141         (score_gdbarch_init): Don't register deleted functions with
4142         gdbarch.
4143
4144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4145
4146         * rx-tdep.c (rx_unwind_pc): Delete.
4147         (rx_unwind_sp): Delete.
4148         (rx_dummy_id): Delete.
4149         (rx_gdbarch_init): Don't register deleted functions with
4150         gdbarch.  Update comment.
4151
4152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4153
4154         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4155         (rs6000_dummy_id): Delete.
4156         (rs6000_gdbarch_init): Don't register deleted functions with
4157         gdbarch.
4158
4159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4160
4161         * or1k-tdep.c (or1k_dummy_id): Delete.
4162         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4163
4164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * nios2-tdep.c (nios2_dummy_id): Delete.
4167         (nios2_unwind_sp): Delete.
4168         (nios2_gdbarch_init): Don't register deleted functions with
4169         gdbarch.
4170
4171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4172
4173         * nds32-tdep.c (nds32_dummy_id): Delete.
4174         (nds32_unwind_pc): Delete.
4175         (nds32_unwind_sp): Delete.
4176         (nds32_gdbarch_init): Don't register deleted functions with
4177         gdbarch.
4178
4179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * msp430-tdep.c (msp430_unwind_pc): Delete.
4182         (msp430_unwind_sp): Delete.
4183         (msp430_dummy_id): Delete.
4184         (msp430_gdbarch_init): Don't register deleted functions with
4185         gdbarch.
4186
4187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * moxie-tdep.c (moxie_unwind_sp): Delete.
4190         (moxie_unwind_pc): Delete.
4191         (moxie_dummy_id): Delete.
4192         (moxie_gdbarch_init): Don't register deleted functions with
4193         gdbarch.
4194
4195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4196
4197         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4198         (mn10300_unwind_pc): Delete.
4199         (mn10300_unwind_sp): Delete.
4200         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4201         mn10300_unwind_sp.
4202         (mn10300_frame_unwind_init): Don't register deleted functions with
4203         gdbarch.
4204
4205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4206
4207         * mep-tdep.c (mep_unwind_pc): Delete.
4208         (mep_unwind_sp): Delete.
4209         (mep_dummy_id): Delete.
4210         (mep_gdbarch_init): Don't register deleted functions with
4211         gdbarch.
4212
4213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4216         (m68hc11_unwind_sp): Delete.
4217         (m68hc11_gdbarch_init): Don't register deleted functions with
4218         gdbarch.
4219
4220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4221
4222         * m32r-tdep.c (m32r_unwind_sp): Delete.
4223         (m32r_unwind_pc): Delete.
4224         (m32r_dummy_id): Delete.
4225         (m32r_gdbarch_init): Don't register deleted functions with
4226         gdbarch.
4227
4228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * m32c-tdep.c (m32c_unwind_pc): Delete.
4231         (m32c_unwind_sp): Delete.
4232         (m32c_dummy_id): Delete.
4233         (m32c_gdbarch_init): Don't register deleted functions with
4234         gdbarch.
4235
4236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4237
4238         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4239         (lm32_unwind_pc): Delete.
4240         (lm32_dummy_id): Delete.
4241         (lm32_gdbarch_init): Don't register deleted functions with
4242         gdbarch.
4243
4244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4245
4246         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4247         (iq2000_unwind_pc): Delete.
4248         (iq2000_dummy_id): Delete.
4249         (iq2000_gdbarch_init): Don't register deleted functions with
4250         gdbarch.
4251
4252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4253
4254         * nds32-tdep.c (nds32_type_align): Delete.
4255         (nds32_push_dummy_call): Use type_align instead.
4256
4257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * arm-tdep.c (arm_type_align): Only handle vector override case.
4260         (arm_push_dummy_call): Use type_align.
4261         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4262
4263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4264
4265         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4266         case.
4267         (pass_on_stack): Use type_align.
4268         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4269         function.
4270
4271 2019-04-23  Tom Tromey  <tromey@adacore.com>
4272
4273         * dwarf2read.c (line_header::file_name_at): Remove unused
4274         overload.
4275
4276 2019-04-23  Tom de Vries  <tdevries@suse.de>
4277
4278         PR gdb/24438
4279         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4280         invocation.
4281
4282
4283 2019-03-27  Ali Tamur  <tamur@google.com>
4284
4285         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4286         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4287         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4288         (dwarf_expr_context::get_addr_index): Likewise
4289         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4290         (symbol_needs_eval_context::get_addr_index): Likewise
4291         (disassemble_dwarf_expression): Add DW_OP_addrx
4292         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4293         (read_cutu_die_from_dwo): Update comment
4294         (skip_one_die): Add DW_FORM_addrx
4295         (read_attribute_value): Likewise
4296         (var_decode_location): Add DW_OP_addrx
4297         (dwarf2_const_value_attr): Add DW_FORM_addrx
4298         (dump_die_shallow): Likewise
4299         (dwarf2_fetch_constant_bytes): Likewise
4300         (decode_locdesc): Add DW_OP_addrx
4301         (skip_form_bytes): Add DW_FORM_addrx
4302
4303 2019-04-22  Ali Tamur  <tamur@google.com>
4304
4305         * MAINTAINERS (Write After Approval): Add self.
4306
4307 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4308
4309         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4310         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4311         (open_symbol_file_object): Likewise.
4312         (svr4_default_sos): Add info parameter.
4313         (svr4_read_so_list): Likewise.
4314         (svr4_current_sos_direct): Adjust functions calls to pass down
4315         info.
4316         (svr4_current_sos_1): Add info parameter.
4317         (svr4_current_sos): Call get_svr4_info, pass info down to
4318         svr4_current_sos_1.
4319         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4320         get_svr4_info.
4321         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4322         get_svr4_info.
4323         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4324         to get_svr4_info.
4325         (probes_table_remove_objfile_probes): Likewise.
4326         (register_solib_event_probe): Add info parameter.
4327         (solist_update_incremental): Pass info parameter down to
4328         svr4_read_so_list.
4329         (disable_probes_interface): Add info parameter.
4330         (svr4_handle_solib_event): Pass current_program_space to
4331         get_svr4_info.  Adjust disable_probes_interface cleanup.
4332         (svr4_create_probe_breakpoints): Add info parameter, pass it
4333         down to register_solib_event_probe.
4334         (svr4_create_solib_event_breakpoints): Add info parameter,
4335         pass it down to svr4_create_probe_breakpoints.
4336         (enable_break): Pass info down to
4337         svr4_create_solib_event_breakpoints.
4338         (svr4_solib_create_inferior_hook): Pass current_program_space to
4339         get_svr4_info.
4340         (svr4_clear_solib): Likewise.
4341
4342 2019-04-22  Pedro Alves  <palves@redhat.com>
4343
4344         * solib-svr4.c (svr4_free_objfile_observer): New.
4345         (probe_and_action::objfile): New field.
4346         (probes_table_htab_remove_objfile_probes)
4347         (probes_table_remove_objfile_probes): New functions.
4348         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4349         in the new probe_and_action.  Don't store the probe in 'lookup'.
4350         (svr4_create_probe_breakpoints): Pass objfile to
4351         register_solib_event_probe.
4352         (_initialize_svr4_solib): Register a free_objfile observer.
4353
4354 2019-04-19  Tom Tromey  <tom@tromey.com>
4355
4356         * common/queue.h: Remove.
4357
4358 2019-04-19  Tom Tromey  <tom@tromey.com>
4359
4360         * event-loop.c: Don't include "common/queue.h".
4361
4362 2019-04-19  Tom Tromey  <tom@tromey.com>
4363
4364         * remote.c (remote_target): Use delete.
4365         * remote-notif.h: Include <list>, not "common/queue.h".
4366         (notif_client_p): Remove typedef.
4367         (remote_notif_state): Add constructor, destructor, initializer.
4368         <notif_queue>: Now a std::list.
4369         (remote_notif_state_xfree): Don't declare.
4370         * remote-notif.c (remote_notif_process, handle_notification)
4371         (remote_notif_state_allocate): Update.
4372         (~remote_notif_state): Rename from remote_notif_state_xfree.
4373
4374 2019-04-19  Tom Tromey  <tom@tromey.com>
4375
4376         * symfile.c (reread_symbols): Update.
4377         * objfiles.c (objfile_register_static_link)
4378         (objfile_lookup_static_link): Update
4379         (~objfile) Don't delete static_links.
4380         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4381
4382 2019-04-19  Tom Tromey  <tom@tromey.com>
4383
4384         * type-stack.h (struct type_stack) <insert>: Constify string.
4385         * type-stack.c (type_stack::insert): Constify string.
4386         * gdbtypes.h (lookup_template_type): Update.
4387         (address_space_name_to_int): Update.
4388         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4389         const.
4390         (lookup_template_type): Make name const.
4391         * c-exp.y: Update rules.
4392         (lex_one_token, classify_name, classify_inner_name)
4393         (c_print_token): Update.
4394         * p-exp.y: Update rules.
4395         (yylex): Update.
4396         * f-exp.y: Update rules.
4397         (yylex): Update.
4398         * d-exp.y: Update rules.
4399         (lex_one_token, classify_name, classify_inner_name): Update.
4400         * parse.c (write_dollar_variable, copy_name): Return std::string.
4401         * parser-defs.h (copy_name): Change return type.
4402         * m2-exp.y: Update rules.
4403         (yylex): Update.
4404         * go-exp.y (lex_one_token): Update.
4405         Update rules.
4406         (classify_unsafe_function, classify_packaged_name)
4407         (classify_name, yylex): Update.
4408
4409 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4410
4411         * configure.ac: add --enable-source-highlight switch.
4412         * configure: Regenerate.
4413         * top.c (print_gdb_version): plumb --enable-source-highlight
4414         status to "show configuration".
4415
4416 2019-04-19  Tom Tromey  <tromey@adacore.com>
4417
4418         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4419         Check ADA_TYPE_P.
4420         (empty_record, ada_template_to_fixed_record_type_1)
4421         (template_to_static_fixed_type)
4422         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4423         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4424         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4425         macros.
4426
4427 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4428
4429         PR symtab/24423:
4430         * source.c (print_source_lines_base): Advance "iter" when a
4431         control character is seen.
4432
4433 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4434
4435         * inferior.h (struct infcall_suspend_state_deleter):
4436         Catch exception in destructor to avoid crash.
4437
4438 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4439
4440         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4441         close to the add_com "shell".
4442
4443 2019-04-18  Tom Tromey  <tromey@adacore.com>
4444
4445         * process-stratum-target.h (class process_stratum_target)
4446         <stratum>: Add "final".
4447
4448 2019-04-17  Tom Tromey  <tromey@adacore.com>
4449
4450         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4451         against nullptr before use.
4452
4453 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4454
4455         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4456
4457 2019-04-17  Jim Wilson  <jimw@sifive.com>
4458             Andrew Burgess  <andrew.burgess@embecosm.com>
4459
4460         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4461         code read might fail, assume 4-byte breakpoint in that case.
4462
4463 2019-04-15  Leszek Swirski  <leszeks@google.com>
4464
4465         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4466         rather than a hand-rolled POD check when checking for forced MEMORY
4467         classification.
4468
4469 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4470
4471         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4472         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4473         function.
4474         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4475         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4476         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4477         declaration.
4478
4479 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4480
4481         * aarch64-linux-nat.c
4482         (aarch64_linux_nat_target::thread_architecture): Add override.
4483         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4484         each VQ.
4485
4486 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4487
4488         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4489
4490 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4491
4492         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4493         target types of size 96-bits, add some additional comments, and
4494         check that the builtin type we found was the correct size.
4495
4496 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4497
4498         * utils.c (prompt_for_continue): Don't restore the styling at the
4499         end, as applied_style has the wrong value.  This fixes styling in
4500         long lists of file names that are interrupted by the "Continue?"
4501         prompt.
4502
4503 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4504
4505         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4506         * c-lang.c (c_language_defn): Likewise.
4507         (cplus_language_defn): Likewise.
4508         (asm_language_defn): Likewise.
4509         (minimal_language_defn): Likewise.
4510         * d-lang.c (d_language_defn): Likewise.
4511         * f-lang.c (f_language_defn): Likewise.
4512         * go-lang.c (go_language_defn): Likewise.
4513         * language.c (unknown_language_defn): Likewise.
4514         (auto_language_defn): Likewise.
4515         * language.h (struct language_defn): Remove la_magic field.
4516         (LANG_MAGIC): Delete.
4517         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4518         * objc-lang.c (objc_language_defn): Likewise.
4519         * opencl-lang.c (opencl_language_defn): Likewise.
4520         * p-lang.c (pascal_language_defn): Likewise.
4521         * rust-lang.c (rust_language_defn): Likewise.
4522
4523 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * riscv-tdep.c (riscv_type_align): New function.
4526         (riscv_type_alignment): Delete.
4527         (riscv_arg_location): Use 'type_align'.
4528         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4529
4530 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4531
4532         * gdbtypes.c (type_align): A struct with no non-static fields also
4533         has alignment of 1.
4534
4535 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4538         component to 0.
4539         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4540         member.
4541         (riscv_struct_info::analyse): New implementation using new
4542         analyse_inner member function.
4543         (riscv_struct_info::field_offset): New member function.
4544         (riscv_struct_info::m_offsets): New member variable.
4545         (riscv_struct_info::analyse_inner): New private member function,
4546         takes the old implementation of riscv_struct_info::analyse but
4547         extended to track field offsets.
4548         (riscv_call_arg_struct): Update the struct folding special cases
4549         to handle cases where empty C++ structs, which are non-zero
4550         length, are found.
4551         (riscv_arg_location): Initialise the length of each location, a
4552         non-zero length now indicates the location is in use.
4553         (riscv_push_dummy_call): Allow for the first location having a
4554         non-zero offset when setting up arguments.
4555         (riscv_return_value): Likewise, but for return values.
4556
4557 2019-04-11  Tom Tromey  <tromey@adacore.com>
4558
4559         * utils.c (internal_vproblem): Make "msg" const.
4560
4561 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4562
4563         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4564         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4565         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4566         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4567
4568 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4569
4570         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4571         function.
4572         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4573         of amd64_collect_native_gregset.
4574         (amd64_linux_nat_target::store_registers): Likewise.
4575
4576 2019-04-10  Tom Tromey  <tom@tromey.com>
4577
4578         * symtab.c (lookup_global_symbol_from_objfile)
4579         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4580         * objfiles.h (class separate_debug_iterator): New.
4581         (class separate_debug_range): New.
4582         (struct objfile) <separate_debug_objfiles>: New method.
4583         (objfile_separate_debug_iterate): Don't declare.
4584         * objfiles.c (separate_debug_iterator::operator++): Rename from
4585         objfile_separate_debug_iterate.
4586         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4587         iterator.
4588         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4589         iterator.
4590
4591 2019-04-10  Tom Tromey  <tom@tromey.com>
4592
4593         * symfile.c (reread_symbols): Remove old comment.
4594         * objfiles.c (free_all_objfiles): Fix a typo.
4595
4596 2019-04-10  Tom Tromey  <tom@tromey.com>
4597
4598         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4599         * minsyms.c (lookup_minimal_symbol): Use foreach.
4600         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4601         (lookup_minimal_symbol_solib_trampoline): Likewise.
4602         * symfile.c (reread_symbols): Use foreach.
4603
4604 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4605             Tom Tromey  <tromey@adacore.com>
4606
4607         PR rust/24414:
4608         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4609         (rust_lex_int_test): Change "value" to be LONGEST.
4610         (rust_lex_tests): Add test for long integer literal.
4611
4612 2019-04-09  Tom Tromey  <tromey@adacore.com>
4613
4614         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4615         to bool.
4616         (extended_remote_target::attach): Update.
4617         (remote_target::remote_notice_new_inferior): Update.
4618         (remote_target::add_current_inferior_and_thread): Update.
4619         * inferior.c (exit_inferior_1): Use "false".
4620         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4621
4622 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4623
4624         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4625         the "start" command.
4626
4627 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4628
4629         * python/py-inferior.c (infpy_thread_from_thread_handle):
4630         Adjust comments to reflect renaming of thread_from_thread_handle
4631         to thread_from_handle.  Adjust keywords.  Fix type error message.
4632         (inferior_object_methods): Add thread_from_handle.  Retain
4633         thread_from_thread_handle, but mark it as deprecated.
4634
4635 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4636
4637         * gdbthread.h (find_thread_by_handle): Revise declaration.
4638         * thread.c (find_thread_by_handle): Likewise.  Adjust
4639         implementation too.
4640         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4641         support for buffer objects as handles.
4642
4643 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4644
4645         * python/py-infthread.c (thpy_thread_handle): New function.
4646         (thread_object_methods): Register thpy_thread_handle.
4647
4648 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4649
4650         * gdbthread.h (thread_to_thread_handle): Declare.
4651         * thread.c (gdbtypes.h): Include.
4652         (thread_to_thread_handle): New function.
4653
4654         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4655         (target_thread_info_to_thread_handle): Declare.
4656         * target.c (target_thread_info_to_thread_handle): New function.
4657         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4658         * target-delegates.c: Regenerate.
4659
4660         * linux-thread-db.c (class thread_db_target): Add method
4661         thread_info_to_thread_handle.
4662         (thread_db_target::thread_info_to_thread_handle): Define.
4663         * remote.c (class remote_target): Add new method
4664         thread_info_to_thread_handle.
4665         (remote_target::thread_info_to_thread_handle): Define.
4666
4667 2019-04-08  Pedro Alves  <palves@redhat.com>
4668
4669         * common/common-exceptions.c (throw_exception): Don't create
4670         named object to throw; throw directly.
4671         (throw_it): Likewise.  Don't initialize gdb_exception::message
4672         here, with new; pass FMT and AP to the ctor instead.
4673         * common/common-exceptions.h: Include <string>.
4674         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4675         const char *, va_list)): New ctor.  Use std::make_shared.
4676         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4677         errors)): Delete.
4678         (gdb_exception_error::gdb_exception_error(enum errors, const char
4679         *, va_list)): New.
4680         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4681         Add assertion.
4682         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4683         errors)): Delete.
4684         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4685         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4686         Add assertion.
4687
4688 2019-04-08  Tom Tromey  <tom@tromey.com>
4689
4690         * valops.c (value_rtti_indirect_type): Replace throw_exception
4691         with throw.
4692         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4693         with throw.
4694         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4695         throw.
4696         * target.c (target_translate_tls_address): Replace throw_exception
4697         with throw.
4698         * stack.c (frame_apply_command_count): Replace throw_exception
4699         with throw.
4700         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4701         throw.
4702         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4703         with throw.
4704         * rs6000-tdep.c (rs6000_frame_cache)
4705         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4706         * remote.c: Replace throw_exception with throw.
4707         * record-full.c (record_full_message, record_full_wait_1)
4708         (record_full_restore): Replace throw_exception with throw.
4709         * record-btrace.c:
4710         (get_thread_current_frame_id, record_btrace_start_replaying)
4711         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4712         (cmd_record_btrace_start): Replace throw_exception with throw.
4713         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4714         throw.
4715         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4716         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4717         * linespec.c:
4718         (find_linespec_symbols): Replace throw_exception with throw.
4719         * infrun.c (displaced_step_prepare, resume): Replace
4720         throw_exception with throw.
4721         * infcmd.c (post_create_inferior): Replace throw_exception with
4722         throw.
4723         * inf-loop.c (inferior_event_handler): Replace throw_exception
4724         with throw.
4725         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4726         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4727         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4728         (get_prev_frame_always, get_frame_pc_if_available)
4729         (get_frame_address_in_block_if_available, get_frame_language):
4730         Replace throw_exception with throw.
4731         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4732         throw_exception with throw.
4733         * eval.c (fetch_subexp_value, evaluate_var_value)
4734         (evaluate_funcall, evaluate_subexp_standard): Replace
4735         throw_exception with throw.
4736         * dwarf2loc.c (call_site_find_chain)
4737         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4738         Replace throw_exception with throw.
4739         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4740         with throw.
4741         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4742         throw.
4743         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4744         * completer.c (complete_line_internal): Replace throw_exception
4745         with throw.
4746         * compile/compile-object-run.c (compile_object_run): Replace
4747         throw_exception with throw.
4748         * cli/cli-script.c (process_next_line): Replace throw_exception
4749         with throw.
4750         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4751         (btrace_enable, btrace_maint_update_pt_packets): Replace
4752         throw_exception with throw.
4753         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4754         throw_exception with throw.
4755         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4756         throw_exception with throw.
4757         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4758         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4759         * aarch64-tdep.c (aarch64_make_prologue_cache)
4760         (aarch64_make_stub_cache): Replace throw_exception with throw.
4761
4762 2019-04-08  Tom Tromey  <tom@tromey.com>
4763
4764         * common/common-exceptions.c (throw_exception): Rename from
4765         throw_exception_cxx.  Remove old copy.  Make argument const.
4766         (throw_it): Create and throw exception objects directly.
4767         * common/common-exceptions.h (throw_exception): Make argument
4768         const.
4769         (struct gdb_exception_error): Add constructor.
4770         (struct gdb_exception_quit): Add constructor.
4771
4772 2019-04-08  Tom Tromey  <tom@tromey.com>
4773
4774         * common/common-exceptions.h (exception_rethrow): Don't declare.
4775         (TRY_SJLJ): Update comment.
4776         (TRY, CATCH, END_CATCH): Remove.
4777         * common/common-exceptions.c (exception_rethrow): Remove.
4778
4779 2019-04-08  Tom Tromey  <tom@tromey.com>
4780
4781         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4782         Remove.
4783         (gdb_exception_error): Rename from
4784         gdb_exception_RETURN_MASK_ERROR.
4785         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4786         (gdb_quit_bad_alloc): Update.
4787         * aarch64-tdep.c: Update.
4788         * ada-lang.c: Update.
4789         * ada-typeprint.c: Update.
4790         * ada-valprint.c: Update.
4791         * amd64-tdep.c: Update.
4792         * arch-utils.c: Update.
4793         * break-catch-throw.c: Update.
4794         * breakpoint.c: Update.
4795         * btrace.c: Update.
4796         * c-varobj.c: Update.
4797         * cli/cli-cmds.c: Update.
4798         * cli/cli-interp.c: Update.
4799         * cli/cli-script.c: Update.
4800         * common/common-exceptions.c: Update.
4801         * common/new-op.c: Update.
4802         * common/selftest.c: Update.
4803         * compile/compile-c-symbols.c: Update.
4804         * compile/compile-cplus-symbols.c: Update.
4805         * compile/compile-object-load.c: Update.
4806         * compile/compile-object-run.c: Update.
4807         * completer.c: Update.
4808         * corelow.c: Update.
4809         * cp-abi.c: Update.
4810         * cp-support.c: Update.
4811         * cp-valprint.c: Update.
4812         * darwin-nat.c: Update.
4813         * disasm-selftests.c: Update.
4814         * dtrace-probe.c: Update.
4815         * dwarf-index-cache.c: Update.
4816         * dwarf-index-write.c: Update.
4817         * dwarf2-frame-tailcall.c: Update.
4818         * dwarf2-frame.c: Update.
4819         * dwarf2loc.c: Update.
4820         * dwarf2read.c: Update.
4821         * eval.c: Update.
4822         * event-loop.c: Update.
4823         * event-top.c: Update.
4824         * exec.c: Update.
4825         * f-valprint.c: Update.
4826         * fbsd-tdep.c: Update.
4827         * frame-unwind.c: Update.
4828         * frame.c: Update.
4829         * gdbtypes.c: Update.
4830         * gnu-v3-abi.c: Update.
4831         * guile/guile-internal.h: Update.
4832         * guile/scm-block.c: Update.
4833         * guile/scm-breakpoint.c: Update.
4834         * guile/scm-cmd.c: Update.
4835         * guile/scm-disasm.c: Update.
4836         * guile/scm-frame.c: Update.
4837         * guile/scm-lazy-string.c: Update.
4838         * guile/scm-math.c: Update.
4839         * guile/scm-param.c: Update.
4840         * guile/scm-ports.c: Update.
4841         * guile/scm-pretty-print.c: Update.
4842         * guile/scm-symbol.c: Update.
4843         * guile/scm-symtab.c: Update.
4844         * guile/scm-type.c: Update.
4845         * guile/scm-value.c: Update.
4846         * i386-linux-tdep.c: Update.
4847         * i386-tdep.c: Update.
4848         * inf-loop.c: Update.
4849         * infcall.c: Update.
4850         * infcmd.c: Update.
4851         * infrun.c: Update.
4852         * jit.c: Update.
4853         * language.c: Update.
4854         * linespec.c: Update.
4855         * linux-fork.c: Update.
4856         * linux-nat.c: Update.
4857         * linux-tdep.c: Update.
4858         * linux-thread-db.c: Update.
4859         * main.c: Update.
4860         * mi/mi-cmd-break.c: Update.
4861         * mi/mi-cmd-stack.c: Update.
4862         * mi/mi-interp.c: Update.
4863         * mi/mi-main.c: Update.
4864         * objc-lang.c: Update.
4865         * p-valprint.c: Update.
4866         * parse.c: Update.
4867         * ppc-linux-tdep.c: Update.
4868         * printcmd.c: Update.
4869         * python/py-arch.c: Update.
4870         * python/py-breakpoint.c: Update.
4871         * python/py-cmd.c: Update.
4872         * python/py-finishbreakpoint.c: Update.
4873         * python/py-frame.c: Update.
4874         * python/py-framefilter.c: Update.
4875         * python/py-gdb-readline.c: Update.
4876         * python/py-inferior.c: Update.
4877         * python/py-infthread.c: Update.
4878         * python/py-lazy-string.c: Update.
4879         * python/py-linetable.c: Update.
4880         * python/py-objfile.c: Update.
4881         * python/py-param.c: Update.
4882         * python/py-prettyprint.c: Update.
4883         * python/py-progspace.c: Update.
4884         * python/py-record-btrace.c: Update.
4885         * python/py-record.c: Update.
4886         * python/py-symbol.c: Update.
4887         * python/py-type.c: Update.
4888         * python/py-unwind.c: Update.
4889         * python/py-utils.c: Update.
4890         * python/py-value.c: Update.
4891         * python/python.c: Update.
4892         * record-btrace.c: Update.
4893         * record-full.c: Update.
4894         * remote-fileio.c: Update.
4895         * remote.c: Update.
4896         * riscv-tdep.c: Update.
4897         * rs6000-aix-tdep.c: Update.
4898         * rs6000-tdep.c: Update.
4899         * rust-exp.y: Update.
4900         * rust-lang.c: Update.
4901         * s390-tdep.c: Update.
4902         * selftest-arch.c: Update.
4903         * solib-dsbt.c: Update.
4904         * solib-frv.c: Update.
4905         * solib-spu.c: Update.
4906         * solib-svr4.c: Update.
4907         * solib.c: Update.
4908         * sparc64-linux-tdep.c: Update.
4909         * stack.c: Update.
4910         * symfile-mem.c: Update.
4911         * symmisc.c: Update.
4912         * target.c: Update.
4913         * thread.c: Update.
4914         * top.c: Update.
4915         * tracefile-tfile.c: Update.
4916         * tui/tui.c: Update.
4917         * typeprint.c: Update.
4918         * unittests/cli-utils-selftests.c: Update.
4919         * unittests/parse-connection-spec-selftests.c: Update.
4920         * valops.c: Update.
4921         * valprint.c: Update.
4922         * value.c: Update.
4923         * varobj.c: Update.
4924         * windows-nat.c: Update.
4925         * x86-linux-nat.c: Update.
4926         * xml-support.c: Update.
4927
4928 2019-04-08  Tom Tromey  <tom@tromey.com>
4929
4930         * xml-support.c: Use C++ exception handling.
4931         * x86-linux-nat.c: Use C++ exception handling.
4932         * windows-nat.c: Use C++ exception handling.
4933         * varobj.c: Use C++ exception handling.
4934         * value.c: Use C++ exception handling.
4935         * valprint.c: Use C++ exception handling.
4936         * valops.c: Use C++ exception handling.
4937         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4938         handling.
4939         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4940         * typeprint.c: Use C++ exception handling.
4941         * tui/tui.c: Use C++ exception handling.
4942         * tracefile-tfile.c: Use C++ exception handling.
4943         * top.c: Use C++ exception handling.
4944         * thread.c: Use C++ exception handling.
4945         * target.c: Use C++ exception handling.
4946         * symmisc.c: Use C++ exception handling.
4947         * symfile-mem.c: Use C++ exception handling.
4948         * stack.c: Use C++ exception handling.
4949         * sparc64-linux-tdep.c: Use C++ exception handling.
4950         * solib.c: Use C++ exception handling.
4951         * solib-svr4.c: Use C++ exception handling.
4952         * solib-spu.c: Use C++ exception handling.
4953         * solib-frv.c: Use C++ exception handling.
4954         * solib-dsbt.c: Use C++ exception handling.
4955         * selftest-arch.c: Use C++ exception handling.
4956         * s390-tdep.c: Use C++ exception handling.
4957         * rust-lang.c: Use C++ exception handling.
4958         * rust-exp.y: Use C++ exception handling.
4959         * rs6000-tdep.c: Use C++ exception handling.
4960         * rs6000-aix-tdep.c: Use C++ exception handling.
4961         * riscv-tdep.c: Use C++ exception handling.
4962         * remote.c: Use C++ exception handling.
4963         * remote-fileio.c: Use C++ exception handling.
4964         * record-full.c: Use C++ exception handling.
4965         * record-btrace.c: Use C++ exception handling.
4966         * python/python.c: Use C++ exception handling.
4967         * python/py-value.c: Use C++ exception handling.
4968         * python/py-utils.c: Use C++ exception handling.
4969         * python/py-unwind.c: Use C++ exception handling.
4970         * python/py-type.c: Use C++ exception handling.
4971         * python/py-symbol.c: Use C++ exception handling.
4972         * python/py-record.c: Use C++ exception handling.
4973         * python/py-record-btrace.c: Use C++ exception handling.
4974         * python/py-progspace.c: Use C++ exception handling.
4975         * python/py-prettyprint.c: Use C++ exception handling.
4976         * python/py-param.c: Use C++ exception handling.
4977         * python/py-objfile.c: Use C++ exception handling.
4978         * python/py-linetable.c: Use C++ exception handling.
4979         * python/py-lazy-string.c: Use C++ exception handling.
4980         * python/py-infthread.c: Use C++ exception handling.
4981         * python/py-inferior.c: Use C++ exception handling.
4982         * python/py-gdb-readline.c: Use C++ exception handling.
4983         * python/py-framefilter.c: Use C++ exception handling.
4984         * python/py-frame.c: Use C++ exception handling.
4985         * python/py-finishbreakpoint.c: Use C++ exception handling.
4986         * python/py-cmd.c: Use C++ exception handling.
4987         * python/py-breakpoint.c: Use C++ exception handling.
4988         * python/py-arch.c: Use C++ exception handling.
4989         * printcmd.c: Use C++ exception handling.
4990         * ppc-linux-tdep.c: Use C++ exception handling.
4991         * parse.c: Use C++ exception handling.
4992         * p-valprint.c: Use C++ exception handling.
4993         * objc-lang.c: Use C++ exception handling.
4994         * mi/mi-main.c: Use C++ exception handling.
4995         * mi/mi-interp.c: Use C++ exception handling.
4996         * mi/mi-cmd-stack.c: Use C++ exception handling.
4997         * mi/mi-cmd-break.c: Use C++ exception handling.
4998         * main.c: Use C++ exception handling.
4999         * linux-thread-db.c: Use C++ exception handling.
5000         * linux-tdep.c: Use C++ exception handling.
5001         * linux-nat.c: Use C++ exception handling.
5002         * linux-fork.c: Use C++ exception handling.
5003         * linespec.c: Use C++ exception handling.
5004         * language.c: Use C++ exception handling.
5005         * jit.c: Use C++ exception handling.
5006         * infrun.c: Use C++ exception handling.
5007         * infcmd.c: Use C++ exception handling.
5008         * infcall.c: Use C++ exception handling.
5009         * inf-loop.c: Use C++ exception handling.
5010         * i386-tdep.c: Use C++ exception handling.
5011         * i386-linux-tdep.c: Use C++ exception handling.
5012         * guile/scm-value.c: Use C++ exception handling.
5013         * guile/scm-type.c: Use C++ exception handling.
5014         * guile/scm-symtab.c: Use C++ exception handling.
5015         * guile/scm-symbol.c: Use C++ exception handling.
5016         * guile/scm-pretty-print.c: Use C++ exception handling.
5017         * guile/scm-ports.c: Use C++ exception handling.
5018         * guile/scm-param.c: Use C++ exception handling.
5019         * guile/scm-math.c: Use C++ exception handling.
5020         * guile/scm-lazy-string.c: Use C++ exception handling.
5021         * guile/scm-frame.c: Use C++ exception handling.
5022         * guile/scm-disasm.c: Use C++ exception handling.
5023         * guile/scm-cmd.c: Use C++ exception handling.
5024         * guile/scm-breakpoint.c: Use C++ exception handling.
5025         * guile/scm-block.c: Use C++ exception handling.
5026         * guile/guile-internal.h: Use C++ exception handling.
5027         * gnu-v3-abi.c: Use C++ exception handling.
5028         * gdbtypes.c: Use C++ exception handling.
5029         * frame.c: Use C++ exception handling.
5030         * frame-unwind.c: Use C++ exception handling.
5031         * fbsd-tdep.c: Use C++ exception handling.
5032         * f-valprint.c: Use C++ exception handling.
5033         * exec.c: Use C++ exception handling.
5034         * event-top.c: Use C++ exception handling.
5035         * event-loop.c: Use C++ exception handling.
5036         * eval.c: Use C++ exception handling.
5037         * dwarf2read.c: Use C++ exception handling.
5038         * dwarf2loc.c: Use C++ exception handling.
5039         * dwarf2-frame.c: Use C++ exception handling.
5040         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5041         * dwarf-index-write.c: Use C++ exception handling.
5042         * dwarf-index-cache.c: Use C++ exception handling.
5043         * dtrace-probe.c: Use C++ exception handling.
5044         * disasm-selftests.c: Use C++ exception handling.
5045         * darwin-nat.c: Use C++ exception handling.
5046         * cp-valprint.c: Use C++ exception handling.
5047         * cp-support.c: Use C++ exception handling.
5048         * cp-abi.c: Use C++ exception handling.
5049         * corelow.c: Use C++ exception handling.
5050         * completer.c: Use C++ exception handling.
5051         * compile/compile-object-run.c: Use C++ exception handling.
5052         * compile/compile-object-load.c: Use C++ exception handling.
5053         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5054         * compile/compile-c-symbols.c: Use C++ exception handling.
5055         * common/selftest.c: Use C++ exception handling.
5056         * common/new-op.c: Use C++ exception handling.
5057         * cli/cli-script.c: Use C++ exception handling.
5058         * cli/cli-interp.c: Use C++ exception handling.
5059         * cli/cli-cmds.c: Use C++ exception handling.
5060         * c-varobj.c: Use C++ exception handling.
5061         * btrace.c: Use C++ exception handling.
5062         * breakpoint.c: Use C++ exception handling.
5063         * break-catch-throw.c: Use C++ exception handling.
5064         * arch-utils.c: Use C++ exception handling.
5065         * amd64-tdep.c: Use C++ exception handling.
5066         * ada-valprint.c: Use C++ exception handling.
5067         * ada-typeprint.c: Use C++ exception handling.
5068         * ada-lang.c: Use C++ exception handling.
5069         * aarch64-tdep.c: Use C++ exception handling.
5070
5071 2019-04-08  Tom Tromey  <tom@tromey.com>
5072
5073         * xml-support.c (gdb_xml_parser::parse): Update.
5074         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5075         * value.c (show_convenience): Update.
5076         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5077         (test_parse_flags_qcs): Update.
5078         * thread.c (thr_try_catch_cmd): Update.
5079         * target.c (target_translate_tls_address): Update.
5080         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5081         (info_frame_command_core, frame_apply_command_count): Update.
5082         * rust-exp.y (rust_lex_exception_test): Update.
5083         * riscv-tdep.c (riscv_print_one_register_info): Update.
5084         * remote.c (remote_target::enable_btrace): Update.
5085         * record-btrace.c (record_btrace_enable_warn): Update.
5086         * python/py-utils.c (gdbpy_convert_exception): Update.
5087         * printcmd.c (do_one_display, print_variable_and_value): Update.
5088         * mi/mi-main.c (mi_print_exception): Update.
5089         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5090         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5091         * linux-nat.c (linux_nat_target::attach): Update.
5092         * linux-fork.c (class scoped_switch_fork_info): Update.
5093         * infrun.c (displaced_step_prepare): Update.
5094         * infcall.c (call_function_by_hand_dummy): Update.
5095         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5096         * gnu-v3-abi.c (print_one_vtable): Update.
5097         * frame.c (get_prev_frame_always): Update.
5098         * f-valprint.c (info_common_command_for_block): Update.
5099         * exec.c (try_open_exec_file): Update.
5100         * exceptions.c (print_exception, exception_print)
5101         (exception_fprintf, exception_print_same): Update.
5102         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5103         * dwarf-index-cache.c (index_cache::store)
5104         (index_cache::lookup_gdb_index): Update.
5105         * darwin-nat.c (maybe_cache_shell): Update.
5106         * cp-valprint.c (cp_print_value_fields): Update.
5107         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5108         (gcc_cplus_symbol_address): Update.
5109         * compile/compile-c-symbols.c (gcc_convert_symbol)
5110         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5111         * common/selftest.c: Update.
5112         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5113         a std::string.
5114         (exception_try_scope_entry, exception_try_scope_exit): Don't
5115         declare.
5116         (struct exception_try_scope): Remove.
5117         (TRY): Don't use exception_try_scope.
5118         (struct gdb_exception): Add constructor, operator=.
5119         <what>: New method.
5120         (struct gdb_exception_RETURN_MASK_ALL)
5121         (struct gdb_exception_RETURN_MASK_ERROR)
5122         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5123         (struct gdb_quit_bad_alloc): Update.
5124         * common/common-exceptions.c (exception_none): Change
5125         initializer.
5126         (struct catcher) <state, exception>: Initialize inline.
5127         <prev>: Remove member.
5128         (current_catcher): Remove.
5129         (catchers): New global.
5130         (exceptions_state_mc_init): Simplify.
5131         (catcher_pop): Remove.
5132         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5133         (try_scope_depth, exception_try_scope_entry)
5134         (exception_try_scope_exit): Remove.
5135         (throw_exception_sjlj): Update.
5136         (exception_messages, exception_messages_size): Remove.
5137         (throw_it): Simplify.
5138         (gdb_exception_sliced_copy): Remove.
5139         (throw_exception_cxx): Update.
5140         * cli/cli-script.c (script_from_file): Update.
5141         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5142         Update.
5143         * ada-valprint.c (ada_val_print): Update.
5144         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5145         (create_excep_cond_exprs): Update.
5146
5147 2019-04-08  Tom Tromey  <tom@tromey.com>
5148
5149         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5150         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5151         (TRY, CATCH, END_CATCH): Remove some definitions.
5152         * common/common-exceptions.c: Don't use GDB_XCPT.
5153         (catcher_list_size): Remove.
5154         (throw_exception, throw_it): Simplify.
5155
5156 2019-04-05  Tom Tromey  <tom@tromey.com>
5157
5158         Revert the header-sorting patch.
5159         * ft32-tdep.c: Revert.
5160         * frv-tdep.c: Revert.
5161         * frv-linux-tdep.c: Revert.
5162         * frame.c: Revert.
5163         * frame-unwind.c: Revert.
5164         * frame-base.c: Revert.
5165         * fork-child.c: Revert.
5166         * findvar.c: Revert.
5167         * findcmd.c: Revert.
5168         * filesystem.c: Revert.
5169         * filename-seen-cache.h: Revert.
5170         * filename-seen-cache.c: Revert.
5171         * fbsd-tdep.c: Revert.
5172         * fbsd-nat.h: Revert.
5173         * fbsd-nat.c: Revert.
5174         * f-valprint.c: Revert.
5175         * f-typeprint.c: Revert.
5176         * f-lang.c: Revert.
5177         * extension.h: Revert.
5178         * extension.c: Revert.
5179         * extension-priv.h: Revert.
5180         * expprint.c: Revert.
5181         * exec.h: Revert.
5182         * exec.c: Revert.
5183         * exceptions.c: Revert.
5184         * event-top.c: Revert.
5185         * event-loop.c: Revert.
5186         * eval.c: Revert.
5187         * elfread.c: Revert.
5188         * dwarf2read.h: Revert.
5189         * dwarf2read.c: Revert.
5190         * dwarf2loc.c: Revert.
5191         * dwarf2expr.h: Revert.
5192         * dwarf2expr.c: Revert.
5193         * dwarf2-frame.c: Revert.
5194         * dwarf2-frame-tailcall.c: Revert.
5195         * dwarf-index-write.h: Revert.
5196         * dwarf-index-write.c: Revert.
5197         * dwarf-index-common.c: Revert.
5198         * dwarf-index-cache.h: Revert.
5199         * dwarf-index-cache.c: Revert.
5200         * dummy-frame.c: Revert.
5201         * dtrace-probe.c: Revert.
5202         * disasm.h: Revert.
5203         * disasm.c: Revert.
5204         * disasm-selftests.c: Revert.
5205         * dictionary.c: Revert.
5206         * dicos-tdep.c: Revert.
5207         * demangle.c: Revert.
5208         * dcache.h: Revert.
5209         * dcache.c: Revert.
5210         * darwin-nat.h: Revert.
5211         * darwin-nat.c: Revert.
5212         * darwin-nat-info.c: Revert.
5213         * d-valprint.c: Revert.
5214         * d-namespace.c: Revert.
5215         * d-lang.c: Revert.
5216         * ctf.c: Revert.
5217         * csky-tdep.c: Revert.
5218         * csky-linux-tdep.c: Revert.
5219         * cris-tdep.c: Revert.
5220         * cris-linux-tdep.c: Revert.
5221         * cp-valprint.c: Revert.
5222         * cp-support.c: Revert.
5223         * cp-namespace.c: Revert.
5224         * cp-abi.c: Revert.
5225         * corelow.c: Revert.
5226         * corefile.c: Revert.
5227         * continuations.c: Revert.
5228         * completer.h: Revert.
5229         * completer.c: Revert.
5230         * complaints.c: Revert.
5231         * coffread.c: Revert.
5232         * coff-pe-read.c: Revert.
5233         * cli-out.h: Revert.
5234         * cli-out.c: Revert.
5235         * charset.c: Revert.
5236         * c-varobj.c: Revert.
5237         * c-valprint.c: Revert.
5238         * c-typeprint.c: Revert.
5239         * c-lang.c: Revert.
5240         * buildsym.c: Revert.
5241         * buildsym-legacy.c: Revert.
5242         * build-id.h: Revert.
5243         * build-id.c: Revert.
5244         * btrace.c: Revert.
5245         * bsd-uthread.c: Revert.
5246         * breakpoint.h: Revert.
5247         * breakpoint.c: Revert.
5248         * break-catch-throw.c: Revert.
5249         * break-catch-syscall.c: Revert.
5250         * break-catch-sig.c: Revert.
5251         * blockframe.c: Revert.
5252         * block.c: Revert.
5253         * bfin-tdep.c: Revert.
5254         * bfin-linux-tdep.c: Revert.
5255         * bfd-target.c: Revert.
5256         * bcache.c: Revert.
5257         * ax-general.c: Revert.
5258         * ax-gdb.h: Revert.
5259         * ax-gdb.c: Revert.
5260         * avr-tdep.c: Revert.
5261         * auxv.c: Revert.
5262         * auto-load.c: Revert.
5263         * arm-wince-tdep.c: Revert.
5264         * arm-tdep.c: Revert.
5265         * arm-symbian-tdep.c: Revert.
5266         * arm-pikeos-tdep.c: Revert.
5267         * arm-obsd-tdep.c: Revert.
5268         * arm-nbsd-tdep.c: Revert.
5269         * arm-nbsd-nat.c: Revert.
5270         * arm-linux-tdep.c: Revert.
5271         * arm-linux-nat.c: Revert.
5272         * arm-fbsd-tdep.c: Revert.
5273         * arm-fbsd-nat.c: Revert.
5274         * arm-bsd-tdep.c: Revert.
5275         * arch-utils.c: Revert.
5276         * arc-tdep.c: Revert.
5277         * arc-newlib-tdep.c: Revert.
5278         * annotate.h: Revert.
5279         * annotate.c: Revert.
5280         * amd64-windows-tdep.c: Revert.
5281         * amd64-windows-nat.c: Revert.
5282         * amd64-tdep.c: Revert.
5283         * amd64-sol2-tdep.c: Revert.
5284         * amd64-obsd-tdep.c: Revert.
5285         * amd64-obsd-nat.c: Revert.
5286         * amd64-nbsd-tdep.c: Revert.
5287         * amd64-nbsd-nat.c: Revert.
5288         * amd64-nat.c: Revert.
5289         * amd64-linux-tdep.c: Revert.
5290         * amd64-linux-nat.c: Revert.
5291         * amd64-fbsd-tdep.c: Revert.
5292         * amd64-fbsd-nat.c: Revert.
5293         * amd64-dicos-tdep.c: Revert.
5294         * amd64-darwin-tdep.c: Revert.
5295         * amd64-bsd-nat.c: Revert.
5296         * alpha-tdep.c: Revert.
5297         * alpha-obsd-tdep.c: Revert.
5298         * alpha-nbsd-tdep.c: Revert.
5299         * alpha-mdebug-tdep.c: Revert.
5300         * alpha-linux-tdep.c: Revert.
5301         * alpha-linux-nat.c: Revert.
5302         * alpha-bsd-tdep.c: Revert.
5303         * alpha-bsd-nat.c: Revert.
5304         * aix-thread.c: Revert.
5305         * agent.c: Revert.
5306         * addrmap.c: Revert.
5307         * ada-varobj.c: Revert.
5308         * ada-valprint.c: Revert.
5309         * ada-typeprint.c: Revert.
5310         * ada-tasks.c: Revert.
5311         * ada-lang.c: Revert.
5312         * aarch64-tdep.c: Revert.
5313         * aarch64-ravenscar-thread.c: Revert.
5314         * aarch64-newlib-tdep.c: Revert.
5315         * aarch64-linux-tdep.c: Revert.
5316         * aarch64-linux-nat.c: Revert.
5317         * aarch64-fbsd-tdep.c: Revert.
5318         * aarch64-fbsd-nat.c: Revert.
5319         * aarch32-linux-nat.c: Revert.
5320
5321 2019-04-05  Tom Tromey  <tom@tromey.com>
5322
5323         * ft32-tdep.c: Sort headers.
5324         * frv-tdep.c: Sort headers.
5325         * frv-linux-tdep.c: Sort headers.
5326         * frame.c: Sort headers.
5327         * frame-unwind.c: Sort headers.
5328         * frame-base.c: Sort headers.
5329         * fork-child.c: Sort headers.
5330         * findvar.c: Sort headers.
5331         * findcmd.c: Sort headers.
5332         * filesystem.c: Sort headers.
5333         * filename-seen-cache.h: Sort headers.
5334         * filename-seen-cache.c: Sort headers.
5335         * fbsd-tdep.c: Sort headers.
5336         * fbsd-nat.h: Sort headers.
5337         * fbsd-nat.c: Sort headers.
5338         * f-valprint.c: Sort headers.
5339         * f-typeprint.c: Sort headers.
5340         * f-lang.c: Sort headers.
5341         * extension.h: Sort headers.
5342         * extension.c: Sort headers.
5343         * extension-priv.h: Sort headers.
5344         * expprint.c: Sort headers.
5345         * exec.h: Sort headers.
5346         * exec.c: Sort headers.
5347         * exceptions.c: Sort headers.
5348         * event-top.c: Sort headers.
5349         * event-loop.c: Sort headers.
5350         * eval.c: Sort headers.
5351         * elfread.c: Sort headers.
5352         * dwarf2read.h: Sort headers.
5353         * dwarf2read.c: Sort headers.
5354         * dwarf2loc.c: Sort headers.
5355         * dwarf2expr.h: Sort headers.
5356         * dwarf2expr.c: Sort headers.
5357         * dwarf2-frame.c: Sort headers.
5358         * dwarf2-frame-tailcall.c: Sort headers.
5359         * dwarf-index-write.h: Sort headers.
5360         * dwarf-index-write.c: Sort headers.
5361         * dwarf-index-common.c: Sort headers.
5362         * dwarf-index-cache.h: Sort headers.
5363         * dwarf-index-cache.c: Sort headers.
5364         * dummy-frame.c: Sort headers.
5365         * dtrace-probe.c: Sort headers.
5366         * disasm.h: Sort headers.
5367         * disasm.c: Sort headers.
5368         * disasm-selftests.c: Sort headers.
5369         * dictionary.c: Sort headers.
5370         * dicos-tdep.c: Sort headers.
5371         * demangle.c: Sort headers.
5372         * dcache.h: Sort headers.
5373         * dcache.c: Sort headers.
5374         * darwin-nat.h: Sort headers.
5375         * darwin-nat.c: Sort headers.
5376         * darwin-nat-info.c: Sort headers.
5377         * d-valprint.c: Sort headers.
5378         * d-namespace.c: Sort headers.
5379         * d-lang.c: Sort headers.
5380         * ctf.c: Sort headers.
5381         * csky-tdep.c: Sort headers.
5382         * csky-linux-tdep.c: Sort headers.
5383         * cris-tdep.c: Sort headers.
5384         * cris-linux-tdep.c: Sort headers.
5385         * cp-valprint.c: Sort headers.
5386         * cp-support.c: Sort headers.
5387         * cp-namespace.c: Sort headers.
5388         * cp-abi.c: Sort headers.
5389         * corelow.c: Sort headers.
5390         * corefile.c: Sort headers.
5391         * continuations.c: Sort headers.
5392         * completer.h: Sort headers.
5393         * completer.c: Sort headers.
5394         * complaints.c: Sort headers.
5395         * coffread.c: Sort headers.
5396         * coff-pe-read.c: Sort headers.
5397         * cli-out.h: Sort headers.
5398         * cli-out.c: Sort headers.
5399         * charset.c: Sort headers.
5400         * c-varobj.c: Sort headers.
5401         * c-valprint.c: Sort headers.
5402         * c-typeprint.c: Sort headers.
5403         * c-lang.c: Sort headers.
5404         * buildsym.c: Sort headers.
5405         * buildsym-legacy.c: Sort headers.
5406         * build-id.h: Sort headers.
5407         * build-id.c: Sort headers.
5408         * btrace.c: Sort headers.
5409         * bsd-uthread.c: Sort headers.
5410         * breakpoint.h: Sort headers.
5411         * breakpoint.c: Sort headers.
5412         * break-catch-throw.c: Sort headers.
5413         * break-catch-syscall.c: Sort headers.
5414         * break-catch-sig.c: Sort headers.
5415         * blockframe.c: Sort headers.
5416         * block.c: Sort headers.
5417         * bfin-tdep.c: Sort headers.
5418         * bfin-linux-tdep.c: Sort headers.
5419         * bfd-target.c: Sort headers.
5420         * bcache.c: Sort headers.
5421         * ax-general.c: Sort headers.
5422         * ax-gdb.h: Sort headers.
5423         * ax-gdb.c: Sort headers.
5424         * avr-tdep.c: Sort headers.
5425         * auxv.c: Sort headers.
5426         * auto-load.c: Sort headers.
5427         * arm-wince-tdep.c: Sort headers.
5428         * arm-tdep.c: Sort headers.
5429         * arm-symbian-tdep.c: Sort headers.
5430         * arm-pikeos-tdep.c: Sort headers.
5431         * arm-obsd-tdep.c: Sort headers.
5432         * arm-nbsd-tdep.c: Sort headers.
5433         * arm-nbsd-nat.c: Sort headers.
5434         * arm-linux-tdep.c: Sort headers.
5435         * arm-linux-nat.c: Sort headers.
5436         * arm-fbsd-tdep.c: Sort headers.
5437         * arm-fbsd-nat.c: Sort headers.
5438         * arm-bsd-tdep.c: Sort headers.
5439         * arch-utils.c: Sort headers.
5440         * arc-tdep.c: Sort headers.
5441         * arc-newlib-tdep.c: Sort headers.
5442         * annotate.h: Sort headers.
5443         * annotate.c: Sort headers.
5444         * amd64-windows-tdep.c: Sort headers.
5445         * amd64-windows-nat.c: Sort headers.
5446         * amd64-tdep.c: Sort headers.
5447         * amd64-sol2-tdep.c: Sort headers.
5448         * amd64-obsd-tdep.c: Sort headers.
5449         * amd64-obsd-nat.c: Sort headers.
5450         * amd64-nbsd-tdep.c: Sort headers.
5451         * amd64-nbsd-nat.c: Sort headers.
5452         * amd64-nat.c: Sort headers.
5453         * amd64-linux-tdep.c: Sort headers.
5454         * amd64-linux-nat.c: Sort headers.
5455         * amd64-fbsd-tdep.c: Sort headers.
5456         * amd64-fbsd-nat.c: Sort headers.
5457         * amd64-dicos-tdep.c: Sort headers.
5458         * amd64-darwin-tdep.c: Sort headers.
5459         * amd64-bsd-nat.c: Sort headers.
5460         * alpha-tdep.c: Sort headers.
5461         * alpha-obsd-tdep.c: Sort headers.
5462         * alpha-nbsd-tdep.c: Sort headers.
5463         * alpha-mdebug-tdep.c: Sort headers.
5464         * alpha-linux-tdep.c: Sort headers.
5465         * alpha-linux-nat.c: Sort headers.
5466         * alpha-bsd-tdep.c: Sort headers.
5467         * alpha-bsd-nat.c: Sort headers.
5468         * aix-thread.c: Sort headers.
5469         * agent.c: Sort headers.
5470         * addrmap.c: Sort headers.
5471         * ada-varobj.c: Sort headers.
5472         * ada-valprint.c: Sort headers.
5473         * ada-typeprint.c: Sort headers.
5474         * ada-tasks.c: Sort headers.
5475         * ada-lang.c: Sort headers.
5476         * aarch64-tdep.c: Sort headers.
5477         * aarch64-ravenscar-thread.c: Sort headers.
5478         * aarch64-newlib-tdep.c: Sort headers.
5479         * aarch64-linux-tdep.c: Sort headers.
5480         * aarch64-linux-nat.c: Sort headers.
5481         * aarch64-fbsd-tdep.c: Sort headers.
5482         * aarch64-fbsd-nat.c: Sort headers.
5483         * aarch32-linux-nat.c: Sort headers.
5484
5485 2019-04-04  Tom Tromey  <tom@tromey.com>
5486
5487         * varobj.c (varobj_create): Update.
5488         * rust-exp.y (struct rust_parser) <update_innermost_block,
5489         lookup_symbol>: New methods.
5490         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5491         Rename.
5492         (rust_parser::rust_lookup_type)
5493         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5494         * printcmd.c (display_command, do_one_display): Update.
5495         * parser-defs.h (struct parser_state) <parser_state>: Add
5496         "tracker" parameter.
5497         (block_tracker): New member.
5498         (class innermost_block_tracker) <innermost_block_tracker>: Add
5499         "types" parameter.
5500         <reset>: Remove method.
5501         (innermost_block): Don't declare.
5502         (null_post_parser): Update.
5503         * parse.c (innermost_block): Remove global.
5504         (write_dollar_variable): Update.
5505         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5506         Remove "tracker_types" parameter.
5507         (parse_expression): Add "tracker" parameter.
5508         (parse_expression_for_completion): Update.
5509         (null_post_parser): Add "tracker" parameter.
5510         * p-exp.y: Update rules.
5511         * m2-exp.y: Update rules.
5512         * language.h (struct language_defn) <la_post_parser>: Add
5513         "tracker" parameter.
5514         * go-exp.y: Update rules.
5515         * f-exp.y: Update rules.
5516         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5517         parameter.
5518         * d-exp.y: Update rules.
5519         * c-exp.y: Update rules.
5520         * breakpoint.c (set_breakpoint_condition): Create an
5521         innermost_block_tracker.
5522         (watch_command_1): Likewise.
5523         * ada-lang.c (resolve): Add "tracker" parameter.
5524         (resolve_subexp): Likewise.
5525         * ada-exp.y (write_var_from_sym): Update.
5526
5527 2019-04-04  Tom Tromey  <tom@tromey.com>
5528
5529         * type-stack.h: New file.
5530         * type-stack.c: New file.
5531         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5532         type-stack.h.
5533         (insert_into_type_stack, insert_type, push_type, push_type_int)
5534         (insert_type_address_space, pop_type, pop_type_int)
5535         (pop_typelist, pop_type_stack, append_type_stack)
5536         (push_type_stack, get_type_stack, push_typelist)
5537         (follow_type_instance_flags, follow_types): Don't declare.
5538         * parse.c (type_stack): Remove global.
5539         (parse_exp_in_context): Update.
5540         (insert_into_type_stack, insert_type, push_type, push_type_int)
5541         (insert_type_address_space, pop_type, pop_type_int)
5542         (pop_typelist, pop_type_stack, append_type_stack)
5543         (push_type_stack, get_type_stack, push_typelist)
5544         (follow_type_instance_flags, follow_types): Remove (moved to
5545         type-stack.c).
5546         * f-exp.y (type_stack): New global.
5547         Update rules.
5548         (push_kind_type, f_parse): Update.
5549         * d-exp.y (type_stack): New global.
5550         Update rules.
5551         (d_parse): Update.
5552         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5553         Update rules.
5554         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5555         (HFILES_NO_SRCDIR): Add type-stack.h.
5556
5557 2019-04-04  Tom Tromey  <tom@tromey.com>
5558
5559         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5560         (rust_parser::convert_ast_to_expression, rust_parse)
5561         (rust_lex_test_completion, rust_lex_tests): Update.
5562         * parser-defs.h (struct expr_completion_state): New.
5563         (struct parser_state) <parser_state>: Add completion parameter.
5564         <mark_struct_expression, mark_completion_tag>: New methods.
5565         <parse_completion, m_completion_state>: New members.
5566         (prefixify_expression, null_post_parser): Update.
5567         (mark_struct_expression, mark_completion_tag): Don't declare.
5568         * parse.c (parse_completion, expout_last_struct)
5569         (expout_tag_completion_type, expout_completion_name): Remove
5570         globals.
5571         (parser_state::mark_struct_expression)
5572         (parser_state::mark_completion_tag): Now methods.
5573         (prefixify_expression): Add last_struct parameter.
5574         (prefixify_subexp): Likewise.
5575         (parse_exp_1): Update.
5576         (parse_exp_in_context): Add cstate parameter.  Update.
5577         (parse_expression_for_completion): Create an
5578         expr_completion_state.
5579         (null_post_parser): Add "completion" parameter.
5580         * p-exp.y: Update rules.
5581         (yylex): Update.
5582         * language.h (struct language_defn) <la_post_parser>: Add
5583         "completing" parameter.
5584         * go-exp.y: Update rules.
5585         (lex_one_token): Update.
5586         * expression.h (parse_completion): Don't declare.
5587         * d-exp.y: Update rules.
5588         (lex_one_token): Update rules.
5589         * c-exp.y: Update rules.
5590         (lex_one_token): Update.
5591         * ada-lang.c (resolve): Add "parse_completion" parameter.
5592         (resolve_subexp): Likewise.
5593         (ada_resolve_function): Likewise.
5594
5595 2019-04-04  Tom Tromey  <tom@tromey.com>
5596
5597         * parser-defs.h (struct parser_state) <start_arglist,
5598         end_arglist>: New methods.
5599         <arglist_len, m_funcall_chain>: New members.
5600         (arglist_len, start_arglist, end_arglist): Don't declare.
5601         * parse.c (arglist_len, funcall_chain): Remove global.
5602         (start_arglist, end_arglist): Remove functions.
5603         (parse_exp_in_context): Update.
5604         * p-exp.y: Update rules.
5605         * m2-exp.y: Update rules.
5606         * go-exp.y: Update rules.
5607         * f-exp.y: Update rules.
5608         * d-exp.y: Update rules.
5609         * c-exp.y: Update rules.
5610
5611 2019-04-04  Tom Tromey  <tom@tromey.com>
5612
5613         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5614         lex_operator, push_back>: New methods.
5615         Update all rules.
5616         (rust_parser::lex_hex, lex_escape): Rename and update.
5617         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5618         (rust_parser::lex_operator): Rename and update.
5619         (rust_parser::lex_number, rustyylex, rustyyerror)
5620         (rust_lex_test_init, rust_lex_test_sequence)
5621         (rust_lex_test_push_back, rust_lex_tests): Update.
5622         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5623         parameter.
5624         <lexptr, prev_lexptr>: New members.
5625         (lexptr, prev_lexptr): Don't declare.
5626         * parse.c (lexptr, prev_lexptr): Remove globals.
5627         (parse_exp_in_context): Update.
5628         * p-exp.y (yylex, yyerror): Update.
5629         * m2-exp.y (parse_number, yylex, yyerror): Update.
5630         * go-exp.y (lex_one_token, yyerror): Update.
5631         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5632         * d-exp.y (lex_one_token, yyerror): Update.
5633         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5634         (lex_one_token, yyerror): Update.
5635         * ada-lex.l (YY_INPUT): Update.
5636         (rewind_to_char): Update.
5637         * ada-exp.y (yyerror): Update.
5638
5639 2019-04-04  Tom Tromey  <tom@tromey.com>
5640
5641         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5642         * parser-defs.h (struct parser_state) <parser_state>: Add new
5643         parameter.
5644         <comma_terminates>: New member.
5645         (comma_terminates): Don't declare global.
5646         * parse.c (comma_terminates): Remove global.
5647         (parse_exp_in_context): Update.
5648         * p-exp.y (yylex): Update.
5649         * m2-exp.y (yylex): Update.
5650         * go-exp.y (lex_one_token): Update.
5651         * f-exp.y (yylex): Update.
5652         * d-exp.y (lex_one_token): Update.
5653         * c-exp.y (lex_one_token): Update.
5654         * ada-lex.l: Update.
5655
5656 2019-04-04  Tom Tromey  <tom@tromey.com>
5657
5658         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5659         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5660         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5661         * parser-defs.h (paren_depth): Don't declare.
5662         * parse.c (paren_depth): Remove global.
5663         (parse_exp_in_context): Update.
5664         * p-exp.y (paren_depth): New global.
5665         (pascal_parse): Initialize it.
5666         * m2-exp.y (paren_depth): New global.
5667         (m2_parse): Initialize it.
5668         * go-exp.y (paren_depth): New global.
5669         (go_parse): Initialize it.
5670         * f-exp.y (paren_depth): New global.
5671         (f_parse): Initialize it.
5672         * d-exp.y (paren_depth): New global.
5673         (d_parse): Initialize it.
5674         * c-exp.y (paren_depth): New global.
5675         (c_parse): Initialize it.
5676         * ada-lex.l (paren_depth): New global.
5677         (lexer_init): Initialize it.
5678
5679 2019-04-04  Tom Tromey  <tom@tromey.com>
5680
5681         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5682         (rust_parser::convert_ast_to_type)
5683         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5684         * parser-defs.h (struct parser_state) <parser_state>: Add
5685         parameters.  Initialize new members.
5686         <expression_context_block, expression_context_pc>: New members.
5687         * parse.c (expression_context_block, expression_context_pc):
5688         Remove globals.
5689         (parse_exp_in_context): Update.
5690         * p-exp.y: Update all rules.
5691         (yylex): Update.
5692         * m2-exp.y: Update all rules.
5693         (yylex): Update.
5694         * go-exp.y (yylex): Update.
5695         * f-exp.y (yylex): Update.
5696         * d-exp.y: Update all rules.
5697         (yylex): Update.
5698         * c-exp.y: Update all rules.
5699         (lex_one_token, classify_name, yylex, c_parse): Update.
5700         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5701
5702 2019-04-04  Tom Tromey  <tom@tromey.com>
5703
5704         * gdbarch.h, gdbarch.c: Rebuild.
5705         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5706         * stap-probe.h:
5707         (struct stap_parse_info): Replace "parser_state" with
5708         "expr_builder".
5709         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5710         (parser_state): New class.
5711         * parse.c (expr_builder): Rename.
5712         (expr_builder::release): Rename.
5713         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5714         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5715         (write_exp_elt_longcst, write_exp_elt_floatcst)
5716         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5717         (write_exp_string_vector, write_exp_bitstring)
5718         (write_exp_msymbol, mark_struct_expression)
5719         (write_dollar_variable)
5720         (insert_type_address_space, increase_expout_size): Replace
5721         "parser_state" with "expr_builder".
5722         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5723         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5724         "parser_state" with "expr_builder".
5725
5726 2019-04-04  Tom Tromey  <tom@tromey.com>
5727
5728         * rust-exp.y: Replace "parse_language" with method call.
5729         * p-exp.y:
5730         (yylex): Replace "parse_language" with method call.
5731         * m2-exp.y:
5732         (yylex): Replace "parse_language" with method call.
5733         * go-exp.y (classify_name): Replace "parse_language" with method
5734         call.
5735         * f-exp.y (yylex): Replace "parse_language" with method call.
5736         * d-exp.y (lex_one_token): Replace "parse_language" with method
5737         call.
5738         * c-exp.y:
5739         (lex_one_token, classify_name, yylex): Replace "parse_language"
5740         with method call.
5741         * ada-exp.y (find_primitive_type, type_char)
5742         (type_system_address): Replace "parse_language" with method call.
5743
5744 2019-04-04  Tom Tromey  <tom@tromey.com>
5745
5746         * rust-exp.y: Replace "parse_gdbarch" with method call.
5747         * parse.c (write_dollar_variable, insert_type_address_space):
5748         Replace "parse_gdbarch" with method call.
5749         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5750         call.
5751         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5752         call.
5753         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5754         "parse_gdbarch" with method call.
5755         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5756         with method call.
5757         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5758         "parse_gdbarch" with method call.
5759         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5760         "parse_gdbarch" with method call.
5761         * c-exp.y (parse_type, parse_number, classify_name): Replace
5762         "parse_gdbarch" with method call.
5763         * ada-lex.l: Replace "parse_gdbarch" with method call.
5764         * ada-exp.y (parse_type, find_primitive_type, type_char)
5765         (type_system_address): Replace "parse_gdbarch" with method call.
5766
5767 2019-04-04  Tom Tromey  <tom@tromey.com>
5768
5769         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5770         * stap-probe.c (stap_parse_argument): Update.
5771         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5772         initial_size parameter.
5773         * rust-exp.y (rust_lex_tests): Update.
5774         * parse.c (parser_state): Update.
5775         (parse_exp_in_context): Update.
5776         * parser-defs.h (struct parser_state) <parser_state>: Remove
5777         "initial_size" parameter.
5778
5779 2019-04-04  Tom Tromey  <tom@tromey.com>
5780
5781         * parser-defs.h (increase_expout_size): Don't declare.
5782         * parse.c (increase_expout_size): Now static.
5783
5784 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5785
5786         * gnu-nat.c (gnu_nat_target::wait): Fix
5787         target_waitstatus_to_string call.
5788
5789 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5790
5791         * eval.c (evaluate_subexp_standard): Handle internal functions
5792         during Fortran function call handling.
5793
5794 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5795
5796         * NEWS: Mention new internal functions.
5797         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5798         (read_base_type): Use dwarf2_init_complex_target_type.
5799         * value.c (creal_internal_fn): New function.
5800         (cimag_internal_fn): New function.
5801         (_initialize_values): Register new internal functions.
5802
5803 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5804
5805         * infrun.c (stop_all_threads): If debug_infrun, always
5806         trace the wait status after wait_one, using
5807         target_waitstatus_to_string and target_pid_to_str.
5808         (handle_inferior_event): Replace various trace of
5809         wait status kind by a single trace.
5810         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5811         wait status kind image by target_waitstatus_to_string.
5812         * target/waitstatus.c (target_waitstatus_to_string): Fix
5813         obsolete comment.
5814
5815 2019-04-01  Tom Tromey  <tromey@adacore.com>
5816
5817         PR symtab/23331:
5818         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5819
5820 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5821             Pedro Alves  <palves@redhat.com>
5822
5823         * top.c (quit_force): Call 'finalize_values'.
5824         * value.c (finalize_values): New function.
5825         * value.h (finalize_values): Declare.
5826
5827 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5828
5829         * NEWS: Announce $_gdb_major and $_gdb_minor.
5830
5831         * top.c (init_gdb_version_vars): New function.
5832         (gdb_init): Call init_gdb_version_vars.
5833
5834 2019-03-29  Tom Tromey  <tromey@adacore.com>
5835
5836         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5837         help text.  Remove dead code.
5838
5839 2019-03-29  Keith Seitz  <keiths@redhat.com>
5840
5841         From Siddhesh Poyarekar:
5842         * f-lang.h (f77_get_upperbound): Return LONGEST.
5843         (f77_get_lowerbound): Likewise.
5844         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5845         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5846         print them.
5847         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5848         plongest to format print it.
5849         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5850         (f77_get_upperbound): Likewise.
5851         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5852         LOWER_BOUND to LONGEST.
5853         (f77_create_arrayprint_offset_tbl): Likewise.
5854
5855 2019-03-29  Keith Seitz  <keiths@redhat.com>
5856
5857         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5858         %s/pulongest for TYPE_LENGTH instead of %d in format
5859         strings.
5860         * ada-typerint.c (ada_print_type): Likewise.
5861         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5862         * compile/compile-c-support.c (generate_register_struct): Likewise.
5863         * gdbtypes.c (recursive_dump_type): Likewise.
5864         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5865         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5866         instead of %d in format strings.
5867         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5868         to std::min to ULONGEST.
5869         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5870         instead of %d in format strings.
5871         * tracepoint.c (info_scope_command): Likewise.
5872         * typeprint.c (print_offset_data::update)
5873         (print_offset_data::finish): Likewise.
5874         * xtensa-tdep.c (xtensa_store_return_value)
5875         (xtensa_push_dummy_call): Likewise.
5876
5877 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5878
5879         * windows-nat.c (display_selector): Fixed format specifications
5880         for 64-bit Cygwin.
5881
5882 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5883
5884         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5885
5886 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5887
5888         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5889         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5890         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5891         (nios2_linux_init_abi): Install it.
5892
5893 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5894
5895         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5896
5897 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5898
5899         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5900
5901 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5902             Tom Tromey  <tromey@adacore.com>
5903
5904         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5905
5906 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5907
5908         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5909         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5910         method to compute the bounds of range types. Also print "[evaluated]"
5911         if the bounds' values come from a dynamic evaluation.
5912
5913 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5914
5915         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5916         whitespace when pretty printing is on.
5917
5918 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5919
5920         * ppc-linux-nat.c: Add include.
5921
5922 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5923
5924         * NEWS: Mention AArch64 Pointer Authentication.
5925
5926 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5927
5928         * arm-linux-nat.c: Add include.
5929
5930 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5931
5932         * source-cache.c (source_cache::get_source_lines): Re-read
5933         fullname after calling open_source_file.
5934
5935 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5936
5937         * NEWS: Mention TLS support for FreeBSD.
5938
5939 2019-03-25  Tom Tromey  <tromey@adacore.com>
5940
5941         * minsyms.c (BUNCH_SIZE): Update comment.
5942         (~minimal_symbol_reader): Remove old comment.
5943         (compact_minimal_symbols): Update comment.
5944         (minimal_symbol_reader::install): Remove old comment.  Update
5945         other comments.
5946
5947 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5948
5949         * s390-linux-nat.c: Add include.
5950
5951 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5952
5953         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5954         Call linux_get_hwcap.
5955         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5956         Likewise.
5957         (aarch64_linux_get_hwcap): Remove function.
5958         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5959         declaration.
5960         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5961         linux_get_hwcap.
5962         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5963         * linux-tdep.c (linux_get_hwcap): Add function.
5964         (linux_get_hwcap2): Likewise.
5965         * linux-tdep.h (linux_get_hwcap): Add declaration.
5966         (linux_get_hwcap2): Likewise.
5967         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5968         (ppc_linux_get_hwcap2): Likewise.
5969         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5970         linux_get_hwcap.
5971         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5972         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5973         (ppc_linux_nat_target::read_description): Likewise.
5974         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5975         * s390-linux-nat.c: Likewise.
5976         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5977
5978 2019-03-24  Tom Tromey  <tom@tromey.com>
5979
5980         * ada-lang.c (standard_lookup): Simplify initialization.
5981         (ada_lookup_symbol_nonlocal): Simplify return.
5982         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5983         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5984         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5985         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5986         initialization.
5987         * solib.c (solib_global_lookup): Simplify.
5988         * symtab.c (null_block_symbol): Remove.
5989         (symbol_cache_lookup): Simplify returns.
5990         (lookup_language_this): Simplify returns.
5991         (lookup_symbol_aux): Simplify return.
5992         (lookup_local_symbol): Simplify returns.
5993         (lookup_global_symbol_from_objfile): Simplify return.
5994         (lookup_symbol_in_objfile_symtabs)
5995         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5996         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5997         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5998         * cp-namespace.c (cp_lookup_bare_symbol)
5999         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6000         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6001         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6002         (cp_lookup_symbol_via_imports): Simplify initialization.
6003         (find_symbol_in_baseclass): Likewise.
6004         * symtab.h (null_block_symbol): Remove.
6005         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6006         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6007         (d_lookup_symbol_module): Likewise.
6008         (find_symbol_in_baseclass): Simplify initialization.
6009
6010 2019-03-24  Tom Tromey  <tom@tromey.com>
6011
6012         * expression.h: Don't include symtab.h.
6013         (struct block): Forward declare.
6014
6015 2019-03-24  Tom Tromey  <tom@tromey.com>
6016
6017         * c-exp.y (typebase): Remove casts.
6018         * gdbtypes.c (lookup_unsigned_typename, )
6019         (lookup_signed_typename): Remove cast.
6020         * eval.c (parse_to_comma_and_eval): Remove cast.
6021         * parse.c (write_dollar_variable): Remove cast.
6022         * block.h (struct block) <superblock>: Now const.
6023         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6024         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6025         (map_block): Make "block" const.
6026         * symfile.h (struct quick_symbol_functions)
6027         <map_matching_symbols>: Constify block argument to "callback".
6028         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6029         const.
6030         (find_pc_sect_compunit_symtab): Make "b" const.
6031         (find_symbol_at_address): Likewise.
6032         (search_symbols): Likewise.
6033         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6034         (dw2_debug_names_lookup_symbol): Likewise.
6035         (dw2_map_matching_symbols): Update.
6036         * p-valprint.c (pascal_val_print): Remove "block".
6037         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6038         (aux_add_nonlocal_symbols): Make "block" const.
6039         (resolve_subexp): Remove cast.
6040         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6041         const.
6042         (iterate_over_file_blocks): Likewise.
6043         * f-exp.y (%union) <bval>: Remove.
6044         * coffread.c (patch_opaque_types): Make "b" const.
6045         * spu-tdep.c (spu_catch_start): Make "block" const.
6046         * c-valprint.c (print_unpacked_pointer): Remove "block".
6047         * symmisc.c (dump_symtab_1): Make "b" const.
6048         (block_depth): Make "block" const.
6049         * d-exp.y (%union) <bval>: Remove.
6050         * cp-support.h (cp_lookup_rtti_type): Update.
6051         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6052         * psymtab.c (psym_lookup_symbol): Make "block" const.
6053         (maintenance_check_psymtabs): Make "b" const.
6054         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6055         (enumerate_locals, enumerate_args): Update.
6056         * python/py-symtab.c (stpy_global_block): Make "block" const.
6057         (stpy_static_block): Likewise.
6058         * inline-frame.c (block_starting_point_at): Make "new_block"
6059         const.
6060         * block.c (find_block_in_blockvector): Make return type const.
6061         (blockvector_for_pc_sect): Make "b" const.
6062         (find_block_in_blockvector): Make "b" const.
6063
6064 2019-03-23  Tom Tromey  <tom@tromey.com>
6065
6066         * varobj.c (varobj_create): Update.
6067         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6068         * printcmd.c (display_command, do_one_display): Don't reset
6069         innermost_block.
6070         * parser-defs.h (enum innermost_block_tracker_type): Move to
6071         expression.h.
6072         (innermost_block): Update comment.
6073         * parse.c (parse_exp_1): Add tracker_types parameter.
6074         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6075         tracker_types parameter.  Reset innermost_block.
6076         (parse_exp_in_context): Remove.
6077         (parse_expression_for_completion): Update.
6078         * objfiles.c (~objfile): Don't reset expression_context_block or
6079         innermost_block.
6080         * expression.h (enum innermost_block_tracker_type): Move from
6081         parser-defs.h.
6082         (parse_exp_1): Add tracker_types parameter.
6083         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6084         reset innermost_block.
6085
6086 2019-03-23  Tom Tromey  <tom@tromey.com>
6087
6088         * objfiles.h: Include bcache.h.
6089
6090 2019-03-23  Tom Tromey  <tom@tromey.com>
6091
6092         * linespec.c (get_current_search_block): Use
6093         scoped_restore_current_language.
6094         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6095
6096 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6097             Jiong Wang  <jiong.wang@arm.com>
6098
6099         * aarch64-linux-tdep.c
6100         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6101         section.
6102         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6103
6104 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6105             Jiong Wang  <jiong.wang@arm.com>
6106
6107         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6108         instructions.
6109         (aarch64_analyze_prologue_test): Add PACIASP test.
6110         (aarch64_prologue_prev_register): Unmask PC value.
6111
6112 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6113             Jiong Wang  <jiong.wang@arm.com>
6114
6115         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6116         (aarch64_dwarf2_prev_register): Unmask PC value.
6117         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6118         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6119         DW_CFA_AARCH64_negate_ra_state.
6120         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6121
6122 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6123             Jiong Wang  <jiong.wang@arm.com>
6124
6125         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6126         registers.
6127         (aarch64_pseudo_register_name): Likewise.
6128         (aarch64_pseudo_register_type): Likewise.
6129         (aarch64_pseudo_register_reggroup_p): Likewise.
6130         (aarch64_gdbarch_init): Add pauth registers.
6131         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6132         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6133         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6134         (struct gdbarch_tdep): Add regnum for ra_state.
6135
6136 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6137             Jiong Wang  <jiong.wang@arm.com>
6138
6139         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6140
6141 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6142             Jiong Wang  <jiong.wang@arm.com>
6143
6144         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6145         function.
6146         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6147         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6148         (aarch64_gdbarch_init): Add puth registers.
6149         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6150         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6151         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6152
6153 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6154             Jiong Wang  <jiong.wang@arm.com>
6155
6156         * aarch64-linux-nat.c
6157         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6158         * aarch64-linux-tdep.c
6159         (aarch64_linux_core_read_description): Likewise.
6160         (aarch64_linux_get_hwcap): New function.
6161         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6162         (aarch64_linux_get_hwcap): New declaration.
6163
6164 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6165             Jiong Wang  <jiong.wang@arm.com>
6166
6167         * aarch64-linux-nat.c
6168         (aarch64_linux_nat_target::read_description): Add pauth param.
6169         * aarch64-linux-tdep.c
6170         (aarch64_linux_core_read_description): Likewise.
6171         * aarch64-tdep.c (struct target_desc): Add in pauth.
6172         (aarch64_read_description): Add pauth param.
6173         (aarch64_gdbarch_init): Likewise.
6174         * aarch64-tdep.h (aarch64_read_description): Likewise.
6175         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6176         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6177         * features/Makefile: Add new files.
6178         * features/aarch64-pauth.c: New file.
6179         * features/aarch64-pauth.xml: New file.
6180
6181 2019-03-20  Tom Tromey  <tromey@adacore.com>
6182
6183         * infrun.c (handle_inferior_event): Rename from
6184         handle_inferior_event_1.  Create a scoped_value_mark.
6185         (handle_inferior_event): Remove.
6186
6187 2019-03-19  Tom Tromey  <tromey@adacore.com>
6188
6189         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6190         * infrun.h (print_stop_event): Add "displays" parameter.
6191         * infrun.c (print_stop_event): Add "displays" parameter.
6192
6193 2019-03-19  Pedro Alves  <palves@redhat.com>
6194
6195         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6196         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6197         to -1.  Fix TABs vs spaces.
6198         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6199         * tui/tui-out.h (tui_ui_out) Add intro comments.
6200         <m_line, m_start_of_line>: In-class initialize, and add describing
6201         comment.
6202
6203 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6204
6205         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6206         variable names.
6207         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6208
6209 2019-03-18  Pedro Alves  <palves@redhat.com>
6210             Eli Zaretskii <eliz@gnu.org>
6211
6212         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6213         m_line and m_start_of_line.
6214
6215 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6216
6217         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6218         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6219         it returns a newline.  This fixes a regression in TU mode, whereby
6220         the next line is output on the same screen line as the user input.
6221
6222 2019-03-18  Tom Tromey  <tromey@adacore.com>
6223
6224         * minsyms.c (minimal_symbol_reader::install): Remove call to
6225         obstack_blank.
6226
6227 2019-03-18  Pedro Alves  <palves@redhat.com>
6228
6229         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6230         New globals.
6231         (apply_style): New, factored out from ...
6232         (apply_ansi_escape): ... this.  Handle reverse video mode.
6233         (tui_set_reverse_mode): New function.
6234         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6235         * tui/tui-winsource.c (tui_show_source_line): Use
6236         tui_set_reverse_mode instead of setting A_STANDOUT.
6237         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6238         New setter methods.
6239
6240 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6241
6242         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6243         Handle tabs.
6244
6245 2019-03-18  Tom Tromey  <tromey@adacore.com>
6246
6247         * ada-lang.c (empty_array): Add "high" parameter.
6248         (ada_evaluate_subexp): Update.
6249
6250 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6251
6252         * unittests/string_view-selftests.c: Define
6253         _initialize_string_view_selftests unconditionally.
6254
6255 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6256
6257         PR gdb/24350
6258         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6259
6260 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6261
6262         PR gdb/24351
6263         * windows-nat.c (display_selector): Fix format specifiers.
6264
6265 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6266
6267         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6268         tui_refill_source_window instead of tui_refresh_win, to update the
6269         current execution line.  This fixes redisplay of the current line
6270         when stepping through the code with "next" or "step".
6271
6272 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6273
6274         * source-cache.c (source_cache::get_source_lines): Call
6275         find_source_lines to initialize s->nlines.  This fixes vertical
6276         scrolling of TUI source window when the DOWN arrow is pressed.
6277
6278 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6279
6280         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6281         linux-thread-db.c (_initialize_thread_db): Likewise.
6282
6283 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6284
6285         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6286         wclrtoeol in tui_show_source_line".  This reverts changes made in
6287         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6288
6289 2019-03-15  Tom Tromey  <tom@tromey.com>
6290
6291         * symtab.h (struct minimal_symbol): Derive from
6292         general_symbol_info.
6293         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6294         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6295         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6296         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6297         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6298         (MSYMBOL_SEARCH_NAME): Update.
6299         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6300         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6301         * minsyms.c (minimal_symbol_reader::record_full): Update.
6302
6303 2019-03-15  Tom Tromey  <tom@tromey.com>
6304
6305         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6306
6307 2019-03-15  Tom Tromey  <tom@tromey.com>
6308
6309         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6310         unique_xmalloc_ptr.
6311         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6312         Update.
6313         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6314         (build_minimal_symbol_hash_tables)
6315         (minimal_symbol_reader::install): Update.
6316
6317 2019-03-15  Tom Tromey  <tom@tromey.com>
6318
6319         * symtab.c (create_demangled_names_hash): Update.
6320         (symbol_set_names): Update.
6321         * objfiles.h (struct objfile_per_bfd_storage)
6322         <demangled_names_hash>: Now an htab_up.
6323         * objfiles.c (objfile_per_bfd_storage): Simplify.
6324
6325 2019-03-15  Tom Tromey  <tom@tromey.com>
6326
6327         * objfiles.h (struct objfile_per_bfd_storage): Declare
6328         destructor.
6329         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6330         New.
6331         (get_objfile_bfd_data): Use new.  Don't initialize
6332         language_of_main.
6333         (free_objfile_per_bfd_storage): Remove.
6334         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6335
6336 2019-03-15  Tom Tromey  <tom@tromey.com>
6337
6338         * symfile.c (reread_symbols): Update.
6339         * objfiles.c (objfile::objfile): Update.
6340         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6341         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6342         comment.
6343         (minimal_symbol_reader::install): Update.
6344         (terminate_minimal_symbol_table): Remove.
6345         * jit.c (jit_object_close_impl): Update.
6346
6347 2019-03-15  Tom Tromey  <tom@tromey.com>
6348
6349         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6350         initializations.
6351
6352 2019-03-15  Tom Tromey  <tom@tromey.com>
6353
6354         * objfiles.h (struct objfile_per_bfd_storage)
6355         <demangled_hash_languages>: Now a bitset.
6356         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6357         (lookup_minimal_symbol): Update.
6358
6359 2019-03-15  Tom Tromey  <tom@tromey.com>
6360
6361         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6362         Don't return the symbol.
6363         * coffread.c (record_minimal_symbol): Use record_full.
6364
6365 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6366
6367         The MS-Windows port of ncurses fails to switch to a color pair if
6368         one or both of the colors are the implicit default colors.  This
6369         change records the default colors when TUI is initialized, and
6370         then specifies them explicitly when a color pair uses the default
6371         colors.  This allows color styling in TUI mode on MS-Windows.
6372
6373         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6374         ncurses_norm_attr.
6375         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6376         colors in ncurses_norm_attr.
6377         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6378         "none", replace it with the default color recorded in
6379         ncurses_norm_attr.
6380
6381 2019-03-14  Tom Tromey  <tromey@adacore.com>
6382
6383         * source-cache.h (class source_cache) <get_source_lines>: Return
6384         std::string.
6385         * source-cache.c (source_cache::extract_lines): Handle case where
6386         first_pos==npos.  Return std::string.
6387         (source_cache::get_source_lines): Update.
6388
6389 2019-03-14  Tom Tromey  <tromey@adacore.com>
6390
6391         * NEWS: Add item for "style sources" commands.
6392         * source-cache.c (source_cache::get_source_lines): Check
6393         source_styling.
6394         * cli/cli-style.c (source_styling): New global.
6395         (_initialize_cli_style): Add "style sources" commands.
6396         (show_style_sources): New function.
6397         * cli/cli-style.h (source_styling): Declare.
6398
6399 2019-03-14  Pedro Alves  <palves@redhat.com>
6400             Tom Tromey  <tromey@adacore.com>
6401
6402         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6403         * tui/tui-winsource.c (tui_refill_source_window): New function,
6404         from...
6405         (tui_horizontal_source_scroll): ... here.  Move some logic.
6406         * cli/cli-style.c (set_style_enabled): Notify new observable.
6407         * tui/tui-hooks.c (tui_redisplay_source): New function.
6408         (tui_attach_detach_observers): Attach or detach
6409         tui_redisplay_source.
6410         * observable.h (source_styling_changed): New observable.
6411         * observable.c: Define source_styling_changed observable.
6412
6413 2019-03-13  Tom Tromey  <tromey@adacore.com>
6414
6415         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6416         (i386_gnu_nat_target::store_registers): Update.
6417         * target-debug.h (target_debug_print_std_string): New macro.
6418         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6419         * windows-tdep.c (display_one_tib): Update.
6420         * tui/tui-stack.c (tui_make_status_line): Update.
6421         * top.c (print_inferior_quit_action): Update.
6422         * thread.c (thr_try_catch_cmd): Update.
6423         (add_thread_with_info): Update.
6424         (thread_target_id_str): Update.
6425         (thr_try_catch_cmd): Update.
6426         (thread_command): Update.
6427         (thread_find_command): Update.
6428         * record-btrace.c (record_btrace_target::info_record)
6429         (record_btrace_resume_thread, record_btrace_target::resume)
6430         (record_btrace_cancel_resume, record_btrace_step_thread)
6431         (record_btrace_target::wait, record_btrace_target::wait)
6432         (record_btrace_target::wait, record_btrace_target::stop): Update.
6433         * progspace.c (print_program_space): Update.
6434         * process-stratum-target.c
6435         (process_stratum_target::thread_address_space): Update.
6436         * linux-fork.c (linux_fork_mourn_inferior)
6437         (detach_checkpoint_command, info_checkpoints_command)
6438         (linux_fork_context): Update.
6439         (linux_fork_detach): Update.
6440         (class scoped_switch_fork_info): Update.
6441         (delete_checkpoint_command): Update.
6442         * infrun.c (follow_fork_inferior): Update.
6443         (follow_fork_inferior): Update.
6444         (proceed_after_vfork_done): Update.
6445         (handle_vfork_child_exec_or_exit): Update.
6446         (follow_exec): Update.
6447         (displaced_step_prepare_throw): Update.
6448         (displaced_step_restore): Update.
6449         (start_step_over): Update.
6450         (resume_1): Update.
6451         (clear_proceed_status_thread): Update.
6452         (proceed): Update.
6453         (print_target_wait_results): Update.
6454         (do_target_wait): Update.
6455         (context_switch): Update.
6456         (stop_all_threads): Update.
6457         (restart_threads): Update.
6458         (finish_step_over): Update.
6459         (handle_signal_stop): Update.
6460         (switch_back_to_stepped_thread): Update.
6461         (keep_going_pass_signal): Update.
6462         (print_exited_reason): Update.
6463         (normal_stop): Update.
6464         * inferior.c (inferior_pid_to_str): Change return type.
6465         (print_selected_inferior): Update.
6466         (add_inferior): Update.
6467         (detach_inferior): Update.
6468         * dummy-frame.c (fprint_dummy_frames): Update.
6469         * dcache.c (dcache_info_1): Update.
6470         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6471         (btrace_fetch, btrace_clear): Update.
6472         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6473         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6474         type.
6475         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6476         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6477         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6478         * gdbarch.c, gdbarch.h: Rebuild.
6479         * gdbarch.sh (core_pid_to_str): Change return type.
6480         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6481         return type.
6482         (windows_nat_target::pid_to_str): Change return type.
6483         (windows_delete_thread): Update.
6484         (windows_nat_target::attach): Update.
6485         (windows_nat_target::files_info): Update.
6486         * target-delegates.c: Rebuild.
6487         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6488         return type.
6489         (sol_thread_target::pid_to_str): Change return type.
6490         * remote.c (class remote_target) <pid_to_str>: Change return
6491         type.
6492         (remote_target::pid_to_str): Change return type.
6493         (extended_remote_target::attach, remote_target::remote_stop_ns)
6494         (remote_target::remote_notif_remove_queued_reply)
6495         (remote_target::push_stop_reply, remote_target::disable_btrace):
6496         Update.
6497         (extended_remote_target::attach): Update.
6498         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6499         type.
6500         (gdbsim_target::pid_to_str): Change return type.
6501         * ravenscar-thread.c (struct ravenscar_thread_target)
6502         <pid_to_str>: Change return type.
6503         (ravenscar_thread_target::pid_to_str): Change return type.
6504         * procfs.c (class procfs_target) <pid_to_str>: Change return
6505         type.
6506         (procfs_target::pid_to_str): Change return type.
6507         (procfs_target::attach): Update.
6508         (procfs_target::detach): Update.
6509         (procfs_target::fetch_registers): Update.
6510         (procfs_target::store_registers): Update.
6511         (procfs_target::wait): Update.
6512         (procfs_target::files_info): Update.
6513         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6514         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6515         return type.
6516         (nto_procfs_target::pid_to_str): Change return type.
6517         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6518         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6519         return type.
6520         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6521         (exit_lwp): Update.
6522         (attach_proc_task_lwp_callback, get_detach_signal)
6523         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6524         (linux_nat_target::resume, wait_lwp, stop_callback)
6525         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6526         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6527         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6528         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6529         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6530         type.
6531         (inf_ptrace_target::attach): Update.
6532         (inf_ptrace_target::files_info): Update.
6533         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6534         type.
6535         (go32_nat_target::pid_to_str): Change return type.
6536         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6537         (gnu_nat_target::wait): Update.
6538         (gnu_nat_target::wait): Update.
6539         (gnu_nat_target::resume): Update.
6540         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6541         (fbsd_nat_target::wait): Update.
6542         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6543         type.
6544         (darwin_nat_target::attach): Update.
6545         * corelow.c (class core_target) <pid_to_str>: Change return type.
6546         (core_target::pid_to_str): Change return type.
6547         * target.c (normal_pid_to_str): Change return type.
6548         (default_pid_to_str): Likewise.
6549         (target_pid_to_str): Change return type.
6550         (target_translate_tls_address): Update.
6551         (target_announce_detach): Update.
6552         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6553         return type.
6554         (bsd_uthread_target::pid_to_str): Change return type.
6555         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6556         type.
6557         (bsd_kvm_target::pid_to_str): Change return type.
6558         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6559         return type.
6560         (aix_thread_target::pid_to_str): Change return type.
6561         * target.h (struct target_ops) <pid_to_str>: Change return type.
6562         (target_pid_to_str, normal_pid_to_str): Likewise.
6563         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6564         type.
6565         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6566         type.
6567         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6568         return type.
6569         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6570         type.
6571         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6572         type.
6573         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6574         return type.
6575
6576 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6577
6578         * NEWS: Mention that the new default MI version is 3.  Mention
6579         changes to the output of commands and events that deal with
6580         multi-location breakpoints.
6581         * breakpoint.c: Include "mi/mi-out.h".
6582         (print_one_breakpoint): Change output syntax if using MI version
6583         >= 3.
6584         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6585         New.
6586         (mi_multi_location_breakpoint_output_fixed): New.
6587         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6588         (mi_cmd_fix_multi_location_breakpoint_output): New.
6589         (mi_multi_location_breakpoint_output_fixed): New.
6590         * mi/mi-cmds.c (mi_cmds): Register command
6591         -fix-multi-location-breakpoint-output.
6592         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6593         interpreter "mi".
6594
6595 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6596
6597         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6598         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6599         instantiate mi_ui_out based on interpreter name.
6600         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6601         * mi/mi-main.c (mi_load_progress): Likewise.
6602
6603 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6604
6605         * NEWS: Combine separate "New targets" sections for 8.3.
6606
6607 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6608
6609         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6610         (ppcfbsd_init_abi): Install gdbarch
6611         "fetch_tls_load_module_address" and "get_thread_local_address"
6612         methods.
6613
6614 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6615
6616         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6617         (riscv_fbsd_init_abi): Install gdbarch
6618         "fetch_tls_load_module_address" and "get_thread_local_address"
6619         methods.
6620
6621 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6622
6623         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6624         (i386fbsd_init_abi): Install gdbarch
6625         "fetch_tls_load_module_address" and "get_thread_local_address"
6626         methods.
6627
6628 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6629
6630         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6631         (amd64fbsd_init_abi): Install gdbarch
6632         "fetch_tls_load_module_address" and "get_thread_local_address"
6633         methods.
6634
6635 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6636
6637         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6638         (struct fbsd_pspace_data): New type.
6639         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6640         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6641         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6642         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6643         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6644
6645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6646
6647         * gdbtypes.c (lookup_struct_elt): New function.
6648         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6649         * gdbtypes.h (struct struct_elt): New type.
6650         (lookup_struct_elt): New prototype.
6651
6652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6653
6654         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6655         remove disabled code block.
6656
6657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6658
6659         * gdbarch.sh (get_thread_local_address): New method.
6660         * gdbarch.h, gdbarch.c: Regenerate.
6661         * target.c (target_translate_tls_address): Use
6662         gdbarch_get_thread_local_address if present instead of
6663         target::get_thread_local_address.
6664
6665 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6666
6667         * target.h (target::get_thread_local_address): Update comment.
6668
6669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6670
6671         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6672         objfile->separate_debug_objfile_backlink if not NULL.
6673
6674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6675
6676         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6677         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6678         (amd64bsd_store_inferior_registers): Likewise.
6679         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6680         Enable segment base registers.
6681         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6682         PT_GETFSBASE and PT_GETGSBASE.
6683         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6684         PT_SETGSBASE.
6685         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6686         segment base registers.
6687         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6688
6689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6690
6691         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6692         Update calls to i386_target_description to add 'segments'
6693         parameter.
6694         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6695         add segment base registers.
6696         * arch/i386.c (i386_create_target_description): Add 'segments'
6697         parameter to enable segment base registers.
6698         * arch/i386.h (i386_create_target_description): Likewise.
6699         * features/i386/32bit-segments.xml: New file.
6700         * features/i386/32bit-segments.c: Generate.
6701         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6702         call to i386_target_description to add 'segments' parameter.
6703         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6704         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6705         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6706         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6707         if feature is present.
6708         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6709         Add 'segments' parameter to call to i386_target_description.
6710         (i386_target_description): Add 'segments' parameter to enable
6711         segment base registers.
6712         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6713         to call to i386_target_description.
6714         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6715         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6716         Define I386_NUM_REGS.
6717         (i386_target_description): Add 'segments' parameter to enable
6718         segment base registers.
6719
6720 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6721
6722         PR/24325
6723         * source-cache.c: #undef open and close, to avoid unresolved
6724         externals during linking.
6725
6726 2019-03-12  Tom Tromey  <tromey@adacore.com>
6727
6728         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6729         const.  Add initializers.
6730         (_initialize_remote): Don't initialize ptid globals.
6731
6732 2019-03-12  Pedro Alves  <palves@redhat.com>
6733
6734         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6735
6736 2019-03-12  Pedro Alves  <palves@redhat.com>
6737
6738         * cp-name-parser.y (main): Remove unused 'len' variable.
6739
6740 2019-03-12  Tom Tromey  <tromey@adacore.com>
6741
6742         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6743         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6744
6745 2019-03-12  Tom Tromey  <tromey@adacore.com>
6746
6747         * linux-nat.c (iterate_over_lwps): Update.
6748         (stop_callback): Remove parameter.
6749         (stop_wait_callback, detach_callback, resume_set_callback)
6750         (select_singlestep_lwp_callback, set_ignore_sigint)
6751         (status_callback, resumed_callback, resume_clear_callback)
6752         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6753         data parameter.
6754         (linux_nat_target::detach, linux_nat_target::resume)
6755         (linux_stop_and_wait_all_lwps, select_event_lwp)
6756         (linux_nat_filter_event, linux_nat_wait_1)
6757         (linux_nat_target::kill, linux_nat_target::stop)
6758         (linux_nat_target::stop): Update.
6759         (linux_nat_resume_callback): Change type.
6760         (resume_stopped_resumed_lwps, count_events_callback)
6761         (select_event_lwp_callback): Likewise.
6762         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6763         * arm-linux-nat.c (struct update_registers_data): Remove.
6764         (update_registers_callback): Change type.
6765         (arm_linux_insert_hw_breakpoint1): Update.
6766         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6767         parameter.
6768         (x86_linux_dr_set_addr): Update.
6769         (x86_linux_dr_set_control): Update.
6770         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6771         (iterate_over_lwps): Use gdb::function_view.
6772         * nat/aarch64-linux-hw-point.c (struct
6773         aarch64_dr_update_callback_param): Remove.
6774         (debug_reg_change_callback): Change type.
6775         (aarch64_notify_debug_reg_change): Update.
6776         * s390-linux-nat.c (s390_refresh_per_info): Update.
6777
6778 2019-03-11  Tom Tromey  <tromey@adacore.com>
6779
6780         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6781         redundant assignment to "this_cu".
6782
6783 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6784
6785         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6786
6787 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6788
6789         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6790         from...
6791         (rank_one_type): ... this.
6792
6793 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6794
6795         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6796         from...
6797         (rank_one_type): ... this.
6798
6799 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6800
6801         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6802         from...
6803         (rank_one_type): ... this.
6804
6805 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6806
6807         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6808         from...
6809         (rank_one_type): ... this.
6810
6811 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6812
6813         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6814         from...
6815         (rank_one_type): ... this.
6816
6817 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6818
6819         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6820         from...
6821         (rank_one_type): ... this.
6822
6823 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6824
6825         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6826         from...
6827         (rank_one_type): ... this.
6828
6829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6830
6831         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6832         from...
6833         (rank_one_type): ... this.
6834
6835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6836
6837         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6838         from...
6839         (rank_one_type): ... this.
6840
6841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6842
6843         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6844         from...
6845         (rank_one_type): ... this.
6846
6847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6848
6849         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6850         from...
6851         (rank_one_type): ... this.
6852
6853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6854
6855         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6856         from...
6857         (rank_one_type): ... this.
6858
6859 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6860
6861         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6862         inferior-events' shows the example events.
6863
6864 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6865
6866         Support styling on native MS-Windows console
6867
6868         PR/24315
6869         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6870         on MS-Windows if $TERM is not defined.
6871
6872         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6873
6874         * posix-hdep.c (gdb_console_fputs):
6875         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6876         functions.
6877         * ui-file.h (gdb_console_fputs): Add prototype.
6878
6879         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6880         back to fputs only if the former returns zero.
6881
6882 2019-03-07  Tom Tromey  <tom@tromey.com>
6883
6884         * symmisc.c (print_symbol_bcache_statistics): Update.
6885         (print_objfile_statistics): Update.
6886         * symfile.c (allocate_symtab): Update.
6887         * stabsread.c: Don't include bcache.h.
6888         * psymtab.h (struct psymbol_bcache): Don't declare.
6889         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6890         (psymbol_bcache_init, psymbol_bcache_free)
6891         (psymbol_bcache_get_bcache): Don't declare.
6892         * psymtab.c (struct psymbol_bcache): Remove.
6893         (psymtab_storage::psymtab_storage): Update.
6894         (psymtab_storage::~psymtab_storage): Update.
6895         (psymbol_bcache_init, psymbol_bcache_free)
6896         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6897         (add_psymbol_to_bcache): Update.
6898         (allocate_psymtab): Update.
6899         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6900         macro_cache>: No longer pointers.
6901         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6902         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6903         * macrotab.c (macro_bcache): Update.
6904         * macroexp.c: Don't include bcache.h.
6905         * gdbtypes.c (check_types_worklist): Update.
6906         (types_deeply_equal): Remove TRY/CATCH.  Update.
6907         * elfread.c (elf_symtab_read): Update.
6908         * dwarf2read.c: Don't include bcache.h.
6909         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6910         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6911         (print_bcache_statistics, bcache_memory_used): Don't declare.
6912         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6913         methods.  Rename all data members.
6914         * bcache.c (struct bcache): Move to bcache.h.
6915         (bcache::expand_hash_table): Rename from expand_hash_table.
6916         (bcache): Remove.
6917         (bcache::insert): Rename from bcache_full.
6918         (bcache::compare): Rename from bcache_compare.
6919         (bcache_xmalloc): Remove.
6920         (bcache::~bcache): Rename from bcache_xfree.
6921         (bcache::print_statistics): Rename from print_bcache_statistics.
6922         (bcache::memory_used): Rename from bcache_memory_used.
6923
6924 2019-03-07  Pedro Alves  <palves@redhat.com>
6925
6926         * infrun.c (normal_stop): Also check for
6927         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6928
6929 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6930
6931         * f-lang.c (value_from_host_double): Moved to...
6932         * value.c (value_from_host_double): ...here.
6933         * value.h (value_from_host_double): Declare.
6934         * guile/scm-math.c (vlscm_convert_typed_number): Use
6935         value_from_host_double.
6936         (vlscm_convert_number): Likewise.
6937         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6938         * python/py-value.c (convert_value_from_python): Likewise.
6939
6940 2019-03-06  Tom Tromey  <tom@tromey.com>
6941
6942         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6943
6944 2019-03-06  Tom Tromey  <tom@tromey.com>
6945
6946         * utils.h (free_current_contents): Don't declare.
6947         * utils.c (free_current_contents): Remove.
6948
6949 2019-03-06  Tom Tromey  <tom@tromey.com>
6950
6951         * top.c (quit_force): Update.
6952         * main.c (captured_command_loop): Update.
6953         * common/new-op.c (operator new): Update.
6954         * common/common-exceptions.c (struct catcher)
6955         <save_cleanup_chain>: Remove member.
6956         (exceptions_state_mc_init): Update.
6957         (exception_try_scope_entry): Return nullptr.
6958         (exception_try_scope_exit, exception_rethrow)
6959         (throw_exception_sjlj, throw_exception_cxx): Update.
6960         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6961         (all_cleanups, do_cleanups, discard_cleanups)
6962         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6963         (restore_cleanups, restore_final_cleanups): Don't declare.
6964         (do_final_cleanups): Remove parameter.
6965         * common/cleanups.c (cleanup_chain, make_cleanup)
6966         (make_cleanup_dtor, all_cleanups, do_cleanups)
6967         (discard_my_cleanups, discard_cleanups)
6968         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6969         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6970         (null_cleanup): Remove.
6971         (do_final_cleanups): Remove parameter.
6972
6973 2019-03-06  Tom Tromey  <tom@tromey.com>
6974
6975         * remote.c (remote_target::remote_parse_stop_reply): Use
6976         unique_xmalloc_ptr.
6977
6978 2019-03-06  Tom Tromey  <tom@tromey.com>
6979
6980         * stabsread.c (struct stabs_field_info): Rename from field_info.
6981         <list, fnlist>: Add initializers.
6982         <obstack>: New member.
6983         (read_member_functions, read_struct_fields, read_baseclasses):
6984         Allocate on obstack.  Don't use cleanups.
6985         (read_one_struct_field, read_member_functions, read_struct_fields)
6986         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6987         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6988         (read_struct_type): Update.
6989
6990 2019-03-06  Tom Tromey  <tom@tromey.com>
6991
6992         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6993         * common/filestuff.h (make_cleanup_close): Don't declare.
6994         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6995         Remove.
6996
6997 2019-03-06  Tom Tromey  <tom@tromey.com>
6998
6999         * solib-aix.c: Use make_scope_exit.
7000
7001 2019-03-06  Tom Tromey  <tom@tromey.com>
7002
7003         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7004         Use make_scope_exit.
7005
7006 2019-03-06  Tom Tromey  <tom@tromey.com>
7007
7008         * solib-svr4.c (disable_probes_interface): Remove parameter.
7009         (svr4_handle_solib_event): Use make_scope_exit.
7010
7011 2019-03-06  Tom Tromey  <tom@tromey.com>
7012
7013         * remote.c (struct stop_reply_deleter): Remove.
7014         (stop_reply_up): Update.
7015         (struct stop_reply): Derive from notif_event.  Don't typedef.
7016         <regcache>: Now a std::vector.
7017         (stop_reply_xfree): Remove.
7018         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7019         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7020         (remote_target::discard_pending_stop_replies): Use delete.
7021         (remote_target::remote_parse_stop_reply): Update.
7022         (remote_target::process_stop_reply): Update.
7023         * remote-notif.h (struct notif_event): Add virtual destructor.
7024         Remove "dtr" member.
7025         (struct notif_client) <alloc_event>: Return a unique_ptr.
7026         (notif_event_xfree): Don't declare.
7027         (notif_event_up): New typedef.
7028         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7029         (notif_event_xfree, do_notif_event_xfree): Remove.
7030         (remote_notif_state_xfree): Update.
7031
7032 2019-03-06  Tom Tromey  <tom@tromey.com>
7033
7034         * infrun.c (displaced_step_clear_cleanup): Now a
7035         forward_scope_exit type.
7036         (displaced_step_prepare_throw): Update.
7037         (displaced_step_fixup): Update.
7038
7039 2019-03-06  Tom Tromey  <tom@tromey.com>
7040
7041         * inferior.h (class inferior): Update comment.
7042         * gdbthread.h (class thread_info): Update comment.
7043
7044 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7045             Tom Tromey  <tom@tromey.com>
7046
7047         * stabsread.h (struct stab_section_list): Remove.
7048         (coffstab_build_psymtabs): Update.
7049         * dbxread.c (symbuf_sections): Now a std::vector.
7050         (sect_idx): New global.
7051         (fill_symbuf): Update.
7052         (coffstab_build_psymtabs): Change type of stabsects parameter.
7053         Update.
7054         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7055         std::vector.
7056         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7057         (coff_locate_sections): Update.
7058         (coff_symfile_read): Remove cleanups.  Update.
7059         (init_stringtab): Add storage parameter.
7060         (free_stringtab, free_stringtab_cleanup): Remove.
7061         (init_lineno): Add storage parameter.
7062         (free_linetab, free_linetab_cleanup): Remove.
7063
7064 2019-03-06  Pedro Alves  <palves@redhat.com>
7065
7066         * linux-fork.c (fork_info::clobber_regs): Delete.
7067         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7068         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7069         comment.  Adjust.
7070         (scoped_switch_fork_info::scoped_switch_fork_info)
7071         (checkpoint_command, linux_fork_context): Adjust
7072         fork_save_infrun_state calls.
7073
7074 2019-03-06  Pedro Alves  <palves@redhat.com>
7075
7076         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7077         (inf_has_multiple_threads): Return 'bool' and rewrite using
7078         inferior_info::threads().
7079
7080 2019-03-06  Pedro Alves  <palves@redhat.com>
7081
7082         * linux-fork.c: Include <list>.
7083         (fork_list): Now a std::list instance.
7084         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7085         (forks_exist_p, find_last_fork): Adjust.
7086         (new_fork): Delete.
7087         (one_fork_p): New.
7088         (add_fork): Adjust.
7089         (free_fork): Delete, folded into fork_info::~fork_info().
7090         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7091         Adjust.
7092         (init_fork_list): Delete.
7093         (linux_fork_killall, linux_fork_mourn_inferior)
7094         (linux_fork_detach, info_checkpoints_command): Adjust.
7095         (_initialize_linux_fork): No longer call init_fork_list.
7096
7097 2019-03-06  Pedro Alves  <palves@redhat.com>
7098
7099         * linux-fork.c (new_fork): New, split out of ...
7100         (add_fork): ... this.  Return void.  Move "first fork" special
7101         case from here, to ...
7102         (checkpoint_command): ... here.
7103         * linux-linux.h (add_fork): Return void.
7104
7105 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7108
7109 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7110             Chris January  <chris.january@arm.com>
7111             David Lecomber  <david.lecomber@arm.com>
7112
7113         * f-exp.y: New token, UNOP_INTRINSIC.
7114         (exp): New pattern using UNOP_INTRINSIC token.
7115         (f77_keywords): Add 'abs' keyword.
7116         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7117         (value_from_host_double): New function.
7118         (evaluate_subexp_f): Support UNOP_ABS.
7119
7120 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7121
7122         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7123         types.
7124
7125 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7126
7127         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7128         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7129         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7130
7131 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7132
7133         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7134
7135 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7136             Chris January  <chris.january@arm.com>
7137
7138         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7139         * f-exp.y: Define 'KIND' token.
7140         (exp): New pattern for KIND expressions.
7141         (ptype): Handle types with a kind extension.
7142         (direct_abs_decl): Extend to spot kind extensions.
7143         (f77_keywords): Add 'kind' to the list.
7144         (push_kind_type): New function.
7145         (convert_to_kind_type): New function.
7146         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7147         * parse.c (operator_length_standard): Likewise.
7148         * parser-defs.h (enum type_pieces): Add tp_kind.
7149         * std-operator.def: Add UNOP_KIND.
7150
7151 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * f-exp.y (f_parse): Set yydebug.
7154
7155 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7156
7157         * f-lang.c (evaluate_subexp_f): New function.
7158         (exp_descriptor_f): New global.
7159         (f_language_defn): Use exp_descriptor_f instead of
7160         exp_descriptor_standard.
7161
7162 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7163
7164         * f-exp.y (struct token): Add comments.
7165         (dot_ops): Remove uppercase versions and the end marker.
7166         (f77_keywords): Likewise.
7167         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7168         entries in the dot_ops array are case insensitive, and use
7169         strncasecmp to compare strings.  Also some whitespace cleanup in
7170         this area.  Similar for the f77_keywords array, except entries in
7171         this list might be case sensitive.
7172
7173 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * f-exp.y (struct f77_boolean_val): Add comments.
7176         (boolean_values): Remove uppercase versions, and end marker.
7177         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7178         and use strncasecmp to achieve case insensitivity.  Additionally,
7179         perform whitespace cleanup around this code.
7180
7181 2019-03-06  Tom Tromey  <tromey@adacore.com>
7182
7183         * remote-sim.c (gdbsim_target_open): Use result of
7184         gdb_argv::release.
7185
7186 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7187         Dirk Schubert  <dirk.schubert@arm.com>
7188         Chris January  <chris.january@arm.com>
7189
7190         * eval.c (evaluate_subexp_standard): Call Fortran argument
7191         wrapping logic.
7192         * f-lang.c (struct value): A value which can be passed into a
7193         Fortran function call.
7194         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7195         where appropriate.
7196         (struct type): Value ready for a Fortran function call.
7197         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7198         is needed.
7199         * f-lang.h (fortran_argument_convert): Declaration.
7200         (fortran_preserve_arg_pointer): Declaration.
7201         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7202
7203 2019-03-05  Tom Tromey  <tromey@adacore.com>
7204
7205         * python/py-prettyprint.c (print_string_repr): Remove #if.
7206         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7207
7208 2019-03-05  Tom Tromey  <tromey@adacore.com>
7209
7210         * target.c (the_dummy_target): Move later.  Change type to
7211         "dummy_target".
7212         (initialize_targets): Don't initialize the_dummy_target.
7213
7214 2019-03-05  Tom Tromey  <tromey@adacore.com>
7215
7216         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7217         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7218
7219 2019-03-05  Tom Tromey  <tromey@adacore.com>
7220
7221         * windows-nat.c (windows_nat_target::attach)
7222         (windows_nat_target::detach): Don't call gdb_flush.
7223         * valprint.c (generic_val_print, val_print, val_print_string):
7224         Don't call gdb_flush.
7225         * utils.c (defaulted_query): Don't call gdb_flush.
7226         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7227         * target.c (target_announce_detach): Don't call gdb_flush.
7228         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7229         * remote.c (extended_remote_target::attach): Don't call
7230         gdb_flush.
7231         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7232         * printcmd.c (do_examine): Don't call gdb_flush.
7233         (info_display_command): Don't call gdb_flush.
7234         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7235         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7236         * memattr.c (info_mem_command): Don't call gdb_flush.
7237         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7238         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7239         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7240         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7241         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7242         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7243         (gnu_nat_target::detach): Don't call gdb_flush.
7244         * f-valprint.c (f_val_print): Don't call gdb_flush.
7245         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7246         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7247         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7248         gdb_flush.
7249         * c-valprint.c (c_val_print): Don't call gdb_flush.
7250         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7251
7252 2019-03-05  Tom Tromey  <tromey@adacore.com>
7253
7254         * varobj.c (update_dynamic_varobj_children): Update.
7255         (install_default_visualizer): Use reset, not release.
7256         * value.c (set_internalvar): Update.
7257         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7258         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7259         ATTRIBUTE_UNUSED_RESULT.
7260
7261 2019-03-05  Tom Tromey  <tromey@adacore.com>
7262
7263         * remote.c (class scoped_remote_fd) <release>: Add
7264         ATTRIBUTE_UNUSED_RESULT.
7265
7266 2019-03-05  Tom Tromey  <tromey@adacore.com>
7267
7268         * macroexp.c (struct macro_buffer) <release>: Add
7269         ATTRIBUTE_UNUSED_RESULT.
7270
7271 2019-03-05  Tom Tromey  <tromey@adacore.com>
7272
7273         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7274         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7275         ATTRIBUTE_UNUSED_RESULT.
7276
7277 2019-03-05  Tom Tromey  <tromey@adacore.com>
7278
7279         * common/scoped_fd.h (class scoped_fd) <release>: Add
7280         ATTRIBUTE_UNUSED_RESULT.
7281
7282 2019-03-05  Tom Tromey  <tromey@adacore.com>
7283
7284         * parser-defs.h (struct parser_state) <release>: Add
7285         ATTRIBUTE_UNUSED_RESULT.
7286
7287 2019-03-05  Tom Tromey  <tromey@adacore.com>
7288
7289         * utils.h (class gdb_argv) <release>: Add
7290         ATTRIBUTE_UNUSED_RESULT.
7291         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7292
7293 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7294
7295         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7296         for-loop range, to avoid compiler warnings.
7297
7298         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7299         avoid compiler warnings about unused variables.
7300
7301         * NEWS: Mention end of support for native debugging on MS-Windows
7302         before XP.
7303
7304         PR gdb/24292
7305         * common/netstuff.c:
7306         * gdbserver/gdbreplay.c
7307         * gdbserver/remote-utils.c:
7308         * ser-tcp.c:
7309         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7310         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7311         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7312         'getaddrinfo' and 'freeaddrinfo' were not available before
7313         Windows XP, and mingw.org's MinGW headers by default define
7314         _WIN32_WINNT to 0x500.
7315
7316 2019-03-01  Gary Benson <gbenson@redhat.com>
7317
7318         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7319
7320 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7321             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7322
7323         PR gdb/8527
7324         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7325         set_sigint_trap, clear_sigint_trap.
7326
7327 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7328
7329         * target.c (target_detach): Clear the regcache and the
7330         frame cache.
7331
7332 2019-02-27  Pedro Alves  <palves@redhat.com>
7333
7334         * utils.c (set_screen_size): When we cap the height/width sizes,
7335         tweak the corresponding command variable to show "unlimited":
7336
7337 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7338             Pedro Alves  <palves@redhat.com>
7339
7340         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7341         before calling rl_set_screen_size.
7342
7343 2019-02-27  Tom Tromey  <tromey@adacore.com>
7344
7345         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7346         define.
7347         * python/py-value.c: Remove Python 2.4 workaround.
7348         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7349         workaround.
7350         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7351         Python 2.4 workaround.
7352         * python/python-internal.h: Remove Python 2.4 comment.
7353         (Py_ssize_t): Don't define.
7354         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7355         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7356         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7357         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7358         * python/python.c (do_start_initialization): Remove Python 2.4
7359         workaround.
7360         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7361         (print_children): Remove Python 2.4 workaround.
7362         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7363         workaround.
7364         (CHARBUFFERPROC_NAME): Remove.
7365         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7366         Python 2.4 workaround.
7367
7368 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7369
7370         * NEWS: Note minimum Python version.
7371
7372 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7373
7374         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7375         code from these functions.  Remove corresponding ifdefs.  Use
7376         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7377         Remove gotos and target of gotos.
7378         (infpy_search_memory): Likewise.
7379
7380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7381
7382         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7383         (hppa_gdbarch_init): Don't register deleted functions with
7384         gdbarch.
7385
7386 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7387
7388         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7389         (h8300_unwind_sp): Delete.
7390         (h8300_dummy_id): Delete.
7391         (h8300_gdbarch_init): Don't register deleted functions with
7392         gdbarch.
7393
7394 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7395
7396         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7397         (ft32_unwind_pc): Delete.
7398         (ft32_unwind_sp): Delete.
7399         (ft32_gdbarch_init): Don't register deleted functions with
7400         gdbarch.
7401
7402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7403
7404         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7405         (frv_unwind_pc): Delete.
7406         (frv_unwind_sp): Delete.
7407         (frv_gdbarch_init): Don't register deleted functions with
7408         gdbarch.
7409
7410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7411
7412         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7413         (riscv_unwind_pc): Delete.
7414         (riscv_unwind_sp): Delete.
7415         (riscv_gdbarch_init): Don't register deleted functions with
7416         gdbarch.
7417
7418 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7419
7420         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7421         (csky_unwind_pc): Delete.
7422         (csky_unwind_sp): Delete.
7423         (csky_gdbarch_init): Don't register deleted functions with
7424         gdbarch.
7425
7426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7427
7428         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7429         (cris_unwind_pc): Delete.
7430         (cris_unwind_sp): Delete.
7431         (cris_gdbarch_init): Don't register deleted functions with
7432         gdbarch.
7433
7434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7435
7436         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7437         (bfin_unwind_pc): Delete.
7438         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7439
7440 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7441
7442         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7443         (arm_unwind_pc): Delete.
7444         (arm_unwind_sp): Delete.
7445         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7446
7447 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7448
7449         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7450         (arc_unwind_pc): Delete.
7451         (arc_unwind_sp): Delete.
7452         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7453
7454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7455
7456         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7457         (alpha_unwind_pc): Delete.
7458         (alpha_gdbarch_init): Don't register deleted functions with
7459         gdbarch.
7460
7461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7462
7463         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7464         (aarch64_unwind_pc): Delete.
7465         (aarch64_unwind_sp): Delete.
7466         (aarch64_gdbarch_init): Don't register deleted functions with
7467         gdbarch.
7468
7469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7470
7471         * gdbtypes.c (type_align): Don't consider static members when
7472         computing structure alignment.
7473
7474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7475
7476         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7477         return 0 for other types.
7478         * arch-utils.c (default_type_align): Always return 0.
7479         * gdbarch.h: Regenerate.
7480         * gdbarch.sh (type_align): Extend comment.
7481         * gdbtypes.c (type_align): Add additional comments, always call
7482         gdbarch_type_align before applying the default rules.
7483         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7484         generic code will then apply a suitable default.
7485         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7486         types, return 0 for other types.
7487
7488 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7489
7490         * NEWS: Create a new section for the next release branch.
7491         Rename the section of the current branch, now that it has
7492         been cut.
7493
7494 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7495
7496         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7497         * version.in: Bump version to 8.3.50.DATE-git.
7498
7499 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7500
7501         * aix-thread.c (ptid_cmp): Remove unused variable.
7502         (get_signaled_thread): Likewise.
7503         (store_regs_user_thread): Likewise.
7504         (store_regs_kernel_thread): Likewise.
7505         (fetch_regs_kernel_thread): Remove shadowed variable.
7506
7507 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7508
7509         * features/riscv/32bit-cpu.xml: Add register numbers.
7510         * features/riscv/32bit-fpu.c: Regenerate.
7511         * features/riscv/32bit-fpu.xml: Add register numbers.
7512         * features/riscv/64bit-cpu.xml: Add register numbers.
7513         * features/riscv/64bit-fpu.c: Regenerate.
7514         * features/riscv/64bit-fpu.xml: Add register numbers.
7515
7516 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7517
7518         * NEWS: Mention two argument form of gdb.Value constructor.
7519         * python/py-value.c (convert_buffer_and_type_to_value): New
7520         function.
7521         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7522         Add support for handling an optional second argument.  Call
7523         convert_buffer_and_type_to_value as appropriate.
7524         * python/python-internal.h (Py_buffer_deleter): New struct.
7525         (Py_buffer_up): New typedef.
7526
7527 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7528
7529         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7530         instead of releasing ownership.
7531
7532 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7533
7534         * dwarf2read.c (open_and_init_dwp_file): Call
7535         elf_numsections instead of bfd_count_sections to initialize
7536         dwp_file->num_sections.
7537
7538 2019-02-25  Tom Tromey  <tromey@adacore.com>
7539
7540         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7541
7542 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7543
7544         * gcore.in: Add '--readnever' option when invoking GDB.
7545
7546 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7547
7548         * MAINTAINERS: Update my email address.
7549
7550 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7551
7552         * build-id.c (build_id_to_debug_bfd_1): New function.
7553         (build_id_to_debug_bfd): Look for separate debug file in
7554         sysroot.
7555
7556 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7557
7558         * gdbarch.sh: Update the copyright year range that is placed into
7559         generated files.
7560
7561 2019-02-22  Keith Seitz  <keiths@redhat.com>
7562
7563         PR symtab/23853
7564         * linespec.c (create_sals_line_offset): Search for the default
7565         symtab's filename instead of its fullname.
7566
7567 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7568
7569         * NEWS: Update style defaults.
7570
7571 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7572
7573         * main.c (captured_main_1): Disable styling in batch mode.
7574
7575 2019-02-20  Tom Tromey  <tom@tromey.com>
7576
7577         * symtab.c (symtab_symbol_info): Fix typos.
7578
7579 2019-02-20  Tom Tromey  <tromey@adacore.com>
7580
7581         * findcmd.c (_initialize_mem_search): Use upper case for
7582         metasyntactic variables.
7583
7584 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7585
7586         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7587         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7588
7589 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7590
7591         * top.h (source_file_name): Change to std::string.
7592         * top.c (source_file_name): Likewise.
7593         (command_line_input): Adjust.
7594         * cli/cli-script.c (script_from_file): Adjust.
7595
7596 2019-02-19  Tom Tromey  <tromey@adacore.com>
7597
7598         * ravenscar-thread.c
7599         (ravenscar_thread_target::update_thread_list): Don't call
7600         ada_build_task_list.
7601         * ada-lang.h (ada_build_task_list): Don't declare.
7602         * ada-tasks.c (struct ada_tasks_inferior_data)
7603         <task_list_valid_p>: Now bool.
7604         (read_known_tasks, ada_task_list_changed)
7605         (ada_tasks_invalidate_inferior_data): Update.
7606         (read_known_tasks_array): Return bool.
7607         (read_known_tasks_list): Likewise.
7608         (read_known_tasks): Return void.
7609         (ada_build_task_list): Now static.
7610
7611 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7612
7613         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7614         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7615
7616 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7617
7618         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7619         variant for ada_tasks_pspace_data_handle and
7620         ada_tasks_inferior_data_handle.
7621         (ada_tasks_pspace_data_cleanup): New function.
7622         (ada_tasks_inferior_data_cleanup): New function.
7623
7624 2019-02-17  Tom Tromey  <tom@tromey.com>
7625
7626         * macrotab.h (macro_source_fullname): Return a std::string.
7627         * macrotab.c (macro_include, check_for_redefinition)
7628         (macro_undef, macro_lookup_definition, foreach_macro)
7629         (foreach_macro_in_scope): Update.
7630         (macro_source_fullname): Return a std::string.
7631         * macrocmd.c (show_pp_source_pos): Update.
7632
7633 2019-02-17  Tom Tromey  <tom@tromey.com>
7634
7635         * macrocmd.c (show_pp_source_pos): Style the file names.
7636
7637 2019-02-17  Tom Tromey  <tom@tromey.com>
7638
7639         PR tui/24197:
7640         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7641
7642 2019-02-17  Tom Tromey  <tom@tromey.com>
7643
7644         * ada-lang.c (user_select_syms): Use filtered printing.
7645         * utils.c (wrap_style): New global.
7646         (desired_style): Remove.
7647         (emit_style_escape): Add stream parameter.
7648         (set_output_style, reset_terminal_style, prompt_for_continue):
7649         Update.
7650         (flush_wrap_buffer): Only flush gdb_stdout.
7651         (wrap_here): Set wrap_style.
7652         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7653         treat escape sequences as a character.  Change when wrap buffer is
7654         flushed.
7655         (fputs_styled): Do not set the output style when the default is
7656         requested.
7657         * ui-style.h (struct ui_file_style) <is_default>: New method.
7658         * source.c (print_source_lines_base): Emit escape sequences in one
7659         piece.
7660
7661 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7662
7663         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7664         integers and enumeration types.
7665
7666 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7667
7668         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7669         instead of lookup_symbol_in_language
7670         (do_exact_match): New function.
7671         (ada_get_symbol_name_matcher): Return do_exact_match when
7672         doing a verbatim match.
7673
7674 2019-02-15  Tom Tromey  <tromey@adacore.com>
7675
7676         * ravenscar-thread.c (ravenscar_thread_target::resume)
7677         (ravenscar_thread_target::wait): Special case wildcard requests.
7678
7679 2019-02-15  Tom Tromey  <tromey@adacore.com>
7680
7681         * ravenscar-thread.c (base_ptid): Remove.
7682         (struct ravenscar_thread_target) <close>: New method.
7683         <m_base_ptid>: New member.
7684         <update_inferior_ptid, active_task, task_is_currently_active,
7685         runtime_initialized>: Declare methods.
7686         <ravenscar_thread_target>: Add constructor.
7687         (ravenscar_thread_target::task_is_currently_active)
7688         (ravenscar_thread_target::update_inferior_ptid)
7689         (ravenscar_runtime_initialized): Rename.  Now methods.
7690         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7691         (ravenscar_thread_target::update_thread_list): Update.
7692         (ravenscar_thread_target::active_task): Now method.
7693         (ravenscar_thread_target::store_registers)
7694         (ravenscar_thread_target::prepare_to_store)
7695         (ravenscar_thread_target::prepare_to_store)
7696         (ravenscar_thread_target::mourn_inferior): Update.
7697         (ravenscar_inferior_created): Use "new" to create target.
7698         (ravenscar_thread_target::get_ada_task_ptid): Update.
7699         (_initialize_ravenscar): Don't initialize base_ptid.
7700         (ravenscar_ops): Remove global.
7701
7702 2019-02-15  Tom Tromey  <tromey@adacore.com>
7703
7704         * target.h (push_target): Declare new overload.
7705         * target.c (push_target): New overload, taking an rvalue reference.
7706         * remote.c (remote_target::open_1): Use push_target overload.
7707         * corelow.c (core_target_open): Use push_target overload.
7708
7709 2019-02-15  Tom Tromey  <tromey@adacore.com>
7710
7711         * ravenscar-thread.c (is_ravenscar_task)
7712         (ravenscar_task_is_currently_active): Return bool.
7713         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7714         (_initialize_ravenscar): Remove "(void)".
7715         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7716         Return bool.
7717
7718 2019-02-15  Tom Tromey  <tromey@adacore.com>
7719
7720         * ravenscar-thread.c (ravenscar_runtime_initializer)
7721         (has_ravenscar_runtime, get_running_thread_id)
7722         (ravenscar_thread_target::resume): Fix indentation.
7723
7724 2019-02-15  Tom Tromey  <tromey@adacore.com>
7725
7726         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7727         from ravenscar_arch_ops.
7728         (sparc_ravenscar_ops::fetch_registers)
7729         (sparc_ravenscar_ops::store_registers): Now methods.
7730         (sparc_ravenscar_prepare_to_store): Remove.
7731         (sparc_ravenscar_ops): Redefine.
7732         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7733         methods and destructor.  Remove members.
7734         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7735         (ravenscar_thread_target::store_registers)
7736         (ravenscar_thread_target::prepare_to_store): Update.
7737         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7738         Remove.
7739         (struct ppc_ravenscar_powerpc_ops): Derive from
7740         ravenscar_arch_ops.
7741         (ppc_ravenscar_powerpc_ops::fetch_registers)
7742         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7743         (ppc_ravenscar_powerpc_ops): Redefine.
7744         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7745         (ppc_ravenscar_e500_ops::fetch_registers)
7746         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7747         (ppc_ravenscar_e500_ops): Redefine.
7748         * aarch64-ravenscar-thread.c
7749         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7750         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7751         (aarch64_ravenscar_fetch_registers)
7752         (aarch64_ravenscar_store_registers): Now methods.
7753         (aarch64_ravenscar_ops): Redefine.
7754
7755 2019-02-15  Tom Tromey  <tromey@adacore.com>
7756
7757         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7758         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7759         (ravenscar_thread_target::stopped_by_watchpoint)
7760         (ravenscar_thread_target::stopped_data_address)
7761         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7762
7763 2019-02-15  Tom Tromey  <tromey@adacore.com>
7764
7765         * ravenscar-thread.c: Fix some typos.
7766
7767 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7768             Tom Tromey  <tromey@adacore.com>
7769
7770         * ada-lang.c (ada_exception_sal): Change addr_string to a
7771         std::string.
7772         (create_ada_exception_catchpoint): Update.
7773
7774 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7775             Tom Tromey  <tromey@adacore.com>
7776
7777         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7778         (bp_location_ops): Remove.
7779         (base_breakpoint_allocate_location): Update.
7780         (free_bp_location): Update.
7781         * ada-lang.c (class ada_catchpoint_location)
7782         <ada_catchpoint_location>: Remove ops parameter.
7783         (ada_catchpoint_location_dtor): Remove.
7784         (ada_catchpoint_location_ops): Remove.
7785         (allocate_location_exception): Update.
7786         * breakpoint.h (struct bp_location_ops): Remove.
7787         (class bp_location) <bp_location>: Remove bp_location_ops
7788         parameter.
7789         <~bp_location>: Add destructor.
7790         <ops>: Remove.
7791
7792 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7793             Pedro Alves  <palves@redhat.com>
7794
7795         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7796         'PATH_MAX'.
7797
7798 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7799             Samuel Thibault  <samuel.thibault@gnu.org>
7800             Thomas Schwinge  <thomas@codesourcery.com>
7801
7802         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7803         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7804
7805 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7806
7807         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7808         (check_empty): Use "const char *".
7809
7810         * gnu-nat.c (gnu_nat_target::detach): Instead of
7811         'detach_inferior (pid)' call
7812         'detach_inferior (find_inferior_pid (pid))'.
7813
7814         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7815         'nat/fork-inferior.o'.
7816         * gnu-nat.c: #include "nat/fork-inferior.h".
7817
7818         * gnu-nat.c (gnu_nat_target::detach): Instead of
7819         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7820         * gnu-nat.h: #include "inf-child.h".
7821         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7822         'i386_gnu_nat_target::fetch_registers'.
7823         (gnu_store_registers): Rename/move to
7824         'i386_gnu_nat_target::store_registers'.
7825
7826         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7827         * gnu-nat.h (mach_thread_info): New function.
7828         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7829
7830         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7831
7832 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7833
7834         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7835
7836 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7837
7838         * windows-nat.c (windows_add_thread): Add new parameter
7839         "main_thread_p" with default value set to false.  Update
7840         function documentation as well as all callers.
7841         (windows_delete_thread): Likewise.
7842         (fake_create_process): Update call to windows_add_thread.
7843         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7844         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7845         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7846         call to windows_delete_thread.
7847
7848 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7849
7850         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7851
7852 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7853
7854         * symfile.c (find_separate_debug_file): Use canonical path of
7855         sysroot with child_path instead of gdb_sysroot if it is valid.
7856
7857 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7858
7859         * symfile.c (find_separate_debug_file): Use child_path to
7860         determine if an object file is under a sysroot.
7861
7862 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7863
7864         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7865         unittests/child-path-selftests.c.
7866         * common/pathstuff.c (child_path): New function.
7867         * common/pathstuff.h (child_path): New prototype.
7868         * unittests/child-path-selftests.c: New file.
7869
7870 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7871
7872         * symfile.c (find_separate_debug_file): Look for separate debug
7873         files in debug directories under the sysroot.
7874
7875 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7876
7877         * symtab.h (struct minimal_symbol data_p): New const method.
7878         (struct minimal_symbol text_p): Likewise.
7879         * symtab.c (output_source_filename): Use file name style
7880         to print file name.
7881         (print_symbol_info): Likewise.
7882         (print_msymbol_info): Use address style to print addresses.
7883         Use function name style to print executable text symbols.
7884         (expand_symtab_containing_pc): Use data_p.
7885         (find_pc_sect_compunit_symtab): Likewise.
7886
7887 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7888
7889         * breakpoint.c (describe_other_breakpoints): Use address style
7890         to print addresses.
7891         (say_where): Likewise.
7892
7893 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7894
7895         * ada-typeprint.c (print_func_type): Print function name
7896         style to print function name.
7897         * c-typeprint.c (c_print_type_1): Likewise.
7898
7899 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7900
7901         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7902         for execve.
7903
7904 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7905
7906         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7907         type_stack.
7908
7909 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7910
7911         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7912         TYPE_CODE_REF types.
7913
7914 2019-02-08  Jim Wilson  <jimw@sifive.com>
7915
7916         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7917         (riscv_linux_fregset): New.
7918         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7919
7920 2019-02-07  Tom Tromey  <tom@tromey.com>
7921
7922         * thread.c (thread_cancel_execution_command): Update.
7923         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7924         methods.
7925         (struct thread_fsm_ops): Remove.
7926         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7927         (thread_fsm_should_stop, thread_fsm_return_value)
7928         (thread_fsm_set_finished, thread_fsm_finished_p)
7929         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7930         Don't declare.
7931         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7932         * infrun.c (clear_proceed_status_thread)
7933         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7934         (print_stop_event): Update.
7935         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7936         Add constructor.
7937         (step_command_fsm_ops): Remove.
7938         (new_step_command_fsm): Remove.
7939         (step_1): Update.
7940         (step_command_fsm::should_stop): Rename from
7941         step_command_fsm_should_stop.
7942         (step_command_fsm::clean_up): Rename from
7943         step_command_fsm_clean_up.
7944         (step_command_fsm::do_async_reply_reason): Rename from
7945         step_command_fsm_async_reply_reason.
7946         (struct until_next_fsm): Inherit from thread_fsm.  Add
7947         constructor.
7948         (until_next_fsm_ops): Remove.
7949         (new_until_next_fsm): Remove.
7950         (until_next_fsm::should_stop): Rename from
7951         until_next_fsm_should_stop.
7952         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7953         (until_next_fsm::do_async_reply_reason): Rename from
7954         until_next_fsm_async_reply_reason.
7955         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7956         constructor.  Change type of breakpoint.
7957         (finish_command_fsm_ops): Remove.
7958         (new_finish_command_fsm): Remove.
7959         (finish_command_fsm::should_stop): Rename from
7960         finish_command_fsm_should_stop.
7961         (finish_command_fsm::clean_up): Rename from
7962         finish_command_fsm_clean_up.
7963         (finish_command_fsm::return_value): Rename from
7964         finish_command_fsm_return_value.
7965         (finish_command_fsm::do_async_reply_reason): Rename from
7966         finish_command_fsm_async_reply_reason.
7967         (finish_command): Update.
7968         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7969         Add constructor.
7970         (call_thread_fsm_ops): Remove.
7971         (call_thread_fsm::call_thread_fsm): Rename from
7972         new_call_thread_fsm.
7973         (call_thread_fsm::should_stop): Rename from
7974         call_thread_fsm_should_stop.
7975         (call_thread_fsm::should_notify_stop): Rename from
7976         call_thread_fsm_should_notify_stop.
7977         (run_inferior_call, call_function_by_hand_dummy): Update.
7978         * cli/cli-interp.c (should_print_stop_to_console): Update.
7979         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7980         Add constructor.  Change type of location_breakpoint,
7981         caller_breakpoint.
7982         (until_break_fsm_ops): Remove.
7983         (new_until_break_fsm): Remove.
7984         (until_break_fsm::should_stop): Rename from
7985         until_break_fsm_should_stop.
7986         (until_break_fsm::clean_up): Rename from
7987         until_break_fsm_clean_up.
7988         (until_break_fsm::do_async_reply_reason): Rename from
7989         until_break_fsm_async_reply_reason.
7990         (until_break_command): Update.
7991         * thread-fsm.c: Remove.
7992         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7993
7994 2019-02-07  Tom Tromey  <tom@tromey.com>
7995
7996         * yy-remap.h: Add include guard.
7997         * xtensa-tdep.h: Add include guard.
7998         * xcoffread.h: Rename include guard.
7999         * varobj-iter.h: Add include guard.
8000         * tui/tui.h: Rename include guard.
8001         * tui/tui-winsource.h: Rename include guard.
8002         * tui/tui-wingeneral.h: Rename include guard.
8003         * tui/tui-windata.h: Rename include guard.
8004         * tui/tui-win.h: Rename include guard.
8005         * tui/tui-stack.h: Rename include guard.
8006         * tui/tui-source.h: Rename include guard.
8007         * tui/tui-regs.h: Rename include guard.
8008         * tui/tui-out.h: Rename include guard.
8009         * tui/tui-layout.h: Rename include guard.
8010         * tui/tui-io.h: Rename include guard.
8011         * tui/tui-hooks.h: Rename include guard.
8012         * tui/tui-file.h: Rename include guard.
8013         * tui/tui-disasm.h: Rename include guard.
8014         * tui/tui-data.h: Rename include guard.
8015         * tui/tui-command.h: Rename include guard.
8016         * tic6x-tdep.h: Add include guard.
8017         * target/waitstatus.h: Rename include guard.
8018         * target/wait.h: Rename include guard.
8019         * target/target.h: Rename include guard.
8020         * target/resume.h: Rename include guard.
8021         * target-float.h: Rename include guard.
8022         * stabsread.h: Add include guard.
8023         * rs6000-tdep.h: Add include guard.
8024         * riscv-fbsd-tdep.h: Add include guard.
8025         * regformats/regdef.h: Rename include guard.
8026         * record.h: Rename include guard.
8027         * python/python.h: Rename include guard.
8028         * python/python-internal.h: Rename include guard.
8029         * python/py-stopevent.h: Rename include guard.
8030         * python/py-ref.h: Rename include guard.
8031         * python/py-record.h: Rename include guard.
8032         * python/py-record-full.h: Rename include guard.
8033         * python/py-record-btrace.h: Rename include guard.
8034         * python/py-instruction.h: Rename include guard.
8035         * python/py-events.h: Rename include guard.
8036         * python/py-event.h: Rename include guard.
8037         * procfs.h: Add include guard.
8038         * proc-utils.h: Add include guard.
8039         * p-lang.h: Add include guard.
8040         * or1k-tdep.h: Rename include guard.
8041         * observable.h: Rename include guard.
8042         * nto-tdep.h: Rename include guard.
8043         * nat/x86-linux.h: Rename include guard.
8044         * nat/x86-linux-dregs.h: Rename include guard.
8045         * nat/x86-gcc-cpuid.h: Add include guard.
8046         * nat/x86-dregs.h: Rename include guard.
8047         * nat/x86-cpuid.h: Rename include guard.
8048         * nat/ppc-linux.h: Rename include guard.
8049         * nat/mips-linux-watch.h: Rename include guard.
8050         * nat/linux-waitpid.h: Rename include guard.
8051         * nat/linux-ptrace.h: Rename include guard.
8052         * nat/linux-procfs.h: Rename include guard.
8053         * nat/linux-osdata.h: Rename include guard.
8054         * nat/linux-nat.h: Rename include guard.
8055         * nat/linux-namespaces.h: Rename include guard.
8056         * nat/linux-btrace.h: Rename include guard.
8057         * nat/glibc_thread_db.h: Rename include guard.
8058         * nat/gdb_thread_db.h: Rename include guard.
8059         * nat/gdb_ptrace.h: Rename include guard.
8060         * nat/fork-inferior.h: Rename include guard.
8061         * nat/amd64-linux-siginfo.h: Rename include guard.
8062         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8063         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8064         * nat/aarch64-linux.h: Rename include guard.
8065         * nat/aarch64-linux-hw-point.h: Rename include guard.
8066         * mn10300-tdep.h: Add include guard.
8067         * mips-linux-tdep.h: Add include guard.
8068         * mi/mi-parse.h: Rename include guard.
8069         * mi/mi-out.h: Rename include guard.
8070         * mi/mi-main.h: Rename include guard.
8071         * mi/mi-interp.h: Rename include guard.
8072         * mi/mi-getopt.h: Rename include guard.
8073         * mi/mi-console.h: Rename include guard.
8074         * mi/mi-common.h: Rename include guard.
8075         * mi/mi-cmds.h: Rename include guard.
8076         * mi/mi-cmd-break.h: Rename include guard.
8077         * m2-lang.h: Add include guard.
8078         * location.h: Rename include guard.
8079         * linux-record.h: Rename include guard.
8080         * linux-nat.h: Add include guard.
8081         * linux-fork.h: Add include guard.
8082         * i386-darwin-tdep.h: Rename include guard.
8083         * hppa-linux-offsets.h: Add include guard.
8084         * guile/guile.h: Rename include guard.
8085         * guile/guile-internal.h: Rename include guard.
8086         * gnu-nat.h: Rename include guard.
8087         * gdb-stabs.h: Rename include guard.
8088         * frv-tdep.h: Add include guard.
8089         * f-lang.h: Add include guard.
8090         * event-loop.h: Add include guard.
8091         * darwin-nat.h: Rename include guard.
8092         * cp-abi.h: Rename include guard.
8093         * config/sparc/nm-sol2.h: Rename include guard.
8094         * config/nm-nto.h: Rename include guard.
8095         * config/nm-linux.h: Add include guard.
8096         * config/i386/nm-i386gnu.h: Rename include guard.
8097         * config/djgpp/nl_types.h: Rename include guard.
8098         * config/djgpp/langinfo.h: Rename include guard.
8099         * compile/gcc-cp-plugin.h: Add include guard.
8100         * compile/gcc-c-plugin.h: Add include guard.
8101         * compile/compile.h: Rename include guard.
8102         * compile/compile-object-run.h: Rename include guard.
8103         * compile/compile-object-load.h: Rename include guard.
8104         * compile/compile-internal.h: Rename include guard.
8105         * compile/compile-cplus.h: Rename include guard.
8106         * compile/compile-c.h: Rename include guard.
8107         * common/xml-utils.h: Rename include guard.
8108         * common/x86-xstate.h: Rename include guard.
8109         * common/version.h: Rename include guard.
8110         * common/vec.h: Rename include guard.
8111         * common/tdesc.h: Rename include guard.
8112         * common/selftest.h: Rename include guard.
8113         * common/scoped_restore.h: Rename include guard.
8114         * common/scoped_mmap.h: Rename include guard.
8115         * common/scoped_fd.h: Rename include guard.
8116         * common/safe-iterator.h: Rename include guard.
8117         * common/run-time-clock.h: Rename include guard.
8118         * common/refcounted-object.h: Rename include guard.
8119         * common/queue.h: Rename include guard.
8120         * common/ptid.h: Rename include guard.
8121         * common/print-utils.h: Rename include guard.
8122         * common/preprocessor.h: Rename include guard.
8123         * common/pathstuff.h: Rename include guard.
8124         * common/observable.h: Rename include guard.
8125         * common/netstuff.h: Rename include guard.
8126         * common/job-control.h: Rename include guard.
8127         * common/host-defs.h: Rename include guard.
8128         * common/gdb_wait.h: Rename include guard.
8129         * common/gdb_vecs.h: Rename include guard.
8130         * common/gdb_unlinker.h: Rename include guard.
8131         * common/gdb_unique_ptr.h: Rename include guard.
8132         * common/gdb_tilde_expand.h: Rename include guard.
8133         * common/gdb_sys_time.h: Rename include guard.
8134         * common/gdb_string_view.h: Rename include guard.
8135         * common/gdb_splay_tree.h: Rename include guard.
8136         * common/gdb_setjmp.h: Rename include guard.
8137         * common/gdb_ref_ptr.h: Rename include guard.
8138         * common/gdb_optional.h: Rename include guard.
8139         * common/gdb_locale.h: Rename include guard.
8140         * common/gdb_assert.h: Rename include guard.
8141         * common/filtered-iterator.h: Rename include guard.
8142         * common/filestuff.h: Rename include guard.
8143         * common/fileio.h: Rename include guard.
8144         * common/environ.h: Rename include guard.
8145         * common/common-utils.h: Rename include guard.
8146         * common/common-types.h: Rename include guard.
8147         * common/common-regcache.h: Rename include guard.
8148         * common/common-inferior.h: Rename include guard.
8149         * common/common-gdbthread.h: Rename include guard.
8150         * common/common-exceptions.h: Rename include guard.
8151         * common/common-defs.h: Rename include guard.
8152         * common/common-debug.h: Rename include guard.
8153         * common/cleanups.h: Rename include guard.
8154         * common/buffer.h: Rename include guard.
8155         * common/btrace-common.h: Rename include guard.
8156         * common/break-common.h: Rename include guard.
8157         * cli/cli-utils.h: Rename include guard.
8158         * cli/cli-style.h: Rename include guard.
8159         * cli/cli-setshow.h: Rename include guard.
8160         * cli/cli-script.h: Rename include guard.
8161         * cli/cli-interp.h: Rename include guard.
8162         * cli/cli-decode.h: Rename include guard.
8163         * cli/cli-cmds.h: Rename include guard.
8164         * charset-list.h: Add include guard.
8165         * buildsym-legacy.h: Rename include guard.
8166         * bfin-tdep.h: Add include guard.
8167         * ax.h: Rename include guard.
8168         * arm-linux-tdep.h: Add include guard.
8169         * arm-fbsd-tdep.h: Add include guard.
8170         * arch/xtensa.h: Rename include guard.
8171         * arch/tic6x.h: Add include guard.
8172         * arch/i386.h: Add include guard.
8173         * arch/arm.h: Rename include guard.
8174         * arch/arm-linux.h: Rename include guard.
8175         * arch/arm-get-next-pcs.h: Rename include guard.
8176         * arch/amd64.h: Add include guard.
8177         * arch/aarch64-insn.h: Rename include guard.
8178         * arch-utils.h: Rename include guard.
8179         * annotate.h: Add include guard.
8180         * amd64-darwin-tdep.h: Rename include guard.
8181         * aarch64-linux-tdep.h: Add include guard.
8182         * aarch64-fbsd-tdep.h: Add include guard.
8183         * aarch32-linux-nat.h: Add include guard.
8184
8185 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8186
8187         * macrotab.c (macro_define_internal): New function that
8188         factorizes macro_define_object_internal and macro_define_function
8189         code.
8190         (macro_define_object_internal): Use macro_define_internal.
8191         (macro_define_function): Likewise.
8192
8193 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8194
8195         * macrocmd.c (extract_identifier): Return
8196         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8197         callers.
8198
8199 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8200
8201         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8202
8203 2019-02-05  Tom Tromey  <tom@tromey.com>
8204
8205         * target.c (target_stack::unpush): Move assertion earlier.
8206
8207 2019-01-30  Tom Tromey  <tom@tromey.com>
8208
8209         PR python/23615:
8210         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8211         (gdbpy_parse_and_eval): Likewise.
8212         * python/python-internal.h (gdbpy_allow_threads): New class.
8213
8214 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8215
8216         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8217         (aarch64_fbsd_fpregmap): Move earlier.
8218         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8219         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8220         instead of individual calls to trad_frame_set_reg_addr.
8221         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8222         earlier.
8223         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8224         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8225         instead of individual calls to trad_frame_set_reg_addr.
8226
8227 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8228
8229         * CONTRIBUTE: Replace contribution list with wiki link.
8230
8231 2019-01-25  Tom Tromey  <tom@tromey.com>
8232
8233         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8234
8235 2019-01-25  Tom Tromey  <tom@tromey.com>
8236
8237         * xtensa-linux-nat.c: Fix common/ includes.
8238         * xml-support.h: Fix common/ includes.
8239         * xml-support.c: Fix common/ includes.
8240         * x86-linux-nat.c: Fix common/ includes.
8241         * windows-nat.c: Fix common/ includes.
8242         * varobj.h: Fix common/ includes.
8243         * varobj.c: Fix common/ includes.
8244         * value.c: Fix common/ includes.
8245         * valops.c: Fix common/ includes.
8246         * utils.c: Fix common/ includes.
8247         * unittests/xml-utils-selftests.c: Fix common/ includes.
8248         * unittests/utils-selftests.c: Fix common/ includes.
8249         * unittests/unpack-selftests.c: Fix common/ includes.
8250         * unittests/tracepoint-selftests.c: Fix common/ includes.
8251         * unittests/style-selftests.c: Fix common/ includes.
8252         * unittests/string_view-selftests.c: Fix common/ includes.
8253         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8254         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8255         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8256         * unittests/rsp-low-selftests.c: Fix common/ includes.
8257         * unittests/parse-connection-spec-selftests.c: Fix common/
8258         includes.
8259         * unittests/optional-selftests.c: Fix common/ includes.
8260         * unittests/offset-type-selftests.c: Fix common/ includes.
8261         * unittests/observable-selftests.c: Fix common/ includes.
8262         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8263         * unittests/memrange-selftests.c: Fix common/ includes.
8264         * unittests/memory-map-selftests.c: Fix common/ includes.
8265         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8266         * unittests/function-view-selftests.c: Fix common/ includes.
8267         * unittests/environ-selftests.c: Fix common/ includes.
8268         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8269         * unittests/common-utils-selftests.c: Fix common/ includes.
8270         * unittests/cli-utils-selftests.c: Fix common/ includes.
8271         * unittests/array-view-selftests.c: Fix common/ includes.
8272         * ui-file.c: Fix common/ includes.
8273         * tui/tui-io.c: Fix common/ includes.
8274         * tracepoint.h: Fix common/ includes.
8275         * tracepoint.c: Fix common/ includes.
8276         * tracefile-tfile.c: Fix common/ includes.
8277         * top.h: Fix common/ includes.
8278         * top.c: Fix common/ includes.
8279         * thread.c: Fix common/ includes.
8280         * target/waitstatus.h: Fix common/ includes.
8281         * target/waitstatus.c: Fix common/ includes.
8282         * target.h: Fix common/ includes.
8283         * target.c: Fix common/ includes.
8284         * target-memory.c: Fix common/ includes.
8285         * target-descriptions.c: Fix common/ includes.
8286         * symtab.h: Fix common/ includes.
8287         * symfile.c: Fix common/ includes.
8288         * stap-probe.c: Fix common/ includes.
8289         * spu-linux-nat.c: Fix common/ includes.
8290         * sparc-nat.c: Fix common/ includes.
8291         * source.c: Fix common/ includes.
8292         * solib.c: Fix common/ includes.
8293         * solib-target.c: Fix common/ includes.
8294         * ser-unix.c: Fix common/ includes.
8295         * ser-tcp.c: Fix common/ includes.
8296         * ser-pipe.c: Fix common/ includes.
8297         * ser-base.c: Fix common/ includes.
8298         * selftest-arch.c: Fix common/ includes.
8299         * s12z-tdep.c: Fix common/ includes.
8300         * rust-exp.y: Fix common/ includes.
8301         * rs6000-aix-tdep.c: Fix common/ includes.
8302         * riscv-tdep.c: Fix common/ includes.
8303         * remote.c: Fix common/ includes.
8304         * remote-notif.h: Fix common/ includes.
8305         * remote-fileio.h: Fix common/ includes.
8306         * remote-fileio.c: Fix common/ includes.
8307         * regcache.h: Fix common/ includes.
8308         * regcache.c: Fix common/ includes.
8309         * record-btrace.c: Fix common/ includes.
8310         * python/python.c: Fix common/ includes.
8311         * python/py-type.c: Fix common/ includes.
8312         * python/py-inferior.c: Fix common/ includes.
8313         * progspace.h: Fix common/ includes.
8314         * producer.c: Fix common/ includes.
8315         * procfs.c: Fix common/ includes.
8316         * proc-api.c: Fix common/ includes.
8317         * printcmd.c: Fix common/ includes.
8318         * ppc-linux-nat.c: Fix common/ includes.
8319         * parser-defs.h: Fix common/ includes.
8320         * osdata.c: Fix common/ includes.
8321         * obsd-nat.c: Fix common/ includes.
8322         * nat/x86-linux.c: Fix common/ includes.
8323         * nat/x86-linux-dregs.c: Fix common/ includes.
8324         * nat/x86-dregs.h: Fix common/ includes.
8325         * nat/x86-dregs.c: Fix common/ includes.
8326         * nat/ppc-linux.c: Fix common/ includes.
8327         * nat/mips-linux-watch.h: Fix common/ includes.
8328         * nat/mips-linux-watch.c: Fix common/ includes.
8329         * nat/linux-waitpid.c: Fix common/ includes.
8330         * nat/linux-ptrace.h: Fix common/ includes.
8331         * nat/linux-ptrace.c: Fix common/ includes.
8332         * nat/linux-procfs.c: Fix common/ includes.
8333         * nat/linux-personality.c: Fix common/ includes.
8334         * nat/linux-osdata.c: Fix common/ includes.
8335         * nat/linux-namespaces.c: Fix common/ includes.
8336         * nat/linux-btrace.h: Fix common/ includes.
8337         * nat/linux-btrace.c: Fix common/ includes.
8338         * nat/fork-inferior.c: Fix common/ includes.
8339         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8340         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8341         * nat/aarch64-linux.c: Fix common/ includes.
8342         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8343         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8344         * namespace.h: Fix common/ includes.
8345         * mips-linux-tdep.c: Fix common/ includes.
8346         * minsyms.c: Fix common/ includes.
8347         * mi/mi-parse.h: Fix common/ includes.
8348         * mi/mi-main.c: Fix common/ includes.
8349         * mi/mi-cmd-env.c: Fix common/ includes.
8350         * memrange.h: Fix common/ includes.
8351         * memattr.c: Fix common/ includes.
8352         * maint.h: Fix common/ includes.
8353         * maint.c: Fix common/ includes.
8354         * main.c: Fix common/ includes.
8355         * machoread.c: Fix common/ includes.
8356         * location.c: Fix common/ includes.
8357         * linux-thread-db.c: Fix common/ includes.
8358         * linux-nat.c: Fix common/ includes.
8359         * linux-fork.c: Fix common/ includes.
8360         * inline-frame.c: Fix common/ includes.
8361         * infrun.c: Fix common/ includes.
8362         * inflow.c: Fix common/ includes.
8363         * inferior.h: Fix common/ includes.
8364         * inferior.c: Fix common/ includes.
8365         * infcmd.c: Fix common/ includes.
8366         * inf-ptrace.c: Fix common/ includes.
8367         * inf-child.c: Fix common/ includes.
8368         * ia64-linux-nat.c: Fix common/ includes.
8369         * i387-tdep.c: Fix common/ includes.
8370         * i386-tdep.c: Fix common/ includes.
8371         * i386-linux-tdep.c: Fix common/ includes.
8372         * i386-linux-nat.c: Fix common/ includes.
8373         * i386-go32-tdep.c: Fix common/ includes.
8374         * i386-fbsd-tdep.c: Fix common/ includes.
8375         * i386-fbsd-nat.c: Fix common/ includes.
8376         * guile/scm-type.c: Fix common/ includes.
8377         * guile/guile.c: Fix common/ includes.
8378         * go32-nat.c: Fix common/ includes.
8379         * gnu-nat.c: Fix common/ includes.
8380         * gdbthread.h: Fix common/ includes.
8381         * gdbarch-selftests.c: Fix common/ includes.
8382         * gdb_usleep.c: Fix common/ includes.
8383         * gdb_select.h: Fix common/ includes.
8384         * gdb_bfd.c: Fix common/ includes.
8385         * gcore.c: Fix common/ includes.
8386         * fork-child.c: Fix common/ includes.
8387         * findvar.c: Fix common/ includes.
8388         * fbsd-nat.c: Fix common/ includes.
8389         * event-top.c: Fix common/ includes.
8390         * event-loop.c: Fix common/ includes.
8391         * dwarf2read.c: Fix common/ includes.
8392         * dwarf2loc.c: Fix common/ includes.
8393         * dwarf2-frame.c: Fix common/ includes.
8394         * dwarf-index-cache.c: Fix common/ includes.
8395         * dtrace-probe.c: Fix common/ includes.
8396         * disasm-selftests.c: Fix common/ includes.
8397         * defs.h: Fix common/ includes.
8398         * csky-tdep.c: Fix common/ includes.
8399         * cp-valprint.c: Fix common/ includes.
8400         * cp-support.h: Fix common/ includes.
8401         * cp-support.c: Fix common/ includes.
8402         * corelow.c: Fix common/ includes.
8403         * completer.h: Fix common/ includes.
8404         * completer.c: Fix common/ includes.
8405         * compile/compile.c: Fix common/ includes.
8406         * compile/compile-loc2c.c: Fix common/ includes.
8407         * compile/compile-cplus-types.c: Fix common/ includes.
8408         * compile/compile-cplus-symbols.c: Fix common/ includes.
8409         * command.h: Fix common/ includes.
8410         * cli/cli-dump.c: Fix common/ includes.
8411         * cli/cli-cmds.c: Fix common/ includes.
8412         * charset.c: Fix common/ includes.
8413         * build-id.c: Fix common/ includes.
8414         * btrace.h: Fix common/ includes.
8415         * btrace.c: Fix common/ includes.
8416         * breakpoint.h: Fix common/ includes.
8417         * breakpoint.c: Fix common/ includes.
8418         * ax.h:
8419         (enum agent_op): Fix common/ includes.
8420         * ax-general.c (struct aop_map): Fix common/ includes.
8421         * ax-gdb.c: Fix common/ includes.
8422         * auxv.c: Fix common/ includes.
8423         * auto-load.c: Fix common/ includes.
8424         * arm-tdep.c: Fix common/ includes.
8425         * arch/riscv.c: Fix common/ includes.
8426         * arch/ppc-linux-common.c: Fix common/ includes.
8427         * arch/i386.c: Fix common/ includes.
8428         * arch/arm.c: Fix common/ includes.
8429         * arch/arm-linux.c: Fix common/ includes.
8430         * arch/arm-get-next-pcs.c: Fix common/ includes.
8431         * arch/amd64.c: Fix common/ includes.
8432         * arch/aarch64.c: Fix common/ includes.
8433         * arch/aarch64-insn.c: Fix common/ includes.
8434         * arch-utils.c: Fix common/ includes.
8435         * amd64-windows-tdep.c: Fix common/ includes.
8436         * amd64-tdep.c: Fix common/ includes.
8437         * amd64-sol2-tdep.c: Fix common/ includes.
8438         * amd64-obsd-tdep.c: Fix common/ includes.
8439         * amd64-nbsd-tdep.c: Fix common/ includes.
8440         * amd64-linux-tdep.c: Fix common/ includes.
8441         * amd64-linux-nat.c: Fix common/ includes.
8442         * amd64-fbsd-tdep.c: Fix common/ includes.
8443         * amd64-fbsd-nat.c: Fix common/ includes.
8444         * amd64-dicos-tdep.c: Fix common/ includes.
8445         * amd64-darwin-tdep.c: Fix common/ includes.
8446         * agent.c: Fix common/ includes.
8447         * ada-lang.h: Fix common/ includes.
8448         * ada-lang.c: Fix common/ includes.
8449         * aarch64-tdep.c: Fix common/ includes.
8450
8451 2019-01-25  Tom Tromey  <tom@tromey.com>
8452
8453         * common/create-version.sh: Use common/version.h.
8454
8455 2019-01-24  Pedro Alves  <palves@redhat.com>
8456
8457         * infrun.c (signal_stop, signal_print, signal_program)
8458         (signal_catch, signal_pass): Now arrays instead of pointers.
8459         (update_signals_program_target, do_target_resume)
8460         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8461         * linux-nat.c (linux_nat_target::pass_signals)
8462         (linux_nat_target::create_inferior, linux_nat_target::attach):
8463         Adjust.
8464         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8465         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8466         * procfs.c (procfs_target::pass_signals): Adjust.
8467         * record-full.c (record_full_target::resume): Adjust.
8468         * remote.c (remote_target::pass_signals)
8469         (remote_target::program_signals): Adjust.
8470         * target-debug.h (target_debug_print_signals): Now takes a
8471         gdb::array_view as parameter.  Adjust.
8472         * target.h (target_ops) <pass_signals, program_signals>: Replace
8473         pointer and length parameters with gdb::array_view.
8474         (target_pass_signals, target_program_signals): Likewise.
8475         * target-delegates.c: Regenerate.
8476
8477 2019-01-24  Pedro Alves  <palves@redhat.com>
8478
8479         * common/forward-scope-exit.h
8480         (forward_scope_exit::forward_scope_exit): Pass arguments to
8481         m_bind_function directly, instead of creating a std::bind and
8482         copying that.
8483
8484 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8485
8486         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8487         for static members.
8488         (pass_in_v_vfp_candidate): Likewise.
8489
8490 2019-01-23  Tom Tromey  <tom@tromey.com>
8491             Pedro Alves  <palves@redhat.com>
8492
8493         * regcache.c (class regcache_invalidator): Remove.
8494         (regcache::raw_write): Use make_scope_exit.
8495
8496 2019-01-23  Tom Tromey  <tom@tromey.com>
8497
8498         * ui-out.h (class ui_out_emit_type): Update comment.
8499
8500 2019-01-23  Tom Tromey  <tom@tromey.com>
8501
8502         * infrun.c (fetch_inferior_event): Update comment.
8503
8504 2019-01-23  Tom Tromey  <tom@tromey.com>
8505             Pedro Alves  <palves@redhat.com>
8506
8507         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8508         parameter.
8509         (fetch_inferior_event): Use SCOPE_EXIT.
8510
8511
8512 2019-01-23  Tom Tromey  <tom@tromey.com>
8513             Pedro Alves  <palves@redhat.com>
8514
8515         * infrun.c (disable_thread_events): Delete.
8516         (stop_all_threads): Use SCOPE_EXIT.
8517
8518 2019-01-23  Tom Tromey  <tom@tromey.com>
8519             Pedro Alves  <palves@redhat.com>
8520
8521         * symfile.c: Include forward-scope-exit.h.
8522         (clear_symtab_users_cleanup): Replace forward declaration with
8523         a FORWARD_SCOPE_EXIT.
8524         (syms_from_objfile_1): Use the forward_scope_exit and
8525         gdb::optional instead of cleanup_function.
8526         (reread_symbols): Use the forward_scope_exit instead of
8527         cleanup_function.
8528         (clear_symtab_users_cleanup): Remove function.
8529
8530 2019-01-23  Tom Tromey  <tom@tromey.com>
8531             Pedro Alves  <palves@redhat.com>
8532
8533         * linux-nat.c: Include scope-exit.h.
8534         (cleanup_target_stop): Remove.
8535         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8536         SCOPE_EXIT.
8537
8538 2019-01-23  Tom Tromey  <tom@tromey.com>
8539             Pedro Alves  <palves@redhat.com>
8540
8541         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8542         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8543
8544 2019-01-23  Tom Tromey  <tom@tromey.com>
8545             Andrew Burgess  <andrew.burgess@embecosm.com>
8546             Pedro Alves  <palves@redhat.com>
8547
8548         * infrun.c (fetch_inferior_event): Use scope_exit.
8549         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8550         * top.c (execute_command): Use scope_exit.
8551         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8552         * utils.c (do_bpstat_clear_actions_cleanup)
8553         (make_bpstat_clear_actions_cleanup): Remove.
8554
8555 2019-01-23  Tom Tromey  <tom@tromey.com>
8556             Pedro Alves  <palves@redhat.com>
8557
8558         * infrun.c: Include "common/scope-exit.h"
8559         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8560         (wait_for_inferior): Use SCOPE_EXIT.
8561         (fetch_inferior_event): Use scope_exit.
8562
8563 2019-01-23  Tom Tromey  <tom@tromey.com>
8564             Pedro Alves  <palves@redhat.com>
8565
8566         * breakpoint.c (create_breakpoint): Remove cleanup.
8567
8568 2019-01-23  Tom Tromey  <tom@tromey.com>
8569             Andrew Burgess  <andrew.burgess@embecosm.com>
8570             Pedro Alves  <palves@redhat.com>
8571
8572 2019-01-23  Pedro Alves  <palves@redhat.com>
8573
8574         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8575
8576 2019-01-23  Pedro Alves  <palves@redhat.com>
8577             Andrew Burgess  <andrew.burgess@embecosm.com>
8578
8579         * gdbthread.h: Include "common/forward-scope-exit.h".
8580         (scoped_finish_thread_state): Redefine custom class in terms of
8581         forward_scope_exit.
8582
8583 2019-01-23  Pedro Alves  <palves@redhat.com>
8584             Andrew Burgess  <andrew.burgess@embecosm.com>
8585
8586         * common/forward-scope-exit.h: New file.
8587
8588 2019-01-23  Pedro Alves  <palves@redhat.com>
8589             Andrew Burgess  <andrew.burgess@embecosm.com>
8590             Tom Tromey  <tom@tromey.com>
8591
8592         * common/scope-exit.h: New file.
8593
8594 2019-01-23  Pedro Alves  <palves@redhat.com>
8595
8596         * common/preprocessor.h (ESC): Rename to ...
8597         (ESC_PARENS): ... this.
8598         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8599         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8600
8601 2019-01-23  Tom Tromey  <tom@tromey.com>
8602
8603         * language.h (class scoped_switch_to_sym_language_if_auto):
8604         Initialize m_lang in both cases.
8605
8606 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8607
8608         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8609         with XCNEW.
8610
8611 2019-01-22  Tom Tromey  <tom@tromey.com>
8612
8613         * corelow.c: Do not include sys/file.h.
8614
8615 2019-01-22  Tom Tromey  <tom@tromey.com>
8616
8617         * tui/tui-wingeneral.h: Include gdb_curses.h.
8618
8619 2019-01-22  Tom Tromey  <tom@tromey.com>
8620
8621         * source-cache.h (class source_cache) <get_source_lines,
8622         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8623
8624 2019-01-22  Tom Tromey  <tom@tromey.com>
8625
8626         * remote-fileio.h (struct remote_target): Declare.
8627
8628 2019-01-22  Tom Tromey  <tom@tromey.com>
8629
8630         * python/py-arch.c: Do not include py-ref.h.
8631         * python/py-bpevent.c: Do not include py-ref.h.
8632         * python/py-cmd.c: Do not include py-ref.h.
8633         * python/py-continueevent.c: Do not include py-ref.h.
8634         * python/py-event.h: Do not include py-ref.h.
8635         * python/py-evtregistry.c: Do not include py-ref.h.
8636         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8637         * python/py-frame.c: Do not include py-ref.h.
8638         * python/py-framefilter.c: Do not include py-ref.h.
8639         * python/py-function.c: Do not include py-ref.h.
8640         * python/py-infevents.c: Do not include py-ref.h.
8641         * python/py-linetable.c: Do not include py-ref.h.
8642         * python/py-objfile.c: Do not include py-ref.h.
8643         * python/py-param.c: Do not include py-ref.h.
8644         * python/py-prettyprint.c: Do not include py-ref.h.
8645         * python/py-progspace.c: Do not include py-ref.h.
8646         * python/py-symbol.c: Do not include py-ref.h.
8647         * python/py-symtab.c: Do not include py-ref.h.
8648         * python/py-type.c: Do not include py-ref.h.
8649         * python/py-unwind.c: Do not include py-ref.h.
8650         * python/py-utils.c: Do not include py-ref.h.
8651         * python/py-value.c: Do not include py-ref.h.
8652         * python/py-varobj.c: Do not include py-ref.h.
8653         * python/py-xmethods.c: Do not include py-ref.h.
8654         * python/python.c: Do not include py-ref.h.
8655         * varobj.c: Do not include py-ref.h.
8656
8657 2019-01-22  Tom Tromey  <tom@tromey.com>
8658
8659         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8660         keyword for bcache.
8661
8662 2019-01-22  Tom Tromey  <tom@tromey.com>
8663
8664         * compile/compile-cplus-types.c: Remove a comment by #include.
8665
8666 2019-01-22  Tom Tromey  <tom@tromey.com>
8667
8668         * compile/gcc-c-plugin.h: Include compile-internal.h.
8669
8670 2019-01-22  Tom Tromey  <tom@tromey.com>
8671
8672         * stabsread.c (EXTERN): Do not define.
8673         (symnum, next_symbol_text_func, processing_gcc_compilation)
8674         (within_function, global_sym_chain, global_stabs)
8675         (previous_stab_code, this_object_header_files)
8676         (n_this_object_header_files)
8677         (n_allocated_this_object_header_files): Define.
8678         * stabsread.h (EXTERN): Never define.  Use "extern".
8679
8680 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8681
8682         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8683         history_value.
8684
8685 2019-01-21  Tom Tromey  <tom@tromey.com>
8686
8687         * ui-out.c: Fix includes.
8688         * tui/tui-source.c: Fix includes.
8689         * target.c: Fix includes.
8690         * remote.c: Fix includes.
8691         * regcache.c: Fix includes.
8692         * python/py-block.c: Fix includes.
8693         * printcmd.c: Fix includes.
8694         * or1k-tdep.c: Fix includes.
8695         * mi/mi-main.c: Fix includes.
8696         * m32r-tdep.c: Fix includes.
8697         * csky-tdep.c: Fix includes.
8698         * compile/compile-cplus-types.c: Fix includes.
8699         * cli/cli-interp.c: Fix includes.
8700
8701 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8702
8703         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8704         for padding.
8705
8706 2019-01-16  Tom Tromey  <tom@tromey.com>
8707
8708         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8709         earlier.
8710         (struct objfile) <msymbols_range>: Move from top level.
8711         <msymbols>: New method.
8712         (class objfile_msymbols): Remove.
8713         * symtab.c (default_collect_symbol_completion_matches_break_on):
8714         Update.
8715         * symmisc.c (dump_msymbols): Update.
8716         * stabsread.c (scan_file_globals): Update.
8717         * objc-lang.c (info_selectors_command, info_classes_command)
8718         (find_methods): Update.
8719         * minsyms.c (find_solib_trampoline_target): Update.
8720         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8721         * coffread.c (coff_symfile_read): Update.
8722         * ada-lang.c (ada_lookup_simple_minsym)
8723         (ada_collect_symbol_completion_matches): Update.
8724
8725 2019-01-16  Tom Tromey  <tom@tromey.com>
8726
8727         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8728         type.  Remove no-argument constructor.
8729         <iterator::operator++>: Simplify.
8730         <begin>: Update.
8731         <end>: Use minimal_symbol_count.
8732
8733 2019-01-16  Tom Tromey  <tom@tromey.com>
8734
8735         * objfiles.h (struct objfile) <psymtabs>: New method.
8736         (class objfile_psymtabs): Remove.
8737         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8738         typedef.
8739         <range>: New method.
8740         (require_partial_symbols): Change return type.
8741         * psymtab.c (require_partial_symbols)
8742         (psym_expand_symtabs_matching): Update.
8743         * mdebugread.c (parse_partial_symbols): Update.
8744         * dbxread.c (dbx_end_psymtab): Update.
8745
8746 2019-01-15  Tom Tromey  <tom@tromey.com>
8747
8748         * symtab.c (lookup_objfile_from_block)
8749         (lookup_symbol_in_objfile_symtabs)
8750         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8751         (find_line_symtab, info_sources_command)
8752         (default_collect_symbol_completion_matches_break_on)
8753         (make_source_files_completion_list): Update.
8754         * symmisc.c (print_objfile_statistics, dump_objfile)
8755         (maintenance_print_symbols, maintenance_info_symtabs)
8756         (maintenance_check_symtabs, maintenance_info_line_tables):
8757         Update.
8758         * source.c (select_source_symtab)
8759         (forget_cached_source_info_for_objfile): Update.
8760         * objfiles.h (class objfile_compunits): Remove.
8761         (struct objfile) <compunits_range>: New typedef.
8762         (compunits): New method.
8763         * objfiles.c (objfile_relocate1): Update.
8764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8765         * maint.c (count_symtabs_and_blocks): Update.
8766         * linespec.c (iterate_over_all_matching_symtabs): Update.
8767         * cp-support.c (add_symbol_overload_list_qualified): Update.
8768         * coffread.c (coff_symtab_read): Update.
8769         * ada-lang.c (add_nonlocal_symbols)
8770         (ada_collect_symbol_completion_matches)
8771         (ada_add_global_exceptions): Update.
8772
8773 2019-01-15  Tom Tromey  <tom@tromey.com>
8774
8775         * progspace.h (program_space) <objfiles_safe_range>: New
8776         typedef.
8777         <objfiles_safe>: New method.
8778         * objfiles.h (class all_objfiles_safe): Remove.
8779         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8780         * jit.c (jit_inferior_exit_hook): Update.
8781
8782 2019-01-17  Tom Tromey  <tom@tromey.com>
8783
8784         * progspace.h (program_space) <objfiles_range>: New typedef.
8785         <objfiles>: New method.
8786         <objfiles_head>: Rename from objfiles.
8787         (object_files): Update.
8788         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8789         * guile/scm-pretty-print.c
8790         (ppscm_find_pretty_printer_from_objfiles): Update.
8791         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8792         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8793         Update.
8794         * python/py-progspace.c (pspy_get_objfiles): Update.
8795         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8796         Update.
8797         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8798         (objfpy_lookup_objfile_by_build_id): Update.
8799         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8800         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8801         Update.
8802         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8803         (expand_symtab_containing_pc, lookup_objfile_from_block)
8804         (lookup_static_symbol, basic_lookup_transparent_type)
8805         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8806         (find_line_symtab, info_sources_command)
8807         (default_collect_symbol_completion_matches_break_on)
8808         (make_source_files_completion_list, find_main_name): Update.
8809         * symmisc.c (print_symbol_bcache_statistics)
8810         (print_objfile_statistics, maintenance_print_symbols)
8811         (maintenance_print_msymbols, maintenance_print_objfiles)
8812         (maintenance_info_symtabs, maintenance_check_symtabs)
8813         (maintenance_expand_symtabs, maintenance_info_line_tables):
8814         Update.
8815         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8816         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8817         (map_overlay_command, unmap_overlay_command)
8818         (simple_overlay_update, expand_symtabs_matching)
8819         (map_symbol_filenames): Update.
8820         * symfile-debug.c (set_debug_symfile): Update.
8821         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8822         Update.
8823         * source.c (select_source_symtab, forget_cached_source_info):
8824         Update.
8825         * solib.c (solib_read_symbols): Update.
8826         * solib-spu.c (append_ocl_sos): Update.
8827         * psymtab.c (maintenance_print_psymbols)
8828         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8829         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8830         * printcmd.c (info_symbol_command): Update.
8831         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8832         Update.
8833         * objfiles.h (class all_objfiles): Remove.
8834         * objfiles.c (have_partial_symbols, have_full_symbols)
8835         (have_minimal_symbols, qsort_cmp, update_section_map)
8836         (shared_objfile_contains_address_p)
8837         (default_iterate_over_objfiles_in_search_order): Update.
8838         * objc-lang.c (info_selectors_command, info_classes_command)
8839         (find_methods): Update.
8840         * minsyms.c (find_solib_trampoline_target): Update.
8841         * maint.c (maintenance_info_sections)
8842         (maintenance_translate_address, count_symtabs_and_blocks):
8843         Update.
8844         * main.c (captured_main_1): Update.
8845         * linux-thread-db.c (try_thread_db_load_from_pdir)
8846         (has_libpthread): Update.
8847         * linespec.c (iterate_over_all_matching_symtabs)
8848         (search_minsyms_for_name): Update.
8849         * jit.c (jit_find_objf_with_entry_addr): Update.
8850         * hppa-tdep.c (find_unwind_entry)
8851         (hppa_lookup_stub_minimal_symbol): Update.
8852         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8853         Update.
8854         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8855         (elf_gnu_ifunc_resolve_by_got): Update.
8856         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8857         * dwarf-index-write.c (save_gdb_index_command): Update.
8858         * cp-support.c (add_symbol_overload_list_qualified): Update.
8859         * breakpoint.c (create_overlay_event_breakpoint)
8860         (create_longjmp_master_breakpoint)
8861         (create_std_terminate_master_breakpoint)
8862         (create_exception_master_breakpoint): Update.
8863         * blockframe.c (find_pc_partial_function): Update.
8864         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8865         (ada_collect_symbol_completion_matches)
8866         (ada_add_global_exceptions): Update.
8867
8868 2019-01-17  Tom Tromey  <tom@tromey.com>
8869
8870         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8871         declare VEC.
8872         (solib_target_parse_libraries): Change return type.
8873         (library_list_start_segment, library_list_start_section)
8874         (library_list_end_library, library_list_start_library); Update.
8875         (solib_target_free_library_list): Remove.
8876         (solib_target_parse_libraries): Remove cleanup.  Change return
8877         type.
8878         (solib_target_current_sos): Update.
8879
8880 2019-01-17  Tom Tromey  <tromey@bapiya>
8881
8882         * valprint.c: Replace "the the" with "the".
8883         * symtab.c: Replace "the the" with "the".
8884         * solib.c: Replace "the the" with "the".
8885         * solib-dsbt.c: Replace "the the" with "the".
8886         * linespec.c: Replace "the the" with "the".
8887         * dwarf2loc.h: Replace "the the" with "the".
8888         * amd64-windows-tdep.c: Replace "the the" with "the".
8889         * aarch64-tdep.c: Replace "the the" with "the".
8890
8891 2019-01-16  Keith Seitz  <keiths@redhat.com>
8892
8893         PR gdb/23773
8894         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8895         <builder>: Rename to ..
8896         <m_builder>: ... this and make private.
8897         (dwarf2_cu::get_builder): New method.  Change all users of
8898         `builder' to use this method.
8899         (dwarf2_start_symtab): Move to ...
8900         (dwarf2_cu::start_symtab): ... here.  Update all callers
8901         (setup_type_unit_groups): Move to ...
8902         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8903         callers.
8904         (dwarf2_cu::reset_builder): New method.
8905         (process_full_compunit, process_full_type_unit): Use
8906         dwarf2_cu::reset_builder.
8907         (follow_die_offset): Record the ancestor CU if it is different
8908         from the followed DIE's CU.
8909         (follow_die_sig_1): Likewise.
8910
8911 2019-01-15  Tom Tromey  <tom@tromey.com>
8912
8913         * remote.c (class remote_state) <buf>: Now a char_vector.
8914         <buf_size>: Remove.
8915         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8916         parameter.
8917         (remote_target::getpkt_or_notif_sane_1)
8918         (remote_target::getpkt_sane)
8919         (remote_target::getpkt_or_notif_sane): Likewise.
8920         (class remote_target) <putpkt>: New overload.
8921         (remote_target::read_frame): Change type of "buf_p".  Remove
8922         sizeof_p parameter.
8923         (packet_ok): New overload.
8924         (packet_check_result): New overload.
8925         Update all uses.
8926
8927 2019-01-14  Tom Tromey  <tom@tromey.com>
8928
8929         * remote-notif.c (handle_notification, remote_notif_ack)
8930         (remote_notif_parse): Make "buf" const.
8931         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8932         const.
8933         (remote_notif_parse, remote_notif_ack, handle_notification):
8934         Likewise.
8935         * remote.c (remote_notif_stop_parse): Make "buf" const.
8936         (remote_target::remote_parse_stop_reply): Make "buf" const.
8937         (remote_notif_stop_ack): Make "buf" const.
8938
8939 2019-01-14  Tom Tromey  <tom@tromey.com>
8940
8941         * remote.c (remote_console_output): Make parameter const.
8942
8943 2019-01-14  Tom Tromey  <tom@tromey.com>
8944
8945         * target-debug.h (target_debug_print_signals): Constify.
8946         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8947         * procfs.c (procfs_target::pass_signals): Update.
8948         * linux-nat.c (linux_nat_target::pass_signals): Update.
8949         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8950         * target-delegates.c: Rebuild.
8951         * remote.c (remote_target::program_signals): Update.
8952         (remote_target::pass_signals): Update.
8953         * target.c (target_pass_signals): Constify argument.
8954         (target_program_signals): Likewise.
8955         * target.h (struct target_ops) <pass_signals, program_signals>:
8956         Constify argument.
8957         (target_pass_signals, target_program_signals): Constify argument.
8958
8959 2019-01-14  Tom Tromey  <tom@tromey.com>
8960
8961         PR tui/28819:
8962         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8963
8964 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8965
8966         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8967         field.
8968         * rs6000-tdep.c: Include reggroups.h.
8969         (IS_V_ALIAS_PSEUDOREG): Define.
8970         (rs6000_register_name): Return names for the "vX" aliases.
8971         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8972         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8973         aliases.  Call default_register_reggroup_p for all other
8974         pseudo-registers.
8975         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8976         New functions.
8977         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8978         Handle "vX" aliases.
8979         (v_alias_pseudo_register_collect): New function.
8980         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8981         (rs6000_gdbarch_init): Initialize "vX" aliases as
8982         pseudo-registers.  Restore registration of
8983         rs6000_pseudo_register_reggroup_p with
8984         set_tdesc_pseudo_register_reggroup_p.
8985
8986 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8987
8988         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8989         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8990         set_gdbarch_num_pseudo_regs.
8991
8992 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8993
8994         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8995         Remove arg prefixname, add do_set and do_show.
8996         Add member functions set_list and show_list.
8997         * cli/cli-style.c (class cli_style_option): Update accordingly.
8998         (style_set_list): Move to file scope.
8999         (style_show_list): Likewise.
9000         (set_style): Call help_list.
9001         (show_style): Call cmd_show_list.
9002         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9003         Update to use the new macro.
9004
9005 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9006
9007         * ada-lang.c (_initialize_ada_language): Expand the help text
9008         for the "catch exception" command.
9009
9010 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9011
9012         * symtab.c (matching_obj_sections): Initialize obj,
9013         declare it closer to its usage.
9014
9015 2019-01-10  Tom Tromey  <tom@tromey.com>
9016
9017         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9018         (basic_inf_threads_range): Remove.
9019         (inf_threads_range, inf_non_exited_threads_range)
9020         (safe_inf_threads_range): Use next_adapter.
9021
9022 2019-01-10  Keith Seitz  <keiths@redhat.com>
9023
9024         PR gdb/23712
9025         PR symtab/23010
9026         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9027         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9028
9029 2019-01-10  Keith Seitz  <keiths@redhat.com>
9030
9031         PR gdb/23712
9032         PR symtab/23010
9033         * dictionary.c (pending_to_vector): Remove.
9034         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9035         Remove _1 suffix, replacing functions of the same name.  Update
9036         all callers.
9037         (dict_create_hashed, dict_create_hashed_expandable)
9038         (dict_create_linear, dict_create_linear_expandable, dict_free)
9039         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9040         Make functions static.
9041
9042 2019-01-10  Keith Seitz  <keiths@redhat.com>
9043
9044         PR gdb/23712
9045         PR symtab/23010
9046         * dictionary.h (struct dictionary): Replace declaration with
9047         multidictionary.
9048         (dict_create_hashed, dict_create_hashed_expandable)
9049         (dict_create_linear, dict_create_linear_expandable)
9050         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9051         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9052         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9053         taking multidictionary argument.
9054         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9055         * block.h (struct block) <dict>: Change to multidictionary
9056         and rename `multidict'.
9057         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9058         symmisc.c: Update all dictionary references to multidictionary.
9059
9060 2019-01-10  Keith Seitz  <keiths@redhat.com>
9061
9062         PR gdb/23712
9063         PR symtab/23010
9064         * dictionary.c: Include unordered_map.
9065         (pending_to_vector): New function.
9066         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9067         Rewrite the non-"_1" functions to take vector instead
9068         of linked list.
9069         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9070         "new" _1 versions of the same name.
9071         (multidictionary): Define.
9072         (std::hash<enum language): New definition.
9073         (collate_pending_symbols_by_language, mdict_create_hashed)
9074         (mdict_create_hashed_expandable, mdict_create_linear)
9075         (mdict_create_linear_expandable, mdict_free)
9076         (find_language_dictionary, create_new_language_dictionary)
9077         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9078         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9079         (mdict_size, mdict_empty): New functions.
9080         * dictionary.h (mdict_iterator): Define.
9081
9082 2019-01-10  Pedro Alves  <palves@redhat.com>
9083
9084         * breakpoint.c (read_uploaded_action)
9085         (create_tracepoint_from_upload): Adjust to use
9086         gdb::unique_xmalloc_ptr.
9087         * ctf.c (ctf_write_uploaded_tp):
9088         (SET_ARRAY_FIELD): Use emplace_back.
9089         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9090         * tracefile-tfile.c (tfile_write_uploaded_tp):
9091         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9092         gdb::unique_xmalloc_ptr.
9093         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9094         at_string, cond_string, cmd_strings>: Replace char pointers
9095         with gdb::unique_xmalloc_ptr.
9096
9097 2019-01-10  Pedro Alves  <palves@redhat.com>
9098
9099         * solib-target.c (library_list_start_library): Don't xstrdup name.
9100
9101 2019-01-10  Pedro Alves  <palves@redhat.com>
9102
9103         * mdebugread.c (parse_partial_symbols): Use
9104         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9105
9106 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9107
9108         * linux-fork.c (scoped_switch_fork_info)
9109         <~scoped_switch_fork_info>: Fix incorrect variable name.
9110
9111 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9112
9113         * linux-fork.c (scoped_switch_fork_info)
9114         <scoped_switch_fork_info>: Make explicit.
9115         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9116
9117 2019-01-10  Tom Tromey  <tom@tromey.com>
9118
9119         * objfiles.h (objfile::reset_psymtabs): Update.
9120         * objfiles.c (objfile::objfile): Update.
9121         * psymtab.h (psymtab_storage::obstack): Update.
9122         (psymtab_storage::m_obstack): Use gdb::optional.
9123         (class psymtab_storage): Update comment.  Remove objfile
9124         parameter.
9125         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9126
9127 2019-01-10  Tom Tromey  <tom@tromey.com>
9128
9129         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9130         <free_psymtabs>: Now private.
9131         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9132         (allocate_psymtab): Use new method.
9133
9134 2019-01-10  Tom Tromey  <tom@tromey.com>
9135
9136         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9137         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9138         * mdebugread.c (parse_partial_symbols): Use
9139         allocate_dependencies.
9140         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9141         allocate_dependencies.
9142         (process_psymtab_comp_unit_reader)
9143         (build_type_psymtab_dependencies): Likewise.
9144         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9145
9146 2019-01-10  Tom Tromey  <tom@tromey.com>
9147
9148         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9149         PSYMBOL_SET_LANGUAGE.
9150         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9151
9152 2019-01-10  Tom Tromey  <tom@tromey.com>
9153
9154         * psymtab.h (psymtab_storage::obstack): New method.
9155         <m_obstack>: Rename from obstack; now private.
9156         * psymtab.c (psymtab_storage): Update.
9157         * dwarf2read.c (create_addrmap_from_index)
9158         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9159         Update.
9160
9161 2019-01-10  Tom Tromey  <tom@tromey.com>
9162
9163         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9164         * objfiles.h (objfile::reset_psymtabs): New method.
9165
9166 2019-01-10  Tom Tromey  <tom@tromey.com>
9167
9168         * symmisc.c (print_symbol_bcache_statistics): Update.
9169         (print_objfile_statistics): Update.
9170         * symfile.c (reread_symbols): Update.
9171         * psymtab.h (class psymtab_storage): New.
9172         * psymtab.c (psymtab_storage): New constructor.
9173         (~psymtab_storage): New destructor.
9174         (require_partial_symbols): Update.
9175         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9176         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9177         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9178         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9179         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9180         (start_psymtab_common, end_psymtab_common)
9181         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9182         (allocate_psymtab): Update.
9183         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9184         Update.
9185         (dump_psymtab_addrmap, maintenance_print_psymbols)
9186         (maintenance_check_psymtabs): Update.
9187         (class objfile_psymtabs): Move to objfiles.h.
9188         * psympriv.h (discard_psymtab): Now inline.
9189         (psymtab_discarder::psymtab_discarder): Update.
9190         (psymtab_discarder::~psymtab_discarder): Update.
9191         (ALL_OBJFILE_PSYMTABS): Rewrite.
9192         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9193         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9194         Remove fields.
9195         <partial_symtabs>: New field.
9196         (class objfile_psymtabs): Move from psymtab.h.  Update.
9197         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9198         psymbol_cache.
9199         (objfile::~objfile): Don't destroy psymbol_cache.
9200         * mdebugread.c (parse_partial_symbols): Update.
9201         * dwarf2read.c (create_addrmap_from_index)
9202         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9203         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9204         (add_partial_subprogram, dwarf2_ranges_read): Update.
9205         * dwarf-index-write.c (write_address_map)
9206         (write_one_signatured_type, recursively_write_psymbols)
9207         (class debug_names, class debug_names, write_psymtabs_to_index):
9208         Update.
9209
9210 2019-01-10  Tom Tromey  <tom@tromey.com>
9211
9212         * symtab.h (SYMBOL_SET_NAMES): Update.
9213         (symbol_set_names): Update.
9214         (MSYMBOL_SET_NAMES): Update.
9215         * symtab.c (symbol_set_names): Change argument to be an
9216         objfile_per_bfd_storage.
9217         * psymtab.c (add_psymbol_to_bcache): Update.
9218         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9219
9220 2019-01-10  Tom Tromey  <tom@tromey.com>
9221
9222         * symtab.c (create_demangled_names_hash): Change argument to be an
9223         objfile_per_bfd_storage.
9224         (symbol_set_names): Update.
9225
9226 2019-01-10  Tom Tromey  <tom@tromey.com>
9227
9228         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9229         init_psymbol_list.
9230         * psymtab.c (init_psymbol_list): Do nothing if already called.
9231         * psympriv.h (init_psymbol_list): Add comment.
9232         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9233         init_psymbol_list.
9234         * dbxread.c (dbx_symfile_read): Unconditionally call
9235         init_psymbol_list.
9236
9237 2019-01-10  Tom Tromey  <tom@tromey.com>
9238
9239         * xcoffread.c (scan_xcoff_symtab): Update.
9240         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9241         "where".
9242         * mdebugread.c (parse_partial_symbols)
9243         (handle_psymbol_enumerators): Update.
9244         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9245         * dbxread.c (read_dbx_symtab): Update.
9246         * psympriv.h (psymbol_placement): New enum.
9247         (add_psymbol_to_list): Update.
9248
9249 2019-01-10  Tom Tromey  <tom@tromey.com>
9250
9251         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9252         static_psymbols parameters.
9253         (scan_xcoff_symtab): Update.
9254         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9255         static_psymbols parameters.
9256         * psympriv.h (start_psymtab_common): Update.
9257         * mdebugread.c (parse_partial_symbols): Update.
9258         * dwarf2read.c (create_partial_symtab): Update.
9259         * dbxread.c (read_dbx_symtab): Update.
9260         (start_psymtab): Remove global_psymbols and static_psymbols
9261         parameters.
9262
9263 2019-01-10  Tom Tromey  <tom@tromey.com>
9264
9265         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9266         * psymtab.c (allocate_psymtab): Add comment.
9267         * psympriv.h (allocate_psymtab): Add comment.
9268         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9269         initializations.
9270         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9271
9272 2019-01-10  Tom Tromey  <tom@tromey.com>
9273
9274         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9275         Don't declare.
9276         * mipsread.c: Include mdebugread.h.
9277         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9278         Declare.
9279         * elfread.c: Include mdebugread.h.
9280
9281 2019-01-09  Tom Tromey  <tom@tromey.com>
9282
9283         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9284         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9285         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9286         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9287         (psym_lookup_symbol, psym_find_last_source_symtab)
9288         (psym_forget_cached_source_info, psym_print_stats)
9289         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9290         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9291         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9292         (psym_find_compunit_symtab_by_address)
9293         (maintenance_print_psymbols, maintenance_info_psymtabs)
9294         (maintenance_check_psymtabs): Use ranged for.
9295         * psymtab.h (class objfile_psymtabs): New.
9296         (require_partial_symbols): Return objfile_psymtabs.
9297         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9298
9299 2019-01-09  Tom Tromey  <tom@tromey.com>
9300
9301         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9302         (find_pc_mapped_section, list_overlays_command)
9303         (map_overlay_command, unmap_overlay_command)
9304         (simple_overlay_update): Use all_objfiles.
9305         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9306         * printcmd.c (info_symbol_command): Use all_objfiles.
9307         * objfiles.h (ALL_OBJSECTIONS): Remove.
9308         * maint.c (maintenance_translate_address): Use all_objfiles.
9309         * gcore.c (gcore_create_callback): Use all_objfiles.
9310         (objfile_find_memory_regions): Likewise.
9311
9312 2019-01-09  Tom Tromey  <tom@tromey.com>
9313
9314         * symtab.c (find_line_symtab, info_sources_command)
9315         (make_source_files_completion_list): Use objfile_compunits.
9316         * source.c (select_source_symtab): Use objfile_compunits.
9317         * objfiles.h (struct objfile): Update comment.
9318         (ALL_OBJFILES): Remove.
9319         (ALL_FILETABS): Remove.
9320         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9321         objfile_compunits.
9322
9323 2019-01-09  Tom Tromey  <tom@tromey.com>
9324
9325         * symmisc.c (print_objfile_statistics, dump_objfile)
9326         (maintenance_print_symbols): Use compunit_filetabs.
9327         * source.c (forget_cached_source_info_for_objfile): Use
9328         compunit_filetabs.
9329         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9330         (ALL_FILETABS): Use compunit_filetabs.
9331         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9332         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9333
9334 2019-01-09  Tom Tromey  <tom@tromey.com>
9335
9336         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9337         (compunit_filetabs): New.
9338         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9339         compunit_filetabs.
9340         (info_sources_command, make_source_files_completion_list): Remove
9341         declaration.
9342         * symmisc.c (print_objfile_statistics, dump_objfile)
9343         (maintenance_print_symbols): Remove declaration.
9344         (maintenance_info_symtabs): Use compunit_filetabs.
9345         (maintenance_info_line_tables): Likewise.
9346         * source.c (select_source_symtab): Change local variable name.
9347         (forget_cached_source_info_for_objfile): Remove declaration.
9348         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9349         * objfiles.c (objfile_relocate1): Remove declaration.
9350         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9351         declaration.
9352         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9353         * coffread.c (coff_symtab_read): Remove declaration.
9354         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9355         compunit_filetabs.
9356
9357 2019-01-09  Tom Tromey  <tom@tromey.com>
9358
9359         * symtab.c (lookup_objfile_from_block)
9360         (find_pc_sect_compunit_symtab, search_symbols)
9361         (default_collect_symbol_completion_matches_break_on): Use
9362         objfile_compunits.
9363         * objfiles.h (ALL_COMPUNITS): Remove.
9364         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9365         * cp-support.c (add_symbol_overload_list_qualified): Use
9366         objfile_compunits.
9367         * ada-lang.c (ada_collect_symbol_completion_matches)
9368         (ada_add_global_exceptions): Use objfile_compunits.
9369
9370 2019-01-09  Tom Tromey  <tom@tromey.com>
9371
9372         * source.c (select_source_symtab)
9373         (forget_cached_source_info_for_objfile): Remove declaration.
9374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9375         declaration.
9376         * maint.c (count_symtabs_and_blocks): Remove declaration.
9377         * cp-support.c (add_symbol_overload_list_qualified): Remove
9378         declaration.
9379         * coffread.c (coff_symtab_read): Remove declaration.
9380         * symtab.c (lookup_symbol_in_objfile_symtabs)
9381         (basic_lookup_transparent_type_1): Use objfile_compunits.
9382         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9383         (info_sources_command, search_symbols)
9384         (default_collect_symbol_completion_matches_break_on)
9385         (make_source_files_completion_list): Remove declaration.
9386         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9387         (ada_collect_symbol_completion_matches)
9388         (ada_add_global_exceptions): Remove declaration.
9389         * linespec.c (iterate_over_all_matching_symtabs): Use
9390         objfile_compunits.
9391         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9392         (class objfile_compunits): New.
9393         (ALL_COMPUNITS): Use objfile_compunits.
9394         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9395         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9396         objfile_compunits.
9397         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9398
9399 2019-01-09  Tom Tromey  <tom@tromey.com>
9400
9401         * symtab.c (search_symbols)
9402         (default_collect_symbol_completion_matches_break_on): Use
9403         objfile_msymbols.
9404         * ada-lang.c (ada_lookup_simple_minsym)
9405         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9406         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9407         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9408         objfile_msymbols.
9409         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9410         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9411         * objc-lang.c (find_methods): Use objfile_msymbols.
9412         (info_selectors_command, info_classes_command): Likewise.
9413         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9414         * objfiles.h (class objfile_msymbols): New.
9415         (ALL_OBJFILE_MSYMBOLS): Remove.
9416         (ALL_MSYMBOLS): Remove.
9417
9418 2019-01-09  Tom Tromey  <tom@tromey.com>
9419
9420         * common/next-iterator.h (next_adapter): Add Iterator template
9421         parameter.
9422         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9423         (class all_objfiles_safe): New.
9424         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9425         * objfiles.c (put_objfile_before): Update comment.
9426         (add_separate_debug_objfile): Likewise.
9427         (free_all_objfiles): Use all_objfiles_safe.
9428         (objfile_purge_solibs): Likewise.
9429
9430 2019-01-09  Tom Tromey  <tom@tromey.com>
9431
9432         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9433         (expand_symtab_containing_pc, lookup_static_symbol)
9434         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9435         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9436         all_objfiles.
9437         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9438         * breakpoint.c (create_overlay_event_breakpoint)
9439         (create_longjmp_master_breakpoint)
9440         (create_std_terminate_master_breakpoint)
9441         (create_exception_master_breakpoint): Use all_objfiles.
9442         * linux-thread-db.c (try_thread_db_load_from_pdir)
9443         (has_libpthread): Use all_objfiles.
9444         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9445         * linespec.c (iterate_over_all_matching_symtabs)
9446         (search_minsyms_for_name): Use all_objfiles.
9447         * maint.c (maintenance_info_sections): Use all_objfiles.
9448         * main.c (captured_main_1): Use all_objfiles.
9449         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9450         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9451         * guile/scm-pretty-print.c
9452         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9453         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9454         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9455         (maintenance_print_msymbols): Use all_objfiles.
9456         * source.c (select_source_symtab): Use all_objfiles.
9457         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9458         * symfile.c (remove_symbol_file_command)
9459         (expand_symtabs_matching, map_symbol_filenames): Use
9460         all_objfiles.
9461         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9462         all_objfiles.
9463         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9464         * objc-lang.c (find_methods): Use all_objfiles.
9465         * objfiles.c (have_partial_symbols, have_full_symbols)
9466         (have_minimal_symbols, qsort_cmp)
9467         (default_iterate_over_objfiles_in_search_order): Use
9468         all_objfiles.
9469         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9470         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9471         (maintenance_check_psymtabs): Use all_objfiles.
9472         (ALL_PSYMTABS): Remove.
9473         * compile/compile-object-run.c (do_module_cleanup): Use
9474         all_objfiles.
9475         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9476         * cp-support.c (add_symbol_overload_list_qualified): Use
9477         all_objfiles.
9478         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9479         Use all_objfiles.
9480         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9481         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9482         all_objfiles.
9483         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9484         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9485         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9486         Uses all_objfiles.
9487         * solib.c (solib_read_symbols): Use all_objfiles
9488
9489 2019-01-09  Tom Tromey  <tom@tromey.com>
9490
9491         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9492         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9493         all_objfiles.
9494         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9495         * symmisc.c (print_symbol_bcache_statistics)
9496         (print_objfile_statistics, maintenance_print_objfiles)
9497         (maintenance_info_symtabs, maintenance_check_symtabs)
9498         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9499         all_objfiles.
9500         * source.c (forget_cached_source_info): Use all_objfiles.
9501         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9502         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9503         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9504         * objfiles.c (update_section_map): Use all_objfiles.
9505         (shared_objfile_contains_address_p): Likewise.
9506         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9507         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9508
9509 2019-01-09  Tom Tromey  <tom@tromey.com>
9510
9511         * common/next-iterator.h: New file.
9512         * objfiles.h (class all_objfiles): New.
9513         (struct objfile_iterator): New.
9514
9515 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9516
9517         * NEWS: Move the description of the changed "frame", "select-frame",
9518          and "info frame" commands to the Changed commands section.
9519
9520 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9521
9522         * gdbtypes.c (check_stub_method_group): Remove handling of old
9523         mangling schemes.
9524         * linespec.c (find_methods): Likewise.
9525         * stabsread.c (read_member_functions): Likewise.
9526         * valops.c (search_struct_method): Likewise.
9527         (value_struct_elt_for_reference): Likewise.
9528         * NEWS: Mention this change.
9529
9530 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9531
9532         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9533         print_source_lines.
9534         * source.c (print_source_lines_base): Update line number check.
9535         (print_source_lines): New function.
9536         (source_lines_range::source_lines_range): New function.
9537         * source.h (class source_lines_range): New class.
9538         (print_source_lines): New declaration.
9539
9540 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9541
9542         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9543
9544 2019-01-08  Tom Tromey  <tom@tromey.com>
9545             Simon Marchi  <simon.marchi@ericsson.com>
9546
9547         PR gdb/24060
9548         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9549         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9550         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9551         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9552         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9553         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9554
9555 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9556
9557         * source.c (select_source_symtab): Move header comment to
9558         declaration in source.h.
9559         (forget_cached_source_info_for_objfile): Likewise.
9560         (forget_cached_source_info): Likewise.
9561         (identify_source_line): Likewise.
9562         * source.h (identify_source_line): Move declaration from symtab.h
9563         and add comment from source.c
9564         (print_source_lines): Likewise.
9565         (forget_cached_source_info_for_objfile): Likewise.
9566         (forget_cached_source_info): Likewise.
9567         (select_source_symtab): Likewise.
9568         (enum print_source_lines_flag): Move definition from symtab.h.
9569         * symtab.h (identify_source_line): Move declaration to source.h.
9570         (print_source_lines): Likewise.
9571         (forget_cached_source_info_for_objfile): Likewise.
9572         (forget_cached_source_info): Likewise.
9573         (select_source_symtab): Likewise.
9574         (enum print_source_lines_flag): Move definition to source.h.
9575         * tui/tui-hooks.c: Add 'source.h' include.
9576
9577 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9578
9579         * source.c (print_source_lines_base): Handle requests to print
9580         reverse line number sequences, and guard against empty lines
9581         string.
9582
9583 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9584
9585         * source.c (print_source_lines_base): Fix skip of '\r' if next
9586         character is '\n'.
9587
9588 2019-01-06  Tom Tromey  <tom@tromey.com>
9589
9590         * c-exp.y (struct c_parse_state) <macro_original_text,
9591         expansion_obstack>: New member.
9592         (macro_original_text, expansion_obstack): Remove globals.
9593         (scan_macro_expansion, scanning_macro_expansion)
9594         (finished_macro_expansion): Update.
9595         (scan_macro_cleanup): Remove.
9596         (yylex, c_parse): Update.
9597
9598 2019-01-06  Tom Tromey  <tom@tromey.com>
9599
9600         * c-exp.y (struct c_parse_state) <strings>: New member.
9601         (operator_stoken): Update.
9602
9603 2019-01-06  Tom Tromey  <tom@tromey.com>
9604
9605         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9606         (union type_stack_elt) <typelist_val>: Now a pointer to
9607         std::vector.
9608         (type_stack_cleanup): Don't declare.
9609         (push_typelist): Update.
9610         * parse.c (pop_typelist): Return a std::vector.
9611         (push_typelist): Take a std::vector.
9612         (follow_types): Update.  Do not free args.
9613         (type_stack_cleanup): Remove.
9614         * c-exp.y (struct c_parse_state): New.
9615         (cpstate): New global.
9616         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9617         (nonempty_typelist): Update.
9618         (func_mod): Create a new vector.
9619         (c_parse): Create a c_parse_state.
9620         (check_parameter_typelist): Do not delete params.
9621         (function_method): Update.  Do not delete type_list.
9622
9623 2019-01-06  Tom Tromey  <tom@tromey.com>
9624
9625         PR gdb/28155:
9626         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9627         check_typedef.
9628         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9629         (print_return_value): Likewise.
9630
9631 2019-01-05  Tom Tromey  <tom@tromey.com>
9632
9633         * contrib/cleanup_check.py: Remove.
9634         * contrib/gcc-with-excheck: Remove.
9635         * contrib/exsummary.py: Remove.
9636         * contrib/excheck.py: Remove.
9637
9638 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9639
9640         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9641         NULL. Initialize tpprev to NULL instead of assigning it
9642         to NULL on the next statement.
9643         * windows-nat.c (windows_delete_thread): Remove check for
9644         main_thread_id before printing thread exit notifications.
9645         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9646         Remove thread ID check against main_thread_id.
9647         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9648         windows_delete_thread.
9649         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9650
9651 2019-01-04  Tom Tromey  <tom@tromey.com>
9652
9653         * compile/compile.c (_initialize_compile): Use upper case for
9654         metasyntactic variables.
9655         * symmisc.c (_initialize_symmisc): Use upper case for
9656         metasyntactic variables.
9657         * psymtab.c (_initialize_psymtab): Use upper case for
9658         metasyntactic variables.
9659         * demangle.c (demangle_command): Use upper case for metasyntactic
9660         variables.
9661         (_initialize_demangler): Likewise.
9662         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9663         variables.
9664
9665 2019-01-03  Tom Tromey  <tom@tromey.com>
9666
9667         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9668
9669 2019-01-03  Tom Tromey  <tom@tromey.com>
9670
9671         * python/py-symtab.c (salpy_str): Update.
9672         (struct salpy_sal_object) <symtab>: Now a PyObject.
9673         (salpy_dealloc): Update.
9674         (del_objfile_sal): Use gdbpy_ref.
9675
9676 2019-01-03  Tom Tromey  <tom@tromey.com>
9677
9678         * python/py-type.c (convert_field): Use new_reference.  Return
9679         gdbpy_ref.
9680         (make_fielditem): Return gdbpy_ref.
9681         (typy_fields): Update.
9682         (typy_getitem): Update.
9683         (field_name): Return gdbpy_ref.  Use new_reference.
9684         (typy_iterator_iternext): Update.
9685
9686 2019-01-03  Tom Tromey  <tom@tromey.com>
9687
9688         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9689
9690 2019-01-03  Tom Tromey  <tom@tromey.com>
9691
9692         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9693         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9694         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9695         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9696         (pspy_set_type_printers): Likewise.
9697         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9698         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9699         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9700         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9701         (objfpy_set_type_printers): Likewise.
9702
9703 2019-01-03  Tom Tromey  <tom@tromey.com>
9704
9705         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9706         (gdbpy_print_stack): Use gdbpy_err_fetch.
9707         * python/python-internal.h (class gdbpy_err_fetch): New class.
9708         (class gdbpy_enter) <m_error_type, m_error_value,
9709         m_error_traceback>: Remove.
9710         <m_error>: New member.
9711         (gdbpy_exception_to_string): Don't declare.
9712         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9713         * python/py-value.c (convert_value_from_python): Use
9714         gdbpy_err_fetch.
9715         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9716         gdbpy_exception_to_string.
9717         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9718         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9719         gdbpy_err_fetch.
9720
9721 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9722
9723         * linux-nat.c (delete_lwp_cleanup): Delete.
9724         (struct lwp_deleter): New struct.
9725         (lwp_info_up): New typedef.
9726         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9727         lwp_info_up.
9728
9729 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9730
9731         * linux-fork.c (class scoped_switch_fork_info): New class.
9732         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9733
9734 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9735
9736         * valops.c (find_overload_match): Remove use of null_cleanup, and
9737         calls to do_cleanups.
9738
9739 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9740
9741         * compile/compile-cplus-types.c
9742         (compile_cplus_instance::decl_name): Handle changes to
9743         cp_func_name.
9744         * cp-support.c (cp_func_name): Update header comment, update
9745         return type.
9746         * cp-support.h (cp_func_name): Update return type in declaration.
9747         * valops.c (find_overload_match): Move temp_func local to top
9748         level of function and change its type.  Use temp_func to hold and
9749         delete temporary string obtained from cp_func_name.
9750
9751 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9752
9753         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9754         gdb::char_vector, remove cleanup, and update uses of `msg`.
9755
9756 2019-01-03  Jim Wilson  <jimw@sifive.com>
9757
9758         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9759
9760 2019-01-02  Tom Tromey  <tom@tromey.com>
9761
9762         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9763         (tdesc_parse_xml): Remove cleanups.
9764         * target-descriptions.h (make_cleanup_free_target_description):
9765         Don't declare.
9766         (target_desc_deleter): New struct.
9767         (target_desc_up): New typedef.
9768         * target-descriptions.c (target_desc_deleter::operator()): Rename
9769         from free_target_description.
9770         (make_cleanup_free_target_description): Remove.
9771
9772 2019-01-02  Tom Tromey  <tom@tromey.com>
9773
9774         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9775         constructor, destructor.
9776         (linespec_parser): Remove typedef.
9777         (~linespec_parser): Rename from linespec_parser_delete.
9778         (linespec_lex_to_end, linespec_complete_label)
9779         (linespec_complete): Update.
9780         (decode_line_full): Remove cleanups.
9781         (decode_line_1): Update.
9782
9783 2019-01-02  Tom Tromey  <tom@tromey.com>
9784
9785         * python/python-internal.h (inferior_to_inferior_object): Change
9786         return type.
9787         * python/py-exitedevent.c (create_exited_event_object): Update.
9788         * python/py-inferior.c (inferior_to_inferior_object): Return
9789         gdbpy_ref.
9790         (python_new_inferior, python_inferior_deleted)
9791         (thread_to_thread_object, delete_thread_object)
9792         (build_inferior_list, gdbpy_selected_inferior): Update.
9793         * python/py-infthread.c (create_thread_object): Update.  Also fail
9794         if inferior_to_inferior_object fails.
9795
9796 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9797
9798         * inferior.h (class inferior) <displaced_step_state>: New field.
9799         * infrun.h (struct displaced_step_state): Move here from
9800         infrun.c.  Initialize fields, add constructor.
9801         <inf>: Remove field.
9802         <reset>: New method.
9803         * infrun.c (struct displaced_step_inferior_state): Move to
9804         infrun.h.
9805         (displaced_step_inferior_states): Remove.
9806         (get_displaced_stepping_state): Adust.
9807         (displaced_step_in_progress_any_inferior): Adjust.
9808         (displaced_step_in_progress_thread): Adjust.
9809         (displaced_step_in_progress): Adjust.
9810         (add_displaced_stepping_state): Remove.
9811         (get_displaced_step_closure_by_addr): Adjust.
9812         (remove_displaced_stepping_state): Remove.
9813         (infrun_inferior_exit): Call displaced_step_state.reset.
9814         (use_displaced_stepping): Don't check for NULL.
9815         (displaced_step_prepare_throw): Call
9816         get_displaced_stepping_state.
9817         (displaced_step_fixup): Don't check for NULL.
9818         (prepare_for_detach): Don't check for NULL.
9819
9820 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9821
9822         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9823          in case of call that did not complete.
9824
9825 2019-01-02  Andrey Utkin  <autkin@undo.io>
9826
9827         * symfile.c (find_separate_debug_file): Fix search of debug files for
9828         remote debuggee.
9829
9830 2019-01-02  Tom Tromey  <tom@tromey.com>
9831
9832         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9833         indentation.
9834         * python/py-frame.c (frapy_older): Remove cast.
9835         (frapy_newer): Likewise.
9836         * python/py-breakpoint.c (local_setattro): Remove cast.
9837         * python/py-arch.c (archpy_name): Remove local variable.
9838         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9839
9840 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9841
9842         * unittests/basic_string_view/element_access/char/empty.cc:
9843         Fix year range in copyright header.
9844
9845 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9846
9847         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9848         Delete.
9849         <operator==>: Update with for removed field.
9850         <hash>: Likewise.
9851         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9852         <isa_features>: ...this.
9853         <abi_features>: New field.
9854         (riscv_isa_flen): Update comment.
9855         (riscv_abi_xlen): New declaration.
9856         (riscv_abi_flen): New declaration.
9857         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9858         isa_features.
9859         (riscv_abi_xlen): New function.
9860         (riscv_isa_flen): Update to get answer from isa_features.
9861         (riscv_abi_flen): New function.
9862         (riscv_has_fp_abi): Update to get answer from abi_features.
9863         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9864         xlen and flen.
9865         (riscv_call_info) <xlen, flen>: Update comment.
9866         (riscv_call_arg_struct): Remove invalid assertions
9867         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9868         is removed.
9869         (riscv_gdbarch_init): Gather isa features and abi features
9870         separately, ensure both match on the gdbarch when reusing an old
9871         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9872         a target with 64-bit float hardware.
9873
9874 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9875
9876         * source.c (search_command_helper): Stop reverse search
9877         when line 1 has been searched.
9878
9879 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9880
9881         * record-full.c (record_full_base_target::close): Rewrite
9882         record_full_core_buf_list free logic.
9883
9884 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9885
9886         * break-catch-syscall.c (print_one_catch_syscall): xfree
9887         the last text.
9888
9889 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9890
9891         * top.c (print_gdb_version): Update Copyright year in version
9892         message.
9893
9894 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9895
9896         Update copyright year range in all GDB files.
9897
9898 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9899
9900         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9901
9902 For older changes see ChangeLog-2018.
9903 \f
9904 Local Variables:
9905 mode: change-log
9906 left-margin: 8
9907 fill-column: 74
9908 version-control: never
9909 coding: utf-8
9910 End:
9911