gdb/ChangeLog

   1 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * gdbsupport/common-utils.h (startswith): Change return type to
   4         bool.
   5
   6 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
   7
   8         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
   9         * breakpoint.c (bp_locations_compare): Rename to...
  10         (bp_location_is_less_than): ...this, and change to std::sort semantics.
  11         (update_global_location_list): Use std::sort instead of qsort.
  12         * buildsym.c (compare_line_numbers): Rename to...
  13         (lte_is_less_than): ...this, and change to std::sort semantics.
  14         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
  15         instead of qsort.
  16         * disasm.c (compare_lines): Rename to...
  17         (line_is_less_than): ...this, and change to std::sort semantics.
  18         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
  19         of qsort.
  20         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
  21         (fde_is_less_than): ...this, and change to std::sort semantics.
  22         (dwarf2_build_frame_info): Call std::sort instead of qsort.
  23         * mdebugread.c (compare_blocks):
  24         (block_is_less_than): ...this, and change to std::sort semantics.
  25         (sort_blocks): Call std::sort instead of qsort.
  26         * objfiles.c (qsort_cmp): Rename to...
  27         (sort_cmp): ...this, and change to std::sort semantics.
  28         (update_section_map): Call std::sort instead of qsort.
  29         * remote.c (compare_pnums): Remove.
  30         (map_regcache_remote_table): Call std::sort instead of qsort.
  31         * utils.c (compare_positive_ints): Remove.
  32         * utils.h (compare_positive_ints): Remove.
  33         * xcoffread.c (compare_lte): Remove.
  34         (arrange_linetable): Call std::sort instead of qsort.
  35
  36 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
  37
  38         * symfile.c (init_entry_point_info): Fix typo.
  39         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
  40
  41 2019-10-18  Tom de Vries  <tdevries@suse.de>
  42
  43         * aarch64-tdep.c: Fix typos in comments.
  44         * ada-lang.c: Same.
  45         * ada-tasks.c: Same.
  46         * alpha-tdep.c: Same.
  47         * alpha-tdep.h: Same.
  48         * amd64-nat.c: Same.
  49         * amd64-windows-tdep.c: Same.
  50         * arc-tdep.c: Same.
  51         * arc-tdep.h: Same.
  52         * arch-utils.c: Same.
  53         * arm-nbsd-tdep.c: Same.
  54         * arm-tdep.c: Same.
  55         * ax-gdb.c: Same.
  56         * blockframe.c: Same.
  57         * btrace.c: Same.
  58         * c-varobj.c: Same.
  59         * coff-pe-read.c: Same.
  60         * coffread.c: Same.
  61         * cris-tdep.c: Same.
  62         * darwin-nat.c: Same.
  63         * dbxread.c: Same.
  64         * dcache.c: Same.
  65         * disasm.c: Same.
  66         * dtrace-probe.c: Same.
  67         * dwarf-index-write.c: Same.
  68         * dwarf2-frame-tailcall.c: Same.
  69         * dwarf2-frame.c: Same.
  70         * dwarf2read.c: Same.
  71         * eval.c: Same.
  72         * exceptions.c: Same.
  73         * fbsd-tdep.c: Same.
  74         * findvar.c: Same.
  75         * frame.c: Same.
  76         * frv-tdep.c: Same.
  77         * gnu-v3-abi.c: Same.
  78         * go32-nat.c: Same.
  79         * h8300-tdep.c: Same.
  80         * hppa-tdep.c: Same.
  81         * i386-linux-tdep.c: Same.
  82         * i386-tdep.c: Same.
  83         * ia64-libunwind-tdep.c: Same.
  84         * ia64-tdep.c: Same.
  85         * infcmd.c: Same.
  86         * infrun.c: Same.
  87         * linespec.c: Same.
  88         * linux-nat.c: Same.
  89         * linux-thread-db.c: Same.
  90         * machoread.c: Same.
  91         * mdebugread.c: Same.
  92         * mep-tdep.c: Same.
  93         * mn10300-tdep.c: Same.
  94         * namespace.c: Same.
  95         * objfiles.c: Same.
  96         * opencl-lang.c: Same.
  97         * or1k-tdep.c: Same.
  98         * osabi.c: Same.
  99         * ppc-linux-nat.c: Same.
 100         * ppc-linux-tdep.c: Same.
 101         * ppc-sysv-tdep.c: Same.
 102         * printcmd.c: Same.
 103         * procfs.c: Same.
 104         * record-btrace.c: Same.
 105         * record-full.c: Same.
 106         * remote-fileio.c: Same.
 107         * remote.c: Same.
 108         * rs6000-tdep.c: Same.
 109         * s12z-tdep.c: Same.
 110         * score-tdep.c: Same.
 111         * ser-base.c: Same.
 112         * ser-go32.c: Same.
 113         * skip.c: Same.
 114         * sol-thread.c: Same.
 115         * solib-svr4.c: Same.
 116         * solib.c: Same.
 117         * source.c: Same.
 118         * sparc-nat.c: Same.
 119         * sparc-sol2-tdep.c: Same.
 120         * sparc-tdep.c: Same.
 121         * sparc64-tdep.c: Same.
 122         * stabsread.c: Same.
 123         * stack.c: Same.
 124         * symfile.c: Same.
 125         * symtab.c: Same.
 126         * target-descriptions.c: Same.
 127         * target-float.c: Same.
 128         * thread.c: Same.
 129         * utils.c: Same.
 130         * valops.c: Same.
 131         * valprint.c: Same.
 132         * value.c: Same.
 133         * varobj.c: Same.
 134         * windows-nat.c: Same.
 135         * xcoffread.c: Same.
 136         * xstormy16-tdep.c: Same.
 137         * xtensa-tdep.c: Same.
 138
 139 2019-10-17  Tom Tromey  <tromey@adacore.com>
 140
 141         * configure: Rebuild.
 142         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 143         in AC_CONFIG_FILES invocation.
 144         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 145         new-style config.status invocation.
 146
 147 2019-10-17  Tom de Vries  <tdevries@suse.de>
 148
 149         * arm-nbsd-nat.c: Fix typos in comments.
 150         * arm-tdep.c: Same.
 151         * darwin-nat-info.c: Same.
 152         * dwarf2read.c: Same.
 153         * elfread.c: Same.
 154         * event-top.c: Same.
 155         * findvar.c: Same.
 156         * gdbtypes.c: Same.
 157         * hppa-tdep.c: Same.
 158         * i386-tdep.c: Same.
 159         * jit.c: Same.
 160         * main.c: Same.
 161         * mdebugread.c: Same.
 162         * moxie-tdep.c: Same.
 163         * nto-procfs.c: Same.
 164         * osabi.c: Same.
 165         * ppc-linux-tdep.c: Same.
 166         * remote.c: Same.
 167         * riscv-tdep.c: Same.
 168         * s390-tdep.c: Same.
 169         * sh-tdep.c: Same.
 170         * sparc-linux-tdep.c: Same.
 171         * sparc-nat.c: Same.
 172         * stack.c: Same.
 173         * target-descriptions.c: Same.
 174         * top.c: Same.
 175         * varobj.c: Same.
 176
 177 2019-10-16  Tom Tromey  <tom@tromey.com>
 178
 179         * objfiles.h (struct objfile) <original_name>: Now const.
 180
 181 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 182
 183         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 184         pass on to sigsetjmp's second argument.
 185         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 186
 187 2019-10-16  Keith Seitz  <keiths@redhat.com>
 188
 189         PR gdb/23567
 190         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 191         sections whose size is greater than the file size.
 192
 193 2019-10-16  Jim Wilson  <jimw@sifive.com>
 194
 195         * riscv-tdep.c (riscv_gcc_target_options): New.
 196         (riscv_gnu_triplet_regexp): New.
 197         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 198         set_gdbarch_gnu_triplet_regexp.
 199
 200 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 201
 202         * Makefile.in: Add xml-builtin.h.
 203         * features/feature_to_c.sh: Add an include for xml-builtin.h
 204         to ensure that the compiler checks that the types match.
 205         * xml-builtin.h: New file.
 206         * xml-support.c (fetch_xml_builtin): Add missing const.
 207         * xml-support.h: Remove declaration of xml_builtins.
 208
 209 2019-10-16  Tom de Vries  <tdevries@suse.de>
 210
 211         PR tdep/25096
 212         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 213         (amd64_classify_aggregate): ... here.
 214         (amd64_classify_aggregate_field): Handled fiels of nested structs
 215         recursively.
 216
 217 2019-10-16  Tom de Vries  <tdevries@suse.de>
 218
 219         PR tdep/24104
 220         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 221         that handles 'theclass'.
 222
 223 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 224
 225         * linespec.c (decode_digits_ordinary): Update comment.
 226         * make-target-delegates: No longer need to handle VEC case.
 227         * memrange.c (normalize_mem_ranges): Update comment.
 228         * namespace.c (add_using_directive): Update comment.
 229         * objc-lang.c (uniquify_strings): Update comment.
 230         * ppc-linux-nat.c (struct thread_points): Update comment.
 231         * probe.h (find_probes_in_objfile): Update comment.
 232         * target.h (enum flash_preserve_mode): Update comment.
 233         * varobj.c (varobj_restrict_range): Update comment.
 234         * varobj.h (varobj_list_children): Update comment.
 235
 236 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * Makefile.in: Remove references to vec.h and vec.c.
 239         * aarch64-tdep.c: No longer include vec.h.
 240         * ada-lang.c: Likewise.
 241         * ada-lang.h: Likewise.
 242         * arm-tdep.c: Likewise.
 243         * ax.h: Likewise.
 244         * breakpoint.h: Likewise.
 245         * charset.c: Likewise.
 246         * cp-support.h: Likewise.
 247         * dtrace-probe.c: Likewise.
 248         * dwarf2read.c: Likewise.
 249         * extension.h: Likewise.
 250         * gdb_bfd.c: Likewise.
 251         * gdbsupport/gdb_vecs.h: Likewise.
 252         * gdbsupport/vec.c: Remove.
 253         * gdbsupport/vec.h: Remove.
 254         * gdbthread.h: Likewise.
 255         * guile/scm-type.c: Likewise.
 256         * inline-frame.c: Likewise.
 257         * machoread.c: Likewise.
 258         * memattr.c: Likewise.
 259         * memrange.h: Likewise.
 260         * namespace.h: Likewise.
 261         * nat/linux-btrace.h: Likewise.
 262         * osdata.c: Likewise.
 263         * parser-defs.h: Likewise.
 264         * progspace.h: Likewise.
 265         * python/py-type.c: Likewise.
 266         * record-btrace.c: Likewise.
 267         * rust-exp.y: Likewise.
 268         * solib-target.c: Likewise.
 269         * stap-probe.c: Likewise.
 270         * target-descriptions.c: Likewise.
 271         * target-memory.c: Likewise.
 272         * target.h: Likewise.
 273         * varobj.c: Likewise.
 274         * varobj.h: Likewise.
 275         * xml-support.h: Likewise.
 276
 277 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 278
 279         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 280         Update for new std::vector based implementation.
 281         (process_psymtab_comp_unit_reader): Likewise.
 282         (scan_partial_symbols): Likewise.
 283         (recursively_compute_inclusions): Likewise.
 284         (compute_compunit_symtab_includes): Likewise.
 285         (process_imported_unit_die): Likewise.
 286         (queue_and_load_dwo_tu): Likewise.
 287         (follow_die_sig_1): Likewise.
 288         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 289         (typedef dwarf2_per_cu_ptr): Remove.
 290         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 291         function.
 292         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 293         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 294         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 295         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 296         std::vector.
 297
 298 2019-10-15  Tom Tromey  <tromey@adacore.com>
 299
 300         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 301         TID.
 302
 303 2019-10-15  Tom Tromey  <tromey@adacore.com>
 304
 305         * windows-nat.c (windows_nat_target::fetch_registers)
 306         (windows_nat_target::store_registers): Rename "pid" to "tid".
 307
 308 2019-10-15  Tom Tromey  <tromey@adacore.com>
 309
 310         * gdbarch.h, gdbarch.c: Rebuild.
 311         * gdbarch.sh (gcc_target_options): Change return type to
 312         std::string.
 313         * compile/compile.c (get_args): Update.
 314         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 315         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 316         std::string.
 317         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 318         std::string.
 319         * arch-utils.c (default_gcc_target_options): Return std::string.
 320         * arch-utils.h (default_gcc_target_options): Return std::string.
 321         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 322
 323 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 324
 325         * breakpoint.c (breakpoint_chain): Make static.
 326         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 327         of accessing breakpoint_chain.
 328
 329 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 330
 331         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 332         to a gdb::function_view and return value to bool.
 333         * breakpoint.h (iterate_over_breakpoints): Likewise.
 334         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 335         (pop_dummy_frame): Update.
 336         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 337         (gdbscm_breakpoints): Update.
 338         * python/py-breakpoint.c (build_bp_list): Update.
 339         (gdbpy_breakpoints): Update.
 340         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 341         Update.
 342         (bpfinishpy_handle_stop): Update.
 343         (bpfinishpy_handle_exit): Update.
 344         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 345         (svr4_update_solib_event_breakpoints): Update.
 346
 347 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 348
 349         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 350         when unwrapping single-field structs.
 351
 352 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 353
 354         * dwarf2read.c: Remove includes.
 355
 356 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 357
 358         * ui-out.c (ui_out::call_do_message): Silence
 359         -Wformat-nonliteral warning.
 360
 361 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 362
 363         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 364         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 365         include: readline/tilde.h.
 366
 367 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 368
 369         * remote.c (remote_target::get_trace_status): Remove declaration of
 370         trace_regblock_size.
 371
 372 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 373
 374         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 375         (show_user): Remove declaration of cmdlist.
 376         * cli/cli-cmds.h (max_user_call_depth): Declare.
 377         * cli/cli-script.c (execute_user_command): Remove declaration
 378         of max_user_call_depth.
 379
 380 2019-10-11  Jim Wilson  <jimw@sifive.com>
 381
 382         * gdbsupport/print-utils.h (pulongest): Fix comment.
 383         (plongest): Likewise.
 384         (phex): Add missing comment, mention leading zeros.
 385         (phex_nz): Add mention of no leading zeros to comment.
 386
 387         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 388         plongest instead of unsigned long long cast.
 389
 390 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 391
 392         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 393         for external_editor_command and gdbtk_test.
 394
 395 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 396
 397         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 398         * varobj.c (varobjdebug): Move comment to...
 399         * varobj.h (varobjdebug): ...here, and declare.
 400
 401 2019-10-09  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 404         erase_data_content.
 405
 406 2019-10-09  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 409         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 410         * tui/tui-command.c (tui_cmd_window::resize)
 411         (tui_refresh_cmd_win): Update.
 412         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 413         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 414         * tui/tui-data.c (~tui_gen_win_info): Remove.
 415         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 416         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 417         (tui_redisplay_readline, tui_mld_flush)
 418         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 419         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 420         (tui_data_window::erase_data_content)
 421         (tui_data_item_window::rerender)
 422         (tui_data_item_window::refresh_window): Update.
 423         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 424         (box_win, tui_gen_win_info::make_window)
 425         (tui_gen_win_info::make_visible): Update.
 426         (tui_delete_win): Remove.
 427         * tui/tui-winsource.c
 428         (tui_source_window_base::do_erase_source_content): Update.
 429         (tui_show_source_line, tui_source_window_base::update_tab_width)
 430         (tui_source_window_base::update_exec_info): Update.
 431         * tui/tui-data.h (struct curses_deleter): New.
 432         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 433         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 434
 435 2019-10-09  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 438
 439 2019-10-09  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 442         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 443
 444 2019-10-09  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 447         window height directly.
 448         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 449         declare.
 450         * tui/tui-layout.c (tui_default_win_height): Remove.
 451         (tui_default_win_viewport_height): Remove.
 452
 453 2019-10-09  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui.h: Remove comments.
 456
 457 2019-10-09  Tom de Vries  <tdevries@suse.de>
 458
 459         * python/lib/gdb/printer/bound_registers.py: Use
 460         '^builtin_type_bound128' as regexp argument for
 461         add_builtin_pretty_printer.
 462
 463 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 464
 465         * guile/guile.c (guile_extension_script_ops): Remove forward
 466         declaration and mark as static.
 467         (guile_script_ops): Likewise.
 468         (extension_language_guile): Move further down in the file so
 469         it can reference the definitions for guile_{extension_,}script_ops.
 470
 471 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 472
 473         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 474         except SORTL, DFLTCC, and KDSA.
 475
 476 2019-10-08  Tom Tromey  <tromey@adacore.com>
 477
 478         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 479         (struct safe_symbol_file_add_args): Remove.
 480
 481 2019-10-08  Tom Tromey  <tromey@adacore.com>
 482
 483         * windows-nat.c: Don't include buildsym-legacy.h.
 484
 485 2019-10-08  Tom Tromey  <tromey@adacore.com>
 486
 487         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 488
 489 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 490
 491         * gdbtypes.c (overload_debug): Move comment to header.
 492         * gdbtypes.h (overload_debug): Declare.
 493         * valops.c: Remove declaration of overload_debug, instead
 494         include gdbtypes.h.
 495
 496 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 497
 498         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 499         through _().
 500         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 501         move comment...
 502         * language.h (lang_frame_mismatch_warn): ... here. Also add
 503         declaration.
 504         * top.c (lang_frame_mismatch_warn): Remove declaration.
 505         (check_frame_language_change): Pass lang_frame_mismatch_warn
 506         through _().
 507
 508 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 509
 510         * c-lang.h (vtbl_ptr_name): Declare.
 511         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 512         it from the header.
 513         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 514
 515 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 516
 517         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 518         gdb_static_assert.
 519
 520 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 521
 522         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 523         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 524         * ctfread.c: New file.
 525         * ctfread.h: New file.
 526         * elfread.c: Include ctfread.h.
 527         (struct elfinfo text_p): New member ctfsect.
 528         (elf_locate_sections): Mark CTF section.
 529         (elf_symfile_read): Call elfctf_build_psymtabs.
 530         * Makefile.in (LIBCTF): Add.
 531         (CLIBS): Use it.
 532         (CDEPS): Likewise.
 533         (DIST): Add ctfread.c.
 534
 535 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 536
 537         * ctfread.c (struct nextfield): Renamed to ...
 538         (struct ctf_nextfield): ... this.
 539         (struct field_info): Renamed to ...
 540         (strut ctf_field_info): ... this.
 541         (attach_fields_to_type): Update for renamed structures.
 542         (ctf_add_member_cb): Likewise.
 543         (ctf_add_enum_member_cb): Likewise.
 544         (process_struct_members): Likewise.
 545         (process_enum_type): Likewise.
 546
 547 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 548
 549         * tracectf.h: Rename, was ctf.h.
 550         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 551         * tracefile.c: Likewise.
 552         * tracepoint.c: Remove unused include ctf.h.
 553         * mi/mi-main.c: Likewise.
 554         * Makefile.in Replace ctf.c with tracectf.c.
 555
 556 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 557
 558         * version.in: Change version number to "9.0.50.DATE-git".
 559
 560 2019-10-03  Tom Tromey  <tom@tromey.com>
 561
 562         PR rust/24976:
 563         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 564
 565 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 568         cp_search_name_hash.
 569         * NEWS: Add entry about nested function support.
 570
 571 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 572             Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 575         for nested static variables when searchin VAR_DOMAIN.
 576         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 577         global scope, update comment.
 578         (add_partial_subprogram): Call add_partial_subprogram recursively
 579         for nested subroutines when processinng Fortran.
 580         (load_partial_dies): Process the child entities of a subprogram
 581         when processing Fortran.
 582         (partial_die_parent_scope): Handle building scope
 583         for Fortran nested functions.
 584         (process_die): Record that nested functions have a scope.
 585         (new_symbol): Always record Fortran subprograms on the global
 586         symbol list.
 587         (determine_prefix): How to build the prefix for Fortran
 588         subprograms.
 589
 590 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 591
 592         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 593         have just sent the thread a SIGSTOP and are waiting for it to
 594         arrive.
 595
 596 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * btrace.c (btrace_add_pc): Remove whitespace before the template
 599         parameter in 'std::vector <...>'.
 600         (parse_xml_btrace_block): Likewise.
 601         (btrace_maint_decode_pt): Likewise.
 602         (btrace_maint_update_packets): Likewise.
 603         (btrace_maint_print_packets): Likewise.
 604         * btrace.h (struct btrace_maint_info): Likewise.
 605         * dwarf2read.c (struct type_unit_group): Likewise.
 606         (build_type_psymtabs_reader): Likewise.
 607         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 608         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 609         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 610
 611 2019-10-03  Tom de Vries  <tdevries@suse.de>
 612
 613         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 614         the first line of the help text for set/show style metadata.
 615
 616 2019-10-02  Tom Tromey  <tromey@adacore.com>
 617
 618         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 619         * gdbsupport/common-inferior.c: New file.
 620         * infcmd.c (startup_with_shell): Don't define.
 621         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 622         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 623         * inferior.h (startup_with_shell): Don't declare.
 624
 625 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 626
 627         * gdbsupport/gdb_assert.h: Include errors.h.
 628         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 629
 630 2019-10-02  Tom Tromey  <tromey@adacore.com>
 631
 632         * NEWS: Add $_ada_exception entry.
 633         * ada-lang.c (struct ada_catchpoint): Add constructor.
 634         <m_kind>: New member.
 635         (allocate_location_exception, re_set_exception): Remove
 636         "ex" parameter.
 637         (should_stop_exception): Compute $_ada_exception.
 638         (check_status_exception, print_it_exception)
 639         (print_one_exception, print_mention_exception): Remove
 640         "ex" parameter.
 641         (allocate_location_catch_exception, re_set_catch_exception)
 642         (check_status_exception, print_it_catch_exception)
 643         (print_one_catch_exception, print_mention_catch_exception)
 644         (print_recreate_catch_exception)
 645         (allocate_location_catch_exception_unhandled)
 646         (re_set_catch_exception_unhandled)
 647         (check_status_exception, print_it_catch_exception_unhandled)
 648         (print_one_catch_exception_unhandled)
 649         (print_mention_catch_exception_unhandled)
 650         (print_recreate_catch_exception_unhandled)
 651         (allocate_location_catch_assert, re_set_catch_assert)
 652         (check_status_assert, print_it_catch_assert)
 653         (print_one_catch_assert, print_mention_catch_assert)
 654         (print_recreate_catch_assert)
 655         (allocate_location_catch_handlers, re_set_catch_handlers)
 656         (check_status_handlers, print_it_catch_handlers)
 657         (print_one_catch_handlers, print_mention_catch_handlers)
 658         (print_recreate_catch_handlers): Remove.
 659         (create_ada_exception_catchpoint): Update.
 660         (initialize_ada_catchpoint_ops): Update.
 661
 662 2019-10-02  Tom Tromey  <tromey@adacore.com>
 663
 664         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 665         (create_excep_cond_exprs): Simplify exception string computation.
 666         (ada_exception_catchpoint_cond_string): Likewise.
 667
 668 2019-10-02  Tom Tromey  <tromey@adacore.com>
 669
 670         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 671         * ada-lang.c (lesseq_defined_than): Handle
 672         LOC_STATIC.
 673         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 674         parameter.
 675         (dwarf2_has_info): Likewise.
 676         (new_symbol): Set maybe_copied on symbol when
 677         appropriate.
 678         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 679         parameter.
 680         <can_copy>: New member.
 681         * elfread.c (record_minimal_symbol): Set maybe_copied
 682         on symbol when appropriate.
 683         (elf_symfile_read): Update call to dwarf2_has_info.
 684         * minsyms.c (lookup_minimal_symbol_linkage): New
 685         function.
 686         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 687         * symtab.c (get_symbol_address, get_msymbol_address):
 688         New functions.
 689         * symtab.h (get_symbol_address, get_msymbol_address):
 690         Declare.
 691         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 692         maybe_copied.
 693         (struct symbol, struct minimal_symbol) <maybe_copied>:
 694         New member.
 695
 696 2019-10-02  Tom Tromey  <tromey@adacore.com>
 697
 698         * source.c (struct current_source_location): New.
 699         (current_source_key): New global.
 700         (current_source_symtab, current_source_line)
 701         (current_source_pspace): Remove.
 702         (get_source_location): New function.
 703         (get_current_source_symtab_and_line)
 704         (set_default_source_symtab_and_line)
 705         (set_current_source_symtab_and_line)
 706         (clear_current_source_symtab_and_line, select_source_symtab)
 707         (info_source_command, print_source_lines_base)
 708         (info_line_command, search_command_helper, _initialize_source):
 709         Update.
 710
 711 2019-10-02  Tom Tromey  <tromey@adacore.com>
 712
 713         * source.c (select_source_symtab): Don't call
 714         decode_line_with_current_source.
 715
 716 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 717
 718         * symtab.c (lookup_global_symbol): Search global block.
 719
 720 2019-10-02  Tom Tromey  <tromey@adacore.com>
 721
 722         * coffread.c (process_coff_symbol): Update.
 723         * dwarf2read.c (var_decode_location, new_symbol): Update.
 724         * mdebugread.c (parse_symbol): Update.
 725         * objfiles.c (relocate_one_symbol): Update.
 726         * stabsread.c (define_symbol, fix_common_block)
 727         (scan_file_globals): Update.
 728         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 729         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 730         * xcoffread.c (process_xcoff_symbol): Update.
 731
 732 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 733
 734         * MAINTAINERS: Update my email address.
 735
 736 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 737
 738         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 739         std::vector.
 740         (build_type_psymtabs_reader): Update for std::vector.
 741         (build_type_psymtab_dependencies): Likewise.
 742         * dwarf2read.h: Remove use of DEF_VEC_P.
 743         (typedef sig_type_ptr): Delete.
 744
 745 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 746
 747         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 748         to std::vector.
 749         (btrace_maint_decode_pt): Likewise, and move allocation of the
 750         vector outside of the loop.
 751         (btrace_maint_update_packets): Update to handle change from VEC to
 752         std::vector.
 753         (btrace_maint_print_packets): Likewise.
 754         (maint_info_btrace_cmd): Likewise.
 755         * btrace.h: Remove use of DEF_VEC_O.
 756         (typedef btrace_pt_packet_s): Delete.
 757         (struct btrace_maint_info) <packets>: Change fromm VEC to
 758         std::vector.
 759         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 760
 761 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 762
 763         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 764         make accesses into the vector constant references.
 765         (btrace_add_pc): Update for std::vector.
 766         (btrace_stitch_bts): Likewise.
 767         (parse_xml_btrace_block): Likewise.
 768         (btrace_maint_update_packets): Likewise.
 769         (btrace_maint_print_packets): Likewise.
 770         (maint_info_btrace_cmd): Likewise.
 771         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 772         std::vector.
 773         (btrace_data::empty): Likewise.
 774         (btrace_data_append): Likewise.
 775         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 776         (typedef btrace_block_s): Delete.
 777         (struct btrace_block): Add constructor.
 778         (struct btrace_data_bts) <blocks>: Change to std::vector.
 779         * nat/linux-btrace.c (perf_event_read_bts): Update for
 780         std::vector.
 781         (linux_read_bts): Likewise.
 782
 783 2019-10-01  Tom Tromey  <tom@tromey.com>
 784
 785         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 786
 787 2019-10-01  Tom Tromey  <tom@tromey.com>
 788
 789         * stack.c (print_frame, info_frame_command_core): Use
 790         styled_string.
 791         * linux-thread-db.c (try_thread_db_load_1)
 792         (try_thread_db_load_from_pdir_1): Use styled_string.
 793         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 794         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 795         (maybe_print_unsupported_script_warning)
 796         (maybe_print_script_not_found_warning): Use styled_string.
 797         * ada-lang.c (user_select_syms): Use styled_string.
 798
 799 2019-10-01  Tom Tromey  <tom@tromey.com>
 800
 801         * p-lang.c (pascal_printstr): Use metadata style.
 802         * value.c (show_convenience): Use metadata style.
 803         * valprint.c (valprint_check_validity, val_print_optimized_out)
 804         (val_print_not_saved, val_print_unavailable)
 805         (val_print_invalid_address, generic_val_print, val_print)
 806         (value_check_printable, val_print_array_elements): Use metadata
 807         style.
 808         * ui-out.h (class ui_out) <field_fmt>: New overload.
 809         <do_field_fmt>: Add style parameter.
 810         * ui-out.c (ui_out::field_fmt): New overload.
 811         * typeprint.c (type_print_unknown_return_type)
 812         (val_print_not_allocated, val_print_not_associated): Use metadata
 813         style.
 814         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 815         parameter.
 816         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 817         * tracepoint.c (tvariables_info_1): Use metadata style.
 818         * stack.c (print_frame_arg, print_frame_info, print_frame)
 819         (info_frame_command_core): Use metadata style.
 820         * skip.c (info_skip_command): Use metadata style.
 821         * rust-lang.c (rust_print_enum): Use metadata style.
 822         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 823         metadata style.
 824         * python/py-framefilter.c (py_print_single_arg): Use metadata
 825         style.
 826         * printcmd.c (do_one_display, print_variable_and_value): Use
 827         metadata style.
 828         * p-valprint.c (pascal_val_print)
 829         (pascal_object_print_value_fields): Use metadata style.
 830         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 831         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 832         parameter.
 833         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 834         * m2-valprint.c (m2_print_long_set): Use metadata style.
 835         * m2-typeprint.c (m2_print_type): Use metadata style.
 836         * infcmd.c (print_return_value_1): Use metadata style.
 837         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 838         * f-valprint.c (info_common_command_for_block): Use metadata
 839         style.
 840         * f-typeprint.c (f_type_print_base): Use metadata style.
 841         * expprint.c (print_subexp_standard): Use metadata style.
 842         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 843         * cli/cli-style.h (class cli_style_option): Add constructor.
 844         (metadata_style): Declare.
 845         * cli/cli-style.c (metadata_style): New global.
 846         (_initialize_cli_style): Register metadata style.
 847         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 848         parameter.
 849         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 850         * c-typeprint.c (c_type_print_base_struct_union)
 851         (c_type_print_base_1): Use metadata style.
 852         * breakpoint.c (watchpoint_value_print)
 853         (print_one_breakpoint_location): Use metadata style.
 854         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 855         style.
 856         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 857         style.
 858         * ada-valprint.c (val_print_packed_array_elements, printstr)
 859         (print_field_values, ada_val_print_ref, ada_val_print): Use
 860         metadata style.
 861         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 862         style.
 863         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 864         style.
 865         * ada-lang.c (user_select_syms): Use metadata style.
 866
 867 2019-10-01  Tom Tromey  <tom@tromey.com>
 868
 869         * cli/cli-cmds.c (pwd_command): Style output.
 870
 871 2019-10-01  Pedro Alves  <palves@redhat.com>
 872             Tom Tromey  <tom@tromey.com>
 873
 874         * symtab.c (print_symbol_info): Use %ps.
 875         (print_msymbol_info): Use %ps.
 876         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 877         * printcmd.c (print_variable_and_value): Use %ps.
 878         * macrocmd.c (show_pp_source_pos): Use %ps.
 879         * infrun.c (print_exited_reason): Use ui_out::message.
 880         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 881         (describe_other_breakpoints): Use ui_out::message and new
 882         formats.
 883         (say_where): Use new formats.
 884         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 885         and new formats.
 886
 887 2019-10-01  Pedro Alves  <palves@redhat.com>
 888             Tom Tromey  <tom@tromey.com>
 889
 890         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 891         (test_gdb_formats): New function.
 892         (run_tests): Call it.
 893         (test_format_specifier): Update.
 894         * utils.h (fputs_filtered): Update comment.
 895         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 896         (fputs_styled_unfiltered): Declare.
 897         * utils.c (fputs_styled_unfiltered): New function.
 898         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 899         (vfprintf_filtered): Update.
 900         (vfprintf_unfiltered, vprintf_filtered): Update.
 901         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 902         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 903         disallow_ui_out_field>: New constants.
 904         (enum class field_kind): New.
 905         (struct base_field_s, struct signed_field_s): New.
 906         (signed_field): New function.
 907         (struct string_field_s): New.
 908         (string_field): New function.
 909         (struct styled_string_s): New.
 910         (styled_string): New function.
 911         (class ui_out) <message>: Add comment.
 912         <vmessage, call_do_message>: New methods.
 913         <do_message>: Add style parameter.
 914         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 915         methods.
 916         (ui_out::message): Rewrite.
 917         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 918         parameter.
 919         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 920         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 921         gdb_extensions parameter.
 922         (class format_piece): Add parameter to constructor.
 923         (n_int_args): New field.
 924         * gdbsupport/format.c (format_pieces::format_pieces): Add
 925         gdb_extensions parameter.  Handle '*'.
 926         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 927         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 928         vfprintf_styled_no_gdbfmt.
 929         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 930         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 931         unfiltered output.
 932         * ui-style.h (struct ui_file_style) <ptr>: New method.
 933
 934 2019-10-01  Tom Tromey  <tom@tromey.com>
 935
 936         * unittests/format_pieces-selftests.c: Update.  Add final format.
 937         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 938         empty literal pieces.
 939
 940 2019-10-01  Tom Tromey  <tom@tromey.com>
 941
 942         * ui-out.h (enum class ui_out_style_kind): Remove.
 943         (class ui_out) <field_string, field_stsream, do_field_string>:
 944         Change type of "style".
 945         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 946         (ui_out::field_string): Update.
 947         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 948         of "style".
 949         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 950         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 951         * stack.c (print_frame_arg, print_frame_info, print_frame):
 952         Update.
 953         * source.c (print_source_lines_base): Update.
 954         * solib.c (info_sharedlibrary_command): Update.
 955         * skip.c (info_skip_command): Update.
 956         * record-btrace.c (btrace_call_history_src_line)
 957         (btrace_call_history): Update.
 958         * python/py-framefilter.c (py_print_frame): Update.
 959         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 960         "style".
 961         * mi/mi-out.c (mi_ui_out::do_table_header)
 962         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 963         (mi_ui_out::do_field_string): Update.
 964         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 965         Update.
 966         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 967         "style".
 968         * cli-out.c (cli_ui_out::do_table_header)
 969         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 970         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 971         (cli_ui_out::do_field_fmt): Update.
 972         * breakpoint.c (print_breakpoint_location): Update.
 973         (update_static_tracepoint): Update.
 974
 975 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 976
 977         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 978         conversion of gdb_datadir.
 979         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 980         remove not needed c_str ().
 981
 982 2019-09-30  Ali Tamur <tamur@google.com>
 983
 984         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 985         (dwarf2_string_attr): Likewise.
 986
 987 2019-09-30  Ali Tamur <tamur@google.com>
 988
 989         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 990         (process_full_type_unit): Likewise.
 991         (dump_die_shallow): Likewise.
 992         (cu_debug_loc_section): Likewise.
 993
 994 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 995
 996         * minsyms.c (compare_minimal_symbols): Rename to...
 997         (minimal_symbol_is_less_than): ...this, and adjust to STL
 998         conventions (return bool, take arguments as references)
 999         (minimal_symbol_reader::install): Call std::sort instead
1000         of qsort.
1001
1002 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1003
1004         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1005         hash and why.
1006         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1007         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1008
1009 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1010
1011         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1012         * psympriv.h (add_psymbol_to_list): Move comment here and update
1013         it.
1014
1015 2019-09-29  Tom de Vries  <tdevries@suse.de>
1016
1017         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1018         Use $tmpdir/$(basename "$output_file").dwz instead of
1019         "${output_file}.dwz".
1020
1021 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1022
1023         PR gdb/25045
1024         * hppa-linux-nat.c: Include gdbarch.h.
1025
1026 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1027
1028         * blockframe.c (find_pc_partial_function): Change return type to bool.
1029         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1030         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1031         (stub_gnu_ifunc_resolve_name): Likewise.
1032         * symtab.c (compare_filenames_for_search): Likewise.
1033         (compare_glob_filenames_for_search): Likewise.
1034         (matching_obj_sections): Likewise.
1035         (symbol_matches_domain): Likewise.
1036         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1037         (find_line_pc): Change return type to bool.
1038         (find_line_pc_range): Likewise.
1039         (producer_is_realview): Likewise.
1040         * symtab.h (symbol_matches_domain): Likewise.
1041         (find_pc_partial_function): Likewise.
1042         (find_pc_line_pc_range): Likewise.
1043         (in_gnu_ifunc_stub): Likewise.
1044         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1045         (find_line_pc): Likewise.
1046         (find_line_pc_range): Likewise.
1047         (matching_obj_sections): Likewise.
1048         (find_line_symtab): Change out parameter to bool.
1049         (producer_is_realview): Change return type to bool.
1050         (compare_filenames_for_search): Likewise.
1051         (compare_glob_filenames_for_search): Likewise.
1052
1053 2019-09-26  Tom Tromey  <tom@tromey.com>
1054
1055         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1056         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1057         * gdb_usleep.h: Remove.
1058         * gdb_usleep.c: Remove.
1059         * utils.c: Don't include gdb_usleep.h.
1060
1061 2019-09-26  Tom Tromey  <tromey@adacore.com>
1062
1063         * python/py-type.c (type_to_type_object): Call check_typedef
1064         for stub types.
1065
1066 2019-09-26  Tom Tromey  <tom@tromey.com>
1067
1068         * utils.h (initialize_utils): Don't declare.
1069         * top.c (gdb_init): Don't call initialize_utils.
1070         * utils.c (initialize_utils): Remove.  Move contents...
1071         (_initialize_utils): ... here.
1072
1073 2019-09-25  Tom Tromey  <tom@tromey.com>
1074
1075         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1076         * utils.h (make_hex_string): Don't declare.
1077         * utils.c (make_hex_string): Remove.
1078
1079 2019-09-24  Tom de Vries  <tdevries@suse.de>
1080
1081         PR gdb/23815
1082         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1083         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1084
1085 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1086
1087         * NEWS: Mention new simulator port for PRU.
1088
1089 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1090
1091         * ada-exp.y (write_object_remaining): Update.
1092         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1093         and eliminate the static buffer.
1094         (ada_decode_symbol): Update.
1095         (ada_la_decode): Update.
1096         (ada_sniff_from_mangled_name): Update.
1097         (is_valid_name_for_wild_match): Update.
1098         (ada_lookup_name_info::matches): Update and simplify.
1099         (name_matches_regex): Update.
1100         (ada_add_global_exceptions): Update.
1101         * ada-lang.h (ada_decode): Update signature.
1102         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1103         * dwarf-index-write.c (debug_names::insert): Update.
1104
1105 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1106
1107         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1108         formatting.
1109
1110 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1111
1112         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1113         Change "nonzero" to "true" in documentation.
1114
1115 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1116
1117         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1118         (_initialize_darwin_solib): Don't set
1119         darwin_so_ops.lookup_lib_global_symbol.
1120         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1121         set_gdbarch_iterate_over_objfiles_in_search_order.
1122         (elf_lookup_lib_symbol): Rename to...
1123         (svr4_iterate_over_objfiles_in_search_order): this, and update
1124         to iterate semantics.
1125         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1126         * solib.c (solib_global_lookup): Remove.
1127         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1128         (solib_global_lookup): Remove.
1129         * symtab.c (lookup_global_or_static_symbol): Remove call to
1130         solib_global_lookup.
1131
1132 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1133
1134         * NEWS: Move entries about default MI version now being
1135         version 3, and about the GDB/MI fix for multi-location
1136         breakpoints to the "since GDB 8.3" section.
1137
1138 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1139
1140         GDB 8.3.1 released.
1141
1142 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1143
1144         * NEWS: Mention that Cell/B.E. debugging support was removed.
1145         * MAINTAINERS: Remove spu target.
1146
1147         * config/djgpp/fnchange.lst: Remove entries for removed files.
1148
1149         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1150         spu-multiarch.o, and spu-tdep.o.
1151         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1152         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1153         spu-multiarch.c, and spu-tdep.c.
1154         * spu-linux-nat.c: Remove file.
1155         * spu-multiarch.c: Remove file.
1156         * spu-tdep.c: Remove file.
1157         * spu-tdep.h: Remove file.
1158         * solib-spu.c: Remove file.
1159         * solib-spu.h: Remove file.
1160
1161         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1162         * configure.nat (spu-linux): Remove.
1163         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1164         solib-multiarch.o from gdb_target_obs.
1165         (spu*-*-*): Remove.
1166
1167         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1168         feature flag.
1169         (ppc_linux_no_features): Update.
1170         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1171         Cell/B.E. support.
1172         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1173         (tdesc_powerpc_cell64l): Likewise.
1174         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1175         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1176         Cell/B.E. support.
1177         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1178         Do not include "features/rs6000/powerpc-cell32l.c" or
1179         "features/rs6000/powerpc-cell64l.c".
1180         (ppc_linux_spu_section): Remove.
1181         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1182         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1183         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1184         (ppc_linux_spe_context_lookup): Remove.
1185         (ppc_linux_spe_context_inferior_created): Remove.
1186         (ppc_linux_spe_context_solib_loaded): Remove.
1187         (ppc_linux_spe_context_solib_unloaded): Remove.
1188         (ppc_linux_spe_context): Remove.
1189         (struct ppu2spu_cache): Remove.
1190         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1191         (struct ppu2spu_data): Remove.
1192         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1193         ppu2spu_unwind): Remove.
1194         (ppc_linux_init_abi): Remove Cell/B.E. support.
1195         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1196
1197         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1198         (rs6000/powerpc-cell64l-expedite): Likewise
1199         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1200         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1201         rs6000/powerpc-cell64l.xml.
1202         * features/rs6000/powerpc-cell32l.xml: Remove.
1203         * features/rs6000/powerpc-cell64l.xml: Likewise.
1204         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1205         * features/rs6000/powerpc-cell64l.c: Likewise.
1206         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1207         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1208         * regformats/reg-spu.dat: Remove.
1209
1210         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1211         * corelow.c (struct spuid_list): Remove.
1212         (add_to_spuid_list): Remove.
1213         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1214         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1215         (remote_protocol_features): Remove associated entries.
1216         (_initialize_remote): No longer initialize them.
1217         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1218         * linux-nat.c (SPUFS_MAGIC): Remove.
1219         (linux_proc_xfer_spu): Remove.
1220         (spu_enumerate_spu_ids): Remove.
1221         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1222         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1223         (linux_make_corefile_notes): No longer call it.
1224
1225         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1226         (cooked_write_test): Likewise.
1227
1228 2019-09-20  Tom Tromey  <tom@tromey.com>
1229
1230         * NEWS: Mention case-sensitivity of TUI commands.
1231         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1232         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1233         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1234
1235 2019-09-20  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-source.c (tui_source_window::set_contents): Use
1238         make_unique_xstrdup.
1239         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1240         make_unique_xstrdup.
1241
1242 2019-09-20  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-data.c: Remove separator comments.
1245         * tui/tui-layout.c: Remove separator comments.
1246         * tui/tui-win.c: Remove separator comments.
1247         * tui/tui-wingeneral.c: Remove separator comments.
1248
1249 2019-09-20  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui.h (strcat_to_buf): Don't declare.
1252         * tui/tui.c (strcat_to_buf): Remove.
1253
1254 2019-09-20  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1257         from "fullname".
1258         * tui/tui-source.c (tui_source_window::set_contents)
1259         (tui_source_window::location_matches_p)
1260         (tui_source_window::maybe_update): Update.
1261
1262 2019-09-20  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1265         Update.
1266         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1267         prefix.
1268         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1269         (tui_data_window::line_from_reg_element_no)
1270         (tui_data_window::first_reg_element_no_inline)
1271         (tui_data_window::show_registers)
1272         (tui_data_window::show_register_group)
1273         (tui_data_window::display_registers_from)
1274         (tui_data_window::display_registers_from_line)
1275         (tui_data_window::first_data_item_displayed)
1276         (tui_data_window::delete_data_content_windows)
1277         (tui_data_window::erase_data_content)
1278         (tui_data_window::do_scroll_vertical)
1279         (tui_data_window::refresh_window)
1280         (tui_data_window::check_register_values): Update.
1281
1282 2019-09-20  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1285         (struct tui_locator_window) <full_name, proc_name>: Now
1286         std::string.
1287         * tui/tui-stack.c (tui_locator_window::make_status_line)
1288         (tui_locator_window::set_locator_fullname)
1289         (tui_locator_window::set_locator_info): Update.
1290         * tui/tui-source.c (tui_source_window::set_contents)
1291         (tui_source_window::showing_source_p): Update.
1292
1293 2019-09-20  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1296         Don't call tui_locator_win_info_ptr.
1297
1298 2019-09-20  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1301
1302 2019-09-20  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1305         height for locator.
1306         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1307         * tui/tui-layout.c (show_source_disasm_command, show_data)
1308         (show_source_or_disasm_and_command): Use 1 as height for locator.
1309
1310 2019-09-20  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui.c (tui_enable): Update.
1313         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1314         Update.
1315         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1316         Update.
1317         * tui/tui-data.c (win_resized): Now bool.
1318         (tui_win_resized): Return bool.
1319         (tui_set_win_resized_to): Accept a bool.
1320
1321 2019-09-20  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1324         Change type of "refresh_values_only".
1325         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1326         type of "refresh_values_only".
1327
1328 2019-09-20  Tom Tromey  <tom@tromey.com>
1329
1330         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1331         std::string.
1332         (tui_disassemble): Add "pos" parameter.
1333         (tui_disasm_window::set_contents): Simplify.
1334
1335 2019-09-20  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-winsource.h (struct tui_source_window_base)
1338         <show_source_content>: Now private.
1339         * tui/tui-winsource.c
1340         (tui_source_window_base::show_source_content): Don't handle empty
1341         content case.
1342
1343 2019-09-20  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-layout.c (show_source_disasm_command)
1346         (show_source_or_disasm_and_command): Don't call
1347         show_source_content.
1348
1349 2019-09-20  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1352         Declare.
1353         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1354         from tui_make_status_line.
1355         (tui_locator_window::rerender): Update.
1356
1357 2019-09-20  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1360         (tui_locator_window::rerender): Update.
1361
1362 2019-09-20  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-winsource.h (struct tui_source_window_base)
1365         <~tui_source_window_base>: Don't declare.
1366         <fullname>: Remove.
1367         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1368         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1369         member.
1370         * tui/tui-source.c (tui_source_window::set_contents): Update.
1371         (tui_source_window::location_matches_p)
1372         (tui_source_window::maybe_update): Update.
1373
1374 2019-09-20  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-winsource.h (~tui_source_element): Remove.
1377         (tui_source_element): Update.
1378         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1379         * tui/tui-winsource.c (tui_show_source_line): Update.
1380         * tui/tui-source.c (tui_source_window::set_contents): Update.
1381         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1382
1383 2019-09-20  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1386         declare.
1387         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1388         tui_clear_source_windows_detail.
1389         * tui/tui-winsource.h (struct tui_source_window_base)
1390         <clear_detail>: Don't declare.
1391         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1392         Remove.
1393         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1394
1395 2019-09-20  Tom Tromey  <tromey@adacore.com>
1396
1397         PR ada/24919:
1398         * block.c (contained_in): Fix final return value.
1399
1400 2019-09-20  Alan Modra  <amodra@gmail.com>
1401
1402         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1403         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1404         (read_indirect_string_from_dwz): Use bfd accessor.
1405         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1406         * machoread.c (macho_symfile_read_all_oso): Likewise.
1407         * solib.c (solib_bfd_open): Likewise.
1408
1409 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1410
1411         * eval.c: Move declaration of overload_resolution to...
1412         * value.h: ...here.
1413
1414 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1415
1416         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1417         * arm-linux-tdep.c: Likewise.
1418         * arm-nbsd-nat.c: Likewise.
1419         * arm-tdep.h: Declare arm_apcs_32.
1420         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1421
1422 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1423
1424         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1425         * dwarf2read.h: Declare dwarf_always_disassemble.
1426
1427 2019-09-19  Tom de Vries  <tdevries@suse.de>
1428
1429         PR gdb/25009
1430         * source-cache.c (source_cache::ensure): Catch exception thrown during
1431         construction of the highlighter.
1432
1433 2019-09-18  Alan Modra  <amodra@gmail.com>
1434
1435         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1436         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1437         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1438         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1439         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1440         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1441         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1442         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1443         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1444         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1445         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1446         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1447         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1448         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1449         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1450         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1451         * mi/mi-interp.c: Update throughout for bfd section macro and
1452         function changes.
1453         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1454         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1455
1456 2019-09-18  Tom Tromey  <tom@tromey.com>
1457
1458         * NEWS: Add entry.
1459         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1460         call rl_initialize.
1461         (tui_enable): Do not call rl_initialize.
1462
1463 2019-09-18  Christian Groessler  <chris@groessler.org>
1464
1465         * alpha-linux-nat.c: Include gdbarch.h.
1466
1467 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1468
1469         * ui-file.c: Include cli/cli-style.h.
1470         (term_cli_styling): Remove cli_styling declaration.
1471
1472 2019-09-18  Alan Modra  <amodra@gmail.com>
1473
1474         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1475         to bfd_asymbol_section.
1476
1477 2019-09-18  Alan Modra  <amodra@gmail.com>
1478
1479         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1480         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1481         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1482
1483 2019-09-18  Alan Modra  <amodra@gmail.com>
1484
1485         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1486         * spu-linux-nat.c (spu_bfd_open): Likewise.
1487
1488 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1489
1490         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1491         to bool to match definition in dwarf2read.c.
1492
1493 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1494
1495         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1496         (print_signatures): Likewise.
1497         (trust_pad_over_xvs): Likewise.
1498         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1499         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1500         * arm-linux-nat.c (arm_apcs_32): Likewise.
1501         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1502         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1503         * arm-tdep.c (arm_debug): Likewise.
1504         (arm_apcs_32): Likewise.
1505         * auto-load.c (debug_auto_load): Likewise.
1506         (auto_load_gdb_scripts): Likewise.
1507         (global_auto_load): Likewise.
1508         (auto_load_local_gdbinit): Likewise.
1509         (auto_load_local_gdbinit_loaded): Likewise.
1510         * auto-load.h (global_auto_load): Likewise.
1511         (auto_load_local_gdbinit): Likewise.
1512         (auto_load_local_gdbinit_loaded): Likewise.
1513         * breakpoint.c (disconnected_dprintf): Likewise.
1514         (breakpoint_proceeded): Likewise.
1515         (automatic_hardware_breakpoints): Likewise.
1516         (always_inserted_mode): Likewise.
1517         (target_exact_watchpoints): Likewise.
1518         (_initialize_breakpoint): Update.
1519         * breakpoint.h (target_exact_watchpoints): Change to bool.
1520         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1521         * cli/cli-cmds.c (trace_commands): Likewise.
1522         * cli/cli-cmds.h (trace_commands): Likewise.
1523         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1524         to bool*.
1525         * cli/cli-logging.c (logging_overwrite): Change to bool.
1526         (logging_redirect): Likewise.
1527         (debug_redirect): Likewise.
1528         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1529         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1530         to bool.
1531         <boolean_option_def>: Update.
1532         (struct flag_option_def): Change default type of Context to bool
1533         from int.
1534         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1535         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1536         (get_setshow_command_value_string): Likewise.
1537         * cli/cli-style.c (cli_styling): Change to bool.
1538         (source_styling): Likewise.
1539         * cli/cli-style.h (source_styling): Likewise.
1540         (cli_styling): Likewise.
1541         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1542         to bool.
1543         * command.h (var_types): Update comment.
1544         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1545         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1546         bool.
1547         (debug_compile_cplus_scopes): Likewise.
1548         * compile/compile-internal.h (compile_debug): Likewise.
1549         * compile/compile.c (compile_debug): Likewise.
1550         (struct compile_options) <raw>: Likewise.
1551         * cp-support.c (catch_demangler_crashes): Likewise.
1552         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1553         (usr_cmd_cris_dwarf2_cfi): Likewise.
1554         * csky-tdep.c (csky_debug): Likewise.
1555         * darwin-nat.c (enable_mach_exceptions): Likewise.
1556         * dcache.c (dcache_enabled_p): Likewise.
1557         * defs.h (info_verbose): Likewise.
1558         * demangle.c (demangle): Likewise.
1559         (asm_demangle): Likewise.
1560         * dwarf-index-cache.c (debug_index_cache): Likewise.
1561         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1562         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1563         * dwarf2read.c (check_physname): Likewise.
1564         (use_deprecated_index_sections): Likewise.
1565         (dwarf_always_disassemble): Likewise.
1566         * eval.c (overload_resolution): Likewise.
1567         * event-top.c (set_editing_cmd_var): Likewise.
1568         (exec_done_display_p): Likewise.
1569         * event-top.h (set_editing_cmd_var): Likewise.
1570         (exec_done_display_p): Likewise.
1571         * exec.c (write_files): Likewise.
1572         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1573         (debug_fbsd_nat): Likewise.
1574         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1575         Likewise.
1576         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1577         <backtrace_past_entry> Likewise.
1578         * gdb-demangle.h (demangle): Likewise.
1579         (asm_demangle): Likewise.
1580         * gdb_bfd.c (bfd_sharing): Likewise.
1581         * gdbcore.h (write_files): Likewise.
1582         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1583         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1584         * gdbthread.h (print_thread_events): Likewise.
1585         * gdbtypes.c (opaque_type_resolution): Likewise.
1586         (strict_type_checking): Likewise.
1587         * gnu-nat.c (gnu_debug_flag): Likewise.
1588         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1589         * guile/scm-param.c (pascm_variable): Add boolval.
1590         (add_setshow_generic): Update.
1591         (pascm_param_value): Update.
1592         (pascm_set_param_value_x): Update.
1593         * hppa-tdep.c (hppa_debug): Change to bool..
1594         * infcall.c (may_call_functions_p): Likewise.
1595         (coerce_float_to_double_p): Likewise.
1596         (unwind_on_signal_p): Likewise.
1597         (unwind_on_terminating_exception_p): Likewise.
1598         * infcmd.c (startup_with_shell): Likewise.
1599         * inferior.c (print_inferior_events): Likewise.
1600         * inferior.h (startup_with_shell): Likewise.
1601         (print_inferior_events): Likewise.
1602         * infrun.c (step_stop_if_no_debug): Likewise.
1603         (detach_fork): Likewise.
1604         (debug_displaced): Likewise.
1605         (disable_randomization): Likewise.
1606         (non_stop): Likewise.
1607         (non_stop_1): Likewise.
1608         (observer_mode): Likewise.
1609         (observer_mode_1): Likewise.
1610         (set_observer_mode): Update.
1611         (sched_multi): Change to bool.
1612         * infrun.h (debug_displaced): Likewise.
1613         (sched_multi): Likewise.
1614         (step_stop_if_no_debug): Likewise.
1615         (non_stop): Likewise.
1616         (disable_randomization): Likewise.
1617         * linux-tdep.c (use_coredump_filter): Likewise.
1618         (dump_excluded_mappings): Likewise.
1619         * linux-thread-db.c (auto_load_thread_db): Likewise.
1620         (check_thread_db_on_load): Likewise.
1621         * main.c (captured_main_1): Update.
1622         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1623         xx2_opt, boolean_opt>: Change to bool.
1624         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1625         * maint.c (maintenance_profile_p): Likewise.
1626         (per_command_time): Likewise.
1627         (per_command_space): Likewise.
1628         (per_command_symtab): Likewise.
1629         * memattr.c (inaccessible_by_default): Likewise.
1630         * mi/mi-main.c (mi_async): Likewise.
1631         (mi_async_1): Likewise.
1632         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1633         * nat/fork-inferior.h (startup_with_shell): Likewise.
1634         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1635         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1636         * nios2-tdep.c (nios2_debug): Likewise.
1637         * or1k-tdep.c (or1k_debug): Likewise.
1638         * parse.c (parser_debug): Likewise.
1639         * parser-defs.h (parser_debug): Likewise.
1640         * printcmd.c (print_symbol_filename): Likewise.
1641         * proc-api.c (procfs_trace): Likewise.
1642         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1643         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1644         (set_parameter_value): Update.
1645         (add_setshow_generic): Update.
1646         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1647         to bool*.
1648         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1649         int*.
1650         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1651         * record-btrace.c (record_btrace_target::store_registers): Update.
1652         * record-full.c (record_full_memory_query): Change to bool.
1653         (record_full_stop_at_limit): Likewise.
1654         * record-full.h (record_full_memory_query): Likewise.
1655         * remote-notif.c (notif_debug): Likewise.
1656         * remote-notif.h (notif_debug): Likewise.
1657         * remote.c (use_range_stepping): Likewise.
1658         (interrupt_on_connect): Likewise.
1659         (remote_break): Likewise.
1660         * ser-tcp.c (tcp_auto_retry): Likewise.
1661         * ser-unix.c (serial_hwflow): Likewise.
1662         * skip.c (debug_skip): Likewise.
1663         * solib-aix.c (solib_aix_debug): Likewise.
1664         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1665         (spu_auto_flush_cache_p): Likewise.
1666         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1667         Likewise.
1668         (struct info_print_options) <quiet>: Likewise.
1669         * symfile-debug.c (debug_symfile): Likewise.
1670         * symfile.c (auto_solib_add): Likewise.
1671         (separate_debug_file_debug): Likewise.
1672         * symfile.h (auto_solib_add): Likewise.
1673         (separate_debug_file_debug): Likewise.
1674         * symtab.c (basenames_may_differ): Likewise.
1675         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1676         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1677         (struct info_types_options) <quiet>: Likewise.
1678         * symtab.h (demangle): Likewise.
1679         (basenames_may_differ): Likewise.
1680         * target-dcache.c (stack_cache_enabled_1): Likewise.
1681         (code_cache_enabled_1): Likewise.
1682         * target.c (trust_readonly): Likewise.
1683         (may_write_registers): Likewise.
1684         (may_write_memory): Likewise.
1685         (may_insert_breakpoints): Likewise.
1686         (may_insert_tracepoints): Likewise.
1687         (may_insert_fast_tracepoints): Likewise.
1688         (may_stop): Likewise.
1689         (auto_connect_native_target): Likewise.
1690         (target_stop_and_wait): Update.
1691         (target_async_permitted): Change to bool.
1692         (target_async_permitted_1): Likewise.
1693         (may_write_registers_1): Likewise.
1694         (may_write_memory_1): Likewise.
1695         (may_insert_breakpoints_1): Likewise.
1696         (may_insert_tracepoints_1): Likewise.
1697         (may_insert_fast_tracepoints_1): Likewise.
1698         (may_stop_1): Likewise.
1699         * target.h (target_async_permitted): Likewise.
1700         (may_write_registers): Likewise.
1701         (may_write_memory): Likewise.
1702         (may_insert_breakpoints): Likewise.
1703         (may_insert_tracepoints): Likewise.
1704         (may_insert_fast_tracepoints): Likewise.
1705         (may_stop): Likewise.
1706         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1707         (make_thread_apply_all_options_def_group): Change argument from int*
1708         to bool*.
1709         (thread_apply_all_command): Update.
1710         (print_thread_events): Change to bool.
1711         * top.c (confirm): Likewise.
1712         (command_editing_p): Likewise.
1713         (history_expansion_p): Likewise.
1714         (write_history_p): Likewise.
1715         (info_verbose): Likewise.
1716         * top.h (confirm): Likewise.
1717         (history_expansion_p): Likewise.
1718         * tracepoint.c (disconnected_tracing): Likewise.
1719         (circular_trace_buffer): Likewise.
1720         * typeprint.c (print_methods): Likewise.
1721         (print_typedefs): Likewise.
1722         * utils.c (debug_timestamp): Likewise.
1723         (sevenbit_strings): Likewise.
1724         (pagination_enabled): Likewise.
1725         * utils.h (sevenbit_strings): Likewise.
1726         (pagination_enabled): Likewise.
1727         * valops.c (overload_resolution): Likewise.
1728         * valprint.h (struct value_print_options) <prettyformat_arrays,
1729         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1730         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1731         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1732         Likewise.
1733         * windows-nat.c (new_console): Likewise.
1734         (cygwin_exceptions): Likewise.
1735         (new_group): Likewise.
1736         (debug_exec): Likewise.
1737         (debug_events): Likewise.
1738         (debug_memory): Likewise.
1739         (debug_exceptions): Likewise.
1740         (useshell): Likewise.
1741         * windows-tdep.c (maint_display_all_tib): Likewise.
1742         * xml-support.c (debug_xml): Likewise.
1743
1744 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1745
1746         * source.c (prepare_path_for_appending): New function.
1747         (openp): Make use of new function.
1748         (find_and_open_source): Search for the compilation directory and
1749         source file as a relative path beneath the directory search path.
1750
1751 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1752
1753         * source-cache.c (source_cache::get_line_charpos): Catch
1754         exceptions and return false, this matches the behaviour documented
1755         in the header file.
1756
1757 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1758
1759         * ada-tasks.c (info_task): Remove quoting of the task's name.
1760
1761 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1762
1763         * symfile.c (auto_solib_add): Replace comment with a reference
1764         to the header file.
1765
1766 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1767
1768         * NEWS: Mention that gdb can now be compiled with Python 3
1769         on Windows.
1770
1771 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1772
1773         * maint.c (maint_print_section_data::maint_print_section_data):
1774         Force use of 'float log10 (float)' by casting the argument to
1775         float.
1776
1777 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1778
1779         * maint.c: Add 'cmath' include.
1780         (struct maint_print_section_data): New structure.
1781         (print_section_index): New function.
1782         (print_bfd_section_info): Add header comment, small whitespace
1783         cleanup, and update to call new print_section_index function.
1784         (print_objfile_section_info): Likewise.
1785         (maint_obj_section_from_bfd_section): New function.
1786         (print_bfd_section_info_maybe_relocated): New function.
1787         (maintenance_info_sections): Add header comment, always use
1788         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1789
1790 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1791
1792         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1793         inner scope, add check that the objfile has psymtabs before
1794         checking psymtabs_addrmap.
1795         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1796
1797 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1798
1799         * NEWS: Announce that Ada task names are now shown at more places,
1800         and between quotes (except in info task output).
1801         * gdb/ada-tasks.c (task_to_str): New function.
1802         (display_current_task_id): Call task_to_str.
1803         (task_command_1): Likewise.
1804         (print_ada_task_info): In non-mi mode, Properly align headers and data
1805         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1806
1807 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1808
1809         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1810         prstatus.pr_lwp.pr_info instead of making it up.
1811
1812 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1813
1814         * auto-load.c (auto_load_expand_dir_vars): Update.
1815         * defs.h (gdb_datadir): Change to std::string.
1816         (python_libdir): Likewise.
1817         (relocate_gdb_directory): Change return type to std::string.
1818         * guile/guile.c (gdbscm_data_directory): Update.
1819         (initialize_scheme_side): Update.
1820         * jit.c (jit_reader_dir): Change to std::string.
1821         (jit_reader_load_command): Update.
1822         * main.c (gdb_datadir): Change to std::string.
1823         (python_libdir): Likewise.
1824         (set_gdb_data_directory): Update.
1825         (relocate_path): Change to return std::string.
1826         (relocate_gdb_directory): Change to return std::string.
1827         (relocate_gdbinit_path_maybe_in_datadir): Update.
1828         (captured_main_1): Update.
1829         * python/python.c (do_start_initialization): Update.
1830         * top.c (show_gdb_datadir): Update.
1831         * xml-syscall.c (xml_init_syscalls_info): Update.
1832         (init_syscalls_info): Update.
1833
1834 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1835
1836         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1837         out of get_init_files.
1838         (get_init_files): Update.
1839
1840 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1841
1842         * main.c (get_init_files): Change to use std::string.
1843         (captured_main_1): Update.
1844         (print_gdb_help): Update.
1845
1846 2019-09-11  Ali Tamur  <tamur@google.com>
1847
1848         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1849         implementation.
1850
1851 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1852
1853         * dbxread.c (read_dbx_symtab): Update.
1854         * dwarf2read.c (load_partial_dies): Update.
1855         * mdebugread.c (parse_partial_symbols): Update.
1856         (handle_psymbol_enumerators): Update.
1857         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1858         * psymtab.c (add_psymbol_to_bcache): Likewise.
1859         (add_psymbol_to_list): Likewise.
1860         * symtab.c (symbol_set_names): Likewise.
1861         * symtab.h (symbol_set_names): Likewise.
1862         * xcoffread.c (scan_xcoff_symtab): Update.
1863
1864 2019-09-11  Tom Tromey  <tom@tromey.com>
1865
1866         * symfile-mem.c (symbol_file_add_from_memory): Use
1867         bfd_set_filename.
1868         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1869         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1870
1871 2019-09-10  Tom Tromey  <tromey@adacore.com>
1872
1873         * dwarf-index-write.c (write_psymbols): Extend error message.
1874         (debug_names::insert): Add Ada code.
1875         (debug_names::write_psymbols): Remove Ada check.
1876         (debug_names) <m_string_obstack>: New member.
1877         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1878         (gdb_index_symbol_name_matcher::matches): Remove.
1879         (mapped_index_base::find_name_components_bounds): Add "lang"
1880         parameter.
1881         (mapped_index_base::build_name_components): Also split names
1882         according to Ada syntax.
1883         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1884         type of "match_callback".
1885         (check_match, check_find_bounds_finds)
1886         (dw2_expand_symtabs_matching): Update.
1887         (dw2_debug_names_iterator): Add new constructor.
1888         (dw2_debug_names_map_matching_symbols): New function.
1889         (dw2_debug_names_expand_symtabs_matching): Update.
1890         (dwarf2_debug_names_functions): Use
1891         dw2_debug_names_map_matching_symbols.
1892
1893 2019-09-10  Tom Tromey  <tromey@adacore.com>
1894
1895         * dwarf2read.c (dw2_get_file_names_reader): Add the
1896         CU's file name to the results.
1897
1898 2019-09-10  Tom Tromey  <tromey@adacore.com>
1899
1900         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1901         map_matching_symbols.  Update.
1902         * dwarf2read.c (dw2_map_matching_symbols): Update.
1903         * psymtab.c (match_partial_symbol): Change type; update.
1904         (psym_map_matching_symbols): Likewise.
1905         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1906         type; update.
1907         * symfile.h (struct quick_symbol_functions)
1908         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1909         Remove "match".
1910
1911 2019-09-10  Tom Tromey  <tromey@adacore.com>
1912
1913         * psymtab.c (map_block): Remove.
1914         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1915         * symtab.c (iterate_over_symbols_terminated): New function.
1916         * symtab.c (iterate_over_symbols_terminated): Declare.
1917
1918 2019-09-10  Tom Tromey  <tromey@adacore.com>
1919
1920         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1921         * language.h (struct language_defn) <la_iterate_over_symbols>:
1922         Return bool.
1923         * symtab.c (iterate_over_symbols): Return bool.
1924         * symtab.h (iterate_over_symbols): Return bool.
1925
1926 2019-09-10  Tom Tromey  <tromey@adacore.com>
1927
1928         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1929         (add_nonlocal_symbols): Update.
1930         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1931         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1932         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1933         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1934         Change type of "callback".  Remove "data".
1935
1936
1937 2019-09-09  Ali Tamur  <tamur@google.com>
1938
1939         * dwarf2read.c (comp_unit_head): Update comment.
1940         (dwarf2_dwo_name): New function declaration.
1941         (dwarf_unit_type_name): New function declaration.
1942         (read_comp_unit_head): Add support for new compilation units,
1943         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1944         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1945         (currently named as "signature") in their header. Also clarify error
1946         messages.
1947         (lookup_dwo_id): New function. Returns the dwo id of the given
1948         compile unit.
1949         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1950         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1951         functions.
1952         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1953         (dwarf2_dwo_name): Get the dwo name if present.
1954         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1955         purposes.
1956
1957 2019-09-09  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1960
1961 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1962
1963         * python/python.c (do_start_initialization): Make progname_copy static,
1964         to avoid a leak report.
1965
1966 2019-09-08  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1969
1970 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1971
1972         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1973         Change type to gdb::optional<block_enum>.
1974         (dw2_symtab_iter_init): Change block_index parameter type
1975         to gdb::optional<block_enum>.
1976         (dw2_lookup_symbol): Change block_index parameter
1977         type to block_enum.c
1978         (dw2_debug_names_lookup_symbol): Likewise.
1979         * psymtab.c (psym_lookup_symbol): Likewise.
1980         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1981         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1982         Likewise.
1983
1984 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1985
1986         * defs.h (relocate_gdb_directory): Change int to bool in
1987         signature and rename flag to relocatable.
1988         * main.c (relocate_path): Likewise.
1989         (relocate_gdb_directory): Likewise.
1990
1991 2019-09-06  Alan Modra  <amodra@gmail.com>
1992
1993         * coffread.c (coff_symfile_read): Constify filename variable.
1994         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1995         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1996         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1997         * solib.c (reload_shared_libraries_1): Likewise.
1998         * symfile.c (reread_symbols): Likewise.
1999         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2000         * solib-darwin.c (darwin_bfd_open): Likewise.
2001         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2002
2003 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2006         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2007
2008 2019-09-03  Tom Tromey  <tromey@adacore.com>
2009
2010         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2011         types.
2012         (has_negatives): Unbias a range type bound.
2013         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2014         * gdbtypes.c (operator==): Handle new field.
2015         (create_range_type): Add "bias" parameter.
2016         (create_static_range_type, resolve_dynamic_range): Update.
2017         * gdbtypes.h (struct range_bounds) <bias>: New member.
2018         (create_range_type): Add bias parameter.
2019         * printcmd.c (print_scalar_formatted): Unbias range types.
2020         * value.c (unpack_long): Unbias range types.
2021         (pack_long): Bias range types.
2022
2023 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2024
2025         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2026         probe arguments.
2027
2028 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2029
2030         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2031         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2032         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2033         (compile_probe_arg): Likewise.
2034         * probe.h (get_argument_count): Likewise.
2035         * solib-svr4.c (solib_event_probe_action): Likewise.
2036         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2037
2038 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2039
2040         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2041         code to here...
2042         (svr4_create_solib_event_breakpoints): ...from here.
2043
2044 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2045
2046         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2047         suffix from warning message.
2048
2049 2019-08-30  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-winsource.h (struct tui_source_window_base)
2052         <refresh_all>: Don't declare.
2053         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2054         Remove.
2055         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2056         tui_show_locator_content.
2057         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2058         declare.
2059         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2060         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2061         declare.
2062
2063 2019-08-30  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2066
2067 2019-08-30  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2070         Remove unnecessary forward declarations.
2071
2072 2019-08-30  Tom Tromey  <tom@tromey.com>
2073
2074         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2075         rerender.
2076         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2077         tui_show_locator_content.
2078
2079 2019-08-30  Tom Tromey  <tom@tromey.com>
2080
2081         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2082         (tui_locator_window::rerender): Rewrite using body of previous
2083         tui_show_locator_content.
2084
2085 2019-08-30  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2088         set_locator_fullname>: New methods.
2089         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2090         Rename from tui_set_locator_fullname.
2091         (tui_locator_window::set_locator_info): Rename from
2092         tui_set_locator_info.  Return bool.
2093         (tui_update_locator_fullname, tui_show_frame_info): Update.
2094
2095 2019-08-30  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2098
2099 2019-08-30  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2102         call touchwin.
2103
2104 2019-08-30  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-wingeneral.c (box_win): Assume win_info and
2107         win_info->handle cannot be NULL.
2108
2109 2019-08-30  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2112         refresh_window>: Declare.
2113         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2114         resize.
2115         (tui_data_item_window::rerender): Rename from
2116         tui_display_register.
2117         (tui_data_item_window::refresh_window): New method.
2118         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2119         no-op.
2120
2121 2019-08-30  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2124         regs_column_count, current_group>: Move later.  Now private.
2125         <get_current_group>: New method.
2126         * tui/tui-regs.c (tui_reg_command): Update.
2127         * tui/tui-layout.c (tui_set_layout): Update.
2128
2129 2019-08-30  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2132         (tui_data_window::rerender): Don't call
2133         check_and_display_highlight_if_needed.
2134         (tui_data_window::refresh_all): Remove call to
2135         erase_data_content.
2136
2137 2019-08-30  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2140         (tui_data_window::display_registers_from)
2141         (tui_data_window::display_reg_element_at_line)
2142         (tui_data_window::display_registers_from_line): Remove checks of
2143         "empty".
2144
2145 2019-08-30  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2148         Don't declare.
2149         * tui/tui-regs.c (tui_data_window::show_registers): Call
2150         rerender.
2151         (tui_data_window::rerender): Rename from display_all_data.
2152         (tui_data_window::rerender): Remove old implementation.
2153
2154 2019-08-30  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2157         text.
2158         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2159
2160 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2161             Sergio Durigan Junior  <sergiodj@redhat.com>
2162
2163         PR win32/24284
2164         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2165
2166 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2169         when searching for types.
2170
2171 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2172
2173         * f-lang.c (f_language_defn): Use f_print_typedef.
2174         * f-lang.h (f_print_typedef): Declare.
2175         * f-typeprint.c (f_print_typedef): Define.
2176
2177 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2178
2179         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2180
2181 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2182
2183         * cli/cli-utils.c (info_print_options_defs): Delete.
2184         (make_info_print_options_def_group): Delete.
2185         (extract_info_print_options): Delete.
2186         (info_print_command_completer): Delete.
2187         (info_print_args_help): Add extra parameter, and optionally
2188         include text about -n flag.
2189         * cli/cli-utils.h (struct info_print_options): Delete.
2190         (extract_info_print_options): Delete declaration.
2191         (info_print_command_completer): Delete declaration.
2192         (info_print_args_help): Add extra parameter, extend header
2193         comment.
2194         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2195         search_symbols.
2196         * stack.c (struct info_print_options): New type.
2197         (info_print_options_defs): New file scoped variable.
2198         (make_info_print_options_def_group): New static function.
2199         (info_print_command_completer): New static function.
2200         (info_locals_command): Update to use new local functions.
2201         (info_args_command): Likewise.
2202         (_initialize_stack): Add extra parameter to calls to
2203         info_print_args_help.
2204         * symtab.c (search_symbols): Add extra parameter, use this to
2205         possibly excluse non-debug symbols.
2206         (symtab_symbol_info): Add extra parameter, which is passed on to
2207         search_symbols.
2208         (struct info_print_options): New type.
2209         (info_print_options_defs): New file scoped variable.
2210         (make_info_print_options_def_group): New static function.
2211         (info_print_command_completer): New static function.
2212         (info_variables_command): Update to use local functions, and pass
2213         extra parameter through to symtab_symbol_info.
2214         (info_functions_command): Likewise.
2215         (info_types_command): Pass additional argument through to
2216         symtab_symbol_info.
2217         (rbreak_command): Pass extra argument to search_symbols.
2218         (_initialize_symtab): Add extra arguments for calls to
2219         info_print_args_help, and update help text for 'info variables',
2220         'whereis', and 'info functions' commands.
2221         * symtab.h (search_symbols): Add extra argument to declaration.
2222         * NEWS: Mention new flags.
2223
2224 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2225
2226         * symtab.c (lookup_static_symbol): Call the new function (and move
2227         it down to be next to lookup_global_symbol).
2228         (struct global_sym_lookup_data): Add block_enum member and rename to...
2229         (struct global_or_static_sym_lookup_data): ...this.
2230         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2231         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2232         (lookup_symbol_global_or_static_iterator_cb): ...this.
2233         (lookup_global_or_static_symbol): New function.
2234         (lookup_global_symbol): Call new function.
2235
2236 2019-08-26  Tom de Vries  <tdevries@suse.de>
2237
2238         PR c++/24852
2239         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2240         when pc_probe.prob == NULL.
2241
2242 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2243
2244         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2245         variable symbol_linkage to symbol_linkage_.
2246
2247 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2248
2249         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2250         represent whether the symbol is static, dynamic, or we don't
2251         know.
2252
2253 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2254
2255         * gdb/rx-tdep.c (rx_register_names): New.
2256         (rx_register_name): Delete.
2257         (rx_psw_type): Delete.
2258         (rx_fpsw_type): Delete.
2259         (rx_register_type): Delete.
2260         (rx_gdbarch_init): Convert target-descriptions.
2261         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2262         * gdb/features/Makefile: Add rx.xml.
2263         * gdb/features/rx.xml: New.
2264         * gdb/features/rx.c: Generated.
2265         * gdb/NEWS: Mention target description support.
2266
2267 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2268
2269         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2270         *slot_ptr.
2271
2272 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2273
2274         * configure.ac: Don't check for 'dlfcn.h' (moved to
2275         gdbsupport/common.m4).
2276         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2277         'gdbsupport/'.
2278         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2279         * compile/compile-c-support.c: Include
2280         'gdbsupport/gdb-dlfcn.h'.
2281         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2282         * gdb-dlfcn.c: Move to...
2283         * gdbsupport/gdb-dlfcn.c: ... here.
2284         * gdb-dlfcn.h: Move to...
2285         * gdbsupport/gdb-dlfcn.h: ... here.
2286
2287 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2288
2289         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2290         the offset field signed.
2291
2292 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2293
2294         * python/lib/gdb/__init__.py (_execute_file): New function.
2295         * python/python.c (python_run_simple_file): Call gdb._execute_file
2296         on Windows.
2297
2298 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2299
2300         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2301         all uses as this was never set to anything but a zero value.
2302
2303 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2304
2305         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2306
2307 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2308
2309         * tui/tui-data.h (tui_gen_win_info): Add an =default
2310         move constructor, required by some GCC versions.
2311
2312 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2313
2314         * go32-nat.c (go32_sysinfo): Add hygon_p.
2315
2316 2019-08-20  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2319         line_from_reg_element_no, first_reg_element_no_inline,
2320         display_all_data, delete_data_content_windows,
2321         erase_data_content>: Now private.
2322
2323 2019-08-20  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2326         (tui_unhighlight_win, tui_highlight_win)
2327         (tui_win_info::make_window): Update.
2328         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2329
2330 2019-08-20  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2333         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2334         (MAX_PID_WIDTH): Move to tui-stack.c.
2335         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2336         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2337         (MAX_PID_WIDTH): Move from tui-data.h.
2338
2339 2019-08-20  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2342         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2343         (box_win): Update.
2344         (tui_gen_win_info::make_window): Rename from tui_make_window.
2345         (tui_win_info::make_window): New method.
2346         (tui_gen_win_info::make_visible): Update.
2347         * tui/tui-source.c (tui_source_window::set_contents): Update.
2348         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2349         (tui_data_window::display_registers_from): Update.
2350         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2351         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2352         Declare.
2353         <can_box>: Remove.
2354         <title>: Remove.
2355         (struct tui_win_info) <make_window>: Declare.
2356         <can_box>: Now virtual.
2357         <title>: New member.
2358         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2359         * tui/tui-command.c (tui_cmd_window::resize): Update.
2360
2361 2019-08-20  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2364         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2365         (tui_data_window::check_register_values): Update.
2366
2367 2019-08-20  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-regs.h (struct tui_data_window): Use
2370         DISABLE_COPY_AND_ASSIGN.
2371         <regs_content>: Change type, removing unique_ptr.
2372         <tui_data_window>: Add move constructor.
2373         * tui/tui-regs.c (tui_data_window::show_registers)
2374         (tui_data_window::show_register_group)
2375         (tui_data_window::display_registers_from)
2376         (tui_data_window::display_registers_from)
2377         (tui_data_window::first_data_item_displayed)
2378         (tui_data_window::delete_data_content_windows)
2379         (tui_data_window::rerender, tui_data_window::refresh_window)
2380         (tui_data_window::check_register_values): Update.
2381
2382 2019-08-20  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2385         show_register_group>: Declare.
2386         (tui_show_register_group): Don't declare.
2387         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2388         tui_show_registers.
2389         (tui_data_window::show_register_group): Rename from
2390         tui_show_register_group.
2391         (tui_data_window::check_register_values, tui_reg_command):
2392         Update.
2393         * tui/tui-layout.c (tui_set_layout): Update.
2394
2395 2019-08-20  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2398         Declare.
2399         (tui_check_register_values): Don't declare.
2400         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2401         from tui_check_register_values.
2402         * tui/tui-hooks.c (tui_register_changed): Update.
2403
2404 2019-08-20  Tom Tromey  <tom@tromey.com>
2405
2406         * tui/tui-regs.c (tui_reg_layout): Move later.
2407         (tui_show_registers): Don't enable TUI mode or change layout.
2408
2409 2019-08-20  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-regs.h (struct tui_data_item_window)
2412         <~tui_data_item_window>: Remove.
2413         <content>: Now a unique_xmalloc_ptr.
2414         * tui/tui-regs.c (tui_register_format): Return a
2415         unique_xmalloc_ptr.
2416         (tui_get_register): Update.
2417         (~tui_data_item_window): Remove.
2418         (tui_data_window::display_registers_from, tui_display_register):
2419         Update.
2420         * tui/tui-io.h (tui_expand_tabs): Update.
2421         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2422         Remove "col" parameter.
2423
2424 2019-08-20  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2427         field.
2428         * tui/tui-regs.c (~tui_data_item_window): Update.
2429
2430 2019-08-20  Tom Tromey  <tom@tromey.com>
2431
2432         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2433         earlier.
2434
2435 2019-08-20  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2438
2439 2019-08-20  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui-source.h (struct tui_source_window): Update.
2442         * tui/tui-regs.c (tui_show_registers): Update.
2443         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2444         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2445         (NO_REGS_STRING): Remove defines.
2446
2447 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2448
2449         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2450         unnecessary thread walk if remote doesn't support the packet.
2451
2452 2019-08-19  Tom Tromey  <tromey@adacore.com>
2453
2454         * python/py-value.c (value_has_field): Fix indentation.
2455
2456 2019-08-19  Tom Tromey  <tromey@adacore.com>
2457
2458         * printcmd.c (do_one_display, info_display_command): Update.
2459         * block.h (contained_in): Return bool.  Add allow_nested
2460         parameter.
2461         * block.c (contained_in): Return bool.  Add allow_nested
2462         parameter.
2463
2464 2019-08-19  Tom Tromey  <tom@tromey.com>
2465
2466         * configure: Rebuild.
2467         * configure.ac: Disallow the combination of -static-libstdc++ and
2468         source highlight.
2469         * source-cache.c (get_language_name): Handle rust.
2470         (source_cache::get_source_lines): Ignore highlighting exceptions.
2471
2472 2019-08-16  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2475         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2476         (struct tui_source_window_base) <make_visible, refresh_window,
2477         resize>: Remove methods.
2478         <execution_info>: Remove field.
2479         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2480         (tui_show_source_line, tui_source_window_base)
2481         (~tui_source_window_base): Update.
2482         (tui_source_window_base::resize)
2483         (tui_source_window_base::make_visible)
2484         (tui_source_window_base::refresh_window): Remove.
2485         (tui_source_window_base::update_exec_info): Update.
2486         * tui/tui-source.c (tui_source_window::set_contents): Update.
2487         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2488
2489 2019-08-16  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2492         deprecated_query_hook.
2493
2494 2019-08-16  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2497         (tui_update_source_windows_with_line): Update.
2498         * tui/tui-source.h (struct tui_source_window)
2499         <show_symtab_source>: Declare.
2500         (tui_show_symtab_source): Don't declare.
2501         * tui/tui-source.c (tui_show_symtab_source): Rename from
2502         tui_show_symtab_source.
2503
2504 2019-08-16  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-winsource.h (struct tui_source_window_base)
2507         <set_contents>: Declare.
2508         * tui/tui-winsource.c
2509         (tui_source_window_base::update_source_window_as_is): Update.
2510         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2511         Declare.
2512         (tui_set_source_content): Don't declare.
2513         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2514         tui_set_source_content.
2515         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2516         Declare.
2517         (tui_set_disassem_content): Don't declare.
2518         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2519         tui_set_disassem_content.
2520
2521 2019-08-16  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-winsource.h (struct tui_source_window_base)
2524         <update_breakpoint_info>: Declare.
2525         (tui_update_breakpoint_info): Don't declare.
2526         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2527         (tui_update_all_breakpoint_info): Update.
2528         (tui_source_window_base::update_breakpoint_info): Rename from
2529         tui_update_breakpoint_info.
2530         (tui_source_window_base::update_exec_info): Update.
2531
2532 2019-08-16  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-winsource.h (struct tui_source_window_base)
2535         <update_source_window>: Declare.
2536         (tui_update_source_window): Don't declare.
2537         * tui/tui-winsource.c
2538         (tui_source_window_base::update_source_window): Rename from
2539         tui_update_source_window.
2540         (tui_source_window_base::rerender): Update.
2541         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2542         * tui/tui-disasm.c (tui_show_disassem)
2543         (tui_show_disassem_and_update_source)
2544         (tui_disasm_window::maybe_update): Update.
2545
2546 2019-08-16  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-winsource.h (struct tui_source_window_base)
2549         <update_source_window_as_is>: Declare.
2550         (tui_update_source_window_as_is): Don't declare.
2551         * tui/tui-winsource.c (tui_update_source_window): Update
2552         (tui_source_window_base::update_source_window_as_is): Rename from
2553         tui_update_source_window_as_is.
2554         (tui_source_window_base::refill): Update.
2555         * tui/tui-source.c (tui_show_symtab_source): Update.
2556         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2557         Update.
2558
2559 2019-08-16  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-winsource.h (tui_update_source_window)
2562         (tui_update_source_window_as_is): Remove "noerror" parameter.
2563         * tui/tui-winsource.c (tui_update_source_window)
2564         (tui_update_source_window_as_is): Remove "noerror" parameter.
2565         (tui_update_source_windows_with_addr)
2566         (tui_update_source_windows_with_line)
2567         (tui_source_window_base::rerender)
2568         (tui_source_window_base::refill): Update.
2569         * tui/tui-source.h (tui_set_source_content)
2570         (tui_show_symtab_source): Remove "noerror" parameter.
2571         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2572         parameter.
2573         (tui_show_symtab_source): Likewise.
2574         (tui_source_window::maybe_update): Update.
2575         * tui/tui-disasm.c (tui_show_disassem)
2576         (tui_show_disassem_and_update_source)
2577         (tui_disasm_window::do_scroll_vertical)
2578         (tui_disasm_window::maybe_update): Update.
2579
2580 2019-08-16  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui.c (tui_is_window_visible): Update.
2583         * tui/tui-wingeneral.c (tui_make_window)
2584         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2585         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2586         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2587         (tui_set_win_height_command, parse_scrolling_args): Update.
2588         * tui/tui-source.c (tui_source_window::style_changed): Update.
2589         * tui/tui-regs.c (tui_show_registers)
2590         (tui_data_window::first_data_item_displayed)
2591         (tui_data_window::delete_data_content_windows)
2592         (tui_check_register_values, tui_reg_command): Update.
2593         * tui/tui-disasm.c (tui_show_disassem): Update.
2594         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2595         method.
2596         <is_visible>: Remove field.
2597         * tui/tui-data.c (tui_next_win, tui_prev_win)
2598         (tui_delete_invisible_windows): Update.
2599
2600 2019-08-16  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-winsource.h (struct tui_source_window_base)
2603         <m_has_locator>: Remove.
2604         * tui/tui-layout.c (show_source_disasm_command, show_data)
2605         (show_source_or_disasm_and_command): Update.
2606
2607 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2608
2609         * NEWS (Other MI changes): New subsection.
2610         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2611         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2612         * arch-utils.c (default_get_pc_address_flags): New function.
2613         * arch-utils.h (default_get_pc_address_flags): New declaration.
2614         * gdbarch.sh: Add get_pc_address_flags.
2615         * gdbarch.c: Regenerate.
2616         * gdbarch.h: Likewise.
2617         * stack.c (print_pc): New function.
2618         (print_frame_info) (print_frame): Call print_pc.
2619
2620 2019-08-16  Tom de Vries  <tdevries@suse.de>
2621
2622         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2623         print_objfile_section_info.
2624
2625 2019-08-15  Tom Tromey  <tom@tromey.com>
2626
2627         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2628         calling update_cmdwin_start_line.
2629         * tui/tui-winsource.h (struct tui_source_window_base)
2630         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2631         <rerender>: Declare.
2632         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2633         Call rerender.
2634         (tui_source_window_base::set_new_height): Remove.
2635         (tui_source_window_base::rerender): Rename from
2636         do_make_visible_with_new_height.
2637         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2638         resize method.
2639         (tui_win_info::make_invisible_and_set_new_height)
2640         (tui_win_info::make_visible_with_new_height): Remove.
2641         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2642         Declare.
2643         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2644         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2645         do_make_visible_with_new_height>: Don't declare.
2646         <rerender>: Declare.
2647         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2648         set_new_height.
2649         (tui_data_window::do_make_visible_with_new_height): Remove.
2650         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2651         call tui_show_locator_content.
2652         (tui_gen_win_info::resize): Call rerender.
2653         (show_source_or_disasm_and_command): Don't call
2654         tui_show_locator_content.
2655         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2656         method.
2657         (struct tui_win_info) <rerender>: Declare.
2658         <set_new_height, make_invisible_and_set_new_height,
2659         make_visible_with_new_height>: Don't declare.
2660         * tui/tui-data.c (tui_win_list::rerender): New method.
2661         * tui/tui-command.h (struct tui_cmd_window)
2662         <do_make_visible_with_new_height>: Don't declare.
2663         * tui/tui-command.c
2664         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2665
2666 2019-08-15  Tom Tromey  <tromey@adacore.com>
2667
2668         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2669         * ada-lang.c (ada_enum_name): Likewise.
2670
2671 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2672
2673         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2674         leading underscore.
2675         (GdbOutputErrorFile): Likewise.
2676         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2677         accordingly.
2678         (execute_unwinders): Rename to have a leading underscore.
2679         (auto_load_packages): Likewise.
2680         (global scope): Adjust call to auto_load_packages accordingly.
2681         (GdbSetPythonDirectory): Likewise.
2682         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2683         instead of execute_unwinders.
2684
2685 2019-08-15  Tom Tromey  <tom@tromey.com>
2686
2687         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2688         (show_data): Don't change window visibility.
2689         (tui_gen_win_info::resize): Remove special case for command
2690         window.  Use wresize, when available.
2691         (show_source_or_disasm_and_command): Don't change window
2692         visibility.
2693         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2694         <make_visible>: New method.
2695         * tui/tui-command.c (tui_cmd_window::resize): New method.
2696
2697 2019-08-15  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2700         (struct tui_source_windows): New.
2701         * tui/tui-winsource.c (tui_display_main): Update.
2702         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2703         (new_height_ok, parse_scrolling_args): Update.
2704         * tui/tui-layout.c (show_layout, show_data): Update.
2705         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2706         (tui_add_to_source_windows): Don't declare.
2707         * tui/tui-data.c (source_windows, tui_source_windows)
2708         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2709
2710 2019-08-15  Tom Tromey  <tom@tromey.com>
2711
2712         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2713         Rename from reset.
2714         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2715         * tui/tui-layout.c (show_source_disasm_command, show_data):
2716         Update.
2717         (tui_gen_win_info::resize): Rename.
2718         (show_source_or_disasm_and_command): Update.
2719         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2720         reset.
2721
2722 2019-08-15  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2725         * tui/tui-interp.c (tui_interp::init): Don't call
2726         tui_initialize_static_data.
2727         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2728
2729 2019-08-15  Tom Tromey  <tom@tromey.com>
2730
2731         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2732         examine tui_win_list.
2733
2734 2019-08-15  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2737         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2738         tui_clear_source_content.
2739         (tui_clear_source_content): Remove.
2740         (tui_source_window_base::do_erase_source_content): Hoist call to
2741         content.clear().
2742         * tui/tui-stack.c (tui_show_frame_info): Don't call
2743         tui_clear_source_content.
2744
2745 2019-08-15  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-winsource.h (struct tui_source_window_base)
2748         <do_erase_source_content>: New method.
2749         <erase_source_content>: New method.
2750         (tui_erase_source_content): Don't declare.
2751         * tui/tui-winsource.c (tui_clear_source_content): Update.
2752         (tui_source_window_base::do_erase_source_content): Rename from
2753         tui_erase_source_content.
2754         (tui_source_window_base::show_source_content): Update.
2755         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2756         * tui/tui-source.h (struct tui_source_window)
2757         <erase_source_content>: New method.
2758         * tui/tui-disasm.h (struct tui_disasm_window)
2759         <erase_source_content>: New method.
2760
2761 2019-08-15  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2764         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2765         constructor.
2766         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2767         * tui/tui-source.c (tui_set_source_content): Update.
2768         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2769
2770 2019-08-15  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2773         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2774         tui-source.c.
2775         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2776         Declare.
2777         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2778         method.
2779         (tui_source_window::maybe_update): Update.
2780
2781 2019-08-15  Tom Tromey  <tom@tromey.com>
2782
2783         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2784         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2785         tui-disasm.c.
2786         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2787         Declare.
2788         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2789         method.
2790         (tui_disasm_window::maybe_update): Update.
2791
2792 2019-08-15  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-winsource.h (struct tui_source_window_base)
2795         <maybe_update>: Declare.
2796         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2797         method.
2798         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2799         Declare.
2800         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2801         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2802         Declare.
2803         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2804
2805 2019-08-15  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2808
2809 2019-08-15  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-wingeneral.c: Include tui-stack.h.
2812         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2813         (struct tui_locator_window): Move from tui-data.h.
2814         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2815         (tui_initialize_static_data): Move from tui-data.c.
2816         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2817         (struct tui_locator_window): Move to tui-stack.c.
2818         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2819         (tui_initialize_static_data): Move to tui-stack.c.
2820
2821 2019-08-15  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-layout.c (show_source_disasm_command)
2824         (show_source_or_disasm_and_command): Use make_visible method, not
2825         tui_make_window.
2826         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2827         Remove.
2828
2829 2019-08-15  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-wingeneral.h (tui_make_window): Update.
2832         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2833         parameter.
2834         (tui_gen_win_info::make_visible): Update.
2835         * tui/tui-regs.c (tui_data_window::display_registers_from):
2836         Update.
2837         * tui/tui-layout.c (show_source_disasm_command)
2838         (show_source_or_disasm_and_command): Update.
2839         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2840         (enum tui_box): Remove.
2841         (struct tui_win_info) <can_box>: New method.
2842         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2843         method.
2844
2845 2019-08-15  Tom de Vries  <tdevries@suse.de>
2846
2847         * linux-nat-trad.c: Include gdbarch.h.
2848
2849 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2850
2851         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2852         register sizes.
2853
2854 2019-08-14  Tom Tromey  <tromey@adacore.com>
2855
2856         * darwin-nat.c: Include gdbarch.h.
2857         * darwin-nat-info.c: Include gdbarch.h.
2858
2859 2019-08-13  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2862         Remove.
2863         * tui/tui-data.c (tui_initialize_static_data): Update.
2864
2865 2019-08-13  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-winsource.h (struct tui_exec_info_window)
2868         <~tui_exec_info_window, maybe_allocate_content, get_content,
2869         m_content>: Remove.
2870         (struct tui_source_window_base) <set_exec_info_content,
2871         show_exec_info_content>: Don't declare.
2872         * tui/tui-winsource.c
2873         (tui_exec_info_window::maybe_allocate_content): Remove.
2874         (tui_source_window_base::update_exec_info): Rename from
2875         set_exec_info_content.
2876         (tui_source_window_base::show_exec_info_content)
2877         (tui_source_window_base::update_exec_info): Remove.
2878
2879 2019-08-13  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2882         declare.
2883         * tui/tui-winsource.c (tui_update_source_window_as_is)
2884         (tui_update_source_windows_with_addr, tui_erase_source_content):
2885         Update.
2886         (tui_clear_exec_info_content): Remove.
2887
2888 2019-08-13  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2891         declare.
2892         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2893         call tui_erase_exec_info_content.
2894         (tui_clear_exec_info_content): Rename from
2895         tui_erase_exec_info_content.
2896         (tui_clear_exec_info_content): Delete.
2897
2898 2019-08-13  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-winsource.h (struct tui_source_window_base)
2901         <show_exec_info_content>: Declare.
2902         (tui_show_exec_info_content): Don't declare.
2903         * tui/tui-winsource.c
2904         (tui_source_window_base::show_exec_info_content): Rename from
2905         tui_show_exec_info_content.
2906         (tui_source_window_base::update_exec_info): Update.
2907
2908 2019-08-13  Tom Tromey  <tom@tromey.com>
2909
2910         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2911         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2912         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2913         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2914         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2915         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2916         ... here.
2917
2918 2019-08-13  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-winsource.h (struct tui_source_window_base)
2921         <update_exec_info>: Declare.
2922         (tui_update_exec_info): Don't declare.
2923         * tui/tui-winsource.c (tui_update_source_window_as_is)
2924         (tui_source_window_base::refresh_all)
2925         (tui_update_all_breakpoint_info): Update.
2926         (tui_source_window_base::update_exec_info): Rename from
2927         tui_update_exec_info.
2928         * tui/tui-stack.c (tui_show_frame_info): Update.
2929
2930 2019-08-13  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-winsource.h (struct tui_source_window_base)
2933         <set_exec_info_content>: Declare.
2934         (tui_set_exec_info_content): Don't declare.
2935         * tui/tui-winsource.c
2936         (tui_source_window_base::set_exec_info_content): Rename from
2937         tui_set_exec_info_content.
2938         (tui_update_exec_info): Update.
2939
2940 2019-08-13  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-winsource.h (struct tui_source_window_base)
2943         <show_source_content>: Declare.
2944         (tui_show_source_content): Don't declare.
2945         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2946         (tui_source_window_base::show_source_content): Rename from
2947         tui_show_source_content.
2948         (tui_source_window_base::refresh_all): Update.
2949         * tui/tui-layout.c (show_source_disasm_command)
2950         (show_source_or_disasm_and_command): Update.
2951
2952 2019-08-13  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-winsource.c (tui_erase_source_content)
2955         (tui_show_source_content, tui_source_window_base::refresh_all):
2956         Update.
2957         * tui/tui-wingeneral.h
2958         (tui_check_and_display_highlight_if_needed): Don't declare.
2959         * tui/tui-wingeneral.c
2960         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2961         check_and_display_highlight_if_needed.
2962         * tui/tui-win.c (tui_rehighlight_all)
2963         (tui_win_info::make_visible_with_new_height): Update.
2964         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2965         (tui_data_window::erase_data_content)
2966         (tui_data_window::display_all_data): Update.
2967         * tui/tui-data.h (struct tui_win_info)
2968         <check_and_display_highlight_if_needed>: Declare.
2969
2970 2019-08-13  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-win.c (tui_resize_all): Call
2973         tui_delete_invisible_windows.
2974         * tui/tui-layout.c (show_layout): Call
2975         tui_delete_invisible_windows.
2976         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2977         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2978
2979 2019-08-13  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2982         tui_add_win_to_layout.
2983
2984 2019-08-13  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2987         * tui/tui-layout.c (tui_default_win_height): Now static.
2988
2989 2019-08-13  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2992         single switch.
2993         (show_source_disasm_command, show_source_or_disasm_and_command):
2994         Don't check current layout.
2995
2996 2019-08-13  Tom Tromey  <tom@tromey.com>
2997
2998         * tui/tui-wingeneral.c (make_all_visible): Remove.
2999         (tui_make_all_invisible): Simplify.
3000         * tui/tui-layout.c (tui_make_all_invisible): Move from
3001         tui-wingeneral.c; simplify.
3002         (show_layout): Hoist call to tui_make_all_invisible.
3003         (show_data): Don't call tui_make_all_invisible.
3004
3005 2019-08-13  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3008         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3009
3010 2019-08-13  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3013         tui-data.c.
3014         (show_source_disasm_command, show_data)
3015         (show_source_or_disasm_and_command): Don't use
3016         tui_set_current_layout_to.
3017         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3018         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3019         tui-layout.c.
3020         (tui_set_current_layout_to): Remove.
3021
3022 2019-08-13  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-layout.c (tui_set_layout): Update.
3025         * tui/tui-data.h (struct tui_layout_def): Remove.
3026         (tui_layout_def): Don't declare.
3027         * tui/tui-data.c (layout_def): Remove.
3028         (tui_layout_def): Remove.
3029
3030 2019-08-13  Tom Tromey  <tom@tromey.com>
3031
3032         * tui/tui-winsource.h (struct tui_source_window_base)
3033         <clear_detail>: No longer "override".
3034         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3035         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3036         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3037         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3038         Remove.
3039         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3040
3041 2019-08-13  Tom Tromey  <tromey@adacore.com>
3042
3043         * tracepoint.c: Don't include readline.h or history.h.
3044
3045 2019-08-12  Tom Tromey  <tom@tromey.com>
3046
3047         * configure: Rebuild.
3048         * configure.ac: Check for readline 7.
3049         * NEWS: Mention readline 7 requirement.
3050         * README: Update.
3051
3052 2019-08-12  Tom Tromey  <tom@tromey.com>
3053
3054         * mingw-hdep.c (gdb_select): Remove readline hack.
3055
3056 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3057
3058         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3059         when the function fails.
3060
3061 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3062
3063         * s390-tdep.c (s390_type_align): New function.
3064         (s390_gdbarch_init): Set it as type_align gdbarch method.
3065
3066 2019-08-09  Tom de Vries  <tdevries@suse.de>
3067
3068         PR gdb/24591
3069         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3070         pc_low with relocation offset.
3071
3072 2019-08-07  Tom Tromey  <tromey@adacore.com>
3073
3074         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3075         (print_frame_args): Update.
3076         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3077         Update.
3078         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3079         * frame.h (struct frame_arg): Add initializers.
3080         <error>: Now a unique_xmalloc_ptr.
3081
3082 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3083
3084         * NEWS: Expand the Pointer Authentication entry.
3085         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3086         (aarch64_frame_unmask_lr): ... to this.
3087         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3088         Call aarch64_frame_unmask_lr.
3089         * frame.c (struct frame_info): Add "masked" variable.
3090         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3091         (fprint_frame): Check for masked pc.
3092         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3093         declarations.
3094         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3095         * stack.c (print_frame): Check for masked pc.
3096
3097 2019-08-06  Tom Tromey  <tom@tromey.com>
3098
3099         * stabsread.c (patch_block_stabs, read_one_struct_field)
3100         (read_enum_type): Use obstack_strndup.
3101         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3102         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3103         * dwarf2read.c (guess_full_die_structure_name)
3104         (anonymous_struct_prefix): Use obstack_strndup.
3105         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3106         * c-exp.y (yylex): Use obstack_strndup.
3107         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3108         (write_var_or_type): Use obstack_strndup.
3109
3110 2019-08-06  Tom Tromey  <tom@tromey.com>
3111
3112         * symfile.c (reread_symbols): Use obstack_strdup.
3113         * stabsread.c (read_type): Use obstack_strdup.
3114         * gdb_obstack.h (obstack_strdup): New overload.
3115         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3116         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3117         (dwarf2_canonicalize_name): Use obstack_strdup.
3118         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3119         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3120         Use obstack_strdup.
3121
3122 2019-08-06  Tom Tromey  <tom@tromey.com>
3123
3124         * gdb_obstack.h (obstack_strdup): Define.
3125         * gdb_obstack.c (obstack_strdup): Don't define.
3126
3127 2019-08-06  Tom Tromey  <tom@tromey.com>
3128
3129         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3130         obstack_strdup.
3131         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3132         obstack_strdup.
3133         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3134         * stabsread.c (common_block_start): Use obstack_strdup.
3135         * objfiles.c (set_objfile_main_name, objfile): Use
3136         obstack_strdup.
3137         * namespace.c (add_using_directive): Use obstack_strdup.
3138         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3139         * jit.c (finalize_symtab): Use obstack_strdup.
3140         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3141         (guess_partial_die_structure_name, partial_die_info::fixup)
3142         (dwarf2_name): Use obstack_strdup.
3143         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3144         obstack_strdup.
3145         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3146         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3147         obstack_strdup.
3148         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3149
3150 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3151
3152         * unittests/help-doc-selftests.c: New file.
3153         * Makefile.in: Add the new file.
3154
3155 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3156
3157         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3158         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3159         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3160         the trailing '.' is not output, and the first character is uppercased.
3161         (print_help_for_command): Update call to print_doc_line.
3162         (print_doc_of_command): Likewise.
3163         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3164         * cli/cli-option.c (append_indented_doc): Do not append newline.
3165         (build_help_option): Append newline after first appended_indented_doc
3166         only if a second call is done.
3167         (build_help): Append 2 new lines before each option, except the first
3168         one.
3169         * compile/compile.c (_initialize_compile): Add new lines after
3170         %OPTIONS%, when not at the end of the help.
3171         Change help doc or code
3172         producing the help doc to respect the invariants.
3173         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3174         Also removed the new line after 'Options:', as all other commands
3175         do not put an empty line between 'Options:' and the first option.
3176         * printcmd.c (_initialize_printcmd): Likewise.
3177         * stack.c (_initialize_stack): Likewise.
3178         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3179         incorrectly telling COMMAND is optional.
3180         * ada-lang.c (_initialize_ada_language): Change help doc or code
3181         producing the help doc to respect the invariants.
3182         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3183         * breakpoint.c (_initialize_breakpoint): Likewise.
3184         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3185         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3186         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3187         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3188         _initialize_cli_style): Likewise.
3189         * corelow.c (core_target_info): Likewise.
3190         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3191         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3192         * filesystem.c (_initialize_filesystem): Likewise.
3193         * frame.c (_initialize_frame): Likewise.
3194         * gnu-nat.c (add_task_commands): Likewise.
3195         * infcall.c (_initialize_infcall): Likewise.
3196         * infcmd.c (_initialize_infcmd): Likewise.
3197         * interps.c (_initialize_interpreter): Likewise.
3198         * language.c (_initialize_language): Likewise.
3199         * linux-fork.c (_initialize_linux_fork): Likewise.
3200         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3201         * maint.c (_initialize_maint_cmds): Likewise.
3202         * memattr.c (_initialize_mem): Likewise.
3203         * printcmd.c (_initialize_printcmd): Likewise.
3204         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3205         _RegEx): Likewise.
3206         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3207         * record-btrace.c (_initialize_record_btrace): Likewise.
3208         * record-full.c (_initialize_record_full): Likewise.
3209         * record.c (_initialize_record): Likewise.
3210         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3211         * regcache.c (_initialize_regcache): Likewise.
3212         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3213         _initialize_remote): Likewise.
3214         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3215         * serial.c (_initialize_serial): Likewise.
3216         * skip.c (_initialize_step_skip): Likewise.
3217         * source.c (_initialize_source): Likewise.
3218         * stack.c (_initialize_stack): Likewise.
3219         * symfile.c (_initialize_symfile): Likewise.
3220         * symtab.c (_initialize_symtab): Likewise.
3221         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3222         * top.c (init_main): Likewise.
3223         * tracefile-tfile.c (tfile_target_info): Likewise.
3224         * tracepoint.c (_initialize_tracepoint): Likewise.
3225         * tui/tui-win.c (_initialize_tui_win): Likewise.
3226         * utils.c (add_internal_problem_command): Likewise.
3227         * valprint.c (value_print_option_defs): Likewise.
3228
3229 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3230
3231         PR build/24886
3232         * configure.ac: Drop enable-libmcheck support.
3233         * configure, config.in: Rebuild.
3234         * libmcheck.m4: Remove.
3235         * acinclude.m4: Don't include it.
3236         * Makefile.in: Don't distribute it.
3237         * top.c (print_gdb_configuration): Don't mention it.
3238
3239 2019-08-06  Tom Tromey  <tom@tromey.com>
3240
3241         * utils.c (set_output_style): Sometimes pass stream to
3242         emit_style_escape.
3243         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3244         * record-btrace.c (btrace_insn_history): Update.
3245         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3246         method.
3247         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3248         Update initializers.
3249         <m_uiout>: New field.
3250         <m_di>: Move lower.
3251         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3252         Remove "uiout" parameter.
3253         (dump_insns): Update.
3254         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3255         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3256
3257 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3258
3259         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3260         (error_in_psymtab_expansion): Likewise.
3261         (lookup_symbol_via_quick_fns): Likewise.
3262         (basic_lookup_transparent_type_quick): Likewise.
3263         (basic_lookup_transparent_type_1): Likewise.
3264
3265 2019-08-06  Tom Tromey  <tromey@adacore.com>
3266
3267         * source.c (last_source_error): Now bool.
3268         (print_source_lines_base): Make "noprint" bool.  Only open
3269         source file when last_source_visited changes.
3270
3271 2019-08-06  Tom Tromey  <tromey@adacore.com>
3272
3273         * annotate.c (annotate_source_line): Use g_source_cache.
3274         * source-cache.c (source_cache::get_plain_source_lines): Change
3275         parameters.  Populate m_offset_cache.
3276         (source_cache::ensure): New method.
3277         (source_cache::get_line_charpos): New method.
3278         (extract_lines): Move lower.  Change parameters.
3279         (source_cache::get_source_lines): Move lower.
3280         * source-cache.h (class source_cache): Update comment.
3281         <get_line_charpos>: New method.
3282         <get_source_lines>: Update comment.
3283         <clear>: Clear m_offset_cache.
3284         <get_plain_source_lines>: Change parameters.
3285         <ensure>: New method
3286         <m_offset_cache>: New member.
3287         * source.c (forget_cached_source_info_for_objfile): Update.
3288         (info_source_command): Use g_source_cache.
3289         (find_source_lines, open_source_file_with_line_charpos): Remove.
3290         (print_source_lines_base, search_command_helper): Use g_source_cache.
3291         * source.h (open_source_file_with_line_charpos): Don't declare.
3292         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3293         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3294         Use g_source_cache.
3295
3296 2019-08-06  Tom Tromey  <tromey@adacore.com>
3297
3298         * source-cache.c (source_cache::get_plain_source_lines):
3299         Remove "first_line" and "last_line" parameters.
3300         (source_cache::get_source_lines): Cache plain text.
3301         * source-cache.h (class source_cache)
3302         <get_plain_source_lines>: Update.
3303
3304 2019-08-06  Tom Tromey  <tromey@adacore.com>
3305
3306         * source-cache.c (extract_lines): No longer a method.
3307         Changed type of parameter.  Include final newline.
3308         (selftests::extract_lines_test): New function.
3309         (_initialize_source_cache): Likewise.
3310         * source-cache.h (class source_cache)
3311         <extract_lines>: Don't declare.
3312
3313 2019-08-06  Tom Tromey  <tromey@adacore.com>
3314
3315         * breakpoint.c (init_breakpoint_sal): Update.
3316         (breakpoint): Update.
3317         * breakpoint.h (struct breakpoint) <filter>: Now a
3318         unique_xmalloc_ptr.
3319
3320 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3321
3322         * NEWS: Mention dictionary access on blocks.
3323         * python/py-block.c (blpy_getitem): New function.
3324         (block_object_as_mapping): New struct.
3325         (block_object_type): Use new struct for tp_as_mapping field.
3326
3327 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3328
3329         * objfiles.h (objfile): Add a comment describing partial symbols.
3330
3331 2019-08-05  Tom Tromey  <tromey@adacore.com>
3332
3333         * compile/compile.c (_initialize_compile): Use _(), not N_().
3334         * thread.c (_initialize_thread): Use _(), not N_().
3335         * stack.c (_initialize_stack): Use _(), not N_().
3336         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3337
3338 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3339
3340         * dwarf2read.c (struct dw2_symtab_iterator):
3341         <want_specific_block>: Remove.
3342         <block_index>: Change type to gdb::optional.
3343         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3344         change type of BLOCK_INDEX parameter to gdb::optional.
3345         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3346         (dw2_lookup_symbol): Don't pass argument for
3347         WANT_SPECIFIC_BLOCK.
3348         (dw2_expand_symtabs_for_function): Don't pass argument for
3349         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3350         (class dw2_debug_names_iterator)
3351         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3352         parameter, change BLOCK_INDEX type to gdb::optional.
3353         <m_want_specific_block>: Remove.
3354         <m_block_index>: Change type to gdb::optional.
3355         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3356         gdb::optional.  Re-write in function of gdb::optional.
3357         (dw2_debug_names_lookup_symbol): Don't pass argument for
3358         WANT_SPECIFIC_BLOCK.
3359         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3360         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3361         BLOCK_INDEX.
3362
3363 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3364
3365         * NEWS: Mention changes to "info sources" command.
3366
3367 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3368
3369         * symtab.c (filename_partial_match_opts): New struct type.
3370         (struct output_source_filename_data): New members
3371         regexp, c_regexp, partial_match.
3372         (output_source_filename): Use new members to decide to print file.
3373         (info_sources_option_defs): New variable.
3374         (make_info_sources_options_def_group, print_info_sources_header,
3375         info_sources_command_completer):
3376         New functions.
3377         (info_sources_command): Read new optional arguments.
3378         (_initialize_symtab): Update info sources help.
3379
3380 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3381
3382         * ada-lang.c (exception_support_info_v0): Renamed from...
3383         (default_exception_support_info): ... this.  Create new
3384         definition for v1.
3385         (ada_has_this_exception_support): Look up catch_handlers_sym.
3386         (ada_exception_support_info_sniffer): Try v0 after default.
3387
3388 2019-08-01  Tom Tromey  <tromey@adacore.com>
3389
3390         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3391         gdbarch.h.
3392
3393 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3394
3395         * s12z-tdep.c: Fix include path for s12z-opc.h.
3396
3397 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3398
3399         * NEWS: Require GNU make 3.82.
3400
3401 2019-07-16  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3404         declare.
3405
3406 2019-07-30  Tom Tromey  <tromey@adacore.com>
3407
3408         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3409
3410 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3411
3412         * printcmd.c (print_address_symbolic): Print negative offsets.
3413         (build_address_symbolic): Force signed arithmetic when computing
3414         offset.
3415
3416 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3417
3418         PR/24474: Add a function to lookup static variables.
3419         * NEWS: Mention this new function.
3420         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3421         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3422         * python/python.c (python_GdbMethods): Add new function.
3423
3424 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3425
3426         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3427         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3428         (objfpy_lookup_static_symbol): New function.
3429         (objfile_object_methods): Add new functions.
3430
3431 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3432
3433         * NEWS: Mention 'set|show print frame-info'.  Mention new
3434         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3435         backtrace argument.  Mention that python frame filtering code
3436         is now consistent with what 'backtrace' command prints.
3437
3438 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3439
3440         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3441         comments.
3442         (print_frame_info_auto, print_frame_info_source_line,
3443         print_frame_info_location, print_frame_info_source_and_location,
3444         print_frame_info_location_and_address, print_frame_info_short_location):
3445         New declarations.
3446         (struct frame_print_options): New member print_frame_info.
3447         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3448         * stack.h (get_user_print_what_frame_info): New declaration.
3449         (frame_show_address): New declaration.
3450         * stack.c (print_frame_arguments_choices): New value 'presence'.
3451         (print_frame_info_auto, print_frame_info_source_line,
3452         print_frame_info_location, print_frame_info_source_and_location,
3453         print_frame_info_location_and_address, print_frame_info_short_location,
3454         print_frame_info_choices, print_frame_info_print_what): New definitions.
3455         (print_frame_args): Only print dots for args if print frame-arguments
3456         is 'presence'.
3457         (frame_print_option_defs): New element for "frame-info".
3458         (get_user_print_what_frame_info): New function.
3459         (frame_show_address): Make non static.  Move comment to stack.h.
3460         (print_frame_info_to_print_what): New function.
3461         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3462         to decide what to print.
3463         (backtrace_command_1): Handle the new print_frame_arguments_presence
3464         value.
3465         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3466         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3467         (py_print_frame): In non-mi mode, use LOCATION as default for
3468         print_what, similarly to frame information printed directly by
3469         backtrace command. Handle frame-info user option in non MI mode.
3470
3471 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3472
3473         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3474         Add case for debugging 32-bit target on 64-bit host.  Revise
3475         comment.
3476
3477 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3478
3479         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3480         instead of find_function_entry_range_from_pc.
3481
3482 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3483
3484         * stack.c (find_frame_funname): Remove code which preferred
3485         minsym over symtab sym in "certain pathological cases".
3486
3487         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3488         parameter.  Change type of "do_demangle" to bool.
3489         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3490         Pass suitable "prefer_sym_over_minsym" flag to
3491         build_address_symbolic().  Don't output "+" for negative offsets.
3492         * printcmd.c (print_address_symbolic): Update invocation of
3493         build_address_symbolic to include a "prefer_sym_over_minsym"
3494         flag.
3495         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3496         Restrict cases in which use of minimal symbol is preferred to that
3497         of a found symbol.  Update comments.
3498
3499         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3500         for entry pc when entry pc is out of range for that FDE.
3501
3502 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3503
3504         PR gdb/24839:
3505         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3506         type.
3507
3508 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3509
3510         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3511         this function's Python signature.
3512
3513
3514 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3515
3516         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3517         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3518         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3519         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3520         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3521
3522
3523 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3524
3525         * h8300-tdep.c (h8300_register_name_common): New.
3526         h8300_register_name): Use h8300_register_name_common.
3527         (h8300s_register_name): Likewise.
3528         (h8300sx_register_name): Likewise.
3529         (h8300h_register_nam): New.
3530         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3531
3532
3533 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3534
3535         * arm-tdep.c (arm_skip_cmse_entry): New function.
3536         (arm_is_sgstubs_section): New function.
3537         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3538
3539 2019-07-22  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3542         Don't self-assign.
3543
3544 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3547         type_print.
3548
3549 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3550
3551         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3552         so that GDB doesn't match any msymbols when searching in the
3553         TYPES_DOMAIN.
3554         (print_symbol_info): Print using typedef_print or type_print based
3555         on the type of the symbol.  Add updated FIXME comment moved from...
3556         (_initialize_symtab): ... move and update FIXME comment to above.
3557
3558 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3559
3560         * NEWS: Mention adding -q option to "info types".
3561         * symtab.c (struct info_types_options): New struct.
3562         (info_types_options_defs): New variable.
3563         (make_info_types_options_def_group): New function.
3564         (info_types_command): Use gdb::option framework to parse options.
3565         (info_types_command_completer): New function.
3566         (_initialize_symtab): Extend the help text on "info types" and
3567         register command completer.
3568
3569 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3570
3571         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3572         (lookup_symbol_in_objfile): Change int to block_enum and add a
3573         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3574
3575 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3576
3577         * MAINTAINERS (Write After Approval): Add self.
3578
3579 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3580
3581         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3582         instruction to the dummy code region.
3583
3584 2019-07-19  Tom Tromey  <tromey@adacore.com>
3585
3586         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3587         (ARGSUSED, PARAMS, __func__): Remove rules.
3588
3589 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3590
3591         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3592         * features/arm/arm-with-iwmmxt.c: Remove.
3593         * features/arm/arm-with-iwmmxt.xml: Remove.
3594         * features/arm/arm-with-m-fpa-layout.c: Remove.
3595         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3596         * features/arm/arm-with-m-vfp-d16.c: Remove.
3597         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3598         * features/arm/arm-with-m.c: Remove.
3599         * features/arm/arm-with-m.xml: Remove.
3600         * features/arm/arm-with-neon.c: Remove.
3601         * features/arm/arm-with-neon.xml: Remove.
3602         * features/arm/arm-with-vfpv2.c: Remove.
3603         * features/arm/arm-with-vfpv2.xml: Remove.
3604         * features/arm/arm-with-vfpv3.c: Remove.
3605         * features/arm/arm-with-vfpv3.xml: Remove.
3606
3607 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3608
3609         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3610
3611 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3612
3613         * arch/aarch32.c (aarch32_create_target_description): Create
3614         target descriptions using features.
3615         * arch/arm.c (arm_create_target_description)
3616         (arm_create_mprofile_target_description): Likewise.
3617         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3618
3619 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3620
3621         * Makefile.in: Add new files.
3622         * aarch32-tdep.c: New file.
3623         * aarch32-tdep.h: New file.
3624         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3625         Call aarch32_read_description.
3626         * arch/aarch32.c: New file.
3627         * arch/aarch32.h: New file.
3628         * arch/arm.c (arm_create_target_description)
3629         (arm_create_mprofile_target_description): New function.
3630         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3631         (arm_create_target_description)
3632         (arm_create_mprofile_target_description): New declaration.
3633         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3634         read_description functions.
3635         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3636         Likewise.
3637         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3638         * arm-tdep.c (tdesc_arm_list): New variable.
3639         (arm_register_g_packet_guesses): Call create description functions.
3640         (arm_read_description) (arm_read_mprofile_description): New
3641         function.
3642         * arm-tdep.h (arm_read_description)
3643         (arm_read_mprofile_description): Add declaration.
3644         * configure.tgt: Add new files.
3645
3646 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3647
3648         * top.c (new_ui_command): Open specified terminal just once.
3649
3650 2019-07-18  Tom Tromey  <tromey@adacore.com>
3651
3652         * symtab.c (main_name): Constify return type.
3653         * symfile.c (set_initial_language): Update.
3654         * symtab.h (main_name): Constify return type.
3655
3656 2019-07-17  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-winsource.c (tui_update_source_window)
3659         (tui_update_source_window_as_is)
3660         (tui_update_source_windows_with_line): Remove return.
3661         * tui/tui-disasm.c (tui_show_disassem)
3662         (tui_show_disassem_and_update_source): Remove return.
3663         * tui/tui.c (tui_reset): Remove return.
3664         * tui/tui-wingeneral.c
3665         (tui_check_and_display_highlight_if_needed): Remove return.
3666
3667 2019-07-17  Tom Tromey  <tom@tromey.com>
3668
3669         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3670
3671 2019-07-17  Tom Tromey  <tom@tromey.com>
3672
3673         * tui/tui-winsource.h (struct tui_exec_info_window)
3674         (struct tui_source_window_base): Move from tui-data.h.
3675         * tui/tui-winsource.c: Move many method definitions from
3676         elsewhere.  Remove "structuring" comments.
3677         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3678         (tui_source_window_base::refresh_window): Move to
3679         tui-winsource.c.
3680         * tui/tui-win.c (tui_source_window_base::refresh_all)
3681         (tui_source_window_base::update_tab_width)
3682         (tui_source_window_base::set_new_height)
3683         (tui_source_window_base::do_make_visible_with_new_height): Move to
3684         tui-winsource.c.
3685         * tui/tui-source.h: Update.
3686         * tui/tui-source.c (tui_source_window_base::reset): Move to
3687         tui-winsource.c.
3688         * tui/tui-disasm.h: Update.
3689         * tui/tui-data.h (struct tui_exec_info_window): Move to
3690         tui-winsource.h.
3691         (struct tui_source_window_base): Likewise.
3692         * tui/tui-data.c (tui_source_window_base::clear_detail)
3693         (tui_source_window_base, ~tui_source_window_base): Move to
3694         tui-winsource.c.
3695
3696 2019-07-17  Tom Tromey  <tom@tromey.com>
3697
3698         * tui/tui-win.c (tui_resize_all)
3699         (tui_source_window_base::update_tab_width)
3700         (tui_adjust_win_heights): Update.
3701         (tui_win_info::make_invisible_and_set_new_height): Rename from
3702         make_invisible_and_set_new_height.
3703         * tui/tui-data.h (struct tui_win_info)
3704         <make_invisible_and_set_new_height>: New method.
3705
3706 2019-07-17  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui.c: Update.
3709         * tui/tui-source.h (struct tui_source_window): Move from
3710         tui-data.h.
3711         * tui/tui-layout.c: Update.
3712         * tui/tui-disasm.c: Update.
3713         * tui/tui-data.h (struct tui_source_window): Move to
3714         tui-source.h.
3715
3716 2019-07-17  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3719         tui-data.h.
3720         * tui/tui-data.h (struct tui_disasm_window): Move to
3721         tui-disasm.h.
3722
3723 2019-07-17  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui-regs.h (struct tui_data_item_window): Move from
3726         tui-data.h.
3727         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3728         * tui/tui-data.h (struct tui_data_item_window): Move to
3729         tui-regs.h.
3730         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3731
3732 2019-07-17  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui.c: Update.
3735         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3736         (tui_cmd_window::max_height): Move to tui-command.c.
3737         * tui/tui-layout.c: Update.
3738         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3739         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3740         tui-command.c.
3741         * tui/tui-command.h (struct tui_cmd_window): Move from
3742         tui-data.h.
3743         * tui/tui-command.c: Remove "structuring" comments.
3744         (tui_cmd_window::clear_detail)
3745         (tui_cmd_window::do_make_visible_with_new_height)
3746         (tui_cmd_window::max_height): Move from elsewhere.
3747
3748 2019-07-17  Tom Tromey  <tom@tromey.com>
3749
3750         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3751         Now static.
3752         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3753         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3754
3755 2019-07-17  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui.c: Update.
3758         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3759         tui-regs.c.
3760         * tui/tui-windata.h: Remove file.
3761         * tui/tui-windata.c: Remove file.
3762         * tui/tui-win.c (tui_data_window::set_new_height)
3763         (tui_data_window::do_make_visible_with_new_height): Move to
3764         tui-regs.c.
3765         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3766         * tui/tui-regs.c: Remove "structuring" comments.
3767         (tui_data_window::first_data_item_displayed)
3768         (tui_data_window::delete_data_content_windows)
3769         (tui_data_window::erase_data_content)
3770         (tui_data_window::display_all_data)
3771         (tui_data_window::refresh_all)
3772         (tui_data_window::do_scroll_vertical)
3773         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3774         (tui_data_window::do_make_visible_with_new_height)
3775         (tui_data_window::refresh_window): Move from elsewhere.
3776         (_initialize_tui_regs): Move to end of file.
3777         * tui/tui-layout.c: Update.
3778         * tui/tui-hooks.c: Update.
3779         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3780         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3781         tui-regs.c.
3782         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3783
3784 2019-07-17  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3787         seen.
3788
3789 2019-07-17  Tom Tromey  <tom@tromey.com>
3790
3791         * tui/tui-win.c (tui_source_window_base::set_new_height)
3792         (tui_source_window_base::do_make_visible_with_new_height): Use
3793         m_has_locator field directly.
3794         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3795         method.
3796         (struct tui_source_window_base) <has_locator>: Likewise.
3797
3798 2019-07-17  Tom Tromey  <tom@tromey.com>
3799
3800         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3801         Don't declare.
3802         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3803         Remove.
3804         * tui/tui-win.c (tui_source_window_base::set_new_height)
3805         (tui_source_window_base::set_new_height)
3806         (make_invisible_and_set_new_height)
3807         (tui_source_window_base::do_make_visible_with_new_height)
3808         (tui_source_window_base::do_make_visible_with_new_height):
3809         Update.
3810         * tui/tui-layout.c (show_source_disasm_command, show_data)
3811         (show_source_or_disasm_and_command): Update.
3812         * tui/tui-layout.c (show_layout): Update.
3813
3814 2019-07-17  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-layout.c (make_data_window): Remove.
3817         (show_data): Unify creation and re-initialization cases.
3818
3819 2019-07-17  Tom Tromey  <tom@tromey.com>
3820
3821         * tui/tui-layout.c (make_source_window, make_disasm_window):
3822         Remove.
3823         (show_data): Unify creation and re-initialization cases.
3824
3825 2019-07-17  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-layout.c (make_command_window): Remove.
3828         (show_source_disasm_command, show_source_or_disasm_and_command):
3829         Unify creation and re-initialization cases.
3830
3831 2019-07-17  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3834         creation and re-initialization cases.
3835
3836 2019-07-17  Tom Tromey  <tom@tromey.com>
3837
3838         * tui/tui-regs.c (tui_get_register): Return void.
3839
3840 2019-07-17  Tom Tromey  <tom@tromey.com>
3841
3842         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3843         Simplify.
3844
3845 2019-07-17  Tom Tromey  <tom@tromey.com>
3846
3847         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3848         resetting.
3849
3850 2019-07-17  Tom Tromey  <tom@tromey.com>
3851
3852         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3853         * tui/tui-regs.c (tui_reg_layout): New function.
3854         (tui_show_registers, tui_reg_command): Use it.
3855         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3856         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3857         parameters.
3858         (tui_layout_command): Remove.
3859
3860 2019-07-17  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-layout.h (tui/tui-layout): Return void.
3863         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3864
3865 2019-07-17  Tom Tromey  <tom@tromey.com>
3866
3867         * tui/tui-layout.c (show_source_disasm_command, show_data):
3868         Update.
3869         (reset_locator): Remove.
3870         (show_source_or_disasm_and_command): Update.
3871
3872 2019-07-17  Tom Tromey  <tom@tromey.com>
3873
3874         * tui/tui-source.c (tui_source_window_base::reset): Remove
3875         win_type parameter.
3876         * tui/tui-layout.c (make_command_window, make_source_window)
3877         (make_disasm_window, make_data_window)
3878         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3879         (reset_locator, show_source_or_disasm_and_command): Update.
3880         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3881         win_type parameter.
3882         (struct tui_source_window_base) <reset>: Likewise.
3883
3884 2019-07-17  Tom Tromey  <tom@tromey.com>
3885
3886         * tui/tui-layout.c (show_source_disasm_command): Use
3887         reset_locator.
3888         (reset_locator): New function.
3889         (init_and_make_win): Remove.
3890         (show_source_or_disasm_and_command): Use reset_locator.
3891
3892 2019-07-17  Tom Tromey  <tom@tromey.com>
3893
3894         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3895         condition.
3896         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3897         Remove condition.
3898         * tui/tui-source.c (tui_source_window_base::reset): New method.
3899         * tui/tui-layout.c (make_command_window): Don't call
3900         init_and_make_win.
3901         (make_source_window, make_disasm_window): Don't call
3902         make_source_or_disasm_window.
3903         (make_data_window): Don't call init_and_make_win.  Change calling
3904         convention.
3905         (show_source_disasm_command, show_data): Simplify.
3906         (make_source_or_disasm_window): Remove.
3907         (show_source_or_disasm_and_command): Simplify.
3908         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3909         (struct tui_source_window_base) <reset>: Likewise.
3910         <execution_info>: Remove initializer.
3911         * tui/tui-data.c (tui_source_window_base): Initialize
3912         execution_info.
3913
3914 2019-07-17  Tom Tromey  <tom@tromey.com>
3915
3916         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3917         variable.
3918
3919 2019-07-17  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui.c (tui_rl_other_window): Update.
3922         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3923         superclass method first.  Always iterate over regs_content.
3924         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3925         method.
3926         * tui/tui-win.c (tui_set_focus_command): Update.
3927
3928 2019-07-17  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-win.c (tui_set_focus_command): Rename from
3931         tui_set_focus.  Call tui_enable.
3932         (tui_set_focus_command): Remove.
3933
3934 2019-07-17  Tom Tromey  <tom@tromey.com>
3935
3936         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3937         refresh_window.
3938         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3939         touchwin.
3940         (tui_data_window::refresh_window): Call refresh_window on data
3941         items.  Always call superclass refresh_window.
3942         (tui_win_info::refresh): Remove.
3943         (tui_source_window_base::refresh_window): Update.
3944         (tui_refresh_all): Update.
3945         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3946         refresh_window.
3947         (show_source_or_disasm_and_command): Likewise.
3948         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3949         (struct tui_source_window_base) <refresh>: Likewise.
3950
3951 2019-07-17  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui-winsource.c (tui_clear_source_content)
3954         (tui_show_source_content): Update.
3955         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3956         whether content is empty.
3957         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3958         Remove.
3959
3960 2019-07-17  Tom Tromey  <tom@tromey.com>
3961
3962         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3963         window's contents.
3964         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3965         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3966
3967 2019-07-17  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3970         (struct tui_data_item_window): Update.
3971
3972 2019-07-17  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3975         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3976         defines.
3977
3978 2019-07-17  Tom Tromey  <tom@tromey.com>
3979
3980         * tui/tui-winsource.h (tui_erase_source_content)
3981         (tui_clear_source_content): Remove "display_prompt" parameter.
3982         * tui/tui-winsource.c (tui_update_source_window_as_is)
3983         (tui_update_source_windows_with_addr): Update.
3984         (tui_clear_source_content): Remove "display_prompt" parameter.
3985         (tui_erase_source_content): Likewise.  Simplify.
3986         (tui_show_source_content): Update.
3987         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3988         * tui/tui-stack.c (tui_show_frame_info): Update.
3989         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3990         Remove defines.
3991
3992 2019-07-17  Tom Tromey  <tom@tromey.com>
3993
3994         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3995         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3996         parameter.
3997         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3998         parameter.
3999
4000 2019-07-17  Tom Tromey  <tom@tromey.com>
4001
4002         * tui/tui-winsource.c (tui_clear_source_content)
4003         (tui_show_source_content, tui_show_exec_info_content)
4004         (tui_clear_exec_info_content): Update.
4005         * tui/tui-stack.c (tui_show_locator_content): Update.
4006         (tui_show_frame_info): Update.
4007         * tui/tui-source.h (tui_source_window): Don't declare.
4008         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4009         from tui_source_is_displayed.
4010         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4011         Remove field.
4012         (struct tui_source_window_base) <content_in_use>: New field.  Now
4013         bool.
4014         (struct tui_source_window) <showing_source_p>: New method.
4015         (TUI_SRC_WIN): Change cast.
4016         * tui/tui-data.c (tui_initialize_static_data): Update.
4017
4018 2019-07-17  Tom Tromey  <tom@tromey.com>
4019
4020         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4021         location_matches_p.
4022         * tui/tui-source.c (tui_source_window::location_matches_p): New
4023         method.
4024         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4025         method.
4026         * tui/tui-data.h (struct tui_source_window_base)
4027         <location_matches_p>: New method.
4028         (struct tui_source_window, struct tui_disasm_window)
4029         <location_matches_p>: Likewise.
4030
4031 2019-07-17  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui-win.c (tui_set_win_height_command): Rename from
4034         tui_set_win_height.
4035         (tui_set_win_height_command): Remove.
4036
4037 2019-07-17  Tom Tromey  <tom@tromey.com>
4038
4039         * tui/tui-source.c (tui_source_window): New constructor.  Add
4040         observer.
4041         (~tui_source_window): New destructor.
4042         (tui_source_window::style_changed): New method.
4043         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4044         (tui_attach_detach_observers): Update.
4045         * tui/tui-data.h (struct tui_source_window): Make constructor not
4046         inline.  Add destructor.
4047         (struct tui_source_window) <style_changed>: New method.
4048         <m_observable>: New member.
4049
4050 2019-07-17  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4053         * tui/tui-win.c (tui_resize_all): Fix typo.
4054
4055 2019-07-17  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4058         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4059         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4060         * tui/tui-win.c (window_name_completer): Use foreach.
4061         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4062         (update_tab_width): Likewise.
4063         * tui/tui-layout.c (show_layout): Update.
4064         * tui/tui-data.h (class tui_window_iterator): New.
4065         (struct all_tui_windows): New.
4066         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4067
4068 2019-07-17  Tom Tromey  <tom@tromey.com>
4069
4070         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4071         parameter.  Don't reference globals.
4072         (tui_reg_command): Update.
4073
4074 2019-07-17  Tom Tromey  <tom@tromey.com>
4075
4076         * tui/tui-regs.c (tui_show_registers): Simplify.
4077
4078 2019-07-17  Tom Tromey  <tom@tromey.com>
4079
4080         * tui/tui-regs.c (tui_show_registers): Update.
4081         (tui_show_register_group): Add win_info parameter.
4082
4083 2019-07-17  Tom Tromey  <tom@tromey.com>
4084
4085         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4086         Rename from tui_display_reg_element_at_line.
4087         (tui_data_window::display_registers_from_line): Update.
4088         * tui/tui-data.h (struct tui_data_window)
4089         <display_reg_element_at_line>: New method.
4090
4091 2019-07-17  Tom Tromey  <tom@tromey.com>
4092
4093         * tui/tui-regs.h (tui_display_registers_from)
4094         (tui_display_registers_from_line): Don't declare.
4095         * tui/tui-windata.c (tui_data_window::display_all_data)
4096         (tui_data_window::refresh_all)
4097         (tui_data_window::do_scroll_vertical): Update.
4098         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4099         from tui_display_registers_from.
4100         (tui_display_reg_element_at_line): Update.
4101         (tui_data_window::display_registers_from_line): Rename from
4102         tui_display_registers_from_line.
4103         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4104         display_registers_from_line>: New methods.
4105
4106 2019-07-17  Tom Tromey  <tom@tromey.com>
4107
4108         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4109         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4110         from tui_erase_data_content.
4111         (tui_data_window::display_all_data)
4112         (tui_data_window::refresh_all)
4113         (tui_data_window::do_scroll_vertical): Update.
4114         * tui/tui-regs.c (tui_show_registers): Update.
4115         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4116         New method.
4117
4118 2019-07-17  Tom Tromey  <tom@tromey.com>
4119
4120         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4121         declare.
4122         * tui/tui-windata.c
4123         (tui_data_window::delete_data_content_windows): Rename from
4124         tui_delete_data_content_windows.
4125         (tui_data_window::display_all_data)
4126         (tui_data_window::do_scroll_vertical): Update.
4127         * tui/tui-data.h (struct tui_data_window)
4128         <delete_data_content_windows>: New method.
4129
4130 2019-07-17  Tom Tromey  <tom@tromey.com>
4131
4132         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4133         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4134
4135 2019-07-17  Tom Tromey  <tom@tromey.com>
4136
4137         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4138         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4139         from tui_display_all_data.
4140         * tui/tui-win.c
4141         (tui_data_window::do_make_visible_with_new_height): Update.
4142         * tui/tui-regs.c (tui_show_registers): Update.
4143         * tui/tui-layout.c (tui_set_layout): Update.
4144         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4145         method.
4146
4147 2019-07-17  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4150         * tui/tui-windata.c (tui_display_data_from): Remove.
4151         (tui_data_window::refresh_all): Update.
4152
4153 2019-07-17  Tom Tromey  <tom@tromey.com>
4154
4155         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4156         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4157         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4158         tui_display_registers_from_line.
4159         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4160         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4161         "force_display" parameter.
4162
4163 2019-07-17  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4166         declare.
4167         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4168         Rename from tui_first_reg_element_no_inline.
4169         (tui_display_reg_element_at_line)
4170         (tui_display_registers_from_line): Update.
4171         * tui/tui-data.h (struct tui_data_window)
4172         <first_reg_element_no_inline>: New method.
4173
4174 2019-07-17  Tom Tromey  <tom@tromey.com>
4175
4176         * tui/tui-windata.c (tui_display_data_from)
4177         (tui_data_window::do_scroll_vertical): Update.
4178         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4179         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4180         Rename from tui_line_from_reg_element_no.
4181         (tui_display_registers_from_line): Update.
4182         * tui/tui-data.h (struct tui_data_window)
4183         <line_from_reg_element_no>: New method.
4184
4185 2019-07-17  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4188         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4189         tui_last_regs_line_no.
4190         (tui_display_reg_element_at_line)
4191         (tui_display_registers_from_line): Update.
4192         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4193         method.
4194
4195 2019-07-17  Tom Tromey  <tom@tromey.com>
4196
4197         PR tui/24722:
4198         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4199         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4200         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4201         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4202         (tui_update_breakpoint_info): Likewise.
4203         * tui/tui-hooks.c (tui_event_create_breakpoint)
4204         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4205         Update.
4206
4207 2019-07-17  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4210
4211 2019-07-17  Tom Tromey  <tom@tromey.com>
4212
4213         * tui/tui-winsource.c (tui_update_source_window_as_is)
4214         (tui_update_source_windows_with_addr): Update.
4215         * tui/tui-source.h (tui_set_source_content)
4216         (tui_show_symtab_source): Add "win_info" parameter.
4217         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4218         parameter.
4219         (tui_show_symtab_source): Likewise.
4220
4221 2019-07-17  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-wingeneral.c
4224         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4225
4226 2019-07-17  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4229         (struct tui_cmd_window) <can_scroll>: New method.
4230         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4231         method.
4232
4233 2019-07-17  Tom Tromey  <tromey@adacore.com>
4234
4235         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4236         do_field_signed>: Rename.  Change type of "value".
4237         * ui-out.c (ui_out::field_signed): Rename from field_int.
4238         Change type of "value".
4239         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4240         type of "value".
4241         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4242         do_field_int.  Change type of "value".
4243         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4244         do_field_int.  Change type of "value".
4245         * tracepoint.c (trace_status_mi, tfind_1)
4246         (print_one_static_tracepoint_marker): Update.
4247         * thread.c (print_thread_info_1, print_selected_thread_frame):
4248         Update.
4249         * stack.c (print_frame, print_frame_info): Update.
4250         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4251         Update.
4252         * source.c (print_source_lines_base): Update.
4253         * skip.c (info_skip_command): Update.
4254         * record-btrace.c (btrace_ui_out_decode_error)
4255         (btrace_call_history_src_line): Update.
4256         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4257         Update.
4258         * progspace.c (print_program_space): Update.
4259         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4260         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4261         do_field_int.  Change type of "value".
4262         * mi/mi-out.c (mi_ui_out::do_table_begin)
4263         (mi_ui_out::do_table_header): Update.
4264         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4265         type of "value".
4266         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4267         (mi_cmd_data_list_changed_registers, output_register)
4268         (mi_cmd_data_read_memory, mi_load_progress)
4269         (mi_cmd_trace_frame_collected): Update.
4270         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4271         Update.
4272         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4273         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4274         (mi_cmd_var_list_children, varobj_update_one): Update.
4275         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4276         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4277         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4278         * inferior.c (print_inferior): Update.
4279         * gdb_bfd.c (print_one_bfd): Update.
4280         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4281         Update.
4282         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4283         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4284         do_field_int.  Change type of "value".
4285         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4286         do_field_int.  Change type of "value".
4287         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4288         (print_one_breakpoint_location, print_it_catch_fork)
4289         (print_one_catch_fork, print_it_catch_vfork)
4290         (print_one_catch_vfork, print_it_catch_solib)
4291         (print_it_catch_exec, print_it_ranged_breakpoint)
4292         (print_mention_watchpoint, print_mention_masked_watchpoint)
4293         (bkpt_print_it, update_static_tracepoint): Update.
4294         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4295         * break-catch-syscall.c (print_it_catch_syscall): Update.
4296         * ada-tasks.c (print_ada_task_info): Update.
4297         * ada-lang.c (print_it_exception, print_mention_exception):
4298         Update.
4299
4300 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         PR breakpoints/24541
4303         * gdbarch.c: Regenerate.
4304         * gdbarch.h: Regenerate.
4305         * gdbarch.sh: Adjust return type and parameter types for
4306         'stap_adjust_register'.
4307         (i386_stap_adjust_register): Adjust signature and return new
4308         register name.
4309         * stap-probe.c (stap_parse_register_operand): Adjust use of
4310         'gdbarch_stap_adjust_register'.
4311
4312 2019-07-17  Tom Tromey  <tromey@adacore.com>
4313
4314         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4315         declare VEC.
4316         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4317         std::vector.
4318         (struct s390_process_info): Add initializers.
4319         (s390_add_process): Use new.
4320         (s390_linux_nat_target::low_forget_process): Use delete.
4321         (s390_linux_nat_target::low_new_fork)
4322         (s390_linux_nat_target::stopped_by_watchpoint)
4323         (s390_linux_nat_target::low_prepare_to_resume)
4324         (s390_linux_nat_target::insert_watchpoint)
4325         (s390_linux_nat_target::insert_hw_breakpoint)
4326         (s390_linux_nat_target::remove_watchpoint)
4327         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4328
4329 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4330
4331         * aarch64-fbsd-nat.c: Include regcache.h.
4332         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4333         argument.
4334         (aarch64_fbsd_nat_target::fetch_registers)
4335         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4336         variable.
4337         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4338
4339 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4340
4341         * fbsd-nat.c: Include gdbarch.h.
4342
4343 2019-07-15  Tom Tromey  <tromey@adacore.com>
4344
4345         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4346
4347 2019-07-15  Tom Tromey  <tromey@adacore.com>
4348
4349         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4350         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4351         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4352         * cli-out.c (cli_ui_out::do_field_int): New method.
4353         * ui-out.c (ui_out::field_unsigned): New method.
4354         * symfile.c (generic_load): Use field_unsigned.
4355         (print_transfer_performance): Likewise.
4356         * record-btrace.c (ui_out_field_uint): Remove.
4357         (btrace_call_history_insn_range, btrace_call_history): Use
4358         field_unsigned.
4359         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4360         field_unsigned.
4361         * ui-out.h (class ui_out) <field_unsigned>: New method.
4362         <do_field_unsigned>: Likewise.
4363
4364 2019-07-15  Tom Tromey  <tromey@adacore.com>
4365
4366         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4367         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4368         * target.c (flash_erase_command): Use field_string.
4369         * infrun.c (print_signal_received_reason): Use field_string.
4370         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4371         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4372         field_string.
4373         * ada-tasks.c (print_ada_task_info): Use field_string.
4374
4375 2019-07-15  Tom Tromey  <tromey@adacore.com>
4376
4377         * target.c (flash_erase_command): Use field_core_addr.
4378         * symfile.c (generic_load): Use field_core_addr.
4379         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4380         Use field_core_addr.
4381         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4382         field_core_addr.
4383
4384 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4385
4386         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4387         value if its desired type is smaller than a CORE_ADDR and signed.
4388
4389 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4390
4391         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4392         of changes to field names, and use new is_reference field to
4393         decide if a property is a reference or not.
4394         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4395         field.
4396         (struct dwarf2_property_baton): Update header comment, rename
4397         'referenced_type' to 'property_type' and update comments.
4398         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4399         default property type, store in property baton, update to take
4400         accound of renamed field.
4401         (read_func_scope): Update call to attr_to_dynamic_prop.
4402         (read_array_type): Likewise.
4403         (dwarf2_per_cu_addr_sized_int_type): New function.
4404         (read_subrange_index_type): Move type finding code to
4405         dwarf2_per_cu_addr_sized_int_type.
4406         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4407         (dwarf2_per_cu_addr_type): New function.
4408         (set_die_type): Update calls to attr_to_dynamic_prop.
4409
4410 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4411
4412         * dwarf2read.c (read_subrange_index_type): New function.
4413         (read_subrange_type): Move code into new function and call it.
4414         * gdbtypes.c (create_range_type): Add some asserts.
4415
4416 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4417
4418         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4419         update return statements.
4420         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4421         declaration, and update comment to match.
4422         * gdbtypes.c (resolve_dynamic_array): Update call to
4423         dwarf2_evaluate_property to match new return type.
4424
4425 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4426
4427         * valarith.c (value_subscripted_rvalue): Change lowerbound
4428         parameter type from int to LONGEST.
4429         * value.h (value_subscripted_rvalue): Likewise in declaration.
4430
4431 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4432
4433         * cli/cli-utils.c (info_print_command_completer): New function.
4434         * cli/cli-utils.h: Add 'completer.h' include, and forward
4435         declaration for 'struct cmd_list_element'.
4436         (info_print_command_completer): Declare.
4437         * stack.c (_initialize_stack): Add completer for 'info locals' and
4438         'info args'.
4439         * symtab.c (_initialize_symtab): Add completer for 'info
4440         variables' and 'info functions'.
4441         * NEWS: Mention completion for additional info commands.
4442
4443 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4444
4445         * cli/cli-utils.c (extract_info_print_args): Delete.
4446         (extract_arg_maybe_quoted): Delete.
4447         (info_print_options_defs): New variable.
4448         (make_info_print_options_def_group): New function.
4449         (extract_info_print_options): Define new function.
4450         * cli/cli-utils.h (extract_info_print_args): Delete.
4451         (struct info_print_options): New structure.
4452         (extract_info_print_options): Declare new function.
4453         * stack.c (info_locals_command): Update to use new
4454         extract_info_print_options, also add a header comment.
4455         (info_args_command): Likewise.
4456         * symtab.c (info_variables_command): Likewise.
4457         (info_functions_command): Likewise.
4458
4459 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4462         to extract string arguments.
4463         * common/common-utils.c (extract_string_maybe_quoted): New function.
4464         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4465
4466 2019-07-11  Tom Tromey  <tromey@adacore.com>
4467
4468         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4469         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4470         * top.h (gdbinit): Don't declare.
4471         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4472         into...
4473         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4474         * top.c (gdb_init): Don't call init_cli_cmds.
4475         (gdbinit): Remove.
4476         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4477
4478 2019-07-11  Tom Tromey  <tromey@adacore.com>
4479
4480         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4481         after it has been moved.
4482
4483 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4484
4485         * valops.c (value_must_coerce_to_target): Change return type to
4486         bool.
4487         * value.h (value_must_coerce_to_target): Likewise.
4488
4489 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4490
4491         * breakpoint.c (is_hardware_watchpoint): Remove
4492         forward-declaration.
4493         (is_masked_watchpoint): Change return type to bool.
4494         (is_tracepoint): Likewise.
4495         (is_breakpoint): Likewise.
4496         (is_hardware_watchpoint): Likewise.
4497         (is_watchpoint): Likewise.
4498         (is_no_memory_software_watchpoint): Likewise.
4499         (is_catchpoint): Likewise.
4500         (breakpoint_1): Make FILTER parameter's return type bool.
4501         is_masked_watchpoint): Change return type to bool.
4502         (save_breakpoints): Make FILTER parameter's return type bool.
4503         * breakpoint.h (is_breakpoint): Change return type to bool.
4504         (is_watchpoint): Likewise.
4505         (is_catchpoint): Likewise.
4506         (is_tracepoint): Likewise.
4507
4508 2019-07-10  Tom Tromey  <tom@tromey.com>
4509
4510         * defs.h: Don't include gdbarch.h.
4511         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4512         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4513         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4514         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4515         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4516         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4517         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4518         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4519         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4520         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4521         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4522         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4523         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4524         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4525         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4526         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4527         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4528         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4529         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4530         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4531         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4532         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4533         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4534         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4535         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4536         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4537         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4538
4539 2019-07-10  Tom Tromey  <tromey@adacore.com>
4540
4541         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4542         * breakpoint.c (init_ada_exception_breakpoint): Register as
4543         bp_catchpoint.
4544         (print_one_breakpoint_location, print_one_breakpoint): Use
4545         is_ada_exception_catchpoint.
4546         * ada-lang.c (class ada_catchpoint_location): Pass
4547         bp_loc_software_breakpoint to bp_location constructor.
4548         (is_ada_exception_catchpoint): New function.
4549
4550 2019-07-10  Tom Tromey  <tromey@adacore.com>
4551
4552         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4553         VEC.
4554         (struct arm_exidx_entry): New method operator<.
4555         (struct arm_exidx_data) <section_maps>: Change type.
4556         (arm_exidx_data_free): Remove.
4557         (arm_exidx_data_key): Change type.  Move lower.
4558         (arm_exidx_new_objfile): Update.
4559         (arm_compare_exidx_entries): Remove.
4560         (arm_find_exidx_entry, _initialize_arm_tdep)
4561
4562 2019-07-10  Tom Tromey  <tromey@adacore.com>
4563
4564         * solib-spu.c (ocl_program_data_key): Change type.
4565         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4566         Update.
4567
4568 2019-07-10  Tom Tromey  <tromey@adacore.com>
4569
4570         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4571         (struct solib_aix_inferior_data) <library_list>: Change type.
4572         (solib_aix_inferior_data_handle): Change type.
4573         (get_solib_aix_inferior_data): Update.
4574         (solib_aix_free_library_list): Remove.
4575         (library_list_start_library): Update.
4576         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4577         return type.
4578         (solib_aix_get_library_list)
4579         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4580         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4581
4582 2019-07-10  Tom Tromey  <tromey@adacore.com>
4583
4584         * solib-dsbt.c (struct dsbt_info): Add initializers.
4585         (solib_dsbt_pspace_data): Change type.
4586         (dsbt_pspace_data_cleanup): Remove.
4587         (get_dsbt_info, _initialize_dsbt_solib): Update.
4588
4589 2019-07-10  Tom Tromey  <tromey@adacore.com>
4590
4591         * spu-tdep.c (spu_overlay_data): Change type.
4592         (spu_get_overlay_table, spu_overlay_new_objfile)
4593         (_initialize_spu_tdep): Update.
4594
4595 2019-07-10  Tom Tromey  <tromey@adacore.com>
4596
4597         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4598         destructor.
4599         (dbx_objfile_data_key): Change type and declare later.
4600         (DBX_SYMFILE_INFO): Rewrite.
4601         * dbxread.c (dbx_objfile_data_key): Change type.
4602         (dbx_symfile_init): Update.
4603         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4604         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4605         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4606
4607 2019-07-10  Tom Tromey  <tromey@adacore.com>
4608
4609         * jit.c (jit_program_space_key): Change type.  Move lower.
4610         (get_jit_program_space_data): Update.
4611         (jit_program_space_data_cleanup): Remove.
4612         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4613         Update.
4614         (struct jit_program_space_data): Add initializers.
4615
4616 2019-07-10  Tom Tromey  <tromey@adacore.com>
4617
4618         * solib-darwin.c (struct darwin_info): Add initializers.
4619         (solib_darwin_pspace_data): Change type.
4620         (darwin_pspace_data_cleanup): Remove.
4621         (get_darwin_info, _initialize_darwin_solib): Update.
4622
4623 2019-07-10  Tom Tromey  <tromey@adacore.com>
4624
4625         * remote-sim.c (struct sim_inferior_data): Add initializers,
4626         constructor, and destructor.
4627         (sim_inferior_data_key): Change type.  Move lower.
4628         (check_for_duplicate_sim_descriptor): Update.
4629         (get_sim_inferior_data): Use new.  Update.
4630         (~sim_inferior_data_cleanup): Rename from
4631         sim_inferior_data_cleanup.  Simplify.
4632         (gdbsim_close_inferior, simulator_command)
4633         (sim_command_completer, _initialize_remote_sim): Update.
4634         (next_pid, INITIAL_PID): Move earlier.
4635
4636 2019-07-10  Tom Tromey  <tromey@adacore.com>
4637
4638         * python/python-internal.h (create_thread_object): Return
4639         gdbpy_ref.
4640         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4641         * python/py-inferior.c (struct threadlist_entry): Add
4642         constructor.
4643         <thread_obj>: Now a gdbpy_ref.
4644         (thread_to_thread_object): Update.
4645         (add_thread_object): Use new.
4646         (delete_thread_object): Use delete.
4647         (infpy_threads): Update.
4648         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4649         GIL.
4650
4651 2019-07-10  Tom Tromey  <tromey@adacore.com>
4652
4653         * valops.c (value_cast): Specialize error message for Ada.
4654
4655 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4656
4657         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4658
4659 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4660
4661         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4662         bpstat_should_step): Return bool, adjust comments.
4663         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4664         bpstat_should_step): Likewise.
4665
4666 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4667
4668         * features/Makefile: Use feature target descriptions for Arm.
4669         * features/arm/arm-core.c: Generate new file.
4670         * features/arm/arm-fpa.c: Likewise.
4671         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4672         * features/arm/arm-m-profile.c: Likewise.
4673         * features/arm/arm-vfpv2.c: Likewise.
4674         * features/arm/arm-vfpv3.c: Likewise.
4675         * features/arm/xscale-iwmmxt.c: Likewise.
4676         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4677
4678 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4679
4680         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4681         ptrace earlier.
4682
4683 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4684
4685         * features/aarch64-pauth.c: Regenerate.
4686
4687 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4688
4689         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4690         bool.
4691         (bpstat_what): Use false instead of 0.
4692
4693 2019-07-09  Pedro Alves  <palves@redhat.com>
4694
4695         * break-catch-throw.c (is_exception_catchpoint): New.
4696         * breakpoint.c (print_one_breakpoint_location): New parameter
4697         'raw_loc'.  Handle it.  Use
4698         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4699         looking at the breakpoint's type.
4700         (print_one_breakpoint): If handling "maint info breakpoints", also
4701         print locations of exception catchpoints.
4702         * breakpoint.h (is_exception_catchpoint): Declare.
4703
4704 2019-07-09  Pedro Alves  <palves@redhat.com>
4705
4706         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4707         "addr" field.
4708         (allocate_location_exception_catchpoint): New.
4709         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4710         (initialize_throw_catchpoint_ops): Install
4711         allocate_location_exception_catchpoint as allocate_location
4712         method.
4713         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4714         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4715         bp_loc_other.
4716         (breakpoint_address_is_meaningful): Delete.
4717         (bl_address_is_meaningful): New.
4718         (breakpoint_locations_match): Adjust comment.
4719         (bp_location_from_bp_type): New, factored out of...
4720         (bp_location::bp_location(breakpoint *)): ... this.
4721         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4722         factored out of...
4723         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4724         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4725         breakpoint_address_is_meaningful.
4726         (bp_locations_compare): Adjust comment.
4727         (update_global_location_list): Use bl_address_is_meaningful
4728         instead of breakpoint_address_is_meaningful.
4729         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4730         explicit.
4731         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4732         * python/py-breakpoint.c (bppy_get_location): No longer check
4733         whether location is null.
4734
4735 2019-07-09  Pedro Alves  <palves@redhat.com>
4736
4737         PR c++/15468
4738         * breakpoint.c (print_one_breakpoint_location): Remove
4739         single-location assert.
4740
4741 2019-07-09  Tom Tromey  <tom@tromey.com>
4742
4743         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4744         * configure: Rebuild.
4745         * configure.ac: Change common to gdbsupport.
4746         * gdbsupport: Rename from common.
4747         * acinclude.m4: Change common to gdbsupport.
4748         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4749         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4750         gdbsupport.
4751         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4752         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4753         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4754         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4755         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4756         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4757         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4758         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4759         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4760         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4761         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4762         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4763         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4764         coff-pe-read.c, command.h, compile/compile-c-support.c,
4765         compile/compile-c.h, compile/compile-cplus-symbols.c,
4766         compile/compile-cplus-types.c, compile/compile-cplus.h,
4767         compile/compile-loc2c.c, compile/compile.c, completer.c,
4768         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4769         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4770         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4771         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4772         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4773         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4774         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4775         features/aarch64-core.c, features/aarch64-fpu.c,
4776         features/aarch64-pauth.c, features/aarch64-sve.c,
4777         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4778         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4779         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4780         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4781         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4782         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4783         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4784         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4785         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4786         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4787         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4788         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4789         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4790         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4791         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4792         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4793         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4794         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4795         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4796         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4797         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4798         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4799         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4800         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4801         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4802         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4803         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4804         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4805         minsyms.c, mips-linux-tdep.c, namespace.h,
4806         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4807         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4808         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4809         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4810         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4811         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4812         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4813         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4814         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4815         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4816         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4817         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4818         procfs.c, producer.c, progspace.h, psymtab.h,
4819         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4820         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4821         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4822         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4823         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4824         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4825         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4826         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4827         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4828         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4829         target-memory.c, target.c, target.h, target/waitstatus.c,
4830         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4831         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4832         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4833         unittests/array-view-selftests.c,
4834         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4835         unittests/common-utils-selftests.c,
4836         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4837         unittests/format_pieces-selftests.c,
4838         unittests/function-view-selftests.c,
4839         unittests/lookup_name_info-selftests.c,
4840         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4841         unittests/mkdir-recursive-selftests.c,
4842         unittests/observable-selftests.c,
4843         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4844         unittests/parse-connection-spec-selftests.c,
4845         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4846         unittests/scoped_fd-selftests.c,
4847         unittests/scoped_mmap-selftests.c,
4848         unittests/scoped_restore-selftests.c,
4849         unittests/string_view-selftests.c, unittests/style-selftests.c,
4850         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4851         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4852         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4853         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4854         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4855         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4856
4857 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4858
4859         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4860         bool value.
4861         (decode_digits_ordinary): Set explicit_line field in sal.
4862         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4863         symtab_and_line that was set on an explicit line number in
4864         assembler code.  Do always update the recorded symtab and line if
4865         we do skip the prologue.
4866
4867 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4868
4869         * breakpoint.c (set_breakpoint_location_function): Remove
4870         explicit_loc parameter.
4871         (momentary_breakpoint_from_master): Update call to
4872         set_breakpoint_location_function.
4873         (add_location_to_breakpoint): Likewise.
4874
4875 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4876
4877         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4878         required features based on default bfd type when no specific bfd
4879         is present.
4880
4881 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4882
4883         * NEWS: Mention that GDB printf and eval commands can now print
4884         C-style and Ada-style convenience var strings without
4885         calling the inferior.
4886         * printcmd.c (printf_c_string): Locally print GDB internal var
4887         instead of transiting via the inferior.
4888         (printf_wide_c_string): Likewise.
4889
4890 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4891
4892         PR breakpoints/25011
4893         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4894
4895 2019-07-04  Tom Tromey  <tom@tromey.com>
4896
4897         PR tui/24724:
4898         * tui/tui-winsource.c (tui_clear_source_content): Update.
4899         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4900         (tui_update_breakpoint_info): Update.
4901         (tui_set_exec_info_content): Update.
4902         * tui/tui-source.c (tui_set_source_content_nil): Update.
4903         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4904         has_break.
4905         * tui/tui-data.h (enum tui_bp_flag): New.
4906         (tui_bp_flags): New enum flags type.
4907         (struct tui_source_element) <break_mode>: Change type.  Rename
4908         from has_break.
4909         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4910         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4911         constants.
4912         * tui/tui-winsource.h: Fix comment.
4913
4914 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4915
4916         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4917         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4918         (store_fpregs_to_thread)
4919         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4920         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4921         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4922         (IWMMXT_REGS_SIZE): Add define.
4923         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4924         (fetch_vfp_regs, store_vfp_regs)
4925         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4926         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4927
4928 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4929
4930         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4931         defines.
4932         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4933         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4934         (ARM_INT_REGISTER_SIZE): ...to this.
4935         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4936         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4937         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4938         (arm_linux_collect_gregset, supply_nwfpe_register)
4939         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4940         defines.
4941         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4942         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4943         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4944         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4945         (arm_return_in_memory, arm_store_return_value)
4946         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4947         (arm_record_ld_st_multiple): Likewise.
4948         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4949         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4950
4951 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4952
4953         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4954         AARCH64_DISPLACED_MODIFIED_INSNS.
4955         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4956         (aarch64_displaced_step_copy_insn): Likewise.
4957         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4958         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4959         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4960         ARM_DISPLACED_MODIFIED_INSNS.
4961         * arm-tdep.c (arm_gdbarch_init): Likewise.
4962         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4963         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4964         (struct arm_displaced_step_closure): Use
4965         ARM_DISPLACED_MODIFIED_INSNS.
4966
4967 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4968
4969         * features/Makefile: Remove unused xml files.
4970         * features/aarch64.xml: Remove.
4971         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4972         * features/i386/amd64-avx-avx512.xml: Remove.
4973         * features/i386/amd64-avx-linux.xml: Remove.
4974         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4975         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4976         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4977         * features/i386/amd64-avx-mpx.xml: Remove.
4978         * features/i386/amd64-avx.xml: Remove.
4979         * features/i386/amd64-linux.xml: Remove.
4980         * features/i386/amd64-mpx-linux.xml: Remove.
4981         * features/i386/amd64-mpx.xml: Remove.
4982         * features/i386/amd64.xml: Remove.
4983         * features/i386/i386-avx-avx512-linux.xml: Remove.
4984         * features/i386/i386-avx-avx512.xml: Remove.
4985         * features/i386/i386-avx-linux.xml: Remove.
4986         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4987         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4988         * features/i386/i386-avx-mpx-linux.xml: Remove.
4989         * features/i386/i386-avx-mpx.xml: Remove.
4990         * features/i386/i386-avx.xml: Remove.
4991         * features/i386/i386-linux.xml: Remove.
4992         * features/i386/i386-mmx-linux.xml: Remove.
4993         * features/i386/i386-mmx.xml: Remove.
4994         * features/i386/i386-mpx-linux.xml: Remove.
4995         * features/i386/i386-mpx.xml: Remove.
4996         * features/i386/i386.xml: Remove.
4997         * features/i386/x32-avx-avx512-linux.xml: Remove.
4998         * features/i386/x32-avx-linux.xml: Remove.
4999         * features/i386/x32-linux.xml: Remove.
5000
5001 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5002
5003         * regformats/aarch64.dat: Remove.
5004         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5005         * regformats/i386/amd64-avx-linux.dat: Remove.
5006         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5007         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5008         * regformats/i386/amd64-linux.dat: Remove.
5009         * regformats/i386/amd64-mpx-linux.dat: Remove.
5010         * regformats/i386/amd64.dat: Remove.
5011         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5012         * regformats/i386/i386-avx-linux.dat: Remove.
5013         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5014         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5015         * regformats/i386/i386-linux.dat: Remove.
5016         * regformats/i386/i386-mmx-linux.dat: Remove.
5017         * regformats/i386/i386-mpx-linux.dat: Remove.
5018         * regformats/i386/i386.dat: Remove.
5019         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5020         * regformats/i386/x32-avx-linux.dat: Remove.
5021         * regformats/i386/x32-linux.dat: Remove.
5022
5023 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5024
5025         * aarch64-tdep.c: Remove xml self tests.
5026         * amd64-linux-tdep.c: Likewise.
5027         * amd64-tdep.c: Likewise.
5028         * i386-linux-tdep.c: Likewise.
5029         * i386-tdep.c: Likewise.
5030
5031 2019-07-03  Pedro Alves  <palves@redhat.com>
5032
5033         PR cli/24732
5034         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5035         (pipe_cmd_option_defs): New.
5036         (make_pipe_cmd_options_def_group): New.
5037         (pipe_command): Use gdb::option::process_options.
5038         (pipe_command_completer): New function.
5039         (_initialize_cli_cmds): Install completer for "pipe" command.
5040
5041 2019-07-03  Pedro Alves  <palves@redhat.com>
5042
5043         * cli/cli-option.c (union option_value) <string>: New field.
5044         (struct option_def_and_value): Add ctor, move ctor, dtor and
5045         use DISABLE_COPY_AND_ASSIGN.
5046         (option_def_and_value::clear_value): New.
5047         (parse_option, save_option_value_in_ctx, get_val_type_str)
5048         (add_setshow_cmds_for_options): Handle var_string.
5049         * cli-option.h (union option_def::var_address) <string>: New
5050         field.
5051         (struct string_option_def): New.
5052         * maint-test-options.c (struct test_options_opts): Add default
5053         ctor and use DISABLE_COPY_AND_ASSIGN.
5054         <string_opt>: New field.
5055         (test_options_opts::~test_options_opts): New.
5056         (test_options_opts::dump): Also dump "-string".
5057         (test_options_option_defs): Install "string.
5058
5059 2019-07-03  Pedro Alves  <palves@redhat.com>
5060
5061         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5062         option_value with a null enumeration.
5063         (complete_options): Save the option values in the context.
5064         (save_option_value_in_ctx): New, factored out from ...
5065         (process_options): ... here.
5066         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5067         of the function.
5068         * maint-test-options.c (test_options_opts::dump): New, factored
5069         out from ...
5070         (maintenance_test_options_command_mode): ... here.
5071         (maintenance_test_options_command_completion_result): Delete.
5072         (maintenance_test_options_command_completion_text): Update
5073         comment.
5074         (maintenance_show_test_options_completion_result): Change
5075         prototype.  Just print
5076         maintenance_test_options_command_completion_text.
5077         (save_completion_result): New.
5078         (maintenance_test_options_completer_mode): Pass options context to
5079         complete_options, and then save a dump.
5080         (_initialize_maint_test_options): Use add_cmd to install "maint
5081         show test-options-completion-result".
5082
5083 2019-07-03  Pedro Alves  <palves@redhat.com>
5084
5085         * NEWS (New commands): Mention "with" and "maint with".
5086         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5087         (with_command, with_command_completer): New.
5088         (pipe_command): Adjust to new repeat_previous
5089         interface.
5090         (_initialize_cli_cmds): Install the "with" command and its "w"
5091         alias.
5092         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5093         declarations.
5094         * cli/cli-setshow.c (parse_cli_var_uinteger)
5095         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5096         argument strings for all var_types.
5097         (get_setshow_command_value_string): New, factored out from ...
5098         (do_show_command): ... this.
5099         * cli/cli-setshow.h: Include <string>.
5100         (get_setshow_command_value_string): Declare.
5101         * command.h (repeat_previous): Now returns const char *.  Adjust
5102         comment.
5103         * maint.c: Include "cli/cli-cmds.h".
5104         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5105         (_initialize_maint_cmds): Register the "maintenance with" command.
5106         * top.c (repeat_previous): Move bits from pipe_command here:
5107         Return the saved command line, if any; error out if there's no
5108         command to relaunch.
5109
5110 2019-07-03  Pedro Alves  <palves@redhat.com>
5111
5112         * NEWS (New commands): Mention "maint set/show test-settings"
5113         instead of "maint test-settings".
5114         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5115         (maintenance_test_settings_set_list): Rename to ...
5116         (maintenance_set_test_settings_list): ... this.
5117         (maintenance_test_settings_show_list): Rename to  ...
5118         (maintenance_show_test_settings_list): ... this.
5119         (maintenance_test_settings_cmd): Delete.
5120         (maintenance_test_settings_set_cmd): ...
5121         (maintenance_set_test_settings_cmd): ... this.
5122         (maintenance_test_settings_show_cmd): ...
5123         (maintenance_show_test_settings_cmd): ... this.
5124         (maintenance_test_settings_show_value_cmd):
5125         (maintenance_show_test_settings_value_cmd): ... this.
5126         (_initialize_maint_test_settings): No longer install the "maint
5127         test-settings" prefix command.  Rename "maint test-settings set"
5128         to "maint set test-settings", and "maint test-settings show" to
5129         "maint show test-settings".  Adjust all subcommands.
5130
5131 2019-07-03  Pedro Alves  <palves@redhat.com>
5132
5133         * maint-test-settings.c: Fix file's intro comment.  Replace all
5134         references to "test-options" with references to "test-settings",
5135         in comments.
5136
5137 2019-07-03  Pedro Alves  <palves@redhat.com>
5138
5139         * maint-test-settings.c (maintenance_test_settings_xxx)
5140         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5141         New.
5142         (maintenance_test_settings_enums): Use them.
5143         (maintenance_test_settings_enum): Default to
5144         maintenance_test_settings_xxx.
5145         (_initialize_maint_test_settings): Initialize
5146         MAINTENANCE_TEST_SETTINGS_FILENAME.
5147
5148 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5149
5150         * breakpoint.h (remove_breakpoints_inf): Change return type to
5151         void, move function documentation here.
5152         * breakpoint.c (remove_breakpoints_inf): Change return type to
5153         void, move function documentation to header.
5154
5155 2019-07-02  Pedro Alves  <palves@redhat.com>
5156
5157         * NEWS (Completion improvements): Mention "info threads".
5158         * thread.c (struct info_threads_opts, info_threads_option_defs)
5159         (make_info_threads_options_def_group): New.
5160         (info_threads_command): Use gdb::option::process_options.
5161         (info_threads_command_completer): New.
5162         (_initialize_thread): Use gdb::option::build_help to build the
5163         help text for "info threads".
5164
5165 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5166
5167         * defs.h (generic_load): Move from here...
5168         * symfile.h (generic_load): ... to here.  Rename name parameter
5169         to args.
5170         * symfile.c (generic_load): Add comment.
5171
5172 2019-07-01  Tom Tromey  <tromey@adacore.com>
5173
5174         * dwarf2read.c
5175         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5176         declaration of without_params.  Fix formatting.
5177
5178 2019-07-01  Tom Tromey  <tromey@adacore.com>
5179
5180         * ada-exp.y (find_primitive_type): Update.
5181         * ada-lang.h (ada_lookup_symbol): Update.
5182         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5183         parameter.
5184         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5185
5186 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5187
5188         PR breakpoints/24541
5189         * gdbarch.c: Regenerate.
5190         * gdbarch.h: Regenerate.
5191         * gdbarch.sh: Add 'stap_adjust_register'.
5192         * i386-tdep.c: Include '<unordered_set>'.
5193         (i386_stap_adjust_register): New function.
5194         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5195         * stap-probe.c (stap_parse_register_operand): Call
5196         'gdbarch_stap_adjust_register'.
5197
5198 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5199
5200         PR python/24742
5201         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5202         * python/python.c (do_start_initialization): Use 'xmalloc'
5203         instead of 'PyMem_Malloc'.
5204
5205 2019-06-28  Tom Tromey  <tromey@adacore.com>
5206
5207         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5208         for Ada.
5209
5210 2019-06-27  Tom Tromey  <tromey@adacore.com>
5211
5212         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5213         objfile_key.
5214         (arm_find_mapping_symbol, arm_record_special_symbol)
5215         (_initialize_arm_tdep): Update.
5216         (arm_objfile_data_free): Remove.
5217
5218 2019-06-27  Tom Tromey  <tromey@adacore.com>
5219
5220         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5221         to cp_print_static_field.
5222
5223 2019-06-26  Tom Tromey  <tromey@adacore.com>
5224
5225         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5226         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5227         declare.
5228
5229 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5230
5231         * features/aarch64-core.c (create_feature_aarch64_core):
5232         Regenerate.
5233         * features/aarch64-core.xml: Add cpsr flags.
5234
5235 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5236
5237         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5238         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5239
5240 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5241
5242         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5243         field.
5244         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5245         use.
5246         (arm_record_special_symbol): Don't insert new symbol in sorted
5247         position, push it at the end.
5248
5249 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5250
5251         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5252         (arm_mapping_symbol_s): Remove.
5253         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5254         (arm_mapping_symbol_vec): New typedef.
5255         (struct arm_per_objfile): Add constructor.
5256         <section_maps>: Change type to
5257         std::unique_ptr<arm_mapping_symbol_vec[]>.
5258         (arm_compare_mapping_symbols): Remove.
5259         (arm_find_mapping_symbol): Adjust to section_maps type change.
5260         (arm_objfile_data_free): Call delete on arm_per_objfile.
5261         (arm_record_special_symbol): Adjust to section_maps type change.
5262         Allocate arm_per_objfile with new.
5263
5264 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5265
5266         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5267         with the command prefix.
5268
5269 2019-06-25  Tom Tromey  <tom@tromey.com>
5270
5271         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5272         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5273
5274 2019-06-25  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5277         type.
5278         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5279         protected.
5280
5281 2019-06-25  Tom Tromey  <tom@tromey.com>
5282
5283         * tui/tui-winsource.c
5284         (tui_source_window_base::set_is_exec_point_at): Add check against
5285         LOA_ADDRESS.
5286
5287 2019-06-25  Tom Tromey  <tom@tromey.com>
5288
5289         * tui/tui-source.c (tui_set_source_content): Don't check before
5290         xfree.
5291         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5292
5293 2019-06-25  Tom Tromey  <tom@tromey.com>
5294
5295         * tui/tui-winsource.h (tui_update_source_window_as_is)
5296         (tui_alloc_source_buffer, tui_line_is_displayed)
5297         (tui_addr_is_displayed): Change type of win_info.
5298         * tui/tui-winsource.c (tui_update_source_window_as_is)
5299         (tui_clear_source_content, tui_show_source_line)
5300         (tui_show_source_content, tui_source_window_base::refill)
5301         (tui_source_window_base::set_is_exec_point_at)
5302         (tui_source_window_base::set_is_exec_point_at)
5303         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5304         (tui_alloc_source_buffer, tui_line_is_displayed)
5305         (tui_addr_is_displayed): Change type of win_info.  Update.
5306         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5307         (tui_source_window_base::do_make_visible_with_new_height):
5308         Update.
5309         * tui/tui-source.c (tui_set_source_content)
5310         (tui_set_source_content_nil)
5311         (tui_source_window::do_scroll_vertical): Update.
5312         * tui/tui-layout.c (show_layout): Update.
5313         * tui/tui-disasm.c (tui_set_disassem_content)
5314         (tui_disasm_window::do_scroll_vertical): Update.
5315         * tui/tui-data.h (tui_win_content): Remove.
5316         (struct tui_gen_win_info) <content, content_size>: Remove.
5317         (struct tui_source_element): Add initializers and destructor.
5318         (union tui_which_element, struct tui_win_element): Remove.
5319         (struct tui_source_window_base) <content>: New field.
5320         (struct tui_data_window): Remove destructor.
5321         (tui_alloc_content, tui_free_win_content)
5322         (tui_free_all_source_wins_content): Don't declare.
5323         * tui/tui-data.c (tui_initialize_static_data): Update.
5324         (init_content_element, tui_alloc_content): Remove.
5325         (~tui_gen_win_info): Update.
5326         (~tui_data_window, tui_free_all_source_wins_content)
5327         (tui_free_win_content, free_content, free_content_elements):
5328         Remove.
5329
5330 2019-06-25  Tom Tromey  <tom@tromey.com>
5331
5332         * tui/tui-winsource.h (tui_clear_source_content)
5333         (tui_erase_source_content, tui_show_source_content): Change type
5334         of win_info.
5335         * tui/tui-winsource.c (tui_clear_source_content)
5336         (tui_erase_source_content, tui_show_source_content): Change type
5337         of win_info.
5338         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5339         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5340         win_info.
5341         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5342         win_info.
5343         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5344
5345 2019-06-25  Tom Tromey  <tom@tromey.com>
5346
5347         * tui/tui-winsource.c (tui_clear_source_content)
5348         (tui_source_window_base::set_is_exec_point_at): Update.
5349         * tui/tui-source.c (tui_set_source_content_nil): Update.
5350         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5351         a bool.
5352         * tui/tui-data.c (init_content_element): Update.
5353
5354 2019-06-25  Tom Tromey  <tom@tromey.com>
5355
5356         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5357         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5358         * tui/tui-layout.c (init_and_make_win): Update.
5359         * tui/tui.h (enum tui_win_type): Update.
5360         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5361         tui_win_is_auxillary.
5362         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5363         tui_win_is_auxillary.
5364
5365 2019-06-25  Tom Tromey  <tom@tromey.com>
5366
5367         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5368         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5369         (tui_delete_data_content_windows, tui_display_all_data)
5370         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5371         Update.
5372         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5373         * tui/tui-regs.c (tui_last_regs_line_no)
5374         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5375         (tui_show_registers): Update.
5376         (tui_show_register_group): Return void.  Update.
5377         (tui_display_registers_from, tui_display_reg_element_at_line)
5378         (tui_display_registers_from_line, tui_check_register_values):
5379         Update.
5380         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5381         member.
5382         (struct tui_data_window) <regs_content>: Now a std::vector.
5383         <regs_content_count>: Remove.
5384         (tui_add_content_elements, tui_free_data_content): Don't declare.
5385         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5386         (init_content_element): Remove DATA_WIN case.  Add assert.
5387         (tui_add_content_elements): Remove.
5388         (tui_data_window): Update.
5389         (tui_free_data_content): Remove.
5390         (free_content_elements): Remove DATA_WIN case.
5391
5392 2019-06-25  Tom Tromey  <tom@tromey.com>
5393
5394         * tui/tui-data.c (tui_data_item_window): Update.
5395         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5396         * tui/tui-windata.c (tui_display_all_data)
5397         (tui_display_data_from_line): Update.
5398         (tui_check_data_values): Remove.
5399         * tui/tui-regs.c (tui_show_register_group)
5400         (tui_display_reg_element_at_line): Update.
5401         * tui/tui-hooks.c (tui_register_changed)
5402         (tui_refresh_frame_and_register_information): Call
5403         tui_check_register_values.
5404         * tui/tui-data.h (struct tui_data_window) <data_content,
5405         data_content_count, data_type>: Remove.
5406         (enum tui_data_type): Remove.
5407
5408         * tui/tui-data.c (tui_data_window::clear_detail)
5409         (~tui_data_window): Update.
5410
5411 2019-06-25  Tom Tromey  <tom@tromey.com>
5412
5413         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5414         declare.
5415         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5416         Rename from tui_first_data_item_displayed.  Update.
5417         (tui_data_window::refresh_all)
5418         (tui_data_window::do_scroll_vertical): Update.
5419         * tui/tui-data.h (struct tui_data_window)
5420         <first_data_item_displayed>: Declare new method.
5421
5422 2019-06-25  Tom Tromey  <tom@tromey.com>
5423
5424         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5425         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5426         contents...
5427         (tui_initialize_static_data): ...here.
5428
5429 2019-06-25  Tom Tromey  <tom@tromey.com>
5430
5431         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5432         (tui_display_registers_from, tui_check_register_values): Update.
5433         (tui_display_register): Remove win_info parameter; update.
5434         (tui_get_register): Change type of parameters.
5435         * tui/tui-data.h (struct tui_data_element): Remove.
5436         (union tui_which_element) <data>: Remove.
5437         <data_window>: Change type.
5438         (struct tui_data_item_window): New.
5439         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5440         case.  Add assert.
5441         (~tui_data_item_window): New destructor.
5442         (free_content_elements): Remove DATA_ITEM_WIN case.
5443
5444 2019-06-25  Tom Tromey  <tom@tromey.com>
5445
5446         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5447         Remove.
5448
5449 2019-06-25  Tom Tromey  <tom@tromey.com>
5450
5451         * tui/tui-data.h (struct tui_command_element): Remove.
5452         (union tui_which_element) <command>: Remove.
5453         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5454         assert.
5455         (free_content_elements): Remove CMD_WIN case.
5456
5457 2019-06-25  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui-layout.c (tui_set_layout): Update.
5460         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5461         * tui/tui-data.c (layout_def): Update.
5462
5463 2019-06-25  Tom Tromey  <tom@tromey.com>
5464
5465         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5466         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5467         (tui_source_window_base::set_new_height): Update.
5468         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5469         Update.
5470         (tui_set_locator_fullname, tui_set_locator_info)
5471         (tui_show_frame_info): Update.
5472         * tui/tui-source.c (tui_set_source_content)
5473         (tui_source_is_displayed): Update.
5474         * tui/tui-layout.c (show_source_disasm_command, show_data)
5475         (show_source_or_disasm_and_command): Update.
5476         * tui/tui-disasm.c (tui_set_disassem_content)
5477         (tui_get_begin_asm_address): Update.
5478         * tui/tui-data.h (struct tui_locator_element): Remove.
5479         (union tui_which_element) <locator>: Remove.
5480         (struct tui_locator_window): New.
5481         (tui_locator_win_info_ptr): Change return type.
5482         * tui/tui-data.c (_locator): Change type.
5483         (tui_locator_win_info_ptr): Change return type.
5484         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5485         (tui_alloc_content): Add assert.
5486
5487 2019-06-25  Tom Tromey  <tom@tromey.com>
5488
5489         * tui/tui-winsource.c
5490         (tui_exec_info_window::maybe_allocate_content): New method.
5491         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5492         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5493         (make_source_or_disasm_window): Add cast.
5494         * tui/tui-data.h (union tui_which_element) <simple_string>:
5495         Remove.
5496         (struct tui_source_info): New.
5497         (struct tui_source_window_base) <execution_info>: Change type.
5498         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5499         case, and add assert.
5500         (tui_alloc_content): Add assert.
5501
5502 2019-06-25  Tom Tromey  <tom@tromey.com>
5503
5504         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5505         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5506         * tui/tui-data.c (tui_alloc_win_info): Remove.
5507
5508 2019-06-25  Tom Tromey  <tom@tromey.com>
5509
5510         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5511         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5512         can_highlight.
5513
5514 2019-06-25  Tom Tromey  <tom@tromey.com>
5515
5516         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5517         make_visible_with_new_height method.
5518         (tui_win_info::make_visible_with_new_height): New method.
5519         (tui_source_window_base::do_make_visible_with_new_height)
5520         (tui_data_window::do_make_visible_with_new_height)
5521         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5522         (make_visible_with_new_height): Remove.
5523         (tui_resize_all, tui_adjust_win_heights): Use
5524         make_visible_with_new_height method.
5525         * tui/tui-data.h (struct tui_win_info)
5526         <do_make_visible_with_new_height, make_visible_with_new_height>:
5527         New methods.
5528         (struct tui_source_window_base, struct tui_data_window)
5529         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5530         methods.
5531
5532 2019-06-25  Tom Tromey  <tom@tromey.com>
5533
5534         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5535         method.
5536         (update_tab_width): Call update_tab_width method.
5537         * tui/tui-data.h (struct tui_win_info)
5538         (struct tui_source_window_base) <update_tab_width>: New methods.
5539
5540 2019-06-25  Tom Tromey  <tom@tromey.com>
5541
5542         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5543         parameter.
5544         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5545         parameter.
5546         (tui_gen_win_info::make_visible): Update.
5547         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5548         parameter.
5549         * tui/tui-data.h (enum tui_box): New enum.
5550         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5551
5552 2019-06-25  Tom Tromey  <tom@tromey.com>
5553
5554         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5555         init_and_make_win for EXEC_INFO_WIN.
5556         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5557         longer inline.
5558         (struct tui_win_info) <~tui_win_info>: Inline.
5559         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5560         Don't declare.
5561         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5562         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5563         Remove.
5564         (tui_initialize_static_data): Update.
5565         (~tui_gen_win_info): Handle more cleanup here.
5566         (~tui_source_window_base): Delete "execution_info".
5567         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5568
5569 2019-06-25  Tom Tromey  <tom@tromey.com>
5570
5571         * tui/tui-layout.c (make_command_window): Don't set
5572         can_highlight.
5573         (show_source_disasm_command): Call the reset method.
5574         (show_data): Don't set can_highlight.  Call the reset method.
5575         (tui_gen_win_info::reset): Rename from init_gen_win_info
5576         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5577         (show_source_or_disasm_and_command): Call the reset method.
5578         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5579         (struct tui_cmd_window): Set can_highlight.
5580
5581 2019-06-25  Tom Tromey  <tom@tromey.com>
5582
5583         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5584         from make_visible.
5585         (tui_make_visible, tui_make_invisible): Rewrite.
5586         (tui_win_info::make_visible): Remove.
5587         (tui_source_window_base::make_visible): Update.
5588         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5589         method.  Moved from...
5590         (struct tui_win_info) <make_visible>: ...here.
5591
5592 2019-06-25  Tom Tromey  <tom@tromey.com>
5593
5594         * tui/tui-winsource.c
5595         (tui_source_window_base::do_scroll_horizontal): Remove direction
5596         parameter.
5597         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5598         direction parameter.
5599         * tui/tui-win.c (tui_win_info::forward_scroll)
5600         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5601         (tui_win_info::right_scroll): Update.
5602         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5603         direction parameter.
5604         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5605         direction parameter.
5606         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5607         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5608         Remove direction parameter.
5609         (struct tui_source_window_base, struct tui_source_window)
5610         (struct tui_disasm_window, struct tui_data_window)
5611         (struct tui_cmd_window): Update.
5612
5613 2019-06-25  Tom Tromey  <tom@tromey.com>
5614
5615         * tui/tui-winsource.h (tui_set_exec_info_content)
5616         (tui_show_exec_info_content, tui_erase_exec_info_content)
5617         (tui_clear_exec_info_content, tui_update_exec_info): Change
5618         argument to tui_source_window_base.
5619         * tui/tui-winsource.c (tui_set_exec_info_content)
5620         (tui_show_exec_info_content, tui_erase_exec_info_content)
5621         (tui_clear_exec_info_content, tui_update_exec_info): Change
5622         argument to tui_source_window_base.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5627         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5628
5629 2019-06-25  Tom Tromey  <tom@tromey.com>
5630
5631         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5632         check.
5633
5634 2019-06-25  Tom Tromey  <tom@tromey.com>
5635
5636         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5637         type to void.
5638         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5639         type to void.
5640         * tui/tui-source.c (tui_set_source_content): Update.
5641         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5642
5643 2019-06-25  Tom Tromey  <tom@tromey.com>
5644
5645         * tui/tui-win.c (window_name_completer, tui_set_focus)
5646         (tui_all_windows_info): Use name method.
5647         * tui/tui-data.h (struct tui_gen_win_info)
5648         (struct tui_source_window, struct tui_disasm_window)
5649         (struct tui_data_window, struct tui_cmd_window) <name>: New
5650         method.
5651         (tui_win_name): Don't declare.
5652         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5653         (tui_win_name): Remove.
5654
5655 2019-06-25  Tom Tromey  <tom@tromey.com>
5656
5657         * tui/tui-winsource.h (tui_update_source_window)
5658         (tui_update_source_window_as_is): Change parameter type.
5659         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5660         to be a tui_source_window_base.
5661         (tui_update_source_window_as_is): Likewise.
5662         * tui/tui-win.c (make_visible_with_new_height): Update.
5663
5664 2019-06-25  Tom Tromey  <tom@tromey.com>
5665
5666         * tui/tui-winsource.c (tui_erase_source_content)
5667         (tui_show_source_content, tui_show_exec_info_content)
5668         (tui_erase_exec_info_content): Use refresh_window method.
5669         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5670         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5671         from tui_refresh_win.
5672         (tui_data_window::refresh_window): New method.
5673         (tui_win_info::refresh, tui_source_window_base::refresh)
5674         (tui_refresh_all): Use refresh_window method.
5675         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5676         method.
5677         * tui/tui-regs.c (tui_display_register): Call refresh_window
5678         method.
5679         * tui/tui-layout.c (show_source_disasm_command)
5680         (show_source_or_disasm_and_command): Call refresh_window method.
5681         * tui/tui-data.h (struct tui_gen_win_info)
5682         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5683         New method.
5684
5685 2019-06-25  Tom Tromey  <tom@tromey.com>
5686
5687         * tui/tui.c (tui_rl_other_window, tui_enable)
5688         (tui_is_window_visible, tui_get_command_dimension): Update.
5689         * tui/tui-winsource.c (tui_update_source_window_as_is)
5690         (tui_clear_source_content, tui_erase_source_content)
5691         (tui_show_source_line, tui_source_window_base::refill)
5692         (tui_source_window_base::do_scroll_horizontal)
5693         (tui_source_window_base::set_is_exec_point_at)
5694         (tui_update_breakpoint_info, tui_set_exec_info_content)
5695         (tui_alloc_source_buffer, tui_line_is_displayed)
5696         (tui_addr_is_displayed): Update.
5697         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5698         (tui_check_and_display_highlight_if_needed)
5699         (tui_win_info::make_visible, tui_win_info::refresh)
5700         (tui_refresh_all): Update.
5701         * tui/tui-windata.c (tui_first_data_item_displayed)
5702         (tui_delete_data_content_windows, tui_erase_data_content)
5703         (tui_display_all_data, tui_data_window::refresh_all)
5704         (tui_check_data_values): Update.
5705         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5706         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5707         (tui_win_info::backward_scroll, tui_refresh_all_win)
5708         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5709         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5710         (tui_source_window_base::set_new_height)
5711         (tui_data_window::set_new_height)
5712         (make_invisible_and_set_new_height)
5713         (make_visible_with_new_height, new_height_ok)
5714         (parse_scrolling_args): Update.
5715         * tui/tui-stack.c (tui_show_frame_info): Update.
5716         * tui/tui-source.c (tui_set_source_content)
5717         (tui_set_source_content_nil, tui_source_is_displayed)
5718         (tui_source_window::do_scroll_vertical): Update.
5719         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5720         (tui_display_registers_from, tui_display_reg_element_at_line)
5721         (tui_check_register_values, tui_reg_command): Update.
5722         * tui/tui-layout.c (tui_default_win_height)
5723         (show_source_disasm_command, show_data, init_and_make_win)
5724         (show_source_or_disasm_and_command): Update.
5725         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5726         (tui_redisplay_readline, tui_mld_flush)
5727         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5728         (tui_getc): Update.
5729         * tui/tui-disasm.c (tui_set_disassem_content)
5730         (tui_disasm_window::do_scroll_vertical): Update.
5731         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5732         Now virtual.
5733         (struct tui_win_info): Derive from tui_gen_win_info.
5734         <~tui_win_info>: Mark as override.
5735         <generic>: Remove member.
5736         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5737         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5738         (~tui_data_window, ~tui_win_info)
5739         (tui_free_all_source_wins_content): Update.
5740         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5741
5742 2019-06-25  Tom Tromey  <tom@tromey.com>
5743
5744         * tui/tui-layout.c (init_and_make_win): Use new.
5745         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5746         destructor, initializers.
5747         (tui_alloc_generic_win_info): Don't declare.
5748         * tui/tui-data.c (_locator): Add argument to constructor.
5749         (source_win, disasm_win): New globals.
5750         (exec_info): Remove.
5751         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5752         Update.
5753         (tui_alloc_generic_win_info): Remove.
5754         (init_content_element): Use new.
5755         (tui_win_info::tui_win_info): Update.
5756         (free_content_elements) <case DATA_WIN>: Use delete.
5757
5758 2019-06-25  Tom Tromey  <tom@tromey.com>
5759
5760         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5761         * tui/tui-windata.c (tui_first_data_item_displayed)
5762         (tui_delete_data_content_windows): Update.
5763         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5764         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5765         (tui_display_registers_from, tui_check_register_values): Update.
5766         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5767         pointer.
5768         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5769         window.
5770         (tui_free_data_content): Update.
5771         (free_content_elements) <case DATA_WIN>: Free the window.
5772
5773 2019-06-25  Tom Tromey  <tom@tromey.com>
5774
5775         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5776         Update.
5777         * tui/tui-layout.c (make_command_window)
5778         (show_source_disasm_command, show_data, init_and_make_win)
5779         (show_source_or_disasm_and_command): Update.
5780         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5781         method.
5782         <can_highight, is_highlighted>: Now bool.
5783         (tui_set_win_highlight): Don't declare.
5784         * tui/tui-data.c (tui_set_win_highlight): Remove.
5785
5786 2019-06-25  Tom Tromey  <tom@tromey.com>
5787
5788         * tui/tui-wingeneral.c (make_visible): Remove check of window
5789         type.
5790
5791 2019-06-25  Tom Tromey  <tom@tromey.com>
5792
5793         * tui/tui-win.c (tui_win_info::max_height)
5794         (tui_cmd_window::max_height): New methods.
5795         (new_height_ok): Call max_height.
5796         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5797         <max_height>: New method.
5798
5799 2019-06-25  Tom Tromey  <tom@tromey.com>
5800
5801         * tui/tui-win.c (tui_source_window_base::set_new_height)
5802         (tui_data_window::set_new_height): New methods.
5803         (make_invisible_and_set_new_height): Call set_new_height method.
5804         * tui/tui-data.h (struct tui_win_info)
5805         (struct tui_source_window_base, struct tui_data_window)
5806         <set_new_height>: New method.
5807
5808 2019-06-25  Tom Tromey  <tom@tromey.com>
5809
5810         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5811         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5812         tui_refresh_data_win.
5813         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5814         method.
5815         (tui_refresh_all_win): Call the refresh_all method.
5816         (tui_set_focus): Likewise.
5817         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5818         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5819         Likewise.
5820
5821 2019-06-25  Tom Tromey  <tom@tromey.com>
5822
5823         * tui/tui-winsource.h (tui_refill_source_window)
5824         (tui_set_is_exec_point_at): Don't declare.
5825         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5826         (tui_source_window_base::refill): Rename from
5827         tui_refill_source_window.
5828         (tui_source_window_base::do_scroll_horizontal): Update.
5829         (tui_source_window_base::set_is_exec_point_at): Rename from
5830         tui_set_is_exec_point_at.
5831         (tui_update_all_breakpoint_info): Update.
5832         * tui/tui-stack.c (tui_show_frame_info): Update.
5833         * tui/tui-layout.c (show_data): Add cast.
5834         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5835         * tui/tui-data.h (struct tui_source_window_base) <refill,
5836         set_is_exec_point_at>: New methods.
5837         (tui_source_windows, tui_add_to_source_windows): Update types.
5838         (tui_add_to_source_windows): Remove redundant declaration.
5839         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5840         (tui_source_windows): Change return type.
5841         (tui_clear_source_windows_detail): Update.
5842         (tui_add_to_source_windows): Change type of parameter.
5843         (tui_free_all_source_wins_content): Update.
5844
5845 2019-06-25  Tom Tromey  <tom@tromey.com>
5846
5847         * tui/tui-wingeneral.c (tui_win_info::refresh)
5848         (tui_source_window_base::refresh): New methods.
5849         (tui_refresh_all): Call the refresh method.
5850         * tui/tui-data.h (struct tui_win_info)
5851         (struct tui_source_window_base) <refresh>: New method.
5852
5853 2019-06-25  Tom Tromey  <tom@tromey.com>
5854
5855         * tui/tui.h (tui_is_window_visible): Return bool.
5856         * tui/tui.c (tui_is_window_visible): Return bool.
5857         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5858         (tui_make_visible, tui_make_invisible)
5859         (tui_win_info::make_visible)
5860         (tui_source_window_base::make_visible, make_all_visible)
5861         (tui_make_all_visible, tui_make_all_invisible): Update.
5862         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5863         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5864         bool.
5865         (struct tui_win_info, struct tui_source_window_base)
5866         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5867         * tui/tui-data.c (tui_init_generic_part): Update.
5868
5869 2019-06-25  Tom Tromey  <tom@tromey.com>
5870
5871         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5872         (tui_source_window_base::make_visible): New methods.
5873         (make_all_visible): Make method call.
5874         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5875         (struct tui_source_window_base, struct tui_cmd_window): Override
5876         make_visible.
5877         (tui_win_is_source_type): Don't declare.
5878         * tui/tui-data.c (tui_win_is_source_type): Remove.
5879
5880 2019-06-25  Tom Tromey  <tom@tromey.com>
5881
5882         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5883         NULL check.
5884
5885 2019-06-25  Tom Tromey  <tom@tromey.com>
5886
5887         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5888         Inline constructor.  Add initializers for members.
5889         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5890         constructors; now inline in class.
5891
5892 2019-06-25  Tom Tromey  <tom@tromey.com>
5893
5894         * tui/tui-regs.c (tui_show_registers): Update.
5895         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5896         bool.
5897         * tui/tui-data.c (tui_data_window::clear_detail)
5898         (tui_data_window): Update.
5899
5900 2019-06-25  Tom Tromey  <tom@tromey.com>
5901
5902         * tui/tui-windata.c (tui_display_all_data)
5903         (tui_display_data_from_line, tui_display_data_from)
5904         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5905         Update.
5906         * tui/tui-regs.c (tui_last_regs_line_no)
5907         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5908         (tui_show_registers, tui_show_register_group)
5909         (tui_display_registers_from, tui_display_reg_element_at_line)
5910         (tui_display_registers_from_line, tui_check_register_values)
5911         (tui_reg_next, tui_reg_prev): Update.
5912         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5913         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5914         tui_data_window.
5915         (struct tui_win_info) <detail>: Remove.  Add new fields from
5916         tui_data_info.
5917         (TUI_DATA_WIN): Add cast.
5918         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5919         (~tui_data_window): Simplify.
5920
5921 2019-06-25  Tom Tromey  <tom@tromey.com>
5922
5923         * tui/tui-layout.c (show_source_disasm_command)
5924         (show_source_or_disasm_and_command): Update.
5925         * tui/tui-io.c (update_cmdwin_start_line)
5926         (tui_redisplay_readline): Update.
5927         * tui/tui-data.h (struct tui_command_info): Remove.
5928         (struct tui_win_info) <detail>: Remove command_info member.
5929         (struct tui_data_window) <start_line>: New member, from
5930         tui_command_info.
5931         (TUI_CMD_WIN): Add casts.
5932
5933 2019-06-25  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui-winsource.c (tui_update_source_window)
5936         (tui_refill_source_window)
5937         (tui_source_window_base::do_scroll_horizontal)
5938         (tui_update_breakpoint_info, tui_set_exec_info_content)
5939         (tui_show_exec_info_content, tui_erase_exec_info_content)
5940         (tui_clear_exec_info_content): Update.
5941         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5942         Update.
5943         * tui/tui-win.c (make_invisible_and_set_new_height)
5944         (make_visible_with_new_height): Update.
5945         * tui/tui-source.c (tui_set_source_content)
5946         (tui_show_symtab_source): Update.
5947         * tui/tui-layout.c (extract_display_start_addr)
5948         (show_source_disasm_command, show_data)
5949         (make_source_or_disasm_window)
5950         (show_source_or_disasm_and_command): Update.
5951         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5952         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5953         "gdbarch".
5954         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5955         to tui_source_window_base.
5956         (struct tui_win_info) <detail>: Remove source_info member.
5957         (struct tui_source_window_base) <has_locator>: Inline.
5958         Move contents from tui_source_info; rename has_locator member to
5959         m_has_locator.
5960         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5961         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5962         header file.
5963         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5964         Simplify.
5965         (tui_free_all_source_wins_content): Cast to
5966         tui_source_window_base.
5967
5968 2019-06-25  Tom Tromey  <tom@tromey.com>
5969
5970         * tui/tui-win.c (make_invisible_and_set_new_height)
5971         (make_visible_with_new_height): Call has_locator method.
5972         * tui/tui-layout.c (show_source_disasm_command, show_data)
5973         (show_source_or_disasm_and_command): Update for bool change.
5974         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5975         (tui_win_info) <has_locator>: New method.
5976         (struct tui_source_window_base) <has_locator>: New method.
5977         (tui_win_has_locator): Don't declare.
5978         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5979         from tui_win_has_locator.
5980         (tui_source_window_base): Use false, not FALSE.
5981
5982 2019-06-25  Tom Tromey  <tom@tromey.com>
5983
5984         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5985         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5986         clear_detail method directly.
5987         (tui_clear_win_detail): Remove.
5988
5989 2019-06-25  Tom Tromey  <tom@tromey.com>
5990
5991         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5992         "this", not TUI_DISASM_WIN.
5993
5994 2019-06-25  Tom Tromey  <tom@tromey.com>
5995
5996         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5997         declare.
5998         * tui/tui-winsource.c
5999         (tui_source_window_base::do_scroll_horizontal): Rename from
6000         tui_horizontal_source_scroll.
6001         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6002         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6003         from tui_vertical_data_scroll.
6004         * tui/tui-win.h (tui_scroll): Don't declare.
6005         * tui/tui-win.c (tui_win_info::forward_scroll)
6006         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6007         (tui_win_info::right_scroll): Rename and update.
6008         (tui_scroll_forward_command, tui_scroll_backward_command)
6009         (tui_scroll_left_command, tui_scroll_right_command): Update.
6010         (tui_scroll): Remove.
6011         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6012         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6013         from tui_vertical_source_scroll.
6014         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6015         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6016         from tui_vertical_disassem_scroll.
6017         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6018         do_scroll_horizontal>: New methods.
6019         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6020         Likewise.
6021         (struct tui_source_window_base): Add do_scroll_horizontal.
6022         (struct tui_source_window, struct tui_disasm_window): Add
6023         do_scroll_vertical.
6024         (struct tui_data_window, struct tui_cmd_window): Add
6025         do_scroll_horizontal and do_scroll_vertical.
6026         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6027
6028 2019-06-25  Tom Tromey  <tom@tromey.com>
6029
6030         * tui/tui-data.h (struct tui_source_window_base): New struct.
6031         (struct tui_source_window): Derive from tui_source_window_base.
6032         (struct tui_disasm_window): New struct.
6033         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6034         from tui_source_window::clear_detail.
6035         (tui_source_window_base): Rename from tui_source_window.
6036         (~tui_source_window_base): Rename from ~tui_source_window.
6037         (tui_alloc_win_info): Create a tui_disasm_window.
6038
6039 2019-06-25  Tom Tromey  <tom@tromey.com>
6040
6041         * tui/tui-data.h (struct tui_source_window)
6042         (struct tui_data_window): Declare destructors.
6043         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6044         destructors.
6045         (tui_win_info): Simplify.
6046
6047 2019-06-25  Tom Tromey  <tom@tromey.com>
6048
6049         * tui/tui-winsource.c (tui_display_main)
6050         (tui_update_source_windows_with_addr)
6051         (tui_update_all_breakpoint_info): Update.
6052         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6053         (new_height_ok, parse_scrolling_args): Update.
6054         * tui/tui-stack.c (tui_show_frame_info): Update.
6055         * tui/tui-data.h (struct tui_list): Remove.
6056         (tui_source_windows): Return a reference to a std::vector.
6057         * tui/tui-data.c (source_windows): Now a std::vector.
6058         (tui_source_windows): Change return type.
6059         (tui_clear_source_windows): Rewrite.
6060         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6061         (tui_free_all_source_wins_content): Rewrite.
6062
6063 2019-06-25  Tom Tromey  <tom@tromey.com>
6064
6065         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6066         (struct tui_data_window, struct tui_cmd_window): Declare
6067         clear_detail method.
6068         * tui/tui-data.c (tui_source_window::clear_detail)
6069         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6070         methods.
6071         (tui_clear_win_detail): Simplify.
6072
6073 2019-06-25  Tom Tromey  <tom@tromey.com>
6074
6075         * tui/tui-layout.c (make_source_window, make_disasm_window)
6076         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6077         Return the new window.
6078         (show_source_disasm_command, show_data)
6079         (show_source_or_disasm_and_command): Update.
6080
6081 2019-06-25  Tom Tromey  <tom@tromey.com>
6082
6083         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6084         parameter.  Return the new window.
6085         (show_source_disasm_command): Update and remove NULL check.
6086         (show_source_or_disasm_and_command): Update.
6087
6088 2019-06-25  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6091
6092 2019-06-25  Tom Tromey  <tom@tromey.com>
6093
6094         * tui/tui-data.h (struct tui_win_info): Make constructor
6095         protected.  Make destructor virtual.  Add initializers.
6096         (tui_source_window, tui_data_window, tui_cmd_window): New
6097         classes.
6098         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6099         constructor.  Add "type" parameter.
6100         (tui_source_window, tui_data_window, tui_cmd_window): New
6101         constructors.
6102         (tui_alloc_win_info): Instantiate the appropriate subclass.
6103
6104 2019-06-25  Tom Tromey  <tom@tromey.com>
6105
6106         * tui/tui-win.c (tui_resize_all): Use delete.
6107         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6108         destructor.
6109         (tui_free_window): Don't declare.
6110         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6111         Update.
6112
6113 2019-06-25  Tom Tromey  <tom@tromey.com>
6114
6115         * tui/tui-data.h (struct tui_win_info): Add constructor.
6116         * tui/tui-data.c (tui_alloc_win_info): Use new.
6117         (tui_free_window): Use delete.
6118
6119 2019-06-22  Tom Tromey  <tom@tromey.com>
6120
6121         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6122         declare.
6123         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6124
6125 2019-06-22  Tom Tromey  <tom@tromey.com>
6126
6127         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6128         declare.
6129         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6130
6131 2019-06-22  Tom de Vries  <tdevries@suse.de>
6132
6133         * dwarf2read.c (create_addrmap_from_aranges)
6134         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6135         instead of '%zu'.
6136
6137 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6138
6139         * dwarf2read.h (dwarf2_section_info_def): Remove.
6140         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6141         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6142         std::vector<dwarf2_section_info>.
6143         (struct dwo_file) <~dwo_file>: Remove.
6144         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6145         types field.
6146         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6147         (dwarf2_read_debug_names): Likewise.
6148         (create_debug_types_hash_table): Change parameter type to
6149         array_view, adjust code accordingly.
6150         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6151         (partial_die_info::fixup): Likewise.
6152         (determine_prefix): Likewise.
6153         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6154
6155 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6156
6157         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6158         gdb_bfd_ref_ptr.
6159         <~dwo_file>: Remove call to gdb_bfd_unref.
6160         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6161         gdb_bfd_ref_ptr::get.
6162
6163 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6164
6165         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6166         type to htab_up.
6167         * dwarf2read.c (struct dwo_file): Initialize fields.
6168         <~dwo_file>: New.
6169         (free_dwo_file): Remove, move content to ~dwo_file.
6170         (struct dwo_file_deleter): Remove.
6171         (dwo_file_up>: Remove custom deleter.
6172         (free_dwo_files): Remove.
6173         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6174         dwo_files.
6175         (process_skeletonless_type_units): Call unique_ptr::get.
6176         (allocate_dwo_file_hash_table): Add deleter to created hash
6177         table.  Change return type to htab_up.
6178         (lookup_dwo_file_slot): Don't memset dwo_file, call
6179         unique_ptr::get.
6180         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6181         (create_dwo_unit_in_dwp_v2): Likewise.
6182         (open_and_init_dwo_file): Likewise.
6183         (free_dwo_file_from_slot): Remove.
6184
6185 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6186
6187         * dwarf2read.h (struct dwarf2_section_info) <readin,
6188         is_virtual>: Change type to bool.
6189         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6190         true instead of 1.
6191
6192 2019-06-19  Tom Tromey  <tom@tromey.com>
6193
6194         * tui/tui-data.h (tui_init_content_element): Don't declare.
6195
6196 2019-06-19  Tom Tromey  <tom@tromey.com>
6197
6198         * tui/tui-data.h (tui_init_win_info): Don't declare.
6199
6200 2019-06-19  Tom de Vries  <tdevries@suse.de>
6201
6202         * dwarf2read.h (abstract_to_concrete): Change type to
6203         std::unordered_map<sect_offset, std::vector<sect_offset>,
6204         gdb::hash_enum<sect_offset>>.
6205
6206 2019-06-19  Tom Tromey  <tromey@adacore.com>
6207
6208         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6209         EVAL_AVOID_SIDE_EFFECTS specially.
6210
6211 2019-06-19  Tom Tromey  <tromey@adacore.com>
6212
6213         * source-cache.c (highlighter): New global.
6214         (source_cache::get_source_lines): Create a highlighter on demand.
6215
6216 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6217
6218         * defs.h (deprecated_interactive_hook): Delete declaration.
6219         * interps.c (clear_interpreter_hooks): Remove use of
6220         deprecated_interactive_hook.
6221         * top.c (deprecated_interactive_hook): Delete definition.
6222         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6223
6224 2019-06-18  Tom de Vries  <tdevries@suse.de>
6225
6226         PR gdb/24515
6227         * dwarf2read.h (abstract_to_concrete): Change type from
6228         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6229         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6230         * dwarf2read.c (read_variable): Update.
6231         (dwarf2_fetch_die_loc_sect_off): Update.
6232
6233 2019-06-17  Tom de Vries  <tdevries@suse.de>
6234
6235         PR gdb/24617
6236         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6237         accessing parent[parent_len - 1].
6238
6239 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6240
6241         PR gdb/24364
6242         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6243         call dtrace_process_dof with NULL dof.
6244
6245 2019-06-16  Tom de Vries  <tdevries@suse.de>
6246
6247         PR gdb/24445
6248         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6249
6250 2019-06-16  Tom Tromey  <tom@tromey.com>
6251
6252         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6253         (make_all_visible): Use address of member.
6254
6255 2019-06-16  Tom Tromey  <tom@tromey.com>
6256
6257         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6258         (tui_free_window, free_content, free_content_elements): Remove
6259         unnecessary cast.
6260         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6261         cast.
6262         * tui/tui-regs.c (tui_show_register_group)
6263         (tui_display_registers_from, tui_display_reg_element_at_line):
6264         Remove unnecessary cast.
6265
6266 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6267
6268         * linux-nat.c (normal_mask): Delete.
6269         (_initialize_linux_nat): Don't initialise normal_mask.
6270
6271 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6272
6273         PR gdb/24445
6274         * dwarf-index-write.h (write_psymtabs_to_index): Add
6275         dwz_basename parameter.
6276         * dwarf-index-write.c (write_gdbindex): Move file writing to
6277         write_gdbindex_1.  Change return type void.
6278         (assert_file_size): Move up, remove filename parameter.
6279         (write_gdbindex_1): New function.
6280         (write_debug_names): Change return type to void, call
6281         assert_file_size.
6282         (struct index_wip_file): New struct.
6283         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6284         file logic to index_wip_file.  Write index for dwz file if
6285         needed.
6286         (save_gdb_index_command): Pass basename of dwz file, if present.
6287         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6288         build-id of dwz file, if present.
6289         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6290         (dwarf2_get_dwz_file): Likewise.
6291         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6292         (dwarf2_get_dwz_file): Likewise.
6293
6294 2019-06-16  Tom Tromey  <tom@tromey.com>
6295
6296         * coffread.c (process_coff_symbol): Use xstrdup.
6297         * value.c (create_internalvar): Use xstrdup.
6298
6299 2019-06-16  Tom Tromey  <tom@tromey.com>
6300
6301         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6302         * breakpoint.c (stopin_command, stopat_command)
6303         (until_break_command, decode_location_default): Remove unnecessary
6304         cast.
6305         * utils.c (subset_compare): Remove unnecessary cast.
6306         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6307         cast.
6308         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6309         cast.
6310         * infcmd.c (path_command): Remove unnecessary cast.
6311         * coffread.c (decode_type): Remove unnecessary cast.
6312         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6313         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6314         * tui/tui-stack.c (tui_show_locator_content)
6315         (tui_show_frame_info): Remove unnecessary cast.
6316         * tui/tui-win.c (tui_scroll_forward_command)
6317         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6318         (parse_scrolling_args): Remove unnecessary cast.
6319         * tui/tui-data.c (init_win_info, tui_del_window)
6320         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6321         (free_content_elements): Remove unnecessary cast.
6322         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6323         unnecessary cast.
6324         * tui/tui-source.c (tui_set_source_content)
6325         (tui_vertical_source_scroll): Remove unnecessary cast.
6326         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6327         cast.
6328         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6329         * tui/tui-regs.c (tui_display_registers_from)
6330         (tui_display_register): Remove unnecessary cast.
6331         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6332         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6333         (make_visible): Remove unnecessary cast.
6334         * tui/tui-winsource.c (tui_erase_source_content)
6335         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6336         unnecessary cast.
6337         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6338         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6339         * stabsread.c (read_type, read_array_type, read_range_type):
6340         Remove unnecessary cast.
6341         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6342         (parse_symbol, parse_type, upgrade_type, parse_external)
6343         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6344         unnecessary cast.
6345         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6346
6347 2019-06-16  Tom Tromey  <tom@tromey.com>
6348
6349         * tui/tui-data.c (tui_alloc_generic_win_info)
6350         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6351         checks.
6352
6353 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6354             Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * f-typeprint.c (f_print_type): Don't return early for not
6357         associated or not allocated types.
6358         (f_type_print_varspec_suffix): Add print_rank parameter and print
6359         ranks of array types in case they dangling.
6360         (f_type_print_base): Add print_rank parameter.
6361
6362 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6363
6364         * NEWS: Mention new MI commands.
6365         * break-catch-throw.c (enum exception_event_kind): Move to
6366         breakpoint.h.
6367         (print_mention_exception_catchpoint): Output text as a single
6368         message.
6369         (catch_exception_command_1): Rename to...
6370         (catch_exception_event): ...this, make non-static, update header
6371         command, and change some parameter types.
6372         (catch_catch_command): Update for changes to
6373         catch_exception_command_1.
6374         (catch_throw_command): Likewise.
6375         (catch_rethrow_command): Likewise.
6376         * breakpoint.c (enum exception_event_kind): Delete.
6377         * breakpoint.h (enum exception_event_kind): Moved here from
6378         break-catch-throw.c.
6379         (catch_exception_event): Declare.
6380         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6381         (mi_cmd_catch_throw): New function.
6382         (mi_cmd_catch_rethrow): New function.
6383         (mi_cmd_catch_catch): New function.
6384         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6385         'catch-catch' entries.
6386         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6387         (mi_cmd_catch_rethrow): Declare.
6388         (mi_cmd_catch_catch): Declare.
6389
6390 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6391
6392         * annotate.c (annotate_source_line): Change return type to void,
6393         update implementation to match.
6394         * annotate.h (annotate_source_line): Change return type to void,
6395         update header comment.
6396         * stack.c (print_frame_info): Don't change what frame information
6397         is printed based on whether annotations are on or not.
6398
6399 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6400
6401         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6402         (annotate_source): Make static.
6403         (annotate_source_line): Moved from source.c and renamed from
6404         identify_source_line.  Update the return type.
6405         * annotate.h (annotate_source): Delete declaration.
6406         (annotate_source_line): Declaration moved from source.h, and
6407         renamed from identify_source_line.  Return type updated.
6408         * source.c (identify_source_line): Moved to annotate.c and renamed
6409         to annotate_source_line.
6410         (info_line_command): Remove check of annotation_level.
6411         * source.h (identify_source_line): Move declaration to annotate.h
6412         and rename to annotate_source_line.
6413         * stack.c: Add 'annotate.h' include.
6414         (print_frame_info): Remove check of annotation_level before
6415         calling annotate_source_line.
6416
6417 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6418
6419         * source-cache.c (source_cache::get_plain_source_lines): Use
6420         open_source_file_with_line_charpos instead of just
6421         open_source_file, remove call to find_source_lines.
6422         (source_cache::get_source_lines): Likewise.
6423         * source.c (find_source_lines): Make static.
6424         (get_filename_and_charpos): Renamed into...
6425         (open_source_file_with_line_charpos): ..this along with changes to
6426         return a scoped_fd, and some other minor clean ups.
6427         (identify_source_line): Use open_source_file_with_line_charpos.
6428         (search_command_helper): Use open_source_file_with_line_charpos
6429         instead of just open_source_file, remove call to
6430         find_source_lines.
6431         * source.h (open_source_file_with_line_charpos): Declare new
6432         function.
6433         (find_source_lines): Delete declaration.
6434
6435 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6436
6437         * source.c (get_filename_and_charpos): Remove fullname
6438         parameter.
6439         (identify_source_line): Update call to get_filename_and_charpos.
6440
6441 2019-06-14  Tom Tromey  <tromey@adacore.com>
6442
6443         PR gdb/24502:
6444         * ui-style.h (skip_ansi_escape): Update comment.
6445         * ui-file.h (class no_terminal_escape_file): New class.
6446         * ui-file.c (no_terminal_escape_file::write)
6447         (no_terminal_escape_file::puts): New methods.
6448         * cli/cli-logging.c (handle_redirections): Use
6449         no_terminal_escape_file.
6450
6451 2019-06-14  Tom Tromey  <tromey@adacore.com>
6452
6453         * NEWS: Move convenience variable news above Python news.
6454
6455 2019-06-14  Tom Tromey  <tom@tromey.com>
6456
6457         * gnulib: Move directory to top-level.
6458         * configure.ac: Don't configure gnulib.
6459         * configure: Rebuild.
6460         * common/common-defs.h: Use new path to gnulib.
6461         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6462         (GNULIB_H): Remove.
6463         (INCGNU): Look in new gnulib location.
6464         (HFILES_NO_SRCDIR): Remove gnulib files.
6465         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6466         (generated_files): Remove GNULIB_H.
6467         ($(LIBGNU), all-lib): Remove targets.
6468         (distclean): Don't mention GNULIB_BUILDDIR.
6469         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6470
6471 2019-06-14  Tom Tromey  <tromey@adacore.com>
6472
6473         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6474         Warn if symbol file does not provide any symbols.
6475
6476 2019-06-14  Tom Tromey  <tromey@adacore.com>
6477
6478         * source.c (find_and_open_source): Respect basenames_may_differ.
6479
6480 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6481
6482         * annotate.c (annotate_breakpoints_invalid): Make use of
6483         scoped_restore_terminal_state.
6484         (annotate_frames_invalid): Likewise.
6485
6486 2019-06-14  Tom Tromey  <tromey@adacore.com>
6487
6488         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6489         allow assignment to an internalvar.
6490
6491 2019-06-14  Tom Tromey  <tromey@adacore.com>
6492
6493         * ada-lex.l: Allow "_" in attribute names.
6494
6495 2019-06-14  Tom Tromey  <tromey@adacore.com>
6496
6497         PR gdb/24653:
6498         * regcache.c (registers_changed): Don't call alloca.
6499         * top.c (execute_command): Don't call alloca.
6500
6501 2019-06-13  Pedro Alves  <palves@redhat.com>
6502
6503         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6504         'expression'.  When parsing an expression, error out if there's
6505         junk after "unlimited".
6506         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6507         (do_set_command): Adjust calls to is_unlimited_literal.
6508
6509 2019-06-13  Pedro Alves  <palves@redhat.com>
6510
6511         * compile/compile.c (make_compile_options_def_group): Add braces
6512         around array_view initializer.
6513         * thread.c (make_thread_apply_all_options_def_group)
6514         (make_thread_apply_all_options_def_group): Likewise.
6515
6516 2019-06-13  Pedro Alves  <palves@redhat.com>
6517
6518         * NEWS (New commands): Mention "maint test-options
6519         require-delimiter", "maint test-options unknown-is-error", "maint
6520         test-options unknown-is-operand" and "maint show
6521         test-options-completion-result".
6522         (New command options, command completion): New section.
6523         (Completion improvements): New section.
6524         Mention that you can abbreviate "unlimited".
6525
6526 2019-06-13  Pedro Alves  <palves@redhat.com>
6527
6528         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6529         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6530         * unittests/cli-utils-selftests.c (test_parse_flags)
6531         (test_parse_flags_qcs): Delete.
6532         (test_cli_utils): Don't call deleted functions.
6533
6534 2019-06-13  Pedro Alves  <palves@redhat.com>
6535
6536         * thread.c: Include "cli/cli-option.h".
6537         (tp_array_compar_ascending): Global.
6538         (tp_array_compar): Delete function.
6539         (tp_array_compar_ascending, tp_array_compar_descending): New
6540         functions.
6541         (ascending_option_def, qcs_flag_option_def)
6542         (thr_qcs_flags_option_defs)
6543         (make_thread_apply_all_options_def_group)
6544         (make_thread_apply_options_def_group): New.
6545         (thread_apply_all_command): Use gdb::option::process_options.
6546         (thread_apply_command_completer)
6547         (thread_apply_all_command_completer): New.
6548         (thread_apply_command): Use gdb::option::process_options.
6549         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6550         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6551         to generate help text of "thread apply".  Adjust "taas"'s help.
6552         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6553         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6554
6555 2019-06-13  Pedro Alves  <palves@redhat.com>
6556
6557         * thread.c (thread_apply_command): Check for invalid TID with
6558         isdigit instead of !isalpha.
6559
6560 2019-06-13  Pedro Alves  <palves@redhat.com>
6561
6562         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6563         (validate_flags_qcs): New.
6564         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6565         (validate_flags_qcs): Declare.
6566         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6567         (make_frame_apply_options_def_group): New.
6568         (frame_apply_command_count): Process options with
6569         gdb::option::process_options.
6570         (frame_apply_completer): New.
6571         (frame_apply_level_completer, frame_apply_all_completer)
6572         (frame_apply_completer): New.
6573         (_initialize_stack): Update help of "frame apply", "frame apply
6574         level", "frame apply all" and "faas" to mention supported options
6575         and install command completers.
6576         * stack.h (frame_apply_all_completer): Declare.
6577         * thread.c: Include "stack.h".
6578         (tfaas_command): Add "--".
6579         (_initialize_thread): Update help "tfaas" to mention supported
6580         options and install command completer.
6581
6582 2019-06-13  Pedro Alves  <palves@redhat.com>
6583
6584         * completer.c (complete_nested_command_line): New.
6585         (gdb_completion_word_break_characters_throw): Add assertion.
6586         * completer.h (complete_nested_command_line): Declare.
6587
6588 2019-06-13  Pedro Alves  <palves@redhat.com>
6589
6590         * stack.c (parse_backtrace_qualifiers): New.
6591         (backtrace_command): Use it.
6592         (backtrace_command_completer): Complete on qualifiers.
6593
6594 2019-06-13  Pedro Alves  <palves@redhat.com>
6595
6596         * frame.c: Include "cli/cli-option.h.
6597         (user_set_backtrace_options): New.
6598         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6599         Delete.
6600         (get_prev_frame): Adjust.
6601         (boolean_option_def, uinteger_option_def)
6602         (set_backtrace_option_defs): New.
6603         (_initialize_frame): Adjust and use
6604         gdb::option::add_setshow_cmds_for_options to install "set
6605         backtrace past-main" and "set backtrace past-entry".
6606         * frame.h: Include "cli/cli-option.h".
6607         (struct frame_print_options): Forward declare.
6608         (print_frame_arguments_all, print_frame_arguments_scalars)
6609         (print_frame_arguments_none): Declare.
6610         (print_entry_values): Delete declaration.
6611         (struct frame_print_options, user_frame_print_options): New.
6612         (struct set_backtrace_options): New.
6613         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6614         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6615         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6616         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6617         (list_args_or_locals): Add frame_print_options parameter.
6618         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6619         * python/py-framefilter.c (enumerate_args): Pass down
6620         USER_FRAME_PRINT_OPTIONS.
6621         * stack.c: Include "cli/cli-option.h".
6622         (print_frame_arguments_all, print_frame_arguments_scalars)
6623         (print_frame_arguments_none): Declare.
6624         (print_raw_frame_arguments, print_entry_values): Delete.
6625         (user_frame_print_options): New.
6626         (boolean_option_def, enum_option_def, frame_print_option_defs):
6627         New.
6628         (struct backtrace_cmd_options): New.
6629         (bt_flag_option_def): New.
6630         (backtrace_command_option_defs): New.
6631         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6632         (print_frame_arg, read_frame_arg, print_frame_args)
6633         (print_frame_info, print_frame): Add frame_print_options parameter
6634         and use it.
6635         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6636         (backtrace_command_1): Add frame_print_options and
6637         backtrace_cmd_options parameters and use them.
6638         (make_backtrace_options_def_group): New.
6639         (backtrace_command): Process command options with
6640         gdb::option::process_options.
6641         (backtrace_command_completer): New.
6642         (_initialize_stack): Extend "backtrace"'s help to mention
6643         supported options.  Install completer for "backtrace".
6644         Install some settings commands with add_setshow_cmds_for_options.
6645
6646 2019-06-13  Pedro Alves  <palves@redhat.com>
6647
6648         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6649         and that "set/show print raw frame-arguments" are now deprecated.
6650
6651         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6652         command.
6653         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6654         * stack.c (_initialize_stack): Install "set/show print
6655         raw-frame-arguments", and deprecate "set/show print raw
6656         frame-arguments".
6657         * valprint.c (_initialize_valprint): Deprecate "set/show print
6658         raw".
6659
6660 2019-06-13  Pedro Alves  <palves@redhat.com>
6661
6662         * compile/compile.c (struct compile_options): New.
6663         (compile_flag_option_def, compile_command_option_defs)
6664         (make_compile_options_def_group): New.
6665         (compile_file_command): Handle options with
6666         gdb::option::process_options.
6667         (compile_file_command_completer): New function.
6668         (compile_code_command): Handle options with
6669         gdb::option::process_options.
6670         (compile_code_command_completer): New function.
6671         (_initialize_compiler): Install completers for "compile code" and
6672         "compile file".  Mention available options in "compile code" and
6673         "compile code"'s help.
6674         * completer.c (advance_to_completion_word): New, factored out from
6675         ...
6676         (advance_to_expression_complete_word_point): ... this.
6677         (advance_to_filename_complete_word_point): New.
6678         * completer.h (advance_to_filename_complete_word_point): New
6679         declaration.
6680
6681 2019-06-13  Pedro Alves  <palves@redhat.com>
6682
6683         * compile/compile.c: Include "cli/cli-option.h".
6684         (compile_print_value): Scope data pointer is now a
6685         value_print_options pointer; adjust.
6686         (compile_print_command): Process options.  Scope data pointer is
6687         now a value_print_options pointer; adjust.
6688         (_initialize_compile): Update "compile print"'s help to include
6689         supported options.  Install a completer for "compile print".
6690         * cp-valprint.c (show_vtblprint, show_objectprint)
6691         (show_static_field_print): Delete.
6692         (_initialize_cp_valprint): Don't install "set print
6693         static-members", "set print vtbl", "set print object" here.
6694         * printcmd.c: Include "cli/cli-option.h" and
6695         "common/gdb_optional.h".
6696         (print_command_parse_format): Rework to fill in a
6697         value_print_options instead of a format_data.
6698         (print_value): Change parameter type from format_data pointer to
6699         value_print_options reference.  Adjust.
6700         (print_command_1): Process options.  Adjust to pass down a
6701         value_print_options.
6702         (print_command_completer): New.
6703         (_initialize_printcmd): Install print_command_completer as
6704         handle_brkchars completer for the "print" command.  Update
6705         "print"'s help to include supported options.
6706         * valprint.c: Include "cli/cli-option.h".
6707         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6708         here from cp-valprint.c.
6709         (boolean_option_def, uinteger_option_def)
6710         (value_print_option_defs, make_value_print_options_def_group):
6711         New.  Use gdb::option::add_setshow_cmds_for_options to install
6712         "set print elements", "set print null-stop", "set print repeats",
6713         "set print pretty", "set print union", "set print array", "set
6714         print address", "set print symbol", "set print array-indexes".
6715         * valprint.h: Include <string> and "cli/cli-option.h".
6716         (make_value_print_options_def_group): Declare.
6717         (print_value): Change parameter type from format_data pointer to
6718         value_print_options reference.
6719         (print_command_completer): Declare.
6720
6721 2019-06-13  Pedro Alves  <palves@redhat.com>
6722
6723         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6724         (COMMON_SFILES): Add maint-test-settings.c.
6725         * cli/cli-decode.c (boolean_enums): New global, factored out from
6726         ...
6727         (add_setshow_boolean_cmd): ... here.
6728         * cli/cli-decode.h (boolean_enums): Declare.
6729         * cli/cli-option.c: New file.
6730         * cli/cli-option.h: New file.
6731         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6732         factored out from ...
6733         (parse_cli_boolean_value(const char *)): ... this.
6734         (is_unlimited_literal): Change parameter type to pointer to
6735         pointer.  Adjust and advance ARG pointer.
6736         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6737         (parse_cli_var_enum): New, factored out from ...
6738         (do_set_command): ... this.  Adjust.
6739         * cli/cli-setshow.h (parse_cli_boolean_value)
6740         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6741         (parse_cli_var_enum): Declare.
6742         * cli/cli-utils.c: Include "cli/cli-option.h".
6743         (get_ulongest): New.
6744         * cli/cli-utils.h (get_ulongest): Declare.
6745         (check_for_argument): New overloads.
6746         * maint-test-options.c: New file.
6747
6748 2019-06-13  Pedro Alves  <palves@redhat.com>
6749
6750         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6751         parse a range if "-" is at the end of the string.
6752
6753 2019-06-13  Pedro Alves  <palves@redhat.com>
6754
6755         * cli/cli-setshow.c (parse_auto_binary_operation)
6756         (parse_cli_boolean_value): Don't allow "o".
6757
6758 2019-06-13  Pedro Alves  <palves@redhat.com>
6759
6760         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6761         * NEWS: Mention maint test-settings KIND.
6762         * maint-test-settings.c: New file.
6763
6764 2019-06-13  Pedro Alves  <palves@redhat.com>
6765
6766         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6767         completer.
6768         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6769         "set" completers.
6770
6771 2019-06-13  Pedro Alves  <palves@redhat.com>
6772
6773         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6774         after item.
6775
6776 2019-06-13  Pedro Alves  <palves@redhat.com>
6777
6778         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6779
6780 2019-06-13  Pedro Alves <palves@redhat.com>
6781
6782         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6783         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6784         call.
6785         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6786         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6787         calls.
6788         (check_for_argument): Skip spaces after argument.
6789
6790 2019-06-13  Pedro Alves  <palves@redhat.com>
6791
6792         * thread.c (thread_apply_command): Adjust TID parsing.
6793         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6794         detected before end of string.
6795         (tid_is_in_list): Error out if LIST is invalid.
6796
6797 2019-06-13  Pedro Alves  <palves@redhat.com>
6798
6799         * completer.c (complete_line_internal_1): Rewind completion word
6800         point.
6801         (completion_tracker::advance_custom_word_point_by): Change
6802         parameter type to int.
6803         * completer.h (completion_tracker::advance_custom_word_point_by):
6804         Likewise.
6805
6806 2019-06-13  Pedro Alves  <palves@redhat.com>
6807
6808         * completer.c (advance_to_completion_word): Handle delimiters.
6809
6810 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6811
6812         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6813
6814 2019-06-11  Tom Tromey  <tom@tromey.com>
6815
6816         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6817         (xmalloc_failed): Move to alloc.c.
6818         * alloc.c: New file.
6819         * Makefile.in (COMMON_SFILES): Add alloc.c.
6820
6821 2019-06-11  Tom Tromey  <tom@tromey.com>
6822
6823         * nat/linux-waitpid.c: Don't include server.h.
6824         (linux_debug): Remove.
6825         (my_waitpid): Update.
6826
6827 2019-06-11  Tom Tromey  <tromey@adacore.com>
6828
6829         * infcall.c (_initialize_infcall): Remove trailing newline from
6830         help.
6831         * user-regs.c (_initialize_user_regs): Remove trailing newline
6832         from help.
6833         * typeprint.c (_initialize_typeprint): Remove trailing newline
6834         from help.
6835         * reverse.c (_initialize_reverse): Remove trailing newlines from
6836         help.
6837         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6838         from help.
6839         * language.c (add_set_language_command): Remove trailing newline
6840         from help.
6841         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6842         help.
6843         * disasm.c (_initialize_disasm): Remove trailing newline from
6844         help.
6845         * top.c (init_main): Remove trailing newline from help.
6846         * interps.c (_initialize_interpreter): Remove trailing newline
6847         from help.
6848         * btrace.c (_initialize_btrace): Remove trailing newlines from
6849         help.
6850         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6851         from help.
6852         * python/python.c (_initialize_python): Remove trailing newline
6853         from help.
6854         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6855         help.
6856         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6857         from help.  Reformat some text.
6858         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6859         from help.
6860         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6861         newline from help.
6862
6863 2019-06-11  Tom Tromey  <tromey@adacore.com>
6864
6865         * darwin-nat.c (darwin_decode_exception_message)
6866         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6867
6868 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6869
6870         * valops.c (value_slice): Check for not allocated or not
6871         associated values.
6872
6873 2019-06-10  Tom de Vries  <tdevries@suse.de>
6874
6875         PR gdb/24618
6876         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6877         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6878         invalid.
6879
6880 2019-06-10  Tom de Vries  <tdevries@suse.de>
6881
6882         PR gdb/24611
6883         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6884         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6885
6886 2019-06-10  Tom de Vries  <tdevries@suse.de>
6887
6888         PR symtab/24545
6889         * symtab.c (struct demangled_name_entry): Add language field.
6890         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6891         static minimal symbol".  Set and use language field.
6892
6893 2019-06-10  Tom Tromey  <tromey@adacore.com>
6894
6895         * ada-lang.c (_initialize_ada_language): Update help text.
6896
6897 2019-06-10  Tom Tromey  <tromey@adacore.com>
6898
6899         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6900         with a newline.
6901         * guile/guile.c (handle_boot_error): Don't end warning with a
6902         newline.
6903         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6904         warning with a newline.
6905         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6906         newline.
6907         (s12z_frame_cache): Likewise.
6908         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6909         a newline.
6910         * solib-svr4.c (disable_probes_interface): Don't end warning with
6911         a newline.
6912         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6913         newline.
6914         * python/python.c (do_finish_initialization): Don't end warning
6915         with a newline.
6916
6917 2019-06-10  Tom Tromey  <tom@tromey.com>
6918
6919         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6920         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6921         gdbpy_enter.
6922
6923 2019-06-10  Tom Tromey  <tromey@adacore.com>
6924
6925         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6926         data.
6927         (elf_new_init): Don't call stabsread_new_init.
6928         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6929         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6930         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6931
6932 2019-06-10  Tom de Vries  <tdevries@suse.de>
6933
6934         PR symtab/16264
6935         PR symtab/24517
6936         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6937
6938 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6939
6940         * source.c (find_and_open_source): Also rewrite relative file
6941         names.
6942
6943 2019-04-26  Amos Bird  <amosbird@gmail.com>
6944
6945         * annotate.c (annotate_thread_exited): Add "thread-exited"
6946         annotation.
6947
6948 2019-06-06  Tom Tromey  <tromey@adacore.com>
6949
6950         * maint.h (class scoped_command_stats): Use
6951         DISABLE_COPY_AND_ASSIGN.
6952         <print_time>: New method.
6953         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6954         print_time.
6955         (scoped_command_stats::print_time): New method.
6956
6957 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6958
6959         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6960         instructions of lengths 6 or 8 bytes.
6961
6962 2019-06-04  Pedro Alves  <palves@redhat.com>
6963
6964         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6965
6966         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6967         * breakpoint.c (condition_completer): Likewise.
6968         * cli/cli-dump.c (scan_expression): Likewise.
6969         * common/filestuff.c (mkdir_recursive): Likewise.
6970         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6971         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6972         (gdb_abspath): Likewise.
6973         * compile/compile-cplus-types.c
6974         (compile_cplus_instance::decl_name): Likewise.
6975         * completer.c (complete_explicit_location):
6976         (signal_completer, reg_or_group_completer_1): Likewise.
6977         * cp-support.c (cp_remove_params_if_any): Likewise.
6978         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6979         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6980         * infcmd.c (strip_bg_char): Likewise.
6981         * linespec.c (copy_token_string): Likewise.
6982         * mi/mi-main.c (output_cores): Likewise.
6983         * psymtab.c (psymtab_search_name):
6984         * symfile.c (test_set_ext_lang_command): Likewise.
6985         * target.c (target_fileio_read_stralloc): Likewise.
6986         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6987         * value.c (complete_internalvar): Likewise.
6988
6989 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6990
6991         Add objfile property to gdb.Type.
6992         * NEWS: Mention Python API addition.
6993         * python/py-type.c (typy_get_objfile): New method.
6994
6995 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6996
6997         * NEWS: Mention the new set|show style [title|highlight].
6998         Mention changes to "show style", "help" and "apropos".
6999
7000 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7001
7002         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7003         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7004         instead of print_help_for_command.
7005         (print_doc_of_command): New function.
7006         (help_list): Add 'apropos -v word' suggestion.
7007         (print_help_for_command): Style the command name using title style.
7008         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7009         (_initialize_cli_cmds): Describe -v in apropos_command help.
7010
7011 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7012
7013         * cli/cli-style.h (cli_style_option): Add name in constructor,
7014         add m_name class member, add constructor with intensity,
7015         add name class function.
7016         (cli_style_option::add_setshow_commands): Remove name argument.
7017         (highlight_style, title_style): New styles.
7018         * cli/cli-style.c (do_show): New function that shows a style
7019         characteristic styling the style name with itself.
7020         (set_style_name): New function.
7021         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7022         Update all callers according to the changes in cli/cli-style.h.
7023         * utils.h (fputs_highlighted): New function.
7024         * utils.c (fputs_highlighted): Likewise.
7025
7026 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7027
7028         * NEWS: Mention new pipe command and new convenience variables.
7029
7030 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7031
7032         * cli/cli-cmds.c (pipe_command): New function.
7033         (_initialize_cli_cmds): Call add_com for pipe_command.
7034         Define | as an alias for pipe.
7035         (exit_status_set_internal_vars): New function.
7036         (shell_escape): Call exit_status_set_internal_vars.
7037         cli/cli-decode.c (find_command_name_length): Recognize | as
7038         a single character command.
7039
7040 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7041
7042         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7043         top.c (execute_command_to_ui_file): New function, mostly a copy
7044         of execute_command_to_string.
7045         (execute_command_to_string): Implement by calling
7046         execute_command_to_ui_file.
7047
7048 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7049
7050         * top.h (saved_command_line): Remove declaration.
7051         * top.c (previous_saved_command_line, previous_repeat_arguments):
7052         New variables.
7053         (saved_command_line): Make static, define together with other
7054         'repeat variables'.
7055         (dont_repeat): Clear repeat_arguments.
7056         (repeat_previous, get_saved_command_line, save_command_line):
7057         New functions.
7058         (gdb_init): Initialize saved_command_line
7059         and previous_saved_command_line.
7060         * main.c (captured_main_1): Remove saved_command_line initialization.
7061         * event-top.c (handle_line_of_input): Update to use
7062         the new 'repeat' related functions instead of direct access to
7063         saved_command_line.
7064         * command.h (repeat_previous, get_saved_command_line,
7065         save_command_line): New declarations.
7066         (dont_repeat): Add comment.
7067
7068 2019-05-30  Tom Tromey  <tromey@adacore.com>
7069
7070         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7071         Fix comment.
7072         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7073
7074 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7075
7076         PR cli/24587
7077         * completer.c (complete): Initialize variable word.
7078
7079 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7080
7081         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7082         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7083         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7084         'body' is NULL to the outter 'if', protecting the '!is_define'
7085         situation as well.
7086
7087 2019-05-29  Tom Tromey  <tromey@adacore.com>
7088
7089         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7090         (dwarf_unknown): New function.
7091         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7092         (dwarf_type_encoding_name): Use dwarf_unknown.
7093
7094 2019-05-29  Tom Tromey  <tromey@adacore.com>
7095
7096         PR c++/20020:
7097         * cp-valprint.c (cp_print_value_fields): Call
7098         cp_print_static_field inside "try".
7099
7100 2019-05-29  Tom Tromey  <tromey@adacore.com>
7101
7102         * inflow.c (struct terminal_info): Add default operator=.
7103         * configure: Rebuild.
7104         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7105         -Wdeprecated-copy-dtor, -Wredundant-move.
7106
7107 2019-05-29  Tom Tromey  <tromey@adacore.com>
7108
7109         * NEWS: Add entry.
7110         * infcmd.c (print_return_value_1): Handle finish_print
7111         option.
7112         (show_print_finish): New function.
7113         (_initialize_infcmd): Add "set/show print finish" commands.
7114         * valprint.c (user_print_options): Initialize new member.
7115         * valprint.h (struct value_print_options) <finish_print>: New
7116         member.
7117
7118 2019-05-28  Tom Tromey  <tromey@adacore.com>
7119
7120         * ada-lang.c (ada_remove_Xbn_suffix)
7121         (find_old_style_renaming_symbol)
7122         (parse_old_style_renaming): Remove.
7123         (ada_find_renaming_symbol): Don't call
7124         find_old_style_renaming_symbol.
7125         (ada_is_renaming_symbol): Rename from
7126         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7127         bool.  Now static.
7128         (ada_read_var_value): Update and simplify.
7129         * ada-exp.y (write_var_or_type): Remove old code.
7130
7131 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7132
7133         PR gdb/25010
7134         * event-top.c: Remove include comment.
7135         * inflow.c (class scoped_ignore_sigttou): Move from here...
7136         * inflow.h (class scoped_ignore_sigttou): ...to here.
7137         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7138         * top.c:  Remove include comment.
7139
7140 2019-05-27  Tom Tromey  <tom@tromey.com>
7141
7142         * NEWS: Fix typo.
7143
7144 2019-05-22  Tom Tromey  <tromey@adacore.com>
7145
7146         * target.c (target_follow_exec): Constify parameter.
7147         * target-delegates.c: Rebuild.
7148         * remote.c (remote_target::follow_exec): Constify parameter.
7149         * infrun.c (follow_exec): Constify parameter.
7150         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7151         (target_follow_exec): Likewise.
7152
7153 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7154
7155         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7156         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7157
7158 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7159
7160         * NEWS: Add debugredirect and testsuite sections.
7161
7162 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7163
7164         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7165         target descriptions using exclusively floating point register name
7166         aliases.
7167
7168 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7169
7170         PR gdb/18644:
7171         * f-lang.c (build_fortran_types): Handle the case where
7172         gdbarch_floatformat_for_type returns a nullptr.
7173
7174 2019-05-21  Tom de Vries  <tdevries@suse.de>
7175
7176         PR cli/24587
7177         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7178
7179 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7180
7181         PR gdb/18644:
7182         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7183         16-byte floats.
7184         * i386-tdep.c (i386_floatformat_for_type): Use
7185         floatformats_ia64_quad for the 16-byte floating point component
7186         within a fortran 32-byte complex number.
7187
7188 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7189
7190         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7191         delete default constructor.
7192         (find_partial_die): Update to return const struct.
7193         (partial_die_parent_scope): Move variable declaration into scope
7194         of its use and change its type to auto.
7195         (guess_partial_die_structure_name): Likewise.
7196         (partial_die_info::fixup): Likewise.
7197
7198 2019-05-17  Tom Tromey  <tromey@adacore.com>
7199
7200         * source.c (find_and_open_source): Remove cast.
7201
7202 2019-05-17  Tom Tromey  <tromey@adacore.com>
7203
7204         * annotate.c (annotate_source): Make "filename" const.
7205         * annotate.h (annotate_source): Use const.
7206
7207 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7208
7209         * disasm.c (set_disassembler_options): Send errors to stderr.
7210
7211 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7212
7213         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7214         (cli_interp_base::set_logging): Check debug_redirect.
7215         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7216         * cli/cli-logging.c (debug_redirect): Add static variable.
7217         (pop_output_files): Add default param.
7218         (handle_redirections): Print debug setting.
7219         (show_logging_command): Likewise.
7220         (_initialize_cli_logging): Add debugredirect command.
7221         * interps.c (current_interp_set_logging): Add debug_redirect
7222         parameter.
7223         * interps.h (set_logging): Add debug_redirect parameter.
7224         (current_interp_set_logging): Likewise.
7225         * mi/mi-common.h: Likewise.
7226         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7227
7228 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7229             Tom Tromey  <tromey@adacore.com>
7230
7231         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7232         directly.
7233         * cli/cli-interp.h (make_logging_output): Remove declaration.
7234         * cli/cli-logging.c (make_logging_output): Remove function.
7235         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7236         directly.
7237         * ui-file.c (tee_file::tee_file): Remove bools.
7238         (tee_file::~tee_file): Remove deletes.
7239         * ui-file.h (tee_file): Remove bools.
7240
7241 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7242
7243         * mi/mi-cmds.h (mi_cmd_complete): New function.
7244         * mi/mi-main.c (mi_cmd_complete): Likewise.
7245         * mi/mi-cmds.c: Define new MI command -complete.
7246         * NEWS: Mention new -complete command.
7247
7248 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7249
7250         * completer.h (complete): New function.
7251         * completer.c (complete): Likewise.
7252         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7253         function defined in completer.h.
7254
7255 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7256
7257         * MAINTAINERS (Write After Approval): Add myself.
7258
7259 2019-05-17  Tom de Vries  <tdevries@suse.de>
7260
7261         PR gdb/24094
7262         * dwarf2read.c (struct cu_partial_die_info): New struct.
7263         (find_partial_die): Return cu_partial_die_info.
7264         (partial_die_parent_scope, guess_partial_die_structure_name)
7265         (partial_die_info::fixup): Handle new return type of find_partial_die.
7266
7267 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7268
7269         PR breakpoints/24541
7270         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7271         "std::string", simplifying the algorithm.
7272
7273 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7274
7275         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7276         (stap_static_probe_ops::get_probes): Likewise.
7277
7278 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7279
7280         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7281         '-')" and "else if".
7282         (stap_parse_single_operand): Join checks for
7283         "gdbarch_stap_parse_special_token_p" and
7284         "gdbarch_stap_parse_special_token" in the same "if" statement.
7285         Invert check when verifying for operation on register
7286         displacement.
7287
7288 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7289
7290         * stap-probe.c (stap_get_opcode): Update comment.
7291         (stap_get_expected_argument_type): Likewise.
7292         (handle_stap_probe): Likewise.
7293
7294 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7295
7296         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7297         return type to 'bool'.  Adjust comment.  Use 'bool' when
7298         appropriate.
7299         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7300         * stap-probe.c (stap_parse_argument_1): Likewise.
7301         (stap_is_operator): Likewise.
7302         (stap_is_generic_prefix): Likewise.
7303         (stap_is_register_prefix): Likewise.
7304         (stap_is_register_indirection_prefix): Likewise.
7305         (stap_is_integer_prefix): Likewise.
7306         (stap_generic_check_suffix): Likewise.
7307         (stap_check_integer_suffix): Likewise.
7308         (stap_check_register_suffix): Likewise.
7309         (stap_check_register_indirection_suffix): Likewise.
7310         (stap_parse_register_operand): Likewise.
7311         (stap_parse_single_operand): Likewise.
7312         (stap_parse_argument_1): Likewise.
7313         (stap_probe::get_argument_count): Likewise.
7314         (stap_is_operator): Likewise.
7315
7316 2019-05-16  Tom Tromey  <tromey@adacore.com>
7317
7318         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7319         keyword to foreach.
7320
7321 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7322
7323         * linux-thread-db.c (try_thread_db_load_1): Change return type
7324         to bool.
7325         (try_thread_db_load): Likewise.
7326         (try_thread_db_load_from_pdir_1): Likewise.
7327         (try_thread_db_load_from_pdir): Likewise.
7328         (try_thread_db_load_from_sdir): Likewise.
7329         (try_thread_db_load_from_dir): Likewise.
7330         (thread_db_load_search): Likewise.
7331         (has_libpthread): Likewise.
7332         (thread_db_load): Likewise.
7333
7334 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7335
7336         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7337         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7338         NULL, and complain/return if that's the case.
7339
7340 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7341
7342         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7343         (advance, posn, abstract_read_memory): New functions.
7344         [struct mem_read_abstraction]: New struct.
7345         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7346
7347 2019-05-14  Tom Tromey  <tromey@adacore.com>
7348
7349         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7350         value is not lval_memory.
7351
7352 2019-05-14  Tom Tromey  <tromey@adacore.com>
7353
7354         * solib.c (info_sharedlibrary_command): Style the file name.
7355
7356 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7357
7358         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7359         (aarch64_vnv_type): Likewise.
7360         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7361         * common/tdesc.c: Likewise.
7362         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7363         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7364         * features/aarch64-fpu.xml: Add ieee half view.
7365         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7366         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7367         * gdbtypes.h (struct builtin_type): Likewise.
7368         (struct objfile_type): Likewise.
7369
7370 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7371
7372         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7373         typo.
7374         * location.h (string_to_event_location): Likewise.
7375
7376 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7377
7378         GDB 8.3 released.
7379
7380 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7381
7382         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7383         New variable declaration.
7384         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7385         New variable.
7386         (print_one_breakpoint): Use ui_out::test_flags and new global
7387         variable to compute use_fixed_output.
7388         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7389         Remove.
7390         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7391         (mi_multi_location_breakpoint_output_fixed): Remove.
7392         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7393         new variable.
7394         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7395         fix_multi_location_breakpoint_output flag if version >= 3.
7396         * ui-out.h (enum ui_out_flag)
7397         <fix_multi_location_breakpoint_output>: New enumerator.
7398
7399 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7400
7401         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7402
7403 2019-05-10  Tom Tromey  <tromey@adacore.com>
7404
7405         * ada-lang.c (catch_ada_completer): New function.
7406         (_initialize_ada_language): Use it.
7407
7408 2019-05-10  Tom Tromey  <tromey@adacore.com>
7409
7410         * thread.c (print_thread_info): Make "requested_threads" const.
7411         * gdbthread.h (print_thread_info): Make "requested_threads"
7412         const.
7413         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7414         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7415
7416 2019-05-08  Tom Tromey  <tom@tromey.com>
7417
7418         * gdbtypes.c (objfile_type_data): Change type.
7419         (objfile_type, _initialize_gdbtypes): Update.
7420
7421 2019-05-08  Tom Tromey  <tom@tromey.com>
7422
7423         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7424         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7425         (_initialize_dwarf2_frame): Update.
7426
7427 2019-05-08  Tom Tromey  <tom@tromey.com>
7428
7429         * objc-lang.c (objc_objfile_data): Change type.
7430         (find_methods): Update.
7431         (_initialize_objc_lang): Remove.
7432
7433 2019-05-08  Tom Tromey  <tom@tromey.com>
7434
7435         * stabsread.c (rs6000_builtin_type_data): Change type.
7436         (rs6000_builtin_type, _initialize_stabsread): Update.
7437
7438 2019-05-08  Tom Tromey  <tom@tromey.com>
7439
7440         * mips-tdep.c (mips_pdr_data): Remove.
7441         (_initialize_mips_tdep): Update.
7442
7443 2019-05-08  Tom Tromey  <tom@tromey.com>
7444
7445         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7446         (hppa_init_objfile_priv_data, read_unwind_info)
7447         (find_unwind_entry, _initialize_hppa_tdep): Update.
7448
7449 2019-05-08  Tom Tromey  <tom@tromey.com>
7450
7451         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7452         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7453         on obstack.
7454         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7455
7456 2019-05-08  Tom Tromey  <tom@tromey.com>
7457
7458         * mdebugread.c (basic_type_data): Change type.
7459         (basic_type, _initialize_mdebugread): Update.
7460
7461 2019-05-08  Tom Tromey  <tom@tromey.com>
7462
7463         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7464
7465 2019-05-08  Tom Tromey  <tom@tromey.com>
7466
7467         * nto-tdep.c (nto_inferior_data_reg): Change type.
7468         (nto_inferior_data): Update.
7469         (nto_inferior_data_cleanup, nto_new_inferior_data)
7470         (_initialize_nto_tdep): Remove.
7471         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7472
7473 2019-05-08  Tom Tromey  <tom@tromey.com>
7474
7475         * ada-lang.c (struct ada_inferior_data): Add initializers.
7476         (ada_inferior_data): Change type.
7477         (ada_inferior_data_cleanup): Remove.
7478         (get_ada_inferior_data, ada_inferior_exit)
7479         (struct ada_pspace_data): Add initializers, destructor.
7480         (ada_pspace_data_handle): Change type.
7481         (get_ada_pspace_data): Update.
7482         (ada_pspace_data_cleanup): Remove.
7483
7484 2019-05-08  Tom Tromey  <tom@tromey.com>
7485
7486         * coffread.c (struct coff_symfile_info): Add initializers.
7487         (coff_objfile_data_key): Move lower.  Change type.
7488         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7489         Update.
7490         (coff_free_info): Remove.
7491
7492 2019-05-08  Tom Tromey  <tom@tromey.com>
7493
7494         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7495         (fbsd_pspace_data_handle): Move lower.  Change type.
7496         (get_fbsd_pspace_data): Update.
7497         (fbsd_pspace_data_cleanup): Remove.
7498         (_initialize_fbsd_tdep): Update.
7499
7500 2019-05-08  Tom Tromey  <tom@tromey.com>
7501
7502         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7503         (get_ada_tasks_pspace_data): Update.
7504         (ada_tasks_pspace_data_cleanup): Remove.
7505         (_initialize_tasks): Update.
7506         (ada_tasks_inferior_data_handle): Change type.
7507         (get_ada_tasks_inferior_data): Update.
7508         (ada_tasks_inferior_data_cleanup): Remove.
7509         (struct ada_tasks_pspace_data): Add initializers.
7510
7511 2019-05-08  Tom Tromey  <tom@tromey.com>
7512
7513         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7514         * symfile-debug.c (debug_sym_get_probes): Change type.
7515         * stap-probe.c (handle_stap_probe):
7516         (stap_static_probe_ops::get_probes): Change type.
7517         * probe.h (class static_probe_ops) <get_probes>: Change type.
7518         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7519         (parse_probes_in_pspace): Update.
7520         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7521         Update.
7522         (any_static_probe_ops::get_probes): Change type.
7523         * elfread.c (elfread_data): New typedef.
7524         (probe_key): Change type.
7525         (elf_get_probes): Likewise.  Update.
7526         (probe_key_free): Remove.
7527         (_initialize_elfread): Update.
7528         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7529         Change type.
7530         (dtrace_process_dof_probe, dtrace_process_dof)
7531         (dtrace_static_probe_ops::get_probe): Change type.
7532
7533 2019-05-08  Tom Tromey  <tom@tromey.com>
7534
7535         * xcoffread.c (struct xcoff_symfile_info): Rename from
7536         coff_symfile_info.  Add initializers.
7537         (xcoff_objfile_data_key): Move lower.  Change type.
7538         (XCOFF_DATA): Rewrite.
7539         (xcoff_free_info): Remove.
7540         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7541         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7542         (xcoff_initial_scan): Update.
7543
7544 2019-05-08  Tom Tromey  <tom@tromey.com>
7545
7546         * solib-svr4.c (struct svr4_info): Add initializers and
7547         destructor.
7548         <probes_table>: Now an htab_up.
7549         (solib_svr4_pspace_data): Change type.
7550         (free_probes_table): Simplify.
7551         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7552         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7553         (probes_table_remove_objfile_probes, register_solib_event_probe)
7554         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7555         (_initialize_svr4_solib): Update.
7556
7557 2019-05-08  Tom Tromey  <tom@tromey.com>
7558
7559         * remote.c (remote_pspace_data): Change type.
7560         (remote_pspace_data_cleanup): Remove.
7561         (get_remote_exec_file, set_pspace_remote_exec_file)
7562         (_initialize_remote): Update.
7563
7564 2019-05-08  Tom Tromey  <tom@tromey.com>
7565
7566         * breakpoint.c (breakpoint_objfile_key): Change type.
7567         (get_breakpoint_objfile_data): Update.
7568         (free_breakpoint_objfile_data): Remove.
7569         (_initialize_breakpoint): Update.
7570
7571 2019-05-08  Tom Tromey  <tom@tromey.com>
7572
7573         * linux-tdep.c (struct linux_info): Add initializers.
7574         (linux_inferior_data): Move.  Change type.
7575         (invalidate_linux_cache_inf): Update.
7576         (linux_inferior_data_cleanup): Remove.
7577         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7578
7579 2019-05-08  Tom Tromey  <tom@tromey.com>
7580
7581         * auxv.c (auxv_inferior_data): Move.  Change type.
7582         (auxv_inferior_data_cleanup): Remove.
7583         (invalidate_auxv_cache_inf): Rewrite.
7584         (get_auxv_inferior_data, _initialize_auxv): Update.
7585
7586 2019-05-08  Tom Tromey  <tom@tromey.com>
7587
7588         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7589         (symfile_debug_objfile_data_key): Change type.
7590         (symfile_debug_installed, debug_qf_has_symbols)
7591         (debug_qf_find_last_source_symtab)
7592         (debug_qf_forget_cached_source_info)
7593         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7594         (debug_qf_print_stats, debug_qf_dump)
7595         (debug_qf_expand_symtabs_for_function)
7596         (debug_qf_expand_all_symtabs)
7597         (debug_qf_expand_symtabs_with_fullname)
7598         (debug_qf_map_matching_symbols)
7599         (debug_qf_expand_symtabs_matching)
7600         (debug_qf_find_pc_sect_compunit_symtab)
7601         (debug_qf_map_symbol_filenames)
7602         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7603         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7604         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7605         (debug_sym_read_linetable, debug_sym_relocate): Update.
7606         (symfile_debug_free_objfile): Remove.
7607         (install_symfile_debug_logging, _initialize_symfile_debug):
7608         Update.
7609
7610 2019-05-08  Tom Tromey  <tom@tromey.com>
7611
7612         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7613         allocate_on_obstack.
7614         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7615         (get_dwarf2_per_objfile): Update.
7616         (set_dwarf2_per_objfile): Remove.
7617         (dwarf2_has_info, dwarf2_get_section_info): Update.
7618         (dwarf2_free_objfile): Remove.
7619         (_initialize_dwarf2_read): Update.
7620
7621 2019-05-08  Tom Tromey  <tom@tromey.com>
7622
7623         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7624         initializers.
7625         <unsupported_script_warning_printed,
7626         script_not_found_warning_printed>: Now bool.
7627         (auto_load_pspace_data): Change type.
7628         (~auto_load_pspace_info): Rename from
7629         auto_load_pspace_data_cleanup.
7630         (get_auto_load_pspace_data, init_loaded_scripts_info)
7631         (clear_section_scripts, maybe_print_unsupported_script_warning)
7632         (maybe_print_script_not_found_warning, _initialize_auto_load):
7633         Update.
7634
7635 2019-05-08  Tom Tromey  <tom@tromey.com>
7636
7637         * objfiles.c (objfile_pspace_info): Add destructor and
7638         initializers.
7639         (objfiles_pspace_data): Change type.
7640         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7641         (get_objfile_pspace_data): Update.
7642         (objfiles_bfd_data): Change type.
7643         (get_objfile_bfd_data): Update.
7644         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7645
7646 2019-05-08  Tom Tromey  <tom@tromey.com>
7647
7648         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7649         Change type.
7650         (get_catch_syscall_inferior_data): Update.
7651         (catch_syscall_inferior_data_cleanup): Remove.
7652         (_initialize_break_catch_syscall): Update.
7653
7654 2019-05-08  Tom Tromey  <tom@tromey.com>
7655
7656         * inflow.c (struct terminal_info): Add destructor and
7657         initializers.
7658         (inflow_inferior_data): Change type.
7659         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7660         (get_inflow_inferior_data, inflow_inferior_exit)
7661         (swap_terminal_info, _initialize_inflow): Update.
7662
7663 2019-05-08  Tom Tromey  <tom@tromey.com>
7664
7665         * target-dcache.c (target_dcache_cleanup): Remove.
7666         (target_dcache_aspace_key): Change type.
7667         (target_dcache_init_p, target_dcache_invalidate)
7668         (target_dcache_get, target_dcache_get_or_init)
7669         (_initialize_target_dcache): Update.
7670         * dcache.h (struct dcache_deleter): New.
7671
7672 2019-05-08  Tom Tromey  <tom@tromey.com>
7673
7674         * symtab.c (struct symbol_cache): Add destructor and
7675         initializers.
7676         (symbol_cache_key): Move.  Change type.
7677         (make_symbol_cache, free_symbol_cache): Remove.
7678         (get_symbol_cache): Update.
7679         (symbol_cache_cleanup): Remove.
7680         (ALL_PSPACES, symbol_cache_flush)
7681         (maintenance_print_symbol_cache)
7682         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7683         Update.
7684
7685 2019-05-08  Tom Tromey  <tom@tromey.com>
7686
7687         * symtab.c (struct main_info): Add destructor and initializers.
7688         (main_progspace_key): Move.  Change type.
7689         (get_main_info): Update.
7690         (main_info_cleanup): Remove.
7691         (_initialize_symtab): Update.
7692
7693 2019-05-08  Tom Tromey  <tom@tromey.com>
7694
7695         * registry.h (DECLARE_REGISTRY): Define the _key class.
7696
7697 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * NEWS: Merge two 'New commands' sections.
7700
7701 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7702
7703         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7704         parameter and use Ada language definition instead.
7705         (ada_val_print_ptr): Remove unused language parameter.
7706         (ada_val_print_num): Remove language parameter and use Ada language
7707         definition instead.
7708         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7709         parameter.
7710         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7711         parameter and use Ada language definition instead.
7712         (ada_val_print_1): Update all ada_val_print_xxx calls.
7713         Remove language parameter.
7714         (ada_val_print): Update ada_val_print_1 call.
7715
7716 2019-05-08  Tom Tromey  <tromey@adacore.com>
7717
7718         * remote.c (remote_hw_watchpoint_limit)
7719         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7720         Now static.
7721
7722 2019-05-08  Tom Tromey  <tromey@adacore.com>
7723
7724         * maint.c (_initialize_maint_cmds): Move initialization code to
7725         remote.c.
7726         (watchdog, show_watchdog): Move to remote.c.
7727         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7728         "watchdog" static.
7729         (_initialize_remote): Move initialization code from maint.c.
7730         * defs.h (watchdog): Don't declare.
7731
7732 2019-05-08  Tom Tromey  <tromey@adacore.com>
7733
7734         * tui/tui-interp.c: Include main.h.
7735         * interps.c: Include main.h.
7736         * main.h (interpreter_p): Declare.
7737         * defs.h (interpreter_p): Don't declare.
7738
7739 2019-05-08  Tom Tromey  <tromey@adacore.com>
7740
7741         * dwarf2loc.c: Include dwarf2read.h.
7742         * defs.h (read_unsigned_leb128): Don't declare.
7743         * dwarf2read.h (read_unsigned_leb128): Declare.
7744
7745 2019-05-08  Tom Tromey  <tromey@adacore.com>
7746
7747         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7748         method.
7749
7750 2019-05-08  Tom Tromey  <tromey@adacore.com>
7751
7752         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7753         when no wrap column is set.
7754
7755 2019-05-08  Tom Tromey  <tromey@adacore.com>
7756
7757         * c-lang.c (c_get_string): Handle non-C-style arrays.
7758
7759 2019-05-08  Tom Tromey  <tromey@adacore.com>
7760
7761         * typeprint.c (print_offset_data::update): Print the bit offset,
7762         not the number of bits remaining.
7763
7764 2019-05-08  Tom Tromey  <tromey@adacore.com>
7765
7766         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7767         padding at end of comment.
7768
7769 2019-05-08  Tom Tromey  <tromey@adacore.com>
7770
7771         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7772         Compare main types.
7773
7774 2019-05-06  Tom Tromey  <tom@tromey.com>
7775
7776         * common/scoped_mmap.c: Include common-defs.h.
7777         * common/scoped_mmap.h: Don't include config.h.
7778
7779 2019-05-04  Tom Tromey  <tom@tromey.com>
7780
7781         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7782         (struct aarch64_call_info): Add initializers.
7783         <si>: Now a std::vector.
7784         (pass_on_stack, aarch64_push_dummy_call): Update.
7785
7786 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7787             Tom Tromey  <tom@tromey.com>
7788
7789         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7790         (ppc_threads): Now a std::vector.  Now static.
7791         (hwdebug_find_thread_points_by_tid)
7792         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7793         Update.
7794
7795 2019-05-04  Tom Tromey  <tom@tromey.com>
7796
7797         * arc-tdep.c (arc_tdesc_init): Return bool.
7798
7799 2019-05-04  Tom Tromey  <tom@tromey.com>
7800
7801         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7802         Use gdb_assert_not_reached.
7803
7804 2019-05-04  Tom Tromey  <tom@tromey.com>
7805
7806         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7807         "false".
7808
7809 2019-05-04  Tom Tromey  <tom@tromey.com>
7810
7811         * arc-tdep.c (arc_tdesc_init): Use bool.
7812
7813 2019-05-04  Tom Tromey  <tom@tromey.com>
7814
7815         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7816
7817 2019-05-04  Tom Tromey  <tom@tromey.com>
7818
7819         * cli/cli-cmds.c (valid_command_p): Return bool.
7820
7821 2019-05-04  Tom Tromey  <tom@tromey.com>
7822
7823         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7824         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7825
7826 2019-05-04  Raul Tambre  <raul@tambre.ee>
7827
7828         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7829         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7830         operator for comparison.
7831
7832 2019-05-04  Tom Tromey  <tom@tromey.com>
7833
7834         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7835         (lookup_partial_symbol, print_partial_symbols)
7836         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7837         (psymbol_compare): Update.
7838         (add_psymbol_to_bcache): Clear the entire psymbol.
7839         (maintenance_check_psymtabs): Update.
7840         * psympriv.h (struct partial_symbol): Don't derive from
7841         general_symbol_info.
7842         <obj_section, unrelocated_address, address,
7843         set_unrelocated_address>: Update.
7844         <ginfo>: New member.
7845         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7846         (debug_names::write_psymbols): Update.
7847
7848 2019-05-04  Tom de Vries  <tdevries@suse.de>
7849
7850         * contrib/cc-with-tweaks.sh: Support -n arg.
7851
7852 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7853
7854         * corelow.c (core_target::detach): Ensure frame cache and
7855         register caches are cleared.
7856         inferior.c (exit_inferior_1): Likewise.
7857
7858 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7859             Tom Tromey  <tom@tromey.com>
7860
7861         * dictionary.c (collate_pending_symbols_by_language): Remove
7862         "struct" from foreach.
7863         * symtab.c (lookup_global_symbol_from_objfile)
7864         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7865         foreach.
7866         * ser-tcp.c (net_open): Remove "struct" from foreach.
7867         * objfiles.c (objfile_relocate, objfile_rebase)
7868         (objfile_has_symbols): Remove "struct" from foreach.
7869         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7870         from foreach.
7871         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7872         foreach.
7873         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7874         "struct" from foreach.
7875         * ada-lang.c (create_excep_cond_exprs)
7876         (ada_exception_catchpoint_cond_string): Remove "struct" from
7877         foreach.
7878
7879 2019-05-03  Tom Tromey  <tromey@adacore.com>
7880
7881         * ada-exp.y (convert_char_literal): Check suffix of each
7882         enumerator.
7883
7884 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7885
7886         PR ada/21406:
7887         * ada-exp.y (yywrap): Don't define.
7888         * ada-lex.l (%option): Add noyywrap
7889         (yywrap): Remove.
7890
7891 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7892
7893         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7894         _WIN32_WINNT to the XP level, unless already defined to a higher
7895         level.
7896
7897         * unittests/parse-connection-spec-selftests.c:
7898         * ser-tcp.c:
7899         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7900         override.
7901
7902         * symfile.c (find_separate_debug_file): Remove colon from the
7903         drive spec of DOS/Windows file names of the target, so that the
7904         file name produced from DEBUGDIR and the target's directory will
7905         be valid on DOS/Windows systems.
7906
7907 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7908
7909         * rust-lang.c (val_print_struct): Handle printing structures
7910         containing strings.
7911
7912 2019-05-02  Tom Tromey  <tromey@adacore.com>
7913
7914         * valarith.c (_initialize_valarith): Remove.
7915
7916 2019-05-01  Tom Tromey  <tromey@adacore.com>
7917
7918         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7919         bitfields.
7920
7921 2019-05-01  Tom Tromey  <tromey@adacore.com>
7922
7923         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7924         for big-endian copies.
7925
7926 2019-04-30  Ali Tamur  <tamur@google.com>
7927         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7928         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7929         (read_3_bytes): New function.
7930
7931 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7932
7933         * windows-nat.c (main_thread_id): Delete.
7934         (handle_output_debug_string): Replace main_thread_id by
7935         current_event.dwThreadId.
7936         (fake_create_process): Likewise.
7937         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7938         Do not set main_thread_id.
7939         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7940         current_event.dwThreadId.
7941         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7942
7943 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7944
7945         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7946         Use current_event.dwThreadId instead of main_thread_id.
7947
7948 2019-04-30  Tom Tromey  <tromey@adacore.com>
7949
7950         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7951         (create_excep_cond_exprs): Iterate over program spaces.
7952         (ada_exception_catchpoint_cond_string): Examine all minimal
7953         symbols for exception types.
7954
7955 2019-04-30  Tom Tromey  <tromey@adacore.com>
7956
7957         PR c++/24470:
7958         * dwarf2read.c (process_structure_scope): Handle case where type
7959         has template parameters but no symbol was created.
7960
7961 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7962             Chris January  <chris.january@arm.com>
7963
7964         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7965         qualifier.
7966         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7967
7968 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7969
7970         * f-typeprint.c (f_print_type): Update rules for printing
7971         whitespace.
7972         (f_type_print_varspec_suffix): Likewise.
7973
7974 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7975             Chris January  <chris.january@arm.com>
7976
7977         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7978         function arguments.
7979
7980 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7981
7982         * f-lang.c (build_fortran_types): Change name of void type to
7983         lower case.
7984         * f-typeprint.c (f_type_print_base): Print the name of the void
7985         type, rather than a fixed string.
7986         * f-valprint.c (f_decorations): Use lower case void string.
7987
7988 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7989             Chris January  <chris.january@arm.com>
7990
7991         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7992         types for Fortran.
7993
7994 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7995             Chris January  <chris.january@arm.com>
7996             David Lecomber  <david.lecomber@arm.com>
7997
7998         * f-exp.y (BINOP_INTRINSIC): New token.
7999         (exp): New parser rule handling BINOP_INTRINSIC.
8000         (f77_keywords): Add new builtin procedures.
8001         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8002         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8003         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8004         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8005         (print_unop_subexp_f): New function.
8006         (print_binop_subexp_f): New function.
8007         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8008         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8009         (dump_subexp_body_f): Likewise.
8010         (operator_check_f): Likewise.
8011         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8012         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8013
8014 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8015
8016         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8017         UNOP_KIND.
8018         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8019         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8020         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8021         (operator_length_f): New fuction.
8022         (print_subexp_f): New function.
8023         (op_name_f): New function.
8024         (dump_subexp_body_f): New function.
8025         (operator_check_f): New function.
8026         (exp_descriptor_f): Replace standard expression handling functions
8027         with new functions.
8028         * gdb/fortran-operator.def: New file.
8029         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8030         * gdb/std-operator.def: Remove UNOP_KIND.
8031
8032 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8033
8034         * std-operator.def: Remove unbalanced, stray double quote
8035         character.
8036
8037 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8038             Chris January  <chris.january@arm.com>
8039             Daniel Everett  <daniel.everett@arm.com>
8040             Nick Forrington  <nick.forrington@arm.com>
8041             Richard Bunt  <richard.bunt@arm.com>
8042
8043         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8044         of depth when printing anonymous structs or unions.
8045         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8046         Don't print either the top-level value, or the children if the
8047         max-depth is exceeded.
8048         (ppscm_print_children): When printing the key of a map, allow one
8049         extra level of depth.
8050         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8051         print either the top-level value, or the children if the max-depth
8052         is exceeded.
8053         (print_children): When printing the key of a map, allow one extra
8054         level of depth.
8055         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8056         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8057         (user_print_options): Initialise max_depth field.
8058         (val_print_scalar_or_string_type_p): New function.
8059         (val_print): Check to see if the max depth has been reached.
8060         (val_print_check_max_depth): Define new function.
8061         (show_print_max_depth): New function.
8062         (_initialize_valprint): Add 'print max-depth' option.
8063         * valprint.h (struct value_print_options) <max_depth>: New field.
8064         (val_print_check_max_depth): Declare new function.
8065         * NEWS: Document new feature.
8066
8067 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8068
8069         * ada-lang.c (ada_language_defn): Initialise new field.
8070         * c-lang.c (c_is_string_type_p): New function.
8071         (c_language_defn): Initialise new field.
8072         (cplus_language_defn): Initialise new field.
8073         (asm_language_defn): Initialise new field.
8074         (minimal_language_defn): Initialise new field.
8075         * c-lang.h (c_is_string_type_p): Declare new function.
8076         * d-lang.c (d_language_defn): Initialise new field.
8077         * f-lang.c (f_is_string_type_p): New function.
8078         (f_language_defn): Initialise new field.
8079         * go-lang.c (go_is_string_type_p): New function.
8080         (go_language_defn): Initialise new field.
8081         * language.c (default_is_string_type_p): New function.
8082         (unknown_language_defn): Initialise new field.
8083         (auto_language_defn): Initialise new field.
8084         * language.h (struct language_defn) <la_is_string_type_p>: New
8085         member variable.
8086         (default_is_string_type_p): Declare new function.
8087         * m2-lang.c (m2_language_defn): Initialise new field.
8088         * objc-lang.c (objc_language_defn): Initialise new field.
8089         * opencl-lang.c (opencl_language_defn): Initialise new field.
8090         * p-lang.c (pascal_is_string_type_p): New function.
8091         (pascal_language_defn): Initialise new field.
8092         * rust-lang.c (rust_is_string_type_p): New function.
8093         (rust_language_defn): Initialise new field.
8094
8095 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8096
8097         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8098         New field.
8099         * ada-lang.c (ada_language_defn): Initialise new field.
8100         * c-lang.c (c_language_defn): Likewise.
8101         (cplus_language_defn): Likewise.
8102         (asm_language_defn): Likewise.
8103         (minimal_language_defn): Likewise.
8104         * d-lang.c (d_language_defn): Likewise.
8105         * f-lang.c (f_language_defn): Likewise.
8106         * go-lang.c (go_language_defn): Likewise.
8107         * language.c (unknown_language_defn): Likewise.
8108         (auto_language_defn): Likewise.
8109         * m2-lang.c (m2_language_defn): Likewise.
8110         * objc-lang.c (objc_language_defn): Likewise.
8111         * opencl-lang.c (opencl_language_defn): Likewise.
8112         * p-lang.c (pascal_language_defn): Likewise.
8113         * rust-lang.c (rust_language_defn): Likewise.
8114
8115 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8116
8117         * ada-lang.c (ada_is_character_type): Change return type to bool.
8118         (ada_is_string_type): Likewise.
8119         * ada-lang.h (ada_is_character_type): Update declaration
8120         (ada_is_string_type): Likewise.
8121
8122 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8123
8124         Support style in 'frame|thread apply'
8125
8126         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8127         * record.c (record_start, record_stop): Update callers of
8128         execute_command_to_string with false.
8129         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8130         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8131         methods.
8132         (class string_file): New constructor with term_out parameter.
8133         Override methods term_out and can_emit_style_escape.  New member
8134         term_out.
8135         (class stdio_file): Override can_emit_style_escape.
8136         (class tee_file): Override term_out and can_emit_style_escape.
8137         * utils.h (can_emit_style_escape): Remove.
8138         * utils.c (can_emit_style_escape): Likewise.
8139         Update all callers of can_emit_style_escape (SOMESTREAM) to
8140         SOMESTREAM->can_emit_style_escape.
8141         * source-cache.c (source_cache::get_source_lines): Likewise.
8142         * stack.c (frame_apply_command_count): Call execute_command_to_string
8143         passing the term_out characteristic of the current gdb_stdout.
8144         * thread.c (thr_try_catch_cmd): Likewise.
8145         * top.c (execute_command_to_string): pass term_out parameter
8146         to construct the string_file for the command output.
8147         * ui-file.c (term_cli_styling): New function (most code moved
8148         from utils.c can_emit_style_escape).
8149         (string_file::string_file, string_file::can_emit_style_escape,
8150         stdio_file::can_emit_style_escape, tee_file::term_out,
8151         tee_file::can_emit_style_escape): New functions.
8152
8153 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8154
8155         * NEWS: Mention the new set|show may-call-functions.
8156         * infcall.c (may_call_functions_p): New variable.
8157         (show_may_call_functions_p): New function.
8158         (call_function_by_hand_dummy): Throws an error if not
8159         may-call-functions.
8160         (_initialize_infcall): Call add_setshow_boolean_cmd for
8161         may-call-functions.
8162
8163 2019-04-25  Keith Seitz  <keiths@redhat.com>
8164
8165         PR c++/24367
8166         * cp-support.c (inspect_type): Don't attempt substitutions
8167         of symbol with the same name.
8168
8169 2019-04-25  Tom Tromey  <tromey@adacore.com>
8170
8171         PR gdb/24475:
8172         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8173         static.
8174
8175 2019-04-25  Tom Tromey  <tromey@adacore.com>
8176
8177         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8178         rvalue reference.
8179         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8180         (gdb_xml_parser::parse): Use std::move.
8181         * python/python-internal.h (gdbpy_convert_exception): Take a const
8182         reference.
8183         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8184         std::move.
8185         * python/py-utils.c (gdbpy_convert_exception): Take a const
8186         reference.
8187         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8188         Use std::move.
8189         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8190         Use std::move.
8191         * mi/mi-main.c (mi_print_exception): Take a const reference.
8192         * main.c (handle_command_errors): Take a const reference.
8193         * linespec.c (parse_linespec): Use std::move.
8194         * infcall.c (run_inferior_call): Use std::move.
8195         (call_function_by_hand_dummy): Use std::move.
8196         * exec.c (try_open_exec_file): Use std::move.
8197         * exceptions.h (exception_print, exception_fprintf)
8198         (exception_print_same): Update.
8199         * exceptions.c (print_exception, exception_print)
8200         (exception_fprintf, exception_print_same): Change parameters to
8201         const reference.
8202         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8203         * common/new-op.c: Use std::move.
8204         * common/common-exceptions.h (struct gdb_exception): Add move
8205         constructor.
8206         (struct gdb_exception_error, struct gdb_exception_quit, struct
8207         gdb_quit_bad_alloc): Change constructor to move constructor.
8208         (throw_exception): Change parameter to rvalue reference.
8209         * common/common-exceptions.c (throw_exception): Take rvalue
8210         reference.
8211         * cli/cli-interp.c (safe_execute_command): Use std::move.
8212         * breakpoint.c (insert_bp_location, location_to_sals): Use
8213         std::move.
8214
8215 2019-04-25  Tom Tromey  <tromey@adacore.com>
8216
8217         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8218         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8219         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8220         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8221         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8222         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8223         guile/scm-value.c: Use unpack.
8224         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8225         gdbscm_gdb_exception.
8226         (gdbscm_throw_gdb_exception): Likewise.
8227         (struct gdbscm_gdb_exception): New.
8228         (unpack): New function.
8229         (gdbscm_wrap): Use unpack.
8230
8231 2019-04-25  Tom Tromey  <tromey@adacore.com>
8232
8233         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8234         (gdb_rl_callback_handler): Use std::move.
8235         * common/common-exceptions.h (struct gdb_exception): Add move
8236         assignment operator.
8237         (throw_exception_sjlj): Change "exception" to const reference.
8238         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8239         (throw_exception_sjlj): Change "exception" to const reference.
8240
8241 2019-04-25  Tom Tromey  <tromey@adacore.com>
8242
8243         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8244         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8245         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8246         Update.
8247         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8248         Update.
8249         * mi/mi-interp.c (mi_interp::exec): Update.
8250         * linespec.c (parse_linespec): Update.
8251         * infcall.c (run_inferior_call): Update.
8252         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8253         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8254         (gdbscm_lookup_global_symbol): Update.
8255         * guile/scm-param.c (gdbscm_parameter_value): Update.
8256         * guile/scm-frame.c (gdbscm_frame_read_register)
8257         (gdbscm_frame_read_var): Update.
8258         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8259         * exec.c (try_open_exec_file): Update.
8260         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8261         (gdb_rl_callback_handler): Update.
8262         * common/common-exceptions.h (exception_none): Don't declare.
8263         * common/common-exceptions.c (exception_none): Don't define.
8264         (struct catcher) <exception>: Update.
8265         * cli/cli-interp.c (safe_execute_command): Update.
8266         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8267
8268 2019-04-25  Ali Tamur  <tamur@google.com>
8269
8270         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8271         (read_attribute_value): Likewise.
8272         (dwarf2_read_addr_index): Update comment.
8273         (read_str_index): Add DW_FORM_strx.
8274         (dwarf2_string_attr): Likewise.
8275         (dwarf2_const_value_attr): Likewise.
8276         (dump_die_shallow): Likewise.
8277         (dwarf2_fetch_constant_bytes): Likewise.
8278         (skip_form_bytes): Likewise.
8279         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8280
8281 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8282
8283         PR corefiles/11608
8284         PR corefiles/18187
8285         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8286         OFFSET.  Verify if current mapping contains an ELF header.
8287         (linux_find_memory_regions_full): Adjust call to
8288         dump_mapping_p.
8289
8290 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8291             Kang Li <kanglictf@gmail.com>
8292
8293         PR gdb/21600
8294
8295         * dwarf2-frame.c (read_initial_length): Be consistent about using
8296         unsigned representation of length.
8297         (decode_frame_entry_1): Likewise.  Check for wraparound of
8298         end pointer as well as buffer overflow.
8299
8300 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8301
8302         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8303         "vq".
8304
8305 2019-04-24  Tom Tromey  <tromey@adacore.com>
8306
8307         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8308
8309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8310
8311         * s12z-tdep.c (s12z_unwind_pc): Delete.
8312         (s12z_unwind_sp): Delete.
8313         (s12z_gdbarch_init): Don't register deleted functions with
8314         gdbarch.
8315
8316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8317
8318         * rl78-tdep.c (rl78_unwind_sp): Delete.
8319         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8320
8321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8322
8323         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8324         (xstormy16_unwind_pc): Delete.
8325         (xstormy16_dummy_id): Delete.
8326         (xstormy16_gdbarch_init): Don't register deleted functions with
8327         gdbarch.
8328
8329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8330
8331         * vax-tdep.c (vax_unwind_pc): Delete.
8332         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8333
8334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8335
8336         * v850-tdep.c (v850_unwind_sp): Delete.
8337         (v850_unwind_pc): Delete.
8338         (v850_dummy_id): Delete.
8339         (v850_gdbarch_init): Don't register deleted functions with
8340         gdbarch.
8341
8342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8343
8344         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8345         (tilegx_unwind_pc): Delete.
8346         (tilegx_unwind_dummy_id): Delete.
8347         (tilegx_gdbarch_init): Don't register deleted functions with
8348         gdbarch.
8349
8350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8351
8352         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8353         (tic6x_dummy_id): Delete.
8354         (tic6x_gdbarch_init): Don't register deleted functions with
8355         gdbarch.
8356
8357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8358
8359         * sparc-tdep.c (sparc_unwind_pc): Delete.
8360         (sparc32_gdbarch_init): Don't register deleted function with
8361         gdbarch.
8362
8363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8364
8365         * sh-tdep.c (sh_unwind_sp): Delete.
8366         (sh_unwind_pc): Delete.
8367         (sh_dummy_id): Delete.
8368         (sh_gdbarch_init): Don't register deleted functions with
8369         gdbarch.
8370
8371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8372
8373         * score-tdep.c (score_unwind_sp): Delete.
8374         (score_unwind_pc): Delete.
8375         (score_dummy_id): Delete.
8376         (score_gdbarch_init): Don't register deleted functions with
8377         gdbarch.
8378
8379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8380
8381         * rx-tdep.c (rx_unwind_pc): Delete.
8382         (rx_unwind_sp): Delete.
8383         (rx_dummy_id): Delete.
8384         (rx_gdbarch_init): Don't register deleted functions with
8385         gdbarch.  Update comment.
8386
8387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8388
8389         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8390         (rs6000_dummy_id): Delete.
8391         (rs6000_gdbarch_init): Don't register deleted functions with
8392         gdbarch.
8393
8394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8395
8396         * or1k-tdep.c (or1k_dummy_id): Delete.
8397         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8398
8399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8400
8401         * nios2-tdep.c (nios2_dummy_id): Delete.
8402         (nios2_unwind_sp): Delete.
8403         (nios2_gdbarch_init): Don't register deleted functions with
8404         gdbarch.
8405
8406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8407
8408         * nds32-tdep.c (nds32_dummy_id): Delete.
8409         (nds32_unwind_pc): Delete.
8410         (nds32_unwind_sp): Delete.
8411         (nds32_gdbarch_init): Don't register deleted functions with
8412         gdbarch.
8413
8414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8415
8416         * msp430-tdep.c (msp430_unwind_pc): Delete.
8417         (msp430_unwind_sp): Delete.
8418         (msp430_dummy_id): Delete.
8419         (msp430_gdbarch_init): Don't register deleted functions with
8420         gdbarch.
8421
8422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8423
8424         * moxie-tdep.c (moxie_unwind_sp): Delete.
8425         (moxie_unwind_pc): Delete.
8426         (moxie_dummy_id): Delete.
8427         (moxie_gdbarch_init): Don't register deleted functions with
8428         gdbarch.
8429
8430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8431
8432         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8433         (mn10300_unwind_pc): Delete.
8434         (mn10300_unwind_sp): Delete.
8435         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8436         mn10300_unwind_sp.
8437         (mn10300_frame_unwind_init): Don't register deleted functions with
8438         gdbarch.
8439
8440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8441
8442         * mep-tdep.c (mep_unwind_pc): Delete.
8443         (mep_unwind_sp): Delete.
8444         (mep_dummy_id): Delete.
8445         (mep_gdbarch_init): Don't register deleted functions with
8446         gdbarch.
8447
8448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8449
8450         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8451         (m68hc11_unwind_sp): Delete.
8452         (m68hc11_gdbarch_init): Don't register deleted functions with
8453         gdbarch.
8454
8455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8456
8457         * m32r-tdep.c (m32r_unwind_sp): Delete.
8458         (m32r_unwind_pc): Delete.
8459         (m32r_dummy_id): Delete.
8460         (m32r_gdbarch_init): Don't register deleted functions with
8461         gdbarch.
8462
8463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8464
8465         * m32c-tdep.c (m32c_unwind_pc): Delete.
8466         (m32c_unwind_sp): Delete.
8467         (m32c_dummy_id): Delete.
8468         (m32c_gdbarch_init): Don't register deleted functions with
8469         gdbarch.
8470
8471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8472
8473         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8474         (lm32_unwind_pc): Delete.
8475         (lm32_dummy_id): Delete.
8476         (lm32_gdbarch_init): Don't register deleted functions with
8477         gdbarch.
8478
8479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8480
8481         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8482         (iq2000_unwind_pc): Delete.
8483         (iq2000_dummy_id): Delete.
8484         (iq2000_gdbarch_init): Don't register deleted functions with
8485         gdbarch.
8486
8487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8488
8489         * nds32-tdep.c (nds32_type_align): Delete.
8490         (nds32_push_dummy_call): Use type_align instead.
8491
8492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8493
8494         * arm-tdep.c (arm_type_align): Only handle vector override case.
8495         (arm_push_dummy_call): Use type_align.
8496         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8497
8498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8499
8500         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8501         case.
8502         (pass_on_stack): Use type_align.
8503         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8504         function.
8505
8506 2019-04-23  Tom Tromey  <tromey@adacore.com>
8507
8508         * dwarf2read.c (line_header::file_name_at): Remove unused
8509         overload.
8510
8511 2019-04-23  Tom de Vries  <tdevries@suse.de>
8512
8513         PR gdb/24438
8514         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8515         invocation.
8516
8517
8518 2019-03-27  Ali Tamur  <tamur@google.com>
8519
8520         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8521         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8522         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8523         (dwarf_expr_context::get_addr_index): Likewise
8524         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8525         (symbol_needs_eval_context::get_addr_index): Likewise
8526         (disassemble_dwarf_expression): Add DW_OP_addrx
8527         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8528         (read_cutu_die_from_dwo): Update comment
8529         (skip_one_die): Add DW_FORM_addrx
8530         (read_attribute_value): Likewise
8531         (var_decode_location): Add DW_OP_addrx
8532         (dwarf2_const_value_attr): Add DW_FORM_addrx
8533         (dump_die_shallow): Likewise
8534         (dwarf2_fetch_constant_bytes): Likewise
8535         (decode_locdesc): Add DW_OP_addrx
8536         (skip_form_bytes): Add DW_FORM_addrx
8537
8538 2019-04-22  Ali Tamur  <tamur@google.com>
8539
8540         * MAINTAINERS (Write After Approval): Add self.
8541
8542 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8543
8544         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8545         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8546         (open_symbol_file_object): Likewise.
8547         (svr4_default_sos): Add info parameter.
8548         (svr4_read_so_list): Likewise.
8549         (svr4_current_sos_direct): Adjust functions calls to pass down
8550         info.
8551         (svr4_current_sos_1): Add info parameter.
8552         (svr4_current_sos): Call get_svr4_info, pass info down to
8553         svr4_current_sos_1.
8554         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8555         get_svr4_info.
8556         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8557         get_svr4_info.
8558         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8559         to get_svr4_info.
8560         (probes_table_remove_objfile_probes): Likewise.
8561         (register_solib_event_probe): Add info parameter.
8562         (solist_update_incremental): Pass info parameter down to
8563         svr4_read_so_list.
8564         (disable_probes_interface): Add info parameter.
8565         (svr4_handle_solib_event): Pass current_program_space to
8566         get_svr4_info.  Adjust disable_probes_interface cleanup.
8567         (svr4_create_probe_breakpoints): Add info parameter, pass it
8568         down to register_solib_event_probe.
8569         (svr4_create_solib_event_breakpoints): Add info parameter,
8570         pass it down to svr4_create_probe_breakpoints.
8571         (enable_break): Pass info down to
8572         svr4_create_solib_event_breakpoints.
8573         (svr4_solib_create_inferior_hook): Pass current_program_space to
8574         get_svr4_info.
8575         (svr4_clear_solib): Likewise.
8576
8577 2019-04-22  Pedro Alves  <palves@redhat.com>
8578
8579         * solib-svr4.c (svr4_free_objfile_observer): New.
8580         (probe_and_action::objfile): New field.
8581         (probes_table_htab_remove_objfile_probes)
8582         (probes_table_remove_objfile_probes): New functions.
8583         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8584         in the new probe_and_action.  Don't store the probe in 'lookup'.
8585         (svr4_create_probe_breakpoints): Pass objfile to
8586         register_solib_event_probe.
8587         (_initialize_svr4_solib): Register a free_objfile observer.
8588
8589 2019-04-19  Tom Tromey  <tom@tromey.com>
8590
8591         * common/queue.h: Remove.
8592
8593 2019-04-19  Tom Tromey  <tom@tromey.com>
8594
8595         * event-loop.c: Don't include "common/queue.h".
8596
8597 2019-04-19  Tom Tromey  <tom@tromey.com>
8598
8599         * remote.c (remote_target): Use delete.
8600         * remote-notif.h: Include <list>, not "common/queue.h".
8601         (notif_client_p): Remove typedef.
8602         (remote_notif_state): Add constructor, destructor, initializer.
8603         <notif_queue>: Now a std::list.
8604         (remote_notif_state_xfree): Don't declare.
8605         * remote-notif.c (remote_notif_process, handle_notification)
8606         (remote_notif_state_allocate): Update.
8607         (~remote_notif_state): Rename from remote_notif_state_xfree.
8608
8609 2019-04-19  Tom Tromey  <tom@tromey.com>
8610
8611         * symfile.c (reread_symbols): Update.
8612         * objfiles.c (objfile_register_static_link)
8613         (objfile_lookup_static_link): Update
8614         (~objfile) Don't delete static_links.
8615         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8616
8617 2019-04-19  Tom Tromey  <tom@tromey.com>
8618
8619         * type-stack.h (struct type_stack) <insert>: Constify string.
8620         * type-stack.c (type_stack::insert): Constify string.
8621         * gdbtypes.h (lookup_template_type): Update.
8622         (address_space_name_to_int): Update.
8623         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8624         const.
8625         (lookup_template_type): Make name const.
8626         * c-exp.y: Update rules.
8627         (lex_one_token, classify_name, classify_inner_name)
8628         (c_print_token): Update.
8629         * p-exp.y: Update rules.
8630         (yylex): Update.
8631         * f-exp.y: Update rules.
8632         (yylex): Update.
8633         * d-exp.y: Update rules.
8634         (lex_one_token, classify_name, classify_inner_name): Update.
8635         * parse.c (write_dollar_variable, copy_name): Return std::string.
8636         * parser-defs.h (copy_name): Change return type.
8637         * m2-exp.y: Update rules.
8638         (yylex): Update.
8639         * go-exp.y (lex_one_token): Update.
8640         Update rules.
8641         (classify_unsafe_function, classify_packaged_name)
8642         (classify_name, yylex): Update.
8643
8644 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8645
8646         * configure.ac: add --enable-source-highlight switch.
8647         * configure: Regenerate.
8648         * top.c (print_gdb_version): plumb --enable-source-highlight
8649         status to "show configuration".
8650
8651 2019-04-19  Tom Tromey  <tromey@adacore.com>
8652
8653         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8654         Check ADA_TYPE_P.
8655         (empty_record, ada_template_to_fixed_record_type_1)
8656         (template_to_static_fixed_type)
8657         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8658         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8659         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8660         macros.
8661
8662 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8663
8664         PR symtab/24423:
8665         * source.c (print_source_lines_base): Advance "iter" when a
8666         control character is seen.
8667
8668 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8669
8670         * inferior.h (struct infcall_suspend_state_deleter):
8671         Catch exception in destructor to avoid crash.
8672
8673 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8674
8675         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8676         close to the add_com "shell".
8677
8678 2019-04-18  Tom Tromey  <tromey@adacore.com>
8679
8680         * process-stratum-target.h (class process_stratum_target)
8681         <stratum>: Add "final".
8682
8683 2019-04-17  Tom Tromey  <tromey@adacore.com>
8684
8685         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8686         against nullptr before use.
8687
8688 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8689
8690         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8691
8692 2019-04-17  Jim Wilson  <jimw@sifive.com>
8693             Andrew Burgess  <andrew.burgess@embecosm.com>
8694
8695         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8696         code read might fail, assume 4-byte breakpoint in that case.
8697
8698 2019-04-15  Leszek Swirski  <leszeks@google.com>
8699
8700         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8701         rather than a hand-rolled POD check when checking for forced MEMORY
8702         classification.
8703
8704 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8705
8706         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8707         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8708         function.
8709         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8710         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8711         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8712         declaration.
8713
8714 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8715
8716         * aarch64-linux-nat.c
8717         (aarch64_linux_nat_target::thread_architecture): Add override.
8718         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8719         each VQ.
8720
8721 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8722
8723         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8724
8725 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8726
8727         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8728         target types of size 96-bits, add some additional comments, and
8729         check that the builtin type we found was the correct size.
8730
8731 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8732
8733         * utils.c (prompt_for_continue): Don't restore the styling at the
8734         end, as applied_style has the wrong value.  This fixes styling in
8735         long lists of file names that are interrupted by the "Continue?"
8736         prompt.
8737
8738 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8739
8740         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8741         * c-lang.c (c_language_defn): Likewise.
8742         (cplus_language_defn): Likewise.
8743         (asm_language_defn): Likewise.
8744         (minimal_language_defn): Likewise.
8745         * d-lang.c (d_language_defn): Likewise.
8746         * f-lang.c (f_language_defn): Likewise.
8747         * go-lang.c (go_language_defn): Likewise.
8748         * language.c (unknown_language_defn): Likewise.
8749         (auto_language_defn): Likewise.
8750         * language.h (struct language_defn): Remove la_magic field.
8751         (LANG_MAGIC): Delete.
8752         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8753         * objc-lang.c (objc_language_defn): Likewise.
8754         * opencl-lang.c (opencl_language_defn): Likewise.
8755         * p-lang.c (pascal_language_defn): Likewise.
8756         * rust-lang.c (rust_language_defn): Likewise.
8757
8758 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8759
8760         * riscv-tdep.c (riscv_type_align): New function.
8761         (riscv_type_alignment): Delete.
8762         (riscv_arg_location): Use 'type_align'.
8763         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8764
8765 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8766
8767         * gdbtypes.c (type_align): A struct with no non-static fields also
8768         has alignment of 1.
8769
8770 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8771
8772         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8773         component to 0.
8774         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8775         member.
8776         (riscv_struct_info::analyse): New implementation using new
8777         analyse_inner member function.
8778         (riscv_struct_info::field_offset): New member function.
8779         (riscv_struct_info::m_offsets): New member variable.
8780         (riscv_struct_info::analyse_inner): New private member function,
8781         takes the old implementation of riscv_struct_info::analyse but
8782         extended to track field offsets.
8783         (riscv_call_arg_struct): Update the struct folding special cases
8784         to handle cases where empty C++ structs, which are non-zero
8785         length, are found.
8786         (riscv_arg_location): Initialise the length of each location, a
8787         non-zero length now indicates the location is in use.
8788         (riscv_push_dummy_call): Allow for the first location having a
8789         non-zero offset when setting up arguments.
8790         (riscv_return_value): Likewise, but for return values.
8791
8792 2019-04-11  Tom Tromey  <tromey@adacore.com>
8793
8794         * utils.c (internal_vproblem): Make "msg" const.
8795
8796 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8797
8798         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8799         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8800         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8801         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8802
8803 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8804
8805         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8806         function.
8807         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8808         of amd64_collect_native_gregset.
8809         (amd64_linux_nat_target::store_registers): Likewise.
8810
8811 2019-04-10  Tom Tromey  <tom@tromey.com>
8812
8813         * symtab.c (lookup_global_symbol_from_objfile)
8814         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8815         * objfiles.h (class separate_debug_iterator): New.
8816         (class separate_debug_range): New.
8817         (struct objfile) <separate_debug_objfiles>: New method.
8818         (objfile_separate_debug_iterate): Don't declare.
8819         * objfiles.c (separate_debug_iterator::operator++): Rename from
8820         objfile_separate_debug_iterate.
8821         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8822         iterator.
8823         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8824         iterator.
8825
8826 2019-04-10  Tom Tromey  <tom@tromey.com>
8827
8828         * symfile.c (reread_symbols): Remove old comment.
8829         * objfiles.c (free_all_objfiles): Fix a typo.
8830
8831 2019-04-10  Tom Tromey  <tom@tromey.com>
8832
8833         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8834         * minsyms.c (lookup_minimal_symbol): Use foreach.
8835         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8836         (lookup_minimal_symbol_solib_trampoline): Likewise.
8837         * symfile.c (reread_symbols): Use foreach.
8838
8839 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8840             Tom Tromey  <tromey@adacore.com>
8841
8842         PR rust/24414:
8843         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8844         (rust_lex_int_test): Change "value" to be LONGEST.
8845         (rust_lex_tests): Add test for long integer literal.
8846
8847 2019-04-09  Tom Tromey  <tromey@adacore.com>
8848
8849         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8850         to bool.
8851         (extended_remote_target::attach): Update.
8852         (remote_target::remote_notice_new_inferior): Update.
8853         (remote_target::add_current_inferior_and_thread): Update.
8854         * inferior.c (exit_inferior_1): Use "false".
8855         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8856
8857 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8858
8859         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8860         the "start" command.
8861
8862 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8863
8864         * python/py-inferior.c (infpy_thread_from_thread_handle):
8865         Adjust comments to reflect renaming of thread_from_thread_handle
8866         to thread_from_handle.  Adjust keywords.  Fix type error message.
8867         (inferior_object_methods): Add thread_from_handle.  Retain
8868         thread_from_thread_handle, but mark it as deprecated.
8869
8870 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8871
8872         * gdbthread.h (find_thread_by_handle): Revise declaration.
8873         * thread.c (find_thread_by_handle): Likewise.  Adjust
8874         implementation too.
8875         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8876         support for buffer objects as handles.
8877
8878 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8879
8880         * python/py-infthread.c (thpy_thread_handle): New function.
8881         (thread_object_methods): Register thpy_thread_handle.
8882
8883 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8884
8885         * gdbthread.h (thread_to_thread_handle): Declare.
8886         * thread.c (gdbtypes.h): Include.
8887         (thread_to_thread_handle): New function.
8888
8889         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8890         (target_thread_info_to_thread_handle): Declare.
8891         * target.c (target_thread_info_to_thread_handle): New function.
8892         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8893         * target-delegates.c: Regenerate.
8894
8895         * linux-thread-db.c (class thread_db_target): Add method
8896         thread_info_to_thread_handle.
8897         (thread_db_target::thread_info_to_thread_handle): Define.
8898         * remote.c (class remote_target): Add new method
8899         thread_info_to_thread_handle.
8900         (remote_target::thread_info_to_thread_handle): Define.
8901
8902 2019-04-08  Pedro Alves  <palves@redhat.com>
8903
8904         * common/common-exceptions.c (throw_exception): Don't create
8905         named object to throw; throw directly.
8906         (throw_it): Likewise.  Don't initialize gdb_exception::message
8907         here, with new; pass FMT and AP to the ctor instead.
8908         * common/common-exceptions.h: Include <string>.
8909         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8910         const char *, va_list)): New ctor.  Use std::make_shared.
8911         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8912         errors)): Delete.
8913         (gdb_exception_error::gdb_exception_error(enum errors, const char
8914         *, va_list)): New.
8915         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8916         Add assertion.
8917         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8918         errors)): Delete.
8919         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8920         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8921         Add assertion.
8922
8923 2019-04-08  Tom Tromey  <tom@tromey.com>
8924
8925         * valops.c (value_rtti_indirect_type): Replace throw_exception
8926         with throw.
8927         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8928         with throw.
8929         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8930         throw.
8931         * target.c (target_translate_tls_address): Replace throw_exception
8932         with throw.
8933         * stack.c (frame_apply_command_count): Replace throw_exception
8934         with throw.
8935         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8936         throw.
8937         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8938         with throw.
8939         * rs6000-tdep.c (rs6000_frame_cache)
8940         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8941         * remote.c: Replace throw_exception with throw.
8942         * record-full.c (record_full_message, record_full_wait_1)
8943         (record_full_restore): Replace throw_exception with throw.
8944         * record-btrace.c:
8945         (get_thread_current_frame_id, record_btrace_start_replaying)
8946         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8947         (cmd_record_btrace_start): Replace throw_exception with throw.
8948         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8949         throw.
8950         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8951         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8952         * linespec.c:
8953         (find_linespec_symbols): Replace throw_exception with throw.
8954         * infrun.c (displaced_step_prepare, resume): Replace
8955         throw_exception with throw.
8956         * infcmd.c (post_create_inferior): Replace throw_exception with
8957         throw.
8958         * inf-loop.c (inferior_event_handler): Replace throw_exception
8959         with throw.
8960         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8961         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8962         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8963         (get_prev_frame_always, get_frame_pc_if_available)
8964         (get_frame_address_in_block_if_available, get_frame_language):
8965         Replace throw_exception with throw.
8966         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8967         throw_exception with throw.
8968         * eval.c (fetch_subexp_value, evaluate_var_value)
8969         (evaluate_funcall, evaluate_subexp_standard): Replace
8970         throw_exception with throw.
8971         * dwarf2loc.c (call_site_find_chain)
8972         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8973         Replace throw_exception with throw.
8974         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8975         with throw.
8976         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8977         throw.
8978         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8979         * completer.c (complete_line_internal): Replace throw_exception
8980         with throw.
8981         * compile/compile-object-run.c (compile_object_run): Replace
8982         throw_exception with throw.
8983         * cli/cli-script.c (process_next_line): Replace throw_exception
8984         with throw.
8985         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8986         (btrace_enable, btrace_maint_update_pt_packets): Replace
8987         throw_exception with throw.
8988         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8989         throw_exception with throw.
8990         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8991         throw_exception with throw.
8992         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8993         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8994         * aarch64-tdep.c (aarch64_make_prologue_cache)
8995         (aarch64_make_stub_cache): Replace throw_exception with throw.
8996
8997 2019-04-08  Tom Tromey  <tom@tromey.com>
8998
8999         * common/common-exceptions.c (throw_exception): Rename from
9000         throw_exception_cxx.  Remove old copy.  Make argument const.
9001         (throw_it): Create and throw exception objects directly.
9002         * common/common-exceptions.h (throw_exception): Make argument
9003         const.
9004         (struct gdb_exception_error): Add constructor.
9005         (struct gdb_exception_quit): Add constructor.
9006
9007 2019-04-08  Tom Tromey  <tom@tromey.com>
9008
9009         * common/common-exceptions.h (exception_rethrow): Don't declare.
9010         (TRY_SJLJ): Update comment.
9011         (TRY, CATCH, END_CATCH): Remove.
9012         * common/common-exceptions.c (exception_rethrow): Remove.
9013
9014 2019-04-08  Tom Tromey  <tom@tromey.com>
9015
9016         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9017         Remove.
9018         (gdb_exception_error): Rename from
9019         gdb_exception_RETURN_MASK_ERROR.
9020         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9021         (gdb_quit_bad_alloc): Update.
9022         * aarch64-tdep.c: Update.
9023         * ada-lang.c: Update.
9024         * ada-typeprint.c: Update.
9025         * ada-valprint.c: Update.
9026         * amd64-tdep.c: Update.
9027         * arch-utils.c: Update.
9028         * break-catch-throw.c: Update.
9029         * breakpoint.c: Update.
9030         * btrace.c: Update.
9031         * c-varobj.c: Update.
9032         * cli/cli-cmds.c: Update.
9033         * cli/cli-interp.c: Update.
9034         * cli/cli-script.c: Update.
9035         * common/common-exceptions.c: Update.
9036         * common/new-op.c: Update.
9037         * common/selftest.c: Update.
9038         * compile/compile-c-symbols.c: Update.
9039         * compile/compile-cplus-symbols.c: Update.
9040         * compile/compile-object-load.c: Update.
9041         * compile/compile-object-run.c: Update.
9042         * completer.c: Update.
9043         * corelow.c: Update.
9044         * cp-abi.c: Update.
9045         * cp-support.c: Update.
9046         * cp-valprint.c: Update.
9047         * darwin-nat.c: Update.
9048         * disasm-selftests.c: Update.
9049         * dtrace-probe.c: Update.
9050         * dwarf-index-cache.c: Update.
9051         * dwarf-index-write.c: Update.
9052         * dwarf2-frame-tailcall.c: Update.
9053         * dwarf2-frame.c: Update.
9054         * dwarf2loc.c: Update.
9055         * dwarf2read.c: Update.
9056         * eval.c: Update.
9057         * event-loop.c: Update.
9058         * event-top.c: Update.
9059         * exec.c: Update.
9060         * f-valprint.c: Update.
9061         * fbsd-tdep.c: Update.
9062         * frame-unwind.c: Update.
9063         * frame.c: Update.
9064         * gdbtypes.c: Update.
9065         * gnu-v3-abi.c: Update.
9066         * guile/guile-internal.h: Update.
9067         * guile/scm-block.c: Update.
9068         * guile/scm-breakpoint.c: Update.
9069         * guile/scm-cmd.c: Update.
9070         * guile/scm-disasm.c: Update.
9071         * guile/scm-frame.c: Update.
9072         * guile/scm-lazy-string.c: Update.
9073         * guile/scm-math.c: Update.
9074         * guile/scm-param.c: Update.
9075         * guile/scm-ports.c: Update.
9076         * guile/scm-pretty-print.c: Update.
9077         * guile/scm-symbol.c: Update.
9078         * guile/scm-symtab.c: Update.
9079         * guile/scm-type.c: Update.
9080         * guile/scm-value.c: Update.
9081         * i386-linux-tdep.c: Update.
9082         * i386-tdep.c: Update.
9083         * inf-loop.c: Update.
9084         * infcall.c: Update.
9085         * infcmd.c: Update.
9086         * infrun.c: Update.
9087         * jit.c: Update.
9088         * language.c: Update.
9089         * linespec.c: Update.
9090         * linux-fork.c: Update.
9091         * linux-nat.c: Update.
9092         * linux-tdep.c: Update.
9093         * linux-thread-db.c: Update.
9094         * main.c: Update.
9095         * mi/mi-cmd-break.c: Update.
9096         * mi/mi-cmd-stack.c: Update.
9097         * mi/mi-interp.c: Update.
9098         * mi/mi-main.c: Update.
9099         * objc-lang.c: Update.
9100         * p-valprint.c: Update.
9101         * parse.c: Update.
9102         * ppc-linux-tdep.c: Update.
9103         * printcmd.c: Update.
9104         * python/py-arch.c: Update.
9105         * python/py-breakpoint.c: Update.
9106         * python/py-cmd.c: Update.
9107         * python/py-finishbreakpoint.c: Update.
9108         * python/py-frame.c: Update.
9109         * python/py-framefilter.c: Update.
9110         * python/py-gdb-readline.c: Update.
9111         * python/py-inferior.c: Update.
9112         * python/py-infthread.c: Update.
9113         * python/py-lazy-string.c: Update.
9114         * python/py-linetable.c: Update.
9115         * python/py-objfile.c: Update.
9116         * python/py-param.c: Update.
9117         * python/py-prettyprint.c: Update.
9118         * python/py-progspace.c: Update.
9119         * python/py-record-btrace.c: Update.
9120         * python/py-record.c: Update.
9121         * python/py-symbol.c: Update.
9122         * python/py-type.c: Update.
9123         * python/py-unwind.c: Update.
9124         * python/py-utils.c: Update.
9125         * python/py-value.c: Update.
9126         * python/python.c: Update.
9127         * record-btrace.c: Update.
9128         * record-full.c: Update.
9129         * remote-fileio.c: Update.
9130         * remote.c: Update.
9131         * riscv-tdep.c: Update.
9132         * rs6000-aix-tdep.c: Update.
9133         * rs6000-tdep.c: Update.
9134         * rust-exp.y: Update.
9135         * rust-lang.c: Update.
9136         * s390-tdep.c: Update.
9137         * selftest-arch.c: Update.
9138         * solib-dsbt.c: Update.
9139         * solib-frv.c: Update.
9140         * solib-spu.c: Update.
9141         * solib-svr4.c: Update.
9142         * solib.c: Update.
9143         * sparc64-linux-tdep.c: Update.
9144         * stack.c: Update.
9145         * symfile-mem.c: Update.
9146         * symmisc.c: Update.
9147         * target.c: Update.
9148         * thread.c: Update.
9149         * top.c: Update.
9150         * tracefile-tfile.c: Update.
9151         * tui/tui.c: Update.
9152         * typeprint.c: Update.
9153         * unittests/cli-utils-selftests.c: Update.
9154         * unittests/parse-connection-spec-selftests.c: Update.
9155         * valops.c: Update.
9156         * valprint.c: Update.
9157         * value.c: Update.
9158         * varobj.c: Update.
9159         * windows-nat.c: Update.
9160         * x86-linux-nat.c: Update.
9161         * xml-support.c: Update.
9162
9163 2019-04-08  Tom Tromey  <tom@tromey.com>
9164
9165         * xml-support.c: Use C++ exception handling.
9166         * x86-linux-nat.c: Use C++ exception handling.
9167         * windows-nat.c: Use C++ exception handling.
9168         * varobj.c: Use C++ exception handling.
9169         * value.c: Use C++ exception handling.
9170         * valprint.c: Use C++ exception handling.
9171         * valops.c: Use C++ exception handling.
9172         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9173         handling.
9174         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9175         * typeprint.c: Use C++ exception handling.
9176         * tui/tui.c: Use C++ exception handling.
9177         * tracefile-tfile.c: Use C++ exception handling.
9178         * top.c: Use C++ exception handling.
9179         * thread.c: Use C++ exception handling.
9180         * target.c: Use C++ exception handling.
9181         * symmisc.c: Use C++ exception handling.
9182         * symfile-mem.c: Use C++ exception handling.
9183         * stack.c: Use C++ exception handling.
9184         * sparc64-linux-tdep.c: Use C++ exception handling.
9185         * solib.c: Use C++ exception handling.
9186         * solib-svr4.c: Use C++ exception handling.
9187         * solib-spu.c: Use C++ exception handling.
9188         * solib-frv.c: Use C++ exception handling.
9189         * solib-dsbt.c: Use C++ exception handling.
9190         * selftest-arch.c: Use C++ exception handling.
9191         * s390-tdep.c: Use C++ exception handling.
9192         * rust-lang.c: Use C++ exception handling.
9193         * rust-exp.y: Use C++ exception handling.
9194         * rs6000-tdep.c: Use C++ exception handling.
9195         * rs6000-aix-tdep.c: Use C++ exception handling.
9196         * riscv-tdep.c: Use C++ exception handling.
9197         * remote.c: Use C++ exception handling.
9198         * remote-fileio.c: Use C++ exception handling.
9199         * record-full.c: Use C++ exception handling.
9200         * record-btrace.c: Use C++ exception handling.
9201         * python/python.c: Use C++ exception handling.
9202         * python/py-value.c: Use C++ exception handling.
9203         * python/py-utils.c: Use C++ exception handling.
9204         * python/py-unwind.c: Use C++ exception handling.
9205         * python/py-type.c: Use C++ exception handling.
9206         * python/py-symbol.c: Use C++ exception handling.
9207         * python/py-record.c: Use C++ exception handling.
9208         * python/py-record-btrace.c: Use C++ exception handling.
9209         * python/py-progspace.c: Use C++ exception handling.
9210         * python/py-prettyprint.c: Use C++ exception handling.
9211         * python/py-param.c: Use C++ exception handling.
9212         * python/py-objfile.c: Use C++ exception handling.
9213         * python/py-linetable.c: Use C++ exception handling.
9214         * python/py-lazy-string.c: Use C++ exception handling.
9215         * python/py-infthread.c: Use C++ exception handling.
9216         * python/py-inferior.c: Use C++ exception handling.
9217         * python/py-gdb-readline.c: Use C++ exception handling.
9218         * python/py-framefilter.c: Use C++ exception handling.
9219         * python/py-frame.c: Use C++ exception handling.
9220         * python/py-finishbreakpoint.c: Use C++ exception handling.
9221         * python/py-cmd.c: Use C++ exception handling.
9222         * python/py-breakpoint.c: Use C++ exception handling.
9223         * python/py-arch.c: Use C++ exception handling.
9224         * printcmd.c: Use C++ exception handling.
9225         * ppc-linux-tdep.c: Use C++ exception handling.
9226         * parse.c: Use C++ exception handling.
9227         * p-valprint.c: Use C++ exception handling.
9228         * objc-lang.c: Use C++ exception handling.
9229         * mi/mi-main.c: Use C++ exception handling.
9230         * mi/mi-interp.c: Use C++ exception handling.
9231         * mi/mi-cmd-stack.c: Use C++ exception handling.
9232         * mi/mi-cmd-break.c: Use C++ exception handling.
9233         * main.c: Use C++ exception handling.
9234         * linux-thread-db.c: Use C++ exception handling.
9235         * linux-tdep.c: Use C++ exception handling.
9236         * linux-nat.c: Use C++ exception handling.
9237         * linux-fork.c: Use C++ exception handling.
9238         * linespec.c: Use C++ exception handling.
9239         * language.c: Use C++ exception handling.
9240         * jit.c: Use C++ exception handling.
9241         * infrun.c: Use C++ exception handling.
9242         * infcmd.c: Use C++ exception handling.
9243         * infcall.c: Use C++ exception handling.
9244         * inf-loop.c: Use C++ exception handling.
9245         * i386-tdep.c: Use C++ exception handling.
9246         * i386-linux-tdep.c: Use C++ exception handling.
9247         * guile/scm-value.c: Use C++ exception handling.
9248         * guile/scm-type.c: Use C++ exception handling.
9249         * guile/scm-symtab.c: Use C++ exception handling.
9250         * guile/scm-symbol.c: Use C++ exception handling.
9251         * guile/scm-pretty-print.c: Use C++ exception handling.
9252         * guile/scm-ports.c: Use C++ exception handling.
9253         * guile/scm-param.c: Use C++ exception handling.
9254         * guile/scm-math.c: Use C++ exception handling.
9255         * guile/scm-lazy-string.c: Use C++ exception handling.
9256         * guile/scm-frame.c: Use C++ exception handling.
9257         * guile/scm-disasm.c: Use C++ exception handling.
9258         * guile/scm-cmd.c: Use C++ exception handling.
9259         * guile/scm-breakpoint.c: Use C++ exception handling.
9260         * guile/scm-block.c: Use C++ exception handling.
9261         * guile/guile-internal.h: Use C++ exception handling.
9262         * gnu-v3-abi.c: Use C++ exception handling.
9263         * gdbtypes.c: Use C++ exception handling.
9264         * frame.c: Use C++ exception handling.
9265         * frame-unwind.c: Use C++ exception handling.
9266         * fbsd-tdep.c: Use C++ exception handling.
9267         * f-valprint.c: Use C++ exception handling.
9268         * exec.c: Use C++ exception handling.
9269         * event-top.c: Use C++ exception handling.
9270         * event-loop.c: Use C++ exception handling.
9271         * eval.c: Use C++ exception handling.
9272         * dwarf2read.c: Use C++ exception handling.
9273         * dwarf2loc.c: Use C++ exception handling.
9274         * dwarf2-frame.c: Use C++ exception handling.
9275         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9276         * dwarf-index-write.c: Use C++ exception handling.
9277         * dwarf-index-cache.c: Use C++ exception handling.
9278         * dtrace-probe.c: Use C++ exception handling.
9279         * disasm-selftests.c: Use C++ exception handling.
9280         * darwin-nat.c: Use C++ exception handling.
9281         * cp-valprint.c: Use C++ exception handling.
9282         * cp-support.c: Use C++ exception handling.
9283         * cp-abi.c: Use C++ exception handling.
9284         * corelow.c: Use C++ exception handling.
9285         * completer.c: Use C++ exception handling.
9286         * compile/compile-object-run.c: Use C++ exception handling.
9287         * compile/compile-object-load.c: Use C++ exception handling.
9288         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9289         * compile/compile-c-symbols.c: Use C++ exception handling.
9290         * common/selftest.c: Use C++ exception handling.
9291         * common/new-op.c: Use C++ exception handling.
9292         * cli/cli-script.c: Use C++ exception handling.
9293         * cli/cli-interp.c: Use C++ exception handling.
9294         * cli/cli-cmds.c: Use C++ exception handling.
9295         * c-varobj.c: Use C++ exception handling.
9296         * btrace.c: Use C++ exception handling.
9297         * breakpoint.c: Use C++ exception handling.
9298         * break-catch-throw.c: Use C++ exception handling.
9299         * arch-utils.c: Use C++ exception handling.
9300         * amd64-tdep.c: Use C++ exception handling.
9301         * ada-valprint.c: Use C++ exception handling.
9302         * ada-typeprint.c: Use C++ exception handling.
9303         * ada-lang.c: Use C++ exception handling.
9304         * aarch64-tdep.c: Use C++ exception handling.
9305
9306 2019-04-08  Tom Tromey  <tom@tromey.com>
9307
9308         * xml-support.c (gdb_xml_parser::parse): Update.
9309         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9310         * value.c (show_convenience): Update.
9311         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9312         (test_parse_flags_qcs): Update.
9313         * thread.c (thr_try_catch_cmd): Update.
9314         * target.c (target_translate_tls_address): Update.
9315         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9316         (info_frame_command_core, frame_apply_command_count): Update.
9317         * rust-exp.y (rust_lex_exception_test): Update.
9318         * riscv-tdep.c (riscv_print_one_register_info): Update.
9319         * remote.c (remote_target::enable_btrace): Update.
9320         * record-btrace.c (record_btrace_enable_warn): Update.
9321         * python/py-utils.c (gdbpy_convert_exception): Update.
9322         * printcmd.c (do_one_display, print_variable_and_value): Update.
9323         * mi/mi-main.c (mi_print_exception): Update.
9324         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9325         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9326         * linux-nat.c (linux_nat_target::attach): Update.
9327         * linux-fork.c (class scoped_switch_fork_info): Update.
9328         * infrun.c (displaced_step_prepare): Update.
9329         * infcall.c (call_function_by_hand_dummy): Update.
9330         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9331         * gnu-v3-abi.c (print_one_vtable): Update.
9332         * frame.c (get_prev_frame_always): Update.
9333         * f-valprint.c (info_common_command_for_block): Update.
9334         * exec.c (try_open_exec_file): Update.
9335         * exceptions.c (print_exception, exception_print)
9336         (exception_fprintf, exception_print_same): Update.
9337         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9338         * dwarf-index-cache.c (index_cache::store)
9339         (index_cache::lookup_gdb_index): Update.
9340         * darwin-nat.c (maybe_cache_shell): Update.
9341         * cp-valprint.c (cp_print_value_fields): Update.
9342         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9343         (gcc_cplus_symbol_address): Update.
9344         * compile/compile-c-symbols.c (gcc_convert_symbol)
9345         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9346         * common/selftest.c: Update.
9347         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9348         a std::string.
9349         (exception_try_scope_entry, exception_try_scope_exit): Don't
9350         declare.
9351         (struct exception_try_scope): Remove.
9352         (TRY): Don't use exception_try_scope.
9353         (struct gdb_exception): Add constructor, operator=.
9354         <what>: New method.
9355         (struct gdb_exception_RETURN_MASK_ALL)
9356         (struct gdb_exception_RETURN_MASK_ERROR)
9357         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9358         (struct gdb_quit_bad_alloc): Update.
9359         * common/common-exceptions.c (exception_none): Change
9360         initializer.
9361         (struct catcher) <state, exception>: Initialize inline.
9362         <prev>: Remove member.
9363         (current_catcher): Remove.
9364         (catchers): New global.
9365         (exceptions_state_mc_init): Simplify.
9366         (catcher_pop): Remove.
9367         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9368         (try_scope_depth, exception_try_scope_entry)
9369         (exception_try_scope_exit): Remove.
9370         (throw_exception_sjlj): Update.
9371         (exception_messages, exception_messages_size): Remove.
9372         (throw_it): Simplify.
9373         (gdb_exception_sliced_copy): Remove.
9374         (throw_exception_cxx): Update.
9375         * cli/cli-script.c (script_from_file): Update.
9376         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9377         Update.
9378         * ada-valprint.c (ada_val_print): Update.
9379         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9380         (create_excep_cond_exprs): Update.
9381
9382 2019-04-08  Tom Tromey  <tom@tromey.com>
9383
9384         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9385         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9386         (TRY, CATCH, END_CATCH): Remove some definitions.
9387         * common/common-exceptions.c: Don't use GDB_XCPT.
9388         (catcher_list_size): Remove.
9389         (throw_exception, throw_it): Simplify.
9390
9391 2019-04-05  Tom Tromey  <tom@tromey.com>
9392
9393         Revert the header-sorting patch.
9394         * ft32-tdep.c: Revert.
9395         * frv-tdep.c: Revert.
9396         * frv-linux-tdep.c: Revert.
9397         * frame.c: Revert.
9398         * frame-unwind.c: Revert.
9399         * frame-base.c: Revert.
9400         * fork-child.c: Revert.
9401         * findvar.c: Revert.
9402         * findcmd.c: Revert.
9403         * filesystem.c: Revert.
9404         * filename-seen-cache.h: Revert.
9405         * filename-seen-cache.c: Revert.
9406         * fbsd-tdep.c: Revert.
9407         * fbsd-nat.h: Revert.
9408         * fbsd-nat.c: Revert.
9409         * f-valprint.c: Revert.
9410         * f-typeprint.c: Revert.
9411         * f-lang.c: Revert.
9412         * extension.h: Revert.
9413         * extension.c: Revert.
9414         * extension-priv.h: Revert.
9415         * expprint.c: Revert.
9416         * exec.h: Revert.
9417         * exec.c: Revert.
9418         * exceptions.c: Revert.
9419         * event-top.c: Revert.
9420         * event-loop.c: Revert.
9421         * eval.c: Revert.
9422         * elfread.c: Revert.
9423         * dwarf2read.h: Revert.
9424         * dwarf2read.c: Revert.
9425         * dwarf2loc.c: Revert.
9426         * dwarf2expr.h: Revert.
9427         * dwarf2expr.c: Revert.
9428         * dwarf2-frame.c: Revert.
9429         * dwarf2-frame-tailcall.c: Revert.
9430         * dwarf-index-write.h: Revert.
9431         * dwarf-index-write.c: Revert.
9432         * dwarf-index-common.c: Revert.
9433         * dwarf-index-cache.h: Revert.
9434         * dwarf-index-cache.c: Revert.
9435         * dummy-frame.c: Revert.
9436         * dtrace-probe.c: Revert.
9437         * disasm.h: Revert.
9438         * disasm.c: Revert.
9439         * disasm-selftests.c: Revert.
9440         * dictionary.c: Revert.
9441         * dicos-tdep.c: Revert.
9442         * demangle.c: Revert.
9443         * dcache.h: Revert.
9444         * dcache.c: Revert.
9445         * darwin-nat.h: Revert.
9446         * darwin-nat.c: Revert.
9447         * darwin-nat-info.c: Revert.
9448         * d-valprint.c: Revert.
9449         * d-namespace.c: Revert.
9450         * d-lang.c: Revert.
9451         * ctf.c: Revert.
9452         * csky-tdep.c: Revert.
9453         * csky-linux-tdep.c: Revert.
9454         * cris-tdep.c: Revert.
9455         * cris-linux-tdep.c: Revert.
9456         * cp-valprint.c: Revert.
9457         * cp-support.c: Revert.
9458         * cp-namespace.c: Revert.
9459         * cp-abi.c: Revert.
9460         * corelow.c: Revert.
9461         * corefile.c: Revert.
9462         * continuations.c: Revert.
9463         * completer.h: Revert.
9464         * completer.c: Revert.
9465         * complaints.c: Revert.
9466         * coffread.c: Revert.
9467         * coff-pe-read.c: Revert.
9468         * cli-out.h: Revert.
9469         * cli-out.c: Revert.
9470         * charset.c: Revert.
9471         * c-varobj.c: Revert.
9472         * c-valprint.c: Revert.
9473         * c-typeprint.c: Revert.
9474         * c-lang.c: Revert.
9475         * buildsym.c: Revert.
9476         * buildsym-legacy.c: Revert.
9477         * build-id.h: Revert.
9478         * build-id.c: Revert.
9479         * btrace.c: Revert.
9480         * bsd-uthread.c: Revert.
9481         * breakpoint.h: Revert.
9482         * breakpoint.c: Revert.
9483         * break-catch-throw.c: Revert.
9484         * break-catch-syscall.c: Revert.
9485         * break-catch-sig.c: Revert.
9486         * blockframe.c: Revert.
9487         * block.c: Revert.
9488         * bfin-tdep.c: Revert.
9489         * bfin-linux-tdep.c: Revert.
9490         * bfd-target.c: Revert.
9491         * bcache.c: Revert.
9492         * ax-general.c: Revert.
9493         * ax-gdb.h: Revert.
9494         * ax-gdb.c: Revert.
9495         * avr-tdep.c: Revert.
9496         * auxv.c: Revert.
9497         * auto-load.c: Revert.
9498         * arm-wince-tdep.c: Revert.
9499         * arm-tdep.c: Revert.
9500         * arm-symbian-tdep.c: Revert.
9501         * arm-pikeos-tdep.c: Revert.
9502         * arm-obsd-tdep.c: Revert.
9503         * arm-nbsd-tdep.c: Revert.
9504         * arm-nbsd-nat.c: Revert.
9505         * arm-linux-tdep.c: Revert.
9506         * arm-linux-nat.c: Revert.
9507         * arm-fbsd-tdep.c: Revert.
9508         * arm-fbsd-nat.c: Revert.
9509         * arm-bsd-tdep.c: Revert.
9510         * arch-utils.c: Revert.
9511         * arc-tdep.c: Revert.
9512         * arc-newlib-tdep.c: Revert.
9513         * annotate.h: Revert.
9514         * annotate.c: Revert.
9515         * amd64-windows-tdep.c: Revert.
9516         * amd64-windows-nat.c: Revert.
9517         * amd64-tdep.c: Revert.
9518         * amd64-sol2-tdep.c: Revert.
9519         * amd64-obsd-tdep.c: Revert.
9520         * amd64-obsd-nat.c: Revert.
9521         * amd64-nbsd-tdep.c: Revert.
9522         * amd64-nbsd-nat.c: Revert.
9523         * amd64-nat.c: Revert.
9524         * amd64-linux-tdep.c: Revert.
9525         * amd64-linux-nat.c: Revert.
9526         * amd64-fbsd-tdep.c: Revert.
9527         * amd64-fbsd-nat.c: Revert.
9528         * amd64-dicos-tdep.c: Revert.
9529         * amd64-darwin-tdep.c: Revert.
9530         * amd64-bsd-nat.c: Revert.
9531         * alpha-tdep.c: Revert.
9532         * alpha-obsd-tdep.c: Revert.
9533         * alpha-nbsd-tdep.c: Revert.
9534         * alpha-mdebug-tdep.c: Revert.
9535         * alpha-linux-tdep.c: Revert.
9536         * alpha-linux-nat.c: Revert.
9537         * alpha-bsd-tdep.c: Revert.
9538         * alpha-bsd-nat.c: Revert.
9539         * aix-thread.c: Revert.
9540         * agent.c: Revert.
9541         * addrmap.c: Revert.
9542         * ada-varobj.c: Revert.
9543         * ada-valprint.c: Revert.
9544         * ada-typeprint.c: Revert.
9545         * ada-tasks.c: Revert.
9546         * ada-lang.c: Revert.
9547         * aarch64-tdep.c: Revert.
9548         * aarch64-ravenscar-thread.c: Revert.
9549         * aarch64-newlib-tdep.c: Revert.
9550         * aarch64-linux-tdep.c: Revert.
9551         * aarch64-linux-nat.c: Revert.
9552         * aarch64-fbsd-tdep.c: Revert.
9553         * aarch64-fbsd-nat.c: Revert.
9554         * aarch32-linux-nat.c: Revert.
9555
9556 2019-04-05  Tom Tromey  <tom@tromey.com>
9557
9558         * ft32-tdep.c: Sort headers.
9559         * frv-tdep.c: Sort headers.
9560         * frv-linux-tdep.c: Sort headers.
9561         * frame.c: Sort headers.
9562         * frame-unwind.c: Sort headers.
9563         * frame-base.c: Sort headers.
9564         * fork-child.c: Sort headers.
9565         * findvar.c: Sort headers.
9566         * findcmd.c: Sort headers.
9567         * filesystem.c: Sort headers.
9568         * filename-seen-cache.h: Sort headers.
9569         * filename-seen-cache.c: Sort headers.
9570         * fbsd-tdep.c: Sort headers.
9571         * fbsd-nat.h: Sort headers.
9572         * fbsd-nat.c: Sort headers.
9573         * f-valprint.c: Sort headers.
9574         * f-typeprint.c: Sort headers.
9575         * f-lang.c: Sort headers.
9576         * extension.h: Sort headers.
9577         * extension.c: Sort headers.
9578         * extension-priv.h: Sort headers.
9579         * expprint.c: Sort headers.
9580         * exec.h: Sort headers.
9581         * exec.c: Sort headers.
9582         * exceptions.c: Sort headers.
9583         * event-top.c: Sort headers.
9584         * event-loop.c: Sort headers.
9585         * eval.c: Sort headers.
9586         * elfread.c: Sort headers.
9587         * dwarf2read.h: Sort headers.
9588         * dwarf2read.c: Sort headers.
9589         * dwarf2loc.c: Sort headers.
9590         * dwarf2expr.h: Sort headers.
9591         * dwarf2expr.c: Sort headers.
9592         * dwarf2-frame.c: Sort headers.
9593         * dwarf2-frame-tailcall.c: Sort headers.
9594         * dwarf-index-write.h: Sort headers.
9595         * dwarf-index-write.c: Sort headers.
9596         * dwarf-index-common.c: Sort headers.
9597         * dwarf-index-cache.h: Sort headers.
9598         * dwarf-index-cache.c: Sort headers.
9599         * dummy-frame.c: Sort headers.
9600         * dtrace-probe.c: Sort headers.
9601         * disasm.h: Sort headers.
9602         * disasm.c: Sort headers.
9603         * disasm-selftests.c: Sort headers.
9604         * dictionary.c: Sort headers.
9605         * dicos-tdep.c: Sort headers.
9606         * demangle.c: Sort headers.
9607         * dcache.h: Sort headers.
9608         * dcache.c: Sort headers.
9609         * darwin-nat.h: Sort headers.
9610         * darwin-nat.c: Sort headers.
9611         * darwin-nat-info.c: Sort headers.
9612         * d-valprint.c: Sort headers.
9613         * d-namespace.c: Sort headers.
9614         * d-lang.c: Sort headers.
9615         * ctf.c: Sort headers.
9616         * csky-tdep.c: Sort headers.
9617         * csky-linux-tdep.c: Sort headers.
9618         * cris-tdep.c: Sort headers.
9619         * cris-linux-tdep.c: Sort headers.
9620         * cp-valprint.c: Sort headers.
9621         * cp-support.c: Sort headers.
9622         * cp-namespace.c: Sort headers.
9623         * cp-abi.c: Sort headers.
9624         * corelow.c: Sort headers.
9625         * corefile.c: Sort headers.
9626         * continuations.c: Sort headers.
9627         * completer.h: Sort headers.
9628         * completer.c: Sort headers.
9629         * complaints.c: Sort headers.
9630         * coffread.c: Sort headers.
9631         * coff-pe-read.c: Sort headers.
9632         * cli-out.h: Sort headers.
9633         * cli-out.c: Sort headers.
9634         * charset.c: Sort headers.
9635         * c-varobj.c: Sort headers.
9636         * c-valprint.c: Sort headers.
9637         * c-typeprint.c: Sort headers.
9638         * c-lang.c: Sort headers.
9639         * buildsym.c: Sort headers.
9640         * buildsym-legacy.c: Sort headers.
9641         * build-id.h: Sort headers.
9642         * build-id.c: Sort headers.
9643         * btrace.c: Sort headers.
9644         * bsd-uthread.c: Sort headers.
9645         * breakpoint.h: Sort headers.
9646         * breakpoint.c: Sort headers.
9647         * break-catch-throw.c: Sort headers.
9648         * break-catch-syscall.c: Sort headers.
9649         * break-catch-sig.c: Sort headers.
9650         * blockframe.c: Sort headers.
9651         * block.c: Sort headers.
9652         * bfin-tdep.c: Sort headers.
9653         * bfin-linux-tdep.c: Sort headers.
9654         * bfd-target.c: Sort headers.
9655         * bcache.c: Sort headers.
9656         * ax-general.c: Sort headers.
9657         * ax-gdb.h: Sort headers.
9658         * ax-gdb.c: Sort headers.
9659         * avr-tdep.c: Sort headers.
9660         * auxv.c: Sort headers.
9661         * auto-load.c: Sort headers.
9662         * arm-wince-tdep.c: Sort headers.
9663         * arm-tdep.c: Sort headers.
9664         * arm-symbian-tdep.c: Sort headers.
9665         * arm-pikeos-tdep.c: Sort headers.
9666         * arm-obsd-tdep.c: Sort headers.
9667         * arm-nbsd-tdep.c: Sort headers.
9668         * arm-nbsd-nat.c: Sort headers.
9669         * arm-linux-tdep.c: Sort headers.
9670         * arm-linux-nat.c: Sort headers.
9671         * arm-fbsd-tdep.c: Sort headers.
9672         * arm-fbsd-nat.c: Sort headers.
9673         * arm-bsd-tdep.c: Sort headers.
9674         * arch-utils.c: Sort headers.
9675         * arc-tdep.c: Sort headers.
9676         * arc-newlib-tdep.c: Sort headers.
9677         * annotate.h: Sort headers.
9678         * annotate.c: Sort headers.
9679         * amd64-windows-tdep.c: Sort headers.
9680         * amd64-windows-nat.c: Sort headers.
9681         * amd64-tdep.c: Sort headers.
9682         * amd64-sol2-tdep.c: Sort headers.
9683         * amd64-obsd-tdep.c: Sort headers.
9684         * amd64-obsd-nat.c: Sort headers.
9685         * amd64-nbsd-tdep.c: Sort headers.
9686         * amd64-nbsd-nat.c: Sort headers.
9687         * amd64-nat.c: Sort headers.
9688         * amd64-linux-tdep.c: Sort headers.
9689         * amd64-linux-nat.c: Sort headers.
9690         * amd64-fbsd-tdep.c: Sort headers.
9691         * amd64-fbsd-nat.c: Sort headers.
9692         * amd64-dicos-tdep.c: Sort headers.
9693         * amd64-darwin-tdep.c: Sort headers.
9694         * amd64-bsd-nat.c: Sort headers.
9695         * alpha-tdep.c: Sort headers.
9696         * alpha-obsd-tdep.c: Sort headers.
9697         * alpha-nbsd-tdep.c: Sort headers.
9698         * alpha-mdebug-tdep.c: Sort headers.
9699         * alpha-linux-tdep.c: Sort headers.
9700         * alpha-linux-nat.c: Sort headers.
9701         * alpha-bsd-tdep.c: Sort headers.
9702         * alpha-bsd-nat.c: Sort headers.
9703         * aix-thread.c: Sort headers.
9704         * agent.c: Sort headers.
9705         * addrmap.c: Sort headers.
9706         * ada-varobj.c: Sort headers.
9707         * ada-valprint.c: Sort headers.
9708         * ada-typeprint.c: Sort headers.
9709         * ada-tasks.c: Sort headers.
9710         * ada-lang.c: Sort headers.
9711         * aarch64-tdep.c: Sort headers.
9712         * aarch64-ravenscar-thread.c: Sort headers.
9713         * aarch64-newlib-tdep.c: Sort headers.
9714         * aarch64-linux-tdep.c: Sort headers.
9715         * aarch64-linux-nat.c: Sort headers.
9716         * aarch64-fbsd-tdep.c: Sort headers.
9717         * aarch64-fbsd-nat.c: Sort headers.
9718         * aarch32-linux-nat.c: Sort headers.
9719
9720 2019-04-04  Tom Tromey  <tom@tromey.com>
9721
9722         * varobj.c (varobj_create): Update.
9723         * rust-exp.y (struct rust_parser) <update_innermost_block,
9724         lookup_symbol>: New methods.
9725         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9726         Rename.
9727         (rust_parser::rust_lookup_type)
9728         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9729         * printcmd.c (display_command, do_one_display): Update.
9730         * parser-defs.h (struct parser_state) <parser_state>: Add
9731         "tracker" parameter.
9732         (block_tracker): New member.
9733         (class innermost_block_tracker) <innermost_block_tracker>: Add
9734         "types" parameter.
9735         <reset>: Remove method.
9736         (innermost_block): Don't declare.
9737         (null_post_parser): Update.
9738         * parse.c (innermost_block): Remove global.
9739         (write_dollar_variable): Update.
9740         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9741         Remove "tracker_types" parameter.
9742         (parse_expression): Add "tracker" parameter.
9743         (parse_expression_for_completion): Update.
9744         (null_post_parser): Add "tracker" parameter.
9745         * p-exp.y: Update rules.
9746         * m2-exp.y: Update rules.
9747         * language.h (struct language_defn) <la_post_parser>: Add
9748         "tracker" parameter.
9749         * go-exp.y: Update rules.
9750         * f-exp.y: Update rules.
9751         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9752         parameter.
9753         * d-exp.y: Update rules.
9754         * c-exp.y: Update rules.
9755         * breakpoint.c (set_breakpoint_condition): Create an
9756         innermost_block_tracker.
9757         (watch_command_1): Likewise.
9758         * ada-lang.c (resolve): Add "tracker" parameter.
9759         (resolve_subexp): Likewise.
9760         * ada-exp.y (write_var_from_sym): Update.
9761
9762 2019-04-04  Tom Tromey  <tom@tromey.com>
9763
9764         * type-stack.h: New file.
9765         * type-stack.c: New file.
9766         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9767         type-stack.h.
9768         (insert_into_type_stack, insert_type, push_type, push_type_int)
9769         (insert_type_address_space, pop_type, pop_type_int)
9770         (pop_typelist, pop_type_stack, append_type_stack)
9771         (push_type_stack, get_type_stack, push_typelist)
9772         (follow_type_instance_flags, follow_types): Don't declare.
9773         * parse.c (type_stack): Remove global.
9774         (parse_exp_in_context): Update.
9775         (insert_into_type_stack, insert_type, push_type, push_type_int)
9776         (insert_type_address_space, pop_type, pop_type_int)
9777         (pop_typelist, pop_type_stack, append_type_stack)
9778         (push_type_stack, get_type_stack, push_typelist)
9779         (follow_type_instance_flags, follow_types): Remove (moved to
9780         type-stack.c).
9781         * f-exp.y (type_stack): New global.
9782         Update rules.
9783         (push_kind_type, f_parse): Update.
9784         * d-exp.y (type_stack): New global.
9785         Update rules.
9786         (d_parse): Update.
9787         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9788         Update rules.
9789         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9790         (HFILES_NO_SRCDIR): Add type-stack.h.
9791
9792 2019-04-04  Tom Tromey  <tom@tromey.com>
9793
9794         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9795         (rust_parser::convert_ast_to_expression, rust_parse)
9796         (rust_lex_test_completion, rust_lex_tests): Update.
9797         * parser-defs.h (struct expr_completion_state): New.
9798         (struct parser_state) <parser_state>: Add completion parameter.
9799         <mark_struct_expression, mark_completion_tag>: New methods.
9800         <parse_completion, m_completion_state>: New members.
9801         (prefixify_expression, null_post_parser): Update.
9802         (mark_struct_expression, mark_completion_tag): Don't declare.
9803         * parse.c (parse_completion, expout_last_struct)
9804         (expout_tag_completion_type, expout_completion_name): Remove
9805         globals.
9806         (parser_state::mark_struct_expression)
9807         (parser_state::mark_completion_tag): Now methods.
9808         (prefixify_expression): Add last_struct parameter.
9809         (prefixify_subexp): Likewise.
9810         (parse_exp_1): Update.
9811         (parse_exp_in_context): Add cstate parameter.  Update.
9812         (parse_expression_for_completion): Create an
9813         expr_completion_state.
9814         (null_post_parser): Add "completion" parameter.
9815         * p-exp.y: Update rules.
9816         (yylex): Update.
9817         * language.h (struct language_defn) <la_post_parser>: Add
9818         "completing" parameter.
9819         * go-exp.y: Update rules.
9820         (lex_one_token): Update.
9821         * expression.h (parse_completion): Don't declare.
9822         * d-exp.y: Update rules.
9823         (lex_one_token): Update rules.
9824         * c-exp.y: Update rules.
9825         (lex_one_token): Update.
9826         * ada-lang.c (resolve): Add "parse_completion" parameter.
9827         (resolve_subexp): Likewise.
9828         (ada_resolve_function): Likewise.
9829
9830 2019-04-04  Tom Tromey  <tom@tromey.com>
9831
9832         * parser-defs.h (struct parser_state) <start_arglist,
9833         end_arglist>: New methods.
9834         <arglist_len, m_funcall_chain>: New members.
9835         (arglist_len, start_arglist, end_arglist): Don't declare.
9836         * parse.c (arglist_len, funcall_chain): Remove global.
9837         (start_arglist, end_arglist): Remove functions.
9838         (parse_exp_in_context): Update.
9839         * p-exp.y: Update rules.
9840         * m2-exp.y: Update rules.
9841         * go-exp.y: Update rules.
9842         * f-exp.y: Update rules.
9843         * d-exp.y: Update rules.
9844         * c-exp.y: Update rules.
9845
9846 2019-04-04  Tom Tromey  <tom@tromey.com>
9847
9848         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9849         lex_operator, push_back>: New methods.
9850         Update all rules.
9851         (rust_parser::lex_hex, lex_escape): Rename and update.
9852         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9853         (rust_parser::lex_operator): Rename and update.
9854         (rust_parser::lex_number, rustyylex, rustyyerror)
9855         (rust_lex_test_init, rust_lex_test_sequence)
9856         (rust_lex_test_push_back, rust_lex_tests): Update.
9857         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9858         parameter.
9859         <lexptr, prev_lexptr>: New members.
9860         (lexptr, prev_lexptr): Don't declare.
9861         * parse.c (lexptr, prev_lexptr): Remove globals.
9862         (parse_exp_in_context): Update.
9863         * p-exp.y (yylex, yyerror): Update.
9864         * m2-exp.y (parse_number, yylex, yyerror): Update.
9865         * go-exp.y (lex_one_token, yyerror): Update.
9866         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9867         * d-exp.y (lex_one_token, yyerror): Update.
9868         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9869         (lex_one_token, yyerror): Update.
9870         * ada-lex.l (YY_INPUT): Update.
9871         (rewind_to_char): Update.
9872         * ada-exp.y (yyerror): Update.
9873
9874 2019-04-04  Tom Tromey  <tom@tromey.com>
9875
9876         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9877         * parser-defs.h (struct parser_state) <parser_state>: Add new
9878         parameter.
9879         <comma_terminates>: New member.
9880         (comma_terminates): Don't declare global.
9881         * parse.c (comma_terminates): Remove global.
9882         (parse_exp_in_context): Update.
9883         * p-exp.y (yylex): Update.
9884         * m2-exp.y (yylex): Update.
9885         * go-exp.y (lex_one_token): Update.
9886         * f-exp.y (yylex): Update.
9887         * d-exp.y (lex_one_token): Update.
9888         * c-exp.y (lex_one_token): Update.
9889         * ada-lex.l: Update.
9890
9891 2019-04-04  Tom Tromey  <tom@tromey.com>
9892
9893         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9894         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9895         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9896         * parser-defs.h (paren_depth): Don't declare.
9897         * parse.c (paren_depth): Remove global.
9898         (parse_exp_in_context): Update.
9899         * p-exp.y (paren_depth): New global.
9900         (pascal_parse): Initialize it.
9901         * m2-exp.y (paren_depth): New global.
9902         (m2_parse): Initialize it.
9903         * go-exp.y (paren_depth): New global.
9904         (go_parse): Initialize it.
9905         * f-exp.y (paren_depth): New global.
9906         (f_parse): Initialize it.
9907         * d-exp.y (paren_depth): New global.
9908         (d_parse): Initialize it.
9909         * c-exp.y (paren_depth): New global.
9910         (c_parse): Initialize it.
9911         * ada-lex.l (paren_depth): New global.
9912         (lexer_init): Initialize it.
9913
9914 2019-04-04  Tom Tromey  <tom@tromey.com>
9915
9916         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9917         (rust_parser::convert_ast_to_type)
9918         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9919         * parser-defs.h (struct parser_state) <parser_state>: Add
9920         parameters.  Initialize new members.
9921         <expression_context_block, expression_context_pc>: New members.
9922         * parse.c (expression_context_block, expression_context_pc):
9923         Remove globals.
9924         (parse_exp_in_context): Update.
9925         * p-exp.y: Update all rules.
9926         (yylex): Update.
9927         * m2-exp.y: Update all rules.
9928         (yylex): Update.
9929         * go-exp.y (yylex): Update.
9930         * f-exp.y (yylex): Update.
9931         * d-exp.y: Update all rules.
9932         (yylex): Update.
9933         * c-exp.y: Update all rules.
9934         (lex_one_token, classify_name, yylex, c_parse): Update.
9935         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9936
9937 2019-04-04  Tom Tromey  <tom@tromey.com>
9938
9939         * gdbarch.h, gdbarch.c: Rebuild.
9940         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9941         * stap-probe.h:
9942         (struct stap_parse_info): Replace "parser_state" with
9943         "expr_builder".
9944         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9945         (parser_state): New class.
9946         * parse.c (expr_builder): Rename.
9947         (expr_builder::release): Rename.
9948         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9949         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9950         (write_exp_elt_longcst, write_exp_elt_floatcst)
9951         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9952         (write_exp_string_vector, write_exp_bitstring)
9953         (write_exp_msymbol, mark_struct_expression)
9954         (write_dollar_variable)
9955         (insert_type_address_space, increase_expout_size): Replace
9956         "parser_state" with "expr_builder".
9957         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9958         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9959         "parser_state" with "expr_builder".
9960
9961 2019-04-04  Tom Tromey  <tom@tromey.com>
9962
9963         * rust-exp.y: Replace "parse_language" with method call.
9964         * p-exp.y:
9965         (yylex): Replace "parse_language" with method call.
9966         * m2-exp.y:
9967         (yylex): Replace "parse_language" with method call.
9968         * go-exp.y (classify_name): Replace "parse_language" with method
9969         call.
9970         * f-exp.y (yylex): Replace "parse_language" with method call.
9971         * d-exp.y (lex_one_token): Replace "parse_language" with method
9972         call.
9973         * c-exp.y:
9974         (lex_one_token, classify_name, yylex): Replace "parse_language"
9975         with method call.
9976         * ada-exp.y (find_primitive_type, type_char)
9977         (type_system_address): Replace "parse_language" with method call.
9978
9979 2019-04-04  Tom Tromey  <tom@tromey.com>
9980
9981         * rust-exp.y: Replace "parse_gdbarch" with method call.
9982         * parse.c (write_dollar_variable, insert_type_address_space):
9983         Replace "parse_gdbarch" with method call.
9984         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9985         call.
9986         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9987         call.
9988         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9989         "parse_gdbarch" with method call.
9990         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9991         with method call.
9992         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9993         "parse_gdbarch" with method call.
9994         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9995         "parse_gdbarch" with method call.
9996         * c-exp.y (parse_type, parse_number, classify_name): Replace
9997         "parse_gdbarch" with method call.
9998         * ada-lex.l: Replace "parse_gdbarch" with method call.
9999         * ada-exp.y (parse_type, find_primitive_type, type_char)
10000         (type_system_address): Replace "parse_gdbarch" with method call.
10001
10002 2019-04-04  Tom Tromey  <tom@tromey.com>
10003
10004         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10005         * stap-probe.c (stap_parse_argument): Update.
10006         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10007         initial_size parameter.
10008         * rust-exp.y (rust_lex_tests): Update.
10009         * parse.c (parser_state): Update.
10010         (parse_exp_in_context): Update.
10011         * parser-defs.h (struct parser_state) <parser_state>: Remove
10012         "initial_size" parameter.
10013
10014 2019-04-04  Tom Tromey  <tom@tromey.com>
10015
10016         * parser-defs.h (increase_expout_size): Don't declare.
10017         * parse.c (increase_expout_size): Now static.
10018
10019 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10020
10021         * gnu-nat.c (gnu_nat_target::wait): Fix
10022         target_waitstatus_to_string call.
10023
10024 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10025
10026         * eval.c (evaluate_subexp_standard): Handle internal functions
10027         during Fortran function call handling.
10028
10029 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10030
10031         * NEWS: Mention new internal functions.
10032         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10033         (read_base_type): Use dwarf2_init_complex_target_type.
10034         * value.c (creal_internal_fn): New function.
10035         (cimag_internal_fn): New function.
10036         (_initialize_values): Register new internal functions.
10037
10038 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10039
10040         * infrun.c (stop_all_threads): If debug_infrun, always
10041         trace the wait status after wait_one, using
10042         target_waitstatus_to_string and target_pid_to_str.
10043         (handle_inferior_event): Replace various trace of
10044         wait status kind by a single trace.
10045         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10046         wait status kind image by target_waitstatus_to_string.
10047         * target/waitstatus.c (target_waitstatus_to_string): Fix
10048         obsolete comment.
10049
10050 2019-04-01  Tom Tromey  <tromey@adacore.com>
10051
10052         PR symtab/23331:
10053         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10054
10055 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10056             Pedro Alves  <palves@redhat.com>
10057
10058         * top.c (quit_force): Call 'finalize_values'.
10059         * value.c (finalize_values): New function.
10060         * value.h (finalize_values): Declare.
10061
10062 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10063
10064         * NEWS: Announce $_gdb_major and $_gdb_minor.
10065
10066         * top.c (init_gdb_version_vars): New function.
10067         (gdb_init): Call init_gdb_version_vars.
10068
10069 2019-03-29  Tom Tromey  <tromey@adacore.com>
10070
10071         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10072         help text.  Remove dead code.
10073
10074 2019-03-29  Keith Seitz  <keiths@redhat.com>
10075
10076         From Siddhesh Poyarekar:
10077         * f-lang.h (f77_get_upperbound): Return LONGEST.
10078         (f77_get_lowerbound): Likewise.
10079         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10080         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10081         print them.
10082         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10083         plongest to format print it.
10084         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10085         (f77_get_upperbound): Likewise.
10086         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10087         LOWER_BOUND to LONGEST.
10088         (f77_create_arrayprint_offset_tbl): Likewise.
10089
10090 2019-03-29  Keith Seitz  <keiths@redhat.com>
10091
10092         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10093         %s/pulongest for TYPE_LENGTH instead of %d in format
10094         strings.
10095         * ada-typerint.c (ada_print_type): Likewise.
10096         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10097         * compile/compile-c-support.c (generate_register_struct): Likewise.
10098         * gdbtypes.c (recursive_dump_type): Likewise.
10099         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10100         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10101         instead of %d in format strings.
10102         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10103         to std::min to ULONGEST.
10104         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10105         instead of %d in format strings.
10106         * tracepoint.c (info_scope_command): Likewise.
10107         * typeprint.c (print_offset_data::update)
10108         (print_offset_data::finish): Likewise.
10109         * xtensa-tdep.c (xtensa_store_return_value)
10110         (xtensa_push_dummy_call): Likewise.
10111
10112 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10113
10114         * windows-nat.c (display_selector): Fixed format specifications
10115         for 64-bit Cygwin.
10116
10117 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10118
10119         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10120
10121 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10122
10123         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10124         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10125         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10126         (nios2_linux_init_abi): Install it.
10127
10128 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10129
10130         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10131
10132 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10133
10134         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10135
10136 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10137             Tom Tromey  <tromey@adacore.com>
10138
10139         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10140
10141 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10142
10143         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10144         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10145         method to compute the bounds of range types. Also print "[evaluated]"
10146         if the bounds' values come from a dynamic evaluation.
10147
10148 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10149
10150         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10151         whitespace when pretty printing is on.
10152
10153 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10154
10155         * ppc-linux-nat.c: Add include.
10156
10157 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10158
10159         * NEWS: Mention AArch64 Pointer Authentication.
10160
10161 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10162
10163         * arm-linux-nat.c: Add include.
10164
10165 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10166
10167         * source-cache.c (source_cache::get_source_lines): Re-read
10168         fullname after calling open_source_file.
10169
10170 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10171
10172         * NEWS: Mention TLS support for FreeBSD.
10173
10174 2019-03-25  Tom Tromey  <tromey@adacore.com>
10175
10176         * minsyms.c (BUNCH_SIZE): Update comment.
10177         (~minimal_symbol_reader): Remove old comment.
10178         (compact_minimal_symbols): Update comment.
10179         (minimal_symbol_reader::install): Remove old comment.  Update
10180         other comments.
10181
10182 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10183
10184         * s390-linux-nat.c: Add include.
10185
10186 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10187
10188         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10189         Call linux_get_hwcap.
10190         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10191         Likewise.
10192         (aarch64_linux_get_hwcap): Remove function.
10193         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10194         declaration.
10195         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10196         linux_get_hwcap.
10197         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10198         * linux-tdep.c (linux_get_hwcap): Add function.
10199         (linux_get_hwcap2): Likewise.
10200         * linux-tdep.h (linux_get_hwcap): Add declaration.
10201         (linux_get_hwcap2): Likewise.
10202         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10203         (ppc_linux_get_hwcap2): Likewise.
10204         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10205         linux_get_hwcap.
10206         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10207         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10208         (ppc_linux_nat_target::read_description): Likewise.
10209         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10210         * s390-linux-nat.c: Likewise.
10211         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10212
10213 2019-03-24  Tom Tromey  <tom@tromey.com>
10214
10215         * ada-lang.c (standard_lookup): Simplify initialization.
10216         (ada_lookup_symbol_nonlocal): Simplify return.
10217         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10218         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10219         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10220         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10221         initialization.
10222         * solib.c (solib_global_lookup): Simplify.
10223         * symtab.c (null_block_symbol): Remove.
10224         (symbol_cache_lookup): Simplify returns.
10225         (lookup_language_this): Simplify returns.
10226         (lookup_symbol_aux): Simplify return.
10227         (lookup_local_symbol): Simplify returns.
10228         (lookup_global_symbol_from_objfile): Simplify return.
10229         (lookup_symbol_in_objfile_symtabs)
10230         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10231         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10232         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10233         * cp-namespace.c (cp_lookup_bare_symbol)
10234         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10235         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10236         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10237         (cp_lookup_symbol_via_imports): Simplify initialization.
10238         (find_symbol_in_baseclass): Likewise.
10239         * symtab.h (null_block_symbol): Remove.
10240         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10241         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10242         (d_lookup_symbol_module): Likewise.
10243         (find_symbol_in_baseclass): Simplify initialization.
10244
10245 2019-03-24  Tom Tromey  <tom@tromey.com>
10246
10247         * expression.h: Don't include symtab.h.
10248         (struct block): Forward declare.
10249
10250 2019-03-24  Tom Tromey  <tom@tromey.com>
10251
10252         * c-exp.y (typebase): Remove casts.
10253         * gdbtypes.c (lookup_unsigned_typename, )
10254         (lookup_signed_typename): Remove cast.
10255         * eval.c (parse_to_comma_and_eval): Remove cast.
10256         * parse.c (write_dollar_variable): Remove cast.
10257         * block.h (struct block) <superblock>: Now const.
10258         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10259         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10260         (map_block): Make "block" const.
10261         * symfile.h (struct quick_symbol_functions)
10262         <map_matching_symbols>: Constify block argument to "callback".
10263         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10264         const.
10265         (find_pc_sect_compunit_symtab): Make "b" const.
10266         (find_symbol_at_address): Likewise.
10267         (search_symbols): Likewise.
10268         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10269         (dw2_debug_names_lookup_symbol): Likewise.
10270         (dw2_map_matching_symbols): Update.
10271         * p-valprint.c (pascal_val_print): Remove "block".
10272         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10273         (aux_add_nonlocal_symbols): Make "block" const.
10274         (resolve_subexp): Remove cast.
10275         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10276         const.
10277         (iterate_over_file_blocks): Likewise.
10278         * f-exp.y (%union) <bval>: Remove.
10279         * coffread.c (patch_opaque_types): Make "b" const.
10280         * spu-tdep.c (spu_catch_start): Make "block" const.
10281         * c-valprint.c (print_unpacked_pointer): Remove "block".
10282         * symmisc.c (dump_symtab_1): Make "b" const.
10283         (block_depth): Make "block" const.
10284         * d-exp.y (%union) <bval>: Remove.
10285         * cp-support.h (cp_lookup_rtti_type): Update.
10286         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10287         * psymtab.c (psym_lookup_symbol): Make "block" const.
10288         (maintenance_check_psymtabs): Make "b" const.
10289         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10290         (enumerate_locals, enumerate_args): Update.
10291         * python/py-symtab.c (stpy_global_block): Make "block" const.
10292         (stpy_static_block): Likewise.
10293         * inline-frame.c (block_starting_point_at): Make "new_block"
10294         const.
10295         * block.c (find_block_in_blockvector): Make return type const.
10296         (blockvector_for_pc_sect): Make "b" const.
10297         (find_block_in_blockvector): Make "b" const.
10298
10299 2019-03-23  Tom Tromey  <tom@tromey.com>
10300
10301         * varobj.c (varobj_create): Update.
10302         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10303         * printcmd.c (display_command, do_one_display): Don't reset
10304         innermost_block.
10305         * parser-defs.h (enum innermost_block_tracker_type): Move to
10306         expression.h.
10307         (innermost_block): Update comment.
10308         * parse.c (parse_exp_1): Add tracker_types parameter.
10309         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10310         tracker_types parameter.  Reset innermost_block.
10311         (parse_exp_in_context): Remove.
10312         (parse_expression_for_completion): Update.
10313         * objfiles.c (~objfile): Don't reset expression_context_block or
10314         innermost_block.
10315         * expression.h (enum innermost_block_tracker_type): Move from
10316         parser-defs.h.
10317         (parse_exp_1): Add tracker_types parameter.
10318         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10319         reset innermost_block.
10320
10321 2019-03-23  Tom Tromey  <tom@tromey.com>
10322
10323         * objfiles.h: Include bcache.h.
10324
10325 2019-03-23  Tom Tromey  <tom@tromey.com>
10326
10327         * linespec.c (get_current_search_block): Use
10328         scoped_restore_current_language.
10329         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10330
10331 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10332             Jiong Wang  <jiong.wang@arm.com>
10333
10334         * aarch64-linux-tdep.c
10335         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10336         section.
10337         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10338
10339 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10340             Jiong Wang  <jiong.wang@arm.com>
10341
10342         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10343         instructions.
10344         (aarch64_analyze_prologue_test): Add PACIASP test.
10345         (aarch64_prologue_prev_register): Unmask PC value.
10346
10347 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10348             Jiong Wang  <jiong.wang@arm.com>
10349
10350         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10351         (aarch64_dwarf2_prev_register): Unmask PC value.
10352         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10353         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10354         DW_CFA_AARCH64_negate_ra_state.
10355         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10356
10357 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10358             Jiong Wang  <jiong.wang@arm.com>
10359
10360         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10361         registers.
10362         (aarch64_pseudo_register_name): Likewise.
10363         (aarch64_pseudo_register_type): Likewise.
10364         (aarch64_pseudo_register_reggroup_p): Likewise.
10365         (aarch64_gdbarch_init): Add pauth registers.
10366         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10367         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10368         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10369         (struct gdbarch_tdep): Add regnum for ra_state.
10370
10371 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10372             Jiong Wang  <jiong.wang@arm.com>
10373
10374         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10375
10376 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10377             Jiong Wang  <jiong.wang@arm.com>
10378
10379         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10380         function.
10381         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10382         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10383         (aarch64_gdbarch_init): Add puth registers.
10384         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10385         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10386         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10387
10388 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10389             Jiong Wang  <jiong.wang@arm.com>
10390
10391         * aarch64-linux-nat.c
10392         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10393         * aarch64-linux-tdep.c
10394         (aarch64_linux_core_read_description): Likewise.
10395         (aarch64_linux_get_hwcap): New function.
10396         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10397         (aarch64_linux_get_hwcap): New declaration.
10398
10399 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10400             Jiong Wang  <jiong.wang@arm.com>
10401
10402         * aarch64-linux-nat.c
10403         (aarch64_linux_nat_target::read_description): Add pauth param.
10404         * aarch64-linux-tdep.c
10405         (aarch64_linux_core_read_description): Likewise.
10406         * aarch64-tdep.c (struct target_desc): Add in pauth.
10407         (aarch64_read_description): Add pauth param.
10408         (aarch64_gdbarch_init): Likewise.
10409         * aarch64-tdep.h (aarch64_read_description): Likewise.
10410         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10411         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10412         * features/Makefile: Add new files.
10413         * features/aarch64-pauth.c: New file.
10414         * features/aarch64-pauth.xml: New file.
10415
10416 2019-03-20  Tom Tromey  <tromey@adacore.com>
10417
10418         * infrun.c (handle_inferior_event): Rename from
10419         handle_inferior_event_1.  Create a scoped_value_mark.
10420         (handle_inferior_event): Remove.
10421
10422 2019-03-19  Tom Tromey  <tromey@adacore.com>
10423
10424         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10425         * infrun.h (print_stop_event): Add "displays" parameter.
10426         * infrun.c (print_stop_event): Add "displays" parameter.
10427
10428 2019-03-19  Pedro Alves  <palves@redhat.com>
10429
10430         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10431         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10432         to -1.  Fix TABs vs spaces.
10433         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10434         * tui/tui-out.h (tui_ui_out) Add intro comments.
10435         <m_line, m_start_of_line>: In-class initialize, and add describing
10436         comment.
10437
10438 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10439
10440         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10441         variable names.
10442         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10443
10444 2019-03-18  Pedro Alves  <palves@redhat.com>
10445             Eli Zaretskii <eliz@gnu.org>
10446
10447         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10448         m_line and m_start_of_line.
10449
10450 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10451
10452         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10453         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10454         it returns a newline.  This fixes a regression in TU mode, whereby
10455         the next line is output on the same screen line as the user input.
10456
10457 2019-03-18  Tom Tromey  <tromey@adacore.com>
10458
10459         * minsyms.c (minimal_symbol_reader::install): Remove call to
10460         obstack_blank.
10461
10462 2019-03-18  Pedro Alves  <palves@redhat.com>
10463
10464         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10465         New globals.
10466         (apply_style): New, factored out from ...
10467         (apply_ansi_escape): ... this.  Handle reverse video mode.
10468         (tui_set_reverse_mode): New function.
10469         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10470         * tui/tui-winsource.c (tui_show_source_line): Use
10471         tui_set_reverse_mode instead of setting A_STANDOUT.
10472         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10473         New setter methods.
10474
10475 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10476
10477         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10478         Handle tabs.
10479
10480 2019-03-18  Tom Tromey  <tromey@adacore.com>
10481
10482         * ada-lang.c (empty_array): Add "high" parameter.
10483         (ada_evaluate_subexp): Update.
10484
10485 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10486
10487         * unittests/string_view-selftests.c: Define
10488         _initialize_string_view_selftests unconditionally.
10489
10490 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10491
10492         PR gdb/24350
10493         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10494
10495 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10496
10497         PR gdb/24351
10498         * windows-nat.c (display_selector): Fix format specifiers.
10499
10500 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10501
10502         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10503         tui_refill_source_window instead of tui_refresh_win, to update the
10504         current execution line.  This fixes redisplay of the current line
10505         when stepping through the code with "next" or "step".
10506
10507 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10508
10509         * source-cache.c (source_cache::get_source_lines): Call
10510         find_source_lines to initialize s->nlines.  This fixes vertical
10511         scrolling of TUI source window when the DOWN arrow is pressed.
10512
10513 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10514
10515         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10516         linux-thread-db.c (_initialize_thread_db): Likewise.
10517
10518 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10519
10520         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10521         wclrtoeol in tui_show_source_line".  This reverts changes made in
10522         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10523
10524 2019-03-15  Tom Tromey  <tom@tromey.com>
10525
10526         * symtab.h (struct minimal_symbol): Derive from
10527         general_symbol_info.
10528         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10529         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10530         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10531         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10532         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10533         (MSYMBOL_SEARCH_NAME): Update.
10534         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10535         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10536         * minsyms.c (minimal_symbol_reader::record_full): Update.
10537
10538 2019-03-15  Tom Tromey  <tom@tromey.com>
10539
10540         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10541
10542 2019-03-15  Tom Tromey  <tom@tromey.com>
10543
10544         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10545         unique_xmalloc_ptr.
10546         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10547         Update.
10548         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10549         (build_minimal_symbol_hash_tables)
10550         (minimal_symbol_reader::install): Update.
10551
10552 2019-03-15  Tom Tromey  <tom@tromey.com>
10553
10554         * symtab.c (create_demangled_names_hash): Update.
10555         (symbol_set_names): Update.
10556         * objfiles.h (struct objfile_per_bfd_storage)
10557         <demangled_names_hash>: Now an htab_up.
10558         * objfiles.c (objfile_per_bfd_storage): Simplify.
10559
10560 2019-03-15  Tom Tromey  <tom@tromey.com>
10561
10562         * objfiles.h (struct objfile_per_bfd_storage): Declare
10563         destructor.
10564         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10565         New.
10566         (get_objfile_bfd_data): Use new.  Don't initialize
10567         language_of_main.
10568         (free_objfile_per_bfd_storage): Remove.
10569         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10570
10571 2019-03-15  Tom Tromey  <tom@tromey.com>
10572
10573         * symfile.c (reread_symbols): Update.
10574         * objfiles.c (objfile::objfile): Update.
10575         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10576         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10577         comment.
10578         (minimal_symbol_reader::install): Update.
10579         (terminate_minimal_symbol_table): Remove.
10580         * jit.c (jit_object_close_impl): Update.
10581
10582 2019-03-15  Tom Tromey  <tom@tromey.com>
10583
10584         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10585         initializations.
10586
10587 2019-03-15  Tom Tromey  <tom@tromey.com>
10588
10589         * objfiles.h (struct objfile_per_bfd_storage)
10590         <demangled_hash_languages>: Now a bitset.
10591         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10592         (lookup_minimal_symbol): Update.
10593
10594 2019-03-15  Tom Tromey  <tom@tromey.com>
10595
10596         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10597         Don't return the symbol.
10598         * coffread.c (record_minimal_symbol): Use record_full.
10599
10600 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10601
10602         The MS-Windows port of ncurses fails to switch to a color pair if
10603         one or both of the colors are the implicit default colors.  This
10604         change records the default colors when TUI is initialized, and
10605         then specifies them explicitly when a color pair uses the default
10606         colors.  This allows color styling in TUI mode on MS-Windows.
10607
10608         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10609         ncurses_norm_attr.
10610         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10611         colors in ncurses_norm_attr.
10612         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10613         "none", replace it with the default color recorded in
10614         ncurses_norm_attr.
10615
10616 2019-03-14  Tom Tromey  <tromey@adacore.com>
10617
10618         * source-cache.h (class source_cache) <get_source_lines>: Return
10619         std::string.
10620         * source-cache.c (source_cache::extract_lines): Handle case where
10621         first_pos==npos.  Return std::string.
10622         (source_cache::get_source_lines): Update.
10623
10624 2019-03-14  Tom Tromey  <tromey@adacore.com>
10625
10626         * NEWS: Add item for "style sources" commands.
10627         * source-cache.c (source_cache::get_source_lines): Check
10628         source_styling.
10629         * cli/cli-style.c (source_styling): New global.
10630         (_initialize_cli_style): Add "style sources" commands.
10631         (show_style_sources): New function.
10632         * cli/cli-style.h (source_styling): Declare.
10633
10634 2019-03-14  Pedro Alves  <palves@redhat.com>
10635             Tom Tromey  <tromey@adacore.com>
10636
10637         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10638         * tui/tui-winsource.c (tui_refill_source_window): New function,
10639         from...
10640         (tui_horizontal_source_scroll): ... here.  Move some logic.
10641         * cli/cli-style.c (set_style_enabled): Notify new observable.
10642         * tui/tui-hooks.c (tui_redisplay_source): New function.
10643         (tui_attach_detach_observers): Attach or detach
10644         tui_redisplay_source.
10645         * observable.h (source_styling_changed): New observable.
10646         * observable.c: Define source_styling_changed observable.
10647
10648 2019-03-13  Tom Tromey  <tromey@adacore.com>
10649
10650         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10651         (i386_gnu_nat_target::store_registers): Update.
10652         * target-debug.h (target_debug_print_std_string): New macro.
10653         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10654         * windows-tdep.c (display_one_tib): Update.
10655         * tui/tui-stack.c (tui_make_status_line): Update.
10656         * top.c (print_inferior_quit_action): Update.
10657         * thread.c (thr_try_catch_cmd): Update.
10658         (add_thread_with_info): Update.
10659         (thread_target_id_str): Update.
10660         (thr_try_catch_cmd): Update.
10661         (thread_command): Update.
10662         (thread_find_command): Update.
10663         * record-btrace.c (record_btrace_target::info_record)
10664         (record_btrace_resume_thread, record_btrace_target::resume)
10665         (record_btrace_cancel_resume, record_btrace_step_thread)
10666         (record_btrace_target::wait, record_btrace_target::wait)
10667         (record_btrace_target::wait, record_btrace_target::stop): Update.
10668         * progspace.c (print_program_space): Update.
10669         * process-stratum-target.c
10670         (process_stratum_target::thread_address_space): Update.
10671         * linux-fork.c (linux_fork_mourn_inferior)
10672         (detach_checkpoint_command, info_checkpoints_command)
10673         (linux_fork_context): Update.
10674         (linux_fork_detach): Update.
10675         (class scoped_switch_fork_info): Update.
10676         (delete_checkpoint_command): Update.
10677         * infrun.c (follow_fork_inferior): Update.
10678         (follow_fork_inferior): Update.
10679         (proceed_after_vfork_done): Update.
10680         (handle_vfork_child_exec_or_exit): Update.
10681         (follow_exec): Update.
10682         (displaced_step_prepare_throw): Update.
10683         (displaced_step_restore): Update.
10684         (start_step_over): Update.
10685         (resume_1): Update.
10686         (clear_proceed_status_thread): Update.
10687         (proceed): Update.
10688         (print_target_wait_results): Update.
10689         (do_target_wait): Update.
10690         (context_switch): Update.
10691         (stop_all_threads): Update.
10692         (restart_threads): Update.
10693         (finish_step_over): Update.
10694         (handle_signal_stop): Update.
10695         (switch_back_to_stepped_thread): Update.
10696         (keep_going_pass_signal): Update.
10697         (print_exited_reason): Update.
10698         (normal_stop): Update.
10699         * inferior.c (inferior_pid_to_str): Change return type.
10700         (print_selected_inferior): Update.
10701         (add_inferior): Update.
10702         (detach_inferior): Update.
10703         * dummy-frame.c (fprint_dummy_frames): Update.
10704         * dcache.c (dcache_info_1): Update.
10705         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10706         (btrace_fetch, btrace_clear): Update.
10707         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10708         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10709         type.
10710         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10711         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10712         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10713         * gdbarch.c, gdbarch.h: Rebuild.
10714         * gdbarch.sh (core_pid_to_str): Change return type.
10715         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10716         return type.
10717         (windows_nat_target::pid_to_str): Change return type.
10718         (windows_delete_thread): Update.
10719         (windows_nat_target::attach): Update.
10720         (windows_nat_target::files_info): Update.
10721         * target-delegates.c: Rebuild.
10722         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10723         return type.
10724         (sol_thread_target::pid_to_str): Change return type.
10725         * remote.c (class remote_target) <pid_to_str>: Change return
10726         type.
10727         (remote_target::pid_to_str): Change return type.
10728         (extended_remote_target::attach, remote_target::remote_stop_ns)
10729         (remote_target::remote_notif_remove_queued_reply)
10730         (remote_target::push_stop_reply, remote_target::disable_btrace):
10731         Update.
10732         (extended_remote_target::attach): Update.
10733         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10734         type.
10735         (gdbsim_target::pid_to_str): Change return type.
10736         * ravenscar-thread.c (struct ravenscar_thread_target)
10737         <pid_to_str>: Change return type.
10738         (ravenscar_thread_target::pid_to_str): Change return type.
10739         * procfs.c (class procfs_target) <pid_to_str>: Change return
10740         type.
10741         (procfs_target::pid_to_str): Change return type.
10742         (procfs_target::attach): Update.
10743         (procfs_target::detach): Update.
10744         (procfs_target::fetch_registers): Update.
10745         (procfs_target::store_registers): Update.
10746         (procfs_target::wait): Update.
10747         (procfs_target::files_info): Update.
10748         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10749         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10750         return type.
10751         (nto_procfs_target::pid_to_str): Change return type.
10752         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10753         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10754         return type.
10755         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10756         (exit_lwp): Update.
10757         (attach_proc_task_lwp_callback, get_detach_signal)
10758         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10759         (linux_nat_target::resume, wait_lwp, stop_callback)
10760         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10761         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10762         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10763         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10764         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10765         type.
10766         (inf_ptrace_target::attach): Update.
10767         (inf_ptrace_target::files_info): Update.
10768         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10769         type.
10770         (go32_nat_target::pid_to_str): Change return type.
10771         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10772         (gnu_nat_target::wait): Update.
10773         (gnu_nat_target::wait): Update.
10774         (gnu_nat_target::resume): Update.
10775         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10776         (fbsd_nat_target::wait): Update.
10777         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10778         type.
10779         (darwin_nat_target::attach): Update.
10780         * corelow.c (class core_target) <pid_to_str>: Change return type.
10781         (core_target::pid_to_str): Change return type.
10782         * target.c (normal_pid_to_str): Change return type.
10783         (default_pid_to_str): Likewise.
10784         (target_pid_to_str): Change return type.
10785         (target_translate_tls_address): Update.
10786         (target_announce_detach): Update.
10787         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10788         return type.
10789         (bsd_uthread_target::pid_to_str): Change return type.
10790         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10791         type.
10792         (bsd_kvm_target::pid_to_str): Change return type.
10793         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10794         return type.
10795         (aix_thread_target::pid_to_str): Change return type.
10796         * target.h (struct target_ops) <pid_to_str>: Change return type.
10797         (target_pid_to_str, normal_pid_to_str): Likewise.
10798         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10799         type.
10800         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10801         type.
10802         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10803         return type.
10804         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10805         type.
10806         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10807         type.
10808         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10809         return type.
10810
10811 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10812
10813         * NEWS: Mention that the new default MI version is 3.  Mention
10814         changes to the output of commands and events that deal with
10815         multi-location breakpoints.
10816         * breakpoint.c: Include "mi/mi-out.h".
10817         (print_one_breakpoint): Change output syntax if using MI version
10818         >= 3.
10819         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10820         New.
10821         (mi_multi_location_breakpoint_output_fixed): New.
10822         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10823         (mi_cmd_fix_multi_location_breakpoint_output): New.
10824         (mi_multi_location_breakpoint_output_fixed): New.
10825         * mi/mi-cmds.c (mi_cmds): Register command
10826         -fix-multi-location-breakpoint-output.
10827         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10828         interpreter "mi".
10829
10830 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10831
10832         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10833         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10834         instantiate mi_ui_out based on interpreter name.
10835         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10836         * mi/mi-main.c (mi_load_progress): Likewise.
10837
10838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10839
10840         * NEWS: Combine separate "New targets" sections for 8.3.
10841
10842 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10843
10844         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10845         (ppcfbsd_init_abi): Install gdbarch
10846         "fetch_tls_load_module_address" and "get_thread_local_address"
10847         methods.
10848
10849 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10850
10851         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10852         (riscv_fbsd_init_abi): Install gdbarch
10853         "fetch_tls_load_module_address" and "get_thread_local_address"
10854         methods.
10855
10856 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10857
10858         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10859         (i386fbsd_init_abi): Install gdbarch
10860         "fetch_tls_load_module_address" and "get_thread_local_address"
10861         methods.
10862
10863 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10864
10865         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10866         (amd64fbsd_init_abi): Install gdbarch
10867         "fetch_tls_load_module_address" and "get_thread_local_address"
10868         methods.
10869
10870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10871
10872         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10873         (struct fbsd_pspace_data): New type.
10874         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10875         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10876         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10877         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10878         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10879
10880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10881
10882         * gdbtypes.c (lookup_struct_elt): New function.
10883         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10884         * gdbtypes.h (struct struct_elt): New type.
10885         (lookup_struct_elt): New prototype.
10886
10887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10888
10889         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10890         remove disabled code block.
10891
10892 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10893
10894         * gdbarch.sh (get_thread_local_address): New method.
10895         * gdbarch.h, gdbarch.c: Regenerate.
10896         * target.c (target_translate_tls_address): Use
10897         gdbarch_get_thread_local_address if present instead of
10898         target::get_thread_local_address.
10899
10900 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10901
10902         * target.h (target::get_thread_local_address): Update comment.
10903
10904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10905
10906         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10907         objfile->separate_debug_objfile_backlink if not NULL.
10908
10909 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10910
10911         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10912         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10913         (amd64bsd_store_inferior_registers): Likewise.
10914         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10915         Enable segment base registers.
10916         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10917         PT_GETFSBASE and PT_GETGSBASE.
10918         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10919         PT_SETGSBASE.
10920         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10921         segment base registers.
10922         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10923
10924 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10925
10926         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10927         Update calls to i386_target_description to add 'segments'
10928         parameter.
10929         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10930         add segment base registers.
10931         * arch/i386.c (i386_create_target_description): Add 'segments'
10932         parameter to enable segment base registers.
10933         * arch/i386.h (i386_create_target_description): Likewise.
10934         * features/i386/32bit-segments.xml: New file.
10935         * features/i386/32bit-segments.c: Generate.
10936         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10937         call to i386_target_description to add 'segments' parameter.
10938         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10939         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10940         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10941         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10942         if feature is present.
10943         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10944         Add 'segments' parameter to call to i386_target_description.
10945         (i386_target_description): Add 'segments' parameter to enable
10946         segment base registers.
10947         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10948         to call to i386_target_description.
10949         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10950         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10951         Define I386_NUM_REGS.
10952         (i386_target_description): Add 'segments' parameter to enable
10953         segment base registers.
10954
10955 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10956
10957         PR/24325
10958         * source-cache.c: #undef open and close, to avoid unresolved
10959         externals during linking.
10960
10961 2019-03-12  Tom Tromey  <tromey@adacore.com>
10962
10963         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10964         const.  Add initializers.
10965         (_initialize_remote): Don't initialize ptid globals.
10966
10967 2019-03-12  Pedro Alves  <palves@redhat.com>
10968
10969         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10970
10971 2019-03-12  Pedro Alves  <palves@redhat.com>
10972
10973         * cp-name-parser.y (main): Remove unused 'len' variable.
10974
10975 2019-03-12  Tom Tromey  <tromey@adacore.com>
10976
10977         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10978         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10979
10980 2019-03-12  Tom Tromey  <tromey@adacore.com>
10981
10982         * linux-nat.c (iterate_over_lwps): Update.
10983         (stop_callback): Remove parameter.
10984         (stop_wait_callback, detach_callback, resume_set_callback)
10985         (select_singlestep_lwp_callback, set_ignore_sigint)
10986         (status_callback, resumed_callback, resume_clear_callback)
10987         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10988         data parameter.
10989         (linux_nat_target::detach, linux_nat_target::resume)
10990         (linux_stop_and_wait_all_lwps, select_event_lwp)
10991         (linux_nat_filter_event, linux_nat_wait_1)
10992         (linux_nat_target::kill, linux_nat_target::stop)
10993         (linux_nat_target::stop): Update.
10994         (linux_nat_resume_callback): Change type.
10995         (resume_stopped_resumed_lwps, count_events_callback)
10996         (select_event_lwp_callback): Likewise.
10997         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10998         * arm-linux-nat.c (struct update_registers_data): Remove.
10999         (update_registers_callback): Change type.
11000         (arm_linux_insert_hw_breakpoint1): Update.
11001         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11002         parameter.
11003         (x86_linux_dr_set_addr): Update.
11004         (x86_linux_dr_set_control): Update.
11005         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11006         (iterate_over_lwps): Use gdb::function_view.
11007         * nat/aarch64-linux-hw-point.c (struct
11008         aarch64_dr_update_callback_param): Remove.
11009         (debug_reg_change_callback): Change type.
11010         (aarch64_notify_debug_reg_change): Update.
11011         * s390-linux-nat.c (s390_refresh_per_info): Update.
11012
11013 2019-03-11  Tom Tromey  <tromey@adacore.com>
11014
11015         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11016         redundant assignment to "this_cu".
11017
11018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11019
11020         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11021
11022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11023
11024         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11025         from...
11026         (rank_one_type): ... this.
11027
11028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11029
11030         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11031         from...
11032         (rank_one_type): ... this.
11033
11034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11035
11036         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11037         from...
11038         (rank_one_type): ... this.
11039
11040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11041
11042         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11043         from...
11044         (rank_one_type): ... this.
11045
11046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11047
11048         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11049         from...
11050         (rank_one_type): ... this.
11051
11052 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11053
11054         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11055         from...
11056         (rank_one_type): ... this.
11057
11058 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11059
11060         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11061         from...
11062         (rank_one_type): ... this.
11063
11064 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11065
11066         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11067         from...
11068         (rank_one_type): ... this.
11069
11070 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11071
11072         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11073         from...
11074         (rank_one_type): ... this.
11075
11076 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11077
11078         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11079         from...
11080         (rank_one_type): ... this.
11081
11082 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11083
11084         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11085         from...
11086         (rank_one_type): ... this.
11087
11088 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11089
11090         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11091         from...
11092         (rank_one_type): ... this.
11093
11094 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11095
11096         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11097         inferior-events' shows the example events.
11098
11099 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11100
11101         Support styling on native MS-Windows console
11102
11103         PR/24315
11104         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11105         on MS-Windows if $TERM is not defined.
11106
11107         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11108
11109         * posix-hdep.c (gdb_console_fputs):
11110         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11111         functions.
11112         * ui-file.h (gdb_console_fputs): Add prototype.
11113
11114         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11115         back to fputs only if the former returns zero.
11116
11117 2019-03-07  Tom Tromey  <tom@tromey.com>
11118
11119         * symmisc.c (print_symbol_bcache_statistics): Update.
11120         (print_objfile_statistics): Update.
11121         * symfile.c (allocate_symtab): Update.
11122         * stabsread.c: Don't include bcache.h.
11123         * psymtab.h (struct psymbol_bcache): Don't declare.
11124         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11125         (psymbol_bcache_init, psymbol_bcache_free)
11126         (psymbol_bcache_get_bcache): Don't declare.
11127         * psymtab.c (struct psymbol_bcache): Remove.
11128         (psymtab_storage::psymtab_storage): Update.
11129         (psymtab_storage::~psymtab_storage): Update.
11130         (psymbol_bcache_init, psymbol_bcache_free)
11131         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11132         (add_psymbol_to_bcache): Update.
11133         (allocate_psymtab): Update.
11134         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11135         macro_cache>: No longer pointers.
11136         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11137         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11138         * macrotab.c (macro_bcache): Update.
11139         * macroexp.c: Don't include bcache.h.
11140         * gdbtypes.c (check_types_worklist): Update.
11141         (types_deeply_equal): Remove TRY/CATCH.  Update.
11142         * elfread.c (elf_symtab_read): Update.
11143         * dwarf2read.c: Don't include bcache.h.
11144         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11145         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11146         (print_bcache_statistics, bcache_memory_used): Don't declare.
11147         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11148         methods.  Rename all data members.
11149         * bcache.c (struct bcache): Move to bcache.h.
11150         (bcache::expand_hash_table): Rename from expand_hash_table.
11151         (bcache): Remove.
11152         (bcache::insert): Rename from bcache_full.
11153         (bcache::compare): Rename from bcache_compare.
11154         (bcache_xmalloc): Remove.
11155         (bcache::~bcache): Rename from bcache_xfree.
11156         (bcache::print_statistics): Rename from print_bcache_statistics.
11157         (bcache::memory_used): Rename from bcache_memory_used.
11158
11159 2019-03-07  Pedro Alves  <palves@redhat.com>
11160
11161         * infrun.c (normal_stop): Also check for
11162         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11163
11164 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11165
11166         * f-lang.c (value_from_host_double): Moved to...
11167         * value.c (value_from_host_double): ...here.
11168         * value.h (value_from_host_double): Declare.
11169         * guile/scm-math.c (vlscm_convert_typed_number): Use
11170         value_from_host_double.
11171         (vlscm_convert_number): Likewise.
11172         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11173         * python/py-value.c (convert_value_from_python): Likewise.
11174
11175 2019-03-06  Tom Tromey  <tom@tromey.com>
11176
11177         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11178
11179 2019-03-06  Tom Tromey  <tom@tromey.com>
11180
11181         * utils.h (free_current_contents): Don't declare.
11182         * utils.c (free_current_contents): Remove.
11183
11184 2019-03-06  Tom Tromey  <tom@tromey.com>
11185
11186         * top.c (quit_force): Update.
11187         * main.c (captured_command_loop): Update.
11188         * common/new-op.c (operator new): Update.
11189         * common/common-exceptions.c (struct catcher)
11190         <save_cleanup_chain>: Remove member.
11191         (exceptions_state_mc_init): Update.
11192         (exception_try_scope_entry): Return nullptr.
11193         (exception_try_scope_exit, exception_rethrow)
11194         (throw_exception_sjlj, throw_exception_cxx): Update.
11195         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11196         (all_cleanups, do_cleanups, discard_cleanups)
11197         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11198         (restore_cleanups, restore_final_cleanups): Don't declare.
11199         (do_final_cleanups): Remove parameter.
11200         * common/cleanups.c (cleanup_chain, make_cleanup)
11201         (make_cleanup_dtor, all_cleanups, do_cleanups)
11202         (discard_my_cleanups, discard_cleanups)
11203         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11204         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11205         (null_cleanup): Remove.
11206         (do_final_cleanups): Remove parameter.
11207
11208 2019-03-06  Tom Tromey  <tom@tromey.com>
11209
11210         * remote.c (remote_target::remote_parse_stop_reply): Use
11211         unique_xmalloc_ptr.
11212
11213 2019-03-06  Tom Tromey  <tom@tromey.com>
11214
11215         * stabsread.c (struct stabs_field_info): Rename from field_info.
11216         <list, fnlist>: Add initializers.
11217         <obstack>: New member.
11218         (read_member_functions, read_struct_fields, read_baseclasses):
11219         Allocate on obstack.  Don't use cleanups.
11220         (read_one_struct_field, read_member_functions, read_struct_fields)
11221         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11222         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11223         (read_struct_type): Update.
11224
11225 2019-03-06  Tom Tromey  <tom@tromey.com>
11226
11227         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11228         * common/filestuff.h (make_cleanup_close): Don't declare.
11229         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11230         Remove.
11231
11232 2019-03-06  Tom Tromey  <tom@tromey.com>
11233
11234         * solib-aix.c: Use make_scope_exit.
11235
11236 2019-03-06  Tom Tromey  <tom@tromey.com>
11237
11238         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11239         Use make_scope_exit.
11240
11241 2019-03-06  Tom Tromey  <tom@tromey.com>
11242
11243         * solib-svr4.c (disable_probes_interface): Remove parameter.
11244         (svr4_handle_solib_event): Use make_scope_exit.
11245
11246 2019-03-06  Tom Tromey  <tom@tromey.com>
11247
11248         * remote.c (struct stop_reply_deleter): Remove.
11249         (stop_reply_up): Update.
11250         (struct stop_reply): Derive from notif_event.  Don't typedef.
11251         <regcache>: Now a std::vector.
11252         (stop_reply_xfree): Remove.
11253         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11254         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11255         (remote_target::discard_pending_stop_replies): Use delete.
11256         (remote_target::remote_parse_stop_reply): Update.
11257         (remote_target::process_stop_reply): Update.
11258         * remote-notif.h (struct notif_event): Add virtual destructor.
11259         Remove "dtr" member.
11260         (struct notif_client) <alloc_event>: Return a unique_ptr.
11261         (notif_event_xfree): Don't declare.
11262         (notif_event_up): New typedef.
11263         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11264         (notif_event_xfree, do_notif_event_xfree): Remove.
11265         (remote_notif_state_xfree): Update.
11266
11267 2019-03-06  Tom Tromey  <tom@tromey.com>
11268
11269         * infrun.c (displaced_step_clear_cleanup): Now a
11270         forward_scope_exit type.
11271         (displaced_step_prepare_throw): Update.
11272         (displaced_step_fixup): Update.
11273
11274 2019-03-06  Tom Tromey  <tom@tromey.com>
11275
11276         * inferior.h (class inferior): Update comment.
11277         * gdbthread.h (class thread_info): Update comment.
11278
11279 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11280             Tom Tromey  <tom@tromey.com>
11281
11282         * stabsread.h (struct stab_section_list): Remove.
11283         (coffstab_build_psymtabs): Update.
11284         * dbxread.c (symbuf_sections): Now a std::vector.
11285         (sect_idx): New global.
11286         (fill_symbuf): Update.
11287         (coffstab_build_psymtabs): Change type of stabsects parameter.
11288         Update.
11289         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11290         std::vector.
11291         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11292         (coff_locate_sections): Update.
11293         (coff_symfile_read): Remove cleanups.  Update.
11294         (init_stringtab): Add storage parameter.
11295         (free_stringtab, free_stringtab_cleanup): Remove.
11296         (init_lineno): Add storage parameter.
11297         (free_linetab, free_linetab_cleanup): Remove.
11298
11299 2019-03-06  Pedro Alves  <palves@redhat.com>
11300
11301         * linux-fork.c (fork_info::clobber_regs): Delete.
11302         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11303         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11304         comment.  Adjust.
11305         (scoped_switch_fork_info::scoped_switch_fork_info)
11306         (checkpoint_command, linux_fork_context): Adjust
11307         fork_save_infrun_state calls.
11308
11309 2019-03-06  Pedro Alves  <palves@redhat.com>
11310
11311         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11312         (inf_has_multiple_threads): Return 'bool' and rewrite using
11313         inferior_info::threads().
11314
11315 2019-03-06  Pedro Alves  <palves@redhat.com>
11316
11317         * linux-fork.c: Include <list>.
11318         (fork_list): Now a std::list instance.
11319         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11320         (forks_exist_p, find_last_fork): Adjust.
11321         (new_fork): Delete.
11322         (one_fork_p): New.
11323         (add_fork): Adjust.
11324         (free_fork): Delete, folded into fork_info::~fork_info().
11325         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11326         Adjust.
11327         (init_fork_list): Delete.
11328         (linux_fork_killall, linux_fork_mourn_inferior)
11329         (linux_fork_detach, info_checkpoints_command): Adjust.
11330         (_initialize_linux_fork): No longer call init_fork_list.
11331
11332 2019-03-06  Pedro Alves  <palves@redhat.com>
11333
11334         * linux-fork.c (new_fork): New, split out of ...
11335         (add_fork): ... this.  Return void.  Move "first fork" special
11336         case from here, to ...
11337         (checkpoint_command): ... here.
11338         * linux-linux.h (add_fork): Return void.
11339
11340 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11341
11342         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11343
11344 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11345             Chris January  <chris.january@arm.com>
11346             David Lecomber  <david.lecomber@arm.com>
11347
11348         * f-exp.y: New token, UNOP_INTRINSIC.
11349         (exp): New pattern using UNOP_INTRINSIC token.
11350         (f77_keywords): Add 'abs' keyword.
11351         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11352         (value_from_host_double): New function.
11353         (evaluate_subexp_f): Support UNOP_ABS.
11354
11355 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11356
11357         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11358         types.
11359
11360 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11361
11362         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11363         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11364         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11365
11366 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11367
11368         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11369
11370 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11371             Chris January  <chris.january@arm.com>
11372
11373         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11374         * f-exp.y: Define 'KIND' token.
11375         (exp): New pattern for KIND expressions.
11376         (ptype): Handle types with a kind extension.
11377         (direct_abs_decl): Extend to spot kind extensions.
11378         (f77_keywords): Add 'kind' to the list.
11379         (push_kind_type): New function.
11380         (convert_to_kind_type): New function.
11381         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11382         * parse.c (operator_length_standard): Likewise.
11383         * parser-defs.h (enum type_pieces): Add tp_kind.
11384         * std-operator.def: Add UNOP_KIND.
11385
11386 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11387
11388         * f-exp.y (f_parse): Set yydebug.
11389
11390 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11391
11392         * f-lang.c (evaluate_subexp_f): New function.
11393         (exp_descriptor_f): New global.
11394         (f_language_defn): Use exp_descriptor_f instead of
11395         exp_descriptor_standard.
11396
11397 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11398
11399         * f-exp.y (struct token): Add comments.
11400         (dot_ops): Remove uppercase versions and the end marker.
11401         (f77_keywords): Likewise.
11402         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11403         entries in the dot_ops array are case insensitive, and use
11404         strncasecmp to compare strings.  Also some whitespace cleanup in
11405         this area.  Similar for the f77_keywords array, except entries in
11406         this list might be case sensitive.
11407
11408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11409
11410         * f-exp.y (struct f77_boolean_val): Add comments.
11411         (boolean_values): Remove uppercase versions, and end marker.
11412         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11413         and use strncasecmp to achieve case insensitivity.  Additionally,
11414         perform whitespace cleanup around this code.
11415
11416 2019-03-06  Tom Tromey  <tromey@adacore.com>
11417
11418         * remote-sim.c (gdbsim_target_open): Use result of
11419         gdb_argv::release.
11420
11421 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11422         Dirk Schubert  <dirk.schubert@arm.com>
11423         Chris January  <chris.january@arm.com>
11424
11425         * eval.c (evaluate_subexp_standard): Call Fortran argument
11426         wrapping logic.
11427         * f-lang.c (struct value): A value which can be passed into a
11428         Fortran function call.
11429         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11430         where appropriate.
11431         (struct type): Value ready for a Fortran function call.
11432         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11433         is needed.
11434         * f-lang.h (fortran_argument_convert): Declaration.
11435         (fortran_preserve_arg_pointer): Declaration.
11436         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11437
11438 2019-03-05  Tom Tromey  <tromey@adacore.com>
11439
11440         * python/py-prettyprint.c (print_string_repr): Remove #if.
11441         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11442
11443 2019-03-05  Tom Tromey  <tromey@adacore.com>
11444
11445         * target.c (the_dummy_target): Move later.  Change type to
11446         "dummy_target".
11447         (initialize_targets): Don't initialize the_dummy_target.
11448
11449 2019-03-05  Tom Tromey  <tromey@adacore.com>
11450
11451         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11452         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11453
11454 2019-03-05  Tom Tromey  <tromey@adacore.com>
11455
11456         * windows-nat.c (windows_nat_target::attach)
11457         (windows_nat_target::detach): Don't call gdb_flush.
11458         * valprint.c (generic_val_print, val_print, val_print_string):
11459         Don't call gdb_flush.
11460         * utils.c (defaulted_query): Don't call gdb_flush.
11461         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11462         * target.c (target_announce_detach): Don't call gdb_flush.
11463         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11464         * remote.c (extended_remote_target::attach): Don't call
11465         gdb_flush.
11466         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11467         * printcmd.c (do_examine): Don't call gdb_flush.
11468         (info_display_command): Don't call gdb_flush.
11469         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11470         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11471         * memattr.c (info_mem_command): Don't call gdb_flush.
11472         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11473         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11474         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11475         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11476         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11477         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11478         (gnu_nat_target::detach): Don't call gdb_flush.
11479         * f-valprint.c (f_val_print): Don't call gdb_flush.
11480         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11481         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11482         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11483         gdb_flush.
11484         * c-valprint.c (c_val_print): Don't call gdb_flush.
11485         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11486
11487 2019-03-05  Tom Tromey  <tromey@adacore.com>
11488
11489         * varobj.c (update_dynamic_varobj_children): Update.
11490         (install_default_visualizer): Use reset, not release.
11491         * value.c (set_internalvar): Update.
11492         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11493         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11494         ATTRIBUTE_UNUSED_RESULT.
11495
11496 2019-03-05  Tom Tromey  <tromey@adacore.com>
11497
11498         * remote.c (class scoped_remote_fd) <release>: Add
11499         ATTRIBUTE_UNUSED_RESULT.
11500
11501 2019-03-05  Tom Tromey  <tromey@adacore.com>
11502
11503         * macroexp.c (struct macro_buffer) <release>: Add
11504         ATTRIBUTE_UNUSED_RESULT.
11505
11506 2019-03-05  Tom Tromey  <tromey@adacore.com>
11507
11508         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11509         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11510         ATTRIBUTE_UNUSED_RESULT.
11511
11512 2019-03-05  Tom Tromey  <tromey@adacore.com>
11513
11514         * common/scoped_fd.h (class scoped_fd) <release>: Add
11515         ATTRIBUTE_UNUSED_RESULT.
11516
11517 2019-03-05  Tom Tromey  <tromey@adacore.com>
11518
11519         * parser-defs.h (struct parser_state) <release>: Add
11520         ATTRIBUTE_UNUSED_RESULT.
11521
11522 2019-03-05  Tom Tromey  <tromey@adacore.com>
11523
11524         * utils.h (class gdb_argv) <release>: Add
11525         ATTRIBUTE_UNUSED_RESULT.
11526         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11527
11528 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11529
11530         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11531         for-loop range, to avoid compiler warnings.
11532
11533         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11534         avoid compiler warnings about unused variables.
11535
11536         * NEWS: Mention end of support for native debugging on MS-Windows
11537         before XP.
11538
11539         PR gdb/24292
11540         * common/netstuff.c:
11541         * gdbserver/gdbreplay.c
11542         * gdbserver/remote-utils.c:
11543         * ser-tcp.c:
11544         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11545         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11546         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11547         'getaddrinfo' and 'freeaddrinfo' were not available before
11548         Windows XP, and mingw.org's MinGW headers by default define
11549         _WIN32_WINNT to 0x500.
11550
11551 2019-03-01  Gary Benson <gbenson@redhat.com>
11552
11553         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11554
11555 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11556             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11557
11558         PR gdb/8527
11559         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11560         set_sigint_trap, clear_sigint_trap.
11561
11562 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11563
11564         * target.c (target_detach): Clear the regcache and the
11565         frame cache.
11566
11567 2019-02-27  Pedro Alves  <palves@redhat.com>
11568
11569         * utils.c (set_screen_size): When we cap the height/width sizes,
11570         tweak the corresponding command variable to show "unlimited":
11571
11572 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11573             Pedro Alves  <palves@redhat.com>
11574
11575         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11576         before calling rl_set_screen_size.
11577
11578 2019-02-27  Tom Tromey  <tromey@adacore.com>
11579
11580         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11581         define.
11582         * python/py-value.c: Remove Python 2.4 workaround.
11583         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11584         workaround.
11585         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11586         Python 2.4 workaround.
11587         * python/python-internal.h: Remove Python 2.4 comment.
11588         (Py_ssize_t): Don't define.
11589         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11590         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11591         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11592         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11593         * python/python.c (do_start_initialization): Remove Python 2.4
11594         workaround.
11595         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11596         (print_children): Remove Python 2.4 workaround.
11597         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11598         workaround.
11599         (CHARBUFFERPROC_NAME): Remove.
11600         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11601         Python 2.4 workaround.
11602
11603 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11604
11605         * NEWS: Note minimum Python version.
11606
11607 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11608
11609         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11610         code from these functions.  Remove corresponding ifdefs.  Use
11611         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11612         Remove gotos and target of gotos.
11613         (infpy_search_memory): Likewise.
11614
11615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11616
11617         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11618         (hppa_gdbarch_init): Don't register deleted functions with
11619         gdbarch.
11620
11621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11622
11623         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11624         (h8300_unwind_sp): Delete.
11625         (h8300_dummy_id): Delete.
11626         (h8300_gdbarch_init): Don't register deleted functions with
11627         gdbarch.
11628
11629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11630
11631         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11632         (ft32_unwind_pc): Delete.
11633         (ft32_unwind_sp): Delete.
11634         (ft32_gdbarch_init): Don't register deleted functions with
11635         gdbarch.
11636
11637 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11638
11639         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11640         (frv_unwind_pc): Delete.
11641         (frv_unwind_sp): Delete.
11642         (frv_gdbarch_init): Don't register deleted functions with
11643         gdbarch.
11644
11645 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11646
11647         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11648         (riscv_unwind_pc): Delete.
11649         (riscv_unwind_sp): Delete.
11650         (riscv_gdbarch_init): Don't register deleted functions with
11651         gdbarch.
11652
11653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11654
11655         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11656         (csky_unwind_pc): Delete.
11657         (csky_unwind_sp): Delete.
11658         (csky_gdbarch_init): Don't register deleted functions with
11659         gdbarch.
11660
11661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11662
11663         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11664         (cris_unwind_pc): Delete.
11665         (cris_unwind_sp): Delete.
11666         (cris_gdbarch_init): Don't register deleted functions with
11667         gdbarch.
11668
11669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11670
11671         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11672         (bfin_unwind_pc): Delete.
11673         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11674
11675 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11676
11677         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11678         (arm_unwind_pc): Delete.
11679         (arm_unwind_sp): Delete.
11680         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11681
11682 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11683
11684         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11685         (arc_unwind_pc): Delete.
11686         (arc_unwind_sp): Delete.
11687         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11688
11689 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11690
11691         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11692         (alpha_unwind_pc): Delete.
11693         (alpha_gdbarch_init): Don't register deleted functions with
11694         gdbarch.
11695
11696 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11697
11698         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11699         (aarch64_unwind_pc): Delete.
11700         (aarch64_unwind_sp): Delete.
11701         (aarch64_gdbarch_init): Don't register deleted functions with
11702         gdbarch.
11703
11704 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11705
11706         * gdbtypes.c (type_align): Don't consider static members when
11707         computing structure alignment.
11708
11709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11710
11711         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11712         return 0 for other types.
11713         * arch-utils.c (default_type_align): Always return 0.
11714         * gdbarch.h: Regenerate.
11715         * gdbarch.sh (type_align): Extend comment.
11716         * gdbtypes.c (type_align): Add additional comments, always call
11717         gdbarch_type_align before applying the default rules.
11718         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11719         generic code will then apply a suitable default.
11720         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11721         types, return 0 for other types.
11722
11723 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11724
11725         * NEWS: Create a new section for the next release branch.
11726         Rename the section of the current branch, now that it has
11727         been cut.
11728
11729 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11730
11731         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11732         * version.in: Bump version to 8.3.50.DATE-git.
11733
11734 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11735
11736         * aix-thread.c (ptid_cmp): Remove unused variable.
11737         (get_signaled_thread): Likewise.
11738         (store_regs_user_thread): Likewise.
11739         (store_regs_kernel_thread): Likewise.
11740         (fetch_regs_kernel_thread): Remove shadowed variable.
11741
11742 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11743
11744         * features/riscv/32bit-cpu.xml: Add register numbers.
11745         * features/riscv/32bit-fpu.c: Regenerate.
11746         * features/riscv/32bit-fpu.xml: Add register numbers.
11747         * features/riscv/64bit-cpu.xml: Add register numbers.
11748         * features/riscv/64bit-fpu.c: Regenerate.
11749         * features/riscv/64bit-fpu.xml: Add register numbers.
11750
11751 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11752
11753         * NEWS: Mention two argument form of gdb.Value constructor.
11754         * python/py-value.c (convert_buffer_and_type_to_value): New
11755         function.
11756         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11757         Add support for handling an optional second argument.  Call
11758         convert_buffer_and_type_to_value as appropriate.
11759         * python/python-internal.h (Py_buffer_deleter): New struct.
11760         (Py_buffer_up): New typedef.
11761
11762 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11763
11764         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11765         instead of releasing ownership.
11766
11767 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11768
11769         * dwarf2read.c (open_and_init_dwp_file): Call
11770         elf_numsections instead of bfd_count_sections to initialize
11771         dwp_file->num_sections.
11772
11773 2019-02-25  Tom Tromey  <tromey@adacore.com>
11774
11775         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11776
11777 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11778
11779         * gcore.in: Add '--readnever' option when invoking GDB.
11780
11781 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11782
11783         * MAINTAINERS: Update my email address.
11784
11785 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11786
11787         * build-id.c (build_id_to_debug_bfd_1): New function.
11788         (build_id_to_debug_bfd): Look for separate debug file in
11789         sysroot.
11790
11791 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11792
11793         * gdbarch.sh: Update the copyright year range that is placed into
11794         generated files.
11795
11796 2019-02-22  Keith Seitz  <keiths@redhat.com>
11797
11798         PR symtab/23853
11799         * linespec.c (create_sals_line_offset): Search for the default
11800         symtab's filename instead of its fullname.
11801
11802 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11803
11804         * NEWS: Update style defaults.
11805
11806 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11807
11808         * main.c (captured_main_1): Disable styling in batch mode.
11809
11810 2019-02-20  Tom Tromey  <tom@tromey.com>
11811
11812         * symtab.c (symtab_symbol_info): Fix typos.
11813
11814 2019-02-20  Tom Tromey  <tromey@adacore.com>
11815
11816         * findcmd.c (_initialize_mem_search): Use upper case for
11817         metasyntactic variables.
11818
11819 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11820
11821         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11822         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11823
11824 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11825
11826         * top.h (source_file_name): Change to std::string.
11827         * top.c (source_file_name): Likewise.
11828         (command_line_input): Adjust.
11829         * cli/cli-script.c (script_from_file): Adjust.
11830
11831 2019-02-19  Tom Tromey  <tromey@adacore.com>
11832
11833         * ravenscar-thread.c
11834         (ravenscar_thread_target::update_thread_list): Don't call
11835         ada_build_task_list.
11836         * ada-lang.h (ada_build_task_list): Don't declare.
11837         * ada-tasks.c (struct ada_tasks_inferior_data)
11838         <task_list_valid_p>: Now bool.
11839         (read_known_tasks, ada_task_list_changed)
11840         (ada_tasks_invalidate_inferior_data): Update.
11841         (read_known_tasks_array): Return bool.
11842         (read_known_tasks_list): Likewise.
11843         (read_known_tasks): Return void.
11844         (ada_build_task_list): Now static.
11845
11846 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11847
11848         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11849         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11850
11851 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11852
11853         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11854         variant for ada_tasks_pspace_data_handle and
11855         ada_tasks_inferior_data_handle.
11856         (ada_tasks_pspace_data_cleanup): New function.
11857         (ada_tasks_inferior_data_cleanup): New function.
11858
11859 2019-02-17  Tom Tromey  <tom@tromey.com>
11860
11861         * macrotab.h (macro_source_fullname): Return a std::string.
11862         * macrotab.c (macro_include, check_for_redefinition)
11863         (macro_undef, macro_lookup_definition, foreach_macro)
11864         (foreach_macro_in_scope): Update.
11865         (macro_source_fullname): Return a std::string.
11866         * macrocmd.c (show_pp_source_pos): Update.
11867
11868 2019-02-17  Tom Tromey  <tom@tromey.com>
11869
11870         * macrocmd.c (show_pp_source_pos): Style the file names.
11871
11872 2019-02-17  Tom Tromey  <tom@tromey.com>
11873
11874         PR tui/24197:
11875         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11876
11877 2019-02-17  Tom Tromey  <tom@tromey.com>
11878
11879         * ada-lang.c (user_select_syms): Use filtered printing.
11880         * utils.c (wrap_style): New global.
11881         (desired_style): Remove.
11882         (emit_style_escape): Add stream parameter.
11883         (set_output_style, reset_terminal_style, prompt_for_continue):
11884         Update.
11885         (flush_wrap_buffer): Only flush gdb_stdout.
11886         (wrap_here): Set wrap_style.
11887         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11888         treat escape sequences as a character.  Change when wrap buffer is
11889         flushed.
11890         (fputs_styled): Do not set the output style when the default is
11891         requested.
11892         * ui-style.h (struct ui_file_style) <is_default>: New method.
11893         * source.c (print_source_lines_base): Emit escape sequences in one
11894         piece.
11895
11896 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11897
11898         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11899         integers and enumeration types.
11900
11901 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11902
11903         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11904         instead of lookup_symbol_in_language
11905         (do_exact_match): New function.
11906         (ada_get_symbol_name_matcher): Return do_exact_match when
11907         doing a verbatim match.
11908
11909 2019-02-15  Tom Tromey  <tromey@adacore.com>
11910
11911         * ravenscar-thread.c (ravenscar_thread_target::resume)
11912         (ravenscar_thread_target::wait): Special case wildcard requests.
11913
11914 2019-02-15  Tom Tromey  <tromey@adacore.com>
11915
11916         * ravenscar-thread.c (base_ptid): Remove.
11917         (struct ravenscar_thread_target) <close>: New method.
11918         <m_base_ptid>: New member.
11919         <update_inferior_ptid, active_task, task_is_currently_active,
11920         runtime_initialized>: Declare methods.
11921         <ravenscar_thread_target>: Add constructor.
11922         (ravenscar_thread_target::task_is_currently_active)
11923         (ravenscar_thread_target::update_inferior_ptid)
11924         (ravenscar_runtime_initialized): Rename.  Now methods.
11925         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11926         (ravenscar_thread_target::update_thread_list): Update.
11927         (ravenscar_thread_target::active_task): Now method.
11928         (ravenscar_thread_target::store_registers)
11929         (ravenscar_thread_target::prepare_to_store)
11930         (ravenscar_thread_target::prepare_to_store)
11931         (ravenscar_thread_target::mourn_inferior): Update.
11932         (ravenscar_inferior_created): Use "new" to create target.
11933         (ravenscar_thread_target::get_ada_task_ptid): Update.
11934         (_initialize_ravenscar): Don't initialize base_ptid.
11935         (ravenscar_ops): Remove global.
11936
11937 2019-02-15  Tom Tromey  <tromey@adacore.com>
11938
11939         * target.h (push_target): Declare new overload.
11940         * target.c (push_target): New overload, taking an rvalue reference.
11941         * remote.c (remote_target::open_1): Use push_target overload.
11942         * corelow.c (core_target_open): Use push_target overload.
11943
11944 2019-02-15  Tom Tromey  <tromey@adacore.com>
11945
11946         * ravenscar-thread.c (is_ravenscar_task)
11947         (ravenscar_task_is_currently_active): Return bool.
11948         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11949         (_initialize_ravenscar): Remove "(void)".
11950         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11951         Return bool.
11952
11953 2019-02-15  Tom Tromey  <tromey@adacore.com>
11954
11955         * ravenscar-thread.c (ravenscar_runtime_initializer)
11956         (has_ravenscar_runtime, get_running_thread_id)
11957         (ravenscar_thread_target::resume): Fix indentation.
11958
11959 2019-02-15  Tom Tromey  <tromey@adacore.com>
11960
11961         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11962         from ravenscar_arch_ops.
11963         (sparc_ravenscar_ops::fetch_registers)
11964         (sparc_ravenscar_ops::store_registers): Now methods.
11965         (sparc_ravenscar_prepare_to_store): Remove.
11966         (sparc_ravenscar_ops): Redefine.
11967         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11968         methods and destructor.  Remove members.
11969         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11970         (ravenscar_thread_target::store_registers)
11971         (ravenscar_thread_target::prepare_to_store): Update.
11972         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11973         Remove.
11974         (struct ppc_ravenscar_powerpc_ops): Derive from
11975         ravenscar_arch_ops.
11976         (ppc_ravenscar_powerpc_ops::fetch_registers)
11977         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11978         (ppc_ravenscar_powerpc_ops): Redefine.
11979         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11980         (ppc_ravenscar_e500_ops::fetch_registers)
11981         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11982         (ppc_ravenscar_e500_ops): Redefine.
11983         * aarch64-ravenscar-thread.c
11984         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11985         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11986         (aarch64_ravenscar_fetch_registers)
11987         (aarch64_ravenscar_store_registers): Now methods.
11988         (aarch64_ravenscar_ops): Redefine.
11989
11990 2019-02-15  Tom Tromey  <tromey@adacore.com>
11991
11992         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11993         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11994         (ravenscar_thread_target::stopped_by_watchpoint)
11995         (ravenscar_thread_target::stopped_data_address)
11996         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11997
11998 2019-02-15  Tom Tromey  <tromey@adacore.com>
11999
12000         * ravenscar-thread.c: Fix some typos.
12001
12002 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12003             Tom Tromey  <tromey@adacore.com>
12004
12005         * ada-lang.c (ada_exception_sal): Change addr_string to a
12006         std::string.
12007         (create_ada_exception_catchpoint): Update.
12008
12009 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12010             Tom Tromey  <tromey@adacore.com>
12011
12012         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12013         (bp_location_ops): Remove.
12014         (base_breakpoint_allocate_location): Update.
12015         (free_bp_location): Update.
12016         * ada-lang.c (class ada_catchpoint_location)
12017         <ada_catchpoint_location>: Remove ops parameter.
12018         (ada_catchpoint_location_dtor): Remove.
12019         (ada_catchpoint_location_ops): Remove.
12020         (allocate_location_exception): Update.
12021         * breakpoint.h (struct bp_location_ops): Remove.
12022         (class bp_location) <bp_location>: Remove bp_location_ops
12023         parameter.
12024         <~bp_location>: Add destructor.
12025         <ops>: Remove.
12026
12027 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12028             Pedro Alves  <palves@redhat.com>
12029
12030         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12031         'PATH_MAX'.
12032
12033 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12034             Samuel Thibault  <samuel.thibault@gnu.org>
12035             Thomas Schwinge  <thomas@codesourcery.com>
12036
12037         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12038         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12039
12040 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12041
12042         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12043         (check_empty): Use "const char *".
12044
12045         * gnu-nat.c (gnu_nat_target::detach): Instead of
12046         'detach_inferior (pid)' call
12047         'detach_inferior (find_inferior_pid (pid))'.
12048
12049         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12050         'nat/fork-inferior.o'.
12051         * gnu-nat.c: #include "nat/fork-inferior.h".
12052
12053         * gnu-nat.c (gnu_nat_target::detach): Instead of
12054         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12055         * gnu-nat.h: #include "inf-child.h".
12056         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12057         'i386_gnu_nat_target::fetch_registers'.
12058         (gnu_store_registers): Rename/move to
12059         'i386_gnu_nat_target::store_registers'.
12060
12061         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12062         * gnu-nat.h (mach_thread_info): New function.
12063         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12064
12065         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12066
12067 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12068
12069         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12070
12071 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12072
12073         * windows-nat.c (windows_add_thread): Add new parameter
12074         "main_thread_p" with default value set to false.  Update
12075         function documentation as well as all callers.
12076         (windows_delete_thread): Likewise.
12077         (fake_create_process): Update call to windows_add_thread.
12078         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12079         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12080         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12081         call to windows_delete_thread.
12082
12083 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12084
12085         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12086
12087 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12088
12089         * symfile.c (find_separate_debug_file): Use canonical path of
12090         sysroot with child_path instead of gdb_sysroot if it is valid.
12091
12092 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12093
12094         * symfile.c (find_separate_debug_file): Use child_path to
12095         determine if an object file is under a sysroot.
12096
12097 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12098
12099         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12100         unittests/child-path-selftests.c.
12101         * common/pathstuff.c (child_path): New function.
12102         * common/pathstuff.h (child_path): New prototype.
12103         * unittests/child-path-selftests.c: New file.
12104
12105 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12106
12107         * symfile.c (find_separate_debug_file): Look for separate debug
12108         files in debug directories under the sysroot.
12109
12110 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12111
12112         * symtab.h (struct minimal_symbol data_p): New const method.
12113         (struct minimal_symbol text_p): Likewise.
12114         * symtab.c (output_source_filename): Use file name style
12115         to print file name.
12116         (print_symbol_info): Likewise.
12117         (print_msymbol_info): Use address style to print addresses.
12118         Use function name style to print executable text symbols.
12119         (expand_symtab_containing_pc): Use data_p.
12120         (find_pc_sect_compunit_symtab): Likewise.
12121
12122 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12123
12124         * breakpoint.c (describe_other_breakpoints): Use address style
12125         to print addresses.
12126         (say_where): Likewise.
12127
12128 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12129
12130         * ada-typeprint.c (print_func_type): Print function name
12131         style to print function name.
12132         * c-typeprint.c (c_print_type_1): Likewise.
12133
12134 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12135
12136         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12137         for execve.
12138
12139 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12140
12141         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12142         type_stack.
12143
12144 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12145
12146         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12147         TYPE_CODE_REF types.
12148
12149 2019-02-08  Jim Wilson  <jimw@sifive.com>
12150
12151         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12152         (riscv_linux_fregset): New.
12153         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12154
12155 2019-02-07  Tom Tromey  <tom@tromey.com>
12156
12157         * thread.c (thread_cancel_execution_command): Update.
12158         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12159         methods.
12160         (struct thread_fsm_ops): Remove.
12161         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12162         (thread_fsm_should_stop, thread_fsm_return_value)
12163         (thread_fsm_set_finished, thread_fsm_finished_p)
12164         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12165         Don't declare.
12166         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12167         * infrun.c (clear_proceed_status_thread)
12168         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12169         (print_stop_event): Update.
12170         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12171         Add constructor.
12172         (step_command_fsm_ops): Remove.
12173         (new_step_command_fsm): Remove.
12174         (step_1): Update.
12175         (step_command_fsm::should_stop): Rename from
12176         step_command_fsm_should_stop.
12177         (step_command_fsm::clean_up): Rename from
12178         step_command_fsm_clean_up.
12179         (step_command_fsm::do_async_reply_reason): Rename from
12180         step_command_fsm_async_reply_reason.
12181         (struct until_next_fsm): Inherit from thread_fsm.  Add
12182         constructor.
12183         (until_next_fsm_ops): Remove.
12184         (new_until_next_fsm): Remove.
12185         (until_next_fsm::should_stop): Rename from
12186         until_next_fsm_should_stop.
12187         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12188         (until_next_fsm::do_async_reply_reason): Rename from
12189         until_next_fsm_async_reply_reason.
12190         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12191         constructor.  Change type of breakpoint.
12192         (finish_command_fsm_ops): Remove.
12193         (new_finish_command_fsm): Remove.
12194         (finish_command_fsm::should_stop): Rename from
12195         finish_command_fsm_should_stop.
12196         (finish_command_fsm::clean_up): Rename from
12197         finish_command_fsm_clean_up.
12198         (finish_command_fsm::return_value): Rename from
12199         finish_command_fsm_return_value.
12200         (finish_command_fsm::do_async_reply_reason): Rename from
12201         finish_command_fsm_async_reply_reason.
12202         (finish_command): Update.
12203         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12204         Add constructor.
12205         (call_thread_fsm_ops): Remove.
12206         (call_thread_fsm::call_thread_fsm): Rename from
12207         new_call_thread_fsm.
12208         (call_thread_fsm::should_stop): Rename from
12209         call_thread_fsm_should_stop.
12210         (call_thread_fsm::should_notify_stop): Rename from
12211         call_thread_fsm_should_notify_stop.
12212         (run_inferior_call, call_function_by_hand_dummy): Update.
12213         * cli/cli-interp.c (should_print_stop_to_console): Update.
12214         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12215         Add constructor.  Change type of location_breakpoint,
12216         caller_breakpoint.
12217         (until_break_fsm_ops): Remove.
12218         (new_until_break_fsm): Remove.
12219         (until_break_fsm::should_stop): Rename from
12220         until_break_fsm_should_stop.
12221         (until_break_fsm::clean_up): Rename from
12222         until_break_fsm_clean_up.
12223         (until_break_fsm::do_async_reply_reason): Rename from
12224         until_break_fsm_async_reply_reason.
12225         (until_break_command): Update.
12226         * thread-fsm.c: Remove.
12227         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12228
12229 2019-02-07  Tom Tromey  <tom@tromey.com>
12230
12231         * yy-remap.h: Add include guard.
12232         * xtensa-tdep.h: Add include guard.
12233         * xcoffread.h: Rename include guard.
12234         * varobj-iter.h: Add include guard.
12235         * tui/tui.h: Rename include guard.
12236         * tui/tui-winsource.h: Rename include guard.
12237         * tui/tui-wingeneral.h: Rename include guard.
12238         * tui/tui-windata.h: Rename include guard.
12239         * tui/tui-win.h: Rename include guard.
12240         * tui/tui-stack.h: Rename include guard.
12241         * tui/tui-source.h: Rename include guard.
12242         * tui/tui-regs.h: Rename include guard.
12243         * tui/tui-out.h: Rename include guard.
12244         * tui/tui-layout.h: Rename include guard.
12245         * tui/tui-io.h: Rename include guard.
12246         * tui/tui-hooks.h: Rename include guard.
12247         * tui/tui-file.h: Rename include guard.
12248         * tui/tui-disasm.h: Rename include guard.
12249         * tui/tui-data.h: Rename include guard.
12250         * tui/tui-command.h: Rename include guard.
12251         * tic6x-tdep.h: Add include guard.
12252         * target/waitstatus.h: Rename include guard.
12253         * target/wait.h: Rename include guard.
12254         * target/target.h: Rename include guard.
12255         * target/resume.h: Rename include guard.
12256         * target-float.h: Rename include guard.
12257         * stabsread.h: Add include guard.
12258         * rs6000-tdep.h: Add include guard.
12259         * riscv-fbsd-tdep.h: Add include guard.
12260         * regformats/regdef.h: Rename include guard.
12261         * record.h: Rename include guard.
12262         * python/python.h: Rename include guard.
12263         * python/python-internal.h: Rename include guard.
12264         * python/py-stopevent.h: Rename include guard.
12265         * python/py-ref.h: Rename include guard.
12266         * python/py-record.h: Rename include guard.
12267         * python/py-record-full.h: Rename include guard.
12268         * python/py-record-btrace.h: Rename include guard.
12269         * python/py-instruction.h: Rename include guard.
12270         * python/py-events.h: Rename include guard.
12271         * python/py-event.h: Rename include guard.
12272         * procfs.h: Add include guard.
12273         * proc-utils.h: Add include guard.
12274         * p-lang.h: Add include guard.
12275         * or1k-tdep.h: Rename include guard.
12276         * observable.h: Rename include guard.
12277         * nto-tdep.h: Rename include guard.
12278         * nat/x86-linux.h: Rename include guard.
12279         * nat/x86-linux-dregs.h: Rename include guard.
12280         * nat/x86-gcc-cpuid.h: Add include guard.
12281         * nat/x86-dregs.h: Rename include guard.
12282         * nat/x86-cpuid.h: Rename include guard.
12283         * nat/ppc-linux.h: Rename include guard.
12284         * nat/mips-linux-watch.h: Rename include guard.
12285         * nat/linux-waitpid.h: Rename include guard.
12286         * nat/linux-ptrace.h: Rename include guard.
12287         * nat/linux-procfs.h: Rename include guard.
12288         * nat/linux-osdata.h: Rename include guard.
12289         * nat/linux-nat.h: Rename include guard.
12290         * nat/linux-namespaces.h: Rename include guard.
12291         * nat/linux-btrace.h: Rename include guard.
12292         * nat/glibc_thread_db.h: Rename include guard.
12293         * nat/gdb_thread_db.h: Rename include guard.
12294         * nat/gdb_ptrace.h: Rename include guard.
12295         * nat/fork-inferior.h: Rename include guard.
12296         * nat/amd64-linux-siginfo.h: Rename include guard.
12297         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12298         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12299         * nat/aarch64-linux.h: Rename include guard.
12300         * nat/aarch64-linux-hw-point.h: Rename include guard.
12301         * mn10300-tdep.h: Add include guard.
12302         * mips-linux-tdep.h: Add include guard.
12303         * mi/mi-parse.h: Rename include guard.
12304         * mi/mi-out.h: Rename include guard.
12305         * mi/mi-main.h: Rename include guard.
12306         * mi/mi-interp.h: Rename include guard.
12307         * mi/mi-getopt.h: Rename include guard.
12308         * mi/mi-console.h: Rename include guard.
12309         * mi/mi-common.h: Rename include guard.
12310         * mi/mi-cmds.h: Rename include guard.
12311         * mi/mi-cmd-break.h: Rename include guard.
12312         * m2-lang.h: Add include guard.
12313         * location.h: Rename include guard.
12314         * linux-record.h: Rename include guard.
12315         * linux-nat.h: Add include guard.
12316         * linux-fork.h: Add include guard.
12317         * i386-darwin-tdep.h: Rename include guard.
12318         * hppa-linux-offsets.h: Add include guard.
12319         * guile/guile.h: Rename include guard.
12320         * guile/guile-internal.h: Rename include guard.
12321         * gnu-nat.h: Rename include guard.
12322         * gdb-stabs.h: Rename include guard.
12323         * frv-tdep.h: Add include guard.
12324         * f-lang.h: Add include guard.
12325         * event-loop.h: Add include guard.
12326         * darwin-nat.h: Rename include guard.
12327         * cp-abi.h: Rename include guard.
12328         * config/sparc/nm-sol2.h: Rename include guard.
12329         * config/nm-nto.h: Rename include guard.
12330         * config/nm-linux.h: Add include guard.
12331         * config/i386/nm-i386gnu.h: Rename include guard.
12332         * config/djgpp/nl_types.h: Rename include guard.
12333         * config/djgpp/langinfo.h: Rename include guard.
12334         * compile/gcc-cp-plugin.h: Add include guard.
12335         * compile/gcc-c-plugin.h: Add include guard.
12336         * compile/compile.h: Rename include guard.
12337         * compile/compile-object-run.h: Rename include guard.
12338         * compile/compile-object-load.h: Rename include guard.
12339         * compile/compile-internal.h: Rename include guard.
12340         * compile/compile-cplus.h: Rename include guard.
12341         * compile/compile-c.h: Rename include guard.
12342         * common/xml-utils.h: Rename include guard.
12343         * common/x86-xstate.h: Rename include guard.
12344         * common/version.h: Rename include guard.
12345         * common/vec.h: Rename include guard.
12346         * common/tdesc.h: Rename include guard.
12347         * common/selftest.h: Rename include guard.
12348         * common/scoped_restore.h: Rename include guard.
12349         * common/scoped_mmap.h: Rename include guard.
12350         * common/scoped_fd.h: Rename include guard.
12351         * common/safe-iterator.h: Rename include guard.
12352         * common/run-time-clock.h: Rename include guard.
12353         * common/refcounted-object.h: Rename include guard.
12354         * common/queue.h: Rename include guard.
12355         * common/ptid.h: Rename include guard.
12356         * common/print-utils.h: Rename include guard.
12357         * common/preprocessor.h: Rename include guard.
12358         * common/pathstuff.h: Rename include guard.
12359         * common/observable.h: Rename include guard.
12360         * common/netstuff.h: Rename include guard.
12361         * common/job-control.h: Rename include guard.
12362         * common/host-defs.h: Rename include guard.
12363         * common/gdb_wait.h: Rename include guard.
12364         * common/gdb_vecs.h: Rename include guard.
12365         * common/gdb_unlinker.h: Rename include guard.
12366         * common/gdb_unique_ptr.h: Rename include guard.
12367         * common/gdb_tilde_expand.h: Rename include guard.
12368         * common/gdb_sys_time.h: Rename include guard.
12369         * common/gdb_string_view.h: Rename include guard.
12370         * common/gdb_splay_tree.h: Rename include guard.
12371         * common/gdb_setjmp.h: Rename include guard.
12372         * common/gdb_ref_ptr.h: Rename include guard.
12373         * common/gdb_optional.h: Rename include guard.
12374         * common/gdb_locale.h: Rename include guard.
12375         * common/gdb_assert.h: Rename include guard.
12376         * common/filtered-iterator.h: Rename include guard.
12377         * common/filestuff.h: Rename include guard.
12378         * common/fileio.h: Rename include guard.
12379         * common/environ.h: Rename include guard.
12380         * common/common-utils.h: Rename include guard.
12381         * common/common-types.h: Rename include guard.
12382         * common/common-regcache.h: Rename include guard.
12383         * common/common-inferior.h: Rename include guard.
12384         * common/common-gdbthread.h: Rename include guard.
12385         * common/common-exceptions.h: Rename include guard.
12386         * common/common-defs.h: Rename include guard.
12387         * common/common-debug.h: Rename include guard.
12388         * common/cleanups.h: Rename include guard.
12389         * common/buffer.h: Rename include guard.
12390         * common/btrace-common.h: Rename include guard.
12391         * common/break-common.h: Rename include guard.
12392         * cli/cli-utils.h: Rename include guard.
12393         * cli/cli-style.h: Rename include guard.
12394         * cli/cli-setshow.h: Rename include guard.
12395         * cli/cli-script.h: Rename include guard.
12396         * cli/cli-interp.h: Rename include guard.
12397         * cli/cli-decode.h: Rename include guard.
12398         * cli/cli-cmds.h: Rename include guard.
12399         * charset-list.h: Add include guard.
12400         * buildsym-legacy.h: Rename include guard.
12401         * bfin-tdep.h: Add include guard.
12402         * ax.h: Rename include guard.
12403         * arm-linux-tdep.h: Add include guard.
12404         * arm-fbsd-tdep.h: Add include guard.
12405         * arch/xtensa.h: Rename include guard.
12406         * arch/tic6x.h: Add include guard.
12407         * arch/i386.h: Add include guard.
12408         * arch/arm.h: Rename include guard.
12409         * arch/arm-linux.h: Rename include guard.
12410         * arch/arm-get-next-pcs.h: Rename include guard.
12411         * arch/amd64.h: Add include guard.
12412         * arch/aarch64-insn.h: Rename include guard.
12413         * arch-utils.h: Rename include guard.
12414         * annotate.h: Add include guard.
12415         * amd64-darwin-tdep.h: Rename include guard.
12416         * aarch64-linux-tdep.h: Add include guard.
12417         * aarch64-fbsd-tdep.h: Add include guard.
12418         * aarch32-linux-nat.h: Add include guard.
12419
12420 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12421
12422         * macrotab.c (macro_define_internal): New function that
12423         factorizes macro_define_object_internal and macro_define_function
12424         code.
12425         (macro_define_object_internal): Use macro_define_internal.
12426         (macro_define_function): Likewise.
12427
12428 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12429
12430         * macrocmd.c (extract_identifier): Return
12431         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12432         callers.
12433
12434 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12435
12436         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12437
12438 2019-02-05  Tom Tromey  <tom@tromey.com>
12439
12440         * target.c (target_stack::unpush): Move assertion earlier.
12441
12442 2019-01-30  Tom Tromey  <tom@tromey.com>
12443
12444         PR python/23615:
12445         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12446         (gdbpy_parse_and_eval): Likewise.
12447         * python/python-internal.h (gdbpy_allow_threads): New class.
12448
12449 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12450
12451         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12452         (aarch64_fbsd_fpregmap): Move earlier.
12453         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12454         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12455         instead of individual calls to trad_frame_set_reg_addr.
12456         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12457         earlier.
12458         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12459         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12460         instead of individual calls to trad_frame_set_reg_addr.
12461
12462 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12463
12464         * CONTRIBUTE: Replace contribution list with wiki link.
12465
12466 2019-01-25  Tom Tromey  <tom@tromey.com>
12467
12468         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12469
12470 2019-01-25  Tom Tromey  <tom@tromey.com>
12471
12472         * xtensa-linux-nat.c: Fix common/ includes.
12473         * xml-support.h: Fix common/ includes.
12474         * xml-support.c: Fix common/ includes.
12475         * x86-linux-nat.c: Fix common/ includes.
12476         * windows-nat.c: Fix common/ includes.
12477         * varobj.h: Fix common/ includes.
12478         * varobj.c: Fix common/ includes.
12479         * value.c: Fix common/ includes.
12480         * valops.c: Fix common/ includes.
12481         * utils.c: Fix common/ includes.
12482         * unittests/xml-utils-selftests.c: Fix common/ includes.
12483         * unittests/utils-selftests.c: Fix common/ includes.
12484         * unittests/unpack-selftests.c: Fix common/ includes.
12485         * unittests/tracepoint-selftests.c: Fix common/ includes.
12486         * unittests/style-selftests.c: Fix common/ includes.
12487         * unittests/string_view-selftests.c: Fix common/ includes.
12488         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12489         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12490         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12491         * unittests/rsp-low-selftests.c: Fix common/ includes.
12492         * unittests/parse-connection-spec-selftests.c: Fix common/
12493         includes.
12494         * unittests/optional-selftests.c: Fix common/ includes.
12495         * unittests/offset-type-selftests.c: Fix common/ includes.
12496         * unittests/observable-selftests.c: Fix common/ includes.
12497         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12498         * unittests/memrange-selftests.c: Fix common/ includes.
12499         * unittests/memory-map-selftests.c: Fix common/ includes.
12500         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12501         * unittests/function-view-selftests.c: Fix common/ includes.
12502         * unittests/environ-selftests.c: Fix common/ includes.
12503         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12504         * unittests/common-utils-selftests.c: Fix common/ includes.
12505         * unittests/cli-utils-selftests.c: Fix common/ includes.
12506         * unittests/array-view-selftests.c: Fix common/ includes.
12507         * ui-file.c: Fix common/ includes.
12508         * tui/tui-io.c: Fix common/ includes.
12509         * tracepoint.h: Fix common/ includes.
12510         * tracepoint.c: Fix common/ includes.
12511         * tracefile-tfile.c: Fix common/ includes.
12512         * top.h: Fix common/ includes.
12513         * top.c: Fix common/ includes.
12514         * thread.c: Fix common/ includes.
12515         * target/waitstatus.h: Fix common/ includes.
12516         * target/waitstatus.c: Fix common/ includes.
12517         * target.h: Fix common/ includes.
12518         * target.c: Fix common/ includes.
12519         * target-memory.c: Fix common/ includes.
12520         * target-descriptions.c: Fix common/ includes.
12521         * symtab.h: Fix common/ includes.
12522         * symfile.c: Fix common/ includes.
12523         * stap-probe.c: Fix common/ includes.
12524         * spu-linux-nat.c: Fix common/ includes.
12525         * sparc-nat.c: Fix common/ includes.
12526         * source.c: Fix common/ includes.
12527         * solib.c: Fix common/ includes.
12528         * solib-target.c: Fix common/ includes.
12529         * ser-unix.c: Fix common/ includes.
12530         * ser-tcp.c: Fix common/ includes.
12531         * ser-pipe.c: Fix common/ includes.
12532         * ser-base.c: Fix common/ includes.
12533         * selftest-arch.c: Fix common/ includes.
12534         * s12z-tdep.c: Fix common/ includes.
12535         * rust-exp.y: Fix common/ includes.
12536         * rs6000-aix-tdep.c: Fix common/ includes.
12537         * riscv-tdep.c: Fix common/ includes.
12538         * remote.c: Fix common/ includes.
12539         * remote-notif.h: Fix common/ includes.
12540         * remote-fileio.h: Fix common/ includes.
12541         * remote-fileio.c: Fix common/ includes.
12542         * regcache.h: Fix common/ includes.
12543         * regcache.c: Fix common/ includes.
12544         * record-btrace.c: Fix common/ includes.
12545         * python/python.c: Fix common/ includes.
12546         * python/py-type.c: Fix common/ includes.
12547         * python/py-inferior.c: Fix common/ includes.
12548         * progspace.h: Fix common/ includes.
12549         * producer.c: Fix common/ includes.
12550         * procfs.c: Fix common/ includes.
12551         * proc-api.c: Fix common/ includes.
12552         * printcmd.c: Fix common/ includes.
12553         * ppc-linux-nat.c: Fix common/ includes.
12554         * parser-defs.h: Fix common/ includes.
12555         * osdata.c: Fix common/ includes.
12556         * obsd-nat.c: Fix common/ includes.
12557         * nat/x86-linux.c: Fix common/ includes.
12558         * nat/x86-linux-dregs.c: Fix common/ includes.
12559         * nat/x86-dregs.h: Fix common/ includes.
12560         * nat/x86-dregs.c: Fix common/ includes.
12561         * nat/ppc-linux.c: Fix common/ includes.
12562         * nat/mips-linux-watch.h: Fix common/ includes.
12563         * nat/mips-linux-watch.c: Fix common/ includes.
12564         * nat/linux-waitpid.c: Fix common/ includes.
12565         * nat/linux-ptrace.h: Fix common/ includes.
12566         * nat/linux-ptrace.c: Fix common/ includes.
12567         * nat/linux-procfs.c: Fix common/ includes.
12568         * nat/linux-personality.c: Fix common/ includes.
12569         * nat/linux-osdata.c: Fix common/ includes.
12570         * nat/linux-namespaces.c: Fix common/ includes.
12571         * nat/linux-btrace.h: Fix common/ includes.
12572         * nat/linux-btrace.c: Fix common/ includes.
12573         * nat/fork-inferior.c: Fix common/ includes.
12574         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12575         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12576         * nat/aarch64-linux.c: Fix common/ includes.
12577         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12578         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12579         * namespace.h: Fix common/ includes.
12580         * mips-linux-tdep.c: Fix common/ includes.
12581         * minsyms.c: Fix common/ includes.
12582         * mi/mi-parse.h: Fix common/ includes.
12583         * mi/mi-main.c: Fix common/ includes.
12584         * mi/mi-cmd-env.c: Fix common/ includes.
12585         * memrange.h: Fix common/ includes.
12586         * memattr.c: Fix common/ includes.
12587         * maint.h: Fix common/ includes.
12588         * maint.c: Fix common/ includes.
12589         * main.c: Fix common/ includes.
12590         * machoread.c: Fix common/ includes.
12591         * location.c: Fix common/ includes.
12592         * linux-thread-db.c: Fix common/ includes.
12593         * linux-nat.c: Fix common/ includes.
12594         * linux-fork.c: Fix common/ includes.
12595         * inline-frame.c: Fix common/ includes.
12596         * infrun.c: Fix common/ includes.
12597         * inflow.c: Fix common/ includes.
12598         * inferior.h: Fix common/ includes.
12599         * inferior.c: Fix common/ includes.
12600         * infcmd.c: Fix common/ includes.
12601         * inf-ptrace.c: Fix common/ includes.
12602         * inf-child.c: Fix common/ includes.
12603         * ia64-linux-nat.c: Fix common/ includes.
12604         * i387-tdep.c: Fix common/ includes.
12605         * i386-tdep.c: Fix common/ includes.
12606         * i386-linux-tdep.c: Fix common/ includes.
12607         * i386-linux-nat.c: Fix common/ includes.
12608         * i386-go32-tdep.c: Fix common/ includes.
12609         * i386-fbsd-tdep.c: Fix common/ includes.
12610         * i386-fbsd-nat.c: Fix common/ includes.
12611         * guile/scm-type.c: Fix common/ includes.
12612         * guile/guile.c: Fix common/ includes.
12613         * go32-nat.c: Fix common/ includes.
12614         * gnu-nat.c: Fix common/ includes.
12615         * gdbthread.h: Fix common/ includes.
12616         * gdbarch-selftests.c: Fix common/ includes.
12617         * gdb_usleep.c: Fix common/ includes.
12618         * gdb_select.h: Fix common/ includes.
12619         * gdb_bfd.c: Fix common/ includes.
12620         * gcore.c: Fix common/ includes.
12621         * fork-child.c: Fix common/ includes.
12622         * findvar.c: Fix common/ includes.
12623         * fbsd-nat.c: Fix common/ includes.
12624         * event-top.c: Fix common/ includes.
12625         * event-loop.c: Fix common/ includes.
12626         * dwarf2read.c: Fix common/ includes.
12627         * dwarf2loc.c: Fix common/ includes.
12628         * dwarf2-frame.c: Fix common/ includes.
12629         * dwarf-index-cache.c: Fix common/ includes.
12630         * dtrace-probe.c: Fix common/ includes.
12631         * disasm-selftests.c: Fix common/ includes.
12632         * defs.h: Fix common/ includes.
12633         * csky-tdep.c: Fix common/ includes.
12634         * cp-valprint.c: Fix common/ includes.
12635         * cp-support.h: Fix common/ includes.
12636         * cp-support.c: Fix common/ includes.
12637         * corelow.c: Fix common/ includes.
12638         * completer.h: Fix common/ includes.
12639         * completer.c: Fix common/ includes.
12640         * compile/compile.c: Fix common/ includes.
12641         * compile/compile-loc2c.c: Fix common/ includes.
12642         * compile/compile-cplus-types.c: Fix common/ includes.
12643         * compile/compile-cplus-symbols.c: Fix common/ includes.
12644         * command.h: Fix common/ includes.
12645         * cli/cli-dump.c: Fix common/ includes.
12646         * cli/cli-cmds.c: Fix common/ includes.
12647         * charset.c: Fix common/ includes.
12648         * build-id.c: Fix common/ includes.
12649         * btrace.h: Fix common/ includes.
12650         * btrace.c: Fix common/ includes.
12651         * breakpoint.h: Fix common/ includes.
12652         * breakpoint.c: Fix common/ includes.
12653         * ax.h:
12654         (enum agent_op): Fix common/ includes.
12655         * ax-general.c (struct aop_map): Fix common/ includes.
12656         * ax-gdb.c: Fix common/ includes.
12657         * auxv.c: Fix common/ includes.
12658         * auto-load.c: Fix common/ includes.
12659         * arm-tdep.c: Fix common/ includes.
12660         * arch/riscv.c: Fix common/ includes.
12661         * arch/ppc-linux-common.c: Fix common/ includes.
12662         * arch/i386.c: Fix common/ includes.
12663         * arch/arm.c: Fix common/ includes.
12664         * arch/arm-linux.c: Fix common/ includes.
12665         * arch/arm-get-next-pcs.c: Fix common/ includes.
12666         * arch/amd64.c: Fix common/ includes.
12667         * arch/aarch64.c: Fix common/ includes.
12668         * arch/aarch64-insn.c: Fix common/ includes.
12669         * arch-utils.c: Fix common/ includes.
12670         * amd64-windows-tdep.c: Fix common/ includes.
12671         * amd64-tdep.c: Fix common/ includes.
12672         * amd64-sol2-tdep.c: Fix common/ includes.
12673         * amd64-obsd-tdep.c: Fix common/ includes.
12674         * amd64-nbsd-tdep.c: Fix common/ includes.
12675         * amd64-linux-tdep.c: Fix common/ includes.
12676         * amd64-linux-nat.c: Fix common/ includes.
12677         * amd64-fbsd-tdep.c: Fix common/ includes.
12678         * amd64-fbsd-nat.c: Fix common/ includes.
12679         * amd64-dicos-tdep.c: Fix common/ includes.
12680         * amd64-darwin-tdep.c: Fix common/ includes.
12681         * agent.c: Fix common/ includes.
12682         * ada-lang.h: Fix common/ includes.
12683         * ada-lang.c: Fix common/ includes.
12684         * aarch64-tdep.c: Fix common/ includes.
12685
12686 2019-01-25  Tom Tromey  <tom@tromey.com>
12687
12688         * common/create-version.sh: Use common/version.h.
12689
12690 2019-01-24  Pedro Alves  <palves@redhat.com>
12691
12692         * infrun.c (signal_stop, signal_print, signal_program)
12693         (signal_catch, signal_pass): Now arrays instead of pointers.
12694         (update_signals_program_target, do_target_resume)
12695         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12696         * linux-nat.c (linux_nat_target::pass_signals)
12697         (linux_nat_target::create_inferior, linux_nat_target::attach):
12698         Adjust.
12699         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12700         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12701         * procfs.c (procfs_target::pass_signals): Adjust.
12702         * record-full.c (record_full_target::resume): Adjust.
12703         * remote.c (remote_target::pass_signals)
12704         (remote_target::program_signals): Adjust.
12705         * target-debug.h (target_debug_print_signals): Now takes a
12706         gdb::array_view as parameter.  Adjust.
12707         * target.h (target_ops) <pass_signals, program_signals>: Replace
12708         pointer and length parameters with gdb::array_view.
12709         (target_pass_signals, target_program_signals): Likewise.
12710         * target-delegates.c: Regenerate.
12711
12712 2019-01-24  Pedro Alves  <palves@redhat.com>
12713
12714         * common/forward-scope-exit.h
12715         (forward_scope_exit::forward_scope_exit): Pass arguments to
12716         m_bind_function directly, instead of creating a std::bind and
12717         copying that.
12718
12719 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12720
12721         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12722         for static members.
12723         (pass_in_v_vfp_candidate): Likewise.
12724
12725 2019-01-23  Tom Tromey  <tom@tromey.com>
12726             Pedro Alves  <palves@redhat.com>
12727
12728         * regcache.c (class regcache_invalidator): Remove.
12729         (regcache::raw_write): Use make_scope_exit.
12730
12731 2019-01-23  Tom Tromey  <tom@tromey.com>
12732
12733         * ui-out.h (class ui_out_emit_type): Update comment.
12734
12735 2019-01-23  Tom Tromey  <tom@tromey.com>
12736
12737         * infrun.c (fetch_inferior_event): Update comment.
12738
12739 2019-01-23  Tom Tromey  <tom@tromey.com>
12740             Pedro Alves  <palves@redhat.com>
12741
12742         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12743         parameter.
12744         (fetch_inferior_event): Use SCOPE_EXIT.
12745
12746
12747 2019-01-23  Tom Tromey  <tom@tromey.com>
12748             Pedro Alves  <palves@redhat.com>
12749
12750         * infrun.c (disable_thread_events): Delete.
12751         (stop_all_threads): Use SCOPE_EXIT.
12752
12753 2019-01-23  Tom Tromey  <tom@tromey.com>
12754             Pedro Alves  <palves@redhat.com>
12755
12756         * symfile.c: Include forward-scope-exit.h.
12757         (clear_symtab_users_cleanup): Replace forward declaration with
12758         a FORWARD_SCOPE_EXIT.
12759         (syms_from_objfile_1): Use the forward_scope_exit and
12760         gdb::optional instead of cleanup_function.
12761         (reread_symbols): Use the forward_scope_exit instead of
12762         cleanup_function.
12763         (clear_symtab_users_cleanup): Remove function.
12764
12765 2019-01-23  Tom Tromey  <tom@tromey.com>
12766             Pedro Alves  <palves@redhat.com>
12767
12768         * linux-nat.c: Include scope-exit.h.
12769         (cleanup_target_stop): Remove.
12770         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12771         SCOPE_EXIT.
12772
12773 2019-01-23  Tom Tromey  <tom@tromey.com>
12774             Pedro Alves  <palves@redhat.com>
12775
12776         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12777         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12778
12779 2019-01-23  Tom Tromey  <tom@tromey.com>
12780             Andrew Burgess  <andrew.burgess@embecosm.com>
12781             Pedro Alves  <palves@redhat.com>
12782
12783         * infrun.c (fetch_inferior_event): Use scope_exit.
12784         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12785         * top.c (execute_command): Use scope_exit.
12786         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12787         * utils.c (do_bpstat_clear_actions_cleanup)
12788         (make_bpstat_clear_actions_cleanup): Remove.
12789
12790 2019-01-23  Tom Tromey  <tom@tromey.com>
12791             Pedro Alves  <palves@redhat.com>
12792
12793         * infrun.c: Include "common/scope-exit.h"
12794         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12795         (wait_for_inferior): Use SCOPE_EXIT.
12796         (fetch_inferior_event): Use scope_exit.
12797
12798 2019-01-23  Tom Tromey  <tom@tromey.com>
12799             Pedro Alves  <palves@redhat.com>
12800
12801         * breakpoint.c (create_breakpoint): Remove cleanup.
12802
12803 2019-01-23  Tom Tromey  <tom@tromey.com>
12804             Andrew Burgess  <andrew.burgess@embecosm.com>
12805             Pedro Alves  <palves@redhat.com>
12806
12807 2019-01-23  Pedro Alves  <palves@redhat.com>
12808
12809         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12810
12811 2019-01-23  Pedro Alves  <palves@redhat.com>
12812             Andrew Burgess  <andrew.burgess@embecosm.com>
12813
12814         * gdbthread.h: Include "common/forward-scope-exit.h".
12815         (scoped_finish_thread_state): Redefine custom class in terms of
12816         forward_scope_exit.
12817
12818 2019-01-23  Pedro Alves  <palves@redhat.com>
12819             Andrew Burgess  <andrew.burgess@embecosm.com>
12820
12821         * common/forward-scope-exit.h: New file.
12822
12823 2019-01-23  Pedro Alves  <palves@redhat.com>
12824             Andrew Burgess  <andrew.burgess@embecosm.com>
12825             Tom Tromey  <tom@tromey.com>
12826
12827         * common/scope-exit.h: New file.
12828
12829 2019-01-23  Pedro Alves  <palves@redhat.com>
12830
12831         * common/preprocessor.h (ESC): Rename to ...
12832         (ESC_PARENS): ... this.
12833         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12834         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12835
12836 2019-01-23  Tom Tromey  <tom@tromey.com>
12837
12838         * language.h (class scoped_switch_to_sym_language_if_auto):
12839         Initialize m_lang in both cases.
12840
12841 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12842
12843         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12844         with XCNEW.
12845
12846 2019-01-22  Tom Tromey  <tom@tromey.com>
12847
12848         * corelow.c: Do not include sys/file.h.
12849
12850 2019-01-22  Tom Tromey  <tom@tromey.com>
12851
12852         * tui/tui-wingeneral.h: Include gdb_curses.h.
12853
12854 2019-01-22  Tom Tromey  <tom@tromey.com>
12855
12856         * source-cache.h (class source_cache) <get_source_lines,
12857         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12858
12859 2019-01-22  Tom Tromey  <tom@tromey.com>
12860
12861         * remote-fileio.h (struct remote_target): Declare.
12862
12863 2019-01-22  Tom Tromey  <tom@tromey.com>
12864
12865         * python/py-arch.c: Do not include py-ref.h.
12866         * python/py-bpevent.c: Do not include py-ref.h.
12867         * python/py-cmd.c: Do not include py-ref.h.
12868         * python/py-continueevent.c: Do not include py-ref.h.
12869         * python/py-event.h: Do not include py-ref.h.
12870         * python/py-evtregistry.c: Do not include py-ref.h.
12871         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12872         * python/py-frame.c: Do not include py-ref.h.
12873         * python/py-framefilter.c: Do not include py-ref.h.
12874         * python/py-function.c: Do not include py-ref.h.
12875         * python/py-infevents.c: Do not include py-ref.h.
12876         * python/py-linetable.c: Do not include py-ref.h.
12877         * python/py-objfile.c: Do not include py-ref.h.
12878         * python/py-param.c: Do not include py-ref.h.
12879         * python/py-prettyprint.c: Do not include py-ref.h.
12880         * python/py-progspace.c: Do not include py-ref.h.
12881         * python/py-symbol.c: Do not include py-ref.h.
12882         * python/py-symtab.c: Do not include py-ref.h.
12883         * python/py-type.c: Do not include py-ref.h.
12884         * python/py-unwind.c: Do not include py-ref.h.
12885         * python/py-utils.c: Do not include py-ref.h.
12886         * python/py-value.c: Do not include py-ref.h.
12887         * python/py-varobj.c: Do not include py-ref.h.
12888         * python/py-xmethods.c: Do not include py-ref.h.
12889         * python/python.c: Do not include py-ref.h.
12890         * varobj.c: Do not include py-ref.h.
12891
12892 2019-01-22  Tom Tromey  <tom@tromey.com>
12893
12894         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12895         keyword for bcache.
12896
12897 2019-01-22  Tom Tromey  <tom@tromey.com>
12898
12899         * compile/compile-cplus-types.c: Remove a comment by #include.
12900
12901 2019-01-22  Tom Tromey  <tom@tromey.com>
12902
12903         * compile/gcc-c-plugin.h: Include compile-internal.h.
12904
12905 2019-01-22  Tom Tromey  <tom@tromey.com>
12906
12907         * stabsread.c (EXTERN): Do not define.
12908         (symnum, next_symbol_text_func, processing_gcc_compilation)
12909         (within_function, global_sym_chain, global_stabs)
12910         (previous_stab_code, this_object_header_files)
12911         (n_this_object_header_files)
12912         (n_allocated_this_object_header_files): Define.
12913         * stabsread.h (EXTERN): Never define.  Use "extern".
12914
12915 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12916
12917         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12918         history_value.
12919
12920 2019-01-21  Tom Tromey  <tom@tromey.com>
12921
12922         * ui-out.c: Fix includes.
12923         * tui/tui-source.c: Fix includes.
12924         * target.c: Fix includes.
12925         * remote.c: Fix includes.
12926         * regcache.c: Fix includes.
12927         * python/py-block.c: Fix includes.
12928         * printcmd.c: Fix includes.
12929         * or1k-tdep.c: Fix includes.
12930         * mi/mi-main.c: Fix includes.
12931         * m32r-tdep.c: Fix includes.
12932         * csky-tdep.c: Fix includes.
12933         * compile/compile-cplus-types.c: Fix includes.
12934         * cli/cli-interp.c: Fix includes.
12935
12936 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12937
12938         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12939         for padding.
12940
12941 2019-01-16  Tom Tromey  <tom@tromey.com>
12942
12943         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12944         earlier.
12945         (struct objfile) <msymbols_range>: Move from top level.
12946         <msymbols>: New method.
12947         (class objfile_msymbols): Remove.
12948         * symtab.c (default_collect_symbol_completion_matches_break_on):
12949         Update.
12950         * symmisc.c (dump_msymbols): Update.
12951         * stabsread.c (scan_file_globals): Update.
12952         * objc-lang.c (info_selectors_command, info_classes_command)
12953         (find_methods): Update.
12954         * minsyms.c (find_solib_trampoline_target): Update.
12955         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12956         * coffread.c (coff_symfile_read): Update.
12957         * ada-lang.c (ada_lookup_simple_minsym)
12958         (ada_collect_symbol_completion_matches): Update.
12959
12960 2019-01-16  Tom Tromey  <tom@tromey.com>
12961
12962         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12963         type.  Remove no-argument constructor.
12964         <iterator::operator++>: Simplify.
12965         <begin>: Update.
12966         <end>: Use minimal_symbol_count.
12967
12968 2019-01-16  Tom Tromey  <tom@tromey.com>
12969
12970         * objfiles.h (struct objfile) <psymtabs>: New method.
12971         (class objfile_psymtabs): Remove.
12972         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12973         typedef.
12974         <range>: New method.
12975         (require_partial_symbols): Change return type.
12976         * psymtab.c (require_partial_symbols)
12977         (psym_expand_symtabs_matching): Update.
12978         * mdebugread.c (parse_partial_symbols): Update.
12979         * dbxread.c (dbx_end_psymtab): Update.
12980
12981 2019-01-15  Tom Tromey  <tom@tromey.com>
12982
12983         * symtab.c (lookup_objfile_from_block)
12984         (lookup_symbol_in_objfile_symtabs)
12985         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12986         (find_line_symtab, info_sources_command)
12987         (default_collect_symbol_completion_matches_break_on)
12988         (make_source_files_completion_list): Update.
12989         * symmisc.c (print_objfile_statistics, dump_objfile)
12990         (maintenance_print_symbols, maintenance_info_symtabs)
12991         (maintenance_check_symtabs, maintenance_info_line_tables):
12992         Update.
12993         * source.c (select_source_symtab)
12994         (forget_cached_source_info_for_objfile): Update.
12995         * objfiles.h (class objfile_compunits): Remove.
12996         (struct objfile) <compunits_range>: New typedef.
12997         (compunits): New method.
12998         * objfiles.c (objfile_relocate1): Update.
12999         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13000         * maint.c (count_symtabs_and_blocks): Update.
13001         * linespec.c (iterate_over_all_matching_symtabs): Update.
13002         * cp-support.c (add_symbol_overload_list_qualified): Update.
13003         * coffread.c (coff_symtab_read): Update.
13004         * ada-lang.c (add_nonlocal_symbols)
13005         (ada_collect_symbol_completion_matches)
13006         (ada_add_global_exceptions): Update.
13007
13008 2019-01-15  Tom Tromey  <tom@tromey.com>
13009
13010         * progspace.h (program_space) <objfiles_safe_range>: New
13011         typedef.
13012         <objfiles_safe>: New method.
13013         * objfiles.h (class all_objfiles_safe): Remove.
13014         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13015         * jit.c (jit_inferior_exit_hook): Update.
13016
13017 2019-01-17  Tom Tromey  <tom@tromey.com>
13018
13019         * progspace.h (program_space) <objfiles_range>: New typedef.
13020         <objfiles>: New method.
13021         <objfiles_head>: Rename from objfiles.
13022         (object_files): Update.
13023         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13024         * guile/scm-pretty-print.c
13025         (ppscm_find_pretty_printer_from_objfiles): Update.
13026         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13027         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13028         Update.
13029         * python/py-progspace.c (pspy_get_objfiles): Update.
13030         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13031         Update.
13032         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13033         (objfpy_lookup_objfile_by_build_id): Update.
13034         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13035         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13036         Update.
13037         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13038         (expand_symtab_containing_pc, lookup_objfile_from_block)
13039         (lookup_static_symbol, basic_lookup_transparent_type)
13040         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13041         (find_line_symtab, info_sources_command)
13042         (default_collect_symbol_completion_matches_break_on)
13043         (make_source_files_completion_list, find_main_name): Update.
13044         * symmisc.c (print_symbol_bcache_statistics)
13045         (print_objfile_statistics, maintenance_print_symbols)
13046         (maintenance_print_msymbols, maintenance_print_objfiles)
13047         (maintenance_info_symtabs, maintenance_check_symtabs)
13048         (maintenance_expand_symtabs, maintenance_info_line_tables):
13049         Update.
13050         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13051         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13052         (map_overlay_command, unmap_overlay_command)
13053         (simple_overlay_update, expand_symtabs_matching)
13054         (map_symbol_filenames): Update.
13055         * symfile-debug.c (set_debug_symfile): Update.
13056         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13057         Update.
13058         * source.c (select_source_symtab, forget_cached_source_info):
13059         Update.
13060         * solib.c (solib_read_symbols): Update.
13061         * solib-spu.c (append_ocl_sos): Update.
13062         * psymtab.c (maintenance_print_psymbols)
13063         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13064         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13065         * printcmd.c (info_symbol_command): Update.
13066         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13067         Update.
13068         * objfiles.h (class all_objfiles): Remove.
13069         * objfiles.c (have_partial_symbols, have_full_symbols)
13070         (have_minimal_symbols, qsort_cmp, update_section_map)
13071         (shared_objfile_contains_address_p)
13072         (default_iterate_over_objfiles_in_search_order): Update.
13073         * objc-lang.c (info_selectors_command, info_classes_command)
13074         (find_methods): Update.
13075         * minsyms.c (find_solib_trampoline_target): Update.
13076         * maint.c (maintenance_info_sections)
13077         (maintenance_translate_address, count_symtabs_and_blocks):
13078         Update.
13079         * main.c (captured_main_1): Update.
13080         * linux-thread-db.c (try_thread_db_load_from_pdir)
13081         (has_libpthread): Update.
13082         * linespec.c (iterate_over_all_matching_symtabs)
13083         (search_minsyms_for_name): Update.
13084         * jit.c (jit_find_objf_with_entry_addr): Update.
13085         * hppa-tdep.c (find_unwind_entry)
13086         (hppa_lookup_stub_minimal_symbol): Update.
13087         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13088         Update.
13089         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13090         (elf_gnu_ifunc_resolve_by_got): Update.
13091         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13092         * dwarf-index-write.c (save_gdb_index_command): Update.
13093         * cp-support.c (add_symbol_overload_list_qualified): Update.
13094         * breakpoint.c (create_overlay_event_breakpoint)
13095         (create_longjmp_master_breakpoint)
13096         (create_std_terminate_master_breakpoint)
13097         (create_exception_master_breakpoint): Update.
13098         * blockframe.c (find_pc_partial_function): Update.
13099         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13100         (ada_collect_symbol_completion_matches)
13101         (ada_add_global_exceptions): Update.
13102
13103 2019-01-17  Tom Tromey  <tom@tromey.com>
13104
13105         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13106         declare VEC.
13107         (solib_target_parse_libraries): Change return type.
13108         (library_list_start_segment, library_list_start_section)
13109         (library_list_end_library, library_list_start_library); Update.
13110         (solib_target_free_library_list): Remove.
13111         (solib_target_parse_libraries): Remove cleanup.  Change return
13112         type.
13113         (solib_target_current_sos): Update.
13114
13115 2019-01-17  Tom Tromey  <tromey@bapiya>
13116
13117         * valprint.c: Replace "the the" with "the".
13118         * symtab.c: Replace "the the" with "the".
13119         * solib.c: Replace "the the" with "the".
13120         * solib-dsbt.c: Replace "the the" with "the".
13121         * linespec.c: Replace "the the" with "the".
13122         * dwarf2loc.h: Replace "the the" with "the".
13123         * amd64-windows-tdep.c: Replace "the the" with "the".
13124         * aarch64-tdep.c: Replace "the the" with "the".
13125
13126 2019-01-16  Keith Seitz  <keiths@redhat.com>
13127
13128         PR gdb/23773
13129         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13130         <builder>: Rename to ..
13131         <m_builder>: ... this and make private.
13132         (dwarf2_cu::get_builder): New method.  Change all users of
13133         `builder' to use this method.
13134         (dwarf2_start_symtab): Move to ...
13135         (dwarf2_cu::start_symtab): ... here.  Update all callers
13136         (setup_type_unit_groups): Move to ...
13137         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13138         callers.
13139         (dwarf2_cu::reset_builder): New method.
13140         (process_full_compunit, process_full_type_unit): Use
13141         dwarf2_cu::reset_builder.
13142         (follow_die_offset): Record the ancestor CU if it is different
13143         from the followed DIE's CU.
13144         (follow_die_sig_1): Likewise.
13145
13146 2019-01-15  Tom Tromey  <tom@tromey.com>
13147
13148         * remote.c (class remote_state) <buf>: Now a char_vector.
13149         <buf_size>: Remove.
13150         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13151         parameter.
13152         (remote_target::getpkt_or_notif_sane_1)
13153         (remote_target::getpkt_sane)
13154         (remote_target::getpkt_or_notif_sane): Likewise.
13155         (class remote_target) <putpkt>: New overload.
13156         (remote_target::read_frame): Change type of "buf_p".  Remove
13157         sizeof_p parameter.
13158         (packet_ok): New overload.
13159         (packet_check_result): New overload.
13160         Update all uses.
13161
13162 2019-01-14  Tom Tromey  <tom@tromey.com>
13163
13164         * remote-notif.c (handle_notification, remote_notif_ack)
13165         (remote_notif_parse): Make "buf" const.
13166         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13167         const.
13168         (remote_notif_parse, remote_notif_ack, handle_notification):
13169         Likewise.
13170         * remote.c (remote_notif_stop_parse): Make "buf" const.
13171         (remote_target::remote_parse_stop_reply): Make "buf" const.
13172         (remote_notif_stop_ack): Make "buf" const.
13173
13174 2019-01-14  Tom Tromey  <tom@tromey.com>
13175
13176         * remote.c (remote_console_output): Make parameter const.
13177
13178 2019-01-14  Tom Tromey  <tom@tromey.com>
13179
13180         * target-debug.h (target_debug_print_signals): Constify.
13181         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13182         * procfs.c (procfs_target::pass_signals): Update.
13183         * linux-nat.c (linux_nat_target::pass_signals): Update.
13184         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13185         * target-delegates.c: Rebuild.
13186         * remote.c (remote_target::program_signals): Update.
13187         (remote_target::pass_signals): Update.
13188         * target.c (target_pass_signals): Constify argument.
13189         (target_program_signals): Likewise.
13190         * target.h (struct target_ops) <pass_signals, program_signals>:
13191         Constify argument.
13192         (target_pass_signals, target_program_signals): Constify argument.
13193
13194 2019-01-14  Tom Tromey  <tom@tromey.com>
13195
13196         PR tui/28819:
13197         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13198
13199 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13200
13201         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13202         field.
13203         * rs6000-tdep.c: Include reggroups.h.
13204         (IS_V_ALIAS_PSEUDOREG): Define.
13205         (rs6000_register_name): Return names for the "vX" aliases.
13206         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13207         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13208         aliases.  Call default_register_reggroup_p for all other
13209         pseudo-registers.
13210         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13211         New functions.
13212         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13213         Handle "vX" aliases.
13214         (v_alias_pseudo_register_collect): New function.
13215         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13216         (rs6000_gdbarch_init): Initialize "vX" aliases as
13217         pseudo-registers.  Restore registration of
13218         rs6000_pseudo_register_reggroup_p with
13219         set_tdesc_pseudo_register_reggroup_p.
13220
13221 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13222
13223         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13224         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13225         set_gdbarch_num_pseudo_regs.
13226
13227 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13228
13229         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13230         Remove arg prefixname, add do_set and do_show.
13231         Add member functions set_list and show_list.
13232         * cli/cli-style.c (class cli_style_option): Update accordingly.
13233         (style_set_list): Move to file scope.
13234         (style_show_list): Likewise.
13235         (set_style): Call help_list.
13236         (show_style): Call cmd_show_list.
13237         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13238         Update to use the new macro.
13239
13240 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13241
13242         * ada-lang.c (_initialize_ada_language): Expand the help text
13243         for the "catch exception" command.
13244
13245 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13246
13247         * symtab.c (matching_obj_sections): Initialize obj,
13248         declare it closer to its usage.
13249
13250 2019-01-10  Tom Tromey  <tom@tromey.com>
13251
13252         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13253         (basic_inf_threads_range): Remove.
13254         (inf_threads_range, inf_non_exited_threads_range)
13255         (safe_inf_threads_range): Use next_adapter.
13256
13257 2019-01-10  Keith Seitz  <keiths@redhat.com>
13258
13259         PR gdb/23712
13260         PR symtab/23010
13261         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13262         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13263
13264 2019-01-10  Keith Seitz  <keiths@redhat.com>
13265
13266         PR gdb/23712
13267         PR symtab/23010
13268         * dictionary.c (pending_to_vector): Remove.
13269         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13270         Remove _1 suffix, replacing functions of the same name.  Update
13271         all callers.
13272         (dict_create_hashed, dict_create_hashed_expandable)
13273         (dict_create_linear, dict_create_linear_expandable, dict_free)
13274         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13275         Make functions static.
13276
13277 2019-01-10  Keith Seitz  <keiths@redhat.com>
13278
13279         PR gdb/23712
13280         PR symtab/23010
13281         * dictionary.h (struct dictionary): Replace declaration with
13282         multidictionary.
13283         (dict_create_hashed, dict_create_hashed_expandable)
13284         (dict_create_linear, dict_create_linear_expandable)
13285         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13286         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13287         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13288         taking multidictionary argument.
13289         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13290         * block.h (struct block) <dict>: Change to multidictionary
13291         and rename `multidict'.
13292         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13293         symmisc.c: Update all dictionary references to multidictionary.
13294
13295 2019-01-10  Keith Seitz  <keiths@redhat.com>
13296
13297         PR gdb/23712
13298         PR symtab/23010
13299         * dictionary.c: Include unordered_map.
13300         (pending_to_vector): New function.
13301         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13302         Rewrite the non-"_1" functions to take vector instead
13303         of linked list.
13304         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13305         "new" _1 versions of the same name.
13306         (multidictionary): Define.
13307         (std::hash<enum language): New definition.
13308         (collate_pending_symbols_by_language, mdict_create_hashed)
13309         (mdict_create_hashed_expandable, mdict_create_linear)
13310         (mdict_create_linear_expandable, mdict_free)
13311         (find_language_dictionary, create_new_language_dictionary)
13312         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13313         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13314         (mdict_size, mdict_empty): New functions.
13315         * dictionary.h (mdict_iterator): Define.
13316
13317 2019-01-10  Pedro Alves  <palves@redhat.com>
13318
13319         * breakpoint.c (read_uploaded_action)
13320         (create_tracepoint_from_upload): Adjust to use
13321         gdb::unique_xmalloc_ptr.
13322         * ctf.c (ctf_write_uploaded_tp):
13323         (SET_ARRAY_FIELD): Use emplace_back.
13324         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13325         * tracefile-tfile.c (tfile_write_uploaded_tp):
13326         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13327         gdb::unique_xmalloc_ptr.
13328         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13329         at_string, cond_string, cmd_strings>: Replace char pointers
13330         with gdb::unique_xmalloc_ptr.
13331
13332 2019-01-10  Pedro Alves  <palves@redhat.com>
13333
13334         * solib-target.c (library_list_start_library): Don't xstrdup name.
13335
13336 2019-01-10  Pedro Alves  <palves@redhat.com>
13337
13338         * mdebugread.c (parse_partial_symbols): Use
13339         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13340
13341 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13342
13343         * linux-fork.c (scoped_switch_fork_info)
13344         <~scoped_switch_fork_info>: Fix incorrect variable name.
13345
13346 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13347
13348         * linux-fork.c (scoped_switch_fork_info)
13349         <scoped_switch_fork_info>: Make explicit.
13350         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13351
13352 2019-01-10  Tom Tromey  <tom@tromey.com>
13353
13354         * objfiles.h (objfile::reset_psymtabs): Update.
13355         * objfiles.c (objfile::objfile): Update.
13356         * psymtab.h (psymtab_storage::obstack): Update.
13357         (psymtab_storage::m_obstack): Use gdb::optional.
13358         (class psymtab_storage): Update comment.  Remove objfile
13359         parameter.
13360         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13361
13362 2019-01-10  Tom Tromey  <tom@tromey.com>
13363
13364         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13365         <free_psymtabs>: Now private.
13366         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13367         (allocate_psymtab): Use new method.
13368
13369 2019-01-10  Tom Tromey  <tom@tromey.com>
13370
13371         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13372         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13373         * mdebugread.c (parse_partial_symbols): Use
13374         allocate_dependencies.
13375         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13376         allocate_dependencies.
13377         (process_psymtab_comp_unit_reader)
13378         (build_type_psymtab_dependencies): Likewise.
13379         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13380
13381 2019-01-10  Tom Tromey  <tom@tromey.com>
13382
13383         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13384         PSYMBOL_SET_LANGUAGE.
13385         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13386
13387 2019-01-10  Tom Tromey  <tom@tromey.com>
13388
13389         * psymtab.h (psymtab_storage::obstack): New method.
13390         <m_obstack>: Rename from obstack; now private.
13391         * psymtab.c (psymtab_storage): Update.
13392         * dwarf2read.c (create_addrmap_from_index)
13393         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13394         Update.
13395
13396 2019-01-10  Tom Tromey  <tom@tromey.com>
13397
13398         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13399         * objfiles.h (objfile::reset_psymtabs): New method.
13400
13401 2019-01-10  Tom Tromey  <tom@tromey.com>
13402
13403         * symmisc.c (print_symbol_bcache_statistics): Update.
13404         (print_objfile_statistics): Update.
13405         * symfile.c (reread_symbols): Update.
13406         * psymtab.h (class psymtab_storage): New.
13407         * psymtab.c (psymtab_storage): New constructor.
13408         (~psymtab_storage): New destructor.
13409         (require_partial_symbols): Update.
13410         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13411         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13412         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13413         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13414         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13415         (start_psymtab_common, end_psymtab_common)
13416         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13417         (allocate_psymtab): Update.
13418         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13419         Update.
13420         (dump_psymtab_addrmap, maintenance_print_psymbols)
13421         (maintenance_check_psymtabs): Update.
13422         (class objfile_psymtabs): Move to objfiles.h.
13423         * psympriv.h (discard_psymtab): Now inline.
13424         (psymtab_discarder::psymtab_discarder): Update.
13425         (psymtab_discarder::~psymtab_discarder): Update.
13426         (ALL_OBJFILE_PSYMTABS): Rewrite.
13427         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13428         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13429         Remove fields.
13430         <partial_symtabs>: New field.
13431         (class objfile_psymtabs): Move from psymtab.h.  Update.
13432         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13433         psymbol_cache.
13434         (objfile::~objfile): Don't destroy psymbol_cache.
13435         * mdebugread.c (parse_partial_symbols): Update.
13436         * dwarf2read.c (create_addrmap_from_index)
13437         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13438         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13439         (add_partial_subprogram, dwarf2_ranges_read): Update.
13440         * dwarf-index-write.c (write_address_map)
13441         (write_one_signatured_type, recursively_write_psymbols)
13442         (class debug_names, class debug_names, write_psymtabs_to_index):
13443         Update.
13444
13445 2019-01-10  Tom Tromey  <tom@tromey.com>
13446
13447         * symtab.h (SYMBOL_SET_NAMES): Update.
13448         (symbol_set_names): Update.
13449         (MSYMBOL_SET_NAMES): Update.
13450         * symtab.c (symbol_set_names): Change argument to be an
13451         objfile_per_bfd_storage.
13452         * psymtab.c (add_psymbol_to_bcache): Update.
13453         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13454
13455 2019-01-10  Tom Tromey  <tom@tromey.com>
13456
13457         * symtab.c (create_demangled_names_hash): Change argument to be an
13458         objfile_per_bfd_storage.
13459         (symbol_set_names): Update.
13460
13461 2019-01-10  Tom Tromey  <tom@tromey.com>
13462
13463         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13464         init_psymbol_list.
13465         * psymtab.c (init_psymbol_list): Do nothing if already called.
13466         * psympriv.h (init_psymbol_list): Add comment.
13467         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13468         init_psymbol_list.
13469         * dbxread.c (dbx_symfile_read): Unconditionally call
13470         init_psymbol_list.
13471
13472 2019-01-10  Tom Tromey  <tom@tromey.com>
13473
13474         * xcoffread.c (scan_xcoff_symtab): Update.
13475         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13476         "where".
13477         * mdebugread.c (parse_partial_symbols)
13478         (handle_psymbol_enumerators): Update.
13479         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13480         * dbxread.c (read_dbx_symtab): Update.
13481         * psympriv.h (psymbol_placement): New enum.
13482         (add_psymbol_to_list): Update.
13483
13484 2019-01-10  Tom Tromey  <tom@tromey.com>
13485
13486         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13487         static_psymbols parameters.
13488         (scan_xcoff_symtab): Update.
13489         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13490         static_psymbols parameters.
13491         * psympriv.h (start_psymtab_common): Update.
13492         * mdebugread.c (parse_partial_symbols): Update.
13493         * dwarf2read.c (create_partial_symtab): Update.
13494         * dbxread.c (read_dbx_symtab): Update.
13495         (start_psymtab): Remove global_psymbols and static_psymbols
13496         parameters.
13497
13498 2019-01-10  Tom Tromey  <tom@tromey.com>
13499
13500         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13501         * psymtab.c (allocate_psymtab): Add comment.
13502         * psympriv.h (allocate_psymtab): Add comment.
13503         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13504         initializations.
13505         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13506
13507 2019-01-10  Tom Tromey  <tom@tromey.com>
13508
13509         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13510         Don't declare.
13511         * mipsread.c: Include mdebugread.h.
13512         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13513         Declare.
13514         * elfread.c: Include mdebugread.h.
13515
13516 2019-01-09  Tom Tromey  <tom@tromey.com>
13517
13518         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13519         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13520         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13521         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13522         (psym_lookup_symbol, psym_find_last_source_symtab)
13523         (psym_forget_cached_source_info, psym_print_stats)
13524         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13525         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13526         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13527         (psym_find_compunit_symtab_by_address)
13528         (maintenance_print_psymbols, maintenance_info_psymtabs)
13529         (maintenance_check_psymtabs): Use ranged for.
13530         * psymtab.h (class objfile_psymtabs): New.
13531         (require_partial_symbols): Return objfile_psymtabs.
13532         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13533
13534 2019-01-09  Tom Tromey  <tom@tromey.com>
13535
13536         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13537         (find_pc_mapped_section, list_overlays_command)
13538         (map_overlay_command, unmap_overlay_command)
13539         (simple_overlay_update): Use all_objfiles.
13540         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13541         * printcmd.c (info_symbol_command): Use all_objfiles.
13542         * objfiles.h (ALL_OBJSECTIONS): Remove.
13543         * maint.c (maintenance_translate_address): Use all_objfiles.
13544         * gcore.c (gcore_create_callback): Use all_objfiles.
13545         (objfile_find_memory_regions): Likewise.
13546
13547 2019-01-09  Tom Tromey  <tom@tromey.com>
13548
13549         * symtab.c (find_line_symtab, info_sources_command)
13550         (make_source_files_completion_list): Use objfile_compunits.
13551         * source.c (select_source_symtab): Use objfile_compunits.
13552         * objfiles.h (struct objfile): Update comment.
13553         (ALL_OBJFILES): Remove.
13554         (ALL_FILETABS): Remove.
13555         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13556         objfile_compunits.
13557
13558 2019-01-09  Tom Tromey  <tom@tromey.com>
13559
13560         * symmisc.c (print_objfile_statistics, dump_objfile)
13561         (maintenance_print_symbols): Use compunit_filetabs.
13562         * source.c (forget_cached_source_info_for_objfile): Use
13563         compunit_filetabs.
13564         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13565         (ALL_FILETABS): Use compunit_filetabs.
13566         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13567         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13568
13569 2019-01-09  Tom Tromey  <tom@tromey.com>
13570
13571         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13572         (compunit_filetabs): New.
13573         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13574         compunit_filetabs.
13575         (info_sources_command, make_source_files_completion_list): Remove
13576         declaration.
13577         * symmisc.c (print_objfile_statistics, dump_objfile)
13578         (maintenance_print_symbols): Remove declaration.
13579         (maintenance_info_symtabs): Use compunit_filetabs.
13580         (maintenance_info_line_tables): Likewise.
13581         * source.c (select_source_symtab): Change local variable name.
13582         (forget_cached_source_info_for_objfile): Remove declaration.
13583         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13584         * objfiles.c (objfile_relocate1): Remove declaration.
13585         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13586         declaration.
13587         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13588         * coffread.c (coff_symtab_read): Remove declaration.
13589         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13590         compunit_filetabs.
13591
13592 2019-01-09  Tom Tromey  <tom@tromey.com>
13593
13594         * symtab.c (lookup_objfile_from_block)
13595         (find_pc_sect_compunit_symtab, search_symbols)
13596         (default_collect_symbol_completion_matches_break_on): Use
13597         objfile_compunits.
13598         * objfiles.h (ALL_COMPUNITS): Remove.
13599         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13600         * cp-support.c (add_symbol_overload_list_qualified): Use
13601         objfile_compunits.
13602         * ada-lang.c (ada_collect_symbol_completion_matches)
13603         (ada_add_global_exceptions): Use objfile_compunits.
13604
13605 2019-01-09  Tom Tromey  <tom@tromey.com>
13606
13607         * source.c (select_source_symtab)
13608         (forget_cached_source_info_for_objfile): Remove declaration.
13609         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13610         declaration.
13611         * maint.c (count_symtabs_and_blocks): Remove declaration.
13612         * cp-support.c (add_symbol_overload_list_qualified): Remove
13613         declaration.
13614         * coffread.c (coff_symtab_read): Remove declaration.
13615         * symtab.c (lookup_symbol_in_objfile_symtabs)
13616         (basic_lookup_transparent_type_1): Use objfile_compunits.
13617         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13618         (info_sources_command, search_symbols)
13619         (default_collect_symbol_completion_matches_break_on)
13620         (make_source_files_completion_list): Remove declaration.
13621         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13622         (ada_collect_symbol_completion_matches)
13623         (ada_add_global_exceptions): Remove declaration.
13624         * linespec.c (iterate_over_all_matching_symtabs): Use
13625         objfile_compunits.
13626         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13627         (class objfile_compunits): New.
13628         (ALL_COMPUNITS): Use objfile_compunits.
13629         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13630         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13631         objfile_compunits.
13632         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13633
13634 2019-01-09  Tom Tromey  <tom@tromey.com>
13635
13636         * symtab.c (search_symbols)
13637         (default_collect_symbol_completion_matches_break_on): Use
13638         objfile_msymbols.
13639         * ada-lang.c (ada_lookup_simple_minsym)
13640         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13641         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13642         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13643         objfile_msymbols.
13644         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13645         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13646         * objc-lang.c (find_methods): Use objfile_msymbols.
13647         (info_selectors_command, info_classes_command): Likewise.
13648         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13649         * objfiles.h (class objfile_msymbols): New.
13650         (ALL_OBJFILE_MSYMBOLS): Remove.
13651         (ALL_MSYMBOLS): Remove.
13652
13653 2019-01-09  Tom Tromey  <tom@tromey.com>
13654
13655         * common/next-iterator.h (next_adapter): Add Iterator template
13656         parameter.
13657         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13658         (class all_objfiles_safe): New.
13659         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13660         * objfiles.c (put_objfile_before): Update comment.
13661         (add_separate_debug_objfile): Likewise.
13662         (free_all_objfiles): Use all_objfiles_safe.
13663         (objfile_purge_solibs): Likewise.
13664
13665 2019-01-09  Tom Tromey  <tom@tromey.com>
13666
13667         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13668         (expand_symtab_containing_pc, lookup_static_symbol)
13669         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13670         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13671         all_objfiles.
13672         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13673         * breakpoint.c (create_overlay_event_breakpoint)
13674         (create_longjmp_master_breakpoint)
13675         (create_std_terminate_master_breakpoint)
13676         (create_exception_master_breakpoint): Use all_objfiles.
13677         * linux-thread-db.c (try_thread_db_load_from_pdir)
13678         (has_libpthread): Use all_objfiles.
13679         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13680         * linespec.c (iterate_over_all_matching_symtabs)
13681         (search_minsyms_for_name): Use all_objfiles.
13682         * maint.c (maintenance_info_sections): Use all_objfiles.
13683         * main.c (captured_main_1): Use all_objfiles.
13684         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13685         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13686         * guile/scm-pretty-print.c
13687         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13688         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13689         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13690         (maintenance_print_msymbols): Use all_objfiles.
13691         * source.c (select_source_symtab): Use all_objfiles.
13692         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13693         * symfile.c (remove_symbol_file_command)
13694         (expand_symtabs_matching, map_symbol_filenames): Use
13695         all_objfiles.
13696         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13697         all_objfiles.
13698         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13699         * objc-lang.c (find_methods): Use all_objfiles.
13700         * objfiles.c (have_partial_symbols, have_full_symbols)
13701         (have_minimal_symbols, qsort_cmp)
13702         (default_iterate_over_objfiles_in_search_order): Use
13703         all_objfiles.
13704         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13705         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13706         (maintenance_check_psymtabs): Use all_objfiles.
13707         (ALL_PSYMTABS): Remove.
13708         * compile/compile-object-run.c (do_module_cleanup): Use
13709         all_objfiles.
13710         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13711         * cp-support.c (add_symbol_overload_list_qualified): Use
13712         all_objfiles.
13713         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13714         Use all_objfiles.
13715         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13716         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13717         all_objfiles.
13718         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13719         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13720         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13721         Uses all_objfiles.
13722         * solib.c (solib_read_symbols): Use all_objfiles
13723
13724 2019-01-09  Tom Tromey  <tom@tromey.com>
13725
13726         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13727         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13728         all_objfiles.
13729         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13730         * symmisc.c (print_symbol_bcache_statistics)
13731         (print_objfile_statistics, maintenance_print_objfiles)
13732         (maintenance_info_symtabs, maintenance_check_symtabs)
13733         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13734         all_objfiles.
13735         * source.c (forget_cached_source_info): Use all_objfiles.
13736         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13737         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13738         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13739         * objfiles.c (update_section_map): Use all_objfiles.
13740         (shared_objfile_contains_address_p): Likewise.
13741         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13742         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13743
13744 2019-01-09  Tom Tromey  <tom@tromey.com>
13745
13746         * common/next-iterator.h: New file.
13747         * objfiles.h (class all_objfiles): New.
13748         (struct objfile_iterator): New.
13749
13750 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13751
13752         * NEWS: Move the description of the changed "frame", "select-frame",
13753          and "info frame" commands to the Changed commands section.
13754
13755 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13756
13757         * gdbtypes.c (check_stub_method_group): Remove handling of old
13758         mangling schemes.
13759         * linespec.c (find_methods): Likewise.
13760         * stabsread.c (read_member_functions): Likewise.
13761         * valops.c (search_struct_method): Likewise.
13762         (value_struct_elt_for_reference): Likewise.
13763         * NEWS: Mention this change.
13764
13765 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13766
13767         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13768         print_source_lines.
13769         * source.c (print_source_lines_base): Update line number check.
13770         (print_source_lines): New function.
13771         (source_lines_range::source_lines_range): New function.
13772         * source.h (class source_lines_range): New class.
13773         (print_source_lines): New declaration.
13774
13775 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13776
13777         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13778
13779 2019-01-08  Tom Tromey  <tom@tromey.com>
13780             Simon Marchi  <simon.marchi@ericsson.com>
13781
13782         PR gdb/24060
13783         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13784         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13785         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13786         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13787         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13788         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13789
13790 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13791
13792         * source.c (select_source_symtab): Move header comment to
13793         declaration in source.h.
13794         (forget_cached_source_info_for_objfile): Likewise.
13795         (forget_cached_source_info): Likewise.
13796         (identify_source_line): Likewise.
13797         * source.h (identify_source_line): Move declaration from symtab.h
13798         and add comment from source.c
13799         (print_source_lines): Likewise.
13800         (forget_cached_source_info_for_objfile): Likewise.
13801         (forget_cached_source_info): Likewise.
13802         (select_source_symtab): Likewise.
13803         (enum print_source_lines_flag): Move definition from symtab.h.
13804         * symtab.h (identify_source_line): Move declaration to source.h.
13805         (print_source_lines): Likewise.
13806         (forget_cached_source_info_for_objfile): Likewise.
13807         (forget_cached_source_info): Likewise.
13808         (select_source_symtab): Likewise.
13809         (enum print_source_lines_flag): Move definition to source.h.
13810         * tui/tui-hooks.c: Add 'source.h' include.
13811
13812 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13813
13814         * source.c (print_source_lines_base): Handle requests to print
13815         reverse line number sequences, and guard against empty lines
13816         string.
13817
13818 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13819
13820         * source.c (print_source_lines_base): Fix skip of '\r' if next
13821         character is '\n'.
13822
13823 2019-01-06  Tom Tromey  <tom@tromey.com>
13824
13825         * c-exp.y (struct c_parse_state) <macro_original_text,
13826         expansion_obstack>: New member.
13827         (macro_original_text, expansion_obstack): Remove globals.
13828         (scan_macro_expansion, scanning_macro_expansion)
13829         (finished_macro_expansion): Update.
13830         (scan_macro_cleanup): Remove.
13831         (yylex, c_parse): Update.
13832
13833 2019-01-06  Tom Tromey  <tom@tromey.com>
13834
13835         * c-exp.y (struct c_parse_state) <strings>: New member.
13836         (operator_stoken): Update.
13837
13838 2019-01-06  Tom Tromey  <tom@tromey.com>
13839
13840         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13841         (union type_stack_elt) <typelist_val>: Now a pointer to
13842         std::vector.
13843         (type_stack_cleanup): Don't declare.
13844         (push_typelist): Update.
13845         * parse.c (pop_typelist): Return a std::vector.
13846         (push_typelist): Take a std::vector.
13847         (follow_types): Update.  Do not free args.
13848         (type_stack_cleanup): Remove.
13849         * c-exp.y (struct c_parse_state): New.
13850         (cpstate): New global.
13851         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13852         (nonempty_typelist): Update.
13853         (func_mod): Create a new vector.
13854         (c_parse): Create a c_parse_state.
13855         (check_parameter_typelist): Do not delete params.
13856         (function_method): Update.  Do not delete type_list.
13857
13858 2019-01-06  Tom Tromey  <tom@tromey.com>
13859
13860         PR gdb/28155:
13861         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13862         check_typedef.
13863         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13864         (print_return_value): Likewise.
13865
13866 2019-01-05  Tom Tromey  <tom@tromey.com>
13867
13868         * contrib/cleanup_check.py: Remove.
13869         * contrib/gcc-with-excheck: Remove.
13870         * contrib/exsummary.py: Remove.
13871         * contrib/excheck.py: Remove.
13872
13873 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13874
13875         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13876         NULL. Initialize tpprev to NULL instead of assigning it
13877         to NULL on the next statement.
13878         * windows-nat.c (windows_delete_thread): Remove check for
13879         main_thread_id before printing thread exit notifications.
13880         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13881         Remove thread ID check against main_thread_id.
13882         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13883         windows_delete_thread.
13884         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13885
13886 2019-01-04  Tom Tromey  <tom@tromey.com>
13887
13888         * compile/compile.c (_initialize_compile): Use upper case for
13889         metasyntactic variables.
13890         * symmisc.c (_initialize_symmisc): Use upper case for
13891         metasyntactic variables.
13892         * psymtab.c (_initialize_psymtab): Use upper case for
13893         metasyntactic variables.
13894         * demangle.c (demangle_command): Use upper case for metasyntactic
13895         variables.
13896         (_initialize_demangler): Likewise.
13897         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13898         variables.
13899
13900 2019-01-03  Tom Tromey  <tom@tromey.com>
13901
13902         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13903
13904 2019-01-03  Tom Tromey  <tom@tromey.com>
13905
13906         * python/py-symtab.c (salpy_str): Update.
13907         (struct salpy_sal_object) <symtab>: Now a PyObject.
13908         (salpy_dealloc): Update.
13909         (del_objfile_sal): Use gdbpy_ref.
13910
13911 2019-01-03  Tom Tromey  <tom@tromey.com>
13912
13913         * python/py-type.c (convert_field): Use new_reference.  Return
13914         gdbpy_ref.
13915         (make_fielditem): Return gdbpy_ref.
13916         (typy_fields): Update.
13917         (typy_getitem): Update.
13918         (field_name): Return gdbpy_ref.  Use new_reference.
13919         (typy_iterator_iternext): Update.
13920
13921 2019-01-03  Tom Tromey  <tom@tromey.com>
13922
13923         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13924
13925 2019-01-03  Tom Tromey  <tom@tromey.com>
13926
13927         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13928         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13929         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13930         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13931         (pspy_set_type_printers): Likewise.
13932         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13933         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13934         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13935         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13936         (objfpy_set_type_printers): Likewise.
13937
13938 2019-01-03  Tom Tromey  <tom@tromey.com>
13939
13940         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13941         (gdbpy_print_stack): Use gdbpy_err_fetch.
13942         * python/python-internal.h (class gdbpy_err_fetch): New class.
13943         (class gdbpy_enter) <m_error_type, m_error_value,
13944         m_error_traceback>: Remove.
13945         <m_error>: New member.
13946         (gdbpy_exception_to_string): Don't declare.
13947         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13948         * python/py-value.c (convert_value_from_python): Use
13949         gdbpy_err_fetch.
13950         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13951         gdbpy_exception_to_string.
13952         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13953         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13954         gdbpy_err_fetch.
13955
13956 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13957
13958         * linux-nat.c (delete_lwp_cleanup): Delete.
13959         (struct lwp_deleter): New struct.
13960         (lwp_info_up): New typedef.
13961         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13962         lwp_info_up.
13963
13964 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13965
13966         * linux-fork.c (class scoped_switch_fork_info): New class.
13967         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13968
13969 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13970
13971         * valops.c (find_overload_match): Remove use of null_cleanup, and
13972         calls to do_cleanups.
13973
13974 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13975
13976         * compile/compile-cplus-types.c
13977         (compile_cplus_instance::decl_name): Handle changes to
13978         cp_func_name.
13979         * cp-support.c (cp_func_name): Update header comment, update
13980         return type.
13981         * cp-support.h (cp_func_name): Update return type in declaration.
13982         * valops.c (find_overload_match): Move temp_func local to top
13983         level of function and change its type.  Use temp_func to hold and
13984         delete temporary string obtained from cp_func_name.
13985
13986 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13987
13988         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13989         gdb::char_vector, remove cleanup, and update uses of `msg`.
13990
13991 2019-01-03  Jim Wilson  <jimw@sifive.com>
13992
13993         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13994
13995 2019-01-02  Tom Tromey  <tom@tromey.com>
13996
13997         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13998         (tdesc_parse_xml): Remove cleanups.
13999         * target-descriptions.h (make_cleanup_free_target_description):
14000         Don't declare.
14001         (target_desc_deleter): New struct.
14002         (target_desc_up): New typedef.
14003         * target-descriptions.c (target_desc_deleter::operator()): Rename
14004         from free_target_description.
14005         (make_cleanup_free_target_description): Remove.
14006
14007 2019-01-02  Tom Tromey  <tom@tromey.com>
14008
14009         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14010         constructor, destructor.
14011         (linespec_parser): Remove typedef.
14012         (~linespec_parser): Rename from linespec_parser_delete.
14013         (linespec_lex_to_end, linespec_complete_label)
14014         (linespec_complete): Update.
14015         (decode_line_full): Remove cleanups.
14016         (decode_line_1): Update.
14017
14018 2019-01-02  Tom Tromey  <tom@tromey.com>
14019
14020         * python/python-internal.h (inferior_to_inferior_object): Change
14021         return type.
14022         * python/py-exitedevent.c (create_exited_event_object): Update.
14023         * python/py-inferior.c (inferior_to_inferior_object): Return
14024         gdbpy_ref.
14025         (python_new_inferior, python_inferior_deleted)
14026         (thread_to_thread_object, delete_thread_object)
14027         (build_inferior_list, gdbpy_selected_inferior): Update.
14028         * python/py-infthread.c (create_thread_object): Update.  Also fail
14029         if inferior_to_inferior_object fails.
14030
14031 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14032
14033         * inferior.h (class inferior) <displaced_step_state>: New field.
14034         * infrun.h (struct displaced_step_state): Move here from
14035         infrun.c.  Initialize fields, add constructor.
14036         <inf>: Remove field.
14037         <reset>: New method.
14038         * infrun.c (struct displaced_step_inferior_state): Move to
14039         infrun.h.
14040         (displaced_step_inferior_states): Remove.
14041         (get_displaced_stepping_state): Adust.
14042         (displaced_step_in_progress_any_inferior): Adjust.
14043         (displaced_step_in_progress_thread): Adjust.
14044         (displaced_step_in_progress): Adjust.
14045         (add_displaced_stepping_state): Remove.
14046         (get_displaced_step_closure_by_addr): Adjust.
14047         (remove_displaced_stepping_state): Remove.
14048         (infrun_inferior_exit): Call displaced_step_state.reset.
14049         (use_displaced_stepping): Don't check for NULL.
14050         (displaced_step_prepare_throw): Call
14051         get_displaced_stepping_state.
14052         (displaced_step_fixup): Don't check for NULL.
14053         (prepare_for_detach): Don't check for NULL.
14054
14055 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14056
14057         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14058          in case of call that did not complete.
14059
14060 2019-01-02  Andrey Utkin  <autkin@undo.io>
14061
14062         * symfile.c (find_separate_debug_file): Fix search of debug files for
14063         remote debuggee.
14064
14065 2019-01-02  Tom Tromey  <tom@tromey.com>
14066
14067         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14068         indentation.
14069         * python/py-frame.c (frapy_older): Remove cast.
14070         (frapy_newer): Likewise.
14071         * python/py-breakpoint.c (local_setattro): Remove cast.
14072         * python/py-arch.c (archpy_name): Remove local variable.
14073         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14074
14075 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14076
14077         * unittests/basic_string_view/element_access/char/empty.cc:
14078         Fix year range in copyright header.
14079
14080 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14081
14082         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14083         Delete.
14084         <operator==>: Update with for removed field.
14085         <hash>: Likewise.
14086         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14087         <isa_features>: ...this.
14088         <abi_features>: New field.
14089         (riscv_isa_flen): Update comment.
14090         (riscv_abi_xlen): New declaration.
14091         (riscv_abi_flen): New declaration.
14092         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14093         isa_features.
14094         (riscv_abi_xlen): New function.
14095         (riscv_isa_flen): Update to get answer from isa_features.
14096         (riscv_abi_flen): New function.
14097         (riscv_has_fp_abi): Update to get answer from abi_features.
14098         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14099         xlen and flen.
14100         (riscv_call_info) <xlen, flen>: Update comment.
14101         (riscv_call_arg_struct): Remove invalid assertions
14102         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14103         is removed.
14104         (riscv_gdbarch_init): Gather isa features and abi features
14105         separately, ensure both match on the gdbarch when reusing an old
14106         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14107         a target with 64-bit float hardware.
14108
14109 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14110
14111         * source.c (search_command_helper): Stop reverse search
14112         when line 1 has been searched.
14113
14114 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14115
14116         * record-full.c (record_full_base_target::close): Rewrite
14117         record_full_core_buf_list free logic.
14118
14119 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14120
14121         * break-catch-syscall.c (print_one_catch_syscall): xfree
14122         the last text.
14123
14124 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14125
14126         * top.c (print_gdb_version): Update Copyright year in version
14127         message.
14128
14129 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14130
14131         Update copyright year range in all GDB files.
14132
14133 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14134
14135         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14136
14137 For older changes see ChangeLog-2018.
14138 \f
14139 Local Variables:
14140 mode: change-log
14141 left-margin: 8
14142 fill-column: 74
14143 version-control: never
14144 coding: utf-8
14145 End:
14146