gdb/ChangeLog

   1 2019-08-06  Tom Tromey  <tromey@adacore.com>
   2
   3         * annotate.c (annotate_source_line): Use g_source_cache.
   4         * source-cache.c (source_cache::get_plain_source_lines): Change
   5         parameters.  Populate m_offset_cache.
   6         (source_cache::ensure): New method.
   7         (source_cache::get_line_charpos): New method.
   8         (extract_lines): Move lower.  Change parameters.
   9         (source_cache::get_source_lines): Move lower.
  10         * source-cache.h (class source_cache): Update comment.
  11         <get_line_charpos>: New method.
  12         <get_source_lines>: Update comment.
  13         <clear>: Clear m_offset_cache.
  14         <get_plain_source_lines>: Change parameters.
  15         <ensure>: New method
  16         <m_offset_cache>: New member.
  17         * source.c (forget_cached_source_info_for_objfile): Update.
  18         (info_source_command): Use g_source_cache.
  19         (find_source_lines, open_source_file_with_line_charpos): Remove.
  20         (print_source_lines_base, search_command_helper): Use g_source_cache.
  21         * source.h (open_source_file_with_line_charpos): Don't declare.
  22         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
  23         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
  24         Use g_source_cache.
  25
  26 2019-08-06  Tom Tromey  <tromey@adacore.com>
  27
  28         * source-cache.c (source_cache::get_plain_source_lines):
  29         Remove "first_line" and "last_line" parameters.
  30         (source_cache::get_source_lines): Cache plain text.
  31         * source-cache.h (class source_cache)
  32         <get_plain_source_lines>: Update.
  33
  34 2019-08-06  Tom Tromey  <tromey@adacore.com>
  35
  36         * source-cache.c (extract_lines): No longer a method.
  37         Changed type of parameter.  Include final newline.
  38         (selftests::extract_lines_test): New function.
  39         (_initialize_source_cache): Likewise.
  40         * source-cache.h (class source_cache)
  41         <extract_lines>: Don't declare.
  42
  43 2019-08-06  Tom Tromey  <tromey@adacore.com>
  44
  45         * breakpoint.c (init_breakpoint_sal): Update.
  46         (breakpoint): Update.
  47         * breakpoint.h (struct breakpoint) <filter>: Now a
  48         unique_xmalloc_ptr.
  49
  50 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  51
  52         * NEWS: Mention dictionary access on blocks.
  53         * python/py-block.c (blpy_getitem): New function.
  54         (block_object_as_mapping): New struct.
  55         (block_object_type): Use new struct for tp_as_mapping field.
  56
  57 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  58
  59         * objfiles.h (objfile): Add a comment describing partial symbols.
  60
  61 2019-08-05  Tom Tromey  <tromey@adacore.com>
  62
  63         * compile/compile.c (_initialize_compile): Use _(), not N_().
  64         * thread.c (_initialize_thread): Use _(), not N_().
  65         * stack.c (_initialize_stack): Use _(), not N_().
  66         * printcmd.c (_initialize_printcmd): Use _(), not N_().
  67
  68 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
  69
  70         * dwarf2read.c (struct dw2_symtab_iterator):
  71         <want_specific_block>: Remove.
  72         <block_index>: Change type to gdb::optional.
  73         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
  74         change type of BLOCK_INDEX parameter to gdb::optional.
  75         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
  76         (dw2_lookup_symbol): Don't pass argument for
  77         WANT_SPECIFIC_BLOCK.
  78         (dw2_expand_symtabs_for_function): Don't pass argument for
  79         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
  80         (class dw2_debug_names_iterator)
  81         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
  82         parameter, change BLOCK_INDEX type to gdb::optional.
  83         <m_want_specific_block>: Remove.
  84         <m_block_index>: Change type to gdb::optional.
  85         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
  86         gdb::optional.  Re-write in function of gdb::optional.
  87         (dw2_debug_names_lookup_symbol): Don't pass argument for
  88         WANT_SPECIFIC_BLOCK.
  89         (dw2_debug_names_expand_symtabs_for_function): Don't pass
  90         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
  91         BLOCK_INDEX.
  92
  93 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  94
  95         * NEWS: Mention changes to "info sources" command.
  96
  97 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  98
  99         * symtab.c (filename_partial_match_opts): New struct type.
 100         (struct output_source_filename_data): New members
 101         regexp, c_regexp, partial_match.
 102         (output_source_filename): Use new members to decide to print file.
 103         (info_sources_option_defs): New variable.
 104         (make_info_sources_options_def_group, print_info_sources_header,
 105         info_sources_command_completer):
 106         New functions.
 107         (info_sources_command): Read new optional arguments.
 108         (_initialize_symtab): Update info sources help.
 109
 110 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 111
 112         * ada-lang.c (exception_support_info_v0): Renamed from...
 113         (default_exception_support_info): ... this.  Create new
 114         definition for v1.
 115         (ada_has_this_exception_support): Look up catch_handlers_sym.
 116         (ada_exception_support_info_sniffer): Try v0 after default.
 117
 118 2019-08-01  Tom Tromey  <tromey@adacore.com>
 119
 120         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 121         gdbarch.h.
 122
 123 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 124
 125         * s12z-tdep.c: Fix include path for s12z-opc.h.
 126
 127 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 128
 129         * NEWS: Require GNU make 3.82.
 130
 131 2019-07-16  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 134         declare.
 135
 136 2019-07-30  Tom Tromey  <tromey@adacore.com>
 137
 138         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 139
 140 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 141
 142         * printcmd.c (print_address_symbolic): Print negative offsets.
 143         (build_address_symbolic): Force signed arithmetic when computing
 144         offset.
 145
 146 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 147
 148         PR/24474: Add a function to lookup static variables.
 149         * NEWS: Mention this new function.
 150         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 151         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 152         * python/python.c (python_GdbMethods): Add new function.
 153
 154 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 155
 156         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 157         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 158         (objfpy_lookup_static_symbol): New function.
 159         (objfile_object_methods): Add new functions.
 160
 161 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 162
 163         * NEWS: Mention 'set|show print frame-info'.  Mention new
 164         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 165         backtrace argument.  Mention that python frame filtering code
 166         is now consistent with what 'backtrace' command prints.
 167
 168 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 169
 170         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 171         comments.
 172         (print_frame_info_auto, print_frame_info_source_line,
 173         print_frame_info_location, print_frame_info_source_and_location,
 174         print_frame_info_location_and_address, print_frame_info_short_location):
 175         New declarations.
 176         (struct frame_print_options): New member print_frame_info.
 177         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 178         * stack.h (get_user_print_what_frame_info): New declaration.
 179         (frame_show_address): New declaration.
 180         * stack.c (print_frame_arguments_choices): New value 'presence'.
 181         (print_frame_info_auto, print_frame_info_source_line,
 182         print_frame_info_location, print_frame_info_source_and_location,
 183         print_frame_info_location_and_address, print_frame_info_short_location,
 184         print_frame_info_choices, print_frame_info_print_what): New definitions.
 185         (print_frame_args): Only print dots for args if print frame-arguments
 186         is 'presence'.
 187         (frame_print_option_defs): New element for "frame-info".
 188         (get_user_print_what_frame_info): New function.
 189         (frame_show_address): Make non static.  Move comment to stack.h.
 190         (print_frame_info_to_print_what): New function.
 191         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 192         to decide what to print.
 193         (backtrace_command_1): Handle the new print_frame_arguments_presence
 194         value.
 195         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 196         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 197         (py_print_frame): In non-mi mode, use LOCATION as default for
 198         print_what, similarly to frame information printed directly by
 199         backtrace command. Handle frame-info user option in non MI mode.
 200
 201 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 202
 203         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 204         Add case for debugging 32-bit target on 64-bit host.  Revise
 205         comment.
 206
 207 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 208
 209         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 210         instead of find_function_entry_range_from_pc.
 211
 212 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 213
 214         * stack.c (find_frame_funname): Remove code which preferred
 215         minsym over symtab sym in "certain pathological cases".
 216
 217         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 218         parameter.  Change type of "do_demangle" to bool.
 219         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 220         Pass suitable "prefer_sym_over_minsym" flag to
 221         build_address_symbolic().  Don't output "+" for negative offsets.
 222         * printcmd.c (print_address_symbolic): Update invocation of
 223         build_address_symbolic to include a "prefer_sym_over_minsym"
 224         flag.
 225         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 226         Restrict cases in which use of minimal symbol is preferred to that
 227         of a found symbol.  Update comments.
 228
 229         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 230         for entry pc when entry pc is out of range for that FDE.
 231
 232 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 233
 234         PR gdb/24839:
 235         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 236         type.
 237
 238 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 239
 240         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 241         this function's Python signature.
 242
 243
 244 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 245
 246         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 247         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 248         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 249         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 250         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 251
 252
 253 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 254
 255         * h8300-tdep.c (h8300_register_name_common): New.
 256         h8300_register_name): Use h8300_register_name_common.
 257         (h8300s_register_name): Likewise.
 258         (h8300sx_register_name): Likewise.
 259         (h8300h_register_nam): New.
 260         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 261
 262
 263 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 264
 265         * arm-tdep.c (arm_skip_cmse_entry): New function.
 266         (arm_is_sgstubs_section): New function.
 267         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 268
 269 2019-07-22  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 272         Don't self-assign.
 273
 274 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 275
 276         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 277         type_print.
 278
 279 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 280
 281         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 282         so that GDB doesn't match any msymbols when searching in the
 283         TYPES_DOMAIN.
 284         (print_symbol_info): Print using typedef_print or type_print based
 285         on the type of the symbol.  Add updated FIXME comment moved from...
 286         (_initialize_symtab): ... move and update FIXME comment to above.
 287
 288 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 289
 290         * NEWS: Mention adding -q option to "info types".
 291         * symtab.c (struct info_types_options): New struct.
 292         (info_types_options_defs): New variable.
 293         (make_info_types_options_def_group): New function.
 294         (info_types_command): Use gdb::option framework to parse options.
 295         (info_types_command_completer): New function.
 296         (_initialize_symtab): Extend the help text on "info types" and
 297         register command completer.
 298
 299 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 300
 301         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 302         (lookup_symbol_in_objfile): Change int to block_enum and add a
 303         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 304
 305 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 306
 307         * MAINTAINERS (Write After Approval): Add self.
 308
 309 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 310
 311         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 312         instruction to the dummy code region.
 313
 314 2019-07-19  Tom Tromey  <tromey@adacore.com>
 315
 316         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 317         (ARGSUSED, PARAMS, __func__): Remove rules.
 318
 319 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 320
 321         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 322         * features/arm/arm-with-iwmmxt.c: Remove.
 323         * features/arm/arm-with-iwmmxt.xml: Remove.
 324         * features/arm/arm-with-m-fpa-layout.c: Remove.
 325         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 326         * features/arm/arm-with-m-vfp-d16.c: Remove.
 327         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 328         * features/arm/arm-with-m.c: Remove.
 329         * features/arm/arm-with-m.xml: Remove.
 330         * features/arm/arm-with-neon.c: Remove.
 331         * features/arm/arm-with-neon.xml: Remove.
 332         * features/arm/arm-with-vfpv2.c: Remove.
 333         * features/arm/arm-with-vfpv2.xml: Remove.
 334         * features/arm/arm-with-vfpv3.c: Remove.
 335         * features/arm/arm-with-vfpv3.xml: Remove.
 336
 337 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 338
 339         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 340
 341 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 342
 343         * arch/aarch32.c (aarch32_create_target_description): Create
 344         target descriptions using features.
 345         * arch/arm.c (arm_create_target_description)
 346         (arm_create_mprofile_target_description): Likewise.
 347         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 348
 349 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 350
 351         * Makefile.in: Add new files.
 352         * aarch32-tdep.c: New file.
 353         * aarch32-tdep.h: New file.
 354         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 355         Call aarch32_read_description.
 356         * arch/aarch32.c: New file.
 357         * arch/aarch32.h: New file.
 358         * arch/arm.c (arm_create_target_description)
 359         (arm_create_mprofile_target_description): New function.
 360         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 361         (arm_create_target_description)
 362         (arm_create_mprofile_target_description): New declaration.
 363         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 364         read_description functions.
 365         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 366         Likewise.
 367         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 368         * arm-tdep.c (tdesc_arm_list): New variable.
 369         (arm_register_g_packet_guesses): Call create description functions.
 370         (arm_read_description) (arm_read_mprofile_description): New
 371         function.
 372         * arm-tdep.h (arm_read_description)
 373         (arm_read_mprofile_description): Add declaration.
 374         * configure.tgt: Add new files.
 375
 376 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 377
 378         * top.c (new_ui_command): Open specified terminal just once.
 379
 380 2019-07-18  Tom Tromey  <tromey@adacore.com>
 381
 382         * symtab.c (main_name): Constify return type.
 383         * symfile.c (set_initial_language): Update.
 384         * symtab.h (main_name): Constify return type.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-winsource.c (tui_update_source_window)
 389         (tui_update_source_window_as_is)
 390         (tui_update_source_windows_with_line): Remove return.
 391         * tui/tui-disasm.c (tui_show_disassem)
 392         (tui_show_disassem_and_update_source): Remove return.
 393         * tui/tui.c (tui_reset): Remove return.
 394         * tui/tui-wingeneral.c
 395         (tui_check_and_display_highlight_if_needed): Remove return.
 396
 397 2019-07-17  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 400
 401 2019-07-17  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-winsource.h (struct tui_exec_info_window)
 404         (struct tui_source_window_base): Move from tui-data.h.
 405         * tui/tui-winsource.c: Move many method definitions from
 406         elsewhere.  Remove "structuring" comments.
 407         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 408         (tui_source_window_base::refresh_window): Move to
 409         tui-winsource.c.
 410         * tui/tui-win.c (tui_source_window_base::refresh_all)
 411         (tui_source_window_base::update_tab_width)
 412         (tui_source_window_base::set_new_height)
 413         (tui_source_window_base::do_make_visible_with_new_height): Move to
 414         tui-winsource.c.
 415         * tui/tui-source.h: Update.
 416         * tui/tui-source.c (tui_source_window_base::reset): Move to
 417         tui-winsource.c.
 418         * tui/tui-disasm.h: Update.
 419         * tui/tui-data.h (struct tui_exec_info_window): Move to
 420         tui-winsource.h.
 421         (struct tui_source_window_base): Likewise.
 422         * tui/tui-data.c (tui_source_window_base::clear_detail)
 423         (tui_source_window_base, ~tui_source_window_base): Move to
 424         tui-winsource.c.
 425
 426 2019-07-17  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-win.c (tui_resize_all)
 429         (tui_source_window_base::update_tab_width)
 430         (tui_adjust_win_heights): Update.
 431         (tui_win_info::make_invisible_and_set_new_height): Rename from
 432         make_invisible_and_set_new_height.
 433         * tui/tui-data.h (struct tui_win_info)
 434         <make_invisible_and_set_new_height>: New method.
 435
 436 2019-07-17  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui.c: Update.
 439         * tui/tui-source.h (struct tui_source_window): Move from
 440         tui-data.h.
 441         * tui/tui-layout.c: Update.
 442         * tui/tui-disasm.c: Update.
 443         * tui/tui-data.h (struct tui_source_window): Move to
 444         tui-source.h.
 445
 446 2019-07-17  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 449         tui-data.h.
 450         * tui/tui-data.h (struct tui_disasm_window): Move to
 451         tui-disasm.h.
 452
 453 2019-07-17  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-regs.h (struct tui_data_item_window): Move from
 456         tui-data.h.
 457         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 458         * tui/tui-data.h (struct tui_data_item_window): Move to
 459         tui-regs.h.
 460         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 461
 462 2019-07-17  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui.c: Update.
 465         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 466         (tui_cmd_window::max_height): Move to tui-command.c.
 467         * tui/tui-layout.c: Update.
 468         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 469         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 470         tui-command.c.
 471         * tui/tui-command.h (struct tui_cmd_window): Move from
 472         tui-data.h.
 473         * tui/tui-command.c: Remove "structuring" comments.
 474         (tui_cmd_window::clear_detail)
 475         (tui_cmd_window::do_make_visible_with_new_height)
 476         (tui_cmd_window::max_height): Move from elsewhere.
 477
 478 2019-07-17  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 481         Now static.
 482         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 483         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 484
 485 2019-07-17  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui.c: Update.
 488         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 489         tui-regs.c.
 490         * tui/tui-windata.h: Remove file.
 491         * tui/tui-windata.c: Remove file.
 492         * tui/tui-win.c (tui_data_window::set_new_height)
 493         (tui_data_window::do_make_visible_with_new_height): Move to
 494         tui-regs.c.
 495         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 496         * tui/tui-regs.c: Remove "structuring" comments.
 497         (tui_data_window::first_data_item_displayed)
 498         (tui_data_window::delete_data_content_windows)
 499         (tui_data_window::erase_data_content)
 500         (tui_data_window::display_all_data)
 501         (tui_data_window::refresh_all)
 502         (tui_data_window::do_scroll_vertical)
 503         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 504         (tui_data_window::do_make_visible_with_new_height)
 505         (tui_data_window::refresh_window): Move from elsewhere.
 506         (_initialize_tui_regs): Move to end of file.
 507         * tui/tui-layout.c: Update.
 508         * tui/tui-hooks.c: Update.
 509         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 510         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 511         tui-regs.c.
 512         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 513
 514 2019-07-17  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 517         seen.
 518
 519 2019-07-17  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-win.c (tui_source_window_base::set_new_height)
 522         (tui_source_window_base::do_make_visible_with_new_height): Use
 523         m_has_locator field directly.
 524         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 525         method.
 526         (struct tui_source_window_base) <has_locator>: Likewise.
 527
 528 2019-07-17  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 531         Don't declare.
 532         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 533         Remove.
 534         * tui/tui-win.c (tui_source_window_base::set_new_height)
 535         (tui_source_window_base::set_new_height)
 536         (make_invisible_and_set_new_height)
 537         (tui_source_window_base::do_make_visible_with_new_height)
 538         (tui_source_window_base::do_make_visible_with_new_height):
 539         Update.
 540         * tui/tui-layout.c (show_source_disasm_command, show_data)
 541         (show_source_or_disasm_and_command): Update.
 542         * tui/tui-layout.c (show_layout): Update.
 543
 544 2019-07-17  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-layout.c (make_data_window): Remove.
 547         (show_data): Unify creation and re-initialization cases.
 548
 549 2019-07-17  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui-layout.c (make_source_window, make_disasm_window):
 552         Remove.
 553         (show_data): Unify creation and re-initialization cases.
 554
 555 2019-07-17  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-layout.c (make_command_window): Remove.
 558         (show_source_disasm_command, show_source_or_disasm_and_command):
 559         Unify creation and re-initialization cases.
 560
 561 2019-07-17  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 564         creation and re-initialization cases.
 565
 566 2019-07-17  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-regs.c (tui_get_register): Return void.
 569
 570 2019-07-17  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 573         Simplify.
 574
 575 2019-07-17  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 578         resetting.
 579
 580 2019-07-17  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 583         * tui/tui-regs.c (tui_reg_layout): New function.
 584         (tui_show_registers, tui_reg_command): Use it.
 585         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 586         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 587         parameters.
 588         (tui_layout_command): Remove.
 589
 590 2019-07-17  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-layout.h (tui/tui-layout): Return void.
 593         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 594
 595 2019-07-17  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-layout.c (show_source_disasm_command, show_data):
 598         Update.
 599         (reset_locator): Remove.
 600         (show_source_or_disasm_and_command): Update.
 601
 602 2019-07-17  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-source.c (tui_source_window_base::reset): Remove
 605         win_type parameter.
 606         * tui/tui-layout.c (make_command_window, make_source_window)
 607         (make_disasm_window, make_data_window)
 608         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 609         (reset_locator, show_source_or_disasm_and_command): Update.
 610         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 611         win_type parameter.
 612         (struct tui_source_window_base) <reset>: Likewise.
 613
 614 2019-07-17  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-layout.c (show_source_disasm_command): Use
 617         reset_locator.
 618         (reset_locator): New function.
 619         (init_and_make_win): Remove.
 620         (show_source_or_disasm_and_command): Use reset_locator.
 621
 622 2019-07-17  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 625         condition.
 626         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 627         Remove condition.
 628         * tui/tui-source.c (tui_source_window_base::reset): New method.
 629         * tui/tui-layout.c (make_command_window): Don't call
 630         init_and_make_win.
 631         (make_source_window, make_disasm_window): Don't call
 632         make_source_or_disasm_window.
 633         (make_data_window): Don't call init_and_make_win.  Change calling
 634         convention.
 635         (show_source_disasm_command, show_data): Simplify.
 636         (make_source_or_disasm_window): Remove.
 637         (show_source_or_disasm_and_command): Simplify.
 638         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 639         (struct tui_source_window_base) <reset>: Likewise.
 640         <execution_info>: Remove initializer.
 641         * tui/tui-data.c (tui_source_window_base): Initialize
 642         execution_info.
 643
 644 2019-07-17  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 647         variable.
 648
 649 2019-07-17  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui.c (tui_rl_other_window): Update.
 652         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 653         superclass method first.  Always iterate over regs_content.
 654         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 655         method.
 656         * tui/tui-win.c (tui_set_focus_command): Update.
 657
 658 2019-07-17  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-win.c (tui_set_focus_command): Rename from
 661         tui_set_focus.  Call tui_enable.
 662         (tui_set_focus_command): Remove.
 663
 664 2019-07-17  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 667         refresh_window.
 668         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 669         touchwin.
 670         (tui_data_window::refresh_window): Call refresh_window on data
 671         items.  Always call superclass refresh_window.
 672         (tui_win_info::refresh): Remove.
 673         (tui_source_window_base::refresh_window): Update.
 674         (tui_refresh_all): Update.
 675         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 676         refresh_window.
 677         (show_source_or_disasm_and_command): Likewise.
 678         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 679         (struct tui_source_window_base) <refresh>: Likewise.
 680
 681 2019-07-17  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-winsource.c (tui_clear_source_content)
 684         (tui_show_source_content): Update.
 685         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 686         whether content is empty.
 687         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 688         Remove.
 689
 690 2019-07-17  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 693         window's contents.
 694         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 695         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 696
 697 2019-07-17  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 700         (struct tui_data_item_window): Update.
 701
 702 2019-07-17  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 705         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 706         defines.
 707
 708 2019-07-17  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-winsource.h (tui_erase_source_content)
 711         (tui_clear_source_content): Remove "display_prompt" parameter.
 712         * tui/tui-winsource.c (tui_update_source_window_as_is)
 713         (tui_update_source_windows_with_addr): Update.
 714         (tui_clear_source_content): Remove "display_prompt" parameter.
 715         (tui_erase_source_content): Likewise.  Simplify.
 716         (tui_show_source_content): Update.
 717         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 718         * tui/tui-stack.c (tui_show_frame_info): Update.
 719         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 720         Remove defines.
 721
 722 2019-07-17  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 725         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 726         parameter.
 727         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 728         parameter.
 729
 730 2019-07-17  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-winsource.c (tui_clear_source_content)
 733         (tui_show_source_content, tui_show_exec_info_content)
 734         (tui_clear_exec_info_content): Update.
 735         * tui/tui-stack.c (tui_show_locator_content): Update.
 736         (tui_show_frame_info): Update.
 737         * tui/tui-source.h (tui_source_window): Don't declare.
 738         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 739         from tui_source_is_displayed.
 740         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 741         Remove field.
 742         (struct tui_source_window_base) <content_in_use>: New field.  Now
 743         bool.
 744         (struct tui_source_window) <showing_source_p>: New method.
 745         (TUI_SRC_WIN): Change cast.
 746         * tui/tui-data.c (tui_initialize_static_data): Update.
 747
 748 2019-07-17  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 751         location_matches_p.
 752         * tui/tui-source.c (tui_source_window::location_matches_p): New
 753         method.
 754         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 755         method.
 756         * tui/tui-data.h (struct tui_source_window_base)
 757         <location_matches_p>: New method.
 758         (struct tui_source_window, struct tui_disasm_window)
 759         <location_matches_p>: Likewise.
 760
 761 2019-07-17  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-win.c (tui_set_win_height_command): Rename from
 764         tui_set_win_height.
 765         (tui_set_win_height_command): Remove.
 766
 767 2019-07-17  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-source.c (tui_source_window): New constructor.  Add
 770         observer.
 771         (~tui_source_window): New destructor.
 772         (tui_source_window::style_changed): New method.
 773         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 774         (tui_attach_detach_observers): Update.
 775         * tui/tui-data.h (struct tui_source_window): Make constructor not
 776         inline.  Add destructor.
 777         (struct tui_source_window) <style_changed>: New method.
 778         <m_observable>: New member.
 779
 780 2019-07-17  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 783         * tui/tui-win.c (tui_resize_all): Fix typo.
 784
 785 2019-07-17  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 788         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 789         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 790         * tui/tui-win.c (window_name_completer): Use foreach.
 791         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 792         (update_tab_width): Likewise.
 793         * tui/tui-layout.c (show_layout): Update.
 794         * tui/tui-data.h (class tui_window_iterator): New.
 795         (struct all_tui_windows): New.
 796         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 797
 798 2019-07-17  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 801         parameter.  Don't reference globals.
 802         (tui_reg_command): Update.
 803
 804 2019-07-17  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-regs.c (tui_show_registers): Simplify.
 807
 808 2019-07-17  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-regs.c (tui_show_registers): Update.
 811         (tui_show_register_group): Add win_info parameter.
 812
 813 2019-07-17  Tom Tromey  <tom@tromey.com>
 814
 815         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 816         Rename from tui_display_reg_element_at_line.
 817         (tui_data_window::display_registers_from_line): Update.
 818         * tui/tui-data.h (struct tui_data_window)
 819         <display_reg_element_at_line>: New method.
 820
 821 2019-07-17  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-regs.h (tui_display_registers_from)
 824         (tui_display_registers_from_line): Don't declare.
 825         * tui/tui-windata.c (tui_data_window::display_all_data)
 826         (tui_data_window::refresh_all)
 827         (tui_data_window::do_scroll_vertical): Update.
 828         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 829         from tui_display_registers_from.
 830         (tui_display_reg_element_at_line): Update.
 831         (tui_data_window::display_registers_from_line): Rename from
 832         tui_display_registers_from_line.
 833         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 834         display_registers_from_line>: New methods.
 835
 836 2019-07-17  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 839         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 840         from tui_erase_data_content.
 841         (tui_data_window::display_all_data)
 842         (tui_data_window::refresh_all)
 843         (tui_data_window::do_scroll_vertical): Update.
 844         * tui/tui-regs.c (tui_show_registers): Update.
 845         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 846         New method.
 847
 848 2019-07-17  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 851         declare.
 852         * tui/tui-windata.c
 853         (tui_data_window::delete_data_content_windows): Rename from
 854         tui_delete_data_content_windows.
 855         (tui_data_window::display_all_data)
 856         (tui_data_window::do_scroll_vertical): Update.
 857         * tui/tui-data.h (struct tui_data_window)
 858         <delete_data_content_windows>: New method.
 859
 860 2019-07-17  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 863         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 864
 865 2019-07-17  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 868         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 869         from tui_display_all_data.
 870         * tui/tui-win.c
 871         (tui_data_window::do_make_visible_with_new_height): Update.
 872         * tui/tui-regs.c (tui_show_registers): Update.
 873         * tui/tui-layout.c (tui_set_layout): Update.
 874         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 875         method.
 876
 877 2019-07-17  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 880         * tui/tui-windata.c (tui_display_data_from): Remove.
 881         (tui_data_window::refresh_all): Update.
 882
 883 2019-07-17  Tom Tromey  <tom@tromey.com>
 884
 885         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 886         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 887         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 888         tui_display_registers_from_line.
 889         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 890         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 891         "force_display" parameter.
 892
 893 2019-07-17  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 896         declare.
 897         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 898         Rename from tui_first_reg_element_no_inline.
 899         (tui_display_reg_element_at_line)
 900         (tui_display_registers_from_line): Update.
 901         * tui/tui-data.h (struct tui_data_window)
 902         <first_reg_element_no_inline>: New method.
 903
 904 2019-07-17  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-windata.c (tui_display_data_from)
 907         (tui_data_window::do_scroll_vertical): Update.
 908         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 909         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 910         Rename from tui_line_from_reg_element_no.
 911         (tui_display_registers_from_line): Update.
 912         * tui/tui-data.h (struct tui_data_window)
 913         <line_from_reg_element_no>: New method.
 914
 915 2019-07-17  Tom Tromey  <tom@tromey.com>
 916
 917         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 918         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 919         tui_last_regs_line_no.
 920         (tui_display_reg_element_at_line)
 921         (tui_display_registers_from_line): Update.
 922         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 923         method.
 924
 925 2019-07-17  Tom Tromey  <tom@tromey.com>
 926
 927         PR tui/24722:
 928         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 929         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 930         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 931         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 932         (tui_update_breakpoint_info): Likewise.
 933         * tui/tui-hooks.c (tui_event_create_breakpoint)
 934         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 935         Update.
 936
 937 2019-07-17  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 940
 941 2019-07-17  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-winsource.c (tui_update_source_window_as_is)
 944         (tui_update_source_windows_with_addr): Update.
 945         * tui/tui-source.h (tui_set_source_content)
 946         (tui_show_symtab_source): Add "win_info" parameter.
 947         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 948         parameter.
 949         (tui_show_symtab_source): Likewise.
 950
 951 2019-07-17  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-wingeneral.c
 954         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 955
 956 2019-07-17  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 959         (struct tui_cmd_window) <can_scroll>: New method.
 960         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 961         method.
 962
 963 2019-07-17  Tom Tromey  <tromey@adacore.com>
 964
 965         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 966         do_field_signed>: Rename.  Change type of "value".
 967         * ui-out.c (ui_out::field_signed): Rename from field_int.
 968         Change type of "value".
 969         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 970         type of "value".
 971         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 972         do_field_int.  Change type of "value".
 973         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 974         do_field_int.  Change type of "value".
 975         * tracepoint.c (trace_status_mi, tfind_1)
 976         (print_one_static_tracepoint_marker): Update.
 977         * thread.c (print_thread_info_1, print_selected_thread_frame):
 978         Update.
 979         * stack.c (print_frame, print_frame_info): Update.
 980         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 981         Update.
 982         * source.c (print_source_lines_base): Update.
 983         * skip.c (info_skip_command): Update.
 984         * record-btrace.c (btrace_ui_out_decode_error)
 985         (btrace_call_history_src_line): Update.
 986         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 987         Update.
 988         * progspace.c (print_program_space): Update.
 989         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 990         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 991         do_field_int.  Change type of "value".
 992         * mi/mi-out.c (mi_ui_out::do_table_begin)
 993         (mi_ui_out::do_table_header): Update.
 994         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 995         type of "value".
 996         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 997         (mi_cmd_data_list_changed_registers, output_register)
 998         (mi_cmd_data_read_memory, mi_load_progress)
 999         (mi_cmd_trace_frame_collected): Update.
1000         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1001         Update.
1002         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1003         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1004         (mi_cmd_var_list_children, varobj_update_one): Update.
1005         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1006         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1007         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1008         * inferior.c (print_inferior): Update.
1009         * gdb_bfd.c (print_one_bfd): Update.
1010         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1011         Update.
1012         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1013         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1014         do_field_int.  Change type of "value".
1015         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1016         do_field_int.  Change type of "value".
1017         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1018         (print_one_breakpoint_location, print_it_catch_fork)
1019         (print_one_catch_fork, print_it_catch_vfork)
1020         (print_one_catch_vfork, print_it_catch_solib)
1021         (print_it_catch_exec, print_it_ranged_breakpoint)
1022         (print_mention_watchpoint, print_mention_masked_watchpoint)
1023         (bkpt_print_it, update_static_tracepoint): Update.
1024         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1025         * break-catch-syscall.c (print_it_catch_syscall): Update.
1026         * ada-tasks.c (print_ada_task_info): Update.
1027         * ada-lang.c (print_it_exception, print_mention_exception):
1028         Update.
1029
1030 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1031
1032         PR breakpoints/24541
1033         * gdbarch.c: Regenerate.
1034         * gdbarch.h: Regenerate.
1035         * gdbarch.sh: Adjust return type and parameter types for
1036         'stap_adjust_register'.
1037         (i386_stap_adjust_register): Adjust signature and return new
1038         register name.
1039         * stap-probe.c (stap_parse_register_operand): Adjust use of
1040         'gdbarch_stap_adjust_register'.
1041
1042 2019-07-17  Tom Tromey  <tromey@adacore.com>
1043
1044         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1045         declare VEC.
1046         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1047         std::vector.
1048         (struct s390_process_info): Add initializers.
1049         (s390_add_process): Use new.
1050         (s390_linux_nat_target::low_forget_process): Use delete.
1051         (s390_linux_nat_target::low_new_fork)
1052         (s390_linux_nat_target::stopped_by_watchpoint)
1053         (s390_linux_nat_target::low_prepare_to_resume)
1054         (s390_linux_nat_target::insert_watchpoint)
1055         (s390_linux_nat_target::insert_hw_breakpoint)
1056         (s390_linux_nat_target::remove_watchpoint)
1057         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1058
1059 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1060
1061         * aarch64-fbsd-nat.c: Include regcache.h.
1062         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1063         argument.
1064         (aarch64_fbsd_nat_target::fetch_registers)
1065         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1066         variable.
1067         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1068
1069 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1070
1071         * fbsd-nat.c: Include gdbarch.h.
1072
1073 2019-07-15  Tom Tromey  <tromey@adacore.com>
1074
1075         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1076
1077 2019-07-15  Tom Tromey  <tromey@adacore.com>
1078
1079         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1080         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1081         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1082         * cli-out.c (cli_ui_out::do_field_int): New method.
1083         * ui-out.c (ui_out::field_unsigned): New method.
1084         * symfile.c (generic_load): Use field_unsigned.
1085         (print_transfer_performance): Likewise.
1086         * record-btrace.c (ui_out_field_uint): Remove.
1087         (btrace_call_history_insn_range, btrace_call_history): Use
1088         field_unsigned.
1089         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1090         field_unsigned.
1091         * ui-out.h (class ui_out) <field_unsigned>: New method.
1092         <do_field_unsigned>: Likewise.
1093
1094 2019-07-15  Tom Tromey  <tromey@adacore.com>
1095
1096         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1097         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1098         * target.c (flash_erase_command): Use field_string.
1099         * infrun.c (print_signal_received_reason): Use field_string.
1100         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1101         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1102         field_string.
1103         * ada-tasks.c (print_ada_task_info): Use field_string.
1104
1105 2019-07-15  Tom Tromey  <tromey@adacore.com>
1106
1107         * target.c (flash_erase_command): Use field_core_addr.
1108         * symfile.c (generic_load): Use field_core_addr.
1109         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1110         Use field_core_addr.
1111         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1112         field_core_addr.
1113
1114 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1115
1116         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1117         value if its desired type is smaller than a CORE_ADDR and signed.
1118
1119 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1122         of changes to field names, and use new is_reference field to
1123         decide if a property is a reference or not.
1124         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1125         field.
1126         (struct dwarf2_property_baton): Update header comment, rename
1127         'referenced_type' to 'property_type' and update comments.
1128         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1129         default property type, store in property baton, update to take
1130         accound of renamed field.
1131         (read_func_scope): Update call to attr_to_dynamic_prop.
1132         (read_array_type): Likewise.
1133         (dwarf2_per_cu_addr_sized_int_type): New function.
1134         (read_subrange_index_type): Move type finding code to
1135         dwarf2_per_cu_addr_sized_int_type.
1136         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1137         (dwarf2_per_cu_addr_type): New function.
1138         (set_die_type): Update calls to attr_to_dynamic_prop.
1139
1140 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         * dwarf2read.c (read_subrange_index_type): New function.
1143         (read_subrange_type): Move code into new function and call it.
1144         * gdbtypes.c (create_range_type): Add some asserts.
1145
1146 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1149         update return statements.
1150         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1151         declaration, and update comment to match.
1152         * gdbtypes.c (resolve_dynamic_array): Update call to
1153         dwarf2_evaluate_property to match new return type.
1154
1155 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1156
1157         * valarith.c (value_subscripted_rvalue): Change lowerbound
1158         parameter type from int to LONGEST.
1159         * value.h (value_subscripted_rvalue): Likewise in declaration.
1160
1161 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * cli/cli-utils.c (info_print_command_completer): New function.
1164         * cli/cli-utils.h: Add 'completer.h' include, and forward
1165         declaration for 'struct cmd_list_element'.
1166         (info_print_command_completer): Declare.
1167         * stack.c (_initialize_stack): Add completer for 'info locals' and
1168         'info args'.
1169         * symtab.c (_initialize_symtab): Add completer for 'info
1170         variables' and 'info functions'.
1171         * NEWS: Mention completion for additional info commands.
1172
1173 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * cli/cli-utils.c (extract_info_print_args): Delete.
1176         (extract_arg_maybe_quoted): Delete.
1177         (info_print_options_defs): New variable.
1178         (make_info_print_options_def_group): New function.
1179         (extract_info_print_options): Define new function.
1180         * cli/cli-utils.h (extract_info_print_args): Delete.
1181         (struct info_print_options): New structure.
1182         (extract_info_print_options): Declare new function.
1183         * stack.c (info_locals_command): Update to use new
1184         extract_info_print_options, also add a header comment.
1185         (info_args_command): Likewise.
1186         * symtab.c (info_variables_command): Likewise.
1187         (info_functions_command): Likewise.
1188
1189 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1192         to extract string arguments.
1193         * common/common-utils.c (extract_string_maybe_quoted): New function.
1194         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1195
1196 2019-07-11  Tom Tromey  <tromey@adacore.com>
1197
1198         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1199         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1200         * top.h (gdbinit): Don't declare.
1201         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1202         into...
1203         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1204         * top.c (gdb_init): Don't call init_cli_cmds.
1205         (gdbinit): Remove.
1206         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1207
1208 2019-07-11  Tom Tromey  <tromey@adacore.com>
1209
1210         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1211         after it has been moved.
1212
1213 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1214
1215         * valops.c (value_must_coerce_to_target): Change return type to
1216         bool.
1217         * value.h (value_must_coerce_to_target): Likewise.
1218
1219 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1220
1221         * breakpoint.c (is_hardware_watchpoint): Remove
1222         forward-declaration.
1223         (is_masked_watchpoint): Change return type to bool.
1224         (is_tracepoint): Likewise.
1225         (is_breakpoint): Likewise.
1226         (is_hardware_watchpoint): Likewise.
1227         (is_watchpoint): Likewise.
1228         (is_no_memory_software_watchpoint): Likewise.
1229         (is_catchpoint): Likewise.
1230         (breakpoint_1): Make FILTER parameter's return type bool.
1231         is_masked_watchpoint): Change return type to bool.
1232         (save_breakpoints): Make FILTER parameter's return type bool.
1233         * breakpoint.h (is_breakpoint): Change return type to bool.
1234         (is_watchpoint): Likewise.
1235         (is_catchpoint): Likewise.
1236         (is_tracepoint): Likewise.
1237
1238 2019-07-10  Tom Tromey  <tom@tromey.com>
1239
1240         * defs.h: Don't include gdbarch.h.
1241         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1242         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1243         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1244         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1245         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1246         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1247         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1248         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1249         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1250         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1251         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1252         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1253         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1254         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1255         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1256         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1257         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1258         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1259         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1260         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1261         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1262         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1263         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1264         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1265         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1266         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1267         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1268
1269 2019-07-10  Tom Tromey  <tromey@adacore.com>
1270
1271         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1272         * breakpoint.c (init_ada_exception_breakpoint): Register as
1273         bp_catchpoint.
1274         (print_one_breakpoint_location, print_one_breakpoint): Use
1275         is_ada_exception_catchpoint.
1276         * ada-lang.c (class ada_catchpoint_location): Pass
1277         bp_loc_software_breakpoint to bp_location constructor.
1278         (is_ada_exception_catchpoint): New function.
1279
1280 2019-07-10  Tom Tromey  <tromey@adacore.com>
1281
1282         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1283         VEC.
1284         (struct arm_exidx_entry): New method operator<.
1285         (struct arm_exidx_data) <section_maps>: Change type.
1286         (arm_exidx_data_free): Remove.
1287         (arm_exidx_data_key): Change type.  Move lower.
1288         (arm_exidx_new_objfile): Update.
1289         (arm_compare_exidx_entries): Remove.
1290         (arm_find_exidx_entry, _initialize_arm_tdep)
1291
1292 2019-07-10  Tom Tromey  <tromey@adacore.com>
1293
1294         * solib-spu.c (ocl_program_data_key): Change type.
1295         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1296         Update.
1297
1298 2019-07-10  Tom Tromey  <tromey@adacore.com>
1299
1300         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1301         (struct solib_aix_inferior_data) <library_list>: Change type.
1302         (solib_aix_inferior_data_handle): Change type.
1303         (get_solib_aix_inferior_data): Update.
1304         (solib_aix_free_library_list): Remove.
1305         (library_list_start_library): Update.
1306         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1307         return type.
1308         (solib_aix_get_library_list)
1309         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1310         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1311
1312 2019-07-10  Tom Tromey  <tromey@adacore.com>
1313
1314         * solib-dsbt.c (struct dsbt_info): Add initializers.
1315         (solib_dsbt_pspace_data): Change type.
1316         (dsbt_pspace_data_cleanup): Remove.
1317         (get_dsbt_info, _initialize_dsbt_solib): Update.
1318
1319 2019-07-10  Tom Tromey  <tromey@adacore.com>
1320
1321         * spu-tdep.c (spu_overlay_data): Change type.
1322         (spu_get_overlay_table, spu_overlay_new_objfile)
1323         (_initialize_spu_tdep): Update.
1324
1325 2019-07-10  Tom Tromey  <tromey@adacore.com>
1326
1327         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1328         destructor.
1329         (dbx_objfile_data_key): Change type and declare later.
1330         (DBX_SYMFILE_INFO): Rewrite.
1331         * dbxread.c (dbx_objfile_data_key): Change type.
1332         (dbx_symfile_init): Update.
1333         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1334         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1335         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1336
1337 2019-07-10  Tom Tromey  <tromey@adacore.com>
1338
1339         * jit.c (jit_program_space_key): Change type.  Move lower.
1340         (get_jit_program_space_data): Update.
1341         (jit_program_space_data_cleanup): Remove.
1342         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1343         Update.
1344         (struct jit_program_space_data): Add initializers.
1345
1346 2019-07-10  Tom Tromey  <tromey@adacore.com>
1347
1348         * solib-darwin.c (struct darwin_info): Add initializers.
1349         (solib_darwin_pspace_data): Change type.
1350         (darwin_pspace_data_cleanup): Remove.
1351         (get_darwin_info, _initialize_darwin_solib): Update.
1352
1353 2019-07-10  Tom Tromey  <tromey@adacore.com>
1354
1355         * remote-sim.c (struct sim_inferior_data): Add initializers,
1356         constructor, and destructor.
1357         (sim_inferior_data_key): Change type.  Move lower.
1358         (check_for_duplicate_sim_descriptor): Update.
1359         (get_sim_inferior_data): Use new.  Update.
1360         (~sim_inferior_data_cleanup): Rename from
1361         sim_inferior_data_cleanup.  Simplify.
1362         (gdbsim_close_inferior, simulator_command)
1363         (sim_command_completer, _initialize_remote_sim): Update.
1364         (next_pid, INITIAL_PID): Move earlier.
1365
1366 2019-07-10  Tom Tromey  <tromey@adacore.com>
1367
1368         * python/python-internal.h (create_thread_object): Return
1369         gdbpy_ref.
1370         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1371         * python/py-inferior.c (struct threadlist_entry): Add
1372         constructor.
1373         <thread_obj>: Now a gdbpy_ref.
1374         (thread_to_thread_object): Update.
1375         (add_thread_object): Use new.
1376         (delete_thread_object): Use delete.
1377         (infpy_threads): Update.
1378         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1379         GIL.
1380
1381 2019-07-10  Tom Tromey  <tromey@adacore.com>
1382
1383         * valops.c (value_cast): Specialize error message for Ada.
1384
1385 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1386
1387         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1388
1389 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1390
1391         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1392         bpstat_should_step): Return bool, adjust comments.
1393         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1394         bpstat_should_step): Likewise.
1395
1396 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1397
1398         * features/Makefile: Use feature target descriptions for Arm.
1399         * features/arm/arm-core.c: Generate new file.
1400         * features/arm/arm-fpa.c: Likewise.
1401         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1402         * features/arm/arm-m-profile.c: Likewise.
1403         * features/arm/arm-vfpv2.c: Likewise.
1404         * features/arm/arm-vfpv3.c: Likewise.
1405         * features/arm/xscale-iwmmxt.c: Likewise.
1406         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1407
1408 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1409
1410         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1411         ptrace earlier.
1412
1413 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1414
1415         * features/aarch64-pauth.c: Regenerate.
1416
1417 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1418
1419         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1420         bool.
1421         (bpstat_what): Use false instead of 0.
1422
1423 2019-07-09  Pedro Alves  <palves@redhat.com>
1424
1425         * break-catch-throw.c (is_exception_catchpoint): New.
1426         * breakpoint.c (print_one_breakpoint_location): New parameter
1427         'raw_loc'.  Handle it.  Use
1428         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1429         looking at the breakpoint's type.
1430         (print_one_breakpoint): If handling "maint info breakpoints", also
1431         print locations of exception catchpoints.
1432         * breakpoint.h (is_exception_catchpoint): Declare.
1433
1434 2019-07-09  Pedro Alves  <palves@redhat.com>
1435
1436         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1437         "addr" field.
1438         (allocate_location_exception_catchpoint): New.
1439         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1440         (initialize_throw_catchpoint_ops): Install
1441         allocate_location_exception_catchpoint as allocate_location
1442         method.
1443         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1444         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1445         bp_loc_other.
1446         (breakpoint_address_is_meaningful): Delete.
1447         (bl_address_is_meaningful): New.
1448         (breakpoint_locations_match): Adjust comment.
1449         (bp_location_from_bp_type): New, factored out of...
1450         (bp_location::bp_location(breakpoint *)): ... this.
1451         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1452         factored out of...
1453         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1454         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1455         breakpoint_address_is_meaningful.
1456         (bp_locations_compare): Adjust comment.
1457         (update_global_location_list): Use bl_address_is_meaningful
1458         instead of breakpoint_address_is_meaningful.
1459         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1460         explicit.
1461         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1462         * python/py-breakpoint.c (bppy_get_location): No longer check
1463         whether location is null.
1464
1465 2019-07-09  Pedro Alves  <palves@redhat.com>
1466
1467         PR c++/15468
1468         * breakpoint.c (print_one_breakpoint_location): Remove
1469         single-location assert.
1470
1471 2019-07-09  Tom Tromey  <tom@tromey.com>
1472
1473         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1474         * configure: Rebuild.
1475         * configure.ac: Change common to gdbsupport.
1476         * gdbsupport: Rename from common.
1477         * acinclude.m4: Change common to gdbsupport.
1478         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1479         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1480         gdbsupport.
1481         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1482         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1483         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1484         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1485         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1486         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1487         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1488         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1489         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1490         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1491         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1492         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1493         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1494         coff-pe-read.c, command.h, compile/compile-c-support.c,
1495         compile/compile-c.h, compile/compile-cplus-symbols.c,
1496         compile/compile-cplus-types.c, compile/compile-cplus.h,
1497         compile/compile-loc2c.c, compile/compile.c, completer.c,
1498         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1499         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1500         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1501         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1502         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1503         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1504         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1505         features/aarch64-core.c, features/aarch64-fpu.c,
1506         features/aarch64-pauth.c, features/aarch64-sve.c,
1507         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1508         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1509         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1510         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1511         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1512         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1513         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1514         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1515         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1516         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1517         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1518         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1519         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1520         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1521         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1522         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1523         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1524         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1525         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1526         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1527         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1528         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1529         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1530         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1531         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1532         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1533         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1534         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1535         minsyms.c, mips-linux-tdep.c, namespace.h,
1536         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1537         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1538         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1539         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1540         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1541         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1542         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1543         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1544         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1545         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1546         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1547         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1548         procfs.c, producer.c, progspace.h, psymtab.h,
1549         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1550         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1551         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1552         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1553         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1554         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1555         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1556         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1557         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1558         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1559         target-memory.c, target.c, target.h, target/waitstatus.c,
1560         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1561         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1562         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1563         unittests/array-view-selftests.c,
1564         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1565         unittests/common-utils-selftests.c,
1566         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1567         unittests/format_pieces-selftests.c,
1568         unittests/function-view-selftests.c,
1569         unittests/lookup_name_info-selftests.c,
1570         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1571         unittests/mkdir-recursive-selftests.c,
1572         unittests/observable-selftests.c,
1573         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1574         unittests/parse-connection-spec-selftests.c,
1575         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1576         unittests/scoped_fd-selftests.c,
1577         unittests/scoped_mmap-selftests.c,
1578         unittests/scoped_restore-selftests.c,
1579         unittests/string_view-selftests.c, unittests/style-selftests.c,
1580         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1581         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1582         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1583         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1584         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1585         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1586
1587 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1588
1589         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1590         bool value.
1591         (decode_digits_ordinary): Set explicit_line field in sal.
1592         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1593         symtab_and_line that was set on an explicit line number in
1594         assembler code.  Do always update the recorded symtab and line if
1595         we do skip the prologue.
1596
1597 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1598
1599         * breakpoint.c (set_breakpoint_location_function): Remove
1600         explicit_loc parameter.
1601         (momentary_breakpoint_from_master): Update call to
1602         set_breakpoint_location_function.
1603         (add_location_to_breakpoint): Likewise.
1604
1605 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1608         required features based on default bfd type when no specific bfd
1609         is present.
1610
1611 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1612
1613         * NEWS: Mention that GDB printf and eval commands can now print
1614         C-style and Ada-style convenience var strings without
1615         calling the inferior.
1616         * printcmd.c (printf_c_string): Locally print GDB internal var
1617         instead of transiting via the inferior.
1618         (printf_wide_c_string): Likewise.
1619
1620 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1621
1622         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1623
1624 2019-07-04  Tom Tromey  <tom@tromey.com>
1625
1626         PR tui/24724:
1627         * tui/tui-winsource.c (tui_clear_source_content): Update.
1628         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1629         (tui_update_breakpoint_info): Update.
1630         (tui_set_exec_info_content): Update.
1631         * tui/tui-source.c (tui_set_source_content_nil): Update.
1632         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1633         has_break.
1634         * tui/tui-data.h (enum tui_bp_flag): New.
1635         (tui_bp_flags): New enum flags type.
1636         (struct tui_source_element) <break_mode>: Change type.  Rename
1637         from has_break.
1638         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1639         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1640         constants.
1641         * tui/tui-winsource.h: Fix comment.
1642
1643 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1644
1645         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1646         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1647         (store_fpregs_to_thread)
1648         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1649         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1650         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1651         (IWMMXT_REGS_SIZE): Add define.
1652         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1653         (fetch_vfp_regs, store_vfp_regs)
1654         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1655         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1656
1657 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1658
1659         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1660         defines.
1661         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1662         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1663         (ARM_INT_REGISTER_SIZE): ...to this.
1664         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1665         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1666         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1667         (arm_linux_collect_gregset, supply_nwfpe_register)
1668         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1669         defines.
1670         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1671         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1672         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1673         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1674         (arm_return_in_memory, arm_store_return_value)
1675         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1676         (arm_record_ld_st_multiple): Likewise.
1677         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1678         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1679
1680 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1681
1682         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1683         AARCH64_DISPLACED_MODIFIED_INSNS.
1684         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1685         (aarch64_displaced_step_copy_insn): Likewise.
1686         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1687         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1688         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1689         ARM_DISPLACED_MODIFIED_INSNS.
1690         * arm-tdep.c (arm_gdbarch_init): Likewise.
1691         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1692         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1693         (struct arm_displaced_step_closure): Use
1694         ARM_DISPLACED_MODIFIED_INSNS.
1695
1696 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1697
1698         * features/Makefile: Remove unused xml files.
1699         * features/aarch64.xml: Remove.
1700         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1701         * features/i386/amd64-avx-avx512.xml: Remove.
1702         * features/i386/amd64-avx-linux.xml: Remove.
1703         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1704         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1705         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1706         * features/i386/amd64-avx-mpx.xml: Remove.
1707         * features/i386/amd64-avx.xml: Remove.
1708         * features/i386/amd64-linux.xml: Remove.
1709         * features/i386/amd64-mpx-linux.xml: Remove.
1710         * features/i386/amd64-mpx.xml: Remove.
1711         * features/i386/amd64.xml: Remove.
1712         * features/i386/i386-avx-avx512-linux.xml: Remove.
1713         * features/i386/i386-avx-avx512.xml: Remove.
1714         * features/i386/i386-avx-linux.xml: Remove.
1715         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1716         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1717         * features/i386/i386-avx-mpx-linux.xml: Remove.
1718         * features/i386/i386-avx-mpx.xml: Remove.
1719         * features/i386/i386-avx.xml: Remove.
1720         * features/i386/i386-linux.xml: Remove.
1721         * features/i386/i386-mmx-linux.xml: Remove.
1722         * features/i386/i386-mmx.xml: Remove.
1723         * features/i386/i386-mpx-linux.xml: Remove.
1724         * features/i386/i386-mpx.xml: Remove.
1725         * features/i386/i386.xml: Remove.
1726         * features/i386/x32-avx-avx512-linux.xml: Remove.
1727         * features/i386/x32-avx-linux.xml: Remove.
1728         * features/i386/x32-linux.xml: Remove.
1729
1730 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1731
1732         * regformats/aarch64.dat: Remove.
1733         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1734         * regformats/i386/amd64-avx-linux.dat: Remove.
1735         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1736         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1737         * regformats/i386/amd64-linux.dat: Remove.
1738         * regformats/i386/amd64-mpx-linux.dat: Remove.
1739         * regformats/i386/amd64.dat: Remove.
1740         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1741         * regformats/i386/i386-avx-linux.dat: Remove.
1742         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1743         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1744         * regformats/i386/i386-linux.dat: Remove.
1745         * regformats/i386/i386-mmx-linux.dat: Remove.
1746         * regformats/i386/i386-mpx-linux.dat: Remove.
1747         * regformats/i386/i386.dat: Remove.
1748         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1749         * regformats/i386/x32-avx-linux.dat: Remove.
1750         * regformats/i386/x32-linux.dat: Remove.
1751
1752 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1753
1754         * aarch64-tdep.c: Remove xml self tests.
1755         * amd64-linux-tdep.c: Likewise.
1756         * amd64-tdep.c: Likewise.
1757         * i386-linux-tdep.c: Likewise.
1758         * i386-tdep.c: Likewise.
1759
1760 2019-07-03  Pedro Alves  <palves@redhat.com>
1761
1762         PR cli/24732
1763         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1764         (pipe_cmd_option_defs): New.
1765         (make_pipe_cmd_options_def_group): New.
1766         (pipe_command): Use gdb::option::process_options.
1767         (pipe_command_completer): New function.
1768         (_initialize_cli_cmds): Install completer for "pipe" command.
1769
1770 2019-07-03  Pedro Alves  <palves@redhat.com>
1771
1772         * cli/cli-option.c (union option_value) <string>: New field.
1773         (struct option_def_and_value): Add ctor, move ctor, dtor and
1774         use DISABLE_COPY_AND_ASSIGN.
1775         (option_def_and_value::clear_value): New.
1776         (parse_option, save_option_value_in_ctx, get_val_type_str)
1777         (add_setshow_cmds_for_options): Handle var_string.
1778         * cli-option.h (union option_def::var_address) <string>: New
1779         field.
1780         (struct string_option_def): New.
1781         * maint-test-options.c (struct test_options_opts): Add default
1782         ctor and use DISABLE_COPY_AND_ASSIGN.
1783         <string_opt>: New field.
1784         (test_options_opts::~test_options_opts): New.
1785         (test_options_opts::dump): Also dump "-string".
1786         (test_options_option_defs): Install "string.
1787
1788 2019-07-03  Pedro Alves  <palves@redhat.com>
1789
1790         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1791         option_value with a null enumeration.
1792         (complete_options): Save the option values in the context.
1793         (save_option_value_in_ctx): New, factored out from ...
1794         (process_options): ... here.
1795         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1796         of the function.
1797         * maint-test-options.c (test_options_opts::dump): New, factored
1798         out from ...
1799         (maintenance_test_options_command_mode): ... here.
1800         (maintenance_test_options_command_completion_result): Delete.
1801         (maintenance_test_options_command_completion_text): Update
1802         comment.
1803         (maintenance_show_test_options_completion_result): Change
1804         prototype.  Just print
1805         maintenance_test_options_command_completion_text.
1806         (save_completion_result): New.
1807         (maintenance_test_options_completer_mode): Pass options context to
1808         complete_options, and then save a dump.
1809         (_initialize_maint_test_options): Use add_cmd to install "maint
1810         show test-options-completion-result".
1811
1812 2019-07-03  Pedro Alves  <palves@redhat.com>
1813
1814         * NEWS (New commands): Mention "with" and "maint with".
1815         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1816         (with_command, with_command_completer): New.
1817         (pipe_command): Adjust to new repeat_previous
1818         interface.
1819         (_initialize_cli_cmds): Install the "with" command and its "w"
1820         alias.
1821         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1822         declarations.
1823         * cli/cli-setshow.c (parse_cli_var_uinteger)
1824         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1825         argument strings for all var_types.
1826         (get_setshow_command_value_string): New, factored out from ...
1827         (do_show_command): ... this.
1828         * cli/cli-setshow.h: Include <string>.
1829         (get_setshow_command_value_string): Declare.
1830         * command.h (repeat_previous): Now returns const char *.  Adjust
1831         comment.
1832         * maint.c: Include "cli/cli-cmds.h".
1833         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1834         (_initialize_maint_cmds): Register the "maintenance with" command.
1835         * top.c (repeat_previous): Move bits from pipe_command here:
1836         Return the saved command line, if any; error out if there's no
1837         command to relaunch.
1838
1839 2019-07-03  Pedro Alves  <palves@redhat.com>
1840
1841         * NEWS (New commands): Mention "maint set/show test-settings"
1842         instead of "maint test-settings".
1843         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1844         (maintenance_test_settings_set_list): Rename to ...
1845         (maintenance_set_test_settings_list): ... this.
1846         (maintenance_test_settings_show_list): Rename to  ...
1847         (maintenance_show_test_settings_list): ... this.
1848         (maintenance_test_settings_cmd): Delete.
1849         (maintenance_test_settings_set_cmd): ...
1850         (maintenance_set_test_settings_cmd): ... this.
1851         (maintenance_test_settings_show_cmd): ...
1852         (maintenance_show_test_settings_cmd): ... this.
1853         (maintenance_test_settings_show_value_cmd):
1854         (maintenance_show_test_settings_value_cmd): ... this.
1855         (_initialize_maint_test_settings): No longer install the "maint
1856         test-settings" prefix command.  Rename "maint test-settings set"
1857         to "maint set test-settings", and "maint test-settings show" to
1858         "maint show test-settings".  Adjust all subcommands.
1859
1860 2019-07-03  Pedro Alves  <palves@redhat.com>
1861
1862         * maint-test-settings.c: Fix file's intro comment.  Replace all
1863         references to "test-options" with references to "test-settings",
1864         in comments.
1865
1866 2019-07-03  Pedro Alves  <palves@redhat.com>
1867
1868         * maint-test-settings.c (maintenance_test_settings_xxx)
1869         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1870         New.
1871         (maintenance_test_settings_enums): Use them.
1872         (maintenance_test_settings_enum): Default to
1873         maintenance_test_settings_xxx.
1874         (_initialize_maint_test_settings): Initialize
1875         MAINTENANCE_TEST_SETTINGS_FILENAME.
1876
1877 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1878
1879         * breakpoint.h (remove_breakpoints_inf): Change return type to
1880         void, move function documentation here.
1881         * breakpoint.c (remove_breakpoints_inf): Change return type to
1882         void, move function documentation to header.
1883
1884 2019-07-02  Pedro Alves  <palves@redhat.com>
1885
1886         * NEWS (Completion improvements): Mention "info threads".
1887         * thread.c (struct info_threads_opts, info_threads_option_defs)
1888         (make_info_threads_options_def_group): New.
1889         (info_threads_command): Use gdb::option::process_options.
1890         (info_threads_command_completer): New.
1891         (_initialize_thread): Use gdb::option::build_help to build the
1892         help text for "info threads".
1893
1894 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1895
1896         * defs.h (generic_load): Move from here...
1897         * symfile.h (generic_load): ... to here.  Rename name parameter
1898         to args.
1899         * symfile.c (generic_load): Add comment.
1900
1901 2019-07-01  Tom Tromey  <tromey@adacore.com>
1902
1903         * dwarf2read.c
1904         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1905         declaration of without_params.  Fix formatting.
1906
1907 2019-07-01  Tom Tromey  <tromey@adacore.com>
1908
1909         * ada-exp.y (find_primitive_type): Update.
1910         * ada-lang.h (ada_lookup_symbol): Update.
1911         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1912         parameter.
1913         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1914
1915 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1916
1917         PR breakpoints/24541
1918         * gdbarch.c: Regenerate.
1919         * gdbarch.h: Regenerate.
1920         * gdbarch.sh: Add 'stap_adjust_register'.
1921         * i386-tdep.c: Include '<unordered_set>'.
1922         (i386_stap_adjust_register): New function.
1923         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1924         * stap-probe.c (stap_parse_register_operand): Call
1925         'gdbarch_stap_adjust_register'.
1926
1927 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1928
1929         PR python/24742
1930         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1931         * python/python.c (do_start_initialization): Use 'xmalloc'
1932         instead of 'PyMem_Malloc'.
1933
1934 2019-06-28  Tom Tromey  <tromey@adacore.com>
1935
1936         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1937         for Ada.
1938
1939 2019-06-27  Tom Tromey  <tromey@adacore.com>
1940
1941         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1942         objfile_key.
1943         (arm_find_mapping_symbol, arm_record_special_symbol)
1944         (_initialize_arm_tdep): Update.
1945         (arm_objfile_data_free): Remove.
1946
1947 2019-06-27  Tom Tromey  <tromey@adacore.com>
1948
1949         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1950         to cp_print_static_field.
1951
1952 2019-06-26  Tom Tromey  <tromey@adacore.com>
1953
1954         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1955         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1956         declare.
1957
1958 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1959
1960         * features/aarch64-core.c (create_feature_aarch64_core):
1961         Regenerate.
1962         * features/aarch64-core.xml: Add cpsr flags.
1963
1964 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1965
1966         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1967         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1968
1969 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1970
1971         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1972         field.
1973         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1974         use.
1975         (arm_record_special_symbol): Don't insert new symbol in sorted
1976         position, push it at the end.
1977
1978 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1979
1980         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1981         (arm_mapping_symbol_s): Remove.
1982         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1983         (arm_mapping_symbol_vec): New typedef.
1984         (struct arm_per_objfile): Add constructor.
1985         <section_maps>: Change type to
1986         std::unique_ptr<arm_mapping_symbol_vec[]>.
1987         (arm_compare_mapping_symbols): Remove.
1988         (arm_find_mapping_symbol): Adjust to section_maps type change.
1989         (arm_objfile_data_free): Call delete on arm_per_objfile.
1990         (arm_record_special_symbol): Adjust to section_maps type change.
1991         Allocate arm_per_objfile with new.
1992
1993 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1994
1995         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1996         with the command prefix.
1997
1998 2019-06-25  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2001         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2002
2003 2019-06-25  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2006         type.
2007         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2008         protected.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-winsource.c
2013         (tui_source_window_base::set_is_exec_point_at): Add check against
2014         LOA_ADDRESS.
2015
2016 2019-06-25  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-source.c (tui_set_source_content): Don't check before
2019         xfree.
2020         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2021
2022 2019-06-25  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-winsource.h (tui_update_source_window_as_is)
2025         (tui_alloc_source_buffer, tui_line_is_displayed)
2026         (tui_addr_is_displayed): Change type of win_info.
2027         * tui/tui-winsource.c (tui_update_source_window_as_is)
2028         (tui_clear_source_content, tui_show_source_line)
2029         (tui_show_source_content, tui_source_window_base::refill)
2030         (tui_source_window_base::set_is_exec_point_at)
2031         (tui_source_window_base::set_is_exec_point_at)
2032         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2033         (tui_alloc_source_buffer, tui_line_is_displayed)
2034         (tui_addr_is_displayed): Change type of win_info.  Update.
2035         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2036         (tui_source_window_base::do_make_visible_with_new_height):
2037         Update.
2038         * tui/tui-source.c (tui_set_source_content)
2039         (tui_set_source_content_nil)
2040         (tui_source_window::do_scroll_vertical): Update.
2041         * tui/tui-layout.c (show_layout): Update.
2042         * tui/tui-disasm.c (tui_set_disassem_content)
2043         (tui_disasm_window::do_scroll_vertical): Update.
2044         * tui/tui-data.h (tui_win_content): Remove.
2045         (struct tui_gen_win_info) <content, content_size>: Remove.
2046         (struct tui_source_element): Add initializers and destructor.
2047         (union tui_which_element, struct tui_win_element): Remove.
2048         (struct tui_source_window_base) <content>: New field.
2049         (struct tui_data_window): Remove destructor.
2050         (tui_alloc_content, tui_free_win_content)
2051         (tui_free_all_source_wins_content): Don't declare.
2052         * tui/tui-data.c (tui_initialize_static_data): Update.
2053         (init_content_element, tui_alloc_content): Remove.
2054         (~tui_gen_win_info): Update.
2055         (~tui_data_window, tui_free_all_source_wins_content)
2056         (tui_free_win_content, free_content, free_content_elements):
2057         Remove.
2058
2059 2019-06-25  Tom Tromey  <tom@tromey.com>
2060
2061         * tui/tui-winsource.h (tui_clear_source_content)
2062         (tui_erase_source_content, tui_show_source_content): Change type
2063         of win_info.
2064         * tui/tui-winsource.c (tui_clear_source_content)
2065         (tui_erase_source_content, tui_show_source_content): Change type
2066         of win_info.
2067         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2068         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2069         win_info.
2070         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2071         win_info.
2072         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2073
2074 2019-06-25  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui-winsource.c (tui_clear_source_content)
2077         (tui_source_window_base::set_is_exec_point_at): Update.
2078         * tui/tui-source.c (tui_set_source_content_nil): Update.
2079         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2080         a bool.
2081         * tui/tui-data.c (init_content_element): Update.
2082
2083 2019-06-25  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2086         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2087         * tui/tui-layout.c (init_and_make_win): Update.
2088         * tui/tui.h (enum tui_win_type): Update.
2089         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2090         tui_win_is_auxillary.
2091         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2092         tui_win_is_auxillary.
2093
2094 2019-06-25  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2097         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2098         (tui_delete_data_content_windows, tui_display_all_data)
2099         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2100         Update.
2101         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2102         * tui/tui-regs.c (tui_last_regs_line_no)
2103         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2104         (tui_show_registers): Update.
2105         (tui_show_register_group): Return void.  Update.
2106         (tui_display_registers_from, tui_display_reg_element_at_line)
2107         (tui_display_registers_from_line, tui_check_register_values):
2108         Update.
2109         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2110         member.
2111         (struct tui_data_window) <regs_content>: Now a std::vector.
2112         <regs_content_count>: Remove.
2113         (tui_add_content_elements, tui_free_data_content): Don't declare.
2114         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2115         (init_content_element): Remove DATA_WIN case.  Add assert.
2116         (tui_add_content_elements): Remove.
2117         (tui_data_window): Update.
2118         (tui_free_data_content): Remove.
2119         (free_content_elements): Remove DATA_WIN case.
2120
2121 2019-06-25  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-data.c (tui_data_item_window): Update.
2124         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2125         * tui/tui-windata.c (tui_display_all_data)
2126         (tui_display_data_from_line): Update.
2127         (tui_check_data_values): Remove.
2128         * tui/tui-regs.c (tui_show_register_group)
2129         (tui_display_reg_element_at_line): Update.
2130         * tui/tui-hooks.c (tui_register_changed)
2131         (tui_refresh_frame_and_register_information): Call
2132         tui_check_register_values.
2133         * tui/tui-data.h (struct tui_data_window) <data_content,
2134         data_content_count, data_type>: Remove.
2135         (enum tui_data_type): Remove.
2136
2137         * tui/tui-data.c (tui_data_window::clear_detail)
2138         (~tui_data_window): Update.
2139
2140 2019-06-25  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2143         declare.
2144         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2145         Rename from tui_first_data_item_displayed.  Update.
2146         (tui_data_window::refresh_all)
2147         (tui_data_window::do_scroll_vertical): Update.
2148         * tui/tui-data.h (struct tui_data_window)
2149         <first_data_item_displayed>: Declare new method.
2150
2151 2019-06-25  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2154         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2155         contents...
2156         (tui_initialize_static_data): ...here.
2157
2158 2019-06-25  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2161         (tui_display_registers_from, tui_check_register_values): Update.
2162         (tui_display_register): Remove win_info parameter; update.
2163         (tui_get_register): Change type of parameters.
2164         * tui/tui-data.h (struct tui_data_element): Remove.
2165         (union tui_which_element) <data>: Remove.
2166         <data_window>: Change type.
2167         (struct tui_data_item_window): New.
2168         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2169         case.  Add assert.
2170         (~tui_data_item_window): New destructor.
2171         (free_content_elements): Remove DATA_ITEM_WIN case.
2172
2173 2019-06-25  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2176         Remove.
2177
2178 2019-06-25  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-data.h (struct tui_command_element): Remove.
2181         (union tui_which_element) <command>: Remove.
2182         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2183         assert.
2184         (free_content_elements): Remove CMD_WIN case.
2185
2186 2019-06-25  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-layout.c (tui_set_layout): Update.
2189         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2190         * tui/tui-data.c (layout_def): Update.
2191
2192 2019-06-25  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2195         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2196         (tui_source_window_base::set_new_height): Update.
2197         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2198         Update.
2199         (tui_set_locator_fullname, tui_set_locator_info)
2200         (tui_show_frame_info): Update.
2201         * tui/tui-source.c (tui_set_source_content)
2202         (tui_source_is_displayed): Update.
2203         * tui/tui-layout.c (show_source_disasm_command, show_data)
2204         (show_source_or_disasm_and_command): Update.
2205         * tui/tui-disasm.c (tui_set_disassem_content)
2206         (tui_get_begin_asm_address): Update.
2207         * tui/tui-data.h (struct tui_locator_element): Remove.
2208         (union tui_which_element) <locator>: Remove.
2209         (struct tui_locator_window): New.
2210         (tui_locator_win_info_ptr): Change return type.
2211         * tui/tui-data.c (_locator): Change type.
2212         (tui_locator_win_info_ptr): Change return type.
2213         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2214         (tui_alloc_content): Add assert.
2215
2216 2019-06-25  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-winsource.c
2219         (tui_exec_info_window::maybe_allocate_content): New method.
2220         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2221         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2222         (make_source_or_disasm_window): Add cast.
2223         * tui/tui-data.h (union tui_which_element) <simple_string>:
2224         Remove.
2225         (struct tui_source_info): New.
2226         (struct tui_source_window_base) <execution_info>: Change type.
2227         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2228         case, and add assert.
2229         (tui_alloc_content): Add assert.
2230
2231 2019-06-25  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2234         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2235         * tui/tui-data.c (tui_alloc_win_info): Remove.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2240         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2241         can_highlight.
2242
2243 2019-06-25  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2246         make_visible_with_new_height method.
2247         (tui_win_info::make_visible_with_new_height): New method.
2248         (tui_source_window_base::do_make_visible_with_new_height)
2249         (tui_data_window::do_make_visible_with_new_height)
2250         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2251         (make_visible_with_new_height): Remove.
2252         (tui_resize_all, tui_adjust_win_heights): Use
2253         make_visible_with_new_height method.
2254         * tui/tui-data.h (struct tui_win_info)
2255         <do_make_visible_with_new_height, make_visible_with_new_height>:
2256         New methods.
2257         (struct tui_source_window_base, struct tui_data_window)
2258         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2259         methods.
2260
2261 2019-06-25  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2264         method.
2265         (update_tab_width): Call update_tab_width method.
2266         * tui/tui-data.h (struct tui_win_info)
2267         (struct tui_source_window_base) <update_tab_width>: New methods.
2268
2269 2019-06-25  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2272         parameter.
2273         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2274         parameter.
2275         (tui_gen_win_info::make_visible): Update.
2276         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2277         parameter.
2278         * tui/tui-data.h (enum tui_box): New enum.
2279         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2280
2281 2019-06-25  Tom Tromey  <tom@tromey.com>
2282
2283         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2284         init_and_make_win for EXEC_INFO_WIN.
2285         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2286         longer inline.
2287         (struct tui_win_info) <~tui_win_info>: Inline.
2288         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2289         Don't declare.
2290         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2291         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2292         Remove.
2293         (tui_initialize_static_data): Update.
2294         (~tui_gen_win_info): Handle more cleanup here.
2295         (~tui_source_window_base): Delete "execution_info".
2296         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2297
2298 2019-06-25  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-layout.c (make_command_window): Don't set
2301         can_highlight.
2302         (show_source_disasm_command): Call the reset method.
2303         (show_data): Don't set can_highlight.  Call the reset method.
2304         (tui_gen_win_info::reset): Rename from init_gen_win_info
2305         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2306         (show_source_or_disasm_and_command): Call the reset method.
2307         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2308         (struct tui_cmd_window): Set can_highlight.
2309
2310 2019-06-25  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2313         from make_visible.
2314         (tui_make_visible, tui_make_invisible): Rewrite.
2315         (tui_win_info::make_visible): Remove.
2316         (tui_source_window_base::make_visible): Update.
2317         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2318         method.  Moved from...
2319         (struct tui_win_info) <make_visible>: ...here.
2320
2321 2019-06-25  Tom Tromey  <tom@tromey.com>
2322
2323         * tui/tui-winsource.c
2324         (tui_source_window_base::do_scroll_horizontal): Remove direction
2325         parameter.
2326         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2327         direction parameter.
2328         * tui/tui-win.c (tui_win_info::forward_scroll)
2329         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2330         (tui_win_info::right_scroll): Update.
2331         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2332         direction parameter.
2333         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2334         direction parameter.
2335         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2336         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2337         Remove direction parameter.
2338         (struct tui_source_window_base, struct tui_source_window)
2339         (struct tui_disasm_window, struct tui_data_window)
2340         (struct tui_cmd_window): Update.
2341
2342 2019-06-25  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui-winsource.h (tui_set_exec_info_content)
2345         (tui_show_exec_info_content, tui_erase_exec_info_content)
2346         (tui_clear_exec_info_content, tui_update_exec_info): Change
2347         argument to tui_source_window_base.
2348         * tui/tui-winsource.c (tui_set_exec_info_content)
2349         (tui_show_exec_info_content, tui_erase_exec_info_content)
2350         (tui_clear_exec_info_content, tui_update_exec_info): Change
2351         argument to tui_source_window_base.
2352
2353 2019-06-25  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2356         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2357
2358 2019-06-25  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2361         check.
2362
2363 2019-06-25  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2366         type to void.
2367         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2368         type to void.
2369         * tui/tui-source.c (tui_set_source_content): Update.
2370         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-win.c (window_name_completer, tui_set_focus)
2375         (tui_all_windows_info): Use name method.
2376         * tui/tui-data.h (struct tui_gen_win_info)
2377         (struct tui_source_window, struct tui_disasm_window)
2378         (struct tui_data_window, struct tui_cmd_window) <name>: New
2379         method.
2380         (tui_win_name): Don't declare.
2381         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2382         (tui_win_name): Remove.
2383
2384 2019-06-25  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui-winsource.h (tui_update_source_window)
2387         (tui_update_source_window_as_is): Change parameter type.
2388         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2389         to be a tui_source_window_base.
2390         (tui_update_source_window_as_is): Likewise.
2391         * tui/tui-win.c (make_visible_with_new_height): Update.
2392
2393 2019-06-25  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-winsource.c (tui_erase_source_content)
2396         (tui_show_source_content, tui_show_exec_info_content)
2397         (tui_erase_exec_info_content): Use refresh_window method.
2398         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2399         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2400         from tui_refresh_win.
2401         (tui_data_window::refresh_window): New method.
2402         (tui_win_info::refresh, tui_source_window_base::refresh)
2403         (tui_refresh_all): Use refresh_window method.
2404         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2405         method.
2406         * tui/tui-regs.c (tui_display_register): Call refresh_window
2407         method.
2408         * tui/tui-layout.c (show_source_disasm_command)
2409         (show_source_or_disasm_and_command): Call refresh_window method.
2410         * tui/tui-data.h (struct tui_gen_win_info)
2411         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2412         New method.
2413
2414 2019-06-25  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui.c (tui_rl_other_window, tui_enable)
2417         (tui_is_window_visible, tui_get_command_dimension): Update.
2418         * tui/tui-winsource.c (tui_update_source_window_as_is)
2419         (tui_clear_source_content, tui_erase_source_content)
2420         (tui_show_source_line, tui_source_window_base::refill)
2421         (tui_source_window_base::do_scroll_horizontal)
2422         (tui_source_window_base::set_is_exec_point_at)
2423         (tui_update_breakpoint_info, tui_set_exec_info_content)
2424         (tui_alloc_source_buffer, tui_line_is_displayed)
2425         (tui_addr_is_displayed): Update.
2426         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2427         (tui_check_and_display_highlight_if_needed)
2428         (tui_win_info::make_visible, tui_win_info::refresh)
2429         (tui_refresh_all): Update.
2430         * tui/tui-windata.c (tui_first_data_item_displayed)
2431         (tui_delete_data_content_windows, tui_erase_data_content)
2432         (tui_display_all_data, tui_data_window::refresh_all)
2433         (tui_check_data_values): Update.
2434         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2435         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2436         (tui_win_info::backward_scroll, tui_refresh_all_win)
2437         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2438         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2439         (tui_source_window_base::set_new_height)
2440         (tui_data_window::set_new_height)
2441         (make_invisible_and_set_new_height)
2442         (make_visible_with_new_height, new_height_ok)
2443         (parse_scrolling_args): Update.
2444         * tui/tui-stack.c (tui_show_frame_info): Update.
2445         * tui/tui-source.c (tui_set_source_content)
2446         (tui_set_source_content_nil, tui_source_is_displayed)
2447         (tui_source_window::do_scroll_vertical): Update.
2448         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2449         (tui_display_registers_from, tui_display_reg_element_at_line)
2450         (tui_check_register_values, tui_reg_command): Update.
2451         * tui/tui-layout.c (tui_default_win_height)
2452         (show_source_disasm_command, show_data, init_and_make_win)
2453         (show_source_or_disasm_and_command): Update.
2454         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2455         (tui_redisplay_readline, tui_mld_flush)
2456         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2457         (tui_getc): Update.
2458         * tui/tui-disasm.c (tui_set_disassem_content)
2459         (tui_disasm_window::do_scroll_vertical): Update.
2460         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2461         Now virtual.
2462         (struct tui_win_info): Derive from tui_gen_win_info.
2463         <~tui_win_info>: Mark as override.
2464         <generic>: Remove member.
2465         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2466         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2467         (~tui_data_window, ~tui_win_info)
2468         (tui_free_all_source_wins_content): Update.
2469         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2470
2471 2019-06-25  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-layout.c (init_and_make_win): Use new.
2474         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2475         destructor, initializers.
2476         (tui_alloc_generic_win_info): Don't declare.
2477         * tui/tui-data.c (_locator): Add argument to constructor.
2478         (source_win, disasm_win): New globals.
2479         (exec_info): Remove.
2480         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2481         Update.
2482         (tui_alloc_generic_win_info): Remove.
2483         (init_content_element): Use new.
2484         (tui_win_info::tui_win_info): Update.
2485         (free_content_elements) <case DATA_WIN>: Use delete.
2486
2487 2019-06-25  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2490         * tui/tui-windata.c (tui_first_data_item_displayed)
2491         (tui_delete_data_content_windows): Update.
2492         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2493         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2494         (tui_display_registers_from, tui_check_register_values): Update.
2495         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2496         pointer.
2497         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2498         window.
2499         (tui_free_data_content): Update.
2500         (free_content_elements) <case DATA_WIN>: Free the window.
2501
2502 2019-06-25  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2505         Update.
2506         * tui/tui-layout.c (make_command_window)
2507         (show_source_disasm_command, show_data, init_and_make_win)
2508         (show_source_or_disasm_and_command): Update.
2509         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2510         method.
2511         <can_highight, is_highlighted>: Now bool.
2512         (tui_set_win_highlight): Don't declare.
2513         * tui/tui-data.c (tui_set_win_highlight): Remove.
2514
2515 2019-06-25  Tom Tromey  <tom@tromey.com>
2516
2517         * tui/tui-wingeneral.c (make_visible): Remove check of window
2518         type.
2519
2520 2019-06-25  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-win.c (tui_win_info::max_height)
2523         (tui_cmd_window::max_height): New methods.
2524         (new_height_ok): Call max_height.
2525         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2526         <max_height>: New method.
2527
2528 2019-06-25  Tom Tromey  <tom@tromey.com>
2529
2530         * tui/tui-win.c (tui_source_window_base::set_new_height)
2531         (tui_data_window::set_new_height): New methods.
2532         (make_invisible_and_set_new_height): Call set_new_height method.
2533         * tui/tui-data.h (struct tui_win_info)
2534         (struct tui_source_window_base, struct tui_data_window)
2535         <set_new_height>: New method.
2536
2537 2019-06-25  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2540         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2541         tui_refresh_data_win.
2542         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2543         method.
2544         (tui_refresh_all_win): Call the refresh_all method.
2545         (tui_set_focus): Likewise.
2546         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2547         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2548         Likewise.
2549
2550 2019-06-25  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-winsource.h (tui_refill_source_window)
2553         (tui_set_is_exec_point_at): Don't declare.
2554         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2555         (tui_source_window_base::refill): Rename from
2556         tui_refill_source_window.
2557         (tui_source_window_base::do_scroll_horizontal): Update.
2558         (tui_source_window_base::set_is_exec_point_at): Rename from
2559         tui_set_is_exec_point_at.
2560         (tui_update_all_breakpoint_info): Update.
2561         * tui/tui-stack.c (tui_show_frame_info): Update.
2562         * tui/tui-layout.c (show_data): Add cast.
2563         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2564         * tui/tui-data.h (struct tui_source_window_base) <refill,
2565         set_is_exec_point_at>: New methods.
2566         (tui_source_windows, tui_add_to_source_windows): Update types.
2567         (tui_add_to_source_windows): Remove redundant declaration.
2568         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2569         (tui_source_windows): Change return type.
2570         (tui_clear_source_windows_detail): Update.
2571         (tui_add_to_source_windows): Change type of parameter.
2572         (tui_free_all_source_wins_content): Update.
2573
2574 2019-06-25  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-wingeneral.c (tui_win_info::refresh)
2577         (tui_source_window_base::refresh): New methods.
2578         (tui_refresh_all): Call the refresh method.
2579         * tui/tui-data.h (struct tui_win_info)
2580         (struct tui_source_window_base) <refresh>: New method.
2581
2582 2019-06-25  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui.h (tui_is_window_visible): Return bool.
2585         * tui/tui.c (tui_is_window_visible): Return bool.
2586         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2587         (tui_make_visible, tui_make_invisible)
2588         (tui_win_info::make_visible)
2589         (tui_source_window_base::make_visible, make_all_visible)
2590         (tui_make_all_visible, tui_make_all_invisible): Update.
2591         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2592         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2593         bool.
2594         (struct tui_win_info, struct tui_source_window_base)
2595         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2596         * tui/tui-data.c (tui_init_generic_part): Update.
2597
2598 2019-06-25  Tom Tromey  <tom@tromey.com>
2599
2600         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2601         (tui_source_window_base::make_visible): New methods.
2602         (make_all_visible): Make method call.
2603         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2604         (struct tui_source_window_base, struct tui_cmd_window): Override
2605         make_visible.
2606         (tui_win_is_source_type): Don't declare.
2607         * tui/tui-data.c (tui_win_is_source_type): Remove.
2608
2609 2019-06-25  Tom Tromey  <tom@tromey.com>
2610
2611         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2612         NULL check.
2613
2614 2019-06-25  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2617         Inline constructor.  Add initializers for members.
2618         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2619         constructors; now inline in class.
2620
2621 2019-06-25  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-regs.c (tui_show_registers): Update.
2624         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2625         bool.
2626         * tui/tui-data.c (tui_data_window::clear_detail)
2627         (tui_data_window): Update.
2628
2629 2019-06-25  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui-windata.c (tui_display_all_data)
2632         (tui_display_data_from_line, tui_display_data_from)
2633         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2634         Update.
2635         * tui/tui-regs.c (tui_last_regs_line_no)
2636         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2637         (tui_show_registers, tui_show_register_group)
2638         (tui_display_registers_from, tui_display_reg_element_at_line)
2639         (tui_display_registers_from_line, tui_check_register_values)
2640         (tui_reg_next, tui_reg_prev): Update.
2641         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2642         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2643         tui_data_window.
2644         (struct tui_win_info) <detail>: Remove.  Add new fields from
2645         tui_data_info.
2646         (TUI_DATA_WIN): Add cast.
2647         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2648         (~tui_data_window): Simplify.
2649
2650 2019-06-25  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui-layout.c (show_source_disasm_command)
2653         (show_source_or_disasm_and_command): Update.
2654         * tui/tui-io.c (update_cmdwin_start_line)
2655         (tui_redisplay_readline): Update.
2656         * tui/tui-data.h (struct tui_command_info): Remove.
2657         (struct tui_win_info) <detail>: Remove command_info member.
2658         (struct tui_data_window) <start_line>: New member, from
2659         tui_command_info.
2660         (TUI_CMD_WIN): Add casts.
2661
2662 2019-06-25  Tom Tromey  <tom@tromey.com>
2663
2664         * tui/tui-winsource.c (tui_update_source_window)
2665         (tui_refill_source_window)
2666         (tui_source_window_base::do_scroll_horizontal)
2667         (tui_update_breakpoint_info, tui_set_exec_info_content)
2668         (tui_show_exec_info_content, tui_erase_exec_info_content)
2669         (tui_clear_exec_info_content): Update.
2670         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2671         Update.
2672         * tui/tui-win.c (make_invisible_and_set_new_height)
2673         (make_visible_with_new_height): Update.
2674         * tui/tui-source.c (tui_set_source_content)
2675         (tui_show_symtab_source): Update.
2676         * tui/tui-layout.c (extract_display_start_addr)
2677         (show_source_disasm_command, show_data)
2678         (make_source_or_disasm_window)
2679         (show_source_or_disasm_and_command): Update.
2680         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2681         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2682         "gdbarch".
2683         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2684         to tui_source_window_base.
2685         (struct tui_win_info) <detail>: Remove source_info member.
2686         (struct tui_source_window_base) <has_locator>: Inline.
2687         Move contents from tui_source_info; rename has_locator member to
2688         m_has_locator.
2689         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2690         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2691         header file.
2692         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2693         Simplify.
2694         (tui_free_all_source_wins_content): Cast to
2695         tui_source_window_base.
2696
2697 2019-06-25  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-win.c (make_invisible_and_set_new_height)
2700         (make_visible_with_new_height): Call has_locator method.
2701         * tui/tui-layout.c (show_source_disasm_command, show_data)
2702         (show_source_or_disasm_and_command): Update for bool change.
2703         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2704         (tui_win_info) <has_locator>: New method.
2705         (struct tui_source_window_base) <has_locator>: New method.
2706         (tui_win_has_locator): Don't declare.
2707         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2708         from tui_win_has_locator.
2709         (tui_source_window_base): Use false, not FALSE.
2710
2711 2019-06-25  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2714         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2715         clear_detail method directly.
2716         (tui_clear_win_detail): Remove.
2717
2718 2019-06-25  Tom Tromey  <tom@tromey.com>
2719
2720         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2721         "this", not TUI_DISASM_WIN.
2722
2723 2019-06-25  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2726         declare.
2727         * tui/tui-winsource.c
2728         (tui_source_window_base::do_scroll_horizontal): Rename from
2729         tui_horizontal_source_scroll.
2730         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2731         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2732         from tui_vertical_data_scroll.
2733         * tui/tui-win.h (tui_scroll): Don't declare.
2734         * tui/tui-win.c (tui_win_info::forward_scroll)
2735         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2736         (tui_win_info::right_scroll): Rename and update.
2737         (tui_scroll_forward_command, tui_scroll_backward_command)
2738         (tui_scroll_left_command, tui_scroll_right_command): Update.
2739         (tui_scroll): Remove.
2740         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2741         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2742         from tui_vertical_source_scroll.
2743         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2744         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2745         from tui_vertical_disassem_scroll.
2746         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2747         do_scroll_horizontal>: New methods.
2748         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2749         Likewise.
2750         (struct tui_source_window_base): Add do_scroll_horizontal.
2751         (struct tui_source_window, struct tui_disasm_window): Add
2752         do_scroll_vertical.
2753         (struct tui_data_window, struct tui_cmd_window): Add
2754         do_scroll_horizontal and do_scroll_vertical.
2755         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2756
2757 2019-06-25  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui-data.h (struct tui_source_window_base): New struct.
2760         (struct tui_source_window): Derive from tui_source_window_base.
2761         (struct tui_disasm_window): New struct.
2762         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2763         from tui_source_window::clear_detail.
2764         (tui_source_window_base): Rename from tui_source_window.
2765         (~tui_source_window_base): Rename from ~tui_source_window.
2766         (tui_alloc_win_info): Create a tui_disasm_window.
2767
2768 2019-06-25  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-data.h (struct tui_source_window)
2771         (struct tui_data_window): Declare destructors.
2772         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2773         destructors.
2774         (tui_win_info): Simplify.
2775
2776 2019-06-25  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-winsource.c (tui_display_main)
2779         (tui_update_source_windows_with_addr)
2780         (tui_update_all_breakpoint_info): Update.
2781         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2782         (new_height_ok, parse_scrolling_args): Update.
2783         * tui/tui-stack.c (tui_show_frame_info): Update.
2784         * tui/tui-data.h (struct tui_list): Remove.
2785         (tui_source_windows): Return a reference to a std::vector.
2786         * tui/tui-data.c (source_windows): Now a std::vector.
2787         (tui_source_windows): Change return type.
2788         (tui_clear_source_windows): Rewrite.
2789         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2790         (tui_free_all_source_wins_content): Rewrite.
2791
2792 2019-06-25  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2795         (struct tui_data_window, struct tui_cmd_window): Declare
2796         clear_detail method.
2797         * tui/tui-data.c (tui_source_window::clear_detail)
2798         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2799         methods.
2800         (tui_clear_win_detail): Simplify.
2801
2802 2019-06-25  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-layout.c (make_source_window, make_disasm_window)
2805         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2806         Return the new window.
2807         (show_source_disasm_command, show_data)
2808         (show_source_or_disasm_and_command): Update.
2809
2810 2019-06-25  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2813         parameter.  Return the new window.
2814         (show_source_disasm_command): Update and remove NULL check.
2815         (show_source_or_disasm_and_command): Update.
2816
2817 2019-06-25  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2820
2821 2019-06-25  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-data.h (struct tui_win_info): Make constructor
2824         protected.  Make destructor virtual.  Add initializers.
2825         (tui_source_window, tui_data_window, tui_cmd_window): New
2826         classes.
2827         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2828         constructor.  Add "type" parameter.
2829         (tui_source_window, tui_data_window, tui_cmd_window): New
2830         constructors.
2831         (tui_alloc_win_info): Instantiate the appropriate subclass.
2832
2833 2019-06-25  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-win.c (tui_resize_all): Use delete.
2836         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2837         destructor.
2838         (tui_free_window): Don't declare.
2839         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2840         Update.
2841
2842 2019-06-25  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui-data.h (struct tui_win_info): Add constructor.
2845         * tui/tui-data.c (tui_alloc_win_info): Use new.
2846         (tui_free_window): Use delete.
2847
2848 2019-06-22  Tom Tromey  <tom@tromey.com>
2849
2850         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2851         declare.
2852         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2853
2854 2019-06-22  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2857         declare.
2858         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2859
2860 2019-06-22  Tom de Vries  <tdevries@suse.de>
2861
2862         * dwarf2read.c (create_addrmap_from_aranges)
2863         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2864         instead of '%zu'.
2865
2866 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2867
2868         * dwarf2read.h (dwarf2_section_info_def): Remove.
2869         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2870         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2871         std::vector<dwarf2_section_info>.
2872         (struct dwo_file) <~dwo_file>: Remove.
2873         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2874         types field.
2875         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2876         (dwarf2_read_debug_names): Likewise.
2877         (create_debug_types_hash_table): Change parameter type to
2878         array_view, adjust code accordingly.
2879         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2880         (partial_die_info::fixup): Likewise.
2881         (determine_prefix): Likewise.
2882         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2883
2884 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2885
2886         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2887         gdb_bfd_ref_ptr.
2888         <~dwo_file>: Remove call to gdb_bfd_unref.
2889         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2890         gdb_bfd_ref_ptr::get.
2891
2892 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2893
2894         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2895         type to htab_up.
2896         * dwarf2read.c (struct dwo_file): Initialize fields.
2897         <~dwo_file>: New.
2898         (free_dwo_file): Remove, move content to ~dwo_file.
2899         (struct dwo_file_deleter): Remove.
2900         (dwo_file_up>: Remove custom deleter.
2901         (free_dwo_files): Remove.
2902         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2903         dwo_files.
2904         (process_skeletonless_type_units): Call unique_ptr::get.
2905         (allocate_dwo_file_hash_table): Add deleter to created hash
2906         table.  Change return type to htab_up.
2907         (lookup_dwo_file_slot): Don't memset dwo_file, call
2908         unique_ptr::get.
2909         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2910         (create_dwo_unit_in_dwp_v2): Likewise.
2911         (open_and_init_dwo_file): Likewise.
2912         (free_dwo_file_from_slot): Remove.
2913
2914 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2915
2916         * dwarf2read.h (struct dwarf2_section_info) <readin,
2917         is_virtual>: Change type to bool.
2918         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2919         true instead of 1.
2920
2921 2019-06-19  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-data.h (tui_init_content_element): Don't declare.
2924
2925 2019-06-19  Tom Tromey  <tom@tromey.com>
2926
2927         * tui/tui-data.h (tui_init_win_info): Don't declare.
2928
2929 2019-06-19  Tom de Vries  <tdevries@suse.de>
2930
2931         * dwarf2read.h (abstract_to_concrete): Change type to
2932         std::unordered_map<sect_offset, std::vector<sect_offset>,
2933         gdb::hash_enum<sect_offset>>.
2934
2935 2019-06-19  Tom Tromey  <tromey@adacore.com>
2936
2937         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2938         EVAL_AVOID_SIDE_EFFECTS specially.
2939
2940 2019-06-19  Tom Tromey  <tromey@adacore.com>
2941
2942         * source-cache.c (highlighter): New global.
2943         (source_cache::get_source_lines): Create a highlighter on demand.
2944
2945 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2946
2947         * defs.h (deprecated_interactive_hook): Delete declaration.
2948         * interps.c (clear_interpreter_hooks): Remove use of
2949         deprecated_interactive_hook.
2950         * top.c (deprecated_interactive_hook): Delete definition.
2951         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2952
2953 2019-06-18  Tom de Vries  <tdevries@suse.de>
2954
2955         PR gdb/24515
2956         * dwarf2read.h (abstract_to_concrete): Change type from
2957         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2958         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2959         * dwarf2read.c (read_variable): Update.
2960         (dwarf2_fetch_die_loc_sect_off): Update.
2961
2962 2019-06-17  Tom de Vries  <tdevries@suse.de>
2963
2964         PR gdb/24617
2965         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2966         accessing parent[parent_len - 1].
2967
2968 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2969
2970         PR gdb/24364
2971         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2972         call dtrace_process_dof with NULL dof.
2973
2974 2019-06-16  Tom de Vries  <tdevries@suse.de>
2975
2976         PR gdb/24445
2977         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2978
2979 2019-06-16  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2982         (make_all_visible): Use address of member.
2983
2984 2019-06-16  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2987         (tui_free_window, free_content, free_content_elements): Remove
2988         unnecessary cast.
2989         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2990         cast.
2991         * tui/tui-regs.c (tui_show_register_group)
2992         (tui_display_registers_from, tui_display_reg_element_at_line):
2993         Remove unnecessary cast.
2994
2995 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * linux-nat.c (normal_mask): Delete.
2998         (_initialize_linux_nat): Don't initialise normal_mask.
2999
3000 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3001
3002         PR gdb/24445
3003         * dwarf-index-write.h (write_psymtabs_to_index): Add
3004         dwz_basename parameter.
3005         * dwarf-index-write.c (write_gdbindex): Move file writing to
3006         write_gdbindex_1.  Change return type void.
3007         (assert_file_size): Move up, remove filename parameter.
3008         (write_gdbindex_1): New function.
3009         (write_debug_names): Change return type to void, call
3010         assert_file_size.
3011         (struct index_wip_file): New struct.
3012         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3013         file logic to index_wip_file.  Write index for dwz file if
3014         needed.
3015         (save_gdb_index_command): Pass basename of dwz file, if present.
3016         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3017         build-id of dwz file, if present.
3018         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3019         (dwarf2_get_dwz_file): Likewise.
3020         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3021         (dwarf2_get_dwz_file): Likewise.
3022
3023 2019-06-16  Tom Tromey  <tom@tromey.com>
3024
3025         * coffread.c (process_coff_symbol): Use xstrdup.
3026         * value.c (create_internalvar): Use xstrdup.
3027
3028 2019-06-16  Tom Tromey  <tom@tromey.com>
3029
3030         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3031         * breakpoint.c (stopin_command, stopat_command)
3032         (until_break_command, decode_location_default): Remove unnecessary
3033         cast.
3034         * utils.c (subset_compare): Remove unnecessary cast.
3035         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3036         cast.
3037         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3038         cast.
3039         * infcmd.c (path_command): Remove unnecessary cast.
3040         * coffread.c (decode_type): Remove unnecessary cast.
3041         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3042         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3043         * tui/tui-stack.c (tui_show_locator_content)
3044         (tui_show_frame_info): Remove unnecessary cast.
3045         * tui/tui-win.c (tui_scroll_forward_command)
3046         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3047         (parse_scrolling_args): Remove unnecessary cast.
3048         * tui/tui-data.c (init_win_info, tui_del_window)
3049         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3050         (free_content_elements): Remove unnecessary cast.
3051         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3052         unnecessary cast.
3053         * tui/tui-source.c (tui_set_source_content)
3054         (tui_vertical_source_scroll): Remove unnecessary cast.
3055         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3056         cast.
3057         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3058         * tui/tui-regs.c (tui_display_registers_from)
3059         (tui_display_register): Remove unnecessary cast.
3060         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3061         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3062         (make_visible): Remove unnecessary cast.
3063         * tui/tui-winsource.c (tui_erase_source_content)
3064         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3065         unnecessary cast.
3066         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3067         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3068         * stabsread.c (read_type, read_array_type, read_range_type):
3069         Remove unnecessary cast.
3070         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3071         (parse_symbol, parse_type, upgrade_type, parse_external)
3072         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3073         unnecessary cast.
3074         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3075
3076 2019-06-16  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-data.c (tui_alloc_generic_win_info)
3079         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3080         checks.
3081
3082 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3083             Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * f-typeprint.c (f_print_type): Don't return early for not
3086         associated or not allocated types.
3087         (f_type_print_varspec_suffix): Add print_rank parameter and print
3088         ranks of array types in case they dangling.
3089         (f_type_print_base): Add print_rank parameter.
3090
3091 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3092
3093         * NEWS: Mention new MI commands.
3094         * break-catch-throw.c (enum exception_event_kind): Move to
3095         breakpoint.h.
3096         (print_mention_exception_catchpoint): Output text as a single
3097         message.
3098         (catch_exception_command_1): Rename to...
3099         (catch_exception_event): ...this, make non-static, update header
3100         command, and change some parameter types.
3101         (catch_catch_command): Update for changes to
3102         catch_exception_command_1.
3103         (catch_throw_command): Likewise.
3104         (catch_rethrow_command): Likewise.
3105         * breakpoint.c (enum exception_event_kind): Delete.
3106         * breakpoint.h (enum exception_event_kind): Moved here from
3107         break-catch-throw.c.
3108         (catch_exception_event): Declare.
3109         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3110         (mi_cmd_catch_throw): New function.
3111         (mi_cmd_catch_rethrow): New function.
3112         (mi_cmd_catch_catch): New function.
3113         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3114         'catch-catch' entries.
3115         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3116         (mi_cmd_catch_rethrow): Declare.
3117         (mi_cmd_catch_catch): Declare.
3118
3119 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3120
3121         * annotate.c (annotate_source_line): Change return type to void,
3122         update implementation to match.
3123         * annotate.h (annotate_source_line): Change return type to void,
3124         update header comment.
3125         * stack.c (print_frame_info): Don't change what frame information
3126         is printed based on whether annotations are on or not.
3127
3128 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3129
3130         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3131         (annotate_source): Make static.
3132         (annotate_source_line): Moved from source.c and renamed from
3133         identify_source_line.  Update the return type.
3134         * annotate.h (annotate_source): Delete declaration.
3135         (annotate_source_line): Declaration moved from source.h, and
3136         renamed from identify_source_line.  Return type updated.
3137         * source.c (identify_source_line): Moved to annotate.c and renamed
3138         to annotate_source_line.
3139         (info_line_command): Remove check of annotation_level.
3140         * source.h (identify_source_line): Move declaration to annotate.h
3141         and rename to annotate_source_line.
3142         * stack.c: Add 'annotate.h' include.
3143         (print_frame_info): Remove check of annotation_level before
3144         calling annotate_source_line.
3145
3146 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3147
3148         * source-cache.c (source_cache::get_plain_source_lines): Use
3149         open_source_file_with_line_charpos instead of just
3150         open_source_file, remove call to find_source_lines.
3151         (source_cache::get_source_lines): Likewise.
3152         * source.c (find_source_lines): Make static.
3153         (get_filename_and_charpos): Renamed into...
3154         (open_source_file_with_line_charpos): ..this along with changes to
3155         return a scoped_fd, and some other minor clean ups.
3156         (identify_source_line): Use open_source_file_with_line_charpos.
3157         (search_command_helper): Use open_source_file_with_line_charpos
3158         instead of just open_source_file, remove call to
3159         find_source_lines.
3160         * source.h (open_source_file_with_line_charpos): Declare new
3161         function.
3162         (find_source_lines): Delete declaration.
3163
3164 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3165
3166         * source.c (get_filename_and_charpos): Remove fullname
3167         parameter.
3168         (identify_source_line): Update call to get_filename_and_charpos.
3169
3170 2019-06-14  Tom Tromey  <tromey@adacore.com>
3171
3172         PR gdb/24502:
3173         * ui-style.h (skip_ansi_escape): Update comment.
3174         * ui-file.h (class no_terminal_escape_file): New class.
3175         * ui-file.c (no_terminal_escape_file::write)
3176         (no_terminal_escape_file::puts): New methods.
3177         * cli/cli-logging.c (handle_redirections): Use
3178         no_terminal_escape_file.
3179
3180 2019-06-14  Tom Tromey  <tromey@adacore.com>
3181
3182         * NEWS: Move convenience variable news above Python news.
3183
3184 2019-06-14  Tom Tromey  <tom@tromey.com>
3185
3186         * gnulib: Move directory to top-level.
3187         * configure.ac: Don't configure gnulib.
3188         * configure: Rebuild.
3189         * common/common-defs.h: Use new path to gnulib.
3190         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3191         (GNULIB_H): Remove.
3192         (INCGNU): Look in new gnulib location.
3193         (HFILES_NO_SRCDIR): Remove gnulib files.
3194         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3195         (generated_files): Remove GNULIB_H.
3196         ($(LIBGNU), all-lib): Remove targets.
3197         (distclean): Don't mention GNULIB_BUILDDIR.
3198         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3199
3200 2019-06-14  Tom Tromey  <tromey@adacore.com>
3201
3202         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3203         Warn if symbol file does not provide any symbols.
3204
3205 2019-06-14  Tom Tromey  <tromey@adacore.com>
3206
3207         * source.c (find_and_open_source): Respect basenames_may_differ.
3208
3209 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3210
3211         * annotate.c (annotate_breakpoints_invalid): Make use of
3212         scoped_restore_terminal_state.
3213         (annotate_frames_invalid): Likewise.
3214
3215 2019-06-14  Tom Tromey  <tromey@adacore.com>
3216
3217         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3218         allow assignment to an internalvar.
3219
3220 2019-06-14  Tom Tromey  <tromey@adacore.com>
3221
3222         * ada-lex.l: Allow "_" in attribute names.
3223
3224 2019-06-14  Tom Tromey  <tromey@adacore.com>
3225
3226         PR gdb/24653:
3227         * regcache.c (registers_changed): Don't call alloca.
3228         * top.c (execute_command): Don't call alloca.
3229
3230 2019-06-13  Pedro Alves  <palves@redhat.com>
3231
3232         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3233         'expression'.  When parsing an expression, error out if there's
3234         junk after "unlimited".
3235         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3236         (do_set_command): Adjust calls to is_unlimited_literal.
3237
3238 2019-06-13  Pedro Alves  <palves@redhat.com>
3239
3240         * compile/compile.c (make_compile_options_def_group): Add braces
3241         around array_view initializer.
3242         * thread.c (make_thread_apply_all_options_def_group)
3243         (make_thread_apply_all_options_def_group): Likewise.
3244
3245 2019-06-13  Pedro Alves  <palves@redhat.com>
3246
3247         * NEWS (New commands): Mention "maint test-options
3248         require-delimiter", "maint test-options unknown-is-error", "maint
3249         test-options unknown-is-operand" and "maint show
3250         test-options-completion-result".
3251         (New command options, command completion): New section.
3252         (Completion improvements): New section.
3253         Mention that you can abbreviate "unlimited".
3254
3255 2019-06-13  Pedro Alves  <palves@redhat.com>
3256
3257         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3258         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3259         * unittests/cli-utils-selftests.c (test_parse_flags)
3260         (test_parse_flags_qcs): Delete.
3261         (test_cli_utils): Don't call deleted functions.
3262
3263 2019-06-13  Pedro Alves  <palves@redhat.com>
3264
3265         * thread.c: Include "cli/cli-option.h".
3266         (tp_array_compar_ascending): Global.
3267         (tp_array_compar): Delete function.
3268         (tp_array_compar_ascending, tp_array_compar_descending): New
3269         functions.
3270         (ascending_option_def, qcs_flag_option_def)
3271         (thr_qcs_flags_option_defs)
3272         (make_thread_apply_all_options_def_group)
3273         (make_thread_apply_options_def_group): New.
3274         (thread_apply_all_command): Use gdb::option::process_options.
3275         (thread_apply_command_completer)
3276         (thread_apply_all_command_completer): New.
3277         (thread_apply_command): Use gdb::option::process_options.
3278         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3279         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3280         to generate help text of "thread apply".  Adjust "taas"'s help.
3281         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3282         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3283
3284 2019-06-13  Pedro Alves  <palves@redhat.com>
3285
3286         * thread.c (thread_apply_command): Check for invalid TID with
3287         isdigit instead of !isalpha.
3288
3289 2019-06-13  Pedro Alves  <palves@redhat.com>
3290
3291         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3292         (validate_flags_qcs): New.
3293         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3294         (validate_flags_qcs): Declare.
3295         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3296         (make_frame_apply_options_def_group): New.
3297         (frame_apply_command_count): Process options with
3298         gdb::option::process_options.
3299         (frame_apply_completer): New.
3300         (frame_apply_level_completer, frame_apply_all_completer)
3301         (frame_apply_completer): New.
3302         (_initialize_stack): Update help of "frame apply", "frame apply
3303         level", "frame apply all" and "faas" to mention supported options
3304         and install command completers.
3305         * stack.h (frame_apply_all_completer): Declare.
3306         * thread.c: Include "stack.h".
3307         (tfaas_command): Add "--".
3308         (_initialize_thread): Update help "tfaas" to mention supported
3309         options and install command completer.
3310
3311 2019-06-13  Pedro Alves  <palves@redhat.com>
3312
3313         * completer.c (complete_nested_command_line): New.
3314         (gdb_completion_word_break_characters_throw): Add assertion.
3315         * completer.h (complete_nested_command_line): Declare.
3316
3317 2019-06-13  Pedro Alves  <palves@redhat.com>
3318
3319         * stack.c (parse_backtrace_qualifiers): New.
3320         (backtrace_command): Use it.
3321         (backtrace_command_completer): Complete on qualifiers.
3322
3323 2019-06-13  Pedro Alves  <palves@redhat.com>
3324
3325         * frame.c: Include "cli/cli-option.h.
3326         (user_set_backtrace_options): New.
3327         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3328         Delete.
3329         (get_prev_frame): Adjust.
3330         (boolean_option_def, uinteger_option_def)
3331         (set_backtrace_option_defs): New.
3332         (_initialize_frame): Adjust and use
3333         gdb::option::add_setshow_cmds_for_options to install "set
3334         backtrace past-main" and "set backtrace past-entry".
3335         * frame.h: Include "cli/cli-option.h".
3336         (struct frame_print_options): Forward declare.
3337         (print_frame_arguments_all, print_frame_arguments_scalars)
3338         (print_frame_arguments_none): Declare.
3339         (print_entry_values): Delete declaration.
3340         (struct frame_print_options, user_frame_print_options): New.
3341         (struct set_backtrace_options): New.
3342         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3343         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3344         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3345         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3346         (list_args_or_locals): Add frame_print_options parameter.
3347         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3348         * python/py-framefilter.c (enumerate_args): Pass down
3349         USER_FRAME_PRINT_OPTIONS.
3350         * stack.c: Include "cli/cli-option.h".
3351         (print_frame_arguments_all, print_frame_arguments_scalars)
3352         (print_frame_arguments_none): Declare.
3353         (print_raw_frame_arguments, print_entry_values): Delete.
3354         (user_frame_print_options): New.
3355         (boolean_option_def, enum_option_def, frame_print_option_defs):
3356         New.
3357         (struct backtrace_cmd_options): New.
3358         (bt_flag_option_def): New.
3359         (backtrace_command_option_defs): New.
3360         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3361         (print_frame_arg, read_frame_arg, print_frame_args)
3362         (print_frame_info, print_frame): Add frame_print_options parameter
3363         and use it.
3364         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3365         (backtrace_command_1): Add frame_print_options and
3366         backtrace_cmd_options parameters and use them.
3367         (make_backtrace_options_def_group): New.
3368         (backtrace_command): Process command options with
3369         gdb::option::process_options.
3370         (backtrace_command_completer): New.
3371         (_initialize_stack): Extend "backtrace"'s help to mention
3372         supported options.  Install completer for "backtrace".
3373         Install some settings commands with add_setshow_cmds_for_options.
3374
3375 2019-06-13  Pedro Alves  <palves@redhat.com>
3376
3377         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3378         and that "set/show print raw frame-arguments" are now deprecated.
3379
3380         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3381         command.
3382         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3383         * stack.c (_initialize_stack): Install "set/show print
3384         raw-frame-arguments", and deprecate "set/show print raw
3385         frame-arguments".
3386         * valprint.c (_initialize_valprint): Deprecate "set/show print
3387         raw".
3388
3389 2019-06-13  Pedro Alves  <palves@redhat.com>
3390
3391         * compile/compile.c (struct compile_options): New.
3392         (compile_flag_option_def, compile_command_option_defs)
3393         (make_compile_options_def_group): New.
3394         (compile_file_command): Handle options with
3395         gdb::option::process_options.
3396         (compile_file_command_completer): New function.
3397         (compile_code_command): Handle options with
3398         gdb::option::process_options.
3399         (compile_code_command_completer): New function.
3400         (_initialize_compiler): Install completers for "compile code" and
3401         "compile file".  Mention available options in "compile code" and
3402         "compile code"'s help.
3403         * completer.c (advance_to_completion_word): New, factored out from
3404         ...
3405         (advance_to_expression_complete_word_point): ... this.
3406         (advance_to_filename_complete_word_point): New.
3407         * completer.h (advance_to_filename_complete_word_point): New
3408         declaration.
3409
3410 2019-06-13  Pedro Alves  <palves@redhat.com>
3411
3412         * compile/compile.c: Include "cli/cli-option.h".
3413         (compile_print_value): Scope data pointer is now a
3414         value_print_options pointer; adjust.
3415         (compile_print_command): Process options.  Scope data pointer is
3416         now a value_print_options pointer; adjust.
3417         (_initialize_compile): Update "compile print"'s help to include
3418         supported options.  Install a completer for "compile print".
3419         * cp-valprint.c (show_vtblprint, show_objectprint)
3420         (show_static_field_print): Delete.
3421         (_initialize_cp_valprint): Don't install "set print
3422         static-members", "set print vtbl", "set print object" here.
3423         * printcmd.c: Include "cli/cli-option.h" and
3424         "common/gdb_optional.h".
3425         (print_command_parse_format): Rework to fill in a
3426         value_print_options instead of a format_data.
3427         (print_value): Change parameter type from format_data pointer to
3428         value_print_options reference.  Adjust.
3429         (print_command_1): Process options.  Adjust to pass down a
3430         value_print_options.
3431         (print_command_completer): New.
3432         (_initialize_printcmd): Install print_command_completer as
3433         handle_brkchars completer for the "print" command.  Update
3434         "print"'s help to include supported options.
3435         * valprint.c: Include "cli/cli-option.h".
3436         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3437         here from cp-valprint.c.
3438         (boolean_option_def, uinteger_option_def)
3439         (value_print_option_defs, make_value_print_options_def_group):
3440         New.  Use gdb::option::add_setshow_cmds_for_options to install
3441         "set print elements", "set print null-stop", "set print repeats",
3442         "set print pretty", "set print union", "set print array", "set
3443         print address", "set print symbol", "set print array-indexes".
3444         * valprint.h: Include <string> and "cli/cli-option.h".
3445         (make_value_print_options_def_group): Declare.
3446         (print_value): Change parameter type from format_data pointer to
3447         value_print_options reference.
3448         (print_command_completer): Declare.
3449
3450 2019-06-13  Pedro Alves  <palves@redhat.com>
3451
3452         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3453         (COMMON_SFILES): Add maint-test-settings.c.
3454         * cli/cli-decode.c (boolean_enums): New global, factored out from
3455         ...
3456         (add_setshow_boolean_cmd): ... here.
3457         * cli/cli-decode.h (boolean_enums): Declare.
3458         * cli/cli-option.c: New file.
3459         * cli/cli-option.h: New file.
3460         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3461         factored out from ...
3462         (parse_cli_boolean_value(const char *)): ... this.
3463         (is_unlimited_literal): Change parameter type to pointer to
3464         pointer.  Adjust and advance ARG pointer.
3465         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3466         (parse_cli_var_enum): New, factored out from ...
3467         (do_set_command): ... this.  Adjust.
3468         * cli/cli-setshow.h (parse_cli_boolean_value)
3469         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3470         (parse_cli_var_enum): Declare.
3471         * cli/cli-utils.c: Include "cli/cli-option.h".
3472         (get_ulongest): New.
3473         * cli/cli-utils.h (get_ulongest): Declare.
3474         (check_for_argument): New overloads.
3475         * maint-test-options.c: New file.
3476
3477 2019-06-13  Pedro Alves  <palves@redhat.com>
3478
3479         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3480         parse a range if "-" is at the end of the string.
3481
3482 2019-06-13  Pedro Alves  <palves@redhat.com>
3483
3484         * cli/cli-setshow.c (parse_auto_binary_operation)
3485         (parse_cli_boolean_value): Don't allow "o".
3486
3487 2019-06-13  Pedro Alves  <palves@redhat.com>
3488
3489         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3490         * NEWS: Mention maint test-settings KIND.
3491         * maint-test-settings.c: New file.
3492
3493 2019-06-13  Pedro Alves  <palves@redhat.com>
3494
3495         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3496         completer.
3497         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3498         "set" completers.
3499
3500 2019-06-13  Pedro Alves  <palves@redhat.com>
3501
3502         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3503         after item.
3504
3505 2019-06-13  Pedro Alves  <palves@redhat.com>
3506
3507         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3508
3509 2019-06-13  Pedro Alves <palves@redhat.com>
3510
3511         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3512         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3513         call.
3514         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3515         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3516         calls.
3517         (check_for_argument): Skip spaces after argument.
3518
3519 2019-06-13  Pedro Alves  <palves@redhat.com>
3520
3521         * thread.c (thread_apply_command): Adjust TID parsing.
3522         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3523         detected before end of string.
3524         (tid_is_in_list): Error out if LIST is invalid.
3525
3526 2019-06-13  Pedro Alves  <palves@redhat.com>
3527
3528         * completer.c (complete_line_internal_1): Rewind completion word
3529         point.
3530         (completion_tracker::advance_custom_word_point_by): Change
3531         parameter type to int.
3532         * completer.h (completion_tracker::advance_custom_word_point_by):
3533         Likewise.
3534
3535 2019-06-13  Pedro Alves  <palves@redhat.com>
3536
3537         * completer.c (advance_to_completion_word): Handle delimiters.
3538
3539 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3540
3541         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3542
3543 2019-06-11  Tom Tromey  <tom@tromey.com>
3544
3545         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3546         (xmalloc_failed): Move to alloc.c.
3547         * alloc.c: New file.
3548         * Makefile.in (COMMON_SFILES): Add alloc.c.
3549
3550 2019-06-11  Tom Tromey  <tom@tromey.com>
3551
3552         * nat/linux-waitpid.c: Don't include server.h.
3553         (linux_debug): Remove.
3554         (my_waitpid): Update.
3555
3556 2019-06-11  Tom Tromey  <tromey@adacore.com>
3557
3558         * infcall.c (_initialize_infcall): Remove trailing newline from
3559         help.
3560         * user-regs.c (_initialize_user_regs): Remove trailing newline
3561         from help.
3562         * typeprint.c (_initialize_typeprint): Remove trailing newline
3563         from help.
3564         * reverse.c (_initialize_reverse): Remove trailing newlines from
3565         help.
3566         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3567         from help.
3568         * language.c (add_set_language_command): Remove trailing newline
3569         from help.
3570         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3571         help.
3572         * disasm.c (_initialize_disasm): Remove trailing newline from
3573         help.
3574         * top.c (init_main): Remove trailing newline from help.
3575         * interps.c (_initialize_interpreter): Remove trailing newline
3576         from help.
3577         * btrace.c (_initialize_btrace): Remove trailing newlines from
3578         help.
3579         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3580         from help.
3581         * python/python.c (_initialize_python): Remove trailing newline
3582         from help.
3583         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3584         help.
3585         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3586         from help.  Reformat some text.
3587         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3588         from help.
3589         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3590         newline from help.
3591
3592 2019-06-11  Tom Tromey  <tromey@adacore.com>
3593
3594         * darwin-nat.c (darwin_decode_exception_message)
3595         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3596
3597 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3598
3599         * valops.c (value_slice): Check for not allocated or not
3600         associated values.
3601
3602 2019-06-10  Tom de Vries  <tdevries@suse.de>
3603
3604         PR gdb/24618
3605         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3606         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3607         invalid.
3608
3609 2019-06-10  Tom de Vries  <tdevries@suse.de>
3610
3611         PR gdb/24611
3612         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3613         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3614
3615 2019-06-10  Tom de Vries  <tdevries@suse.de>
3616
3617         PR symtab/24545
3618         * symtab.c (struct demangled_name_entry): Add language field.
3619         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3620         static minimal symbol".  Set and use language field.
3621
3622 2019-06-10  Tom Tromey  <tromey@adacore.com>
3623
3624         * ada-lang.c (_initialize_ada_language): Update help text.
3625
3626 2019-06-10  Tom Tromey  <tromey@adacore.com>
3627
3628         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3629         with a newline.
3630         * guile/guile.c (handle_boot_error): Don't end warning with a
3631         newline.
3632         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3633         warning with a newline.
3634         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3635         newline.
3636         (s12z_frame_cache): Likewise.
3637         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3638         a newline.
3639         * solib-svr4.c (disable_probes_interface): Don't end warning with
3640         a newline.
3641         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3642         newline.
3643         * python/python.c (do_finish_initialization): Don't end warning
3644         with a newline.
3645
3646 2019-06-10  Tom Tromey  <tom@tromey.com>
3647
3648         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3649         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3650         gdbpy_enter.
3651
3652 2019-06-10  Tom Tromey  <tromey@adacore.com>
3653
3654         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3655         data.
3656         (elf_new_init): Don't call stabsread_new_init.
3657         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3658         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3659         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3660
3661 2019-06-10  Tom de Vries  <tdevries@suse.de>
3662
3663         PR symtab/16264
3664         PR symtab/24517
3665         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3666
3667 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3668
3669         * source.c (find_and_open_source): Also rewrite relative file
3670         names.
3671
3672 2019-04-26  Amos Bird  <amosbird@gmail.com>
3673
3674         * annotate.c (annotate_thread_exited): Add "thread-exited"
3675         annotation.
3676
3677 2019-06-06  Tom Tromey  <tromey@adacore.com>
3678
3679         * maint.h (class scoped_command_stats): Use
3680         DISABLE_COPY_AND_ASSIGN.
3681         <print_time>: New method.
3682         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3683         print_time.
3684         (scoped_command_stats::print_time): New method.
3685
3686 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3687
3688         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3689         instructions of lengths 6 or 8 bytes.
3690
3691 2019-06-04  Pedro Alves  <palves@redhat.com>
3692
3693         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3694
3695         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3696         * breakpoint.c (condition_completer): Likewise.
3697         * cli/cli-dump.c (scan_expression): Likewise.
3698         * common/filestuff.c (mkdir_recursive): Likewise.
3699         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3700         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3701         (gdb_abspath): Likewise.
3702         * compile/compile-cplus-types.c
3703         (compile_cplus_instance::decl_name): Likewise.
3704         * completer.c (complete_explicit_location):
3705         (signal_completer, reg_or_group_completer_1): Likewise.
3706         * cp-support.c (cp_remove_params_if_any): Likewise.
3707         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3708         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3709         * infcmd.c (strip_bg_char): Likewise.
3710         * linespec.c (copy_token_string): Likewise.
3711         * mi/mi-main.c (output_cores): Likewise.
3712         * psymtab.c (psymtab_search_name):
3713         * symfile.c (test_set_ext_lang_command): Likewise.
3714         * target.c (target_fileio_read_stralloc): Likewise.
3715         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3716         * value.c (complete_internalvar): Likewise.
3717
3718 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3719
3720         Add objfile property to gdb.Type.
3721         * NEWS: Mention Python API addition.
3722         * python/py-type.c (typy_get_objfile): New method.
3723
3724 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3725
3726         * NEWS: Mention the new set|show style [title|highlight].
3727         Mention changes to "show style", "help" and "apropos".
3728
3729 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3730
3731         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3732         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3733         instead of print_help_for_command.
3734         (print_doc_of_command): New function.
3735         (help_list): Add 'apropos -v word' suggestion.
3736         (print_help_for_command): Style the command name using title style.
3737         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3738         (_initialize_cli_cmds): Describe -v in apropos_command help.
3739
3740 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3741
3742         * cli/cli-style.h (cli_style_option): Add name in constructor,
3743         add m_name class member, add constructor with intensity,
3744         add name class function.
3745         (cli_style_option::add_setshow_commands): Remove name argument.
3746         (highlight_style, title_style): New styles.
3747         * cli/cli-style.c (do_show): New function that shows a style
3748         characteristic styling the style name with itself.
3749         (set_style_name): New function.
3750         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3751         Update all callers according to the changes in cli/cli-style.h.
3752         * utils.h (fputs_highlighted): New function.
3753         * utils.c (fputs_highlighted): Likewise.
3754
3755 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3756
3757         * NEWS: Mention new pipe command and new convenience variables.
3758
3759 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3760
3761         * cli/cli-cmds.c (pipe_command): New function.
3762         (_initialize_cli_cmds): Call add_com for pipe_command.
3763         Define | as an alias for pipe.
3764         (exit_status_set_internal_vars): New function.
3765         (shell_escape): Call exit_status_set_internal_vars.
3766         cli/cli-decode.c (find_command_name_length): Recognize | as
3767         a single character command.
3768
3769 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3770
3771         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3772         top.c (execute_command_to_ui_file): New function, mostly a copy
3773         of execute_command_to_string.
3774         (execute_command_to_string): Implement by calling
3775         execute_command_to_ui_file.
3776
3777 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3778
3779         * top.h (saved_command_line): Remove declaration.
3780         * top.c (previous_saved_command_line, previous_repeat_arguments):
3781         New variables.
3782         (saved_command_line): Make static, define together with other
3783         'repeat variables'.
3784         (dont_repeat): Clear repeat_arguments.
3785         (repeat_previous, get_saved_command_line, save_command_line):
3786         New functions.
3787         (gdb_init): Initialize saved_command_line
3788         and previous_saved_command_line.
3789         * main.c (captured_main_1): Remove saved_command_line initialization.
3790         * event-top.c (handle_line_of_input): Update to use
3791         the new 'repeat' related functions instead of direct access to
3792         saved_command_line.
3793         * command.h (repeat_previous, get_saved_command_line,
3794         save_command_line): New declarations.
3795         (dont_repeat): Add comment.
3796
3797 2019-05-30  Tom Tromey  <tromey@adacore.com>
3798
3799         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3800         Fix comment.
3801         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3802
3803 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3804
3805         PR cli/24587
3806         * completer.c (complete): Initialize variable word.
3807
3808 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3809
3810         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3811         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3812         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3813         'body' is NULL to the outter 'if', protecting the '!is_define'
3814         situation as well.
3815
3816 2019-05-29  Tom Tromey  <tromey@adacore.com>
3817
3818         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3819         (dwarf_unknown): New function.
3820         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3821         (dwarf_type_encoding_name): Use dwarf_unknown.
3822
3823 2019-05-29  Tom Tromey  <tromey@adacore.com>
3824
3825         PR c++/20020:
3826         * cp-valprint.c (cp_print_value_fields): Call
3827         cp_print_static_field inside "try".
3828
3829 2019-05-29  Tom Tromey  <tromey@adacore.com>
3830
3831         * inflow.c (struct terminal_info): Add default operator=.
3832         * configure: Rebuild.
3833         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3834         -Wdeprecated-copy-dtor, -Wredundant-move.
3835
3836 2019-05-29  Tom Tromey  <tromey@adacore.com>
3837
3838         * NEWS: Add entry.
3839         * infcmd.c (print_return_value_1): Handle finish_print
3840         option.
3841         (show_print_finish): New function.
3842         (_initialize_infcmd): Add "set/show print finish" commands.
3843         * valprint.c (user_print_options): Initialize new member.
3844         * valprint.h (struct value_print_options) <finish_print>: New
3845         member.
3846
3847 2019-05-28  Tom Tromey  <tromey@adacore.com>
3848
3849         * ada-lang.c (ada_remove_Xbn_suffix)
3850         (find_old_style_renaming_symbol)
3851         (parse_old_style_renaming): Remove.
3852         (ada_find_renaming_symbol): Don't call
3853         find_old_style_renaming_symbol.
3854         (ada_is_renaming_symbol): Rename from
3855         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3856         bool.  Now static.
3857         (ada_read_var_value): Update and simplify.
3858         * ada-exp.y (write_var_or_type): Remove old code.
3859
3860 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3861
3862         * event-top.c: Remove include comment.
3863         * inflow.c (class scoped_ignore_sigttou): Move from here...
3864         * inflow.h (class scoped_ignore_sigttou): ...to here.
3865         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3866         * top.c:  Remove include comment.
3867
3868 2019-05-27  Tom Tromey  <tom@tromey.com>
3869
3870         * NEWS: Fix typo.
3871
3872 2019-05-22  Tom Tromey  <tromey@adacore.com>
3873
3874         * target.c (target_follow_exec): Constify parameter.
3875         * target-delegates.c: Rebuild.
3876         * remote.c (remote_target::follow_exec): Constify parameter.
3877         * infrun.c (follow_exec): Constify parameter.
3878         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3879         (target_follow_exec): Likewise.
3880
3881 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3882
3883         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3884         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3885
3886 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3887
3888         * NEWS: Add debugredirect and testsuite sections.
3889
3890 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3891
3892         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3893         target descriptions using exclusively floating point register name
3894         aliases.
3895
3896 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         PR gdb/18644:
3899         * f-lang.c (build_fortran_types): Handle the case where
3900         gdbarch_floatformat_for_type returns a nullptr.
3901
3902 2019-05-21  Tom de Vries  <tdevries@suse.de>
3903
3904         PR cli/24587
3905         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3906
3907 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         PR gdb/18644:
3910         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3911         16-byte floats.
3912         * i386-tdep.c (i386_floatformat_for_type): Use
3913         floatformats_ia64_quad for the 16-byte floating point component
3914         within a fortran 32-byte complex number.
3915
3916 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3917
3918         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3919         delete default constructor.
3920         (find_partial_die): Update to return const struct.
3921         (partial_die_parent_scope): Move variable declaration into scope
3922         of its use and change its type to auto.
3923         (guess_partial_die_structure_name): Likewise.
3924         (partial_die_info::fixup): Likewise.
3925
3926 2019-05-17  Tom Tromey  <tromey@adacore.com>
3927
3928         * source.c (find_and_open_source): Remove cast.
3929
3930 2019-05-17  Tom Tromey  <tromey@adacore.com>
3931
3932         * annotate.c (annotate_source): Make "filename" const.
3933         * annotate.h (annotate_source): Use const.
3934
3935 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3936
3937         * disasm.c (set_disassembler_options): Send errors to stderr.
3938
3939 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3940
3941         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3942         (cli_interp_base::set_logging): Check debug_redirect.
3943         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3944         * cli/cli-logging.c (debug_redirect): Add static variable.
3945         (pop_output_files): Add default param.
3946         (handle_redirections): Print debug setting.
3947         (show_logging_command): Likewise.
3948         (_initialize_cli_logging): Add debugredirect command.
3949         * interps.c (current_interp_set_logging): Add debug_redirect
3950         parameter.
3951         * interps.h (set_logging): Add debug_redirect parameter.
3952         (current_interp_set_logging): Likewise.
3953         * mi/mi-common.h: Likewise.
3954         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3955
3956 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3957             Tom Tromey  <tromey@adacore.com>
3958
3959         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3960         directly.
3961         * cli/cli-interp.h (make_logging_output): Remove declaration.
3962         * cli/cli-logging.c (make_logging_output): Remove function.
3963         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3964         directly.
3965         * ui-file.c (tee_file::tee_file): Remove bools.
3966         (tee_file::~tee_file): Remove deletes.
3967         * ui-file.h (tee_file): Remove bools.
3968
3969 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3970
3971         * mi/mi-cmds.h (mi_cmd_complete): New function.
3972         * mi/mi-main.c (mi_cmd_complete): Likewise.
3973         * mi/mi-cmds.c: Define new MI command -complete.
3974         * NEWS: Mention new -complete command.
3975
3976 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3977
3978         * completer.h (complete): New function.
3979         * completer.c (complete): Likewise.
3980         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3981         function defined in completer.h.
3982
3983 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3984
3985         * MAINTAINERS (Write After Approval): Add myself.
3986
3987 2019-05-17  Tom de Vries  <tdevries@suse.de>
3988
3989         PR gdb/24094
3990         * dwarf2read.c (struct cu_partial_die_info): New struct.
3991         (find_partial_die): Return cu_partial_die_info.
3992         (partial_die_parent_scope, guess_partial_die_structure_name)
3993         (partial_die_info::fixup): Handle new return type of find_partial_die.
3994
3995 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3996
3997         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3998         "std::string", simplifying the algorithm.
3999
4000 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4001
4002         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4003         (stap_static_probe_ops::get_probes): Likewise.
4004
4005 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4006
4007         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4008         '-')" and "else if".
4009         (stap_parse_single_operand): Join checks for
4010         "gdbarch_stap_parse_special_token_p" and
4011         "gdbarch_stap_parse_special_token" in the same "if" statement.
4012         Invert check when verifying for operation on register
4013         displacement.
4014
4015 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4016
4017         * stap-probe.c (stap_get_opcode): Update comment.
4018         (stap_get_expected_argument_type): Likewise.
4019         (handle_stap_probe): Likewise.
4020
4021 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4022
4023         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4024         return type to 'bool'.  Adjust comment.  Use 'bool' when
4025         appropriate.
4026         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4027         * stap-probe.c (stap_parse_argument_1): Likewise.
4028         (stap_is_operator): Likewise.
4029         (stap_is_generic_prefix): Likewise.
4030         (stap_is_register_prefix): Likewise.
4031         (stap_is_register_indirection_prefix): Likewise.
4032         (stap_is_integer_prefix): Likewise.
4033         (stap_generic_check_suffix): Likewise.
4034         (stap_check_integer_suffix): Likewise.
4035         (stap_check_register_suffix): Likewise.
4036         (stap_check_register_indirection_suffix): Likewise.
4037         (stap_parse_register_operand): Likewise.
4038         (stap_parse_single_operand): Likewise.
4039         (stap_parse_argument_1): Likewise.
4040         (stap_probe::get_argument_count): Likewise.
4041         (stap_is_operator): Likewise.
4042
4043 2019-05-16  Tom Tromey  <tromey@adacore.com>
4044
4045         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4046         keyword to foreach.
4047
4048 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4049
4050         * linux-thread-db.c (try_thread_db_load_1): Change return type
4051         to bool.
4052         (try_thread_db_load): Likewise.
4053         (try_thread_db_load_from_pdir_1): Likewise.
4054         (try_thread_db_load_from_pdir): Likewise.
4055         (try_thread_db_load_from_sdir): Likewise.
4056         (try_thread_db_load_from_dir): Likewise.
4057         (thread_db_load_search): Likewise.
4058         (has_libpthread): Likewise.
4059         (thread_db_load): Likewise.
4060
4061 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4062
4063         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4064         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4065         NULL, and complain/return if that's the case.
4066
4067 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4068
4069         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4070         (advance, posn, abstract_read_memory): New functions.
4071         [struct mem_read_abstraction]: New struct.
4072         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4073
4074 2019-05-14  Tom Tromey  <tromey@adacore.com>
4075
4076         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4077         value is not lval_memory.
4078
4079 2019-05-14  Tom Tromey  <tromey@adacore.com>
4080
4081         * solib.c (info_sharedlibrary_command): Style the file name.
4082
4083 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4084
4085         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4086         (aarch64_vnv_type): Likewise.
4087         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4088         * common/tdesc.c: Likewise.
4089         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4090         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4091         * features/aarch64-fpu.xml: Add ieee half view.
4092         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4093         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4094         * gdbtypes.h (struct builtin_type): Likewise.
4095         (struct objfile_type): Likewise.
4096
4097 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4098
4099         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4100         typo.
4101         * location.h (string_to_event_location): Likewise.
4102
4103 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4104
4105         GDB 8.3 released.
4106
4107 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4108
4109         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4110         New variable declaration.
4111         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4112         New variable.
4113         (print_one_breakpoint): Use ui_out::test_flags and new global
4114         variable to compute use_fixed_output.
4115         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4116         Remove.
4117         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4118         (mi_multi_location_breakpoint_output_fixed): Remove.
4119         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4120         new variable.
4121         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4122         fix_multi_location_breakpoint_output flag if version >= 3.
4123         * ui-out.h (enum ui_out_flag)
4124         <fix_multi_location_breakpoint_output>: New enumerator.
4125
4126 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4127
4128         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4129
4130 2019-05-10  Tom Tromey  <tromey@adacore.com>
4131
4132         * ada-lang.c (catch_ada_completer): New function.
4133         (_initialize_ada_language): Use it.
4134
4135 2019-05-10  Tom Tromey  <tromey@adacore.com>
4136
4137         * thread.c (print_thread_info): Make "requested_threads" const.
4138         * gdbthread.h (print_thread_info): Make "requested_threads"
4139         const.
4140         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4141         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4142
4143 2019-05-08  Tom Tromey  <tom@tromey.com>
4144
4145         * gdbtypes.c (objfile_type_data): Change type.
4146         (objfile_type, _initialize_gdbtypes): Update.
4147
4148 2019-05-08  Tom Tromey  <tom@tromey.com>
4149
4150         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4151         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4152         (_initialize_dwarf2_frame): Update.
4153
4154 2019-05-08  Tom Tromey  <tom@tromey.com>
4155
4156         * objc-lang.c (objc_objfile_data): Change type.
4157         (find_methods): Update.
4158         (_initialize_objc_lang): Remove.
4159
4160 2019-05-08  Tom Tromey  <tom@tromey.com>
4161
4162         * stabsread.c (rs6000_builtin_type_data): Change type.
4163         (rs6000_builtin_type, _initialize_stabsread): Update.
4164
4165 2019-05-08  Tom Tromey  <tom@tromey.com>
4166
4167         * mips-tdep.c (mips_pdr_data): Remove.
4168         (_initialize_mips_tdep): Update.
4169
4170 2019-05-08  Tom Tromey  <tom@tromey.com>
4171
4172         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4173         (hppa_init_objfile_priv_data, read_unwind_info)
4174         (find_unwind_entry, _initialize_hppa_tdep): Update.
4175
4176 2019-05-08  Tom Tromey  <tom@tromey.com>
4177
4178         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4179         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4180         on obstack.
4181         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4182
4183 2019-05-08  Tom Tromey  <tom@tromey.com>
4184
4185         * mdebugread.c (basic_type_data): Change type.
4186         (basic_type, _initialize_mdebugread): Update.
4187
4188 2019-05-08  Tom Tromey  <tom@tromey.com>
4189
4190         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4191
4192 2019-05-08  Tom Tromey  <tom@tromey.com>
4193
4194         * nto-tdep.c (nto_inferior_data_reg): Change type.
4195         (nto_inferior_data): Update.
4196         (nto_inferior_data_cleanup, nto_new_inferior_data)
4197         (_initialize_nto_tdep): Remove.
4198         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4199
4200 2019-05-08  Tom Tromey  <tom@tromey.com>
4201
4202         * ada-lang.c (struct ada_inferior_data): Add initializers.
4203         (ada_inferior_data): Change type.
4204         (ada_inferior_data_cleanup): Remove.
4205         (get_ada_inferior_data, ada_inferior_exit)
4206         (struct ada_pspace_data): Add initializers, destructor.
4207         (ada_pspace_data_handle): Change type.
4208         (get_ada_pspace_data): Update.
4209         (ada_pspace_data_cleanup): Remove.
4210
4211 2019-05-08  Tom Tromey  <tom@tromey.com>
4212
4213         * coffread.c (struct coff_symfile_info): Add initializers.
4214         (coff_objfile_data_key): Move lower.  Change type.
4215         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4216         Update.
4217         (coff_free_info): Remove.
4218
4219 2019-05-08  Tom Tromey  <tom@tromey.com>
4220
4221         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4222         (fbsd_pspace_data_handle): Move lower.  Change type.
4223         (get_fbsd_pspace_data): Update.
4224         (fbsd_pspace_data_cleanup): Remove.
4225         (_initialize_fbsd_tdep): Update.
4226
4227 2019-05-08  Tom Tromey  <tom@tromey.com>
4228
4229         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4230         (get_ada_tasks_pspace_data): Update.
4231         (ada_tasks_pspace_data_cleanup): Remove.
4232         (_initialize_tasks): Update.
4233         (ada_tasks_inferior_data_handle): Change type.
4234         (get_ada_tasks_inferior_data): Update.
4235         (ada_tasks_inferior_data_cleanup): Remove.
4236         (struct ada_tasks_pspace_data): Add initializers.
4237
4238 2019-05-08  Tom Tromey  <tom@tromey.com>
4239
4240         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4241         * symfile-debug.c (debug_sym_get_probes): Change type.
4242         * stap-probe.c (handle_stap_probe):
4243         (stap_static_probe_ops::get_probes): Change type.
4244         * probe.h (class static_probe_ops) <get_probes>: Change type.
4245         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4246         (parse_probes_in_pspace): Update.
4247         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4248         Update.
4249         (any_static_probe_ops::get_probes): Change type.
4250         * elfread.c (elfread_data): New typedef.
4251         (probe_key): Change type.
4252         (elf_get_probes): Likewise.  Update.
4253         (probe_key_free): Remove.
4254         (_initialize_elfread): Update.
4255         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4256         Change type.
4257         (dtrace_process_dof_probe, dtrace_process_dof)
4258         (dtrace_static_probe_ops::get_probe): Change type.
4259
4260 2019-05-08  Tom Tromey  <tom@tromey.com>
4261
4262         * xcoffread.c (struct xcoff_symfile_info): Rename from
4263         coff_symfile_info.  Add initializers.
4264         (xcoff_objfile_data_key): Move lower.  Change type.
4265         (XCOFF_DATA): Rewrite.
4266         (xcoff_free_info): Remove.
4267         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4268         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4269         (xcoff_initial_scan): Update.
4270
4271 2019-05-08  Tom Tromey  <tom@tromey.com>
4272
4273         * solib-svr4.c (struct svr4_info): Add initializers and
4274         destructor.
4275         <probes_table>: Now an htab_up.
4276         (solib_svr4_pspace_data): Change type.
4277         (free_probes_table): Simplify.
4278         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4279         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4280         (probes_table_remove_objfile_probes, register_solib_event_probe)
4281         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4282         (_initialize_svr4_solib): Update.
4283
4284 2019-05-08  Tom Tromey  <tom@tromey.com>
4285
4286         * remote.c (remote_pspace_data): Change type.
4287         (remote_pspace_data_cleanup): Remove.
4288         (get_remote_exec_file, set_pspace_remote_exec_file)
4289         (_initialize_remote): Update.
4290
4291 2019-05-08  Tom Tromey  <tom@tromey.com>
4292
4293         * breakpoint.c (breakpoint_objfile_key): Change type.
4294         (get_breakpoint_objfile_data): Update.
4295         (free_breakpoint_objfile_data): Remove.
4296         (_initialize_breakpoint): Update.
4297
4298 2019-05-08  Tom Tromey  <tom@tromey.com>
4299
4300         * linux-tdep.c (struct linux_info): Add initializers.
4301         (linux_inferior_data): Move.  Change type.
4302         (invalidate_linux_cache_inf): Update.
4303         (linux_inferior_data_cleanup): Remove.
4304         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4305
4306 2019-05-08  Tom Tromey  <tom@tromey.com>
4307
4308         * auxv.c (auxv_inferior_data): Move.  Change type.
4309         (auxv_inferior_data_cleanup): Remove.
4310         (invalidate_auxv_cache_inf): Rewrite.
4311         (get_auxv_inferior_data, _initialize_auxv): Update.
4312
4313 2019-05-08  Tom Tromey  <tom@tromey.com>
4314
4315         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4316         (symfile_debug_objfile_data_key): Change type.
4317         (symfile_debug_installed, debug_qf_has_symbols)
4318         (debug_qf_find_last_source_symtab)
4319         (debug_qf_forget_cached_source_info)
4320         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4321         (debug_qf_print_stats, debug_qf_dump)
4322         (debug_qf_expand_symtabs_for_function)
4323         (debug_qf_expand_all_symtabs)
4324         (debug_qf_expand_symtabs_with_fullname)
4325         (debug_qf_map_matching_symbols)
4326         (debug_qf_expand_symtabs_matching)
4327         (debug_qf_find_pc_sect_compunit_symtab)
4328         (debug_qf_map_symbol_filenames)
4329         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4330         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4331         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4332         (debug_sym_read_linetable, debug_sym_relocate): Update.
4333         (symfile_debug_free_objfile): Remove.
4334         (install_symfile_debug_logging, _initialize_symfile_debug):
4335         Update.
4336
4337 2019-05-08  Tom Tromey  <tom@tromey.com>
4338
4339         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4340         allocate_on_obstack.
4341         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4342         (get_dwarf2_per_objfile): Update.
4343         (set_dwarf2_per_objfile): Remove.
4344         (dwarf2_has_info, dwarf2_get_section_info): Update.
4345         (dwarf2_free_objfile): Remove.
4346         (_initialize_dwarf2_read): Update.
4347
4348 2019-05-08  Tom Tromey  <tom@tromey.com>
4349
4350         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4351         initializers.
4352         <unsupported_script_warning_printed,
4353         script_not_found_warning_printed>: Now bool.
4354         (auto_load_pspace_data): Change type.
4355         (~auto_load_pspace_info): Rename from
4356         auto_load_pspace_data_cleanup.
4357         (get_auto_load_pspace_data, init_loaded_scripts_info)
4358         (clear_section_scripts, maybe_print_unsupported_script_warning)
4359         (maybe_print_script_not_found_warning, _initialize_auto_load):
4360         Update.
4361
4362 2019-05-08  Tom Tromey  <tom@tromey.com>
4363
4364         * objfiles.c (objfile_pspace_info): Add destructor and
4365         initializers.
4366         (objfiles_pspace_data): Change type.
4367         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4368         (get_objfile_pspace_data): Update.
4369         (objfiles_bfd_data): Change type.
4370         (get_objfile_bfd_data): Update.
4371         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4372
4373 2019-05-08  Tom Tromey  <tom@tromey.com>
4374
4375         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4376         Change type.
4377         (get_catch_syscall_inferior_data): Update.
4378         (catch_syscall_inferior_data_cleanup): Remove.
4379         (_initialize_break_catch_syscall): Update.
4380
4381 2019-05-08  Tom Tromey  <tom@tromey.com>
4382
4383         * inflow.c (struct terminal_info): Add destructor and
4384         initializers.
4385         (inflow_inferior_data): Change type.
4386         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4387         (get_inflow_inferior_data, inflow_inferior_exit)
4388         (swap_terminal_info, _initialize_inflow): Update.
4389
4390 2019-05-08  Tom Tromey  <tom@tromey.com>
4391
4392         * target-dcache.c (target_dcache_cleanup): Remove.
4393         (target_dcache_aspace_key): Change type.
4394         (target_dcache_init_p, target_dcache_invalidate)
4395         (target_dcache_get, target_dcache_get_or_init)
4396         (_initialize_target_dcache): Update.
4397         * dcache.h (struct dcache_deleter): New.
4398
4399 2019-05-08  Tom Tromey  <tom@tromey.com>
4400
4401         * symtab.c (struct symbol_cache): Add destructor and
4402         initializers.
4403         (symbol_cache_key): Move.  Change type.
4404         (make_symbol_cache, free_symbol_cache): Remove.
4405         (get_symbol_cache): Update.
4406         (symbol_cache_cleanup): Remove.
4407         (ALL_PSPACES, symbol_cache_flush)
4408         (maintenance_print_symbol_cache)
4409         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4410         Update.
4411
4412 2019-05-08  Tom Tromey  <tom@tromey.com>
4413
4414         * symtab.c (struct main_info): Add destructor and initializers.
4415         (main_progspace_key): Move.  Change type.
4416         (get_main_info): Update.
4417         (main_info_cleanup): Remove.
4418         (_initialize_symtab): Update.
4419
4420 2019-05-08  Tom Tromey  <tom@tromey.com>
4421
4422         * registry.h (DECLARE_REGISTRY): Define the _key class.
4423
4424 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4425
4426         * NEWS: Merge two 'New commands' sections.
4427
4428 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4429
4430         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4431         parameter and use Ada language definition instead.
4432         (ada_val_print_ptr): Remove unused language parameter.
4433         (ada_val_print_num): Remove language parameter and use Ada language
4434         definition instead.
4435         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4436         parameter.
4437         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4438         parameter and use Ada language definition instead.
4439         (ada_val_print_1): Update all ada_val_print_xxx calls.
4440         Remove language parameter.
4441         (ada_val_print): Update ada_val_print_1 call.
4442
4443 2019-05-08  Tom Tromey  <tromey@adacore.com>
4444
4445         * remote.c (remote_hw_watchpoint_limit)
4446         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4447         Now static.
4448
4449 2019-05-08  Tom Tromey  <tromey@adacore.com>
4450
4451         * maint.c (_initialize_maint_cmds): Move initialization code to
4452         remote.c.
4453         (watchdog, show_watchdog): Move to remote.c.
4454         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4455         "watchdog" static.
4456         (_initialize_remote): Move initialization code from maint.c.
4457         * defs.h (watchdog): Don't declare.
4458
4459 2019-05-08  Tom Tromey  <tromey@adacore.com>
4460
4461         * tui/tui-interp.c: Include main.h.
4462         * interps.c: Include main.h.
4463         * main.h (interpreter_p): Declare.
4464         * defs.h (interpreter_p): Don't declare.
4465
4466 2019-05-08  Tom Tromey  <tromey@adacore.com>
4467
4468         * dwarf2loc.c: Include dwarf2read.h.
4469         * defs.h (read_unsigned_leb128): Don't declare.
4470         * dwarf2read.h (read_unsigned_leb128): Declare.
4471
4472 2019-05-08  Tom Tromey  <tromey@adacore.com>
4473
4474         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4475         method.
4476
4477 2019-05-08  Tom Tromey  <tromey@adacore.com>
4478
4479         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4480         when no wrap column is set.
4481
4482 2019-05-08  Tom Tromey  <tromey@adacore.com>
4483
4484         * c-lang.c (c_get_string): Handle non-C-style arrays.
4485
4486 2019-05-08  Tom Tromey  <tromey@adacore.com>
4487
4488         * typeprint.c (print_offset_data::update): Print the bit offset,
4489         not the number of bits remaining.
4490
4491 2019-05-08  Tom Tromey  <tromey@adacore.com>
4492
4493         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4494         padding at end of comment.
4495
4496 2019-05-08  Tom Tromey  <tromey@adacore.com>
4497
4498         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4499         Compare main types.
4500
4501 2019-05-06  Tom Tromey  <tom@tromey.com>
4502
4503         * common/scoped_mmap.c: Include common-defs.h.
4504         * common/scoped_mmap.h: Don't include config.h.
4505
4506 2019-05-04  Tom Tromey  <tom@tromey.com>
4507
4508         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4509         (struct aarch64_call_info): Add initializers.
4510         <si>: Now a std::vector.
4511         (pass_on_stack, aarch64_push_dummy_call): Update.
4512
4513 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4514             Tom Tromey  <tom@tromey.com>
4515
4516         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4517         (ppc_threads): Now a std::vector.  Now static.
4518         (hwdebug_find_thread_points_by_tid)
4519         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4520         Update.
4521
4522 2019-05-04  Tom Tromey  <tom@tromey.com>
4523
4524         * arc-tdep.c (arc_tdesc_init): Return bool.
4525
4526 2019-05-04  Tom Tromey  <tom@tromey.com>
4527
4528         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4529         Use gdb_assert_not_reached.
4530
4531 2019-05-04  Tom Tromey  <tom@tromey.com>
4532
4533         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4534         "false".
4535
4536 2019-05-04  Tom Tromey  <tom@tromey.com>
4537
4538         * arc-tdep.c (arc_tdesc_init): Use bool.
4539
4540 2019-05-04  Tom Tromey  <tom@tromey.com>
4541
4542         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4543
4544 2019-05-04  Tom Tromey  <tom@tromey.com>
4545
4546         * cli/cli-cmds.c (valid_command_p): Return bool.
4547
4548 2019-05-04  Tom Tromey  <tom@tromey.com>
4549
4550         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4551         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4552
4553 2019-05-04  Raul Tambre  <raul@tambre.ee>
4554
4555         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4556         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4557         operator for comparison.
4558
4559 2019-05-04  Tom Tromey  <tom@tromey.com>
4560
4561         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4562         (lookup_partial_symbol, print_partial_symbols)
4563         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4564         (psymbol_compare): Update.
4565         (add_psymbol_to_bcache): Clear the entire psymbol.
4566         (maintenance_check_psymtabs): Update.
4567         * psympriv.h (struct partial_symbol): Don't derive from
4568         general_symbol_info.
4569         <obj_section, unrelocated_address, address,
4570         set_unrelocated_address>: Update.
4571         <ginfo>: New member.
4572         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4573         (debug_names::write_psymbols): Update.
4574
4575 2019-05-04  Tom de Vries  <tdevries@suse.de>
4576
4577         * contrib/cc-with-tweaks.sh: Support -n arg.
4578
4579 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4580
4581         * corelow.c (core_target::detach): Ensure frame cache and
4582         register caches are cleared.
4583         inferior.c (exit_inferior_1): Likewise.
4584
4585 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4586             Tom Tromey  <tom@tromey.com>
4587
4588         * dictionary.c (collate_pending_symbols_by_language): Remove
4589         "struct" from foreach.
4590         * symtab.c (lookup_global_symbol_from_objfile)
4591         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4592         foreach.
4593         * ser-tcp.c (net_open): Remove "struct" from foreach.
4594         * objfiles.c (objfile_relocate, objfile_rebase)
4595         (objfile_has_symbols): Remove "struct" from foreach.
4596         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4597         from foreach.
4598         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4599         foreach.
4600         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4601         "struct" from foreach.
4602         * ada-lang.c (create_excep_cond_exprs)
4603         (ada_exception_catchpoint_cond_string): Remove "struct" from
4604         foreach.
4605
4606 2019-05-03  Tom Tromey  <tromey@adacore.com>
4607
4608         * ada-exp.y (convert_char_literal): Check suffix of each
4609         enumerator.
4610
4611 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4612
4613         PR ada/21406:
4614         * ada-exp.y (yywrap): Don't define.
4615         * ada-lex.l (%option): Add noyywrap
4616         (yywrap): Remove.
4617
4618 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4619
4620         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4621         _WIN32_WINNT to the XP level, unless already defined to a higher
4622         level.
4623
4624         * unittests/parse-connection-spec-selftests.c:
4625         * ser-tcp.c:
4626         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4627         override.
4628
4629         * symfile.c (find_separate_debug_file): Remove colon from the
4630         drive spec of DOS/Windows file names of the target, so that the
4631         file name produced from DEBUGDIR and the target's directory will
4632         be valid on DOS/Windows systems.
4633
4634 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * rust-lang.c (val_print_struct): Handle printing structures
4637         containing strings.
4638
4639 2019-05-02  Tom Tromey  <tromey@adacore.com>
4640
4641         * valarith.c (_initialize_valarith): Remove.
4642
4643 2019-05-01  Tom Tromey  <tromey@adacore.com>
4644
4645         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4646         bitfields.
4647
4648 2019-05-01  Tom Tromey  <tromey@adacore.com>
4649
4650         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4651         for big-endian copies.
4652
4653 2019-04-30  Ali Tamur  <tamur@google.com>
4654         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4655         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4656         (read_3_bytes): New function.
4657
4658 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4659
4660         * windows-nat.c (main_thread_id): Delete.
4661         (handle_output_debug_string): Replace main_thread_id by
4662         current_event.dwThreadId.
4663         (fake_create_process): Likewise.
4664         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4665         Do not set main_thread_id.
4666         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4667         current_event.dwThreadId.
4668         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4669
4670 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4671
4672         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4673         Use current_event.dwThreadId instead of main_thread_id.
4674
4675 2019-04-30  Tom Tromey  <tromey@adacore.com>
4676
4677         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4678         (create_excep_cond_exprs): Iterate over program spaces.
4679         (ada_exception_catchpoint_cond_string): Examine all minimal
4680         symbols for exception types.
4681
4682 2019-04-30  Tom Tromey  <tromey@adacore.com>
4683
4684         PR c++/24470:
4685         * dwarf2read.c (process_structure_scope): Handle case where type
4686         has template parameters but no symbol was created.
4687
4688 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4689             Chris January  <chris.january@arm.com>
4690
4691         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4692         qualifier.
4693         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4694
4695 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4696
4697         * f-typeprint.c (f_print_type): Update rules for printing
4698         whitespace.
4699         (f_type_print_varspec_suffix): Likewise.
4700
4701 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4702             Chris January  <chris.january@arm.com>
4703
4704         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4705         function arguments.
4706
4707 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4708
4709         * f-lang.c (build_fortran_types): Change name of void type to
4710         lower case.
4711         * f-typeprint.c (f_type_print_base): Print the name of the void
4712         type, rather than a fixed string.
4713         * f-valprint.c (f_decorations): Use lower case void string.
4714
4715 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4716             Chris January  <chris.january@arm.com>
4717
4718         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4719         types for Fortran.
4720
4721 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4722             Chris January  <chris.january@arm.com>
4723             David Lecomber  <david.lecomber@arm.com>
4724
4725         * f-exp.y (BINOP_INTRINSIC): New token.
4726         (exp): New parser rule handling BINOP_INTRINSIC.
4727         (f77_keywords): Add new builtin procedures.
4728         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4729         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4730         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4731         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4732         (print_unop_subexp_f): New function.
4733         (print_binop_subexp_f): New function.
4734         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4735         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4736         (dump_subexp_body_f): Likewise.
4737         (operator_check_f): Likewise.
4738         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4739         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4740
4741 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4742
4743         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4744         UNOP_KIND.
4745         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4746         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4747         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4748         (operator_length_f): New fuction.
4749         (print_subexp_f): New function.
4750         (op_name_f): New function.
4751         (dump_subexp_body_f): New function.
4752         (operator_check_f): New function.
4753         (exp_descriptor_f): Replace standard expression handling functions
4754         with new functions.
4755         * gdb/fortran-operator.def: New file.
4756         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4757         * gdb/std-operator.def: Remove UNOP_KIND.
4758
4759 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4760
4761         * std-operator.def: Remove unbalanced, stray double quote
4762         character.
4763
4764 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4765             Chris January  <chris.january@arm.com>
4766             Daniel Everett  <daniel.everett@arm.com>
4767             Nick Forrington  <nick.forrington@arm.com>
4768             Richard Bunt  <richard.bunt@arm.com>
4769
4770         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4771         of depth when printing anonymous structs or unions.
4772         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4773         Don't print either the top-level value, or the children if the
4774         max-depth is exceeded.
4775         (ppscm_print_children): When printing the key of a map, allow one
4776         extra level of depth.
4777         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4778         print either the top-level value, or the children if the max-depth
4779         is exceeded.
4780         (print_children): When printing the key of a map, allow one extra
4781         level of depth.
4782         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4783         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4784         (user_print_options): Initialise max_depth field.
4785         (val_print_scalar_or_string_type_p): New function.
4786         (val_print): Check to see if the max depth has been reached.
4787         (val_print_check_max_depth): Define new function.
4788         (show_print_max_depth): New function.
4789         (_initialize_valprint): Add 'print max-depth' option.
4790         * valprint.h (struct value_print_options) <max_depth>: New field.
4791         (val_print_check_max_depth): Declare new function.
4792         * NEWS: Document new feature.
4793
4794 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * ada-lang.c (ada_language_defn): Initialise new field.
4797         * c-lang.c (c_is_string_type_p): New function.
4798         (c_language_defn): Initialise new field.
4799         (cplus_language_defn): Initialise new field.
4800         (asm_language_defn): Initialise new field.
4801         (minimal_language_defn): Initialise new field.
4802         * c-lang.h (c_is_string_type_p): Declare new function.
4803         * d-lang.c (d_language_defn): Initialise new field.
4804         * f-lang.c (f_is_string_type_p): New function.
4805         (f_language_defn): Initialise new field.
4806         * go-lang.c (go_is_string_type_p): New function.
4807         (go_language_defn): Initialise new field.
4808         * language.c (default_is_string_type_p): New function.
4809         (unknown_language_defn): Initialise new field.
4810         (auto_language_defn): Initialise new field.
4811         * language.h (struct language_defn) <la_is_string_type_p>: New
4812         member variable.
4813         (default_is_string_type_p): Declare new function.
4814         * m2-lang.c (m2_language_defn): Initialise new field.
4815         * objc-lang.c (objc_language_defn): Initialise new field.
4816         * opencl-lang.c (opencl_language_defn): Initialise new field.
4817         * p-lang.c (pascal_is_string_type_p): New function.
4818         (pascal_language_defn): Initialise new field.
4819         * rust-lang.c (rust_is_string_type_p): New function.
4820         (rust_language_defn): Initialise new field.
4821
4822 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4825         New field.
4826         * ada-lang.c (ada_language_defn): Initialise new field.
4827         * c-lang.c (c_language_defn): Likewise.
4828         (cplus_language_defn): Likewise.
4829         (asm_language_defn): Likewise.
4830         (minimal_language_defn): Likewise.
4831         * d-lang.c (d_language_defn): Likewise.
4832         * f-lang.c (f_language_defn): Likewise.
4833         * go-lang.c (go_language_defn): Likewise.
4834         * language.c (unknown_language_defn): Likewise.
4835         (auto_language_defn): Likewise.
4836         * m2-lang.c (m2_language_defn): Likewise.
4837         * objc-lang.c (objc_language_defn): Likewise.
4838         * opencl-lang.c (opencl_language_defn): Likewise.
4839         * p-lang.c (pascal_language_defn): Likewise.
4840         * rust-lang.c (rust_language_defn): Likewise.
4841
4842 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4843
4844         * ada-lang.c (ada_is_character_type): Change return type to bool.
4845         (ada_is_string_type): Likewise.
4846         * ada-lang.h (ada_is_character_type): Update declaration
4847         (ada_is_string_type): Likewise.
4848
4849 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4850
4851         Support style in 'frame|thread apply'
4852
4853         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4854         * record.c (record_start, record_stop): Update callers of
4855         execute_command_to_string with false.
4856         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4857         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4858         methods.
4859         (class string_file): New constructor with term_out parameter.
4860         Override methods term_out and can_emit_style_escape.  New member
4861         term_out.
4862         (class stdio_file): Override can_emit_style_escape.
4863         (class tee_file): Override term_out and can_emit_style_escape.
4864         * utils.h (can_emit_style_escape): Remove.
4865         * utils.c (can_emit_style_escape): Likewise.
4866         Update all callers of can_emit_style_escape (SOMESTREAM) to
4867         SOMESTREAM->can_emit_style_escape.
4868         * source-cache.c (source_cache::get_source_lines): Likewise.
4869         * stack.c (frame_apply_command_count): Call execute_command_to_string
4870         passing the term_out characteristic of the current gdb_stdout.
4871         * thread.c (thr_try_catch_cmd): Likewise.
4872         * top.c (execute_command_to_string): pass term_out parameter
4873         to construct the string_file for the command output.
4874         * ui-file.c (term_cli_styling): New function (most code moved
4875         from utils.c can_emit_style_escape).
4876         (string_file::string_file, string_file::can_emit_style_escape,
4877         stdio_file::can_emit_style_escape, tee_file::term_out,
4878         tee_file::can_emit_style_escape): New functions.
4879
4880 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4881
4882         * NEWS: Mention the new set|show may-call-functions.
4883         * infcall.c (may_call_functions_p): New variable.
4884         (show_may_call_functions_p): New function.
4885         (call_function_by_hand_dummy): Throws an error if not
4886         may-call-functions.
4887         (_initialize_infcall): Call add_setshow_boolean_cmd for
4888         may-call-functions.
4889
4890 2019-04-25  Keith Seitz  <keiths@redhat.com>
4891
4892         PR c++/24367
4893         * cp-support.c (inspect_type): Don't attempt substitutions
4894         of symbol with the same name.
4895
4896 2019-04-25  Tom Tromey  <tromey@adacore.com>
4897
4898         PR gdb/24475:
4899         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4900         static.
4901
4902 2019-04-25  Tom Tromey  <tromey@adacore.com>
4903
4904         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4905         rvalue reference.
4906         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4907         (gdb_xml_parser::parse): Use std::move.
4908         * python/python-internal.h (gdbpy_convert_exception): Take a const
4909         reference.
4910         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4911         std::move.
4912         * python/py-utils.c (gdbpy_convert_exception): Take a const
4913         reference.
4914         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4915         Use std::move.
4916         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4917         Use std::move.
4918         * mi/mi-main.c (mi_print_exception): Take a const reference.
4919         * main.c (handle_command_errors): Take a const reference.
4920         * linespec.c (parse_linespec): Use std::move.
4921         * infcall.c (run_inferior_call): Use std::move.
4922         (call_function_by_hand_dummy): Use std::move.
4923         * exec.c (try_open_exec_file): Use std::move.
4924         * exceptions.h (exception_print, exception_fprintf)
4925         (exception_print_same): Update.
4926         * exceptions.c (print_exception, exception_print)
4927         (exception_fprintf, exception_print_same): Change parameters to
4928         const reference.
4929         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4930         * common/new-op.c: Use std::move.
4931         * common/common-exceptions.h (struct gdb_exception): Add move
4932         constructor.
4933         (struct gdb_exception_error, struct gdb_exception_quit, struct
4934         gdb_quit_bad_alloc): Change constructor to move constructor.
4935         (throw_exception): Change parameter to rvalue reference.
4936         * common/common-exceptions.c (throw_exception): Take rvalue
4937         reference.
4938         * cli/cli-interp.c (safe_execute_command): Use std::move.
4939         * breakpoint.c (insert_bp_location, location_to_sals): Use
4940         std::move.
4941
4942 2019-04-25  Tom Tromey  <tromey@adacore.com>
4943
4944         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4945         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4946         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4947         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4948         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4949         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4950         guile/scm-value.c: Use unpack.
4951         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4952         gdbscm_gdb_exception.
4953         (gdbscm_throw_gdb_exception): Likewise.
4954         (struct gdbscm_gdb_exception): New.
4955         (unpack): New function.
4956         (gdbscm_wrap): Use unpack.
4957
4958 2019-04-25  Tom Tromey  <tromey@adacore.com>
4959
4960         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4961         (gdb_rl_callback_handler): Use std::move.
4962         * common/common-exceptions.h (struct gdb_exception): Add move
4963         assignment operator.
4964         (throw_exception_sjlj): Change "exception" to const reference.
4965         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4966         (throw_exception_sjlj): Change "exception" to const reference.
4967
4968 2019-04-25  Tom Tromey  <tromey@adacore.com>
4969
4970         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4971         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4972         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4973         Update.
4974         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4975         Update.
4976         * mi/mi-interp.c (mi_interp::exec): Update.
4977         * linespec.c (parse_linespec): Update.
4978         * infcall.c (run_inferior_call): Update.
4979         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4980         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4981         (gdbscm_lookup_global_symbol): Update.
4982         * guile/scm-param.c (gdbscm_parameter_value): Update.
4983         * guile/scm-frame.c (gdbscm_frame_read_register)
4984         (gdbscm_frame_read_var): Update.
4985         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4986         * exec.c (try_open_exec_file): Update.
4987         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4988         (gdb_rl_callback_handler): Update.
4989         * common/common-exceptions.h (exception_none): Don't declare.
4990         * common/common-exceptions.c (exception_none): Don't define.
4991         (struct catcher) <exception>: Update.
4992         * cli/cli-interp.c (safe_execute_command): Update.
4993         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4994
4995 2019-04-25  Ali Tamur  <tamur@google.com>
4996
4997         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4998         (read_attribute_value): Likewise.
4999         (dwarf2_read_addr_index): Update comment.
5000         (read_str_index): Add DW_FORM_strx.
5001         (dwarf2_string_attr): Likewise.
5002         (dwarf2_const_value_attr): Likewise.
5003         (dump_die_shallow): Likewise.
5004         (dwarf2_fetch_constant_bytes): Likewise.
5005         (skip_form_bytes): Likewise.
5006         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5007
5008 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5009
5010         PR corefiles/11608
5011         PR corefiles/18187
5012         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5013         OFFSET.  Verify if current mapping contains an ELF header.
5014         (linux_find_memory_regions_full): Adjust call to
5015         dump_mapping_p.
5016
5017 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5018             Kang Li <kanglictf@gmail.com>
5019
5020         PR gdb/21600
5021
5022         * dwarf2-frame.c (read_initial_length): Be consistent about using
5023         unsigned representation of length.
5024         (decode_frame_entry_1): Likewise.  Check for wraparound of
5025         end pointer as well as buffer overflow.
5026
5027 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5028
5029         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5030         "vq".
5031
5032 2019-04-24  Tom Tromey  <tromey@adacore.com>
5033
5034         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5035
5036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5037
5038         * s12z-tdep.c (s12z_unwind_pc): Delete.
5039         (s12z_unwind_sp): Delete.
5040         (s12z_gdbarch_init): Don't register deleted functions with
5041         gdbarch.
5042
5043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5044
5045         * rl78-tdep.c (rl78_unwind_sp): Delete.
5046         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5047
5048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5049
5050         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5051         (xstormy16_unwind_pc): Delete.
5052         (xstormy16_dummy_id): Delete.
5053         (xstormy16_gdbarch_init): Don't register deleted functions with
5054         gdbarch.
5055
5056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5057
5058         * vax-tdep.c (vax_unwind_pc): Delete.
5059         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5060
5061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5062
5063         * v850-tdep.c (v850_unwind_sp): Delete.
5064         (v850_unwind_pc): Delete.
5065         (v850_dummy_id): Delete.
5066         (v850_gdbarch_init): Don't register deleted functions with
5067         gdbarch.
5068
5069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5070
5071         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5072         (tilegx_unwind_pc): Delete.
5073         (tilegx_unwind_dummy_id): Delete.
5074         (tilegx_gdbarch_init): Don't register deleted functions with
5075         gdbarch.
5076
5077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5078
5079         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5080         (tic6x_dummy_id): Delete.
5081         (tic6x_gdbarch_init): Don't register deleted functions with
5082         gdbarch.
5083
5084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * sparc-tdep.c (sparc_unwind_pc): Delete.
5087         (sparc32_gdbarch_init): Don't register deleted function with
5088         gdbarch.
5089
5090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5091
5092         * sh-tdep.c (sh_unwind_sp): Delete.
5093         (sh_unwind_pc): Delete.
5094         (sh_dummy_id): Delete.
5095         (sh_gdbarch_init): Don't register deleted functions with
5096         gdbarch.
5097
5098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5099
5100         * score-tdep.c (score_unwind_sp): Delete.
5101         (score_unwind_pc): Delete.
5102         (score_dummy_id): Delete.
5103         (score_gdbarch_init): Don't register deleted functions with
5104         gdbarch.
5105
5106 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * rx-tdep.c (rx_unwind_pc): Delete.
5109         (rx_unwind_sp): Delete.
5110         (rx_dummy_id): Delete.
5111         (rx_gdbarch_init): Don't register deleted functions with
5112         gdbarch.  Update comment.
5113
5114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5117         (rs6000_dummy_id): Delete.
5118         (rs6000_gdbarch_init): Don't register deleted functions with
5119         gdbarch.
5120
5121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5122
5123         * or1k-tdep.c (or1k_dummy_id): Delete.
5124         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5125
5126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * nios2-tdep.c (nios2_dummy_id): Delete.
5129         (nios2_unwind_sp): Delete.
5130         (nios2_gdbarch_init): Don't register deleted functions with
5131         gdbarch.
5132
5133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5134
5135         * nds32-tdep.c (nds32_dummy_id): Delete.
5136         (nds32_unwind_pc): Delete.
5137         (nds32_unwind_sp): Delete.
5138         (nds32_gdbarch_init): Don't register deleted functions with
5139         gdbarch.
5140
5141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5142
5143         * msp430-tdep.c (msp430_unwind_pc): Delete.
5144         (msp430_unwind_sp): Delete.
5145         (msp430_dummy_id): Delete.
5146         (msp430_gdbarch_init): Don't register deleted functions with
5147         gdbarch.
5148
5149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * moxie-tdep.c (moxie_unwind_sp): Delete.
5152         (moxie_unwind_pc): Delete.
5153         (moxie_dummy_id): Delete.
5154         (moxie_gdbarch_init): Don't register deleted functions with
5155         gdbarch.
5156
5157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5160         (mn10300_unwind_pc): Delete.
5161         (mn10300_unwind_sp): Delete.
5162         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5163         mn10300_unwind_sp.
5164         (mn10300_frame_unwind_init): Don't register deleted functions with
5165         gdbarch.
5166
5167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5168
5169         * mep-tdep.c (mep_unwind_pc): Delete.
5170         (mep_unwind_sp): Delete.
5171         (mep_dummy_id): Delete.
5172         (mep_gdbarch_init): Don't register deleted functions with
5173         gdbarch.
5174
5175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5176
5177         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5178         (m68hc11_unwind_sp): Delete.
5179         (m68hc11_gdbarch_init): Don't register deleted functions with
5180         gdbarch.
5181
5182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5183
5184         * m32r-tdep.c (m32r_unwind_sp): Delete.
5185         (m32r_unwind_pc): Delete.
5186         (m32r_dummy_id): Delete.
5187         (m32r_gdbarch_init): Don't register deleted functions with
5188         gdbarch.
5189
5190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5191
5192         * m32c-tdep.c (m32c_unwind_pc): Delete.
5193         (m32c_unwind_sp): Delete.
5194         (m32c_dummy_id): Delete.
5195         (m32c_gdbarch_init): Don't register deleted functions with
5196         gdbarch.
5197
5198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5199
5200         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5201         (lm32_unwind_pc): Delete.
5202         (lm32_dummy_id): Delete.
5203         (lm32_gdbarch_init): Don't register deleted functions with
5204         gdbarch.
5205
5206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5207
5208         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5209         (iq2000_unwind_pc): Delete.
5210         (iq2000_dummy_id): Delete.
5211         (iq2000_gdbarch_init): Don't register deleted functions with
5212         gdbarch.
5213
5214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5215
5216         * nds32-tdep.c (nds32_type_align): Delete.
5217         (nds32_push_dummy_call): Use type_align instead.
5218
5219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5220
5221         * arm-tdep.c (arm_type_align): Only handle vector override case.
5222         (arm_push_dummy_call): Use type_align.
5223         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5224
5225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5226
5227         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5228         case.
5229         (pass_on_stack): Use type_align.
5230         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5231         function.
5232
5233 2019-04-23  Tom Tromey  <tromey@adacore.com>
5234
5235         * dwarf2read.c (line_header::file_name_at): Remove unused
5236         overload.
5237
5238 2019-04-23  Tom de Vries  <tdevries@suse.de>
5239
5240         PR gdb/24438
5241         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5242         invocation.
5243
5244
5245 2019-03-27  Ali Tamur  <tamur@google.com>
5246
5247         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5248         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5249         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5250         (dwarf_expr_context::get_addr_index): Likewise
5251         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5252         (symbol_needs_eval_context::get_addr_index): Likewise
5253         (disassemble_dwarf_expression): Add DW_OP_addrx
5254         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5255         (read_cutu_die_from_dwo): Update comment
5256         (skip_one_die): Add DW_FORM_addrx
5257         (read_attribute_value): Likewise
5258         (var_decode_location): Add DW_OP_addrx
5259         (dwarf2_const_value_attr): Add DW_FORM_addrx
5260         (dump_die_shallow): Likewise
5261         (dwarf2_fetch_constant_bytes): Likewise
5262         (decode_locdesc): Add DW_OP_addrx
5263         (skip_form_bytes): Add DW_FORM_addrx
5264
5265 2019-04-22  Ali Tamur  <tamur@google.com>
5266
5267         * MAINTAINERS (Write After Approval): Add self.
5268
5269 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5270
5271         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5272         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5273         (open_symbol_file_object): Likewise.
5274         (svr4_default_sos): Add info parameter.
5275         (svr4_read_so_list): Likewise.
5276         (svr4_current_sos_direct): Adjust functions calls to pass down
5277         info.
5278         (svr4_current_sos_1): Add info parameter.
5279         (svr4_current_sos): Call get_svr4_info, pass info down to
5280         svr4_current_sos_1.
5281         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5282         get_svr4_info.
5283         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5284         get_svr4_info.
5285         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5286         to get_svr4_info.
5287         (probes_table_remove_objfile_probes): Likewise.
5288         (register_solib_event_probe): Add info parameter.
5289         (solist_update_incremental): Pass info parameter down to
5290         svr4_read_so_list.
5291         (disable_probes_interface): Add info parameter.
5292         (svr4_handle_solib_event): Pass current_program_space to
5293         get_svr4_info.  Adjust disable_probes_interface cleanup.
5294         (svr4_create_probe_breakpoints): Add info parameter, pass it
5295         down to register_solib_event_probe.
5296         (svr4_create_solib_event_breakpoints): Add info parameter,
5297         pass it down to svr4_create_probe_breakpoints.
5298         (enable_break): Pass info down to
5299         svr4_create_solib_event_breakpoints.
5300         (svr4_solib_create_inferior_hook): Pass current_program_space to
5301         get_svr4_info.
5302         (svr4_clear_solib): Likewise.
5303
5304 2019-04-22  Pedro Alves  <palves@redhat.com>
5305
5306         * solib-svr4.c (svr4_free_objfile_observer): New.
5307         (probe_and_action::objfile): New field.
5308         (probes_table_htab_remove_objfile_probes)
5309         (probes_table_remove_objfile_probes): New functions.
5310         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5311         in the new probe_and_action.  Don't store the probe in 'lookup'.
5312         (svr4_create_probe_breakpoints): Pass objfile to
5313         register_solib_event_probe.
5314         (_initialize_svr4_solib): Register a free_objfile observer.
5315
5316 2019-04-19  Tom Tromey  <tom@tromey.com>
5317
5318         * common/queue.h: Remove.
5319
5320 2019-04-19  Tom Tromey  <tom@tromey.com>
5321
5322         * event-loop.c: Don't include "common/queue.h".
5323
5324 2019-04-19  Tom Tromey  <tom@tromey.com>
5325
5326         * remote.c (remote_target): Use delete.
5327         * remote-notif.h: Include <list>, not "common/queue.h".
5328         (notif_client_p): Remove typedef.
5329         (remote_notif_state): Add constructor, destructor, initializer.
5330         <notif_queue>: Now a std::list.
5331         (remote_notif_state_xfree): Don't declare.
5332         * remote-notif.c (remote_notif_process, handle_notification)
5333         (remote_notif_state_allocate): Update.
5334         (~remote_notif_state): Rename from remote_notif_state_xfree.
5335
5336 2019-04-19  Tom Tromey  <tom@tromey.com>
5337
5338         * symfile.c (reread_symbols): Update.
5339         * objfiles.c (objfile_register_static_link)
5340         (objfile_lookup_static_link): Update
5341         (~objfile) Don't delete static_links.
5342         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5343
5344 2019-04-19  Tom Tromey  <tom@tromey.com>
5345
5346         * type-stack.h (struct type_stack) <insert>: Constify string.
5347         * type-stack.c (type_stack::insert): Constify string.
5348         * gdbtypes.h (lookup_template_type): Update.
5349         (address_space_name_to_int): Update.
5350         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5351         const.
5352         (lookup_template_type): Make name const.
5353         * c-exp.y: Update rules.
5354         (lex_one_token, classify_name, classify_inner_name)
5355         (c_print_token): Update.
5356         * p-exp.y: Update rules.
5357         (yylex): Update.
5358         * f-exp.y: Update rules.
5359         (yylex): Update.
5360         * d-exp.y: Update rules.
5361         (lex_one_token, classify_name, classify_inner_name): Update.
5362         * parse.c (write_dollar_variable, copy_name): Return std::string.
5363         * parser-defs.h (copy_name): Change return type.
5364         * m2-exp.y: Update rules.
5365         (yylex): Update.
5366         * go-exp.y (lex_one_token): Update.
5367         Update rules.
5368         (classify_unsafe_function, classify_packaged_name)
5369         (classify_name, yylex): Update.
5370
5371 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5372
5373         * configure.ac: add --enable-source-highlight switch.
5374         * configure: Regenerate.
5375         * top.c (print_gdb_version): plumb --enable-source-highlight
5376         status to "show configuration".
5377
5378 2019-04-19  Tom Tromey  <tromey@adacore.com>
5379
5380         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5381         Check ADA_TYPE_P.
5382         (empty_record, ada_template_to_fixed_record_type_1)
5383         (template_to_static_fixed_type)
5384         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5385         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5386         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5387         macros.
5388
5389 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5390
5391         PR symtab/24423:
5392         * source.c (print_source_lines_base): Advance "iter" when a
5393         control character is seen.
5394
5395 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5396
5397         * inferior.h (struct infcall_suspend_state_deleter):
5398         Catch exception in destructor to avoid crash.
5399
5400 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5401
5402         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5403         close to the add_com "shell".
5404
5405 2019-04-18  Tom Tromey  <tromey@adacore.com>
5406
5407         * process-stratum-target.h (class process_stratum_target)
5408         <stratum>: Add "final".
5409
5410 2019-04-17  Tom Tromey  <tromey@adacore.com>
5411
5412         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5413         against nullptr before use.
5414
5415 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5416
5417         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5418
5419 2019-04-17  Jim Wilson  <jimw@sifive.com>
5420             Andrew Burgess  <andrew.burgess@embecosm.com>
5421
5422         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5423         code read might fail, assume 4-byte breakpoint in that case.
5424
5425 2019-04-15  Leszek Swirski  <leszeks@google.com>
5426
5427         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5428         rather than a hand-rolled POD check when checking for forced MEMORY
5429         classification.
5430
5431 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5432
5433         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5434         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5435         function.
5436         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5437         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5438         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5439         declaration.
5440
5441 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5442
5443         * aarch64-linux-nat.c
5444         (aarch64_linux_nat_target::thread_architecture): Add override.
5445         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5446         each VQ.
5447
5448 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5449
5450         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5451
5452 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5453
5454         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5455         target types of size 96-bits, add some additional comments, and
5456         check that the builtin type we found was the correct size.
5457
5458 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5459
5460         * utils.c (prompt_for_continue): Don't restore the styling at the
5461         end, as applied_style has the wrong value.  This fixes styling in
5462         long lists of file names that are interrupted by the "Continue?"
5463         prompt.
5464
5465 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5466
5467         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5468         * c-lang.c (c_language_defn): Likewise.
5469         (cplus_language_defn): Likewise.
5470         (asm_language_defn): Likewise.
5471         (minimal_language_defn): Likewise.
5472         * d-lang.c (d_language_defn): Likewise.
5473         * f-lang.c (f_language_defn): Likewise.
5474         * go-lang.c (go_language_defn): Likewise.
5475         * language.c (unknown_language_defn): Likewise.
5476         (auto_language_defn): Likewise.
5477         * language.h (struct language_defn): Remove la_magic field.
5478         (LANG_MAGIC): Delete.
5479         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5480         * objc-lang.c (objc_language_defn): Likewise.
5481         * opencl-lang.c (opencl_language_defn): Likewise.
5482         * p-lang.c (pascal_language_defn): Likewise.
5483         * rust-lang.c (rust_language_defn): Likewise.
5484
5485 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5486
5487         * riscv-tdep.c (riscv_type_align): New function.
5488         (riscv_type_alignment): Delete.
5489         (riscv_arg_location): Use 'type_align'.
5490         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5491
5492 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5493
5494         * gdbtypes.c (type_align): A struct with no non-static fields also
5495         has alignment of 1.
5496
5497 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5498
5499         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5500         component to 0.
5501         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5502         member.
5503         (riscv_struct_info::analyse): New implementation using new
5504         analyse_inner member function.
5505         (riscv_struct_info::field_offset): New member function.
5506         (riscv_struct_info::m_offsets): New member variable.
5507         (riscv_struct_info::analyse_inner): New private member function,
5508         takes the old implementation of riscv_struct_info::analyse but
5509         extended to track field offsets.
5510         (riscv_call_arg_struct): Update the struct folding special cases
5511         to handle cases where empty C++ structs, which are non-zero
5512         length, are found.
5513         (riscv_arg_location): Initialise the length of each location, a
5514         non-zero length now indicates the location is in use.
5515         (riscv_push_dummy_call): Allow for the first location having a
5516         non-zero offset when setting up arguments.
5517         (riscv_return_value): Likewise, but for return values.
5518
5519 2019-04-11  Tom Tromey  <tromey@adacore.com>
5520
5521         * utils.c (internal_vproblem): Make "msg" const.
5522
5523 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5524
5525         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5526         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5527         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5528         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5529
5530 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5531
5532         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5533         function.
5534         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5535         of amd64_collect_native_gregset.
5536         (amd64_linux_nat_target::store_registers): Likewise.
5537
5538 2019-04-10  Tom Tromey  <tom@tromey.com>
5539
5540         * symtab.c (lookup_global_symbol_from_objfile)
5541         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5542         * objfiles.h (class separate_debug_iterator): New.
5543         (class separate_debug_range): New.
5544         (struct objfile) <separate_debug_objfiles>: New method.
5545         (objfile_separate_debug_iterate): Don't declare.
5546         * objfiles.c (separate_debug_iterator::operator++): Rename from
5547         objfile_separate_debug_iterate.
5548         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5549         iterator.
5550         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5551         iterator.
5552
5553 2019-04-10  Tom Tromey  <tom@tromey.com>
5554
5555         * symfile.c (reread_symbols): Remove old comment.
5556         * objfiles.c (free_all_objfiles): Fix a typo.
5557
5558 2019-04-10  Tom Tromey  <tom@tromey.com>
5559
5560         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5561         * minsyms.c (lookup_minimal_symbol): Use foreach.
5562         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5563         (lookup_minimal_symbol_solib_trampoline): Likewise.
5564         * symfile.c (reread_symbols): Use foreach.
5565
5566 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5567             Tom Tromey  <tromey@adacore.com>
5568
5569         PR rust/24414:
5570         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5571         (rust_lex_int_test): Change "value" to be LONGEST.
5572         (rust_lex_tests): Add test for long integer literal.
5573
5574 2019-04-09  Tom Tromey  <tromey@adacore.com>
5575
5576         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5577         to bool.
5578         (extended_remote_target::attach): Update.
5579         (remote_target::remote_notice_new_inferior): Update.
5580         (remote_target::add_current_inferior_and_thread): Update.
5581         * inferior.c (exit_inferior_1): Use "false".
5582         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5583
5584 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5585
5586         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5587         the "start" command.
5588
5589 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5590
5591         * python/py-inferior.c (infpy_thread_from_thread_handle):
5592         Adjust comments to reflect renaming of thread_from_thread_handle
5593         to thread_from_handle.  Adjust keywords.  Fix type error message.
5594         (inferior_object_methods): Add thread_from_handle.  Retain
5595         thread_from_thread_handle, but mark it as deprecated.
5596
5597 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5598
5599         * gdbthread.h (find_thread_by_handle): Revise declaration.
5600         * thread.c (find_thread_by_handle): Likewise.  Adjust
5601         implementation too.
5602         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5603         support for buffer objects as handles.
5604
5605 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5606
5607         * python/py-infthread.c (thpy_thread_handle): New function.
5608         (thread_object_methods): Register thpy_thread_handle.
5609
5610 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5611
5612         * gdbthread.h (thread_to_thread_handle): Declare.
5613         * thread.c (gdbtypes.h): Include.
5614         (thread_to_thread_handle): New function.
5615
5616         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5617         (target_thread_info_to_thread_handle): Declare.
5618         * target.c (target_thread_info_to_thread_handle): New function.
5619         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5620         * target-delegates.c: Regenerate.
5621
5622         * linux-thread-db.c (class thread_db_target): Add method
5623         thread_info_to_thread_handle.
5624         (thread_db_target::thread_info_to_thread_handle): Define.
5625         * remote.c (class remote_target): Add new method
5626         thread_info_to_thread_handle.
5627         (remote_target::thread_info_to_thread_handle): Define.
5628
5629 2019-04-08  Pedro Alves  <palves@redhat.com>
5630
5631         * common/common-exceptions.c (throw_exception): Don't create
5632         named object to throw; throw directly.
5633         (throw_it): Likewise.  Don't initialize gdb_exception::message
5634         here, with new; pass FMT and AP to the ctor instead.
5635         * common/common-exceptions.h: Include <string>.
5636         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5637         const char *, va_list)): New ctor.  Use std::make_shared.
5638         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5639         errors)): Delete.
5640         (gdb_exception_error::gdb_exception_error(enum errors, const char
5641         *, va_list)): New.
5642         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5643         Add assertion.
5644         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5645         errors)): Delete.
5646         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5647         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5648         Add assertion.
5649
5650 2019-04-08  Tom Tromey  <tom@tromey.com>
5651
5652         * valops.c (value_rtti_indirect_type): Replace throw_exception
5653         with throw.
5654         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5655         with throw.
5656         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5657         throw.
5658         * target.c (target_translate_tls_address): Replace throw_exception
5659         with throw.
5660         * stack.c (frame_apply_command_count): Replace throw_exception
5661         with throw.
5662         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5663         throw.
5664         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5665         with throw.
5666         * rs6000-tdep.c (rs6000_frame_cache)
5667         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5668         * remote.c: Replace throw_exception with throw.
5669         * record-full.c (record_full_message, record_full_wait_1)
5670         (record_full_restore): Replace throw_exception with throw.
5671         * record-btrace.c:
5672         (get_thread_current_frame_id, record_btrace_start_replaying)
5673         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5674         (cmd_record_btrace_start): Replace throw_exception with throw.
5675         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5676         throw.
5677         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5678         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5679         * linespec.c:
5680         (find_linespec_symbols): Replace throw_exception with throw.
5681         * infrun.c (displaced_step_prepare, resume): Replace
5682         throw_exception with throw.
5683         * infcmd.c (post_create_inferior): Replace throw_exception with
5684         throw.
5685         * inf-loop.c (inferior_event_handler): Replace throw_exception
5686         with throw.
5687         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5688         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5689         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5690         (get_prev_frame_always, get_frame_pc_if_available)
5691         (get_frame_address_in_block_if_available, get_frame_language):
5692         Replace throw_exception with throw.
5693         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5694         throw_exception with throw.
5695         * eval.c (fetch_subexp_value, evaluate_var_value)
5696         (evaluate_funcall, evaluate_subexp_standard): Replace
5697         throw_exception with throw.
5698         * dwarf2loc.c (call_site_find_chain)
5699         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5700         Replace throw_exception with throw.
5701         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5702         with throw.
5703         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5704         throw.
5705         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5706         * completer.c (complete_line_internal): Replace throw_exception
5707         with throw.
5708         * compile/compile-object-run.c (compile_object_run): Replace
5709         throw_exception with throw.
5710         * cli/cli-script.c (process_next_line): Replace throw_exception
5711         with throw.
5712         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5713         (btrace_enable, btrace_maint_update_pt_packets): Replace
5714         throw_exception with throw.
5715         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5716         throw_exception with throw.
5717         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5718         throw_exception with throw.
5719         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5720         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5721         * aarch64-tdep.c (aarch64_make_prologue_cache)
5722         (aarch64_make_stub_cache): Replace throw_exception with throw.
5723
5724 2019-04-08  Tom Tromey  <tom@tromey.com>
5725
5726         * common/common-exceptions.c (throw_exception): Rename from
5727         throw_exception_cxx.  Remove old copy.  Make argument const.
5728         (throw_it): Create and throw exception objects directly.
5729         * common/common-exceptions.h (throw_exception): Make argument
5730         const.
5731         (struct gdb_exception_error): Add constructor.
5732         (struct gdb_exception_quit): Add constructor.
5733
5734 2019-04-08  Tom Tromey  <tom@tromey.com>
5735
5736         * common/common-exceptions.h (exception_rethrow): Don't declare.
5737         (TRY_SJLJ): Update comment.
5738         (TRY, CATCH, END_CATCH): Remove.
5739         * common/common-exceptions.c (exception_rethrow): Remove.
5740
5741 2019-04-08  Tom Tromey  <tom@tromey.com>
5742
5743         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5744         Remove.
5745         (gdb_exception_error): Rename from
5746         gdb_exception_RETURN_MASK_ERROR.
5747         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5748         (gdb_quit_bad_alloc): Update.
5749         * aarch64-tdep.c: Update.
5750         * ada-lang.c: Update.
5751         * ada-typeprint.c: Update.
5752         * ada-valprint.c: Update.
5753         * amd64-tdep.c: Update.
5754         * arch-utils.c: Update.
5755         * break-catch-throw.c: Update.
5756         * breakpoint.c: Update.
5757         * btrace.c: Update.
5758         * c-varobj.c: Update.
5759         * cli/cli-cmds.c: Update.
5760         * cli/cli-interp.c: Update.
5761         * cli/cli-script.c: Update.
5762         * common/common-exceptions.c: Update.
5763         * common/new-op.c: Update.
5764         * common/selftest.c: Update.
5765         * compile/compile-c-symbols.c: Update.
5766         * compile/compile-cplus-symbols.c: Update.
5767         * compile/compile-object-load.c: Update.
5768         * compile/compile-object-run.c: Update.
5769         * completer.c: Update.
5770         * corelow.c: Update.
5771         * cp-abi.c: Update.
5772         * cp-support.c: Update.
5773         * cp-valprint.c: Update.
5774         * darwin-nat.c: Update.
5775         * disasm-selftests.c: Update.
5776         * dtrace-probe.c: Update.
5777         * dwarf-index-cache.c: Update.
5778         * dwarf-index-write.c: Update.
5779         * dwarf2-frame-tailcall.c: Update.
5780         * dwarf2-frame.c: Update.
5781         * dwarf2loc.c: Update.
5782         * dwarf2read.c: Update.
5783         * eval.c: Update.
5784         * event-loop.c: Update.
5785         * event-top.c: Update.
5786         * exec.c: Update.
5787         * f-valprint.c: Update.
5788         * fbsd-tdep.c: Update.
5789         * frame-unwind.c: Update.
5790         * frame.c: Update.
5791         * gdbtypes.c: Update.
5792         * gnu-v3-abi.c: Update.
5793         * guile/guile-internal.h: Update.
5794         * guile/scm-block.c: Update.
5795         * guile/scm-breakpoint.c: Update.
5796         * guile/scm-cmd.c: Update.
5797         * guile/scm-disasm.c: Update.
5798         * guile/scm-frame.c: Update.
5799         * guile/scm-lazy-string.c: Update.
5800         * guile/scm-math.c: Update.
5801         * guile/scm-param.c: Update.
5802         * guile/scm-ports.c: Update.
5803         * guile/scm-pretty-print.c: Update.
5804         * guile/scm-symbol.c: Update.
5805         * guile/scm-symtab.c: Update.
5806         * guile/scm-type.c: Update.
5807         * guile/scm-value.c: Update.
5808         * i386-linux-tdep.c: Update.
5809         * i386-tdep.c: Update.
5810         * inf-loop.c: Update.
5811         * infcall.c: Update.
5812         * infcmd.c: Update.
5813         * infrun.c: Update.
5814         * jit.c: Update.
5815         * language.c: Update.
5816         * linespec.c: Update.
5817         * linux-fork.c: Update.
5818         * linux-nat.c: Update.
5819         * linux-tdep.c: Update.
5820         * linux-thread-db.c: Update.
5821         * main.c: Update.
5822         * mi/mi-cmd-break.c: Update.
5823         * mi/mi-cmd-stack.c: Update.
5824         * mi/mi-interp.c: Update.
5825         * mi/mi-main.c: Update.
5826         * objc-lang.c: Update.
5827         * p-valprint.c: Update.
5828         * parse.c: Update.
5829         * ppc-linux-tdep.c: Update.
5830         * printcmd.c: Update.
5831         * python/py-arch.c: Update.
5832         * python/py-breakpoint.c: Update.
5833         * python/py-cmd.c: Update.
5834         * python/py-finishbreakpoint.c: Update.
5835         * python/py-frame.c: Update.
5836         * python/py-framefilter.c: Update.
5837         * python/py-gdb-readline.c: Update.
5838         * python/py-inferior.c: Update.
5839         * python/py-infthread.c: Update.
5840         * python/py-lazy-string.c: Update.
5841         * python/py-linetable.c: Update.
5842         * python/py-objfile.c: Update.
5843         * python/py-param.c: Update.
5844         * python/py-prettyprint.c: Update.
5845         * python/py-progspace.c: Update.
5846         * python/py-record-btrace.c: Update.
5847         * python/py-record.c: Update.
5848         * python/py-symbol.c: Update.
5849         * python/py-type.c: Update.
5850         * python/py-unwind.c: Update.
5851         * python/py-utils.c: Update.
5852         * python/py-value.c: Update.
5853         * python/python.c: Update.
5854         * record-btrace.c: Update.
5855         * record-full.c: Update.
5856         * remote-fileio.c: Update.
5857         * remote.c: Update.
5858         * riscv-tdep.c: Update.
5859         * rs6000-aix-tdep.c: Update.
5860         * rs6000-tdep.c: Update.
5861         * rust-exp.y: Update.
5862         * rust-lang.c: Update.
5863         * s390-tdep.c: Update.
5864         * selftest-arch.c: Update.
5865         * solib-dsbt.c: Update.
5866         * solib-frv.c: Update.
5867         * solib-spu.c: Update.
5868         * solib-svr4.c: Update.
5869         * solib.c: Update.
5870         * sparc64-linux-tdep.c: Update.
5871         * stack.c: Update.
5872         * symfile-mem.c: Update.
5873         * symmisc.c: Update.
5874         * target.c: Update.
5875         * thread.c: Update.
5876         * top.c: Update.
5877         * tracefile-tfile.c: Update.
5878         * tui/tui.c: Update.
5879         * typeprint.c: Update.
5880         * unittests/cli-utils-selftests.c: Update.
5881         * unittests/parse-connection-spec-selftests.c: Update.
5882         * valops.c: Update.
5883         * valprint.c: Update.
5884         * value.c: Update.
5885         * varobj.c: Update.
5886         * windows-nat.c: Update.
5887         * x86-linux-nat.c: Update.
5888         * xml-support.c: Update.
5889
5890 2019-04-08  Tom Tromey  <tom@tromey.com>
5891
5892         * xml-support.c: Use C++ exception handling.
5893         * x86-linux-nat.c: Use C++ exception handling.
5894         * windows-nat.c: Use C++ exception handling.
5895         * varobj.c: Use C++ exception handling.
5896         * value.c: Use C++ exception handling.
5897         * valprint.c: Use C++ exception handling.
5898         * valops.c: Use C++ exception handling.
5899         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5900         handling.
5901         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5902         * typeprint.c: Use C++ exception handling.
5903         * tui/tui.c: Use C++ exception handling.
5904         * tracefile-tfile.c: Use C++ exception handling.
5905         * top.c: Use C++ exception handling.
5906         * thread.c: Use C++ exception handling.
5907         * target.c: Use C++ exception handling.
5908         * symmisc.c: Use C++ exception handling.
5909         * symfile-mem.c: Use C++ exception handling.
5910         * stack.c: Use C++ exception handling.
5911         * sparc64-linux-tdep.c: Use C++ exception handling.
5912         * solib.c: Use C++ exception handling.
5913         * solib-svr4.c: Use C++ exception handling.
5914         * solib-spu.c: Use C++ exception handling.
5915         * solib-frv.c: Use C++ exception handling.
5916         * solib-dsbt.c: Use C++ exception handling.
5917         * selftest-arch.c: Use C++ exception handling.
5918         * s390-tdep.c: Use C++ exception handling.
5919         * rust-lang.c: Use C++ exception handling.
5920         * rust-exp.y: Use C++ exception handling.
5921         * rs6000-tdep.c: Use C++ exception handling.
5922         * rs6000-aix-tdep.c: Use C++ exception handling.
5923         * riscv-tdep.c: Use C++ exception handling.
5924         * remote.c: Use C++ exception handling.
5925         * remote-fileio.c: Use C++ exception handling.
5926         * record-full.c: Use C++ exception handling.
5927         * record-btrace.c: Use C++ exception handling.
5928         * python/python.c: Use C++ exception handling.
5929         * python/py-value.c: Use C++ exception handling.
5930         * python/py-utils.c: Use C++ exception handling.
5931         * python/py-unwind.c: Use C++ exception handling.
5932         * python/py-type.c: Use C++ exception handling.
5933         * python/py-symbol.c: Use C++ exception handling.
5934         * python/py-record.c: Use C++ exception handling.
5935         * python/py-record-btrace.c: Use C++ exception handling.
5936         * python/py-progspace.c: Use C++ exception handling.
5937         * python/py-prettyprint.c: Use C++ exception handling.
5938         * python/py-param.c: Use C++ exception handling.
5939         * python/py-objfile.c: Use C++ exception handling.
5940         * python/py-linetable.c: Use C++ exception handling.
5941         * python/py-lazy-string.c: Use C++ exception handling.
5942         * python/py-infthread.c: Use C++ exception handling.
5943         * python/py-inferior.c: Use C++ exception handling.
5944         * python/py-gdb-readline.c: Use C++ exception handling.
5945         * python/py-framefilter.c: Use C++ exception handling.
5946         * python/py-frame.c: Use C++ exception handling.
5947         * python/py-finishbreakpoint.c: Use C++ exception handling.
5948         * python/py-cmd.c: Use C++ exception handling.
5949         * python/py-breakpoint.c: Use C++ exception handling.
5950         * python/py-arch.c: Use C++ exception handling.
5951         * printcmd.c: Use C++ exception handling.
5952         * ppc-linux-tdep.c: Use C++ exception handling.
5953         * parse.c: Use C++ exception handling.
5954         * p-valprint.c: Use C++ exception handling.
5955         * objc-lang.c: Use C++ exception handling.
5956         * mi/mi-main.c: Use C++ exception handling.
5957         * mi/mi-interp.c: Use C++ exception handling.
5958         * mi/mi-cmd-stack.c: Use C++ exception handling.
5959         * mi/mi-cmd-break.c: Use C++ exception handling.
5960         * main.c: Use C++ exception handling.
5961         * linux-thread-db.c: Use C++ exception handling.
5962         * linux-tdep.c: Use C++ exception handling.
5963         * linux-nat.c: Use C++ exception handling.
5964         * linux-fork.c: Use C++ exception handling.
5965         * linespec.c: Use C++ exception handling.
5966         * language.c: Use C++ exception handling.
5967         * jit.c: Use C++ exception handling.
5968         * infrun.c: Use C++ exception handling.
5969         * infcmd.c: Use C++ exception handling.
5970         * infcall.c: Use C++ exception handling.
5971         * inf-loop.c: Use C++ exception handling.
5972         * i386-tdep.c: Use C++ exception handling.
5973         * i386-linux-tdep.c: Use C++ exception handling.
5974         * guile/scm-value.c: Use C++ exception handling.
5975         * guile/scm-type.c: Use C++ exception handling.
5976         * guile/scm-symtab.c: Use C++ exception handling.
5977         * guile/scm-symbol.c: Use C++ exception handling.
5978         * guile/scm-pretty-print.c: Use C++ exception handling.
5979         * guile/scm-ports.c: Use C++ exception handling.
5980         * guile/scm-param.c: Use C++ exception handling.
5981         * guile/scm-math.c: Use C++ exception handling.
5982         * guile/scm-lazy-string.c: Use C++ exception handling.
5983         * guile/scm-frame.c: Use C++ exception handling.
5984         * guile/scm-disasm.c: Use C++ exception handling.
5985         * guile/scm-cmd.c: Use C++ exception handling.
5986         * guile/scm-breakpoint.c: Use C++ exception handling.
5987         * guile/scm-block.c: Use C++ exception handling.
5988         * guile/guile-internal.h: Use C++ exception handling.
5989         * gnu-v3-abi.c: Use C++ exception handling.
5990         * gdbtypes.c: Use C++ exception handling.
5991         * frame.c: Use C++ exception handling.
5992         * frame-unwind.c: Use C++ exception handling.
5993         * fbsd-tdep.c: Use C++ exception handling.
5994         * f-valprint.c: Use C++ exception handling.
5995         * exec.c: Use C++ exception handling.
5996         * event-top.c: Use C++ exception handling.
5997         * event-loop.c: Use C++ exception handling.
5998         * eval.c: Use C++ exception handling.
5999         * dwarf2read.c: Use C++ exception handling.
6000         * dwarf2loc.c: Use C++ exception handling.
6001         * dwarf2-frame.c: Use C++ exception handling.
6002         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6003         * dwarf-index-write.c: Use C++ exception handling.
6004         * dwarf-index-cache.c: Use C++ exception handling.
6005         * dtrace-probe.c: Use C++ exception handling.
6006         * disasm-selftests.c: Use C++ exception handling.
6007         * darwin-nat.c: Use C++ exception handling.
6008         * cp-valprint.c: Use C++ exception handling.
6009         * cp-support.c: Use C++ exception handling.
6010         * cp-abi.c: Use C++ exception handling.
6011         * corelow.c: Use C++ exception handling.
6012         * completer.c: Use C++ exception handling.
6013         * compile/compile-object-run.c: Use C++ exception handling.
6014         * compile/compile-object-load.c: Use C++ exception handling.
6015         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6016         * compile/compile-c-symbols.c: Use C++ exception handling.
6017         * common/selftest.c: Use C++ exception handling.
6018         * common/new-op.c: Use C++ exception handling.
6019         * cli/cli-script.c: Use C++ exception handling.
6020         * cli/cli-interp.c: Use C++ exception handling.
6021         * cli/cli-cmds.c: Use C++ exception handling.
6022         * c-varobj.c: Use C++ exception handling.
6023         * btrace.c: Use C++ exception handling.
6024         * breakpoint.c: Use C++ exception handling.
6025         * break-catch-throw.c: Use C++ exception handling.
6026         * arch-utils.c: Use C++ exception handling.
6027         * amd64-tdep.c: Use C++ exception handling.
6028         * ada-valprint.c: Use C++ exception handling.
6029         * ada-typeprint.c: Use C++ exception handling.
6030         * ada-lang.c: Use C++ exception handling.
6031         * aarch64-tdep.c: Use C++ exception handling.
6032
6033 2019-04-08  Tom Tromey  <tom@tromey.com>
6034
6035         * xml-support.c (gdb_xml_parser::parse): Update.
6036         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6037         * value.c (show_convenience): Update.
6038         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6039         (test_parse_flags_qcs): Update.
6040         * thread.c (thr_try_catch_cmd): Update.
6041         * target.c (target_translate_tls_address): Update.
6042         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6043         (info_frame_command_core, frame_apply_command_count): Update.
6044         * rust-exp.y (rust_lex_exception_test): Update.
6045         * riscv-tdep.c (riscv_print_one_register_info): Update.
6046         * remote.c (remote_target::enable_btrace): Update.
6047         * record-btrace.c (record_btrace_enable_warn): Update.
6048         * python/py-utils.c (gdbpy_convert_exception): Update.
6049         * printcmd.c (do_one_display, print_variable_and_value): Update.
6050         * mi/mi-main.c (mi_print_exception): Update.
6051         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6052         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6053         * linux-nat.c (linux_nat_target::attach): Update.
6054         * linux-fork.c (class scoped_switch_fork_info): Update.
6055         * infrun.c (displaced_step_prepare): Update.
6056         * infcall.c (call_function_by_hand_dummy): Update.
6057         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6058         * gnu-v3-abi.c (print_one_vtable): Update.
6059         * frame.c (get_prev_frame_always): Update.
6060         * f-valprint.c (info_common_command_for_block): Update.
6061         * exec.c (try_open_exec_file): Update.
6062         * exceptions.c (print_exception, exception_print)
6063         (exception_fprintf, exception_print_same): Update.
6064         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6065         * dwarf-index-cache.c (index_cache::store)
6066         (index_cache::lookup_gdb_index): Update.
6067         * darwin-nat.c (maybe_cache_shell): Update.
6068         * cp-valprint.c (cp_print_value_fields): Update.
6069         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6070         (gcc_cplus_symbol_address): Update.
6071         * compile/compile-c-symbols.c (gcc_convert_symbol)
6072         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6073         * common/selftest.c: Update.
6074         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6075         a std::string.
6076         (exception_try_scope_entry, exception_try_scope_exit): Don't
6077         declare.
6078         (struct exception_try_scope): Remove.
6079         (TRY): Don't use exception_try_scope.
6080         (struct gdb_exception): Add constructor, operator=.
6081         <what>: New method.
6082         (struct gdb_exception_RETURN_MASK_ALL)
6083         (struct gdb_exception_RETURN_MASK_ERROR)
6084         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6085         (struct gdb_quit_bad_alloc): Update.
6086         * common/common-exceptions.c (exception_none): Change
6087         initializer.
6088         (struct catcher) <state, exception>: Initialize inline.
6089         <prev>: Remove member.
6090         (current_catcher): Remove.
6091         (catchers): New global.
6092         (exceptions_state_mc_init): Simplify.
6093         (catcher_pop): Remove.
6094         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6095         (try_scope_depth, exception_try_scope_entry)
6096         (exception_try_scope_exit): Remove.
6097         (throw_exception_sjlj): Update.
6098         (exception_messages, exception_messages_size): Remove.
6099         (throw_it): Simplify.
6100         (gdb_exception_sliced_copy): Remove.
6101         (throw_exception_cxx): Update.
6102         * cli/cli-script.c (script_from_file): Update.
6103         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6104         Update.
6105         * ada-valprint.c (ada_val_print): Update.
6106         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6107         (create_excep_cond_exprs): Update.
6108
6109 2019-04-08  Tom Tromey  <tom@tromey.com>
6110
6111         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6112         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6113         (TRY, CATCH, END_CATCH): Remove some definitions.
6114         * common/common-exceptions.c: Don't use GDB_XCPT.
6115         (catcher_list_size): Remove.
6116         (throw_exception, throw_it): Simplify.
6117
6118 2019-04-05  Tom Tromey  <tom@tromey.com>
6119
6120         Revert the header-sorting patch.
6121         * ft32-tdep.c: Revert.
6122         * frv-tdep.c: Revert.
6123         * frv-linux-tdep.c: Revert.
6124         * frame.c: Revert.
6125         * frame-unwind.c: Revert.
6126         * frame-base.c: Revert.
6127         * fork-child.c: Revert.
6128         * findvar.c: Revert.
6129         * findcmd.c: Revert.
6130         * filesystem.c: Revert.
6131         * filename-seen-cache.h: Revert.
6132         * filename-seen-cache.c: Revert.
6133         * fbsd-tdep.c: Revert.
6134         * fbsd-nat.h: Revert.
6135         * fbsd-nat.c: Revert.
6136         * f-valprint.c: Revert.
6137         * f-typeprint.c: Revert.
6138         * f-lang.c: Revert.
6139         * extension.h: Revert.
6140         * extension.c: Revert.
6141         * extension-priv.h: Revert.
6142         * expprint.c: Revert.
6143         * exec.h: Revert.
6144         * exec.c: Revert.
6145         * exceptions.c: Revert.
6146         * event-top.c: Revert.
6147         * event-loop.c: Revert.
6148         * eval.c: Revert.
6149         * elfread.c: Revert.
6150         * dwarf2read.h: Revert.
6151         * dwarf2read.c: Revert.
6152         * dwarf2loc.c: Revert.
6153         * dwarf2expr.h: Revert.
6154         * dwarf2expr.c: Revert.
6155         * dwarf2-frame.c: Revert.
6156         * dwarf2-frame-tailcall.c: Revert.
6157         * dwarf-index-write.h: Revert.
6158         * dwarf-index-write.c: Revert.
6159         * dwarf-index-common.c: Revert.
6160         * dwarf-index-cache.h: Revert.
6161         * dwarf-index-cache.c: Revert.
6162         * dummy-frame.c: Revert.
6163         * dtrace-probe.c: Revert.
6164         * disasm.h: Revert.
6165         * disasm.c: Revert.
6166         * disasm-selftests.c: Revert.
6167         * dictionary.c: Revert.
6168         * dicos-tdep.c: Revert.
6169         * demangle.c: Revert.
6170         * dcache.h: Revert.
6171         * dcache.c: Revert.
6172         * darwin-nat.h: Revert.
6173         * darwin-nat.c: Revert.
6174         * darwin-nat-info.c: Revert.
6175         * d-valprint.c: Revert.
6176         * d-namespace.c: Revert.
6177         * d-lang.c: Revert.
6178         * ctf.c: Revert.
6179         * csky-tdep.c: Revert.
6180         * csky-linux-tdep.c: Revert.
6181         * cris-tdep.c: Revert.
6182         * cris-linux-tdep.c: Revert.
6183         * cp-valprint.c: Revert.
6184         * cp-support.c: Revert.
6185         * cp-namespace.c: Revert.
6186         * cp-abi.c: Revert.
6187         * corelow.c: Revert.
6188         * corefile.c: Revert.
6189         * continuations.c: Revert.
6190         * completer.h: Revert.
6191         * completer.c: Revert.
6192         * complaints.c: Revert.
6193         * coffread.c: Revert.
6194         * coff-pe-read.c: Revert.
6195         * cli-out.h: Revert.
6196         * cli-out.c: Revert.
6197         * charset.c: Revert.
6198         * c-varobj.c: Revert.
6199         * c-valprint.c: Revert.
6200         * c-typeprint.c: Revert.
6201         * c-lang.c: Revert.
6202         * buildsym.c: Revert.
6203         * buildsym-legacy.c: Revert.
6204         * build-id.h: Revert.
6205         * build-id.c: Revert.
6206         * btrace.c: Revert.
6207         * bsd-uthread.c: Revert.
6208         * breakpoint.h: Revert.
6209         * breakpoint.c: Revert.
6210         * break-catch-throw.c: Revert.
6211         * break-catch-syscall.c: Revert.
6212         * break-catch-sig.c: Revert.
6213         * blockframe.c: Revert.
6214         * block.c: Revert.
6215         * bfin-tdep.c: Revert.
6216         * bfin-linux-tdep.c: Revert.
6217         * bfd-target.c: Revert.
6218         * bcache.c: Revert.
6219         * ax-general.c: Revert.
6220         * ax-gdb.h: Revert.
6221         * ax-gdb.c: Revert.
6222         * avr-tdep.c: Revert.
6223         * auxv.c: Revert.
6224         * auto-load.c: Revert.
6225         * arm-wince-tdep.c: Revert.
6226         * arm-tdep.c: Revert.
6227         * arm-symbian-tdep.c: Revert.
6228         * arm-pikeos-tdep.c: Revert.
6229         * arm-obsd-tdep.c: Revert.
6230         * arm-nbsd-tdep.c: Revert.
6231         * arm-nbsd-nat.c: Revert.
6232         * arm-linux-tdep.c: Revert.
6233         * arm-linux-nat.c: Revert.
6234         * arm-fbsd-tdep.c: Revert.
6235         * arm-fbsd-nat.c: Revert.
6236         * arm-bsd-tdep.c: Revert.
6237         * arch-utils.c: Revert.
6238         * arc-tdep.c: Revert.
6239         * arc-newlib-tdep.c: Revert.
6240         * annotate.h: Revert.
6241         * annotate.c: Revert.
6242         * amd64-windows-tdep.c: Revert.
6243         * amd64-windows-nat.c: Revert.
6244         * amd64-tdep.c: Revert.
6245         * amd64-sol2-tdep.c: Revert.
6246         * amd64-obsd-tdep.c: Revert.
6247         * amd64-obsd-nat.c: Revert.
6248         * amd64-nbsd-tdep.c: Revert.
6249         * amd64-nbsd-nat.c: Revert.
6250         * amd64-nat.c: Revert.
6251         * amd64-linux-tdep.c: Revert.
6252         * amd64-linux-nat.c: Revert.
6253         * amd64-fbsd-tdep.c: Revert.
6254         * amd64-fbsd-nat.c: Revert.
6255         * amd64-dicos-tdep.c: Revert.
6256         * amd64-darwin-tdep.c: Revert.
6257         * amd64-bsd-nat.c: Revert.
6258         * alpha-tdep.c: Revert.
6259         * alpha-obsd-tdep.c: Revert.
6260         * alpha-nbsd-tdep.c: Revert.
6261         * alpha-mdebug-tdep.c: Revert.
6262         * alpha-linux-tdep.c: Revert.
6263         * alpha-linux-nat.c: Revert.
6264         * alpha-bsd-tdep.c: Revert.
6265         * alpha-bsd-nat.c: Revert.
6266         * aix-thread.c: Revert.
6267         * agent.c: Revert.
6268         * addrmap.c: Revert.
6269         * ada-varobj.c: Revert.
6270         * ada-valprint.c: Revert.
6271         * ada-typeprint.c: Revert.
6272         * ada-tasks.c: Revert.
6273         * ada-lang.c: Revert.
6274         * aarch64-tdep.c: Revert.
6275         * aarch64-ravenscar-thread.c: Revert.
6276         * aarch64-newlib-tdep.c: Revert.
6277         * aarch64-linux-tdep.c: Revert.
6278         * aarch64-linux-nat.c: Revert.
6279         * aarch64-fbsd-tdep.c: Revert.
6280         * aarch64-fbsd-nat.c: Revert.
6281         * aarch32-linux-nat.c: Revert.
6282
6283 2019-04-05  Tom Tromey  <tom@tromey.com>
6284
6285         * ft32-tdep.c: Sort headers.
6286         * frv-tdep.c: Sort headers.
6287         * frv-linux-tdep.c: Sort headers.
6288         * frame.c: Sort headers.
6289         * frame-unwind.c: Sort headers.
6290         * frame-base.c: Sort headers.
6291         * fork-child.c: Sort headers.
6292         * findvar.c: Sort headers.
6293         * findcmd.c: Sort headers.
6294         * filesystem.c: Sort headers.
6295         * filename-seen-cache.h: Sort headers.
6296         * filename-seen-cache.c: Sort headers.
6297         * fbsd-tdep.c: Sort headers.
6298         * fbsd-nat.h: Sort headers.
6299         * fbsd-nat.c: Sort headers.
6300         * f-valprint.c: Sort headers.
6301         * f-typeprint.c: Sort headers.
6302         * f-lang.c: Sort headers.
6303         * extension.h: Sort headers.
6304         * extension.c: Sort headers.
6305         * extension-priv.h: Sort headers.
6306         * expprint.c: Sort headers.
6307         * exec.h: Sort headers.
6308         * exec.c: Sort headers.
6309         * exceptions.c: Sort headers.
6310         * event-top.c: Sort headers.
6311         * event-loop.c: Sort headers.
6312         * eval.c: Sort headers.
6313         * elfread.c: Sort headers.
6314         * dwarf2read.h: Sort headers.
6315         * dwarf2read.c: Sort headers.
6316         * dwarf2loc.c: Sort headers.
6317         * dwarf2expr.h: Sort headers.
6318         * dwarf2expr.c: Sort headers.
6319         * dwarf2-frame.c: Sort headers.
6320         * dwarf2-frame-tailcall.c: Sort headers.
6321         * dwarf-index-write.h: Sort headers.
6322         * dwarf-index-write.c: Sort headers.
6323         * dwarf-index-common.c: Sort headers.
6324         * dwarf-index-cache.h: Sort headers.
6325         * dwarf-index-cache.c: Sort headers.
6326         * dummy-frame.c: Sort headers.
6327         * dtrace-probe.c: Sort headers.
6328         * disasm.h: Sort headers.
6329         * disasm.c: Sort headers.
6330         * disasm-selftests.c: Sort headers.
6331         * dictionary.c: Sort headers.
6332         * dicos-tdep.c: Sort headers.
6333         * demangle.c: Sort headers.
6334         * dcache.h: Sort headers.
6335         * dcache.c: Sort headers.
6336         * darwin-nat.h: Sort headers.
6337         * darwin-nat.c: Sort headers.
6338         * darwin-nat-info.c: Sort headers.
6339         * d-valprint.c: Sort headers.
6340         * d-namespace.c: Sort headers.
6341         * d-lang.c: Sort headers.
6342         * ctf.c: Sort headers.
6343         * csky-tdep.c: Sort headers.
6344         * csky-linux-tdep.c: Sort headers.
6345         * cris-tdep.c: Sort headers.
6346         * cris-linux-tdep.c: Sort headers.
6347         * cp-valprint.c: Sort headers.
6348         * cp-support.c: Sort headers.
6349         * cp-namespace.c: Sort headers.
6350         * cp-abi.c: Sort headers.
6351         * corelow.c: Sort headers.
6352         * corefile.c: Sort headers.
6353         * continuations.c: Sort headers.
6354         * completer.h: Sort headers.
6355         * completer.c: Sort headers.
6356         * complaints.c: Sort headers.
6357         * coffread.c: Sort headers.
6358         * coff-pe-read.c: Sort headers.
6359         * cli-out.h: Sort headers.
6360         * cli-out.c: Sort headers.
6361         * charset.c: Sort headers.
6362         * c-varobj.c: Sort headers.
6363         * c-valprint.c: Sort headers.
6364         * c-typeprint.c: Sort headers.
6365         * c-lang.c: Sort headers.
6366         * buildsym.c: Sort headers.
6367         * buildsym-legacy.c: Sort headers.
6368         * build-id.h: Sort headers.
6369         * build-id.c: Sort headers.
6370         * btrace.c: Sort headers.
6371         * bsd-uthread.c: Sort headers.
6372         * breakpoint.h: Sort headers.
6373         * breakpoint.c: Sort headers.
6374         * break-catch-throw.c: Sort headers.
6375         * break-catch-syscall.c: Sort headers.
6376         * break-catch-sig.c: Sort headers.
6377         * blockframe.c: Sort headers.
6378         * block.c: Sort headers.
6379         * bfin-tdep.c: Sort headers.
6380         * bfin-linux-tdep.c: Sort headers.
6381         * bfd-target.c: Sort headers.
6382         * bcache.c: Sort headers.
6383         * ax-general.c: Sort headers.
6384         * ax-gdb.h: Sort headers.
6385         * ax-gdb.c: Sort headers.
6386         * avr-tdep.c: Sort headers.
6387         * auxv.c: Sort headers.
6388         * auto-load.c: Sort headers.
6389         * arm-wince-tdep.c: Sort headers.
6390         * arm-tdep.c: Sort headers.
6391         * arm-symbian-tdep.c: Sort headers.
6392         * arm-pikeos-tdep.c: Sort headers.
6393         * arm-obsd-tdep.c: Sort headers.
6394         * arm-nbsd-tdep.c: Sort headers.
6395         * arm-nbsd-nat.c: Sort headers.
6396         * arm-linux-tdep.c: Sort headers.
6397         * arm-linux-nat.c: Sort headers.
6398         * arm-fbsd-tdep.c: Sort headers.
6399         * arm-fbsd-nat.c: Sort headers.
6400         * arm-bsd-tdep.c: Sort headers.
6401         * arch-utils.c: Sort headers.
6402         * arc-tdep.c: Sort headers.
6403         * arc-newlib-tdep.c: Sort headers.
6404         * annotate.h: Sort headers.
6405         * annotate.c: Sort headers.
6406         * amd64-windows-tdep.c: Sort headers.
6407         * amd64-windows-nat.c: Sort headers.
6408         * amd64-tdep.c: Sort headers.
6409         * amd64-sol2-tdep.c: Sort headers.
6410         * amd64-obsd-tdep.c: Sort headers.
6411         * amd64-obsd-nat.c: Sort headers.
6412         * amd64-nbsd-tdep.c: Sort headers.
6413         * amd64-nbsd-nat.c: Sort headers.
6414         * amd64-nat.c: Sort headers.
6415         * amd64-linux-tdep.c: Sort headers.
6416         * amd64-linux-nat.c: Sort headers.
6417         * amd64-fbsd-tdep.c: Sort headers.
6418         * amd64-fbsd-nat.c: Sort headers.
6419         * amd64-dicos-tdep.c: Sort headers.
6420         * amd64-darwin-tdep.c: Sort headers.
6421         * amd64-bsd-nat.c: Sort headers.
6422         * alpha-tdep.c: Sort headers.
6423         * alpha-obsd-tdep.c: Sort headers.
6424         * alpha-nbsd-tdep.c: Sort headers.
6425         * alpha-mdebug-tdep.c: Sort headers.
6426         * alpha-linux-tdep.c: Sort headers.
6427         * alpha-linux-nat.c: Sort headers.
6428         * alpha-bsd-tdep.c: Sort headers.
6429         * alpha-bsd-nat.c: Sort headers.
6430         * aix-thread.c: Sort headers.
6431         * agent.c: Sort headers.
6432         * addrmap.c: Sort headers.
6433         * ada-varobj.c: Sort headers.
6434         * ada-valprint.c: Sort headers.
6435         * ada-typeprint.c: Sort headers.
6436         * ada-tasks.c: Sort headers.
6437         * ada-lang.c: Sort headers.
6438         * aarch64-tdep.c: Sort headers.
6439         * aarch64-ravenscar-thread.c: Sort headers.
6440         * aarch64-newlib-tdep.c: Sort headers.
6441         * aarch64-linux-tdep.c: Sort headers.
6442         * aarch64-linux-nat.c: Sort headers.
6443         * aarch64-fbsd-tdep.c: Sort headers.
6444         * aarch64-fbsd-nat.c: Sort headers.
6445         * aarch32-linux-nat.c: Sort headers.
6446
6447 2019-04-04  Tom Tromey  <tom@tromey.com>
6448
6449         * varobj.c (varobj_create): Update.
6450         * rust-exp.y (struct rust_parser) <update_innermost_block,
6451         lookup_symbol>: New methods.
6452         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6453         Rename.
6454         (rust_parser::rust_lookup_type)
6455         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6456         * printcmd.c (display_command, do_one_display): Update.
6457         * parser-defs.h (struct parser_state) <parser_state>: Add
6458         "tracker" parameter.
6459         (block_tracker): New member.
6460         (class innermost_block_tracker) <innermost_block_tracker>: Add
6461         "types" parameter.
6462         <reset>: Remove method.
6463         (innermost_block): Don't declare.
6464         (null_post_parser): Update.
6465         * parse.c (innermost_block): Remove global.
6466         (write_dollar_variable): Update.
6467         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6468         Remove "tracker_types" parameter.
6469         (parse_expression): Add "tracker" parameter.
6470         (parse_expression_for_completion): Update.
6471         (null_post_parser): Add "tracker" parameter.
6472         * p-exp.y: Update rules.
6473         * m2-exp.y: Update rules.
6474         * language.h (struct language_defn) <la_post_parser>: Add
6475         "tracker" parameter.
6476         * go-exp.y: Update rules.
6477         * f-exp.y: Update rules.
6478         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6479         parameter.
6480         * d-exp.y: Update rules.
6481         * c-exp.y: Update rules.
6482         * breakpoint.c (set_breakpoint_condition): Create an
6483         innermost_block_tracker.
6484         (watch_command_1): Likewise.
6485         * ada-lang.c (resolve): Add "tracker" parameter.
6486         (resolve_subexp): Likewise.
6487         * ada-exp.y (write_var_from_sym): Update.
6488
6489 2019-04-04  Tom Tromey  <tom@tromey.com>
6490
6491         * type-stack.h: New file.
6492         * type-stack.c: New file.
6493         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6494         type-stack.h.
6495         (insert_into_type_stack, insert_type, push_type, push_type_int)
6496         (insert_type_address_space, pop_type, pop_type_int)
6497         (pop_typelist, pop_type_stack, append_type_stack)
6498         (push_type_stack, get_type_stack, push_typelist)
6499         (follow_type_instance_flags, follow_types): Don't declare.
6500         * parse.c (type_stack): Remove global.
6501         (parse_exp_in_context): Update.
6502         (insert_into_type_stack, insert_type, push_type, push_type_int)
6503         (insert_type_address_space, pop_type, pop_type_int)
6504         (pop_typelist, pop_type_stack, append_type_stack)
6505         (push_type_stack, get_type_stack, push_typelist)
6506         (follow_type_instance_flags, follow_types): Remove (moved to
6507         type-stack.c).
6508         * f-exp.y (type_stack): New global.
6509         Update rules.
6510         (push_kind_type, f_parse): Update.
6511         * d-exp.y (type_stack): New global.
6512         Update rules.
6513         (d_parse): Update.
6514         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6515         Update rules.
6516         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6517         (HFILES_NO_SRCDIR): Add type-stack.h.
6518
6519 2019-04-04  Tom Tromey  <tom@tromey.com>
6520
6521         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6522         (rust_parser::convert_ast_to_expression, rust_parse)
6523         (rust_lex_test_completion, rust_lex_tests): Update.
6524         * parser-defs.h (struct expr_completion_state): New.
6525         (struct parser_state) <parser_state>: Add completion parameter.
6526         <mark_struct_expression, mark_completion_tag>: New methods.
6527         <parse_completion, m_completion_state>: New members.
6528         (prefixify_expression, null_post_parser): Update.
6529         (mark_struct_expression, mark_completion_tag): Don't declare.
6530         * parse.c (parse_completion, expout_last_struct)
6531         (expout_tag_completion_type, expout_completion_name): Remove
6532         globals.
6533         (parser_state::mark_struct_expression)
6534         (parser_state::mark_completion_tag): Now methods.
6535         (prefixify_expression): Add last_struct parameter.
6536         (prefixify_subexp): Likewise.
6537         (parse_exp_1): Update.
6538         (parse_exp_in_context): Add cstate parameter.  Update.
6539         (parse_expression_for_completion): Create an
6540         expr_completion_state.
6541         (null_post_parser): Add "completion" parameter.
6542         * p-exp.y: Update rules.
6543         (yylex): Update.
6544         * language.h (struct language_defn) <la_post_parser>: Add
6545         "completing" parameter.
6546         * go-exp.y: Update rules.
6547         (lex_one_token): Update.
6548         * expression.h (parse_completion): Don't declare.
6549         * d-exp.y: Update rules.
6550         (lex_one_token): Update rules.
6551         * c-exp.y: Update rules.
6552         (lex_one_token): Update.
6553         * ada-lang.c (resolve): Add "parse_completion" parameter.
6554         (resolve_subexp): Likewise.
6555         (ada_resolve_function): Likewise.
6556
6557 2019-04-04  Tom Tromey  <tom@tromey.com>
6558
6559         * parser-defs.h (struct parser_state) <start_arglist,
6560         end_arglist>: New methods.
6561         <arglist_len, m_funcall_chain>: New members.
6562         (arglist_len, start_arglist, end_arglist): Don't declare.
6563         * parse.c (arglist_len, funcall_chain): Remove global.
6564         (start_arglist, end_arglist): Remove functions.
6565         (parse_exp_in_context): Update.
6566         * p-exp.y: Update rules.
6567         * m2-exp.y: Update rules.
6568         * go-exp.y: Update rules.
6569         * f-exp.y: Update rules.
6570         * d-exp.y: Update rules.
6571         * c-exp.y: Update rules.
6572
6573 2019-04-04  Tom Tromey  <tom@tromey.com>
6574
6575         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6576         lex_operator, push_back>: New methods.
6577         Update all rules.
6578         (rust_parser::lex_hex, lex_escape): Rename and update.
6579         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6580         (rust_parser::lex_operator): Rename and update.
6581         (rust_parser::lex_number, rustyylex, rustyyerror)
6582         (rust_lex_test_init, rust_lex_test_sequence)
6583         (rust_lex_test_push_back, rust_lex_tests): Update.
6584         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6585         parameter.
6586         <lexptr, prev_lexptr>: New members.
6587         (lexptr, prev_lexptr): Don't declare.
6588         * parse.c (lexptr, prev_lexptr): Remove globals.
6589         (parse_exp_in_context): Update.
6590         * p-exp.y (yylex, yyerror): Update.
6591         * m2-exp.y (parse_number, yylex, yyerror): Update.
6592         * go-exp.y (lex_one_token, yyerror): Update.
6593         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6594         * d-exp.y (lex_one_token, yyerror): Update.
6595         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6596         (lex_one_token, yyerror): Update.
6597         * ada-lex.l (YY_INPUT): Update.
6598         (rewind_to_char): Update.
6599         * ada-exp.y (yyerror): Update.
6600
6601 2019-04-04  Tom Tromey  <tom@tromey.com>
6602
6603         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6604         * parser-defs.h (struct parser_state) <parser_state>: Add new
6605         parameter.
6606         <comma_terminates>: New member.
6607         (comma_terminates): Don't declare global.
6608         * parse.c (comma_terminates): Remove global.
6609         (parse_exp_in_context): Update.
6610         * p-exp.y (yylex): Update.
6611         * m2-exp.y (yylex): Update.
6612         * go-exp.y (lex_one_token): Update.
6613         * f-exp.y (yylex): Update.
6614         * d-exp.y (lex_one_token): Update.
6615         * c-exp.y (lex_one_token): Update.
6616         * ada-lex.l: Update.
6617
6618 2019-04-04  Tom Tromey  <tom@tromey.com>
6619
6620         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6621         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6622         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6623         * parser-defs.h (paren_depth): Don't declare.
6624         * parse.c (paren_depth): Remove global.
6625         (parse_exp_in_context): Update.
6626         * p-exp.y (paren_depth): New global.
6627         (pascal_parse): Initialize it.
6628         * m2-exp.y (paren_depth): New global.
6629         (m2_parse): Initialize it.
6630         * go-exp.y (paren_depth): New global.
6631         (go_parse): Initialize it.
6632         * f-exp.y (paren_depth): New global.
6633         (f_parse): Initialize it.
6634         * d-exp.y (paren_depth): New global.
6635         (d_parse): Initialize it.
6636         * c-exp.y (paren_depth): New global.
6637         (c_parse): Initialize it.
6638         * ada-lex.l (paren_depth): New global.
6639         (lexer_init): Initialize it.
6640
6641 2019-04-04  Tom Tromey  <tom@tromey.com>
6642
6643         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6644         (rust_parser::convert_ast_to_type)
6645         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6646         * parser-defs.h (struct parser_state) <parser_state>: Add
6647         parameters.  Initialize new members.
6648         <expression_context_block, expression_context_pc>: New members.
6649         * parse.c (expression_context_block, expression_context_pc):
6650         Remove globals.
6651         (parse_exp_in_context): Update.
6652         * p-exp.y: Update all rules.
6653         (yylex): Update.
6654         * m2-exp.y: Update all rules.
6655         (yylex): Update.
6656         * go-exp.y (yylex): Update.
6657         * f-exp.y (yylex): Update.
6658         * d-exp.y: Update all rules.
6659         (yylex): Update.
6660         * c-exp.y: Update all rules.
6661         (lex_one_token, classify_name, yylex, c_parse): Update.
6662         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6663
6664 2019-04-04  Tom Tromey  <tom@tromey.com>
6665
6666         * gdbarch.h, gdbarch.c: Rebuild.
6667         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6668         * stap-probe.h:
6669         (struct stap_parse_info): Replace "parser_state" with
6670         "expr_builder".
6671         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6672         (parser_state): New class.
6673         * parse.c (expr_builder): Rename.
6674         (expr_builder::release): Rename.
6675         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6676         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6677         (write_exp_elt_longcst, write_exp_elt_floatcst)
6678         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6679         (write_exp_string_vector, write_exp_bitstring)
6680         (write_exp_msymbol, mark_struct_expression)
6681         (write_dollar_variable)
6682         (insert_type_address_space, increase_expout_size): Replace
6683         "parser_state" with "expr_builder".
6684         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6685         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6686         "parser_state" with "expr_builder".
6687
6688 2019-04-04  Tom Tromey  <tom@tromey.com>
6689
6690         * rust-exp.y: Replace "parse_language" with method call.
6691         * p-exp.y:
6692         (yylex): Replace "parse_language" with method call.
6693         * m2-exp.y:
6694         (yylex): Replace "parse_language" with method call.
6695         * go-exp.y (classify_name): Replace "parse_language" with method
6696         call.
6697         * f-exp.y (yylex): Replace "parse_language" with method call.
6698         * d-exp.y (lex_one_token): Replace "parse_language" with method
6699         call.
6700         * c-exp.y:
6701         (lex_one_token, classify_name, yylex): Replace "parse_language"
6702         with method call.
6703         * ada-exp.y (find_primitive_type, type_char)
6704         (type_system_address): Replace "parse_language" with method call.
6705
6706 2019-04-04  Tom Tromey  <tom@tromey.com>
6707
6708         * rust-exp.y: Replace "parse_gdbarch" with method call.
6709         * parse.c (write_dollar_variable, insert_type_address_space):
6710         Replace "parse_gdbarch" with method call.
6711         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6712         call.
6713         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6714         call.
6715         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6716         "parse_gdbarch" with method call.
6717         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6718         with method call.
6719         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6720         "parse_gdbarch" with method call.
6721         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6722         "parse_gdbarch" with method call.
6723         * c-exp.y (parse_type, parse_number, classify_name): Replace
6724         "parse_gdbarch" with method call.
6725         * ada-lex.l: Replace "parse_gdbarch" with method call.
6726         * ada-exp.y (parse_type, find_primitive_type, type_char)
6727         (type_system_address): Replace "parse_gdbarch" with method call.
6728
6729 2019-04-04  Tom Tromey  <tom@tromey.com>
6730
6731         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6732         * stap-probe.c (stap_parse_argument): Update.
6733         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6734         initial_size parameter.
6735         * rust-exp.y (rust_lex_tests): Update.
6736         * parse.c (parser_state): Update.
6737         (parse_exp_in_context): Update.
6738         * parser-defs.h (struct parser_state) <parser_state>: Remove
6739         "initial_size" parameter.
6740
6741 2019-04-04  Tom Tromey  <tom@tromey.com>
6742
6743         * parser-defs.h (increase_expout_size): Don't declare.
6744         * parse.c (increase_expout_size): Now static.
6745
6746 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6747
6748         * gnu-nat.c (gnu_nat_target::wait): Fix
6749         target_waitstatus_to_string call.
6750
6751 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6752
6753         * eval.c (evaluate_subexp_standard): Handle internal functions
6754         during Fortran function call handling.
6755
6756 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6757
6758         * NEWS: Mention new internal functions.
6759         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6760         (read_base_type): Use dwarf2_init_complex_target_type.
6761         * value.c (creal_internal_fn): New function.
6762         (cimag_internal_fn): New function.
6763         (_initialize_values): Register new internal functions.
6764
6765 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6766
6767         * infrun.c (stop_all_threads): If debug_infrun, always
6768         trace the wait status after wait_one, using
6769         target_waitstatus_to_string and target_pid_to_str.
6770         (handle_inferior_event): Replace various trace of
6771         wait status kind by a single trace.
6772         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6773         wait status kind image by target_waitstatus_to_string.
6774         * target/waitstatus.c (target_waitstatus_to_string): Fix
6775         obsolete comment.
6776
6777 2019-04-01  Tom Tromey  <tromey@adacore.com>
6778
6779         PR symtab/23331:
6780         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6781
6782 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6783             Pedro Alves  <palves@redhat.com>
6784
6785         * top.c (quit_force): Call 'finalize_values'.
6786         * value.c (finalize_values): New function.
6787         * value.h (finalize_values): Declare.
6788
6789 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6790
6791         * NEWS: Announce $_gdb_major and $_gdb_minor.
6792
6793         * top.c (init_gdb_version_vars): New function.
6794         (gdb_init): Call init_gdb_version_vars.
6795
6796 2019-03-29  Tom Tromey  <tromey@adacore.com>
6797
6798         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6799         help text.  Remove dead code.
6800
6801 2019-03-29  Keith Seitz  <keiths@redhat.com>
6802
6803         From Siddhesh Poyarekar:
6804         * f-lang.h (f77_get_upperbound): Return LONGEST.
6805         (f77_get_lowerbound): Likewise.
6806         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6807         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6808         print them.
6809         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6810         plongest to format print it.
6811         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6812         (f77_get_upperbound): Likewise.
6813         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6814         LOWER_BOUND to LONGEST.
6815         (f77_create_arrayprint_offset_tbl): Likewise.
6816
6817 2019-03-29  Keith Seitz  <keiths@redhat.com>
6818
6819         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6820         %s/pulongest for TYPE_LENGTH instead of %d in format
6821         strings.
6822         * ada-typerint.c (ada_print_type): Likewise.
6823         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6824         * compile/compile-c-support.c (generate_register_struct): Likewise.
6825         * gdbtypes.c (recursive_dump_type): Likewise.
6826         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6827         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6828         instead of %d in format strings.
6829         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6830         to std::min to ULONGEST.
6831         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6832         instead of %d in format strings.
6833         * tracepoint.c (info_scope_command): Likewise.
6834         * typeprint.c (print_offset_data::update)
6835         (print_offset_data::finish): Likewise.
6836         * xtensa-tdep.c (xtensa_store_return_value)
6837         (xtensa_push_dummy_call): Likewise.
6838
6839 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6840
6841         * windows-nat.c (display_selector): Fixed format specifications
6842         for 64-bit Cygwin.
6843
6844 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6845
6846         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6847
6848 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6849
6850         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6851         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6852         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6853         (nios2_linux_init_abi): Install it.
6854
6855 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6856
6857         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6858
6859 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6860
6861         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6862
6863 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6864             Tom Tromey  <tromey@adacore.com>
6865
6866         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6867
6868 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6869
6870         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6871         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6872         method to compute the bounds of range types. Also print "[evaluated]"
6873         if the bounds' values come from a dynamic evaluation.
6874
6875 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6876
6877         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6878         whitespace when pretty printing is on.
6879
6880 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6881
6882         * ppc-linux-nat.c: Add include.
6883
6884 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6885
6886         * NEWS: Mention AArch64 Pointer Authentication.
6887
6888 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6889
6890         * arm-linux-nat.c: Add include.
6891
6892 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6893
6894         * source-cache.c (source_cache::get_source_lines): Re-read
6895         fullname after calling open_source_file.
6896
6897 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6898
6899         * NEWS: Mention TLS support for FreeBSD.
6900
6901 2019-03-25  Tom Tromey  <tromey@adacore.com>
6902
6903         * minsyms.c (BUNCH_SIZE): Update comment.
6904         (~minimal_symbol_reader): Remove old comment.
6905         (compact_minimal_symbols): Update comment.
6906         (minimal_symbol_reader::install): Remove old comment.  Update
6907         other comments.
6908
6909 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6910
6911         * s390-linux-nat.c: Add include.
6912
6913 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6914
6915         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6916         Call linux_get_hwcap.
6917         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6918         Likewise.
6919         (aarch64_linux_get_hwcap): Remove function.
6920         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6921         declaration.
6922         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6923         linux_get_hwcap.
6924         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6925         * linux-tdep.c (linux_get_hwcap): Add function.
6926         (linux_get_hwcap2): Likewise.
6927         * linux-tdep.h (linux_get_hwcap): Add declaration.
6928         (linux_get_hwcap2): Likewise.
6929         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6930         (ppc_linux_get_hwcap2): Likewise.
6931         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6932         linux_get_hwcap.
6933         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6934         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6935         (ppc_linux_nat_target::read_description): Likewise.
6936         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6937         * s390-linux-nat.c: Likewise.
6938         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6939
6940 2019-03-24  Tom Tromey  <tom@tromey.com>
6941
6942         * ada-lang.c (standard_lookup): Simplify initialization.
6943         (ada_lookup_symbol_nonlocal): Simplify return.
6944         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6945         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6946         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6947         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6948         initialization.
6949         * solib.c (solib_global_lookup): Simplify.
6950         * symtab.c (null_block_symbol): Remove.
6951         (symbol_cache_lookup): Simplify returns.
6952         (lookup_language_this): Simplify returns.
6953         (lookup_symbol_aux): Simplify return.
6954         (lookup_local_symbol): Simplify returns.
6955         (lookup_global_symbol_from_objfile): Simplify return.
6956         (lookup_symbol_in_objfile_symtabs)
6957         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6958         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6959         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6960         * cp-namespace.c (cp_lookup_bare_symbol)
6961         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6962         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6963         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6964         (cp_lookup_symbol_via_imports): Simplify initialization.
6965         (find_symbol_in_baseclass): Likewise.
6966         * symtab.h (null_block_symbol): Remove.
6967         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6968         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6969         (d_lookup_symbol_module): Likewise.
6970         (find_symbol_in_baseclass): Simplify initialization.
6971
6972 2019-03-24  Tom Tromey  <tom@tromey.com>
6973
6974         * expression.h: Don't include symtab.h.
6975         (struct block): Forward declare.
6976
6977 2019-03-24  Tom Tromey  <tom@tromey.com>
6978
6979         * c-exp.y (typebase): Remove casts.
6980         * gdbtypes.c (lookup_unsigned_typename, )
6981         (lookup_signed_typename): Remove cast.
6982         * eval.c (parse_to_comma_and_eval): Remove cast.
6983         * parse.c (write_dollar_variable): Remove cast.
6984         * block.h (struct block) <superblock>: Now const.
6985         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6986         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6987         (map_block): Make "block" const.
6988         * symfile.h (struct quick_symbol_functions)
6989         <map_matching_symbols>: Constify block argument to "callback".
6990         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6991         const.
6992         (find_pc_sect_compunit_symtab): Make "b" const.
6993         (find_symbol_at_address): Likewise.
6994         (search_symbols): Likewise.
6995         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6996         (dw2_debug_names_lookup_symbol): Likewise.
6997         (dw2_map_matching_symbols): Update.
6998         * p-valprint.c (pascal_val_print): Remove "block".
6999         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7000         (aux_add_nonlocal_symbols): Make "block" const.
7001         (resolve_subexp): Remove cast.
7002         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7003         const.
7004         (iterate_over_file_blocks): Likewise.
7005         * f-exp.y (%union) <bval>: Remove.
7006         * coffread.c (patch_opaque_types): Make "b" const.
7007         * spu-tdep.c (spu_catch_start): Make "block" const.
7008         * c-valprint.c (print_unpacked_pointer): Remove "block".
7009         * symmisc.c (dump_symtab_1): Make "b" const.
7010         (block_depth): Make "block" const.
7011         * d-exp.y (%union) <bval>: Remove.
7012         * cp-support.h (cp_lookup_rtti_type): Update.
7013         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7014         * psymtab.c (psym_lookup_symbol): Make "block" const.
7015         (maintenance_check_psymtabs): Make "b" const.
7016         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7017         (enumerate_locals, enumerate_args): Update.
7018         * python/py-symtab.c (stpy_global_block): Make "block" const.
7019         (stpy_static_block): Likewise.
7020         * inline-frame.c (block_starting_point_at): Make "new_block"
7021         const.
7022         * block.c (find_block_in_blockvector): Make return type const.
7023         (blockvector_for_pc_sect): Make "b" const.
7024         (find_block_in_blockvector): Make "b" const.
7025
7026 2019-03-23  Tom Tromey  <tom@tromey.com>
7027
7028         * varobj.c (varobj_create): Update.
7029         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7030         * printcmd.c (display_command, do_one_display): Don't reset
7031         innermost_block.
7032         * parser-defs.h (enum innermost_block_tracker_type): Move to
7033         expression.h.
7034         (innermost_block): Update comment.
7035         * parse.c (parse_exp_1): Add tracker_types parameter.
7036         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7037         tracker_types parameter.  Reset innermost_block.
7038         (parse_exp_in_context): Remove.
7039         (parse_expression_for_completion): Update.
7040         * objfiles.c (~objfile): Don't reset expression_context_block or
7041         innermost_block.
7042         * expression.h (enum innermost_block_tracker_type): Move from
7043         parser-defs.h.
7044         (parse_exp_1): Add tracker_types parameter.
7045         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7046         reset innermost_block.
7047
7048 2019-03-23  Tom Tromey  <tom@tromey.com>
7049
7050         * objfiles.h: Include bcache.h.
7051
7052 2019-03-23  Tom Tromey  <tom@tromey.com>
7053
7054         * linespec.c (get_current_search_block): Use
7055         scoped_restore_current_language.
7056         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7057
7058 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7059             Jiong Wang  <jiong.wang@arm.com>
7060
7061         * aarch64-linux-tdep.c
7062         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7063         section.
7064         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7065
7066 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7067             Jiong Wang  <jiong.wang@arm.com>
7068
7069         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7070         instructions.
7071         (aarch64_analyze_prologue_test): Add PACIASP test.
7072         (aarch64_prologue_prev_register): Unmask PC value.
7073
7074 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7075             Jiong Wang  <jiong.wang@arm.com>
7076
7077         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7078         (aarch64_dwarf2_prev_register): Unmask PC value.
7079         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7080         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7081         DW_CFA_AARCH64_negate_ra_state.
7082         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7083
7084 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7085             Jiong Wang  <jiong.wang@arm.com>
7086
7087         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7088         registers.
7089         (aarch64_pseudo_register_name): Likewise.
7090         (aarch64_pseudo_register_type): Likewise.
7091         (aarch64_pseudo_register_reggroup_p): Likewise.
7092         (aarch64_gdbarch_init): Add pauth registers.
7093         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7094         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7095         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7096         (struct gdbarch_tdep): Add regnum for ra_state.
7097
7098 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7099             Jiong Wang  <jiong.wang@arm.com>
7100
7101         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7102
7103 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7104             Jiong Wang  <jiong.wang@arm.com>
7105
7106         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7107         function.
7108         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7109         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7110         (aarch64_gdbarch_init): Add puth registers.
7111         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7112         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7113         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7114
7115 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7116             Jiong Wang  <jiong.wang@arm.com>
7117
7118         * aarch64-linux-nat.c
7119         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7120         * aarch64-linux-tdep.c
7121         (aarch64_linux_core_read_description): Likewise.
7122         (aarch64_linux_get_hwcap): New function.
7123         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7124         (aarch64_linux_get_hwcap): New declaration.
7125
7126 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7127             Jiong Wang  <jiong.wang@arm.com>
7128
7129         * aarch64-linux-nat.c
7130         (aarch64_linux_nat_target::read_description): Add pauth param.
7131         * aarch64-linux-tdep.c
7132         (aarch64_linux_core_read_description): Likewise.
7133         * aarch64-tdep.c (struct target_desc): Add in pauth.
7134         (aarch64_read_description): Add pauth param.
7135         (aarch64_gdbarch_init): Likewise.
7136         * aarch64-tdep.h (aarch64_read_description): Likewise.
7137         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7138         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7139         * features/Makefile: Add new files.
7140         * features/aarch64-pauth.c: New file.
7141         * features/aarch64-pauth.xml: New file.
7142
7143 2019-03-20  Tom Tromey  <tromey@adacore.com>
7144
7145         * infrun.c (handle_inferior_event): Rename from
7146         handle_inferior_event_1.  Create a scoped_value_mark.
7147         (handle_inferior_event): Remove.
7148
7149 2019-03-19  Tom Tromey  <tromey@adacore.com>
7150
7151         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7152         * infrun.h (print_stop_event): Add "displays" parameter.
7153         * infrun.c (print_stop_event): Add "displays" parameter.
7154
7155 2019-03-19  Pedro Alves  <palves@redhat.com>
7156
7157         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7158         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7159         to -1.  Fix TABs vs spaces.
7160         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7161         * tui/tui-out.h (tui_ui_out) Add intro comments.
7162         <m_line, m_start_of_line>: In-class initialize, and add describing
7163         comment.
7164
7165 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7166
7167         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7168         variable names.
7169         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7170
7171 2019-03-18  Pedro Alves  <palves@redhat.com>
7172             Eli Zaretskii <eliz@gnu.org>
7173
7174         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7175         m_line and m_start_of_line.
7176
7177 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7178
7179         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7180         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7181         it returns a newline.  This fixes a regression in TU mode, whereby
7182         the next line is output on the same screen line as the user input.
7183
7184 2019-03-18  Tom Tromey  <tromey@adacore.com>
7185
7186         * minsyms.c (minimal_symbol_reader::install): Remove call to
7187         obstack_blank.
7188
7189 2019-03-18  Pedro Alves  <palves@redhat.com>
7190
7191         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7192         New globals.
7193         (apply_style): New, factored out from ...
7194         (apply_ansi_escape): ... this.  Handle reverse video mode.
7195         (tui_set_reverse_mode): New function.
7196         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7197         * tui/tui-winsource.c (tui_show_source_line): Use
7198         tui_set_reverse_mode instead of setting A_STANDOUT.
7199         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7200         New setter methods.
7201
7202 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7203
7204         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7205         Handle tabs.
7206
7207 2019-03-18  Tom Tromey  <tromey@adacore.com>
7208
7209         * ada-lang.c (empty_array): Add "high" parameter.
7210         (ada_evaluate_subexp): Update.
7211
7212 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7213
7214         * unittests/string_view-selftests.c: Define
7215         _initialize_string_view_selftests unconditionally.
7216
7217 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7218
7219         PR gdb/24350
7220         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7221
7222 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7223
7224         PR gdb/24351
7225         * windows-nat.c (display_selector): Fix format specifiers.
7226
7227 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7228
7229         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7230         tui_refill_source_window instead of tui_refresh_win, to update the
7231         current execution line.  This fixes redisplay of the current line
7232         when stepping through the code with "next" or "step".
7233
7234 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7235
7236         * source-cache.c (source_cache::get_source_lines): Call
7237         find_source_lines to initialize s->nlines.  This fixes vertical
7238         scrolling of TUI source window when the DOWN arrow is pressed.
7239
7240 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7241
7242         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7243         linux-thread-db.c (_initialize_thread_db): Likewise.
7244
7245 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7246
7247         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7248         wclrtoeol in tui_show_source_line".  This reverts changes made in
7249         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7250
7251 2019-03-15  Tom Tromey  <tom@tromey.com>
7252
7253         * symtab.h (struct minimal_symbol): Derive from
7254         general_symbol_info.
7255         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7256         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7257         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7258         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7259         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7260         (MSYMBOL_SEARCH_NAME): Update.
7261         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7262         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7263         * minsyms.c (minimal_symbol_reader::record_full): Update.
7264
7265 2019-03-15  Tom Tromey  <tom@tromey.com>
7266
7267         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7268
7269 2019-03-15  Tom Tromey  <tom@tromey.com>
7270
7271         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7272         unique_xmalloc_ptr.
7273         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7274         Update.
7275         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7276         (build_minimal_symbol_hash_tables)
7277         (minimal_symbol_reader::install): Update.
7278
7279 2019-03-15  Tom Tromey  <tom@tromey.com>
7280
7281         * symtab.c (create_demangled_names_hash): Update.
7282         (symbol_set_names): Update.
7283         * objfiles.h (struct objfile_per_bfd_storage)
7284         <demangled_names_hash>: Now an htab_up.
7285         * objfiles.c (objfile_per_bfd_storage): Simplify.
7286
7287 2019-03-15  Tom Tromey  <tom@tromey.com>
7288
7289         * objfiles.h (struct objfile_per_bfd_storage): Declare
7290         destructor.
7291         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7292         New.
7293         (get_objfile_bfd_data): Use new.  Don't initialize
7294         language_of_main.
7295         (free_objfile_per_bfd_storage): Remove.
7296         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7297
7298 2019-03-15  Tom Tromey  <tom@tromey.com>
7299
7300         * symfile.c (reread_symbols): Update.
7301         * objfiles.c (objfile::objfile): Update.
7302         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7303         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7304         comment.
7305         (minimal_symbol_reader::install): Update.
7306         (terminate_minimal_symbol_table): Remove.
7307         * jit.c (jit_object_close_impl): Update.
7308
7309 2019-03-15  Tom Tromey  <tom@tromey.com>
7310
7311         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7312         initializations.
7313
7314 2019-03-15  Tom Tromey  <tom@tromey.com>
7315
7316         * objfiles.h (struct objfile_per_bfd_storage)
7317         <demangled_hash_languages>: Now a bitset.
7318         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7319         (lookup_minimal_symbol): Update.
7320
7321 2019-03-15  Tom Tromey  <tom@tromey.com>
7322
7323         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7324         Don't return the symbol.
7325         * coffread.c (record_minimal_symbol): Use record_full.
7326
7327 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7328
7329         The MS-Windows port of ncurses fails to switch to a color pair if
7330         one or both of the colors are the implicit default colors.  This
7331         change records the default colors when TUI is initialized, and
7332         then specifies them explicitly when a color pair uses the default
7333         colors.  This allows color styling in TUI mode on MS-Windows.
7334
7335         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7336         ncurses_norm_attr.
7337         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7338         colors in ncurses_norm_attr.
7339         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7340         "none", replace it with the default color recorded in
7341         ncurses_norm_attr.
7342
7343 2019-03-14  Tom Tromey  <tromey@adacore.com>
7344
7345         * source-cache.h (class source_cache) <get_source_lines>: Return
7346         std::string.
7347         * source-cache.c (source_cache::extract_lines): Handle case where
7348         first_pos==npos.  Return std::string.
7349         (source_cache::get_source_lines): Update.
7350
7351 2019-03-14  Tom Tromey  <tromey@adacore.com>
7352
7353         * NEWS: Add item for "style sources" commands.
7354         * source-cache.c (source_cache::get_source_lines): Check
7355         source_styling.
7356         * cli/cli-style.c (source_styling): New global.
7357         (_initialize_cli_style): Add "style sources" commands.
7358         (show_style_sources): New function.
7359         * cli/cli-style.h (source_styling): Declare.
7360
7361 2019-03-14  Pedro Alves  <palves@redhat.com>
7362             Tom Tromey  <tromey@adacore.com>
7363
7364         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7365         * tui/tui-winsource.c (tui_refill_source_window): New function,
7366         from...
7367         (tui_horizontal_source_scroll): ... here.  Move some logic.
7368         * cli/cli-style.c (set_style_enabled): Notify new observable.
7369         * tui/tui-hooks.c (tui_redisplay_source): New function.
7370         (tui_attach_detach_observers): Attach or detach
7371         tui_redisplay_source.
7372         * observable.h (source_styling_changed): New observable.
7373         * observable.c: Define source_styling_changed observable.
7374
7375 2019-03-13  Tom Tromey  <tromey@adacore.com>
7376
7377         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7378         (i386_gnu_nat_target::store_registers): Update.
7379         * target-debug.h (target_debug_print_std_string): New macro.
7380         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7381         * windows-tdep.c (display_one_tib): Update.
7382         * tui/tui-stack.c (tui_make_status_line): Update.
7383         * top.c (print_inferior_quit_action): Update.
7384         * thread.c (thr_try_catch_cmd): Update.
7385         (add_thread_with_info): Update.
7386         (thread_target_id_str): Update.
7387         (thr_try_catch_cmd): Update.
7388         (thread_command): Update.
7389         (thread_find_command): Update.
7390         * record-btrace.c (record_btrace_target::info_record)
7391         (record_btrace_resume_thread, record_btrace_target::resume)
7392         (record_btrace_cancel_resume, record_btrace_step_thread)
7393         (record_btrace_target::wait, record_btrace_target::wait)
7394         (record_btrace_target::wait, record_btrace_target::stop): Update.
7395         * progspace.c (print_program_space): Update.
7396         * process-stratum-target.c
7397         (process_stratum_target::thread_address_space): Update.
7398         * linux-fork.c (linux_fork_mourn_inferior)
7399         (detach_checkpoint_command, info_checkpoints_command)
7400         (linux_fork_context): Update.
7401         (linux_fork_detach): Update.
7402         (class scoped_switch_fork_info): Update.
7403         (delete_checkpoint_command): Update.
7404         * infrun.c (follow_fork_inferior): Update.
7405         (follow_fork_inferior): Update.
7406         (proceed_after_vfork_done): Update.
7407         (handle_vfork_child_exec_or_exit): Update.
7408         (follow_exec): Update.
7409         (displaced_step_prepare_throw): Update.
7410         (displaced_step_restore): Update.
7411         (start_step_over): Update.
7412         (resume_1): Update.
7413         (clear_proceed_status_thread): Update.
7414         (proceed): Update.
7415         (print_target_wait_results): Update.
7416         (do_target_wait): Update.
7417         (context_switch): Update.
7418         (stop_all_threads): Update.
7419         (restart_threads): Update.
7420         (finish_step_over): Update.
7421         (handle_signal_stop): Update.
7422         (switch_back_to_stepped_thread): Update.
7423         (keep_going_pass_signal): Update.
7424         (print_exited_reason): Update.
7425         (normal_stop): Update.
7426         * inferior.c (inferior_pid_to_str): Change return type.
7427         (print_selected_inferior): Update.
7428         (add_inferior): Update.
7429         (detach_inferior): Update.
7430         * dummy-frame.c (fprint_dummy_frames): Update.
7431         * dcache.c (dcache_info_1): Update.
7432         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7433         (btrace_fetch, btrace_clear): Update.
7434         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7435         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7436         type.
7437         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7438         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7439         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7440         * gdbarch.c, gdbarch.h: Rebuild.
7441         * gdbarch.sh (core_pid_to_str): Change return type.
7442         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7443         return type.
7444         (windows_nat_target::pid_to_str): Change return type.
7445         (windows_delete_thread): Update.
7446         (windows_nat_target::attach): Update.
7447         (windows_nat_target::files_info): Update.
7448         * target-delegates.c: Rebuild.
7449         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7450         return type.
7451         (sol_thread_target::pid_to_str): Change return type.
7452         * remote.c (class remote_target) <pid_to_str>: Change return
7453         type.
7454         (remote_target::pid_to_str): Change return type.
7455         (extended_remote_target::attach, remote_target::remote_stop_ns)
7456         (remote_target::remote_notif_remove_queued_reply)
7457         (remote_target::push_stop_reply, remote_target::disable_btrace):
7458         Update.
7459         (extended_remote_target::attach): Update.
7460         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7461         type.
7462         (gdbsim_target::pid_to_str): Change return type.
7463         * ravenscar-thread.c (struct ravenscar_thread_target)
7464         <pid_to_str>: Change return type.
7465         (ravenscar_thread_target::pid_to_str): Change return type.
7466         * procfs.c (class procfs_target) <pid_to_str>: Change return
7467         type.
7468         (procfs_target::pid_to_str): Change return type.
7469         (procfs_target::attach): Update.
7470         (procfs_target::detach): Update.
7471         (procfs_target::fetch_registers): Update.
7472         (procfs_target::store_registers): Update.
7473         (procfs_target::wait): Update.
7474         (procfs_target::files_info): Update.
7475         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7476         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7477         return type.
7478         (nto_procfs_target::pid_to_str): Change return type.
7479         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7480         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7481         return type.
7482         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7483         (exit_lwp): Update.
7484         (attach_proc_task_lwp_callback, get_detach_signal)
7485         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7486         (linux_nat_target::resume, wait_lwp, stop_callback)
7487         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7488         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7489         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7490         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7491         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7492         type.
7493         (inf_ptrace_target::attach): Update.
7494         (inf_ptrace_target::files_info): Update.
7495         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7496         type.
7497         (go32_nat_target::pid_to_str): Change return type.
7498         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7499         (gnu_nat_target::wait): Update.
7500         (gnu_nat_target::wait): Update.
7501         (gnu_nat_target::resume): Update.
7502         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7503         (fbsd_nat_target::wait): Update.
7504         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7505         type.
7506         (darwin_nat_target::attach): Update.
7507         * corelow.c (class core_target) <pid_to_str>: Change return type.
7508         (core_target::pid_to_str): Change return type.
7509         * target.c (normal_pid_to_str): Change return type.
7510         (default_pid_to_str): Likewise.
7511         (target_pid_to_str): Change return type.
7512         (target_translate_tls_address): Update.
7513         (target_announce_detach): Update.
7514         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7515         return type.
7516         (bsd_uthread_target::pid_to_str): Change return type.
7517         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7518         type.
7519         (bsd_kvm_target::pid_to_str): Change return type.
7520         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7521         return type.
7522         (aix_thread_target::pid_to_str): Change return type.
7523         * target.h (struct target_ops) <pid_to_str>: Change return type.
7524         (target_pid_to_str, normal_pid_to_str): Likewise.
7525         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7526         type.
7527         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7528         type.
7529         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7530         return type.
7531         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7532         type.
7533         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7534         type.
7535         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7536         return type.
7537
7538 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7539
7540         * NEWS: Mention that the new default MI version is 3.  Mention
7541         changes to the output of commands and events that deal with
7542         multi-location breakpoints.
7543         * breakpoint.c: Include "mi/mi-out.h".
7544         (print_one_breakpoint): Change output syntax if using MI version
7545         >= 3.
7546         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7547         New.
7548         (mi_multi_location_breakpoint_output_fixed): New.
7549         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7550         (mi_cmd_fix_multi_location_breakpoint_output): New.
7551         (mi_multi_location_breakpoint_output_fixed): New.
7552         * mi/mi-cmds.c (mi_cmds): Register command
7553         -fix-multi-location-breakpoint-output.
7554         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7555         interpreter "mi".
7556
7557 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7558
7559         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7560         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7561         instantiate mi_ui_out based on interpreter name.
7562         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7563         * mi/mi-main.c (mi_load_progress): Likewise.
7564
7565 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7566
7567         * NEWS: Combine separate "New targets" sections for 8.3.
7568
7569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7570
7571         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7572         (ppcfbsd_init_abi): Install gdbarch
7573         "fetch_tls_load_module_address" and "get_thread_local_address"
7574         methods.
7575
7576 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7577
7578         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7579         (riscv_fbsd_init_abi): Install gdbarch
7580         "fetch_tls_load_module_address" and "get_thread_local_address"
7581         methods.
7582
7583 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7584
7585         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7586         (i386fbsd_init_abi): Install gdbarch
7587         "fetch_tls_load_module_address" and "get_thread_local_address"
7588         methods.
7589
7590 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7591
7592         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7593         (amd64fbsd_init_abi): Install gdbarch
7594         "fetch_tls_load_module_address" and "get_thread_local_address"
7595         methods.
7596
7597 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7598
7599         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7600         (struct fbsd_pspace_data): New type.
7601         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7602         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7603         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7604         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7605         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7606
7607 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7608
7609         * gdbtypes.c (lookup_struct_elt): New function.
7610         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7611         * gdbtypes.h (struct struct_elt): New type.
7612         (lookup_struct_elt): New prototype.
7613
7614 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7615
7616         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7617         remove disabled code block.
7618
7619 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7620
7621         * gdbarch.sh (get_thread_local_address): New method.
7622         * gdbarch.h, gdbarch.c: Regenerate.
7623         * target.c (target_translate_tls_address): Use
7624         gdbarch_get_thread_local_address if present instead of
7625         target::get_thread_local_address.
7626
7627 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7628
7629         * target.h (target::get_thread_local_address): Update comment.
7630
7631 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7632
7633         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7634         objfile->separate_debug_objfile_backlink if not NULL.
7635
7636 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7637
7638         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7639         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7640         (amd64bsd_store_inferior_registers): Likewise.
7641         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7642         Enable segment base registers.
7643         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7644         PT_GETFSBASE and PT_GETGSBASE.
7645         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7646         PT_SETGSBASE.
7647         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7648         segment base registers.
7649         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7650
7651 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7652
7653         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7654         Update calls to i386_target_description to add 'segments'
7655         parameter.
7656         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7657         add segment base registers.
7658         * arch/i386.c (i386_create_target_description): Add 'segments'
7659         parameter to enable segment base registers.
7660         * arch/i386.h (i386_create_target_description): Likewise.
7661         * features/i386/32bit-segments.xml: New file.
7662         * features/i386/32bit-segments.c: Generate.
7663         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7664         call to i386_target_description to add 'segments' parameter.
7665         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7666         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7667         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7668         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7669         if feature is present.
7670         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7671         Add 'segments' parameter to call to i386_target_description.
7672         (i386_target_description): Add 'segments' parameter to enable
7673         segment base registers.
7674         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7675         to call to i386_target_description.
7676         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7677         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7678         Define I386_NUM_REGS.
7679         (i386_target_description): Add 'segments' parameter to enable
7680         segment base registers.
7681
7682 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7683
7684         PR/24325
7685         * source-cache.c: #undef open and close, to avoid unresolved
7686         externals during linking.
7687
7688 2019-03-12  Tom Tromey  <tromey@adacore.com>
7689
7690         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7691         const.  Add initializers.
7692         (_initialize_remote): Don't initialize ptid globals.
7693
7694 2019-03-12  Pedro Alves  <palves@redhat.com>
7695
7696         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7697
7698 2019-03-12  Pedro Alves  <palves@redhat.com>
7699
7700         * cp-name-parser.y (main): Remove unused 'len' variable.
7701
7702 2019-03-12  Tom Tromey  <tromey@adacore.com>
7703
7704         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7705         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7706
7707 2019-03-12  Tom Tromey  <tromey@adacore.com>
7708
7709         * linux-nat.c (iterate_over_lwps): Update.
7710         (stop_callback): Remove parameter.
7711         (stop_wait_callback, detach_callback, resume_set_callback)
7712         (select_singlestep_lwp_callback, set_ignore_sigint)
7713         (status_callback, resumed_callback, resume_clear_callback)
7714         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7715         data parameter.
7716         (linux_nat_target::detach, linux_nat_target::resume)
7717         (linux_stop_and_wait_all_lwps, select_event_lwp)
7718         (linux_nat_filter_event, linux_nat_wait_1)
7719         (linux_nat_target::kill, linux_nat_target::stop)
7720         (linux_nat_target::stop): Update.
7721         (linux_nat_resume_callback): Change type.
7722         (resume_stopped_resumed_lwps, count_events_callback)
7723         (select_event_lwp_callback): Likewise.
7724         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7725         * arm-linux-nat.c (struct update_registers_data): Remove.
7726         (update_registers_callback): Change type.
7727         (arm_linux_insert_hw_breakpoint1): Update.
7728         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7729         parameter.
7730         (x86_linux_dr_set_addr): Update.
7731         (x86_linux_dr_set_control): Update.
7732         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7733         (iterate_over_lwps): Use gdb::function_view.
7734         * nat/aarch64-linux-hw-point.c (struct
7735         aarch64_dr_update_callback_param): Remove.
7736         (debug_reg_change_callback): Change type.
7737         (aarch64_notify_debug_reg_change): Update.
7738         * s390-linux-nat.c (s390_refresh_per_info): Update.
7739
7740 2019-03-11  Tom Tromey  <tromey@adacore.com>
7741
7742         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7743         redundant assignment to "this_cu".
7744
7745 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7746
7747         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7748
7749 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7750
7751         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7752         from...
7753         (rank_one_type): ... this.
7754
7755 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7756
7757         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7758         from...
7759         (rank_one_type): ... this.
7760
7761 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7762
7763         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7764         from...
7765         (rank_one_type): ... this.
7766
7767 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7768
7769         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7770         from...
7771         (rank_one_type): ... this.
7772
7773 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7774
7775         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7776         from...
7777         (rank_one_type): ... this.
7778
7779 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7780
7781         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7782         from...
7783         (rank_one_type): ... this.
7784
7785 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7786
7787         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7788         from...
7789         (rank_one_type): ... this.
7790
7791 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7792
7793         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7794         from...
7795         (rank_one_type): ... this.
7796
7797 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7798
7799         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7800         from...
7801         (rank_one_type): ... this.
7802
7803 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7804
7805         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7806         from...
7807         (rank_one_type): ... this.
7808
7809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7810
7811         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7812         from...
7813         (rank_one_type): ... this.
7814
7815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7816
7817         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7818         from...
7819         (rank_one_type): ... this.
7820
7821 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7822
7823         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7824         inferior-events' shows the example events.
7825
7826 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7827
7828         Support styling on native MS-Windows console
7829
7830         PR/24315
7831         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7832         on MS-Windows if $TERM is not defined.
7833
7834         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7835
7836         * posix-hdep.c (gdb_console_fputs):
7837         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7838         functions.
7839         * ui-file.h (gdb_console_fputs): Add prototype.
7840
7841         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7842         back to fputs only if the former returns zero.
7843
7844 2019-03-07  Tom Tromey  <tom@tromey.com>
7845
7846         * symmisc.c (print_symbol_bcache_statistics): Update.
7847         (print_objfile_statistics): Update.
7848         * symfile.c (allocate_symtab): Update.
7849         * stabsread.c: Don't include bcache.h.
7850         * psymtab.h (struct psymbol_bcache): Don't declare.
7851         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7852         (psymbol_bcache_init, psymbol_bcache_free)
7853         (psymbol_bcache_get_bcache): Don't declare.
7854         * psymtab.c (struct psymbol_bcache): Remove.
7855         (psymtab_storage::psymtab_storage): Update.
7856         (psymtab_storage::~psymtab_storage): Update.
7857         (psymbol_bcache_init, psymbol_bcache_free)
7858         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7859         (add_psymbol_to_bcache): Update.
7860         (allocate_psymtab): Update.
7861         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7862         macro_cache>: No longer pointers.
7863         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7864         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7865         * macrotab.c (macro_bcache): Update.
7866         * macroexp.c: Don't include bcache.h.
7867         * gdbtypes.c (check_types_worklist): Update.
7868         (types_deeply_equal): Remove TRY/CATCH.  Update.
7869         * elfread.c (elf_symtab_read): Update.
7870         * dwarf2read.c: Don't include bcache.h.
7871         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7872         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7873         (print_bcache_statistics, bcache_memory_used): Don't declare.
7874         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7875         methods.  Rename all data members.
7876         * bcache.c (struct bcache): Move to bcache.h.
7877         (bcache::expand_hash_table): Rename from expand_hash_table.
7878         (bcache): Remove.
7879         (bcache::insert): Rename from bcache_full.
7880         (bcache::compare): Rename from bcache_compare.
7881         (bcache_xmalloc): Remove.
7882         (bcache::~bcache): Rename from bcache_xfree.
7883         (bcache::print_statistics): Rename from print_bcache_statistics.
7884         (bcache::memory_used): Rename from bcache_memory_used.
7885
7886 2019-03-07  Pedro Alves  <palves@redhat.com>
7887
7888         * infrun.c (normal_stop): Also check for
7889         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7890
7891 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7892
7893         * f-lang.c (value_from_host_double): Moved to...
7894         * value.c (value_from_host_double): ...here.
7895         * value.h (value_from_host_double): Declare.
7896         * guile/scm-math.c (vlscm_convert_typed_number): Use
7897         value_from_host_double.
7898         (vlscm_convert_number): Likewise.
7899         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7900         * python/py-value.c (convert_value_from_python): Likewise.
7901
7902 2019-03-06  Tom Tromey  <tom@tromey.com>
7903
7904         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7905
7906 2019-03-06  Tom Tromey  <tom@tromey.com>
7907
7908         * utils.h (free_current_contents): Don't declare.
7909         * utils.c (free_current_contents): Remove.
7910
7911 2019-03-06  Tom Tromey  <tom@tromey.com>
7912
7913         * top.c (quit_force): Update.
7914         * main.c (captured_command_loop): Update.
7915         * common/new-op.c (operator new): Update.
7916         * common/common-exceptions.c (struct catcher)
7917         <save_cleanup_chain>: Remove member.
7918         (exceptions_state_mc_init): Update.
7919         (exception_try_scope_entry): Return nullptr.
7920         (exception_try_scope_exit, exception_rethrow)
7921         (throw_exception_sjlj, throw_exception_cxx): Update.
7922         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7923         (all_cleanups, do_cleanups, discard_cleanups)
7924         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7925         (restore_cleanups, restore_final_cleanups): Don't declare.
7926         (do_final_cleanups): Remove parameter.
7927         * common/cleanups.c (cleanup_chain, make_cleanup)
7928         (make_cleanup_dtor, all_cleanups, do_cleanups)
7929         (discard_my_cleanups, discard_cleanups)
7930         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7931         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7932         (null_cleanup): Remove.
7933         (do_final_cleanups): Remove parameter.
7934
7935 2019-03-06  Tom Tromey  <tom@tromey.com>
7936
7937         * remote.c (remote_target::remote_parse_stop_reply): Use
7938         unique_xmalloc_ptr.
7939
7940 2019-03-06  Tom Tromey  <tom@tromey.com>
7941
7942         * stabsread.c (struct stabs_field_info): Rename from field_info.
7943         <list, fnlist>: Add initializers.
7944         <obstack>: New member.
7945         (read_member_functions, read_struct_fields, read_baseclasses):
7946         Allocate on obstack.  Don't use cleanups.
7947         (read_one_struct_field, read_member_functions, read_struct_fields)
7948         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7949         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7950         (read_struct_type): Update.
7951
7952 2019-03-06  Tom Tromey  <tom@tromey.com>
7953
7954         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7955         * common/filestuff.h (make_cleanup_close): Don't declare.
7956         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7957         Remove.
7958
7959 2019-03-06  Tom Tromey  <tom@tromey.com>
7960
7961         * solib-aix.c: Use make_scope_exit.
7962
7963 2019-03-06  Tom Tromey  <tom@tromey.com>
7964
7965         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7966         Use make_scope_exit.
7967
7968 2019-03-06  Tom Tromey  <tom@tromey.com>
7969
7970         * solib-svr4.c (disable_probes_interface): Remove parameter.
7971         (svr4_handle_solib_event): Use make_scope_exit.
7972
7973 2019-03-06  Tom Tromey  <tom@tromey.com>
7974
7975         * remote.c (struct stop_reply_deleter): Remove.
7976         (stop_reply_up): Update.
7977         (struct stop_reply): Derive from notif_event.  Don't typedef.
7978         <regcache>: Now a std::vector.
7979         (stop_reply_xfree): Remove.
7980         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7981         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7982         (remote_target::discard_pending_stop_replies): Use delete.
7983         (remote_target::remote_parse_stop_reply): Update.
7984         (remote_target::process_stop_reply): Update.
7985         * remote-notif.h (struct notif_event): Add virtual destructor.
7986         Remove "dtr" member.
7987         (struct notif_client) <alloc_event>: Return a unique_ptr.
7988         (notif_event_xfree): Don't declare.
7989         (notif_event_up): New typedef.
7990         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7991         (notif_event_xfree, do_notif_event_xfree): Remove.
7992         (remote_notif_state_xfree): Update.
7993
7994 2019-03-06  Tom Tromey  <tom@tromey.com>
7995
7996         * infrun.c (displaced_step_clear_cleanup): Now a
7997         forward_scope_exit type.
7998         (displaced_step_prepare_throw): Update.
7999         (displaced_step_fixup): Update.
8000
8001 2019-03-06  Tom Tromey  <tom@tromey.com>
8002
8003         * inferior.h (class inferior): Update comment.
8004         * gdbthread.h (class thread_info): Update comment.
8005
8006 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8007             Tom Tromey  <tom@tromey.com>
8008
8009         * stabsread.h (struct stab_section_list): Remove.
8010         (coffstab_build_psymtabs): Update.
8011         * dbxread.c (symbuf_sections): Now a std::vector.
8012         (sect_idx): New global.
8013         (fill_symbuf): Update.
8014         (coffstab_build_psymtabs): Change type of stabsects parameter.
8015         Update.
8016         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8017         std::vector.
8018         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8019         (coff_locate_sections): Update.
8020         (coff_symfile_read): Remove cleanups.  Update.
8021         (init_stringtab): Add storage parameter.
8022         (free_stringtab, free_stringtab_cleanup): Remove.
8023         (init_lineno): Add storage parameter.
8024         (free_linetab, free_linetab_cleanup): Remove.
8025
8026 2019-03-06  Pedro Alves  <palves@redhat.com>
8027
8028         * linux-fork.c (fork_info::clobber_regs): Delete.
8029         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8030         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8031         comment.  Adjust.
8032         (scoped_switch_fork_info::scoped_switch_fork_info)
8033         (checkpoint_command, linux_fork_context): Adjust
8034         fork_save_infrun_state calls.
8035
8036 2019-03-06  Pedro Alves  <palves@redhat.com>
8037
8038         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8039         (inf_has_multiple_threads): Return 'bool' and rewrite using
8040         inferior_info::threads().
8041
8042 2019-03-06  Pedro Alves  <palves@redhat.com>
8043
8044         * linux-fork.c: Include <list>.
8045         (fork_list): Now a std::list instance.
8046         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8047         (forks_exist_p, find_last_fork): Adjust.
8048         (new_fork): Delete.
8049         (one_fork_p): New.
8050         (add_fork): Adjust.
8051         (free_fork): Delete, folded into fork_info::~fork_info().
8052         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8053         Adjust.
8054         (init_fork_list): Delete.
8055         (linux_fork_killall, linux_fork_mourn_inferior)
8056         (linux_fork_detach, info_checkpoints_command): Adjust.
8057         (_initialize_linux_fork): No longer call init_fork_list.
8058
8059 2019-03-06  Pedro Alves  <palves@redhat.com>
8060
8061         * linux-fork.c (new_fork): New, split out of ...
8062         (add_fork): ... this.  Return void.  Move "first fork" special
8063         case from here, to ...
8064         (checkpoint_command): ... here.
8065         * linux-linux.h (add_fork): Return void.
8066
8067 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8068
8069         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8070
8071 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8072             Chris January  <chris.january@arm.com>
8073             David Lecomber  <david.lecomber@arm.com>
8074
8075         * f-exp.y: New token, UNOP_INTRINSIC.
8076         (exp): New pattern using UNOP_INTRINSIC token.
8077         (f77_keywords): Add 'abs' keyword.
8078         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8079         (value_from_host_double): New function.
8080         (evaluate_subexp_f): Support UNOP_ABS.
8081
8082 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8083
8084         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8085         types.
8086
8087 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8088
8089         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8090         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8091         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8092
8093 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8094
8095         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8096
8097 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8098             Chris January  <chris.january@arm.com>
8099
8100         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8101         * f-exp.y: Define 'KIND' token.
8102         (exp): New pattern for KIND expressions.
8103         (ptype): Handle types with a kind extension.
8104         (direct_abs_decl): Extend to spot kind extensions.
8105         (f77_keywords): Add 'kind' to the list.
8106         (push_kind_type): New function.
8107         (convert_to_kind_type): New function.
8108         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8109         * parse.c (operator_length_standard): Likewise.
8110         * parser-defs.h (enum type_pieces): Add tp_kind.
8111         * std-operator.def: Add UNOP_KIND.
8112
8113 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8114
8115         * f-exp.y (f_parse): Set yydebug.
8116
8117 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8118
8119         * f-lang.c (evaluate_subexp_f): New function.
8120         (exp_descriptor_f): New global.
8121         (f_language_defn): Use exp_descriptor_f instead of
8122         exp_descriptor_standard.
8123
8124 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8125
8126         * f-exp.y (struct token): Add comments.
8127         (dot_ops): Remove uppercase versions and the end marker.
8128         (f77_keywords): Likewise.
8129         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8130         entries in the dot_ops array are case insensitive, and use
8131         strncasecmp to compare strings.  Also some whitespace cleanup in
8132         this area.  Similar for the f77_keywords array, except entries in
8133         this list might be case sensitive.
8134
8135 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8136
8137         * f-exp.y (struct f77_boolean_val): Add comments.
8138         (boolean_values): Remove uppercase versions, and end marker.
8139         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8140         and use strncasecmp to achieve case insensitivity.  Additionally,
8141         perform whitespace cleanup around this code.
8142
8143 2019-03-06  Tom Tromey  <tromey@adacore.com>
8144
8145         * remote-sim.c (gdbsim_target_open): Use result of
8146         gdb_argv::release.
8147
8148 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8149         Dirk Schubert  <dirk.schubert@arm.com>
8150         Chris January  <chris.january@arm.com>
8151
8152         * eval.c (evaluate_subexp_standard): Call Fortran argument
8153         wrapping logic.
8154         * f-lang.c (struct value): A value which can be passed into a
8155         Fortran function call.
8156         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8157         where appropriate.
8158         (struct type): Value ready for a Fortran function call.
8159         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8160         is needed.
8161         * f-lang.h (fortran_argument_convert): Declaration.
8162         (fortran_preserve_arg_pointer): Declaration.
8163         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8164
8165 2019-03-05  Tom Tromey  <tromey@adacore.com>
8166
8167         * python/py-prettyprint.c (print_string_repr): Remove #if.
8168         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8169
8170 2019-03-05  Tom Tromey  <tromey@adacore.com>
8171
8172         * target.c (the_dummy_target): Move later.  Change type to
8173         "dummy_target".
8174         (initialize_targets): Don't initialize the_dummy_target.
8175
8176 2019-03-05  Tom Tromey  <tromey@adacore.com>
8177
8178         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8179         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8180
8181 2019-03-05  Tom Tromey  <tromey@adacore.com>
8182
8183         * windows-nat.c (windows_nat_target::attach)
8184         (windows_nat_target::detach): Don't call gdb_flush.
8185         * valprint.c (generic_val_print, val_print, val_print_string):
8186         Don't call gdb_flush.
8187         * utils.c (defaulted_query): Don't call gdb_flush.
8188         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8189         * target.c (target_announce_detach): Don't call gdb_flush.
8190         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8191         * remote.c (extended_remote_target::attach): Don't call
8192         gdb_flush.
8193         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8194         * printcmd.c (do_examine): Don't call gdb_flush.
8195         (info_display_command): Don't call gdb_flush.
8196         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8197         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8198         * memattr.c (info_mem_command): Don't call gdb_flush.
8199         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8200         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8201         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8202         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8203         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8204         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8205         (gnu_nat_target::detach): Don't call gdb_flush.
8206         * f-valprint.c (f_val_print): Don't call gdb_flush.
8207         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8208         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8209         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8210         gdb_flush.
8211         * c-valprint.c (c_val_print): Don't call gdb_flush.
8212         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8213
8214 2019-03-05  Tom Tromey  <tromey@adacore.com>
8215
8216         * varobj.c (update_dynamic_varobj_children): Update.
8217         (install_default_visualizer): Use reset, not release.
8218         * value.c (set_internalvar): Update.
8219         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8220         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8221         ATTRIBUTE_UNUSED_RESULT.
8222
8223 2019-03-05  Tom Tromey  <tromey@adacore.com>
8224
8225         * remote.c (class scoped_remote_fd) <release>: Add
8226         ATTRIBUTE_UNUSED_RESULT.
8227
8228 2019-03-05  Tom Tromey  <tromey@adacore.com>
8229
8230         * macroexp.c (struct macro_buffer) <release>: Add
8231         ATTRIBUTE_UNUSED_RESULT.
8232
8233 2019-03-05  Tom Tromey  <tromey@adacore.com>
8234
8235         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8236         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8237         ATTRIBUTE_UNUSED_RESULT.
8238
8239 2019-03-05  Tom Tromey  <tromey@adacore.com>
8240
8241         * common/scoped_fd.h (class scoped_fd) <release>: Add
8242         ATTRIBUTE_UNUSED_RESULT.
8243
8244 2019-03-05  Tom Tromey  <tromey@adacore.com>
8245
8246         * parser-defs.h (struct parser_state) <release>: Add
8247         ATTRIBUTE_UNUSED_RESULT.
8248
8249 2019-03-05  Tom Tromey  <tromey@adacore.com>
8250
8251         * utils.h (class gdb_argv) <release>: Add
8252         ATTRIBUTE_UNUSED_RESULT.
8253         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8254
8255 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8256
8257         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8258         for-loop range, to avoid compiler warnings.
8259
8260         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8261         avoid compiler warnings about unused variables.
8262
8263         * NEWS: Mention end of support for native debugging on MS-Windows
8264         before XP.
8265
8266         PR gdb/24292
8267         * common/netstuff.c:
8268         * gdbserver/gdbreplay.c
8269         * gdbserver/remote-utils.c:
8270         * ser-tcp.c:
8271         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8272         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8273         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8274         'getaddrinfo' and 'freeaddrinfo' were not available before
8275         Windows XP, and mingw.org's MinGW headers by default define
8276         _WIN32_WINNT to 0x500.
8277
8278 2019-03-01  Gary Benson <gbenson@redhat.com>
8279
8280         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8281
8282 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8283             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8284
8285         PR gdb/8527
8286         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8287         set_sigint_trap, clear_sigint_trap.
8288
8289 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8290
8291         * target.c (target_detach): Clear the regcache and the
8292         frame cache.
8293
8294 2019-02-27  Pedro Alves  <palves@redhat.com>
8295
8296         * utils.c (set_screen_size): When we cap the height/width sizes,
8297         tweak the corresponding command variable to show "unlimited":
8298
8299 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8300             Pedro Alves  <palves@redhat.com>
8301
8302         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8303         before calling rl_set_screen_size.
8304
8305 2019-02-27  Tom Tromey  <tromey@adacore.com>
8306
8307         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8308         define.
8309         * python/py-value.c: Remove Python 2.4 workaround.
8310         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8311         workaround.
8312         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8313         Python 2.4 workaround.
8314         * python/python-internal.h: Remove Python 2.4 comment.
8315         (Py_ssize_t): Don't define.
8316         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8317         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8318         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8319         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8320         * python/python.c (do_start_initialization): Remove Python 2.4
8321         workaround.
8322         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8323         (print_children): Remove Python 2.4 workaround.
8324         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8325         workaround.
8326         (CHARBUFFERPROC_NAME): Remove.
8327         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8328         Python 2.4 workaround.
8329
8330 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8331
8332         * NEWS: Note minimum Python version.
8333
8334 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8335
8336         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8337         code from these functions.  Remove corresponding ifdefs.  Use
8338         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8339         Remove gotos and target of gotos.
8340         (infpy_search_memory): Likewise.
8341
8342 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8343
8344         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8345         (hppa_gdbarch_init): Don't register deleted functions with
8346         gdbarch.
8347
8348 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8349
8350         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8351         (h8300_unwind_sp): Delete.
8352         (h8300_dummy_id): Delete.
8353         (h8300_gdbarch_init): Don't register deleted functions with
8354         gdbarch.
8355
8356 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8357
8358         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8359         (ft32_unwind_pc): Delete.
8360         (ft32_unwind_sp): Delete.
8361         (ft32_gdbarch_init): Don't register deleted functions with
8362         gdbarch.
8363
8364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8365
8366         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8367         (frv_unwind_pc): Delete.
8368         (frv_unwind_sp): Delete.
8369         (frv_gdbarch_init): Don't register deleted functions with
8370         gdbarch.
8371
8372 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8373
8374         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8375         (riscv_unwind_pc): Delete.
8376         (riscv_unwind_sp): Delete.
8377         (riscv_gdbarch_init): Don't register deleted functions with
8378         gdbarch.
8379
8380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8381
8382         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8383         (csky_unwind_pc): Delete.
8384         (csky_unwind_sp): Delete.
8385         (csky_gdbarch_init): Don't register deleted functions with
8386         gdbarch.
8387
8388 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8389
8390         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8391         (cris_unwind_pc): Delete.
8392         (cris_unwind_sp): Delete.
8393         (cris_gdbarch_init): Don't register deleted functions with
8394         gdbarch.
8395
8396 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8397
8398         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8399         (bfin_unwind_pc): Delete.
8400         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8401
8402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8403
8404         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8405         (arm_unwind_pc): Delete.
8406         (arm_unwind_sp): Delete.
8407         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8408
8409 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8410
8411         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8412         (arc_unwind_pc): Delete.
8413         (arc_unwind_sp): Delete.
8414         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8415
8416 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8417
8418         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8419         (alpha_unwind_pc): Delete.
8420         (alpha_gdbarch_init): Don't register deleted functions with
8421         gdbarch.
8422
8423 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8424
8425         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8426         (aarch64_unwind_pc): Delete.
8427         (aarch64_unwind_sp): Delete.
8428         (aarch64_gdbarch_init): Don't register deleted functions with
8429         gdbarch.
8430
8431 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8432
8433         * gdbtypes.c (type_align): Don't consider static members when
8434         computing structure alignment.
8435
8436 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8437
8438         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8439         return 0 for other types.
8440         * arch-utils.c (default_type_align): Always return 0.
8441         * gdbarch.h: Regenerate.
8442         * gdbarch.sh (type_align): Extend comment.
8443         * gdbtypes.c (type_align): Add additional comments, always call
8444         gdbarch_type_align before applying the default rules.
8445         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8446         generic code will then apply a suitable default.
8447         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8448         types, return 0 for other types.
8449
8450 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8451
8452         * NEWS: Create a new section for the next release branch.
8453         Rename the section of the current branch, now that it has
8454         been cut.
8455
8456 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8457
8458         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8459         * version.in: Bump version to 8.3.50.DATE-git.
8460
8461 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8462
8463         * aix-thread.c (ptid_cmp): Remove unused variable.
8464         (get_signaled_thread): Likewise.
8465         (store_regs_user_thread): Likewise.
8466         (store_regs_kernel_thread): Likewise.
8467         (fetch_regs_kernel_thread): Remove shadowed variable.
8468
8469 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8470
8471         * features/riscv/32bit-cpu.xml: Add register numbers.
8472         * features/riscv/32bit-fpu.c: Regenerate.
8473         * features/riscv/32bit-fpu.xml: Add register numbers.
8474         * features/riscv/64bit-cpu.xml: Add register numbers.
8475         * features/riscv/64bit-fpu.c: Regenerate.
8476         * features/riscv/64bit-fpu.xml: Add register numbers.
8477
8478 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8479
8480         * NEWS: Mention two argument form of gdb.Value constructor.
8481         * python/py-value.c (convert_buffer_and_type_to_value): New
8482         function.
8483         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8484         Add support for handling an optional second argument.  Call
8485         convert_buffer_and_type_to_value as appropriate.
8486         * python/python-internal.h (Py_buffer_deleter): New struct.
8487         (Py_buffer_up): New typedef.
8488
8489 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8490
8491         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8492         instead of releasing ownership.
8493
8494 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8495
8496         * dwarf2read.c (open_and_init_dwp_file): Call
8497         elf_numsections instead of bfd_count_sections to initialize
8498         dwp_file->num_sections.
8499
8500 2019-02-25  Tom Tromey  <tromey@adacore.com>
8501
8502         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8503
8504 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8505
8506         * gcore.in: Add '--readnever' option when invoking GDB.
8507
8508 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8509
8510         * MAINTAINERS: Update my email address.
8511
8512 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8513
8514         * build-id.c (build_id_to_debug_bfd_1): New function.
8515         (build_id_to_debug_bfd): Look for separate debug file in
8516         sysroot.
8517
8518 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8519
8520         * gdbarch.sh: Update the copyright year range that is placed into
8521         generated files.
8522
8523 2019-02-22  Keith Seitz  <keiths@redhat.com>
8524
8525         PR symtab/23853
8526         * linespec.c (create_sals_line_offset): Search for the default
8527         symtab's filename instead of its fullname.
8528
8529 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8530
8531         * NEWS: Update style defaults.
8532
8533 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8534
8535         * main.c (captured_main_1): Disable styling in batch mode.
8536
8537 2019-02-20  Tom Tromey  <tom@tromey.com>
8538
8539         * symtab.c (symtab_symbol_info): Fix typos.
8540
8541 2019-02-20  Tom Tromey  <tromey@adacore.com>
8542
8543         * findcmd.c (_initialize_mem_search): Use upper case for
8544         metasyntactic variables.
8545
8546 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8547
8548         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8549         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8550
8551 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8552
8553         * top.h (source_file_name): Change to std::string.
8554         * top.c (source_file_name): Likewise.
8555         (command_line_input): Adjust.
8556         * cli/cli-script.c (script_from_file): Adjust.
8557
8558 2019-02-19  Tom Tromey  <tromey@adacore.com>
8559
8560         * ravenscar-thread.c
8561         (ravenscar_thread_target::update_thread_list): Don't call
8562         ada_build_task_list.
8563         * ada-lang.h (ada_build_task_list): Don't declare.
8564         * ada-tasks.c (struct ada_tasks_inferior_data)
8565         <task_list_valid_p>: Now bool.
8566         (read_known_tasks, ada_task_list_changed)
8567         (ada_tasks_invalidate_inferior_data): Update.
8568         (read_known_tasks_array): Return bool.
8569         (read_known_tasks_list): Likewise.
8570         (read_known_tasks): Return void.
8571         (ada_build_task_list): Now static.
8572
8573 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8574
8575         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8576         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8577
8578 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8579
8580         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8581         variant for ada_tasks_pspace_data_handle and
8582         ada_tasks_inferior_data_handle.
8583         (ada_tasks_pspace_data_cleanup): New function.
8584         (ada_tasks_inferior_data_cleanup): New function.
8585
8586 2019-02-17  Tom Tromey  <tom@tromey.com>
8587
8588         * macrotab.h (macro_source_fullname): Return a std::string.
8589         * macrotab.c (macro_include, check_for_redefinition)
8590         (macro_undef, macro_lookup_definition, foreach_macro)
8591         (foreach_macro_in_scope): Update.
8592         (macro_source_fullname): Return a std::string.
8593         * macrocmd.c (show_pp_source_pos): Update.
8594
8595 2019-02-17  Tom Tromey  <tom@tromey.com>
8596
8597         * macrocmd.c (show_pp_source_pos): Style the file names.
8598
8599 2019-02-17  Tom Tromey  <tom@tromey.com>
8600
8601         PR tui/24197:
8602         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8603
8604 2019-02-17  Tom Tromey  <tom@tromey.com>
8605
8606         * ada-lang.c (user_select_syms): Use filtered printing.
8607         * utils.c (wrap_style): New global.
8608         (desired_style): Remove.
8609         (emit_style_escape): Add stream parameter.
8610         (set_output_style, reset_terminal_style, prompt_for_continue):
8611         Update.
8612         (flush_wrap_buffer): Only flush gdb_stdout.
8613         (wrap_here): Set wrap_style.
8614         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8615         treat escape sequences as a character.  Change when wrap buffer is
8616         flushed.
8617         (fputs_styled): Do not set the output style when the default is
8618         requested.
8619         * ui-style.h (struct ui_file_style) <is_default>: New method.
8620         * source.c (print_source_lines_base): Emit escape sequences in one
8621         piece.
8622
8623 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8624
8625         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8626         integers and enumeration types.
8627
8628 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8629
8630         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8631         instead of lookup_symbol_in_language
8632         (do_exact_match): New function.
8633         (ada_get_symbol_name_matcher): Return do_exact_match when
8634         doing a verbatim match.
8635
8636 2019-02-15  Tom Tromey  <tromey@adacore.com>
8637
8638         * ravenscar-thread.c (ravenscar_thread_target::resume)
8639         (ravenscar_thread_target::wait): Special case wildcard requests.
8640
8641 2019-02-15  Tom Tromey  <tromey@adacore.com>
8642
8643         * ravenscar-thread.c (base_ptid): Remove.
8644         (struct ravenscar_thread_target) <close>: New method.
8645         <m_base_ptid>: New member.
8646         <update_inferior_ptid, active_task, task_is_currently_active,
8647         runtime_initialized>: Declare methods.
8648         <ravenscar_thread_target>: Add constructor.
8649         (ravenscar_thread_target::task_is_currently_active)
8650         (ravenscar_thread_target::update_inferior_ptid)
8651         (ravenscar_runtime_initialized): Rename.  Now methods.
8652         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8653         (ravenscar_thread_target::update_thread_list): Update.
8654         (ravenscar_thread_target::active_task): Now method.
8655         (ravenscar_thread_target::store_registers)
8656         (ravenscar_thread_target::prepare_to_store)
8657         (ravenscar_thread_target::prepare_to_store)
8658         (ravenscar_thread_target::mourn_inferior): Update.
8659         (ravenscar_inferior_created): Use "new" to create target.
8660         (ravenscar_thread_target::get_ada_task_ptid): Update.
8661         (_initialize_ravenscar): Don't initialize base_ptid.
8662         (ravenscar_ops): Remove global.
8663
8664 2019-02-15  Tom Tromey  <tromey@adacore.com>
8665
8666         * target.h (push_target): Declare new overload.
8667         * target.c (push_target): New overload, taking an rvalue reference.
8668         * remote.c (remote_target::open_1): Use push_target overload.
8669         * corelow.c (core_target_open): Use push_target overload.
8670
8671 2019-02-15  Tom Tromey  <tromey@adacore.com>
8672
8673         * ravenscar-thread.c (is_ravenscar_task)
8674         (ravenscar_task_is_currently_active): Return bool.
8675         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8676         (_initialize_ravenscar): Remove "(void)".
8677         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8678         Return bool.
8679
8680 2019-02-15  Tom Tromey  <tromey@adacore.com>
8681
8682         * ravenscar-thread.c (ravenscar_runtime_initializer)
8683         (has_ravenscar_runtime, get_running_thread_id)
8684         (ravenscar_thread_target::resume): Fix indentation.
8685
8686 2019-02-15  Tom Tromey  <tromey@adacore.com>
8687
8688         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8689         from ravenscar_arch_ops.
8690         (sparc_ravenscar_ops::fetch_registers)
8691         (sparc_ravenscar_ops::store_registers): Now methods.
8692         (sparc_ravenscar_prepare_to_store): Remove.
8693         (sparc_ravenscar_ops): Redefine.
8694         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8695         methods and destructor.  Remove members.
8696         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8697         (ravenscar_thread_target::store_registers)
8698         (ravenscar_thread_target::prepare_to_store): Update.
8699         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8700         Remove.
8701         (struct ppc_ravenscar_powerpc_ops): Derive from
8702         ravenscar_arch_ops.
8703         (ppc_ravenscar_powerpc_ops::fetch_registers)
8704         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8705         (ppc_ravenscar_powerpc_ops): Redefine.
8706         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8707         (ppc_ravenscar_e500_ops::fetch_registers)
8708         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8709         (ppc_ravenscar_e500_ops): Redefine.
8710         * aarch64-ravenscar-thread.c
8711         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8712         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8713         (aarch64_ravenscar_fetch_registers)
8714         (aarch64_ravenscar_store_registers): Now methods.
8715         (aarch64_ravenscar_ops): Redefine.
8716
8717 2019-02-15  Tom Tromey  <tromey@adacore.com>
8718
8719         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8720         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8721         (ravenscar_thread_target::stopped_by_watchpoint)
8722         (ravenscar_thread_target::stopped_data_address)
8723         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8724
8725 2019-02-15  Tom Tromey  <tromey@adacore.com>
8726
8727         * ravenscar-thread.c: Fix some typos.
8728
8729 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8730             Tom Tromey  <tromey@adacore.com>
8731
8732         * ada-lang.c (ada_exception_sal): Change addr_string to a
8733         std::string.
8734         (create_ada_exception_catchpoint): Update.
8735
8736 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8737             Tom Tromey  <tromey@adacore.com>
8738
8739         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8740         (bp_location_ops): Remove.
8741         (base_breakpoint_allocate_location): Update.
8742         (free_bp_location): Update.
8743         * ada-lang.c (class ada_catchpoint_location)
8744         <ada_catchpoint_location>: Remove ops parameter.
8745         (ada_catchpoint_location_dtor): Remove.
8746         (ada_catchpoint_location_ops): Remove.
8747         (allocate_location_exception): Update.
8748         * breakpoint.h (struct bp_location_ops): Remove.
8749         (class bp_location) <bp_location>: Remove bp_location_ops
8750         parameter.
8751         <~bp_location>: Add destructor.
8752         <ops>: Remove.
8753
8754 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8755             Pedro Alves  <palves@redhat.com>
8756
8757         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8758         'PATH_MAX'.
8759
8760 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8761             Samuel Thibault  <samuel.thibault@gnu.org>
8762             Thomas Schwinge  <thomas@codesourcery.com>
8763
8764         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8765         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8766
8767 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8768
8769         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8770         (check_empty): Use "const char *".
8771
8772         * gnu-nat.c (gnu_nat_target::detach): Instead of
8773         'detach_inferior (pid)' call
8774         'detach_inferior (find_inferior_pid (pid))'.
8775
8776         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8777         'nat/fork-inferior.o'.
8778         * gnu-nat.c: #include "nat/fork-inferior.h".
8779
8780         * gnu-nat.c (gnu_nat_target::detach): Instead of
8781         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8782         * gnu-nat.h: #include "inf-child.h".
8783         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8784         'i386_gnu_nat_target::fetch_registers'.
8785         (gnu_store_registers): Rename/move to
8786         'i386_gnu_nat_target::store_registers'.
8787
8788         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8789         * gnu-nat.h (mach_thread_info): New function.
8790         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8791
8792         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8793
8794 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8795
8796         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8797
8798 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8799
8800         * windows-nat.c (windows_add_thread): Add new parameter
8801         "main_thread_p" with default value set to false.  Update
8802         function documentation as well as all callers.
8803         (windows_delete_thread): Likewise.
8804         (fake_create_process): Update call to windows_add_thread.
8805         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8806         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8807         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8808         call to windows_delete_thread.
8809
8810 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8811
8812         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8813
8814 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8815
8816         * symfile.c (find_separate_debug_file): Use canonical path of
8817         sysroot with child_path instead of gdb_sysroot if it is valid.
8818
8819 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8820
8821         * symfile.c (find_separate_debug_file): Use child_path to
8822         determine if an object file is under a sysroot.
8823
8824 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8825
8826         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8827         unittests/child-path-selftests.c.
8828         * common/pathstuff.c (child_path): New function.
8829         * common/pathstuff.h (child_path): New prototype.
8830         * unittests/child-path-selftests.c: New file.
8831
8832 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8833
8834         * symfile.c (find_separate_debug_file): Look for separate debug
8835         files in debug directories under the sysroot.
8836
8837 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8838
8839         * symtab.h (struct minimal_symbol data_p): New const method.
8840         (struct minimal_symbol text_p): Likewise.
8841         * symtab.c (output_source_filename): Use file name style
8842         to print file name.
8843         (print_symbol_info): Likewise.
8844         (print_msymbol_info): Use address style to print addresses.
8845         Use function name style to print executable text symbols.
8846         (expand_symtab_containing_pc): Use data_p.
8847         (find_pc_sect_compunit_symtab): Likewise.
8848
8849 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8850
8851         * breakpoint.c (describe_other_breakpoints): Use address style
8852         to print addresses.
8853         (say_where): Likewise.
8854
8855 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8856
8857         * ada-typeprint.c (print_func_type): Print function name
8858         style to print function name.
8859         * c-typeprint.c (c_print_type_1): Likewise.
8860
8861 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8862
8863         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8864         for execve.
8865
8866 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8867
8868         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8869         type_stack.
8870
8871 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8872
8873         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8874         TYPE_CODE_REF types.
8875
8876 2019-02-08  Jim Wilson  <jimw@sifive.com>
8877
8878         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8879         (riscv_linux_fregset): New.
8880         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8881
8882 2019-02-07  Tom Tromey  <tom@tromey.com>
8883
8884         * thread.c (thread_cancel_execution_command): Update.
8885         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8886         methods.
8887         (struct thread_fsm_ops): Remove.
8888         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8889         (thread_fsm_should_stop, thread_fsm_return_value)
8890         (thread_fsm_set_finished, thread_fsm_finished_p)
8891         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8892         Don't declare.
8893         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8894         * infrun.c (clear_proceed_status_thread)
8895         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8896         (print_stop_event): Update.
8897         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8898         Add constructor.
8899         (step_command_fsm_ops): Remove.
8900         (new_step_command_fsm): Remove.
8901         (step_1): Update.
8902         (step_command_fsm::should_stop): Rename from
8903         step_command_fsm_should_stop.
8904         (step_command_fsm::clean_up): Rename from
8905         step_command_fsm_clean_up.
8906         (step_command_fsm::do_async_reply_reason): Rename from
8907         step_command_fsm_async_reply_reason.
8908         (struct until_next_fsm): Inherit from thread_fsm.  Add
8909         constructor.
8910         (until_next_fsm_ops): Remove.
8911         (new_until_next_fsm): Remove.
8912         (until_next_fsm::should_stop): Rename from
8913         until_next_fsm_should_stop.
8914         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8915         (until_next_fsm::do_async_reply_reason): Rename from
8916         until_next_fsm_async_reply_reason.
8917         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8918         constructor.  Change type of breakpoint.
8919         (finish_command_fsm_ops): Remove.
8920         (new_finish_command_fsm): Remove.
8921         (finish_command_fsm::should_stop): Rename from
8922         finish_command_fsm_should_stop.
8923         (finish_command_fsm::clean_up): Rename from
8924         finish_command_fsm_clean_up.
8925         (finish_command_fsm::return_value): Rename from
8926         finish_command_fsm_return_value.
8927         (finish_command_fsm::do_async_reply_reason): Rename from
8928         finish_command_fsm_async_reply_reason.
8929         (finish_command): Update.
8930         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8931         Add constructor.
8932         (call_thread_fsm_ops): Remove.
8933         (call_thread_fsm::call_thread_fsm): Rename from
8934         new_call_thread_fsm.
8935         (call_thread_fsm::should_stop): Rename from
8936         call_thread_fsm_should_stop.
8937         (call_thread_fsm::should_notify_stop): Rename from
8938         call_thread_fsm_should_notify_stop.
8939         (run_inferior_call, call_function_by_hand_dummy): Update.
8940         * cli/cli-interp.c (should_print_stop_to_console): Update.
8941         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8942         Add constructor.  Change type of location_breakpoint,
8943         caller_breakpoint.
8944         (until_break_fsm_ops): Remove.
8945         (new_until_break_fsm): Remove.
8946         (until_break_fsm::should_stop): Rename from
8947         until_break_fsm_should_stop.
8948         (until_break_fsm::clean_up): Rename from
8949         until_break_fsm_clean_up.
8950         (until_break_fsm::do_async_reply_reason): Rename from
8951         until_break_fsm_async_reply_reason.
8952         (until_break_command): Update.
8953         * thread-fsm.c: Remove.
8954         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8955
8956 2019-02-07  Tom Tromey  <tom@tromey.com>
8957
8958         * yy-remap.h: Add include guard.
8959         * xtensa-tdep.h: Add include guard.
8960         * xcoffread.h: Rename include guard.
8961         * varobj-iter.h: Add include guard.
8962         * tui/tui.h: Rename include guard.
8963         * tui/tui-winsource.h: Rename include guard.
8964         * tui/tui-wingeneral.h: Rename include guard.
8965         * tui/tui-windata.h: Rename include guard.
8966         * tui/tui-win.h: Rename include guard.
8967         * tui/tui-stack.h: Rename include guard.
8968         * tui/tui-source.h: Rename include guard.
8969         * tui/tui-regs.h: Rename include guard.
8970         * tui/tui-out.h: Rename include guard.
8971         * tui/tui-layout.h: Rename include guard.
8972         * tui/tui-io.h: Rename include guard.
8973         * tui/tui-hooks.h: Rename include guard.
8974         * tui/tui-file.h: Rename include guard.
8975         * tui/tui-disasm.h: Rename include guard.
8976         * tui/tui-data.h: Rename include guard.
8977         * tui/tui-command.h: Rename include guard.
8978         * tic6x-tdep.h: Add include guard.
8979         * target/waitstatus.h: Rename include guard.
8980         * target/wait.h: Rename include guard.
8981         * target/target.h: Rename include guard.
8982         * target/resume.h: Rename include guard.
8983         * target-float.h: Rename include guard.
8984         * stabsread.h: Add include guard.
8985         * rs6000-tdep.h: Add include guard.
8986         * riscv-fbsd-tdep.h: Add include guard.
8987         * regformats/regdef.h: Rename include guard.
8988         * record.h: Rename include guard.
8989         * python/python.h: Rename include guard.
8990         * python/python-internal.h: Rename include guard.
8991         * python/py-stopevent.h: Rename include guard.
8992         * python/py-ref.h: Rename include guard.
8993         * python/py-record.h: Rename include guard.
8994         * python/py-record-full.h: Rename include guard.
8995         * python/py-record-btrace.h: Rename include guard.
8996         * python/py-instruction.h: Rename include guard.
8997         * python/py-events.h: Rename include guard.
8998         * python/py-event.h: Rename include guard.
8999         * procfs.h: Add include guard.
9000         * proc-utils.h: Add include guard.
9001         * p-lang.h: Add include guard.
9002         * or1k-tdep.h: Rename include guard.
9003         * observable.h: Rename include guard.
9004         * nto-tdep.h: Rename include guard.
9005         * nat/x86-linux.h: Rename include guard.
9006         * nat/x86-linux-dregs.h: Rename include guard.
9007         * nat/x86-gcc-cpuid.h: Add include guard.
9008         * nat/x86-dregs.h: Rename include guard.
9009         * nat/x86-cpuid.h: Rename include guard.
9010         * nat/ppc-linux.h: Rename include guard.
9011         * nat/mips-linux-watch.h: Rename include guard.
9012         * nat/linux-waitpid.h: Rename include guard.
9013         * nat/linux-ptrace.h: Rename include guard.
9014         * nat/linux-procfs.h: Rename include guard.
9015         * nat/linux-osdata.h: Rename include guard.
9016         * nat/linux-nat.h: Rename include guard.
9017         * nat/linux-namespaces.h: Rename include guard.
9018         * nat/linux-btrace.h: Rename include guard.
9019         * nat/glibc_thread_db.h: Rename include guard.
9020         * nat/gdb_thread_db.h: Rename include guard.
9021         * nat/gdb_ptrace.h: Rename include guard.
9022         * nat/fork-inferior.h: Rename include guard.
9023         * nat/amd64-linux-siginfo.h: Rename include guard.
9024         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9025         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9026         * nat/aarch64-linux.h: Rename include guard.
9027         * nat/aarch64-linux-hw-point.h: Rename include guard.
9028         * mn10300-tdep.h: Add include guard.
9029         * mips-linux-tdep.h: Add include guard.
9030         * mi/mi-parse.h: Rename include guard.
9031         * mi/mi-out.h: Rename include guard.
9032         * mi/mi-main.h: Rename include guard.
9033         * mi/mi-interp.h: Rename include guard.
9034         * mi/mi-getopt.h: Rename include guard.
9035         * mi/mi-console.h: Rename include guard.
9036         * mi/mi-common.h: Rename include guard.
9037         * mi/mi-cmds.h: Rename include guard.
9038         * mi/mi-cmd-break.h: Rename include guard.
9039         * m2-lang.h: Add include guard.
9040         * location.h: Rename include guard.
9041         * linux-record.h: Rename include guard.
9042         * linux-nat.h: Add include guard.
9043         * linux-fork.h: Add include guard.
9044         * i386-darwin-tdep.h: Rename include guard.
9045         * hppa-linux-offsets.h: Add include guard.
9046         * guile/guile.h: Rename include guard.
9047         * guile/guile-internal.h: Rename include guard.
9048         * gnu-nat.h: Rename include guard.
9049         * gdb-stabs.h: Rename include guard.
9050         * frv-tdep.h: Add include guard.
9051         * f-lang.h: Add include guard.
9052         * event-loop.h: Add include guard.
9053         * darwin-nat.h: Rename include guard.
9054         * cp-abi.h: Rename include guard.
9055         * config/sparc/nm-sol2.h: Rename include guard.
9056         * config/nm-nto.h: Rename include guard.
9057         * config/nm-linux.h: Add include guard.
9058         * config/i386/nm-i386gnu.h: Rename include guard.
9059         * config/djgpp/nl_types.h: Rename include guard.
9060         * config/djgpp/langinfo.h: Rename include guard.
9061         * compile/gcc-cp-plugin.h: Add include guard.
9062         * compile/gcc-c-plugin.h: Add include guard.
9063         * compile/compile.h: Rename include guard.
9064         * compile/compile-object-run.h: Rename include guard.
9065         * compile/compile-object-load.h: Rename include guard.
9066         * compile/compile-internal.h: Rename include guard.
9067         * compile/compile-cplus.h: Rename include guard.
9068         * compile/compile-c.h: Rename include guard.
9069         * common/xml-utils.h: Rename include guard.
9070         * common/x86-xstate.h: Rename include guard.
9071         * common/version.h: Rename include guard.
9072         * common/vec.h: Rename include guard.
9073         * common/tdesc.h: Rename include guard.
9074         * common/selftest.h: Rename include guard.
9075         * common/scoped_restore.h: Rename include guard.
9076         * common/scoped_mmap.h: Rename include guard.
9077         * common/scoped_fd.h: Rename include guard.
9078         * common/safe-iterator.h: Rename include guard.
9079         * common/run-time-clock.h: Rename include guard.
9080         * common/refcounted-object.h: Rename include guard.
9081         * common/queue.h: Rename include guard.
9082         * common/ptid.h: Rename include guard.
9083         * common/print-utils.h: Rename include guard.
9084         * common/preprocessor.h: Rename include guard.
9085         * common/pathstuff.h: Rename include guard.
9086         * common/observable.h: Rename include guard.
9087         * common/netstuff.h: Rename include guard.
9088         * common/job-control.h: Rename include guard.
9089         * common/host-defs.h: Rename include guard.
9090         * common/gdb_wait.h: Rename include guard.
9091         * common/gdb_vecs.h: Rename include guard.
9092         * common/gdb_unlinker.h: Rename include guard.
9093         * common/gdb_unique_ptr.h: Rename include guard.
9094         * common/gdb_tilde_expand.h: Rename include guard.
9095         * common/gdb_sys_time.h: Rename include guard.
9096         * common/gdb_string_view.h: Rename include guard.
9097         * common/gdb_splay_tree.h: Rename include guard.
9098         * common/gdb_setjmp.h: Rename include guard.
9099         * common/gdb_ref_ptr.h: Rename include guard.
9100         * common/gdb_optional.h: Rename include guard.
9101         * common/gdb_locale.h: Rename include guard.
9102         * common/gdb_assert.h: Rename include guard.
9103         * common/filtered-iterator.h: Rename include guard.
9104         * common/filestuff.h: Rename include guard.
9105         * common/fileio.h: Rename include guard.
9106         * common/environ.h: Rename include guard.
9107         * common/common-utils.h: Rename include guard.
9108         * common/common-types.h: Rename include guard.
9109         * common/common-regcache.h: Rename include guard.
9110         * common/common-inferior.h: Rename include guard.
9111         * common/common-gdbthread.h: Rename include guard.
9112         * common/common-exceptions.h: Rename include guard.
9113         * common/common-defs.h: Rename include guard.
9114         * common/common-debug.h: Rename include guard.
9115         * common/cleanups.h: Rename include guard.
9116         * common/buffer.h: Rename include guard.
9117         * common/btrace-common.h: Rename include guard.
9118         * common/break-common.h: Rename include guard.
9119         * cli/cli-utils.h: Rename include guard.
9120         * cli/cli-style.h: Rename include guard.
9121         * cli/cli-setshow.h: Rename include guard.
9122         * cli/cli-script.h: Rename include guard.
9123         * cli/cli-interp.h: Rename include guard.
9124         * cli/cli-decode.h: Rename include guard.
9125         * cli/cli-cmds.h: Rename include guard.
9126         * charset-list.h: Add include guard.
9127         * buildsym-legacy.h: Rename include guard.
9128         * bfin-tdep.h: Add include guard.
9129         * ax.h: Rename include guard.
9130         * arm-linux-tdep.h: Add include guard.
9131         * arm-fbsd-tdep.h: Add include guard.
9132         * arch/xtensa.h: Rename include guard.
9133         * arch/tic6x.h: Add include guard.
9134         * arch/i386.h: Add include guard.
9135         * arch/arm.h: Rename include guard.
9136         * arch/arm-linux.h: Rename include guard.
9137         * arch/arm-get-next-pcs.h: Rename include guard.
9138         * arch/amd64.h: Add include guard.
9139         * arch/aarch64-insn.h: Rename include guard.
9140         * arch-utils.h: Rename include guard.
9141         * annotate.h: Add include guard.
9142         * amd64-darwin-tdep.h: Rename include guard.
9143         * aarch64-linux-tdep.h: Add include guard.
9144         * aarch64-fbsd-tdep.h: Add include guard.
9145         * aarch32-linux-nat.h: Add include guard.
9146
9147 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9148
9149         * macrotab.c (macro_define_internal): New function that
9150         factorizes macro_define_object_internal and macro_define_function
9151         code.
9152         (macro_define_object_internal): Use macro_define_internal.
9153         (macro_define_function): Likewise.
9154
9155 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9156
9157         * macrocmd.c (extract_identifier): Return
9158         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9159         callers.
9160
9161 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9162
9163         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9164
9165 2019-02-05  Tom Tromey  <tom@tromey.com>
9166
9167         * target.c (target_stack::unpush): Move assertion earlier.
9168
9169 2019-01-30  Tom Tromey  <tom@tromey.com>
9170
9171         PR python/23615:
9172         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9173         (gdbpy_parse_and_eval): Likewise.
9174         * python/python-internal.h (gdbpy_allow_threads): New class.
9175
9176 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9177
9178         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9179         (aarch64_fbsd_fpregmap): Move earlier.
9180         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9181         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9182         instead of individual calls to trad_frame_set_reg_addr.
9183         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9184         earlier.
9185         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9186         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9187         instead of individual calls to trad_frame_set_reg_addr.
9188
9189 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9190
9191         * CONTRIBUTE: Replace contribution list with wiki link.
9192
9193 2019-01-25  Tom Tromey  <tom@tromey.com>
9194
9195         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9196
9197 2019-01-25  Tom Tromey  <tom@tromey.com>
9198
9199         * xtensa-linux-nat.c: Fix common/ includes.
9200         * xml-support.h: Fix common/ includes.
9201         * xml-support.c: Fix common/ includes.
9202         * x86-linux-nat.c: Fix common/ includes.
9203         * windows-nat.c: Fix common/ includes.
9204         * varobj.h: Fix common/ includes.
9205         * varobj.c: Fix common/ includes.
9206         * value.c: Fix common/ includes.
9207         * valops.c: Fix common/ includes.
9208         * utils.c: Fix common/ includes.
9209         * unittests/xml-utils-selftests.c: Fix common/ includes.
9210         * unittests/utils-selftests.c: Fix common/ includes.
9211         * unittests/unpack-selftests.c: Fix common/ includes.
9212         * unittests/tracepoint-selftests.c: Fix common/ includes.
9213         * unittests/style-selftests.c: Fix common/ includes.
9214         * unittests/string_view-selftests.c: Fix common/ includes.
9215         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9216         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9217         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9218         * unittests/rsp-low-selftests.c: Fix common/ includes.
9219         * unittests/parse-connection-spec-selftests.c: Fix common/
9220         includes.
9221         * unittests/optional-selftests.c: Fix common/ includes.
9222         * unittests/offset-type-selftests.c: Fix common/ includes.
9223         * unittests/observable-selftests.c: Fix common/ includes.
9224         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9225         * unittests/memrange-selftests.c: Fix common/ includes.
9226         * unittests/memory-map-selftests.c: Fix common/ includes.
9227         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9228         * unittests/function-view-selftests.c: Fix common/ includes.
9229         * unittests/environ-selftests.c: Fix common/ includes.
9230         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9231         * unittests/common-utils-selftests.c: Fix common/ includes.
9232         * unittests/cli-utils-selftests.c: Fix common/ includes.
9233         * unittests/array-view-selftests.c: Fix common/ includes.
9234         * ui-file.c: Fix common/ includes.
9235         * tui/tui-io.c: Fix common/ includes.
9236         * tracepoint.h: Fix common/ includes.
9237         * tracepoint.c: Fix common/ includes.
9238         * tracefile-tfile.c: Fix common/ includes.
9239         * top.h: Fix common/ includes.
9240         * top.c: Fix common/ includes.
9241         * thread.c: Fix common/ includes.
9242         * target/waitstatus.h: Fix common/ includes.
9243         * target/waitstatus.c: Fix common/ includes.
9244         * target.h: Fix common/ includes.
9245         * target.c: Fix common/ includes.
9246         * target-memory.c: Fix common/ includes.
9247         * target-descriptions.c: Fix common/ includes.
9248         * symtab.h: Fix common/ includes.
9249         * symfile.c: Fix common/ includes.
9250         * stap-probe.c: Fix common/ includes.
9251         * spu-linux-nat.c: Fix common/ includes.
9252         * sparc-nat.c: Fix common/ includes.
9253         * source.c: Fix common/ includes.
9254         * solib.c: Fix common/ includes.
9255         * solib-target.c: Fix common/ includes.
9256         * ser-unix.c: Fix common/ includes.
9257         * ser-tcp.c: Fix common/ includes.
9258         * ser-pipe.c: Fix common/ includes.
9259         * ser-base.c: Fix common/ includes.
9260         * selftest-arch.c: Fix common/ includes.
9261         * s12z-tdep.c: Fix common/ includes.
9262         * rust-exp.y: Fix common/ includes.
9263         * rs6000-aix-tdep.c: Fix common/ includes.
9264         * riscv-tdep.c: Fix common/ includes.
9265         * remote.c: Fix common/ includes.
9266         * remote-notif.h: Fix common/ includes.
9267         * remote-fileio.h: Fix common/ includes.
9268         * remote-fileio.c: Fix common/ includes.
9269         * regcache.h: Fix common/ includes.
9270         * regcache.c: Fix common/ includes.
9271         * record-btrace.c: Fix common/ includes.
9272         * python/python.c: Fix common/ includes.
9273         * python/py-type.c: Fix common/ includes.
9274         * python/py-inferior.c: Fix common/ includes.
9275         * progspace.h: Fix common/ includes.
9276         * producer.c: Fix common/ includes.
9277         * procfs.c: Fix common/ includes.
9278         * proc-api.c: Fix common/ includes.
9279         * printcmd.c: Fix common/ includes.
9280         * ppc-linux-nat.c: Fix common/ includes.
9281         * parser-defs.h: Fix common/ includes.
9282         * osdata.c: Fix common/ includes.
9283         * obsd-nat.c: Fix common/ includes.
9284         * nat/x86-linux.c: Fix common/ includes.
9285         * nat/x86-linux-dregs.c: Fix common/ includes.
9286         * nat/x86-dregs.h: Fix common/ includes.
9287         * nat/x86-dregs.c: Fix common/ includes.
9288         * nat/ppc-linux.c: Fix common/ includes.
9289         * nat/mips-linux-watch.h: Fix common/ includes.
9290         * nat/mips-linux-watch.c: Fix common/ includes.
9291         * nat/linux-waitpid.c: Fix common/ includes.
9292         * nat/linux-ptrace.h: Fix common/ includes.
9293         * nat/linux-ptrace.c: Fix common/ includes.
9294         * nat/linux-procfs.c: Fix common/ includes.
9295         * nat/linux-personality.c: Fix common/ includes.
9296         * nat/linux-osdata.c: Fix common/ includes.
9297         * nat/linux-namespaces.c: Fix common/ includes.
9298         * nat/linux-btrace.h: Fix common/ includes.
9299         * nat/linux-btrace.c: Fix common/ includes.
9300         * nat/fork-inferior.c: Fix common/ includes.
9301         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9302         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9303         * nat/aarch64-linux.c: Fix common/ includes.
9304         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9305         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9306         * namespace.h: Fix common/ includes.
9307         * mips-linux-tdep.c: Fix common/ includes.
9308         * minsyms.c: Fix common/ includes.
9309         * mi/mi-parse.h: Fix common/ includes.
9310         * mi/mi-main.c: Fix common/ includes.
9311         * mi/mi-cmd-env.c: Fix common/ includes.
9312         * memrange.h: Fix common/ includes.
9313         * memattr.c: Fix common/ includes.
9314         * maint.h: Fix common/ includes.
9315         * maint.c: Fix common/ includes.
9316         * main.c: Fix common/ includes.
9317         * machoread.c: Fix common/ includes.
9318         * location.c: Fix common/ includes.
9319         * linux-thread-db.c: Fix common/ includes.
9320         * linux-nat.c: Fix common/ includes.
9321         * linux-fork.c: Fix common/ includes.
9322         * inline-frame.c: Fix common/ includes.
9323         * infrun.c: Fix common/ includes.
9324         * inflow.c: Fix common/ includes.
9325         * inferior.h: Fix common/ includes.
9326         * inferior.c: Fix common/ includes.
9327         * infcmd.c: Fix common/ includes.
9328         * inf-ptrace.c: Fix common/ includes.
9329         * inf-child.c: Fix common/ includes.
9330         * ia64-linux-nat.c: Fix common/ includes.
9331         * i387-tdep.c: Fix common/ includes.
9332         * i386-tdep.c: Fix common/ includes.
9333         * i386-linux-tdep.c: Fix common/ includes.
9334         * i386-linux-nat.c: Fix common/ includes.
9335         * i386-go32-tdep.c: Fix common/ includes.
9336         * i386-fbsd-tdep.c: Fix common/ includes.
9337         * i386-fbsd-nat.c: Fix common/ includes.
9338         * guile/scm-type.c: Fix common/ includes.
9339         * guile/guile.c: Fix common/ includes.
9340         * go32-nat.c: Fix common/ includes.
9341         * gnu-nat.c: Fix common/ includes.
9342         * gdbthread.h: Fix common/ includes.
9343         * gdbarch-selftests.c: Fix common/ includes.
9344         * gdb_usleep.c: Fix common/ includes.
9345         * gdb_select.h: Fix common/ includes.
9346         * gdb_bfd.c: Fix common/ includes.
9347         * gcore.c: Fix common/ includes.
9348         * fork-child.c: Fix common/ includes.
9349         * findvar.c: Fix common/ includes.
9350         * fbsd-nat.c: Fix common/ includes.
9351         * event-top.c: Fix common/ includes.
9352         * event-loop.c: Fix common/ includes.
9353         * dwarf2read.c: Fix common/ includes.
9354         * dwarf2loc.c: Fix common/ includes.
9355         * dwarf2-frame.c: Fix common/ includes.
9356         * dwarf-index-cache.c: Fix common/ includes.
9357         * dtrace-probe.c: Fix common/ includes.
9358         * disasm-selftests.c: Fix common/ includes.
9359         * defs.h: Fix common/ includes.
9360         * csky-tdep.c: Fix common/ includes.
9361         * cp-valprint.c: Fix common/ includes.
9362         * cp-support.h: Fix common/ includes.
9363         * cp-support.c: Fix common/ includes.
9364         * corelow.c: Fix common/ includes.
9365         * completer.h: Fix common/ includes.
9366         * completer.c: Fix common/ includes.
9367         * compile/compile.c: Fix common/ includes.
9368         * compile/compile-loc2c.c: Fix common/ includes.
9369         * compile/compile-cplus-types.c: Fix common/ includes.
9370         * compile/compile-cplus-symbols.c: Fix common/ includes.
9371         * command.h: Fix common/ includes.
9372         * cli/cli-dump.c: Fix common/ includes.
9373         * cli/cli-cmds.c: Fix common/ includes.
9374         * charset.c: Fix common/ includes.
9375         * build-id.c: Fix common/ includes.
9376         * btrace.h: Fix common/ includes.
9377         * btrace.c: Fix common/ includes.
9378         * breakpoint.h: Fix common/ includes.
9379         * breakpoint.c: Fix common/ includes.
9380         * ax.h:
9381         (enum agent_op): Fix common/ includes.
9382         * ax-general.c (struct aop_map): Fix common/ includes.
9383         * ax-gdb.c: Fix common/ includes.
9384         * auxv.c: Fix common/ includes.
9385         * auto-load.c: Fix common/ includes.
9386         * arm-tdep.c: Fix common/ includes.
9387         * arch/riscv.c: Fix common/ includes.
9388         * arch/ppc-linux-common.c: Fix common/ includes.
9389         * arch/i386.c: Fix common/ includes.
9390         * arch/arm.c: Fix common/ includes.
9391         * arch/arm-linux.c: Fix common/ includes.
9392         * arch/arm-get-next-pcs.c: Fix common/ includes.
9393         * arch/amd64.c: Fix common/ includes.
9394         * arch/aarch64.c: Fix common/ includes.
9395         * arch/aarch64-insn.c: Fix common/ includes.
9396         * arch-utils.c: Fix common/ includes.
9397         * amd64-windows-tdep.c: Fix common/ includes.
9398         * amd64-tdep.c: Fix common/ includes.
9399         * amd64-sol2-tdep.c: Fix common/ includes.
9400         * amd64-obsd-tdep.c: Fix common/ includes.
9401         * amd64-nbsd-tdep.c: Fix common/ includes.
9402         * amd64-linux-tdep.c: Fix common/ includes.
9403         * amd64-linux-nat.c: Fix common/ includes.
9404         * amd64-fbsd-tdep.c: Fix common/ includes.
9405         * amd64-fbsd-nat.c: Fix common/ includes.
9406         * amd64-dicos-tdep.c: Fix common/ includes.
9407         * amd64-darwin-tdep.c: Fix common/ includes.
9408         * agent.c: Fix common/ includes.
9409         * ada-lang.h: Fix common/ includes.
9410         * ada-lang.c: Fix common/ includes.
9411         * aarch64-tdep.c: Fix common/ includes.
9412
9413 2019-01-25  Tom Tromey  <tom@tromey.com>
9414
9415         * common/create-version.sh: Use common/version.h.
9416
9417 2019-01-24  Pedro Alves  <palves@redhat.com>
9418
9419         * infrun.c (signal_stop, signal_print, signal_program)
9420         (signal_catch, signal_pass): Now arrays instead of pointers.
9421         (update_signals_program_target, do_target_resume)
9422         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9423         * linux-nat.c (linux_nat_target::pass_signals)
9424         (linux_nat_target::create_inferior, linux_nat_target::attach):
9425         Adjust.
9426         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9427         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9428         * procfs.c (procfs_target::pass_signals): Adjust.
9429         * record-full.c (record_full_target::resume): Adjust.
9430         * remote.c (remote_target::pass_signals)
9431         (remote_target::program_signals): Adjust.
9432         * target-debug.h (target_debug_print_signals): Now takes a
9433         gdb::array_view as parameter.  Adjust.
9434         * target.h (target_ops) <pass_signals, program_signals>: Replace
9435         pointer and length parameters with gdb::array_view.
9436         (target_pass_signals, target_program_signals): Likewise.
9437         * target-delegates.c: Regenerate.
9438
9439 2019-01-24  Pedro Alves  <palves@redhat.com>
9440
9441         * common/forward-scope-exit.h
9442         (forward_scope_exit::forward_scope_exit): Pass arguments to
9443         m_bind_function directly, instead of creating a std::bind and
9444         copying that.
9445
9446 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9447
9448         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9449         for static members.
9450         (pass_in_v_vfp_candidate): Likewise.
9451
9452 2019-01-23  Tom Tromey  <tom@tromey.com>
9453             Pedro Alves  <palves@redhat.com>
9454
9455         * regcache.c (class regcache_invalidator): Remove.
9456         (regcache::raw_write): Use make_scope_exit.
9457
9458 2019-01-23  Tom Tromey  <tom@tromey.com>
9459
9460         * ui-out.h (class ui_out_emit_type): Update comment.
9461
9462 2019-01-23  Tom Tromey  <tom@tromey.com>
9463
9464         * infrun.c (fetch_inferior_event): Update comment.
9465
9466 2019-01-23  Tom Tromey  <tom@tromey.com>
9467             Pedro Alves  <palves@redhat.com>
9468
9469         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9470         parameter.
9471         (fetch_inferior_event): Use SCOPE_EXIT.
9472
9473
9474 2019-01-23  Tom Tromey  <tom@tromey.com>
9475             Pedro Alves  <palves@redhat.com>
9476
9477         * infrun.c (disable_thread_events): Delete.
9478         (stop_all_threads): Use SCOPE_EXIT.
9479
9480 2019-01-23  Tom Tromey  <tom@tromey.com>
9481             Pedro Alves  <palves@redhat.com>
9482
9483         * symfile.c: Include forward-scope-exit.h.
9484         (clear_symtab_users_cleanup): Replace forward declaration with
9485         a FORWARD_SCOPE_EXIT.
9486         (syms_from_objfile_1): Use the forward_scope_exit and
9487         gdb::optional instead of cleanup_function.
9488         (reread_symbols): Use the forward_scope_exit instead of
9489         cleanup_function.
9490         (clear_symtab_users_cleanup): Remove function.
9491
9492 2019-01-23  Tom Tromey  <tom@tromey.com>
9493             Pedro Alves  <palves@redhat.com>
9494
9495         * linux-nat.c: Include scope-exit.h.
9496         (cleanup_target_stop): Remove.
9497         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9498         SCOPE_EXIT.
9499
9500 2019-01-23  Tom Tromey  <tom@tromey.com>
9501             Pedro Alves  <palves@redhat.com>
9502
9503         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9504         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9505
9506 2019-01-23  Tom Tromey  <tom@tromey.com>
9507             Andrew Burgess  <andrew.burgess@embecosm.com>
9508             Pedro Alves  <palves@redhat.com>
9509
9510         * infrun.c (fetch_inferior_event): Use scope_exit.
9511         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9512         * top.c (execute_command): Use scope_exit.
9513         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9514         * utils.c (do_bpstat_clear_actions_cleanup)
9515         (make_bpstat_clear_actions_cleanup): Remove.
9516
9517 2019-01-23  Tom Tromey  <tom@tromey.com>
9518             Pedro Alves  <palves@redhat.com>
9519
9520         * infrun.c: Include "common/scope-exit.h"
9521         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9522         (wait_for_inferior): Use SCOPE_EXIT.
9523         (fetch_inferior_event): Use scope_exit.
9524
9525 2019-01-23  Tom Tromey  <tom@tromey.com>
9526             Pedro Alves  <palves@redhat.com>
9527
9528         * breakpoint.c (create_breakpoint): Remove cleanup.
9529
9530 2019-01-23  Tom Tromey  <tom@tromey.com>
9531             Andrew Burgess  <andrew.burgess@embecosm.com>
9532             Pedro Alves  <palves@redhat.com>
9533
9534 2019-01-23  Pedro Alves  <palves@redhat.com>
9535
9536         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9537
9538 2019-01-23  Pedro Alves  <palves@redhat.com>
9539             Andrew Burgess  <andrew.burgess@embecosm.com>
9540
9541         * gdbthread.h: Include "common/forward-scope-exit.h".
9542         (scoped_finish_thread_state): Redefine custom class in terms of
9543         forward_scope_exit.
9544
9545 2019-01-23  Pedro Alves  <palves@redhat.com>
9546             Andrew Burgess  <andrew.burgess@embecosm.com>
9547
9548         * common/forward-scope-exit.h: New file.
9549
9550 2019-01-23  Pedro Alves  <palves@redhat.com>
9551             Andrew Burgess  <andrew.burgess@embecosm.com>
9552             Tom Tromey  <tom@tromey.com>
9553
9554         * common/scope-exit.h: New file.
9555
9556 2019-01-23  Pedro Alves  <palves@redhat.com>
9557
9558         * common/preprocessor.h (ESC): Rename to ...
9559         (ESC_PARENS): ... this.
9560         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9561         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9562
9563 2019-01-23  Tom Tromey  <tom@tromey.com>
9564
9565         * language.h (class scoped_switch_to_sym_language_if_auto):
9566         Initialize m_lang in both cases.
9567
9568 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9569
9570         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9571         with XCNEW.
9572
9573 2019-01-22  Tom Tromey  <tom@tromey.com>
9574
9575         * corelow.c: Do not include sys/file.h.
9576
9577 2019-01-22  Tom Tromey  <tom@tromey.com>
9578
9579         * tui/tui-wingeneral.h: Include gdb_curses.h.
9580
9581 2019-01-22  Tom Tromey  <tom@tromey.com>
9582
9583         * source-cache.h (class source_cache) <get_source_lines,
9584         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9585
9586 2019-01-22  Tom Tromey  <tom@tromey.com>
9587
9588         * remote-fileio.h (struct remote_target): Declare.
9589
9590 2019-01-22  Tom Tromey  <tom@tromey.com>
9591
9592         * python/py-arch.c: Do not include py-ref.h.
9593         * python/py-bpevent.c: Do not include py-ref.h.
9594         * python/py-cmd.c: Do not include py-ref.h.
9595         * python/py-continueevent.c: Do not include py-ref.h.
9596         * python/py-event.h: Do not include py-ref.h.
9597         * python/py-evtregistry.c: Do not include py-ref.h.
9598         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9599         * python/py-frame.c: Do not include py-ref.h.
9600         * python/py-framefilter.c: Do not include py-ref.h.
9601         * python/py-function.c: Do not include py-ref.h.
9602         * python/py-infevents.c: Do not include py-ref.h.
9603         * python/py-linetable.c: Do not include py-ref.h.
9604         * python/py-objfile.c: Do not include py-ref.h.
9605         * python/py-param.c: Do not include py-ref.h.
9606         * python/py-prettyprint.c: Do not include py-ref.h.
9607         * python/py-progspace.c: Do not include py-ref.h.
9608         * python/py-symbol.c: Do not include py-ref.h.
9609         * python/py-symtab.c: Do not include py-ref.h.
9610         * python/py-type.c: Do not include py-ref.h.
9611         * python/py-unwind.c: Do not include py-ref.h.
9612         * python/py-utils.c: Do not include py-ref.h.
9613         * python/py-value.c: Do not include py-ref.h.
9614         * python/py-varobj.c: Do not include py-ref.h.
9615         * python/py-xmethods.c: Do not include py-ref.h.
9616         * python/python.c: Do not include py-ref.h.
9617         * varobj.c: Do not include py-ref.h.
9618
9619 2019-01-22  Tom Tromey  <tom@tromey.com>
9620
9621         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9622         keyword for bcache.
9623
9624 2019-01-22  Tom Tromey  <tom@tromey.com>
9625
9626         * compile/compile-cplus-types.c: Remove a comment by #include.
9627
9628 2019-01-22  Tom Tromey  <tom@tromey.com>
9629
9630         * compile/gcc-c-plugin.h: Include compile-internal.h.
9631
9632 2019-01-22  Tom Tromey  <tom@tromey.com>
9633
9634         * stabsread.c (EXTERN): Do not define.
9635         (symnum, next_symbol_text_func, processing_gcc_compilation)
9636         (within_function, global_sym_chain, global_stabs)
9637         (previous_stab_code, this_object_header_files)
9638         (n_this_object_header_files)
9639         (n_allocated_this_object_header_files): Define.
9640         * stabsread.h (EXTERN): Never define.  Use "extern".
9641
9642 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9643
9644         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9645         history_value.
9646
9647 2019-01-21  Tom Tromey  <tom@tromey.com>
9648
9649         * ui-out.c: Fix includes.
9650         * tui/tui-source.c: Fix includes.
9651         * target.c: Fix includes.
9652         * remote.c: Fix includes.
9653         * regcache.c: Fix includes.
9654         * python/py-block.c: Fix includes.
9655         * printcmd.c: Fix includes.
9656         * or1k-tdep.c: Fix includes.
9657         * mi/mi-main.c: Fix includes.
9658         * m32r-tdep.c: Fix includes.
9659         * csky-tdep.c: Fix includes.
9660         * compile/compile-cplus-types.c: Fix includes.
9661         * cli/cli-interp.c: Fix includes.
9662
9663 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9664
9665         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9666         for padding.
9667
9668 2019-01-16  Tom Tromey  <tom@tromey.com>
9669
9670         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9671         earlier.
9672         (struct objfile) <msymbols_range>: Move from top level.
9673         <msymbols>: New method.
9674         (class objfile_msymbols): Remove.
9675         * symtab.c (default_collect_symbol_completion_matches_break_on):
9676         Update.
9677         * symmisc.c (dump_msymbols): Update.
9678         * stabsread.c (scan_file_globals): Update.
9679         * objc-lang.c (info_selectors_command, info_classes_command)
9680         (find_methods): Update.
9681         * minsyms.c (find_solib_trampoline_target): Update.
9682         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9683         * coffread.c (coff_symfile_read): Update.
9684         * ada-lang.c (ada_lookup_simple_minsym)
9685         (ada_collect_symbol_completion_matches): Update.
9686
9687 2019-01-16  Tom Tromey  <tom@tromey.com>
9688
9689         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9690         type.  Remove no-argument constructor.
9691         <iterator::operator++>: Simplify.
9692         <begin>: Update.
9693         <end>: Use minimal_symbol_count.
9694
9695 2019-01-16  Tom Tromey  <tom@tromey.com>
9696
9697         * objfiles.h (struct objfile) <psymtabs>: New method.
9698         (class objfile_psymtabs): Remove.
9699         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9700         typedef.
9701         <range>: New method.
9702         (require_partial_symbols): Change return type.
9703         * psymtab.c (require_partial_symbols)
9704         (psym_expand_symtabs_matching): Update.
9705         * mdebugread.c (parse_partial_symbols): Update.
9706         * dbxread.c (dbx_end_psymtab): Update.
9707
9708 2019-01-15  Tom Tromey  <tom@tromey.com>
9709
9710         * symtab.c (lookup_objfile_from_block)
9711         (lookup_symbol_in_objfile_symtabs)
9712         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9713         (find_line_symtab, info_sources_command)
9714         (default_collect_symbol_completion_matches_break_on)
9715         (make_source_files_completion_list): Update.
9716         * symmisc.c (print_objfile_statistics, dump_objfile)
9717         (maintenance_print_symbols, maintenance_info_symtabs)
9718         (maintenance_check_symtabs, maintenance_info_line_tables):
9719         Update.
9720         * source.c (select_source_symtab)
9721         (forget_cached_source_info_for_objfile): Update.
9722         * objfiles.h (class objfile_compunits): Remove.
9723         (struct objfile) <compunits_range>: New typedef.
9724         (compunits): New method.
9725         * objfiles.c (objfile_relocate1): Update.
9726         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9727         * maint.c (count_symtabs_and_blocks): Update.
9728         * linespec.c (iterate_over_all_matching_symtabs): Update.
9729         * cp-support.c (add_symbol_overload_list_qualified): Update.
9730         * coffread.c (coff_symtab_read): Update.
9731         * ada-lang.c (add_nonlocal_symbols)
9732         (ada_collect_symbol_completion_matches)
9733         (ada_add_global_exceptions): Update.
9734
9735 2019-01-15  Tom Tromey  <tom@tromey.com>
9736
9737         * progspace.h (program_space) <objfiles_safe_range>: New
9738         typedef.
9739         <objfiles_safe>: New method.
9740         * objfiles.h (class all_objfiles_safe): Remove.
9741         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9742         * jit.c (jit_inferior_exit_hook): Update.
9743
9744 2019-01-17  Tom Tromey  <tom@tromey.com>
9745
9746         * progspace.h (program_space) <objfiles_range>: New typedef.
9747         <objfiles>: New method.
9748         <objfiles_head>: Rename from objfiles.
9749         (object_files): Update.
9750         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9751         * guile/scm-pretty-print.c
9752         (ppscm_find_pretty_printer_from_objfiles): Update.
9753         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9754         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9755         Update.
9756         * python/py-progspace.c (pspy_get_objfiles): Update.
9757         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9758         Update.
9759         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9760         (objfpy_lookup_objfile_by_build_id): Update.
9761         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9762         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9763         Update.
9764         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9765         (expand_symtab_containing_pc, lookup_objfile_from_block)
9766         (lookup_static_symbol, basic_lookup_transparent_type)
9767         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9768         (find_line_symtab, info_sources_command)
9769         (default_collect_symbol_completion_matches_break_on)
9770         (make_source_files_completion_list, find_main_name): Update.
9771         * symmisc.c (print_symbol_bcache_statistics)
9772         (print_objfile_statistics, maintenance_print_symbols)
9773         (maintenance_print_msymbols, maintenance_print_objfiles)
9774         (maintenance_info_symtabs, maintenance_check_symtabs)
9775         (maintenance_expand_symtabs, maintenance_info_line_tables):
9776         Update.
9777         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9778         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9779         (map_overlay_command, unmap_overlay_command)
9780         (simple_overlay_update, expand_symtabs_matching)
9781         (map_symbol_filenames): Update.
9782         * symfile-debug.c (set_debug_symfile): Update.
9783         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9784         Update.
9785         * source.c (select_source_symtab, forget_cached_source_info):
9786         Update.
9787         * solib.c (solib_read_symbols): Update.
9788         * solib-spu.c (append_ocl_sos): Update.
9789         * psymtab.c (maintenance_print_psymbols)
9790         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9791         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9792         * printcmd.c (info_symbol_command): Update.
9793         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9794         Update.
9795         * objfiles.h (class all_objfiles): Remove.
9796         * objfiles.c (have_partial_symbols, have_full_symbols)
9797         (have_minimal_symbols, qsort_cmp, update_section_map)
9798         (shared_objfile_contains_address_p)
9799         (default_iterate_over_objfiles_in_search_order): Update.
9800         * objc-lang.c (info_selectors_command, info_classes_command)
9801         (find_methods): Update.
9802         * minsyms.c (find_solib_trampoline_target): Update.
9803         * maint.c (maintenance_info_sections)
9804         (maintenance_translate_address, count_symtabs_and_blocks):
9805         Update.
9806         * main.c (captured_main_1): Update.
9807         * linux-thread-db.c (try_thread_db_load_from_pdir)
9808         (has_libpthread): Update.
9809         * linespec.c (iterate_over_all_matching_symtabs)
9810         (search_minsyms_for_name): Update.
9811         * jit.c (jit_find_objf_with_entry_addr): Update.
9812         * hppa-tdep.c (find_unwind_entry)
9813         (hppa_lookup_stub_minimal_symbol): Update.
9814         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9815         Update.
9816         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9817         (elf_gnu_ifunc_resolve_by_got): Update.
9818         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9819         * dwarf-index-write.c (save_gdb_index_command): Update.
9820         * cp-support.c (add_symbol_overload_list_qualified): Update.
9821         * breakpoint.c (create_overlay_event_breakpoint)
9822         (create_longjmp_master_breakpoint)
9823         (create_std_terminate_master_breakpoint)
9824         (create_exception_master_breakpoint): Update.
9825         * blockframe.c (find_pc_partial_function): Update.
9826         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9827         (ada_collect_symbol_completion_matches)
9828         (ada_add_global_exceptions): Update.
9829
9830 2019-01-17  Tom Tromey  <tom@tromey.com>
9831
9832         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9833         declare VEC.
9834         (solib_target_parse_libraries): Change return type.
9835         (library_list_start_segment, library_list_start_section)
9836         (library_list_end_library, library_list_start_library); Update.
9837         (solib_target_free_library_list): Remove.
9838         (solib_target_parse_libraries): Remove cleanup.  Change return
9839         type.
9840         (solib_target_current_sos): Update.
9841
9842 2019-01-17  Tom Tromey  <tromey@bapiya>
9843
9844         * valprint.c: Replace "the the" with "the".
9845         * symtab.c: Replace "the the" with "the".
9846         * solib.c: Replace "the the" with "the".
9847         * solib-dsbt.c: Replace "the the" with "the".
9848         * linespec.c: Replace "the the" with "the".
9849         * dwarf2loc.h: Replace "the the" with "the".
9850         * amd64-windows-tdep.c: Replace "the the" with "the".
9851         * aarch64-tdep.c: Replace "the the" with "the".
9852
9853 2019-01-16  Keith Seitz  <keiths@redhat.com>
9854
9855         PR gdb/23773
9856         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9857         <builder>: Rename to ..
9858         <m_builder>: ... this and make private.
9859         (dwarf2_cu::get_builder): New method.  Change all users of
9860         `builder' to use this method.
9861         (dwarf2_start_symtab): Move to ...
9862         (dwarf2_cu::start_symtab): ... here.  Update all callers
9863         (setup_type_unit_groups): Move to ...
9864         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9865         callers.
9866         (dwarf2_cu::reset_builder): New method.
9867         (process_full_compunit, process_full_type_unit): Use
9868         dwarf2_cu::reset_builder.
9869         (follow_die_offset): Record the ancestor CU if it is different
9870         from the followed DIE's CU.
9871         (follow_die_sig_1): Likewise.
9872
9873 2019-01-15  Tom Tromey  <tom@tromey.com>
9874
9875         * remote.c (class remote_state) <buf>: Now a char_vector.
9876         <buf_size>: Remove.
9877         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9878         parameter.
9879         (remote_target::getpkt_or_notif_sane_1)
9880         (remote_target::getpkt_sane)
9881         (remote_target::getpkt_or_notif_sane): Likewise.
9882         (class remote_target) <putpkt>: New overload.
9883         (remote_target::read_frame): Change type of "buf_p".  Remove
9884         sizeof_p parameter.
9885         (packet_ok): New overload.
9886         (packet_check_result): New overload.
9887         Update all uses.
9888
9889 2019-01-14  Tom Tromey  <tom@tromey.com>
9890
9891         * remote-notif.c (handle_notification, remote_notif_ack)
9892         (remote_notif_parse): Make "buf" const.
9893         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9894         const.
9895         (remote_notif_parse, remote_notif_ack, handle_notification):
9896         Likewise.
9897         * remote.c (remote_notif_stop_parse): Make "buf" const.
9898         (remote_target::remote_parse_stop_reply): Make "buf" const.
9899         (remote_notif_stop_ack): Make "buf" const.
9900
9901 2019-01-14  Tom Tromey  <tom@tromey.com>
9902
9903         * remote.c (remote_console_output): Make parameter const.
9904
9905 2019-01-14  Tom Tromey  <tom@tromey.com>
9906
9907         * target-debug.h (target_debug_print_signals): Constify.
9908         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9909         * procfs.c (procfs_target::pass_signals): Update.
9910         * linux-nat.c (linux_nat_target::pass_signals): Update.
9911         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9912         * target-delegates.c: Rebuild.
9913         * remote.c (remote_target::program_signals): Update.
9914         (remote_target::pass_signals): Update.
9915         * target.c (target_pass_signals): Constify argument.
9916         (target_program_signals): Likewise.
9917         * target.h (struct target_ops) <pass_signals, program_signals>:
9918         Constify argument.
9919         (target_pass_signals, target_program_signals): Constify argument.
9920
9921 2019-01-14  Tom Tromey  <tom@tromey.com>
9922
9923         PR tui/28819:
9924         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9925
9926 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9927
9928         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9929         field.
9930         * rs6000-tdep.c: Include reggroups.h.
9931         (IS_V_ALIAS_PSEUDOREG): Define.
9932         (rs6000_register_name): Return names for the "vX" aliases.
9933         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9934         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9935         aliases.  Call default_register_reggroup_p for all other
9936         pseudo-registers.
9937         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9938         New functions.
9939         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9940         Handle "vX" aliases.
9941         (v_alias_pseudo_register_collect): New function.
9942         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9943         (rs6000_gdbarch_init): Initialize "vX" aliases as
9944         pseudo-registers.  Restore registration of
9945         rs6000_pseudo_register_reggroup_p with
9946         set_tdesc_pseudo_register_reggroup_p.
9947
9948 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9949
9950         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9951         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9952         set_gdbarch_num_pseudo_regs.
9953
9954 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9955
9956         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9957         Remove arg prefixname, add do_set and do_show.
9958         Add member functions set_list and show_list.
9959         * cli/cli-style.c (class cli_style_option): Update accordingly.
9960         (style_set_list): Move to file scope.
9961         (style_show_list): Likewise.
9962         (set_style): Call help_list.
9963         (show_style): Call cmd_show_list.
9964         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9965         Update to use the new macro.
9966
9967 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9968
9969         * ada-lang.c (_initialize_ada_language): Expand the help text
9970         for the "catch exception" command.
9971
9972 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9973
9974         * symtab.c (matching_obj_sections): Initialize obj,
9975         declare it closer to its usage.
9976
9977 2019-01-10  Tom Tromey  <tom@tromey.com>
9978
9979         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9980         (basic_inf_threads_range): Remove.
9981         (inf_threads_range, inf_non_exited_threads_range)
9982         (safe_inf_threads_range): Use next_adapter.
9983
9984 2019-01-10  Keith Seitz  <keiths@redhat.com>
9985
9986         PR gdb/23712
9987         PR symtab/23010
9988         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9989         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9990
9991 2019-01-10  Keith Seitz  <keiths@redhat.com>
9992
9993         PR gdb/23712
9994         PR symtab/23010
9995         * dictionary.c (pending_to_vector): Remove.
9996         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9997         Remove _1 suffix, replacing functions of the same name.  Update
9998         all callers.
9999         (dict_create_hashed, dict_create_hashed_expandable)
10000         (dict_create_linear, dict_create_linear_expandable, dict_free)
10001         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10002         Make functions static.
10003
10004 2019-01-10  Keith Seitz  <keiths@redhat.com>
10005
10006         PR gdb/23712
10007         PR symtab/23010
10008         * dictionary.h (struct dictionary): Replace declaration with
10009         multidictionary.
10010         (dict_create_hashed, dict_create_hashed_expandable)
10011         (dict_create_linear, dict_create_linear_expandable)
10012         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10013         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10014         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10015         taking multidictionary argument.
10016         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10017         * block.h (struct block) <dict>: Change to multidictionary
10018         and rename `multidict'.
10019         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10020         symmisc.c: Update all dictionary references to multidictionary.
10021
10022 2019-01-10  Keith Seitz  <keiths@redhat.com>
10023
10024         PR gdb/23712
10025         PR symtab/23010
10026         * dictionary.c: Include unordered_map.
10027         (pending_to_vector): New function.
10028         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10029         Rewrite the non-"_1" functions to take vector instead
10030         of linked list.
10031         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10032         "new" _1 versions of the same name.
10033         (multidictionary): Define.
10034         (std::hash<enum language): New definition.
10035         (collate_pending_symbols_by_language, mdict_create_hashed)
10036         (mdict_create_hashed_expandable, mdict_create_linear)
10037         (mdict_create_linear_expandable, mdict_free)
10038         (find_language_dictionary, create_new_language_dictionary)
10039         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10040         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10041         (mdict_size, mdict_empty): New functions.
10042         * dictionary.h (mdict_iterator): Define.
10043
10044 2019-01-10  Pedro Alves  <palves@redhat.com>
10045
10046         * breakpoint.c (read_uploaded_action)
10047         (create_tracepoint_from_upload): Adjust to use
10048         gdb::unique_xmalloc_ptr.
10049         * ctf.c (ctf_write_uploaded_tp):
10050         (SET_ARRAY_FIELD): Use emplace_back.
10051         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10052         * tracefile-tfile.c (tfile_write_uploaded_tp):
10053         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10054         gdb::unique_xmalloc_ptr.
10055         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10056         at_string, cond_string, cmd_strings>: Replace char pointers
10057         with gdb::unique_xmalloc_ptr.
10058
10059 2019-01-10  Pedro Alves  <palves@redhat.com>
10060
10061         * solib-target.c (library_list_start_library): Don't xstrdup name.
10062
10063 2019-01-10  Pedro Alves  <palves@redhat.com>
10064
10065         * mdebugread.c (parse_partial_symbols): Use
10066         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10067
10068 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10069
10070         * linux-fork.c (scoped_switch_fork_info)
10071         <~scoped_switch_fork_info>: Fix incorrect variable name.
10072
10073 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10074
10075         * linux-fork.c (scoped_switch_fork_info)
10076         <scoped_switch_fork_info>: Make explicit.
10077         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10078
10079 2019-01-10  Tom Tromey  <tom@tromey.com>
10080
10081         * objfiles.h (objfile::reset_psymtabs): Update.
10082         * objfiles.c (objfile::objfile): Update.
10083         * psymtab.h (psymtab_storage::obstack): Update.
10084         (psymtab_storage::m_obstack): Use gdb::optional.
10085         (class psymtab_storage): Update comment.  Remove objfile
10086         parameter.
10087         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10088
10089 2019-01-10  Tom Tromey  <tom@tromey.com>
10090
10091         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10092         <free_psymtabs>: Now private.
10093         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10094         (allocate_psymtab): Use new method.
10095
10096 2019-01-10  Tom Tromey  <tom@tromey.com>
10097
10098         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10099         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10100         * mdebugread.c (parse_partial_symbols): Use
10101         allocate_dependencies.
10102         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10103         allocate_dependencies.
10104         (process_psymtab_comp_unit_reader)
10105         (build_type_psymtab_dependencies): Likewise.
10106         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10107
10108 2019-01-10  Tom Tromey  <tom@tromey.com>
10109
10110         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10111         PSYMBOL_SET_LANGUAGE.
10112         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10113
10114 2019-01-10  Tom Tromey  <tom@tromey.com>
10115
10116         * psymtab.h (psymtab_storage::obstack): New method.
10117         <m_obstack>: Rename from obstack; now private.
10118         * psymtab.c (psymtab_storage): Update.
10119         * dwarf2read.c (create_addrmap_from_index)
10120         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10121         Update.
10122
10123 2019-01-10  Tom Tromey  <tom@tromey.com>
10124
10125         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10126         * objfiles.h (objfile::reset_psymtabs): New method.
10127
10128 2019-01-10  Tom Tromey  <tom@tromey.com>
10129
10130         * symmisc.c (print_symbol_bcache_statistics): Update.
10131         (print_objfile_statistics): Update.
10132         * symfile.c (reread_symbols): Update.
10133         * psymtab.h (class psymtab_storage): New.
10134         * psymtab.c (psymtab_storage): New constructor.
10135         (~psymtab_storage): New destructor.
10136         (require_partial_symbols): Update.
10137         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10138         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10139         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10140         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10141         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10142         (start_psymtab_common, end_psymtab_common)
10143         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10144         (allocate_psymtab): Update.
10145         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10146         Update.
10147         (dump_psymtab_addrmap, maintenance_print_psymbols)
10148         (maintenance_check_psymtabs): Update.
10149         (class objfile_psymtabs): Move to objfiles.h.
10150         * psympriv.h (discard_psymtab): Now inline.
10151         (psymtab_discarder::psymtab_discarder): Update.
10152         (psymtab_discarder::~psymtab_discarder): Update.
10153         (ALL_OBJFILE_PSYMTABS): Rewrite.
10154         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10155         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10156         Remove fields.
10157         <partial_symtabs>: New field.
10158         (class objfile_psymtabs): Move from psymtab.h.  Update.
10159         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10160         psymbol_cache.
10161         (objfile::~objfile): Don't destroy psymbol_cache.
10162         * mdebugread.c (parse_partial_symbols): Update.
10163         * dwarf2read.c (create_addrmap_from_index)
10164         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10165         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10166         (add_partial_subprogram, dwarf2_ranges_read): Update.
10167         * dwarf-index-write.c (write_address_map)
10168         (write_one_signatured_type, recursively_write_psymbols)
10169         (class debug_names, class debug_names, write_psymtabs_to_index):
10170         Update.
10171
10172 2019-01-10  Tom Tromey  <tom@tromey.com>
10173
10174         * symtab.h (SYMBOL_SET_NAMES): Update.
10175         (symbol_set_names): Update.
10176         (MSYMBOL_SET_NAMES): Update.
10177         * symtab.c (symbol_set_names): Change argument to be an
10178         objfile_per_bfd_storage.
10179         * psymtab.c (add_psymbol_to_bcache): Update.
10180         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10181
10182 2019-01-10  Tom Tromey  <tom@tromey.com>
10183
10184         * symtab.c (create_demangled_names_hash): Change argument to be an
10185         objfile_per_bfd_storage.
10186         (symbol_set_names): Update.
10187
10188 2019-01-10  Tom Tromey  <tom@tromey.com>
10189
10190         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10191         init_psymbol_list.
10192         * psymtab.c (init_psymbol_list): Do nothing if already called.
10193         * psympriv.h (init_psymbol_list): Add comment.
10194         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10195         init_psymbol_list.
10196         * dbxread.c (dbx_symfile_read): Unconditionally call
10197         init_psymbol_list.
10198
10199 2019-01-10  Tom Tromey  <tom@tromey.com>
10200
10201         * xcoffread.c (scan_xcoff_symtab): Update.
10202         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10203         "where".
10204         * mdebugread.c (parse_partial_symbols)
10205         (handle_psymbol_enumerators): Update.
10206         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10207         * dbxread.c (read_dbx_symtab): Update.
10208         * psympriv.h (psymbol_placement): New enum.
10209         (add_psymbol_to_list): Update.
10210
10211 2019-01-10  Tom Tromey  <tom@tromey.com>
10212
10213         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10214         static_psymbols parameters.
10215         (scan_xcoff_symtab): Update.
10216         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10217         static_psymbols parameters.
10218         * psympriv.h (start_psymtab_common): Update.
10219         * mdebugread.c (parse_partial_symbols): Update.
10220         * dwarf2read.c (create_partial_symtab): Update.
10221         * dbxread.c (read_dbx_symtab): Update.
10222         (start_psymtab): Remove global_psymbols and static_psymbols
10223         parameters.
10224
10225 2019-01-10  Tom Tromey  <tom@tromey.com>
10226
10227         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10228         * psymtab.c (allocate_psymtab): Add comment.
10229         * psympriv.h (allocate_psymtab): Add comment.
10230         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10231         initializations.
10232         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10233
10234 2019-01-10  Tom Tromey  <tom@tromey.com>
10235
10236         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10237         Don't declare.
10238         * mipsread.c: Include mdebugread.h.
10239         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10240         Declare.
10241         * elfread.c: Include mdebugread.h.
10242
10243 2019-01-09  Tom Tromey  <tom@tromey.com>
10244
10245         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10246         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10247         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10248         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10249         (psym_lookup_symbol, psym_find_last_source_symtab)
10250         (psym_forget_cached_source_info, psym_print_stats)
10251         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10252         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10253         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10254         (psym_find_compunit_symtab_by_address)
10255         (maintenance_print_psymbols, maintenance_info_psymtabs)
10256         (maintenance_check_psymtabs): Use ranged for.
10257         * psymtab.h (class objfile_psymtabs): New.
10258         (require_partial_symbols): Return objfile_psymtabs.
10259         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10260
10261 2019-01-09  Tom Tromey  <tom@tromey.com>
10262
10263         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10264         (find_pc_mapped_section, list_overlays_command)
10265         (map_overlay_command, unmap_overlay_command)
10266         (simple_overlay_update): Use all_objfiles.
10267         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10268         * printcmd.c (info_symbol_command): Use all_objfiles.
10269         * objfiles.h (ALL_OBJSECTIONS): Remove.
10270         * maint.c (maintenance_translate_address): Use all_objfiles.
10271         * gcore.c (gcore_create_callback): Use all_objfiles.
10272         (objfile_find_memory_regions): Likewise.
10273
10274 2019-01-09  Tom Tromey  <tom@tromey.com>
10275
10276         * symtab.c (find_line_symtab, info_sources_command)
10277         (make_source_files_completion_list): Use objfile_compunits.
10278         * source.c (select_source_symtab): Use objfile_compunits.
10279         * objfiles.h (struct objfile): Update comment.
10280         (ALL_OBJFILES): Remove.
10281         (ALL_FILETABS): Remove.
10282         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10283         objfile_compunits.
10284
10285 2019-01-09  Tom Tromey  <tom@tromey.com>
10286
10287         * symmisc.c (print_objfile_statistics, dump_objfile)
10288         (maintenance_print_symbols): Use compunit_filetabs.
10289         * source.c (forget_cached_source_info_for_objfile): Use
10290         compunit_filetabs.
10291         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10292         (ALL_FILETABS): Use compunit_filetabs.
10293         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10294         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10295
10296 2019-01-09  Tom Tromey  <tom@tromey.com>
10297
10298         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10299         (compunit_filetabs): New.
10300         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10301         compunit_filetabs.
10302         (info_sources_command, make_source_files_completion_list): Remove
10303         declaration.
10304         * symmisc.c (print_objfile_statistics, dump_objfile)
10305         (maintenance_print_symbols): Remove declaration.
10306         (maintenance_info_symtabs): Use compunit_filetabs.
10307         (maintenance_info_line_tables): Likewise.
10308         * source.c (select_source_symtab): Change local variable name.
10309         (forget_cached_source_info_for_objfile): Remove declaration.
10310         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10311         * objfiles.c (objfile_relocate1): Remove declaration.
10312         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10313         declaration.
10314         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10315         * coffread.c (coff_symtab_read): Remove declaration.
10316         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10317         compunit_filetabs.
10318
10319 2019-01-09  Tom Tromey  <tom@tromey.com>
10320
10321         * symtab.c (lookup_objfile_from_block)
10322         (find_pc_sect_compunit_symtab, search_symbols)
10323         (default_collect_symbol_completion_matches_break_on): Use
10324         objfile_compunits.
10325         * objfiles.h (ALL_COMPUNITS): Remove.
10326         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10327         * cp-support.c (add_symbol_overload_list_qualified): Use
10328         objfile_compunits.
10329         * ada-lang.c (ada_collect_symbol_completion_matches)
10330         (ada_add_global_exceptions): Use objfile_compunits.
10331
10332 2019-01-09  Tom Tromey  <tom@tromey.com>
10333
10334         * source.c (select_source_symtab)
10335         (forget_cached_source_info_for_objfile): Remove declaration.
10336         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10337         declaration.
10338         * maint.c (count_symtabs_and_blocks): Remove declaration.
10339         * cp-support.c (add_symbol_overload_list_qualified): Remove
10340         declaration.
10341         * coffread.c (coff_symtab_read): Remove declaration.
10342         * symtab.c (lookup_symbol_in_objfile_symtabs)
10343         (basic_lookup_transparent_type_1): Use objfile_compunits.
10344         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10345         (info_sources_command, search_symbols)
10346         (default_collect_symbol_completion_matches_break_on)
10347         (make_source_files_completion_list): Remove declaration.
10348         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10349         (ada_collect_symbol_completion_matches)
10350         (ada_add_global_exceptions): Remove declaration.
10351         * linespec.c (iterate_over_all_matching_symtabs): Use
10352         objfile_compunits.
10353         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10354         (class objfile_compunits): New.
10355         (ALL_COMPUNITS): Use objfile_compunits.
10356         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10357         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10358         objfile_compunits.
10359         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10360
10361 2019-01-09  Tom Tromey  <tom@tromey.com>
10362
10363         * symtab.c (search_symbols)
10364         (default_collect_symbol_completion_matches_break_on): Use
10365         objfile_msymbols.
10366         * ada-lang.c (ada_lookup_simple_minsym)
10367         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10368         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10369         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10370         objfile_msymbols.
10371         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10372         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10373         * objc-lang.c (find_methods): Use objfile_msymbols.
10374         (info_selectors_command, info_classes_command): Likewise.
10375         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10376         * objfiles.h (class objfile_msymbols): New.
10377         (ALL_OBJFILE_MSYMBOLS): Remove.
10378         (ALL_MSYMBOLS): Remove.
10379
10380 2019-01-09  Tom Tromey  <tom@tromey.com>
10381
10382         * common/next-iterator.h (next_adapter): Add Iterator template
10383         parameter.
10384         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10385         (class all_objfiles_safe): New.
10386         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10387         * objfiles.c (put_objfile_before): Update comment.
10388         (add_separate_debug_objfile): Likewise.
10389         (free_all_objfiles): Use all_objfiles_safe.
10390         (objfile_purge_solibs): Likewise.
10391
10392 2019-01-09  Tom Tromey  <tom@tromey.com>
10393
10394         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10395         (expand_symtab_containing_pc, lookup_static_symbol)
10396         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10397         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10398         all_objfiles.
10399         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10400         * breakpoint.c (create_overlay_event_breakpoint)
10401         (create_longjmp_master_breakpoint)
10402         (create_std_terminate_master_breakpoint)
10403         (create_exception_master_breakpoint): Use all_objfiles.
10404         * linux-thread-db.c (try_thread_db_load_from_pdir)
10405         (has_libpthread): Use all_objfiles.
10406         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10407         * linespec.c (iterate_over_all_matching_symtabs)
10408         (search_minsyms_for_name): Use all_objfiles.
10409         * maint.c (maintenance_info_sections): Use all_objfiles.
10410         * main.c (captured_main_1): Use all_objfiles.
10411         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10412         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10413         * guile/scm-pretty-print.c
10414         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10415         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10416         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10417         (maintenance_print_msymbols): Use all_objfiles.
10418         * source.c (select_source_symtab): Use all_objfiles.
10419         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10420         * symfile.c (remove_symbol_file_command)
10421         (expand_symtabs_matching, map_symbol_filenames): Use
10422         all_objfiles.
10423         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10424         all_objfiles.
10425         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10426         * objc-lang.c (find_methods): Use all_objfiles.
10427         * objfiles.c (have_partial_symbols, have_full_symbols)
10428         (have_minimal_symbols, qsort_cmp)
10429         (default_iterate_over_objfiles_in_search_order): Use
10430         all_objfiles.
10431         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10432         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10433         (maintenance_check_psymtabs): Use all_objfiles.
10434         (ALL_PSYMTABS): Remove.
10435         * compile/compile-object-run.c (do_module_cleanup): Use
10436         all_objfiles.
10437         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10438         * cp-support.c (add_symbol_overload_list_qualified): Use
10439         all_objfiles.
10440         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10441         Use all_objfiles.
10442         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10443         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10444         all_objfiles.
10445         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10446         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10447         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10448         Uses all_objfiles.
10449         * solib.c (solib_read_symbols): Use all_objfiles
10450
10451 2019-01-09  Tom Tromey  <tom@tromey.com>
10452
10453         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10454         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10455         all_objfiles.
10456         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10457         * symmisc.c (print_symbol_bcache_statistics)
10458         (print_objfile_statistics, maintenance_print_objfiles)
10459         (maintenance_info_symtabs, maintenance_check_symtabs)
10460         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10461         all_objfiles.
10462         * source.c (forget_cached_source_info): Use all_objfiles.
10463         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10464         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10465         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10466         * objfiles.c (update_section_map): Use all_objfiles.
10467         (shared_objfile_contains_address_p): Likewise.
10468         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10469         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10470
10471 2019-01-09  Tom Tromey  <tom@tromey.com>
10472
10473         * common/next-iterator.h: New file.
10474         * objfiles.h (class all_objfiles): New.
10475         (struct objfile_iterator): New.
10476
10477 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10478
10479         * NEWS: Move the description of the changed "frame", "select-frame",
10480          and "info frame" commands to the Changed commands section.
10481
10482 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10483
10484         * gdbtypes.c (check_stub_method_group): Remove handling of old
10485         mangling schemes.
10486         * linespec.c (find_methods): Likewise.
10487         * stabsread.c (read_member_functions): Likewise.
10488         * valops.c (search_struct_method): Likewise.
10489         (value_struct_elt_for_reference): Likewise.
10490         * NEWS: Mention this change.
10491
10492 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10493
10494         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10495         print_source_lines.
10496         * source.c (print_source_lines_base): Update line number check.
10497         (print_source_lines): New function.
10498         (source_lines_range::source_lines_range): New function.
10499         * source.h (class source_lines_range): New class.
10500         (print_source_lines): New declaration.
10501
10502 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10503
10504         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10505
10506 2019-01-08  Tom Tromey  <tom@tromey.com>
10507             Simon Marchi  <simon.marchi@ericsson.com>
10508
10509         PR gdb/24060
10510         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10511         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10512         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10513         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10514         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10515         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10516
10517 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10518
10519         * source.c (select_source_symtab): Move header comment to
10520         declaration in source.h.
10521         (forget_cached_source_info_for_objfile): Likewise.
10522         (forget_cached_source_info): Likewise.
10523         (identify_source_line): Likewise.
10524         * source.h (identify_source_line): Move declaration from symtab.h
10525         and add comment from source.c
10526         (print_source_lines): Likewise.
10527         (forget_cached_source_info_for_objfile): Likewise.
10528         (forget_cached_source_info): Likewise.
10529         (select_source_symtab): Likewise.
10530         (enum print_source_lines_flag): Move definition from symtab.h.
10531         * symtab.h (identify_source_line): Move declaration to source.h.
10532         (print_source_lines): Likewise.
10533         (forget_cached_source_info_for_objfile): Likewise.
10534         (forget_cached_source_info): Likewise.
10535         (select_source_symtab): Likewise.
10536         (enum print_source_lines_flag): Move definition to source.h.
10537         * tui/tui-hooks.c: Add 'source.h' include.
10538
10539 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10540
10541         * source.c (print_source_lines_base): Handle requests to print
10542         reverse line number sequences, and guard against empty lines
10543         string.
10544
10545 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10546
10547         * source.c (print_source_lines_base): Fix skip of '\r' if next
10548         character is '\n'.
10549
10550 2019-01-06  Tom Tromey  <tom@tromey.com>
10551
10552         * c-exp.y (struct c_parse_state) <macro_original_text,
10553         expansion_obstack>: New member.
10554         (macro_original_text, expansion_obstack): Remove globals.
10555         (scan_macro_expansion, scanning_macro_expansion)
10556         (finished_macro_expansion): Update.
10557         (scan_macro_cleanup): Remove.
10558         (yylex, c_parse): Update.
10559
10560 2019-01-06  Tom Tromey  <tom@tromey.com>
10561
10562         * c-exp.y (struct c_parse_state) <strings>: New member.
10563         (operator_stoken): Update.
10564
10565 2019-01-06  Tom Tromey  <tom@tromey.com>
10566
10567         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10568         (union type_stack_elt) <typelist_val>: Now a pointer to
10569         std::vector.
10570         (type_stack_cleanup): Don't declare.
10571         (push_typelist): Update.
10572         * parse.c (pop_typelist): Return a std::vector.
10573         (push_typelist): Take a std::vector.
10574         (follow_types): Update.  Do not free args.
10575         (type_stack_cleanup): Remove.
10576         * c-exp.y (struct c_parse_state): New.
10577         (cpstate): New global.
10578         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10579         (nonempty_typelist): Update.
10580         (func_mod): Create a new vector.
10581         (c_parse): Create a c_parse_state.
10582         (check_parameter_typelist): Do not delete params.
10583         (function_method): Update.  Do not delete type_list.
10584
10585 2019-01-06  Tom Tromey  <tom@tromey.com>
10586
10587         PR gdb/28155:
10588         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10589         check_typedef.
10590         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10591         (print_return_value): Likewise.
10592
10593 2019-01-05  Tom Tromey  <tom@tromey.com>
10594
10595         * contrib/cleanup_check.py: Remove.
10596         * contrib/gcc-with-excheck: Remove.
10597         * contrib/exsummary.py: Remove.
10598         * contrib/excheck.py: Remove.
10599
10600 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10601
10602         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10603         NULL. Initialize tpprev to NULL instead of assigning it
10604         to NULL on the next statement.
10605         * windows-nat.c (windows_delete_thread): Remove check for
10606         main_thread_id before printing thread exit notifications.
10607         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10608         Remove thread ID check against main_thread_id.
10609         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10610         windows_delete_thread.
10611         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10612
10613 2019-01-04  Tom Tromey  <tom@tromey.com>
10614
10615         * compile/compile.c (_initialize_compile): Use upper case for
10616         metasyntactic variables.
10617         * symmisc.c (_initialize_symmisc): Use upper case for
10618         metasyntactic variables.
10619         * psymtab.c (_initialize_psymtab): Use upper case for
10620         metasyntactic variables.
10621         * demangle.c (demangle_command): Use upper case for metasyntactic
10622         variables.
10623         (_initialize_demangler): Likewise.
10624         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10625         variables.
10626
10627 2019-01-03  Tom Tromey  <tom@tromey.com>
10628
10629         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10630
10631 2019-01-03  Tom Tromey  <tom@tromey.com>
10632
10633         * python/py-symtab.c (salpy_str): Update.
10634         (struct salpy_sal_object) <symtab>: Now a PyObject.
10635         (salpy_dealloc): Update.
10636         (del_objfile_sal): Use gdbpy_ref.
10637
10638 2019-01-03  Tom Tromey  <tom@tromey.com>
10639
10640         * python/py-type.c (convert_field): Use new_reference.  Return
10641         gdbpy_ref.
10642         (make_fielditem): Return gdbpy_ref.
10643         (typy_fields): Update.
10644         (typy_getitem): Update.
10645         (field_name): Return gdbpy_ref.  Use new_reference.
10646         (typy_iterator_iternext): Update.
10647
10648 2019-01-03  Tom Tromey  <tom@tromey.com>
10649
10650         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10651
10652 2019-01-03  Tom Tromey  <tom@tromey.com>
10653
10654         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10655         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10656         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10657         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10658         (pspy_set_type_printers): Likewise.
10659         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10660         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10661         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10662         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10663         (objfpy_set_type_printers): Likewise.
10664
10665 2019-01-03  Tom Tromey  <tom@tromey.com>
10666
10667         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10668         (gdbpy_print_stack): Use gdbpy_err_fetch.
10669         * python/python-internal.h (class gdbpy_err_fetch): New class.
10670         (class gdbpy_enter) <m_error_type, m_error_value,
10671         m_error_traceback>: Remove.
10672         <m_error>: New member.
10673         (gdbpy_exception_to_string): Don't declare.
10674         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10675         * python/py-value.c (convert_value_from_python): Use
10676         gdbpy_err_fetch.
10677         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10678         gdbpy_exception_to_string.
10679         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10680         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10681         gdbpy_err_fetch.
10682
10683 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10684
10685         * linux-nat.c (delete_lwp_cleanup): Delete.
10686         (struct lwp_deleter): New struct.
10687         (lwp_info_up): New typedef.
10688         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10689         lwp_info_up.
10690
10691 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10692
10693         * linux-fork.c (class scoped_switch_fork_info): New class.
10694         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10695
10696 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10697
10698         * valops.c (find_overload_match): Remove use of null_cleanup, and
10699         calls to do_cleanups.
10700
10701 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10702
10703         * compile/compile-cplus-types.c
10704         (compile_cplus_instance::decl_name): Handle changes to
10705         cp_func_name.
10706         * cp-support.c (cp_func_name): Update header comment, update
10707         return type.
10708         * cp-support.h (cp_func_name): Update return type in declaration.
10709         * valops.c (find_overload_match): Move temp_func local to top
10710         level of function and change its type.  Use temp_func to hold and
10711         delete temporary string obtained from cp_func_name.
10712
10713 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10714
10715         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10716         gdb::char_vector, remove cleanup, and update uses of `msg`.
10717
10718 2019-01-03  Jim Wilson  <jimw@sifive.com>
10719
10720         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10721
10722 2019-01-02  Tom Tromey  <tom@tromey.com>
10723
10724         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10725         (tdesc_parse_xml): Remove cleanups.
10726         * target-descriptions.h (make_cleanup_free_target_description):
10727         Don't declare.
10728         (target_desc_deleter): New struct.
10729         (target_desc_up): New typedef.
10730         * target-descriptions.c (target_desc_deleter::operator()): Rename
10731         from free_target_description.
10732         (make_cleanup_free_target_description): Remove.
10733
10734 2019-01-02  Tom Tromey  <tom@tromey.com>
10735
10736         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10737         constructor, destructor.
10738         (linespec_parser): Remove typedef.
10739         (~linespec_parser): Rename from linespec_parser_delete.
10740         (linespec_lex_to_end, linespec_complete_label)
10741         (linespec_complete): Update.
10742         (decode_line_full): Remove cleanups.
10743         (decode_line_1): Update.
10744
10745 2019-01-02  Tom Tromey  <tom@tromey.com>
10746
10747         * python/python-internal.h (inferior_to_inferior_object): Change
10748         return type.
10749         * python/py-exitedevent.c (create_exited_event_object): Update.
10750         * python/py-inferior.c (inferior_to_inferior_object): Return
10751         gdbpy_ref.
10752         (python_new_inferior, python_inferior_deleted)
10753         (thread_to_thread_object, delete_thread_object)
10754         (build_inferior_list, gdbpy_selected_inferior): Update.
10755         * python/py-infthread.c (create_thread_object): Update.  Also fail
10756         if inferior_to_inferior_object fails.
10757
10758 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10759
10760         * inferior.h (class inferior) <displaced_step_state>: New field.
10761         * infrun.h (struct displaced_step_state): Move here from
10762         infrun.c.  Initialize fields, add constructor.
10763         <inf>: Remove field.
10764         <reset>: New method.
10765         * infrun.c (struct displaced_step_inferior_state): Move to
10766         infrun.h.
10767         (displaced_step_inferior_states): Remove.
10768         (get_displaced_stepping_state): Adust.
10769         (displaced_step_in_progress_any_inferior): Adjust.
10770         (displaced_step_in_progress_thread): Adjust.
10771         (displaced_step_in_progress): Adjust.
10772         (add_displaced_stepping_state): Remove.
10773         (get_displaced_step_closure_by_addr): Adjust.
10774         (remove_displaced_stepping_state): Remove.
10775         (infrun_inferior_exit): Call displaced_step_state.reset.
10776         (use_displaced_stepping): Don't check for NULL.
10777         (displaced_step_prepare_throw): Call
10778         get_displaced_stepping_state.
10779         (displaced_step_fixup): Don't check for NULL.
10780         (prepare_for_detach): Don't check for NULL.
10781
10782 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10783
10784         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10785          in case of call that did not complete.
10786
10787 2019-01-02  Andrey Utkin  <autkin@undo.io>
10788
10789         * symfile.c (find_separate_debug_file): Fix search of debug files for
10790         remote debuggee.
10791
10792 2019-01-02  Tom Tromey  <tom@tromey.com>
10793
10794         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10795         indentation.
10796         * python/py-frame.c (frapy_older): Remove cast.
10797         (frapy_newer): Likewise.
10798         * python/py-breakpoint.c (local_setattro): Remove cast.
10799         * python/py-arch.c (archpy_name): Remove local variable.
10800         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10801
10802 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10803
10804         * unittests/basic_string_view/element_access/char/empty.cc:
10805         Fix year range in copyright header.
10806
10807 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10808
10809         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10810         Delete.
10811         <operator==>: Update with for removed field.
10812         <hash>: Likewise.
10813         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10814         <isa_features>: ...this.
10815         <abi_features>: New field.
10816         (riscv_isa_flen): Update comment.
10817         (riscv_abi_xlen): New declaration.
10818         (riscv_abi_flen): New declaration.
10819         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10820         isa_features.
10821         (riscv_abi_xlen): New function.
10822         (riscv_isa_flen): Update to get answer from isa_features.
10823         (riscv_abi_flen): New function.
10824         (riscv_has_fp_abi): Update to get answer from abi_features.
10825         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10826         xlen and flen.
10827         (riscv_call_info) <xlen, flen>: Update comment.
10828         (riscv_call_arg_struct): Remove invalid assertions
10829         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10830         is removed.
10831         (riscv_gdbarch_init): Gather isa features and abi features
10832         separately, ensure both match on the gdbarch when reusing an old
10833         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10834         a target with 64-bit float hardware.
10835
10836 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10837
10838         * source.c (search_command_helper): Stop reverse search
10839         when line 1 has been searched.
10840
10841 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10842
10843         * record-full.c (record_full_base_target::close): Rewrite
10844         record_full_core_buf_list free logic.
10845
10846 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10847
10848         * break-catch-syscall.c (print_one_catch_syscall): xfree
10849         the last text.
10850
10851 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10852
10853         * top.c (print_gdb_version): Update Copyright year in version
10854         message.
10855
10856 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10857
10858         Update copyright year range in all GDB files.
10859
10860 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10861
10862         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10863
10864 For older changes see ChangeLog-2018.
10865 \f
10866 Local Variables:
10867 mode: change-log
10868 left-margin: 8
10869 fill-column: 74
10870 version-control: never
10871 coding: utf-8
10872 End:
10873