gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
   4         (hppa_init_objfile_priv_data, read_unwind_info)
   5         (find_unwind_entry, _initialize_hppa_tdep): Update.
   6
   7 2019-05-08  Tom Tromey  <tom@tromey.com>
   8
   9         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
  10         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
  11         on obstack.
  12         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
  13
  14 2019-05-08  Tom Tromey  <tom@tromey.com>
  15
  16         * mdebugread.c (basic_type_data): Change type.
  17         (basic_type, _initialize_mdebugread): Update.
  18
  19 2019-05-08  Tom Tromey  <tom@tromey.com>
  20
  21         * common/gdb_unique_ptr.h (struct noop_deleter): New.
  22
  23 2019-05-08  Tom Tromey  <tom@tromey.com>
  24
  25         * nto-tdep.c (nto_inferior_data_reg): Change type.
  26         (nto_inferior_data): Update.
  27         (nto_inferior_data_cleanup, nto_new_inferior_data)
  28         (_initialize_nto_tdep): Remove.
  29         * nto-tdep.h (struct nto_inferior_data): Add initializers.
  30
  31 2019-05-08  Tom Tromey  <tom@tromey.com>
  32
  33         * ada-lang.c (struct ada_inferior_data): Add initializers.
  34         (ada_inferior_data): Change type.
  35         (ada_inferior_data_cleanup): Remove.
  36         (get_ada_inferior_data, ada_inferior_exit)
  37         (struct ada_pspace_data): Add initializers, destructor.
  38         (ada_pspace_data_handle): Change type.
  39         (get_ada_pspace_data): Update.
  40         (ada_pspace_data_cleanup): Remove.
  41
  42 2019-05-08  Tom Tromey  <tom@tromey.com>
  43
  44         * coffread.c (struct coff_symfile_info): Add initializers.
  45         (coff_objfile_data_key): Move lower.  Change type.
  46         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  47         Update.
  48         (coff_free_info): Remove.
  49
  50 2019-05-08  Tom Tromey  <tom@tromey.com>
  51
  52         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  53         (fbsd_pspace_data_handle): Move lower.  Change type.
  54         (get_fbsd_pspace_data): Update.
  55         (fbsd_pspace_data_cleanup): Remove.
  56         (_initialize_fbsd_tdep): Update.
  57
  58 2019-05-08  Tom Tromey  <tom@tromey.com>
  59
  60         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  61         (get_ada_tasks_pspace_data): Update.
  62         (ada_tasks_pspace_data_cleanup): Remove.
  63         (_initialize_tasks): Update.
  64         (ada_tasks_inferior_data_handle): Change type.
  65         (get_ada_tasks_inferior_data): Update.
  66         (ada_tasks_inferior_data_cleanup): Remove.
  67         (struct ada_tasks_pspace_data): Add initializers.
  68
  69 2019-05-08  Tom Tromey  <tom@tromey.com>
  70
  71         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  72         * symfile-debug.c (debug_sym_get_probes): Change type.
  73         * stap-probe.c (handle_stap_probe):
  74         (stap_static_probe_ops::get_probes): Change type.
  75         * probe.h (class static_probe_ops) <get_probes>: Change type.
  76         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  77         (parse_probes_in_pspace): Update.
  78         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  79         Update.
  80         (any_static_probe_ops::get_probes): Change type.
  81         * elfread.c (elfread_data): New typedef.
  82         (probe_key): Change type.
  83         (elf_get_probes): Likewise.  Update.
  84         (probe_key_free): Remove.
  85         (_initialize_elfread): Update.
  86         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
  87         Change type.
  88         (dtrace_process_dof_probe, dtrace_process_dof)
  89         (dtrace_static_probe_ops::get_probe): Change type.
  90
  91 2019-05-08  Tom Tromey  <tom@tromey.com>
  92
  93         * xcoffread.c (struct xcoff_symfile_info): Rename from
  94         coff_symfile_info.  Add initializers.
  95         (xcoff_objfile_data_key): Move lower.  Change type.
  96         (XCOFF_DATA): Rewrite.
  97         (xcoff_free_info): Remove.
  98         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
  99         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 100         (xcoff_initial_scan): Update.
 101
 102 2019-05-08  Tom Tromey  <tom@tromey.com>
 103
 104         * solib-svr4.c (struct svr4_info): Add initializers and
 105         destructor.
 106         <probes_table>: Now an htab_up.
 107         (solib_svr4_pspace_data): Change type.
 108         (free_probes_table): Simplify.
 109         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 110         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 111         (probes_table_remove_objfile_probes, register_solib_event_probe)
 112         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 113         (_initialize_svr4_solib): Update.
 114
 115 2019-05-08  Tom Tromey  <tom@tromey.com>
 116
 117         * remote.c (remote_pspace_data): Change type.
 118         (remote_pspace_data_cleanup): Remove.
 119         (get_remote_exec_file, set_pspace_remote_exec_file)
 120         (_initialize_remote): Update.
 121
 122 2019-05-08  Tom Tromey  <tom@tromey.com>
 123
 124         * breakpoint.c (breakpoint_objfile_key): Change type.
 125         (get_breakpoint_objfile_data): Update.
 126         (free_breakpoint_objfile_data): Remove.
 127         (_initialize_breakpoint): Update.
 128
 129 2019-05-08  Tom Tromey  <tom@tromey.com>
 130
 131         * linux-tdep.c (struct linux_info): Add initializers.
 132         (linux_inferior_data): Move.  Change type.
 133         (invalidate_linux_cache_inf): Update.
 134         (linux_inferior_data_cleanup): Remove.
 135         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 136
 137 2019-05-08  Tom Tromey  <tom@tromey.com>
 138
 139         * auxv.c (auxv_inferior_data): Move.  Change type.
 140         (auxv_inferior_data_cleanup): Remove.
 141         (invalidate_auxv_cache_inf): Rewrite.
 142         (get_auxv_inferior_data, _initialize_auxv): Update.
 143
 144 2019-05-08  Tom Tromey  <tom@tromey.com>
 145
 146         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 147         (symfile_debug_objfile_data_key): Change type.
 148         (symfile_debug_installed, debug_qf_has_symbols)
 149         (debug_qf_find_last_source_symtab)
 150         (debug_qf_forget_cached_source_info)
 151         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 152         (debug_qf_print_stats, debug_qf_dump)
 153         (debug_qf_expand_symtabs_for_function)
 154         (debug_qf_expand_all_symtabs)
 155         (debug_qf_expand_symtabs_with_fullname)
 156         (debug_qf_map_matching_symbols)
 157         (debug_qf_expand_symtabs_matching)
 158         (debug_qf_find_pc_sect_compunit_symtab)
 159         (debug_qf_map_symbol_filenames)
 160         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 161         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 162         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 163         (debug_sym_read_linetable, debug_sym_relocate): Update.
 164         (symfile_debug_free_objfile): Remove.
 165         (install_symfile_debug_logging, _initialize_symfile_debug):
 166         Update.
 167
 168 2019-05-08  Tom Tromey  <tom@tromey.com>
 169
 170         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 171         allocate_on_obstack.
 172         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 173         (get_dwarf2_per_objfile): Update.
 174         (set_dwarf2_per_objfile): Remove.
 175         (dwarf2_has_info, dwarf2_get_section_info): Update.
 176         (dwarf2_free_objfile): Remove.
 177         (_initialize_dwarf2_read): Update.
 178
 179 2019-05-08  Tom Tromey  <tom@tromey.com>
 180
 181         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 182         initializers.
 183         <unsupported_script_warning_printed,
 184         script_not_found_warning_printed>: Now bool.
 185         (auto_load_pspace_data): Change type.
 186         (~auto_load_pspace_info): Rename from
 187         auto_load_pspace_data_cleanup.
 188         (get_auto_load_pspace_data, init_loaded_scripts_info)
 189         (clear_section_scripts, maybe_print_unsupported_script_warning)
 190         (maybe_print_script_not_found_warning, _initialize_auto_load):
 191         Update.
 192
 193 2019-05-08  Tom Tromey  <tom@tromey.com>
 194
 195         * objfiles.c (objfile_pspace_info): Add destructor and
 196         initializers.
 197         (objfiles_pspace_data): Change type.
 198         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 199         (get_objfile_pspace_data): Update.
 200         (objfiles_bfd_data): Change type.
 201         (get_objfile_bfd_data): Update.
 202         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 203
 204 2019-05-08  Tom Tromey  <tom@tromey.com>
 205
 206         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 207         Change type.
 208         (get_catch_syscall_inferior_data): Update.
 209         (catch_syscall_inferior_data_cleanup): Remove.
 210         (_initialize_break_catch_syscall): Update.
 211
 212 2019-05-08  Tom Tromey  <tom@tromey.com>
 213
 214         * inflow.c (struct terminal_info): Add destructor and
 215         initializers.
 216         (inflow_inferior_data): Change type.
 217         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 218         (get_inflow_inferior_data, inflow_inferior_exit)
 219         (swap_terminal_info, _initialize_inflow): Update.
 220
 221 2019-05-08  Tom Tromey  <tom@tromey.com>
 222
 223         * target-dcache.c (target_dcache_cleanup): Remove.
 224         (target_dcache_aspace_key): Change type.
 225         (target_dcache_init_p, target_dcache_invalidate)
 226         (target_dcache_get, target_dcache_get_or_init)
 227         (_initialize_target_dcache): Update.
 228         * dcache.h (struct dcache_deleter): New.
 229
 230 2019-05-08  Tom Tromey  <tom@tromey.com>
 231
 232         * symtab.c (struct symbol_cache): Add destructor and
 233         initializers.
 234         (symbol_cache_key): Move.  Change type.
 235         (make_symbol_cache, free_symbol_cache): Remove.
 236         (get_symbol_cache): Update.
 237         (symbol_cache_cleanup): Remove.
 238         (ALL_PSPACES, symbol_cache_flush)
 239         (maintenance_print_symbol_cache)
 240         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 241         Update.
 242
 243 2019-05-08  Tom Tromey  <tom@tromey.com>
 244
 245         * symtab.c (struct main_info): Add destructor and initializers.
 246         (main_progspace_key): Move.  Change type.
 247         (get_main_info): Update.
 248         (main_info_cleanup): Remove.
 249         (_initialize_symtab): Update.
 250
 251 2019-05-08  Tom Tromey  <tom@tromey.com>
 252
 253         * registry.h (DECLARE_REGISTRY): Define the _key class.
 254
 255 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 256
 257         * NEWS: Merge two 'New commands' sections.
 258
 259 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 260
 261         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 262         parameter and use Ada language definition instead.
 263         (ada_val_print_ptr): Remove unused language parameter.
 264         (ada_val_print_num): Remove language parameter and use Ada language
 265         definition instead.
 266         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 267         parameter.
 268         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 269         parameter and use Ada language definition instead.
 270         (ada_val_print_1): Update all ada_val_print_xxx calls.
 271         Remove language parameter.
 272         (ada_val_print): Update ada_val_print_1 call.
 273
 274 2019-05-08  Tom Tromey  <tromey@adacore.com>
 275
 276         * remote.c (remote_hw_watchpoint_limit)
 277         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 278         Now static.
 279
 280 2019-05-08  Tom Tromey  <tromey@adacore.com>
 281
 282         * maint.c (_initialize_maint_cmds): Move initialization code to
 283         remote.c.
 284         (watchdog, show_watchdog): Move to remote.c.
 285         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 286         "watchdog" static.
 287         (_initialize_remote): Move initialization code from maint.c.
 288         * defs.h (watchdog): Don't declare.
 289
 290 2019-05-08  Tom Tromey  <tromey@adacore.com>
 291
 292         * tui/tui-interp.c: Include main.h.
 293         * interps.c: Include main.h.
 294         * main.h (interpreter_p): Declare.
 295         * defs.h (interpreter_p): Don't declare.
 296
 297 2019-05-08  Tom Tromey  <tromey@adacore.com>
 298
 299         * dwarf2loc.c: Include dwarf2read.h.
 300         * defs.h (read_unsigned_leb128): Don't declare.
 301         * dwarf2read.h (read_unsigned_leb128): Declare.
 302
 303 2019-05-08  Tom Tromey  <tromey@adacore.com>
 304
 305         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 306         method.
 307
 308 2019-05-08  Tom Tromey  <tromey@adacore.com>
 309
 310         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 311         when no wrap column is set.
 312
 313 2019-05-08  Tom Tromey  <tromey@adacore.com>
 314
 315         * c-lang.c (c_get_string): Handle non-C-style arrays.
 316
 317 2019-05-08  Tom Tromey  <tromey@adacore.com>
 318
 319         * typeprint.c (print_offset_data::update): Print the bit offset,
 320         not the number of bits remaining.
 321
 322 2019-05-08  Tom Tromey  <tromey@adacore.com>
 323
 324         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 325         padding at end of comment.
 326
 327 2019-05-08  Tom Tromey  <tromey@adacore.com>
 328
 329         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 330         Compare main types.
 331
 332 2019-05-06  Tom Tromey  <tom@tromey.com>
 333
 334         * common/scoped_mmap.c: Include common-defs.h.
 335         * common/scoped_mmap.h: Don't include config.h.
 336
 337 2019-05-04  Tom Tromey  <tom@tromey.com>
 338
 339         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 340         (struct aarch64_call_info): Add initializers.
 341         <si>: Now a std::vector.
 342         (pass_on_stack, aarch64_push_dummy_call): Update.
 343
 344 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 345             Tom Tromey  <tom@tromey.com>
 346
 347         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 348         (ppc_threads): Now a std::vector.  Now static.
 349         (hwdebug_find_thread_points_by_tid)
 350         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 351         Update.
 352
 353 2019-05-04  Tom Tromey  <tom@tromey.com>
 354
 355         * arc-tdep.c (arc_tdesc_init): Return bool.
 356
 357 2019-05-04  Tom Tromey  <tom@tromey.com>
 358
 359         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 360         Use gdb_assert_not_reached.
 361
 362 2019-05-04  Tom Tromey  <tom@tromey.com>
 363
 364         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 365         "false".
 366
 367 2019-05-04  Tom Tromey  <tom@tromey.com>
 368
 369         * arc-tdep.c (arc_tdesc_init): Use bool.
 370
 371 2019-05-04  Tom Tromey  <tom@tromey.com>
 372
 373         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 374
 375 2019-05-04  Tom Tromey  <tom@tromey.com>
 376
 377         * cli/cli-cmds.c (valid_command_p): Return bool.
 378
 379 2019-05-04  Tom Tromey  <tom@tromey.com>
 380
 381         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 382         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 383
 384 2019-05-04  Raul Tambre  <raul@tambre.ee>
 385
 386         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 387         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 388         operator for comparison.
 389
 390 2019-05-04  Tom Tromey  <tom@tromey.com>
 391
 392         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 393         (lookup_partial_symbol, print_partial_symbols)
 394         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 395         (psymbol_compare): Update.
 396         (add_psymbol_to_bcache): Clear the entire psymbol.
 397         (maintenance_check_psymtabs): Update.
 398         * psympriv.h (struct partial_symbol): Don't derive from
 399         general_symbol_info.
 400         <obj_section, unrelocated_address, address,
 401         set_unrelocated_address>: Update.
 402         <ginfo>: New member.
 403         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 404         (debug_names::write_psymbols): Update.
 405
 406 2019-05-04  Tom de Vries  <tdevries@suse.de>
 407
 408         * contrib/cc-with-tweaks.sh: Support -n arg.
 409
 410 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 411
 412         * corelow.c (core_target::detach): Ensure frame cache and
 413         register caches are cleared.
 414         inferior.c (exit_inferior_1): Likewise.
 415
 416 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 417             Tom Tromey  <tom@tromey.com>
 418
 419         * dictionary.c (collate_pending_symbols_by_language): Remove
 420         "struct" from foreach.
 421         * symtab.c (lookup_global_symbol_from_objfile)
 422         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 423         foreach.
 424         * ser-tcp.c (net_open): Remove "struct" from foreach.
 425         * objfiles.c (objfile_relocate, objfile_rebase)
 426         (objfile_has_symbols): Remove "struct" from foreach.
 427         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 428         from foreach.
 429         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 430         foreach.
 431         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 432         "struct" from foreach.
 433         * ada-lang.c (create_excep_cond_exprs)
 434         (ada_exception_catchpoint_cond_string): Remove "struct" from
 435         foreach.
 436
 437 2019-05-03  Tom Tromey  <tromey@adacore.com>
 438
 439         * ada-exp.y (convert_char_literal): Check suffix of each
 440         enumerator.
 441
 442 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 443
 444         PR ada/21406:
 445         * ada-exp.y (yywrap): Don't define.
 446         * ada-lex.l (%option): Add noyywrap
 447         (yywrap): Remove.
 448
 449 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 450
 451         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 452         _WIN32_WINNT to the XP level, unless already defined to a higher
 453         level.
 454
 455         * unittests/parse-connection-spec-selftests.c:
 456         * ser-tcp.c:
 457         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 458         override.
 459
 460         * symfile.c (find_separate_debug_file): Remove colon from the
 461         drive spec of DOS/Windows file names of the target, so that the
 462         file name produced from DEBUGDIR and the target's directory will
 463         be valid on DOS/Windows systems.
 464
 465 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 466
 467         * rust-lang.c (val_print_struct): Handle printing structures
 468         containing strings.
 469
 470 2019-05-02  Tom Tromey  <tromey@adacore.com>
 471
 472         * valarith.c (_initialize_valarith): Remove.
 473
 474 2019-05-01  Tom Tromey  <tromey@adacore.com>
 475
 476         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 477         bitfields.
 478
 479 2019-05-01  Tom Tromey  <tromey@adacore.com>
 480
 481         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 482         for big-endian copies.
 483
 484 2019-04-30  Ali Tamur  <tamur@google.com>
 485         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 486         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 487         (read_3_bytes): New function.
 488
 489 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 490
 491         * windows-nat.c (main_thread_id): Delete.
 492         (handle_output_debug_string): Replace main_thread_id by
 493         current_event.dwThreadId.
 494         (fake_create_process): Likewise.
 495         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 496         Do not set main_thread_id.
 497         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 498         current_event.dwThreadId.
 499         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 500
 501 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 502
 503         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 504         Use current_event.dwThreadId instead of main_thread_id.
 505
 506 2019-04-30  Tom Tromey  <tromey@adacore.com>
 507
 508         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 509         (create_excep_cond_exprs): Iterate over program spaces.
 510         (ada_exception_catchpoint_cond_string): Examine all minimal
 511         symbols for exception types.
 512
 513 2019-04-30  Tom Tromey  <tromey@adacore.com>
 514
 515         PR c++/24470:
 516         * dwarf2read.c (process_structure_scope): Handle case where type
 517         has template parameters but no symbol was created.
 518
 519 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 520             Chris January  <chris.january@arm.com>
 521
 522         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 523         qualifier.
 524         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 525
 526 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * f-typeprint.c (f_print_type): Update rules for printing
 529         whitespace.
 530         (f_type_print_varspec_suffix): Likewise.
 531
 532 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 533             Chris January  <chris.january@arm.com>
 534
 535         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 536         function arguments.
 537
 538 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         * f-lang.c (build_fortran_types): Change name of void type to
 541         lower case.
 542         * f-typeprint.c (f_type_print_base): Print the name of the void
 543         type, rather than a fixed string.
 544         * f-valprint.c (f_decorations): Use lower case void string.
 545
 546 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 547             Chris January  <chris.january@arm.com>
 548
 549         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 550         types for Fortran.
 551
 552 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 553             Chris January  <chris.january@arm.com>
 554             David Lecomber  <david.lecomber@arm.com>
 555
 556         * f-exp.y (BINOP_INTRINSIC): New token.
 557         (exp): New parser rule handling BINOP_INTRINSIC.
 558         (f77_keywords): Add new builtin procedures.
 559         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 560         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 561         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 562         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 563         (print_unop_subexp_f): New function.
 564         (print_binop_subexp_f): New function.
 565         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 566         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 567         (dump_subexp_body_f): Likewise.
 568         (operator_check_f): Likewise.
 569         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 570         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 571
 572 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 575         UNOP_KIND.
 576         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 577         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 578         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 579         (operator_length_f): New fuction.
 580         (print_subexp_f): New function.
 581         (op_name_f): New function.
 582         (dump_subexp_body_f): New function.
 583         (operator_check_f): New function.
 584         (exp_descriptor_f): Replace standard expression handling functions
 585         with new functions.
 586         * gdb/fortran-operator.def: New file.
 587         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 588         * gdb/std-operator.def: Remove UNOP_KIND.
 589
 590 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 591
 592         * std-operator.def: Remove unbalanced, stray double quote
 593         character.
 594
 595 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 596             Chris January  <chris.january@arm.com>
 597             Daniel Everett  <daniel.everett@arm.com>
 598             Nick Forrington  <nick.forrington@arm.com>
 599             Richard Bunt  <richard.bunt@arm.com>
 600
 601         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 602         of depth when printing anonymous structs or unions.
 603         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 604         Don't print either the top-level value, or the children if the
 605         max-depth is exceeded.
 606         (ppscm_print_children): When printing the key of a map, allow one
 607         extra level of depth.
 608         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 609         print either the top-level value, or the children if the max-depth
 610         is exceeded.
 611         (print_children): When printing the key of a map, allow one extra
 612         level of depth.
 613         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 614         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 615         (user_print_options): Initialise max_depth field.
 616         (val_print_scalar_or_string_type_p): New function.
 617         (val_print): Check to see if the max depth has been reached.
 618         (val_print_check_max_depth): Define new function.
 619         (show_print_max_depth): New function.
 620         (_initialize_valprint): Add 'print max-depth' option.
 621         * valprint.h (struct value_print_options) <max_depth>: New field.
 622         (val_print_check_max_depth): Declare new function.
 623         * NEWS: Document new feature.
 624
 625 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 626
 627         * ada-lang.c (ada_language_defn): Initialise new field.
 628         * c-lang.c (c_is_string_type_p): New function.
 629         (c_language_defn): Initialise new field.
 630         (cplus_language_defn): Initialise new field.
 631         (asm_language_defn): Initialise new field.
 632         (minimal_language_defn): Initialise new field.
 633         * c-lang.h (c_is_string_type_p): Declare new function.
 634         * d-lang.c (d_language_defn): Initialise new field.
 635         * f-lang.c (f_is_string_type_p): New function.
 636         (f_language_defn): Initialise new field.
 637         * go-lang.c (go_is_string_type_p): New function.
 638         (go_language_defn): Initialise new field.
 639         * language.c (default_is_string_type_p): New function.
 640         (unknown_language_defn): Initialise new field.
 641         (auto_language_defn): Initialise new field.
 642         * language.h (struct language_defn) <la_is_string_type_p>: New
 643         member variable.
 644         (default_is_string_type_p): Declare new function.
 645         * m2-lang.c (m2_language_defn): Initialise new field.
 646         * objc-lang.c (objc_language_defn): Initialise new field.
 647         * opencl-lang.c (opencl_language_defn): Initialise new field.
 648         * p-lang.c (pascal_is_string_type_p): New function.
 649         (pascal_language_defn): Initialise new field.
 650         * rust-lang.c (rust_is_string_type_p): New function.
 651         (rust_language_defn): Initialise new field.
 652
 653 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 654
 655         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 656         New field.
 657         * ada-lang.c (ada_language_defn): Initialise new field.
 658         * c-lang.c (c_language_defn): Likewise.
 659         (cplus_language_defn): Likewise.
 660         (asm_language_defn): Likewise.
 661         (minimal_language_defn): Likewise.
 662         * d-lang.c (d_language_defn): Likewise.
 663         * f-lang.c (f_language_defn): Likewise.
 664         * go-lang.c (go_language_defn): Likewise.
 665         * language.c (unknown_language_defn): Likewise.
 666         (auto_language_defn): Likewise.
 667         * m2-lang.c (m2_language_defn): Likewise.
 668         * objc-lang.c (objc_language_defn): Likewise.
 669         * opencl-lang.c (opencl_language_defn): Likewise.
 670         * p-lang.c (pascal_language_defn): Likewise.
 671         * rust-lang.c (rust_language_defn): Likewise.
 672
 673 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 674
 675         * ada-lang.c (ada_is_character_type): Change return type to bool.
 676         (ada_is_string_type): Likewise.
 677         * ada-lang.h (ada_is_character_type): Update declaration
 678         (ada_is_string_type): Likewise.
 679
 680 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 681
 682         Support style in 'frame|thread apply'
 683
 684         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 685         * record.c (record_start, record_stop): Update callers of
 686         execute_command_to_string with false.
 687         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 688         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 689         methods.
 690         (class string_file): New constructor with term_out parameter.
 691         Override methods term_out and can_emit_style_escape.  New member
 692         term_out.
 693         (class stdio_file): Override can_emit_style_escape.
 694         (class tee_file): Override term_out and can_emit_style_escape.
 695         * utils.h (can_emit_style_escape): Remove.
 696         * utils.c (can_emit_style_escape): Likewise.
 697         Update all callers of can_emit_style_escape (SOMESTREAM) to
 698         SOMESTREAM->can_emit_style_escape.
 699         * source-cache.c (source_cache::get_source_lines): Likewise.
 700         * stack.c (frame_apply_command_count): Call execute_command_to_string
 701         passing the term_out characteristic of the current gdb_stdout.
 702         * thread.c (thr_try_catch_cmd): Likewise.
 703         * top.c (execute_command_to_string): pass term_out parameter
 704         to construct the string_file for the command output.
 705         * ui-file.c (term_cli_styling): New function (most code moved
 706         from utils.c can_emit_style_escape).
 707         (string_file::string_file, string_file::can_emit_style_escape,
 708         stdio_file::can_emit_style_escape, tee_file::term_out,
 709         tee_file::can_emit_style_escape): New functions.
 710
 711 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 712
 713         * NEWS: Mention the new set|show may-call-functions.
 714         * infcall.c (may_call_functions_p): New variable.
 715         (show_may_call_functions_p): New function.
 716         (call_function_by_hand_dummy): Throws an error if not
 717         may-call-functions.
 718         (_initialize_infcall): Call add_setshow_boolean_cmd for
 719         may-call-functions.
 720
 721 2019-04-25  Keith Seitz  <keiths@redhat.com>
 722
 723         PR c++/24367
 724         * cp-support.c (inspect_type): Don't attempt substitutions
 725         of symbol with the same name.
 726
 727 2019-04-25  Tom Tromey  <tromey@adacore.com>
 728
 729         PR gdb/24475:
 730         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 731         static.
 732
 733 2019-04-25  Tom Tromey  <tromey@adacore.com>
 734
 735         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 736         rvalue reference.
 737         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 738         (gdb_xml_parser::parse): Use std::move.
 739         * python/python-internal.h (gdbpy_convert_exception): Take a const
 740         reference.
 741         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 742         std::move.
 743         * python/py-utils.c (gdbpy_convert_exception): Take a const
 744         reference.
 745         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 746         Use std::move.
 747         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 748         Use std::move.
 749         * mi/mi-main.c (mi_print_exception): Take a const reference.
 750         * main.c (handle_command_errors): Take a const reference.
 751         * linespec.c (parse_linespec): Use std::move.
 752         * infcall.c (run_inferior_call): Use std::move.
 753         (call_function_by_hand_dummy): Use std::move.
 754         * exec.c (try_open_exec_file): Use std::move.
 755         * exceptions.h (exception_print, exception_fprintf)
 756         (exception_print_same): Update.
 757         * exceptions.c (print_exception, exception_print)
 758         (exception_fprintf, exception_print_same): Change parameters to
 759         const reference.
 760         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 761         * common/new-op.c: Use std::move.
 762         * common/common-exceptions.h (struct gdb_exception): Add move
 763         constructor.
 764         (struct gdb_exception_error, struct gdb_exception_quit, struct
 765         gdb_quit_bad_alloc): Change constructor to move constructor.
 766         (throw_exception): Change parameter to rvalue reference.
 767         * common/common-exceptions.c (throw_exception): Take rvalue
 768         reference.
 769         * cli/cli-interp.c (safe_execute_command): Use std::move.
 770         * breakpoint.c (insert_bp_location, location_to_sals): Use
 771         std::move.
 772
 773 2019-04-25  Tom Tromey  <tromey@adacore.com>
 774
 775         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 776         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 777         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 778         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 779         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 780         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 781         guile/scm-value.c: Use unpack.
 782         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 783         gdbscm_gdb_exception.
 784         (gdbscm_throw_gdb_exception): Likewise.
 785         (struct gdbscm_gdb_exception): New.
 786         (unpack): New function.
 787         (gdbscm_wrap): Use unpack.
 788
 789 2019-04-25  Tom Tromey  <tromey@adacore.com>
 790
 791         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 792         (gdb_rl_callback_handler): Use std::move.
 793         * common/common-exceptions.h (struct gdb_exception): Add move
 794         assignment operator.
 795         (throw_exception_sjlj): Change "exception" to const reference.
 796         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 797         (throw_exception_sjlj): Change "exception" to const reference.
 798
 799 2019-04-25  Tom Tromey  <tromey@adacore.com>
 800
 801         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 802         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 803         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 804         Update.
 805         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 806         Update.
 807         * mi/mi-interp.c (mi_interp::exec): Update.
 808         * linespec.c (parse_linespec): Update.
 809         * infcall.c (run_inferior_call): Update.
 810         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 811         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 812         (gdbscm_lookup_global_symbol): Update.
 813         * guile/scm-param.c (gdbscm_parameter_value): Update.
 814         * guile/scm-frame.c (gdbscm_frame_read_register)
 815         (gdbscm_frame_read_var): Update.
 816         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 817         * exec.c (try_open_exec_file): Update.
 818         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 819         (gdb_rl_callback_handler): Update.
 820         * common/common-exceptions.h (exception_none): Don't declare.
 821         * common/common-exceptions.c (exception_none): Don't define.
 822         (struct catcher) <exception>: Update.
 823         * cli/cli-interp.c (safe_execute_command): Update.
 824         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 825
 826 2019-04-25  Ali Tamur  <tamur@google.com>
 827
 828         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 829         (read_attribute_value): Likewise.
 830         (dwarf2_read_addr_index): Update comment.
 831         (read_str_index): Add DW_FORM_strx.
 832         (dwarf2_string_attr): Likewise.
 833         (dwarf2_const_value_attr): Likewise.
 834         (dump_die_shallow): Likewise.
 835         (dwarf2_fetch_constant_bytes): Likewise.
 836         (skip_form_bytes): Likewise.
 837         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 838
 839 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 840
 841         PR corefiles/11608
 842         PR corefiles/18187
 843         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 844         OFFSET.  Verify if current mapping contains an ELF header.
 845         (linux_find_memory_regions_full): Adjust call to
 846         dump_mapping_p.
 847
 848 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 849             Kang Li <kanglictf@gmail.com>
 850
 851         PR gdb/21600
 852
 853         * dwarf2-frame.c (read_initial_length): Be consistent about using
 854         unsigned representation of length.
 855         (decode_frame_entry_1): Likewise.  Check for wraparound of
 856         end pointer as well as buffer overflow.
 857
 858 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 859
 860         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 861         "vq".
 862
 863 2019-04-24  Tom Tromey  <tromey@adacore.com>
 864
 865         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 866
 867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * s12z-tdep.c (s12z_unwind_pc): Delete.
 870         (s12z_unwind_sp): Delete.
 871         (s12z_gdbarch_init): Don't register deleted functions with
 872         gdbarch.
 873
 874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * rl78-tdep.c (rl78_unwind_sp): Delete.
 877         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 878
 879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 882         (xstormy16_unwind_pc): Delete.
 883         (xstormy16_dummy_id): Delete.
 884         (xstormy16_gdbarch_init): Don't register deleted functions with
 885         gdbarch.
 886
 887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * vax-tdep.c (vax_unwind_pc): Delete.
 890         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 891
 892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 893
 894         * v850-tdep.c (v850_unwind_sp): Delete.
 895         (v850_unwind_pc): Delete.
 896         (v850_dummy_id): Delete.
 897         (v850_gdbarch_init): Don't register deleted functions with
 898         gdbarch.
 899
 900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 903         (tilegx_unwind_pc): Delete.
 904         (tilegx_unwind_dummy_id): Delete.
 905         (tilegx_gdbarch_init): Don't register deleted functions with
 906         gdbarch.
 907
 908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 911         (tic6x_dummy_id): Delete.
 912         (tic6x_gdbarch_init): Don't register deleted functions with
 913         gdbarch.
 914
 915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * sparc-tdep.c (sparc_unwind_pc): Delete.
 918         (sparc32_gdbarch_init): Don't register deleted function with
 919         gdbarch.
 920
 921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 922
 923         * sh-tdep.c (sh_unwind_sp): Delete.
 924         (sh_unwind_pc): Delete.
 925         (sh_dummy_id): Delete.
 926         (sh_gdbarch_init): Don't register deleted functions with
 927         gdbarch.
 928
 929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 930
 931         * score-tdep.c (score_unwind_sp): Delete.
 932         (score_unwind_pc): Delete.
 933         (score_dummy_id): Delete.
 934         (score_gdbarch_init): Don't register deleted functions with
 935         gdbarch.
 936
 937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * rx-tdep.c (rx_unwind_pc): Delete.
 940         (rx_unwind_sp): Delete.
 941         (rx_dummy_id): Delete.
 942         (rx_gdbarch_init): Don't register deleted functions with
 943         gdbarch.  Update comment.
 944
 945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 946
 947         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 948         (rs6000_dummy_id): Delete.
 949         (rs6000_gdbarch_init): Don't register deleted functions with
 950         gdbarch.
 951
 952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 953
 954         * or1k-tdep.c (or1k_dummy_id): Delete.
 955         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 956
 957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * nios2-tdep.c (nios2_dummy_id): Delete.
 960         (nios2_unwind_sp): Delete.
 961         (nios2_gdbarch_init): Don't register deleted functions with
 962         gdbarch.
 963
 964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 965
 966         * nds32-tdep.c (nds32_dummy_id): Delete.
 967         (nds32_unwind_pc): Delete.
 968         (nds32_unwind_sp): Delete.
 969         (nds32_gdbarch_init): Don't register deleted functions with
 970         gdbarch.
 971
 972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         * msp430-tdep.c (msp430_unwind_pc): Delete.
 975         (msp430_unwind_sp): Delete.
 976         (msp430_dummy_id): Delete.
 977         (msp430_gdbarch_init): Don't register deleted functions with
 978         gdbarch.
 979
 980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * moxie-tdep.c (moxie_unwind_sp): Delete.
 983         (moxie_unwind_pc): Delete.
 984         (moxie_dummy_id): Delete.
 985         (moxie_gdbarch_init): Don't register deleted functions with
 986         gdbarch.
 987
 988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 991         (mn10300_unwind_pc): Delete.
 992         (mn10300_unwind_sp): Delete.
 993         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 994         mn10300_unwind_sp.
 995         (mn10300_frame_unwind_init): Don't register deleted functions with
 996         gdbarch.
 997
 998 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 999
1000         * mep-tdep.c (mep_unwind_pc): Delete.
1001         (mep_unwind_sp): Delete.
1002         (mep_dummy_id): Delete.
1003         (mep_gdbarch_init): Don't register deleted functions with
1004         gdbarch.
1005
1006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1007
1008         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1009         (m68hc11_unwind_sp): Delete.
1010         (m68hc11_gdbarch_init): Don't register deleted functions with
1011         gdbarch.
1012
1013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1014
1015         * m32r-tdep.c (m32r_unwind_sp): Delete.
1016         (m32r_unwind_pc): Delete.
1017         (m32r_dummy_id): Delete.
1018         (m32r_gdbarch_init): Don't register deleted functions with
1019         gdbarch.
1020
1021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1022
1023         * m32c-tdep.c (m32c_unwind_pc): Delete.
1024         (m32c_unwind_sp): Delete.
1025         (m32c_dummy_id): Delete.
1026         (m32c_gdbarch_init): Don't register deleted functions with
1027         gdbarch.
1028
1029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1032         (lm32_unwind_pc): Delete.
1033         (lm32_dummy_id): Delete.
1034         (lm32_gdbarch_init): Don't register deleted functions with
1035         gdbarch.
1036
1037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1040         (iq2000_unwind_pc): Delete.
1041         (iq2000_dummy_id): Delete.
1042         (iq2000_gdbarch_init): Don't register deleted functions with
1043         gdbarch.
1044
1045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1046
1047         * nds32-tdep.c (nds32_type_align): Delete.
1048         (nds32_push_dummy_call): Use type_align instead.
1049
1050 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * arm-tdep.c (arm_type_align): Only handle vector override case.
1053         (arm_push_dummy_call): Use type_align.
1054         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1055
1056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1059         case.
1060         (pass_on_stack): Use type_align.
1061         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1062         function.
1063
1064 2019-04-23  Tom Tromey  <tromey@adacore.com>
1065
1066         * dwarf2read.c (line_header::file_name_at): Remove unused
1067         overload.
1068
1069 2019-04-23  Tom de Vries  <tdevries@suse.de>
1070
1071         PR gdb/24438
1072         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1073         invocation.
1074
1075
1076 2019-03-27  Ali Tamur  <tamur@google.com>
1077
1078         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1079         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1080         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1081         (dwarf_expr_context::get_addr_index): Likewise
1082         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1083         (symbol_needs_eval_context::get_addr_index): Likewise
1084         (disassemble_dwarf_expression): Add DW_OP_addrx
1085         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1086         (read_cutu_die_from_dwo): Update comment
1087         (skip_one_die): Add DW_FORM_addrx
1088         (read_attribute_value): Likewise
1089         (var_decode_location): Add DW_OP_addrx
1090         (dwarf2_const_value_attr): Add DW_FORM_addrx
1091         (dump_die_shallow): Likewise
1092         (dwarf2_fetch_constant_bytes): Likewise
1093         (decode_locdesc): Add DW_OP_addrx
1094         (skip_form_bytes): Add DW_FORM_addrx
1095
1096 2019-04-22  Ali Tamur  <tamur@google.com>
1097
1098         * MAINTAINERS (Write After Approval): Add self.
1099
1100 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1101
1102         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1103         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1104         (open_symbol_file_object): Likewise.
1105         (svr4_default_sos): Add info parameter.
1106         (svr4_read_so_list): Likewise.
1107         (svr4_current_sos_direct): Adjust functions calls to pass down
1108         info.
1109         (svr4_current_sos_1): Add info parameter.
1110         (svr4_current_sos): Call get_svr4_info, pass info down to
1111         svr4_current_sos_1.
1112         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1113         get_svr4_info.
1114         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1115         get_svr4_info.
1116         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1117         to get_svr4_info.
1118         (probes_table_remove_objfile_probes): Likewise.
1119         (register_solib_event_probe): Add info parameter.
1120         (solist_update_incremental): Pass info parameter down to
1121         svr4_read_so_list.
1122         (disable_probes_interface): Add info parameter.
1123         (svr4_handle_solib_event): Pass current_program_space to
1124         get_svr4_info.  Adjust disable_probes_interface cleanup.
1125         (svr4_create_probe_breakpoints): Add info parameter, pass it
1126         down to register_solib_event_probe.
1127         (svr4_create_solib_event_breakpoints): Add info parameter,
1128         pass it down to svr4_create_probe_breakpoints.
1129         (enable_break): Pass info down to
1130         svr4_create_solib_event_breakpoints.
1131         (svr4_solib_create_inferior_hook): Pass current_program_space to
1132         get_svr4_info.
1133         (svr4_clear_solib): Likewise.
1134
1135 2019-04-22  Pedro Alves  <palves@redhat.com>
1136
1137         * solib-svr4.c (svr4_free_objfile_observer): New.
1138         (probe_and_action::objfile): New field.
1139         (probes_table_htab_remove_objfile_probes)
1140         (probes_table_remove_objfile_probes): New functions.
1141         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1142         in the new probe_and_action.  Don't store the probe in 'lookup'.
1143         (svr4_create_probe_breakpoints): Pass objfile to
1144         register_solib_event_probe.
1145         (_initialize_svr4_solib): Register a free_objfile observer.
1146
1147 2019-04-19  Tom Tromey  <tom@tromey.com>
1148
1149         * common/queue.h: Remove.
1150
1151 2019-04-19  Tom Tromey  <tom@tromey.com>
1152
1153         * event-loop.c: Don't include "common/queue.h".
1154
1155 2019-04-19  Tom Tromey  <tom@tromey.com>
1156
1157         * remote.c (remote_target): Use delete.
1158         * remote-notif.h: Include <list>, not "common/queue.h".
1159         (notif_client_p): Remove typedef.
1160         (remote_notif_state): Add constructor, destructor, initializer.
1161         <notif_queue>: Now a std::list.
1162         (remote_notif_state_xfree): Don't declare.
1163         * remote-notif.c (remote_notif_process, handle_notification)
1164         (remote_notif_state_allocate): Update.
1165         (~remote_notif_state): Rename from remote_notif_state_xfree.
1166
1167 2019-04-19  Tom Tromey  <tom@tromey.com>
1168
1169         * symfile.c (reread_symbols): Update.
1170         * objfiles.c (objfile_register_static_link)
1171         (objfile_lookup_static_link): Update
1172         (~objfile) Don't delete static_links.
1173         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1174
1175 2019-04-19  Tom Tromey  <tom@tromey.com>
1176
1177         * type-stack.h (struct type_stack) <insert>: Constify string.
1178         * type-stack.c (type_stack::insert): Constify string.
1179         * gdbtypes.h (lookup_template_type): Update.
1180         (address_space_name_to_int): Update.
1181         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1182         const.
1183         (lookup_template_type): Make name const.
1184         * c-exp.y: Update rules.
1185         (lex_one_token, classify_name, classify_inner_name)
1186         (c_print_token): Update.
1187         * p-exp.y: Update rules.
1188         (yylex): Update.
1189         * f-exp.y: Update rules.
1190         (yylex): Update.
1191         * d-exp.y: Update rules.
1192         (lex_one_token, classify_name, classify_inner_name): Update.
1193         * parse.c (write_dollar_variable, copy_name): Return std::string.
1194         * parser-defs.h (copy_name): Change return type.
1195         * m2-exp.y: Update rules.
1196         (yylex): Update.
1197         * go-exp.y (lex_one_token): Update.
1198         Update rules.
1199         (classify_unsafe_function, classify_packaged_name)
1200         (classify_name, yylex): Update.
1201
1202 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1203
1204         * configure.ac: add --enable-source-highlight switch.
1205         * configure: Regenerate.
1206         * top.c (print_gdb_version): plumb --enable-source-highlight
1207         status to "show configuration".
1208
1209 2019-04-19  Tom Tromey  <tromey@adacore.com>
1210
1211         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1212         Check ADA_TYPE_P.
1213         (empty_record, ada_template_to_fixed_record_type_1)
1214         (template_to_static_fixed_type)
1215         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1216         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1217         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1218         macros.
1219
1220 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1221
1222         PR symtab/24423:
1223         * source.c (print_source_lines_base): Advance "iter" when a
1224         control character is seen.
1225
1226 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1227
1228         * inferior.h (struct infcall_suspend_state_deleter):
1229         Catch exception in destructor to avoid crash.
1230
1231 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1232
1233         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1234         close to the add_com "shell".
1235
1236 2019-04-18  Tom Tromey  <tromey@adacore.com>
1237
1238         * process-stratum-target.h (class process_stratum_target)
1239         <stratum>: Add "final".
1240
1241 2019-04-17  Tom Tromey  <tromey@adacore.com>
1242
1243         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1244         against nullptr before use.
1245
1246 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1247
1248         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1249
1250 2019-04-17  Jim Wilson  <jimw@sifive.com>
1251             Andrew Burgess  <andrew.burgess@embecosm.com>
1252
1253         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1254         code read might fail, assume 4-byte breakpoint in that case.
1255
1256 2019-04-15  Leszek Swirski  <leszeks@google.com>
1257
1258         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1259         rather than a hand-rolled POD check when checking for forced MEMORY
1260         classification.
1261
1262 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1263
1264         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1265         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1266         function.
1267         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1268         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1269         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1270         declaration.
1271
1272 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1273
1274         * aarch64-linux-nat.c
1275         (aarch64_linux_nat_target::thread_architecture): Add override.
1276         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1277         each VQ.
1278
1279 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1280
1281         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1282
1283 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1286         target types of size 96-bits, add some additional comments, and
1287         check that the builtin type we found was the correct size.
1288
1289 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1290
1291         * utils.c (prompt_for_continue): Don't restore the styling at the
1292         end, as applied_style has the wrong value.  This fixes styling in
1293         long lists of file names that are interrupted by the "Continue?"
1294         prompt.
1295
1296 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1297
1298         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1299         * c-lang.c (c_language_defn): Likewise.
1300         (cplus_language_defn): Likewise.
1301         (asm_language_defn): Likewise.
1302         (minimal_language_defn): Likewise.
1303         * d-lang.c (d_language_defn): Likewise.
1304         * f-lang.c (f_language_defn): Likewise.
1305         * go-lang.c (go_language_defn): Likewise.
1306         * language.c (unknown_language_defn): Likewise.
1307         (auto_language_defn): Likewise.
1308         * language.h (struct language_defn): Remove la_magic field.
1309         (LANG_MAGIC): Delete.
1310         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1311         * objc-lang.c (objc_language_defn): Likewise.
1312         * opencl-lang.c (opencl_language_defn): Likewise.
1313         * p-lang.c (pascal_language_defn): Likewise.
1314         * rust-lang.c (rust_language_defn): Likewise.
1315
1316 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1317
1318         * riscv-tdep.c (riscv_type_align): New function.
1319         (riscv_type_alignment): Delete.
1320         (riscv_arg_location): Use 'type_align'.
1321         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1322
1323 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * gdbtypes.c (type_align): A struct with no non-static fields also
1326         has alignment of 1.
1327
1328 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1329
1330         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1331         component to 0.
1332         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1333         member.
1334         (riscv_struct_info::analyse): New implementation using new
1335         analyse_inner member function.
1336         (riscv_struct_info::field_offset): New member function.
1337         (riscv_struct_info::m_offsets): New member variable.
1338         (riscv_struct_info::analyse_inner): New private member function,
1339         takes the old implementation of riscv_struct_info::analyse but
1340         extended to track field offsets.
1341         (riscv_call_arg_struct): Update the struct folding special cases
1342         to handle cases where empty C++ structs, which are non-zero
1343         length, are found.
1344         (riscv_arg_location): Initialise the length of each location, a
1345         non-zero length now indicates the location is in use.
1346         (riscv_push_dummy_call): Allow for the first location having a
1347         non-zero offset when setting up arguments.
1348         (riscv_return_value): Likewise, but for return values.
1349
1350 2019-04-11  Tom Tromey  <tromey@adacore.com>
1351
1352         * utils.c (internal_vproblem): Make "msg" const.
1353
1354 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1355
1356         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1357         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1358         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1359         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1360
1361 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1362
1363         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1364         function.
1365         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1366         of amd64_collect_native_gregset.
1367         (amd64_linux_nat_target::store_registers): Likewise.
1368
1369 2019-04-10  Tom Tromey  <tom@tromey.com>
1370
1371         * symtab.c (lookup_global_symbol_from_objfile)
1372         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1373         * objfiles.h (class separate_debug_iterator): New.
1374         (class separate_debug_range): New.
1375         (struct objfile) <separate_debug_objfiles>: New method.
1376         (objfile_separate_debug_iterate): Don't declare.
1377         * objfiles.c (separate_debug_iterator::operator++): Rename from
1378         objfile_separate_debug_iterate.
1379         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1380         iterator.
1381         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1382         iterator.
1383
1384 2019-04-10  Tom Tromey  <tom@tromey.com>
1385
1386         * symfile.c (reread_symbols): Remove old comment.
1387         * objfiles.c (free_all_objfiles): Fix a typo.
1388
1389 2019-04-10  Tom Tromey  <tom@tromey.com>
1390
1391         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1392         * minsyms.c (lookup_minimal_symbol): Use foreach.
1393         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1394         (lookup_minimal_symbol_solib_trampoline): Likewise.
1395         * symfile.c (reread_symbols): Use foreach.
1396
1397 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1398             Tom Tromey  <tromey@adacore.com>
1399
1400         PR rust/24414:
1401         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1402         (rust_lex_int_test): Change "value" to be LONGEST.
1403         (rust_lex_tests): Add test for long integer literal.
1404
1405 2019-04-09  Tom Tromey  <tromey@adacore.com>
1406
1407         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1408         to bool.
1409         (extended_remote_target::attach): Update.
1410         (remote_target::remote_notice_new_inferior): Update.
1411         (remote_target::add_current_inferior_and_thread): Update.
1412         * inferior.c (exit_inferior_1): Use "false".
1413         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1414
1415 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1416
1417         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1418         the "start" command.
1419
1420 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1421
1422         * python/py-inferior.c (infpy_thread_from_thread_handle):
1423         Adjust comments to reflect renaming of thread_from_thread_handle
1424         to thread_from_handle.  Adjust keywords.  Fix type error message.
1425         (inferior_object_methods): Add thread_from_handle.  Retain
1426         thread_from_thread_handle, but mark it as deprecated.
1427
1428 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1429
1430         * gdbthread.h (find_thread_by_handle): Revise declaration.
1431         * thread.c (find_thread_by_handle): Likewise.  Adjust
1432         implementation too.
1433         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1434         support for buffer objects as handles.
1435
1436 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1437
1438         * python/py-infthread.c (thpy_thread_handle): New function.
1439         (thread_object_methods): Register thpy_thread_handle.
1440
1441 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1442
1443         * gdbthread.h (thread_to_thread_handle): Declare.
1444         * thread.c (gdbtypes.h): Include.
1445         (thread_to_thread_handle): New function.
1446
1447         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1448         (target_thread_info_to_thread_handle): Declare.
1449         * target.c (target_thread_info_to_thread_handle): New function.
1450         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1451         * target-delegates.c: Regenerate.
1452
1453         * linux-thread-db.c (class thread_db_target): Add method
1454         thread_info_to_thread_handle.
1455         (thread_db_target::thread_info_to_thread_handle): Define.
1456         * remote.c (class remote_target): Add new method
1457         thread_info_to_thread_handle.
1458         (remote_target::thread_info_to_thread_handle): Define.
1459
1460 2019-04-08  Pedro Alves  <palves@redhat.com>
1461
1462         * common/common-exceptions.c (throw_exception): Don't create
1463         named object to throw; throw directly.
1464         (throw_it): Likewise.  Don't initialize gdb_exception::message
1465         here, with new; pass FMT and AP to the ctor instead.
1466         * common/common-exceptions.h: Include <string>.
1467         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1468         const char *, va_list)): New ctor.  Use std::make_shared.
1469         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1470         errors)): Delete.
1471         (gdb_exception_error::gdb_exception_error(enum errors, const char
1472         *, va_list)): New.
1473         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1474         Add assertion.
1475         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1476         errors)): Delete.
1477         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1478         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1479         Add assertion.
1480
1481 2019-04-08  Tom Tromey  <tom@tromey.com>
1482
1483         * valops.c (value_rtti_indirect_type): Replace throw_exception
1484         with throw.
1485         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1486         with throw.
1487         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1488         throw.
1489         * target.c (target_translate_tls_address): Replace throw_exception
1490         with throw.
1491         * stack.c (frame_apply_command_count): Replace throw_exception
1492         with throw.
1493         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1494         throw.
1495         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1496         with throw.
1497         * rs6000-tdep.c (rs6000_frame_cache)
1498         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1499         * remote.c: Replace throw_exception with throw.
1500         * record-full.c (record_full_message, record_full_wait_1)
1501         (record_full_restore): Replace throw_exception with throw.
1502         * record-btrace.c:
1503         (get_thread_current_frame_id, record_btrace_start_replaying)
1504         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1505         (cmd_record_btrace_start): Replace throw_exception with throw.
1506         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1507         throw.
1508         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1509         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1510         * linespec.c:
1511         (find_linespec_symbols): Replace throw_exception with throw.
1512         * infrun.c (displaced_step_prepare, resume): Replace
1513         throw_exception with throw.
1514         * infcmd.c (post_create_inferior): Replace throw_exception with
1515         throw.
1516         * inf-loop.c (inferior_event_handler): Replace throw_exception
1517         with throw.
1518         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1519         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1520         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1521         (get_prev_frame_always, get_frame_pc_if_available)
1522         (get_frame_address_in_block_if_available, get_frame_language):
1523         Replace throw_exception with throw.
1524         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1525         throw_exception with throw.
1526         * eval.c (fetch_subexp_value, evaluate_var_value)
1527         (evaluate_funcall, evaluate_subexp_standard): Replace
1528         throw_exception with throw.
1529         * dwarf2loc.c (call_site_find_chain)
1530         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1531         Replace throw_exception with throw.
1532         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1533         with throw.
1534         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1535         throw.
1536         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1537         * completer.c (complete_line_internal): Replace throw_exception
1538         with throw.
1539         * compile/compile-object-run.c (compile_object_run): Replace
1540         throw_exception with throw.
1541         * cli/cli-script.c (process_next_line): Replace throw_exception
1542         with throw.
1543         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1544         (btrace_enable, btrace_maint_update_pt_packets): Replace
1545         throw_exception with throw.
1546         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1547         throw_exception with throw.
1548         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1549         throw_exception with throw.
1550         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1551         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1552         * aarch64-tdep.c (aarch64_make_prologue_cache)
1553         (aarch64_make_stub_cache): Replace throw_exception with throw.
1554
1555 2019-04-08  Tom Tromey  <tom@tromey.com>
1556
1557         * common/common-exceptions.c (throw_exception): Rename from
1558         throw_exception_cxx.  Remove old copy.  Make argument const.
1559         (throw_it): Create and throw exception objects directly.
1560         * common/common-exceptions.h (throw_exception): Make argument
1561         const.
1562         (struct gdb_exception_error): Add constructor.
1563         (struct gdb_exception_quit): Add constructor.
1564
1565 2019-04-08  Tom Tromey  <tom@tromey.com>
1566
1567         * common/common-exceptions.h (exception_rethrow): Don't declare.
1568         (TRY_SJLJ): Update comment.
1569         (TRY, CATCH, END_CATCH): Remove.
1570         * common/common-exceptions.c (exception_rethrow): Remove.
1571
1572 2019-04-08  Tom Tromey  <tom@tromey.com>
1573
1574         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1575         Remove.
1576         (gdb_exception_error): Rename from
1577         gdb_exception_RETURN_MASK_ERROR.
1578         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1579         (gdb_quit_bad_alloc): Update.
1580         * aarch64-tdep.c: Update.
1581         * ada-lang.c: Update.
1582         * ada-typeprint.c: Update.
1583         * ada-valprint.c: Update.
1584         * amd64-tdep.c: Update.
1585         * arch-utils.c: Update.
1586         * break-catch-throw.c: Update.
1587         * breakpoint.c: Update.
1588         * btrace.c: Update.
1589         * c-varobj.c: Update.
1590         * cli/cli-cmds.c: Update.
1591         * cli/cli-interp.c: Update.
1592         * cli/cli-script.c: Update.
1593         * common/common-exceptions.c: Update.
1594         * common/new-op.c: Update.
1595         * common/selftest.c: Update.
1596         * compile/compile-c-symbols.c: Update.
1597         * compile/compile-cplus-symbols.c: Update.
1598         * compile/compile-object-load.c: Update.
1599         * compile/compile-object-run.c: Update.
1600         * completer.c: Update.
1601         * corelow.c: Update.
1602         * cp-abi.c: Update.
1603         * cp-support.c: Update.
1604         * cp-valprint.c: Update.
1605         * darwin-nat.c: Update.
1606         * disasm-selftests.c: Update.
1607         * dtrace-probe.c: Update.
1608         * dwarf-index-cache.c: Update.
1609         * dwarf-index-write.c: Update.
1610         * dwarf2-frame-tailcall.c: Update.
1611         * dwarf2-frame.c: Update.
1612         * dwarf2loc.c: Update.
1613         * dwarf2read.c: Update.
1614         * eval.c: Update.
1615         * event-loop.c: Update.
1616         * event-top.c: Update.
1617         * exec.c: Update.
1618         * f-valprint.c: Update.
1619         * fbsd-tdep.c: Update.
1620         * frame-unwind.c: Update.
1621         * frame.c: Update.
1622         * gdbtypes.c: Update.
1623         * gnu-v3-abi.c: Update.
1624         * guile/guile-internal.h: Update.
1625         * guile/scm-block.c: Update.
1626         * guile/scm-breakpoint.c: Update.
1627         * guile/scm-cmd.c: Update.
1628         * guile/scm-disasm.c: Update.
1629         * guile/scm-frame.c: Update.
1630         * guile/scm-lazy-string.c: Update.
1631         * guile/scm-math.c: Update.
1632         * guile/scm-param.c: Update.
1633         * guile/scm-ports.c: Update.
1634         * guile/scm-pretty-print.c: Update.
1635         * guile/scm-symbol.c: Update.
1636         * guile/scm-symtab.c: Update.
1637         * guile/scm-type.c: Update.
1638         * guile/scm-value.c: Update.
1639         * i386-linux-tdep.c: Update.
1640         * i386-tdep.c: Update.
1641         * inf-loop.c: Update.
1642         * infcall.c: Update.
1643         * infcmd.c: Update.
1644         * infrun.c: Update.
1645         * jit.c: Update.
1646         * language.c: Update.
1647         * linespec.c: Update.
1648         * linux-fork.c: Update.
1649         * linux-nat.c: Update.
1650         * linux-tdep.c: Update.
1651         * linux-thread-db.c: Update.
1652         * main.c: Update.
1653         * mi/mi-cmd-break.c: Update.
1654         * mi/mi-cmd-stack.c: Update.
1655         * mi/mi-interp.c: Update.
1656         * mi/mi-main.c: Update.
1657         * objc-lang.c: Update.
1658         * p-valprint.c: Update.
1659         * parse.c: Update.
1660         * ppc-linux-tdep.c: Update.
1661         * printcmd.c: Update.
1662         * python/py-arch.c: Update.
1663         * python/py-breakpoint.c: Update.
1664         * python/py-cmd.c: Update.
1665         * python/py-finishbreakpoint.c: Update.
1666         * python/py-frame.c: Update.
1667         * python/py-framefilter.c: Update.
1668         * python/py-gdb-readline.c: Update.
1669         * python/py-inferior.c: Update.
1670         * python/py-infthread.c: Update.
1671         * python/py-lazy-string.c: Update.
1672         * python/py-linetable.c: Update.
1673         * python/py-objfile.c: Update.
1674         * python/py-param.c: Update.
1675         * python/py-prettyprint.c: Update.
1676         * python/py-progspace.c: Update.
1677         * python/py-record-btrace.c: Update.
1678         * python/py-record.c: Update.
1679         * python/py-symbol.c: Update.
1680         * python/py-type.c: Update.
1681         * python/py-unwind.c: Update.
1682         * python/py-utils.c: Update.
1683         * python/py-value.c: Update.
1684         * python/python.c: Update.
1685         * record-btrace.c: Update.
1686         * record-full.c: Update.
1687         * remote-fileio.c: Update.
1688         * remote.c: Update.
1689         * riscv-tdep.c: Update.
1690         * rs6000-aix-tdep.c: Update.
1691         * rs6000-tdep.c: Update.
1692         * rust-exp.y: Update.
1693         * rust-lang.c: Update.
1694         * s390-tdep.c: Update.
1695         * selftest-arch.c: Update.
1696         * solib-dsbt.c: Update.
1697         * solib-frv.c: Update.
1698         * solib-spu.c: Update.
1699         * solib-svr4.c: Update.
1700         * solib.c: Update.
1701         * sparc64-linux-tdep.c: Update.
1702         * stack.c: Update.
1703         * symfile-mem.c: Update.
1704         * symmisc.c: Update.
1705         * target.c: Update.
1706         * thread.c: Update.
1707         * top.c: Update.
1708         * tracefile-tfile.c: Update.
1709         * tui/tui.c: Update.
1710         * typeprint.c: Update.
1711         * unittests/cli-utils-selftests.c: Update.
1712         * unittests/parse-connection-spec-selftests.c: Update.
1713         * valops.c: Update.
1714         * valprint.c: Update.
1715         * value.c: Update.
1716         * varobj.c: Update.
1717         * windows-nat.c: Update.
1718         * x86-linux-nat.c: Update.
1719         * xml-support.c: Update.
1720
1721 2019-04-08  Tom Tromey  <tom@tromey.com>
1722
1723         * xml-support.c: Use C++ exception handling.
1724         * x86-linux-nat.c: Use C++ exception handling.
1725         * windows-nat.c: Use C++ exception handling.
1726         * varobj.c: Use C++ exception handling.
1727         * value.c: Use C++ exception handling.
1728         * valprint.c: Use C++ exception handling.
1729         * valops.c: Use C++ exception handling.
1730         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1731         handling.
1732         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1733         * typeprint.c: Use C++ exception handling.
1734         * tui/tui.c: Use C++ exception handling.
1735         * tracefile-tfile.c: Use C++ exception handling.
1736         * top.c: Use C++ exception handling.
1737         * thread.c: Use C++ exception handling.
1738         * target.c: Use C++ exception handling.
1739         * symmisc.c: Use C++ exception handling.
1740         * symfile-mem.c: Use C++ exception handling.
1741         * stack.c: Use C++ exception handling.
1742         * sparc64-linux-tdep.c: Use C++ exception handling.
1743         * solib.c: Use C++ exception handling.
1744         * solib-svr4.c: Use C++ exception handling.
1745         * solib-spu.c: Use C++ exception handling.
1746         * solib-frv.c: Use C++ exception handling.
1747         * solib-dsbt.c: Use C++ exception handling.
1748         * selftest-arch.c: Use C++ exception handling.
1749         * s390-tdep.c: Use C++ exception handling.
1750         * rust-lang.c: Use C++ exception handling.
1751         * rust-exp.y: Use C++ exception handling.
1752         * rs6000-tdep.c: Use C++ exception handling.
1753         * rs6000-aix-tdep.c: Use C++ exception handling.
1754         * riscv-tdep.c: Use C++ exception handling.
1755         * remote.c: Use C++ exception handling.
1756         * remote-fileio.c: Use C++ exception handling.
1757         * record-full.c: Use C++ exception handling.
1758         * record-btrace.c: Use C++ exception handling.
1759         * python/python.c: Use C++ exception handling.
1760         * python/py-value.c: Use C++ exception handling.
1761         * python/py-utils.c: Use C++ exception handling.
1762         * python/py-unwind.c: Use C++ exception handling.
1763         * python/py-type.c: Use C++ exception handling.
1764         * python/py-symbol.c: Use C++ exception handling.
1765         * python/py-record.c: Use C++ exception handling.
1766         * python/py-record-btrace.c: Use C++ exception handling.
1767         * python/py-progspace.c: Use C++ exception handling.
1768         * python/py-prettyprint.c: Use C++ exception handling.
1769         * python/py-param.c: Use C++ exception handling.
1770         * python/py-objfile.c: Use C++ exception handling.
1771         * python/py-linetable.c: Use C++ exception handling.
1772         * python/py-lazy-string.c: Use C++ exception handling.
1773         * python/py-infthread.c: Use C++ exception handling.
1774         * python/py-inferior.c: Use C++ exception handling.
1775         * python/py-gdb-readline.c: Use C++ exception handling.
1776         * python/py-framefilter.c: Use C++ exception handling.
1777         * python/py-frame.c: Use C++ exception handling.
1778         * python/py-finishbreakpoint.c: Use C++ exception handling.
1779         * python/py-cmd.c: Use C++ exception handling.
1780         * python/py-breakpoint.c: Use C++ exception handling.
1781         * python/py-arch.c: Use C++ exception handling.
1782         * printcmd.c: Use C++ exception handling.
1783         * ppc-linux-tdep.c: Use C++ exception handling.
1784         * parse.c: Use C++ exception handling.
1785         * p-valprint.c: Use C++ exception handling.
1786         * objc-lang.c: Use C++ exception handling.
1787         * mi/mi-main.c: Use C++ exception handling.
1788         * mi/mi-interp.c: Use C++ exception handling.
1789         * mi/mi-cmd-stack.c: Use C++ exception handling.
1790         * mi/mi-cmd-break.c: Use C++ exception handling.
1791         * main.c: Use C++ exception handling.
1792         * linux-thread-db.c: Use C++ exception handling.
1793         * linux-tdep.c: Use C++ exception handling.
1794         * linux-nat.c: Use C++ exception handling.
1795         * linux-fork.c: Use C++ exception handling.
1796         * linespec.c: Use C++ exception handling.
1797         * language.c: Use C++ exception handling.
1798         * jit.c: Use C++ exception handling.
1799         * infrun.c: Use C++ exception handling.
1800         * infcmd.c: Use C++ exception handling.
1801         * infcall.c: Use C++ exception handling.
1802         * inf-loop.c: Use C++ exception handling.
1803         * i386-tdep.c: Use C++ exception handling.
1804         * i386-linux-tdep.c: Use C++ exception handling.
1805         * guile/scm-value.c: Use C++ exception handling.
1806         * guile/scm-type.c: Use C++ exception handling.
1807         * guile/scm-symtab.c: Use C++ exception handling.
1808         * guile/scm-symbol.c: Use C++ exception handling.
1809         * guile/scm-pretty-print.c: Use C++ exception handling.
1810         * guile/scm-ports.c: Use C++ exception handling.
1811         * guile/scm-param.c: Use C++ exception handling.
1812         * guile/scm-math.c: Use C++ exception handling.
1813         * guile/scm-lazy-string.c: Use C++ exception handling.
1814         * guile/scm-frame.c: Use C++ exception handling.
1815         * guile/scm-disasm.c: Use C++ exception handling.
1816         * guile/scm-cmd.c: Use C++ exception handling.
1817         * guile/scm-breakpoint.c: Use C++ exception handling.
1818         * guile/scm-block.c: Use C++ exception handling.
1819         * guile/guile-internal.h: Use C++ exception handling.
1820         * gnu-v3-abi.c: Use C++ exception handling.
1821         * gdbtypes.c: Use C++ exception handling.
1822         * frame.c: Use C++ exception handling.
1823         * frame-unwind.c: Use C++ exception handling.
1824         * fbsd-tdep.c: Use C++ exception handling.
1825         * f-valprint.c: Use C++ exception handling.
1826         * exec.c: Use C++ exception handling.
1827         * event-top.c: Use C++ exception handling.
1828         * event-loop.c: Use C++ exception handling.
1829         * eval.c: Use C++ exception handling.
1830         * dwarf2read.c: Use C++ exception handling.
1831         * dwarf2loc.c: Use C++ exception handling.
1832         * dwarf2-frame.c: Use C++ exception handling.
1833         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1834         * dwarf-index-write.c: Use C++ exception handling.
1835         * dwarf-index-cache.c: Use C++ exception handling.
1836         * dtrace-probe.c: Use C++ exception handling.
1837         * disasm-selftests.c: Use C++ exception handling.
1838         * darwin-nat.c: Use C++ exception handling.
1839         * cp-valprint.c: Use C++ exception handling.
1840         * cp-support.c: Use C++ exception handling.
1841         * cp-abi.c: Use C++ exception handling.
1842         * corelow.c: Use C++ exception handling.
1843         * completer.c: Use C++ exception handling.
1844         * compile/compile-object-run.c: Use C++ exception handling.
1845         * compile/compile-object-load.c: Use C++ exception handling.
1846         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1847         * compile/compile-c-symbols.c: Use C++ exception handling.
1848         * common/selftest.c: Use C++ exception handling.
1849         * common/new-op.c: Use C++ exception handling.
1850         * cli/cli-script.c: Use C++ exception handling.
1851         * cli/cli-interp.c: Use C++ exception handling.
1852         * cli/cli-cmds.c: Use C++ exception handling.
1853         * c-varobj.c: Use C++ exception handling.
1854         * btrace.c: Use C++ exception handling.
1855         * breakpoint.c: Use C++ exception handling.
1856         * break-catch-throw.c: Use C++ exception handling.
1857         * arch-utils.c: Use C++ exception handling.
1858         * amd64-tdep.c: Use C++ exception handling.
1859         * ada-valprint.c: Use C++ exception handling.
1860         * ada-typeprint.c: Use C++ exception handling.
1861         * ada-lang.c: Use C++ exception handling.
1862         * aarch64-tdep.c: Use C++ exception handling.
1863
1864 2019-04-08  Tom Tromey  <tom@tromey.com>
1865
1866         * xml-support.c (gdb_xml_parser::parse): Update.
1867         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1868         * value.c (show_convenience): Update.
1869         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1870         (test_parse_flags_qcs): Update.
1871         * thread.c (thr_try_catch_cmd): Update.
1872         * target.c (target_translate_tls_address): Update.
1873         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1874         (info_frame_command_core, frame_apply_command_count): Update.
1875         * rust-exp.y (rust_lex_exception_test): Update.
1876         * riscv-tdep.c (riscv_print_one_register_info): Update.
1877         * remote.c (remote_target::enable_btrace): Update.
1878         * record-btrace.c (record_btrace_enable_warn): Update.
1879         * python/py-utils.c (gdbpy_convert_exception): Update.
1880         * printcmd.c (do_one_display, print_variable_and_value): Update.
1881         * mi/mi-main.c (mi_print_exception): Update.
1882         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1883         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1884         * linux-nat.c (linux_nat_target::attach): Update.
1885         * linux-fork.c (class scoped_switch_fork_info): Update.
1886         * infrun.c (displaced_step_prepare): Update.
1887         * infcall.c (call_function_by_hand_dummy): Update.
1888         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1889         * gnu-v3-abi.c (print_one_vtable): Update.
1890         * frame.c (get_prev_frame_always): Update.
1891         * f-valprint.c (info_common_command_for_block): Update.
1892         * exec.c (try_open_exec_file): Update.
1893         * exceptions.c (print_exception, exception_print)
1894         (exception_fprintf, exception_print_same): Update.
1895         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1896         * dwarf-index-cache.c (index_cache::store)
1897         (index_cache::lookup_gdb_index): Update.
1898         * darwin-nat.c (maybe_cache_shell): Update.
1899         * cp-valprint.c (cp_print_value_fields): Update.
1900         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1901         (gcc_cplus_symbol_address): Update.
1902         * compile/compile-c-symbols.c (gcc_convert_symbol)
1903         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1904         * common/selftest.c: Update.
1905         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1906         a std::string.
1907         (exception_try_scope_entry, exception_try_scope_exit): Don't
1908         declare.
1909         (struct exception_try_scope): Remove.
1910         (TRY): Don't use exception_try_scope.
1911         (struct gdb_exception): Add constructor, operator=.
1912         <what>: New method.
1913         (struct gdb_exception_RETURN_MASK_ALL)
1914         (struct gdb_exception_RETURN_MASK_ERROR)
1915         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1916         (struct gdb_quit_bad_alloc): Update.
1917         * common/common-exceptions.c (exception_none): Change
1918         initializer.
1919         (struct catcher) <state, exception>: Initialize inline.
1920         <prev>: Remove member.
1921         (current_catcher): Remove.
1922         (catchers): New global.
1923         (exceptions_state_mc_init): Simplify.
1924         (catcher_pop): Remove.
1925         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1926         (try_scope_depth, exception_try_scope_entry)
1927         (exception_try_scope_exit): Remove.
1928         (throw_exception_sjlj): Update.
1929         (exception_messages, exception_messages_size): Remove.
1930         (throw_it): Simplify.
1931         (gdb_exception_sliced_copy): Remove.
1932         (throw_exception_cxx): Update.
1933         * cli/cli-script.c (script_from_file): Update.
1934         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1935         Update.
1936         * ada-valprint.c (ada_val_print): Update.
1937         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1938         (create_excep_cond_exprs): Update.
1939
1940 2019-04-08  Tom Tromey  <tom@tromey.com>
1941
1942         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1943         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1944         (TRY, CATCH, END_CATCH): Remove some definitions.
1945         * common/common-exceptions.c: Don't use GDB_XCPT.
1946         (catcher_list_size): Remove.
1947         (throw_exception, throw_it): Simplify.
1948
1949 2019-04-05  Tom Tromey  <tom@tromey.com>
1950
1951         Revert the header-sorting patch.
1952         * ft32-tdep.c: Revert.
1953         * frv-tdep.c: Revert.
1954         * frv-linux-tdep.c: Revert.
1955         * frame.c: Revert.
1956         * frame-unwind.c: Revert.
1957         * frame-base.c: Revert.
1958         * fork-child.c: Revert.
1959         * findvar.c: Revert.
1960         * findcmd.c: Revert.
1961         * filesystem.c: Revert.
1962         * filename-seen-cache.h: Revert.
1963         * filename-seen-cache.c: Revert.
1964         * fbsd-tdep.c: Revert.
1965         * fbsd-nat.h: Revert.
1966         * fbsd-nat.c: Revert.
1967         * f-valprint.c: Revert.
1968         * f-typeprint.c: Revert.
1969         * f-lang.c: Revert.
1970         * extension.h: Revert.
1971         * extension.c: Revert.
1972         * extension-priv.h: Revert.
1973         * expprint.c: Revert.
1974         * exec.h: Revert.
1975         * exec.c: Revert.
1976         * exceptions.c: Revert.
1977         * event-top.c: Revert.
1978         * event-loop.c: Revert.
1979         * eval.c: Revert.
1980         * elfread.c: Revert.
1981         * dwarf2read.h: Revert.
1982         * dwarf2read.c: Revert.
1983         * dwarf2loc.c: Revert.
1984         * dwarf2expr.h: Revert.
1985         * dwarf2expr.c: Revert.
1986         * dwarf2-frame.c: Revert.
1987         * dwarf2-frame-tailcall.c: Revert.
1988         * dwarf-index-write.h: Revert.
1989         * dwarf-index-write.c: Revert.
1990         * dwarf-index-common.c: Revert.
1991         * dwarf-index-cache.h: Revert.
1992         * dwarf-index-cache.c: Revert.
1993         * dummy-frame.c: Revert.
1994         * dtrace-probe.c: Revert.
1995         * disasm.h: Revert.
1996         * disasm.c: Revert.
1997         * disasm-selftests.c: Revert.
1998         * dictionary.c: Revert.
1999         * dicos-tdep.c: Revert.
2000         * demangle.c: Revert.
2001         * dcache.h: Revert.
2002         * dcache.c: Revert.
2003         * darwin-nat.h: Revert.
2004         * darwin-nat.c: Revert.
2005         * darwin-nat-info.c: Revert.
2006         * d-valprint.c: Revert.
2007         * d-namespace.c: Revert.
2008         * d-lang.c: Revert.
2009         * ctf.c: Revert.
2010         * csky-tdep.c: Revert.
2011         * csky-linux-tdep.c: Revert.
2012         * cris-tdep.c: Revert.
2013         * cris-linux-tdep.c: Revert.
2014         * cp-valprint.c: Revert.
2015         * cp-support.c: Revert.
2016         * cp-namespace.c: Revert.
2017         * cp-abi.c: Revert.
2018         * corelow.c: Revert.
2019         * corefile.c: Revert.
2020         * continuations.c: Revert.
2021         * completer.h: Revert.
2022         * completer.c: Revert.
2023         * complaints.c: Revert.
2024         * coffread.c: Revert.
2025         * coff-pe-read.c: Revert.
2026         * cli-out.h: Revert.
2027         * cli-out.c: Revert.
2028         * charset.c: Revert.
2029         * c-varobj.c: Revert.
2030         * c-valprint.c: Revert.
2031         * c-typeprint.c: Revert.
2032         * c-lang.c: Revert.
2033         * buildsym.c: Revert.
2034         * buildsym-legacy.c: Revert.
2035         * build-id.h: Revert.
2036         * build-id.c: Revert.
2037         * btrace.c: Revert.
2038         * bsd-uthread.c: Revert.
2039         * breakpoint.h: Revert.
2040         * breakpoint.c: Revert.
2041         * break-catch-throw.c: Revert.
2042         * break-catch-syscall.c: Revert.
2043         * break-catch-sig.c: Revert.
2044         * blockframe.c: Revert.
2045         * block.c: Revert.
2046         * bfin-tdep.c: Revert.
2047         * bfin-linux-tdep.c: Revert.
2048         * bfd-target.c: Revert.
2049         * bcache.c: Revert.
2050         * ax-general.c: Revert.
2051         * ax-gdb.h: Revert.
2052         * ax-gdb.c: Revert.
2053         * avr-tdep.c: Revert.
2054         * auxv.c: Revert.
2055         * auto-load.c: Revert.
2056         * arm-wince-tdep.c: Revert.
2057         * arm-tdep.c: Revert.
2058         * arm-symbian-tdep.c: Revert.
2059         * arm-pikeos-tdep.c: Revert.
2060         * arm-obsd-tdep.c: Revert.
2061         * arm-nbsd-tdep.c: Revert.
2062         * arm-nbsd-nat.c: Revert.
2063         * arm-linux-tdep.c: Revert.
2064         * arm-linux-nat.c: Revert.
2065         * arm-fbsd-tdep.c: Revert.
2066         * arm-fbsd-nat.c: Revert.
2067         * arm-bsd-tdep.c: Revert.
2068         * arch-utils.c: Revert.
2069         * arc-tdep.c: Revert.
2070         * arc-newlib-tdep.c: Revert.
2071         * annotate.h: Revert.
2072         * annotate.c: Revert.
2073         * amd64-windows-tdep.c: Revert.
2074         * amd64-windows-nat.c: Revert.
2075         * amd64-tdep.c: Revert.
2076         * amd64-sol2-tdep.c: Revert.
2077         * amd64-obsd-tdep.c: Revert.
2078         * amd64-obsd-nat.c: Revert.
2079         * amd64-nbsd-tdep.c: Revert.
2080         * amd64-nbsd-nat.c: Revert.
2081         * amd64-nat.c: Revert.
2082         * amd64-linux-tdep.c: Revert.
2083         * amd64-linux-nat.c: Revert.
2084         * amd64-fbsd-tdep.c: Revert.
2085         * amd64-fbsd-nat.c: Revert.
2086         * amd64-dicos-tdep.c: Revert.
2087         * amd64-darwin-tdep.c: Revert.
2088         * amd64-bsd-nat.c: Revert.
2089         * alpha-tdep.c: Revert.
2090         * alpha-obsd-tdep.c: Revert.
2091         * alpha-nbsd-tdep.c: Revert.
2092         * alpha-mdebug-tdep.c: Revert.
2093         * alpha-linux-tdep.c: Revert.
2094         * alpha-linux-nat.c: Revert.
2095         * alpha-bsd-tdep.c: Revert.
2096         * alpha-bsd-nat.c: Revert.
2097         * aix-thread.c: Revert.
2098         * agent.c: Revert.
2099         * addrmap.c: Revert.
2100         * ada-varobj.c: Revert.
2101         * ada-valprint.c: Revert.
2102         * ada-typeprint.c: Revert.
2103         * ada-tasks.c: Revert.
2104         * ada-lang.c: Revert.
2105         * aarch64-tdep.c: Revert.
2106         * aarch64-ravenscar-thread.c: Revert.
2107         * aarch64-newlib-tdep.c: Revert.
2108         * aarch64-linux-tdep.c: Revert.
2109         * aarch64-linux-nat.c: Revert.
2110         * aarch64-fbsd-tdep.c: Revert.
2111         * aarch64-fbsd-nat.c: Revert.
2112         * aarch32-linux-nat.c: Revert.
2113
2114 2019-04-05  Tom Tromey  <tom@tromey.com>
2115
2116         * ft32-tdep.c: Sort headers.
2117         * frv-tdep.c: Sort headers.
2118         * frv-linux-tdep.c: Sort headers.
2119         * frame.c: Sort headers.
2120         * frame-unwind.c: Sort headers.
2121         * frame-base.c: Sort headers.
2122         * fork-child.c: Sort headers.
2123         * findvar.c: Sort headers.
2124         * findcmd.c: Sort headers.
2125         * filesystem.c: Sort headers.
2126         * filename-seen-cache.h: Sort headers.
2127         * filename-seen-cache.c: Sort headers.
2128         * fbsd-tdep.c: Sort headers.
2129         * fbsd-nat.h: Sort headers.
2130         * fbsd-nat.c: Sort headers.
2131         * f-valprint.c: Sort headers.
2132         * f-typeprint.c: Sort headers.
2133         * f-lang.c: Sort headers.
2134         * extension.h: Sort headers.
2135         * extension.c: Sort headers.
2136         * extension-priv.h: Sort headers.
2137         * expprint.c: Sort headers.
2138         * exec.h: Sort headers.
2139         * exec.c: Sort headers.
2140         * exceptions.c: Sort headers.
2141         * event-top.c: Sort headers.
2142         * event-loop.c: Sort headers.
2143         * eval.c: Sort headers.
2144         * elfread.c: Sort headers.
2145         * dwarf2read.h: Sort headers.
2146         * dwarf2read.c: Sort headers.
2147         * dwarf2loc.c: Sort headers.
2148         * dwarf2expr.h: Sort headers.
2149         * dwarf2expr.c: Sort headers.
2150         * dwarf2-frame.c: Sort headers.
2151         * dwarf2-frame-tailcall.c: Sort headers.
2152         * dwarf-index-write.h: Sort headers.
2153         * dwarf-index-write.c: Sort headers.
2154         * dwarf-index-common.c: Sort headers.
2155         * dwarf-index-cache.h: Sort headers.
2156         * dwarf-index-cache.c: Sort headers.
2157         * dummy-frame.c: Sort headers.
2158         * dtrace-probe.c: Sort headers.
2159         * disasm.h: Sort headers.
2160         * disasm.c: Sort headers.
2161         * disasm-selftests.c: Sort headers.
2162         * dictionary.c: Sort headers.
2163         * dicos-tdep.c: Sort headers.
2164         * demangle.c: Sort headers.
2165         * dcache.h: Sort headers.
2166         * dcache.c: Sort headers.
2167         * darwin-nat.h: Sort headers.
2168         * darwin-nat.c: Sort headers.
2169         * darwin-nat-info.c: Sort headers.
2170         * d-valprint.c: Sort headers.
2171         * d-namespace.c: Sort headers.
2172         * d-lang.c: Sort headers.
2173         * ctf.c: Sort headers.
2174         * csky-tdep.c: Sort headers.
2175         * csky-linux-tdep.c: Sort headers.
2176         * cris-tdep.c: Sort headers.
2177         * cris-linux-tdep.c: Sort headers.
2178         * cp-valprint.c: Sort headers.
2179         * cp-support.c: Sort headers.
2180         * cp-namespace.c: Sort headers.
2181         * cp-abi.c: Sort headers.
2182         * corelow.c: Sort headers.
2183         * corefile.c: Sort headers.
2184         * continuations.c: Sort headers.
2185         * completer.h: Sort headers.
2186         * completer.c: Sort headers.
2187         * complaints.c: Sort headers.
2188         * coffread.c: Sort headers.
2189         * coff-pe-read.c: Sort headers.
2190         * cli-out.h: Sort headers.
2191         * cli-out.c: Sort headers.
2192         * charset.c: Sort headers.
2193         * c-varobj.c: Sort headers.
2194         * c-valprint.c: Sort headers.
2195         * c-typeprint.c: Sort headers.
2196         * c-lang.c: Sort headers.
2197         * buildsym.c: Sort headers.
2198         * buildsym-legacy.c: Sort headers.
2199         * build-id.h: Sort headers.
2200         * build-id.c: Sort headers.
2201         * btrace.c: Sort headers.
2202         * bsd-uthread.c: Sort headers.
2203         * breakpoint.h: Sort headers.
2204         * breakpoint.c: Sort headers.
2205         * break-catch-throw.c: Sort headers.
2206         * break-catch-syscall.c: Sort headers.
2207         * break-catch-sig.c: Sort headers.
2208         * blockframe.c: Sort headers.
2209         * block.c: Sort headers.
2210         * bfin-tdep.c: Sort headers.
2211         * bfin-linux-tdep.c: Sort headers.
2212         * bfd-target.c: Sort headers.
2213         * bcache.c: Sort headers.
2214         * ax-general.c: Sort headers.
2215         * ax-gdb.h: Sort headers.
2216         * ax-gdb.c: Sort headers.
2217         * avr-tdep.c: Sort headers.
2218         * auxv.c: Sort headers.
2219         * auto-load.c: Sort headers.
2220         * arm-wince-tdep.c: Sort headers.
2221         * arm-tdep.c: Sort headers.
2222         * arm-symbian-tdep.c: Sort headers.
2223         * arm-pikeos-tdep.c: Sort headers.
2224         * arm-obsd-tdep.c: Sort headers.
2225         * arm-nbsd-tdep.c: Sort headers.
2226         * arm-nbsd-nat.c: Sort headers.
2227         * arm-linux-tdep.c: Sort headers.
2228         * arm-linux-nat.c: Sort headers.
2229         * arm-fbsd-tdep.c: Sort headers.
2230         * arm-fbsd-nat.c: Sort headers.
2231         * arm-bsd-tdep.c: Sort headers.
2232         * arch-utils.c: Sort headers.
2233         * arc-tdep.c: Sort headers.
2234         * arc-newlib-tdep.c: Sort headers.
2235         * annotate.h: Sort headers.
2236         * annotate.c: Sort headers.
2237         * amd64-windows-tdep.c: Sort headers.
2238         * amd64-windows-nat.c: Sort headers.
2239         * amd64-tdep.c: Sort headers.
2240         * amd64-sol2-tdep.c: Sort headers.
2241         * amd64-obsd-tdep.c: Sort headers.
2242         * amd64-obsd-nat.c: Sort headers.
2243         * amd64-nbsd-tdep.c: Sort headers.
2244         * amd64-nbsd-nat.c: Sort headers.
2245         * amd64-nat.c: Sort headers.
2246         * amd64-linux-tdep.c: Sort headers.
2247         * amd64-linux-nat.c: Sort headers.
2248         * amd64-fbsd-tdep.c: Sort headers.
2249         * amd64-fbsd-nat.c: Sort headers.
2250         * amd64-dicos-tdep.c: Sort headers.
2251         * amd64-darwin-tdep.c: Sort headers.
2252         * amd64-bsd-nat.c: Sort headers.
2253         * alpha-tdep.c: Sort headers.
2254         * alpha-obsd-tdep.c: Sort headers.
2255         * alpha-nbsd-tdep.c: Sort headers.
2256         * alpha-mdebug-tdep.c: Sort headers.
2257         * alpha-linux-tdep.c: Sort headers.
2258         * alpha-linux-nat.c: Sort headers.
2259         * alpha-bsd-tdep.c: Sort headers.
2260         * alpha-bsd-nat.c: Sort headers.
2261         * aix-thread.c: Sort headers.
2262         * agent.c: Sort headers.
2263         * addrmap.c: Sort headers.
2264         * ada-varobj.c: Sort headers.
2265         * ada-valprint.c: Sort headers.
2266         * ada-typeprint.c: Sort headers.
2267         * ada-tasks.c: Sort headers.
2268         * ada-lang.c: Sort headers.
2269         * aarch64-tdep.c: Sort headers.
2270         * aarch64-ravenscar-thread.c: Sort headers.
2271         * aarch64-newlib-tdep.c: Sort headers.
2272         * aarch64-linux-tdep.c: Sort headers.
2273         * aarch64-linux-nat.c: Sort headers.
2274         * aarch64-fbsd-tdep.c: Sort headers.
2275         * aarch64-fbsd-nat.c: Sort headers.
2276         * aarch32-linux-nat.c: Sort headers.
2277
2278 2019-04-04  Tom Tromey  <tom@tromey.com>
2279
2280         * varobj.c (varobj_create): Update.
2281         * rust-exp.y (struct rust_parser) <update_innermost_block,
2282         lookup_symbol>: New methods.
2283         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2284         Rename.
2285         (rust_parser::rust_lookup_type)
2286         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2287         * printcmd.c (display_command, do_one_display): Update.
2288         * parser-defs.h (struct parser_state) <parser_state>: Add
2289         "tracker" parameter.
2290         (block_tracker): New member.
2291         (class innermost_block_tracker) <innermost_block_tracker>: Add
2292         "types" parameter.
2293         <reset>: Remove method.
2294         (innermost_block): Don't declare.
2295         (null_post_parser): Update.
2296         * parse.c (innermost_block): Remove global.
2297         (write_dollar_variable): Update.
2298         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2299         Remove "tracker_types" parameter.
2300         (parse_expression): Add "tracker" parameter.
2301         (parse_expression_for_completion): Update.
2302         (null_post_parser): Add "tracker" parameter.
2303         * p-exp.y: Update rules.
2304         * m2-exp.y: Update rules.
2305         * language.h (struct language_defn) <la_post_parser>: Add
2306         "tracker" parameter.
2307         * go-exp.y: Update rules.
2308         * f-exp.y: Update rules.
2309         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2310         parameter.
2311         * d-exp.y: Update rules.
2312         * c-exp.y: Update rules.
2313         * breakpoint.c (set_breakpoint_condition): Create an
2314         innermost_block_tracker.
2315         (watch_command_1): Likewise.
2316         * ada-lang.c (resolve): Add "tracker" parameter.
2317         (resolve_subexp): Likewise.
2318         * ada-exp.y (write_var_from_sym): Update.
2319
2320 2019-04-04  Tom Tromey  <tom@tromey.com>
2321
2322         * type-stack.h: New file.
2323         * type-stack.c: New file.
2324         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2325         type-stack.h.
2326         (insert_into_type_stack, insert_type, push_type, push_type_int)
2327         (insert_type_address_space, pop_type, pop_type_int)
2328         (pop_typelist, pop_type_stack, append_type_stack)
2329         (push_type_stack, get_type_stack, push_typelist)
2330         (follow_type_instance_flags, follow_types): Don't declare.
2331         * parse.c (type_stack): Remove global.
2332         (parse_exp_in_context): Update.
2333         (insert_into_type_stack, insert_type, push_type, push_type_int)
2334         (insert_type_address_space, pop_type, pop_type_int)
2335         (pop_typelist, pop_type_stack, append_type_stack)
2336         (push_type_stack, get_type_stack, push_typelist)
2337         (follow_type_instance_flags, follow_types): Remove (moved to
2338         type-stack.c).
2339         * f-exp.y (type_stack): New global.
2340         Update rules.
2341         (push_kind_type, f_parse): Update.
2342         * d-exp.y (type_stack): New global.
2343         Update rules.
2344         (d_parse): Update.
2345         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2346         Update rules.
2347         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2348         (HFILES_NO_SRCDIR): Add type-stack.h.
2349
2350 2019-04-04  Tom Tromey  <tom@tromey.com>
2351
2352         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2353         (rust_parser::convert_ast_to_expression, rust_parse)
2354         (rust_lex_test_completion, rust_lex_tests): Update.
2355         * parser-defs.h (struct expr_completion_state): New.
2356         (struct parser_state) <parser_state>: Add completion parameter.
2357         <mark_struct_expression, mark_completion_tag>: New methods.
2358         <parse_completion, m_completion_state>: New members.
2359         (prefixify_expression, null_post_parser): Update.
2360         (mark_struct_expression, mark_completion_tag): Don't declare.
2361         * parse.c (parse_completion, expout_last_struct)
2362         (expout_tag_completion_type, expout_completion_name): Remove
2363         globals.
2364         (parser_state::mark_struct_expression)
2365         (parser_state::mark_completion_tag): Now methods.
2366         (prefixify_expression): Add last_struct parameter.
2367         (prefixify_subexp): Likewise.
2368         (parse_exp_1): Update.
2369         (parse_exp_in_context): Add cstate parameter.  Update.
2370         (parse_expression_for_completion): Create an
2371         expr_completion_state.
2372         (null_post_parser): Add "completion" parameter.
2373         * p-exp.y: Update rules.
2374         (yylex): Update.
2375         * language.h (struct language_defn) <la_post_parser>: Add
2376         "completing" parameter.
2377         * go-exp.y: Update rules.
2378         (lex_one_token): Update.
2379         * expression.h (parse_completion): Don't declare.
2380         * d-exp.y: Update rules.
2381         (lex_one_token): Update rules.
2382         * c-exp.y: Update rules.
2383         (lex_one_token): Update.
2384         * ada-lang.c (resolve): Add "parse_completion" parameter.
2385         (resolve_subexp): Likewise.
2386         (ada_resolve_function): Likewise.
2387
2388 2019-04-04  Tom Tromey  <tom@tromey.com>
2389
2390         * parser-defs.h (struct parser_state) <start_arglist,
2391         end_arglist>: New methods.
2392         <arglist_len, m_funcall_chain>: New members.
2393         (arglist_len, start_arglist, end_arglist): Don't declare.
2394         * parse.c (arglist_len, funcall_chain): Remove global.
2395         (start_arglist, end_arglist): Remove functions.
2396         (parse_exp_in_context): Update.
2397         * p-exp.y: Update rules.
2398         * m2-exp.y: Update rules.
2399         * go-exp.y: Update rules.
2400         * f-exp.y: Update rules.
2401         * d-exp.y: Update rules.
2402         * c-exp.y: Update rules.
2403
2404 2019-04-04  Tom Tromey  <tom@tromey.com>
2405
2406         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2407         lex_operator, push_back>: New methods.
2408         Update all rules.
2409         (rust_parser::lex_hex, lex_escape): Rename and update.
2410         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2411         (rust_parser::lex_operator): Rename and update.
2412         (rust_parser::lex_number, rustyylex, rustyyerror)
2413         (rust_lex_test_init, rust_lex_test_sequence)
2414         (rust_lex_test_push_back, rust_lex_tests): Update.
2415         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2416         parameter.
2417         <lexptr, prev_lexptr>: New members.
2418         (lexptr, prev_lexptr): Don't declare.
2419         * parse.c (lexptr, prev_lexptr): Remove globals.
2420         (parse_exp_in_context): Update.
2421         * p-exp.y (yylex, yyerror): Update.
2422         * m2-exp.y (parse_number, yylex, yyerror): Update.
2423         * go-exp.y (lex_one_token, yyerror): Update.
2424         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2425         * d-exp.y (lex_one_token, yyerror): Update.
2426         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2427         (lex_one_token, yyerror): Update.
2428         * ada-lex.l (YY_INPUT): Update.
2429         (rewind_to_char): Update.
2430         * ada-exp.y (yyerror): Update.
2431
2432 2019-04-04  Tom Tromey  <tom@tromey.com>
2433
2434         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2435         * parser-defs.h (struct parser_state) <parser_state>: Add new
2436         parameter.
2437         <comma_terminates>: New member.
2438         (comma_terminates): Don't declare global.
2439         * parse.c (comma_terminates): Remove global.
2440         (parse_exp_in_context): Update.
2441         * p-exp.y (yylex): Update.
2442         * m2-exp.y (yylex): Update.
2443         * go-exp.y (lex_one_token): Update.
2444         * f-exp.y (yylex): Update.
2445         * d-exp.y (lex_one_token): Update.
2446         * c-exp.y (lex_one_token): Update.
2447         * ada-lex.l: Update.
2448
2449 2019-04-04  Tom Tromey  <tom@tromey.com>
2450
2451         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2452         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2453         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2454         * parser-defs.h (paren_depth): Don't declare.
2455         * parse.c (paren_depth): Remove global.
2456         (parse_exp_in_context): Update.
2457         * p-exp.y (paren_depth): New global.
2458         (pascal_parse): Initialize it.
2459         * m2-exp.y (paren_depth): New global.
2460         (m2_parse): Initialize it.
2461         * go-exp.y (paren_depth): New global.
2462         (go_parse): Initialize it.
2463         * f-exp.y (paren_depth): New global.
2464         (f_parse): Initialize it.
2465         * d-exp.y (paren_depth): New global.
2466         (d_parse): Initialize it.
2467         * c-exp.y (paren_depth): New global.
2468         (c_parse): Initialize it.
2469         * ada-lex.l (paren_depth): New global.
2470         (lexer_init): Initialize it.
2471
2472 2019-04-04  Tom Tromey  <tom@tromey.com>
2473
2474         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2475         (rust_parser::convert_ast_to_type)
2476         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2477         * parser-defs.h (struct parser_state) <parser_state>: Add
2478         parameters.  Initialize new members.
2479         <expression_context_block, expression_context_pc>: New members.
2480         * parse.c (expression_context_block, expression_context_pc):
2481         Remove globals.
2482         (parse_exp_in_context): Update.
2483         * p-exp.y: Update all rules.
2484         (yylex): Update.
2485         * m2-exp.y: Update all rules.
2486         (yylex): Update.
2487         * go-exp.y (yylex): Update.
2488         * f-exp.y (yylex): Update.
2489         * d-exp.y: Update all rules.
2490         (yylex): Update.
2491         * c-exp.y: Update all rules.
2492         (lex_one_token, classify_name, yylex, c_parse): Update.
2493         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2494
2495 2019-04-04  Tom Tromey  <tom@tromey.com>
2496
2497         * gdbarch.h, gdbarch.c: Rebuild.
2498         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2499         * stap-probe.h:
2500         (struct stap_parse_info): Replace "parser_state" with
2501         "expr_builder".
2502         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2503         (parser_state): New class.
2504         * parse.c (expr_builder): Rename.
2505         (expr_builder::release): Rename.
2506         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2507         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2508         (write_exp_elt_longcst, write_exp_elt_floatcst)
2509         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2510         (write_exp_string_vector, write_exp_bitstring)
2511         (write_exp_msymbol, mark_struct_expression)
2512         (write_dollar_variable)
2513         (insert_type_address_space, increase_expout_size): Replace
2514         "parser_state" with "expr_builder".
2515         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2516         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2517         "parser_state" with "expr_builder".
2518
2519 2019-04-04  Tom Tromey  <tom@tromey.com>
2520
2521         * rust-exp.y: Replace "parse_language" with method call.
2522         * p-exp.y:
2523         (yylex): Replace "parse_language" with method call.
2524         * m2-exp.y:
2525         (yylex): Replace "parse_language" with method call.
2526         * go-exp.y (classify_name): Replace "parse_language" with method
2527         call.
2528         * f-exp.y (yylex): Replace "parse_language" with method call.
2529         * d-exp.y (lex_one_token): Replace "parse_language" with method
2530         call.
2531         * c-exp.y:
2532         (lex_one_token, classify_name, yylex): Replace "parse_language"
2533         with method call.
2534         * ada-exp.y (find_primitive_type, type_char)
2535         (type_system_address): Replace "parse_language" with method call.
2536
2537 2019-04-04  Tom Tromey  <tom@tromey.com>
2538
2539         * rust-exp.y: Replace "parse_gdbarch" with method call.
2540         * parse.c (write_dollar_variable, insert_type_address_space):
2541         Replace "parse_gdbarch" with method call.
2542         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2543         call.
2544         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2545         call.
2546         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2547         "parse_gdbarch" with method call.
2548         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2549         with method call.
2550         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2551         "parse_gdbarch" with method call.
2552         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2553         "parse_gdbarch" with method call.
2554         * c-exp.y (parse_type, parse_number, classify_name): Replace
2555         "parse_gdbarch" with method call.
2556         * ada-lex.l: Replace "parse_gdbarch" with method call.
2557         * ada-exp.y (parse_type, find_primitive_type, type_char)
2558         (type_system_address): Replace "parse_gdbarch" with method call.
2559
2560 2019-04-04  Tom Tromey  <tom@tromey.com>
2561
2562         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2563         * stap-probe.c (stap_parse_argument): Update.
2564         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2565         initial_size parameter.
2566         * rust-exp.y (rust_lex_tests): Update.
2567         * parse.c (parser_state): Update.
2568         (parse_exp_in_context): Update.
2569         * parser-defs.h (struct parser_state) <parser_state>: Remove
2570         "initial_size" parameter.
2571
2572 2019-04-04  Tom Tromey  <tom@tromey.com>
2573
2574         * parser-defs.h (increase_expout_size): Don't declare.
2575         * parse.c (increase_expout_size): Now static.
2576
2577 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2578
2579         * gnu-nat.c (gnu_nat_target::wait): Fix
2580         target_waitstatus_to_string call.
2581
2582 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2583
2584         * eval.c (evaluate_subexp_standard): Handle internal functions
2585         during Fortran function call handling.
2586
2587 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2588
2589         * NEWS: Mention new internal functions.
2590         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2591         (read_base_type): Use dwarf2_init_complex_target_type.
2592         * value.c (creal_internal_fn): New function.
2593         (cimag_internal_fn): New function.
2594         (_initialize_values): Register new internal functions.
2595
2596 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2597
2598         * infrun.c (stop_all_threads): If debug_infrun, always
2599         trace the wait status after wait_one, using
2600         target_waitstatus_to_string and target_pid_to_str.
2601         (handle_inferior_event): Replace various trace of
2602         wait status kind by a single trace.
2603         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2604         wait status kind image by target_waitstatus_to_string.
2605         * target/waitstatus.c (target_waitstatus_to_string): Fix
2606         obsolete comment.
2607
2608 2019-04-01  Tom Tromey  <tromey@adacore.com>
2609
2610         PR symtab/23331:
2611         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2612
2613 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2614             Pedro Alves  <palves@redhat.com>
2615
2616         * top.c (quit_force): Call 'finalize_values'.
2617         * value.c (finalize_values): New function.
2618         * value.h (finalize_values): Declare.
2619
2620 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2621
2622         * NEWS: Announce $_gdb_major and $_gdb_minor.
2623
2624         * top.c (init_gdb_version_vars): New function.
2625         (gdb_init): Call init_gdb_version_vars.
2626
2627 2019-03-29  Tom Tromey  <tromey@adacore.com>
2628
2629         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2630         help text.  Remove dead code.
2631
2632 2019-03-29  Keith Seitz  <keiths@redhat.com>
2633
2634         From Siddhesh Poyarekar:
2635         * f-lang.h (f77_get_upperbound): Return LONGEST.
2636         (f77_get_lowerbound): Likewise.
2637         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2638         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2639         print them.
2640         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2641         plongest to format print it.
2642         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2643         (f77_get_upperbound): Likewise.
2644         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2645         LOWER_BOUND to LONGEST.
2646         (f77_create_arrayprint_offset_tbl): Likewise.
2647
2648 2019-03-29  Keith Seitz  <keiths@redhat.com>
2649
2650         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2651         %s/pulongest for TYPE_LENGTH instead of %d in format
2652         strings.
2653         * ada-typerint.c (ada_print_type): Likewise.
2654         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2655         * compile/compile-c-support.c (generate_register_struct): Likewise.
2656         * gdbtypes.c (recursive_dump_type): Likewise.
2657         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2658         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2659         instead of %d in format strings.
2660         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2661         to std::min to ULONGEST.
2662         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2663         instead of %d in format strings.
2664         * tracepoint.c (info_scope_command): Likewise.
2665         * typeprint.c (print_offset_data::update)
2666         (print_offset_data::finish): Likewise.
2667         * xtensa-tdep.c (xtensa_store_return_value)
2668         (xtensa_push_dummy_call): Likewise.
2669
2670 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2671
2672         * windows-nat.c (display_selector): Fixed format specifications
2673         for 64-bit Cygwin.
2674
2675 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2676
2677         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2678
2679 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2680
2681         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2682         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2683         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2684         (nios2_linux_init_abi): Install it.
2685
2686 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2687
2688         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2689
2690 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2691
2692         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2693
2694 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2695             Tom Tromey  <tromey@adacore.com>
2696
2697         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2698
2699 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2700
2701         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2702         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2703         method to compute the bounds of range types. Also print "[evaluated]"
2704         if the bounds' values come from a dynamic evaluation.
2705
2706 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2707
2708         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2709         whitespace when pretty printing is on.
2710
2711 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2712
2713         * ppc-linux-nat.c: Add include.
2714
2715 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2716
2717         * NEWS: Mention AArch64 Pointer Authentication.
2718
2719 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2720
2721         * arm-linux-nat.c: Add include.
2722
2723 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2724
2725         * source-cache.c (source_cache::get_source_lines): Re-read
2726         fullname after calling open_source_file.
2727
2728 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2729
2730         * NEWS: Mention TLS support for FreeBSD.
2731
2732 2019-03-25  Tom Tromey  <tromey@adacore.com>
2733
2734         * minsyms.c (BUNCH_SIZE): Update comment.
2735         (~minimal_symbol_reader): Remove old comment.
2736         (compact_minimal_symbols): Update comment.
2737         (minimal_symbol_reader::install): Remove old comment.  Update
2738         other comments.
2739
2740 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2741
2742         * s390-linux-nat.c: Add include.
2743
2744 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2745
2746         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2747         Call linux_get_hwcap.
2748         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2749         Likewise.
2750         (aarch64_linux_get_hwcap): Remove function.
2751         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2752         declaration.
2753         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2754         linux_get_hwcap.
2755         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2756         * linux-tdep.c (linux_get_hwcap): Add function.
2757         (linux_get_hwcap2): Likewise.
2758         * linux-tdep.h (linux_get_hwcap): Add declaration.
2759         (linux_get_hwcap2): Likewise.
2760         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2761         (ppc_linux_get_hwcap2): Likewise.
2762         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2763         linux_get_hwcap.
2764         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2765         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2766         (ppc_linux_nat_target::read_description): Likewise.
2767         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2768         * s390-linux-nat.c: Likewise.
2769         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2770
2771 2019-03-24  Tom Tromey  <tom@tromey.com>
2772
2773         * ada-lang.c (standard_lookup): Simplify initialization.
2774         (ada_lookup_symbol_nonlocal): Simplify return.
2775         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2776         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2777         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2778         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2779         initialization.
2780         * solib.c (solib_global_lookup): Simplify.
2781         * symtab.c (null_block_symbol): Remove.
2782         (symbol_cache_lookup): Simplify returns.
2783         (lookup_language_this): Simplify returns.
2784         (lookup_symbol_aux): Simplify return.
2785         (lookup_local_symbol): Simplify returns.
2786         (lookup_global_symbol_from_objfile): Simplify return.
2787         (lookup_symbol_in_objfile_symtabs)
2788         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2789         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2790         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2791         * cp-namespace.c (cp_lookup_bare_symbol)
2792         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2793         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2794         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2795         (cp_lookup_symbol_via_imports): Simplify initialization.
2796         (find_symbol_in_baseclass): Likewise.
2797         * symtab.h (null_block_symbol): Remove.
2798         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2799         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2800         (d_lookup_symbol_module): Likewise.
2801         (find_symbol_in_baseclass): Simplify initialization.
2802
2803 2019-03-24  Tom Tromey  <tom@tromey.com>
2804
2805         * expression.h: Don't include symtab.h.
2806         (struct block): Forward declare.
2807
2808 2019-03-24  Tom Tromey  <tom@tromey.com>
2809
2810         * c-exp.y (typebase): Remove casts.
2811         * gdbtypes.c (lookup_unsigned_typename, )
2812         (lookup_signed_typename): Remove cast.
2813         * eval.c (parse_to_comma_and_eval): Remove cast.
2814         * parse.c (write_dollar_variable): Remove cast.
2815         * block.h (struct block) <superblock>: Now const.
2816         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2817         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2818         (map_block): Make "block" const.
2819         * symfile.h (struct quick_symbol_functions)
2820         <map_matching_symbols>: Constify block argument to "callback".
2821         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2822         const.
2823         (find_pc_sect_compunit_symtab): Make "b" const.
2824         (find_symbol_at_address): Likewise.
2825         (search_symbols): Likewise.
2826         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2827         (dw2_debug_names_lookup_symbol): Likewise.
2828         (dw2_map_matching_symbols): Update.
2829         * p-valprint.c (pascal_val_print): Remove "block".
2830         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2831         (aux_add_nonlocal_symbols): Make "block" const.
2832         (resolve_subexp): Remove cast.
2833         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2834         const.
2835         (iterate_over_file_blocks): Likewise.
2836         * f-exp.y (%union) <bval>: Remove.
2837         * coffread.c (patch_opaque_types): Make "b" const.
2838         * spu-tdep.c (spu_catch_start): Make "block" const.
2839         * c-valprint.c (print_unpacked_pointer): Remove "block".
2840         * symmisc.c (dump_symtab_1): Make "b" const.
2841         (block_depth): Make "block" const.
2842         * d-exp.y (%union) <bval>: Remove.
2843         * cp-support.h (cp_lookup_rtti_type): Update.
2844         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2845         * psymtab.c (psym_lookup_symbol): Make "block" const.
2846         (maintenance_check_psymtabs): Make "b" const.
2847         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2848         (enumerate_locals, enumerate_args): Update.
2849         * python/py-symtab.c (stpy_global_block): Make "block" const.
2850         (stpy_static_block): Likewise.
2851         * inline-frame.c (block_starting_point_at): Make "new_block"
2852         const.
2853         * block.c (find_block_in_blockvector): Make return type const.
2854         (blockvector_for_pc_sect): Make "b" const.
2855         (find_block_in_blockvector): Make "b" const.
2856
2857 2019-03-23  Tom Tromey  <tom@tromey.com>
2858
2859         * varobj.c (varobj_create): Update.
2860         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2861         * printcmd.c (display_command, do_one_display): Don't reset
2862         innermost_block.
2863         * parser-defs.h (enum innermost_block_tracker_type): Move to
2864         expression.h.
2865         (innermost_block): Update comment.
2866         * parse.c (parse_exp_1): Add tracker_types parameter.
2867         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2868         tracker_types parameter.  Reset innermost_block.
2869         (parse_exp_in_context): Remove.
2870         (parse_expression_for_completion): Update.
2871         * objfiles.c (~objfile): Don't reset expression_context_block or
2872         innermost_block.
2873         * expression.h (enum innermost_block_tracker_type): Move from
2874         parser-defs.h.
2875         (parse_exp_1): Add tracker_types parameter.
2876         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2877         reset innermost_block.
2878
2879 2019-03-23  Tom Tromey  <tom@tromey.com>
2880
2881         * objfiles.h: Include bcache.h.
2882
2883 2019-03-23  Tom Tromey  <tom@tromey.com>
2884
2885         * linespec.c (get_current_search_block): Use
2886         scoped_restore_current_language.
2887         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2888
2889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2890             Jiong Wang  <jiong.wang@arm.com>
2891
2892         * aarch64-linux-tdep.c
2893         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2894         section.
2895         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2896
2897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2898             Jiong Wang  <jiong.wang@arm.com>
2899
2900         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2901         instructions.
2902         (aarch64_analyze_prologue_test): Add PACIASP test.
2903         (aarch64_prologue_prev_register): Unmask PC value.
2904
2905 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2906             Jiong Wang  <jiong.wang@arm.com>
2907
2908         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2909         (aarch64_dwarf2_prev_register): Unmask PC value.
2910         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2911         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2912         DW_CFA_AARCH64_negate_ra_state.
2913         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2914
2915 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2916             Jiong Wang  <jiong.wang@arm.com>
2917
2918         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2919         registers.
2920         (aarch64_pseudo_register_name): Likewise.
2921         (aarch64_pseudo_register_type): Likewise.
2922         (aarch64_pseudo_register_reggroup_p): Likewise.
2923         (aarch64_gdbarch_init): Add pauth registers.
2924         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2925         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2926         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2927         (struct gdbarch_tdep): Add regnum for ra_state.
2928
2929 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2930             Jiong Wang  <jiong.wang@arm.com>
2931
2932         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2933
2934 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2935             Jiong Wang  <jiong.wang@arm.com>
2936
2937         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2938         function.
2939         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2940         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2941         (aarch64_gdbarch_init): Add puth registers.
2942         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2943         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2944         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2945
2946 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2947             Jiong Wang  <jiong.wang@arm.com>
2948
2949         * aarch64-linux-nat.c
2950         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2951         * aarch64-linux-tdep.c
2952         (aarch64_linux_core_read_description): Likewise.
2953         (aarch64_linux_get_hwcap): New function.
2954         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2955         (aarch64_linux_get_hwcap): New declaration.
2956
2957 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2958             Jiong Wang  <jiong.wang@arm.com>
2959
2960         * aarch64-linux-nat.c
2961         (aarch64_linux_nat_target::read_description): Add pauth param.
2962         * aarch64-linux-tdep.c
2963         (aarch64_linux_core_read_description): Likewise.
2964         * aarch64-tdep.c (struct target_desc): Add in pauth.
2965         (aarch64_read_description): Add pauth param.
2966         (aarch64_gdbarch_init): Likewise.
2967         * aarch64-tdep.h (aarch64_read_description): Likewise.
2968         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2969         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2970         * features/Makefile: Add new files.
2971         * features/aarch64-pauth.c: New file.
2972         * features/aarch64-pauth.xml: New file.
2973
2974 2019-03-20  Tom Tromey  <tromey@adacore.com>
2975
2976         * infrun.c (handle_inferior_event): Rename from
2977         handle_inferior_event_1.  Create a scoped_value_mark.
2978         (handle_inferior_event): Remove.
2979
2980 2019-03-19  Tom Tromey  <tromey@adacore.com>
2981
2982         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2983         * infrun.h (print_stop_event): Add "displays" parameter.
2984         * infrun.c (print_stop_event): Add "displays" parameter.
2985
2986 2019-03-19  Pedro Alves  <palves@redhat.com>
2987
2988         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2989         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2990         to -1.  Fix TABs vs spaces.
2991         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2992         * tui/tui-out.h (tui_ui_out) Add intro comments.
2993         <m_line, m_start_of_line>: In-class initialize, and add describing
2994         comment.
2995
2996 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2997
2998         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2999         variable names.
3000         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3001
3002 2019-03-18  Pedro Alves  <palves@redhat.com>
3003             Eli Zaretskii <eliz@gnu.org>
3004
3005         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3006         m_line and m_start_of_line.
3007
3008 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3009
3010         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3011         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3012         it returns a newline.  This fixes a regression in TU mode, whereby
3013         the next line is output on the same screen line as the user input.
3014
3015 2019-03-18  Tom Tromey  <tromey@adacore.com>
3016
3017         * minsyms.c (minimal_symbol_reader::install): Remove call to
3018         obstack_blank.
3019
3020 2019-03-18  Pedro Alves  <palves@redhat.com>
3021
3022         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3023         New globals.
3024         (apply_style): New, factored out from ...
3025         (apply_ansi_escape): ... this.  Handle reverse video mode.
3026         (tui_set_reverse_mode): New function.
3027         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3028         * tui/tui-winsource.c (tui_show_source_line): Use
3029         tui_set_reverse_mode instead of setting A_STANDOUT.
3030         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3031         New setter methods.
3032
3033 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3034
3035         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3036         Handle tabs.
3037
3038 2019-03-18  Tom Tromey  <tromey@adacore.com>
3039
3040         * ada-lang.c (empty_array): Add "high" parameter.
3041         (ada_evaluate_subexp): Update.
3042
3043 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3044
3045         * unittests/string_view-selftests.c: Define
3046         _initialize_string_view_selftests unconditionally.
3047
3048 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3049
3050         PR gdb/24350
3051         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3052
3053 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3054
3055         PR gdb/24351
3056         * windows-nat.c (display_selector): Fix format specifiers.
3057
3058 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3059
3060         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3061         tui_refill_source_window instead of tui_refresh_win, to update the
3062         current execution line.  This fixes redisplay of the current line
3063         when stepping through the code with "next" or "step".
3064
3065 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3066
3067         * source-cache.c (source_cache::get_source_lines): Call
3068         find_source_lines to initialize s->nlines.  This fixes vertical
3069         scrolling of TUI source window when the DOWN arrow is pressed.
3070
3071 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3072
3073         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3074         linux-thread-db.c (_initialize_thread_db): Likewise.
3075
3076 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3077
3078         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3079         wclrtoeol in tui_show_source_line".  This reverts changes made in
3080         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3081
3082 2019-03-15  Tom Tromey  <tom@tromey.com>
3083
3084         * symtab.h (struct minimal_symbol): Derive from
3085         general_symbol_info.
3086         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3087         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3088         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3089         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3090         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3091         (MSYMBOL_SEARCH_NAME): Update.
3092         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3093         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3094         * minsyms.c (minimal_symbol_reader::record_full): Update.
3095
3096 2019-03-15  Tom Tromey  <tom@tromey.com>
3097
3098         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3099
3100 2019-03-15  Tom Tromey  <tom@tromey.com>
3101
3102         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3103         unique_xmalloc_ptr.
3104         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3105         Update.
3106         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3107         (build_minimal_symbol_hash_tables)
3108         (minimal_symbol_reader::install): Update.
3109
3110 2019-03-15  Tom Tromey  <tom@tromey.com>
3111
3112         * symtab.c (create_demangled_names_hash): Update.
3113         (symbol_set_names): Update.
3114         * objfiles.h (struct objfile_per_bfd_storage)
3115         <demangled_names_hash>: Now an htab_up.
3116         * objfiles.c (objfile_per_bfd_storage): Simplify.
3117
3118 2019-03-15  Tom Tromey  <tom@tromey.com>
3119
3120         * objfiles.h (struct objfile_per_bfd_storage): Declare
3121         destructor.
3122         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3123         New.
3124         (get_objfile_bfd_data): Use new.  Don't initialize
3125         language_of_main.
3126         (free_objfile_per_bfd_storage): Remove.
3127         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3128
3129 2019-03-15  Tom Tromey  <tom@tromey.com>
3130
3131         * symfile.c (reread_symbols): Update.
3132         * objfiles.c (objfile::objfile): Update.
3133         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3134         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3135         comment.
3136         (minimal_symbol_reader::install): Update.
3137         (terminate_minimal_symbol_table): Remove.
3138         * jit.c (jit_object_close_impl): Update.
3139
3140 2019-03-15  Tom Tromey  <tom@tromey.com>
3141
3142         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3143         initializations.
3144
3145 2019-03-15  Tom Tromey  <tom@tromey.com>
3146
3147         * objfiles.h (struct objfile_per_bfd_storage)
3148         <demangled_hash_languages>: Now a bitset.
3149         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3150         (lookup_minimal_symbol): Update.
3151
3152 2019-03-15  Tom Tromey  <tom@tromey.com>
3153
3154         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3155         Don't return the symbol.
3156         * coffread.c (record_minimal_symbol): Use record_full.
3157
3158 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3159
3160         The MS-Windows port of ncurses fails to switch to a color pair if
3161         one or both of the colors are the implicit default colors.  This
3162         change records the default colors when TUI is initialized, and
3163         then specifies them explicitly when a color pair uses the default
3164         colors.  This allows color styling in TUI mode on MS-Windows.
3165
3166         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3167         ncurses_norm_attr.
3168         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3169         colors in ncurses_norm_attr.
3170         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3171         "none", replace it with the default color recorded in
3172         ncurses_norm_attr.
3173
3174 2019-03-14  Tom Tromey  <tromey@adacore.com>
3175
3176         * source-cache.h (class source_cache) <get_source_lines>: Return
3177         std::string.
3178         * source-cache.c (source_cache::extract_lines): Handle case where
3179         first_pos==npos.  Return std::string.
3180         (source_cache::get_source_lines): Update.
3181
3182 2019-03-14  Tom Tromey  <tromey@adacore.com>
3183
3184         * NEWS: Add item for "style sources" commands.
3185         * source-cache.c (source_cache::get_source_lines): Check
3186         source_styling.
3187         * cli/cli-style.c (source_styling): New global.
3188         (_initialize_cli_style): Add "style sources" commands.
3189         (show_style_sources): New function.
3190         * cli/cli-style.h (source_styling): Declare.
3191
3192 2019-03-14  Pedro Alves  <palves@redhat.com>
3193             Tom Tromey  <tromey@adacore.com>
3194
3195         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3196         * tui/tui-winsource.c (tui_refill_source_window): New function,
3197         from...
3198         (tui_horizontal_source_scroll): ... here.  Move some logic.
3199         * cli/cli-style.c (set_style_enabled): Notify new observable.
3200         * tui/tui-hooks.c (tui_redisplay_source): New function.
3201         (tui_attach_detach_observers): Attach or detach
3202         tui_redisplay_source.
3203         * observable.h (source_styling_changed): New observable.
3204         * observable.c: Define source_styling_changed observable.
3205
3206 2019-03-13  Tom Tromey  <tromey@adacore.com>
3207
3208         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3209         (i386_gnu_nat_target::store_registers): Update.
3210         * target-debug.h (target_debug_print_std_string): New macro.
3211         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3212         * windows-tdep.c (display_one_tib): Update.
3213         * tui/tui-stack.c (tui_make_status_line): Update.
3214         * top.c (print_inferior_quit_action): Update.
3215         * thread.c (thr_try_catch_cmd): Update.
3216         (add_thread_with_info): Update.
3217         (thread_target_id_str): Update.
3218         (thr_try_catch_cmd): Update.
3219         (thread_command): Update.
3220         (thread_find_command): Update.
3221         * record-btrace.c (record_btrace_target::info_record)
3222         (record_btrace_resume_thread, record_btrace_target::resume)
3223         (record_btrace_cancel_resume, record_btrace_step_thread)
3224         (record_btrace_target::wait, record_btrace_target::wait)
3225         (record_btrace_target::wait, record_btrace_target::stop): Update.
3226         * progspace.c (print_program_space): Update.
3227         * process-stratum-target.c
3228         (process_stratum_target::thread_address_space): Update.
3229         * linux-fork.c (linux_fork_mourn_inferior)
3230         (detach_checkpoint_command, info_checkpoints_command)
3231         (linux_fork_context): Update.
3232         (linux_fork_detach): Update.
3233         (class scoped_switch_fork_info): Update.
3234         (delete_checkpoint_command): Update.
3235         * infrun.c (follow_fork_inferior): Update.
3236         (follow_fork_inferior): Update.
3237         (proceed_after_vfork_done): Update.
3238         (handle_vfork_child_exec_or_exit): Update.
3239         (follow_exec): Update.
3240         (displaced_step_prepare_throw): Update.
3241         (displaced_step_restore): Update.
3242         (start_step_over): Update.
3243         (resume_1): Update.
3244         (clear_proceed_status_thread): Update.
3245         (proceed): Update.
3246         (print_target_wait_results): Update.
3247         (do_target_wait): Update.
3248         (context_switch): Update.
3249         (stop_all_threads): Update.
3250         (restart_threads): Update.
3251         (finish_step_over): Update.
3252         (handle_signal_stop): Update.
3253         (switch_back_to_stepped_thread): Update.
3254         (keep_going_pass_signal): Update.
3255         (print_exited_reason): Update.
3256         (normal_stop): Update.
3257         * inferior.c (inferior_pid_to_str): Change return type.
3258         (print_selected_inferior): Update.
3259         (add_inferior): Update.
3260         (detach_inferior): Update.
3261         * dummy-frame.c (fprint_dummy_frames): Update.
3262         * dcache.c (dcache_info_1): Update.
3263         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3264         (btrace_fetch, btrace_clear): Update.
3265         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3266         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3267         type.
3268         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3269         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3270         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3271         * gdbarch.c, gdbarch.h: Rebuild.
3272         * gdbarch.sh (core_pid_to_str): Change return type.
3273         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3274         return type.
3275         (windows_nat_target::pid_to_str): Change return type.
3276         (windows_delete_thread): Update.
3277         (windows_nat_target::attach): Update.
3278         (windows_nat_target::files_info): Update.
3279         * target-delegates.c: Rebuild.
3280         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3281         return type.
3282         (sol_thread_target::pid_to_str): Change return type.
3283         * remote.c (class remote_target) <pid_to_str>: Change return
3284         type.
3285         (remote_target::pid_to_str): Change return type.
3286         (extended_remote_target::attach, remote_target::remote_stop_ns)
3287         (remote_target::remote_notif_remove_queued_reply)
3288         (remote_target::push_stop_reply, remote_target::disable_btrace):
3289         Update.
3290         (extended_remote_target::attach): Update.
3291         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3292         type.
3293         (gdbsim_target::pid_to_str): Change return type.
3294         * ravenscar-thread.c (struct ravenscar_thread_target)
3295         <pid_to_str>: Change return type.
3296         (ravenscar_thread_target::pid_to_str): Change return type.
3297         * procfs.c (class procfs_target) <pid_to_str>: Change return
3298         type.
3299         (procfs_target::pid_to_str): Change return type.
3300         (procfs_target::attach): Update.
3301         (procfs_target::detach): Update.
3302         (procfs_target::fetch_registers): Update.
3303         (procfs_target::store_registers): Update.
3304         (procfs_target::wait): Update.
3305         (procfs_target::files_info): Update.
3306         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3307         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3308         return type.
3309         (nto_procfs_target::pid_to_str): Change return type.
3310         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3311         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3312         return type.
3313         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3314         (exit_lwp): Update.
3315         (attach_proc_task_lwp_callback, get_detach_signal)
3316         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3317         (linux_nat_target::resume, wait_lwp, stop_callback)
3318         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3319         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3320         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3321         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3322         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3323         type.
3324         (inf_ptrace_target::attach): Update.
3325         (inf_ptrace_target::files_info): Update.
3326         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3327         type.
3328         (go32_nat_target::pid_to_str): Change return type.
3329         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3330         (gnu_nat_target::wait): Update.
3331         (gnu_nat_target::wait): Update.
3332         (gnu_nat_target::resume): Update.
3333         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3334         (fbsd_nat_target::wait): Update.
3335         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3336         type.
3337         (darwin_nat_target::attach): Update.
3338         * corelow.c (class core_target) <pid_to_str>: Change return type.
3339         (core_target::pid_to_str): Change return type.
3340         * target.c (normal_pid_to_str): Change return type.
3341         (default_pid_to_str): Likewise.
3342         (target_pid_to_str): Change return type.
3343         (target_translate_tls_address): Update.
3344         (target_announce_detach): Update.
3345         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3346         return type.
3347         (bsd_uthread_target::pid_to_str): Change return type.
3348         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3349         type.
3350         (bsd_kvm_target::pid_to_str): Change return type.
3351         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3352         return type.
3353         (aix_thread_target::pid_to_str): Change return type.
3354         * target.h (struct target_ops) <pid_to_str>: Change return type.
3355         (target_pid_to_str, normal_pid_to_str): Likewise.
3356         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3357         type.
3358         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3359         type.
3360         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3361         return type.
3362         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3363         type.
3364         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3365         type.
3366         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3367         return type.
3368
3369 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3370
3371         * NEWS: Mention that the new default MI version is 3.  Mention
3372         changes to the output of commands and events that deal with
3373         multi-location breakpoints.
3374         * breakpoint.c: Include "mi/mi-out.h".
3375         (print_one_breakpoint): Change output syntax if using MI version
3376         >= 3.
3377         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3378         New.
3379         (mi_multi_location_breakpoint_output_fixed): New.
3380         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3381         (mi_cmd_fix_multi_location_breakpoint_output): New.
3382         (mi_multi_location_breakpoint_output_fixed): New.
3383         * mi/mi-cmds.c (mi_cmds): Register command
3384         -fix-multi-location-breakpoint-output.
3385         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3386         interpreter "mi".
3387
3388 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3389
3390         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3391         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3392         instantiate mi_ui_out based on interpreter name.
3393         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3394         * mi/mi-main.c (mi_load_progress): Likewise.
3395
3396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3397
3398         * NEWS: Combine separate "New targets" sections for 8.3.
3399
3400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3401
3402         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3403         (ppcfbsd_init_abi): Install gdbarch
3404         "fetch_tls_load_module_address" and "get_thread_local_address"
3405         methods.
3406
3407 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3408
3409         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3410         (riscv_fbsd_init_abi): Install gdbarch
3411         "fetch_tls_load_module_address" and "get_thread_local_address"
3412         methods.
3413
3414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3415
3416         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3417         (i386fbsd_init_abi): Install gdbarch
3418         "fetch_tls_load_module_address" and "get_thread_local_address"
3419         methods.
3420
3421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3422
3423         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3424         (amd64fbsd_init_abi): Install gdbarch
3425         "fetch_tls_load_module_address" and "get_thread_local_address"
3426         methods.
3427
3428 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3429
3430         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3431         (struct fbsd_pspace_data): New type.
3432         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3433         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3434         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3435         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3436         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3437
3438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3439
3440         * gdbtypes.c (lookup_struct_elt): New function.
3441         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3442         * gdbtypes.h (struct struct_elt): New type.
3443         (lookup_struct_elt): New prototype.
3444
3445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3446
3447         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3448         remove disabled code block.
3449
3450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3451
3452         * gdbarch.sh (get_thread_local_address): New method.
3453         * gdbarch.h, gdbarch.c: Regenerate.
3454         * target.c (target_translate_tls_address): Use
3455         gdbarch_get_thread_local_address if present instead of
3456         target::get_thread_local_address.
3457
3458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3459
3460         * target.h (target::get_thread_local_address): Update comment.
3461
3462 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3463
3464         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3465         objfile->separate_debug_objfile_backlink if not NULL.
3466
3467 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3468
3469         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3470         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3471         (amd64bsd_store_inferior_registers): Likewise.
3472         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3473         Enable segment base registers.
3474         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3475         PT_GETFSBASE and PT_GETGSBASE.
3476         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3477         PT_SETGSBASE.
3478         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3479         segment base registers.
3480         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3481
3482 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3483
3484         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3485         Update calls to i386_target_description to add 'segments'
3486         parameter.
3487         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3488         add segment base registers.
3489         * arch/i386.c (i386_create_target_description): Add 'segments'
3490         parameter to enable segment base registers.
3491         * arch/i386.h (i386_create_target_description): Likewise.
3492         * features/i386/32bit-segments.xml: New file.
3493         * features/i386/32bit-segments.c: Generate.
3494         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3495         call to i386_target_description to add 'segments' parameter.
3496         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3497         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3498         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3499         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3500         if feature is present.
3501         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3502         Add 'segments' parameter to call to i386_target_description.
3503         (i386_target_description): Add 'segments' parameter to enable
3504         segment base registers.
3505         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3506         to call to i386_target_description.
3507         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3508         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3509         Define I386_NUM_REGS.
3510         (i386_target_description): Add 'segments' parameter to enable
3511         segment base registers.
3512
3513 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3514
3515         PR/24325
3516         * source-cache.c: #undef open and close, to avoid unresolved
3517         externals during linking.
3518
3519 2019-03-12  Tom Tromey  <tromey@adacore.com>
3520
3521         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3522         const.  Add initializers.
3523         (_initialize_remote): Don't initialize ptid globals.
3524
3525 2019-03-12  Pedro Alves  <palves@redhat.com>
3526
3527         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3528
3529 2019-03-12  Pedro Alves  <palves@redhat.com>
3530
3531         * cp-name-parser.y (main): Remove unused 'len' variable.
3532
3533 2019-03-12  Tom Tromey  <tromey@adacore.com>
3534
3535         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3536         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3537
3538 2019-03-12  Tom Tromey  <tromey@adacore.com>
3539
3540         * linux-nat.c (iterate_over_lwps): Update.
3541         (stop_callback): Remove parameter.
3542         (stop_wait_callback, detach_callback, resume_set_callback)
3543         (select_singlestep_lwp_callback, set_ignore_sigint)
3544         (status_callback, resumed_callback, resume_clear_callback)
3545         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3546         data parameter.
3547         (linux_nat_target::detach, linux_nat_target::resume)
3548         (linux_stop_and_wait_all_lwps, select_event_lwp)
3549         (linux_nat_filter_event, linux_nat_wait_1)
3550         (linux_nat_target::kill, linux_nat_target::stop)
3551         (linux_nat_target::stop): Update.
3552         (linux_nat_resume_callback): Change type.
3553         (resume_stopped_resumed_lwps, count_events_callback)
3554         (select_event_lwp_callback): Likewise.
3555         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3556         * arm-linux-nat.c (struct update_registers_data): Remove.
3557         (update_registers_callback): Change type.
3558         (arm_linux_insert_hw_breakpoint1): Update.
3559         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3560         parameter.
3561         (x86_linux_dr_set_addr): Update.
3562         (x86_linux_dr_set_control): Update.
3563         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3564         (iterate_over_lwps): Use gdb::function_view.
3565         * nat/aarch64-linux-hw-point.c (struct
3566         aarch64_dr_update_callback_param): Remove.
3567         (debug_reg_change_callback): Change type.
3568         (aarch64_notify_debug_reg_change): Update.
3569         * s390-linux-nat.c (s390_refresh_per_info): Update.
3570
3571 2019-03-11  Tom Tromey  <tromey@adacore.com>
3572
3573         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3574         redundant assignment to "this_cu".
3575
3576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3577
3578         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3579
3580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3581
3582         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3583         from...
3584         (rank_one_type): ... this.
3585
3586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3587
3588         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3589         from...
3590         (rank_one_type): ... this.
3591
3592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3593
3594         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3595         from...
3596         (rank_one_type): ... this.
3597
3598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3599
3600         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3601         from...
3602         (rank_one_type): ... this.
3603
3604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3605
3606         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3607         from...
3608         (rank_one_type): ... this.
3609
3610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3611
3612         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3613         from...
3614         (rank_one_type): ... this.
3615
3616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3617
3618         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3619         from...
3620         (rank_one_type): ... this.
3621
3622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3623
3624         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3625         from...
3626         (rank_one_type): ... this.
3627
3628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3629
3630         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3631         from...
3632         (rank_one_type): ... this.
3633
3634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3635
3636         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3637         from...
3638         (rank_one_type): ... this.
3639
3640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3641
3642         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3643         from...
3644         (rank_one_type): ... this.
3645
3646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3647
3648         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3649         from...
3650         (rank_one_type): ... this.
3651
3652 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3653
3654         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3655         inferior-events' shows the example events.
3656
3657 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3658
3659         Support styling on native MS-Windows console
3660
3661         PR/24315
3662         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3663         on MS-Windows if $TERM is not defined.
3664
3665         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3666
3667         * posix-hdep.c (gdb_console_fputs):
3668         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3669         functions.
3670         * ui-file.h (gdb_console_fputs): Add prototype.
3671
3672         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3673         back to fputs only if the former returns zero.
3674
3675 2019-03-07  Tom Tromey  <tom@tromey.com>
3676
3677         * symmisc.c (print_symbol_bcache_statistics): Update.
3678         (print_objfile_statistics): Update.
3679         * symfile.c (allocate_symtab): Update.
3680         * stabsread.c: Don't include bcache.h.
3681         * psymtab.h (struct psymbol_bcache): Don't declare.
3682         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3683         (psymbol_bcache_init, psymbol_bcache_free)
3684         (psymbol_bcache_get_bcache): Don't declare.
3685         * psymtab.c (struct psymbol_bcache): Remove.
3686         (psymtab_storage::psymtab_storage): Update.
3687         (psymtab_storage::~psymtab_storage): Update.
3688         (psymbol_bcache_init, psymbol_bcache_free)
3689         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3690         (add_psymbol_to_bcache): Update.
3691         (allocate_psymtab): Update.
3692         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3693         macro_cache>: No longer pointers.
3694         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3695         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3696         * macrotab.c (macro_bcache): Update.
3697         * macroexp.c: Don't include bcache.h.
3698         * gdbtypes.c (check_types_worklist): Update.
3699         (types_deeply_equal): Remove TRY/CATCH.  Update.
3700         * elfread.c (elf_symtab_read): Update.
3701         * dwarf2read.c: Don't include bcache.h.
3702         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3703         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3704         (print_bcache_statistics, bcache_memory_used): Don't declare.
3705         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3706         methods.  Rename all data members.
3707         * bcache.c (struct bcache): Move to bcache.h.
3708         (bcache::expand_hash_table): Rename from expand_hash_table.
3709         (bcache): Remove.
3710         (bcache::insert): Rename from bcache_full.
3711         (bcache::compare): Rename from bcache_compare.
3712         (bcache_xmalloc): Remove.
3713         (bcache::~bcache): Rename from bcache_xfree.
3714         (bcache::print_statistics): Rename from print_bcache_statistics.
3715         (bcache::memory_used): Rename from bcache_memory_used.
3716
3717 2019-03-07  Pedro Alves  <palves@redhat.com>
3718
3719         * infrun.c (normal_stop): Also check for
3720         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3721
3722 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * f-lang.c (value_from_host_double): Moved to...
3725         * value.c (value_from_host_double): ...here.
3726         * value.h (value_from_host_double): Declare.
3727         * guile/scm-math.c (vlscm_convert_typed_number): Use
3728         value_from_host_double.
3729         (vlscm_convert_number): Likewise.
3730         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3731         * python/py-value.c (convert_value_from_python): Likewise.
3732
3733 2019-03-06  Tom Tromey  <tom@tromey.com>
3734
3735         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3736
3737 2019-03-06  Tom Tromey  <tom@tromey.com>
3738
3739         * utils.h (free_current_contents): Don't declare.
3740         * utils.c (free_current_contents): Remove.
3741
3742 2019-03-06  Tom Tromey  <tom@tromey.com>
3743
3744         * top.c (quit_force): Update.
3745         * main.c (captured_command_loop): Update.
3746         * common/new-op.c (operator new): Update.
3747         * common/common-exceptions.c (struct catcher)
3748         <save_cleanup_chain>: Remove member.
3749         (exceptions_state_mc_init): Update.
3750         (exception_try_scope_entry): Return nullptr.
3751         (exception_try_scope_exit, exception_rethrow)
3752         (throw_exception_sjlj, throw_exception_cxx): Update.
3753         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3754         (all_cleanups, do_cleanups, discard_cleanups)
3755         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3756         (restore_cleanups, restore_final_cleanups): Don't declare.
3757         (do_final_cleanups): Remove parameter.
3758         * common/cleanups.c (cleanup_chain, make_cleanup)
3759         (make_cleanup_dtor, all_cleanups, do_cleanups)
3760         (discard_my_cleanups, discard_cleanups)
3761         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3762         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3763         (null_cleanup): Remove.
3764         (do_final_cleanups): Remove parameter.
3765
3766 2019-03-06  Tom Tromey  <tom@tromey.com>
3767
3768         * remote.c (remote_target::remote_parse_stop_reply): Use
3769         unique_xmalloc_ptr.
3770
3771 2019-03-06  Tom Tromey  <tom@tromey.com>
3772
3773         * stabsread.c (struct stabs_field_info): Rename from field_info.
3774         <list, fnlist>: Add initializers.
3775         <obstack>: New member.
3776         (read_member_functions, read_struct_fields, read_baseclasses):
3777         Allocate on obstack.  Don't use cleanups.
3778         (read_one_struct_field, read_member_functions, read_struct_fields)
3779         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3780         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3781         (read_struct_type): Update.
3782
3783 2019-03-06  Tom Tromey  <tom@tromey.com>
3784
3785         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3786         * common/filestuff.h (make_cleanup_close): Don't declare.
3787         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3788         Remove.
3789
3790 2019-03-06  Tom Tromey  <tom@tromey.com>
3791
3792         * solib-aix.c: Use make_scope_exit.
3793
3794 2019-03-06  Tom Tromey  <tom@tromey.com>
3795
3796         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3797         Use make_scope_exit.
3798
3799 2019-03-06  Tom Tromey  <tom@tromey.com>
3800
3801         * solib-svr4.c (disable_probes_interface): Remove parameter.
3802         (svr4_handle_solib_event): Use make_scope_exit.
3803
3804 2019-03-06  Tom Tromey  <tom@tromey.com>
3805
3806         * remote.c (struct stop_reply_deleter): Remove.
3807         (stop_reply_up): Update.
3808         (struct stop_reply): Derive from notif_event.  Don't typedef.
3809         <regcache>: Now a std::vector.
3810         (stop_reply_xfree): Remove.
3811         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3812         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3813         (remote_target::discard_pending_stop_replies): Use delete.
3814         (remote_target::remote_parse_stop_reply): Update.
3815         (remote_target::process_stop_reply): Update.
3816         * remote-notif.h (struct notif_event): Add virtual destructor.
3817         Remove "dtr" member.
3818         (struct notif_client) <alloc_event>: Return a unique_ptr.
3819         (notif_event_xfree): Don't declare.
3820         (notif_event_up): New typedef.
3821         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3822         (notif_event_xfree, do_notif_event_xfree): Remove.
3823         (remote_notif_state_xfree): Update.
3824
3825 2019-03-06  Tom Tromey  <tom@tromey.com>
3826
3827         * infrun.c (displaced_step_clear_cleanup): Now a
3828         forward_scope_exit type.
3829         (displaced_step_prepare_throw): Update.
3830         (displaced_step_fixup): Update.
3831
3832 2019-03-06  Tom Tromey  <tom@tromey.com>
3833
3834         * inferior.h (class inferior): Update comment.
3835         * gdbthread.h (class thread_info): Update comment.
3836
3837 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3838             Tom Tromey  <tom@tromey.com>
3839
3840         * stabsread.h (struct stab_section_list): Remove.
3841         (coffstab_build_psymtabs): Update.
3842         * dbxread.c (symbuf_sections): Now a std::vector.
3843         (sect_idx): New global.
3844         (fill_symbuf): Update.
3845         (coffstab_build_psymtabs): Change type of stabsects parameter.
3846         Update.
3847         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3848         std::vector.
3849         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3850         (coff_locate_sections): Update.
3851         (coff_symfile_read): Remove cleanups.  Update.
3852         (init_stringtab): Add storage parameter.
3853         (free_stringtab, free_stringtab_cleanup): Remove.
3854         (init_lineno): Add storage parameter.
3855         (free_linetab, free_linetab_cleanup): Remove.
3856
3857 2019-03-06  Pedro Alves  <palves@redhat.com>
3858
3859         * linux-fork.c (fork_info::clobber_regs): Delete.
3860         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3861         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3862         comment.  Adjust.
3863         (scoped_switch_fork_info::scoped_switch_fork_info)
3864         (checkpoint_command, linux_fork_context): Adjust
3865         fork_save_infrun_state calls.
3866
3867 2019-03-06  Pedro Alves  <palves@redhat.com>
3868
3869         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3870         (inf_has_multiple_threads): Return 'bool' and rewrite using
3871         inferior_info::threads().
3872
3873 2019-03-06  Pedro Alves  <palves@redhat.com>
3874
3875         * linux-fork.c: Include <list>.
3876         (fork_list): Now a std::list instance.
3877         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3878         (forks_exist_p, find_last_fork): Adjust.
3879         (new_fork): Delete.
3880         (one_fork_p): New.
3881         (add_fork): Adjust.
3882         (free_fork): Delete, folded into fork_info::~fork_info().
3883         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3884         Adjust.
3885         (init_fork_list): Delete.
3886         (linux_fork_killall, linux_fork_mourn_inferior)
3887         (linux_fork_detach, info_checkpoints_command): Adjust.
3888         (_initialize_linux_fork): No longer call init_fork_list.
3889
3890 2019-03-06  Pedro Alves  <palves@redhat.com>
3891
3892         * linux-fork.c (new_fork): New, split out of ...
3893         (add_fork): ... this.  Return void.  Move "first fork" special
3894         case from here, to ...
3895         (checkpoint_command): ... here.
3896         * linux-linux.h (add_fork): Return void.
3897
3898 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3901
3902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3903             Chris January  <chris.january@arm.com>
3904             David Lecomber  <david.lecomber@arm.com>
3905
3906         * f-exp.y: New token, UNOP_INTRINSIC.
3907         (exp): New pattern using UNOP_INTRINSIC token.
3908         (f77_keywords): Add 'abs' keyword.
3909         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3910         (value_from_host_double): New function.
3911         (evaluate_subexp_f): Support UNOP_ABS.
3912
3913 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3914
3915         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3916         types.
3917
3918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3921         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3922         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3923
3924 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3927
3928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3929             Chris January  <chris.january@arm.com>
3930
3931         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3932         * f-exp.y: Define 'KIND' token.
3933         (exp): New pattern for KIND expressions.
3934         (ptype): Handle types with a kind extension.
3935         (direct_abs_decl): Extend to spot kind extensions.
3936         (f77_keywords): Add 'kind' to the list.
3937         (push_kind_type): New function.
3938         (convert_to_kind_type): New function.
3939         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3940         * parse.c (operator_length_standard): Likewise.
3941         * parser-defs.h (enum type_pieces): Add tp_kind.
3942         * std-operator.def: Add UNOP_KIND.
3943
3944 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3945
3946         * f-exp.y (f_parse): Set yydebug.
3947
3948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3949
3950         * f-lang.c (evaluate_subexp_f): New function.
3951         (exp_descriptor_f): New global.
3952         (f_language_defn): Use exp_descriptor_f instead of
3953         exp_descriptor_standard.
3954
3955 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3956
3957         * f-exp.y (struct token): Add comments.
3958         (dot_ops): Remove uppercase versions and the end marker.
3959         (f77_keywords): Likewise.
3960         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3961         entries in the dot_ops array are case insensitive, and use
3962         strncasecmp to compare strings.  Also some whitespace cleanup in
3963         this area.  Similar for the f77_keywords array, except entries in
3964         this list might be case sensitive.
3965
3966 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * f-exp.y (struct f77_boolean_val): Add comments.
3969         (boolean_values): Remove uppercase versions, and end marker.
3970         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3971         and use strncasecmp to achieve case insensitivity.  Additionally,
3972         perform whitespace cleanup around this code.
3973
3974 2019-03-06  Tom Tromey  <tromey@adacore.com>
3975
3976         * remote-sim.c (gdbsim_target_open): Use result of
3977         gdb_argv::release.
3978
3979 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3980         Dirk Schubert  <dirk.schubert@arm.com>
3981         Chris January  <chris.january@arm.com>
3982
3983         * eval.c (evaluate_subexp_standard): Call Fortran argument
3984         wrapping logic.
3985         * f-lang.c (struct value): A value which can be passed into a
3986         Fortran function call.
3987         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3988         where appropriate.
3989         (struct type): Value ready for a Fortran function call.
3990         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3991         is needed.
3992         * f-lang.h (fortran_argument_convert): Declaration.
3993         (fortran_preserve_arg_pointer): Declaration.
3994         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3995
3996 2019-03-05  Tom Tromey  <tromey@adacore.com>
3997
3998         * python/py-prettyprint.c (print_string_repr): Remove #if.
3999         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4000
4001 2019-03-05  Tom Tromey  <tromey@adacore.com>
4002
4003         * target.c (the_dummy_target): Move later.  Change type to
4004         "dummy_target".
4005         (initialize_targets): Don't initialize the_dummy_target.
4006
4007 2019-03-05  Tom Tromey  <tromey@adacore.com>
4008
4009         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4010         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4011
4012 2019-03-05  Tom Tromey  <tromey@adacore.com>
4013
4014         * windows-nat.c (windows_nat_target::attach)
4015         (windows_nat_target::detach): Don't call gdb_flush.
4016         * valprint.c (generic_val_print, val_print, val_print_string):
4017         Don't call gdb_flush.
4018         * utils.c (defaulted_query): Don't call gdb_flush.
4019         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4020         * target.c (target_announce_detach): Don't call gdb_flush.
4021         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4022         * remote.c (extended_remote_target::attach): Don't call
4023         gdb_flush.
4024         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4025         * printcmd.c (do_examine): Don't call gdb_flush.
4026         (info_display_command): Don't call gdb_flush.
4027         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4028         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4029         * memattr.c (info_mem_command): Don't call gdb_flush.
4030         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4031         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4032         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4033         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4034         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4035         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4036         (gnu_nat_target::detach): Don't call gdb_flush.
4037         * f-valprint.c (f_val_print): Don't call gdb_flush.
4038         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4039         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4040         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4041         gdb_flush.
4042         * c-valprint.c (c_val_print): Don't call gdb_flush.
4043         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4044
4045 2019-03-05  Tom Tromey  <tromey@adacore.com>
4046
4047         * varobj.c (update_dynamic_varobj_children): Update.
4048         (install_default_visualizer): Use reset, not release.
4049         * value.c (set_internalvar): Update.
4050         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4051         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4052         ATTRIBUTE_UNUSED_RESULT.
4053
4054 2019-03-05  Tom Tromey  <tromey@adacore.com>
4055
4056         * remote.c (class scoped_remote_fd) <release>: Add
4057         ATTRIBUTE_UNUSED_RESULT.
4058
4059 2019-03-05  Tom Tromey  <tromey@adacore.com>
4060
4061         * macroexp.c (struct macro_buffer) <release>: Add
4062         ATTRIBUTE_UNUSED_RESULT.
4063
4064 2019-03-05  Tom Tromey  <tromey@adacore.com>
4065
4066         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4067         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4068         ATTRIBUTE_UNUSED_RESULT.
4069
4070 2019-03-05  Tom Tromey  <tromey@adacore.com>
4071
4072         * common/scoped_fd.h (class scoped_fd) <release>: Add
4073         ATTRIBUTE_UNUSED_RESULT.
4074
4075 2019-03-05  Tom Tromey  <tromey@adacore.com>
4076
4077         * parser-defs.h (struct parser_state) <release>: Add
4078         ATTRIBUTE_UNUSED_RESULT.
4079
4080 2019-03-05  Tom Tromey  <tromey@adacore.com>
4081
4082         * utils.h (class gdb_argv) <release>: Add
4083         ATTRIBUTE_UNUSED_RESULT.
4084         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4085
4086 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4087
4088         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4089         for-loop range, to avoid compiler warnings.
4090
4091         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4092         avoid compiler warnings about unused variables.
4093
4094         * NEWS: Mention end of support for native debugging on MS-Windows
4095         before XP.
4096
4097         PR gdb/24292
4098         * common/netstuff.c:
4099         * gdbserver/gdbreplay.c
4100         * gdbserver/remote-utils.c:
4101         * ser-tcp.c:
4102         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4103         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4104         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4105         'getaddrinfo' and 'freeaddrinfo' were not available before
4106         Windows XP, and mingw.org's MinGW headers by default define
4107         _WIN32_WINNT to 0x500.
4108
4109 2019-03-01  Gary Benson <gbenson@redhat.com>
4110
4111         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4112
4113 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4114             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4115
4116         PR gdb/8527
4117         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4118         set_sigint_trap, clear_sigint_trap.
4119
4120 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4121
4122         * target.c (target_detach): Clear the regcache and the
4123         frame cache.
4124
4125 2019-02-27  Pedro Alves  <palves@redhat.com>
4126
4127         * utils.c (set_screen_size): When we cap the height/width sizes,
4128         tweak the corresponding command variable to show "unlimited":
4129
4130 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4131             Pedro Alves  <palves@redhat.com>
4132
4133         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4134         before calling rl_set_screen_size.
4135
4136 2019-02-27  Tom Tromey  <tromey@adacore.com>
4137
4138         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4139         define.
4140         * python/py-value.c: Remove Python 2.4 workaround.
4141         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4142         workaround.
4143         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4144         Python 2.4 workaround.
4145         * python/python-internal.h: Remove Python 2.4 comment.
4146         (Py_ssize_t): Don't define.
4147         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4148         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4149         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4150         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4151         * python/python.c (do_start_initialization): Remove Python 2.4
4152         workaround.
4153         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4154         (print_children): Remove Python 2.4 workaround.
4155         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4156         workaround.
4157         (CHARBUFFERPROC_NAME): Remove.
4158         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4159         Python 2.4 workaround.
4160
4161 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4162
4163         * NEWS: Note minimum Python version.
4164
4165 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4166
4167         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4168         code from these functions.  Remove corresponding ifdefs.  Use
4169         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4170         Remove gotos and target of gotos.
4171         (infpy_search_memory): Likewise.
4172
4173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4176         (hppa_gdbarch_init): Don't register deleted functions with
4177         gdbarch.
4178
4179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4182         (h8300_unwind_sp): Delete.
4183         (h8300_dummy_id): Delete.
4184         (h8300_gdbarch_init): Don't register deleted functions with
4185         gdbarch.
4186
4187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4190         (ft32_unwind_pc): Delete.
4191         (ft32_unwind_sp): Delete.
4192         (ft32_gdbarch_init): Don't register deleted functions with
4193         gdbarch.
4194
4195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4196
4197         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4198         (frv_unwind_pc): Delete.
4199         (frv_unwind_sp): Delete.
4200         (frv_gdbarch_init): Don't register deleted functions with
4201         gdbarch.
4202
4203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4204
4205         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4206         (riscv_unwind_pc): Delete.
4207         (riscv_unwind_sp): Delete.
4208         (riscv_gdbarch_init): Don't register deleted functions with
4209         gdbarch.
4210
4211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4212
4213         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4214         (csky_unwind_pc): Delete.
4215         (csky_unwind_sp): Delete.
4216         (csky_gdbarch_init): Don't register deleted functions with
4217         gdbarch.
4218
4219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4220
4221         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4222         (cris_unwind_pc): Delete.
4223         (cris_unwind_sp): Delete.
4224         (cris_gdbarch_init): Don't register deleted functions with
4225         gdbarch.
4226
4227 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4228
4229         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4230         (bfin_unwind_pc): Delete.
4231         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4232
4233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4234
4235         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4236         (arm_unwind_pc): Delete.
4237         (arm_unwind_sp): Delete.
4238         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4239
4240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4241
4242         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4243         (arc_unwind_pc): Delete.
4244         (arc_unwind_sp): Delete.
4245         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4246
4247 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4248
4249         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4250         (alpha_unwind_pc): Delete.
4251         (alpha_gdbarch_init): Don't register deleted functions with
4252         gdbarch.
4253
4254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4257         (aarch64_unwind_pc): Delete.
4258         (aarch64_unwind_sp): Delete.
4259         (aarch64_gdbarch_init): Don't register deleted functions with
4260         gdbarch.
4261
4262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * gdbtypes.c (type_align): Don't consider static members when
4265         computing structure alignment.
4266
4267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4270         return 0 for other types.
4271         * arch-utils.c (default_type_align): Always return 0.
4272         * gdbarch.h: Regenerate.
4273         * gdbarch.sh (type_align): Extend comment.
4274         * gdbtypes.c (type_align): Add additional comments, always call
4275         gdbarch_type_align before applying the default rules.
4276         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4277         generic code will then apply a suitable default.
4278         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4279         types, return 0 for other types.
4280
4281 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4282
4283         * NEWS: Create a new section for the next release branch.
4284         Rename the section of the current branch, now that it has
4285         been cut.
4286
4287 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4288
4289         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4290         * version.in: Bump version to 8.3.50.DATE-git.
4291
4292 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4293
4294         * aix-thread.c (ptid_cmp): Remove unused variable.
4295         (get_signaled_thread): Likewise.
4296         (store_regs_user_thread): Likewise.
4297         (store_regs_kernel_thread): Likewise.
4298         (fetch_regs_kernel_thread): Remove shadowed variable.
4299
4300 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         * features/riscv/32bit-cpu.xml: Add register numbers.
4303         * features/riscv/32bit-fpu.c: Regenerate.
4304         * features/riscv/32bit-fpu.xml: Add register numbers.
4305         * features/riscv/64bit-cpu.xml: Add register numbers.
4306         * features/riscv/64bit-fpu.c: Regenerate.
4307         * features/riscv/64bit-fpu.xml: Add register numbers.
4308
4309 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4310
4311         * NEWS: Mention two argument form of gdb.Value constructor.
4312         * python/py-value.c (convert_buffer_and_type_to_value): New
4313         function.
4314         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4315         Add support for handling an optional second argument.  Call
4316         convert_buffer_and_type_to_value as appropriate.
4317         * python/python-internal.h (Py_buffer_deleter): New struct.
4318         (Py_buffer_up): New typedef.
4319
4320 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4321
4322         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4323         instead of releasing ownership.
4324
4325 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4326
4327         * dwarf2read.c (open_and_init_dwp_file): Call
4328         elf_numsections instead of bfd_count_sections to initialize
4329         dwp_file->num_sections.
4330
4331 2019-02-25  Tom Tromey  <tromey@adacore.com>
4332
4333         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4334
4335 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4336
4337         * gcore.in: Add '--readnever' option when invoking GDB.
4338
4339 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4340
4341         * MAINTAINERS: Update my email address.
4342
4343 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4344
4345         * build-id.c (build_id_to_debug_bfd_1): New function.
4346         (build_id_to_debug_bfd): Look for separate debug file in
4347         sysroot.
4348
4349 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * gdbarch.sh: Update the copyright year range that is placed into
4352         generated files.
4353
4354 2019-02-22  Keith Seitz  <keiths@redhat.com>
4355
4356         PR symtab/23853
4357         * linespec.c (create_sals_line_offset): Search for the default
4358         symtab's filename instead of its fullname.
4359
4360 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4361
4362         * NEWS: Update style defaults.
4363
4364 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4365
4366         * main.c (captured_main_1): Disable styling in batch mode.
4367
4368 2019-02-20  Tom Tromey  <tom@tromey.com>
4369
4370         * symtab.c (symtab_symbol_info): Fix typos.
4371
4372 2019-02-20  Tom Tromey  <tromey@adacore.com>
4373
4374         * findcmd.c (_initialize_mem_search): Use upper case for
4375         metasyntactic variables.
4376
4377 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4378
4379         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4380         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4381
4382 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4383
4384         * top.h (source_file_name): Change to std::string.
4385         * top.c (source_file_name): Likewise.
4386         (command_line_input): Adjust.
4387         * cli/cli-script.c (script_from_file): Adjust.
4388
4389 2019-02-19  Tom Tromey  <tromey@adacore.com>
4390
4391         * ravenscar-thread.c
4392         (ravenscar_thread_target::update_thread_list): Don't call
4393         ada_build_task_list.
4394         * ada-lang.h (ada_build_task_list): Don't declare.
4395         * ada-tasks.c (struct ada_tasks_inferior_data)
4396         <task_list_valid_p>: Now bool.
4397         (read_known_tasks, ada_task_list_changed)
4398         (ada_tasks_invalidate_inferior_data): Update.
4399         (read_known_tasks_array): Return bool.
4400         (read_known_tasks_list): Likewise.
4401         (read_known_tasks): Return void.
4402         (ada_build_task_list): Now static.
4403
4404 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4405
4406         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4407         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4408
4409 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4410
4411         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4412         variant for ada_tasks_pspace_data_handle and
4413         ada_tasks_inferior_data_handle.
4414         (ada_tasks_pspace_data_cleanup): New function.
4415         (ada_tasks_inferior_data_cleanup): New function.
4416
4417 2019-02-17  Tom Tromey  <tom@tromey.com>
4418
4419         * macrotab.h (macro_source_fullname): Return a std::string.
4420         * macrotab.c (macro_include, check_for_redefinition)
4421         (macro_undef, macro_lookup_definition, foreach_macro)
4422         (foreach_macro_in_scope): Update.
4423         (macro_source_fullname): Return a std::string.
4424         * macrocmd.c (show_pp_source_pos): Update.
4425
4426 2019-02-17  Tom Tromey  <tom@tromey.com>
4427
4428         * macrocmd.c (show_pp_source_pos): Style the file names.
4429
4430 2019-02-17  Tom Tromey  <tom@tromey.com>
4431
4432         PR tui/24197:
4433         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4434
4435 2019-02-17  Tom Tromey  <tom@tromey.com>
4436
4437         * ada-lang.c (user_select_syms): Use filtered printing.
4438         * utils.c (wrap_style): New global.
4439         (desired_style): Remove.
4440         (emit_style_escape): Add stream parameter.
4441         (set_output_style, reset_terminal_style, prompt_for_continue):
4442         Update.
4443         (flush_wrap_buffer): Only flush gdb_stdout.
4444         (wrap_here): Set wrap_style.
4445         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4446         treat escape sequences as a character.  Change when wrap buffer is
4447         flushed.
4448         (fputs_styled): Do not set the output style when the default is
4449         requested.
4450         * ui-style.h (struct ui_file_style) <is_default>: New method.
4451         * source.c (print_source_lines_base): Emit escape sequences in one
4452         piece.
4453
4454 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4455
4456         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4457         integers and enumeration types.
4458
4459 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4460
4461         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4462         instead of lookup_symbol_in_language
4463         (do_exact_match): New function.
4464         (ada_get_symbol_name_matcher): Return do_exact_match when
4465         doing a verbatim match.
4466
4467 2019-02-15  Tom Tromey  <tromey@adacore.com>
4468
4469         * ravenscar-thread.c (ravenscar_thread_target::resume)
4470         (ravenscar_thread_target::wait): Special case wildcard requests.
4471
4472 2019-02-15  Tom Tromey  <tromey@adacore.com>
4473
4474         * ravenscar-thread.c (base_ptid): Remove.
4475         (struct ravenscar_thread_target) <close>: New method.
4476         <m_base_ptid>: New member.
4477         <update_inferior_ptid, active_task, task_is_currently_active,
4478         runtime_initialized>: Declare methods.
4479         <ravenscar_thread_target>: Add constructor.
4480         (ravenscar_thread_target::task_is_currently_active)
4481         (ravenscar_thread_target::update_inferior_ptid)
4482         (ravenscar_runtime_initialized): Rename.  Now methods.
4483         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4484         (ravenscar_thread_target::update_thread_list): Update.
4485         (ravenscar_thread_target::active_task): Now method.
4486         (ravenscar_thread_target::store_registers)
4487         (ravenscar_thread_target::prepare_to_store)
4488         (ravenscar_thread_target::prepare_to_store)
4489         (ravenscar_thread_target::mourn_inferior): Update.
4490         (ravenscar_inferior_created): Use "new" to create target.
4491         (ravenscar_thread_target::get_ada_task_ptid): Update.
4492         (_initialize_ravenscar): Don't initialize base_ptid.
4493         (ravenscar_ops): Remove global.
4494
4495 2019-02-15  Tom Tromey  <tromey@adacore.com>
4496
4497         * target.h (push_target): Declare new overload.
4498         * target.c (push_target): New overload, taking an rvalue reference.
4499         * remote.c (remote_target::open_1): Use push_target overload.
4500         * corelow.c (core_target_open): Use push_target overload.
4501
4502 2019-02-15  Tom Tromey  <tromey@adacore.com>
4503
4504         * ravenscar-thread.c (is_ravenscar_task)
4505         (ravenscar_task_is_currently_active): Return bool.
4506         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4507         (_initialize_ravenscar): Remove "(void)".
4508         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4509         Return bool.
4510
4511 2019-02-15  Tom Tromey  <tromey@adacore.com>
4512
4513         * ravenscar-thread.c (ravenscar_runtime_initializer)
4514         (has_ravenscar_runtime, get_running_thread_id)
4515         (ravenscar_thread_target::resume): Fix indentation.
4516
4517 2019-02-15  Tom Tromey  <tromey@adacore.com>
4518
4519         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4520         from ravenscar_arch_ops.
4521         (sparc_ravenscar_ops::fetch_registers)
4522         (sparc_ravenscar_ops::store_registers): Now methods.
4523         (sparc_ravenscar_prepare_to_store): Remove.
4524         (sparc_ravenscar_ops): Redefine.
4525         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4526         methods and destructor.  Remove members.
4527         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4528         (ravenscar_thread_target::store_registers)
4529         (ravenscar_thread_target::prepare_to_store): Update.
4530         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4531         Remove.
4532         (struct ppc_ravenscar_powerpc_ops): Derive from
4533         ravenscar_arch_ops.
4534         (ppc_ravenscar_powerpc_ops::fetch_registers)
4535         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4536         (ppc_ravenscar_powerpc_ops): Redefine.
4537         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4538         (ppc_ravenscar_e500_ops::fetch_registers)
4539         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4540         (ppc_ravenscar_e500_ops): Redefine.
4541         * aarch64-ravenscar-thread.c
4542         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4543         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4544         (aarch64_ravenscar_fetch_registers)
4545         (aarch64_ravenscar_store_registers): Now methods.
4546         (aarch64_ravenscar_ops): Redefine.
4547
4548 2019-02-15  Tom Tromey  <tromey@adacore.com>
4549
4550         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4551         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4552         (ravenscar_thread_target::stopped_by_watchpoint)
4553         (ravenscar_thread_target::stopped_data_address)
4554         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4555
4556 2019-02-15  Tom Tromey  <tromey@adacore.com>
4557
4558         * ravenscar-thread.c: Fix some typos.
4559
4560 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4561             Tom Tromey  <tromey@adacore.com>
4562
4563         * ada-lang.c (ada_exception_sal): Change addr_string to a
4564         std::string.
4565         (create_ada_exception_catchpoint): Update.
4566
4567 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4568             Tom Tromey  <tromey@adacore.com>
4569
4570         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4571         (bp_location_ops): Remove.
4572         (base_breakpoint_allocate_location): Update.
4573         (free_bp_location): Update.
4574         * ada-lang.c (class ada_catchpoint_location)
4575         <ada_catchpoint_location>: Remove ops parameter.
4576         (ada_catchpoint_location_dtor): Remove.
4577         (ada_catchpoint_location_ops): Remove.
4578         (allocate_location_exception): Update.
4579         * breakpoint.h (struct bp_location_ops): Remove.
4580         (class bp_location) <bp_location>: Remove bp_location_ops
4581         parameter.
4582         <~bp_location>: Add destructor.
4583         <ops>: Remove.
4584
4585 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4586             Pedro Alves  <palves@redhat.com>
4587
4588         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4589         'PATH_MAX'.
4590
4591 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4592             Samuel Thibault  <samuel.thibault@gnu.org>
4593             Thomas Schwinge  <thomas@codesourcery.com>
4594
4595         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4596         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4597
4598 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4599
4600         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4601         (check_empty): Use "const char *".
4602
4603         * gnu-nat.c (gnu_nat_target::detach): Instead of
4604         'detach_inferior (pid)' call
4605         'detach_inferior (find_inferior_pid (pid))'.
4606
4607         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4608         'nat/fork-inferior.o'.
4609         * gnu-nat.c: #include "nat/fork-inferior.h".
4610
4611         * gnu-nat.c (gnu_nat_target::detach): Instead of
4612         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4613         * gnu-nat.h: #include "inf-child.h".
4614         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4615         'i386_gnu_nat_target::fetch_registers'.
4616         (gnu_store_registers): Rename/move to
4617         'i386_gnu_nat_target::store_registers'.
4618
4619         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4620         * gnu-nat.h (mach_thread_info): New function.
4621         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4622
4623         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4624
4625 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4626
4627         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4628
4629 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4630
4631         * windows-nat.c (windows_add_thread): Add new parameter
4632         "main_thread_p" with default value set to false.  Update
4633         function documentation as well as all callers.
4634         (windows_delete_thread): Likewise.
4635         (fake_create_process): Update call to windows_add_thread.
4636         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4637         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4638         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4639         call to windows_delete_thread.
4640
4641 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4642
4643         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4644
4645 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4646
4647         * symfile.c (find_separate_debug_file): Use canonical path of
4648         sysroot with child_path instead of gdb_sysroot if it is valid.
4649
4650 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4651
4652         * symfile.c (find_separate_debug_file): Use child_path to
4653         determine if an object file is under a sysroot.
4654
4655 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4656
4657         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4658         unittests/child-path-selftests.c.
4659         * common/pathstuff.c (child_path): New function.
4660         * common/pathstuff.h (child_path): New prototype.
4661         * unittests/child-path-selftests.c: New file.
4662
4663 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4664
4665         * symfile.c (find_separate_debug_file): Look for separate debug
4666         files in debug directories under the sysroot.
4667
4668 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4669
4670         * symtab.h (struct minimal_symbol data_p): New const method.
4671         (struct minimal_symbol text_p): Likewise.
4672         * symtab.c (output_source_filename): Use file name style
4673         to print file name.
4674         (print_symbol_info): Likewise.
4675         (print_msymbol_info): Use address style to print addresses.
4676         Use function name style to print executable text symbols.
4677         (expand_symtab_containing_pc): Use data_p.
4678         (find_pc_sect_compunit_symtab): Likewise.
4679
4680 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4681
4682         * breakpoint.c (describe_other_breakpoints): Use address style
4683         to print addresses.
4684         (say_where): Likewise.
4685
4686 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4687
4688         * ada-typeprint.c (print_func_type): Print function name
4689         style to print function name.
4690         * c-typeprint.c (c_print_type_1): Likewise.
4691
4692 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4693
4694         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4695         for execve.
4696
4697 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4698
4699         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4700         type_stack.
4701
4702 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4703
4704         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4705         TYPE_CODE_REF types.
4706
4707 2019-02-08  Jim Wilson  <jimw@sifive.com>
4708
4709         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4710         (riscv_linux_fregset): New.
4711         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4712
4713 2019-02-07  Tom Tromey  <tom@tromey.com>
4714
4715         * thread.c (thread_cancel_execution_command): Update.
4716         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4717         methods.
4718         (struct thread_fsm_ops): Remove.
4719         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4720         (thread_fsm_should_stop, thread_fsm_return_value)
4721         (thread_fsm_set_finished, thread_fsm_finished_p)
4722         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4723         Don't declare.
4724         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4725         * infrun.c (clear_proceed_status_thread)
4726         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4727         (print_stop_event): Update.
4728         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4729         Add constructor.
4730         (step_command_fsm_ops): Remove.
4731         (new_step_command_fsm): Remove.
4732         (step_1): Update.
4733         (step_command_fsm::should_stop): Rename from
4734         step_command_fsm_should_stop.
4735         (step_command_fsm::clean_up): Rename from
4736         step_command_fsm_clean_up.
4737         (step_command_fsm::do_async_reply_reason): Rename from
4738         step_command_fsm_async_reply_reason.
4739         (struct until_next_fsm): Inherit from thread_fsm.  Add
4740         constructor.
4741         (until_next_fsm_ops): Remove.
4742         (new_until_next_fsm): Remove.
4743         (until_next_fsm::should_stop): Rename from
4744         until_next_fsm_should_stop.
4745         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4746         (until_next_fsm::do_async_reply_reason): Rename from
4747         until_next_fsm_async_reply_reason.
4748         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4749         constructor.  Change type of breakpoint.
4750         (finish_command_fsm_ops): Remove.
4751         (new_finish_command_fsm): Remove.
4752         (finish_command_fsm::should_stop): Rename from
4753         finish_command_fsm_should_stop.
4754         (finish_command_fsm::clean_up): Rename from
4755         finish_command_fsm_clean_up.
4756         (finish_command_fsm::return_value): Rename from
4757         finish_command_fsm_return_value.
4758         (finish_command_fsm::do_async_reply_reason): Rename from
4759         finish_command_fsm_async_reply_reason.
4760         (finish_command): Update.
4761         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4762         Add constructor.
4763         (call_thread_fsm_ops): Remove.
4764         (call_thread_fsm::call_thread_fsm): Rename from
4765         new_call_thread_fsm.
4766         (call_thread_fsm::should_stop): Rename from
4767         call_thread_fsm_should_stop.
4768         (call_thread_fsm::should_notify_stop): Rename from
4769         call_thread_fsm_should_notify_stop.
4770         (run_inferior_call, call_function_by_hand_dummy): Update.
4771         * cli/cli-interp.c (should_print_stop_to_console): Update.
4772         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4773         Add constructor.  Change type of location_breakpoint,
4774         caller_breakpoint.
4775         (until_break_fsm_ops): Remove.
4776         (new_until_break_fsm): Remove.
4777         (until_break_fsm::should_stop): Rename from
4778         until_break_fsm_should_stop.
4779         (until_break_fsm::clean_up): Rename from
4780         until_break_fsm_clean_up.
4781         (until_break_fsm::do_async_reply_reason): Rename from
4782         until_break_fsm_async_reply_reason.
4783         (until_break_command): Update.
4784         * thread-fsm.c: Remove.
4785         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4786
4787 2019-02-07  Tom Tromey  <tom@tromey.com>
4788
4789         * yy-remap.h: Add include guard.
4790         * xtensa-tdep.h: Add include guard.
4791         * xcoffread.h: Rename include guard.
4792         * varobj-iter.h: Add include guard.
4793         * tui/tui.h: Rename include guard.
4794         * tui/tui-winsource.h: Rename include guard.
4795         * tui/tui-wingeneral.h: Rename include guard.
4796         * tui/tui-windata.h: Rename include guard.
4797         * tui/tui-win.h: Rename include guard.
4798         * tui/tui-stack.h: Rename include guard.
4799         * tui/tui-source.h: Rename include guard.
4800         * tui/tui-regs.h: Rename include guard.
4801         * tui/tui-out.h: Rename include guard.
4802         * tui/tui-layout.h: Rename include guard.
4803         * tui/tui-io.h: Rename include guard.
4804         * tui/tui-hooks.h: Rename include guard.
4805         * tui/tui-file.h: Rename include guard.
4806         * tui/tui-disasm.h: Rename include guard.
4807         * tui/tui-data.h: Rename include guard.
4808         * tui/tui-command.h: Rename include guard.
4809         * tic6x-tdep.h: Add include guard.
4810         * target/waitstatus.h: Rename include guard.
4811         * target/wait.h: Rename include guard.
4812         * target/target.h: Rename include guard.
4813         * target/resume.h: Rename include guard.
4814         * target-float.h: Rename include guard.
4815         * stabsread.h: Add include guard.
4816         * rs6000-tdep.h: Add include guard.
4817         * riscv-fbsd-tdep.h: Add include guard.
4818         * regformats/regdef.h: Rename include guard.
4819         * record.h: Rename include guard.
4820         * python/python.h: Rename include guard.
4821         * python/python-internal.h: Rename include guard.
4822         * python/py-stopevent.h: Rename include guard.
4823         * python/py-ref.h: Rename include guard.
4824         * python/py-record.h: Rename include guard.
4825         * python/py-record-full.h: Rename include guard.
4826         * python/py-record-btrace.h: Rename include guard.
4827         * python/py-instruction.h: Rename include guard.
4828         * python/py-events.h: Rename include guard.
4829         * python/py-event.h: Rename include guard.
4830         * procfs.h: Add include guard.
4831         * proc-utils.h: Add include guard.
4832         * p-lang.h: Add include guard.
4833         * or1k-tdep.h: Rename include guard.
4834         * observable.h: Rename include guard.
4835         * nto-tdep.h: Rename include guard.
4836         * nat/x86-linux.h: Rename include guard.
4837         * nat/x86-linux-dregs.h: Rename include guard.
4838         * nat/x86-gcc-cpuid.h: Add include guard.
4839         * nat/x86-dregs.h: Rename include guard.
4840         * nat/x86-cpuid.h: Rename include guard.
4841         * nat/ppc-linux.h: Rename include guard.
4842         * nat/mips-linux-watch.h: Rename include guard.
4843         * nat/linux-waitpid.h: Rename include guard.
4844         * nat/linux-ptrace.h: Rename include guard.
4845         * nat/linux-procfs.h: Rename include guard.
4846         * nat/linux-osdata.h: Rename include guard.
4847         * nat/linux-nat.h: Rename include guard.
4848         * nat/linux-namespaces.h: Rename include guard.
4849         * nat/linux-btrace.h: Rename include guard.
4850         * nat/glibc_thread_db.h: Rename include guard.
4851         * nat/gdb_thread_db.h: Rename include guard.
4852         * nat/gdb_ptrace.h: Rename include guard.
4853         * nat/fork-inferior.h: Rename include guard.
4854         * nat/amd64-linux-siginfo.h: Rename include guard.
4855         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4856         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4857         * nat/aarch64-linux.h: Rename include guard.
4858         * nat/aarch64-linux-hw-point.h: Rename include guard.
4859         * mn10300-tdep.h: Add include guard.
4860         * mips-linux-tdep.h: Add include guard.
4861         * mi/mi-parse.h: Rename include guard.
4862         * mi/mi-out.h: Rename include guard.
4863         * mi/mi-main.h: Rename include guard.
4864         * mi/mi-interp.h: Rename include guard.
4865         * mi/mi-getopt.h: Rename include guard.
4866         * mi/mi-console.h: Rename include guard.
4867         * mi/mi-common.h: Rename include guard.
4868         * mi/mi-cmds.h: Rename include guard.
4869         * mi/mi-cmd-break.h: Rename include guard.
4870         * m2-lang.h: Add include guard.
4871         * location.h: Rename include guard.
4872         * linux-record.h: Rename include guard.
4873         * linux-nat.h: Add include guard.
4874         * linux-fork.h: Add include guard.
4875         * i386-darwin-tdep.h: Rename include guard.
4876         * hppa-linux-offsets.h: Add include guard.
4877         * guile/guile.h: Rename include guard.
4878         * guile/guile-internal.h: Rename include guard.
4879         * gnu-nat.h: Rename include guard.
4880         * gdb-stabs.h: Rename include guard.
4881         * frv-tdep.h: Add include guard.
4882         * f-lang.h: Add include guard.
4883         * event-loop.h: Add include guard.
4884         * darwin-nat.h: Rename include guard.
4885         * cp-abi.h: Rename include guard.
4886         * config/sparc/nm-sol2.h: Rename include guard.
4887         * config/nm-nto.h: Rename include guard.
4888         * config/nm-linux.h: Add include guard.
4889         * config/i386/nm-i386gnu.h: Rename include guard.
4890         * config/djgpp/nl_types.h: Rename include guard.
4891         * config/djgpp/langinfo.h: Rename include guard.
4892         * compile/gcc-cp-plugin.h: Add include guard.
4893         * compile/gcc-c-plugin.h: Add include guard.
4894         * compile/compile.h: Rename include guard.
4895         * compile/compile-object-run.h: Rename include guard.
4896         * compile/compile-object-load.h: Rename include guard.
4897         * compile/compile-internal.h: Rename include guard.
4898         * compile/compile-cplus.h: Rename include guard.
4899         * compile/compile-c.h: Rename include guard.
4900         * common/xml-utils.h: Rename include guard.
4901         * common/x86-xstate.h: Rename include guard.
4902         * common/version.h: Rename include guard.
4903         * common/vec.h: Rename include guard.
4904         * common/tdesc.h: Rename include guard.
4905         * common/selftest.h: Rename include guard.
4906         * common/scoped_restore.h: Rename include guard.
4907         * common/scoped_mmap.h: Rename include guard.
4908         * common/scoped_fd.h: Rename include guard.
4909         * common/safe-iterator.h: Rename include guard.
4910         * common/run-time-clock.h: Rename include guard.
4911         * common/refcounted-object.h: Rename include guard.
4912         * common/queue.h: Rename include guard.
4913         * common/ptid.h: Rename include guard.
4914         * common/print-utils.h: Rename include guard.
4915         * common/preprocessor.h: Rename include guard.
4916         * common/pathstuff.h: Rename include guard.
4917         * common/observable.h: Rename include guard.
4918         * common/netstuff.h: Rename include guard.
4919         * common/job-control.h: Rename include guard.
4920         * common/host-defs.h: Rename include guard.
4921         * common/gdb_wait.h: Rename include guard.
4922         * common/gdb_vecs.h: Rename include guard.
4923         * common/gdb_unlinker.h: Rename include guard.
4924         * common/gdb_unique_ptr.h: Rename include guard.
4925         * common/gdb_tilde_expand.h: Rename include guard.
4926         * common/gdb_sys_time.h: Rename include guard.
4927         * common/gdb_string_view.h: Rename include guard.
4928         * common/gdb_splay_tree.h: Rename include guard.
4929         * common/gdb_setjmp.h: Rename include guard.
4930         * common/gdb_ref_ptr.h: Rename include guard.
4931         * common/gdb_optional.h: Rename include guard.
4932         * common/gdb_locale.h: Rename include guard.
4933         * common/gdb_assert.h: Rename include guard.
4934         * common/filtered-iterator.h: Rename include guard.
4935         * common/filestuff.h: Rename include guard.
4936         * common/fileio.h: Rename include guard.
4937         * common/environ.h: Rename include guard.
4938         * common/common-utils.h: Rename include guard.
4939         * common/common-types.h: Rename include guard.
4940         * common/common-regcache.h: Rename include guard.
4941         * common/common-inferior.h: Rename include guard.
4942         * common/common-gdbthread.h: Rename include guard.
4943         * common/common-exceptions.h: Rename include guard.
4944         * common/common-defs.h: Rename include guard.
4945         * common/common-debug.h: Rename include guard.
4946         * common/cleanups.h: Rename include guard.
4947         * common/buffer.h: Rename include guard.
4948         * common/btrace-common.h: Rename include guard.
4949         * common/break-common.h: Rename include guard.
4950         * cli/cli-utils.h: Rename include guard.
4951         * cli/cli-style.h: Rename include guard.
4952         * cli/cli-setshow.h: Rename include guard.
4953         * cli/cli-script.h: Rename include guard.
4954         * cli/cli-interp.h: Rename include guard.
4955         * cli/cli-decode.h: Rename include guard.
4956         * cli/cli-cmds.h: Rename include guard.
4957         * charset-list.h: Add include guard.
4958         * buildsym-legacy.h: Rename include guard.
4959         * bfin-tdep.h: Add include guard.
4960         * ax.h: Rename include guard.
4961         * arm-linux-tdep.h: Add include guard.
4962         * arm-fbsd-tdep.h: Add include guard.
4963         * arch/xtensa.h: Rename include guard.
4964         * arch/tic6x.h: Add include guard.
4965         * arch/i386.h: Add include guard.
4966         * arch/arm.h: Rename include guard.
4967         * arch/arm-linux.h: Rename include guard.
4968         * arch/arm-get-next-pcs.h: Rename include guard.
4969         * arch/amd64.h: Add include guard.
4970         * arch/aarch64-insn.h: Rename include guard.
4971         * arch-utils.h: Rename include guard.
4972         * annotate.h: Add include guard.
4973         * amd64-darwin-tdep.h: Rename include guard.
4974         * aarch64-linux-tdep.h: Add include guard.
4975         * aarch64-fbsd-tdep.h: Add include guard.
4976         * aarch32-linux-nat.h: Add include guard.
4977
4978 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4979
4980         * macrotab.c (macro_define_internal): New function that
4981         factorizes macro_define_object_internal and macro_define_function
4982         code.
4983         (macro_define_object_internal): Use macro_define_internal.
4984         (macro_define_function): Likewise.
4985
4986 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4987
4988         * macrocmd.c (extract_identifier): Return
4989         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4990         callers.
4991
4992 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4993
4994         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4995
4996 2019-02-05  Tom Tromey  <tom@tromey.com>
4997
4998         * target.c (target_stack::unpush): Move assertion earlier.
4999
5000 2019-01-30  Tom Tromey  <tom@tromey.com>
5001
5002         PR python/23615:
5003         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5004         (gdbpy_parse_and_eval): Likewise.
5005         * python/python-internal.h (gdbpy_allow_threads): New class.
5006
5007 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5008
5009         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5010         (aarch64_fbsd_fpregmap): Move earlier.
5011         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5012         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5013         instead of individual calls to trad_frame_set_reg_addr.
5014         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5015         earlier.
5016         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5017         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5018         instead of individual calls to trad_frame_set_reg_addr.
5019
5020 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5021
5022         * CONTRIBUTE: Replace contribution list with wiki link.
5023
5024 2019-01-25  Tom Tromey  <tom@tromey.com>
5025
5026         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5027
5028 2019-01-25  Tom Tromey  <tom@tromey.com>
5029
5030         * xtensa-linux-nat.c: Fix common/ includes.
5031         * xml-support.h: Fix common/ includes.
5032         * xml-support.c: Fix common/ includes.
5033         * x86-linux-nat.c: Fix common/ includes.
5034         * windows-nat.c: Fix common/ includes.
5035         * varobj.h: Fix common/ includes.
5036         * varobj.c: Fix common/ includes.
5037         * value.c: Fix common/ includes.
5038         * valops.c: Fix common/ includes.
5039         * utils.c: Fix common/ includes.
5040         * unittests/xml-utils-selftests.c: Fix common/ includes.
5041         * unittests/utils-selftests.c: Fix common/ includes.
5042         * unittests/unpack-selftests.c: Fix common/ includes.
5043         * unittests/tracepoint-selftests.c: Fix common/ includes.
5044         * unittests/style-selftests.c: Fix common/ includes.
5045         * unittests/string_view-selftests.c: Fix common/ includes.
5046         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5047         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5048         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5049         * unittests/rsp-low-selftests.c: Fix common/ includes.
5050         * unittests/parse-connection-spec-selftests.c: Fix common/
5051         includes.
5052         * unittests/optional-selftests.c: Fix common/ includes.
5053         * unittests/offset-type-selftests.c: Fix common/ includes.
5054         * unittests/observable-selftests.c: Fix common/ includes.
5055         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5056         * unittests/memrange-selftests.c: Fix common/ includes.
5057         * unittests/memory-map-selftests.c: Fix common/ includes.
5058         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5059         * unittests/function-view-selftests.c: Fix common/ includes.
5060         * unittests/environ-selftests.c: Fix common/ includes.
5061         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5062         * unittests/common-utils-selftests.c: Fix common/ includes.
5063         * unittests/cli-utils-selftests.c: Fix common/ includes.
5064         * unittests/array-view-selftests.c: Fix common/ includes.
5065         * ui-file.c: Fix common/ includes.
5066         * tui/tui-io.c: Fix common/ includes.
5067         * tracepoint.h: Fix common/ includes.
5068         * tracepoint.c: Fix common/ includes.
5069         * tracefile-tfile.c: Fix common/ includes.
5070         * top.h: Fix common/ includes.
5071         * top.c: Fix common/ includes.
5072         * thread.c: Fix common/ includes.
5073         * target/waitstatus.h: Fix common/ includes.
5074         * target/waitstatus.c: Fix common/ includes.
5075         * target.h: Fix common/ includes.
5076         * target.c: Fix common/ includes.
5077         * target-memory.c: Fix common/ includes.
5078         * target-descriptions.c: Fix common/ includes.
5079         * symtab.h: Fix common/ includes.
5080         * symfile.c: Fix common/ includes.
5081         * stap-probe.c: Fix common/ includes.
5082         * spu-linux-nat.c: Fix common/ includes.
5083         * sparc-nat.c: Fix common/ includes.
5084         * source.c: Fix common/ includes.
5085         * solib.c: Fix common/ includes.
5086         * solib-target.c: Fix common/ includes.
5087         * ser-unix.c: Fix common/ includes.
5088         * ser-tcp.c: Fix common/ includes.
5089         * ser-pipe.c: Fix common/ includes.
5090         * ser-base.c: Fix common/ includes.
5091         * selftest-arch.c: Fix common/ includes.
5092         * s12z-tdep.c: Fix common/ includes.
5093         * rust-exp.y: Fix common/ includes.
5094         * rs6000-aix-tdep.c: Fix common/ includes.
5095         * riscv-tdep.c: Fix common/ includes.
5096         * remote.c: Fix common/ includes.
5097         * remote-notif.h: Fix common/ includes.
5098         * remote-fileio.h: Fix common/ includes.
5099         * remote-fileio.c: Fix common/ includes.
5100         * regcache.h: Fix common/ includes.
5101         * regcache.c: Fix common/ includes.
5102         * record-btrace.c: Fix common/ includes.
5103         * python/python.c: Fix common/ includes.
5104         * python/py-type.c: Fix common/ includes.
5105         * python/py-inferior.c: Fix common/ includes.
5106         * progspace.h: Fix common/ includes.
5107         * producer.c: Fix common/ includes.
5108         * procfs.c: Fix common/ includes.
5109         * proc-api.c: Fix common/ includes.
5110         * printcmd.c: Fix common/ includes.
5111         * ppc-linux-nat.c: Fix common/ includes.
5112         * parser-defs.h: Fix common/ includes.
5113         * osdata.c: Fix common/ includes.
5114         * obsd-nat.c: Fix common/ includes.
5115         * nat/x86-linux.c: Fix common/ includes.
5116         * nat/x86-linux-dregs.c: Fix common/ includes.
5117         * nat/x86-dregs.h: Fix common/ includes.
5118         * nat/x86-dregs.c: Fix common/ includes.
5119         * nat/ppc-linux.c: Fix common/ includes.
5120         * nat/mips-linux-watch.h: Fix common/ includes.
5121         * nat/mips-linux-watch.c: Fix common/ includes.
5122         * nat/linux-waitpid.c: Fix common/ includes.
5123         * nat/linux-ptrace.h: Fix common/ includes.
5124         * nat/linux-ptrace.c: Fix common/ includes.
5125         * nat/linux-procfs.c: Fix common/ includes.
5126         * nat/linux-personality.c: Fix common/ includes.
5127         * nat/linux-osdata.c: Fix common/ includes.
5128         * nat/linux-namespaces.c: Fix common/ includes.
5129         * nat/linux-btrace.h: Fix common/ includes.
5130         * nat/linux-btrace.c: Fix common/ includes.
5131         * nat/fork-inferior.c: Fix common/ includes.
5132         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5133         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5134         * nat/aarch64-linux.c: Fix common/ includes.
5135         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5136         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5137         * namespace.h: Fix common/ includes.
5138         * mips-linux-tdep.c: Fix common/ includes.
5139         * minsyms.c: Fix common/ includes.
5140         * mi/mi-parse.h: Fix common/ includes.
5141         * mi/mi-main.c: Fix common/ includes.
5142         * mi/mi-cmd-env.c: Fix common/ includes.
5143         * memrange.h: Fix common/ includes.
5144         * memattr.c: Fix common/ includes.
5145         * maint.h: Fix common/ includes.
5146         * maint.c: Fix common/ includes.
5147         * main.c: Fix common/ includes.
5148         * machoread.c: Fix common/ includes.
5149         * location.c: Fix common/ includes.
5150         * linux-thread-db.c: Fix common/ includes.
5151         * linux-nat.c: Fix common/ includes.
5152         * linux-fork.c: Fix common/ includes.
5153         * inline-frame.c: Fix common/ includes.
5154         * infrun.c: Fix common/ includes.
5155         * inflow.c: Fix common/ includes.
5156         * inferior.h: Fix common/ includes.
5157         * inferior.c: Fix common/ includes.
5158         * infcmd.c: Fix common/ includes.
5159         * inf-ptrace.c: Fix common/ includes.
5160         * inf-child.c: Fix common/ includes.
5161         * ia64-linux-nat.c: Fix common/ includes.
5162         * i387-tdep.c: Fix common/ includes.
5163         * i386-tdep.c: Fix common/ includes.
5164         * i386-linux-tdep.c: Fix common/ includes.
5165         * i386-linux-nat.c: Fix common/ includes.
5166         * i386-go32-tdep.c: Fix common/ includes.
5167         * i386-fbsd-tdep.c: Fix common/ includes.
5168         * i386-fbsd-nat.c: Fix common/ includes.
5169         * guile/scm-type.c: Fix common/ includes.
5170         * guile/guile.c: Fix common/ includes.
5171         * go32-nat.c: Fix common/ includes.
5172         * gnu-nat.c: Fix common/ includes.
5173         * gdbthread.h: Fix common/ includes.
5174         * gdbarch-selftests.c: Fix common/ includes.
5175         * gdb_usleep.c: Fix common/ includes.
5176         * gdb_select.h: Fix common/ includes.
5177         * gdb_bfd.c: Fix common/ includes.
5178         * gcore.c: Fix common/ includes.
5179         * fork-child.c: Fix common/ includes.
5180         * findvar.c: Fix common/ includes.
5181         * fbsd-nat.c: Fix common/ includes.
5182         * event-top.c: Fix common/ includes.
5183         * event-loop.c: Fix common/ includes.
5184         * dwarf2read.c: Fix common/ includes.
5185         * dwarf2loc.c: Fix common/ includes.
5186         * dwarf2-frame.c: Fix common/ includes.
5187         * dwarf-index-cache.c: Fix common/ includes.
5188         * dtrace-probe.c: Fix common/ includes.
5189         * disasm-selftests.c: Fix common/ includes.
5190         * defs.h: Fix common/ includes.
5191         * csky-tdep.c: Fix common/ includes.
5192         * cp-valprint.c: Fix common/ includes.
5193         * cp-support.h: Fix common/ includes.
5194         * cp-support.c: Fix common/ includes.
5195         * corelow.c: Fix common/ includes.
5196         * completer.h: Fix common/ includes.
5197         * completer.c: Fix common/ includes.
5198         * compile/compile.c: Fix common/ includes.
5199         * compile/compile-loc2c.c: Fix common/ includes.
5200         * compile/compile-cplus-types.c: Fix common/ includes.
5201         * compile/compile-cplus-symbols.c: Fix common/ includes.
5202         * command.h: Fix common/ includes.
5203         * cli/cli-dump.c: Fix common/ includes.
5204         * cli/cli-cmds.c: Fix common/ includes.
5205         * charset.c: Fix common/ includes.
5206         * build-id.c: Fix common/ includes.
5207         * btrace.h: Fix common/ includes.
5208         * btrace.c: Fix common/ includes.
5209         * breakpoint.h: Fix common/ includes.
5210         * breakpoint.c: Fix common/ includes.
5211         * ax.h:
5212         (enum agent_op): Fix common/ includes.
5213         * ax-general.c (struct aop_map): Fix common/ includes.
5214         * ax-gdb.c: Fix common/ includes.
5215         * auxv.c: Fix common/ includes.
5216         * auto-load.c: Fix common/ includes.
5217         * arm-tdep.c: Fix common/ includes.
5218         * arch/riscv.c: Fix common/ includes.
5219         * arch/ppc-linux-common.c: Fix common/ includes.
5220         * arch/i386.c: Fix common/ includes.
5221         * arch/arm.c: Fix common/ includes.
5222         * arch/arm-linux.c: Fix common/ includes.
5223         * arch/arm-get-next-pcs.c: Fix common/ includes.
5224         * arch/amd64.c: Fix common/ includes.
5225         * arch/aarch64.c: Fix common/ includes.
5226         * arch/aarch64-insn.c: Fix common/ includes.
5227         * arch-utils.c: Fix common/ includes.
5228         * amd64-windows-tdep.c: Fix common/ includes.
5229         * amd64-tdep.c: Fix common/ includes.
5230         * amd64-sol2-tdep.c: Fix common/ includes.
5231         * amd64-obsd-tdep.c: Fix common/ includes.
5232         * amd64-nbsd-tdep.c: Fix common/ includes.
5233         * amd64-linux-tdep.c: Fix common/ includes.
5234         * amd64-linux-nat.c: Fix common/ includes.
5235         * amd64-fbsd-tdep.c: Fix common/ includes.
5236         * amd64-fbsd-nat.c: Fix common/ includes.
5237         * amd64-dicos-tdep.c: Fix common/ includes.
5238         * amd64-darwin-tdep.c: Fix common/ includes.
5239         * agent.c: Fix common/ includes.
5240         * ada-lang.h: Fix common/ includes.
5241         * ada-lang.c: Fix common/ includes.
5242         * aarch64-tdep.c: Fix common/ includes.
5243
5244 2019-01-25  Tom Tromey  <tom@tromey.com>
5245
5246         * common/create-version.sh: Use common/version.h.
5247
5248 2019-01-24  Pedro Alves  <palves@redhat.com>
5249
5250         * infrun.c (signal_stop, signal_print, signal_program)
5251         (signal_catch, signal_pass): Now arrays instead of pointers.
5252         (update_signals_program_target, do_target_resume)
5253         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5254         * linux-nat.c (linux_nat_target::pass_signals)
5255         (linux_nat_target::create_inferior, linux_nat_target::attach):
5256         Adjust.
5257         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5258         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5259         * procfs.c (procfs_target::pass_signals): Adjust.
5260         * record-full.c (record_full_target::resume): Adjust.
5261         * remote.c (remote_target::pass_signals)
5262         (remote_target::program_signals): Adjust.
5263         * target-debug.h (target_debug_print_signals): Now takes a
5264         gdb::array_view as parameter.  Adjust.
5265         * target.h (target_ops) <pass_signals, program_signals>: Replace
5266         pointer and length parameters with gdb::array_view.
5267         (target_pass_signals, target_program_signals): Likewise.
5268         * target-delegates.c: Regenerate.
5269
5270 2019-01-24  Pedro Alves  <palves@redhat.com>
5271
5272         * common/forward-scope-exit.h
5273         (forward_scope_exit::forward_scope_exit): Pass arguments to
5274         m_bind_function directly, instead of creating a std::bind and
5275         copying that.
5276
5277 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5278
5279         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5280         for static members.
5281         (pass_in_v_vfp_candidate): Likewise.
5282
5283 2019-01-23  Tom Tromey  <tom@tromey.com>
5284             Pedro Alves  <palves@redhat.com>
5285
5286         * regcache.c (class regcache_invalidator): Remove.
5287         (regcache::raw_write): Use make_scope_exit.
5288
5289 2019-01-23  Tom Tromey  <tom@tromey.com>
5290
5291         * ui-out.h (class ui_out_emit_type): Update comment.
5292
5293 2019-01-23  Tom Tromey  <tom@tromey.com>
5294
5295         * infrun.c (fetch_inferior_event): Update comment.
5296
5297 2019-01-23  Tom Tromey  <tom@tromey.com>
5298             Pedro Alves  <palves@redhat.com>
5299
5300         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5301         parameter.
5302         (fetch_inferior_event): Use SCOPE_EXIT.
5303
5304
5305 2019-01-23  Tom Tromey  <tom@tromey.com>
5306             Pedro Alves  <palves@redhat.com>
5307
5308         * infrun.c (disable_thread_events): Delete.
5309         (stop_all_threads): Use SCOPE_EXIT.
5310
5311 2019-01-23  Tom Tromey  <tom@tromey.com>
5312             Pedro Alves  <palves@redhat.com>
5313
5314         * symfile.c: Include forward-scope-exit.h.
5315         (clear_symtab_users_cleanup): Replace forward declaration with
5316         a FORWARD_SCOPE_EXIT.
5317         (syms_from_objfile_1): Use the forward_scope_exit and
5318         gdb::optional instead of cleanup_function.
5319         (reread_symbols): Use the forward_scope_exit instead of
5320         cleanup_function.
5321         (clear_symtab_users_cleanup): Remove function.
5322
5323 2019-01-23  Tom Tromey  <tom@tromey.com>
5324             Pedro Alves  <palves@redhat.com>
5325
5326         * linux-nat.c: Include scope-exit.h.
5327         (cleanup_target_stop): Remove.
5328         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5329         SCOPE_EXIT.
5330
5331 2019-01-23  Tom Tromey  <tom@tromey.com>
5332             Pedro Alves  <palves@redhat.com>
5333
5334         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5335         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5336
5337 2019-01-23  Tom Tromey  <tom@tromey.com>
5338             Andrew Burgess  <andrew.burgess@embecosm.com>
5339             Pedro Alves  <palves@redhat.com>
5340
5341         * infrun.c (fetch_inferior_event): Use scope_exit.
5342         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5343         * top.c (execute_command): Use scope_exit.
5344         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5345         * utils.c (do_bpstat_clear_actions_cleanup)
5346         (make_bpstat_clear_actions_cleanup): Remove.
5347
5348 2019-01-23  Tom Tromey  <tom@tromey.com>
5349             Pedro Alves  <palves@redhat.com>
5350
5351         * infrun.c: Include "common/scope-exit.h"
5352         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5353         (wait_for_inferior): Use SCOPE_EXIT.
5354         (fetch_inferior_event): Use scope_exit.
5355
5356 2019-01-23  Tom Tromey  <tom@tromey.com>
5357             Pedro Alves  <palves@redhat.com>
5358
5359         * breakpoint.c (create_breakpoint): Remove cleanup.
5360
5361 2019-01-23  Tom Tromey  <tom@tromey.com>
5362             Andrew Burgess  <andrew.burgess@embecosm.com>
5363             Pedro Alves  <palves@redhat.com>
5364
5365 2019-01-23  Pedro Alves  <palves@redhat.com>
5366
5367         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5368
5369 2019-01-23  Pedro Alves  <palves@redhat.com>
5370             Andrew Burgess  <andrew.burgess@embecosm.com>
5371
5372         * gdbthread.h: Include "common/forward-scope-exit.h".
5373         (scoped_finish_thread_state): Redefine custom class in terms of
5374         forward_scope_exit.
5375
5376 2019-01-23  Pedro Alves  <palves@redhat.com>
5377             Andrew Burgess  <andrew.burgess@embecosm.com>
5378
5379         * common/forward-scope-exit.h: New file.
5380
5381 2019-01-23  Pedro Alves  <palves@redhat.com>
5382             Andrew Burgess  <andrew.burgess@embecosm.com>
5383             Tom Tromey  <tom@tromey.com>
5384
5385         * common/scope-exit.h: New file.
5386
5387 2019-01-23  Pedro Alves  <palves@redhat.com>
5388
5389         * common/preprocessor.h (ESC): Rename to ...
5390         (ESC_PARENS): ... this.
5391         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5392         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5393
5394 2019-01-23  Tom Tromey  <tom@tromey.com>
5395
5396         * language.h (class scoped_switch_to_sym_language_if_auto):
5397         Initialize m_lang in both cases.
5398
5399 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5400
5401         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5402         with XCNEW.
5403
5404 2019-01-22  Tom Tromey  <tom@tromey.com>
5405
5406         * corelow.c: Do not include sys/file.h.
5407
5408 2019-01-22  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui-wingeneral.h: Include gdb_curses.h.
5411
5412 2019-01-22  Tom Tromey  <tom@tromey.com>
5413
5414         * source-cache.h (class source_cache) <get_source_lines,
5415         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5416
5417 2019-01-22  Tom Tromey  <tom@tromey.com>
5418
5419         * remote-fileio.h (struct remote_target): Declare.
5420
5421 2019-01-22  Tom Tromey  <tom@tromey.com>
5422
5423         * python/py-arch.c: Do not include py-ref.h.
5424         * python/py-bpevent.c: Do not include py-ref.h.
5425         * python/py-cmd.c: Do not include py-ref.h.
5426         * python/py-continueevent.c: Do not include py-ref.h.
5427         * python/py-event.h: Do not include py-ref.h.
5428         * python/py-evtregistry.c: Do not include py-ref.h.
5429         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5430         * python/py-frame.c: Do not include py-ref.h.
5431         * python/py-framefilter.c: Do not include py-ref.h.
5432         * python/py-function.c: Do not include py-ref.h.
5433         * python/py-infevents.c: Do not include py-ref.h.
5434         * python/py-linetable.c: Do not include py-ref.h.
5435         * python/py-objfile.c: Do not include py-ref.h.
5436         * python/py-param.c: Do not include py-ref.h.
5437         * python/py-prettyprint.c: Do not include py-ref.h.
5438         * python/py-progspace.c: Do not include py-ref.h.
5439         * python/py-symbol.c: Do not include py-ref.h.
5440         * python/py-symtab.c: Do not include py-ref.h.
5441         * python/py-type.c: Do not include py-ref.h.
5442         * python/py-unwind.c: Do not include py-ref.h.
5443         * python/py-utils.c: Do not include py-ref.h.
5444         * python/py-value.c: Do not include py-ref.h.
5445         * python/py-varobj.c: Do not include py-ref.h.
5446         * python/py-xmethods.c: Do not include py-ref.h.
5447         * python/python.c: Do not include py-ref.h.
5448         * varobj.c: Do not include py-ref.h.
5449
5450 2019-01-22  Tom Tromey  <tom@tromey.com>
5451
5452         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5453         keyword for bcache.
5454
5455 2019-01-22  Tom Tromey  <tom@tromey.com>
5456
5457         * compile/compile-cplus-types.c: Remove a comment by #include.
5458
5459 2019-01-22  Tom Tromey  <tom@tromey.com>
5460
5461         * compile/gcc-c-plugin.h: Include compile-internal.h.
5462
5463 2019-01-22  Tom Tromey  <tom@tromey.com>
5464
5465         * stabsread.c (EXTERN): Do not define.
5466         (symnum, next_symbol_text_func, processing_gcc_compilation)
5467         (within_function, global_sym_chain, global_stabs)
5468         (previous_stab_code, this_object_header_files)
5469         (n_this_object_header_files)
5470         (n_allocated_this_object_header_files): Define.
5471         * stabsread.h (EXTERN): Never define.  Use "extern".
5472
5473 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5474
5475         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5476         history_value.
5477
5478 2019-01-21  Tom Tromey  <tom@tromey.com>
5479
5480         * ui-out.c: Fix includes.
5481         * tui/tui-source.c: Fix includes.
5482         * target.c: Fix includes.
5483         * remote.c: Fix includes.
5484         * regcache.c: Fix includes.
5485         * python/py-block.c: Fix includes.
5486         * printcmd.c: Fix includes.
5487         * or1k-tdep.c: Fix includes.
5488         * mi/mi-main.c: Fix includes.
5489         * m32r-tdep.c: Fix includes.
5490         * csky-tdep.c: Fix includes.
5491         * compile/compile-cplus-types.c: Fix includes.
5492         * cli/cli-interp.c: Fix includes.
5493
5494 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5495
5496         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5497         for padding.
5498
5499 2019-01-16  Tom Tromey  <tom@tromey.com>
5500
5501         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5502         earlier.
5503         (struct objfile) <msymbols_range>: Move from top level.
5504         <msymbols>: New method.
5505         (class objfile_msymbols): Remove.
5506         * symtab.c (default_collect_symbol_completion_matches_break_on):
5507         Update.
5508         * symmisc.c (dump_msymbols): Update.
5509         * stabsread.c (scan_file_globals): Update.
5510         * objc-lang.c (info_selectors_command, info_classes_command)
5511         (find_methods): Update.
5512         * minsyms.c (find_solib_trampoline_target): Update.
5513         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5514         * coffread.c (coff_symfile_read): Update.
5515         * ada-lang.c (ada_lookup_simple_minsym)
5516         (ada_collect_symbol_completion_matches): Update.
5517
5518 2019-01-16  Tom Tromey  <tom@tromey.com>
5519
5520         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5521         type.  Remove no-argument constructor.
5522         <iterator::operator++>: Simplify.
5523         <begin>: Update.
5524         <end>: Use minimal_symbol_count.
5525
5526 2019-01-16  Tom Tromey  <tom@tromey.com>
5527
5528         * objfiles.h (struct objfile) <psymtabs>: New method.
5529         (class objfile_psymtabs): Remove.
5530         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5531         typedef.
5532         <range>: New method.
5533         (require_partial_symbols): Change return type.
5534         * psymtab.c (require_partial_symbols)
5535         (psym_expand_symtabs_matching): Update.
5536         * mdebugread.c (parse_partial_symbols): Update.
5537         * dbxread.c (dbx_end_psymtab): Update.
5538
5539 2019-01-15  Tom Tromey  <tom@tromey.com>
5540
5541         * symtab.c (lookup_objfile_from_block)
5542         (lookup_symbol_in_objfile_symtabs)
5543         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5544         (find_line_symtab, info_sources_command)
5545         (default_collect_symbol_completion_matches_break_on)
5546         (make_source_files_completion_list): Update.
5547         * symmisc.c (print_objfile_statistics, dump_objfile)
5548         (maintenance_print_symbols, maintenance_info_symtabs)
5549         (maintenance_check_symtabs, maintenance_info_line_tables):
5550         Update.
5551         * source.c (select_source_symtab)
5552         (forget_cached_source_info_for_objfile): Update.
5553         * objfiles.h (class objfile_compunits): Remove.
5554         (struct objfile) <compunits_range>: New typedef.
5555         (compunits): New method.
5556         * objfiles.c (objfile_relocate1): Update.
5557         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5558         * maint.c (count_symtabs_and_blocks): Update.
5559         * linespec.c (iterate_over_all_matching_symtabs): Update.
5560         * cp-support.c (add_symbol_overload_list_qualified): Update.
5561         * coffread.c (coff_symtab_read): Update.
5562         * ada-lang.c (add_nonlocal_symbols)
5563         (ada_collect_symbol_completion_matches)
5564         (ada_add_global_exceptions): Update.
5565
5566 2019-01-15  Tom Tromey  <tom@tromey.com>
5567
5568         * progspace.h (program_space) <objfiles_safe_range>: New
5569         typedef.
5570         <objfiles_safe>: New method.
5571         * objfiles.h (class all_objfiles_safe): Remove.
5572         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5573         * jit.c (jit_inferior_exit_hook): Update.
5574
5575 2019-01-17  Tom Tromey  <tom@tromey.com>
5576
5577         * progspace.h (program_space) <objfiles_range>: New typedef.
5578         <objfiles>: New method.
5579         <objfiles_head>: Rename from objfiles.
5580         (object_files): Update.
5581         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5582         * guile/scm-pretty-print.c
5583         (ppscm_find_pretty_printer_from_objfiles): Update.
5584         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5585         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5586         Update.
5587         * python/py-progspace.c (pspy_get_objfiles): Update.
5588         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5589         Update.
5590         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5591         (objfpy_lookup_objfile_by_build_id): Update.
5592         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5593         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5594         Update.
5595         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5596         (expand_symtab_containing_pc, lookup_objfile_from_block)
5597         (lookup_static_symbol, basic_lookup_transparent_type)
5598         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5599         (find_line_symtab, info_sources_command)
5600         (default_collect_symbol_completion_matches_break_on)
5601         (make_source_files_completion_list, find_main_name): Update.
5602         * symmisc.c (print_symbol_bcache_statistics)
5603         (print_objfile_statistics, maintenance_print_symbols)
5604         (maintenance_print_msymbols, maintenance_print_objfiles)
5605         (maintenance_info_symtabs, maintenance_check_symtabs)
5606         (maintenance_expand_symtabs, maintenance_info_line_tables):
5607         Update.
5608         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5609         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5610         (map_overlay_command, unmap_overlay_command)
5611         (simple_overlay_update, expand_symtabs_matching)
5612         (map_symbol_filenames): Update.
5613         * symfile-debug.c (set_debug_symfile): Update.
5614         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5615         Update.
5616         * source.c (select_source_symtab, forget_cached_source_info):
5617         Update.
5618         * solib.c (solib_read_symbols): Update.
5619         * solib-spu.c (append_ocl_sos): Update.
5620         * psymtab.c (maintenance_print_psymbols)
5621         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5622         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5623         * printcmd.c (info_symbol_command): Update.
5624         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5625         Update.
5626         * objfiles.h (class all_objfiles): Remove.
5627         * objfiles.c (have_partial_symbols, have_full_symbols)
5628         (have_minimal_symbols, qsort_cmp, update_section_map)
5629         (shared_objfile_contains_address_p)
5630         (default_iterate_over_objfiles_in_search_order): Update.
5631         * objc-lang.c (info_selectors_command, info_classes_command)
5632         (find_methods): Update.
5633         * minsyms.c (find_solib_trampoline_target): Update.
5634         * maint.c (maintenance_info_sections)
5635         (maintenance_translate_address, count_symtabs_and_blocks):
5636         Update.
5637         * main.c (captured_main_1): Update.
5638         * linux-thread-db.c (try_thread_db_load_from_pdir)
5639         (has_libpthread): Update.
5640         * linespec.c (iterate_over_all_matching_symtabs)
5641         (search_minsyms_for_name): Update.
5642         * jit.c (jit_find_objf_with_entry_addr): Update.
5643         * hppa-tdep.c (find_unwind_entry)
5644         (hppa_lookup_stub_minimal_symbol): Update.
5645         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5646         Update.
5647         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5648         (elf_gnu_ifunc_resolve_by_got): Update.
5649         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5650         * dwarf-index-write.c (save_gdb_index_command): Update.
5651         * cp-support.c (add_symbol_overload_list_qualified): Update.
5652         * breakpoint.c (create_overlay_event_breakpoint)
5653         (create_longjmp_master_breakpoint)
5654         (create_std_terminate_master_breakpoint)
5655         (create_exception_master_breakpoint): Update.
5656         * blockframe.c (find_pc_partial_function): Update.
5657         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5658         (ada_collect_symbol_completion_matches)
5659         (ada_add_global_exceptions): Update.
5660
5661 2019-01-17  Tom Tromey  <tom@tromey.com>
5662
5663         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5664         declare VEC.
5665         (solib_target_parse_libraries): Change return type.
5666         (library_list_start_segment, library_list_start_section)
5667         (library_list_end_library, library_list_start_library); Update.
5668         (solib_target_free_library_list): Remove.
5669         (solib_target_parse_libraries): Remove cleanup.  Change return
5670         type.
5671         (solib_target_current_sos): Update.
5672
5673 2019-01-17  Tom Tromey  <tromey@bapiya>
5674
5675         * valprint.c: Replace "the the" with "the".
5676         * symtab.c: Replace "the the" with "the".
5677         * solib.c: Replace "the the" with "the".
5678         * solib-dsbt.c: Replace "the the" with "the".
5679         * linespec.c: Replace "the the" with "the".
5680         * dwarf2loc.h: Replace "the the" with "the".
5681         * amd64-windows-tdep.c: Replace "the the" with "the".
5682         * aarch64-tdep.c: Replace "the the" with "the".
5683
5684 2019-01-16  Keith Seitz  <keiths@redhat.com>
5685
5686         PR gdb/23773
5687         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5688         <builder>: Rename to ..
5689         <m_builder>: ... this and make private.
5690         (dwarf2_cu::get_builder): New method.  Change all users of
5691         `builder' to use this method.
5692         (dwarf2_start_symtab): Move to ...
5693         (dwarf2_cu::start_symtab): ... here.  Update all callers
5694         (setup_type_unit_groups): Move to ...
5695         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5696         callers.
5697         (dwarf2_cu::reset_builder): New method.
5698         (process_full_compunit, process_full_type_unit): Use
5699         dwarf2_cu::reset_builder.
5700         (follow_die_offset): Record the ancestor CU if it is different
5701         from the followed DIE's CU.
5702         (follow_die_sig_1): Likewise.
5703
5704 2019-01-15  Tom Tromey  <tom@tromey.com>
5705
5706         * remote.c (class remote_state) <buf>: Now a char_vector.
5707         <buf_size>: Remove.
5708         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5709         parameter.
5710         (remote_target::getpkt_or_notif_sane_1)
5711         (remote_target::getpkt_sane)
5712         (remote_target::getpkt_or_notif_sane): Likewise.
5713         (class remote_target) <putpkt>: New overload.
5714         (remote_target::read_frame): Change type of "buf_p".  Remove
5715         sizeof_p parameter.
5716         (packet_ok): New overload.
5717         (packet_check_result): New overload.
5718         Update all uses.
5719
5720 2019-01-14  Tom Tromey  <tom@tromey.com>
5721
5722         * remote-notif.c (handle_notification, remote_notif_ack)
5723         (remote_notif_parse): Make "buf" const.
5724         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5725         const.
5726         (remote_notif_parse, remote_notif_ack, handle_notification):
5727         Likewise.
5728         * remote.c (remote_notif_stop_parse): Make "buf" const.
5729         (remote_target::remote_parse_stop_reply): Make "buf" const.
5730         (remote_notif_stop_ack): Make "buf" const.
5731
5732 2019-01-14  Tom Tromey  <tom@tromey.com>
5733
5734         * remote.c (remote_console_output): Make parameter const.
5735
5736 2019-01-14  Tom Tromey  <tom@tromey.com>
5737
5738         * target-debug.h (target_debug_print_signals): Constify.
5739         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5740         * procfs.c (procfs_target::pass_signals): Update.
5741         * linux-nat.c (linux_nat_target::pass_signals): Update.
5742         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5743         * target-delegates.c: Rebuild.
5744         * remote.c (remote_target::program_signals): Update.
5745         (remote_target::pass_signals): Update.
5746         * target.c (target_pass_signals): Constify argument.
5747         (target_program_signals): Likewise.
5748         * target.h (struct target_ops) <pass_signals, program_signals>:
5749         Constify argument.
5750         (target_pass_signals, target_program_signals): Constify argument.
5751
5752 2019-01-14  Tom Tromey  <tom@tromey.com>
5753
5754         PR tui/28819:
5755         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5756
5757 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5758
5759         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5760         field.
5761         * rs6000-tdep.c: Include reggroups.h.
5762         (IS_V_ALIAS_PSEUDOREG): Define.
5763         (rs6000_register_name): Return names for the "vX" aliases.
5764         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5765         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5766         aliases.  Call default_register_reggroup_p for all other
5767         pseudo-registers.
5768         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5769         New functions.
5770         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5771         Handle "vX" aliases.
5772         (v_alias_pseudo_register_collect): New function.
5773         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5774         (rs6000_gdbarch_init): Initialize "vX" aliases as
5775         pseudo-registers.  Restore registration of
5776         rs6000_pseudo_register_reggroup_p with
5777         set_tdesc_pseudo_register_reggroup_p.
5778
5779 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5780
5781         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5782         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5783         set_gdbarch_num_pseudo_regs.
5784
5785 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5786
5787         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5788         Remove arg prefixname, add do_set and do_show.
5789         Add member functions set_list and show_list.
5790         * cli/cli-style.c (class cli_style_option): Update accordingly.
5791         (style_set_list): Move to file scope.
5792         (style_show_list): Likewise.
5793         (set_style): Call help_list.
5794         (show_style): Call cmd_show_list.
5795         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5796         Update to use the new macro.
5797
5798 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5799
5800         * ada-lang.c (_initialize_ada_language): Expand the help text
5801         for the "catch exception" command.
5802
5803 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5804
5805         * symtab.c (matching_obj_sections): Initialize obj,
5806         declare it closer to its usage.
5807
5808 2019-01-10  Tom Tromey  <tom@tromey.com>
5809
5810         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5811         (basic_inf_threads_range): Remove.
5812         (inf_threads_range, inf_non_exited_threads_range)
5813         (safe_inf_threads_range): Use next_adapter.
5814
5815 2019-01-10  Keith Seitz  <keiths@redhat.com>
5816
5817         PR gdb/23712
5818         PR symtab/23010
5819         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5820         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5821
5822 2019-01-10  Keith Seitz  <keiths@redhat.com>
5823
5824         PR gdb/23712
5825         PR symtab/23010
5826         * dictionary.c (pending_to_vector): Remove.
5827         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5828         Remove _1 suffix, replacing functions of the same name.  Update
5829         all callers.
5830         (dict_create_hashed, dict_create_hashed_expandable)
5831         (dict_create_linear, dict_create_linear_expandable, dict_free)
5832         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5833         Make functions static.
5834
5835 2019-01-10  Keith Seitz  <keiths@redhat.com>
5836
5837         PR gdb/23712
5838         PR symtab/23010
5839         * dictionary.h (struct dictionary): Replace declaration with
5840         multidictionary.
5841         (dict_create_hashed, dict_create_hashed_expandable)
5842         (dict_create_linear, dict_create_linear_expandable)
5843         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5844         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5845         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5846         taking multidictionary argument.
5847         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5848         * block.h (struct block) <dict>: Change to multidictionary
5849         and rename `multidict'.
5850         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5851         symmisc.c: Update all dictionary references to multidictionary.
5852
5853 2019-01-10  Keith Seitz  <keiths@redhat.com>
5854
5855         PR gdb/23712
5856         PR symtab/23010
5857         * dictionary.c: Include unordered_map.
5858         (pending_to_vector): New function.
5859         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5860         Rewrite the non-"_1" functions to take vector instead
5861         of linked list.
5862         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5863         "new" _1 versions of the same name.
5864         (multidictionary): Define.
5865         (std::hash<enum language): New definition.
5866         (collate_pending_symbols_by_language, mdict_create_hashed)
5867         (mdict_create_hashed_expandable, mdict_create_linear)
5868         (mdict_create_linear_expandable, mdict_free)
5869         (find_language_dictionary, create_new_language_dictionary)
5870         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5871         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5872         (mdict_size, mdict_empty): New functions.
5873         * dictionary.h (mdict_iterator): Define.
5874
5875 2019-01-10  Pedro Alves  <palves@redhat.com>
5876
5877         * breakpoint.c (read_uploaded_action)
5878         (create_tracepoint_from_upload): Adjust to use
5879         gdb::unique_xmalloc_ptr.
5880         * ctf.c (ctf_write_uploaded_tp):
5881         (SET_ARRAY_FIELD): Use emplace_back.
5882         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5883         * tracefile-tfile.c (tfile_write_uploaded_tp):
5884         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5885         gdb::unique_xmalloc_ptr.
5886         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5887         at_string, cond_string, cmd_strings>: Replace char pointers
5888         with gdb::unique_xmalloc_ptr.
5889
5890 2019-01-10  Pedro Alves  <palves@redhat.com>
5891
5892         * solib-target.c (library_list_start_library): Don't xstrdup name.
5893
5894 2019-01-10  Pedro Alves  <palves@redhat.com>
5895
5896         * mdebugread.c (parse_partial_symbols): Use
5897         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5898
5899 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5900
5901         * linux-fork.c (scoped_switch_fork_info)
5902         <~scoped_switch_fork_info>: Fix incorrect variable name.
5903
5904 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5905
5906         * linux-fork.c (scoped_switch_fork_info)
5907         <scoped_switch_fork_info>: Make explicit.
5908         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5909
5910 2019-01-10  Tom Tromey  <tom@tromey.com>
5911
5912         * objfiles.h (objfile::reset_psymtabs): Update.
5913         * objfiles.c (objfile::objfile): Update.
5914         * psymtab.h (psymtab_storage::obstack): Update.
5915         (psymtab_storage::m_obstack): Use gdb::optional.
5916         (class psymtab_storage): Update comment.  Remove objfile
5917         parameter.
5918         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5919
5920 2019-01-10  Tom Tromey  <tom@tromey.com>
5921
5922         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5923         <free_psymtabs>: Now private.
5924         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5925         (allocate_psymtab): Use new method.
5926
5927 2019-01-10  Tom Tromey  <tom@tromey.com>
5928
5929         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5930         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5931         * mdebugread.c (parse_partial_symbols): Use
5932         allocate_dependencies.
5933         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5934         allocate_dependencies.
5935         (process_psymtab_comp_unit_reader)
5936         (build_type_psymtab_dependencies): Likewise.
5937         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5938
5939 2019-01-10  Tom Tromey  <tom@tromey.com>
5940
5941         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5942         PSYMBOL_SET_LANGUAGE.
5943         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5944
5945 2019-01-10  Tom Tromey  <tom@tromey.com>
5946
5947         * psymtab.h (psymtab_storage::obstack): New method.
5948         <m_obstack>: Rename from obstack; now private.
5949         * psymtab.c (psymtab_storage): Update.
5950         * dwarf2read.c (create_addrmap_from_index)
5951         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5952         Update.
5953
5954 2019-01-10  Tom Tromey  <tom@tromey.com>
5955
5956         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5957         * objfiles.h (objfile::reset_psymtabs): New method.
5958
5959 2019-01-10  Tom Tromey  <tom@tromey.com>
5960
5961         * symmisc.c (print_symbol_bcache_statistics): Update.
5962         (print_objfile_statistics): Update.
5963         * symfile.c (reread_symbols): Update.
5964         * psymtab.h (class psymtab_storage): New.
5965         * psymtab.c (psymtab_storage): New constructor.
5966         (~psymtab_storage): New destructor.
5967         (require_partial_symbols): Update.
5968         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5969         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5970         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5971         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5972         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5973         (start_psymtab_common, end_psymtab_common)
5974         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5975         (allocate_psymtab): Update.
5976         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5977         Update.
5978         (dump_psymtab_addrmap, maintenance_print_psymbols)
5979         (maintenance_check_psymtabs): Update.
5980         (class objfile_psymtabs): Move to objfiles.h.
5981         * psympriv.h (discard_psymtab): Now inline.
5982         (psymtab_discarder::psymtab_discarder): Update.
5983         (psymtab_discarder::~psymtab_discarder): Update.
5984         (ALL_OBJFILE_PSYMTABS): Rewrite.
5985         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5986         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5987         Remove fields.
5988         <partial_symtabs>: New field.
5989         (class objfile_psymtabs): Move from psymtab.h.  Update.
5990         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5991         psymbol_cache.
5992         (objfile::~objfile): Don't destroy psymbol_cache.
5993         * mdebugread.c (parse_partial_symbols): Update.
5994         * dwarf2read.c (create_addrmap_from_index)
5995         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5996         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5997         (add_partial_subprogram, dwarf2_ranges_read): Update.
5998         * dwarf-index-write.c (write_address_map)
5999         (write_one_signatured_type, recursively_write_psymbols)
6000         (class debug_names, class debug_names, write_psymtabs_to_index):
6001         Update.
6002
6003 2019-01-10  Tom Tromey  <tom@tromey.com>
6004
6005         * symtab.h (SYMBOL_SET_NAMES): Update.
6006         (symbol_set_names): Update.
6007         (MSYMBOL_SET_NAMES): Update.
6008         * symtab.c (symbol_set_names): Change argument to be an
6009         objfile_per_bfd_storage.
6010         * psymtab.c (add_psymbol_to_bcache): Update.
6011         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6012
6013 2019-01-10  Tom Tromey  <tom@tromey.com>
6014
6015         * symtab.c (create_demangled_names_hash): Change argument to be an
6016         objfile_per_bfd_storage.
6017         (symbol_set_names): Update.
6018
6019 2019-01-10  Tom Tromey  <tom@tromey.com>
6020
6021         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6022         init_psymbol_list.
6023         * psymtab.c (init_psymbol_list): Do nothing if already called.
6024         * psympriv.h (init_psymbol_list): Add comment.
6025         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6026         init_psymbol_list.
6027         * dbxread.c (dbx_symfile_read): Unconditionally call
6028         init_psymbol_list.
6029
6030 2019-01-10  Tom Tromey  <tom@tromey.com>
6031
6032         * xcoffread.c (scan_xcoff_symtab): Update.
6033         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6034         "where".
6035         * mdebugread.c (parse_partial_symbols)
6036         (handle_psymbol_enumerators): Update.
6037         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6038         * dbxread.c (read_dbx_symtab): Update.
6039         * psympriv.h (psymbol_placement): New enum.
6040         (add_psymbol_to_list): Update.
6041
6042 2019-01-10  Tom Tromey  <tom@tromey.com>
6043
6044         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6045         static_psymbols parameters.
6046         (scan_xcoff_symtab): Update.
6047         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6048         static_psymbols parameters.
6049         * psympriv.h (start_psymtab_common): Update.
6050         * mdebugread.c (parse_partial_symbols): Update.
6051         * dwarf2read.c (create_partial_symtab): Update.
6052         * dbxread.c (read_dbx_symtab): Update.
6053         (start_psymtab): Remove global_psymbols and static_psymbols
6054         parameters.
6055
6056 2019-01-10  Tom Tromey  <tom@tromey.com>
6057
6058         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6059         * psymtab.c (allocate_psymtab): Add comment.
6060         * psympriv.h (allocate_psymtab): Add comment.
6061         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6062         initializations.
6063         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6064
6065 2019-01-10  Tom Tromey  <tom@tromey.com>
6066
6067         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6068         Don't declare.
6069         * mipsread.c: Include mdebugread.h.
6070         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6071         Declare.
6072         * elfread.c: Include mdebugread.h.
6073
6074 2019-01-09  Tom Tromey  <tom@tromey.com>
6075
6076         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6077         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6078         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6079         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6080         (psym_lookup_symbol, psym_find_last_source_symtab)
6081         (psym_forget_cached_source_info, psym_print_stats)
6082         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6083         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6084         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6085         (psym_find_compunit_symtab_by_address)
6086         (maintenance_print_psymbols, maintenance_info_psymtabs)
6087         (maintenance_check_psymtabs): Use ranged for.
6088         * psymtab.h (class objfile_psymtabs): New.
6089         (require_partial_symbols): Return objfile_psymtabs.
6090         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6091
6092 2019-01-09  Tom Tromey  <tom@tromey.com>
6093
6094         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6095         (find_pc_mapped_section, list_overlays_command)
6096         (map_overlay_command, unmap_overlay_command)
6097         (simple_overlay_update): Use all_objfiles.
6098         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6099         * printcmd.c (info_symbol_command): Use all_objfiles.
6100         * objfiles.h (ALL_OBJSECTIONS): Remove.
6101         * maint.c (maintenance_translate_address): Use all_objfiles.
6102         * gcore.c (gcore_create_callback): Use all_objfiles.
6103         (objfile_find_memory_regions): Likewise.
6104
6105 2019-01-09  Tom Tromey  <tom@tromey.com>
6106
6107         * symtab.c (find_line_symtab, info_sources_command)
6108         (make_source_files_completion_list): Use objfile_compunits.
6109         * source.c (select_source_symtab): Use objfile_compunits.
6110         * objfiles.h (struct objfile): Update comment.
6111         (ALL_OBJFILES): Remove.
6112         (ALL_FILETABS): Remove.
6113         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6114         objfile_compunits.
6115
6116 2019-01-09  Tom Tromey  <tom@tromey.com>
6117
6118         * symmisc.c (print_objfile_statistics, dump_objfile)
6119         (maintenance_print_symbols): Use compunit_filetabs.
6120         * source.c (forget_cached_source_info_for_objfile): Use
6121         compunit_filetabs.
6122         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6123         (ALL_FILETABS): Use compunit_filetabs.
6124         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6125         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6126
6127 2019-01-09  Tom Tromey  <tom@tromey.com>
6128
6129         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6130         (compunit_filetabs): New.
6131         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6132         compunit_filetabs.
6133         (info_sources_command, make_source_files_completion_list): Remove
6134         declaration.
6135         * symmisc.c (print_objfile_statistics, dump_objfile)
6136         (maintenance_print_symbols): Remove declaration.
6137         (maintenance_info_symtabs): Use compunit_filetabs.
6138         (maintenance_info_line_tables): Likewise.
6139         * source.c (select_source_symtab): Change local variable name.
6140         (forget_cached_source_info_for_objfile): Remove declaration.
6141         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6142         * objfiles.c (objfile_relocate1): Remove declaration.
6143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6144         declaration.
6145         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6146         * coffread.c (coff_symtab_read): Remove declaration.
6147         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6148         compunit_filetabs.
6149
6150 2019-01-09  Tom Tromey  <tom@tromey.com>
6151
6152         * symtab.c (lookup_objfile_from_block)
6153         (find_pc_sect_compunit_symtab, search_symbols)
6154         (default_collect_symbol_completion_matches_break_on): Use
6155         objfile_compunits.
6156         * objfiles.h (ALL_COMPUNITS): Remove.
6157         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6158         * cp-support.c (add_symbol_overload_list_qualified): Use
6159         objfile_compunits.
6160         * ada-lang.c (ada_collect_symbol_completion_matches)
6161         (ada_add_global_exceptions): Use objfile_compunits.
6162
6163 2019-01-09  Tom Tromey  <tom@tromey.com>
6164
6165         * source.c (select_source_symtab)
6166         (forget_cached_source_info_for_objfile): Remove declaration.
6167         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6168         declaration.
6169         * maint.c (count_symtabs_and_blocks): Remove declaration.
6170         * cp-support.c (add_symbol_overload_list_qualified): Remove
6171         declaration.
6172         * coffread.c (coff_symtab_read): Remove declaration.
6173         * symtab.c (lookup_symbol_in_objfile_symtabs)
6174         (basic_lookup_transparent_type_1): Use objfile_compunits.
6175         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6176         (info_sources_command, search_symbols)
6177         (default_collect_symbol_completion_matches_break_on)
6178         (make_source_files_completion_list): Remove declaration.
6179         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6180         (ada_collect_symbol_completion_matches)
6181         (ada_add_global_exceptions): Remove declaration.
6182         * linespec.c (iterate_over_all_matching_symtabs): Use
6183         objfile_compunits.
6184         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6185         (class objfile_compunits): New.
6186         (ALL_COMPUNITS): Use objfile_compunits.
6187         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6188         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6189         objfile_compunits.
6190         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6191
6192 2019-01-09  Tom Tromey  <tom@tromey.com>
6193
6194         * symtab.c (search_symbols)
6195         (default_collect_symbol_completion_matches_break_on): Use
6196         objfile_msymbols.
6197         * ada-lang.c (ada_lookup_simple_minsym)
6198         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6199         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6200         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6201         objfile_msymbols.
6202         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6203         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6204         * objc-lang.c (find_methods): Use objfile_msymbols.
6205         (info_selectors_command, info_classes_command): Likewise.
6206         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6207         * objfiles.h (class objfile_msymbols): New.
6208         (ALL_OBJFILE_MSYMBOLS): Remove.
6209         (ALL_MSYMBOLS): Remove.
6210
6211 2019-01-09  Tom Tromey  <tom@tromey.com>
6212
6213         * common/next-iterator.h (next_adapter): Add Iterator template
6214         parameter.
6215         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6216         (class all_objfiles_safe): New.
6217         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6218         * objfiles.c (put_objfile_before): Update comment.
6219         (add_separate_debug_objfile): Likewise.
6220         (free_all_objfiles): Use all_objfiles_safe.
6221         (objfile_purge_solibs): Likewise.
6222
6223 2019-01-09  Tom Tromey  <tom@tromey.com>
6224
6225         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6226         (expand_symtab_containing_pc, lookup_static_symbol)
6227         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6228         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6229         all_objfiles.
6230         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6231         * breakpoint.c (create_overlay_event_breakpoint)
6232         (create_longjmp_master_breakpoint)
6233         (create_std_terminate_master_breakpoint)
6234         (create_exception_master_breakpoint): Use all_objfiles.
6235         * linux-thread-db.c (try_thread_db_load_from_pdir)
6236         (has_libpthread): Use all_objfiles.
6237         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6238         * linespec.c (iterate_over_all_matching_symtabs)
6239         (search_minsyms_for_name): Use all_objfiles.
6240         * maint.c (maintenance_info_sections): Use all_objfiles.
6241         * main.c (captured_main_1): Use all_objfiles.
6242         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6243         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6244         * guile/scm-pretty-print.c
6245         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6246         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6247         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6248         (maintenance_print_msymbols): Use all_objfiles.
6249         * source.c (select_source_symtab): Use all_objfiles.
6250         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6251         * symfile.c (remove_symbol_file_command)
6252         (expand_symtabs_matching, map_symbol_filenames): Use
6253         all_objfiles.
6254         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6255         all_objfiles.
6256         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6257         * objc-lang.c (find_methods): Use all_objfiles.
6258         * objfiles.c (have_partial_symbols, have_full_symbols)
6259         (have_minimal_symbols, qsort_cmp)
6260         (default_iterate_over_objfiles_in_search_order): Use
6261         all_objfiles.
6262         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6263         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6264         (maintenance_check_psymtabs): Use all_objfiles.
6265         (ALL_PSYMTABS): Remove.
6266         * compile/compile-object-run.c (do_module_cleanup): Use
6267         all_objfiles.
6268         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6269         * cp-support.c (add_symbol_overload_list_qualified): Use
6270         all_objfiles.
6271         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6272         Use all_objfiles.
6273         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6274         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6275         all_objfiles.
6276         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6277         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6278         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6279         Uses all_objfiles.
6280         * solib.c (solib_read_symbols): Use all_objfiles
6281
6282 2019-01-09  Tom Tromey  <tom@tromey.com>
6283
6284         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6285         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6286         all_objfiles.
6287         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6288         * symmisc.c (print_symbol_bcache_statistics)
6289         (print_objfile_statistics, maintenance_print_objfiles)
6290         (maintenance_info_symtabs, maintenance_check_symtabs)
6291         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6292         all_objfiles.
6293         * source.c (forget_cached_source_info): Use all_objfiles.
6294         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6295         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6296         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6297         * objfiles.c (update_section_map): Use all_objfiles.
6298         (shared_objfile_contains_address_p): Likewise.
6299         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6300         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6301
6302 2019-01-09  Tom Tromey  <tom@tromey.com>
6303
6304         * common/next-iterator.h: New file.
6305         * objfiles.h (class all_objfiles): New.
6306         (struct objfile_iterator): New.
6307
6308 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6309
6310         * NEWS: Move the description of the changed "frame", "select-frame",
6311          and "info frame" commands to the Changed commands section.
6312
6313 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6314
6315         * gdbtypes.c (check_stub_method_group): Remove handling of old
6316         mangling schemes.
6317         * linespec.c (find_methods): Likewise.
6318         * stabsread.c (read_member_functions): Likewise.
6319         * valops.c (search_struct_method): Likewise.
6320         (value_struct_elt_for_reference): Likewise.
6321         * NEWS: Mention this change.
6322
6323 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6324
6325         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6326         print_source_lines.
6327         * source.c (print_source_lines_base): Update line number check.
6328         (print_source_lines): New function.
6329         (source_lines_range::source_lines_range): New function.
6330         * source.h (class source_lines_range): New class.
6331         (print_source_lines): New declaration.
6332
6333 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6334
6335         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6336
6337 2019-01-08  Tom Tromey  <tom@tromey.com>
6338             Simon Marchi  <simon.marchi@ericsson.com>
6339
6340         PR gdb/24060
6341         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6342         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6343         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6344         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6345         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6346         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6347
6348 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * source.c (select_source_symtab): Move header comment to
6351         declaration in source.h.
6352         (forget_cached_source_info_for_objfile): Likewise.
6353         (forget_cached_source_info): Likewise.
6354         (identify_source_line): Likewise.
6355         * source.h (identify_source_line): Move declaration from symtab.h
6356         and add comment from source.c
6357         (print_source_lines): Likewise.
6358         (forget_cached_source_info_for_objfile): Likewise.
6359         (forget_cached_source_info): Likewise.
6360         (select_source_symtab): Likewise.
6361         (enum print_source_lines_flag): Move definition from symtab.h.
6362         * symtab.h (identify_source_line): Move declaration to source.h.
6363         (print_source_lines): Likewise.
6364         (forget_cached_source_info_for_objfile): Likewise.
6365         (forget_cached_source_info): Likewise.
6366         (select_source_symtab): Likewise.
6367         (enum print_source_lines_flag): Move definition to source.h.
6368         * tui/tui-hooks.c: Add 'source.h' include.
6369
6370 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * source.c (print_source_lines_base): Handle requests to print
6373         reverse line number sequences, and guard against empty lines
6374         string.
6375
6376 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6377
6378         * source.c (print_source_lines_base): Fix skip of '\r' if next
6379         character is '\n'.
6380
6381 2019-01-06  Tom Tromey  <tom@tromey.com>
6382
6383         * c-exp.y (struct c_parse_state) <macro_original_text,
6384         expansion_obstack>: New member.
6385         (macro_original_text, expansion_obstack): Remove globals.
6386         (scan_macro_expansion, scanning_macro_expansion)
6387         (finished_macro_expansion): Update.
6388         (scan_macro_cleanup): Remove.
6389         (yylex, c_parse): Update.
6390
6391 2019-01-06  Tom Tromey  <tom@tromey.com>
6392
6393         * c-exp.y (struct c_parse_state) <strings>: New member.
6394         (operator_stoken): Update.
6395
6396 2019-01-06  Tom Tromey  <tom@tromey.com>
6397
6398         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6399         (union type_stack_elt) <typelist_val>: Now a pointer to
6400         std::vector.
6401         (type_stack_cleanup): Don't declare.
6402         (push_typelist): Update.
6403         * parse.c (pop_typelist): Return a std::vector.
6404         (push_typelist): Take a std::vector.
6405         (follow_types): Update.  Do not free args.
6406         (type_stack_cleanup): Remove.
6407         * c-exp.y (struct c_parse_state): New.
6408         (cpstate): New global.
6409         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6410         (nonempty_typelist): Update.
6411         (func_mod): Create a new vector.
6412         (c_parse): Create a c_parse_state.
6413         (check_parameter_typelist): Do not delete params.
6414         (function_method): Update.  Do not delete type_list.
6415
6416 2019-01-06  Tom Tromey  <tom@tromey.com>
6417
6418         PR gdb/28155:
6419         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6420         check_typedef.
6421         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6422         (print_return_value): Likewise.
6423
6424 2019-01-05  Tom Tromey  <tom@tromey.com>
6425
6426         * contrib/cleanup_check.py: Remove.
6427         * contrib/gcc-with-excheck: Remove.
6428         * contrib/exsummary.py: Remove.
6429         * contrib/excheck.py: Remove.
6430
6431 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6432
6433         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6434         NULL. Initialize tpprev to NULL instead of assigning it
6435         to NULL on the next statement.
6436         * windows-nat.c (windows_delete_thread): Remove check for
6437         main_thread_id before printing thread exit notifications.
6438         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6439         Remove thread ID check against main_thread_id.
6440         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6441         windows_delete_thread.
6442         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6443
6444 2019-01-04  Tom Tromey  <tom@tromey.com>
6445
6446         * compile/compile.c (_initialize_compile): Use upper case for
6447         metasyntactic variables.
6448         * symmisc.c (_initialize_symmisc): Use upper case for
6449         metasyntactic variables.
6450         * psymtab.c (_initialize_psymtab): Use upper case for
6451         metasyntactic variables.
6452         * demangle.c (demangle_command): Use upper case for metasyntactic
6453         variables.
6454         (_initialize_demangler): Likewise.
6455         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6456         variables.
6457
6458 2019-01-03  Tom Tromey  <tom@tromey.com>
6459
6460         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6461
6462 2019-01-03  Tom Tromey  <tom@tromey.com>
6463
6464         * python/py-symtab.c (salpy_str): Update.
6465         (struct salpy_sal_object) <symtab>: Now a PyObject.
6466         (salpy_dealloc): Update.
6467         (del_objfile_sal): Use gdbpy_ref.
6468
6469 2019-01-03  Tom Tromey  <tom@tromey.com>
6470
6471         * python/py-type.c (convert_field): Use new_reference.  Return
6472         gdbpy_ref.
6473         (make_fielditem): Return gdbpy_ref.
6474         (typy_fields): Update.
6475         (typy_getitem): Update.
6476         (field_name): Return gdbpy_ref.  Use new_reference.
6477         (typy_iterator_iternext): Update.
6478
6479 2019-01-03  Tom Tromey  <tom@tromey.com>
6480
6481         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6482
6483 2019-01-03  Tom Tromey  <tom@tromey.com>
6484
6485         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6486         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6487         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6488         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6489         (pspy_set_type_printers): Likewise.
6490         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6491         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6492         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6493         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6494         (objfpy_set_type_printers): Likewise.
6495
6496 2019-01-03  Tom Tromey  <tom@tromey.com>
6497
6498         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6499         (gdbpy_print_stack): Use gdbpy_err_fetch.
6500         * python/python-internal.h (class gdbpy_err_fetch): New class.
6501         (class gdbpy_enter) <m_error_type, m_error_value,
6502         m_error_traceback>: Remove.
6503         <m_error>: New member.
6504         (gdbpy_exception_to_string): Don't declare.
6505         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6506         * python/py-value.c (convert_value_from_python): Use
6507         gdbpy_err_fetch.
6508         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6509         gdbpy_exception_to_string.
6510         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6511         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6512         gdbpy_err_fetch.
6513
6514 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * linux-nat.c (delete_lwp_cleanup): Delete.
6517         (struct lwp_deleter): New struct.
6518         (lwp_info_up): New typedef.
6519         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6520         lwp_info_up.
6521
6522 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6523
6524         * linux-fork.c (class scoped_switch_fork_info): New class.
6525         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6526
6527 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6528
6529         * valops.c (find_overload_match): Remove use of null_cleanup, and
6530         calls to do_cleanups.
6531
6532 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6533
6534         * compile/compile-cplus-types.c
6535         (compile_cplus_instance::decl_name): Handle changes to
6536         cp_func_name.
6537         * cp-support.c (cp_func_name): Update header comment, update
6538         return type.
6539         * cp-support.h (cp_func_name): Update return type in declaration.
6540         * valops.c (find_overload_match): Move temp_func local to top
6541         level of function and change its type.  Use temp_func to hold and
6542         delete temporary string obtained from cp_func_name.
6543
6544 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6545
6546         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6547         gdb::char_vector, remove cleanup, and update uses of `msg`.
6548
6549 2019-01-03  Jim Wilson  <jimw@sifive.com>
6550
6551         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6552
6553 2019-01-02  Tom Tromey  <tom@tromey.com>
6554
6555         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6556         (tdesc_parse_xml): Remove cleanups.
6557         * target-descriptions.h (make_cleanup_free_target_description):
6558         Don't declare.
6559         (target_desc_deleter): New struct.
6560         (target_desc_up): New typedef.
6561         * target-descriptions.c (target_desc_deleter::operator()): Rename
6562         from free_target_description.
6563         (make_cleanup_free_target_description): Remove.
6564
6565 2019-01-02  Tom Tromey  <tom@tromey.com>
6566
6567         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6568         constructor, destructor.
6569         (linespec_parser): Remove typedef.
6570         (~linespec_parser): Rename from linespec_parser_delete.
6571         (linespec_lex_to_end, linespec_complete_label)
6572         (linespec_complete): Update.
6573         (decode_line_full): Remove cleanups.
6574         (decode_line_1): Update.
6575
6576 2019-01-02  Tom Tromey  <tom@tromey.com>
6577
6578         * python/python-internal.h (inferior_to_inferior_object): Change
6579         return type.
6580         * python/py-exitedevent.c (create_exited_event_object): Update.
6581         * python/py-inferior.c (inferior_to_inferior_object): Return
6582         gdbpy_ref.
6583         (python_new_inferior, python_inferior_deleted)
6584         (thread_to_thread_object, delete_thread_object)
6585         (build_inferior_list, gdbpy_selected_inferior): Update.
6586         * python/py-infthread.c (create_thread_object): Update.  Also fail
6587         if inferior_to_inferior_object fails.
6588
6589 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6590
6591         * inferior.h (class inferior) <displaced_step_state>: New field.
6592         * infrun.h (struct displaced_step_state): Move here from
6593         infrun.c.  Initialize fields, add constructor.
6594         <inf>: Remove field.
6595         <reset>: New method.
6596         * infrun.c (struct displaced_step_inferior_state): Move to
6597         infrun.h.
6598         (displaced_step_inferior_states): Remove.
6599         (get_displaced_stepping_state): Adust.
6600         (displaced_step_in_progress_any_inferior): Adjust.
6601         (displaced_step_in_progress_thread): Adjust.
6602         (displaced_step_in_progress): Adjust.
6603         (add_displaced_stepping_state): Remove.
6604         (get_displaced_step_closure_by_addr): Adjust.
6605         (remove_displaced_stepping_state): Remove.
6606         (infrun_inferior_exit): Call displaced_step_state.reset.
6607         (use_displaced_stepping): Don't check for NULL.
6608         (displaced_step_prepare_throw): Call
6609         get_displaced_stepping_state.
6610         (displaced_step_fixup): Don't check for NULL.
6611         (prepare_for_detach): Don't check for NULL.
6612
6613 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6614
6615         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6616          in case of call that did not complete.
6617
6618 2019-01-02  Andrey Utkin  <autkin@undo.io>
6619
6620         * symfile.c (find_separate_debug_file): Fix search of debug files for
6621         remote debuggee.
6622
6623 2019-01-02  Tom Tromey  <tom@tromey.com>
6624
6625         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6626         indentation.
6627         * python/py-frame.c (frapy_older): Remove cast.
6628         (frapy_newer): Likewise.
6629         * python/py-breakpoint.c (local_setattro): Remove cast.
6630         * python/py-arch.c (archpy_name): Remove local variable.
6631         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6632
6633 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6634
6635         * unittests/basic_string_view/element_access/char/empty.cc:
6636         Fix year range in copyright header.
6637
6638 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6639
6640         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6641         Delete.
6642         <operator==>: Update with for removed field.
6643         <hash>: Likewise.
6644         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6645         <isa_features>: ...this.
6646         <abi_features>: New field.
6647         (riscv_isa_flen): Update comment.
6648         (riscv_abi_xlen): New declaration.
6649         (riscv_abi_flen): New declaration.
6650         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6651         isa_features.
6652         (riscv_abi_xlen): New function.
6653         (riscv_isa_flen): Update to get answer from isa_features.
6654         (riscv_abi_flen): New function.
6655         (riscv_has_fp_abi): Update to get answer from abi_features.
6656         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6657         xlen and flen.
6658         (riscv_call_info) <xlen, flen>: Update comment.
6659         (riscv_call_arg_struct): Remove invalid assertions
6660         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6661         is removed.
6662         (riscv_gdbarch_init): Gather isa features and abi features
6663         separately, ensure both match on the gdbarch when reusing an old
6664         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6665         a target with 64-bit float hardware.
6666
6667 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6668
6669         * source.c (search_command_helper): Stop reverse search
6670         when line 1 has been searched.
6671
6672 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6673
6674         * record-full.c (record_full_base_target::close): Rewrite
6675         record_full_core_buf_list free logic.
6676
6677 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6678
6679         * break-catch-syscall.c (print_one_catch_syscall): xfree
6680         the last text.
6681
6682 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6683
6684         * top.c (print_gdb_version): Update Copyright year in version
6685         message.
6686
6687 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6688
6689         Update copyright year range in all GDB files.
6690
6691 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6692
6693         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6694
6695 For older changes see ChangeLog-2018.
6696 \f
6697 Local Variables:
6698 mode: change-log
6699 left-margin: 8
6700 fill-column: 74
6701 version-control: never
6702 coding: utf-8
6703 End:
6704