gdb/ChangeLog

   1 2019-01-10  Tom Tromey  <tom@tromey.com>
   2
   3         * psymtab.h (psymtab_storage::obstack): New method.
   4         <m_obstack>: Rename from obstack; now private.
   5         * psymtab.c (psymtab_storage): Update.
   6         * dwarf2read.c (create_addrmap_from_index)
   7         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
   8         Update.
   9
  10 2019-01-10  Tom Tromey  <tom@tromey.com>
  11
  12         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
  13         * objfiles.h (objfile::reset_psymtabs): New method.
  14
  15 2019-01-10  Tom Tromey  <tom@tromey.com>
  16
  17         * symmisc.c (print_symbol_bcache_statistics): Update.
  18         (print_objfile_statistics): Update.
  19         * symfile.c (reread_symbols): Update.
  20         * psymtab.h (class psymtab_storage): New.
  21         * psymtab.c (psymtab_storage): New constructor.
  22         (~psymtab_storage): New destructor.
  23         (require_partial_symbols): Update.
  24         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
  25         (find_pc_sect_psymtab, find_pc_sect_psymbol)
  26         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
  27         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
  28         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
  29         (start_psymtab_common, end_psymtab_common)
  30         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
  31         (allocate_psymtab): Update.
  32         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
  33         Update.
  34         (dump_psymtab_addrmap, maintenance_print_psymbols)
  35         (maintenance_check_psymtabs): Update.
  36         (class objfile_psymtabs): Move to objfiles.h.
  37         * psympriv.h (discard_psymtab): Now inline.
  38         (psymtab_discarder::psymtab_discarder): Update.
  39         (psymtab_discarder::~psymtab_discarder): Update.
  40         (ALL_OBJFILE_PSYMTABS): Rewrite.
  41         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
  42         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
  43         Remove fields.
  44         <partial_symtabs>: New field.
  45         (class objfile_psymtabs): Move from psymtab.h.  Update.
  46         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
  47         psymbol_cache.
  48         (objfile::~objfile): Don't destroy psymbol_cache.
  49         * mdebugread.c (parse_partial_symbols): Update.
  50         * dwarf2read.c (create_addrmap_from_index)
  51         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
  52         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
  53         (add_partial_subprogram, dwarf2_ranges_read): Update.
  54         * dwarf-index-write.c (write_address_map)
  55         (write_one_signatured_type, recursively_write_psymbols)
  56         (class debug_names, class debug_names, write_psymtabs_to_index):
  57         Update.
  58
  59 2019-01-10  Tom Tromey  <tom@tromey.com>
  60
  61         * symtab.h (SYMBOL_SET_NAMES): Update.
  62         (symbol_set_names): Update.
  63         (MSYMBOL_SET_NAMES): Update.
  64         * symtab.c (symbol_set_names): Change argument to be an
  65         objfile_per_bfd_storage.
  66         * psymtab.c (add_psymbol_to_bcache): Update.
  67         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
  68
  69 2019-01-10  Tom Tromey  <tom@tromey.com>
  70
  71         * symtab.c (create_demangled_names_hash): Change argument to be an
  72         objfile_per_bfd_storage.
  73         (symbol_set_names): Update.
  74
  75 2019-01-10  Tom Tromey  <tom@tromey.com>
  76
  77         * xcoffread.c (xcoff_initial_scan): Unconditionally call
  78         init_psymbol_list.
  79         * psymtab.c (init_psymbol_list): Do nothing if already called.
  80         * psympriv.h (init_psymbol_list): Add comment.
  81         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
  82         init_psymbol_list.
  83         * dbxread.c (dbx_symfile_read): Unconditionally call
  84         init_psymbol_list.
  85
  86 2019-01-10  Tom Tromey  <tom@tromey.com>
  87
  88         * xcoffread.c (scan_xcoff_symtab): Update.
  89         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
  90         "where".
  91         * mdebugread.c (parse_partial_symbols)
  92         (handle_psymbol_enumerators): Update.
  93         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
  94         * dbxread.c (read_dbx_symtab): Update.
  95         * psympriv.h (psymbol_placement): New enum.
  96         (add_psymbol_to_list): Update.
  97
  98 2019-01-10  Tom Tromey  <tom@tromey.com>
  99
 100         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 101         static_psymbols parameters.
 102         (scan_xcoff_symtab): Update.
 103         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 104         static_psymbols parameters.
 105         * psympriv.h (start_psymtab_common): Update.
 106         * mdebugread.c (parse_partial_symbols): Update.
 107         * dwarf2read.c (create_partial_symtab): Update.
 108         * dbxread.c (read_dbx_symtab): Update.
 109         (start_psymtab): Remove global_psymbols and static_psymbols
 110         parameters.
 111
 112 2019-01-10  Tom Tromey  <tom@tromey.com>
 113
 114         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 115         * psymtab.c (allocate_psymtab): Add comment.
 116         * psympriv.h (allocate_psymtab): Add comment.
 117         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 118         initializations.
 119         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 120
 121 2019-01-10  Tom Tromey  <tom@tromey.com>
 122
 123         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 124         Don't declare.
 125         * mipsread.c: Include mdebugread.h.
 126         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 127         Declare.
 128         * elfread.c: Include mdebugread.h.
 129
 130 2019-01-09  Tom Tromey  <tom@tromey.com>
 131
 132         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 133         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 134         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 135         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 136         (psym_lookup_symbol, psym_find_last_source_symtab)
 137         (psym_forget_cached_source_info, psym_print_stats)
 138         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 139         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 140         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 141         (psym_find_compunit_symtab_by_address)
 142         (maintenance_print_psymbols, maintenance_info_psymtabs)
 143         (maintenance_check_psymtabs): Use ranged for.
 144         * psymtab.h (class objfile_psymtabs): New.
 145         (require_partial_symbols): Return objfile_psymtabs.
 146         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 147
 148 2019-01-09  Tom Tromey  <tom@tromey.com>
 149
 150         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 151         (find_pc_mapped_section, list_overlays_command)
 152         (map_overlay_command, unmap_overlay_command)
 153         (simple_overlay_update): Use all_objfiles.
 154         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 155         * printcmd.c (info_symbol_command): Use all_objfiles.
 156         * objfiles.h (ALL_OBJSECTIONS): Remove.
 157         * maint.c (maintenance_translate_address): Use all_objfiles.
 158         * gcore.c (gcore_create_callback): Use all_objfiles.
 159         (objfile_find_memory_regions): Likewise.
 160
 161 2019-01-09  Tom Tromey  <tom@tromey.com>
 162
 163         * symtab.c (find_line_symtab, info_sources_command)
 164         (make_source_files_completion_list): Use objfile_compunits.
 165         * source.c (select_source_symtab): Use objfile_compunits.
 166         * objfiles.h (struct objfile): Update comment.
 167         (ALL_OBJFILES): Remove.
 168         (ALL_FILETABS): Remove.
 169         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 170         objfile_compunits.
 171
 172 2019-01-09  Tom Tromey  <tom@tromey.com>
 173
 174         * symmisc.c (print_objfile_statistics, dump_objfile)
 175         (maintenance_print_symbols): Use compunit_filetabs.
 176         * source.c (forget_cached_source_info_for_objfile): Use
 177         compunit_filetabs.
 178         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 179         (ALL_FILETABS): Use compunit_filetabs.
 180         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 181         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 182
 183 2019-01-09  Tom Tromey  <tom@tromey.com>
 184
 185         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 186         (compunit_filetabs): New.
 187         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 188         compunit_filetabs.
 189         (info_sources_command, make_source_files_completion_list): Remove
 190         declaration.
 191         * symmisc.c (print_objfile_statistics, dump_objfile)
 192         (maintenance_print_symbols): Remove declaration.
 193         (maintenance_info_symtabs): Use compunit_filetabs.
 194         (maintenance_info_line_tables): Likewise.
 195         * source.c (select_source_symtab): Change local variable name.
 196         (forget_cached_source_info_for_objfile): Remove declaration.
 197         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 198         * objfiles.c (objfile_relocate1): Remove declaration.
 199         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 200         declaration.
 201         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 202         * coffread.c (coff_symtab_read): Remove declaration.
 203         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 204         compunit_filetabs.
 205
 206 2019-01-09  Tom Tromey  <tom@tromey.com>
 207
 208         * symtab.c (lookup_objfile_from_block)
 209         (find_pc_sect_compunit_symtab, search_symbols)
 210         (default_collect_symbol_completion_matches_break_on): Use
 211         objfile_compunits.
 212         * objfiles.h (ALL_COMPUNITS): Remove.
 213         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 214         * cp-support.c (add_symbol_overload_list_qualified): Use
 215         objfile_compunits.
 216         * ada-lang.c (ada_collect_symbol_completion_matches)
 217         (ada_add_global_exceptions): Use objfile_compunits.
 218
 219 2019-01-09  Tom Tromey  <tom@tromey.com>
 220
 221         * source.c (select_source_symtab)
 222         (forget_cached_source_info_for_objfile): Remove declaration.
 223         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 224         declaration.
 225         * maint.c (count_symtabs_and_blocks): Remove declaration.
 226         * cp-support.c (add_symbol_overload_list_qualified): Remove
 227         declaration.
 228         * coffread.c (coff_symtab_read): Remove declaration.
 229         * symtab.c (lookup_symbol_in_objfile_symtabs)
 230         (basic_lookup_transparent_type_1): Use objfile_compunits.
 231         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 232         (info_sources_command, search_symbols)
 233         (default_collect_symbol_completion_matches_break_on)
 234         (make_source_files_completion_list): Remove declaration.
 235         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 236         (ada_collect_symbol_completion_matches)
 237         (ada_add_global_exceptions): Remove declaration.
 238         * linespec.c (iterate_over_all_matching_symtabs): Use
 239         objfile_compunits.
 240         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 241         (class objfile_compunits): New.
 242         (ALL_COMPUNITS): Use objfile_compunits.
 243         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 244         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 245         objfile_compunits.
 246         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 247
 248 2019-01-09  Tom Tromey  <tom@tromey.com>
 249
 250         * symtab.c (search_symbols)
 251         (default_collect_symbol_completion_matches_break_on): Use
 252         objfile_msymbols.
 253         * ada-lang.c (ada_lookup_simple_minsym)
 254         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 255         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 256         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 257         objfile_msymbols.
 258         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 259         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 260         * objc-lang.c (find_methods): Use objfile_msymbols.
 261         (info_selectors_command, info_classes_command): Likewise.
 262         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 263         * objfiles.h (class objfile_msymbols): New.
 264         (ALL_OBJFILE_MSYMBOLS): Remove.
 265         (ALL_MSYMBOLS): Remove.
 266
 267 2019-01-09  Tom Tromey  <tom@tromey.com>
 268
 269         * common/next-iterator.h (next_adapter): Add Iterator template
 270         parameter.
 271         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 272         (class all_objfiles_safe): New.
 273         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 274         * objfiles.c (put_objfile_before): Update comment.
 275         (add_separate_debug_objfile): Likewise.
 276         (free_all_objfiles): Use all_objfiles_safe.
 277         (objfile_purge_solibs): Likewise.
 278
 279 2019-01-09  Tom Tromey  <tom@tromey.com>
 280
 281         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 282         (expand_symtab_containing_pc, lookup_static_symbol)
 283         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 284         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 285         all_objfiles.
 286         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 287         * breakpoint.c (create_overlay_event_breakpoint)
 288         (create_longjmp_master_breakpoint)
 289         (create_std_terminate_master_breakpoint)
 290         (create_exception_master_breakpoint): Use all_objfiles.
 291         * linux-thread-db.c (try_thread_db_load_from_pdir)
 292         (has_libpthread): Use all_objfiles.
 293         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 294         * linespec.c (iterate_over_all_matching_symtabs)
 295         (search_minsyms_for_name): Use all_objfiles.
 296         * maint.c (maintenance_info_sections): Use all_objfiles.
 297         * main.c (captured_main_1): Use all_objfiles.
 298         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 299         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 300         * guile/scm-pretty-print.c
 301         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 302         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 303         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 304         (maintenance_print_msymbols): Use all_objfiles.
 305         * source.c (select_source_symtab): Use all_objfiles.
 306         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 307         * symfile.c (remove_symbol_file_command)
 308         (expand_symtabs_matching, map_symbol_filenames): Use
 309         all_objfiles.
 310         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 311         all_objfiles.
 312         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 313         * objc-lang.c (find_methods): Use all_objfiles.
 314         * objfiles.c (have_partial_symbols, have_full_symbols)
 315         (have_minimal_symbols, qsort_cmp)
 316         (default_iterate_over_objfiles_in_search_order): Use
 317         all_objfiles.
 318         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 319         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 320         (maintenance_check_psymtabs): Use all_objfiles.
 321         (ALL_PSYMTABS): Remove.
 322         * compile/compile-object-run.c (do_module_cleanup): Use
 323         all_objfiles.
 324         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 325         * cp-support.c (add_symbol_overload_list_qualified): Use
 326         all_objfiles.
 327         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 328         Use all_objfiles.
 329         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 330         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 331         all_objfiles.
 332         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 333         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 334         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 335         Uses all_objfiles.
 336         * solib.c (solib_read_symbols): Use all_objfiles
 337
 338 2019-01-09  Tom Tromey  <tom@tromey.com>
 339
 340         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 341         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 342         all_objfiles.
 343         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 344         * symmisc.c (print_symbol_bcache_statistics)
 345         (print_objfile_statistics, maintenance_print_objfiles)
 346         (maintenance_info_symtabs, maintenance_check_symtabs)
 347         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 348         all_objfiles.
 349         * source.c (forget_cached_source_info): Use all_objfiles.
 350         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 351         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 352         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 353         * objfiles.c (update_section_map): Use all_objfiles.
 354         (shared_objfile_contains_address_p): Likewise.
 355         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 356         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 357
 358 2019-01-09  Tom Tromey  <tom@tromey.com>
 359
 360         * common/next-iterator.h: New file.
 361         * objfiles.h (class all_objfiles): New.
 362         (struct objfile_iterator): New.
 363
 364 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 365
 366         * NEWS: Move the description of the changed "frame", "select-frame",
 367          and "info frame" commands to the Changed commands section.
 368
 369 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 370
 371         * gdbtypes.c (check_stub_method_group): Remove handling of old
 372         mangling schemes.
 373         * linespec.c (find_methods): Likewise.
 374         * stabsread.c (read_member_functions): Likewise.
 375         * valops.c (search_struct_method): Likewise.
 376         (value_struct_elt_for_reference): Likewise.
 377         * NEWS: Mention this change.
 378
 379 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 380
 381         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 382         print_source_lines.
 383         * source.c (print_source_lines_base): Update line number check.
 384         (print_source_lines): New function.
 385         (source_lines_range::source_lines_range): New function.
 386         * source.h (class source_lines_range): New class.
 387         (print_source_lines): New declaration.
 388
 389 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 390
 391         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 392
 393 2019-01-08  Tom Tromey  <tom@tromey.com>
 394             Simon Marchi  <simon.marchi@ericsson.com>
 395
 396         PR gdb/24060
 397         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 398         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 399         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 400         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 401         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 402         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 403
 404 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * source.c (select_source_symtab): Move header comment to
 407         declaration in source.h.
 408         (forget_cached_source_info_for_objfile): Likewise.
 409         (forget_cached_source_info): Likewise.
 410         (identify_source_line): Likewise.
 411         * source.h (identify_source_line): Move declaration from symtab.h
 412         and add comment from source.c
 413         (print_source_lines): Likewise.
 414         (forget_cached_source_info_for_objfile): Likewise.
 415         (forget_cached_source_info): Likewise.
 416         (select_source_symtab): Likewise.
 417         (enum print_source_lines_flag): Move definition from symtab.h.
 418         * symtab.h (identify_source_line): Move declaration to source.h.
 419         (print_source_lines): Likewise.
 420         (forget_cached_source_info_for_objfile): Likewise.
 421         (forget_cached_source_info): Likewise.
 422         (select_source_symtab): Likewise.
 423         (enum print_source_lines_flag): Move definition to source.h.
 424         * tui/tui-hooks.c: Add 'source.h' include.
 425
 426 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 427
 428         * source.c (print_source_lines_base): Handle requests to print
 429         reverse line number sequences, and guard against empty lines
 430         string.
 431
 432 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 433
 434         * source.c (print_source_lines_base): Fix skip of '\r' if next
 435         character is '\n'.
 436
 437 2019-01-06  Tom Tromey  <tom@tromey.com>
 438
 439         * c-exp.y (struct c_parse_state) <macro_original_text,
 440         expansion_obstack>: New member.
 441         (macro_original_text, expansion_obstack): Remove globals.
 442         (scan_macro_expansion, scanning_macro_expansion)
 443         (finished_macro_expansion): Update.
 444         (scan_macro_cleanup): Remove.
 445         (yylex, c_parse): Update.
 446
 447 2019-01-06  Tom Tromey  <tom@tromey.com>
 448
 449         * c-exp.y (struct c_parse_state) <strings>: New member.
 450         (operator_stoken): Update.
 451
 452 2019-01-06  Tom Tromey  <tom@tromey.com>
 453
 454         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 455         (union type_stack_elt) <typelist_val>: Now a pointer to
 456         std::vector.
 457         (type_stack_cleanup): Don't declare.
 458         (push_typelist): Update.
 459         * parse.c (pop_typelist): Return a std::vector.
 460         (push_typelist): Take a std::vector.
 461         (follow_types): Update.  Do not free args.
 462         (type_stack_cleanup): Remove.
 463         * c-exp.y (struct c_parse_state): New.
 464         (cpstate): New global.
 465         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 466         (nonempty_typelist): Update.
 467         (func_mod): Create a new vector.
 468         (c_parse): Create a c_parse_state.
 469         (check_parameter_typelist): Do not delete params.
 470         (function_method): Update.  Do not delete type_list.
 471
 472 2019-01-06  Tom Tromey  <tom@tromey.com>
 473
 474         PR gdb/28155:
 475         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 476         check_typedef.
 477         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 478         (print_return_value): Likewise.
 479
 480 2019-01-05  Tom Tromey  <tom@tromey.com>
 481
 482         * contrib/cleanup_check.py: Remove.
 483         * contrib/gcc-with-excheck: Remove.
 484         * contrib/exsummary.py: Remove.
 485         * contrib/excheck.py: Remove.
 486
 487 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 488
 489         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 490         NULL. Initialize tpprev to NULL instead of assigning it
 491         to NULL on the next statement.
 492         * windows-nat.c (windows_delete_thread): Remove check for
 493         main_thread_id before printing thread exit notifications.
 494         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 495         Remove thread ID check against main_thread_id.
 496         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 497         windows_delete_thread.
 498         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 499
 500 2019-01-04  Tom Tromey  <tom@tromey.com>
 501
 502         * compile/compile.c (_initialize_compile): Use upper case for
 503         metasyntactic variables.
 504         * symmisc.c (_initialize_symmisc): Use upper case for
 505         metasyntactic variables.
 506         * psymtab.c (_initialize_psymtab): Use upper case for
 507         metasyntactic variables.
 508         * demangle.c (demangle_command): Use upper case for metasyntactic
 509         variables.
 510         (_initialize_demangler): Likewise.
 511         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 512         variables.
 513
 514 2019-01-03  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 517
 518 2019-01-03  Tom Tromey  <tom@tromey.com>
 519
 520         * python/py-symtab.c (salpy_str): Update.
 521         (struct salpy_sal_object) <symtab>: Now a PyObject.
 522         (salpy_dealloc): Update.
 523         (del_objfile_sal): Use gdbpy_ref.
 524
 525 2019-01-03  Tom Tromey  <tom@tromey.com>
 526
 527         * python/py-type.c (convert_field): Use new_reference.  Return
 528         gdbpy_ref.
 529         (make_fielditem): Return gdbpy_ref.
 530         (typy_fields): Update.
 531         (typy_getitem): Update.
 532         (field_name): Return gdbpy_ref.  Use new_reference.
 533         (typy_iterator_iternext): Update.
 534
 535 2019-01-03  Tom Tromey  <tom@tromey.com>
 536
 537         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 538
 539 2019-01-03  Tom Tromey  <tom@tromey.com>
 540
 541         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 542         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 543         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 544         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 545         (pspy_set_type_printers): Likewise.
 546         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 547         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 548         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 549         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 550         (objfpy_set_type_printers): Likewise.
 551
 552 2019-01-03  Tom Tromey  <tom@tromey.com>
 553
 554         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 555         (gdbpy_print_stack): Use gdbpy_err_fetch.
 556         * python/python-internal.h (class gdbpy_err_fetch): New class.
 557         (class gdbpy_enter) <m_error_type, m_error_value,
 558         m_error_traceback>: Remove.
 559         <m_error>: New member.
 560         (gdbpy_exception_to_string): Don't declare.
 561         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 562         * python/py-value.c (convert_value_from_python): Use
 563         gdbpy_err_fetch.
 564         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 565         gdbpy_exception_to_string.
 566         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 567         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 568         gdbpy_err_fetch.
 569
 570 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 571
 572         * linux-nat.c (delete_lwp_cleanup): Delete.
 573         (struct lwp_deleter): New struct.
 574         (lwp_info_up): New typedef.
 575         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 576         lwp_info_up.
 577
 578 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 579
 580         * linux-fork.c (class scoped_switch_fork_info): New class.
 581         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 582
 583 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 584
 585         * valops.c (find_overload_match): Remove use of null_cleanup, and
 586         calls to do_cleanups.
 587
 588 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * compile/compile-cplus-types.c
 591         (compile_cplus_instance::decl_name): Handle changes to
 592         cp_func_name.
 593         * cp-support.c (cp_func_name): Update header comment, update
 594         return type.
 595         * cp-support.h (cp_func_name): Update return type in declaration.
 596         * valops.c (find_overload_match): Move temp_func local to top
 597         level of function and change its type.  Use temp_func to hold and
 598         delete temporary string obtained from cp_func_name.
 599
 600 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 601
 602         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 603         gdb::char_vector, remove cleanup, and update uses of `msg`.
 604
 605 2019-01-03  Jim Wilson  <jimw@sifive.com>
 606
 607         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 608
 609 2019-01-02  Tom Tromey  <tom@tromey.com>
 610
 611         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 612         (tdesc_parse_xml): Remove cleanups.
 613         * target-descriptions.h (make_cleanup_free_target_description):
 614         Don't declare.
 615         (target_desc_deleter): New struct.
 616         (target_desc_up): New typedef.
 617         * target-descriptions.c (target_desc_deleter::operator()): Rename
 618         from free_target_description.
 619         (make_cleanup_free_target_description): Remove.
 620
 621 2019-01-02  Tom Tromey  <tom@tromey.com>
 622
 623         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 624         constructor, destructor.
 625         (linespec_parser): Remove typedef.
 626         (~linespec_parser): Rename from linespec_parser_delete.
 627         (linespec_lex_to_end, linespec_complete_label)
 628         (linespec_complete): Update.
 629         (decode_line_full): Remove cleanups.
 630         (decode_line_1): Update.
 631
 632 2019-01-02  Tom Tromey  <tom@tromey.com>
 633
 634         * python/python-internal.h (inferior_to_inferior_object): Change
 635         return type.
 636         * python/py-exitedevent.c (create_exited_event_object): Update.
 637         * python/py-inferior.c (inferior_to_inferior_object): Return
 638         gdbpy_ref.
 639         (python_new_inferior, python_inferior_deleted)
 640         (thread_to_thread_object, delete_thread_object)
 641         (build_inferior_list, gdbpy_selected_inferior): Update.
 642         * python/py-infthread.c (create_thread_object): Update.  Also fail
 643         if inferior_to_inferior_object fails.
 644
 645 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
 646
 647         * inferior.h (class inferior) <displaced_step_state>: New field.
 648         * infrun.h (struct displaced_step_state): Move here from
 649         infrun.c.  Initialize fields, add constructor.
 650         <inf>: Remove field.
 651         <reset>: New method.
 652         * infrun.c (struct displaced_step_inferior_state): Move to
 653         infrun.h.
 654         (displaced_step_inferior_states): Remove.
 655         (get_displaced_stepping_state): Adust.
 656         (displaced_step_in_progress_any_inferior): Adjust.
 657         (displaced_step_in_progress_thread): Adjust.
 658         (displaced_step_in_progress): Adjust.
 659         (add_displaced_stepping_state): Remove.
 660         (get_displaced_step_closure_by_addr): Adjust.
 661         (remove_displaced_stepping_state): Remove.
 662         (infrun_inferior_exit): Call displaced_step_state.reset.
 663         (use_displaced_stepping): Don't check for NULL.
 664         (displaced_step_prepare_throw): Call
 665         get_displaced_stepping_state.
 666         (displaced_step_fixup): Don't check for NULL.
 667         (prepare_for_detach): Don't check for NULL.
 668
 669 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 670
 671         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
 672          in case of call that did not complete.
 673
 674 2019-01-02  Andrey Utkin  <autkin@undo.io>
 675
 676         * symfile.c (find_separate_debug_file): Fix search of debug files for
 677         remote debuggee.
 678
 679 2019-01-02  Tom Tromey  <tom@tromey.com>
 680
 681         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
 682         indentation.
 683         * python/py-frame.c (frapy_older): Remove cast.
 684         (frapy_newer): Likewise.
 685         * python/py-breakpoint.c (local_setattro): Remove cast.
 686         * python/py-arch.c (archpy_name): Remove local variable.
 687         * python/py-type.c (gdbpy_lookup_type): Remove cast.
 688
 689 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
 690
 691         * unittests/basic_string_view/element_access/char/empty.cc:
 692         Fix year range in copyright header.
 693
 694 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
 697         Delete.
 698         <operator==>: Update with for removed field.
 699         <hash>: Likewise.
 700         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
 701         <isa_features>: ...this.
 702         <abi_features>: New field.
 703         (riscv_isa_flen): Update comment.
 704         (riscv_abi_xlen): New declaration.
 705         (riscv_abi_flen): New declaration.
 706         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
 707         isa_features.
 708         (riscv_abi_xlen): New function.
 709         (riscv_isa_flen): Update to get answer from isa_features.
 710         (riscv_abi_flen): New function.
 711         (riscv_has_fp_abi): Update to get answer from abi_features.
 712         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
 713         xlen and flen.
 714         (riscv_call_info) <xlen, flen>: Update comment.
 715         (riscv_call_arg_struct): Remove invalid assertions
 716         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
 717         is removed.
 718         (riscv_gdbarch_init): Gather isa features and abi features
 719         separately, ensure both match on the gdbarch when reusing an old
 720         gdbarch.  Relax an error check to allow 32-bit abi float to run on
 721         a target with 64-bit float hardware.
 722
 723 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 724
 725         * source.c (search_command_helper): Stop reverse search
 726         when line 1 has been searched.
 727
 728 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 729
 730         * record-full.c (record_full_base_target::close): Rewrite
 731         record_full_core_buf_list free logic.
 732
 733 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 734
 735         * break-catch-syscall.c (print_one_catch_syscall): xfree
 736         the last text.
 737
 738 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 739
 740         * top.c (print_gdb_version): Update Copyright year in version
 741         message.
 742
 743 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 744
 745         Update copyright year range in all GDB files.
 746
 747 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 748
 749         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
 750
 751 For older changes see ChangeLog-2018.
 752 \f
 753 Local Variables:
 754 mode: change-log
 755 left-margin: 8
 756 fill-column: 74
 757 version-control: never
 758 coding: utf-8
 759 End:
 760