gdb/ChangeLog

   1 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * stack.c (find_frame_funname): Remove code which preferred
   4         minsym over symtab sym in "certain pathological cases".
   5
   6         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
   7         parameter.  Change type of "do_demangle" to bool.
   8         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
   9         Pass suitable "prefer_sym_over_minsym" flag to
  10         build_address_symbolic().  Don't output "+" for negative offsets.
  11         * printcmd.c (print_address_symbolic): Update invocation of
  12         build_address_symbolic to include a "prefer_sym_over_minsym"
  13         flag.
  14         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  15         Restrict cases in which use of minimal symbol is preferred to that
  16         of a found symbol.  Update comments.
  17
  18 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
  19
  20         PR gdb/24839:
  21         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
  22         type.
  23
  24 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * python/py-objfile.c (add_separate_debug_file): Fix comment about
  27         this function's Python signature.
  28
  29
  30 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
  31
  32         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
  33         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  34         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  35         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
  36         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
  37
  38
  39 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
  40
  41         * h8300-tdep.c (h8300_register_name_common): New.
  42         h8300_register_name): Use h8300_register_name_common.
  43         (h8300s_register_name): Likewise.
  44         (h8300sx_register_name): Likewise.
  45         (h8300h_register_nam): New.
  46         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
  47
  48
  49 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
  50
  51         * arm-tdep.c (arm_skip_cmse_entry): New function.
  52         (arm_is_sgstubs_section): New function.
  53         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
  54
  55 2019-07-22  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
  58         Don't self-assign.
  59
  60 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  61
  62         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
  63         type_print.
  64
  65 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  66
  67         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  68         so that GDB doesn't match any msymbols when searching in the
  69         TYPES_DOMAIN.
  70         (print_symbol_info): Print using typedef_print or type_print based
  71         on the type of the symbol.  Add updated FIXME comment moved from...
  72         (_initialize_symtab): ... move and update FIXME comment to above.
  73
  74 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  75
  76         * NEWS: Mention adding -q option to "info types".
  77         * symtab.c (struct info_types_options): New struct.
  78         (info_types_options_defs): New variable.
  79         (make_info_types_options_def_group): New function.
  80         (info_types_command): Use gdb::option framework to parse options.
  81         (info_types_command_completer): New function.
  82         (_initialize_symtab): Extend the help text on "info types" and
  83         register command completer.
  84
  85 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  86
  87         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  88         (lookup_symbol_in_objfile): Change int to block_enum and add a
  89         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  90
  91 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  92
  93         * MAINTAINERS (Write After Approval): Add self.
  94
  95 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  96
  97         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  98         instruction to the dummy code region.
  99
 100 2019-07-19  Tom Tromey  <tromey@adacore.com>
 101
 102         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 103         (ARGSUSED, PARAMS, __func__): Remove rules.
 104
 105 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 106
 107         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 108         * features/arm/arm-with-iwmmxt.c: Remove.
 109         * features/arm/arm-with-iwmmxt.xml: Remove.
 110         * features/arm/arm-with-m-fpa-layout.c: Remove.
 111         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 112         * features/arm/arm-with-m-vfp-d16.c: Remove.
 113         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 114         * features/arm/arm-with-m.c: Remove.
 115         * features/arm/arm-with-m.xml: Remove.
 116         * features/arm/arm-with-neon.c: Remove.
 117         * features/arm/arm-with-neon.xml: Remove.
 118         * features/arm/arm-with-vfpv2.c: Remove.
 119         * features/arm/arm-with-vfpv2.xml: Remove.
 120         * features/arm/arm-with-vfpv3.c: Remove.
 121         * features/arm/arm-with-vfpv3.xml: Remove.
 122
 123 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 124
 125         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 126
 127 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 128
 129         * arch/aarch32.c (aarch32_create_target_description): Create
 130         target descriptions using features.
 131         * arch/arm.c (arm_create_target_description)
 132         (arm_create_mprofile_target_description): Likewise.
 133         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 134
 135 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 136
 137         * Makefile.in: Add new files.
 138         * aarch32-tdep.c: New file.
 139         * aarch32-tdep.h: New file.
 140         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 141         Call aarch32_read_description.
 142         * arch/aarch32.c: New file.
 143         * arch/aarch32.h: New file.
 144         * arch/arm.c (arm_create_target_description)
 145         (arm_create_mprofile_target_description): New function.
 146         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 147         (arm_create_target_description)
 148         (arm_create_mprofile_target_description): New declaration.
 149         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 150         read_description functions.
 151         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 152         Likewise.
 153         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 154         * arm-tdep.c (tdesc_arm_list): New variable.
 155         (arm_register_g_packet_guesses): Call create description functions.
 156         (arm_read_description) (arm_read_mprofile_description): New
 157         function.
 158         * arm-tdep.h (arm_read_description)
 159         (arm_read_mprofile_description): Add declaration.
 160         * configure.tgt: Add new files.
 161
 162 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 163
 164         * top.c (new_ui_command): Open specified terminal just once.
 165
 166 2019-07-18  Tom Tromey  <tromey@adacore.com>
 167
 168         * symtab.c (main_name): Constify return type.
 169         * symfile.c (set_initial_language): Update.
 170         * symtab.h (main_name): Constify return type.
 171
 172 2019-07-17  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-winsource.c (tui_update_source_window)
 175         (tui_update_source_window_as_is)
 176         (tui_update_source_windows_with_line): Remove return.
 177         * tui/tui-disasm.c (tui_show_disassem)
 178         (tui_show_disassem_and_update_source): Remove return.
 179         * tui/tui.c (tui_reset): Remove return.
 180         * tui/tui-wingeneral.c
 181         (tui_check_and_display_highlight_if_needed): Remove return.
 182
 183 2019-07-17  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 186
 187 2019-07-17  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-winsource.h (struct tui_exec_info_window)
 190         (struct tui_source_window_base): Move from tui-data.h.
 191         * tui/tui-winsource.c: Move many method definitions from
 192         elsewhere.  Remove "structuring" comments.
 193         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 194         (tui_source_window_base::refresh_window): Move to
 195         tui-winsource.c.
 196         * tui/tui-win.c (tui_source_window_base::refresh_all)
 197         (tui_source_window_base::update_tab_width)
 198         (tui_source_window_base::set_new_height)
 199         (tui_source_window_base::do_make_visible_with_new_height): Move to
 200         tui-winsource.c.
 201         * tui/tui-source.h: Update.
 202         * tui/tui-source.c (tui_source_window_base::reset): Move to
 203         tui-winsource.c.
 204         * tui/tui-disasm.h: Update.
 205         * tui/tui-data.h (struct tui_exec_info_window): Move to
 206         tui-winsource.h.
 207         (struct tui_source_window_base): Likewise.
 208         * tui/tui-data.c (tui_source_window_base::clear_detail)
 209         (tui_source_window_base, ~tui_source_window_base): Move to
 210         tui-winsource.c.
 211
 212 2019-07-17  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-win.c (tui_resize_all)
 215         (tui_source_window_base::update_tab_width)
 216         (tui_adjust_win_heights): Update.
 217         (tui_win_info::make_invisible_and_set_new_height): Rename from
 218         make_invisible_and_set_new_height.
 219         * tui/tui-data.h (struct tui_win_info)
 220         <make_invisible_and_set_new_height>: New method.
 221
 222 2019-07-17  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui.c: Update.
 225         * tui/tui-source.h (struct tui_source_window): Move from
 226         tui-data.h.
 227         * tui/tui-layout.c: Update.
 228         * tui/tui-disasm.c: Update.
 229         * tui/tui-data.h (struct tui_source_window): Move to
 230         tui-source.h.
 231
 232 2019-07-17  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 235         tui-data.h.
 236         * tui/tui-data.h (struct tui_disasm_window): Move to
 237         tui-disasm.h.
 238
 239 2019-07-17  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-regs.h (struct tui_data_item_window): Move from
 242         tui-data.h.
 243         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 244         * tui/tui-data.h (struct tui_data_item_window): Move to
 245         tui-regs.h.
 246         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 247
 248 2019-07-17  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui.c: Update.
 251         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 252         (tui_cmd_window::max_height): Move to tui-command.c.
 253         * tui/tui-layout.c: Update.
 254         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 255         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 256         tui-command.c.
 257         * tui/tui-command.h (struct tui_cmd_window): Move from
 258         tui-data.h.
 259         * tui/tui-command.c: Remove "structuring" comments.
 260         (tui_cmd_window::clear_detail)
 261         (tui_cmd_window::do_make_visible_with_new_height)
 262         (tui_cmd_window::max_height): Move from elsewhere.
 263
 264 2019-07-17  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 267         Now static.
 268         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 269         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui.c: Update.
 274         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 275         tui-regs.c.
 276         * tui/tui-windata.h: Remove file.
 277         * tui/tui-windata.c: Remove file.
 278         * tui/tui-win.c (tui_data_window::set_new_height)
 279         (tui_data_window::do_make_visible_with_new_height): Move to
 280         tui-regs.c.
 281         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 282         * tui/tui-regs.c: Remove "structuring" comments.
 283         (tui_data_window::first_data_item_displayed)
 284         (tui_data_window::delete_data_content_windows)
 285         (tui_data_window::erase_data_content)
 286         (tui_data_window::display_all_data)
 287         (tui_data_window::refresh_all)
 288         (tui_data_window::do_scroll_vertical)
 289         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 290         (tui_data_window::do_make_visible_with_new_height)
 291         (tui_data_window::refresh_window): Move from elsewhere.
 292         (_initialize_tui_regs): Move to end of file.
 293         * tui/tui-layout.c: Update.
 294         * tui/tui-hooks.c: Update.
 295         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 296         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 297         tui-regs.c.
 298         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 299
 300 2019-07-17  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 303         seen.
 304
 305 2019-07-17  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-win.c (tui_source_window_base::set_new_height)
 308         (tui_source_window_base::do_make_visible_with_new_height): Use
 309         m_has_locator field directly.
 310         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 311         method.
 312         (struct tui_source_window_base) <has_locator>: Likewise.
 313
 314 2019-07-17  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 317         Don't declare.
 318         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 319         Remove.
 320         * tui/tui-win.c (tui_source_window_base::set_new_height)
 321         (tui_source_window_base::set_new_height)
 322         (make_invisible_and_set_new_height)
 323         (tui_source_window_base::do_make_visible_with_new_height)
 324         (tui_source_window_base::do_make_visible_with_new_height):
 325         Update.
 326         * tui/tui-layout.c (show_source_disasm_command, show_data)
 327         (show_source_or_disasm_and_command): Update.
 328         * tui/tui-layout.c (show_layout): Update.
 329
 330 2019-07-17  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-layout.c (make_data_window): Remove.
 333         (show_data): Unify creation and re-initialization cases.
 334
 335 2019-07-17  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-layout.c (make_source_window, make_disasm_window):
 338         Remove.
 339         (show_data): Unify creation and re-initialization cases.
 340
 341 2019-07-17  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-layout.c (make_command_window): Remove.
 344         (show_source_disasm_command, show_source_or_disasm_and_command):
 345         Unify creation and re-initialization cases.
 346
 347 2019-07-17  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 350         creation and re-initialization cases.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-regs.c (tui_get_register): Return void.
 355
 356 2019-07-17  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 359         Simplify.
 360
 361 2019-07-17  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 364         resetting.
 365
 366 2019-07-17  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 369         * tui/tui-regs.c (tui_reg_layout): New function.
 370         (tui_show_registers, tui_reg_command): Use it.
 371         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 372         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 373         parameters.
 374         (tui_layout_command): Remove.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-layout.h (tui/tui-layout): Return void.
 379         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 380
 381 2019-07-17  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-layout.c (show_source_disasm_command, show_data):
 384         Update.
 385         (reset_locator): Remove.
 386         (show_source_or_disasm_and_command): Update.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-source.c (tui_source_window_base::reset): Remove
 391         win_type parameter.
 392         * tui/tui-layout.c (make_command_window, make_source_window)
 393         (make_disasm_window, make_data_window)
 394         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 395         (reset_locator, show_source_or_disasm_and_command): Update.
 396         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 397         win_type parameter.
 398         (struct tui_source_window_base) <reset>: Likewise.
 399
 400 2019-07-17  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-layout.c (show_source_disasm_command): Use
 403         reset_locator.
 404         (reset_locator): New function.
 405         (init_and_make_win): Remove.
 406         (show_source_or_disasm_and_command): Use reset_locator.
 407
 408 2019-07-17  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 411         condition.
 412         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 413         Remove condition.
 414         * tui/tui-source.c (tui_source_window_base::reset): New method.
 415         * tui/tui-layout.c (make_command_window): Don't call
 416         init_and_make_win.
 417         (make_source_window, make_disasm_window): Don't call
 418         make_source_or_disasm_window.
 419         (make_data_window): Don't call init_and_make_win.  Change calling
 420         convention.
 421         (show_source_disasm_command, show_data): Simplify.
 422         (make_source_or_disasm_window): Remove.
 423         (show_source_or_disasm_and_command): Simplify.
 424         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 425         (struct tui_source_window_base) <reset>: Likewise.
 426         <execution_info>: Remove initializer.
 427         * tui/tui-data.c (tui_source_window_base): Initialize
 428         execution_info.
 429
 430 2019-07-17  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 433         variable.
 434
 435 2019-07-17  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui.c (tui_rl_other_window): Update.
 438         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 439         superclass method first.  Always iterate over regs_content.
 440         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 441         method.
 442         * tui/tui-win.c (tui_set_focus_command): Update.
 443
 444 2019-07-17  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-win.c (tui_set_focus_command): Rename from
 447         tui_set_focus.  Call tui_enable.
 448         (tui_set_focus_command): Remove.
 449
 450 2019-07-17  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 453         refresh_window.
 454         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 455         touchwin.
 456         (tui_data_window::refresh_window): Call refresh_window on data
 457         items.  Always call superclass refresh_window.
 458         (tui_win_info::refresh): Remove.
 459         (tui_source_window_base::refresh_window): Update.
 460         (tui_refresh_all): Update.
 461         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 462         refresh_window.
 463         (show_source_or_disasm_and_command): Likewise.
 464         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 465         (struct tui_source_window_base) <refresh>: Likewise.
 466
 467 2019-07-17  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-winsource.c (tui_clear_source_content)
 470         (tui_show_source_content): Update.
 471         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 472         whether content is empty.
 473         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 474         Remove.
 475
 476 2019-07-17  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 479         window's contents.
 480         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 481         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 482
 483 2019-07-17  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 486         (struct tui_data_item_window): Update.
 487
 488 2019-07-17  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 491         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 492         defines.
 493
 494 2019-07-17  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-winsource.h (tui_erase_source_content)
 497         (tui_clear_source_content): Remove "display_prompt" parameter.
 498         * tui/tui-winsource.c (tui_update_source_window_as_is)
 499         (tui_update_source_windows_with_addr): Update.
 500         (tui_clear_source_content): Remove "display_prompt" parameter.
 501         (tui_erase_source_content): Likewise.  Simplify.
 502         (tui_show_source_content): Update.
 503         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 504         * tui/tui-stack.c (tui_show_frame_info): Update.
 505         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 506         Remove defines.
 507
 508 2019-07-17  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 511         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 512         parameter.
 513         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 514         parameter.
 515
 516 2019-07-17  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-winsource.c (tui_clear_source_content)
 519         (tui_show_source_content, tui_show_exec_info_content)
 520         (tui_clear_exec_info_content): Update.
 521         * tui/tui-stack.c (tui_show_locator_content): Update.
 522         (tui_show_frame_info): Update.
 523         * tui/tui-source.h (tui_source_window): Don't declare.
 524         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 525         from tui_source_is_displayed.
 526         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 527         Remove field.
 528         (struct tui_source_window_base) <content_in_use>: New field.  Now
 529         bool.
 530         (struct tui_source_window) <showing_source_p>: New method.
 531         (TUI_SRC_WIN): Change cast.
 532         * tui/tui-data.c (tui_initialize_static_data): Update.
 533
 534 2019-07-17  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 537         location_matches_p.
 538         * tui/tui-source.c (tui_source_window::location_matches_p): New
 539         method.
 540         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 541         method.
 542         * tui/tui-data.h (struct tui_source_window_base)
 543         <location_matches_p>: New method.
 544         (struct tui_source_window, struct tui_disasm_window)
 545         <location_matches_p>: Likewise.
 546
 547 2019-07-17  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-win.c (tui_set_win_height_command): Rename from
 550         tui_set_win_height.
 551         (tui_set_win_height_command): Remove.
 552
 553 2019-07-17  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-source.c (tui_source_window): New constructor.  Add
 556         observer.
 557         (~tui_source_window): New destructor.
 558         (tui_source_window::style_changed): New method.
 559         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 560         (tui_attach_detach_observers): Update.
 561         * tui/tui-data.h (struct tui_source_window): Make constructor not
 562         inline.  Add destructor.
 563         (struct tui_source_window) <style_changed>: New method.
 564         <m_observable>: New member.
 565
 566 2019-07-17  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 569         * tui/tui-win.c (tui_resize_all): Fix typo.
 570
 571 2019-07-17  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 574         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 575         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 576         * tui/tui-win.c (window_name_completer): Use foreach.
 577         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 578         (update_tab_width): Likewise.
 579         * tui/tui-layout.c (show_layout): Update.
 580         * tui/tui-data.h (class tui_window_iterator): New.
 581         (struct all_tui_windows): New.
 582         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 583
 584 2019-07-17  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 587         parameter.  Don't reference globals.
 588         (tui_reg_command): Update.
 589
 590 2019-07-17  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-regs.c (tui_show_registers): Simplify.
 593
 594 2019-07-17  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-regs.c (tui_show_registers): Update.
 597         (tui_show_register_group): Add win_info parameter.
 598
 599 2019-07-17  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 602         Rename from tui_display_reg_element_at_line.
 603         (tui_data_window::display_registers_from_line): Update.
 604         * tui/tui-data.h (struct tui_data_window)
 605         <display_reg_element_at_line>: New method.
 606
 607 2019-07-17  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-regs.h (tui_display_registers_from)
 610         (tui_display_registers_from_line): Don't declare.
 611         * tui/tui-windata.c (tui_data_window::display_all_data)
 612         (tui_data_window::refresh_all)
 613         (tui_data_window::do_scroll_vertical): Update.
 614         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 615         from tui_display_registers_from.
 616         (tui_display_reg_element_at_line): Update.
 617         (tui_data_window::display_registers_from_line): Rename from
 618         tui_display_registers_from_line.
 619         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 620         display_registers_from_line>: New methods.
 621
 622 2019-07-17  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 625         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 626         from tui_erase_data_content.
 627         (tui_data_window::display_all_data)
 628         (tui_data_window::refresh_all)
 629         (tui_data_window::do_scroll_vertical): Update.
 630         * tui/tui-regs.c (tui_show_registers): Update.
 631         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 632         New method.
 633
 634 2019-07-17  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 637         declare.
 638         * tui/tui-windata.c
 639         (tui_data_window::delete_data_content_windows): Rename from
 640         tui_delete_data_content_windows.
 641         (tui_data_window::display_all_data)
 642         (tui_data_window::do_scroll_vertical): Update.
 643         * tui/tui-data.h (struct tui_data_window)
 644         <delete_data_content_windows>: New method.
 645
 646 2019-07-17  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 649         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 650
 651 2019-07-17  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 654         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 655         from tui_display_all_data.
 656         * tui/tui-win.c
 657         (tui_data_window::do_make_visible_with_new_height): Update.
 658         * tui/tui-regs.c (tui_show_registers): Update.
 659         * tui/tui-layout.c (tui_set_layout): Update.
 660         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 661         method.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 666         * tui/tui-windata.c (tui_display_data_from): Remove.
 667         (tui_data_window::refresh_all): Update.
 668
 669 2019-07-17  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 672         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 673         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 674         tui_display_registers_from_line.
 675         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 676         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 677         "force_display" parameter.
 678
 679 2019-07-17  Tom Tromey  <tom@tromey.com>
 680
 681         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 682         declare.
 683         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 684         Rename from tui_first_reg_element_no_inline.
 685         (tui_display_reg_element_at_line)
 686         (tui_display_registers_from_line): Update.
 687         * tui/tui-data.h (struct tui_data_window)
 688         <first_reg_element_no_inline>: New method.
 689
 690 2019-07-17  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-windata.c (tui_display_data_from)
 693         (tui_data_window::do_scroll_vertical): Update.
 694         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 695         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 696         Rename from tui_line_from_reg_element_no.
 697         (tui_display_registers_from_line): Update.
 698         * tui/tui-data.h (struct tui_data_window)
 699         <line_from_reg_element_no>: New method.
 700
 701 2019-07-17  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 704         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 705         tui_last_regs_line_no.
 706         (tui_display_reg_element_at_line)
 707         (tui_display_registers_from_line): Update.
 708         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 709         method.
 710
 711 2019-07-17  Tom Tromey  <tom@tromey.com>
 712
 713         PR tui/24722:
 714         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 715         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 716         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 717         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 718         (tui_update_breakpoint_info): Likewise.
 719         * tui/tui-hooks.c (tui_event_create_breakpoint)
 720         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 721         Update.
 722
 723 2019-07-17  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 726
 727 2019-07-17  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-winsource.c (tui_update_source_window_as_is)
 730         (tui_update_source_windows_with_addr): Update.
 731         * tui/tui-source.h (tui_set_source_content)
 732         (tui_show_symtab_source): Add "win_info" parameter.
 733         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 734         parameter.
 735         (tui_show_symtab_source): Likewise.
 736
 737 2019-07-17  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-wingeneral.c
 740         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 741
 742 2019-07-17  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 745         (struct tui_cmd_window) <can_scroll>: New method.
 746         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 747         method.
 748
 749 2019-07-17  Tom Tromey  <tromey@adacore.com>
 750
 751         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 752         do_field_signed>: Rename.  Change type of "value".
 753         * ui-out.c (ui_out::field_signed): Rename from field_int.
 754         Change type of "value".
 755         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 756         type of "value".
 757         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 758         do_field_int.  Change type of "value".
 759         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 760         do_field_int.  Change type of "value".
 761         * tracepoint.c (trace_status_mi, tfind_1)
 762         (print_one_static_tracepoint_marker): Update.
 763         * thread.c (print_thread_info_1, print_selected_thread_frame):
 764         Update.
 765         * stack.c (print_frame, print_frame_info): Update.
 766         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 767         Update.
 768         * source.c (print_source_lines_base): Update.
 769         * skip.c (info_skip_command): Update.
 770         * record-btrace.c (btrace_ui_out_decode_error)
 771         (btrace_call_history_src_line): Update.
 772         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 773         Update.
 774         * progspace.c (print_program_space): Update.
 775         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 776         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 777         do_field_int.  Change type of "value".
 778         * mi/mi-out.c (mi_ui_out::do_table_begin)
 779         (mi_ui_out::do_table_header): Update.
 780         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 781         type of "value".
 782         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 783         (mi_cmd_data_list_changed_registers, output_register)
 784         (mi_cmd_data_read_memory, mi_load_progress)
 785         (mi_cmd_trace_frame_collected): Update.
 786         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 787         Update.
 788         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 789         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 790         (mi_cmd_var_list_children, varobj_update_one): Update.
 791         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 792         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 793         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 794         * inferior.c (print_inferior): Update.
 795         * gdb_bfd.c (print_one_bfd): Update.
 796         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 797         Update.
 798         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 799         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 800         do_field_int.  Change type of "value".
 801         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 802         do_field_int.  Change type of "value".
 803         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 804         (print_one_breakpoint_location, print_it_catch_fork)
 805         (print_one_catch_fork, print_it_catch_vfork)
 806         (print_one_catch_vfork, print_it_catch_solib)
 807         (print_it_catch_exec, print_it_ranged_breakpoint)
 808         (print_mention_watchpoint, print_mention_masked_watchpoint)
 809         (bkpt_print_it, update_static_tracepoint): Update.
 810         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 811         * break-catch-syscall.c (print_it_catch_syscall): Update.
 812         * ada-tasks.c (print_ada_task_info): Update.
 813         * ada-lang.c (print_it_exception, print_mention_exception):
 814         Update.
 815
 816 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         PR breakpoints/24541
 819         * gdbarch.c: Regenerate.
 820         * gdbarch.h: Regenerate.
 821         * gdbarch.sh: Adjust return type and parameter types for
 822         'stap_adjust_register'.
 823         (i386_stap_adjust_register): Adjust signature and return new
 824         register name.
 825         * stap-probe.c (stap_parse_register_operand): Adjust use of
 826         'gdbarch_stap_adjust_register'.
 827
 828 2019-07-17  Tom Tromey  <tromey@adacore.com>
 829
 830         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 831         declare VEC.
 832         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 833         std::vector.
 834         (struct s390_process_info): Add initializers.
 835         (s390_add_process): Use new.
 836         (s390_linux_nat_target::low_forget_process): Use delete.
 837         (s390_linux_nat_target::low_new_fork)
 838         (s390_linux_nat_target::stopped_by_watchpoint)
 839         (s390_linux_nat_target::low_prepare_to_resume)
 840         (s390_linux_nat_target::insert_watchpoint)
 841         (s390_linux_nat_target::insert_hw_breakpoint)
 842         (s390_linux_nat_target::remove_watchpoint)
 843         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 844
 845 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 846
 847         * aarch64-fbsd-nat.c: Include regcache.h.
 848         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 849         argument.
 850         (aarch64_fbsd_nat_target::fetch_registers)
 851         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 852         variable.
 853         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 854
 855 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 856
 857         * fbsd-nat.c: Include gdbarch.h.
 858
 859 2019-07-15  Tom Tromey  <tromey@adacore.com>
 860
 861         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 862
 863 2019-07-15  Tom Tromey  <tromey@adacore.com>
 864
 865         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 866         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 867         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 868         * cli-out.c (cli_ui_out::do_field_int): New method.
 869         * ui-out.c (ui_out::field_unsigned): New method.
 870         * symfile.c (generic_load): Use field_unsigned.
 871         (print_transfer_performance): Likewise.
 872         * record-btrace.c (ui_out_field_uint): Remove.
 873         (btrace_call_history_insn_range, btrace_call_history): Use
 874         field_unsigned.
 875         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 876         field_unsigned.
 877         * ui-out.h (class ui_out) <field_unsigned>: New method.
 878         <do_field_unsigned>: Likewise.
 879
 880 2019-07-15  Tom Tromey  <tromey@adacore.com>
 881
 882         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 883         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 884         * target.c (flash_erase_command): Use field_string.
 885         * infrun.c (print_signal_received_reason): Use field_string.
 886         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 887         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 888         field_string.
 889         * ada-tasks.c (print_ada_task_info): Use field_string.
 890
 891 2019-07-15  Tom Tromey  <tromey@adacore.com>
 892
 893         * target.c (flash_erase_command): Use field_core_addr.
 894         * symfile.c (generic_load): Use field_core_addr.
 895         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 896         Use field_core_addr.
 897         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 898         field_core_addr.
 899
 900 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 903         value if its desired type is smaller than a CORE_ADDR and signed.
 904
 905 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 908         of changes to field names, and use new is_reference field to
 909         decide if a property is a reference or not.
 910         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 911         field.
 912         (struct dwarf2_property_baton): Update header comment, rename
 913         'referenced_type' to 'property_type' and update comments.
 914         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 915         default property type, store in property baton, update to take
 916         accound of renamed field.
 917         (read_func_scope): Update call to attr_to_dynamic_prop.
 918         (read_array_type): Likewise.
 919         (dwarf2_per_cu_addr_sized_int_type): New function.
 920         (read_subrange_index_type): Move type finding code to
 921         dwarf2_per_cu_addr_sized_int_type.
 922         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 923         (dwarf2_per_cu_addr_type): New function.
 924         (set_die_type): Update calls to attr_to_dynamic_prop.
 925
 926 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 927
 928         * dwarf2read.c (read_subrange_index_type): New function.
 929         (read_subrange_type): Move code into new function and call it.
 930         * gdbtypes.c (create_range_type): Add some asserts.
 931
 932 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 933
 934         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 935         update return statements.
 936         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 937         declaration, and update comment to match.
 938         * gdbtypes.c (resolve_dynamic_array): Update call to
 939         dwarf2_evaluate_property to match new return type.
 940
 941 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 942
 943         * valarith.c (value_subscripted_rvalue): Change lowerbound
 944         parameter type from int to LONGEST.
 945         * value.h (value_subscripted_rvalue): Likewise in declaration.
 946
 947 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * cli/cli-utils.c (info_print_command_completer): New function.
 950         * cli/cli-utils.h: Add 'completer.h' include, and forward
 951         declaration for 'struct cmd_list_element'.
 952         (info_print_command_completer): Declare.
 953         * stack.c (_initialize_stack): Add completer for 'info locals' and
 954         'info args'.
 955         * symtab.c (_initialize_symtab): Add completer for 'info
 956         variables' and 'info functions'.
 957         * NEWS: Mention completion for additional info commands.
 958
 959 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * cli/cli-utils.c (extract_info_print_args): Delete.
 962         (extract_arg_maybe_quoted): Delete.
 963         (info_print_options_defs): New variable.
 964         (make_info_print_options_def_group): New function.
 965         (extract_info_print_options): Define new function.
 966         * cli/cli-utils.h (extract_info_print_args): Delete.
 967         (struct info_print_options): New structure.
 968         (extract_info_print_options): Declare new function.
 969         * stack.c (info_locals_command): Update to use new
 970         extract_info_print_options, also add a header comment.
 971         (info_args_command): Likewise.
 972         * symtab.c (info_variables_command): Likewise.
 973         (info_functions_command): Likewise.
 974
 975 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 976
 977         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 978         to extract string arguments.
 979         * common/common-utils.c (extract_string_maybe_quoted): New function.
 980         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 981
 982 2019-07-11  Tom Tromey  <tromey@adacore.com>
 983
 984         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 985         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 986         * top.h (gdbinit): Don't declare.
 987         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 988         into...
 989         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 990         * top.c (gdb_init): Don't call init_cli_cmds.
 991         (gdbinit): Remove.
 992         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 993
 994 2019-07-11  Tom Tromey  <tromey@adacore.com>
 995
 996         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 997         after it has been moved.
 998
 999 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1000
1001         * valops.c (value_must_coerce_to_target): Change return type to
1002         bool.
1003         * value.h (value_must_coerce_to_target): Likewise.
1004
1005 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1006
1007         * breakpoint.c (is_hardware_watchpoint): Remove
1008         forward-declaration.
1009         (is_masked_watchpoint): Change return type to bool.
1010         (is_tracepoint): Likewise.
1011         (is_breakpoint): Likewise.
1012         (is_hardware_watchpoint): Likewise.
1013         (is_watchpoint): Likewise.
1014         (is_no_memory_software_watchpoint): Likewise.
1015         (is_catchpoint): Likewise.
1016         (breakpoint_1): Make FILTER parameter's return type bool.
1017         is_masked_watchpoint): Change return type to bool.
1018         (save_breakpoints): Make FILTER parameter's return type bool.
1019         * breakpoint.h (is_breakpoint): Change return type to bool.
1020         (is_watchpoint): Likewise.
1021         (is_catchpoint): Likewise.
1022         (is_tracepoint): Likewise.
1023
1024 2019-07-10  Tom Tromey  <tom@tromey.com>
1025
1026         * defs.h: Don't include gdbarch.h.
1027         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1028         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1029         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1030         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1031         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1032         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1033         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1034         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1035         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1036         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1037         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1038         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1039         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1040         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1041         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1042         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1043         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1044         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1045         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1046         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1047         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1048         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1049         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1050         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1051         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1052         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1053         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1054
1055 2019-07-10  Tom Tromey  <tromey@adacore.com>
1056
1057         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1058         * breakpoint.c (init_ada_exception_breakpoint): Register as
1059         bp_catchpoint.
1060         (print_one_breakpoint_location, print_one_breakpoint): Use
1061         is_ada_exception_catchpoint.
1062         * ada-lang.c (class ada_catchpoint_location): Pass
1063         bp_loc_software_breakpoint to bp_location constructor.
1064         (is_ada_exception_catchpoint): New function.
1065
1066 2019-07-10  Tom Tromey  <tromey@adacore.com>
1067
1068         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1069         VEC.
1070         (struct arm_exidx_entry): New method operator<.
1071         (struct arm_exidx_data) <section_maps>: Change type.
1072         (arm_exidx_data_free): Remove.
1073         (arm_exidx_data_key): Change type.  Move lower.
1074         (arm_exidx_new_objfile): Update.
1075         (arm_compare_exidx_entries): Remove.
1076         (arm_find_exidx_entry, _initialize_arm_tdep)
1077
1078 2019-07-10  Tom Tromey  <tromey@adacore.com>
1079
1080         * solib-spu.c (ocl_program_data_key): Change type.
1081         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1082         Update.
1083
1084 2019-07-10  Tom Tromey  <tromey@adacore.com>
1085
1086         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1087         (struct solib_aix_inferior_data) <library_list>: Change type.
1088         (solib_aix_inferior_data_handle): Change type.
1089         (get_solib_aix_inferior_data): Update.
1090         (solib_aix_free_library_list): Remove.
1091         (library_list_start_library): Update.
1092         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1093         return type.
1094         (solib_aix_get_library_list)
1095         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1096         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1097
1098 2019-07-10  Tom Tromey  <tromey@adacore.com>
1099
1100         * solib-dsbt.c (struct dsbt_info): Add initializers.
1101         (solib_dsbt_pspace_data): Change type.
1102         (dsbt_pspace_data_cleanup): Remove.
1103         (get_dsbt_info, _initialize_dsbt_solib): Update.
1104
1105 2019-07-10  Tom Tromey  <tromey@adacore.com>
1106
1107         * spu-tdep.c (spu_overlay_data): Change type.
1108         (spu_get_overlay_table, spu_overlay_new_objfile)
1109         (_initialize_spu_tdep): Update.
1110
1111 2019-07-10  Tom Tromey  <tromey@adacore.com>
1112
1113         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1114         destructor.
1115         (dbx_objfile_data_key): Change type and declare later.
1116         (DBX_SYMFILE_INFO): Rewrite.
1117         * dbxread.c (dbx_objfile_data_key): Change type.
1118         (dbx_symfile_init): Update.
1119         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1120         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1121         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1122
1123 2019-07-10  Tom Tromey  <tromey@adacore.com>
1124
1125         * jit.c (jit_program_space_key): Change type.  Move lower.
1126         (get_jit_program_space_data): Update.
1127         (jit_program_space_data_cleanup): Remove.
1128         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1129         Update.
1130         (struct jit_program_space_data): Add initializers.
1131
1132 2019-07-10  Tom Tromey  <tromey@adacore.com>
1133
1134         * solib-darwin.c (struct darwin_info): Add initializers.
1135         (solib_darwin_pspace_data): Change type.
1136         (darwin_pspace_data_cleanup): Remove.
1137         (get_darwin_info, _initialize_darwin_solib): Update.
1138
1139 2019-07-10  Tom Tromey  <tromey@adacore.com>
1140
1141         * remote-sim.c (struct sim_inferior_data): Add initializers,
1142         constructor, and destructor.
1143         (sim_inferior_data_key): Change type.  Move lower.
1144         (check_for_duplicate_sim_descriptor): Update.
1145         (get_sim_inferior_data): Use new.  Update.
1146         (~sim_inferior_data_cleanup): Rename from
1147         sim_inferior_data_cleanup.  Simplify.
1148         (gdbsim_close_inferior, simulator_command)
1149         (sim_command_completer, _initialize_remote_sim): Update.
1150         (next_pid, INITIAL_PID): Move earlier.
1151
1152 2019-07-10  Tom Tromey  <tromey@adacore.com>
1153
1154         * python/python-internal.h (create_thread_object): Return
1155         gdbpy_ref.
1156         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1157         * python/py-inferior.c (struct threadlist_entry): Add
1158         constructor.
1159         <thread_obj>: Now a gdbpy_ref.
1160         (thread_to_thread_object): Update.
1161         (add_thread_object): Use new.
1162         (delete_thread_object): Use delete.
1163         (infpy_threads): Update.
1164         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1165         GIL.
1166
1167 2019-07-10  Tom Tromey  <tromey@adacore.com>
1168
1169         * valops.c (value_cast): Specialize error message for Ada.
1170
1171 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1172
1173         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1174
1175 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1176
1177         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1178         bpstat_should_step): Return bool, adjust comments.
1179         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1180         bpstat_should_step): Likewise.
1181
1182 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1183
1184         * features/Makefile: Use feature target descriptions for Arm.
1185         * features/arm/arm-core.c: Generate new file.
1186         * features/arm/arm-fpa.c: Likewise.
1187         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1188         * features/arm/arm-m-profile.c: Likewise.
1189         * features/arm/arm-vfpv2.c: Likewise.
1190         * features/arm/arm-vfpv3.c: Likewise.
1191         * features/arm/xscale-iwmmxt.c: Likewise.
1192         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1193
1194 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1195
1196         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1197         ptrace earlier.
1198
1199 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1200
1201         * features/aarch64-pauth.c: Regenerate.
1202
1203 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1204
1205         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1206         bool.
1207         (bpstat_what): Use false instead of 0.
1208
1209 2019-07-09  Pedro Alves  <palves@redhat.com>
1210
1211         * break-catch-throw.c (is_exception_catchpoint): New.
1212         * breakpoint.c (print_one_breakpoint_location): New parameter
1213         'raw_loc'.  Handle it.  Use
1214         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1215         looking at the breakpoint's type.
1216         (print_one_breakpoint): If handling "maint info breakpoints", also
1217         print locations of exception catchpoints.
1218         * breakpoint.h (is_exception_catchpoint): Declare.
1219
1220 2019-07-09  Pedro Alves  <palves@redhat.com>
1221
1222         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1223         "addr" field.
1224         (allocate_location_exception_catchpoint): New.
1225         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1226         (initialize_throw_catchpoint_ops): Install
1227         allocate_location_exception_catchpoint as allocate_location
1228         method.
1229         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1230         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1231         bp_loc_other.
1232         (breakpoint_address_is_meaningful): Delete.
1233         (bl_address_is_meaningful): New.
1234         (breakpoint_locations_match): Adjust comment.
1235         (bp_location_from_bp_type): New, factored out of...
1236         (bp_location::bp_location(breakpoint *)): ... this.
1237         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1238         factored out of...
1239         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1240         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1241         breakpoint_address_is_meaningful.
1242         (bp_locations_compare): Adjust comment.
1243         (update_global_location_list): Use bl_address_is_meaningful
1244         instead of breakpoint_address_is_meaningful.
1245         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1246         explicit.
1247         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1248         * python/py-breakpoint.c (bppy_get_location): No longer check
1249         whether location is null.
1250
1251 2019-07-09  Pedro Alves  <palves@redhat.com>
1252
1253         PR c++/15468
1254         * breakpoint.c (print_one_breakpoint_location): Remove
1255         single-location assert.
1256
1257 2019-07-09  Tom Tromey  <tom@tromey.com>
1258
1259         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1260         * configure: Rebuild.
1261         * configure.ac: Change common to gdbsupport.
1262         * gdbsupport: Rename from common.
1263         * acinclude.m4: Change common to gdbsupport.
1264         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1265         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1266         gdbsupport.
1267         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1268         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1269         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1270         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1271         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1272         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1273         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1274         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1275         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1276         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1277         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1278         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1279         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1280         coff-pe-read.c, command.h, compile/compile-c-support.c,
1281         compile/compile-c.h, compile/compile-cplus-symbols.c,
1282         compile/compile-cplus-types.c, compile/compile-cplus.h,
1283         compile/compile-loc2c.c, compile/compile.c, completer.c,
1284         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1285         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1286         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1287         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1288         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1289         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1290         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1291         features/aarch64-core.c, features/aarch64-fpu.c,
1292         features/aarch64-pauth.c, features/aarch64-sve.c,
1293         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1294         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1295         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1296         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1297         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1298         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1299         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1300         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1301         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1302         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1303         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1304         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1305         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1306         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1307         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1308         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1309         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1310         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1311         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1312         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1313         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1314         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1315         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1316         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1317         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1318         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1319         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1320         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1321         minsyms.c, mips-linux-tdep.c, namespace.h,
1322         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1323         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1324         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1325         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1326         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1327         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1328         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1329         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1330         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1331         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1332         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1333         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1334         procfs.c, producer.c, progspace.h, psymtab.h,
1335         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1336         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1337         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1338         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1339         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1340         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1341         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1342         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1343         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1344         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1345         target-memory.c, target.c, target.h, target/waitstatus.c,
1346         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1347         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1348         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1349         unittests/array-view-selftests.c,
1350         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1351         unittests/common-utils-selftests.c,
1352         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1353         unittests/format_pieces-selftests.c,
1354         unittests/function-view-selftests.c,
1355         unittests/lookup_name_info-selftests.c,
1356         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1357         unittests/mkdir-recursive-selftests.c,
1358         unittests/observable-selftests.c,
1359         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1360         unittests/parse-connection-spec-selftests.c,
1361         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1362         unittests/scoped_fd-selftests.c,
1363         unittests/scoped_mmap-selftests.c,
1364         unittests/scoped_restore-selftests.c,
1365         unittests/string_view-selftests.c, unittests/style-selftests.c,
1366         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1367         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1368         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1369         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1370         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1371         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1372
1373 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1376         bool value.
1377         (decode_digits_ordinary): Set explicit_line field in sal.
1378         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1379         symtab_and_line that was set on an explicit line number in
1380         assembler code.  Do always update the recorded symtab and line if
1381         we do skip the prologue.
1382
1383 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         * breakpoint.c (set_breakpoint_location_function): Remove
1386         explicit_loc parameter.
1387         (momentary_breakpoint_from_master): Update call to
1388         set_breakpoint_location_function.
1389         (add_location_to_breakpoint): Likewise.
1390
1391 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1394         required features based on default bfd type when no specific bfd
1395         is present.
1396
1397 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1398
1399         * NEWS: Mention that GDB printf and eval commands can now print
1400         C-style and Ada-style convenience var strings without
1401         calling the inferior.
1402         * printcmd.c (printf_c_string): Locally print GDB internal var
1403         instead of transiting via the inferior.
1404         (printf_wide_c_string): Likewise.
1405
1406 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1407
1408         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1409
1410 2019-07-04  Tom Tromey  <tom@tromey.com>
1411
1412         PR tui/24724:
1413         * tui/tui-winsource.c (tui_clear_source_content): Update.
1414         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1415         (tui_update_breakpoint_info): Update.
1416         (tui_set_exec_info_content): Update.
1417         * tui/tui-source.c (tui_set_source_content_nil): Update.
1418         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1419         has_break.
1420         * tui/tui-data.h (enum tui_bp_flag): New.
1421         (tui_bp_flags): New enum flags type.
1422         (struct tui_source_element) <break_mode>: Change type.  Rename
1423         from has_break.
1424         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1425         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1426         constants.
1427         * tui/tui-winsource.h: Fix comment.
1428
1429 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1430
1431         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1432         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1433         (store_fpregs_to_thread)
1434         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1435         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1436         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1437         (IWMMXT_REGS_SIZE): Add define.
1438         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1439         (fetch_vfp_regs, store_vfp_regs)
1440         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1441         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1442
1443 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1444
1445         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1446         defines.
1447         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1448         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1449         (ARM_INT_REGISTER_SIZE): ...to this.
1450         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1451         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1452         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1453         (arm_linux_collect_gregset, supply_nwfpe_register)
1454         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1455         defines.
1456         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1457         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1458         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1459         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1460         (arm_return_in_memory, arm_store_return_value)
1461         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1462         (arm_record_ld_st_multiple): Likewise.
1463         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1464         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1465
1466 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1467
1468         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1469         AARCH64_DISPLACED_MODIFIED_INSNS.
1470         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1471         (aarch64_displaced_step_copy_insn): Likewise.
1472         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1473         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1474         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1475         ARM_DISPLACED_MODIFIED_INSNS.
1476         * arm-tdep.c (arm_gdbarch_init): Likewise.
1477         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1478         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1479         (struct arm_displaced_step_closure): Use
1480         ARM_DISPLACED_MODIFIED_INSNS.
1481
1482 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1483
1484         * features/Makefile: Remove unused xml files.
1485         * features/aarch64.xml: Remove.
1486         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1487         * features/i386/amd64-avx-avx512.xml: Remove.
1488         * features/i386/amd64-avx-linux.xml: Remove.
1489         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1490         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1491         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1492         * features/i386/amd64-avx-mpx.xml: Remove.
1493         * features/i386/amd64-avx.xml: Remove.
1494         * features/i386/amd64-linux.xml: Remove.
1495         * features/i386/amd64-mpx-linux.xml: Remove.
1496         * features/i386/amd64-mpx.xml: Remove.
1497         * features/i386/amd64.xml: Remove.
1498         * features/i386/i386-avx-avx512-linux.xml: Remove.
1499         * features/i386/i386-avx-avx512.xml: Remove.
1500         * features/i386/i386-avx-linux.xml: Remove.
1501         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1502         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1503         * features/i386/i386-avx-mpx-linux.xml: Remove.
1504         * features/i386/i386-avx-mpx.xml: Remove.
1505         * features/i386/i386-avx.xml: Remove.
1506         * features/i386/i386-linux.xml: Remove.
1507         * features/i386/i386-mmx-linux.xml: Remove.
1508         * features/i386/i386-mmx.xml: Remove.
1509         * features/i386/i386-mpx-linux.xml: Remove.
1510         * features/i386/i386-mpx.xml: Remove.
1511         * features/i386/i386.xml: Remove.
1512         * features/i386/x32-avx-avx512-linux.xml: Remove.
1513         * features/i386/x32-avx-linux.xml: Remove.
1514         * features/i386/x32-linux.xml: Remove.
1515
1516 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1517
1518         * regformats/aarch64.dat: Remove.
1519         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1520         * regformats/i386/amd64-avx-linux.dat: Remove.
1521         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1522         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1523         * regformats/i386/amd64-linux.dat: Remove.
1524         * regformats/i386/amd64-mpx-linux.dat: Remove.
1525         * regformats/i386/amd64.dat: Remove.
1526         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1527         * regformats/i386/i386-avx-linux.dat: Remove.
1528         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1529         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1530         * regformats/i386/i386-linux.dat: Remove.
1531         * regformats/i386/i386-mmx-linux.dat: Remove.
1532         * regformats/i386/i386-mpx-linux.dat: Remove.
1533         * regformats/i386/i386.dat: Remove.
1534         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1535         * regformats/i386/x32-avx-linux.dat: Remove.
1536         * regformats/i386/x32-linux.dat: Remove.
1537
1538 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1539
1540         * aarch64-tdep.c: Remove xml self tests.
1541         * amd64-linux-tdep.c: Likewise.
1542         * amd64-tdep.c: Likewise.
1543         * i386-linux-tdep.c: Likewise.
1544         * i386-tdep.c: Likewise.
1545
1546 2019-07-03  Pedro Alves  <palves@redhat.com>
1547
1548         PR cli/24732
1549         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1550         (pipe_cmd_option_defs): New.
1551         (make_pipe_cmd_options_def_group): New.
1552         (pipe_command): Use gdb::option::process_options.
1553         (pipe_command_completer): New function.
1554         (_initialize_cli_cmds): Install completer for "pipe" command.
1555
1556 2019-07-03  Pedro Alves  <palves@redhat.com>
1557
1558         * cli/cli-option.c (union option_value) <string>: New field.
1559         (struct option_def_and_value): Add ctor, move ctor, dtor and
1560         use DISABLE_COPY_AND_ASSIGN.
1561         (option_def_and_value::clear_value): New.
1562         (parse_option, save_option_value_in_ctx, get_val_type_str)
1563         (add_setshow_cmds_for_options): Handle var_string.
1564         * cli-option.h (union option_def::var_address) <string>: New
1565         field.
1566         (struct string_option_def): New.
1567         * maint-test-options.c (struct test_options_opts): Add default
1568         ctor and use DISABLE_COPY_AND_ASSIGN.
1569         <string_opt>: New field.
1570         (test_options_opts::~test_options_opts): New.
1571         (test_options_opts::dump): Also dump "-string".
1572         (test_options_option_defs): Install "string.
1573
1574 2019-07-03  Pedro Alves  <palves@redhat.com>
1575
1576         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1577         option_value with a null enumeration.
1578         (complete_options): Save the option values in the context.
1579         (save_option_value_in_ctx): New, factored out from ...
1580         (process_options): ... here.
1581         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1582         of the function.
1583         * maint-test-options.c (test_options_opts::dump): New, factored
1584         out from ...
1585         (maintenance_test_options_command_mode): ... here.
1586         (maintenance_test_options_command_completion_result): Delete.
1587         (maintenance_test_options_command_completion_text): Update
1588         comment.
1589         (maintenance_show_test_options_completion_result): Change
1590         prototype.  Just print
1591         maintenance_test_options_command_completion_text.
1592         (save_completion_result): New.
1593         (maintenance_test_options_completer_mode): Pass options context to
1594         complete_options, and then save a dump.
1595         (_initialize_maint_test_options): Use add_cmd to install "maint
1596         show test-options-completion-result".
1597
1598 2019-07-03  Pedro Alves  <palves@redhat.com>
1599
1600         * NEWS (New commands): Mention "with" and "maint with".
1601         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1602         (with_command, with_command_completer): New.
1603         (pipe_command): Adjust to new repeat_previous
1604         interface.
1605         (_initialize_cli_cmds): Install the "with" command and its "w"
1606         alias.
1607         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1608         declarations.
1609         * cli/cli-setshow.c (parse_cli_var_uinteger)
1610         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1611         argument strings for all var_types.
1612         (get_setshow_command_value_string): New, factored out from ...
1613         (do_show_command): ... this.
1614         * cli/cli-setshow.h: Include <string>.
1615         (get_setshow_command_value_string): Declare.
1616         * command.h (repeat_previous): Now returns const char *.  Adjust
1617         comment.
1618         * maint.c: Include "cli/cli-cmds.h".
1619         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1620         (_initialize_maint_cmds): Register the "maintenance with" command.
1621         * top.c (repeat_previous): Move bits from pipe_command here:
1622         Return the saved command line, if any; error out if there's no
1623         command to relaunch.
1624
1625 2019-07-03  Pedro Alves  <palves@redhat.com>
1626
1627         * NEWS (New commands): Mention "maint set/show test-settings"
1628         instead of "maint test-settings".
1629         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1630         (maintenance_test_settings_set_list): Rename to ...
1631         (maintenance_set_test_settings_list): ... this.
1632         (maintenance_test_settings_show_list): Rename to  ...
1633         (maintenance_show_test_settings_list): ... this.
1634         (maintenance_test_settings_cmd): Delete.
1635         (maintenance_test_settings_set_cmd): ...
1636         (maintenance_set_test_settings_cmd): ... this.
1637         (maintenance_test_settings_show_cmd): ...
1638         (maintenance_show_test_settings_cmd): ... this.
1639         (maintenance_test_settings_show_value_cmd):
1640         (maintenance_show_test_settings_value_cmd): ... this.
1641         (_initialize_maint_test_settings): No longer install the "maint
1642         test-settings" prefix command.  Rename "maint test-settings set"
1643         to "maint set test-settings", and "maint test-settings show" to
1644         "maint show test-settings".  Adjust all subcommands.
1645
1646 2019-07-03  Pedro Alves  <palves@redhat.com>
1647
1648         * maint-test-settings.c: Fix file's intro comment.  Replace all
1649         references to "test-options" with references to "test-settings",
1650         in comments.
1651
1652 2019-07-03  Pedro Alves  <palves@redhat.com>
1653
1654         * maint-test-settings.c (maintenance_test_settings_xxx)
1655         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1656         New.
1657         (maintenance_test_settings_enums): Use them.
1658         (maintenance_test_settings_enum): Default to
1659         maintenance_test_settings_xxx.
1660         (_initialize_maint_test_settings): Initialize
1661         MAINTENANCE_TEST_SETTINGS_FILENAME.
1662
1663 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1664
1665         * breakpoint.h (remove_breakpoints_inf): Change return type to
1666         void, move function documentation here.
1667         * breakpoint.c (remove_breakpoints_inf): Change return type to
1668         void, move function documentation to header.
1669
1670 2019-07-02  Pedro Alves  <palves@redhat.com>
1671
1672         * NEWS (Completion improvements): Mention "info threads".
1673         * thread.c (struct info_threads_opts, info_threads_option_defs)
1674         (make_info_threads_options_def_group): New.
1675         (info_threads_command): Use gdb::option::process_options.
1676         (info_threads_command_completer): New.
1677         (_initialize_thread): Use gdb::option::build_help to build the
1678         help text for "info threads".
1679
1680 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1681
1682         * defs.h (generic_load): Move from here...
1683         * symfile.h (generic_load): ... to here.  Rename name parameter
1684         to args.
1685         * symfile.c (generic_load): Add comment.
1686
1687 2019-07-01  Tom Tromey  <tromey@adacore.com>
1688
1689         * dwarf2read.c
1690         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1691         declaration of without_params.  Fix formatting.
1692
1693 2019-07-01  Tom Tromey  <tromey@adacore.com>
1694
1695         * ada-exp.y (find_primitive_type): Update.
1696         * ada-lang.h (ada_lookup_symbol): Update.
1697         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1698         parameter.
1699         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1700
1701 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1702
1703         PR breakpoints/24541
1704         * gdbarch.c: Regenerate.
1705         * gdbarch.h: Regenerate.
1706         * gdbarch.sh: Add 'stap_adjust_register'.
1707         * i386-tdep.c: Include '<unordered_set>'.
1708         (i386_stap_adjust_register): New function.
1709         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1710         * stap-probe.c (stap_parse_register_operand): Call
1711         'gdbarch_stap_adjust_register'.
1712
1713 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1714
1715         PR python/24742
1716         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1717         * python/python.c (do_start_initialization): Use 'xmalloc'
1718         instead of 'PyMem_Malloc'.
1719
1720 2019-06-28  Tom Tromey  <tromey@adacore.com>
1721
1722         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1723         for Ada.
1724
1725 2019-06-27  Tom Tromey  <tromey@adacore.com>
1726
1727         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1728         objfile_key.
1729         (arm_find_mapping_symbol, arm_record_special_symbol)
1730         (_initialize_arm_tdep): Update.
1731         (arm_objfile_data_free): Remove.
1732
1733 2019-06-27  Tom Tromey  <tromey@adacore.com>
1734
1735         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1736         to cp_print_static_field.
1737
1738 2019-06-26  Tom Tromey  <tromey@adacore.com>
1739
1740         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1741         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1742         declare.
1743
1744 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1745
1746         * features/aarch64-core.c (create_feature_aarch64_core):
1747         Regenerate.
1748         * features/aarch64-core.xml: Add cpsr flags.
1749
1750 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1751
1752         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1753         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1754
1755 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1756
1757         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1758         field.
1759         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1760         use.
1761         (arm_record_special_symbol): Don't insert new symbol in sorted
1762         position, push it at the end.
1763
1764 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1765
1766         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1767         (arm_mapping_symbol_s): Remove.
1768         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1769         (arm_mapping_symbol_vec): New typedef.
1770         (struct arm_per_objfile): Add constructor.
1771         <section_maps>: Change type to
1772         std::unique_ptr<arm_mapping_symbol_vec[]>.
1773         (arm_compare_mapping_symbols): Remove.
1774         (arm_find_mapping_symbol): Adjust to section_maps type change.
1775         (arm_objfile_data_free): Call delete on arm_per_objfile.
1776         (arm_record_special_symbol): Adjust to section_maps type change.
1777         Allocate arm_per_objfile with new.
1778
1779 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1780
1781         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1782         with the command prefix.
1783
1784 2019-06-25  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1787         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1788
1789 2019-06-25  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1792         type.
1793         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1794         protected.
1795
1796 2019-06-25  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-winsource.c
1799         (tui_source_window_base::set_is_exec_point_at): Add check against
1800         LOA_ADDRESS.
1801
1802 2019-06-25  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-source.c (tui_set_source_content): Don't check before
1805         xfree.
1806         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-winsource.h (tui_update_source_window_as_is)
1811         (tui_alloc_source_buffer, tui_line_is_displayed)
1812         (tui_addr_is_displayed): Change type of win_info.
1813         * tui/tui-winsource.c (tui_update_source_window_as_is)
1814         (tui_clear_source_content, tui_show_source_line)
1815         (tui_show_source_content, tui_source_window_base::refill)
1816         (tui_source_window_base::set_is_exec_point_at)
1817         (tui_source_window_base::set_is_exec_point_at)
1818         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1819         (tui_alloc_source_buffer, tui_line_is_displayed)
1820         (tui_addr_is_displayed): Change type of win_info.  Update.
1821         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1822         (tui_source_window_base::do_make_visible_with_new_height):
1823         Update.
1824         * tui/tui-source.c (tui_set_source_content)
1825         (tui_set_source_content_nil)
1826         (tui_source_window::do_scroll_vertical): Update.
1827         * tui/tui-layout.c (show_layout): Update.
1828         * tui/tui-disasm.c (tui_set_disassem_content)
1829         (tui_disasm_window::do_scroll_vertical): Update.
1830         * tui/tui-data.h (tui_win_content): Remove.
1831         (struct tui_gen_win_info) <content, content_size>: Remove.
1832         (struct tui_source_element): Add initializers and destructor.
1833         (union tui_which_element, struct tui_win_element): Remove.
1834         (struct tui_source_window_base) <content>: New field.
1835         (struct tui_data_window): Remove destructor.
1836         (tui_alloc_content, tui_free_win_content)
1837         (tui_free_all_source_wins_content): Don't declare.
1838         * tui/tui-data.c (tui_initialize_static_data): Update.
1839         (init_content_element, tui_alloc_content): Remove.
1840         (~tui_gen_win_info): Update.
1841         (~tui_data_window, tui_free_all_source_wins_content)
1842         (tui_free_win_content, free_content, free_content_elements):
1843         Remove.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-winsource.h (tui_clear_source_content)
1848         (tui_erase_source_content, tui_show_source_content): Change type
1849         of win_info.
1850         * tui/tui-winsource.c (tui_clear_source_content)
1851         (tui_erase_source_content, tui_show_source_content): Change type
1852         of win_info.
1853         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1854         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1855         win_info.
1856         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1857         win_info.
1858         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1859
1860 2019-06-25  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-winsource.c (tui_clear_source_content)
1863         (tui_source_window_base::set_is_exec_point_at): Update.
1864         * tui/tui-source.c (tui_set_source_content_nil): Update.
1865         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1866         a bool.
1867         * tui/tui-data.c (init_content_element): Update.
1868
1869 2019-06-25  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1872         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1873         * tui/tui-layout.c (init_and_make_win): Update.
1874         * tui/tui.h (enum tui_win_type): Update.
1875         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1876         tui_win_is_auxillary.
1877         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1878         tui_win_is_auxillary.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1883         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1884         (tui_delete_data_content_windows, tui_display_all_data)
1885         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1886         Update.
1887         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1888         * tui/tui-regs.c (tui_last_regs_line_no)
1889         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1890         (tui_show_registers): Update.
1891         (tui_show_register_group): Return void.  Update.
1892         (tui_display_registers_from, tui_display_reg_element_at_line)
1893         (tui_display_registers_from_line, tui_check_register_values):
1894         Update.
1895         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1896         member.
1897         (struct tui_data_window) <regs_content>: Now a std::vector.
1898         <regs_content_count>: Remove.
1899         (tui_add_content_elements, tui_free_data_content): Don't declare.
1900         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1901         (init_content_element): Remove DATA_WIN case.  Add assert.
1902         (tui_add_content_elements): Remove.
1903         (tui_data_window): Update.
1904         (tui_free_data_content): Remove.
1905         (free_content_elements): Remove DATA_WIN case.
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-data.c (tui_data_item_window): Update.
1910         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1911         * tui/tui-windata.c (tui_display_all_data)
1912         (tui_display_data_from_line): Update.
1913         (tui_check_data_values): Remove.
1914         * tui/tui-regs.c (tui_show_register_group)
1915         (tui_display_reg_element_at_line): Update.
1916         * tui/tui-hooks.c (tui_register_changed)
1917         (tui_refresh_frame_and_register_information): Call
1918         tui_check_register_values.
1919         * tui/tui-data.h (struct tui_data_window) <data_content,
1920         data_content_count, data_type>: Remove.
1921         (enum tui_data_type): Remove.
1922
1923         * tui/tui-data.c (tui_data_window::clear_detail)
1924         (~tui_data_window): Update.
1925
1926 2019-06-25  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1929         declare.
1930         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1931         Rename from tui_first_data_item_displayed.  Update.
1932         (tui_data_window::refresh_all)
1933         (tui_data_window::do_scroll_vertical): Update.
1934         * tui/tui-data.h (struct tui_data_window)
1935         <first_data_item_displayed>: Declare new method.
1936
1937 2019-06-25  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1940         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1941         contents...
1942         (tui_initialize_static_data): ...here.
1943
1944 2019-06-25  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1947         (tui_display_registers_from, tui_check_register_values): Update.
1948         (tui_display_register): Remove win_info parameter; update.
1949         (tui_get_register): Change type of parameters.
1950         * tui/tui-data.h (struct tui_data_element): Remove.
1951         (union tui_which_element) <data>: Remove.
1952         <data_window>: Change type.
1953         (struct tui_data_item_window): New.
1954         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1955         case.  Add assert.
1956         (~tui_data_item_window): New destructor.
1957         (free_content_elements): Remove DATA_ITEM_WIN case.
1958
1959 2019-06-25  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1962         Remove.
1963
1964 2019-06-25  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-data.h (struct tui_command_element): Remove.
1967         (union tui_which_element) <command>: Remove.
1968         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1969         assert.
1970         (free_content_elements): Remove CMD_WIN case.
1971
1972 2019-06-25  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-layout.c (tui_set_layout): Update.
1975         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1976         * tui/tui-data.c (layout_def): Update.
1977
1978 2019-06-25  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1981         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1982         (tui_source_window_base::set_new_height): Update.
1983         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1984         Update.
1985         (tui_set_locator_fullname, tui_set_locator_info)
1986         (tui_show_frame_info): Update.
1987         * tui/tui-source.c (tui_set_source_content)
1988         (tui_source_is_displayed): Update.
1989         * tui/tui-layout.c (show_source_disasm_command, show_data)
1990         (show_source_or_disasm_and_command): Update.
1991         * tui/tui-disasm.c (tui_set_disassem_content)
1992         (tui_get_begin_asm_address): Update.
1993         * tui/tui-data.h (struct tui_locator_element): Remove.
1994         (union tui_which_element) <locator>: Remove.
1995         (struct tui_locator_window): New.
1996         (tui_locator_win_info_ptr): Change return type.
1997         * tui/tui-data.c (_locator): Change type.
1998         (tui_locator_win_info_ptr): Change return type.
1999         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2000         (tui_alloc_content): Add assert.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-winsource.c
2005         (tui_exec_info_window::maybe_allocate_content): New method.
2006         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2007         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2008         (make_source_or_disasm_window): Add cast.
2009         * tui/tui-data.h (union tui_which_element) <simple_string>:
2010         Remove.
2011         (struct tui_source_info): New.
2012         (struct tui_source_window_base) <execution_info>: Change type.
2013         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2014         case, and add assert.
2015         (tui_alloc_content): Add assert.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2020         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2021         * tui/tui-data.c (tui_alloc_win_info): Remove.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2026         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2027         can_highlight.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2032         make_visible_with_new_height method.
2033         (tui_win_info::make_visible_with_new_height): New method.
2034         (tui_source_window_base::do_make_visible_with_new_height)
2035         (tui_data_window::do_make_visible_with_new_height)
2036         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2037         (make_visible_with_new_height): Remove.
2038         (tui_resize_all, tui_adjust_win_heights): Use
2039         make_visible_with_new_height method.
2040         * tui/tui-data.h (struct tui_win_info)
2041         <do_make_visible_with_new_height, make_visible_with_new_height>:
2042         New methods.
2043         (struct tui_source_window_base, struct tui_data_window)
2044         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2045         methods.
2046
2047 2019-06-25  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2050         method.
2051         (update_tab_width): Call update_tab_width method.
2052         * tui/tui-data.h (struct tui_win_info)
2053         (struct tui_source_window_base) <update_tab_width>: New methods.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2058         parameter.
2059         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2060         parameter.
2061         (tui_gen_win_info::make_visible): Update.
2062         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2063         parameter.
2064         * tui/tui-data.h (enum tui_box): New enum.
2065         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2070         init_and_make_win for EXEC_INFO_WIN.
2071         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2072         longer inline.
2073         (struct tui_win_info) <~tui_win_info>: Inline.
2074         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2075         Don't declare.
2076         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2077         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2078         Remove.
2079         (tui_initialize_static_data): Update.
2080         (~tui_gen_win_info): Handle more cleanup here.
2081         (~tui_source_window_base): Delete "execution_info".
2082         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2083
2084 2019-06-25  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-layout.c (make_command_window): Don't set
2087         can_highlight.
2088         (show_source_disasm_command): Call the reset method.
2089         (show_data): Don't set can_highlight.  Call the reset method.
2090         (tui_gen_win_info::reset): Rename from init_gen_win_info
2091         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2092         (show_source_or_disasm_and_command): Call the reset method.
2093         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2094         (struct tui_cmd_window): Set can_highlight.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2099         from make_visible.
2100         (tui_make_visible, tui_make_invisible): Rewrite.
2101         (tui_win_info::make_visible): Remove.
2102         (tui_source_window_base::make_visible): Update.
2103         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2104         method.  Moved from...
2105         (struct tui_win_info) <make_visible>: ...here.
2106
2107 2019-06-25  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-winsource.c
2110         (tui_source_window_base::do_scroll_horizontal): Remove direction
2111         parameter.
2112         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2113         direction parameter.
2114         * tui/tui-win.c (tui_win_info::forward_scroll)
2115         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2116         (tui_win_info::right_scroll): Update.
2117         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2118         direction parameter.
2119         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2120         direction parameter.
2121         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2122         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2123         Remove direction parameter.
2124         (struct tui_source_window_base, struct tui_source_window)
2125         (struct tui_disasm_window, struct tui_data_window)
2126         (struct tui_cmd_window): Update.
2127
2128 2019-06-25  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-winsource.h (tui_set_exec_info_content)
2131         (tui_show_exec_info_content, tui_erase_exec_info_content)
2132         (tui_clear_exec_info_content, tui_update_exec_info): Change
2133         argument to tui_source_window_base.
2134         * tui/tui-winsource.c (tui_set_exec_info_content)
2135         (tui_show_exec_info_content, tui_erase_exec_info_content)
2136         (tui_clear_exec_info_content, tui_update_exec_info): Change
2137         argument to tui_source_window_base.
2138
2139 2019-06-25  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2142         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2147         check.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2152         type to void.
2153         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2154         type to void.
2155         * tui/tui-source.c (tui_set_source_content): Update.
2156         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2157
2158 2019-06-25  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-win.c (window_name_completer, tui_set_focus)
2161         (tui_all_windows_info): Use name method.
2162         * tui/tui-data.h (struct tui_gen_win_info)
2163         (struct tui_source_window, struct tui_disasm_window)
2164         (struct tui_data_window, struct tui_cmd_window) <name>: New
2165         method.
2166         (tui_win_name): Don't declare.
2167         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2168         (tui_win_name): Remove.
2169
2170 2019-06-25  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-winsource.h (tui_update_source_window)
2173         (tui_update_source_window_as_is): Change parameter type.
2174         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2175         to be a tui_source_window_base.
2176         (tui_update_source_window_as_is): Likewise.
2177         * tui/tui-win.c (make_visible_with_new_height): Update.
2178
2179 2019-06-25  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-winsource.c (tui_erase_source_content)
2182         (tui_show_source_content, tui_show_exec_info_content)
2183         (tui_erase_exec_info_content): Use refresh_window method.
2184         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2185         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2186         from tui_refresh_win.
2187         (tui_data_window::refresh_window): New method.
2188         (tui_win_info::refresh, tui_source_window_base::refresh)
2189         (tui_refresh_all): Use refresh_window method.
2190         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2191         method.
2192         * tui/tui-regs.c (tui_display_register): Call refresh_window
2193         method.
2194         * tui/tui-layout.c (show_source_disasm_command)
2195         (show_source_or_disasm_and_command): Call refresh_window method.
2196         * tui/tui-data.h (struct tui_gen_win_info)
2197         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2198         New method.
2199
2200 2019-06-25  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui.c (tui_rl_other_window, tui_enable)
2203         (tui_is_window_visible, tui_get_command_dimension): Update.
2204         * tui/tui-winsource.c (tui_update_source_window_as_is)
2205         (tui_clear_source_content, tui_erase_source_content)
2206         (tui_show_source_line, tui_source_window_base::refill)
2207         (tui_source_window_base::do_scroll_horizontal)
2208         (tui_source_window_base::set_is_exec_point_at)
2209         (tui_update_breakpoint_info, tui_set_exec_info_content)
2210         (tui_alloc_source_buffer, tui_line_is_displayed)
2211         (tui_addr_is_displayed): Update.
2212         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2213         (tui_check_and_display_highlight_if_needed)
2214         (tui_win_info::make_visible, tui_win_info::refresh)
2215         (tui_refresh_all): Update.
2216         * tui/tui-windata.c (tui_first_data_item_displayed)
2217         (tui_delete_data_content_windows, tui_erase_data_content)
2218         (tui_display_all_data, tui_data_window::refresh_all)
2219         (tui_check_data_values): Update.
2220         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2221         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2222         (tui_win_info::backward_scroll, tui_refresh_all_win)
2223         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2224         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2225         (tui_source_window_base::set_new_height)
2226         (tui_data_window::set_new_height)
2227         (make_invisible_and_set_new_height)
2228         (make_visible_with_new_height, new_height_ok)
2229         (parse_scrolling_args): Update.
2230         * tui/tui-stack.c (tui_show_frame_info): Update.
2231         * tui/tui-source.c (tui_set_source_content)
2232         (tui_set_source_content_nil, tui_source_is_displayed)
2233         (tui_source_window::do_scroll_vertical): Update.
2234         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2235         (tui_display_registers_from, tui_display_reg_element_at_line)
2236         (tui_check_register_values, tui_reg_command): Update.
2237         * tui/tui-layout.c (tui_default_win_height)
2238         (show_source_disasm_command, show_data, init_and_make_win)
2239         (show_source_or_disasm_and_command): Update.
2240         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2241         (tui_redisplay_readline, tui_mld_flush)
2242         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2243         (tui_getc): Update.
2244         * tui/tui-disasm.c (tui_set_disassem_content)
2245         (tui_disasm_window::do_scroll_vertical): Update.
2246         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2247         Now virtual.
2248         (struct tui_win_info): Derive from tui_gen_win_info.
2249         <~tui_win_info>: Mark as override.
2250         <generic>: Remove member.
2251         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2252         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2253         (~tui_data_window, ~tui_win_info)
2254         (tui_free_all_source_wins_content): Update.
2255         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2256
2257 2019-06-25  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-layout.c (init_and_make_win): Use new.
2260         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2261         destructor, initializers.
2262         (tui_alloc_generic_win_info): Don't declare.
2263         * tui/tui-data.c (_locator): Add argument to constructor.
2264         (source_win, disasm_win): New globals.
2265         (exec_info): Remove.
2266         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2267         Update.
2268         (tui_alloc_generic_win_info): Remove.
2269         (init_content_element): Use new.
2270         (tui_win_info::tui_win_info): Update.
2271         (free_content_elements) <case DATA_WIN>: Use delete.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2276         * tui/tui-windata.c (tui_first_data_item_displayed)
2277         (tui_delete_data_content_windows): Update.
2278         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2279         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2280         (tui_display_registers_from, tui_check_register_values): Update.
2281         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2282         pointer.
2283         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2284         window.
2285         (tui_free_data_content): Update.
2286         (free_content_elements) <case DATA_WIN>: Free the window.
2287
2288 2019-06-25  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2291         Update.
2292         * tui/tui-layout.c (make_command_window)
2293         (show_source_disasm_command, show_data, init_and_make_win)
2294         (show_source_or_disasm_and_command): Update.
2295         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2296         method.
2297         <can_highight, is_highlighted>: Now bool.
2298         (tui_set_win_highlight): Don't declare.
2299         * tui/tui-data.c (tui_set_win_highlight): Remove.
2300
2301 2019-06-25  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-wingeneral.c (make_visible): Remove check of window
2304         type.
2305
2306 2019-06-25  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-win.c (tui_win_info::max_height)
2309         (tui_cmd_window::max_height): New methods.
2310         (new_height_ok): Call max_height.
2311         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2312         <max_height>: New method.
2313
2314 2019-06-25  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-win.c (tui_source_window_base::set_new_height)
2317         (tui_data_window::set_new_height): New methods.
2318         (make_invisible_and_set_new_height): Call set_new_height method.
2319         * tui/tui-data.h (struct tui_win_info)
2320         (struct tui_source_window_base, struct tui_data_window)
2321         <set_new_height>: New method.
2322
2323 2019-06-25  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2326         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2327         tui_refresh_data_win.
2328         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2329         method.
2330         (tui_refresh_all_win): Call the refresh_all method.
2331         (tui_set_focus): Likewise.
2332         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2333         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2334         Likewise.
2335
2336 2019-06-25  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-winsource.h (tui_refill_source_window)
2339         (tui_set_is_exec_point_at): Don't declare.
2340         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2341         (tui_source_window_base::refill): Rename from
2342         tui_refill_source_window.
2343         (tui_source_window_base::do_scroll_horizontal): Update.
2344         (tui_source_window_base::set_is_exec_point_at): Rename from
2345         tui_set_is_exec_point_at.
2346         (tui_update_all_breakpoint_info): Update.
2347         * tui/tui-stack.c (tui_show_frame_info): Update.
2348         * tui/tui-layout.c (show_data): Add cast.
2349         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2350         * tui/tui-data.h (struct tui_source_window_base) <refill,
2351         set_is_exec_point_at>: New methods.
2352         (tui_source_windows, tui_add_to_source_windows): Update types.
2353         (tui_add_to_source_windows): Remove redundant declaration.
2354         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2355         (tui_source_windows): Change return type.
2356         (tui_clear_source_windows_detail): Update.
2357         (tui_add_to_source_windows): Change type of parameter.
2358         (tui_free_all_source_wins_content): Update.
2359
2360 2019-06-25  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-wingeneral.c (tui_win_info::refresh)
2363         (tui_source_window_base::refresh): New methods.
2364         (tui_refresh_all): Call the refresh method.
2365         * tui/tui-data.h (struct tui_win_info)
2366         (struct tui_source_window_base) <refresh>: New method.
2367
2368 2019-06-25  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui.h (tui_is_window_visible): Return bool.
2371         * tui/tui.c (tui_is_window_visible): Return bool.
2372         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2373         (tui_make_visible, tui_make_invisible)
2374         (tui_win_info::make_visible)
2375         (tui_source_window_base::make_visible, make_all_visible)
2376         (tui_make_all_visible, tui_make_all_invisible): Update.
2377         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2378         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2379         bool.
2380         (struct tui_win_info, struct tui_source_window_base)
2381         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2382         * tui/tui-data.c (tui_init_generic_part): Update.
2383
2384 2019-06-25  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2387         (tui_source_window_base::make_visible): New methods.
2388         (make_all_visible): Make method call.
2389         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2390         (struct tui_source_window_base, struct tui_cmd_window): Override
2391         make_visible.
2392         (tui_win_is_source_type): Don't declare.
2393         * tui/tui-data.c (tui_win_is_source_type): Remove.
2394
2395 2019-06-25  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2398         NULL check.
2399
2400 2019-06-25  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2403         Inline constructor.  Add initializers for members.
2404         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2405         constructors; now inline in class.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-regs.c (tui_show_registers): Update.
2410         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2411         bool.
2412         * tui/tui-data.c (tui_data_window::clear_detail)
2413         (tui_data_window): Update.
2414
2415 2019-06-25  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-windata.c (tui_display_all_data)
2418         (tui_display_data_from_line, tui_display_data_from)
2419         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2420         Update.
2421         * tui/tui-regs.c (tui_last_regs_line_no)
2422         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2423         (tui_show_registers, tui_show_register_group)
2424         (tui_display_registers_from, tui_display_reg_element_at_line)
2425         (tui_display_registers_from_line, tui_check_register_values)
2426         (tui_reg_next, tui_reg_prev): Update.
2427         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2428         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2429         tui_data_window.
2430         (struct tui_win_info) <detail>: Remove.  Add new fields from
2431         tui_data_info.
2432         (TUI_DATA_WIN): Add cast.
2433         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2434         (~tui_data_window): Simplify.
2435
2436 2019-06-25  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-layout.c (show_source_disasm_command)
2439         (show_source_or_disasm_and_command): Update.
2440         * tui/tui-io.c (update_cmdwin_start_line)
2441         (tui_redisplay_readline): Update.
2442         * tui/tui-data.h (struct tui_command_info): Remove.
2443         (struct tui_win_info) <detail>: Remove command_info member.
2444         (struct tui_data_window) <start_line>: New member, from
2445         tui_command_info.
2446         (TUI_CMD_WIN): Add casts.
2447
2448 2019-06-25  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-winsource.c (tui_update_source_window)
2451         (tui_refill_source_window)
2452         (tui_source_window_base::do_scroll_horizontal)
2453         (tui_update_breakpoint_info, tui_set_exec_info_content)
2454         (tui_show_exec_info_content, tui_erase_exec_info_content)
2455         (tui_clear_exec_info_content): Update.
2456         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2457         Update.
2458         * tui/tui-win.c (make_invisible_and_set_new_height)
2459         (make_visible_with_new_height): Update.
2460         * tui/tui-source.c (tui_set_source_content)
2461         (tui_show_symtab_source): Update.
2462         * tui/tui-layout.c (extract_display_start_addr)
2463         (show_source_disasm_command, show_data)
2464         (make_source_or_disasm_window)
2465         (show_source_or_disasm_and_command): Update.
2466         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2467         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2468         "gdbarch".
2469         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2470         to tui_source_window_base.
2471         (struct tui_win_info) <detail>: Remove source_info member.
2472         (struct tui_source_window_base) <has_locator>: Inline.
2473         Move contents from tui_source_info; rename has_locator member to
2474         m_has_locator.
2475         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2476         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2477         header file.
2478         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2479         Simplify.
2480         (tui_free_all_source_wins_content): Cast to
2481         tui_source_window_base.
2482
2483 2019-06-25  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-win.c (make_invisible_and_set_new_height)
2486         (make_visible_with_new_height): Call has_locator method.
2487         * tui/tui-layout.c (show_source_disasm_command, show_data)
2488         (show_source_or_disasm_and_command): Update for bool change.
2489         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2490         (tui_win_info) <has_locator>: New method.
2491         (struct tui_source_window_base) <has_locator>: New method.
2492         (tui_win_has_locator): Don't declare.
2493         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2494         from tui_win_has_locator.
2495         (tui_source_window_base): Use false, not FALSE.
2496
2497 2019-06-25  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2500         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2501         clear_detail method directly.
2502         (tui_clear_win_detail): Remove.
2503
2504 2019-06-25  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2507         "this", not TUI_DISASM_WIN.
2508
2509 2019-06-25  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2512         declare.
2513         * tui/tui-winsource.c
2514         (tui_source_window_base::do_scroll_horizontal): Rename from
2515         tui_horizontal_source_scroll.
2516         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2517         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2518         from tui_vertical_data_scroll.
2519         * tui/tui-win.h (tui_scroll): Don't declare.
2520         * tui/tui-win.c (tui_win_info::forward_scroll)
2521         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2522         (tui_win_info::right_scroll): Rename and update.
2523         (tui_scroll_forward_command, tui_scroll_backward_command)
2524         (tui_scroll_left_command, tui_scroll_right_command): Update.
2525         (tui_scroll): Remove.
2526         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2527         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2528         from tui_vertical_source_scroll.
2529         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2530         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2531         from tui_vertical_disassem_scroll.
2532         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2533         do_scroll_horizontal>: New methods.
2534         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2535         Likewise.
2536         (struct tui_source_window_base): Add do_scroll_horizontal.
2537         (struct tui_source_window, struct tui_disasm_window): Add
2538         do_scroll_vertical.
2539         (struct tui_data_window, struct tui_cmd_window): Add
2540         do_scroll_horizontal and do_scroll_vertical.
2541         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2542
2543 2019-06-25  Tom Tromey  <tom@tromey.com>
2544
2545         * tui/tui-data.h (struct tui_source_window_base): New struct.
2546         (struct tui_source_window): Derive from tui_source_window_base.
2547         (struct tui_disasm_window): New struct.
2548         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2549         from tui_source_window::clear_detail.
2550         (tui_source_window_base): Rename from tui_source_window.
2551         (~tui_source_window_base): Rename from ~tui_source_window.
2552         (tui_alloc_win_info): Create a tui_disasm_window.
2553
2554 2019-06-25  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-data.h (struct tui_source_window)
2557         (struct tui_data_window): Declare destructors.
2558         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2559         destructors.
2560         (tui_win_info): Simplify.
2561
2562 2019-06-25  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-winsource.c (tui_display_main)
2565         (tui_update_source_windows_with_addr)
2566         (tui_update_all_breakpoint_info): Update.
2567         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2568         (new_height_ok, parse_scrolling_args): Update.
2569         * tui/tui-stack.c (tui_show_frame_info): Update.
2570         * tui/tui-data.h (struct tui_list): Remove.
2571         (tui_source_windows): Return a reference to a std::vector.
2572         * tui/tui-data.c (source_windows): Now a std::vector.
2573         (tui_source_windows): Change return type.
2574         (tui_clear_source_windows): Rewrite.
2575         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2576         (tui_free_all_source_wins_content): Rewrite.
2577
2578 2019-06-25  Tom Tromey  <tom@tromey.com>
2579
2580         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2581         (struct tui_data_window, struct tui_cmd_window): Declare
2582         clear_detail method.
2583         * tui/tui-data.c (tui_source_window::clear_detail)
2584         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2585         methods.
2586         (tui_clear_win_detail): Simplify.
2587
2588 2019-06-25  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-layout.c (make_source_window, make_disasm_window)
2591         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2592         Return the new window.
2593         (show_source_disasm_command, show_data)
2594         (show_source_or_disasm_and_command): Update.
2595
2596 2019-06-25  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2599         parameter.  Return the new window.
2600         (show_source_disasm_command): Update and remove NULL check.
2601         (show_source_or_disasm_and_command): Update.
2602
2603 2019-06-25  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2606
2607 2019-06-25  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-data.h (struct tui_win_info): Make constructor
2610         protected.  Make destructor virtual.  Add initializers.
2611         (tui_source_window, tui_data_window, tui_cmd_window): New
2612         classes.
2613         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2614         constructor.  Add "type" parameter.
2615         (tui_source_window, tui_data_window, tui_cmd_window): New
2616         constructors.
2617         (tui_alloc_win_info): Instantiate the appropriate subclass.
2618
2619 2019-06-25  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-win.c (tui_resize_all): Use delete.
2622         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2623         destructor.
2624         (tui_free_window): Don't declare.
2625         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2626         Update.
2627
2628 2019-06-25  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-data.h (struct tui_win_info): Add constructor.
2631         * tui/tui-data.c (tui_alloc_win_info): Use new.
2632         (tui_free_window): Use delete.
2633
2634 2019-06-22  Tom Tromey  <tom@tromey.com>
2635
2636         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2637         declare.
2638         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2639
2640 2019-06-22  Tom Tromey  <tom@tromey.com>
2641
2642         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2643         declare.
2644         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2645
2646 2019-06-22  Tom de Vries  <tdevries@suse.de>
2647
2648         * dwarf2read.c (create_addrmap_from_aranges)
2649         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2650         instead of '%zu'.
2651
2652 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2653
2654         * dwarf2read.h (dwarf2_section_info_def): Remove.
2655         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2656         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2657         std::vector<dwarf2_section_info>.
2658         (struct dwo_file) <~dwo_file>: Remove.
2659         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2660         types field.
2661         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2662         (dwarf2_read_debug_names): Likewise.
2663         (create_debug_types_hash_table): Change parameter type to
2664         array_view, adjust code accordingly.
2665         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2666         (partial_die_info::fixup): Likewise.
2667         (determine_prefix): Likewise.
2668         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2669
2670 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2671
2672         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2673         gdb_bfd_ref_ptr.
2674         <~dwo_file>: Remove call to gdb_bfd_unref.
2675         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2676         gdb_bfd_ref_ptr::get.
2677
2678 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2679
2680         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2681         type to htab_up.
2682         * dwarf2read.c (struct dwo_file): Initialize fields.
2683         <~dwo_file>: New.
2684         (free_dwo_file): Remove, move content to ~dwo_file.
2685         (struct dwo_file_deleter): Remove.
2686         (dwo_file_up>: Remove custom deleter.
2687         (free_dwo_files): Remove.
2688         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2689         dwo_files.
2690         (process_skeletonless_type_units): Call unique_ptr::get.
2691         (allocate_dwo_file_hash_table): Add deleter to created hash
2692         table.  Change return type to htab_up.
2693         (lookup_dwo_file_slot): Don't memset dwo_file, call
2694         unique_ptr::get.
2695         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2696         (create_dwo_unit_in_dwp_v2): Likewise.
2697         (open_and_init_dwo_file): Likewise.
2698         (free_dwo_file_from_slot): Remove.
2699
2700 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2701
2702         * dwarf2read.h (struct dwarf2_section_info) <readin,
2703         is_virtual>: Change type to bool.
2704         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2705         true instead of 1.
2706
2707 2019-06-19  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-data.h (tui_init_content_element): Don't declare.
2710
2711 2019-06-19  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-data.h (tui_init_win_info): Don't declare.
2714
2715 2019-06-19  Tom de Vries  <tdevries@suse.de>
2716
2717         * dwarf2read.h (abstract_to_concrete): Change type to
2718         std::unordered_map<sect_offset, std::vector<sect_offset>,
2719         gdb::hash_enum<sect_offset>>.
2720
2721 2019-06-19  Tom Tromey  <tromey@adacore.com>
2722
2723         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2724         EVAL_AVOID_SIDE_EFFECTS specially.
2725
2726 2019-06-19  Tom Tromey  <tromey@adacore.com>
2727
2728         * source-cache.c (highlighter): New global.
2729         (source_cache::get_source_lines): Create a highlighter on demand.
2730
2731 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * defs.h (deprecated_interactive_hook): Delete declaration.
2734         * interps.c (clear_interpreter_hooks): Remove use of
2735         deprecated_interactive_hook.
2736         * top.c (deprecated_interactive_hook): Delete definition.
2737         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2738
2739 2019-06-18  Tom de Vries  <tdevries@suse.de>
2740
2741         PR gdb/24515
2742         * dwarf2read.h (abstract_to_concrete): Change type from
2743         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2744         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2745         * dwarf2read.c (read_variable): Update.
2746         (dwarf2_fetch_die_loc_sect_off): Update.
2747
2748 2019-06-17  Tom de Vries  <tdevries@suse.de>
2749
2750         PR gdb/24617
2751         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2752         accessing parent[parent_len - 1].
2753
2754 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2755
2756         PR gdb/24364
2757         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2758         call dtrace_process_dof with NULL dof.
2759
2760 2019-06-16  Tom de Vries  <tdevries@suse.de>
2761
2762         PR gdb/24445
2763         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2764
2765 2019-06-16  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2768         (make_all_visible): Use address of member.
2769
2770 2019-06-16  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2773         (tui_free_window, free_content, free_content_elements): Remove
2774         unnecessary cast.
2775         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2776         cast.
2777         * tui/tui-regs.c (tui_show_register_group)
2778         (tui_display_registers_from, tui_display_reg_element_at_line):
2779         Remove unnecessary cast.
2780
2781 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * linux-nat.c (normal_mask): Delete.
2784         (_initialize_linux_nat): Don't initialise normal_mask.
2785
2786 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2787
2788         PR gdb/24445
2789         * dwarf-index-write.h (write_psymtabs_to_index): Add
2790         dwz_basename parameter.
2791         * dwarf-index-write.c (write_gdbindex): Move file writing to
2792         write_gdbindex_1.  Change return type void.
2793         (assert_file_size): Move up, remove filename parameter.
2794         (write_gdbindex_1): New function.
2795         (write_debug_names): Change return type to void, call
2796         assert_file_size.
2797         (struct index_wip_file): New struct.
2798         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2799         file logic to index_wip_file.  Write index for dwz file if
2800         needed.
2801         (save_gdb_index_command): Pass basename of dwz file, if present.
2802         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2803         build-id of dwz file, if present.
2804         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2805         (dwarf2_get_dwz_file): Likewise.
2806         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2807         (dwarf2_get_dwz_file): Likewise.
2808
2809 2019-06-16  Tom Tromey  <tom@tromey.com>
2810
2811         * coffread.c (process_coff_symbol): Use xstrdup.
2812         * value.c (create_internalvar): Use xstrdup.
2813
2814 2019-06-16  Tom Tromey  <tom@tromey.com>
2815
2816         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2817         * breakpoint.c (stopin_command, stopat_command)
2818         (until_break_command, decode_location_default): Remove unnecessary
2819         cast.
2820         * utils.c (subset_compare): Remove unnecessary cast.
2821         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2822         cast.
2823         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2824         cast.
2825         * infcmd.c (path_command): Remove unnecessary cast.
2826         * coffread.c (decode_type): Remove unnecessary cast.
2827         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2828         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2829         * tui/tui-stack.c (tui_show_locator_content)
2830         (tui_show_frame_info): Remove unnecessary cast.
2831         * tui/tui-win.c (tui_scroll_forward_command)
2832         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2833         (parse_scrolling_args): Remove unnecessary cast.
2834         * tui/tui-data.c (init_win_info, tui_del_window)
2835         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2836         (free_content_elements): Remove unnecessary cast.
2837         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2838         unnecessary cast.
2839         * tui/tui-source.c (tui_set_source_content)
2840         (tui_vertical_source_scroll): Remove unnecessary cast.
2841         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2842         cast.
2843         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2844         * tui/tui-regs.c (tui_display_registers_from)
2845         (tui_display_register): Remove unnecessary cast.
2846         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2847         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2848         (make_visible): Remove unnecessary cast.
2849         * tui/tui-winsource.c (tui_erase_source_content)
2850         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2851         unnecessary cast.
2852         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2853         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2854         * stabsread.c (read_type, read_array_type, read_range_type):
2855         Remove unnecessary cast.
2856         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2857         (parse_symbol, parse_type, upgrade_type, parse_external)
2858         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2859         unnecessary cast.
2860         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2861
2862 2019-06-16  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui-data.c (tui_alloc_generic_win_info)
2865         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2866         checks.
2867
2868 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2869             Andrew Burgess  <andrew.burgess@embecosm.com>
2870
2871         * f-typeprint.c (f_print_type): Don't return early for not
2872         associated or not allocated types.
2873         (f_type_print_varspec_suffix): Add print_rank parameter and print
2874         ranks of array types in case they dangling.
2875         (f_type_print_base): Add print_rank parameter.
2876
2877 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2878
2879         * NEWS: Mention new MI commands.
2880         * break-catch-throw.c (enum exception_event_kind): Move to
2881         breakpoint.h.
2882         (print_mention_exception_catchpoint): Output text as a single
2883         message.
2884         (catch_exception_command_1): Rename to...
2885         (catch_exception_event): ...this, make non-static, update header
2886         command, and change some parameter types.
2887         (catch_catch_command): Update for changes to
2888         catch_exception_command_1.
2889         (catch_throw_command): Likewise.
2890         (catch_rethrow_command): Likewise.
2891         * breakpoint.c (enum exception_event_kind): Delete.
2892         * breakpoint.h (enum exception_event_kind): Moved here from
2893         break-catch-throw.c.
2894         (catch_exception_event): Declare.
2895         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2896         (mi_cmd_catch_throw): New function.
2897         (mi_cmd_catch_rethrow): New function.
2898         (mi_cmd_catch_catch): New function.
2899         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2900         'catch-catch' entries.
2901         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2902         (mi_cmd_catch_rethrow): Declare.
2903         (mi_cmd_catch_catch): Declare.
2904
2905 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2906
2907         * annotate.c (annotate_source_line): Change return type to void,
2908         update implementation to match.
2909         * annotate.h (annotate_source_line): Change return type to void,
2910         update header comment.
2911         * stack.c (print_frame_info): Don't change what frame information
2912         is printed based on whether annotations are on or not.
2913
2914 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2915
2916         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2917         (annotate_source): Make static.
2918         (annotate_source_line): Moved from source.c and renamed from
2919         identify_source_line.  Update the return type.
2920         * annotate.h (annotate_source): Delete declaration.
2921         (annotate_source_line): Declaration moved from source.h, and
2922         renamed from identify_source_line.  Return type updated.
2923         * source.c (identify_source_line): Moved to annotate.c and renamed
2924         to annotate_source_line.
2925         (info_line_command): Remove check of annotation_level.
2926         * source.h (identify_source_line): Move declaration to annotate.h
2927         and rename to annotate_source_line.
2928         * stack.c: Add 'annotate.h' include.
2929         (print_frame_info): Remove check of annotation_level before
2930         calling annotate_source_line.
2931
2932 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2933
2934         * source-cache.c (source_cache::get_plain_source_lines): Use
2935         open_source_file_with_line_charpos instead of just
2936         open_source_file, remove call to find_source_lines.
2937         (source_cache::get_source_lines): Likewise.
2938         * source.c (find_source_lines): Make static.
2939         (get_filename_and_charpos): Renamed into...
2940         (open_source_file_with_line_charpos): ..this along with changes to
2941         return a scoped_fd, and some other minor clean ups.
2942         (identify_source_line): Use open_source_file_with_line_charpos.
2943         (search_command_helper): Use open_source_file_with_line_charpos
2944         instead of just open_source_file, remove call to
2945         find_source_lines.
2946         * source.h (open_source_file_with_line_charpos): Declare new
2947         function.
2948         (find_source_lines): Delete declaration.
2949
2950 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * source.c (get_filename_and_charpos): Remove fullname
2953         parameter.
2954         (identify_source_line): Update call to get_filename_and_charpos.
2955
2956 2019-06-14  Tom Tromey  <tromey@adacore.com>
2957
2958         PR gdb/24502:
2959         * ui-style.h (skip_ansi_escape): Update comment.
2960         * ui-file.h (class no_terminal_escape_file): New class.
2961         * ui-file.c (no_terminal_escape_file::write)
2962         (no_terminal_escape_file::puts): New methods.
2963         * cli/cli-logging.c (handle_redirections): Use
2964         no_terminal_escape_file.
2965
2966 2019-06-14  Tom Tromey  <tromey@adacore.com>
2967
2968         * NEWS: Move convenience variable news above Python news.
2969
2970 2019-06-14  Tom Tromey  <tom@tromey.com>
2971
2972         * gnulib: Move directory to top-level.
2973         * configure.ac: Don't configure gnulib.
2974         * configure: Rebuild.
2975         * common/common-defs.h: Use new path to gnulib.
2976         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2977         (GNULIB_H): Remove.
2978         (INCGNU): Look in new gnulib location.
2979         (HFILES_NO_SRCDIR): Remove gnulib files.
2980         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2981         (generated_files): Remove GNULIB_H.
2982         ($(LIBGNU), all-lib): Remove targets.
2983         (distclean): Don't mention GNULIB_BUILDDIR.
2984         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2985
2986 2019-06-14  Tom Tromey  <tromey@adacore.com>
2987
2988         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2989         Warn if symbol file does not provide any symbols.
2990
2991 2019-06-14  Tom Tromey  <tromey@adacore.com>
2992
2993         * source.c (find_and_open_source): Respect basenames_may_differ.
2994
2995 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * annotate.c (annotate_breakpoints_invalid): Make use of
2998         scoped_restore_terminal_state.
2999         (annotate_frames_invalid): Likewise.
3000
3001 2019-06-14  Tom Tromey  <tromey@adacore.com>
3002
3003         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3004         allow assignment to an internalvar.
3005
3006 2019-06-14  Tom Tromey  <tromey@adacore.com>
3007
3008         * ada-lex.l: Allow "_" in attribute names.
3009
3010 2019-06-14  Tom Tromey  <tromey@adacore.com>
3011
3012         PR gdb/24653:
3013         * regcache.c (registers_changed): Don't call alloca.
3014         * top.c (execute_command): Don't call alloca.
3015
3016 2019-06-13  Pedro Alves  <palves@redhat.com>
3017
3018         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3019         'expression'.  When parsing an expression, error out if there's
3020         junk after "unlimited".
3021         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3022         (do_set_command): Adjust calls to is_unlimited_literal.
3023
3024 2019-06-13  Pedro Alves  <palves@redhat.com>
3025
3026         * compile/compile.c (make_compile_options_def_group): Add braces
3027         around array_view initializer.
3028         * thread.c (make_thread_apply_all_options_def_group)
3029         (make_thread_apply_all_options_def_group): Likewise.
3030
3031 2019-06-13  Pedro Alves  <palves@redhat.com>
3032
3033         * NEWS (New commands): Mention "maint test-options
3034         require-delimiter", "maint test-options unknown-is-error", "maint
3035         test-options unknown-is-operand" and "maint show
3036         test-options-completion-result".
3037         (New command options, command completion): New section.
3038         (Completion improvements): New section.
3039         Mention that you can abbreviate "unlimited".
3040
3041 2019-06-13  Pedro Alves  <palves@redhat.com>
3042
3043         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3044         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3045         * unittests/cli-utils-selftests.c (test_parse_flags)
3046         (test_parse_flags_qcs): Delete.
3047         (test_cli_utils): Don't call deleted functions.
3048
3049 2019-06-13  Pedro Alves  <palves@redhat.com>
3050
3051         * thread.c: Include "cli/cli-option.h".
3052         (tp_array_compar_ascending): Global.
3053         (tp_array_compar): Delete function.
3054         (tp_array_compar_ascending, tp_array_compar_descending): New
3055         functions.
3056         (ascending_option_def, qcs_flag_option_def)
3057         (thr_qcs_flags_option_defs)
3058         (make_thread_apply_all_options_def_group)
3059         (make_thread_apply_options_def_group): New.
3060         (thread_apply_all_command): Use gdb::option::process_options.
3061         (thread_apply_command_completer)
3062         (thread_apply_all_command_completer): New.
3063         (thread_apply_command): Use gdb::option::process_options.
3064         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3065         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3066         to generate help text of "thread apply".  Adjust "taas"'s help.
3067         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3068         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3069
3070 2019-06-13  Pedro Alves  <palves@redhat.com>
3071
3072         * thread.c (thread_apply_command): Check for invalid TID with
3073         isdigit instead of !isalpha.
3074
3075 2019-06-13  Pedro Alves  <palves@redhat.com>
3076
3077         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3078         (validate_flags_qcs): New.
3079         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3080         (validate_flags_qcs): Declare.
3081         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3082         (make_frame_apply_options_def_group): New.
3083         (frame_apply_command_count): Process options with
3084         gdb::option::process_options.
3085         (frame_apply_completer): New.
3086         (frame_apply_level_completer, frame_apply_all_completer)
3087         (frame_apply_completer): New.
3088         (_initialize_stack): Update help of "frame apply", "frame apply
3089         level", "frame apply all" and "faas" to mention supported options
3090         and install command completers.
3091         * stack.h (frame_apply_all_completer): Declare.
3092         * thread.c: Include "stack.h".
3093         (tfaas_command): Add "--".
3094         (_initialize_thread): Update help "tfaas" to mention supported
3095         options and install command completer.
3096
3097 2019-06-13  Pedro Alves  <palves@redhat.com>
3098
3099         * completer.c (complete_nested_command_line): New.
3100         (gdb_completion_word_break_characters_throw): Add assertion.
3101         * completer.h (complete_nested_command_line): Declare.
3102
3103 2019-06-13  Pedro Alves  <palves@redhat.com>
3104
3105         * stack.c (parse_backtrace_qualifiers): New.
3106         (backtrace_command): Use it.
3107         (backtrace_command_completer): Complete on qualifiers.
3108
3109 2019-06-13  Pedro Alves  <palves@redhat.com>
3110
3111         * frame.c: Include "cli/cli-option.h.
3112         (user_set_backtrace_options): New.
3113         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3114         Delete.
3115         (get_prev_frame): Adjust.
3116         (boolean_option_def, uinteger_option_def)
3117         (set_backtrace_option_defs): New.
3118         (_initialize_frame): Adjust and use
3119         gdb::option::add_setshow_cmds_for_options to install "set
3120         backtrace past-main" and "set backtrace past-entry".
3121         * frame.h: Include "cli/cli-option.h".
3122         (struct frame_print_options): Forward declare.
3123         (print_frame_arguments_all, print_frame_arguments_scalars)
3124         (print_frame_arguments_none): Declare.
3125         (print_entry_values): Delete declaration.
3126         (struct frame_print_options, user_frame_print_options): New.
3127         (struct set_backtrace_options): New.
3128         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3129         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3130         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3131         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3132         (list_args_or_locals): Add frame_print_options parameter.
3133         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3134         * python/py-framefilter.c (enumerate_args): Pass down
3135         USER_FRAME_PRINT_OPTIONS.
3136         * stack.c: Include "cli/cli-option.h".
3137         (print_frame_arguments_all, print_frame_arguments_scalars)
3138         (print_frame_arguments_none): Declare.
3139         (print_raw_frame_arguments, print_entry_values): Delete.
3140         (user_frame_print_options): New.
3141         (boolean_option_def, enum_option_def, frame_print_option_defs):
3142         New.
3143         (struct backtrace_cmd_options): New.
3144         (bt_flag_option_def): New.
3145         (backtrace_command_option_defs): New.
3146         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3147         (print_frame_arg, read_frame_arg, print_frame_args)
3148         (print_frame_info, print_frame): Add frame_print_options parameter
3149         and use it.
3150         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3151         (backtrace_command_1): Add frame_print_options and
3152         backtrace_cmd_options parameters and use them.
3153         (make_backtrace_options_def_group): New.
3154         (backtrace_command): Process command options with
3155         gdb::option::process_options.
3156         (backtrace_command_completer): New.
3157         (_initialize_stack): Extend "backtrace"'s help to mention
3158         supported options.  Install completer for "backtrace".
3159         Install some settings commands with add_setshow_cmds_for_options.
3160
3161 2019-06-13  Pedro Alves  <palves@redhat.com>
3162
3163         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3164         and that "set/show print raw frame-arguments" are now deprecated.
3165
3166         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3167         command.
3168         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3169         * stack.c (_initialize_stack): Install "set/show print
3170         raw-frame-arguments", and deprecate "set/show print raw
3171         frame-arguments".
3172         * valprint.c (_initialize_valprint): Deprecate "set/show print
3173         raw".
3174
3175 2019-06-13  Pedro Alves  <palves@redhat.com>
3176
3177         * compile/compile.c (struct compile_options): New.
3178         (compile_flag_option_def, compile_command_option_defs)
3179         (make_compile_options_def_group): New.
3180         (compile_file_command): Handle options with
3181         gdb::option::process_options.
3182         (compile_file_command_completer): New function.
3183         (compile_code_command): Handle options with
3184         gdb::option::process_options.
3185         (compile_code_command_completer): New function.
3186         (_initialize_compiler): Install completers for "compile code" and
3187         "compile file".  Mention available options in "compile code" and
3188         "compile code"'s help.
3189         * completer.c (advance_to_completion_word): New, factored out from
3190         ...
3191         (advance_to_expression_complete_word_point): ... this.
3192         (advance_to_filename_complete_word_point): New.
3193         * completer.h (advance_to_filename_complete_word_point): New
3194         declaration.
3195
3196 2019-06-13  Pedro Alves  <palves@redhat.com>
3197
3198         * compile/compile.c: Include "cli/cli-option.h".
3199         (compile_print_value): Scope data pointer is now a
3200         value_print_options pointer; adjust.
3201         (compile_print_command): Process options.  Scope data pointer is
3202         now a value_print_options pointer; adjust.
3203         (_initialize_compile): Update "compile print"'s help to include
3204         supported options.  Install a completer for "compile print".
3205         * cp-valprint.c (show_vtblprint, show_objectprint)
3206         (show_static_field_print): Delete.
3207         (_initialize_cp_valprint): Don't install "set print
3208         static-members", "set print vtbl", "set print object" here.
3209         * printcmd.c: Include "cli/cli-option.h" and
3210         "common/gdb_optional.h".
3211         (print_command_parse_format): Rework to fill in a
3212         value_print_options instead of a format_data.
3213         (print_value): Change parameter type from format_data pointer to
3214         value_print_options reference.  Adjust.
3215         (print_command_1): Process options.  Adjust to pass down a
3216         value_print_options.
3217         (print_command_completer): New.
3218         (_initialize_printcmd): Install print_command_completer as
3219         handle_brkchars completer for the "print" command.  Update
3220         "print"'s help to include supported options.
3221         * valprint.c: Include "cli/cli-option.h".
3222         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3223         here from cp-valprint.c.
3224         (boolean_option_def, uinteger_option_def)
3225         (value_print_option_defs, make_value_print_options_def_group):
3226         New.  Use gdb::option::add_setshow_cmds_for_options to install
3227         "set print elements", "set print null-stop", "set print repeats",
3228         "set print pretty", "set print union", "set print array", "set
3229         print address", "set print symbol", "set print array-indexes".
3230         * valprint.h: Include <string> and "cli/cli-option.h".
3231         (make_value_print_options_def_group): Declare.
3232         (print_value): Change parameter type from format_data pointer to
3233         value_print_options reference.
3234         (print_command_completer): Declare.
3235
3236 2019-06-13  Pedro Alves  <palves@redhat.com>
3237
3238         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3239         (COMMON_SFILES): Add maint-test-settings.c.
3240         * cli/cli-decode.c (boolean_enums): New global, factored out from
3241         ...
3242         (add_setshow_boolean_cmd): ... here.
3243         * cli/cli-decode.h (boolean_enums): Declare.
3244         * cli/cli-option.c: New file.
3245         * cli/cli-option.h: New file.
3246         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3247         factored out from ...
3248         (parse_cli_boolean_value(const char *)): ... this.
3249         (is_unlimited_literal): Change parameter type to pointer to
3250         pointer.  Adjust and advance ARG pointer.
3251         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3252         (parse_cli_var_enum): New, factored out from ...
3253         (do_set_command): ... this.  Adjust.
3254         * cli/cli-setshow.h (parse_cli_boolean_value)
3255         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3256         (parse_cli_var_enum): Declare.
3257         * cli/cli-utils.c: Include "cli/cli-option.h".
3258         (get_ulongest): New.
3259         * cli/cli-utils.h (get_ulongest): Declare.
3260         (check_for_argument): New overloads.
3261         * maint-test-options.c: New file.
3262
3263 2019-06-13  Pedro Alves  <palves@redhat.com>
3264
3265         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3266         parse a range if "-" is at the end of the string.
3267
3268 2019-06-13  Pedro Alves  <palves@redhat.com>
3269
3270         * cli/cli-setshow.c (parse_auto_binary_operation)
3271         (parse_cli_boolean_value): Don't allow "o".
3272
3273 2019-06-13  Pedro Alves  <palves@redhat.com>
3274
3275         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3276         * NEWS: Mention maint test-settings KIND.
3277         * maint-test-settings.c: New file.
3278
3279 2019-06-13  Pedro Alves  <palves@redhat.com>
3280
3281         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3282         completer.
3283         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3284         "set" completers.
3285
3286 2019-06-13  Pedro Alves  <palves@redhat.com>
3287
3288         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3289         after item.
3290
3291 2019-06-13  Pedro Alves  <palves@redhat.com>
3292
3293         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3294
3295 2019-06-13  Pedro Alves <palves@redhat.com>
3296
3297         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3298         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3299         call.
3300         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3301         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3302         calls.
3303         (check_for_argument): Skip spaces after argument.
3304
3305 2019-06-13  Pedro Alves  <palves@redhat.com>
3306
3307         * thread.c (thread_apply_command): Adjust TID parsing.
3308         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3309         detected before end of string.
3310         (tid_is_in_list): Error out if LIST is invalid.
3311
3312 2019-06-13  Pedro Alves  <palves@redhat.com>
3313
3314         * completer.c (complete_line_internal_1): Rewind completion word
3315         point.
3316         (completion_tracker::advance_custom_word_point_by): Change
3317         parameter type to int.
3318         * completer.h (completion_tracker::advance_custom_word_point_by):
3319         Likewise.
3320
3321 2019-06-13  Pedro Alves  <palves@redhat.com>
3322
3323         * completer.c (advance_to_completion_word): Handle delimiters.
3324
3325 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3326
3327         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3328
3329 2019-06-11  Tom Tromey  <tom@tromey.com>
3330
3331         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3332         (xmalloc_failed): Move to alloc.c.
3333         * alloc.c: New file.
3334         * Makefile.in (COMMON_SFILES): Add alloc.c.
3335
3336 2019-06-11  Tom Tromey  <tom@tromey.com>
3337
3338         * nat/linux-waitpid.c: Don't include server.h.
3339         (linux_debug): Remove.
3340         (my_waitpid): Update.
3341
3342 2019-06-11  Tom Tromey  <tromey@adacore.com>
3343
3344         * infcall.c (_initialize_infcall): Remove trailing newline from
3345         help.
3346         * user-regs.c (_initialize_user_regs): Remove trailing newline
3347         from help.
3348         * typeprint.c (_initialize_typeprint): Remove trailing newline
3349         from help.
3350         * reverse.c (_initialize_reverse): Remove trailing newlines from
3351         help.
3352         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3353         from help.
3354         * language.c (add_set_language_command): Remove trailing newline
3355         from help.
3356         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3357         help.
3358         * disasm.c (_initialize_disasm): Remove trailing newline from
3359         help.
3360         * top.c (init_main): Remove trailing newline from help.
3361         * interps.c (_initialize_interpreter): Remove trailing newline
3362         from help.
3363         * btrace.c (_initialize_btrace): Remove trailing newlines from
3364         help.
3365         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3366         from help.
3367         * python/python.c (_initialize_python): Remove trailing newline
3368         from help.
3369         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3370         help.
3371         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3372         from help.  Reformat some text.
3373         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3374         from help.
3375         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3376         newline from help.
3377
3378 2019-06-11  Tom Tromey  <tromey@adacore.com>
3379
3380         * darwin-nat.c (darwin_decode_exception_message)
3381         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3382
3383 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * valops.c (value_slice): Check for not allocated or not
3386         associated values.
3387
3388 2019-06-10  Tom de Vries  <tdevries@suse.de>
3389
3390         PR gdb/24618
3391         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3392         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3393         invalid.
3394
3395 2019-06-10  Tom de Vries  <tdevries@suse.de>
3396
3397         PR gdb/24611
3398         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3399         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3400
3401 2019-06-10  Tom de Vries  <tdevries@suse.de>
3402
3403         PR symtab/24545
3404         * symtab.c (struct demangled_name_entry): Add language field.
3405         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3406         static minimal symbol".  Set and use language field.
3407
3408 2019-06-10  Tom Tromey  <tromey@adacore.com>
3409
3410         * ada-lang.c (_initialize_ada_language): Update help text.
3411
3412 2019-06-10  Tom Tromey  <tromey@adacore.com>
3413
3414         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3415         with a newline.
3416         * guile/guile.c (handle_boot_error): Don't end warning with a
3417         newline.
3418         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3419         warning with a newline.
3420         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3421         newline.
3422         (s12z_frame_cache): Likewise.
3423         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3424         a newline.
3425         * solib-svr4.c (disable_probes_interface): Don't end warning with
3426         a newline.
3427         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3428         newline.
3429         * python/python.c (do_finish_initialization): Don't end warning
3430         with a newline.
3431
3432 2019-06-10  Tom Tromey  <tom@tromey.com>
3433
3434         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3435         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3436         gdbpy_enter.
3437
3438 2019-06-10  Tom Tromey  <tromey@adacore.com>
3439
3440         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3441         data.
3442         (elf_new_init): Don't call stabsread_new_init.
3443         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3444         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3445         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3446
3447 2019-06-10  Tom de Vries  <tdevries@suse.de>
3448
3449         PR symtab/16264
3450         PR symtab/24517
3451         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3452
3453 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3454
3455         * source.c (find_and_open_source): Also rewrite relative file
3456         names.
3457
3458 2019-04-26  Amos Bird  <amosbird@gmail.com>
3459
3460         * annotate.c (annotate_thread_exited): Add "thread-exited"
3461         annotation.
3462
3463 2019-06-06  Tom Tromey  <tromey@adacore.com>
3464
3465         * maint.h (class scoped_command_stats): Use
3466         DISABLE_COPY_AND_ASSIGN.
3467         <print_time>: New method.
3468         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3469         print_time.
3470         (scoped_command_stats::print_time): New method.
3471
3472 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3475         instructions of lengths 6 or 8 bytes.
3476
3477 2019-06-04  Pedro Alves  <palves@redhat.com>
3478
3479         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3480
3481         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3482         * breakpoint.c (condition_completer): Likewise.
3483         * cli/cli-dump.c (scan_expression): Likewise.
3484         * common/filestuff.c (mkdir_recursive): Likewise.
3485         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3486         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3487         (gdb_abspath): Likewise.
3488         * compile/compile-cplus-types.c
3489         (compile_cplus_instance::decl_name): Likewise.
3490         * completer.c (complete_explicit_location):
3491         (signal_completer, reg_or_group_completer_1): Likewise.
3492         * cp-support.c (cp_remove_params_if_any): Likewise.
3493         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3494         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3495         * infcmd.c (strip_bg_char): Likewise.
3496         * linespec.c (copy_token_string): Likewise.
3497         * mi/mi-main.c (output_cores): Likewise.
3498         * psymtab.c (psymtab_search_name):
3499         * symfile.c (test_set_ext_lang_command): Likewise.
3500         * target.c (target_fileio_read_stralloc): Likewise.
3501         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3502         * value.c (complete_internalvar): Likewise.
3503
3504 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3505
3506         Add objfile property to gdb.Type.
3507         * NEWS: Mention Python API addition.
3508         * python/py-type.c (typy_get_objfile): New method.
3509
3510 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3511
3512         * NEWS: Mention the new set|show style [title|highlight].
3513         Mention changes to "show style", "help" and "apropos".
3514
3515 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3516
3517         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3518         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3519         instead of print_help_for_command.
3520         (print_doc_of_command): New function.
3521         (help_list): Add 'apropos -v word' suggestion.
3522         (print_help_for_command): Style the command name using title style.
3523         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3524         (_initialize_cli_cmds): Describe -v in apropos_command help.
3525
3526 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3527
3528         * cli/cli-style.h (cli_style_option): Add name in constructor,
3529         add m_name class member, add constructor with intensity,
3530         add name class function.
3531         (cli_style_option::add_setshow_commands): Remove name argument.
3532         (highlight_style, title_style): New styles.
3533         * cli/cli-style.c (do_show): New function that shows a style
3534         characteristic styling the style name with itself.
3535         (set_style_name): New function.
3536         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3537         Update all callers according to the changes in cli/cli-style.h.
3538         * utils.h (fputs_highlighted): New function.
3539         * utils.c (fputs_highlighted): Likewise.
3540
3541 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3542
3543         * NEWS: Mention new pipe command and new convenience variables.
3544
3545 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3546
3547         * cli/cli-cmds.c (pipe_command): New function.
3548         (_initialize_cli_cmds): Call add_com for pipe_command.
3549         Define | as an alias for pipe.
3550         (exit_status_set_internal_vars): New function.
3551         (shell_escape): Call exit_status_set_internal_vars.
3552         cli/cli-decode.c (find_command_name_length): Recognize | as
3553         a single character command.
3554
3555 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3556
3557         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3558         top.c (execute_command_to_ui_file): New function, mostly a copy
3559         of execute_command_to_string.
3560         (execute_command_to_string): Implement by calling
3561         execute_command_to_ui_file.
3562
3563 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3564
3565         * top.h (saved_command_line): Remove declaration.
3566         * top.c (previous_saved_command_line, previous_repeat_arguments):
3567         New variables.
3568         (saved_command_line): Make static, define together with other
3569         'repeat variables'.
3570         (dont_repeat): Clear repeat_arguments.
3571         (repeat_previous, get_saved_command_line, save_command_line):
3572         New functions.
3573         (gdb_init): Initialize saved_command_line
3574         and previous_saved_command_line.
3575         * main.c (captured_main_1): Remove saved_command_line initialization.
3576         * event-top.c (handle_line_of_input): Update to use
3577         the new 'repeat' related functions instead of direct access to
3578         saved_command_line.
3579         * command.h (repeat_previous, get_saved_command_line,
3580         save_command_line): New declarations.
3581         (dont_repeat): Add comment.
3582
3583 2019-05-30  Tom Tromey  <tromey@adacore.com>
3584
3585         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3586         Fix comment.
3587         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3588
3589 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3590
3591         PR cli/24587
3592         * completer.c (complete): Initialize variable word.
3593
3594 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3595
3596         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3597         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3598         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3599         'body' is NULL to the outter 'if', protecting the '!is_define'
3600         situation as well.
3601
3602 2019-05-29  Tom Tromey  <tromey@adacore.com>
3603
3604         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3605         (dwarf_unknown): New function.
3606         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3607         (dwarf_type_encoding_name): Use dwarf_unknown.
3608
3609 2019-05-29  Tom Tromey  <tromey@adacore.com>
3610
3611         PR c++/20020:
3612         * cp-valprint.c (cp_print_value_fields): Call
3613         cp_print_static_field inside "try".
3614
3615 2019-05-29  Tom Tromey  <tromey@adacore.com>
3616
3617         * inflow.c (struct terminal_info): Add default operator=.
3618         * configure: Rebuild.
3619         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3620         -Wdeprecated-copy-dtor, -Wredundant-move.
3621
3622 2019-05-29  Tom Tromey  <tromey@adacore.com>
3623
3624         * NEWS: Add entry.
3625         * infcmd.c (print_return_value_1): Handle finish_print
3626         option.
3627         (show_print_finish): New function.
3628         (_initialize_infcmd): Add "set/show print finish" commands.
3629         * valprint.c (user_print_options): Initialize new member.
3630         * valprint.h (struct value_print_options) <finish_print>: New
3631         member.
3632
3633 2019-05-28  Tom Tromey  <tromey@adacore.com>
3634
3635         * ada-lang.c (ada_remove_Xbn_suffix)
3636         (find_old_style_renaming_symbol)
3637         (parse_old_style_renaming): Remove.
3638         (ada_find_renaming_symbol): Don't call
3639         find_old_style_renaming_symbol.
3640         (ada_is_renaming_symbol): Rename from
3641         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3642         bool.  Now static.
3643         (ada_read_var_value): Update and simplify.
3644         * ada-exp.y (write_var_or_type): Remove old code.
3645
3646 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3647
3648         * event-top.c: Remove include comment.
3649         * inflow.c (class scoped_ignore_sigttou): Move from here...
3650         * inflow.h (class scoped_ignore_sigttou): ...to here.
3651         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3652         * top.c:  Remove include comment.
3653
3654 2019-05-27  Tom Tromey  <tom@tromey.com>
3655
3656         * NEWS: Fix typo.
3657
3658 2019-05-22  Tom Tromey  <tromey@adacore.com>
3659
3660         * target.c (target_follow_exec): Constify parameter.
3661         * target-delegates.c: Rebuild.
3662         * remote.c (remote_target::follow_exec): Constify parameter.
3663         * infrun.c (follow_exec): Constify parameter.
3664         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3665         (target_follow_exec): Likewise.
3666
3667 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3668
3669         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3670         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3671
3672 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3673
3674         * NEWS: Add debugredirect and testsuite sections.
3675
3676 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3677
3678         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3679         target descriptions using exclusively floating point register name
3680         aliases.
3681
3682 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3683
3684         PR gdb/18644:
3685         * f-lang.c (build_fortran_types): Handle the case where
3686         gdbarch_floatformat_for_type returns a nullptr.
3687
3688 2019-05-21  Tom de Vries  <tdevries@suse.de>
3689
3690         PR cli/24587
3691         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3692
3693 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3694
3695         PR gdb/18644:
3696         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3697         16-byte floats.
3698         * i386-tdep.c (i386_floatformat_for_type): Use
3699         floatformats_ia64_quad for the 16-byte floating point component
3700         within a fortran 32-byte complex number.
3701
3702 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3703
3704         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3705         delete default constructor.
3706         (find_partial_die): Update to return const struct.
3707         (partial_die_parent_scope): Move variable declaration into scope
3708         of its use and change its type to auto.
3709         (guess_partial_die_structure_name): Likewise.
3710         (partial_die_info::fixup): Likewise.
3711
3712 2019-05-17  Tom Tromey  <tromey@adacore.com>
3713
3714         * source.c (find_and_open_source): Remove cast.
3715
3716 2019-05-17  Tom Tromey  <tromey@adacore.com>
3717
3718         * annotate.c (annotate_source): Make "filename" const.
3719         * annotate.h (annotate_source): Use const.
3720
3721 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3722
3723         * disasm.c (set_disassembler_options): Send errors to stderr.
3724
3725 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3726
3727         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3728         (cli_interp_base::set_logging): Check debug_redirect.
3729         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3730         * cli/cli-logging.c (debug_redirect): Add static variable.
3731         (pop_output_files): Add default param.
3732         (handle_redirections): Print debug setting.
3733         (show_logging_command): Likewise.
3734         (_initialize_cli_logging): Add debugredirect command.
3735         * interps.c (current_interp_set_logging): Add debug_redirect
3736         parameter.
3737         * interps.h (set_logging): Add debug_redirect parameter.
3738         (current_interp_set_logging): Likewise.
3739         * mi/mi-common.h: Likewise.
3740         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3741
3742 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3743             Tom Tromey  <tromey@adacore.com>
3744
3745         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3746         directly.
3747         * cli/cli-interp.h (make_logging_output): Remove declaration.
3748         * cli/cli-logging.c (make_logging_output): Remove function.
3749         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3750         directly.
3751         * ui-file.c (tee_file::tee_file): Remove bools.
3752         (tee_file::~tee_file): Remove deletes.
3753         * ui-file.h (tee_file): Remove bools.
3754
3755 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3756
3757         * mi/mi-cmds.h (mi_cmd_complete): New function.
3758         * mi/mi-main.c (mi_cmd_complete): Likewise.
3759         * mi/mi-cmds.c: Define new MI command -complete.
3760         * NEWS: Mention new -complete command.
3761
3762 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3763
3764         * completer.h (complete): New function.
3765         * completer.c (complete): Likewise.
3766         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3767         function defined in completer.h.
3768
3769 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3770
3771         * MAINTAINERS (Write After Approval): Add myself.
3772
3773 2019-05-17  Tom de Vries  <tdevries@suse.de>
3774
3775         PR gdb/24094
3776         * dwarf2read.c (struct cu_partial_die_info): New struct.
3777         (find_partial_die): Return cu_partial_die_info.
3778         (partial_die_parent_scope, guess_partial_die_structure_name)
3779         (partial_die_info::fixup): Handle new return type of find_partial_die.
3780
3781 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3782
3783         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3784         "std::string", simplifying the algorithm.
3785
3786 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3787
3788         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3789         (stap_static_probe_ops::get_probes): Likewise.
3790
3791 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3792
3793         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3794         '-')" and "else if".
3795         (stap_parse_single_operand): Join checks for
3796         "gdbarch_stap_parse_special_token_p" and
3797         "gdbarch_stap_parse_special_token" in the same "if" statement.
3798         Invert check when verifying for operation on register
3799         displacement.
3800
3801 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3802
3803         * stap-probe.c (stap_get_opcode): Update comment.
3804         (stap_get_expected_argument_type): Likewise.
3805         (handle_stap_probe): Likewise.
3806
3807 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3808
3809         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3810         return type to 'bool'.  Adjust comment.  Use 'bool' when
3811         appropriate.
3812         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3813         * stap-probe.c (stap_parse_argument_1): Likewise.
3814         (stap_is_operator): Likewise.
3815         (stap_is_generic_prefix): Likewise.
3816         (stap_is_register_prefix): Likewise.
3817         (stap_is_register_indirection_prefix): Likewise.
3818         (stap_is_integer_prefix): Likewise.
3819         (stap_generic_check_suffix): Likewise.
3820         (stap_check_integer_suffix): Likewise.
3821         (stap_check_register_suffix): Likewise.
3822         (stap_check_register_indirection_suffix): Likewise.
3823         (stap_parse_register_operand): Likewise.
3824         (stap_parse_single_operand): Likewise.
3825         (stap_parse_argument_1): Likewise.
3826         (stap_probe::get_argument_count): Likewise.
3827         (stap_is_operator): Likewise.
3828
3829 2019-05-16  Tom Tromey  <tromey@adacore.com>
3830
3831         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3832         keyword to foreach.
3833
3834 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3835
3836         * linux-thread-db.c (try_thread_db_load_1): Change return type
3837         to bool.
3838         (try_thread_db_load): Likewise.
3839         (try_thread_db_load_from_pdir_1): Likewise.
3840         (try_thread_db_load_from_pdir): Likewise.
3841         (try_thread_db_load_from_sdir): Likewise.
3842         (try_thread_db_load_from_dir): Likewise.
3843         (thread_db_load_search): Likewise.
3844         (has_libpthread): Likewise.
3845         (thread_db_load): Likewise.
3846
3847 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3848
3849         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3850         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3851         NULL, and complain/return if that's the case.
3852
3853 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3854
3855         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3856         (advance, posn, abstract_read_memory): New functions.
3857         [struct mem_read_abstraction]: New struct.
3858         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3859
3860 2019-05-14  Tom Tromey  <tromey@adacore.com>
3861
3862         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3863         value is not lval_memory.
3864
3865 2019-05-14  Tom Tromey  <tromey@adacore.com>
3866
3867         * solib.c (info_sharedlibrary_command): Style the file name.
3868
3869 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3870
3871         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3872         (aarch64_vnv_type): Likewise.
3873         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3874         * common/tdesc.c: Likewise.
3875         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3876         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3877         * features/aarch64-fpu.xml: Add ieee half view.
3878         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3879         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3880         * gdbtypes.h (struct builtin_type): Likewise.
3881         (struct objfile_type): Likewise.
3882
3883 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3884
3885         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3886         typo.
3887         * location.h (string_to_event_location): Likewise.
3888
3889 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3890
3891         GDB 8.3 released.
3892
3893 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3894
3895         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3896         New variable declaration.
3897         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3898         New variable.
3899         (print_one_breakpoint): Use ui_out::test_flags and new global
3900         variable to compute use_fixed_output.
3901         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3902         Remove.
3903         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3904         (mi_multi_location_breakpoint_output_fixed): Remove.
3905         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3906         new variable.
3907         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3908         fix_multi_location_breakpoint_output flag if version >= 3.
3909         * ui-out.h (enum ui_out_flag)
3910         <fix_multi_location_breakpoint_output>: New enumerator.
3911
3912 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3913
3914         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3915
3916 2019-05-10  Tom Tromey  <tromey@adacore.com>
3917
3918         * ada-lang.c (catch_ada_completer): New function.
3919         (_initialize_ada_language): Use it.
3920
3921 2019-05-10  Tom Tromey  <tromey@adacore.com>
3922
3923         * thread.c (print_thread_info): Make "requested_threads" const.
3924         * gdbthread.h (print_thread_info): Make "requested_threads"
3925         const.
3926         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3927         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3928
3929 2019-05-08  Tom Tromey  <tom@tromey.com>
3930
3931         * gdbtypes.c (objfile_type_data): Change type.
3932         (objfile_type, _initialize_gdbtypes): Update.
3933
3934 2019-05-08  Tom Tromey  <tom@tromey.com>
3935
3936         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3937         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3938         (_initialize_dwarf2_frame): Update.
3939
3940 2019-05-08  Tom Tromey  <tom@tromey.com>
3941
3942         * objc-lang.c (objc_objfile_data): Change type.
3943         (find_methods): Update.
3944         (_initialize_objc_lang): Remove.
3945
3946 2019-05-08  Tom Tromey  <tom@tromey.com>
3947
3948         * stabsread.c (rs6000_builtin_type_data): Change type.
3949         (rs6000_builtin_type, _initialize_stabsread): Update.
3950
3951 2019-05-08  Tom Tromey  <tom@tromey.com>
3952
3953         * mips-tdep.c (mips_pdr_data): Remove.
3954         (_initialize_mips_tdep): Update.
3955
3956 2019-05-08  Tom Tromey  <tom@tromey.com>
3957
3958         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3959         (hppa_init_objfile_priv_data, read_unwind_info)
3960         (find_unwind_entry, _initialize_hppa_tdep): Update.
3961
3962 2019-05-08  Tom Tromey  <tom@tromey.com>
3963
3964         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3965         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3966         on obstack.
3967         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3968
3969 2019-05-08  Tom Tromey  <tom@tromey.com>
3970
3971         * mdebugread.c (basic_type_data): Change type.
3972         (basic_type, _initialize_mdebugread): Update.
3973
3974 2019-05-08  Tom Tromey  <tom@tromey.com>
3975
3976         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3977
3978 2019-05-08  Tom Tromey  <tom@tromey.com>
3979
3980         * nto-tdep.c (nto_inferior_data_reg): Change type.
3981         (nto_inferior_data): Update.
3982         (nto_inferior_data_cleanup, nto_new_inferior_data)
3983         (_initialize_nto_tdep): Remove.
3984         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3985
3986 2019-05-08  Tom Tromey  <tom@tromey.com>
3987
3988         * ada-lang.c (struct ada_inferior_data): Add initializers.
3989         (ada_inferior_data): Change type.
3990         (ada_inferior_data_cleanup): Remove.
3991         (get_ada_inferior_data, ada_inferior_exit)
3992         (struct ada_pspace_data): Add initializers, destructor.
3993         (ada_pspace_data_handle): Change type.
3994         (get_ada_pspace_data): Update.
3995         (ada_pspace_data_cleanup): Remove.
3996
3997 2019-05-08  Tom Tromey  <tom@tromey.com>
3998
3999         * coffread.c (struct coff_symfile_info): Add initializers.
4000         (coff_objfile_data_key): Move lower.  Change type.
4001         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4002         Update.
4003         (coff_free_info): Remove.
4004
4005 2019-05-08  Tom Tromey  <tom@tromey.com>
4006
4007         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4008         (fbsd_pspace_data_handle): Move lower.  Change type.
4009         (get_fbsd_pspace_data): Update.
4010         (fbsd_pspace_data_cleanup): Remove.
4011         (_initialize_fbsd_tdep): Update.
4012
4013 2019-05-08  Tom Tromey  <tom@tromey.com>
4014
4015         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4016         (get_ada_tasks_pspace_data): Update.
4017         (ada_tasks_pspace_data_cleanup): Remove.
4018         (_initialize_tasks): Update.
4019         (ada_tasks_inferior_data_handle): Change type.
4020         (get_ada_tasks_inferior_data): Update.
4021         (ada_tasks_inferior_data_cleanup): Remove.
4022         (struct ada_tasks_pspace_data): Add initializers.
4023
4024 2019-05-08  Tom Tromey  <tom@tromey.com>
4025
4026         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4027         * symfile-debug.c (debug_sym_get_probes): Change type.
4028         * stap-probe.c (handle_stap_probe):
4029         (stap_static_probe_ops::get_probes): Change type.
4030         * probe.h (class static_probe_ops) <get_probes>: Change type.
4031         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4032         (parse_probes_in_pspace): Update.
4033         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4034         Update.
4035         (any_static_probe_ops::get_probes): Change type.
4036         * elfread.c (elfread_data): New typedef.
4037         (probe_key): Change type.
4038         (elf_get_probes): Likewise.  Update.
4039         (probe_key_free): Remove.
4040         (_initialize_elfread): Update.
4041         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4042         Change type.
4043         (dtrace_process_dof_probe, dtrace_process_dof)
4044         (dtrace_static_probe_ops::get_probe): Change type.
4045
4046 2019-05-08  Tom Tromey  <tom@tromey.com>
4047
4048         * xcoffread.c (struct xcoff_symfile_info): Rename from
4049         coff_symfile_info.  Add initializers.
4050         (xcoff_objfile_data_key): Move lower.  Change type.
4051         (XCOFF_DATA): Rewrite.
4052         (xcoff_free_info): Remove.
4053         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4054         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4055         (xcoff_initial_scan): Update.
4056
4057 2019-05-08  Tom Tromey  <tom@tromey.com>
4058
4059         * solib-svr4.c (struct svr4_info): Add initializers and
4060         destructor.
4061         <probes_table>: Now an htab_up.
4062         (solib_svr4_pspace_data): Change type.
4063         (free_probes_table): Simplify.
4064         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4065         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4066         (probes_table_remove_objfile_probes, register_solib_event_probe)
4067         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4068         (_initialize_svr4_solib): Update.
4069
4070 2019-05-08  Tom Tromey  <tom@tromey.com>
4071
4072         * remote.c (remote_pspace_data): Change type.
4073         (remote_pspace_data_cleanup): Remove.
4074         (get_remote_exec_file, set_pspace_remote_exec_file)
4075         (_initialize_remote): Update.
4076
4077 2019-05-08  Tom Tromey  <tom@tromey.com>
4078
4079         * breakpoint.c (breakpoint_objfile_key): Change type.
4080         (get_breakpoint_objfile_data): Update.
4081         (free_breakpoint_objfile_data): Remove.
4082         (_initialize_breakpoint): Update.
4083
4084 2019-05-08  Tom Tromey  <tom@tromey.com>
4085
4086         * linux-tdep.c (struct linux_info): Add initializers.
4087         (linux_inferior_data): Move.  Change type.
4088         (invalidate_linux_cache_inf): Update.
4089         (linux_inferior_data_cleanup): Remove.
4090         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4091
4092 2019-05-08  Tom Tromey  <tom@tromey.com>
4093
4094         * auxv.c (auxv_inferior_data): Move.  Change type.
4095         (auxv_inferior_data_cleanup): Remove.
4096         (invalidate_auxv_cache_inf): Rewrite.
4097         (get_auxv_inferior_data, _initialize_auxv): Update.
4098
4099 2019-05-08  Tom Tromey  <tom@tromey.com>
4100
4101         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4102         (symfile_debug_objfile_data_key): Change type.
4103         (symfile_debug_installed, debug_qf_has_symbols)
4104         (debug_qf_find_last_source_symtab)
4105         (debug_qf_forget_cached_source_info)
4106         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4107         (debug_qf_print_stats, debug_qf_dump)
4108         (debug_qf_expand_symtabs_for_function)
4109         (debug_qf_expand_all_symtabs)
4110         (debug_qf_expand_symtabs_with_fullname)
4111         (debug_qf_map_matching_symbols)
4112         (debug_qf_expand_symtabs_matching)
4113         (debug_qf_find_pc_sect_compunit_symtab)
4114         (debug_qf_map_symbol_filenames)
4115         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4116         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4117         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4118         (debug_sym_read_linetable, debug_sym_relocate): Update.
4119         (symfile_debug_free_objfile): Remove.
4120         (install_symfile_debug_logging, _initialize_symfile_debug):
4121         Update.
4122
4123 2019-05-08  Tom Tromey  <tom@tromey.com>
4124
4125         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4126         allocate_on_obstack.
4127         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4128         (get_dwarf2_per_objfile): Update.
4129         (set_dwarf2_per_objfile): Remove.
4130         (dwarf2_has_info, dwarf2_get_section_info): Update.
4131         (dwarf2_free_objfile): Remove.
4132         (_initialize_dwarf2_read): Update.
4133
4134 2019-05-08  Tom Tromey  <tom@tromey.com>
4135
4136         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4137         initializers.
4138         <unsupported_script_warning_printed,
4139         script_not_found_warning_printed>: Now bool.
4140         (auto_load_pspace_data): Change type.
4141         (~auto_load_pspace_info): Rename from
4142         auto_load_pspace_data_cleanup.
4143         (get_auto_load_pspace_data, init_loaded_scripts_info)
4144         (clear_section_scripts, maybe_print_unsupported_script_warning)
4145         (maybe_print_script_not_found_warning, _initialize_auto_load):
4146         Update.
4147
4148 2019-05-08  Tom Tromey  <tom@tromey.com>
4149
4150         * objfiles.c (objfile_pspace_info): Add destructor and
4151         initializers.
4152         (objfiles_pspace_data): Change type.
4153         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4154         (get_objfile_pspace_data): Update.
4155         (objfiles_bfd_data): Change type.
4156         (get_objfile_bfd_data): Update.
4157         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4158
4159 2019-05-08  Tom Tromey  <tom@tromey.com>
4160
4161         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4162         Change type.
4163         (get_catch_syscall_inferior_data): Update.
4164         (catch_syscall_inferior_data_cleanup): Remove.
4165         (_initialize_break_catch_syscall): Update.
4166
4167 2019-05-08  Tom Tromey  <tom@tromey.com>
4168
4169         * inflow.c (struct terminal_info): Add destructor and
4170         initializers.
4171         (inflow_inferior_data): Change type.
4172         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4173         (get_inflow_inferior_data, inflow_inferior_exit)
4174         (swap_terminal_info, _initialize_inflow): Update.
4175
4176 2019-05-08  Tom Tromey  <tom@tromey.com>
4177
4178         * target-dcache.c (target_dcache_cleanup): Remove.
4179         (target_dcache_aspace_key): Change type.
4180         (target_dcache_init_p, target_dcache_invalidate)
4181         (target_dcache_get, target_dcache_get_or_init)
4182         (_initialize_target_dcache): Update.
4183         * dcache.h (struct dcache_deleter): New.
4184
4185 2019-05-08  Tom Tromey  <tom@tromey.com>
4186
4187         * symtab.c (struct symbol_cache): Add destructor and
4188         initializers.
4189         (symbol_cache_key): Move.  Change type.
4190         (make_symbol_cache, free_symbol_cache): Remove.
4191         (get_symbol_cache): Update.
4192         (symbol_cache_cleanup): Remove.
4193         (ALL_PSPACES, symbol_cache_flush)
4194         (maintenance_print_symbol_cache)
4195         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4196         Update.
4197
4198 2019-05-08  Tom Tromey  <tom@tromey.com>
4199
4200         * symtab.c (struct main_info): Add destructor and initializers.
4201         (main_progspace_key): Move.  Change type.
4202         (get_main_info): Update.
4203         (main_info_cleanup): Remove.
4204         (_initialize_symtab): Update.
4205
4206 2019-05-08  Tom Tromey  <tom@tromey.com>
4207
4208         * registry.h (DECLARE_REGISTRY): Define the _key class.
4209
4210 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4211
4212         * NEWS: Merge two 'New commands' sections.
4213
4214 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4215
4216         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4217         parameter and use Ada language definition instead.
4218         (ada_val_print_ptr): Remove unused language parameter.
4219         (ada_val_print_num): Remove language parameter and use Ada language
4220         definition instead.
4221         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4222         parameter.
4223         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4224         parameter and use Ada language definition instead.
4225         (ada_val_print_1): Update all ada_val_print_xxx calls.
4226         Remove language parameter.
4227         (ada_val_print): Update ada_val_print_1 call.
4228
4229 2019-05-08  Tom Tromey  <tromey@adacore.com>
4230
4231         * remote.c (remote_hw_watchpoint_limit)
4232         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4233         Now static.
4234
4235 2019-05-08  Tom Tromey  <tromey@adacore.com>
4236
4237         * maint.c (_initialize_maint_cmds): Move initialization code to
4238         remote.c.
4239         (watchdog, show_watchdog): Move to remote.c.
4240         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4241         "watchdog" static.
4242         (_initialize_remote): Move initialization code from maint.c.
4243         * defs.h (watchdog): Don't declare.
4244
4245 2019-05-08  Tom Tromey  <tromey@adacore.com>
4246
4247         * tui/tui-interp.c: Include main.h.
4248         * interps.c: Include main.h.
4249         * main.h (interpreter_p): Declare.
4250         * defs.h (interpreter_p): Don't declare.
4251
4252 2019-05-08  Tom Tromey  <tromey@adacore.com>
4253
4254         * dwarf2loc.c: Include dwarf2read.h.
4255         * defs.h (read_unsigned_leb128): Don't declare.
4256         * dwarf2read.h (read_unsigned_leb128): Declare.
4257
4258 2019-05-08  Tom Tromey  <tromey@adacore.com>
4259
4260         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4261         method.
4262
4263 2019-05-08  Tom Tromey  <tromey@adacore.com>
4264
4265         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4266         when no wrap column is set.
4267
4268 2019-05-08  Tom Tromey  <tromey@adacore.com>
4269
4270         * c-lang.c (c_get_string): Handle non-C-style arrays.
4271
4272 2019-05-08  Tom Tromey  <tromey@adacore.com>
4273
4274         * typeprint.c (print_offset_data::update): Print the bit offset,
4275         not the number of bits remaining.
4276
4277 2019-05-08  Tom Tromey  <tromey@adacore.com>
4278
4279         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4280         padding at end of comment.
4281
4282 2019-05-08  Tom Tromey  <tromey@adacore.com>
4283
4284         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4285         Compare main types.
4286
4287 2019-05-06  Tom Tromey  <tom@tromey.com>
4288
4289         * common/scoped_mmap.c: Include common-defs.h.
4290         * common/scoped_mmap.h: Don't include config.h.
4291
4292 2019-05-04  Tom Tromey  <tom@tromey.com>
4293
4294         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4295         (struct aarch64_call_info): Add initializers.
4296         <si>: Now a std::vector.
4297         (pass_on_stack, aarch64_push_dummy_call): Update.
4298
4299 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4300             Tom Tromey  <tom@tromey.com>
4301
4302         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4303         (ppc_threads): Now a std::vector.  Now static.
4304         (hwdebug_find_thread_points_by_tid)
4305         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4306         Update.
4307
4308 2019-05-04  Tom Tromey  <tom@tromey.com>
4309
4310         * arc-tdep.c (arc_tdesc_init): Return bool.
4311
4312 2019-05-04  Tom Tromey  <tom@tromey.com>
4313
4314         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4315         Use gdb_assert_not_reached.
4316
4317 2019-05-04  Tom Tromey  <tom@tromey.com>
4318
4319         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4320         "false".
4321
4322 2019-05-04  Tom Tromey  <tom@tromey.com>
4323
4324         * arc-tdep.c (arc_tdesc_init): Use bool.
4325
4326 2019-05-04  Tom Tromey  <tom@tromey.com>
4327
4328         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4329
4330 2019-05-04  Tom Tromey  <tom@tromey.com>
4331
4332         * cli/cli-cmds.c (valid_command_p): Return bool.
4333
4334 2019-05-04  Tom Tromey  <tom@tromey.com>
4335
4336         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4337         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4338
4339 2019-05-04  Raul Tambre  <raul@tambre.ee>
4340
4341         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4342         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4343         operator for comparison.
4344
4345 2019-05-04  Tom Tromey  <tom@tromey.com>
4346
4347         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4348         (lookup_partial_symbol, print_partial_symbols)
4349         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4350         (psymbol_compare): Update.
4351         (add_psymbol_to_bcache): Clear the entire psymbol.
4352         (maintenance_check_psymtabs): Update.
4353         * psympriv.h (struct partial_symbol): Don't derive from
4354         general_symbol_info.
4355         <obj_section, unrelocated_address, address,
4356         set_unrelocated_address>: Update.
4357         <ginfo>: New member.
4358         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4359         (debug_names::write_psymbols): Update.
4360
4361 2019-05-04  Tom de Vries  <tdevries@suse.de>
4362
4363         * contrib/cc-with-tweaks.sh: Support -n arg.
4364
4365 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4366
4367         * corelow.c (core_target::detach): Ensure frame cache and
4368         register caches are cleared.
4369         inferior.c (exit_inferior_1): Likewise.
4370
4371 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4372             Tom Tromey  <tom@tromey.com>
4373
4374         * dictionary.c (collate_pending_symbols_by_language): Remove
4375         "struct" from foreach.
4376         * symtab.c (lookup_global_symbol_from_objfile)
4377         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4378         foreach.
4379         * ser-tcp.c (net_open): Remove "struct" from foreach.
4380         * objfiles.c (objfile_relocate, objfile_rebase)
4381         (objfile_has_symbols): Remove "struct" from foreach.
4382         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4383         from foreach.
4384         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4385         foreach.
4386         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4387         "struct" from foreach.
4388         * ada-lang.c (create_excep_cond_exprs)
4389         (ada_exception_catchpoint_cond_string): Remove "struct" from
4390         foreach.
4391
4392 2019-05-03  Tom Tromey  <tromey@adacore.com>
4393
4394         * ada-exp.y (convert_char_literal): Check suffix of each
4395         enumerator.
4396
4397 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4398
4399         PR ada/21406:
4400         * ada-exp.y (yywrap): Don't define.
4401         * ada-lex.l (%option): Add noyywrap
4402         (yywrap): Remove.
4403
4404 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4405
4406         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4407         _WIN32_WINNT to the XP level, unless already defined to a higher
4408         level.
4409
4410         * unittests/parse-connection-spec-selftests.c:
4411         * ser-tcp.c:
4412         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4413         override.
4414
4415         * symfile.c (find_separate_debug_file): Remove colon from the
4416         drive spec of DOS/Windows file names of the target, so that the
4417         file name produced from DEBUGDIR and the target's directory will
4418         be valid on DOS/Windows systems.
4419
4420 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * rust-lang.c (val_print_struct): Handle printing structures
4423         containing strings.
4424
4425 2019-05-02  Tom Tromey  <tromey@adacore.com>
4426
4427         * valarith.c (_initialize_valarith): Remove.
4428
4429 2019-05-01  Tom Tromey  <tromey@adacore.com>
4430
4431         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4432         bitfields.
4433
4434 2019-05-01  Tom Tromey  <tromey@adacore.com>
4435
4436         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4437         for big-endian copies.
4438
4439 2019-04-30  Ali Tamur  <tamur@google.com>
4440         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4441         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4442         (read_3_bytes): New function.
4443
4444 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4445
4446         * windows-nat.c (main_thread_id): Delete.
4447         (handle_output_debug_string): Replace main_thread_id by
4448         current_event.dwThreadId.
4449         (fake_create_process): Likewise.
4450         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4451         Do not set main_thread_id.
4452         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4453         current_event.dwThreadId.
4454         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4455
4456 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4457
4458         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4459         Use current_event.dwThreadId instead of main_thread_id.
4460
4461 2019-04-30  Tom Tromey  <tromey@adacore.com>
4462
4463         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4464         (create_excep_cond_exprs): Iterate over program spaces.
4465         (ada_exception_catchpoint_cond_string): Examine all minimal
4466         symbols for exception types.
4467
4468 2019-04-30  Tom Tromey  <tromey@adacore.com>
4469
4470         PR c++/24470:
4471         * dwarf2read.c (process_structure_scope): Handle case where type
4472         has template parameters but no symbol was created.
4473
4474 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4475             Chris January  <chris.january@arm.com>
4476
4477         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4478         qualifier.
4479         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4480
4481 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * f-typeprint.c (f_print_type): Update rules for printing
4484         whitespace.
4485         (f_type_print_varspec_suffix): Likewise.
4486
4487 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4488             Chris January  <chris.january@arm.com>
4489
4490         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4491         function arguments.
4492
4493 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * f-lang.c (build_fortran_types): Change name of void type to
4496         lower case.
4497         * f-typeprint.c (f_type_print_base): Print the name of the void
4498         type, rather than a fixed string.
4499         * f-valprint.c (f_decorations): Use lower case void string.
4500
4501 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4502             Chris January  <chris.january@arm.com>
4503
4504         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4505         types for Fortran.
4506
4507 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4508             Chris January  <chris.january@arm.com>
4509             David Lecomber  <david.lecomber@arm.com>
4510
4511         * f-exp.y (BINOP_INTRINSIC): New token.
4512         (exp): New parser rule handling BINOP_INTRINSIC.
4513         (f77_keywords): Add new builtin procedures.
4514         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4515         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4516         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4517         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4518         (print_unop_subexp_f): New function.
4519         (print_binop_subexp_f): New function.
4520         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4521         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4522         (dump_subexp_body_f): Likewise.
4523         (operator_check_f): Likewise.
4524         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4525         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4526
4527 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4528
4529         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4530         UNOP_KIND.
4531         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4532         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4533         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4534         (operator_length_f): New fuction.
4535         (print_subexp_f): New function.
4536         (op_name_f): New function.
4537         (dump_subexp_body_f): New function.
4538         (operator_check_f): New function.
4539         (exp_descriptor_f): Replace standard expression handling functions
4540         with new functions.
4541         * gdb/fortran-operator.def: New file.
4542         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4543         * gdb/std-operator.def: Remove UNOP_KIND.
4544
4545 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * std-operator.def: Remove unbalanced, stray double quote
4548         character.
4549
4550 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4551             Chris January  <chris.january@arm.com>
4552             Daniel Everett  <daniel.everett@arm.com>
4553             Nick Forrington  <nick.forrington@arm.com>
4554             Richard Bunt  <richard.bunt@arm.com>
4555
4556         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4557         of depth when printing anonymous structs or unions.
4558         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4559         Don't print either the top-level value, or the children if the
4560         max-depth is exceeded.
4561         (ppscm_print_children): When printing the key of a map, allow one
4562         extra level of depth.
4563         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4564         print either the top-level value, or the children if the max-depth
4565         is exceeded.
4566         (print_children): When printing the key of a map, allow one extra
4567         level of depth.
4568         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4569         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4570         (user_print_options): Initialise max_depth field.
4571         (val_print_scalar_or_string_type_p): New function.
4572         (val_print): Check to see if the max depth has been reached.
4573         (val_print_check_max_depth): Define new function.
4574         (show_print_max_depth): New function.
4575         (_initialize_valprint): Add 'print max-depth' option.
4576         * valprint.h (struct value_print_options) <max_depth>: New field.
4577         (val_print_check_max_depth): Declare new function.
4578         * NEWS: Document new feature.
4579
4580 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4581
4582         * ada-lang.c (ada_language_defn): Initialise new field.
4583         * c-lang.c (c_is_string_type_p): New function.
4584         (c_language_defn): Initialise new field.
4585         (cplus_language_defn): Initialise new field.
4586         (asm_language_defn): Initialise new field.
4587         (minimal_language_defn): Initialise new field.
4588         * c-lang.h (c_is_string_type_p): Declare new function.
4589         * d-lang.c (d_language_defn): Initialise new field.
4590         * f-lang.c (f_is_string_type_p): New function.
4591         (f_language_defn): Initialise new field.
4592         * go-lang.c (go_is_string_type_p): New function.
4593         (go_language_defn): Initialise new field.
4594         * language.c (default_is_string_type_p): New function.
4595         (unknown_language_defn): Initialise new field.
4596         (auto_language_defn): Initialise new field.
4597         * language.h (struct language_defn) <la_is_string_type_p>: New
4598         member variable.
4599         (default_is_string_type_p): Declare new function.
4600         * m2-lang.c (m2_language_defn): Initialise new field.
4601         * objc-lang.c (objc_language_defn): Initialise new field.
4602         * opencl-lang.c (opencl_language_defn): Initialise new field.
4603         * p-lang.c (pascal_is_string_type_p): New function.
4604         (pascal_language_defn): Initialise new field.
4605         * rust-lang.c (rust_is_string_type_p): New function.
4606         (rust_language_defn): Initialise new field.
4607
4608 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4611         New field.
4612         * ada-lang.c (ada_language_defn): Initialise new field.
4613         * c-lang.c (c_language_defn): Likewise.
4614         (cplus_language_defn): Likewise.
4615         (asm_language_defn): Likewise.
4616         (minimal_language_defn): Likewise.
4617         * d-lang.c (d_language_defn): Likewise.
4618         * f-lang.c (f_language_defn): Likewise.
4619         * go-lang.c (go_language_defn): Likewise.
4620         * language.c (unknown_language_defn): Likewise.
4621         (auto_language_defn): Likewise.
4622         * m2-lang.c (m2_language_defn): Likewise.
4623         * objc-lang.c (objc_language_defn): Likewise.
4624         * opencl-lang.c (opencl_language_defn): Likewise.
4625         * p-lang.c (pascal_language_defn): Likewise.
4626         * rust-lang.c (rust_language_defn): Likewise.
4627
4628 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4629
4630         * ada-lang.c (ada_is_character_type): Change return type to bool.
4631         (ada_is_string_type): Likewise.
4632         * ada-lang.h (ada_is_character_type): Update declaration
4633         (ada_is_string_type): Likewise.
4634
4635 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4636
4637         Support style in 'frame|thread apply'
4638
4639         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4640         * record.c (record_start, record_stop): Update callers of
4641         execute_command_to_string with false.
4642         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4643         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4644         methods.
4645         (class string_file): New constructor with term_out parameter.
4646         Override methods term_out and can_emit_style_escape.  New member
4647         term_out.
4648         (class stdio_file): Override can_emit_style_escape.
4649         (class tee_file): Override term_out and can_emit_style_escape.
4650         * utils.h (can_emit_style_escape): Remove.
4651         * utils.c (can_emit_style_escape): Likewise.
4652         Update all callers of can_emit_style_escape (SOMESTREAM) to
4653         SOMESTREAM->can_emit_style_escape.
4654         * source-cache.c (source_cache::get_source_lines): Likewise.
4655         * stack.c (frame_apply_command_count): Call execute_command_to_string
4656         passing the term_out characteristic of the current gdb_stdout.
4657         * thread.c (thr_try_catch_cmd): Likewise.
4658         * top.c (execute_command_to_string): pass term_out parameter
4659         to construct the string_file for the command output.
4660         * ui-file.c (term_cli_styling): New function (most code moved
4661         from utils.c can_emit_style_escape).
4662         (string_file::string_file, string_file::can_emit_style_escape,
4663         stdio_file::can_emit_style_escape, tee_file::term_out,
4664         tee_file::can_emit_style_escape): New functions.
4665
4666 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4667
4668         * NEWS: Mention the new set|show may-call-functions.
4669         * infcall.c (may_call_functions_p): New variable.
4670         (show_may_call_functions_p): New function.
4671         (call_function_by_hand_dummy): Throws an error if not
4672         may-call-functions.
4673         (_initialize_infcall): Call add_setshow_boolean_cmd for
4674         may-call-functions.
4675
4676 2019-04-25  Keith Seitz  <keiths@redhat.com>
4677
4678         PR c++/24367
4679         * cp-support.c (inspect_type): Don't attempt substitutions
4680         of symbol with the same name.
4681
4682 2019-04-25  Tom Tromey  <tromey@adacore.com>
4683
4684         PR gdb/24475:
4685         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4686         static.
4687
4688 2019-04-25  Tom Tromey  <tromey@adacore.com>
4689
4690         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4691         rvalue reference.
4692         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4693         (gdb_xml_parser::parse): Use std::move.
4694         * python/python-internal.h (gdbpy_convert_exception): Take a const
4695         reference.
4696         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4697         std::move.
4698         * python/py-utils.c (gdbpy_convert_exception): Take a const
4699         reference.
4700         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4701         Use std::move.
4702         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4703         Use std::move.
4704         * mi/mi-main.c (mi_print_exception): Take a const reference.
4705         * main.c (handle_command_errors): Take a const reference.
4706         * linespec.c (parse_linespec): Use std::move.
4707         * infcall.c (run_inferior_call): Use std::move.
4708         (call_function_by_hand_dummy): Use std::move.
4709         * exec.c (try_open_exec_file): Use std::move.
4710         * exceptions.h (exception_print, exception_fprintf)
4711         (exception_print_same): Update.
4712         * exceptions.c (print_exception, exception_print)
4713         (exception_fprintf, exception_print_same): Change parameters to
4714         const reference.
4715         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4716         * common/new-op.c: Use std::move.
4717         * common/common-exceptions.h (struct gdb_exception): Add move
4718         constructor.
4719         (struct gdb_exception_error, struct gdb_exception_quit, struct
4720         gdb_quit_bad_alloc): Change constructor to move constructor.
4721         (throw_exception): Change parameter to rvalue reference.
4722         * common/common-exceptions.c (throw_exception): Take rvalue
4723         reference.
4724         * cli/cli-interp.c (safe_execute_command): Use std::move.
4725         * breakpoint.c (insert_bp_location, location_to_sals): Use
4726         std::move.
4727
4728 2019-04-25  Tom Tromey  <tromey@adacore.com>
4729
4730         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4731         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4732         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4733         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4734         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4735         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4736         guile/scm-value.c: Use unpack.
4737         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4738         gdbscm_gdb_exception.
4739         (gdbscm_throw_gdb_exception): Likewise.
4740         (struct gdbscm_gdb_exception): New.
4741         (unpack): New function.
4742         (gdbscm_wrap): Use unpack.
4743
4744 2019-04-25  Tom Tromey  <tromey@adacore.com>
4745
4746         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4747         (gdb_rl_callback_handler): Use std::move.
4748         * common/common-exceptions.h (struct gdb_exception): Add move
4749         assignment operator.
4750         (throw_exception_sjlj): Change "exception" to const reference.
4751         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4752         (throw_exception_sjlj): Change "exception" to const reference.
4753
4754 2019-04-25  Tom Tromey  <tromey@adacore.com>
4755
4756         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4757         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4758         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4759         Update.
4760         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4761         Update.
4762         * mi/mi-interp.c (mi_interp::exec): Update.
4763         * linespec.c (parse_linespec): Update.
4764         * infcall.c (run_inferior_call): Update.
4765         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4766         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4767         (gdbscm_lookup_global_symbol): Update.
4768         * guile/scm-param.c (gdbscm_parameter_value): Update.
4769         * guile/scm-frame.c (gdbscm_frame_read_register)
4770         (gdbscm_frame_read_var): Update.
4771         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4772         * exec.c (try_open_exec_file): Update.
4773         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4774         (gdb_rl_callback_handler): Update.
4775         * common/common-exceptions.h (exception_none): Don't declare.
4776         * common/common-exceptions.c (exception_none): Don't define.
4777         (struct catcher) <exception>: Update.
4778         * cli/cli-interp.c (safe_execute_command): Update.
4779         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4780
4781 2019-04-25  Ali Tamur  <tamur@google.com>
4782
4783         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4784         (read_attribute_value): Likewise.
4785         (dwarf2_read_addr_index): Update comment.
4786         (read_str_index): Add DW_FORM_strx.
4787         (dwarf2_string_attr): Likewise.
4788         (dwarf2_const_value_attr): Likewise.
4789         (dump_die_shallow): Likewise.
4790         (dwarf2_fetch_constant_bytes): Likewise.
4791         (skip_form_bytes): Likewise.
4792         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4793
4794 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4795
4796         PR corefiles/11608
4797         PR corefiles/18187
4798         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4799         OFFSET.  Verify if current mapping contains an ELF header.
4800         (linux_find_memory_regions_full): Adjust call to
4801         dump_mapping_p.
4802
4803 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4804             Kang Li <kanglictf@gmail.com>
4805
4806         PR gdb/21600
4807
4808         * dwarf2-frame.c (read_initial_length): Be consistent about using
4809         unsigned representation of length.
4810         (decode_frame_entry_1): Likewise.  Check for wraparound of
4811         end pointer as well as buffer overflow.
4812
4813 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4814
4815         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4816         "vq".
4817
4818 2019-04-24  Tom Tromey  <tromey@adacore.com>
4819
4820         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4821
4822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * s12z-tdep.c (s12z_unwind_pc): Delete.
4825         (s12z_unwind_sp): Delete.
4826         (s12z_gdbarch_init): Don't register deleted functions with
4827         gdbarch.
4828
4829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4830
4831         * rl78-tdep.c (rl78_unwind_sp): Delete.
4832         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4833
4834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4837         (xstormy16_unwind_pc): Delete.
4838         (xstormy16_dummy_id): Delete.
4839         (xstormy16_gdbarch_init): Don't register deleted functions with
4840         gdbarch.
4841
4842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4843
4844         * vax-tdep.c (vax_unwind_pc): Delete.
4845         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4846
4847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4848
4849         * v850-tdep.c (v850_unwind_sp): Delete.
4850         (v850_unwind_pc): Delete.
4851         (v850_dummy_id): Delete.
4852         (v850_gdbarch_init): Don't register deleted functions with
4853         gdbarch.
4854
4855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4856
4857         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4858         (tilegx_unwind_pc): Delete.
4859         (tilegx_unwind_dummy_id): Delete.
4860         (tilegx_gdbarch_init): Don't register deleted functions with
4861         gdbarch.
4862
4863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4864
4865         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4866         (tic6x_dummy_id): Delete.
4867         (tic6x_gdbarch_init): Don't register deleted functions with
4868         gdbarch.
4869
4870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4871
4872         * sparc-tdep.c (sparc_unwind_pc): Delete.
4873         (sparc32_gdbarch_init): Don't register deleted function with
4874         gdbarch.
4875
4876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4877
4878         * sh-tdep.c (sh_unwind_sp): Delete.
4879         (sh_unwind_pc): Delete.
4880         (sh_dummy_id): Delete.
4881         (sh_gdbarch_init): Don't register deleted functions with
4882         gdbarch.
4883
4884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * score-tdep.c (score_unwind_sp): Delete.
4887         (score_unwind_pc): Delete.
4888         (score_dummy_id): Delete.
4889         (score_gdbarch_init): Don't register deleted functions with
4890         gdbarch.
4891
4892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * rx-tdep.c (rx_unwind_pc): Delete.
4895         (rx_unwind_sp): Delete.
4896         (rx_dummy_id): Delete.
4897         (rx_gdbarch_init): Don't register deleted functions with
4898         gdbarch.  Update comment.
4899
4900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4901
4902         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4903         (rs6000_dummy_id): Delete.
4904         (rs6000_gdbarch_init): Don't register deleted functions with
4905         gdbarch.
4906
4907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * or1k-tdep.c (or1k_dummy_id): Delete.
4910         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4911
4912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4913
4914         * nios2-tdep.c (nios2_dummy_id): Delete.
4915         (nios2_unwind_sp): Delete.
4916         (nios2_gdbarch_init): Don't register deleted functions with
4917         gdbarch.
4918
4919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4920
4921         * nds32-tdep.c (nds32_dummy_id): Delete.
4922         (nds32_unwind_pc): Delete.
4923         (nds32_unwind_sp): Delete.
4924         (nds32_gdbarch_init): Don't register deleted functions with
4925         gdbarch.
4926
4927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * msp430-tdep.c (msp430_unwind_pc): Delete.
4930         (msp430_unwind_sp): Delete.
4931         (msp430_dummy_id): Delete.
4932         (msp430_gdbarch_init): Don't register deleted functions with
4933         gdbarch.
4934
4935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4936
4937         * moxie-tdep.c (moxie_unwind_sp): Delete.
4938         (moxie_unwind_pc): Delete.
4939         (moxie_dummy_id): Delete.
4940         (moxie_gdbarch_init): Don't register deleted functions with
4941         gdbarch.
4942
4943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4944
4945         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4946         (mn10300_unwind_pc): Delete.
4947         (mn10300_unwind_sp): Delete.
4948         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4949         mn10300_unwind_sp.
4950         (mn10300_frame_unwind_init): Don't register deleted functions with
4951         gdbarch.
4952
4953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4954
4955         * mep-tdep.c (mep_unwind_pc): Delete.
4956         (mep_unwind_sp): Delete.
4957         (mep_dummy_id): Delete.
4958         (mep_gdbarch_init): Don't register deleted functions with
4959         gdbarch.
4960
4961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4962
4963         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4964         (m68hc11_unwind_sp): Delete.
4965         (m68hc11_gdbarch_init): Don't register deleted functions with
4966         gdbarch.
4967
4968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * m32r-tdep.c (m32r_unwind_sp): Delete.
4971         (m32r_unwind_pc): Delete.
4972         (m32r_dummy_id): Delete.
4973         (m32r_gdbarch_init): Don't register deleted functions with
4974         gdbarch.
4975
4976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4977
4978         * m32c-tdep.c (m32c_unwind_pc): Delete.
4979         (m32c_unwind_sp): Delete.
4980         (m32c_dummy_id): Delete.
4981         (m32c_gdbarch_init): Don't register deleted functions with
4982         gdbarch.
4983
4984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4985
4986         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4987         (lm32_unwind_pc): Delete.
4988         (lm32_dummy_id): Delete.
4989         (lm32_gdbarch_init): Don't register deleted functions with
4990         gdbarch.
4991
4992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4995         (iq2000_unwind_pc): Delete.
4996         (iq2000_dummy_id): Delete.
4997         (iq2000_gdbarch_init): Don't register deleted functions with
4998         gdbarch.
4999
5000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * nds32-tdep.c (nds32_type_align): Delete.
5003         (nds32_push_dummy_call): Use type_align instead.
5004
5005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5006
5007         * arm-tdep.c (arm_type_align): Only handle vector override case.
5008         (arm_push_dummy_call): Use type_align.
5009         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5010
5011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5012
5013         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5014         case.
5015         (pass_on_stack): Use type_align.
5016         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5017         function.
5018
5019 2019-04-23  Tom Tromey  <tromey@adacore.com>
5020
5021         * dwarf2read.c (line_header::file_name_at): Remove unused
5022         overload.
5023
5024 2019-04-23  Tom de Vries  <tdevries@suse.de>
5025
5026         PR gdb/24438
5027         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5028         invocation.
5029
5030
5031 2019-03-27  Ali Tamur  <tamur@google.com>
5032
5033         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5034         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5035         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5036         (dwarf_expr_context::get_addr_index): Likewise
5037         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5038         (symbol_needs_eval_context::get_addr_index): Likewise
5039         (disassemble_dwarf_expression): Add DW_OP_addrx
5040         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5041         (read_cutu_die_from_dwo): Update comment
5042         (skip_one_die): Add DW_FORM_addrx
5043         (read_attribute_value): Likewise
5044         (var_decode_location): Add DW_OP_addrx
5045         (dwarf2_const_value_attr): Add DW_FORM_addrx
5046         (dump_die_shallow): Likewise
5047         (dwarf2_fetch_constant_bytes): Likewise
5048         (decode_locdesc): Add DW_OP_addrx
5049         (skip_form_bytes): Add DW_FORM_addrx
5050
5051 2019-04-22  Ali Tamur  <tamur@google.com>
5052
5053         * MAINTAINERS (Write After Approval): Add self.
5054
5055 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5056
5057         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5058         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5059         (open_symbol_file_object): Likewise.
5060         (svr4_default_sos): Add info parameter.
5061         (svr4_read_so_list): Likewise.
5062         (svr4_current_sos_direct): Adjust functions calls to pass down
5063         info.
5064         (svr4_current_sos_1): Add info parameter.
5065         (svr4_current_sos): Call get_svr4_info, pass info down to
5066         svr4_current_sos_1.
5067         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5068         get_svr4_info.
5069         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5070         get_svr4_info.
5071         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5072         to get_svr4_info.
5073         (probes_table_remove_objfile_probes): Likewise.
5074         (register_solib_event_probe): Add info parameter.
5075         (solist_update_incremental): Pass info parameter down to
5076         svr4_read_so_list.
5077         (disable_probes_interface): Add info parameter.
5078         (svr4_handle_solib_event): Pass current_program_space to
5079         get_svr4_info.  Adjust disable_probes_interface cleanup.
5080         (svr4_create_probe_breakpoints): Add info parameter, pass it
5081         down to register_solib_event_probe.
5082         (svr4_create_solib_event_breakpoints): Add info parameter,
5083         pass it down to svr4_create_probe_breakpoints.
5084         (enable_break): Pass info down to
5085         svr4_create_solib_event_breakpoints.
5086         (svr4_solib_create_inferior_hook): Pass current_program_space to
5087         get_svr4_info.
5088         (svr4_clear_solib): Likewise.
5089
5090 2019-04-22  Pedro Alves  <palves@redhat.com>
5091
5092         * solib-svr4.c (svr4_free_objfile_observer): New.
5093         (probe_and_action::objfile): New field.
5094         (probes_table_htab_remove_objfile_probes)
5095         (probes_table_remove_objfile_probes): New functions.
5096         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5097         in the new probe_and_action.  Don't store the probe in 'lookup'.
5098         (svr4_create_probe_breakpoints): Pass objfile to
5099         register_solib_event_probe.
5100         (_initialize_svr4_solib): Register a free_objfile observer.
5101
5102 2019-04-19  Tom Tromey  <tom@tromey.com>
5103
5104         * common/queue.h: Remove.
5105
5106 2019-04-19  Tom Tromey  <tom@tromey.com>
5107
5108         * event-loop.c: Don't include "common/queue.h".
5109
5110 2019-04-19  Tom Tromey  <tom@tromey.com>
5111
5112         * remote.c (remote_target): Use delete.
5113         * remote-notif.h: Include <list>, not "common/queue.h".
5114         (notif_client_p): Remove typedef.
5115         (remote_notif_state): Add constructor, destructor, initializer.
5116         <notif_queue>: Now a std::list.
5117         (remote_notif_state_xfree): Don't declare.
5118         * remote-notif.c (remote_notif_process, handle_notification)
5119         (remote_notif_state_allocate): Update.
5120         (~remote_notif_state): Rename from remote_notif_state_xfree.
5121
5122 2019-04-19  Tom Tromey  <tom@tromey.com>
5123
5124         * symfile.c (reread_symbols): Update.
5125         * objfiles.c (objfile_register_static_link)
5126         (objfile_lookup_static_link): Update
5127         (~objfile) Don't delete static_links.
5128         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5129
5130 2019-04-19  Tom Tromey  <tom@tromey.com>
5131
5132         * type-stack.h (struct type_stack) <insert>: Constify string.
5133         * type-stack.c (type_stack::insert): Constify string.
5134         * gdbtypes.h (lookup_template_type): Update.
5135         (address_space_name_to_int): Update.
5136         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5137         const.
5138         (lookup_template_type): Make name const.
5139         * c-exp.y: Update rules.
5140         (lex_one_token, classify_name, classify_inner_name)
5141         (c_print_token): Update.
5142         * p-exp.y: Update rules.
5143         (yylex): Update.
5144         * f-exp.y: Update rules.
5145         (yylex): Update.
5146         * d-exp.y: Update rules.
5147         (lex_one_token, classify_name, classify_inner_name): Update.
5148         * parse.c (write_dollar_variable, copy_name): Return std::string.
5149         * parser-defs.h (copy_name): Change return type.
5150         * m2-exp.y: Update rules.
5151         (yylex): Update.
5152         * go-exp.y (lex_one_token): Update.
5153         Update rules.
5154         (classify_unsafe_function, classify_packaged_name)
5155         (classify_name, yylex): Update.
5156
5157 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5158
5159         * configure.ac: add --enable-source-highlight switch.
5160         * configure: Regenerate.
5161         * top.c (print_gdb_version): plumb --enable-source-highlight
5162         status to "show configuration".
5163
5164 2019-04-19  Tom Tromey  <tromey@adacore.com>
5165
5166         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5167         Check ADA_TYPE_P.
5168         (empty_record, ada_template_to_fixed_record_type_1)
5169         (template_to_static_fixed_type)
5170         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5171         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5172         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5173         macros.
5174
5175 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5176
5177         PR symtab/24423:
5178         * source.c (print_source_lines_base): Advance "iter" when a
5179         control character is seen.
5180
5181 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5182
5183         * inferior.h (struct infcall_suspend_state_deleter):
5184         Catch exception in destructor to avoid crash.
5185
5186 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5187
5188         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5189         close to the add_com "shell".
5190
5191 2019-04-18  Tom Tromey  <tromey@adacore.com>
5192
5193         * process-stratum-target.h (class process_stratum_target)
5194         <stratum>: Add "final".
5195
5196 2019-04-17  Tom Tromey  <tromey@adacore.com>
5197
5198         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5199         against nullptr before use.
5200
5201 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5202
5203         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5204
5205 2019-04-17  Jim Wilson  <jimw@sifive.com>
5206             Andrew Burgess  <andrew.burgess@embecosm.com>
5207
5208         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5209         code read might fail, assume 4-byte breakpoint in that case.
5210
5211 2019-04-15  Leszek Swirski  <leszeks@google.com>
5212
5213         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5214         rather than a hand-rolled POD check when checking for forced MEMORY
5215         classification.
5216
5217 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5218
5219         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5220         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5221         function.
5222         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5223         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5224         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5225         declaration.
5226
5227 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5228
5229         * aarch64-linux-nat.c
5230         (aarch64_linux_nat_target::thread_architecture): Add override.
5231         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5232         each VQ.
5233
5234 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5235
5236         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5237
5238 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5239
5240         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5241         target types of size 96-bits, add some additional comments, and
5242         check that the builtin type we found was the correct size.
5243
5244 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5245
5246         * utils.c (prompt_for_continue): Don't restore the styling at the
5247         end, as applied_style has the wrong value.  This fixes styling in
5248         long lists of file names that are interrupted by the "Continue?"
5249         prompt.
5250
5251 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5254         * c-lang.c (c_language_defn): Likewise.
5255         (cplus_language_defn): Likewise.
5256         (asm_language_defn): Likewise.
5257         (minimal_language_defn): Likewise.
5258         * d-lang.c (d_language_defn): Likewise.
5259         * f-lang.c (f_language_defn): Likewise.
5260         * go-lang.c (go_language_defn): Likewise.
5261         * language.c (unknown_language_defn): Likewise.
5262         (auto_language_defn): Likewise.
5263         * language.h (struct language_defn): Remove la_magic field.
5264         (LANG_MAGIC): Delete.
5265         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5266         * objc-lang.c (objc_language_defn): Likewise.
5267         * opencl-lang.c (opencl_language_defn): Likewise.
5268         * p-lang.c (pascal_language_defn): Likewise.
5269         * rust-lang.c (rust_language_defn): Likewise.
5270
5271 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5272
5273         * riscv-tdep.c (riscv_type_align): New function.
5274         (riscv_type_alignment): Delete.
5275         (riscv_arg_location): Use 'type_align'.
5276         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5277
5278 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5279
5280         * gdbtypes.c (type_align): A struct with no non-static fields also
5281         has alignment of 1.
5282
5283 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5284
5285         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5286         component to 0.
5287         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5288         member.
5289         (riscv_struct_info::analyse): New implementation using new
5290         analyse_inner member function.
5291         (riscv_struct_info::field_offset): New member function.
5292         (riscv_struct_info::m_offsets): New member variable.
5293         (riscv_struct_info::analyse_inner): New private member function,
5294         takes the old implementation of riscv_struct_info::analyse but
5295         extended to track field offsets.
5296         (riscv_call_arg_struct): Update the struct folding special cases
5297         to handle cases where empty C++ structs, which are non-zero
5298         length, are found.
5299         (riscv_arg_location): Initialise the length of each location, a
5300         non-zero length now indicates the location is in use.
5301         (riscv_push_dummy_call): Allow for the first location having a
5302         non-zero offset when setting up arguments.
5303         (riscv_return_value): Likewise, but for return values.
5304
5305 2019-04-11  Tom Tromey  <tromey@adacore.com>
5306
5307         * utils.c (internal_vproblem): Make "msg" const.
5308
5309 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5310
5311         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5312         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5313         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5314         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5315
5316 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5317
5318         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5319         function.
5320         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5321         of amd64_collect_native_gregset.
5322         (amd64_linux_nat_target::store_registers): Likewise.
5323
5324 2019-04-10  Tom Tromey  <tom@tromey.com>
5325
5326         * symtab.c (lookup_global_symbol_from_objfile)
5327         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5328         * objfiles.h (class separate_debug_iterator): New.
5329         (class separate_debug_range): New.
5330         (struct objfile) <separate_debug_objfiles>: New method.
5331         (objfile_separate_debug_iterate): Don't declare.
5332         * objfiles.c (separate_debug_iterator::operator++): Rename from
5333         objfile_separate_debug_iterate.
5334         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5335         iterator.
5336         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5337         iterator.
5338
5339 2019-04-10  Tom Tromey  <tom@tromey.com>
5340
5341         * symfile.c (reread_symbols): Remove old comment.
5342         * objfiles.c (free_all_objfiles): Fix a typo.
5343
5344 2019-04-10  Tom Tromey  <tom@tromey.com>
5345
5346         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5347         * minsyms.c (lookup_minimal_symbol): Use foreach.
5348         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5349         (lookup_minimal_symbol_solib_trampoline): Likewise.
5350         * symfile.c (reread_symbols): Use foreach.
5351
5352 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5353             Tom Tromey  <tromey@adacore.com>
5354
5355         PR rust/24414:
5356         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5357         (rust_lex_int_test): Change "value" to be LONGEST.
5358         (rust_lex_tests): Add test for long integer literal.
5359
5360 2019-04-09  Tom Tromey  <tromey@adacore.com>
5361
5362         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5363         to bool.
5364         (extended_remote_target::attach): Update.
5365         (remote_target::remote_notice_new_inferior): Update.
5366         (remote_target::add_current_inferior_and_thread): Update.
5367         * inferior.c (exit_inferior_1): Use "false".
5368         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5369
5370 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5371
5372         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5373         the "start" command.
5374
5375 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5376
5377         * python/py-inferior.c (infpy_thread_from_thread_handle):
5378         Adjust comments to reflect renaming of thread_from_thread_handle
5379         to thread_from_handle.  Adjust keywords.  Fix type error message.
5380         (inferior_object_methods): Add thread_from_handle.  Retain
5381         thread_from_thread_handle, but mark it as deprecated.
5382
5383 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5384
5385         * gdbthread.h (find_thread_by_handle): Revise declaration.
5386         * thread.c (find_thread_by_handle): Likewise.  Adjust
5387         implementation too.
5388         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5389         support for buffer objects as handles.
5390
5391 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5392
5393         * python/py-infthread.c (thpy_thread_handle): New function.
5394         (thread_object_methods): Register thpy_thread_handle.
5395
5396 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5397
5398         * gdbthread.h (thread_to_thread_handle): Declare.
5399         * thread.c (gdbtypes.h): Include.
5400         (thread_to_thread_handle): New function.
5401
5402         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5403         (target_thread_info_to_thread_handle): Declare.
5404         * target.c (target_thread_info_to_thread_handle): New function.
5405         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5406         * target-delegates.c: Regenerate.
5407
5408         * linux-thread-db.c (class thread_db_target): Add method
5409         thread_info_to_thread_handle.
5410         (thread_db_target::thread_info_to_thread_handle): Define.
5411         * remote.c (class remote_target): Add new method
5412         thread_info_to_thread_handle.
5413         (remote_target::thread_info_to_thread_handle): Define.
5414
5415 2019-04-08  Pedro Alves  <palves@redhat.com>
5416
5417         * common/common-exceptions.c (throw_exception): Don't create
5418         named object to throw; throw directly.
5419         (throw_it): Likewise.  Don't initialize gdb_exception::message
5420         here, with new; pass FMT and AP to the ctor instead.
5421         * common/common-exceptions.h: Include <string>.
5422         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5423         const char *, va_list)): New ctor.  Use std::make_shared.
5424         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5425         errors)): Delete.
5426         (gdb_exception_error::gdb_exception_error(enum errors, const char
5427         *, va_list)): New.
5428         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5429         Add assertion.
5430         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5431         errors)): Delete.
5432         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5433         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5434         Add assertion.
5435
5436 2019-04-08  Tom Tromey  <tom@tromey.com>
5437
5438         * valops.c (value_rtti_indirect_type): Replace throw_exception
5439         with throw.
5440         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5441         with throw.
5442         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5443         throw.
5444         * target.c (target_translate_tls_address): Replace throw_exception
5445         with throw.
5446         * stack.c (frame_apply_command_count): Replace throw_exception
5447         with throw.
5448         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5449         throw.
5450         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5451         with throw.
5452         * rs6000-tdep.c (rs6000_frame_cache)
5453         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5454         * remote.c: Replace throw_exception with throw.
5455         * record-full.c (record_full_message, record_full_wait_1)
5456         (record_full_restore): Replace throw_exception with throw.
5457         * record-btrace.c:
5458         (get_thread_current_frame_id, record_btrace_start_replaying)
5459         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5460         (cmd_record_btrace_start): Replace throw_exception with throw.
5461         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5462         throw.
5463         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5464         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5465         * linespec.c:
5466         (find_linespec_symbols): Replace throw_exception with throw.
5467         * infrun.c (displaced_step_prepare, resume): Replace
5468         throw_exception with throw.
5469         * infcmd.c (post_create_inferior): Replace throw_exception with
5470         throw.
5471         * inf-loop.c (inferior_event_handler): Replace throw_exception
5472         with throw.
5473         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5474         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5475         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5476         (get_prev_frame_always, get_frame_pc_if_available)
5477         (get_frame_address_in_block_if_available, get_frame_language):
5478         Replace throw_exception with throw.
5479         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5480         throw_exception with throw.
5481         * eval.c (fetch_subexp_value, evaluate_var_value)
5482         (evaluate_funcall, evaluate_subexp_standard): Replace
5483         throw_exception with throw.
5484         * dwarf2loc.c (call_site_find_chain)
5485         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5486         Replace throw_exception with throw.
5487         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5488         with throw.
5489         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5490         throw.
5491         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5492         * completer.c (complete_line_internal): Replace throw_exception
5493         with throw.
5494         * compile/compile-object-run.c (compile_object_run): Replace
5495         throw_exception with throw.
5496         * cli/cli-script.c (process_next_line): Replace throw_exception
5497         with throw.
5498         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5499         (btrace_enable, btrace_maint_update_pt_packets): Replace
5500         throw_exception with throw.
5501         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5502         throw_exception with throw.
5503         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5504         throw_exception with throw.
5505         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5506         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5507         * aarch64-tdep.c (aarch64_make_prologue_cache)
5508         (aarch64_make_stub_cache): Replace throw_exception with throw.
5509
5510 2019-04-08  Tom Tromey  <tom@tromey.com>
5511
5512         * common/common-exceptions.c (throw_exception): Rename from
5513         throw_exception_cxx.  Remove old copy.  Make argument const.
5514         (throw_it): Create and throw exception objects directly.
5515         * common/common-exceptions.h (throw_exception): Make argument
5516         const.
5517         (struct gdb_exception_error): Add constructor.
5518         (struct gdb_exception_quit): Add constructor.
5519
5520 2019-04-08  Tom Tromey  <tom@tromey.com>
5521
5522         * common/common-exceptions.h (exception_rethrow): Don't declare.
5523         (TRY_SJLJ): Update comment.
5524         (TRY, CATCH, END_CATCH): Remove.
5525         * common/common-exceptions.c (exception_rethrow): Remove.
5526
5527 2019-04-08  Tom Tromey  <tom@tromey.com>
5528
5529         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5530         Remove.
5531         (gdb_exception_error): Rename from
5532         gdb_exception_RETURN_MASK_ERROR.
5533         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5534         (gdb_quit_bad_alloc): Update.
5535         * aarch64-tdep.c: Update.
5536         * ada-lang.c: Update.
5537         * ada-typeprint.c: Update.
5538         * ada-valprint.c: Update.
5539         * amd64-tdep.c: Update.
5540         * arch-utils.c: Update.
5541         * break-catch-throw.c: Update.
5542         * breakpoint.c: Update.
5543         * btrace.c: Update.
5544         * c-varobj.c: Update.
5545         * cli/cli-cmds.c: Update.
5546         * cli/cli-interp.c: Update.
5547         * cli/cli-script.c: Update.
5548         * common/common-exceptions.c: Update.
5549         * common/new-op.c: Update.
5550         * common/selftest.c: Update.
5551         * compile/compile-c-symbols.c: Update.
5552         * compile/compile-cplus-symbols.c: Update.
5553         * compile/compile-object-load.c: Update.
5554         * compile/compile-object-run.c: Update.
5555         * completer.c: Update.
5556         * corelow.c: Update.
5557         * cp-abi.c: Update.
5558         * cp-support.c: Update.
5559         * cp-valprint.c: Update.
5560         * darwin-nat.c: Update.
5561         * disasm-selftests.c: Update.
5562         * dtrace-probe.c: Update.
5563         * dwarf-index-cache.c: Update.
5564         * dwarf-index-write.c: Update.
5565         * dwarf2-frame-tailcall.c: Update.
5566         * dwarf2-frame.c: Update.
5567         * dwarf2loc.c: Update.
5568         * dwarf2read.c: Update.
5569         * eval.c: Update.
5570         * event-loop.c: Update.
5571         * event-top.c: Update.
5572         * exec.c: Update.
5573         * f-valprint.c: Update.
5574         * fbsd-tdep.c: Update.
5575         * frame-unwind.c: Update.
5576         * frame.c: Update.
5577         * gdbtypes.c: Update.
5578         * gnu-v3-abi.c: Update.
5579         * guile/guile-internal.h: Update.
5580         * guile/scm-block.c: Update.
5581         * guile/scm-breakpoint.c: Update.
5582         * guile/scm-cmd.c: Update.
5583         * guile/scm-disasm.c: Update.
5584         * guile/scm-frame.c: Update.
5585         * guile/scm-lazy-string.c: Update.
5586         * guile/scm-math.c: Update.
5587         * guile/scm-param.c: Update.
5588         * guile/scm-ports.c: Update.
5589         * guile/scm-pretty-print.c: Update.
5590         * guile/scm-symbol.c: Update.
5591         * guile/scm-symtab.c: Update.
5592         * guile/scm-type.c: Update.
5593         * guile/scm-value.c: Update.
5594         * i386-linux-tdep.c: Update.
5595         * i386-tdep.c: Update.
5596         * inf-loop.c: Update.
5597         * infcall.c: Update.
5598         * infcmd.c: Update.
5599         * infrun.c: Update.
5600         * jit.c: Update.
5601         * language.c: Update.
5602         * linespec.c: Update.
5603         * linux-fork.c: Update.
5604         * linux-nat.c: Update.
5605         * linux-tdep.c: Update.
5606         * linux-thread-db.c: Update.
5607         * main.c: Update.
5608         * mi/mi-cmd-break.c: Update.
5609         * mi/mi-cmd-stack.c: Update.
5610         * mi/mi-interp.c: Update.
5611         * mi/mi-main.c: Update.
5612         * objc-lang.c: Update.
5613         * p-valprint.c: Update.
5614         * parse.c: Update.
5615         * ppc-linux-tdep.c: Update.
5616         * printcmd.c: Update.
5617         * python/py-arch.c: Update.
5618         * python/py-breakpoint.c: Update.
5619         * python/py-cmd.c: Update.
5620         * python/py-finishbreakpoint.c: Update.
5621         * python/py-frame.c: Update.
5622         * python/py-framefilter.c: Update.
5623         * python/py-gdb-readline.c: Update.
5624         * python/py-inferior.c: Update.
5625         * python/py-infthread.c: Update.
5626         * python/py-lazy-string.c: Update.
5627         * python/py-linetable.c: Update.
5628         * python/py-objfile.c: Update.
5629         * python/py-param.c: Update.
5630         * python/py-prettyprint.c: Update.
5631         * python/py-progspace.c: Update.
5632         * python/py-record-btrace.c: Update.
5633         * python/py-record.c: Update.
5634         * python/py-symbol.c: Update.
5635         * python/py-type.c: Update.
5636         * python/py-unwind.c: Update.
5637         * python/py-utils.c: Update.
5638         * python/py-value.c: Update.
5639         * python/python.c: Update.
5640         * record-btrace.c: Update.
5641         * record-full.c: Update.
5642         * remote-fileio.c: Update.
5643         * remote.c: Update.
5644         * riscv-tdep.c: Update.
5645         * rs6000-aix-tdep.c: Update.
5646         * rs6000-tdep.c: Update.
5647         * rust-exp.y: Update.
5648         * rust-lang.c: Update.
5649         * s390-tdep.c: Update.
5650         * selftest-arch.c: Update.
5651         * solib-dsbt.c: Update.
5652         * solib-frv.c: Update.
5653         * solib-spu.c: Update.
5654         * solib-svr4.c: Update.
5655         * solib.c: Update.
5656         * sparc64-linux-tdep.c: Update.
5657         * stack.c: Update.
5658         * symfile-mem.c: Update.
5659         * symmisc.c: Update.
5660         * target.c: Update.
5661         * thread.c: Update.
5662         * top.c: Update.
5663         * tracefile-tfile.c: Update.
5664         * tui/tui.c: Update.
5665         * typeprint.c: Update.
5666         * unittests/cli-utils-selftests.c: Update.
5667         * unittests/parse-connection-spec-selftests.c: Update.
5668         * valops.c: Update.
5669         * valprint.c: Update.
5670         * value.c: Update.
5671         * varobj.c: Update.
5672         * windows-nat.c: Update.
5673         * x86-linux-nat.c: Update.
5674         * xml-support.c: Update.
5675
5676 2019-04-08  Tom Tromey  <tom@tromey.com>
5677
5678         * xml-support.c: Use C++ exception handling.
5679         * x86-linux-nat.c: Use C++ exception handling.
5680         * windows-nat.c: Use C++ exception handling.
5681         * varobj.c: Use C++ exception handling.
5682         * value.c: Use C++ exception handling.
5683         * valprint.c: Use C++ exception handling.
5684         * valops.c: Use C++ exception handling.
5685         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5686         handling.
5687         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5688         * typeprint.c: Use C++ exception handling.
5689         * tui/tui.c: Use C++ exception handling.
5690         * tracefile-tfile.c: Use C++ exception handling.
5691         * top.c: Use C++ exception handling.
5692         * thread.c: Use C++ exception handling.
5693         * target.c: Use C++ exception handling.
5694         * symmisc.c: Use C++ exception handling.
5695         * symfile-mem.c: Use C++ exception handling.
5696         * stack.c: Use C++ exception handling.
5697         * sparc64-linux-tdep.c: Use C++ exception handling.
5698         * solib.c: Use C++ exception handling.
5699         * solib-svr4.c: Use C++ exception handling.
5700         * solib-spu.c: Use C++ exception handling.
5701         * solib-frv.c: Use C++ exception handling.
5702         * solib-dsbt.c: Use C++ exception handling.
5703         * selftest-arch.c: Use C++ exception handling.
5704         * s390-tdep.c: Use C++ exception handling.
5705         * rust-lang.c: Use C++ exception handling.
5706         * rust-exp.y: Use C++ exception handling.
5707         * rs6000-tdep.c: Use C++ exception handling.
5708         * rs6000-aix-tdep.c: Use C++ exception handling.
5709         * riscv-tdep.c: Use C++ exception handling.
5710         * remote.c: Use C++ exception handling.
5711         * remote-fileio.c: Use C++ exception handling.
5712         * record-full.c: Use C++ exception handling.
5713         * record-btrace.c: Use C++ exception handling.
5714         * python/python.c: Use C++ exception handling.
5715         * python/py-value.c: Use C++ exception handling.
5716         * python/py-utils.c: Use C++ exception handling.
5717         * python/py-unwind.c: Use C++ exception handling.
5718         * python/py-type.c: Use C++ exception handling.
5719         * python/py-symbol.c: Use C++ exception handling.
5720         * python/py-record.c: Use C++ exception handling.
5721         * python/py-record-btrace.c: Use C++ exception handling.
5722         * python/py-progspace.c: Use C++ exception handling.
5723         * python/py-prettyprint.c: Use C++ exception handling.
5724         * python/py-param.c: Use C++ exception handling.
5725         * python/py-objfile.c: Use C++ exception handling.
5726         * python/py-linetable.c: Use C++ exception handling.
5727         * python/py-lazy-string.c: Use C++ exception handling.
5728         * python/py-infthread.c: Use C++ exception handling.
5729         * python/py-inferior.c: Use C++ exception handling.
5730         * python/py-gdb-readline.c: Use C++ exception handling.
5731         * python/py-framefilter.c: Use C++ exception handling.
5732         * python/py-frame.c: Use C++ exception handling.
5733         * python/py-finishbreakpoint.c: Use C++ exception handling.
5734         * python/py-cmd.c: Use C++ exception handling.
5735         * python/py-breakpoint.c: Use C++ exception handling.
5736         * python/py-arch.c: Use C++ exception handling.
5737         * printcmd.c: Use C++ exception handling.
5738         * ppc-linux-tdep.c: Use C++ exception handling.
5739         * parse.c: Use C++ exception handling.
5740         * p-valprint.c: Use C++ exception handling.
5741         * objc-lang.c: Use C++ exception handling.
5742         * mi/mi-main.c: Use C++ exception handling.
5743         * mi/mi-interp.c: Use C++ exception handling.
5744         * mi/mi-cmd-stack.c: Use C++ exception handling.
5745         * mi/mi-cmd-break.c: Use C++ exception handling.
5746         * main.c: Use C++ exception handling.
5747         * linux-thread-db.c: Use C++ exception handling.
5748         * linux-tdep.c: Use C++ exception handling.
5749         * linux-nat.c: Use C++ exception handling.
5750         * linux-fork.c: Use C++ exception handling.
5751         * linespec.c: Use C++ exception handling.
5752         * language.c: Use C++ exception handling.
5753         * jit.c: Use C++ exception handling.
5754         * infrun.c: Use C++ exception handling.
5755         * infcmd.c: Use C++ exception handling.
5756         * infcall.c: Use C++ exception handling.
5757         * inf-loop.c: Use C++ exception handling.
5758         * i386-tdep.c: Use C++ exception handling.
5759         * i386-linux-tdep.c: Use C++ exception handling.
5760         * guile/scm-value.c: Use C++ exception handling.
5761         * guile/scm-type.c: Use C++ exception handling.
5762         * guile/scm-symtab.c: Use C++ exception handling.
5763         * guile/scm-symbol.c: Use C++ exception handling.
5764         * guile/scm-pretty-print.c: Use C++ exception handling.
5765         * guile/scm-ports.c: Use C++ exception handling.
5766         * guile/scm-param.c: Use C++ exception handling.
5767         * guile/scm-math.c: Use C++ exception handling.
5768         * guile/scm-lazy-string.c: Use C++ exception handling.
5769         * guile/scm-frame.c: Use C++ exception handling.
5770         * guile/scm-disasm.c: Use C++ exception handling.
5771         * guile/scm-cmd.c: Use C++ exception handling.
5772         * guile/scm-breakpoint.c: Use C++ exception handling.
5773         * guile/scm-block.c: Use C++ exception handling.
5774         * guile/guile-internal.h: Use C++ exception handling.
5775         * gnu-v3-abi.c: Use C++ exception handling.
5776         * gdbtypes.c: Use C++ exception handling.
5777         * frame.c: Use C++ exception handling.
5778         * frame-unwind.c: Use C++ exception handling.
5779         * fbsd-tdep.c: Use C++ exception handling.
5780         * f-valprint.c: Use C++ exception handling.
5781         * exec.c: Use C++ exception handling.
5782         * event-top.c: Use C++ exception handling.
5783         * event-loop.c: Use C++ exception handling.
5784         * eval.c: Use C++ exception handling.
5785         * dwarf2read.c: Use C++ exception handling.
5786         * dwarf2loc.c: Use C++ exception handling.
5787         * dwarf2-frame.c: Use C++ exception handling.
5788         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5789         * dwarf-index-write.c: Use C++ exception handling.
5790         * dwarf-index-cache.c: Use C++ exception handling.
5791         * dtrace-probe.c: Use C++ exception handling.
5792         * disasm-selftests.c: Use C++ exception handling.
5793         * darwin-nat.c: Use C++ exception handling.
5794         * cp-valprint.c: Use C++ exception handling.
5795         * cp-support.c: Use C++ exception handling.
5796         * cp-abi.c: Use C++ exception handling.
5797         * corelow.c: Use C++ exception handling.
5798         * completer.c: Use C++ exception handling.
5799         * compile/compile-object-run.c: Use C++ exception handling.
5800         * compile/compile-object-load.c: Use C++ exception handling.
5801         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5802         * compile/compile-c-symbols.c: Use C++ exception handling.
5803         * common/selftest.c: Use C++ exception handling.
5804         * common/new-op.c: Use C++ exception handling.
5805         * cli/cli-script.c: Use C++ exception handling.
5806         * cli/cli-interp.c: Use C++ exception handling.
5807         * cli/cli-cmds.c: Use C++ exception handling.
5808         * c-varobj.c: Use C++ exception handling.
5809         * btrace.c: Use C++ exception handling.
5810         * breakpoint.c: Use C++ exception handling.
5811         * break-catch-throw.c: Use C++ exception handling.
5812         * arch-utils.c: Use C++ exception handling.
5813         * amd64-tdep.c: Use C++ exception handling.
5814         * ada-valprint.c: Use C++ exception handling.
5815         * ada-typeprint.c: Use C++ exception handling.
5816         * ada-lang.c: Use C++ exception handling.
5817         * aarch64-tdep.c: Use C++ exception handling.
5818
5819 2019-04-08  Tom Tromey  <tom@tromey.com>
5820
5821         * xml-support.c (gdb_xml_parser::parse): Update.
5822         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5823         * value.c (show_convenience): Update.
5824         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5825         (test_parse_flags_qcs): Update.
5826         * thread.c (thr_try_catch_cmd): Update.
5827         * target.c (target_translate_tls_address): Update.
5828         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5829         (info_frame_command_core, frame_apply_command_count): Update.
5830         * rust-exp.y (rust_lex_exception_test): Update.
5831         * riscv-tdep.c (riscv_print_one_register_info): Update.
5832         * remote.c (remote_target::enable_btrace): Update.
5833         * record-btrace.c (record_btrace_enable_warn): Update.
5834         * python/py-utils.c (gdbpy_convert_exception): Update.
5835         * printcmd.c (do_one_display, print_variable_and_value): Update.
5836         * mi/mi-main.c (mi_print_exception): Update.
5837         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5838         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5839         * linux-nat.c (linux_nat_target::attach): Update.
5840         * linux-fork.c (class scoped_switch_fork_info): Update.
5841         * infrun.c (displaced_step_prepare): Update.
5842         * infcall.c (call_function_by_hand_dummy): Update.
5843         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5844         * gnu-v3-abi.c (print_one_vtable): Update.
5845         * frame.c (get_prev_frame_always): Update.
5846         * f-valprint.c (info_common_command_for_block): Update.
5847         * exec.c (try_open_exec_file): Update.
5848         * exceptions.c (print_exception, exception_print)
5849         (exception_fprintf, exception_print_same): Update.
5850         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5851         * dwarf-index-cache.c (index_cache::store)
5852         (index_cache::lookup_gdb_index): Update.
5853         * darwin-nat.c (maybe_cache_shell): Update.
5854         * cp-valprint.c (cp_print_value_fields): Update.
5855         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5856         (gcc_cplus_symbol_address): Update.
5857         * compile/compile-c-symbols.c (gcc_convert_symbol)
5858         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5859         * common/selftest.c: Update.
5860         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5861         a std::string.
5862         (exception_try_scope_entry, exception_try_scope_exit): Don't
5863         declare.
5864         (struct exception_try_scope): Remove.
5865         (TRY): Don't use exception_try_scope.
5866         (struct gdb_exception): Add constructor, operator=.
5867         <what>: New method.
5868         (struct gdb_exception_RETURN_MASK_ALL)
5869         (struct gdb_exception_RETURN_MASK_ERROR)
5870         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5871         (struct gdb_quit_bad_alloc): Update.
5872         * common/common-exceptions.c (exception_none): Change
5873         initializer.
5874         (struct catcher) <state, exception>: Initialize inline.
5875         <prev>: Remove member.
5876         (current_catcher): Remove.
5877         (catchers): New global.
5878         (exceptions_state_mc_init): Simplify.
5879         (catcher_pop): Remove.
5880         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5881         (try_scope_depth, exception_try_scope_entry)
5882         (exception_try_scope_exit): Remove.
5883         (throw_exception_sjlj): Update.
5884         (exception_messages, exception_messages_size): Remove.
5885         (throw_it): Simplify.
5886         (gdb_exception_sliced_copy): Remove.
5887         (throw_exception_cxx): Update.
5888         * cli/cli-script.c (script_from_file): Update.
5889         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5890         Update.
5891         * ada-valprint.c (ada_val_print): Update.
5892         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5893         (create_excep_cond_exprs): Update.
5894
5895 2019-04-08  Tom Tromey  <tom@tromey.com>
5896
5897         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5898         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5899         (TRY, CATCH, END_CATCH): Remove some definitions.
5900         * common/common-exceptions.c: Don't use GDB_XCPT.
5901         (catcher_list_size): Remove.
5902         (throw_exception, throw_it): Simplify.
5903
5904 2019-04-05  Tom Tromey  <tom@tromey.com>
5905
5906         Revert the header-sorting patch.
5907         * ft32-tdep.c: Revert.
5908         * frv-tdep.c: Revert.
5909         * frv-linux-tdep.c: Revert.
5910         * frame.c: Revert.
5911         * frame-unwind.c: Revert.
5912         * frame-base.c: Revert.
5913         * fork-child.c: Revert.
5914         * findvar.c: Revert.
5915         * findcmd.c: Revert.
5916         * filesystem.c: Revert.
5917         * filename-seen-cache.h: Revert.
5918         * filename-seen-cache.c: Revert.
5919         * fbsd-tdep.c: Revert.
5920         * fbsd-nat.h: Revert.
5921         * fbsd-nat.c: Revert.
5922         * f-valprint.c: Revert.
5923         * f-typeprint.c: Revert.
5924         * f-lang.c: Revert.
5925         * extension.h: Revert.
5926         * extension.c: Revert.
5927         * extension-priv.h: Revert.
5928         * expprint.c: Revert.
5929         * exec.h: Revert.
5930         * exec.c: Revert.
5931         * exceptions.c: Revert.
5932         * event-top.c: Revert.
5933         * event-loop.c: Revert.
5934         * eval.c: Revert.
5935         * elfread.c: Revert.
5936         * dwarf2read.h: Revert.
5937         * dwarf2read.c: Revert.
5938         * dwarf2loc.c: Revert.
5939         * dwarf2expr.h: Revert.
5940         * dwarf2expr.c: Revert.
5941         * dwarf2-frame.c: Revert.
5942         * dwarf2-frame-tailcall.c: Revert.
5943         * dwarf-index-write.h: Revert.
5944         * dwarf-index-write.c: Revert.
5945         * dwarf-index-common.c: Revert.
5946         * dwarf-index-cache.h: Revert.
5947         * dwarf-index-cache.c: Revert.
5948         * dummy-frame.c: Revert.
5949         * dtrace-probe.c: Revert.
5950         * disasm.h: Revert.
5951         * disasm.c: Revert.
5952         * disasm-selftests.c: Revert.
5953         * dictionary.c: Revert.
5954         * dicos-tdep.c: Revert.
5955         * demangle.c: Revert.
5956         * dcache.h: Revert.
5957         * dcache.c: Revert.
5958         * darwin-nat.h: Revert.
5959         * darwin-nat.c: Revert.
5960         * darwin-nat-info.c: Revert.
5961         * d-valprint.c: Revert.
5962         * d-namespace.c: Revert.
5963         * d-lang.c: Revert.
5964         * ctf.c: Revert.
5965         * csky-tdep.c: Revert.
5966         * csky-linux-tdep.c: Revert.
5967         * cris-tdep.c: Revert.
5968         * cris-linux-tdep.c: Revert.
5969         * cp-valprint.c: Revert.
5970         * cp-support.c: Revert.
5971         * cp-namespace.c: Revert.
5972         * cp-abi.c: Revert.
5973         * corelow.c: Revert.
5974         * corefile.c: Revert.
5975         * continuations.c: Revert.
5976         * completer.h: Revert.
5977         * completer.c: Revert.
5978         * complaints.c: Revert.
5979         * coffread.c: Revert.
5980         * coff-pe-read.c: Revert.
5981         * cli-out.h: Revert.
5982         * cli-out.c: Revert.
5983         * charset.c: Revert.
5984         * c-varobj.c: Revert.
5985         * c-valprint.c: Revert.
5986         * c-typeprint.c: Revert.
5987         * c-lang.c: Revert.
5988         * buildsym.c: Revert.
5989         * buildsym-legacy.c: Revert.
5990         * build-id.h: Revert.
5991         * build-id.c: Revert.
5992         * btrace.c: Revert.
5993         * bsd-uthread.c: Revert.
5994         * breakpoint.h: Revert.
5995         * breakpoint.c: Revert.
5996         * break-catch-throw.c: Revert.
5997         * break-catch-syscall.c: Revert.
5998         * break-catch-sig.c: Revert.
5999         * blockframe.c: Revert.
6000         * block.c: Revert.
6001         * bfin-tdep.c: Revert.
6002         * bfin-linux-tdep.c: Revert.
6003         * bfd-target.c: Revert.
6004         * bcache.c: Revert.
6005         * ax-general.c: Revert.
6006         * ax-gdb.h: Revert.
6007         * ax-gdb.c: Revert.
6008         * avr-tdep.c: Revert.
6009         * auxv.c: Revert.
6010         * auto-load.c: Revert.
6011         * arm-wince-tdep.c: Revert.
6012         * arm-tdep.c: Revert.
6013         * arm-symbian-tdep.c: Revert.
6014         * arm-pikeos-tdep.c: Revert.
6015         * arm-obsd-tdep.c: Revert.
6016         * arm-nbsd-tdep.c: Revert.
6017         * arm-nbsd-nat.c: Revert.
6018         * arm-linux-tdep.c: Revert.
6019         * arm-linux-nat.c: Revert.
6020         * arm-fbsd-tdep.c: Revert.
6021         * arm-fbsd-nat.c: Revert.
6022         * arm-bsd-tdep.c: Revert.
6023         * arch-utils.c: Revert.
6024         * arc-tdep.c: Revert.
6025         * arc-newlib-tdep.c: Revert.
6026         * annotate.h: Revert.
6027         * annotate.c: Revert.
6028         * amd64-windows-tdep.c: Revert.
6029         * amd64-windows-nat.c: Revert.
6030         * amd64-tdep.c: Revert.
6031         * amd64-sol2-tdep.c: Revert.
6032         * amd64-obsd-tdep.c: Revert.
6033         * amd64-obsd-nat.c: Revert.
6034         * amd64-nbsd-tdep.c: Revert.
6035         * amd64-nbsd-nat.c: Revert.
6036         * amd64-nat.c: Revert.
6037         * amd64-linux-tdep.c: Revert.
6038         * amd64-linux-nat.c: Revert.
6039         * amd64-fbsd-tdep.c: Revert.
6040         * amd64-fbsd-nat.c: Revert.
6041         * amd64-dicos-tdep.c: Revert.
6042         * amd64-darwin-tdep.c: Revert.
6043         * amd64-bsd-nat.c: Revert.
6044         * alpha-tdep.c: Revert.
6045         * alpha-obsd-tdep.c: Revert.
6046         * alpha-nbsd-tdep.c: Revert.
6047         * alpha-mdebug-tdep.c: Revert.
6048         * alpha-linux-tdep.c: Revert.
6049         * alpha-linux-nat.c: Revert.
6050         * alpha-bsd-tdep.c: Revert.
6051         * alpha-bsd-nat.c: Revert.
6052         * aix-thread.c: Revert.
6053         * agent.c: Revert.
6054         * addrmap.c: Revert.
6055         * ada-varobj.c: Revert.
6056         * ada-valprint.c: Revert.
6057         * ada-typeprint.c: Revert.
6058         * ada-tasks.c: Revert.
6059         * ada-lang.c: Revert.
6060         * aarch64-tdep.c: Revert.
6061         * aarch64-ravenscar-thread.c: Revert.
6062         * aarch64-newlib-tdep.c: Revert.
6063         * aarch64-linux-tdep.c: Revert.
6064         * aarch64-linux-nat.c: Revert.
6065         * aarch64-fbsd-tdep.c: Revert.
6066         * aarch64-fbsd-nat.c: Revert.
6067         * aarch32-linux-nat.c: Revert.
6068
6069 2019-04-05  Tom Tromey  <tom@tromey.com>
6070
6071         * ft32-tdep.c: Sort headers.
6072         * frv-tdep.c: Sort headers.
6073         * frv-linux-tdep.c: Sort headers.
6074         * frame.c: Sort headers.
6075         * frame-unwind.c: Sort headers.
6076         * frame-base.c: Sort headers.
6077         * fork-child.c: Sort headers.
6078         * findvar.c: Sort headers.
6079         * findcmd.c: Sort headers.
6080         * filesystem.c: Sort headers.
6081         * filename-seen-cache.h: Sort headers.
6082         * filename-seen-cache.c: Sort headers.
6083         * fbsd-tdep.c: Sort headers.
6084         * fbsd-nat.h: Sort headers.
6085         * fbsd-nat.c: Sort headers.
6086         * f-valprint.c: Sort headers.
6087         * f-typeprint.c: Sort headers.
6088         * f-lang.c: Sort headers.
6089         * extension.h: Sort headers.
6090         * extension.c: Sort headers.
6091         * extension-priv.h: Sort headers.
6092         * expprint.c: Sort headers.
6093         * exec.h: Sort headers.
6094         * exec.c: Sort headers.
6095         * exceptions.c: Sort headers.
6096         * event-top.c: Sort headers.
6097         * event-loop.c: Sort headers.
6098         * eval.c: Sort headers.
6099         * elfread.c: Sort headers.
6100         * dwarf2read.h: Sort headers.
6101         * dwarf2read.c: Sort headers.
6102         * dwarf2loc.c: Sort headers.
6103         * dwarf2expr.h: Sort headers.
6104         * dwarf2expr.c: Sort headers.
6105         * dwarf2-frame.c: Sort headers.
6106         * dwarf2-frame-tailcall.c: Sort headers.
6107         * dwarf-index-write.h: Sort headers.
6108         * dwarf-index-write.c: Sort headers.
6109         * dwarf-index-common.c: Sort headers.
6110         * dwarf-index-cache.h: Sort headers.
6111         * dwarf-index-cache.c: Sort headers.
6112         * dummy-frame.c: Sort headers.
6113         * dtrace-probe.c: Sort headers.
6114         * disasm.h: Sort headers.
6115         * disasm.c: Sort headers.
6116         * disasm-selftests.c: Sort headers.
6117         * dictionary.c: Sort headers.
6118         * dicos-tdep.c: Sort headers.
6119         * demangle.c: Sort headers.
6120         * dcache.h: Sort headers.
6121         * dcache.c: Sort headers.
6122         * darwin-nat.h: Sort headers.
6123         * darwin-nat.c: Sort headers.
6124         * darwin-nat-info.c: Sort headers.
6125         * d-valprint.c: Sort headers.
6126         * d-namespace.c: Sort headers.
6127         * d-lang.c: Sort headers.
6128         * ctf.c: Sort headers.
6129         * csky-tdep.c: Sort headers.
6130         * csky-linux-tdep.c: Sort headers.
6131         * cris-tdep.c: Sort headers.
6132         * cris-linux-tdep.c: Sort headers.
6133         * cp-valprint.c: Sort headers.
6134         * cp-support.c: Sort headers.
6135         * cp-namespace.c: Sort headers.
6136         * cp-abi.c: Sort headers.
6137         * corelow.c: Sort headers.
6138         * corefile.c: Sort headers.
6139         * continuations.c: Sort headers.
6140         * completer.h: Sort headers.
6141         * completer.c: Sort headers.
6142         * complaints.c: Sort headers.
6143         * coffread.c: Sort headers.
6144         * coff-pe-read.c: Sort headers.
6145         * cli-out.h: Sort headers.
6146         * cli-out.c: Sort headers.
6147         * charset.c: Sort headers.
6148         * c-varobj.c: Sort headers.
6149         * c-valprint.c: Sort headers.
6150         * c-typeprint.c: Sort headers.
6151         * c-lang.c: Sort headers.
6152         * buildsym.c: Sort headers.
6153         * buildsym-legacy.c: Sort headers.
6154         * build-id.h: Sort headers.
6155         * build-id.c: Sort headers.
6156         * btrace.c: Sort headers.
6157         * bsd-uthread.c: Sort headers.
6158         * breakpoint.h: Sort headers.
6159         * breakpoint.c: Sort headers.
6160         * break-catch-throw.c: Sort headers.
6161         * break-catch-syscall.c: Sort headers.
6162         * break-catch-sig.c: Sort headers.
6163         * blockframe.c: Sort headers.
6164         * block.c: Sort headers.
6165         * bfin-tdep.c: Sort headers.
6166         * bfin-linux-tdep.c: Sort headers.
6167         * bfd-target.c: Sort headers.
6168         * bcache.c: Sort headers.
6169         * ax-general.c: Sort headers.
6170         * ax-gdb.h: Sort headers.
6171         * ax-gdb.c: Sort headers.
6172         * avr-tdep.c: Sort headers.
6173         * auxv.c: Sort headers.
6174         * auto-load.c: Sort headers.
6175         * arm-wince-tdep.c: Sort headers.
6176         * arm-tdep.c: Sort headers.
6177         * arm-symbian-tdep.c: Sort headers.
6178         * arm-pikeos-tdep.c: Sort headers.
6179         * arm-obsd-tdep.c: Sort headers.
6180         * arm-nbsd-tdep.c: Sort headers.
6181         * arm-nbsd-nat.c: Sort headers.
6182         * arm-linux-tdep.c: Sort headers.
6183         * arm-linux-nat.c: Sort headers.
6184         * arm-fbsd-tdep.c: Sort headers.
6185         * arm-fbsd-nat.c: Sort headers.
6186         * arm-bsd-tdep.c: Sort headers.
6187         * arch-utils.c: Sort headers.
6188         * arc-tdep.c: Sort headers.
6189         * arc-newlib-tdep.c: Sort headers.
6190         * annotate.h: Sort headers.
6191         * annotate.c: Sort headers.
6192         * amd64-windows-tdep.c: Sort headers.
6193         * amd64-windows-nat.c: Sort headers.
6194         * amd64-tdep.c: Sort headers.
6195         * amd64-sol2-tdep.c: Sort headers.
6196         * amd64-obsd-tdep.c: Sort headers.
6197         * amd64-obsd-nat.c: Sort headers.
6198         * amd64-nbsd-tdep.c: Sort headers.
6199         * amd64-nbsd-nat.c: Sort headers.
6200         * amd64-nat.c: Sort headers.
6201         * amd64-linux-tdep.c: Sort headers.
6202         * amd64-linux-nat.c: Sort headers.
6203         * amd64-fbsd-tdep.c: Sort headers.
6204         * amd64-fbsd-nat.c: Sort headers.
6205         * amd64-dicos-tdep.c: Sort headers.
6206         * amd64-darwin-tdep.c: Sort headers.
6207         * amd64-bsd-nat.c: Sort headers.
6208         * alpha-tdep.c: Sort headers.
6209         * alpha-obsd-tdep.c: Sort headers.
6210         * alpha-nbsd-tdep.c: Sort headers.
6211         * alpha-mdebug-tdep.c: Sort headers.
6212         * alpha-linux-tdep.c: Sort headers.
6213         * alpha-linux-nat.c: Sort headers.
6214         * alpha-bsd-tdep.c: Sort headers.
6215         * alpha-bsd-nat.c: Sort headers.
6216         * aix-thread.c: Sort headers.
6217         * agent.c: Sort headers.
6218         * addrmap.c: Sort headers.
6219         * ada-varobj.c: Sort headers.
6220         * ada-valprint.c: Sort headers.
6221         * ada-typeprint.c: Sort headers.
6222         * ada-tasks.c: Sort headers.
6223         * ada-lang.c: Sort headers.
6224         * aarch64-tdep.c: Sort headers.
6225         * aarch64-ravenscar-thread.c: Sort headers.
6226         * aarch64-newlib-tdep.c: Sort headers.
6227         * aarch64-linux-tdep.c: Sort headers.
6228         * aarch64-linux-nat.c: Sort headers.
6229         * aarch64-fbsd-tdep.c: Sort headers.
6230         * aarch64-fbsd-nat.c: Sort headers.
6231         * aarch32-linux-nat.c: Sort headers.
6232
6233 2019-04-04  Tom Tromey  <tom@tromey.com>
6234
6235         * varobj.c (varobj_create): Update.
6236         * rust-exp.y (struct rust_parser) <update_innermost_block,
6237         lookup_symbol>: New methods.
6238         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6239         Rename.
6240         (rust_parser::rust_lookup_type)
6241         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6242         * printcmd.c (display_command, do_one_display): Update.
6243         * parser-defs.h (struct parser_state) <parser_state>: Add
6244         "tracker" parameter.
6245         (block_tracker): New member.
6246         (class innermost_block_tracker) <innermost_block_tracker>: Add
6247         "types" parameter.
6248         <reset>: Remove method.
6249         (innermost_block): Don't declare.
6250         (null_post_parser): Update.
6251         * parse.c (innermost_block): Remove global.
6252         (write_dollar_variable): Update.
6253         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6254         Remove "tracker_types" parameter.
6255         (parse_expression): Add "tracker" parameter.
6256         (parse_expression_for_completion): Update.
6257         (null_post_parser): Add "tracker" parameter.
6258         * p-exp.y: Update rules.
6259         * m2-exp.y: Update rules.
6260         * language.h (struct language_defn) <la_post_parser>: Add
6261         "tracker" parameter.
6262         * go-exp.y: Update rules.
6263         * f-exp.y: Update rules.
6264         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6265         parameter.
6266         * d-exp.y: Update rules.
6267         * c-exp.y: Update rules.
6268         * breakpoint.c (set_breakpoint_condition): Create an
6269         innermost_block_tracker.
6270         (watch_command_1): Likewise.
6271         * ada-lang.c (resolve): Add "tracker" parameter.
6272         (resolve_subexp): Likewise.
6273         * ada-exp.y (write_var_from_sym): Update.
6274
6275 2019-04-04  Tom Tromey  <tom@tromey.com>
6276
6277         * type-stack.h: New file.
6278         * type-stack.c: New file.
6279         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6280         type-stack.h.
6281         (insert_into_type_stack, insert_type, push_type, push_type_int)
6282         (insert_type_address_space, pop_type, pop_type_int)
6283         (pop_typelist, pop_type_stack, append_type_stack)
6284         (push_type_stack, get_type_stack, push_typelist)
6285         (follow_type_instance_flags, follow_types): Don't declare.
6286         * parse.c (type_stack): Remove global.
6287         (parse_exp_in_context): Update.
6288         (insert_into_type_stack, insert_type, push_type, push_type_int)
6289         (insert_type_address_space, pop_type, pop_type_int)
6290         (pop_typelist, pop_type_stack, append_type_stack)
6291         (push_type_stack, get_type_stack, push_typelist)
6292         (follow_type_instance_flags, follow_types): Remove (moved to
6293         type-stack.c).
6294         * f-exp.y (type_stack): New global.
6295         Update rules.
6296         (push_kind_type, f_parse): Update.
6297         * d-exp.y (type_stack): New global.
6298         Update rules.
6299         (d_parse): Update.
6300         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6301         Update rules.
6302         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6303         (HFILES_NO_SRCDIR): Add type-stack.h.
6304
6305 2019-04-04  Tom Tromey  <tom@tromey.com>
6306
6307         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6308         (rust_parser::convert_ast_to_expression, rust_parse)
6309         (rust_lex_test_completion, rust_lex_tests): Update.
6310         * parser-defs.h (struct expr_completion_state): New.
6311         (struct parser_state) <parser_state>: Add completion parameter.
6312         <mark_struct_expression, mark_completion_tag>: New methods.
6313         <parse_completion, m_completion_state>: New members.
6314         (prefixify_expression, null_post_parser): Update.
6315         (mark_struct_expression, mark_completion_tag): Don't declare.
6316         * parse.c (parse_completion, expout_last_struct)
6317         (expout_tag_completion_type, expout_completion_name): Remove
6318         globals.
6319         (parser_state::mark_struct_expression)
6320         (parser_state::mark_completion_tag): Now methods.
6321         (prefixify_expression): Add last_struct parameter.
6322         (prefixify_subexp): Likewise.
6323         (parse_exp_1): Update.
6324         (parse_exp_in_context): Add cstate parameter.  Update.
6325         (parse_expression_for_completion): Create an
6326         expr_completion_state.
6327         (null_post_parser): Add "completion" parameter.
6328         * p-exp.y: Update rules.
6329         (yylex): Update.
6330         * language.h (struct language_defn) <la_post_parser>: Add
6331         "completing" parameter.
6332         * go-exp.y: Update rules.
6333         (lex_one_token): Update.
6334         * expression.h (parse_completion): Don't declare.
6335         * d-exp.y: Update rules.
6336         (lex_one_token): Update rules.
6337         * c-exp.y: Update rules.
6338         (lex_one_token): Update.
6339         * ada-lang.c (resolve): Add "parse_completion" parameter.
6340         (resolve_subexp): Likewise.
6341         (ada_resolve_function): Likewise.
6342
6343 2019-04-04  Tom Tromey  <tom@tromey.com>
6344
6345         * parser-defs.h (struct parser_state) <start_arglist,
6346         end_arglist>: New methods.
6347         <arglist_len, m_funcall_chain>: New members.
6348         (arglist_len, start_arglist, end_arglist): Don't declare.
6349         * parse.c (arglist_len, funcall_chain): Remove global.
6350         (start_arglist, end_arglist): Remove functions.
6351         (parse_exp_in_context): Update.
6352         * p-exp.y: Update rules.
6353         * m2-exp.y: Update rules.
6354         * go-exp.y: Update rules.
6355         * f-exp.y: Update rules.
6356         * d-exp.y: Update rules.
6357         * c-exp.y: Update rules.
6358
6359 2019-04-04  Tom Tromey  <tom@tromey.com>
6360
6361         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6362         lex_operator, push_back>: New methods.
6363         Update all rules.
6364         (rust_parser::lex_hex, lex_escape): Rename and update.
6365         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6366         (rust_parser::lex_operator): Rename and update.
6367         (rust_parser::lex_number, rustyylex, rustyyerror)
6368         (rust_lex_test_init, rust_lex_test_sequence)
6369         (rust_lex_test_push_back, rust_lex_tests): Update.
6370         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6371         parameter.
6372         <lexptr, prev_lexptr>: New members.
6373         (lexptr, prev_lexptr): Don't declare.
6374         * parse.c (lexptr, prev_lexptr): Remove globals.
6375         (parse_exp_in_context): Update.
6376         * p-exp.y (yylex, yyerror): Update.
6377         * m2-exp.y (parse_number, yylex, yyerror): Update.
6378         * go-exp.y (lex_one_token, yyerror): Update.
6379         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6380         * d-exp.y (lex_one_token, yyerror): Update.
6381         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6382         (lex_one_token, yyerror): Update.
6383         * ada-lex.l (YY_INPUT): Update.
6384         (rewind_to_char): Update.
6385         * ada-exp.y (yyerror): Update.
6386
6387 2019-04-04  Tom Tromey  <tom@tromey.com>
6388
6389         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6390         * parser-defs.h (struct parser_state) <parser_state>: Add new
6391         parameter.
6392         <comma_terminates>: New member.
6393         (comma_terminates): Don't declare global.
6394         * parse.c (comma_terminates): Remove global.
6395         (parse_exp_in_context): Update.
6396         * p-exp.y (yylex): Update.
6397         * m2-exp.y (yylex): Update.
6398         * go-exp.y (lex_one_token): Update.
6399         * f-exp.y (yylex): Update.
6400         * d-exp.y (lex_one_token): Update.
6401         * c-exp.y (lex_one_token): Update.
6402         * ada-lex.l: Update.
6403
6404 2019-04-04  Tom Tromey  <tom@tromey.com>
6405
6406         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6407         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6408         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6409         * parser-defs.h (paren_depth): Don't declare.
6410         * parse.c (paren_depth): Remove global.
6411         (parse_exp_in_context): Update.
6412         * p-exp.y (paren_depth): New global.
6413         (pascal_parse): Initialize it.
6414         * m2-exp.y (paren_depth): New global.
6415         (m2_parse): Initialize it.
6416         * go-exp.y (paren_depth): New global.
6417         (go_parse): Initialize it.
6418         * f-exp.y (paren_depth): New global.
6419         (f_parse): Initialize it.
6420         * d-exp.y (paren_depth): New global.
6421         (d_parse): Initialize it.
6422         * c-exp.y (paren_depth): New global.
6423         (c_parse): Initialize it.
6424         * ada-lex.l (paren_depth): New global.
6425         (lexer_init): Initialize it.
6426
6427 2019-04-04  Tom Tromey  <tom@tromey.com>
6428
6429         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6430         (rust_parser::convert_ast_to_type)
6431         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6432         * parser-defs.h (struct parser_state) <parser_state>: Add
6433         parameters.  Initialize new members.
6434         <expression_context_block, expression_context_pc>: New members.
6435         * parse.c (expression_context_block, expression_context_pc):
6436         Remove globals.
6437         (parse_exp_in_context): Update.
6438         * p-exp.y: Update all rules.
6439         (yylex): Update.
6440         * m2-exp.y: Update all rules.
6441         (yylex): Update.
6442         * go-exp.y (yylex): Update.
6443         * f-exp.y (yylex): Update.
6444         * d-exp.y: Update all rules.
6445         (yylex): Update.
6446         * c-exp.y: Update all rules.
6447         (lex_one_token, classify_name, yylex, c_parse): Update.
6448         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6449
6450 2019-04-04  Tom Tromey  <tom@tromey.com>
6451
6452         * gdbarch.h, gdbarch.c: Rebuild.
6453         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6454         * stap-probe.h:
6455         (struct stap_parse_info): Replace "parser_state" with
6456         "expr_builder".
6457         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6458         (parser_state): New class.
6459         * parse.c (expr_builder): Rename.
6460         (expr_builder::release): Rename.
6461         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6462         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6463         (write_exp_elt_longcst, write_exp_elt_floatcst)
6464         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6465         (write_exp_string_vector, write_exp_bitstring)
6466         (write_exp_msymbol, mark_struct_expression)
6467         (write_dollar_variable)
6468         (insert_type_address_space, increase_expout_size): Replace
6469         "parser_state" with "expr_builder".
6470         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6471         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6472         "parser_state" with "expr_builder".
6473
6474 2019-04-04  Tom Tromey  <tom@tromey.com>
6475
6476         * rust-exp.y: Replace "parse_language" with method call.
6477         * p-exp.y:
6478         (yylex): Replace "parse_language" with method call.
6479         * m2-exp.y:
6480         (yylex): Replace "parse_language" with method call.
6481         * go-exp.y (classify_name): Replace "parse_language" with method
6482         call.
6483         * f-exp.y (yylex): Replace "parse_language" with method call.
6484         * d-exp.y (lex_one_token): Replace "parse_language" with method
6485         call.
6486         * c-exp.y:
6487         (lex_one_token, classify_name, yylex): Replace "parse_language"
6488         with method call.
6489         * ada-exp.y (find_primitive_type, type_char)
6490         (type_system_address): Replace "parse_language" with method call.
6491
6492 2019-04-04  Tom Tromey  <tom@tromey.com>
6493
6494         * rust-exp.y: Replace "parse_gdbarch" with method call.
6495         * parse.c (write_dollar_variable, insert_type_address_space):
6496         Replace "parse_gdbarch" with method call.
6497         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6498         call.
6499         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6500         call.
6501         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6502         "parse_gdbarch" with method call.
6503         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6504         with method call.
6505         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6506         "parse_gdbarch" with method call.
6507         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6508         "parse_gdbarch" with method call.
6509         * c-exp.y (parse_type, parse_number, classify_name): Replace
6510         "parse_gdbarch" with method call.
6511         * ada-lex.l: Replace "parse_gdbarch" with method call.
6512         * ada-exp.y (parse_type, find_primitive_type, type_char)
6513         (type_system_address): Replace "parse_gdbarch" with method call.
6514
6515 2019-04-04  Tom Tromey  <tom@tromey.com>
6516
6517         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6518         * stap-probe.c (stap_parse_argument): Update.
6519         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6520         initial_size parameter.
6521         * rust-exp.y (rust_lex_tests): Update.
6522         * parse.c (parser_state): Update.
6523         (parse_exp_in_context): Update.
6524         * parser-defs.h (struct parser_state) <parser_state>: Remove
6525         "initial_size" parameter.
6526
6527 2019-04-04  Tom Tromey  <tom@tromey.com>
6528
6529         * parser-defs.h (increase_expout_size): Don't declare.
6530         * parse.c (increase_expout_size): Now static.
6531
6532 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6533
6534         * gnu-nat.c (gnu_nat_target::wait): Fix
6535         target_waitstatus_to_string call.
6536
6537 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         * eval.c (evaluate_subexp_standard): Handle internal functions
6540         during Fortran function call handling.
6541
6542 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6543
6544         * NEWS: Mention new internal functions.
6545         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6546         (read_base_type): Use dwarf2_init_complex_target_type.
6547         * value.c (creal_internal_fn): New function.
6548         (cimag_internal_fn): New function.
6549         (_initialize_values): Register new internal functions.
6550
6551 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6552
6553         * infrun.c (stop_all_threads): If debug_infrun, always
6554         trace the wait status after wait_one, using
6555         target_waitstatus_to_string and target_pid_to_str.
6556         (handle_inferior_event): Replace various trace of
6557         wait status kind by a single trace.
6558         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6559         wait status kind image by target_waitstatus_to_string.
6560         * target/waitstatus.c (target_waitstatus_to_string): Fix
6561         obsolete comment.
6562
6563 2019-04-01  Tom Tromey  <tromey@adacore.com>
6564
6565         PR symtab/23331:
6566         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6567
6568 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6569             Pedro Alves  <palves@redhat.com>
6570
6571         * top.c (quit_force): Call 'finalize_values'.
6572         * value.c (finalize_values): New function.
6573         * value.h (finalize_values): Declare.
6574
6575 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6576
6577         * NEWS: Announce $_gdb_major and $_gdb_minor.
6578
6579         * top.c (init_gdb_version_vars): New function.
6580         (gdb_init): Call init_gdb_version_vars.
6581
6582 2019-03-29  Tom Tromey  <tromey@adacore.com>
6583
6584         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6585         help text.  Remove dead code.
6586
6587 2019-03-29  Keith Seitz  <keiths@redhat.com>
6588
6589         From Siddhesh Poyarekar:
6590         * f-lang.h (f77_get_upperbound): Return LONGEST.
6591         (f77_get_lowerbound): Likewise.
6592         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6593         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6594         print them.
6595         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6596         plongest to format print it.
6597         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6598         (f77_get_upperbound): Likewise.
6599         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6600         LOWER_BOUND to LONGEST.
6601         (f77_create_arrayprint_offset_tbl): Likewise.
6602
6603 2019-03-29  Keith Seitz  <keiths@redhat.com>
6604
6605         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6606         %s/pulongest for TYPE_LENGTH instead of %d in format
6607         strings.
6608         * ada-typerint.c (ada_print_type): Likewise.
6609         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6610         * compile/compile-c-support.c (generate_register_struct): Likewise.
6611         * gdbtypes.c (recursive_dump_type): Likewise.
6612         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6613         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6614         instead of %d in format strings.
6615         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6616         to std::min to ULONGEST.
6617         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6618         instead of %d in format strings.
6619         * tracepoint.c (info_scope_command): Likewise.
6620         * typeprint.c (print_offset_data::update)
6621         (print_offset_data::finish): Likewise.
6622         * xtensa-tdep.c (xtensa_store_return_value)
6623         (xtensa_push_dummy_call): Likewise.
6624
6625 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6626
6627         * windows-nat.c (display_selector): Fixed format specifications
6628         for 64-bit Cygwin.
6629
6630 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6631
6632         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6633
6634 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6635
6636         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6637         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6638         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6639         (nios2_linux_init_abi): Install it.
6640
6641 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6642
6643         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6644
6645 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6646
6647         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6648
6649 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6650             Tom Tromey  <tromey@adacore.com>
6651
6652         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6653
6654 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6655
6656         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6657         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6658         method to compute the bounds of range types. Also print "[evaluated]"
6659         if the bounds' values come from a dynamic evaluation.
6660
6661 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6662
6663         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6664         whitespace when pretty printing is on.
6665
6666 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6667
6668         * ppc-linux-nat.c: Add include.
6669
6670 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6671
6672         * NEWS: Mention AArch64 Pointer Authentication.
6673
6674 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6675
6676         * arm-linux-nat.c: Add include.
6677
6678 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6679
6680         * source-cache.c (source_cache::get_source_lines): Re-read
6681         fullname after calling open_source_file.
6682
6683 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6684
6685         * NEWS: Mention TLS support for FreeBSD.
6686
6687 2019-03-25  Tom Tromey  <tromey@adacore.com>
6688
6689         * minsyms.c (BUNCH_SIZE): Update comment.
6690         (~minimal_symbol_reader): Remove old comment.
6691         (compact_minimal_symbols): Update comment.
6692         (minimal_symbol_reader::install): Remove old comment.  Update
6693         other comments.
6694
6695 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6696
6697         * s390-linux-nat.c: Add include.
6698
6699 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6700
6701         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6702         Call linux_get_hwcap.
6703         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6704         Likewise.
6705         (aarch64_linux_get_hwcap): Remove function.
6706         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6707         declaration.
6708         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6709         linux_get_hwcap.
6710         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6711         * linux-tdep.c (linux_get_hwcap): Add function.
6712         (linux_get_hwcap2): Likewise.
6713         * linux-tdep.h (linux_get_hwcap): Add declaration.
6714         (linux_get_hwcap2): Likewise.
6715         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6716         (ppc_linux_get_hwcap2): Likewise.
6717         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6718         linux_get_hwcap.
6719         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6720         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6721         (ppc_linux_nat_target::read_description): Likewise.
6722         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6723         * s390-linux-nat.c: Likewise.
6724         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6725
6726 2019-03-24  Tom Tromey  <tom@tromey.com>
6727
6728         * ada-lang.c (standard_lookup): Simplify initialization.
6729         (ada_lookup_symbol_nonlocal): Simplify return.
6730         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6731         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6732         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6733         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6734         initialization.
6735         * solib.c (solib_global_lookup): Simplify.
6736         * symtab.c (null_block_symbol): Remove.
6737         (symbol_cache_lookup): Simplify returns.
6738         (lookup_language_this): Simplify returns.
6739         (lookup_symbol_aux): Simplify return.
6740         (lookup_local_symbol): Simplify returns.
6741         (lookup_global_symbol_from_objfile): Simplify return.
6742         (lookup_symbol_in_objfile_symtabs)
6743         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6744         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6745         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6746         * cp-namespace.c (cp_lookup_bare_symbol)
6747         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6748         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6749         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6750         (cp_lookup_symbol_via_imports): Simplify initialization.
6751         (find_symbol_in_baseclass): Likewise.
6752         * symtab.h (null_block_symbol): Remove.
6753         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6754         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6755         (d_lookup_symbol_module): Likewise.
6756         (find_symbol_in_baseclass): Simplify initialization.
6757
6758 2019-03-24  Tom Tromey  <tom@tromey.com>
6759
6760         * expression.h: Don't include symtab.h.
6761         (struct block): Forward declare.
6762
6763 2019-03-24  Tom Tromey  <tom@tromey.com>
6764
6765         * c-exp.y (typebase): Remove casts.
6766         * gdbtypes.c (lookup_unsigned_typename, )
6767         (lookup_signed_typename): Remove cast.
6768         * eval.c (parse_to_comma_and_eval): Remove cast.
6769         * parse.c (write_dollar_variable): Remove cast.
6770         * block.h (struct block) <superblock>: Now const.
6771         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6772         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6773         (map_block): Make "block" const.
6774         * symfile.h (struct quick_symbol_functions)
6775         <map_matching_symbols>: Constify block argument to "callback".
6776         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6777         const.
6778         (find_pc_sect_compunit_symtab): Make "b" const.
6779         (find_symbol_at_address): Likewise.
6780         (search_symbols): Likewise.
6781         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6782         (dw2_debug_names_lookup_symbol): Likewise.
6783         (dw2_map_matching_symbols): Update.
6784         * p-valprint.c (pascal_val_print): Remove "block".
6785         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6786         (aux_add_nonlocal_symbols): Make "block" const.
6787         (resolve_subexp): Remove cast.
6788         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6789         const.
6790         (iterate_over_file_blocks): Likewise.
6791         * f-exp.y (%union) <bval>: Remove.
6792         * coffread.c (patch_opaque_types): Make "b" const.
6793         * spu-tdep.c (spu_catch_start): Make "block" const.
6794         * c-valprint.c (print_unpacked_pointer): Remove "block".
6795         * symmisc.c (dump_symtab_1): Make "b" const.
6796         (block_depth): Make "block" const.
6797         * d-exp.y (%union) <bval>: Remove.
6798         * cp-support.h (cp_lookup_rtti_type): Update.
6799         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6800         * psymtab.c (psym_lookup_symbol): Make "block" const.
6801         (maintenance_check_psymtabs): Make "b" const.
6802         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6803         (enumerate_locals, enumerate_args): Update.
6804         * python/py-symtab.c (stpy_global_block): Make "block" const.
6805         (stpy_static_block): Likewise.
6806         * inline-frame.c (block_starting_point_at): Make "new_block"
6807         const.
6808         * block.c (find_block_in_blockvector): Make return type const.
6809         (blockvector_for_pc_sect): Make "b" const.
6810         (find_block_in_blockvector): Make "b" const.
6811
6812 2019-03-23  Tom Tromey  <tom@tromey.com>
6813
6814         * varobj.c (varobj_create): Update.
6815         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6816         * printcmd.c (display_command, do_one_display): Don't reset
6817         innermost_block.
6818         * parser-defs.h (enum innermost_block_tracker_type): Move to
6819         expression.h.
6820         (innermost_block): Update comment.
6821         * parse.c (parse_exp_1): Add tracker_types parameter.
6822         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6823         tracker_types parameter.  Reset innermost_block.
6824         (parse_exp_in_context): Remove.
6825         (parse_expression_for_completion): Update.
6826         * objfiles.c (~objfile): Don't reset expression_context_block or
6827         innermost_block.
6828         * expression.h (enum innermost_block_tracker_type): Move from
6829         parser-defs.h.
6830         (parse_exp_1): Add tracker_types parameter.
6831         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6832         reset innermost_block.
6833
6834 2019-03-23  Tom Tromey  <tom@tromey.com>
6835
6836         * objfiles.h: Include bcache.h.
6837
6838 2019-03-23  Tom Tromey  <tom@tromey.com>
6839
6840         * linespec.c (get_current_search_block): Use
6841         scoped_restore_current_language.
6842         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6843
6844 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6845             Jiong Wang  <jiong.wang@arm.com>
6846
6847         * aarch64-linux-tdep.c
6848         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6849         section.
6850         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6851
6852 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6853             Jiong Wang  <jiong.wang@arm.com>
6854
6855         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6856         instructions.
6857         (aarch64_analyze_prologue_test): Add PACIASP test.
6858         (aarch64_prologue_prev_register): Unmask PC value.
6859
6860 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6861             Jiong Wang  <jiong.wang@arm.com>
6862
6863         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6864         (aarch64_dwarf2_prev_register): Unmask PC value.
6865         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6866         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6867         DW_CFA_AARCH64_negate_ra_state.
6868         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6869
6870 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6871             Jiong Wang  <jiong.wang@arm.com>
6872
6873         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6874         registers.
6875         (aarch64_pseudo_register_name): Likewise.
6876         (aarch64_pseudo_register_type): Likewise.
6877         (aarch64_pseudo_register_reggroup_p): Likewise.
6878         (aarch64_gdbarch_init): Add pauth registers.
6879         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6880         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6881         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6882         (struct gdbarch_tdep): Add regnum for ra_state.
6883
6884 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6885             Jiong Wang  <jiong.wang@arm.com>
6886
6887         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6888
6889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6890             Jiong Wang  <jiong.wang@arm.com>
6891
6892         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6893         function.
6894         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6895         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6896         (aarch64_gdbarch_init): Add puth registers.
6897         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6898         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6899         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6900
6901 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6902             Jiong Wang  <jiong.wang@arm.com>
6903
6904         * aarch64-linux-nat.c
6905         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6906         * aarch64-linux-tdep.c
6907         (aarch64_linux_core_read_description): Likewise.
6908         (aarch64_linux_get_hwcap): New function.
6909         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6910         (aarch64_linux_get_hwcap): New declaration.
6911
6912 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6913             Jiong Wang  <jiong.wang@arm.com>
6914
6915         * aarch64-linux-nat.c
6916         (aarch64_linux_nat_target::read_description): Add pauth param.
6917         * aarch64-linux-tdep.c
6918         (aarch64_linux_core_read_description): Likewise.
6919         * aarch64-tdep.c (struct target_desc): Add in pauth.
6920         (aarch64_read_description): Add pauth param.
6921         (aarch64_gdbarch_init): Likewise.
6922         * aarch64-tdep.h (aarch64_read_description): Likewise.
6923         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6924         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6925         * features/Makefile: Add new files.
6926         * features/aarch64-pauth.c: New file.
6927         * features/aarch64-pauth.xml: New file.
6928
6929 2019-03-20  Tom Tromey  <tromey@adacore.com>
6930
6931         * infrun.c (handle_inferior_event): Rename from
6932         handle_inferior_event_1.  Create a scoped_value_mark.
6933         (handle_inferior_event): Remove.
6934
6935 2019-03-19  Tom Tromey  <tromey@adacore.com>
6936
6937         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6938         * infrun.h (print_stop_event): Add "displays" parameter.
6939         * infrun.c (print_stop_event): Add "displays" parameter.
6940
6941 2019-03-19  Pedro Alves  <palves@redhat.com>
6942
6943         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6944         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6945         to -1.  Fix TABs vs spaces.
6946         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6947         * tui/tui-out.h (tui_ui_out) Add intro comments.
6948         <m_line, m_start_of_line>: In-class initialize, and add describing
6949         comment.
6950
6951 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6952
6953         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6954         variable names.
6955         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6956
6957 2019-03-18  Pedro Alves  <palves@redhat.com>
6958             Eli Zaretskii <eliz@gnu.org>
6959
6960         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6961         m_line and m_start_of_line.
6962
6963 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6964
6965         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6966         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6967         it returns a newline.  This fixes a regression in TU mode, whereby
6968         the next line is output on the same screen line as the user input.
6969
6970 2019-03-18  Tom Tromey  <tromey@adacore.com>
6971
6972         * minsyms.c (minimal_symbol_reader::install): Remove call to
6973         obstack_blank.
6974
6975 2019-03-18  Pedro Alves  <palves@redhat.com>
6976
6977         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6978         New globals.
6979         (apply_style): New, factored out from ...
6980         (apply_ansi_escape): ... this.  Handle reverse video mode.
6981         (tui_set_reverse_mode): New function.
6982         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6983         * tui/tui-winsource.c (tui_show_source_line): Use
6984         tui_set_reverse_mode instead of setting A_STANDOUT.
6985         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6986         New setter methods.
6987
6988 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6989
6990         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6991         Handle tabs.
6992
6993 2019-03-18  Tom Tromey  <tromey@adacore.com>
6994
6995         * ada-lang.c (empty_array): Add "high" parameter.
6996         (ada_evaluate_subexp): Update.
6997
6998 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6999
7000         * unittests/string_view-selftests.c: Define
7001         _initialize_string_view_selftests unconditionally.
7002
7003 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7004
7005         PR gdb/24350
7006         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7007
7008 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7009
7010         PR gdb/24351
7011         * windows-nat.c (display_selector): Fix format specifiers.
7012
7013 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7014
7015         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7016         tui_refill_source_window instead of tui_refresh_win, to update the
7017         current execution line.  This fixes redisplay of the current line
7018         when stepping through the code with "next" or "step".
7019
7020 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7021
7022         * source-cache.c (source_cache::get_source_lines): Call
7023         find_source_lines to initialize s->nlines.  This fixes vertical
7024         scrolling of TUI source window when the DOWN arrow is pressed.
7025
7026 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7027
7028         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7029         linux-thread-db.c (_initialize_thread_db): Likewise.
7030
7031 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7032
7033         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7034         wclrtoeol in tui_show_source_line".  This reverts changes made in
7035         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7036
7037 2019-03-15  Tom Tromey  <tom@tromey.com>
7038
7039         * symtab.h (struct minimal_symbol): Derive from
7040         general_symbol_info.
7041         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7042         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7043         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7044         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7045         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7046         (MSYMBOL_SEARCH_NAME): Update.
7047         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7048         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7049         * minsyms.c (minimal_symbol_reader::record_full): Update.
7050
7051 2019-03-15  Tom Tromey  <tom@tromey.com>
7052
7053         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7054
7055 2019-03-15  Tom Tromey  <tom@tromey.com>
7056
7057         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7058         unique_xmalloc_ptr.
7059         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7060         Update.
7061         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7062         (build_minimal_symbol_hash_tables)
7063         (minimal_symbol_reader::install): Update.
7064
7065 2019-03-15  Tom Tromey  <tom@tromey.com>
7066
7067         * symtab.c (create_demangled_names_hash): Update.
7068         (symbol_set_names): Update.
7069         * objfiles.h (struct objfile_per_bfd_storage)
7070         <demangled_names_hash>: Now an htab_up.
7071         * objfiles.c (objfile_per_bfd_storage): Simplify.
7072
7073 2019-03-15  Tom Tromey  <tom@tromey.com>
7074
7075         * objfiles.h (struct objfile_per_bfd_storage): Declare
7076         destructor.
7077         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7078         New.
7079         (get_objfile_bfd_data): Use new.  Don't initialize
7080         language_of_main.
7081         (free_objfile_per_bfd_storage): Remove.
7082         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7083
7084 2019-03-15  Tom Tromey  <tom@tromey.com>
7085
7086         * symfile.c (reread_symbols): Update.
7087         * objfiles.c (objfile::objfile): Update.
7088         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7089         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7090         comment.
7091         (minimal_symbol_reader::install): Update.
7092         (terminate_minimal_symbol_table): Remove.
7093         * jit.c (jit_object_close_impl): Update.
7094
7095 2019-03-15  Tom Tromey  <tom@tromey.com>
7096
7097         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7098         initializations.
7099
7100 2019-03-15  Tom Tromey  <tom@tromey.com>
7101
7102         * objfiles.h (struct objfile_per_bfd_storage)
7103         <demangled_hash_languages>: Now a bitset.
7104         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7105         (lookup_minimal_symbol): Update.
7106
7107 2019-03-15  Tom Tromey  <tom@tromey.com>
7108
7109         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7110         Don't return the symbol.
7111         * coffread.c (record_minimal_symbol): Use record_full.
7112
7113 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7114
7115         The MS-Windows port of ncurses fails to switch to a color pair if
7116         one or both of the colors are the implicit default colors.  This
7117         change records the default colors when TUI is initialized, and
7118         then specifies them explicitly when a color pair uses the default
7119         colors.  This allows color styling in TUI mode on MS-Windows.
7120
7121         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7122         ncurses_norm_attr.
7123         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7124         colors in ncurses_norm_attr.
7125         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7126         "none", replace it with the default color recorded in
7127         ncurses_norm_attr.
7128
7129 2019-03-14  Tom Tromey  <tromey@adacore.com>
7130
7131         * source-cache.h (class source_cache) <get_source_lines>: Return
7132         std::string.
7133         * source-cache.c (source_cache::extract_lines): Handle case where
7134         first_pos==npos.  Return std::string.
7135         (source_cache::get_source_lines): Update.
7136
7137 2019-03-14  Tom Tromey  <tromey@adacore.com>
7138
7139         * NEWS: Add item for "style sources" commands.
7140         * source-cache.c (source_cache::get_source_lines): Check
7141         source_styling.
7142         * cli/cli-style.c (source_styling): New global.
7143         (_initialize_cli_style): Add "style sources" commands.
7144         (show_style_sources): New function.
7145         * cli/cli-style.h (source_styling): Declare.
7146
7147 2019-03-14  Pedro Alves  <palves@redhat.com>
7148             Tom Tromey  <tromey@adacore.com>
7149
7150         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7151         * tui/tui-winsource.c (tui_refill_source_window): New function,
7152         from...
7153         (tui_horizontal_source_scroll): ... here.  Move some logic.
7154         * cli/cli-style.c (set_style_enabled): Notify new observable.
7155         * tui/tui-hooks.c (tui_redisplay_source): New function.
7156         (tui_attach_detach_observers): Attach or detach
7157         tui_redisplay_source.
7158         * observable.h (source_styling_changed): New observable.
7159         * observable.c: Define source_styling_changed observable.
7160
7161 2019-03-13  Tom Tromey  <tromey@adacore.com>
7162
7163         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7164         (i386_gnu_nat_target::store_registers): Update.
7165         * target-debug.h (target_debug_print_std_string): New macro.
7166         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7167         * windows-tdep.c (display_one_tib): Update.
7168         * tui/tui-stack.c (tui_make_status_line): Update.
7169         * top.c (print_inferior_quit_action): Update.
7170         * thread.c (thr_try_catch_cmd): Update.
7171         (add_thread_with_info): Update.
7172         (thread_target_id_str): Update.
7173         (thr_try_catch_cmd): Update.
7174         (thread_command): Update.
7175         (thread_find_command): Update.
7176         * record-btrace.c (record_btrace_target::info_record)
7177         (record_btrace_resume_thread, record_btrace_target::resume)
7178         (record_btrace_cancel_resume, record_btrace_step_thread)
7179         (record_btrace_target::wait, record_btrace_target::wait)
7180         (record_btrace_target::wait, record_btrace_target::stop): Update.
7181         * progspace.c (print_program_space): Update.
7182         * process-stratum-target.c
7183         (process_stratum_target::thread_address_space): Update.
7184         * linux-fork.c (linux_fork_mourn_inferior)
7185         (detach_checkpoint_command, info_checkpoints_command)
7186         (linux_fork_context): Update.
7187         (linux_fork_detach): Update.
7188         (class scoped_switch_fork_info): Update.
7189         (delete_checkpoint_command): Update.
7190         * infrun.c (follow_fork_inferior): Update.
7191         (follow_fork_inferior): Update.
7192         (proceed_after_vfork_done): Update.
7193         (handle_vfork_child_exec_or_exit): Update.
7194         (follow_exec): Update.
7195         (displaced_step_prepare_throw): Update.
7196         (displaced_step_restore): Update.
7197         (start_step_over): Update.
7198         (resume_1): Update.
7199         (clear_proceed_status_thread): Update.
7200         (proceed): Update.
7201         (print_target_wait_results): Update.
7202         (do_target_wait): Update.
7203         (context_switch): Update.
7204         (stop_all_threads): Update.
7205         (restart_threads): Update.
7206         (finish_step_over): Update.
7207         (handle_signal_stop): Update.
7208         (switch_back_to_stepped_thread): Update.
7209         (keep_going_pass_signal): Update.
7210         (print_exited_reason): Update.
7211         (normal_stop): Update.
7212         * inferior.c (inferior_pid_to_str): Change return type.
7213         (print_selected_inferior): Update.
7214         (add_inferior): Update.
7215         (detach_inferior): Update.
7216         * dummy-frame.c (fprint_dummy_frames): Update.
7217         * dcache.c (dcache_info_1): Update.
7218         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7219         (btrace_fetch, btrace_clear): Update.
7220         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7221         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7222         type.
7223         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7224         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7225         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7226         * gdbarch.c, gdbarch.h: Rebuild.
7227         * gdbarch.sh (core_pid_to_str): Change return type.
7228         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7229         return type.
7230         (windows_nat_target::pid_to_str): Change return type.
7231         (windows_delete_thread): Update.
7232         (windows_nat_target::attach): Update.
7233         (windows_nat_target::files_info): Update.
7234         * target-delegates.c: Rebuild.
7235         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7236         return type.
7237         (sol_thread_target::pid_to_str): Change return type.
7238         * remote.c (class remote_target) <pid_to_str>: Change return
7239         type.
7240         (remote_target::pid_to_str): Change return type.
7241         (extended_remote_target::attach, remote_target::remote_stop_ns)
7242         (remote_target::remote_notif_remove_queued_reply)
7243         (remote_target::push_stop_reply, remote_target::disable_btrace):
7244         Update.
7245         (extended_remote_target::attach): Update.
7246         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7247         type.
7248         (gdbsim_target::pid_to_str): Change return type.
7249         * ravenscar-thread.c (struct ravenscar_thread_target)
7250         <pid_to_str>: Change return type.
7251         (ravenscar_thread_target::pid_to_str): Change return type.
7252         * procfs.c (class procfs_target) <pid_to_str>: Change return
7253         type.
7254         (procfs_target::pid_to_str): Change return type.
7255         (procfs_target::attach): Update.
7256         (procfs_target::detach): Update.
7257         (procfs_target::fetch_registers): Update.
7258         (procfs_target::store_registers): Update.
7259         (procfs_target::wait): Update.
7260         (procfs_target::files_info): Update.
7261         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7262         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7263         return type.
7264         (nto_procfs_target::pid_to_str): Change return type.
7265         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7266         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7267         return type.
7268         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7269         (exit_lwp): Update.
7270         (attach_proc_task_lwp_callback, get_detach_signal)
7271         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7272         (linux_nat_target::resume, wait_lwp, stop_callback)
7273         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7274         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7275         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7276         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7277         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7278         type.
7279         (inf_ptrace_target::attach): Update.
7280         (inf_ptrace_target::files_info): Update.
7281         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7282         type.
7283         (go32_nat_target::pid_to_str): Change return type.
7284         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7285         (gnu_nat_target::wait): Update.
7286         (gnu_nat_target::wait): Update.
7287         (gnu_nat_target::resume): Update.
7288         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7289         (fbsd_nat_target::wait): Update.
7290         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7291         type.
7292         (darwin_nat_target::attach): Update.
7293         * corelow.c (class core_target) <pid_to_str>: Change return type.
7294         (core_target::pid_to_str): Change return type.
7295         * target.c (normal_pid_to_str): Change return type.
7296         (default_pid_to_str): Likewise.
7297         (target_pid_to_str): Change return type.
7298         (target_translate_tls_address): Update.
7299         (target_announce_detach): Update.
7300         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7301         return type.
7302         (bsd_uthread_target::pid_to_str): Change return type.
7303         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7304         type.
7305         (bsd_kvm_target::pid_to_str): Change return type.
7306         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7307         return type.
7308         (aix_thread_target::pid_to_str): Change return type.
7309         * target.h (struct target_ops) <pid_to_str>: Change return type.
7310         (target_pid_to_str, normal_pid_to_str): Likewise.
7311         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7312         type.
7313         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7314         type.
7315         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7316         return type.
7317         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7318         type.
7319         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7320         type.
7321         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7322         return type.
7323
7324 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7325
7326         * NEWS: Mention that the new default MI version is 3.  Mention
7327         changes to the output of commands and events that deal with
7328         multi-location breakpoints.
7329         * breakpoint.c: Include "mi/mi-out.h".
7330         (print_one_breakpoint): Change output syntax if using MI version
7331         >= 3.
7332         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7333         New.
7334         (mi_multi_location_breakpoint_output_fixed): New.
7335         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7336         (mi_cmd_fix_multi_location_breakpoint_output): New.
7337         (mi_multi_location_breakpoint_output_fixed): New.
7338         * mi/mi-cmds.c (mi_cmds): Register command
7339         -fix-multi-location-breakpoint-output.
7340         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7341         interpreter "mi".
7342
7343 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7344
7345         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7346         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7347         instantiate mi_ui_out based on interpreter name.
7348         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7349         * mi/mi-main.c (mi_load_progress): Likewise.
7350
7351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7352
7353         * NEWS: Combine separate "New targets" sections for 8.3.
7354
7355 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7356
7357         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7358         (ppcfbsd_init_abi): Install gdbarch
7359         "fetch_tls_load_module_address" and "get_thread_local_address"
7360         methods.
7361
7362 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7363
7364         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7365         (riscv_fbsd_init_abi): Install gdbarch
7366         "fetch_tls_load_module_address" and "get_thread_local_address"
7367         methods.
7368
7369 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7370
7371         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7372         (i386fbsd_init_abi): Install gdbarch
7373         "fetch_tls_load_module_address" and "get_thread_local_address"
7374         methods.
7375
7376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7377
7378         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7379         (amd64fbsd_init_abi): Install gdbarch
7380         "fetch_tls_load_module_address" and "get_thread_local_address"
7381         methods.
7382
7383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7384
7385         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7386         (struct fbsd_pspace_data): New type.
7387         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7388         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7389         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7390         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7391         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7392
7393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7394
7395         * gdbtypes.c (lookup_struct_elt): New function.
7396         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7397         * gdbtypes.h (struct struct_elt): New type.
7398         (lookup_struct_elt): New prototype.
7399
7400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7401
7402         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7403         remove disabled code block.
7404
7405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7406
7407         * gdbarch.sh (get_thread_local_address): New method.
7408         * gdbarch.h, gdbarch.c: Regenerate.
7409         * target.c (target_translate_tls_address): Use
7410         gdbarch_get_thread_local_address if present instead of
7411         target::get_thread_local_address.
7412
7413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7414
7415         * target.h (target::get_thread_local_address): Update comment.
7416
7417 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7418
7419         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7420         objfile->separate_debug_objfile_backlink if not NULL.
7421
7422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7423
7424         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7425         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7426         (amd64bsd_store_inferior_registers): Likewise.
7427         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7428         Enable segment base registers.
7429         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7430         PT_GETFSBASE and PT_GETGSBASE.
7431         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7432         PT_SETGSBASE.
7433         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7434         segment base registers.
7435         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7436
7437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7438
7439         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7440         Update calls to i386_target_description to add 'segments'
7441         parameter.
7442         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7443         add segment base registers.
7444         * arch/i386.c (i386_create_target_description): Add 'segments'
7445         parameter to enable segment base registers.
7446         * arch/i386.h (i386_create_target_description): Likewise.
7447         * features/i386/32bit-segments.xml: New file.
7448         * features/i386/32bit-segments.c: Generate.
7449         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7450         call to i386_target_description to add 'segments' parameter.
7451         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7452         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7453         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7454         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7455         if feature is present.
7456         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7457         Add 'segments' parameter to call to i386_target_description.
7458         (i386_target_description): Add 'segments' parameter to enable
7459         segment base registers.
7460         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7461         to call to i386_target_description.
7462         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7463         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7464         Define I386_NUM_REGS.
7465         (i386_target_description): Add 'segments' parameter to enable
7466         segment base registers.
7467
7468 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7469
7470         PR/24325
7471         * source-cache.c: #undef open and close, to avoid unresolved
7472         externals during linking.
7473
7474 2019-03-12  Tom Tromey  <tromey@adacore.com>
7475
7476         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7477         const.  Add initializers.
7478         (_initialize_remote): Don't initialize ptid globals.
7479
7480 2019-03-12  Pedro Alves  <palves@redhat.com>
7481
7482         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7483
7484 2019-03-12  Pedro Alves  <palves@redhat.com>
7485
7486         * cp-name-parser.y (main): Remove unused 'len' variable.
7487
7488 2019-03-12  Tom Tromey  <tromey@adacore.com>
7489
7490         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7491         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7492
7493 2019-03-12  Tom Tromey  <tromey@adacore.com>
7494
7495         * linux-nat.c (iterate_over_lwps): Update.
7496         (stop_callback): Remove parameter.
7497         (stop_wait_callback, detach_callback, resume_set_callback)
7498         (select_singlestep_lwp_callback, set_ignore_sigint)
7499         (status_callback, resumed_callback, resume_clear_callback)
7500         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7501         data parameter.
7502         (linux_nat_target::detach, linux_nat_target::resume)
7503         (linux_stop_and_wait_all_lwps, select_event_lwp)
7504         (linux_nat_filter_event, linux_nat_wait_1)
7505         (linux_nat_target::kill, linux_nat_target::stop)
7506         (linux_nat_target::stop): Update.
7507         (linux_nat_resume_callback): Change type.
7508         (resume_stopped_resumed_lwps, count_events_callback)
7509         (select_event_lwp_callback): Likewise.
7510         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7511         * arm-linux-nat.c (struct update_registers_data): Remove.
7512         (update_registers_callback): Change type.
7513         (arm_linux_insert_hw_breakpoint1): Update.
7514         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7515         parameter.
7516         (x86_linux_dr_set_addr): Update.
7517         (x86_linux_dr_set_control): Update.
7518         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7519         (iterate_over_lwps): Use gdb::function_view.
7520         * nat/aarch64-linux-hw-point.c (struct
7521         aarch64_dr_update_callback_param): Remove.
7522         (debug_reg_change_callback): Change type.
7523         (aarch64_notify_debug_reg_change): Update.
7524         * s390-linux-nat.c (s390_refresh_per_info): Update.
7525
7526 2019-03-11  Tom Tromey  <tromey@adacore.com>
7527
7528         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7529         redundant assignment to "this_cu".
7530
7531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7532
7533         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7534
7535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7536
7537         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7538         from...
7539         (rank_one_type): ... this.
7540
7541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7542
7543         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7544         from...
7545         (rank_one_type): ... this.
7546
7547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7548
7549         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7550         from...
7551         (rank_one_type): ... this.
7552
7553 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7554
7555         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7556         from...
7557         (rank_one_type): ... this.
7558
7559 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7560
7561         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7562         from...
7563         (rank_one_type): ... this.
7564
7565 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7566
7567         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7568         from...
7569         (rank_one_type): ... this.
7570
7571 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7572
7573         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7574         from...
7575         (rank_one_type): ... this.
7576
7577 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7578
7579         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7580         from...
7581         (rank_one_type): ... this.
7582
7583 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7584
7585         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7586         from...
7587         (rank_one_type): ... this.
7588
7589 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7590
7591         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7592         from...
7593         (rank_one_type): ... this.
7594
7595 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7596
7597         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7598         from...
7599         (rank_one_type): ... this.
7600
7601 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7602
7603         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7604         from...
7605         (rank_one_type): ... this.
7606
7607 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7608
7609         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7610         inferior-events' shows the example events.
7611
7612 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7613
7614         Support styling on native MS-Windows console
7615
7616         PR/24315
7617         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7618         on MS-Windows if $TERM is not defined.
7619
7620         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7621
7622         * posix-hdep.c (gdb_console_fputs):
7623         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7624         functions.
7625         * ui-file.h (gdb_console_fputs): Add prototype.
7626
7627         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7628         back to fputs only if the former returns zero.
7629
7630 2019-03-07  Tom Tromey  <tom@tromey.com>
7631
7632         * symmisc.c (print_symbol_bcache_statistics): Update.
7633         (print_objfile_statistics): Update.
7634         * symfile.c (allocate_symtab): Update.
7635         * stabsread.c: Don't include bcache.h.
7636         * psymtab.h (struct psymbol_bcache): Don't declare.
7637         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7638         (psymbol_bcache_init, psymbol_bcache_free)
7639         (psymbol_bcache_get_bcache): Don't declare.
7640         * psymtab.c (struct psymbol_bcache): Remove.
7641         (psymtab_storage::psymtab_storage): Update.
7642         (psymtab_storage::~psymtab_storage): Update.
7643         (psymbol_bcache_init, psymbol_bcache_free)
7644         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7645         (add_psymbol_to_bcache): Update.
7646         (allocate_psymtab): Update.
7647         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7648         macro_cache>: No longer pointers.
7649         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7650         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7651         * macrotab.c (macro_bcache): Update.
7652         * macroexp.c: Don't include bcache.h.
7653         * gdbtypes.c (check_types_worklist): Update.
7654         (types_deeply_equal): Remove TRY/CATCH.  Update.
7655         * elfread.c (elf_symtab_read): Update.
7656         * dwarf2read.c: Don't include bcache.h.
7657         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7658         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7659         (print_bcache_statistics, bcache_memory_used): Don't declare.
7660         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7661         methods.  Rename all data members.
7662         * bcache.c (struct bcache): Move to bcache.h.
7663         (bcache::expand_hash_table): Rename from expand_hash_table.
7664         (bcache): Remove.
7665         (bcache::insert): Rename from bcache_full.
7666         (bcache::compare): Rename from bcache_compare.
7667         (bcache_xmalloc): Remove.
7668         (bcache::~bcache): Rename from bcache_xfree.
7669         (bcache::print_statistics): Rename from print_bcache_statistics.
7670         (bcache::memory_used): Rename from bcache_memory_used.
7671
7672 2019-03-07  Pedro Alves  <palves@redhat.com>
7673
7674         * infrun.c (normal_stop): Also check for
7675         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7676
7677 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7678
7679         * f-lang.c (value_from_host_double): Moved to...
7680         * value.c (value_from_host_double): ...here.
7681         * value.h (value_from_host_double): Declare.
7682         * guile/scm-math.c (vlscm_convert_typed_number): Use
7683         value_from_host_double.
7684         (vlscm_convert_number): Likewise.
7685         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7686         * python/py-value.c (convert_value_from_python): Likewise.
7687
7688 2019-03-06  Tom Tromey  <tom@tromey.com>
7689
7690         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7691
7692 2019-03-06  Tom Tromey  <tom@tromey.com>
7693
7694         * utils.h (free_current_contents): Don't declare.
7695         * utils.c (free_current_contents): Remove.
7696
7697 2019-03-06  Tom Tromey  <tom@tromey.com>
7698
7699         * top.c (quit_force): Update.
7700         * main.c (captured_command_loop): Update.
7701         * common/new-op.c (operator new): Update.
7702         * common/common-exceptions.c (struct catcher)
7703         <save_cleanup_chain>: Remove member.
7704         (exceptions_state_mc_init): Update.
7705         (exception_try_scope_entry): Return nullptr.
7706         (exception_try_scope_exit, exception_rethrow)
7707         (throw_exception_sjlj, throw_exception_cxx): Update.
7708         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7709         (all_cleanups, do_cleanups, discard_cleanups)
7710         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7711         (restore_cleanups, restore_final_cleanups): Don't declare.
7712         (do_final_cleanups): Remove parameter.
7713         * common/cleanups.c (cleanup_chain, make_cleanup)
7714         (make_cleanup_dtor, all_cleanups, do_cleanups)
7715         (discard_my_cleanups, discard_cleanups)
7716         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7717         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7718         (null_cleanup): Remove.
7719         (do_final_cleanups): Remove parameter.
7720
7721 2019-03-06  Tom Tromey  <tom@tromey.com>
7722
7723         * remote.c (remote_target::remote_parse_stop_reply): Use
7724         unique_xmalloc_ptr.
7725
7726 2019-03-06  Tom Tromey  <tom@tromey.com>
7727
7728         * stabsread.c (struct stabs_field_info): Rename from field_info.
7729         <list, fnlist>: Add initializers.
7730         <obstack>: New member.
7731         (read_member_functions, read_struct_fields, read_baseclasses):
7732         Allocate on obstack.  Don't use cleanups.
7733         (read_one_struct_field, read_member_functions, read_struct_fields)
7734         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7735         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7736         (read_struct_type): Update.
7737
7738 2019-03-06  Tom Tromey  <tom@tromey.com>
7739
7740         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7741         * common/filestuff.h (make_cleanup_close): Don't declare.
7742         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7743         Remove.
7744
7745 2019-03-06  Tom Tromey  <tom@tromey.com>
7746
7747         * solib-aix.c: Use make_scope_exit.
7748
7749 2019-03-06  Tom Tromey  <tom@tromey.com>
7750
7751         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7752         Use make_scope_exit.
7753
7754 2019-03-06  Tom Tromey  <tom@tromey.com>
7755
7756         * solib-svr4.c (disable_probes_interface): Remove parameter.
7757         (svr4_handle_solib_event): Use make_scope_exit.
7758
7759 2019-03-06  Tom Tromey  <tom@tromey.com>
7760
7761         * remote.c (struct stop_reply_deleter): Remove.
7762         (stop_reply_up): Update.
7763         (struct stop_reply): Derive from notif_event.  Don't typedef.
7764         <regcache>: Now a std::vector.
7765         (stop_reply_xfree): Remove.
7766         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7767         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7768         (remote_target::discard_pending_stop_replies): Use delete.
7769         (remote_target::remote_parse_stop_reply): Update.
7770         (remote_target::process_stop_reply): Update.
7771         * remote-notif.h (struct notif_event): Add virtual destructor.
7772         Remove "dtr" member.
7773         (struct notif_client) <alloc_event>: Return a unique_ptr.
7774         (notif_event_xfree): Don't declare.
7775         (notif_event_up): New typedef.
7776         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7777         (notif_event_xfree, do_notif_event_xfree): Remove.
7778         (remote_notif_state_xfree): Update.
7779
7780 2019-03-06  Tom Tromey  <tom@tromey.com>
7781
7782         * infrun.c (displaced_step_clear_cleanup): Now a
7783         forward_scope_exit type.
7784         (displaced_step_prepare_throw): Update.
7785         (displaced_step_fixup): Update.
7786
7787 2019-03-06  Tom Tromey  <tom@tromey.com>
7788
7789         * inferior.h (class inferior): Update comment.
7790         * gdbthread.h (class thread_info): Update comment.
7791
7792 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7793             Tom Tromey  <tom@tromey.com>
7794
7795         * stabsread.h (struct stab_section_list): Remove.
7796         (coffstab_build_psymtabs): Update.
7797         * dbxread.c (symbuf_sections): Now a std::vector.
7798         (sect_idx): New global.
7799         (fill_symbuf): Update.
7800         (coffstab_build_psymtabs): Change type of stabsects parameter.
7801         Update.
7802         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7803         std::vector.
7804         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7805         (coff_locate_sections): Update.
7806         (coff_symfile_read): Remove cleanups.  Update.
7807         (init_stringtab): Add storage parameter.
7808         (free_stringtab, free_stringtab_cleanup): Remove.
7809         (init_lineno): Add storage parameter.
7810         (free_linetab, free_linetab_cleanup): Remove.
7811
7812 2019-03-06  Pedro Alves  <palves@redhat.com>
7813
7814         * linux-fork.c (fork_info::clobber_regs): Delete.
7815         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7816         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7817         comment.  Adjust.
7818         (scoped_switch_fork_info::scoped_switch_fork_info)
7819         (checkpoint_command, linux_fork_context): Adjust
7820         fork_save_infrun_state calls.
7821
7822 2019-03-06  Pedro Alves  <palves@redhat.com>
7823
7824         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7825         (inf_has_multiple_threads): Return 'bool' and rewrite using
7826         inferior_info::threads().
7827
7828 2019-03-06  Pedro Alves  <palves@redhat.com>
7829
7830         * linux-fork.c: Include <list>.
7831         (fork_list): Now a std::list instance.
7832         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7833         (forks_exist_p, find_last_fork): Adjust.
7834         (new_fork): Delete.
7835         (one_fork_p): New.
7836         (add_fork): Adjust.
7837         (free_fork): Delete, folded into fork_info::~fork_info().
7838         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7839         Adjust.
7840         (init_fork_list): Delete.
7841         (linux_fork_killall, linux_fork_mourn_inferior)
7842         (linux_fork_detach, info_checkpoints_command): Adjust.
7843         (_initialize_linux_fork): No longer call init_fork_list.
7844
7845 2019-03-06  Pedro Alves  <palves@redhat.com>
7846
7847         * linux-fork.c (new_fork): New, split out of ...
7848         (add_fork): ... this.  Return void.  Move "first fork" special
7849         case from here, to ...
7850         (checkpoint_command): ... here.
7851         * linux-linux.h (add_fork): Return void.
7852
7853 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7854
7855         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7856
7857 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7858             Chris January  <chris.january@arm.com>
7859             David Lecomber  <david.lecomber@arm.com>
7860
7861         * f-exp.y: New token, UNOP_INTRINSIC.
7862         (exp): New pattern using UNOP_INTRINSIC token.
7863         (f77_keywords): Add 'abs' keyword.
7864         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7865         (value_from_host_double): New function.
7866         (evaluate_subexp_f): Support UNOP_ABS.
7867
7868 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7869
7870         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7871         types.
7872
7873 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7874
7875         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7876         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7877         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7878
7879 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7880
7881         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7882
7883 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7884             Chris January  <chris.january@arm.com>
7885
7886         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7887         * f-exp.y: Define 'KIND' token.
7888         (exp): New pattern for KIND expressions.
7889         (ptype): Handle types with a kind extension.
7890         (direct_abs_decl): Extend to spot kind extensions.
7891         (f77_keywords): Add 'kind' to the list.
7892         (push_kind_type): New function.
7893         (convert_to_kind_type): New function.
7894         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7895         * parse.c (operator_length_standard): Likewise.
7896         * parser-defs.h (enum type_pieces): Add tp_kind.
7897         * std-operator.def: Add UNOP_KIND.
7898
7899 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7900
7901         * f-exp.y (f_parse): Set yydebug.
7902
7903 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7904
7905         * f-lang.c (evaluate_subexp_f): New function.
7906         (exp_descriptor_f): New global.
7907         (f_language_defn): Use exp_descriptor_f instead of
7908         exp_descriptor_standard.
7909
7910 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7911
7912         * f-exp.y (struct token): Add comments.
7913         (dot_ops): Remove uppercase versions and the end marker.
7914         (f77_keywords): Likewise.
7915         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7916         entries in the dot_ops array are case insensitive, and use
7917         strncasecmp to compare strings.  Also some whitespace cleanup in
7918         this area.  Similar for the f77_keywords array, except entries in
7919         this list might be case sensitive.
7920
7921 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7922
7923         * f-exp.y (struct f77_boolean_val): Add comments.
7924         (boolean_values): Remove uppercase versions, and end marker.
7925         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7926         and use strncasecmp to achieve case insensitivity.  Additionally,
7927         perform whitespace cleanup around this code.
7928
7929 2019-03-06  Tom Tromey  <tromey@adacore.com>
7930
7931         * remote-sim.c (gdbsim_target_open): Use result of
7932         gdb_argv::release.
7933
7934 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7935         Dirk Schubert  <dirk.schubert@arm.com>
7936         Chris January  <chris.january@arm.com>
7937
7938         * eval.c (evaluate_subexp_standard): Call Fortran argument
7939         wrapping logic.
7940         * f-lang.c (struct value): A value which can be passed into a
7941         Fortran function call.
7942         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7943         where appropriate.
7944         (struct type): Value ready for a Fortran function call.
7945         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7946         is needed.
7947         * f-lang.h (fortran_argument_convert): Declaration.
7948         (fortran_preserve_arg_pointer): Declaration.
7949         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7950
7951 2019-03-05  Tom Tromey  <tromey@adacore.com>
7952
7953         * python/py-prettyprint.c (print_string_repr): Remove #if.
7954         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7955
7956 2019-03-05  Tom Tromey  <tromey@adacore.com>
7957
7958         * target.c (the_dummy_target): Move later.  Change type to
7959         "dummy_target".
7960         (initialize_targets): Don't initialize the_dummy_target.
7961
7962 2019-03-05  Tom Tromey  <tromey@adacore.com>
7963
7964         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7965         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7966
7967 2019-03-05  Tom Tromey  <tromey@adacore.com>
7968
7969         * windows-nat.c (windows_nat_target::attach)
7970         (windows_nat_target::detach): Don't call gdb_flush.
7971         * valprint.c (generic_val_print, val_print, val_print_string):
7972         Don't call gdb_flush.
7973         * utils.c (defaulted_query): Don't call gdb_flush.
7974         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7975         * target.c (target_announce_detach): Don't call gdb_flush.
7976         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7977         * remote.c (extended_remote_target::attach): Don't call
7978         gdb_flush.
7979         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7980         * printcmd.c (do_examine): Don't call gdb_flush.
7981         (info_display_command): Don't call gdb_flush.
7982         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7983         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7984         * memattr.c (info_mem_command): Don't call gdb_flush.
7985         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7986         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7987         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7988         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7989         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7990         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7991         (gnu_nat_target::detach): Don't call gdb_flush.
7992         * f-valprint.c (f_val_print): Don't call gdb_flush.
7993         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7994         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7995         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7996         gdb_flush.
7997         * c-valprint.c (c_val_print): Don't call gdb_flush.
7998         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7999
8000 2019-03-05  Tom Tromey  <tromey@adacore.com>
8001
8002         * varobj.c (update_dynamic_varobj_children): Update.
8003         (install_default_visualizer): Use reset, not release.
8004         * value.c (set_internalvar): Update.
8005         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8006         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8007         ATTRIBUTE_UNUSED_RESULT.
8008
8009 2019-03-05  Tom Tromey  <tromey@adacore.com>
8010
8011         * remote.c (class scoped_remote_fd) <release>: Add
8012         ATTRIBUTE_UNUSED_RESULT.
8013
8014 2019-03-05  Tom Tromey  <tromey@adacore.com>
8015
8016         * macroexp.c (struct macro_buffer) <release>: Add
8017         ATTRIBUTE_UNUSED_RESULT.
8018
8019 2019-03-05  Tom Tromey  <tromey@adacore.com>
8020
8021         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8022         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8023         ATTRIBUTE_UNUSED_RESULT.
8024
8025 2019-03-05  Tom Tromey  <tromey@adacore.com>
8026
8027         * common/scoped_fd.h (class scoped_fd) <release>: Add
8028         ATTRIBUTE_UNUSED_RESULT.
8029
8030 2019-03-05  Tom Tromey  <tromey@adacore.com>
8031
8032         * parser-defs.h (struct parser_state) <release>: Add
8033         ATTRIBUTE_UNUSED_RESULT.
8034
8035 2019-03-05  Tom Tromey  <tromey@adacore.com>
8036
8037         * utils.h (class gdb_argv) <release>: Add
8038         ATTRIBUTE_UNUSED_RESULT.
8039         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8040
8041 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8042
8043         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8044         for-loop range, to avoid compiler warnings.
8045
8046         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8047         avoid compiler warnings about unused variables.
8048
8049         * NEWS: Mention end of support for native debugging on MS-Windows
8050         before XP.
8051
8052         PR gdb/24292
8053         * common/netstuff.c:
8054         * gdbserver/gdbreplay.c
8055         * gdbserver/remote-utils.c:
8056         * ser-tcp.c:
8057         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8058         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8059         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8060         'getaddrinfo' and 'freeaddrinfo' were not available before
8061         Windows XP, and mingw.org's MinGW headers by default define
8062         _WIN32_WINNT to 0x500.
8063
8064 2019-03-01  Gary Benson <gbenson@redhat.com>
8065
8066         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8067
8068 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8069             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8070
8071         PR gdb/8527
8072         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8073         set_sigint_trap, clear_sigint_trap.
8074
8075 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8076
8077         * target.c (target_detach): Clear the regcache and the
8078         frame cache.
8079
8080 2019-02-27  Pedro Alves  <palves@redhat.com>
8081
8082         * utils.c (set_screen_size): When we cap the height/width sizes,
8083         tweak the corresponding command variable to show "unlimited":
8084
8085 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8086             Pedro Alves  <palves@redhat.com>
8087
8088         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8089         before calling rl_set_screen_size.
8090
8091 2019-02-27  Tom Tromey  <tromey@adacore.com>
8092
8093         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8094         define.
8095         * python/py-value.c: Remove Python 2.4 workaround.
8096         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8097         workaround.
8098         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8099         Python 2.4 workaround.
8100         * python/python-internal.h: Remove Python 2.4 comment.
8101         (Py_ssize_t): Don't define.
8102         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8103         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8104         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8105         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8106         * python/python.c (do_start_initialization): Remove Python 2.4
8107         workaround.
8108         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8109         (print_children): Remove Python 2.4 workaround.
8110         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8111         workaround.
8112         (CHARBUFFERPROC_NAME): Remove.
8113         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8114         Python 2.4 workaround.
8115
8116 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8117
8118         * NEWS: Note minimum Python version.
8119
8120 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8121
8122         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8123         code from these functions.  Remove corresponding ifdefs.  Use
8124         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8125         Remove gotos and target of gotos.
8126         (infpy_search_memory): Likewise.
8127
8128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8129
8130         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8131         (hppa_gdbarch_init): Don't register deleted functions with
8132         gdbarch.
8133
8134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8137         (h8300_unwind_sp): Delete.
8138         (h8300_dummy_id): Delete.
8139         (h8300_gdbarch_init): Don't register deleted functions with
8140         gdbarch.
8141
8142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8143
8144         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8145         (ft32_unwind_pc): Delete.
8146         (ft32_unwind_sp): Delete.
8147         (ft32_gdbarch_init): Don't register deleted functions with
8148         gdbarch.
8149
8150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8151
8152         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8153         (frv_unwind_pc): Delete.
8154         (frv_unwind_sp): Delete.
8155         (frv_gdbarch_init): Don't register deleted functions with
8156         gdbarch.
8157
8158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8159
8160         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8161         (riscv_unwind_pc): Delete.
8162         (riscv_unwind_sp): Delete.
8163         (riscv_gdbarch_init): Don't register deleted functions with
8164         gdbarch.
8165
8166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8167
8168         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8169         (csky_unwind_pc): Delete.
8170         (csky_unwind_sp): Delete.
8171         (csky_gdbarch_init): Don't register deleted functions with
8172         gdbarch.
8173
8174 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8175
8176         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8177         (cris_unwind_pc): Delete.
8178         (cris_unwind_sp): Delete.
8179         (cris_gdbarch_init): Don't register deleted functions with
8180         gdbarch.
8181
8182 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8185         (bfin_unwind_pc): Delete.
8186         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8187
8188 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8189
8190         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8191         (arm_unwind_pc): Delete.
8192         (arm_unwind_sp): Delete.
8193         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8194
8195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8196
8197         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8198         (arc_unwind_pc): Delete.
8199         (arc_unwind_sp): Delete.
8200         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8201
8202 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8203
8204         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8205         (alpha_unwind_pc): Delete.
8206         (alpha_gdbarch_init): Don't register deleted functions with
8207         gdbarch.
8208
8209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8210
8211         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8212         (aarch64_unwind_pc): Delete.
8213         (aarch64_unwind_sp): Delete.
8214         (aarch64_gdbarch_init): Don't register deleted functions with
8215         gdbarch.
8216
8217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8218
8219         * gdbtypes.c (type_align): Don't consider static members when
8220         computing structure alignment.
8221
8222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8223
8224         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8225         return 0 for other types.
8226         * arch-utils.c (default_type_align): Always return 0.
8227         * gdbarch.h: Regenerate.
8228         * gdbarch.sh (type_align): Extend comment.
8229         * gdbtypes.c (type_align): Add additional comments, always call
8230         gdbarch_type_align before applying the default rules.
8231         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8232         generic code will then apply a suitable default.
8233         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8234         types, return 0 for other types.
8235
8236 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8237
8238         * NEWS: Create a new section for the next release branch.
8239         Rename the section of the current branch, now that it has
8240         been cut.
8241
8242 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8243
8244         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8245         * version.in: Bump version to 8.3.50.DATE-git.
8246
8247 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8248
8249         * aix-thread.c (ptid_cmp): Remove unused variable.
8250         (get_signaled_thread): Likewise.
8251         (store_regs_user_thread): Likewise.
8252         (store_regs_kernel_thread): Likewise.
8253         (fetch_regs_kernel_thread): Remove shadowed variable.
8254
8255 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * features/riscv/32bit-cpu.xml: Add register numbers.
8258         * features/riscv/32bit-fpu.c: Regenerate.
8259         * features/riscv/32bit-fpu.xml: Add register numbers.
8260         * features/riscv/64bit-cpu.xml: Add register numbers.
8261         * features/riscv/64bit-fpu.c: Regenerate.
8262         * features/riscv/64bit-fpu.xml: Add register numbers.
8263
8264 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8265
8266         * NEWS: Mention two argument form of gdb.Value constructor.
8267         * python/py-value.c (convert_buffer_and_type_to_value): New
8268         function.
8269         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8270         Add support for handling an optional second argument.  Call
8271         convert_buffer_and_type_to_value as appropriate.
8272         * python/python-internal.h (Py_buffer_deleter): New struct.
8273         (Py_buffer_up): New typedef.
8274
8275 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8276
8277         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8278         instead of releasing ownership.
8279
8280 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8281
8282         * dwarf2read.c (open_and_init_dwp_file): Call
8283         elf_numsections instead of bfd_count_sections to initialize
8284         dwp_file->num_sections.
8285
8286 2019-02-25  Tom Tromey  <tromey@adacore.com>
8287
8288         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8289
8290 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8291
8292         * gcore.in: Add '--readnever' option when invoking GDB.
8293
8294 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8295
8296         * MAINTAINERS: Update my email address.
8297
8298 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8299
8300         * build-id.c (build_id_to_debug_bfd_1): New function.
8301         (build_id_to_debug_bfd): Look for separate debug file in
8302         sysroot.
8303
8304 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8305
8306         * gdbarch.sh: Update the copyright year range that is placed into
8307         generated files.
8308
8309 2019-02-22  Keith Seitz  <keiths@redhat.com>
8310
8311         PR symtab/23853
8312         * linespec.c (create_sals_line_offset): Search for the default
8313         symtab's filename instead of its fullname.
8314
8315 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8316
8317         * NEWS: Update style defaults.
8318
8319 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8320
8321         * main.c (captured_main_1): Disable styling in batch mode.
8322
8323 2019-02-20  Tom Tromey  <tom@tromey.com>
8324
8325         * symtab.c (symtab_symbol_info): Fix typos.
8326
8327 2019-02-20  Tom Tromey  <tromey@adacore.com>
8328
8329         * findcmd.c (_initialize_mem_search): Use upper case for
8330         metasyntactic variables.
8331
8332 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8333
8334         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8335         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8336
8337 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8338
8339         * top.h (source_file_name): Change to std::string.
8340         * top.c (source_file_name): Likewise.
8341         (command_line_input): Adjust.
8342         * cli/cli-script.c (script_from_file): Adjust.
8343
8344 2019-02-19  Tom Tromey  <tromey@adacore.com>
8345
8346         * ravenscar-thread.c
8347         (ravenscar_thread_target::update_thread_list): Don't call
8348         ada_build_task_list.
8349         * ada-lang.h (ada_build_task_list): Don't declare.
8350         * ada-tasks.c (struct ada_tasks_inferior_data)
8351         <task_list_valid_p>: Now bool.
8352         (read_known_tasks, ada_task_list_changed)
8353         (ada_tasks_invalidate_inferior_data): Update.
8354         (read_known_tasks_array): Return bool.
8355         (read_known_tasks_list): Likewise.
8356         (read_known_tasks): Return void.
8357         (ada_build_task_list): Now static.
8358
8359 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8360
8361         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8362         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8363
8364 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8365
8366         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8367         variant for ada_tasks_pspace_data_handle and
8368         ada_tasks_inferior_data_handle.
8369         (ada_tasks_pspace_data_cleanup): New function.
8370         (ada_tasks_inferior_data_cleanup): New function.
8371
8372 2019-02-17  Tom Tromey  <tom@tromey.com>
8373
8374         * macrotab.h (macro_source_fullname): Return a std::string.
8375         * macrotab.c (macro_include, check_for_redefinition)
8376         (macro_undef, macro_lookup_definition, foreach_macro)
8377         (foreach_macro_in_scope): Update.
8378         (macro_source_fullname): Return a std::string.
8379         * macrocmd.c (show_pp_source_pos): Update.
8380
8381 2019-02-17  Tom Tromey  <tom@tromey.com>
8382
8383         * macrocmd.c (show_pp_source_pos): Style the file names.
8384
8385 2019-02-17  Tom Tromey  <tom@tromey.com>
8386
8387         PR tui/24197:
8388         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8389
8390 2019-02-17  Tom Tromey  <tom@tromey.com>
8391
8392         * ada-lang.c (user_select_syms): Use filtered printing.
8393         * utils.c (wrap_style): New global.
8394         (desired_style): Remove.
8395         (emit_style_escape): Add stream parameter.
8396         (set_output_style, reset_terminal_style, prompt_for_continue):
8397         Update.
8398         (flush_wrap_buffer): Only flush gdb_stdout.
8399         (wrap_here): Set wrap_style.
8400         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8401         treat escape sequences as a character.  Change when wrap buffer is
8402         flushed.
8403         (fputs_styled): Do not set the output style when the default is
8404         requested.
8405         * ui-style.h (struct ui_file_style) <is_default>: New method.
8406         * source.c (print_source_lines_base): Emit escape sequences in one
8407         piece.
8408
8409 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8410
8411         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8412         integers and enumeration types.
8413
8414 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8415
8416         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8417         instead of lookup_symbol_in_language
8418         (do_exact_match): New function.
8419         (ada_get_symbol_name_matcher): Return do_exact_match when
8420         doing a verbatim match.
8421
8422 2019-02-15  Tom Tromey  <tromey@adacore.com>
8423
8424         * ravenscar-thread.c (ravenscar_thread_target::resume)
8425         (ravenscar_thread_target::wait): Special case wildcard requests.
8426
8427 2019-02-15  Tom Tromey  <tromey@adacore.com>
8428
8429         * ravenscar-thread.c (base_ptid): Remove.
8430         (struct ravenscar_thread_target) <close>: New method.
8431         <m_base_ptid>: New member.
8432         <update_inferior_ptid, active_task, task_is_currently_active,
8433         runtime_initialized>: Declare methods.
8434         <ravenscar_thread_target>: Add constructor.
8435         (ravenscar_thread_target::task_is_currently_active)
8436         (ravenscar_thread_target::update_inferior_ptid)
8437         (ravenscar_runtime_initialized): Rename.  Now methods.
8438         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8439         (ravenscar_thread_target::update_thread_list): Update.
8440         (ravenscar_thread_target::active_task): Now method.
8441         (ravenscar_thread_target::store_registers)
8442         (ravenscar_thread_target::prepare_to_store)
8443         (ravenscar_thread_target::prepare_to_store)
8444         (ravenscar_thread_target::mourn_inferior): Update.
8445         (ravenscar_inferior_created): Use "new" to create target.
8446         (ravenscar_thread_target::get_ada_task_ptid): Update.
8447         (_initialize_ravenscar): Don't initialize base_ptid.
8448         (ravenscar_ops): Remove global.
8449
8450 2019-02-15  Tom Tromey  <tromey@adacore.com>
8451
8452         * target.h (push_target): Declare new overload.
8453         * target.c (push_target): New overload, taking an rvalue reference.
8454         * remote.c (remote_target::open_1): Use push_target overload.
8455         * corelow.c (core_target_open): Use push_target overload.
8456
8457 2019-02-15  Tom Tromey  <tromey@adacore.com>
8458
8459         * ravenscar-thread.c (is_ravenscar_task)
8460         (ravenscar_task_is_currently_active): Return bool.
8461         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8462         (_initialize_ravenscar): Remove "(void)".
8463         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8464         Return bool.
8465
8466 2019-02-15  Tom Tromey  <tromey@adacore.com>
8467
8468         * ravenscar-thread.c (ravenscar_runtime_initializer)
8469         (has_ravenscar_runtime, get_running_thread_id)
8470         (ravenscar_thread_target::resume): Fix indentation.
8471
8472 2019-02-15  Tom Tromey  <tromey@adacore.com>
8473
8474         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8475         from ravenscar_arch_ops.
8476         (sparc_ravenscar_ops::fetch_registers)
8477         (sparc_ravenscar_ops::store_registers): Now methods.
8478         (sparc_ravenscar_prepare_to_store): Remove.
8479         (sparc_ravenscar_ops): Redefine.
8480         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8481         methods and destructor.  Remove members.
8482         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8483         (ravenscar_thread_target::store_registers)
8484         (ravenscar_thread_target::prepare_to_store): Update.
8485         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8486         Remove.
8487         (struct ppc_ravenscar_powerpc_ops): Derive from
8488         ravenscar_arch_ops.
8489         (ppc_ravenscar_powerpc_ops::fetch_registers)
8490         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8491         (ppc_ravenscar_powerpc_ops): Redefine.
8492         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8493         (ppc_ravenscar_e500_ops::fetch_registers)
8494         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8495         (ppc_ravenscar_e500_ops): Redefine.
8496         * aarch64-ravenscar-thread.c
8497         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8498         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8499         (aarch64_ravenscar_fetch_registers)
8500         (aarch64_ravenscar_store_registers): Now methods.
8501         (aarch64_ravenscar_ops): Redefine.
8502
8503 2019-02-15  Tom Tromey  <tromey@adacore.com>
8504
8505         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8506         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8507         (ravenscar_thread_target::stopped_by_watchpoint)
8508         (ravenscar_thread_target::stopped_data_address)
8509         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8510
8511 2019-02-15  Tom Tromey  <tromey@adacore.com>
8512
8513         * ravenscar-thread.c: Fix some typos.
8514
8515 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8516             Tom Tromey  <tromey@adacore.com>
8517
8518         * ada-lang.c (ada_exception_sal): Change addr_string to a
8519         std::string.
8520         (create_ada_exception_catchpoint): Update.
8521
8522 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8523             Tom Tromey  <tromey@adacore.com>
8524
8525         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8526         (bp_location_ops): Remove.
8527         (base_breakpoint_allocate_location): Update.
8528         (free_bp_location): Update.
8529         * ada-lang.c (class ada_catchpoint_location)
8530         <ada_catchpoint_location>: Remove ops parameter.
8531         (ada_catchpoint_location_dtor): Remove.
8532         (ada_catchpoint_location_ops): Remove.
8533         (allocate_location_exception): Update.
8534         * breakpoint.h (struct bp_location_ops): Remove.
8535         (class bp_location) <bp_location>: Remove bp_location_ops
8536         parameter.
8537         <~bp_location>: Add destructor.
8538         <ops>: Remove.
8539
8540 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8541             Pedro Alves  <palves@redhat.com>
8542
8543         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8544         'PATH_MAX'.
8545
8546 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8547             Samuel Thibault  <samuel.thibault@gnu.org>
8548             Thomas Schwinge  <thomas@codesourcery.com>
8549
8550         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8551         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8552
8553 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8554
8555         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8556         (check_empty): Use "const char *".
8557
8558         * gnu-nat.c (gnu_nat_target::detach): Instead of
8559         'detach_inferior (pid)' call
8560         'detach_inferior (find_inferior_pid (pid))'.
8561
8562         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8563         'nat/fork-inferior.o'.
8564         * gnu-nat.c: #include "nat/fork-inferior.h".
8565
8566         * gnu-nat.c (gnu_nat_target::detach): Instead of
8567         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8568         * gnu-nat.h: #include "inf-child.h".
8569         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8570         'i386_gnu_nat_target::fetch_registers'.
8571         (gnu_store_registers): Rename/move to
8572         'i386_gnu_nat_target::store_registers'.
8573
8574         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8575         * gnu-nat.h (mach_thread_info): New function.
8576         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8577
8578         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8579
8580 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8581
8582         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8583
8584 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8585
8586         * windows-nat.c (windows_add_thread): Add new parameter
8587         "main_thread_p" with default value set to false.  Update
8588         function documentation as well as all callers.
8589         (windows_delete_thread): Likewise.
8590         (fake_create_process): Update call to windows_add_thread.
8591         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8592         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8593         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8594         call to windows_delete_thread.
8595
8596 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8597
8598         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8599
8600 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8601
8602         * symfile.c (find_separate_debug_file): Use canonical path of
8603         sysroot with child_path instead of gdb_sysroot if it is valid.
8604
8605 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8606
8607         * symfile.c (find_separate_debug_file): Use child_path to
8608         determine if an object file is under a sysroot.
8609
8610 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8611
8612         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8613         unittests/child-path-selftests.c.
8614         * common/pathstuff.c (child_path): New function.
8615         * common/pathstuff.h (child_path): New prototype.
8616         * unittests/child-path-selftests.c: New file.
8617
8618 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8619
8620         * symfile.c (find_separate_debug_file): Look for separate debug
8621         files in debug directories under the sysroot.
8622
8623 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8624
8625         * symtab.h (struct minimal_symbol data_p): New const method.
8626         (struct minimal_symbol text_p): Likewise.
8627         * symtab.c (output_source_filename): Use file name style
8628         to print file name.
8629         (print_symbol_info): Likewise.
8630         (print_msymbol_info): Use address style to print addresses.
8631         Use function name style to print executable text symbols.
8632         (expand_symtab_containing_pc): Use data_p.
8633         (find_pc_sect_compunit_symtab): Likewise.
8634
8635 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8636
8637         * breakpoint.c (describe_other_breakpoints): Use address style
8638         to print addresses.
8639         (say_where): Likewise.
8640
8641 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8642
8643         * ada-typeprint.c (print_func_type): Print function name
8644         style to print function name.
8645         * c-typeprint.c (c_print_type_1): Likewise.
8646
8647 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8648
8649         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8650         for execve.
8651
8652 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8653
8654         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8655         type_stack.
8656
8657 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8658
8659         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8660         TYPE_CODE_REF types.
8661
8662 2019-02-08  Jim Wilson  <jimw@sifive.com>
8663
8664         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8665         (riscv_linux_fregset): New.
8666         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8667
8668 2019-02-07  Tom Tromey  <tom@tromey.com>
8669
8670         * thread.c (thread_cancel_execution_command): Update.
8671         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8672         methods.
8673         (struct thread_fsm_ops): Remove.
8674         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8675         (thread_fsm_should_stop, thread_fsm_return_value)
8676         (thread_fsm_set_finished, thread_fsm_finished_p)
8677         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8678         Don't declare.
8679         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8680         * infrun.c (clear_proceed_status_thread)
8681         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8682         (print_stop_event): Update.
8683         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8684         Add constructor.
8685         (step_command_fsm_ops): Remove.
8686         (new_step_command_fsm): Remove.
8687         (step_1): Update.
8688         (step_command_fsm::should_stop): Rename from
8689         step_command_fsm_should_stop.
8690         (step_command_fsm::clean_up): Rename from
8691         step_command_fsm_clean_up.
8692         (step_command_fsm::do_async_reply_reason): Rename from
8693         step_command_fsm_async_reply_reason.
8694         (struct until_next_fsm): Inherit from thread_fsm.  Add
8695         constructor.
8696         (until_next_fsm_ops): Remove.
8697         (new_until_next_fsm): Remove.
8698         (until_next_fsm::should_stop): Rename from
8699         until_next_fsm_should_stop.
8700         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8701         (until_next_fsm::do_async_reply_reason): Rename from
8702         until_next_fsm_async_reply_reason.
8703         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8704         constructor.  Change type of breakpoint.
8705         (finish_command_fsm_ops): Remove.
8706         (new_finish_command_fsm): Remove.
8707         (finish_command_fsm::should_stop): Rename from
8708         finish_command_fsm_should_stop.
8709         (finish_command_fsm::clean_up): Rename from
8710         finish_command_fsm_clean_up.
8711         (finish_command_fsm::return_value): Rename from
8712         finish_command_fsm_return_value.
8713         (finish_command_fsm::do_async_reply_reason): Rename from
8714         finish_command_fsm_async_reply_reason.
8715         (finish_command): Update.
8716         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8717         Add constructor.
8718         (call_thread_fsm_ops): Remove.
8719         (call_thread_fsm::call_thread_fsm): Rename from
8720         new_call_thread_fsm.
8721         (call_thread_fsm::should_stop): Rename from
8722         call_thread_fsm_should_stop.
8723         (call_thread_fsm::should_notify_stop): Rename from
8724         call_thread_fsm_should_notify_stop.
8725         (run_inferior_call, call_function_by_hand_dummy): Update.
8726         * cli/cli-interp.c (should_print_stop_to_console): Update.
8727         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8728         Add constructor.  Change type of location_breakpoint,
8729         caller_breakpoint.
8730         (until_break_fsm_ops): Remove.
8731         (new_until_break_fsm): Remove.
8732         (until_break_fsm::should_stop): Rename from
8733         until_break_fsm_should_stop.
8734         (until_break_fsm::clean_up): Rename from
8735         until_break_fsm_clean_up.
8736         (until_break_fsm::do_async_reply_reason): Rename from
8737         until_break_fsm_async_reply_reason.
8738         (until_break_command): Update.
8739         * thread-fsm.c: Remove.
8740         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8741
8742 2019-02-07  Tom Tromey  <tom@tromey.com>
8743
8744         * yy-remap.h: Add include guard.
8745         * xtensa-tdep.h: Add include guard.
8746         * xcoffread.h: Rename include guard.
8747         * varobj-iter.h: Add include guard.
8748         * tui/tui.h: Rename include guard.
8749         * tui/tui-winsource.h: Rename include guard.
8750         * tui/tui-wingeneral.h: Rename include guard.
8751         * tui/tui-windata.h: Rename include guard.
8752         * tui/tui-win.h: Rename include guard.
8753         * tui/tui-stack.h: Rename include guard.
8754         * tui/tui-source.h: Rename include guard.
8755         * tui/tui-regs.h: Rename include guard.
8756         * tui/tui-out.h: Rename include guard.
8757         * tui/tui-layout.h: Rename include guard.
8758         * tui/tui-io.h: Rename include guard.
8759         * tui/tui-hooks.h: Rename include guard.
8760         * tui/tui-file.h: Rename include guard.
8761         * tui/tui-disasm.h: Rename include guard.
8762         * tui/tui-data.h: Rename include guard.
8763         * tui/tui-command.h: Rename include guard.
8764         * tic6x-tdep.h: Add include guard.
8765         * target/waitstatus.h: Rename include guard.
8766         * target/wait.h: Rename include guard.
8767         * target/target.h: Rename include guard.
8768         * target/resume.h: Rename include guard.
8769         * target-float.h: Rename include guard.
8770         * stabsread.h: Add include guard.
8771         * rs6000-tdep.h: Add include guard.
8772         * riscv-fbsd-tdep.h: Add include guard.
8773         * regformats/regdef.h: Rename include guard.
8774         * record.h: Rename include guard.
8775         * python/python.h: Rename include guard.
8776         * python/python-internal.h: Rename include guard.
8777         * python/py-stopevent.h: Rename include guard.
8778         * python/py-ref.h: Rename include guard.
8779         * python/py-record.h: Rename include guard.
8780         * python/py-record-full.h: Rename include guard.
8781         * python/py-record-btrace.h: Rename include guard.
8782         * python/py-instruction.h: Rename include guard.
8783         * python/py-events.h: Rename include guard.
8784         * python/py-event.h: Rename include guard.
8785         * procfs.h: Add include guard.
8786         * proc-utils.h: Add include guard.
8787         * p-lang.h: Add include guard.
8788         * or1k-tdep.h: Rename include guard.
8789         * observable.h: Rename include guard.
8790         * nto-tdep.h: Rename include guard.
8791         * nat/x86-linux.h: Rename include guard.
8792         * nat/x86-linux-dregs.h: Rename include guard.
8793         * nat/x86-gcc-cpuid.h: Add include guard.
8794         * nat/x86-dregs.h: Rename include guard.
8795         * nat/x86-cpuid.h: Rename include guard.
8796         * nat/ppc-linux.h: Rename include guard.
8797         * nat/mips-linux-watch.h: Rename include guard.
8798         * nat/linux-waitpid.h: Rename include guard.
8799         * nat/linux-ptrace.h: Rename include guard.
8800         * nat/linux-procfs.h: Rename include guard.
8801         * nat/linux-osdata.h: Rename include guard.
8802         * nat/linux-nat.h: Rename include guard.
8803         * nat/linux-namespaces.h: Rename include guard.
8804         * nat/linux-btrace.h: Rename include guard.
8805         * nat/glibc_thread_db.h: Rename include guard.
8806         * nat/gdb_thread_db.h: Rename include guard.
8807         * nat/gdb_ptrace.h: Rename include guard.
8808         * nat/fork-inferior.h: Rename include guard.
8809         * nat/amd64-linux-siginfo.h: Rename include guard.
8810         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8811         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8812         * nat/aarch64-linux.h: Rename include guard.
8813         * nat/aarch64-linux-hw-point.h: Rename include guard.
8814         * mn10300-tdep.h: Add include guard.
8815         * mips-linux-tdep.h: Add include guard.
8816         * mi/mi-parse.h: Rename include guard.
8817         * mi/mi-out.h: Rename include guard.
8818         * mi/mi-main.h: Rename include guard.
8819         * mi/mi-interp.h: Rename include guard.
8820         * mi/mi-getopt.h: Rename include guard.
8821         * mi/mi-console.h: Rename include guard.
8822         * mi/mi-common.h: Rename include guard.
8823         * mi/mi-cmds.h: Rename include guard.
8824         * mi/mi-cmd-break.h: Rename include guard.
8825         * m2-lang.h: Add include guard.
8826         * location.h: Rename include guard.
8827         * linux-record.h: Rename include guard.
8828         * linux-nat.h: Add include guard.
8829         * linux-fork.h: Add include guard.
8830         * i386-darwin-tdep.h: Rename include guard.
8831         * hppa-linux-offsets.h: Add include guard.
8832         * guile/guile.h: Rename include guard.
8833         * guile/guile-internal.h: Rename include guard.
8834         * gnu-nat.h: Rename include guard.
8835         * gdb-stabs.h: Rename include guard.
8836         * frv-tdep.h: Add include guard.
8837         * f-lang.h: Add include guard.
8838         * event-loop.h: Add include guard.
8839         * darwin-nat.h: Rename include guard.
8840         * cp-abi.h: Rename include guard.
8841         * config/sparc/nm-sol2.h: Rename include guard.
8842         * config/nm-nto.h: Rename include guard.
8843         * config/nm-linux.h: Add include guard.
8844         * config/i386/nm-i386gnu.h: Rename include guard.
8845         * config/djgpp/nl_types.h: Rename include guard.
8846         * config/djgpp/langinfo.h: Rename include guard.
8847         * compile/gcc-cp-plugin.h: Add include guard.
8848         * compile/gcc-c-plugin.h: Add include guard.
8849         * compile/compile.h: Rename include guard.
8850         * compile/compile-object-run.h: Rename include guard.
8851         * compile/compile-object-load.h: Rename include guard.
8852         * compile/compile-internal.h: Rename include guard.
8853         * compile/compile-cplus.h: Rename include guard.
8854         * compile/compile-c.h: Rename include guard.
8855         * common/xml-utils.h: Rename include guard.
8856         * common/x86-xstate.h: Rename include guard.
8857         * common/version.h: Rename include guard.
8858         * common/vec.h: Rename include guard.
8859         * common/tdesc.h: Rename include guard.
8860         * common/selftest.h: Rename include guard.
8861         * common/scoped_restore.h: Rename include guard.
8862         * common/scoped_mmap.h: Rename include guard.
8863         * common/scoped_fd.h: Rename include guard.
8864         * common/safe-iterator.h: Rename include guard.
8865         * common/run-time-clock.h: Rename include guard.
8866         * common/refcounted-object.h: Rename include guard.
8867         * common/queue.h: Rename include guard.
8868         * common/ptid.h: Rename include guard.
8869         * common/print-utils.h: Rename include guard.
8870         * common/preprocessor.h: Rename include guard.
8871         * common/pathstuff.h: Rename include guard.
8872         * common/observable.h: Rename include guard.
8873         * common/netstuff.h: Rename include guard.
8874         * common/job-control.h: Rename include guard.
8875         * common/host-defs.h: Rename include guard.
8876         * common/gdb_wait.h: Rename include guard.
8877         * common/gdb_vecs.h: Rename include guard.
8878         * common/gdb_unlinker.h: Rename include guard.
8879         * common/gdb_unique_ptr.h: Rename include guard.
8880         * common/gdb_tilde_expand.h: Rename include guard.
8881         * common/gdb_sys_time.h: Rename include guard.
8882         * common/gdb_string_view.h: Rename include guard.
8883         * common/gdb_splay_tree.h: Rename include guard.
8884         * common/gdb_setjmp.h: Rename include guard.
8885         * common/gdb_ref_ptr.h: Rename include guard.
8886         * common/gdb_optional.h: Rename include guard.
8887         * common/gdb_locale.h: Rename include guard.
8888         * common/gdb_assert.h: Rename include guard.
8889         * common/filtered-iterator.h: Rename include guard.
8890         * common/filestuff.h: Rename include guard.
8891         * common/fileio.h: Rename include guard.
8892         * common/environ.h: Rename include guard.
8893         * common/common-utils.h: Rename include guard.
8894         * common/common-types.h: Rename include guard.
8895         * common/common-regcache.h: Rename include guard.
8896         * common/common-inferior.h: Rename include guard.
8897         * common/common-gdbthread.h: Rename include guard.
8898         * common/common-exceptions.h: Rename include guard.
8899         * common/common-defs.h: Rename include guard.
8900         * common/common-debug.h: Rename include guard.
8901         * common/cleanups.h: Rename include guard.
8902         * common/buffer.h: Rename include guard.
8903         * common/btrace-common.h: Rename include guard.
8904         * common/break-common.h: Rename include guard.
8905         * cli/cli-utils.h: Rename include guard.
8906         * cli/cli-style.h: Rename include guard.
8907         * cli/cli-setshow.h: Rename include guard.
8908         * cli/cli-script.h: Rename include guard.
8909         * cli/cli-interp.h: Rename include guard.
8910         * cli/cli-decode.h: Rename include guard.
8911         * cli/cli-cmds.h: Rename include guard.
8912         * charset-list.h: Add include guard.
8913         * buildsym-legacy.h: Rename include guard.
8914         * bfin-tdep.h: Add include guard.
8915         * ax.h: Rename include guard.
8916         * arm-linux-tdep.h: Add include guard.
8917         * arm-fbsd-tdep.h: Add include guard.
8918         * arch/xtensa.h: Rename include guard.
8919         * arch/tic6x.h: Add include guard.
8920         * arch/i386.h: Add include guard.
8921         * arch/arm.h: Rename include guard.
8922         * arch/arm-linux.h: Rename include guard.
8923         * arch/arm-get-next-pcs.h: Rename include guard.
8924         * arch/amd64.h: Add include guard.
8925         * arch/aarch64-insn.h: Rename include guard.
8926         * arch-utils.h: Rename include guard.
8927         * annotate.h: Add include guard.
8928         * amd64-darwin-tdep.h: Rename include guard.
8929         * aarch64-linux-tdep.h: Add include guard.
8930         * aarch64-fbsd-tdep.h: Add include guard.
8931         * aarch32-linux-nat.h: Add include guard.
8932
8933 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8934
8935         * macrotab.c (macro_define_internal): New function that
8936         factorizes macro_define_object_internal and macro_define_function
8937         code.
8938         (macro_define_object_internal): Use macro_define_internal.
8939         (macro_define_function): Likewise.
8940
8941 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8942
8943         * macrocmd.c (extract_identifier): Return
8944         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8945         callers.
8946
8947 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8948
8949         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8950
8951 2019-02-05  Tom Tromey  <tom@tromey.com>
8952
8953         * target.c (target_stack::unpush): Move assertion earlier.
8954
8955 2019-01-30  Tom Tromey  <tom@tromey.com>
8956
8957         PR python/23615:
8958         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8959         (gdbpy_parse_and_eval): Likewise.
8960         * python/python-internal.h (gdbpy_allow_threads): New class.
8961
8962 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8963
8964         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8965         (aarch64_fbsd_fpregmap): Move earlier.
8966         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8967         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8968         instead of individual calls to trad_frame_set_reg_addr.
8969         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8970         earlier.
8971         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8972         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8973         instead of individual calls to trad_frame_set_reg_addr.
8974
8975 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8976
8977         * CONTRIBUTE: Replace contribution list with wiki link.
8978
8979 2019-01-25  Tom Tromey  <tom@tromey.com>
8980
8981         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8982
8983 2019-01-25  Tom Tromey  <tom@tromey.com>
8984
8985         * xtensa-linux-nat.c: Fix common/ includes.
8986         * xml-support.h: Fix common/ includes.
8987         * xml-support.c: Fix common/ includes.
8988         * x86-linux-nat.c: Fix common/ includes.
8989         * windows-nat.c: Fix common/ includes.
8990         * varobj.h: Fix common/ includes.
8991         * varobj.c: Fix common/ includes.
8992         * value.c: Fix common/ includes.
8993         * valops.c: Fix common/ includes.
8994         * utils.c: Fix common/ includes.
8995         * unittests/xml-utils-selftests.c: Fix common/ includes.
8996         * unittests/utils-selftests.c: Fix common/ includes.
8997         * unittests/unpack-selftests.c: Fix common/ includes.
8998         * unittests/tracepoint-selftests.c: Fix common/ includes.
8999         * unittests/style-selftests.c: Fix common/ includes.
9000         * unittests/string_view-selftests.c: Fix common/ includes.
9001         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9002         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9003         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9004         * unittests/rsp-low-selftests.c: Fix common/ includes.
9005         * unittests/parse-connection-spec-selftests.c: Fix common/
9006         includes.
9007         * unittests/optional-selftests.c: Fix common/ includes.
9008         * unittests/offset-type-selftests.c: Fix common/ includes.
9009         * unittests/observable-selftests.c: Fix common/ includes.
9010         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9011         * unittests/memrange-selftests.c: Fix common/ includes.
9012         * unittests/memory-map-selftests.c: Fix common/ includes.
9013         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9014         * unittests/function-view-selftests.c: Fix common/ includes.
9015         * unittests/environ-selftests.c: Fix common/ includes.
9016         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9017         * unittests/common-utils-selftests.c: Fix common/ includes.
9018         * unittests/cli-utils-selftests.c: Fix common/ includes.
9019         * unittests/array-view-selftests.c: Fix common/ includes.
9020         * ui-file.c: Fix common/ includes.
9021         * tui/tui-io.c: Fix common/ includes.
9022         * tracepoint.h: Fix common/ includes.
9023         * tracepoint.c: Fix common/ includes.
9024         * tracefile-tfile.c: Fix common/ includes.
9025         * top.h: Fix common/ includes.
9026         * top.c: Fix common/ includes.
9027         * thread.c: Fix common/ includes.
9028         * target/waitstatus.h: Fix common/ includes.
9029         * target/waitstatus.c: Fix common/ includes.
9030         * target.h: Fix common/ includes.
9031         * target.c: Fix common/ includes.
9032         * target-memory.c: Fix common/ includes.
9033         * target-descriptions.c: Fix common/ includes.
9034         * symtab.h: Fix common/ includes.
9035         * symfile.c: Fix common/ includes.
9036         * stap-probe.c: Fix common/ includes.
9037         * spu-linux-nat.c: Fix common/ includes.
9038         * sparc-nat.c: Fix common/ includes.
9039         * source.c: Fix common/ includes.
9040         * solib.c: Fix common/ includes.
9041         * solib-target.c: Fix common/ includes.
9042         * ser-unix.c: Fix common/ includes.
9043         * ser-tcp.c: Fix common/ includes.
9044         * ser-pipe.c: Fix common/ includes.
9045         * ser-base.c: Fix common/ includes.
9046         * selftest-arch.c: Fix common/ includes.
9047         * s12z-tdep.c: Fix common/ includes.
9048         * rust-exp.y: Fix common/ includes.
9049         * rs6000-aix-tdep.c: Fix common/ includes.
9050         * riscv-tdep.c: Fix common/ includes.
9051         * remote.c: Fix common/ includes.
9052         * remote-notif.h: Fix common/ includes.
9053         * remote-fileio.h: Fix common/ includes.
9054         * remote-fileio.c: Fix common/ includes.
9055         * regcache.h: Fix common/ includes.
9056         * regcache.c: Fix common/ includes.
9057         * record-btrace.c: Fix common/ includes.
9058         * python/python.c: Fix common/ includes.
9059         * python/py-type.c: Fix common/ includes.
9060         * python/py-inferior.c: Fix common/ includes.
9061         * progspace.h: Fix common/ includes.
9062         * producer.c: Fix common/ includes.
9063         * procfs.c: Fix common/ includes.
9064         * proc-api.c: Fix common/ includes.
9065         * printcmd.c: Fix common/ includes.
9066         * ppc-linux-nat.c: Fix common/ includes.
9067         * parser-defs.h: Fix common/ includes.
9068         * osdata.c: Fix common/ includes.
9069         * obsd-nat.c: Fix common/ includes.
9070         * nat/x86-linux.c: Fix common/ includes.
9071         * nat/x86-linux-dregs.c: Fix common/ includes.
9072         * nat/x86-dregs.h: Fix common/ includes.
9073         * nat/x86-dregs.c: Fix common/ includes.
9074         * nat/ppc-linux.c: Fix common/ includes.
9075         * nat/mips-linux-watch.h: Fix common/ includes.
9076         * nat/mips-linux-watch.c: Fix common/ includes.
9077         * nat/linux-waitpid.c: Fix common/ includes.
9078         * nat/linux-ptrace.h: Fix common/ includes.
9079         * nat/linux-ptrace.c: Fix common/ includes.
9080         * nat/linux-procfs.c: Fix common/ includes.
9081         * nat/linux-personality.c: Fix common/ includes.
9082         * nat/linux-osdata.c: Fix common/ includes.
9083         * nat/linux-namespaces.c: Fix common/ includes.
9084         * nat/linux-btrace.h: Fix common/ includes.
9085         * nat/linux-btrace.c: Fix common/ includes.
9086         * nat/fork-inferior.c: Fix common/ includes.
9087         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9088         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9089         * nat/aarch64-linux.c: Fix common/ includes.
9090         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9091         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9092         * namespace.h: Fix common/ includes.
9093         * mips-linux-tdep.c: Fix common/ includes.
9094         * minsyms.c: Fix common/ includes.
9095         * mi/mi-parse.h: Fix common/ includes.
9096         * mi/mi-main.c: Fix common/ includes.
9097         * mi/mi-cmd-env.c: Fix common/ includes.
9098         * memrange.h: Fix common/ includes.
9099         * memattr.c: Fix common/ includes.
9100         * maint.h: Fix common/ includes.
9101         * maint.c: Fix common/ includes.
9102         * main.c: Fix common/ includes.
9103         * machoread.c: Fix common/ includes.
9104         * location.c: Fix common/ includes.
9105         * linux-thread-db.c: Fix common/ includes.
9106         * linux-nat.c: Fix common/ includes.
9107         * linux-fork.c: Fix common/ includes.
9108         * inline-frame.c: Fix common/ includes.
9109         * infrun.c: Fix common/ includes.
9110         * inflow.c: Fix common/ includes.
9111         * inferior.h: Fix common/ includes.
9112         * inferior.c: Fix common/ includes.
9113         * infcmd.c: Fix common/ includes.
9114         * inf-ptrace.c: Fix common/ includes.
9115         * inf-child.c: Fix common/ includes.
9116         * ia64-linux-nat.c: Fix common/ includes.
9117         * i387-tdep.c: Fix common/ includes.
9118         * i386-tdep.c: Fix common/ includes.
9119         * i386-linux-tdep.c: Fix common/ includes.
9120         * i386-linux-nat.c: Fix common/ includes.
9121         * i386-go32-tdep.c: Fix common/ includes.
9122         * i386-fbsd-tdep.c: Fix common/ includes.
9123         * i386-fbsd-nat.c: Fix common/ includes.
9124         * guile/scm-type.c: Fix common/ includes.
9125         * guile/guile.c: Fix common/ includes.
9126         * go32-nat.c: Fix common/ includes.
9127         * gnu-nat.c: Fix common/ includes.
9128         * gdbthread.h: Fix common/ includes.
9129         * gdbarch-selftests.c: Fix common/ includes.
9130         * gdb_usleep.c: Fix common/ includes.
9131         * gdb_select.h: Fix common/ includes.
9132         * gdb_bfd.c: Fix common/ includes.
9133         * gcore.c: Fix common/ includes.
9134         * fork-child.c: Fix common/ includes.
9135         * findvar.c: Fix common/ includes.
9136         * fbsd-nat.c: Fix common/ includes.
9137         * event-top.c: Fix common/ includes.
9138         * event-loop.c: Fix common/ includes.
9139         * dwarf2read.c: Fix common/ includes.
9140         * dwarf2loc.c: Fix common/ includes.
9141         * dwarf2-frame.c: Fix common/ includes.
9142         * dwarf-index-cache.c: Fix common/ includes.
9143         * dtrace-probe.c: Fix common/ includes.
9144         * disasm-selftests.c: Fix common/ includes.
9145         * defs.h: Fix common/ includes.
9146         * csky-tdep.c: Fix common/ includes.
9147         * cp-valprint.c: Fix common/ includes.
9148         * cp-support.h: Fix common/ includes.
9149         * cp-support.c: Fix common/ includes.
9150         * corelow.c: Fix common/ includes.
9151         * completer.h: Fix common/ includes.
9152         * completer.c: Fix common/ includes.
9153         * compile/compile.c: Fix common/ includes.
9154         * compile/compile-loc2c.c: Fix common/ includes.
9155         * compile/compile-cplus-types.c: Fix common/ includes.
9156         * compile/compile-cplus-symbols.c: Fix common/ includes.
9157         * command.h: Fix common/ includes.
9158         * cli/cli-dump.c: Fix common/ includes.
9159         * cli/cli-cmds.c: Fix common/ includes.
9160         * charset.c: Fix common/ includes.
9161         * build-id.c: Fix common/ includes.
9162         * btrace.h: Fix common/ includes.
9163         * btrace.c: Fix common/ includes.
9164         * breakpoint.h: Fix common/ includes.
9165         * breakpoint.c: Fix common/ includes.
9166         * ax.h:
9167         (enum agent_op): Fix common/ includes.
9168         * ax-general.c (struct aop_map): Fix common/ includes.
9169         * ax-gdb.c: Fix common/ includes.
9170         * auxv.c: Fix common/ includes.
9171         * auto-load.c: Fix common/ includes.
9172         * arm-tdep.c: Fix common/ includes.
9173         * arch/riscv.c: Fix common/ includes.
9174         * arch/ppc-linux-common.c: Fix common/ includes.
9175         * arch/i386.c: Fix common/ includes.
9176         * arch/arm.c: Fix common/ includes.
9177         * arch/arm-linux.c: Fix common/ includes.
9178         * arch/arm-get-next-pcs.c: Fix common/ includes.
9179         * arch/amd64.c: Fix common/ includes.
9180         * arch/aarch64.c: Fix common/ includes.
9181         * arch/aarch64-insn.c: Fix common/ includes.
9182         * arch-utils.c: Fix common/ includes.
9183         * amd64-windows-tdep.c: Fix common/ includes.
9184         * amd64-tdep.c: Fix common/ includes.
9185         * amd64-sol2-tdep.c: Fix common/ includes.
9186         * amd64-obsd-tdep.c: Fix common/ includes.
9187         * amd64-nbsd-tdep.c: Fix common/ includes.
9188         * amd64-linux-tdep.c: Fix common/ includes.
9189         * amd64-linux-nat.c: Fix common/ includes.
9190         * amd64-fbsd-tdep.c: Fix common/ includes.
9191         * amd64-fbsd-nat.c: Fix common/ includes.
9192         * amd64-dicos-tdep.c: Fix common/ includes.
9193         * amd64-darwin-tdep.c: Fix common/ includes.
9194         * agent.c: Fix common/ includes.
9195         * ada-lang.h: Fix common/ includes.
9196         * ada-lang.c: Fix common/ includes.
9197         * aarch64-tdep.c: Fix common/ includes.
9198
9199 2019-01-25  Tom Tromey  <tom@tromey.com>
9200
9201         * common/create-version.sh: Use common/version.h.
9202
9203 2019-01-24  Pedro Alves  <palves@redhat.com>
9204
9205         * infrun.c (signal_stop, signal_print, signal_program)
9206         (signal_catch, signal_pass): Now arrays instead of pointers.
9207         (update_signals_program_target, do_target_resume)
9208         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9209         * linux-nat.c (linux_nat_target::pass_signals)
9210         (linux_nat_target::create_inferior, linux_nat_target::attach):
9211         Adjust.
9212         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9213         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9214         * procfs.c (procfs_target::pass_signals): Adjust.
9215         * record-full.c (record_full_target::resume): Adjust.
9216         * remote.c (remote_target::pass_signals)
9217         (remote_target::program_signals): Adjust.
9218         * target-debug.h (target_debug_print_signals): Now takes a
9219         gdb::array_view as parameter.  Adjust.
9220         * target.h (target_ops) <pass_signals, program_signals>: Replace
9221         pointer and length parameters with gdb::array_view.
9222         (target_pass_signals, target_program_signals): Likewise.
9223         * target-delegates.c: Regenerate.
9224
9225 2019-01-24  Pedro Alves  <palves@redhat.com>
9226
9227         * common/forward-scope-exit.h
9228         (forward_scope_exit::forward_scope_exit): Pass arguments to
9229         m_bind_function directly, instead of creating a std::bind and
9230         copying that.
9231
9232 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9233
9234         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9235         for static members.
9236         (pass_in_v_vfp_candidate): Likewise.
9237
9238 2019-01-23  Tom Tromey  <tom@tromey.com>
9239             Pedro Alves  <palves@redhat.com>
9240
9241         * regcache.c (class regcache_invalidator): Remove.
9242         (regcache::raw_write): Use make_scope_exit.
9243
9244 2019-01-23  Tom Tromey  <tom@tromey.com>
9245
9246         * ui-out.h (class ui_out_emit_type): Update comment.
9247
9248 2019-01-23  Tom Tromey  <tom@tromey.com>
9249
9250         * infrun.c (fetch_inferior_event): Update comment.
9251
9252 2019-01-23  Tom Tromey  <tom@tromey.com>
9253             Pedro Alves  <palves@redhat.com>
9254
9255         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9256         parameter.
9257         (fetch_inferior_event): Use SCOPE_EXIT.
9258
9259
9260 2019-01-23  Tom Tromey  <tom@tromey.com>
9261             Pedro Alves  <palves@redhat.com>
9262
9263         * infrun.c (disable_thread_events): Delete.
9264         (stop_all_threads): Use SCOPE_EXIT.
9265
9266 2019-01-23  Tom Tromey  <tom@tromey.com>
9267             Pedro Alves  <palves@redhat.com>
9268
9269         * symfile.c: Include forward-scope-exit.h.
9270         (clear_symtab_users_cleanup): Replace forward declaration with
9271         a FORWARD_SCOPE_EXIT.
9272         (syms_from_objfile_1): Use the forward_scope_exit and
9273         gdb::optional instead of cleanup_function.
9274         (reread_symbols): Use the forward_scope_exit instead of
9275         cleanup_function.
9276         (clear_symtab_users_cleanup): Remove function.
9277
9278 2019-01-23  Tom Tromey  <tom@tromey.com>
9279             Pedro Alves  <palves@redhat.com>
9280
9281         * linux-nat.c: Include scope-exit.h.
9282         (cleanup_target_stop): Remove.
9283         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9284         SCOPE_EXIT.
9285
9286 2019-01-23  Tom Tromey  <tom@tromey.com>
9287             Pedro Alves  <palves@redhat.com>
9288
9289         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9290         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9291
9292 2019-01-23  Tom Tromey  <tom@tromey.com>
9293             Andrew Burgess  <andrew.burgess@embecosm.com>
9294             Pedro Alves  <palves@redhat.com>
9295
9296         * infrun.c (fetch_inferior_event): Use scope_exit.
9297         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9298         * top.c (execute_command): Use scope_exit.
9299         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9300         * utils.c (do_bpstat_clear_actions_cleanup)
9301         (make_bpstat_clear_actions_cleanup): Remove.
9302
9303 2019-01-23  Tom Tromey  <tom@tromey.com>
9304             Pedro Alves  <palves@redhat.com>
9305
9306         * infrun.c: Include "common/scope-exit.h"
9307         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9308         (wait_for_inferior): Use SCOPE_EXIT.
9309         (fetch_inferior_event): Use scope_exit.
9310
9311 2019-01-23  Tom Tromey  <tom@tromey.com>
9312             Pedro Alves  <palves@redhat.com>
9313
9314         * breakpoint.c (create_breakpoint): Remove cleanup.
9315
9316 2019-01-23  Tom Tromey  <tom@tromey.com>
9317             Andrew Burgess  <andrew.burgess@embecosm.com>
9318             Pedro Alves  <palves@redhat.com>
9319
9320 2019-01-23  Pedro Alves  <palves@redhat.com>
9321
9322         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9323
9324 2019-01-23  Pedro Alves  <palves@redhat.com>
9325             Andrew Burgess  <andrew.burgess@embecosm.com>
9326
9327         * gdbthread.h: Include "common/forward-scope-exit.h".
9328         (scoped_finish_thread_state): Redefine custom class in terms of
9329         forward_scope_exit.
9330
9331 2019-01-23  Pedro Alves  <palves@redhat.com>
9332             Andrew Burgess  <andrew.burgess@embecosm.com>
9333
9334         * common/forward-scope-exit.h: New file.
9335
9336 2019-01-23  Pedro Alves  <palves@redhat.com>
9337             Andrew Burgess  <andrew.burgess@embecosm.com>
9338             Tom Tromey  <tom@tromey.com>
9339
9340         * common/scope-exit.h: New file.
9341
9342 2019-01-23  Pedro Alves  <palves@redhat.com>
9343
9344         * common/preprocessor.h (ESC): Rename to ...
9345         (ESC_PARENS): ... this.
9346         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9347         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9348
9349 2019-01-23  Tom Tromey  <tom@tromey.com>
9350
9351         * language.h (class scoped_switch_to_sym_language_if_auto):
9352         Initialize m_lang in both cases.
9353
9354 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9355
9356         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9357         with XCNEW.
9358
9359 2019-01-22  Tom Tromey  <tom@tromey.com>
9360
9361         * corelow.c: Do not include sys/file.h.
9362
9363 2019-01-22  Tom Tromey  <tom@tromey.com>
9364
9365         * tui/tui-wingeneral.h: Include gdb_curses.h.
9366
9367 2019-01-22  Tom Tromey  <tom@tromey.com>
9368
9369         * source-cache.h (class source_cache) <get_source_lines,
9370         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9371
9372 2019-01-22  Tom Tromey  <tom@tromey.com>
9373
9374         * remote-fileio.h (struct remote_target): Declare.
9375
9376 2019-01-22  Tom Tromey  <tom@tromey.com>
9377
9378         * python/py-arch.c: Do not include py-ref.h.
9379         * python/py-bpevent.c: Do not include py-ref.h.
9380         * python/py-cmd.c: Do not include py-ref.h.
9381         * python/py-continueevent.c: Do not include py-ref.h.
9382         * python/py-event.h: Do not include py-ref.h.
9383         * python/py-evtregistry.c: Do not include py-ref.h.
9384         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9385         * python/py-frame.c: Do not include py-ref.h.
9386         * python/py-framefilter.c: Do not include py-ref.h.
9387         * python/py-function.c: Do not include py-ref.h.
9388         * python/py-infevents.c: Do not include py-ref.h.
9389         * python/py-linetable.c: Do not include py-ref.h.
9390         * python/py-objfile.c: Do not include py-ref.h.
9391         * python/py-param.c: Do not include py-ref.h.
9392         * python/py-prettyprint.c: Do not include py-ref.h.
9393         * python/py-progspace.c: Do not include py-ref.h.
9394         * python/py-symbol.c: Do not include py-ref.h.
9395         * python/py-symtab.c: Do not include py-ref.h.
9396         * python/py-type.c: Do not include py-ref.h.
9397         * python/py-unwind.c: Do not include py-ref.h.
9398         * python/py-utils.c: Do not include py-ref.h.
9399         * python/py-value.c: Do not include py-ref.h.
9400         * python/py-varobj.c: Do not include py-ref.h.
9401         * python/py-xmethods.c: Do not include py-ref.h.
9402         * python/python.c: Do not include py-ref.h.
9403         * varobj.c: Do not include py-ref.h.
9404
9405 2019-01-22  Tom Tromey  <tom@tromey.com>
9406
9407         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9408         keyword for bcache.
9409
9410 2019-01-22  Tom Tromey  <tom@tromey.com>
9411
9412         * compile/compile-cplus-types.c: Remove a comment by #include.
9413
9414 2019-01-22  Tom Tromey  <tom@tromey.com>
9415
9416         * compile/gcc-c-plugin.h: Include compile-internal.h.
9417
9418 2019-01-22  Tom Tromey  <tom@tromey.com>
9419
9420         * stabsread.c (EXTERN): Do not define.
9421         (symnum, next_symbol_text_func, processing_gcc_compilation)
9422         (within_function, global_sym_chain, global_stabs)
9423         (previous_stab_code, this_object_header_files)
9424         (n_this_object_header_files)
9425         (n_allocated_this_object_header_files): Define.
9426         * stabsread.h (EXTERN): Never define.  Use "extern".
9427
9428 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9429
9430         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9431         history_value.
9432
9433 2019-01-21  Tom Tromey  <tom@tromey.com>
9434
9435         * ui-out.c: Fix includes.
9436         * tui/tui-source.c: Fix includes.
9437         * target.c: Fix includes.
9438         * remote.c: Fix includes.
9439         * regcache.c: Fix includes.
9440         * python/py-block.c: Fix includes.
9441         * printcmd.c: Fix includes.
9442         * or1k-tdep.c: Fix includes.
9443         * mi/mi-main.c: Fix includes.
9444         * m32r-tdep.c: Fix includes.
9445         * csky-tdep.c: Fix includes.
9446         * compile/compile-cplus-types.c: Fix includes.
9447         * cli/cli-interp.c: Fix includes.
9448
9449 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9450
9451         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9452         for padding.
9453
9454 2019-01-16  Tom Tromey  <tom@tromey.com>
9455
9456         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9457         earlier.
9458         (struct objfile) <msymbols_range>: Move from top level.
9459         <msymbols>: New method.
9460         (class objfile_msymbols): Remove.
9461         * symtab.c (default_collect_symbol_completion_matches_break_on):
9462         Update.
9463         * symmisc.c (dump_msymbols): Update.
9464         * stabsread.c (scan_file_globals): Update.
9465         * objc-lang.c (info_selectors_command, info_classes_command)
9466         (find_methods): Update.
9467         * minsyms.c (find_solib_trampoline_target): Update.
9468         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9469         * coffread.c (coff_symfile_read): Update.
9470         * ada-lang.c (ada_lookup_simple_minsym)
9471         (ada_collect_symbol_completion_matches): Update.
9472
9473 2019-01-16  Tom Tromey  <tom@tromey.com>
9474
9475         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9476         type.  Remove no-argument constructor.
9477         <iterator::operator++>: Simplify.
9478         <begin>: Update.
9479         <end>: Use minimal_symbol_count.
9480
9481 2019-01-16  Tom Tromey  <tom@tromey.com>
9482
9483         * objfiles.h (struct objfile) <psymtabs>: New method.
9484         (class objfile_psymtabs): Remove.
9485         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9486         typedef.
9487         <range>: New method.
9488         (require_partial_symbols): Change return type.
9489         * psymtab.c (require_partial_symbols)
9490         (psym_expand_symtabs_matching): Update.
9491         * mdebugread.c (parse_partial_symbols): Update.
9492         * dbxread.c (dbx_end_psymtab): Update.
9493
9494 2019-01-15  Tom Tromey  <tom@tromey.com>
9495
9496         * symtab.c (lookup_objfile_from_block)
9497         (lookup_symbol_in_objfile_symtabs)
9498         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9499         (find_line_symtab, info_sources_command)
9500         (default_collect_symbol_completion_matches_break_on)
9501         (make_source_files_completion_list): Update.
9502         * symmisc.c (print_objfile_statistics, dump_objfile)
9503         (maintenance_print_symbols, maintenance_info_symtabs)
9504         (maintenance_check_symtabs, maintenance_info_line_tables):
9505         Update.
9506         * source.c (select_source_symtab)
9507         (forget_cached_source_info_for_objfile): Update.
9508         * objfiles.h (class objfile_compunits): Remove.
9509         (struct objfile) <compunits_range>: New typedef.
9510         (compunits): New method.
9511         * objfiles.c (objfile_relocate1): Update.
9512         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9513         * maint.c (count_symtabs_and_blocks): Update.
9514         * linespec.c (iterate_over_all_matching_symtabs): Update.
9515         * cp-support.c (add_symbol_overload_list_qualified): Update.
9516         * coffread.c (coff_symtab_read): Update.
9517         * ada-lang.c (add_nonlocal_symbols)
9518         (ada_collect_symbol_completion_matches)
9519         (ada_add_global_exceptions): Update.
9520
9521 2019-01-15  Tom Tromey  <tom@tromey.com>
9522
9523         * progspace.h (program_space) <objfiles_safe_range>: New
9524         typedef.
9525         <objfiles_safe>: New method.
9526         * objfiles.h (class all_objfiles_safe): Remove.
9527         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9528         * jit.c (jit_inferior_exit_hook): Update.
9529
9530 2019-01-17  Tom Tromey  <tom@tromey.com>
9531
9532         * progspace.h (program_space) <objfiles_range>: New typedef.
9533         <objfiles>: New method.
9534         <objfiles_head>: Rename from objfiles.
9535         (object_files): Update.
9536         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9537         * guile/scm-pretty-print.c
9538         (ppscm_find_pretty_printer_from_objfiles): Update.
9539         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9540         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9541         Update.
9542         * python/py-progspace.c (pspy_get_objfiles): Update.
9543         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9544         Update.
9545         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9546         (objfpy_lookup_objfile_by_build_id): Update.
9547         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9548         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9549         Update.
9550         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9551         (expand_symtab_containing_pc, lookup_objfile_from_block)
9552         (lookup_static_symbol, basic_lookup_transparent_type)
9553         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9554         (find_line_symtab, info_sources_command)
9555         (default_collect_symbol_completion_matches_break_on)
9556         (make_source_files_completion_list, find_main_name): Update.
9557         * symmisc.c (print_symbol_bcache_statistics)
9558         (print_objfile_statistics, maintenance_print_symbols)
9559         (maintenance_print_msymbols, maintenance_print_objfiles)
9560         (maintenance_info_symtabs, maintenance_check_symtabs)
9561         (maintenance_expand_symtabs, maintenance_info_line_tables):
9562         Update.
9563         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9564         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9565         (map_overlay_command, unmap_overlay_command)
9566         (simple_overlay_update, expand_symtabs_matching)
9567         (map_symbol_filenames): Update.
9568         * symfile-debug.c (set_debug_symfile): Update.
9569         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9570         Update.
9571         * source.c (select_source_symtab, forget_cached_source_info):
9572         Update.
9573         * solib.c (solib_read_symbols): Update.
9574         * solib-spu.c (append_ocl_sos): Update.
9575         * psymtab.c (maintenance_print_psymbols)
9576         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9577         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9578         * printcmd.c (info_symbol_command): Update.
9579         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9580         Update.
9581         * objfiles.h (class all_objfiles): Remove.
9582         * objfiles.c (have_partial_symbols, have_full_symbols)
9583         (have_minimal_symbols, qsort_cmp, update_section_map)
9584         (shared_objfile_contains_address_p)
9585         (default_iterate_over_objfiles_in_search_order): Update.
9586         * objc-lang.c (info_selectors_command, info_classes_command)
9587         (find_methods): Update.
9588         * minsyms.c (find_solib_trampoline_target): Update.
9589         * maint.c (maintenance_info_sections)
9590         (maintenance_translate_address, count_symtabs_and_blocks):
9591         Update.
9592         * main.c (captured_main_1): Update.
9593         * linux-thread-db.c (try_thread_db_load_from_pdir)
9594         (has_libpthread): Update.
9595         * linespec.c (iterate_over_all_matching_symtabs)
9596         (search_minsyms_for_name): Update.
9597         * jit.c (jit_find_objf_with_entry_addr): Update.
9598         * hppa-tdep.c (find_unwind_entry)
9599         (hppa_lookup_stub_minimal_symbol): Update.
9600         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9601         Update.
9602         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9603         (elf_gnu_ifunc_resolve_by_got): Update.
9604         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9605         * dwarf-index-write.c (save_gdb_index_command): Update.
9606         * cp-support.c (add_symbol_overload_list_qualified): Update.
9607         * breakpoint.c (create_overlay_event_breakpoint)
9608         (create_longjmp_master_breakpoint)
9609         (create_std_terminate_master_breakpoint)
9610         (create_exception_master_breakpoint): Update.
9611         * blockframe.c (find_pc_partial_function): Update.
9612         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9613         (ada_collect_symbol_completion_matches)
9614         (ada_add_global_exceptions): Update.
9615
9616 2019-01-17  Tom Tromey  <tom@tromey.com>
9617
9618         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9619         declare VEC.
9620         (solib_target_parse_libraries): Change return type.
9621         (library_list_start_segment, library_list_start_section)
9622         (library_list_end_library, library_list_start_library); Update.
9623         (solib_target_free_library_list): Remove.
9624         (solib_target_parse_libraries): Remove cleanup.  Change return
9625         type.
9626         (solib_target_current_sos): Update.
9627
9628 2019-01-17  Tom Tromey  <tromey@bapiya>
9629
9630         * valprint.c: Replace "the the" with "the".
9631         * symtab.c: Replace "the the" with "the".
9632         * solib.c: Replace "the the" with "the".
9633         * solib-dsbt.c: Replace "the the" with "the".
9634         * linespec.c: Replace "the the" with "the".
9635         * dwarf2loc.h: Replace "the the" with "the".
9636         * amd64-windows-tdep.c: Replace "the the" with "the".
9637         * aarch64-tdep.c: Replace "the the" with "the".
9638
9639 2019-01-16  Keith Seitz  <keiths@redhat.com>
9640
9641         PR gdb/23773
9642         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9643         <builder>: Rename to ..
9644         <m_builder>: ... this and make private.
9645         (dwarf2_cu::get_builder): New method.  Change all users of
9646         `builder' to use this method.
9647         (dwarf2_start_symtab): Move to ...
9648         (dwarf2_cu::start_symtab): ... here.  Update all callers
9649         (setup_type_unit_groups): Move to ...
9650         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9651         callers.
9652         (dwarf2_cu::reset_builder): New method.
9653         (process_full_compunit, process_full_type_unit): Use
9654         dwarf2_cu::reset_builder.
9655         (follow_die_offset): Record the ancestor CU if it is different
9656         from the followed DIE's CU.
9657         (follow_die_sig_1): Likewise.
9658
9659 2019-01-15  Tom Tromey  <tom@tromey.com>
9660
9661         * remote.c (class remote_state) <buf>: Now a char_vector.
9662         <buf_size>: Remove.
9663         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9664         parameter.
9665         (remote_target::getpkt_or_notif_sane_1)
9666         (remote_target::getpkt_sane)
9667         (remote_target::getpkt_or_notif_sane): Likewise.
9668         (class remote_target) <putpkt>: New overload.
9669         (remote_target::read_frame): Change type of "buf_p".  Remove
9670         sizeof_p parameter.
9671         (packet_ok): New overload.
9672         (packet_check_result): New overload.
9673         Update all uses.
9674
9675 2019-01-14  Tom Tromey  <tom@tromey.com>
9676
9677         * remote-notif.c (handle_notification, remote_notif_ack)
9678         (remote_notif_parse): Make "buf" const.
9679         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9680         const.
9681         (remote_notif_parse, remote_notif_ack, handle_notification):
9682         Likewise.
9683         * remote.c (remote_notif_stop_parse): Make "buf" const.
9684         (remote_target::remote_parse_stop_reply): Make "buf" const.
9685         (remote_notif_stop_ack): Make "buf" const.
9686
9687 2019-01-14  Tom Tromey  <tom@tromey.com>
9688
9689         * remote.c (remote_console_output): Make parameter const.
9690
9691 2019-01-14  Tom Tromey  <tom@tromey.com>
9692
9693         * target-debug.h (target_debug_print_signals): Constify.
9694         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9695         * procfs.c (procfs_target::pass_signals): Update.
9696         * linux-nat.c (linux_nat_target::pass_signals): Update.
9697         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9698         * target-delegates.c: Rebuild.
9699         * remote.c (remote_target::program_signals): Update.
9700         (remote_target::pass_signals): Update.
9701         * target.c (target_pass_signals): Constify argument.
9702         (target_program_signals): Likewise.
9703         * target.h (struct target_ops) <pass_signals, program_signals>:
9704         Constify argument.
9705         (target_pass_signals, target_program_signals): Constify argument.
9706
9707 2019-01-14  Tom Tromey  <tom@tromey.com>
9708
9709         PR tui/28819:
9710         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9711
9712 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9713
9714         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9715         field.
9716         * rs6000-tdep.c: Include reggroups.h.
9717         (IS_V_ALIAS_PSEUDOREG): Define.
9718         (rs6000_register_name): Return names for the "vX" aliases.
9719         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9720         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9721         aliases.  Call default_register_reggroup_p for all other
9722         pseudo-registers.
9723         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9724         New functions.
9725         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9726         Handle "vX" aliases.
9727         (v_alias_pseudo_register_collect): New function.
9728         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9729         (rs6000_gdbarch_init): Initialize "vX" aliases as
9730         pseudo-registers.  Restore registration of
9731         rs6000_pseudo_register_reggroup_p with
9732         set_tdesc_pseudo_register_reggroup_p.
9733
9734 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9735
9736         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9737         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9738         set_gdbarch_num_pseudo_regs.
9739
9740 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9741
9742         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9743         Remove arg prefixname, add do_set and do_show.
9744         Add member functions set_list and show_list.
9745         * cli/cli-style.c (class cli_style_option): Update accordingly.
9746         (style_set_list): Move to file scope.
9747         (style_show_list): Likewise.
9748         (set_style): Call help_list.
9749         (show_style): Call cmd_show_list.
9750         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9751         Update to use the new macro.
9752
9753 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9754
9755         * ada-lang.c (_initialize_ada_language): Expand the help text
9756         for the "catch exception" command.
9757
9758 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9759
9760         * symtab.c (matching_obj_sections): Initialize obj,
9761         declare it closer to its usage.
9762
9763 2019-01-10  Tom Tromey  <tom@tromey.com>
9764
9765         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9766         (basic_inf_threads_range): Remove.
9767         (inf_threads_range, inf_non_exited_threads_range)
9768         (safe_inf_threads_range): Use next_adapter.
9769
9770 2019-01-10  Keith Seitz  <keiths@redhat.com>
9771
9772         PR gdb/23712
9773         PR symtab/23010
9774         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9775         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9776
9777 2019-01-10  Keith Seitz  <keiths@redhat.com>
9778
9779         PR gdb/23712
9780         PR symtab/23010
9781         * dictionary.c (pending_to_vector): Remove.
9782         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9783         Remove _1 suffix, replacing functions of the same name.  Update
9784         all callers.
9785         (dict_create_hashed, dict_create_hashed_expandable)
9786         (dict_create_linear, dict_create_linear_expandable, dict_free)
9787         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9788         Make functions static.
9789
9790 2019-01-10  Keith Seitz  <keiths@redhat.com>
9791
9792         PR gdb/23712
9793         PR symtab/23010
9794         * dictionary.h (struct dictionary): Replace declaration with
9795         multidictionary.
9796         (dict_create_hashed, dict_create_hashed_expandable)
9797         (dict_create_linear, dict_create_linear_expandable)
9798         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9799         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9800         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9801         taking multidictionary argument.
9802         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9803         * block.h (struct block) <dict>: Change to multidictionary
9804         and rename `multidict'.
9805         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9806         symmisc.c: Update all dictionary references to multidictionary.
9807
9808 2019-01-10  Keith Seitz  <keiths@redhat.com>
9809
9810         PR gdb/23712
9811         PR symtab/23010
9812         * dictionary.c: Include unordered_map.
9813         (pending_to_vector): New function.
9814         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9815         Rewrite the non-"_1" functions to take vector instead
9816         of linked list.
9817         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9818         "new" _1 versions of the same name.
9819         (multidictionary): Define.
9820         (std::hash<enum language): New definition.
9821         (collate_pending_symbols_by_language, mdict_create_hashed)
9822         (mdict_create_hashed_expandable, mdict_create_linear)
9823         (mdict_create_linear_expandable, mdict_free)
9824         (find_language_dictionary, create_new_language_dictionary)
9825         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9826         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9827         (mdict_size, mdict_empty): New functions.
9828         * dictionary.h (mdict_iterator): Define.
9829
9830 2019-01-10  Pedro Alves  <palves@redhat.com>
9831
9832         * breakpoint.c (read_uploaded_action)
9833         (create_tracepoint_from_upload): Adjust to use
9834         gdb::unique_xmalloc_ptr.
9835         * ctf.c (ctf_write_uploaded_tp):
9836         (SET_ARRAY_FIELD): Use emplace_back.
9837         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9838         * tracefile-tfile.c (tfile_write_uploaded_tp):
9839         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9840         gdb::unique_xmalloc_ptr.
9841         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9842         at_string, cond_string, cmd_strings>: Replace char pointers
9843         with gdb::unique_xmalloc_ptr.
9844
9845 2019-01-10  Pedro Alves  <palves@redhat.com>
9846
9847         * solib-target.c (library_list_start_library): Don't xstrdup name.
9848
9849 2019-01-10  Pedro Alves  <palves@redhat.com>
9850
9851         * mdebugread.c (parse_partial_symbols): Use
9852         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9853
9854 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9855
9856         * linux-fork.c (scoped_switch_fork_info)
9857         <~scoped_switch_fork_info>: Fix incorrect variable name.
9858
9859 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9860
9861         * linux-fork.c (scoped_switch_fork_info)
9862         <scoped_switch_fork_info>: Make explicit.
9863         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9864
9865 2019-01-10  Tom Tromey  <tom@tromey.com>
9866
9867         * objfiles.h (objfile::reset_psymtabs): Update.
9868         * objfiles.c (objfile::objfile): Update.
9869         * psymtab.h (psymtab_storage::obstack): Update.
9870         (psymtab_storage::m_obstack): Use gdb::optional.
9871         (class psymtab_storage): Update comment.  Remove objfile
9872         parameter.
9873         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9874
9875 2019-01-10  Tom Tromey  <tom@tromey.com>
9876
9877         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9878         <free_psymtabs>: Now private.
9879         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9880         (allocate_psymtab): Use new method.
9881
9882 2019-01-10  Tom Tromey  <tom@tromey.com>
9883
9884         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9885         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9886         * mdebugread.c (parse_partial_symbols): Use
9887         allocate_dependencies.
9888         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9889         allocate_dependencies.
9890         (process_psymtab_comp_unit_reader)
9891         (build_type_psymtab_dependencies): Likewise.
9892         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9893
9894 2019-01-10  Tom Tromey  <tom@tromey.com>
9895
9896         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9897         PSYMBOL_SET_LANGUAGE.
9898         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9899
9900 2019-01-10  Tom Tromey  <tom@tromey.com>
9901
9902         * psymtab.h (psymtab_storage::obstack): New method.
9903         <m_obstack>: Rename from obstack; now private.
9904         * psymtab.c (psymtab_storage): Update.
9905         * dwarf2read.c (create_addrmap_from_index)
9906         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9907         Update.
9908
9909 2019-01-10  Tom Tromey  <tom@tromey.com>
9910
9911         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9912         * objfiles.h (objfile::reset_psymtabs): New method.
9913
9914 2019-01-10  Tom Tromey  <tom@tromey.com>
9915
9916         * symmisc.c (print_symbol_bcache_statistics): Update.
9917         (print_objfile_statistics): Update.
9918         * symfile.c (reread_symbols): Update.
9919         * psymtab.h (class psymtab_storage): New.
9920         * psymtab.c (psymtab_storage): New constructor.
9921         (~psymtab_storage): New destructor.
9922         (require_partial_symbols): Update.
9923         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9924         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9925         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9926         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9927         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9928         (start_psymtab_common, end_psymtab_common)
9929         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9930         (allocate_psymtab): Update.
9931         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9932         Update.
9933         (dump_psymtab_addrmap, maintenance_print_psymbols)
9934         (maintenance_check_psymtabs): Update.
9935         (class objfile_psymtabs): Move to objfiles.h.
9936         * psympriv.h (discard_psymtab): Now inline.
9937         (psymtab_discarder::psymtab_discarder): Update.
9938         (psymtab_discarder::~psymtab_discarder): Update.
9939         (ALL_OBJFILE_PSYMTABS): Rewrite.
9940         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9941         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9942         Remove fields.
9943         <partial_symtabs>: New field.
9944         (class objfile_psymtabs): Move from psymtab.h.  Update.
9945         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9946         psymbol_cache.
9947         (objfile::~objfile): Don't destroy psymbol_cache.
9948         * mdebugread.c (parse_partial_symbols): Update.
9949         * dwarf2read.c (create_addrmap_from_index)
9950         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9951         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9952         (add_partial_subprogram, dwarf2_ranges_read): Update.
9953         * dwarf-index-write.c (write_address_map)
9954         (write_one_signatured_type, recursively_write_psymbols)
9955         (class debug_names, class debug_names, write_psymtabs_to_index):
9956         Update.
9957
9958 2019-01-10  Tom Tromey  <tom@tromey.com>
9959
9960         * symtab.h (SYMBOL_SET_NAMES): Update.
9961         (symbol_set_names): Update.
9962         (MSYMBOL_SET_NAMES): Update.
9963         * symtab.c (symbol_set_names): Change argument to be an
9964         objfile_per_bfd_storage.
9965         * psymtab.c (add_psymbol_to_bcache): Update.
9966         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9967
9968 2019-01-10  Tom Tromey  <tom@tromey.com>
9969
9970         * symtab.c (create_demangled_names_hash): Change argument to be an
9971         objfile_per_bfd_storage.
9972         (symbol_set_names): Update.
9973
9974 2019-01-10  Tom Tromey  <tom@tromey.com>
9975
9976         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9977         init_psymbol_list.
9978         * psymtab.c (init_psymbol_list): Do nothing if already called.
9979         * psympriv.h (init_psymbol_list): Add comment.
9980         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9981         init_psymbol_list.
9982         * dbxread.c (dbx_symfile_read): Unconditionally call
9983         init_psymbol_list.
9984
9985 2019-01-10  Tom Tromey  <tom@tromey.com>
9986
9987         * xcoffread.c (scan_xcoff_symtab): Update.
9988         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9989         "where".
9990         * mdebugread.c (parse_partial_symbols)
9991         (handle_psymbol_enumerators): Update.
9992         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9993         * dbxread.c (read_dbx_symtab): Update.
9994         * psympriv.h (psymbol_placement): New enum.
9995         (add_psymbol_to_list): Update.
9996
9997 2019-01-10  Tom Tromey  <tom@tromey.com>
9998
9999         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10000         static_psymbols parameters.
10001         (scan_xcoff_symtab): Update.
10002         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10003         static_psymbols parameters.
10004         * psympriv.h (start_psymtab_common): Update.
10005         * mdebugread.c (parse_partial_symbols): Update.
10006         * dwarf2read.c (create_partial_symtab): Update.
10007         * dbxread.c (read_dbx_symtab): Update.
10008         (start_psymtab): Remove global_psymbols and static_psymbols
10009         parameters.
10010
10011 2019-01-10  Tom Tromey  <tom@tromey.com>
10012
10013         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10014         * psymtab.c (allocate_psymtab): Add comment.
10015         * psympriv.h (allocate_psymtab): Add comment.
10016         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10017         initializations.
10018         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10019
10020 2019-01-10  Tom Tromey  <tom@tromey.com>
10021
10022         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10023         Don't declare.
10024         * mipsread.c: Include mdebugread.h.
10025         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10026         Declare.
10027         * elfread.c: Include mdebugread.h.
10028
10029 2019-01-09  Tom Tromey  <tom@tromey.com>
10030
10031         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10032         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10033         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10034         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10035         (psym_lookup_symbol, psym_find_last_source_symtab)
10036         (psym_forget_cached_source_info, psym_print_stats)
10037         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10038         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10039         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10040         (psym_find_compunit_symtab_by_address)
10041         (maintenance_print_psymbols, maintenance_info_psymtabs)
10042         (maintenance_check_psymtabs): Use ranged for.
10043         * psymtab.h (class objfile_psymtabs): New.
10044         (require_partial_symbols): Return objfile_psymtabs.
10045         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10046
10047 2019-01-09  Tom Tromey  <tom@tromey.com>
10048
10049         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10050         (find_pc_mapped_section, list_overlays_command)
10051         (map_overlay_command, unmap_overlay_command)
10052         (simple_overlay_update): Use all_objfiles.
10053         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10054         * printcmd.c (info_symbol_command): Use all_objfiles.
10055         * objfiles.h (ALL_OBJSECTIONS): Remove.
10056         * maint.c (maintenance_translate_address): Use all_objfiles.
10057         * gcore.c (gcore_create_callback): Use all_objfiles.
10058         (objfile_find_memory_regions): Likewise.
10059
10060 2019-01-09  Tom Tromey  <tom@tromey.com>
10061
10062         * symtab.c (find_line_symtab, info_sources_command)
10063         (make_source_files_completion_list): Use objfile_compunits.
10064         * source.c (select_source_symtab): Use objfile_compunits.
10065         * objfiles.h (struct objfile): Update comment.
10066         (ALL_OBJFILES): Remove.
10067         (ALL_FILETABS): Remove.
10068         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10069         objfile_compunits.
10070
10071 2019-01-09  Tom Tromey  <tom@tromey.com>
10072
10073         * symmisc.c (print_objfile_statistics, dump_objfile)
10074         (maintenance_print_symbols): Use compunit_filetabs.
10075         * source.c (forget_cached_source_info_for_objfile): Use
10076         compunit_filetabs.
10077         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10078         (ALL_FILETABS): Use compunit_filetabs.
10079         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10080         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10081
10082 2019-01-09  Tom Tromey  <tom@tromey.com>
10083
10084         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10085         (compunit_filetabs): New.
10086         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10087         compunit_filetabs.
10088         (info_sources_command, make_source_files_completion_list): Remove
10089         declaration.
10090         * symmisc.c (print_objfile_statistics, dump_objfile)
10091         (maintenance_print_symbols): Remove declaration.
10092         (maintenance_info_symtabs): Use compunit_filetabs.
10093         (maintenance_info_line_tables): Likewise.
10094         * source.c (select_source_symtab): Change local variable name.
10095         (forget_cached_source_info_for_objfile): Remove declaration.
10096         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10097         * objfiles.c (objfile_relocate1): Remove declaration.
10098         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10099         declaration.
10100         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10101         * coffread.c (coff_symtab_read): Remove declaration.
10102         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10103         compunit_filetabs.
10104
10105 2019-01-09  Tom Tromey  <tom@tromey.com>
10106
10107         * symtab.c (lookup_objfile_from_block)
10108         (find_pc_sect_compunit_symtab, search_symbols)
10109         (default_collect_symbol_completion_matches_break_on): Use
10110         objfile_compunits.
10111         * objfiles.h (ALL_COMPUNITS): Remove.
10112         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10113         * cp-support.c (add_symbol_overload_list_qualified): Use
10114         objfile_compunits.
10115         * ada-lang.c (ada_collect_symbol_completion_matches)
10116         (ada_add_global_exceptions): Use objfile_compunits.
10117
10118 2019-01-09  Tom Tromey  <tom@tromey.com>
10119
10120         * source.c (select_source_symtab)
10121         (forget_cached_source_info_for_objfile): Remove declaration.
10122         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10123         declaration.
10124         * maint.c (count_symtabs_and_blocks): Remove declaration.
10125         * cp-support.c (add_symbol_overload_list_qualified): Remove
10126         declaration.
10127         * coffread.c (coff_symtab_read): Remove declaration.
10128         * symtab.c (lookup_symbol_in_objfile_symtabs)
10129         (basic_lookup_transparent_type_1): Use objfile_compunits.
10130         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10131         (info_sources_command, search_symbols)
10132         (default_collect_symbol_completion_matches_break_on)
10133         (make_source_files_completion_list): Remove declaration.
10134         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10135         (ada_collect_symbol_completion_matches)
10136         (ada_add_global_exceptions): Remove declaration.
10137         * linespec.c (iterate_over_all_matching_symtabs): Use
10138         objfile_compunits.
10139         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10140         (class objfile_compunits): New.
10141         (ALL_COMPUNITS): Use objfile_compunits.
10142         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10143         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10144         objfile_compunits.
10145         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10146
10147 2019-01-09  Tom Tromey  <tom@tromey.com>
10148
10149         * symtab.c (search_symbols)
10150         (default_collect_symbol_completion_matches_break_on): Use
10151         objfile_msymbols.
10152         * ada-lang.c (ada_lookup_simple_minsym)
10153         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10154         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10155         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10156         objfile_msymbols.
10157         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10158         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10159         * objc-lang.c (find_methods): Use objfile_msymbols.
10160         (info_selectors_command, info_classes_command): Likewise.
10161         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10162         * objfiles.h (class objfile_msymbols): New.
10163         (ALL_OBJFILE_MSYMBOLS): Remove.
10164         (ALL_MSYMBOLS): Remove.
10165
10166 2019-01-09  Tom Tromey  <tom@tromey.com>
10167
10168         * common/next-iterator.h (next_adapter): Add Iterator template
10169         parameter.
10170         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10171         (class all_objfiles_safe): New.
10172         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10173         * objfiles.c (put_objfile_before): Update comment.
10174         (add_separate_debug_objfile): Likewise.
10175         (free_all_objfiles): Use all_objfiles_safe.
10176         (objfile_purge_solibs): Likewise.
10177
10178 2019-01-09  Tom Tromey  <tom@tromey.com>
10179
10180         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10181         (expand_symtab_containing_pc, lookup_static_symbol)
10182         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10183         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10184         all_objfiles.
10185         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10186         * breakpoint.c (create_overlay_event_breakpoint)
10187         (create_longjmp_master_breakpoint)
10188         (create_std_terminate_master_breakpoint)
10189         (create_exception_master_breakpoint): Use all_objfiles.
10190         * linux-thread-db.c (try_thread_db_load_from_pdir)
10191         (has_libpthread): Use all_objfiles.
10192         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10193         * linespec.c (iterate_over_all_matching_symtabs)
10194         (search_minsyms_for_name): Use all_objfiles.
10195         * maint.c (maintenance_info_sections): Use all_objfiles.
10196         * main.c (captured_main_1): Use all_objfiles.
10197         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10198         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10199         * guile/scm-pretty-print.c
10200         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10201         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10202         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10203         (maintenance_print_msymbols): Use all_objfiles.
10204         * source.c (select_source_symtab): Use all_objfiles.
10205         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10206         * symfile.c (remove_symbol_file_command)
10207         (expand_symtabs_matching, map_symbol_filenames): Use
10208         all_objfiles.
10209         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10210         all_objfiles.
10211         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10212         * objc-lang.c (find_methods): Use all_objfiles.
10213         * objfiles.c (have_partial_symbols, have_full_symbols)
10214         (have_minimal_symbols, qsort_cmp)
10215         (default_iterate_over_objfiles_in_search_order): Use
10216         all_objfiles.
10217         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10218         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10219         (maintenance_check_psymtabs): Use all_objfiles.
10220         (ALL_PSYMTABS): Remove.
10221         * compile/compile-object-run.c (do_module_cleanup): Use
10222         all_objfiles.
10223         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10224         * cp-support.c (add_symbol_overload_list_qualified): Use
10225         all_objfiles.
10226         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10227         Use all_objfiles.
10228         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10229         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10230         all_objfiles.
10231         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10232         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10233         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10234         Uses all_objfiles.
10235         * solib.c (solib_read_symbols): Use all_objfiles
10236
10237 2019-01-09  Tom Tromey  <tom@tromey.com>
10238
10239         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10240         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10241         all_objfiles.
10242         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10243         * symmisc.c (print_symbol_bcache_statistics)
10244         (print_objfile_statistics, maintenance_print_objfiles)
10245         (maintenance_info_symtabs, maintenance_check_symtabs)
10246         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10247         all_objfiles.
10248         * source.c (forget_cached_source_info): Use all_objfiles.
10249         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10250         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10251         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10252         * objfiles.c (update_section_map): Use all_objfiles.
10253         (shared_objfile_contains_address_p): Likewise.
10254         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10255         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10256
10257 2019-01-09  Tom Tromey  <tom@tromey.com>
10258
10259         * common/next-iterator.h: New file.
10260         * objfiles.h (class all_objfiles): New.
10261         (struct objfile_iterator): New.
10262
10263 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10264
10265         * NEWS: Move the description of the changed "frame", "select-frame",
10266          and "info frame" commands to the Changed commands section.
10267
10268 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10269
10270         * gdbtypes.c (check_stub_method_group): Remove handling of old
10271         mangling schemes.
10272         * linespec.c (find_methods): Likewise.
10273         * stabsread.c (read_member_functions): Likewise.
10274         * valops.c (search_struct_method): Likewise.
10275         (value_struct_elt_for_reference): Likewise.
10276         * NEWS: Mention this change.
10277
10278 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10279
10280         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10281         print_source_lines.
10282         * source.c (print_source_lines_base): Update line number check.
10283         (print_source_lines): New function.
10284         (source_lines_range::source_lines_range): New function.
10285         * source.h (class source_lines_range): New class.
10286         (print_source_lines): New declaration.
10287
10288 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10289
10290         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10291
10292 2019-01-08  Tom Tromey  <tom@tromey.com>
10293             Simon Marchi  <simon.marchi@ericsson.com>
10294
10295         PR gdb/24060
10296         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10297         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10298         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10299         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10300         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10301         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10302
10303 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10304
10305         * source.c (select_source_symtab): Move header comment to
10306         declaration in source.h.
10307         (forget_cached_source_info_for_objfile): Likewise.
10308         (forget_cached_source_info): Likewise.
10309         (identify_source_line): Likewise.
10310         * source.h (identify_source_line): Move declaration from symtab.h
10311         and add comment from source.c
10312         (print_source_lines): Likewise.
10313         (forget_cached_source_info_for_objfile): Likewise.
10314         (forget_cached_source_info): Likewise.
10315         (select_source_symtab): Likewise.
10316         (enum print_source_lines_flag): Move definition from symtab.h.
10317         * symtab.h (identify_source_line): Move declaration to source.h.
10318         (print_source_lines): Likewise.
10319         (forget_cached_source_info_for_objfile): Likewise.
10320         (forget_cached_source_info): Likewise.
10321         (select_source_symtab): Likewise.
10322         (enum print_source_lines_flag): Move definition to source.h.
10323         * tui/tui-hooks.c: Add 'source.h' include.
10324
10325 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10326
10327         * source.c (print_source_lines_base): Handle requests to print
10328         reverse line number sequences, and guard against empty lines
10329         string.
10330
10331 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10332
10333         * source.c (print_source_lines_base): Fix skip of '\r' if next
10334         character is '\n'.
10335
10336 2019-01-06  Tom Tromey  <tom@tromey.com>
10337
10338         * c-exp.y (struct c_parse_state) <macro_original_text,
10339         expansion_obstack>: New member.
10340         (macro_original_text, expansion_obstack): Remove globals.
10341         (scan_macro_expansion, scanning_macro_expansion)
10342         (finished_macro_expansion): Update.
10343         (scan_macro_cleanup): Remove.
10344         (yylex, c_parse): Update.
10345
10346 2019-01-06  Tom Tromey  <tom@tromey.com>
10347
10348         * c-exp.y (struct c_parse_state) <strings>: New member.
10349         (operator_stoken): Update.
10350
10351 2019-01-06  Tom Tromey  <tom@tromey.com>
10352
10353         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10354         (union type_stack_elt) <typelist_val>: Now a pointer to
10355         std::vector.
10356         (type_stack_cleanup): Don't declare.
10357         (push_typelist): Update.
10358         * parse.c (pop_typelist): Return a std::vector.
10359         (push_typelist): Take a std::vector.
10360         (follow_types): Update.  Do not free args.
10361         (type_stack_cleanup): Remove.
10362         * c-exp.y (struct c_parse_state): New.
10363         (cpstate): New global.
10364         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10365         (nonempty_typelist): Update.
10366         (func_mod): Create a new vector.
10367         (c_parse): Create a c_parse_state.
10368         (check_parameter_typelist): Do not delete params.
10369         (function_method): Update.  Do not delete type_list.
10370
10371 2019-01-06  Tom Tromey  <tom@tromey.com>
10372
10373         PR gdb/28155:
10374         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10375         check_typedef.
10376         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10377         (print_return_value): Likewise.
10378
10379 2019-01-05  Tom Tromey  <tom@tromey.com>
10380
10381         * contrib/cleanup_check.py: Remove.
10382         * contrib/gcc-with-excheck: Remove.
10383         * contrib/exsummary.py: Remove.
10384         * contrib/excheck.py: Remove.
10385
10386 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10387
10388         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10389         NULL. Initialize tpprev to NULL instead of assigning it
10390         to NULL on the next statement.
10391         * windows-nat.c (windows_delete_thread): Remove check for
10392         main_thread_id before printing thread exit notifications.
10393         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10394         Remove thread ID check against main_thread_id.
10395         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10396         windows_delete_thread.
10397         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10398
10399 2019-01-04  Tom Tromey  <tom@tromey.com>
10400
10401         * compile/compile.c (_initialize_compile): Use upper case for
10402         metasyntactic variables.
10403         * symmisc.c (_initialize_symmisc): Use upper case for
10404         metasyntactic variables.
10405         * psymtab.c (_initialize_psymtab): Use upper case for
10406         metasyntactic variables.
10407         * demangle.c (demangle_command): Use upper case for metasyntactic
10408         variables.
10409         (_initialize_demangler): Likewise.
10410         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10411         variables.
10412
10413 2019-01-03  Tom Tromey  <tom@tromey.com>
10414
10415         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10416
10417 2019-01-03  Tom Tromey  <tom@tromey.com>
10418
10419         * python/py-symtab.c (salpy_str): Update.
10420         (struct salpy_sal_object) <symtab>: Now a PyObject.
10421         (salpy_dealloc): Update.
10422         (del_objfile_sal): Use gdbpy_ref.
10423
10424 2019-01-03  Tom Tromey  <tom@tromey.com>
10425
10426         * python/py-type.c (convert_field): Use new_reference.  Return
10427         gdbpy_ref.
10428         (make_fielditem): Return gdbpy_ref.
10429         (typy_fields): Update.
10430         (typy_getitem): Update.
10431         (field_name): Return gdbpy_ref.  Use new_reference.
10432         (typy_iterator_iternext): Update.
10433
10434 2019-01-03  Tom Tromey  <tom@tromey.com>
10435
10436         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10437
10438 2019-01-03  Tom Tromey  <tom@tromey.com>
10439
10440         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10441         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10442         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10443         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10444         (pspy_set_type_printers): Likewise.
10445         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10446         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10447         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10448         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10449         (objfpy_set_type_printers): Likewise.
10450
10451 2019-01-03  Tom Tromey  <tom@tromey.com>
10452
10453         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10454         (gdbpy_print_stack): Use gdbpy_err_fetch.
10455         * python/python-internal.h (class gdbpy_err_fetch): New class.
10456         (class gdbpy_enter) <m_error_type, m_error_value,
10457         m_error_traceback>: Remove.
10458         <m_error>: New member.
10459         (gdbpy_exception_to_string): Don't declare.
10460         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10461         * python/py-value.c (convert_value_from_python): Use
10462         gdbpy_err_fetch.
10463         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10464         gdbpy_exception_to_string.
10465         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10466         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10467         gdbpy_err_fetch.
10468
10469 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10470
10471         * linux-nat.c (delete_lwp_cleanup): Delete.
10472         (struct lwp_deleter): New struct.
10473         (lwp_info_up): New typedef.
10474         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10475         lwp_info_up.
10476
10477 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10478
10479         * linux-fork.c (class scoped_switch_fork_info): New class.
10480         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10481
10482 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10483
10484         * valops.c (find_overload_match): Remove use of null_cleanup, and
10485         calls to do_cleanups.
10486
10487 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10488
10489         * compile/compile-cplus-types.c
10490         (compile_cplus_instance::decl_name): Handle changes to
10491         cp_func_name.
10492         * cp-support.c (cp_func_name): Update header comment, update
10493         return type.
10494         * cp-support.h (cp_func_name): Update return type in declaration.
10495         * valops.c (find_overload_match): Move temp_func local to top
10496         level of function and change its type.  Use temp_func to hold and
10497         delete temporary string obtained from cp_func_name.
10498
10499 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10500
10501         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10502         gdb::char_vector, remove cleanup, and update uses of `msg`.
10503
10504 2019-01-03  Jim Wilson  <jimw@sifive.com>
10505
10506         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10507
10508 2019-01-02  Tom Tromey  <tom@tromey.com>
10509
10510         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10511         (tdesc_parse_xml): Remove cleanups.
10512         * target-descriptions.h (make_cleanup_free_target_description):
10513         Don't declare.
10514         (target_desc_deleter): New struct.
10515         (target_desc_up): New typedef.
10516         * target-descriptions.c (target_desc_deleter::operator()): Rename
10517         from free_target_description.
10518         (make_cleanup_free_target_description): Remove.
10519
10520 2019-01-02  Tom Tromey  <tom@tromey.com>
10521
10522         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10523         constructor, destructor.
10524         (linespec_parser): Remove typedef.
10525         (~linespec_parser): Rename from linespec_parser_delete.
10526         (linespec_lex_to_end, linespec_complete_label)
10527         (linespec_complete): Update.
10528         (decode_line_full): Remove cleanups.
10529         (decode_line_1): Update.
10530
10531 2019-01-02  Tom Tromey  <tom@tromey.com>
10532
10533         * python/python-internal.h (inferior_to_inferior_object): Change
10534         return type.
10535         * python/py-exitedevent.c (create_exited_event_object): Update.
10536         * python/py-inferior.c (inferior_to_inferior_object): Return
10537         gdbpy_ref.
10538         (python_new_inferior, python_inferior_deleted)
10539         (thread_to_thread_object, delete_thread_object)
10540         (build_inferior_list, gdbpy_selected_inferior): Update.
10541         * python/py-infthread.c (create_thread_object): Update.  Also fail
10542         if inferior_to_inferior_object fails.
10543
10544 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10545
10546         * inferior.h (class inferior) <displaced_step_state>: New field.
10547         * infrun.h (struct displaced_step_state): Move here from
10548         infrun.c.  Initialize fields, add constructor.
10549         <inf>: Remove field.
10550         <reset>: New method.
10551         * infrun.c (struct displaced_step_inferior_state): Move to
10552         infrun.h.
10553         (displaced_step_inferior_states): Remove.
10554         (get_displaced_stepping_state): Adust.
10555         (displaced_step_in_progress_any_inferior): Adjust.
10556         (displaced_step_in_progress_thread): Adjust.
10557         (displaced_step_in_progress): Adjust.
10558         (add_displaced_stepping_state): Remove.
10559         (get_displaced_step_closure_by_addr): Adjust.
10560         (remove_displaced_stepping_state): Remove.
10561         (infrun_inferior_exit): Call displaced_step_state.reset.
10562         (use_displaced_stepping): Don't check for NULL.
10563         (displaced_step_prepare_throw): Call
10564         get_displaced_stepping_state.
10565         (displaced_step_fixup): Don't check for NULL.
10566         (prepare_for_detach): Don't check for NULL.
10567
10568 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10569
10570         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10571          in case of call that did not complete.
10572
10573 2019-01-02  Andrey Utkin  <autkin@undo.io>
10574
10575         * symfile.c (find_separate_debug_file): Fix search of debug files for
10576         remote debuggee.
10577
10578 2019-01-02  Tom Tromey  <tom@tromey.com>
10579
10580         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10581         indentation.
10582         * python/py-frame.c (frapy_older): Remove cast.
10583         (frapy_newer): Likewise.
10584         * python/py-breakpoint.c (local_setattro): Remove cast.
10585         * python/py-arch.c (archpy_name): Remove local variable.
10586         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10587
10588 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10589
10590         * unittests/basic_string_view/element_access/char/empty.cc:
10591         Fix year range in copyright header.
10592
10593 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10594
10595         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10596         Delete.
10597         <operator==>: Update with for removed field.
10598         <hash>: Likewise.
10599         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10600         <isa_features>: ...this.
10601         <abi_features>: New field.
10602         (riscv_isa_flen): Update comment.
10603         (riscv_abi_xlen): New declaration.
10604         (riscv_abi_flen): New declaration.
10605         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10606         isa_features.
10607         (riscv_abi_xlen): New function.
10608         (riscv_isa_flen): Update to get answer from isa_features.
10609         (riscv_abi_flen): New function.
10610         (riscv_has_fp_abi): Update to get answer from abi_features.
10611         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10612         xlen and flen.
10613         (riscv_call_info) <xlen, flen>: Update comment.
10614         (riscv_call_arg_struct): Remove invalid assertions
10615         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10616         is removed.
10617         (riscv_gdbarch_init): Gather isa features and abi features
10618         separately, ensure both match on the gdbarch when reusing an old
10619         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10620         a target with 64-bit float hardware.
10621
10622 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10623
10624         * source.c (search_command_helper): Stop reverse search
10625         when line 1 has been searched.
10626
10627 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10628
10629         * record-full.c (record_full_base_target::close): Rewrite
10630         record_full_core_buf_list free logic.
10631
10632 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10633
10634         * break-catch-syscall.c (print_one_catch_syscall): xfree
10635         the last text.
10636
10637 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10638
10639         * top.c (print_gdb_version): Update Copyright year in version
10640         message.
10641
10642 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10643
10644         Update copyright year range in all GDB files.
10645
10646 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10647
10648         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10649
10650 For older changes see ChangeLog-2018.
10651 \f
10652 Local Variables:
10653 mode: change-log
10654 left-margin: 8
10655 fill-column: 74
10656 version-control: never
10657 coding: utf-8
10658 End:
10659