1 2019-12-11 Tom Tromey <tromey@adacore.com>
3 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
6 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8 * NEWS: Document -raw-values option and the related setting commands.
9 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
10 only set it on when /r is given.
11 * valprint.c (value_print_option_defs): New element raw-values.
12 * Makefile.in: Add the new file.
14 2019-12-10 Christian Biesinger <cbiesinger@google.com>
16 * gdbsupport/safe-strerror.c: Supress the unused function warning
17 for select_strerror_r.
19 2019-12-10 Christian Biesinger <cbiesinger@google.com>
21 * config.in: Regenerate.
22 * configure: Regenerate.
23 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
24 safe_strerror instead of strerror.
25 * gdbsupport/common.m4: Don't check for strerror.
26 * gdbsupport/safe-strerror.c: Support both the glibc version
27 of strerror_r and the XSI version.
29 2019-12-10 Tom Tromey <tromey@adacore.com>
31 * ada-typeprint.c (print_choices): Use a single "?".
32 (print_variant_part): Print "?" if the discriminant name
35 2019-12-10 George Barrett <bob@bob131.so>
37 Fix scripted probe breakpoints.
38 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
40 (breakpoint_ops_for_event_location_type)
41 (breakpoint_ops_for_event_location): Add function definitions.
42 (break_command_1, trace_command): Use
43 breakpoint_ops_for_event_location.
44 * breakpoint.h (breakpoint_ops_for_event_location): Add function
46 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
47 breakpoint_ops_for_event_location.
48 * python/py-breakpoint.c (bppy_init): Use
49 breakpoint_ops_for_event_location.
51 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
53 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
54 when ranking an lvalue argument for an rvalue parameter.
56 2019-12-08 Wataru Ashihara <wataash@wataash.com>
58 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
59 template argument for scoped_restore_tmpl from bool to int.
61 2019-12-07 Keith Seitz <keiths@redhat.com>
63 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
64 (build_id_to_debug_bfd): Make static, rewriting to use
65 build_id_to_bfd_suffix.
66 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
67 adding `suffix' parameter. Append SUFFIX to file names
68 when searching for matching files.
69 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
70 (build_id_to_exec_bfd): Likewise.
71 * build-id.h (build_id_to_debug_bfd): Clarify that function
72 searches for BFD of debug info file.
73 (build_id_to_exec_bfd): Declare.
74 * corelow.c: Include build-id.h.
75 (locate_exec_from_corefile_build_id): New function.
76 (core_target_open): If no executable BFD is found,
77 search for a core file BFD using build-id.
79 2019-12-06 Christian Biesinger <cbiesinger@google.com>
81 * bcache.c: Put in namespace gdb.
83 * gdbtypes.c (check_types_worklist): Update.
84 (types_deeply_equal): Update.
85 * macrotab.c (struct macro_table) <bcache>: Update.
86 (new_macro_table): Update.
87 * macrotab.h (struct bcache): Put this forward declaration
89 (new_macro_table): Update.
90 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
92 <macro_cache>: Update.
93 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
95 2019-12-06 Tom de Vries <tdevries@suse.de>
98 * block.c (best_symbol, better_symbol): New function.
99 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
102 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
104 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
105 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
106 for ranking see-through reference cases.
108 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
109 * stack.c (faas_command): Check a command is provided.
110 * thread.c (taas_command, tfaas_command): Likewise.
112 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
113 * inferior.c (prune_inferiors): Only call delete_inferior,
114 Do not modify the inferior list.
116 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
118 * c-exp.y: Update calls to lookup_typename,
119 lookup_signed_typename and lookup_unsigned_typename.
120 * c-lang.c (evaluate_subexp_c): Likewise.
121 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
123 * eval.c (binop_promote): Likewise.
124 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
125 (lookup_unsigned_typename): Likewise.
126 (lookup_signed_typename): Likewise.
127 * gdbtypes.h (lookup_unsigned_typename): Likewise.
128 (lookup_signed_typename): Likewise.
129 (lookup_typename): Likewise.
130 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
131 lookup_typename, lookup_signed_typename,
132 lookup_unsigned_typename.
133 * m2-exp.y: Likewise.
134 * printcmd.c (printf_wide_c_string): Likewise.
135 (ui_printf): Likewise.
136 * python/py-type.c (typy_lookup_typename): Likewise.
137 * python/py-xmethods.c (python_xmethod_worker::invoke):
139 * rust-exp.y: Likewise.
141 2019-12-04 Christian Biesinger <cbiesinger@google.com>
143 * configure.nat (obsd64): Add missing files x86-nat.o and
146 2019-12-04 Tom Tromey <tom@tromey.com>
148 * valprint.c (val_print_string): Use metadata_style.
149 * go-valprint.c (print_go_string): Use metadata style.
150 * p-valprint.c (pascal_object_print_static_field): Use metadata
152 * cp-valprint.c (cp_print_static_field): Use metadata style.
154 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
155 Chris January <chris.january@arm.com>
157 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
159 (typebase): New patterns for complex, single/double precision, and
160 single/double complex.
161 (f77_keywords): Change token for complex keyword, and add single,
162 double, and precision keywords.
164 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
166 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
169 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
171 * regcache.c (cooked_read_test): Initialize thread list of
174 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
176 * aarch64-linux-tdep.c: Remove includes.
178 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
180 * aarch64-tdep.c: Remove includes.
182 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
184 * filtered-iterator.h (filtered_iterator) <operator==,
185 operator!=>: Compare wrapped iterators, not wrapped pointers.
186 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
187 unittests/filtered_iterator-selftests.c.
188 * unittests/filtered_iterator-selftests.c: New file.
190 2019-12-04 Tom Tromey <tromey@adacore.com>
192 * gdbtypes.c (create_range_type): Inherit endianity
195 2019-12-04 Tom Tromey <tromey@adacore.com>
197 * ada-lang.c (decode_constrained_packed_array)
198 (ada_value_assign, value_assign_to_component): Update.
199 * dwarf2loc.c (rw_pieced_value, access_memory)
200 (dwarf2_compile_expr_to_ax): Update.
201 * dwarf2read.c (dwarf2_add_field): Update.
202 * eval.c (evaluate_subexp_standard): Update.
203 * gdbarch.c, gdbarch.h: Rebuild.
204 * gdbarch.sh (bits_big_endian): Remove.
205 * gdbtypes.h (union field_location): Update comment.
206 * target-descriptions.c (make_gdb_type): Update.
207 * valarith.c (value_bit_index): Update.
208 * value.c (struct value) <bitpos>: Update comment.
209 (unpack_bits_as_long, modify_field): Update.
210 * value.h (value_bitpos): Update comment.
212 2019-12-04 Tom Tromey <tromey@adacore.com>
214 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
217 2019-12-04 Tom Tromey <tromey@adacore.com>
219 * dwarf2read.c (dwarf2_init_float_type)
220 (dwarf2_init_complex_target_type): Add byte_order parameter.
221 (read_base_type): Compute byte order earlier.
222 * gdbtypes.c (init_float_type): Add byte_order parameter.
223 * gdbtypes.h (init_float_type): Add byte_order parameter.
225 2019-12-04 Tom Tromey <tromey@adacore.com>
227 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
229 2019-12-04 Tom Tromey <tromey@adacore.com>
231 * dwarf2read.c (process_structure_scope): Initialize
234 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
236 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
237 add it into the search spec.
238 (parse_max_results_option): New function.
239 (mi_info_functions_or_variables): Parse -max-results flag and pass
240 it to mi_symbol_info.
241 (mi_cmd_symbol_info_modules): Likewise.
242 (mi_cmd_symbol_info_types): Likewise.
243 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
244 return type to bool, change result container into a set, and don't
245 add new results if we have enough already.
246 (global_symbol_searcher::add_matching_msymbols): Change return
247 type to bool, and don't add new results if we have enough already.
248 (sort_search_symbols_remove_dups): Delete.
249 (global_symbol_searcher::search): Early exit from search loop when
250 we have enough results. Use a std::set to collect the results
251 from calling add_matching_symbols.
252 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
254 (global_symbol_searcher) <m_max_search_results>: New member
256 (global_symbol_searcher) <add_matching_symbols>: Update header
257 comment and change return type to bool.
258 (global_symbol_searcher) <add_matching_msymbols>: Update header
259 comment and change return type to bool.
261 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
263 * symtab.c (symbol_search::compare_search_syms): Update header
265 (global_symbol_searcher::is_suitable_msymbol): New function.
266 (global_symbol_searcher::expand_symtabs): New function.
267 (global_symbol_searcher::add_matching_symbols): New function.
268 (global_symbol_searcher::add_matching_msymbols): New function.
269 (global_symbol_searcher::search): Move most of the content
270 into the new functions above, and call them as needed.
271 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
273 (global_symbol_searcher) <add_matching_symbols>: New member
275 (global_symbol_searcher) <add_matching_msymbols>: New member
277 (global_symbol_searcher) <is_suitable_msymbol>: New member
280 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
282 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
283 -symbol-info-module-variables entries.
284 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
285 (mi_cmd_symbol_info_module_variables): Declare.
286 * mi/mi-symbol-cmds.c
287 (module_symbol_search_iterator): New typedef.
288 (output_module_symbols_in_single_module_and_file): New function.
289 (output_module_symbols_in_single_module): New function.
290 (mi_info_module_functions_or_variables): New function.
291 (mi_cmd_symbol_info_module_functions): New function.
292 (mi_cmd_symbol_info_module_variables): New function.
293 * NEWS: Mention new MI command.
295 2019-12-03 Christian Biesinger <cbiesinger@google.com>
297 * bcache.c (hash): Remove.
298 (hash_continue): Remove.
299 * bcache.h (hash): Remove.
300 (hash_continue): Remove.
301 (struct bcache) <ctor>: Update.
302 * psymtab.c (psymbol_hash): Update.
303 * stabsread.c (hashname): Update.
304 * utils.h (fast_hash): Add an argument for a start value,
307 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
308 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
309 (destroy_block_symbol_cache): New function.
310 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
311 (resize_symbol_cache): Likewise.
313 2019-12-02 Tom Tromey <tom@tromey.com>
315 * unittests/tui-selftests.c (run_tests): Make conditional.
316 (_initialize_tui_selftest): Make conditional.
318 2019-12-02 Christian Biesinger <cbiesinger@google.com>
320 * aix-thread.c (debug_aix_thread): Change type to bool.
322 2019-12-02 Luis Machado <luis.machado@linaro.org>
324 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
326 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
328 * dwarf2read.c (read_tag_string_type): Read the fields required to
329 make a dynamic string, and possibly create a dynamic range for the
331 (attr_to_dynamic_prop): Setup is_reference based on the type of
332 attribute being processed.
333 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
334 (resolve_dynamic_array): Rename to...
335 (resolve_dynamic_array_or_string): ...this, update header comment,
336 and accept TYPE_CODE_STRING.
337 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
339 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
341 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
342 of its implementation from...
343 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
346 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
348 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
349 create a range with stride where appropriate.
350 * f-valprint.c: Include 'gdbarch.h'.
351 (f77_print_array_1): Take the stride into account when walking the
352 array. Also convert the stride into addressable units.
353 * gdbtypes.c (create_range_type): Initialise the stride to
355 (create_range_type_with_stride): New function, initialise the
356 range as normal, and then setup the stride.
357 (has_static_range): Include the stride here. Also change the
359 (create_array_type_with_stride): Consider the range stride if the
360 array isn't given its own stride.
361 (resolve_dynamic_range): Resolve the stride if needed.
362 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
363 (struct range_bounds) <flag_is_byte_stride>: New member variable.
364 (TYPE_BIT_STRIDE): Define.
365 (TYPE_ARRAY_BIT_STRIDE): Define.
366 (create_range_type_with_stride): Declare.
367 * valarith.c (value_subscripted_rvalue): Take range stride into
368 account when walking the array.
370 2019-12-01 Tom Tromey <tom@tromey.com>
372 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
375 2019-12-01 Tom Tromey <tom@tromey.com>
377 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
379 * unittests/tui-selftests.c: New file.
380 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
382 2019-12-01 Tom Tromey <tom@tromey.com>
384 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
386 2019-12-01 Tom Tromey <tom@tromey.com>
388 * NEWS: Document new settings.
389 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
390 * tui/tui-win.c (_initialize_tui_win): Add border style
392 * tui/tui-io.h (tui_apply_style): Declare.
393 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
395 (apply_ansi_escape, tui_set_reverse_mode): Update.
396 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
397 Add "skip_intensity" parameter.
398 <changed>: New member.
399 <do_set_value>: Declare.
400 (tui_border_style, tui_active_border_style): Declare.
401 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
403 (cli_style_option): Initialize "changed".
404 (cli_style_option::do_set_value): New function.
405 (cli_style_option::add_setshow_commands): Add "skip_intensity"
407 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
408 (_initialize_cli_style): Update. Create TUI border style
411 2019-12-01 Tom Tromey <tom@tromey.com>
413 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
415 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
417 * tui/tui-win.h (compact_source): Declare.
418 * tui/tui-win.c (compact_source): New global.
419 (tui_set_compact_source, tui_show_compact_source): New functions.
420 (_initialize_tui_win): Add "compact-source" setting.
421 * tui/tui-source.c (tui_source_window::set_contents): Handle
422 compact_source setting.
423 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
424 * NEWS: Document new setting.
426 2019-11-30 Tom Tromey <tom@tromey.com>
428 * dwarf2read.c (dwarf2_add_field): Include field offset when
429 computing variant part length.
431 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
432 * NEWS: Mention define-prefix. Tell that command names can now
433 contain a . character.
435 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
437 * command.h (valid_cmd_char_p): Declare.
438 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
439 the check of valid command char.
440 (find_command_name_length, valid_user_defined_cmd_name_p): Use
442 * cli/cli-script.c (validate_comname): Likewise.
443 * completer.c (gdb_completer_command_word_break_characters):
444 Do not remove . from the word break char, update comments.
445 (complete_line_internal_1): Use valid_cmd_char_p.
446 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
447 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
449 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
451 * cli/cli-script.c (do_define_command): Ensure a redefined
452 prefix command is kept as a prefix command.
453 (define_prefix_command): New function.
454 (show_user_1): Report user defined prefixes.
455 (_initialize_cli_script): Create the new 'define-prefix' command.
456 Add completers for 'define' and 'document'.
457 * top.c (execute_command): If command is a user-defined prefix only
458 command, report the list of commands for this prefix command.
460 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
462 * valops.c (find_oload_champ): Improve debug output.
464 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
466 * valops.c (find_oload_champ): Print part of debug messages
467 before the badness vector is std::move'd.
469 2019-11-28 Tom Tromey <tom@tromey.com>
471 * value.c (creal_internal_fn): Fix comment.
473 2019-11-28 Tom Tromey <tom@tromey.com>
475 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
476 flag_bound_evaluated>: Now unsigned.
478 2019-11-28 Tom Tromey <tom@tromey.com>
480 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
483 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
485 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
487 * jit.c (jit_unregister_code): Add debug print to match
490 2019-11-27 Christian Biesinger <cbiesinger@google.com>
492 * NEWS: Mention the new multithreaded symbol loading.
494 2019-11-27 Christian Biesinger <cbiesinger@google.com>
496 * maint.c (n_worker_threads): Default to 0.
497 (worker_threads_disabled): New function.
498 * maint.h (worker_threads_disabled): New function.
499 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
500 here if worker_threads_disabled () is true.
501 (minimal_symbol_reader::install): Skip all threading if
502 worker_threads_disabled () is true.
504 2019-11-27 Christian Biesinger <cbiesinger@google.com>
506 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
507 hash code if possible.
508 (add_minsym_to_demangled_hash_table): Likewise.
509 (minimal_symbol_reader::install): Compute the hash codes for msymbol
510 on the background thread.
511 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
514 2019-11-27 Christian Biesinger <cbiesinger@google.com>
516 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
517 of the mangled name on the background thread.
518 * symtab.c (symbol_set_names): Allow passing in the hash of the
520 * symtab.h (symbol_set_names): Likewise.
522 2019-11-27 Kevin Buettner <kevinb@redhat.com>
524 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
525 physnames are computed for inherited DIEs.
527 2019-11-27 Tom Tromey <tromey@adacore.com>
529 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
531 * cp-support.c: Remove unnecessary backslashes.
533 2019-11-27 Christian Biesinger <cbiesinger@google.com>
535 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
536 with sym->set_linkage_name.
537 * coffread.c (coff_read_enum_type): Likewise.
538 * mdebugread.c (parse_symbol): Likewise.
539 * stabsread.c (patch_block_stabs): Likewise.
540 (define_symbol): Likewise.
541 (read_enum_type): Likewise.
542 (common_block_end): Likewise.
543 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
545 (SYMBOL_SET_LINKAGE_NAME): Remove.
546 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
547 with sym->set_linkage_name.
549 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
551 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
552 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
553 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
554 * NEWS: Mention new MI command.
556 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
558 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
559 '-symbol-info-types', and '-symbol-info-variables'.
560 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
561 (mi_cmd_symbol_info_types): Declare.
562 (mi_cmd_symbol_info_variables): Declare.
563 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
564 (output_debug_symbol): New function.
565 (output_nondebug_symbol): New function.
566 (mi_symbol_info): New function.
567 (mi_info_functions_or_variables): New function.
568 (mi_cmd_symbol_info_functions): New function.
569 (mi_cmd_symbol_info_types): New function.
570 (mi_cmd_symbol_info_variables): New function.
571 * NEWS: Mention new commands.
573 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
575 * symtab.c (symbol_to_info_string): New function, most content
576 moved from print_symbol_info, but updated to return a std::string.
577 (print_symbol_info): Update to use symbol_to_info_string and print
579 * symtab.h (symbol_to_info_string): Declare new function.
581 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
583 * python/python.c (gdbpy_rbreak): Convert to using
584 global_symbol_searcher.
585 * symtab.c (file_matches): Convert return type to bool, change
586 file list to std::vector, update header comment.
587 (search_symbols): Rename to...
588 (global_symbol_searcher::search): ...this and update now its
589 a member function of global_symbol_searcher. Take account of the
590 changes to file_matches.
591 (symtab_symbol_info): Convert to using global_symbol_searcher.
592 (rbreak_command): Likewise.
593 (search_module_symbols): Likewise.
594 * symtab.h (enum symbol_search): Update comment.
595 (search_symbols): Remove declaration.
596 (class global_symbol_searcher): New class.
598 2019-11-26 Tom Tromey <tromey@adacore.com>
600 * cp-support.c (_initialize_cp_support): Conditionally initialize
601 gdb_demangle_attempt_core_dump.
603 2019-11-26 Tom Tromey <tom@tromey.com>
605 * python/py-function.c (fnpy_init): Update.
606 * value.h (add_internal_function): Adjust declaration.
607 * value.c (function_destroyer): Remove.
608 (do_add_internal_function): Don't set destroyer or copy name.
609 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
611 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
612 (cmdpy_init): Set name_allocated.
613 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
615 (~cmd_list_element): Free "name" if needed.
617 2019-11-26 Tom Tromey <tom@tromey.com>
619 * value.h (add_internal_function): Add new overload. Move
620 documentation from value.h.
621 * value.c (do_add_internal_function): New function.
622 (add_internal_function): Use it. Add new overload.
623 (function_destroyer): Don't free doc.
624 * python/py-function.c (fnpy_init): Update.
626 2019-11-26 Tom Tromey <tom@tromey.com>
628 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
629 (cmdpy_init): Set "doc_allocated".
631 2019-11-26 Tom Tromey <tom@tromey.com>
633 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
634 name of worker thread.
635 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
637 * configure, config.in: Rebuild.
639 2019-11-26 Tom Tromey <tom@tromey.com>
641 * python/python.c (class gdbpy_gil): New.
642 (struct gdbpy_event): Add constructor, destructor, operator().
643 (gdbpy_post_event): Use run_on_main_thread.
644 (gdbpy_initialize_events): Remove.
645 (do_start_initialization): Update.
647 2019-11-26 Tom Tromey <tom@tromey.com>
650 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
651 commands. Call update_thread_pool_size.
652 (update_thread_pool_size, maintenance_set_worker_threads): New
654 (n_worker_threads): New global.
656 2019-11-26 Christian Biesinger <cbiesinger@google.com>
657 Tom Tromey <tom@tromey.com>
659 * minsyms.c (minimal_symbol_reader::install): Use
661 * gdbsupport/parallel-for.h: New file.
662 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
664 2019-11-26 Christian Biesinger <cbiesinger@google.com>
665 Tom Tromey <tom@tromey.com>
667 * gdbsupport/thread-pool.h: New file.
668 * gdbsupport/thread-pool.c: New file.
669 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
670 (HFILES_NO_SRCDIR): Add thread-pool.h.
672 2019-11-26 Tom Tromey <tom@tromey.com>
674 * event-top.h (thread_local_segv_handler): Declare.
675 * event-top.c (thread_local_segv_handler): New global.
676 (install_handle_sigsegv, handle_sigsegv): New functions.
677 (async_init_signals): Install SIGSEGV handler.
678 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
680 (report_failed_demangle): New function.
681 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
682 handler-setting code, instead use segv_handler. Run warning code
685 2019-11-26 Tom Tromey <tom@tromey.com>
687 * run-on-main-thread.c: New file.
688 * run-on-main-thread.h: New file.
689 * unittests/main-thread-selftests.c: New file.
690 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
691 main-thread-selftests.c.
692 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
693 (COMMON_SFILES): Add run-on-main-thread.c.
695 2019-11-26 Tom Tromey <tom@tromey.com>
697 * main.c (setup_alternate_signal_stack): Remove.
698 (captured_main_1): Use gdb::alternate_signal_stack.
699 * gdbsupport/alt-stack.h: New file.
701 2019-11-26 Tom Tromey <tom@tromey.com>
703 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
705 (save_original_signals_state, restore_original_signals_state): Use
707 * linux-nat.c (block_child_signals, restore_child_signals_mask)
708 (_initialize_linux_nat): Use gdb_sigmask.
709 * guile/guile.c (_initialize_guile): Use block_signals.
710 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
711 * gdbsupport/gdb-sigmask.h: New file.
712 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
713 * cp-support.c (gdb_demangle): Use gdb_sigmask.
714 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
716 * configure, config.in: Rebuild.
717 * gdbsupport/block-signals.h: New file.
719 2019-11-26 Tom Tromey <tom@tromey.com>
721 * acinclude.m4: Include ax_pthread.m4.
722 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
723 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
724 (CLIBS): Use PTHREAD_LIBS.
725 (aclocal_m4_deps): Add ax_pthread.m4.
726 * config.in, configure: Rebuild.
727 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
729 2019-11-26 Tom Tromey <tom@tromey.com>
731 * symtab.h (struct minimal_symbol) <name_set>: New member.
732 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
733 Don't call symbol_set_names.
734 (minimal_symbol_reader::install): Call symbol_set_names.
736 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
738 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
739 restore_active_ext_lang, as GIL is needed for (indirectly)
740 called PyOS_InterruptOccurred.
742 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
744 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
747 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
749 * remote-sim.c (simulator_command): Make static, remove
752 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
754 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
756 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
757 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
759 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
761 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
763 * unittests/basic_string_view/element_access/char/1.cc (test01):
766 * unittests/basic_string_view/element_access/char/empty.cc (main):
768 * unittests/basic_string_view/element_access/char/front_back.cc
771 * unittests/basic_string_view/inserters/char/2.cc (test05):
774 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
777 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
780 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
782 * unittests/basic_string_view/operations/compare/char/1.cc
785 * unittests/basic_string_view/operations/compare/char/13650.cc
787 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
790 * unittests/basic_string_view/operations/data/char/1.cc (test01):
793 * unittests/basic_string_view/operations/find/char/1.cc (test01):
796 * unittests/basic_string_view/operations/find/char/2.cc (test02):
799 * unittests/basic_string_view/operations/find/char/3.cc (test03):
802 * unittests/basic_string_view/operations/find/char/4.cc (main):
804 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
807 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
810 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
813 * unittests/basic_string_view/operations/substr/char/1.cc
816 * unittests/basic_string_view/operators/char/2.cc (main):
818 * unittests/optional/assignment/1.cc (test): Likewise.
819 * unittests/optional/assignment/2.cc (test): Likewise.
820 * unittests/optional/assignment/3.cc (test): Likewise.
821 * unittests/optional/assignment/4.cc (test): Likewise.
822 * unittests/optional/assignment/5.cc (test): Likewise.
823 * unittests/optional/assignment/6.cc (test): Likewise.
824 * unittests/optional/assignment/7.cc (test): Likewise.
825 * unittests/optional/cons/copy.cc (test): Likewise.
826 * unittests/optional/cons/default.cc (test): Likewise.
827 * unittests/optional/cons/move.cc (test): Likewise.
828 * unittests/optional/cons/value.cc (test): Likewise.
829 * unittests/optional/in_place.cc (test): Likewise.
830 * unittests/optional/observers/1.cc (test): Likewise.
831 * unittests/optional/observers/2.cc (test): Likewise.
833 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
835 * tui-win.h (tui_set_var_cmd): Remove.
836 * tui-win.c (tui_set_var_cmd): Make static.
838 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
840 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
841 rbreak_command_wrapper): Remove.
842 * symtab.c (rbreak_command_wrapper): Remove.
844 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
846 * inferior.h (info_terminal_command): Remove declaration.
847 * inflow.c (info_terminal_command): Make static.
849 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
851 * inferior.c (exit_inferior_silent): Remove.
853 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
855 * dictionary.c (dict_empty, mdict_empty): Remove.
856 * dictionary.c (mdict_empty): Remove.
858 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
860 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
861 (arc_insn_get_memory_offset): Likewise.
862 (arc_insn_dump): Likewise.
863 * cp-support.c (test_cp_symbol_name_matches): Likewise.
864 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
865 * dictionary.c (dict_iterator_next): Likewise.
866 (dict_iter_match_first): Likewise.
867 (dict_iter_match_next): Likewise.
868 * f-lang.c (evaluate_subexp_f): Likewise.
869 * hppa-tdep.c (hppa_read_pc): Likewise.
870 * i386-tdep.c (i386_floatformat_for_type): Likewise.
871 * parse.c (write_exp_elt_msym): Likewise.
872 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
873 * remote.c (remote_packet_size): Likewise.
874 (remote_notif_stop_parse): Likewise.
875 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
876 * s12z-tdep.c (s12z_disassemble_info): Likewise.
877 * source.c (prepare_path_for_appending): Likewise.
878 * sparc64-linux-tdep.c
879 (sparc64_linux_handle_segmentation_fault); Likewise.
880 * stack.c (frame_selection_by_function_completer): Likewise.
882 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
884 * completer.c (set_gdb_completion_word_break_characters):
887 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
889 * dwarf-index-write.c: Include dwarf-index-write.h.
890 * mi/mi-interp.c: Include mi/mi-interp.h.
892 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
894 * aarch32-tdep.c: Include aarch32-tdep.h.
895 * aarch32-tdep.h: Forward-declare struct target_desc.
897 2019-11-26 Christian Biesinger <cbiesinger@google.com>
899 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
901 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
902 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
904 2019-11-25 Tom de Vries <tdevries@suse.de>
906 * contrib/words.sh: Add -c option.
908 2019-11-25 Christian Biesinger <cbiesinger@google.com>
910 * solib.c (solib_find_1): Change int to bool.
911 (exec_file_find): Change int to bool.
912 (solib_find): Change int to bool.
913 (solib_read_symbols): Change int to bool.
914 (solib_used): Change int to bool.
915 (solib_add): Change int to bool.
916 (info_sharedlibrary_command): Change int to bool.
917 (solib_contains_address_p): Change int to bool.
918 (solib_keep_data_in_core): Change int to bool.
919 (in_solib_dynsym_resolve_code): Change int to bool.
920 (reload_shared_libraries_1): Change int to bool.
921 (gdb_sysroot_changed): Change int to bool.
922 * solib.h (solib_read_symbols): Change int to bool.
923 (solib_contains_address_p): Change int to bool.
924 (solib_keep_data_in_core): Change int to bool.
925 (in_solib_dynsym_resolve_code): Change int to bool.
926 (libpthread_name_p): Change int to bool.
928 2019-11-25 Luis Machado <luis.machado@linaro.org>
930 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
931 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
932 (remote_packet_max_chars): New static global.
933 (show_remote_packet_max_chars): New function.
934 (remote_target::putpkt_binary): Adjust to use new
935 remote_packet_max_chars option.
936 (remote_target::getpkt_or_notif_sane_1): Likewise.
937 (_initialize_remote): Register new remote-packet-max-chars option.
939 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
941 * m68k-linux-nat.c: Include gdbarch.h.
943 2019-11-24 Tom Tromey <tom@tromey.com>
945 * symfile.c (read_symbols): Update.
946 * psymtab.c (require_partial_symbols): Change type of "verbose" to
948 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
949 (psym_lookup_symbol, psym_find_last_source_symtab)
950 (psym_forget_cached_source_info, psym_print_stats)
951 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
952 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
953 (psym_map_matching_symbols, psym_expand_symtabs_matching)
954 (psym_find_compunit_symtab_by_address)
955 (maintenance_print_psymbols, maintenance_info_psymtabs)
956 (maintenance_check_psymtabs): Update.
957 * psymtab.h (require_partial_symbols): Change type of "verbose" to
960 2019-11-22 Tom Tromey <tom@tromey.com>
962 * observable.h: Update comments.
964 2019-11-22 Tom Tromey <tromey@adacore.com>
966 * ada-tasks.c (ada_task_is_alive): Make parameter const.
967 (print_ada_task_info): Don't try to fetch thread id if task is not
970 2019-11-22 Christian Biesinger <cbiesinger@google.com>
973 * ada-lang.c (sort_choices): Update.
974 (ada_print_symbol_signature): Update.
975 (resolve_subexp): Update.
976 (ada_parse_renaming): Update.
977 (ada_read_renaming_var_value): Update.
978 (lesseq_defined_than): Update.
979 (remove_extra_symbols): Update.
980 (remove_irrelevant_renamings): Update.
981 (ada_add_block_symbols): Update.
982 (ada_collect_symbol_completion_matches): Update.
983 (ada_is_renaming_symbol): Update.
984 (aggregate_assign_from_choices): Update.
985 (ada_evaluate_subexp): Update.
986 (ada_has_this_exception_support): Update.
987 (ada_is_non_standard_exception_sym): Update.
988 (ada_add_exceptions_from_frame): Update.
989 (ada_add_global_exceptions): Update.
990 (ada_print_subexp): Update.
991 * ax-gdb.c (gen_var_ref): Update.
992 (gen_maybe_namespace_elt): Update.
993 (gen_expr_for_cast): Update.
996 * blockframe.c (find_pc_partial_function): Update.
997 * breakpoint.c (print_breakpoint_location): Update.
998 (update_static_tracepoint): Update.
999 * btrace.c (ftrace_print_function_name): Update.
1000 (ftrace_function_switched): Update.
1001 * buildsym.c (find_symbol_in_list): Update.
1003 * c-typeprint.c (c_print_typedef): Update.
1004 (c_type_print_template_args): Update.
1005 * cli/cli-cmds.c (edit_command): Update.
1006 (list_command): Update.
1007 (print_sal_location): Update.
1008 * coffread.c (patch_opaque_types): Update.
1009 (process_coff_symbol): Update.
1010 (coff_read_enum_type): Update.
1011 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1012 (convert_one_symbol): Update.
1013 (hash_symname): Update.
1014 (eq_symname): Update.
1015 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1016 * compile/compile-cplus-types.c (debug_print_scope): Update.
1017 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1018 * compile/compile-object-load.c (get_out_value_type): Update.
1019 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1020 (search_symbol_list): Update.
1021 (cp_lookup_symbol_imports_or_template): Update.
1022 * cp-support.c (overload_list_add_symbol): Update.
1023 * ctfread.c (psymtab_to_symtab): Update.
1024 * dbxread.c (cp_set_block_scope): Update.
1025 * dictionary.c (iter_match_first_hashed): Update.
1026 (iter_match_next_hashed): Update.
1027 (insert_symbol_hashed): Update.
1028 (iter_match_next_linear): Update.
1029 * dictionary.h: Update.
1030 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1031 (locexpr_describe_location_piece): Update.
1032 (locexpr_describe_location_1): Update.
1033 (locexpr_generate_c_location): Update.
1034 (loclist_describe_location): Update.
1035 (loclist_generate_c_location): Update.
1036 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1037 (read_func_scope): Update.
1038 (process_enumeration_scope): Update.
1039 (new_symbol): Update.
1040 (dwarf2_const_value): Update.
1041 (dwarf2_symbol_mark_computed): Update.
1042 * eval.c (evaluate_funcall): Update.
1043 (evaluate_subexp_standard): Update.
1044 * expprint.c (print_subexp_standard): Update.
1045 (dump_subexp_body_standard): Update.
1046 * f-valprint.c (info_common_command_for_block): Update.
1047 * findvar.c (get_hosting_frame): Update.
1048 (default_read_var_value): Update.
1049 * go-lang.c (go_symbol_package_name): Update.
1050 * guile/scm-block.c (bkscm_print_block_smob): Update.
1051 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1052 (gdbscm_symbol_name): Update.
1053 (gdbscm_symbol_linkage_name): Update.
1054 (gdbscm_symbol_print_name): Update.
1055 * infcall.c (get_function_name): Update.
1056 * infcmd.c (jump_command): Update.
1057 (finish_command): Update.
1058 * infrun.c (insert_exception_resume_breakpoint): Update.
1059 * linespec.c (canonicalize_linespec): Update.
1060 (create_sals_line_offset): Update.
1061 (convert_linespec_to_sals): Update.
1062 (complete_label): Update.
1063 (find_label_symbols_in_block): Update.
1064 * m2-typeprint.c (m2_print_typedef): Update.
1065 * mdebugread.c (mdebug_reg_to_regnum): Update.
1066 (parse_symbol): Update.
1067 (mylookup_symbol): Update.
1068 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1069 (list_args_or_locals): Update.
1070 * objc-lang.c (compare_selectors): Update.
1071 (info_selectors_command): Update.
1072 (compare_classes): Update.
1073 (info_classes_command): Update.
1074 (find_imps): Update.
1075 * p-typeprint.c (pascal_print_typedef): Update.
1076 * printcmd.c (build_address_symbolic): Update.
1077 (info_address_command): Update.
1078 (print_variable_and_value): Update.
1079 * python/py-framefilter.c (extract_sym): Update.
1080 (py_print_single_arg): Update.
1081 * python/py-symbol.c (sympy_str): Update.
1082 (sympy_get_name): Update.
1083 (sympy_get_linkage_name): Update.
1084 * python/python.c (gdbpy_rbreak): Update.
1085 * record-btrace.c (btrace_get_bfun_name): Update.
1086 (btrace_call_history): Update.
1087 * rust-lang.c (rust_print_typedef): Update.
1088 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1089 * stabsread.c (stab_reg_to_regnum): Update.
1090 (define_symbol): Update.
1091 (read_enum_type): Update.
1092 (common_block_end): Update.
1093 (cleanup_undefined_types_1): Update.
1094 (scan_file_globals): Update.
1095 * stack.c (print_frame_arg): Update.
1096 (print_frame_args): Update.
1097 (find_frame_funname): Update.
1098 (info_frame_command_core): Update.
1099 (iterate_over_block_locals): Update.
1100 (print_block_frame_labels): Update.
1101 (do_print_variable_and_value): Update.
1102 (iterate_over_block_arg_vars): Update.
1103 (return_command): Update.
1104 * symmisc.c (dump_symtab_1): Update.
1105 (print_symbol): Update.
1106 * symtab.c (eq_symbol_entry): Update.
1107 (symbol_cache_dump): Update.
1108 (lookup_language_this): Update.
1109 (find_pc_sect_line): Update.
1110 (skip_prologue_sal): Update.
1111 (symbol_search::compare_search_syms): Update.
1112 (treg_matches_sym_type_name): Update.
1113 (search_symbols): Update.
1114 (print_symbol_info): Update.
1115 (rbreak_command): Update.
1116 (completion_list_add_symbol): Update.
1117 (find_gnu_ifunc): Update.
1118 (get_symbol_address): Update.
1119 (search_module_symbols): Update.
1120 (info_module_subcommand): Update.
1121 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1122 (SYMBOL_LINKAGE_NAME): Remove.
1123 (SYMBOL_DEMANGLED_NAME): Remove.
1124 (SYMBOL_PRINT_NAME): Remove.
1125 (SYMBOL_SEARCH_NAME): Remove.
1126 * tracepoint.c (set_traceframe_context): Update.
1127 (validate_actionline): Update.
1128 (collection_list::collect_symbol): Update.
1129 (encode_actions_1): Update.
1130 (info_scope_command): Update.
1131 (print_one_static_tracepoint_marker): Update.
1132 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1133 * valops.c (address_of_variable): Update.
1134 (find_overload_match): Update.
1135 (find_oload_champ): Update.
1137 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1139 * ada-lang.c (ada_lookup_simple_minsym): Update.
1140 (ada_collect_symbol_completion_matches): Update.
1141 * ada-tasks.c (read_atcb): Update.
1142 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1143 (amd64_windows_skip_trampoline_code): Update.
1144 * arm-tdep.c (skip_prologue_function): Update.
1145 (arm_skip_stack_protector): Update.
1146 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1147 (arm_wince_skip_main_prologue): Update.
1148 * ax-gdb.c (gen_expr): Update.
1149 * block.c (call_site_for_pc): Update.
1150 * blockframe.c (find_pc_partial_function): Update.
1151 * breakpoint.c (set_breakpoint_location_function): Update.
1152 * btrace.c (ftrace_print_function_name): Update.
1153 (ftrace_function_switched): Update.
1154 * c-valprint.c (print_unpacked_pointer): Update.
1155 * coffread.c (coff_symfile_read): Update.
1156 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1157 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1158 * dwarf-index-write.c (write_psymbols): Update.
1159 * dwarf2loc.c (call_site_to_target_addr): Update.
1160 (func_verify_no_selftailcall): Update.
1161 (tailcall_dump): Update.
1162 (call_site_find_chain_1): Update.
1163 (dwarf_expr_reg_to_entry_parameter): Update.
1164 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1165 * eval.c (evaluate_funcall): Update.
1166 (evaluate_subexp_standard): Update.
1167 (evaluate_subexp_for_sizeof): Update.
1168 * expprint.c (print_subexp_standard): Update.
1169 (dump_subexp_body_standard): Update.
1170 * frame.c (get_prev_frame_always_1): Update.
1171 * frv-tdep.c (frv_skip_main_prologue): Update.
1172 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1173 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1174 (gnuv3_get_typename_from_type_info): Update.
1175 (gnuv3_skip_trampoline): Update.
1176 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1177 * i386-tdep.c (i386_skip_main_prologue): Update.
1178 (i386_pe_skip_trampoline_code): Update.
1179 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1180 * infcall.c (get_function_name): Update.
1181 * linespec.c (minsym_found): Update.
1182 * linux-fork.c (info_checkpoints_command): Update.
1183 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1184 (m32c_m16c_pointer_to_address): Update.
1185 * maint.c (maintenance_translate_address): Update.
1186 * minsyms.c (add_minsym_to_hash_table): Update.
1187 (add_minsym_to_demangled_hash_table): Update.
1188 (lookup_minimal_symbol_mangled): Update.
1189 (lookup_minimal_symbol_demangled): Update.
1190 (lookup_minimal_symbol_linkage): Update.
1191 (lookup_minimal_symbol_text): Update.
1192 (lookup_minimal_symbol_by_pc_name): Update.
1193 (minimal_symbol_is_less_than): Update.
1194 (compact_minimal_symbols): Update.
1195 (build_minimal_symbol_hash_tables): Update.
1196 (find_solib_trampoline_target): Update.
1197 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1198 (mips_skip_pic_trampoline_code): Update.
1199 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1200 * objc-lang.c (info_selectors_command): Update.
1201 (info_classes_command): Update.
1202 (find_methods): Update.
1203 (find_imps): Update.
1204 * p-valprint.c (pascal_val_print): Update.
1205 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1206 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1207 * printcmd.c (build_address_symbolic): Update.
1208 (info_symbol_command): Update.
1209 * psymtab.c (psymbol_name_matches): Update.
1210 (match_partial_symbol): Update.
1211 (lookup_partial_symbol): Update.
1212 (print_partial_symbols): Update.
1213 (sort_pst_symbols): Update.
1214 (maintenance_check_psymtabs): Update.
1215 * python/py-framefilter.c (py_print_frame): Update.
1216 * python/python.c (gdbpy_rbreak): Update.
1217 * record-btrace.c (btrace_get_bfun_name): Update.
1218 (btrace_call_history): Update.
1219 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1220 (rs6000_skip_trampoline_code): Update.
1221 * sol-thread.c (info_cb): Update.
1222 * stabsread.c (scan_file_globals): Update.
1223 * stack.c (find_frame_funname): Update.
1224 (info_frame_command_core): Update.
1225 * symmisc.c (dump_msymbols): Update.
1226 * symtab.c (symbol_natural_name): Rename to..,
1227 (general_symbol_info::natural_name): ...this.
1228 (symbol_demangled_name): Rename to...
1229 (general_symbol_info::demangled_name): ...this.
1230 (symbol_search_name): Rename to...
1231 (general_symbol_info::search_name): ...this.
1232 (symbol_matches_search_name): Update.
1233 (find_pc_sect_line): Update.
1234 (skip_prologue_sal): Update.
1235 (search_symbols): Update.
1236 (print_msymbol_info): Update.
1237 (rbreak_command): Update.
1238 (completion_list_add_msymbol): Update.
1239 (completion_list_objc_symbol): Update.
1240 (get_msymbol_address): Update.
1241 * symtab.h (struct general_symbol_info): Add member functions
1242 natural_name (), linkage_name (), print_name (), demangled_name (),
1244 (SYMBOL_NATURAL_NAME): Update.
1245 (symbol_natural_name): Move to a member function on general_symbol_info.
1246 (SYMBOL_DEMANGLED_NAME): Update.
1247 (symbol_demangled_name): Move to a member function on
1248 general_symbol_info.
1249 (SYMBOL_SEARCH_NAME): Update.
1250 (symbol_search_name): Move to a member function on general_symbol_info.
1251 (MSYMBOL_NATURAL_NAME): Remove.
1252 (MSYMBOL_LINKAGE_NAME): Remove.
1253 (MSYMBOL_PRINT_NAME): Remove.
1254 (MSYMBOL_DEMANGLED_NAME): Remove.
1255 (MSYMBOL_SEARCH_NAME): Remove.
1256 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1258 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1260 * symtab.c (create_demangled_names_hash): Use per_bfd->
1261 minimal_symbol_count for computing the initial size, if greater
1262 than our default size.
1264 2019-11-22 Tom de Vries <tdevries@suse.de>
1266 * contrib/words.sh: Improve words extraction.
1268 2019-11-22 Tom de Vries <tdevries@suse.de>
1270 * contrib/words.sh: Combine sed invocations.
1272 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1274 * Makefile.in: Update.
1275 * demangle.c: Rename to...
1276 * gdb-demangle.c: ..this.
1277 (is_cplus_marker): Change return type to bool.
1278 (_initialize_demangler): Rename to...
1279 (_initialize_gdb_demangle): ...this.
1280 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1281 * symtab.h (demangle): Remove declaration; instead include
1284 2019-11-21 Tom Tromey <tromey@adacore.com>
1286 * gdbsupport/format.c (format_pieces): Parse %I64d.
1287 * unittests/format_pieces-selftests.c (test_windows_formats): New
1289 (run_tests): Call it.
1291 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1293 Byte reverse display of variables with DW_END_big, DW_END_little
1294 (DW_AT_endianity) dwarf attributes if different than the native
1296 * ada-lang.c (ada_value_binop):
1297 Use type_byte_order instead of gdbarch_byte_order.
1298 * ada-valprint.c (printstr):
1299 (ada_val_print_string):
1300 * ada-lang.c (value_pointer):
1302 Use type_byte_order instead of gdbarch_byte_order.
1303 * c-lang.c (c_get_string):
1304 Use type_byte_order instead of gdbarch_byte_order.
1305 * c-valprint.c (c_val_print_array):
1306 Use type_byte_order instead of gdbarch_byte_order.
1307 * cp-valprint.c (cp_print_class_member):
1308 Use type_byte_order instead of gdbarch_byte_order.
1309 * dwarf2loc.c (rw_pieced_value):
1310 Use type_byte_order instead of gdbarch_byte_order.
1311 * dwarf2read.c (read_base_type): Handle DW_END_big,
1313 * f-lang.c (f_get_encoding):
1314 Use type_byte_order instead of gdbarch_byte_order.
1315 * findvar.c (default_read_var_value):
1316 Use type_byte_order instead of gdbarch_byte_order.
1317 * gdbtypes.c (check_types_equal):
1318 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1319 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1320 and TYPE_ENDIANITY_LITTLE if set.
1321 (type_byte_order): new function.
1322 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1323 (struct main_type) <flag_endianity_not_default>:
1325 (type_byte_order): New function.
1326 * infcmd.c (default_print_one_register_info):
1327 Use type_byte_order instead of gdbarch_byte_order.
1328 * p-lang.c (pascal_printstr):
1329 Use type_byte_order instead of gdbarch_byte_order.
1330 * p-valprint.c (pascal_val_print):
1331 Use type_byte_order instead of gdbarch_byte_order.
1332 * printcmd.c (print_scalar_formatted):
1333 Use type_byte_order instead of gdbarch_byte_order.
1334 * solib-darwin.c (darwin_current_sos):
1335 Use type_byte_order instead of gdbarch_byte_order.
1336 * solib-svr4.c (solib_svr4_r_ldsomap):
1337 Use type_byte_order instead of gdbarch_byte_order.
1338 * stap-probe.c (stap_modify_semaphore):
1339 Use type_byte_order instead of gdbarch_byte_order.
1340 * target-float.c (target_float_same_format_p):
1341 Use type_byte_order instead of gdbarch_byte_order.
1342 * valarith.c (scalar_binop):
1344 Use type_byte_order instead of gdbarch_byte_order.
1345 * valops.c (value_cast):
1346 Use type_byte_order instead of gdbarch_byte_order.
1347 * valprint.c (generic_emit_char):
1350 Use type_byte_order instead of gdbarch_byte_order.
1351 * value.c (unpack_long):
1352 (unpack_bits_as_long):
1353 (unpack_value_bitfield):
1356 (pack_unsigned_long):
1357 Use type_byte_order instead of gdbarch_byte_order.
1358 * findvar.c (unsigned_pointer_to_address):
1359 (signed_pointer_to_address):
1360 (unsigned_address_to_pointer):
1361 (address_to_signed_pointer):
1362 (default_read_var_value):
1363 (default_value_from_register):
1364 Use type_byte_order instead of gdbarch_byte_order.
1365 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1366 Use type_byte_order instead of gdbarch_byte_order.
1367 * riscv-tdep.c (riscv_print_one_register_info):
1368 Use type_byte_order instead of gdbarch_byte_order.
1370 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1372 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1373 (current_ui_gdb_stdin_ptr): Likewise.
1374 (current_ui_gdb_stderr_ptr): Likewise.
1375 (current_ui_gdb_stdlog_ptr): Likewise.
1376 (current_ui_current_uiout_ptr): Likewise.
1377 (gen_ret_current_ui_field_ptr): Remove.
1379 2019-11-21 Tom de Vries <tdevries@suse.de>
1382 * cli/cli-script.c (execute_control_command): Only switch to
1383 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1385 2019-11-19 Tom Tromey <tom@tromey.com>
1387 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1388 Now static. Change type of "name".
1389 (tui_set_win_height_command): Don't copy "arg".
1390 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1391 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1393 2019-11-19 Ali Tamur <tamur@google.com>
1395 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1396 "if (attr != nullptr)".
1397 (dwarf2_find_base_address): Likewise.
1398 (dwarf2_build_include_psymtabs): Likewise.
1399 (read_cutu_die_from_dwo): Likewise.
1400 (read_func_scope): Likewise.
1401 (read_call_site_scope): Likewise.
1402 (dwarf2_get_pc_bounds): Likewise.
1403 (dwarf2_record_block_ranges): Likewise.
1404 (dwarf2_add_field): Likewise.
1405 (dwarf2_add_member_fn): Likewise.
1406 (read_structure_type): Likewise.
1407 (read_enumeration_type): Likewise.
1408 (read_array_type): Likewise.
1409 (read_array_order): Likewise.
1410 (read_set_type): Likewise.
1411 (read_common_block): Likewise.
1412 (read_tag_reference_type): Likewise.
1413 (read_tag_string_type): Likewise.
1414 (read_subroutine_type): Likewise.
1415 (read_base_type): Likewise.
1416 (read_subrange_type): Likewise.
1417 (new_symbol): Likewise.
1418 (prepare_one_comp_unit): Likewise.
1420 2019-11-19 Tom Tromey <tromey@adacore.com>
1422 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1423 result in error when DebugActiveProcess fails.
1425 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1426 Pedro Alves <palves@redhat.com>
1428 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1429 * target.c (target_stack::push): Call 'unpush' if there's a
1430 target on top of the stack.
1432 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1434 * python/py-block.c (blpy_dealloc): Call tp_free.
1435 (blpy_block_syms_dealloc): Likewise.
1436 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1437 * python/py-inferior.c (infpy_dealloc): Likewise.
1438 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1439 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1440 * python/py-symbol.c (sympy_dealloc): Likewise.
1441 * python/py-symtab.c (stpy_dealloc): Likewise.
1442 * python/py-type.c (typy_iterator_dealloc): Likewise.
1444 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1446 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1447 constructor instead of using a class initializer.
1449 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1451 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1452 * configure: Regenerate.
1453 * configure.ac: Don't source common.host.
1454 * gdbsupport/common.host: Remove.
1455 * gdbsupport/mingw-strerror.c: Remove.
1456 * gdbsupport/posix-strerror.c: Rename to...
1457 * gdbsupport/safe-strerror.c: ...this.
1459 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1461 * maint.c (scoped_command_stats::print_time): Use localtime_r
1462 instead of localtime (provided through gnulib if necessary).
1463 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1466 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1468 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1469 avoid compile errors.
1471 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1473 * config.in: Regenerate.
1474 * configure: Regenerate.
1475 * gdbsupport/common.m4: No longer check for strerror_r.
1476 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1477 POSIX version of strerror_r, now that gnulib provides it if
1480 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1482 * README (`configure' options): Update.
1484 2019-11-14 Tom Tromey <tromey@adacore.com>
1486 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1487 expected type for the RHS if the LHS is a convenience variable.
1489 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1491 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1492 Provide explicit default and copy constructor.
1494 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1496 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1497 only call Py_INCREF (newbp) in the bppy_pending_object case.
1499 2019-11-13 Tom Tromey <tromey@adacore.com>
1502 * psympriv.h (partial_symbol): Remove static assert.
1503 * symtab.h (general_symbol_info, symbol): Remove static assert.
1505 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1507 * gdbsupport/format.c (format_pieces::format_pieces): Support
1508 printf 'z' size modifier.
1509 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1510 * printcmd.c (ui_printf): Handle size_t_arg.
1511 * ui-out.c (ui_out::vmessage): Likewise.
1512 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1514 (run_tests): Call test_format_int_sizes.
1516 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1518 * ada-exp.y (write_ambiguous_var): Update.
1519 * buildsym.c (add_symbol_to_list): Update.
1520 * dwarf2read.c (read_variable): Update.
1521 (new_symbol): Update.
1522 * jit.c (finalize_symtab): Update.
1523 * language.c (language_alloc_type_symbol): Update.
1524 * symtab.c (fixup_symbol_section): Update.
1525 (initialize_objfile_symbol_1): Move code to...
1526 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1527 (allocate_symbol): Update.
1528 (allocate_template_symbol): Update.
1529 (get_symbol_address): Update.
1530 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1531 of having as a field, and add a constructor.
1532 (SYMBOL_VALUE): Update.
1533 (SYMBOL_VALUE_ADDRESS): Update.
1534 (SET_SYMBOL_VALUE_ADDRESS): Update.
1535 (SYMBOL_VALUE_BYTES): Update.
1536 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1537 (SYMBOL_BLOCK_VALUE): Update.
1538 (SYMBOL_VALUE_CHAIN): Update.
1539 (SYMBOL_LANGUAGE): Update.
1540 (SYMBOL_SECTION): Update.
1541 (SYMBOL_OBJ_SECTION): Update.
1542 (SYMBOL_SET_LANGUAGE): Update.
1543 (SYMBOL_SET_LINKAGE_NAME): Update.
1544 (SYMBOL_SET_NAMES): Update.
1545 (SYMBOL_NATURAL_NAME): Update.
1546 (SYMBOL_LINKAGE_NAME): Update.
1547 (SYMBOL_DEMANGLED_NAME): Update.
1548 (SYMBOL_SEARCH_NAME): Update.
1549 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1550 (struct symbol): Update.
1551 (struct template_symbol): Update.
1552 (struct rust_vtable_symbol): Update.
1553 * xcoffread.c (SYMBOL_DUP): Update.
1555 2019-11-12 Tom Tromey <tom@tromey.com>
1557 * tui/tui-layout.c (show_layout): Set current_layout.
1558 (show_source_disasm_command, show_data)
1559 (show_source_or_disasm_and_command): Don't set current_layout.
1561 2019-11-12 Tom Tromey <tom@tromey.com>
1563 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1565 2019-11-12 Tom Tromey <tom@tromey.com>
1567 * tui/tui-win.c (resize_message): New global.
1568 (show_tui_resize_message): New function.
1569 (tui_async_resize_screen): Print message if requested.
1570 (_initialize_tui_win): Add tui-resize-message setting.
1571 * NEWS: Add entry for new commands.
1573 2019-11-11 Tom Tromey <tom@tromey.com>
1575 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1578 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1580 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1582 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1584 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1586 * python/python-internal.h (gdbpy_lookup_static_symbols):
1587 Declare new function.
1588 * python/python.c (python_GdbMethods): Add
1589 gdb.lookup_static_symbols method.
1590 * NEWS: Mention gdb.lookup_static_symbols.
1592 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1594 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1595 static block of current object file first. Also fix typo in
1598 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1600 * stack.c (set_last_displayed_sal): Delete.
1601 (last_displayed_sal_valid): Delete.
1602 (last_displayed_pspace): Delete.
1603 (last_displayed_addr): Delete.
1604 (last_displayed_symtab): Delete.
1605 (last_displayed_line): Delete.
1606 (class last_displayed_symtab_info_type): New.
1607 (last_displayed_symtab_info): New static global variable.
1608 (print_frame_info): Call methods on last_displayed_symtab_info.
1609 (clear_last_displayed_sal): Update header comment, and make use of
1610 last_displayed_symtab_info.
1611 (last_displayed_sal_is_valid): Likewise.
1612 (get_last_displayed_pspace): Likewise.
1613 (get_last_displayed_addr): Likewise.
1614 (get_last_displayed_symtab): Likewise.
1615 (get_last_displayed_line): Likewise.
1616 (get_last_displayed_sal): Likewise.
1617 * stack.h (clear_last_displayed_sal): Update header comment.
1618 (last_displayed_sal_is_valid): Likewise.
1619 (get_last_displayed_pspace): Likewise.
1620 (get_last_displayed_addr): Likewise.
1621 (get_last_displayed_symtab): Likewise.
1622 (get_last_displayed_line): Likewise.
1623 (get_last_displayed_sal): Likewise.
1625 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1627 * stack.c (frame_show_address): Convert return type to bool.
1628 * stack.h (frame_show_address): Likewise, and update header
1631 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1633 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1634 * unittests/vec-utils-selftests.c: New file.
1635 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1637 2019-11-10 Tom Tromey <tom@tromey.com>
1639 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1640 (tui_highlight_win): Likewise.
1641 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1642 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1643 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1644 Don't set can_highlight.
1646 2019-11-10 Tom Tromey <tom@tromey.com>
1648 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1649 Remove unused declaration.
1651 2019-11-08 Tom Tromey <tromey@adacore.com>
1653 * top.c (read_command_file): Update.
1654 (command_line_input): Make return type const.
1655 * python/py-gdb-readline.c: Update.
1656 * linespec.c (decode_line_2): Update.
1657 * defs.h (command_line_input): Make return type const.
1658 * cli/cli-script.c (read_next_line): Make return type const.
1659 * ada-lang.c (get_selections): Update.
1661 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1663 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1664 * mi/mi-main.c (output_cores): Likewise.
1665 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1666 (linux_xfer_osdata_modules): Likewise.
1667 * remote.c (register_remote_support_xml): Likewise.
1668 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1669 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1671 2019-11-06 Tom Tromey <tom@tromey.com>
1673 * tui/tui-interp.c: Don't include readline.h.
1674 * tui/tui-hooks.c: Don't include readline.h.
1675 * symmisc.c: Include tilde.h, not readline.h.
1676 * symfile.c: Include tilde.h, not readline.h.
1677 * source.c: Include tilde.h, not readline.h.
1678 * solib.c: Include tilde.h, not readline.h.
1679 * psymtab.c: Include tilde.h, not readline.h.
1680 * exec.c: Include tilde.h, not readline.h.
1681 * corelow.c: Include tilde.h, not readline.h.
1682 * cli/cli-dump.c: Include tilde.h, not readline.h.
1683 * cli/cli-cmds.c: Don't include readline.h.
1685 2019-11-05 Tom Tromey <tom@tromey.com>
1687 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1688 (tui_disassemble): Set addr_size.
1689 (tui_disasm_window::set_contents): Use addr_size.
1691 2019-11-05 Tom Tromey <tom@tromey.com>
1693 * rust-lang.c (rust_language_defn): Update.
1694 * python/py-value.c (valpy_string): Call c_get_string.
1695 * p-lang.c (pascal_language_defn): Update.
1696 * opencl-lang.c (opencl_language_defn): Update.
1697 * objc-lang.c (objc_language_defn): Update.
1698 * m2-lang.c (m2_language_defn): Update.
1699 * language.c (unknown_language_defn, auto_language_defn): Update.
1700 (default_get_string): Remove.
1701 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1702 * go-lang.c (go_language_defn): Update.
1703 * f-lang.c (f_language_defn): Update.
1704 * d-lang.c (d_language_defn): Update.
1705 * c-lang.c (c_language_defn, cplus_language_defn)
1706 (asm_language_defn, minimal_language_defn): Update.
1707 * ada-lang.c (ada_language_defn): Update.
1708 * language.h (struct language_defn) <la_get_string>: Remove.
1709 (LA_GET_STRING): Remove.
1710 (default_get_string): Don't declare.
1712 2019-11-05 Tom Tromey <tom@tromey.com>
1714 * tui/tui-source.h (struct tui_source_window): Inline
1715 constructor. Remove destructor.
1716 <style_changed, m_observable>: Move to superclass.
1717 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1718 (struct tui_source_window_base): Move private members to end.
1719 <style_changed, m_observable>: Move from tui_source_window.
1720 * tui/tui-winsource.c (tui_copy_source_line): Move from
1721 tui-source.c. Rename from copy_source_line. Add special handling
1722 for negative line number.
1723 (tui_source_window_base::style_changed): Move from
1725 (tui_source_window_base): Register observer.
1726 (~tui_source_window_base): New.
1727 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1729 (tui_source_window::set_contents): Use tui_copy_source_line.
1730 (tui_source_window::tui_source_window): Move to tui-source.h.
1731 (tui_source_window::~tui_source_window): Remove.
1732 (tui_source_window::style_changed): Move to superclass.
1733 * tui/tui-disasm.c (tui_disassemble): Create string file with
1734 styling, when possible. Add "addr_size" parameter.
1735 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1736 Don't compute maximum size.
1737 (len_without_escapes): New function
1739 2019-11-05 Tom Tromey <tom@tromey.com>
1741 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1743 * tui/tui-winsource.c (tui_show_source_line): Update.
1744 * tui/tui-source.c (tui_source_window::set_contents): Update.
1745 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1747 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1749 * symtab.h (gdb_static_assert): Put && operator at the beginning
1750 of the line instead of the end.
1752 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1754 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1755 and sizeof (symbol).
1756 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1758 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1760 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1761 * configure.host: Mark *-*-solaris2.10* obsolete.
1762 * configure.tgt: Mark Solaris < 11 obsolete.
1763 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1764 Update target triplet.
1766 2019-11-01 Tom Tromey <tromey@adacore.com>
1768 * utils.c (print_sys_errmsg): Simplify.
1770 2019-11-01 Tom Tromey <tromey@adacore.com>
1772 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1774 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1776 * configure: Regenerate.
1777 * configure.ac: Remove check for strerror_r.
1778 * gdbsupport/common.m4: Check for strerror_r.
1780 2019-11-01 Luis Machado <luis.machado@linaro.org>
1784 * arm-tdep.c (arm_per_objfile): Rename to ...
1785 (arm_per_bfd): ... this.
1786 (arm_objfile_data_key): Rename to ...
1787 (arm_bfd_data_key): ... this.
1788 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1790 (arm_record_special_symbol): Likewise.
1792 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1794 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1796 * c-typeprint.c (c_print_typedef): Likewise.
1797 * f-typeprint.c (f_print_typedef): Likewise.
1798 * m2-typeprint.c (m2_print_typedef): Likewise.
1799 * p-typeprint.c (pascal_print_typedef): Likewise.
1800 * rust-lang.c (rust_print_typedef): Likewise.
1801 * symtab.c (print_symbol_info): Print a newline after calling
1804 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1806 * symtab.c (info_module_cmdlist): New variable.
1807 (info_module_command): New function.
1808 (search_module_symbols): New function.
1809 (info_module_subcommand): New function.
1810 (struct info_modules_var_func_options): New struct.
1811 (info_modules_var_func_options_defs): New variable.
1812 (make_info_modules_var_func_options_def_group): New function.
1813 (info_module_functions_command): New function.
1814 (info_module_variables_command): New function.
1815 (info_module_var_func_command_completer): New function.
1816 (_initialize_symtab): Register new 'info module functions' and
1817 'info module variables' commands.
1818 * symtab.h (typedef symbol_search_in_module): New typedef.
1819 (search_module_symbols): Declare new function.
1820 * NEWS: Mention new commands.
1822 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1824 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1825 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1826 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1828 (scan_partial_symbols): Only create partial module symbols for non
1830 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1832 * symtab.c (search_domain_name): Likewise.
1833 (search_symbols): Likewise.
1834 (print_symbol_info): Likewise.
1835 (symtab_symbol_info): Likewise.
1836 (info_modules_command): New function.
1837 (_initialize_symtab): Register 'info modules' command.
1838 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1839 * NEWS: Mention new 'info modules' command.
1841 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1843 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1844 and $_gdb_maint_setting_str.
1846 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1848 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1849 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1850 (str_value_from_setting, gdb_setting_str_internal_fn)
1851 (gdb_maint_setting_str_internal_fn): New functions.
1852 (_initialize_cli_cmds): Define the new convenience functions.
1853 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1854 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1856 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1858 * agent.c (set_can_use_agent): When the setting is turned on,
1859 look up agent symbols if we don't have them yet.
1860 (agent_new_objfile): Don't look up agent symbols when the agent
1863 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1865 * config.in: Regenerate.
1867 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1869 * configure: Regenerate.
1870 * configure.ac: Check for strerror_r.
1871 * gdbsupport/common-utils.h (safe_strerror): Change return value
1872 to const char * and document that this function is now threadsafe.
1873 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1874 thread_local and call strerror_r, if available.
1875 * utils.c (perror_string): Update.
1876 (print_sys_errmsg): Update.
1878 2019-10-31 Luis Machado <luis.machado@linaro.org>
1880 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1882 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1883 objfile to fetch per-bfd data.
1884 (arm_find_exidx_entry): Likewise.
1886 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1888 * gdbsupport/agent.c (debug_agent): Change type to bool.
1889 (use_agent): Likewise.
1890 (all_agent_symbols_look_up): Likewise.
1891 (agent_loaded_p): Change return value to bool.
1892 (agent_look_up_symbols): Update.
1893 (agent_capability_check): Change return value to bool.
1894 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1895 (debug_agent): Change type to bool.
1896 (use_agent): Likewise.
1897 (agent_capability_check): Change return value to bool.
1899 2019-10-30 Christian Biesinger <cbiesinger@google.com>
1901 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1902 (build_minimal_symbol_hash_tables): Code to clear the table moved
1903 to clear_minimal_symbol_hash_tables.
1904 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1907 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1909 * infcmd.c: Remove includes.
1910 * infrun.c: Remove includes.
1912 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1914 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1915 (grow_vect): Remove declaration.
1916 (ada_type_of_array): Remove declaration.
1917 (ada_update_initial_language): Remove declaration.
1918 (ada_fold_name): Remove declaration.
1919 (ada_fill_in_ada_prototype): Remove declaration.
1920 (user_select_syms): Remove declaration.
1921 (get_selections): Remove declaration.
1922 (ada_tag_type): Remove declaration.
1923 (ada_value_tag): Remove declaration.
1924 (ada_is_others_clause): Remove declaration.
1925 (ada_in_variant): Remove declaration.
1926 (ada_value_struct_elt): Remove declaration.
1927 (ada_attribute_name): Remove declaration.
1928 (ada_system_address_type): Remove declaration.
1929 * ada-lang.c (ada_watch_location_expression): Make static.
1930 (GROW_VECT): Move here from ada-lang.h.
1931 (grow_vect): Make static.
1932 (ada_update_initial_language): Make static.
1933 (ada_fold_name): Make static.
1934 (ada_type_of_array): Make static.
1935 (encoded_ordered_before): Move up.
1936 (sort_choices): Move up.
1937 (print_signatures): Move up.
1938 (ada_print_symbol_signature): Move up.
1939 (get_selections): Move up and make static.
1940 (user_select_syms): Move up and make static.
1941 (ada_value_struct_elt): Move up and make static.
1942 (ada_tag_type): Make static.
1943 (ada_value_tag): Make static.
1944 (ada_is_others_clause): Make static.
1945 (ada_in_variant): Make static.
1946 (ada_attribute_name): Make static.
1948 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1950 * ada-lang.c: Remove includes.
1951 * ada-typeprint.c: Remove includes.
1952 * ada-valprint.c: Remove includes.
1954 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
1956 * addrmap.c: Add static assertions of type size, moved from
1957 _initialize_addrmap.
1958 (_initialize_addrmap): Remove.
1960 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1962 * coffread.c (record_minimal_symbol): Update.
1963 (process_coff_symbol): Update.
1964 * dbxread.c (read_dbx_symtab): Update.
1965 * dwarf2read.c (add_partial_symbol): Update.
1966 (fixup_go_packaging): Update.
1967 (load_partial_dies): Update.
1968 (new_symbol): Update.
1969 * elfread.c (record_minimal_symbol): Change signature to use
1970 gdb::string_view instead of name+len.
1971 (elf_symtab_read): Update.
1972 (elf_rel_plt_read): Update.
1973 * mdebugread.c (parse_partial_symbols): Update.
1974 (handle_psymbol_enumerators): Update.
1975 (new_symbol): Update.
1976 * minsyms.c (minimal_symbol_reader::record_full): Change signature
1977 to use gdb::string_view instead of name+len.
1978 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1979 * psympriv.h (add_psymbol_to_list): Likewise.
1980 * psymtab.c (add_psymbol_to_bcache): Likewise.
1981 (add_psymbol_to_list): Likewise.
1982 * stabsread.c (define_symbol): Update.
1983 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1984 * symtab.h (SYMBOL_SET_NAMES): Likewise.
1985 (symbol_set_names): Likewise.
1986 * xcoffread.c (scan_xcoff_symtab): Update.
1988 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1990 * symtab.h (symbol_set_names): Document that copy_name must be
1991 set to true for non-nullterminated strings.
1992 * symtab.c (symbol_set_names): Only make a nullterminated copy of
1993 linkage_name if the entry was not found and we need to demangle.
1995 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1997 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1998 * dwarf2-frame.c (bsearch_fde_cmp): Update.
1999 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2000 * gdbsupport/gdb_binary_search.h: New file.
2002 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2004 * NEWS: Mention new --with-system-gdbinit-dir option.
2005 * config.in: Regenerate.
2006 * configure: Regenerate.
2007 * configure.ac: Add new option --with-system-gdbinit-dir.
2008 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2009 for a ".gdb" suffix.
2010 * main.c (get_init_files): Change system_gdbinit argument to
2011 a vector and return the files in SYSTEM_GDBINIT_DIR in
2012 addition to SYSTEM_GDBINIT.
2013 (captured_main_1): Update.
2014 (print_gdb_help): Update.
2015 * top.c (print_gdb_configuration): Also print the value of
2018 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2020 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2021 that takes gdb::string_view arguments.
2023 2019-10-26 Tom de Vries <tdevries@suse.de>
2025 * aarch64-linux-tdep.c: Fix typos in comments.
2026 * aarch64-tdep.c: Same.
2028 * amd64-nat.c: Same.
2030 * arch/aarch64-insn.c: Same.
2032 * breakpoint.h: Same.
2035 * cli/cli-decode.c: Same.
2036 * cli/cli-script.c: Same.
2037 * cli/cli-utils.h: Same.
2038 * coff-pe-read.c: Same.
2040 * compile/compile-cplus-symbols.c: Same.
2041 * compile/compile-object-run.c: Same.
2042 * completer.c: Same.
2044 * cp-support.c: Same.
2046 * dwarf-index-write.c: Same.
2047 * dwarf2-frame.c: Same.
2048 * dwarf2-frame.h: Same.
2050 * frame-base.h: Same.
2055 * guile/scm-objfile.c: Same.
2056 * i386-tdep.c: Same.
2057 * i386-tdep.h: Same.
2060 * linux-nat.c: Same.
2061 * m68k-tdep.c: Same.
2064 * mi/mi-cmd-disas.c: Same.
2065 * mi/mi-getopt.h: Same.
2066 * mi/mi-main.c: Same.
2068 * nat/aarch64-sve-linux-sigcontext.h: Same.
2070 * ppc-linux-nat.c: Same.
2071 * ppc-linux-tdep.c: Same.
2073 * progspace.h: Same.
2074 * prologue-value.h: Same.
2075 * python/py-evtregistry.c: Same.
2076 * python/py-instruction.h: Same.
2077 * record-btrace.c: Same.
2078 * record-full.c: Same.
2080 * rs6000-tdep.c: Same.
2082 * sol-thread.c: Same.
2083 * sparc-sol2-tdep.c: Same.
2084 * sparc64-tdep.c: Same.
2085 * stabsread.c: Same.
2089 * tracepoint.c: Same.
2090 * tui/tui-data.h: Same.
2091 * tui/tui-io.c: Same.
2092 * tui/tui-win.c: Same.
2094 * unittests/rsp-low-selftests.c: Same.
2095 * user-regs.h: Same.
2106 * xtensa-tdep.c: Same.
2108 2019-10-25 Ali Tamur <tamur@google.com>
2110 * charset.c (find_charset_names): Reflect API change.
2112 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2114 * symtab.c (struct demangled_name_entry): Change demangled name
2115 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2116 part of the struct anymore.
2117 (symbol_set_names): No longer obstack allocate + copy the demangled
2118 name, just store the allocated name from bfd.
2120 2019-10-25 Tom Tromey <tromey@adacore.com>
2122 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2123 (bsearch_cie_cmp, add_cie): Remove.
2124 (find_cie): Reimplement.
2125 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2126 (dwarf2_build_frame_info): Update.
2128 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2131 * symfile.c (reread_symbols): Call forget_cached_source_info to
2132 clear the stale source cache.
2134 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2136 * configure: Regenerate.
2137 * configure.ac: Remove code that sets python_has_threads.
2139 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2141 * config.in: Regenerate.
2142 * configure: Regenerate.
2143 * configure.ac: Remove the code that uses sed to get the python
2144 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2146 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2148 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2151 2019-10-23 Tom Tromey <tom@tromey.com>
2153 * arc-tdep.c: Remove ".." from include.
2154 * frv-tdep.c: Remove ".." from include.
2155 * lm32-tdep.c: Remove ".." from include.
2156 * microblaze-tdep.c: Remove ".." from include.
2157 * or1k-tdep.h: Remove ".." from include.
2158 * s12z-tdep.c: Remove ".." from include.
2159 * Makefile.in (OPCODES_CFLAGS): Add comment.
2160 (TOP_CFLAGS): New variable.
2161 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2163 2019-10-23 Tom Tromey <tom@tromey.com>
2165 * Makefile.in (READLINE_DIR): Update.
2167 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2169 * infcall.c (call_function_by_hand_dummy): Fix the function
2170 comment. And extract out a code section into...
2171 (reserve_stack_space): ...this new function.
2173 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2175 * infcall.c (value_arg_coerce): Remove an unused parameter.
2176 (call_function_by_hand_dummy): Update the call to
2179 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2181 * infcall.c (call_function_by_hand_dummy): Refactor.
2183 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2185 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2187 2019-10-23 Tom Tromey <tom@tromey.com>
2189 * configure: Rebuild.
2190 * configure.ac: Don't check for sigprocmask.
2191 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2193 2019-10-23 Tom Tromey <tom@tromey.com>
2195 * configure: Rebuild.
2196 * acinclude.m4: Use m4_include, not sinclude.
2198 2019-10-23 Tom de Vries <tdevries@suse.de>
2200 PR breakpoints/24687
2201 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2203 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2205 * symtab.c (struct demangled_name_entry) <language>: Change from
2206 bitfield to regular variable.
2208 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2210 * symtab.c (struct demangled_name_entry): Add a constructor.
2211 (free_demangled_name_entry): New function to call the destructor
2212 for demangled_name_entry.
2213 (create_demangled_names_hash): Pass free_demangled_name_entry to
2215 (symbol_set_names): Call placement new for demangled_name_entry.
2216 * utils.c: No longer include xxhash.h here, now that fast_hash
2217 is inlined in the header.
2218 * utils.h: Instead, include it here.
2220 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2222 * Makefile.in: Link with libxxhash.
2223 * config.in: Regenerate.
2224 * configure: Regenerate.
2225 * configure.ac: Search for libxxhash.
2226 * utils.c (fast_hash): Use xxhash if present.
2228 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2230 * utils.h (fast_hash): New function.
2231 * symtab.c (hash_demangled_name_entry): Call new function
2234 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2236 * symtab.c (struct demangled_name_entry): Change type of mangled
2237 to gdb::string_view. Also adds a constructor that takes the
2239 (hash_demangled_name_entry): Update.
2240 (eq_demangled_name_entry): Update.
2241 (free_demangled_name_entry): New function to call the destructor
2242 now that this is not a POD anymore.
2243 (create_demangled_names_hash): Pass free_demangled_name_entry to
2245 (symbol_set_names): Update.
2247 2019-10-21 Ali Tamur <tamu@google.com>
2249 * dwarf2read.c (dir_index): Change type.
2250 (file_name_index): Likewise.
2251 (line_header::include_dir_at): Change comment and implementation on
2252 whether it is DWARF 5.
2253 (line_header::is_valid_file_index): New function.
2254 (line_header::file_name_at): Change comment and implementation on
2255 whether it is DWARF 5.
2256 (line_header::file_names): Change to private field renamed as
2257 m_file_names and introduce a new accessor method.
2258 (line_header::file_names_size): New method.
2259 (line_header::include_dirs): Change to private field and rename as
2261 (dw2_get_file_names_reader): Define local var at a smaller scope and
2263 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2264 (process_structure_scope): Likewise.
2265 (line_header::add_include_dir): Change message and reflect renaming.
2266 (line_header::add_file_name): Likewise.
2267 (read_formatted_entries): Handle DW_FORM_data16.
2268 (dwarf_decode_line_header): Fix line header length calculation.
2269 (psymtab_include_file_name): Change comment and API.
2270 (lnp_state_machine::m_file): Update comment and reflect type change.
2271 (lnp_state_machine::record_line): Reflect type change.
2272 (dwarf_decode_lines): Reflect API change.
2273 (file_file_name): Likewise.
2274 (file_full_name): Likewise.
2276 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2278 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2280 2019-10-21 Tom Tromey <tom@tromey.com>
2282 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2284 2019-10-21 Tom Tromey <tom@tromey.com>
2286 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2287 NM_H. Use AC_CONFIG_LINKS.
2288 * configure: Rebuild.
2289 * Makefile.in (NM_H): New variable.
2290 (generated_files): Add NM_H. Remove gcore.
2291 (nm.h, stamp-nmh): New targets.
2293 2019-10-20 Tom Tromey <tom@tromey.com>
2295 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2296 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2298 (put_objfile_before): Now static.
2300 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2302 * gdbsupport/common-utils.h (startswith): Change return type to
2305 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2307 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2308 * breakpoint.c (bp_locations_compare): Rename to...
2309 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2310 (update_global_location_list): Use std::sort instead of qsort.
2311 * buildsym.c (compare_line_numbers): Rename to...
2312 (lte_is_less_than): ...this, and change to std::sort semantics.
2313 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2315 * disasm.c (compare_lines): Rename to...
2316 (line_is_less_than): ...this, and change to std::sort semantics.
2317 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2319 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2320 (fde_is_less_than): ...this, and change to std::sort semantics.
2321 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2322 * mdebugread.c (compare_blocks):
2323 (block_is_less_than): ...this, and change to std::sort semantics.
2324 (sort_blocks): Call std::sort instead of qsort.
2325 * objfiles.c (qsort_cmp): Rename to...
2326 (sort_cmp): ...this, and change to std::sort semantics.
2327 (update_section_map): Call std::sort instead of qsort.
2328 * remote.c (compare_pnums): Remove.
2329 (map_regcache_remote_table): Call std::sort instead of qsort.
2330 * utils.c (compare_positive_ints): Remove.
2331 * utils.h (compare_positive_ints): Remove.
2332 * xcoffread.c (compare_lte): Remove.
2333 (arrange_linetable): Call std::sort instead of qsort.
2335 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2337 * symfile.c (init_entry_point_info): Fix typo.
2338 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2340 2019-10-18 Tom de Vries <tdevries@suse.de>
2342 * aarch64-tdep.c: Fix typos in comments.
2344 * ada-tasks.c: Same.
2345 * alpha-tdep.c: Same.
2346 * alpha-tdep.h: Same.
2347 * amd64-nat.c: Same.
2348 * amd64-windows-tdep.c: Same.
2351 * arch-utils.c: Same.
2352 * arm-nbsd-tdep.c: Same.
2355 * blockframe.c: Same.
2358 * coff-pe-read.c: Same.
2360 * cris-tdep.c: Same.
2361 * darwin-nat.c: Same.
2365 * dtrace-probe.c: Same.
2366 * dwarf-index-write.c: Same.
2367 * dwarf2-frame-tailcall.c: Same.
2368 * dwarf2-frame.c: Same.
2369 * dwarf2read.c: Same.
2371 * exceptions.c: Same.
2372 * fbsd-tdep.c: Same.
2376 * gnu-v3-abi.c: Same.
2378 * h8300-tdep.c: Same.
2379 * hppa-tdep.c: Same.
2380 * i386-linux-tdep.c: Same.
2381 * i386-tdep.c: Same.
2382 * ia64-libunwind-tdep.c: Same.
2383 * ia64-tdep.c: Same.
2387 * linux-nat.c: Same.
2388 * linux-thread-db.c: Same.
2389 * machoread.c: Same.
2390 * mdebugread.c: Same.
2392 * mn10300-tdep.c: Same.
2393 * namespace.c: Same.
2395 * opencl-lang.c: Same.
2396 * or1k-tdep.c: Same.
2398 * ppc-linux-nat.c: Same.
2399 * ppc-linux-tdep.c: Same.
2400 * ppc-sysv-tdep.c: Same.
2403 * record-btrace.c: Same.
2404 * record-full.c: Same.
2405 * remote-fileio.c: Same.
2407 * rs6000-tdep.c: Same.
2408 * s12z-tdep.c: Same.
2409 * score-tdep.c: Same.
2413 * sol-thread.c: Same.
2414 * solib-svr4.c: Same.
2417 * sparc-nat.c: Same.
2418 * sparc-sol2-tdep.c: Same.
2419 * sparc-tdep.c: Same.
2420 * sparc64-tdep.c: Same.
2421 * stabsread.c: Same.
2425 * target-descriptions.c: Same.
2426 * target-float.c: Same.
2433 * windows-nat.c: Same.
2434 * xcoffread.c: Same.
2435 * xstormy16-tdep.c: Same.
2436 * xtensa-tdep.c: Same.
2438 2019-10-17 Tom Tromey <tromey@adacore.com>
2440 * configure: Rebuild.
2441 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2442 in AC_CONFIG_FILES invocation.
2443 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2444 new-style config.status invocation.
2446 2019-10-17 Tom de Vries <tdevries@suse.de>
2448 * arm-nbsd-nat.c: Fix typos in comments.
2450 * darwin-nat-info.c: Same.
2451 * dwarf2read.c: Same.
2453 * event-top.c: Same.
2456 * hppa-tdep.c: Same.
2457 * i386-tdep.c: Same.
2460 * mdebugread.c: Same.
2461 * moxie-tdep.c: Same.
2462 * nto-procfs.c: Same.
2464 * ppc-linux-tdep.c: Same.
2466 * riscv-tdep.c: Same.
2467 * s390-tdep.c: Same.
2469 * sparc-linux-tdep.c: Same.
2470 * sparc-nat.c: Same.
2472 * target-descriptions.c: Same.
2476 2019-10-16 Tom Tromey <tom@tromey.com>
2478 * objfiles.h (struct objfile) <original_name>: Now const.
2480 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2482 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2483 pass on to sigsetjmp's second argument.
2484 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2486 2019-10-16 Keith Seitz <keiths@redhat.com>
2489 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2490 sections whose size is greater than the file size.
2492 2019-10-16 Jim Wilson <jimw@sifive.com>
2494 * riscv-tdep.c (riscv_gcc_target_options): New.
2495 (riscv_gnu_triplet_regexp): New.
2496 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2497 set_gdbarch_gnu_triplet_regexp.
2499 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2501 * Makefile.in: Add xml-builtin.h.
2502 * features/feature_to_c.sh: Add an include for xml-builtin.h
2503 to ensure that the compiler checks that the types match.
2504 * xml-builtin.h: New file.
2505 * xml-support.c (fetch_xml_builtin): Add missing const.
2506 * xml-support.h: Remove declaration of xml_builtins.
2508 2019-10-16 Tom de Vries <tdevries@suse.de>
2511 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2512 (amd64_classify_aggregate): ... here.
2513 (amd64_classify_aggregate_field): Handled fiels of nested structs
2516 2019-10-16 Tom de Vries <tdevries@suse.de>
2519 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2520 that handles 'theclass'.
2522 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2524 * linespec.c (decode_digits_ordinary): Update comment.
2525 * make-target-delegates: No longer need to handle VEC case.
2526 * memrange.c (normalize_mem_ranges): Update comment.
2527 * namespace.c (add_using_directive): Update comment.
2528 * objc-lang.c (uniquify_strings): Update comment.
2529 * ppc-linux-nat.c (struct thread_points): Update comment.
2530 * probe.h (find_probes_in_objfile): Update comment.
2531 * target.h (enum flash_preserve_mode): Update comment.
2532 * varobj.c (varobj_restrict_range): Update comment.
2533 * varobj.h (varobj_list_children): Update comment.
2535 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2537 * Makefile.in: Remove references to vec.h and vec.c.
2538 * aarch64-tdep.c: No longer include vec.h.
2539 * ada-lang.c: Likewise.
2540 * ada-lang.h: Likewise.
2541 * arm-tdep.c: Likewise.
2543 * breakpoint.h: Likewise.
2544 * charset.c: Likewise.
2545 * cp-support.h: Likewise.
2546 * dtrace-probe.c: Likewise.
2547 * dwarf2read.c: Likewise.
2548 * extension.h: Likewise.
2549 * gdb_bfd.c: Likewise.
2550 * gdbsupport/gdb_vecs.h: Likewise.
2551 * gdbsupport/vec.c: Remove.
2552 * gdbsupport/vec.h: Remove.
2553 * gdbthread.h: Likewise.
2554 * guile/scm-type.c: Likewise.
2555 * inline-frame.c: Likewise.
2556 * machoread.c: Likewise.
2557 * memattr.c: Likewise.
2558 * memrange.h: Likewise.
2559 * namespace.h: Likewise.
2560 * nat/linux-btrace.h: Likewise.
2561 * osdata.c: Likewise.
2562 * parser-defs.h: Likewise.
2563 * progspace.h: Likewise.
2564 * python/py-type.c: Likewise.
2565 * record-btrace.c: Likewise.
2566 * rust-exp.y: Likewise.
2567 * solib-target.c: Likewise.
2568 * stap-probe.c: Likewise.
2569 * target-descriptions.c: Likewise.
2570 * target-memory.c: Likewise.
2571 * target.h: Likewise.
2572 * varobj.c: Likewise.
2573 * varobj.h: Likewise.
2574 * xml-support.h: Likewise.
2576 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2578 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2579 Update for new std::vector based implementation.
2580 (process_psymtab_comp_unit_reader): Likewise.
2581 (scan_partial_symbols): Likewise.
2582 (recursively_compute_inclusions): Likewise.
2583 (compute_compunit_symtab_includes): Likewise.
2584 (process_imported_unit_die): Likewise.
2585 (queue_and_load_dwo_tu): Likewise.
2586 (follow_die_sig_1): Likewise.
2587 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2588 (typedef dwarf2_per_cu_ptr): Remove.
2589 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2591 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2592 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2593 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2594 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2597 2019-10-15 Tom Tromey <tromey@adacore.com>
2599 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2602 2019-10-15 Tom Tromey <tromey@adacore.com>
2604 * windows-nat.c (windows_nat_target::fetch_registers)
2605 (windows_nat_target::store_registers): Rename "pid" to "tid".
2607 2019-10-15 Tom Tromey <tromey@adacore.com>
2609 * gdbarch.h, gdbarch.c: Rebuild.
2610 * gdbarch.sh (gcc_target_options): Change return type to
2612 * compile/compile.c (get_args): Update.
2613 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2614 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2616 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2618 * arch-utils.c (default_gcc_target_options): Return std::string.
2619 * arch-utils.h (default_gcc_target_options): Return std::string.
2620 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2622 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2624 * breakpoint.c (breakpoint_chain): Make static.
2625 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2626 of accessing breakpoint_chain.
2628 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2630 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2631 to a gdb::function_view and return value to bool.
2632 * breakpoint.h (iterate_over_breakpoints): Likewise.
2633 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2634 (pop_dummy_frame): Update.
2635 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2636 (gdbscm_breakpoints): Update.
2637 * python/py-breakpoint.c (build_bp_list): Update.
2638 (gdbpy_breakpoints): Update.
2639 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2641 (bpfinishpy_handle_stop): Update.
2642 (bpfinishpy_handle_exit): Update.
2643 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2644 (svr4_update_solib_event_breakpoints): Update.
2646 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2648 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2649 when unwrapping single-field structs.
2651 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2653 * dwarf2read.c: Remove includes.
2655 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2657 * ui-out.c (ui_out::call_do_message): Silence
2658 -Wformat-nonliteral warning.
2660 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2662 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2663 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2664 include: readline/tilde.h.
2666 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2668 * remote.c (remote_target::get_trace_status): Remove declaration of
2669 trace_regblock_size.
2671 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2673 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2674 (show_user): Remove declaration of cmdlist.
2675 * cli/cli-cmds.h (max_user_call_depth): Declare.
2676 * cli/cli-script.c (execute_user_command): Remove declaration
2677 of max_user_call_depth.
2679 2019-10-11 Jim Wilson <jimw@sifive.com>
2681 * gdbsupport/print-utils.h (pulongest): Fix comment.
2682 (plongest): Likewise.
2683 (phex): Add missing comment, mention leading zeros.
2684 (phex_nz): Add mention of no leading zeros to comment.
2686 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2687 plongest instead of unsigned long long cast.
2689 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2691 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2692 for external_editor_command and gdbtk_test.
2694 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2696 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2697 * varobj.c (varobjdebug): Move comment to...
2698 * varobj.h (varobjdebug): ...here, and declare.
2700 2019-10-09 Tom Tromey <tom@tromey.com>
2702 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2705 2019-10-09 Tom Tromey <tom@tromey.com>
2707 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2708 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2709 * tui/tui-command.c (tui_cmd_window::resize)
2710 (tui_refresh_cmd_win): Update.
2711 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2712 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2713 * tui/tui-data.c (~tui_gen_win_info): Remove.
2714 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2715 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2716 (tui_redisplay_readline, tui_mld_flush)
2717 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2718 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2719 (tui_data_window::erase_data_content)
2720 (tui_data_item_window::rerender)
2721 (tui_data_item_window::refresh_window): Update.
2722 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2723 (box_win, tui_gen_win_info::make_window)
2724 (tui_gen_win_info::make_visible): Update.
2725 (tui_delete_win): Remove.
2726 * tui/tui-winsource.c
2727 (tui_source_window_base::do_erase_source_content): Update.
2728 (tui_show_source_line, tui_source_window_base::update_tab_width)
2729 (tui_source_window_base::update_exec_info): Update.
2730 * tui/tui-data.h (struct curses_deleter): New.
2731 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2732 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2734 2019-10-09 Tom Tromey <tom@tromey.com>
2736 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2738 2019-10-09 Tom Tromey <tom@tromey.com>
2740 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2741 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2743 2019-10-09 Tom Tromey <tom@tromey.com>
2745 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2746 window height directly.
2747 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2749 * tui/tui-layout.c (tui_default_win_height): Remove.
2750 (tui_default_win_viewport_height): Remove.
2752 2019-10-09 Tom Tromey <tom@tromey.com>
2754 * tui/tui.h: Remove comments.
2756 2019-10-09 Tom de Vries <tdevries@suse.de>
2758 * python/lib/gdb/printer/bound_registers.py: Use
2759 '^builtin_type_bound128' as regexp argument for
2760 add_builtin_pretty_printer.
2762 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2764 * guile/guile.c (guile_extension_script_ops): Remove forward
2765 declaration and mark as static.
2766 (guile_script_ops): Likewise.
2767 (extension_language_guile): Move further down in the file so
2768 it can reference the definitions for guile_{extension_,}script_ops.
2770 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2772 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2773 except SORTL, DFLTCC, and KDSA.
2775 2019-10-08 Tom Tromey <tromey@adacore.com>
2777 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2778 (struct safe_symbol_file_add_args): Remove.
2780 2019-10-08 Tom Tromey <tromey@adacore.com>
2782 * windows-nat.c: Don't include buildsym-legacy.h.
2784 2019-10-08 Tom Tromey <tromey@adacore.com>
2786 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2788 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2790 * gdbtypes.c (overload_debug): Move comment to header.
2791 * gdbtypes.h (overload_debug): Declare.
2792 * valops.c: Remove declaration of overload_debug, instead
2795 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2797 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2799 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2801 * language.h (lang_frame_mismatch_warn): ... here. Also add
2803 * top.c (lang_frame_mismatch_warn): Remove declaration.
2804 (check_frame_language_change): Pass lang_frame_mismatch_warn
2807 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2809 * c-lang.h (vtbl_ptr_name): Declare.
2810 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2812 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2814 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2816 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2819 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2821 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2822 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2823 * ctfread.c: New file.
2824 * ctfread.h: New file.
2825 * elfread.c: Include ctfread.h.
2826 (struct elfinfo text_p): New member ctfsect.
2827 (elf_locate_sections): Mark CTF section.
2828 (elf_symfile_read): Call elfctf_build_psymtabs.
2829 * Makefile.in (LIBCTF): Add.
2832 (DIST): Add ctfread.c.
2834 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2836 * ctfread.c (struct nextfield): Renamed to ...
2837 (struct ctf_nextfield): ... this.
2838 (struct field_info): Renamed to ...
2839 (strut ctf_field_info): ... this.
2840 (attach_fields_to_type): Update for renamed structures.
2841 (ctf_add_member_cb): Likewise.
2842 (ctf_add_enum_member_cb): Likewise.
2843 (process_struct_members): Likewise.
2844 (process_enum_type): Likewise.
2846 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2848 * tracectf.h: Rename, was ctf.h.
2849 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2850 * tracefile.c: Likewise.
2851 * tracepoint.c: Remove unused include ctf.h.
2852 * mi/mi-main.c: Likewise.
2853 * Makefile.in Replace ctf.c with tracectf.c.
2855 2019-10-06 Joel Brobecker <brobecker@adacore.com>
2857 * version.in: Change version number to "9.0.50.DATE-git".
2859 2019-10-03 Tom Tromey <tom@tromey.com>
2862 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2864 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2866 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2867 cp_search_name_hash.
2868 * NEWS: Add entry about nested function support.
2870 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2871 Andrew Burgess <andrew.burgess@embecosm.com>
2873 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2874 for nested static variables when searchin VAR_DOMAIN.
2875 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2876 global scope, update comment.
2877 (add_partial_subprogram): Call add_partial_subprogram recursively
2878 for nested subroutines when processinng Fortran.
2879 (load_partial_dies): Process the child entities of a subprogram
2880 when processing Fortran.
2881 (partial_die_parent_scope): Handle building scope
2882 for Fortran nested functions.
2883 (process_die): Record that nested functions have a scope.
2884 (new_symbol): Always record Fortran subprograms on the global
2886 (determine_prefix): How to build the prefix for Fortran
2889 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2891 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2892 have just sent the thread a SIGSTOP and are waiting for it to
2895 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2897 * btrace.c (btrace_add_pc): Remove whitespace before the template
2898 parameter in 'std::vector <...>'.
2899 (parse_xml_btrace_block): Likewise.
2900 (btrace_maint_decode_pt): Likewise.
2901 (btrace_maint_update_packets): Likewise.
2902 (btrace_maint_print_packets): Likewise.
2903 * btrace.h (struct btrace_maint_info): Likewise.
2904 * dwarf2read.c (struct type_unit_group): Likewise.
2905 (build_type_psymtabs_reader): Likewise.
2906 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2907 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2908 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2910 2019-10-03 Tom de Vries <tdevries@suse.de>
2912 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2913 the first line of the help text for set/show style metadata.
2915 2019-10-02 Tom Tromey <tromey@adacore.com>
2917 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2918 * gdbsupport/common-inferior.c: New file.
2919 * infcmd.c (startup_with_shell): Don't define.
2920 * nat/fork-inferior.h (startup_with_shell): Don't declare.
2921 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2922 * inferior.h (startup_with_shell): Don't declare.
2924 2019-10-02 Christian Biesinger <cbiesinger@google.com>
2926 * gdbsupport/gdb_assert.h: Include errors.h.
2927 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2929 2019-10-02 Tom Tromey <tromey@adacore.com>
2931 * NEWS: Add $_ada_exception entry.
2932 * ada-lang.c (struct ada_catchpoint): Add constructor.
2933 <m_kind>: New member.
2934 (allocate_location_exception, re_set_exception): Remove
2936 (should_stop_exception): Compute $_ada_exception.
2937 (check_status_exception, print_it_exception)
2938 (print_one_exception, print_mention_exception): Remove
2940 (allocate_location_catch_exception, re_set_catch_exception)
2941 (check_status_exception, print_it_catch_exception)
2942 (print_one_catch_exception, print_mention_catch_exception)
2943 (print_recreate_catch_exception)
2944 (allocate_location_catch_exception_unhandled)
2945 (re_set_catch_exception_unhandled)
2946 (check_status_exception, print_it_catch_exception_unhandled)
2947 (print_one_catch_exception_unhandled)
2948 (print_mention_catch_exception_unhandled)
2949 (print_recreate_catch_exception_unhandled)
2950 (allocate_location_catch_assert, re_set_catch_assert)
2951 (check_status_assert, print_it_catch_assert)
2952 (print_one_catch_assert, print_mention_catch_assert)
2953 (print_recreate_catch_assert)
2954 (allocate_location_catch_handlers, re_set_catch_handlers)
2955 (check_status_handlers, print_it_catch_handlers)
2956 (print_one_catch_handlers, print_mention_catch_handlers)
2957 (print_recreate_catch_handlers): Remove.
2958 (create_ada_exception_catchpoint): Update.
2959 (initialize_ada_catchpoint_ops): Update.
2961 2019-10-02 Tom Tromey <tromey@adacore.com>
2963 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2964 (create_excep_cond_exprs): Simplify exception string computation.
2965 (ada_exception_catchpoint_cond_string): Likewise.
2967 2019-10-02 Tom Tromey <tromey@adacore.com>
2969 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2970 * ada-lang.c (lesseq_defined_than): Handle
2972 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2974 (dwarf2_has_info): Likewise.
2975 (new_symbol): Set maybe_copied on symbol when
2977 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2979 <can_copy>: New member.
2980 * elfread.c (record_minimal_symbol): Set maybe_copied
2981 on symbol when appropriate.
2982 (elf_symfile_read): Update call to dwarf2_has_info.
2983 * minsyms.c (lookup_minimal_symbol_linkage): New
2985 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2986 * symtab.c (get_symbol_address, get_msymbol_address):
2988 * symtab.h (get_symbol_address, get_msymbol_address):
2990 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2992 (struct symbol, struct minimal_symbol) <maybe_copied>:
2995 2019-10-02 Tom Tromey <tromey@adacore.com>
2997 * source.c (struct current_source_location): New.
2998 (current_source_key): New global.
2999 (current_source_symtab, current_source_line)
3000 (current_source_pspace): Remove.
3001 (get_source_location): New function.
3002 (get_current_source_symtab_and_line)
3003 (set_default_source_symtab_and_line)
3004 (set_current_source_symtab_and_line)
3005 (clear_current_source_symtab_and_line, select_source_symtab)
3006 (info_source_command, print_source_lines_base)
3007 (info_line_command, search_command_helper, _initialize_source):
3010 2019-10-02 Tom Tromey <tromey@adacore.com>
3012 * source.c (select_source_symtab): Don't call
3013 decode_line_with_current_source.
3015 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3017 * symtab.c (lookup_global_symbol): Search global block.
3019 2019-10-02 Tom Tromey <tromey@adacore.com>
3021 * coffread.c (process_coff_symbol): Update.
3022 * dwarf2read.c (var_decode_location, new_symbol): Update.
3023 * mdebugread.c (parse_symbol): Update.
3024 * objfiles.c (relocate_one_symbol): Update.
3025 * stabsread.c (define_symbol, fix_common_block)
3026 (scan_file_globals): Update.
3027 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3028 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3029 * xcoffread.c (process_xcoff_symbol): Update.
3031 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3033 * MAINTAINERS: Update my email address.
3035 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3037 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3039 (build_type_psymtabs_reader): Update for std::vector.
3040 (build_type_psymtab_dependencies): Likewise.
3041 * dwarf2read.h: Remove use of DEF_VEC_P.
3042 (typedef sig_type_ptr): Delete.
3044 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3046 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3048 (btrace_maint_decode_pt): Likewise, and move allocation of the
3049 vector outside of the loop.
3050 (btrace_maint_update_packets): Update to handle change from VEC to
3052 (btrace_maint_print_packets): Likewise.
3053 (maint_info_btrace_cmd): Likewise.
3054 * btrace.h: Remove use of DEF_VEC_O.
3055 (typedef btrace_pt_packet_s): Delete.
3056 (struct btrace_maint_info) <packets>: Change fromm VEC to
3058 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3060 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3062 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3063 make accesses into the vector constant references.
3064 (btrace_add_pc): Update for std::vector.
3065 (btrace_stitch_bts): Likewise.
3066 (parse_xml_btrace_block): Likewise.
3067 (btrace_maint_update_packets): Likewise.
3068 (btrace_maint_print_packets): Likewise.
3069 (maint_info_btrace_cmd): Likewise.
3070 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3072 (btrace_data::empty): Likewise.
3073 (btrace_data_append): Likewise.
3074 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3075 (typedef btrace_block_s): Delete.
3076 (struct btrace_block): Add constructor.
3077 (struct btrace_data_bts) <blocks>: Change to std::vector.
3078 * nat/linux-btrace.c (perf_event_read_bts): Update for
3080 (linux_read_bts): Likewise.
3082 2019-10-01 Tom Tromey <tom@tromey.com>
3084 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3086 2019-10-01 Tom Tromey <tom@tromey.com>
3088 * stack.c (print_frame, info_frame_command_core): Use
3090 * linux-thread-db.c (try_thread_db_load_1)
3091 (try_thread_db_load_from_pdir_1): Use styled_string.
3092 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3093 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3094 (maybe_print_unsupported_script_warning)
3095 (maybe_print_script_not_found_warning): Use styled_string.
3096 * ada-lang.c (user_select_syms): Use styled_string.
3098 2019-10-01 Tom Tromey <tom@tromey.com>
3100 * p-lang.c (pascal_printstr): Use metadata style.
3101 * value.c (show_convenience): Use metadata style.
3102 * valprint.c (valprint_check_validity, val_print_optimized_out)
3103 (val_print_not_saved, val_print_unavailable)
3104 (val_print_invalid_address, generic_val_print, val_print)
3105 (value_check_printable, val_print_array_elements): Use metadata
3107 * ui-out.h (class ui_out) <field_fmt>: New overload.
3108 <do_field_fmt>: Add style parameter.
3109 * ui-out.c (ui_out::field_fmt): New overload.
3110 * typeprint.c (type_print_unknown_return_type)
3111 (val_print_not_allocated, val_print_not_associated): Use metadata
3113 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3115 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3116 * tracepoint.c (tvariables_info_1): Use metadata style.
3117 * stack.c (print_frame_arg, print_frame_info, print_frame)
3118 (info_frame_command_core): Use metadata style.
3119 * skip.c (info_skip_command): Use metadata style.
3120 * rust-lang.c (rust_print_enum): Use metadata style.
3121 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3123 * python/py-framefilter.c (py_print_single_arg): Use metadata
3125 * printcmd.c (do_one_display, print_variable_and_value): Use
3127 * p-valprint.c (pascal_val_print)
3128 (pascal_object_print_value_fields): Use metadata style.
3129 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3130 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3132 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3133 * m2-valprint.c (m2_print_long_set): Use metadata style.
3134 * m2-typeprint.c (m2_print_type): Use metadata style.
3135 * infcmd.c (print_return_value_1): Use metadata style.
3136 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3137 * f-valprint.c (info_common_command_for_block): Use metadata
3139 * f-typeprint.c (f_type_print_base): Use metadata style.
3140 * expprint.c (print_subexp_standard): Use metadata style.
3141 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3142 * cli/cli-style.h (class cli_style_option): Add constructor.
3143 (metadata_style): Declare.
3144 * cli/cli-style.c (metadata_style): New global.
3145 (_initialize_cli_style): Register metadata style.
3146 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3148 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3149 * c-typeprint.c (c_type_print_base_struct_union)
3150 (c_type_print_base_1): Use metadata style.
3151 * breakpoint.c (watchpoint_value_print)
3152 (print_one_breakpoint_location): Use metadata style.
3153 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3155 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3157 * ada-valprint.c (val_print_packed_array_elements, printstr)
3158 (print_field_values, ada_val_print_ref, ada_val_print): Use
3160 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3162 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3164 * ada-lang.c (user_select_syms): Use metadata style.
3166 2019-10-01 Tom Tromey <tom@tromey.com>
3168 * cli/cli-cmds.c (pwd_command): Style output.
3170 2019-10-01 Pedro Alves <palves@redhat.com>
3171 Tom Tromey <tom@tromey.com>
3173 * symtab.c (print_symbol_info): Use %ps.
3174 (print_msymbol_info): Use %ps.
3175 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3176 * printcmd.c (print_variable_and_value): Use %ps.
3177 * macrocmd.c (show_pp_source_pos): Use %ps.
3178 * infrun.c (print_exited_reason): Use ui_out::message.
3179 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3180 (describe_other_breakpoints): Use ui_out::message and new
3182 (say_where): Use new formats.
3183 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3186 2019-10-01 Pedro Alves <palves@redhat.com>
3187 Tom Tromey <tom@tromey.com>
3189 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3190 (test_gdb_formats): New function.
3191 (run_tests): Call it.
3192 (test_format_specifier): Update.
3193 * utils.h (fputs_filtered): Update comment.
3194 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3195 (fputs_styled_unfiltered): Declare.
3196 * utils.c (fputs_styled_unfiltered): New function.
3197 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3198 (vfprintf_filtered): Update.
3199 (vfprintf_unfiltered, vprintf_filtered): Update.
3200 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3201 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3202 disallow_ui_out_field>: New constants.
3203 (enum class field_kind): New.
3204 (struct base_field_s, struct signed_field_s): New.
3205 (signed_field): New function.
3206 (struct string_field_s): New.
3207 (string_field): New function.
3208 (struct styled_string_s): New.
3209 (styled_string): New function.
3210 (class ui_out) <message>: Add comment.
3211 <vmessage, call_do_message>: New methods.
3212 <do_message>: Add style parameter.
3213 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3215 (ui_out::message): Rewrite.
3216 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3218 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3219 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3220 gdb_extensions parameter.
3221 (class format_piece): Add parameter to constructor.
3222 (n_int_args): New field.
3223 * gdbsupport/format.c (format_pieces::format_pieces): Add
3224 gdb_extensions parameter. Handle '*'.
3225 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3226 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3227 vfprintf_styled_no_gdbfmt.
3228 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3229 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3231 * ui-style.h (struct ui_file_style) <ptr>: New method.
3233 2019-10-01 Tom Tromey <tom@tromey.com>
3235 * unittests/format_pieces-selftests.c: Update. Add final format.
3236 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3237 empty literal pieces.
3239 2019-10-01 Tom Tromey <tom@tromey.com>
3241 * ui-out.h (enum class ui_out_style_kind): Remove.
3242 (class ui_out) <field_string, field_stsream, do_field_string>:
3243 Change type of "style".
3244 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3245 (ui_out::field_string): Update.
3246 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3248 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3249 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3250 * stack.c (print_frame_arg, print_frame_info, print_frame):
3252 * source.c (print_source_lines_base): Update.
3253 * solib.c (info_sharedlibrary_command): Update.
3254 * skip.c (info_skip_command): Update.
3255 * record-btrace.c (btrace_call_history_src_line)
3256 (btrace_call_history): Update.
3257 * python/py-framefilter.c (py_print_frame): Update.
3258 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3260 * mi/mi-out.c (mi_ui_out::do_table_header)
3261 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3262 (mi_ui_out::do_field_string): Update.
3263 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3265 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3267 * cli-out.c (cli_ui_out::do_table_header)
3268 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3269 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3270 (cli_ui_out::do_field_fmt): Update.
3271 * breakpoint.c (print_breakpoint_location): Update.
3272 (update_static_tracepoint): Update.
3274 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3276 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3277 conversion of gdb_datadir.
3278 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3279 remove not needed c_str ().
3281 2019-09-30 Ali Tamur <tamur@google.com>
3283 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3284 (dwarf2_string_attr): Likewise.
3286 2019-09-30 Ali Tamur <tamur@google.com>
3288 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3289 (process_full_type_unit): Likewise.
3290 (dump_die_shallow): Likewise.
3291 (cu_debug_loc_section): Likewise.
3293 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3295 * minsyms.c (compare_minimal_symbols): Rename to...
3296 (minimal_symbol_is_less_than): ...this, and adjust to STL
3297 conventions (return bool, take arguments as references)
3298 (minimal_symbol_reader::install): Call std::sort instead
3301 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3303 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3305 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3306 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3308 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3310 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3311 * psympriv.h (add_psymbol_to_list): Move comment here and update
3314 2019-09-29 Tom de Vries <tdevries@suse.de>
3316 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3317 Use $tmpdir/$(basename "$output_file").dwz instead of
3318 "${output_file}.dwz".
3320 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3323 * hppa-linux-nat.c: Include gdbarch.h.
3325 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3327 * blockframe.c (find_pc_partial_function): Change return type to bool.
3328 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3329 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3330 (stub_gnu_ifunc_resolve_name): Likewise.
3331 * symtab.c (compare_filenames_for_search): Likewise.
3332 (compare_glob_filenames_for_search): Likewise.
3333 (matching_obj_sections): Likewise.
3334 (symbol_matches_domain): Likewise.
3335 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3336 (find_line_pc): Change return type to bool.
3337 (find_line_pc_range): Likewise.
3338 (producer_is_realview): Likewise.
3339 * symtab.h (symbol_matches_domain): Likewise.
3340 (find_pc_partial_function): Likewise.
3341 (find_pc_line_pc_range): Likewise.
3342 (in_gnu_ifunc_stub): Likewise.
3343 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3344 (find_line_pc): Likewise.
3345 (find_line_pc_range): Likewise.
3346 (matching_obj_sections): Likewise.
3347 (find_line_symtab): Change out parameter to bool.
3348 (producer_is_realview): Change return type to bool.
3349 (compare_filenames_for_search): Likewise.
3350 (compare_glob_filenames_for_search): Likewise.
3352 2019-09-26 Tom Tromey <tom@tromey.com>
3354 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3355 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3356 * gdb_usleep.h: Remove.
3357 * gdb_usleep.c: Remove.
3358 * utils.c: Don't include gdb_usleep.h.
3360 2019-09-26 Tom Tromey <tromey@adacore.com>
3362 * python/py-type.c (type_to_type_object): Call check_typedef
3365 2019-09-26 Tom Tromey <tom@tromey.com>
3367 * utils.h (initialize_utils): Don't declare.
3368 * top.c (gdb_init): Don't call initialize_utils.
3369 * utils.c (initialize_utils): Remove. Move contents...
3370 (_initialize_utils): ... here.
3372 2019-09-25 Tom Tromey <tom@tromey.com>
3374 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3375 * utils.h (make_hex_string): Don't declare.
3376 * utils.c (make_hex_string): Remove.
3378 2019-09-24 Tom de Vries <tdevries@suse.de>
3381 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3382 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3384 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3386 * NEWS: Mention new simulator port for PRU.
3388 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3390 * ada-exp.y (write_object_remaining): Update.
3391 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3392 and eliminate the static buffer.
3393 (ada_decode_symbol): Update.
3394 (ada_la_decode): Update.
3395 (ada_sniff_from_mangled_name): Update.
3396 (is_valid_name_for_wild_match): Update.
3397 (ada_lookup_name_info::matches): Update and simplify.
3398 (name_matches_regex): Update.
3399 (ada_add_global_exceptions): Update.
3400 * ada-lang.h (ada_decode): Update signature.
3401 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3402 * dwarf-index-write.c (debug_names::insert): Update.
3404 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3406 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3409 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3411 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3412 Change "nonzero" to "true" in documentation.
3414 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3416 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3417 (_initialize_darwin_solib): Don't set
3418 darwin_so_ops.lookup_lib_global_symbol.
3419 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3420 set_gdbarch_iterate_over_objfiles_in_search_order.
3421 (elf_lookup_lib_symbol): Rename to...
3422 (svr4_iterate_over_objfiles_in_search_order): this, and update
3423 to iterate semantics.
3424 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3425 * solib.c (solib_global_lookup): Remove.
3426 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3427 (solib_global_lookup): Remove.
3428 * symtab.c (lookup_global_or_static_symbol): Remove call to
3429 solib_global_lookup.
3431 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3433 * NEWS: Move entries about default MI version now being
3434 version 3, and about the GDB/MI fix for multi-location
3435 breakpoints to the "since GDB 8.3" section.
3437 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3441 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3443 * NEWS: Mention that Cell/B.E. debugging support was removed.
3444 * MAINTAINERS: Remove spu target.
3446 * config/djgpp/fnchange.lst: Remove entries for removed files.
3448 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3449 spu-multiarch.o, and spu-tdep.o.
3450 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3451 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3452 spu-multiarch.c, and spu-tdep.c.
3453 * spu-linux-nat.c: Remove file.
3454 * spu-multiarch.c: Remove file.
3455 * spu-tdep.c: Remove file.
3456 * spu-tdep.h: Remove file.
3457 * solib-spu.c: Remove file.
3458 * solib-spu.h: Remove file.
3460 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3461 * configure.nat (spu-linux): Remove.
3462 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3463 solib-multiarch.o from gdb_target_obs.
3466 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3468 (ppc_linux_no_features): Update.
3469 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3471 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3472 (tdesc_powerpc_cell64l): Likewise.
3473 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3474 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3476 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3477 Do not include "features/rs6000/powerpc-cell32l.c" or
3478 "features/rs6000/powerpc-cell64l.c".
3479 (ppc_linux_spu_section): Remove.
3480 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3481 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3482 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3483 (ppc_linux_spe_context_lookup): Remove.
3484 (ppc_linux_spe_context_inferior_created): Remove.
3485 (ppc_linux_spe_context_solib_loaded): Remove.
3486 (ppc_linux_spe_context_solib_unloaded): Remove.
3487 (ppc_linux_spe_context): Remove.
3488 (struct ppu2spu_cache): Remove.
3489 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3490 (struct ppu2spu_data): Remove.
3491 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3492 ppu2spu_unwind): Remove.
3493 (ppc_linux_init_abi): Remove Cell/B.E. support.
3494 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3496 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3497 (rs6000/powerpc-cell64l-expedite): Likewise
3498 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3499 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3500 rs6000/powerpc-cell64l.xml.
3501 * features/rs6000/powerpc-cell32l.xml: Remove.
3502 * features/rs6000/powerpc-cell64l.xml: Likewise.
3503 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3504 * features/rs6000/powerpc-cell64l.c: Likewise.
3505 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3506 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3507 * regformats/reg-spu.dat: Remove.
3509 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3510 * corelow.c (struct spuid_list): Remove.
3511 (add_to_spuid_list): Remove.
3512 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3513 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3514 (remote_protocol_features): Remove associated entries.
3515 (_initialize_remote): No longer initialize them.
3516 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3517 * linux-nat.c (SPUFS_MAGIC): Remove.
3518 (linux_proc_xfer_spu): Remove.
3519 (spu_enumerate_spu_ids): Remove.
3520 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3521 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3522 (linux_make_corefile_notes): No longer call it.
3524 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3525 (cooked_write_test): Likewise.
3527 2019-09-20 Tom Tromey <tom@tromey.com>
3529 * NEWS: Mention case-sensitivity of TUI commands.
3530 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3531 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3532 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3534 2019-09-20 Tom Tromey <tom@tromey.com>
3536 * tui/tui-source.c (tui_source_window::set_contents): Use
3537 make_unique_xstrdup.
3538 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3539 make_unique_xstrdup.
3541 2019-09-20 Tom Tromey <tom@tromey.com>
3543 * tui/tui-data.c: Remove separator comments.
3544 * tui/tui-layout.c: Remove separator comments.
3545 * tui/tui-win.c: Remove separator comments.
3546 * tui/tui-wingeneral.c: Remove separator comments.
3548 2019-09-20 Tom Tromey <tom@tromey.com>
3550 * tui/tui.h (strcat_to_buf): Don't declare.
3551 * tui/tui.c (strcat_to_buf): Remove.
3553 2019-09-20 Tom Tromey <tom@tromey.com>
3555 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3557 * tui/tui-source.c (tui_source_window::set_contents)
3558 (tui_source_window::location_matches_p)
3559 (tui_source_window::maybe_update): Update.
3561 2019-09-20 Tom Tromey <tom@tromey.com>
3563 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3565 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3567 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3568 (tui_data_window::line_from_reg_element_no)
3569 (tui_data_window::first_reg_element_no_inline)
3570 (tui_data_window::show_registers)
3571 (tui_data_window::show_register_group)
3572 (tui_data_window::display_registers_from)
3573 (tui_data_window::display_registers_from_line)
3574 (tui_data_window::first_data_item_displayed)
3575 (tui_data_window::delete_data_content_windows)
3576 (tui_data_window::erase_data_content)
3577 (tui_data_window::do_scroll_vertical)
3578 (tui_data_window::refresh_window)
3579 (tui_data_window::check_register_values): Update.
3581 2019-09-20 Tom Tromey <tom@tromey.com>
3583 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3584 (struct tui_locator_window) <full_name, proc_name>: Now
3586 * tui/tui-stack.c (tui_locator_window::make_status_line)
3587 (tui_locator_window::set_locator_fullname)
3588 (tui_locator_window::set_locator_info): Update.
3589 * tui/tui-source.c (tui_source_window::set_contents)
3590 (tui_source_window::showing_source_p): Update.
3592 2019-09-20 Tom Tromey <tom@tromey.com>
3594 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3595 Don't call tui_locator_win_info_ptr.
3597 2019-09-20 Tom Tromey <tom@tromey.com>
3599 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3601 2019-09-20 Tom Tromey <tom@tromey.com>
3603 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3605 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3606 * tui/tui-layout.c (show_source_disasm_command, show_data)
3607 (show_source_or_disasm_and_command): Use 1 as height for locator.
3609 2019-09-20 Tom Tromey <tom@tromey.com>
3611 * tui/tui.c (tui_enable): Update.
3612 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3614 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3616 * tui/tui-data.c (win_resized): Now bool.
3617 (tui_win_resized): Return bool.
3618 (tui_set_win_resized_to): Accept a bool.
3620 2019-09-20 Tom Tromey <tom@tromey.com>
3622 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3623 Change type of "refresh_values_only".
3624 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3625 type of "refresh_values_only".
3627 2019-09-20 Tom Tromey <tom@tromey.com>
3629 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3631 (tui_disassemble): Add "pos" parameter.
3632 (tui_disasm_window::set_contents): Simplify.
3634 2019-09-20 Tom Tromey <tom@tromey.com>
3636 * tui/tui-winsource.h (struct tui_source_window_base)
3637 <show_source_content>: Now private.
3638 * tui/tui-winsource.c
3639 (tui_source_window_base::show_source_content): Don't handle empty
3642 2019-09-20 Tom Tromey <tom@tromey.com>
3644 * tui/tui-layout.c (show_source_disasm_command)
3645 (show_source_or_disasm_and_command): Don't call
3646 show_source_content.
3648 2019-09-20 Tom Tromey <tom@tromey.com>
3650 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3652 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3653 from tui_make_status_line.
3654 (tui_locator_window::rerender): Update.
3656 2019-09-20 Tom Tromey <tom@tromey.com>
3658 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3659 (tui_locator_window::rerender): Update.
3661 2019-09-20 Tom Tromey <tom@tromey.com>
3663 * tui/tui-winsource.h (struct tui_source_window_base)
3664 <~tui_source_window_base>: Don't declare.
3666 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3667 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3669 * tui/tui-source.c (tui_source_window::set_contents): Update.
3670 (tui_source_window::location_matches_p)
3671 (tui_source_window::maybe_update): Update.
3673 2019-09-20 Tom Tromey <tom@tromey.com>
3675 * tui/tui-winsource.h (~tui_source_element): Remove.
3676 (tui_source_element): Update.
3677 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3678 * tui/tui-winsource.c (tui_show_source_line): Update.
3679 * tui/tui-source.c (tui_source_window::set_contents): Update.
3680 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3682 2019-09-20 Tom Tromey <tom@tromey.com>
3684 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3686 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3687 tui_clear_source_windows_detail.
3688 * tui/tui-winsource.h (struct tui_source_window_base)
3689 <clear_detail>: Don't declare.
3690 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3692 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3694 2019-09-20 Tom Tromey <tromey@adacore.com>
3697 * block.c (contained_in): Fix final return value.
3699 2019-09-20 Alan Modra <amodra@gmail.com>
3701 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3702 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3703 (read_indirect_string_from_dwz): Use bfd accessor.
3704 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3705 * machoread.c (macho_symfile_read_all_oso): Likewise.
3706 * solib.c (solib_bfd_open): Likewise.
3708 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3710 * eval.c: Move declaration of overload_resolution to...
3713 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3715 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3716 * arm-linux-tdep.c: Likewise.
3717 * arm-nbsd-nat.c: Likewise.
3718 * arm-tdep.h: Declare arm_apcs_32.
3719 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3721 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3723 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3724 * dwarf2read.h: Declare dwarf_always_disassemble.
3726 2019-09-19 Tom de Vries <tdevries@suse.de>
3729 * source-cache.c (source_cache::ensure): Catch exception thrown during
3730 construction of the highlighter.
3732 2019-09-18 Alan Modra <amodra@gmail.com>
3734 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3735 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3736 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3737 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3738 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3739 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3740 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3741 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3742 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3743 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3744 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3745 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3746 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3747 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3748 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3749 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3750 * mi/mi-interp.c: Update throughout for bfd section macro and
3752 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3753 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3755 2019-09-18 Tom Tromey <tom@tromey.com>
3758 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3760 (tui_enable): Do not call rl_initialize.
3762 2019-09-18 Christian Groessler <chris@groessler.org>
3764 * alpha-linux-nat.c: Include gdbarch.h.
3766 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3768 * ui-file.c: Include cli/cli-style.h.
3769 (term_cli_styling): Remove cli_styling declaration.
3771 2019-09-18 Alan Modra <amodra@gmail.com>
3773 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3774 to bfd_asymbol_section.
3776 2019-09-18 Alan Modra <amodra@gmail.com>
3778 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3779 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3780 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3782 2019-09-18 Alan Modra <amodra@gmail.com>
3784 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3785 * spu-linux-nat.c (spu_bfd_open): Likewise.
3787 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3789 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3790 to bool to match definition in dwarf2read.c.
3792 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3794 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3795 (print_signatures): Likewise.
3796 (trust_pad_over_xvs): Likewise.
3797 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3798 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3799 * arm-linux-nat.c (arm_apcs_32): Likewise.
3800 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3801 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3802 * arm-tdep.c (arm_debug): Likewise.
3803 (arm_apcs_32): Likewise.
3804 * auto-load.c (debug_auto_load): Likewise.
3805 (auto_load_gdb_scripts): Likewise.
3806 (global_auto_load): Likewise.
3807 (auto_load_local_gdbinit): Likewise.
3808 (auto_load_local_gdbinit_loaded): Likewise.
3809 * auto-load.h (global_auto_load): Likewise.
3810 (auto_load_local_gdbinit): Likewise.
3811 (auto_load_local_gdbinit_loaded): Likewise.
3812 * breakpoint.c (disconnected_dprintf): Likewise.
3813 (breakpoint_proceeded): Likewise.
3814 (automatic_hardware_breakpoints): Likewise.
3815 (always_inserted_mode): Likewise.
3816 (target_exact_watchpoints): Likewise.
3817 (_initialize_breakpoint): Update.
3818 * breakpoint.h (target_exact_watchpoints): Change to bool.
3819 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3820 * cli/cli-cmds.c (trace_commands): Likewise.
3821 * cli/cli-cmds.h (trace_commands): Likewise.
3822 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3824 * cli/cli-logging.c (logging_overwrite): Change to bool.
3825 (logging_redirect): Likewise.
3826 (debug_redirect): Likewise.
3827 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3828 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3830 <boolean_option_def>: Update.
3831 (struct flag_option_def): Change default type of Context to bool
3833 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3834 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3835 (get_setshow_command_value_string): Likewise.
3836 * cli/cli-style.c (cli_styling): Change to bool.
3837 (source_styling): Likewise.
3838 * cli/cli-style.h (source_styling): Likewise.
3839 (cli_styling): Likewise.
3840 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3842 * command.h (var_types): Update comment.
3843 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3844 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3846 (debug_compile_cplus_scopes): Likewise.
3847 * compile/compile-internal.h (compile_debug): Likewise.
3848 * compile/compile.c (compile_debug): Likewise.
3849 (struct compile_options) <raw>: Likewise.
3850 * cp-support.c (catch_demangler_crashes): Likewise.
3851 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3852 (usr_cmd_cris_dwarf2_cfi): Likewise.
3853 * csky-tdep.c (csky_debug): Likewise.
3854 * darwin-nat.c (enable_mach_exceptions): Likewise.
3855 * dcache.c (dcache_enabled_p): Likewise.
3856 * defs.h (info_verbose): Likewise.
3857 * demangle.c (demangle): Likewise.
3858 (asm_demangle): Likewise.
3859 * dwarf-index-cache.c (debug_index_cache): Likewise.
3860 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3861 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3862 * dwarf2read.c (check_physname): Likewise.
3863 (use_deprecated_index_sections): Likewise.
3864 (dwarf_always_disassemble): Likewise.
3865 * eval.c (overload_resolution): Likewise.
3866 * event-top.c (set_editing_cmd_var): Likewise.
3867 (exec_done_display_p): Likewise.
3868 * event-top.h (set_editing_cmd_var): Likewise.
3869 (exec_done_display_p): Likewise.
3870 * exec.c (write_files): Likewise.
3871 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3872 (debug_fbsd_nat): Likewise.
3873 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3875 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3876 <backtrace_past_entry> Likewise.
3877 * gdb-demangle.h (demangle): Likewise.
3878 (asm_demangle): Likewise.
3879 * gdb_bfd.c (bfd_sharing): Likewise.
3880 * gdbcore.h (write_files): Likewise.
3881 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3882 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3883 * gdbthread.h (print_thread_events): Likewise.
3884 * gdbtypes.c (opaque_type_resolution): Likewise.
3885 (strict_type_checking): Likewise.
3886 * gnu-nat.c (gnu_debug_flag): Likewise.
3887 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3888 * guile/scm-param.c (pascm_variable): Add boolval.
3889 (add_setshow_generic): Update.
3890 (pascm_param_value): Update.
3891 (pascm_set_param_value_x): Update.
3892 * hppa-tdep.c (hppa_debug): Change to bool..
3893 * infcall.c (may_call_functions_p): Likewise.
3894 (coerce_float_to_double_p): Likewise.
3895 (unwind_on_signal_p): Likewise.
3896 (unwind_on_terminating_exception_p): Likewise.
3897 * infcmd.c (startup_with_shell): Likewise.
3898 * inferior.c (print_inferior_events): Likewise.
3899 * inferior.h (startup_with_shell): Likewise.
3900 (print_inferior_events): Likewise.
3901 * infrun.c (step_stop_if_no_debug): Likewise.
3902 (detach_fork): Likewise.
3903 (debug_displaced): Likewise.
3904 (disable_randomization): Likewise.
3905 (non_stop): Likewise.
3906 (non_stop_1): Likewise.
3907 (observer_mode): Likewise.
3908 (observer_mode_1): Likewise.
3909 (set_observer_mode): Update.
3910 (sched_multi): Change to bool.
3911 * infrun.h (debug_displaced): Likewise.
3912 (sched_multi): Likewise.
3913 (step_stop_if_no_debug): Likewise.
3914 (non_stop): Likewise.
3915 (disable_randomization): Likewise.
3916 * linux-tdep.c (use_coredump_filter): Likewise.
3917 (dump_excluded_mappings): Likewise.
3918 * linux-thread-db.c (auto_load_thread_db): Likewise.
3919 (check_thread_db_on_load): Likewise.
3920 * main.c (captured_main_1): Update.
3921 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3922 xx2_opt, boolean_opt>: Change to bool.
3923 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3924 * maint.c (maintenance_profile_p): Likewise.
3925 (per_command_time): Likewise.
3926 (per_command_space): Likewise.
3927 (per_command_symtab): Likewise.
3928 * memattr.c (inaccessible_by_default): Likewise.
3929 * mi/mi-main.c (mi_async): Likewise.
3930 (mi_async_1): Likewise.
3931 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3932 * nat/fork-inferior.h (startup_with_shell): Likewise.
3933 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3934 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3935 * nios2-tdep.c (nios2_debug): Likewise.
3936 * or1k-tdep.c (or1k_debug): Likewise.
3937 * parse.c (parser_debug): Likewise.
3938 * parser-defs.h (parser_debug): Likewise.
3939 * printcmd.c (print_symbol_filename): Likewise.
3940 * proc-api.c (procfs_trace): Likewise.
3941 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3942 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3943 (set_parameter_value): Update.
3944 (add_setshow_generic): Update.
3945 * python/py-value.c (copy_py_bool_obj): Change argument from int*
3947 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3949 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3950 * record-btrace.c (record_btrace_target::store_registers): Update.
3951 * record-full.c (record_full_memory_query): Change to bool.
3952 (record_full_stop_at_limit): Likewise.
3953 * record-full.h (record_full_memory_query): Likewise.
3954 * remote-notif.c (notif_debug): Likewise.
3955 * remote-notif.h (notif_debug): Likewise.
3956 * remote.c (use_range_stepping): Likewise.
3957 (interrupt_on_connect): Likewise.
3958 (remote_break): Likewise.
3959 * ser-tcp.c (tcp_auto_retry): Likewise.
3960 * ser-unix.c (serial_hwflow): Likewise.
3961 * skip.c (debug_skip): Likewise.
3962 * solib-aix.c (solib_aix_debug): Likewise.
3963 * spu-tdep.c (spu_stop_on_load_p): Likewise.
3964 (spu_auto_flush_cache_p): Likewise.
3965 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3967 (struct info_print_options) <quiet>: Likewise.
3968 * symfile-debug.c (debug_symfile): Likewise.
3969 * symfile.c (auto_solib_add): Likewise.
3970 (separate_debug_file_debug): Likewise.
3971 * symfile.h (auto_solib_add): Likewise.
3972 (separate_debug_file_debug): Likewise.
3973 * symtab.c (basenames_may_differ): Likewise.
3974 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3975 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3976 (struct info_types_options) <quiet>: Likewise.
3977 * symtab.h (demangle): Likewise.
3978 (basenames_may_differ): Likewise.
3979 * target-dcache.c (stack_cache_enabled_1): Likewise.
3980 (code_cache_enabled_1): Likewise.
3981 * target.c (trust_readonly): Likewise.
3982 (may_write_registers): Likewise.
3983 (may_write_memory): Likewise.
3984 (may_insert_breakpoints): Likewise.
3985 (may_insert_tracepoints): Likewise.
3986 (may_insert_fast_tracepoints): Likewise.
3987 (may_stop): Likewise.
3988 (auto_connect_native_target): Likewise.
3989 (target_stop_and_wait): Update.
3990 (target_async_permitted): Change to bool.
3991 (target_async_permitted_1): Likewise.
3992 (may_write_registers_1): Likewise.
3993 (may_write_memory_1): Likewise.
3994 (may_insert_breakpoints_1): Likewise.
3995 (may_insert_tracepoints_1): Likewise.
3996 (may_insert_fast_tracepoints_1): Likewise.
3997 (may_stop_1): Likewise.
3998 * target.h (target_async_permitted): Likewise.
3999 (may_write_registers): Likewise.
4000 (may_write_memory): Likewise.
4001 (may_insert_breakpoints): Likewise.
4002 (may_insert_tracepoints): Likewise.
4003 (may_insert_fast_tracepoints): Likewise.
4004 (may_stop): Likewise.
4005 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4006 (make_thread_apply_all_options_def_group): Change argument from int*
4008 (thread_apply_all_command): Update.
4009 (print_thread_events): Change to bool.
4010 * top.c (confirm): Likewise.
4011 (command_editing_p): Likewise.
4012 (history_expansion_p): Likewise.
4013 (write_history_p): Likewise.
4014 (info_verbose): Likewise.
4015 * top.h (confirm): Likewise.
4016 (history_expansion_p): Likewise.
4017 * tracepoint.c (disconnected_tracing): Likewise.
4018 (circular_trace_buffer): Likewise.
4019 * typeprint.c (print_methods): Likewise.
4020 (print_typedefs): Likewise.
4021 * utils.c (debug_timestamp): Likewise.
4022 (sevenbit_strings): Likewise.
4023 (pagination_enabled): Likewise.
4024 * utils.h (sevenbit_strings): Likewise.
4025 (pagination_enabled): Likewise.
4026 * valops.c (overload_resolution): Likewise.
4027 * valprint.h (struct value_print_options) <prettyformat_arrays,
4028 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4029 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4030 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4032 * windows-nat.c (new_console): Likewise.
4033 (cygwin_exceptions): Likewise.
4034 (new_group): Likewise.
4035 (debug_exec): Likewise.
4036 (debug_events): Likewise.
4037 (debug_memory): Likewise.
4038 (debug_exceptions): Likewise.
4039 (useshell): Likewise.
4040 * windows-tdep.c (maint_display_all_tib): Likewise.
4041 * xml-support.c (debug_xml): Likewise.
4043 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4045 * source.c (prepare_path_for_appending): New function.
4046 (openp): Make use of new function.
4047 (find_and_open_source): Search for the compilation directory and
4048 source file as a relative path beneath the directory search path.
4050 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4052 * source-cache.c (source_cache::get_line_charpos): Catch
4053 exceptions and return false, this matches the behaviour documented
4056 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4058 * ada-tasks.c (info_task): Remove quoting of the task's name.
4060 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4062 * symfile.c (auto_solib_add): Replace comment with a reference
4065 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4067 * NEWS: Mention that gdb can now be compiled with Python 3
4070 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4072 * maint.c (maint_print_section_data::maint_print_section_data):
4073 Force use of 'float log10 (float)' by casting the argument to
4076 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4078 * maint.c: Add 'cmath' include.
4079 (struct maint_print_section_data): New structure.
4080 (print_section_index): New function.
4081 (print_bfd_section_info): Add header comment, small whitespace
4082 cleanup, and update to call new print_section_index function.
4083 (print_objfile_section_info): Likewise.
4084 (maint_obj_section_from_bfd_section): New function.
4085 (print_bfd_section_info_maybe_relocated): New function.
4086 (maintenance_info_sections): Add header comment, always use
4087 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4089 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4091 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4092 inner scope, add check that the objfile has psymtabs before
4093 checking psymtabs_addrmap.
4094 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4096 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4098 * NEWS: Announce that Ada task names are now shown at more places,
4099 and between quotes (except in info task output).
4100 * gdb/ada-tasks.c (task_to_str): New function.
4101 (display_current_task_id): Call task_to_str.
4102 (task_command_1): Likewise.
4103 (print_ada_task_info): In non-mi mode, Properly align headers and data
4104 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4106 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4108 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4109 prstatus.pr_lwp.pr_info instead of making it up.
4111 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4113 * auto-load.c (auto_load_expand_dir_vars): Update.
4114 * defs.h (gdb_datadir): Change to std::string.
4115 (python_libdir): Likewise.
4116 (relocate_gdb_directory): Change return type to std::string.
4117 * guile/guile.c (gdbscm_data_directory): Update.
4118 (initialize_scheme_side): Update.
4119 * jit.c (jit_reader_dir): Change to std::string.
4120 (jit_reader_load_command): Update.
4121 * main.c (gdb_datadir): Change to std::string.
4122 (python_libdir): Likewise.
4123 (set_gdb_data_directory): Update.
4124 (relocate_path): Change to return std::string.
4125 (relocate_gdb_directory): Change to return std::string.
4126 (relocate_gdbinit_path_maybe_in_datadir): Update.
4127 (captured_main_1): Update.
4128 * python/python.c (do_start_initialization): Update.
4129 * top.c (show_gdb_datadir): Update.
4130 * xml-syscall.c (xml_init_syscalls_info): Update.
4131 (init_syscalls_info): Update.
4133 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4135 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4136 out of get_init_files.
4137 (get_init_files): Update.
4139 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4141 * main.c (get_init_files): Change to use std::string.
4142 (captured_main_1): Update.
4143 (print_gdb_help): Update.
4145 2019-09-11 Ali Tamur <tamur@google.com>
4147 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4150 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4152 * dbxread.c (read_dbx_symtab): Update.
4153 * dwarf2read.c (load_partial_dies): Update.
4154 * mdebugread.c (parse_partial_symbols): Update.
4155 (handle_psymbol_enumerators): Update.
4156 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4157 * psymtab.c (add_psymbol_to_bcache): Likewise.
4158 (add_psymbol_to_list): Likewise.
4159 * symtab.c (symbol_set_names): Likewise.
4160 * symtab.h (symbol_set_names): Likewise.
4161 * xcoffread.c (scan_xcoff_symtab): Update.
4163 2019-09-11 Tom Tromey <tom@tromey.com>
4165 * symfile-mem.c (symbol_file_add_from_memory): Use
4167 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4168 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4170 2019-09-10 Tom Tromey <tromey@adacore.com>
4172 * dwarf-index-write.c (write_psymbols): Extend error message.
4173 (debug_names::insert): Add Ada code.
4174 (debug_names::write_psymbols): Remove Ada check.
4175 (debug_names) <m_string_obstack>: New member.
4176 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4177 (gdb_index_symbol_name_matcher::matches): Remove.
4178 (mapped_index_base::find_name_components_bounds): Add "lang"
4180 (mapped_index_base::build_name_components): Also split names
4181 according to Ada syntax.
4182 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4183 type of "match_callback".
4184 (check_match, check_find_bounds_finds)
4185 (dw2_expand_symtabs_matching): Update.
4186 (dw2_debug_names_iterator): Add new constructor.
4187 (dw2_debug_names_map_matching_symbols): New function.
4188 (dw2_debug_names_expand_symtabs_matching): Update.
4189 (dwarf2_debug_names_functions): Use
4190 dw2_debug_names_map_matching_symbols.
4192 2019-09-10 Tom Tromey <tromey@adacore.com>
4194 * dwarf2read.c (dw2_get_file_names_reader): Add the
4195 CU's file name to the results.
4197 2019-09-10 Tom Tromey <tromey@adacore.com>
4199 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4200 map_matching_symbols. Update.
4201 * dwarf2read.c (dw2_map_matching_symbols): Update.
4202 * psymtab.c (match_partial_symbol): Change type; update.
4203 (psym_map_matching_symbols): Likewise.
4204 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4206 * symfile.h (struct quick_symbol_functions)
4207 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4210 2019-09-10 Tom Tromey <tromey@adacore.com>
4212 * psymtab.c (map_block): Remove.
4213 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4214 * symtab.c (iterate_over_symbols_terminated): New function.
4215 * symtab.c (iterate_over_symbols_terminated): Declare.
4217 2019-09-10 Tom Tromey <tromey@adacore.com>
4219 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4220 * language.h (struct language_defn) <la_iterate_over_symbols>:
4222 * symtab.c (iterate_over_symbols): Return bool.
4223 * symtab.h (iterate_over_symbols): Return bool.
4225 2019-09-10 Tom Tromey <tromey@adacore.com>
4227 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4228 (add_nonlocal_symbols): Update.
4229 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4230 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4231 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4232 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4233 Change type of "callback". Remove "data".
4236 2019-09-09 Ali Tamur <tamur@google.com>
4238 * dwarf2read.c (comp_unit_head): Update comment.
4239 (dwarf2_dwo_name): New function declaration.
4240 (dwarf_unit_type_name): New function declaration.
4241 (read_comp_unit_head): Add support for new compilation units,
4242 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4243 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4244 (currently named as "signature") in their header. Also clarify error
4246 (lookup_dwo_id): New function. Returns the dwo id of the given
4248 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4249 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4251 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4252 (dwarf2_dwo_name): Get the dwo name if present.
4253 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4256 2019-09-09 Tom Tromey <tom@tromey.com>
4258 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4260 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4262 * python/python.c (do_start_initialization): Make progname_copy static,
4263 to avoid a leak report.
4265 2019-09-08 Tom Tromey <tom@tromey.com>
4267 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4269 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4271 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4272 Change type to gdb::optional<block_enum>.
4273 (dw2_symtab_iter_init): Change block_index parameter type
4274 to gdb::optional<block_enum>.
4275 (dw2_lookup_symbol): Change block_index parameter
4276 type to block_enum.c
4277 (dw2_debug_names_lookup_symbol): Likewise.
4278 * psymtab.c (psym_lookup_symbol): Likewise.
4279 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4280 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4283 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4285 * defs.h (relocate_gdb_directory): Change int to bool in
4286 signature and rename flag to relocatable.
4287 * main.c (relocate_path): Likewise.
4288 (relocate_gdb_directory): Likewise.
4290 2019-09-06 Alan Modra <amodra@gmail.com>
4292 * coffread.c (coff_symfile_read): Constify filename variable.
4293 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4294 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4295 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4296 * solib.c (reload_shared_libraries_1): Likewise.
4297 * symfile.c (reread_symbols): Likewise.
4298 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4299 * solib-darwin.c (darwin_bfd_open): Likewise.
4300 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4302 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4304 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4305 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4307 2019-09-03 Tom Tromey <tromey@adacore.com>
4309 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4311 (has_negatives): Unbias a range type bound.
4312 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4313 * gdbtypes.c (operator==): Handle new field.
4314 (create_range_type): Add "bias" parameter.
4315 (create_static_range_type, resolve_dynamic_range): Update.
4316 * gdbtypes.h (struct range_bounds) <bias>: New member.
4317 (create_range_type): Add bias parameter.
4318 * printcmd.c (print_scalar_formatted): Unbias range types.
4319 * value.c (unpack_long): Unbias range types.
4320 (pack_long): Bias range types.
4322 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4324 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4327 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4329 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4330 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4331 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4332 (compile_probe_arg): Likewise.
4333 * probe.h (get_argument_count): Likewise.
4334 * solib-svr4.c (solib_event_probe_action): Likewise.
4335 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4337 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4339 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4341 (svr4_create_solib_event_breakpoints): ...from here.
4343 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4345 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4346 suffix from warning message.
4348 2019-08-30 Tom Tromey <tom@tromey.com>
4350 * tui/tui-winsource.h (struct tui_source_window_base)
4351 <refresh_all>: Don't declare.
4352 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4354 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4355 tui_show_locator_content.
4356 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4358 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4359 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4362 2019-08-30 Tom Tromey <tom@tromey.com>
4364 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4366 2019-08-30 Tom Tromey <tom@tromey.com>
4368 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4369 Remove unnecessary forward declarations.
4371 2019-08-30 Tom Tromey <tom@tromey.com>
4373 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4375 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4376 tui_show_locator_content.
4378 2019-08-30 Tom Tromey <tom@tromey.com>
4380 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4381 (tui_locator_window::rerender): Rewrite using body of previous
4382 tui_show_locator_content.
4384 2019-08-30 Tom Tromey <tom@tromey.com>
4386 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4387 set_locator_fullname>: New methods.
4388 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4389 Rename from tui_set_locator_fullname.
4390 (tui_locator_window::set_locator_info): Rename from
4391 tui_set_locator_info. Return bool.
4392 (tui_update_locator_fullname, tui_show_frame_info): Update.
4394 2019-08-30 Tom Tromey <tom@tromey.com>
4396 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4398 2019-08-30 Tom Tromey <tom@tromey.com>
4400 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4403 2019-08-30 Tom Tromey <tom@tromey.com>
4405 * tui/tui-wingeneral.c (box_win): Assume win_info and
4406 win_info->handle cannot be NULL.
4408 2019-08-30 Tom Tromey <tom@tromey.com>
4410 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4411 refresh_window>: Declare.
4412 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4414 (tui_data_item_window::rerender): Rename from
4415 tui_display_register.
4416 (tui_data_item_window::refresh_window): New method.
4417 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4420 2019-08-30 Tom Tromey <tom@tromey.com>
4422 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4423 regs_column_count, current_group>: Move later. Now private.
4424 <get_current_group>: New method.
4425 * tui/tui-regs.c (tui_reg_command): Update.
4426 * tui/tui-layout.c (tui_set_layout): Update.
4428 2019-08-30 Tom Tromey <tom@tromey.com>
4430 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4431 (tui_data_window::rerender): Don't call
4432 check_and_display_highlight_if_needed.
4433 (tui_data_window::refresh_all): Remove call to
4436 2019-08-30 Tom Tromey <tom@tromey.com>
4438 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4439 (tui_data_window::display_registers_from)
4440 (tui_data_window::display_reg_element_at_line)
4441 (tui_data_window::display_registers_from_line): Remove checks of
4444 2019-08-30 Tom Tromey <tom@tromey.com>
4446 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4448 * tui/tui-regs.c (tui_data_window::show_registers): Call
4450 (tui_data_window::rerender): Rename from display_all_data.
4451 (tui_data_window::rerender): Remove old implementation.
4453 2019-08-30 Tom Tromey <tom@tromey.com>
4455 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4457 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4459 2019-08-29 Bernhard Wodok <barto@gmx.net>
4460 Sergio Durigan Junior <sergiodj@redhat.com>
4463 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4465 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4467 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4468 when searching for types.
4470 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4472 * f-lang.c (f_language_defn): Use f_print_typedef.
4473 * f-lang.h (f_print_typedef): Declare.
4474 * f-typeprint.c (f_print_typedef): Define.
4476 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4478 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4480 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4482 * cli/cli-utils.c (info_print_options_defs): Delete.
4483 (make_info_print_options_def_group): Delete.
4484 (extract_info_print_options): Delete.
4485 (info_print_command_completer): Delete.
4486 (info_print_args_help): Add extra parameter, and optionally
4487 include text about -n flag.
4488 * cli/cli-utils.h (struct info_print_options): Delete.
4489 (extract_info_print_options): Delete declaration.
4490 (info_print_command_completer): Delete declaration.
4491 (info_print_args_help): Add extra parameter, extend header
4493 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4495 * stack.c (struct info_print_options): New type.
4496 (info_print_options_defs): New file scoped variable.
4497 (make_info_print_options_def_group): New static function.
4498 (info_print_command_completer): New static function.
4499 (info_locals_command): Update to use new local functions.
4500 (info_args_command): Likewise.
4501 (_initialize_stack): Add extra parameter to calls to
4502 info_print_args_help.
4503 * symtab.c (search_symbols): Add extra parameter, use this to
4504 possibly excluse non-debug symbols.
4505 (symtab_symbol_info): Add extra parameter, which is passed on to
4507 (struct info_print_options): New type.
4508 (info_print_options_defs): New file scoped variable.
4509 (make_info_print_options_def_group): New static function.
4510 (info_print_command_completer): New static function.
4511 (info_variables_command): Update to use local functions, and pass
4512 extra parameter through to symtab_symbol_info.
4513 (info_functions_command): Likewise.
4514 (info_types_command): Pass additional argument through to
4516 (rbreak_command): Pass extra argument to search_symbols.
4517 (_initialize_symtab): Add extra arguments for calls to
4518 info_print_args_help, and update help text for 'info variables',
4519 'whereis', and 'info functions' commands.
4520 * symtab.h (search_symbols): Add extra argument to declaration.
4521 * NEWS: Mention new flags.
4523 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4525 * symtab.c (lookup_static_symbol): Call the new function (and move
4526 it down to be next to lookup_global_symbol).
4527 (struct global_sym_lookup_data): Add block_enum member and rename to...
4528 (struct global_or_static_sym_lookup_data): ...this.
4529 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4530 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4531 (lookup_symbol_global_or_static_iterator_cb): ...this.
4532 (lookup_global_or_static_symbol): New function.
4533 (lookup_global_symbol): Call new function.
4535 2019-08-26 Tom de Vries <tdevries@suse.de>
4538 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4539 when pc_probe.prob == NULL.
4541 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4543 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4544 variable symbol_linkage to symbol_linkage_.
4546 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4548 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4549 represent whether the symbol is static, dynamic, or we don't
4552 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4554 * gdb/rx-tdep.c (rx_register_names): New.
4555 (rx_register_name): Delete.
4556 (rx_psw_type): Delete.
4557 (rx_fpsw_type): Delete.
4558 (rx_register_type): Delete.
4559 (rx_gdbarch_init): Convert target-descriptions.
4560 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4561 * gdb/features/Makefile: Add rx.xml.
4562 * gdb/features/rx.xml: New.
4563 * gdb/features/rx.c: Generated.
4564 * gdb/NEWS: Mention target description support.
4566 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4568 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4571 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4573 * configure.ac: Don't check for 'dlfcn.h' (moved to
4574 gdbsupport/common.m4).
4575 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4577 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4578 * compile/compile-c-support.c: Include
4579 'gdbsupport/gdb-dlfcn.h'.
4580 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4581 * gdb-dlfcn.c: Move to...
4582 * gdbsupport/gdb-dlfcn.c: ... here.
4583 * gdb-dlfcn.h: Move to...
4584 * gdbsupport/gdb-dlfcn.h: ... here.
4586 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4588 * nios2-tdep.c (struct reg_value): Improve comments. Make
4589 the offset field signed.
4591 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4593 * python/lib/gdb/__init__.py (_execute_file): New function.
4594 * python/python.c (python_run_simple_file): Call gdb._execute_file
4597 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4599 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4600 all uses as this was never set to anything but a zero value.
4602 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4604 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4606 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4608 * tui/tui-data.h (tui_gen_win_info): Add an =default
4609 move constructor, required by some GCC versions.
4611 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4613 * go32-nat.c (go32_sysinfo): Add hygon_p.
4615 2019-08-20 Tom Tromey <tom@tromey.com>
4617 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4618 line_from_reg_element_no, first_reg_element_no_inline,
4619 display_all_data, delete_data_content_windows,
4620 erase_data_content>: Now private.
4622 2019-08-20 Tom Tromey <tom@tromey.com>
4624 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4625 (tui_unhighlight_win, tui_highlight_win)
4626 (tui_win_info::make_window): Update.
4627 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4629 2019-08-20 Tom Tromey <tom@tromey.com>
4631 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4632 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4633 (MAX_PID_WIDTH): Move to tui-stack.c.
4634 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4635 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4636 (MAX_PID_WIDTH): Move from tui-data.h.
4638 2019-08-20 Tom Tromey <tom@tromey.com>
4640 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4641 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4643 (tui_gen_win_info::make_window): Rename from tui_make_window.
4644 (tui_win_info::make_window): New method.
4645 (tui_gen_win_info::make_visible): Update.
4646 * tui/tui-source.c (tui_source_window::set_contents): Update.
4647 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4648 (tui_data_window::display_registers_from): Update.
4649 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4650 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4654 (struct tui_win_info) <make_window>: Declare.
4655 <can_box>: Now virtual.
4656 <title>: New member.
4657 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4658 * tui/tui-command.c (tui_cmd_window::resize): Update.
4660 2019-08-20 Tom Tromey <tom@tromey.com>
4662 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4663 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4664 (tui_data_window::check_register_values): Update.
4666 2019-08-20 Tom Tromey <tom@tromey.com>
4668 * tui/tui-regs.h (struct tui_data_window): Use
4669 DISABLE_COPY_AND_ASSIGN.
4670 <regs_content>: Change type, removing unique_ptr.
4671 <tui_data_window>: Add move constructor.
4672 * tui/tui-regs.c (tui_data_window::show_registers)
4673 (tui_data_window::show_register_group)
4674 (tui_data_window::display_registers_from)
4675 (tui_data_window::display_registers_from)
4676 (tui_data_window::first_data_item_displayed)
4677 (tui_data_window::delete_data_content_windows)
4678 (tui_data_window::rerender, tui_data_window::refresh_window)
4679 (tui_data_window::check_register_values): Update.
4681 2019-08-20 Tom Tromey <tom@tromey.com>
4683 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4684 show_register_group>: Declare.
4685 (tui_show_register_group): Don't declare.
4686 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4688 (tui_data_window::show_register_group): Rename from
4689 tui_show_register_group.
4690 (tui_data_window::check_register_values, tui_reg_command):
4692 * tui/tui-layout.c (tui_set_layout): Update.
4694 2019-08-20 Tom Tromey <tom@tromey.com>
4696 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4698 (tui_check_register_values): Don't declare.
4699 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4700 from tui_check_register_values.
4701 * tui/tui-hooks.c (tui_register_changed): Update.
4703 2019-08-20 Tom Tromey <tom@tromey.com>
4705 * tui/tui-regs.c (tui_reg_layout): Move later.
4706 (tui_show_registers): Don't enable TUI mode or change layout.
4708 2019-08-20 Tom Tromey <tom@tromey.com>
4710 * tui/tui-regs.h (struct tui_data_item_window)
4711 <~tui_data_item_window>: Remove.
4712 <content>: Now a unique_xmalloc_ptr.
4713 * tui/tui-regs.c (tui_register_format): Return a
4715 (tui_get_register): Update.
4716 (~tui_data_item_window): Remove.
4717 (tui_data_window::display_registers_from, tui_display_register):
4719 * tui/tui-io.h (tui_expand_tabs): Update.
4720 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4721 Remove "col" parameter.
4723 2019-08-20 Tom Tromey <tom@tromey.com>
4725 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4727 * tui/tui-regs.c (~tui_data_item_window): Update.
4729 2019-08-20 Tom Tromey <tom@tromey.com>
4731 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4734 2019-08-20 Tom Tromey <tom@tromey.com>
4736 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4738 2019-08-20 Tom Tromey <tom@tromey.com>
4740 * tui/tui-source.h (struct tui_source_window): Update.
4741 * tui/tui-regs.c (tui_show_registers): Update.
4742 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4743 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4744 (NO_REGS_STRING): Remove defines.
4746 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4748 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4749 unnecessary thread walk if remote doesn't support the packet.
4751 2019-08-19 Tom Tromey <tromey@adacore.com>
4753 * python/py-value.c (value_has_field): Fix indentation.
4755 2019-08-19 Tom Tromey <tromey@adacore.com>
4757 * printcmd.c (do_one_display, info_display_command): Update.
4758 * block.h (contained_in): Return bool. Add allow_nested
4760 * block.c (contained_in): Return bool. Add allow_nested
4763 2019-08-19 Tom Tromey <tom@tromey.com>
4765 * configure: Rebuild.
4766 * configure.ac: Disallow the combination of -static-libstdc++ and
4768 * source-cache.c (get_language_name): Handle rust.
4769 (source_cache::get_source_lines): Ignore highlighting exceptions.
4771 2019-08-16 Tom Tromey <tom@tromey.com>
4773 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4774 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4775 (struct tui_source_window_base) <make_visible, refresh_window,
4776 resize>: Remove methods.
4777 <execution_info>: Remove field.
4778 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4779 (tui_show_source_line, tui_source_window_base)
4780 (~tui_source_window_base): Update.
4781 (tui_source_window_base::resize)
4782 (tui_source_window_base::make_visible)
4783 (tui_source_window_base::refresh_window): Remove.
4784 (tui_source_window_base::update_exec_info): Update.
4785 * tui/tui-source.c (tui_source_window::set_contents): Update.
4786 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4788 2019-08-16 Tom Tromey <tom@tromey.com>
4790 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4791 deprecated_query_hook.
4793 2019-08-16 Tom Tromey <tom@tromey.com>
4795 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4796 (tui_update_source_windows_with_line): Update.
4797 * tui/tui-source.h (struct tui_source_window)
4798 <show_symtab_source>: Declare.
4799 (tui_show_symtab_source): Don't declare.
4800 * tui/tui-source.c (tui_show_symtab_source): Rename from
4801 tui_show_symtab_source.
4803 2019-08-16 Tom Tromey <tom@tromey.com>
4805 * tui/tui-winsource.h (struct tui_source_window_base)
4806 <set_contents>: Declare.
4807 * tui/tui-winsource.c
4808 (tui_source_window_base::update_source_window_as_is): Update.
4809 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4811 (tui_set_source_content): Don't declare.
4812 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4813 tui_set_source_content.
4814 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4816 (tui_set_disassem_content): Don't declare.
4817 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4818 tui_set_disassem_content.
4820 2019-08-16 Tom Tromey <tom@tromey.com>
4822 * tui/tui-winsource.h (struct tui_source_window_base)
4823 <update_breakpoint_info>: Declare.
4824 (tui_update_breakpoint_info): Don't declare.
4825 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4826 (tui_update_all_breakpoint_info): Update.
4827 (tui_source_window_base::update_breakpoint_info): Rename from
4828 tui_update_breakpoint_info.
4829 (tui_source_window_base::update_exec_info): Update.
4831 2019-08-16 Tom Tromey <tom@tromey.com>
4833 * tui/tui-winsource.h (struct tui_source_window_base)
4834 <update_source_window>: Declare.
4835 (tui_update_source_window): Don't declare.
4836 * tui/tui-winsource.c
4837 (tui_source_window_base::update_source_window): Rename from
4838 tui_update_source_window.
4839 (tui_source_window_base::rerender): Update.
4840 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4841 * tui/tui-disasm.c (tui_show_disassem)
4842 (tui_show_disassem_and_update_source)
4843 (tui_disasm_window::maybe_update): Update.
4845 2019-08-16 Tom Tromey <tom@tromey.com>
4847 * tui/tui-winsource.h (struct tui_source_window_base)
4848 <update_source_window_as_is>: Declare.
4849 (tui_update_source_window_as_is): Don't declare.
4850 * tui/tui-winsource.c (tui_update_source_window): Update
4851 (tui_source_window_base::update_source_window_as_is): Rename from
4852 tui_update_source_window_as_is.
4853 (tui_source_window_base::refill): Update.
4854 * tui/tui-source.c (tui_show_symtab_source): Update.
4855 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4858 2019-08-16 Tom Tromey <tom@tromey.com>
4860 * tui/tui-winsource.h (tui_update_source_window)
4861 (tui_update_source_window_as_is): Remove "noerror" parameter.
4862 * tui/tui-winsource.c (tui_update_source_window)
4863 (tui_update_source_window_as_is): Remove "noerror" parameter.
4864 (tui_update_source_windows_with_addr)
4865 (tui_update_source_windows_with_line)
4866 (tui_source_window_base::rerender)
4867 (tui_source_window_base::refill): Update.
4868 * tui/tui-source.h (tui_set_source_content)
4869 (tui_show_symtab_source): Remove "noerror" parameter.
4870 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4872 (tui_show_symtab_source): Likewise.
4873 (tui_source_window::maybe_update): Update.
4874 * tui/tui-disasm.c (tui_show_disassem)
4875 (tui_show_disassem_and_update_source)
4876 (tui_disasm_window::do_scroll_vertical)
4877 (tui_disasm_window::maybe_update): Update.
4879 2019-08-16 Tom Tromey <tom@tromey.com>
4881 * tui/tui.c (tui_is_window_visible): Update.
4882 * tui/tui-wingeneral.c (tui_make_window)
4883 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4884 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4885 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4886 (tui_set_win_height_command, parse_scrolling_args): Update.
4887 * tui/tui-source.c (tui_source_window::style_changed): Update.
4888 * tui/tui-regs.c (tui_show_registers)
4889 (tui_data_window::first_data_item_displayed)
4890 (tui_data_window::delete_data_content_windows)
4891 (tui_check_register_values, tui_reg_command): Update.
4892 * tui/tui-disasm.c (tui_show_disassem): Update.
4893 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4895 <is_visible>: Remove field.
4896 * tui/tui-data.c (tui_next_win, tui_prev_win)
4897 (tui_delete_invisible_windows): Update.
4899 2019-08-16 Tom Tromey <tom@tromey.com>
4901 * tui/tui-winsource.h (struct tui_source_window_base)
4902 <m_has_locator>: Remove.
4903 * tui/tui-layout.c (show_source_disasm_command, show_data)
4904 (show_source_or_disasm_and_command): Update.
4906 2019-08-16 Alan Hayward <alan.hayward@arm.com>
4908 * NEWS (Other MI changes): New subsection.
4909 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4910 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4911 * arch-utils.c (default_get_pc_address_flags): New function.
4912 * arch-utils.h (default_get_pc_address_flags): New declaration.
4913 * gdbarch.sh: Add get_pc_address_flags.
4914 * gdbarch.c: Regenerate.
4915 * gdbarch.h: Likewise.
4916 * stack.c (print_pc): New function.
4917 (print_frame_info) (print_frame): Call print_pc.
4919 2019-08-16 Tom de Vries <tdevries@suse.de>
4921 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4922 print_objfile_section_info.
4924 2019-08-15 Tom Tromey <tom@tromey.com>
4926 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4927 calling update_cmdwin_start_line.
4928 * tui/tui-winsource.h (struct tui_source_window_base)
4929 <do_make_visible_with_new_height, set_new_height>: Don't declare.
4930 <rerender>: Declare.
4931 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4933 (tui_source_window_base::set_new_height): Remove.
4934 (tui_source_window_base::rerender): Rename from
4935 do_make_visible_with_new_height.
4936 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4938 (tui_win_info::make_invisible_and_set_new_height)
4939 (tui_win_info::make_visible_with_new_height): Remove.
4940 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4942 * tui/tui-stack.c (tui_locator_window::rerender): New method.
4943 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4944 do_make_visible_with_new_height>: Don't declare.
4945 <rerender>: Declare.
4946 * tui/tui-regs.c (tui_data_window::rerender): Rename from
4948 (tui_data_window::do_make_visible_with_new_height): Remove.
4949 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4950 call tui_show_locator_content.
4951 (tui_gen_win_info::resize): Call rerender.
4952 (show_source_or_disasm_and_command): Don't call
4953 tui_show_locator_content.
4954 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4956 (struct tui_win_info) <rerender>: Declare.
4957 <set_new_height, make_invisible_and_set_new_height,
4958 make_visible_with_new_height>: Don't declare.
4959 * tui/tui-data.c (tui_win_list::rerender): New method.
4960 * tui/tui-command.h (struct tui_cmd_window)
4961 <do_make_visible_with_new_height>: Don't declare.
4963 (tui_cmd_window::do_make_visible_with_new_height): Remove.
4965 2019-08-15 Tom Tromey <tromey@adacore.com>
4967 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4968 * ada-lang.c (ada_enum_name): Likewise.
4970 2019-08-15 Christian Biesinger <cbiesinger@google.com>
4972 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4974 (GdbOutputErrorFile): Likewise.
4975 (global scope): Adjust constructor calls to GdbOutput{,Error}File
4977 (execute_unwinders): Rename to have a leading underscore.
4978 (auto_load_packages): Likewise.
4979 (global scope): Adjust call to auto_load_packages accordingly.
4980 (GdbSetPythonDirectory): Likewise.
4981 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4982 instead of execute_unwinders.
4984 2019-08-15 Tom Tromey <tom@tromey.com>
4986 * tui/tui-layout.c (show_layout, show_source_disasm_command)
4987 (show_data): Don't change window visibility.
4988 (tui_gen_win_info::resize): Remove special case for command
4989 window. Use wresize, when available.
4990 (show_source_or_disasm_and_command): Don't change window
4992 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4993 <make_visible>: New method.
4994 * tui/tui-command.c (tui_cmd_window::resize): New method.
4996 2019-08-15 Tom Tromey <tom@tromey.com>
4998 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4999 (struct tui_source_windows): New.
5000 * tui/tui-winsource.c (tui_display_main): Update.
5001 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5002 (new_height_ok, parse_scrolling_args): Update.
5003 * tui/tui-layout.c (show_layout, show_data): Update.
5004 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5005 (tui_add_to_source_windows): Don't declare.
5006 * tui/tui-data.c (source_windows, tui_source_windows)
5007 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5009 2019-08-15 Tom Tromey <tom@tromey.com>
5011 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5013 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5014 * tui/tui-layout.c (show_source_disasm_command, show_data):
5016 (tui_gen_win_info::resize): Rename.
5017 (show_source_or_disasm_and_command): Update.
5018 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5021 2019-08-15 Tom Tromey <tom@tromey.com>
5023 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5024 * tui/tui-interp.c (tui_interp::init): Don't call
5025 tui_initialize_static_data.
5026 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5028 2019-08-15 Tom Tromey <tom@tromey.com>
5030 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5031 examine tui_win_list.
5033 2019-08-15 Tom Tromey <tom@tromey.com>
5035 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5036 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5037 tui_clear_source_content.
5038 (tui_clear_source_content): Remove.
5039 (tui_source_window_base::do_erase_source_content): Hoist call to
5041 * tui/tui-stack.c (tui_show_frame_info): Don't call
5042 tui_clear_source_content.
5044 2019-08-15 Tom Tromey <tom@tromey.com>
5046 * tui/tui-winsource.h (struct tui_source_window_base)
5047 <do_erase_source_content>: New method.
5048 <erase_source_content>: New method.
5049 (tui_erase_source_content): Don't declare.
5050 * tui/tui-winsource.c (tui_clear_source_content): Update.
5051 (tui_source_window_base::do_erase_source_content): Rename from
5052 tui_erase_source_content.
5053 (tui_source_window_base::show_source_content): Update.
5054 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5055 * tui/tui-source.h (struct tui_source_window)
5056 <erase_source_content>: New method.
5057 * tui/tui-disasm.h (struct tui_disasm_window)
5058 <erase_source_content>: New method.
5060 2019-08-15 Tom Tromey <tom@tromey.com>
5062 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5063 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5065 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5066 * tui/tui-source.c (tui_set_source_content): Update.
5067 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5069 2019-08-15 Tom Tromey <tom@tromey.com>
5071 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5072 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5074 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5076 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5078 (tui_source_window::maybe_update): Update.
5080 2019-08-15 Tom Tromey <tom@tromey.com>
5082 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5083 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5085 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5087 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5089 (tui_disasm_window::maybe_update): Update.
5091 2019-08-15 Tom Tromey <tom@tromey.com>
5093 * tui/tui-winsource.h (struct tui_source_window_base)
5094 <maybe_update>: Declare.
5095 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5097 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5099 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5100 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5102 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5104 2019-08-15 Tom Tromey <tom@tromey.com>
5106 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5108 2019-08-15 Tom Tromey <tom@tromey.com>
5110 * tui/tui-wingeneral.c: Include tui-stack.h.
5111 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5112 (struct tui_locator_window): Move from tui-data.h.
5113 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5114 (tui_initialize_static_data): Move from tui-data.c.
5115 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5116 (struct tui_locator_window): Move to tui-stack.c.
5117 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5118 (tui_initialize_static_data): Move to tui-stack.c.
5120 2019-08-15 Tom Tromey <tom@tromey.com>
5122 * tui/tui-layout.c (show_source_disasm_command)
5123 (show_source_or_disasm_and_command): Use make_visible method, not
5125 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5128 2019-08-15 Tom Tromey <tom@tromey.com>
5130 * tui/tui-wingeneral.h (tui_make_window): Update.
5131 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5133 (tui_gen_win_info::make_visible): Update.
5134 * tui/tui-regs.c (tui_data_window::display_registers_from):
5136 * tui/tui-layout.c (show_source_disasm_command)
5137 (show_source_or_disasm_and_command): Update.
5138 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5139 (enum tui_box): Remove.
5140 (struct tui_win_info) <can_box>: New method.
5141 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5144 2019-08-15 Tom de Vries <tdevries@suse.de>
5146 * linux-nat-trad.c: Include gdbarch.h.
5148 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5150 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5153 2019-08-14 Tom Tromey <tromey@adacore.com>
5155 * darwin-nat.c: Include gdbarch.h.
5156 * darwin-nat-info.c: Include gdbarch.h.
5158 2019-08-13 Tom Tromey <tom@tromey.com>
5160 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5162 * tui/tui-data.c (tui_initialize_static_data): Update.
5164 2019-08-13 Tom Tromey <tom@tromey.com>
5166 * tui/tui-winsource.h (struct tui_exec_info_window)
5167 <~tui_exec_info_window, maybe_allocate_content, get_content,
5169 (struct tui_source_window_base) <set_exec_info_content,
5170 show_exec_info_content>: Don't declare.
5171 * tui/tui-winsource.c
5172 (tui_exec_info_window::maybe_allocate_content): Remove.
5173 (tui_source_window_base::update_exec_info): Rename from
5174 set_exec_info_content.
5175 (tui_source_window_base::show_exec_info_content)
5176 (tui_source_window_base::update_exec_info): Remove.
5178 2019-08-13 Tom Tromey <tom@tromey.com>
5180 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5182 * tui/tui-winsource.c (tui_update_source_window_as_is)
5183 (tui_update_source_windows_with_addr, tui_erase_source_content):
5185 (tui_clear_exec_info_content): Remove.
5187 2019-08-13 Tom Tromey <tom@tromey.com>
5189 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5191 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5192 call tui_erase_exec_info_content.
5193 (tui_clear_exec_info_content): Rename from
5194 tui_erase_exec_info_content.
5195 (tui_clear_exec_info_content): Delete.
5197 2019-08-13 Tom Tromey <tom@tromey.com>
5199 * tui/tui-winsource.h (struct tui_source_window_base)
5200 <show_exec_info_content>: Declare.
5201 (tui_show_exec_info_content): Don't declare.
5202 * tui/tui-winsource.c
5203 (tui_source_window_base::show_exec_info_content): Rename from
5204 tui_show_exec_info_content.
5205 (tui_source_window_base::update_exec_info): Update.
5207 2019-08-13 Tom Tromey <tom@tromey.com>
5209 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5210 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5211 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5212 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5213 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5214 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5217 2019-08-13 Tom Tromey <tom@tromey.com>
5219 * tui/tui-winsource.h (struct tui_source_window_base)
5220 <update_exec_info>: Declare.
5221 (tui_update_exec_info): Don't declare.
5222 * tui/tui-winsource.c (tui_update_source_window_as_is)
5223 (tui_source_window_base::refresh_all)
5224 (tui_update_all_breakpoint_info): Update.
5225 (tui_source_window_base::update_exec_info): Rename from
5226 tui_update_exec_info.
5227 * tui/tui-stack.c (tui_show_frame_info): Update.
5229 2019-08-13 Tom Tromey <tom@tromey.com>
5231 * tui/tui-winsource.h (struct tui_source_window_base)
5232 <set_exec_info_content>: Declare.
5233 (tui_set_exec_info_content): Don't declare.
5234 * tui/tui-winsource.c
5235 (tui_source_window_base::set_exec_info_content): Rename from
5236 tui_set_exec_info_content.
5237 (tui_update_exec_info): Update.
5239 2019-08-13 Tom Tromey <tom@tromey.com>
5241 * tui/tui-winsource.h (struct tui_source_window_base)
5242 <show_source_content>: Declare.
5243 (tui_show_source_content): Don't declare.
5244 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5245 (tui_source_window_base::show_source_content): Rename from
5246 tui_show_source_content.
5247 (tui_source_window_base::refresh_all): Update.
5248 * tui/tui-layout.c (show_source_disasm_command)
5249 (show_source_or_disasm_and_command): Update.
5251 2019-08-13 Tom Tromey <tom@tromey.com>
5253 * tui/tui-winsource.c (tui_erase_source_content)
5254 (tui_show_source_content, tui_source_window_base::refresh_all):
5256 * tui/tui-wingeneral.h
5257 (tui_check_and_display_highlight_if_needed): Don't declare.
5258 * tui/tui-wingeneral.c
5259 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5260 check_and_display_highlight_if_needed.
5261 * tui/tui-win.c (tui_rehighlight_all)
5262 (tui_win_info::make_visible_with_new_height): Update.
5263 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5264 (tui_data_window::erase_data_content)
5265 (tui_data_window::display_all_data): Update.
5266 * tui/tui-data.h (struct tui_win_info)
5267 <check_and_display_highlight_if_needed>: Declare.
5269 2019-08-13 Tom Tromey <tom@tromey.com>
5271 * tui/tui-win.c (tui_resize_all): Call
5272 tui_delete_invisible_windows.
5273 * tui/tui-layout.c (show_layout): Call
5274 tui_delete_invisible_windows.
5275 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5276 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5278 2019-08-13 Tom Tromey <tom@tromey.com>
5280 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5281 tui_add_win_to_layout.
5283 2019-08-13 Tom Tromey <tom@tromey.com>
5285 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5286 * tui/tui-layout.c (tui_default_win_height): Now static.
5288 2019-08-13 Tom Tromey <tom@tromey.com>
5290 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5292 (show_source_disasm_command, show_source_or_disasm_and_command):
5293 Don't check current layout.
5295 2019-08-13 Tom Tromey <tom@tromey.com>
5297 * tui/tui-wingeneral.c (make_all_visible): Remove.
5298 (tui_make_all_invisible): Simplify.
5299 * tui/tui-layout.c (tui_make_all_invisible): Move from
5300 tui-wingeneral.c; simplify.
5301 (show_layout): Hoist call to tui_make_all_invisible.
5302 (show_data): Don't call tui_make_all_invisible.
5304 2019-08-13 Tom Tromey <tom@tromey.com>
5306 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5307 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5309 2019-08-13 Tom Tromey <tom@tromey.com>
5311 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5313 (show_source_disasm_command, show_data)
5314 (show_source_or_disasm_and_command): Don't use
5315 tui_set_current_layout_to.
5316 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5317 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5319 (tui_set_current_layout_to): Remove.
5321 2019-08-13 Tom Tromey <tom@tromey.com>
5323 * tui/tui-layout.c (tui_set_layout): Update.
5324 * tui/tui-data.h (struct tui_layout_def): Remove.
5325 (tui_layout_def): Don't declare.
5326 * tui/tui-data.c (layout_def): Remove.
5327 (tui_layout_def): Remove.
5329 2019-08-13 Tom Tromey <tom@tromey.com>
5331 * tui/tui-winsource.h (struct tui_source_window_base)
5332 <clear_detail>: No longer "override".
5333 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5334 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5335 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5336 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5338 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5340 2019-08-13 Tom Tromey <tromey@adacore.com>
5342 * tracepoint.c: Don't include readline.h or history.h.
5344 2019-08-12 Tom Tromey <tom@tromey.com>
5346 * configure: Rebuild.
5347 * configure.ac: Check for readline 7.
5348 * NEWS: Mention readline 7 requirement.
5351 2019-08-12 Tom Tromey <tom@tromey.com>
5353 * mingw-hdep.c (gdb_select): Remove readline hack.
5355 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5357 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5358 when the function fails.
5360 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5362 * s390-tdep.c (s390_type_align): New function.
5363 (s390_gdbarch_init): Set it as type_align gdbarch method.
5365 2019-08-09 Tom de Vries <tdevries@suse.de>
5368 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5369 pc_low with relocation offset.
5371 2019-08-07 Tom Tromey <tromey@adacore.com>
5373 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5374 (print_frame_args): Update.
5375 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5377 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5378 * frame.h (struct frame_arg): Add initializers.
5379 <error>: Now a unique_xmalloc_ptr.
5381 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5383 * NEWS: Expand the Pointer Authentication entry.
5384 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5385 (aarch64_frame_unmask_lr): ... to this.
5386 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5387 Call aarch64_frame_unmask_lr.
5388 * frame.c (struct frame_info): Add "masked" variable.
5389 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5390 (fprint_frame): Check for masked pc.
5391 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5393 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5394 * stack.c (print_frame): Check for masked pc.
5396 2019-08-06 Tom Tromey <tom@tromey.com>
5398 * stabsread.c (patch_block_stabs, read_one_struct_field)
5399 (read_enum_type): Use obstack_strndup.
5400 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5401 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5402 * dwarf2read.c (guess_full_die_structure_name)
5403 (anonymous_struct_prefix): Use obstack_strndup.
5404 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5405 * c-exp.y (yylex): Use obstack_strndup.
5406 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5407 (write_var_or_type): Use obstack_strndup.
5409 2019-08-06 Tom Tromey <tom@tromey.com>
5411 * symfile.c (reread_symbols): Use obstack_strdup.
5412 * stabsread.c (read_type): Use obstack_strdup.
5413 * gdb_obstack.h (obstack_strdup): New overload.
5414 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5415 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5416 (dwarf2_canonicalize_name): Use obstack_strdup.
5417 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5418 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5421 2019-08-06 Tom Tromey <tom@tromey.com>
5423 * gdb_obstack.h (obstack_strdup): Define.
5424 * gdb_obstack.c (obstack_strdup): Don't define.
5426 2019-08-06 Tom Tromey <tom@tromey.com>
5428 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5430 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5432 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5433 * stabsread.c (common_block_start): Use obstack_strdup.
5434 * objfiles.c (set_objfile_main_name, objfile): Use
5436 * namespace.c (add_using_directive): Use obstack_strdup.
5437 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5438 * jit.c (finalize_symtab): Use obstack_strdup.
5439 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5440 (guess_partial_die_structure_name, partial_die_info::fixup)
5441 (dwarf2_name): Use obstack_strdup.
5442 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5444 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5445 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5447 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5449 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5451 * unittests/help-doc-selftests.c: New file.
5452 * Makefile.in: Add the new file.
5454 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5456 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5457 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5458 the full first line, except when FOR_VALUE_PREFIX. In this case,
5459 the trailing '.' is not output, and the first character is uppercased.
5460 (print_help_for_command): Update call to print_doc_line.
5461 (print_doc_of_command): Likewise.
5462 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5463 * cli/cli-option.c (append_indented_doc): Do not append newline.
5464 (build_help_option): Append newline after first appended_indented_doc
5465 only if a second call is done.
5466 (build_help): Append 2 new lines before each option, except the first
5468 * compile/compile.c (_initialize_compile): Add new lines after
5469 %OPTIONS%, when not at the end of the help.
5470 Change help doc or code
5471 producing the help doc to respect the invariants.
5472 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5473 Also removed the new line after 'Options:', as all other commands
5474 do not put an empty line between 'Options:' and the first option.
5475 * printcmd.c (_initialize_printcmd): Likewise.
5476 * stack.c (_initialize_stack): Likewise.
5477 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5478 incorrectly telling COMMAND is optional.
5479 * ada-lang.c (_initialize_ada_language): Change help doc or code
5480 producing the help doc to respect the invariants.
5481 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5482 * breakpoint.c (_initialize_breakpoint): Likewise.
5483 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5484 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5485 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5486 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5487 _initialize_cli_style): Likewise.
5488 * corelow.c (core_target_info): Likewise.
5489 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5490 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5491 * filesystem.c (_initialize_filesystem): Likewise.
5492 * frame.c (_initialize_frame): Likewise.
5493 * gnu-nat.c (add_task_commands): Likewise.
5494 * infcall.c (_initialize_infcall): Likewise.
5495 * infcmd.c (_initialize_infcmd): Likewise.
5496 * interps.c (_initialize_interpreter): Likewise.
5497 * language.c (_initialize_language): Likewise.
5498 * linux-fork.c (_initialize_linux_fork): Likewise.
5499 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5500 * maint.c (_initialize_maint_cmds): Likewise.
5501 * memattr.c (_initialize_mem): Likewise.
5502 * printcmd.c (_initialize_printcmd): Likewise.
5503 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5505 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5506 * record-btrace.c (_initialize_record_btrace): Likewise.
5507 * record-full.c (_initialize_record_full): Likewise.
5508 * record.c (_initialize_record): Likewise.
5509 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5510 * regcache.c (_initialize_regcache): Likewise.
5511 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5512 _initialize_remote): Likewise.
5513 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5514 * serial.c (_initialize_serial): Likewise.
5515 * skip.c (_initialize_step_skip): Likewise.
5516 * source.c (_initialize_source): Likewise.
5517 * stack.c (_initialize_stack): Likewise.
5518 * symfile.c (_initialize_symfile): Likewise.
5519 * symtab.c (_initialize_symtab): Likewise.
5520 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5521 * top.c (init_main): Likewise.
5522 * tracefile-tfile.c (tfile_target_info): Likewise.
5523 * tracepoint.c (_initialize_tracepoint): Likewise.
5524 * tui/tui-win.c (_initialize_tui_win): Likewise.
5525 * utils.c (add_internal_problem_command): Likewise.
5526 * valprint.c (value_print_option_defs): Likewise.
5528 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5531 * configure.ac: Drop enable-libmcheck support.
5532 * configure, config.in: Rebuild.
5533 * libmcheck.m4: Remove.
5534 * acinclude.m4: Don't include it.
5535 * Makefile.in: Don't distribute it.
5536 * top.c (print_gdb_configuration): Don't mention it.
5538 2019-08-06 Tom Tromey <tom@tromey.com>
5540 * utils.c (set_output_style): Sometimes pass stream to
5542 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5543 * record-btrace.c (btrace_insn_history): Update.
5544 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5546 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5547 Update initializers.
5548 <m_uiout>: New field.
5550 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5551 Remove "uiout" parameter.
5552 (dump_insns): Update.
5553 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5554 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5556 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5558 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5559 (error_in_psymtab_expansion): Likewise.
5560 (lookup_symbol_via_quick_fns): Likewise.
5561 (basic_lookup_transparent_type_quick): Likewise.
5562 (basic_lookup_transparent_type_1): Likewise.
5564 2019-08-06 Tom Tromey <tromey@adacore.com>
5566 * source.c (last_source_error): Now bool.
5567 (print_source_lines_base): Make "noprint" bool. Only open
5568 source file when last_source_visited changes.
5570 2019-08-06 Tom Tromey <tromey@adacore.com>
5572 * annotate.c (annotate_source_line): Use g_source_cache.
5573 * source-cache.c (source_cache::get_plain_source_lines): Change
5574 parameters. Populate m_offset_cache.
5575 (source_cache::ensure): New method.
5576 (source_cache::get_line_charpos): New method.
5577 (extract_lines): Move lower. Change parameters.
5578 (source_cache::get_source_lines): Move lower.
5579 * source-cache.h (class source_cache): Update comment.
5580 <get_line_charpos>: New method.
5581 <get_source_lines>: Update comment.
5582 <clear>: Clear m_offset_cache.
5583 <get_plain_source_lines>: Change parameters.
5584 <ensure>: New method
5585 <m_offset_cache>: New member.
5586 * source.c (forget_cached_source_info_for_objfile): Update.
5587 (info_source_command): Use g_source_cache.
5588 (find_source_lines, open_source_file_with_line_charpos): Remove.
5589 (print_source_lines_base, search_command_helper): Use g_source_cache.
5590 * source.h (open_source_file_with_line_charpos): Don't declare.
5591 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5592 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5595 2019-08-06 Tom Tromey <tromey@adacore.com>
5597 * source-cache.c (source_cache::get_plain_source_lines):
5598 Remove "first_line" and "last_line" parameters.
5599 (source_cache::get_source_lines): Cache plain text.
5600 * source-cache.h (class source_cache)
5601 <get_plain_source_lines>: Update.
5603 2019-08-06 Tom Tromey <tromey@adacore.com>
5605 * source-cache.c (extract_lines): No longer a method.
5606 Changed type of parameter. Include final newline.
5607 (selftests::extract_lines_test): New function.
5608 (_initialize_source_cache): Likewise.
5609 * source-cache.h (class source_cache)
5610 <extract_lines>: Don't declare.
5612 2019-08-06 Tom Tromey <tromey@adacore.com>
5614 * breakpoint.c (init_breakpoint_sal): Update.
5615 (breakpoint): Update.
5616 * breakpoint.h (struct breakpoint) <filter>: Now a
5619 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5621 * NEWS: Mention dictionary access on blocks.
5622 * python/py-block.c (blpy_getitem): New function.
5623 (block_object_as_mapping): New struct.
5624 (block_object_type): Use new struct for tp_as_mapping field.
5626 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5628 * objfiles.h (objfile): Add a comment describing partial symbols.
5630 2019-08-05 Tom Tromey <tromey@adacore.com>
5632 * compile/compile.c (_initialize_compile): Use _(), not N_().
5633 * thread.c (_initialize_thread): Use _(), not N_().
5634 * stack.c (_initialize_stack): Use _(), not N_().
5635 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5637 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5639 * dwarf2read.c (struct dw2_symtab_iterator):
5640 <want_specific_block>: Remove.
5641 <block_index>: Change type to gdb::optional.
5642 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5643 change type of BLOCK_INDEX parameter to gdb::optional.
5644 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5645 (dw2_lookup_symbol): Don't pass argument for
5646 WANT_SPECIFIC_BLOCK.
5647 (dw2_expand_symtabs_for_function): Don't pass argument for
5648 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5649 (class dw2_debug_names_iterator)
5650 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5651 parameter, change BLOCK_INDEX type to gdb::optional.
5652 <m_want_specific_block>: Remove.
5653 <m_block_index>: Change type to gdb::optional.
5654 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5655 gdb::optional. Re-write in function of gdb::optional.
5656 (dw2_debug_names_lookup_symbol): Don't pass argument for
5657 WANT_SPECIFIC_BLOCK.
5658 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5659 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5662 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5664 * NEWS: Mention changes to "info sources" command.
5666 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5668 * symtab.c (filename_partial_match_opts): New struct type.
5669 (struct output_source_filename_data): New members
5670 regexp, c_regexp, partial_match.
5671 (output_source_filename): Use new members to decide to print file.
5672 (info_sources_option_defs): New variable.
5673 (make_info_sources_options_def_group, print_info_sources_header,
5674 info_sources_command_completer):
5676 (info_sources_command): Read new optional arguments.
5677 (_initialize_symtab): Update info sources help.
5679 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5681 * ada-lang.c (exception_support_info_v0): Renamed from...
5682 (default_exception_support_info): ... this. Create new
5684 (ada_has_this_exception_support): Look up catch_handlers_sym.
5685 (ada_exception_support_info_sniffer): Try v0 after default.
5687 2019-08-01 Tom Tromey <tromey@adacore.com>
5689 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5692 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5694 * s12z-tdep.c: Fix include path for s12z-opc.h.
5696 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5698 * NEWS: Require GNU make 3.82.
5700 2019-07-16 Tom Tromey <tom@tromey.com>
5702 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5705 2019-07-30 Tom Tromey <tromey@adacore.com>
5707 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5709 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5711 * printcmd.c (print_address_symbolic): Print negative offsets.
5712 (build_address_symbolic): Force signed arithmetic when computing
5715 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5717 PR/24474: Add a function to lookup static variables.
5718 * NEWS: Mention this new function.
5719 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5720 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5721 * python/python.c (python_GdbMethods): Add new function.
5723 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5725 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5726 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5727 (objfpy_lookup_static_symbol): New function.
5728 (objfile_object_methods): Add new functions.
5730 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5732 * NEWS: Mention 'set|show print frame-info'. Mention new
5733 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5734 backtrace argument. Mention that python frame filtering code
5735 is now consistent with what 'backtrace' command prints.
5737 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5739 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5741 (print_frame_info_auto, print_frame_info_source_line,
5742 print_frame_info_location, print_frame_info_source_and_location,
5743 print_frame_info_location_and_address, print_frame_info_short_location):
5745 (struct frame_print_options): New member print_frame_info.
5746 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5747 * stack.h (get_user_print_what_frame_info): New declaration.
5748 (frame_show_address): New declaration.
5749 * stack.c (print_frame_arguments_choices): New value 'presence'.
5750 (print_frame_info_auto, print_frame_info_source_line,
5751 print_frame_info_location, print_frame_info_source_and_location,
5752 print_frame_info_location_and_address, print_frame_info_short_location,
5753 print_frame_info_choices, print_frame_info_print_what): New definitions.
5754 (print_frame_args): Only print dots for args if print frame-arguments
5756 (frame_print_option_defs): New element for "frame-info".
5757 (get_user_print_what_frame_info): New function.
5758 (frame_show_address): Make non static. Move comment to stack.h.
5759 (print_frame_info_to_print_what): New function.
5760 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5761 to decide what to print.
5762 (backtrace_command_1): Handle the new print_frame_arguments_presence
5764 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5765 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5766 (py_print_frame): In non-mi mode, use LOCATION as default for
5767 print_what, similarly to frame information printed directly by
5768 backtrace command. Handle frame-info user option in non MI mode.
5770 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5772 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5773 Add case for debugging 32-bit target on 64-bit host. Revise
5776 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5778 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5779 instead of find_function_entry_range_from_pc.
5781 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5783 * stack.c (find_frame_funname): Remove code which preferred
5784 minsym over symtab sym in "certain pathological cases".
5786 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5787 parameter. Change type of "do_demangle" to bool.
5788 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5789 Pass suitable "prefer_sym_over_minsym" flag to
5790 build_address_symbolic(). Don't output "+" for negative offsets.
5791 * printcmd.c (print_address_symbolic): Update invocation of
5792 build_address_symbolic to include a "prefer_sym_over_minsym"
5794 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5795 Restrict cases in which use of minimal symbol is preferred to that
5796 of a found symbol. Update comments.
5798 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5799 for entry pc when entry pc is out of range for that FDE.
5801 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5804 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5807 2019-07-25 Christian Biesinger <cbiesinger@google.com>
5809 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5810 this function's Python signature.
5813 2019-07-24 Christian Biesinger <cbiesinger@google.com>
5815 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5816 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5817 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5818 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5819 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5822 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5824 * h8300-tdep.c (h8300_register_name_common): New.
5825 h8300_register_name): Use h8300_register_name_common.
5826 (h8300s_register_name): Likewise.
5827 (h8300sx_register_name): Likewise.
5828 (h8300h_register_nam): New.
5829 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5832 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5834 * arm-tdep.c (arm_skip_cmse_entry): New function.
5835 (arm_is_sgstubs_section): New function.
5836 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5838 2019-07-22 Tom Tromey <tom@tromey.com>
5840 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5843 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5845 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5848 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5850 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5851 so that GDB doesn't match any msymbols when searching in the
5853 (print_symbol_info): Print using typedef_print or type_print based
5854 on the type of the symbol. Add updated FIXME comment moved from...
5855 (_initialize_symtab): ... move and update FIXME comment to above.
5857 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5859 * NEWS: Mention adding -q option to "info types".
5860 * symtab.c (struct info_types_options): New struct.
5861 (info_types_options_defs): New variable.
5862 (make_info_types_options_def_group): New function.
5863 (info_types_command): Use gdb::option framework to parse options.
5864 (info_types_command_completer): New function.
5865 (_initialize_symtab): Extend the help text on "info types" and
5866 register command completer.
5868 2019-07-21 Christian Biesinger <cbiesinger@google.com>
5870 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5871 (lookup_symbol_in_objfile): Change int to block_enum and add a
5872 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5874 2019-07-20 Christian Biesinger <cbiesinger@google.com>
5876 * MAINTAINERS (Write After Approval): Add self.
5878 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5880 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5881 instruction to the dummy code region.
5883 2019-07-19 Tom Tromey <tromey@adacore.com>
5885 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5886 (ARGSUSED, PARAMS, __func__): Remove rules.
5888 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5890 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5891 * features/arm/arm-with-iwmmxt.c: Remove.
5892 * features/arm/arm-with-iwmmxt.xml: Remove.
5893 * features/arm/arm-with-m-fpa-layout.c: Remove.
5894 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5895 * features/arm/arm-with-m-vfp-d16.c: Remove.
5896 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5897 * features/arm/arm-with-m.c: Remove.
5898 * features/arm/arm-with-m.xml: Remove.
5899 * features/arm/arm-with-neon.c: Remove.
5900 * features/arm/arm-with-neon.xml: Remove.
5901 * features/arm/arm-with-vfpv2.c: Remove.
5902 * features/arm/arm-with-vfpv2.xml: Remove.
5903 * features/arm/arm-with-vfpv3.c: Remove.
5904 * features/arm/arm-with-vfpv3.xml: Remove.
5906 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5908 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5910 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5912 * arch/aarch32.c (aarch32_create_target_description): Create
5913 target descriptions using features.
5914 * arch/arm.c (arm_create_target_description)
5915 (arm_create_mprofile_target_description): Likewise.
5916 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5918 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5920 * Makefile.in: Add new files.
5921 * aarch32-tdep.c: New file.
5922 * aarch32-tdep.h: New file.
5923 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5924 Call aarch32_read_description.
5925 * arch/aarch32.c: New file.
5926 * arch/aarch32.h: New file.
5927 * arch/arm.c (arm_create_target_description)
5928 (arm_create_mprofile_target_description): New function.
5929 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5930 (arm_create_target_description)
5931 (arm_create_mprofile_target_description): New declaration.
5932 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5933 read_description functions.
5934 * arm-linux-nat.c (arm_linux_nat_target::read_description):
5936 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5937 * arm-tdep.c (tdesc_arm_list): New variable.
5938 (arm_register_g_packet_guesses): Call create description functions.
5939 (arm_read_description) (arm_read_mprofile_description): New
5941 * arm-tdep.h (arm_read_description)
5942 (arm_read_mprofile_description): Add declaration.
5943 * configure.tgt: Add new files.
5945 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
5947 * top.c (new_ui_command): Open specified terminal just once.
5949 2019-07-18 Tom Tromey <tromey@adacore.com>
5951 * symtab.c (main_name): Constify return type.
5952 * symfile.c (set_initial_language): Update.
5953 * symtab.h (main_name): Constify return type.
5955 2019-07-17 Tom Tromey <tom@tromey.com>
5957 * tui/tui-winsource.c (tui_update_source_window)
5958 (tui_update_source_window_as_is)
5959 (tui_update_source_windows_with_line): Remove return.
5960 * tui/tui-disasm.c (tui_show_disassem)
5961 (tui_show_disassem_and_update_source): Remove return.
5962 * tui/tui.c (tui_reset): Remove return.
5963 * tui/tui-wingeneral.c
5964 (tui_check_and_display_highlight_if_needed): Remove return.
5966 2019-07-17 Tom Tromey <tom@tromey.com>
5968 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5970 2019-07-17 Tom Tromey <tom@tromey.com>
5972 * tui/tui-winsource.h (struct tui_exec_info_window)
5973 (struct tui_source_window_base): Move from tui-data.h.
5974 * tui/tui-winsource.c: Move many method definitions from
5975 elsewhere. Remove "structuring" comments.
5976 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5977 (tui_source_window_base::refresh_window): Move to
5979 * tui/tui-win.c (tui_source_window_base::refresh_all)
5980 (tui_source_window_base::update_tab_width)
5981 (tui_source_window_base::set_new_height)
5982 (tui_source_window_base::do_make_visible_with_new_height): Move to
5984 * tui/tui-source.h: Update.
5985 * tui/tui-source.c (tui_source_window_base::reset): Move to
5987 * tui/tui-disasm.h: Update.
5988 * tui/tui-data.h (struct tui_exec_info_window): Move to
5990 (struct tui_source_window_base): Likewise.
5991 * tui/tui-data.c (tui_source_window_base::clear_detail)
5992 (tui_source_window_base, ~tui_source_window_base): Move to
5995 2019-07-17 Tom Tromey <tom@tromey.com>
5997 * tui/tui-win.c (tui_resize_all)
5998 (tui_source_window_base::update_tab_width)
5999 (tui_adjust_win_heights): Update.
6000 (tui_win_info::make_invisible_and_set_new_height): Rename from
6001 make_invisible_and_set_new_height.
6002 * tui/tui-data.h (struct tui_win_info)
6003 <make_invisible_and_set_new_height>: New method.
6005 2019-07-17 Tom Tromey <tom@tromey.com>
6007 * tui/tui.c: Update.
6008 * tui/tui-source.h (struct tui_source_window): Move from
6010 * tui/tui-layout.c: Update.
6011 * tui/tui-disasm.c: Update.
6012 * tui/tui-data.h (struct tui_source_window): Move to
6015 2019-07-17 Tom Tromey <tom@tromey.com>
6017 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6019 * tui/tui-data.h (struct tui_disasm_window): Move to
6022 2019-07-17 Tom Tromey <tom@tromey.com>
6024 * tui/tui-regs.h (struct tui_data_item_window): Move from
6026 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6027 * tui/tui-data.h (struct tui_data_item_window): Move to
6029 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6031 2019-07-17 Tom Tromey <tom@tromey.com>
6033 * tui/tui.c: Update.
6034 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6035 (tui_cmd_window::max_height): Move to tui-command.c.
6036 * tui/tui-layout.c: Update.
6037 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6038 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6040 * tui/tui-command.h (struct tui_cmd_window): Move from
6042 * tui/tui-command.c: Remove "structuring" comments.
6043 (tui_cmd_window::clear_detail)
6044 (tui_cmd_window::do_make_visible_with_new_height)
6045 (tui_cmd_window::max_height): Move from elsewhere.
6047 2019-07-17 Tom Tromey <tom@tromey.com>
6049 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6051 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6052 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6054 2019-07-17 Tom Tromey <tom@tromey.com>
6056 * tui/tui.c: Update.
6057 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6059 * tui/tui-windata.h: Remove file.
6060 * tui/tui-windata.c: Remove file.
6061 * tui/tui-win.c (tui_data_window::set_new_height)
6062 (tui_data_window::do_make_visible_with_new_height): Move to
6064 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6065 * tui/tui-regs.c: Remove "structuring" comments.
6066 (tui_data_window::first_data_item_displayed)
6067 (tui_data_window::delete_data_content_windows)
6068 (tui_data_window::erase_data_content)
6069 (tui_data_window::display_all_data)
6070 (tui_data_window::refresh_all)
6071 (tui_data_window::do_scroll_vertical)
6072 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6073 (tui_data_window::do_make_visible_with_new_height)
6074 (tui_data_window::refresh_window): Move from elsewhere.
6075 (_initialize_tui_regs): Move to end of file.
6076 * tui/tui-layout.c: Update.
6077 * tui/tui-hooks.c: Update.
6078 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6079 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6081 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6083 2019-07-17 Tom Tromey <tom@tromey.com>
6085 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6088 2019-07-17 Tom Tromey <tom@tromey.com>
6090 * tui/tui-win.c (tui_source_window_base::set_new_height)
6091 (tui_source_window_base::do_make_visible_with_new_height): Use
6092 m_has_locator field directly.
6093 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6095 (struct tui_source_window_base) <has_locator>: Likewise.
6097 2019-07-17 Tom Tromey <tom@tromey.com>
6099 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6101 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6103 * tui/tui-win.c (tui_source_window_base::set_new_height)
6104 (tui_source_window_base::set_new_height)
6105 (make_invisible_and_set_new_height)
6106 (tui_source_window_base::do_make_visible_with_new_height)
6107 (tui_source_window_base::do_make_visible_with_new_height):
6109 * tui/tui-layout.c (show_source_disasm_command, show_data)
6110 (show_source_or_disasm_and_command): Update.
6111 * tui/tui-layout.c (show_layout): Update.
6113 2019-07-17 Tom Tromey <tom@tromey.com>
6115 * tui/tui-layout.c (make_data_window): Remove.
6116 (show_data): Unify creation and re-initialization cases.
6118 2019-07-17 Tom Tromey <tom@tromey.com>
6120 * tui/tui-layout.c (make_source_window, make_disasm_window):
6122 (show_data): Unify creation and re-initialization cases.
6124 2019-07-17 Tom Tromey <tom@tromey.com>
6126 * tui/tui-layout.c (make_command_window): Remove.
6127 (show_source_disasm_command, show_source_or_disasm_and_command):
6128 Unify creation and re-initialization cases.
6130 2019-07-17 Tom Tromey <tom@tromey.com>
6132 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6133 creation and re-initialization cases.
6135 2019-07-17 Tom Tromey <tom@tromey.com>
6137 * tui/tui-regs.c (tui_get_register): Return void.
6139 2019-07-17 Tom Tromey <tom@tromey.com>
6141 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6144 2019-07-17 Tom Tromey <tom@tromey.com>
6146 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6149 2019-07-17 Tom Tromey <tom@tromey.com>
6151 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6152 * tui/tui-regs.c (tui_reg_layout): New function.
6153 (tui_show_registers, tui_reg_command): Use it.
6154 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6155 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6157 (tui_layout_command): Remove.
6159 2019-07-17 Tom Tromey <tom@tromey.com>
6161 * tui/tui-layout.h (tui/tui-layout): Return void.
6162 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6164 2019-07-17 Tom Tromey <tom@tromey.com>
6166 * tui/tui-layout.c (show_source_disasm_command, show_data):
6168 (reset_locator): Remove.
6169 (show_source_or_disasm_and_command): Update.
6171 2019-07-17 Tom Tromey <tom@tromey.com>
6173 * tui/tui-source.c (tui_source_window_base::reset): Remove
6175 * tui/tui-layout.c (make_command_window, make_source_window)
6176 (make_disasm_window, make_data_window)
6177 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6178 (reset_locator, show_source_or_disasm_and_command): Update.
6179 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6181 (struct tui_source_window_base) <reset>: Likewise.
6183 2019-07-17 Tom Tromey <tom@tromey.com>
6185 * tui/tui-layout.c (show_source_disasm_command): Use
6187 (reset_locator): New function.
6188 (init_and_make_win): Remove.
6189 (show_source_or_disasm_and_command): Use reset_locator.
6191 2019-07-17 Tom Tromey <tom@tromey.com>
6193 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6195 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6197 * tui/tui-source.c (tui_source_window_base::reset): New method.
6198 * tui/tui-layout.c (make_command_window): Don't call
6200 (make_source_window, make_disasm_window): Don't call
6201 make_source_or_disasm_window.
6202 (make_data_window): Don't call init_and_make_win. Change calling
6204 (show_source_disasm_command, show_data): Simplify.
6205 (make_source_or_disasm_window): Remove.
6206 (show_source_or_disasm_and_command): Simplify.
6207 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6208 (struct tui_source_window_base) <reset>: Likewise.
6209 <execution_info>: Remove initializer.
6210 * tui/tui-data.c (tui_source_window_base): Initialize
6213 2019-07-17 Tom Tromey <tom@tromey.com>
6215 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6218 2019-07-17 Tom Tromey <tom@tromey.com>
6220 * tui/tui.c (tui_rl_other_window): Update.
6221 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6222 superclass method first. Always iterate over regs_content.
6223 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6225 * tui/tui-win.c (tui_set_focus_command): Update.
6227 2019-07-17 Tom Tromey <tom@tromey.com>
6229 * tui/tui-win.c (tui_set_focus_command): Rename from
6230 tui_set_focus. Call tui_enable.
6231 (tui_set_focus_command): Remove.
6233 2019-07-17 Tom Tromey <tom@tromey.com>
6235 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6237 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6239 (tui_data_window::refresh_window): Call refresh_window on data
6240 items. Always call superclass refresh_window.
6241 (tui_win_info::refresh): Remove.
6242 (tui_source_window_base::refresh_window): Update.
6243 (tui_refresh_all): Update.
6244 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6246 (show_source_or_disasm_and_command): Likewise.
6247 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6248 (struct tui_source_window_base) <refresh>: Likewise.
6250 2019-07-17 Tom Tromey <tom@tromey.com>
6252 * tui/tui-winsource.c (tui_clear_source_content)
6253 (tui_show_source_content): Update.
6254 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6255 whether content is empty.
6256 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6259 2019-07-17 Tom Tromey <tom@tromey.com>
6261 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6263 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6264 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6266 2019-07-17 Tom Tromey <tom@tromey.com>
6268 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6269 (struct tui_data_item_window): Update.
6271 2019-07-17 Tom Tromey <tom@tromey.com>
6273 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6274 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6277 2019-07-17 Tom Tromey <tom@tromey.com>
6279 * tui/tui-winsource.h (tui_erase_source_content)
6280 (tui_clear_source_content): Remove "display_prompt" parameter.
6281 * tui/tui-winsource.c (tui_update_source_window_as_is)
6282 (tui_update_source_windows_with_addr): Update.
6283 (tui_clear_source_content): Remove "display_prompt" parameter.
6284 (tui_erase_source_content): Likewise. Simplify.
6285 (tui_show_source_content): Update.
6286 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6287 * tui/tui-stack.c (tui_show_frame_info): Update.
6288 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6291 2019-07-17 Tom Tromey <tom@tromey.com>
6293 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6294 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6296 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6299 2019-07-17 Tom Tromey <tom@tromey.com>
6301 * tui/tui-winsource.c (tui_clear_source_content)
6302 (tui_show_source_content, tui_show_exec_info_content)
6303 (tui_clear_exec_info_content): Update.
6304 * tui/tui-stack.c (tui_show_locator_content): Update.
6305 (tui_show_frame_info): Update.
6306 * tui/tui-source.h (tui_source_window): Don't declare.
6307 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6308 from tui_source_is_displayed.
6309 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6311 (struct tui_source_window_base) <content_in_use>: New field. Now
6313 (struct tui_source_window) <showing_source_p>: New method.
6314 (TUI_SRC_WIN): Change cast.
6315 * tui/tui-data.c (tui_initialize_static_data): Update.
6317 2019-07-17 Tom Tromey <tom@tromey.com>
6319 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6321 * tui/tui-source.c (tui_source_window::location_matches_p): New
6323 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6325 * tui/tui-data.h (struct tui_source_window_base)
6326 <location_matches_p>: New method.
6327 (struct tui_source_window, struct tui_disasm_window)
6328 <location_matches_p>: Likewise.
6330 2019-07-17 Tom Tromey <tom@tromey.com>
6332 * tui/tui-win.c (tui_set_win_height_command): Rename from
6334 (tui_set_win_height_command): Remove.
6336 2019-07-17 Tom Tromey <tom@tromey.com>
6338 * tui/tui-source.c (tui_source_window): New constructor. Add
6340 (~tui_source_window): New destructor.
6341 (tui_source_window::style_changed): New method.
6342 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6343 (tui_attach_detach_observers): Update.
6344 * tui/tui-data.h (struct tui_source_window): Make constructor not
6345 inline. Add destructor.
6346 (struct tui_source_window) <style_changed>: New method.
6347 <m_observable>: New member.
6349 2019-07-17 Tom Tromey <tom@tromey.com>
6351 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6352 * tui/tui-win.c (tui_resize_all): Fix typo.
6354 2019-07-17 Tom Tromey <tom@tromey.com>
6356 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6357 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6358 (tui_refresh_all): Remove "list" parameter. Use foreach.
6359 * tui/tui-win.c (window_name_completer): Use foreach.
6360 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6361 (update_tab_width): Likewise.
6362 * tui/tui-layout.c (show_layout): Update.
6363 * tui/tui-data.h (class tui_window_iterator): New.
6364 (struct all_tui_windows): New.
6365 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6367 2019-07-17 Tom Tromey <tom@tromey.com>
6369 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6370 parameter. Don't reference globals.
6371 (tui_reg_command): Update.
6373 2019-07-17 Tom Tromey <tom@tromey.com>
6375 * tui/tui-regs.c (tui_show_registers): Simplify.
6377 2019-07-17 Tom Tromey <tom@tromey.com>
6379 * tui/tui-regs.c (tui_show_registers): Update.
6380 (tui_show_register_group): Add win_info parameter.
6382 2019-07-17 Tom Tromey <tom@tromey.com>
6384 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6385 Rename from tui_display_reg_element_at_line.
6386 (tui_data_window::display_registers_from_line): Update.
6387 * tui/tui-data.h (struct tui_data_window)
6388 <display_reg_element_at_line>: New method.
6390 2019-07-17 Tom Tromey <tom@tromey.com>
6392 * tui/tui-regs.h (tui_display_registers_from)
6393 (tui_display_registers_from_line): Don't declare.
6394 * tui/tui-windata.c (tui_data_window::display_all_data)
6395 (tui_data_window::refresh_all)
6396 (tui_data_window::do_scroll_vertical): Update.
6397 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6398 from tui_display_registers_from.
6399 (tui_display_reg_element_at_line): Update.
6400 (tui_data_window::display_registers_from_line): Rename from
6401 tui_display_registers_from_line.
6402 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6403 display_registers_from_line>: New methods.
6405 2019-07-17 Tom Tromey <tom@tromey.com>
6407 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6408 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6409 from tui_erase_data_content.
6410 (tui_data_window::display_all_data)
6411 (tui_data_window::refresh_all)
6412 (tui_data_window::do_scroll_vertical): Update.
6413 * tui/tui-regs.c (tui_show_registers): Update.
6414 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6417 2019-07-17 Tom Tromey <tom@tromey.com>
6419 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6422 (tui_data_window::delete_data_content_windows): Rename from
6423 tui_delete_data_content_windows.
6424 (tui_data_window::display_all_data)
6425 (tui_data_window::do_scroll_vertical): Update.
6426 * tui/tui-data.h (struct tui_data_window)
6427 <delete_data_content_windows>: New method.
6429 2019-07-17 Tom Tromey <tom@tromey.com>
6431 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6432 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6434 2019-07-17 Tom Tromey <tom@tromey.com>
6436 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6437 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6438 from tui_display_all_data.
6440 (tui_data_window::do_make_visible_with_new_height): Update.
6441 * tui/tui-regs.c (tui_show_registers): Update.
6442 * tui/tui-layout.c (tui_set_layout): Update.
6443 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6446 2019-07-17 Tom Tromey <tom@tromey.com>
6448 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6449 * tui/tui-windata.c (tui_display_data_from): Remove.
6450 (tui_data_window::refresh_all): Update.
6452 2019-07-17 Tom Tromey <tom@tromey.com>
6454 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6455 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6456 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6457 tui_display_registers_from_line.
6458 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6459 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6460 "force_display" parameter.
6462 2019-07-17 Tom Tromey <tom@tromey.com>
6464 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6466 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6467 Rename from tui_first_reg_element_no_inline.
6468 (tui_display_reg_element_at_line)
6469 (tui_display_registers_from_line): Update.
6470 * tui/tui-data.h (struct tui_data_window)
6471 <first_reg_element_no_inline>: New method.
6473 2019-07-17 Tom Tromey <tom@tromey.com>
6475 * tui/tui-windata.c (tui_display_data_from)
6476 (tui_data_window::do_scroll_vertical): Update.
6477 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6478 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6479 Rename from tui_line_from_reg_element_no.
6480 (tui_display_registers_from_line): Update.
6481 * tui/tui-data.h (struct tui_data_window)
6482 <line_from_reg_element_no>: New method.
6484 2019-07-17 Tom Tromey <tom@tromey.com>
6486 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6487 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6488 tui_last_regs_line_no.
6489 (tui_display_reg_element_at_line)
6490 (tui_display_registers_from_line): Update.
6491 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6494 2019-07-17 Tom Tromey <tom@tromey.com>
6497 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6498 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6499 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6500 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6501 (tui_update_breakpoint_info): Likewise.
6502 * tui/tui-hooks.c (tui_event_create_breakpoint)
6503 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6506 2019-07-17 Tom Tromey <tom@tromey.com>
6508 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6510 2019-07-17 Tom Tromey <tom@tromey.com>
6512 * tui/tui-winsource.c (tui_update_source_window_as_is)
6513 (tui_update_source_windows_with_addr): Update.
6514 * tui/tui-source.h (tui_set_source_content)
6515 (tui_show_symtab_source): Add "win_info" parameter.
6516 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6518 (tui_show_symtab_source): Likewise.
6520 2019-07-17 Tom Tromey <tom@tromey.com>
6522 * tui/tui-wingeneral.c
6523 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6525 2019-07-17 Tom Tromey <tom@tromey.com>
6527 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6528 (struct tui_cmd_window) <can_scroll>: New method.
6529 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6532 2019-07-17 Tom Tromey <tromey@adacore.com>
6534 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6535 do_field_signed>: Rename. Change type of "value".
6536 * ui-out.c (ui_out::field_signed): Rename from field_int.
6537 Change type of "value".
6538 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6540 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6541 do_field_int. Change type of "value".
6542 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6543 do_field_int. Change type of "value".
6544 * tracepoint.c (trace_status_mi, tfind_1)
6545 (print_one_static_tracepoint_marker): Update.
6546 * thread.c (print_thread_info_1, print_selected_thread_frame):
6548 * stack.c (print_frame, print_frame_info): Update.
6549 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6551 * source.c (print_source_lines_base): Update.
6552 * skip.c (info_skip_command): Update.
6553 * record-btrace.c (btrace_ui_out_decode_error)
6554 (btrace_call_history_src_line): Update.
6555 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6557 * progspace.c (print_program_space): Update.
6558 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6559 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6560 do_field_int. Change type of "value".
6561 * mi/mi-out.c (mi_ui_out::do_table_begin)
6562 (mi_ui_out::do_table_header): Update.
6563 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6565 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6566 (mi_cmd_data_list_changed_registers, output_register)
6567 (mi_cmd_data_read_memory, mi_load_progress)
6568 (mi_cmd_trace_frame_collected): Update.
6569 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6571 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6572 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6573 (mi_cmd_var_list_children, varobj_update_one): Update.
6574 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6575 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6576 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6577 * inferior.c (print_inferior): Update.
6578 * gdb_bfd.c (print_one_bfd): Update.
6579 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6581 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6582 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6583 do_field_int. Change type of "value".
6584 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6585 do_field_int. Change type of "value".
6586 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6587 (print_one_breakpoint_location, print_it_catch_fork)
6588 (print_one_catch_fork, print_it_catch_vfork)
6589 (print_one_catch_vfork, print_it_catch_solib)
6590 (print_it_catch_exec, print_it_ranged_breakpoint)
6591 (print_mention_watchpoint, print_mention_masked_watchpoint)
6592 (bkpt_print_it, update_static_tracepoint): Update.
6593 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6594 * break-catch-syscall.c (print_it_catch_syscall): Update.
6595 * ada-tasks.c (print_ada_task_info): Update.
6596 * ada-lang.c (print_it_exception, print_mention_exception):
6599 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6601 PR breakpoints/24541
6602 * gdbarch.c: Regenerate.
6603 * gdbarch.h: Regenerate.
6604 * gdbarch.sh: Adjust return type and parameter types for
6605 'stap_adjust_register'.
6606 (i386_stap_adjust_register): Adjust signature and return new
6608 * stap-probe.c (stap_parse_register_operand): Adjust use of
6609 'gdbarch_stap_adjust_register'.
6611 2019-07-17 Tom Tromey <tromey@adacore.com>
6613 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6615 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6617 (struct s390_process_info): Add initializers.
6618 (s390_add_process): Use new.
6619 (s390_linux_nat_target::low_forget_process): Use delete.
6620 (s390_linux_nat_target::low_new_fork)
6621 (s390_linux_nat_target::stopped_by_watchpoint)
6622 (s390_linux_nat_target::low_prepare_to_resume)
6623 (s390_linux_nat_target::insert_watchpoint)
6624 (s390_linux_nat_target::insert_hw_breakpoint)
6625 (s390_linux_nat_target::remove_watchpoint)
6626 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6628 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6630 * aarch64-fbsd-nat.c: Include regcache.h.
6631 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6633 (aarch64_fbsd_nat_target::fetch_registers)
6634 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6636 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6638 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6640 * fbsd-nat.c: Include gdbarch.h.
6642 2019-07-15 Tom Tromey <tromey@adacore.com>
6644 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6646 2019-07-15 Tom Tromey <tromey@adacore.com>
6648 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6649 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6650 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6651 * cli-out.c (cli_ui_out::do_field_int): New method.
6652 * ui-out.c (ui_out::field_unsigned): New method.
6653 * symfile.c (generic_load): Use field_unsigned.
6654 (print_transfer_performance): Likewise.
6655 * record-btrace.c (ui_out_field_uint): Remove.
6656 (btrace_call_history_insn_range, btrace_call_history): Use
6658 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6660 * ui-out.h (class ui_out) <field_unsigned>: New method.
6661 <do_field_unsigned>: Likewise.
6663 2019-07-15 Tom Tromey <tromey@adacore.com>
6665 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6666 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6667 * target.c (flash_erase_command): Use field_string.
6668 * infrun.c (print_signal_received_reason): Use field_string.
6669 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6670 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6672 * ada-tasks.c (print_ada_task_info): Use field_string.
6674 2019-07-15 Tom Tromey <tromey@adacore.com>
6676 * target.c (flash_erase_command): Use field_core_addr.
6677 * symfile.c (generic_load): Use field_core_addr.
6678 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6679 Use field_core_addr.
6680 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6683 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6685 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6686 value if its desired type is smaller than a CORE_ADDR and signed.
6688 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6690 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6691 of changes to field names, and use new is_reference field to
6692 decide if a property is a reference or not.
6693 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6695 (struct dwarf2_property_baton): Update header comment, rename
6696 'referenced_type' to 'property_type' and update comments.
6697 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6698 default property type, store in property baton, update to take
6699 accound of renamed field.
6700 (read_func_scope): Update call to attr_to_dynamic_prop.
6701 (read_array_type): Likewise.
6702 (dwarf2_per_cu_addr_sized_int_type): New function.
6703 (read_subrange_index_type): Move type finding code to
6704 dwarf2_per_cu_addr_sized_int_type.
6705 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6706 (dwarf2_per_cu_addr_type): New function.
6707 (set_die_type): Update calls to attr_to_dynamic_prop.
6709 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6711 * dwarf2read.c (read_subrange_index_type): New function.
6712 (read_subrange_type): Move code into new function and call it.
6713 * gdbtypes.c (create_range_type): Add some asserts.
6715 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6717 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6718 update return statements.
6719 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6720 declaration, and update comment to match.
6721 * gdbtypes.c (resolve_dynamic_array): Update call to
6722 dwarf2_evaluate_property to match new return type.
6724 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6726 * valarith.c (value_subscripted_rvalue): Change lowerbound
6727 parameter type from int to LONGEST.
6728 * value.h (value_subscripted_rvalue): Likewise in declaration.
6730 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6732 * cli/cli-utils.c (info_print_command_completer): New function.
6733 * cli/cli-utils.h: Add 'completer.h' include, and forward
6734 declaration for 'struct cmd_list_element'.
6735 (info_print_command_completer): Declare.
6736 * stack.c (_initialize_stack): Add completer for 'info locals' and
6738 * symtab.c (_initialize_symtab): Add completer for 'info
6739 variables' and 'info functions'.
6740 * NEWS: Mention completion for additional info commands.
6742 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6744 * cli/cli-utils.c (extract_info_print_args): Delete.
6745 (extract_arg_maybe_quoted): Delete.
6746 (info_print_options_defs): New variable.
6747 (make_info_print_options_def_group): New function.
6748 (extract_info_print_options): Define new function.
6749 * cli/cli-utils.h (extract_info_print_args): Delete.
6750 (struct info_print_options): New structure.
6751 (extract_info_print_options): Declare new function.
6752 * stack.c (info_locals_command): Update to use new
6753 extract_info_print_options, also add a header comment.
6754 (info_args_command): Likewise.
6755 * symtab.c (info_variables_command): Likewise.
6756 (info_functions_command): Likewise.
6758 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6760 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6761 to extract string arguments.
6762 * common/common-utils.c (extract_string_maybe_quoted): New function.
6763 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6765 2019-07-11 Tom Tromey <tromey@adacore.com>
6767 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6768 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6769 * top.h (gdbinit): Don't declare.
6770 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6772 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6773 * top.c (gdb_init): Don't call init_cli_cmds.
6775 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6777 2019-07-11 Tom Tromey <tromey@adacore.com>
6779 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6780 after it has been moved.
6782 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6784 * valops.c (value_must_coerce_to_target): Change return type to
6786 * value.h (value_must_coerce_to_target): Likewise.
6788 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6790 * breakpoint.c (is_hardware_watchpoint): Remove
6791 forward-declaration.
6792 (is_masked_watchpoint): Change return type to bool.
6793 (is_tracepoint): Likewise.
6794 (is_breakpoint): Likewise.
6795 (is_hardware_watchpoint): Likewise.
6796 (is_watchpoint): Likewise.
6797 (is_no_memory_software_watchpoint): Likewise.
6798 (is_catchpoint): Likewise.
6799 (breakpoint_1): Make FILTER parameter's return type bool.
6800 is_masked_watchpoint): Change return type to bool.
6801 (save_breakpoints): Make FILTER parameter's return type bool.
6802 * breakpoint.h (is_breakpoint): Change return type to bool.
6803 (is_watchpoint): Likewise.
6804 (is_catchpoint): Likewise.
6805 (is_tracepoint): Likewise.
6807 2019-07-10 Tom Tromey <tom@tromey.com>
6809 * defs.h: Don't include gdbarch.h.
6810 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6811 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6812 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6813 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6814 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6815 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6816 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6817 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6818 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6819 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6820 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6821 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6822 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6823 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6824 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6825 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6826 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6827 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6828 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6829 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6830 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6831 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6832 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6833 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6834 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6835 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6836 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6838 2019-07-10 Tom Tromey <tromey@adacore.com>
6840 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6841 * breakpoint.c (init_ada_exception_breakpoint): Register as
6843 (print_one_breakpoint_location, print_one_breakpoint): Use
6844 is_ada_exception_catchpoint.
6845 * ada-lang.c (class ada_catchpoint_location): Pass
6846 bp_loc_software_breakpoint to bp_location constructor.
6847 (is_ada_exception_catchpoint): New function.
6849 2019-07-10 Tom Tromey <tromey@adacore.com>
6851 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6853 (struct arm_exidx_entry): New method operator<.
6854 (struct arm_exidx_data) <section_maps>: Change type.
6855 (arm_exidx_data_free): Remove.
6856 (arm_exidx_data_key): Change type. Move lower.
6857 (arm_exidx_new_objfile): Update.
6858 (arm_compare_exidx_entries): Remove.
6859 (arm_find_exidx_entry, _initialize_arm_tdep)
6861 2019-07-10 Tom Tromey <tromey@adacore.com>
6863 * solib-spu.c (ocl_program_data_key): Change type.
6864 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6867 2019-07-10 Tom Tromey <tromey@adacore.com>
6869 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6870 (struct solib_aix_inferior_data) <library_list>: Change type.
6871 (solib_aix_inferior_data_handle): Change type.
6872 (get_solib_aix_inferior_data): Update.
6873 (solib_aix_free_library_list): Remove.
6874 (library_list_start_library): Update.
6875 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6877 (solib_aix_get_library_list)
6878 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6879 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6881 2019-07-10 Tom Tromey <tromey@adacore.com>
6883 * solib-dsbt.c (struct dsbt_info): Add initializers.
6884 (solib_dsbt_pspace_data): Change type.
6885 (dsbt_pspace_data_cleanup): Remove.
6886 (get_dsbt_info, _initialize_dsbt_solib): Update.
6888 2019-07-10 Tom Tromey <tromey@adacore.com>
6890 * spu-tdep.c (spu_overlay_data): Change type.
6891 (spu_get_overlay_table, spu_overlay_new_objfile)
6892 (_initialize_spu_tdep): Update.
6894 2019-07-10 Tom Tromey <tromey@adacore.com>
6896 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6898 (dbx_objfile_data_key): Change type and declare later.
6899 (DBX_SYMFILE_INFO): Rewrite.
6900 * dbxread.c (dbx_objfile_data_key): Change type.
6901 (dbx_symfile_init): Update.
6902 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6903 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6904 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6906 2019-07-10 Tom Tromey <tromey@adacore.com>
6908 * jit.c (jit_program_space_key): Change type. Move lower.
6909 (get_jit_program_space_data): Update.
6910 (jit_program_space_data_cleanup): Remove.
6911 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6913 (struct jit_program_space_data): Add initializers.
6915 2019-07-10 Tom Tromey <tromey@adacore.com>
6917 * solib-darwin.c (struct darwin_info): Add initializers.
6918 (solib_darwin_pspace_data): Change type.
6919 (darwin_pspace_data_cleanup): Remove.
6920 (get_darwin_info, _initialize_darwin_solib): Update.
6922 2019-07-10 Tom Tromey <tromey@adacore.com>
6924 * remote-sim.c (struct sim_inferior_data): Add initializers,
6925 constructor, and destructor.
6926 (sim_inferior_data_key): Change type. Move lower.
6927 (check_for_duplicate_sim_descriptor): Update.
6928 (get_sim_inferior_data): Use new. Update.
6929 (~sim_inferior_data_cleanup): Rename from
6930 sim_inferior_data_cleanup. Simplify.
6931 (gdbsim_close_inferior, simulator_command)
6932 (sim_command_completer, _initialize_remote_sim): Update.
6933 (next_pid, INITIAL_PID): Move earlier.
6935 2019-07-10 Tom Tromey <tromey@adacore.com>
6937 * python/python-internal.h (create_thread_object): Return
6939 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6940 * python/py-inferior.c (struct threadlist_entry): Add
6942 <thread_obj>: Now a gdbpy_ref.
6943 (thread_to_thread_object): Update.
6944 (add_thread_object): Use new.
6945 (delete_thread_object): Use delete.
6946 (infpy_threads): Update.
6947 (py_free_inferior): Update. Construct "inf_obj" after acquiring
6950 2019-07-10 Tom Tromey <tromey@adacore.com>
6952 * valops.c (value_cast): Specialize error message for Ada.
6954 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6956 * breakpoint.c (breakpoint_1): Update doc and parameter names.
6958 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6960 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6961 bpstat_should_step): Return bool, adjust comments.
6962 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6963 bpstat_should_step): Likewise.
6965 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6967 * features/Makefile: Use feature target descriptions for Arm.
6968 * features/arm/arm-core.c: Generate new file.
6969 * features/arm/arm-fpa.c: Likewise.
6970 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6971 * features/arm/arm-m-profile.c: Likewise.
6972 * features/arm/arm-vfpv2.c: Likewise.
6973 * features/arm/arm-vfpv3.c: Likewise.
6974 * features/arm/xscale-iwmmxt.c: Likewise.
6975 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6977 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6979 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6982 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6984 * features/aarch64-pauth.c: Regenerate.
6986 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
6988 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6990 (bpstat_what): Use false instead of 0.
6992 2019-07-09 Pedro Alves <palves@redhat.com>
6994 * break-catch-throw.c (is_exception_catchpoint): New.
6995 * breakpoint.c (print_one_breakpoint_location): New parameter
6996 'raw_loc'. Handle it. Use
6997 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6998 looking at the breakpoint's type.
6999 (print_one_breakpoint): If handling "maint info breakpoints", also
7000 print locations of exception catchpoints.
7001 * breakpoint.h (is_exception_catchpoint): Declare.
7003 2019-07-09 Pedro Alves <palves@redhat.com>
7005 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7007 (allocate_location_exception_catchpoint): New.
7008 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7009 (initialize_throw_catchpoint_ops): Install
7010 allocate_location_exception_catchpoint as allocate_location
7012 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7013 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7015 (breakpoint_address_is_meaningful): Delete.
7016 (bl_address_is_meaningful): New.
7017 (breakpoint_locations_match): Adjust comment.
7018 (bp_location_from_bp_type): New, factored out of...
7019 (bp_location::bp_location(breakpoint *)): ... this.
7020 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7022 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7023 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7024 breakpoint_address_is_meaningful.
7025 (bp_locations_compare): Adjust comment.
7026 (update_global_location_list): Use bl_address_is_meaningful
7027 instead of breakpoint_address_is_meaningful.
7028 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7030 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7031 * python/py-breakpoint.c (bppy_get_location): No longer check
7032 whether location is null.
7034 2019-07-09 Pedro Alves <palves@redhat.com>
7037 * breakpoint.c (print_one_breakpoint_location): Remove
7038 single-location assert.
7040 2019-07-09 Tom Tromey <tom@tromey.com>
7042 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7043 * configure: Rebuild.
7044 * configure.ac: Change common to gdbsupport.
7045 * gdbsupport: Rename from common.
7046 * acinclude.m4: Change common to gdbsupport.
7047 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7048 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7050 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7051 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7052 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7053 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7054 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7055 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7056 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7057 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7058 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7059 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7060 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7061 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7062 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7063 coff-pe-read.c, command.h, compile/compile-c-support.c,
7064 compile/compile-c.h, compile/compile-cplus-symbols.c,
7065 compile/compile-cplus-types.c, compile/compile-cplus.h,
7066 compile/compile-loc2c.c, compile/compile.c, completer.c,
7067 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7068 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7069 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7070 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7071 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7072 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7073 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7074 features/aarch64-core.c, features/aarch64-fpu.c,
7075 features/aarch64-pauth.c, features/aarch64-sve.c,
7076 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7077 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7078 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7079 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7080 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7081 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7082 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7083 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7084 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7085 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7086 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7087 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7088 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7089 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7090 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7091 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7092 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7093 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7094 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7095 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7096 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7097 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7098 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7099 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7100 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7101 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7102 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7103 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7104 minsyms.c, mips-linux-tdep.c, namespace.h,
7105 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7106 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7107 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7108 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7109 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7110 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7111 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7112 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7113 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7114 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7115 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7116 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7117 procfs.c, producer.c, progspace.h, psymtab.h,
7118 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7119 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7120 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7121 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7122 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7123 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7124 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7125 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7126 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7127 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7128 target-memory.c, target.c, target.h, target/waitstatus.c,
7129 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7130 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7131 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7132 unittests/array-view-selftests.c,
7133 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7134 unittests/common-utils-selftests.c,
7135 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7136 unittests/format_pieces-selftests.c,
7137 unittests/function-view-selftests.c,
7138 unittests/lookup_name_info-selftests.c,
7139 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7140 unittests/mkdir-recursive-selftests.c,
7141 unittests/observable-selftests.c,
7142 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7143 unittests/parse-connection-spec-selftests.c,
7144 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7145 unittests/scoped_fd-selftests.c,
7146 unittests/scoped_mmap-selftests.c,
7147 unittests/scoped_restore-selftests.c,
7148 unittests/string_view-selftests.c, unittests/style-selftests.c,
7149 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7150 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7151 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7152 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7153 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7154 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7156 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7158 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7160 (decode_digits_ordinary): Set explicit_line field in sal.
7161 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7162 symtab_and_line that was set on an explicit line number in
7163 assembler code. Do always update the recorded symtab and line if
7164 we do skip the prologue.
7166 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7168 * breakpoint.c (set_breakpoint_location_function): Remove
7169 explicit_loc parameter.
7170 (momentary_breakpoint_from_master): Update call to
7171 set_breakpoint_location_function.
7172 (add_location_to_breakpoint): Likewise.
7174 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7176 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7177 required features based on default bfd type when no specific bfd
7180 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7182 * NEWS: Mention that GDB printf and eval commands can now print
7183 C-style and Ada-style convenience var strings without
7184 calling the inferior.
7185 * printcmd.c (printf_c_string): Locally print GDB internal var
7186 instead of transiting via the inferior.
7187 (printf_wide_c_string): Likewise.
7189 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7191 PR breakpoints/25011
7192 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7194 2019-07-04 Tom Tromey <tom@tromey.com>
7197 * tui/tui-winsource.c (tui_clear_source_content): Update.
7198 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7199 (tui_update_breakpoint_info): Update.
7200 (tui_set_exec_info_content): Update.
7201 * tui/tui-source.c (tui_set_source_content_nil): Update.
7202 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7204 * tui/tui-data.h (enum tui_bp_flag): New.
7205 (tui_bp_flags): New enum flags type.
7206 (struct tui_source_element) <break_mode>: Change type. Rename
7208 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7209 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7211 * tui/tui-winsource.h: Fix comment.
7213 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7215 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7216 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7217 (store_fpregs_to_thread)
7218 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7219 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7220 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7221 (IWMMXT_REGS_SIZE): Add define.
7222 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7223 (fetch_vfp_regs, store_vfp_regs)
7224 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7225 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7227 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7229 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7231 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7232 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7233 (ARM_INT_REGISTER_SIZE): ...to this.
7234 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7235 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7236 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7237 (arm_linux_collect_gregset, supply_nwfpe_register)
7238 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7240 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7241 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7242 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7243 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7244 (arm_return_in_memory, arm_store_return_value)
7245 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7246 (arm_record_ld_st_multiple): Likewise.
7247 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7248 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7250 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7252 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7253 AARCH64_DISPLACED_MODIFIED_INSNS.
7254 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7255 (aarch64_displaced_step_copy_insn): Likewise.
7256 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7257 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7258 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7259 ARM_DISPLACED_MODIFIED_INSNS.
7260 * arm-tdep.c (arm_gdbarch_init): Likewise.
7261 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7262 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7263 (struct arm_displaced_step_closure): Use
7264 ARM_DISPLACED_MODIFIED_INSNS.
7266 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7268 * features/Makefile: Remove unused xml files.
7269 * features/aarch64.xml: Remove.
7270 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7271 * features/i386/amd64-avx-avx512.xml: Remove.
7272 * features/i386/amd64-avx-linux.xml: Remove.
7273 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7274 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7275 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7276 * features/i386/amd64-avx-mpx.xml: Remove.
7277 * features/i386/amd64-avx.xml: Remove.
7278 * features/i386/amd64-linux.xml: Remove.
7279 * features/i386/amd64-mpx-linux.xml: Remove.
7280 * features/i386/amd64-mpx.xml: Remove.
7281 * features/i386/amd64.xml: Remove.
7282 * features/i386/i386-avx-avx512-linux.xml: Remove.
7283 * features/i386/i386-avx-avx512.xml: Remove.
7284 * features/i386/i386-avx-linux.xml: Remove.
7285 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7286 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7287 * features/i386/i386-avx-mpx-linux.xml: Remove.
7288 * features/i386/i386-avx-mpx.xml: Remove.
7289 * features/i386/i386-avx.xml: Remove.
7290 * features/i386/i386-linux.xml: Remove.
7291 * features/i386/i386-mmx-linux.xml: Remove.
7292 * features/i386/i386-mmx.xml: Remove.
7293 * features/i386/i386-mpx-linux.xml: Remove.
7294 * features/i386/i386-mpx.xml: Remove.
7295 * features/i386/i386.xml: Remove.
7296 * features/i386/x32-avx-avx512-linux.xml: Remove.
7297 * features/i386/x32-avx-linux.xml: Remove.
7298 * features/i386/x32-linux.xml: Remove.
7300 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7302 * regformats/aarch64.dat: Remove.
7303 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7304 * regformats/i386/amd64-avx-linux.dat: Remove.
7305 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7306 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7307 * regformats/i386/amd64-linux.dat: Remove.
7308 * regformats/i386/amd64-mpx-linux.dat: Remove.
7309 * regformats/i386/amd64.dat: Remove.
7310 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7311 * regformats/i386/i386-avx-linux.dat: Remove.
7312 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7313 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7314 * regformats/i386/i386-linux.dat: Remove.
7315 * regformats/i386/i386-mmx-linux.dat: Remove.
7316 * regformats/i386/i386-mpx-linux.dat: Remove.
7317 * regformats/i386/i386.dat: Remove.
7318 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7319 * regformats/i386/x32-avx-linux.dat: Remove.
7320 * regformats/i386/x32-linux.dat: Remove.
7322 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7324 * aarch64-tdep.c: Remove xml self tests.
7325 * amd64-linux-tdep.c: Likewise.
7326 * amd64-tdep.c: Likewise.
7327 * i386-linux-tdep.c: Likewise.
7328 * i386-tdep.c: Likewise.
7330 2019-07-03 Pedro Alves <palves@redhat.com>
7333 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7334 (pipe_cmd_option_defs): New.
7335 (make_pipe_cmd_options_def_group): New.
7336 (pipe_command): Use gdb::option::process_options.
7337 (pipe_command_completer): New function.
7338 (_initialize_cli_cmds): Install completer for "pipe" command.
7340 2019-07-03 Pedro Alves <palves@redhat.com>
7342 * cli/cli-option.c (union option_value) <string>: New field.
7343 (struct option_def_and_value): Add ctor, move ctor, dtor and
7344 use DISABLE_COPY_AND_ASSIGN.
7345 (option_def_and_value::clear_value): New.
7346 (parse_option, save_option_value_in_ctx, get_val_type_str)
7347 (add_setshow_cmds_for_options): Handle var_string.
7348 * cli-option.h (union option_def::var_address) <string>: New
7350 (struct string_option_def): New.
7351 * maint-test-options.c (struct test_options_opts): Add default
7352 ctor and use DISABLE_COPY_AND_ASSIGN.
7353 <string_opt>: New field.
7354 (test_options_opts::~test_options_opts): New.
7355 (test_options_opts::dump): Also dump "-string".
7356 (test_options_option_defs): Install "string.
7358 2019-07-03 Pedro Alves <palves@redhat.com>
7360 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7361 option_value with a null enumeration.
7362 (complete_options): Save the option values in the context.
7363 (save_option_value_in_ctx): New, factored out from ...
7364 (process_options): ... here.
7365 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7367 * maint-test-options.c (test_options_opts::dump): New, factored
7369 (maintenance_test_options_command_mode): ... here.
7370 (maintenance_test_options_command_completion_result): Delete.
7371 (maintenance_test_options_command_completion_text): Update
7373 (maintenance_show_test_options_completion_result): Change
7374 prototype. Just print
7375 maintenance_test_options_command_completion_text.
7376 (save_completion_result): New.
7377 (maintenance_test_options_completer_mode): Pass options context to
7378 complete_options, and then save a dump.
7379 (_initialize_maint_test_options): Use add_cmd to install "maint
7380 show test-options-completion-result".
7382 2019-07-03 Pedro Alves <palves@redhat.com>
7384 * NEWS (New commands): Mention "with" and "maint with".
7385 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7386 (with_command, with_command_completer): New.
7387 (pipe_command): Adjust to new repeat_previous
7389 (_initialize_cli_cmds): Install the "with" command and its "w"
7391 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7393 * cli/cli-setshow.c (parse_cli_var_uinteger)
7394 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7395 argument strings for all var_types.
7396 (get_setshow_command_value_string): New, factored out from ...
7397 (do_show_command): ... this.
7398 * cli/cli-setshow.h: Include <string>.
7399 (get_setshow_command_value_string): Declare.
7400 * command.h (repeat_previous): Now returns const char *. Adjust
7402 * maint.c: Include "cli/cli-cmds.h".
7403 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7404 (_initialize_maint_cmds): Register the "maintenance with" command.
7405 * top.c (repeat_previous): Move bits from pipe_command here:
7406 Return the saved command line, if any; error out if there's no
7407 command to relaunch.
7409 2019-07-03 Pedro Alves <palves@redhat.com>
7411 * NEWS (New commands): Mention "maint set/show test-settings"
7412 instead of "maint test-settings".
7413 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7414 (maintenance_test_settings_set_list): Rename to ...
7415 (maintenance_set_test_settings_list): ... this.
7416 (maintenance_test_settings_show_list): Rename to ...
7417 (maintenance_show_test_settings_list): ... this.
7418 (maintenance_test_settings_cmd): Delete.
7419 (maintenance_test_settings_set_cmd): ...
7420 (maintenance_set_test_settings_cmd): ... this.
7421 (maintenance_test_settings_show_cmd): ...
7422 (maintenance_show_test_settings_cmd): ... this.
7423 (maintenance_test_settings_show_value_cmd):
7424 (maintenance_show_test_settings_value_cmd): ... this.
7425 (_initialize_maint_test_settings): No longer install the "maint
7426 test-settings" prefix command. Rename "maint test-settings set"
7427 to "maint set test-settings", and "maint test-settings show" to
7428 "maint show test-settings". Adjust all subcommands.
7430 2019-07-03 Pedro Alves <palves@redhat.com>
7432 * maint-test-settings.c: Fix file's intro comment. Replace all
7433 references to "test-options" with references to "test-settings",
7436 2019-07-03 Pedro Alves <palves@redhat.com>
7438 * maint-test-settings.c (maintenance_test_settings_xxx)
7439 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7441 (maintenance_test_settings_enums): Use them.
7442 (maintenance_test_settings_enum): Default to
7443 maintenance_test_settings_xxx.
7444 (_initialize_maint_test_settings): Initialize
7445 MAINTENANCE_TEST_SETTINGS_FILENAME.
7447 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7449 * breakpoint.h (remove_breakpoints_inf): Change return type to
7450 void, move function documentation here.
7451 * breakpoint.c (remove_breakpoints_inf): Change return type to
7452 void, move function documentation to header.
7454 2019-07-02 Pedro Alves <palves@redhat.com>
7456 * NEWS (Completion improvements): Mention "info threads".
7457 * thread.c (struct info_threads_opts, info_threads_option_defs)
7458 (make_info_threads_options_def_group): New.
7459 (info_threads_command): Use gdb::option::process_options.
7460 (info_threads_command_completer): New.
7461 (_initialize_thread): Use gdb::option::build_help to build the
7462 help text for "info threads".
7464 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7466 * defs.h (generic_load): Move from here...
7467 * symfile.h (generic_load): ... to here. Rename name parameter
7469 * symfile.c (generic_load): Add comment.
7471 2019-07-01 Tom Tromey <tromey@adacore.com>
7474 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7475 declaration of without_params. Fix formatting.
7477 2019-07-01 Tom Tromey <tromey@adacore.com>
7479 * ada-exp.y (find_primitive_type): Update.
7480 * ada-lang.h (ada_lookup_symbol): Update.
7481 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7483 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7485 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7487 PR breakpoints/24541
7488 * gdbarch.c: Regenerate.
7489 * gdbarch.h: Regenerate.
7490 * gdbarch.sh: Add 'stap_adjust_register'.
7491 * i386-tdep.c: Include '<unordered_set>'.
7492 (i386_stap_adjust_register): New function.
7493 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7494 * stap-probe.c (stap_parse_register_operand): Call
7495 'gdbarch_stap_adjust_register'.
7497 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7500 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7501 * python/python.c (do_start_initialization): Use 'xmalloc'
7502 instead of 'PyMem_Malloc'.
7504 2019-06-28 Tom Tromey <tromey@adacore.com>
7506 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7509 2019-06-27 Tom Tromey <tromey@adacore.com>
7511 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7513 (arm_find_mapping_symbol, arm_record_special_symbol)
7514 (_initialize_arm_tdep): Update.
7515 (arm_objfile_data_free): Remove.
7517 2019-06-27 Tom Tromey <tromey@adacore.com>
7519 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7520 to cp_print_static_field.
7522 2019-06-26 Tom Tromey <tromey@adacore.com>
7524 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7525 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7528 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7530 * features/aarch64-core.c (create_feature_aarch64_core):
7532 * features/aarch64-core.xml: Add cpsr flags.
7534 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7536 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7537 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7539 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7541 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7543 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7545 (arm_record_special_symbol): Don't insert new symbol in sorted
7546 position, push it at the end.
7548 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7550 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7551 (arm_mapping_symbol_s): Remove.
7552 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7553 (arm_mapping_symbol_vec): New typedef.
7554 (struct arm_per_objfile): Add constructor.
7555 <section_maps>: Change type to
7556 std::unique_ptr<arm_mapping_symbol_vec[]>.
7557 (arm_compare_mapping_symbols): Remove.
7558 (arm_find_mapping_symbol): Adjust to section_maps type change.
7559 (arm_objfile_data_free): Call delete on arm_per_objfile.
7560 (arm_record_special_symbol): Adjust to section_maps type change.
7561 Allocate arm_per_objfile with new.
7563 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7565 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7566 with the command prefix.
7568 2019-06-25 Tom Tromey <tom@tromey.com>
7570 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7571 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7573 2019-06-25 Tom Tromey <tom@tromey.com>
7575 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7577 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7580 2019-06-25 Tom Tromey <tom@tromey.com>
7582 * tui/tui-winsource.c
7583 (tui_source_window_base::set_is_exec_point_at): Add check against
7586 2019-06-25 Tom Tromey <tom@tromey.com>
7588 * tui/tui-source.c (tui_set_source_content): Don't check before
7590 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7592 2019-06-25 Tom Tromey <tom@tromey.com>
7594 * tui/tui-winsource.h (tui_update_source_window_as_is)
7595 (tui_alloc_source_buffer, tui_line_is_displayed)
7596 (tui_addr_is_displayed): Change type of win_info.
7597 * tui/tui-winsource.c (tui_update_source_window_as_is)
7598 (tui_clear_source_content, tui_show_source_line)
7599 (tui_show_source_content, tui_source_window_base::refill)
7600 (tui_source_window_base::set_is_exec_point_at)
7601 (tui_source_window_base::set_is_exec_point_at)
7602 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7603 (tui_alloc_source_buffer, tui_line_is_displayed)
7604 (tui_addr_is_displayed): Change type of win_info. Update.
7605 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7606 (tui_source_window_base::do_make_visible_with_new_height):
7608 * tui/tui-source.c (tui_set_source_content)
7609 (tui_set_source_content_nil)
7610 (tui_source_window::do_scroll_vertical): Update.
7611 * tui/tui-layout.c (show_layout): Update.
7612 * tui/tui-disasm.c (tui_set_disassem_content)
7613 (tui_disasm_window::do_scroll_vertical): Update.
7614 * tui/tui-data.h (tui_win_content): Remove.
7615 (struct tui_gen_win_info) <content, content_size>: Remove.
7616 (struct tui_source_element): Add initializers and destructor.
7617 (union tui_which_element, struct tui_win_element): Remove.
7618 (struct tui_source_window_base) <content>: New field.
7619 (struct tui_data_window): Remove destructor.
7620 (tui_alloc_content, tui_free_win_content)
7621 (tui_free_all_source_wins_content): Don't declare.
7622 * tui/tui-data.c (tui_initialize_static_data): Update.
7623 (init_content_element, tui_alloc_content): Remove.
7624 (~tui_gen_win_info): Update.
7625 (~tui_data_window, tui_free_all_source_wins_content)
7626 (tui_free_win_content, free_content, free_content_elements):
7629 2019-06-25 Tom Tromey <tom@tromey.com>
7631 * tui/tui-winsource.h (tui_clear_source_content)
7632 (tui_erase_source_content, tui_show_source_content): Change type
7634 * tui/tui-winsource.c (tui_clear_source_content)
7635 (tui_erase_source_content, tui_show_source_content): Change type
7637 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7638 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7640 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7642 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7644 2019-06-25 Tom Tromey <tom@tromey.com>
7646 * tui/tui-winsource.c (tui_clear_source_content)
7647 (tui_source_window_base::set_is_exec_point_at): Update.
7648 * tui/tui-source.c (tui_set_source_content_nil): Update.
7649 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7651 * tui/tui-data.c (init_content_element): Update.
7653 2019-06-25 Tom Tromey <tom@tromey.com>
7655 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7656 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7657 * tui/tui-layout.c (init_and_make_win): Update.
7658 * tui/tui.h (enum tui_win_type): Update.
7659 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7660 tui_win_is_auxillary.
7661 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7662 tui_win_is_auxillary.
7664 2019-06-25 Tom Tromey <tom@tromey.com>
7666 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7667 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7668 (tui_delete_data_content_windows, tui_display_all_data)
7669 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7671 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7672 * tui/tui-regs.c (tui_last_regs_line_no)
7673 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7674 (tui_show_registers): Update.
7675 (tui_show_register_group): Return void. Update.
7676 (tui_display_registers_from, tui_display_reg_element_at_line)
7677 (tui_display_registers_from_line, tui_check_register_values):
7679 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7681 (struct tui_data_window) <regs_content>: Now a std::vector.
7682 <regs_content_count>: Remove.
7683 (tui_add_content_elements, tui_free_data_content): Don't declare.
7684 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7685 (init_content_element): Remove DATA_WIN case. Add assert.
7686 (tui_add_content_elements): Remove.
7687 (tui_data_window): Update.
7688 (tui_free_data_content): Remove.
7689 (free_content_elements): Remove DATA_WIN case.
7691 2019-06-25 Tom Tromey <tom@tromey.com>
7693 * tui/tui-data.c (tui_data_item_window): Update.
7694 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7695 * tui/tui-windata.c (tui_display_all_data)
7696 (tui_display_data_from_line): Update.
7697 (tui_check_data_values): Remove.
7698 * tui/tui-regs.c (tui_show_register_group)
7699 (tui_display_reg_element_at_line): Update.
7700 * tui/tui-hooks.c (tui_register_changed)
7701 (tui_refresh_frame_and_register_information): Call
7702 tui_check_register_values.
7703 * tui/tui-data.h (struct tui_data_window) <data_content,
7704 data_content_count, data_type>: Remove.
7705 (enum tui_data_type): Remove.
7707 * tui/tui-data.c (tui_data_window::clear_detail)
7708 (~tui_data_window): Update.
7710 2019-06-25 Tom Tromey <tom@tromey.com>
7712 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7714 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7715 Rename from tui_first_data_item_displayed. Update.
7716 (tui_data_window::refresh_all)
7717 (tui_data_window::do_scroll_vertical): Update.
7718 * tui/tui-data.h (struct tui_data_window)
7719 <first_data_item_displayed>: Declare new method.
7721 2019-06-25 Tom Tromey <tom@tromey.com>
7723 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7724 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7726 (tui_initialize_static_data): ...here.
7728 2019-06-25 Tom Tromey <tom@tromey.com>
7730 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7731 (tui_display_registers_from, tui_check_register_values): Update.
7732 (tui_display_register): Remove win_info parameter; update.
7733 (tui_get_register): Change type of parameters.
7734 * tui/tui-data.h (struct tui_data_element): Remove.
7735 (union tui_which_element) <data>: Remove.
7736 <data_window>: Change type.
7737 (struct tui_data_item_window): New.
7738 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7740 (~tui_data_item_window): New destructor.
7741 (free_content_elements): Remove DATA_ITEM_WIN case.
7743 2019-06-25 Tom Tromey <tom@tromey.com>
7745 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7748 2019-06-25 Tom Tromey <tom@tromey.com>
7750 * tui/tui-data.h (struct tui_command_element): Remove.
7751 (union tui_which_element) <command>: Remove.
7752 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7754 (free_content_elements): Remove CMD_WIN case.
7756 2019-06-25 Tom Tromey <tom@tromey.com>
7758 * tui/tui-layout.c (tui_set_layout): Update.
7759 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7760 * tui/tui-data.c (layout_def): Update.
7762 2019-06-25 Tom Tromey <tom@tromey.com>
7764 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7765 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7766 (tui_source_window_base::set_new_height): Update.
7767 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7769 (tui_set_locator_fullname, tui_set_locator_info)
7770 (tui_show_frame_info): Update.
7771 * tui/tui-source.c (tui_set_source_content)
7772 (tui_source_is_displayed): Update.
7773 * tui/tui-layout.c (show_source_disasm_command, show_data)
7774 (show_source_or_disasm_and_command): Update.
7775 * tui/tui-disasm.c (tui_set_disassem_content)
7776 (tui_get_begin_asm_address): Update.
7777 * tui/tui-data.h (struct tui_locator_element): Remove.
7778 (union tui_which_element) <locator>: Remove.
7779 (struct tui_locator_window): New.
7780 (tui_locator_win_info_ptr): Change return type.
7781 * tui/tui-data.c (_locator): Change type.
7782 (tui_locator_win_info_ptr): Change return type.
7783 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7784 (tui_alloc_content): Add assert.
7786 2019-06-25 Tom Tromey <tom@tromey.com>
7788 * tui/tui-winsource.c
7789 (tui_exec_info_window::maybe_allocate_content): New method.
7790 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7791 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7792 (make_source_or_disasm_window): Add cast.
7793 * tui/tui-data.h (union tui_which_element) <simple_string>:
7795 (struct tui_source_info): New.
7796 (struct tui_source_window_base) <execution_info>: Change type.
7797 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7798 case, and add assert.
7799 (tui_alloc_content): Add assert.
7801 2019-06-25 Tom Tromey <tom@tromey.com>
7803 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7804 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7805 * tui/tui-data.c (tui_alloc_win_info): Remove.
7807 2019-06-25 Tom Tromey <tom@tromey.com>
7809 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7810 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7813 2019-06-25 Tom Tromey <tom@tromey.com>
7815 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7816 make_visible_with_new_height method.
7817 (tui_win_info::make_visible_with_new_height): New method.
7818 (tui_source_window_base::do_make_visible_with_new_height)
7819 (tui_data_window::do_make_visible_with_new_height)
7820 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7821 (make_visible_with_new_height): Remove.
7822 (tui_resize_all, tui_adjust_win_heights): Use
7823 make_visible_with_new_height method.
7824 * tui/tui-data.h (struct tui_win_info)
7825 <do_make_visible_with_new_height, make_visible_with_new_height>:
7827 (struct tui_source_window_base, struct tui_data_window)
7828 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7831 2019-06-25 Tom Tromey <tom@tromey.com>
7833 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7835 (update_tab_width): Call update_tab_width method.
7836 * tui/tui-data.h (struct tui_win_info)
7837 (struct tui_source_window_base) <update_tab_width>: New methods.
7839 2019-06-25 Tom Tromey <tom@tromey.com>
7841 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7843 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7845 (tui_gen_win_info::make_visible): Update.
7846 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7848 * tui/tui-data.h (enum tui_box): New enum.
7849 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7851 2019-06-25 Tom Tromey <tom@tromey.com>
7853 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7854 init_and_make_win for EXEC_INFO_WIN.
7855 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7857 (struct tui_win_info) <~tui_win_info>: Inline.
7858 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7860 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7861 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7863 (tui_initialize_static_data): Update.
7864 (~tui_gen_win_info): Handle more cleanup here.
7865 (~tui_source_window_base): Delete "execution_info".
7866 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7868 2019-06-25 Tom Tromey <tom@tromey.com>
7870 * tui/tui-layout.c (make_command_window): Don't set
7872 (show_source_disasm_command): Call the reset method.
7873 (show_data): Don't set can_highlight. Call the reset method.
7874 (tui_gen_win_info::reset): Rename from init_gen_win_info
7875 (init_and_make_win): Simplify. Return tui_gen_win_info.
7876 (show_source_or_disasm_and_command): Call the reset method.
7877 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7878 (struct tui_cmd_window): Set can_highlight.
7880 2019-06-25 Tom Tromey <tom@tromey.com>
7882 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7884 (tui_make_visible, tui_make_invisible): Rewrite.
7885 (tui_win_info::make_visible): Remove.
7886 (tui_source_window_base::make_visible): Update.
7887 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7888 method. Moved from...
7889 (struct tui_win_info) <make_visible>: ...here.
7891 2019-06-25 Tom Tromey <tom@tromey.com>
7893 * tui/tui-winsource.c
7894 (tui_source_window_base::do_scroll_horizontal): Remove direction
7896 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7897 direction parameter.
7898 * tui/tui-win.c (tui_win_info::forward_scroll)
7899 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7900 (tui_win_info::right_scroll): Update.
7901 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7902 direction parameter.
7903 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7904 direction parameter.
7905 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7906 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7907 Remove direction parameter.
7908 (struct tui_source_window_base, struct tui_source_window)
7909 (struct tui_disasm_window, struct tui_data_window)
7910 (struct tui_cmd_window): Update.
7912 2019-06-25 Tom Tromey <tom@tromey.com>
7914 * tui/tui-winsource.h (tui_set_exec_info_content)
7915 (tui_show_exec_info_content, tui_erase_exec_info_content)
7916 (tui_clear_exec_info_content, tui_update_exec_info): Change
7917 argument to tui_source_window_base.
7918 * tui/tui-winsource.c (tui_set_exec_info_content)
7919 (tui_show_exec_info_content, tui_erase_exec_info_content)
7920 (tui_clear_exec_info_content, tui_update_exec_info): Change
7921 argument to tui_source_window_base.
7923 2019-06-25 Tom Tromey <tom@tromey.com>
7925 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7926 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7928 2019-06-25 Tom Tromey <tom@tromey.com>
7930 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7933 2019-06-25 Tom Tromey <tom@tromey.com>
7935 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7937 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7939 * tui/tui-source.c (tui_set_source_content): Update.
7940 * tui/tui-disasm.c (tui_set_disassem_content): Update.
7942 2019-06-25 Tom Tromey <tom@tromey.com>
7944 * tui/tui-win.c (window_name_completer, tui_set_focus)
7945 (tui_all_windows_info): Use name method.
7946 * tui/tui-data.h (struct tui_gen_win_info)
7947 (struct tui_source_window, struct tui_disasm_window)
7948 (struct tui_data_window, struct tui_cmd_window) <name>: New
7950 (tui_win_name): Don't declare.
7951 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7952 (tui_win_name): Remove.
7954 2019-06-25 Tom Tromey <tom@tromey.com>
7956 * tui/tui-winsource.h (tui_update_source_window)
7957 (tui_update_source_window_as_is): Change parameter type.
7958 * tui/tui-winsource.c (tui_update_source_window): Change win_info
7959 to be a tui_source_window_base.
7960 (tui_update_source_window_as_is): Likewise.
7961 * tui/tui-win.c (make_visible_with_new_height): Update.
7963 2019-06-25 Tom Tromey <tom@tromey.com>
7965 * tui/tui-winsource.c (tui_erase_source_content)
7966 (tui_show_source_content, tui_show_exec_info_content)
7967 (tui_erase_exec_info_content): Use refresh_window method.
7968 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7969 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7970 from tui_refresh_win.
7971 (tui_data_window::refresh_window): New method.
7972 (tui_win_info::refresh, tui_source_window_base::refresh)
7973 (tui_refresh_all): Use refresh_window method.
7974 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7976 * tui/tui-regs.c (tui_display_register): Call refresh_window
7978 * tui/tui-layout.c (show_source_disasm_command)
7979 (show_source_or_disasm_and_command): Call refresh_window method.
7980 * tui/tui-data.h (struct tui_gen_win_info)
7981 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7984 2019-06-25 Tom Tromey <tom@tromey.com>
7986 * tui/tui.c (tui_rl_other_window, tui_enable)
7987 (tui_is_window_visible, tui_get_command_dimension): Update.
7988 * tui/tui-winsource.c (tui_update_source_window_as_is)
7989 (tui_clear_source_content, tui_erase_source_content)
7990 (tui_show_source_line, tui_source_window_base::refill)
7991 (tui_source_window_base::do_scroll_horizontal)
7992 (tui_source_window_base::set_is_exec_point_at)
7993 (tui_update_breakpoint_info, tui_set_exec_info_content)
7994 (tui_alloc_source_buffer, tui_line_is_displayed)
7995 (tui_addr_is_displayed): Update.
7996 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7997 (tui_check_and_display_highlight_if_needed)
7998 (tui_win_info::make_visible, tui_win_info::refresh)
7999 (tui_refresh_all): Update.
8000 * tui/tui-windata.c (tui_first_data_item_displayed)
8001 (tui_delete_data_content_windows, tui_erase_data_content)
8002 (tui_display_all_data, tui_data_window::refresh_all)
8003 (tui_check_data_values): Update.
8004 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8005 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8006 (tui_win_info::backward_scroll, tui_refresh_all_win)
8007 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8008 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8009 (tui_source_window_base::set_new_height)
8010 (tui_data_window::set_new_height)
8011 (make_invisible_and_set_new_height)
8012 (make_visible_with_new_height, new_height_ok)
8013 (parse_scrolling_args): Update.
8014 * tui/tui-stack.c (tui_show_frame_info): Update.
8015 * tui/tui-source.c (tui_set_source_content)
8016 (tui_set_source_content_nil, tui_source_is_displayed)
8017 (tui_source_window::do_scroll_vertical): Update.
8018 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8019 (tui_display_registers_from, tui_display_reg_element_at_line)
8020 (tui_check_register_values, tui_reg_command): Update.
8021 * tui/tui-layout.c (tui_default_win_height)
8022 (show_source_disasm_command, show_data, init_and_make_win)
8023 (show_source_or_disasm_and_command): Update.
8024 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8025 (tui_redisplay_readline, tui_mld_flush)
8026 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8028 * tui/tui-disasm.c (tui_set_disassem_content)
8029 (tui_disasm_window::do_scroll_vertical): Update.
8030 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8032 (struct tui_win_info): Derive from tui_gen_win_info.
8033 <~tui_win_info>: Mark as override.
8034 <generic>: Remove member.
8035 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8036 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8037 (~tui_data_window, ~tui_win_info)
8038 (tui_free_all_source_wins_content): Update.
8039 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8041 2019-06-25 Tom Tromey <tom@tromey.com>
8043 * tui/tui-layout.c (init_and_make_win): Use new.
8044 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8045 destructor, initializers.
8046 (tui_alloc_generic_win_info): Don't declare.
8047 * tui/tui-data.c (_locator): Add argument to constructor.
8048 (source_win, disasm_win): New globals.
8049 (exec_info): Remove.
8050 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8052 (tui_alloc_generic_win_info): Remove.
8053 (init_content_element): Use new.
8054 (tui_win_info::tui_win_info): Update.
8055 (free_content_elements) <case DATA_WIN>: Use delete.
8057 2019-06-25 Tom Tromey <tom@tromey.com>
8059 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8060 * tui/tui-windata.c (tui_first_data_item_displayed)
8061 (tui_delete_data_content_windows): Update.
8062 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8063 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8064 (tui_display_registers_from, tui_check_register_values): Update.
8065 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8067 * tui/tui-data.c (init_content_element): Update. Allocate the new
8069 (tui_free_data_content): Update.
8070 (free_content_elements) <case DATA_WIN>: Free the window.
8072 2019-06-25 Tom Tromey <tom@tromey.com>
8074 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8076 * tui/tui-layout.c (make_command_window)
8077 (show_source_disasm_command, show_data, init_and_make_win)
8078 (show_source_or_disasm_and_command): Update.
8079 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8081 <can_highight, is_highlighted>: Now bool.
8082 (tui_set_win_highlight): Don't declare.
8083 * tui/tui-data.c (tui_set_win_highlight): Remove.
8085 2019-06-25 Tom Tromey <tom@tromey.com>
8087 * tui/tui-wingeneral.c (make_visible): Remove check of window
8090 2019-06-25 Tom Tromey <tom@tromey.com>
8092 * tui/tui-win.c (tui_win_info::max_height)
8093 (tui_cmd_window::max_height): New methods.
8094 (new_height_ok): Call max_height.
8095 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8096 <max_height>: New method.
8098 2019-06-25 Tom Tromey <tom@tromey.com>
8100 * tui/tui-win.c (tui_source_window_base::set_new_height)
8101 (tui_data_window::set_new_height): New methods.
8102 (make_invisible_and_set_new_height): Call set_new_height method.
8103 * tui/tui-data.h (struct tui_win_info)
8104 (struct tui_source_window_base, struct tui_data_window)
8105 <set_new_height>: New method.
8107 2019-06-25 Tom Tromey <tom@tromey.com>
8109 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8110 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8111 tui_refresh_data_win.
8112 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8114 (tui_refresh_all_win): Call the refresh_all method.
8115 (tui_set_focus): Likewise.
8116 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8117 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8120 2019-06-25 Tom Tromey <tom@tromey.com>
8122 * tui/tui-winsource.h (tui_refill_source_window)
8123 (tui_set_is_exec_point_at): Don't declare.
8124 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8125 (tui_source_window_base::refill): Rename from
8126 tui_refill_source_window.
8127 (tui_source_window_base::do_scroll_horizontal): Update.
8128 (tui_source_window_base::set_is_exec_point_at): Rename from
8129 tui_set_is_exec_point_at.
8130 (tui_update_all_breakpoint_info): Update.
8131 * tui/tui-stack.c (tui_show_frame_info): Update.
8132 * tui/tui-layout.c (show_data): Add cast.
8133 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8134 * tui/tui-data.h (struct tui_source_window_base) <refill,
8135 set_is_exec_point_at>: New methods.
8136 (tui_source_windows, tui_add_to_source_windows): Update types.
8137 (tui_add_to_source_windows): Remove redundant declaration.
8138 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8139 (tui_source_windows): Change return type.
8140 (tui_clear_source_windows_detail): Update.
8141 (tui_add_to_source_windows): Change type of parameter.
8142 (tui_free_all_source_wins_content): Update.
8144 2019-06-25 Tom Tromey <tom@tromey.com>
8146 * tui/tui-wingeneral.c (tui_win_info::refresh)
8147 (tui_source_window_base::refresh): New methods.
8148 (tui_refresh_all): Call the refresh method.
8149 * tui/tui-data.h (struct tui_win_info)
8150 (struct tui_source_window_base) <refresh>: New method.
8152 2019-06-25 Tom Tromey <tom@tromey.com>
8154 * tui/tui.h (tui_is_window_visible): Return bool.
8155 * tui/tui.c (tui_is_window_visible): Return bool.
8156 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8157 (tui_make_visible, tui_make_invisible)
8158 (tui_win_info::make_visible)
8159 (tui_source_window_base::make_visible, make_all_visible)
8160 (tui_make_all_visible, tui_make_all_invisible): Update.
8161 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8162 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8164 (struct tui_win_info, struct tui_source_window_base)
8165 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8166 * tui/tui-data.c (tui_init_generic_part): Update.
8168 2019-06-25 Tom Tromey <tom@tromey.com>
8170 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8171 (tui_source_window_base::make_visible): New methods.
8172 (make_all_visible): Make method call.
8173 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8174 (struct tui_source_window_base, struct tui_cmd_window): Override
8176 (tui_win_is_source_type): Don't declare.
8177 * tui/tui-data.c (tui_win_is_source_type): Remove.
8179 2019-06-25 Tom Tromey <tom@tromey.com>
8181 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8184 2019-06-25 Tom Tromey <tom@tromey.com>
8186 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8187 Inline constructor. Add initializers for members.
8188 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8189 constructors; now inline in class.
8191 2019-06-25 Tom Tromey <tom@tromey.com>
8193 * tui/tui-regs.c (tui_show_registers): Update.
8194 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8196 * tui/tui-data.c (tui_data_window::clear_detail)
8197 (tui_data_window): Update.
8199 2019-06-25 Tom Tromey <tom@tromey.com>
8201 * tui/tui-windata.c (tui_display_all_data)
8202 (tui_display_data_from_line, tui_display_data_from)
8203 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8205 * tui/tui-regs.c (tui_last_regs_line_no)
8206 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8207 (tui_show_registers, tui_show_register_group)
8208 (tui_display_registers_from, tui_display_reg_element_at_line)
8209 (tui_display_registers_from_line, tui_check_register_values)
8210 (tui_reg_next, tui_reg_prev): Update.
8211 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8212 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8214 (struct tui_win_info) <detail>: Remove. Add new fields from
8216 (TUI_DATA_WIN): Add cast.
8217 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8218 (~tui_data_window): Simplify.
8220 2019-06-25 Tom Tromey <tom@tromey.com>
8222 * tui/tui-layout.c (show_source_disasm_command)
8223 (show_source_or_disasm_and_command): Update.
8224 * tui/tui-io.c (update_cmdwin_start_line)
8225 (tui_redisplay_readline): Update.
8226 * tui/tui-data.h (struct tui_command_info): Remove.
8227 (struct tui_win_info) <detail>: Remove command_info member.
8228 (struct tui_data_window) <start_line>: New member, from
8230 (TUI_CMD_WIN): Add casts.
8232 2019-06-25 Tom Tromey <tom@tromey.com>
8234 * tui/tui-winsource.c (tui_update_source_window)
8235 (tui_refill_source_window)
8236 (tui_source_window_base::do_scroll_horizontal)
8237 (tui_update_breakpoint_info, tui_set_exec_info_content)
8238 (tui_show_exec_info_content, tui_erase_exec_info_content)
8239 (tui_clear_exec_info_content): Update.
8240 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8242 * tui/tui-win.c (make_invisible_and_set_new_height)
8243 (make_visible_with_new_height): Update.
8244 * tui/tui-source.c (tui_set_source_content)
8245 (tui_show_symtab_source): Update.
8246 * tui/tui-layout.c (extract_display_start_addr)
8247 (show_source_disasm_command, show_data)
8248 (make_source_or_disasm_window)
8249 (show_source_or_disasm_and_command): Update.
8250 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8251 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8253 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8254 to tui_source_window_base.
8255 (struct tui_win_info) <detail>: Remove source_info member.
8256 (struct tui_source_window_base) <has_locator>: Inline.
8257 Move contents from tui_source_info; rename has_locator member to
8259 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8260 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8262 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8264 (tui_free_all_source_wins_content): Cast to
8265 tui_source_window_base.
8267 2019-06-25 Tom Tromey <tom@tromey.com>
8269 * tui/tui-win.c (make_invisible_and_set_new_height)
8270 (make_visible_with_new_height): Call has_locator method.
8271 * tui/tui-layout.c (show_source_disasm_command, show_data)
8272 (show_source_or_disasm_and_command): Update for bool change.
8273 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8274 (tui_win_info) <has_locator>: New method.
8275 (struct tui_source_window_base) <has_locator>: New method.
8276 (tui_win_has_locator): Don't declare.
8277 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8278 from tui_win_has_locator.
8279 (tui_source_window_base): Use false, not FALSE.
8281 2019-06-25 Tom Tromey <tom@tromey.com>
8283 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8284 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8285 clear_detail method directly.
8286 (tui_clear_win_detail): Remove.
8288 2019-06-25 Tom Tromey <tom@tromey.com>
8290 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8291 "this", not TUI_DISASM_WIN.
8293 2019-06-25 Tom Tromey <tom@tromey.com>
8295 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8297 * tui/tui-winsource.c
8298 (tui_source_window_base::do_scroll_horizontal): Rename from
8299 tui_horizontal_source_scroll.
8300 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8301 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8302 from tui_vertical_data_scroll.
8303 * tui/tui-win.h (tui_scroll): Don't declare.
8304 * tui/tui-win.c (tui_win_info::forward_scroll)
8305 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8306 (tui_win_info::right_scroll): Rename and update.
8307 (tui_scroll_forward_command, tui_scroll_backward_command)
8308 (tui_scroll_left_command, tui_scroll_right_command): Update.
8309 (tui_scroll): Remove.
8310 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8311 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8312 from tui_vertical_source_scroll.
8313 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8314 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8315 from tui_vertical_disassem_scroll.
8316 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8317 do_scroll_horizontal>: New methods.
8318 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8320 (struct tui_source_window_base): Add do_scroll_horizontal.
8321 (struct tui_source_window, struct tui_disasm_window): Add
8323 (struct tui_data_window, struct tui_cmd_window): Add
8324 do_scroll_horizontal and do_scroll_vertical.
8325 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8327 2019-06-25 Tom Tromey <tom@tromey.com>
8329 * tui/tui-data.h (struct tui_source_window_base): New struct.
8330 (struct tui_source_window): Derive from tui_source_window_base.
8331 (struct tui_disasm_window): New struct.
8332 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8333 from tui_source_window::clear_detail.
8334 (tui_source_window_base): Rename from tui_source_window.
8335 (~tui_source_window_base): Rename from ~tui_source_window.
8336 (tui_alloc_win_info): Create a tui_disasm_window.
8338 2019-06-25 Tom Tromey <tom@tromey.com>
8340 * tui/tui-data.h (struct tui_source_window)
8341 (struct tui_data_window): Declare destructors.
8342 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8344 (tui_win_info): Simplify.
8346 2019-06-25 Tom Tromey <tom@tromey.com>
8348 * tui/tui-winsource.c (tui_display_main)
8349 (tui_update_source_windows_with_addr)
8350 (tui_update_all_breakpoint_info): Update.
8351 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8352 (new_height_ok, parse_scrolling_args): Update.
8353 * tui/tui-stack.c (tui_show_frame_info): Update.
8354 * tui/tui-data.h (struct tui_list): Remove.
8355 (tui_source_windows): Return a reference to a std::vector.
8356 * tui/tui-data.c (source_windows): Now a std::vector.
8357 (tui_source_windows): Change return type.
8358 (tui_clear_source_windows): Rewrite.
8359 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8360 (tui_free_all_source_wins_content): Rewrite.
8362 2019-06-25 Tom Tromey <tom@tromey.com>
8364 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8365 (struct tui_data_window, struct tui_cmd_window): Declare
8366 clear_detail method.
8367 * tui/tui-data.c (tui_source_window::clear_detail)
8368 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8370 (tui_clear_win_detail): Simplify.
8372 2019-06-25 Tom Tromey <tom@tromey.com>
8374 * tui/tui-layout.c (make_source_window, make_disasm_window)
8375 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8376 Return the new window.
8377 (show_source_disasm_command, show_data)
8378 (show_source_or_disasm_and_command): Update.
8380 2019-06-25 Tom Tromey <tom@tromey.com>
8382 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8383 parameter. Return the new window.
8384 (show_source_disasm_command): Update and remove NULL check.
8385 (show_source_or_disasm_and_command): Update.
8387 2019-06-25 Tom Tromey <tom@tromey.com>
8389 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8391 2019-06-25 Tom Tromey <tom@tromey.com>
8393 * tui/tui-data.h (struct tui_win_info): Make constructor
8394 protected. Make destructor virtual. Add initializers.
8395 (tui_source_window, tui_data_window, tui_cmd_window): New
8397 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8398 constructor. Add "type" parameter.
8399 (tui_source_window, tui_data_window, tui_cmd_window): New
8401 (tui_alloc_win_info): Instantiate the appropriate subclass.
8403 2019-06-25 Tom Tromey <tom@tromey.com>
8405 * tui/tui-win.c (tui_resize_all): Use delete.
8406 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8408 (tui_free_window): Don't declare.
8409 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8412 2019-06-25 Tom Tromey <tom@tromey.com>
8414 * tui/tui-data.h (struct tui_win_info): Add constructor.
8415 * tui/tui-data.c (tui_alloc_win_info): Use new.
8416 (tui_free_window): Use delete.
8418 2019-06-22 Tom Tromey <tom@tromey.com>
8420 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8422 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8424 2019-06-22 Tom Tromey <tom@tromey.com>
8426 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8428 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8430 2019-06-22 Tom de Vries <tdevries@suse.de>
8432 * dwarf2read.c (create_addrmap_from_aranges)
8433 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8436 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8438 * dwarf2read.h (dwarf2_section_info_def): Remove.
8439 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8440 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8441 std::vector<dwarf2_section_info>.
8442 (struct dwo_file) <~dwo_file>: Remove.
8443 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8445 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8446 (dwarf2_read_debug_names): Likewise.
8447 (create_debug_types_hash_table): Change parameter type to
8448 array_view, adjust code accordingly.
8449 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8450 (partial_die_info::fixup): Likewise.
8451 (determine_prefix): Likewise.
8452 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8454 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8456 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8458 <~dwo_file>: Remove call to gdb_bfd_unref.
8459 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8460 gdb_bfd_ref_ptr::get.
8462 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8464 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8466 * dwarf2read.c (struct dwo_file): Initialize fields.
8468 (free_dwo_file): Remove, move content to ~dwo_file.
8469 (struct dwo_file_deleter): Remove.
8470 (dwo_file_up>: Remove custom deleter.
8471 (free_dwo_files): Remove.
8472 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8474 (process_skeletonless_type_units): Call unique_ptr::get.
8475 (allocate_dwo_file_hash_table): Add deleter to created hash
8476 table. Change return type to htab_up.
8477 (lookup_dwo_file_slot): Don't memset dwo_file, call
8479 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8480 (create_dwo_unit_in_dwp_v2): Likewise.
8481 (open_and_init_dwo_file): Likewise.
8482 (free_dwo_file_from_slot): Remove.
8484 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8486 * dwarf2read.h (struct dwarf2_section_info) <readin,
8487 is_virtual>: Change type to bool.
8488 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8491 2019-06-19 Tom Tromey <tom@tromey.com>
8493 * tui/tui-data.h (tui_init_content_element): Don't declare.
8495 2019-06-19 Tom Tromey <tom@tromey.com>
8497 * tui/tui-data.h (tui_init_win_info): Don't declare.
8499 2019-06-19 Tom de Vries <tdevries@suse.de>
8501 * dwarf2read.h (abstract_to_concrete): Change type to
8502 std::unordered_map<sect_offset, std::vector<sect_offset>,
8503 gdb::hash_enum<sect_offset>>.
8505 2019-06-19 Tom Tromey <tromey@adacore.com>
8507 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8508 EVAL_AVOID_SIDE_EFFECTS specially.
8510 2019-06-19 Tom Tromey <tromey@adacore.com>
8512 * source-cache.c (highlighter): New global.
8513 (source_cache::get_source_lines): Create a highlighter on demand.
8515 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8517 * defs.h (deprecated_interactive_hook): Delete declaration.
8518 * interps.c (clear_interpreter_hooks): Remove use of
8519 deprecated_interactive_hook.
8520 * top.c (deprecated_interactive_hook): Delete definition.
8521 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8523 2019-06-18 Tom de Vries <tdevries@suse.de>
8526 * dwarf2read.h (abstract_to_concrete): Change type from
8527 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8528 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8529 * dwarf2read.c (read_variable): Update.
8530 (dwarf2_fetch_die_loc_sect_off): Update.
8532 2019-06-17 Tom de Vries <tdevries@suse.de>
8535 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8536 accessing parent[parent_len - 1].
8538 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8541 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8542 call dtrace_process_dof with NULL dof.
8544 2019-06-16 Tom de Vries <tdevries@suse.de>
8547 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8549 2019-06-16 Tom Tromey <tom@tromey.com>
8551 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8552 (make_all_visible): Use address of member.
8554 2019-06-16 Tom Tromey <tom@tromey.com>
8556 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8557 (tui_free_window, free_content, free_content_elements): Remove
8559 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8561 * tui/tui-regs.c (tui_show_register_group)
8562 (tui_display_registers_from, tui_display_reg_element_at_line):
8563 Remove unnecessary cast.
8565 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8567 * linux-nat.c (normal_mask): Delete.
8568 (_initialize_linux_nat): Don't initialise normal_mask.
8570 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8573 * dwarf-index-write.h (write_psymtabs_to_index): Add
8574 dwz_basename parameter.
8575 * dwarf-index-write.c (write_gdbindex): Move file writing to
8576 write_gdbindex_1. Change return type void.
8577 (assert_file_size): Move up, remove filename parameter.
8578 (write_gdbindex_1): New function.
8579 (write_debug_names): Change return type to void, call
8581 (struct index_wip_file): New struct.
8582 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8583 file logic to index_wip_file. Write index for dwz file if
8585 (save_gdb_index_command): Pass basename of dwz file, if present.
8586 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8587 build-id of dwz file, if present.
8588 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8589 (dwarf2_get_dwz_file): Likewise.
8590 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8591 (dwarf2_get_dwz_file): Likewise.
8593 2019-06-16 Tom Tromey <tom@tromey.com>
8595 * coffread.c (process_coff_symbol): Use xstrdup.
8596 * value.c (create_internalvar): Use xstrdup.
8598 2019-06-16 Tom Tromey <tom@tromey.com>
8600 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8601 * breakpoint.c (stopin_command, stopat_command)
8602 (until_break_command, decode_location_default): Remove unnecessary
8604 * utils.c (subset_compare): Remove unnecessary cast.
8605 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8607 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8609 * infcmd.c (path_command): Remove unnecessary cast.
8610 * coffread.c (decode_type): Remove unnecessary cast.
8611 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8612 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8613 * tui/tui-stack.c (tui_show_locator_content)
8614 (tui_show_frame_info): Remove unnecessary cast.
8615 * tui/tui-win.c (tui_scroll_forward_command)
8616 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8617 (parse_scrolling_args): Remove unnecessary cast.
8618 * tui/tui-data.c (init_win_info, tui_del_window)
8619 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8620 (free_content_elements): Remove unnecessary cast.
8621 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8623 * tui/tui-source.c (tui_set_source_content)
8624 (tui_vertical_source_scroll): Remove unnecessary cast.
8625 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8627 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8628 * tui/tui-regs.c (tui_display_registers_from)
8629 (tui_display_register): Remove unnecessary cast.
8630 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8631 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8632 (make_visible): Remove unnecessary cast.
8633 * tui/tui-winsource.c (tui_erase_source_content)
8634 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8636 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8637 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8638 * stabsread.c (read_type, read_array_type, read_range_type):
8639 Remove unnecessary cast.
8640 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8641 (parse_symbol, parse_type, upgrade_type, parse_external)
8642 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8644 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8646 2019-06-16 Tom Tromey <tom@tromey.com>
8648 * tui/tui-data.c (tui_alloc_generic_win_info)
8649 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8652 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8653 Andrew Burgess <andrew.burgess@embecosm.com>
8655 * f-typeprint.c (f_print_type): Don't return early for not
8656 associated or not allocated types.
8657 (f_type_print_varspec_suffix): Add print_rank parameter and print
8658 ranks of array types in case they dangling.
8659 (f_type_print_base): Add print_rank parameter.
8661 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8663 * NEWS: Mention new MI commands.
8664 * break-catch-throw.c (enum exception_event_kind): Move to
8666 (print_mention_exception_catchpoint): Output text as a single
8668 (catch_exception_command_1): Rename to...
8669 (catch_exception_event): ...this, make non-static, update header
8670 command, and change some parameter types.
8671 (catch_catch_command): Update for changes to
8672 catch_exception_command_1.
8673 (catch_throw_command): Likewise.
8674 (catch_rethrow_command): Likewise.
8675 * breakpoint.c (enum exception_event_kind): Delete.
8676 * breakpoint.h (enum exception_event_kind): Moved here from
8677 break-catch-throw.c.
8678 (catch_exception_event): Declare.
8679 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8680 (mi_cmd_catch_throw): New function.
8681 (mi_cmd_catch_rethrow): New function.
8682 (mi_cmd_catch_catch): New function.
8683 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8684 'catch-catch' entries.
8685 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8686 (mi_cmd_catch_rethrow): Declare.
8687 (mi_cmd_catch_catch): Declare.
8689 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8691 * annotate.c (annotate_source_line): Change return type to void,
8692 update implementation to match.
8693 * annotate.h (annotate_source_line): Change return type to void,
8694 update header comment.
8695 * stack.c (print_frame_info): Don't change what frame information
8696 is printed based on whether annotations are on or not.
8698 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8700 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8701 (annotate_source): Make static.
8702 (annotate_source_line): Moved from source.c and renamed from
8703 identify_source_line. Update the return type.
8704 * annotate.h (annotate_source): Delete declaration.
8705 (annotate_source_line): Declaration moved from source.h, and
8706 renamed from identify_source_line. Return type updated.
8707 * source.c (identify_source_line): Moved to annotate.c and renamed
8708 to annotate_source_line.
8709 (info_line_command): Remove check of annotation_level.
8710 * source.h (identify_source_line): Move declaration to annotate.h
8711 and rename to annotate_source_line.
8712 * stack.c: Add 'annotate.h' include.
8713 (print_frame_info): Remove check of annotation_level before
8714 calling annotate_source_line.
8716 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8718 * source-cache.c (source_cache::get_plain_source_lines): Use
8719 open_source_file_with_line_charpos instead of just
8720 open_source_file, remove call to find_source_lines.
8721 (source_cache::get_source_lines): Likewise.
8722 * source.c (find_source_lines): Make static.
8723 (get_filename_and_charpos): Renamed into...
8724 (open_source_file_with_line_charpos): ..this along with changes to
8725 return a scoped_fd, and some other minor clean ups.
8726 (identify_source_line): Use open_source_file_with_line_charpos.
8727 (search_command_helper): Use open_source_file_with_line_charpos
8728 instead of just open_source_file, remove call to
8730 * source.h (open_source_file_with_line_charpos): Declare new
8732 (find_source_lines): Delete declaration.
8734 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8736 * source.c (get_filename_and_charpos): Remove fullname
8738 (identify_source_line): Update call to get_filename_and_charpos.
8740 2019-06-14 Tom Tromey <tromey@adacore.com>
8743 * ui-style.h (skip_ansi_escape): Update comment.
8744 * ui-file.h (class no_terminal_escape_file): New class.
8745 * ui-file.c (no_terminal_escape_file::write)
8746 (no_terminal_escape_file::puts): New methods.
8747 * cli/cli-logging.c (handle_redirections): Use
8748 no_terminal_escape_file.
8750 2019-06-14 Tom Tromey <tromey@adacore.com>
8752 * NEWS: Move convenience variable news above Python news.
8754 2019-06-14 Tom Tromey <tom@tromey.com>
8756 * gnulib: Move directory to top-level.
8757 * configure.ac: Don't configure gnulib.
8758 * configure: Rebuild.
8759 * common/common-defs.h: Use new path to gnulib.
8760 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8762 (INCGNU): Look in new gnulib location.
8763 (HFILES_NO_SRCDIR): Remove gnulib files.
8764 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8765 (generated_files): Remove GNULIB_H.
8766 ($(LIBGNU), all-lib): Remove targets.
8767 (distclean): Don't mention GNULIB_BUILDDIR.
8768 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8770 2019-06-14 Tom Tromey <tromey@adacore.com>
8772 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8773 Warn if symbol file does not provide any symbols.
8775 2019-06-14 Tom Tromey <tromey@adacore.com>
8777 * source.c (find_and_open_source): Respect basenames_may_differ.
8779 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8781 * annotate.c (annotate_breakpoints_invalid): Make use of
8782 scoped_restore_terminal_state.
8783 (annotate_frames_invalid): Likewise.
8785 2019-06-14 Tom Tromey <tromey@adacore.com>
8787 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8788 allow assignment to an internalvar.
8790 2019-06-14 Tom Tromey <tromey@adacore.com>
8792 * ada-lex.l: Allow "_" in attribute names.
8794 2019-06-14 Tom Tromey <tromey@adacore.com>
8797 * regcache.c (registers_changed): Don't call alloca.
8798 * top.c (execute_command): Don't call alloca.
8800 2019-06-13 Pedro Alves <palves@redhat.com>
8802 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8803 'expression'. When parsing an expression, error out if there's
8804 junk after "unlimited".
8805 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8806 (do_set_command): Adjust calls to is_unlimited_literal.
8808 2019-06-13 Pedro Alves <palves@redhat.com>
8810 * compile/compile.c (make_compile_options_def_group): Add braces
8811 around array_view initializer.
8812 * thread.c (make_thread_apply_all_options_def_group)
8813 (make_thread_apply_all_options_def_group): Likewise.
8815 2019-06-13 Pedro Alves <palves@redhat.com>
8817 * NEWS (New commands): Mention "maint test-options
8818 require-delimiter", "maint test-options unknown-is-error", "maint
8819 test-options unknown-is-operand" and "maint show
8820 test-options-completion-result".
8821 (New command options, command completion): New section.
8822 (Completion improvements): New section.
8823 Mention that you can abbreviate "unlimited".
8825 2019-06-13 Pedro Alves <palves@redhat.com>
8827 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8828 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8829 * unittests/cli-utils-selftests.c (test_parse_flags)
8830 (test_parse_flags_qcs): Delete.
8831 (test_cli_utils): Don't call deleted functions.
8833 2019-06-13 Pedro Alves <palves@redhat.com>
8835 * thread.c: Include "cli/cli-option.h".
8836 (tp_array_compar_ascending): Global.
8837 (tp_array_compar): Delete function.
8838 (tp_array_compar_ascending, tp_array_compar_descending): New
8840 (ascending_option_def, qcs_flag_option_def)
8841 (thr_qcs_flags_option_defs)
8842 (make_thread_apply_all_options_def_group)
8843 (make_thread_apply_options_def_group): New.
8844 (thread_apply_all_command): Use gdb::option::process_options.
8845 (thread_apply_command_completer)
8846 (thread_apply_all_command_completer): New.
8847 (thread_apply_command): Use gdb::option::process_options.
8848 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8849 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8850 to generate help text of "thread apply". Adjust "taas"'s help.
8851 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8852 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8854 2019-06-13 Pedro Alves <palves@redhat.com>
8856 * thread.c (thread_apply_command): Check for invalid TID with
8857 isdigit instead of !isalpha.
8859 2019-06-13 Pedro Alves <palves@redhat.com>
8861 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8862 (validate_flags_qcs): New.
8863 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8864 (validate_flags_qcs): Declare.
8865 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8866 (make_frame_apply_options_def_group): New.
8867 (frame_apply_command_count): Process options with
8868 gdb::option::process_options.
8869 (frame_apply_completer): New.
8870 (frame_apply_level_completer, frame_apply_all_completer)
8871 (frame_apply_completer): New.
8872 (_initialize_stack): Update help of "frame apply", "frame apply
8873 level", "frame apply all" and "faas" to mention supported options
8874 and install command completers.
8875 * stack.h (frame_apply_all_completer): Declare.
8876 * thread.c: Include "stack.h".
8877 (tfaas_command): Add "--".
8878 (_initialize_thread): Update help "tfaas" to mention supported
8879 options and install command completer.
8881 2019-06-13 Pedro Alves <palves@redhat.com>
8883 * completer.c (complete_nested_command_line): New.
8884 (gdb_completion_word_break_characters_throw): Add assertion.
8885 * completer.h (complete_nested_command_line): Declare.
8887 2019-06-13 Pedro Alves <palves@redhat.com>
8889 * stack.c (parse_backtrace_qualifiers): New.
8890 (backtrace_command): Use it.
8891 (backtrace_command_completer): Complete on qualifiers.
8893 2019-06-13 Pedro Alves <palves@redhat.com>
8895 * frame.c: Include "cli/cli-option.h.
8896 (user_set_backtrace_options): New.
8897 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8899 (get_prev_frame): Adjust.
8900 (boolean_option_def, uinteger_option_def)
8901 (set_backtrace_option_defs): New.
8902 (_initialize_frame): Adjust and use
8903 gdb::option::add_setshow_cmds_for_options to install "set
8904 backtrace past-main" and "set backtrace past-entry".
8905 * frame.h: Include "cli/cli-option.h".
8906 (struct frame_print_options): Forward declare.
8907 (print_frame_arguments_all, print_frame_arguments_scalars)
8908 (print_frame_arguments_none): Declare.
8909 (print_entry_values): Delete declaration.
8910 (struct frame_print_options, user_frame_print_options): New.
8911 (struct set_backtrace_options): New.
8912 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8913 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8914 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8915 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8916 (list_args_or_locals): Add frame_print_options parameter.
8917 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8918 * python/py-framefilter.c (enumerate_args): Pass down
8919 USER_FRAME_PRINT_OPTIONS.
8920 * stack.c: Include "cli/cli-option.h".
8921 (print_frame_arguments_all, print_frame_arguments_scalars)
8922 (print_frame_arguments_none): Declare.
8923 (print_raw_frame_arguments, print_entry_values): Delete.
8924 (user_frame_print_options): New.
8925 (boolean_option_def, enum_option_def, frame_print_option_defs):
8927 (struct backtrace_cmd_options): New.
8928 (bt_flag_option_def): New.
8929 (backtrace_command_option_defs): New.
8930 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8931 (print_frame_arg, read_frame_arg, print_frame_args)
8932 (print_frame_info, print_frame): Add frame_print_options parameter
8934 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8935 (backtrace_command_1): Add frame_print_options and
8936 backtrace_cmd_options parameters and use them.
8937 (make_backtrace_options_def_group): New.
8938 (backtrace_command): Process command options with
8939 gdb::option::process_options.
8940 (backtrace_command_completer): New.
8941 (_initialize_stack): Extend "backtrace"'s help to mention
8942 supported options. Install completer for "backtrace".
8943 Install some settings commands with add_setshow_cmds_for_options.
8945 2019-06-13 Pedro Alves <palves@redhat.com>
8947 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8948 and that "set/show print raw frame-arguments" are now deprecated.
8950 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8952 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8953 * stack.c (_initialize_stack): Install "set/show print
8954 raw-frame-arguments", and deprecate "set/show print raw
8956 * valprint.c (_initialize_valprint): Deprecate "set/show print
8959 2019-06-13 Pedro Alves <palves@redhat.com>
8961 * compile/compile.c (struct compile_options): New.
8962 (compile_flag_option_def, compile_command_option_defs)
8963 (make_compile_options_def_group): New.
8964 (compile_file_command): Handle options with
8965 gdb::option::process_options.
8966 (compile_file_command_completer): New function.
8967 (compile_code_command): Handle options with
8968 gdb::option::process_options.
8969 (compile_code_command_completer): New function.
8970 (_initialize_compiler): Install completers for "compile code" and
8971 "compile file". Mention available options in "compile code" and
8972 "compile code"'s help.
8973 * completer.c (advance_to_completion_word): New, factored out from
8975 (advance_to_expression_complete_word_point): ... this.
8976 (advance_to_filename_complete_word_point): New.
8977 * completer.h (advance_to_filename_complete_word_point): New
8980 2019-06-13 Pedro Alves <palves@redhat.com>
8982 * compile/compile.c: Include "cli/cli-option.h".
8983 (compile_print_value): Scope data pointer is now a
8984 value_print_options pointer; adjust.
8985 (compile_print_command): Process options. Scope data pointer is
8986 now a value_print_options pointer; adjust.
8987 (_initialize_compile): Update "compile print"'s help to include
8988 supported options. Install a completer for "compile print".
8989 * cp-valprint.c (show_vtblprint, show_objectprint)
8990 (show_static_field_print): Delete.
8991 (_initialize_cp_valprint): Don't install "set print
8992 static-members", "set print vtbl", "set print object" here.
8993 * printcmd.c: Include "cli/cli-option.h" and
8994 "common/gdb_optional.h".
8995 (print_command_parse_format): Rework to fill in a
8996 value_print_options instead of a format_data.
8997 (print_value): Change parameter type from format_data pointer to
8998 value_print_options reference. Adjust.
8999 (print_command_1): Process options. Adjust to pass down a
9000 value_print_options.
9001 (print_command_completer): New.
9002 (_initialize_printcmd): Install print_command_completer as
9003 handle_brkchars completer for the "print" command. Update
9004 "print"'s help to include supported options.
9005 * valprint.c: Include "cli/cli-option.h".
9006 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9007 here from cp-valprint.c.
9008 (boolean_option_def, uinteger_option_def)
9009 (value_print_option_defs, make_value_print_options_def_group):
9010 New. Use gdb::option::add_setshow_cmds_for_options to install
9011 "set print elements", "set print null-stop", "set print repeats",
9012 "set print pretty", "set print union", "set print array", "set
9013 print address", "set print symbol", "set print array-indexes".
9014 * valprint.h: Include <string> and "cli/cli-option.h".
9015 (make_value_print_options_def_group): Declare.
9016 (print_value): Change parameter type from format_data pointer to
9017 value_print_options reference.
9018 (print_command_completer): Declare.
9020 2019-06-13 Pedro Alves <palves@redhat.com>
9022 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9023 (COMMON_SFILES): Add maint-test-settings.c.
9024 * cli/cli-decode.c (boolean_enums): New global, factored out from
9026 (add_setshow_boolean_cmd): ... here.
9027 * cli/cli-decode.h (boolean_enums): Declare.
9028 * cli/cli-option.c: New file.
9029 * cli/cli-option.h: New file.
9030 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9031 factored out from ...
9032 (parse_cli_boolean_value(const char *)): ... this.
9033 (is_unlimited_literal): Change parameter type to pointer to
9034 pointer. Adjust and advance ARG pointer.
9035 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9036 (parse_cli_var_enum): New, factored out from ...
9037 (do_set_command): ... this. Adjust.
9038 * cli/cli-setshow.h (parse_cli_boolean_value)
9039 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9040 (parse_cli_var_enum): Declare.
9041 * cli/cli-utils.c: Include "cli/cli-option.h".
9042 (get_ulongest): New.
9043 * cli/cli-utils.h (get_ulongest): Declare.
9044 (check_for_argument): New overloads.
9045 * maint-test-options.c: New file.
9047 2019-06-13 Pedro Alves <palves@redhat.com>
9049 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9050 parse a range if "-" is at the end of the string.
9052 2019-06-13 Pedro Alves <palves@redhat.com>
9054 * cli/cli-setshow.c (parse_auto_binary_operation)
9055 (parse_cli_boolean_value): Don't allow "o".
9057 2019-06-13 Pedro Alves <palves@redhat.com>
9059 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9060 * NEWS: Mention maint test-settings KIND.
9061 * maint-test-settings.c: New file.
9063 2019-06-13 Pedro Alves <palves@redhat.com>
9065 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9067 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9070 2019-06-13 Pedro Alves <palves@redhat.com>
9072 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9075 2019-06-13 Pedro Alves <palves@redhat.com>
9077 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9079 2019-06-13 Pedro Alves <palves@redhat.com>
9081 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9082 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9084 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9085 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9087 (check_for_argument): Skip spaces after argument.
9089 2019-06-13 Pedro Alves <palves@redhat.com>
9091 * thread.c (thread_apply_command): Adjust TID parsing.
9092 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9093 detected before end of string.
9094 (tid_is_in_list): Error out if LIST is invalid.
9096 2019-06-13 Pedro Alves <palves@redhat.com>
9098 * completer.c (complete_line_internal_1): Rewind completion word
9100 (completion_tracker::advance_custom_word_point_by): Change
9101 parameter type to int.
9102 * completer.h (completion_tracker::advance_custom_word_point_by):
9105 2019-06-13 Pedro Alves <palves@redhat.com>
9107 * completer.c (advance_to_completion_word): Handle delimiters.
9109 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9111 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9113 2019-06-11 Tom Tromey <tom@tromey.com>
9115 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9116 (xmalloc_failed): Move to alloc.c.
9117 * alloc.c: New file.
9118 * Makefile.in (COMMON_SFILES): Add alloc.c.
9120 2019-06-11 Tom Tromey <tom@tromey.com>
9122 * nat/linux-waitpid.c: Don't include server.h.
9123 (linux_debug): Remove.
9124 (my_waitpid): Update.
9126 2019-06-11 Tom Tromey <tromey@adacore.com>
9128 * infcall.c (_initialize_infcall): Remove trailing newline from
9130 * user-regs.c (_initialize_user_regs): Remove trailing newline
9132 * typeprint.c (_initialize_typeprint): Remove trailing newline
9134 * reverse.c (_initialize_reverse): Remove trailing newlines from
9136 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9138 * language.c (add_set_language_command): Remove trailing newline
9140 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9142 * disasm.c (_initialize_disasm): Remove trailing newline from
9144 * top.c (init_main): Remove trailing newline from help.
9145 * interps.c (_initialize_interpreter): Remove trailing newline
9147 * btrace.c (_initialize_btrace): Remove trailing newlines from
9149 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9151 * python/python.c (_initialize_python): Remove trailing newline
9153 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9155 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9156 from help. Reformat some text.
9157 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9159 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9162 2019-06-11 Tom Tromey <tromey@adacore.com>
9164 * darwin-nat.c (darwin_decode_exception_message)
9165 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9167 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9169 * valops.c (value_slice): Check for not allocated or not
9172 2019-06-10 Tom de Vries <tdevries@suse.de>
9175 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9176 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9179 2019-06-10 Tom de Vries <tdevries@suse.de>
9182 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9183 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9185 2019-06-10 Tom de Vries <tdevries@suse.de>
9188 * symtab.c (struct demangled_name_entry): Add language field.
9189 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9190 static minimal symbol". Set and use language field.
9192 2019-06-10 Tom Tromey <tromey@adacore.com>
9194 * ada-lang.c (_initialize_ada_language): Update help text.
9196 2019-06-10 Tom Tromey <tromey@adacore.com>
9198 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9200 * guile/guile.c (handle_boot_error): Don't end warning with a
9202 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9203 warning with a newline.
9204 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9206 (s12z_frame_cache): Likewise.
9207 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9209 * solib-svr4.c (disable_probes_interface): Don't end warning with
9211 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9213 * python/python.c (do_finish_initialization): Don't end warning
9216 2019-06-10 Tom Tromey <tom@tromey.com>
9218 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9219 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9222 2019-06-10 Tom Tromey <tromey@adacore.com>
9224 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9226 (elf_new_init): Don't call stabsread_new_init.
9227 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9228 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9229 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9231 2019-06-10 Tom de Vries <tdevries@suse.de>
9235 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9237 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9239 * source.c (find_and_open_source): Also rewrite relative file
9242 2019-04-26 Amos Bird <amosbird@gmail.com>
9244 * annotate.c (annotate_thread_exited): Add "thread-exited"
9247 2019-06-06 Tom Tromey <tromey@adacore.com>
9249 * maint.h (class scoped_command_stats): Use
9250 DISABLE_COPY_AND_ASSIGN.
9251 <print_time>: New method.
9252 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9254 (scoped_command_stats::print_time): New method.
9256 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9258 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9259 instructions of lengths 6 or 8 bytes.
9261 2019-06-04 Pedro Alves <palves@redhat.com>
9263 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9265 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9266 * breakpoint.c (condition_completer): Likewise.
9267 * cli/cli-dump.c (scan_expression): Likewise.
9268 * common/filestuff.c (mkdir_recursive): Likewise.
9269 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9270 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9271 (gdb_abspath): Likewise.
9272 * compile/compile-cplus-types.c
9273 (compile_cplus_instance::decl_name): Likewise.
9274 * completer.c (complete_explicit_location):
9275 (signal_completer, reg_or_group_completer_1): Likewise.
9276 * cp-support.c (cp_remove_params_if_any): Likewise.
9277 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9278 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9279 * infcmd.c (strip_bg_char): Likewise.
9280 * linespec.c (copy_token_string): Likewise.
9281 * mi/mi-main.c (output_cores): Likewise.
9282 * psymtab.c (psymtab_search_name):
9283 * symfile.c (test_set_ext_lang_command): Likewise.
9284 * target.c (target_fileio_read_stralloc): Likewise.
9285 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9286 * value.c (complete_internalvar): Likewise.
9288 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9290 Add objfile property to gdb.Type.
9291 * NEWS: Mention Python API addition.
9292 * python/py-type.c (typy_get_objfile): New method.
9294 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9296 * NEWS: Mention the new set|show style [title|highlight].
9297 Mention changes to "show style", "help" and "apropos".
9299 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9301 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9302 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9303 instead of print_help_for_command.
9304 (print_doc_of_command): New function.
9305 (help_list): Add 'apropos -v word' suggestion.
9306 (print_help_for_command): Style the command name using title style.
9307 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9308 (_initialize_cli_cmds): Describe -v in apropos_command help.
9310 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9312 * cli/cli-style.h (cli_style_option): Add name in constructor,
9313 add m_name class member, add constructor with intensity,
9314 add name class function.
9315 (cli_style_option::add_setshow_commands): Remove name argument.
9316 (highlight_style, title_style): New styles.
9317 * cli/cli-style.c (do_show): New function that shows a style
9318 characteristic styling the style name with itself.
9319 (set_style_name): New function.
9320 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9321 Update all callers according to the changes in cli/cli-style.h.
9322 * utils.h (fputs_highlighted): New function.
9323 * utils.c (fputs_highlighted): Likewise.
9325 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9327 * NEWS: Mention new pipe command and new convenience variables.
9329 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9331 * cli/cli-cmds.c (pipe_command): New function.
9332 (_initialize_cli_cmds): Call add_com for pipe_command.
9333 Define | as an alias for pipe.
9334 (exit_status_set_internal_vars): New function.
9335 (shell_escape): Call exit_status_set_internal_vars.
9336 cli/cli-decode.c (find_command_name_length): Recognize | as
9337 a single character command.
9339 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9341 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9342 top.c (execute_command_to_ui_file): New function, mostly a copy
9343 of execute_command_to_string.
9344 (execute_command_to_string): Implement by calling
9345 execute_command_to_ui_file.
9347 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9349 * top.h (saved_command_line): Remove declaration.
9350 * top.c (previous_saved_command_line, previous_repeat_arguments):
9352 (saved_command_line): Make static, define together with other
9354 (dont_repeat): Clear repeat_arguments.
9355 (repeat_previous, get_saved_command_line, save_command_line):
9357 (gdb_init): Initialize saved_command_line
9358 and previous_saved_command_line.
9359 * main.c (captured_main_1): Remove saved_command_line initialization.
9360 * event-top.c (handle_line_of_input): Update to use
9361 the new 'repeat' related functions instead of direct access to
9363 * command.h (repeat_previous, get_saved_command_line,
9364 save_command_line): New declarations.
9365 (dont_repeat): Add comment.
9367 2019-05-30 Tom Tromey <tromey@adacore.com>
9369 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9371 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9373 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9376 * completer.c (complete): Initialize variable word.
9378 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9380 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9381 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9382 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9383 'body' is NULL to the outter 'if', protecting the '!is_define'
9386 2019-05-29 Tom Tromey <tromey@adacore.com>
9388 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9389 (dwarf_unknown): New function.
9390 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9391 (dwarf_type_encoding_name): Use dwarf_unknown.
9393 2019-05-29 Tom Tromey <tromey@adacore.com>
9396 * cp-valprint.c (cp_print_value_fields): Call
9397 cp_print_static_field inside "try".
9399 2019-05-29 Tom Tromey <tromey@adacore.com>
9401 * inflow.c (struct terminal_info): Add default operator=.
9402 * configure: Rebuild.
9403 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9404 -Wdeprecated-copy-dtor, -Wredundant-move.
9406 2019-05-29 Tom Tromey <tromey@adacore.com>
9409 * infcmd.c (print_return_value_1): Handle finish_print
9411 (show_print_finish): New function.
9412 (_initialize_infcmd): Add "set/show print finish" commands.
9413 * valprint.c (user_print_options): Initialize new member.
9414 * valprint.h (struct value_print_options) <finish_print>: New
9417 2019-05-28 Tom Tromey <tromey@adacore.com>
9419 * ada-lang.c (ada_remove_Xbn_suffix)
9420 (find_old_style_renaming_symbol)
9421 (parse_old_style_renaming): Remove.
9422 (ada_find_renaming_symbol): Don't call
9423 find_old_style_renaming_symbol.
9424 (ada_is_renaming_symbol): Rename from
9425 ada_find_renaming_symbol. Remove "block" parameter. Return
9427 (ada_read_var_value): Update and simplify.
9428 * ada-exp.y (write_var_or_type): Remove old code.
9430 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9433 * event-top.c: Remove include comment.
9434 * inflow.c (class scoped_ignore_sigttou): Move from here...
9435 * inflow.h (class scoped_ignore_sigttou): ...to here.
9436 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9437 * top.c: Remove include comment.
9439 2019-05-27 Tom Tromey <tom@tromey.com>
9443 2019-05-22 Tom Tromey <tromey@adacore.com>
9445 * target.c (target_follow_exec): Constify parameter.
9446 * target-delegates.c: Rebuild.
9447 * remote.c (remote_target::follow_exec): Constify parameter.
9448 * infrun.c (follow_exec): Constify parameter.
9449 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9450 (target_follow_exec): Likewise.
9452 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9454 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9455 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9457 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9459 * NEWS: Add debugredirect and testsuite sections.
9461 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9463 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9464 target descriptions using exclusively floating point register name
9467 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9470 * f-lang.c (build_fortran_types): Handle the case where
9471 gdbarch_floatformat_for_type returns a nullptr.
9473 2019-05-21 Tom de Vries <tdevries@suse.de>
9476 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9478 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9481 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9483 * i386-tdep.c (i386_floatformat_for_type): Use
9484 floatformats_ia64_quad for the 16-byte floating point component
9485 within a fortran 32-byte complex number.
9487 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9489 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9490 delete default constructor.
9491 (find_partial_die): Update to return const struct.
9492 (partial_die_parent_scope): Move variable declaration into scope
9493 of its use and change its type to auto.
9494 (guess_partial_die_structure_name): Likewise.
9495 (partial_die_info::fixup): Likewise.
9497 2019-05-17 Tom Tromey <tromey@adacore.com>
9499 * source.c (find_and_open_source): Remove cast.
9501 2019-05-17 Tom Tromey <tromey@adacore.com>
9503 * annotate.c (annotate_source): Make "filename" const.
9504 * annotate.h (annotate_source): Use const.
9506 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9508 * disasm.c (set_disassembler_options): Send errors to stderr.
9510 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9512 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9513 (cli_interp_base::set_logging): Check debug_redirect.
9514 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9515 * cli/cli-logging.c (debug_redirect): Add static variable.
9516 (pop_output_files): Add default param.
9517 (handle_redirections): Print debug setting.
9518 (show_logging_command): Likewise.
9519 (_initialize_cli_logging): Add debugredirect command.
9520 * interps.c (current_interp_set_logging): Add debug_redirect
9522 * interps.h (set_logging): Add debug_redirect parameter.
9523 (current_interp_set_logging): Likewise.
9524 * mi/mi-common.h: Likewise.
9525 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9527 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9528 Tom Tromey <tromey@adacore.com>
9530 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9532 * cli/cli-interp.h (make_logging_output): Remove declaration.
9533 * cli/cli-logging.c (make_logging_output): Remove function.
9534 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9536 * ui-file.c (tee_file::tee_file): Remove bools.
9537 (tee_file::~tee_file): Remove deletes.
9538 * ui-file.h (tee_file): Remove bools.
9540 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9542 * mi/mi-cmds.h (mi_cmd_complete): New function.
9543 * mi/mi-main.c (mi_cmd_complete): Likewise.
9544 * mi/mi-cmds.c: Define new MI command -complete.
9545 * NEWS: Mention new -complete command.
9547 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9549 * completer.h (complete): New function.
9550 * completer.c (complete): Likewise.
9551 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9552 function defined in completer.h.
9554 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9556 * MAINTAINERS (Write After Approval): Add myself.
9558 2019-05-17 Tom de Vries <tdevries@suse.de>
9561 * dwarf2read.c (struct cu_partial_die_info): New struct.
9562 (find_partial_die): Return cu_partial_die_info.
9563 (partial_die_parent_scope, guess_partial_die_structure_name)
9564 (partial_die_info::fixup): Handle new return type of find_partial_die.
9566 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9568 PR breakpoints/24541
9569 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9570 "std::string", simplifying the algorithm.
9572 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9574 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9575 (stap_static_probe_ops::get_probes): Likewise.
9577 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9579 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9580 '-')" and "else if".
9581 (stap_parse_single_operand): Join checks for
9582 "gdbarch_stap_parse_special_token_p" and
9583 "gdbarch_stap_parse_special_token" in the same "if" statement.
9584 Invert check when verifying for operation on register
9587 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9589 * stap-probe.c (stap_get_opcode): Update comment.
9590 (stap_get_expected_argument_type): Likewise.
9591 (handle_stap_probe): Likewise.
9593 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9595 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9596 return type to 'bool'. Adjust comment. Use 'bool' when
9598 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9599 * stap-probe.c (stap_parse_argument_1): Likewise.
9600 (stap_is_operator): Likewise.
9601 (stap_is_generic_prefix): Likewise.
9602 (stap_is_register_prefix): Likewise.
9603 (stap_is_register_indirection_prefix): Likewise.
9604 (stap_is_integer_prefix): Likewise.
9605 (stap_generic_check_suffix): Likewise.
9606 (stap_check_integer_suffix): Likewise.
9607 (stap_check_register_suffix): Likewise.
9608 (stap_check_register_indirection_suffix): Likewise.
9609 (stap_parse_register_operand): Likewise.
9610 (stap_parse_single_operand): Likewise.
9611 (stap_parse_argument_1): Likewise.
9612 (stap_probe::get_argument_count): Likewise.
9613 (stap_is_operator): Likewise.
9615 2019-05-16 Tom Tromey <tromey@adacore.com>
9617 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9620 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9622 * linux-thread-db.c (try_thread_db_load_1): Change return type
9624 (try_thread_db_load): Likewise.
9625 (try_thread_db_load_from_pdir_1): Likewise.
9626 (try_thread_db_load_from_pdir): Likewise.
9627 (try_thread_db_load_from_sdir): Likewise.
9628 (try_thread_db_load_from_dir): Likewise.
9629 (thread_db_load_search): Likewise.
9630 (has_libpthread): Likewise.
9631 (thread_db_load): Likewise.
9633 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9635 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9636 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9637 NULL, and complain/return if that's the case.
9639 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9641 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9642 (advance, posn, abstract_read_memory): New functions.
9643 [struct mem_read_abstraction]: New struct.
9644 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9646 2019-05-14 Tom Tromey <tromey@adacore.com>
9648 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9649 value is not lval_memory.
9651 2019-05-14 Tom Tromey <tromey@adacore.com>
9653 * solib.c (info_sharedlibrary_command): Style the file name.
9655 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9657 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9658 (aarch64_vnv_type): Likewise.
9659 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9660 * common/tdesc.c: Likewise.
9661 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9662 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9663 * features/aarch64-fpu.xml: Add ieee half view.
9664 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9665 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9666 * gdbtypes.h (struct builtin_type): Likewise.
9667 (struct objfile_type): Likewise.
9669 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9671 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9673 * location.h (string_to_event_location): Likewise.
9675 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9679 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9681 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9682 New variable declaration.
9683 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9685 (print_one_breakpoint): Use ui_out::test_flags and new global
9686 variable to compute use_fixed_output.
9687 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9689 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9690 (mi_multi_location_breakpoint_output_fixed): Remove.
9691 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9693 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9694 fix_multi_location_breakpoint_output flag if version >= 3.
9695 * ui-out.h (enum ui_out_flag)
9696 <fix_multi_location_breakpoint_output>: New enumerator.
9698 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9700 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9702 2019-05-10 Tom Tromey <tromey@adacore.com>
9704 * ada-lang.c (catch_ada_completer): New function.
9705 (_initialize_ada_language): Use it.
9707 2019-05-10 Tom Tromey <tromey@adacore.com>
9709 * thread.c (print_thread_info): Make "requested_threads" const.
9710 * gdbthread.h (print_thread_info): Make "requested_threads"
9712 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9713 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9715 2019-05-08 Tom Tromey <tom@tromey.com>
9717 * gdbtypes.c (objfile_type_data): Change type.
9718 (objfile_type, _initialize_gdbtypes): Update.
9720 2019-05-08 Tom Tromey <tom@tromey.com>
9722 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9723 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9724 (_initialize_dwarf2_frame): Update.
9726 2019-05-08 Tom Tromey <tom@tromey.com>
9728 * objc-lang.c (objc_objfile_data): Change type.
9729 (find_methods): Update.
9730 (_initialize_objc_lang): Remove.
9732 2019-05-08 Tom Tromey <tom@tromey.com>
9734 * stabsread.c (rs6000_builtin_type_data): Change type.
9735 (rs6000_builtin_type, _initialize_stabsread): Update.
9737 2019-05-08 Tom Tromey <tom@tromey.com>
9739 * mips-tdep.c (mips_pdr_data): Remove.
9740 (_initialize_mips_tdep): Update.
9742 2019-05-08 Tom Tromey <tom@tromey.com>
9744 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9745 (hppa_init_objfile_priv_data, read_unwind_info)
9746 (find_unwind_entry, _initialize_hppa_tdep): Update.
9748 2019-05-08 Tom Tromey <tom@tromey.com>
9750 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9751 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9753 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9755 2019-05-08 Tom Tromey <tom@tromey.com>
9757 * mdebugread.c (basic_type_data): Change type.
9758 (basic_type, _initialize_mdebugread): Update.
9760 2019-05-08 Tom Tromey <tom@tromey.com>
9762 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9764 2019-05-08 Tom Tromey <tom@tromey.com>
9766 * nto-tdep.c (nto_inferior_data_reg): Change type.
9767 (nto_inferior_data): Update.
9768 (nto_inferior_data_cleanup, nto_new_inferior_data)
9769 (_initialize_nto_tdep): Remove.
9770 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9772 2019-05-08 Tom Tromey <tom@tromey.com>
9774 * ada-lang.c (struct ada_inferior_data): Add initializers.
9775 (ada_inferior_data): Change type.
9776 (ada_inferior_data_cleanup): Remove.
9777 (get_ada_inferior_data, ada_inferior_exit)
9778 (struct ada_pspace_data): Add initializers, destructor.
9779 (ada_pspace_data_handle): Change type.
9780 (get_ada_pspace_data): Update.
9781 (ada_pspace_data_cleanup): Remove.
9783 2019-05-08 Tom Tromey <tom@tromey.com>
9785 * coffread.c (struct coff_symfile_info): Add initializers.
9786 (coff_objfile_data_key): Move lower. Change type.
9787 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9789 (coff_free_info): Remove.
9791 2019-05-08 Tom Tromey <tom@tromey.com>
9793 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9794 (fbsd_pspace_data_handle): Move lower. Change type.
9795 (get_fbsd_pspace_data): Update.
9796 (fbsd_pspace_data_cleanup): Remove.
9797 (_initialize_fbsd_tdep): Update.
9799 2019-05-08 Tom Tromey <tom@tromey.com>
9801 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9802 (get_ada_tasks_pspace_data): Update.
9803 (ada_tasks_pspace_data_cleanup): Remove.
9804 (_initialize_tasks): Update.
9805 (ada_tasks_inferior_data_handle): Change type.
9806 (get_ada_tasks_inferior_data): Update.
9807 (ada_tasks_inferior_data_cleanup): Remove.
9808 (struct ada_tasks_pspace_data): Add initializers.
9810 2019-05-08 Tom Tromey <tom@tromey.com>
9812 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9813 * symfile-debug.c (debug_sym_get_probes): Change type.
9814 * stap-probe.c (handle_stap_probe):
9815 (stap_static_probe_ops::get_probes): Change type.
9816 * probe.h (class static_probe_ops) <get_probes>: Change type.
9817 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9818 (parse_probes_in_pspace): Update.
9819 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9821 (any_static_probe_ops::get_probes): Change type.
9822 * elfread.c (elfread_data): New typedef.
9823 (probe_key): Change type.
9824 (elf_get_probes): Likewise. Update.
9825 (probe_key_free): Remove.
9826 (_initialize_elfread): Update.
9827 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9829 (dtrace_process_dof_probe, dtrace_process_dof)
9830 (dtrace_static_probe_ops::get_probe): Change type.
9832 2019-05-08 Tom Tromey <tom@tromey.com>
9834 * xcoffread.c (struct xcoff_symfile_info): Rename from
9835 coff_symfile_info. Add initializers.
9836 (xcoff_objfile_data_key): Move lower. Change type.
9837 (XCOFF_DATA): Rewrite.
9838 (xcoff_free_info): Remove.
9839 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9840 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9841 (xcoff_initial_scan): Update.
9843 2019-05-08 Tom Tromey <tom@tromey.com>
9845 * solib-svr4.c (struct svr4_info): Add initializers and
9847 <probes_table>: Now an htab_up.
9848 (solib_svr4_pspace_data): Change type.
9849 (free_probes_table): Simplify.
9850 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9851 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9852 (probes_table_remove_objfile_probes, register_solib_event_probe)
9853 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9854 (_initialize_svr4_solib): Update.
9856 2019-05-08 Tom Tromey <tom@tromey.com>
9858 * remote.c (remote_pspace_data): Change type.
9859 (remote_pspace_data_cleanup): Remove.
9860 (get_remote_exec_file, set_pspace_remote_exec_file)
9861 (_initialize_remote): Update.
9863 2019-05-08 Tom Tromey <tom@tromey.com>
9865 * breakpoint.c (breakpoint_objfile_key): Change type.
9866 (get_breakpoint_objfile_data): Update.
9867 (free_breakpoint_objfile_data): Remove.
9868 (_initialize_breakpoint): Update.
9870 2019-05-08 Tom Tromey <tom@tromey.com>
9872 * linux-tdep.c (struct linux_info): Add initializers.
9873 (linux_inferior_data): Move. Change type.
9874 (invalidate_linux_cache_inf): Update.
9875 (linux_inferior_data_cleanup): Remove.
9876 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9878 2019-05-08 Tom Tromey <tom@tromey.com>
9880 * auxv.c (auxv_inferior_data): Move. Change type.
9881 (auxv_inferior_data_cleanup): Remove.
9882 (invalidate_auxv_cache_inf): Rewrite.
9883 (get_auxv_inferior_data, _initialize_auxv): Update.
9885 2019-05-08 Tom Tromey <tom@tromey.com>
9887 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9888 (symfile_debug_objfile_data_key): Change type.
9889 (symfile_debug_installed, debug_qf_has_symbols)
9890 (debug_qf_find_last_source_symtab)
9891 (debug_qf_forget_cached_source_info)
9892 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9893 (debug_qf_print_stats, debug_qf_dump)
9894 (debug_qf_expand_symtabs_for_function)
9895 (debug_qf_expand_all_symtabs)
9896 (debug_qf_expand_symtabs_with_fullname)
9897 (debug_qf_map_matching_symbols)
9898 (debug_qf_expand_symtabs_matching)
9899 (debug_qf_find_pc_sect_compunit_symtab)
9900 (debug_qf_map_symbol_filenames)
9901 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9902 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9903 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9904 (debug_sym_read_linetable, debug_sym_relocate): Update.
9905 (symfile_debug_free_objfile): Remove.
9906 (install_symfile_debug_logging, _initialize_symfile_debug):
9909 2019-05-08 Tom Tromey <tom@tromey.com>
9911 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9912 allocate_on_obstack.
9913 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9914 (get_dwarf2_per_objfile): Update.
9915 (set_dwarf2_per_objfile): Remove.
9916 (dwarf2_has_info, dwarf2_get_section_info): Update.
9917 (dwarf2_free_objfile): Remove.
9918 (_initialize_dwarf2_read): Update.
9920 2019-05-08 Tom Tromey <tom@tromey.com>
9922 * auto-load.c (struct auto_load_pspace_info): Add destructor and
9924 <unsupported_script_warning_printed,
9925 script_not_found_warning_printed>: Now bool.
9926 (auto_load_pspace_data): Change type.
9927 (~auto_load_pspace_info): Rename from
9928 auto_load_pspace_data_cleanup.
9929 (get_auto_load_pspace_data, init_loaded_scripts_info)
9930 (clear_section_scripts, maybe_print_unsupported_script_warning)
9931 (maybe_print_script_not_found_warning, _initialize_auto_load):
9934 2019-05-08 Tom Tromey <tom@tromey.com>
9936 * objfiles.c (objfile_pspace_info): Add destructor and
9938 (objfiles_pspace_data): Change type.
9939 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9940 (get_objfile_pspace_data): Update.
9941 (objfiles_bfd_data): Change type.
9942 (get_objfile_bfd_data): Update.
9943 (objfile_bfd_data_free, _initialize_objfiles): Remove.
9945 2019-05-08 Tom Tromey <tom@tromey.com>
9947 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9949 (get_catch_syscall_inferior_data): Update.
9950 (catch_syscall_inferior_data_cleanup): Remove.
9951 (_initialize_break_catch_syscall): Update.
9953 2019-05-08 Tom Tromey <tom@tromey.com>
9955 * inflow.c (struct terminal_info): Add destructor and
9957 (inflow_inferior_data): Change type.
9958 (~terminal_info): Rename from inflow_inferior_data_cleanup.
9959 (get_inflow_inferior_data, inflow_inferior_exit)
9960 (swap_terminal_info, _initialize_inflow): Update.
9962 2019-05-08 Tom Tromey <tom@tromey.com>
9964 * target-dcache.c (target_dcache_cleanup): Remove.
9965 (target_dcache_aspace_key): Change type.
9966 (target_dcache_init_p, target_dcache_invalidate)
9967 (target_dcache_get, target_dcache_get_or_init)
9968 (_initialize_target_dcache): Update.
9969 * dcache.h (struct dcache_deleter): New.
9971 2019-05-08 Tom Tromey <tom@tromey.com>
9973 * symtab.c (struct symbol_cache): Add destructor and
9975 (symbol_cache_key): Move. Change type.
9976 (make_symbol_cache, free_symbol_cache): Remove.
9977 (get_symbol_cache): Update.
9978 (symbol_cache_cleanup): Remove.
9979 (ALL_PSPACES, symbol_cache_flush)
9980 (maintenance_print_symbol_cache)
9981 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9984 2019-05-08 Tom Tromey <tom@tromey.com>
9986 * symtab.c (struct main_info): Add destructor and initializers.
9987 (main_progspace_key): Move. Change type.
9988 (get_main_info): Update.
9989 (main_info_cleanup): Remove.
9990 (_initialize_symtab): Update.
9992 2019-05-08 Tom Tromey <tom@tromey.com>
9994 * registry.h (DECLARE_REGISTRY): Define the _key class.
9996 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
9998 * NEWS: Merge two 'New commands' sections.
10000 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10002 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10003 parameter and use Ada language definition instead.
10004 (ada_val_print_ptr): Remove unused language parameter.
10005 (ada_val_print_num): Remove language parameter and use Ada language
10006 definition instead.
10007 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10009 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10010 parameter and use Ada language definition instead.
10011 (ada_val_print_1): Update all ada_val_print_xxx calls.
10012 Remove language parameter.
10013 (ada_val_print): Update ada_val_print_1 call.
10015 2019-05-08 Tom Tromey <tromey@adacore.com>
10017 * remote.c (remote_hw_watchpoint_limit)
10018 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10021 2019-05-08 Tom Tromey <tromey@adacore.com>
10023 * maint.c (_initialize_maint_cmds): Move initialization code to
10025 (watchdog, show_watchdog): Move to remote.c.
10026 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10028 (_initialize_remote): Move initialization code from maint.c.
10029 * defs.h (watchdog): Don't declare.
10031 2019-05-08 Tom Tromey <tromey@adacore.com>
10033 * tui/tui-interp.c: Include main.h.
10034 * interps.c: Include main.h.
10035 * main.h (interpreter_p): Declare.
10036 * defs.h (interpreter_p): Don't declare.
10038 2019-05-08 Tom Tromey <tromey@adacore.com>
10040 * dwarf2loc.c: Include dwarf2read.h.
10041 * defs.h (read_unsigned_leb128): Don't declare.
10042 * dwarf2read.h (read_unsigned_leb128): Declare.
10044 2019-05-08 Tom Tromey <tromey@adacore.com>
10046 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10049 2019-05-08 Tom Tromey <tromey@adacore.com>
10051 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10052 when no wrap column is set.
10054 2019-05-08 Tom Tromey <tromey@adacore.com>
10056 * c-lang.c (c_get_string): Handle non-C-style arrays.
10058 2019-05-08 Tom Tromey <tromey@adacore.com>
10060 * typeprint.c (print_offset_data::update): Print the bit offset,
10061 not the number of bits remaining.
10063 2019-05-08 Tom Tromey <tromey@adacore.com>
10065 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10066 padding at end of comment.
10068 2019-05-08 Tom Tromey <tromey@adacore.com>
10070 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10071 Compare main types.
10073 2019-05-06 Tom Tromey <tom@tromey.com>
10075 * common/scoped_mmap.c: Include common-defs.h.
10076 * common/scoped_mmap.h: Don't include config.h.
10078 2019-05-04 Tom Tromey <tom@tromey.com>
10080 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10081 (struct aarch64_call_info): Add initializers.
10082 <si>: Now a std::vector.
10083 (pass_on_stack, aarch64_push_dummy_call): Update.
10085 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10086 Tom Tromey <tom@tromey.com>
10088 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10089 (ppc_threads): Now a std::vector. Now static.
10090 (hwdebug_find_thread_points_by_tid)
10091 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10094 2019-05-04 Tom Tromey <tom@tromey.com>
10096 * arc-tdep.c (arc_tdesc_init): Return bool.
10098 2019-05-04 Tom Tromey <tom@tromey.com>
10100 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10101 Use gdb_assert_not_reached.
10103 2019-05-04 Tom Tromey <tom@tromey.com>
10105 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10108 2019-05-04 Tom Tromey <tom@tromey.com>
10110 * arc-tdep.c (arc_tdesc_init): Use bool.
10112 2019-05-04 Tom Tromey <tom@tromey.com>
10114 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10116 2019-05-04 Tom Tromey <tom@tromey.com>
10118 * cli/cli-cmds.c (valid_command_p): Return bool.
10120 2019-05-04 Tom Tromey <tom@tromey.com>
10122 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10123 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10125 2019-05-04 Raul Tambre <raul@tambre.ee>
10127 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10128 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10129 operator for comparison.
10131 2019-05-04 Tom Tromey <tom@tromey.com>
10133 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10134 (lookup_partial_symbol, print_partial_symbols)
10135 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10136 (psymbol_compare): Update.
10137 (add_psymbol_to_bcache): Clear the entire psymbol.
10138 (maintenance_check_psymtabs): Update.
10139 * psympriv.h (struct partial_symbol): Don't derive from
10140 general_symbol_info.
10141 <obj_section, unrelocated_address, address,
10142 set_unrelocated_address>: Update.
10143 <ginfo>: New member.
10144 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10145 (debug_names::write_psymbols): Update.
10147 2019-05-04 Tom de Vries <tdevries@suse.de>
10149 * contrib/cc-with-tweaks.sh: Support -n arg.
10151 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10153 * corelow.c (core_target::detach): Ensure frame cache and
10154 register caches are cleared.
10155 inferior.c (exit_inferior_1): Likewise.
10157 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10158 Tom Tromey <tom@tromey.com>
10160 * dictionary.c (collate_pending_symbols_by_language): Remove
10161 "struct" from foreach.
10162 * symtab.c (lookup_global_symbol_from_objfile)
10163 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10165 * ser-tcp.c (net_open): Remove "struct" from foreach.
10166 * objfiles.c (objfile_relocate, objfile_rebase)
10167 (objfile_has_symbols): Remove "struct" from foreach.
10168 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10170 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10172 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10173 "struct" from foreach.
10174 * ada-lang.c (create_excep_cond_exprs)
10175 (ada_exception_catchpoint_cond_string): Remove "struct" from
10178 2019-05-03 Tom Tromey <tromey@adacore.com>
10180 * ada-exp.y (convert_char_literal): Check suffix of each
10183 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10186 * ada-exp.y (yywrap): Don't define.
10187 * ada-lex.l (%option): Add noyywrap
10190 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10192 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10193 _WIN32_WINNT to the XP level, unless already defined to a higher
10196 * unittests/parse-connection-spec-selftests.c:
10198 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10201 * symfile.c (find_separate_debug_file): Remove colon from the
10202 drive spec of DOS/Windows file names of the target, so that the
10203 file name produced from DEBUGDIR and the target's directory will
10204 be valid on DOS/Windows systems.
10206 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10208 * rust-lang.c (val_print_struct): Handle printing structures
10209 containing strings.
10211 2019-05-02 Tom Tromey <tromey@adacore.com>
10213 * valarith.c (_initialize_valarith): Remove.
10215 2019-05-01 Tom Tromey <tromey@adacore.com>
10217 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10220 2019-05-01 Tom Tromey <tromey@adacore.com>
10222 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10223 for big-endian copies.
10225 2019-04-30 Ali Tamur <tamur@google.com>
10226 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10227 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10228 (read_3_bytes): New function.
10230 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10232 * windows-nat.c (main_thread_id): Delete.
10233 (handle_output_debug_string): Replace main_thread_id by
10234 current_event.dwThreadId.
10235 (fake_create_process): Likewise.
10236 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10237 Do not set main_thread_id.
10238 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10239 current_event.dwThreadId.
10240 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10242 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10244 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10245 Use current_event.dwThreadId instead of main_thread_id.
10247 2019-04-30 Tom Tromey <tromey@adacore.com>
10249 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10250 (create_excep_cond_exprs): Iterate over program spaces.
10251 (ada_exception_catchpoint_cond_string): Examine all minimal
10252 symbols for exception types.
10254 2019-04-30 Tom Tromey <tromey@adacore.com>
10257 * dwarf2read.c (process_structure_scope): Handle case where type
10258 has template parameters but no symbol was created.
10260 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10261 Chris January <chris.january@arm.com>
10263 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10265 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10267 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10269 * f-typeprint.c (f_print_type): Update rules for printing
10271 (f_type_print_varspec_suffix): Likewise.
10273 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10274 Chris January <chris.january@arm.com>
10276 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10277 function arguments.
10279 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10281 * f-lang.c (build_fortran_types): Change name of void type to
10283 * f-typeprint.c (f_type_print_base): Print the name of the void
10284 type, rather than a fixed string.
10285 * f-valprint.c (f_decorations): Use lower case void string.
10287 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10288 Chris January <chris.january@arm.com>
10290 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10293 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10294 Chris January <chris.january@arm.com>
10295 David Lecomber <david.lecomber@arm.com>
10297 * f-exp.y (BINOP_INTRINSIC): New token.
10298 (exp): New parser rule handling BINOP_INTRINSIC.
10299 (f77_keywords): Add new builtin procedures.
10300 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10301 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10302 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10303 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10304 (print_unop_subexp_f): New function.
10305 (print_binop_subexp_f): New function.
10306 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10307 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10308 (dump_subexp_body_f): Likewise.
10309 (operator_check_f): Likewise.
10310 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10311 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10313 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10315 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10317 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10318 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10319 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10320 (operator_length_f): New fuction.
10321 (print_subexp_f): New function.
10322 (op_name_f): New function.
10323 (dump_subexp_body_f): New function.
10324 (operator_check_f): New function.
10325 (exp_descriptor_f): Replace standard expression handling functions
10326 with new functions.
10327 * gdb/fortran-operator.def: New file.
10328 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10329 * gdb/std-operator.def: Remove UNOP_KIND.
10331 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10333 * std-operator.def: Remove unbalanced, stray double quote
10336 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10337 Chris January <chris.january@arm.com>
10338 Daniel Everett <daniel.everett@arm.com>
10339 Nick Forrington <nick.forrington@arm.com>
10340 Richard Bunt <richard.bunt@arm.com>
10342 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10343 of depth when printing anonymous structs or unions.
10344 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10345 Don't print either the top-level value, or the children if the
10346 max-depth is exceeded.
10347 (ppscm_print_children): When printing the key of a map, allow one
10348 extra level of depth.
10349 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10350 print either the top-level value, or the children if the max-depth
10352 (print_children): When printing the key of a map, allow one extra
10354 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10355 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10356 (user_print_options): Initialise max_depth field.
10357 (val_print_scalar_or_string_type_p): New function.
10358 (val_print): Check to see if the max depth has been reached.
10359 (val_print_check_max_depth): Define new function.
10360 (show_print_max_depth): New function.
10361 (_initialize_valprint): Add 'print max-depth' option.
10362 * valprint.h (struct value_print_options) <max_depth>: New field.
10363 (val_print_check_max_depth): Declare new function.
10364 * NEWS: Document new feature.
10366 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10368 * ada-lang.c (ada_language_defn): Initialise new field.
10369 * c-lang.c (c_is_string_type_p): New function.
10370 (c_language_defn): Initialise new field.
10371 (cplus_language_defn): Initialise new field.
10372 (asm_language_defn): Initialise new field.
10373 (minimal_language_defn): Initialise new field.
10374 * c-lang.h (c_is_string_type_p): Declare new function.
10375 * d-lang.c (d_language_defn): Initialise new field.
10376 * f-lang.c (f_is_string_type_p): New function.
10377 (f_language_defn): Initialise new field.
10378 * go-lang.c (go_is_string_type_p): New function.
10379 (go_language_defn): Initialise new field.
10380 * language.c (default_is_string_type_p): New function.
10381 (unknown_language_defn): Initialise new field.
10382 (auto_language_defn): Initialise new field.
10383 * language.h (struct language_defn) <la_is_string_type_p>: New
10385 (default_is_string_type_p): Declare new function.
10386 * m2-lang.c (m2_language_defn): Initialise new field.
10387 * objc-lang.c (objc_language_defn): Initialise new field.
10388 * opencl-lang.c (opencl_language_defn): Initialise new field.
10389 * p-lang.c (pascal_is_string_type_p): New function.
10390 (pascal_language_defn): Initialise new field.
10391 * rust-lang.c (rust_is_string_type_p): New function.
10392 (rust_language_defn): Initialise new field.
10394 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10396 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10398 * ada-lang.c (ada_language_defn): Initialise new field.
10399 * c-lang.c (c_language_defn): Likewise.
10400 (cplus_language_defn): Likewise.
10401 (asm_language_defn): Likewise.
10402 (minimal_language_defn): Likewise.
10403 * d-lang.c (d_language_defn): Likewise.
10404 * f-lang.c (f_language_defn): Likewise.
10405 * go-lang.c (go_language_defn): Likewise.
10406 * language.c (unknown_language_defn): Likewise.
10407 (auto_language_defn): Likewise.
10408 * m2-lang.c (m2_language_defn): Likewise.
10409 * objc-lang.c (objc_language_defn): Likewise.
10410 * opencl-lang.c (opencl_language_defn): Likewise.
10411 * p-lang.c (pascal_language_defn): Likewise.
10412 * rust-lang.c (rust_language_defn): Likewise.
10414 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10416 * ada-lang.c (ada_is_character_type): Change return type to bool.
10417 (ada_is_string_type): Likewise.
10418 * ada-lang.h (ada_is_character_type): Update declaration
10419 (ada_is_string_type): Likewise.
10421 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10423 Support style in 'frame|thread apply'
10425 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10426 * record.c (record_start, record_stop): Update callers of
10427 execute_command_to_string with false.
10428 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10429 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10431 (class string_file): New constructor with term_out parameter.
10432 Override methods term_out and can_emit_style_escape. New member
10434 (class stdio_file): Override can_emit_style_escape.
10435 (class tee_file): Override term_out and can_emit_style_escape.
10436 * utils.h (can_emit_style_escape): Remove.
10437 * utils.c (can_emit_style_escape): Likewise.
10438 Update all callers of can_emit_style_escape (SOMESTREAM) to
10439 SOMESTREAM->can_emit_style_escape.
10440 * source-cache.c (source_cache::get_source_lines): Likewise.
10441 * stack.c (frame_apply_command_count): Call execute_command_to_string
10442 passing the term_out characteristic of the current gdb_stdout.
10443 * thread.c (thr_try_catch_cmd): Likewise.
10444 * top.c (execute_command_to_string): pass term_out parameter
10445 to construct the string_file for the command output.
10446 * ui-file.c (term_cli_styling): New function (most code moved
10447 from utils.c can_emit_style_escape).
10448 (string_file::string_file, string_file::can_emit_style_escape,
10449 stdio_file::can_emit_style_escape, tee_file::term_out,
10450 tee_file::can_emit_style_escape): New functions.
10452 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10454 * NEWS: Mention the new set|show may-call-functions.
10455 * infcall.c (may_call_functions_p): New variable.
10456 (show_may_call_functions_p): New function.
10457 (call_function_by_hand_dummy): Throws an error if not
10458 may-call-functions.
10459 (_initialize_infcall): Call add_setshow_boolean_cmd for
10460 may-call-functions.
10462 2019-04-25 Keith Seitz <keiths@redhat.com>
10465 * cp-support.c (inspect_type): Don't attempt substitutions
10466 of symbol with the same name.
10468 2019-04-25 Tom Tromey <tromey@adacore.com>
10471 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10474 2019-04-25 Tom Tromey <tromey@adacore.com>
10476 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10478 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10479 (gdb_xml_parser::parse): Use std::move.
10480 * python/python-internal.h (gdbpy_convert_exception): Take a const
10482 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10484 * python/py-utils.c (gdbpy_convert_exception): Take a const
10486 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10488 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10490 * mi/mi-main.c (mi_print_exception): Take a const reference.
10491 * main.c (handle_command_errors): Take a const reference.
10492 * linespec.c (parse_linespec): Use std::move.
10493 * infcall.c (run_inferior_call): Use std::move.
10494 (call_function_by_hand_dummy): Use std::move.
10495 * exec.c (try_open_exec_file): Use std::move.
10496 * exceptions.h (exception_print, exception_fprintf)
10497 (exception_print_same): Update.
10498 * exceptions.c (print_exception, exception_print)
10499 (exception_fprintf, exception_print_same): Change parameters to
10501 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10502 * common/new-op.c: Use std::move.
10503 * common/common-exceptions.h (struct gdb_exception): Add move
10505 (struct gdb_exception_error, struct gdb_exception_quit, struct
10506 gdb_quit_bad_alloc): Change constructor to move constructor.
10507 (throw_exception): Change parameter to rvalue reference.
10508 * common/common-exceptions.c (throw_exception): Take rvalue
10510 * cli/cli-interp.c (safe_execute_command): Use std::move.
10511 * breakpoint.c (insert_bp_location, location_to_sals): Use
10514 2019-04-25 Tom Tromey <tromey@adacore.com>
10516 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10517 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10518 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10519 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10520 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10521 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10522 guile/scm-value.c: Use unpack.
10523 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10524 gdbscm_gdb_exception.
10525 (gdbscm_throw_gdb_exception): Likewise.
10526 (struct gdbscm_gdb_exception): New.
10527 (unpack): New function.
10528 (gdbscm_wrap): Use unpack.
10530 2019-04-25 Tom Tromey <tromey@adacore.com>
10532 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10533 (gdb_rl_callback_handler): Use std::move.
10534 * common/common-exceptions.h (struct gdb_exception): Add move
10535 assignment operator.
10536 (throw_exception_sjlj): Change "exception" to const reference.
10537 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10538 (throw_exception_sjlj): Change "exception" to const reference.
10540 2019-04-25 Tom Tromey <tromey@adacore.com>
10542 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10543 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10544 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10546 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10548 * mi/mi-interp.c (mi_interp::exec): Update.
10549 * linespec.c (parse_linespec): Update.
10550 * infcall.c (run_inferior_call): Update.
10551 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10552 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10553 (gdbscm_lookup_global_symbol): Update.
10554 * guile/scm-param.c (gdbscm_parameter_value): Update.
10555 * guile/scm-frame.c (gdbscm_frame_read_register)
10556 (gdbscm_frame_read_var): Update.
10557 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10558 * exec.c (try_open_exec_file): Update.
10559 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10560 (gdb_rl_callback_handler): Update.
10561 * common/common-exceptions.h (exception_none): Don't declare.
10562 * common/common-exceptions.c (exception_none): Don't define.
10563 (struct catcher) <exception>: Update.
10564 * cli/cli-interp.c (safe_execute_command): Update.
10565 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10567 2019-04-25 Ali Tamur <tamur@google.com>
10569 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10570 (read_attribute_value): Likewise.
10571 (dwarf2_read_addr_index): Update comment.
10572 (read_str_index): Add DW_FORM_strx.
10573 (dwarf2_string_attr): Likewise.
10574 (dwarf2_const_value_attr): Likewise.
10575 (dump_die_shallow): Likewise.
10576 (dwarf2_fetch_constant_bytes): Likewise.
10577 (skip_form_bytes): Likewise.
10578 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10580 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10584 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10585 OFFSET. Verify if current mapping contains an ELF header.
10586 (linux_find_memory_regions_full): Adjust call to
10589 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10590 Kang Li <kanglictf@gmail.com>
10594 * dwarf2-frame.c (read_initial_length): Be consistent about using
10595 unsigned representation of length.
10596 (decode_frame_entry_1): Likewise. Check for wraparound of
10597 end pointer as well as buffer overflow.
10599 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10601 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10604 2019-04-24 Tom Tromey <tromey@adacore.com>
10606 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10608 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10610 * s12z-tdep.c (s12z_unwind_pc): Delete.
10611 (s12z_unwind_sp): Delete.
10612 (s12z_gdbarch_init): Don't register deleted functions with
10615 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10617 * rl78-tdep.c (rl78_unwind_sp): Delete.
10618 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10620 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10622 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10623 (xstormy16_unwind_pc): Delete.
10624 (xstormy16_dummy_id): Delete.
10625 (xstormy16_gdbarch_init): Don't register deleted functions with
10628 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10630 * vax-tdep.c (vax_unwind_pc): Delete.
10631 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10633 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10635 * v850-tdep.c (v850_unwind_sp): Delete.
10636 (v850_unwind_pc): Delete.
10637 (v850_dummy_id): Delete.
10638 (v850_gdbarch_init): Don't register deleted functions with
10641 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10643 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10644 (tilegx_unwind_pc): Delete.
10645 (tilegx_unwind_dummy_id): Delete.
10646 (tilegx_gdbarch_init): Don't register deleted functions with
10649 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10651 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10652 (tic6x_dummy_id): Delete.
10653 (tic6x_gdbarch_init): Don't register deleted functions with
10656 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10658 * sparc-tdep.c (sparc_unwind_pc): Delete.
10659 (sparc32_gdbarch_init): Don't register deleted function with
10662 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10664 * sh-tdep.c (sh_unwind_sp): Delete.
10665 (sh_unwind_pc): Delete.
10666 (sh_dummy_id): Delete.
10667 (sh_gdbarch_init): Don't register deleted functions with
10670 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10672 * score-tdep.c (score_unwind_sp): Delete.
10673 (score_unwind_pc): Delete.
10674 (score_dummy_id): Delete.
10675 (score_gdbarch_init): Don't register deleted functions with
10678 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10680 * rx-tdep.c (rx_unwind_pc): Delete.
10681 (rx_unwind_sp): Delete.
10682 (rx_dummy_id): Delete.
10683 (rx_gdbarch_init): Don't register deleted functions with
10684 gdbarch. Update comment.
10686 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10688 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10689 (rs6000_dummy_id): Delete.
10690 (rs6000_gdbarch_init): Don't register deleted functions with
10693 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10695 * or1k-tdep.c (or1k_dummy_id): Delete.
10696 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10698 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10700 * nios2-tdep.c (nios2_dummy_id): Delete.
10701 (nios2_unwind_sp): Delete.
10702 (nios2_gdbarch_init): Don't register deleted functions with
10705 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10707 * nds32-tdep.c (nds32_dummy_id): Delete.
10708 (nds32_unwind_pc): Delete.
10709 (nds32_unwind_sp): Delete.
10710 (nds32_gdbarch_init): Don't register deleted functions with
10713 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10715 * msp430-tdep.c (msp430_unwind_pc): Delete.
10716 (msp430_unwind_sp): Delete.
10717 (msp430_dummy_id): Delete.
10718 (msp430_gdbarch_init): Don't register deleted functions with
10721 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10723 * moxie-tdep.c (moxie_unwind_sp): Delete.
10724 (moxie_unwind_pc): Delete.
10725 (moxie_dummy_id): Delete.
10726 (moxie_gdbarch_init): Don't register deleted functions with
10729 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10731 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10732 (mn10300_unwind_pc): Delete.
10733 (mn10300_unwind_sp): Delete.
10734 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10736 (mn10300_frame_unwind_init): Don't register deleted functions with
10739 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10741 * mep-tdep.c (mep_unwind_pc): Delete.
10742 (mep_unwind_sp): Delete.
10743 (mep_dummy_id): Delete.
10744 (mep_gdbarch_init): Don't register deleted functions with
10747 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10749 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10750 (m68hc11_unwind_sp): Delete.
10751 (m68hc11_gdbarch_init): Don't register deleted functions with
10754 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10756 * m32r-tdep.c (m32r_unwind_sp): Delete.
10757 (m32r_unwind_pc): Delete.
10758 (m32r_dummy_id): Delete.
10759 (m32r_gdbarch_init): Don't register deleted functions with
10762 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10764 * m32c-tdep.c (m32c_unwind_pc): Delete.
10765 (m32c_unwind_sp): Delete.
10766 (m32c_dummy_id): Delete.
10767 (m32c_gdbarch_init): Don't register deleted functions with
10770 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10772 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10773 (lm32_unwind_pc): Delete.
10774 (lm32_dummy_id): Delete.
10775 (lm32_gdbarch_init): Don't register deleted functions with
10778 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10780 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10781 (iq2000_unwind_pc): Delete.
10782 (iq2000_dummy_id): Delete.
10783 (iq2000_gdbarch_init): Don't register deleted functions with
10786 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10788 * nds32-tdep.c (nds32_type_align): Delete.
10789 (nds32_push_dummy_call): Use type_align instead.
10791 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10793 * arm-tdep.c (arm_type_align): Only handle vector override case.
10794 (arm_push_dummy_call): Use type_align.
10795 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10797 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10799 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10801 (pass_on_stack): Use type_align.
10802 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10805 2019-04-23 Tom Tromey <tromey@adacore.com>
10807 * dwarf2read.c (line_header::file_name_at): Remove unused
10810 2019-04-23 Tom de Vries <tdevries@suse.de>
10813 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10817 2019-03-27 Ali Tamur <tamur@google.com>
10819 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10820 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10821 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10822 (dwarf_expr_context::get_addr_index): Likewise
10823 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10824 (symbol_needs_eval_context::get_addr_index): Likewise
10825 (disassemble_dwarf_expression): Add DW_OP_addrx
10826 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10827 (read_cutu_die_from_dwo): Update comment
10828 (skip_one_die): Add DW_FORM_addrx
10829 (read_attribute_value): Likewise
10830 (var_decode_location): Add DW_OP_addrx
10831 (dwarf2_const_value_attr): Add DW_FORM_addrx
10832 (dump_die_shallow): Likewise
10833 (dwarf2_fetch_constant_bytes): Likewise
10834 (decode_locdesc): Add DW_OP_addrx
10835 (skip_form_bytes): Add DW_FORM_addrx
10837 2019-04-22 Ali Tamur <tamur@google.com>
10839 * MAINTAINERS (Write After Approval): Add self.
10841 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
10843 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10844 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10845 (open_symbol_file_object): Likewise.
10846 (svr4_default_sos): Add info parameter.
10847 (svr4_read_so_list): Likewise.
10848 (svr4_current_sos_direct): Adjust functions calls to pass down
10850 (svr4_current_sos_1): Add info parameter.
10851 (svr4_current_sos): Call get_svr4_info, pass info down to
10852 svr4_current_sos_1.
10853 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10855 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10857 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10859 (probes_table_remove_objfile_probes): Likewise.
10860 (register_solib_event_probe): Add info parameter.
10861 (solist_update_incremental): Pass info parameter down to
10863 (disable_probes_interface): Add info parameter.
10864 (svr4_handle_solib_event): Pass current_program_space to
10865 get_svr4_info. Adjust disable_probes_interface cleanup.
10866 (svr4_create_probe_breakpoints): Add info parameter, pass it
10867 down to register_solib_event_probe.
10868 (svr4_create_solib_event_breakpoints): Add info parameter,
10869 pass it down to svr4_create_probe_breakpoints.
10870 (enable_break): Pass info down to
10871 svr4_create_solib_event_breakpoints.
10872 (svr4_solib_create_inferior_hook): Pass current_program_space to
10874 (svr4_clear_solib): Likewise.
10876 2019-04-22 Pedro Alves <palves@redhat.com>
10878 * solib-svr4.c (svr4_free_objfile_observer): New.
10879 (probe_and_action::objfile): New field.
10880 (probes_table_htab_remove_objfile_probes)
10881 (probes_table_remove_objfile_probes): New functions.
10882 (register_solib_event_probe): Add 'objfile' parameter. Store it
10883 in the new probe_and_action. Don't store the probe in 'lookup'.
10884 (svr4_create_probe_breakpoints): Pass objfile to
10885 register_solib_event_probe.
10886 (_initialize_svr4_solib): Register a free_objfile observer.
10888 2019-04-19 Tom Tromey <tom@tromey.com>
10890 * common/queue.h: Remove.
10892 2019-04-19 Tom Tromey <tom@tromey.com>
10894 * event-loop.c: Don't include "common/queue.h".
10896 2019-04-19 Tom Tromey <tom@tromey.com>
10898 * remote.c (remote_target): Use delete.
10899 * remote-notif.h: Include <list>, not "common/queue.h".
10900 (notif_client_p): Remove typedef.
10901 (remote_notif_state): Add constructor, destructor, initializer.
10902 <notif_queue>: Now a std::list.
10903 (remote_notif_state_xfree): Don't declare.
10904 * remote-notif.c (remote_notif_process, handle_notification)
10905 (remote_notif_state_allocate): Update.
10906 (~remote_notif_state): Rename from remote_notif_state_xfree.
10908 2019-04-19 Tom Tromey <tom@tromey.com>
10910 * symfile.c (reread_symbols): Update.
10911 * objfiles.c (objfile_register_static_link)
10912 (objfile_lookup_static_link): Update
10913 (~objfile) Don't delete static_links.
10914 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10916 2019-04-19 Tom Tromey <tom@tromey.com>
10918 * type-stack.h (struct type_stack) <insert>: Constify string.
10919 * type-stack.c (type_stack::insert): Constify string.
10920 * gdbtypes.h (lookup_template_type): Update.
10921 (address_space_name_to_int): Update.
10922 * gdbtypes.c (address_space_name_to_int): Make space_identifier
10924 (lookup_template_type): Make name const.
10925 * c-exp.y: Update rules.
10926 (lex_one_token, classify_name, classify_inner_name)
10927 (c_print_token): Update.
10928 * p-exp.y: Update rules.
10930 * f-exp.y: Update rules.
10932 * d-exp.y: Update rules.
10933 (lex_one_token, classify_name, classify_inner_name): Update.
10934 * parse.c (write_dollar_variable, copy_name): Return std::string.
10935 * parser-defs.h (copy_name): Change return type.
10936 * m2-exp.y: Update rules.
10938 * go-exp.y (lex_one_token): Update.
10940 (classify_unsafe_function, classify_packaged_name)
10941 (classify_name, yylex): Update.
10943 2019-04-19 Sergei Trofimovich <siarheit@google.com>
10945 * configure.ac: add --enable-source-highlight switch.
10946 * configure: Regenerate.
10947 * top.c (print_gdb_version): plumb --enable-source-highlight
10948 status to "show configuration".
10950 2019-04-19 Tom Tromey <tromey@adacore.com>
10952 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10954 (empty_record, ada_template_to_fixed_record_type_1)
10955 (template_to_static_fixed_type)
10956 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10957 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10958 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10961 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
10964 * source.c (print_source_lines_base): Advance "iter" when a
10965 control character is seen.
10967 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10969 * inferior.h (struct infcall_suspend_state_deleter):
10970 Catch exception in destructor to avoid crash.
10972 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10974 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10975 close to the add_com "shell".
10977 2019-04-18 Tom Tromey <tromey@adacore.com>
10979 * process-stratum-target.h (class process_stratum_target)
10980 <stratum>: Add "final".
10982 2019-04-17 Tom Tromey <tromey@adacore.com>
10984 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10985 against nullptr before use.
10987 2019-04-17 Alan Hayward <alan.hayward@arm.com>
10989 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10991 2019-04-17 Jim Wilson <jimw@sifive.com>
10992 Andrew Burgess <andrew.burgess@embecosm.com>
10994 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10995 code read might fail, assume 4-byte breakpoint in that case.
10997 2019-04-15 Leszek Swirski <leszeks@google.com>
10999 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11000 rather than a hand-rolled POD check when checking for forced MEMORY
11003 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11005 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11006 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11008 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11009 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11010 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11013 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11015 * aarch64-linux-nat.c
11016 (aarch64_linux_nat_target::thread_architecture): Add override.
11017 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11020 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11022 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11024 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11026 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11027 target types of size 96-bits, add some additional comments, and
11028 check that the builtin type we found was the correct size.
11030 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11032 * utils.c (prompt_for_continue): Don't restore the styling at the
11033 end, as applied_style has the wrong value. This fixes styling in
11034 long lists of file names that are interrupted by the "Continue?"
11037 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11039 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11040 * c-lang.c (c_language_defn): Likewise.
11041 (cplus_language_defn): Likewise.
11042 (asm_language_defn): Likewise.
11043 (minimal_language_defn): Likewise.
11044 * d-lang.c (d_language_defn): Likewise.
11045 * f-lang.c (f_language_defn): Likewise.
11046 * go-lang.c (go_language_defn): Likewise.
11047 * language.c (unknown_language_defn): Likewise.
11048 (auto_language_defn): Likewise.
11049 * language.h (struct language_defn): Remove la_magic field.
11050 (LANG_MAGIC): Delete.
11051 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11052 * objc-lang.c (objc_language_defn): Likewise.
11053 * opencl-lang.c (opencl_language_defn): Likewise.
11054 * p-lang.c (pascal_language_defn): Likewise.
11055 * rust-lang.c (rust_language_defn): Likewise.
11057 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11059 * riscv-tdep.c (riscv_type_align): New function.
11060 (riscv_type_alignment): Delete.
11061 (riscv_arg_location): Use 'type_align'.
11062 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11064 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11066 * gdbtypes.c (type_align): A struct with no non-static fields also
11067 has alignment of 1.
11069 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11071 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11073 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11075 (riscv_struct_info::analyse): New implementation using new
11076 analyse_inner member function.
11077 (riscv_struct_info::field_offset): New member function.
11078 (riscv_struct_info::m_offsets): New member variable.
11079 (riscv_struct_info::analyse_inner): New private member function,
11080 takes the old implementation of riscv_struct_info::analyse but
11081 extended to track field offsets.
11082 (riscv_call_arg_struct): Update the struct folding special cases
11083 to handle cases where empty C++ structs, which are non-zero
11085 (riscv_arg_location): Initialise the length of each location, a
11086 non-zero length now indicates the location is in use.
11087 (riscv_push_dummy_call): Allow for the first location having a
11088 non-zero offset when setting up arguments.
11089 (riscv_return_value): Likewise, but for return values.
11091 2019-04-11 Tom Tromey <tromey@adacore.com>
11093 * utils.c (internal_vproblem): Make "msg" const.
11095 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11097 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11098 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11099 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11100 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11102 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11104 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11106 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11107 of amd64_collect_native_gregset.
11108 (amd64_linux_nat_target::store_registers): Likewise.
11110 2019-04-10 Tom Tromey <tom@tromey.com>
11112 * symtab.c (lookup_global_symbol_from_objfile)
11113 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11114 * objfiles.h (class separate_debug_iterator): New.
11115 (class separate_debug_range): New.
11116 (struct objfile) <separate_debug_objfiles>: New method.
11117 (objfile_separate_debug_iterate): Don't declare.
11118 * objfiles.c (separate_debug_iterator::operator++): Rename from
11119 objfile_separate_debug_iterate.
11120 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11122 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11125 2019-04-10 Tom Tromey <tom@tromey.com>
11127 * symfile.c (reread_symbols): Remove old comment.
11128 * objfiles.c (free_all_objfiles): Fix a typo.
11130 2019-04-10 Tom Tromey <tom@tromey.com>
11132 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11133 * minsyms.c (lookup_minimal_symbol): Use foreach.
11134 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11135 (lookup_minimal_symbol_solib_trampoline): Likewise.
11136 * symfile.c (reread_symbols): Use foreach.
11138 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11139 Tom Tromey <tromey@adacore.com>
11142 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11143 (rust_lex_int_test): Change "value" to be LONGEST.
11144 (rust_lex_tests): Add test for long integer literal.
11146 2019-04-09 Tom Tromey <tromey@adacore.com>
11148 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11150 (extended_remote_target::attach): Update.
11151 (remote_target::remote_notice_new_inferior): Update.
11152 (remote_target::add_current_inferior_and_thread): Update.
11153 * inferior.c (exit_inferior_1): Use "false".
11154 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11156 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11158 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11159 the "start" command.
11161 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11163 * python/py-inferior.c (infpy_thread_from_thread_handle):
11164 Adjust comments to reflect renaming of thread_from_thread_handle
11165 to thread_from_handle. Adjust keywords. Fix type error message.
11166 (inferior_object_methods): Add thread_from_handle. Retain
11167 thread_from_thread_handle, but mark it as deprecated.
11169 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11171 * gdbthread.h (find_thread_by_handle): Revise declaration.
11172 * thread.c (find_thread_by_handle): Likewise. Adjust
11173 implementation too.
11174 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11175 support for buffer objects as handles.
11177 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11179 * python/py-infthread.c (thpy_thread_handle): New function.
11180 (thread_object_methods): Register thpy_thread_handle.
11182 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11184 * gdbthread.h (thread_to_thread_handle): Declare.
11185 * thread.c (gdbtypes.h): Include.
11186 (thread_to_thread_handle): New function.
11188 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11189 (target_thread_info_to_thread_handle): Declare.
11190 * target.c (target_thread_info_to_thread_handle): New function.
11191 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11192 * target-delegates.c: Regenerate.
11194 * linux-thread-db.c (class thread_db_target): Add method
11195 thread_info_to_thread_handle.
11196 (thread_db_target::thread_info_to_thread_handle): Define.
11197 * remote.c (class remote_target): Add new method
11198 thread_info_to_thread_handle.
11199 (remote_target::thread_info_to_thread_handle): Define.
11201 2019-04-08 Pedro Alves <palves@redhat.com>
11203 * common/common-exceptions.c (throw_exception): Don't create
11204 named object to throw; throw directly.
11205 (throw_it): Likewise. Don't initialize gdb_exception::message
11206 here, with new; pass FMT and AP to the ctor instead.
11207 * common/common-exceptions.h: Include <string>.
11208 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11209 const char *, va_list)): New ctor. Use std::make_shared.
11210 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11212 (gdb_exception_error::gdb_exception_error(enum errors, const char
11214 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11216 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11218 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11219 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11222 2019-04-08 Tom Tromey <tom@tromey.com>
11224 * valops.c (value_rtti_indirect_type): Replace throw_exception
11226 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11228 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11230 * target.c (target_translate_tls_address): Replace throw_exception
11232 * stack.c (frame_apply_command_count): Replace throw_exception
11234 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11236 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11238 * rs6000-tdep.c (rs6000_frame_cache)
11239 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11240 * remote.c: Replace throw_exception with throw.
11241 * record-full.c (record_full_message, record_full_wait_1)
11242 (record_full_restore): Replace throw_exception with throw.
11244 (get_thread_current_frame_id, record_btrace_start_replaying)
11245 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11246 (cmd_record_btrace_start): Replace throw_exception with throw.
11247 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11249 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11250 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11252 (find_linespec_symbols): Replace throw_exception with throw.
11253 * infrun.c (displaced_step_prepare, resume): Replace
11254 throw_exception with throw.
11255 * infcmd.c (post_create_inferior): Replace throw_exception with
11257 * inf-loop.c (inferior_event_handler): Replace throw_exception
11259 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11260 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11261 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11262 (get_prev_frame_always, get_frame_pc_if_available)
11263 (get_frame_address_in_block_if_available, get_frame_language):
11264 Replace throw_exception with throw.
11265 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11266 throw_exception with throw.
11267 * eval.c (fetch_subexp_value, evaluate_var_value)
11268 (evaluate_funcall, evaluate_subexp_standard): Replace
11269 throw_exception with throw.
11270 * dwarf2loc.c (call_site_find_chain)
11271 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11272 Replace throw_exception with throw.
11273 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11275 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11277 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11278 * completer.c (complete_line_internal): Replace throw_exception
11280 * compile/compile-object-run.c (compile_object_run): Replace
11281 throw_exception with throw.
11282 * cli/cli-script.c (process_next_line): Replace throw_exception
11284 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11285 (btrace_enable, btrace_maint_update_pt_packets): Replace
11286 throw_exception with throw.
11287 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11288 throw_exception with throw.
11289 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11290 throw_exception with throw.
11291 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11292 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11293 * aarch64-tdep.c (aarch64_make_prologue_cache)
11294 (aarch64_make_stub_cache): Replace throw_exception with throw.
11296 2019-04-08 Tom Tromey <tom@tromey.com>
11298 * common/common-exceptions.c (throw_exception): Rename from
11299 throw_exception_cxx. Remove old copy. Make argument const.
11300 (throw_it): Create and throw exception objects directly.
11301 * common/common-exceptions.h (throw_exception): Make argument
11303 (struct gdb_exception_error): Add constructor.
11304 (struct gdb_exception_quit): Add constructor.
11306 2019-04-08 Tom Tromey <tom@tromey.com>
11308 * common/common-exceptions.h (exception_rethrow): Don't declare.
11309 (TRY_SJLJ): Update comment.
11310 (TRY, CATCH, END_CATCH): Remove.
11311 * common/common-exceptions.c (exception_rethrow): Remove.
11313 2019-04-08 Tom Tromey <tom@tromey.com>
11315 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11317 (gdb_exception_error): Rename from
11318 gdb_exception_RETURN_MASK_ERROR.
11319 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11320 (gdb_quit_bad_alloc): Update.
11321 * aarch64-tdep.c: Update.
11322 * ada-lang.c: Update.
11323 * ada-typeprint.c: Update.
11324 * ada-valprint.c: Update.
11325 * amd64-tdep.c: Update.
11326 * arch-utils.c: Update.
11327 * break-catch-throw.c: Update.
11328 * breakpoint.c: Update.
11329 * btrace.c: Update.
11330 * c-varobj.c: Update.
11331 * cli/cli-cmds.c: Update.
11332 * cli/cli-interp.c: Update.
11333 * cli/cli-script.c: Update.
11334 * common/common-exceptions.c: Update.
11335 * common/new-op.c: Update.
11336 * common/selftest.c: Update.
11337 * compile/compile-c-symbols.c: Update.
11338 * compile/compile-cplus-symbols.c: Update.
11339 * compile/compile-object-load.c: Update.
11340 * compile/compile-object-run.c: Update.
11341 * completer.c: Update.
11342 * corelow.c: Update.
11343 * cp-abi.c: Update.
11344 * cp-support.c: Update.
11345 * cp-valprint.c: Update.
11346 * darwin-nat.c: Update.
11347 * disasm-selftests.c: Update.
11348 * dtrace-probe.c: Update.
11349 * dwarf-index-cache.c: Update.
11350 * dwarf-index-write.c: Update.
11351 * dwarf2-frame-tailcall.c: Update.
11352 * dwarf2-frame.c: Update.
11353 * dwarf2loc.c: Update.
11354 * dwarf2read.c: Update.
11356 * event-loop.c: Update.
11357 * event-top.c: Update.
11359 * f-valprint.c: Update.
11360 * fbsd-tdep.c: Update.
11361 * frame-unwind.c: Update.
11363 * gdbtypes.c: Update.
11364 * gnu-v3-abi.c: Update.
11365 * guile/guile-internal.h: Update.
11366 * guile/scm-block.c: Update.
11367 * guile/scm-breakpoint.c: Update.
11368 * guile/scm-cmd.c: Update.
11369 * guile/scm-disasm.c: Update.
11370 * guile/scm-frame.c: Update.
11371 * guile/scm-lazy-string.c: Update.
11372 * guile/scm-math.c: Update.
11373 * guile/scm-param.c: Update.
11374 * guile/scm-ports.c: Update.
11375 * guile/scm-pretty-print.c: Update.
11376 * guile/scm-symbol.c: Update.
11377 * guile/scm-symtab.c: Update.
11378 * guile/scm-type.c: Update.
11379 * guile/scm-value.c: Update.
11380 * i386-linux-tdep.c: Update.
11381 * i386-tdep.c: Update.
11382 * inf-loop.c: Update.
11383 * infcall.c: Update.
11384 * infcmd.c: Update.
11385 * infrun.c: Update.
11387 * language.c: Update.
11388 * linespec.c: Update.
11389 * linux-fork.c: Update.
11390 * linux-nat.c: Update.
11391 * linux-tdep.c: Update.
11392 * linux-thread-db.c: Update.
11394 * mi/mi-cmd-break.c: Update.
11395 * mi/mi-cmd-stack.c: Update.
11396 * mi/mi-interp.c: Update.
11397 * mi/mi-main.c: Update.
11398 * objc-lang.c: Update.
11399 * p-valprint.c: Update.
11401 * ppc-linux-tdep.c: Update.
11402 * printcmd.c: Update.
11403 * python/py-arch.c: Update.
11404 * python/py-breakpoint.c: Update.
11405 * python/py-cmd.c: Update.
11406 * python/py-finishbreakpoint.c: Update.
11407 * python/py-frame.c: Update.
11408 * python/py-framefilter.c: Update.
11409 * python/py-gdb-readline.c: Update.
11410 * python/py-inferior.c: Update.
11411 * python/py-infthread.c: Update.
11412 * python/py-lazy-string.c: Update.
11413 * python/py-linetable.c: Update.
11414 * python/py-objfile.c: Update.
11415 * python/py-param.c: Update.
11416 * python/py-prettyprint.c: Update.
11417 * python/py-progspace.c: Update.
11418 * python/py-record-btrace.c: Update.
11419 * python/py-record.c: Update.
11420 * python/py-symbol.c: Update.
11421 * python/py-type.c: Update.
11422 * python/py-unwind.c: Update.
11423 * python/py-utils.c: Update.
11424 * python/py-value.c: Update.
11425 * python/python.c: Update.
11426 * record-btrace.c: Update.
11427 * record-full.c: Update.
11428 * remote-fileio.c: Update.
11429 * remote.c: Update.
11430 * riscv-tdep.c: Update.
11431 * rs6000-aix-tdep.c: Update.
11432 * rs6000-tdep.c: Update.
11433 * rust-exp.y: Update.
11434 * rust-lang.c: Update.
11435 * s390-tdep.c: Update.
11436 * selftest-arch.c: Update.
11437 * solib-dsbt.c: Update.
11438 * solib-frv.c: Update.
11439 * solib-spu.c: Update.
11440 * solib-svr4.c: Update.
11442 * sparc64-linux-tdep.c: Update.
11444 * symfile-mem.c: Update.
11445 * symmisc.c: Update.
11446 * target.c: Update.
11447 * thread.c: Update.
11449 * tracefile-tfile.c: Update.
11450 * tui/tui.c: Update.
11451 * typeprint.c: Update.
11452 * unittests/cli-utils-selftests.c: Update.
11453 * unittests/parse-connection-spec-selftests.c: Update.
11454 * valops.c: Update.
11455 * valprint.c: Update.
11457 * varobj.c: Update.
11458 * windows-nat.c: Update.
11459 * x86-linux-nat.c: Update.
11460 * xml-support.c: Update.
11462 2019-04-08 Tom Tromey <tom@tromey.com>
11464 * xml-support.c: Use C++ exception handling.
11465 * x86-linux-nat.c: Use C++ exception handling.
11466 * windows-nat.c: Use C++ exception handling.
11467 * varobj.c: Use C++ exception handling.
11468 * value.c: Use C++ exception handling.
11469 * valprint.c: Use C++ exception handling.
11470 * valops.c: Use C++ exception handling.
11471 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11473 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11474 * typeprint.c: Use C++ exception handling.
11475 * tui/tui.c: Use C++ exception handling.
11476 * tracefile-tfile.c: Use C++ exception handling.
11477 * top.c: Use C++ exception handling.
11478 * thread.c: Use C++ exception handling.
11479 * target.c: Use C++ exception handling.
11480 * symmisc.c: Use C++ exception handling.
11481 * symfile-mem.c: Use C++ exception handling.
11482 * stack.c: Use C++ exception handling.
11483 * sparc64-linux-tdep.c: Use C++ exception handling.
11484 * solib.c: Use C++ exception handling.
11485 * solib-svr4.c: Use C++ exception handling.
11486 * solib-spu.c: Use C++ exception handling.
11487 * solib-frv.c: Use C++ exception handling.
11488 * solib-dsbt.c: Use C++ exception handling.
11489 * selftest-arch.c: Use C++ exception handling.
11490 * s390-tdep.c: Use C++ exception handling.
11491 * rust-lang.c: Use C++ exception handling.
11492 * rust-exp.y: Use C++ exception handling.
11493 * rs6000-tdep.c: Use C++ exception handling.
11494 * rs6000-aix-tdep.c: Use C++ exception handling.
11495 * riscv-tdep.c: Use C++ exception handling.
11496 * remote.c: Use C++ exception handling.
11497 * remote-fileio.c: Use C++ exception handling.
11498 * record-full.c: Use C++ exception handling.
11499 * record-btrace.c: Use C++ exception handling.
11500 * python/python.c: Use C++ exception handling.
11501 * python/py-value.c: Use C++ exception handling.
11502 * python/py-utils.c: Use C++ exception handling.
11503 * python/py-unwind.c: Use C++ exception handling.
11504 * python/py-type.c: Use C++ exception handling.
11505 * python/py-symbol.c: Use C++ exception handling.
11506 * python/py-record.c: Use C++ exception handling.
11507 * python/py-record-btrace.c: Use C++ exception handling.
11508 * python/py-progspace.c: Use C++ exception handling.
11509 * python/py-prettyprint.c: Use C++ exception handling.
11510 * python/py-param.c: Use C++ exception handling.
11511 * python/py-objfile.c: Use C++ exception handling.
11512 * python/py-linetable.c: Use C++ exception handling.
11513 * python/py-lazy-string.c: Use C++ exception handling.
11514 * python/py-infthread.c: Use C++ exception handling.
11515 * python/py-inferior.c: Use C++ exception handling.
11516 * python/py-gdb-readline.c: Use C++ exception handling.
11517 * python/py-framefilter.c: Use C++ exception handling.
11518 * python/py-frame.c: Use C++ exception handling.
11519 * python/py-finishbreakpoint.c: Use C++ exception handling.
11520 * python/py-cmd.c: Use C++ exception handling.
11521 * python/py-breakpoint.c: Use C++ exception handling.
11522 * python/py-arch.c: Use C++ exception handling.
11523 * printcmd.c: Use C++ exception handling.
11524 * ppc-linux-tdep.c: Use C++ exception handling.
11525 * parse.c: Use C++ exception handling.
11526 * p-valprint.c: Use C++ exception handling.
11527 * objc-lang.c: Use C++ exception handling.
11528 * mi/mi-main.c: Use C++ exception handling.
11529 * mi/mi-interp.c: Use C++ exception handling.
11530 * mi/mi-cmd-stack.c: Use C++ exception handling.
11531 * mi/mi-cmd-break.c: Use C++ exception handling.
11532 * main.c: Use C++ exception handling.
11533 * linux-thread-db.c: Use C++ exception handling.
11534 * linux-tdep.c: Use C++ exception handling.
11535 * linux-nat.c: Use C++ exception handling.
11536 * linux-fork.c: Use C++ exception handling.
11537 * linespec.c: Use C++ exception handling.
11538 * language.c: Use C++ exception handling.
11539 * jit.c: Use C++ exception handling.
11540 * infrun.c: Use C++ exception handling.
11541 * infcmd.c: Use C++ exception handling.
11542 * infcall.c: Use C++ exception handling.
11543 * inf-loop.c: Use C++ exception handling.
11544 * i386-tdep.c: Use C++ exception handling.
11545 * i386-linux-tdep.c: Use C++ exception handling.
11546 * guile/scm-value.c: Use C++ exception handling.
11547 * guile/scm-type.c: Use C++ exception handling.
11548 * guile/scm-symtab.c: Use C++ exception handling.
11549 * guile/scm-symbol.c: Use C++ exception handling.
11550 * guile/scm-pretty-print.c: Use C++ exception handling.
11551 * guile/scm-ports.c: Use C++ exception handling.
11552 * guile/scm-param.c: Use C++ exception handling.
11553 * guile/scm-math.c: Use C++ exception handling.
11554 * guile/scm-lazy-string.c: Use C++ exception handling.
11555 * guile/scm-frame.c: Use C++ exception handling.
11556 * guile/scm-disasm.c: Use C++ exception handling.
11557 * guile/scm-cmd.c: Use C++ exception handling.
11558 * guile/scm-breakpoint.c: Use C++ exception handling.
11559 * guile/scm-block.c: Use C++ exception handling.
11560 * guile/guile-internal.h: Use C++ exception handling.
11561 * gnu-v3-abi.c: Use C++ exception handling.
11562 * gdbtypes.c: Use C++ exception handling.
11563 * frame.c: Use C++ exception handling.
11564 * frame-unwind.c: Use C++ exception handling.
11565 * fbsd-tdep.c: Use C++ exception handling.
11566 * f-valprint.c: Use C++ exception handling.
11567 * exec.c: Use C++ exception handling.
11568 * event-top.c: Use C++ exception handling.
11569 * event-loop.c: Use C++ exception handling.
11570 * eval.c: Use C++ exception handling.
11571 * dwarf2read.c: Use C++ exception handling.
11572 * dwarf2loc.c: Use C++ exception handling.
11573 * dwarf2-frame.c: Use C++ exception handling.
11574 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11575 * dwarf-index-write.c: Use C++ exception handling.
11576 * dwarf-index-cache.c: Use C++ exception handling.
11577 * dtrace-probe.c: Use C++ exception handling.
11578 * disasm-selftests.c: Use C++ exception handling.
11579 * darwin-nat.c: Use C++ exception handling.
11580 * cp-valprint.c: Use C++ exception handling.
11581 * cp-support.c: Use C++ exception handling.
11582 * cp-abi.c: Use C++ exception handling.
11583 * corelow.c: Use C++ exception handling.
11584 * completer.c: Use C++ exception handling.
11585 * compile/compile-object-run.c: Use C++ exception handling.
11586 * compile/compile-object-load.c: Use C++ exception handling.
11587 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11588 * compile/compile-c-symbols.c: Use C++ exception handling.
11589 * common/selftest.c: Use C++ exception handling.
11590 * common/new-op.c: Use C++ exception handling.
11591 * cli/cli-script.c: Use C++ exception handling.
11592 * cli/cli-interp.c: Use C++ exception handling.
11593 * cli/cli-cmds.c: Use C++ exception handling.
11594 * c-varobj.c: Use C++ exception handling.
11595 * btrace.c: Use C++ exception handling.
11596 * breakpoint.c: Use C++ exception handling.
11597 * break-catch-throw.c: Use C++ exception handling.
11598 * arch-utils.c: Use C++ exception handling.
11599 * amd64-tdep.c: Use C++ exception handling.
11600 * ada-valprint.c: Use C++ exception handling.
11601 * ada-typeprint.c: Use C++ exception handling.
11602 * ada-lang.c: Use C++ exception handling.
11603 * aarch64-tdep.c: Use C++ exception handling.
11605 2019-04-08 Tom Tromey <tom@tromey.com>
11607 * xml-support.c (gdb_xml_parser::parse): Update.
11608 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11609 * value.c (show_convenience): Update.
11610 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11611 (test_parse_flags_qcs): Update.
11612 * thread.c (thr_try_catch_cmd): Update.
11613 * target.c (target_translate_tls_address): Update.
11614 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11615 (info_frame_command_core, frame_apply_command_count): Update.
11616 * rust-exp.y (rust_lex_exception_test): Update.
11617 * riscv-tdep.c (riscv_print_one_register_info): Update.
11618 * remote.c (remote_target::enable_btrace): Update.
11619 * record-btrace.c (record_btrace_enable_warn): Update.
11620 * python/py-utils.c (gdbpy_convert_exception): Update.
11621 * printcmd.c (do_one_display, print_variable_and_value): Update.
11622 * mi/mi-main.c (mi_print_exception): Update.
11623 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11624 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11625 * linux-nat.c (linux_nat_target::attach): Update.
11626 * linux-fork.c (class scoped_switch_fork_info): Update.
11627 * infrun.c (displaced_step_prepare): Update.
11628 * infcall.c (call_function_by_hand_dummy): Update.
11629 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11630 * gnu-v3-abi.c (print_one_vtable): Update.
11631 * frame.c (get_prev_frame_always): Update.
11632 * f-valprint.c (info_common_command_for_block): Update.
11633 * exec.c (try_open_exec_file): Update.
11634 * exceptions.c (print_exception, exception_print)
11635 (exception_fprintf, exception_print_same): Update.
11636 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11637 * dwarf-index-cache.c (index_cache::store)
11638 (index_cache::lookup_gdb_index): Update.
11639 * darwin-nat.c (maybe_cache_shell): Update.
11640 * cp-valprint.c (cp_print_value_fields): Update.
11641 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11642 (gcc_cplus_symbol_address): Update.
11643 * compile/compile-c-symbols.c (gcc_convert_symbol)
11644 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11645 * common/selftest.c: Update.
11646 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11648 (exception_try_scope_entry, exception_try_scope_exit): Don't
11650 (struct exception_try_scope): Remove.
11651 (TRY): Don't use exception_try_scope.
11652 (struct gdb_exception): Add constructor, operator=.
11653 <what>: New method.
11654 (struct gdb_exception_RETURN_MASK_ALL)
11655 (struct gdb_exception_RETURN_MASK_ERROR)
11656 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11657 (struct gdb_quit_bad_alloc): Update.
11658 * common/common-exceptions.c (exception_none): Change
11660 (struct catcher) <state, exception>: Initialize inline.
11661 <prev>: Remove member.
11662 (current_catcher): Remove.
11663 (catchers): New global.
11664 (exceptions_state_mc_init): Simplify.
11665 (catcher_pop): Remove.
11666 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11667 (try_scope_depth, exception_try_scope_entry)
11668 (exception_try_scope_exit): Remove.
11669 (throw_exception_sjlj): Update.
11670 (exception_messages, exception_messages_size): Remove.
11671 (throw_it): Simplify.
11672 (gdb_exception_sliced_copy): Remove.
11673 (throw_exception_cxx): Update.
11674 * cli/cli-script.c (script_from_file): Update.
11675 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11677 * ada-valprint.c (ada_val_print): Update.
11678 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11679 (create_excep_cond_exprs): Update.
11681 2019-04-08 Tom Tromey <tom@tromey.com>
11683 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11684 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11685 (TRY, CATCH, END_CATCH): Remove some definitions.
11686 * common/common-exceptions.c: Don't use GDB_XCPT.
11687 (catcher_list_size): Remove.
11688 (throw_exception, throw_it): Simplify.
11690 2019-04-05 Tom Tromey <tom@tromey.com>
11692 Revert the header-sorting patch.
11693 * ft32-tdep.c: Revert.
11694 * frv-tdep.c: Revert.
11695 * frv-linux-tdep.c: Revert.
11697 * frame-unwind.c: Revert.
11698 * frame-base.c: Revert.
11699 * fork-child.c: Revert.
11700 * findvar.c: Revert.
11701 * findcmd.c: Revert.
11702 * filesystem.c: Revert.
11703 * filename-seen-cache.h: Revert.
11704 * filename-seen-cache.c: Revert.
11705 * fbsd-tdep.c: Revert.
11706 * fbsd-nat.h: Revert.
11707 * fbsd-nat.c: Revert.
11708 * f-valprint.c: Revert.
11709 * f-typeprint.c: Revert.
11710 * f-lang.c: Revert.
11711 * extension.h: Revert.
11712 * extension.c: Revert.
11713 * extension-priv.h: Revert.
11714 * expprint.c: Revert.
11717 * exceptions.c: Revert.
11718 * event-top.c: Revert.
11719 * event-loop.c: Revert.
11721 * elfread.c: Revert.
11722 * dwarf2read.h: Revert.
11723 * dwarf2read.c: Revert.
11724 * dwarf2loc.c: Revert.
11725 * dwarf2expr.h: Revert.
11726 * dwarf2expr.c: Revert.
11727 * dwarf2-frame.c: Revert.
11728 * dwarf2-frame-tailcall.c: Revert.
11729 * dwarf-index-write.h: Revert.
11730 * dwarf-index-write.c: Revert.
11731 * dwarf-index-common.c: Revert.
11732 * dwarf-index-cache.h: Revert.
11733 * dwarf-index-cache.c: Revert.
11734 * dummy-frame.c: Revert.
11735 * dtrace-probe.c: Revert.
11736 * disasm.h: Revert.
11737 * disasm.c: Revert.
11738 * disasm-selftests.c: Revert.
11739 * dictionary.c: Revert.
11740 * dicos-tdep.c: Revert.
11741 * demangle.c: Revert.
11742 * dcache.h: Revert.
11743 * dcache.c: Revert.
11744 * darwin-nat.h: Revert.
11745 * darwin-nat.c: Revert.
11746 * darwin-nat-info.c: Revert.
11747 * d-valprint.c: Revert.
11748 * d-namespace.c: Revert.
11749 * d-lang.c: Revert.
11751 * csky-tdep.c: Revert.
11752 * csky-linux-tdep.c: Revert.
11753 * cris-tdep.c: Revert.
11754 * cris-linux-tdep.c: Revert.
11755 * cp-valprint.c: Revert.
11756 * cp-support.c: Revert.
11757 * cp-namespace.c: Revert.
11758 * cp-abi.c: Revert.
11759 * corelow.c: Revert.
11760 * corefile.c: Revert.
11761 * continuations.c: Revert.
11762 * completer.h: Revert.
11763 * completer.c: Revert.
11764 * complaints.c: Revert.
11765 * coffread.c: Revert.
11766 * coff-pe-read.c: Revert.
11767 * cli-out.h: Revert.
11768 * cli-out.c: Revert.
11769 * charset.c: Revert.
11770 * c-varobj.c: Revert.
11771 * c-valprint.c: Revert.
11772 * c-typeprint.c: Revert.
11773 * c-lang.c: Revert.
11774 * buildsym.c: Revert.
11775 * buildsym-legacy.c: Revert.
11776 * build-id.h: Revert.
11777 * build-id.c: Revert.
11778 * btrace.c: Revert.
11779 * bsd-uthread.c: Revert.
11780 * breakpoint.h: Revert.
11781 * breakpoint.c: Revert.
11782 * break-catch-throw.c: Revert.
11783 * break-catch-syscall.c: Revert.
11784 * break-catch-sig.c: Revert.
11785 * blockframe.c: Revert.
11787 * bfin-tdep.c: Revert.
11788 * bfin-linux-tdep.c: Revert.
11789 * bfd-target.c: Revert.
11790 * bcache.c: Revert.
11791 * ax-general.c: Revert.
11792 * ax-gdb.h: Revert.
11793 * ax-gdb.c: Revert.
11794 * avr-tdep.c: Revert.
11796 * auto-load.c: Revert.
11797 * arm-wince-tdep.c: Revert.
11798 * arm-tdep.c: Revert.
11799 * arm-symbian-tdep.c: Revert.
11800 * arm-pikeos-tdep.c: Revert.
11801 * arm-obsd-tdep.c: Revert.
11802 * arm-nbsd-tdep.c: Revert.
11803 * arm-nbsd-nat.c: Revert.
11804 * arm-linux-tdep.c: Revert.
11805 * arm-linux-nat.c: Revert.
11806 * arm-fbsd-tdep.c: Revert.
11807 * arm-fbsd-nat.c: Revert.
11808 * arm-bsd-tdep.c: Revert.
11809 * arch-utils.c: Revert.
11810 * arc-tdep.c: Revert.
11811 * arc-newlib-tdep.c: Revert.
11812 * annotate.h: Revert.
11813 * annotate.c: Revert.
11814 * amd64-windows-tdep.c: Revert.
11815 * amd64-windows-nat.c: Revert.
11816 * amd64-tdep.c: Revert.
11817 * amd64-sol2-tdep.c: Revert.
11818 * amd64-obsd-tdep.c: Revert.
11819 * amd64-obsd-nat.c: Revert.
11820 * amd64-nbsd-tdep.c: Revert.
11821 * amd64-nbsd-nat.c: Revert.
11822 * amd64-nat.c: Revert.
11823 * amd64-linux-tdep.c: Revert.
11824 * amd64-linux-nat.c: Revert.
11825 * amd64-fbsd-tdep.c: Revert.
11826 * amd64-fbsd-nat.c: Revert.
11827 * amd64-dicos-tdep.c: Revert.
11828 * amd64-darwin-tdep.c: Revert.
11829 * amd64-bsd-nat.c: Revert.
11830 * alpha-tdep.c: Revert.
11831 * alpha-obsd-tdep.c: Revert.
11832 * alpha-nbsd-tdep.c: Revert.
11833 * alpha-mdebug-tdep.c: Revert.
11834 * alpha-linux-tdep.c: Revert.
11835 * alpha-linux-nat.c: Revert.
11836 * alpha-bsd-tdep.c: Revert.
11837 * alpha-bsd-nat.c: Revert.
11838 * aix-thread.c: Revert.
11840 * addrmap.c: Revert.
11841 * ada-varobj.c: Revert.
11842 * ada-valprint.c: Revert.
11843 * ada-typeprint.c: Revert.
11844 * ada-tasks.c: Revert.
11845 * ada-lang.c: Revert.
11846 * aarch64-tdep.c: Revert.
11847 * aarch64-ravenscar-thread.c: Revert.
11848 * aarch64-newlib-tdep.c: Revert.
11849 * aarch64-linux-tdep.c: Revert.
11850 * aarch64-linux-nat.c: Revert.
11851 * aarch64-fbsd-tdep.c: Revert.
11852 * aarch64-fbsd-nat.c: Revert.
11853 * aarch32-linux-nat.c: Revert.
11855 2019-04-05 Tom Tromey <tom@tromey.com>
11857 * ft32-tdep.c: Sort headers.
11858 * frv-tdep.c: Sort headers.
11859 * frv-linux-tdep.c: Sort headers.
11860 * frame.c: Sort headers.
11861 * frame-unwind.c: Sort headers.
11862 * frame-base.c: Sort headers.
11863 * fork-child.c: Sort headers.
11864 * findvar.c: Sort headers.
11865 * findcmd.c: Sort headers.
11866 * filesystem.c: Sort headers.
11867 * filename-seen-cache.h: Sort headers.
11868 * filename-seen-cache.c: Sort headers.
11869 * fbsd-tdep.c: Sort headers.
11870 * fbsd-nat.h: Sort headers.
11871 * fbsd-nat.c: Sort headers.
11872 * f-valprint.c: Sort headers.
11873 * f-typeprint.c: Sort headers.
11874 * f-lang.c: Sort headers.
11875 * extension.h: Sort headers.
11876 * extension.c: Sort headers.
11877 * extension-priv.h: Sort headers.
11878 * expprint.c: Sort headers.
11879 * exec.h: Sort headers.
11880 * exec.c: Sort headers.
11881 * exceptions.c: Sort headers.
11882 * event-top.c: Sort headers.
11883 * event-loop.c: Sort headers.
11884 * eval.c: Sort headers.
11885 * elfread.c: Sort headers.
11886 * dwarf2read.h: Sort headers.
11887 * dwarf2read.c: Sort headers.
11888 * dwarf2loc.c: Sort headers.
11889 * dwarf2expr.h: Sort headers.
11890 * dwarf2expr.c: Sort headers.
11891 * dwarf2-frame.c: Sort headers.
11892 * dwarf2-frame-tailcall.c: Sort headers.
11893 * dwarf-index-write.h: Sort headers.
11894 * dwarf-index-write.c: Sort headers.
11895 * dwarf-index-common.c: Sort headers.
11896 * dwarf-index-cache.h: Sort headers.
11897 * dwarf-index-cache.c: Sort headers.
11898 * dummy-frame.c: Sort headers.
11899 * dtrace-probe.c: Sort headers.
11900 * disasm.h: Sort headers.
11901 * disasm.c: Sort headers.
11902 * disasm-selftests.c: Sort headers.
11903 * dictionary.c: Sort headers.
11904 * dicos-tdep.c: Sort headers.
11905 * demangle.c: Sort headers.
11906 * dcache.h: Sort headers.
11907 * dcache.c: Sort headers.
11908 * darwin-nat.h: Sort headers.
11909 * darwin-nat.c: Sort headers.
11910 * darwin-nat-info.c: Sort headers.
11911 * d-valprint.c: Sort headers.
11912 * d-namespace.c: Sort headers.
11913 * d-lang.c: Sort headers.
11914 * ctf.c: Sort headers.
11915 * csky-tdep.c: Sort headers.
11916 * csky-linux-tdep.c: Sort headers.
11917 * cris-tdep.c: Sort headers.
11918 * cris-linux-tdep.c: Sort headers.
11919 * cp-valprint.c: Sort headers.
11920 * cp-support.c: Sort headers.
11921 * cp-namespace.c: Sort headers.
11922 * cp-abi.c: Sort headers.
11923 * corelow.c: Sort headers.
11924 * corefile.c: Sort headers.
11925 * continuations.c: Sort headers.
11926 * completer.h: Sort headers.
11927 * completer.c: Sort headers.
11928 * complaints.c: Sort headers.
11929 * coffread.c: Sort headers.
11930 * coff-pe-read.c: Sort headers.
11931 * cli-out.h: Sort headers.
11932 * cli-out.c: Sort headers.
11933 * charset.c: Sort headers.
11934 * c-varobj.c: Sort headers.
11935 * c-valprint.c: Sort headers.
11936 * c-typeprint.c: Sort headers.
11937 * c-lang.c: Sort headers.
11938 * buildsym.c: Sort headers.
11939 * buildsym-legacy.c: Sort headers.
11940 * build-id.h: Sort headers.
11941 * build-id.c: Sort headers.
11942 * btrace.c: Sort headers.
11943 * bsd-uthread.c: Sort headers.
11944 * breakpoint.h: Sort headers.
11945 * breakpoint.c: Sort headers.
11946 * break-catch-throw.c: Sort headers.
11947 * break-catch-syscall.c: Sort headers.
11948 * break-catch-sig.c: Sort headers.
11949 * blockframe.c: Sort headers.
11950 * block.c: Sort headers.
11951 * bfin-tdep.c: Sort headers.
11952 * bfin-linux-tdep.c: Sort headers.
11953 * bfd-target.c: Sort headers.
11954 * bcache.c: Sort headers.
11955 * ax-general.c: Sort headers.
11956 * ax-gdb.h: Sort headers.
11957 * ax-gdb.c: Sort headers.
11958 * avr-tdep.c: Sort headers.
11959 * auxv.c: Sort headers.
11960 * auto-load.c: Sort headers.
11961 * arm-wince-tdep.c: Sort headers.
11962 * arm-tdep.c: Sort headers.
11963 * arm-symbian-tdep.c: Sort headers.
11964 * arm-pikeos-tdep.c: Sort headers.
11965 * arm-obsd-tdep.c: Sort headers.
11966 * arm-nbsd-tdep.c: Sort headers.
11967 * arm-nbsd-nat.c: Sort headers.
11968 * arm-linux-tdep.c: Sort headers.
11969 * arm-linux-nat.c: Sort headers.
11970 * arm-fbsd-tdep.c: Sort headers.
11971 * arm-fbsd-nat.c: Sort headers.
11972 * arm-bsd-tdep.c: Sort headers.
11973 * arch-utils.c: Sort headers.
11974 * arc-tdep.c: Sort headers.
11975 * arc-newlib-tdep.c: Sort headers.
11976 * annotate.h: Sort headers.
11977 * annotate.c: Sort headers.
11978 * amd64-windows-tdep.c: Sort headers.
11979 * amd64-windows-nat.c: Sort headers.
11980 * amd64-tdep.c: Sort headers.
11981 * amd64-sol2-tdep.c: Sort headers.
11982 * amd64-obsd-tdep.c: Sort headers.
11983 * amd64-obsd-nat.c: Sort headers.
11984 * amd64-nbsd-tdep.c: Sort headers.
11985 * amd64-nbsd-nat.c: Sort headers.
11986 * amd64-nat.c: Sort headers.
11987 * amd64-linux-tdep.c: Sort headers.
11988 * amd64-linux-nat.c: Sort headers.
11989 * amd64-fbsd-tdep.c: Sort headers.
11990 * amd64-fbsd-nat.c: Sort headers.
11991 * amd64-dicos-tdep.c: Sort headers.
11992 * amd64-darwin-tdep.c: Sort headers.
11993 * amd64-bsd-nat.c: Sort headers.
11994 * alpha-tdep.c: Sort headers.
11995 * alpha-obsd-tdep.c: Sort headers.
11996 * alpha-nbsd-tdep.c: Sort headers.
11997 * alpha-mdebug-tdep.c: Sort headers.
11998 * alpha-linux-tdep.c: Sort headers.
11999 * alpha-linux-nat.c: Sort headers.
12000 * alpha-bsd-tdep.c: Sort headers.
12001 * alpha-bsd-nat.c: Sort headers.
12002 * aix-thread.c: Sort headers.
12003 * agent.c: Sort headers.
12004 * addrmap.c: Sort headers.
12005 * ada-varobj.c: Sort headers.
12006 * ada-valprint.c: Sort headers.
12007 * ada-typeprint.c: Sort headers.
12008 * ada-tasks.c: Sort headers.
12009 * ada-lang.c: Sort headers.
12010 * aarch64-tdep.c: Sort headers.
12011 * aarch64-ravenscar-thread.c: Sort headers.
12012 * aarch64-newlib-tdep.c: Sort headers.
12013 * aarch64-linux-tdep.c: Sort headers.
12014 * aarch64-linux-nat.c: Sort headers.
12015 * aarch64-fbsd-tdep.c: Sort headers.
12016 * aarch64-fbsd-nat.c: Sort headers.
12017 * aarch32-linux-nat.c: Sort headers.
12019 2019-04-04 Tom Tromey <tom@tromey.com>
12021 * varobj.c (varobj_create): Update.
12022 * rust-exp.y (struct rust_parser) <update_innermost_block,
12023 lookup_symbol>: New methods.
12024 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12026 (rust_parser::rust_lookup_type)
12027 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12028 * printcmd.c (display_command, do_one_display): Update.
12029 * parser-defs.h (struct parser_state) <parser_state>: Add
12030 "tracker" parameter.
12031 (block_tracker): New member.
12032 (class innermost_block_tracker) <innermost_block_tracker>: Add
12034 <reset>: Remove method.
12035 (innermost_block): Don't declare.
12036 (null_post_parser): Update.
12037 * parse.c (innermost_block): Remove global.
12038 (write_dollar_variable): Update.
12039 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12040 Remove "tracker_types" parameter.
12041 (parse_expression): Add "tracker" parameter.
12042 (parse_expression_for_completion): Update.
12043 (null_post_parser): Add "tracker" parameter.
12044 * p-exp.y: Update rules.
12045 * m2-exp.y: Update rules.
12046 * language.h (struct language_defn) <la_post_parser>: Add
12047 "tracker" parameter.
12048 * go-exp.y: Update rules.
12049 * f-exp.y: Update rules.
12050 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12052 * d-exp.y: Update rules.
12053 * c-exp.y: Update rules.
12054 * breakpoint.c (set_breakpoint_condition): Create an
12055 innermost_block_tracker.
12056 (watch_command_1): Likewise.
12057 * ada-lang.c (resolve): Add "tracker" parameter.
12058 (resolve_subexp): Likewise.
12059 * ada-exp.y (write_var_from_sym): Update.
12061 2019-04-04 Tom Tromey <tom@tromey.com>
12063 * type-stack.h: New file.
12064 * type-stack.c: New file.
12065 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12067 (insert_into_type_stack, insert_type, push_type, push_type_int)
12068 (insert_type_address_space, pop_type, pop_type_int)
12069 (pop_typelist, pop_type_stack, append_type_stack)
12070 (push_type_stack, get_type_stack, push_typelist)
12071 (follow_type_instance_flags, follow_types): Don't declare.
12072 * parse.c (type_stack): Remove global.
12073 (parse_exp_in_context): Update.
12074 (insert_into_type_stack, insert_type, push_type, push_type_int)
12075 (insert_type_address_space, pop_type, pop_type_int)
12076 (pop_typelist, pop_type_stack, append_type_stack)
12077 (push_type_stack, get_type_stack, push_typelist)
12078 (follow_type_instance_flags, follow_types): Remove (moved to
12080 * f-exp.y (type_stack): New global.
12082 (push_kind_type, f_parse): Update.
12083 * d-exp.y (type_stack): New global.
12086 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12088 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12089 (HFILES_NO_SRCDIR): Add type-stack.h.
12091 2019-04-04 Tom Tromey <tom@tromey.com>
12093 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12094 (rust_parser::convert_ast_to_expression, rust_parse)
12095 (rust_lex_test_completion, rust_lex_tests): Update.
12096 * parser-defs.h (struct expr_completion_state): New.
12097 (struct parser_state) <parser_state>: Add completion parameter.
12098 <mark_struct_expression, mark_completion_tag>: New methods.
12099 <parse_completion, m_completion_state>: New members.
12100 (prefixify_expression, null_post_parser): Update.
12101 (mark_struct_expression, mark_completion_tag): Don't declare.
12102 * parse.c (parse_completion, expout_last_struct)
12103 (expout_tag_completion_type, expout_completion_name): Remove
12105 (parser_state::mark_struct_expression)
12106 (parser_state::mark_completion_tag): Now methods.
12107 (prefixify_expression): Add last_struct parameter.
12108 (prefixify_subexp): Likewise.
12109 (parse_exp_1): Update.
12110 (parse_exp_in_context): Add cstate parameter. Update.
12111 (parse_expression_for_completion): Create an
12112 expr_completion_state.
12113 (null_post_parser): Add "completion" parameter.
12114 * p-exp.y: Update rules.
12116 * language.h (struct language_defn) <la_post_parser>: Add
12117 "completing" parameter.
12118 * go-exp.y: Update rules.
12119 (lex_one_token): Update.
12120 * expression.h (parse_completion): Don't declare.
12121 * d-exp.y: Update rules.
12122 (lex_one_token): Update rules.
12123 * c-exp.y: Update rules.
12124 (lex_one_token): Update.
12125 * ada-lang.c (resolve): Add "parse_completion" parameter.
12126 (resolve_subexp): Likewise.
12127 (ada_resolve_function): Likewise.
12129 2019-04-04 Tom Tromey <tom@tromey.com>
12131 * parser-defs.h (struct parser_state) <start_arglist,
12132 end_arglist>: New methods.
12133 <arglist_len, m_funcall_chain>: New members.
12134 (arglist_len, start_arglist, end_arglist): Don't declare.
12135 * parse.c (arglist_len, funcall_chain): Remove global.
12136 (start_arglist, end_arglist): Remove functions.
12137 (parse_exp_in_context): Update.
12138 * p-exp.y: Update rules.
12139 * m2-exp.y: Update rules.
12140 * go-exp.y: Update rules.
12141 * f-exp.y: Update rules.
12142 * d-exp.y: Update rules.
12143 * c-exp.y: Update rules.
12145 2019-04-04 Tom Tromey <tom@tromey.com>
12147 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12148 lex_operator, push_back>: New methods.
12150 (rust_parser::lex_hex, lex_escape): Rename and update.
12151 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12152 (rust_parser::lex_operator): Rename and update.
12153 (rust_parser::lex_number, rustyylex, rustyyerror)
12154 (rust_lex_test_init, rust_lex_test_sequence)
12155 (rust_lex_test_push_back, rust_lex_tests): Update.
12156 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12158 <lexptr, prev_lexptr>: New members.
12159 (lexptr, prev_lexptr): Don't declare.
12160 * parse.c (lexptr, prev_lexptr): Remove globals.
12161 (parse_exp_in_context): Update.
12162 * p-exp.y (yylex, yyerror): Update.
12163 * m2-exp.y (parse_number, yylex, yyerror): Update.
12164 * go-exp.y (lex_one_token, yyerror): Update.
12165 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12166 * d-exp.y (lex_one_token, yyerror): Update.
12167 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12168 (lex_one_token, yyerror): Update.
12169 * ada-lex.l (YY_INPUT): Update.
12170 (rewind_to_char): Update.
12171 * ada-exp.y (yyerror): Update.
12173 2019-04-04 Tom Tromey <tom@tromey.com>
12175 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12176 * parser-defs.h (struct parser_state) <parser_state>: Add new
12178 <comma_terminates>: New member.
12179 (comma_terminates): Don't declare global.
12180 * parse.c (comma_terminates): Remove global.
12181 (parse_exp_in_context): Update.
12182 * p-exp.y (yylex): Update.
12183 * m2-exp.y (yylex): Update.
12184 * go-exp.y (lex_one_token): Update.
12185 * f-exp.y (yylex): Update.
12186 * d-exp.y (lex_one_token): Update.
12187 * c-exp.y (lex_one_token): Update.
12188 * ada-lex.l: Update.
12190 2019-04-04 Tom Tromey <tom@tromey.com>
12192 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12193 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12194 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12195 * parser-defs.h (paren_depth): Don't declare.
12196 * parse.c (paren_depth): Remove global.
12197 (parse_exp_in_context): Update.
12198 * p-exp.y (paren_depth): New global.
12199 (pascal_parse): Initialize it.
12200 * m2-exp.y (paren_depth): New global.
12201 (m2_parse): Initialize it.
12202 * go-exp.y (paren_depth): New global.
12203 (go_parse): Initialize it.
12204 * f-exp.y (paren_depth): New global.
12205 (f_parse): Initialize it.
12206 * d-exp.y (paren_depth): New global.
12207 (d_parse): Initialize it.
12208 * c-exp.y (paren_depth): New global.
12209 (c_parse): Initialize it.
12210 * ada-lex.l (paren_depth): New global.
12211 (lexer_init): Initialize it.
12213 2019-04-04 Tom Tromey <tom@tromey.com>
12215 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12216 (rust_parser::convert_ast_to_type)
12217 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12218 * parser-defs.h (struct parser_state) <parser_state>: Add
12219 parameters. Initialize new members.
12220 <expression_context_block, expression_context_pc>: New members.
12221 * parse.c (expression_context_block, expression_context_pc):
12223 (parse_exp_in_context): Update.
12224 * p-exp.y: Update all rules.
12226 * m2-exp.y: Update all rules.
12228 * go-exp.y (yylex): Update.
12229 * f-exp.y (yylex): Update.
12230 * d-exp.y: Update all rules.
12232 * c-exp.y: Update all rules.
12233 (lex_one_token, classify_name, yylex, c_parse): Update.
12234 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12236 2019-04-04 Tom Tromey <tom@tromey.com>
12238 * gdbarch.h, gdbarch.c: Rebuild.
12239 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12241 (struct stap_parse_info): Replace "parser_state" with
12243 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12244 (parser_state): New class.
12245 * parse.c (expr_builder): Rename.
12246 (expr_builder::release): Rename.
12247 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12248 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12249 (write_exp_elt_longcst, write_exp_elt_floatcst)
12250 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12251 (write_exp_string_vector, write_exp_bitstring)
12252 (write_exp_msymbol, mark_struct_expression)
12253 (write_dollar_variable)
12254 (insert_type_address_space, increase_expout_size): Replace
12255 "parser_state" with "expr_builder".
12256 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12257 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12258 "parser_state" with "expr_builder".
12260 2019-04-04 Tom Tromey <tom@tromey.com>
12262 * rust-exp.y: Replace "parse_language" with method call.
12264 (yylex): Replace "parse_language" with method call.
12266 (yylex): Replace "parse_language" with method call.
12267 * go-exp.y (classify_name): Replace "parse_language" with method
12269 * f-exp.y (yylex): Replace "parse_language" with method call.
12270 * d-exp.y (lex_one_token): Replace "parse_language" with method
12273 (lex_one_token, classify_name, yylex): Replace "parse_language"
12275 * ada-exp.y (find_primitive_type, type_char)
12276 (type_system_address): Replace "parse_language" with method call.
12278 2019-04-04 Tom Tromey <tom@tromey.com>
12280 * rust-exp.y: Replace "parse_gdbarch" with method call.
12281 * parse.c (write_dollar_variable, insert_type_address_space):
12282 Replace "parse_gdbarch" with method call.
12283 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12285 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12287 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12288 "parse_gdbarch" with method call.
12289 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12291 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12292 "parse_gdbarch" with method call.
12293 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12294 "parse_gdbarch" with method call.
12295 * c-exp.y (parse_type, parse_number, classify_name): Replace
12296 "parse_gdbarch" with method call.
12297 * ada-lex.l: Replace "parse_gdbarch" with method call.
12298 * ada-exp.y (parse_type, find_primitive_type, type_char)
12299 (type_system_address): Replace "parse_gdbarch" with method call.
12301 2019-04-04 Tom Tromey <tom@tromey.com>
12303 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12304 * stap-probe.c (stap_parse_argument): Update.
12305 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12306 initial_size parameter.
12307 * rust-exp.y (rust_lex_tests): Update.
12308 * parse.c (parser_state): Update.
12309 (parse_exp_in_context): Update.
12310 * parser-defs.h (struct parser_state) <parser_state>: Remove
12311 "initial_size" parameter.
12313 2019-04-04 Tom Tromey <tom@tromey.com>
12315 * parser-defs.h (increase_expout_size): Don't declare.
12316 * parse.c (increase_expout_size): Now static.
12318 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12320 * gnu-nat.c (gnu_nat_target::wait): Fix
12321 target_waitstatus_to_string call.
12323 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12325 * eval.c (evaluate_subexp_standard): Handle internal functions
12326 during Fortran function call handling.
12328 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12330 * NEWS: Mention new internal functions.
12331 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12332 (read_base_type): Use dwarf2_init_complex_target_type.
12333 * value.c (creal_internal_fn): New function.
12334 (cimag_internal_fn): New function.
12335 (_initialize_values): Register new internal functions.
12337 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12339 * infrun.c (stop_all_threads): If debug_infrun, always
12340 trace the wait status after wait_one, using
12341 target_waitstatus_to_string and target_pid_to_str.
12342 (handle_inferior_event): Replace various trace of
12343 wait status kind by a single trace.
12344 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12345 wait status kind image by target_waitstatus_to_string.
12346 * target/waitstatus.c (target_waitstatus_to_string): Fix
12349 2019-04-01 Tom Tromey <tromey@adacore.com>
12352 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12354 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12355 Pedro Alves <palves@redhat.com>
12357 * top.c (quit_force): Call 'finalize_values'.
12358 * value.c (finalize_values): New function.
12359 * value.h (finalize_values): Declare.
12361 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12363 * NEWS: Announce $_gdb_major and $_gdb_minor.
12365 * top.c (init_gdb_version_vars): New function.
12366 (gdb_init): Call init_gdb_version_vars.
12368 2019-03-29 Tom Tromey <tromey@adacore.com>
12370 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12371 help text. Remove dead code.
12373 2019-03-29 Keith Seitz <keiths@redhat.com>
12375 From Siddhesh Poyarekar:
12376 * f-lang.h (f77_get_upperbound): Return LONGEST.
12377 (f77_get_lowerbound): Likewise.
12378 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12379 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12381 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12382 plongest to format print it.
12383 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12384 (f77_get_upperbound): Likewise.
12385 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12386 LOWER_BOUND to LONGEST.
12387 (f77_create_arrayprint_offset_tbl): Likewise.
12389 2019-03-29 Keith Seitz <keiths@redhat.com>
12391 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12392 %s/pulongest for TYPE_LENGTH instead of %d in format
12394 * ada-typerint.c (ada_print_type): Likewise.
12395 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12396 * compile/compile-c-support.c (generate_register_struct): Likewise.
12397 * gdbtypes.c (recursive_dump_type): Likewise.
12398 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12399 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12400 instead of %d in format strings.
12401 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12402 to std::min to ULONGEST.
12403 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12404 instead of %d in format strings.
12405 * tracepoint.c (info_scope_command): Likewise.
12406 * typeprint.c (print_offset_data::update)
12407 (print_offset_data::finish): Likewise.
12408 * xtensa-tdep.c (xtensa_store_return_value)
12409 (xtensa_push_dummy_call): Likewise.
12411 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12413 * windows-nat.c (display_selector): Fixed format specifications
12416 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12418 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12420 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12422 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12423 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12424 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12425 (nios2_linux_init_abi): Install it.
12427 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12429 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12431 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12433 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12435 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12436 Tom Tromey <tromey@adacore.com>
12438 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12440 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12442 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12443 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12444 method to compute the bounds of range types. Also print "[evaluated]"
12445 if the bounds' values come from a dynamic evaluation.
12447 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12449 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12450 whitespace when pretty printing is on.
12452 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12454 * ppc-linux-nat.c: Add include.
12456 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12458 * NEWS: Mention AArch64 Pointer Authentication.
12460 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12462 * arm-linux-nat.c: Add include.
12464 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12466 * source-cache.c (source_cache::get_source_lines): Re-read
12467 fullname after calling open_source_file.
12469 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12471 * NEWS: Mention TLS support for FreeBSD.
12473 2019-03-25 Tom Tromey <tromey@adacore.com>
12475 * minsyms.c (BUNCH_SIZE): Update comment.
12476 (~minimal_symbol_reader): Remove old comment.
12477 (compact_minimal_symbols): Update comment.
12478 (minimal_symbol_reader::install): Remove old comment. Update
12481 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12483 * s390-linux-nat.c: Add include.
12485 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12487 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12488 Call linux_get_hwcap.
12489 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12491 (aarch64_linux_get_hwcap): Remove function.
12492 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12494 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12496 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12497 * linux-tdep.c (linux_get_hwcap): Add function.
12498 (linux_get_hwcap2): Likewise.
12499 * linux-tdep.h (linux_get_hwcap): Add declaration.
12500 (linux_get_hwcap2): Likewise.
12501 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12502 (ppc_linux_get_hwcap2): Likewise.
12503 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12505 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12506 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12507 (ppc_linux_nat_target::read_description): Likewise.
12508 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12509 * s390-linux-nat.c: Likewise.
12510 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12512 2019-03-24 Tom Tromey <tom@tromey.com>
12514 * ada-lang.c (standard_lookup): Simplify initialization.
12515 (ada_lookup_symbol_nonlocal): Simplify return.
12516 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12517 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12518 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12519 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12521 * solib.c (solib_global_lookup): Simplify.
12522 * symtab.c (null_block_symbol): Remove.
12523 (symbol_cache_lookup): Simplify returns.
12524 (lookup_language_this): Simplify returns.
12525 (lookup_symbol_aux): Simplify return.
12526 (lookup_local_symbol): Simplify returns.
12527 (lookup_global_symbol_from_objfile): Simplify return.
12528 (lookup_symbol_in_objfile_symtabs)
12529 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12530 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12531 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12532 * cp-namespace.c (cp_lookup_bare_symbol)
12533 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12534 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12535 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12536 (cp_lookup_symbol_via_imports): Simplify initialization.
12537 (find_symbol_in_baseclass): Likewise.
12538 * symtab.h (null_block_symbol): Remove.
12539 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12540 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12541 (d_lookup_symbol_module): Likewise.
12542 (find_symbol_in_baseclass): Simplify initialization.
12544 2019-03-24 Tom Tromey <tom@tromey.com>
12546 * expression.h: Don't include symtab.h.
12547 (struct block): Forward declare.
12549 2019-03-24 Tom Tromey <tom@tromey.com>
12551 * c-exp.y (typebase): Remove casts.
12552 * gdbtypes.c (lookup_unsigned_typename, )
12553 (lookup_signed_typename): Remove cast.
12554 * eval.c (parse_to_comma_and_eval): Remove cast.
12555 * parse.c (write_dollar_variable): Remove cast.
12556 * block.h (struct block) <superblock>: Now const.
12557 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12558 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12559 (map_block): Make "block" const.
12560 * symfile.h (struct quick_symbol_functions)
12561 <map_matching_symbols>: Constify block argument to "callback".
12562 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12564 (find_pc_sect_compunit_symtab): Make "b" const.
12565 (find_symbol_at_address): Likewise.
12566 (search_symbols): Likewise.
12567 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12568 (dw2_debug_names_lookup_symbol): Likewise.
12569 (dw2_map_matching_symbols): Update.
12570 * p-valprint.c (pascal_val_print): Remove "block".
12571 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12572 (aux_add_nonlocal_symbols): Make "block" const.
12573 (resolve_subexp): Remove cast.
12574 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12576 (iterate_over_file_blocks): Likewise.
12577 * f-exp.y (%union) <bval>: Remove.
12578 * coffread.c (patch_opaque_types): Make "b" const.
12579 * spu-tdep.c (spu_catch_start): Make "block" const.
12580 * c-valprint.c (print_unpacked_pointer): Remove "block".
12581 * symmisc.c (dump_symtab_1): Make "b" const.
12582 (block_depth): Make "block" const.
12583 * d-exp.y (%union) <bval>: Remove.
12584 * cp-support.h (cp_lookup_rtti_type): Update.
12585 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12586 * psymtab.c (psym_lookup_symbol): Make "block" const.
12587 (maintenance_check_psymtabs): Make "b" const.
12588 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12589 (enumerate_locals, enumerate_args): Update.
12590 * python/py-symtab.c (stpy_global_block): Make "block" const.
12591 (stpy_static_block): Likewise.
12592 * inline-frame.c (block_starting_point_at): Make "new_block"
12594 * block.c (find_block_in_blockvector): Make return type const.
12595 (blockvector_for_pc_sect): Make "b" const.
12596 (find_block_in_blockvector): Make "b" const.
12598 2019-03-23 Tom Tromey <tom@tromey.com>
12600 * varobj.c (varobj_create): Update.
12601 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12602 * printcmd.c (display_command, do_one_display): Don't reset
12604 * parser-defs.h (enum innermost_block_tracker_type): Move to
12606 (innermost_block): Update comment.
12607 * parse.c (parse_exp_1): Add tracker_types parameter.
12608 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12609 tracker_types parameter. Reset innermost_block.
12610 (parse_exp_in_context): Remove.
12611 (parse_expression_for_completion): Update.
12612 * objfiles.c (~objfile): Don't reset expression_context_block or
12614 * expression.h (enum innermost_block_tracker_type): Move from
12616 (parse_exp_1): Add tracker_types parameter.
12617 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12618 reset innermost_block.
12620 2019-03-23 Tom Tromey <tom@tromey.com>
12622 * objfiles.h: Include bcache.h.
12624 2019-03-23 Tom Tromey <tom@tromey.com>
12626 * linespec.c (get_current_search_block): Use
12627 scoped_restore_current_language.
12628 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12630 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12631 Jiong Wang <jiong.wang@arm.com>
12633 * aarch64-linux-tdep.c
12634 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12636 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12638 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12639 Jiong Wang <jiong.wang@arm.com>
12641 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12643 (aarch64_analyze_prologue_test): Add PACIASP test.
12644 (aarch64_prologue_prev_register): Unmask PC value.
12646 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12647 Jiong Wang <jiong.wang@arm.com>
12649 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12650 (aarch64_dwarf2_prev_register): Unmask PC value.
12651 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12652 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12653 DW_CFA_AARCH64_negate_ra_state.
12654 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12656 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12657 Jiong Wang <jiong.wang@arm.com>
12659 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12661 (aarch64_pseudo_register_name): Likewise.
12662 (aarch64_pseudo_register_type): Likewise.
12663 (aarch64_pseudo_register_reggroup_p): Likewise.
12664 (aarch64_gdbarch_init): Add pauth registers.
12665 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12666 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12667 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12668 (struct gdbarch_tdep): Add regnum for ra_state.
12670 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12671 Jiong Wang <jiong.wang@arm.com>
12673 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12675 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12676 Jiong Wang <jiong.wang@arm.com>
12678 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12680 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12681 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12682 (aarch64_gdbarch_init): Add puth registers.
12683 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12684 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12685 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12687 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12688 Jiong Wang <jiong.wang@arm.com>
12690 * aarch64-linux-nat.c
12691 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12692 * aarch64-linux-tdep.c
12693 (aarch64_linux_core_read_description): Likewise.
12694 (aarch64_linux_get_hwcap): New function.
12695 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12696 (aarch64_linux_get_hwcap): New declaration.
12698 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12699 Jiong Wang <jiong.wang@arm.com>
12701 * aarch64-linux-nat.c
12702 (aarch64_linux_nat_target::read_description): Add pauth param.
12703 * aarch64-linux-tdep.c
12704 (aarch64_linux_core_read_description): Likewise.
12705 * aarch64-tdep.c (struct target_desc): Add in pauth.
12706 (aarch64_read_description): Add pauth param.
12707 (aarch64_gdbarch_init): Likewise.
12708 * aarch64-tdep.h (aarch64_read_description): Likewise.
12709 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12710 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12711 * features/Makefile: Add new files.
12712 * features/aarch64-pauth.c: New file.
12713 * features/aarch64-pauth.xml: New file.
12715 2019-03-20 Tom Tromey <tromey@adacore.com>
12717 * infrun.c (handle_inferior_event): Rename from
12718 handle_inferior_event_1. Create a scoped_value_mark.
12719 (handle_inferior_event): Remove.
12721 2019-03-19 Tom Tromey <tromey@adacore.com>
12723 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12724 * infrun.h (print_stop_event): Add "displays" parameter.
12725 * infrun.c (print_stop_event): Add "displays" parameter.
12727 2019-03-19 Pedro Alves <palves@redhat.com>
12729 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12730 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12731 to -1. Fix TABs vs spaces.
12732 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12733 * tui/tui-out.h (tui_ui_out) Add intro comments.
12734 <m_line, m_start_of_line>: In-class initialize, and add describing
12737 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12739 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12741 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12743 2019-03-18 Pedro Alves <palves@redhat.com>
12744 Eli Zaretskii <eliz@gnu.org>
12746 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12747 m_line and m_start_of_line.
12749 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12751 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12752 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12753 it returns a newline. This fixes a regression in TU mode, whereby
12754 the next line is output on the same screen line as the user input.
12756 2019-03-18 Tom Tromey <tromey@adacore.com>
12758 * minsyms.c (minimal_symbol_reader::install): Remove call to
12761 2019-03-18 Pedro Alves <palves@redhat.com>
12763 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12765 (apply_style): New, factored out from ...
12766 (apply_ansi_escape): ... this. Handle reverse video mode.
12767 (tui_set_reverse_mode): New function.
12768 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12769 * tui/tui-winsource.c (tui_show_source_line): Use
12770 tui_set_reverse_mode instead of setting A_STANDOUT.
12771 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12772 New setter methods.
12774 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12776 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12779 2019-03-18 Tom Tromey <tromey@adacore.com>
12781 * ada-lang.c (empty_array): Add "high" parameter.
12782 (ada_evaluate_subexp): Update.
12784 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12786 * unittests/string_view-selftests.c: Define
12787 _initialize_string_view_selftests unconditionally.
12789 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12792 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12794 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12797 * windows-nat.c (display_selector): Fix format specifiers.
12799 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12801 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12802 tui_refill_source_window instead of tui_refresh_win, to update the
12803 current execution line. This fixes redisplay of the current line
12804 when stepping through the code with "next" or "step".
12806 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12808 * source-cache.c (source_cache::get_source_lines): Call
12809 find_source_lines to initialize s->nlines. This fixes vertical
12810 scrolling of TUI source window when the DOWN arrow is pressed.
12812 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12814 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12815 linux-thread-db.c (_initialize_thread_db): Likewise.
12817 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12819 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12820 wclrtoeol in tui_show_source_line". This reverts changes made in
12821 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12823 2019-03-15 Tom Tromey <tom@tromey.com>
12825 * symtab.h (struct minimal_symbol): Derive from
12826 general_symbol_info.
12827 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12828 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12829 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12830 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12831 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12832 (MSYMBOL_SEARCH_NAME): Update.
12833 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12834 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12835 * minsyms.c (minimal_symbol_reader::record_full): Update.
12837 2019-03-15 Tom Tromey <tom@tromey.com>
12839 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12841 2019-03-15 Tom Tromey <tom@tromey.com>
12843 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12844 unique_xmalloc_ptr.
12845 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12847 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12848 (build_minimal_symbol_hash_tables)
12849 (minimal_symbol_reader::install): Update.
12851 2019-03-15 Tom Tromey <tom@tromey.com>
12853 * symtab.c (create_demangled_names_hash): Update.
12854 (symbol_set_names): Update.
12855 * objfiles.h (struct objfile_per_bfd_storage)
12856 <demangled_names_hash>: Now an htab_up.
12857 * objfiles.c (objfile_per_bfd_storage): Simplify.
12859 2019-03-15 Tom Tromey <tom@tromey.com>
12861 * objfiles.h (struct objfile_per_bfd_storage): Declare
12863 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12865 (get_objfile_bfd_data): Use new. Don't initialize
12867 (free_objfile_per_bfd_storage): Remove.
12868 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12870 2019-03-15 Tom Tromey <tom@tromey.com>
12872 * symfile.c (reread_symbols): Update.
12873 * objfiles.c (objfile::objfile): Update.
12874 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12875 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12877 (minimal_symbol_reader::install): Update.
12878 (terminate_minimal_symbol_table): Remove.
12879 * jit.c (jit_object_close_impl): Update.
12881 2019-03-15 Tom Tromey <tom@tromey.com>
12883 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12886 2019-03-15 Tom Tromey <tom@tromey.com>
12888 * objfiles.h (struct objfile_per_bfd_storage)
12889 <demangled_hash_languages>: Now a bitset.
12890 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12891 (lookup_minimal_symbol): Update.
12893 2019-03-15 Tom Tromey <tom@tromey.com>
12895 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12896 Don't return the symbol.
12897 * coffread.c (record_minimal_symbol): Use record_full.
12899 2019-03-14 Eli Zaretskii <eliz@gnu.org>
12901 The MS-Windows port of ncurses fails to switch to a color pair if
12902 one or both of the colors are the implicit default colors. This
12903 change records the default colors when TUI is initialized, and
12904 then specifies them explicitly when a color pair uses the default
12905 colors. This allows color styling in TUI mode on MS-Windows.
12907 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12909 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12910 colors in ncurses_norm_attr.
12911 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12912 "none", replace it with the default color recorded in
12915 2019-03-14 Tom Tromey <tromey@adacore.com>
12917 * source-cache.h (class source_cache) <get_source_lines>: Return
12919 * source-cache.c (source_cache::extract_lines): Handle case where
12920 first_pos==npos. Return std::string.
12921 (source_cache::get_source_lines): Update.
12923 2019-03-14 Tom Tromey <tromey@adacore.com>
12925 * NEWS: Add item for "style sources" commands.
12926 * source-cache.c (source_cache::get_source_lines): Check
12928 * cli/cli-style.c (source_styling): New global.
12929 (_initialize_cli_style): Add "style sources" commands.
12930 (show_style_sources): New function.
12931 * cli/cli-style.h (source_styling): Declare.
12933 2019-03-14 Pedro Alves <palves@redhat.com>
12934 Tom Tromey <tromey@adacore.com>
12936 * tui/tui-winsource.h (tui_refill_source_window): Declare.
12937 * tui/tui-winsource.c (tui_refill_source_window): New function,
12939 (tui_horizontal_source_scroll): ... here. Move some logic.
12940 * cli/cli-style.c (set_style_enabled): Notify new observable.
12941 * tui/tui-hooks.c (tui_redisplay_source): New function.
12942 (tui_attach_detach_observers): Attach or detach
12943 tui_redisplay_source.
12944 * observable.h (source_styling_changed): New observable.
12945 * observable.c: Define source_styling_changed observable.
12947 2019-03-13 Tom Tromey <tromey@adacore.com>
12949 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12950 (i386_gnu_nat_target::store_registers): Update.
12951 * target-debug.h (target_debug_print_std_string): New macro.
12952 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12953 * windows-tdep.c (display_one_tib): Update.
12954 * tui/tui-stack.c (tui_make_status_line): Update.
12955 * top.c (print_inferior_quit_action): Update.
12956 * thread.c (thr_try_catch_cmd): Update.
12957 (add_thread_with_info): Update.
12958 (thread_target_id_str): Update.
12959 (thr_try_catch_cmd): Update.
12960 (thread_command): Update.
12961 (thread_find_command): Update.
12962 * record-btrace.c (record_btrace_target::info_record)
12963 (record_btrace_resume_thread, record_btrace_target::resume)
12964 (record_btrace_cancel_resume, record_btrace_step_thread)
12965 (record_btrace_target::wait, record_btrace_target::wait)
12966 (record_btrace_target::wait, record_btrace_target::stop): Update.
12967 * progspace.c (print_program_space): Update.
12968 * process-stratum-target.c
12969 (process_stratum_target::thread_address_space): Update.
12970 * linux-fork.c (linux_fork_mourn_inferior)
12971 (detach_checkpoint_command, info_checkpoints_command)
12972 (linux_fork_context): Update.
12973 (linux_fork_detach): Update.
12974 (class scoped_switch_fork_info): Update.
12975 (delete_checkpoint_command): Update.
12976 * infrun.c (follow_fork_inferior): Update.
12977 (follow_fork_inferior): Update.
12978 (proceed_after_vfork_done): Update.
12979 (handle_vfork_child_exec_or_exit): Update.
12980 (follow_exec): Update.
12981 (displaced_step_prepare_throw): Update.
12982 (displaced_step_restore): Update.
12983 (start_step_over): Update.
12984 (resume_1): Update.
12985 (clear_proceed_status_thread): Update.
12987 (print_target_wait_results): Update.
12988 (do_target_wait): Update.
12989 (context_switch): Update.
12990 (stop_all_threads): Update.
12991 (restart_threads): Update.
12992 (finish_step_over): Update.
12993 (handle_signal_stop): Update.
12994 (switch_back_to_stepped_thread): Update.
12995 (keep_going_pass_signal): Update.
12996 (print_exited_reason): Update.
12997 (normal_stop): Update.
12998 * inferior.c (inferior_pid_to_str): Change return type.
12999 (print_selected_inferior): Update.
13000 (add_inferior): Update.
13001 (detach_inferior): Update.
13002 * dummy-frame.c (fprint_dummy_frames): Update.
13003 * dcache.c (dcache_info_1): Update.
13004 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13005 (btrace_fetch, btrace_clear): Update.
13006 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13007 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13009 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13010 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13011 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13012 * gdbarch.c, gdbarch.h: Rebuild.
13013 * gdbarch.sh (core_pid_to_str): Change return type.
13014 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13016 (windows_nat_target::pid_to_str): Change return type.
13017 (windows_delete_thread): Update.
13018 (windows_nat_target::attach): Update.
13019 (windows_nat_target::files_info): Update.
13020 * target-delegates.c: Rebuild.
13021 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13023 (sol_thread_target::pid_to_str): Change return type.
13024 * remote.c (class remote_target) <pid_to_str>: Change return
13026 (remote_target::pid_to_str): Change return type.
13027 (extended_remote_target::attach, remote_target::remote_stop_ns)
13028 (remote_target::remote_notif_remove_queued_reply)
13029 (remote_target::push_stop_reply, remote_target::disable_btrace):
13031 (extended_remote_target::attach): Update.
13032 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13034 (gdbsim_target::pid_to_str): Change return type.
13035 * ravenscar-thread.c (struct ravenscar_thread_target)
13036 <pid_to_str>: Change return type.
13037 (ravenscar_thread_target::pid_to_str): Change return type.
13038 * procfs.c (class procfs_target) <pid_to_str>: Change return
13040 (procfs_target::pid_to_str): Change return type.
13041 (procfs_target::attach): Update.
13042 (procfs_target::detach): Update.
13043 (procfs_target::fetch_registers): Update.
13044 (procfs_target::store_registers): Update.
13045 (procfs_target::wait): Update.
13046 (procfs_target::files_info): Update.
13047 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13048 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13050 (nto_procfs_target::pid_to_str): Change return type.
13051 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13052 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13054 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13055 (exit_lwp): Update.
13056 (attach_proc_task_lwp_callback, get_detach_signal)
13057 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13058 (linux_nat_target::resume, wait_lwp, stop_callback)
13059 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13060 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13061 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13062 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13063 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13065 (inf_ptrace_target::attach): Update.
13066 (inf_ptrace_target::files_info): Update.
13067 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13069 (go32_nat_target::pid_to_str): Change return type.
13070 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13071 (gnu_nat_target::wait): Update.
13072 (gnu_nat_target::wait): Update.
13073 (gnu_nat_target::resume): Update.
13074 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13075 (fbsd_nat_target::wait): Update.
13076 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13078 (darwin_nat_target::attach): Update.
13079 * corelow.c (class core_target) <pid_to_str>: Change return type.
13080 (core_target::pid_to_str): Change return type.
13081 * target.c (normal_pid_to_str): Change return type.
13082 (default_pid_to_str): Likewise.
13083 (target_pid_to_str): Change return type.
13084 (target_translate_tls_address): Update.
13085 (target_announce_detach): Update.
13086 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13088 (bsd_uthread_target::pid_to_str): Change return type.
13089 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13091 (bsd_kvm_target::pid_to_str): Change return type.
13092 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13094 (aix_thread_target::pid_to_str): Change return type.
13095 * target.h (struct target_ops) <pid_to_str>: Change return type.
13096 (target_pid_to_str, normal_pid_to_str): Likewise.
13097 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13099 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13101 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13103 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13105 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13107 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13110 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13112 * NEWS: Mention that the new default MI version is 3. Mention
13113 changes to the output of commands and events that deal with
13114 multi-location breakpoints.
13115 * breakpoint.c: Include "mi/mi-out.h".
13116 (print_one_breakpoint): Change output syntax if using MI version
13118 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13120 (mi_multi_location_breakpoint_output_fixed): New.
13121 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13122 (mi_cmd_fix_multi_location_breakpoint_output): New.
13123 (mi_multi_location_breakpoint_output_fixed): New.
13124 * mi/mi-cmds.c (mi_cmds): Register command
13125 -fix-multi-location-breakpoint-output.
13126 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13129 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13131 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13132 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13133 instantiate mi_ui_out based on interpreter name.
13134 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13135 * mi/mi-main.c (mi_load_progress): Likewise.
13137 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13139 * NEWS: Combine separate "New targets" sections for 8.3.
13141 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13143 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13144 (ppcfbsd_init_abi): Install gdbarch
13145 "fetch_tls_load_module_address" and "get_thread_local_address"
13148 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13150 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13151 (riscv_fbsd_init_abi): Install gdbarch
13152 "fetch_tls_load_module_address" and "get_thread_local_address"
13155 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13157 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13158 (i386fbsd_init_abi): Install gdbarch
13159 "fetch_tls_load_module_address" and "get_thread_local_address"
13162 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13164 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13165 (amd64fbsd_init_abi): Install gdbarch
13166 "fetch_tls_load_module_address" and "get_thread_local_address"
13169 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13171 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13172 (struct fbsd_pspace_data): New type.
13173 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13174 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13175 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13176 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13177 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13179 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13181 * gdbtypes.c (lookup_struct_elt): New function.
13182 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13183 * gdbtypes.h (struct struct_elt): New type.
13184 (lookup_struct_elt): New prototype.
13186 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13188 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13189 remove disabled code block.
13191 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13193 * gdbarch.sh (get_thread_local_address): New method.
13194 * gdbarch.h, gdbarch.c: Regenerate.
13195 * target.c (target_translate_tls_address): Use
13196 gdbarch_get_thread_local_address if present instead of
13197 target::get_thread_local_address.
13199 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13201 * target.h (target::get_thread_local_address): Update comment.
13203 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13205 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13206 objfile->separate_debug_objfile_backlink if not NULL.
13208 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13210 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13211 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13212 (amd64bsd_store_inferior_registers): Likewise.
13213 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13214 Enable segment base registers.
13215 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13216 PT_GETFSBASE and PT_GETGSBASE.
13217 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13219 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13220 segment base registers.
13221 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13223 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13225 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13226 Update calls to i386_target_description to add 'segments'
13228 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13229 add segment base registers.
13230 * arch/i386.c (i386_create_target_description): Add 'segments'
13231 parameter to enable segment base registers.
13232 * arch/i386.h (i386_create_target_description): Likewise.
13233 * features/i386/32bit-segments.xml: New file.
13234 * features/i386/32bit-segments.c: Generate.
13235 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13236 call to i386_target_description to add 'segments' parameter.
13237 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13238 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13239 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13240 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13241 if feature is present.
13242 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13243 Add 'segments' parameter to call to i386_target_description.
13244 (i386_target_description): Add 'segments' parameter to enable
13245 segment base registers.
13246 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13247 to call to i386_target_description.
13248 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13249 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13250 Define I386_NUM_REGS.
13251 (i386_target_description): Add 'segments' parameter to enable
13252 segment base registers.
13254 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13257 * source-cache.c: #undef open and close, to avoid unresolved
13258 externals during linking.
13260 2019-03-12 Tom Tromey <tromey@adacore.com>
13262 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13263 const. Add initializers.
13264 (_initialize_remote): Don't initialize ptid globals.
13266 2019-03-12 Pedro Alves <palves@redhat.com>
13268 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13270 2019-03-12 Pedro Alves <palves@redhat.com>
13272 * cp-name-parser.y (main): Remove unused 'len' variable.
13274 2019-03-12 Tom Tromey <tromey@adacore.com>
13276 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13277 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13279 2019-03-12 Tom Tromey <tromey@adacore.com>
13281 * linux-nat.c (iterate_over_lwps): Update.
13282 (stop_callback): Remove parameter.
13283 (stop_wait_callback, detach_callback, resume_set_callback)
13284 (select_singlestep_lwp_callback, set_ignore_sigint)
13285 (status_callback, resumed_callback, resume_clear_callback)
13286 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13288 (linux_nat_target::detach, linux_nat_target::resume)
13289 (linux_stop_and_wait_all_lwps, select_event_lwp)
13290 (linux_nat_filter_event, linux_nat_wait_1)
13291 (linux_nat_target::kill, linux_nat_target::stop)
13292 (linux_nat_target::stop): Update.
13293 (linux_nat_resume_callback): Change type.
13294 (resume_stopped_resumed_lwps, count_events_callback)
13295 (select_event_lwp_callback): Likewise.
13296 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13297 * arm-linux-nat.c (struct update_registers_data): Remove.
13298 (update_registers_callback): Change type.
13299 (arm_linux_insert_hw_breakpoint1): Update.
13300 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13302 (x86_linux_dr_set_addr): Update.
13303 (x86_linux_dr_set_control): Update.
13304 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13305 (iterate_over_lwps): Use gdb::function_view.
13306 * nat/aarch64-linux-hw-point.c (struct
13307 aarch64_dr_update_callback_param): Remove.
13308 (debug_reg_change_callback): Change type.
13309 (aarch64_notify_debug_reg_change): Update.
13310 * s390-linux-nat.c (s390_refresh_per_info): Update.
13312 2019-03-11 Tom Tromey <tromey@adacore.com>
13314 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13315 redundant assignment to "this_cu".
13317 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13319 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13321 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13323 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13325 (rank_one_type): ... this.
13327 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13329 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13331 (rank_one_type): ... this.
13333 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13335 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13337 (rank_one_type): ... this.
13339 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13341 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13343 (rank_one_type): ... this.
13345 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13347 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13349 (rank_one_type): ... this.
13351 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13353 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13355 (rank_one_type): ... this.
13357 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13359 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13361 (rank_one_type): ... this.
13363 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13365 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13367 (rank_one_type): ... this.
13369 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13371 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13373 (rank_one_type): ... this.
13375 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13377 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13379 (rank_one_type): ... this.
13381 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13383 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13385 (rank_one_type): ... this.
13387 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13389 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13391 (rank_one_type): ... this.
13393 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13395 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13396 inferior-events' shows the example events.
13398 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13400 Support styling on native MS-Windows console
13403 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13404 on MS-Windows if $TERM is not defined.
13406 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13408 * posix-hdep.c (gdb_console_fputs):
13409 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13411 * ui-file.h (gdb_console_fputs): Add prototype.
13413 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13414 back to fputs only if the former returns zero.
13416 2019-03-07 Tom Tromey <tom@tromey.com>
13418 * symmisc.c (print_symbol_bcache_statistics): Update.
13419 (print_objfile_statistics): Update.
13420 * symfile.c (allocate_symtab): Update.
13421 * stabsread.c: Don't include bcache.h.
13422 * psymtab.h (struct psymbol_bcache): Don't declare.
13423 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13424 (psymbol_bcache_init, psymbol_bcache_free)
13425 (psymbol_bcache_get_bcache): Don't declare.
13426 * psymtab.c (struct psymbol_bcache): Remove.
13427 (psymtab_storage::psymtab_storage): Update.
13428 (psymtab_storage::~psymtab_storage): Update.
13429 (psymbol_bcache_init, psymbol_bcache_free)
13430 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13431 (add_psymbol_to_bcache): Update.
13432 (allocate_psymtab): Update.
13433 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13434 macro_cache>: No longer pointers.
13435 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13436 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13437 * macrotab.c (macro_bcache): Update.
13438 * macroexp.c: Don't include bcache.h.
13439 * gdbtypes.c (check_types_worklist): Update.
13440 (types_deeply_equal): Remove TRY/CATCH. Update.
13441 * elfread.c (elf_symtab_read): Update.
13442 * dwarf2read.c: Don't include bcache.h.
13443 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13444 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13445 (print_bcache_statistics, bcache_memory_used): Don't declare.
13446 (struct bcache): Move from bcache.c. Add constructor, destructor,
13447 methods. Rename all data members.
13448 * bcache.c (struct bcache): Move to bcache.h.
13449 (bcache::expand_hash_table): Rename from expand_hash_table.
13451 (bcache::insert): Rename from bcache_full.
13452 (bcache::compare): Rename from bcache_compare.
13453 (bcache_xmalloc): Remove.
13454 (bcache::~bcache): Rename from bcache_xfree.
13455 (bcache::print_statistics): Rename from print_bcache_statistics.
13456 (bcache::memory_used): Rename from bcache_memory_used.
13458 2019-03-07 Pedro Alves <palves@redhat.com>
13460 * infrun.c (normal_stop): Also check for
13461 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13463 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13465 * f-lang.c (value_from_host_double): Moved to...
13466 * value.c (value_from_host_double): ...here.
13467 * value.h (value_from_host_double): Declare.
13468 * guile/scm-math.c (vlscm_convert_typed_number): Use
13469 value_from_host_double.
13470 (vlscm_convert_number): Likewise.
13471 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13472 * python/py-value.c (convert_value_from_python): Likewise.
13474 2019-03-06 Tom Tromey <tom@tromey.com>
13476 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13478 2019-03-06 Tom Tromey <tom@tromey.com>
13480 * utils.h (free_current_contents): Don't declare.
13481 * utils.c (free_current_contents): Remove.
13483 2019-03-06 Tom Tromey <tom@tromey.com>
13485 * top.c (quit_force): Update.
13486 * main.c (captured_command_loop): Update.
13487 * common/new-op.c (operator new): Update.
13488 * common/common-exceptions.c (struct catcher)
13489 <save_cleanup_chain>: Remove member.
13490 (exceptions_state_mc_init): Update.
13491 (exception_try_scope_entry): Return nullptr.
13492 (exception_try_scope_exit, exception_rethrow)
13493 (throw_exception_sjlj, throw_exception_cxx): Update.
13494 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13495 (all_cleanups, do_cleanups, discard_cleanups)
13496 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13497 (restore_cleanups, restore_final_cleanups): Don't declare.
13498 (do_final_cleanups): Remove parameter.
13499 * common/cleanups.c (cleanup_chain, make_cleanup)
13500 (make_cleanup_dtor, all_cleanups, do_cleanups)
13501 (discard_my_cleanups, discard_cleanups)
13502 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13503 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13504 (null_cleanup): Remove.
13505 (do_final_cleanups): Remove parameter.
13507 2019-03-06 Tom Tromey <tom@tromey.com>
13509 * remote.c (remote_target::remote_parse_stop_reply): Use
13510 unique_xmalloc_ptr.
13512 2019-03-06 Tom Tromey <tom@tromey.com>
13514 * stabsread.c (struct stabs_field_info): Rename from field_info.
13515 <list, fnlist>: Add initializers.
13516 <obstack>: New member.
13517 (read_member_functions, read_struct_fields, read_baseclasses):
13518 Allocate on obstack. Don't use cleanups.
13519 (read_one_struct_field, read_member_functions, read_struct_fields)
13520 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13521 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13522 (read_struct_type): Update.
13524 2019-03-06 Tom Tromey <tom@tromey.com>
13526 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13527 * common/filestuff.h (make_cleanup_close): Don't declare.
13528 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13531 2019-03-06 Tom Tromey <tom@tromey.com>
13533 * solib-aix.c: Use make_scope_exit.
13535 2019-03-06 Tom Tromey <tom@tromey.com>
13537 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13538 Use make_scope_exit.
13540 2019-03-06 Tom Tromey <tom@tromey.com>
13542 * solib-svr4.c (disable_probes_interface): Remove parameter.
13543 (svr4_handle_solib_event): Use make_scope_exit.
13545 2019-03-06 Tom Tromey <tom@tromey.com>
13547 * remote.c (struct stop_reply_deleter): Remove.
13548 (stop_reply_up): Update.
13549 (struct stop_reply): Derive from notif_event. Don't typedef.
13550 <regcache>: Now a std::vector.
13551 (stop_reply_xfree): Remove.
13552 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13553 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13554 (remote_target::discard_pending_stop_replies): Use delete.
13555 (remote_target::remote_parse_stop_reply): Update.
13556 (remote_target::process_stop_reply): Update.
13557 * remote-notif.h (struct notif_event): Add virtual destructor.
13558 Remove "dtr" member.
13559 (struct notif_client) <alloc_event>: Return a unique_ptr.
13560 (notif_event_xfree): Don't declare.
13561 (notif_event_up): New typedef.
13562 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13563 (notif_event_xfree, do_notif_event_xfree): Remove.
13564 (remote_notif_state_xfree): Update.
13566 2019-03-06 Tom Tromey <tom@tromey.com>
13568 * infrun.c (displaced_step_clear_cleanup): Now a
13569 forward_scope_exit type.
13570 (displaced_step_prepare_throw): Update.
13571 (displaced_step_fixup): Update.
13573 2019-03-06 Tom Tromey <tom@tromey.com>
13575 * inferior.h (class inferior): Update comment.
13576 * gdbthread.h (class thread_info): Update comment.
13578 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13579 Tom Tromey <tom@tromey.com>
13581 * stabsread.h (struct stab_section_list): Remove.
13582 (coffstab_build_psymtabs): Update.
13583 * dbxread.c (symbuf_sections): Now a std::vector.
13584 (sect_idx): New global.
13585 (fill_symbuf): Update.
13586 (coffstab_build_psymtabs): Change type of stabsects parameter.
13588 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13590 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13591 (coff_locate_sections): Update.
13592 (coff_symfile_read): Remove cleanups. Update.
13593 (init_stringtab): Add storage parameter.
13594 (free_stringtab, free_stringtab_cleanup): Remove.
13595 (init_lineno): Add storage parameter.
13596 (free_linetab, free_linetab_cleanup): Remove.
13598 2019-03-06 Pedro Alves <palves@redhat.com>
13600 * linux-fork.c (fork_info::clobber_regs): Delete.
13601 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13602 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13604 (scoped_switch_fork_info::scoped_switch_fork_info)
13605 (checkpoint_command, linux_fork_context): Adjust
13606 fork_save_infrun_state calls.
13608 2019-03-06 Pedro Alves <palves@redhat.com>
13610 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13611 (inf_has_multiple_threads): Return 'bool' and rewrite using
13612 inferior_info::threads().
13614 2019-03-06 Pedro Alves <palves@redhat.com>
13616 * linux-fork.c: Include <list>.
13617 (fork_list): Now a std::list instance.
13618 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13619 (forks_exist_p, find_last_fork): Adjust.
13620 (new_fork): Delete.
13622 (add_fork): Adjust.
13623 (free_fork): Delete, folded into fork_info::~fork_info().
13624 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13626 (init_fork_list): Delete.
13627 (linux_fork_killall, linux_fork_mourn_inferior)
13628 (linux_fork_detach, info_checkpoints_command): Adjust.
13629 (_initialize_linux_fork): No longer call init_fork_list.
13631 2019-03-06 Pedro Alves <palves@redhat.com>
13633 * linux-fork.c (new_fork): New, split out of ...
13634 (add_fork): ... this. Return void. Move "first fork" special
13635 case from here, to ...
13636 (checkpoint_command): ... here.
13637 * linux-linux.h (add_fork): Return void.
13639 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13641 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13643 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13644 Chris January <chris.january@arm.com>
13645 David Lecomber <david.lecomber@arm.com>
13647 * f-exp.y: New token, UNOP_INTRINSIC.
13648 (exp): New pattern using UNOP_INTRINSIC token.
13649 (f77_keywords): Add 'abs' keyword.
13650 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13651 (value_from_host_double): New function.
13652 (evaluate_subexp_f): Support UNOP_ABS.
13654 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13656 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13659 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13661 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13662 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13663 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13665 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13667 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13669 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13670 Chris January <chris.january@arm.com>
13672 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13673 * f-exp.y: Define 'KIND' token.
13674 (exp): New pattern for KIND expressions.
13675 (ptype): Handle types with a kind extension.
13676 (direct_abs_decl): Extend to spot kind extensions.
13677 (f77_keywords): Add 'kind' to the list.
13678 (push_kind_type): New function.
13679 (convert_to_kind_type): New function.
13680 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13681 * parse.c (operator_length_standard): Likewise.
13682 * parser-defs.h (enum type_pieces): Add tp_kind.
13683 * std-operator.def: Add UNOP_KIND.
13685 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13687 * f-exp.y (f_parse): Set yydebug.
13689 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13691 * f-lang.c (evaluate_subexp_f): New function.
13692 (exp_descriptor_f): New global.
13693 (f_language_defn): Use exp_descriptor_f instead of
13694 exp_descriptor_standard.
13696 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13698 * f-exp.y (struct token): Add comments.
13699 (dot_ops): Remove uppercase versions and the end marker.
13700 (f77_keywords): Likewise.
13701 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13702 entries in the dot_ops array are case insensitive, and use
13703 strncasecmp to compare strings. Also some whitespace cleanup in
13704 this area. Similar for the f77_keywords array, except entries in
13705 this list might be case sensitive.
13707 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13709 * f-exp.y (struct f77_boolean_val): Add comments.
13710 (boolean_values): Remove uppercase versions, and end marker.
13711 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13712 and use strncasecmp to achieve case insensitivity. Additionally,
13713 perform whitespace cleanup around this code.
13715 2019-03-06 Tom Tromey <tromey@adacore.com>
13717 * remote-sim.c (gdbsim_target_open): Use result of
13720 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13721 Dirk Schubert <dirk.schubert@arm.com>
13722 Chris January <chris.january@arm.com>
13724 * eval.c (evaluate_subexp_standard): Call Fortran argument
13726 * f-lang.c (struct value): A value which can be passed into a
13727 Fortran function call.
13728 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13730 (struct type): Value ready for a Fortran function call.
13731 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13733 * f-lang.h (fortran_argument_convert): Declaration.
13734 (fortran_preserve_arg_pointer): Declaration.
13735 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13737 2019-03-05 Tom Tromey <tromey@adacore.com>
13739 * python/py-prettyprint.c (print_string_repr): Remove #if.
13740 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13742 2019-03-05 Tom Tromey <tromey@adacore.com>
13744 * target.c (the_dummy_target): Move later. Change type to
13746 (initialize_targets): Don't initialize the_dummy_target.
13748 2019-03-05 Tom Tromey <tromey@adacore.com>
13750 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13751 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13753 2019-03-05 Tom Tromey <tromey@adacore.com>
13755 * windows-nat.c (windows_nat_target::attach)
13756 (windows_nat_target::detach): Don't call gdb_flush.
13757 * valprint.c (generic_val_print, val_print, val_print_string):
13758 Don't call gdb_flush.
13759 * utils.c (defaulted_query): Don't call gdb_flush.
13760 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13761 * target.c (target_announce_detach): Don't call gdb_flush.
13762 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13763 * remote.c (extended_remote_target::attach): Don't call
13765 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13766 * printcmd.c (do_examine): Don't call gdb_flush.
13767 (info_display_command): Don't call gdb_flush.
13768 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13769 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13770 * memattr.c (info_mem_command): Don't call gdb_flush.
13771 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13772 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13773 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13774 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13775 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13776 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13777 (gnu_nat_target::detach): Don't call gdb_flush.
13778 * f-valprint.c (f_val_print): Don't call gdb_flush.
13779 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13780 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13781 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13783 * c-valprint.c (c_val_print): Don't call gdb_flush.
13784 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13786 2019-03-05 Tom Tromey <tromey@adacore.com>
13788 * varobj.c (update_dynamic_varobj_children): Update.
13789 (install_default_visualizer): Use reset, not release.
13790 * value.c (set_internalvar): Update.
13791 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13792 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13793 ATTRIBUTE_UNUSED_RESULT.
13795 2019-03-05 Tom Tromey <tromey@adacore.com>
13797 * remote.c (class scoped_remote_fd) <release>: Add
13798 ATTRIBUTE_UNUSED_RESULT.
13800 2019-03-05 Tom Tromey <tromey@adacore.com>
13802 * macroexp.c (struct macro_buffer) <release>: Add
13803 ATTRIBUTE_UNUSED_RESULT.
13805 2019-03-05 Tom Tromey <tromey@adacore.com>
13807 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13808 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13809 ATTRIBUTE_UNUSED_RESULT.
13811 2019-03-05 Tom Tromey <tromey@adacore.com>
13813 * common/scoped_fd.h (class scoped_fd) <release>: Add
13814 ATTRIBUTE_UNUSED_RESULT.
13816 2019-03-05 Tom Tromey <tromey@adacore.com>
13818 * parser-defs.h (struct parser_state) <release>: Add
13819 ATTRIBUTE_UNUSED_RESULT.
13821 2019-03-05 Tom Tromey <tromey@adacore.com>
13823 * utils.h (class gdb_argv) <release>: Add
13824 ATTRIBUTE_UNUSED_RESULT.
13825 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13827 2019-03-02 Eli Zaretskii <eliz@gnu.org>
13829 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13830 for-loop range, to avoid compiler warnings.
13832 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13833 avoid compiler warnings about unused variables.
13835 * NEWS: Mention end of support for native debugging on MS-Windows
13839 * common/netstuff.c:
13840 * gdbserver/gdbreplay.c
13841 * gdbserver/remote-utils.c:
13843 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13844 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13845 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13846 'getaddrinfo' and 'freeaddrinfo' were not available before
13847 Windows XP, and mingw.org's MinGW headers by default define
13848 _WIN32_WINNT to 0x500.
13850 2019-03-01 Gary Benson <gbenson@redhat.com>
13852 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13854 2019-02-28 Brian Vandenberg <phantall@gmail.com>
13855 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13858 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13859 set_sigint_trap, clear_sigint_trap.
13861 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13863 * target.c (target_detach): Clear the regcache and the
13866 2019-02-27 Pedro Alves <palves@redhat.com>
13868 * utils.c (set_screen_size): When we cap the height/width sizes,
13869 tweak the corresponding command variable to show "unlimited":
13871 2019-02-27 Saagar Jha <saagar@saagarjha.com>
13872 Pedro Alves <palves@redhat.com>
13874 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13875 before calling rl_set_screen_size.
13877 2019-02-27 Tom Tromey <tromey@adacore.com>
13879 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13881 * python/py-value.c: Remove Python 2.4 workaround.
13882 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13884 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13885 Python 2.4 workaround.
13886 * python/python-internal.h: Remove Python 2.4 comment.
13887 (Py_ssize_t): Don't define.
13888 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13889 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13890 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13891 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13892 * python/python.c (do_start_initialization): Remove Python 2.4
13894 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13895 (print_children): Remove Python 2.4 workaround.
13896 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13898 (CHARBUFFERPROC_NAME): Remove.
13899 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13900 Python 2.4 workaround.
13902 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13904 * NEWS: Note minimum Python version.
13906 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13908 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13909 code from these functions. Remove corresponding ifdefs. Use
13910 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13911 Remove gotos and target of gotos.
13912 (infpy_search_memory): Likewise.
13914 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13916 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13917 (hppa_gdbarch_init): Don't register deleted functions with
13920 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13922 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13923 (h8300_unwind_sp): Delete.
13924 (h8300_dummy_id): Delete.
13925 (h8300_gdbarch_init): Don't register deleted functions with
13928 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13930 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13931 (ft32_unwind_pc): Delete.
13932 (ft32_unwind_sp): Delete.
13933 (ft32_gdbarch_init): Don't register deleted functions with
13936 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13938 * gdb/frv-tdep.c (frv_dummy_id): Delete.
13939 (frv_unwind_pc): Delete.
13940 (frv_unwind_sp): Delete.
13941 (frv_gdbarch_init): Don't register deleted functions with
13944 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13946 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13947 (riscv_unwind_pc): Delete.
13948 (riscv_unwind_sp): Delete.
13949 (riscv_gdbarch_init): Don't register deleted functions with
13952 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13954 * gdb/csky-tdep.c (csky_dummy_id): Delete.
13955 (csky_unwind_pc): Delete.
13956 (csky_unwind_sp): Delete.
13957 (csky_gdbarch_init): Don't register deleted functions with
13960 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13962 * gdb/cris-tdep.c (cris_dummy_id): Delete.
13963 (cris_unwind_pc): Delete.
13964 (cris_unwind_sp): Delete.
13965 (cris_gdbarch_init): Don't register deleted functions with
13968 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13970 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13971 (bfin_unwind_pc): Delete.
13972 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13974 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13976 * gdb/arm-tdep.c (arm_dummy_id): Delete.
13977 (arm_unwind_pc): Delete.
13978 (arm_unwind_sp): Delete.
13979 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13981 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13983 * gdb/arc-tdep.c (arc_dummy_id): Delete.
13984 (arc_unwind_pc): Delete.
13985 (arc_unwind_sp): Delete.
13986 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13988 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13990 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13991 (alpha_unwind_pc): Delete.
13992 (alpha_gdbarch_init): Don't register deleted functions with
13995 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13997 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13998 (aarch64_unwind_pc): Delete.
13999 (aarch64_unwind_sp): Delete.
14000 (aarch64_gdbarch_init): Don't register deleted functions with
14003 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14005 * gdbtypes.c (type_align): Don't consider static members when
14006 computing structure alignment.
14008 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14010 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14011 return 0 for other types.
14012 * arch-utils.c (default_type_align): Always return 0.
14013 * gdbarch.h: Regenerate.
14014 * gdbarch.sh (type_align): Extend comment.
14015 * gdbtypes.c (type_align): Add additional comments, always call
14016 gdbarch_type_align before applying the default rules.
14017 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14018 generic code will then apply a suitable default.
14019 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14020 types, return 0 for other types.
14022 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14024 * NEWS: Create a new section for the next release branch.
14025 Rename the section of the current branch, now that it has
14028 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14030 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14031 * version.in: Bump version to 8.3.50.DATE-git.
14033 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14035 * aix-thread.c (ptid_cmp): Remove unused variable.
14036 (get_signaled_thread): Likewise.
14037 (store_regs_user_thread): Likewise.
14038 (store_regs_kernel_thread): Likewise.
14039 (fetch_regs_kernel_thread): Remove shadowed variable.
14041 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14043 * features/riscv/32bit-cpu.xml: Add register numbers.
14044 * features/riscv/32bit-fpu.c: Regenerate.
14045 * features/riscv/32bit-fpu.xml: Add register numbers.
14046 * features/riscv/64bit-cpu.xml: Add register numbers.
14047 * features/riscv/64bit-fpu.c: Regenerate.
14048 * features/riscv/64bit-fpu.xml: Add register numbers.
14050 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14052 * NEWS: Mention two argument form of gdb.Value constructor.
14053 * python/py-value.c (convert_buffer_and_type_to_value): New
14055 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14056 Add support for handling an optional second argument. Call
14057 convert_buffer_and_type_to_value as appropriate.
14058 * python/python-internal.h (Py_buffer_deleter): New struct.
14059 (Py_buffer_up): New typedef.
14061 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14063 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14064 instead of releasing ownership.
14066 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14068 * dwarf2read.c (open_and_init_dwp_file): Call
14069 elf_numsections instead of bfd_count_sections to initialize
14070 dwp_file->num_sections.
14072 2019-02-25 Tom Tromey <tromey@adacore.com>
14074 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14076 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14078 * gcore.in: Add '--readnever' option when invoking GDB.
14080 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14082 * MAINTAINERS: Update my email address.
14084 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14086 * build-id.c (build_id_to_debug_bfd_1): New function.
14087 (build_id_to_debug_bfd): Look for separate debug file in
14090 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14092 * gdbarch.sh: Update the copyright year range that is placed into
14095 2019-02-22 Keith Seitz <keiths@redhat.com>
14098 * linespec.c (create_sals_line_offset): Search for the default
14099 symtab's filename instead of its fullname.
14101 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14103 * NEWS: Update style defaults.
14105 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14107 * main.c (captured_main_1): Disable styling in batch mode.
14109 2019-02-20 Tom Tromey <tom@tromey.com>
14111 * symtab.c (symtab_symbol_info): Fix typos.
14113 2019-02-20 Tom Tromey <tromey@adacore.com>
14115 * findcmd.c (_initialize_mem_search): Use upper case for
14116 metasyntactic variables.
14118 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14120 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14121 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14123 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14125 * top.h (source_file_name): Change to std::string.
14126 * top.c (source_file_name): Likewise.
14127 (command_line_input): Adjust.
14128 * cli/cli-script.c (script_from_file): Adjust.
14130 2019-02-19 Tom Tromey <tromey@adacore.com>
14132 * ravenscar-thread.c
14133 (ravenscar_thread_target::update_thread_list): Don't call
14134 ada_build_task_list.
14135 * ada-lang.h (ada_build_task_list): Don't declare.
14136 * ada-tasks.c (struct ada_tasks_inferior_data)
14137 <task_list_valid_p>: Now bool.
14138 (read_known_tasks, ada_task_list_changed)
14139 (ada_tasks_invalidate_inferior_data): Update.
14140 (read_known_tasks_array): Return bool.
14141 (read_known_tasks_list): Likewise.
14142 (read_known_tasks): Return void.
14143 (ada_build_task_list): Now static.
14145 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14147 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14148 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14150 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14152 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14153 variant for ada_tasks_pspace_data_handle and
14154 ada_tasks_inferior_data_handle.
14155 (ada_tasks_pspace_data_cleanup): New function.
14156 (ada_tasks_inferior_data_cleanup): New function.
14158 2019-02-17 Tom Tromey <tom@tromey.com>
14160 * macrotab.h (macro_source_fullname): Return a std::string.
14161 * macrotab.c (macro_include, check_for_redefinition)
14162 (macro_undef, macro_lookup_definition, foreach_macro)
14163 (foreach_macro_in_scope): Update.
14164 (macro_source_fullname): Return a std::string.
14165 * macrocmd.c (show_pp_source_pos): Update.
14167 2019-02-17 Tom Tromey <tom@tromey.com>
14169 * macrocmd.c (show_pp_source_pos): Style the file names.
14171 2019-02-17 Tom Tromey <tom@tromey.com>
14174 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14176 2019-02-17 Tom Tromey <tom@tromey.com>
14178 * ada-lang.c (user_select_syms): Use filtered printing.
14179 * utils.c (wrap_style): New global.
14180 (desired_style): Remove.
14181 (emit_style_escape): Add stream parameter.
14182 (set_output_style, reset_terminal_style, prompt_for_continue):
14184 (flush_wrap_buffer): Only flush gdb_stdout.
14185 (wrap_here): Set wrap_style.
14186 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14187 treat escape sequences as a character. Change when wrap buffer is
14189 (fputs_styled): Do not set the output style when the default is
14191 * ui-style.h (struct ui_file_style) <is_default>: New method.
14192 * source.c (print_source_lines_base): Emit escape sequences in one
14195 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14197 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14198 integers and enumeration types.
14200 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14202 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14203 instead of lookup_symbol_in_language
14204 (do_exact_match): New function.
14205 (ada_get_symbol_name_matcher): Return do_exact_match when
14206 doing a verbatim match.
14208 2019-02-15 Tom Tromey <tromey@adacore.com>
14210 * ravenscar-thread.c (ravenscar_thread_target::resume)
14211 (ravenscar_thread_target::wait): Special case wildcard requests.
14213 2019-02-15 Tom Tromey <tromey@adacore.com>
14215 * ravenscar-thread.c (base_ptid): Remove.
14216 (struct ravenscar_thread_target) <close>: New method.
14217 <m_base_ptid>: New member.
14218 <update_inferior_ptid, active_task, task_is_currently_active,
14219 runtime_initialized>: Declare methods.
14220 <ravenscar_thread_target>: Add constructor.
14221 (ravenscar_thread_target::task_is_currently_active)
14222 (ravenscar_thread_target::update_inferior_ptid)
14223 (ravenscar_runtime_initialized): Rename. Now methods.
14224 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14225 (ravenscar_thread_target::update_thread_list): Update.
14226 (ravenscar_thread_target::active_task): Now method.
14227 (ravenscar_thread_target::store_registers)
14228 (ravenscar_thread_target::prepare_to_store)
14229 (ravenscar_thread_target::prepare_to_store)
14230 (ravenscar_thread_target::mourn_inferior): Update.
14231 (ravenscar_inferior_created): Use "new" to create target.
14232 (ravenscar_thread_target::get_ada_task_ptid): Update.
14233 (_initialize_ravenscar): Don't initialize base_ptid.
14234 (ravenscar_ops): Remove global.
14236 2019-02-15 Tom Tromey <tromey@adacore.com>
14238 * target.h (push_target): Declare new overload.
14239 * target.c (push_target): New overload, taking an rvalue reference.
14240 * remote.c (remote_target::open_1): Use push_target overload.
14241 * corelow.c (core_target_open): Use push_target overload.
14243 2019-02-15 Tom Tromey <tromey@adacore.com>
14245 * ravenscar-thread.c (is_ravenscar_task)
14246 (ravenscar_task_is_currently_active): Return bool.
14247 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14248 (_initialize_ravenscar): Remove "(void)".
14249 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14252 2019-02-15 Tom Tromey <tromey@adacore.com>
14254 * ravenscar-thread.c (ravenscar_runtime_initializer)
14255 (has_ravenscar_runtime, get_running_thread_id)
14256 (ravenscar_thread_target::resume): Fix indentation.
14258 2019-02-15 Tom Tromey <tromey@adacore.com>
14260 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14261 from ravenscar_arch_ops.
14262 (sparc_ravenscar_ops::fetch_registers)
14263 (sparc_ravenscar_ops::store_registers): Now methods.
14264 (sparc_ravenscar_prepare_to_store): Remove.
14265 (sparc_ravenscar_ops): Redefine.
14266 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14267 methods and destructor. Remove members.
14268 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14269 (ravenscar_thread_target::store_registers)
14270 (ravenscar_thread_target::prepare_to_store): Update.
14271 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14273 (struct ppc_ravenscar_powerpc_ops): Derive from
14274 ravenscar_arch_ops.
14275 (ppc_ravenscar_powerpc_ops::fetch_registers)
14276 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14277 (ppc_ravenscar_powerpc_ops): Redefine.
14278 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14279 (ppc_ravenscar_e500_ops::fetch_registers)
14280 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14281 (ppc_ravenscar_e500_ops): Redefine.
14282 * aarch64-ravenscar-thread.c
14283 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14284 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14285 (aarch64_ravenscar_fetch_registers)
14286 (aarch64_ravenscar_store_registers): Now methods.
14287 (aarch64_ravenscar_ops): Redefine.
14289 2019-02-15 Tom Tromey <tromey@adacore.com>
14291 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14292 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14293 (ravenscar_thread_target::stopped_by_watchpoint)
14294 (ravenscar_thread_target::stopped_data_address)
14295 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14297 2019-02-15 Tom Tromey <tromey@adacore.com>
14299 * ravenscar-thread.c: Fix some typos.
14301 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14302 Tom Tromey <tromey@adacore.com>
14304 * ada-lang.c (ada_exception_sal): Change addr_string to a
14306 (create_ada_exception_catchpoint): Update.
14308 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14309 Tom Tromey <tromey@adacore.com>
14311 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14312 (bp_location_ops): Remove.
14313 (base_breakpoint_allocate_location): Update.
14314 (free_bp_location): Update.
14315 * ada-lang.c (class ada_catchpoint_location)
14316 <ada_catchpoint_location>: Remove ops parameter.
14317 (ada_catchpoint_location_dtor): Remove.
14318 (ada_catchpoint_location_ops): Remove.
14319 (allocate_location_exception): Update.
14320 * breakpoint.h (struct bp_location_ops): Remove.
14321 (class bp_location) <bp_location>: Remove bp_location_ops
14323 <~bp_location>: Add destructor.
14326 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14327 Pedro Alves <palves@redhat.com>
14329 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14332 2019-02-14 David Michael <fedora.dm0@gmail.com>
14333 Samuel Thibault <samuel.thibault@gnu.org>
14334 Thomas Schwinge <thomas@codesourcery.com>
14336 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14337 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14339 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14341 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14342 (check_empty): Use "const char *".
14344 * gnu-nat.c (gnu_nat_target::detach): Instead of
14345 'detach_inferior (pid)' call
14346 'detach_inferior (find_inferior_pid (pid))'.
14348 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14349 'nat/fork-inferior.o'.
14350 * gnu-nat.c: #include "nat/fork-inferior.h".
14352 * gnu-nat.c (gnu_nat_target::detach): Instead of
14353 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14354 * gnu-nat.h: #include "inf-child.h".
14355 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14356 'i386_gnu_nat_target::fetch_registers'.
14357 (gnu_store_registers): Rename/move to
14358 'i386_gnu_nat_target::store_registers'.
14360 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14361 * gnu-nat.h (mach_thread_info): New function.
14362 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14364 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14366 2019-02-14 Frederic Konrad <konrad@adacore.com>
14368 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14370 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14372 * windows-nat.c (windows_add_thread): Add new parameter
14373 "main_thread_p" with default value set to false. Update
14374 function documentation as well as all callers.
14375 (windows_delete_thread): Likewise.
14376 (fake_create_process): Update call to windows_add_thread.
14377 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14378 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14379 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14380 call to windows_delete_thread.
14382 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14384 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14386 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14388 * symfile.c (find_separate_debug_file): Use canonical path of
14389 sysroot with child_path instead of gdb_sysroot if it is valid.
14391 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14393 * symfile.c (find_separate_debug_file): Use child_path to
14394 determine if an object file is under a sysroot.
14396 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14398 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14399 unittests/child-path-selftests.c.
14400 * common/pathstuff.c (child_path): New function.
14401 * common/pathstuff.h (child_path): New prototype.
14402 * unittests/child-path-selftests.c: New file.
14404 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14406 * symfile.c (find_separate_debug_file): Look for separate debug
14407 files in debug directories under the sysroot.
14409 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14411 * symtab.h (struct minimal_symbol data_p): New const method.
14412 (struct minimal_symbol text_p): Likewise.
14413 * symtab.c (output_source_filename): Use file name style
14414 to print file name.
14415 (print_symbol_info): Likewise.
14416 (print_msymbol_info): Use address style to print addresses.
14417 Use function name style to print executable text symbols.
14418 (expand_symtab_containing_pc): Use data_p.
14419 (find_pc_sect_compunit_symtab): Likewise.
14421 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14423 * breakpoint.c (describe_other_breakpoints): Use address style
14424 to print addresses.
14425 (say_where): Likewise.
14427 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14429 * ada-typeprint.c (print_func_type): Print function name
14430 style to print function name.
14431 * c-typeprint.c (c_print_type_1): Likewise.
14433 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14435 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14438 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14440 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14443 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14445 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14446 TYPE_CODE_REF types.
14448 2019-02-08 Jim Wilson <jimw@sifive.com>
14450 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14451 (riscv_linux_fregset): New.
14452 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14454 2019-02-07 Tom Tromey <tom@tromey.com>
14456 * thread.c (thread_cancel_execution_command): Update.
14457 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14459 (struct thread_fsm_ops): Remove.
14460 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14461 (thread_fsm_should_stop, thread_fsm_return_value)
14462 (thread_fsm_set_finished, thread_fsm_finished_p)
14463 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14465 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14466 * infrun.c (clear_proceed_status_thread)
14467 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14468 (print_stop_event): Update.
14469 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14471 (step_command_fsm_ops): Remove.
14472 (new_step_command_fsm): Remove.
14474 (step_command_fsm::should_stop): Rename from
14475 step_command_fsm_should_stop.
14476 (step_command_fsm::clean_up): Rename from
14477 step_command_fsm_clean_up.
14478 (step_command_fsm::do_async_reply_reason): Rename from
14479 step_command_fsm_async_reply_reason.
14480 (struct until_next_fsm): Inherit from thread_fsm. Add
14482 (until_next_fsm_ops): Remove.
14483 (new_until_next_fsm): Remove.
14484 (until_next_fsm::should_stop): Rename from
14485 until_next_fsm_should_stop.
14486 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14487 (until_next_fsm::do_async_reply_reason): Rename from
14488 until_next_fsm_async_reply_reason.
14489 (struct finish_command_fsm): Inherit from thread_fsm. Add
14490 constructor. Change type of breakpoint.
14491 (finish_command_fsm_ops): Remove.
14492 (new_finish_command_fsm): Remove.
14493 (finish_command_fsm::should_stop): Rename from
14494 finish_command_fsm_should_stop.
14495 (finish_command_fsm::clean_up): Rename from
14496 finish_command_fsm_clean_up.
14497 (finish_command_fsm::return_value): Rename from
14498 finish_command_fsm_return_value.
14499 (finish_command_fsm::do_async_reply_reason): Rename from
14500 finish_command_fsm_async_reply_reason.
14501 (finish_command): Update.
14502 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14504 (call_thread_fsm_ops): Remove.
14505 (call_thread_fsm::call_thread_fsm): Rename from
14506 new_call_thread_fsm.
14507 (call_thread_fsm::should_stop): Rename from
14508 call_thread_fsm_should_stop.
14509 (call_thread_fsm::should_notify_stop): Rename from
14510 call_thread_fsm_should_notify_stop.
14511 (run_inferior_call, call_function_by_hand_dummy): Update.
14512 * cli/cli-interp.c (should_print_stop_to_console): Update.
14513 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14514 Add constructor. Change type of location_breakpoint,
14516 (until_break_fsm_ops): Remove.
14517 (new_until_break_fsm): Remove.
14518 (until_break_fsm::should_stop): Rename from
14519 until_break_fsm_should_stop.
14520 (until_break_fsm::clean_up): Rename from
14521 until_break_fsm_clean_up.
14522 (until_break_fsm::do_async_reply_reason): Rename from
14523 until_break_fsm_async_reply_reason.
14524 (until_break_command): Update.
14525 * thread-fsm.c: Remove.
14526 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14528 2019-02-07 Tom Tromey <tom@tromey.com>
14530 * yy-remap.h: Add include guard.
14531 * xtensa-tdep.h: Add include guard.
14532 * xcoffread.h: Rename include guard.
14533 * varobj-iter.h: Add include guard.
14534 * tui/tui.h: Rename include guard.
14535 * tui/tui-winsource.h: Rename include guard.
14536 * tui/tui-wingeneral.h: Rename include guard.
14537 * tui/tui-windata.h: Rename include guard.
14538 * tui/tui-win.h: Rename include guard.
14539 * tui/tui-stack.h: Rename include guard.
14540 * tui/tui-source.h: Rename include guard.
14541 * tui/tui-regs.h: Rename include guard.
14542 * tui/tui-out.h: Rename include guard.
14543 * tui/tui-layout.h: Rename include guard.
14544 * tui/tui-io.h: Rename include guard.
14545 * tui/tui-hooks.h: Rename include guard.
14546 * tui/tui-file.h: Rename include guard.
14547 * tui/tui-disasm.h: Rename include guard.
14548 * tui/tui-data.h: Rename include guard.
14549 * tui/tui-command.h: Rename include guard.
14550 * tic6x-tdep.h: Add include guard.
14551 * target/waitstatus.h: Rename include guard.
14552 * target/wait.h: Rename include guard.
14553 * target/target.h: Rename include guard.
14554 * target/resume.h: Rename include guard.
14555 * target-float.h: Rename include guard.
14556 * stabsread.h: Add include guard.
14557 * rs6000-tdep.h: Add include guard.
14558 * riscv-fbsd-tdep.h: Add include guard.
14559 * regformats/regdef.h: Rename include guard.
14560 * record.h: Rename include guard.
14561 * python/python.h: Rename include guard.
14562 * python/python-internal.h: Rename include guard.
14563 * python/py-stopevent.h: Rename include guard.
14564 * python/py-ref.h: Rename include guard.
14565 * python/py-record.h: Rename include guard.
14566 * python/py-record-full.h: Rename include guard.
14567 * python/py-record-btrace.h: Rename include guard.
14568 * python/py-instruction.h: Rename include guard.
14569 * python/py-events.h: Rename include guard.
14570 * python/py-event.h: Rename include guard.
14571 * procfs.h: Add include guard.
14572 * proc-utils.h: Add include guard.
14573 * p-lang.h: Add include guard.
14574 * or1k-tdep.h: Rename include guard.
14575 * observable.h: Rename include guard.
14576 * nto-tdep.h: Rename include guard.
14577 * nat/x86-linux.h: Rename include guard.
14578 * nat/x86-linux-dregs.h: Rename include guard.
14579 * nat/x86-gcc-cpuid.h: Add include guard.
14580 * nat/x86-dregs.h: Rename include guard.
14581 * nat/x86-cpuid.h: Rename include guard.
14582 * nat/ppc-linux.h: Rename include guard.
14583 * nat/mips-linux-watch.h: Rename include guard.
14584 * nat/linux-waitpid.h: Rename include guard.
14585 * nat/linux-ptrace.h: Rename include guard.
14586 * nat/linux-procfs.h: Rename include guard.
14587 * nat/linux-osdata.h: Rename include guard.
14588 * nat/linux-nat.h: Rename include guard.
14589 * nat/linux-namespaces.h: Rename include guard.
14590 * nat/linux-btrace.h: Rename include guard.
14591 * nat/glibc_thread_db.h: Rename include guard.
14592 * nat/gdb_thread_db.h: Rename include guard.
14593 * nat/gdb_ptrace.h: Rename include guard.
14594 * nat/fork-inferior.h: Rename include guard.
14595 * nat/amd64-linux-siginfo.h: Rename include guard.
14596 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14597 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14598 * nat/aarch64-linux.h: Rename include guard.
14599 * nat/aarch64-linux-hw-point.h: Rename include guard.
14600 * mn10300-tdep.h: Add include guard.
14601 * mips-linux-tdep.h: Add include guard.
14602 * mi/mi-parse.h: Rename include guard.
14603 * mi/mi-out.h: Rename include guard.
14604 * mi/mi-main.h: Rename include guard.
14605 * mi/mi-interp.h: Rename include guard.
14606 * mi/mi-getopt.h: Rename include guard.
14607 * mi/mi-console.h: Rename include guard.
14608 * mi/mi-common.h: Rename include guard.
14609 * mi/mi-cmds.h: Rename include guard.
14610 * mi/mi-cmd-break.h: Rename include guard.
14611 * m2-lang.h: Add include guard.
14612 * location.h: Rename include guard.
14613 * linux-record.h: Rename include guard.
14614 * linux-nat.h: Add include guard.
14615 * linux-fork.h: Add include guard.
14616 * i386-darwin-tdep.h: Rename include guard.
14617 * hppa-linux-offsets.h: Add include guard.
14618 * guile/guile.h: Rename include guard.
14619 * guile/guile-internal.h: Rename include guard.
14620 * gnu-nat.h: Rename include guard.
14621 * gdb-stabs.h: Rename include guard.
14622 * frv-tdep.h: Add include guard.
14623 * f-lang.h: Add include guard.
14624 * event-loop.h: Add include guard.
14625 * darwin-nat.h: Rename include guard.
14626 * cp-abi.h: Rename include guard.
14627 * config/sparc/nm-sol2.h: Rename include guard.
14628 * config/nm-nto.h: Rename include guard.
14629 * config/nm-linux.h: Add include guard.
14630 * config/i386/nm-i386gnu.h: Rename include guard.
14631 * config/djgpp/nl_types.h: Rename include guard.
14632 * config/djgpp/langinfo.h: Rename include guard.
14633 * compile/gcc-cp-plugin.h: Add include guard.
14634 * compile/gcc-c-plugin.h: Add include guard.
14635 * compile/compile.h: Rename include guard.
14636 * compile/compile-object-run.h: Rename include guard.
14637 * compile/compile-object-load.h: Rename include guard.
14638 * compile/compile-internal.h: Rename include guard.
14639 * compile/compile-cplus.h: Rename include guard.
14640 * compile/compile-c.h: Rename include guard.
14641 * common/xml-utils.h: Rename include guard.
14642 * common/x86-xstate.h: Rename include guard.
14643 * common/version.h: Rename include guard.
14644 * common/vec.h: Rename include guard.
14645 * common/tdesc.h: Rename include guard.
14646 * common/selftest.h: Rename include guard.
14647 * common/scoped_restore.h: Rename include guard.
14648 * common/scoped_mmap.h: Rename include guard.
14649 * common/scoped_fd.h: Rename include guard.
14650 * common/safe-iterator.h: Rename include guard.
14651 * common/run-time-clock.h: Rename include guard.
14652 * common/refcounted-object.h: Rename include guard.
14653 * common/queue.h: Rename include guard.
14654 * common/ptid.h: Rename include guard.
14655 * common/print-utils.h: Rename include guard.
14656 * common/preprocessor.h: Rename include guard.
14657 * common/pathstuff.h: Rename include guard.
14658 * common/observable.h: Rename include guard.
14659 * common/netstuff.h: Rename include guard.
14660 * common/job-control.h: Rename include guard.
14661 * common/host-defs.h: Rename include guard.
14662 * common/gdb_wait.h: Rename include guard.
14663 * common/gdb_vecs.h: Rename include guard.
14664 * common/gdb_unlinker.h: Rename include guard.
14665 * common/gdb_unique_ptr.h: Rename include guard.
14666 * common/gdb_tilde_expand.h: Rename include guard.
14667 * common/gdb_sys_time.h: Rename include guard.
14668 * common/gdb_string_view.h: Rename include guard.
14669 * common/gdb_splay_tree.h: Rename include guard.
14670 * common/gdb_setjmp.h: Rename include guard.
14671 * common/gdb_ref_ptr.h: Rename include guard.
14672 * common/gdb_optional.h: Rename include guard.
14673 * common/gdb_locale.h: Rename include guard.
14674 * common/gdb_assert.h: Rename include guard.
14675 * common/filtered-iterator.h: Rename include guard.
14676 * common/filestuff.h: Rename include guard.
14677 * common/fileio.h: Rename include guard.
14678 * common/environ.h: Rename include guard.
14679 * common/common-utils.h: Rename include guard.
14680 * common/common-types.h: Rename include guard.
14681 * common/common-regcache.h: Rename include guard.
14682 * common/common-inferior.h: Rename include guard.
14683 * common/common-gdbthread.h: Rename include guard.
14684 * common/common-exceptions.h: Rename include guard.
14685 * common/common-defs.h: Rename include guard.
14686 * common/common-debug.h: Rename include guard.
14687 * common/cleanups.h: Rename include guard.
14688 * common/buffer.h: Rename include guard.
14689 * common/btrace-common.h: Rename include guard.
14690 * common/break-common.h: Rename include guard.
14691 * cli/cli-utils.h: Rename include guard.
14692 * cli/cli-style.h: Rename include guard.
14693 * cli/cli-setshow.h: Rename include guard.
14694 * cli/cli-script.h: Rename include guard.
14695 * cli/cli-interp.h: Rename include guard.
14696 * cli/cli-decode.h: Rename include guard.
14697 * cli/cli-cmds.h: Rename include guard.
14698 * charset-list.h: Add include guard.
14699 * buildsym-legacy.h: Rename include guard.
14700 * bfin-tdep.h: Add include guard.
14701 * ax.h: Rename include guard.
14702 * arm-linux-tdep.h: Add include guard.
14703 * arm-fbsd-tdep.h: Add include guard.
14704 * arch/xtensa.h: Rename include guard.
14705 * arch/tic6x.h: Add include guard.
14706 * arch/i386.h: Add include guard.
14707 * arch/arm.h: Rename include guard.
14708 * arch/arm-linux.h: Rename include guard.
14709 * arch/arm-get-next-pcs.h: Rename include guard.
14710 * arch/amd64.h: Add include guard.
14711 * arch/aarch64-insn.h: Rename include guard.
14712 * arch-utils.h: Rename include guard.
14713 * annotate.h: Add include guard.
14714 * amd64-darwin-tdep.h: Rename include guard.
14715 * aarch64-linux-tdep.h: Add include guard.
14716 * aarch64-fbsd-tdep.h: Add include guard.
14717 * aarch32-linux-nat.h: Add include guard.
14719 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14721 * macrotab.c (macro_define_internal): New function that
14722 factorizes macro_define_object_internal and macro_define_function
14724 (macro_define_object_internal): Use macro_define_internal.
14725 (macro_define_function): Likewise.
14727 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14729 * macrocmd.c (extract_identifier): Return
14730 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14733 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14735 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14737 2019-02-05 Tom Tromey <tom@tromey.com>
14739 * target.c (target_stack::unpush): Move assertion earlier.
14741 2019-01-30 Tom Tromey <tom@tromey.com>
14744 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14745 (gdbpy_parse_and_eval): Likewise.
14746 * python/python-internal.h (gdbpy_allow_threads): New class.
14748 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14750 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14751 (aarch64_fbsd_fpregmap): Move earlier.
14752 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14753 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14754 instead of individual calls to trad_frame_set_reg_addr.
14755 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14757 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14758 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14759 instead of individual calls to trad_frame_set_reg_addr.
14761 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14763 * CONTRIBUTE: Replace contribution list with wiki link.
14765 2019-01-25 Tom Tromey <tom@tromey.com>
14767 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14769 2019-01-25 Tom Tromey <tom@tromey.com>
14771 * xtensa-linux-nat.c: Fix common/ includes.
14772 * xml-support.h: Fix common/ includes.
14773 * xml-support.c: Fix common/ includes.
14774 * x86-linux-nat.c: Fix common/ includes.
14775 * windows-nat.c: Fix common/ includes.
14776 * varobj.h: Fix common/ includes.
14777 * varobj.c: Fix common/ includes.
14778 * value.c: Fix common/ includes.
14779 * valops.c: Fix common/ includes.
14780 * utils.c: Fix common/ includes.
14781 * unittests/xml-utils-selftests.c: Fix common/ includes.
14782 * unittests/utils-selftests.c: Fix common/ includes.
14783 * unittests/unpack-selftests.c: Fix common/ includes.
14784 * unittests/tracepoint-selftests.c: Fix common/ includes.
14785 * unittests/style-selftests.c: Fix common/ includes.
14786 * unittests/string_view-selftests.c: Fix common/ includes.
14787 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14788 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14789 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14790 * unittests/rsp-low-selftests.c: Fix common/ includes.
14791 * unittests/parse-connection-spec-selftests.c: Fix common/
14793 * unittests/optional-selftests.c: Fix common/ includes.
14794 * unittests/offset-type-selftests.c: Fix common/ includes.
14795 * unittests/observable-selftests.c: Fix common/ includes.
14796 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14797 * unittests/memrange-selftests.c: Fix common/ includes.
14798 * unittests/memory-map-selftests.c: Fix common/ includes.
14799 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14800 * unittests/function-view-selftests.c: Fix common/ includes.
14801 * unittests/environ-selftests.c: Fix common/ includes.
14802 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14803 * unittests/common-utils-selftests.c: Fix common/ includes.
14804 * unittests/cli-utils-selftests.c: Fix common/ includes.
14805 * unittests/array-view-selftests.c: Fix common/ includes.
14806 * ui-file.c: Fix common/ includes.
14807 * tui/tui-io.c: Fix common/ includes.
14808 * tracepoint.h: Fix common/ includes.
14809 * tracepoint.c: Fix common/ includes.
14810 * tracefile-tfile.c: Fix common/ includes.
14811 * top.h: Fix common/ includes.
14812 * top.c: Fix common/ includes.
14813 * thread.c: Fix common/ includes.
14814 * target/waitstatus.h: Fix common/ includes.
14815 * target/waitstatus.c: Fix common/ includes.
14816 * target.h: Fix common/ includes.
14817 * target.c: Fix common/ includes.
14818 * target-memory.c: Fix common/ includes.
14819 * target-descriptions.c: Fix common/ includes.
14820 * symtab.h: Fix common/ includes.
14821 * symfile.c: Fix common/ includes.
14822 * stap-probe.c: Fix common/ includes.
14823 * spu-linux-nat.c: Fix common/ includes.
14824 * sparc-nat.c: Fix common/ includes.
14825 * source.c: Fix common/ includes.
14826 * solib.c: Fix common/ includes.
14827 * solib-target.c: Fix common/ includes.
14828 * ser-unix.c: Fix common/ includes.
14829 * ser-tcp.c: Fix common/ includes.
14830 * ser-pipe.c: Fix common/ includes.
14831 * ser-base.c: Fix common/ includes.
14832 * selftest-arch.c: Fix common/ includes.
14833 * s12z-tdep.c: Fix common/ includes.
14834 * rust-exp.y: Fix common/ includes.
14835 * rs6000-aix-tdep.c: Fix common/ includes.
14836 * riscv-tdep.c: Fix common/ includes.
14837 * remote.c: Fix common/ includes.
14838 * remote-notif.h: Fix common/ includes.
14839 * remote-fileio.h: Fix common/ includes.
14840 * remote-fileio.c: Fix common/ includes.
14841 * regcache.h: Fix common/ includes.
14842 * regcache.c: Fix common/ includes.
14843 * record-btrace.c: Fix common/ includes.
14844 * python/python.c: Fix common/ includes.
14845 * python/py-type.c: Fix common/ includes.
14846 * python/py-inferior.c: Fix common/ includes.
14847 * progspace.h: Fix common/ includes.
14848 * producer.c: Fix common/ includes.
14849 * procfs.c: Fix common/ includes.
14850 * proc-api.c: Fix common/ includes.
14851 * printcmd.c: Fix common/ includes.
14852 * ppc-linux-nat.c: Fix common/ includes.
14853 * parser-defs.h: Fix common/ includes.
14854 * osdata.c: Fix common/ includes.
14855 * obsd-nat.c: Fix common/ includes.
14856 * nat/x86-linux.c: Fix common/ includes.
14857 * nat/x86-linux-dregs.c: Fix common/ includes.
14858 * nat/x86-dregs.h: Fix common/ includes.
14859 * nat/x86-dregs.c: Fix common/ includes.
14860 * nat/ppc-linux.c: Fix common/ includes.
14861 * nat/mips-linux-watch.h: Fix common/ includes.
14862 * nat/mips-linux-watch.c: Fix common/ includes.
14863 * nat/linux-waitpid.c: Fix common/ includes.
14864 * nat/linux-ptrace.h: Fix common/ includes.
14865 * nat/linux-ptrace.c: Fix common/ includes.
14866 * nat/linux-procfs.c: Fix common/ includes.
14867 * nat/linux-personality.c: Fix common/ includes.
14868 * nat/linux-osdata.c: Fix common/ includes.
14869 * nat/linux-namespaces.c: Fix common/ includes.
14870 * nat/linux-btrace.h: Fix common/ includes.
14871 * nat/linux-btrace.c: Fix common/ includes.
14872 * nat/fork-inferior.c: Fix common/ includes.
14873 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14874 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14875 * nat/aarch64-linux.c: Fix common/ includes.
14876 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14877 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14878 * namespace.h: Fix common/ includes.
14879 * mips-linux-tdep.c: Fix common/ includes.
14880 * minsyms.c: Fix common/ includes.
14881 * mi/mi-parse.h: Fix common/ includes.
14882 * mi/mi-main.c: Fix common/ includes.
14883 * mi/mi-cmd-env.c: Fix common/ includes.
14884 * memrange.h: Fix common/ includes.
14885 * memattr.c: Fix common/ includes.
14886 * maint.h: Fix common/ includes.
14887 * maint.c: Fix common/ includes.
14888 * main.c: Fix common/ includes.
14889 * machoread.c: Fix common/ includes.
14890 * location.c: Fix common/ includes.
14891 * linux-thread-db.c: Fix common/ includes.
14892 * linux-nat.c: Fix common/ includes.
14893 * linux-fork.c: Fix common/ includes.
14894 * inline-frame.c: Fix common/ includes.
14895 * infrun.c: Fix common/ includes.
14896 * inflow.c: Fix common/ includes.
14897 * inferior.h: Fix common/ includes.
14898 * inferior.c: Fix common/ includes.
14899 * infcmd.c: Fix common/ includes.
14900 * inf-ptrace.c: Fix common/ includes.
14901 * inf-child.c: Fix common/ includes.
14902 * ia64-linux-nat.c: Fix common/ includes.
14903 * i387-tdep.c: Fix common/ includes.
14904 * i386-tdep.c: Fix common/ includes.
14905 * i386-linux-tdep.c: Fix common/ includes.
14906 * i386-linux-nat.c: Fix common/ includes.
14907 * i386-go32-tdep.c: Fix common/ includes.
14908 * i386-fbsd-tdep.c: Fix common/ includes.
14909 * i386-fbsd-nat.c: Fix common/ includes.
14910 * guile/scm-type.c: Fix common/ includes.
14911 * guile/guile.c: Fix common/ includes.
14912 * go32-nat.c: Fix common/ includes.
14913 * gnu-nat.c: Fix common/ includes.
14914 * gdbthread.h: Fix common/ includes.
14915 * gdbarch-selftests.c: Fix common/ includes.
14916 * gdb_usleep.c: Fix common/ includes.
14917 * gdb_select.h: Fix common/ includes.
14918 * gdb_bfd.c: Fix common/ includes.
14919 * gcore.c: Fix common/ includes.
14920 * fork-child.c: Fix common/ includes.
14921 * findvar.c: Fix common/ includes.
14922 * fbsd-nat.c: Fix common/ includes.
14923 * event-top.c: Fix common/ includes.
14924 * event-loop.c: Fix common/ includes.
14925 * dwarf2read.c: Fix common/ includes.
14926 * dwarf2loc.c: Fix common/ includes.
14927 * dwarf2-frame.c: Fix common/ includes.
14928 * dwarf-index-cache.c: Fix common/ includes.
14929 * dtrace-probe.c: Fix common/ includes.
14930 * disasm-selftests.c: Fix common/ includes.
14931 * defs.h: Fix common/ includes.
14932 * csky-tdep.c: Fix common/ includes.
14933 * cp-valprint.c: Fix common/ includes.
14934 * cp-support.h: Fix common/ includes.
14935 * cp-support.c: Fix common/ includes.
14936 * corelow.c: Fix common/ includes.
14937 * completer.h: Fix common/ includes.
14938 * completer.c: Fix common/ includes.
14939 * compile/compile.c: Fix common/ includes.
14940 * compile/compile-loc2c.c: Fix common/ includes.
14941 * compile/compile-cplus-types.c: Fix common/ includes.
14942 * compile/compile-cplus-symbols.c: Fix common/ includes.
14943 * command.h: Fix common/ includes.
14944 * cli/cli-dump.c: Fix common/ includes.
14945 * cli/cli-cmds.c: Fix common/ includes.
14946 * charset.c: Fix common/ includes.
14947 * build-id.c: Fix common/ includes.
14948 * btrace.h: Fix common/ includes.
14949 * btrace.c: Fix common/ includes.
14950 * breakpoint.h: Fix common/ includes.
14951 * breakpoint.c: Fix common/ includes.
14953 (enum agent_op): Fix common/ includes.
14954 * ax-general.c (struct aop_map): Fix common/ includes.
14955 * ax-gdb.c: Fix common/ includes.
14956 * auxv.c: Fix common/ includes.
14957 * auto-load.c: Fix common/ includes.
14958 * arm-tdep.c: Fix common/ includes.
14959 * arch/riscv.c: Fix common/ includes.
14960 * arch/ppc-linux-common.c: Fix common/ includes.
14961 * arch/i386.c: Fix common/ includes.
14962 * arch/arm.c: Fix common/ includes.
14963 * arch/arm-linux.c: Fix common/ includes.
14964 * arch/arm-get-next-pcs.c: Fix common/ includes.
14965 * arch/amd64.c: Fix common/ includes.
14966 * arch/aarch64.c: Fix common/ includes.
14967 * arch/aarch64-insn.c: Fix common/ includes.
14968 * arch-utils.c: Fix common/ includes.
14969 * amd64-windows-tdep.c: Fix common/ includes.
14970 * amd64-tdep.c: Fix common/ includes.
14971 * amd64-sol2-tdep.c: Fix common/ includes.
14972 * amd64-obsd-tdep.c: Fix common/ includes.
14973 * amd64-nbsd-tdep.c: Fix common/ includes.
14974 * amd64-linux-tdep.c: Fix common/ includes.
14975 * amd64-linux-nat.c: Fix common/ includes.
14976 * amd64-fbsd-tdep.c: Fix common/ includes.
14977 * amd64-fbsd-nat.c: Fix common/ includes.
14978 * amd64-dicos-tdep.c: Fix common/ includes.
14979 * amd64-darwin-tdep.c: Fix common/ includes.
14980 * agent.c: Fix common/ includes.
14981 * ada-lang.h: Fix common/ includes.
14982 * ada-lang.c: Fix common/ includes.
14983 * aarch64-tdep.c: Fix common/ includes.
14985 2019-01-25 Tom Tromey <tom@tromey.com>
14987 * common/create-version.sh: Use common/version.h.
14989 2019-01-24 Pedro Alves <palves@redhat.com>
14991 * infrun.c (signal_stop, signal_print, signal_program)
14992 (signal_catch, signal_pass): Now arrays instead of pointers.
14993 (update_signals_program_target, do_target_resume)
14994 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14995 * linux-nat.c (linux_nat_target::pass_signals)
14996 (linux_nat_target::create_inferior, linux_nat_target::attach):
14998 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14999 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15000 * procfs.c (procfs_target::pass_signals): Adjust.
15001 * record-full.c (record_full_target::resume): Adjust.
15002 * remote.c (remote_target::pass_signals)
15003 (remote_target::program_signals): Adjust.
15004 * target-debug.h (target_debug_print_signals): Now takes a
15005 gdb::array_view as parameter. Adjust.
15006 * target.h (target_ops) <pass_signals, program_signals>: Replace
15007 pointer and length parameters with gdb::array_view.
15008 (target_pass_signals, target_program_signals): Likewise.
15009 * target-delegates.c: Regenerate.
15011 2019-01-24 Pedro Alves <palves@redhat.com>
15013 * common/forward-scope-exit.h
15014 (forward_scope_exit::forward_scope_exit): Pass arguments to
15015 m_bind_function directly, instead of creating a std::bind and
15018 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15020 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15021 for static members.
15022 (pass_in_v_vfp_candidate): Likewise.
15024 2019-01-23 Tom Tromey <tom@tromey.com>
15025 Pedro Alves <palves@redhat.com>
15027 * regcache.c (class regcache_invalidator): Remove.
15028 (regcache::raw_write): Use make_scope_exit.
15030 2019-01-23 Tom Tromey <tom@tromey.com>
15032 * ui-out.h (class ui_out_emit_type): Update comment.
15034 2019-01-23 Tom Tromey <tom@tromey.com>
15036 * infrun.c (fetch_inferior_event): Update comment.
15038 2019-01-23 Tom Tromey <tom@tromey.com>
15039 Pedro Alves <palves@redhat.com>
15041 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15043 (fetch_inferior_event): Use SCOPE_EXIT.
15046 2019-01-23 Tom Tromey <tom@tromey.com>
15047 Pedro Alves <palves@redhat.com>
15049 * infrun.c (disable_thread_events): Delete.
15050 (stop_all_threads): Use SCOPE_EXIT.
15052 2019-01-23 Tom Tromey <tom@tromey.com>
15053 Pedro Alves <palves@redhat.com>
15055 * symfile.c: Include forward-scope-exit.h.
15056 (clear_symtab_users_cleanup): Replace forward declaration with
15057 a FORWARD_SCOPE_EXIT.
15058 (syms_from_objfile_1): Use the forward_scope_exit and
15059 gdb::optional instead of cleanup_function.
15060 (reread_symbols): Use the forward_scope_exit instead of
15062 (clear_symtab_users_cleanup): Remove function.
15064 2019-01-23 Tom Tromey <tom@tromey.com>
15065 Pedro Alves <palves@redhat.com>
15067 * linux-nat.c: Include scope-exit.h.
15068 (cleanup_target_stop): Remove.
15069 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15072 2019-01-23 Tom Tromey <tom@tromey.com>
15073 Pedro Alves <palves@redhat.com>
15075 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15076 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15078 2019-01-23 Tom Tromey <tom@tromey.com>
15079 Andrew Burgess <andrew.burgess@embecosm.com>
15080 Pedro Alves <palves@redhat.com>
15082 * infrun.c (fetch_inferior_event): Use scope_exit.
15083 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15084 * top.c (execute_command): Use scope_exit.
15085 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15086 * utils.c (do_bpstat_clear_actions_cleanup)
15087 (make_bpstat_clear_actions_cleanup): Remove.
15089 2019-01-23 Tom Tromey <tom@tromey.com>
15090 Pedro Alves <palves@redhat.com>
15092 * infrun.c: Include "common/scope-exit.h"
15093 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15094 (wait_for_inferior): Use SCOPE_EXIT.
15095 (fetch_inferior_event): Use scope_exit.
15097 2019-01-23 Tom Tromey <tom@tromey.com>
15098 Pedro Alves <palves@redhat.com>
15100 * breakpoint.c (create_breakpoint): Remove cleanup.
15102 2019-01-23 Tom Tromey <tom@tromey.com>
15103 Andrew Burgess <andrew.burgess@embecosm.com>
15104 Pedro Alves <palves@redhat.com>
15106 2019-01-23 Pedro Alves <palves@redhat.com>
15108 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15110 2019-01-23 Pedro Alves <palves@redhat.com>
15111 Andrew Burgess <andrew.burgess@embecosm.com>
15113 * gdbthread.h: Include "common/forward-scope-exit.h".
15114 (scoped_finish_thread_state): Redefine custom class in terms of
15115 forward_scope_exit.
15117 2019-01-23 Pedro Alves <palves@redhat.com>
15118 Andrew Burgess <andrew.burgess@embecosm.com>
15120 * common/forward-scope-exit.h: New file.
15122 2019-01-23 Pedro Alves <palves@redhat.com>
15123 Andrew Burgess <andrew.burgess@embecosm.com>
15124 Tom Tromey <tom@tromey.com>
15126 * common/scope-exit.h: New file.
15128 2019-01-23 Pedro Alves <palves@redhat.com>
15130 * common/preprocessor.h (ESC): Rename to ...
15131 (ESC_PARENS): ... this.
15132 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15133 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15135 2019-01-23 Tom Tromey <tom@tromey.com>
15137 * language.h (class scoped_switch_to_sym_language_if_auto):
15138 Initialize m_lang in both cases.
15140 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15142 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15145 2019-01-22 Tom Tromey <tom@tromey.com>
15147 * corelow.c: Do not include sys/file.h.
15149 2019-01-22 Tom Tromey <tom@tromey.com>
15151 * tui/tui-wingeneral.h: Include gdb_curses.h.
15153 2019-01-22 Tom Tromey <tom@tromey.com>
15155 * source-cache.h (class source_cache) <get_source_lines,
15156 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15158 2019-01-22 Tom Tromey <tom@tromey.com>
15160 * remote-fileio.h (struct remote_target): Declare.
15162 2019-01-22 Tom Tromey <tom@tromey.com>
15164 * python/py-arch.c: Do not include py-ref.h.
15165 * python/py-bpevent.c: Do not include py-ref.h.
15166 * python/py-cmd.c: Do not include py-ref.h.
15167 * python/py-continueevent.c: Do not include py-ref.h.
15168 * python/py-event.h: Do not include py-ref.h.
15169 * python/py-evtregistry.c: Do not include py-ref.h.
15170 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15171 * python/py-frame.c: Do not include py-ref.h.
15172 * python/py-framefilter.c: Do not include py-ref.h.
15173 * python/py-function.c: Do not include py-ref.h.
15174 * python/py-infevents.c: Do not include py-ref.h.
15175 * python/py-linetable.c: Do not include py-ref.h.
15176 * python/py-objfile.c: Do not include py-ref.h.
15177 * python/py-param.c: Do not include py-ref.h.
15178 * python/py-prettyprint.c: Do not include py-ref.h.
15179 * python/py-progspace.c: Do not include py-ref.h.
15180 * python/py-symbol.c: Do not include py-ref.h.
15181 * python/py-symtab.c: Do not include py-ref.h.
15182 * python/py-type.c: Do not include py-ref.h.
15183 * python/py-unwind.c: Do not include py-ref.h.
15184 * python/py-utils.c: Do not include py-ref.h.
15185 * python/py-value.c: Do not include py-ref.h.
15186 * python/py-varobj.c: Do not include py-ref.h.
15187 * python/py-xmethods.c: Do not include py-ref.h.
15188 * python/python.c: Do not include py-ref.h.
15189 * varobj.c: Do not include py-ref.h.
15191 2019-01-22 Tom Tromey <tom@tromey.com>
15193 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15194 keyword for bcache.
15196 2019-01-22 Tom Tromey <tom@tromey.com>
15198 * compile/compile-cplus-types.c: Remove a comment by #include.
15200 2019-01-22 Tom Tromey <tom@tromey.com>
15202 * compile/gcc-c-plugin.h: Include compile-internal.h.
15204 2019-01-22 Tom Tromey <tom@tromey.com>
15206 * stabsread.c (EXTERN): Do not define.
15207 (symnum, next_symbol_text_func, processing_gcc_compilation)
15208 (within_function, global_sym_chain, global_stabs)
15209 (previous_stab_code, this_object_header_files)
15210 (n_this_object_header_files)
15211 (n_allocated_this_object_header_files): Define.
15212 * stabsread.h (EXTERN): Never define. Use "extern".
15214 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15216 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15219 2019-01-21 Tom Tromey <tom@tromey.com>
15221 * ui-out.c: Fix includes.
15222 * tui/tui-source.c: Fix includes.
15223 * target.c: Fix includes.
15224 * remote.c: Fix includes.
15225 * regcache.c: Fix includes.
15226 * python/py-block.c: Fix includes.
15227 * printcmd.c: Fix includes.
15228 * or1k-tdep.c: Fix includes.
15229 * mi/mi-main.c: Fix includes.
15230 * m32r-tdep.c: Fix includes.
15231 * csky-tdep.c: Fix includes.
15232 * compile/compile-cplus-types.c: Fix includes.
15233 * cli/cli-interp.c: Fix includes.
15235 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15237 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15240 2019-01-16 Tom Tromey <tom@tromey.com>
15242 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15244 (struct objfile) <msymbols_range>: Move from top level.
15245 <msymbols>: New method.
15246 (class objfile_msymbols): Remove.
15247 * symtab.c (default_collect_symbol_completion_matches_break_on):
15249 * symmisc.c (dump_msymbols): Update.
15250 * stabsread.c (scan_file_globals): Update.
15251 * objc-lang.c (info_selectors_command, info_classes_command)
15252 (find_methods): Update.
15253 * minsyms.c (find_solib_trampoline_target): Update.
15254 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15255 * coffread.c (coff_symfile_read): Update.
15256 * ada-lang.c (ada_lookup_simple_minsym)
15257 (ada_collect_symbol_completion_matches): Update.
15259 2019-01-16 Tom Tromey <tom@tromey.com>
15261 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15262 type. Remove no-argument constructor.
15263 <iterator::operator++>: Simplify.
15265 <end>: Use minimal_symbol_count.
15267 2019-01-16 Tom Tromey <tom@tromey.com>
15269 * objfiles.h (struct objfile) <psymtabs>: New method.
15270 (class objfile_psymtabs): Remove.
15271 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15273 <range>: New method.
15274 (require_partial_symbols): Change return type.
15275 * psymtab.c (require_partial_symbols)
15276 (psym_expand_symtabs_matching): Update.
15277 * mdebugread.c (parse_partial_symbols): Update.
15278 * dbxread.c (dbx_end_psymtab): Update.
15280 2019-01-15 Tom Tromey <tom@tromey.com>
15282 * symtab.c (lookup_objfile_from_block)
15283 (lookup_symbol_in_objfile_symtabs)
15284 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15285 (find_line_symtab, info_sources_command)
15286 (default_collect_symbol_completion_matches_break_on)
15287 (make_source_files_completion_list): Update.
15288 * symmisc.c (print_objfile_statistics, dump_objfile)
15289 (maintenance_print_symbols, maintenance_info_symtabs)
15290 (maintenance_check_symtabs, maintenance_info_line_tables):
15292 * source.c (select_source_symtab)
15293 (forget_cached_source_info_for_objfile): Update.
15294 * objfiles.h (class objfile_compunits): Remove.
15295 (struct objfile) <compunits_range>: New typedef.
15296 (compunits): New method.
15297 * objfiles.c (objfile_relocate1): Update.
15298 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15299 * maint.c (count_symtabs_and_blocks): Update.
15300 * linespec.c (iterate_over_all_matching_symtabs): Update.
15301 * cp-support.c (add_symbol_overload_list_qualified): Update.
15302 * coffread.c (coff_symtab_read): Update.
15303 * ada-lang.c (add_nonlocal_symbols)
15304 (ada_collect_symbol_completion_matches)
15305 (ada_add_global_exceptions): Update.
15307 2019-01-15 Tom Tromey <tom@tromey.com>
15309 * progspace.h (program_space) <objfiles_safe_range>: New
15311 <objfiles_safe>: New method.
15312 * objfiles.h (class all_objfiles_safe): Remove.
15313 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15314 * jit.c (jit_inferior_exit_hook): Update.
15316 2019-01-17 Tom Tromey <tom@tromey.com>
15318 * progspace.h (program_space) <objfiles_range>: New typedef.
15319 <objfiles>: New method.
15320 <objfiles_head>: Rename from objfiles.
15321 (object_files): Update.
15322 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15323 * guile/scm-pretty-print.c
15324 (ppscm_find_pretty_printer_from_objfiles): Update.
15325 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15326 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15328 * python/py-progspace.c (pspy_get_objfiles): Update.
15329 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15331 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15332 (objfpy_lookup_objfile_by_build_id): Update.
15333 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15334 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15336 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15337 (expand_symtab_containing_pc, lookup_objfile_from_block)
15338 (lookup_static_symbol, basic_lookup_transparent_type)
15339 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15340 (find_line_symtab, info_sources_command)
15341 (default_collect_symbol_completion_matches_break_on)
15342 (make_source_files_completion_list, find_main_name): Update.
15343 * symmisc.c (print_symbol_bcache_statistics)
15344 (print_objfile_statistics, maintenance_print_symbols)
15345 (maintenance_print_msymbols, maintenance_print_objfiles)
15346 (maintenance_info_symtabs, maintenance_check_symtabs)
15347 (maintenance_expand_symtabs, maintenance_info_line_tables):
15349 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15350 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15351 (map_overlay_command, unmap_overlay_command)
15352 (simple_overlay_update, expand_symtabs_matching)
15353 (map_symbol_filenames): Update.
15354 * symfile-debug.c (set_debug_symfile): Update.
15355 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15357 * source.c (select_source_symtab, forget_cached_source_info):
15359 * solib.c (solib_read_symbols): Update.
15360 * solib-spu.c (append_ocl_sos): Update.
15361 * psymtab.c (maintenance_print_psymbols)
15362 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15363 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15364 * printcmd.c (info_symbol_command): Update.
15365 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15367 * objfiles.h (class all_objfiles): Remove.
15368 * objfiles.c (have_partial_symbols, have_full_symbols)
15369 (have_minimal_symbols, qsort_cmp, update_section_map)
15370 (shared_objfile_contains_address_p)
15371 (default_iterate_over_objfiles_in_search_order): Update.
15372 * objc-lang.c (info_selectors_command, info_classes_command)
15373 (find_methods): Update.
15374 * minsyms.c (find_solib_trampoline_target): Update.
15375 * maint.c (maintenance_info_sections)
15376 (maintenance_translate_address, count_symtabs_and_blocks):
15378 * main.c (captured_main_1): Update.
15379 * linux-thread-db.c (try_thread_db_load_from_pdir)
15380 (has_libpthread): Update.
15381 * linespec.c (iterate_over_all_matching_symtabs)
15382 (search_minsyms_for_name): Update.
15383 * jit.c (jit_find_objf_with_entry_addr): Update.
15384 * hppa-tdep.c (find_unwind_entry)
15385 (hppa_lookup_stub_minimal_symbol): Update.
15386 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15388 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15389 (elf_gnu_ifunc_resolve_by_got): Update.
15390 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15391 * dwarf-index-write.c (save_gdb_index_command): Update.
15392 * cp-support.c (add_symbol_overload_list_qualified): Update.
15393 * breakpoint.c (create_overlay_event_breakpoint)
15394 (create_longjmp_master_breakpoint)
15395 (create_std_terminate_master_breakpoint)
15396 (create_exception_master_breakpoint): Update.
15397 * blockframe.c (find_pc_partial_function): Update.
15398 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15399 (ada_collect_symbol_completion_matches)
15400 (ada_add_global_exceptions): Update.
15402 2019-01-17 Tom Tromey <tom@tromey.com>
15404 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15406 (solib_target_parse_libraries): Change return type.
15407 (library_list_start_segment, library_list_start_section)
15408 (library_list_end_library, library_list_start_library); Update.
15409 (solib_target_free_library_list): Remove.
15410 (solib_target_parse_libraries): Remove cleanup. Change return
15412 (solib_target_current_sos): Update.
15414 2019-01-17 Tom Tromey <tromey@bapiya>
15416 * valprint.c: Replace "the the" with "the".
15417 * symtab.c: Replace "the the" with "the".
15418 * solib.c: Replace "the the" with "the".
15419 * solib-dsbt.c: Replace "the the" with "the".
15420 * linespec.c: Replace "the the" with "the".
15421 * dwarf2loc.h: Replace "the the" with "the".
15422 * amd64-windows-tdep.c: Replace "the the" with "the".
15423 * aarch64-tdep.c: Replace "the the" with "the".
15425 2019-01-16 Keith Seitz <keiths@redhat.com>
15428 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15429 <builder>: Rename to ..
15430 <m_builder>: ... this and make private.
15431 (dwarf2_cu::get_builder): New method. Change all users of
15432 `builder' to use this method.
15433 (dwarf2_start_symtab): Move to ...
15434 (dwarf2_cu::start_symtab): ... here. Update all callers
15435 (setup_type_unit_groups): Move to ...
15436 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15438 (dwarf2_cu::reset_builder): New method.
15439 (process_full_compunit, process_full_type_unit): Use
15440 dwarf2_cu::reset_builder.
15441 (follow_die_offset): Record the ancestor CU if it is different
15442 from the followed DIE's CU.
15443 (follow_die_sig_1): Likewise.
15445 2019-01-15 Tom Tromey <tom@tromey.com>
15447 * remote.c (class remote_state) <buf>: Now a char_vector.
15448 <buf_size>: Remove.
15449 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15451 (remote_target::getpkt_or_notif_sane_1)
15452 (remote_target::getpkt_sane)
15453 (remote_target::getpkt_or_notif_sane): Likewise.
15454 (class remote_target) <putpkt>: New overload.
15455 (remote_target::read_frame): Change type of "buf_p". Remove
15456 sizeof_p parameter.
15457 (packet_ok): New overload.
15458 (packet_check_result): New overload.
15461 2019-01-14 Tom Tromey <tom@tromey.com>
15463 * remote-notif.c (handle_notification, remote_notif_ack)
15464 (remote_notif_parse): Make "buf" const.
15465 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15467 (remote_notif_parse, remote_notif_ack, handle_notification):
15469 * remote.c (remote_notif_stop_parse): Make "buf" const.
15470 (remote_target::remote_parse_stop_reply): Make "buf" const.
15471 (remote_notif_stop_ack): Make "buf" const.
15473 2019-01-14 Tom Tromey <tom@tromey.com>
15475 * remote.c (remote_console_output): Make parameter const.
15477 2019-01-14 Tom Tromey <tom@tromey.com>
15479 * target-debug.h (target_debug_print_signals): Constify.
15480 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15481 * procfs.c (procfs_target::pass_signals): Update.
15482 * linux-nat.c (linux_nat_target::pass_signals): Update.
15483 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15484 * target-delegates.c: Rebuild.
15485 * remote.c (remote_target::program_signals): Update.
15486 (remote_target::pass_signals): Update.
15487 * target.c (target_pass_signals): Constify argument.
15488 (target_program_signals): Likewise.
15489 * target.h (struct target_ops) <pass_signals, program_signals>:
15491 (target_pass_signals, target_program_signals): Constify argument.
15493 2019-01-14 Tom Tromey <tom@tromey.com>
15496 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15498 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15500 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15502 * rs6000-tdep.c: Include reggroups.h.
15503 (IS_V_ALIAS_PSEUDOREG): Define.
15504 (rs6000_register_name): Return names for the "vX" aliases.
15505 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15506 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15507 aliases. Call default_register_reggroup_p for all other
15509 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15511 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15512 Handle "vX" aliases.
15513 (v_alias_pseudo_register_collect): New function.
15514 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15515 (rs6000_gdbarch_init): Initialize "vX" aliases as
15516 pseudo-registers. Restore registration of
15517 rs6000_pseudo_register_reggroup_p with
15518 set_tdesc_pseudo_register_reggroup_p.
15520 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15522 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15523 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15524 set_gdbarch_num_pseudo_regs.
15526 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15528 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15529 Remove arg prefixname, add do_set and do_show.
15530 Add member functions set_list and show_list.
15531 * cli/cli-style.c (class cli_style_option): Update accordingly.
15532 (style_set_list): Move to file scope.
15533 (style_show_list): Likewise.
15534 (set_style): Call help_list.
15535 (show_style): Call cmd_show_list.
15536 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15537 Update to use the new macro.
15539 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15541 * ada-lang.c (_initialize_ada_language): Expand the help text
15542 for the "catch exception" command.
15544 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15546 * symtab.c (matching_obj_sections): Initialize obj,
15547 declare it closer to its usage.
15549 2019-01-10 Tom Tromey <tom@tromey.com>
15551 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15552 (basic_inf_threads_range): Remove.
15553 (inf_threads_range, inf_non_exited_threads_range)
15554 (safe_inf_threads_range): Use next_adapter.
15556 2019-01-10 Keith Seitz <keiths@redhat.com>
15560 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15561 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15563 2019-01-10 Keith Seitz <keiths@redhat.com>
15567 * dictionary.c (pending_to_vector): Remove.
15568 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15569 Remove _1 suffix, replacing functions of the same name. Update
15571 (dict_create_hashed, dict_create_hashed_expandable)
15572 (dict_create_linear, dict_create_linear_expandable, dict_free)
15573 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15574 Make functions static.
15576 2019-01-10 Keith Seitz <keiths@redhat.com>
15580 * dictionary.h (struct dictionary): Replace declaration with
15582 (dict_create_hashed, dict_create_hashed_expandable)
15583 (dict_create_linear, dict_create_linear_expandable)
15584 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15585 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15586 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15587 taking multidictionary argument.
15588 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15589 * block.h (struct block) <dict>: Change to multidictionary
15590 and rename `multidict'.
15591 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15592 symmisc.c: Update all dictionary references to multidictionary.
15594 2019-01-10 Keith Seitz <keiths@redhat.com>
15598 * dictionary.c: Include unordered_map.
15599 (pending_to_vector): New function.
15600 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15601 Rewrite the non-"_1" functions to take vector instead
15603 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15604 "new" _1 versions of the same name.
15605 (multidictionary): Define.
15606 (std::hash<enum language): New definition.
15607 (collate_pending_symbols_by_language, mdict_create_hashed)
15608 (mdict_create_hashed_expandable, mdict_create_linear)
15609 (mdict_create_linear_expandable, mdict_free)
15610 (find_language_dictionary, create_new_language_dictionary)
15611 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15612 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15613 (mdict_size, mdict_empty): New functions.
15614 * dictionary.h (mdict_iterator): Define.
15616 2019-01-10 Pedro Alves <palves@redhat.com>
15618 * breakpoint.c (read_uploaded_action)
15619 (create_tracepoint_from_upload): Adjust to use
15620 gdb::unique_xmalloc_ptr.
15621 * ctf.c (ctf_write_uploaded_tp):
15622 (SET_ARRAY_FIELD): Use emplace_back.
15623 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15624 * tracefile-tfile.c (tfile_write_uploaded_tp):
15625 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15626 gdb::unique_xmalloc_ptr.
15627 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15628 at_string, cond_string, cmd_strings>: Replace char pointers
15629 with gdb::unique_xmalloc_ptr.
15631 2019-01-10 Pedro Alves <palves@redhat.com>
15633 * solib-target.c (library_list_start_library): Don't xstrdup name.
15635 2019-01-10 Pedro Alves <palves@redhat.com>
15637 * mdebugread.c (parse_partial_symbols): Use
15638 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15640 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15642 * linux-fork.c (scoped_switch_fork_info)
15643 <~scoped_switch_fork_info>: Fix incorrect variable name.
15645 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15647 * linux-fork.c (scoped_switch_fork_info)
15648 <scoped_switch_fork_info>: Make explicit.
15649 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15651 2019-01-10 Tom Tromey <tom@tromey.com>
15653 * objfiles.h (objfile::reset_psymtabs): Update.
15654 * objfiles.c (objfile::objfile): Update.
15655 * psymtab.h (psymtab_storage::obstack): Update.
15656 (psymtab_storage::m_obstack): Use gdb::optional.
15657 (class psymtab_storage): Update comment. Remove objfile
15659 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15661 2019-01-10 Tom Tromey <tom@tromey.com>
15663 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15664 <free_psymtabs>: Now private.
15665 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15666 (allocate_psymtab): Use new method.
15668 2019-01-10 Tom Tromey <tom@tromey.com>
15670 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15671 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15672 * mdebugread.c (parse_partial_symbols): Use
15673 allocate_dependencies.
15674 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15675 allocate_dependencies.
15676 (process_psymtab_comp_unit_reader)
15677 (build_type_psymtab_dependencies): Likewise.
15678 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15680 2019-01-10 Tom Tromey <tom@tromey.com>
15682 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15683 PSYMBOL_SET_LANGUAGE.
15684 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15686 2019-01-10 Tom Tromey <tom@tromey.com>
15688 * psymtab.h (psymtab_storage::obstack): New method.
15689 <m_obstack>: Rename from obstack; now private.
15690 * psymtab.c (psymtab_storage): Update.
15691 * dwarf2read.c (create_addrmap_from_index)
15692 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15695 2019-01-10 Tom Tromey <tom@tromey.com>
15697 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15698 * objfiles.h (objfile::reset_psymtabs): New method.
15700 2019-01-10 Tom Tromey <tom@tromey.com>
15702 * symmisc.c (print_symbol_bcache_statistics): Update.
15703 (print_objfile_statistics): Update.
15704 * symfile.c (reread_symbols): Update.
15705 * psymtab.h (class psymtab_storage): New.
15706 * psymtab.c (psymtab_storage): New constructor.
15707 (~psymtab_storage): New destructor.
15708 (require_partial_symbols): Update.
15709 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15710 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15711 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15712 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15713 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15714 (start_psymtab_common, end_psymtab_common)
15715 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15716 (allocate_psymtab): Update.
15717 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15719 (dump_psymtab_addrmap, maintenance_print_psymbols)
15720 (maintenance_check_psymtabs): Update.
15721 (class objfile_psymtabs): Move to objfiles.h.
15722 * psympriv.h (discard_psymtab): Now inline.
15723 (psymtab_discarder::psymtab_discarder): Update.
15724 (psymtab_discarder::~psymtab_discarder): Update.
15725 (ALL_OBJFILE_PSYMTABS): Rewrite.
15726 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15727 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15729 <partial_symtabs>: New field.
15730 (class objfile_psymtabs): Move from psymtab.h. Update.
15731 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15733 (objfile::~objfile): Don't destroy psymbol_cache.
15734 * mdebugread.c (parse_partial_symbols): Update.
15735 * dwarf2read.c (create_addrmap_from_index)
15736 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15737 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15738 (add_partial_subprogram, dwarf2_ranges_read): Update.
15739 * dwarf-index-write.c (write_address_map)
15740 (write_one_signatured_type, recursively_write_psymbols)
15741 (class debug_names, class debug_names, write_psymtabs_to_index):
15744 2019-01-10 Tom Tromey <tom@tromey.com>
15746 * symtab.h (SYMBOL_SET_NAMES): Update.
15747 (symbol_set_names): Update.
15748 (MSYMBOL_SET_NAMES): Update.
15749 * symtab.c (symbol_set_names): Change argument to be an
15750 objfile_per_bfd_storage.
15751 * psymtab.c (add_psymbol_to_bcache): Update.
15752 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15754 2019-01-10 Tom Tromey <tom@tromey.com>
15756 * symtab.c (create_demangled_names_hash): Change argument to be an
15757 objfile_per_bfd_storage.
15758 (symbol_set_names): Update.
15760 2019-01-10 Tom Tromey <tom@tromey.com>
15762 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15764 * psymtab.c (init_psymbol_list): Do nothing if already called.
15765 * psympriv.h (init_psymbol_list): Add comment.
15766 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15768 * dbxread.c (dbx_symfile_read): Unconditionally call
15771 2019-01-10 Tom Tromey <tom@tromey.com>
15773 * xcoffread.c (scan_xcoff_symtab): Update.
15774 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15776 * mdebugread.c (parse_partial_symbols)
15777 (handle_psymbol_enumerators): Update.
15778 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15779 * dbxread.c (read_dbx_symtab): Update.
15780 * psympriv.h (psymbol_placement): New enum.
15781 (add_psymbol_to_list): Update.
15783 2019-01-10 Tom Tromey <tom@tromey.com>
15785 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15786 static_psymbols parameters.
15787 (scan_xcoff_symtab): Update.
15788 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15789 static_psymbols parameters.
15790 * psympriv.h (start_psymtab_common): Update.
15791 * mdebugread.c (parse_partial_symbols): Update.
15792 * dwarf2read.c (create_partial_symtab): Update.
15793 * dbxread.c (read_dbx_symtab): Update.
15794 (start_psymtab): Remove global_psymbols and static_psymbols
15797 2019-01-10 Tom Tromey <tom@tromey.com>
15799 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15800 * psymtab.c (allocate_psymtab): Add comment.
15801 * psympriv.h (allocate_psymtab): Add comment.
15802 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15804 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15806 2019-01-10 Tom Tromey <tom@tromey.com>
15808 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15810 * mipsread.c: Include mdebugread.h.
15811 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15813 * elfread.c: Include mdebugread.h.
15815 2019-01-09 Tom Tromey <tom@tromey.com>
15817 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15818 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15819 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15820 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15821 (psym_lookup_symbol, psym_find_last_source_symtab)
15822 (psym_forget_cached_source_info, psym_print_stats)
15823 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15824 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15825 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15826 (psym_find_compunit_symtab_by_address)
15827 (maintenance_print_psymbols, maintenance_info_psymtabs)
15828 (maintenance_check_psymtabs): Use ranged for.
15829 * psymtab.h (class objfile_psymtabs): New.
15830 (require_partial_symbols): Return objfile_psymtabs.
15831 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15833 2019-01-09 Tom Tromey <tom@tromey.com>
15835 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15836 (find_pc_mapped_section, list_overlays_command)
15837 (map_overlay_command, unmap_overlay_command)
15838 (simple_overlay_update): Use all_objfiles.
15839 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15840 * printcmd.c (info_symbol_command): Use all_objfiles.
15841 * objfiles.h (ALL_OBJSECTIONS): Remove.
15842 * maint.c (maintenance_translate_address): Use all_objfiles.
15843 * gcore.c (gcore_create_callback): Use all_objfiles.
15844 (objfile_find_memory_regions): Likewise.
15846 2019-01-09 Tom Tromey <tom@tromey.com>
15848 * symtab.c (find_line_symtab, info_sources_command)
15849 (make_source_files_completion_list): Use objfile_compunits.
15850 * source.c (select_source_symtab): Use objfile_compunits.
15851 * objfiles.h (struct objfile): Update comment.
15852 (ALL_OBJFILES): Remove.
15853 (ALL_FILETABS): Remove.
15854 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15857 2019-01-09 Tom Tromey <tom@tromey.com>
15859 * symmisc.c (print_objfile_statistics, dump_objfile)
15860 (maintenance_print_symbols): Use compunit_filetabs.
15861 * source.c (forget_cached_source_info_for_objfile): Use
15863 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15864 (ALL_FILETABS): Use compunit_filetabs.
15865 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15866 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15868 2019-01-09 Tom Tromey <tom@tromey.com>
15870 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15871 (compunit_filetabs): New.
15872 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15874 (info_sources_command, make_source_files_completion_list): Remove
15876 * symmisc.c (print_objfile_statistics, dump_objfile)
15877 (maintenance_print_symbols): Remove declaration.
15878 (maintenance_info_symtabs): Use compunit_filetabs.
15879 (maintenance_info_line_tables): Likewise.
15880 * source.c (select_source_symtab): Change local variable name.
15881 (forget_cached_source_info_for_objfile): Remove declaration.
15882 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15883 * objfiles.c (objfile_relocate1): Remove declaration.
15884 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15886 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15887 * coffread.c (coff_symtab_read): Remove declaration.
15888 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15891 2019-01-09 Tom Tromey <tom@tromey.com>
15893 * symtab.c (lookup_objfile_from_block)
15894 (find_pc_sect_compunit_symtab, search_symbols)
15895 (default_collect_symbol_completion_matches_break_on): Use
15897 * objfiles.h (ALL_COMPUNITS): Remove.
15898 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15899 * cp-support.c (add_symbol_overload_list_qualified): Use
15901 * ada-lang.c (ada_collect_symbol_completion_matches)
15902 (ada_add_global_exceptions): Use objfile_compunits.
15904 2019-01-09 Tom Tromey <tom@tromey.com>
15906 * source.c (select_source_symtab)
15907 (forget_cached_source_info_for_objfile): Remove declaration.
15908 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15910 * maint.c (count_symtabs_and_blocks): Remove declaration.
15911 * cp-support.c (add_symbol_overload_list_qualified): Remove
15913 * coffread.c (coff_symtab_read): Remove declaration.
15914 * symtab.c (lookup_symbol_in_objfile_symtabs)
15915 (basic_lookup_transparent_type_1): Use objfile_compunits.
15916 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15917 (info_sources_command, search_symbols)
15918 (default_collect_symbol_completion_matches_break_on)
15919 (make_source_files_completion_list): Remove declaration.
15920 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15921 (ada_collect_symbol_completion_matches)
15922 (ada_add_global_exceptions): Remove declaration.
15923 * linespec.c (iterate_over_all_matching_symtabs): Use
15925 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15926 (class objfile_compunits): New.
15927 (ALL_COMPUNITS): Use objfile_compunits.
15928 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15929 (maintenance_check_symtabs, maintenance_info_line_tables): Use
15931 * objfiles.c (objfile_relocate1): Use objfile_compunits.
15933 2019-01-09 Tom Tromey <tom@tromey.com>
15935 * symtab.c (search_symbols)
15936 (default_collect_symbol_completion_matches_break_on): Use
15938 * ada-lang.c (ada_lookup_simple_minsym)
15939 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15940 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15941 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15943 * coffread.c (coff_symfile_read): Use objfile_msymbols.
15944 * symmisc.c (dump_msymbols): Use objfile_msymbols.
15945 * objc-lang.c (find_methods): Use objfile_msymbols.
15946 (info_selectors_command, info_classes_command): Likewise.
15947 * stabsread.c (scan_file_globals): Use objfile_msymbols.
15948 * objfiles.h (class objfile_msymbols): New.
15949 (ALL_OBJFILE_MSYMBOLS): Remove.
15950 (ALL_MSYMBOLS): Remove.
15952 2019-01-09 Tom Tromey <tom@tromey.com>
15954 * common/next-iterator.h (next_adapter): Add Iterator template
15956 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15957 (class all_objfiles_safe): New.
15958 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15959 * objfiles.c (put_objfile_before): Update comment.
15960 (add_separate_debug_objfile): Likewise.
15961 (free_all_objfiles): Use all_objfiles_safe.
15962 (objfile_purge_solibs): Likewise.
15964 2019-01-09 Tom Tromey <tom@tromey.com>
15966 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15967 (expand_symtab_containing_pc, lookup_static_symbol)
15968 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15969 (find_symbol_at_address, find_line_symtab, find_main_name): Use
15971 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15972 * breakpoint.c (create_overlay_event_breakpoint)
15973 (create_longjmp_master_breakpoint)
15974 (create_std_terminate_master_breakpoint)
15975 (create_exception_master_breakpoint): Use all_objfiles.
15976 * linux-thread-db.c (try_thread_db_load_from_pdir)
15977 (has_libpthread): Use all_objfiles.
15978 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15979 * linespec.c (iterate_over_all_matching_symtabs)
15980 (search_minsyms_for_name): Use all_objfiles.
15981 * maint.c (maintenance_info_sections): Use all_objfiles.
15982 * main.c (captured_main_1): Use all_objfiles.
15983 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15984 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15985 * guile/scm-pretty-print.c
15986 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15987 * solib-spu.c (append_ocl_sos): Use all_objfiles.
15988 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15989 (maintenance_print_msymbols): Use all_objfiles.
15990 * source.c (select_source_symtab): Use all_objfiles.
15991 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15992 * symfile.c (remove_symbol_file_command)
15993 (expand_symtabs_matching, map_symbol_filenames): Use
15995 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15997 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15998 * objc-lang.c (find_methods): Use all_objfiles.
15999 * objfiles.c (have_partial_symbols, have_full_symbols)
16000 (have_minimal_symbols, qsort_cmp)
16001 (default_iterate_over_objfiles_in_search_order): Use
16003 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16004 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16005 (maintenance_check_psymtabs): Use all_objfiles.
16006 (ALL_PSYMTABS): Remove.
16007 * compile/compile-object-run.c (do_module_cleanup): Use
16009 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16010 * cp-support.c (add_symbol_overload_list_qualified): Use
16012 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16014 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16015 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16017 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16018 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16019 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16021 * solib.c (solib_read_symbols): Use all_objfiles
16023 2019-01-09 Tom Tromey <tom@tromey.com>
16025 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16026 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16028 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16029 * symmisc.c (print_symbol_bcache_statistics)
16030 (print_objfile_statistics, maintenance_print_objfiles)
16031 (maintenance_info_symtabs, maintenance_check_symtabs)
16032 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16034 * source.c (forget_cached_source_info): Use all_objfiles.
16035 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16036 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16037 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16038 * objfiles.c (update_section_map): Use all_objfiles.
16039 (shared_objfile_contains_address_p): Likewise.
16040 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16041 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16043 2019-01-09 Tom Tromey <tom@tromey.com>
16045 * common/next-iterator.h: New file.
16046 * objfiles.h (class all_objfiles): New.
16047 (struct objfile_iterator): New.
16049 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16051 * NEWS: Move the description of the changed "frame", "select-frame",
16052 and "info frame" commands to the Changed commands section.
16054 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16056 * gdbtypes.c (check_stub_method_group): Remove handling of old
16058 * linespec.c (find_methods): Likewise.
16059 * stabsread.c (read_member_functions): Likewise.
16060 * valops.c (search_struct_method): Likewise.
16061 (value_struct_elt_for_reference): Likewise.
16062 * NEWS: Mention this change.
16064 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16066 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16067 print_source_lines.
16068 * source.c (print_source_lines_base): Update line number check.
16069 (print_source_lines): New function.
16070 (source_lines_range::source_lines_range): New function.
16071 * source.h (class source_lines_range): New class.
16072 (print_source_lines): New declaration.
16074 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16076 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16078 2019-01-08 Tom Tromey <tom@tromey.com>
16079 Simon Marchi <simon.marchi@ericsson.com>
16082 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16083 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16084 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16085 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16086 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16087 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16089 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16091 * source.c (select_source_symtab): Move header comment to
16092 declaration in source.h.
16093 (forget_cached_source_info_for_objfile): Likewise.
16094 (forget_cached_source_info): Likewise.
16095 (identify_source_line): Likewise.
16096 * source.h (identify_source_line): Move declaration from symtab.h
16097 and add comment from source.c
16098 (print_source_lines): Likewise.
16099 (forget_cached_source_info_for_objfile): Likewise.
16100 (forget_cached_source_info): Likewise.
16101 (select_source_symtab): Likewise.
16102 (enum print_source_lines_flag): Move definition from symtab.h.
16103 * symtab.h (identify_source_line): Move declaration to source.h.
16104 (print_source_lines): Likewise.
16105 (forget_cached_source_info_for_objfile): Likewise.
16106 (forget_cached_source_info): Likewise.
16107 (select_source_symtab): Likewise.
16108 (enum print_source_lines_flag): Move definition to source.h.
16109 * tui/tui-hooks.c: Add 'source.h' include.
16111 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16113 * source.c (print_source_lines_base): Handle requests to print
16114 reverse line number sequences, and guard against empty lines
16117 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16119 * source.c (print_source_lines_base): Fix skip of '\r' if next
16122 2019-01-06 Tom Tromey <tom@tromey.com>
16124 * c-exp.y (struct c_parse_state) <macro_original_text,
16125 expansion_obstack>: New member.
16126 (macro_original_text, expansion_obstack): Remove globals.
16127 (scan_macro_expansion, scanning_macro_expansion)
16128 (finished_macro_expansion): Update.
16129 (scan_macro_cleanup): Remove.
16130 (yylex, c_parse): Update.
16132 2019-01-06 Tom Tromey <tom@tromey.com>
16134 * c-exp.y (struct c_parse_state) <strings>: New member.
16135 (operator_stoken): Update.
16137 2019-01-06 Tom Tromey <tom@tromey.com>
16139 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16140 (union type_stack_elt) <typelist_val>: Now a pointer to
16142 (type_stack_cleanup): Don't declare.
16143 (push_typelist): Update.
16144 * parse.c (pop_typelist): Return a std::vector.
16145 (push_typelist): Take a std::vector.
16146 (follow_types): Update. Do not free args.
16147 (type_stack_cleanup): Remove.
16148 * c-exp.y (struct c_parse_state): New.
16149 (cpstate): New global.
16150 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16151 (nonempty_typelist): Update.
16152 (func_mod): Create a new vector.
16153 (c_parse): Create a c_parse_state.
16154 (check_parameter_typelist): Do not delete params.
16155 (function_method): Update. Do not delete type_list.
16157 2019-01-06 Tom Tromey <tom@tromey.com>
16160 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16162 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16163 (print_return_value): Likewise.
16165 2019-01-05 Tom Tromey <tom@tromey.com>
16167 * contrib/cleanup_check.py: Remove.
16168 * contrib/gcc-with-excheck: Remove.
16169 * contrib/exsummary.py: Remove.
16170 * contrib/excheck.py: Remove.
16172 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16174 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16175 NULL. Initialize tpprev to NULL instead of assigning it
16176 to NULL on the next statement.
16177 * windows-nat.c (windows_delete_thread): Remove check for
16178 main_thread_id before printing thread exit notifications.
16179 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16180 Remove thread ID check against main_thread_id.
16181 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16182 windows_delete_thread.
16183 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16185 2019-01-04 Tom Tromey <tom@tromey.com>
16187 * compile/compile.c (_initialize_compile): Use upper case for
16188 metasyntactic variables.
16189 * symmisc.c (_initialize_symmisc): Use upper case for
16190 metasyntactic variables.
16191 * psymtab.c (_initialize_psymtab): Use upper case for
16192 metasyntactic variables.
16193 * demangle.c (demangle_command): Use upper case for metasyntactic
16195 (_initialize_demangler): Likewise.
16196 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16199 2019-01-03 Tom Tromey <tom@tromey.com>
16201 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16203 2019-01-03 Tom Tromey <tom@tromey.com>
16205 * python/py-symtab.c (salpy_str): Update.
16206 (struct salpy_sal_object) <symtab>: Now a PyObject.
16207 (salpy_dealloc): Update.
16208 (del_objfile_sal): Use gdbpy_ref.
16210 2019-01-03 Tom Tromey <tom@tromey.com>
16212 * python/py-type.c (convert_field): Use new_reference. Return
16214 (make_fielditem): Return gdbpy_ref.
16215 (typy_fields): Update.
16216 (typy_getitem): Update.
16217 (field_name): Return gdbpy_ref. Use new_reference.
16218 (typy_iterator_iternext): Update.
16220 2019-01-03 Tom Tromey <tom@tromey.com>
16222 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16224 2019-01-03 Tom Tromey <tom@tromey.com>
16226 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16227 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16228 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16229 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16230 (pspy_set_type_printers): Likewise.
16231 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16232 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16233 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16234 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16235 (objfpy_set_type_printers): Likewise.
16237 2019-01-03 Tom Tromey <tom@tromey.com>
16239 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16240 (gdbpy_print_stack): Use gdbpy_err_fetch.
16241 * python/python-internal.h (class gdbpy_err_fetch): New class.
16242 (class gdbpy_enter) <m_error_type, m_error_value,
16243 m_error_traceback>: Remove.
16244 <m_error>: New member.
16245 (gdbpy_exception_to_string): Don't declare.
16246 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16247 * python/py-value.c (convert_value_from_python): Use
16249 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16250 gdbpy_exception_to_string.
16251 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16252 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16255 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16257 * linux-nat.c (delete_lwp_cleanup): Delete.
16258 (struct lwp_deleter): New struct.
16259 (lwp_info_up): New typedef.
16260 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16263 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16265 * linux-fork.c (class scoped_switch_fork_info): New class.
16266 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16268 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16270 * valops.c (find_overload_match): Remove use of null_cleanup, and
16271 calls to do_cleanups.
16273 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16275 * compile/compile-cplus-types.c
16276 (compile_cplus_instance::decl_name): Handle changes to
16278 * cp-support.c (cp_func_name): Update header comment, update
16280 * cp-support.h (cp_func_name): Update return type in declaration.
16281 * valops.c (find_overload_match): Move temp_func local to top
16282 level of function and change its type. Use temp_func to hold and
16283 delete temporary string obtained from cp_func_name.
16285 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16287 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16288 gdb::char_vector, remove cleanup, and update uses of `msg`.
16290 2019-01-03 Jim Wilson <jimw@sifive.com>
16292 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16294 2019-01-02 Tom Tromey <tom@tromey.com>
16296 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16297 (tdesc_parse_xml): Remove cleanups.
16298 * target-descriptions.h (make_cleanup_free_target_description):
16300 (target_desc_deleter): New struct.
16301 (target_desc_up): New typedef.
16302 * target-descriptions.c (target_desc_deleter::operator()): Rename
16303 from free_target_description.
16304 (make_cleanup_free_target_description): Remove.
16306 2019-01-02 Tom Tromey <tom@tromey.com>
16308 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16309 constructor, destructor.
16310 (linespec_parser): Remove typedef.
16311 (~linespec_parser): Rename from linespec_parser_delete.
16312 (linespec_lex_to_end, linespec_complete_label)
16313 (linespec_complete): Update.
16314 (decode_line_full): Remove cleanups.
16315 (decode_line_1): Update.
16317 2019-01-02 Tom Tromey <tom@tromey.com>
16319 * python/python-internal.h (inferior_to_inferior_object): Change
16321 * python/py-exitedevent.c (create_exited_event_object): Update.
16322 * python/py-inferior.c (inferior_to_inferior_object): Return
16324 (python_new_inferior, python_inferior_deleted)
16325 (thread_to_thread_object, delete_thread_object)
16326 (build_inferior_list, gdbpy_selected_inferior): Update.
16327 * python/py-infthread.c (create_thread_object): Update. Also fail
16328 if inferior_to_inferior_object fails.
16330 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16332 * inferior.h (class inferior) <displaced_step_state>: New field.
16333 * infrun.h (struct displaced_step_state): Move here from
16334 infrun.c. Initialize fields, add constructor.
16335 <inf>: Remove field.
16336 <reset>: New method.
16337 * infrun.c (struct displaced_step_inferior_state): Move to
16339 (displaced_step_inferior_states): Remove.
16340 (get_displaced_stepping_state): Adust.
16341 (displaced_step_in_progress_any_inferior): Adjust.
16342 (displaced_step_in_progress_thread): Adjust.
16343 (displaced_step_in_progress): Adjust.
16344 (add_displaced_stepping_state): Remove.
16345 (get_displaced_step_closure_by_addr): Adjust.
16346 (remove_displaced_stepping_state): Remove.
16347 (infrun_inferior_exit): Call displaced_step_state.reset.
16348 (use_displaced_stepping): Don't check for NULL.
16349 (displaced_step_prepare_throw): Call
16350 get_displaced_stepping_state.
16351 (displaced_step_fixup): Don't check for NULL.
16352 (prepare_for_detach): Don't check for NULL.
16354 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16356 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16357 in case of call that did not complete.
16359 2019-01-02 Andrey Utkin <autkin@undo.io>
16361 * symfile.c (find_separate_debug_file): Fix search of debug files for
16364 2019-01-02 Tom Tromey <tom@tromey.com>
16366 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16368 * python/py-frame.c (frapy_older): Remove cast.
16369 (frapy_newer): Likewise.
16370 * python/py-breakpoint.c (local_setattro): Remove cast.
16371 * python/py-arch.c (archpy_name): Remove local variable.
16372 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16374 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16376 * unittests/basic_string_view/element_access/char/empty.cc:
16377 Fix year range in copyright header.
16379 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16381 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16383 <operator==>: Update with for removed field.
16385 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16386 <isa_features>: ...this.
16387 <abi_features>: New field.
16388 (riscv_isa_flen): Update comment.
16389 (riscv_abi_xlen): New declaration.
16390 (riscv_abi_flen): New declaration.
16391 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16393 (riscv_abi_xlen): New function.
16394 (riscv_isa_flen): Update to get answer from isa_features.
16395 (riscv_abi_flen): New function.
16396 (riscv_has_fp_abi): Update to get answer from abi_features.
16397 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16399 (riscv_call_info) <xlen, flen>: Update comment.
16400 (riscv_call_arg_struct): Remove invalid assertions
16401 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16403 (riscv_gdbarch_init): Gather isa features and abi features
16404 separately, ensure both match on the gdbarch when reusing an old
16405 gdbarch. Relax an error check to allow 32-bit abi float to run on
16406 a target with 64-bit float hardware.
16408 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16410 * source.c (search_command_helper): Stop reverse search
16411 when line 1 has been searched.
16413 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16415 * record-full.c (record_full_base_target::close): Rewrite
16416 record_full_core_buf_list free logic.
16418 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16420 * break-catch-syscall.c (print_one_catch_syscall): xfree
16423 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16425 * top.c (print_gdb_version): Update Copyright year in version
16428 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16430 Update copyright year range in all GDB files.
16432 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16434 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16436 For older changes see ChangeLog-2018.
16442 version-control: never