gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
   4         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
   5         * tui/tui-layout.c (init_and_make_win): Update.
   6         * tui/tui.h (enum tui_win_type): Update.
   7         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
   8         tui_win_is_auxillary.
   9         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
  10         tui_win_is_auxillary.
  11
  12 2019-06-25  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
  15         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
  16         (tui_delete_data_content_windows, tui_display_all_data)
  17         (tui_data_window::do_scroll_vertical, tui_display_data_from):
  18         Update.
  19         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
  20         * tui/tui-regs.c (tui_last_regs_line_no)
  21         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
  22         (tui_show_registers): Update.
  23         (tui_show_register_group): Return void.  Update.
  24         (tui_display_registers_from, tui_display_reg_element_at_line)
  25         (tui_display_registers_from_line, tui_check_register_values):
  26         Update.
  27         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
  28         member.
  29         (struct tui_data_window) <regs_content>: Now a std::vector.
  30         <regs_content_count>: Remove.
  31         (tui_add_content_elements, tui_free_data_content): Don't declare.
  32         * tui/tui-data.c (tui_data_window::clear_detail): Update.
  33         (init_content_element): Remove DATA_WIN case.  Add assert.
  34         (tui_add_content_elements): Remove.
  35         (tui_data_window): Update.
  36         (tui_free_data_content): Remove.
  37         (free_content_elements): Remove DATA_WIN case.
  38
  39 2019-06-25  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-data.c (tui_data_item_window): Update.
  42         * tui/tui-windata.h (tui_check_data_values): Don't declare.
  43         * tui/tui-windata.c (tui_display_all_data)
  44         (tui_display_data_from_line): Update.
  45         (tui_check_data_values): Remove.
  46         * tui/tui-regs.c (tui_show_register_group)
  47         (tui_display_reg_element_at_line): Update.
  48         * tui/tui-hooks.c (tui_register_changed)
  49         (tui_refresh_frame_and_register_information): Call
  50         tui_check_register_values.
  51         * tui/tui-data.h (struct tui_data_window) <data_content,
  52         data_content_count, data_type>: Remove.
  53         (enum tui_data_type): Remove.
  54
  55         * tui/tui-data.c (tui_data_window::clear_detail)
  56         (~tui_data_window): Update.
  57
  58 2019-06-25  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
  61         declare.
  62         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
  63         Rename from tui_first_data_item_displayed.  Update.
  64         (tui_data_window::refresh_all)
  65         (tui_data_window::do_scroll_vertical): Update.
  66         * tui/tui-data.h (struct tui_data_window)
  67         <first_data_item_displayed>: Declare new method.
  68
  69 2019-06-25  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-data.h (tui_init_generic_part): Don't declare.
  72         * tui/tui-data.c (tui_init_generic_part): Remove, moving
  73         contents...
  74         (tui_initialize_static_data): ...here.
  75
  76 2019-06-25  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
  79         (tui_display_registers_from, tui_check_register_values): Update.
  80         (tui_display_register): Remove win_info parameter; update.
  81         (tui_get_register): Change type of parameters.
  82         * tui/tui-data.h (struct tui_data_element): Remove.
  83         (union tui_which_element) <data>: Remove.
  84         <data_window>: Change type.
  85         (struct tui_data_item_window): New.
  86         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
  87         case.  Add assert.
  88         (~tui_data_item_window): New destructor.
  89         (free_content_elements): Remove DATA_ITEM_WIN case.
  90
  91 2019-06-25  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
  94         Remove.
  95
  96 2019-06-25  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-data.h (struct tui_command_element): Remove.
  99         (union tui_which_element) <command>: Remove.
 100         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 101         assert.
 102         (free_content_elements): Remove CMD_WIN case.
 103
 104 2019-06-25  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-layout.c (tui_set_layout): Update.
 107         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 108         * tui/tui-data.c (layout_def): Update.
 109
 110 2019-06-25  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 113         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 114         (tui_source_window_base::set_new_height): Update.
 115         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 116         Update.
 117         (tui_set_locator_fullname, tui_set_locator_info)
 118         (tui_show_frame_info): Update.
 119         * tui/tui-source.c (tui_set_source_content)
 120         (tui_source_is_displayed): Update.
 121         * tui/tui-layout.c (show_source_disasm_command, show_data)
 122         (show_source_or_disasm_and_command): Update.
 123         * tui/tui-disasm.c (tui_set_disassem_content)
 124         (tui_get_begin_asm_address): Update.
 125         * tui/tui-data.h (struct tui_locator_element): Remove.
 126         (union tui_which_element) <locator>: Remove.
 127         (struct tui_locator_window): New.
 128         (tui_locator_win_info_ptr): Change return type.
 129         * tui/tui-data.c (_locator): Change type.
 130         (tui_locator_win_info_ptr): Change return type.
 131         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 132         (tui_alloc_content): Add assert.
 133
 134 2019-06-25  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-winsource.c
 137         (tui_exec_info_window::maybe_allocate_content): New method.
 138         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 139         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 140         (make_source_or_disasm_window): Add cast.
 141         * tui/tui-data.h (union tui_which_element) <simple_string>:
 142         Remove.
 143         (struct tui_source_info): New.
 144         (struct tui_source_window_base) <execution_info>: Change type.
 145         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 146         case, and add assert.
 147         (tui_alloc_content): Add assert.
 148
 149 2019-06-25  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 152         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 153         * tui/tui-data.c (tui_alloc_win_info): Remove.
 154
 155 2019-06-25  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 158         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 159         can_highlight.
 160
 161 2019-06-25  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 164         make_visible_with_new_height method.
 165         (tui_win_info::make_visible_with_new_height): New method.
 166         (tui_source_window_base::do_make_visible_with_new_height)
 167         (tui_data_window::do_make_visible_with_new_height)
 168         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 169         (make_visible_with_new_height): Remove.
 170         (tui_resize_all, tui_adjust_win_heights): Use
 171         make_visible_with_new_height method.
 172         * tui/tui-data.h (struct tui_win_info)
 173         <do_make_visible_with_new_height, make_visible_with_new_height>:
 174         New methods.
 175         (struct tui_source_window_base, struct tui_data_window)
 176         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 177         methods.
 178
 179 2019-06-25  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 182         method.
 183         (update_tab_width): Call update_tab_width method.
 184         * tui/tui-data.h (struct tui_win_info)
 185         (struct tui_source_window_base) <update_tab_width>: New methods.
 186
 187 2019-06-25  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 190         parameter.
 191         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 192         parameter.
 193         (tui_gen_win_info::make_visible): Update.
 194         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 195         parameter.
 196         * tui/tui-data.h (enum tui_box): New enum.
 197         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 198
 199 2019-06-25  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 202         init_and_make_win for EXEC_INFO_WIN.
 203         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 204         longer inline.
 205         (struct tui_win_info) <~tui_win_info>: Inline.
 206         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 207         Don't declare.
 208         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 209         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 210         Remove.
 211         (tui_initialize_static_data): Update.
 212         (~tui_gen_win_info): Handle more cleanup here.
 213         (~tui_source_window_base): Delete "execution_info".
 214         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 215
 216 2019-06-25  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-layout.c (make_command_window): Don't set
 219         can_highlight.
 220         (show_source_disasm_command): Call the reset method.
 221         (show_data): Don't set can_highlight.  Call the reset method.
 222         (tui_gen_win_info::reset): Rename from init_gen_win_info
 223         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 224         (show_source_or_disasm_and_command): Call the reset method.
 225         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 226         (struct tui_cmd_window): Set can_highlight.
 227
 228 2019-06-25  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 231         from make_visible.
 232         (tui_make_visible, tui_make_invisible): Rewrite.
 233         (tui_win_info::make_visible): Remove.
 234         (tui_source_window_base::make_visible): Update.
 235         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 236         method.  Moved from...
 237         (struct tui_win_info) <make_visible>: ...here.
 238
 239 2019-06-25  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-winsource.c
 242         (tui_source_window_base::do_scroll_horizontal): Remove direction
 243         parameter.
 244         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 245         direction parameter.
 246         * tui/tui-win.c (tui_win_info::forward_scroll)
 247         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 248         (tui_win_info::right_scroll): Update.
 249         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 250         direction parameter.
 251         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 252         direction parameter.
 253         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 254         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 255         Remove direction parameter.
 256         (struct tui_source_window_base, struct tui_source_window)
 257         (struct tui_disasm_window, struct tui_data_window)
 258         (struct tui_cmd_window): Update.
 259
 260 2019-06-25  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-winsource.h (tui_set_exec_info_content)
 263         (tui_show_exec_info_content, tui_erase_exec_info_content)
 264         (tui_clear_exec_info_content, tui_update_exec_info): Change
 265         argument to tui_source_window_base.
 266         * tui/tui-winsource.c (tui_set_exec_info_content)
 267         (tui_show_exec_info_content, tui_erase_exec_info_content)
 268         (tui_clear_exec_info_content, tui_update_exec_info): Change
 269         argument to tui_source_window_base.
 270
 271 2019-06-25  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 274         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 275
 276 2019-06-25  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 279         check.
 280
 281 2019-06-25  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 284         type to void.
 285         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 286         type to void.
 287         * tui/tui-source.c (tui_set_source_content): Update.
 288         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 289
 290 2019-06-25  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-win.c (window_name_completer, tui_set_focus)
 293         (tui_all_windows_info): Use name method.
 294         * tui/tui-data.h (struct tui_gen_win_info)
 295         (struct tui_source_window, struct tui_disasm_window)
 296         (struct tui_data_window, struct tui_cmd_window) <name>: New
 297         method.
 298         (tui_win_name): Don't declare.
 299         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 300         (tui_win_name): Remove.
 301
 302 2019-06-25  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-winsource.h (tui_update_source_window)
 305         (tui_update_source_window_as_is): Change parameter type.
 306         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 307         to be a tui_source_window_base.
 308         (tui_update_source_window_as_is): Likewise.
 309         * tui/tui-win.c (make_visible_with_new_height): Update.
 310
 311 2019-06-25  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-winsource.c (tui_erase_source_content)
 314         (tui_show_source_content, tui_show_exec_info_content)
 315         (tui_erase_exec_info_content): Use refresh_window method.
 316         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 317         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 318         from tui_refresh_win.
 319         (tui_data_window::refresh_window): New method.
 320         (tui_win_info::refresh, tui_source_window_base::refresh)
 321         (tui_refresh_all): Use refresh_window method.
 322         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 323         method.
 324         * tui/tui-regs.c (tui_display_register): Call refresh_window
 325         method.
 326         * tui/tui-layout.c (show_source_disasm_command)
 327         (show_source_or_disasm_and_command): Call refresh_window method.
 328         * tui/tui-data.h (struct tui_gen_win_info)
 329         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 330         New method.
 331
 332 2019-06-25  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui.c (tui_rl_other_window, tui_enable)
 335         (tui_is_window_visible, tui_get_command_dimension): Update.
 336         * tui/tui-winsource.c (tui_update_source_window_as_is)
 337         (tui_clear_source_content, tui_erase_source_content)
 338         (tui_show_source_line, tui_source_window_base::refill)
 339         (tui_source_window_base::do_scroll_horizontal)
 340         (tui_source_window_base::set_is_exec_point_at)
 341         (tui_update_breakpoint_info, tui_set_exec_info_content)
 342         (tui_alloc_source_buffer, tui_line_is_displayed)
 343         (tui_addr_is_displayed): Update.
 344         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 345         (tui_check_and_display_highlight_if_needed)
 346         (tui_win_info::make_visible, tui_win_info::refresh)
 347         (tui_refresh_all): Update.
 348         * tui/tui-windata.c (tui_first_data_item_displayed)
 349         (tui_delete_data_content_windows, tui_erase_data_content)
 350         (tui_display_all_data, tui_data_window::refresh_all)
 351         (tui_check_data_values): Update.
 352         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 353         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 354         (tui_win_info::backward_scroll, tui_refresh_all_win)
 355         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 356         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 357         (tui_source_window_base::set_new_height)
 358         (tui_data_window::set_new_height)
 359         (make_invisible_and_set_new_height)
 360         (make_visible_with_new_height, new_height_ok)
 361         (parse_scrolling_args): Update.
 362         * tui/tui-stack.c (tui_show_frame_info): Update.
 363         * tui/tui-source.c (tui_set_source_content)
 364         (tui_set_source_content_nil, tui_source_is_displayed)
 365         (tui_source_window::do_scroll_vertical): Update.
 366         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 367         (tui_display_registers_from, tui_display_reg_element_at_line)
 368         (tui_check_register_values, tui_reg_command): Update.
 369         * tui/tui-layout.c (tui_default_win_height)
 370         (show_source_disasm_command, show_data, init_and_make_win)
 371         (show_source_or_disasm_and_command): Update.
 372         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 373         (tui_redisplay_readline, tui_mld_flush)
 374         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 375         (tui_getc): Update.
 376         * tui/tui-disasm.c (tui_set_disassem_content)
 377         (tui_disasm_window::do_scroll_vertical): Update.
 378         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 379         Now virtual.
 380         (struct tui_win_info): Derive from tui_gen_win_info.
 381         <~tui_win_info>: Mark as override.
 382         <generic>: Remove member.
 383         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 384         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 385         (~tui_data_window, ~tui_win_info)
 386         (tui_free_all_source_wins_content): Update.
 387         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 388
 389 2019-06-25  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-layout.c (init_and_make_win): Use new.
 392         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 393         destructor, initializers.
 394         (tui_alloc_generic_win_info): Don't declare.
 395         * tui/tui-data.c (_locator): Add argument to constructor.
 396         (source_win, disasm_win): New globals.
 397         (exec_info): Remove.
 398         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 399         Update.
 400         (tui_alloc_generic_win_info): Remove.
 401         (init_content_element): Use new.
 402         (tui_win_info::tui_win_info): Update.
 403         (free_content_elements) <case DATA_WIN>: Use delete.
 404
 405 2019-06-25  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 408         * tui/tui-windata.c (tui_first_data_item_displayed)
 409         (tui_delete_data_content_windows): Update.
 410         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 411         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 412         (tui_display_registers_from, tui_check_register_values): Update.
 413         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 414         pointer.
 415         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 416         window.
 417         (tui_free_data_content): Update.
 418         (free_content_elements) <case DATA_WIN>: Free the window.
 419
 420 2019-06-25  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 423         Update.
 424         * tui/tui-layout.c (make_command_window)
 425         (show_source_disasm_command, show_data, init_and_make_win)
 426         (show_source_or_disasm_and_command): Update.
 427         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 428         method.
 429         <can_highight, is_highlighted>: Now bool.
 430         (tui_set_win_highlight): Don't declare.
 431         * tui/tui-data.c (tui_set_win_highlight): Remove.
 432
 433 2019-06-25  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-wingeneral.c (make_visible): Remove check of window
 436         type.
 437
 438 2019-06-25  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-win.c (tui_win_info::max_height)
 441         (tui_cmd_window::max_height): New methods.
 442         (new_height_ok): Call max_height.
 443         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 444         <max_height>: New method.
 445
 446 2019-06-25  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-win.c (tui_source_window_base::set_new_height)
 449         (tui_data_window::set_new_height): New methods.
 450         (make_invisible_and_set_new_height): Call set_new_height method.
 451         * tui/tui-data.h (struct tui_win_info)
 452         (struct tui_source_window_base, struct tui_data_window)
 453         <set_new_height>: New method.
 454
 455 2019-06-25  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 458         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 459         tui_refresh_data_win.
 460         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 461         method.
 462         (tui_refresh_all_win): Call the refresh_all method.
 463         (tui_set_focus): Likewise.
 464         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 465         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 466         Likewise.
 467
 468 2019-06-25  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-winsource.h (tui_refill_source_window)
 471         (tui_set_is_exec_point_at): Don't declare.
 472         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 473         (tui_source_window_base::refill): Rename from
 474         tui_refill_source_window.
 475         (tui_source_window_base::do_scroll_horizontal): Update.
 476         (tui_source_window_base::set_is_exec_point_at): Rename from
 477         tui_set_is_exec_point_at.
 478         (tui_update_all_breakpoint_info): Update.
 479         * tui/tui-stack.c (tui_show_frame_info): Update.
 480         * tui/tui-layout.c (show_data): Add cast.
 481         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 482         * tui/tui-data.h (struct tui_source_window_base) <refill,
 483         set_is_exec_point_at>: New methods.
 484         (tui_source_windows, tui_add_to_source_windows): Update types.
 485         (tui_add_to_source_windows): Remove redundant declaration.
 486         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 487         (tui_source_windows): Change return type.
 488         (tui_clear_source_windows_detail): Update.
 489         (tui_add_to_source_windows): Change type of parameter.
 490         (tui_free_all_source_wins_content): Update.
 491
 492 2019-06-25  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-wingeneral.c (tui_win_info::refresh)
 495         (tui_source_window_base::refresh): New methods.
 496         (tui_refresh_all): Call the refresh method.
 497         * tui/tui-data.h (struct tui_win_info)
 498         (struct tui_source_window_base) <refresh>: New method.
 499
 500 2019-06-25  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui.h (tui_is_window_visible): Return bool.
 503         * tui/tui.c (tui_is_window_visible): Return bool.
 504         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 505         (tui_make_visible, tui_make_invisible)
 506         (tui_win_info::make_visible)
 507         (tui_source_window_base::make_visible, make_all_visible)
 508         (tui_make_all_visible, tui_make_all_invisible): Update.
 509         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 510         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 511         bool.
 512         (struct tui_win_info, struct tui_source_window_base)
 513         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 514         * tui/tui-data.c (tui_init_generic_part): Update.
 515
 516 2019-06-25  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 519         (tui_source_window_base::make_visible): New methods.
 520         (make_all_visible): Make method call.
 521         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 522         (struct tui_source_window_base, struct tui_cmd_window): Override
 523         make_visible.
 524         (tui_win_is_source_type): Don't declare.
 525         * tui/tui-data.c (tui_win_is_source_type): Remove.
 526
 527 2019-06-25  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 530         NULL check.
 531
 532 2019-06-25  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 535         Inline constructor.  Add initializers for members.
 536         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 537         constructors; now inline in class.
 538
 539 2019-06-25  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-regs.c (tui_show_registers): Update.
 542         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 543         bool.
 544         * tui/tui-data.c (tui_data_window::clear_detail)
 545         (tui_data_window): Update.
 546
 547 2019-06-25  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-windata.c (tui_display_all_data)
 550         (tui_display_data_from_line, tui_display_data_from)
 551         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 552         Update.
 553         * tui/tui-regs.c (tui_last_regs_line_no)
 554         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 555         (tui_show_registers, tui_show_register_group)
 556         (tui_display_registers_from, tui_display_reg_element_at_line)
 557         (tui_display_registers_from_line, tui_check_register_values)
 558         (tui_reg_next, tui_reg_prev): Update.
 559         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 560         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 561         tui_data_window.
 562         (struct tui_win_info) <detail>: Remove.  Add new fields from
 563         tui_data_info.
 564         (TUI_DATA_WIN): Add cast.
 565         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 566         (~tui_data_window): Simplify.
 567
 568 2019-06-25  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-layout.c (show_source_disasm_command)
 571         (show_source_or_disasm_and_command): Update.
 572         * tui/tui-io.c (update_cmdwin_start_line)
 573         (tui_redisplay_readline): Update.
 574         * tui/tui-data.h (struct tui_command_info): Remove.
 575         (struct tui_win_info) <detail>: Remove command_info member.
 576         (struct tui_data_window) <start_line>: New member, from
 577         tui_command_info.
 578         (TUI_CMD_WIN): Add casts.
 579
 580 2019-06-25  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-winsource.c (tui_update_source_window)
 583         (tui_refill_source_window)
 584         (tui_source_window_base::do_scroll_horizontal)
 585         (tui_update_breakpoint_info, tui_set_exec_info_content)
 586         (tui_show_exec_info_content, tui_erase_exec_info_content)
 587         (tui_clear_exec_info_content): Update.
 588         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 589         Update.
 590         * tui/tui-win.c (make_invisible_and_set_new_height)
 591         (make_visible_with_new_height): Update.
 592         * tui/tui-source.c (tui_set_source_content)
 593         (tui_show_symtab_source): Update.
 594         * tui/tui-layout.c (extract_display_start_addr)
 595         (show_source_disasm_command, show_data)
 596         (make_source_or_disasm_window)
 597         (show_source_or_disasm_and_command): Update.
 598         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 599         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 600         "gdbarch".
 601         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 602         to tui_source_window_base.
 603         (struct tui_win_info) <detail>: Remove source_info member.
 604         (struct tui_source_window_base) <has_locator>: Inline.
 605         Move contents from tui_source_info; rename has_locator member to
 606         m_has_locator.
 607         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 608         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 609         header file.
 610         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 611         Simplify.
 612         (tui_free_all_source_wins_content): Cast to
 613         tui_source_window_base.
 614
 615 2019-06-25  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-win.c (make_invisible_and_set_new_height)
 618         (make_visible_with_new_height): Call has_locator method.
 619         * tui/tui-layout.c (show_source_disasm_command, show_data)
 620         (show_source_or_disasm_and_command): Update for bool change.
 621         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 622         (tui_win_info) <has_locator>: New method.
 623         (struct tui_source_window_base) <has_locator>: New method.
 624         (tui_win_has_locator): Don't declare.
 625         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 626         from tui_win_has_locator.
 627         (tui_source_window_base): Use false, not FALSE.
 628
 629 2019-06-25  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 632         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 633         clear_detail method directly.
 634         (tui_clear_win_detail): Remove.
 635
 636 2019-06-25  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 639         "this", not TUI_DISASM_WIN.
 640
 641 2019-06-25  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 644         declare.
 645         * tui/tui-winsource.c
 646         (tui_source_window_base::do_scroll_horizontal): Rename from
 647         tui_horizontal_source_scroll.
 648         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 649         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 650         from tui_vertical_data_scroll.
 651         * tui/tui-win.h (tui_scroll): Don't declare.
 652         * tui/tui-win.c (tui_win_info::forward_scroll)
 653         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 654         (tui_win_info::right_scroll): Rename and update.
 655         (tui_scroll_forward_command, tui_scroll_backward_command)
 656         (tui_scroll_left_command, tui_scroll_right_command): Update.
 657         (tui_scroll): Remove.
 658         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 659         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 660         from tui_vertical_source_scroll.
 661         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 662         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 663         from tui_vertical_disassem_scroll.
 664         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 665         do_scroll_horizontal>: New methods.
 666         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 667         Likewise.
 668         (struct tui_source_window_base): Add do_scroll_horizontal.
 669         (struct tui_source_window, struct tui_disasm_window): Add
 670         do_scroll_vertical.
 671         (struct tui_data_window, struct tui_cmd_window): Add
 672         do_scroll_horizontal and do_scroll_vertical.
 673         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 674
 675 2019-06-25  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-data.h (struct tui_source_window_base): New struct.
 678         (struct tui_source_window): Derive from tui_source_window_base.
 679         (struct tui_disasm_window): New struct.
 680         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 681         from tui_source_window::clear_detail.
 682         (tui_source_window_base): Rename from tui_source_window.
 683         (~tui_source_window_base): Rename from ~tui_source_window.
 684         (tui_alloc_win_info): Create a tui_disasm_window.
 685
 686 2019-06-25  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-data.h (struct tui_source_window)
 689         (struct tui_data_window): Declare destructors.
 690         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 691         destructors.
 692         (tui_win_info): Simplify.
 693
 694 2019-06-25  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-winsource.c (tui_display_main)
 697         (tui_update_source_windows_with_addr)
 698         (tui_update_all_breakpoint_info): Update.
 699         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 700         (new_height_ok, parse_scrolling_args): Update.
 701         * tui/tui-stack.c (tui_show_frame_info): Update.
 702         * tui/tui-data.h (struct tui_list): Remove.
 703         (tui_source_windows): Return a reference to a std::vector.
 704         * tui/tui-data.c (source_windows): Now a std::vector.
 705         (tui_source_windows): Change return type.
 706         (tui_clear_source_windows): Rewrite.
 707         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 708         (tui_free_all_source_wins_content): Rewrite.
 709
 710 2019-06-25  Tom Tromey  <tom@tromey.com>
 711
 712         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 713         (struct tui_data_window, struct tui_cmd_window): Declare
 714         clear_detail method.
 715         * tui/tui-data.c (tui_source_window::clear_detail)
 716         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 717         methods.
 718         (tui_clear_win_detail): Simplify.
 719
 720 2019-06-25  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-layout.c (make_source_window, make_disasm_window)
 723         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 724         Return the new window.
 725         (show_source_disasm_command, show_data)
 726         (show_source_or_disasm_and_command): Update.
 727
 728 2019-06-25  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 731         parameter.  Return the new window.
 732         (show_source_disasm_command): Update and remove NULL check.
 733         (show_source_or_disasm_and_command): Update.
 734
 735 2019-06-25  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 738
 739 2019-06-25  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-data.h (struct tui_win_info): Make constructor
 742         protected.  Make destructor virtual.  Add initializers.
 743         (tui_source_window, tui_data_window, tui_cmd_window): New
 744         classes.
 745         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 746         constructor.  Add "type" parameter.
 747         (tui_source_window, tui_data_window, tui_cmd_window): New
 748         constructors.
 749         (tui_alloc_win_info): Instantiate the appropriate subclass.
 750
 751 2019-06-25  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-win.c (tui_resize_all): Use delete.
 754         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 755         destructor.
 756         (tui_free_window): Don't declare.
 757         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 758         Update.
 759
 760 2019-06-25  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-data.h (struct tui_win_info): Add constructor.
 763         * tui/tui-data.c (tui_alloc_win_info): Use new.
 764         (tui_free_window): Use delete.
 765
 766 2019-06-22  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 769         declare.
 770         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 771
 772 2019-06-22  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 775         declare.
 776         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 777
 778 2019-06-22  Tom de Vries  <tdevries@suse.de>
 779
 780         * dwarf2read.c (create_addrmap_from_aranges)
 781         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 782         instead of '%zu'.
 783
 784 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 785
 786         * dwarf2read.h (dwarf2_section_info_def): Remove.
 787         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 788         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 789         std::vector<dwarf2_section_info>.
 790         (struct dwo_file) <~dwo_file>: Remove.
 791         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 792         types field.
 793         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 794         (dwarf2_read_debug_names): Likewise.
 795         (create_debug_types_hash_table): Change parameter type to
 796         array_view, adjust code accordingly.
 797         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 798         (partial_die_info::fixup): Likewise.
 799         (determine_prefix): Likewise.
 800         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 801
 802 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 803
 804         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 805         gdb_bfd_ref_ptr.
 806         <~dwo_file>: Remove call to gdb_bfd_unref.
 807         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 808         gdb_bfd_ref_ptr::get.
 809
 810 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 811
 812         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 813         type to htab_up.
 814         * dwarf2read.c (struct dwo_file): Initialize fields.
 815         <~dwo_file>: New.
 816         (free_dwo_file): Remove, move content to ~dwo_file.
 817         (struct dwo_file_deleter): Remove.
 818         (dwo_file_up>: Remove custom deleter.
 819         (free_dwo_files): Remove.
 820         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 821         dwo_files.
 822         (process_skeletonless_type_units): Call unique_ptr::get.
 823         (allocate_dwo_file_hash_table): Add deleter to created hash
 824         table.  Change return type to htab_up.
 825         (lookup_dwo_file_slot): Don't memset dwo_file, call
 826         unique_ptr::get.
 827         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 828         (create_dwo_unit_in_dwp_v2): Likewise.
 829         (open_and_init_dwo_file): Likewise.
 830         (free_dwo_file_from_slot): Remove.
 831
 832 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 833
 834         * dwarf2read.h (struct dwarf2_section_info) <readin,
 835         is_virtual>: Change type to bool.
 836         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 837         true instead of 1.
 838
 839 2019-06-19  Tom Tromey  <tom@tromey.com>
 840
 841         * tui/tui-data.h (tui_init_content_element): Don't declare.
 842
 843 2019-06-19  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-data.h (tui_init_win_info): Don't declare.
 846
 847 2019-06-19  Tom de Vries  <tdevries@suse.de>
 848
 849         * dwarf2read.h (abstract_to_concrete): Change type to
 850         std::unordered_map<sect_offset, std::vector<sect_offset>,
 851         gdb::hash_enum<sect_offset>>.
 852
 853 2019-06-19  Tom Tromey  <tromey@adacore.com>
 854
 855         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 856         EVAL_AVOID_SIDE_EFFECTS specially.
 857
 858 2019-06-19  Tom Tromey  <tromey@adacore.com>
 859
 860         * source-cache.c (highlighter): New global.
 861         (source_cache::get_source_lines): Create a highlighter on demand.
 862
 863 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 864
 865         * defs.h (deprecated_interactive_hook): Delete declaration.
 866         * interps.c (clear_interpreter_hooks): Remove use of
 867         deprecated_interactive_hook.
 868         * top.c (deprecated_interactive_hook): Delete definition.
 869         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 870
 871 2019-06-18  Tom de Vries  <tdevries@suse.de>
 872
 873         PR gdb/24515
 874         * dwarf2read.h (abstract_to_concrete): Change type from
 875         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 876         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 877         * dwarf2read.c (read_variable): Update.
 878         (dwarf2_fetch_die_loc_sect_off): Update.
 879
 880 2019-06-17  Tom de Vries  <tdevries@suse.de>
 881
 882         PR gdb/24617
 883         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 884         accessing parent[parent_len - 1].
 885
 886 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 887
 888         PR gdb/24364
 889         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 890         call dtrace_process_dof with NULL dof.
 891
 892 2019-06-16  Tom de Vries  <tdevries@suse.de>
 893
 894         PR gdb/24445
 895         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 896
 897 2019-06-16  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 900         (make_all_visible): Use address of member.
 901
 902 2019-06-16  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 905         (tui_free_window, free_content, free_content_elements): Remove
 906         unnecessary cast.
 907         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 908         cast.
 909         * tui/tui-regs.c (tui_show_register_group)
 910         (tui_display_registers_from, tui_display_reg_element_at_line):
 911         Remove unnecessary cast.
 912
 913 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * linux-nat.c (normal_mask): Delete.
 916         (_initialize_linux_nat): Don't initialise normal_mask.
 917
 918 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 919
 920         PR gdb/24445
 921         * dwarf-index-write.h (write_psymtabs_to_index): Add
 922         dwz_basename parameter.
 923         * dwarf-index-write.c (write_gdbindex): Move file writing to
 924         write_gdbindex_1.  Change return type void.
 925         (assert_file_size): Move up, remove filename parameter.
 926         (write_gdbindex_1): New function.
 927         (write_debug_names): Change return type to void, call
 928         assert_file_size.
 929         (struct index_wip_file): New struct.
 930         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 931         file logic to index_wip_file.  Write index for dwz file if
 932         needed.
 933         (save_gdb_index_command): Pass basename of dwz file, if present.
 934         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 935         build-id of dwz file, if present.
 936         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 937         (dwarf2_get_dwz_file): Likewise.
 938         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 939         (dwarf2_get_dwz_file): Likewise.
 940
 941 2019-06-16  Tom Tromey  <tom@tromey.com>
 942
 943         * coffread.c (process_coff_symbol): Use xstrdup.
 944         * value.c (create_internalvar): Use xstrdup.
 945
 946 2019-06-16  Tom Tromey  <tom@tromey.com>
 947
 948         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 949         * breakpoint.c (stopin_command, stopat_command)
 950         (until_break_command, decode_location_default): Remove unnecessary
 951         cast.
 952         * utils.c (subset_compare): Remove unnecessary cast.
 953         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 954         cast.
 955         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 956         cast.
 957         * infcmd.c (path_command): Remove unnecessary cast.
 958         * coffread.c (decode_type): Remove unnecessary cast.
 959         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 960         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 961         * tui/tui-stack.c (tui_show_locator_content)
 962         (tui_show_frame_info): Remove unnecessary cast.
 963         * tui/tui-win.c (tui_scroll_forward_command)
 964         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 965         (parse_scrolling_args): Remove unnecessary cast.
 966         * tui/tui-data.c (init_win_info, tui_del_window)
 967         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 968         (free_content_elements): Remove unnecessary cast.
 969         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 970         unnecessary cast.
 971         * tui/tui-source.c (tui_set_source_content)
 972         (tui_vertical_source_scroll): Remove unnecessary cast.
 973         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 974         cast.
 975         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 976         * tui/tui-regs.c (tui_display_registers_from)
 977         (tui_display_register): Remove unnecessary cast.
 978         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 979         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 980         (make_visible): Remove unnecessary cast.
 981         * tui/tui-winsource.c (tui_erase_source_content)
 982         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 983         unnecessary cast.
 984         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 985         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 986         * stabsread.c (read_type, read_array_type, read_range_type):
 987         Remove unnecessary cast.
 988         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 989         (parse_symbol, parse_type, upgrade_type, parse_external)
 990         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 991         unnecessary cast.
 992         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 993
 994 2019-06-16  Tom Tromey  <tom@tromey.com>
 995
 996         * tui/tui-data.c (tui_alloc_generic_win_info)
 997         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 998         checks.
 999
1000 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1001             Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * f-typeprint.c (f_print_type): Don't return early for not
1004         associated or not allocated types.
1005         (f_type_print_varspec_suffix): Add print_rank parameter and print
1006         ranks of array types in case they dangling.
1007         (f_type_print_base): Add print_rank parameter.
1008
1009 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1010
1011         * NEWS: Mention new MI commands.
1012         * break-catch-throw.c (enum exception_event_kind): Move to
1013         breakpoint.h.
1014         (print_mention_exception_catchpoint): Output text as a single
1015         message.
1016         (catch_exception_command_1): Rename to...
1017         (catch_exception_event): ...this, make non-static, update header
1018         command, and change some parameter types.
1019         (catch_catch_command): Update for changes to
1020         catch_exception_command_1.
1021         (catch_throw_command): Likewise.
1022         (catch_rethrow_command): Likewise.
1023         * breakpoint.c (enum exception_event_kind): Delete.
1024         * breakpoint.h (enum exception_event_kind): Moved here from
1025         break-catch-throw.c.
1026         (catch_exception_event): Declare.
1027         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1028         (mi_cmd_catch_throw): New function.
1029         (mi_cmd_catch_rethrow): New function.
1030         (mi_cmd_catch_catch): New function.
1031         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1032         'catch-catch' entries.
1033         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1034         (mi_cmd_catch_rethrow): Declare.
1035         (mi_cmd_catch_catch): Declare.
1036
1037 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * annotate.c (annotate_source_line): Change return type to void,
1040         update implementation to match.
1041         * annotate.h (annotate_source_line): Change return type to void,
1042         update header comment.
1043         * stack.c (print_frame_info): Don't change what frame information
1044         is printed based on whether annotations are on or not.
1045
1046 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1049         (annotate_source): Make static.
1050         (annotate_source_line): Moved from source.c and renamed from
1051         identify_source_line.  Update the return type.
1052         * annotate.h (annotate_source): Delete declaration.
1053         (annotate_source_line): Declaration moved from source.h, and
1054         renamed from identify_source_line.  Return type updated.
1055         * source.c (identify_source_line): Moved to annotate.c and renamed
1056         to annotate_source_line.
1057         (info_line_command): Remove check of annotation_level.
1058         * source.h (identify_source_line): Move declaration to annotate.h
1059         and rename to annotate_source_line.
1060         * stack.c: Add 'annotate.h' include.
1061         (print_frame_info): Remove check of annotation_level before
1062         calling annotate_source_line.
1063
1064 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * source-cache.c (source_cache::get_plain_source_lines): Use
1067         open_source_file_with_line_charpos instead of just
1068         open_source_file, remove call to find_source_lines.
1069         (source_cache::get_source_lines): Likewise.
1070         * source.c (find_source_lines): Make static.
1071         (get_filename_and_charpos): Renamed into...
1072         (open_source_file_with_line_charpos): ..this along with changes to
1073         return a scoped_fd, and some other minor clean ups.
1074         (identify_source_line): Use open_source_file_with_line_charpos.
1075         (search_command_helper): Use open_source_file_with_line_charpos
1076         instead of just open_source_file, remove call to
1077         find_source_lines.
1078         * source.h (open_source_file_with_line_charpos): Declare new
1079         function.
1080         (find_source_lines): Delete declaration.
1081
1082 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1083
1084         * source.c (get_filename_and_charpos): Remove fullname
1085         parameter.
1086         (identify_source_line): Update call to get_filename_and_charpos.
1087
1088 2019-06-14  Tom Tromey  <tromey@adacore.com>
1089
1090         PR gdb/24502:
1091         * ui-style.h (skip_ansi_escape): Update comment.
1092         * ui-file.h (class no_terminal_escape_file): New class.
1093         * ui-file.c (no_terminal_escape_file::write)
1094         (no_terminal_escape_file::puts): New methods.
1095         * cli/cli-logging.c (handle_redirections): Use
1096         no_terminal_escape_file.
1097
1098 2019-06-14  Tom Tromey  <tromey@adacore.com>
1099
1100         * NEWS: Move convenience variable news above Python news.
1101
1102 2019-06-14  Tom Tromey  <tom@tromey.com>
1103
1104         * gnulib: Move directory to top-level.
1105         * configure.ac: Don't configure gnulib.
1106         * configure: Rebuild.
1107         * common/common-defs.h: Use new path to gnulib.
1108         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1109         (GNULIB_H): Remove.
1110         (INCGNU): Look in new gnulib location.
1111         (HFILES_NO_SRCDIR): Remove gnulib files.
1112         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1113         (generated_files): Remove GNULIB_H.
1114         ($(LIBGNU), all-lib): Remove targets.
1115         (distclean): Don't mention GNULIB_BUILDDIR.
1116         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1117
1118 2019-06-14  Tom Tromey  <tromey@adacore.com>
1119
1120         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1121         Warn if symbol file does not provide any symbols.
1122
1123 2019-06-14  Tom Tromey  <tromey@adacore.com>
1124
1125         * source.c (find_and_open_source): Respect basenames_may_differ.
1126
1127 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1128
1129         * annotate.c (annotate_breakpoints_invalid): Make use of
1130         scoped_restore_terminal_state.
1131         (annotate_frames_invalid): Likewise.
1132
1133 2019-06-14  Tom Tromey  <tromey@adacore.com>
1134
1135         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1136         allow assignment to an internalvar.
1137
1138 2019-06-14  Tom Tromey  <tromey@adacore.com>
1139
1140         * ada-lex.l: Allow "_" in attribute names.
1141
1142 2019-06-14  Tom Tromey  <tromey@adacore.com>
1143
1144         PR gdb/24653:
1145         * regcache.c (registers_changed): Don't call alloca.
1146         * top.c (execute_command): Don't call alloca.
1147
1148 2019-06-13  Pedro Alves  <palves@redhat.com>
1149
1150         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1151         'expression'.  When parsing an expression, error out if there's
1152         junk after "unlimited".
1153         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1154         (do_set_command): Adjust calls to is_unlimited_literal.
1155
1156 2019-06-13  Pedro Alves  <palves@redhat.com>
1157
1158         * compile/compile.c (make_compile_options_def_group): Add braces
1159         around array_view initializer.
1160         * thread.c (make_thread_apply_all_options_def_group)
1161         (make_thread_apply_all_options_def_group): Likewise.
1162
1163 2019-06-13  Pedro Alves  <palves@redhat.com>
1164
1165         * NEWS (New commands): Mention "maint test-options
1166         require-delimiter", "maint test-options unknown-is-error", "maint
1167         test-options unknown-is-operand" and "maint show
1168         test-options-completion-result".
1169         (New command options, command completion): New section.
1170         (Completion improvements): New section.
1171         Mention that you can abbreviate "unlimited".
1172
1173 2019-06-13  Pedro Alves  <palves@redhat.com>
1174
1175         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1176         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1177         * unittests/cli-utils-selftests.c (test_parse_flags)
1178         (test_parse_flags_qcs): Delete.
1179         (test_cli_utils): Don't call deleted functions.
1180
1181 2019-06-13  Pedro Alves  <palves@redhat.com>
1182
1183         * thread.c: Include "cli/cli-option.h".
1184         (tp_array_compar_ascending): Global.
1185         (tp_array_compar): Delete function.
1186         (tp_array_compar_ascending, tp_array_compar_descending): New
1187         functions.
1188         (ascending_option_def, qcs_flag_option_def)
1189         (thr_qcs_flags_option_defs)
1190         (make_thread_apply_all_options_def_group)
1191         (make_thread_apply_options_def_group): New.
1192         (thread_apply_all_command): Use gdb::option::process_options.
1193         (thread_apply_command_completer)
1194         (thread_apply_all_command_completer): New.
1195         (thread_apply_command): Use gdb::option::process_options.
1196         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1197         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1198         to generate help text of "thread apply".  Adjust "taas"'s help.
1199         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1200         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1201
1202 2019-06-13  Pedro Alves  <palves@redhat.com>
1203
1204         * thread.c (thread_apply_command): Check for invalid TID with
1205         isdigit instead of !isalpha.
1206
1207 2019-06-13  Pedro Alves  <palves@redhat.com>
1208
1209         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1210         (validate_flags_qcs): New.
1211         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1212         (validate_flags_qcs): Declare.
1213         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1214         (make_frame_apply_options_def_group): New.
1215         (frame_apply_command_count): Process options with
1216         gdb::option::process_options.
1217         (frame_apply_completer): New.
1218         (frame_apply_level_completer, frame_apply_all_completer)
1219         (frame_apply_completer): New.
1220         (_initialize_stack): Update help of "frame apply", "frame apply
1221         level", "frame apply all" and "faas" to mention supported options
1222         and install command completers.
1223         * stack.h (frame_apply_all_completer): Declare.
1224         * thread.c: Include "stack.h".
1225         (tfaas_command): Add "--".
1226         (_initialize_thread): Update help "tfaas" to mention supported
1227         options and install command completer.
1228
1229 2019-06-13  Pedro Alves  <palves@redhat.com>
1230
1231         * completer.c (complete_nested_command_line): New.
1232         (gdb_completion_word_break_characters_throw): Add assertion.
1233         * completer.h (complete_nested_command_line): Declare.
1234
1235 2019-06-13  Pedro Alves  <palves@redhat.com>
1236
1237         * stack.c (parse_backtrace_qualifiers): New.
1238         (backtrace_command): Use it.
1239         (backtrace_command_completer): Complete on qualifiers.
1240
1241 2019-06-13  Pedro Alves  <palves@redhat.com>
1242
1243         * frame.c: Include "cli/cli-option.h.
1244         (user_set_backtrace_options): New.
1245         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1246         Delete.
1247         (get_prev_frame): Adjust.
1248         (boolean_option_def, uinteger_option_def)
1249         (set_backtrace_option_defs): New.
1250         (_initialize_frame): Adjust and use
1251         gdb::option::add_setshow_cmds_for_options to install "set
1252         backtrace past-main" and "set backtrace past-entry".
1253         * frame.h: Include "cli/cli-option.h".
1254         (struct frame_print_options): Forward declare.
1255         (print_frame_arguments_all, print_frame_arguments_scalars)
1256         (print_frame_arguments_none): Declare.
1257         (print_entry_values): Delete declaration.
1258         (struct frame_print_options, user_frame_print_options): New.
1259         (struct set_backtrace_options): New.
1260         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1261         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1262         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1263         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1264         (list_args_or_locals): Add frame_print_options parameter.
1265         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1266         * python/py-framefilter.c (enumerate_args): Pass down
1267         USER_FRAME_PRINT_OPTIONS.
1268         * stack.c: Include "cli/cli-option.h".
1269         (print_frame_arguments_all, print_frame_arguments_scalars)
1270         (print_frame_arguments_none): Declare.
1271         (print_raw_frame_arguments, print_entry_values): Delete.
1272         (user_frame_print_options): New.
1273         (boolean_option_def, enum_option_def, frame_print_option_defs):
1274         New.
1275         (struct backtrace_cmd_options): New.
1276         (bt_flag_option_def): New.
1277         (backtrace_command_option_defs): New.
1278         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1279         (print_frame_arg, read_frame_arg, print_frame_args)
1280         (print_frame_info, print_frame): Add frame_print_options parameter
1281         and use it.
1282         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1283         (backtrace_command_1): Add frame_print_options and
1284         backtrace_cmd_options parameters and use them.
1285         (make_backtrace_options_def_group): New.
1286         (backtrace_command): Process command options with
1287         gdb::option::process_options.
1288         (backtrace_command_completer): New.
1289         (_initialize_stack): Extend "backtrace"'s help to mention
1290         supported options.  Install completer for "backtrace".
1291         Install some settings commands with add_setshow_cmds_for_options.
1292
1293 2019-06-13  Pedro Alves  <palves@redhat.com>
1294
1295         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1296         and that "set/show print raw frame-arguments" are now deprecated.
1297
1298         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1299         command.
1300         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1301         * stack.c (_initialize_stack): Install "set/show print
1302         raw-frame-arguments", and deprecate "set/show print raw
1303         frame-arguments".
1304         * valprint.c (_initialize_valprint): Deprecate "set/show print
1305         raw".
1306
1307 2019-06-13  Pedro Alves  <palves@redhat.com>
1308
1309         * compile/compile.c (struct compile_options): New.
1310         (compile_flag_option_def, compile_command_option_defs)
1311         (make_compile_options_def_group): New.
1312         (compile_file_command): Handle options with
1313         gdb::option::process_options.
1314         (compile_file_command_completer): New function.
1315         (compile_code_command): Handle options with
1316         gdb::option::process_options.
1317         (compile_code_command_completer): New function.
1318         (_initialize_compiler): Install completers for "compile code" and
1319         "compile file".  Mention available options in "compile code" and
1320         "compile code"'s help.
1321         * completer.c (advance_to_completion_word): New, factored out from
1322         ...
1323         (advance_to_expression_complete_word_point): ... this.
1324         (advance_to_filename_complete_word_point): New.
1325         * completer.h (advance_to_filename_complete_word_point): New
1326         declaration.
1327
1328 2019-06-13  Pedro Alves  <palves@redhat.com>
1329
1330         * compile/compile.c: Include "cli/cli-option.h".
1331         (compile_print_value): Scope data pointer is now a
1332         value_print_options pointer; adjust.
1333         (compile_print_command): Process options.  Scope data pointer is
1334         now a value_print_options pointer; adjust.
1335         (_initialize_compile): Update "compile print"'s help to include
1336         supported options.  Install a completer for "compile print".
1337         * cp-valprint.c (show_vtblprint, show_objectprint)
1338         (show_static_field_print): Delete.
1339         (_initialize_cp_valprint): Don't install "set print
1340         static-members", "set print vtbl", "set print object" here.
1341         * printcmd.c: Include "cli/cli-option.h" and
1342         "common/gdb_optional.h".
1343         (print_command_parse_format): Rework to fill in a
1344         value_print_options instead of a format_data.
1345         (print_value): Change parameter type from format_data pointer to
1346         value_print_options reference.  Adjust.
1347         (print_command_1): Process options.  Adjust to pass down a
1348         value_print_options.
1349         (print_command_completer): New.
1350         (_initialize_printcmd): Install print_command_completer as
1351         handle_brkchars completer for the "print" command.  Update
1352         "print"'s help to include supported options.
1353         * valprint.c: Include "cli/cli-option.h".
1354         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1355         here from cp-valprint.c.
1356         (boolean_option_def, uinteger_option_def)
1357         (value_print_option_defs, make_value_print_options_def_group):
1358         New.  Use gdb::option::add_setshow_cmds_for_options to install
1359         "set print elements", "set print null-stop", "set print repeats",
1360         "set print pretty", "set print union", "set print array", "set
1361         print address", "set print symbol", "set print array-indexes".
1362         * valprint.h: Include <string> and "cli/cli-option.h".
1363         (make_value_print_options_def_group): Declare.
1364         (print_value): Change parameter type from format_data pointer to
1365         value_print_options reference.
1366         (print_command_completer): Declare.
1367
1368 2019-06-13  Pedro Alves  <palves@redhat.com>
1369
1370         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1371         (COMMON_SFILES): Add maint-test-settings.c.
1372         * cli/cli-decode.c (boolean_enums): New global, factored out from
1373         ...
1374         (add_setshow_boolean_cmd): ... here.
1375         * cli/cli-decode.h (boolean_enums): Declare.
1376         * cli/cli-option.c: New file.
1377         * cli/cli-option.h: New file.
1378         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1379         factored out from ...
1380         (parse_cli_boolean_value(const char *)): ... this.
1381         (is_unlimited_literal): Change parameter type to pointer to
1382         pointer.  Adjust and advance ARG pointer.
1383         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1384         (parse_cli_var_enum): New, factored out from ...
1385         (do_set_command): ... this.  Adjust.
1386         * cli/cli-setshow.h (parse_cli_boolean_value)
1387         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1388         (parse_cli_var_enum): Declare.
1389         * cli/cli-utils.c: Include "cli/cli-option.h".
1390         (get_ulongest): New.
1391         * cli/cli-utils.h (get_ulongest): Declare.
1392         (check_for_argument): New overloads.
1393         * maint-test-options.c: New file.
1394
1395 2019-06-13  Pedro Alves  <palves@redhat.com>
1396
1397         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1398         parse a range if "-" is at the end of the string.
1399
1400 2019-06-13  Pedro Alves  <palves@redhat.com>
1401
1402         * cli/cli-setshow.c (parse_auto_binary_operation)
1403         (parse_cli_boolean_value): Don't allow "o".
1404
1405 2019-06-13  Pedro Alves  <palves@redhat.com>
1406
1407         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1408         * NEWS: Mention maint test-settings KIND.
1409         * maint-test-settings.c: New file.
1410
1411 2019-06-13  Pedro Alves  <palves@redhat.com>
1412
1413         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1414         completer.
1415         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1416         "set" completers.
1417
1418 2019-06-13  Pedro Alves  <palves@redhat.com>
1419
1420         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1421         after item.
1422
1423 2019-06-13  Pedro Alves  <palves@redhat.com>
1424
1425         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1426
1427 2019-06-13  Pedro Alves <palves@redhat.com>
1428
1429         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1430         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1431         call.
1432         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1433         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1434         calls.
1435         (check_for_argument): Skip spaces after argument.
1436
1437 2019-06-13  Pedro Alves  <palves@redhat.com>
1438
1439         * thread.c (thread_apply_command): Adjust TID parsing.
1440         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1441         detected before end of string.
1442         (tid_is_in_list): Error out if LIST is invalid.
1443
1444 2019-06-13  Pedro Alves  <palves@redhat.com>
1445
1446         * completer.c (complete_line_internal_1): Rewind completion word
1447         point.
1448         (completion_tracker::advance_custom_word_point_by): Change
1449         parameter type to int.
1450         * completer.h (completion_tracker::advance_custom_word_point_by):
1451         Likewise.
1452
1453 2019-06-13  Pedro Alves  <palves@redhat.com>
1454
1455         * completer.c (advance_to_completion_word): Handle delimiters.
1456
1457 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1458
1459         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1460
1461 2019-06-11  Tom Tromey  <tom@tromey.com>
1462
1463         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1464         (xmalloc_failed): Move to alloc.c.
1465         * alloc.c: New file.
1466         * Makefile.in (COMMON_SFILES): Add alloc.c.
1467
1468 2019-06-11  Tom Tromey  <tom@tromey.com>
1469
1470         * nat/linux-waitpid.c: Don't include server.h.
1471         (linux_debug): Remove.
1472         (my_waitpid): Update.
1473
1474 2019-06-11  Tom Tromey  <tromey@adacore.com>
1475
1476         * infcall.c (_initialize_infcall): Remove trailing newline from
1477         help.
1478         * user-regs.c (_initialize_user_regs): Remove trailing newline
1479         from help.
1480         * typeprint.c (_initialize_typeprint): Remove trailing newline
1481         from help.
1482         * reverse.c (_initialize_reverse): Remove trailing newlines from
1483         help.
1484         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1485         from help.
1486         * language.c (add_set_language_command): Remove trailing newline
1487         from help.
1488         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1489         help.
1490         * disasm.c (_initialize_disasm): Remove trailing newline from
1491         help.
1492         * top.c (init_main): Remove trailing newline from help.
1493         * interps.c (_initialize_interpreter): Remove trailing newline
1494         from help.
1495         * btrace.c (_initialize_btrace): Remove trailing newlines from
1496         help.
1497         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1498         from help.
1499         * python/python.c (_initialize_python): Remove trailing newline
1500         from help.
1501         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1502         help.
1503         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1504         from help.  Reformat some text.
1505         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1506         from help.
1507         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1508         newline from help.
1509
1510 2019-06-11  Tom Tromey  <tromey@adacore.com>
1511
1512         * darwin-nat.c (darwin_decode_exception_message)
1513         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1514
1515 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         * valops.c (value_slice): Check for not allocated or not
1518         associated values.
1519
1520 2019-06-10  Tom de Vries  <tdevries@suse.de>
1521
1522         PR gdb/24618
1523         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1524         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1525         invalid.
1526
1527 2019-06-10  Tom de Vries  <tdevries@suse.de>
1528
1529         PR gdb/24611
1530         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1531         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1532
1533 2019-06-10  Tom de Vries  <tdevries@suse.de>
1534
1535         PR symtab/24545
1536         * symtab.c (struct demangled_name_entry): Add language field.
1537         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1538         static minimal symbol".  Set and use language field.
1539
1540 2019-06-10  Tom Tromey  <tromey@adacore.com>
1541
1542         * ada-lang.c (_initialize_ada_language): Update help text.
1543
1544 2019-06-10  Tom Tromey  <tromey@adacore.com>
1545
1546         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1547         with a newline.
1548         * guile/guile.c (handle_boot_error): Don't end warning with a
1549         newline.
1550         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1551         warning with a newline.
1552         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1553         newline.
1554         (s12z_frame_cache): Likewise.
1555         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1556         a newline.
1557         * solib-svr4.c (disable_probes_interface): Don't end warning with
1558         a newline.
1559         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1560         newline.
1561         * python/python.c (do_finish_initialization): Don't end warning
1562         with a newline.
1563
1564 2019-06-10  Tom Tromey  <tom@tromey.com>
1565
1566         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1567         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1568         gdbpy_enter.
1569
1570 2019-06-10  Tom Tromey  <tromey@adacore.com>
1571
1572         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1573         data.
1574         (elf_new_init): Don't call stabsread_new_init.
1575         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1576         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1577         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1578
1579 2019-06-10  Tom de Vries  <tdevries@suse.de>
1580
1581         PR symtab/16264
1582         PR symtab/24517
1583         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1584
1585 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1586
1587         * source.c (find_and_open_source): Also rewrite relative file
1588         names.
1589
1590 2019-04-26  Amos Bird  <amosbird@gmail.com>
1591
1592         * annotate.c (annotate_thread_exited): Add "thread-exited"
1593         annotation.
1594
1595 2019-06-06  Tom Tromey  <tromey@adacore.com>
1596
1597         * maint.h (class scoped_command_stats): Use
1598         DISABLE_COPY_AND_ASSIGN.
1599         <print_time>: New method.
1600         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1601         print_time.
1602         (scoped_command_stats::print_time): New method.
1603
1604 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1605
1606         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1607         instructions of lengths 6 or 8 bytes.
1608
1609 2019-06-04  Pedro Alves  <palves@redhat.com>
1610
1611         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1612
1613         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1614         * breakpoint.c (condition_completer): Likewise.
1615         * cli/cli-dump.c (scan_expression): Likewise.
1616         * common/filestuff.c (mkdir_recursive): Likewise.
1617         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1618         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1619         (gdb_abspath): Likewise.
1620         * compile/compile-cplus-types.c
1621         (compile_cplus_instance::decl_name): Likewise.
1622         * completer.c (complete_explicit_location):
1623         (signal_completer, reg_or_group_completer_1): Likewise.
1624         * cp-support.c (cp_remove_params_if_any): Likewise.
1625         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1626         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1627         * infcmd.c (strip_bg_char): Likewise.
1628         * linespec.c (copy_token_string): Likewise.
1629         * mi/mi-main.c (output_cores): Likewise.
1630         * psymtab.c (psymtab_search_name):
1631         * symfile.c (test_set_ext_lang_command): Likewise.
1632         * target.c (target_fileio_read_stralloc): Likewise.
1633         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1634         * value.c (complete_internalvar): Likewise.
1635
1636 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1637
1638         Add objfile property to gdb.Type.
1639         * NEWS: Mention Python API addition.
1640         * python/py-type.c (typy_get_objfile): New method.
1641
1642 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1643
1644         * NEWS: Mention the new set|show style [title|highlight].
1645         Mention changes to "show style", "help" and "apropos".
1646
1647 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1648
1649         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1650         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1651         instead of print_help_for_command.
1652         (print_doc_of_command): New function.
1653         (help_list): Add 'apropos -v word' suggestion.
1654         (print_help_for_command): Style the command name using title style.
1655         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1656         (_initialize_cli_cmds): Describe -v in apropos_command help.
1657
1658 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1659
1660         * cli/cli-style.h (cli_style_option): Add name in constructor,
1661         add m_name class member, add constructor with intensity,
1662         add name class function.
1663         (cli_style_option::add_setshow_commands): Remove name argument.
1664         (highlight_style, title_style): New styles.
1665         * cli/cli-style.c (do_show): New function that shows a style
1666         characteristic styling the style name with itself.
1667         (set_style_name): New function.
1668         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1669         Update all callers according to the changes in cli/cli-style.h.
1670         * utils.h (fputs_highlighted): New function.
1671         * utils.c (fputs_highlighted): Likewise.
1672
1673 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1674
1675         * NEWS: Mention new pipe command and new convenience variables.
1676
1677 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1678
1679         * cli/cli-cmds.c (pipe_command): New function.
1680         (_initialize_cli_cmds): Call add_com for pipe_command.
1681         Define | as an alias for pipe.
1682         (exit_status_set_internal_vars): New function.
1683         (shell_escape): Call exit_status_set_internal_vars.
1684         cli/cli-decode.c (find_command_name_length): Recognize | as
1685         a single character command.
1686
1687 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1688
1689         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1690         top.c (execute_command_to_ui_file): New function, mostly a copy
1691         of execute_command_to_string.
1692         (execute_command_to_string): Implement by calling
1693         execute_command_to_ui_file.
1694
1695 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1696
1697         * top.h (saved_command_line): Remove declaration.
1698         * top.c (previous_saved_command_line, previous_repeat_arguments):
1699         New variables.
1700         (saved_command_line): Make static, define together with other
1701         'repeat variables'.
1702         (dont_repeat): Clear repeat_arguments.
1703         (repeat_previous, get_saved_command_line, save_command_line):
1704         New functions.
1705         (gdb_init): Initialize saved_command_line
1706         and previous_saved_command_line.
1707         * main.c (captured_main_1): Remove saved_command_line initialization.
1708         * event-top.c (handle_line_of_input): Update to use
1709         the new 'repeat' related functions instead of direct access to
1710         saved_command_line.
1711         * command.h (repeat_previous, get_saved_command_line,
1712         save_command_line): New declarations.
1713         (dont_repeat): Add comment.
1714
1715 2019-05-30  Tom Tromey  <tromey@adacore.com>
1716
1717         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1718         Fix comment.
1719         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1720
1721 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1722
1723         PR cli/24587
1724         * completer.c (complete): Initialize variable word.
1725
1726 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1727
1728         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1729         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1730         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1731         'body' is NULL to the outter 'if', protecting the '!is_define'
1732         situation as well.
1733
1734 2019-05-29  Tom Tromey  <tromey@adacore.com>
1735
1736         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1737         (dwarf_unknown): New function.
1738         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1739         (dwarf_type_encoding_name): Use dwarf_unknown.
1740
1741 2019-05-29  Tom Tromey  <tromey@adacore.com>
1742
1743         PR c++/20020:
1744         * cp-valprint.c (cp_print_value_fields): Call
1745         cp_print_static_field inside "try".
1746
1747 2019-05-29  Tom Tromey  <tromey@adacore.com>
1748
1749         * inflow.c (struct terminal_info): Add default operator=.
1750         * configure: Rebuild.
1751         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1752         -Wdeprecated-copy-dtor, -Wredundant-move.
1753
1754 2019-05-29  Tom Tromey  <tromey@adacore.com>
1755
1756         * NEWS: Add entry.
1757         * infcmd.c (print_return_value_1): Handle finish_print
1758         option.
1759         (show_print_finish): New function.
1760         (_initialize_infcmd): Add "set/show print finish" commands.
1761         * valprint.c (user_print_options): Initialize new member.
1762         * valprint.h (struct value_print_options) <finish_print>: New
1763         member.
1764
1765 2019-05-28  Tom Tromey  <tromey@adacore.com>
1766
1767         * ada-lang.c (ada_remove_Xbn_suffix)
1768         (find_old_style_renaming_symbol)
1769         (parse_old_style_renaming): Remove.
1770         (ada_find_renaming_symbol): Don't call
1771         find_old_style_renaming_symbol.
1772         (ada_is_renaming_symbol): Rename from
1773         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1774         bool.  Now static.
1775         (ada_read_var_value): Update and simplify.
1776         * ada-exp.y (write_var_or_type): Remove old code.
1777
1778 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1779
1780         * event-top.c: Remove include comment.
1781         * inflow.c (class scoped_ignore_sigttou): Move from here...
1782         * inflow.h (class scoped_ignore_sigttou): ...to here.
1783         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1784         * top.c:  Remove include comment.
1785
1786 2019-05-27  Tom Tromey  <tom@tromey.com>
1787
1788         * NEWS: Fix typo.
1789
1790 2019-05-22  Tom Tromey  <tromey@adacore.com>
1791
1792         * target.c (target_follow_exec): Constify parameter.
1793         * target-delegates.c: Rebuild.
1794         * remote.c (remote_target::follow_exec): Constify parameter.
1795         * infrun.c (follow_exec): Constify parameter.
1796         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1797         (target_follow_exec): Likewise.
1798
1799 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1800
1801         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1802         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1803
1804 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1805
1806         * NEWS: Add debugredirect and testsuite sections.
1807
1808 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1809
1810         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1811         target descriptions using exclusively floating point register name
1812         aliases.
1813
1814 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1815
1816         PR gdb/18644:
1817         * f-lang.c (build_fortran_types): Handle the case where
1818         gdbarch_floatformat_for_type returns a nullptr.
1819
1820 2019-05-21  Tom de Vries  <tdevries@suse.de>
1821
1822         PR cli/24587
1823         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1824
1825 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1826
1827         PR gdb/18644:
1828         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1829         16-byte floats.
1830         * i386-tdep.c (i386_floatformat_for_type): Use
1831         floatformats_ia64_quad for the 16-byte floating point component
1832         within a fortran 32-byte complex number.
1833
1834 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1835
1836         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1837         delete default constructor.
1838         (find_partial_die): Update to return const struct.
1839         (partial_die_parent_scope): Move variable declaration into scope
1840         of its use and change its type to auto.
1841         (guess_partial_die_structure_name): Likewise.
1842         (partial_die_info::fixup): Likewise.
1843
1844 2019-05-17  Tom Tromey  <tromey@adacore.com>
1845
1846         * source.c (find_and_open_source): Remove cast.
1847
1848 2019-05-17  Tom Tromey  <tromey@adacore.com>
1849
1850         * annotate.c (annotate_source): Make "filename" const.
1851         * annotate.h (annotate_source): Use const.
1852
1853 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1854
1855         * disasm.c (set_disassembler_options): Send errors to stderr.
1856
1857 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1858
1859         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1860         (cli_interp_base::set_logging): Check debug_redirect.
1861         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1862         * cli/cli-logging.c (debug_redirect): Add static variable.
1863         (pop_output_files): Add default param.
1864         (handle_redirections): Print debug setting.
1865         (show_logging_command): Likewise.
1866         (_initialize_cli_logging): Add debugredirect command.
1867         * interps.c (current_interp_set_logging): Add debug_redirect
1868         parameter.
1869         * interps.h (set_logging): Add debug_redirect parameter.
1870         (current_interp_set_logging): Likewise.
1871         * mi/mi-common.h: Likewise.
1872         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1873
1874 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1875             Tom Tromey  <tromey@adacore.com>
1876
1877         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1878         directly.
1879         * cli/cli-interp.h (make_logging_output): Remove declaration.
1880         * cli/cli-logging.c (make_logging_output): Remove function.
1881         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1882         directly.
1883         * ui-file.c (tee_file::tee_file): Remove bools.
1884         (tee_file::~tee_file): Remove deletes.
1885         * ui-file.h (tee_file): Remove bools.
1886
1887 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1888
1889         * mi/mi-cmds.h (mi_cmd_complete): New function.
1890         * mi/mi-main.c (mi_cmd_complete): Likewise.
1891         * mi/mi-cmds.c: Define new MI command -complete.
1892         * NEWS: Mention new -complete command.
1893
1894 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1895
1896         * completer.h (complete): New function.
1897         * completer.c (complete): Likewise.
1898         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1899         function defined in completer.h.
1900
1901 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1902
1903         * MAINTAINERS (Write After Approval): Add myself.
1904
1905 2019-05-17  Tom de Vries  <tdevries@suse.de>
1906
1907         PR gdb/24094
1908         * dwarf2read.c (struct cu_partial_die_info): New struct.
1909         (find_partial_die): Return cu_partial_die_info.
1910         (partial_die_parent_scope, guess_partial_die_structure_name)
1911         (partial_die_info::fixup): Handle new return type of find_partial_die.
1912
1913 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1914
1915         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1916         "std::string", simplifying the algorithm.
1917
1918 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1919
1920         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1921         (stap_static_probe_ops::get_probes): Likewise.
1922
1923 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1924
1925         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1926         '-')" and "else if".
1927         (stap_parse_single_operand): Join checks for
1928         "gdbarch_stap_parse_special_token_p" and
1929         "gdbarch_stap_parse_special_token" in the same "if" statement.
1930         Invert check when verifying for operation on register
1931         displacement.
1932
1933 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1934
1935         * stap-probe.c (stap_get_opcode): Update comment.
1936         (stap_get_expected_argument_type): Likewise.
1937         (handle_stap_probe): Likewise.
1938
1939 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1940
1941         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1942         return type to 'bool'.  Adjust comment.  Use 'bool' when
1943         appropriate.
1944         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1945         * stap-probe.c (stap_parse_argument_1): Likewise.
1946         (stap_is_operator): Likewise.
1947         (stap_is_generic_prefix): Likewise.
1948         (stap_is_register_prefix): Likewise.
1949         (stap_is_register_indirection_prefix): Likewise.
1950         (stap_is_integer_prefix): Likewise.
1951         (stap_generic_check_suffix): Likewise.
1952         (stap_check_integer_suffix): Likewise.
1953         (stap_check_register_suffix): Likewise.
1954         (stap_check_register_indirection_suffix): Likewise.
1955         (stap_parse_register_operand): Likewise.
1956         (stap_parse_single_operand): Likewise.
1957         (stap_parse_argument_1): Likewise.
1958         (stap_probe::get_argument_count): Likewise.
1959         (stap_is_operator): Likewise.
1960
1961 2019-05-16  Tom Tromey  <tromey@adacore.com>
1962
1963         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1964         keyword to foreach.
1965
1966 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1967
1968         * linux-thread-db.c (try_thread_db_load_1): Change return type
1969         to bool.
1970         (try_thread_db_load): Likewise.
1971         (try_thread_db_load_from_pdir_1): Likewise.
1972         (try_thread_db_load_from_pdir): Likewise.
1973         (try_thread_db_load_from_sdir): Likewise.
1974         (try_thread_db_load_from_dir): Likewise.
1975         (thread_db_load_search): Likewise.
1976         (has_libpthread): Likewise.
1977         (thread_db_load): Likewise.
1978
1979 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1980
1981         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1982         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1983         NULL, and complain/return if that's the case.
1984
1985 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1986
1987         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1988         (advance, posn, abstract_read_memory): New functions.
1989         [struct mem_read_abstraction]: New struct.
1990         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1991
1992 2019-05-14  Tom Tromey  <tromey@adacore.com>
1993
1994         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1995         value is not lval_memory.
1996
1997 2019-05-14  Tom Tromey  <tromey@adacore.com>
1998
1999         * solib.c (info_sharedlibrary_command): Style the file name.
2000
2001 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2002
2003         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2004         (aarch64_vnv_type): Likewise.
2005         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2006         * common/tdesc.c: Likewise.
2007         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2008         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2009         * features/aarch64-fpu.xml: Add ieee half view.
2010         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2011         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2012         * gdbtypes.h (struct builtin_type): Likewise.
2013         (struct objfile_type): Likewise.
2014
2015 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2016
2017         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2018         typo.
2019         * location.h (string_to_event_location): Likewise.
2020
2021 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2022
2023         GDB 8.3 released.
2024
2025 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2026
2027         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2028         New variable declaration.
2029         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2030         New variable.
2031         (print_one_breakpoint): Use ui_out::test_flags and new global
2032         variable to compute use_fixed_output.
2033         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2034         Remove.
2035         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2036         (mi_multi_location_breakpoint_output_fixed): Remove.
2037         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2038         new variable.
2039         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2040         fix_multi_location_breakpoint_output flag if version >= 3.
2041         * ui-out.h (enum ui_out_flag)
2042         <fix_multi_location_breakpoint_output>: New enumerator.
2043
2044 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2045
2046         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2047
2048 2019-05-10  Tom Tromey  <tromey@adacore.com>
2049
2050         * ada-lang.c (catch_ada_completer): New function.
2051         (_initialize_ada_language): Use it.
2052
2053 2019-05-10  Tom Tromey  <tromey@adacore.com>
2054
2055         * thread.c (print_thread_info): Make "requested_threads" const.
2056         * gdbthread.h (print_thread_info): Make "requested_threads"
2057         const.
2058         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2059         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2060
2061 2019-05-08  Tom Tromey  <tom@tromey.com>
2062
2063         * gdbtypes.c (objfile_type_data): Change type.
2064         (objfile_type, _initialize_gdbtypes): Update.
2065
2066 2019-05-08  Tom Tromey  <tom@tromey.com>
2067
2068         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2069         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2070         (_initialize_dwarf2_frame): Update.
2071
2072 2019-05-08  Tom Tromey  <tom@tromey.com>
2073
2074         * objc-lang.c (objc_objfile_data): Change type.
2075         (find_methods): Update.
2076         (_initialize_objc_lang): Remove.
2077
2078 2019-05-08  Tom Tromey  <tom@tromey.com>
2079
2080         * stabsread.c (rs6000_builtin_type_data): Change type.
2081         (rs6000_builtin_type, _initialize_stabsread): Update.
2082
2083 2019-05-08  Tom Tromey  <tom@tromey.com>
2084
2085         * mips-tdep.c (mips_pdr_data): Remove.
2086         (_initialize_mips_tdep): Update.
2087
2088 2019-05-08  Tom Tromey  <tom@tromey.com>
2089
2090         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2091         (hppa_init_objfile_priv_data, read_unwind_info)
2092         (find_unwind_entry, _initialize_hppa_tdep): Update.
2093
2094 2019-05-08  Tom Tromey  <tom@tromey.com>
2095
2096         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2097         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2098         on obstack.
2099         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2100
2101 2019-05-08  Tom Tromey  <tom@tromey.com>
2102
2103         * mdebugread.c (basic_type_data): Change type.
2104         (basic_type, _initialize_mdebugread): Update.
2105
2106 2019-05-08  Tom Tromey  <tom@tromey.com>
2107
2108         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2109
2110 2019-05-08  Tom Tromey  <tom@tromey.com>
2111
2112         * nto-tdep.c (nto_inferior_data_reg): Change type.
2113         (nto_inferior_data): Update.
2114         (nto_inferior_data_cleanup, nto_new_inferior_data)
2115         (_initialize_nto_tdep): Remove.
2116         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2117
2118 2019-05-08  Tom Tromey  <tom@tromey.com>
2119
2120         * ada-lang.c (struct ada_inferior_data): Add initializers.
2121         (ada_inferior_data): Change type.
2122         (ada_inferior_data_cleanup): Remove.
2123         (get_ada_inferior_data, ada_inferior_exit)
2124         (struct ada_pspace_data): Add initializers, destructor.
2125         (ada_pspace_data_handle): Change type.
2126         (get_ada_pspace_data): Update.
2127         (ada_pspace_data_cleanup): Remove.
2128
2129 2019-05-08  Tom Tromey  <tom@tromey.com>
2130
2131         * coffread.c (struct coff_symfile_info): Add initializers.
2132         (coff_objfile_data_key): Move lower.  Change type.
2133         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2134         Update.
2135         (coff_free_info): Remove.
2136
2137 2019-05-08  Tom Tromey  <tom@tromey.com>
2138
2139         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2140         (fbsd_pspace_data_handle): Move lower.  Change type.
2141         (get_fbsd_pspace_data): Update.
2142         (fbsd_pspace_data_cleanup): Remove.
2143         (_initialize_fbsd_tdep): Update.
2144
2145 2019-05-08  Tom Tromey  <tom@tromey.com>
2146
2147         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2148         (get_ada_tasks_pspace_data): Update.
2149         (ada_tasks_pspace_data_cleanup): Remove.
2150         (_initialize_tasks): Update.
2151         (ada_tasks_inferior_data_handle): Change type.
2152         (get_ada_tasks_inferior_data): Update.
2153         (ada_tasks_inferior_data_cleanup): Remove.
2154         (struct ada_tasks_pspace_data): Add initializers.
2155
2156 2019-05-08  Tom Tromey  <tom@tromey.com>
2157
2158         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2159         * symfile-debug.c (debug_sym_get_probes): Change type.
2160         * stap-probe.c (handle_stap_probe):
2161         (stap_static_probe_ops::get_probes): Change type.
2162         * probe.h (class static_probe_ops) <get_probes>: Change type.
2163         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2164         (parse_probes_in_pspace): Update.
2165         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2166         Update.
2167         (any_static_probe_ops::get_probes): Change type.
2168         * elfread.c (elfread_data): New typedef.
2169         (probe_key): Change type.
2170         (elf_get_probes): Likewise.  Update.
2171         (probe_key_free): Remove.
2172         (_initialize_elfread): Update.
2173         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2174         Change type.
2175         (dtrace_process_dof_probe, dtrace_process_dof)
2176         (dtrace_static_probe_ops::get_probe): Change type.
2177
2178 2019-05-08  Tom Tromey  <tom@tromey.com>
2179
2180         * xcoffread.c (struct xcoff_symfile_info): Rename from
2181         coff_symfile_info.  Add initializers.
2182         (xcoff_objfile_data_key): Move lower.  Change type.
2183         (XCOFF_DATA): Rewrite.
2184         (xcoff_free_info): Remove.
2185         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2186         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2187         (xcoff_initial_scan): Update.
2188
2189 2019-05-08  Tom Tromey  <tom@tromey.com>
2190
2191         * solib-svr4.c (struct svr4_info): Add initializers and
2192         destructor.
2193         <probes_table>: Now an htab_up.
2194         (solib_svr4_pspace_data): Change type.
2195         (free_probes_table): Simplify.
2196         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2197         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2198         (probes_table_remove_objfile_probes, register_solib_event_probe)
2199         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2200         (_initialize_svr4_solib): Update.
2201
2202 2019-05-08  Tom Tromey  <tom@tromey.com>
2203
2204         * remote.c (remote_pspace_data): Change type.
2205         (remote_pspace_data_cleanup): Remove.
2206         (get_remote_exec_file, set_pspace_remote_exec_file)
2207         (_initialize_remote): Update.
2208
2209 2019-05-08  Tom Tromey  <tom@tromey.com>
2210
2211         * breakpoint.c (breakpoint_objfile_key): Change type.
2212         (get_breakpoint_objfile_data): Update.
2213         (free_breakpoint_objfile_data): Remove.
2214         (_initialize_breakpoint): Update.
2215
2216 2019-05-08  Tom Tromey  <tom@tromey.com>
2217
2218         * linux-tdep.c (struct linux_info): Add initializers.
2219         (linux_inferior_data): Move.  Change type.
2220         (invalidate_linux_cache_inf): Update.
2221         (linux_inferior_data_cleanup): Remove.
2222         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2223
2224 2019-05-08  Tom Tromey  <tom@tromey.com>
2225
2226         * auxv.c (auxv_inferior_data): Move.  Change type.
2227         (auxv_inferior_data_cleanup): Remove.
2228         (invalidate_auxv_cache_inf): Rewrite.
2229         (get_auxv_inferior_data, _initialize_auxv): Update.
2230
2231 2019-05-08  Tom Tromey  <tom@tromey.com>
2232
2233         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2234         (symfile_debug_objfile_data_key): Change type.
2235         (symfile_debug_installed, debug_qf_has_symbols)
2236         (debug_qf_find_last_source_symtab)
2237         (debug_qf_forget_cached_source_info)
2238         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2239         (debug_qf_print_stats, debug_qf_dump)
2240         (debug_qf_expand_symtabs_for_function)
2241         (debug_qf_expand_all_symtabs)
2242         (debug_qf_expand_symtabs_with_fullname)
2243         (debug_qf_map_matching_symbols)
2244         (debug_qf_expand_symtabs_matching)
2245         (debug_qf_find_pc_sect_compunit_symtab)
2246         (debug_qf_map_symbol_filenames)
2247         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2248         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2249         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2250         (debug_sym_read_linetable, debug_sym_relocate): Update.
2251         (symfile_debug_free_objfile): Remove.
2252         (install_symfile_debug_logging, _initialize_symfile_debug):
2253         Update.
2254
2255 2019-05-08  Tom Tromey  <tom@tromey.com>
2256
2257         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2258         allocate_on_obstack.
2259         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2260         (get_dwarf2_per_objfile): Update.
2261         (set_dwarf2_per_objfile): Remove.
2262         (dwarf2_has_info, dwarf2_get_section_info): Update.
2263         (dwarf2_free_objfile): Remove.
2264         (_initialize_dwarf2_read): Update.
2265
2266 2019-05-08  Tom Tromey  <tom@tromey.com>
2267
2268         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2269         initializers.
2270         <unsupported_script_warning_printed,
2271         script_not_found_warning_printed>: Now bool.
2272         (auto_load_pspace_data): Change type.
2273         (~auto_load_pspace_info): Rename from
2274         auto_load_pspace_data_cleanup.
2275         (get_auto_load_pspace_data, init_loaded_scripts_info)
2276         (clear_section_scripts, maybe_print_unsupported_script_warning)
2277         (maybe_print_script_not_found_warning, _initialize_auto_load):
2278         Update.
2279
2280 2019-05-08  Tom Tromey  <tom@tromey.com>
2281
2282         * objfiles.c (objfile_pspace_info): Add destructor and
2283         initializers.
2284         (objfiles_pspace_data): Change type.
2285         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2286         (get_objfile_pspace_data): Update.
2287         (objfiles_bfd_data): Change type.
2288         (get_objfile_bfd_data): Update.
2289         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2290
2291 2019-05-08  Tom Tromey  <tom@tromey.com>
2292
2293         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2294         Change type.
2295         (get_catch_syscall_inferior_data): Update.
2296         (catch_syscall_inferior_data_cleanup): Remove.
2297         (_initialize_break_catch_syscall): Update.
2298
2299 2019-05-08  Tom Tromey  <tom@tromey.com>
2300
2301         * inflow.c (struct terminal_info): Add destructor and
2302         initializers.
2303         (inflow_inferior_data): Change type.
2304         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2305         (get_inflow_inferior_data, inflow_inferior_exit)
2306         (swap_terminal_info, _initialize_inflow): Update.
2307
2308 2019-05-08  Tom Tromey  <tom@tromey.com>
2309
2310         * target-dcache.c (target_dcache_cleanup): Remove.
2311         (target_dcache_aspace_key): Change type.
2312         (target_dcache_init_p, target_dcache_invalidate)
2313         (target_dcache_get, target_dcache_get_or_init)
2314         (_initialize_target_dcache): Update.
2315         * dcache.h (struct dcache_deleter): New.
2316
2317 2019-05-08  Tom Tromey  <tom@tromey.com>
2318
2319         * symtab.c (struct symbol_cache): Add destructor and
2320         initializers.
2321         (symbol_cache_key): Move.  Change type.
2322         (make_symbol_cache, free_symbol_cache): Remove.
2323         (get_symbol_cache): Update.
2324         (symbol_cache_cleanup): Remove.
2325         (ALL_PSPACES, symbol_cache_flush)
2326         (maintenance_print_symbol_cache)
2327         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2328         Update.
2329
2330 2019-05-08  Tom Tromey  <tom@tromey.com>
2331
2332         * symtab.c (struct main_info): Add destructor and initializers.
2333         (main_progspace_key): Move.  Change type.
2334         (get_main_info): Update.
2335         (main_info_cleanup): Remove.
2336         (_initialize_symtab): Update.
2337
2338 2019-05-08  Tom Tromey  <tom@tromey.com>
2339
2340         * registry.h (DECLARE_REGISTRY): Define the _key class.
2341
2342 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2343
2344         * NEWS: Merge two 'New commands' sections.
2345
2346 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2347
2348         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2349         parameter and use Ada language definition instead.
2350         (ada_val_print_ptr): Remove unused language parameter.
2351         (ada_val_print_num): Remove language parameter and use Ada language
2352         definition instead.
2353         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2354         parameter.
2355         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2356         parameter and use Ada language definition instead.
2357         (ada_val_print_1): Update all ada_val_print_xxx calls.
2358         Remove language parameter.
2359         (ada_val_print): Update ada_val_print_1 call.
2360
2361 2019-05-08  Tom Tromey  <tromey@adacore.com>
2362
2363         * remote.c (remote_hw_watchpoint_limit)
2364         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2365         Now static.
2366
2367 2019-05-08  Tom Tromey  <tromey@adacore.com>
2368
2369         * maint.c (_initialize_maint_cmds): Move initialization code to
2370         remote.c.
2371         (watchdog, show_watchdog): Move to remote.c.
2372         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2373         "watchdog" static.
2374         (_initialize_remote): Move initialization code from maint.c.
2375         * defs.h (watchdog): Don't declare.
2376
2377 2019-05-08  Tom Tromey  <tromey@adacore.com>
2378
2379         * tui/tui-interp.c: Include main.h.
2380         * interps.c: Include main.h.
2381         * main.h (interpreter_p): Declare.
2382         * defs.h (interpreter_p): Don't declare.
2383
2384 2019-05-08  Tom Tromey  <tromey@adacore.com>
2385
2386         * dwarf2loc.c: Include dwarf2read.h.
2387         * defs.h (read_unsigned_leb128): Don't declare.
2388         * dwarf2read.h (read_unsigned_leb128): Declare.
2389
2390 2019-05-08  Tom Tromey  <tromey@adacore.com>
2391
2392         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2393         method.
2394
2395 2019-05-08  Tom Tromey  <tromey@adacore.com>
2396
2397         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2398         when no wrap column is set.
2399
2400 2019-05-08  Tom Tromey  <tromey@adacore.com>
2401
2402         * c-lang.c (c_get_string): Handle non-C-style arrays.
2403
2404 2019-05-08  Tom Tromey  <tromey@adacore.com>
2405
2406         * typeprint.c (print_offset_data::update): Print the bit offset,
2407         not the number of bits remaining.
2408
2409 2019-05-08  Tom Tromey  <tromey@adacore.com>
2410
2411         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2412         padding at end of comment.
2413
2414 2019-05-08  Tom Tromey  <tromey@adacore.com>
2415
2416         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2417         Compare main types.
2418
2419 2019-05-06  Tom Tromey  <tom@tromey.com>
2420
2421         * common/scoped_mmap.c: Include common-defs.h.
2422         * common/scoped_mmap.h: Don't include config.h.
2423
2424 2019-05-04  Tom Tromey  <tom@tromey.com>
2425
2426         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2427         (struct aarch64_call_info): Add initializers.
2428         <si>: Now a std::vector.
2429         (pass_on_stack, aarch64_push_dummy_call): Update.
2430
2431 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2432             Tom Tromey  <tom@tromey.com>
2433
2434         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2435         (ppc_threads): Now a std::vector.  Now static.
2436         (hwdebug_find_thread_points_by_tid)
2437         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2438         Update.
2439
2440 2019-05-04  Tom Tromey  <tom@tromey.com>
2441
2442         * arc-tdep.c (arc_tdesc_init): Return bool.
2443
2444 2019-05-04  Tom Tromey  <tom@tromey.com>
2445
2446         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2447         Use gdb_assert_not_reached.
2448
2449 2019-05-04  Tom Tromey  <tom@tromey.com>
2450
2451         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2452         "false".
2453
2454 2019-05-04  Tom Tromey  <tom@tromey.com>
2455
2456         * arc-tdep.c (arc_tdesc_init): Use bool.
2457
2458 2019-05-04  Tom Tromey  <tom@tromey.com>
2459
2460         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2461
2462 2019-05-04  Tom Tromey  <tom@tromey.com>
2463
2464         * cli/cli-cmds.c (valid_command_p): Return bool.
2465
2466 2019-05-04  Tom Tromey  <tom@tromey.com>
2467
2468         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2469         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2470
2471 2019-05-04  Raul Tambre  <raul@tambre.ee>
2472
2473         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2474         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2475         operator for comparison.
2476
2477 2019-05-04  Tom Tromey  <tom@tromey.com>
2478
2479         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2480         (lookup_partial_symbol, print_partial_symbols)
2481         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2482         (psymbol_compare): Update.
2483         (add_psymbol_to_bcache): Clear the entire psymbol.
2484         (maintenance_check_psymtabs): Update.
2485         * psympriv.h (struct partial_symbol): Don't derive from
2486         general_symbol_info.
2487         <obj_section, unrelocated_address, address,
2488         set_unrelocated_address>: Update.
2489         <ginfo>: New member.
2490         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2491         (debug_names::write_psymbols): Update.
2492
2493 2019-05-04  Tom de Vries  <tdevries@suse.de>
2494
2495         * contrib/cc-with-tweaks.sh: Support -n arg.
2496
2497 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2498
2499         * corelow.c (core_target::detach): Ensure frame cache and
2500         register caches are cleared.
2501         inferior.c (exit_inferior_1): Likewise.
2502
2503 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2504             Tom Tromey  <tom@tromey.com>
2505
2506         * dictionary.c (collate_pending_symbols_by_language): Remove
2507         "struct" from foreach.
2508         * symtab.c (lookup_global_symbol_from_objfile)
2509         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2510         foreach.
2511         * ser-tcp.c (net_open): Remove "struct" from foreach.
2512         * objfiles.c (objfile_relocate, objfile_rebase)
2513         (objfile_has_symbols): Remove "struct" from foreach.
2514         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2515         from foreach.
2516         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2517         foreach.
2518         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2519         "struct" from foreach.
2520         * ada-lang.c (create_excep_cond_exprs)
2521         (ada_exception_catchpoint_cond_string): Remove "struct" from
2522         foreach.
2523
2524 2019-05-03  Tom Tromey  <tromey@adacore.com>
2525
2526         * ada-exp.y (convert_char_literal): Check suffix of each
2527         enumerator.
2528
2529 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2530
2531         PR ada/21406:
2532         * ada-exp.y (yywrap): Don't define.
2533         * ada-lex.l (%option): Add noyywrap
2534         (yywrap): Remove.
2535
2536 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2537
2538         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2539         _WIN32_WINNT to the XP level, unless already defined to a higher
2540         level.
2541
2542         * unittests/parse-connection-spec-selftests.c:
2543         * ser-tcp.c:
2544         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2545         override.
2546
2547         * symfile.c (find_separate_debug_file): Remove colon from the
2548         drive spec of DOS/Windows file names of the target, so that the
2549         file name produced from DEBUGDIR and the target's directory will
2550         be valid on DOS/Windows systems.
2551
2552 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * rust-lang.c (val_print_struct): Handle printing structures
2555         containing strings.
2556
2557 2019-05-02  Tom Tromey  <tromey@adacore.com>
2558
2559         * valarith.c (_initialize_valarith): Remove.
2560
2561 2019-05-01  Tom Tromey  <tromey@adacore.com>
2562
2563         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2564         bitfields.
2565
2566 2019-05-01  Tom Tromey  <tromey@adacore.com>
2567
2568         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2569         for big-endian copies.
2570
2571 2019-04-30  Ali Tamur  <tamur@google.com>
2572         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2573         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2574         (read_3_bytes): New function.
2575
2576 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2577
2578         * windows-nat.c (main_thread_id): Delete.
2579         (handle_output_debug_string): Replace main_thread_id by
2580         current_event.dwThreadId.
2581         (fake_create_process): Likewise.
2582         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2583         Do not set main_thread_id.
2584         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2585         current_event.dwThreadId.
2586         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2587
2588 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2589
2590         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2591         Use current_event.dwThreadId instead of main_thread_id.
2592
2593 2019-04-30  Tom Tromey  <tromey@adacore.com>
2594
2595         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2596         (create_excep_cond_exprs): Iterate over program spaces.
2597         (ada_exception_catchpoint_cond_string): Examine all minimal
2598         symbols for exception types.
2599
2600 2019-04-30  Tom Tromey  <tromey@adacore.com>
2601
2602         PR c++/24470:
2603         * dwarf2read.c (process_structure_scope): Handle case where type
2604         has template parameters but no symbol was created.
2605
2606 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2607             Chris January  <chris.january@arm.com>
2608
2609         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2610         qualifier.
2611         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2612
2613 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2614
2615         * f-typeprint.c (f_print_type): Update rules for printing
2616         whitespace.
2617         (f_type_print_varspec_suffix): Likewise.
2618
2619 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2620             Chris January  <chris.january@arm.com>
2621
2622         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2623         function arguments.
2624
2625 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * f-lang.c (build_fortran_types): Change name of void type to
2628         lower case.
2629         * f-typeprint.c (f_type_print_base): Print the name of the void
2630         type, rather than a fixed string.
2631         * f-valprint.c (f_decorations): Use lower case void string.
2632
2633 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2634             Chris January  <chris.january@arm.com>
2635
2636         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2637         types for Fortran.
2638
2639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2640             Chris January  <chris.january@arm.com>
2641             David Lecomber  <david.lecomber@arm.com>
2642
2643         * f-exp.y (BINOP_INTRINSIC): New token.
2644         (exp): New parser rule handling BINOP_INTRINSIC.
2645         (f77_keywords): Add new builtin procedures.
2646         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2647         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2648         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2649         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2650         (print_unop_subexp_f): New function.
2651         (print_binop_subexp_f): New function.
2652         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2653         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2654         (dump_subexp_body_f): Likewise.
2655         (operator_check_f): Likewise.
2656         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2657         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2658
2659 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2660
2661         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2662         UNOP_KIND.
2663         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2664         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2665         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2666         (operator_length_f): New fuction.
2667         (print_subexp_f): New function.
2668         (op_name_f): New function.
2669         (dump_subexp_body_f): New function.
2670         (operator_check_f): New function.
2671         (exp_descriptor_f): Replace standard expression handling functions
2672         with new functions.
2673         * gdb/fortran-operator.def: New file.
2674         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2675         * gdb/std-operator.def: Remove UNOP_KIND.
2676
2677 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * std-operator.def: Remove unbalanced, stray double quote
2680         character.
2681
2682 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2683             Chris January  <chris.january@arm.com>
2684             Daniel Everett  <daniel.everett@arm.com>
2685             Nick Forrington  <nick.forrington@arm.com>
2686             Richard Bunt  <richard.bunt@arm.com>
2687
2688         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2689         of depth when printing anonymous structs or unions.
2690         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2691         Don't print either the top-level value, or the children if the
2692         max-depth is exceeded.
2693         (ppscm_print_children): When printing the key of a map, allow one
2694         extra level of depth.
2695         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2696         print either the top-level value, or the children if the max-depth
2697         is exceeded.
2698         (print_children): When printing the key of a map, allow one extra
2699         level of depth.
2700         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2701         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2702         (user_print_options): Initialise max_depth field.
2703         (val_print_scalar_or_string_type_p): New function.
2704         (val_print): Check to see if the max depth has been reached.
2705         (val_print_check_max_depth): Define new function.
2706         (show_print_max_depth): New function.
2707         (_initialize_valprint): Add 'print max-depth' option.
2708         * valprint.h (struct value_print_options) <max_depth>: New field.
2709         (val_print_check_max_depth): Declare new function.
2710         * NEWS: Document new feature.
2711
2712 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2713
2714         * ada-lang.c (ada_language_defn): Initialise new field.
2715         * c-lang.c (c_is_string_type_p): New function.
2716         (c_language_defn): Initialise new field.
2717         (cplus_language_defn): Initialise new field.
2718         (asm_language_defn): Initialise new field.
2719         (minimal_language_defn): Initialise new field.
2720         * c-lang.h (c_is_string_type_p): Declare new function.
2721         * d-lang.c (d_language_defn): Initialise new field.
2722         * f-lang.c (f_is_string_type_p): New function.
2723         (f_language_defn): Initialise new field.
2724         * go-lang.c (go_is_string_type_p): New function.
2725         (go_language_defn): Initialise new field.
2726         * language.c (default_is_string_type_p): New function.
2727         (unknown_language_defn): Initialise new field.
2728         (auto_language_defn): Initialise new field.
2729         * language.h (struct language_defn) <la_is_string_type_p>: New
2730         member variable.
2731         (default_is_string_type_p): Declare new function.
2732         * m2-lang.c (m2_language_defn): Initialise new field.
2733         * objc-lang.c (objc_language_defn): Initialise new field.
2734         * opencl-lang.c (opencl_language_defn): Initialise new field.
2735         * p-lang.c (pascal_is_string_type_p): New function.
2736         (pascal_language_defn): Initialise new field.
2737         * rust-lang.c (rust_is_string_type_p): New function.
2738         (rust_language_defn): Initialise new field.
2739
2740 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2741
2742         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2743         New field.
2744         * ada-lang.c (ada_language_defn): Initialise new field.
2745         * c-lang.c (c_language_defn): Likewise.
2746         (cplus_language_defn): Likewise.
2747         (asm_language_defn): Likewise.
2748         (minimal_language_defn): Likewise.
2749         * d-lang.c (d_language_defn): Likewise.
2750         * f-lang.c (f_language_defn): Likewise.
2751         * go-lang.c (go_language_defn): Likewise.
2752         * language.c (unknown_language_defn): Likewise.
2753         (auto_language_defn): Likewise.
2754         * m2-lang.c (m2_language_defn): Likewise.
2755         * objc-lang.c (objc_language_defn): Likewise.
2756         * opencl-lang.c (opencl_language_defn): Likewise.
2757         * p-lang.c (pascal_language_defn): Likewise.
2758         * rust-lang.c (rust_language_defn): Likewise.
2759
2760 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2761
2762         * ada-lang.c (ada_is_character_type): Change return type to bool.
2763         (ada_is_string_type): Likewise.
2764         * ada-lang.h (ada_is_character_type): Update declaration
2765         (ada_is_string_type): Likewise.
2766
2767 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2768
2769         Support style in 'frame|thread apply'
2770
2771         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2772         * record.c (record_start, record_stop): Update callers of
2773         execute_command_to_string with false.
2774         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2775         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2776         methods.
2777         (class string_file): New constructor with term_out parameter.
2778         Override methods term_out and can_emit_style_escape.  New member
2779         term_out.
2780         (class stdio_file): Override can_emit_style_escape.
2781         (class tee_file): Override term_out and can_emit_style_escape.
2782         * utils.h (can_emit_style_escape): Remove.
2783         * utils.c (can_emit_style_escape): Likewise.
2784         Update all callers of can_emit_style_escape (SOMESTREAM) to
2785         SOMESTREAM->can_emit_style_escape.
2786         * source-cache.c (source_cache::get_source_lines): Likewise.
2787         * stack.c (frame_apply_command_count): Call execute_command_to_string
2788         passing the term_out characteristic of the current gdb_stdout.
2789         * thread.c (thr_try_catch_cmd): Likewise.
2790         * top.c (execute_command_to_string): pass term_out parameter
2791         to construct the string_file for the command output.
2792         * ui-file.c (term_cli_styling): New function (most code moved
2793         from utils.c can_emit_style_escape).
2794         (string_file::string_file, string_file::can_emit_style_escape,
2795         stdio_file::can_emit_style_escape, tee_file::term_out,
2796         tee_file::can_emit_style_escape): New functions.
2797
2798 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2799
2800         * NEWS: Mention the new set|show may-call-functions.
2801         * infcall.c (may_call_functions_p): New variable.
2802         (show_may_call_functions_p): New function.
2803         (call_function_by_hand_dummy): Throws an error if not
2804         may-call-functions.
2805         (_initialize_infcall): Call add_setshow_boolean_cmd for
2806         may-call-functions.
2807
2808 2019-04-25  Keith Seitz  <keiths@redhat.com>
2809
2810         PR c++/24367
2811         * cp-support.c (inspect_type): Don't attempt substitutions
2812         of symbol with the same name.
2813
2814 2019-04-25  Tom Tromey  <tromey@adacore.com>
2815
2816         PR gdb/24475:
2817         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2818         static.
2819
2820 2019-04-25  Tom Tromey  <tromey@adacore.com>
2821
2822         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2823         rvalue reference.
2824         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2825         (gdb_xml_parser::parse): Use std::move.
2826         * python/python-internal.h (gdbpy_convert_exception): Take a const
2827         reference.
2828         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2829         std::move.
2830         * python/py-utils.c (gdbpy_convert_exception): Take a const
2831         reference.
2832         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2833         Use std::move.
2834         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2835         Use std::move.
2836         * mi/mi-main.c (mi_print_exception): Take a const reference.
2837         * main.c (handle_command_errors): Take a const reference.
2838         * linespec.c (parse_linespec): Use std::move.
2839         * infcall.c (run_inferior_call): Use std::move.
2840         (call_function_by_hand_dummy): Use std::move.
2841         * exec.c (try_open_exec_file): Use std::move.
2842         * exceptions.h (exception_print, exception_fprintf)
2843         (exception_print_same): Update.
2844         * exceptions.c (print_exception, exception_print)
2845         (exception_fprintf, exception_print_same): Change parameters to
2846         const reference.
2847         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2848         * common/new-op.c: Use std::move.
2849         * common/common-exceptions.h (struct gdb_exception): Add move
2850         constructor.
2851         (struct gdb_exception_error, struct gdb_exception_quit, struct
2852         gdb_quit_bad_alloc): Change constructor to move constructor.
2853         (throw_exception): Change parameter to rvalue reference.
2854         * common/common-exceptions.c (throw_exception): Take rvalue
2855         reference.
2856         * cli/cli-interp.c (safe_execute_command): Use std::move.
2857         * breakpoint.c (insert_bp_location, location_to_sals): Use
2858         std::move.
2859
2860 2019-04-25  Tom Tromey  <tromey@adacore.com>
2861
2862         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2863         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2864         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2865         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2866         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2867         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2868         guile/scm-value.c: Use unpack.
2869         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2870         gdbscm_gdb_exception.
2871         (gdbscm_throw_gdb_exception): Likewise.
2872         (struct gdbscm_gdb_exception): New.
2873         (unpack): New function.
2874         (gdbscm_wrap): Use unpack.
2875
2876 2019-04-25  Tom Tromey  <tromey@adacore.com>
2877
2878         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2879         (gdb_rl_callback_handler): Use std::move.
2880         * common/common-exceptions.h (struct gdb_exception): Add move
2881         assignment operator.
2882         (throw_exception_sjlj): Change "exception" to const reference.
2883         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2884         (throw_exception_sjlj): Change "exception" to const reference.
2885
2886 2019-04-25  Tom Tromey  <tromey@adacore.com>
2887
2888         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2889         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2890         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2891         Update.
2892         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2893         Update.
2894         * mi/mi-interp.c (mi_interp::exec): Update.
2895         * linespec.c (parse_linespec): Update.
2896         * infcall.c (run_inferior_call): Update.
2897         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2898         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2899         (gdbscm_lookup_global_symbol): Update.
2900         * guile/scm-param.c (gdbscm_parameter_value): Update.
2901         * guile/scm-frame.c (gdbscm_frame_read_register)
2902         (gdbscm_frame_read_var): Update.
2903         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2904         * exec.c (try_open_exec_file): Update.
2905         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2906         (gdb_rl_callback_handler): Update.
2907         * common/common-exceptions.h (exception_none): Don't declare.
2908         * common/common-exceptions.c (exception_none): Don't define.
2909         (struct catcher) <exception>: Update.
2910         * cli/cli-interp.c (safe_execute_command): Update.
2911         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2912
2913 2019-04-25  Ali Tamur  <tamur@google.com>
2914
2915         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2916         (read_attribute_value): Likewise.
2917         (dwarf2_read_addr_index): Update comment.
2918         (read_str_index): Add DW_FORM_strx.
2919         (dwarf2_string_attr): Likewise.
2920         (dwarf2_const_value_attr): Likewise.
2921         (dump_die_shallow): Likewise.
2922         (dwarf2_fetch_constant_bytes): Likewise.
2923         (skip_form_bytes): Likewise.
2924         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2925
2926 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2927
2928         PR corefiles/11608
2929         PR corefiles/18187
2930         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2931         OFFSET.  Verify if current mapping contains an ELF header.
2932         (linux_find_memory_regions_full): Adjust call to
2933         dump_mapping_p.
2934
2935 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2936             Kang Li <kanglictf@gmail.com>
2937
2938         PR gdb/21600
2939
2940         * dwarf2-frame.c (read_initial_length): Be consistent about using
2941         unsigned representation of length.
2942         (decode_frame_entry_1): Likewise.  Check for wraparound of
2943         end pointer as well as buffer overflow.
2944
2945 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2946
2947         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2948         "vq".
2949
2950 2019-04-24  Tom Tromey  <tromey@adacore.com>
2951
2952         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2953
2954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * s12z-tdep.c (s12z_unwind_pc): Delete.
2957         (s12z_unwind_sp): Delete.
2958         (s12z_gdbarch_init): Don't register deleted functions with
2959         gdbarch.
2960
2961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2962
2963         * rl78-tdep.c (rl78_unwind_sp): Delete.
2964         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2965
2966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2969         (xstormy16_unwind_pc): Delete.
2970         (xstormy16_dummy_id): Delete.
2971         (xstormy16_gdbarch_init): Don't register deleted functions with
2972         gdbarch.
2973
2974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * vax-tdep.c (vax_unwind_pc): Delete.
2977         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2978
2979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2980
2981         * v850-tdep.c (v850_unwind_sp): Delete.
2982         (v850_unwind_pc): Delete.
2983         (v850_dummy_id): Delete.
2984         (v850_gdbarch_init): Don't register deleted functions with
2985         gdbarch.
2986
2987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2988
2989         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2990         (tilegx_unwind_pc): Delete.
2991         (tilegx_unwind_dummy_id): Delete.
2992         (tilegx_gdbarch_init): Don't register deleted functions with
2993         gdbarch.
2994
2995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2998         (tic6x_dummy_id): Delete.
2999         (tic6x_gdbarch_init): Don't register deleted functions with
3000         gdbarch.
3001
3002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * sparc-tdep.c (sparc_unwind_pc): Delete.
3005         (sparc32_gdbarch_init): Don't register deleted function with
3006         gdbarch.
3007
3008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * sh-tdep.c (sh_unwind_sp): Delete.
3011         (sh_unwind_pc): Delete.
3012         (sh_dummy_id): Delete.
3013         (sh_gdbarch_init): Don't register deleted functions with
3014         gdbarch.
3015
3016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * score-tdep.c (score_unwind_sp): Delete.
3019         (score_unwind_pc): Delete.
3020         (score_dummy_id): Delete.
3021         (score_gdbarch_init): Don't register deleted functions with
3022         gdbarch.
3023
3024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * rx-tdep.c (rx_unwind_pc): Delete.
3027         (rx_unwind_sp): Delete.
3028         (rx_dummy_id): Delete.
3029         (rx_gdbarch_init): Don't register deleted functions with
3030         gdbarch.  Update comment.
3031
3032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3035         (rs6000_dummy_id): Delete.
3036         (rs6000_gdbarch_init): Don't register deleted functions with
3037         gdbarch.
3038
3039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3040
3041         * or1k-tdep.c (or1k_dummy_id): Delete.
3042         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3043
3044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3045
3046         * nios2-tdep.c (nios2_dummy_id): Delete.
3047         (nios2_unwind_sp): Delete.
3048         (nios2_gdbarch_init): Don't register deleted functions with
3049         gdbarch.
3050
3051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * nds32-tdep.c (nds32_dummy_id): Delete.
3054         (nds32_unwind_pc): Delete.
3055         (nds32_unwind_sp): Delete.
3056         (nds32_gdbarch_init): Don't register deleted functions with
3057         gdbarch.
3058
3059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3060
3061         * msp430-tdep.c (msp430_unwind_pc): Delete.
3062         (msp430_unwind_sp): Delete.
3063         (msp430_dummy_id): Delete.
3064         (msp430_gdbarch_init): Don't register deleted functions with
3065         gdbarch.
3066
3067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3068
3069         * moxie-tdep.c (moxie_unwind_sp): Delete.
3070         (moxie_unwind_pc): Delete.
3071         (moxie_dummy_id): Delete.
3072         (moxie_gdbarch_init): Don't register deleted functions with
3073         gdbarch.
3074
3075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3076
3077         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3078         (mn10300_unwind_pc): Delete.
3079         (mn10300_unwind_sp): Delete.
3080         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3081         mn10300_unwind_sp.
3082         (mn10300_frame_unwind_init): Don't register deleted functions with
3083         gdbarch.
3084
3085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3086
3087         * mep-tdep.c (mep_unwind_pc): Delete.
3088         (mep_unwind_sp): Delete.
3089         (mep_dummy_id): Delete.
3090         (mep_gdbarch_init): Don't register deleted functions with
3091         gdbarch.
3092
3093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3096         (m68hc11_unwind_sp): Delete.
3097         (m68hc11_gdbarch_init): Don't register deleted functions with
3098         gdbarch.
3099
3100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * m32r-tdep.c (m32r_unwind_sp): Delete.
3103         (m32r_unwind_pc): Delete.
3104         (m32r_dummy_id): Delete.
3105         (m32r_gdbarch_init): Don't register deleted functions with
3106         gdbarch.
3107
3108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3109
3110         * m32c-tdep.c (m32c_unwind_pc): Delete.
3111         (m32c_unwind_sp): Delete.
3112         (m32c_dummy_id): Delete.
3113         (m32c_gdbarch_init): Don't register deleted functions with
3114         gdbarch.
3115
3116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3117
3118         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3119         (lm32_unwind_pc): Delete.
3120         (lm32_dummy_id): Delete.
3121         (lm32_gdbarch_init): Don't register deleted functions with
3122         gdbarch.
3123
3124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3125
3126         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3127         (iq2000_unwind_pc): Delete.
3128         (iq2000_dummy_id): Delete.
3129         (iq2000_gdbarch_init): Don't register deleted functions with
3130         gdbarch.
3131
3132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3133
3134         * nds32-tdep.c (nds32_type_align): Delete.
3135         (nds32_push_dummy_call): Use type_align instead.
3136
3137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3138
3139         * arm-tdep.c (arm_type_align): Only handle vector override case.
3140         (arm_push_dummy_call): Use type_align.
3141         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3142
3143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3146         case.
3147         (pass_on_stack): Use type_align.
3148         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3149         function.
3150
3151 2019-04-23  Tom Tromey  <tromey@adacore.com>
3152
3153         * dwarf2read.c (line_header::file_name_at): Remove unused
3154         overload.
3155
3156 2019-04-23  Tom de Vries  <tdevries@suse.de>
3157
3158         PR gdb/24438
3159         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3160         invocation.
3161
3162
3163 2019-03-27  Ali Tamur  <tamur@google.com>
3164
3165         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3166         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3167         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3168         (dwarf_expr_context::get_addr_index): Likewise
3169         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3170         (symbol_needs_eval_context::get_addr_index): Likewise
3171         (disassemble_dwarf_expression): Add DW_OP_addrx
3172         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3173         (read_cutu_die_from_dwo): Update comment
3174         (skip_one_die): Add DW_FORM_addrx
3175         (read_attribute_value): Likewise
3176         (var_decode_location): Add DW_OP_addrx
3177         (dwarf2_const_value_attr): Add DW_FORM_addrx
3178         (dump_die_shallow): Likewise
3179         (dwarf2_fetch_constant_bytes): Likewise
3180         (decode_locdesc): Add DW_OP_addrx
3181         (skip_form_bytes): Add DW_FORM_addrx
3182
3183 2019-04-22  Ali Tamur  <tamur@google.com>
3184
3185         * MAINTAINERS (Write After Approval): Add self.
3186
3187 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3188
3189         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3190         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3191         (open_symbol_file_object): Likewise.
3192         (svr4_default_sos): Add info parameter.
3193         (svr4_read_so_list): Likewise.
3194         (svr4_current_sos_direct): Adjust functions calls to pass down
3195         info.
3196         (svr4_current_sos_1): Add info parameter.
3197         (svr4_current_sos): Call get_svr4_info, pass info down to
3198         svr4_current_sos_1.
3199         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3200         get_svr4_info.
3201         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3202         get_svr4_info.
3203         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3204         to get_svr4_info.
3205         (probes_table_remove_objfile_probes): Likewise.
3206         (register_solib_event_probe): Add info parameter.
3207         (solist_update_incremental): Pass info parameter down to
3208         svr4_read_so_list.
3209         (disable_probes_interface): Add info parameter.
3210         (svr4_handle_solib_event): Pass current_program_space to
3211         get_svr4_info.  Adjust disable_probes_interface cleanup.
3212         (svr4_create_probe_breakpoints): Add info parameter, pass it
3213         down to register_solib_event_probe.
3214         (svr4_create_solib_event_breakpoints): Add info parameter,
3215         pass it down to svr4_create_probe_breakpoints.
3216         (enable_break): Pass info down to
3217         svr4_create_solib_event_breakpoints.
3218         (svr4_solib_create_inferior_hook): Pass current_program_space to
3219         get_svr4_info.
3220         (svr4_clear_solib): Likewise.
3221
3222 2019-04-22  Pedro Alves  <palves@redhat.com>
3223
3224         * solib-svr4.c (svr4_free_objfile_observer): New.
3225         (probe_and_action::objfile): New field.
3226         (probes_table_htab_remove_objfile_probes)
3227         (probes_table_remove_objfile_probes): New functions.
3228         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3229         in the new probe_and_action.  Don't store the probe in 'lookup'.
3230         (svr4_create_probe_breakpoints): Pass objfile to
3231         register_solib_event_probe.
3232         (_initialize_svr4_solib): Register a free_objfile observer.
3233
3234 2019-04-19  Tom Tromey  <tom@tromey.com>
3235
3236         * common/queue.h: Remove.
3237
3238 2019-04-19  Tom Tromey  <tom@tromey.com>
3239
3240         * event-loop.c: Don't include "common/queue.h".
3241
3242 2019-04-19  Tom Tromey  <tom@tromey.com>
3243
3244         * remote.c (remote_target): Use delete.
3245         * remote-notif.h: Include <list>, not "common/queue.h".
3246         (notif_client_p): Remove typedef.
3247         (remote_notif_state): Add constructor, destructor, initializer.
3248         <notif_queue>: Now a std::list.
3249         (remote_notif_state_xfree): Don't declare.
3250         * remote-notif.c (remote_notif_process, handle_notification)
3251         (remote_notif_state_allocate): Update.
3252         (~remote_notif_state): Rename from remote_notif_state_xfree.
3253
3254 2019-04-19  Tom Tromey  <tom@tromey.com>
3255
3256         * symfile.c (reread_symbols): Update.
3257         * objfiles.c (objfile_register_static_link)
3258         (objfile_lookup_static_link): Update
3259         (~objfile) Don't delete static_links.
3260         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3261
3262 2019-04-19  Tom Tromey  <tom@tromey.com>
3263
3264         * type-stack.h (struct type_stack) <insert>: Constify string.
3265         * type-stack.c (type_stack::insert): Constify string.
3266         * gdbtypes.h (lookup_template_type): Update.
3267         (address_space_name_to_int): Update.
3268         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3269         const.
3270         (lookup_template_type): Make name const.
3271         * c-exp.y: Update rules.
3272         (lex_one_token, classify_name, classify_inner_name)
3273         (c_print_token): Update.
3274         * p-exp.y: Update rules.
3275         (yylex): Update.
3276         * f-exp.y: Update rules.
3277         (yylex): Update.
3278         * d-exp.y: Update rules.
3279         (lex_one_token, classify_name, classify_inner_name): Update.
3280         * parse.c (write_dollar_variable, copy_name): Return std::string.
3281         * parser-defs.h (copy_name): Change return type.
3282         * m2-exp.y: Update rules.
3283         (yylex): Update.
3284         * go-exp.y (lex_one_token): Update.
3285         Update rules.
3286         (classify_unsafe_function, classify_packaged_name)
3287         (classify_name, yylex): Update.
3288
3289 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3290
3291         * configure.ac: add --enable-source-highlight switch.
3292         * configure: Regenerate.
3293         * top.c (print_gdb_version): plumb --enable-source-highlight
3294         status to "show configuration".
3295
3296 2019-04-19  Tom Tromey  <tromey@adacore.com>
3297
3298         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3299         Check ADA_TYPE_P.
3300         (empty_record, ada_template_to_fixed_record_type_1)
3301         (template_to_static_fixed_type)
3302         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3303         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3304         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3305         macros.
3306
3307 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3308
3309         PR symtab/24423:
3310         * source.c (print_source_lines_base): Advance "iter" when a
3311         control character is seen.
3312
3313 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3314
3315         * inferior.h (struct infcall_suspend_state_deleter):
3316         Catch exception in destructor to avoid crash.
3317
3318 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3319
3320         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3321         close to the add_com "shell".
3322
3323 2019-04-18  Tom Tromey  <tromey@adacore.com>
3324
3325         * process-stratum-target.h (class process_stratum_target)
3326         <stratum>: Add "final".
3327
3328 2019-04-17  Tom Tromey  <tromey@adacore.com>
3329
3330         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3331         against nullptr before use.
3332
3333 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3334
3335         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3336
3337 2019-04-17  Jim Wilson  <jimw@sifive.com>
3338             Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3341         code read might fail, assume 4-byte breakpoint in that case.
3342
3343 2019-04-15  Leszek Swirski  <leszeks@google.com>
3344
3345         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3346         rather than a hand-rolled POD check when checking for forced MEMORY
3347         classification.
3348
3349 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3350
3351         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3352         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3353         function.
3354         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3355         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3356         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3357         declaration.
3358
3359 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3360
3361         * aarch64-linux-nat.c
3362         (aarch64_linux_nat_target::thread_architecture): Add override.
3363         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3364         each VQ.
3365
3366 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3367
3368         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3369
3370 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3371
3372         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3373         target types of size 96-bits, add some additional comments, and
3374         check that the builtin type we found was the correct size.
3375
3376 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3377
3378         * utils.c (prompt_for_continue): Don't restore the styling at the
3379         end, as applied_style has the wrong value.  This fixes styling in
3380         long lists of file names that are interrupted by the "Continue?"
3381         prompt.
3382
3383 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3386         * c-lang.c (c_language_defn): Likewise.
3387         (cplus_language_defn): Likewise.
3388         (asm_language_defn): Likewise.
3389         (minimal_language_defn): Likewise.
3390         * d-lang.c (d_language_defn): Likewise.
3391         * f-lang.c (f_language_defn): Likewise.
3392         * go-lang.c (go_language_defn): Likewise.
3393         * language.c (unknown_language_defn): Likewise.
3394         (auto_language_defn): Likewise.
3395         * language.h (struct language_defn): Remove la_magic field.
3396         (LANG_MAGIC): Delete.
3397         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3398         * objc-lang.c (objc_language_defn): Likewise.
3399         * opencl-lang.c (opencl_language_defn): Likewise.
3400         * p-lang.c (pascal_language_defn): Likewise.
3401         * rust-lang.c (rust_language_defn): Likewise.
3402
3403 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3404
3405         * riscv-tdep.c (riscv_type_align): New function.
3406         (riscv_type_alignment): Delete.
3407         (riscv_arg_location): Use 'type_align'.
3408         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3409
3410 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * gdbtypes.c (type_align): A struct with no non-static fields also
3413         has alignment of 1.
3414
3415 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3416
3417         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3418         component to 0.
3419         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3420         member.
3421         (riscv_struct_info::analyse): New implementation using new
3422         analyse_inner member function.
3423         (riscv_struct_info::field_offset): New member function.
3424         (riscv_struct_info::m_offsets): New member variable.
3425         (riscv_struct_info::analyse_inner): New private member function,
3426         takes the old implementation of riscv_struct_info::analyse but
3427         extended to track field offsets.
3428         (riscv_call_arg_struct): Update the struct folding special cases
3429         to handle cases where empty C++ structs, which are non-zero
3430         length, are found.
3431         (riscv_arg_location): Initialise the length of each location, a
3432         non-zero length now indicates the location is in use.
3433         (riscv_push_dummy_call): Allow for the first location having a
3434         non-zero offset when setting up arguments.
3435         (riscv_return_value): Likewise, but for return values.
3436
3437 2019-04-11  Tom Tromey  <tromey@adacore.com>
3438
3439         * utils.c (internal_vproblem): Make "msg" const.
3440
3441 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3442
3443         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3444         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3445         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3446         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3447
3448 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3449
3450         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3451         function.
3452         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3453         of amd64_collect_native_gregset.
3454         (amd64_linux_nat_target::store_registers): Likewise.
3455
3456 2019-04-10  Tom Tromey  <tom@tromey.com>
3457
3458         * symtab.c (lookup_global_symbol_from_objfile)
3459         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3460         * objfiles.h (class separate_debug_iterator): New.
3461         (class separate_debug_range): New.
3462         (struct objfile) <separate_debug_objfiles>: New method.
3463         (objfile_separate_debug_iterate): Don't declare.
3464         * objfiles.c (separate_debug_iterator::operator++): Rename from
3465         objfile_separate_debug_iterate.
3466         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3467         iterator.
3468         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3469         iterator.
3470
3471 2019-04-10  Tom Tromey  <tom@tromey.com>
3472
3473         * symfile.c (reread_symbols): Remove old comment.
3474         * objfiles.c (free_all_objfiles): Fix a typo.
3475
3476 2019-04-10  Tom Tromey  <tom@tromey.com>
3477
3478         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3479         * minsyms.c (lookup_minimal_symbol): Use foreach.
3480         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3481         (lookup_minimal_symbol_solib_trampoline): Likewise.
3482         * symfile.c (reread_symbols): Use foreach.
3483
3484 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3485             Tom Tromey  <tromey@adacore.com>
3486
3487         PR rust/24414:
3488         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3489         (rust_lex_int_test): Change "value" to be LONGEST.
3490         (rust_lex_tests): Add test for long integer literal.
3491
3492 2019-04-09  Tom Tromey  <tromey@adacore.com>
3493
3494         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3495         to bool.
3496         (extended_remote_target::attach): Update.
3497         (remote_target::remote_notice_new_inferior): Update.
3498         (remote_target::add_current_inferior_and_thread): Update.
3499         * inferior.c (exit_inferior_1): Use "false".
3500         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3501
3502 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3503
3504         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3505         the "start" command.
3506
3507 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3508
3509         * python/py-inferior.c (infpy_thread_from_thread_handle):
3510         Adjust comments to reflect renaming of thread_from_thread_handle
3511         to thread_from_handle.  Adjust keywords.  Fix type error message.
3512         (inferior_object_methods): Add thread_from_handle.  Retain
3513         thread_from_thread_handle, but mark it as deprecated.
3514
3515 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3516
3517         * gdbthread.h (find_thread_by_handle): Revise declaration.
3518         * thread.c (find_thread_by_handle): Likewise.  Adjust
3519         implementation too.
3520         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3521         support for buffer objects as handles.
3522
3523 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3524
3525         * python/py-infthread.c (thpy_thread_handle): New function.
3526         (thread_object_methods): Register thpy_thread_handle.
3527
3528 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3529
3530         * gdbthread.h (thread_to_thread_handle): Declare.
3531         * thread.c (gdbtypes.h): Include.
3532         (thread_to_thread_handle): New function.
3533
3534         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3535         (target_thread_info_to_thread_handle): Declare.
3536         * target.c (target_thread_info_to_thread_handle): New function.
3537         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3538         * target-delegates.c: Regenerate.
3539
3540         * linux-thread-db.c (class thread_db_target): Add method
3541         thread_info_to_thread_handle.
3542         (thread_db_target::thread_info_to_thread_handle): Define.
3543         * remote.c (class remote_target): Add new method
3544         thread_info_to_thread_handle.
3545         (remote_target::thread_info_to_thread_handle): Define.
3546
3547 2019-04-08  Pedro Alves  <palves@redhat.com>
3548
3549         * common/common-exceptions.c (throw_exception): Don't create
3550         named object to throw; throw directly.
3551         (throw_it): Likewise.  Don't initialize gdb_exception::message
3552         here, with new; pass FMT and AP to the ctor instead.
3553         * common/common-exceptions.h: Include <string>.
3554         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3555         const char *, va_list)): New ctor.  Use std::make_shared.
3556         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3557         errors)): Delete.
3558         (gdb_exception_error::gdb_exception_error(enum errors, const char
3559         *, va_list)): New.
3560         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3561         Add assertion.
3562         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3563         errors)): Delete.
3564         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3565         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3566         Add assertion.
3567
3568 2019-04-08  Tom Tromey  <tom@tromey.com>
3569
3570         * valops.c (value_rtti_indirect_type): Replace throw_exception
3571         with throw.
3572         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3573         with throw.
3574         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3575         throw.
3576         * target.c (target_translate_tls_address): Replace throw_exception
3577         with throw.
3578         * stack.c (frame_apply_command_count): Replace throw_exception
3579         with throw.
3580         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3581         throw.
3582         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3583         with throw.
3584         * rs6000-tdep.c (rs6000_frame_cache)
3585         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3586         * remote.c: Replace throw_exception with throw.
3587         * record-full.c (record_full_message, record_full_wait_1)
3588         (record_full_restore): Replace throw_exception with throw.
3589         * record-btrace.c:
3590         (get_thread_current_frame_id, record_btrace_start_replaying)
3591         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3592         (cmd_record_btrace_start): Replace throw_exception with throw.
3593         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3594         throw.
3595         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3596         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3597         * linespec.c:
3598         (find_linespec_symbols): Replace throw_exception with throw.
3599         * infrun.c (displaced_step_prepare, resume): Replace
3600         throw_exception with throw.
3601         * infcmd.c (post_create_inferior): Replace throw_exception with
3602         throw.
3603         * inf-loop.c (inferior_event_handler): Replace throw_exception
3604         with throw.
3605         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3606         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3607         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3608         (get_prev_frame_always, get_frame_pc_if_available)
3609         (get_frame_address_in_block_if_available, get_frame_language):
3610         Replace throw_exception with throw.
3611         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3612         throw_exception with throw.
3613         * eval.c (fetch_subexp_value, evaluate_var_value)
3614         (evaluate_funcall, evaluate_subexp_standard): Replace
3615         throw_exception with throw.
3616         * dwarf2loc.c (call_site_find_chain)
3617         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3618         Replace throw_exception with throw.
3619         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3620         with throw.
3621         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3622         throw.
3623         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3624         * completer.c (complete_line_internal): Replace throw_exception
3625         with throw.
3626         * compile/compile-object-run.c (compile_object_run): Replace
3627         throw_exception with throw.
3628         * cli/cli-script.c (process_next_line): Replace throw_exception
3629         with throw.
3630         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3631         (btrace_enable, btrace_maint_update_pt_packets): Replace
3632         throw_exception with throw.
3633         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3634         throw_exception with throw.
3635         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3636         throw_exception with throw.
3637         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3638         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3639         * aarch64-tdep.c (aarch64_make_prologue_cache)
3640         (aarch64_make_stub_cache): Replace throw_exception with throw.
3641
3642 2019-04-08  Tom Tromey  <tom@tromey.com>
3643
3644         * common/common-exceptions.c (throw_exception): Rename from
3645         throw_exception_cxx.  Remove old copy.  Make argument const.
3646         (throw_it): Create and throw exception objects directly.
3647         * common/common-exceptions.h (throw_exception): Make argument
3648         const.
3649         (struct gdb_exception_error): Add constructor.
3650         (struct gdb_exception_quit): Add constructor.
3651
3652 2019-04-08  Tom Tromey  <tom@tromey.com>
3653
3654         * common/common-exceptions.h (exception_rethrow): Don't declare.
3655         (TRY_SJLJ): Update comment.
3656         (TRY, CATCH, END_CATCH): Remove.
3657         * common/common-exceptions.c (exception_rethrow): Remove.
3658
3659 2019-04-08  Tom Tromey  <tom@tromey.com>
3660
3661         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3662         Remove.
3663         (gdb_exception_error): Rename from
3664         gdb_exception_RETURN_MASK_ERROR.
3665         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3666         (gdb_quit_bad_alloc): Update.
3667         * aarch64-tdep.c: Update.
3668         * ada-lang.c: Update.
3669         * ada-typeprint.c: Update.
3670         * ada-valprint.c: Update.
3671         * amd64-tdep.c: Update.
3672         * arch-utils.c: Update.
3673         * break-catch-throw.c: Update.
3674         * breakpoint.c: Update.
3675         * btrace.c: Update.
3676         * c-varobj.c: Update.
3677         * cli/cli-cmds.c: Update.
3678         * cli/cli-interp.c: Update.
3679         * cli/cli-script.c: Update.
3680         * common/common-exceptions.c: Update.
3681         * common/new-op.c: Update.
3682         * common/selftest.c: Update.
3683         * compile/compile-c-symbols.c: Update.
3684         * compile/compile-cplus-symbols.c: Update.
3685         * compile/compile-object-load.c: Update.
3686         * compile/compile-object-run.c: Update.
3687         * completer.c: Update.
3688         * corelow.c: Update.
3689         * cp-abi.c: Update.
3690         * cp-support.c: Update.
3691         * cp-valprint.c: Update.
3692         * darwin-nat.c: Update.
3693         * disasm-selftests.c: Update.
3694         * dtrace-probe.c: Update.
3695         * dwarf-index-cache.c: Update.
3696         * dwarf-index-write.c: Update.
3697         * dwarf2-frame-tailcall.c: Update.
3698         * dwarf2-frame.c: Update.
3699         * dwarf2loc.c: Update.
3700         * dwarf2read.c: Update.
3701         * eval.c: Update.
3702         * event-loop.c: Update.
3703         * event-top.c: Update.
3704         * exec.c: Update.
3705         * f-valprint.c: Update.
3706         * fbsd-tdep.c: Update.
3707         * frame-unwind.c: Update.
3708         * frame.c: Update.
3709         * gdbtypes.c: Update.
3710         * gnu-v3-abi.c: Update.
3711         * guile/guile-internal.h: Update.
3712         * guile/scm-block.c: Update.
3713         * guile/scm-breakpoint.c: Update.
3714         * guile/scm-cmd.c: Update.
3715         * guile/scm-disasm.c: Update.
3716         * guile/scm-frame.c: Update.
3717         * guile/scm-lazy-string.c: Update.
3718         * guile/scm-math.c: Update.
3719         * guile/scm-param.c: Update.
3720         * guile/scm-ports.c: Update.
3721         * guile/scm-pretty-print.c: Update.
3722         * guile/scm-symbol.c: Update.
3723         * guile/scm-symtab.c: Update.
3724         * guile/scm-type.c: Update.
3725         * guile/scm-value.c: Update.
3726         * i386-linux-tdep.c: Update.
3727         * i386-tdep.c: Update.
3728         * inf-loop.c: Update.
3729         * infcall.c: Update.
3730         * infcmd.c: Update.
3731         * infrun.c: Update.
3732         * jit.c: Update.
3733         * language.c: Update.
3734         * linespec.c: Update.
3735         * linux-fork.c: Update.
3736         * linux-nat.c: Update.
3737         * linux-tdep.c: Update.
3738         * linux-thread-db.c: Update.
3739         * main.c: Update.
3740         * mi/mi-cmd-break.c: Update.
3741         * mi/mi-cmd-stack.c: Update.
3742         * mi/mi-interp.c: Update.
3743         * mi/mi-main.c: Update.
3744         * objc-lang.c: Update.
3745         * p-valprint.c: Update.
3746         * parse.c: Update.
3747         * ppc-linux-tdep.c: Update.
3748         * printcmd.c: Update.
3749         * python/py-arch.c: Update.
3750         * python/py-breakpoint.c: Update.
3751         * python/py-cmd.c: Update.
3752         * python/py-finishbreakpoint.c: Update.
3753         * python/py-frame.c: Update.
3754         * python/py-framefilter.c: Update.
3755         * python/py-gdb-readline.c: Update.
3756         * python/py-inferior.c: Update.
3757         * python/py-infthread.c: Update.
3758         * python/py-lazy-string.c: Update.
3759         * python/py-linetable.c: Update.
3760         * python/py-objfile.c: Update.
3761         * python/py-param.c: Update.
3762         * python/py-prettyprint.c: Update.
3763         * python/py-progspace.c: Update.
3764         * python/py-record-btrace.c: Update.
3765         * python/py-record.c: Update.
3766         * python/py-symbol.c: Update.
3767         * python/py-type.c: Update.
3768         * python/py-unwind.c: Update.
3769         * python/py-utils.c: Update.
3770         * python/py-value.c: Update.
3771         * python/python.c: Update.
3772         * record-btrace.c: Update.
3773         * record-full.c: Update.
3774         * remote-fileio.c: Update.
3775         * remote.c: Update.
3776         * riscv-tdep.c: Update.
3777         * rs6000-aix-tdep.c: Update.
3778         * rs6000-tdep.c: Update.
3779         * rust-exp.y: Update.
3780         * rust-lang.c: Update.
3781         * s390-tdep.c: Update.
3782         * selftest-arch.c: Update.
3783         * solib-dsbt.c: Update.
3784         * solib-frv.c: Update.
3785         * solib-spu.c: Update.
3786         * solib-svr4.c: Update.
3787         * solib.c: Update.
3788         * sparc64-linux-tdep.c: Update.
3789         * stack.c: Update.
3790         * symfile-mem.c: Update.
3791         * symmisc.c: Update.
3792         * target.c: Update.
3793         * thread.c: Update.
3794         * top.c: Update.
3795         * tracefile-tfile.c: Update.
3796         * tui/tui.c: Update.
3797         * typeprint.c: Update.
3798         * unittests/cli-utils-selftests.c: Update.
3799         * unittests/parse-connection-spec-selftests.c: Update.
3800         * valops.c: Update.
3801         * valprint.c: Update.
3802         * value.c: Update.
3803         * varobj.c: Update.
3804         * windows-nat.c: Update.
3805         * x86-linux-nat.c: Update.
3806         * xml-support.c: Update.
3807
3808 2019-04-08  Tom Tromey  <tom@tromey.com>
3809
3810         * xml-support.c: Use C++ exception handling.
3811         * x86-linux-nat.c: Use C++ exception handling.
3812         * windows-nat.c: Use C++ exception handling.
3813         * varobj.c: Use C++ exception handling.
3814         * value.c: Use C++ exception handling.
3815         * valprint.c: Use C++ exception handling.
3816         * valops.c: Use C++ exception handling.
3817         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3818         handling.
3819         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3820         * typeprint.c: Use C++ exception handling.
3821         * tui/tui.c: Use C++ exception handling.
3822         * tracefile-tfile.c: Use C++ exception handling.
3823         * top.c: Use C++ exception handling.
3824         * thread.c: Use C++ exception handling.
3825         * target.c: Use C++ exception handling.
3826         * symmisc.c: Use C++ exception handling.
3827         * symfile-mem.c: Use C++ exception handling.
3828         * stack.c: Use C++ exception handling.
3829         * sparc64-linux-tdep.c: Use C++ exception handling.
3830         * solib.c: Use C++ exception handling.
3831         * solib-svr4.c: Use C++ exception handling.
3832         * solib-spu.c: Use C++ exception handling.
3833         * solib-frv.c: Use C++ exception handling.
3834         * solib-dsbt.c: Use C++ exception handling.
3835         * selftest-arch.c: Use C++ exception handling.
3836         * s390-tdep.c: Use C++ exception handling.
3837         * rust-lang.c: Use C++ exception handling.
3838         * rust-exp.y: Use C++ exception handling.
3839         * rs6000-tdep.c: Use C++ exception handling.
3840         * rs6000-aix-tdep.c: Use C++ exception handling.
3841         * riscv-tdep.c: Use C++ exception handling.
3842         * remote.c: Use C++ exception handling.
3843         * remote-fileio.c: Use C++ exception handling.
3844         * record-full.c: Use C++ exception handling.
3845         * record-btrace.c: Use C++ exception handling.
3846         * python/python.c: Use C++ exception handling.
3847         * python/py-value.c: Use C++ exception handling.
3848         * python/py-utils.c: Use C++ exception handling.
3849         * python/py-unwind.c: Use C++ exception handling.
3850         * python/py-type.c: Use C++ exception handling.
3851         * python/py-symbol.c: Use C++ exception handling.
3852         * python/py-record.c: Use C++ exception handling.
3853         * python/py-record-btrace.c: Use C++ exception handling.
3854         * python/py-progspace.c: Use C++ exception handling.
3855         * python/py-prettyprint.c: Use C++ exception handling.
3856         * python/py-param.c: Use C++ exception handling.
3857         * python/py-objfile.c: Use C++ exception handling.
3858         * python/py-linetable.c: Use C++ exception handling.
3859         * python/py-lazy-string.c: Use C++ exception handling.
3860         * python/py-infthread.c: Use C++ exception handling.
3861         * python/py-inferior.c: Use C++ exception handling.
3862         * python/py-gdb-readline.c: Use C++ exception handling.
3863         * python/py-framefilter.c: Use C++ exception handling.
3864         * python/py-frame.c: Use C++ exception handling.
3865         * python/py-finishbreakpoint.c: Use C++ exception handling.
3866         * python/py-cmd.c: Use C++ exception handling.
3867         * python/py-breakpoint.c: Use C++ exception handling.
3868         * python/py-arch.c: Use C++ exception handling.
3869         * printcmd.c: Use C++ exception handling.
3870         * ppc-linux-tdep.c: Use C++ exception handling.
3871         * parse.c: Use C++ exception handling.
3872         * p-valprint.c: Use C++ exception handling.
3873         * objc-lang.c: Use C++ exception handling.
3874         * mi/mi-main.c: Use C++ exception handling.
3875         * mi/mi-interp.c: Use C++ exception handling.
3876         * mi/mi-cmd-stack.c: Use C++ exception handling.
3877         * mi/mi-cmd-break.c: Use C++ exception handling.
3878         * main.c: Use C++ exception handling.
3879         * linux-thread-db.c: Use C++ exception handling.
3880         * linux-tdep.c: Use C++ exception handling.
3881         * linux-nat.c: Use C++ exception handling.
3882         * linux-fork.c: Use C++ exception handling.
3883         * linespec.c: Use C++ exception handling.
3884         * language.c: Use C++ exception handling.
3885         * jit.c: Use C++ exception handling.
3886         * infrun.c: Use C++ exception handling.
3887         * infcmd.c: Use C++ exception handling.
3888         * infcall.c: Use C++ exception handling.
3889         * inf-loop.c: Use C++ exception handling.
3890         * i386-tdep.c: Use C++ exception handling.
3891         * i386-linux-tdep.c: Use C++ exception handling.
3892         * guile/scm-value.c: Use C++ exception handling.
3893         * guile/scm-type.c: Use C++ exception handling.
3894         * guile/scm-symtab.c: Use C++ exception handling.
3895         * guile/scm-symbol.c: Use C++ exception handling.
3896         * guile/scm-pretty-print.c: Use C++ exception handling.
3897         * guile/scm-ports.c: Use C++ exception handling.
3898         * guile/scm-param.c: Use C++ exception handling.
3899         * guile/scm-math.c: Use C++ exception handling.
3900         * guile/scm-lazy-string.c: Use C++ exception handling.
3901         * guile/scm-frame.c: Use C++ exception handling.
3902         * guile/scm-disasm.c: Use C++ exception handling.
3903         * guile/scm-cmd.c: Use C++ exception handling.
3904         * guile/scm-breakpoint.c: Use C++ exception handling.
3905         * guile/scm-block.c: Use C++ exception handling.
3906         * guile/guile-internal.h: Use C++ exception handling.
3907         * gnu-v3-abi.c: Use C++ exception handling.
3908         * gdbtypes.c: Use C++ exception handling.
3909         * frame.c: Use C++ exception handling.
3910         * frame-unwind.c: Use C++ exception handling.
3911         * fbsd-tdep.c: Use C++ exception handling.
3912         * f-valprint.c: Use C++ exception handling.
3913         * exec.c: Use C++ exception handling.
3914         * event-top.c: Use C++ exception handling.
3915         * event-loop.c: Use C++ exception handling.
3916         * eval.c: Use C++ exception handling.
3917         * dwarf2read.c: Use C++ exception handling.
3918         * dwarf2loc.c: Use C++ exception handling.
3919         * dwarf2-frame.c: Use C++ exception handling.
3920         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3921         * dwarf-index-write.c: Use C++ exception handling.
3922         * dwarf-index-cache.c: Use C++ exception handling.
3923         * dtrace-probe.c: Use C++ exception handling.
3924         * disasm-selftests.c: Use C++ exception handling.
3925         * darwin-nat.c: Use C++ exception handling.
3926         * cp-valprint.c: Use C++ exception handling.
3927         * cp-support.c: Use C++ exception handling.
3928         * cp-abi.c: Use C++ exception handling.
3929         * corelow.c: Use C++ exception handling.
3930         * completer.c: Use C++ exception handling.
3931         * compile/compile-object-run.c: Use C++ exception handling.
3932         * compile/compile-object-load.c: Use C++ exception handling.
3933         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3934         * compile/compile-c-symbols.c: Use C++ exception handling.
3935         * common/selftest.c: Use C++ exception handling.
3936         * common/new-op.c: Use C++ exception handling.
3937         * cli/cli-script.c: Use C++ exception handling.
3938         * cli/cli-interp.c: Use C++ exception handling.
3939         * cli/cli-cmds.c: Use C++ exception handling.
3940         * c-varobj.c: Use C++ exception handling.
3941         * btrace.c: Use C++ exception handling.
3942         * breakpoint.c: Use C++ exception handling.
3943         * break-catch-throw.c: Use C++ exception handling.
3944         * arch-utils.c: Use C++ exception handling.
3945         * amd64-tdep.c: Use C++ exception handling.
3946         * ada-valprint.c: Use C++ exception handling.
3947         * ada-typeprint.c: Use C++ exception handling.
3948         * ada-lang.c: Use C++ exception handling.
3949         * aarch64-tdep.c: Use C++ exception handling.
3950
3951 2019-04-08  Tom Tromey  <tom@tromey.com>
3952
3953         * xml-support.c (gdb_xml_parser::parse): Update.
3954         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3955         * value.c (show_convenience): Update.
3956         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3957         (test_parse_flags_qcs): Update.
3958         * thread.c (thr_try_catch_cmd): Update.
3959         * target.c (target_translate_tls_address): Update.
3960         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3961         (info_frame_command_core, frame_apply_command_count): Update.
3962         * rust-exp.y (rust_lex_exception_test): Update.
3963         * riscv-tdep.c (riscv_print_one_register_info): Update.
3964         * remote.c (remote_target::enable_btrace): Update.
3965         * record-btrace.c (record_btrace_enable_warn): Update.
3966         * python/py-utils.c (gdbpy_convert_exception): Update.
3967         * printcmd.c (do_one_display, print_variable_and_value): Update.
3968         * mi/mi-main.c (mi_print_exception): Update.
3969         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3970         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3971         * linux-nat.c (linux_nat_target::attach): Update.
3972         * linux-fork.c (class scoped_switch_fork_info): Update.
3973         * infrun.c (displaced_step_prepare): Update.
3974         * infcall.c (call_function_by_hand_dummy): Update.
3975         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3976         * gnu-v3-abi.c (print_one_vtable): Update.
3977         * frame.c (get_prev_frame_always): Update.
3978         * f-valprint.c (info_common_command_for_block): Update.
3979         * exec.c (try_open_exec_file): Update.
3980         * exceptions.c (print_exception, exception_print)
3981         (exception_fprintf, exception_print_same): Update.
3982         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3983         * dwarf-index-cache.c (index_cache::store)
3984         (index_cache::lookup_gdb_index): Update.
3985         * darwin-nat.c (maybe_cache_shell): Update.
3986         * cp-valprint.c (cp_print_value_fields): Update.
3987         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3988         (gcc_cplus_symbol_address): Update.
3989         * compile/compile-c-symbols.c (gcc_convert_symbol)
3990         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3991         * common/selftest.c: Update.
3992         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3993         a std::string.
3994         (exception_try_scope_entry, exception_try_scope_exit): Don't
3995         declare.
3996         (struct exception_try_scope): Remove.
3997         (TRY): Don't use exception_try_scope.
3998         (struct gdb_exception): Add constructor, operator=.
3999         <what>: New method.
4000         (struct gdb_exception_RETURN_MASK_ALL)
4001         (struct gdb_exception_RETURN_MASK_ERROR)
4002         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4003         (struct gdb_quit_bad_alloc): Update.
4004         * common/common-exceptions.c (exception_none): Change
4005         initializer.
4006         (struct catcher) <state, exception>: Initialize inline.
4007         <prev>: Remove member.
4008         (current_catcher): Remove.
4009         (catchers): New global.
4010         (exceptions_state_mc_init): Simplify.
4011         (catcher_pop): Remove.
4012         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4013         (try_scope_depth, exception_try_scope_entry)
4014         (exception_try_scope_exit): Remove.
4015         (throw_exception_sjlj): Update.
4016         (exception_messages, exception_messages_size): Remove.
4017         (throw_it): Simplify.
4018         (gdb_exception_sliced_copy): Remove.
4019         (throw_exception_cxx): Update.
4020         * cli/cli-script.c (script_from_file): Update.
4021         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4022         Update.
4023         * ada-valprint.c (ada_val_print): Update.
4024         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4025         (create_excep_cond_exprs): Update.
4026
4027 2019-04-08  Tom Tromey  <tom@tromey.com>
4028
4029         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4030         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4031         (TRY, CATCH, END_CATCH): Remove some definitions.
4032         * common/common-exceptions.c: Don't use GDB_XCPT.
4033         (catcher_list_size): Remove.
4034         (throw_exception, throw_it): Simplify.
4035
4036 2019-04-05  Tom Tromey  <tom@tromey.com>
4037
4038         Revert the header-sorting patch.
4039         * ft32-tdep.c: Revert.
4040         * frv-tdep.c: Revert.
4041         * frv-linux-tdep.c: Revert.
4042         * frame.c: Revert.
4043         * frame-unwind.c: Revert.
4044         * frame-base.c: Revert.
4045         * fork-child.c: Revert.
4046         * findvar.c: Revert.
4047         * findcmd.c: Revert.
4048         * filesystem.c: Revert.
4049         * filename-seen-cache.h: Revert.
4050         * filename-seen-cache.c: Revert.
4051         * fbsd-tdep.c: Revert.
4052         * fbsd-nat.h: Revert.
4053         * fbsd-nat.c: Revert.
4054         * f-valprint.c: Revert.
4055         * f-typeprint.c: Revert.
4056         * f-lang.c: Revert.
4057         * extension.h: Revert.
4058         * extension.c: Revert.
4059         * extension-priv.h: Revert.
4060         * expprint.c: Revert.
4061         * exec.h: Revert.
4062         * exec.c: Revert.
4063         * exceptions.c: Revert.
4064         * event-top.c: Revert.
4065         * event-loop.c: Revert.
4066         * eval.c: Revert.
4067         * elfread.c: Revert.
4068         * dwarf2read.h: Revert.
4069         * dwarf2read.c: Revert.
4070         * dwarf2loc.c: Revert.
4071         * dwarf2expr.h: Revert.
4072         * dwarf2expr.c: Revert.
4073         * dwarf2-frame.c: Revert.
4074         * dwarf2-frame-tailcall.c: Revert.
4075         * dwarf-index-write.h: Revert.
4076         * dwarf-index-write.c: Revert.
4077         * dwarf-index-common.c: Revert.
4078         * dwarf-index-cache.h: Revert.
4079         * dwarf-index-cache.c: Revert.
4080         * dummy-frame.c: Revert.
4081         * dtrace-probe.c: Revert.
4082         * disasm.h: Revert.
4083         * disasm.c: Revert.
4084         * disasm-selftests.c: Revert.
4085         * dictionary.c: Revert.
4086         * dicos-tdep.c: Revert.
4087         * demangle.c: Revert.
4088         * dcache.h: Revert.
4089         * dcache.c: Revert.
4090         * darwin-nat.h: Revert.
4091         * darwin-nat.c: Revert.
4092         * darwin-nat-info.c: Revert.
4093         * d-valprint.c: Revert.
4094         * d-namespace.c: Revert.
4095         * d-lang.c: Revert.
4096         * ctf.c: Revert.
4097         * csky-tdep.c: Revert.
4098         * csky-linux-tdep.c: Revert.
4099         * cris-tdep.c: Revert.
4100         * cris-linux-tdep.c: Revert.
4101         * cp-valprint.c: Revert.
4102         * cp-support.c: Revert.
4103         * cp-namespace.c: Revert.
4104         * cp-abi.c: Revert.
4105         * corelow.c: Revert.
4106         * corefile.c: Revert.
4107         * continuations.c: Revert.
4108         * completer.h: Revert.
4109         * completer.c: Revert.
4110         * complaints.c: Revert.
4111         * coffread.c: Revert.
4112         * coff-pe-read.c: Revert.
4113         * cli-out.h: Revert.
4114         * cli-out.c: Revert.
4115         * charset.c: Revert.
4116         * c-varobj.c: Revert.
4117         * c-valprint.c: Revert.
4118         * c-typeprint.c: Revert.
4119         * c-lang.c: Revert.
4120         * buildsym.c: Revert.
4121         * buildsym-legacy.c: Revert.
4122         * build-id.h: Revert.
4123         * build-id.c: Revert.
4124         * btrace.c: Revert.
4125         * bsd-uthread.c: Revert.
4126         * breakpoint.h: Revert.
4127         * breakpoint.c: Revert.
4128         * break-catch-throw.c: Revert.
4129         * break-catch-syscall.c: Revert.
4130         * break-catch-sig.c: Revert.
4131         * blockframe.c: Revert.
4132         * block.c: Revert.
4133         * bfin-tdep.c: Revert.
4134         * bfin-linux-tdep.c: Revert.
4135         * bfd-target.c: Revert.
4136         * bcache.c: Revert.
4137         * ax-general.c: Revert.
4138         * ax-gdb.h: Revert.
4139         * ax-gdb.c: Revert.
4140         * avr-tdep.c: Revert.
4141         * auxv.c: Revert.
4142         * auto-load.c: Revert.
4143         * arm-wince-tdep.c: Revert.
4144         * arm-tdep.c: Revert.
4145         * arm-symbian-tdep.c: Revert.
4146         * arm-pikeos-tdep.c: Revert.
4147         * arm-obsd-tdep.c: Revert.
4148         * arm-nbsd-tdep.c: Revert.
4149         * arm-nbsd-nat.c: Revert.
4150         * arm-linux-tdep.c: Revert.
4151         * arm-linux-nat.c: Revert.
4152         * arm-fbsd-tdep.c: Revert.
4153         * arm-fbsd-nat.c: Revert.
4154         * arm-bsd-tdep.c: Revert.
4155         * arch-utils.c: Revert.
4156         * arc-tdep.c: Revert.
4157         * arc-newlib-tdep.c: Revert.
4158         * annotate.h: Revert.
4159         * annotate.c: Revert.
4160         * amd64-windows-tdep.c: Revert.
4161         * amd64-windows-nat.c: Revert.
4162         * amd64-tdep.c: Revert.
4163         * amd64-sol2-tdep.c: Revert.
4164         * amd64-obsd-tdep.c: Revert.
4165         * amd64-obsd-nat.c: Revert.
4166         * amd64-nbsd-tdep.c: Revert.
4167         * amd64-nbsd-nat.c: Revert.
4168         * amd64-nat.c: Revert.
4169         * amd64-linux-tdep.c: Revert.
4170         * amd64-linux-nat.c: Revert.
4171         * amd64-fbsd-tdep.c: Revert.
4172         * amd64-fbsd-nat.c: Revert.
4173         * amd64-dicos-tdep.c: Revert.
4174         * amd64-darwin-tdep.c: Revert.
4175         * amd64-bsd-nat.c: Revert.
4176         * alpha-tdep.c: Revert.
4177         * alpha-obsd-tdep.c: Revert.
4178         * alpha-nbsd-tdep.c: Revert.
4179         * alpha-mdebug-tdep.c: Revert.
4180         * alpha-linux-tdep.c: Revert.
4181         * alpha-linux-nat.c: Revert.
4182         * alpha-bsd-tdep.c: Revert.
4183         * alpha-bsd-nat.c: Revert.
4184         * aix-thread.c: Revert.
4185         * agent.c: Revert.
4186         * addrmap.c: Revert.
4187         * ada-varobj.c: Revert.
4188         * ada-valprint.c: Revert.
4189         * ada-typeprint.c: Revert.
4190         * ada-tasks.c: Revert.
4191         * ada-lang.c: Revert.
4192         * aarch64-tdep.c: Revert.
4193         * aarch64-ravenscar-thread.c: Revert.
4194         * aarch64-newlib-tdep.c: Revert.
4195         * aarch64-linux-tdep.c: Revert.
4196         * aarch64-linux-nat.c: Revert.
4197         * aarch64-fbsd-tdep.c: Revert.
4198         * aarch64-fbsd-nat.c: Revert.
4199         * aarch32-linux-nat.c: Revert.
4200
4201 2019-04-05  Tom Tromey  <tom@tromey.com>
4202
4203         * ft32-tdep.c: Sort headers.
4204         * frv-tdep.c: Sort headers.
4205         * frv-linux-tdep.c: Sort headers.
4206         * frame.c: Sort headers.
4207         * frame-unwind.c: Sort headers.
4208         * frame-base.c: Sort headers.
4209         * fork-child.c: Sort headers.
4210         * findvar.c: Sort headers.
4211         * findcmd.c: Sort headers.
4212         * filesystem.c: Sort headers.
4213         * filename-seen-cache.h: Sort headers.
4214         * filename-seen-cache.c: Sort headers.
4215         * fbsd-tdep.c: Sort headers.
4216         * fbsd-nat.h: Sort headers.
4217         * fbsd-nat.c: Sort headers.
4218         * f-valprint.c: Sort headers.
4219         * f-typeprint.c: Sort headers.
4220         * f-lang.c: Sort headers.
4221         * extension.h: Sort headers.
4222         * extension.c: Sort headers.
4223         * extension-priv.h: Sort headers.
4224         * expprint.c: Sort headers.
4225         * exec.h: Sort headers.
4226         * exec.c: Sort headers.
4227         * exceptions.c: Sort headers.
4228         * event-top.c: Sort headers.
4229         * event-loop.c: Sort headers.
4230         * eval.c: Sort headers.
4231         * elfread.c: Sort headers.
4232         * dwarf2read.h: Sort headers.
4233         * dwarf2read.c: Sort headers.
4234         * dwarf2loc.c: Sort headers.
4235         * dwarf2expr.h: Sort headers.
4236         * dwarf2expr.c: Sort headers.
4237         * dwarf2-frame.c: Sort headers.
4238         * dwarf2-frame-tailcall.c: Sort headers.
4239         * dwarf-index-write.h: Sort headers.
4240         * dwarf-index-write.c: Sort headers.
4241         * dwarf-index-common.c: Sort headers.
4242         * dwarf-index-cache.h: Sort headers.
4243         * dwarf-index-cache.c: Sort headers.
4244         * dummy-frame.c: Sort headers.
4245         * dtrace-probe.c: Sort headers.
4246         * disasm.h: Sort headers.
4247         * disasm.c: Sort headers.
4248         * disasm-selftests.c: Sort headers.
4249         * dictionary.c: Sort headers.
4250         * dicos-tdep.c: Sort headers.
4251         * demangle.c: Sort headers.
4252         * dcache.h: Sort headers.
4253         * dcache.c: Sort headers.
4254         * darwin-nat.h: Sort headers.
4255         * darwin-nat.c: Sort headers.
4256         * darwin-nat-info.c: Sort headers.
4257         * d-valprint.c: Sort headers.
4258         * d-namespace.c: Sort headers.
4259         * d-lang.c: Sort headers.
4260         * ctf.c: Sort headers.
4261         * csky-tdep.c: Sort headers.
4262         * csky-linux-tdep.c: Sort headers.
4263         * cris-tdep.c: Sort headers.
4264         * cris-linux-tdep.c: Sort headers.
4265         * cp-valprint.c: Sort headers.
4266         * cp-support.c: Sort headers.
4267         * cp-namespace.c: Sort headers.
4268         * cp-abi.c: Sort headers.
4269         * corelow.c: Sort headers.
4270         * corefile.c: Sort headers.
4271         * continuations.c: Sort headers.
4272         * completer.h: Sort headers.
4273         * completer.c: Sort headers.
4274         * complaints.c: Sort headers.
4275         * coffread.c: Sort headers.
4276         * coff-pe-read.c: Sort headers.
4277         * cli-out.h: Sort headers.
4278         * cli-out.c: Sort headers.
4279         * charset.c: Sort headers.
4280         * c-varobj.c: Sort headers.
4281         * c-valprint.c: Sort headers.
4282         * c-typeprint.c: Sort headers.
4283         * c-lang.c: Sort headers.
4284         * buildsym.c: Sort headers.
4285         * buildsym-legacy.c: Sort headers.
4286         * build-id.h: Sort headers.
4287         * build-id.c: Sort headers.
4288         * btrace.c: Sort headers.
4289         * bsd-uthread.c: Sort headers.
4290         * breakpoint.h: Sort headers.
4291         * breakpoint.c: Sort headers.
4292         * break-catch-throw.c: Sort headers.
4293         * break-catch-syscall.c: Sort headers.
4294         * break-catch-sig.c: Sort headers.
4295         * blockframe.c: Sort headers.
4296         * block.c: Sort headers.
4297         * bfin-tdep.c: Sort headers.
4298         * bfin-linux-tdep.c: Sort headers.
4299         * bfd-target.c: Sort headers.
4300         * bcache.c: Sort headers.
4301         * ax-general.c: Sort headers.
4302         * ax-gdb.h: Sort headers.
4303         * ax-gdb.c: Sort headers.
4304         * avr-tdep.c: Sort headers.
4305         * auxv.c: Sort headers.
4306         * auto-load.c: Sort headers.
4307         * arm-wince-tdep.c: Sort headers.
4308         * arm-tdep.c: Sort headers.
4309         * arm-symbian-tdep.c: Sort headers.
4310         * arm-pikeos-tdep.c: Sort headers.
4311         * arm-obsd-tdep.c: Sort headers.
4312         * arm-nbsd-tdep.c: Sort headers.
4313         * arm-nbsd-nat.c: Sort headers.
4314         * arm-linux-tdep.c: Sort headers.
4315         * arm-linux-nat.c: Sort headers.
4316         * arm-fbsd-tdep.c: Sort headers.
4317         * arm-fbsd-nat.c: Sort headers.
4318         * arm-bsd-tdep.c: Sort headers.
4319         * arch-utils.c: Sort headers.
4320         * arc-tdep.c: Sort headers.
4321         * arc-newlib-tdep.c: Sort headers.
4322         * annotate.h: Sort headers.
4323         * annotate.c: Sort headers.
4324         * amd64-windows-tdep.c: Sort headers.
4325         * amd64-windows-nat.c: Sort headers.
4326         * amd64-tdep.c: Sort headers.
4327         * amd64-sol2-tdep.c: Sort headers.
4328         * amd64-obsd-tdep.c: Sort headers.
4329         * amd64-obsd-nat.c: Sort headers.
4330         * amd64-nbsd-tdep.c: Sort headers.
4331         * amd64-nbsd-nat.c: Sort headers.
4332         * amd64-nat.c: Sort headers.
4333         * amd64-linux-tdep.c: Sort headers.
4334         * amd64-linux-nat.c: Sort headers.
4335         * amd64-fbsd-tdep.c: Sort headers.
4336         * amd64-fbsd-nat.c: Sort headers.
4337         * amd64-dicos-tdep.c: Sort headers.
4338         * amd64-darwin-tdep.c: Sort headers.
4339         * amd64-bsd-nat.c: Sort headers.
4340         * alpha-tdep.c: Sort headers.
4341         * alpha-obsd-tdep.c: Sort headers.
4342         * alpha-nbsd-tdep.c: Sort headers.
4343         * alpha-mdebug-tdep.c: Sort headers.
4344         * alpha-linux-tdep.c: Sort headers.
4345         * alpha-linux-nat.c: Sort headers.
4346         * alpha-bsd-tdep.c: Sort headers.
4347         * alpha-bsd-nat.c: Sort headers.
4348         * aix-thread.c: Sort headers.
4349         * agent.c: Sort headers.
4350         * addrmap.c: Sort headers.
4351         * ada-varobj.c: Sort headers.
4352         * ada-valprint.c: Sort headers.
4353         * ada-typeprint.c: Sort headers.
4354         * ada-tasks.c: Sort headers.
4355         * ada-lang.c: Sort headers.
4356         * aarch64-tdep.c: Sort headers.
4357         * aarch64-ravenscar-thread.c: Sort headers.
4358         * aarch64-newlib-tdep.c: Sort headers.
4359         * aarch64-linux-tdep.c: Sort headers.
4360         * aarch64-linux-nat.c: Sort headers.
4361         * aarch64-fbsd-tdep.c: Sort headers.
4362         * aarch64-fbsd-nat.c: Sort headers.
4363         * aarch32-linux-nat.c: Sort headers.
4364
4365 2019-04-04  Tom Tromey  <tom@tromey.com>
4366
4367         * varobj.c (varobj_create): Update.
4368         * rust-exp.y (struct rust_parser) <update_innermost_block,
4369         lookup_symbol>: New methods.
4370         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4371         Rename.
4372         (rust_parser::rust_lookup_type)
4373         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4374         * printcmd.c (display_command, do_one_display): Update.
4375         * parser-defs.h (struct parser_state) <parser_state>: Add
4376         "tracker" parameter.
4377         (block_tracker): New member.
4378         (class innermost_block_tracker) <innermost_block_tracker>: Add
4379         "types" parameter.
4380         <reset>: Remove method.
4381         (innermost_block): Don't declare.
4382         (null_post_parser): Update.
4383         * parse.c (innermost_block): Remove global.
4384         (write_dollar_variable): Update.
4385         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4386         Remove "tracker_types" parameter.
4387         (parse_expression): Add "tracker" parameter.
4388         (parse_expression_for_completion): Update.
4389         (null_post_parser): Add "tracker" parameter.
4390         * p-exp.y: Update rules.
4391         * m2-exp.y: Update rules.
4392         * language.h (struct language_defn) <la_post_parser>: Add
4393         "tracker" parameter.
4394         * go-exp.y: Update rules.
4395         * f-exp.y: Update rules.
4396         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4397         parameter.
4398         * d-exp.y: Update rules.
4399         * c-exp.y: Update rules.
4400         * breakpoint.c (set_breakpoint_condition): Create an
4401         innermost_block_tracker.
4402         (watch_command_1): Likewise.
4403         * ada-lang.c (resolve): Add "tracker" parameter.
4404         (resolve_subexp): Likewise.
4405         * ada-exp.y (write_var_from_sym): Update.
4406
4407 2019-04-04  Tom Tromey  <tom@tromey.com>
4408
4409         * type-stack.h: New file.
4410         * type-stack.c: New file.
4411         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4412         type-stack.h.
4413         (insert_into_type_stack, insert_type, push_type, push_type_int)
4414         (insert_type_address_space, pop_type, pop_type_int)
4415         (pop_typelist, pop_type_stack, append_type_stack)
4416         (push_type_stack, get_type_stack, push_typelist)
4417         (follow_type_instance_flags, follow_types): Don't declare.
4418         * parse.c (type_stack): Remove global.
4419         (parse_exp_in_context): Update.
4420         (insert_into_type_stack, insert_type, push_type, push_type_int)
4421         (insert_type_address_space, pop_type, pop_type_int)
4422         (pop_typelist, pop_type_stack, append_type_stack)
4423         (push_type_stack, get_type_stack, push_typelist)
4424         (follow_type_instance_flags, follow_types): Remove (moved to
4425         type-stack.c).
4426         * f-exp.y (type_stack): New global.
4427         Update rules.
4428         (push_kind_type, f_parse): Update.
4429         * d-exp.y (type_stack): New global.
4430         Update rules.
4431         (d_parse): Update.
4432         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4433         Update rules.
4434         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4435         (HFILES_NO_SRCDIR): Add type-stack.h.
4436
4437 2019-04-04  Tom Tromey  <tom@tromey.com>
4438
4439         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4440         (rust_parser::convert_ast_to_expression, rust_parse)
4441         (rust_lex_test_completion, rust_lex_tests): Update.
4442         * parser-defs.h (struct expr_completion_state): New.
4443         (struct parser_state) <parser_state>: Add completion parameter.
4444         <mark_struct_expression, mark_completion_tag>: New methods.
4445         <parse_completion, m_completion_state>: New members.
4446         (prefixify_expression, null_post_parser): Update.
4447         (mark_struct_expression, mark_completion_tag): Don't declare.
4448         * parse.c (parse_completion, expout_last_struct)
4449         (expout_tag_completion_type, expout_completion_name): Remove
4450         globals.
4451         (parser_state::mark_struct_expression)
4452         (parser_state::mark_completion_tag): Now methods.
4453         (prefixify_expression): Add last_struct parameter.
4454         (prefixify_subexp): Likewise.
4455         (parse_exp_1): Update.
4456         (parse_exp_in_context): Add cstate parameter.  Update.
4457         (parse_expression_for_completion): Create an
4458         expr_completion_state.
4459         (null_post_parser): Add "completion" parameter.
4460         * p-exp.y: Update rules.
4461         (yylex): Update.
4462         * language.h (struct language_defn) <la_post_parser>: Add
4463         "completing" parameter.
4464         * go-exp.y: Update rules.
4465         (lex_one_token): Update.
4466         * expression.h (parse_completion): Don't declare.
4467         * d-exp.y: Update rules.
4468         (lex_one_token): Update rules.
4469         * c-exp.y: Update rules.
4470         (lex_one_token): Update.
4471         * ada-lang.c (resolve): Add "parse_completion" parameter.
4472         (resolve_subexp): Likewise.
4473         (ada_resolve_function): Likewise.
4474
4475 2019-04-04  Tom Tromey  <tom@tromey.com>
4476
4477         * parser-defs.h (struct parser_state) <start_arglist,
4478         end_arglist>: New methods.
4479         <arglist_len, m_funcall_chain>: New members.
4480         (arglist_len, start_arglist, end_arglist): Don't declare.
4481         * parse.c (arglist_len, funcall_chain): Remove global.
4482         (start_arglist, end_arglist): Remove functions.
4483         (parse_exp_in_context): Update.
4484         * p-exp.y: Update rules.
4485         * m2-exp.y: Update rules.
4486         * go-exp.y: Update rules.
4487         * f-exp.y: Update rules.
4488         * d-exp.y: Update rules.
4489         * c-exp.y: Update rules.
4490
4491 2019-04-04  Tom Tromey  <tom@tromey.com>
4492
4493         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4494         lex_operator, push_back>: New methods.
4495         Update all rules.
4496         (rust_parser::lex_hex, lex_escape): Rename and update.
4497         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4498         (rust_parser::lex_operator): Rename and update.
4499         (rust_parser::lex_number, rustyylex, rustyyerror)
4500         (rust_lex_test_init, rust_lex_test_sequence)
4501         (rust_lex_test_push_back, rust_lex_tests): Update.
4502         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4503         parameter.
4504         <lexptr, prev_lexptr>: New members.
4505         (lexptr, prev_lexptr): Don't declare.
4506         * parse.c (lexptr, prev_lexptr): Remove globals.
4507         (parse_exp_in_context): Update.
4508         * p-exp.y (yylex, yyerror): Update.
4509         * m2-exp.y (parse_number, yylex, yyerror): Update.
4510         * go-exp.y (lex_one_token, yyerror): Update.
4511         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4512         * d-exp.y (lex_one_token, yyerror): Update.
4513         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4514         (lex_one_token, yyerror): Update.
4515         * ada-lex.l (YY_INPUT): Update.
4516         (rewind_to_char): Update.
4517         * ada-exp.y (yyerror): Update.
4518
4519 2019-04-04  Tom Tromey  <tom@tromey.com>
4520
4521         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4522         * parser-defs.h (struct parser_state) <parser_state>: Add new
4523         parameter.
4524         <comma_terminates>: New member.
4525         (comma_terminates): Don't declare global.
4526         * parse.c (comma_terminates): Remove global.
4527         (parse_exp_in_context): Update.
4528         * p-exp.y (yylex): Update.
4529         * m2-exp.y (yylex): Update.
4530         * go-exp.y (lex_one_token): Update.
4531         * f-exp.y (yylex): Update.
4532         * d-exp.y (lex_one_token): Update.
4533         * c-exp.y (lex_one_token): Update.
4534         * ada-lex.l: Update.
4535
4536 2019-04-04  Tom Tromey  <tom@tromey.com>
4537
4538         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4539         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4540         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4541         * parser-defs.h (paren_depth): Don't declare.
4542         * parse.c (paren_depth): Remove global.
4543         (parse_exp_in_context): Update.
4544         * p-exp.y (paren_depth): New global.
4545         (pascal_parse): Initialize it.
4546         * m2-exp.y (paren_depth): New global.
4547         (m2_parse): Initialize it.
4548         * go-exp.y (paren_depth): New global.
4549         (go_parse): Initialize it.
4550         * f-exp.y (paren_depth): New global.
4551         (f_parse): Initialize it.
4552         * d-exp.y (paren_depth): New global.
4553         (d_parse): Initialize it.
4554         * c-exp.y (paren_depth): New global.
4555         (c_parse): Initialize it.
4556         * ada-lex.l (paren_depth): New global.
4557         (lexer_init): Initialize it.
4558
4559 2019-04-04  Tom Tromey  <tom@tromey.com>
4560
4561         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4562         (rust_parser::convert_ast_to_type)
4563         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4564         * parser-defs.h (struct parser_state) <parser_state>: Add
4565         parameters.  Initialize new members.
4566         <expression_context_block, expression_context_pc>: New members.
4567         * parse.c (expression_context_block, expression_context_pc):
4568         Remove globals.
4569         (parse_exp_in_context): Update.
4570         * p-exp.y: Update all rules.
4571         (yylex): Update.
4572         * m2-exp.y: Update all rules.
4573         (yylex): Update.
4574         * go-exp.y (yylex): Update.
4575         * f-exp.y (yylex): Update.
4576         * d-exp.y: Update all rules.
4577         (yylex): Update.
4578         * c-exp.y: Update all rules.
4579         (lex_one_token, classify_name, yylex, c_parse): Update.
4580         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4581
4582 2019-04-04  Tom Tromey  <tom@tromey.com>
4583
4584         * gdbarch.h, gdbarch.c: Rebuild.
4585         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4586         * stap-probe.h:
4587         (struct stap_parse_info): Replace "parser_state" with
4588         "expr_builder".
4589         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4590         (parser_state): New class.
4591         * parse.c (expr_builder): Rename.
4592         (expr_builder::release): Rename.
4593         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4594         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4595         (write_exp_elt_longcst, write_exp_elt_floatcst)
4596         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4597         (write_exp_string_vector, write_exp_bitstring)
4598         (write_exp_msymbol, mark_struct_expression)
4599         (write_dollar_variable)
4600         (insert_type_address_space, increase_expout_size): Replace
4601         "parser_state" with "expr_builder".
4602         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4603         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4604         "parser_state" with "expr_builder".
4605
4606 2019-04-04  Tom Tromey  <tom@tromey.com>
4607
4608         * rust-exp.y: Replace "parse_language" with method call.
4609         * p-exp.y:
4610         (yylex): Replace "parse_language" with method call.
4611         * m2-exp.y:
4612         (yylex): Replace "parse_language" with method call.
4613         * go-exp.y (classify_name): Replace "parse_language" with method
4614         call.
4615         * f-exp.y (yylex): Replace "parse_language" with method call.
4616         * d-exp.y (lex_one_token): Replace "parse_language" with method
4617         call.
4618         * c-exp.y:
4619         (lex_one_token, classify_name, yylex): Replace "parse_language"
4620         with method call.
4621         * ada-exp.y (find_primitive_type, type_char)
4622         (type_system_address): Replace "parse_language" with method call.
4623
4624 2019-04-04  Tom Tromey  <tom@tromey.com>
4625
4626         * rust-exp.y: Replace "parse_gdbarch" with method call.
4627         * parse.c (write_dollar_variable, insert_type_address_space):
4628         Replace "parse_gdbarch" with method call.
4629         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4630         call.
4631         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4632         call.
4633         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4634         "parse_gdbarch" with method call.
4635         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4636         with method call.
4637         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4638         "parse_gdbarch" with method call.
4639         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4640         "parse_gdbarch" with method call.
4641         * c-exp.y (parse_type, parse_number, classify_name): Replace
4642         "parse_gdbarch" with method call.
4643         * ada-lex.l: Replace "parse_gdbarch" with method call.
4644         * ada-exp.y (parse_type, find_primitive_type, type_char)
4645         (type_system_address): Replace "parse_gdbarch" with method call.
4646
4647 2019-04-04  Tom Tromey  <tom@tromey.com>
4648
4649         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4650         * stap-probe.c (stap_parse_argument): Update.
4651         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4652         initial_size parameter.
4653         * rust-exp.y (rust_lex_tests): Update.
4654         * parse.c (parser_state): Update.
4655         (parse_exp_in_context): Update.
4656         * parser-defs.h (struct parser_state) <parser_state>: Remove
4657         "initial_size" parameter.
4658
4659 2019-04-04  Tom Tromey  <tom@tromey.com>
4660
4661         * parser-defs.h (increase_expout_size): Don't declare.
4662         * parse.c (increase_expout_size): Now static.
4663
4664 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4665
4666         * gnu-nat.c (gnu_nat_target::wait): Fix
4667         target_waitstatus_to_string call.
4668
4669 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * eval.c (evaluate_subexp_standard): Handle internal functions
4672         during Fortran function call handling.
4673
4674 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4675
4676         * NEWS: Mention new internal functions.
4677         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4678         (read_base_type): Use dwarf2_init_complex_target_type.
4679         * value.c (creal_internal_fn): New function.
4680         (cimag_internal_fn): New function.
4681         (_initialize_values): Register new internal functions.
4682
4683 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4684
4685         * infrun.c (stop_all_threads): If debug_infrun, always
4686         trace the wait status after wait_one, using
4687         target_waitstatus_to_string and target_pid_to_str.
4688         (handle_inferior_event): Replace various trace of
4689         wait status kind by a single trace.
4690         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4691         wait status kind image by target_waitstatus_to_string.
4692         * target/waitstatus.c (target_waitstatus_to_string): Fix
4693         obsolete comment.
4694
4695 2019-04-01  Tom Tromey  <tromey@adacore.com>
4696
4697         PR symtab/23331:
4698         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4699
4700 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4701             Pedro Alves  <palves@redhat.com>
4702
4703         * top.c (quit_force): Call 'finalize_values'.
4704         * value.c (finalize_values): New function.
4705         * value.h (finalize_values): Declare.
4706
4707 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4708
4709         * NEWS: Announce $_gdb_major and $_gdb_minor.
4710
4711         * top.c (init_gdb_version_vars): New function.
4712         (gdb_init): Call init_gdb_version_vars.
4713
4714 2019-03-29  Tom Tromey  <tromey@adacore.com>
4715
4716         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4717         help text.  Remove dead code.
4718
4719 2019-03-29  Keith Seitz  <keiths@redhat.com>
4720
4721         From Siddhesh Poyarekar:
4722         * f-lang.h (f77_get_upperbound): Return LONGEST.
4723         (f77_get_lowerbound): Likewise.
4724         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4725         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4726         print them.
4727         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4728         plongest to format print it.
4729         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4730         (f77_get_upperbound): Likewise.
4731         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4732         LOWER_BOUND to LONGEST.
4733         (f77_create_arrayprint_offset_tbl): Likewise.
4734
4735 2019-03-29  Keith Seitz  <keiths@redhat.com>
4736
4737         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4738         %s/pulongest for TYPE_LENGTH instead of %d in format
4739         strings.
4740         * ada-typerint.c (ada_print_type): Likewise.
4741         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4742         * compile/compile-c-support.c (generate_register_struct): Likewise.
4743         * gdbtypes.c (recursive_dump_type): Likewise.
4744         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4745         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4746         instead of %d in format strings.
4747         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4748         to std::min to ULONGEST.
4749         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4750         instead of %d in format strings.
4751         * tracepoint.c (info_scope_command): Likewise.
4752         * typeprint.c (print_offset_data::update)
4753         (print_offset_data::finish): Likewise.
4754         * xtensa-tdep.c (xtensa_store_return_value)
4755         (xtensa_push_dummy_call): Likewise.
4756
4757 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4758
4759         * windows-nat.c (display_selector): Fixed format specifications
4760         for 64-bit Cygwin.
4761
4762 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4763
4764         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4765
4766 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4767
4768         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4769         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4770         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4771         (nios2_linux_init_abi): Install it.
4772
4773 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4774
4775         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4776
4777 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4778
4779         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4780
4781 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4782             Tom Tromey  <tromey@adacore.com>
4783
4784         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4785
4786 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4787
4788         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4789         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4790         method to compute the bounds of range types. Also print "[evaluated]"
4791         if the bounds' values come from a dynamic evaluation.
4792
4793 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4794
4795         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4796         whitespace when pretty printing is on.
4797
4798 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4799
4800         * ppc-linux-nat.c: Add include.
4801
4802 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4803
4804         * NEWS: Mention AArch64 Pointer Authentication.
4805
4806 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4807
4808         * arm-linux-nat.c: Add include.
4809
4810 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4811
4812         * source-cache.c (source_cache::get_source_lines): Re-read
4813         fullname after calling open_source_file.
4814
4815 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4816
4817         * NEWS: Mention TLS support for FreeBSD.
4818
4819 2019-03-25  Tom Tromey  <tromey@adacore.com>
4820
4821         * minsyms.c (BUNCH_SIZE): Update comment.
4822         (~minimal_symbol_reader): Remove old comment.
4823         (compact_minimal_symbols): Update comment.
4824         (minimal_symbol_reader::install): Remove old comment.  Update
4825         other comments.
4826
4827 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4828
4829         * s390-linux-nat.c: Add include.
4830
4831 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4832
4833         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4834         Call linux_get_hwcap.
4835         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4836         Likewise.
4837         (aarch64_linux_get_hwcap): Remove function.
4838         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4839         declaration.
4840         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4841         linux_get_hwcap.
4842         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4843         * linux-tdep.c (linux_get_hwcap): Add function.
4844         (linux_get_hwcap2): Likewise.
4845         * linux-tdep.h (linux_get_hwcap): Add declaration.
4846         (linux_get_hwcap2): Likewise.
4847         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4848         (ppc_linux_get_hwcap2): Likewise.
4849         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4850         linux_get_hwcap.
4851         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4852         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4853         (ppc_linux_nat_target::read_description): Likewise.
4854         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4855         * s390-linux-nat.c: Likewise.
4856         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4857
4858 2019-03-24  Tom Tromey  <tom@tromey.com>
4859
4860         * ada-lang.c (standard_lookup): Simplify initialization.
4861         (ada_lookup_symbol_nonlocal): Simplify return.
4862         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4863         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4864         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4865         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4866         initialization.
4867         * solib.c (solib_global_lookup): Simplify.
4868         * symtab.c (null_block_symbol): Remove.
4869         (symbol_cache_lookup): Simplify returns.
4870         (lookup_language_this): Simplify returns.
4871         (lookup_symbol_aux): Simplify return.
4872         (lookup_local_symbol): Simplify returns.
4873         (lookup_global_symbol_from_objfile): Simplify return.
4874         (lookup_symbol_in_objfile_symtabs)
4875         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4876         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4877         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4878         * cp-namespace.c (cp_lookup_bare_symbol)
4879         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4880         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4881         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4882         (cp_lookup_symbol_via_imports): Simplify initialization.
4883         (find_symbol_in_baseclass): Likewise.
4884         * symtab.h (null_block_symbol): Remove.
4885         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4886         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4887         (d_lookup_symbol_module): Likewise.
4888         (find_symbol_in_baseclass): Simplify initialization.
4889
4890 2019-03-24  Tom Tromey  <tom@tromey.com>
4891
4892         * expression.h: Don't include symtab.h.
4893         (struct block): Forward declare.
4894
4895 2019-03-24  Tom Tromey  <tom@tromey.com>
4896
4897         * c-exp.y (typebase): Remove casts.
4898         * gdbtypes.c (lookup_unsigned_typename, )
4899         (lookup_signed_typename): Remove cast.
4900         * eval.c (parse_to_comma_and_eval): Remove cast.
4901         * parse.c (write_dollar_variable): Remove cast.
4902         * block.h (struct block) <superblock>: Now const.
4903         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4904         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4905         (map_block): Make "block" const.
4906         * symfile.h (struct quick_symbol_functions)
4907         <map_matching_symbols>: Constify block argument to "callback".
4908         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4909         const.
4910         (find_pc_sect_compunit_symtab): Make "b" const.
4911         (find_symbol_at_address): Likewise.
4912         (search_symbols): Likewise.
4913         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4914         (dw2_debug_names_lookup_symbol): Likewise.
4915         (dw2_map_matching_symbols): Update.
4916         * p-valprint.c (pascal_val_print): Remove "block".
4917         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4918         (aux_add_nonlocal_symbols): Make "block" const.
4919         (resolve_subexp): Remove cast.
4920         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4921         const.
4922         (iterate_over_file_blocks): Likewise.
4923         * f-exp.y (%union) <bval>: Remove.
4924         * coffread.c (patch_opaque_types): Make "b" const.
4925         * spu-tdep.c (spu_catch_start): Make "block" const.
4926         * c-valprint.c (print_unpacked_pointer): Remove "block".
4927         * symmisc.c (dump_symtab_1): Make "b" const.
4928         (block_depth): Make "block" const.
4929         * d-exp.y (%union) <bval>: Remove.
4930         * cp-support.h (cp_lookup_rtti_type): Update.
4931         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4932         * psymtab.c (psym_lookup_symbol): Make "block" const.
4933         (maintenance_check_psymtabs): Make "b" const.
4934         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4935         (enumerate_locals, enumerate_args): Update.
4936         * python/py-symtab.c (stpy_global_block): Make "block" const.
4937         (stpy_static_block): Likewise.
4938         * inline-frame.c (block_starting_point_at): Make "new_block"
4939         const.
4940         * block.c (find_block_in_blockvector): Make return type const.
4941         (blockvector_for_pc_sect): Make "b" const.
4942         (find_block_in_blockvector): Make "b" const.
4943
4944 2019-03-23  Tom Tromey  <tom@tromey.com>
4945
4946         * varobj.c (varobj_create): Update.
4947         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4948         * printcmd.c (display_command, do_one_display): Don't reset
4949         innermost_block.
4950         * parser-defs.h (enum innermost_block_tracker_type): Move to
4951         expression.h.
4952         (innermost_block): Update comment.
4953         * parse.c (parse_exp_1): Add tracker_types parameter.
4954         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4955         tracker_types parameter.  Reset innermost_block.
4956         (parse_exp_in_context): Remove.
4957         (parse_expression_for_completion): Update.
4958         * objfiles.c (~objfile): Don't reset expression_context_block or
4959         innermost_block.
4960         * expression.h (enum innermost_block_tracker_type): Move from
4961         parser-defs.h.
4962         (parse_exp_1): Add tracker_types parameter.
4963         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4964         reset innermost_block.
4965
4966 2019-03-23  Tom Tromey  <tom@tromey.com>
4967
4968         * objfiles.h: Include bcache.h.
4969
4970 2019-03-23  Tom Tromey  <tom@tromey.com>
4971
4972         * linespec.c (get_current_search_block): Use
4973         scoped_restore_current_language.
4974         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4975
4976 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4977             Jiong Wang  <jiong.wang@arm.com>
4978
4979         * aarch64-linux-tdep.c
4980         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4981         section.
4982         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4983
4984 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4985             Jiong Wang  <jiong.wang@arm.com>
4986
4987         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4988         instructions.
4989         (aarch64_analyze_prologue_test): Add PACIASP test.
4990         (aarch64_prologue_prev_register): Unmask PC value.
4991
4992 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4993             Jiong Wang  <jiong.wang@arm.com>
4994
4995         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4996         (aarch64_dwarf2_prev_register): Unmask PC value.
4997         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4998         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4999         DW_CFA_AARCH64_negate_ra_state.
5000         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5001
5002 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5003             Jiong Wang  <jiong.wang@arm.com>
5004
5005         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5006         registers.
5007         (aarch64_pseudo_register_name): Likewise.
5008         (aarch64_pseudo_register_type): Likewise.
5009         (aarch64_pseudo_register_reggroup_p): Likewise.
5010         (aarch64_gdbarch_init): Add pauth registers.
5011         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5012         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5013         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5014         (struct gdbarch_tdep): Add regnum for ra_state.
5015
5016 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5017             Jiong Wang  <jiong.wang@arm.com>
5018
5019         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5020
5021 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5022             Jiong Wang  <jiong.wang@arm.com>
5023
5024         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5025         function.
5026         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5027         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5028         (aarch64_gdbarch_init): Add puth registers.
5029         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5030         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5031         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5032
5033 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5034             Jiong Wang  <jiong.wang@arm.com>
5035
5036         * aarch64-linux-nat.c
5037         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5038         * aarch64-linux-tdep.c
5039         (aarch64_linux_core_read_description): Likewise.
5040         (aarch64_linux_get_hwcap): New function.
5041         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5042         (aarch64_linux_get_hwcap): New declaration.
5043
5044 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5045             Jiong Wang  <jiong.wang@arm.com>
5046
5047         * aarch64-linux-nat.c
5048         (aarch64_linux_nat_target::read_description): Add pauth param.
5049         * aarch64-linux-tdep.c
5050         (aarch64_linux_core_read_description): Likewise.
5051         * aarch64-tdep.c (struct target_desc): Add in pauth.
5052         (aarch64_read_description): Add pauth param.
5053         (aarch64_gdbarch_init): Likewise.
5054         * aarch64-tdep.h (aarch64_read_description): Likewise.
5055         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5056         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5057         * features/Makefile: Add new files.
5058         * features/aarch64-pauth.c: New file.
5059         * features/aarch64-pauth.xml: New file.
5060
5061 2019-03-20  Tom Tromey  <tromey@adacore.com>
5062
5063         * infrun.c (handle_inferior_event): Rename from
5064         handle_inferior_event_1.  Create a scoped_value_mark.
5065         (handle_inferior_event): Remove.
5066
5067 2019-03-19  Tom Tromey  <tromey@adacore.com>
5068
5069         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5070         * infrun.h (print_stop_event): Add "displays" parameter.
5071         * infrun.c (print_stop_event): Add "displays" parameter.
5072
5073 2019-03-19  Pedro Alves  <palves@redhat.com>
5074
5075         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5076         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5077         to -1.  Fix TABs vs spaces.
5078         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5079         * tui/tui-out.h (tui_ui_out) Add intro comments.
5080         <m_line, m_start_of_line>: In-class initialize, and add describing
5081         comment.
5082
5083 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5084
5085         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5086         variable names.
5087         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5088
5089 2019-03-18  Pedro Alves  <palves@redhat.com>
5090             Eli Zaretskii <eliz@gnu.org>
5091
5092         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5093         m_line and m_start_of_line.
5094
5095 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5096
5097         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5098         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5099         it returns a newline.  This fixes a regression in TU mode, whereby
5100         the next line is output on the same screen line as the user input.
5101
5102 2019-03-18  Tom Tromey  <tromey@adacore.com>
5103
5104         * minsyms.c (minimal_symbol_reader::install): Remove call to
5105         obstack_blank.
5106
5107 2019-03-18  Pedro Alves  <palves@redhat.com>
5108
5109         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5110         New globals.
5111         (apply_style): New, factored out from ...
5112         (apply_ansi_escape): ... this.  Handle reverse video mode.
5113         (tui_set_reverse_mode): New function.
5114         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5115         * tui/tui-winsource.c (tui_show_source_line): Use
5116         tui_set_reverse_mode instead of setting A_STANDOUT.
5117         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5118         New setter methods.
5119
5120 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5121
5122         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5123         Handle tabs.
5124
5125 2019-03-18  Tom Tromey  <tromey@adacore.com>
5126
5127         * ada-lang.c (empty_array): Add "high" parameter.
5128         (ada_evaluate_subexp): Update.
5129
5130 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5131
5132         * unittests/string_view-selftests.c: Define
5133         _initialize_string_view_selftests unconditionally.
5134
5135 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5136
5137         PR gdb/24350
5138         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5139
5140 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5141
5142         PR gdb/24351
5143         * windows-nat.c (display_selector): Fix format specifiers.
5144
5145 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5146
5147         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5148         tui_refill_source_window instead of tui_refresh_win, to update the
5149         current execution line.  This fixes redisplay of the current line
5150         when stepping through the code with "next" or "step".
5151
5152 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5153
5154         * source-cache.c (source_cache::get_source_lines): Call
5155         find_source_lines to initialize s->nlines.  This fixes vertical
5156         scrolling of TUI source window when the DOWN arrow is pressed.
5157
5158 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5159
5160         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5161         linux-thread-db.c (_initialize_thread_db): Likewise.
5162
5163 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5164
5165         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5166         wclrtoeol in tui_show_source_line".  This reverts changes made in
5167         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5168
5169 2019-03-15  Tom Tromey  <tom@tromey.com>
5170
5171         * symtab.h (struct minimal_symbol): Derive from
5172         general_symbol_info.
5173         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5174         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5175         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5176         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5177         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5178         (MSYMBOL_SEARCH_NAME): Update.
5179         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5180         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5181         * minsyms.c (minimal_symbol_reader::record_full): Update.
5182
5183 2019-03-15  Tom Tromey  <tom@tromey.com>
5184
5185         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5186
5187 2019-03-15  Tom Tromey  <tom@tromey.com>
5188
5189         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5190         unique_xmalloc_ptr.
5191         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5192         Update.
5193         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5194         (build_minimal_symbol_hash_tables)
5195         (minimal_symbol_reader::install): Update.
5196
5197 2019-03-15  Tom Tromey  <tom@tromey.com>
5198
5199         * symtab.c (create_demangled_names_hash): Update.
5200         (symbol_set_names): Update.
5201         * objfiles.h (struct objfile_per_bfd_storage)
5202         <demangled_names_hash>: Now an htab_up.
5203         * objfiles.c (objfile_per_bfd_storage): Simplify.
5204
5205 2019-03-15  Tom Tromey  <tom@tromey.com>
5206
5207         * objfiles.h (struct objfile_per_bfd_storage): Declare
5208         destructor.
5209         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5210         New.
5211         (get_objfile_bfd_data): Use new.  Don't initialize
5212         language_of_main.
5213         (free_objfile_per_bfd_storage): Remove.
5214         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5215
5216 2019-03-15  Tom Tromey  <tom@tromey.com>
5217
5218         * symfile.c (reread_symbols): Update.
5219         * objfiles.c (objfile::objfile): Update.
5220         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5221         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5222         comment.
5223         (minimal_symbol_reader::install): Update.
5224         (terminate_minimal_symbol_table): Remove.
5225         * jit.c (jit_object_close_impl): Update.
5226
5227 2019-03-15  Tom Tromey  <tom@tromey.com>
5228
5229         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5230         initializations.
5231
5232 2019-03-15  Tom Tromey  <tom@tromey.com>
5233
5234         * objfiles.h (struct objfile_per_bfd_storage)
5235         <demangled_hash_languages>: Now a bitset.
5236         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5237         (lookup_minimal_symbol): Update.
5238
5239 2019-03-15  Tom Tromey  <tom@tromey.com>
5240
5241         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5242         Don't return the symbol.
5243         * coffread.c (record_minimal_symbol): Use record_full.
5244
5245 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5246
5247         The MS-Windows port of ncurses fails to switch to a color pair if
5248         one or both of the colors are the implicit default colors.  This
5249         change records the default colors when TUI is initialized, and
5250         then specifies them explicitly when a color pair uses the default
5251         colors.  This allows color styling in TUI mode on MS-Windows.
5252
5253         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5254         ncurses_norm_attr.
5255         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5256         colors in ncurses_norm_attr.
5257         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5258         "none", replace it with the default color recorded in
5259         ncurses_norm_attr.
5260
5261 2019-03-14  Tom Tromey  <tromey@adacore.com>
5262
5263         * source-cache.h (class source_cache) <get_source_lines>: Return
5264         std::string.
5265         * source-cache.c (source_cache::extract_lines): Handle case where
5266         first_pos==npos.  Return std::string.
5267         (source_cache::get_source_lines): Update.
5268
5269 2019-03-14  Tom Tromey  <tromey@adacore.com>
5270
5271         * NEWS: Add item for "style sources" commands.
5272         * source-cache.c (source_cache::get_source_lines): Check
5273         source_styling.
5274         * cli/cli-style.c (source_styling): New global.
5275         (_initialize_cli_style): Add "style sources" commands.
5276         (show_style_sources): New function.
5277         * cli/cli-style.h (source_styling): Declare.
5278
5279 2019-03-14  Pedro Alves  <palves@redhat.com>
5280             Tom Tromey  <tromey@adacore.com>
5281
5282         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5283         * tui/tui-winsource.c (tui_refill_source_window): New function,
5284         from...
5285         (tui_horizontal_source_scroll): ... here.  Move some logic.
5286         * cli/cli-style.c (set_style_enabled): Notify new observable.
5287         * tui/tui-hooks.c (tui_redisplay_source): New function.
5288         (tui_attach_detach_observers): Attach or detach
5289         tui_redisplay_source.
5290         * observable.h (source_styling_changed): New observable.
5291         * observable.c: Define source_styling_changed observable.
5292
5293 2019-03-13  Tom Tromey  <tromey@adacore.com>
5294
5295         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5296         (i386_gnu_nat_target::store_registers): Update.
5297         * target-debug.h (target_debug_print_std_string): New macro.
5298         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5299         * windows-tdep.c (display_one_tib): Update.
5300         * tui/tui-stack.c (tui_make_status_line): Update.
5301         * top.c (print_inferior_quit_action): Update.
5302         * thread.c (thr_try_catch_cmd): Update.
5303         (add_thread_with_info): Update.
5304         (thread_target_id_str): Update.
5305         (thr_try_catch_cmd): Update.
5306         (thread_command): Update.
5307         (thread_find_command): Update.
5308         * record-btrace.c (record_btrace_target::info_record)
5309         (record_btrace_resume_thread, record_btrace_target::resume)
5310         (record_btrace_cancel_resume, record_btrace_step_thread)
5311         (record_btrace_target::wait, record_btrace_target::wait)
5312         (record_btrace_target::wait, record_btrace_target::stop): Update.
5313         * progspace.c (print_program_space): Update.
5314         * process-stratum-target.c
5315         (process_stratum_target::thread_address_space): Update.
5316         * linux-fork.c (linux_fork_mourn_inferior)
5317         (detach_checkpoint_command, info_checkpoints_command)
5318         (linux_fork_context): Update.
5319         (linux_fork_detach): Update.
5320         (class scoped_switch_fork_info): Update.
5321         (delete_checkpoint_command): Update.
5322         * infrun.c (follow_fork_inferior): Update.
5323         (follow_fork_inferior): Update.
5324         (proceed_after_vfork_done): Update.
5325         (handle_vfork_child_exec_or_exit): Update.
5326         (follow_exec): Update.
5327         (displaced_step_prepare_throw): Update.
5328         (displaced_step_restore): Update.
5329         (start_step_over): Update.
5330         (resume_1): Update.
5331         (clear_proceed_status_thread): Update.
5332         (proceed): Update.
5333         (print_target_wait_results): Update.
5334         (do_target_wait): Update.
5335         (context_switch): Update.
5336         (stop_all_threads): Update.
5337         (restart_threads): Update.
5338         (finish_step_over): Update.
5339         (handle_signal_stop): Update.
5340         (switch_back_to_stepped_thread): Update.
5341         (keep_going_pass_signal): Update.
5342         (print_exited_reason): Update.
5343         (normal_stop): Update.
5344         * inferior.c (inferior_pid_to_str): Change return type.
5345         (print_selected_inferior): Update.
5346         (add_inferior): Update.
5347         (detach_inferior): Update.
5348         * dummy-frame.c (fprint_dummy_frames): Update.
5349         * dcache.c (dcache_info_1): Update.
5350         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5351         (btrace_fetch, btrace_clear): Update.
5352         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5353         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5354         type.
5355         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5356         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5357         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5358         * gdbarch.c, gdbarch.h: Rebuild.
5359         * gdbarch.sh (core_pid_to_str): Change return type.
5360         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5361         return type.
5362         (windows_nat_target::pid_to_str): Change return type.
5363         (windows_delete_thread): Update.
5364         (windows_nat_target::attach): Update.
5365         (windows_nat_target::files_info): Update.
5366         * target-delegates.c: Rebuild.
5367         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5368         return type.
5369         (sol_thread_target::pid_to_str): Change return type.
5370         * remote.c (class remote_target) <pid_to_str>: Change return
5371         type.
5372         (remote_target::pid_to_str): Change return type.
5373         (extended_remote_target::attach, remote_target::remote_stop_ns)
5374         (remote_target::remote_notif_remove_queued_reply)
5375         (remote_target::push_stop_reply, remote_target::disable_btrace):
5376         Update.
5377         (extended_remote_target::attach): Update.
5378         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5379         type.
5380         (gdbsim_target::pid_to_str): Change return type.
5381         * ravenscar-thread.c (struct ravenscar_thread_target)
5382         <pid_to_str>: Change return type.
5383         (ravenscar_thread_target::pid_to_str): Change return type.
5384         * procfs.c (class procfs_target) <pid_to_str>: Change return
5385         type.
5386         (procfs_target::pid_to_str): Change return type.
5387         (procfs_target::attach): Update.
5388         (procfs_target::detach): Update.
5389         (procfs_target::fetch_registers): Update.
5390         (procfs_target::store_registers): Update.
5391         (procfs_target::wait): Update.
5392         (procfs_target::files_info): Update.
5393         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5394         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5395         return type.
5396         (nto_procfs_target::pid_to_str): Change return type.
5397         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5398         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5399         return type.
5400         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5401         (exit_lwp): Update.
5402         (attach_proc_task_lwp_callback, get_detach_signal)
5403         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5404         (linux_nat_target::resume, wait_lwp, stop_callback)
5405         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5406         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5407         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5408         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5409         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5410         type.
5411         (inf_ptrace_target::attach): Update.
5412         (inf_ptrace_target::files_info): Update.
5413         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5414         type.
5415         (go32_nat_target::pid_to_str): Change return type.
5416         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5417         (gnu_nat_target::wait): Update.
5418         (gnu_nat_target::wait): Update.
5419         (gnu_nat_target::resume): Update.
5420         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5421         (fbsd_nat_target::wait): Update.
5422         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5423         type.
5424         (darwin_nat_target::attach): Update.
5425         * corelow.c (class core_target) <pid_to_str>: Change return type.
5426         (core_target::pid_to_str): Change return type.
5427         * target.c (normal_pid_to_str): Change return type.
5428         (default_pid_to_str): Likewise.
5429         (target_pid_to_str): Change return type.
5430         (target_translate_tls_address): Update.
5431         (target_announce_detach): Update.
5432         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5433         return type.
5434         (bsd_uthread_target::pid_to_str): Change return type.
5435         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5436         type.
5437         (bsd_kvm_target::pid_to_str): Change return type.
5438         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5439         return type.
5440         (aix_thread_target::pid_to_str): Change return type.
5441         * target.h (struct target_ops) <pid_to_str>: Change return type.
5442         (target_pid_to_str, normal_pid_to_str): Likewise.
5443         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5444         type.
5445         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5446         type.
5447         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5448         return type.
5449         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5450         type.
5451         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5452         type.
5453         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5454         return type.
5455
5456 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5457
5458         * NEWS: Mention that the new default MI version is 3.  Mention
5459         changes to the output of commands and events that deal with
5460         multi-location breakpoints.
5461         * breakpoint.c: Include "mi/mi-out.h".
5462         (print_one_breakpoint): Change output syntax if using MI version
5463         >= 3.
5464         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5465         New.
5466         (mi_multi_location_breakpoint_output_fixed): New.
5467         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5468         (mi_cmd_fix_multi_location_breakpoint_output): New.
5469         (mi_multi_location_breakpoint_output_fixed): New.
5470         * mi/mi-cmds.c (mi_cmds): Register command
5471         -fix-multi-location-breakpoint-output.
5472         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5473         interpreter "mi".
5474
5475 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5476
5477         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5478         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5479         instantiate mi_ui_out based on interpreter name.
5480         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5481         * mi/mi-main.c (mi_load_progress): Likewise.
5482
5483 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5484
5485         * NEWS: Combine separate "New targets" sections for 8.3.
5486
5487 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5488
5489         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5490         (ppcfbsd_init_abi): Install gdbarch
5491         "fetch_tls_load_module_address" and "get_thread_local_address"
5492         methods.
5493
5494 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5495
5496         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5497         (riscv_fbsd_init_abi): Install gdbarch
5498         "fetch_tls_load_module_address" and "get_thread_local_address"
5499         methods.
5500
5501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5502
5503         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5504         (i386fbsd_init_abi): Install gdbarch
5505         "fetch_tls_load_module_address" and "get_thread_local_address"
5506         methods.
5507
5508 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5509
5510         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5511         (amd64fbsd_init_abi): Install gdbarch
5512         "fetch_tls_load_module_address" and "get_thread_local_address"
5513         methods.
5514
5515 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5516
5517         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5518         (struct fbsd_pspace_data): New type.
5519         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5520         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5521         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5522         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5523         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5524
5525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5526
5527         * gdbtypes.c (lookup_struct_elt): New function.
5528         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5529         * gdbtypes.h (struct struct_elt): New type.
5530         (lookup_struct_elt): New prototype.
5531
5532 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5533
5534         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5535         remove disabled code block.
5536
5537 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5538
5539         * gdbarch.sh (get_thread_local_address): New method.
5540         * gdbarch.h, gdbarch.c: Regenerate.
5541         * target.c (target_translate_tls_address): Use
5542         gdbarch_get_thread_local_address if present instead of
5543         target::get_thread_local_address.
5544
5545 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5546
5547         * target.h (target::get_thread_local_address): Update comment.
5548
5549 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5550
5551         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5552         objfile->separate_debug_objfile_backlink if not NULL.
5553
5554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5555
5556         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5557         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5558         (amd64bsd_store_inferior_registers): Likewise.
5559         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5560         Enable segment base registers.
5561         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5562         PT_GETFSBASE and PT_GETGSBASE.
5563         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5564         PT_SETGSBASE.
5565         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5566         segment base registers.
5567         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5568
5569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5570
5571         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5572         Update calls to i386_target_description to add 'segments'
5573         parameter.
5574         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5575         add segment base registers.
5576         * arch/i386.c (i386_create_target_description): Add 'segments'
5577         parameter to enable segment base registers.
5578         * arch/i386.h (i386_create_target_description): Likewise.
5579         * features/i386/32bit-segments.xml: New file.
5580         * features/i386/32bit-segments.c: Generate.
5581         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5582         call to i386_target_description to add 'segments' parameter.
5583         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5584         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5585         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5586         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5587         if feature is present.
5588         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5589         Add 'segments' parameter to call to i386_target_description.
5590         (i386_target_description): Add 'segments' parameter to enable
5591         segment base registers.
5592         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5593         to call to i386_target_description.
5594         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5595         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5596         Define I386_NUM_REGS.
5597         (i386_target_description): Add 'segments' parameter to enable
5598         segment base registers.
5599
5600 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5601
5602         PR/24325
5603         * source-cache.c: #undef open and close, to avoid unresolved
5604         externals during linking.
5605
5606 2019-03-12  Tom Tromey  <tromey@adacore.com>
5607
5608         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5609         const.  Add initializers.
5610         (_initialize_remote): Don't initialize ptid globals.
5611
5612 2019-03-12  Pedro Alves  <palves@redhat.com>
5613
5614         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5615
5616 2019-03-12  Pedro Alves  <palves@redhat.com>
5617
5618         * cp-name-parser.y (main): Remove unused 'len' variable.
5619
5620 2019-03-12  Tom Tromey  <tromey@adacore.com>
5621
5622         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5623         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5624
5625 2019-03-12  Tom Tromey  <tromey@adacore.com>
5626
5627         * linux-nat.c (iterate_over_lwps): Update.
5628         (stop_callback): Remove parameter.
5629         (stop_wait_callback, detach_callback, resume_set_callback)
5630         (select_singlestep_lwp_callback, set_ignore_sigint)
5631         (status_callback, resumed_callback, resume_clear_callback)
5632         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5633         data parameter.
5634         (linux_nat_target::detach, linux_nat_target::resume)
5635         (linux_stop_and_wait_all_lwps, select_event_lwp)
5636         (linux_nat_filter_event, linux_nat_wait_1)
5637         (linux_nat_target::kill, linux_nat_target::stop)
5638         (linux_nat_target::stop): Update.
5639         (linux_nat_resume_callback): Change type.
5640         (resume_stopped_resumed_lwps, count_events_callback)
5641         (select_event_lwp_callback): Likewise.
5642         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5643         * arm-linux-nat.c (struct update_registers_data): Remove.
5644         (update_registers_callback): Change type.
5645         (arm_linux_insert_hw_breakpoint1): Update.
5646         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5647         parameter.
5648         (x86_linux_dr_set_addr): Update.
5649         (x86_linux_dr_set_control): Update.
5650         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5651         (iterate_over_lwps): Use gdb::function_view.
5652         * nat/aarch64-linux-hw-point.c (struct
5653         aarch64_dr_update_callback_param): Remove.
5654         (debug_reg_change_callback): Change type.
5655         (aarch64_notify_debug_reg_change): Update.
5656         * s390-linux-nat.c (s390_refresh_per_info): Update.
5657
5658 2019-03-11  Tom Tromey  <tromey@adacore.com>
5659
5660         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5661         redundant assignment to "this_cu".
5662
5663 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5664
5665         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5666
5667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5668
5669         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5670         from...
5671         (rank_one_type): ... this.
5672
5673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5674
5675         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5676         from...
5677         (rank_one_type): ... this.
5678
5679 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5680
5681         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5682         from...
5683         (rank_one_type): ... this.
5684
5685 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5686
5687         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5688         from...
5689         (rank_one_type): ... this.
5690
5691 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5692
5693         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5694         from...
5695         (rank_one_type): ... this.
5696
5697 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5698
5699         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5700         from...
5701         (rank_one_type): ... this.
5702
5703 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5704
5705         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5706         from...
5707         (rank_one_type): ... this.
5708
5709 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5710
5711         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5712         from...
5713         (rank_one_type): ... this.
5714
5715 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5716
5717         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5718         from...
5719         (rank_one_type): ... this.
5720
5721 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5722
5723         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5724         from...
5725         (rank_one_type): ... this.
5726
5727 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5728
5729         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5730         from...
5731         (rank_one_type): ... this.
5732
5733 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5734
5735         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5736         from...
5737         (rank_one_type): ... this.
5738
5739 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5740
5741         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5742         inferior-events' shows the example events.
5743
5744 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5745
5746         Support styling on native MS-Windows console
5747
5748         PR/24315
5749         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5750         on MS-Windows if $TERM is not defined.
5751
5752         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5753
5754         * posix-hdep.c (gdb_console_fputs):
5755         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5756         functions.
5757         * ui-file.h (gdb_console_fputs): Add prototype.
5758
5759         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5760         back to fputs only if the former returns zero.
5761
5762 2019-03-07  Tom Tromey  <tom@tromey.com>
5763
5764         * symmisc.c (print_symbol_bcache_statistics): Update.
5765         (print_objfile_statistics): Update.
5766         * symfile.c (allocate_symtab): Update.
5767         * stabsread.c: Don't include bcache.h.
5768         * psymtab.h (struct psymbol_bcache): Don't declare.
5769         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5770         (psymbol_bcache_init, psymbol_bcache_free)
5771         (psymbol_bcache_get_bcache): Don't declare.
5772         * psymtab.c (struct psymbol_bcache): Remove.
5773         (psymtab_storage::psymtab_storage): Update.
5774         (psymtab_storage::~psymtab_storage): Update.
5775         (psymbol_bcache_init, psymbol_bcache_free)
5776         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5777         (add_psymbol_to_bcache): Update.
5778         (allocate_psymtab): Update.
5779         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5780         macro_cache>: No longer pointers.
5781         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5782         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5783         * macrotab.c (macro_bcache): Update.
5784         * macroexp.c: Don't include bcache.h.
5785         * gdbtypes.c (check_types_worklist): Update.
5786         (types_deeply_equal): Remove TRY/CATCH.  Update.
5787         * elfread.c (elf_symtab_read): Update.
5788         * dwarf2read.c: Don't include bcache.h.
5789         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5790         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5791         (print_bcache_statistics, bcache_memory_used): Don't declare.
5792         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5793         methods.  Rename all data members.
5794         * bcache.c (struct bcache): Move to bcache.h.
5795         (bcache::expand_hash_table): Rename from expand_hash_table.
5796         (bcache): Remove.
5797         (bcache::insert): Rename from bcache_full.
5798         (bcache::compare): Rename from bcache_compare.
5799         (bcache_xmalloc): Remove.
5800         (bcache::~bcache): Rename from bcache_xfree.
5801         (bcache::print_statistics): Rename from print_bcache_statistics.
5802         (bcache::memory_used): Rename from bcache_memory_used.
5803
5804 2019-03-07  Pedro Alves  <palves@redhat.com>
5805
5806         * infrun.c (normal_stop): Also check for
5807         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5808
5809 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5810
5811         * f-lang.c (value_from_host_double): Moved to...
5812         * value.c (value_from_host_double): ...here.
5813         * value.h (value_from_host_double): Declare.
5814         * guile/scm-math.c (vlscm_convert_typed_number): Use
5815         value_from_host_double.
5816         (vlscm_convert_number): Likewise.
5817         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5818         * python/py-value.c (convert_value_from_python): Likewise.
5819
5820 2019-03-06  Tom Tromey  <tom@tromey.com>
5821
5822         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5823
5824 2019-03-06  Tom Tromey  <tom@tromey.com>
5825
5826         * utils.h (free_current_contents): Don't declare.
5827         * utils.c (free_current_contents): Remove.
5828
5829 2019-03-06  Tom Tromey  <tom@tromey.com>
5830
5831         * top.c (quit_force): Update.
5832         * main.c (captured_command_loop): Update.
5833         * common/new-op.c (operator new): Update.
5834         * common/common-exceptions.c (struct catcher)
5835         <save_cleanup_chain>: Remove member.
5836         (exceptions_state_mc_init): Update.
5837         (exception_try_scope_entry): Return nullptr.
5838         (exception_try_scope_exit, exception_rethrow)
5839         (throw_exception_sjlj, throw_exception_cxx): Update.
5840         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5841         (all_cleanups, do_cleanups, discard_cleanups)
5842         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5843         (restore_cleanups, restore_final_cleanups): Don't declare.
5844         (do_final_cleanups): Remove parameter.
5845         * common/cleanups.c (cleanup_chain, make_cleanup)
5846         (make_cleanup_dtor, all_cleanups, do_cleanups)
5847         (discard_my_cleanups, discard_cleanups)
5848         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5849         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5850         (null_cleanup): Remove.
5851         (do_final_cleanups): Remove parameter.
5852
5853 2019-03-06  Tom Tromey  <tom@tromey.com>
5854
5855         * remote.c (remote_target::remote_parse_stop_reply): Use
5856         unique_xmalloc_ptr.
5857
5858 2019-03-06  Tom Tromey  <tom@tromey.com>
5859
5860         * stabsread.c (struct stabs_field_info): Rename from field_info.
5861         <list, fnlist>: Add initializers.
5862         <obstack>: New member.
5863         (read_member_functions, read_struct_fields, read_baseclasses):
5864         Allocate on obstack.  Don't use cleanups.
5865         (read_one_struct_field, read_member_functions, read_struct_fields)
5866         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5867         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5868         (read_struct_type): Update.
5869
5870 2019-03-06  Tom Tromey  <tom@tromey.com>
5871
5872         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5873         * common/filestuff.h (make_cleanup_close): Don't declare.
5874         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5875         Remove.
5876
5877 2019-03-06  Tom Tromey  <tom@tromey.com>
5878
5879         * solib-aix.c: Use make_scope_exit.
5880
5881 2019-03-06  Tom Tromey  <tom@tromey.com>
5882
5883         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5884         Use make_scope_exit.
5885
5886 2019-03-06  Tom Tromey  <tom@tromey.com>
5887
5888         * solib-svr4.c (disable_probes_interface): Remove parameter.
5889         (svr4_handle_solib_event): Use make_scope_exit.
5890
5891 2019-03-06  Tom Tromey  <tom@tromey.com>
5892
5893         * remote.c (struct stop_reply_deleter): Remove.
5894         (stop_reply_up): Update.
5895         (struct stop_reply): Derive from notif_event.  Don't typedef.
5896         <regcache>: Now a std::vector.
5897         (stop_reply_xfree): Remove.
5898         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5899         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5900         (remote_target::discard_pending_stop_replies): Use delete.
5901         (remote_target::remote_parse_stop_reply): Update.
5902         (remote_target::process_stop_reply): Update.
5903         * remote-notif.h (struct notif_event): Add virtual destructor.
5904         Remove "dtr" member.
5905         (struct notif_client) <alloc_event>: Return a unique_ptr.
5906         (notif_event_xfree): Don't declare.
5907         (notif_event_up): New typedef.
5908         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5909         (notif_event_xfree, do_notif_event_xfree): Remove.
5910         (remote_notif_state_xfree): Update.
5911
5912 2019-03-06  Tom Tromey  <tom@tromey.com>
5913
5914         * infrun.c (displaced_step_clear_cleanup): Now a
5915         forward_scope_exit type.
5916         (displaced_step_prepare_throw): Update.
5917         (displaced_step_fixup): Update.
5918
5919 2019-03-06  Tom Tromey  <tom@tromey.com>
5920
5921         * inferior.h (class inferior): Update comment.
5922         * gdbthread.h (class thread_info): Update comment.
5923
5924 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5925             Tom Tromey  <tom@tromey.com>
5926
5927         * stabsread.h (struct stab_section_list): Remove.
5928         (coffstab_build_psymtabs): Update.
5929         * dbxread.c (symbuf_sections): Now a std::vector.
5930         (sect_idx): New global.
5931         (fill_symbuf): Update.
5932         (coffstab_build_psymtabs): Change type of stabsects parameter.
5933         Update.
5934         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5935         std::vector.
5936         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5937         (coff_locate_sections): Update.
5938         (coff_symfile_read): Remove cleanups.  Update.
5939         (init_stringtab): Add storage parameter.
5940         (free_stringtab, free_stringtab_cleanup): Remove.
5941         (init_lineno): Add storage parameter.
5942         (free_linetab, free_linetab_cleanup): Remove.
5943
5944 2019-03-06  Pedro Alves  <palves@redhat.com>
5945
5946         * linux-fork.c (fork_info::clobber_regs): Delete.
5947         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5948         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5949         comment.  Adjust.
5950         (scoped_switch_fork_info::scoped_switch_fork_info)
5951         (checkpoint_command, linux_fork_context): Adjust
5952         fork_save_infrun_state calls.
5953
5954 2019-03-06  Pedro Alves  <palves@redhat.com>
5955
5956         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5957         (inf_has_multiple_threads): Return 'bool' and rewrite using
5958         inferior_info::threads().
5959
5960 2019-03-06  Pedro Alves  <palves@redhat.com>
5961
5962         * linux-fork.c: Include <list>.
5963         (fork_list): Now a std::list instance.
5964         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5965         (forks_exist_p, find_last_fork): Adjust.
5966         (new_fork): Delete.
5967         (one_fork_p): New.
5968         (add_fork): Adjust.
5969         (free_fork): Delete, folded into fork_info::~fork_info().
5970         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5971         Adjust.
5972         (init_fork_list): Delete.
5973         (linux_fork_killall, linux_fork_mourn_inferior)
5974         (linux_fork_detach, info_checkpoints_command): Adjust.
5975         (_initialize_linux_fork): No longer call init_fork_list.
5976
5977 2019-03-06  Pedro Alves  <palves@redhat.com>
5978
5979         * linux-fork.c (new_fork): New, split out of ...
5980         (add_fork): ... this.  Return void.  Move "first fork" special
5981         case from here, to ...
5982         (checkpoint_command): ... here.
5983         * linux-linux.h (add_fork): Return void.
5984
5985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5986
5987         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5988
5989 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5990             Chris January  <chris.january@arm.com>
5991             David Lecomber  <david.lecomber@arm.com>
5992
5993         * f-exp.y: New token, UNOP_INTRINSIC.
5994         (exp): New pattern using UNOP_INTRINSIC token.
5995         (f77_keywords): Add 'abs' keyword.
5996         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5997         (value_from_host_double): New function.
5998         (evaluate_subexp_f): Support UNOP_ABS.
5999
6000 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6001
6002         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6003         types.
6004
6005 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6006
6007         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6008         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6009         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6010
6011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6012
6013         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6014
6015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6016             Chris January  <chris.january@arm.com>
6017
6018         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6019         * f-exp.y: Define 'KIND' token.
6020         (exp): New pattern for KIND expressions.
6021         (ptype): Handle types with a kind extension.
6022         (direct_abs_decl): Extend to spot kind extensions.
6023         (f77_keywords): Add 'kind' to the list.
6024         (push_kind_type): New function.
6025         (convert_to_kind_type): New function.
6026         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6027         * parse.c (operator_length_standard): Likewise.
6028         * parser-defs.h (enum type_pieces): Add tp_kind.
6029         * std-operator.def: Add UNOP_KIND.
6030
6031 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * f-exp.y (f_parse): Set yydebug.
6034
6035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6036
6037         * f-lang.c (evaluate_subexp_f): New function.
6038         (exp_descriptor_f): New global.
6039         (f_language_defn): Use exp_descriptor_f instead of
6040         exp_descriptor_standard.
6041
6042 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6043
6044         * f-exp.y (struct token): Add comments.
6045         (dot_ops): Remove uppercase versions and the end marker.
6046         (f77_keywords): Likewise.
6047         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6048         entries in the dot_ops array are case insensitive, and use
6049         strncasecmp to compare strings.  Also some whitespace cleanup in
6050         this area.  Similar for the f77_keywords array, except entries in
6051         this list might be case sensitive.
6052
6053 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6054
6055         * f-exp.y (struct f77_boolean_val): Add comments.
6056         (boolean_values): Remove uppercase versions, and end marker.
6057         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6058         and use strncasecmp to achieve case insensitivity.  Additionally,
6059         perform whitespace cleanup around this code.
6060
6061 2019-03-06  Tom Tromey  <tromey@adacore.com>
6062
6063         * remote-sim.c (gdbsim_target_open): Use result of
6064         gdb_argv::release.
6065
6066 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6067         Dirk Schubert  <dirk.schubert@arm.com>
6068         Chris January  <chris.january@arm.com>
6069
6070         * eval.c (evaluate_subexp_standard): Call Fortran argument
6071         wrapping logic.
6072         * f-lang.c (struct value): A value which can be passed into a
6073         Fortran function call.
6074         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6075         where appropriate.
6076         (struct type): Value ready for a Fortran function call.
6077         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6078         is needed.
6079         * f-lang.h (fortran_argument_convert): Declaration.
6080         (fortran_preserve_arg_pointer): Declaration.
6081         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6082
6083 2019-03-05  Tom Tromey  <tromey@adacore.com>
6084
6085         * python/py-prettyprint.c (print_string_repr): Remove #if.
6086         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6087
6088 2019-03-05  Tom Tromey  <tromey@adacore.com>
6089
6090         * target.c (the_dummy_target): Move later.  Change type to
6091         "dummy_target".
6092         (initialize_targets): Don't initialize the_dummy_target.
6093
6094 2019-03-05  Tom Tromey  <tromey@adacore.com>
6095
6096         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6097         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6098
6099 2019-03-05  Tom Tromey  <tromey@adacore.com>
6100
6101         * windows-nat.c (windows_nat_target::attach)
6102         (windows_nat_target::detach): Don't call gdb_flush.
6103         * valprint.c (generic_val_print, val_print, val_print_string):
6104         Don't call gdb_flush.
6105         * utils.c (defaulted_query): Don't call gdb_flush.
6106         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6107         * target.c (target_announce_detach): Don't call gdb_flush.
6108         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6109         * remote.c (extended_remote_target::attach): Don't call
6110         gdb_flush.
6111         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6112         * printcmd.c (do_examine): Don't call gdb_flush.
6113         (info_display_command): Don't call gdb_flush.
6114         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6115         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6116         * memattr.c (info_mem_command): Don't call gdb_flush.
6117         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6118         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6119         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6120         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6121         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6122         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6123         (gnu_nat_target::detach): Don't call gdb_flush.
6124         * f-valprint.c (f_val_print): Don't call gdb_flush.
6125         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6126         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6127         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6128         gdb_flush.
6129         * c-valprint.c (c_val_print): Don't call gdb_flush.
6130         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6131
6132 2019-03-05  Tom Tromey  <tromey@adacore.com>
6133
6134         * varobj.c (update_dynamic_varobj_children): Update.
6135         (install_default_visualizer): Use reset, not release.
6136         * value.c (set_internalvar): Update.
6137         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6138         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6139         ATTRIBUTE_UNUSED_RESULT.
6140
6141 2019-03-05  Tom Tromey  <tromey@adacore.com>
6142
6143         * remote.c (class scoped_remote_fd) <release>: Add
6144         ATTRIBUTE_UNUSED_RESULT.
6145
6146 2019-03-05  Tom Tromey  <tromey@adacore.com>
6147
6148         * macroexp.c (struct macro_buffer) <release>: Add
6149         ATTRIBUTE_UNUSED_RESULT.
6150
6151 2019-03-05  Tom Tromey  <tromey@adacore.com>
6152
6153         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6154         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6155         ATTRIBUTE_UNUSED_RESULT.
6156
6157 2019-03-05  Tom Tromey  <tromey@adacore.com>
6158
6159         * common/scoped_fd.h (class scoped_fd) <release>: Add
6160         ATTRIBUTE_UNUSED_RESULT.
6161
6162 2019-03-05  Tom Tromey  <tromey@adacore.com>
6163
6164         * parser-defs.h (struct parser_state) <release>: Add
6165         ATTRIBUTE_UNUSED_RESULT.
6166
6167 2019-03-05  Tom Tromey  <tromey@adacore.com>
6168
6169         * utils.h (class gdb_argv) <release>: Add
6170         ATTRIBUTE_UNUSED_RESULT.
6171         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6172
6173 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6174
6175         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6176         for-loop range, to avoid compiler warnings.
6177
6178         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6179         avoid compiler warnings about unused variables.
6180
6181         * NEWS: Mention end of support for native debugging on MS-Windows
6182         before XP.
6183
6184         PR gdb/24292
6185         * common/netstuff.c:
6186         * gdbserver/gdbreplay.c
6187         * gdbserver/remote-utils.c:
6188         * ser-tcp.c:
6189         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6190         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6191         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6192         'getaddrinfo' and 'freeaddrinfo' were not available before
6193         Windows XP, and mingw.org's MinGW headers by default define
6194         _WIN32_WINNT to 0x500.
6195
6196 2019-03-01  Gary Benson <gbenson@redhat.com>
6197
6198         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6199
6200 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6201             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6202
6203         PR gdb/8527
6204         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6205         set_sigint_trap, clear_sigint_trap.
6206
6207 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6208
6209         * target.c (target_detach): Clear the regcache and the
6210         frame cache.
6211
6212 2019-02-27  Pedro Alves  <palves@redhat.com>
6213
6214         * utils.c (set_screen_size): When we cap the height/width sizes,
6215         tweak the corresponding command variable to show "unlimited":
6216
6217 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6218             Pedro Alves  <palves@redhat.com>
6219
6220         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6221         before calling rl_set_screen_size.
6222
6223 2019-02-27  Tom Tromey  <tromey@adacore.com>
6224
6225         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6226         define.
6227         * python/py-value.c: Remove Python 2.4 workaround.
6228         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6229         workaround.
6230         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6231         Python 2.4 workaround.
6232         * python/python-internal.h: Remove Python 2.4 comment.
6233         (Py_ssize_t): Don't define.
6234         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6235         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6236         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6237         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6238         * python/python.c (do_start_initialization): Remove Python 2.4
6239         workaround.
6240         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6241         (print_children): Remove Python 2.4 workaround.
6242         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6243         workaround.
6244         (CHARBUFFERPROC_NAME): Remove.
6245         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6246         Python 2.4 workaround.
6247
6248 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6249
6250         * NEWS: Note minimum Python version.
6251
6252 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6253
6254         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6255         code from these functions.  Remove corresponding ifdefs.  Use
6256         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6257         Remove gotos and target of gotos.
6258         (infpy_search_memory): Likewise.
6259
6260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6261
6262         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6263         (hppa_gdbarch_init): Don't register deleted functions with
6264         gdbarch.
6265
6266 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6267
6268         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6269         (h8300_unwind_sp): Delete.
6270         (h8300_dummy_id): Delete.
6271         (h8300_gdbarch_init): Don't register deleted functions with
6272         gdbarch.
6273
6274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6277         (ft32_unwind_pc): Delete.
6278         (ft32_unwind_sp): Delete.
6279         (ft32_gdbarch_init): Don't register deleted functions with
6280         gdbarch.
6281
6282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6285         (frv_unwind_pc): Delete.
6286         (frv_unwind_sp): Delete.
6287         (frv_gdbarch_init): Don't register deleted functions with
6288         gdbarch.
6289
6290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6291
6292         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6293         (riscv_unwind_pc): Delete.
6294         (riscv_unwind_sp): Delete.
6295         (riscv_gdbarch_init): Don't register deleted functions with
6296         gdbarch.
6297
6298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6299
6300         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6301         (csky_unwind_pc): Delete.
6302         (csky_unwind_sp): Delete.
6303         (csky_gdbarch_init): Don't register deleted functions with
6304         gdbarch.
6305
6306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6309         (cris_unwind_pc): Delete.
6310         (cris_unwind_sp): Delete.
6311         (cris_gdbarch_init): Don't register deleted functions with
6312         gdbarch.
6313
6314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6317         (bfin_unwind_pc): Delete.
6318         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6319
6320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6321
6322         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6323         (arm_unwind_pc): Delete.
6324         (arm_unwind_sp): Delete.
6325         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6326
6327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6328
6329         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6330         (arc_unwind_pc): Delete.
6331         (arc_unwind_sp): Delete.
6332         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6333
6334 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6335
6336         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6337         (alpha_unwind_pc): Delete.
6338         (alpha_gdbarch_init): Don't register deleted functions with
6339         gdbarch.
6340
6341 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6342
6343         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6344         (aarch64_unwind_pc): Delete.
6345         (aarch64_unwind_sp): Delete.
6346         (aarch64_gdbarch_init): Don't register deleted functions with
6347         gdbarch.
6348
6349 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6350
6351         * gdbtypes.c (type_align): Don't consider static members when
6352         computing structure alignment.
6353
6354 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6357         return 0 for other types.
6358         * arch-utils.c (default_type_align): Always return 0.
6359         * gdbarch.h: Regenerate.
6360         * gdbarch.sh (type_align): Extend comment.
6361         * gdbtypes.c (type_align): Add additional comments, always call
6362         gdbarch_type_align before applying the default rules.
6363         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6364         generic code will then apply a suitable default.
6365         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6366         types, return 0 for other types.
6367
6368 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6369
6370         * NEWS: Create a new section for the next release branch.
6371         Rename the section of the current branch, now that it has
6372         been cut.
6373
6374 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6375
6376         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6377         * version.in: Bump version to 8.3.50.DATE-git.
6378
6379 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6380
6381         * aix-thread.c (ptid_cmp): Remove unused variable.
6382         (get_signaled_thread): Likewise.
6383         (store_regs_user_thread): Likewise.
6384         (store_regs_kernel_thread): Likewise.
6385         (fetch_regs_kernel_thread): Remove shadowed variable.
6386
6387 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6388
6389         * features/riscv/32bit-cpu.xml: Add register numbers.
6390         * features/riscv/32bit-fpu.c: Regenerate.
6391         * features/riscv/32bit-fpu.xml: Add register numbers.
6392         * features/riscv/64bit-cpu.xml: Add register numbers.
6393         * features/riscv/64bit-fpu.c: Regenerate.
6394         * features/riscv/64bit-fpu.xml: Add register numbers.
6395
6396 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6397
6398         * NEWS: Mention two argument form of gdb.Value constructor.
6399         * python/py-value.c (convert_buffer_and_type_to_value): New
6400         function.
6401         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6402         Add support for handling an optional second argument.  Call
6403         convert_buffer_and_type_to_value as appropriate.
6404         * python/python-internal.h (Py_buffer_deleter): New struct.
6405         (Py_buffer_up): New typedef.
6406
6407 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6408
6409         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6410         instead of releasing ownership.
6411
6412 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6413
6414         * dwarf2read.c (open_and_init_dwp_file): Call
6415         elf_numsections instead of bfd_count_sections to initialize
6416         dwp_file->num_sections.
6417
6418 2019-02-25  Tom Tromey  <tromey@adacore.com>
6419
6420         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6421
6422 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6423
6424         * gcore.in: Add '--readnever' option when invoking GDB.
6425
6426 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6427
6428         * MAINTAINERS: Update my email address.
6429
6430 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6431
6432         * build-id.c (build_id_to_debug_bfd_1): New function.
6433         (build_id_to_debug_bfd): Look for separate debug file in
6434         sysroot.
6435
6436 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6437
6438         * gdbarch.sh: Update the copyright year range that is placed into
6439         generated files.
6440
6441 2019-02-22  Keith Seitz  <keiths@redhat.com>
6442
6443         PR symtab/23853
6444         * linespec.c (create_sals_line_offset): Search for the default
6445         symtab's filename instead of its fullname.
6446
6447 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6448
6449         * NEWS: Update style defaults.
6450
6451 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6452
6453         * main.c (captured_main_1): Disable styling in batch mode.
6454
6455 2019-02-20  Tom Tromey  <tom@tromey.com>
6456
6457         * symtab.c (symtab_symbol_info): Fix typos.
6458
6459 2019-02-20  Tom Tromey  <tromey@adacore.com>
6460
6461         * findcmd.c (_initialize_mem_search): Use upper case for
6462         metasyntactic variables.
6463
6464 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6465
6466         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6467         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6468
6469 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6470
6471         * top.h (source_file_name): Change to std::string.
6472         * top.c (source_file_name): Likewise.
6473         (command_line_input): Adjust.
6474         * cli/cli-script.c (script_from_file): Adjust.
6475
6476 2019-02-19  Tom Tromey  <tromey@adacore.com>
6477
6478         * ravenscar-thread.c
6479         (ravenscar_thread_target::update_thread_list): Don't call
6480         ada_build_task_list.
6481         * ada-lang.h (ada_build_task_list): Don't declare.
6482         * ada-tasks.c (struct ada_tasks_inferior_data)
6483         <task_list_valid_p>: Now bool.
6484         (read_known_tasks, ada_task_list_changed)
6485         (ada_tasks_invalidate_inferior_data): Update.
6486         (read_known_tasks_array): Return bool.
6487         (read_known_tasks_list): Likewise.
6488         (read_known_tasks): Return void.
6489         (ada_build_task_list): Now static.
6490
6491 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6492
6493         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6494         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6495
6496 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6497
6498         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6499         variant for ada_tasks_pspace_data_handle and
6500         ada_tasks_inferior_data_handle.
6501         (ada_tasks_pspace_data_cleanup): New function.
6502         (ada_tasks_inferior_data_cleanup): New function.
6503
6504 2019-02-17  Tom Tromey  <tom@tromey.com>
6505
6506         * macrotab.h (macro_source_fullname): Return a std::string.
6507         * macrotab.c (macro_include, check_for_redefinition)
6508         (macro_undef, macro_lookup_definition, foreach_macro)
6509         (foreach_macro_in_scope): Update.
6510         (macro_source_fullname): Return a std::string.
6511         * macrocmd.c (show_pp_source_pos): Update.
6512
6513 2019-02-17  Tom Tromey  <tom@tromey.com>
6514
6515         * macrocmd.c (show_pp_source_pos): Style the file names.
6516
6517 2019-02-17  Tom Tromey  <tom@tromey.com>
6518
6519         PR tui/24197:
6520         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6521
6522 2019-02-17  Tom Tromey  <tom@tromey.com>
6523
6524         * ada-lang.c (user_select_syms): Use filtered printing.
6525         * utils.c (wrap_style): New global.
6526         (desired_style): Remove.
6527         (emit_style_escape): Add stream parameter.
6528         (set_output_style, reset_terminal_style, prompt_for_continue):
6529         Update.
6530         (flush_wrap_buffer): Only flush gdb_stdout.
6531         (wrap_here): Set wrap_style.
6532         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6533         treat escape sequences as a character.  Change when wrap buffer is
6534         flushed.
6535         (fputs_styled): Do not set the output style when the default is
6536         requested.
6537         * ui-style.h (struct ui_file_style) <is_default>: New method.
6538         * source.c (print_source_lines_base): Emit escape sequences in one
6539         piece.
6540
6541 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6542
6543         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6544         integers and enumeration types.
6545
6546 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6547
6548         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6549         instead of lookup_symbol_in_language
6550         (do_exact_match): New function.
6551         (ada_get_symbol_name_matcher): Return do_exact_match when
6552         doing a verbatim match.
6553
6554 2019-02-15  Tom Tromey  <tromey@adacore.com>
6555
6556         * ravenscar-thread.c (ravenscar_thread_target::resume)
6557         (ravenscar_thread_target::wait): Special case wildcard requests.
6558
6559 2019-02-15  Tom Tromey  <tromey@adacore.com>
6560
6561         * ravenscar-thread.c (base_ptid): Remove.
6562         (struct ravenscar_thread_target) <close>: New method.
6563         <m_base_ptid>: New member.
6564         <update_inferior_ptid, active_task, task_is_currently_active,
6565         runtime_initialized>: Declare methods.
6566         <ravenscar_thread_target>: Add constructor.
6567         (ravenscar_thread_target::task_is_currently_active)
6568         (ravenscar_thread_target::update_inferior_ptid)
6569         (ravenscar_runtime_initialized): Rename.  Now methods.
6570         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6571         (ravenscar_thread_target::update_thread_list): Update.
6572         (ravenscar_thread_target::active_task): Now method.
6573         (ravenscar_thread_target::store_registers)
6574         (ravenscar_thread_target::prepare_to_store)
6575         (ravenscar_thread_target::prepare_to_store)
6576         (ravenscar_thread_target::mourn_inferior): Update.
6577         (ravenscar_inferior_created): Use "new" to create target.
6578         (ravenscar_thread_target::get_ada_task_ptid): Update.
6579         (_initialize_ravenscar): Don't initialize base_ptid.
6580         (ravenscar_ops): Remove global.
6581
6582 2019-02-15  Tom Tromey  <tromey@adacore.com>
6583
6584         * target.h (push_target): Declare new overload.
6585         * target.c (push_target): New overload, taking an rvalue reference.
6586         * remote.c (remote_target::open_1): Use push_target overload.
6587         * corelow.c (core_target_open): Use push_target overload.
6588
6589 2019-02-15  Tom Tromey  <tromey@adacore.com>
6590
6591         * ravenscar-thread.c (is_ravenscar_task)
6592         (ravenscar_task_is_currently_active): Return bool.
6593         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6594         (_initialize_ravenscar): Remove "(void)".
6595         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6596         Return bool.
6597
6598 2019-02-15  Tom Tromey  <tromey@adacore.com>
6599
6600         * ravenscar-thread.c (ravenscar_runtime_initializer)
6601         (has_ravenscar_runtime, get_running_thread_id)
6602         (ravenscar_thread_target::resume): Fix indentation.
6603
6604 2019-02-15  Tom Tromey  <tromey@adacore.com>
6605
6606         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6607         from ravenscar_arch_ops.
6608         (sparc_ravenscar_ops::fetch_registers)
6609         (sparc_ravenscar_ops::store_registers): Now methods.
6610         (sparc_ravenscar_prepare_to_store): Remove.
6611         (sparc_ravenscar_ops): Redefine.
6612         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6613         methods and destructor.  Remove members.
6614         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6615         (ravenscar_thread_target::store_registers)
6616         (ravenscar_thread_target::prepare_to_store): Update.
6617         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6618         Remove.
6619         (struct ppc_ravenscar_powerpc_ops): Derive from
6620         ravenscar_arch_ops.
6621         (ppc_ravenscar_powerpc_ops::fetch_registers)
6622         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6623         (ppc_ravenscar_powerpc_ops): Redefine.
6624         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6625         (ppc_ravenscar_e500_ops::fetch_registers)
6626         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6627         (ppc_ravenscar_e500_ops): Redefine.
6628         * aarch64-ravenscar-thread.c
6629         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6630         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6631         (aarch64_ravenscar_fetch_registers)
6632         (aarch64_ravenscar_store_registers): Now methods.
6633         (aarch64_ravenscar_ops): Redefine.
6634
6635 2019-02-15  Tom Tromey  <tromey@adacore.com>
6636
6637         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6638         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6639         (ravenscar_thread_target::stopped_by_watchpoint)
6640         (ravenscar_thread_target::stopped_data_address)
6641         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6642
6643 2019-02-15  Tom Tromey  <tromey@adacore.com>
6644
6645         * ravenscar-thread.c: Fix some typos.
6646
6647 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6648             Tom Tromey  <tromey@adacore.com>
6649
6650         * ada-lang.c (ada_exception_sal): Change addr_string to a
6651         std::string.
6652         (create_ada_exception_catchpoint): Update.
6653
6654 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6655             Tom Tromey  <tromey@adacore.com>
6656
6657         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6658         (bp_location_ops): Remove.
6659         (base_breakpoint_allocate_location): Update.
6660         (free_bp_location): Update.
6661         * ada-lang.c (class ada_catchpoint_location)
6662         <ada_catchpoint_location>: Remove ops parameter.
6663         (ada_catchpoint_location_dtor): Remove.
6664         (ada_catchpoint_location_ops): Remove.
6665         (allocate_location_exception): Update.
6666         * breakpoint.h (struct bp_location_ops): Remove.
6667         (class bp_location) <bp_location>: Remove bp_location_ops
6668         parameter.
6669         <~bp_location>: Add destructor.
6670         <ops>: Remove.
6671
6672 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6673             Pedro Alves  <palves@redhat.com>
6674
6675         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6676         'PATH_MAX'.
6677
6678 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6679             Samuel Thibault  <samuel.thibault@gnu.org>
6680             Thomas Schwinge  <thomas@codesourcery.com>
6681
6682         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6683         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6684
6685 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6686
6687         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6688         (check_empty): Use "const char *".
6689
6690         * gnu-nat.c (gnu_nat_target::detach): Instead of
6691         'detach_inferior (pid)' call
6692         'detach_inferior (find_inferior_pid (pid))'.
6693
6694         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6695         'nat/fork-inferior.o'.
6696         * gnu-nat.c: #include "nat/fork-inferior.h".
6697
6698         * gnu-nat.c (gnu_nat_target::detach): Instead of
6699         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6700         * gnu-nat.h: #include "inf-child.h".
6701         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6702         'i386_gnu_nat_target::fetch_registers'.
6703         (gnu_store_registers): Rename/move to
6704         'i386_gnu_nat_target::store_registers'.
6705
6706         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6707         * gnu-nat.h (mach_thread_info): New function.
6708         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6709
6710         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6711
6712 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6713
6714         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6715
6716 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6717
6718         * windows-nat.c (windows_add_thread): Add new parameter
6719         "main_thread_p" with default value set to false.  Update
6720         function documentation as well as all callers.
6721         (windows_delete_thread): Likewise.
6722         (fake_create_process): Update call to windows_add_thread.
6723         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6724         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6725         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6726         call to windows_delete_thread.
6727
6728 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6729
6730         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6731
6732 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6733
6734         * symfile.c (find_separate_debug_file): Use canonical path of
6735         sysroot with child_path instead of gdb_sysroot if it is valid.
6736
6737 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6738
6739         * symfile.c (find_separate_debug_file): Use child_path to
6740         determine if an object file is under a sysroot.
6741
6742 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6743
6744         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6745         unittests/child-path-selftests.c.
6746         * common/pathstuff.c (child_path): New function.
6747         * common/pathstuff.h (child_path): New prototype.
6748         * unittests/child-path-selftests.c: New file.
6749
6750 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6751
6752         * symfile.c (find_separate_debug_file): Look for separate debug
6753         files in debug directories under the sysroot.
6754
6755 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6756
6757         * symtab.h (struct minimal_symbol data_p): New const method.
6758         (struct minimal_symbol text_p): Likewise.
6759         * symtab.c (output_source_filename): Use file name style
6760         to print file name.
6761         (print_symbol_info): Likewise.
6762         (print_msymbol_info): Use address style to print addresses.
6763         Use function name style to print executable text symbols.
6764         (expand_symtab_containing_pc): Use data_p.
6765         (find_pc_sect_compunit_symtab): Likewise.
6766
6767 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6768
6769         * breakpoint.c (describe_other_breakpoints): Use address style
6770         to print addresses.
6771         (say_where): Likewise.
6772
6773 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6774
6775         * ada-typeprint.c (print_func_type): Print function name
6776         style to print function name.
6777         * c-typeprint.c (c_print_type_1): Likewise.
6778
6779 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6780
6781         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6782         for execve.
6783
6784 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6785
6786         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6787         type_stack.
6788
6789 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6790
6791         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6792         TYPE_CODE_REF types.
6793
6794 2019-02-08  Jim Wilson  <jimw@sifive.com>
6795
6796         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6797         (riscv_linux_fregset): New.
6798         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6799
6800 2019-02-07  Tom Tromey  <tom@tromey.com>
6801
6802         * thread.c (thread_cancel_execution_command): Update.
6803         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6804         methods.
6805         (struct thread_fsm_ops): Remove.
6806         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6807         (thread_fsm_should_stop, thread_fsm_return_value)
6808         (thread_fsm_set_finished, thread_fsm_finished_p)
6809         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6810         Don't declare.
6811         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6812         * infrun.c (clear_proceed_status_thread)
6813         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6814         (print_stop_event): Update.
6815         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6816         Add constructor.
6817         (step_command_fsm_ops): Remove.
6818         (new_step_command_fsm): Remove.
6819         (step_1): Update.
6820         (step_command_fsm::should_stop): Rename from
6821         step_command_fsm_should_stop.
6822         (step_command_fsm::clean_up): Rename from
6823         step_command_fsm_clean_up.
6824         (step_command_fsm::do_async_reply_reason): Rename from
6825         step_command_fsm_async_reply_reason.
6826         (struct until_next_fsm): Inherit from thread_fsm.  Add
6827         constructor.
6828         (until_next_fsm_ops): Remove.
6829         (new_until_next_fsm): Remove.
6830         (until_next_fsm::should_stop): Rename from
6831         until_next_fsm_should_stop.
6832         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6833         (until_next_fsm::do_async_reply_reason): Rename from
6834         until_next_fsm_async_reply_reason.
6835         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6836         constructor.  Change type of breakpoint.
6837         (finish_command_fsm_ops): Remove.
6838         (new_finish_command_fsm): Remove.
6839         (finish_command_fsm::should_stop): Rename from
6840         finish_command_fsm_should_stop.
6841         (finish_command_fsm::clean_up): Rename from
6842         finish_command_fsm_clean_up.
6843         (finish_command_fsm::return_value): Rename from
6844         finish_command_fsm_return_value.
6845         (finish_command_fsm::do_async_reply_reason): Rename from
6846         finish_command_fsm_async_reply_reason.
6847         (finish_command): Update.
6848         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6849         Add constructor.
6850         (call_thread_fsm_ops): Remove.
6851         (call_thread_fsm::call_thread_fsm): Rename from
6852         new_call_thread_fsm.
6853         (call_thread_fsm::should_stop): Rename from
6854         call_thread_fsm_should_stop.
6855         (call_thread_fsm::should_notify_stop): Rename from
6856         call_thread_fsm_should_notify_stop.
6857         (run_inferior_call, call_function_by_hand_dummy): Update.
6858         * cli/cli-interp.c (should_print_stop_to_console): Update.
6859         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6860         Add constructor.  Change type of location_breakpoint,
6861         caller_breakpoint.
6862         (until_break_fsm_ops): Remove.
6863         (new_until_break_fsm): Remove.
6864         (until_break_fsm::should_stop): Rename from
6865         until_break_fsm_should_stop.
6866         (until_break_fsm::clean_up): Rename from
6867         until_break_fsm_clean_up.
6868         (until_break_fsm::do_async_reply_reason): Rename from
6869         until_break_fsm_async_reply_reason.
6870         (until_break_command): Update.
6871         * thread-fsm.c: Remove.
6872         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6873
6874 2019-02-07  Tom Tromey  <tom@tromey.com>
6875
6876         * yy-remap.h: Add include guard.
6877         * xtensa-tdep.h: Add include guard.
6878         * xcoffread.h: Rename include guard.
6879         * varobj-iter.h: Add include guard.
6880         * tui/tui.h: Rename include guard.
6881         * tui/tui-winsource.h: Rename include guard.
6882         * tui/tui-wingeneral.h: Rename include guard.
6883         * tui/tui-windata.h: Rename include guard.
6884         * tui/tui-win.h: Rename include guard.
6885         * tui/tui-stack.h: Rename include guard.
6886         * tui/tui-source.h: Rename include guard.
6887         * tui/tui-regs.h: Rename include guard.
6888         * tui/tui-out.h: Rename include guard.
6889         * tui/tui-layout.h: Rename include guard.
6890         * tui/tui-io.h: Rename include guard.
6891         * tui/tui-hooks.h: Rename include guard.
6892         * tui/tui-file.h: Rename include guard.
6893         * tui/tui-disasm.h: Rename include guard.
6894         * tui/tui-data.h: Rename include guard.
6895         * tui/tui-command.h: Rename include guard.
6896         * tic6x-tdep.h: Add include guard.
6897         * target/waitstatus.h: Rename include guard.
6898         * target/wait.h: Rename include guard.
6899         * target/target.h: Rename include guard.
6900         * target/resume.h: Rename include guard.
6901         * target-float.h: Rename include guard.
6902         * stabsread.h: Add include guard.
6903         * rs6000-tdep.h: Add include guard.
6904         * riscv-fbsd-tdep.h: Add include guard.
6905         * regformats/regdef.h: Rename include guard.
6906         * record.h: Rename include guard.
6907         * python/python.h: Rename include guard.
6908         * python/python-internal.h: Rename include guard.
6909         * python/py-stopevent.h: Rename include guard.
6910         * python/py-ref.h: Rename include guard.
6911         * python/py-record.h: Rename include guard.
6912         * python/py-record-full.h: Rename include guard.
6913         * python/py-record-btrace.h: Rename include guard.
6914         * python/py-instruction.h: Rename include guard.
6915         * python/py-events.h: Rename include guard.
6916         * python/py-event.h: Rename include guard.
6917         * procfs.h: Add include guard.
6918         * proc-utils.h: Add include guard.
6919         * p-lang.h: Add include guard.
6920         * or1k-tdep.h: Rename include guard.
6921         * observable.h: Rename include guard.
6922         * nto-tdep.h: Rename include guard.
6923         * nat/x86-linux.h: Rename include guard.
6924         * nat/x86-linux-dregs.h: Rename include guard.
6925         * nat/x86-gcc-cpuid.h: Add include guard.
6926         * nat/x86-dregs.h: Rename include guard.
6927         * nat/x86-cpuid.h: Rename include guard.
6928         * nat/ppc-linux.h: Rename include guard.
6929         * nat/mips-linux-watch.h: Rename include guard.
6930         * nat/linux-waitpid.h: Rename include guard.
6931         * nat/linux-ptrace.h: Rename include guard.
6932         * nat/linux-procfs.h: Rename include guard.
6933         * nat/linux-osdata.h: Rename include guard.
6934         * nat/linux-nat.h: Rename include guard.
6935         * nat/linux-namespaces.h: Rename include guard.
6936         * nat/linux-btrace.h: Rename include guard.
6937         * nat/glibc_thread_db.h: Rename include guard.
6938         * nat/gdb_thread_db.h: Rename include guard.
6939         * nat/gdb_ptrace.h: Rename include guard.
6940         * nat/fork-inferior.h: Rename include guard.
6941         * nat/amd64-linux-siginfo.h: Rename include guard.
6942         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6943         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6944         * nat/aarch64-linux.h: Rename include guard.
6945         * nat/aarch64-linux-hw-point.h: Rename include guard.
6946         * mn10300-tdep.h: Add include guard.
6947         * mips-linux-tdep.h: Add include guard.
6948         * mi/mi-parse.h: Rename include guard.
6949         * mi/mi-out.h: Rename include guard.
6950         * mi/mi-main.h: Rename include guard.
6951         * mi/mi-interp.h: Rename include guard.
6952         * mi/mi-getopt.h: Rename include guard.
6953         * mi/mi-console.h: Rename include guard.
6954         * mi/mi-common.h: Rename include guard.
6955         * mi/mi-cmds.h: Rename include guard.
6956         * mi/mi-cmd-break.h: Rename include guard.
6957         * m2-lang.h: Add include guard.
6958         * location.h: Rename include guard.
6959         * linux-record.h: Rename include guard.
6960         * linux-nat.h: Add include guard.
6961         * linux-fork.h: Add include guard.
6962         * i386-darwin-tdep.h: Rename include guard.
6963         * hppa-linux-offsets.h: Add include guard.
6964         * guile/guile.h: Rename include guard.
6965         * guile/guile-internal.h: Rename include guard.
6966         * gnu-nat.h: Rename include guard.
6967         * gdb-stabs.h: Rename include guard.
6968         * frv-tdep.h: Add include guard.
6969         * f-lang.h: Add include guard.
6970         * event-loop.h: Add include guard.
6971         * darwin-nat.h: Rename include guard.
6972         * cp-abi.h: Rename include guard.
6973         * config/sparc/nm-sol2.h: Rename include guard.
6974         * config/nm-nto.h: Rename include guard.
6975         * config/nm-linux.h: Add include guard.
6976         * config/i386/nm-i386gnu.h: Rename include guard.
6977         * config/djgpp/nl_types.h: Rename include guard.
6978         * config/djgpp/langinfo.h: Rename include guard.
6979         * compile/gcc-cp-plugin.h: Add include guard.
6980         * compile/gcc-c-plugin.h: Add include guard.
6981         * compile/compile.h: Rename include guard.
6982         * compile/compile-object-run.h: Rename include guard.
6983         * compile/compile-object-load.h: Rename include guard.
6984         * compile/compile-internal.h: Rename include guard.
6985         * compile/compile-cplus.h: Rename include guard.
6986         * compile/compile-c.h: Rename include guard.
6987         * common/xml-utils.h: Rename include guard.
6988         * common/x86-xstate.h: Rename include guard.
6989         * common/version.h: Rename include guard.
6990         * common/vec.h: Rename include guard.
6991         * common/tdesc.h: Rename include guard.
6992         * common/selftest.h: Rename include guard.
6993         * common/scoped_restore.h: Rename include guard.
6994         * common/scoped_mmap.h: Rename include guard.
6995         * common/scoped_fd.h: Rename include guard.
6996         * common/safe-iterator.h: Rename include guard.
6997         * common/run-time-clock.h: Rename include guard.
6998         * common/refcounted-object.h: Rename include guard.
6999         * common/queue.h: Rename include guard.
7000         * common/ptid.h: Rename include guard.
7001         * common/print-utils.h: Rename include guard.
7002         * common/preprocessor.h: Rename include guard.
7003         * common/pathstuff.h: Rename include guard.
7004         * common/observable.h: Rename include guard.
7005         * common/netstuff.h: Rename include guard.
7006         * common/job-control.h: Rename include guard.
7007         * common/host-defs.h: Rename include guard.
7008         * common/gdb_wait.h: Rename include guard.
7009         * common/gdb_vecs.h: Rename include guard.
7010         * common/gdb_unlinker.h: Rename include guard.
7011         * common/gdb_unique_ptr.h: Rename include guard.
7012         * common/gdb_tilde_expand.h: Rename include guard.
7013         * common/gdb_sys_time.h: Rename include guard.
7014         * common/gdb_string_view.h: Rename include guard.
7015         * common/gdb_splay_tree.h: Rename include guard.
7016         * common/gdb_setjmp.h: Rename include guard.
7017         * common/gdb_ref_ptr.h: Rename include guard.
7018         * common/gdb_optional.h: Rename include guard.
7019         * common/gdb_locale.h: Rename include guard.
7020         * common/gdb_assert.h: Rename include guard.
7021         * common/filtered-iterator.h: Rename include guard.
7022         * common/filestuff.h: Rename include guard.
7023         * common/fileio.h: Rename include guard.
7024         * common/environ.h: Rename include guard.
7025         * common/common-utils.h: Rename include guard.
7026         * common/common-types.h: Rename include guard.
7027         * common/common-regcache.h: Rename include guard.
7028         * common/common-inferior.h: Rename include guard.
7029         * common/common-gdbthread.h: Rename include guard.
7030         * common/common-exceptions.h: Rename include guard.
7031         * common/common-defs.h: Rename include guard.
7032         * common/common-debug.h: Rename include guard.
7033         * common/cleanups.h: Rename include guard.
7034         * common/buffer.h: Rename include guard.
7035         * common/btrace-common.h: Rename include guard.
7036         * common/break-common.h: Rename include guard.
7037         * cli/cli-utils.h: Rename include guard.
7038         * cli/cli-style.h: Rename include guard.
7039         * cli/cli-setshow.h: Rename include guard.
7040         * cli/cli-script.h: Rename include guard.
7041         * cli/cli-interp.h: Rename include guard.
7042         * cli/cli-decode.h: Rename include guard.
7043         * cli/cli-cmds.h: Rename include guard.
7044         * charset-list.h: Add include guard.
7045         * buildsym-legacy.h: Rename include guard.
7046         * bfin-tdep.h: Add include guard.
7047         * ax.h: Rename include guard.
7048         * arm-linux-tdep.h: Add include guard.
7049         * arm-fbsd-tdep.h: Add include guard.
7050         * arch/xtensa.h: Rename include guard.
7051         * arch/tic6x.h: Add include guard.
7052         * arch/i386.h: Add include guard.
7053         * arch/arm.h: Rename include guard.
7054         * arch/arm-linux.h: Rename include guard.
7055         * arch/arm-get-next-pcs.h: Rename include guard.
7056         * arch/amd64.h: Add include guard.
7057         * arch/aarch64-insn.h: Rename include guard.
7058         * arch-utils.h: Rename include guard.
7059         * annotate.h: Add include guard.
7060         * amd64-darwin-tdep.h: Rename include guard.
7061         * aarch64-linux-tdep.h: Add include guard.
7062         * aarch64-fbsd-tdep.h: Add include guard.
7063         * aarch32-linux-nat.h: Add include guard.
7064
7065 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7066
7067         * macrotab.c (macro_define_internal): New function that
7068         factorizes macro_define_object_internal and macro_define_function
7069         code.
7070         (macro_define_object_internal): Use macro_define_internal.
7071         (macro_define_function): Likewise.
7072
7073 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7074
7075         * macrocmd.c (extract_identifier): Return
7076         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7077         callers.
7078
7079 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7080
7081         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7082
7083 2019-02-05  Tom Tromey  <tom@tromey.com>
7084
7085         * target.c (target_stack::unpush): Move assertion earlier.
7086
7087 2019-01-30  Tom Tromey  <tom@tromey.com>
7088
7089         PR python/23615:
7090         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7091         (gdbpy_parse_and_eval): Likewise.
7092         * python/python-internal.h (gdbpy_allow_threads): New class.
7093
7094 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7095
7096         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7097         (aarch64_fbsd_fpregmap): Move earlier.
7098         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7099         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7100         instead of individual calls to trad_frame_set_reg_addr.
7101         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7102         earlier.
7103         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7104         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7105         instead of individual calls to trad_frame_set_reg_addr.
7106
7107 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7108
7109         * CONTRIBUTE: Replace contribution list with wiki link.
7110
7111 2019-01-25  Tom Tromey  <tom@tromey.com>
7112
7113         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7114
7115 2019-01-25  Tom Tromey  <tom@tromey.com>
7116
7117         * xtensa-linux-nat.c: Fix common/ includes.
7118         * xml-support.h: Fix common/ includes.
7119         * xml-support.c: Fix common/ includes.
7120         * x86-linux-nat.c: Fix common/ includes.
7121         * windows-nat.c: Fix common/ includes.
7122         * varobj.h: Fix common/ includes.
7123         * varobj.c: Fix common/ includes.
7124         * value.c: Fix common/ includes.
7125         * valops.c: Fix common/ includes.
7126         * utils.c: Fix common/ includes.
7127         * unittests/xml-utils-selftests.c: Fix common/ includes.
7128         * unittests/utils-selftests.c: Fix common/ includes.
7129         * unittests/unpack-selftests.c: Fix common/ includes.
7130         * unittests/tracepoint-selftests.c: Fix common/ includes.
7131         * unittests/style-selftests.c: Fix common/ includes.
7132         * unittests/string_view-selftests.c: Fix common/ includes.
7133         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7134         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7135         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7136         * unittests/rsp-low-selftests.c: Fix common/ includes.
7137         * unittests/parse-connection-spec-selftests.c: Fix common/
7138         includes.
7139         * unittests/optional-selftests.c: Fix common/ includes.
7140         * unittests/offset-type-selftests.c: Fix common/ includes.
7141         * unittests/observable-selftests.c: Fix common/ includes.
7142         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7143         * unittests/memrange-selftests.c: Fix common/ includes.
7144         * unittests/memory-map-selftests.c: Fix common/ includes.
7145         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7146         * unittests/function-view-selftests.c: Fix common/ includes.
7147         * unittests/environ-selftests.c: Fix common/ includes.
7148         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7149         * unittests/common-utils-selftests.c: Fix common/ includes.
7150         * unittests/cli-utils-selftests.c: Fix common/ includes.
7151         * unittests/array-view-selftests.c: Fix common/ includes.
7152         * ui-file.c: Fix common/ includes.
7153         * tui/tui-io.c: Fix common/ includes.
7154         * tracepoint.h: Fix common/ includes.
7155         * tracepoint.c: Fix common/ includes.
7156         * tracefile-tfile.c: Fix common/ includes.
7157         * top.h: Fix common/ includes.
7158         * top.c: Fix common/ includes.
7159         * thread.c: Fix common/ includes.
7160         * target/waitstatus.h: Fix common/ includes.
7161         * target/waitstatus.c: Fix common/ includes.
7162         * target.h: Fix common/ includes.
7163         * target.c: Fix common/ includes.
7164         * target-memory.c: Fix common/ includes.
7165         * target-descriptions.c: Fix common/ includes.
7166         * symtab.h: Fix common/ includes.
7167         * symfile.c: Fix common/ includes.
7168         * stap-probe.c: Fix common/ includes.
7169         * spu-linux-nat.c: Fix common/ includes.
7170         * sparc-nat.c: Fix common/ includes.
7171         * source.c: Fix common/ includes.
7172         * solib.c: Fix common/ includes.
7173         * solib-target.c: Fix common/ includes.
7174         * ser-unix.c: Fix common/ includes.
7175         * ser-tcp.c: Fix common/ includes.
7176         * ser-pipe.c: Fix common/ includes.
7177         * ser-base.c: Fix common/ includes.
7178         * selftest-arch.c: Fix common/ includes.
7179         * s12z-tdep.c: Fix common/ includes.
7180         * rust-exp.y: Fix common/ includes.
7181         * rs6000-aix-tdep.c: Fix common/ includes.
7182         * riscv-tdep.c: Fix common/ includes.
7183         * remote.c: Fix common/ includes.
7184         * remote-notif.h: Fix common/ includes.
7185         * remote-fileio.h: Fix common/ includes.
7186         * remote-fileio.c: Fix common/ includes.
7187         * regcache.h: Fix common/ includes.
7188         * regcache.c: Fix common/ includes.
7189         * record-btrace.c: Fix common/ includes.
7190         * python/python.c: Fix common/ includes.
7191         * python/py-type.c: Fix common/ includes.
7192         * python/py-inferior.c: Fix common/ includes.
7193         * progspace.h: Fix common/ includes.
7194         * producer.c: Fix common/ includes.
7195         * procfs.c: Fix common/ includes.
7196         * proc-api.c: Fix common/ includes.
7197         * printcmd.c: Fix common/ includes.
7198         * ppc-linux-nat.c: Fix common/ includes.
7199         * parser-defs.h: Fix common/ includes.
7200         * osdata.c: Fix common/ includes.
7201         * obsd-nat.c: Fix common/ includes.
7202         * nat/x86-linux.c: Fix common/ includes.
7203         * nat/x86-linux-dregs.c: Fix common/ includes.
7204         * nat/x86-dregs.h: Fix common/ includes.
7205         * nat/x86-dregs.c: Fix common/ includes.
7206         * nat/ppc-linux.c: Fix common/ includes.
7207         * nat/mips-linux-watch.h: Fix common/ includes.
7208         * nat/mips-linux-watch.c: Fix common/ includes.
7209         * nat/linux-waitpid.c: Fix common/ includes.
7210         * nat/linux-ptrace.h: Fix common/ includes.
7211         * nat/linux-ptrace.c: Fix common/ includes.
7212         * nat/linux-procfs.c: Fix common/ includes.
7213         * nat/linux-personality.c: Fix common/ includes.
7214         * nat/linux-osdata.c: Fix common/ includes.
7215         * nat/linux-namespaces.c: Fix common/ includes.
7216         * nat/linux-btrace.h: Fix common/ includes.
7217         * nat/linux-btrace.c: Fix common/ includes.
7218         * nat/fork-inferior.c: Fix common/ includes.
7219         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7220         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7221         * nat/aarch64-linux.c: Fix common/ includes.
7222         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7223         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7224         * namespace.h: Fix common/ includes.
7225         * mips-linux-tdep.c: Fix common/ includes.
7226         * minsyms.c: Fix common/ includes.
7227         * mi/mi-parse.h: Fix common/ includes.
7228         * mi/mi-main.c: Fix common/ includes.
7229         * mi/mi-cmd-env.c: Fix common/ includes.
7230         * memrange.h: Fix common/ includes.
7231         * memattr.c: Fix common/ includes.
7232         * maint.h: Fix common/ includes.
7233         * maint.c: Fix common/ includes.
7234         * main.c: Fix common/ includes.
7235         * machoread.c: Fix common/ includes.
7236         * location.c: Fix common/ includes.
7237         * linux-thread-db.c: Fix common/ includes.
7238         * linux-nat.c: Fix common/ includes.
7239         * linux-fork.c: Fix common/ includes.
7240         * inline-frame.c: Fix common/ includes.
7241         * infrun.c: Fix common/ includes.
7242         * inflow.c: Fix common/ includes.
7243         * inferior.h: Fix common/ includes.
7244         * inferior.c: Fix common/ includes.
7245         * infcmd.c: Fix common/ includes.
7246         * inf-ptrace.c: Fix common/ includes.
7247         * inf-child.c: Fix common/ includes.
7248         * ia64-linux-nat.c: Fix common/ includes.
7249         * i387-tdep.c: Fix common/ includes.
7250         * i386-tdep.c: Fix common/ includes.
7251         * i386-linux-tdep.c: Fix common/ includes.
7252         * i386-linux-nat.c: Fix common/ includes.
7253         * i386-go32-tdep.c: Fix common/ includes.
7254         * i386-fbsd-tdep.c: Fix common/ includes.
7255         * i386-fbsd-nat.c: Fix common/ includes.
7256         * guile/scm-type.c: Fix common/ includes.
7257         * guile/guile.c: Fix common/ includes.
7258         * go32-nat.c: Fix common/ includes.
7259         * gnu-nat.c: Fix common/ includes.
7260         * gdbthread.h: Fix common/ includes.
7261         * gdbarch-selftests.c: Fix common/ includes.
7262         * gdb_usleep.c: Fix common/ includes.
7263         * gdb_select.h: Fix common/ includes.
7264         * gdb_bfd.c: Fix common/ includes.
7265         * gcore.c: Fix common/ includes.
7266         * fork-child.c: Fix common/ includes.
7267         * findvar.c: Fix common/ includes.
7268         * fbsd-nat.c: Fix common/ includes.
7269         * event-top.c: Fix common/ includes.
7270         * event-loop.c: Fix common/ includes.
7271         * dwarf2read.c: Fix common/ includes.
7272         * dwarf2loc.c: Fix common/ includes.
7273         * dwarf2-frame.c: Fix common/ includes.
7274         * dwarf-index-cache.c: Fix common/ includes.
7275         * dtrace-probe.c: Fix common/ includes.
7276         * disasm-selftests.c: Fix common/ includes.
7277         * defs.h: Fix common/ includes.
7278         * csky-tdep.c: Fix common/ includes.
7279         * cp-valprint.c: Fix common/ includes.
7280         * cp-support.h: Fix common/ includes.
7281         * cp-support.c: Fix common/ includes.
7282         * corelow.c: Fix common/ includes.
7283         * completer.h: Fix common/ includes.
7284         * completer.c: Fix common/ includes.
7285         * compile/compile.c: Fix common/ includes.
7286         * compile/compile-loc2c.c: Fix common/ includes.
7287         * compile/compile-cplus-types.c: Fix common/ includes.
7288         * compile/compile-cplus-symbols.c: Fix common/ includes.
7289         * command.h: Fix common/ includes.
7290         * cli/cli-dump.c: Fix common/ includes.
7291         * cli/cli-cmds.c: Fix common/ includes.
7292         * charset.c: Fix common/ includes.
7293         * build-id.c: Fix common/ includes.
7294         * btrace.h: Fix common/ includes.
7295         * btrace.c: Fix common/ includes.
7296         * breakpoint.h: Fix common/ includes.
7297         * breakpoint.c: Fix common/ includes.
7298         * ax.h:
7299         (enum agent_op): Fix common/ includes.
7300         * ax-general.c (struct aop_map): Fix common/ includes.
7301         * ax-gdb.c: Fix common/ includes.
7302         * auxv.c: Fix common/ includes.
7303         * auto-load.c: Fix common/ includes.
7304         * arm-tdep.c: Fix common/ includes.
7305         * arch/riscv.c: Fix common/ includes.
7306         * arch/ppc-linux-common.c: Fix common/ includes.
7307         * arch/i386.c: Fix common/ includes.
7308         * arch/arm.c: Fix common/ includes.
7309         * arch/arm-linux.c: Fix common/ includes.
7310         * arch/arm-get-next-pcs.c: Fix common/ includes.
7311         * arch/amd64.c: Fix common/ includes.
7312         * arch/aarch64.c: Fix common/ includes.
7313         * arch/aarch64-insn.c: Fix common/ includes.
7314         * arch-utils.c: Fix common/ includes.
7315         * amd64-windows-tdep.c: Fix common/ includes.
7316         * amd64-tdep.c: Fix common/ includes.
7317         * amd64-sol2-tdep.c: Fix common/ includes.
7318         * amd64-obsd-tdep.c: Fix common/ includes.
7319         * amd64-nbsd-tdep.c: Fix common/ includes.
7320         * amd64-linux-tdep.c: Fix common/ includes.
7321         * amd64-linux-nat.c: Fix common/ includes.
7322         * amd64-fbsd-tdep.c: Fix common/ includes.
7323         * amd64-fbsd-nat.c: Fix common/ includes.
7324         * amd64-dicos-tdep.c: Fix common/ includes.
7325         * amd64-darwin-tdep.c: Fix common/ includes.
7326         * agent.c: Fix common/ includes.
7327         * ada-lang.h: Fix common/ includes.
7328         * ada-lang.c: Fix common/ includes.
7329         * aarch64-tdep.c: Fix common/ includes.
7330
7331 2019-01-25  Tom Tromey  <tom@tromey.com>
7332
7333         * common/create-version.sh: Use common/version.h.
7334
7335 2019-01-24  Pedro Alves  <palves@redhat.com>
7336
7337         * infrun.c (signal_stop, signal_print, signal_program)
7338         (signal_catch, signal_pass): Now arrays instead of pointers.
7339         (update_signals_program_target, do_target_resume)
7340         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7341         * linux-nat.c (linux_nat_target::pass_signals)
7342         (linux_nat_target::create_inferior, linux_nat_target::attach):
7343         Adjust.
7344         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7345         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7346         * procfs.c (procfs_target::pass_signals): Adjust.
7347         * record-full.c (record_full_target::resume): Adjust.
7348         * remote.c (remote_target::pass_signals)
7349         (remote_target::program_signals): Adjust.
7350         * target-debug.h (target_debug_print_signals): Now takes a
7351         gdb::array_view as parameter.  Adjust.
7352         * target.h (target_ops) <pass_signals, program_signals>: Replace
7353         pointer and length parameters with gdb::array_view.
7354         (target_pass_signals, target_program_signals): Likewise.
7355         * target-delegates.c: Regenerate.
7356
7357 2019-01-24  Pedro Alves  <palves@redhat.com>
7358
7359         * common/forward-scope-exit.h
7360         (forward_scope_exit::forward_scope_exit): Pass arguments to
7361         m_bind_function directly, instead of creating a std::bind and
7362         copying that.
7363
7364 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7365
7366         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7367         for static members.
7368         (pass_in_v_vfp_candidate): Likewise.
7369
7370 2019-01-23  Tom Tromey  <tom@tromey.com>
7371             Pedro Alves  <palves@redhat.com>
7372
7373         * regcache.c (class regcache_invalidator): Remove.
7374         (regcache::raw_write): Use make_scope_exit.
7375
7376 2019-01-23  Tom Tromey  <tom@tromey.com>
7377
7378         * ui-out.h (class ui_out_emit_type): Update comment.
7379
7380 2019-01-23  Tom Tromey  <tom@tromey.com>
7381
7382         * infrun.c (fetch_inferior_event): Update comment.
7383
7384 2019-01-23  Tom Tromey  <tom@tromey.com>
7385             Pedro Alves  <palves@redhat.com>
7386
7387         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7388         parameter.
7389         (fetch_inferior_event): Use SCOPE_EXIT.
7390
7391
7392 2019-01-23  Tom Tromey  <tom@tromey.com>
7393             Pedro Alves  <palves@redhat.com>
7394
7395         * infrun.c (disable_thread_events): Delete.
7396         (stop_all_threads): Use SCOPE_EXIT.
7397
7398 2019-01-23  Tom Tromey  <tom@tromey.com>
7399             Pedro Alves  <palves@redhat.com>
7400
7401         * symfile.c: Include forward-scope-exit.h.
7402         (clear_symtab_users_cleanup): Replace forward declaration with
7403         a FORWARD_SCOPE_EXIT.
7404         (syms_from_objfile_1): Use the forward_scope_exit and
7405         gdb::optional instead of cleanup_function.
7406         (reread_symbols): Use the forward_scope_exit instead of
7407         cleanup_function.
7408         (clear_symtab_users_cleanup): Remove function.
7409
7410 2019-01-23  Tom Tromey  <tom@tromey.com>
7411             Pedro Alves  <palves@redhat.com>
7412
7413         * linux-nat.c: Include scope-exit.h.
7414         (cleanup_target_stop): Remove.
7415         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7416         SCOPE_EXIT.
7417
7418 2019-01-23  Tom Tromey  <tom@tromey.com>
7419             Pedro Alves  <palves@redhat.com>
7420
7421         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7422         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7423
7424 2019-01-23  Tom Tromey  <tom@tromey.com>
7425             Andrew Burgess  <andrew.burgess@embecosm.com>
7426             Pedro Alves  <palves@redhat.com>
7427
7428         * infrun.c (fetch_inferior_event): Use scope_exit.
7429         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7430         * top.c (execute_command): Use scope_exit.
7431         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7432         * utils.c (do_bpstat_clear_actions_cleanup)
7433         (make_bpstat_clear_actions_cleanup): Remove.
7434
7435 2019-01-23  Tom Tromey  <tom@tromey.com>
7436             Pedro Alves  <palves@redhat.com>
7437
7438         * infrun.c: Include "common/scope-exit.h"
7439         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7440         (wait_for_inferior): Use SCOPE_EXIT.
7441         (fetch_inferior_event): Use scope_exit.
7442
7443 2019-01-23  Tom Tromey  <tom@tromey.com>
7444             Pedro Alves  <palves@redhat.com>
7445
7446         * breakpoint.c (create_breakpoint): Remove cleanup.
7447
7448 2019-01-23  Tom Tromey  <tom@tromey.com>
7449             Andrew Burgess  <andrew.burgess@embecosm.com>
7450             Pedro Alves  <palves@redhat.com>
7451
7452 2019-01-23  Pedro Alves  <palves@redhat.com>
7453
7454         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7455
7456 2019-01-23  Pedro Alves  <palves@redhat.com>
7457             Andrew Burgess  <andrew.burgess@embecosm.com>
7458
7459         * gdbthread.h: Include "common/forward-scope-exit.h".
7460         (scoped_finish_thread_state): Redefine custom class in terms of
7461         forward_scope_exit.
7462
7463 2019-01-23  Pedro Alves  <palves@redhat.com>
7464             Andrew Burgess  <andrew.burgess@embecosm.com>
7465
7466         * common/forward-scope-exit.h: New file.
7467
7468 2019-01-23  Pedro Alves  <palves@redhat.com>
7469             Andrew Burgess  <andrew.burgess@embecosm.com>
7470             Tom Tromey  <tom@tromey.com>
7471
7472         * common/scope-exit.h: New file.
7473
7474 2019-01-23  Pedro Alves  <palves@redhat.com>
7475
7476         * common/preprocessor.h (ESC): Rename to ...
7477         (ESC_PARENS): ... this.
7478         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7479         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7480
7481 2019-01-23  Tom Tromey  <tom@tromey.com>
7482
7483         * language.h (class scoped_switch_to_sym_language_if_auto):
7484         Initialize m_lang in both cases.
7485
7486 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7487
7488         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7489         with XCNEW.
7490
7491 2019-01-22  Tom Tromey  <tom@tromey.com>
7492
7493         * corelow.c: Do not include sys/file.h.
7494
7495 2019-01-22  Tom Tromey  <tom@tromey.com>
7496
7497         * tui/tui-wingeneral.h: Include gdb_curses.h.
7498
7499 2019-01-22  Tom Tromey  <tom@tromey.com>
7500
7501         * source-cache.h (class source_cache) <get_source_lines,
7502         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7503
7504 2019-01-22  Tom Tromey  <tom@tromey.com>
7505
7506         * remote-fileio.h (struct remote_target): Declare.
7507
7508 2019-01-22  Tom Tromey  <tom@tromey.com>
7509
7510         * python/py-arch.c: Do not include py-ref.h.
7511         * python/py-bpevent.c: Do not include py-ref.h.
7512         * python/py-cmd.c: Do not include py-ref.h.
7513         * python/py-continueevent.c: Do not include py-ref.h.
7514         * python/py-event.h: Do not include py-ref.h.
7515         * python/py-evtregistry.c: Do not include py-ref.h.
7516         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7517         * python/py-frame.c: Do not include py-ref.h.
7518         * python/py-framefilter.c: Do not include py-ref.h.
7519         * python/py-function.c: Do not include py-ref.h.
7520         * python/py-infevents.c: Do not include py-ref.h.
7521         * python/py-linetable.c: Do not include py-ref.h.
7522         * python/py-objfile.c: Do not include py-ref.h.
7523         * python/py-param.c: Do not include py-ref.h.
7524         * python/py-prettyprint.c: Do not include py-ref.h.
7525         * python/py-progspace.c: Do not include py-ref.h.
7526         * python/py-symbol.c: Do not include py-ref.h.
7527         * python/py-symtab.c: Do not include py-ref.h.
7528         * python/py-type.c: Do not include py-ref.h.
7529         * python/py-unwind.c: Do not include py-ref.h.
7530         * python/py-utils.c: Do not include py-ref.h.
7531         * python/py-value.c: Do not include py-ref.h.
7532         * python/py-varobj.c: Do not include py-ref.h.
7533         * python/py-xmethods.c: Do not include py-ref.h.
7534         * python/python.c: Do not include py-ref.h.
7535         * varobj.c: Do not include py-ref.h.
7536
7537 2019-01-22  Tom Tromey  <tom@tromey.com>
7538
7539         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7540         keyword for bcache.
7541
7542 2019-01-22  Tom Tromey  <tom@tromey.com>
7543
7544         * compile/compile-cplus-types.c: Remove a comment by #include.
7545
7546 2019-01-22  Tom Tromey  <tom@tromey.com>
7547
7548         * compile/gcc-c-plugin.h: Include compile-internal.h.
7549
7550 2019-01-22  Tom Tromey  <tom@tromey.com>
7551
7552         * stabsread.c (EXTERN): Do not define.
7553         (symnum, next_symbol_text_func, processing_gcc_compilation)
7554         (within_function, global_sym_chain, global_stabs)
7555         (previous_stab_code, this_object_header_files)
7556         (n_this_object_header_files)
7557         (n_allocated_this_object_header_files): Define.
7558         * stabsread.h (EXTERN): Never define.  Use "extern".
7559
7560 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7561
7562         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7563         history_value.
7564
7565 2019-01-21  Tom Tromey  <tom@tromey.com>
7566
7567         * ui-out.c: Fix includes.
7568         * tui/tui-source.c: Fix includes.
7569         * target.c: Fix includes.
7570         * remote.c: Fix includes.
7571         * regcache.c: Fix includes.
7572         * python/py-block.c: Fix includes.
7573         * printcmd.c: Fix includes.
7574         * or1k-tdep.c: Fix includes.
7575         * mi/mi-main.c: Fix includes.
7576         * m32r-tdep.c: Fix includes.
7577         * csky-tdep.c: Fix includes.
7578         * compile/compile-cplus-types.c: Fix includes.
7579         * cli/cli-interp.c: Fix includes.
7580
7581 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7582
7583         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7584         for padding.
7585
7586 2019-01-16  Tom Tromey  <tom@tromey.com>
7587
7588         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7589         earlier.
7590         (struct objfile) <msymbols_range>: Move from top level.
7591         <msymbols>: New method.
7592         (class objfile_msymbols): Remove.
7593         * symtab.c (default_collect_symbol_completion_matches_break_on):
7594         Update.
7595         * symmisc.c (dump_msymbols): Update.
7596         * stabsread.c (scan_file_globals): Update.
7597         * objc-lang.c (info_selectors_command, info_classes_command)
7598         (find_methods): Update.
7599         * minsyms.c (find_solib_trampoline_target): Update.
7600         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7601         * coffread.c (coff_symfile_read): Update.
7602         * ada-lang.c (ada_lookup_simple_minsym)
7603         (ada_collect_symbol_completion_matches): Update.
7604
7605 2019-01-16  Tom Tromey  <tom@tromey.com>
7606
7607         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7608         type.  Remove no-argument constructor.
7609         <iterator::operator++>: Simplify.
7610         <begin>: Update.
7611         <end>: Use minimal_symbol_count.
7612
7613 2019-01-16  Tom Tromey  <tom@tromey.com>
7614
7615         * objfiles.h (struct objfile) <psymtabs>: New method.
7616         (class objfile_psymtabs): Remove.
7617         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7618         typedef.
7619         <range>: New method.
7620         (require_partial_symbols): Change return type.
7621         * psymtab.c (require_partial_symbols)
7622         (psym_expand_symtabs_matching): Update.
7623         * mdebugread.c (parse_partial_symbols): Update.
7624         * dbxread.c (dbx_end_psymtab): Update.
7625
7626 2019-01-15  Tom Tromey  <tom@tromey.com>
7627
7628         * symtab.c (lookup_objfile_from_block)
7629         (lookup_symbol_in_objfile_symtabs)
7630         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7631         (find_line_symtab, info_sources_command)
7632         (default_collect_symbol_completion_matches_break_on)
7633         (make_source_files_completion_list): Update.
7634         * symmisc.c (print_objfile_statistics, dump_objfile)
7635         (maintenance_print_symbols, maintenance_info_symtabs)
7636         (maintenance_check_symtabs, maintenance_info_line_tables):
7637         Update.
7638         * source.c (select_source_symtab)
7639         (forget_cached_source_info_for_objfile): Update.
7640         * objfiles.h (class objfile_compunits): Remove.
7641         (struct objfile) <compunits_range>: New typedef.
7642         (compunits): New method.
7643         * objfiles.c (objfile_relocate1): Update.
7644         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7645         * maint.c (count_symtabs_and_blocks): Update.
7646         * linespec.c (iterate_over_all_matching_symtabs): Update.
7647         * cp-support.c (add_symbol_overload_list_qualified): Update.
7648         * coffread.c (coff_symtab_read): Update.
7649         * ada-lang.c (add_nonlocal_symbols)
7650         (ada_collect_symbol_completion_matches)
7651         (ada_add_global_exceptions): Update.
7652
7653 2019-01-15  Tom Tromey  <tom@tromey.com>
7654
7655         * progspace.h (program_space) <objfiles_safe_range>: New
7656         typedef.
7657         <objfiles_safe>: New method.
7658         * objfiles.h (class all_objfiles_safe): Remove.
7659         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7660         * jit.c (jit_inferior_exit_hook): Update.
7661
7662 2019-01-17  Tom Tromey  <tom@tromey.com>
7663
7664         * progspace.h (program_space) <objfiles_range>: New typedef.
7665         <objfiles>: New method.
7666         <objfiles_head>: Rename from objfiles.
7667         (object_files): Update.
7668         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7669         * guile/scm-pretty-print.c
7670         (ppscm_find_pretty_printer_from_objfiles): Update.
7671         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7672         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7673         Update.
7674         * python/py-progspace.c (pspy_get_objfiles): Update.
7675         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7676         Update.
7677         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7678         (objfpy_lookup_objfile_by_build_id): Update.
7679         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7680         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7681         Update.
7682         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7683         (expand_symtab_containing_pc, lookup_objfile_from_block)
7684         (lookup_static_symbol, basic_lookup_transparent_type)
7685         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7686         (find_line_symtab, info_sources_command)
7687         (default_collect_symbol_completion_matches_break_on)
7688         (make_source_files_completion_list, find_main_name): Update.
7689         * symmisc.c (print_symbol_bcache_statistics)
7690         (print_objfile_statistics, maintenance_print_symbols)
7691         (maintenance_print_msymbols, maintenance_print_objfiles)
7692         (maintenance_info_symtabs, maintenance_check_symtabs)
7693         (maintenance_expand_symtabs, maintenance_info_line_tables):
7694         Update.
7695         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7696         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7697         (map_overlay_command, unmap_overlay_command)
7698         (simple_overlay_update, expand_symtabs_matching)
7699         (map_symbol_filenames): Update.
7700         * symfile-debug.c (set_debug_symfile): Update.
7701         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7702         Update.
7703         * source.c (select_source_symtab, forget_cached_source_info):
7704         Update.
7705         * solib.c (solib_read_symbols): Update.
7706         * solib-spu.c (append_ocl_sos): Update.
7707         * psymtab.c (maintenance_print_psymbols)
7708         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7709         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7710         * printcmd.c (info_symbol_command): Update.
7711         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7712         Update.
7713         * objfiles.h (class all_objfiles): Remove.
7714         * objfiles.c (have_partial_symbols, have_full_symbols)
7715         (have_minimal_symbols, qsort_cmp, update_section_map)
7716         (shared_objfile_contains_address_p)
7717         (default_iterate_over_objfiles_in_search_order): Update.
7718         * objc-lang.c (info_selectors_command, info_classes_command)
7719         (find_methods): Update.
7720         * minsyms.c (find_solib_trampoline_target): Update.
7721         * maint.c (maintenance_info_sections)
7722         (maintenance_translate_address, count_symtabs_and_blocks):
7723         Update.
7724         * main.c (captured_main_1): Update.
7725         * linux-thread-db.c (try_thread_db_load_from_pdir)
7726         (has_libpthread): Update.
7727         * linespec.c (iterate_over_all_matching_symtabs)
7728         (search_minsyms_for_name): Update.
7729         * jit.c (jit_find_objf_with_entry_addr): Update.
7730         * hppa-tdep.c (find_unwind_entry)
7731         (hppa_lookup_stub_minimal_symbol): Update.
7732         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7733         Update.
7734         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7735         (elf_gnu_ifunc_resolve_by_got): Update.
7736         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7737         * dwarf-index-write.c (save_gdb_index_command): Update.
7738         * cp-support.c (add_symbol_overload_list_qualified): Update.
7739         * breakpoint.c (create_overlay_event_breakpoint)
7740         (create_longjmp_master_breakpoint)
7741         (create_std_terminate_master_breakpoint)
7742         (create_exception_master_breakpoint): Update.
7743         * blockframe.c (find_pc_partial_function): Update.
7744         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7745         (ada_collect_symbol_completion_matches)
7746         (ada_add_global_exceptions): Update.
7747
7748 2019-01-17  Tom Tromey  <tom@tromey.com>
7749
7750         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7751         declare VEC.
7752         (solib_target_parse_libraries): Change return type.
7753         (library_list_start_segment, library_list_start_section)
7754         (library_list_end_library, library_list_start_library); Update.
7755         (solib_target_free_library_list): Remove.
7756         (solib_target_parse_libraries): Remove cleanup.  Change return
7757         type.
7758         (solib_target_current_sos): Update.
7759
7760 2019-01-17  Tom Tromey  <tromey@bapiya>
7761
7762         * valprint.c: Replace "the the" with "the".
7763         * symtab.c: Replace "the the" with "the".
7764         * solib.c: Replace "the the" with "the".
7765         * solib-dsbt.c: Replace "the the" with "the".
7766         * linespec.c: Replace "the the" with "the".
7767         * dwarf2loc.h: Replace "the the" with "the".
7768         * amd64-windows-tdep.c: Replace "the the" with "the".
7769         * aarch64-tdep.c: Replace "the the" with "the".
7770
7771 2019-01-16  Keith Seitz  <keiths@redhat.com>
7772
7773         PR gdb/23773
7774         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7775         <builder>: Rename to ..
7776         <m_builder>: ... this and make private.
7777         (dwarf2_cu::get_builder): New method.  Change all users of
7778         `builder' to use this method.
7779         (dwarf2_start_symtab): Move to ...
7780         (dwarf2_cu::start_symtab): ... here.  Update all callers
7781         (setup_type_unit_groups): Move to ...
7782         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7783         callers.
7784         (dwarf2_cu::reset_builder): New method.
7785         (process_full_compunit, process_full_type_unit): Use
7786         dwarf2_cu::reset_builder.
7787         (follow_die_offset): Record the ancestor CU if it is different
7788         from the followed DIE's CU.
7789         (follow_die_sig_1): Likewise.
7790
7791 2019-01-15  Tom Tromey  <tom@tromey.com>
7792
7793         * remote.c (class remote_state) <buf>: Now a char_vector.
7794         <buf_size>: Remove.
7795         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7796         parameter.
7797         (remote_target::getpkt_or_notif_sane_1)
7798         (remote_target::getpkt_sane)
7799         (remote_target::getpkt_or_notif_sane): Likewise.
7800         (class remote_target) <putpkt>: New overload.
7801         (remote_target::read_frame): Change type of "buf_p".  Remove
7802         sizeof_p parameter.
7803         (packet_ok): New overload.
7804         (packet_check_result): New overload.
7805         Update all uses.
7806
7807 2019-01-14  Tom Tromey  <tom@tromey.com>
7808
7809         * remote-notif.c (handle_notification, remote_notif_ack)
7810         (remote_notif_parse): Make "buf" const.
7811         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7812         const.
7813         (remote_notif_parse, remote_notif_ack, handle_notification):
7814         Likewise.
7815         * remote.c (remote_notif_stop_parse): Make "buf" const.
7816         (remote_target::remote_parse_stop_reply): Make "buf" const.
7817         (remote_notif_stop_ack): Make "buf" const.
7818
7819 2019-01-14  Tom Tromey  <tom@tromey.com>
7820
7821         * remote.c (remote_console_output): Make parameter const.
7822
7823 2019-01-14  Tom Tromey  <tom@tromey.com>
7824
7825         * target-debug.h (target_debug_print_signals): Constify.
7826         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7827         * procfs.c (procfs_target::pass_signals): Update.
7828         * linux-nat.c (linux_nat_target::pass_signals): Update.
7829         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7830         * target-delegates.c: Rebuild.
7831         * remote.c (remote_target::program_signals): Update.
7832         (remote_target::pass_signals): Update.
7833         * target.c (target_pass_signals): Constify argument.
7834         (target_program_signals): Likewise.
7835         * target.h (struct target_ops) <pass_signals, program_signals>:
7836         Constify argument.
7837         (target_pass_signals, target_program_signals): Constify argument.
7838
7839 2019-01-14  Tom Tromey  <tom@tromey.com>
7840
7841         PR tui/28819:
7842         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7843
7844 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7845
7846         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7847         field.
7848         * rs6000-tdep.c: Include reggroups.h.
7849         (IS_V_ALIAS_PSEUDOREG): Define.
7850         (rs6000_register_name): Return names for the "vX" aliases.
7851         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7852         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7853         aliases.  Call default_register_reggroup_p for all other
7854         pseudo-registers.
7855         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7856         New functions.
7857         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7858         Handle "vX" aliases.
7859         (v_alias_pseudo_register_collect): New function.
7860         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7861         (rs6000_gdbarch_init): Initialize "vX" aliases as
7862         pseudo-registers.  Restore registration of
7863         rs6000_pseudo_register_reggroup_p with
7864         set_tdesc_pseudo_register_reggroup_p.
7865
7866 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7867
7868         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7869         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7870         set_gdbarch_num_pseudo_regs.
7871
7872 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7873
7874         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7875         Remove arg prefixname, add do_set and do_show.
7876         Add member functions set_list and show_list.
7877         * cli/cli-style.c (class cli_style_option): Update accordingly.
7878         (style_set_list): Move to file scope.
7879         (style_show_list): Likewise.
7880         (set_style): Call help_list.
7881         (show_style): Call cmd_show_list.
7882         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7883         Update to use the new macro.
7884
7885 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7886
7887         * ada-lang.c (_initialize_ada_language): Expand the help text
7888         for the "catch exception" command.
7889
7890 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7891
7892         * symtab.c (matching_obj_sections): Initialize obj,
7893         declare it closer to its usage.
7894
7895 2019-01-10  Tom Tromey  <tom@tromey.com>
7896
7897         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7898         (basic_inf_threads_range): Remove.
7899         (inf_threads_range, inf_non_exited_threads_range)
7900         (safe_inf_threads_range): Use next_adapter.
7901
7902 2019-01-10  Keith Seitz  <keiths@redhat.com>
7903
7904         PR gdb/23712
7905         PR symtab/23010
7906         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7907         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7908
7909 2019-01-10  Keith Seitz  <keiths@redhat.com>
7910
7911         PR gdb/23712
7912         PR symtab/23010
7913         * dictionary.c (pending_to_vector): Remove.
7914         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7915         Remove _1 suffix, replacing functions of the same name.  Update
7916         all callers.
7917         (dict_create_hashed, dict_create_hashed_expandable)
7918         (dict_create_linear, dict_create_linear_expandable, dict_free)
7919         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7920         Make functions static.
7921
7922 2019-01-10  Keith Seitz  <keiths@redhat.com>
7923
7924         PR gdb/23712
7925         PR symtab/23010
7926         * dictionary.h (struct dictionary): Replace declaration with
7927         multidictionary.
7928         (dict_create_hashed, dict_create_hashed_expandable)
7929         (dict_create_linear, dict_create_linear_expandable)
7930         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7931         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7932         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7933         taking multidictionary argument.
7934         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7935         * block.h (struct block) <dict>: Change to multidictionary
7936         and rename `multidict'.
7937         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7938         symmisc.c: Update all dictionary references to multidictionary.
7939
7940 2019-01-10  Keith Seitz  <keiths@redhat.com>
7941
7942         PR gdb/23712
7943         PR symtab/23010
7944         * dictionary.c: Include unordered_map.
7945         (pending_to_vector): New function.
7946         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7947         Rewrite the non-"_1" functions to take vector instead
7948         of linked list.
7949         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7950         "new" _1 versions of the same name.
7951         (multidictionary): Define.
7952         (std::hash<enum language): New definition.
7953         (collate_pending_symbols_by_language, mdict_create_hashed)
7954         (mdict_create_hashed_expandable, mdict_create_linear)
7955         (mdict_create_linear_expandable, mdict_free)
7956         (find_language_dictionary, create_new_language_dictionary)
7957         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7958         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7959         (mdict_size, mdict_empty): New functions.
7960         * dictionary.h (mdict_iterator): Define.
7961
7962 2019-01-10  Pedro Alves  <palves@redhat.com>
7963
7964         * breakpoint.c (read_uploaded_action)
7965         (create_tracepoint_from_upload): Adjust to use
7966         gdb::unique_xmalloc_ptr.
7967         * ctf.c (ctf_write_uploaded_tp):
7968         (SET_ARRAY_FIELD): Use emplace_back.
7969         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7970         * tracefile-tfile.c (tfile_write_uploaded_tp):
7971         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7972         gdb::unique_xmalloc_ptr.
7973         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7974         at_string, cond_string, cmd_strings>: Replace char pointers
7975         with gdb::unique_xmalloc_ptr.
7976
7977 2019-01-10  Pedro Alves  <palves@redhat.com>
7978
7979         * solib-target.c (library_list_start_library): Don't xstrdup name.
7980
7981 2019-01-10  Pedro Alves  <palves@redhat.com>
7982
7983         * mdebugread.c (parse_partial_symbols): Use
7984         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7985
7986 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7987
7988         * linux-fork.c (scoped_switch_fork_info)
7989         <~scoped_switch_fork_info>: Fix incorrect variable name.
7990
7991 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7992
7993         * linux-fork.c (scoped_switch_fork_info)
7994         <scoped_switch_fork_info>: Make explicit.
7995         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7996
7997 2019-01-10  Tom Tromey  <tom@tromey.com>
7998
7999         * objfiles.h (objfile::reset_psymtabs): Update.
8000         * objfiles.c (objfile::objfile): Update.
8001         * psymtab.h (psymtab_storage::obstack): Update.
8002         (psymtab_storage::m_obstack): Use gdb::optional.
8003         (class psymtab_storage): Update comment.  Remove objfile
8004         parameter.
8005         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8006
8007 2019-01-10  Tom Tromey  <tom@tromey.com>
8008
8009         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8010         <free_psymtabs>: Now private.
8011         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8012         (allocate_psymtab): Use new method.
8013
8014 2019-01-10  Tom Tromey  <tom@tromey.com>
8015
8016         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8017         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8018         * mdebugread.c (parse_partial_symbols): Use
8019         allocate_dependencies.
8020         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8021         allocate_dependencies.
8022         (process_psymtab_comp_unit_reader)
8023         (build_type_psymtab_dependencies): Likewise.
8024         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8025
8026 2019-01-10  Tom Tromey  <tom@tromey.com>
8027
8028         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8029         PSYMBOL_SET_LANGUAGE.
8030         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8031
8032 2019-01-10  Tom Tromey  <tom@tromey.com>
8033
8034         * psymtab.h (psymtab_storage::obstack): New method.
8035         <m_obstack>: Rename from obstack; now private.
8036         * psymtab.c (psymtab_storage): Update.
8037         * dwarf2read.c (create_addrmap_from_index)
8038         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8039         Update.
8040
8041 2019-01-10  Tom Tromey  <tom@tromey.com>
8042
8043         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8044         * objfiles.h (objfile::reset_psymtabs): New method.
8045
8046 2019-01-10  Tom Tromey  <tom@tromey.com>
8047
8048         * symmisc.c (print_symbol_bcache_statistics): Update.
8049         (print_objfile_statistics): Update.
8050         * symfile.c (reread_symbols): Update.
8051         * psymtab.h (class psymtab_storage): New.
8052         * psymtab.c (psymtab_storage): New constructor.
8053         (~psymtab_storage): New destructor.
8054         (require_partial_symbols): Update.
8055         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8056         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8057         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8058         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8059         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8060         (start_psymtab_common, end_psymtab_common)
8061         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8062         (allocate_psymtab): Update.
8063         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8064         Update.
8065         (dump_psymtab_addrmap, maintenance_print_psymbols)
8066         (maintenance_check_psymtabs): Update.
8067         (class objfile_psymtabs): Move to objfiles.h.
8068         * psympriv.h (discard_psymtab): Now inline.
8069         (psymtab_discarder::psymtab_discarder): Update.
8070         (psymtab_discarder::~psymtab_discarder): Update.
8071         (ALL_OBJFILE_PSYMTABS): Rewrite.
8072         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8073         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8074         Remove fields.
8075         <partial_symtabs>: New field.
8076         (class objfile_psymtabs): Move from psymtab.h.  Update.
8077         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8078         psymbol_cache.
8079         (objfile::~objfile): Don't destroy psymbol_cache.
8080         * mdebugread.c (parse_partial_symbols): Update.
8081         * dwarf2read.c (create_addrmap_from_index)
8082         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8083         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8084         (add_partial_subprogram, dwarf2_ranges_read): Update.
8085         * dwarf-index-write.c (write_address_map)
8086         (write_one_signatured_type, recursively_write_psymbols)
8087         (class debug_names, class debug_names, write_psymtabs_to_index):
8088         Update.
8089
8090 2019-01-10  Tom Tromey  <tom@tromey.com>
8091
8092         * symtab.h (SYMBOL_SET_NAMES): Update.
8093         (symbol_set_names): Update.
8094         (MSYMBOL_SET_NAMES): Update.
8095         * symtab.c (symbol_set_names): Change argument to be an
8096         objfile_per_bfd_storage.
8097         * psymtab.c (add_psymbol_to_bcache): Update.
8098         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8099
8100 2019-01-10  Tom Tromey  <tom@tromey.com>
8101
8102         * symtab.c (create_demangled_names_hash): Change argument to be an
8103         objfile_per_bfd_storage.
8104         (symbol_set_names): Update.
8105
8106 2019-01-10  Tom Tromey  <tom@tromey.com>
8107
8108         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8109         init_psymbol_list.
8110         * psymtab.c (init_psymbol_list): Do nothing if already called.
8111         * psympriv.h (init_psymbol_list): Add comment.
8112         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8113         init_psymbol_list.
8114         * dbxread.c (dbx_symfile_read): Unconditionally call
8115         init_psymbol_list.
8116
8117 2019-01-10  Tom Tromey  <tom@tromey.com>
8118
8119         * xcoffread.c (scan_xcoff_symtab): Update.
8120         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8121         "where".
8122         * mdebugread.c (parse_partial_symbols)
8123         (handle_psymbol_enumerators): Update.
8124         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8125         * dbxread.c (read_dbx_symtab): Update.
8126         * psympriv.h (psymbol_placement): New enum.
8127         (add_psymbol_to_list): Update.
8128
8129 2019-01-10  Tom Tromey  <tom@tromey.com>
8130
8131         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8132         static_psymbols parameters.
8133         (scan_xcoff_symtab): Update.
8134         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8135         static_psymbols parameters.
8136         * psympriv.h (start_psymtab_common): Update.
8137         * mdebugread.c (parse_partial_symbols): Update.
8138         * dwarf2read.c (create_partial_symtab): Update.
8139         * dbxread.c (read_dbx_symtab): Update.
8140         (start_psymtab): Remove global_psymbols and static_psymbols
8141         parameters.
8142
8143 2019-01-10  Tom Tromey  <tom@tromey.com>
8144
8145         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8146         * psymtab.c (allocate_psymtab): Add comment.
8147         * psympriv.h (allocate_psymtab): Add comment.
8148         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8149         initializations.
8150         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8151
8152 2019-01-10  Tom Tromey  <tom@tromey.com>
8153
8154         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8155         Don't declare.
8156         * mipsread.c: Include mdebugread.h.
8157         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8158         Declare.
8159         * elfread.c: Include mdebugread.h.
8160
8161 2019-01-09  Tom Tromey  <tom@tromey.com>
8162
8163         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8164         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8165         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8166         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8167         (psym_lookup_symbol, psym_find_last_source_symtab)
8168         (psym_forget_cached_source_info, psym_print_stats)
8169         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8170         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8171         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8172         (psym_find_compunit_symtab_by_address)
8173         (maintenance_print_psymbols, maintenance_info_psymtabs)
8174         (maintenance_check_psymtabs): Use ranged for.
8175         * psymtab.h (class objfile_psymtabs): New.
8176         (require_partial_symbols): Return objfile_psymtabs.
8177         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8178
8179 2019-01-09  Tom Tromey  <tom@tromey.com>
8180
8181         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8182         (find_pc_mapped_section, list_overlays_command)
8183         (map_overlay_command, unmap_overlay_command)
8184         (simple_overlay_update): Use all_objfiles.
8185         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8186         * printcmd.c (info_symbol_command): Use all_objfiles.
8187         * objfiles.h (ALL_OBJSECTIONS): Remove.
8188         * maint.c (maintenance_translate_address): Use all_objfiles.
8189         * gcore.c (gcore_create_callback): Use all_objfiles.
8190         (objfile_find_memory_regions): Likewise.
8191
8192 2019-01-09  Tom Tromey  <tom@tromey.com>
8193
8194         * symtab.c (find_line_symtab, info_sources_command)
8195         (make_source_files_completion_list): Use objfile_compunits.
8196         * source.c (select_source_symtab): Use objfile_compunits.
8197         * objfiles.h (struct objfile): Update comment.
8198         (ALL_OBJFILES): Remove.
8199         (ALL_FILETABS): Remove.
8200         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8201         objfile_compunits.
8202
8203 2019-01-09  Tom Tromey  <tom@tromey.com>
8204
8205         * symmisc.c (print_objfile_statistics, dump_objfile)
8206         (maintenance_print_symbols): Use compunit_filetabs.
8207         * source.c (forget_cached_source_info_for_objfile): Use
8208         compunit_filetabs.
8209         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8210         (ALL_FILETABS): Use compunit_filetabs.
8211         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8212         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8213
8214 2019-01-09  Tom Tromey  <tom@tromey.com>
8215
8216         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8217         (compunit_filetabs): New.
8218         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8219         compunit_filetabs.
8220         (info_sources_command, make_source_files_completion_list): Remove
8221         declaration.
8222         * symmisc.c (print_objfile_statistics, dump_objfile)
8223         (maintenance_print_symbols): Remove declaration.
8224         (maintenance_info_symtabs): Use compunit_filetabs.
8225         (maintenance_info_line_tables): Likewise.
8226         * source.c (select_source_symtab): Change local variable name.
8227         (forget_cached_source_info_for_objfile): Remove declaration.
8228         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8229         * objfiles.c (objfile_relocate1): Remove declaration.
8230         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8231         declaration.
8232         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8233         * coffread.c (coff_symtab_read): Remove declaration.
8234         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8235         compunit_filetabs.
8236
8237 2019-01-09  Tom Tromey  <tom@tromey.com>
8238
8239         * symtab.c (lookup_objfile_from_block)
8240         (find_pc_sect_compunit_symtab, search_symbols)
8241         (default_collect_symbol_completion_matches_break_on): Use
8242         objfile_compunits.
8243         * objfiles.h (ALL_COMPUNITS): Remove.
8244         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8245         * cp-support.c (add_symbol_overload_list_qualified): Use
8246         objfile_compunits.
8247         * ada-lang.c (ada_collect_symbol_completion_matches)
8248         (ada_add_global_exceptions): Use objfile_compunits.
8249
8250 2019-01-09  Tom Tromey  <tom@tromey.com>
8251
8252         * source.c (select_source_symtab)
8253         (forget_cached_source_info_for_objfile): Remove declaration.
8254         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8255         declaration.
8256         * maint.c (count_symtabs_and_blocks): Remove declaration.
8257         * cp-support.c (add_symbol_overload_list_qualified): Remove
8258         declaration.
8259         * coffread.c (coff_symtab_read): Remove declaration.
8260         * symtab.c (lookup_symbol_in_objfile_symtabs)
8261         (basic_lookup_transparent_type_1): Use objfile_compunits.
8262         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8263         (info_sources_command, search_symbols)
8264         (default_collect_symbol_completion_matches_break_on)
8265         (make_source_files_completion_list): Remove declaration.
8266         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8267         (ada_collect_symbol_completion_matches)
8268         (ada_add_global_exceptions): Remove declaration.
8269         * linespec.c (iterate_over_all_matching_symtabs): Use
8270         objfile_compunits.
8271         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8272         (class objfile_compunits): New.
8273         (ALL_COMPUNITS): Use objfile_compunits.
8274         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8275         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8276         objfile_compunits.
8277         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8278
8279 2019-01-09  Tom Tromey  <tom@tromey.com>
8280
8281         * symtab.c (search_symbols)
8282         (default_collect_symbol_completion_matches_break_on): Use
8283         objfile_msymbols.
8284         * ada-lang.c (ada_lookup_simple_minsym)
8285         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8286         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8287         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8288         objfile_msymbols.
8289         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8290         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8291         * objc-lang.c (find_methods): Use objfile_msymbols.
8292         (info_selectors_command, info_classes_command): Likewise.
8293         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8294         * objfiles.h (class objfile_msymbols): New.
8295         (ALL_OBJFILE_MSYMBOLS): Remove.
8296         (ALL_MSYMBOLS): Remove.
8297
8298 2019-01-09  Tom Tromey  <tom@tromey.com>
8299
8300         * common/next-iterator.h (next_adapter): Add Iterator template
8301         parameter.
8302         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8303         (class all_objfiles_safe): New.
8304         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8305         * objfiles.c (put_objfile_before): Update comment.
8306         (add_separate_debug_objfile): Likewise.
8307         (free_all_objfiles): Use all_objfiles_safe.
8308         (objfile_purge_solibs): Likewise.
8309
8310 2019-01-09  Tom Tromey  <tom@tromey.com>
8311
8312         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8313         (expand_symtab_containing_pc, lookup_static_symbol)
8314         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8315         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8316         all_objfiles.
8317         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8318         * breakpoint.c (create_overlay_event_breakpoint)
8319         (create_longjmp_master_breakpoint)
8320         (create_std_terminate_master_breakpoint)
8321         (create_exception_master_breakpoint): Use all_objfiles.
8322         * linux-thread-db.c (try_thread_db_load_from_pdir)
8323         (has_libpthread): Use all_objfiles.
8324         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8325         * linespec.c (iterate_over_all_matching_symtabs)
8326         (search_minsyms_for_name): Use all_objfiles.
8327         * maint.c (maintenance_info_sections): Use all_objfiles.
8328         * main.c (captured_main_1): Use all_objfiles.
8329         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8330         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8331         * guile/scm-pretty-print.c
8332         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8333         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8334         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8335         (maintenance_print_msymbols): Use all_objfiles.
8336         * source.c (select_source_symtab): Use all_objfiles.
8337         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8338         * symfile.c (remove_symbol_file_command)
8339         (expand_symtabs_matching, map_symbol_filenames): Use
8340         all_objfiles.
8341         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8342         all_objfiles.
8343         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8344         * objc-lang.c (find_methods): Use all_objfiles.
8345         * objfiles.c (have_partial_symbols, have_full_symbols)
8346         (have_minimal_symbols, qsort_cmp)
8347         (default_iterate_over_objfiles_in_search_order): Use
8348         all_objfiles.
8349         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8350         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8351         (maintenance_check_psymtabs): Use all_objfiles.
8352         (ALL_PSYMTABS): Remove.
8353         * compile/compile-object-run.c (do_module_cleanup): Use
8354         all_objfiles.
8355         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8356         * cp-support.c (add_symbol_overload_list_qualified): Use
8357         all_objfiles.
8358         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8359         Use all_objfiles.
8360         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8361         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8362         all_objfiles.
8363         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8364         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8365         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8366         Uses all_objfiles.
8367         * solib.c (solib_read_symbols): Use all_objfiles
8368
8369 2019-01-09  Tom Tromey  <tom@tromey.com>
8370
8371         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8372         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8373         all_objfiles.
8374         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8375         * symmisc.c (print_symbol_bcache_statistics)
8376         (print_objfile_statistics, maintenance_print_objfiles)
8377         (maintenance_info_symtabs, maintenance_check_symtabs)
8378         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8379         all_objfiles.
8380         * source.c (forget_cached_source_info): Use all_objfiles.
8381         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8382         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8383         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8384         * objfiles.c (update_section_map): Use all_objfiles.
8385         (shared_objfile_contains_address_p): Likewise.
8386         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8387         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8388
8389 2019-01-09  Tom Tromey  <tom@tromey.com>
8390
8391         * common/next-iterator.h: New file.
8392         * objfiles.h (class all_objfiles): New.
8393         (struct objfile_iterator): New.
8394
8395 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8396
8397         * NEWS: Move the description of the changed "frame", "select-frame",
8398          and "info frame" commands to the Changed commands section.
8399
8400 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8401
8402         * gdbtypes.c (check_stub_method_group): Remove handling of old
8403         mangling schemes.
8404         * linespec.c (find_methods): Likewise.
8405         * stabsread.c (read_member_functions): Likewise.
8406         * valops.c (search_struct_method): Likewise.
8407         (value_struct_elt_for_reference): Likewise.
8408         * NEWS: Mention this change.
8409
8410 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8411
8412         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8413         print_source_lines.
8414         * source.c (print_source_lines_base): Update line number check.
8415         (print_source_lines): New function.
8416         (source_lines_range::source_lines_range): New function.
8417         * source.h (class source_lines_range): New class.
8418         (print_source_lines): New declaration.
8419
8420 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8421
8422         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8423
8424 2019-01-08  Tom Tromey  <tom@tromey.com>
8425             Simon Marchi  <simon.marchi@ericsson.com>
8426
8427         PR gdb/24060
8428         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8429         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8430         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8431         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8432         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8433         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8434
8435 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8436
8437         * source.c (select_source_symtab): Move header comment to
8438         declaration in source.h.
8439         (forget_cached_source_info_for_objfile): Likewise.
8440         (forget_cached_source_info): Likewise.
8441         (identify_source_line): Likewise.
8442         * source.h (identify_source_line): Move declaration from symtab.h
8443         and add comment from source.c
8444         (print_source_lines): Likewise.
8445         (forget_cached_source_info_for_objfile): Likewise.
8446         (forget_cached_source_info): Likewise.
8447         (select_source_symtab): Likewise.
8448         (enum print_source_lines_flag): Move definition from symtab.h.
8449         * symtab.h (identify_source_line): Move declaration to source.h.
8450         (print_source_lines): Likewise.
8451         (forget_cached_source_info_for_objfile): Likewise.
8452         (forget_cached_source_info): Likewise.
8453         (select_source_symtab): Likewise.
8454         (enum print_source_lines_flag): Move definition to source.h.
8455         * tui/tui-hooks.c: Add 'source.h' include.
8456
8457 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8458
8459         * source.c (print_source_lines_base): Handle requests to print
8460         reverse line number sequences, and guard against empty lines
8461         string.
8462
8463 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8464
8465         * source.c (print_source_lines_base): Fix skip of '\r' if next
8466         character is '\n'.
8467
8468 2019-01-06  Tom Tromey  <tom@tromey.com>
8469
8470         * c-exp.y (struct c_parse_state) <macro_original_text,
8471         expansion_obstack>: New member.
8472         (macro_original_text, expansion_obstack): Remove globals.
8473         (scan_macro_expansion, scanning_macro_expansion)
8474         (finished_macro_expansion): Update.
8475         (scan_macro_cleanup): Remove.
8476         (yylex, c_parse): Update.
8477
8478 2019-01-06  Tom Tromey  <tom@tromey.com>
8479
8480         * c-exp.y (struct c_parse_state) <strings>: New member.
8481         (operator_stoken): Update.
8482
8483 2019-01-06  Tom Tromey  <tom@tromey.com>
8484
8485         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8486         (union type_stack_elt) <typelist_val>: Now a pointer to
8487         std::vector.
8488         (type_stack_cleanup): Don't declare.
8489         (push_typelist): Update.
8490         * parse.c (pop_typelist): Return a std::vector.
8491         (push_typelist): Take a std::vector.
8492         (follow_types): Update.  Do not free args.
8493         (type_stack_cleanup): Remove.
8494         * c-exp.y (struct c_parse_state): New.
8495         (cpstate): New global.
8496         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8497         (nonempty_typelist): Update.
8498         (func_mod): Create a new vector.
8499         (c_parse): Create a c_parse_state.
8500         (check_parameter_typelist): Do not delete params.
8501         (function_method): Update.  Do not delete type_list.
8502
8503 2019-01-06  Tom Tromey  <tom@tromey.com>
8504
8505         PR gdb/28155:
8506         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8507         check_typedef.
8508         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8509         (print_return_value): Likewise.
8510
8511 2019-01-05  Tom Tromey  <tom@tromey.com>
8512
8513         * contrib/cleanup_check.py: Remove.
8514         * contrib/gcc-with-excheck: Remove.
8515         * contrib/exsummary.py: Remove.
8516         * contrib/excheck.py: Remove.
8517
8518 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8519
8520         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8521         NULL. Initialize tpprev to NULL instead of assigning it
8522         to NULL on the next statement.
8523         * windows-nat.c (windows_delete_thread): Remove check for
8524         main_thread_id before printing thread exit notifications.
8525         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8526         Remove thread ID check against main_thread_id.
8527         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8528         windows_delete_thread.
8529         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8530
8531 2019-01-04  Tom Tromey  <tom@tromey.com>
8532
8533         * compile/compile.c (_initialize_compile): Use upper case for
8534         metasyntactic variables.
8535         * symmisc.c (_initialize_symmisc): Use upper case for
8536         metasyntactic variables.
8537         * psymtab.c (_initialize_psymtab): Use upper case for
8538         metasyntactic variables.
8539         * demangle.c (demangle_command): Use upper case for metasyntactic
8540         variables.
8541         (_initialize_demangler): Likewise.
8542         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8543         variables.
8544
8545 2019-01-03  Tom Tromey  <tom@tromey.com>
8546
8547         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8548
8549 2019-01-03  Tom Tromey  <tom@tromey.com>
8550
8551         * python/py-symtab.c (salpy_str): Update.
8552         (struct salpy_sal_object) <symtab>: Now a PyObject.
8553         (salpy_dealloc): Update.
8554         (del_objfile_sal): Use gdbpy_ref.
8555
8556 2019-01-03  Tom Tromey  <tom@tromey.com>
8557
8558         * python/py-type.c (convert_field): Use new_reference.  Return
8559         gdbpy_ref.
8560         (make_fielditem): Return gdbpy_ref.
8561         (typy_fields): Update.
8562         (typy_getitem): Update.
8563         (field_name): Return gdbpy_ref.  Use new_reference.
8564         (typy_iterator_iternext): Update.
8565
8566 2019-01-03  Tom Tromey  <tom@tromey.com>
8567
8568         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8569
8570 2019-01-03  Tom Tromey  <tom@tromey.com>
8571
8572         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8573         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8574         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8575         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8576         (pspy_set_type_printers): Likewise.
8577         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8578         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8579         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8580         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8581         (objfpy_set_type_printers): Likewise.
8582
8583 2019-01-03  Tom Tromey  <tom@tromey.com>
8584
8585         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8586         (gdbpy_print_stack): Use gdbpy_err_fetch.
8587         * python/python-internal.h (class gdbpy_err_fetch): New class.
8588         (class gdbpy_enter) <m_error_type, m_error_value,
8589         m_error_traceback>: Remove.
8590         <m_error>: New member.
8591         (gdbpy_exception_to_string): Don't declare.
8592         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8593         * python/py-value.c (convert_value_from_python): Use
8594         gdbpy_err_fetch.
8595         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8596         gdbpy_exception_to_string.
8597         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8598         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8599         gdbpy_err_fetch.
8600
8601 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8602
8603         * linux-nat.c (delete_lwp_cleanup): Delete.
8604         (struct lwp_deleter): New struct.
8605         (lwp_info_up): New typedef.
8606         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8607         lwp_info_up.
8608
8609 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8610
8611         * linux-fork.c (class scoped_switch_fork_info): New class.
8612         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8613
8614 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8615
8616         * valops.c (find_overload_match): Remove use of null_cleanup, and
8617         calls to do_cleanups.
8618
8619 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8620
8621         * compile/compile-cplus-types.c
8622         (compile_cplus_instance::decl_name): Handle changes to
8623         cp_func_name.
8624         * cp-support.c (cp_func_name): Update header comment, update
8625         return type.
8626         * cp-support.h (cp_func_name): Update return type in declaration.
8627         * valops.c (find_overload_match): Move temp_func local to top
8628         level of function and change its type.  Use temp_func to hold and
8629         delete temporary string obtained from cp_func_name.
8630
8631 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8632
8633         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8634         gdb::char_vector, remove cleanup, and update uses of `msg`.
8635
8636 2019-01-03  Jim Wilson  <jimw@sifive.com>
8637
8638         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8639
8640 2019-01-02  Tom Tromey  <tom@tromey.com>
8641
8642         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8643         (tdesc_parse_xml): Remove cleanups.
8644         * target-descriptions.h (make_cleanup_free_target_description):
8645         Don't declare.
8646         (target_desc_deleter): New struct.
8647         (target_desc_up): New typedef.
8648         * target-descriptions.c (target_desc_deleter::operator()): Rename
8649         from free_target_description.
8650         (make_cleanup_free_target_description): Remove.
8651
8652 2019-01-02  Tom Tromey  <tom@tromey.com>
8653
8654         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8655         constructor, destructor.
8656         (linespec_parser): Remove typedef.
8657         (~linespec_parser): Rename from linespec_parser_delete.
8658         (linespec_lex_to_end, linespec_complete_label)
8659         (linespec_complete): Update.
8660         (decode_line_full): Remove cleanups.
8661         (decode_line_1): Update.
8662
8663 2019-01-02  Tom Tromey  <tom@tromey.com>
8664
8665         * python/python-internal.h (inferior_to_inferior_object): Change
8666         return type.
8667         * python/py-exitedevent.c (create_exited_event_object): Update.
8668         * python/py-inferior.c (inferior_to_inferior_object): Return
8669         gdbpy_ref.
8670         (python_new_inferior, python_inferior_deleted)
8671         (thread_to_thread_object, delete_thread_object)
8672         (build_inferior_list, gdbpy_selected_inferior): Update.
8673         * python/py-infthread.c (create_thread_object): Update.  Also fail
8674         if inferior_to_inferior_object fails.
8675
8676 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8677
8678         * inferior.h (class inferior) <displaced_step_state>: New field.
8679         * infrun.h (struct displaced_step_state): Move here from
8680         infrun.c.  Initialize fields, add constructor.
8681         <inf>: Remove field.
8682         <reset>: New method.
8683         * infrun.c (struct displaced_step_inferior_state): Move to
8684         infrun.h.
8685         (displaced_step_inferior_states): Remove.
8686         (get_displaced_stepping_state): Adust.
8687         (displaced_step_in_progress_any_inferior): Adjust.
8688         (displaced_step_in_progress_thread): Adjust.
8689         (displaced_step_in_progress): Adjust.
8690         (add_displaced_stepping_state): Remove.
8691         (get_displaced_step_closure_by_addr): Adjust.
8692         (remove_displaced_stepping_state): Remove.
8693         (infrun_inferior_exit): Call displaced_step_state.reset.
8694         (use_displaced_stepping): Don't check for NULL.
8695         (displaced_step_prepare_throw): Call
8696         get_displaced_stepping_state.
8697         (displaced_step_fixup): Don't check for NULL.
8698         (prepare_for_detach): Don't check for NULL.
8699
8700 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8701
8702         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8703          in case of call that did not complete.
8704
8705 2019-01-02  Andrey Utkin  <autkin@undo.io>
8706
8707         * symfile.c (find_separate_debug_file): Fix search of debug files for
8708         remote debuggee.
8709
8710 2019-01-02  Tom Tromey  <tom@tromey.com>
8711
8712         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8713         indentation.
8714         * python/py-frame.c (frapy_older): Remove cast.
8715         (frapy_newer): Likewise.
8716         * python/py-breakpoint.c (local_setattro): Remove cast.
8717         * python/py-arch.c (archpy_name): Remove local variable.
8718         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8719
8720 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8721
8722         * unittests/basic_string_view/element_access/char/empty.cc:
8723         Fix year range in copyright header.
8724
8725 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8726
8727         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8728         Delete.
8729         <operator==>: Update with for removed field.
8730         <hash>: Likewise.
8731         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8732         <isa_features>: ...this.
8733         <abi_features>: New field.
8734         (riscv_isa_flen): Update comment.
8735         (riscv_abi_xlen): New declaration.
8736         (riscv_abi_flen): New declaration.
8737         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8738         isa_features.
8739         (riscv_abi_xlen): New function.
8740         (riscv_isa_flen): Update to get answer from isa_features.
8741         (riscv_abi_flen): New function.
8742         (riscv_has_fp_abi): Update to get answer from abi_features.
8743         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8744         xlen and flen.
8745         (riscv_call_info) <xlen, flen>: Update comment.
8746         (riscv_call_arg_struct): Remove invalid assertions
8747         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8748         is removed.
8749         (riscv_gdbarch_init): Gather isa features and abi features
8750         separately, ensure both match on the gdbarch when reusing an old
8751         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8752         a target with 64-bit float hardware.
8753
8754 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8755
8756         * source.c (search_command_helper): Stop reverse search
8757         when line 1 has been searched.
8758
8759 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8760
8761         * record-full.c (record_full_base_target::close): Rewrite
8762         record_full_core_buf_list free logic.
8763
8764 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8765
8766         * break-catch-syscall.c (print_one_catch_syscall): xfree
8767         the last text.
8768
8769 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8770
8771         * top.c (print_gdb_version): Update Copyright year in version
8772         message.
8773
8774 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8775
8776         Update copyright year range in all GDB files.
8777
8778 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8779
8780         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8781
8782 For older changes see ChangeLog-2018.
8783 \f
8784 Local Variables:
8785 mode: change-log
8786 left-margin: 8
8787 fill-column: 74
8788 version-control: never
8789 coding: utf-8
8790 End:
8791