gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * typeprint.c (print_offset_data::update): Print the bit offset,
   4         not the number of bits remaining.
   5
   6 2019-05-08  Tom Tromey  <tromey@adacore.com>
   7
   8         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
   9         padding at end of comment.
  10
  11 2019-05-08  Tom Tromey  <tromey@adacore.com>
  12
  13         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
  14         Compare main types.
  15
  16 2019-05-06  Tom Tromey  <tom@tromey.com>
  17
  18         * common/scoped_mmap.c: Include common-defs.h.
  19         * common/scoped_mmap.h: Don't include config.h.
  20
  21 2019-05-04  Tom Tromey  <tom@tromey.com>
  22
  23         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
  24         (struct aarch64_call_info): Add initializers.
  25         <si>: Now a std::vector.
  26         (pass_on_stack, aarch64_push_dummy_call): Update.
  27
  28 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
  29             Tom Tromey  <tom@tromey.com>
  30
  31         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  32         (ppc_threads): Now a std::vector.  Now static.
  33         (hwdebug_find_thread_points_by_tid)
  34         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
  35         Update.
  36
  37 2019-05-04  Tom Tromey  <tom@tromey.com>
  38
  39         * arc-tdep.c (arc_tdesc_init): Return bool.
  40
  41 2019-05-04  Tom Tromey  <tom@tromey.com>
  42
  43         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
  44         Use gdb_assert_not_reached.
  45
  46 2019-05-04  Tom Tromey  <tom@tromey.com>
  47
  48         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
  49         "false".
  50
  51 2019-05-04  Tom Tromey  <tom@tromey.com>
  52
  53         * arc-tdep.c (arc_tdesc_init): Use bool.
  54
  55 2019-05-04  Tom Tromey  <tom@tromey.com>
  56
  57         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  58
  59 2019-05-04  Tom Tromey  <tom@tromey.com>
  60
  61         * cli/cli-cmds.c (valid_command_p): Return bool.
  62
  63 2019-05-04  Tom Tromey  <tom@tromey.com>
  64
  65         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  66         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  67
  68 2019-05-04  Raul Tambre  <raul@tambre.ee>
  69
  70         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  71         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  72         operator for comparison.
  73
  74 2019-05-04  Tom Tromey  <tom@tromey.com>
  75
  76         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  77         (lookup_partial_symbol, print_partial_symbols)
  78         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  79         (psymbol_compare): Update.
  80         (add_psymbol_to_bcache): Clear the entire psymbol.
  81         (maintenance_check_psymtabs): Update.
  82         * psympriv.h (struct partial_symbol): Don't derive from
  83         general_symbol_info.
  84         <obj_section, unrelocated_address, address,
  85         set_unrelocated_address>: Update.
  86         <ginfo>: New member.
  87         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  88         (debug_names::write_psymbols): Update.
  89
  90 2019-05-04  Tom de Vries  <tdevries@suse.de>
  91
  92         * contrib/cc-with-tweaks.sh: Support -n arg.
  93
  94 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  95
  96         * corelow.c (core_target::detach): Ensure frame cache and
  97         register caches are cleared.
  98         inferior.c (exit_inferior_1): Likewise.
  99
 100 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 101             Tom Tromey  <tom@tromey.com>
 102
 103         * dictionary.c (collate_pending_symbols_by_language): Remove
 104         "struct" from foreach.
 105         * symtab.c (lookup_global_symbol_from_objfile)
 106         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 107         foreach.
 108         * ser-tcp.c (net_open): Remove "struct" from foreach.
 109         * objfiles.c (objfile_relocate, objfile_rebase)
 110         (objfile_has_symbols): Remove "struct" from foreach.
 111         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 112         from foreach.
 113         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 114         foreach.
 115         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 116         "struct" from foreach.
 117         * ada-lang.c (create_excep_cond_exprs)
 118         (ada_exception_catchpoint_cond_string): Remove "struct" from
 119         foreach.
 120
 121 2019-05-03  Tom Tromey  <tromey@adacore.com>
 122
 123         * ada-exp.y (convert_char_literal): Check suffix of each
 124         enumerator.
 125
 126 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 127
 128         PR ada/21406:
 129         * ada-exp.y (yywrap): Don't define.
 130         * ada-lex.l (%option): Add noyywrap
 131         (yywrap): Remove.
 132
 133 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 134
 135         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 136         _WIN32_WINNT to the XP level, unless already defined to a higher
 137         level.
 138
 139         * unittests/parse-connection-spec-selftests.c:
 140         * ser-tcp.c:
 141         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 142         override.
 143
 144         * symfile.c (find_separate_debug_file): Remove colon from the
 145         drive spec of DOS/Windows file names of the target, so that the
 146         file name produced from DEBUGDIR and the target's directory will
 147         be valid on DOS/Windows systems.
 148
 149 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 150
 151         * rust-lang.c (val_print_struct): Handle printing structures
 152         containing strings.
 153
 154 2019-05-02  Tom Tromey  <tromey@adacore.com>
 155
 156         * valarith.c (_initialize_valarith): Remove.
 157
 158 2019-05-01  Tom Tromey  <tromey@adacore.com>
 159
 160         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 161         bitfields.
 162
 163 2019-05-01  Tom Tromey  <tromey@adacore.com>
 164
 165         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 166         for big-endian copies.
 167
 168 2019-04-30  Ali Tamur  <tamur@google.com>
 169         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 170         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 171         (read_3_bytes): New function.
 172
 173 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 174
 175         * windows-nat.c (main_thread_id): Delete.
 176         (handle_output_debug_string): Replace main_thread_id by
 177         current_event.dwThreadId.
 178         (fake_create_process): Likewise.
 179         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 180         Do not set main_thread_id.
 181         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 182         current_event.dwThreadId.
 183         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 184
 185 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 186
 187         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 188         Use current_event.dwThreadId instead of main_thread_id.
 189
 190 2019-04-30  Tom Tromey  <tromey@adacore.com>
 191
 192         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 193         (create_excep_cond_exprs): Iterate over program spaces.
 194         (ada_exception_catchpoint_cond_string): Examine all minimal
 195         symbols for exception types.
 196
 197 2019-04-30  Tom Tromey  <tromey@adacore.com>
 198
 199         PR c++/24470:
 200         * dwarf2read.c (process_structure_scope): Handle case where type
 201         has template parameters but no symbol was created.
 202
 203 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 204             Chris January  <chris.january@arm.com>
 205
 206         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 207         qualifier.
 208         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 209
 210 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 211
 212         * f-typeprint.c (f_print_type): Update rules for printing
 213         whitespace.
 214         (f_type_print_varspec_suffix): Likewise.
 215
 216 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 217             Chris January  <chris.january@arm.com>
 218
 219         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 220         function arguments.
 221
 222 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 223
 224         * f-lang.c (build_fortran_types): Change name of void type to
 225         lower case.
 226         * f-typeprint.c (f_type_print_base): Print the name of the void
 227         type, rather than a fixed string.
 228         * f-valprint.c (f_decorations): Use lower case void string.
 229
 230 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 231             Chris January  <chris.january@arm.com>
 232
 233         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 234         types for Fortran.
 235
 236 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 237             Chris January  <chris.january@arm.com>
 238             David Lecomber  <david.lecomber@arm.com>
 239
 240         * f-exp.y (BINOP_INTRINSIC): New token.
 241         (exp): New parser rule handling BINOP_INTRINSIC.
 242         (f77_keywords): Add new builtin procedures.
 243         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 244         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 245         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 246         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 247         (print_unop_subexp_f): New function.
 248         (print_binop_subexp_f): New function.
 249         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 250         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 251         (dump_subexp_body_f): Likewise.
 252         (operator_check_f): Likewise.
 253         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 254         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 255
 256 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 257
 258         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 259         UNOP_KIND.
 260         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 261         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 262         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 263         (operator_length_f): New fuction.
 264         (print_subexp_f): New function.
 265         (op_name_f): New function.
 266         (dump_subexp_body_f): New function.
 267         (operator_check_f): New function.
 268         (exp_descriptor_f): Replace standard expression handling functions
 269         with new functions.
 270         * gdb/fortran-operator.def: New file.
 271         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 272         * gdb/std-operator.def: Remove UNOP_KIND.
 273
 274 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 275
 276         * std-operator.def: Remove unbalanced, stray double quote
 277         character.
 278
 279 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 280             Chris January  <chris.january@arm.com>
 281             Daniel Everett  <daniel.everett@arm.com>
 282             Nick Forrington  <nick.forrington@arm.com>
 283             Richard Bunt  <richard.bunt@arm.com>
 284
 285         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 286         of depth when printing anonymous structs or unions.
 287         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 288         Don't print either the top-level value, or the children if the
 289         max-depth is exceeded.
 290         (ppscm_print_children): When printing the key of a map, allow one
 291         extra level of depth.
 292         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 293         print either the top-level value, or the children if the max-depth
 294         is exceeded.
 295         (print_children): When printing the key of a map, allow one extra
 296         level of depth.
 297         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 298         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 299         (user_print_options): Initialise max_depth field.
 300         (val_print_scalar_or_string_type_p): New function.
 301         (val_print): Check to see if the max depth has been reached.
 302         (val_print_check_max_depth): Define new function.
 303         (show_print_max_depth): New function.
 304         (_initialize_valprint): Add 'print max-depth' option.
 305         * valprint.h (struct value_print_options) <max_depth>: New field.
 306         (val_print_check_max_depth): Declare new function.
 307         * NEWS: Document new feature.
 308
 309 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 310
 311         * ada-lang.c (ada_language_defn): Initialise new field.
 312         * c-lang.c (c_is_string_type_p): New function.
 313         (c_language_defn): Initialise new field.
 314         (cplus_language_defn): Initialise new field.
 315         (asm_language_defn): Initialise new field.
 316         (minimal_language_defn): Initialise new field.
 317         * c-lang.h (c_is_string_type_p): Declare new function.
 318         * d-lang.c (d_language_defn): Initialise new field.
 319         * f-lang.c (f_is_string_type_p): New function.
 320         (f_language_defn): Initialise new field.
 321         * go-lang.c (go_is_string_type_p): New function.
 322         (go_language_defn): Initialise new field.
 323         * language.c (default_is_string_type_p): New function.
 324         (unknown_language_defn): Initialise new field.
 325         (auto_language_defn): Initialise new field.
 326         * language.h (struct language_defn) <la_is_string_type_p>: New
 327         member variable.
 328         (default_is_string_type_p): Declare new function.
 329         * m2-lang.c (m2_language_defn): Initialise new field.
 330         * objc-lang.c (objc_language_defn): Initialise new field.
 331         * opencl-lang.c (opencl_language_defn): Initialise new field.
 332         * p-lang.c (pascal_is_string_type_p): New function.
 333         (pascal_language_defn): Initialise new field.
 334         * rust-lang.c (rust_is_string_type_p): New function.
 335         (rust_language_defn): Initialise new field.
 336
 337 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 338
 339         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 340         New field.
 341         * ada-lang.c (ada_language_defn): Initialise new field.
 342         * c-lang.c (c_language_defn): Likewise.
 343         (cplus_language_defn): Likewise.
 344         (asm_language_defn): Likewise.
 345         (minimal_language_defn): Likewise.
 346         * d-lang.c (d_language_defn): Likewise.
 347         * f-lang.c (f_language_defn): Likewise.
 348         * go-lang.c (go_language_defn): Likewise.
 349         * language.c (unknown_language_defn): Likewise.
 350         (auto_language_defn): Likewise.
 351         * m2-lang.c (m2_language_defn): Likewise.
 352         * objc-lang.c (objc_language_defn): Likewise.
 353         * opencl-lang.c (opencl_language_defn): Likewise.
 354         * p-lang.c (pascal_language_defn): Likewise.
 355         * rust-lang.c (rust_language_defn): Likewise.
 356
 357 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 358
 359         * ada-lang.c (ada_is_character_type): Change return type to bool.
 360         (ada_is_string_type): Likewise.
 361         * ada-lang.h (ada_is_character_type): Update declaration
 362         (ada_is_string_type): Likewise.
 363
 364 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 365
 366         Support style in 'frame|thread apply'
 367
 368         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 369         * record.c (record_start, record_stop): Update callers of
 370         execute_command_to_string with false.
 371         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 372         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 373         methods.
 374         (class string_file): New constructor with term_out parameter.
 375         Override methods term_out and can_emit_style_escape.  New member
 376         term_out.
 377         (class stdio_file): Override can_emit_style_escape.
 378         (class tee_file): Override term_out and can_emit_style_escape.
 379         * utils.h (can_emit_style_escape): Remove.
 380         * utils.c (can_emit_style_escape): Likewise.
 381         Update all callers of can_emit_style_escape (SOMESTREAM) to
 382         SOMESTREAM->can_emit_style_escape.
 383         * source-cache.c (source_cache::get_source_lines): Likewise.
 384         * stack.c (frame_apply_command_count): Call execute_command_to_string
 385         passing the term_out characteristic of the current gdb_stdout.
 386         * thread.c (thr_try_catch_cmd): Likewise.
 387         * top.c (execute_command_to_string): pass term_out parameter
 388         to construct the string_file for the command output.
 389         * ui-file.c (term_cli_styling): New function (most code moved
 390         from utils.c can_emit_style_escape).
 391         (string_file::string_file, string_file::can_emit_style_escape,
 392         stdio_file::can_emit_style_escape, tee_file::term_out,
 393         tee_file::can_emit_style_escape): New functions.
 394
 395 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 396
 397         * NEWS: Mention the new set|show may-call-functions.
 398         * infcall.c (may_call_functions_p): New variable.
 399         (show_may_call_functions_p): New function.
 400         (call_function_by_hand_dummy): Throws an error if not
 401         may-call-functions.
 402         (_initialize_infcall): Call add_setshow_boolean_cmd for
 403         may-call-functions.
 404
 405 2019-04-25  Keith Seitz  <keiths@redhat.com>
 406
 407         PR c++/24367
 408         * cp-support.c (inspect_type): Don't attempt substitutions
 409         of symbol with the same name.
 410
 411 2019-04-25  Tom Tromey  <tromey@adacore.com>
 412
 413         PR gdb/24475:
 414         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 415         static.
 416
 417 2019-04-25  Tom Tromey  <tromey@adacore.com>
 418
 419         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 420         rvalue reference.
 421         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 422         (gdb_xml_parser::parse): Use std::move.
 423         * python/python-internal.h (gdbpy_convert_exception): Take a const
 424         reference.
 425         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 426         std::move.
 427         * python/py-utils.c (gdbpy_convert_exception): Take a const
 428         reference.
 429         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 430         Use std::move.
 431         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 432         Use std::move.
 433         * mi/mi-main.c (mi_print_exception): Take a const reference.
 434         * main.c (handle_command_errors): Take a const reference.
 435         * linespec.c (parse_linespec): Use std::move.
 436         * infcall.c (run_inferior_call): Use std::move.
 437         (call_function_by_hand_dummy): Use std::move.
 438         * exec.c (try_open_exec_file): Use std::move.
 439         * exceptions.h (exception_print, exception_fprintf)
 440         (exception_print_same): Update.
 441         * exceptions.c (print_exception, exception_print)
 442         (exception_fprintf, exception_print_same): Change parameters to
 443         const reference.
 444         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 445         * common/new-op.c: Use std::move.
 446         * common/common-exceptions.h (struct gdb_exception): Add move
 447         constructor.
 448         (struct gdb_exception_error, struct gdb_exception_quit, struct
 449         gdb_quit_bad_alloc): Change constructor to move constructor.
 450         (throw_exception): Change parameter to rvalue reference.
 451         * common/common-exceptions.c (throw_exception): Take rvalue
 452         reference.
 453         * cli/cli-interp.c (safe_execute_command): Use std::move.
 454         * breakpoint.c (insert_bp_location, location_to_sals): Use
 455         std::move.
 456
 457 2019-04-25  Tom Tromey  <tromey@adacore.com>
 458
 459         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 460         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 461         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 462         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 463         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 464         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 465         guile/scm-value.c: Use unpack.
 466         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 467         gdbscm_gdb_exception.
 468         (gdbscm_throw_gdb_exception): Likewise.
 469         (struct gdbscm_gdb_exception): New.
 470         (unpack): New function.
 471         (gdbscm_wrap): Use unpack.
 472
 473 2019-04-25  Tom Tromey  <tromey@adacore.com>
 474
 475         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 476         (gdb_rl_callback_handler): Use std::move.
 477         * common/common-exceptions.h (struct gdb_exception): Add move
 478         assignment operator.
 479         (throw_exception_sjlj): Change "exception" to const reference.
 480         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 481         (throw_exception_sjlj): Change "exception" to const reference.
 482
 483 2019-04-25  Tom Tromey  <tromey@adacore.com>
 484
 485         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 486         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 487         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 488         Update.
 489         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 490         Update.
 491         * mi/mi-interp.c (mi_interp::exec): Update.
 492         * linespec.c (parse_linespec): Update.
 493         * infcall.c (run_inferior_call): Update.
 494         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 495         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 496         (gdbscm_lookup_global_symbol): Update.
 497         * guile/scm-param.c (gdbscm_parameter_value): Update.
 498         * guile/scm-frame.c (gdbscm_frame_read_register)
 499         (gdbscm_frame_read_var): Update.
 500         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 501         * exec.c (try_open_exec_file): Update.
 502         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 503         (gdb_rl_callback_handler): Update.
 504         * common/common-exceptions.h (exception_none): Don't declare.
 505         * common/common-exceptions.c (exception_none): Don't define.
 506         (struct catcher) <exception>: Update.
 507         * cli/cli-interp.c (safe_execute_command): Update.
 508         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 509
 510 2019-04-25  Ali Tamur  <tamur@google.com>
 511
 512         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 513         (read_attribute_value): Likewise.
 514         (dwarf2_read_addr_index): Update comment.
 515         (read_str_index): Add DW_FORM_strx.
 516         (dwarf2_string_attr): Likewise.
 517         (dwarf2_const_value_attr): Likewise.
 518         (dump_die_shallow): Likewise.
 519         (dwarf2_fetch_constant_bytes): Likewise.
 520         (skip_form_bytes): Likewise.
 521         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 522
 523 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 524
 525         PR corefiles/11608
 526         PR corefiles/18187
 527         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 528         OFFSET.  Verify if current mapping contains an ELF header.
 529         (linux_find_memory_regions_full): Adjust call to
 530         dump_mapping_p.
 531
 532 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 533             Kang Li <kanglictf@gmail.com>
 534
 535         PR gdb/21600
 536
 537         * dwarf2-frame.c (read_initial_length): Be consistent about using
 538         unsigned representation of length.
 539         (decode_frame_entry_1): Likewise.  Check for wraparound of
 540         end pointer as well as buffer overflow.
 541
 542 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 543
 544         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 545         "vq".
 546
 547 2019-04-24  Tom Tromey  <tromey@adacore.com>
 548
 549         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 550
 551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 552
 553         * s12z-tdep.c (s12z_unwind_pc): Delete.
 554         (s12z_unwind_sp): Delete.
 555         (s12z_gdbarch_init): Don't register deleted functions with
 556         gdbarch.
 557
 558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 559
 560         * rl78-tdep.c (rl78_unwind_sp): Delete.
 561         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 562
 563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 564
 565         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 566         (xstormy16_unwind_pc): Delete.
 567         (xstormy16_dummy_id): Delete.
 568         (xstormy16_gdbarch_init): Don't register deleted functions with
 569         gdbarch.
 570
 571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * vax-tdep.c (vax_unwind_pc): Delete.
 574         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 575
 576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * v850-tdep.c (v850_unwind_sp): Delete.
 579         (v850_unwind_pc): Delete.
 580         (v850_dummy_id): Delete.
 581         (v850_gdbarch_init): Don't register deleted functions with
 582         gdbarch.
 583
 584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 585
 586         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 587         (tilegx_unwind_pc): Delete.
 588         (tilegx_unwind_dummy_id): Delete.
 589         (tilegx_gdbarch_init): Don't register deleted functions with
 590         gdbarch.
 591
 592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 595         (tic6x_dummy_id): Delete.
 596         (tic6x_gdbarch_init): Don't register deleted functions with
 597         gdbarch.
 598
 599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 600
 601         * sparc-tdep.c (sparc_unwind_pc): Delete.
 602         (sparc32_gdbarch_init): Don't register deleted function with
 603         gdbarch.
 604
 605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 606
 607         * sh-tdep.c (sh_unwind_sp): Delete.
 608         (sh_unwind_pc): Delete.
 609         (sh_dummy_id): Delete.
 610         (sh_gdbarch_init): Don't register deleted functions with
 611         gdbarch.
 612
 613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         * score-tdep.c (score_unwind_sp): Delete.
 616         (score_unwind_pc): Delete.
 617         (score_dummy_id): Delete.
 618         (score_gdbarch_init): Don't register deleted functions with
 619         gdbarch.
 620
 621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 622
 623         * rx-tdep.c (rx_unwind_pc): Delete.
 624         (rx_unwind_sp): Delete.
 625         (rx_dummy_id): Delete.
 626         (rx_gdbarch_init): Don't register deleted functions with
 627         gdbarch.  Update comment.
 628
 629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 630
 631         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 632         (rs6000_dummy_id): Delete.
 633         (rs6000_gdbarch_init): Don't register deleted functions with
 634         gdbarch.
 635
 636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 637
 638         * or1k-tdep.c (or1k_dummy_id): Delete.
 639         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 640
 641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * nios2-tdep.c (nios2_dummy_id): Delete.
 644         (nios2_unwind_sp): Delete.
 645         (nios2_gdbarch_init): Don't register deleted functions with
 646         gdbarch.
 647
 648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 649
 650         * nds32-tdep.c (nds32_dummy_id): Delete.
 651         (nds32_unwind_pc): Delete.
 652         (nds32_unwind_sp): Delete.
 653         (nds32_gdbarch_init): Don't register deleted functions with
 654         gdbarch.
 655
 656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 657
 658         * msp430-tdep.c (msp430_unwind_pc): Delete.
 659         (msp430_unwind_sp): Delete.
 660         (msp430_dummy_id): Delete.
 661         (msp430_gdbarch_init): Don't register deleted functions with
 662         gdbarch.
 663
 664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 665
 666         * moxie-tdep.c (moxie_unwind_sp): Delete.
 667         (moxie_unwind_pc): Delete.
 668         (moxie_dummy_id): Delete.
 669         (moxie_gdbarch_init): Don't register deleted functions with
 670         gdbarch.
 671
 672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 673
 674         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 675         (mn10300_unwind_pc): Delete.
 676         (mn10300_unwind_sp): Delete.
 677         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 678         mn10300_unwind_sp.
 679         (mn10300_frame_unwind_init): Don't register deleted functions with
 680         gdbarch.
 681
 682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 683
 684         * mep-tdep.c (mep_unwind_pc): Delete.
 685         (mep_unwind_sp): Delete.
 686         (mep_dummy_id): Delete.
 687         (mep_gdbarch_init): Don't register deleted functions with
 688         gdbarch.
 689
 690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 691
 692         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 693         (m68hc11_unwind_sp): Delete.
 694         (m68hc11_gdbarch_init): Don't register deleted functions with
 695         gdbarch.
 696
 697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 698
 699         * m32r-tdep.c (m32r_unwind_sp): Delete.
 700         (m32r_unwind_pc): Delete.
 701         (m32r_dummy_id): Delete.
 702         (m32r_gdbarch_init): Don't register deleted functions with
 703         gdbarch.
 704
 705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * m32c-tdep.c (m32c_unwind_pc): Delete.
 708         (m32c_unwind_sp): Delete.
 709         (m32c_dummy_id): Delete.
 710         (m32c_gdbarch_init): Don't register deleted functions with
 711         gdbarch.
 712
 713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 714
 715         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 716         (lm32_unwind_pc): Delete.
 717         (lm32_dummy_id): Delete.
 718         (lm32_gdbarch_init): Don't register deleted functions with
 719         gdbarch.
 720
 721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 722
 723         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 724         (iq2000_unwind_pc): Delete.
 725         (iq2000_dummy_id): Delete.
 726         (iq2000_gdbarch_init): Don't register deleted functions with
 727         gdbarch.
 728
 729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 730
 731         * nds32-tdep.c (nds32_type_align): Delete.
 732         (nds32_push_dummy_call): Use type_align instead.
 733
 734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * arm-tdep.c (arm_type_align): Only handle vector override case.
 737         (arm_push_dummy_call): Use type_align.
 738         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 739
 740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 743         case.
 744         (pass_on_stack): Use type_align.
 745         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 746         function.
 747
 748 2019-04-23  Tom Tromey  <tromey@adacore.com>
 749
 750         * dwarf2read.c (line_header::file_name_at): Remove unused
 751         overload.
 752
 753 2019-04-23  Tom de Vries  <tdevries@suse.de>
 754
 755         PR gdb/24438
 756         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 757         invocation.
 758
 759
 760 2019-03-27  Ali Tamur  <tamur@google.com>
 761
 762         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 763         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 764         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 765         (dwarf_expr_context::get_addr_index): Likewise
 766         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 767         (symbol_needs_eval_context::get_addr_index): Likewise
 768         (disassemble_dwarf_expression): Add DW_OP_addrx
 769         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 770         (read_cutu_die_from_dwo): Update comment
 771         (skip_one_die): Add DW_FORM_addrx
 772         (read_attribute_value): Likewise
 773         (var_decode_location): Add DW_OP_addrx
 774         (dwarf2_const_value_attr): Add DW_FORM_addrx
 775         (dump_die_shallow): Likewise
 776         (dwarf2_fetch_constant_bytes): Likewise
 777         (decode_locdesc): Add DW_OP_addrx
 778         (skip_form_bytes): Add DW_FORM_addrx
 779
 780 2019-04-22  Ali Tamur  <tamur@google.com>
 781
 782         * MAINTAINERS (Write After Approval): Add self.
 783
 784 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 785
 786         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 787         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 788         (open_symbol_file_object): Likewise.
 789         (svr4_default_sos): Add info parameter.
 790         (svr4_read_so_list): Likewise.
 791         (svr4_current_sos_direct): Adjust functions calls to pass down
 792         info.
 793         (svr4_current_sos_1): Add info parameter.
 794         (svr4_current_sos): Call get_svr4_info, pass info down to
 795         svr4_current_sos_1.
 796         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 797         get_svr4_info.
 798         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 799         get_svr4_info.
 800         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 801         to get_svr4_info.
 802         (probes_table_remove_objfile_probes): Likewise.
 803         (register_solib_event_probe): Add info parameter.
 804         (solist_update_incremental): Pass info parameter down to
 805         svr4_read_so_list.
 806         (disable_probes_interface): Add info parameter.
 807         (svr4_handle_solib_event): Pass current_program_space to
 808         get_svr4_info.  Adjust disable_probes_interface cleanup.
 809         (svr4_create_probe_breakpoints): Add info parameter, pass it
 810         down to register_solib_event_probe.
 811         (svr4_create_solib_event_breakpoints): Add info parameter,
 812         pass it down to svr4_create_probe_breakpoints.
 813         (enable_break): Pass info down to
 814         svr4_create_solib_event_breakpoints.
 815         (svr4_solib_create_inferior_hook): Pass current_program_space to
 816         get_svr4_info.
 817         (svr4_clear_solib): Likewise.
 818
 819 2019-04-22  Pedro Alves  <palves@redhat.com>
 820
 821         * solib-svr4.c (svr4_free_objfile_observer): New.
 822         (probe_and_action::objfile): New field.
 823         (probes_table_htab_remove_objfile_probes)
 824         (probes_table_remove_objfile_probes): New functions.
 825         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 826         in the new probe_and_action.  Don't store the probe in 'lookup'.
 827         (svr4_create_probe_breakpoints): Pass objfile to
 828         register_solib_event_probe.
 829         (_initialize_svr4_solib): Register a free_objfile observer.
 830
 831 2019-04-19  Tom Tromey  <tom@tromey.com>
 832
 833         * common/queue.h: Remove.
 834
 835 2019-04-19  Tom Tromey  <tom@tromey.com>
 836
 837         * event-loop.c: Don't include "common/queue.h".
 838
 839 2019-04-19  Tom Tromey  <tom@tromey.com>
 840
 841         * remote.c (remote_target): Use delete.
 842         * remote-notif.h: Include <list>, not "common/queue.h".
 843         (notif_client_p): Remove typedef.
 844         (remote_notif_state): Add constructor, destructor, initializer.
 845         <notif_queue>: Now a std::list.
 846         (remote_notif_state_xfree): Don't declare.
 847         * remote-notif.c (remote_notif_process, handle_notification)
 848         (remote_notif_state_allocate): Update.
 849         (~remote_notif_state): Rename from remote_notif_state_xfree.
 850
 851 2019-04-19  Tom Tromey  <tom@tromey.com>
 852
 853         * symfile.c (reread_symbols): Update.
 854         * objfiles.c (objfile_register_static_link)
 855         (objfile_lookup_static_link): Update
 856         (~objfile) Don't delete static_links.
 857         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 858
 859 2019-04-19  Tom Tromey  <tom@tromey.com>
 860
 861         * type-stack.h (struct type_stack) <insert>: Constify string.
 862         * type-stack.c (type_stack::insert): Constify string.
 863         * gdbtypes.h (lookup_template_type): Update.
 864         (address_space_name_to_int): Update.
 865         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 866         const.
 867         (lookup_template_type): Make name const.
 868         * c-exp.y: Update rules.
 869         (lex_one_token, classify_name, classify_inner_name)
 870         (c_print_token): Update.
 871         * p-exp.y: Update rules.
 872         (yylex): Update.
 873         * f-exp.y: Update rules.
 874         (yylex): Update.
 875         * d-exp.y: Update rules.
 876         (lex_one_token, classify_name, classify_inner_name): Update.
 877         * parse.c (write_dollar_variable, copy_name): Return std::string.
 878         * parser-defs.h (copy_name): Change return type.
 879         * m2-exp.y: Update rules.
 880         (yylex): Update.
 881         * go-exp.y (lex_one_token): Update.
 882         Update rules.
 883         (classify_unsafe_function, classify_packaged_name)
 884         (classify_name, yylex): Update.
 885
 886 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 887
 888         * configure.ac: add --enable-source-highlight switch.
 889         * configure: Regenerate.
 890         * top.c (print_gdb_version): plumb --enable-source-highlight
 891         status to "show configuration".
 892
 893 2019-04-19  Tom Tromey  <tromey@adacore.com>
 894
 895         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 896         Check ADA_TYPE_P.
 897         (empty_record, ada_template_to_fixed_record_type_1)
 898         (template_to_static_fixed_type)
 899         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 900         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 901         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 902         macros.
 903
 904 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 905
 906         PR symtab/24423:
 907         * source.c (print_source_lines_base): Advance "iter" when a
 908         control character is seen.
 909
 910 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 911
 912         * inferior.h (struct infcall_suspend_state_deleter):
 913         Catch exception in destructor to avoid crash.
 914
 915 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 916
 917         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 918         close to the add_com "shell".
 919
 920 2019-04-18  Tom Tromey  <tromey@adacore.com>
 921
 922         * process-stratum-target.h (class process_stratum_target)
 923         <stratum>: Add "final".
 924
 925 2019-04-17  Tom Tromey  <tromey@adacore.com>
 926
 927         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 928         against nullptr before use.
 929
 930 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 931
 932         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 933
 934 2019-04-17  Jim Wilson  <jimw@sifive.com>
 935             Andrew Burgess  <andrew.burgess@embecosm.com>
 936
 937         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 938         code read might fail, assume 4-byte breakpoint in that case.
 939
 940 2019-04-15  Leszek Swirski  <leszeks@google.com>
 941
 942         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 943         rather than a hand-rolled POD check when checking for forced MEMORY
 944         classification.
 945
 946 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 947
 948         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 949         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 950         function.
 951         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 952         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 953         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 954         declaration.
 955
 956 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 957
 958         * aarch64-linux-nat.c
 959         (aarch64_linux_nat_target::thread_architecture): Add override.
 960         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 961         each VQ.
 962
 963 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 964
 965         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 966
 967 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 970         target types of size 96-bits, add some additional comments, and
 971         check that the builtin type we found was the correct size.
 972
 973 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 974
 975         * utils.c (prompt_for_continue): Don't restore the styling at the
 976         end, as applied_style has the wrong value.  This fixes styling in
 977         long lists of file names that are interrupted by the "Continue?"
 978         prompt.
 979
 980 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 983         * c-lang.c (c_language_defn): Likewise.
 984         (cplus_language_defn): Likewise.
 985         (asm_language_defn): Likewise.
 986         (minimal_language_defn): Likewise.
 987         * d-lang.c (d_language_defn): Likewise.
 988         * f-lang.c (f_language_defn): Likewise.
 989         * go-lang.c (go_language_defn): Likewise.
 990         * language.c (unknown_language_defn): Likewise.
 991         (auto_language_defn): Likewise.
 992         * language.h (struct language_defn): Remove la_magic field.
 993         (LANG_MAGIC): Delete.
 994         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 995         * objc-lang.c (objc_language_defn): Likewise.
 996         * opencl-lang.c (opencl_language_defn): Likewise.
 997         * p-lang.c (pascal_language_defn): Likewise.
 998         * rust-lang.c (rust_language_defn): Likewise.
 999
1000 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1001
1002         * riscv-tdep.c (riscv_type_align): New function.
1003         (riscv_type_alignment): Delete.
1004         (riscv_arg_location): Use 'type_align'.
1005         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1006
1007 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * gdbtypes.c (type_align): A struct with no non-static fields also
1010         has alignment of 1.
1011
1012 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1013
1014         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1015         component to 0.
1016         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1017         member.
1018         (riscv_struct_info::analyse): New implementation using new
1019         analyse_inner member function.
1020         (riscv_struct_info::field_offset): New member function.
1021         (riscv_struct_info::m_offsets): New member variable.
1022         (riscv_struct_info::analyse_inner): New private member function,
1023         takes the old implementation of riscv_struct_info::analyse but
1024         extended to track field offsets.
1025         (riscv_call_arg_struct): Update the struct folding special cases
1026         to handle cases where empty C++ structs, which are non-zero
1027         length, are found.
1028         (riscv_arg_location): Initialise the length of each location, a
1029         non-zero length now indicates the location is in use.
1030         (riscv_push_dummy_call): Allow for the first location having a
1031         non-zero offset when setting up arguments.
1032         (riscv_return_value): Likewise, but for return values.
1033
1034 2019-04-11  Tom Tromey  <tromey@adacore.com>
1035
1036         * utils.c (internal_vproblem): Make "msg" const.
1037
1038 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1039
1040         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1041         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1042         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1043         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1044
1045 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1046
1047         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1048         function.
1049         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1050         of amd64_collect_native_gregset.
1051         (amd64_linux_nat_target::store_registers): Likewise.
1052
1053 2019-04-10  Tom Tromey  <tom@tromey.com>
1054
1055         * symtab.c (lookup_global_symbol_from_objfile)
1056         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1057         * objfiles.h (class separate_debug_iterator): New.
1058         (class separate_debug_range): New.
1059         (struct objfile) <separate_debug_objfiles>: New method.
1060         (objfile_separate_debug_iterate): Don't declare.
1061         * objfiles.c (separate_debug_iterator::operator++): Rename from
1062         objfile_separate_debug_iterate.
1063         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1064         iterator.
1065         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1066         iterator.
1067
1068 2019-04-10  Tom Tromey  <tom@tromey.com>
1069
1070         * symfile.c (reread_symbols): Remove old comment.
1071         * objfiles.c (free_all_objfiles): Fix a typo.
1072
1073 2019-04-10  Tom Tromey  <tom@tromey.com>
1074
1075         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1076         * minsyms.c (lookup_minimal_symbol): Use foreach.
1077         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1078         (lookup_minimal_symbol_solib_trampoline): Likewise.
1079         * symfile.c (reread_symbols): Use foreach.
1080
1081 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1082             Tom Tromey  <tromey@adacore.com>
1083
1084         PR rust/24414:
1085         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1086         (rust_lex_int_test): Change "value" to be LONGEST.
1087         (rust_lex_tests): Add test for long integer literal.
1088
1089 2019-04-09  Tom Tromey  <tromey@adacore.com>
1090
1091         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1092         to bool.
1093         (extended_remote_target::attach): Update.
1094         (remote_target::remote_notice_new_inferior): Update.
1095         (remote_target::add_current_inferior_and_thread): Update.
1096         * inferior.c (exit_inferior_1): Use "false".
1097         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1098
1099 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1100
1101         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1102         the "start" command.
1103
1104 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1105
1106         * python/py-inferior.c (infpy_thread_from_thread_handle):
1107         Adjust comments to reflect renaming of thread_from_thread_handle
1108         to thread_from_handle.  Adjust keywords.  Fix type error message.
1109         (inferior_object_methods): Add thread_from_handle.  Retain
1110         thread_from_thread_handle, but mark it as deprecated.
1111
1112 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1113
1114         * gdbthread.h (find_thread_by_handle): Revise declaration.
1115         * thread.c (find_thread_by_handle): Likewise.  Adjust
1116         implementation too.
1117         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1118         support for buffer objects as handles.
1119
1120 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1121
1122         * python/py-infthread.c (thpy_thread_handle): New function.
1123         (thread_object_methods): Register thpy_thread_handle.
1124
1125 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1126
1127         * gdbthread.h (thread_to_thread_handle): Declare.
1128         * thread.c (gdbtypes.h): Include.
1129         (thread_to_thread_handle): New function.
1130
1131         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1132         (target_thread_info_to_thread_handle): Declare.
1133         * target.c (target_thread_info_to_thread_handle): New function.
1134         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1135         * target-delegates.c: Regenerate.
1136
1137         * linux-thread-db.c (class thread_db_target): Add method
1138         thread_info_to_thread_handle.
1139         (thread_db_target::thread_info_to_thread_handle): Define.
1140         * remote.c (class remote_target): Add new method
1141         thread_info_to_thread_handle.
1142         (remote_target::thread_info_to_thread_handle): Define.
1143
1144 2019-04-08  Pedro Alves  <palves@redhat.com>
1145
1146         * common/common-exceptions.c (throw_exception): Don't create
1147         named object to throw; throw directly.
1148         (throw_it): Likewise.  Don't initialize gdb_exception::message
1149         here, with new; pass FMT and AP to the ctor instead.
1150         * common/common-exceptions.h: Include <string>.
1151         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1152         const char *, va_list)): New ctor.  Use std::make_shared.
1153         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1154         errors)): Delete.
1155         (gdb_exception_error::gdb_exception_error(enum errors, const char
1156         *, va_list)): New.
1157         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1158         Add assertion.
1159         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1160         errors)): Delete.
1161         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1162         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1163         Add assertion.
1164
1165 2019-04-08  Tom Tromey  <tom@tromey.com>
1166
1167         * valops.c (value_rtti_indirect_type): Replace throw_exception
1168         with throw.
1169         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1170         with throw.
1171         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1172         throw.
1173         * target.c (target_translate_tls_address): Replace throw_exception
1174         with throw.
1175         * stack.c (frame_apply_command_count): Replace throw_exception
1176         with throw.
1177         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1178         throw.
1179         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1180         with throw.
1181         * rs6000-tdep.c (rs6000_frame_cache)
1182         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1183         * remote.c: Replace throw_exception with throw.
1184         * record-full.c (record_full_message, record_full_wait_1)
1185         (record_full_restore): Replace throw_exception with throw.
1186         * record-btrace.c:
1187         (get_thread_current_frame_id, record_btrace_start_replaying)
1188         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1189         (cmd_record_btrace_start): Replace throw_exception with throw.
1190         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1191         throw.
1192         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1193         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1194         * linespec.c:
1195         (find_linespec_symbols): Replace throw_exception with throw.
1196         * infrun.c (displaced_step_prepare, resume): Replace
1197         throw_exception with throw.
1198         * infcmd.c (post_create_inferior): Replace throw_exception with
1199         throw.
1200         * inf-loop.c (inferior_event_handler): Replace throw_exception
1201         with throw.
1202         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1203         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1204         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1205         (get_prev_frame_always, get_frame_pc_if_available)
1206         (get_frame_address_in_block_if_available, get_frame_language):
1207         Replace throw_exception with throw.
1208         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1209         throw_exception with throw.
1210         * eval.c (fetch_subexp_value, evaluate_var_value)
1211         (evaluate_funcall, evaluate_subexp_standard): Replace
1212         throw_exception with throw.
1213         * dwarf2loc.c (call_site_find_chain)
1214         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1215         Replace throw_exception with throw.
1216         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1217         with throw.
1218         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1219         throw.
1220         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1221         * completer.c (complete_line_internal): Replace throw_exception
1222         with throw.
1223         * compile/compile-object-run.c (compile_object_run): Replace
1224         throw_exception with throw.
1225         * cli/cli-script.c (process_next_line): Replace throw_exception
1226         with throw.
1227         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1228         (btrace_enable, btrace_maint_update_pt_packets): Replace
1229         throw_exception with throw.
1230         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1231         throw_exception with throw.
1232         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1233         throw_exception with throw.
1234         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1235         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1236         * aarch64-tdep.c (aarch64_make_prologue_cache)
1237         (aarch64_make_stub_cache): Replace throw_exception with throw.
1238
1239 2019-04-08  Tom Tromey  <tom@tromey.com>
1240
1241         * common/common-exceptions.c (throw_exception): Rename from
1242         throw_exception_cxx.  Remove old copy.  Make argument const.
1243         (throw_it): Create and throw exception objects directly.
1244         * common/common-exceptions.h (throw_exception): Make argument
1245         const.
1246         (struct gdb_exception_error): Add constructor.
1247         (struct gdb_exception_quit): Add constructor.
1248
1249 2019-04-08  Tom Tromey  <tom@tromey.com>
1250
1251         * common/common-exceptions.h (exception_rethrow): Don't declare.
1252         (TRY_SJLJ): Update comment.
1253         (TRY, CATCH, END_CATCH): Remove.
1254         * common/common-exceptions.c (exception_rethrow): Remove.
1255
1256 2019-04-08  Tom Tromey  <tom@tromey.com>
1257
1258         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1259         Remove.
1260         (gdb_exception_error): Rename from
1261         gdb_exception_RETURN_MASK_ERROR.
1262         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1263         (gdb_quit_bad_alloc): Update.
1264         * aarch64-tdep.c: Update.
1265         * ada-lang.c: Update.
1266         * ada-typeprint.c: Update.
1267         * ada-valprint.c: Update.
1268         * amd64-tdep.c: Update.
1269         * arch-utils.c: Update.
1270         * break-catch-throw.c: Update.
1271         * breakpoint.c: Update.
1272         * btrace.c: Update.
1273         * c-varobj.c: Update.
1274         * cli/cli-cmds.c: Update.
1275         * cli/cli-interp.c: Update.
1276         * cli/cli-script.c: Update.
1277         * common/common-exceptions.c: Update.
1278         * common/new-op.c: Update.
1279         * common/selftest.c: Update.
1280         * compile/compile-c-symbols.c: Update.
1281         * compile/compile-cplus-symbols.c: Update.
1282         * compile/compile-object-load.c: Update.
1283         * compile/compile-object-run.c: Update.
1284         * completer.c: Update.
1285         * corelow.c: Update.
1286         * cp-abi.c: Update.
1287         * cp-support.c: Update.
1288         * cp-valprint.c: Update.
1289         * darwin-nat.c: Update.
1290         * disasm-selftests.c: Update.
1291         * dtrace-probe.c: Update.
1292         * dwarf-index-cache.c: Update.
1293         * dwarf-index-write.c: Update.
1294         * dwarf2-frame-tailcall.c: Update.
1295         * dwarf2-frame.c: Update.
1296         * dwarf2loc.c: Update.
1297         * dwarf2read.c: Update.
1298         * eval.c: Update.
1299         * event-loop.c: Update.
1300         * event-top.c: Update.
1301         * exec.c: Update.
1302         * f-valprint.c: Update.
1303         * fbsd-tdep.c: Update.
1304         * frame-unwind.c: Update.
1305         * frame.c: Update.
1306         * gdbtypes.c: Update.
1307         * gnu-v3-abi.c: Update.
1308         * guile/guile-internal.h: Update.
1309         * guile/scm-block.c: Update.
1310         * guile/scm-breakpoint.c: Update.
1311         * guile/scm-cmd.c: Update.
1312         * guile/scm-disasm.c: Update.
1313         * guile/scm-frame.c: Update.
1314         * guile/scm-lazy-string.c: Update.
1315         * guile/scm-math.c: Update.
1316         * guile/scm-param.c: Update.
1317         * guile/scm-ports.c: Update.
1318         * guile/scm-pretty-print.c: Update.
1319         * guile/scm-symbol.c: Update.
1320         * guile/scm-symtab.c: Update.
1321         * guile/scm-type.c: Update.
1322         * guile/scm-value.c: Update.
1323         * i386-linux-tdep.c: Update.
1324         * i386-tdep.c: Update.
1325         * inf-loop.c: Update.
1326         * infcall.c: Update.
1327         * infcmd.c: Update.
1328         * infrun.c: Update.
1329         * jit.c: Update.
1330         * language.c: Update.
1331         * linespec.c: Update.
1332         * linux-fork.c: Update.
1333         * linux-nat.c: Update.
1334         * linux-tdep.c: Update.
1335         * linux-thread-db.c: Update.
1336         * main.c: Update.
1337         * mi/mi-cmd-break.c: Update.
1338         * mi/mi-cmd-stack.c: Update.
1339         * mi/mi-interp.c: Update.
1340         * mi/mi-main.c: Update.
1341         * objc-lang.c: Update.
1342         * p-valprint.c: Update.
1343         * parse.c: Update.
1344         * ppc-linux-tdep.c: Update.
1345         * printcmd.c: Update.
1346         * python/py-arch.c: Update.
1347         * python/py-breakpoint.c: Update.
1348         * python/py-cmd.c: Update.
1349         * python/py-finishbreakpoint.c: Update.
1350         * python/py-frame.c: Update.
1351         * python/py-framefilter.c: Update.
1352         * python/py-gdb-readline.c: Update.
1353         * python/py-inferior.c: Update.
1354         * python/py-infthread.c: Update.
1355         * python/py-lazy-string.c: Update.
1356         * python/py-linetable.c: Update.
1357         * python/py-objfile.c: Update.
1358         * python/py-param.c: Update.
1359         * python/py-prettyprint.c: Update.
1360         * python/py-progspace.c: Update.
1361         * python/py-record-btrace.c: Update.
1362         * python/py-record.c: Update.
1363         * python/py-symbol.c: Update.
1364         * python/py-type.c: Update.
1365         * python/py-unwind.c: Update.
1366         * python/py-utils.c: Update.
1367         * python/py-value.c: Update.
1368         * python/python.c: Update.
1369         * record-btrace.c: Update.
1370         * record-full.c: Update.
1371         * remote-fileio.c: Update.
1372         * remote.c: Update.
1373         * riscv-tdep.c: Update.
1374         * rs6000-aix-tdep.c: Update.
1375         * rs6000-tdep.c: Update.
1376         * rust-exp.y: Update.
1377         * rust-lang.c: Update.
1378         * s390-tdep.c: Update.
1379         * selftest-arch.c: Update.
1380         * solib-dsbt.c: Update.
1381         * solib-frv.c: Update.
1382         * solib-spu.c: Update.
1383         * solib-svr4.c: Update.
1384         * solib.c: Update.
1385         * sparc64-linux-tdep.c: Update.
1386         * stack.c: Update.
1387         * symfile-mem.c: Update.
1388         * symmisc.c: Update.
1389         * target.c: Update.
1390         * thread.c: Update.
1391         * top.c: Update.
1392         * tracefile-tfile.c: Update.
1393         * tui/tui.c: Update.
1394         * typeprint.c: Update.
1395         * unittests/cli-utils-selftests.c: Update.
1396         * unittests/parse-connection-spec-selftests.c: Update.
1397         * valops.c: Update.
1398         * valprint.c: Update.
1399         * value.c: Update.
1400         * varobj.c: Update.
1401         * windows-nat.c: Update.
1402         * x86-linux-nat.c: Update.
1403         * xml-support.c: Update.
1404
1405 2019-04-08  Tom Tromey  <tom@tromey.com>
1406
1407         * xml-support.c: Use C++ exception handling.
1408         * x86-linux-nat.c: Use C++ exception handling.
1409         * windows-nat.c: Use C++ exception handling.
1410         * varobj.c: Use C++ exception handling.
1411         * value.c: Use C++ exception handling.
1412         * valprint.c: Use C++ exception handling.
1413         * valops.c: Use C++ exception handling.
1414         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1415         handling.
1416         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1417         * typeprint.c: Use C++ exception handling.
1418         * tui/tui.c: Use C++ exception handling.
1419         * tracefile-tfile.c: Use C++ exception handling.
1420         * top.c: Use C++ exception handling.
1421         * thread.c: Use C++ exception handling.
1422         * target.c: Use C++ exception handling.
1423         * symmisc.c: Use C++ exception handling.
1424         * symfile-mem.c: Use C++ exception handling.
1425         * stack.c: Use C++ exception handling.
1426         * sparc64-linux-tdep.c: Use C++ exception handling.
1427         * solib.c: Use C++ exception handling.
1428         * solib-svr4.c: Use C++ exception handling.
1429         * solib-spu.c: Use C++ exception handling.
1430         * solib-frv.c: Use C++ exception handling.
1431         * solib-dsbt.c: Use C++ exception handling.
1432         * selftest-arch.c: Use C++ exception handling.
1433         * s390-tdep.c: Use C++ exception handling.
1434         * rust-lang.c: Use C++ exception handling.
1435         * rust-exp.y: Use C++ exception handling.
1436         * rs6000-tdep.c: Use C++ exception handling.
1437         * rs6000-aix-tdep.c: Use C++ exception handling.
1438         * riscv-tdep.c: Use C++ exception handling.
1439         * remote.c: Use C++ exception handling.
1440         * remote-fileio.c: Use C++ exception handling.
1441         * record-full.c: Use C++ exception handling.
1442         * record-btrace.c: Use C++ exception handling.
1443         * python/python.c: Use C++ exception handling.
1444         * python/py-value.c: Use C++ exception handling.
1445         * python/py-utils.c: Use C++ exception handling.
1446         * python/py-unwind.c: Use C++ exception handling.
1447         * python/py-type.c: Use C++ exception handling.
1448         * python/py-symbol.c: Use C++ exception handling.
1449         * python/py-record.c: Use C++ exception handling.
1450         * python/py-record-btrace.c: Use C++ exception handling.
1451         * python/py-progspace.c: Use C++ exception handling.
1452         * python/py-prettyprint.c: Use C++ exception handling.
1453         * python/py-param.c: Use C++ exception handling.
1454         * python/py-objfile.c: Use C++ exception handling.
1455         * python/py-linetable.c: Use C++ exception handling.
1456         * python/py-lazy-string.c: Use C++ exception handling.
1457         * python/py-infthread.c: Use C++ exception handling.
1458         * python/py-inferior.c: Use C++ exception handling.
1459         * python/py-gdb-readline.c: Use C++ exception handling.
1460         * python/py-framefilter.c: Use C++ exception handling.
1461         * python/py-frame.c: Use C++ exception handling.
1462         * python/py-finishbreakpoint.c: Use C++ exception handling.
1463         * python/py-cmd.c: Use C++ exception handling.
1464         * python/py-breakpoint.c: Use C++ exception handling.
1465         * python/py-arch.c: Use C++ exception handling.
1466         * printcmd.c: Use C++ exception handling.
1467         * ppc-linux-tdep.c: Use C++ exception handling.
1468         * parse.c: Use C++ exception handling.
1469         * p-valprint.c: Use C++ exception handling.
1470         * objc-lang.c: Use C++ exception handling.
1471         * mi/mi-main.c: Use C++ exception handling.
1472         * mi/mi-interp.c: Use C++ exception handling.
1473         * mi/mi-cmd-stack.c: Use C++ exception handling.
1474         * mi/mi-cmd-break.c: Use C++ exception handling.
1475         * main.c: Use C++ exception handling.
1476         * linux-thread-db.c: Use C++ exception handling.
1477         * linux-tdep.c: Use C++ exception handling.
1478         * linux-nat.c: Use C++ exception handling.
1479         * linux-fork.c: Use C++ exception handling.
1480         * linespec.c: Use C++ exception handling.
1481         * language.c: Use C++ exception handling.
1482         * jit.c: Use C++ exception handling.
1483         * infrun.c: Use C++ exception handling.
1484         * infcmd.c: Use C++ exception handling.
1485         * infcall.c: Use C++ exception handling.
1486         * inf-loop.c: Use C++ exception handling.
1487         * i386-tdep.c: Use C++ exception handling.
1488         * i386-linux-tdep.c: Use C++ exception handling.
1489         * guile/scm-value.c: Use C++ exception handling.
1490         * guile/scm-type.c: Use C++ exception handling.
1491         * guile/scm-symtab.c: Use C++ exception handling.
1492         * guile/scm-symbol.c: Use C++ exception handling.
1493         * guile/scm-pretty-print.c: Use C++ exception handling.
1494         * guile/scm-ports.c: Use C++ exception handling.
1495         * guile/scm-param.c: Use C++ exception handling.
1496         * guile/scm-math.c: Use C++ exception handling.
1497         * guile/scm-lazy-string.c: Use C++ exception handling.
1498         * guile/scm-frame.c: Use C++ exception handling.
1499         * guile/scm-disasm.c: Use C++ exception handling.
1500         * guile/scm-cmd.c: Use C++ exception handling.
1501         * guile/scm-breakpoint.c: Use C++ exception handling.
1502         * guile/scm-block.c: Use C++ exception handling.
1503         * guile/guile-internal.h: Use C++ exception handling.
1504         * gnu-v3-abi.c: Use C++ exception handling.
1505         * gdbtypes.c: Use C++ exception handling.
1506         * frame.c: Use C++ exception handling.
1507         * frame-unwind.c: Use C++ exception handling.
1508         * fbsd-tdep.c: Use C++ exception handling.
1509         * f-valprint.c: Use C++ exception handling.
1510         * exec.c: Use C++ exception handling.
1511         * event-top.c: Use C++ exception handling.
1512         * event-loop.c: Use C++ exception handling.
1513         * eval.c: Use C++ exception handling.
1514         * dwarf2read.c: Use C++ exception handling.
1515         * dwarf2loc.c: Use C++ exception handling.
1516         * dwarf2-frame.c: Use C++ exception handling.
1517         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1518         * dwarf-index-write.c: Use C++ exception handling.
1519         * dwarf-index-cache.c: Use C++ exception handling.
1520         * dtrace-probe.c: Use C++ exception handling.
1521         * disasm-selftests.c: Use C++ exception handling.
1522         * darwin-nat.c: Use C++ exception handling.
1523         * cp-valprint.c: Use C++ exception handling.
1524         * cp-support.c: Use C++ exception handling.
1525         * cp-abi.c: Use C++ exception handling.
1526         * corelow.c: Use C++ exception handling.
1527         * completer.c: Use C++ exception handling.
1528         * compile/compile-object-run.c: Use C++ exception handling.
1529         * compile/compile-object-load.c: Use C++ exception handling.
1530         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1531         * compile/compile-c-symbols.c: Use C++ exception handling.
1532         * common/selftest.c: Use C++ exception handling.
1533         * common/new-op.c: Use C++ exception handling.
1534         * cli/cli-script.c: Use C++ exception handling.
1535         * cli/cli-interp.c: Use C++ exception handling.
1536         * cli/cli-cmds.c: Use C++ exception handling.
1537         * c-varobj.c: Use C++ exception handling.
1538         * btrace.c: Use C++ exception handling.
1539         * breakpoint.c: Use C++ exception handling.
1540         * break-catch-throw.c: Use C++ exception handling.
1541         * arch-utils.c: Use C++ exception handling.
1542         * amd64-tdep.c: Use C++ exception handling.
1543         * ada-valprint.c: Use C++ exception handling.
1544         * ada-typeprint.c: Use C++ exception handling.
1545         * ada-lang.c: Use C++ exception handling.
1546         * aarch64-tdep.c: Use C++ exception handling.
1547
1548 2019-04-08  Tom Tromey  <tom@tromey.com>
1549
1550         * xml-support.c (gdb_xml_parser::parse): Update.
1551         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1552         * value.c (show_convenience): Update.
1553         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1554         (test_parse_flags_qcs): Update.
1555         * thread.c (thr_try_catch_cmd): Update.
1556         * target.c (target_translate_tls_address): Update.
1557         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1558         (info_frame_command_core, frame_apply_command_count): Update.
1559         * rust-exp.y (rust_lex_exception_test): Update.
1560         * riscv-tdep.c (riscv_print_one_register_info): Update.
1561         * remote.c (remote_target::enable_btrace): Update.
1562         * record-btrace.c (record_btrace_enable_warn): Update.
1563         * python/py-utils.c (gdbpy_convert_exception): Update.
1564         * printcmd.c (do_one_display, print_variable_and_value): Update.
1565         * mi/mi-main.c (mi_print_exception): Update.
1566         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1567         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1568         * linux-nat.c (linux_nat_target::attach): Update.
1569         * linux-fork.c (class scoped_switch_fork_info): Update.
1570         * infrun.c (displaced_step_prepare): Update.
1571         * infcall.c (call_function_by_hand_dummy): Update.
1572         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1573         * gnu-v3-abi.c (print_one_vtable): Update.
1574         * frame.c (get_prev_frame_always): Update.
1575         * f-valprint.c (info_common_command_for_block): Update.
1576         * exec.c (try_open_exec_file): Update.
1577         * exceptions.c (print_exception, exception_print)
1578         (exception_fprintf, exception_print_same): Update.
1579         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1580         * dwarf-index-cache.c (index_cache::store)
1581         (index_cache::lookup_gdb_index): Update.
1582         * darwin-nat.c (maybe_cache_shell): Update.
1583         * cp-valprint.c (cp_print_value_fields): Update.
1584         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1585         (gcc_cplus_symbol_address): Update.
1586         * compile/compile-c-symbols.c (gcc_convert_symbol)
1587         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1588         * common/selftest.c: Update.
1589         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1590         a std::string.
1591         (exception_try_scope_entry, exception_try_scope_exit): Don't
1592         declare.
1593         (struct exception_try_scope): Remove.
1594         (TRY): Don't use exception_try_scope.
1595         (struct gdb_exception): Add constructor, operator=.
1596         <what>: New method.
1597         (struct gdb_exception_RETURN_MASK_ALL)
1598         (struct gdb_exception_RETURN_MASK_ERROR)
1599         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1600         (struct gdb_quit_bad_alloc): Update.
1601         * common/common-exceptions.c (exception_none): Change
1602         initializer.
1603         (struct catcher) <state, exception>: Initialize inline.
1604         <prev>: Remove member.
1605         (current_catcher): Remove.
1606         (catchers): New global.
1607         (exceptions_state_mc_init): Simplify.
1608         (catcher_pop): Remove.
1609         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1610         (try_scope_depth, exception_try_scope_entry)
1611         (exception_try_scope_exit): Remove.
1612         (throw_exception_sjlj): Update.
1613         (exception_messages, exception_messages_size): Remove.
1614         (throw_it): Simplify.
1615         (gdb_exception_sliced_copy): Remove.
1616         (throw_exception_cxx): Update.
1617         * cli/cli-script.c (script_from_file): Update.
1618         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1619         Update.
1620         * ada-valprint.c (ada_val_print): Update.
1621         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1622         (create_excep_cond_exprs): Update.
1623
1624 2019-04-08  Tom Tromey  <tom@tromey.com>
1625
1626         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1627         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1628         (TRY, CATCH, END_CATCH): Remove some definitions.
1629         * common/common-exceptions.c: Don't use GDB_XCPT.
1630         (catcher_list_size): Remove.
1631         (throw_exception, throw_it): Simplify.
1632
1633 2019-04-05  Tom Tromey  <tom@tromey.com>
1634
1635         Revert the header-sorting patch.
1636         * ft32-tdep.c: Revert.
1637         * frv-tdep.c: Revert.
1638         * frv-linux-tdep.c: Revert.
1639         * frame.c: Revert.
1640         * frame-unwind.c: Revert.
1641         * frame-base.c: Revert.
1642         * fork-child.c: Revert.
1643         * findvar.c: Revert.
1644         * findcmd.c: Revert.
1645         * filesystem.c: Revert.
1646         * filename-seen-cache.h: Revert.
1647         * filename-seen-cache.c: Revert.
1648         * fbsd-tdep.c: Revert.
1649         * fbsd-nat.h: Revert.
1650         * fbsd-nat.c: Revert.
1651         * f-valprint.c: Revert.
1652         * f-typeprint.c: Revert.
1653         * f-lang.c: Revert.
1654         * extension.h: Revert.
1655         * extension.c: Revert.
1656         * extension-priv.h: Revert.
1657         * expprint.c: Revert.
1658         * exec.h: Revert.
1659         * exec.c: Revert.
1660         * exceptions.c: Revert.
1661         * event-top.c: Revert.
1662         * event-loop.c: Revert.
1663         * eval.c: Revert.
1664         * elfread.c: Revert.
1665         * dwarf2read.h: Revert.
1666         * dwarf2read.c: Revert.
1667         * dwarf2loc.c: Revert.
1668         * dwarf2expr.h: Revert.
1669         * dwarf2expr.c: Revert.
1670         * dwarf2-frame.c: Revert.
1671         * dwarf2-frame-tailcall.c: Revert.
1672         * dwarf-index-write.h: Revert.
1673         * dwarf-index-write.c: Revert.
1674         * dwarf-index-common.c: Revert.
1675         * dwarf-index-cache.h: Revert.
1676         * dwarf-index-cache.c: Revert.
1677         * dummy-frame.c: Revert.
1678         * dtrace-probe.c: Revert.
1679         * disasm.h: Revert.
1680         * disasm.c: Revert.
1681         * disasm-selftests.c: Revert.
1682         * dictionary.c: Revert.
1683         * dicos-tdep.c: Revert.
1684         * demangle.c: Revert.
1685         * dcache.h: Revert.
1686         * dcache.c: Revert.
1687         * darwin-nat.h: Revert.
1688         * darwin-nat.c: Revert.
1689         * darwin-nat-info.c: Revert.
1690         * d-valprint.c: Revert.
1691         * d-namespace.c: Revert.
1692         * d-lang.c: Revert.
1693         * ctf.c: Revert.
1694         * csky-tdep.c: Revert.
1695         * csky-linux-tdep.c: Revert.
1696         * cris-tdep.c: Revert.
1697         * cris-linux-tdep.c: Revert.
1698         * cp-valprint.c: Revert.
1699         * cp-support.c: Revert.
1700         * cp-namespace.c: Revert.
1701         * cp-abi.c: Revert.
1702         * corelow.c: Revert.
1703         * corefile.c: Revert.
1704         * continuations.c: Revert.
1705         * completer.h: Revert.
1706         * completer.c: Revert.
1707         * complaints.c: Revert.
1708         * coffread.c: Revert.
1709         * coff-pe-read.c: Revert.
1710         * cli-out.h: Revert.
1711         * cli-out.c: Revert.
1712         * charset.c: Revert.
1713         * c-varobj.c: Revert.
1714         * c-valprint.c: Revert.
1715         * c-typeprint.c: Revert.
1716         * c-lang.c: Revert.
1717         * buildsym.c: Revert.
1718         * buildsym-legacy.c: Revert.
1719         * build-id.h: Revert.
1720         * build-id.c: Revert.
1721         * btrace.c: Revert.
1722         * bsd-uthread.c: Revert.
1723         * breakpoint.h: Revert.
1724         * breakpoint.c: Revert.
1725         * break-catch-throw.c: Revert.
1726         * break-catch-syscall.c: Revert.
1727         * break-catch-sig.c: Revert.
1728         * blockframe.c: Revert.
1729         * block.c: Revert.
1730         * bfin-tdep.c: Revert.
1731         * bfin-linux-tdep.c: Revert.
1732         * bfd-target.c: Revert.
1733         * bcache.c: Revert.
1734         * ax-general.c: Revert.
1735         * ax-gdb.h: Revert.
1736         * ax-gdb.c: Revert.
1737         * avr-tdep.c: Revert.
1738         * auxv.c: Revert.
1739         * auto-load.c: Revert.
1740         * arm-wince-tdep.c: Revert.
1741         * arm-tdep.c: Revert.
1742         * arm-symbian-tdep.c: Revert.
1743         * arm-pikeos-tdep.c: Revert.
1744         * arm-obsd-tdep.c: Revert.
1745         * arm-nbsd-tdep.c: Revert.
1746         * arm-nbsd-nat.c: Revert.
1747         * arm-linux-tdep.c: Revert.
1748         * arm-linux-nat.c: Revert.
1749         * arm-fbsd-tdep.c: Revert.
1750         * arm-fbsd-nat.c: Revert.
1751         * arm-bsd-tdep.c: Revert.
1752         * arch-utils.c: Revert.
1753         * arc-tdep.c: Revert.
1754         * arc-newlib-tdep.c: Revert.
1755         * annotate.h: Revert.
1756         * annotate.c: Revert.
1757         * amd64-windows-tdep.c: Revert.
1758         * amd64-windows-nat.c: Revert.
1759         * amd64-tdep.c: Revert.
1760         * amd64-sol2-tdep.c: Revert.
1761         * amd64-obsd-tdep.c: Revert.
1762         * amd64-obsd-nat.c: Revert.
1763         * amd64-nbsd-tdep.c: Revert.
1764         * amd64-nbsd-nat.c: Revert.
1765         * amd64-nat.c: Revert.
1766         * amd64-linux-tdep.c: Revert.
1767         * amd64-linux-nat.c: Revert.
1768         * amd64-fbsd-tdep.c: Revert.
1769         * amd64-fbsd-nat.c: Revert.
1770         * amd64-dicos-tdep.c: Revert.
1771         * amd64-darwin-tdep.c: Revert.
1772         * amd64-bsd-nat.c: Revert.
1773         * alpha-tdep.c: Revert.
1774         * alpha-obsd-tdep.c: Revert.
1775         * alpha-nbsd-tdep.c: Revert.
1776         * alpha-mdebug-tdep.c: Revert.
1777         * alpha-linux-tdep.c: Revert.
1778         * alpha-linux-nat.c: Revert.
1779         * alpha-bsd-tdep.c: Revert.
1780         * alpha-bsd-nat.c: Revert.
1781         * aix-thread.c: Revert.
1782         * agent.c: Revert.
1783         * addrmap.c: Revert.
1784         * ada-varobj.c: Revert.
1785         * ada-valprint.c: Revert.
1786         * ada-typeprint.c: Revert.
1787         * ada-tasks.c: Revert.
1788         * ada-lang.c: Revert.
1789         * aarch64-tdep.c: Revert.
1790         * aarch64-ravenscar-thread.c: Revert.
1791         * aarch64-newlib-tdep.c: Revert.
1792         * aarch64-linux-tdep.c: Revert.
1793         * aarch64-linux-nat.c: Revert.
1794         * aarch64-fbsd-tdep.c: Revert.
1795         * aarch64-fbsd-nat.c: Revert.
1796         * aarch32-linux-nat.c: Revert.
1797
1798 2019-04-05  Tom Tromey  <tom@tromey.com>
1799
1800         * ft32-tdep.c: Sort headers.
1801         * frv-tdep.c: Sort headers.
1802         * frv-linux-tdep.c: Sort headers.
1803         * frame.c: Sort headers.
1804         * frame-unwind.c: Sort headers.
1805         * frame-base.c: Sort headers.
1806         * fork-child.c: Sort headers.
1807         * findvar.c: Sort headers.
1808         * findcmd.c: Sort headers.
1809         * filesystem.c: Sort headers.
1810         * filename-seen-cache.h: Sort headers.
1811         * filename-seen-cache.c: Sort headers.
1812         * fbsd-tdep.c: Sort headers.
1813         * fbsd-nat.h: Sort headers.
1814         * fbsd-nat.c: Sort headers.
1815         * f-valprint.c: Sort headers.
1816         * f-typeprint.c: Sort headers.
1817         * f-lang.c: Sort headers.
1818         * extension.h: Sort headers.
1819         * extension.c: Sort headers.
1820         * extension-priv.h: Sort headers.
1821         * expprint.c: Sort headers.
1822         * exec.h: Sort headers.
1823         * exec.c: Sort headers.
1824         * exceptions.c: Sort headers.
1825         * event-top.c: Sort headers.
1826         * event-loop.c: Sort headers.
1827         * eval.c: Sort headers.
1828         * elfread.c: Sort headers.
1829         * dwarf2read.h: Sort headers.
1830         * dwarf2read.c: Sort headers.
1831         * dwarf2loc.c: Sort headers.
1832         * dwarf2expr.h: Sort headers.
1833         * dwarf2expr.c: Sort headers.
1834         * dwarf2-frame.c: Sort headers.
1835         * dwarf2-frame-tailcall.c: Sort headers.
1836         * dwarf-index-write.h: Sort headers.
1837         * dwarf-index-write.c: Sort headers.
1838         * dwarf-index-common.c: Sort headers.
1839         * dwarf-index-cache.h: Sort headers.
1840         * dwarf-index-cache.c: Sort headers.
1841         * dummy-frame.c: Sort headers.
1842         * dtrace-probe.c: Sort headers.
1843         * disasm.h: Sort headers.
1844         * disasm.c: Sort headers.
1845         * disasm-selftests.c: Sort headers.
1846         * dictionary.c: Sort headers.
1847         * dicos-tdep.c: Sort headers.
1848         * demangle.c: Sort headers.
1849         * dcache.h: Sort headers.
1850         * dcache.c: Sort headers.
1851         * darwin-nat.h: Sort headers.
1852         * darwin-nat.c: Sort headers.
1853         * darwin-nat-info.c: Sort headers.
1854         * d-valprint.c: Sort headers.
1855         * d-namespace.c: Sort headers.
1856         * d-lang.c: Sort headers.
1857         * ctf.c: Sort headers.
1858         * csky-tdep.c: Sort headers.
1859         * csky-linux-tdep.c: Sort headers.
1860         * cris-tdep.c: Sort headers.
1861         * cris-linux-tdep.c: Sort headers.
1862         * cp-valprint.c: Sort headers.
1863         * cp-support.c: Sort headers.
1864         * cp-namespace.c: Sort headers.
1865         * cp-abi.c: Sort headers.
1866         * corelow.c: Sort headers.
1867         * corefile.c: Sort headers.
1868         * continuations.c: Sort headers.
1869         * completer.h: Sort headers.
1870         * completer.c: Sort headers.
1871         * complaints.c: Sort headers.
1872         * coffread.c: Sort headers.
1873         * coff-pe-read.c: Sort headers.
1874         * cli-out.h: Sort headers.
1875         * cli-out.c: Sort headers.
1876         * charset.c: Sort headers.
1877         * c-varobj.c: Sort headers.
1878         * c-valprint.c: Sort headers.
1879         * c-typeprint.c: Sort headers.
1880         * c-lang.c: Sort headers.
1881         * buildsym.c: Sort headers.
1882         * buildsym-legacy.c: Sort headers.
1883         * build-id.h: Sort headers.
1884         * build-id.c: Sort headers.
1885         * btrace.c: Sort headers.
1886         * bsd-uthread.c: Sort headers.
1887         * breakpoint.h: Sort headers.
1888         * breakpoint.c: Sort headers.
1889         * break-catch-throw.c: Sort headers.
1890         * break-catch-syscall.c: Sort headers.
1891         * break-catch-sig.c: Sort headers.
1892         * blockframe.c: Sort headers.
1893         * block.c: Sort headers.
1894         * bfin-tdep.c: Sort headers.
1895         * bfin-linux-tdep.c: Sort headers.
1896         * bfd-target.c: Sort headers.
1897         * bcache.c: Sort headers.
1898         * ax-general.c: Sort headers.
1899         * ax-gdb.h: Sort headers.
1900         * ax-gdb.c: Sort headers.
1901         * avr-tdep.c: Sort headers.
1902         * auxv.c: Sort headers.
1903         * auto-load.c: Sort headers.
1904         * arm-wince-tdep.c: Sort headers.
1905         * arm-tdep.c: Sort headers.
1906         * arm-symbian-tdep.c: Sort headers.
1907         * arm-pikeos-tdep.c: Sort headers.
1908         * arm-obsd-tdep.c: Sort headers.
1909         * arm-nbsd-tdep.c: Sort headers.
1910         * arm-nbsd-nat.c: Sort headers.
1911         * arm-linux-tdep.c: Sort headers.
1912         * arm-linux-nat.c: Sort headers.
1913         * arm-fbsd-tdep.c: Sort headers.
1914         * arm-fbsd-nat.c: Sort headers.
1915         * arm-bsd-tdep.c: Sort headers.
1916         * arch-utils.c: Sort headers.
1917         * arc-tdep.c: Sort headers.
1918         * arc-newlib-tdep.c: Sort headers.
1919         * annotate.h: Sort headers.
1920         * annotate.c: Sort headers.
1921         * amd64-windows-tdep.c: Sort headers.
1922         * amd64-windows-nat.c: Sort headers.
1923         * amd64-tdep.c: Sort headers.
1924         * amd64-sol2-tdep.c: Sort headers.
1925         * amd64-obsd-tdep.c: Sort headers.
1926         * amd64-obsd-nat.c: Sort headers.
1927         * amd64-nbsd-tdep.c: Sort headers.
1928         * amd64-nbsd-nat.c: Sort headers.
1929         * amd64-nat.c: Sort headers.
1930         * amd64-linux-tdep.c: Sort headers.
1931         * amd64-linux-nat.c: Sort headers.
1932         * amd64-fbsd-tdep.c: Sort headers.
1933         * amd64-fbsd-nat.c: Sort headers.
1934         * amd64-dicos-tdep.c: Sort headers.
1935         * amd64-darwin-tdep.c: Sort headers.
1936         * amd64-bsd-nat.c: Sort headers.
1937         * alpha-tdep.c: Sort headers.
1938         * alpha-obsd-tdep.c: Sort headers.
1939         * alpha-nbsd-tdep.c: Sort headers.
1940         * alpha-mdebug-tdep.c: Sort headers.
1941         * alpha-linux-tdep.c: Sort headers.
1942         * alpha-linux-nat.c: Sort headers.
1943         * alpha-bsd-tdep.c: Sort headers.
1944         * alpha-bsd-nat.c: Sort headers.
1945         * aix-thread.c: Sort headers.
1946         * agent.c: Sort headers.
1947         * addrmap.c: Sort headers.
1948         * ada-varobj.c: Sort headers.
1949         * ada-valprint.c: Sort headers.
1950         * ada-typeprint.c: Sort headers.
1951         * ada-tasks.c: Sort headers.
1952         * ada-lang.c: Sort headers.
1953         * aarch64-tdep.c: Sort headers.
1954         * aarch64-ravenscar-thread.c: Sort headers.
1955         * aarch64-newlib-tdep.c: Sort headers.
1956         * aarch64-linux-tdep.c: Sort headers.
1957         * aarch64-linux-nat.c: Sort headers.
1958         * aarch64-fbsd-tdep.c: Sort headers.
1959         * aarch64-fbsd-nat.c: Sort headers.
1960         * aarch32-linux-nat.c: Sort headers.
1961
1962 2019-04-04  Tom Tromey  <tom@tromey.com>
1963
1964         * varobj.c (varobj_create): Update.
1965         * rust-exp.y (struct rust_parser) <update_innermost_block,
1966         lookup_symbol>: New methods.
1967         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1968         Rename.
1969         (rust_parser::rust_lookup_type)
1970         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1971         * printcmd.c (display_command, do_one_display): Update.
1972         * parser-defs.h (struct parser_state) <parser_state>: Add
1973         "tracker" parameter.
1974         (block_tracker): New member.
1975         (class innermost_block_tracker) <innermost_block_tracker>: Add
1976         "types" parameter.
1977         <reset>: Remove method.
1978         (innermost_block): Don't declare.
1979         (null_post_parser): Update.
1980         * parse.c (innermost_block): Remove global.
1981         (write_dollar_variable): Update.
1982         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1983         Remove "tracker_types" parameter.
1984         (parse_expression): Add "tracker" parameter.
1985         (parse_expression_for_completion): Update.
1986         (null_post_parser): Add "tracker" parameter.
1987         * p-exp.y: Update rules.
1988         * m2-exp.y: Update rules.
1989         * language.h (struct language_defn) <la_post_parser>: Add
1990         "tracker" parameter.
1991         * go-exp.y: Update rules.
1992         * f-exp.y: Update rules.
1993         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1994         parameter.
1995         * d-exp.y: Update rules.
1996         * c-exp.y: Update rules.
1997         * breakpoint.c (set_breakpoint_condition): Create an
1998         innermost_block_tracker.
1999         (watch_command_1): Likewise.
2000         * ada-lang.c (resolve): Add "tracker" parameter.
2001         (resolve_subexp): Likewise.
2002         * ada-exp.y (write_var_from_sym): Update.
2003
2004 2019-04-04  Tom Tromey  <tom@tromey.com>
2005
2006         * type-stack.h: New file.
2007         * type-stack.c: New file.
2008         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2009         type-stack.h.
2010         (insert_into_type_stack, insert_type, push_type, push_type_int)
2011         (insert_type_address_space, pop_type, pop_type_int)
2012         (pop_typelist, pop_type_stack, append_type_stack)
2013         (push_type_stack, get_type_stack, push_typelist)
2014         (follow_type_instance_flags, follow_types): Don't declare.
2015         * parse.c (type_stack): Remove global.
2016         (parse_exp_in_context): Update.
2017         (insert_into_type_stack, insert_type, push_type, push_type_int)
2018         (insert_type_address_space, pop_type, pop_type_int)
2019         (pop_typelist, pop_type_stack, append_type_stack)
2020         (push_type_stack, get_type_stack, push_typelist)
2021         (follow_type_instance_flags, follow_types): Remove (moved to
2022         type-stack.c).
2023         * f-exp.y (type_stack): New global.
2024         Update rules.
2025         (push_kind_type, f_parse): Update.
2026         * d-exp.y (type_stack): New global.
2027         Update rules.
2028         (d_parse): Update.
2029         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2030         Update rules.
2031         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2032         (HFILES_NO_SRCDIR): Add type-stack.h.
2033
2034 2019-04-04  Tom Tromey  <tom@tromey.com>
2035
2036         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2037         (rust_parser::convert_ast_to_expression, rust_parse)
2038         (rust_lex_test_completion, rust_lex_tests): Update.
2039         * parser-defs.h (struct expr_completion_state): New.
2040         (struct parser_state) <parser_state>: Add completion parameter.
2041         <mark_struct_expression, mark_completion_tag>: New methods.
2042         <parse_completion, m_completion_state>: New members.
2043         (prefixify_expression, null_post_parser): Update.
2044         (mark_struct_expression, mark_completion_tag): Don't declare.
2045         * parse.c (parse_completion, expout_last_struct)
2046         (expout_tag_completion_type, expout_completion_name): Remove
2047         globals.
2048         (parser_state::mark_struct_expression)
2049         (parser_state::mark_completion_tag): Now methods.
2050         (prefixify_expression): Add last_struct parameter.
2051         (prefixify_subexp): Likewise.
2052         (parse_exp_1): Update.
2053         (parse_exp_in_context): Add cstate parameter.  Update.
2054         (parse_expression_for_completion): Create an
2055         expr_completion_state.
2056         (null_post_parser): Add "completion" parameter.
2057         * p-exp.y: Update rules.
2058         (yylex): Update.
2059         * language.h (struct language_defn) <la_post_parser>: Add
2060         "completing" parameter.
2061         * go-exp.y: Update rules.
2062         (lex_one_token): Update.
2063         * expression.h (parse_completion): Don't declare.
2064         * d-exp.y: Update rules.
2065         (lex_one_token): Update rules.
2066         * c-exp.y: Update rules.
2067         (lex_one_token): Update.
2068         * ada-lang.c (resolve): Add "parse_completion" parameter.
2069         (resolve_subexp): Likewise.
2070         (ada_resolve_function): Likewise.
2071
2072 2019-04-04  Tom Tromey  <tom@tromey.com>
2073
2074         * parser-defs.h (struct parser_state) <start_arglist,
2075         end_arglist>: New methods.
2076         <arglist_len, m_funcall_chain>: New members.
2077         (arglist_len, start_arglist, end_arglist): Don't declare.
2078         * parse.c (arglist_len, funcall_chain): Remove global.
2079         (start_arglist, end_arglist): Remove functions.
2080         (parse_exp_in_context): Update.
2081         * p-exp.y: Update rules.
2082         * m2-exp.y: Update rules.
2083         * go-exp.y: Update rules.
2084         * f-exp.y: Update rules.
2085         * d-exp.y: Update rules.
2086         * c-exp.y: Update rules.
2087
2088 2019-04-04  Tom Tromey  <tom@tromey.com>
2089
2090         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2091         lex_operator, push_back>: New methods.
2092         Update all rules.
2093         (rust_parser::lex_hex, lex_escape): Rename and update.
2094         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2095         (rust_parser::lex_operator): Rename and update.
2096         (rust_parser::lex_number, rustyylex, rustyyerror)
2097         (rust_lex_test_init, rust_lex_test_sequence)
2098         (rust_lex_test_push_back, rust_lex_tests): Update.
2099         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2100         parameter.
2101         <lexptr, prev_lexptr>: New members.
2102         (lexptr, prev_lexptr): Don't declare.
2103         * parse.c (lexptr, prev_lexptr): Remove globals.
2104         (parse_exp_in_context): Update.
2105         * p-exp.y (yylex, yyerror): Update.
2106         * m2-exp.y (parse_number, yylex, yyerror): Update.
2107         * go-exp.y (lex_one_token, yyerror): Update.
2108         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2109         * d-exp.y (lex_one_token, yyerror): Update.
2110         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2111         (lex_one_token, yyerror): Update.
2112         * ada-lex.l (YY_INPUT): Update.
2113         (rewind_to_char): Update.
2114         * ada-exp.y (yyerror): Update.
2115
2116 2019-04-04  Tom Tromey  <tom@tromey.com>
2117
2118         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2119         * parser-defs.h (struct parser_state) <parser_state>: Add new
2120         parameter.
2121         <comma_terminates>: New member.
2122         (comma_terminates): Don't declare global.
2123         * parse.c (comma_terminates): Remove global.
2124         (parse_exp_in_context): Update.
2125         * p-exp.y (yylex): Update.
2126         * m2-exp.y (yylex): Update.
2127         * go-exp.y (lex_one_token): Update.
2128         * f-exp.y (yylex): Update.
2129         * d-exp.y (lex_one_token): Update.
2130         * c-exp.y (lex_one_token): Update.
2131         * ada-lex.l: Update.
2132
2133 2019-04-04  Tom Tromey  <tom@tromey.com>
2134
2135         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2136         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2137         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2138         * parser-defs.h (paren_depth): Don't declare.
2139         * parse.c (paren_depth): Remove global.
2140         (parse_exp_in_context): Update.
2141         * p-exp.y (paren_depth): New global.
2142         (pascal_parse): Initialize it.
2143         * m2-exp.y (paren_depth): New global.
2144         (m2_parse): Initialize it.
2145         * go-exp.y (paren_depth): New global.
2146         (go_parse): Initialize it.
2147         * f-exp.y (paren_depth): New global.
2148         (f_parse): Initialize it.
2149         * d-exp.y (paren_depth): New global.
2150         (d_parse): Initialize it.
2151         * c-exp.y (paren_depth): New global.
2152         (c_parse): Initialize it.
2153         * ada-lex.l (paren_depth): New global.
2154         (lexer_init): Initialize it.
2155
2156 2019-04-04  Tom Tromey  <tom@tromey.com>
2157
2158         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2159         (rust_parser::convert_ast_to_type)
2160         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2161         * parser-defs.h (struct parser_state) <parser_state>: Add
2162         parameters.  Initialize new members.
2163         <expression_context_block, expression_context_pc>: New members.
2164         * parse.c (expression_context_block, expression_context_pc):
2165         Remove globals.
2166         (parse_exp_in_context): Update.
2167         * p-exp.y: Update all rules.
2168         (yylex): Update.
2169         * m2-exp.y: Update all rules.
2170         (yylex): Update.
2171         * go-exp.y (yylex): Update.
2172         * f-exp.y (yylex): Update.
2173         * d-exp.y: Update all rules.
2174         (yylex): Update.
2175         * c-exp.y: Update all rules.
2176         (lex_one_token, classify_name, yylex, c_parse): Update.
2177         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2178
2179 2019-04-04  Tom Tromey  <tom@tromey.com>
2180
2181         * gdbarch.h, gdbarch.c: Rebuild.
2182         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2183         * stap-probe.h:
2184         (struct stap_parse_info): Replace "parser_state" with
2185         "expr_builder".
2186         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2187         (parser_state): New class.
2188         * parse.c (expr_builder): Rename.
2189         (expr_builder::release): Rename.
2190         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2191         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2192         (write_exp_elt_longcst, write_exp_elt_floatcst)
2193         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2194         (write_exp_string_vector, write_exp_bitstring)
2195         (write_exp_msymbol, mark_struct_expression)
2196         (write_dollar_variable)
2197         (insert_type_address_space, increase_expout_size): Replace
2198         "parser_state" with "expr_builder".
2199         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2200         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2201         "parser_state" with "expr_builder".
2202
2203 2019-04-04  Tom Tromey  <tom@tromey.com>
2204
2205         * rust-exp.y: Replace "parse_language" with method call.
2206         * p-exp.y:
2207         (yylex): Replace "parse_language" with method call.
2208         * m2-exp.y:
2209         (yylex): Replace "parse_language" with method call.
2210         * go-exp.y (classify_name): Replace "parse_language" with method
2211         call.
2212         * f-exp.y (yylex): Replace "parse_language" with method call.
2213         * d-exp.y (lex_one_token): Replace "parse_language" with method
2214         call.
2215         * c-exp.y:
2216         (lex_one_token, classify_name, yylex): Replace "parse_language"
2217         with method call.
2218         * ada-exp.y (find_primitive_type, type_char)
2219         (type_system_address): Replace "parse_language" with method call.
2220
2221 2019-04-04  Tom Tromey  <tom@tromey.com>
2222
2223         * rust-exp.y: Replace "parse_gdbarch" with method call.
2224         * parse.c (write_dollar_variable, insert_type_address_space):
2225         Replace "parse_gdbarch" with method call.
2226         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2227         call.
2228         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2229         call.
2230         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2231         "parse_gdbarch" with method call.
2232         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2233         with method call.
2234         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2235         "parse_gdbarch" with method call.
2236         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2237         "parse_gdbarch" with method call.
2238         * c-exp.y (parse_type, parse_number, classify_name): Replace
2239         "parse_gdbarch" with method call.
2240         * ada-lex.l: Replace "parse_gdbarch" with method call.
2241         * ada-exp.y (parse_type, find_primitive_type, type_char)
2242         (type_system_address): Replace "parse_gdbarch" with method call.
2243
2244 2019-04-04  Tom Tromey  <tom@tromey.com>
2245
2246         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2247         * stap-probe.c (stap_parse_argument): Update.
2248         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2249         initial_size parameter.
2250         * rust-exp.y (rust_lex_tests): Update.
2251         * parse.c (parser_state): Update.
2252         (parse_exp_in_context): Update.
2253         * parser-defs.h (struct parser_state) <parser_state>: Remove
2254         "initial_size" parameter.
2255
2256 2019-04-04  Tom Tromey  <tom@tromey.com>
2257
2258         * parser-defs.h (increase_expout_size): Don't declare.
2259         * parse.c (increase_expout_size): Now static.
2260
2261 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2262
2263         * gnu-nat.c (gnu_nat_target::wait): Fix
2264         target_waitstatus_to_string call.
2265
2266 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * eval.c (evaluate_subexp_standard): Handle internal functions
2269         during Fortran function call handling.
2270
2271 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2272
2273         * NEWS: Mention new internal functions.
2274         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2275         (read_base_type): Use dwarf2_init_complex_target_type.
2276         * value.c (creal_internal_fn): New function.
2277         (cimag_internal_fn): New function.
2278         (_initialize_values): Register new internal functions.
2279
2280 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2281
2282         * infrun.c (stop_all_threads): If debug_infrun, always
2283         trace the wait status after wait_one, using
2284         target_waitstatus_to_string and target_pid_to_str.
2285         (handle_inferior_event): Replace various trace of
2286         wait status kind by a single trace.
2287         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2288         wait status kind image by target_waitstatus_to_string.
2289         * target/waitstatus.c (target_waitstatus_to_string): Fix
2290         obsolete comment.
2291
2292 2019-04-01  Tom Tromey  <tromey@adacore.com>
2293
2294         PR symtab/23331:
2295         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2296
2297 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2298             Pedro Alves  <palves@redhat.com>
2299
2300         * top.c (quit_force): Call 'finalize_values'.
2301         * value.c (finalize_values): New function.
2302         * value.h (finalize_values): Declare.
2303
2304 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2305
2306         * NEWS: Announce $_gdb_major and $_gdb_minor.
2307
2308         * top.c (init_gdb_version_vars): New function.
2309         (gdb_init): Call init_gdb_version_vars.
2310
2311 2019-03-29  Tom Tromey  <tromey@adacore.com>
2312
2313         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2314         help text.  Remove dead code.
2315
2316 2019-03-29  Keith Seitz  <keiths@redhat.com>
2317
2318         From Siddhesh Poyarekar:
2319         * f-lang.h (f77_get_upperbound): Return LONGEST.
2320         (f77_get_lowerbound): Likewise.
2321         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2322         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2323         print them.
2324         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2325         plongest to format print it.
2326         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2327         (f77_get_upperbound): Likewise.
2328         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2329         LOWER_BOUND to LONGEST.
2330         (f77_create_arrayprint_offset_tbl): Likewise.
2331
2332 2019-03-29  Keith Seitz  <keiths@redhat.com>
2333
2334         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2335         %s/pulongest for TYPE_LENGTH instead of %d in format
2336         strings.
2337         * ada-typerint.c (ada_print_type): Likewise.
2338         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2339         * compile/compile-c-support.c (generate_register_struct): Likewise.
2340         * gdbtypes.c (recursive_dump_type): Likewise.
2341         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2342         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2343         instead of %d in format strings.
2344         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2345         to std::min to ULONGEST.
2346         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2347         instead of %d in format strings.
2348         * tracepoint.c (info_scope_command): Likewise.
2349         * typeprint.c (print_offset_data::update)
2350         (print_offset_data::finish): Likewise.
2351         * xtensa-tdep.c (xtensa_store_return_value)
2352         (xtensa_push_dummy_call): Likewise.
2353
2354 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2355
2356         * windows-nat.c (display_selector): Fixed format specifications
2357         for 64-bit Cygwin.
2358
2359 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2360
2361         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2362
2363 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2364
2365         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2366         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2367         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2368         (nios2_linux_init_abi): Install it.
2369
2370 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2371
2372         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2373
2374 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2375
2376         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2377
2378 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2379             Tom Tromey  <tromey@adacore.com>
2380
2381         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2382
2383 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2384
2385         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2386         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2387         method to compute the bounds of range types. Also print "[evaluated]"
2388         if the bounds' values come from a dynamic evaluation.
2389
2390 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2393         whitespace when pretty printing is on.
2394
2395 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2396
2397         * ppc-linux-nat.c: Add include.
2398
2399 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2400
2401         * NEWS: Mention AArch64 Pointer Authentication.
2402
2403 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2404
2405         * arm-linux-nat.c: Add include.
2406
2407 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2408
2409         * source-cache.c (source_cache::get_source_lines): Re-read
2410         fullname after calling open_source_file.
2411
2412 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2413
2414         * NEWS: Mention TLS support for FreeBSD.
2415
2416 2019-03-25  Tom Tromey  <tromey@adacore.com>
2417
2418         * minsyms.c (BUNCH_SIZE): Update comment.
2419         (~minimal_symbol_reader): Remove old comment.
2420         (compact_minimal_symbols): Update comment.
2421         (minimal_symbol_reader::install): Remove old comment.  Update
2422         other comments.
2423
2424 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2425
2426         * s390-linux-nat.c: Add include.
2427
2428 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2429
2430         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2431         Call linux_get_hwcap.
2432         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2433         Likewise.
2434         (aarch64_linux_get_hwcap): Remove function.
2435         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2436         declaration.
2437         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2438         linux_get_hwcap.
2439         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2440         * linux-tdep.c (linux_get_hwcap): Add function.
2441         (linux_get_hwcap2): Likewise.
2442         * linux-tdep.h (linux_get_hwcap): Add declaration.
2443         (linux_get_hwcap2): Likewise.
2444         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2445         (ppc_linux_get_hwcap2): Likewise.
2446         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2447         linux_get_hwcap.
2448         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2449         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2450         (ppc_linux_nat_target::read_description): Likewise.
2451         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2452         * s390-linux-nat.c: Likewise.
2453         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2454
2455 2019-03-24  Tom Tromey  <tom@tromey.com>
2456
2457         * ada-lang.c (standard_lookup): Simplify initialization.
2458         (ada_lookup_symbol_nonlocal): Simplify return.
2459         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2460         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2461         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2462         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2463         initialization.
2464         * solib.c (solib_global_lookup): Simplify.
2465         * symtab.c (null_block_symbol): Remove.
2466         (symbol_cache_lookup): Simplify returns.
2467         (lookup_language_this): Simplify returns.
2468         (lookup_symbol_aux): Simplify return.
2469         (lookup_local_symbol): Simplify returns.
2470         (lookup_global_symbol_from_objfile): Simplify return.
2471         (lookup_symbol_in_objfile_symtabs)
2472         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2473         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2474         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2475         * cp-namespace.c (cp_lookup_bare_symbol)
2476         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2477         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2478         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2479         (cp_lookup_symbol_via_imports): Simplify initialization.
2480         (find_symbol_in_baseclass): Likewise.
2481         * symtab.h (null_block_symbol): Remove.
2482         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2483         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2484         (d_lookup_symbol_module): Likewise.
2485         (find_symbol_in_baseclass): Simplify initialization.
2486
2487 2019-03-24  Tom Tromey  <tom@tromey.com>
2488
2489         * expression.h: Don't include symtab.h.
2490         (struct block): Forward declare.
2491
2492 2019-03-24  Tom Tromey  <tom@tromey.com>
2493
2494         * c-exp.y (typebase): Remove casts.
2495         * gdbtypes.c (lookup_unsigned_typename, )
2496         (lookup_signed_typename): Remove cast.
2497         * eval.c (parse_to_comma_and_eval): Remove cast.
2498         * parse.c (write_dollar_variable): Remove cast.
2499         * block.h (struct block) <superblock>: Now const.
2500         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2501         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2502         (map_block): Make "block" const.
2503         * symfile.h (struct quick_symbol_functions)
2504         <map_matching_symbols>: Constify block argument to "callback".
2505         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2506         const.
2507         (find_pc_sect_compunit_symtab): Make "b" const.
2508         (find_symbol_at_address): Likewise.
2509         (search_symbols): Likewise.
2510         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2511         (dw2_debug_names_lookup_symbol): Likewise.
2512         (dw2_map_matching_symbols): Update.
2513         * p-valprint.c (pascal_val_print): Remove "block".
2514         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2515         (aux_add_nonlocal_symbols): Make "block" const.
2516         (resolve_subexp): Remove cast.
2517         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2518         const.
2519         (iterate_over_file_blocks): Likewise.
2520         * f-exp.y (%union) <bval>: Remove.
2521         * coffread.c (patch_opaque_types): Make "b" const.
2522         * spu-tdep.c (spu_catch_start): Make "block" const.
2523         * c-valprint.c (print_unpacked_pointer): Remove "block".
2524         * symmisc.c (dump_symtab_1): Make "b" const.
2525         (block_depth): Make "block" const.
2526         * d-exp.y (%union) <bval>: Remove.
2527         * cp-support.h (cp_lookup_rtti_type): Update.
2528         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2529         * psymtab.c (psym_lookup_symbol): Make "block" const.
2530         (maintenance_check_psymtabs): Make "b" const.
2531         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2532         (enumerate_locals, enumerate_args): Update.
2533         * python/py-symtab.c (stpy_global_block): Make "block" const.
2534         (stpy_static_block): Likewise.
2535         * inline-frame.c (block_starting_point_at): Make "new_block"
2536         const.
2537         * block.c (find_block_in_blockvector): Make return type const.
2538         (blockvector_for_pc_sect): Make "b" const.
2539         (find_block_in_blockvector): Make "b" const.
2540
2541 2019-03-23  Tom Tromey  <tom@tromey.com>
2542
2543         * varobj.c (varobj_create): Update.
2544         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2545         * printcmd.c (display_command, do_one_display): Don't reset
2546         innermost_block.
2547         * parser-defs.h (enum innermost_block_tracker_type): Move to
2548         expression.h.
2549         (innermost_block): Update comment.
2550         * parse.c (parse_exp_1): Add tracker_types parameter.
2551         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2552         tracker_types parameter.  Reset innermost_block.
2553         (parse_exp_in_context): Remove.
2554         (parse_expression_for_completion): Update.
2555         * objfiles.c (~objfile): Don't reset expression_context_block or
2556         innermost_block.
2557         * expression.h (enum innermost_block_tracker_type): Move from
2558         parser-defs.h.
2559         (parse_exp_1): Add tracker_types parameter.
2560         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2561         reset innermost_block.
2562
2563 2019-03-23  Tom Tromey  <tom@tromey.com>
2564
2565         * objfiles.h: Include bcache.h.
2566
2567 2019-03-23  Tom Tromey  <tom@tromey.com>
2568
2569         * linespec.c (get_current_search_block): Use
2570         scoped_restore_current_language.
2571         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2572
2573 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2574             Jiong Wang  <jiong.wang@arm.com>
2575
2576         * aarch64-linux-tdep.c
2577         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2578         section.
2579         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2580
2581 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2582             Jiong Wang  <jiong.wang@arm.com>
2583
2584         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2585         instructions.
2586         (aarch64_analyze_prologue_test): Add PACIASP test.
2587         (aarch64_prologue_prev_register): Unmask PC value.
2588
2589 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2590             Jiong Wang  <jiong.wang@arm.com>
2591
2592         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2593         (aarch64_dwarf2_prev_register): Unmask PC value.
2594         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2595         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2596         DW_CFA_AARCH64_negate_ra_state.
2597         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2598
2599 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2600             Jiong Wang  <jiong.wang@arm.com>
2601
2602         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2603         registers.
2604         (aarch64_pseudo_register_name): Likewise.
2605         (aarch64_pseudo_register_type): Likewise.
2606         (aarch64_pseudo_register_reggroup_p): Likewise.
2607         (aarch64_gdbarch_init): Add pauth registers.
2608         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2609         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2610         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2611         (struct gdbarch_tdep): Add regnum for ra_state.
2612
2613 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2614             Jiong Wang  <jiong.wang@arm.com>
2615
2616         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2617
2618 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2619             Jiong Wang  <jiong.wang@arm.com>
2620
2621         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2622         function.
2623         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2624         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2625         (aarch64_gdbarch_init): Add puth registers.
2626         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2627         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2628         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2629
2630 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2631             Jiong Wang  <jiong.wang@arm.com>
2632
2633         * aarch64-linux-nat.c
2634         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2635         * aarch64-linux-tdep.c
2636         (aarch64_linux_core_read_description): Likewise.
2637         (aarch64_linux_get_hwcap): New function.
2638         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2639         (aarch64_linux_get_hwcap): New declaration.
2640
2641 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2642             Jiong Wang  <jiong.wang@arm.com>
2643
2644         * aarch64-linux-nat.c
2645         (aarch64_linux_nat_target::read_description): Add pauth param.
2646         * aarch64-linux-tdep.c
2647         (aarch64_linux_core_read_description): Likewise.
2648         * aarch64-tdep.c (struct target_desc): Add in pauth.
2649         (aarch64_read_description): Add pauth param.
2650         (aarch64_gdbarch_init): Likewise.
2651         * aarch64-tdep.h (aarch64_read_description): Likewise.
2652         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2653         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2654         * features/Makefile: Add new files.
2655         * features/aarch64-pauth.c: New file.
2656         * features/aarch64-pauth.xml: New file.
2657
2658 2019-03-20  Tom Tromey  <tromey@adacore.com>
2659
2660         * infrun.c (handle_inferior_event): Rename from
2661         handle_inferior_event_1.  Create a scoped_value_mark.
2662         (handle_inferior_event): Remove.
2663
2664 2019-03-19  Tom Tromey  <tromey@adacore.com>
2665
2666         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2667         * infrun.h (print_stop_event): Add "displays" parameter.
2668         * infrun.c (print_stop_event): Add "displays" parameter.
2669
2670 2019-03-19  Pedro Alves  <palves@redhat.com>
2671
2672         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2673         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2674         to -1.  Fix TABs vs spaces.
2675         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2676         * tui/tui-out.h (tui_ui_out) Add intro comments.
2677         <m_line, m_start_of_line>: In-class initialize, and add describing
2678         comment.
2679
2680 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2681
2682         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2683         variable names.
2684         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2685
2686 2019-03-18  Pedro Alves  <palves@redhat.com>
2687             Eli Zaretskii <eliz@gnu.org>
2688
2689         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2690         m_line and m_start_of_line.
2691
2692 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2693
2694         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2695         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2696         it returns a newline.  This fixes a regression in TU mode, whereby
2697         the next line is output on the same screen line as the user input.
2698
2699 2019-03-18  Tom Tromey  <tromey@adacore.com>
2700
2701         * minsyms.c (minimal_symbol_reader::install): Remove call to
2702         obstack_blank.
2703
2704 2019-03-18  Pedro Alves  <palves@redhat.com>
2705
2706         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2707         New globals.
2708         (apply_style): New, factored out from ...
2709         (apply_ansi_escape): ... this.  Handle reverse video mode.
2710         (tui_set_reverse_mode): New function.
2711         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2712         * tui/tui-winsource.c (tui_show_source_line): Use
2713         tui_set_reverse_mode instead of setting A_STANDOUT.
2714         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2715         New setter methods.
2716
2717 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2718
2719         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2720         Handle tabs.
2721
2722 2019-03-18  Tom Tromey  <tromey@adacore.com>
2723
2724         * ada-lang.c (empty_array): Add "high" parameter.
2725         (ada_evaluate_subexp): Update.
2726
2727 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2728
2729         * unittests/string_view-selftests.c: Define
2730         _initialize_string_view_selftests unconditionally.
2731
2732 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2733
2734         PR gdb/24350
2735         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2736
2737 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2738
2739         PR gdb/24351
2740         * windows-nat.c (display_selector): Fix format specifiers.
2741
2742 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2743
2744         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2745         tui_refill_source_window instead of tui_refresh_win, to update the
2746         current execution line.  This fixes redisplay of the current line
2747         when stepping through the code with "next" or "step".
2748
2749 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2750
2751         * source-cache.c (source_cache::get_source_lines): Call
2752         find_source_lines to initialize s->nlines.  This fixes vertical
2753         scrolling of TUI source window when the DOWN arrow is pressed.
2754
2755 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2756
2757         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2758         linux-thread-db.c (_initialize_thread_db): Likewise.
2759
2760 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2761
2762         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2763         wclrtoeol in tui_show_source_line".  This reverts changes made in
2764         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2765
2766 2019-03-15  Tom Tromey  <tom@tromey.com>
2767
2768         * symtab.h (struct minimal_symbol): Derive from
2769         general_symbol_info.
2770         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2771         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2772         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2773         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2774         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2775         (MSYMBOL_SEARCH_NAME): Update.
2776         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2777         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2778         * minsyms.c (minimal_symbol_reader::record_full): Update.
2779
2780 2019-03-15  Tom Tromey  <tom@tromey.com>
2781
2782         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2783
2784 2019-03-15  Tom Tromey  <tom@tromey.com>
2785
2786         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2787         unique_xmalloc_ptr.
2788         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2789         Update.
2790         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2791         (build_minimal_symbol_hash_tables)
2792         (minimal_symbol_reader::install): Update.
2793
2794 2019-03-15  Tom Tromey  <tom@tromey.com>
2795
2796         * symtab.c (create_demangled_names_hash): Update.
2797         (symbol_set_names): Update.
2798         * objfiles.h (struct objfile_per_bfd_storage)
2799         <demangled_names_hash>: Now an htab_up.
2800         * objfiles.c (objfile_per_bfd_storage): Simplify.
2801
2802 2019-03-15  Tom Tromey  <tom@tromey.com>
2803
2804         * objfiles.h (struct objfile_per_bfd_storage): Declare
2805         destructor.
2806         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2807         New.
2808         (get_objfile_bfd_data): Use new.  Don't initialize
2809         language_of_main.
2810         (free_objfile_per_bfd_storage): Remove.
2811         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2812
2813 2019-03-15  Tom Tromey  <tom@tromey.com>
2814
2815         * symfile.c (reread_symbols): Update.
2816         * objfiles.c (objfile::objfile): Update.
2817         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2818         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2819         comment.
2820         (minimal_symbol_reader::install): Update.
2821         (terminate_minimal_symbol_table): Remove.
2822         * jit.c (jit_object_close_impl): Update.
2823
2824 2019-03-15  Tom Tromey  <tom@tromey.com>
2825
2826         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2827         initializations.
2828
2829 2019-03-15  Tom Tromey  <tom@tromey.com>
2830
2831         * objfiles.h (struct objfile_per_bfd_storage)
2832         <demangled_hash_languages>: Now a bitset.
2833         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2834         (lookup_minimal_symbol): Update.
2835
2836 2019-03-15  Tom Tromey  <tom@tromey.com>
2837
2838         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2839         Don't return the symbol.
2840         * coffread.c (record_minimal_symbol): Use record_full.
2841
2842 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2843
2844         The MS-Windows port of ncurses fails to switch to a color pair if
2845         one or both of the colors are the implicit default colors.  This
2846         change records the default colors when TUI is initialized, and
2847         then specifies them explicitly when a color pair uses the default
2848         colors.  This allows color styling in TUI mode on MS-Windows.
2849
2850         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2851         ncurses_norm_attr.
2852         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2853         colors in ncurses_norm_attr.
2854         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2855         "none", replace it with the default color recorded in
2856         ncurses_norm_attr.
2857
2858 2019-03-14  Tom Tromey  <tromey@adacore.com>
2859
2860         * source-cache.h (class source_cache) <get_source_lines>: Return
2861         std::string.
2862         * source-cache.c (source_cache::extract_lines): Handle case where
2863         first_pos==npos.  Return std::string.
2864         (source_cache::get_source_lines): Update.
2865
2866 2019-03-14  Tom Tromey  <tromey@adacore.com>
2867
2868         * NEWS: Add item for "style sources" commands.
2869         * source-cache.c (source_cache::get_source_lines): Check
2870         source_styling.
2871         * cli/cli-style.c (source_styling): New global.
2872         (_initialize_cli_style): Add "style sources" commands.
2873         (show_style_sources): New function.
2874         * cli/cli-style.h (source_styling): Declare.
2875
2876 2019-03-14  Pedro Alves  <palves@redhat.com>
2877             Tom Tromey  <tromey@adacore.com>
2878
2879         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2880         * tui/tui-winsource.c (tui_refill_source_window): New function,
2881         from...
2882         (tui_horizontal_source_scroll): ... here.  Move some logic.
2883         * cli/cli-style.c (set_style_enabled): Notify new observable.
2884         * tui/tui-hooks.c (tui_redisplay_source): New function.
2885         (tui_attach_detach_observers): Attach or detach
2886         tui_redisplay_source.
2887         * observable.h (source_styling_changed): New observable.
2888         * observable.c: Define source_styling_changed observable.
2889
2890 2019-03-13  Tom Tromey  <tromey@adacore.com>
2891
2892         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2893         (i386_gnu_nat_target::store_registers): Update.
2894         * target-debug.h (target_debug_print_std_string): New macro.
2895         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2896         * windows-tdep.c (display_one_tib): Update.
2897         * tui/tui-stack.c (tui_make_status_line): Update.
2898         * top.c (print_inferior_quit_action): Update.
2899         * thread.c (thr_try_catch_cmd): Update.
2900         (add_thread_with_info): Update.
2901         (thread_target_id_str): Update.
2902         (thr_try_catch_cmd): Update.
2903         (thread_command): Update.
2904         (thread_find_command): Update.
2905         * record-btrace.c (record_btrace_target::info_record)
2906         (record_btrace_resume_thread, record_btrace_target::resume)
2907         (record_btrace_cancel_resume, record_btrace_step_thread)
2908         (record_btrace_target::wait, record_btrace_target::wait)
2909         (record_btrace_target::wait, record_btrace_target::stop): Update.
2910         * progspace.c (print_program_space): Update.
2911         * process-stratum-target.c
2912         (process_stratum_target::thread_address_space): Update.
2913         * linux-fork.c (linux_fork_mourn_inferior)
2914         (detach_checkpoint_command, info_checkpoints_command)
2915         (linux_fork_context): Update.
2916         (linux_fork_detach): Update.
2917         (class scoped_switch_fork_info): Update.
2918         (delete_checkpoint_command): Update.
2919         * infrun.c (follow_fork_inferior): Update.
2920         (follow_fork_inferior): Update.
2921         (proceed_after_vfork_done): Update.
2922         (handle_vfork_child_exec_or_exit): Update.
2923         (follow_exec): Update.
2924         (displaced_step_prepare_throw): Update.
2925         (displaced_step_restore): Update.
2926         (start_step_over): Update.
2927         (resume_1): Update.
2928         (clear_proceed_status_thread): Update.
2929         (proceed): Update.
2930         (print_target_wait_results): Update.
2931         (do_target_wait): Update.
2932         (context_switch): Update.
2933         (stop_all_threads): Update.
2934         (restart_threads): Update.
2935         (finish_step_over): Update.
2936         (handle_signal_stop): Update.
2937         (switch_back_to_stepped_thread): Update.
2938         (keep_going_pass_signal): Update.
2939         (print_exited_reason): Update.
2940         (normal_stop): Update.
2941         * inferior.c (inferior_pid_to_str): Change return type.
2942         (print_selected_inferior): Update.
2943         (add_inferior): Update.
2944         (detach_inferior): Update.
2945         * dummy-frame.c (fprint_dummy_frames): Update.
2946         * dcache.c (dcache_info_1): Update.
2947         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2948         (btrace_fetch, btrace_clear): Update.
2949         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2950         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2951         type.
2952         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2953         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2954         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2955         * gdbarch.c, gdbarch.h: Rebuild.
2956         * gdbarch.sh (core_pid_to_str): Change return type.
2957         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2958         return type.
2959         (windows_nat_target::pid_to_str): Change return type.
2960         (windows_delete_thread): Update.
2961         (windows_nat_target::attach): Update.
2962         (windows_nat_target::files_info): Update.
2963         * target-delegates.c: Rebuild.
2964         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2965         return type.
2966         (sol_thread_target::pid_to_str): Change return type.
2967         * remote.c (class remote_target) <pid_to_str>: Change return
2968         type.
2969         (remote_target::pid_to_str): Change return type.
2970         (extended_remote_target::attach, remote_target::remote_stop_ns)
2971         (remote_target::remote_notif_remove_queued_reply)
2972         (remote_target::push_stop_reply, remote_target::disable_btrace):
2973         Update.
2974         (extended_remote_target::attach): Update.
2975         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2976         type.
2977         (gdbsim_target::pid_to_str): Change return type.
2978         * ravenscar-thread.c (struct ravenscar_thread_target)
2979         <pid_to_str>: Change return type.
2980         (ravenscar_thread_target::pid_to_str): Change return type.
2981         * procfs.c (class procfs_target) <pid_to_str>: Change return
2982         type.
2983         (procfs_target::pid_to_str): Change return type.
2984         (procfs_target::attach): Update.
2985         (procfs_target::detach): Update.
2986         (procfs_target::fetch_registers): Update.
2987         (procfs_target::store_registers): Update.
2988         (procfs_target::wait): Update.
2989         (procfs_target::files_info): Update.
2990         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2991         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2992         return type.
2993         (nto_procfs_target::pid_to_str): Change return type.
2994         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2995         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2996         return type.
2997         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2998         (exit_lwp): Update.
2999         (attach_proc_task_lwp_callback, get_detach_signal)
3000         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3001         (linux_nat_target::resume, wait_lwp, stop_callback)
3002         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3003         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3004         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3005         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3006         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3007         type.
3008         (inf_ptrace_target::attach): Update.
3009         (inf_ptrace_target::files_info): Update.
3010         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3011         type.
3012         (go32_nat_target::pid_to_str): Change return type.
3013         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3014         (gnu_nat_target::wait): Update.
3015         (gnu_nat_target::wait): Update.
3016         (gnu_nat_target::resume): Update.
3017         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3018         (fbsd_nat_target::wait): Update.
3019         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3020         type.
3021         (darwin_nat_target::attach): Update.
3022         * corelow.c (class core_target) <pid_to_str>: Change return type.
3023         (core_target::pid_to_str): Change return type.
3024         * target.c (normal_pid_to_str): Change return type.
3025         (default_pid_to_str): Likewise.
3026         (target_pid_to_str): Change return type.
3027         (target_translate_tls_address): Update.
3028         (target_announce_detach): Update.
3029         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3030         return type.
3031         (bsd_uthread_target::pid_to_str): Change return type.
3032         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3033         type.
3034         (bsd_kvm_target::pid_to_str): Change return type.
3035         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3036         return type.
3037         (aix_thread_target::pid_to_str): Change return type.
3038         * target.h (struct target_ops) <pid_to_str>: Change return type.
3039         (target_pid_to_str, normal_pid_to_str): Likewise.
3040         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3041         type.
3042         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3043         type.
3044         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3045         return type.
3046         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3047         type.
3048         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3049         type.
3050         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3051         return type.
3052
3053 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3054
3055         * NEWS: Mention that the new default MI version is 3.  Mention
3056         changes to the output of commands and events that deal with
3057         multi-location breakpoints.
3058         * breakpoint.c: Include "mi/mi-out.h".
3059         (print_one_breakpoint): Change output syntax if using MI version
3060         >= 3.
3061         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3062         New.
3063         (mi_multi_location_breakpoint_output_fixed): New.
3064         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3065         (mi_cmd_fix_multi_location_breakpoint_output): New.
3066         (mi_multi_location_breakpoint_output_fixed): New.
3067         * mi/mi-cmds.c (mi_cmds): Register command
3068         -fix-multi-location-breakpoint-output.
3069         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3070         interpreter "mi".
3071
3072 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3073
3074         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3075         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3076         instantiate mi_ui_out based on interpreter name.
3077         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3078         * mi/mi-main.c (mi_load_progress): Likewise.
3079
3080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3081
3082         * NEWS: Combine separate "New targets" sections for 8.3.
3083
3084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3085
3086         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3087         (ppcfbsd_init_abi): Install gdbarch
3088         "fetch_tls_load_module_address" and "get_thread_local_address"
3089         methods.
3090
3091 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3092
3093         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3094         (riscv_fbsd_init_abi): Install gdbarch
3095         "fetch_tls_load_module_address" and "get_thread_local_address"
3096         methods.
3097
3098 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3099
3100         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3101         (i386fbsd_init_abi): Install gdbarch
3102         "fetch_tls_load_module_address" and "get_thread_local_address"
3103         methods.
3104
3105 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3106
3107         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3108         (amd64fbsd_init_abi): Install gdbarch
3109         "fetch_tls_load_module_address" and "get_thread_local_address"
3110         methods.
3111
3112 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3113
3114         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3115         (struct fbsd_pspace_data): New type.
3116         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3117         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3118         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3119         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3120         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3121
3122 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3123
3124         * gdbtypes.c (lookup_struct_elt): New function.
3125         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3126         * gdbtypes.h (struct struct_elt): New type.
3127         (lookup_struct_elt): New prototype.
3128
3129 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3130
3131         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3132         remove disabled code block.
3133
3134 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3135
3136         * gdbarch.sh (get_thread_local_address): New method.
3137         * gdbarch.h, gdbarch.c: Regenerate.
3138         * target.c (target_translate_tls_address): Use
3139         gdbarch_get_thread_local_address if present instead of
3140         target::get_thread_local_address.
3141
3142 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3143
3144         * target.h (target::get_thread_local_address): Update comment.
3145
3146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3147
3148         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3149         objfile->separate_debug_objfile_backlink if not NULL.
3150
3151 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3152
3153         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3154         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3155         (amd64bsd_store_inferior_registers): Likewise.
3156         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3157         Enable segment base registers.
3158         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3159         PT_GETFSBASE and PT_GETGSBASE.
3160         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3161         PT_SETGSBASE.
3162         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3163         segment base registers.
3164         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3165
3166 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3167
3168         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3169         Update calls to i386_target_description to add 'segments'
3170         parameter.
3171         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3172         add segment base registers.
3173         * arch/i386.c (i386_create_target_description): Add 'segments'
3174         parameter to enable segment base registers.
3175         * arch/i386.h (i386_create_target_description): Likewise.
3176         * features/i386/32bit-segments.xml: New file.
3177         * features/i386/32bit-segments.c: Generate.
3178         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3179         call to i386_target_description to add 'segments' parameter.
3180         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3181         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3182         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3183         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3184         if feature is present.
3185         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3186         Add 'segments' parameter to call to i386_target_description.
3187         (i386_target_description): Add 'segments' parameter to enable
3188         segment base registers.
3189         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3190         to call to i386_target_description.
3191         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3192         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3193         Define I386_NUM_REGS.
3194         (i386_target_description): Add 'segments' parameter to enable
3195         segment base registers.
3196
3197 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3198
3199         PR/24325
3200         * source-cache.c: #undef open and close, to avoid unresolved
3201         externals during linking.
3202
3203 2019-03-12  Tom Tromey  <tromey@adacore.com>
3204
3205         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3206         const.  Add initializers.
3207         (_initialize_remote): Don't initialize ptid globals.
3208
3209 2019-03-12  Pedro Alves  <palves@redhat.com>
3210
3211         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3212
3213 2019-03-12  Pedro Alves  <palves@redhat.com>
3214
3215         * cp-name-parser.y (main): Remove unused 'len' variable.
3216
3217 2019-03-12  Tom Tromey  <tromey@adacore.com>
3218
3219         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3220         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3221
3222 2019-03-12  Tom Tromey  <tromey@adacore.com>
3223
3224         * linux-nat.c (iterate_over_lwps): Update.
3225         (stop_callback): Remove parameter.
3226         (stop_wait_callback, detach_callback, resume_set_callback)
3227         (select_singlestep_lwp_callback, set_ignore_sigint)
3228         (status_callback, resumed_callback, resume_clear_callback)
3229         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3230         data parameter.
3231         (linux_nat_target::detach, linux_nat_target::resume)
3232         (linux_stop_and_wait_all_lwps, select_event_lwp)
3233         (linux_nat_filter_event, linux_nat_wait_1)
3234         (linux_nat_target::kill, linux_nat_target::stop)
3235         (linux_nat_target::stop): Update.
3236         (linux_nat_resume_callback): Change type.
3237         (resume_stopped_resumed_lwps, count_events_callback)
3238         (select_event_lwp_callback): Likewise.
3239         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3240         * arm-linux-nat.c (struct update_registers_data): Remove.
3241         (update_registers_callback): Change type.
3242         (arm_linux_insert_hw_breakpoint1): Update.
3243         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3244         parameter.
3245         (x86_linux_dr_set_addr): Update.
3246         (x86_linux_dr_set_control): Update.
3247         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3248         (iterate_over_lwps): Use gdb::function_view.
3249         * nat/aarch64-linux-hw-point.c (struct
3250         aarch64_dr_update_callback_param): Remove.
3251         (debug_reg_change_callback): Change type.
3252         (aarch64_notify_debug_reg_change): Update.
3253         * s390-linux-nat.c (s390_refresh_per_info): Update.
3254
3255 2019-03-11  Tom Tromey  <tromey@adacore.com>
3256
3257         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3258         redundant assignment to "this_cu".
3259
3260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3261
3262         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3263
3264 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3265
3266         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3267         from...
3268         (rank_one_type): ... this.
3269
3270 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3271
3272         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3273         from...
3274         (rank_one_type): ... this.
3275
3276 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3277
3278         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3279         from...
3280         (rank_one_type): ... this.
3281
3282 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3283
3284         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3285         from...
3286         (rank_one_type): ... this.
3287
3288 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3289
3290         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3291         from...
3292         (rank_one_type): ... this.
3293
3294 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3295
3296         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3297         from...
3298         (rank_one_type): ... this.
3299
3300 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3301
3302         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3303         from...
3304         (rank_one_type): ... this.
3305
3306 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3307
3308         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3309         from...
3310         (rank_one_type): ... this.
3311
3312 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3313
3314         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3315         from...
3316         (rank_one_type): ... this.
3317
3318 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3319
3320         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3321         from...
3322         (rank_one_type): ... this.
3323
3324 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3325
3326         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3327         from...
3328         (rank_one_type): ... this.
3329
3330 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3331
3332         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3333         from...
3334         (rank_one_type): ... this.
3335
3336 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3337
3338         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3339         inferior-events' shows the example events.
3340
3341 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3342
3343         Support styling on native MS-Windows console
3344
3345         PR/24315
3346         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3347         on MS-Windows if $TERM is not defined.
3348
3349         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3350
3351         * posix-hdep.c (gdb_console_fputs):
3352         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3353         functions.
3354         * ui-file.h (gdb_console_fputs): Add prototype.
3355
3356         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3357         back to fputs only if the former returns zero.
3358
3359 2019-03-07  Tom Tromey  <tom@tromey.com>
3360
3361         * symmisc.c (print_symbol_bcache_statistics): Update.
3362         (print_objfile_statistics): Update.
3363         * symfile.c (allocate_symtab): Update.
3364         * stabsread.c: Don't include bcache.h.
3365         * psymtab.h (struct psymbol_bcache): Don't declare.
3366         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3367         (psymbol_bcache_init, psymbol_bcache_free)
3368         (psymbol_bcache_get_bcache): Don't declare.
3369         * psymtab.c (struct psymbol_bcache): Remove.
3370         (psymtab_storage::psymtab_storage): Update.
3371         (psymtab_storage::~psymtab_storage): Update.
3372         (psymbol_bcache_init, psymbol_bcache_free)
3373         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3374         (add_psymbol_to_bcache): Update.
3375         (allocate_psymtab): Update.
3376         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3377         macro_cache>: No longer pointers.
3378         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3379         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3380         * macrotab.c (macro_bcache): Update.
3381         * macroexp.c: Don't include bcache.h.
3382         * gdbtypes.c (check_types_worklist): Update.
3383         (types_deeply_equal): Remove TRY/CATCH.  Update.
3384         * elfread.c (elf_symtab_read): Update.
3385         * dwarf2read.c: Don't include bcache.h.
3386         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3387         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3388         (print_bcache_statistics, bcache_memory_used): Don't declare.
3389         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3390         methods.  Rename all data members.
3391         * bcache.c (struct bcache): Move to bcache.h.
3392         (bcache::expand_hash_table): Rename from expand_hash_table.
3393         (bcache): Remove.
3394         (bcache::insert): Rename from bcache_full.
3395         (bcache::compare): Rename from bcache_compare.
3396         (bcache_xmalloc): Remove.
3397         (bcache::~bcache): Rename from bcache_xfree.
3398         (bcache::print_statistics): Rename from print_bcache_statistics.
3399         (bcache::memory_used): Rename from bcache_memory_used.
3400
3401 2019-03-07  Pedro Alves  <palves@redhat.com>
3402
3403         * infrun.c (normal_stop): Also check for
3404         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3405
3406 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3407
3408         * f-lang.c (value_from_host_double): Moved to...
3409         * value.c (value_from_host_double): ...here.
3410         * value.h (value_from_host_double): Declare.
3411         * guile/scm-math.c (vlscm_convert_typed_number): Use
3412         value_from_host_double.
3413         (vlscm_convert_number): Likewise.
3414         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3415         * python/py-value.c (convert_value_from_python): Likewise.
3416
3417 2019-03-06  Tom Tromey  <tom@tromey.com>
3418
3419         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3420
3421 2019-03-06  Tom Tromey  <tom@tromey.com>
3422
3423         * utils.h (free_current_contents): Don't declare.
3424         * utils.c (free_current_contents): Remove.
3425
3426 2019-03-06  Tom Tromey  <tom@tromey.com>
3427
3428         * top.c (quit_force): Update.
3429         * main.c (captured_command_loop): Update.
3430         * common/new-op.c (operator new): Update.
3431         * common/common-exceptions.c (struct catcher)
3432         <save_cleanup_chain>: Remove member.
3433         (exceptions_state_mc_init): Update.
3434         (exception_try_scope_entry): Return nullptr.
3435         (exception_try_scope_exit, exception_rethrow)
3436         (throw_exception_sjlj, throw_exception_cxx): Update.
3437         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3438         (all_cleanups, do_cleanups, discard_cleanups)
3439         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3440         (restore_cleanups, restore_final_cleanups): Don't declare.
3441         (do_final_cleanups): Remove parameter.
3442         * common/cleanups.c (cleanup_chain, make_cleanup)
3443         (make_cleanup_dtor, all_cleanups, do_cleanups)
3444         (discard_my_cleanups, discard_cleanups)
3445         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3446         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3447         (null_cleanup): Remove.
3448         (do_final_cleanups): Remove parameter.
3449
3450 2019-03-06  Tom Tromey  <tom@tromey.com>
3451
3452         * remote.c (remote_target::remote_parse_stop_reply): Use
3453         unique_xmalloc_ptr.
3454
3455 2019-03-06  Tom Tromey  <tom@tromey.com>
3456
3457         * stabsread.c (struct stabs_field_info): Rename from field_info.
3458         <list, fnlist>: Add initializers.
3459         <obstack>: New member.
3460         (read_member_functions, read_struct_fields, read_baseclasses):
3461         Allocate on obstack.  Don't use cleanups.
3462         (read_one_struct_field, read_member_functions, read_struct_fields)
3463         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3464         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3465         (read_struct_type): Update.
3466
3467 2019-03-06  Tom Tromey  <tom@tromey.com>
3468
3469         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3470         * common/filestuff.h (make_cleanup_close): Don't declare.
3471         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3472         Remove.
3473
3474 2019-03-06  Tom Tromey  <tom@tromey.com>
3475
3476         * solib-aix.c: Use make_scope_exit.
3477
3478 2019-03-06  Tom Tromey  <tom@tromey.com>
3479
3480         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3481         Use make_scope_exit.
3482
3483 2019-03-06  Tom Tromey  <tom@tromey.com>
3484
3485         * solib-svr4.c (disable_probes_interface): Remove parameter.
3486         (svr4_handle_solib_event): Use make_scope_exit.
3487
3488 2019-03-06  Tom Tromey  <tom@tromey.com>
3489
3490         * remote.c (struct stop_reply_deleter): Remove.
3491         (stop_reply_up): Update.
3492         (struct stop_reply): Derive from notif_event.  Don't typedef.
3493         <regcache>: Now a std::vector.
3494         (stop_reply_xfree): Remove.
3495         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3496         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3497         (remote_target::discard_pending_stop_replies): Use delete.
3498         (remote_target::remote_parse_stop_reply): Update.
3499         (remote_target::process_stop_reply): Update.
3500         * remote-notif.h (struct notif_event): Add virtual destructor.
3501         Remove "dtr" member.
3502         (struct notif_client) <alloc_event>: Return a unique_ptr.
3503         (notif_event_xfree): Don't declare.
3504         (notif_event_up): New typedef.
3505         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3506         (notif_event_xfree, do_notif_event_xfree): Remove.
3507         (remote_notif_state_xfree): Update.
3508
3509 2019-03-06  Tom Tromey  <tom@tromey.com>
3510
3511         * infrun.c (displaced_step_clear_cleanup): Now a
3512         forward_scope_exit type.
3513         (displaced_step_prepare_throw): Update.
3514         (displaced_step_fixup): Update.
3515
3516 2019-03-06  Tom Tromey  <tom@tromey.com>
3517
3518         * inferior.h (class inferior): Update comment.
3519         * gdbthread.h (class thread_info): Update comment.
3520
3521 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3522             Tom Tromey  <tom@tromey.com>
3523
3524         * stabsread.h (struct stab_section_list): Remove.
3525         (coffstab_build_psymtabs): Update.
3526         * dbxread.c (symbuf_sections): Now a std::vector.
3527         (sect_idx): New global.
3528         (fill_symbuf): Update.
3529         (coffstab_build_psymtabs): Change type of stabsects parameter.
3530         Update.
3531         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3532         std::vector.
3533         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3534         (coff_locate_sections): Update.
3535         (coff_symfile_read): Remove cleanups.  Update.
3536         (init_stringtab): Add storage parameter.
3537         (free_stringtab, free_stringtab_cleanup): Remove.
3538         (init_lineno): Add storage parameter.
3539         (free_linetab, free_linetab_cleanup): Remove.
3540
3541 2019-03-06  Pedro Alves  <palves@redhat.com>
3542
3543         * linux-fork.c (fork_info::clobber_regs): Delete.
3544         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3545         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3546         comment.  Adjust.
3547         (scoped_switch_fork_info::scoped_switch_fork_info)
3548         (checkpoint_command, linux_fork_context): Adjust
3549         fork_save_infrun_state calls.
3550
3551 2019-03-06  Pedro Alves  <palves@redhat.com>
3552
3553         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3554         (inf_has_multiple_threads): Return 'bool' and rewrite using
3555         inferior_info::threads().
3556
3557 2019-03-06  Pedro Alves  <palves@redhat.com>
3558
3559         * linux-fork.c: Include <list>.
3560         (fork_list): Now a std::list instance.
3561         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3562         (forks_exist_p, find_last_fork): Adjust.
3563         (new_fork): Delete.
3564         (one_fork_p): New.
3565         (add_fork): Adjust.
3566         (free_fork): Delete, folded into fork_info::~fork_info().
3567         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3568         Adjust.
3569         (init_fork_list): Delete.
3570         (linux_fork_killall, linux_fork_mourn_inferior)
3571         (linux_fork_detach, info_checkpoints_command): Adjust.
3572         (_initialize_linux_fork): No longer call init_fork_list.
3573
3574 2019-03-06  Pedro Alves  <palves@redhat.com>
3575
3576         * linux-fork.c (new_fork): New, split out of ...
3577         (add_fork): ... this.  Return void.  Move "first fork" special
3578         case from here, to ...
3579         (checkpoint_command): ... here.
3580         * linux-linux.h (add_fork): Return void.
3581
3582 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3585
3586 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3587             Chris January  <chris.january@arm.com>
3588             David Lecomber  <david.lecomber@arm.com>
3589
3590         * f-exp.y: New token, UNOP_INTRINSIC.
3591         (exp): New pattern using UNOP_INTRINSIC token.
3592         (f77_keywords): Add 'abs' keyword.
3593         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3594         (value_from_host_double): New function.
3595         (evaluate_subexp_f): Support UNOP_ABS.
3596
3597 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3598
3599         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3600         types.
3601
3602 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3605         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3606         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3607
3608 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3609
3610         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3611
3612 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3613             Chris January  <chris.january@arm.com>
3614
3615         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3616         * f-exp.y: Define 'KIND' token.
3617         (exp): New pattern for KIND expressions.
3618         (ptype): Handle types with a kind extension.
3619         (direct_abs_decl): Extend to spot kind extensions.
3620         (f77_keywords): Add 'kind' to the list.
3621         (push_kind_type): New function.
3622         (convert_to_kind_type): New function.
3623         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3624         * parse.c (operator_length_standard): Likewise.
3625         * parser-defs.h (enum type_pieces): Add tp_kind.
3626         * std-operator.def: Add UNOP_KIND.
3627
3628 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         * f-exp.y (f_parse): Set yydebug.
3631
3632 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3633
3634         * f-lang.c (evaluate_subexp_f): New function.
3635         (exp_descriptor_f): New global.
3636         (f_language_defn): Use exp_descriptor_f instead of
3637         exp_descriptor_standard.
3638
3639 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         * f-exp.y (struct token): Add comments.
3642         (dot_ops): Remove uppercase versions and the end marker.
3643         (f77_keywords): Likewise.
3644         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3645         entries in the dot_ops array are case insensitive, and use
3646         strncasecmp to compare strings.  Also some whitespace cleanup in
3647         this area.  Similar for the f77_keywords array, except entries in
3648         this list might be case sensitive.
3649
3650 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3651
3652         * f-exp.y (struct f77_boolean_val): Add comments.
3653         (boolean_values): Remove uppercase versions, and end marker.
3654         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3655         and use strncasecmp to achieve case insensitivity.  Additionally,
3656         perform whitespace cleanup around this code.
3657
3658 2019-03-06  Tom Tromey  <tromey@adacore.com>
3659
3660         * remote-sim.c (gdbsim_target_open): Use result of
3661         gdb_argv::release.
3662
3663 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3664         Dirk Schubert  <dirk.schubert@arm.com>
3665         Chris January  <chris.january@arm.com>
3666
3667         * eval.c (evaluate_subexp_standard): Call Fortran argument
3668         wrapping logic.
3669         * f-lang.c (struct value): A value which can be passed into a
3670         Fortran function call.
3671         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3672         where appropriate.
3673         (struct type): Value ready for a Fortran function call.
3674         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3675         is needed.
3676         * f-lang.h (fortran_argument_convert): Declaration.
3677         (fortran_preserve_arg_pointer): Declaration.
3678         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3679
3680 2019-03-05  Tom Tromey  <tromey@adacore.com>
3681
3682         * python/py-prettyprint.c (print_string_repr): Remove #if.
3683         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3684
3685 2019-03-05  Tom Tromey  <tromey@adacore.com>
3686
3687         * target.c (the_dummy_target): Move later.  Change type to
3688         "dummy_target".
3689         (initialize_targets): Don't initialize the_dummy_target.
3690
3691 2019-03-05  Tom Tromey  <tromey@adacore.com>
3692
3693         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3694         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3695
3696 2019-03-05  Tom Tromey  <tromey@adacore.com>
3697
3698         * windows-nat.c (windows_nat_target::attach)
3699         (windows_nat_target::detach): Don't call gdb_flush.
3700         * valprint.c (generic_val_print, val_print, val_print_string):
3701         Don't call gdb_flush.
3702         * utils.c (defaulted_query): Don't call gdb_flush.
3703         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3704         * target.c (target_announce_detach): Don't call gdb_flush.
3705         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3706         * remote.c (extended_remote_target::attach): Don't call
3707         gdb_flush.
3708         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3709         * printcmd.c (do_examine): Don't call gdb_flush.
3710         (info_display_command): Don't call gdb_flush.
3711         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3712         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3713         * memattr.c (info_mem_command): Don't call gdb_flush.
3714         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3715         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3716         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3717         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3718         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3719         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3720         (gnu_nat_target::detach): Don't call gdb_flush.
3721         * f-valprint.c (f_val_print): Don't call gdb_flush.
3722         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3723         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3724         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3725         gdb_flush.
3726         * c-valprint.c (c_val_print): Don't call gdb_flush.
3727         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3728
3729 2019-03-05  Tom Tromey  <tromey@adacore.com>
3730
3731         * varobj.c (update_dynamic_varobj_children): Update.
3732         (install_default_visualizer): Use reset, not release.
3733         * value.c (set_internalvar): Update.
3734         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3735         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3736         ATTRIBUTE_UNUSED_RESULT.
3737
3738 2019-03-05  Tom Tromey  <tromey@adacore.com>
3739
3740         * remote.c (class scoped_remote_fd) <release>: Add
3741         ATTRIBUTE_UNUSED_RESULT.
3742
3743 2019-03-05  Tom Tromey  <tromey@adacore.com>
3744
3745         * macroexp.c (struct macro_buffer) <release>: Add
3746         ATTRIBUTE_UNUSED_RESULT.
3747
3748 2019-03-05  Tom Tromey  <tromey@adacore.com>
3749
3750         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3751         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3752         ATTRIBUTE_UNUSED_RESULT.
3753
3754 2019-03-05  Tom Tromey  <tromey@adacore.com>
3755
3756         * common/scoped_fd.h (class scoped_fd) <release>: Add
3757         ATTRIBUTE_UNUSED_RESULT.
3758
3759 2019-03-05  Tom Tromey  <tromey@adacore.com>
3760
3761         * parser-defs.h (struct parser_state) <release>: Add
3762         ATTRIBUTE_UNUSED_RESULT.
3763
3764 2019-03-05  Tom Tromey  <tromey@adacore.com>
3765
3766         * utils.h (class gdb_argv) <release>: Add
3767         ATTRIBUTE_UNUSED_RESULT.
3768         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3769
3770 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3771
3772         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3773         for-loop range, to avoid compiler warnings.
3774
3775         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3776         avoid compiler warnings about unused variables.
3777
3778         * NEWS: Mention end of support for native debugging on MS-Windows
3779         before XP.
3780
3781         PR gdb/24292
3782         * common/netstuff.c:
3783         * gdbserver/gdbreplay.c
3784         * gdbserver/remote-utils.c:
3785         * ser-tcp.c:
3786         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3787         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3788         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3789         'getaddrinfo' and 'freeaddrinfo' were not available before
3790         Windows XP, and mingw.org's MinGW headers by default define
3791         _WIN32_WINNT to 0x500.
3792
3793 2019-03-01  Gary Benson <gbenson@redhat.com>
3794
3795         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3796
3797 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3798             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3799
3800         PR gdb/8527
3801         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3802         set_sigint_trap, clear_sigint_trap.
3803
3804 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3805
3806         * target.c (target_detach): Clear the regcache and the
3807         frame cache.
3808
3809 2019-02-27  Pedro Alves  <palves@redhat.com>
3810
3811         * utils.c (set_screen_size): When we cap the height/width sizes,
3812         tweak the corresponding command variable to show "unlimited":
3813
3814 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3815             Pedro Alves  <palves@redhat.com>
3816
3817         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3818         before calling rl_set_screen_size.
3819
3820 2019-02-27  Tom Tromey  <tromey@adacore.com>
3821
3822         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3823         define.
3824         * python/py-value.c: Remove Python 2.4 workaround.
3825         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3826         workaround.
3827         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3828         Python 2.4 workaround.
3829         * python/python-internal.h: Remove Python 2.4 comment.
3830         (Py_ssize_t): Don't define.
3831         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3832         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3833         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3834         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3835         * python/python.c (do_start_initialization): Remove Python 2.4
3836         workaround.
3837         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3838         (print_children): Remove Python 2.4 workaround.
3839         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3840         workaround.
3841         (CHARBUFFERPROC_NAME): Remove.
3842         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3843         Python 2.4 workaround.
3844
3845 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3846
3847         * NEWS: Note minimum Python version.
3848
3849 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3850
3851         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3852         code from these functions.  Remove corresponding ifdefs.  Use
3853         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3854         Remove gotos and target of gotos.
3855         (infpy_search_memory): Likewise.
3856
3857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3858
3859         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3860         (hppa_gdbarch_init): Don't register deleted functions with
3861         gdbarch.
3862
3863 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3864
3865         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3866         (h8300_unwind_sp): Delete.
3867         (h8300_dummy_id): Delete.
3868         (h8300_gdbarch_init): Don't register deleted functions with
3869         gdbarch.
3870
3871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3874         (ft32_unwind_pc): Delete.
3875         (ft32_unwind_sp): Delete.
3876         (ft32_gdbarch_init): Don't register deleted functions with
3877         gdbarch.
3878
3879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3880
3881         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3882         (frv_unwind_pc): Delete.
3883         (frv_unwind_sp): Delete.
3884         (frv_gdbarch_init): Don't register deleted functions with
3885         gdbarch.
3886
3887 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3888
3889         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3890         (riscv_unwind_pc): Delete.
3891         (riscv_unwind_sp): Delete.
3892         (riscv_gdbarch_init): Don't register deleted functions with
3893         gdbarch.
3894
3895 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3898         (csky_unwind_pc): Delete.
3899         (csky_unwind_sp): Delete.
3900         (csky_gdbarch_init): Don't register deleted functions with
3901         gdbarch.
3902
3903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3906         (cris_unwind_pc): Delete.
3907         (cris_unwind_sp): Delete.
3908         (cris_gdbarch_init): Don't register deleted functions with
3909         gdbarch.
3910
3911 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3914         (bfin_unwind_pc): Delete.
3915         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3916
3917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3918
3919         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3920         (arm_unwind_pc): Delete.
3921         (arm_unwind_sp): Delete.
3922         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3923
3924 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3927         (arc_unwind_pc): Delete.
3928         (arc_unwind_sp): Delete.
3929         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3930
3931 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3934         (alpha_unwind_pc): Delete.
3935         (alpha_gdbarch_init): Don't register deleted functions with
3936         gdbarch.
3937
3938 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3941         (aarch64_unwind_pc): Delete.
3942         (aarch64_unwind_sp): Delete.
3943         (aarch64_gdbarch_init): Don't register deleted functions with
3944         gdbarch.
3945
3946 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * gdbtypes.c (type_align): Don't consider static members when
3949         computing structure alignment.
3950
3951 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3954         return 0 for other types.
3955         * arch-utils.c (default_type_align): Always return 0.
3956         * gdbarch.h: Regenerate.
3957         * gdbarch.sh (type_align): Extend comment.
3958         * gdbtypes.c (type_align): Add additional comments, always call
3959         gdbarch_type_align before applying the default rules.
3960         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3961         generic code will then apply a suitable default.
3962         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3963         types, return 0 for other types.
3964
3965 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3966
3967         * NEWS: Create a new section for the next release branch.
3968         Rename the section of the current branch, now that it has
3969         been cut.
3970
3971 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3972
3973         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3974         * version.in: Bump version to 8.3.50.DATE-git.
3975
3976 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3977
3978         * aix-thread.c (ptid_cmp): Remove unused variable.
3979         (get_signaled_thread): Likewise.
3980         (store_regs_user_thread): Likewise.
3981         (store_regs_kernel_thread): Likewise.
3982         (fetch_regs_kernel_thread): Remove shadowed variable.
3983
3984 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3985
3986         * features/riscv/32bit-cpu.xml: Add register numbers.
3987         * features/riscv/32bit-fpu.c: Regenerate.
3988         * features/riscv/32bit-fpu.xml: Add register numbers.
3989         * features/riscv/64bit-cpu.xml: Add register numbers.
3990         * features/riscv/64bit-fpu.c: Regenerate.
3991         * features/riscv/64bit-fpu.xml: Add register numbers.
3992
3993 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3994
3995         * NEWS: Mention two argument form of gdb.Value constructor.
3996         * python/py-value.c (convert_buffer_and_type_to_value): New
3997         function.
3998         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3999         Add support for handling an optional second argument.  Call
4000         convert_buffer_and_type_to_value as appropriate.
4001         * python/python-internal.h (Py_buffer_deleter): New struct.
4002         (Py_buffer_up): New typedef.
4003
4004 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4005
4006         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4007         instead of releasing ownership.
4008
4009 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4010
4011         * dwarf2read.c (open_and_init_dwp_file): Call
4012         elf_numsections instead of bfd_count_sections to initialize
4013         dwp_file->num_sections.
4014
4015 2019-02-25  Tom Tromey  <tromey@adacore.com>
4016
4017         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4018
4019 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4020
4021         * gcore.in: Add '--readnever' option when invoking GDB.
4022
4023 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4024
4025         * MAINTAINERS: Update my email address.
4026
4027 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4028
4029         * build-id.c (build_id_to_debug_bfd_1): New function.
4030         (build_id_to_debug_bfd): Look for separate debug file in
4031         sysroot.
4032
4033 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4034
4035         * gdbarch.sh: Update the copyright year range that is placed into
4036         generated files.
4037
4038 2019-02-22  Keith Seitz  <keiths@redhat.com>
4039
4040         PR symtab/23853
4041         * linespec.c (create_sals_line_offset): Search for the default
4042         symtab's filename instead of its fullname.
4043
4044 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4045
4046         * NEWS: Update style defaults.
4047
4048 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4049
4050         * main.c (captured_main_1): Disable styling in batch mode.
4051
4052 2019-02-20  Tom Tromey  <tom@tromey.com>
4053
4054         * symtab.c (symtab_symbol_info): Fix typos.
4055
4056 2019-02-20  Tom Tromey  <tromey@adacore.com>
4057
4058         * findcmd.c (_initialize_mem_search): Use upper case for
4059         metasyntactic variables.
4060
4061 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4062
4063         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4064         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4065
4066 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4067
4068         * top.h (source_file_name): Change to std::string.
4069         * top.c (source_file_name): Likewise.
4070         (command_line_input): Adjust.
4071         * cli/cli-script.c (script_from_file): Adjust.
4072
4073 2019-02-19  Tom Tromey  <tromey@adacore.com>
4074
4075         * ravenscar-thread.c
4076         (ravenscar_thread_target::update_thread_list): Don't call
4077         ada_build_task_list.
4078         * ada-lang.h (ada_build_task_list): Don't declare.
4079         * ada-tasks.c (struct ada_tasks_inferior_data)
4080         <task_list_valid_p>: Now bool.
4081         (read_known_tasks, ada_task_list_changed)
4082         (ada_tasks_invalidate_inferior_data): Update.
4083         (read_known_tasks_array): Return bool.
4084         (read_known_tasks_list): Likewise.
4085         (read_known_tasks): Return void.
4086         (ada_build_task_list): Now static.
4087
4088 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4089
4090         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4091         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4092
4093 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4094
4095         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4096         variant for ada_tasks_pspace_data_handle and
4097         ada_tasks_inferior_data_handle.
4098         (ada_tasks_pspace_data_cleanup): New function.
4099         (ada_tasks_inferior_data_cleanup): New function.
4100
4101 2019-02-17  Tom Tromey  <tom@tromey.com>
4102
4103         * macrotab.h (macro_source_fullname): Return a std::string.
4104         * macrotab.c (macro_include, check_for_redefinition)
4105         (macro_undef, macro_lookup_definition, foreach_macro)
4106         (foreach_macro_in_scope): Update.
4107         (macro_source_fullname): Return a std::string.
4108         * macrocmd.c (show_pp_source_pos): Update.
4109
4110 2019-02-17  Tom Tromey  <tom@tromey.com>
4111
4112         * macrocmd.c (show_pp_source_pos): Style the file names.
4113
4114 2019-02-17  Tom Tromey  <tom@tromey.com>
4115
4116         PR tui/24197:
4117         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4118
4119 2019-02-17  Tom Tromey  <tom@tromey.com>
4120
4121         * ada-lang.c (user_select_syms): Use filtered printing.
4122         * utils.c (wrap_style): New global.
4123         (desired_style): Remove.
4124         (emit_style_escape): Add stream parameter.
4125         (set_output_style, reset_terminal_style, prompt_for_continue):
4126         Update.
4127         (flush_wrap_buffer): Only flush gdb_stdout.
4128         (wrap_here): Set wrap_style.
4129         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4130         treat escape sequences as a character.  Change when wrap buffer is
4131         flushed.
4132         (fputs_styled): Do not set the output style when the default is
4133         requested.
4134         * ui-style.h (struct ui_file_style) <is_default>: New method.
4135         * source.c (print_source_lines_base): Emit escape sequences in one
4136         piece.
4137
4138 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4139
4140         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4141         integers and enumeration types.
4142
4143 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4144
4145         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4146         instead of lookup_symbol_in_language
4147         (do_exact_match): New function.
4148         (ada_get_symbol_name_matcher): Return do_exact_match when
4149         doing a verbatim match.
4150
4151 2019-02-15  Tom Tromey  <tromey@adacore.com>
4152
4153         * ravenscar-thread.c (ravenscar_thread_target::resume)
4154         (ravenscar_thread_target::wait): Special case wildcard requests.
4155
4156 2019-02-15  Tom Tromey  <tromey@adacore.com>
4157
4158         * ravenscar-thread.c (base_ptid): Remove.
4159         (struct ravenscar_thread_target) <close>: New method.
4160         <m_base_ptid>: New member.
4161         <update_inferior_ptid, active_task, task_is_currently_active,
4162         runtime_initialized>: Declare methods.
4163         <ravenscar_thread_target>: Add constructor.
4164         (ravenscar_thread_target::task_is_currently_active)
4165         (ravenscar_thread_target::update_inferior_ptid)
4166         (ravenscar_runtime_initialized): Rename.  Now methods.
4167         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4168         (ravenscar_thread_target::update_thread_list): Update.
4169         (ravenscar_thread_target::active_task): Now method.
4170         (ravenscar_thread_target::store_registers)
4171         (ravenscar_thread_target::prepare_to_store)
4172         (ravenscar_thread_target::prepare_to_store)
4173         (ravenscar_thread_target::mourn_inferior): Update.
4174         (ravenscar_inferior_created): Use "new" to create target.
4175         (ravenscar_thread_target::get_ada_task_ptid): Update.
4176         (_initialize_ravenscar): Don't initialize base_ptid.
4177         (ravenscar_ops): Remove global.
4178
4179 2019-02-15  Tom Tromey  <tromey@adacore.com>
4180
4181         * target.h (push_target): Declare new overload.
4182         * target.c (push_target): New overload, taking an rvalue reference.
4183         * remote.c (remote_target::open_1): Use push_target overload.
4184         * corelow.c (core_target_open): Use push_target overload.
4185
4186 2019-02-15  Tom Tromey  <tromey@adacore.com>
4187
4188         * ravenscar-thread.c (is_ravenscar_task)
4189         (ravenscar_task_is_currently_active): Return bool.
4190         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4191         (_initialize_ravenscar): Remove "(void)".
4192         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4193         Return bool.
4194
4195 2019-02-15  Tom Tromey  <tromey@adacore.com>
4196
4197         * ravenscar-thread.c (ravenscar_runtime_initializer)
4198         (has_ravenscar_runtime, get_running_thread_id)
4199         (ravenscar_thread_target::resume): Fix indentation.
4200
4201 2019-02-15  Tom Tromey  <tromey@adacore.com>
4202
4203         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4204         from ravenscar_arch_ops.
4205         (sparc_ravenscar_ops::fetch_registers)
4206         (sparc_ravenscar_ops::store_registers): Now methods.
4207         (sparc_ravenscar_prepare_to_store): Remove.
4208         (sparc_ravenscar_ops): Redefine.
4209         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4210         methods and destructor.  Remove members.
4211         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4212         (ravenscar_thread_target::store_registers)
4213         (ravenscar_thread_target::prepare_to_store): Update.
4214         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4215         Remove.
4216         (struct ppc_ravenscar_powerpc_ops): Derive from
4217         ravenscar_arch_ops.
4218         (ppc_ravenscar_powerpc_ops::fetch_registers)
4219         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4220         (ppc_ravenscar_powerpc_ops): Redefine.
4221         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4222         (ppc_ravenscar_e500_ops::fetch_registers)
4223         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4224         (ppc_ravenscar_e500_ops): Redefine.
4225         * aarch64-ravenscar-thread.c
4226         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4227         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4228         (aarch64_ravenscar_fetch_registers)
4229         (aarch64_ravenscar_store_registers): Now methods.
4230         (aarch64_ravenscar_ops): Redefine.
4231
4232 2019-02-15  Tom Tromey  <tromey@adacore.com>
4233
4234         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4235         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4236         (ravenscar_thread_target::stopped_by_watchpoint)
4237         (ravenscar_thread_target::stopped_data_address)
4238         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4239
4240 2019-02-15  Tom Tromey  <tromey@adacore.com>
4241
4242         * ravenscar-thread.c: Fix some typos.
4243
4244 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4245             Tom Tromey  <tromey@adacore.com>
4246
4247         * ada-lang.c (ada_exception_sal): Change addr_string to a
4248         std::string.
4249         (create_ada_exception_catchpoint): Update.
4250
4251 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4252             Tom Tromey  <tromey@adacore.com>
4253
4254         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4255         (bp_location_ops): Remove.
4256         (base_breakpoint_allocate_location): Update.
4257         (free_bp_location): Update.
4258         * ada-lang.c (class ada_catchpoint_location)
4259         <ada_catchpoint_location>: Remove ops parameter.
4260         (ada_catchpoint_location_dtor): Remove.
4261         (ada_catchpoint_location_ops): Remove.
4262         (allocate_location_exception): Update.
4263         * breakpoint.h (struct bp_location_ops): Remove.
4264         (class bp_location) <bp_location>: Remove bp_location_ops
4265         parameter.
4266         <~bp_location>: Add destructor.
4267         <ops>: Remove.
4268
4269 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4270             Pedro Alves  <palves@redhat.com>
4271
4272         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4273         'PATH_MAX'.
4274
4275 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4276             Samuel Thibault  <samuel.thibault@gnu.org>
4277             Thomas Schwinge  <thomas@codesourcery.com>
4278
4279         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4280         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4281
4282 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4283
4284         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4285         (check_empty): Use "const char *".
4286
4287         * gnu-nat.c (gnu_nat_target::detach): Instead of
4288         'detach_inferior (pid)' call
4289         'detach_inferior (find_inferior_pid (pid))'.
4290
4291         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4292         'nat/fork-inferior.o'.
4293         * gnu-nat.c: #include "nat/fork-inferior.h".
4294
4295         * gnu-nat.c (gnu_nat_target::detach): Instead of
4296         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4297         * gnu-nat.h: #include "inf-child.h".
4298         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4299         'i386_gnu_nat_target::fetch_registers'.
4300         (gnu_store_registers): Rename/move to
4301         'i386_gnu_nat_target::store_registers'.
4302
4303         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4304         * gnu-nat.h (mach_thread_info): New function.
4305         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4306
4307         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4308
4309 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4310
4311         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4312
4313 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4314
4315         * windows-nat.c (windows_add_thread): Add new parameter
4316         "main_thread_p" with default value set to false.  Update
4317         function documentation as well as all callers.
4318         (windows_delete_thread): Likewise.
4319         (fake_create_process): Update call to windows_add_thread.
4320         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4321         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4322         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4323         call to windows_delete_thread.
4324
4325 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4326
4327         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4328
4329 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4330
4331         * symfile.c (find_separate_debug_file): Use canonical path of
4332         sysroot with child_path instead of gdb_sysroot if it is valid.
4333
4334 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4335
4336         * symfile.c (find_separate_debug_file): Use child_path to
4337         determine if an object file is under a sysroot.
4338
4339 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4340
4341         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4342         unittests/child-path-selftests.c.
4343         * common/pathstuff.c (child_path): New function.
4344         * common/pathstuff.h (child_path): New prototype.
4345         * unittests/child-path-selftests.c: New file.
4346
4347 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4348
4349         * symfile.c (find_separate_debug_file): Look for separate debug
4350         files in debug directories under the sysroot.
4351
4352 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4353
4354         * symtab.h (struct minimal_symbol data_p): New const method.
4355         (struct minimal_symbol text_p): Likewise.
4356         * symtab.c (output_source_filename): Use file name style
4357         to print file name.
4358         (print_symbol_info): Likewise.
4359         (print_msymbol_info): Use address style to print addresses.
4360         Use function name style to print executable text symbols.
4361         (expand_symtab_containing_pc): Use data_p.
4362         (find_pc_sect_compunit_symtab): Likewise.
4363
4364 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4365
4366         * breakpoint.c (describe_other_breakpoints): Use address style
4367         to print addresses.
4368         (say_where): Likewise.
4369
4370 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4371
4372         * ada-typeprint.c (print_func_type): Print function name
4373         style to print function name.
4374         * c-typeprint.c (c_print_type_1): Likewise.
4375
4376 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4377
4378         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4379         for execve.
4380
4381 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4382
4383         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4384         type_stack.
4385
4386 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4387
4388         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4389         TYPE_CODE_REF types.
4390
4391 2019-02-08  Jim Wilson  <jimw@sifive.com>
4392
4393         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4394         (riscv_linux_fregset): New.
4395         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4396
4397 2019-02-07  Tom Tromey  <tom@tromey.com>
4398
4399         * thread.c (thread_cancel_execution_command): Update.
4400         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4401         methods.
4402         (struct thread_fsm_ops): Remove.
4403         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4404         (thread_fsm_should_stop, thread_fsm_return_value)
4405         (thread_fsm_set_finished, thread_fsm_finished_p)
4406         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4407         Don't declare.
4408         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4409         * infrun.c (clear_proceed_status_thread)
4410         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4411         (print_stop_event): Update.
4412         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4413         Add constructor.
4414         (step_command_fsm_ops): Remove.
4415         (new_step_command_fsm): Remove.
4416         (step_1): Update.
4417         (step_command_fsm::should_stop): Rename from
4418         step_command_fsm_should_stop.
4419         (step_command_fsm::clean_up): Rename from
4420         step_command_fsm_clean_up.
4421         (step_command_fsm::do_async_reply_reason): Rename from
4422         step_command_fsm_async_reply_reason.
4423         (struct until_next_fsm): Inherit from thread_fsm.  Add
4424         constructor.
4425         (until_next_fsm_ops): Remove.
4426         (new_until_next_fsm): Remove.
4427         (until_next_fsm::should_stop): Rename from
4428         until_next_fsm_should_stop.
4429         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4430         (until_next_fsm::do_async_reply_reason): Rename from
4431         until_next_fsm_async_reply_reason.
4432         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4433         constructor.  Change type of breakpoint.
4434         (finish_command_fsm_ops): Remove.
4435         (new_finish_command_fsm): Remove.
4436         (finish_command_fsm::should_stop): Rename from
4437         finish_command_fsm_should_stop.
4438         (finish_command_fsm::clean_up): Rename from
4439         finish_command_fsm_clean_up.
4440         (finish_command_fsm::return_value): Rename from
4441         finish_command_fsm_return_value.
4442         (finish_command_fsm::do_async_reply_reason): Rename from
4443         finish_command_fsm_async_reply_reason.
4444         (finish_command): Update.
4445         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4446         Add constructor.
4447         (call_thread_fsm_ops): Remove.
4448         (call_thread_fsm::call_thread_fsm): Rename from
4449         new_call_thread_fsm.
4450         (call_thread_fsm::should_stop): Rename from
4451         call_thread_fsm_should_stop.
4452         (call_thread_fsm::should_notify_stop): Rename from
4453         call_thread_fsm_should_notify_stop.
4454         (run_inferior_call, call_function_by_hand_dummy): Update.
4455         * cli/cli-interp.c (should_print_stop_to_console): Update.
4456         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4457         Add constructor.  Change type of location_breakpoint,
4458         caller_breakpoint.
4459         (until_break_fsm_ops): Remove.
4460         (new_until_break_fsm): Remove.
4461         (until_break_fsm::should_stop): Rename from
4462         until_break_fsm_should_stop.
4463         (until_break_fsm::clean_up): Rename from
4464         until_break_fsm_clean_up.
4465         (until_break_fsm::do_async_reply_reason): Rename from
4466         until_break_fsm_async_reply_reason.
4467         (until_break_command): Update.
4468         * thread-fsm.c: Remove.
4469         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4470
4471 2019-02-07  Tom Tromey  <tom@tromey.com>
4472
4473         * yy-remap.h: Add include guard.
4474         * xtensa-tdep.h: Add include guard.
4475         * xcoffread.h: Rename include guard.
4476         * varobj-iter.h: Add include guard.
4477         * tui/tui.h: Rename include guard.
4478         * tui/tui-winsource.h: Rename include guard.
4479         * tui/tui-wingeneral.h: Rename include guard.
4480         * tui/tui-windata.h: Rename include guard.
4481         * tui/tui-win.h: Rename include guard.
4482         * tui/tui-stack.h: Rename include guard.
4483         * tui/tui-source.h: Rename include guard.
4484         * tui/tui-regs.h: Rename include guard.
4485         * tui/tui-out.h: Rename include guard.
4486         * tui/tui-layout.h: Rename include guard.
4487         * tui/tui-io.h: Rename include guard.
4488         * tui/tui-hooks.h: Rename include guard.
4489         * tui/tui-file.h: Rename include guard.
4490         * tui/tui-disasm.h: Rename include guard.
4491         * tui/tui-data.h: Rename include guard.
4492         * tui/tui-command.h: Rename include guard.
4493         * tic6x-tdep.h: Add include guard.
4494         * target/waitstatus.h: Rename include guard.
4495         * target/wait.h: Rename include guard.
4496         * target/target.h: Rename include guard.
4497         * target/resume.h: Rename include guard.
4498         * target-float.h: Rename include guard.
4499         * stabsread.h: Add include guard.
4500         * rs6000-tdep.h: Add include guard.
4501         * riscv-fbsd-tdep.h: Add include guard.
4502         * regformats/regdef.h: Rename include guard.
4503         * record.h: Rename include guard.
4504         * python/python.h: Rename include guard.
4505         * python/python-internal.h: Rename include guard.
4506         * python/py-stopevent.h: Rename include guard.
4507         * python/py-ref.h: Rename include guard.
4508         * python/py-record.h: Rename include guard.
4509         * python/py-record-full.h: Rename include guard.
4510         * python/py-record-btrace.h: Rename include guard.
4511         * python/py-instruction.h: Rename include guard.
4512         * python/py-events.h: Rename include guard.
4513         * python/py-event.h: Rename include guard.
4514         * procfs.h: Add include guard.
4515         * proc-utils.h: Add include guard.
4516         * p-lang.h: Add include guard.
4517         * or1k-tdep.h: Rename include guard.
4518         * observable.h: Rename include guard.
4519         * nto-tdep.h: Rename include guard.
4520         * nat/x86-linux.h: Rename include guard.
4521         * nat/x86-linux-dregs.h: Rename include guard.
4522         * nat/x86-gcc-cpuid.h: Add include guard.
4523         * nat/x86-dregs.h: Rename include guard.
4524         * nat/x86-cpuid.h: Rename include guard.
4525         * nat/ppc-linux.h: Rename include guard.
4526         * nat/mips-linux-watch.h: Rename include guard.
4527         * nat/linux-waitpid.h: Rename include guard.
4528         * nat/linux-ptrace.h: Rename include guard.
4529         * nat/linux-procfs.h: Rename include guard.
4530         * nat/linux-osdata.h: Rename include guard.
4531         * nat/linux-nat.h: Rename include guard.
4532         * nat/linux-namespaces.h: Rename include guard.
4533         * nat/linux-btrace.h: Rename include guard.
4534         * nat/glibc_thread_db.h: Rename include guard.
4535         * nat/gdb_thread_db.h: Rename include guard.
4536         * nat/gdb_ptrace.h: Rename include guard.
4537         * nat/fork-inferior.h: Rename include guard.
4538         * nat/amd64-linux-siginfo.h: Rename include guard.
4539         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4540         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4541         * nat/aarch64-linux.h: Rename include guard.
4542         * nat/aarch64-linux-hw-point.h: Rename include guard.
4543         * mn10300-tdep.h: Add include guard.
4544         * mips-linux-tdep.h: Add include guard.
4545         * mi/mi-parse.h: Rename include guard.
4546         * mi/mi-out.h: Rename include guard.
4547         * mi/mi-main.h: Rename include guard.
4548         * mi/mi-interp.h: Rename include guard.
4549         * mi/mi-getopt.h: Rename include guard.
4550         * mi/mi-console.h: Rename include guard.
4551         * mi/mi-common.h: Rename include guard.
4552         * mi/mi-cmds.h: Rename include guard.
4553         * mi/mi-cmd-break.h: Rename include guard.
4554         * m2-lang.h: Add include guard.
4555         * location.h: Rename include guard.
4556         * linux-record.h: Rename include guard.
4557         * linux-nat.h: Add include guard.
4558         * linux-fork.h: Add include guard.
4559         * i386-darwin-tdep.h: Rename include guard.
4560         * hppa-linux-offsets.h: Add include guard.
4561         * guile/guile.h: Rename include guard.
4562         * guile/guile-internal.h: Rename include guard.
4563         * gnu-nat.h: Rename include guard.
4564         * gdb-stabs.h: Rename include guard.
4565         * frv-tdep.h: Add include guard.
4566         * f-lang.h: Add include guard.
4567         * event-loop.h: Add include guard.
4568         * darwin-nat.h: Rename include guard.
4569         * cp-abi.h: Rename include guard.
4570         * config/sparc/nm-sol2.h: Rename include guard.
4571         * config/nm-nto.h: Rename include guard.
4572         * config/nm-linux.h: Add include guard.
4573         * config/i386/nm-i386gnu.h: Rename include guard.
4574         * config/djgpp/nl_types.h: Rename include guard.
4575         * config/djgpp/langinfo.h: Rename include guard.
4576         * compile/gcc-cp-plugin.h: Add include guard.
4577         * compile/gcc-c-plugin.h: Add include guard.
4578         * compile/compile.h: Rename include guard.
4579         * compile/compile-object-run.h: Rename include guard.
4580         * compile/compile-object-load.h: Rename include guard.
4581         * compile/compile-internal.h: Rename include guard.
4582         * compile/compile-cplus.h: Rename include guard.
4583         * compile/compile-c.h: Rename include guard.
4584         * common/xml-utils.h: Rename include guard.
4585         * common/x86-xstate.h: Rename include guard.
4586         * common/version.h: Rename include guard.
4587         * common/vec.h: Rename include guard.
4588         * common/tdesc.h: Rename include guard.
4589         * common/selftest.h: Rename include guard.
4590         * common/scoped_restore.h: Rename include guard.
4591         * common/scoped_mmap.h: Rename include guard.
4592         * common/scoped_fd.h: Rename include guard.
4593         * common/safe-iterator.h: Rename include guard.
4594         * common/run-time-clock.h: Rename include guard.
4595         * common/refcounted-object.h: Rename include guard.
4596         * common/queue.h: Rename include guard.
4597         * common/ptid.h: Rename include guard.
4598         * common/print-utils.h: Rename include guard.
4599         * common/preprocessor.h: Rename include guard.
4600         * common/pathstuff.h: Rename include guard.
4601         * common/observable.h: Rename include guard.
4602         * common/netstuff.h: Rename include guard.
4603         * common/job-control.h: Rename include guard.
4604         * common/host-defs.h: Rename include guard.
4605         * common/gdb_wait.h: Rename include guard.
4606         * common/gdb_vecs.h: Rename include guard.
4607         * common/gdb_unlinker.h: Rename include guard.
4608         * common/gdb_unique_ptr.h: Rename include guard.
4609         * common/gdb_tilde_expand.h: Rename include guard.
4610         * common/gdb_sys_time.h: Rename include guard.
4611         * common/gdb_string_view.h: Rename include guard.
4612         * common/gdb_splay_tree.h: Rename include guard.
4613         * common/gdb_setjmp.h: Rename include guard.
4614         * common/gdb_ref_ptr.h: Rename include guard.
4615         * common/gdb_optional.h: Rename include guard.
4616         * common/gdb_locale.h: Rename include guard.
4617         * common/gdb_assert.h: Rename include guard.
4618         * common/filtered-iterator.h: Rename include guard.
4619         * common/filestuff.h: Rename include guard.
4620         * common/fileio.h: Rename include guard.
4621         * common/environ.h: Rename include guard.
4622         * common/common-utils.h: Rename include guard.
4623         * common/common-types.h: Rename include guard.
4624         * common/common-regcache.h: Rename include guard.
4625         * common/common-inferior.h: Rename include guard.
4626         * common/common-gdbthread.h: Rename include guard.
4627         * common/common-exceptions.h: Rename include guard.
4628         * common/common-defs.h: Rename include guard.
4629         * common/common-debug.h: Rename include guard.
4630         * common/cleanups.h: Rename include guard.
4631         * common/buffer.h: Rename include guard.
4632         * common/btrace-common.h: Rename include guard.
4633         * common/break-common.h: Rename include guard.
4634         * cli/cli-utils.h: Rename include guard.
4635         * cli/cli-style.h: Rename include guard.
4636         * cli/cli-setshow.h: Rename include guard.
4637         * cli/cli-script.h: Rename include guard.
4638         * cli/cli-interp.h: Rename include guard.
4639         * cli/cli-decode.h: Rename include guard.
4640         * cli/cli-cmds.h: Rename include guard.
4641         * charset-list.h: Add include guard.
4642         * buildsym-legacy.h: Rename include guard.
4643         * bfin-tdep.h: Add include guard.
4644         * ax.h: Rename include guard.
4645         * arm-linux-tdep.h: Add include guard.
4646         * arm-fbsd-tdep.h: Add include guard.
4647         * arch/xtensa.h: Rename include guard.
4648         * arch/tic6x.h: Add include guard.
4649         * arch/i386.h: Add include guard.
4650         * arch/arm.h: Rename include guard.
4651         * arch/arm-linux.h: Rename include guard.
4652         * arch/arm-get-next-pcs.h: Rename include guard.
4653         * arch/amd64.h: Add include guard.
4654         * arch/aarch64-insn.h: Rename include guard.
4655         * arch-utils.h: Rename include guard.
4656         * annotate.h: Add include guard.
4657         * amd64-darwin-tdep.h: Rename include guard.
4658         * aarch64-linux-tdep.h: Add include guard.
4659         * aarch64-fbsd-tdep.h: Add include guard.
4660         * aarch32-linux-nat.h: Add include guard.
4661
4662 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4663
4664         * macrotab.c (macro_define_internal): New function that
4665         factorizes macro_define_object_internal and macro_define_function
4666         code.
4667         (macro_define_object_internal): Use macro_define_internal.
4668         (macro_define_function): Likewise.
4669
4670 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4671
4672         * macrocmd.c (extract_identifier): Return
4673         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4674         callers.
4675
4676 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4677
4678         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4679
4680 2019-02-05  Tom Tromey  <tom@tromey.com>
4681
4682         * target.c (target_stack::unpush): Move assertion earlier.
4683
4684 2019-01-30  Tom Tromey  <tom@tromey.com>
4685
4686         PR python/23615:
4687         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4688         (gdbpy_parse_and_eval): Likewise.
4689         * python/python-internal.h (gdbpy_allow_threads): New class.
4690
4691 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4692
4693         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4694         (aarch64_fbsd_fpregmap): Move earlier.
4695         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4696         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4697         instead of individual calls to trad_frame_set_reg_addr.
4698         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4699         earlier.
4700         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4701         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4702         instead of individual calls to trad_frame_set_reg_addr.
4703
4704 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4705
4706         * CONTRIBUTE: Replace contribution list with wiki link.
4707
4708 2019-01-25  Tom Tromey  <tom@tromey.com>
4709
4710         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4711
4712 2019-01-25  Tom Tromey  <tom@tromey.com>
4713
4714         * xtensa-linux-nat.c: Fix common/ includes.
4715         * xml-support.h: Fix common/ includes.
4716         * xml-support.c: Fix common/ includes.
4717         * x86-linux-nat.c: Fix common/ includes.
4718         * windows-nat.c: Fix common/ includes.
4719         * varobj.h: Fix common/ includes.
4720         * varobj.c: Fix common/ includes.
4721         * value.c: Fix common/ includes.
4722         * valops.c: Fix common/ includes.
4723         * utils.c: Fix common/ includes.
4724         * unittests/xml-utils-selftests.c: Fix common/ includes.
4725         * unittests/utils-selftests.c: Fix common/ includes.
4726         * unittests/unpack-selftests.c: Fix common/ includes.
4727         * unittests/tracepoint-selftests.c: Fix common/ includes.
4728         * unittests/style-selftests.c: Fix common/ includes.
4729         * unittests/string_view-selftests.c: Fix common/ includes.
4730         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4731         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4732         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4733         * unittests/rsp-low-selftests.c: Fix common/ includes.
4734         * unittests/parse-connection-spec-selftests.c: Fix common/
4735         includes.
4736         * unittests/optional-selftests.c: Fix common/ includes.
4737         * unittests/offset-type-selftests.c: Fix common/ includes.
4738         * unittests/observable-selftests.c: Fix common/ includes.
4739         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4740         * unittests/memrange-selftests.c: Fix common/ includes.
4741         * unittests/memory-map-selftests.c: Fix common/ includes.
4742         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4743         * unittests/function-view-selftests.c: Fix common/ includes.
4744         * unittests/environ-selftests.c: Fix common/ includes.
4745         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4746         * unittests/common-utils-selftests.c: Fix common/ includes.
4747         * unittests/cli-utils-selftests.c: Fix common/ includes.
4748         * unittests/array-view-selftests.c: Fix common/ includes.
4749         * ui-file.c: Fix common/ includes.
4750         * tui/tui-io.c: Fix common/ includes.
4751         * tracepoint.h: Fix common/ includes.
4752         * tracepoint.c: Fix common/ includes.
4753         * tracefile-tfile.c: Fix common/ includes.
4754         * top.h: Fix common/ includes.
4755         * top.c: Fix common/ includes.
4756         * thread.c: Fix common/ includes.
4757         * target/waitstatus.h: Fix common/ includes.
4758         * target/waitstatus.c: Fix common/ includes.
4759         * target.h: Fix common/ includes.
4760         * target.c: Fix common/ includes.
4761         * target-memory.c: Fix common/ includes.
4762         * target-descriptions.c: Fix common/ includes.
4763         * symtab.h: Fix common/ includes.
4764         * symfile.c: Fix common/ includes.
4765         * stap-probe.c: Fix common/ includes.
4766         * spu-linux-nat.c: Fix common/ includes.
4767         * sparc-nat.c: Fix common/ includes.
4768         * source.c: Fix common/ includes.
4769         * solib.c: Fix common/ includes.
4770         * solib-target.c: Fix common/ includes.
4771         * ser-unix.c: Fix common/ includes.
4772         * ser-tcp.c: Fix common/ includes.
4773         * ser-pipe.c: Fix common/ includes.
4774         * ser-base.c: Fix common/ includes.
4775         * selftest-arch.c: Fix common/ includes.
4776         * s12z-tdep.c: Fix common/ includes.
4777         * rust-exp.y: Fix common/ includes.
4778         * rs6000-aix-tdep.c: Fix common/ includes.
4779         * riscv-tdep.c: Fix common/ includes.
4780         * remote.c: Fix common/ includes.
4781         * remote-notif.h: Fix common/ includes.
4782         * remote-fileio.h: Fix common/ includes.
4783         * remote-fileio.c: Fix common/ includes.
4784         * regcache.h: Fix common/ includes.
4785         * regcache.c: Fix common/ includes.
4786         * record-btrace.c: Fix common/ includes.
4787         * python/python.c: Fix common/ includes.
4788         * python/py-type.c: Fix common/ includes.
4789         * python/py-inferior.c: Fix common/ includes.
4790         * progspace.h: Fix common/ includes.
4791         * producer.c: Fix common/ includes.
4792         * procfs.c: Fix common/ includes.
4793         * proc-api.c: Fix common/ includes.
4794         * printcmd.c: Fix common/ includes.
4795         * ppc-linux-nat.c: Fix common/ includes.
4796         * parser-defs.h: Fix common/ includes.
4797         * osdata.c: Fix common/ includes.
4798         * obsd-nat.c: Fix common/ includes.
4799         * nat/x86-linux.c: Fix common/ includes.
4800         * nat/x86-linux-dregs.c: Fix common/ includes.
4801         * nat/x86-dregs.h: Fix common/ includes.
4802         * nat/x86-dregs.c: Fix common/ includes.
4803         * nat/ppc-linux.c: Fix common/ includes.
4804         * nat/mips-linux-watch.h: Fix common/ includes.
4805         * nat/mips-linux-watch.c: Fix common/ includes.
4806         * nat/linux-waitpid.c: Fix common/ includes.
4807         * nat/linux-ptrace.h: Fix common/ includes.
4808         * nat/linux-ptrace.c: Fix common/ includes.
4809         * nat/linux-procfs.c: Fix common/ includes.
4810         * nat/linux-personality.c: Fix common/ includes.
4811         * nat/linux-osdata.c: Fix common/ includes.
4812         * nat/linux-namespaces.c: Fix common/ includes.
4813         * nat/linux-btrace.h: Fix common/ includes.
4814         * nat/linux-btrace.c: Fix common/ includes.
4815         * nat/fork-inferior.c: Fix common/ includes.
4816         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4817         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4818         * nat/aarch64-linux.c: Fix common/ includes.
4819         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4820         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4821         * namespace.h: Fix common/ includes.
4822         * mips-linux-tdep.c: Fix common/ includes.
4823         * minsyms.c: Fix common/ includes.
4824         * mi/mi-parse.h: Fix common/ includes.
4825         * mi/mi-main.c: Fix common/ includes.
4826         * mi/mi-cmd-env.c: Fix common/ includes.
4827         * memrange.h: Fix common/ includes.
4828         * memattr.c: Fix common/ includes.
4829         * maint.h: Fix common/ includes.
4830         * maint.c: Fix common/ includes.
4831         * main.c: Fix common/ includes.
4832         * machoread.c: Fix common/ includes.
4833         * location.c: Fix common/ includes.
4834         * linux-thread-db.c: Fix common/ includes.
4835         * linux-nat.c: Fix common/ includes.
4836         * linux-fork.c: Fix common/ includes.
4837         * inline-frame.c: Fix common/ includes.
4838         * infrun.c: Fix common/ includes.
4839         * inflow.c: Fix common/ includes.
4840         * inferior.h: Fix common/ includes.
4841         * inferior.c: Fix common/ includes.
4842         * infcmd.c: Fix common/ includes.
4843         * inf-ptrace.c: Fix common/ includes.
4844         * inf-child.c: Fix common/ includes.
4845         * ia64-linux-nat.c: Fix common/ includes.
4846         * i387-tdep.c: Fix common/ includes.
4847         * i386-tdep.c: Fix common/ includes.
4848         * i386-linux-tdep.c: Fix common/ includes.
4849         * i386-linux-nat.c: Fix common/ includes.
4850         * i386-go32-tdep.c: Fix common/ includes.
4851         * i386-fbsd-tdep.c: Fix common/ includes.
4852         * i386-fbsd-nat.c: Fix common/ includes.
4853         * guile/scm-type.c: Fix common/ includes.
4854         * guile/guile.c: Fix common/ includes.
4855         * go32-nat.c: Fix common/ includes.
4856         * gnu-nat.c: Fix common/ includes.
4857         * gdbthread.h: Fix common/ includes.
4858         * gdbarch-selftests.c: Fix common/ includes.
4859         * gdb_usleep.c: Fix common/ includes.
4860         * gdb_select.h: Fix common/ includes.
4861         * gdb_bfd.c: Fix common/ includes.
4862         * gcore.c: Fix common/ includes.
4863         * fork-child.c: Fix common/ includes.
4864         * findvar.c: Fix common/ includes.
4865         * fbsd-nat.c: Fix common/ includes.
4866         * event-top.c: Fix common/ includes.
4867         * event-loop.c: Fix common/ includes.
4868         * dwarf2read.c: Fix common/ includes.
4869         * dwarf2loc.c: Fix common/ includes.
4870         * dwarf2-frame.c: Fix common/ includes.
4871         * dwarf-index-cache.c: Fix common/ includes.
4872         * dtrace-probe.c: Fix common/ includes.
4873         * disasm-selftests.c: Fix common/ includes.
4874         * defs.h: Fix common/ includes.
4875         * csky-tdep.c: Fix common/ includes.
4876         * cp-valprint.c: Fix common/ includes.
4877         * cp-support.h: Fix common/ includes.
4878         * cp-support.c: Fix common/ includes.
4879         * corelow.c: Fix common/ includes.
4880         * completer.h: Fix common/ includes.
4881         * completer.c: Fix common/ includes.
4882         * compile/compile.c: Fix common/ includes.
4883         * compile/compile-loc2c.c: Fix common/ includes.
4884         * compile/compile-cplus-types.c: Fix common/ includes.
4885         * compile/compile-cplus-symbols.c: Fix common/ includes.
4886         * command.h: Fix common/ includes.
4887         * cli/cli-dump.c: Fix common/ includes.
4888         * cli/cli-cmds.c: Fix common/ includes.
4889         * charset.c: Fix common/ includes.
4890         * build-id.c: Fix common/ includes.
4891         * btrace.h: Fix common/ includes.
4892         * btrace.c: Fix common/ includes.
4893         * breakpoint.h: Fix common/ includes.
4894         * breakpoint.c: Fix common/ includes.
4895         * ax.h:
4896         (enum agent_op): Fix common/ includes.
4897         * ax-general.c (struct aop_map): Fix common/ includes.
4898         * ax-gdb.c: Fix common/ includes.
4899         * auxv.c: Fix common/ includes.
4900         * auto-load.c: Fix common/ includes.
4901         * arm-tdep.c: Fix common/ includes.
4902         * arch/riscv.c: Fix common/ includes.
4903         * arch/ppc-linux-common.c: Fix common/ includes.
4904         * arch/i386.c: Fix common/ includes.
4905         * arch/arm.c: Fix common/ includes.
4906         * arch/arm-linux.c: Fix common/ includes.
4907         * arch/arm-get-next-pcs.c: Fix common/ includes.
4908         * arch/amd64.c: Fix common/ includes.
4909         * arch/aarch64.c: Fix common/ includes.
4910         * arch/aarch64-insn.c: Fix common/ includes.
4911         * arch-utils.c: Fix common/ includes.
4912         * amd64-windows-tdep.c: Fix common/ includes.
4913         * amd64-tdep.c: Fix common/ includes.
4914         * amd64-sol2-tdep.c: Fix common/ includes.
4915         * amd64-obsd-tdep.c: Fix common/ includes.
4916         * amd64-nbsd-tdep.c: Fix common/ includes.
4917         * amd64-linux-tdep.c: Fix common/ includes.
4918         * amd64-linux-nat.c: Fix common/ includes.
4919         * amd64-fbsd-tdep.c: Fix common/ includes.
4920         * amd64-fbsd-nat.c: Fix common/ includes.
4921         * amd64-dicos-tdep.c: Fix common/ includes.
4922         * amd64-darwin-tdep.c: Fix common/ includes.
4923         * agent.c: Fix common/ includes.
4924         * ada-lang.h: Fix common/ includes.
4925         * ada-lang.c: Fix common/ includes.
4926         * aarch64-tdep.c: Fix common/ includes.
4927
4928 2019-01-25  Tom Tromey  <tom@tromey.com>
4929
4930         * common/create-version.sh: Use common/version.h.
4931
4932 2019-01-24  Pedro Alves  <palves@redhat.com>
4933
4934         * infrun.c (signal_stop, signal_print, signal_program)
4935         (signal_catch, signal_pass): Now arrays instead of pointers.
4936         (update_signals_program_target, do_target_resume)
4937         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4938         * linux-nat.c (linux_nat_target::pass_signals)
4939         (linux_nat_target::create_inferior, linux_nat_target::attach):
4940         Adjust.
4941         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4942         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4943         * procfs.c (procfs_target::pass_signals): Adjust.
4944         * record-full.c (record_full_target::resume): Adjust.
4945         * remote.c (remote_target::pass_signals)
4946         (remote_target::program_signals): Adjust.
4947         * target-debug.h (target_debug_print_signals): Now takes a
4948         gdb::array_view as parameter.  Adjust.
4949         * target.h (target_ops) <pass_signals, program_signals>: Replace
4950         pointer and length parameters with gdb::array_view.
4951         (target_pass_signals, target_program_signals): Likewise.
4952         * target-delegates.c: Regenerate.
4953
4954 2019-01-24  Pedro Alves  <palves@redhat.com>
4955
4956         * common/forward-scope-exit.h
4957         (forward_scope_exit::forward_scope_exit): Pass arguments to
4958         m_bind_function directly, instead of creating a std::bind and
4959         copying that.
4960
4961 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4962
4963         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4964         for static members.
4965         (pass_in_v_vfp_candidate): Likewise.
4966
4967 2019-01-23  Tom Tromey  <tom@tromey.com>
4968             Pedro Alves  <palves@redhat.com>
4969
4970         * regcache.c (class regcache_invalidator): Remove.
4971         (regcache::raw_write): Use make_scope_exit.
4972
4973 2019-01-23  Tom Tromey  <tom@tromey.com>
4974
4975         * ui-out.h (class ui_out_emit_type): Update comment.
4976
4977 2019-01-23  Tom Tromey  <tom@tromey.com>
4978
4979         * infrun.c (fetch_inferior_event): Update comment.
4980
4981 2019-01-23  Tom Tromey  <tom@tromey.com>
4982             Pedro Alves  <palves@redhat.com>
4983
4984         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4985         parameter.
4986         (fetch_inferior_event): Use SCOPE_EXIT.
4987
4988
4989 2019-01-23  Tom Tromey  <tom@tromey.com>
4990             Pedro Alves  <palves@redhat.com>
4991
4992         * infrun.c (disable_thread_events): Delete.
4993         (stop_all_threads): Use SCOPE_EXIT.
4994
4995 2019-01-23  Tom Tromey  <tom@tromey.com>
4996             Pedro Alves  <palves@redhat.com>
4997
4998         * symfile.c: Include forward-scope-exit.h.
4999         (clear_symtab_users_cleanup): Replace forward declaration with
5000         a FORWARD_SCOPE_EXIT.
5001         (syms_from_objfile_1): Use the forward_scope_exit and
5002         gdb::optional instead of cleanup_function.
5003         (reread_symbols): Use the forward_scope_exit instead of
5004         cleanup_function.
5005         (clear_symtab_users_cleanup): Remove function.
5006
5007 2019-01-23  Tom Tromey  <tom@tromey.com>
5008             Pedro Alves  <palves@redhat.com>
5009
5010         * linux-nat.c: Include scope-exit.h.
5011         (cleanup_target_stop): Remove.
5012         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5013         SCOPE_EXIT.
5014
5015 2019-01-23  Tom Tromey  <tom@tromey.com>
5016             Pedro Alves  <palves@redhat.com>
5017
5018         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5019         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5020
5021 2019-01-23  Tom Tromey  <tom@tromey.com>
5022             Andrew Burgess  <andrew.burgess@embecosm.com>
5023             Pedro Alves  <palves@redhat.com>
5024
5025         * infrun.c (fetch_inferior_event): Use scope_exit.
5026         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5027         * top.c (execute_command): Use scope_exit.
5028         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5029         * utils.c (do_bpstat_clear_actions_cleanup)
5030         (make_bpstat_clear_actions_cleanup): Remove.
5031
5032 2019-01-23  Tom Tromey  <tom@tromey.com>
5033             Pedro Alves  <palves@redhat.com>
5034
5035         * infrun.c: Include "common/scope-exit.h"
5036         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5037         (wait_for_inferior): Use SCOPE_EXIT.
5038         (fetch_inferior_event): Use scope_exit.
5039
5040 2019-01-23  Tom Tromey  <tom@tromey.com>
5041             Pedro Alves  <palves@redhat.com>
5042
5043         * breakpoint.c (create_breakpoint): Remove cleanup.
5044
5045 2019-01-23  Tom Tromey  <tom@tromey.com>
5046             Andrew Burgess  <andrew.burgess@embecosm.com>
5047             Pedro Alves  <palves@redhat.com>
5048
5049 2019-01-23  Pedro Alves  <palves@redhat.com>
5050
5051         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5052
5053 2019-01-23  Pedro Alves  <palves@redhat.com>
5054             Andrew Burgess  <andrew.burgess@embecosm.com>
5055
5056         * gdbthread.h: Include "common/forward-scope-exit.h".
5057         (scoped_finish_thread_state): Redefine custom class in terms of
5058         forward_scope_exit.
5059
5060 2019-01-23  Pedro Alves  <palves@redhat.com>
5061             Andrew Burgess  <andrew.burgess@embecosm.com>
5062
5063         * common/forward-scope-exit.h: New file.
5064
5065 2019-01-23  Pedro Alves  <palves@redhat.com>
5066             Andrew Burgess  <andrew.burgess@embecosm.com>
5067             Tom Tromey  <tom@tromey.com>
5068
5069         * common/scope-exit.h: New file.
5070
5071 2019-01-23  Pedro Alves  <palves@redhat.com>
5072
5073         * common/preprocessor.h (ESC): Rename to ...
5074         (ESC_PARENS): ... this.
5075         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5076         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5077
5078 2019-01-23  Tom Tromey  <tom@tromey.com>
5079
5080         * language.h (class scoped_switch_to_sym_language_if_auto):
5081         Initialize m_lang in both cases.
5082
5083 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5084
5085         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5086         with XCNEW.
5087
5088 2019-01-22  Tom Tromey  <tom@tromey.com>
5089
5090         * corelow.c: Do not include sys/file.h.
5091
5092 2019-01-22  Tom Tromey  <tom@tromey.com>
5093
5094         * tui/tui-wingeneral.h: Include gdb_curses.h.
5095
5096 2019-01-22  Tom Tromey  <tom@tromey.com>
5097
5098         * source-cache.h (class source_cache) <get_source_lines,
5099         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5100
5101 2019-01-22  Tom Tromey  <tom@tromey.com>
5102
5103         * remote-fileio.h (struct remote_target): Declare.
5104
5105 2019-01-22  Tom Tromey  <tom@tromey.com>
5106
5107         * python/py-arch.c: Do not include py-ref.h.
5108         * python/py-bpevent.c: Do not include py-ref.h.
5109         * python/py-cmd.c: Do not include py-ref.h.
5110         * python/py-continueevent.c: Do not include py-ref.h.
5111         * python/py-event.h: Do not include py-ref.h.
5112         * python/py-evtregistry.c: Do not include py-ref.h.
5113         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5114         * python/py-frame.c: Do not include py-ref.h.
5115         * python/py-framefilter.c: Do not include py-ref.h.
5116         * python/py-function.c: Do not include py-ref.h.
5117         * python/py-infevents.c: Do not include py-ref.h.
5118         * python/py-linetable.c: Do not include py-ref.h.
5119         * python/py-objfile.c: Do not include py-ref.h.
5120         * python/py-param.c: Do not include py-ref.h.
5121         * python/py-prettyprint.c: Do not include py-ref.h.
5122         * python/py-progspace.c: Do not include py-ref.h.
5123         * python/py-symbol.c: Do not include py-ref.h.
5124         * python/py-symtab.c: Do not include py-ref.h.
5125         * python/py-type.c: Do not include py-ref.h.
5126         * python/py-unwind.c: Do not include py-ref.h.
5127         * python/py-utils.c: Do not include py-ref.h.
5128         * python/py-value.c: Do not include py-ref.h.
5129         * python/py-varobj.c: Do not include py-ref.h.
5130         * python/py-xmethods.c: Do not include py-ref.h.
5131         * python/python.c: Do not include py-ref.h.
5132         * varobj.c: Do not include py-ref.h.
5133
5134 2019-01-22  Tom Tromey  <tom@tromey.com>
5135
5136         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5137         keyword for bcache.
5138
5139 2019-01-22  Tom Tromey  <tom@tromey.com>
5140
5141         * compile/compile-cplus-types.c: Remove a comment by #include.
5142
5143 2019-01-22  Tom Tromey  <tom@tromey.com>
5144
5145         * compile/gcc-c-plugin.h: Include compile-internal.h.
5146
5147 2019-01-22  Tom Tromey  <tom@tromey.com>
5148
5149         * stabsread.c (EXTERN): Do not define.
5150         (symnum, next_symbol_text_func, processing_gcc_compilation)
5151         (within_function, global_sym_chain, global_stabs)
5152         (previous_stab_code, this_object_header_files)
5153         (n_this_object_header_files)
5154         (n_allocated_this_object_header_files): Define.
5155         * stabsread.h (EXTERN): Never define.  Use "extern".
5156
5157 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5158
5159         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5160         history_value.
5161
5162 2019-01-21  Tom Tromey  <tom@tromey.com>
5163
5164         * ui-out.c: Fix includes.
5165         * tui/tui-source.c: Fix includes.
5166         * target.c: Fix includes.
5167         * remote.c: Fix includes.
5168         * regcache.c: Fix includes.
5169         * python/py-block.c: Fix includes.
5170         * printcmd.c: Fix includes.
5171         * or1k-tdep.c: Fix includes.
5172         * mi/mi-main.c: Fix includes.
5173         * m32r-tdep.c: Fix includes.
5174         * csky-tdep.c: Fix includes.
5175         * compile/compile-cplus-types.c: Fix includes.
5176         * cli/cli-interp.c: Fix includes.
5177
5178 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5179
5180         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5181         for padding.
5182
5183 2019-01-16  Tom Tromey  <tom@tromey.com>
5184
5185         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5186         earlier.
5187         (struct objfile) <msymbols_range>: Move from top level.
5188         <msymbols>: New method.
5189         (class objfile_msymbols): Remove.
5190         * symtab.c (default_collect_symbol_completion_matches_break_on):
5191         Update.
5192         * symmisc.c (dump_msymbols): Update.
5193         * stabsread.c (scan_file_globals): Update.
5194         * objc-lang.c (info_selectors_command, info_classes_command)
5195         (find_methods): Update.
5196         * minsyms.c (find_solib_trampoline_target): Update.
5197         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5198         * coffread.c (coff_symfile_read): Update.
5199         * ada-lang.c (ada_lookup_simple_minsym)
5200         (ada_collect_symbol_completion_matches): Update.
5201
5202 2019-01-16  Tom Tromey  <tom@tromey.com>
5203
5204         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5205         type.  Remove no-argument constructor.
5206         <iterator::operator++>: Simplify.
5207         <begin>: Update.
5208         <end>: Use minimal_symbol_count.
5209
5210 2019-01-16  Tom Tromey  <tom@tromey.com>
5211
5212         * objfiles.h (struct objfile) <psymtabs>: New method.
5213         (class objfile_psymtabs): Remove.
5214         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5215         typedef.
5216         <range>: New method.
5217         (require_partial_symbols): Change return type.
5218         * psymtab.c (require_partial_symbols)
5219         (psym_expand_symtabs_matching): Update.
5220         * mdebugread.c (parse_partial_symbols): Update.
5221         * dbxread.c (dbx_end_psymtab): Update.
5222
5223 2019-01-15  Tom Tromey  <tom@tromey.com>
5224
5225         * symtab.c (lookup_objfile_from_block)
5226         (lookup_symbol_in_objfile_symtabs)
5227         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5228         (find_line_symtab, info_sources_command)
5229         (default_collect_symbol_completion_matches_break_on)
5230         (make_source_files_completion_list): Update.
5231         * symmisc.c (print_objfile_statistics, dump_objfile)
5232         (maintenance_print_symbols, maintenance_info_symtabs)
5233         (maintenance_check_symtabs, maintenance_info_line_tables):
5234         Update.
5235         * source.c (select_source_symtab)
5236         (forget_cached_source_info_for_objfile): Update.
5237         * objfiles.h (class objfile_compunits): Remove.
5238         (struct objfile) <compunits_range>: New typedef.
5239         (compunits): New method.
5240         * objfiles.c (objfile_relocate1): Update.
5241         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5242         * maint.c (count_symtabs_and_blocks): Update.
5243         * linespec.c (iterate_over_all_matching_symtabs): Update.
5244         * cp-support.c (add_symbol_overload_list_qualified): Update.
5245         * coffread.c (coff_symtab_read): Update.
5246         * ada-lang.c (add_nonlocal_symbols)
5247         (ada_collect_symbol_completion_matches)
5248         (ada_add_global_exceptions): Update.
5249
5250 2019-01-15  Tom Tromey  <tom@tromey.com>
5251
5252         * progspace.h (program_space) <objfiles_safe_range>: New
5253         typedef.
5254         <objfiles_safe>: New method.
5255         * objfiles.h (class all_objfiles_safe): Remove.
5256         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5257         * jit.c (jit_inferior_exit_hook): Update.
5258
5259 2019-01-17  Tom Tromey  <tom@tromey.com>
5260
5261         * progspace.h (program_space) <objfiles_range>: New typedef.
5262         <objfiles>: New method.
5263         <objfiles_head>: Rename from objfiles.
5264         (object_files): Update.
5265         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5266         * guile/scm-pretty-print.c
5267         (ppscm_find_pretty_printer_from_objfiles): Update.
5268         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5269         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5270         Update.
5271         * python/py-progspace.c (pspy_get_objfiles): Update.
5272         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5273         Update.
5274         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5275         (objfpy_lookup_objfile_by_build_id): Update.
5276         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5277         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5278         Update.
5279         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5280         (expand_symtab_containing_pc, lookup_objfile_from_block)
5281         (lookup_static_symbol, basic_lookup_transparent_type)
5282         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5283         (find_line_symtab, info_sources_command)
5284         (default_collect_symbol_completion_matches_break_on)
5285         (make_source_files_completion_list, find_main_name): Update.
5286         * symmisc.c (print_symbol_bcache_statistics)
5287         (print_objfile_statistics, maintenance_print_symbols)
5288         (maintenance_print_msymbols, maintenance_print_objfiles)
5289         (maintenance_info_symtabs, maintenance_check_symtabs)
5290         (maintenance_expand_symtabs, maintenance_info_line_tables):
5291         Update.
5292         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5293         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5294         (map_overlay_command, unmap_overlay_command)
5295         (simple_overlay_update, expand_symtabs_matching)
5296         (map_symbol_filenames): Update.
5297         * symfile-debug.c (set_debug_symfile): Update.
5298         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5299         Update.
5300         * source.c (select_source_symtab, forget_cached_source_info):
5301         Update.
5302         * solib.c (solib_read_symbols): Update.
5303         * solib-spu.c (append_ocl_sos): Update.
5304         * psymtab.c (maintenance_print_psymbols)
5305         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5306         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5307         * printcmd.c (info_symbol_command): Update.
5308         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5309         Update.
5310         * objfiles.h (class all_objfiles): Remove.
5311         * objfiles.c (have_partial_symbols, have_full_symbols)
5312         (have_minimal_symbols, qsort_cmp, update_section_map)
5313         (shared_objfile_contains_address_p)
5314         (default_iterate_over_objfiles_in_search_order): Update.
5315         * objc-lang.c (info_selectors_command, info_classes_command)
5316         (find_methods): Update.
5317         * minsyms.c (find_solib_trampoline_target): Update.
5318         * maint.c (maintenance_info_sections)
5319         (maintenance_translate_address, count_symtabs_and_blocks):
5320         Update.
5321         * main.c (captured_main_1): Update.
5322         * linux-thread-db.c (try_thread_db_load_from_pdir)
5323         (has_libpthread): Update.
5324         * linespec.c (iterate_over_all_matching_symtabs)
5325         (search_minsyms_for_name): Update.
5326         * jit.c (jit_find_objf_with_entry_addr): Update.
5327         * hppa-tdep.c (find_unwind_entry)
5328         (hppa_lookup_stub_minimal_symbol): Update.
5329         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5330         Update.
5331         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5332         (elf_gnu_ifunc_resolve_by_got): Update.
5333         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5334         * dwarf-index-write.c (save_gdb_index_command): Update.
5335         * cp-support.c (add_symbol_overload_list_qualified): Update.
5336         * breakpoint.c (create_overlay_event_breakpoint)
5337         (create_longjmp_master_breakpoint)
5338         (create_std_terminate_master_breakpoint)
5339         (create_exception_master_breakpoint): Update.
5340         * blockframe.c (find_pc_partial_function): Update.
5341         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5342         (ada_collect_symbol_completion_matches)
5343         (ada_add_global_exceptions): Update.
5344
5345 2019-01-17  Tom Tromey  <tom@tromey.com>
5346
5347         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5348         declare VEC.
5349         (solib_target_parse_libraries): Change return type.
5350         (library_list_start_segment, library_list_start_section)
5351         (library_list_end_library, library_list_start_library); Update.
5352         (solib_target_free_library_list): Remove.
5353         (solib_target_parse_libraries): Remove cleanup.  Change return
5354         type.
5355         (solib_target_current_sos): Update.
5356
5357 2019-01-17  Tom Tromey  <tromey@bapiya>
5358
5359         * valprint.c: Replace "the the" with "the".
5360         * symtab.c: Replace "the the" with "the".
5361         * solib.c: Replace "the the" with "the".
5362         * solib-dsbt.c: Replace "the the" with "the".
5363         * linespec.c: Replace "the the" with "the".
5364         * dwarf2loc.h: Replace "the the" with "the".
5365         * amd64-windows-tdep.c: Replace "the the" with "the".
5366         * aarch64-tdep.c: Replace "the the" with "the".
5367
5368 2019-01-16  Keith Seitz  <keiths@redhat.com>
5369
5370         PR gdb/23773
5371         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5372         <builder>: Rename to ..
5373         <m_builder>: ... this and make private.
5374         (dwarf2_cu::get_builder): New method.  Change all users of
5375         `builder' to use this method.
5376         (dwarf2_start_symtab): Move to ...
5377         (dwarf2_cu::start_symtab): ... here.  Update all callers
5378         (setup_type_unit_groups): Move to ...
5379         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5380         callers.
5381         (dwarf2_cu::reset_builder): New method.
5382         (process_full_compunit, process_full_type_unit): Use
5383         dwarf2_cu::reset_builder.
5384         (follow_die_offset): Record the ancestor CU if it is different
5385         from the followed DIE's CU.
5386         (follow_die_sig_1): Likewise.
5387
5388 2019-01-15  Tom Tromey  <tom@tromey.com>
5389
5390         * remote.c (class remote_state) <buf>: Now a char_vector.
5391         <buf_size>: Remove.
5392         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5393         parameter.
5394         (remote_target::getpkt_or_notif_sane_1)
5395         (remote_target::getpkt_sane)
5396         (remote_target::getpkt_or_notif_sane): Likewise.
5397         (class remote_target) <putpkt>: New overload.
5398         (remote_target::read_frame): Change type of "buf_p".  Remove
5399         sizeof_p parameter.
5400         (packet_ok): New overload.
5401         (packet_check_result): New overload.
5402         Update all uses.
5403
5404 2019-01-14  Tom Tromey  <tom@tromey.com>
5405
5406         * remote-notif.c (handle_notification, remote_notif_ack)
5407         (remote_notif_parse): Make "buf" const.
5408         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5409         const.
5410         (remote_notif_parse, remote_notif_ack, handle_notification):
5411         Likewise.
5412         * remote.c (remote_notif_stop_parse): Make "buf" const.
5413         (remote_target::remote_parse_stop_reply): Make "buf" const.
5414         (remote_notif_stop_ack): Make "buf" const.
5415
5416 2019-01-14  Tom Tromey  <tom@tromey.com>
5417
5418         * remote.c (remote_console_output): Make parameter const.
5419
5420 2019-01-14  Tom Tromey  <tom@tromey.com>
5421
5422         * target-debug.h (target_debug_print_signals): Constify.
5423         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5424         * procfs.c (procfs_target::pass_signals): Update.
5425         * linux-nat.c (linux_nat_target::pass_signals): Update.
5426         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5427         * target-delegates.c: Rebuild.
5428         * remote.c (remote_target::program_signals): Update.
5429         (remote_target::pass_signals): Update.
5430         * target.c (target_pass_signals): Constify argument.
5431         (target_program_signals): Likewise.
5432         * target.h (struct target_ops) <pass_signals, program_signals>:
5433         Constify argument.
5434         (target_pass_signals, target_program_signals): Constify argument.
5435
5436 2019-01-14  Tom Tromey  <tom@tromey.com>
5437
5438         PR tui/28819:
5439         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5440
5441 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5442
5443         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5444         field.
5445         * rs6000-tdep.c: Include reggroups.h.
5446         (IS_V_ALIAS_PSEUDOREG): Define.
5447         (rs6000_register_name): Return names for the "vX" aliases.
5448         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5449         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5450         aliases.  Call default_register_reggroup_p for all other
5451         pseudo-registers.
5452         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5453         New functions.
5454         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5455         Handle "vX" aliases.
5456         (v_alias_pseudo_register_collect): New function.
5457         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5458         (rs6000_gdbarch_init): Initialize "vX" aliases as
5459         pseudo-registers.  Restore registration of
5460         rs6000_pseudo_register_reggroup_p with
5461         set_tdesc_pseudo_register_reggroup_p.
5462
5463 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5464
5465         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5466         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5467         set_gdbarch_num_pseudo_regs.
5468
5469 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5470
5471         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5472         Remove arg prefixname, add do_set and do_show.
5473         Add member functions set_list and show_list.
5474         * cli/cli-style.c (class cli_style_option): Update accordingly.
5475         (style_set_list): Move to file scope.
5476         (style_show_list): Likewise.
5477         (set_style): Call help_list.
5478         (show_style): Call cmd_show_list.
5479         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5480         Update to use the new macro.
5481
5482 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5483
5484         * ada-lang.c (_initialize_ada_language): Expand the help text
5485         for the "catch exception" command.
5486
5487 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5488
5489         * symtab.c (matching_obj_sections): Initialize obj,
5490         declare it closer to its usage.
5491
5492 2019-01-10  Tom Tromey  <tom@tromey.com>
5493
5494         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5495         (basic_inf_threads_range): Remove.
5496         (inf_threads_range, inf_non_exited_threads_range)
5497         (safe_inf_threads_range): Use next_adapter.
5498
5499 2019-01-10  Keith Seitz  <keiths@redhat.com>
5500
5501         PR gdb/23712
5502         PR symtab/23010
5503         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5504         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5505
5506 2019-01-10  Keith Seitz  <keiths@redhat.com>
5507
5508         PR gdb/23712
5509         PR symtab/23010
5510         * dictionary.c (pending_to_vector): Remove.
5511         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5512         Remove _1 suffix, replacing functions of the same name.  Update
5513         all callers.
5514         (dict_create_hashed, dict_create_hashed_expandable)
5515         (dict_create_linear, dict_create_linear_expandable, dict_free)
5516         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5517         Make functions static.
5518
5519 2019-01-10  Keith Seitz  <keiths@redhat.com>
5520
5521         PR gdb/23712
5522         PR symtab/23010
5523         * dictionary.h (struct dictionary): Replace declaration with
5524         multidictionary.
5525         (dict_create_hashed, dict_create_hashed_expandable)
5526         (dict_create_linear, dict_create_linear_expandable)
5527         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5528         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5529         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5530         taking multidictionary argument.
5531         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5532         * block.h (struct block) <dict>: Change to multidictionary
5533         and rename `multidict'.
5534         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5535         symmisc.c: Update all dictionary references to multidictionary.
5536
5537 2019-01-10  Keith Seitz  <keiths@redhat.com>
5538
5539         PR gdb/23712
5540         PR symtab/23010
5541         * dictionary.c: Include unordered_map.
5542         (pending_to_vector): New function.
5543         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5544         Rewrite the non-"_1" functions to take vector instead
5545         of linked list.
5546         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5547         "new" _1 versions of the same name.
5548         (multidictionary): Define.
5549         (std::hash<enum language): New definition.
5550         (collate_pending_symbols_by_language, mdict_create_hashed)
5551         (mdict_create_hashed_expandable, mdict_create_linear)
5552         (mdict_create_linear_expandable, mdict_free)
5553         (find_language_dictionary, create_new_language_dictionary)
5554         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5555         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5556         (mdict_size, mdict_empty): New functions.
5557         * dictionary.h (mdict_iterator): Define.
5558
5559 2019-01-10  Pedro Alves  <palves@redhat.com>
5560
5561         * breakpoint.c (read_uploaded_action)
5562         (create_tracepoint_from_upload): Adjust to use
5563         gdb::unique_xmalloc_ptr.
5564         * ctf.c (ctf_write_uploaded_tp):
5565         (SET_ARRAY_FIELD): Use emplace_back.
5566         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5567         * tracefile-tfile.c (tfile_write_uploaded_tp):
5568         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5569         gdb::unique_xmalloc_ptr.
5570         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5571         at_string, cond_string, cmd_strings>: Replace char pointers
5572         with gdb::unique_xmalloc_ptr.
5573
5574 2019-01-10  Pedro Alves  <palves@redhat.com>
5575
5576         * solib-target.c (library_list_start_library): Don't xstrdup name.
5577
5578 2019-01-10  Pedro Alves  <palves@redhat.com>
5579
5580         * mdebugread.c (parse_partial_symbols): Use
5581         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5582
5583 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * linux-fork.c (scoped_switch_fork_info)
5586         <~scoped_switch_fork_info>: Fix incorrect variable name.
5587
5588 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5589
5590         * linux-fork.c (scoped_switch_fork_info)
5591         <scoped_switch_fork_info>: Make explicit.
5592         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5593
5594 2019-01-10  Tom Tromey  <tom@tromey.com>
5595
5596         * objfiles.h (objfile::reset_psymtabs): Update.
5597         * objfiles.c (objfile::objfile): Update.
5598         * psymtab.h (psymtab_storage::obstack): Update.
5599         (psymtab_storage::m_obstack): Use gdb::optional.
5600         (class psymtab_storage): Update comment.  Remove objfile
5601         parameter.
5602         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5603
5604 2019-01-10  Tom Tromey  <tom@tromey.com>
5605
5606         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5607         <free_psymtabs>: Now private.
5608         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5609         (allocate_psymtab): Use new method.
5610
5611 2019-01-10  Tom Tromey  <tom@tromey.com>
5612
5613         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5614         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5615         * mdebugread.c (parse_partial_symbols): Use
5616         allocate_dependencies.
5617         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5618         allocate_dependencies.
5619         (process_psymtab_comp_unit_reader)
5620         (build_type_psymtab_dependencies): Likewise.
5621         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5622
5623 2019-01-10  Tom Tromey  <tom@tromey.com>
5624
5625         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5626         PSYMBOL_SET_LANGUAGE.
5627         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5628
5629 2019-01-10  Tom Tromey  <tom@tromey.com>
5630
5631         * psymtab.h (psymtab_storage::obstack): New method.
5632         <m_obstack>: Rename from obstack; now private.
5633         * psymtab.c (psymtab_storage): Update.
5634         * dwarf2read.c (create_addrmap_from_index)
5635         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5636         Update.
5637
5638 2019-01-10  Tom Tromey  <tom@tromey.com>
5639
5640         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5641         * objfiles.h (objfile::reset_psymtabs): New method.
5642
5643 2019-01-10  Tom Tromey  <tom@tromey.com>
5644
5645         * symmisc.c (print_symbol_bcache_statistics): Update.
5646         (print_objfile_statistics): Update.
5647         * symfile.c (reread_symbols): Update.
5648         * psymtab.h (class psymtab_storage): New.
5649         * psymtab.c (psymtab_storage): New constructor.
5650         (~psymtab_storage): New destructor.
5651         (require_partial_symbols): Update.
5652         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5653         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5654         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5655         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5656         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5657         (start_psymtab_common, end_psymtab_common)
5658         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5659         (allocate_psymtab): Update.
5660         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5661         Update.
5662         (dump_psymtab_addrmap, maintenance_print_psymbols)
5663         (maintenance_check_psymtabs): Update.
5664         (class objfile_psymtabs): Move to objfiles.h.
5665         * psympriv.h (discard_psymtab): Now inline.
5666         (psymtab_discarder::psymtab_discarder): Update.
5667         (psymtab_discarder::~psymtab_discarder): Update.
5668         (ALL_OBJFILE_PSYMTABS): Rewrite.
5669         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5670         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5671         Remove fields.
5672         <partial_symtabs>: New field.
5673         (class objfile_psymtabs): Move from psymtab.h.  Update.
5674         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5675         psymbol_cache.
5676         (objfile::~objfile): Don't destroy psymbol_cache.
5677         * mdebugread.c (parse_partial_symbols): Update.
5678         * dwarf2read.c (create_addrmap_from_index)
5679         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5680         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5681         (add_partial_subprogram, dwarf2_ranges_read): Update.
5682         * dwarf-index-write.c (write_address_map)
5683         (write_one_signatured_type, recursively_write_psymbols)
5684         (class debug_names, class debug_names, write_psymtabs_to_index):
5685         Update.
5686
5687 2019-01-10  Tom Tromey  <tom@tromey.com>
5688
5689         * symtab.h (SYMBOL_SET_NAMES): Update.
5690         (symbol_set_names): Update.
5691         (MSYMBOL_SET_NAMES): Update.
5692         * symtab.c (symbol_set_names): Change argument to be an
5693         objfile_per_bfd_storage.
5694         * psymtab.c (add_psymbol_to_bcache): Update.
5695         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5696
5697 2019-01-10  Tom Tromey  <tom@tromey.com>
5698
5699         * symtab.c (create_demangled_names_hash): Change argument to be an
5700         objfile_per_bfd_storage.
5701         (symbol_set_names): Update.
5702
5703 2019-01-10  Tom Tromey  <tom@tromey.com>
5704
5705         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5706         init_psymbol_list.
5707         * psymtab.c (init_psymbol_list): Do nothing if already called.
5708         * psympriv.h (init_psymbol_list): Add comment.
5709         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5710         init_psymbol_list.
5711         * dbxread.c (dbx_symfile_read): Unconditionally call
5712         init_psymbol_list.
5713
5714 2019-01-10  Tom Tromey  <tom@tromey.com>
5715
5716         * xcoffread.c (scan_xcoff_symtab): Update.
5717         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5718         "where".
5719         * mdebugread.c (parse_partial_symbols)
5720         (handle_psymbol_enumerators): Update.
5721         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5722         * dbxread.c (read_dbx_symtab): Update.
5723         * psympriv.h (psymbol_placement): New enum.
5724         (add_psymbol_to_list): Update.
5725
5726 2019-01-10  Tom Tromey  <tom@tromey.com>
5727
5728         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5729         static_psymbols parameters.
5730         (scan_xcoff_symtab): Update.
5731         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5732         static_psymbols parameters.
5733         * psympriv.h (start_psymtab_common): Update.
5734         * mdebugread.c (parse_partial_symbols): Update.
5735         * dwarf2read.c (create_partial_symtab): Update.
5736         * dbxread.c (read_dbx_symtab): Update.
5737         (start_psymtab): Remove global_psymbols and static_psymbols
5738         parameters.
5739
5740 2019-01-10  Tom Tromey  <tom@tromey.com>
5741
5742         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5743         * psymtab.c (allocate_psymtab): Add comment.
5744         * psympriv.h (allocate_psymtab): Add comment.
5745         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5746         initializations.
5747         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5748
5749 2019-01-10  Tom Tromey  <tom@tromey.com>
5750
5751         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5752         Don't declare.
5753         * mipsread.c: Include mdebugread.h.
5754         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5755         Declare.
5756         * elfread.c: Include mdebugread.h.
5757
5758 2019-01-09  Tom Tromey  <tom@tromey.com>
5759
5760         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5761         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5762         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5763         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5764         (psym_lookup_symbol, psym_find_last_source_symtab)
5765         (psym_forget_cached_source_info, psym_print_stats)
5766         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5767         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5768         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5769         (psym_find_compunit_symtab_by_address)
5770         (maintenance_print_psymbols, maintenance_info_psymtabs)
5771         (maintenance_check_psymtabs): Use ranged for.
5772         * psymtab.h (class objfile_psymtabs): New.
5773         (require_partial_symbols): Return objfile_psymtabs.
5774         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5775
5776 2019-01-09  Tom Tromey  <tom@tromey.com>
5777
5778         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5779         (find_pc_mapped_section, list_overlays_command)
5780         (map_overlay_command, unmap_overlay_command)
5781         (simple_overlay_update): Use all_objfiles.
5782         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5783         * printcmd.c (info_symbol_command): Use all_objfiles.
5784         * objfiles.h (ALL_OBJSECTIONS): Remove.
5785         * maint.c (maintenance_translate_address): Use all_objfiles.
5786         * gcore.c (gcore_create_callback): Use all_objfiles.
5787         (objfile_find_memory_regions): Likewise.
5788
5789 2019-01-09  Tom Tromey  <tom@tromey.com>
5790
5791         * symtab.c (find_line_symtab, info_sources_command)
5792         (make_source_files_completion_list): Use objfile_compunits.
5793         * source.c (select_source_symtab): Use objfile_compunits.
5794         * objfiles.h (struct objfile): Update comment.
5795         (ALL_OBJFILES): Remove.
5796         (ALL_FILETABS): Remove.
5797         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5798         objfile_compunits.
5799
5800 2019-01-09  Tom Tromey  <tom@tromey.com>
5801
5802         * symmisc.c (print_objfile_statistics, dump_objfile)
5803         (maintenance_print_symbols): Use compunit_filetabs.
5804         * source.c (forget_cached_source_info_for_objfile): Use
5805         compunit_filetabs.
5806         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5807         (ALL_FILETABS): Use compunit_filetabs.
5808         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5809         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5810
5811 2019-01-09  Tom Tromey  <tom@tromey.com>
5812
5813         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5814         (compunit_filetabs): New.
5815         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5816         compunit_filetabs.
5817         (info_sources_command, make_source_files_completion_list): Remove
5818         declaration.
5819         * symmisc.c (print_objfile_statistics, dump_objfile)
5820         (maintenance_print_symbols): Remove declaration.
5821         (maintenance_info_symtabs): Use compunit_filetabs.
5822         (maintenance_info_line_tables): Likewise.
5823         * source.c (select_source_symtab): Change local variable name.
5824         (forget_cached_source_info_for_objfile): Remove declaration.
5825         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5826         * objfiles.c (objfile_relocate1): Remove declaration.
5827         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5828         declaration.
5829         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5830         * coffread.c (coff_symtab_read): Remove declaration.
5831         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5832         compunit_filetabs.
5833
5834 2019-01-09  Tom Tromey  <tom@tromey.com>
5835
5836         * symtab.c (lookup_objfile_from_block)
5837         (find_pc_sect_compunit_symtab, search_symbols)
5838         (default_collect_symbol_completion_matches_break_on): Use
5839         objfile_compunits.
5840         * objfiles.h (ALL_COMPUNITS): Remove.
5841         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5842         * cp-support.c (add_symbol_overload_list_qualified): Use
5843         objfile_compunits.
5844         * ada-lang.c (ada_collect_symbol_completion_matches)
5845         (ada_add_global_exceptions): Use objfile_compunits.
5846
5847 2019-01-09  Tom Tromey  <tom@tromey.com>
5848
5849         * source.c (select_source_symtab)
5850         (forget_cached_source_info_for_objfile): Remove declaration.
5851         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5852         declaration.
5853         * maint.c (count_symtabs_and_blocks): Remove declaration.
5854         * cp-support.c (add_symbol_overload_list_qualified): Remove
5855         declaration.
5856         * coffread.c (coff_symtab_read): Remove declaration.
5857         * symtab.c (lookup_symbol_in_objfile_symtabs)
5858         (basic_lookup_transparent_type_1): Use objfile_compunits.
5859         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5860         (info_sources_command, search_symbols)
5861         (default_collect_symbol_completion_matches_break_on)
5862         (make_source_files_completion_list): Remove declaration.
5863         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5864         (ada_collect_symbol_completion_matches)
5865         (ada_add_global_exceptions): Remove declaration.
5866         * linespec.c (iterate_over_all_matching_symtabs): Use
5867         objfile_compunits.
5868         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5869         (class objfile_compunits): New.
5870         (ALL_COMPUNITS): Use objfile_compunits.
5871         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5872         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5873         objfile_compunits.
5874         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5875
5876 2019-01-09  Tom Tromey  <tom@tromey.com>
5877
5878         * symtab.c (search_symbols)
5879         (default_collect_symbol_completion_matches_break_on): Use
5880         objfile_msymbols.
5881         * ada-lang.c (ada_lookup_simple_minsym)
5882         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5883         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5884         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5885         objfile_msymbols.
5886         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5887         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5888         * objc-lang.c (find_methods): Use objfile_msymbols.
5889         (info_selectors_command, info_classes_command): Likewise.
5890         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5891         * objfiles.h (class objfile_msymbols): New.
5892         (ALL_OBJFILE_MSYMBOLS): Remove.
5893         (ALL_MSYMBOLS): Remove.
5894
5895 2019-01-09  Tom Tromey  <tom@tromey.com>
5896
5897         * common/next-iterator.h (next_adapter): Add Iterator template
5898         parameter.
5899         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5900         (class all_objfiles_safe): New.
5901         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5902         * objfiles.c (put_objfile_before): Update comment.
5903         (add_separate_debug_objfile): Likewise.
5904         (free_all_objfiles): Use all_objfiles_safe.
5905         (objfile_purge_solibs): Likewise.
5906
5907 2019-01-09  Tom Tromey  <tom@tromey.com>
5908
5909         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5910         (expand_symtab_containing_pc, lookup_static_symbol)
5911         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5912         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5913         all_objfiles.
5914         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5915         * breakpoint.c (create_overlay_event_breakpoint)
5916         (create_longjmp_master_breakpoint)
5917         (create_std_terminate_master_breakpoint)
5918         (create_exception_master_breakpoint): Use all_objfiles.
5919         * linux-thread-db.c (try_thread_db_load_from_pdir)
5920         (has_libpthread): Use all_objfiles.
5921         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5922         * linespec.c (iterate_over_all_matching_symtabs)
5923         (search_minsyms_for_name): Use all_objfiles.
5924         * maint.c (maintenance_info_sections): Use all_objfiles.
5925         * main.c (captured_main_1): Use all_objfiles.
5926         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5927         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5928         * guile/scm-pretty-print.c
5929         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5930         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5931         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5932         (maintenance_print_msymbols): Use all_objfiles.
5933         * source.c (select_source_symtab): Use all_objfiles.
5934         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5935         * symfile.c (remove_symbol_file_command)
5936         (expand_symtabs_matching, map_symbol_filenames): Use
5937         all_objfiles.
5938         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5939         all_objfiles.
5940         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5941         * objc-lang.c (find_methods): Use all_objfiles.
5942         * objfiles.c (have_partial_symbols, have_full_symbols)
5943         (have_minimal_symbols, qsort_cmp)
5944         (default_iterate_over_objfiles_in_search_order): Use
5945         all_objfiles.
5946         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5947         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5948         (maintenance_check_psymtabs): Use all_objfiles.
5949         (ALL_PSYMTABS): Remove.
5950         * compile/compile-object-run.c (do_module_cleanup): Use
5951         all_objfiles.
5952         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5953         * cp-support.c (add_symbol_overload_list_qualified): Use
5954         all_objfiles.
5955         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5956         Use all_objfiles.
5957         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5958         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5959         all_objfiles.
5960         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5961         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5962         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5963         Uses all_objfiles.
5964         * solib.c (solib_read_symbols): Use all_objfiles
5965
5966 2019-01-09  Tom Tromey  <tom@tromey.com>
5967
5968         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5969         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5970         all_objfiles.
5971         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5972         * symmisc.c (print_symbol_bcache_statistics)
5973         (print_objfile_statistics, maintenance_print_objfiles)
5974         (maintenance_info_symtabs, maintenance_check_symtabs)
5975         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5976         all_objfiles.
5977         * source.c (forget_cached_source_info): Use all_objfiles.
5978         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5979         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5980         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5981         * objfiles.c (update_section_map): Use all_objfiles.
5982         (shared_objfile_contains_address_p): Likewise.
5983         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5984         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5985
5986 2019-01-09  Tom Tromey  <tom@tromey.com>
5987
5988         * common/next-iterator.h: New file.
5989         * objfiles.h (class all_objfiles): New.
5990         (struct objfile_iterator): New.
5991
5992 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5993
5994         * NEWS: Move the description of the changed "frame", "select-frame",
5995          and "info frame" commands to the Changed commands section.
5996
5997 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5998
5999         * gdbtypes.c (check_stub_method_group): Remove handling of old
6000         mangling schemes.
6001         * linespec.c (find_methods): Likewise.
6002         * stabsread.c (read_member_functions): Likewise.
6003         * valops.c (search_struct_method): Likewise.
6004         (value_struct_elt_for_reference): Likewise.
6005         * NEWS: Mention this change.
6006
6007 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6010         print_source_lines.
6011         * source.c (print_source_lines_base): Update line number check.
6012         (print_source_lines): New function.
6013         (source_lines_range::source_lines_range): New function.
6014         * source.h (class source_lines_range): New class.
6015         (print_source_lines): New declaration.
6016
6017 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6018
6019         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6020
6021 2019-01-08  Tom Tromey  <tom@tromey.com>
6022             Simon Marchi  <simon.marchi@ericsson.com>
6023
6024         PR gdb/24060
6025         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6026         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6027         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6028         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6029         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6030         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6031
6032 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6033
6034         * source.c (select_source_symtab): Move header comment to
6035         declaration in source.h.
6036         (forget_cached_source_info_for_objfile): Likewise.
6037         (forget_cached_source_info): Likewise.
6038         (identify_source_line): Likewise.
6039         * source.h (identify_source_line): Move declaration from symtab.h
6040         and add comment from source.c
6041         (print_source_lines): Likewise.
6042         (forget_cached_source_info_for_objfile): Likewise.
6043         (forget_cached_source_info): Likewise.
6044         (select_source_symtab): Likewise.
6045         (enum print_source_lines_flag): Move definition from symtab.h.
6046         * symtab.h (identify_source_line): Move declaration to source.h.
6047         (print_source_lines): Likewise.
6048         (forget_cached_source_info_for_objfile): Likewise.
6049         (forget_cached_source_info): Likewise.
6050         (select_source_symtab): Likewise.
6051         (enum print_source_lines_flag): Move definition to source.h.
6052         * tui/tui-hooks.c: Add 'source.h' include.
6053
6054 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6055
6056         * source.c (print_source_lines_base): Handle requests to print
6057         reverse line number sequences, and guard against empty lines
6058         string.
6059
6060 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6061
6062         * source.c (print_source_lines_base): Fix skip of '\r' if next
6063         character is '\n'.
6064
6065 2019-01-06  Tom Tromey  <tom@tromey.com>
6066
6067         * c-exp.y (struct c_parse_state) <macro_original_text,
6068         expansion_obstack>: New member.
6069         (macro_original_text, expansion_obstack): Remove globals.
6070         (scan_macro_expansion, scanning_macro_expansion)
6071         (finished_macro_expansion): Update.
6072         (scan_macro_cleanup): Remove.
6073         (yylex, c_parse): Update.
6074
6075 2019-01-06  Tom Tromey  <tom@tromey.com>
6076
6077         * c-exp.y (struct c_parse_state) <strings>: New member.
6078         (operator_stoken): Update.
6079
6080 2019-01-06  Tom Tromey  <tom@tromey.com>
6081
6082         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6083         (union type_stack_elt) <typelist_val>: Now a pointer to
6084         std::vector.
6085         (type_stack_cleanup): Don't declare.
6086         (push_typelist): Update.
6087         * parse.c (pop_typelist): Return a std::vector.
6088         (push_typelist): Take a std::vector.
6089         (follow_types): Update.  Do not free args.
6090         (type_stack_cleanup): Remove.
6091         * c-exp.y (struct c_parse_state): New.
6092         (cpstate): New global.
6093         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6094         (nonempty_typelist): Update.
6095         (func_mod): Create a new vector.
6096         (c_parse): Create a c_parse_state.
6097         (check_parameter_typelist): Do not delete params.
6098         (function_method): Update.  Do not delete type_list.
6099
6100 2019-01-06  Tom Tromey  <tom@tromey.com>
6101
6102         PR gdb/28155:
6103         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6104         check_typedef.
6105         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6106         (print_return_value): Likewise.
6107
6108 2019-01-05  Tom Tromey  <tom@tromey.com>
6109
6110         * contrib/cleanup_check.py: Remove.
6111         * contrib/gcc-with-excheck: Remove.
6112         * contrib/exsummary.py: Remove.
6113         * contrib/excheck.py: Remove.
6114
6115 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6116
6117         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6118         NULL. Initialize tpprev to NULL instead of assigning it
6119         to NULL on the next statement.
6120         * windows-nat.c (windows_delete_thread): Remove check for
6121         main_thread_id before printing thread exit notifications.
6122         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6123         Remove thread ID check against main_thread_id.
6124         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6125         windows_delete_thread.
6126         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6127
6128 2019-01-04  Tom Tromey  <tom@tromey.com>
6129
6130         * compile/compile.c (_initialize_compile): Use upper case for
6131         metasyntactic variables.
6132         * symmisc.c (_initialize_symmisc): Use upper case for
6133         metasyntactic variables.
6134         * psymtab.c (_initialize_psymtab): Use upper case for
6135         metasyntactic variables.
6136         * demangle.c (demangle_command): Use upper case for metasyntactic
6137         variables.
6138         (_initialize_demangler): Likewise.
6139         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6140         variables.
6141
6142 2019-01-03  Tom Tromey  <tom@tromey.com>
6143
6144         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6145
6146 2019-01-03  Tom Tromey  <tom@tromey.com>
6147
6148         * python/py-symtab.c (salpy_str): Update.
6149         (struct salpy_sal_object) <symtab>: Now a PyObject.
6150         (salpy_dealloc): Update.
6151         (del_objfile_sal): Use gdbpy_ref.
6152
6153 2019-01-03  Tom Tromey  <tom@tromey.com>
6154
6155         * python/py-type.c (convert_field): Use new_reference.  Return
6156         gdbpy_ref.
6157         (make_fielditem): Return gdbpy_ref.
6158         (typy_fields): Update.
6159         (typy_getitem): Update.
6160         (field_name): Return gdbpy_ref.  Use new_reference.
6161         (typy_iterator_iternext): Update.
6162
6163 2019-01-03  Tom Tromey  <tom@tromey.com>
6164
6165         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6166
6167 2019-01-03  Tom Tromey  <tom@tromey.com>
6168
6169         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6170         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6171         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6172         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6173         (pspy_set_type_printers): Likewise.
6174         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6175         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6176         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6177         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6178         (objfpy_set_type_printers): Likewise.
6179
6180 2019-01-03  Tom Tromey  <tom@tromey.com>
6181
6182         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6183         (gdbpy_print_stack): Use gdbpy_err_fetch.
6184         * python/python-internal.h (class gdbpy_err_fetch): New class.
6185         (class gdbpy_enter) <m_error_type, m_error_value,
6186         m_error_traceback>: Remove.
6187         <m_error>: New member.
6188         (gdbpy_exception_to_string): Don't declare.
6189         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6190         * python/py-value.c (convert_value_from_python): Use
6191         gdbpy_err_fetch.
6192         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6193         gdbpy_exception_to_string.
6194         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6195         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6196         gdbpy_err_fetch.
6197
6198 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6199
6200         * linux-nat.c (delete_lwp_cleanup): Delete.
6201         (struct lwp_deleter): New struct.
6202         (lwp_info_up): New typedef.
6203         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6204         lwp_info_up.
6205
6206 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * linux-fork.c (class scoped_switch_fork_info): New class.
6209         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6210
6211 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6212
6213         * valops.c (find_overload_match): Remove use of null_cleanup, and
6214         calls to do_cleanups.
6215
6216 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6217
6218         * compile/compile-cplus-types.c
6219         (compile_cplus_instance::decl_name): Handle changes to
6220         cp_func_name.
6221         * cp-support.c (cp_func_name): Update header comment, update
6222         return type.
6223         * cp-support.h (cp_func_name): Update return type in declaration.
6224         * valops.c (find_overload_match): Move temp_func local to top
6225         level of function and change its type.  Use temp_func to hold and
6226         delete temporary string obtained from cp_func_name.
6227
6228 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6229
6230         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6231         gdb::char_vector, remove cleanup, and update uses of `msg`.
6232
6233 2019-01-03  Jim Wilson  <jimw@sifive.com>
6234
6235         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6236
6237 2019-01-02  Tom Tromey  <tom@tromey.com>
6238
6239         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6240         (tdesc_parse_xml): Remove cleanups.
6241         * target-descriptions.h (make_cleanup_free_target_description):
6242         Don't declare.
6243         (target_desc_deleter): New struct.
6244         (target_desc_up): New typedef.
6245         * target-descriptions.c (target_desc_deleter::operator()): Rename
6246         from free_target_description.
6247         (make_cleanup_free_target_description): Remove.
6248
6249 2019-01-02  Tom Tromey  <tom@tromey.com>
6250
6251         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6252         constructor, destructor.
6253         (linespec_parser): Remove typedef.
6254         (~linespec_parser): Rename from linespec_parser_delete.
6255         (linespec_lex_to_end, linespec_complete_label)
6256         (linespec_complete): Update.
6257         (decode_line_full): Remove cleanups.
6258         (decode_line_1): Update.
6259
6260 2019-01-02  Tom Tromey  <tom@tromey.com>
6261
6262         * python/python-internal.h (inferior_to_inferior_object): Change
6263         return type.
6264         * python/py-exitedevent.c (create_exited_event_object): Update.
6265         * python/py-inferior.c (inferior_to_inferior_object): Return
6266         gdbpy_ref.
6267         (python_new_inferior, python_inferior_deleted)
6268         (thread_to_thread_object, delete_thread_object)
6269         (build_inferior_list, gdbpy_selected_inferior): Update.
6270         * python/py-infthread.c (create_thread_object): Update.  Also fail
6271         if inferior_to_inferior_object fails.
6272
6273 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6274
6275         * inferior.h (class inferior) <displaced_step_state>: New field.
6276         * infrun.h (struct displaced_step_state): Move here from
6277         infrun.c.  Initialize fields, add constructor.
6278         <inf>: Remove field.
6279         <reset>: New method.
6280         * infrun.c (struct displaced_step_inferior_state): Move to
6281         infrun.h.
6282         (displaced_step_inferior_states): Remove.
6283         (get_displaced_stepping_state): Adust.
6284         (displaced_step_in_progress_any_inferior): Adjust.
6285         (displaced_step_in_progress_thread): Adjust.
6286         (displaced_step_in_progress): Adjust.
6287         (add_displaced_stepping_state): Remove.
6288         (get_displaced_step_closure_by_addr): Adjust.
6289         (remove_displaced_stepping_state): Remove.
6290         (infrun_inferior_exit): Call displaced_step_state.reset.
6291         (use_displaced_stepping): Don't check for NULL.
6292         (displaced_step_prepare_throw): Call
6293         get_displaced_stepping_state.
6294         (displaced_step_fixup): Don't check for NULL.
6295         (prepare_for_detach): Don't check for NULL.
6296
6297 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6298
6299         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6300          in case of call that did not complete.
6301
6302 2019-01-02  Andrey Utkin  <autkin@undo.io>
6303
6304         * symfile.c (find_separate_debug_file): Fix search of debug files for
6305         remote debuggee.
6306
6307 2019-01-02  Tom Tromey  <tom@tromey.com>
6308
6309         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6310         indentation.
6311         * python/py-frame.c (frapy_older): Remove cast.
6312         (frapy_newer): Likewise.
6313         * python/py-breakpoint.c (local_setattro): Remove cast.
6314         * python/py-arch.c (archpy_name): Remove local variable.
6315         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6316
6317 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6318
6319         * unittests/basic_string_view/element_access/char/empty.cc:
6320         Fix year range in copyright header.
6321
6322 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6323
6324         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6325         Delete.
6326         <operator==>: Update with for removed field.
6327         <hash>: Likewise.
6328         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6329         <isa_features>: ...this.
6330         <abi_features>: New field.
6331         (riscv_isa_flen): Update comment.
6332         (riscv_abi_xlen): New declaration.
6333         (riscv_abi_flen): New declaration.
6334         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6335         isa_features.
6336         (riscv_abi_xlen): New function.
6337         (riscv_isa_flen): Update to get answer from isa_features.
6338         (riscv_abi_flen): New function.
6339         (riscv_has_fp_abi): Update to get answer from abi_features.
6340         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6341         xlen and flen.
6342         (riscv_call_info) <xlen, flen>: Update comment.
6343         (riscv_call_arg_struct): Remove invalid assertions
6344         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6345         is removed.
6346         (riscv_gdbarch_init): Gather isa features and abi features
6347         separately, ensure both match on the gdbarch when reusing an old
6348         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6349         a target with 64-bit float hardware.
6350
6351 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6352
6353         * source.c (search_command_helper): Stop reverse search
6354         when line 1 has been searched.
6355
6356 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6357
6358         * record-full.c (record_full_base_target::close): Rewrite
6359         record_full_core_buf_list free logic.
6360
6361 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6362
6363         * break-catch-syscall.c (print_one_catch_syscall): xfree
6364         the last text.
6365
6366 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6367
6368         * top.c (print_gdb_version): Update Copyright year in version
6369         message.
6370
6371 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6372
6373         Update copyright year range in all GDB files.
6374
6375 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6376
6377         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6378
6379 For older changes see ChangeLog-2018.
6380 \f
6381 Local Variables:
6382 mode: change-log
6383 left-margin: 8
6384 fill-column: 74
6385 version-control: never
6386 coding: utf-8
6387 End:
6388