gdb/ChangeLog

   1 2019-10-01  Pedro Alves  <palves@redhat.com>
   2             Tom Tromey  <tom@tromey.com>
   3
   4         * symtab.c (print_symbol_info): Use %ps.
   5         (print_msymbol_info): Use %ps.
   6         * symfile.c (symbol_file_add_with_addrs): Use %ps.
   7         * printcmd.c (print_variable_and_value): Use %ps.
   8         * macrocmd.c (show_pp_source_pos): Use %ps.
   9         * infrun.c (print_exited_reason): Use ui_out::message.
  10         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
  11         (describe_other_breakpoints): Use ui_out::message and new
  12         formats.
  13         (say_where): Use new formats.
  14         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
  15         and new formats.
  16
  17 2019-10-01  Pedro Alves  <palves@redhat.com>
  18             Tom Tromey  <tom@tromey.com>
  19
  20         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
  21         (test_gdb_formats): New function.
  22         (run_tests): Call it.
  23         (test_format_specifier): Update.
  24         * utils.h (fputs_filtered): Update comment.
  25         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
  26         (fputs_styled_unfiltered): Declare.
  27         * utils.c (fputs_styled_unfiltered): New function.
  28         (vfprintf_maybe_filtered): Add gdbfmt parameter.
  29         (vfprintf_filtered): Update.
  30         (vfprintf_unfiltered, vprintf_filtered): Update.
  31         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
  32         * ui-out.h (enum ui_out_flag) <unfiltered_output,
  33         disallow_ui_out_field>: New constants.
  34         (enum class field_kind): New.
  35         (struct base_field_s, struct signed_field_s): New.
  36         (signed_field): New function.
  37         (struct string_field_s): New.
  38         (string_field): New function.
  39         (struct styled_string_s): New.
  40         (styled_string): New function.
  41         (class ui_out) <message>: Add comment.
  42         <vmessage, call_do_message>: New methods.
  43         <do_message>: Add style parameter.
  44         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
  45         methods.
  46         (ui_out::message): Rewrite.
  47         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
  48         parameter.
  49         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
  50         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
  51         gdb_extensions parameter.
  52         (class format_piece): Add parameter to constructor.
  53         (n_int_args): New field.
  54         * gdbsupport/format.c (format_pieces::format_pieces): Add
  55         gdb_extensions parameter.  Handle '*'.
  56         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
  57         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
  58         vfprintf_styled_no_gdbfmt.
  59         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
  60         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
  61         unfiltered output.
  62         * ui-style.h (struct ui_file_style) <ptr>: New method.
  63
  64 2019-10-01  Tom Tromey  <tom@tromey.com>
  65
  66         * unittests/format_pieces-selftests.c: Update.  Add final format.
  67         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
  68         empty literal pieces.
  69
  70 2019-10-01  Tom Tromey  <tom@tromey.com>
  71
  72         * ui-out.h (enum class ui_out_style_kind): Remove.
  73         (class ui_out) <field_string, field_stsream, do_field_string>:
  74         Change type of "style".
  75         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
  76         (ui_out::field_string): Update.
  77         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
  78         of "style".
  79         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
  80         * tracepoint.c (print_one_static_tracepoint_marker): Update.
  81         * stack.c (print_frame_arg, print_frame_info, print_frame):
  82         Update.
  83         * source.c (print_source_lines_base): Update.
  84         * solib.c (info_sharedlibrary_command): Update.
  85         * skip.c (info_skip_command): Update.
  86         * record-btrace.c (btrace_call_history_src_line)
  87         (btrace_call_history): Update.
  88         * python/py-framefilter.c (py_print_frame): Update.
  89         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
  90         "style".
  91         * mi/mi-out.c (mi_ui_out::do_table_header)
  92         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
  93         (mi_ui_out::do_field_string): Update.
  94         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  95         Update.
  96         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
  97         "style".
  98         * cli-out.c (cli_ui_out::do_table_header)
  99         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 100         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 101         (cli_ui_out::do_field_fmt): Update.
 102         * breakpoint.c (print_breakpoint_location): Update.
 103         (update_static_tracepoint): Update.
 104
 105 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 106
 107         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 108         conversion of gdb_datadir.
 109         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 110         remove not needed c_str ().
 111
 112 2019-09-30  Ali Tamur <tamur@google.com>
 113
 114         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 115         (dwarf2_string_attr): Likewise.
 116
 117 2019-09-30  Ali Tamur <tamur@google.com>
 118
 119         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 120         (process_full_type_unit): Likewise.
 121         (dump_die_shallow): Likewise.
 122         (cu_debug_loc_section): Likewise.
 123
 124 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 125
 126         * minsyms.c (compare_minimal_symbols): Rename to...
 127         (minimal_symbol_is_less_than): ...this, and adjust to STL
 128         conventions (return bool, take arguments as references)
 129         (minimal_symbol_reader::install): Call std::sort instead
 130         of qsort.
 131
 132 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 133
 134         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 135         hash and why.
 136         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 137         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 138
 139 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 140
 141         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 142         * psympriv.h (add_psymbol_to_list): Move comment here and update
 143         it.
 144
 145 2019-09-29  Tom de Vries  <tdevries@suse.de>
 146
 147         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 148         Use $tmpdir/$(basename "$output_file").dwz instead of
 149         "${output_file}.dwz".
 150
 151 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 152
 153         PR gdb/25045
 154         * hppa-linux-nat.c: Include gdbarch.h.
 155
 156 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 157
 158         * blockframe.c (find_pc_partial_function): Change return type to bool.
 159         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 160         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 161         (stub_gnu_ifunc_resolve_name): Likewise.
 162         * symtab.c (compare_filenames_for_search): Likewise.
 163         (compare_glob_filenames_for_search): Likewise.
 164         (matching_obj_sections): Likewise.
 165         (symbol_matches_domain): Likewise.
 166         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 167         (find_line_pc): Change return type to bool.
 168         (find_line_pc_range): Likewise.
 169         (producer_is_realview): Likewise.
 170         * symtab.h (symbol_matches_domain): Likewise.
 171         (find_pc_partial_function): Likewise.
 172         (find_pc_line_pc_range): Likewise.
 173         (in_gnu_ifunc_stub): Likewise.
 174         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 175         (find_line_pc): Likewise.
 176         (find_line_pc_range): Likewise.
 177         (matching_obj_sections): Likewise.
 178         (find_line_symtab): Change out parameter to bool.
 179         (producer_is_realview): Change return type to bool.
 180         (compare_filenames_for_search): Likewise.
 181         (compare_glob_filenames_for_search): Likewise.
 182
 183 2019-09-26  Tom Tromey  <tom@tromey.com>
 184
 185         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 186         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 187         * gdb_usleep.h: Remove.
 188         * gdb_usleep.c: Remove.
 189         * utils.c: Don't include gdb_usleep.h.
 190
 191 2019-09-26  Tom Tromey  <tromey@adacore.com>
 192
 193         * python/py-type.c (type_to_type_object): Call check_typedef
 194         for stub types.
 195
 196 2019-09-26  Tom Tromey  <tom@tromey.com>
 197
 198         * utils.h (initialize_utils): Don't declare.
 199         * top.c (gdb_init): Don't call initialize_utils.
 200         * utils.c (initialize_utils): Remove.  Move contents...
 201         (_initialize_utils): ... here.
 202
 203 2019-09-25  Tom Tromey  <tom@tromey.com>
 204
 205         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 206         * utils.h (make_hex_string): Don't declare.
 207         * utils.c (make_hex_string): Remove.
 208
 209 2019-09-24  Tom de Vries  <tdevries@suse.de>
 210
 211         PR gdb/23815
 212         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 213         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 214
 215 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 216
 217         * NEWS: Mention new simulator port for PRU.
 218
 219 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 220
 221         * ada-exp.y (write_object_remaining): Update.
 222         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 223         and eliminate the static buffer.
 224         (ada_decode_symbol): Update.
 225         (ada_la_decode): Update.
 226         (ada_sniff_from_mangled_name): Update.
 227         (is_valid_name_for_wild_match): Update.
 228         (ada_lookup_name_info::matches): Update and simplify.
 229         (name_matches_regex): Update.
 230         (ada_add_global_exceptions): Update.
 231         * ada-lang.h (ada_decode): Update signature.
 232         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 233         * dwarf-index-write.c (debug_names::insert): Update.
 234
 235 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 236
 237         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 238         formatting.
 239
 240 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 241
 242         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 243         Change "nonzero" to "true" in documentation.
 244
 245 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 246
 247         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 248         (_initialize_darwin_solib): Don't set
 249         darwin_so_ops.lookup_lib_global_symbol.
 250         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 251         set_gdbarch_iterate_over_objfiles_in_search_order.
 252         (elf_lookup_lib_symbol): Rename to...
 253         (svr4_iterate_over_objfiles_in_search_order): this, and update
 254         to iterate semantics.
 255         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 256         * solib.c (solib_global_lookup): Remove.
 257         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 258         (solib_global_lookup): Remove.
 259         * symtab.c (lookup_global_or_static_symbol): Remove call to
 260         solib_global_lookup.
 261
 262 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 263
 264         * NEWS: Move entries about default MI version now being
 265         version 3, and about the GDB/MI fix for multi-location
 266         breakpoints to the "since GDB 8.3" section.
 267
 268 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 269
 270         GDB 8.3.1 released.
 271
 272 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 273
 274         * NEWS: Mention that Cell/B.E. debugging support was removed.
 275         * MAINTAINERS: Remove spu target.
 276
 277         * config/djgpp/fnchange.lst: Remove entries for removed files.
 278
 279         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 280         spu-multiarch.o, and spu-tdep.o.
 281         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 282         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 283         spu-multiarch.c, and spu-tdep.c.
 284         * spu-linux-nat.c: Remove file.
 285         * spu-multiarch.c: Remove file.
 286         * spu-tdep.c: Remove file.
 287         * spu-tdep.h: Remove file.
 288         * solib-spu.c: Remove file.
 289         * solib-spu.h: Remove file.
 290
 291         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 292         * configure.nat (spu-linux): Remove.
 293         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 294         solib-multiarch.o from gdb_target_obs.
 295         (spu*-*-*): Remove.
 296
 297         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 298         feature flag.
 299         (ppc_linux_no_features): Update.
 300         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 301         Cell/B.E. support.
 302         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 303         (tdesc_powerpc_cell64l): Likewise.
 304         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 305         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 306         Cell/B.E. support.
 307         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 308         Do not include "features/rs6000/powerpc-cell32l.c" or
 309         "features/rs6000/powerpc-cell64l.c".
 310         (ppc_linux_spu_section): Remove.
 311         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 312         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 313         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 314         (ppc_linux_spe_context_lookup): Remove.
 315         (ppc_linux_spe_context_inferior_created): Remove.
 316         (ppc_linux_spe_context_solib_loaded): Remove.
 317         (ppc_linux_spe_context_solib_unloaded): Remove.
 318         (ppc_linux_spe_context): Remove.
 319         (struct ppu2spu_cache): Remove.
 320         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 321         (struct ppu2spu_data): Remove.
 322         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 323         ppu2spu_unwind): Remove.
 324         (ppc_linux_init_abi): Remove Cell/B.E. support.
 325         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 326
 327         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 328         (rs6000/powerpc-cell64l-expedite): Likewise
 329         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 330         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 331         rs6000/powerpc-cell64l.xml.
 332         * features/rs6000/powerpc-cell32l.xml: Remove.
 333         * features/rs6000/powerpc-cell64l.xml: Likewise.
 334         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 335         * features/rs6000/powerpc-cell64l.c: Likewise.
 336         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 337         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 338         * regformats/reg-spu.dat: Remove.
 339
 340         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 341         * corelow.c (struct spuid_list): Remove.
 342         (add_to_spuid_list): Remove.
 343         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 344         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 345         (remote_protocol_features): Remove associated entries.
 346         (_initialize_remote): No longer initialize them.
 347         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 348         * linux-nat.c (SPUFS_MAGIC): Remove.
 349         (linux_proc_xfer_spu): Remove.
 350         (spu_enumerate_spu_ids): Remove.
 351         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 352         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 353         (linux_make_corefile_notes): No longer call it.
 354
 355         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 356         (cooked_write_test): Likewise.
 357
 358 2019-09-20  Tom Tromey  <tom@tromey.com>
 359
 360         * NEWS: Mention case-sensitivity of TUI commands.
 361         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 362         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 363         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 364
 365 2019-09-20  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-source.c (tui_source_window::set_contents): Use
 368         make_unique_xstrdup.
 369         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 370         make_unique_xstrdup.
 371
 372 2019-09-20  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-data.c: Remove separator comments.
 375         * tui/tui-layout.c: Remove separator comments.
 376         * tui/tui-win.c: Remove separator comments.
 377         * tui/tui-wingeneral.c: Remove separator comments.
 378
 379 2019-09-20  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui.h (strcat_to_buf): Don't declare.
 382         * tui/tui.c (strcat_to_buf): Remove.
 383
 384 2019-09-20  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 387         from "fullname".
 388         * tui/tui-source.c (tui_source_window::set_contents)
 389         (tui_source_window::location_matches_p)
 390         (tui_source_window::maybe_update): Update.
 391
 392 2019-09-20  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 395         Update.
 396         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 397         prefix.
 398         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 399         (tui_data_window::line_from_reg_element_no)
 400         (tui_data_window::first_reg_element_no_inline)
 401         (tui_data_window::show_registers)
 402         (tui_data_window::show_register_group)
 403         (tui_data_window::display_registers_from)
 404         (tui_data_window::display_registers_from_line)
 405         (tui_data_window::first_data_item_displayed)
 406         (tui_data_window::delete_data_content_windows)
 407         (tui_data_window::erase_data_content)
 408         (tui_data_window::do_scroll_vertical)
 409         (tui_data_window::refresh_window)
 410         (tui_data_window::check_register_values): Update.
 411
 412 2019-09-20  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 415         (struct tui_locator_window) <full_name, proc_name>: Now
 416         std::string.
 417         * tui/tui-stack.c (tui_locator_window::make_status_line)
 418         (tui_locator_window::set_locator_fullname)
 419         (tui_locator_window::set_locator_info): Update.
 420         * tui/tui-source.c (tui_source_window::set_contents)
 421         (tui_source_window::showing_source_p): Update.
 422
 423 2019-09-20  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 426         Don't call tui_locator_win_info_ptr.
 427
 428 2019-09-20  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 431
 432 2019-09-20  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 435         height for locator.
 436         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 437         * tui/tui-layout.c (show_source_disasm_command, show_data)
 438         (show_source_or_disasm_and_command): Use 1 as height for locator.
 439
 440 2019-09-20  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui.c (tui_enable): Update.
 443         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 444         Update.
 445         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 446         Update.
 447         * tui/tui-data.c (win_resized): Now bool.
 448         (tui_win_resized): Return bool.
 449         (tui_set_win_resized_to): Accept a bool.
 450
 451 2019-09-20  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 454         Change type of "refresh_values_only".
 455         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 456         type of "refresh_values_only".
 457
 458 2019-09-20  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 461         std::string.
 462         (tui_disassemble): Add "pos" parameter.
 463         (tui_disasm_window::set_contents): Simplify.
 464
 465 2019-09-20  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-winsource.h (struct tui_source_window_base)
 468         <show_source_content>: Now private.
 469         * tui/tui-winsource.c
 470         (tui_source_window_base::show_source_content): Don't handle empty
 471         content case.
 472
 473 2019-09-20  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-layout.c (show_source_disasm_command)
 476         (show_source_or_disasm_and_command): Don't call
 477         show_source_content.
 478
 479 2019-09-20  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 482         Declare.
 483         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 484         from tui_make_status_line.
 485         (tui_locator_window::rerender): Update.
 486
 487 2019-09-20  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 490         (tui_locator_window::rerender): Update.
 491
 492 2019-09-20  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-winsource.h (struct tui_source_window_base)
 495         <~tui_source_window_base>: Don't declare.
 496         <fullname>: Remove.
 497         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 498         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 499         member.
 500         * tui/tui-source.c (tui_source_window::set_contents): Update.
 501         (tui_source_window::location_matches_p)
 502         (tui_source_window::maybe_update): Update.
 503
 504 2019-09-20  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-winsource.h (~tui_source_element): Remove.
 507         (tui_source_element): Update.
 508         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 509         * tui/tui-winsource.c (tui_show_source_line): Update.
 510         * tui/tui-source.c (tui_source_window::set_contents): Update.
 511         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 512
 513 2019-09-20  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 516         declare.
 517         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 518         tui_clear_source_windows_detail.
 519         * tui/tui-winsource.h (struct tui_source_window_base)
 520         <clear_detail>: Don't declare.
 521         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 522         Remove.
 523         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 524
 525 2019-09-20  Tom Tromey  <tromey@adacore.com>
 526
 527         PR ada/24919:
 528         * block.c (contained_in): Fix final return value.
 529
 530 2019-09-20  Alan Modra  <amodra@gmail.com>
 531
 532         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 533         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 534         (read_indirect_string_from_dwz): Use bfd accessor.
 535         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 536         * machoread.c (macho_symfile_read_all_oso): Likewise.
 537         * solib.c (solib_bfd_open): Likewise.
 538
 539 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 540
 541         * eval.c: Move declaration of overload_resolution to...
 542         * value.h: ...here.
 543
 544 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 545
 546         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 547         * arm-linux-tdep.c: Likewise.
 548         * arm-nbsd-nat.c: Likewise.
 549         * arm-tdep.h: Declare arm_apcs_32.
 550         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 551
 552 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 553
 554         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 555         * dwarf2read.h: Declare dwarf_always_disassemble.
 556
 557 2019-09-19  Tom de Vries  <tdevries@suse.de>
 558
 559         PR gdb/25009
 560         * source-cache.c (source_cache::ensure): Catch exception thrown during
 561         construction of the highlighter.
 562
 563 2019-09-18  Alan Modra  <amodra@gmail.com>
 564
 565         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 566         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 567         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 568         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 569         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 570         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 571         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 572         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 573         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 574         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 575         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 576         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 577         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 578         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 579         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 580         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 581         * mi/mi-interp.c: Update throughout for bfd section macro and
 582         function changes.
 583         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 584         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 585
 586 2019-09-18  Tom Tromey  <tom@tromey.com>
 587
 588         * NEWS: Add entry.
 589         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 590         call rl_initialize.
 591         (tui_enable): Do not call rl_initialize.
 592
 593 2019-09-18  Christian Groessler  <chris@groessler.org>
 594
 595         * alpha-linux-nat.c: Include gdbarch.h.
 596
 597 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 598
 599         * ui-file.c: Include cli/cli-style.h.
 600         (term_cli_styling): Remove cli_styling declaration.
 601
 602 2019-09-18  Alan Modra  <amodra@gmail.com>
 603
 604         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 605         to bfd_asymbol_section.
 606
 607 2019-09-18  Alan Modra  <amodra@gmail.com>
 608
 609         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 610         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 611         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 612
 613 2019-09-18  Alan Modra  <amodra@gmail.com>
 614
 615         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 616         * spu-linux-nat.c (spu_bfd_open): Likewise.
 617
 618 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 619
 620         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 621         to bool to match definition in dwarf2read.c.
 622
 623 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 624
 625         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 626         (print_signatures): Likewise.
 627         (trust_pad_over_xvs): Likewise.
 628         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 629         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 630         * arm-linux-nat.c (arm_apcs_32): Likewise.
 631         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 632         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 633         * arm-tdep.c (arm_debug): Likewise.
 634         (arm_apcs_32): Likewise.
 635         * auto-load.c (debug_auto_load): Likewise.
 636         (auto_load_gdb_scripts): Likewise.
 637         (global_auto_load): Likewise.
 638         (auto_load_local_gdbinit): Likewise.
 639         (auto_load_local_gdbinit_loaded): Likewise.
 640         * auto-load.h (global_auto_load): Likewise.
 641         (auto_load_local_gdbinit): Likewise.
 642         (auto_load_local_gdbinit_loaded): Likewise.
 643         * breakpoint.c (disconnected_dprintf): Likewise.
 644         (breakpoint_proceeded): Likewise.
 645         (automatic_hardware_breakpoints): Likewise.
 646         (always_inserted_mode): Likewise.
 647         (target_exact_watchpoints): Likewise.
 648         (_initialize_breakpoint): Update.
 649         * breakpoint.h (target_exact_watchpoints): Change to bool.
 650         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 651         * cli/cli-cmds.c (trace_commands): Likewise.
 652         * cli/cli-cmds.h (trace_commands): Likewise.
 653         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 654         to bool*.
 655         * cli/cli-logging.c (logging_overwrite): Change to bool.
 656         (logging_redirect): Likewise.
 657         (debug_redirect): Likewise.
 658         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 659         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 660         to bool.
 661         <boolean_option_def>: Update.
 662         (struct flag_option_def): Change default type of Context to bool
 663         from int.
 664         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 665         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 666         (get_setshow_command_value_string): Likewise.
 667         * cli/cli-style.c (cli_styling): Change to bool.
 668         (source_styling): Likewise.
 669         * cli/cli-style.h (source_styling): Likewise.
 670         (cli_styling): Likewise.
 671         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 672         to bool.
 673         * command.h (var_types): Update comment.
 674         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 675         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 676         bool.
 677         (debug_compile_cplus_scopes): Likewise.
 678         * compile/compile-internal.h (compile_debug): Likewise.
 679         * compile/compile.c (compile_debug): Likewise.
 680         (struct compile_options) <raw>: Likewise.
 681         * cp-support.c (catch_demangler_crashes): Likewise.
 682         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 683         (usr_cmd_cris_dwarf2_cfi): Likewise.
 684         * csky-tdep.c (csky_debug): Likewise.
 685         * darwin-nat.c (enable_mach_exceptions): Likewise.
 686         * dcache.c (dcache_enabled_p): Likewise.
 687         * defs.h (info_verbose): Likewise.
 688         * demangle.c (demangle): Likewise.
 689         (asm_demangle): Likewise.
 690         * dwarf-index-cache.c (debug_index_cache): Likewise.
 691         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 692         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 693         * dwarf2read.c (check_physname): Likewise.
 694         (use_deprecated_index_sections): Likewise.
 695         (dwarf_always_disassemble): Likewise.
 696         * eval.c (overload_resolution): Likewise.
 697         * event-top.c (set_editing_cmd_var): Likewise.
 698         (exec_done_display_p): Likewise.
 699         * event-top.h (set_editing_cmd_var): Likewise.
 700         (exec_done_display_p): Likewise.
 701         * exec.c (write_files): Likewise.
 702         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 703         (debug_fbsd_nat): Likewise.
 704         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 705         Likewise.
 706         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 707         <backtrace_past_entry> Likewise.
 708         * gdb-demangle.h (demangle): Likewise.
 709         (asm_demangle): Likewise.
 710         * gdb_bfd.c (bfd_sharing): Likewise.
 711         * gdbcore.h (write_files): Likewise.
 712         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 713         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 714         * gdbthread.h (print_thread_events): Likewise.
 715         * gdbtypes.c (opaque_type_resolution): Likewise.
 716         (strict_type_checking): Likewise.
 717         * gnu-nat.c (gnu_debug_flag): Likewise.
 718         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 719         * guile/scm-param.c (pascm_variable): Add boolval.
 720         (add_setshow_generic): Update.
 721         (pascm_param_value): Update.
 722         (pascm_set_param_value_x): Update.
 723         * hppa-tdep.c (hppa_debug): Change to bool..
 724         * infcall.c (may_call_functions_p): Likewise.
 725         (coerce_float_to_double_p): Likewise.
 726         (unwind_on_signal_p): Likewise.
 727         (unwind_on_terminating_exception_p): Likewise.
 728         * infcmd.c (startup_with_shell): Likewise.
 729         * inferior.c (print_inferior_events): Likewise.
 730         * inferior.h (startup_with_shell): Likewise.
 731         (print_inferior_events): Likewise.
 732         * infrun.c (step_stop_if_no_debug): Likewise.
 733         (detach_fork): Likewise.
 734         (debug_displaced): Likewise.
 735         (disable_randomization): Likewise.
 736         (non_stop): Likewise.
 737         (non_stop_1): Likewise.
 738         (observer_mode): Likewise.
 739         (observer_mode_1): Likewise.
 740         (set_observer_mode): Update.
 741         (sched_multi): Change to bool.
 742         * infrun.h (debug_displaced): Likewise.
 743         (sched_multi): Likewise.
 744         (step_stop_if_no_debug): Likewise.
 745         (non_stop): Likewise.
 746         (disable_randomization): Likewise.
 747         * linux-tdep.c (use_coredump_filter): Likewise.
 748         (dump_excluded_mappings): Likewise.
 749         * linux-thread-db.c (auto_load_thread_db): Likewise.
 750         (check_thread_db_on_load): Likewise.
 751         * main.c (captured_main_1): Update.
 752         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 753         xx2_opt, boolean_opt>: Change to bool.
 754         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 755         * maint.c (maintenance_profile_p): Likewise.
 756         (per_command_time): Likewise.
 757         (per_command_space): Likewise.
 758         (per_command_symtab): Likewise.
 759         * memattr.c (inaccessible_by_default): Likewise.
 760         * mi/mi-main.c (mi_async): Likewise.
 761         (mi_async_1): Likewise.
 762         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 763         * nat/fork-inferior.h (startup_with_shell): Likewise.
 764         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 765         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 766         * nios2-tdep.c (nios2_debug): Likewise.
 767         * or1k-tdep.c (or1k_debug): Likewise.
 768         * parse.c (parser_debug): Likewise.
 769         * parser-defs.h (parser_debug): Likewise.
 770         * printcmd.c (print_symbol_filename): Likewise.
 771         * proc-api.c (procfs_trace): Likewise.
 772         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 773         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 774         (set_parameter_value): Update.
 775         (add_setshow_generic): Update.
 776         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 777         to bool*.
 778         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 779         int*.
 780         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 781         * record-btrace.c (record_btrace_target::store_registers): Update.
 782         * record-full.c (record_full_memory_query): Change to bool.
 783         (record_full_stop_at_limit): Likewise.
 784         * record-full.h (record_full_memory_query): Likewise.
 785         * remote-notif.c (notif_debug): Likewise.
 786         * remote-notif.h (notif_debug): Likewise.
 787         * remote.c (use_range_stepping): Likewise.
 788         (interrupt_on_connect): Likewise.
 789         (remote_break): Likewise.
 790         * ser-tcp.c (tcp_auto_retry): Likewise.
 791         * ser-unix.c (serial_hwflow): Likewise.
 792         * skip.c (debug_skip): Likewise.
 793         * solib-aix.c (solib_aix_debug): Likewise.
 794         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 795         (spu_auto_flush_cache_p): Likewise.
 796         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 797         Likewise.
 798         (struct info_print_options) <quiet>: Likewise.
 799         * symfile-debug.c (debug_symfile): Likewise.
 800         * symfile.c (auto_solib_add): Likewise.
 801         (separate_debug_file_debug): Likewise.
 802         * symfile.h (auto_solib_add): Likewise.
 803         (separate_debug_file_debug): Likewise.
 804         * symtab.c (basenames_may_differ): Likewise.
 805         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 806         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 807         (struct info_types_options) <quiet>: Likewise.
 808         * symtab.h (demangle): Likewise.
 809         (basenames_may_differ): Likewise.
 810         * target-dcache.c (stack_cache_enabled_1): Likewise.
 811         (code_cache_enabled_1): Likewise.
 812         * target.c (trust_readonly): Likewise.
 813         (may_write_registers): Likewise.
 814         (may_write_memory): Likewise.
 815         (may_insert_breakpoints): Likewise.
 816         (may_insert_tracepoints): Likewise.
 817         (may_insert_fast_tracepoints): Likewise.
 818         (may_stop): Likewise.
 819         (auto_connect_native_target): Likewise.
 820         (target_stop_and_wait): Update.
 821         (target_async_permitted): Change to bool.
 822         (target_async_permitted_1): Likewise.
 823         (may_write_registers_1): Likewise.
 824         (may_write_memory_1): Likewise.
 825         (may_insert_breakpoints_1): Likewise.
 826         (may_insert_tracepoints_1): Likewise.
 827         (may_insert_fast_tracepoints_1): Likewise.
 828         (may_stop_1): Likewise.
 829         * target.h (target_async_permitted): Likewise.
 830         (may_write_registers): Likewise.
 831         (may_write_memory): Likewise.
 832         (may_insert_breakpoints): Likewise.
 833         (may_insert_tracepoints): Likewise.
 834         (may_insert_fast_tracepoints): Likewise.
 835         (may_stop): Likewise.
 836         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 837         (make_thread_apply_all_options_def_group): Change argument from int*
 838         to bool*.
 839         (thread_apply_all_command): Update.
 840         (print_thread_events): Change to bool.
 841         * top.c (confirm): Likewise.
 842         (command_editing_p): Likewise.
 843         (history_expansion_p): Likewise.
 844         (write_history_p): Likewise.
 845         (info_verbose): Likewise.
 846         * top.h (confirm): Likewise.
 847         (history_expansion_p): Likewise.
 848         * tracepoint.c (disconnected_tracing): Likewise.
 849         (circular_trace_buffer): Likewise.
 850         * typeprint.c (print_methods): Likewise.
 851         (print_typedefs): Likewise.
 852         * utils.c (debug_timestamp): Likewise.
 853         (sevenbit_strings): Likewise.
 854         (pagination_enabled): Likewise.
 855         * utils.h (sevenbit_strings): Likewise.
 856         (pagination_enabled): Likewise.
 857         * valops.c (overload_resolution): Likewise.
 858         * valprint.h (struct value_print_options) <prettyformat_arrays,
 859         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 860         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 861         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 862         Likewise.
 863         * windows-nat.c (new_console): Likewise.
 864         (cygwin_exceptions): Likewise.
 865         (new_group): Likewise.
 866         (debug_exec): Likewise.
 867         (debug_events): Likewise.
 868         (debug_memory): Likewise.
 869         (debug_exceptions): Likewise.
 870         (useshell): Likewise.
 871         * windows-tdep.c (maint_display_all_tib): Likewise.
 872         * xml-support.c (debug_xml): Likewise.
 873
 874 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 875
 876         * source.c (prepare_path_for_appending): New function.
 877         (openp): Make use of new function.
 878         (find_and_open_source): Search for the compilation directory and
 879         source file as a relative path beneath the directory search path.
 880
 881 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 882
 883         * source-cache.c (source_cache::get_line_charpos): Catch
 884         exceptions and return false, this matches the behaviour documented
 885         in the header file.
 886
 887 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 888
 889         * ada-tasks.c (info_task): Remove quoting of the task's name.
 890
 891 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 892
 893         * symfile.c (auto_solib_add): Replace comment with a reference
 894         to the header file.
 895
 896 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 897
 898         * NEWS: Mention that gdb can now be compiled with Python 3
 899         on Windows.
 900
 901 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 902
 903         * maint.c (maint_print_section_data::maint_print_section_data):
 904         Force use of 'float log10 (float)' by casting the argument to
 905         float.
 906
 907 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * maint.c: Add 'cmath' include.
 910         (struct maint_print_section_data): New structure.
 911         (print_section_index): New function.
 912         (print_bfd_section_info): Add header comment, small whitespace
 913         cleanup, and update to call new print_section_index function.
 914         (print_objfile_section_info): Likewise.
 915         (maint_obj_section_from_bfd_section): New function.
 916         (print_bfd_section_info_maybe_relocated): New function.
 917         (maintenance_info_sections): Add header comment, always use
 918         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 919
 920 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 921
 922         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 923         inner scope, add check that the objfile has psymtabs before
 924         checking psymtabs_addrmap.
 925         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 926
 927 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 928
 929         * NEWS: Announce that Ada task names are now shown at more places,
 930         and between quotes (except in info task output).
 931         * gdb/ada-tasks.c (task_to_str): New function.
 932         (display_current_task_id): Call task_to_str.
 933         (task_command_1): Likewise.
 934         (print_ada_task_info): In non-mi mode, Properly align headers and data
 935         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 936
 937 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 938
 939         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 940         prstatus.pr_lwp.pr_info instead of making it up.
 941
 942 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 943
 944         * auto-load.c (auto_load_expand_dir_vars): Update.
 945         * defs.h (gdb_datadir): Change to std::string.
 946         (python_libdir): Likewise.
 947         (relocate_gdb_directory): Change return type to std::string.
 948         * guile/guile.c (gdbscm_data_directory): Update.
 949         (initialize_scheme_side): Update.
 950         * jit.c (jit_reader_dir): Change to std::string.
 951         (jit_reader_load_command): Update.
 952         * main.c (gdb_datadir): Change to std::string.
 953         (python_libdir): Likewise.
 954         (set_gdb_data_directory): Update.
 955         (relocate_path): Change to return std::string.
 956         (relocate_gdb_directory): Change to return std::string.
 957         (relocate_gdbinit_path_maybe_in_datadir): Update.
 958         (captured_main_1): Update.
 959         * python/python.c (do_start_initialization): Update.
 960         * top.c (show_gdb_datadir): Update.
 961         * xml-syscall.c (xml_init_syscalls_info): Update.
 962         (init_syscalls_info): Update.
 963
 964 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 965
 966         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 967         out of get_init_files.
 968         (get_init_files): Update.
 969
 970 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 971
 972         * main.c (get_init_files): Change to use std::string.
 973         (captured_main_1): Update.
 974         (print_gdb_help): Update.
 975
 976 2019-09-11  Ali Tamur  <tamur@google.com>
 977
 978         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 979         implementation.
 980
 981 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 982
 983         * dbxread.c (read_dbx_symtab): Update.
 984         * dwarf2read.c (load_partial_dies): Update.
 985         * mdebugread.c (parse_partial_symbols): Update.
 986         (handle_psymbol_enumerators): Update.
 987         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 988         * psymtab.c (add_psymbol_to_bcache): Likewise.
 989         (add_psymbol_to_list): Likewise.
 990         * symtab.c (symbol_set_names): Likewise.
 991         * symtab.h (symbol_set_names): Likewise.
 992         * xcoffread.c (scan_xcoff_symtab): Update.
 993
 994 2019-09-11  Tom Tromey  <tom@tromey.com>
 995
 996         * symfile-mem.c (symbol_file_add_from_memory): Use
 997         bfd_set_filename.
 998         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 999         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1000
1001 2019-09-10  Tom Tromey  <tromey@adacore.com>
1002
1003         * dwarf-index-write.c (write_psymbols): Extend error message.
1004         (debug_names::insert): Add Ada code.
1005         (debug_names::write_psymbols): Remove Ada check.
1006         (debug_names) <m_string_obstack>: New member.
1007         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1008         (gdb_index_symbol_name_matcher::matches): Remove.
1009         (mapped_index_base::find_name_components_bounds): Add "lang"
1010         parameter.
1011         (mapped_index_base::build_name_components): Also split names
1012         according to Ada syntax.
1013         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1014         type of "match_callback".
1015         (check_match, check_find_bounds_finds)
1016         (dw2_expand_symtabs_matching): Update.
1017         (dw2_debug_names_iterator): Add new constructor.
1018         (dw2_debug_names_map_matching_symbols): New function.
1019         (dw2_debug_names_expand_symtabs_matching): Update.
1020         (dwarf2_debug_names_functions): Use
1021         dw2_debug_names_map_matching_symbols.
1022
1023 2019-09-10  Tom Tromey  <tromey@adacore.com>
1024
1025         * dwarf2read.c (dw2_get_file_names_reader): Add the
1026         CU's file name to the results.
1027
1028 2019-09-10  Tom Tromey  <tromey@adacore.com>
1029
1030         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1031         map_matching_symbols.  Update.
1032         * dwarf2read.c (dw2_map_matching_symbols): Update.
1033         * psymtab.c (match_partial_symbol): Change type; update.
1034         (psym_map_matching_symbols): Likewise.
1035         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1036         type; update.
1037         * symfile.h (struct quick_symbol_functions)
1038         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1039         Remove "match".
1040
1041 2019-09-10  Tom Tromey  <tromey@adacore.com>
1042
1043         * psymtab.c (map_block): Remove.
1044         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1045         * symtab.c (iterate_over_symbols_terminated): New function.
1046         * symtab.c (iterate_over_symbols_terminated): Declare.
1047
1048 2019-09-10  Tom Tromey  <tromey@adacore.com>
1049
1050         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1051         * language.h (struct language_defn) <la_iterate_over_symbols>:
1052         Return bool.
1053         * symtab.c (iterate_over_symbols): Return bool.
1054         * symtab.h (iterate_over_symbols): Return bool.
1055
1056 2019-09-10  Tom Tromey  <tromey@adacore.com>
1057
1058         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1059         (add_nonlocal_symbols): Update.
1060         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1061         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1062         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1063         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1064         Change type of "callback".  Remove "data".
1065
1066
1067 2019-09-09  Ali Tamur  <tamur@google.com>
1068
1069         * dwarf2read.c (comp_unit_head): Update comment.
1070         (dwarf2_dwo_name): New function declaration.
1071         (dwarf_unit_type_name): New function declaration.
1072         (read_comp_unit_head): Add support for new compilation units,
1073         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1074         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1075         (currently named as "signature") in their header. Also clarify error
1076         messages.
1077         (lookup_dwo_id): New function. Returns the dwo id of the given
1078         compile unit.
1079         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1080         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1081         functions.
1082         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1083         (dwarf2_dwo_name): Get the dwo name if present.
1084         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1085         purposes.
1086
1087 2019-09-09  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1090
1091 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1092
1093         * python/python.c (do_start_initialization): Make progname_copy static,
1094         to avoid a leak report.
1095
1096 2019-09-08  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1099
1100 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1101
1102         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1103         Change type to gdb::optional<block_enum>.
1104         (dw2_symtab_iter_init): Change block_index parameter type
1105         to gdb::optional<block_enum>.
1106         (dw2_lookup_symbol): Change block_index parameter
1107         type to block_enum.c
1108         (dw2_debug_names_lookup_symbol): Likewise.
1109         * psymtab.c (psym_lookup_symbol): Likewise.
1110         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1111         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1112         Likewise.
1113
1114 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1115
1116         * defs.h (relocate_gdb_directory): Change int to bool in
1117         signature and rename flag to relocatable.
1118         * main.c (relocate_path): Likewise.
1119         (relocate_gdb_directory): Likewise.
1120
1121 2019-09-06  Alan Modra  <amodra@gmail.com>
1122
1123         * coffread.c (coff_symfile_read): Constify filename variable.
1124         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1125         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1126         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1127         * solib.c (reload_shared_libraries_1): Likewise.
1128         * symfile.c (reread_symbols): Likewise.
1129         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1130         * solib-darwin.c (darwin_bfd_open): Likewise.
1131         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1132
1133 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1136         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1137
1138 2019-09-03  Tom Tromey  <tromey@adacore.com>
1139
1140         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1141         types.
1142         (has_negatives): Unbias a range type bound.
1143         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1144         * gdbtypes.c (operator==): Handle new field.
1145         (create_range_type): Add "bias" parameter.
1146         (create_static_range_type, resolve_dynamic_range): Update.
1147         * gdbtypes.h (struct range_bounds) <bias>: New member.
1148         (create_range_type): Add bias parameter.
1149         * printcmd.c (print_scalar_formatted): Unbias range types.
1150         * value.c (unpack_long): Unbias range types.
1151         (pack_long): Bias range types.
1152
1153 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1154
1155         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1156         probe arguments.
1157
1158 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1159
1160         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1161         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1162         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1163         (compile_probe_arg): Likewise.
1164         * probe.h (get_argument_count): Likewise.
1165         * solib-svr4.c (solib_event_probe_action): Likewise.
1166         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1167
1168 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1169
1170         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1171         code to here...
1172         (svr4_create_solib_event_breakpoints): ...from here.
1173
1174 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1175
1176         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1177         suffix from warning message.
1178
1179 2019-08-30  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-winsource.h (struct tui_source_window_base)
1182         <refresh_all>: Don't declare.
1183         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1184         Remove.
1185         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1186         tui_show_locator_content.
1187         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1188         declare.
1189         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1190         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1191         declare.
1192
1193 2019-08-30  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1196
1197 2019-08-30  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1200         Remove unnecessary forward declarations.
1201
1202 2019-08-30  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1205         rerender.
1206         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1207         tui_show_locator_content.
1208
1209 2019-08-30  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1212         (tui_locator_window::rerender): Rewrite using body of previous
1213         tui_show_locator_content.
1214
1215 2019-08-30  Tom Tromey  <tom@tromey.com>
1216
1217         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1218         set_locator_fullname>: New methods.
1219         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1220         Rename from tui_set_locator_fullname.
1221         (tui_locator_window::set_locator_info): Rename from
1222         tui_set_locator_info.  Return bool.
1223         (tui_update_locator_fullname, tui_show_frame_info): Update.
1224
1225 2019-08-30  Tom Tromey  <tom@tromey.com>
1226
1227         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1228
1229 2019-08-30  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1232         call touchwin.
1233
1234 2019-08-30  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-wingeneral.c (box_win): Assume win_info and
1237         win_info->handle cannot be NULL.
1238
1239 2019-08-30  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1242         refresh_window>: Declare.
1243         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1244         resize.
1245         (tui_data_item_window::rerender): Rename from
1246         tui_display_register.
1247         (tui_data_item_window::refresh_window): New method.
1248         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1249         no-op.
1250
1251 2019-08-30  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1254         regs_column_count, current_group>: Move later.  Now private.
1255         <get_current_group>: New method.
1256         * tui/tui-regs.c (tui_reg_command): Update.
1257         * tui/tui-layout.c (tui_set_layout): Update.
1258
1259 2019-08-30  Tom Tromey  <tom@tromey.com>
1260
1261         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1262         (tui_data_window::rerender): Don't call
1263         check_and_display_highlight_if_needed.
1264         (tui_data_window::refresh_all): Remove call to
1265         erase_data_content.
1266
1267 2019-08-30  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1270         (tui_data_window::display_registers_from)
1271         (tui_data_window::display_reg_element_at_line)
1272         (tui_data_window::display_registers_from_line): Remove checks of
1273         "empty".
1274
1275 2019-08-30  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1278         Don't declare.
1279         * tui/tui-regs.c (tui_data_window::show_registers): Call
1280         rerender.
1281         (tui_data_window::rerender): Rename from display_all_data.
1282         (tui_data_window::rerender): Remove old implementation.
1283
1284 2019-08-30  Tom Tromey  <tom@tromey.com>
1285
1286         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1287         text.
1288         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1289
1290 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1291             Sergio Durigan Junior  <sergiodj@redhat.com>
1292
1293         PR win32/24284
1294         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1295
1296 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1297
1298         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1299         when searching for types.
1300
1301 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * f-lang.c (f_language_defn): Use f_print_typedef.
1304         * f-lang.h (f_print_typedef): Declare.
1305         * f-typeprint.c (f_print_typedef): Define.
1306
1307 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1308
1309         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1310
1311 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1312
1313         * cli/cli-utils.c (info_print_options_defs): Delete.
1314         (make_info_print_options_def_group): Delete.
1315         (extract_info_print_options): Delete.
1316         (info_print_command_completer): Delete.
1317         (info_print_args_help): Add extra parameter, and optionally
1318         include text about -n flag.
1319         * cli/cli-utils.h (struct info_print_options): Delete.
1320         (extract_info_print_options): Delete declaration.
1321         (info_print_command_completer): Delete declaration.
1322         (info_print_args_help): Add extra parameter, extend header
1323         comment.
1324         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1325         search_symbols.
1326         * stack.c (struct info_print_options): New type.
1327         (info_print_options_defs): New file scoped variable.
1328         (make_info_print_options_def_group): New static function.
1329         (info_print_command_completer): New static function.
1330         (info_locals_command): Update to use new local functions.
1331         (info_args_command): Likewise.
1332         (_initialize_stack): Add extra parameter to calls to
1333         info_print_args_help.
1334         * symtab.c (search_symbols): Add extra parameter, use this to
1335         possibly excluse non-debug symbols.
1336         (symtab_symbol_info): Add extra parameter, which is passed on to
1337         search_symbols.
1338         (struct info_print_options): New type.
1339         (info_print_options_defs): New file scoped variable.
1340         (make_info_print_options_def_group): New static function.
1341         (info_print_command_completer): New static function.
1342         (info_variables_command): Update to use local functions, and pass
1343         extra parameter through to symtab_symbol_info.
1344         (info_functions_command): Likewise.
1345         (info_types_command): Pass additional argument through to
1346         symtab_symbol_info.
1347         (rbreak_command): Pass extra argument to search_symbols.
1348         (_initialize_symtab): Add extra arguments for calls to
1349         info_print_args_help, and update help text for 'info variables',
1350         'whereis', and 'info functions' commands.
1351         * symtab.h (search_symbols): Add extra argument to declaration.
1352         * NEWS: Mention new flags.
1353
1354 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1355
1356         * symtab.c (lookup_static_symbol): Call the new function (and move
1357         it down to be next to lookup_global_symbol).
1358         (struct global_sym_lookup_data): Add block_enum member and rename to...
1359         (struct global_or_static_sym_lookup_data): ...this.
1360         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1361         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1362         (lookup_symbol_global_or_static_iterator_cb): ...this.
1363         (lookup_global_or_static_symbol): New function.
1364         (lookup_global_symbol): Call new function.
1365
1366 2019-08-26  Tom de Vries  <tdevries@suse.de>
1367
1368         PR c++/24852
1369         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1370         when pc_probe.prob == NULL.
1371
1372 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1373
1374         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1375         variable symbol_linkage to symbol_linkage_.
1376
1377 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1378
1379         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1380         represent whether the symbol is static, dynamic, or we don't
1381         know.
1382
1383 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1384
1385         * gdb/rx-tdep.c (rx_register_names): New.
1386         (rx_register_name): Delete.
1387         (rx_psw_type): Delete.
1388         (rx_fpsw_type): Delete.
1389         (rx_register_type): Delete.
1390         (rx_gdbarch_init): Convert target-descriptions.
1391         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1392         * gdb/features/Makefile: Add rx.xml.
1393         * gdb/features/rx.xml: New.
1394         * gdb/features/rx.c: Generated.
1395         * gdb/NEWS: Mention target description support.
1396
1397 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1398
1399         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1400         *slot_ptr.
1401
1402 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1403
1404         * configure.ac: Don't check for 'dlfcn.h' (moved to
1405         gdbsupport/common.m4).
1406         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1407         'gdbsupport/'.
1408         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1409         * compile/compile-c-support.c: Include
1410         'gdbsupport/gdb-dlfcn.h'.
1411         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1412         * gdb-dlfcn.c: Move to...
1413         * gdbsupport/gdb-dlfcn.c: ... here.
1414         * gdb-dlfcn.h: Move to...
1415         * gdbsupport/gdb-dlfcn.h: ... here.
1416
1417 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1418
1419         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1420         the offset field signed.
1421
1422 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1423
1424         * python/lib/gdb/__init__.py (_execute_file): New function.
1425         * python/python.c (python_run_simple_file): Call gdb._execute_file
1426         on Windows.
1427
1428 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1429
1430         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1431         all uses as this was never set to anything but a zero value.
1432
1433 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1434
1435         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1436
1437 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1438
1439         * tui/tui-data.h (tui_gen_win_info): Add an =default
1440         move constructor, required by some GCC versions.
1441
1442 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1443
1444         * go32-nat.c (go32_sysinfo): Add hygon_p.
1445
1446 2019-08-20  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1449         line_from_reg_element_no, first_reg_element_no_inline,
1450         display_all_data, delete_data_content_windows,
1451         erase_data_content>: Now private.
1452
1453 2019-08-20  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1456         (tui_unhighlight_win, tui_highlight_win)
1457         (tui_win_info::make_window): Update.
1458         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1459
1460 2019-08-20  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1463         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1464         (MAX_PID_WIDTH): Move to tui-stack.c.
1465         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1466         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1467         (MAX_PID_WIDTH): Move from tui-data.h.
1468
1469 2019-08-20  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1472         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1473         (box_win): Update.
1474         (tui_gen_win_info::make_window): Rename from tui_make_window.
1475         (tui_win_info::make_window): New method.
1476         (tui_gen_win_info::make_visible): Update.
1477         * tui/tui-source.c (tui_source_window::set_contents): Update.
1478         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1479         (tui_data_window::display_registers_from): Update.
1480         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1481         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1482         Declare.
1483         <can_box>: Remove.
1484         <title>: Remove.
1485         (struct tui_win_info) <make_window>: Declare.
1486         <can_box>: Now virtual.
1487         <title>: New member.
1488         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1489         * tui/tui-command.c (tui_cmd_window::resize): Update.
1490
1491 2019-08-20  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1494         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1495         (tui_data_window::check_register_values): Update.
1496
1497 2019-08-20  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-regs.h (struct tui_data_window): Use
1500         DISABLE_COPY_AND_ASSIGN.
1501         <regs_content>: Change type, removing unique_ptr.
1502         <tui_data_window>: Add move constructor.
1503         * tui/tui-regs.c (tui_data_window::show_registers)
1504         (tui_data_window::show_register_group)
1505         (tui_data_window::display_registers_from)
1506         (tui_data_window::display_registers_from)
1507         (tui_data_window::first_data_item_displayed)
1508         (tui_data_window::delete_data_content_windows)
1509         (tui_data_window::rerender, tui_data_window::refresh_window)
1510         (tui_data_window::check_register_values): Update.
1511
1512 2019-08-20  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1515         show_register_group>: Declare.
1516         (tui_show_register_group): Don't declare.
1517         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1518         tui_show_registers.
1519         (tui_data_window::show_register_group): Rename from
1520         tui_show_register_group.
1521         (tui_data_window::check_register_values, tui_reg_command):
1522         Update.
1523         * tui/tui-layout.c (tui_set_layout): Update.
1524
1525 2019-08-20  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1528         Declare.
1529         (tui_check_register_values): Don't declare.
1530         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1531         from tui_check_register_values.
1532         * tui/tui-hooks.c (tui_register_changed): Update.
1533
1534 2019-08-20  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-regs.c (tui_reg_layout): Move later.
1537         (tui_show_registers): Don't enable TUI mode or change layout.
1538
1539 2019-08-20  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-regs.h (struct tui_data_item_window)
1542         <~tui_data_item_window>: Remove.
1543         <content>: Now a unique_xmalloc_ptr.
1544         * tui/tui-regs.c (tui_register_format): Return a
1545         unique_xmalloc_ptr.
1546         (tui_get_register): Update.
1547         (~tui_data_item_window): Remove.
1548         (tui_data_window::display_registers_from, tui_display_register):
1549         Update.
1550         * tui/tui-io.h (tui_expand_tabs): Update.
1551         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1552         Remove "col" parameter.
1553
1554 2019-08-20  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1557         field.
1558         * tui/tui-regs.c (~tui_data_item_window): Update.
1559
1560 2019-08-20  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1563         earlier.
1564
1565 2019-08-20  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1568
1569 2019-08-20  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-source.h (struct tui_source_window): Update.
1572         * tui/tui-regs.c (tui_show_registers): Update.
1573         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1574         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1575         (NO_REGS_STRING): Remove defines.
1576
1577 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1578
1579         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1580         unnecessary thread walk if remote doesn't support the packet.
1581
1582 2019-08-19  Tom Tromey  <tromey@adacore.com>
1583
1584         * python/py-value.c (value_has_field): Fix indentation.
1585
1586 2019-08-19  Tom Tromey  <tromey@adacore.com>
1587
1588         * printcmd.c (do_one_display, info_display_command): Update.
1589         * block.h (contained_in): Return bool.  Add allow_nested
1590         parameter.
1591         * block.c (contained_in): Return bool.  Add allow_nested
1592         parameter.
1593
1594 2019-08-19  Tom Tromey  <tom@tromey.com>
1595
1596         * configure: Rebuild.
1597         * configure.ac: Disallow the combination of -static-libstdc++ and
1598         source highlight.
1599         * source-cache.c (get_language_name): Handle rust.
1600         (source_cache::get_source_lines): Ignore highlighting exceptions.
1601
1602 2019-08-16  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1605         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1606         (struct tui_source_window_base) <make_visible, refresh_window,
1607         resize>: Remove methods.
1608         <execution_info>: Remove field.
1609         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1610         (tui_show_source_line, tui_source_window_base)
1611         (~tui_source_window_base): Update.
1612         (tui_source_window_base::resize)
1613         (tui_source_window_base::make_visible)
1614         (tui_source_window_base::refresh_window): Remove.
1615         (tui_source_window_base::update_exec_info): Update.
1616         * tui/tui-source.c (tui_source_window::set_contents): Update.
1617         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1618
1619 2019-08-16  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1622         deprecated_query_hook.
1623
1624 2019-08-16  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1627         (tui_update_source_windows_with_line): Update.
1628         * tui/tui-source.h (struct tui_source_window)
1629         <show_symtab_source>: Declare.
1630         (tui_show_symtab_source): Don't declare.
1631         * tui/tui-source.c (tui_show_symtab_source): Rename from
1632         tui_show_symtab_source.
1633
1634 2019-08-16  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-winsource.h (struct tui_source_window_base)
1637         <set_contents>: Declare.
1638         * tui/tui-winsource.c
1639         (tui_source_window_base::update_source_window_as_is): Update.
1640         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1641         Declare.
1642         (tui_set_source_content): Don't declare.
1643         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1644         tui_set_source_content.
1645         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1646         Declare.
1647         (tui_set_disassem_content): Don't declare.
1648         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1649         tui_set_disassem_content.
1650
1651 2019-08-16  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-winsource.h (struct tui_source_window_base)
1654         <update_breakpoint_info>: Declare.
1655         (tui_update_breakpoint_info): Don't declare.
1656         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1657         (tui_update_all_breakpoint_info): Update.
1658         (tui_source_window_base::update_breakpoint_info): Rename from
1659         tui_update_breakpoint_info.
1660         (tui_source_window_base::update_exec_info): Update.
1661
1662 2019-08-16  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-winsource.h (struct tui_source_window_base)
1665         <update_source_window>: Declare.
1666         (tui_update_source_window): Don't declare.
1667         * tui/tui-winsource.c
1668         (tui_source_window_base::update_source_window): Rename from
1669         tui_update_source_window.
1670         (tui_source_window_base::rerender): Update.
1671         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1672         * tui/tui-disasm.c (tui_show_disassem)
1673         (tui_show_disassem_and_update_source)
1674         (tui_disasm_window::maybe_update): Update.
1675
1676 2019-08-16  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-winsource.h (struct tui_source_window_base)
1679         <update_source_window_as_is>: Declare.
1680         (tui_update_source_window_as_is): Don't declare.
1681         * tui/tui-winsource.c (tui_update_source_window): Update
1682         (tui_source_window_base::update_source_window_as_is): Rename from
1683         tui_update_source_window_as_is.
1684         (tui_source_window_base::refill): Update.
1685         * tui/tui-source.c (tui_show_symtab_source): Update.
1686         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1687         Update.
1688
1689 2019-08-16  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-winsource.h (tui_update_source_window)
1692         (tui_update_source_window_as_is): Remove "noerror" parameter.
1693         * tui/tui-winsource.c (tui_update_source_window)
1694         (tui_update_source_window_as_is): Remove "noerror" parameter.
1695         (tui_update_source_windows_with_addr)
1696         (tui_update_source_windows_with_line)
1697         (tui_source_window_base::rerender)
1698         (tui_source_window_base::refill): Update.
1699         * tui/tui-source.h (tui_set_source_content)
1700         (tui_show_symtab_source): Remove "noerror" parameter.
1701         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1702         parameter.
1703         (tui_show_symtab_source): Likewise.
1704         (tui_source_window::maybe_update): Update.
1705         * tui/tui-disasm.c (tui_show_disassem)
1706         (tui_show_disassem_and_update_source)
1707         (tui_disasm_window::do_scroll_vertical)
1708         (tui_disasm_window::maybe_update): Update.
1709
1710 2019-08-16  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui.c (tui_is_window_visible): Update.
1713         * tui/tui-wingeneral.c (tui_make_window)
1714         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1715         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1716         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1717         (tui_set_win_height_command, parse_scrolling_args): Update.
1718         * tui/tui-source.c (tui_source_window::style_changed): Update.
1719         * tui/tui-regs.c (tui_show_registers)
1720         (tui_data_window::first_data_item_displayed)
1721         (tui_data_window::delete_data_content_windows)
1722         (tui_check_register_values, tui_reg_command): Update.
1723         * tui/tui-disasm.c (tui_show_disassem): Update.
1724         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1725         method.
1726         <is_visible>: Remove field.
1727         * tui/tui-data.c (tui_next_win, tui_prev_win)
1728         (tui_delete_invisible_windows): Update.
1729
1730 2019-08-16  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-winsource.h (struct tui_source_window_base)
1733         <m_has_locator>: Remove.
1734         * tui/tui-layout.c (show_source_disasm_command, show_data)
1735         (show_source_or_disasm_and_command): Update.
1736
1737 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1738
1739         * NEWS (Other MI changes): New subsection.
1740         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1741         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1742         * arch-utils.c (default_get_pc_address_flags): New function.
1743         * arch-utils.h (default_get_pc_address_flags): New declaration.
1744         * gdbarch.sh: Add get_pc_address_flags.
1745         * gdbarch.c: Regenerate.
1746         * gdbarch.h: Likewise.
1747         * stack.c (print_pc): New function.
1748         (print_frame_info) (print_frame): Call print_pc.
1749
1750 2019-08-16  Tom de Vries  <tdevries@suse.de>
1751
1752         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1753         print_objfile_section_info.
1754
1755 2019-08-15  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1758         calling update_cmdwin_start_line.
1759         * tui/tui-winsource.h (struct tui_source_window_base)
1760         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1761         <rerender>: Declare.
1762         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1763         Call rerender.
1764         (tui_source_window_base::set_new_height): Remove.
1765         (tui_source_window_base::rerender): Rename from
1766         do_make_visible_with_new_height.
1767         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1768         resize method.
1769         (tui_win_info::make_invisible_and_set_new_height)
1770         (tui_win_info::make_visible_with_new_height): Remove.
1771         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1772         Declare.
1773         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1774         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1775         do_make_visible_with_new_height>: Don't declare.
1776         <rerender>: Declare.
1777         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1778         set_new_height.
1779         (tui_data_window::do_make_visible_with_new_height): Remove.
1780         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1781         call tui_show_locator_content.
1782         (tui_gen_win_info::resize): Call rerender.
1783         (show_source_or_disasm_and_command): Don't call
1784         tui_show_locator_content.
1785         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1786         method.
1787         (struct tui_win_info) <rerender>: Declare.
1788         <set_new_height, make_invisible_and_set_new_height,
1789         make_visible_with_new_height>: Don't declare.
1790         * tui/tui-data.c (tui_win_list::rerender): New method.
1791         * tui/tui-command.h (struct tui_cmd_window)
1792         <do_make_visible_with_new_height>: Don't declare.
1793         * tui/tui-command.c
1794         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1795
1796 2019-08-15  Tom Tromey  <tromey@adacore.com>
1797
1798         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1799         * ada-lang.c (ada_enum_name): Likewise.
1800
1801 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1802
1803         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1804         leading underscore.
1805         (GdbOutputErrorFile): Likewise.
1806         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1807         accordingly.
1808         (execute_unwinders): Rename to have a leading underscore.
1809         (auto_load_packages): Likewise.
1810         (global scope): Adjust call to auto_load_packages accordingly.
1811         (GdbSetPythonDirectory): Likewise.
1812         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1813         instead of execute_unwinders.
1814
1815 2019-08-15  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1818         (show_data): Don't change window visibility.
1819         (tui_gen_win_info::resize): Remove special case for command
1820         window.  Use wresize, when available.
1821         (show_source_or_disasm_and_command): Don't change window
1822         visibility.
1823         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1824         <make_visible>: New method.
1825         * tui/tui-command.c (tui_cmd_window::resize): New method.
1826
1827 2019-08-15  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1830         (struct tui_source_windows): New.
1831         * tui/tui-winsource.c (tui_display_main): Update.
1832         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1833         (new_height_ok, parse_scrolling_args): Update.
1834         * tui/tui-layout.c (show_layout, show_data): Update.
1835         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1836         (tui_add_to_source_windows): Don't declare.
1837         * tui/tui-data.c (source_windows, tui_source_windows)
1838         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1839
1840 2019-08-15  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1843         Rename from reset.
1844         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1845         * tui/tui-layout.c (show_source_disasm_command, show_data):
1846         Update.
1847         (tui_gen_win_info::resize): Rename.
1848         (show_source_or_disasm_and_command): Update.
1849         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1850         reset.
1851
1852 2019-08-15  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1855         * tui/tui-interp.c (tui_interp::init): Don't call
1856         tui_initialize_static_data.
1857         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1858
1859 2019-08-15  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1862         examine tui_win_list.
1863
1864 2019-08-15  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1867         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1868         tui_clear_source_content.
1869         (tui_clear_source_content): Remove.
1870         (tui_source_window_base::do_erase_source_content): Hoist call to
1871         content.clear().
1872         * tui/tui-stack.c (tui_show_frame_info): Don't call
1873         tui_clear_source_content.
1874
1875 2019-08-15  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-winsource.h (struct tui_source_window_base)
1878         <do_erase_source_content>: New method.
1879         <erase_source_content>: New method.
1880         (tui_erase_source_content): Don't declare.
1881         * tui/tui-winsource.c (tui_clear_source_content): Update.
1882         (tui_source_window_base::do_erase_source_content): Rename from
1883         tui_erase_source_content.
1884         (tui_source_window_base::show_source_content): Update.
1885         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1886         * tui/tui-source.h (struct tui_source_window)
1887         <erase_source_content>: New method.
1888         * tui/tui-disasm.h (struct tui_disasm_window)
1889         <erase_source_content>: New method.
1890
1891 2019-08-15  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1894         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1895         constructor.
1896         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1897         * tui/tui-source.c (tui_set_source_content): Update.
1898         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1899
1900 2019-08-15  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1903         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1904         tui-source.c.
1905         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1906         Declare.
1907         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1908         method.
1909         (tui_source_window::maybe_update): Update.
1910
1911 2019-08-15  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1914         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1915         tui-disasm.c.
1916         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1917         Declare.
1918         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1919         method.
1920         (tui_disasm_window::maybe_update): Update.
1921
1922 2019-08-15  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-winsource.h (struct tui_source_window_base)
1925         <maybe_update>: Declare.
1926         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1927         method.
1928         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1929         Declare.
1930         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1931         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1932         Declare.
1933         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1934
1935 2019-08-15  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1938
1939 2019-08-15  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-wingeneral.c: Include tui-stack.h.
1942         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1943         (struct tui_locator_window): Move from tui-data.h.
1944         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1945         (tui_initialize_static_data): Move from tui-data.c.
1946         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1947         (struct tui_locator_window): Move to tui-stack.c.
1948         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1949         (tui_initialize_static_data): Move to tui-stack.c.
1950
1951 2019-08-15  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-layout.c (show_source_disasm_command)
1954         (show_source_or_disasm_and_command): Use make_visible method, not
1955         tui_make_window.
1956         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1957         Remove.
1958
1959 2019-08-15  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-wingeneral.h (tui_make_window): Update.
1962         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1963         parameter.
1964         (tui_gen_win_info::make_visible): Update.
1965         * tui/tui-regs.c (tui_data_window::display_registers_from):
1966         Update.
1967         * tui/tui-layout.c (show_source_disasm_command)
1968         (show_source_or_disasm_and_command): Update.
1969         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1970         (enum tui_box): Remove.
1971         (struct tui_win_info) <can_box>: New method.
1972         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1973         method.
1974
1975 2019-08-15  Tom de Vries  <tdevries@suse.de>
1976
1977         * linux-nat-trad.c: Include gdbarch.h.
1978
1979 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1980
1981         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1982         register sizes.
1983
1984 2019-08-14  Tom Tromey  <tromey@adacore.com>
1985
1986         * darwin-nat.c: Include gdbarch.h.
1987         * darwin-nat-info.c: Include gdbarch.h.
1988
1989 2019-08-13  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1992         Remove.
1993         * tui/tui-data.c (tui_initialize_static_data): Update.
1994
1995 2019-08-13  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-winsource.h (struct tui_exec_info_window)
1998         <~tui_exec_info_window, maybe_allocate_content, get_content,
1999         m_content>: Remove.
2000         (struct tui_source_window_base) <set_exec_info_content,
2001         show_exec_info_content>: Don't declare.
2002         * tui/tui-winsource.c
2003         (tui_exec_info_window::maybe_allocate_content): Remove.
2004         (tui_source_window_base::update_exec_info): Rename from
2005         set_exec_info_content.
2006         (tui_source_window_base::show_exec_info_content)
2007         (tui_source_window_base::update_exec_info): Remove.
2008
2009 2019-08-13  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2012         declare.
2013         * tui/tui-winsource.c (tui_update_source_window_as_is)
2014         (tui_update_source_windows_with_addr, tui_erase_source_content):
2015         Update.
2016         (tui_clear_exec_info_content): Remove.
2017
2018 2019-08-13  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2021         declare.
2022         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2023         call tui_erase_exec_info_content.
2024         (tui_clear_exec_info_content): Rename from
2025         tui_erase_exec_info_content.
2026         (tui_clear_exec_info_content): Delete.
2027
2028 2019-08-13  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui-winsource.h (struct tui_source_window_base)
2031         <show_exec_info_content>: Declare.
2032         (tui_show_exec_info_content): Don't declare.
2033         * tui/tui-winsource.c
2034         (tui_source_window_base::show_exec_info_content): Rename from
2035         tui_show_exec_info_content.
2036         (tui_source_window_base::update_exec_info): Update.
2037
2038 2019-08-13  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2041         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2042         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2043         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2044         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2045         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2046         ... here.
2047
2048 2019-08-13  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-winsource.h (struct tui_source_window_base)
2051         <update_exec_info>: Declare.
2052         (tui_update_exec_info): Don't declare.
2053         * tui/tui-winsource.c (tui_update_source_window_as_is)
2054         (tui_source_window_base::refresh_all)
2055         (tui_update_all_breakpoint_info): Update.
2056         (tui_source_window_base::update_exec_info): Rename from
2057         tui_update_exec_info.
2058         * tui/tui-stack.c (tui_show_frame_info): Update.
2059
2060 2019-08-13  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-winsource.h (struct tui_source_window_base)
2063         <set_exec_info_content>: Declare.
2064         (tui_set_exec_info_content): Don't declare.
2065         * tui/tui-winsource.c
2066         (tui_source_window_base::set_exec_info_content): Rename from
2067         tui_set_exec_info_content.
2068         (tui_update_exec_info): Update.
2069
2070 2019-08-13  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-winsource.h (struct tui_source_window_base)
2073         <show_source_content>: Declare.
2074         (tui_show_source_content): Don't declare.
2075         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2076         (tui_source_window_base::show_source_content): Rename from
2077         tui_show_source_content.
2078         (tui_source_window_base::refresh_all): Update.
2079         * tui/tui-layout.c (show_source_disasm_command)
2080         (show_source_or_disasm_and_command): Update.
2081
2082 2019-08-13  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-winsource.c (tui_erase_source_content)
2085         (tui_show_source_content, tui_source_window_base::refresh_all):
2086         Update.
2087         * tui/tui-wingeneral.h
2088         (tui_check_and_display_highlight_if_needed): Don't declare.
2089         * tui/tui-wingeneral.c
2090         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2091         check_and_display_highlight_if_needed.
2092         * tui/tui-win.c (tui_rehighlight_all)
2093         (tui_win_info::make_visible_with_new_height): Update.
2094         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2095         (tui_data_window::erase_data_content)
2096         (tui_data_window::display_all_data): Update.
2097         * tui/tui-data.h (struct tui_win_info)
2098         <check_and_display_highlight_if_needed>: Declare.
2099
2100 2019-08-13  Tom Tromey  <tom@tromey.com>
2101
2102         * tui/tui-win.c (tui_resize_all): Call
2103         tui_delete_invisible_windows.
2104         * tui/tui-layout.c (show_layout): Call
2105         tui_delete_invisible_windows.
2106         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2107         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2108
2109 2019-08-13  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2112         tui_add_win_to_layout.
2113
2114 2019-08-13  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2117         * tui/tui-layout.c (tui_default_win_height): Now static.
2118
2119 2019-08-13  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2122         single switch.
2123         (show_source_disasm_command, show_source_or_disasm_and_command):
2124         Don't check current layout.
2125
2126 2019-08-13  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-wingeneral.c (make_all_visible): Remove.
2129         (tui_make_all_invisible): Simplify.
2130         * tui/tui-layout.c (tui_make_all_invisible): Move from
2131         tui-wingeneral.c; simplify.
2132         (show_layout): Hoist call to tui_make_all_invisible.
2133         (show_data): Don't call tui_make_all_invisible.
2134
2135 2019-08-13  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2138         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2139
2140 2019-08-13  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2143         tui-data.c.
2144         (show_source_disasm_command, show_data)
2145         (show_source_or_disasm_and_command): Don't use
2146         tui_set_current_layout_to.
2147         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2148         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2149         tui-layout.c.
2150         (tui_set_current_layout_to): Remove.
2151
2152 2019-08-13  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-layout.c (tui_set_layout): Update.
2155         * tui/tui-data.h (struct tui_layout_def): Remove.
2156         (tui_layout_def): Don't declare.
2157         * tui/tui-data.c (layout_def): Remove.
2158         (tui_layout_def): Remove.
2159
2160 2019-08-13  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-winsource.h (struct tui_source_window_base)
2163         <clear_detail>: No longer "override".
2164         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2165         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2166         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2167         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2168         Remove.
2169         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2170
2171 2019-08-13  Tom Tromey  <tromey@adacore.com>
2172
2173         * tracepoint.c: Don't include readline.h or history.h.
2174
2175 2019-08-12  Tom Tromey  <tom@tromey.com>
2176
2177         * configure: Rebuild.
2178         * configure.ac: Check for readline 7.
2179         * NEWS: Mention readline 7 requirement.
2180         * README: Update.
2181
2182 2019-08-12  Tom Tromey  <tom@tromey.com>
2183
2184         * mingw-hdep.c (gdb_select): Remove readline hack.
2185
2186 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2187
2188         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2189         when the function fails.
2190
2191 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2192
2193         * s390-tdep.c (s390_type_align): New function.
2194         (s390_gdbarch_init): Set it as type_align gdbarch method.
2195
2196 2019-08-09  Tom de Vries  <tdevries@suse.de>
2197
2198         PR gdb/24591
2199         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2200         pc_low with relocation offset.
2201
2202 2019-08-07  Tom Tromey  <tromey@adacore.com>
2203
2204         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2205         (print_frame_args): Update.
2206         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2207         Update.
2208         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2209         * frame.h (struct frame_arg): Add initializers.
2210         <error>: Now a unique_xmalloc_ptr.
2211
2212 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2213
2214         * NEWS: Expand the Pointer Authentication entry.
2215         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2216         (aarch64_frame_unmask_lr): ... to this.
2217         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2218         Call aarch64_frame_unmask_lr.
2219         * frame.c (struct frame_info): Add "masked" variable.
2220         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2221         (fprint_frame): Check for masked pc.
2222         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2223         declarations.
2224         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2225         * stack.c (print_frame): Check for masked pc.
2226
2227 2019-08-06  Tom Tromey  <tom@tromey.com>
2228
2229         * stabsread.c (patch_block_stabs, read_one_struct_field)
2230         (read_enum_type): Use obstack_strndup.
2231         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2232         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2233         * dwarf2read.c (guess_full_die_structure_name)
2234         (anonymous_struct_prefix): Use obstack_strndup.
2235         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2236         * c-exp.y (yylex): Use obstack_strndup.
2237         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2238         (write_var_or_type): Use obstack_strndup.
2239
2240 2019-08-06  Tom Tromey  <tom@tromey.com>
2241
2242         * symfile.c (reread_symbols): Use obstack_strdup.
2243         * stabsread.c (read_type): Use obstack_strdup.
2244         * gdb_obstack.h (obstack_strdup): New overload.
2245         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2246         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2247         (dwarf2_canonicalize_name): Use obstack_strdup.
2248         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2249         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2250         Use obstack_strdup.
2251
2252 2019-08-06  Tom Tromey  <tom@tromey.com>
2253
2254         * gdb_obstack.h (obstack_strdup): Define.
2255         * gdb_obstack.c (obstack_strdup): Don't define.
2256
2257 2019-08-06  Tom Tromey  <tom@tromey.com>
2258
2259         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2260         obstack_strdup.
2261         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2262         obstack_strdup.
2263         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2264         * stabsread.c (common_block_start): Use obstack_strdup.
2265         * objfiles.c (set_objfile_main_name, objfile): Use
2266         obstack_strdup.
2267         * namespace.c (add_using_directive): Use obstack_strdup.
2268         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2269         * jit.c (finalize_symtab): Use obstack_strdup.
2270         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2271         (guess_partial_die_structure_name, partial_die_info::fixup)
2272         (dwarf2_name): Use obstack_strdup.
2273         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2274         obstack_strdup.
2275         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2276         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2277         obstack_strdup.
2278         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2279
2280 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2281
2282         * unittests/help-doc-selftests.c: New file.
2283         * Makefile.in: Add the new file.
2284
2285 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2286
2287         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2288         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2289         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2290         the trailing '.' is not output, and the first character is uppercased.
2291         (print_help_for_command): Update call to print_doc_line.
2292         (print_doc_of_command): Likewise.
2293         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2294         * cli/cli-option.c (append_indented_doc): Do not append newline.
2295         (build_help_option): Append newline after first appended_indented_doc
2296         only if a second call is done.
2297         (build_help): Append 2 new lines before each option, except the first
2298         one.
2299         * compile/compile.c (_initialize_compile): Add new lines after
2300         %OPTIONS%, when not at the end of the help.
2301         Change help doc or code
2302         producing the help doc to respect the invariants.
2303         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2304         Also removed the new line after 'Options:', as all other commands
2305         do not put an empty line between 'Options:' and the first option.
2306         * printcmd.c (_initialize_printcmd): Likewise.
2307         * stack.c (_initialize_stack): Likewise.
2308         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2309         incorrectly telling COMMAND is optional.
2310         * ada-lang.c (_initialize_ada_language): Change help doc or code
2311         producing the help doc to respect the invariants.
2312         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2313         * breakpoint.c (_initialize_breakpoint): Likewise.
2314         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2315         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2316         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2317         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2318         _initialize_cli_style): Likewise.
2319         * corelow.c (core_target_info): Likewise.
2320         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2321         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2322         * filesystem.c (_initialize_filesystem): Likewise.
2323         * frame.c (_initialize_frame): Likewise.
2324         * gnu-nat.c (add_task_commands): Likewise.
2325         * infcall.c (_initialize_infcall): Likewise.
2326         * infcmd.c (_initialize_infcmd): Likewise.
2327         * interps.c (_initialize_interpreter): Likewise.
2328         * language.c (_initialize_language): Likewise.
2329         * linux-fork.c (_initialize_linux_fork): Likewise.
2330         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2331         * maint.c (_initialize_maint_cmds): Likewise.
2332         * memattr.c (_initialize_mem): Likewise.
2333         * printcmd.c (_initialize_printcmd): Likewise.
2334         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2335         _RegEx): Likewise.
2336         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2337         * record-btrace.c (_initialize_record_btrace): Likewise.
2338         * record-full.c (_initialize_record_full): Likewise.
2339         * record.c (_initialize_record): Likewise.
2340         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2341         * regcache.c (_initialize_regcache): Likewise.
2342         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2343         _initialize_remote): Likewise.
2344         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2345         * serial.c (_initialize_serial): Likewise.
2346         * skip.c (_initialize_step_skip): Likewise.
2347         * source.c (_initialize_source): Likewise.
2348         * stack.c (_initialize_stack): Likewise.
2349         * symfile.c (_initialize_symfile): Likewise.
2350         * symtab.c (_initialize_symtab): Likewise.
2351         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2352         * top.c (init_main): Likewise.
2353         * tracefile-tfile.c (tfile_target_info): Likewise.
2354         * tracepoint.c (_initialize_tracepoint): Likewise.
2355         * tui/tui-win.c (_initialize_tui_win): Likewise.
2356         * utils.c (add_internal_problem_command): Likewise.
2357         * valprint.c (value_print_option_defs): Likewise.
2358
2359 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2360
2361         PR build/24886
2362         * configure.ac: Drop enable-libmcheck support.
2363         * configure, config.in: Rebuild.
2364         * libmcheck.m4: Remove.
2365         * acinclude.m4: Don't include it.
2366         * Makefile.in: Don't distribute it.
2367         * top.c (print_gdb_configuration): Don't mention it.
2368
2369 2019-08-06  Tom Tromey  <tom@tromey.com>
2370
2371         * utils.c (set_output_style): Sometimes pass stream to
2372         emit_style_escape.
2373         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2374         * record-btrace.c (btrace_insn_history): Update.
2375         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2376         method.
2377         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2378         Update initializers.
2379         <m_uiout>: New field.
2380         <m_di>: Move lower.
2381         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2382         Remove "uiout" parameter.
2383         (dump_insns): Update.
2384         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2385         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2386
2387 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2388
2389         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2390         (error_in_psymtab_expansion): Likewise.
2391         (lookup_symbol_via_quick_fns): Likewise.
2392         (basic_lookup_transparent_type_quick): Likewise.
2393         (basic_lookup_transparent_type_1): Likewise.
2394
2395 2019-08-06  Tom Tromey  <tromey@adacore.com>
2396
2397         * source.c (last_source_error): Now bool.
2398         (print_source_lines_base): Make "noprint" bool.  Only open
2399         source file when last_source_visited changes.
2400
2401 2019-08-06  Tom Tromey  <tromey@adacore.com>
2402
2403         * annotate.c (annotate_source_line): Use g_source_cache.
2404         * source-cache.c (source_cache::get_plain_source_lines): Change
2405         parameters.  Populate m_offset_cache.
2406         (source_cache::ensure): New method.
2407         (source_cache::get_line_charpos): New method.
2408         (extract_lines): Move lower.  Change parameters.
2409         (source_cache::get_source_lines): Move lower.
2410         * source-cache.h (class source_cache): Update comment.
2411         <get_line_charpos>: New method.
2412         <get_source_lines>: Update comment.
2413         <clear>: Clear m_offset_cache.
2414         <get_plain_source_lines>: Change parameters.
2415         <ensure>: New method
2416         <m_offset_cache>: New member.
2417         * source.c (forget_cached_source_info_for_objfile): Update.
2418         (info_source_command): Use g_source_cache.
2419         (find_source_lines, open_source_file_with_line_charpos): Remove.
2420         (print_source_lines_base, search_command_helper): Use g_source_cache.
2421         * source.h (open_source_file_with_line_charpos): Don't declare.
2422         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2423         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2424         Use g_source_cache.
2425
2426 2019-08-06  Tom Tromey  <tromey@adacore.com>
2427
2428         * source-cache.c (source_cache::get_plain_source_lines):
2429         Remove "first_line" and "last_line" parameters.
2430         (source_cache::get_source_lines): Cache plain text.
2431         * source-cache.h (class source_cache)
2432         <get_plain_source_lines>: Update.
2433
2434 2019-08-06  Tom Tromey  <tromey@adacore.com>
2435
2436         * source-cache.c (extract_lines): No longer a method.
2437         Changed type of parameter.  Include final newline.
2438         (selftests::extract_lines_test): New function.
2439         (_initialize_source_cache): Likewise.
2440         * source-cache.h (class source_cache)
2441         <extract_lines>: Don't declare.
2442
2443 2019-08-06  Tom Tromey  <tromey@adacore.com>
2444
2445         * breakpoint.c (init_breakpoint_sal): Update.
2446         (breakpoint): Update.
2447         * breakpoint.h (struct breakpoint) <filter>: Now a
2448         unique_xmalloc_ptr.
2449
2450 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2451
2452         * NEWS: Mention dictionary access on blocks.
2453         * python/py-block.c (blpy_getitem): New function.
2454         (block_object_as_mapping): New struct.
2455         (block_object_type): Use new struct for tp_as_mapping field.
2456
2457 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2458
2459         * objfiles.h (objfile): Add a comment describing partial symbols.
2460
2461 2019-08-05  Tom Tromey  <tromey@adacore.com>
2462
2463         * compile/compile.c (_initialize_compile): Use _(), not N_().
2464         * thread.c (_initialize_thread): Use _(), not N_().
2465         * stack.c (_initialize_stack): Use _(), not N_().
2466         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2467
2468 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2469
2470         * dwarf2read.c (struct dw2_symtab_iterator):
2471         <want_specific_block>: Remove.
2472         <block_index>: Change type to gdb::optional.
2473         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2474         change type of BLOCK_INDEX parameter to gdb::optional.
2475         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2476         (dw2_lookup_symbol): Don't pass argument for
2477         WANT_SPECIFIC_BLOCK.
2478         (dw2_expand_symtabs_for_function): Don't pass argument for
2479         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2480         (class dw2_debug_names_iterator)
2481         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2482         parameter, change BLOCK_INDEX type to gdb::optional.
2483         <m_want_specific_block>: Remove.
2484         <m_block_index>: Change type to gdb::optional.
2485         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2486         gdb::optional.  Re-write in function of gdb::optional.
2487         (dw2_debug_names_lookup_symbol): Don't pass argument for
2488         WANT_SPECIFIC_BLOCK.
2489         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2490         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2491         BLOCK_INDEX.
2492
2493 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2494
2495         * NEWS: Mention changes to "info sources" command.
2496
2497 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2498
2499         * symtab.c (filename_partial_match_opts): New struct type.
2500         (struct output_source_filename_data): New members
2501         regexp, c_regexp, partial_match.
2502         (output_source_filename): Use new members to decide to print file.
2503         (info_sources_option_defs): New variable.
2504         (make_info_sources_options_def_group, print_info_sources_header,
2505         info_sources_command_completer):
2506         New functions.
2507         (info_sources_command): Read new optional arguments.
2508         (_initialize_symtab): Update info sources help.
2509
2510 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2511
2512         * ada-lang.c (exception_support_info_v0): Renamed from...
2513         (default_exception_support_info): ... this.  Create new
2514         definition for v1.
2515         (ada_has_this_exception_support): Look up catch_handlers_sym.
2516         (ada_exception_support_info_sniffer): Try v0 after default.
2517
2518 2019-08-01  Tom Tromey  <tromey@adacore.com>
2519
2520         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2521         gdbarch.h.
2522
2523 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2524
2525         * s12z-tdep.c: Fix include path for s12z-opc.h.
2526
2527 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2528
2529         * NEWS: Require GNU make 3.82.
2530
2531 2019-07-16  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2534         declare.
2535
2536 2019-07-30  Tom Tromey  <tromey@adacore.com>
2537
2538         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2539
2540 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2541
2542         * printcmd.c (print_address_symbolic): Print negative offsets.
2543         (build_address_symbolic): Force signed arithmetic when computing
2544         offset.
2545
2546 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2547
2548         PR/24474: Add a function to lookup static variables.
2549         * NEWS: Mention this new function.
2550         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2551         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2552         * python/python.c (python_GdbMethods): Add new function.
2553
2554 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2555
2556         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2557         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2558         (objfpy_lookup_static_symbol): New function.
2559         (objfile_object_methods): Add new functions.
2560
2561 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2562
2563         * NEWS: Mention 'set|show print frame-info'.  Mention new
2564         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2565         backtrace argument.  Mention that python frame filtering code
2566         is now consistent with what 'backtrace' command prints.
2567
2568 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2569
2570         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2571         comments.
2572         (print_frame_info_auto, print_frame_info_source_line,
2573         print_frame_info_location, print_frame_info_source_and_location,
2574         print_frame_info_location_and_address, print_frame_info_short_location):
2575         New declarations.
2576         (struct frame_print_options): New member print_frame_info.
2577         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2578         * stack.h (get_user_print_what_frame_info): New declaration.
2579         (frame_show_address): New declaration.
2580         * stack.c (print_frame_arguments_choices): New value 'presence'.
2581         (print_frame_info_auto, print_frame_info_source_line,
2582         print_frame_info_location, print_frame_info_source_and_location,
2583         print_frame_info_location_and_address, print_frame_info_short_location,
2584         print_frame_info_choices, print_frame_info_print_what): New definitions.
2585         (print_frame_args): Only print dots for args if print frame-arguments
2586         is 'presence'.
2587         (frame_print_option_defs): New element for "frame-info".
2588         (get_user_print_what_frame_info): New function.
2589         (frame_show_address): Make non static.  Move comment to stack.h.
2590         (print_frame_info_to_print_what): New function.
2591         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2592         to decide what to print.
2593         (backtrace_command_1): Handle the new print_frame_arguments_presence
2594         value.
2595         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2596         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2597         (py_print_frame): In non-mi mode, use LOCATION as default for
2598         print_what, similarly to frame information printed directly by
2599         backtrace command. Handle frame-info user option in non MI mode.
2600
2601 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2602
2603         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2604         Add case for debugging 32-bit target on 64-bit host.  Revise
2605         comment.
2606
2607 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2608
2609         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2610         instead of find_function_entry_range_from_pc.
2611
2612 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2613
2614         * stack.c (find_frame_funname): Remove code which preferred
2615         minsym over symtab sym in "certain pathological cases".
2616
2617         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2618         parameter.  Change type of "do_demangle" to bool.
2619         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2620         Pass suitable "prefer_sym_over_minsym" flag to
2621         build_address_symbolic().  Don't output "+" for negative offsets.
2622         * printcmd.c (print_address_symbolic): Update invocation of
2623         build_address_symbolic to include a "prefer_sym_over_minsym"
2624         flag.
2625         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2626         Restrict cases in which use of minimal symbol is preferred to that
2627         of a found symbol.  Update comments.
2628
2629         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2630         for entry pc when entry pc is out of range for that FDE.
2631
2632 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2633
2634         PR gdb/24839:
2635         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2636         type.
2637
2638 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2639
2640         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2641         this function's Python signature.
2642
2643
2644 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2645
2646         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2647         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2648         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2649         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2650         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2651
2652
2653 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2654
2655         * h8300-tdep.c (h8300_register_name_common): New.
2656         h8300_register_name): Use h8300_register_name_common.
2657         (h8300s_register_name): Likewise.
2658         (h8300sx_register_name): Likewise.
2659         (h8300h_register_nam): New.
2660         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2661
2662
2663 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2664
2665         * arm-tdep.c (arm_skip_cmse_entry): New function.
2666         (arm_is_sgstubs_section): New function.
2667         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2668
2669 2019-07-22  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2672         Don't self-assign.
2673
2674 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2677         type_print.
2678
2679 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2680
2681         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2682         so that GDB doesn't match any msymbols when searching in the
2683         TYPES_DOMAIN.
2684         (print_symbol_info): Print using typedef_print or type_print based
2685         on the type of the symbol.  Add updated FIXME comment moved from...
2686         (_initialize_symtab): ... move and update FIXME comment to above.
2687
2688 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2689
2690         * NEWS: Mention adding -q option to "info types".
2691         * symtab.c (struct info_types_options): New struct.
2692         (info_types_options_defs): New variable.
2693         (make_info_types_options_def_group): New function.
2694         (info_types_command): Use gdb::option framework to parse options.
2695         (info_types_command_completer): New function.
2696         (_initialize_symtab): Extend the help text on "info types" and
2697         register command completer.
2698
2699 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2700
2701         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2702         (lookup_symbol_in_objfile): Change int to block_enum and add a
2703         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2704
2705 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2706
2707         * MAINTAINERS (Write After Approval): Add self.
2708
2709 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2710
2711         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2712         instruction to the dummy code region.
2713
2714 2019-07-19  Tom Tromey  <tromey@adacore.com>
2715
2716         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2717         (ARGSUSED, PARAMS, __func__): Remove rules.
2718
2719 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2720
2721         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2722         * features/arm/arm-with-iwmmxt.c: Remove.
2723         * features/arm/arm-with-iwmmxt.xml: Remove.
2724         * features/arm/arm-with-m-fpa-layout.c: Remove.
2725         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2726         * features/arm/arm-with-m-vfp-d16.c: Remove.
2727         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2728         * features/arm/arm-with-m.c: Remove.
2729         * features/arm/arm-with-m.xml: Remove.
2730         * features/arm/arm-with-neon.c: Remove.
2731         * features/arm/arm-with-neon.xml: Remove.
2732         * features/arm/arm-with-vfpv2.c: Remove.
2733         * features/arm/arm-with-vfpv2.xml: Remove.
2734         * features/arm/arm-with-vfpv3.c: Remove.
2735         * features/arm/arm-with-vfpv3.xml: Remove.
2736
2737 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2738
2739         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2740
2741 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2742
2743         * arch/aarch32.c (aarch32_create_target_description): Create
2744         target descriptions using features.
2745         * arch/arm.c (arm_create_target_description)
2746         (arm_create_mprofile_target_description): Likewise.
2747         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2748
2749 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2750
2751         * Makefile.in: Add new files.
2752         * aarch32-tdep.c: New file.
2753         * aarch32-tdep.h: New file.
2754         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2755         Call aarch32_read_description.
2756         * arch/aarch32.c: New file.
2757         * arch/aarch32.h: New file.
2758         * arch/arm.c (arm_create_target_description)
2759         (arm_create_mprofile_target_description): New function.
2760         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2761         (arm_create_target_description)
2762         (arm_create_mprofile_target_description): New declaration.
2763         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2764         read_description functions.
2765         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2766         Likewise.
2767         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2768         * arm-tdep.c (tdesc_arm_list): New variable.
2769         (arm_register_g_packet_guesses): Call create description functions.
2770         (arm_read_description) (arm_read_mprofile_description): New
2771         function.
2772         * arm-tdep.h (arm_read_description)
2773         (arm_read_mprofile_description): Add declaration.
2774         * configure.tgt: Add new files.
2775
2776 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2777
2778         * top.c (new_ui_command): Open specified terminal just once.
2779
2780 2019-07-18  Tom Tromey  <tromey@adacore.com>
2781
2782         * symtab.c (main_name): Constify return type.
2783         * symfile.c (set_initial_language): Update.
2784         * symtab.h (main_name): Constify return type.
2785
2786 2019-07-17  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-winsource.c (tui_update_source_window)
2789         (tui_update_source_window_as_is)
2790         (tui_update_source_windows_with_line): Remove return.
2791         * tui/tui-disasm.c (tui_show_disassem)
2792         (tui_show_disassem_and_update_source): Remove return.
2793         * tui/tui.c (tui_reset): Remove return.
2794         * tui/tui-wingeneral.c
2795         (tui_check_and_display_highlight_if_needed): Remove return.
2796
2797 2019-07-17  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2800
2801 2019-07-17  Tom Tromey  <tom@tromey.com>
2802
2803         * tui/tui-winsource.h (struct tui_exec_info_window)
2804         (struct tui_source_window_base): Move from tui-data.h.
2805         * tui/tui-winsource.c: Move many method definitions from
2806         elsewhere.  Remove "structuring" comments.
2807         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2808         (tui_source_window_base::refresh_window): Move to
2809         tui-winsource.c.
2810         * tui/tui-win.c (tui_source_window_base::refresh_all)
2811         (tui_source_window_base::update_tab_width)
2812         (tui_source_window_base::set_new_height)
2813         (tui_source_window_base::do_make_visible_with_new_height): Move to
2814         tui-winsource.c.
2815         * tui/tui-source.h: Update.
2816         * tui/tui-source.c (tui_source_window_base::reset): Move to
2817         tui-winsource.c.
2818         * tui/tui-disasm.h: Update.
2819         * tui/tui-data.h (struct tui_exec_info_window): Move to
2820         tui-winsource.h.
2821         (struct tui_source_window_base): Likewise.
2822         * tui/tui-data.c (tui_source_window_base::clear_detail)
2823         (tui_source_window_base, ~tui_source_window_base): Move to
2824         tui-winsource.c.
2825
2826 2019-07-17  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-win.c (tui_resize_all)
2829         (tui_source_window_base::update_tab_width)
2830         (tui_adjust_win_heights): Update.
2831         (tui_win_info::make_invisible_and_set_new_height): Rename from
2832         make_invisible_and_set_new_height.
2833         * tui/tui-data.h (struct tui_win_info)
2834         <make_invisible_and_set_new_height>: New method.
2835
2836 2019-07-17  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui.c: Update.
2839         * tui/tui-source.h (struct tui_source_window): Move from
2840         tui-data.h.
2841         * tui/tui-layout.c: Update.
2842         * tui/tui-disasm.c: Update.
2843         * tui/tui-data.h (struct tui_source_window): Move to
2844         tui-source.h.
2845
2846 2019-07-17  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2849         tui-data.h.
2850         * tui/tui-data.h (struct tui_disasm_window): Move to
2851         tui-disasm.h.
2852
2853 2019-07-17  Tom Tromey  <tom@tromey.com>
2854
2855         * tui/tui-regs.h (struct tui_data_item_window): Move from
2856         tui-data.h.
2857         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2858         * tui/tui-data.h (struct tui_data_item_window): Move to
2859         tui-regs.h.
2860         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2861
2862 2019-07-17  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui.c: Update.
2865         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2866         (tui_cmd_window::max_height): Move to tui-command.c.
2867         * tui/tui-layout.c: Update.
2868         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2869         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2870         tui-command.c.
2871         * tui/tui-command.h (struct tui_cmd_window): Move from
2872         tui-data.h.
2873         * tui/tui-command.c: Remove "structuring" comments.
2874         (tui_cmd_window::clear_detail)
2875         (tui_cmd_window::do_make_visible_with_new_height)
2876         (tui_cmd_window::max_height): Move from elsewhere.
2877
2878 2019-07-17  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2881         Now static.
2882         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2883         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2884
2885 2019-07-17  Tom Tromey  <tom@tromey.com>
2886
2887         * tui/tui.c: Update.
2888         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2889         tui-regs.c.
2890         * tui/tui-windata.h: Remove file.
2891         * tui/tui-windata.c: Remove file.
2892         * tui/tui-win.c (tui_data_window::set_new_height)
2893         (tui_data_window::do_make_visible_with_new_height): Move to
2894         tui-regs.c.
2895         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2896         * tui/tui-regs.c: Remove "structuring" comments.
2897         (tui_data_window::first_data_item_displayed)
2898         (tui_data_window::delete_data_content_windows)
2899         (tui_data_window::erase_data_content)
2900         (tui_data_window::display_all_data)
2901         (tui_data_window::refresh_all)
2902         (tui_data_window::do_scroll_vertical)
2903         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2904         (tui_data_window::do_make_visible_with_new_height)
2905         (tui_data_window::refresh_window): Move from elsewhere.
2906         (_initialize_tui_regs): Move to end of file.
2907         * tui/tui-layout.c: Update.
2908         * tui/tui-hooks.c: Update.
2909         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2910         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2911         tui-regs.c.
2912         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2913
2914 2019-07-17  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2917         seen.
2918
2919 2019-07-17  Tom Tromey  <tom@tromey.com>
2920
2921         * tui/tui-win.c (tui_source_window_base::set_new_height)
2922         (tui_source_window_base::do_make_visible_with_new_height): Use
2923         m_has_locator field directly.
2924         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2925         method.
2926         (struct tui_source_window_base) <has_locator>: Likewise.
2927
2928 2019-07-17  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2931         Don't declare.
2932         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2933         Remove.
2934         * tui/tui-win.c (tui_source_window_base::set_new_height)
2935         (tui_source_window_base::set_new_height)
2936         (make_invisible_and_set_new_height)
2937         (tui_source_window_base::do_make_visible_with_new_height)
2938         (tui_source_window_base::do_make_visible_with_new_height):
2939         Update.
2940         * tui/tui-layout.c (show_source_disasm_command, show_data)
2941         (show_source_or_disasm_and_command): Update.
2942         * tui/tui-layout.c (show_layout): Update.
2943
2944 2019-07-17  Tom Tromey  <tom@tromey.com>
2945
2946         * tui/tui-layout.c (make_data_window): Remove.
2947         (show_data): Unify creation and re-initialization cases.
2948
2949 2019-07-17  Tom Tromey  <tom@tromey.com>
2950
2951         * tui/tui-layout.c (make_source_window, make_disasm_window):
2952         Remove.
2953         (show_data): Unify creation and re-initialization cases.
2954
2955 2019-07-17  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui-layout.c (make_command_window): Remove.
2958         (show_source_disasm_command, show_source_or_disasm_and_command):
2959         Unify creation and re-initialization cases.
2960
2961 2019-07-17  Tom Tromey  <tom@tromey.com>
2962
2963         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2964         creation and re-initialization cases.
2965
2966 2019-07-17  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-regs.c (tui_get_register): Return void.
2969
2970 2019-07-17  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2973         Simplify.
2974
2975 2019-07-17  Tom Tromey  <tom@tromey.com>
2976
2977         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2978         resetting.
2979
2980 2019-07-17  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2983         * tui/tui-regs.c (tui_reg_layout): New function.
2984         (tui_show_registers, tui_reg_command): Use it.
2985         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2986         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2987         parameters.
2988         (tui_layout_command): Remove.
2989
2990 2019-07-17  Tom Tromey  <tom@tromey.com>
2991
2992         * tui/tui-layout.h (tui/tui-layout): Return void.
2993         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2994
2995 2019-07-17  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-layout.c (show_source_disasm_command, show_data):
2998         Update.
2999         (reset_locator): Remove.
3000         (show_source_or_disasm_and_command): Update.
3001
3002 2019-07-17  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-source.c (tui_source_window_base::reset): Remove
3005         win_type parameter.
3006         * tui/tui-layout.c (make_command_window, make_source_window)
3007         (make_disasm_window, make_data_window)
3008         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3009         (reset_locator, show_source_or_disasm_and_command): Update.
3010         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3011         win_type parameter.
3012         (struct tui_source_window_base) <reset>: Likewise.
3013
3014 2019-07-17  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui-layout.c (show_source_disasm_command): Use
3017         reset_locator.
3018         (reset_locator): New function.
3019         (init_and_make_win): Remove.
3020         (show_source_or_disasm_and_command): Use reset_locator.
3021
3022 2019-07-17  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3025         condition.
3026         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3027         Remove condition.
3028         * tui/tui-source.c (tui_source_window_base::reset): New method.
3029         * tui/tui-layout.c (make_command_window): Don't call
3030         init_and_make_win.
3031         (make_source_window, make_disasm_window): Don't call
3032         make_source_or_disasm_window.
3033         (make_data_window): Don't call init_and_make_win.  Change calling
3034         convention.
3035         (show_source_disasm_command, show_data): Simplify.
3036         (make_source_or_disasm_window): Remove.
3037         (show_source_or_disasm_and_command): Simplify.
3038         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3039         (struct tui_source_window_base) <reset>: Likewise.
3040         <execution_info>: Remove initializer.
3041         * tui/tui-data.c (tui_source_window_base): Initialize
3042         execution_info.
3043
3044 2019-07-17  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3047         variable.
3048
3049 2019-07-17  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui.c (tui_rl_other_window): Update.
3052         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3053         superclass method first.  Always iterate over regs_content.
3054         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3055         method.
3056         * tui/tui-win.c (tui_set_focus_command): Update.
3057
3058 2019-07-17  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-win.c (tui_set_focus_command): Rename from
3061         tui_set_focus.  Call tui_enable.
3062         (tui_set_focus_command): Remove.
3063
3064 2019-07-17  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3067         refresh_window.
3068         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3069         touchwin.
3070         (tui_data_window::refresh_window): Call refresh_window on data
3071         items.  Always call superclass refresh_window.
3072         (tui_win_info::refresh): Remove.
3073         (tui_source_window_base::refresh_window): Update.
3074         (tui_refresh_all): Update.
3075         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3076         refresh_window.
3077         (show_source_or_disasm_and_command): Likewise.
3078         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3079         (struct tui_source_window_base) <refresh>: Likewise.
3080
3081 2019-07-17  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-winsource.c (tui_clear_source_content)
3084         (tui_show_source_content): Update.
3085         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3086         whether content is empty.
3087         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3088         Remove.
3089
3090 2019-07-17  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3093         window's contents.
3094         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3095         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3096
3097 2019-07-17  Tom Tromey  <tom@tromey.com>
3098
3099         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3100         (struct tui_data_item_window): Update.
3101
3102 2019-07-17  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3105         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3106         defines.
3107
3108 2019-07-17  Tom Tromey  <tom@tromey.com>
3109
3110         * tui/tui-winsource.h (tui_erase_source_content)
3111         (tui_clear_source_content): Remove "display_prompt" parameter.
3112         * tui/tui-winsource.c (tui_update_source_window_as_is)
3113         (tui_update_source_windows_with_addr): Update.
3114         (tui_clear_source_content): Remove "display_prompt" parameter.
3115         (tui_erase_source_content): Likewise.  Simplify.
3116         (tui_show_source_content): Update.
3117         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3118         * tui/tui-stack.c (tui_show_frame_info): Update.
3119         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3120         Remove defines.
3121
3122 2019-07-17  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3125         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3126         parameter.
3127         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3128         parameter.
3129
3130 2019-07-17  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-winsource.c (tui_clear_source_content)
3133         (tui_show_source_content, tui_show_exec_info_content)
3134         (tui_clear_exec_info_content): Update.
3135         * tui/tui-stack.c (tui_show_locator_content): Update.
3136         (tui_show_frame_info): Update.
3137         * tui/tui-source.h (tui_source_window): Don't declare.
3138         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3139         from tui_source_is_displayed.
3140         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3141         Remove field.
3142         (struct tui_source_window_base) <content_in_use>: New field.  Now
3143         bool.
3144         (struct tui_source_window) <showing_source_p>: New method.
3145         (TUI_SRC_WIN): Change cast.
3146         * tui/tui-data.c (tui_initialize_static_data): Update.
3147
3148 2019-07-17  Tom Tromey  <tom@tromey.com>
3149
3150         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3151         location_matches_p.
3152         * tui/tui-source.c (tui_source_window::location_matches_p): New
3153         method.
3154         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3155         method.
3156         * tui/tui-data.h (struct tui_source_window_base)
3157         <location_matches_p>: New method.
3158         (struct tui_source_window, struct tui_disasm_window)
3159         <location_matches_p>: Likewise.
3160
3161 2019-07-17  Tom Tromey  <tom@tromey.com>
3162
3163         * tui/tui-win.c (tui_set_win_height_command): Rename from
3164         tui_set_win_height.
3165         (tui_set_win_height_command): Remove.
3166
3167 2019-07-17  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-source.c (tui_source_window): New constructor.  Add
3170         observer.
3171         (~tui_source_window): New destructor.
3172         (tui_source_window::style_changed): New method.
3173         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3174         (tui_attach_detach_observers): Update.
3175         * tui/tui-data.h (struct tui_source_window): Make constructor not
3176         inline.  Add destructor.
3177         (struct tui_source_window) <style_changed>: New method.
3178         <m_observable>: New member.
3179
3180 2019-07-17  Tom Tromey  <tom@tromey.com>
3181
3182         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3183         * tui/tui-win.c (tui_resize_all): Fix typo.
3184
3185 2019-07-17  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3188         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3189         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3190         * tui/tui-win.c (window_name_completer): Use foreach.
3191         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3192         (update_tab_width): Likewise.
3193         * tui/tui-layout.c (show_layout): Update.
3194         * tui/tui-data.h (class tui_window_iterator): New.
3195         (struct all_tui_windows): New.
3196         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3197
3198 2019-07-17  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3201         parameter.  Don't reference globals.
3202         (tui_reg_command): Update.
3203
3204 2019-07-17  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-regs.c (tui_show_registers): Simplify.
3207
3208 2019-07-17  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-regs.c (tui_show_registers): Update.
3211         (tui_show_register_group): Add win_info parameter.
3212
3213 2019-07-17  Tom Tromey  <tom@tromey.com>
3214
3215         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3216         Rename from tui_display_reg_element_at_line.
3217         (tui_data_window::display_registers_from_line): Update.
3218         * tui/tui-data.h (struct tui_data_window)
3219         <display_reg_element_at_line>: New method.
3220
3221 2019-07-17  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-regs.h (tui_display_registers_from)
3224         (tui_display_registers_from_line): Don't declare.
3225         * tui/tui-windata.c (tui_data_window::display_all_data)
3226         (tui_data_window::refresh_all)
3227         (tui_data_window::do_scroll_vertical): Update.
3228         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3229         from tui_display_registers_from.
3230         (tui_display_reg_element_at_line): Update.
3231         (tui_data_window::display_registers_from_line): Rename from
3232         tui_display_registers_from_line.
3233         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3234         display_registers_from_line>: New methods.
3235
3236 2019-07-17  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3239         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3240         from tui_erase_data_content.
3241         (tui_data_window::display_all_data)
3242         (tui_data_window::refresh_all)
3243         (tui_data_window::do_scroll_vertical): Update.
3244         * tui/tui-regs.c (tui_show_registers): Update.
3245         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3246         New method.
3247
3248 2019-07-17  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3251         declare.
3252         * tui/tui-windata.c
3253         (tui_data_window::delete_data_content_windows): Rename from
3254         tui_delete_data_content_windows.
3255         (tui_data_window::display_all_data)
3256         (tui_data_window::do_scroll_vertical): Update.
3257         * tui/tui-data.h (struct tui_data_window)
3258         <delete_data_content_windows>: New method.
3259
3260 2019-07-17  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3263         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3264
3265 2019-07-17  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3268         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3269         from tui_display_all_data.
3270         * tui/tui-win.c
3271         (tui_data_window::do_make_visible_with_new_height): Update.
3272         * tui/tui-regs.c (tui_show_registers): Update.
3273         * tui/tui-layout.c (tui_set_layout): Update.
3274         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3275         method.
3276
3277 2019-07-17  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3280         * tui/tui-windata.c (tui_display_data_from): Remove.
3281         (tui_data_window::refresh_all): Update.
3282
3283 2019-07-17  Tom Tromey  <tom@tromey.com>
3284
3285         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3286         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3287         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3288         tui_display_registers_from_line.
3289         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3290         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3291         "force_display" parameter.
3292
3293 2019-07-17  Tom Tromey  <tom@tromey.com>
3294
3295         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3296         declare.
3297         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3298         Rename from tui_first_reg_element_no_inline.
3299         (tui_display_reg_element_at_line)
3300         (tui_display_registers_from_line): Update.
3301         * tui/tui-data.h (struct tui_data_window)
3302         <first_reg_element_no_inline>: New method.
3303
3304 2019-07-17  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-windata.c (tui_display_data_from)
3307         (tui_data_window::do_scroll_vertical): Update.
3308         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3309         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3310         Rename from tui_line_from_reg_element_no.
3311         (tui_display_registers_from_line): Update.
3312         * tui/tui-data.h (struct tui_data_window)
3313         <line_from_reg_element_no>: New method.
3314
3315 2019-07-17  Tom Tromey  <tom@tromey.com>
3316
3317         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3318         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3319         tui_last_regs_line_no.
3320         (tui_display_reg_element_at_line)
3321         (tui_display_registers_from_line): Update.
3322         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3323         method.
3324
3325 2019-07-17  Tom Tromey  <tom@tromey.com>
3326
3327         PR tui/24722:
3328         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3329         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3330         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3331         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3332         (tui_update_breakpoint_info): Likewise.
3333         * tui/tui-hooks.c (tui_event_create_breakpoint)
3334         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3335         Update.
3336
3337 2019-07-17  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3340
3341 2019-07-17  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-winsource.c (tui_update_source_window_as_is)
3344         (tui_update_source_windows_with_addr): Update.
3345         * tui/tui-source.h (tui_set_source_content)
3346         (tui_show_symtab_source): Add "win_info" parameter.
3347         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3348         parameter.
3349         (tui_show_symtab_source): Likewise.
3350
3351 2019-07-17  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-wingeneral.c
3354         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3355
3356 2019-07-17  Tom Tromey  <tom@tromey.com>
3357
3358         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3359         (struct tui_cmd_window) <can_scroll>: New method.
3360         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3361         method.
3362
3363 2019-07-17  Tom Tromey  <tromey@adacore.com>
3364
3365         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3366         do_field_signed>: Rename.  Change type of "value".
3367         * ui-out.c (ui_out::field_signed): Rename from field_int.
3368         Change type of "value".
3369         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3370         type of "value".
3371         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3372         do_field_int.  Change type of "value".
3373         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3374         do_field_int.  Change type of "value".
3375         * tracepoint.c (trace_status_mi, tfind_1)
3376         (print_one_static_tracepoint_marker): Update.
3377         * thread.c (print_thread_info_1, print_selected_thread_frame):
3378         Update.
3379         * stack.c (print_frame, print_frame_info): Update.
3380         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3381         Update.
3382         * source.c (print_source_lines_base): Update.
3383         * skip.c (info_skip_command): Update.
3384         * record-btrace.c (btrace_ui_out_decode_error)
3385         (btrace_call_history_src_line): Update.
3386         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3387         Update.
3388         * progspace.c (print_program_space): Update.
3389         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3390         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3391         do_field_int.  Change type of "value".
3392         * mi/mi-out.c (mi_ui_out::do_table_begin)
3393         (mi_ui_out::do_table_header): Update.
3394         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3395         type of "value".
3396         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3397         (mi_cmd_data_list_changed_registers, output_register)
3398         (mi_cmd_data_read_memory, mi_load_progress)
3399         (mi_cmd_trace_frame_collected): Update.
3400         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3401         Update.
3402         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3403         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3404         (mi_cmd_var_list_children, varobj_update_one): Update.
3405         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3406         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3407         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3408         * inferior.c (print_inferior): Update.
3409         * gdb_bfd.c (print_one_bfd): Update.
3410         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3411         Update.
3412         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3413         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3414         do_field_int.  Change type of "value".
3415         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3416         do_field_int.  Change type of "value".
3417         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3418         (print_one_breakpoint_location, print_it_catch_fork)
3419         (print_one_catch_fork, print_it_catch_vfork)
3420         (print_one_catch_vfork, print_it_catch_solib)
3421         (print_it_catch_exec, print_it_ranged_breakpoint)
3422         (print_mention_watchpoint, print_mention_masked_watchpoint)
3423         (bkpt_print_it, update_static_tracepoint): Update.
3424         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3425         * break-catch-syscall.c (print_it_catch_syscall): Update.
3426         * ada-tasks.c (print_ada_task_info): Update.
3427         * ada-lang.c (print_it_exception, print_mention_exception):
3428         Update.
3429
3430 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         PR breakpoints/24541
3433         * gdbarch.c: Regenerate.
3434         * gdbarch.h: Regenerate.
3435         * gdbarch.sh: Adjust return type and parameter types for
3436         'stap_adjust_register'.
3437         (i386_stap_adjust_register): Adjust signature and return new
3438         register name.
3439         * stap-probe.c (stap_parse_register_operand): Adjust use of
3440         'gdbarch_stap_adjust_register'.
3441
3442 2019-07-17  Tom Tromey  <tromey@adacore.com>
3443
3444         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3445         declare VEC.
3446         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3447         std::vector.
3448         (struct s390_process_info): Add initializers.
3449         (s390_add_process): Use new.
3450         (s390_linux_nat_target::low_forget_process): Use delete.
3451         (s390_linux_nat_target::low_new_fork)
3452         (s390_linux_nat_target::stopped_by_watchpoint)
3453         (s390_linux_nat_target::low_prepare_to_resume)
3454         (s390_linux_nat_target::insert_watchpoint)
3455         (s390_linux_nat_target::insert_hw_breakpoint)
3456         (s390_linux_nat_target::remove_watchpoint)
3457         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3458
3459 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3460
3461         * aarch64-fbsd-nat.c: Include regcache.h.
3462         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3463         argument.
3464         (aarch64_fbsd_nat_target::fetch_registers)
3465         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3466         variable.
3467         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3468
3469 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3470
3471         * fbsd-nat.c: Include gdbarch.h.
3472
3473 2019-07-15  Tom Tromey  <tromey@adacore.com>
3474
3475         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3476
3477 2019-07-15  Tom Tromey  <tromey@adacore.com>
3478
3479         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3480         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3481         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3482         * cli-out.c (cli_ui_out::do_field_int): New method.
3483         * ui-out.c (ui_out::field_unsigned): New method.
3484         * symfile.c (generic_load): Use field_unsigned.
3485         (print_transfer_performance): Likewise.
3486         * record-btrace.c (ui_out_field_uint): Remove.
3487         (btrace_call_history_insn_range, btrace_call_history): Use
3488         field_unsigned.
3489         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3490         field_unsigned.
3491         * ui-out.h (class ui_out) <field_unsigned>: New method.
3492         <do_field_unsigned>: Likewise.
3493
3494 2019-07-15  Tom Tromey  <tromey@adacore.com>
3495
3496         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3497         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3498         * target.c (flash_erase_command): Use field_string.
3499         * infrun.c (print_signal_received_reason): Use field_string.
3500         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3501         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3502         field_string.
3503         * ada-tasks.c (print_ada_task_info): Use field_string.
3504
3505 2019-07-15  Tom Tromey  <tromey@adacore.com>
3506
3507         * target.c (flash_erase_command): Use field_core_addr.
3508         * symfile.c (generic_load): Use field_core_addr.
3509         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3510         Use field_core_addr.
3511         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3512         field_core_addr.
3513
3514 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3515
3516         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3517         value if its desired type is smaller than a CORE_ADDR and signed.
3518
3519 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3522         of changes to field names, and use new is_reference field to
3523         decide if a property is a reference or not.
3524         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3525         field.
3526         (struct dwarf2_property_baton): Update header comment, rename
3527         'referenced_type' to 'property_type' and update comments.
3528         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3529         default property type, store in property baton, update to take
3530         accound of renamed field.
3531         (read_func_scope): Update call to attr_to_dynamic_prop.
3532         (read_array_type): Likewise.
3533         (dwarf2_per_cu_addr_sized_int_type): New function.
3534         (read_subrange_index_type): Move type finding code to
3535         dwarf2_per_cu_addr_sized_int_type.
3536         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3537         (dwarf2_per_cu_addr_type): New function.
3538         (set_die_type): Update calls to attr_to_dynamic_prop.
3539
3540 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3541
3542         * dwarf2read.c (read_subrange_index_type): New function.
3543         (read_subrange_type): Move code into new function and call it.
3544         * gdbtypes.c (create_range_type): Add some asserts.
3545
3546 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3547
3548         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3549         update return statements.
3550         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3551         declaration, and update comment to match.
3552         * gdbtypes.c (resolve_dynamic_array): Update call to
3553         dwarf2_evaluate_property to match new return type.
3554
3555 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * valarith.c (value_subscripted_rvalue): Change lowerbound
3558         parameter type from int to LONGEST.
3559         * value.h (value_subscripted_rvalue): Likewise in declaration.
3560
3561 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3562
3563         * cli/cli-utils.c (info_print_command_completer): New function.
3564         * cli/cli-utils.h: Add 'completer.h' include, and forward
3565         declaration for 'struct cmd_list_element'.
3566         (info_print_command_completer): Declare.
3567         * stack.c (_initialize_stack): Add completer for 'info locals' and
3568         'info args'.
3569         * symtab.c (_initialize_symtab): Add completer for 'info
3570         variables' and 'info functions'.
3571         * NEWS: Mention completion for additional info commands.
3572
3573 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3574
3575         * cli/cli-utils.c (extract_info_print_args): Delete.
3576         (extract_arg_maybe_quoted): Delete.
3577         (info_print_options_defs): New variable.
3578         (make_info_print_options_def_group): New function.
3579         (extract_info_print_options): Define new function.
3580         * cli/cli-utils.h (extract_info_print_args): Delete.
3581         (struct info_print_options): New structure.
3582         (extract_info_print_options): Declare new function.
3583         * stack.c (info_locals_command): Update to use new
3584         extract_info_print_options, also add a header comment.
3585         (info_args_command): Likewise.
3586         * symtab.c (info_variables_command): Likewise.
3587         (info_functions_command): Likewise.
3588
3589 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3590
3591         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3592         to extract string arguments.
3593         * common/common-utils.c (extract_string_maybe_quoted): New function.
3594         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3595
3596 2019-07-11  Tom Tromey  <tromey@adacore.com>
3597
3598         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3599         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3600         * top.h (gdbinit): Don't declare.
3601         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3602         into...
3603         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3604         * top.c (gdb_init): Don't call init_cli_cmds.
3605         (gdbinit): Remove.
3606         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3607
3608 2019-07-11  Tom Tromey  <tromey@adacore.com>
3609
3610         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3611         after it has been moved.
3612
3613 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3614
3615         * valops.c (value_must_coerce_to_target): Change return type to
3616         bool.
3617         * value.h (value_must_coerce_to_target): Likewise.
3618
3619 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3620
3621         * breakpoint.c (is_hardware_watchpoint): Remove
3622         forward-declaration.
3623         (is_masked_watchpoint): Change return type to bool.
3624         (is_tracepoint): Likewise.
3625         (is_breakpoint): Likewise.
3626         (is_hardware_watchpoint): Likewise.
3627         (is_watchpoint): Likewise.
3628         (is_no_memory_software_watchpoint): Likewise.
3629         (is_catchpoint): Likewise.
3630         (breakpoint_1): Make FILTER parameter's return type bool.
3631         is_masked_watchpoint): Change return type to bool.
3632         (save_breakpoints): Make FILTER parameter's return type bool.
3633         * breakpoint.h (is_breakpoint): Change return type to bool.
3634         (is_watchpoint): Likewise.
3635         (is_catchpoint): Likewise.
3636         (is_tracepoint): Likewise.
3637
3638 2019-07-10  Tom Tromey  <tom@tromey.com>
3639
3640         * defs.h: Don't include gdbarch.h.
3641         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3642         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3643         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3644         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3645         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3646         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3647         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3648         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3649         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3650         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3651         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3652         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3653         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3654         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3655         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3656         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3657         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3658         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3659         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3660         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3661         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3662         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3663         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3664         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3665         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3666         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3667         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3668
3669 2019-07-10  Tom Tromey  <tromey@adacore.com>
3670
3671         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3672         * breakpoint.c (init_ada_exception_breakpoint): Register as
3673         bp_catchpoint.
3674         (print_one_breakpoint_location, print_one_breakpoint): Use
3675         is_ada_exception_catchpoint.
3676         * ada-lang.c (class ada_catchpoint_location): Pass
3677         bp_loc_software_breakpoint to bp_location constructor.
3678         (is_ada_exception_catchpoint): New function.
3679
3680 2019-07-10  Tom Tromey  <tromey@adacore.com>
3681
3682         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3683         VEC.
3684         (struct arm_exidx_entry): New method operator<.
3685         (struct arm_exidx_data) <section_maps>: Change type.
3686         (arm_exidx_data_free): Remove.
3687         (arm_exidx_data_key): Change type.  Move lower.
3688         (arm_exidx_new_objfile): Update.
3689         (arm_compare_exidx_entries): Remove.
3690         (arm_find_exidx_entry, _initialize_arm_tdep)
3691
3692 2019-07-10  Tom Tromey  <tromey@adacore.com>
3693
3694         * solib-spu.c (ocl_program_data_key): Change type.
3695         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3696         Update.
3697
3698 2019-07-10  Tom Tromey  <tromey@adacore.com>
3699
3700         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3701         (struct solib_aix_inferior_data) <library_list>: Change type.
3702         (solib_aix_inferior_data_handle): Change type.
3703         (get_solib_aix_inferior_data): Update.
3704         (solib_aix_free_library_list): Remove.
3705         (library_list_start_library): Update.
3706         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3707         return type.
3708         (solib_aix_get_library_list)
3709         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3710         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3711
3712 2019-07-10  Tom Tromey  <tromey@adacore.com>
3713
3714         * solib-dsbt.c (struct dsbt_info): Add initializers.
3715         (solib_dsbt_pspace_data): Change type.
3716         (dsbt_pspace_data_cleanup): Remove.
3717         (get_dsbt_info, _initialize_dsbt_solib): Update.
3718
3719 2019-07-10  Tom Tromey  <tromey@adacore.com>
3720
3721         * spu-tdep.c (spu_overlay_data): Change type.
3722         (spu_get_overlay_table, spu_overlay_new_objfile)
3723         (_initialize_spu_tdep): Update.
3724
3725 2019-07-10  Tom Tromey  <tromey@adacore.com>
3726
3727         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3728         destructor.
3729         (dbx_objfile_data_key): Change type and declare later.
3730         (DBX_SYMFILE_INFO): Rewrite.
3731         * dbxread.c (dbx_objfile_data_key): Change type.
3732         (dbx_symfile_init): Update.
3733         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3734         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3735         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3736
3737 2019-07-10  Tom Tromey  <tromey@adacore.com>
3738
3739         * jit.c (jit_program_space_key): Change type.  Move lower.
3740         (get_jit_program_space_data): Update.
3741         (jit_program_space_data_cleanup): Remove.
3742         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3743         Update.
3744         (struct jit_program_space_data): Add initializers.
3745
3746 2019-07-10  Tom Tromey  <tromey@adacore.com>
3747
3748         * solib-darwin.c (struct darwin_info): Add initializers.
3749         (solib_darwin_pspace_data): Change type.
3750         (darwin_pspace_data_cleanup): Remove.
3751         (get_darwin_info, _initialize_darwin_solib): Update.
3752
3753 2019-07-10  Tom Tromey  <tromey@adacore.com>
3754
3755         * remote-sim.c (struct sim_inferior_data): Add initializers,
3756         constructor, and destructor.
3757         (sim_inferior_data_key): Change type.  Move lower.
3758         (check_for_duplicate_sim_descriptor): Update.
3759         (get_sim_inferior_data): Use new.  Update.
3760         (~sim_inferior_data_cleanup): Rename from
3761         sim_inferior_data_cleanup.  Simplify.
3762         (gdbsim_close_inferior, simulator_command)
3763         (sim_command_completer, _initialize_remote_sim): Update.
3764         (next_pid, INITIAL_PID): Move earlier.
3765
3766 2019-07-10  Tom Tromey  <tromey@adacore.com>
3767
3768         * python/python-internal.h (create_thread_object): Return
3769         gdbpy_ref.
3770         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3771         * python/py-inferior.c (struct threadlist_entry): Add
3772         constructor.
3773         <thread_obj>: Now a gdbpy_ref.
3774         (thread_to_thread_object): Update.
3775         (add_thread_object): Use new.
3776         (delete_thread_object): Use delete.
3777         (infpy_threads): Update.
3778         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3779         GIL.
3780
3781 2019-07-10  Tom Tromey  <tromey@adacore.com>
3782
3783         * valops.c (value_cast): Specialize error message for Ada.
3784
3785 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3786
3787         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3788
3789 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3790
3791         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3792         bpstat_should_step): Return bool, adjust comments.
3793         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3794         bpstat_should_step): Likewise.
3795
3796 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3797
3798         * features/Makefile: Use feature target descriptions for Arm.
3799         * features/arm/arm-core.c: Generate new file.
3800         * features/arm/arm-fpa.c: Likewise.
3801         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3802         * features/arm/arm-m-profile.c: Likewise.
3803         * features/arm/arm-vfpv2.c: Likewise.
3804         * features/arm/arm-vfpv3.c: Likewise.
3805         * features/arm/xscale-iwmmxt.c: Likewise.
3806         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3807
3808 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3809
3810         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3811         ptrace earlier.
3812
3813 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3814
3815         * features/aarch64-pauth.c: Regenerate.
3816
3817 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3818
3819         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3820         bool.
3821         (bpstat_what): Use false instead of 0.
3822
3823 2019-07-09  Pedro Alves  <palves@redhat.com>
3824
3825         * break-catch-throw.c (is_exception_catchpoint): New.
3826         * breakpoint.c (print_one_breakpoint_location): New parameter
3827         'raw_loc'.  Handle it.  Use
3828         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3829         looking at the breakpoint's type.
3830         (print_one_breakpoint): If handling "maint info breakpoints", also
3831         print locations of exception catchpoints.
3832         * breakpoint.h (is_exception_catchpoint): Declare.
3833
3834 2019-07-09  Pedro Alves  <palves@redhat.com>
3835
3836         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3837         "addr" field.
3838         (allocate_location_exception_catchpoint): New.
3839         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3840         (initialize_throw_catchpoint_ops): Install
3841         allocate_location_exception_catchpoint as allocate_location
3842         method.
3843         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3844         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3845         bp_loc_other.
3846         (breakpoint_address_is_meaningful): Delete.
3847         (bl_address_is_meaningful): New.
3848         (breakpoint_locations_match): Adjust comment.
3849         (bp_location_from_bp_type): New, factored out of...
3850         (bp_location::bp_location(breakpoint *)): ... this.
3851         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3852         factored out of...
3853         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3854         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3855         breakpoint_address_is_meaningful.
3856         (bp_locations_compare): Adjust comment.
3857         (update_global_location_list): Use bl_address_is_meaningful
3858         instead of breakpoint_address_is_meaningful.
3859         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3860         explicit.
3861         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3862         * python/py-breakpoint.c (bppy_get_location): No longer check
3863         whether location is null.
3864
3865 2019-07-09  Pedro Alves  <palves@redhat.com>
3866
3867         PR c++/15468
3868         * breakpoint.c (print_one_breakpoint_location): Remove
3869         single-location assert.
3870
3871 2019-07-09  Tom Tromey  <tom@tromey.com>
3872
3873         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3874         * configure: Rebuild.
3875         * configure.ac: Change common to gdbsupport.
3876         * gdbsupport: Rename from common.
3877         * acinclude.m4: Change common to gdbsupport.
3878         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3879         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3880         gdbsupport.
3881         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3882         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3883         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3884         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3885         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3886         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3887         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3888         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3889         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3890         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3891         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3892         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3893         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3894         coff-pe-read.c, command.h, compile/compile-c-support.c,
3895         compile/compile-c.h, compile/compile-cplus-symbols.c,
3896         compile/compile-cplus-types.c, compile/compile-cplus.h,
3897         compile/compile-loc2c.c, compile/compile.c, completer.c,
3898         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3899         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3900         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3901         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3902         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3903         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3904         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3905         features/aarch64-core.c, features/aarch64-fpu.c,
3906         features/aarch64-pauth.c, features/aarch64-sve.c,
3907         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3908         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3909         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3910         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3911         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3912         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3913         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3914         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3915         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3916         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3917         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3918         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3919         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3920         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3921         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3922         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3923         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3924         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3925         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3926         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3927         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3928         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3929         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3930         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3931         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3932         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3933         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3934         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3935         minsyms.c, mips-linux-tdep.c, namespace.h,
3936         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3937         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3938         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3939         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3940         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3941         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3942         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3943         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3944         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3945         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3946         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3947         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3948         procfs.c, producer.c, progspace.h, psymtab.h,
3949         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3950         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3951         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3952         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3953         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3954         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3955         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3956         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3957         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3958         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3959         target-memory.c, target.c, target.h, target/waitstatus.c,
3960         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3961         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3962         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3963         unittests/array-view-selftests.c,
3964         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3965         unittests/common-utils-selftests.c,
3966         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3967         unittests/format_pieces-selftests.c,
3968         unittests/function-view-selftests.c,
3969         unittests/lookup_name_info-selftests.c,
3970         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3971         unittests/mkdir-recursive-selftests.c,
3972         unittests/observable-selftests.c,
3973         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3974         unittests/parse-connection-spec-selftests.c,
3975         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3976         unittests/scoped_fd-selftests.c,
3977         unittests/scoped_mmap-selftests.c,
3978         unittests/scoped_restore-selftests.c,
3979         unittests/string_view-selftests.c, unittests/style-selftests.c,
3980         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3981         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3982         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3983         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3984         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3985         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3986
3987 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3990         bool value.
3991         (decode_digits_ordinary): Set explicit_line field in sal.
3992         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3993         symtab_and_line that was set on an explicit line number in
3994         assembler code.  Do always update the recorded symtab and line if
3995         we do skip the prologue.
3996
3997 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3998
3999         * breakpoint.c (set_breakpoint_location_function): Remove
4000         explicit_loc parameter.
4001         (momentary_breakpoint_from_master): Update call to
4002         set_breakpoint_location_function.
4003         (add_location_to_breakpoint): Likewise.
4004
4005 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4006
4007         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4008         required features based on default bfd type when no specific bfd
4009         is present.
4010
4011 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4012
4013         * NEWS: Mention that GDB printf and eval commands can now print
4014         C-style and Ada-style convenience var strings without
4015         calling the inferior.
4016         * printcmd.c (printf_c_string): Locally print GDB internal var
4017         instead of transiting via the inferior.
4018         (printf_wide_c_string): Likewise.
4019
4020 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4021
4022         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4023
4024 2019-07-04  Tom Tromey  <tom@tromey.com>
4025
4026         PR tui/24724:
4027         * tui/tui-winsource.c (tui_clear_source_content): Update.
4028         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4029         (tui_update_breakpoint_info): Update.
4030         (tui_set_exec_info_content): Update.
4031         * tui/tui-source.c (tui_set_source_content_nil): Update.
4032         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4033         has_break.
4034         * tui/tui-data.h (enum tui_bp_flag): New.
4035         (tui_bp_flags): New enum flags type.
4036         (struct tui_source_element) <break_mode>: Change type.  Rename
4037         from has_break.
4038         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4039         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4040         constants.
4041         * tui/tui-winsource.h: Fix comment.
4042
4043 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4044
4045         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4046         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4047         (store_fpregs_to_thread)
4048         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4049         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4050         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4051         (IWMMXT_REGS_SIZE): Add define.
4052         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4053         (fetch_vfp_regs, store_vfp_regs)
4054         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4055         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4056
4057 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4058
4059         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4060         defines.
4061         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4062         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4063         (ARM_INT_REGISTER_SIZE): ...to this.
4064         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4065         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4066         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4067         (arm_linux_collect_gregset, supply_nwfpe_register)
4068         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4069         defines.
4070         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4071         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4072         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4073         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4074         (arm_return_in_memory, arm_store_return_value)
4075         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4076         (arm_record_ld_st_multiple): Likewise.
4077         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4078         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4079
4080 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4081
4082         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4083         AARCH64_DISPLACED_MODIFIED_INSNS.
4084         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4085         (aarch64_displaced_step_copy_insn): Likewise.
4086         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4087         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4088         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4089         ARM_DISPLACED_MODIFIED_INSNS.
4090         * arm-tdep.c (arm_gdbarch_init): Likewise.
4091         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4092         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4093         (struct arm_displaced_step_closure): Use
4094         ARM_DISPLACED_MODIFIED_INSNS.
4095
4096 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4097
4098         * features/Makefile: Remove unused xml files.
4099         * features/aarch64.xml: Remove.
4100         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4101         * features/i386/amd64-avx-avx512.xml: Remove.
4102         * features/i386/amd64-avx-linux.xml: Remove.
4103         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4104         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4105         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4106         * features/i386/amd64-avx-mpx.xml: Remove.
4107         * features/i386/amd64-avx.xml: Remove.
4108         * features/i386/amd64-linux.xml: Remove.
4109         * features/i386/amd64-mpx-linux.xml: Remove.
4110         * features/i386/amd64-mpx.xml: Remove.
4111         * features/i386/amd64.xml: Remove.
4112         * features/i386/i386-avx-avx512-linux.xml: Remove.
4113         * features/i386/i386-avx-avx512.xml: Remove.
4114         * features/i386/i386-avx-linux.xml: Remove.
4115         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4116         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4117         * features/i386/i386-avx-mpx-linux.xml: Remove.
4118         * features/i386/i386-avx-mpx.xml: Remove.
4119         * features/i386/i386-avx.xml: Remove.
4120         * features/i386/i386-linux.xml: Remove.
4121         * features/i386/i386-mmx-linux.xml: Remove.
4122         * features/i386/i386-mmx.xml: Remove.
4123         * features/i386/i386-mpx-linux.xml: Remove.
4124         * features/i386/i386-mpx.xml: Remove.
4125         * features/i386/i386.xml: Remove.
4126         * features/i386/x32-avx-avx512-linux.xml: Remove.
4127         * features/i386/x32-avx-linux.xml: Remove.
4128         * features/i386/x32-linux.xml: Remove.
4129
4130 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4131
4132         * regformats/aarch64.dat: Remove.
4133         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4134         * regformats/i386/amd64-avx-linux.dat: Remove.
4135         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4136         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4137         * regformats/i386/amd64-linux.dat: Remove.
4138         * regformats/i386/amd64-mpx-linux.dat: Remove.
4139         * regformats/i386/amd64.dat: Remove.
4140         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4141         * regformats/i386/i386-avx-linux.dat: Remove.
4142         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4143         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4144         * regformats/i386/i386-linux.dat: Remove.
4145         * regformats/i386/i386-mmx-linux.dat: Remove.
4146         * regformats/i386/i386-mpx-linux.dat: Remove.
4147         * regformats/i386/i386.dat: Remove.
4148         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4149         * regformats/i386/x32-avx-linux.dat: Remove.
4150         * regformats/i386/x32-linux.dat: Remove.
4151
4152 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4153
4154         * aarch64-tdep.c: Remove xml self tests.
4155         * amd64-linux-tdep.c: Likewise.
4156         * amd64-tdep.c: Likewise.
4157         * i386-linux-tdep.c: Likewise.
4158         * i386-tdep.c: Likewise.
4159
4160 2019-07-03  Pedro Alves  <palves@redhat.com>
4161
4162         PR cli/24732
4163         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4164         (pipe_cmd_option_defs): New.
4165         (make_pipe_cmd_options_def_group): New.
4166         (pipe_command): Use gdb::option::process_options.
4167         (pipe_command_completer): New function.
4168         (_initialize_cli_cmds): Install completer for "pipe" command.
4169
4170 2019-07-03  Pedro Alves  <palves@redhat.com>
4171
4172         * cli/cli-option.c (union option_value) <string>: New field.
4173         (struct option_def_and_value): Add ctor, move ctor, dtor and
4174         use DISABLE_COPY_AND_ASSIGN.
4175         (option_def_and_value::clear_value): New.
4176         (parse_option, save_option_value_in_ctx, get_val_type_str)
4177         (add_setshow_cmds_for_options): Handle var_string.
4178         * cli-option.h (union option_def::var_address) <string>: New
4179         field.
4180         (struct string_option_def): New.
4181         * maint-test-options.c (struct test_options_opts): Add default
4182         ctor and use DISABLE_COPY_AND_ASSIGN.
4183         <string_opt>: New field.
4184         (test_options_opts::~test_options_opts): New.
4185         (test_options_opts::dump): Also dump "-string".
4186         (test_options_option_defs): Install "string.
4187
4188 2019-07-03  Pedro Alves  <palves@redhat.com>
4189
4190         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4191         option_value with a null enumeration.
4192         (complete_options): Save the option values in the context.
4193         (save_option_value_in_ctx): New, factored out from ...
4194         (process_options): ... here.
4195         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4196         of the function.
4197         * maint-test-options.c (test_options_opts::dump): New, factored
4198         out from ...
4199         (maintenance_test_options_command_mode): ... here.
4200         (maintenance_test_options_command_completion_result): Delete.
4201         (maintenance_test_options_command_completion_text): Update
4202         comment.
4203         (maintenance_show_test_options_completion_result): Change
4204         prototype.  Just print
4205         maintenance_test_options_command_completion_text.
4206         (save_completion_result): New.
4207         (maintenance_test_options_completer_mode): Pass options context to
4208         complete_options, and then save a dump.
4209         (_initialize_maint_test_options): Use add_cmd to install "maint
4210         show test-options-completion-result".
4211
4212 2019-07-03  Pedro Alves  <palves@redhat.com>
4213
4214         * NEWS (New commands): Mention "with" and "maint with".
4215         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4216         (with_command, with_command_completer): New.
4217         (pipe_command): Adjust to new repeat_previous
4218         interface.
4219         (_initialize_cli_cmds): Install the "with" command and its "w"
4220         alias.
4221         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4222         declarations.
4223         * cli/cli-setshow.c (parse_cli_var_uinteger)
4224         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4225         argument strings for all var_types.
4226         (get_setshow_command_value_string): New, factored out from ...
4227         (do_show_command): ... this.
4228         * cli/cli-setshow.h: Include <string>.
4229         (get_setshow_command_value_string): Declare.
4230         * command.h (repeat_previous): Now returns const char *.  Adjust
4231         comment.
4232         * maint.c: Include "cli/cli-cmds.h".
4233         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4234         (_initialize_maint_cmds): Register the "maintenance with" command.
4235         * top.c (repeat_previous): Move bits from pipe_command here:
4236         Return the saved command line, if any; error out if there's no
4237         command to relaunch.
4238
4239 2019-07-03  Pedro Alves  <palves@redhat.com>
4240
4241         * NEWS (New commands): Mention "maint set/show test-settings"
4242         instead of "maint test-settings".
4243         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4244         (maintenance_test_settings_set_list): Rename to ...
4245         (maintenance_set_test_settings_list): ... this.
4246         (maintenance_test_settings_show_list): Rename to  ...
4247         (maintenance_show_test_settings_list): ... this.
4248         (maintenance_test_settings_cmd): Delete.
4249         (maintenance_test_settings_set_cmd): ...
4250         (maintenance_set_test_settings_cmd): ... this.
4251         (maintenance_test_settings_show_cmd): ...
4252         (maintenance_show_test_settings_cmd): ... this.
4253         (maintenance_test_settings_show_value_cmd):
4254         (maintenance_show_test_settings_value_cmd): ... this.
4255         (_initialize_maint_test_settings): No longer install the "maint
4256         test-settings" prefix command.  Rename "maint test-settings set"
4257         to "maint set test-settings", and "maint test-settings show" to
4258         "maint show test-settings".  Adjust all subcommands.
4259
4260 2019-07-03  Pedro Alves  <palves@redhat.com>
4261
4262         * maint-test-settings.c: Fix file's intro comment.  Replace all
4263         references to "test-options" with references to "test-settings",
4264         in comments.
4265
4266 2019-07-03  Pedro Alves  <palves@redhat.com>
4267
4268         * maint-test-settings.c (maintenance_test_settings_xxx)
4269         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4270         New.
4271         (maintenance_test_settings_enums): Use them.
4272         (maintenance_test_settings_enum): Default to
4273         maintenance_test_settings_xxx.
4274         (_initialize_maint_test_settings): Initialize
4275         MAINTENANCE_TEST_SETTINGS_FILENAME.
4276
4277 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4278
4279         * breakpoint.h (remove_breakpoints_inf): Change return type to
4280         void, move function documentation here.
4281         * breakpoint.c (remove_breakpoints_inf): Change return type to
4282         void, move function documentation to header.
4283
4284 2019-07-02  Pedro Alves  <palves@redhat.com>
4285
4286         * NEWS (Completion improvements): Mention "info threads".
4287         * thread.c (struct info_threads_opts, info_threads_option_defs)
4288         (make_info_threads_options_def_group): New.
4289         (info_threads_command): Use gdb::option::process_options.
4290         (info_threads_command_completer): New.
4291         (_initialize_thread): Use gdb::option::build_help to build the
4292         help text for "info threads".
4293
4294 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4295
4296         * defs.h (generic_load): Move from here...
4297         * symfile.h (generic_load): ... to here.  Rename name parameter
4298         to args.
4299         * symfile.c (generic_load): Add comment.
4300
4301 2019-07-01  Tom Tromey  <tromey@adacore.com>
4302
4303         * dwarf2read.c
4304         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4305         declaration of without_params.  Fix formatting.
4306
4307 2019-07-01  Tom Tromey  <tromey@adacore.com>
4308
4309         * ada-exp.y (find_primitive_type): Update.
4310         * ada-lang.h (ada_lookup_symbol): Update.
4311         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4312         parameter.
4313         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4314
4315 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4316
4317         PR breakpoints/24541
4318         * gdbarch.c: Regenerate.
4319         * gdbarch.h: Regenerate.
4320         * gdbarch.sh: Add 'stap_adjust_register'.
4321         * i386-tdep.c: Include '<unordered_set>'.
4322         (i386_stap_adjust_register): New function.
4323         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4324         * stap-probe.c (stap_parse_register_operand): Call
4325         'gdbarch_stap_adjust_register'.
4326
4327 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4328
4329         PR python/24742
4330         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4331         * python/python.c (do_start_initialization): Use 'xmalloc'
4332         instead of 'PyMem_Malloc'.
4333
4334 2019-06-28  Tom Tromey  <tromey@adacore.com>
4335
4336         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4337         for Ada.
4338
4339 2019-06-27  Tom Tromey  <tromey@adacore.com>
4340
4341         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4342         objfile_key.
4343         (arm_find_mapping_symbol, arm_record_special_symbol)
4344         (_initialize_arm_tdep): Update.
4345         (arm_objfile_data_free): Remove.
4346
4347 2019-06-27  Tom Tromey  <tromey@adacore.com>
4348
4349         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4350         to cp_print_static_field.
4351
4352 2019-06-26  Tom Tromey  <tromey@adacore.com>
4353
4354         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4355         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4356         declare.
4357
4358 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4359
4360         * features/aarch64-core.c (create_feature_aarch64_core):
4361         Regenerate.
4362         * features/aarch64-core.xml: Add cpsr flags.
4363
4364 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4365
4366         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4367         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4368
4369 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4370
4371         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4372         field.
4373         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4374         use.
4375         (arm_record_special_symbol): Don't insert new symbol in sorted
4376         position, push it at the end.
4377
4378 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4379
4380         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4381         (arm_mapping_symbol_s): Remove.
4382         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4383         (arm_mapping_symbol_vec): New typedef.
4384         (struct arm_per_objfile): Add constructor.
4385         <section_maps>: Change type to
4386         std::unique_ptr<arm_mapping_symbol_vec[]>.
4387         (arm_compare_mapping_symbols): Remove.
4388         (arm_find_mapping_symbol): Adjust to section_maps type change.
4389         (arm_objfile_data_free): Call delete on arm_per_objfile.
4390         (arm_record_special_symbol): Adjust to section_maps type change.
4391         Allocate arm_per_objfile with new.
4392
4393 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4394
4395         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4396         with the command prefix.
4397
4398 2019-06-25  Tom Tromey  <tom@tromey.com>
4399
4400         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4401         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4402
4403 2019-06-25  Tom Tromey  <tom@tromey.com>
4404
4405         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4406         type.
4407         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4408         protected.
4409
4410 2019-06-25  Tom Tromey  <tom@tromey.com>
4411
4412         * tui/tui-winsource.c
4413         (tui_source_window_base::set_is_exec_point_at): Add check against
4414         LOA_ADDRESS.
4415
4416 2019-06-25  Tom Tromey  <tom@tromey.com>
4417
4418         * tui/tui-source.c (tui_set_source_content): Don't check before
4419         xfree.
4420         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4421
4422 2019-06-25  Tom Tromey  <tom@tromey.com>
4423
4424         * tui/tui-winsource.h (tui_update_source_window_as_is)
4425         (tui_alloc_source_buffer, tui_line_is_displayed)
4426         (tui_addr_is_displayed): Change type of win_info.
4427         * tui/tui-winsource.c (tui_update_source_window_as_is)
4428         (tui_clear_source_content, tui_show_source_line)
4429         (tui_show_source_content, tui_source_window_base::refill)
4430         (tui_source_window_base::set_is_exec_point_at)
4431         (tui_source_window_base::set_is_exec_point_at)
4432         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4433         (tui_alloc_source_buffer, tui_line_is_displayed)
4434         (tui_addr_is_displayed): Change type of win_info.  Update.
4435         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4436         (tui_source_window_base::do_make_visible_with_new_height):
4437         Update.
4438         * tui/tui-source.c (tui_set_source_content)
4439         (tui_set_source_content_nil)
4440         (tui_source_window::do_scroll_vertical): Update.
4441         * tui/tui-layout.c (show_layout): Update.
4442         * tui/tui-disasm.c (tui_set_disassem_content)
4443         (tui_disasm_window::do_scroll_vertical): Update.
4444         * tui/tui-data.h (tui_win_content): Remove.
4445         (struct tui_gen_win_info) <content, content_size>: Remove.
4446         (struct tui_source_element): Add initializers and destructor.
4447         (union tui_which_element, struct tui_win_element): Remove.
4448         (struct tui_source_window_base) <content>: New field.
4449         (struct tui_data_window): Remove destructor.
4450         (tui_alloc_content, tui_free_win_content)
4451         (tui_free_all_source_wins_content): Don't declare.
4452         * tui/tui-data.c (tui_initialize_static_data): Update.
4453         (init_content_element, tui_alloc_content): Remove.
4454         (~tui_gen_win_info): Update.
4455         (~tui_data_window, tui_free_all_source_wins_content)
4456         (tui_free_win_content, free_content, free_content_elements):
4457         Remove.
4458
4459 2019-06-25  Tom Tromey  <tom@tromey.com>
4460
4461         * tui/tui-winsource.h (tui_clear_source_content)
4462         (tui_erase_source_content, tui_show_source_content): Change type
4463         of win_info.
4464         * tui/tui-winsource.c (tui_clear_source_content)
4465         (tui_erase_source_content, tui_show_source_content): Change type
4466         of win_info.
4467         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4468         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4469         win_info.
4470         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4471         win_info.
4472         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4473
4474 2019-06-25  Tom Tromey  <tom@tromey.com>
4475
4476         * tui/tui-winsource.c (tui_clear_source_content)
4477         (tui_source_window_base::set_is_exec_point_at): Update.
4478         * tui/tui-source.c (tui_set_source_content_nil): Update.
4479         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4480         a bool.
4481         * tui/tui-data.c (init_content_element): Update.
4482
4483 2019-06-25  Tom Tromey  <tom@tromey.com>
4484
4485         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4486         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4487         * tui/tui-layout.c (init_and_make_win): Update.
4488         * tui/tui.h (enum tui_win_type): Update.
4489         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4490         tui_win_is_auxillary.
4491         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4492         tui_win_is_auxillary.
4493
4494 2019-06-25  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4497         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4498         (tui_delete_data_content_windows, tui_display_all_data)
4499         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4500         Update.
4501         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4502         * tui/tui-regs.c (tui_last_regs_line_no)
4503         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4504         (tui_show_registers): Update.
4505         (tui_show_register_group): Return void.  Update.
4506         (tui_display_registers_from, tui_display_reg_element_at_line)
4507         (tui_display_registers_from_line, tui_check_register_values):
4508         Update.
4509         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4510         member.
4511         (struct tui_data_window) <regs_content>: Now a std::vector.
4512         <regs_content_count>: Remove.
4513         (tui_add_content_elements, tui_free_data_content): Don't declare.
4514         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4515         (init_content_element): Remove DATA_WIN case.  Add assert.
4516         (tui_add_content_elements): Remove.
4517         (tui_data_window): Update.
4518         (tui_free_data_content): Remove.
4519         (free_content_elements): Remove DATA_WIN case.
4520
4521 2019-06-25  Tom Tromey  <tom@tromey.com>
4522
4523         * tui/tui-data.c (tui_data_item_window): Update.
4524         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4525         * tui/tui-windata.c (tui_display_all_data)
4526         (tui_display_data_from_line): Update.
4527         (tui_check_data_values): Remove.
4528         * tui/tui-regs.c (tui_show_register_group)
4529         (tui_display_reg_element_at_line): Update.
4530         * tui/tui-hooks.c (tui_register_changed)
4531         (tui_refresh_frame_and_register_information): Call
4532         tui_check_register_values.
4533         * tui/tui-data.h (struct tui_data_window) <data_content,
4534         data_content_count, data_type>: Remove.
4535         (enum tui_data_type): Remove.
4536
4537         * tui/tui-data.c (tui_data_window::clear_detail)
4538         (~tui_data_window): Update.
4539
4540 2019-06-25  Tom Tromey  <tom@tromey.com>
4541
4542         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4543         declare.
4544         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4545         Rename from tui_first_data_item_displayed.  Update.
4546         (tui_data_window::refresh_all)
4547         (tui_data_window::do_scroll_vertical): Update.
4548         * tui/tui-data.h (struct tui_data_window)
4549         <first_data_item_displayed>: Declare new method.
4550
4551 2019-06-25  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4554         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4555         contents...
4556         (tui_initialize_static_data): ...here.
4557
4558 2019-06-25  Tom Tromey  <tom@tromey.com>
4559
4560         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4561         (tui_display_registers_from, tui_check_register_values): Update.
4562         (tui_display_register): Remove win_info parameter; update.
4563         (tui_get_register): Change type of parameters.
4564         * tui/tui-data.h (struct tui_data_element): Remove.
4565         (union tui_which_element) <data>: Remove.
4566         <data_window>: Change type.
4567         (struct tui_data_item_window): New.
4568         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4569         case.  Add assert.
4570         (~tui_data_item_window): New destructor.
4571         (free_content_elements): Remove DATA_ITEM_WIN case.
4572
4573 2019-06-25  Tom Tromey  <tom@tromey.com>
4574
4575         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4576         Remove.
4577
4578 2019-06-25  Tom Tromey  <tom@tromey.com>
4579
4580         * tui/tui-data.h (struct tui_command_element): Remove.
4581         (union tui_which_element) <command>: Remove.
4582         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4583         assert.
4584         (free_content_elements): Remove CMD_WIN case.
4585
4586 2019-06-25  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui-layout.c (tui_set_layout): Update.
4589         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4590         * tui/tui-data.c (layout_def): Update.
4591
4592 2019-06-25  Tom Tromey  <tom@tromey.com>
4593
4594         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4595         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4596         (tui_source_window_base::set_new_height): Update.
4597         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4598         Update.
4599         (tui_set_locator_fullname, tui_set_locator_info)
4600         (tui_show_frame_info): Update.
4601         * tui/tui-source.c (tui_set_source_content)
4602         (tui_source_is_displayed): Update.
4603         * tui/tui-layout.c (show_source_disasm_command, show_data)
4604         (show_source_or_disasm_and_command): Update.
4605         * tui/tui-disasm.c (tui_set_disassem_content)
4606         (tui_get_begin_asm_address): Update.
4607         * tui/tui-data.h (struct tui_locator_element): Remove.
4608         (union tui_which_element) <locator>: Remove.
4609         (struct tui_locator_window): New.
4610         (tui_locator_win_info_ptr): Change return type.
4611         * tui/tui-data.c (_locator): Change type.
4612         (tui_locator_win_info_ptr): Change return type.
4613         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4614         (tui_alloc_content): Add assert.
4615
4616 2019-06-25  Tom Tromey  <tom@tromey.com>
4617
4618         * tui/tui-winsource.c
4619         (tui_exec_info_window::maybe_allocate_content): New method.
4620         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4621         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4622         (make_source_or_disasm_window): Add cast.
4623         * tui/tui-data.h (union tui_which_element) <simple_string>:
4624         Remove.
4625         (struct tui_source_info): New.
4626         (struct tui_source_window_base) <execution_info>: Change type.
4627         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4628         case, and add assert.
4629         (tui_alloc_content): Add assert.
4630
4631 2019-06-25  Tom Tromey  <tom@tromey.com>
4632
4633         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4634         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4635         * tui/tui-data.c (tui_alloc_win_info): Remove.
4636
4637 2019-06-25  Tom Tromey  <tom@tromey.com>
4638
4639         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4640         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4641         can_highlight.
4642
4643 2019-06-25  Tom Tromey  <tom@tromey.com>
4644
4645         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4646         make_visible_with_new_height method.
4647         (tui_win_info::make_visible_with_new_height): New method.
4648         (tui_source_window_base::do_make_visible_with_new_height)
4649         (tui_data_window::do_make_visible_with_new_height)
4650         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4651         (make_visible_with_new_height): Remove.
4652         (tui_resize_all, tui_adjust_win_heights): Use
4653         make_visible_with_new_height method.
4654         * tui/tui-data.h (struct tui_win_info)
4655         <do_make_visible_with_new_height, make_visible_with_new_height>:
4656         New methods.
4657         (struct tui_source_window_base, struct tui_data_window)
4658         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4659         methods.
4660
4661 2019-06-25  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4664         method.
4665         (update_tab_width): Call update_tab_width method.
4666         * tui/tui-data.h (struct tui_win_info)
4667         (struct tui_source_window_base) <update_tab_width>: New methods.
4668
4669 2019-06-25  Tom Tromey  <tom@tromey.com>
4670
4671         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4672         parameter.
4673         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4674         parameter.
4675         (tui_gen_win_info::make_visible): Update.
4676         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4677         parameter.
4678         * tui/tui-data.h (enum tui_box): New enum.
4679         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4680
4681 2019-06-25  Tom Tromey  <tom@tromey.com>
4682
4683         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4684         init_and_make_win for EXEC_INFO_WIN.
4685         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4686         longer inline.
4687         (struct tui_win_info) <~tui_win_info>: Inline.
4688         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4689         Don't declare.
4690         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4691         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4692         Remove.
4693         (tui_initialize_static_data): Update.
4694         (~tui_gen_win_info): Handle more cleanup here.
4695         (~tui_source_window_base): Delete "execution_info".
4696         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4697
4698 2019-06-25  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui-layout.c (make_command_window): Don't set
4701         can_highlight.
4702         (show_source_disasm_command): Call the reset method.
4703         (show_data): Don't set can_highlight.  Call the reset method.
4704         (tui_gen_win_info::reset): Rename from init_gen_win_info
4705         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4706         (show_source_or_disasm_and_command): Call the reset method.
4707         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4708         (struct tui_cmd_window): Set can_highlight.
4709
4710 2019-06-25  Tom Tromey  <tom@tromey.com>
4711
4712         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4713         from make_visible.
4714         (tui_make_visible, tui_make_invisible): Rewrite.
4715         (tui_win_info::make_visible): Remove.
4716         (tui_source_window_base::make_visible): Update.
4717         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4718         method.  Moved from...
4719         (struct tui_win_info) <make_visible>: ...here.
4720
4721 2019-06-25  Tom Tromey  <tom@tromey.com>
4722
4723         * tui/tui-winsource.c
4724         (tui_source_window_base::do_scroll_horizontal): Remove direction
4725         parameter.
4726         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4727         direction parameter.
4728         * tui/tui-win.c (tui_win_info::forward_scroll)
4729         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4730         (tui_win_info::right_scroll): Update.
4731         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4732         direction parameter.
4733         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4734         direction parameter.
4735         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4736         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4737         Remove direction parameter.
4738         (struct tui_source_window_base, struct tui_source_window)
4739         (struct tui_disasm_window, struct tui_data_window)
4740         (struct tui_cmd_window): Update.
4741
4742 2019-06-25  Tom Tromey  <tom@tromey.com>
4743
4744         * tui/tui-winsource.h (tui_set_exec_info_content)
4745         (tui_show_exec_info_content, tui_erase_exec_info_content)
4746         (tui_clear_exec_info_content, tui_update_exec_info): Change
4747         argument to tui_source_window_base.
4748         * tui/tui-winsource.c (tui_set_exec_info_content)
4749         (tui_show_exec_info_content, tui_erase_exec_info_content)
4750         (tui_clear_exec_info_content, tui_update_exec_info): Change
4751         argument to tui_source_window_base.
4752
4753 2019-06-25  Tom Tromey  <tom@tromey.com>
4754
4755         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4756         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4757
4758 2019-06-25  Tom Tromey  <tom@tromey.com>
4759
4760         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4761         check.
4762
4763 2019-06-25  Tom Tromey  <tom@tromey.com>
4764
4765         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4766         type to void.
4767         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4768         type to void.
4769         * tui/tui-source.c (tui_set_source_content): Update.
4770         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4771
4772 2019-06-25  Tom Tromey  <tom@tromey.com>
4773
4774         * tui/tui-win.c (window_name_completer, tui_set_focus)
4775         (tui_all_windows_info): Use name method.
4776         * tui/tui-data.h (struct tui_gen_win_info)
4777         (struct tui_source_window, struct tui_disasm_window)
4778         (struct tui_data_window, struct tui_cmd_window) <name>: New
4779         method.
4780         (tui_win_name): Don't declare.
4781         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4782         (tui_win_name): Remove.
4783
4784 2019-06-25  Tom Tromey  <tom@tromey.com>
4785
4786         * tui/tui-winsource.h (tui_update_source_window)
4787         (tui_update_source_window_as_is): Change parameter type.
4788         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4789         to be a tui_source_window_base.
4790         (tui_update_source_window_as_is): Likewise.
4791         * tui/tui-win.c (make_visible_with_new_height): Update.
4792
4793 2019-06-25  Tom Tromey  <tom@tromey.com>
4794
4795         * tui/tui-winsource.c (tui_erase_source_content)
4796         (tui_show_source_content, tui_show_exec_info_content)
4797         (tui_erase_exec_info_content): Use refresh_window method.
4798         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4799         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4800         from tui_refresh_win.
4801         (tui_data_window::refresh_window): New method.
4802         (tui_win_info::refresh, tui_source_window_base::refresh)
4803         (tui_refresh_all): Use refresh_window method.
4804         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4805         method.
4806         * tui/tui-regs.c (tui_display_register): Call refresh_window
4807         method.
4808         * tui/tui-layout.c (show_source_disasm_command)
4809         (show_source_or_disasm_and_command): Call refresh_window method.
4810         * tui/tui-data.h (struct tui_gen_win_info)
4811         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4812         New method.
4813
4814 2019-06-25  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui.c (tui_rl_other_window, tui_enable)
4817         (tui_is_window_visible, tui_get_command_dimension): Update.
4818         * tui/tui-winsource.c (tui_update_source_window_as_is)
4819         (tui_clear_source_content, tui_erase_source_content)
4820         (tui_show_source_line, tui_source_window_base::refill)
4821         (tui_source_window_base::do_scroll_horizontal)
4822         (tui_source_window_base::set_is_exec_point_at)
4823         (tui_update_breakpoint_info, tui_set_exec_info_content)
4824         (tui_alloc_source_buffer, tui_line_is_displayed)
4825         (tui_addr_is_displayed): Update.
4826         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4827         (tui_check_and_display_highlight_if_needed)
4828         (tui_win_info::make_visible, tui_win_info::refresh)
4829         (tui_refresh_all): Update.
4830         * tui/tui-windata.c (tui_first_data_item_displayed)
4831         (tui_delete_data_content_windows, tui_erase_data_content)
4832         (tui_display_all_data, tui_data_window::refresh_all)
4833         (tui_check_data_values): Update.
4834         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4835         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4836         (tui_win_info::backward_scroll, tui_refresh_all_win)
4837         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4838         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4839         (tui_source_window_base::set_new_height)
4840         (tui_data_window::set_new_height)
4841         (make_invisible_and_set_new_height)
4842         (make_visible_with_new_height, new_height_ok)
4843         (parse_scrolling_args): Update.
4844         * tui/tui-stack.c (tui_show_frame_info): Update.
4845         * tui/tui-source.c (tui_set_source_content)
4846         (tui_set_source_content_nil, tui_source_is_displayed)
4847         (tui_source_window::do_scroll_vertical): Update.
4848         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4849         (tui_display_registers_from, tui_display_reg_element_at_line)
4850         (tui_check_register_values, tui_reg_command): Update.
4851         * tui/tui-layout.c (tui_default_win_height)
4852         (show_source_disasm_command, show_data, init_and_make_win)
4853         (show_source_or_disasm_and_command): Update.
4854         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4855         (tui_redisplay_readline, tui_mld_flush)
4856         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4857         (tui_getc): Update.
4858         * tui/tui-disasm.c (tui_set_disassem_content)
4859         (tui_disasm_window::do_scroll_vertical): Update.
4860         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4861         Now virtual.
4862         (struct tui_win_info): Derive from tui_gen_win_info.
4863         <~tui_win_info>: Mark as override.
4864         <generic>: Remove member.
4865         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4866         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4867         (~tui_data_window, ~tui_win_info)
4868         (tui_free_all_source_wins_content): Update.
4869         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4870
4871 2019-06-25  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-layout.c (init_and_make_win): Use new.
4874         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4875         destructor, initializers.
4876         (tui_alloc_generic_win_info): Don't declare.
4877         * tui/tui-data.c (_locator): Add argument to constructor.
4878         (source_win, disasm_win): New globals.
4879         (exec_info): Remove.
4880         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4881         Update.
4882         (tui_alloc_generic_win_info): Remove.
4883         (init_content_element): Use new.
4884         (tui_win_info::tui_win_info): Update.
4885         (free_content_elements) <case DATA_WIN>: Use delete.
4886
4887 2019-06-25  Tom Tromey  <tom@tromey.com>
4888
4889         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4890         * tui/tui-windata.c (tui_first_data_item_displayed)
4891         (tui_delete_data_content_windows): Update.
4892         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4893         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4894         (tui_display_registers_from, tui_check_register_values): Update.
4895         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4896         pointer.
4897         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4898         window.
4899         (tui_free_data_content): Update.
4900         (free_content_elements) <case DATA_WIN>: Free the window.
4901
4902 2019-06-25  Tom Tromey  <tom@tromey.com>
4903
4904         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4905         Update.
4906         * tui/tui-layout.c (make_command_window)
4907         (show_source_disasm_command, show_data, init_and_make_win)
4908         (show_source_or_disasm_and_command): Update.
4909         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4910         method.
4911         <can_highight, is_highlighted>: Now bool.
4912         (tui_set_win_highlight): Don't declare.
4913         * tui/tui-data.c (tui_set_win_highlight): Remove.
4914
4915 2019-06-25  Tom Tromey  <tom@tromey.com>
4916
4917         * tui/tui-wingeneral.c (make_visible): Remove check of window
4918         type.
4919
4920 2019-06-25  Tom Tromey  <tom@tromey.com>
4921
4922         * tui/tui-win.c (tui_win_info::max_height)
4923         (tui_cmd_window::max_height): New methods.
4924         (new_height_ok): Call max_height.
4925         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4926         <max_height>: New method.
4927
4928 2019-06-25  Tom Tromey  <tom@tromey.com>
4929
4930         * tui/tui-win.c (tui_source_window_base::set_new_height)
4931         (tui_data_window::set_new_height): New methods.
4932         (make_invisible_and_set_new_height): Call set_new_height method.
4933         * tui/tui-data.h (struct tui_win_info)
4934         (struct tui_source_window_base, struct tui_data_window)
4935         <set_new_height>: New method.
4936
4937 2019-06-25  Tom Tromey  <tom@tromey.com>
4938
4939         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4940         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4941         tui_refresh_data_win.
4942         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4943         method.
4944         (tui_refresh_all_win): Call the refresh_all method.
4945         (tui_set_focus): Likewise.
4946         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4947         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4948         Likewise.
4949
4950 2019-06-25  Tom Tromey  <tom@tromey.com>
4951
4952         * tui/tui-winsource.h (tui_refill_source_window)
4953         (tui_set_is_exec_point_at): Don't declare.
4954         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4955         (tui_source_window_base::refill): Rename from
4956         tui_refill_source_window.
4957         (tui_source_window_base::do_scroll_horizontal): Update.
4958         (tui_source_window_base::set_is_exec_point_at): Rename from
4959         tui_set_is_exec_point_at.
4960         (tui_update_all_breakpoint_info): Update.
4961         * tui/tui-stack.c (tui_show_frame_info): Update.
4962         * tui/tui-layout.c (show_data): Add cast.
4963         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4964         * tui/tui-data.h (struct tui_source_window_base) <refill,
4965         set_is_exec_point_at>: New methods.
4966         (tui_source_windows, tui_add_to_source_windows): Update types.
4967         (tui_add_to_source_windows): Remove redundant declaration.
4968         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4969         (tui_source_windows): Change return type.
4970         (tui_clear_source_windows_detail): Update.
4971         (tui_add_to_source_windows): Change type of parameter.
4972         (tui_free_all_source_wins_content): Update.
4973
4974 2019-06-25  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui-wingeneral.c (tui_win_info::refresh)
4977         (tui_source_window_base::refresh): New methods.
4978         (tui_refresh_all): Call the refresh method.
4979         * tui/tui-data.h (struct tui_win_info)
4980         (struct tui_source_window_base) <refresh>: New method.
4981
4982 2019-06-25  Tom Tromey  <tom@tromey.com>
4983
4984         * tui/tui.h (tui_is_window_visible): Return bool.
4985         * tui/tui.c (tui_is_window_visible): Return bool.
4986         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4987         (tui_make_visible, tui_make_invisible)
4988         (tui_win_info::make_visible)
4989         (tui_source_window_base::make_visible, make_all_visible)
4990         (tui_make_all_visible, tui_make_all_invisible): Update.
4991         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4992         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4993         bool.
4994         (struct tui_win_info, struct tui_source_window_base)
4995         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4996         * tui/tui-data.c (tui_init_generic_part): Update.
4997
4998 2019-06-25  Tom Tromey  <tom@tromey.com>
4999
5000         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5001         (tui_source_window_base::make_visible): New methods.
5002         (make_all_visible): Make method call.
5003         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5004         (struct tui_source_window_base, struct tui_cmd_window): Override
5005         make_visible.
5006         (tui_win_is_source_type): Don't declare.
5007         * tui/tui-data.c (tui_win_is_source_type): Remove.
5008
5009 2019-06-25  Tom Tromey  <tom@tromey.com>
5010
5011         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5012         NULL check.
5013
5014 2019-06-25  Tom Tromey  <tom@tromey.com>
5015
5016         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5017         Inline constructor.  Add initializers for members.
5018         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5019         constructors; now inline in class.
5020
5021 2019-06-25  Tom Tromey  <tom@tromey.com>
5022
5023         * tui/tui-regs.c (tui_show_registers): Update.
5024         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5025         bool.
5026         * tui/tui-data.c (tui_data_window::clear_detail)
5027         (tui_data_window): Update.
5028
5029 2019-06-25  Tom Tromey  <tom@tromey.com>
5030
5031         * tui/tui-windata.c (tui_display_all_data)
5032         (tui_display_data_from_line, tui_display_data_from)
5033         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5034         Update.
5035         * tui/tui-regs.c (tui_last_regs_line_no)
5036         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5037         (tui_show_registers, tui_show_register_group)
5038         (tui_display_registers_from, tui_display_reg_element_at_line)
5039         (tui_display_registers_from_line, tui_check_register_values)
5040         (tui_reg_next, tui_reg_prev): Update.
5041         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5042         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5043         tui_data_window.
5044         (struct tui_win_info) <detail>: Remove.  Add new fields from
5045         tui_data_info.
5046         (TUI_DATA_WIN): Add cast.
5047         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5048         (~tui_data_window): Simplify.
5049
5050 2019-06-25  Tom Tromey  <tom@tromey.com>
5051
5052         * tui/tui-layout.c (show_source_disasm_command)
5053         (show_source_or_disasm_and_command): Update.
5054         * tui/tui-io.c (update_cmdwin_start_line)
5055         (tui_redisplay_readline): Update.
5056         * tui/tui-data.h (struct tui_command_info): Remove.
5057         (struct tui_win_info) <detail>: Remove command_info member.
5058         (struct tui_data_window) <start_line>: New member, from
5059         tui_command_info.
5060         (TUI_CMD_WIN): Add casts.
5061
5062 2019-06-25  Tom Tromey  <tom@tromey.com>
5063
5064         * tui/tui-winsource.c (tui_update_source_window)
5065         (tui_refill_source_window)
5066         (tui_source_window_base::do_scroll_horizontal)
5067         (tui_update_breakpoint_info, tui_set_exec_info_content)
5068         (tui_show_exec_info_content, tui_erase_exec_info_content)
5069         (tui_clear_exec_info_content): Update.
5070         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5071         Update.
5072         * tui/tui-win.c (make_invisible_and_set_new_height)
5073         (make_visible_with_new_height): Update.
5074         * tui/tui-source.c (tui_set_source_content)
5075         (tui_show_symtab_source): Update.
5076         * tui/tui-layout.c (extract_display_start_addr)
5077         (show_source_disasm_command, show_data)
5078         (make_source_or_disasm_window)
5079         (show_source_or_disasm_and_command): Update.
5080         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5081         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5082         "gdbarch".
5083         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5084         to tui_source_window_base.
5085         (struct tui_win_info) <detail>: Remove source_info member.
5086         (struct tui_source_window_base) <has_locator>: Inline.
5087         Move contents from tui_source_info; rename has_locator member to
5088         m_has_locator.
5089         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5090         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5091         header file.
5092         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5093         Simplify.
5094         (tui_free_all_source_wins_content): Cast to
5095         tui_source_window_base.
5096
5097 2019-06-25  Tom Tromey  <tom@tromey.com>
5098
5099         * tui/tui-win.c (make_invisible_and_set_new_height)
5100         (make_visible_with_new_height): Call has_locator method.
5101         * tui/tui-layout.c (show_source_disasm_command, show_data)
5102         (show_source_or_disasm_and_command): Update for bool change.
5103         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5104         (tui_win_info) <has_locator>: New method.
5105         (struct tui_source_window_base) <has_locator>: New method.
5106         (tui_win_has_locator): Don't declare.
5107         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5108         from tui_win_has_locator.
5109         (tui_source_window_base): Use false, not FALSE.
5110
5111 2019-06-25  Tom Tromey  <tom@tromey.com>
5112
5113         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5114         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5115         clear_detail method directly.
5116         (tui_clear_win_detail): Remove.
5117
5118 2019-06-25  Tom Tromey  <tom@tromey.com>
5119
5120         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5121         "this", not TUI_DISASM_WIN.
5122
5123 2019-06-25  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5126         declare.
5127         * tui/tui-winsource.c
5128         (tui_source_window_base::do_scroll_horizontal): Rename from
5129         tui_horizontal_source_scroll.
5130         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5131         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5132         from tui_vertical_data_scroll.
5133         * tui/tui-win.h (tui_scroll): Don't declare.
5134         * tui/tui-win.c (tui_win_info::forward_scroll)
5135         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5136         (tui_win_info::right_scroll): Rename and update.
5137         (tui_scroll_forward_command, tui_scroll_backward_command)
5138         (tui_scroll_left_command, tui_scroll_right_command): Update.
5139         (tui_scroll): Remove.
5140         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5141         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5142         from tui_vertical_source_scroll.
5143         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5144         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5145         from tui_vertical_disassem_scroll.
5146         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5147         do_scroll_horizontal>: New methods.
5148         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5149         Likewise.
5150         (struct tui_source_window_base): Add do_scroll_horizontal.
5151         (struct tui_source_window, struct tui_disasm_window): Add
5152         do_scroll_vertical.
5153         (struct tui_data_window, struct tui_cmd_window): Add
5154         do_scroll_horizontal and do_scroll_vertical.
5155         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5156
5157 2019-06-25  Tom Tromey  <tom@tromey.com>
5158
5159         * tui/tui-data.h (struct tui_source_window_base): New struct.
5160         (struct tui_source_window): Derive from tui_source_window_base.
5161         (struct tui_disasm_window): New struct.
5162         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5163         from tui_source_window::clear_detail.
5164         (tui_source_window_base): Rename from tui_source_window.
5165         (~tui_source_window_base): Rename from ~tui_source_window.
5166         (tui_alloc_win_info): Create a tui_disasm_window.
5167
5168 2019-06-25  Tom Tromey  <tom@tromey.com>
5169
5170         * tui/tui-data.h (struct tui_source_window)
5171         (struct tui_data_window): Declare destructors.
5172         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5173         destructors.
5174         (tui_win_info): Simplify.
5175
5176 2019-06-25  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-winsource.c (tui_display_main)
5179         (tui_update_source_windows_with_addr)
5180         (tui_update_all_breakpoint_info): Update.
5181         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5182         (new_height_ok, parse_scrolling_args): Update.
5183         * tui/tui-stack.c (tui_show_frame_info): Update.
5184         * tui/tui-data.h (struct tui_list): Remove.
5185         (tui_source_windows): Return a reference to a std::vector.
5186         * tui/tui-data.c (source_windows): Now a std::vector.
5187         (tui_source_windows): Change return type.
5188         (tui_clear_source_windows): Rewrite.
5189         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5190         (tui_free_all_source_wins_content): Rewrite.
5191
5192 2019-06-25  Tom Tromey  <tom@tromey.com>
5193
5194         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5195         (struct tui_data_window, struct tui_cmd_window): Declare
5196         clear_detail method.
5197         * tui/tui-data.c (tui_source_window::clear_detail)
5198         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5199         methods.
5200         (tui_clear_win_detail): Simplify.
5201
5202 2019-06-25  Tom Tromey  <tom@tromey.com>
5203
5204         * tui/tui-layout.c (make_source_window, make_disasm_window)
5205         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5206         Return the new window.
5207         (show_source_disasm_command, show_data)
5208         (show_source_or_disasm_and_command): Update.
5209
5210 2019-06-25  Tom Tromey  <tom@tromey.com>
5211
5212         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5213         parameter.  Return the new window.
5214         (show_source_disasm_command): Update and remove NULL check.
5215         (show_source_or_disasm_and_command): Update.
5216
5217 2019-06-25  Tom Tromey  <tom@tromey.com>
5218
5219         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5220
5221 2019-06-25  Tom Tromey  <tom@tromey.com>
5222
5223         * tui/tui-data.h (struct tui_win_info): Make constructor
5224         protected.  Make destructor virtual.  Add initializers.
5225         (tui_source_window, tui_data_window, tui_cmd_window): New
5226         classes.
5227         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5228         constructor.  Add "type" parameter.
5229         (tui_source_window, tui_data_window, tui_cmd_window): New
5230         constructors.
5231         (tui_alloc_win_info): Instantiate the appropriate subclass.
5232
5233 2019-06-25  Tom Tromey  <tom@tromey.com>
5234
5235         * tui/tui-win.c (tui_resize_all): Use delete.
5236         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5237         destructor.
5238         (tui_free_window): Don't declare.
5239         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5240         Update.
5241
5242 2019-06-25  Tom Tromey  <tom@tromey.com>
5243
5244         * tui/tui-data.h (struct tui_win_info): Add constructor.
5245         * tui/tui-data.c (tui_alloc_win_info): Use new.
5246         (tui_free_window): Use delete.
5247
5248 2019-06-22  Tom Tromey  <tom@tromey.com>
5249
5250         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5251         declare.
5252         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5253
5254 2019-06-22  Tom Tromey  <tom@tromey.com>
5255
5256         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5257         declare.
5258         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5259
5260 2019-06-22  Tom de Vries  <tdevries@suse.de>
5261
5262         * dwarf2read.c (create_addrmap_from_aranges)
5263         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5264         instead of '%zu'.
5265
5266 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5267
5268         * dwarf2read.h (dwarf2_section_info_def): Remove.
5269         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5270         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5271         std::vector<dwarf2_section_info>.
5272         (struct dwo_file) <~dwo_file>: Remove.
5273         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5274         types field.
5275         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5276         (dwarf2_read_debug_names): Likewise.
5277         (create_debug_types_hash_table): Change parameter type to
5278         array_view, adjust code accordingly.
5279         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5280         (partial_die_info::fixup): Likewise.
5281         (determine_prefix): Likewise.
5282         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5283
5284 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5285
5286         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5287         gdb_bfd_ref_ptr.
5288         <~dwo_file>: Remove call to gdb_bfd_unref.
5289         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5290         gdb_bfd_ref_ptr::get.
5291
5292 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5293
5294         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5295         type to htab_up.
5296         * dwarf2read.c (struct dwo_file): Initialize fields.
5297         <~dwo_file>: New.
5298         (free_dwo_file): Remove, move content to ~dwo_file.
5299         (struct dwo_file_deleter): Remove.
5300         (dwo_file_up>: Remove custom deleter.
5301         (free_dwo_files): Remove.
5302         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5303         dwo_files.
5304         (process_skeletonless_type_units): Call unique_ptr::get.
5305         (allocate_dwo_file_hash_table): Add deleter to created hash
5306         table.  Change return type to htab_up.
5307         (lookup_dwo_file_slot): Don't memset dwo_file, call
5308         unique_ptr::get.
5309         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5310         (create_dwo_unit_in_dwp_v2): Likewise.
5311         (open_and_init_dwo_file): Likewise.
5312         (free_dwo_file_from_slot): Remove.
5313
5314 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5315
5316         * dwarf2read.h (struct dwarf2_section_info) <readin,
5317         is_virtual>: Change type to bool.
5318         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5319         true instead of 1.
5320
5321 2019-06-19  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-data.h (tui_init_content_element): Don't declare.
5324
5325 2019-06-19  Tom Tromey  <tom@tromey.com>
5326
5327         * tui/tui-data.h (tui_init_win_info): Don't declare.
5328
5329 2019-06-19  Tom de Vries  <tdevries@suse.de>
5330
5331         * dwarf2read.h (abstract_to_concrete): Change type to
5332         std::unordered_map<sect_offset, std::vector<sect_offset>,
5333         gdb::hash_enum<sect_offset>>.
5334
5335 2019-06-19  Tom Tromey  <tromey@adacore.com>
5336
5337         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5338         EVAL_AVOID_SIDE_EFFECTS specially.
5339
5340 2019-06-19  Tom Tromey  <tromey@adacore.com>
5341
5342         * source-cache.c (highlighter): New global.
5343         (source_cache::get_source_lines): Create a highlighter on demand.
5344
5345 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5346
5347         * defs.h (deprecated_interactive_hook): Delete declaration.
5348         * interps.c (clear_interpreter_hooks): Remove use of
5349         deprecated_interactive_hook.
5350         * top.c (deprecated_interactive_hook): Delete definition.
5351         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5352
5353 2019-06-18  Tom de Vries  <tdevries@suse.de>
5354
5355         PR gdb/24515
5356         * dwarf2read.h (abstract_to_concrete): Change type from
5357         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5358         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5359         * dwarf2read.c (read_variable): Update.
5360         (dwarf2_fetch_die_loc_sect_off): Update.
5361
5362 2019-06-17  Tom de Vries  <tdevries@suse.de>
5363
5364         PR gdb/24617
5365         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5366         accessing parent[parent_len - 1].
5367
5368 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5369
5370         PR gdb/24364
5371         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5372         call dtrace_process_dof with NULL dof.
5373
5374 2019-06-16  Tom de Vries  <tdevries@suse.de>
5375
5376         PR gdb/24445
5377         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5378
5379 2019-06-16  Tom Tromey  <tom@tromey.com>
5380
5381         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5382         (make_all_visible): Use address of member.
5383
5384 2019-06-16  Tom Tromey  <tom@tromey.com>
5385
5386         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5387         (tui_free_window, free_content, free_content_elements): Remove
5388         unnecessary cast.
5389         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5390         cast.
5391         * tui/tui-regs.c (tui_show_register_group)
5392         (tui_display_registers_from, tui_display_reg_element_at_line):
5393         Remove unnecessary cast.
5394
5395 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5396
5397         * linux-nat.c (normal_mask): Delete.
5398         (_initialize_linux_nat): Don't initialise normal_mask.
5399
5400 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5401
5402         PR gdb/24445
5403         * dwarf-index-write.h (write_psymtabs_to_index): Add
5404         dwz_basename parameter.
5405         * dwarf-index-write.c (write_gdbindex): Move file writing to
5406         write_gdbindex_1.  Change return type void.
5407         (assert_file_size): Move up, remove filename parameter.
5408         (write_gdbindex_1): New function.
5409         (write_debug_names): Change return type to void, call
5410         assert_file_size.
5411         (struct index_wip_file): New struct.
5412         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5413         file logic to index_wip_file.  Write index for dwz file if
5414         needed.
5415         (save_gdb_index_command): Pass basename of dwz file, if present.
5416         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5417         build-id of dwz file, if present.
5418         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5419         (dwarf2_get_dwz_file): Likewise.
5420         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5421         (dwarf2_get_dwz_file): Likewise.
5422
5423 2019-06-16  Tom Tromey  <tom@tromey.com>
5424
5425         * coffread.c (process_coff_symbol): Use xstrdup.
5426         * value.c (create_internalvar): Use xstrdup.
5427
5428 2019-06-16  Tom Tromey  <tom@tromey.com>
5429
5430         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5431         * breakpoint.c (stopin_command, stopat_command)
5432         (until_break_command, decode_location_default): Remove unnecessary
5433         cast.
5434         * utils.c (subset_compare): Remove unnecessary cast.
5435         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5436         cast.
5437         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5438         cast.
5439         * infcmd.c (path_command): Remove unnecessary cast.
5440         * coffread.c (decode_type): Remove unnecessary cast.
5441         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5442         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5443         * tui/tui-stack.c (tui_show_locator_content)
5444         (tui_show_frame_info): Remove unnecessary cast.
5445         * tui/tui-win.c (tui_scroll_forward_command)
5446         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5447         (parse_scrolling_args): Remove unnecessary cast.
5448         * tui/tui-data.c (init_win_info, tui_del_window)
5449         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5450         (free_content_elements): Remove unnecessary cast.
5451         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5452         unnecessary cast.
5453         * tui/tui-source.c (tui_set_source_content)
5454         (tui_vertical_source_scroll): Remove unnecessary cast.
5455         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5456         cast.
5457         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5458         * tui/tui-regs.c (tui_display_registers_from)
5459         (tui_display_register): Remove unnecessary cast.
5460         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5461         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5462         (make_visible): Remove unnecessary cast.
5463         * tui/tui-winsource.c (tui_erase_source_content)
5464         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5465         unnecessary cast.
5466         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5467         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5468         * stabsread.c (read_type, read_array_type, read_range_type):
5469         Remove unnecessary cast.
5470         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5471         (parse_symbol, parse_type, upgrade_type, parse_external)
5472         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5473         unnecessary cast.
5474         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5475
5476 2019-06-16  Tom Tromey  <tom@tromey.com>
5477
5478         * tui/tui-data.c (tui_alloc_generic_win_info)
5479         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5480         checks.
5481
5482 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5483             Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * f-typeprint.c (f_print_type): Don't return early for not
5486         associated or not allocated types.
5487         (f_type_print_varspec_suffix): Add print_rank parameter and print
5488         ranks of array types in case they dangling.
5489         (f_type_print_base): Add print_rank parameter.
5490
5491 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5492
5493         * NEWS: Mention new MI commands.
5494         * break-catch-throw.c (enum exception_event_kind): Move to
5495         breakpoint.h.
5496         (print_mention_exception_catchpoint): Output text as a single
5497         message.
5498         (catch_exception_command_1): Rename to...
5499         (catch_exception_event): ...this, make non-static, update header
5500         command, and change some parameter types.
5501         (catch_catch_command): Update for changes to
5502         catch_exception_command_1.
5503         (catch_throw_command): Likewise.
5504         (catch_rethrow_command): Likewise.
5505         * breakpoint.c (enum exception_event_kind): Delete.
5506         * breakpoint.h (enum exception_event_kind): Moved here from
5507         break-catch-throw.c.
5508         (catch_exception_event): Declare.
5509         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5510         (mi_cmd_catch_throw): New function.
5511         (mi_cmd_catch_rethrow): New function.
5512         (mi_cmd_catch_catch): New function.
5513         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5514         'catch-catch' entries.
5515         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5516         (mi_cmd_catch_rethrow): Declare.
5517         (mi_cmd_catch_catch): Declare.
5518
5519 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5520
5521         * annotate.c (annotate_source_line): Change return type to void,
5522         update implementation to match.
5523         * annotate.h (annotate_source_line): Change return type to void,
5524         update header comment.
5525         * stack.c (print_frame_info): Don't change what frame information
5526         is printed based on whether annotations are on or not.
5527
5528 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5529
5530         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5531         (annotate_source): Make static.
5532         (annotate_source_line): Moved from source.c and renamed from
5533         identify_source_line.  Update the return type.
5534         * annotate.h (annotate_source): Delete declaration.
5535         (annotate_source_line): Declaration moved from source.h, and
5536         renamed from identify_source_line.  Return type updated.
5537         * source.c (identify_source_line): Moved to annotate.c and renamed
5538         to annotate_source_line.
5539         (info_line_command): Remove check of annotation_level.
5540         * source.h (identify_source_line): Move declaration to annotate.h
5541         and rename to annotate_source_line.
5542         * stack.c: Add 'annotate.h' include.
5543         (print_frame_info): Remove check of annotation_level before
5544         calling annotate_source_line.
5545
5546 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5547
5548         * source-cache.c (source_cache::get_plain_source_lines): Use
5549         open_source_file_with_line_charpos instead of just
5550         open_source_file, remove call to find_source_lines.
5551         (source_cache::get_source_lines): Likewise.
5552         * source.c (find_source_lines): Make static.
5553         (get_filename_and_charpos): Renamed into...
5554         (open_source_file_with_line_charpos): ..this along with changes to
5555         return a scoped_fd, and some other minor clean ups.
5556         (identify_source_line): Use open_source_file_with_line_charpos.
5557         (search_command_helper): Use open_source_file_with_line_charpos
5558         instead of just open_source_file, remove call to
5559         find_source_lines.
5560         * source.h (open_source_file_with_line_charpos): Declare new
5561         function.
5562         (find_source_lines): Delete declaration.
5563
5564 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5565
5566         * source.c (get_filename_and_charpos): Remove fullname
5567         parameter.
5568         (identify_source_line): Update call to get_filename_and_charpos.
5569
5570 2019-06-14  Tom Tromey  <tromey@adacore.com>
5571
5572         PR gdb/24502:
5573         * ui-style.h (skip_ansi_escape): Update comment.
5574         * ui-file.h (class no_terminal_escape_file): New class.
5575         * ui-file.c (no_terminal_escape_file::write)
5576         (no_terminal_escape_file::puts): New methods.
5577         * cli/cli-logging.c (handle_redirections): Use
5578         no_terminal_escape_file.
5579
5580 2019-06-14  Tom Tromey  <tromey@adacore.com>
5581
5582         * NEWS: Move convenience variable news above Python news.
5583
5584 2019-06-14  Tom Tromey  <tom@tromey.com>
5585
5586         * gnulib: Move directory to top-level.
5587         * configure.ac: Don't configure gnulib.
5588         * configure: Rebuild.
5589         * common/common-defs.h: Use new path to gnulib.
5590         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5591         (GNULIB_H): Remove.
5592         (INCGNU): Look in new gnulib location.
5593         (HFILES_NO_SRCDIR): Remove gnulib files.
5594         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5595         (generated_files): Remove GNULIB_H.
5596         ($(LIBGNU), all-lib): Remove targets.
5597         (distclean): Don't mention GNULIB_BUILDDIR.
5598         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5599
5600 2019-06-14  Tom Tromey  <tromey@adacore.com>
5601
5602         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5603         Warn if symbol file does not provide any symbols.
5604
5605 2019-06-14  Tom Tromey  <tromey@adacore.com>
5606
5607         * source.c (find_and_open_source): Respect basenames_may_differ.
5608
5609 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5610
5611         * annotate.c (annotate_breakpoints_invalid): Make use of
5612         scoped_restore_terminal_state.
5613         (annotate_frames_invalid): Likewise.
5614
5615 2019-06-14  Tom Tromey  <tromey@adacore.com>
5616
5617         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5618         allow assignment to an internalvar.
5619
5620 2019-06-14  Tom Tromey  <tromey@adacore.com>
5621
5622         * ada-lex.l: Allow "_" in attribute names.
5623
5624 2019-06-14  Tom Tromey  <tromey@adacore.com>
5625
5626         PR gdb/24653:
5627         * regcache.c (registers_changed): Don't call alloca.
5628         * top.c (execute_command): Don't call alloca.
5629
5630 2019-06-13  Pedro Alves  <palves@redhat.com>
5631
5632         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5633         'expression'.  When parsing an expression, error out if there's
5634         junk after "unlimited".
5635         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5636         (do_set_command): Adjust calls to is_unlimited_literal.
5637
5638 2019-06-13  Pedro Alves  <palves@redhat.com>
5639
5640         * compile/compile.c (make_compile_options_def_group): Add braces
5641         around array_view initializer.
5642         * thread.c (make_thread_apply_all_options_def_group)
5643         (make_thread_apply_all_options_def_group): Likewise.
5644
5645 2019-06-13  Pedro Alves  <palves@redhat.com>
5646
5647         * NEWS (New commands): Mention "maint test-options
5648         require-delimiter", "maint test-options unknown-is-error", "maint
5649         test-options unknown-is-operand" and "maint show
5650         test-options-completion-result".
5651         (New command options, command completion): New section.
5652         (Completion improvements): New section.
5653         Mention that you can abbreviate "unlimited".
5654
5655 2019-06-13  Pedro Alves  <palves@redhat.com>
5656
5657         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5658         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5659         * unittests/cli-utils-selftests.c (test_parse_flags)
5660         (test_parse_flags_qcs): Delete.
5661         (test_cli_utils): Don't call deleted functions.
5662
5663 2019-06-13  Pedro Alves  <palves@redhat.com>
5664
5665         * thread.c: Include "cli/cli-option.h".
5666         (tp_array_compar_ascending): Global.
5667         (tp_array_compar): Delete function.
5668         (tp_array_compar_ascending, tp_array_compar_descending): New
5669         functions.
5670         (ascending_option_def, qcs_flag_option_def)
5671         (thr_qcs_flags_option_defs)
5672         (make_thread_apply_all_options_def_group)
5673         (make_thread_apply_options_def_group): New.
5674         (thread_apply_all_command): Use gdb::option::process_options.
5675         (thread_apply_command_completer)
5676         (thread_apply_all_command_completer): New.
5677         (thread_apply_command): Use gdb::option::process_options.
5678         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5679         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5680         to generate help text of "thread apply".  Adjust "taas"'s help.
5681         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5682         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5683
5684 2019-06-13  Pedro Alves  <palves@redhat.com>
5685
5686         * thread.c (thread_apply_command): Check for invalid TID with
5687         isdigit instead of !isalpha.
5688
5689 2019-06-13  Pedro Alves  <palves@redhat.com>
5690
5691         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5692         (validate_flags_qcs): New.
5693         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5694         (validate_flags_qcs): Declare.
5695         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5696         (make_frame_apply_options_def_group): New.
5697         (frame_apply_command_count): Process options with
5698         gdb::option::process_options.
5699         (frame_apply_completer): New.
5700         (frame_apply_level_completer, frame_apply_all_completer)
5701         (frame_apply_completer): New.
5702         (_initialize_stack): Update help of "frame apply", "frame apply
5703         level", "frame apply all" and "faas" to mention supported options
5704         and install command completers.
5705         * stack.h (frame_apply_all_completer): Declare.
5706         * thread.c: Include "stack.h".
5707         (tfaas_command): Add "--".
5708         (_initialize_thread): Update help "tfaas" to mention supported
5709         options and install command completer.
5710
5711 2019-06-13  Pedro Alves  <palves@redhat.com>
5712
5713         * completer.c (complete_nested_command_line): New.
5714         (gdb_completion_word_break_characters_throw): Add assertion.
5715         * completer.h (complete_nested_command_line): Declare.
5716
5717 2019-06-13  Pedro Alves  <palves@redhat.com>
5718
5719         * stack.c (parse_backtrace_qualifiers): New.
5720         (backtrace_command): Use it.
5721         (backtrace_command_completer): Complete on qualifiers.
5722
5723 2019-06-13  Pedro Alves  <palves@redhat.com>
5724
5725         * frame.c: Include "cli/cli-option.h.
5726         (user_set_backtrace_options): New.
5727         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5728         Delete.
5729         (get_prev_frame): Adjust.
5730         (boolean_option_def, uinteger_option_def)
5731         (set_backtrace_option_defs): New.
5732         (_initialize_frame): Adjust and use
5733         gdb::option::add_setshow_cmds_for_options to install "set
5734         backtrace past-main" and "set backtrace past-entry".
5735         * frame.h: Include "cli/cli-option.h".
5736         (struct frame_print_options): Forward declare.
5737         (print_frame_arguments_all, print_frame_arguments_scalars)
5738         (print_frame_arguments_none): Declare.
5739         (print_entry_values): Delete declaration.
5740         (struct frame_print_options, user_frame_print_options): New.
5741         (struct set_backtrace_options): New.
5742         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5743         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5744         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5745         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5746         (list_args_or_locals): Add frame_print_options parameter.
5747         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5748         * python/py-framefilter.c (enumerate_args): Pass down
5749         USER_FRAME_PRINT_OPTIONS.
5750         * stack.c: Include "cli/cli-option.h".
5751         (print_frame_arguments_all, print_frame_arguments_scalars)
5752         (print_frame_arguments_none): Declare.
5753         (print_raw_frame_arguments, print_entry_values): Delete.
5754         (user_frame_print_options): New.
5755         (boolean_option_def, enum_option_def, frame_print_option_defs):
5756         New.
5757         (struct backtrace_cmd_options): New.
5758         (bt_flag_option_def): New.
5759         (backtrace_command_option_defs): New.
5760         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5761         (print_frame_arg, read_frame_arg, print_frame_args)
5762         (print_frame_info, print_frame): Add frame_print_options parameter
5763         and use it.
5764         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5765         (backtrace_command_1): Add frame_print_options and
5766         backtrace_cmd_options parameters and use them.
5767         (make_backtrace_options_def_group): New.
5768         (backtrace_command): Process command options with
5769         gdb::option::process_options.
5770         (backtrace_command_completer): New.
5771         (_initialize_stack): Extend "backtrace"'s help to mention
5772         supported options.  Install completer for "backtrace".
5773         Install some settings commands with add_setshow_cmds_for_options.
5774
5775 2019-06-13  Pedro Alves  <palves@redhat.com>
5776
5777         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5778         and that "set/show print raw frame-arguments" are now deprecated.
5779
5780         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5781         command.
5782         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5783         * stack.c (_initialize_stack): Install "set/show print
5784         raw-frame-arguments", and deprecate "set/show print raw
5785         frame-arguments".
5786         * valprint.c (_initialize_valprint): Deprecate "set/show print
5787         raw".
5788
5789 2019-06-13  Pedro Alves  <palves@redhat.com>
5790
5791         * compile/compile.c (struct compile_options): New.
5792         (compile_flag_option_def, compile_command_option_defs)
5793         (make_compile_options_def_group): New.
5794         (compile_file_command): Handle options with
5795         gdb::option::process_options.
5796         (compile_file_command_completer): New function.
5797         (compile_code_command): Handle options with
5798         gdb::option::process_options.
5799         (compile_code_command_completer): New function.
5800         (_initialize_compiler): Install completers for "compile code" and
5801         "compile file".  Mention available options in "compile code" and
5802         "compile code"'s help.
5803         * completer.c (advance_to_completion_word): New, factored out from
5804         ...
5805         (advance_to_expression_complete_word_point): ... this.
5806         (advance_to_filename_complete_word_point): New.
5807         * completer.h (advance_to_filename_complete_word_point): New
5808         declaration.
5809
5810 2019-06-13  Pedro Alves  <palves@redhat.com>
5811
5812         * compile/compile.c: Include "cli/cli-option.h".
5813         (compile_print_value): Scope data pointer is now a
5814         value_print_options pointer; adjust.
5815         (compile_print_command): Process options.  Scope data pointer is
5816         now a value_print_options pointer; adjust.
5817         (_initialize_compile): Update "compile print"'s help to include
5818         supported options.  Install a completer for "compile print".
5819         * cp-valprint.c (show_vtblprint, show_objectprint)
5820         (show_static_field_print): Delete.
5821         (_initialize_cp_valprint): Don't install "set print
5822         static-members", "set print vtbl", "set print object" here.
5823         * printcmd.c: Include "cli/cli-option.h" and
5824         "common/gdb_optional.h".
5825         (print_command_parse_format): Rework to fill in a
5826         value_print_options instead of a format_data.
5827         (print_value): Change parameter type from format_data pointer to
5828         value_print_options reference.  Adjust.
5829         (print_command_1): Process options.  Adjust to pass down a
5830         value_print_options.
5831         (print_command_completer): New.
5832         (_initialize_printcmd): Install print_command_completer as
5833         handle_brkchars completer for the "print" command.  Update
5834         "print"'s help to include supported options.
5835         * valprint.c: Include "cli/cli-option.h".
5836         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5837         here from cp-valprint.c.
5838         (boolean_option_def, uinteger_option_def)
5839         (value_print_option_defs, make_value_print_options_def_group):
5840         New.  Use gdb::option::add_setshow_cmds_for_options to install
5841         "set print elements", "set print null-stop", "set print repeats",
5842         "set print pretty", "set print union", "set print array", "set
5843         print address", "set print symbol", "set print array-indexes".
5844         * valprint.h: Include <string> and "cli/cli-option.h".
5845         (make_value_print_options_def_group): Declare.
5846         (print_value): Change parameter type from format_data pointer to
5847         value_print_options reference.
5848         (print_command_completer): Declare.
5849
5850 2019-06-13  Pedro Alves  <palves@redhat.com>
5851
5852         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5853         (COMMON_SFILES): Add maint-test-settings.c.
5854         * cli/cli-decode.c (boolean_enums): New global, factored out from
5855         ...
5856         (add_setshow_boolean_cmd): ... here.
5857         * cli/cli-decode.h (boolean_enums): Declare.
5858         * cli/cli-option.c: New file.
5859         * cli/cli-option.h: New file.
5860         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5861         factored out from ...
5862         (parse_cli_boolean_value(const char *)): ... this.
5863         (is_unlimited_literal): Change parameter type to pointer to
5864         pointer.  Adjust and advance ARG pointer.
5865         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5866         (parse_cli_var_enum): New, factored out from ...
5867         (do_set_command): ... this.  Adjust.
5868         * cli/cli-setshow.h (parse_cli_boolean_value)
5869         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5870         (parse_cli_var_enum): Declare.
5871         * cli/cli-utils.c: Include "cli/cli-option.h".
5872         (get_ulongest): New.
5873         * cli/cli-utils.h (get_ulongest): Declare.
5874         (check_for_argument): New overloads.
5875         * maint-test-options.c: New file.
5876
5877 2019-06-13  Pedro Alves  <palves@redhat.com>
5878
5879         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5880         parse a range if "-" is at the end of the string.
5881
5882 2019-06-13  Pedro Alves  <palves@redhat.com>
5883
5884         * cli/cli-setshow.c (parse_auto_binary_operation)
5885         (parse_cli_boolean_value): Don't allow "o".
5886
5887 2019-06-13  Pedro Alves  <palves@redhat.com>
5888
5889         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5890         * NEWS: Mention maint test-settings KIND.
5891         * maint-test-settings.c: New file.
5892
5893 2019-06-13  Pedro Alves  <palves@redhat.com>
5894
5895         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5896         completer.
5897         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5898         "set" completers.
5899
5900 2019-06-13  Pedro Alves  <palves@redhat.com>
5901
5902         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5903         after item.
5904
5905 2019-06-13  Pedro Alves  <palves@redhat.com>
5906
5907         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5908
5909 2019-06-13  Pedro Alves <palves@redhat.com>
5910
5911         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5912         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5913         call.
5914         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5915         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5916         calls.
5917         (check_for_argument): Skip spaces after argument.
5918
5919 2019-06-13  Pedro Alves  <palves@redhat.com>
5920
5921         * thread.c (thread_apply_command): Adjust TID parsing.
5922         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5923         detected before end of string.
5924         (tid_is_in_list): Error out if LIST is invalid.
5925
5926 2019-06-13  Pedro Alves  <palves@redhat.com>
5927
5928         * completer.c (complete_line_internal_1): Rewind completion word
5929         point.
5930         (completion_tracker::advance_custom_word_point_by): Change
5931         parameter type to int.
5932         * completer.h (completion_tracker::advance_custom_word_point_by):
5933         Likewise.
5934
5935 2019-06-13  Pedro Alves  <palves@redhat.com>
5936
5937         * completer.c (advance_to_completion_word): Handle delimiters.
5938
5939 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5940
5941         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5942
5943 2019-06-11  Tom Tromey  <tom@tromey.com>
5944
5945         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5946         (xmalloc_failed): Move to alloc.c.
5947         * alloc.c: New file.
5948         * Makefile.in (COMMON_SFILES): Add alloc.c.
5949
5950 2019-06-11  Tom Tromey  <tom@tromey.com>
5951
5952         * nat/linux-waitpid.c: Don't include server.h.
5953         (linux_debug): Remove.
5954         (my_waitpid): Update.
5955
5956 2019-06-11  Tom Tromey  <tromey@adacore.com>
5957
5958         * infcall.c (_initialize_infcall): Remove trailing newline from
5959         help.
5960         * user-regs.c (_initialize_user_regs): Remove trailing newline
5961         from help.
5962         * typeprint.c (_initialize_typeprint): Remove trailing newline
5963         from help.
5964         * reverse.c (_initialize_reverse): Remove trailing newlines from
5965         help.
5966         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5967         from help.
5968         * language.c (add_set_language_command): Remove trailing newline
5969         from help.
5970         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5971         help.
5972         * disasm.c (_initialize_disasm): Remove trailing newline from
5973         help.
5974         * top.c (init_main): Remove trailing newline from help.
5975         * interps.c (_initialize_interpreter): Remove trailing newline
5976         from help.
5977         * btrace.c (_initialize_btrace): Remove trailing newlines from
5978         help.
5979         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5980         from help.
5981         * python/python.c (_initialize_python): Remove trailing newline
5982         from help.
5983         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5984         help.
5985         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5986         from help.  Reformat some text.
5987         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5988         from help.
5989         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5990         newline from help.
5991
5992 2019-06-11  Tom Tromey  <tromey@adacore.com>
5993
5994         * darwin-nat.c (darwin_decode_exception_message)
5995         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5996
5997 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * valops.c (value_slice): Check for not allocated or not
6000         associated values.
6001
6002 2019-06-10  Tom de Vries  <tdevries@suse.de>
6003
6004         PR gdb/24618
6005         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6006         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6007         invalid.
6008
6009 2019-06-10  Tom de Vries  <tdevries@suse.de>
6010
6011         PR gdb/24611
6012         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6013         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6014
6015 2019-06-10  Tom de Vries  <tdevries@suse.de>
6016
6017         PR symtab/24545
6018         * symtab.c (struct demangled_name_entry): Add language field.
6019         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6020         static minimal symbol".  Set and use language field.
6021
6022 2019-06-10  Tom Tromey  <tromey@adacore.com>
6023
6024         * ada-lang.c (_initialize_ada_language): Update help text.
6025
6026 2019-06-10  Tom Tromey  <tromey@adacore.com>
6027
6028         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6029         with a newline.
6030         * guile/guile.c (handle_boot_error): Don't end warning with a
6031         newline.
6032         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6033         warning with a newline.
6034         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6035         newline.
6036         (s12z_frame_cache): Likewise.
6037         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6038         a newline.
6039         * solib-svr4.c (disable_probes_interface): Don't end warning with
6040         a newline.
6041         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6042         newline.
6043         * python/python.c (do_finish_initialization): Don't end warning
6044         with a newline.
6045
6046 2019-06-10  Tom Tromey  <tom@tromey.com>
6047
6048         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6049         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6050         gdbpy_enter.
6051
6052 2019-06-10  Tom Tromey  <tromey@adacore.com>
6053
6054         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6055         data.
6056         (elf_new_init): Don't call stabsread_new_init.
6057         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6058         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6059         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6060
6061 2019-06-10  Tom de Vries  <tdevries@suse.de>
6062
6063         PR symtab/16264
6064         PR symtab/24517
6065         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6066
6067 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6068
6069         * source.c (find_and_open_source): Also rewrite relative file
6070         names.
6071
6072 2019-04-26  Amos Bird  <amosbird@gmail.com>
6073
6074         * annotate.c (annotate_thread_exited): Add "thread-exited"
6075         annotation.
6076
6077 2019-06-06  Tom Tromey  <tromey@adacore.com>
6078
6079         * maint.h (class scoped_command_stats): Use
6080         DISABLE_COPY_AND_ASSIGN.
6081         <print_time>: New method.
6082         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6083         print_time.
6084         (scoped_command_stats::print_time): New method.
6085
6086 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6087
6088         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6089         instructions of lengths 6 or 8 bytes.
6090
6091 2019-06-04  Pedro Alves  <palves@redhat.com>
6092
6093         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6094
6095         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6096         * breakpoint.c (condition_completer): Likewise.
6097         * cli/cli-dump.c (scan_expression): Likewise.
6098         * common/filestuff.c (mkdir_recursive): Likewise.
6099         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6100         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6101         (gdb_abspath): Likewise.
6102         * compile/compile-cplus-types.c
6103         (compile_cplus_instance::decl_name): Likewise.
6104         * completer.c (complete_explicit_location):
6105         (signal_completer, reg_or_group_completer_1): Likewise.
6106         * cp-support.c (cp_remove_params_if_any): Likewise.
6107         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6108         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6109         * infcmd.c (strip_bg_char): Likewise.
6110         * linespec.c (copy_token_string): Likewise.
6111         * mi/mi-main.c (output_cores): Likewise.
6112         * psymtab.c (psymtab_search_name):
6113         * symfile.c (test_set_ext_lang_command): Likewise.
6114         * target.c (target_fileio_read_stralloc): Likewise.
6115         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6116         * value.c (complete_internalvar): Likewise.
6117
6118 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6119
6120         Add objfile property to gdb.Type.
6121         * NEWS: Mention Python API addition.
6122         * python/py-type.c (typy_get_objfile): New method.
6123
6124 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6125
6126         * NEWS: Mention the new set|show style [title|highlight].
6127         Mention changes to "show style", "help" and "apropos".
6128
6129 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6130
6131         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6132         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6133         instead of print_help_for_command.
6134         (print_doc_of_command): New function.
6135         (help_list): Add 'apropos -v word' suggestion.
6136         (print_help_for_command): Style the command name using title style.
6137         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6138         (_initialize_cli_cmds): Describe -v in apropos_command help.
6139
6140 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6141
6142         * cli/cli-style.h (cli_style_option): Add name in constructor,
6143         add m_name class member, add constructor with intensity,
6144         add name class function.
6145         (cli_style_option::add_setshow_commands): Remove name argument.
6146         (highlight_style, title_style): New styles.
6147         * cli/cli-style.c (do_show): New function that shows a style
6148         characteristic styling the style name with itself.
6149         (set_style_name): New function.
6150         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6151         Update all callers according to the changes in cli/cli-style.h.
6152         * utils.h (fputs_highlighted): New function.
6153         * utils.c (fputs_highlighted): Likewise.
6154
6155 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6156
6157         * NEWS: Mention new pipe command and new convenience variables.
6158
6159 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6160
6161         * cli/cli-cmds.c (pipe_command): New function.
6162         (_initialize_cli_cmds): Call add_com for pipe_command.
6163         Define | as an alias for pipe.
6164         (exit_status_set_internal_vars): New function.
6165         (shell_escape): Call exit_status_set_internal_vars.
6166         cli/cli-decode.c (find_command_name_length): Recognize | as
6167         a single character command.
6168
6169 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6170
6171         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6172         top.c (execute_command_to_ui_file): New function, mostly a copy
6173         of execute_command_to_string.
6174         (execute_command_to_string): Implement by calling
6175         execute_command_to_ui_file.
6176
6177 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6178
6179         * top.h (saved_command_line): Remove declaration.
6180         * top.c (previous_saved_command_line, previous_repeat_arguments):
6181         New variables.
6182         (saved_command_line): Make static, define together with other
6183         'repeat variables'.
6184         (dont_repeat): Clear repeat_arguments.
6185         (repeat_previous, get_saved_command_line, save_command_line):
6186         New functions.
6187         (gdb_init): Initialize saved_command_line
6188         and previous_saved_command_line.
6189         * main.c (captured_main_1): Remove saved_command_line initialization.
6190         * event-top.c (handle_line_of_input): Update to use
6191         the new 'repeat' related functions instead of direct access to
6192         saved_command_line.
6193         * command.h (repeat_previous, get_saved_command_line,
6194         save_command_line): New declarations.
6195         (dont_repeat): Add comment.
6196
6197 2019-05-30  Tom Tromey  <tromey@adacore.com>
6198
6199         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6200         Fix comment.
6201         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6202
6203 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6204
6205         PR cli/24587
6206         * completer.c (complete): Initialize variable word.
6207
6208 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6209
6210         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6211         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6212         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6213         'body' is NULL to the outter 'if', protecting the '!is_define'
6214         situation as well.
6215
6216 2019-05-29  Tom Tromey  <tromey@adacore.com>
6217
6218         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6219         (dwarf_unknown): New function.
6220         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6221         (dwarf_type_encoding_name): Use dwarf_unknown.
6222
6223 2019-05-29  Tom Tromey  <tromey@adacore.com>
6224
6225         PR c++/20020:
6226         * cp-valprint.c (cp_print_value_fields): Call
6227         cp_print_static_field inside "try".
6228
6229 2019-05-29  Tom Tromey  <tromey@adacore.com>
6230
6231         * inflow.c (struct terminal_info): Add default operator=.
6232         * configure: Rebuild.
6233         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6234         -Wdeprecated-copy-dtor, -Wredundant-move.
6235
6236 2019-05-29  Tom Tromey  <tromey@adacore.com>
6237
6238         * NEWS: Add entry.
6239         * infcmd.c (print_return_value_1): Handle finish_print
6240         option.
6241         (show_print_finish): New function.
6242         (_initialize_infcmd): Add "set/show print finish" commands.
6243         * valprint.c (user_print_options): Initialize new member.
6244         * valprint.h (struct value_print_options) <finish_print>: New
6245         member.
6246
6247 2019-05-28  Tom Tromey  <tromey@adacore.com>
6248
6249         * ada-lang.c (ada_remove_Xbn_suffix)
6250         (find_old_style_renaming_symbol)
6251         (parse_old_style_renaming): Remove.
6252         (ada_find_renaming_symbol): Don't call
6253         find_old_style_renaming_symbol.
6254         (ada_is_renaming_symbol): Rename from
6255         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6256         bool.  Now static.
6257         (ada_read_var_value): Update and simplify.
6258         * ada-exp.y (write_var_or_type): Remove old code.
6259
6260 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6261
6262         * event-top.c: Remove include comment.
6263         * inflow.c (class scoped_ignore_sigttou): Move from here...
6264         * inflow.h (class scoped_ignore_sigttou): ...to here.
6265         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6266         * top.c:  Remove include comment.
6267
6268 2019-05-27  Tom Tromey  <tom@tromey.com>
6269
6270         * NEWS: Fix typo.
6271
6272 2019-05-22  Tom Tromey  <tromey@adacore.com>
6273
6274         * target.c (target_follow_exec): Constify parameter.
6275         * target-delegates.c: Rebuild.
6276         * remote.c (remote_target::follow_exec): Constify parameter.
6277         * infrun.c (follow_exec): Constify parameter.
6278         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6279         (target_follow_exec): Likewise.
6280
6281 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6282
6283         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6284         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6285
6286 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6287
6288         * NEWS: Add debugredirect and testsuite sections.
6289
6290 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6291
6292         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6293         target descriptions using exclusively floating point register name
6294         aliases.
6295
6296 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6297
6298         PR gdb/18644:
6299         * f-lang.c (build_fortran_types): Handle the case where
6300         gdbarch_floatformat_for_type returns a nullptr.
6301
6302 2019-05-21  Tom de Vries  <tdevries@suse.de>
6303
6304         PR cli/24587
6305         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6306
6307 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6308
6309         PR gdb/18644:
6310         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6311         16-byte floats.
6312         * i386-tdep.c (i386_floatformat_for_type): Use
6313         floatformats_ia64_quad for the 16-byte floating point component
6314         within a fortran 32-byte complex number.
6315
6316 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6319         delete default constructor.
6320         (find_partial_die): Update to return const struct.
6321         (partial_die_parent_scope): Move variable declaration into scope
6322         of its use and change its type to auto.
6323         (guess_partial_die_structure_name): Likewise.
6324         (partial_die_info::fixup): Likewise.
6325
6326 2019-05-17  Tom Tromey  <tromey@adacore.com>
6327
6328         * source.c (find_and_open_source): Remove cast.
6329
6330 2019-05-17  Tom Tromey  <tromey@adacore.com>
6331
6332         * annotate.c (annotate_source): Make "filename" const.
6333         * annotate.h (annotate_source): Use const.
6334
6335 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6336
6337         * disasm.c (set_disassembler_options): Send errors to stderr.
6338
6339 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6340
6341         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6342         (cli_interp_base::set_logging): Check debug_redirect.
6343         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6344         * cli/cli-logging.c (debug_redirect): Add static variable.
6345         (pop_output_files): Add default param.
6346         (handle_redirections): Print debug setting.
6347         (show_logging_command): Likewise.
6348         (_initialize_cli_logging): Add debugredirect command.
6349         * interps.c (current_interp_set_logging): Add debug_redirect
6350         parameter.
6351         * interps.h (set_logging): Add debug_redirect parameter.
6352         (current_interp_set_logging): Likewise.
6353         * mi/mi-common.h: Likewise.
6354         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6355
6356 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6357             Tom Tromey  <tromey@adacore.com>
6358
6359         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6360         directly.
6361         * cli/cli-interp.h (make_logging_output): Remove declaration.
6362         * cli/cli-logging.c (make_logging_output): Remove function.
6363         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6364         directly.
6365         * ui-file.c (tee_file::tee_file): Remove bools.
6366         (tee_file::~tee_file): Remove deletes.
6367         * ui-file.h (tee_file): Remove bools.
6368
6369 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6370
6371         * mi/mi-cmds.h (mi_cmd_complete): New function.
6372         * mi/mi-main.c (mi_cmd_complete): Likewise.
6373         * mi/mi-cmds.c: Define new MI command -complete.
6374         * NEWS: Mention new -complete command.
6375
6376 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6377
6378         * completer.h (complete): New function.
6379         * completer.c (complete): Likewise.
6380         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6381         function defined in completer.h.
6382
6383 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6384
6385         * MAINTAINERS (Write After Approval): Add myself.
6386
6387 2019-05-17  Tom de Vries  <tdevries@suse.de>
6388
6389         PR gdb/24094
6390         * dwarf2read.c (struct cu_partial_die_info): New struct.
6391         (find_partial_die): Return cu_partial_die_info.
6392         (partial_die_parent_scope, guess_partial_die_structure_name)
6393         (partial_die_info::fixup): Handle new return type of find_partial_die.
6394
6395 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6396
6397         PR breakpoints/24541
6398         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6399         "std::string", simplifying the algorithm.
6400
6401 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6402
6403         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6404         (stap_static_probe_ops::get_probes): Likewise.
6405
6406 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6407
6408         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6409         '-')" and "else if".
6410         (stap_parse_single_operand): Join checks for
6411         "gdbarch_stap_parse_special_token_p" and
6412         "gdbarch_stap_parse_special_token" in the same "if" statement.
6413         Invert check when verifying for operation on register
6414         displacement.
6415
6416 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6417
6418         * stap-probe.c (stap_get_opcode): Update comment.
6419         (stap_get_expected_argument_type): Likewise.
6420         (handle_stap_probe): Likewise.
6421
6422 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6423
6424         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6425         return type to 'bool'.  Adjust comment.  Use 'bool' when
6426         appropriate.
6427         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6428         * stap-probe.c (stap_parse_argument_1): Likewise.
6429         (stap_is_operator): Likewise.
6430         (stap_is_generic_prefix): Likewise.
6431         (stap_is_register_prefix): Likewise.
6432         (stap_is_register_indirection_prefix): Likewise.
6433         (stap_is_integer_prefix): Likewise.
6434         (stap_generic_check_suffix): Likewise.
6435         (stap_check_integer_suffix): Likewise.
6436         (stap_check_register_suffix): Likewise.
6437         (stap_check_register_indirection_suffix): Likewise.
6438         (stap_parse_register_operand): Likewise.
6439         (stap_parse_single_operand): Likewise.
6440         (stap_parse_argument_1): Likewise.
6441         (stap_probe::get_argument_count): Likewise.
6442         (stap_is_operator): Likewise.
6443
6444 2019-05-16  Tom Tromey  <tromey@adacore.com>
6445
6446         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6447         keyword to foreach.
6448
6449 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6450
6451         * linux-thread-db.c (try_thread_db_load_1): Change return type
6452         to bool.
6453         (try_thread_db_load): Likewise.
6454         (try_thread_db_load_from_pdir_1): Likewise.
6455         (try_thread_db_load_from_pdir): Likewise.
6456         (try_thread_db_load_from_sdir): Likewise.
6457         (try_thread_db_load_from_dir): Likewise.
6458         (thread_db_load_search): Likewise.
6459         (has_libpthread): Likewise.
6460         (thread_db_load): Likewise.
6461
6462 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6463
6464         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6465         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6466         NULL, and complain/return if that's the case.
6467
6468 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6469
6470         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6471         (advance, posn, abstract_read_memory): New functions.
6472         [struct mem_read_abstraction]: New struct.
6473         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6474
6475 2019-05-14  Tom Tromey  <tromey@adacore.com>
6476
6477         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6478         value is not lval_memory.
6479
6480 2019-05-14  Tom Tromey  <tromey@adacore.com>
6481
6482         * solib.c (info_sharedlibrary_command): Style the file name.
6483
6484 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6485
6486         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6487         (aarch64_vnv_type): Likewise.
6488         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6489         * common/tdesc.c: Likewise.
6490         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6491         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6492         * features/aarch64-fpu.xml: Add ieee half view.
6493         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6494         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6495         * gdbtypes.h (struct builtin_type): Likewise.
6496         (struct objfile_type): Likewise.
6497
6498 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6499
6500         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6501         typo.
6502         * location.h (string_to_event_location): Likewise.
6503
6504 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6505
6506         GDB 8.3 released.
6507
6508 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6509
6510         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6511         New variable declaration.
6512         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6513         New variable.
6514         (print_one_breakpoint): Use ui_out::test_flags and new global
6515         variable to compute use_fixed_output.
6516         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6517         Remove.
6518         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6519         (mi_multi_location_breakpoint_output_fixed): Remove.
6520         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6521         new variable.
6522         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6523         fix_multi_location_breakpoint_output flag if version >= 3.
6524         * ui-out.h (enum ui_out_flag)
6525         <fix_multi_location_breakpoint_output>: New enumerator.
6526
6527 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6528
6529         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6530
6531 2019-05-10  Tom Tromey  <tromey@adacore.com>
6532
6533         * ada-lang.c (catch_ada_completer): New function.
6534         (_initialize_ada_language): Use it.
6535
6536 2019-05-10  Tom Tromey  <tromey@adacore.com>
6537
6538         * thread.c (print_thread_info): Make "requested_threads" const.
6539         * gdbthread.h (print_thread_info): Make "requested_threads"
6540         const.
6541         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6542         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6543
6544 2019-05-08  Tom Tromey  <tom@tromey.com>
6545
6546         * gdbtypes.c (objfile_type_data): Change type.
6547         (objfile_type, _initialize_gdbtypes): Update.
6548
6549 2019-05-08  Tom Tromey  <tom@tromey.com>
6550
6551         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6552         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6553         (_initialize_dwarf2_frame): Update.
6554
6555 2019-05-08  Tom Tromey  <tom@tromey.com>
6556
6557         * objc-lang.c (objc_objfile_data): Change type.
6558         (find_methods): Update.
6559         (_initialize_objc_lang): Remove.
6560
6561 2019-05-08  Tom Tromey  <tom@tromey.com>
6562
6563         * stabsread.c (rs6000_builtin_type_data): Change type.
6564         (rs6000_builtin_type, _initialize_stabsread): Update.
6565
6566 2019-05-08  Tom Tromey  <tom@tromey.com>
6567
6568         * mips-tdep.c (mips_pdr_data): Remove.
6569         (_initialize_mips_tdep): Update.
6570
6571 2019-05-08  Tom Tromey  <tom@tromey.com>
6572
6573         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6574         (hppa_init_objfile_priv_data, read_unwind_info)
6575         (find_unwind_entry, _initialize_hppa_tdep): Update.
6576
6577 2019-05-08  Tom Tromey  <tom@tromey.com>
6578
6579         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6580         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6581         on obstack.
6582         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6583
6584 2019-05-08  Tom Tromey  <tom@tromey.com>
6585
6586         * mdebugread.c (basic_type_data): Change type.
6587         (basic_type, _initialize_mdebugread): Update.
6588
6589 2019-05-08  Tom Tromey  <tom@tromey.com>
6590
6591         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6592
6593 2019-05-08  Tom Tromey  <tom@tromey.com>
6594
6595         * nto-tdep.c (nto_inferior_data_reg): Change type.
6596         (nto_inferior_data): Update.
6597         (nto_inferior_data_cleanup, nto_new_inferior_data)
6598         (_initialize_nto_tdep): Remove.
6599         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6600
6601 2019-05-08  Tom Tromey  <tom@tromey.com>
6602
6603         * ada-lang.c (struct ada_inferior_data): Add initializers.
6604         (ada_inferior_data): Change type.
6605         (ada_inferior_data_cleanup): Remove.
6606         (get_ada_inferior_data, ada_inferior_exit)
6607         (struct ada_pspace_data): Add initializers, destructor.
6608         (ada_pspace_data_handle): Change type.
6609         (get_ada_pspace_data): Update.
6610         (ada_pspace_data_cleanup): Remove.
6611
6612 2019-05-08  Tom Tromey  <tom@tromey.com>
6613
6614         * coffread.c (struct coff_symfile_info): Add initializers.
6615         (coff_objfile_data_key): Move lower.  Change type.
6616         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6617         Update.
6618         (coff_free_info): Remove.
6619
6620 2019-05-08  Tom Tromey  <tom@tromey.com>
6621
6622         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6623         (fbsd_pspace_data_handle): Move lower.  Change type.
6624         (get_fbsd_pspace_data): Update.
6625         (fbsd_pspace_data_cleanup): Remove.
6626         (_initialize_fbsd_tdep): Update.
6627
6628 2019-05-08  Tom Tromey  <tom@tromey.com>
6629
6630         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6631         (get_ada_tasks_pspace_data): Update.
6632         (ada_tasks_pspace_data_cleanup): Remove.
6633         (_initialize_tasks): Update.
6634         (ada_tasks_inferior_data_handle): Change type.
6635         (get_ada_tasks_inferior_data): Update.
6636         (ada_tasks_inferior_data_cleanup): Remove.
6637         (struct ada_tasks_pspace_data): Add initializers.
6638
6639 2019-05-08  Tom Tromey  <tom@tromey.com>
6640
6641         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6642         * symfile-debug.c (debug_sym_get_probes): Change type.
6643         * stap-probe.c (handle_stap_probe):
6644         (stap_static_probe_ops::get_probes): Change type.
6645         * probe.h (class static_probe_ops) <get_probes>: Change type.
6646         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6647         (parse_probes_in_pspace): Update.
6648         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6649         Update.
6650         (any_static_probe_ops::get_probes): Change type.
6651         * elfread.c (elfread_data): New typedef.
6652         (probe_key): Change type.
6653         (elf_get_probes): Likewise.  Update.
6654         (probe_key_free): Remove.
6655         (_initialize_elfread): Update.
6656         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6657         Change type.
6658         (dtrace_process_dof_probe, dtrace_process_dof)
6659         (dtrace_static_probe_ops::get_probe): Change type.
6660
6661 2019-05-08  Tom Tromey  <tom@tromey.com>
6662
6663         * xcoffread.c (struct xcoff_symfile_info): Rename from
6664         coff_symfile_info.  Add initializers.
6665         (xcoff_objfile_data_key): Move lower.  Change type.
6666         (XCOFF_DATA): Rewrite.
6667         (xcoff_free_info): Remove.
6668         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6669         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6670         (xcoff_initial_scan): Update.
6671
6672 2019-05-08  Tom Tromey  <tom@tromey.com>
6673
6674         * solib-svr4.c (struct svr4_info): Add initializers and
6675         destructor.
6676         <probes_table>: Now an htab_up.
6677         (solib_svr4_pspace_data): Change type.
6678         (free_probes_table): Simplify.
6679         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6680         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6681         (probes_table_remove_objfile_probes, register_solib_event_probe)
6682         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6683         (_initialize_svr4_solib): Update.
6684
6685 2019-05-08  Tom Tromey  <tom@tromey.com>
6686
6687         * remote.c (remote_pspace_data): Change type.
6688         (remote_pspace_data_cleanup): Remove.
6689         (get_remote_exec_file, set_pspace_remote_exec_file)
6690         (_initialize_remote): Update.
6691
6692 2019-05-08  Tom Tromey  <tom@tromey.com>
6693
6694         * breakpoint.c (breakpoint_objfile_key): Change type.
6695         (get_breakpoint_objfile_data): Update.
6696         (free_breakpoint_objfile_data): Remove.
6697         (_initialize_breakpoint): Update.
6698
6699 2019-05-08  Tom Tromey  <tom@tromey.com>
6700
6701         * linux-tdep.c (struct linux_info): Add initializers.
6702         (linux_inferior_data): Move.  Change type.
6703         (invalidate_linux_cache_inf): Update.
6704         (linux_inferior_data_cleanup): Remove.
6705         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6706
6707 2019-05-08  Tom Tromey  <tom@tromey.com>
6708
6709         * auxv.c (auxv_inferior_data): Move.  Change type.
6710         (auxv_inferior_data_cleanup): Remove.
6711         (invalidate_auxv_cache_inf): Rewrite.
6712         (get_auxv_inferior_data, _initialize_auxv): Update.
6713
6714 2019-05-08  Tom Tromey  <tom@tromey.com>
6715
6716         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6717         (symfile_debug_objfile_data_key): Change type.
6718         (symfile_debug_installed, debug_qf_has_symbols)
6719         (debug_qf_find_last_source_symtab)
6720         (debug_qf_forget_cached_source_info)
6721         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6722         (debug_qf_print_stats, debug_qf_dump)
6723         (debug_qf_expand_symtabs_for_function)
6724         (debug_qf_expand_all_symtabs)
6725         (debug_qf_expand_symtabs_with_fullname)
6726         (debug_qf_map_matching_symbols)
6727         (debug_qf_expand_symtabs_matching)
6728         (debug_qf_find_pc_sect_compunit_symtab)
6729         (debug_qf_map_symbol_filenames)
6730         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6731         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6732         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6733         (debug_sym_read_linetable, debug_sym_relocate): Update.
6734         (symfile_debug_free_objfile): Remove.
6735         (install_symfile_debug_logging, _initialize_symfile_debug):
6736         Update.
6737
6738 2019-05-08  Tom Tromey  <tom@tromey.com>
6739
6740         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6741         allocate_on_obstack.
6742         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6743         (get_dwarf2_per_objfile): Update.
6744         (set_dwarf2_per_objfile): Remove.
6745         (dwarf2_has_info, dwarf2_get_section_info): Update.
6746         (dwarf2_free_objfile): Remove.
6747         (_initialize_dwarf2_read): Update.
6748
6749 2019-05-08  Tom Tromey  <tom@tromey.com>
6750
6751         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6752         initializers.
6753         <unsupported_script_warning_printed,
6754         script_not_found_warning_printed>: Now bool.
6755         (auto_load_pspace_data): Change type.
6756         (~auto_load_pspace_info): Rename from
6757         auto_load_pspace_data_cleanup.
6758         (get_auto_load_pspace_data, init_loaded_scripts_info)
6759         (clear_section_scripts, maybe_print_unsupported_script_warning)
6760         (maybe_print_script_not_found_warning, _initialize_auto_load):
6761         Update.
6762
6763 2019-05-08  Tom Tromey  <tom@tromey.com>
6764
6765         * objfiles.c (objfile_pspace_info): Add destructor and
6766         initializers.
6767         (objfiles_pspace_data): Change type.
6768         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6769         (get_objfile_pspace_data): Update.
6770         (objfiles_bfd_data): Change type.
6771         (get_objfile_bfd_data): Update.
6772         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6773
6774 2019-05-08  Tom Tromey  <tom@tromey.com>
6775
6776         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6777         Change type.
6778         (get_catch_syscall_inferior_data): Update.
6779         (catch_syscall_inferior_data_cleanup): Remove.
6780         (_initialize_break_catch_syscall): Update.
6781
6782 2019-05-08  Tom Tromey  <tom@tromey.com>
6783
6784         * inflow.c (struct terminal_info): Add destructor and
6785         initializers.
6786         (inflow_inferior_data): Change type.
6787         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6788         (get_inflow_inferior_data, inflow_inferior_exit)
6789         (swap_terminal_info, _initialize_inflow): Update.
6790
6791 2019-05-08  Tom Tromey  <tom@tromey.com>
6792
6793         * target-dcache.c (target_dcache_cleanup): Remove.
6794         (target_dcache_aspace_key): Change type.
6795         (target_dcache_init_p, target_dcache_invalidate)
6796         (target_dcache_get, target_dcache_get_or_init)
6797         (_initialize_target_dcache): Update.
6798         * dcache.h (struct dcache_deleter): New.
6799
6800 2019-05-08  Tom Tromey  <tom@tromey.com>
6801
6802         * symtab.c (struct symbol_cache): Add destructor and
6803         initializers.
6804         (symbol_cache_key): Move.  Change type.
6805         (make_symbol_cache, free_symbol_cache): Remove.
6806         (get_symbol_cache): Update.
6807         (symbol_cache_cleanup): Remove.
6808         (ALL_PSPACES, symbol_cache_flush)
6809         (maintenance_print_symbol_cache)
6810         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6811         Update.
6812
6813 2019-05-08  Tom Tromey  <tom@tromey.com>
6814
6815         * symtab.c (struct main_info): Add destructor and initializers.
6816         (main_progspace_key): Move.  Change type.
6817         (get_main_info): Update.
6818         (main_info_cleanup): Remove.
6819         (_initialize_symtab): Update.
6820
6821 2019-05-08  Tom Tromey  <tom@tromey.com>
6822
6823         * registry.h (DECLARE_REGISTRY): Define the _key class.
6824
6825 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6826
6827         * NEWS: Merge two 'New commands' sections.
6828
6829 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6830
6831         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6832         parameter and use Ada language definition instead.
6833         (ada_val_print_ptr): Remove unused language parameter.
6834         (ada_val_print_num): Remove language parameter and use Ada language
6835         definition instead.
6836         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6837         parameter.
6838         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6839         parameter and use Ada language definition instead.
6840         (ada_val_print_1): Update all ada_val_print_xxx calls.
6841         Remove language parameter.
6842         (ada_val_print): Update ada_val_print_1 call.
6843
6844 2019-05-08  Tom Tromey  <tromey@adacore.com>
6845
6846         * remote.c (remote_hw_watchpoint_limit)
6847         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6848         Now static.
6849
6850 2019-05-08  Tom Tromey  <tromey@adacore.com>
6851
6852         * maint.c (_initialize_maint_cmds): Move initialization code to
6853         remote.c.
6854         (watchdog, show_watchdog): Move to remote.c.
6855         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6856         "watchdog" static.
6857         (_initialize_remote): Move initialization code from maint.c.
6858         * defs.h (watchdog): Don't declare.
6859
6860 2019-05-08  Tom Tromey  <tromey@adacore.com>
6861
6862         * tui/tui-interp.c: Include main.h.
6863         * interps.c: Include main.h.
6864         * main.h (interpreter_p): Declare.
6865         * defs.h (interpreter_p): Don't declare.
6866
6867 2019-05-08  Tom Tromey  <tromey@adacore.com>
6868
6869         * dwarf2loc.c: Include dwarf2read.h.
6870         * defs.h (read_unsigned_leb128): Don't declare.
6871         * dwarf2read.h (read_unsigned_leb128): Declare.
6872
6873 2019-05-08  Tom Tromey  <tromey@adacore.com>
6874
6875         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6876         method.
6877
6878 2019-05-08  Tom Tromey  <tromey@adacore.com>
6879
6880         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6881         when no wrap column is set.
6882
6883 2019-05-08  Tom Tromey  <tromey@adacore.com>
6884
6885         * c-lang.c (c_get_string): Handle non-C-style arrays.
6886
6887 2019-05-08  Tom Tromey  <tromey@adacore.com>
6888
6889         * typeprint.c (print_offset_data::update): Print the bit offset,
6890         not the number of bits remaining.
6891
6892 2019-05-08  Tom Tromey  <tromey@adacore.com>
6893
6894         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6895         padding at end of comment.
6896
6897 2019-05-08  Tom Tromey  <tromey@adacore.com>
6898
6899         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6900         Compare main types.
6901
6902 2019-05-06  Tom Tromey  <tom@tromey.com>
6903
6904         * common/scoped_mmap.c: Include common-defs.h.
6905         * common/scoped_mmap.h: Don't include config.h.
6906
6907 2019-05-04  Tom Tromey  <tom@tromey.com>
6908
6909         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6910         (struct aarch64_call_info): Add initializers.
6911         <si>: Now a std::vector.
6912         (pass_on_stack, aarch64_push_dummy_call): Update.
6913
6914 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6915             Tom Tromey  <tom@tromey.com>
6916
6917         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6918         (ppc_threads): Now a std::vector.  Now static.
6919         (hwdebug_find_thread_points_by_tid)
6920         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6921         Update.
6922
6923 2019-05-04  Tom Tromey  <tom@tromey.com>
6924
6925         * arc-tdep.c (arc_tdesc_init): Return bool.
6926
6927 2019-05-04  Tom Tromey  <tom@tromey.com>
6928
6929         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6930         Use gdb_assert_not_reached.
6931
6932 2019-05-04  Tom Tromey  <tom@tromey.com>
6933
6934         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6935         "false".
6936
6937 2019-05-04  Tom Tromey  <tom@tromey.com>
6938
6939         * arc-tdep.c (arc_tdesc_init): Use bool.
6940
6941 2019-05-04  Tom Tromey  <tom@tromey.com>
6942
6943         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6944
6945 2019-05-04  Tom Tromey  <tom@tromey.com>
6946
6947         * cli/cli-cmds.c (valid_command_p): Return bool.
6948
6949 2019-05-04  Tom Tromey  <tom@tromey.com>
6950
6951         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6952         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6953
6954 2019-05-04  Raul Tambre  <raul@tambre.ee>
6955
6956         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6957         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6958         operator for comparison.
6959
6960 2019-05-04  Tom Tromey  <tom@tromey.com>
6961
6962         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6963         (lookup_partial_symbol, print_partial_symbols)
6964         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6965         (psymbol_compare): Update.
6966         (add_psymbol_to_bcache): Clear the entire psymbol.
6967         (maintenance_check_psymtabs): Update.
6968         * psympriv.h (struct partial_symbol): Don't derive from
6969         general_symbol_info.
6970         <obj_section, unrelocated_address, address,
6971         set_unrelocated_address>: Update.
6972         <ginfo>: New member.
6973         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6974         (debug_names::write_psymbols): Update.
6975
6976 2019-05-04  Tom de Vries  <tdevries@suse.de>
6977
6978         * contrib/cc-with-tweaks.sh: Support -n arg.
6979
6980 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6981
6982         * corelow.c (core_target::detach): Ensure frame cache and
6983         register caches are cleared.
6984         inferior.c (exit_inferior_1): Likewise.
6985
6986 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6987             Tom Tromey  <tom@tromey.com>
6988
6989         * dictionary.c (collate_pending_symbols_by_language): Remove
6990         "struct" from foreach.
6991         * symtab.c (lookup_global_symbol_from_objfile)
6992         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6993         foreach.
6994         * ser-tcp.c (net_open): Remove "struct" from foreach.
6995         * objfiles.c (objfile_relocate, objfile_rebase)
6996         (objfile_has_symbols): Remove "struct" from foreach.
6997         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6998         from foreach.
6999         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7000         foreach.
7001         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7002         "struct" from foreach.
7003         * ada-lang.c (create_excep_cond_exprs)
7004         (ada_exception_catchpoint_cond_string): Remove "struct" from
7005         foreach.
7006
7007 2019-05-03  Tom Tromey  <tromey@adacore.com>
7008
7009         * ada-exp.y (convert_char_literal): Check suffix of each
7010         enumerator.
7011
7012 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7013
7014         PR ada/21406:
7015         * ada-exp.y (yywrap): Don't define.
7016         * ada-lex.l (%option): Add noyywrap
7017         (yywrap): Remove.
7018
7019 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7020
7021         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7022         _WIN32_WINNT to the XP level, unless already defined to a higher
7023         level.
7024
7025         * unittests/parse-connection-spec-selftests.c:
7026         * ser-tcp.c:
7027         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7028         override.
7029
7030         * symfile.c (find_separate_debug_file): Remove colon from the
7031         drive spec of DOS/Windows file names of the target, so that the
7032         file name produced from DEBUGDIR and the target's directory will
7033         be valid on DOS/Windows systems.
7034
7035 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7036
7037         * rust-lang.c (val_print_struct): Handle printing structures
7038         containing strings.
7039
7040 2019-05-02  Tom Tromey  <tromey@adacore.com>
7041
7042         * valarith.c (_initialize_valarith): Remove.
7043
7044 2019-05-01  Tom Tromey  <tromey@adacore.com>
7045
7046         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7047         bitfields.
7048
7049 2019-05-01  Tom Tromey  <tromey@adacore.com>
7050
7051         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7052         for big-endian copies.
7053
7054 2019-04-30  Ali Tamur  <tamur@google.com>
7055         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7056         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7057         (read_3_bytes): New function.
7058
7059 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7060
7061         * windows-nat.c (main_thread_id): Delete.
7062         (handle_output_debug_string): Replace main_thread_id by
7063         current_event.dwThreadId.
7064         (fake_create_process): Likewise.
7065         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7066         Do not set main_thread_id.
7067         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7068         current_event.dwThreadId.
7069         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7070
7071 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7072
7073         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7074         Use current_event.dwThreadId instead of main_thread_id.
7075
7076 2019-04-30  Tom Tromey  <tromey@adacore.com>
7077
7078         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7079         (create_excep_cond_exprs): Iterate over program spaces.
7080         (ada_exception_catchpoint_cond_string): Examine all minimal
7081         symbols for exception types.
7082
7083 2019-04-30  Tom Tromey  <tromey@adacore.com>
7084
7085         PR c++/24470:
7086         * dwarf2read.c (process_structure_scope): Handle case where type
7087         has template parameters but no symbol was created.
7088
7089 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7090             Chris January  <chris.january@arm.com>
7091
7092         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7093         qualifier.
7094         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7095
7096 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7097
7098         * f-typeprint.c (f_print_type): Update rules for printing
7099         whitespace.
7100         (f_type_print_varspec_suffix): Likewise.
7101
7102 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7103             Chris January  <chris.january@arm.com>
7104
7105         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7106         function arguments.
7107
7108 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7109
7110         * f-lang.c (build_fortran_types): Change name of void type to
7111         lower case.
7112         * f-typeprint.c (f_type_print_base): Print the name of the void
7113         type, rather than a fixed string.
7114         * f-valprint.c (f_decorations): Use lower case void string.
7115
7116 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7117             Chris January  <chris.january@arm.com>
7118
7119         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7120         types for Fortran.
7121
7122 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7123             Chris January  <chris.january@arm.com>
7124             David Lecomber  <david.lecomber@arm.com>
7125
7126         * f-exp.y (BINOP_INTRINSIC): New token.
7127         (exp): New parser rule handling BINOP_INTRINSIC.
7128         (f77_keywords): Add new builtin procedures.
7129         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7130         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7131         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7132         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7133         (print_unop_subexp_f): New function.
7134         (print_binop_subexp_f): New function.
7135         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7136         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7137         (dump_subexp_body_f): Likewise.
7138         (operator_check_f): Likewise.
7139         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7140         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7141
7142 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7143
7144         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7145         UNOP_KIND.
7146         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7147         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7148         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7149         (operator_length_f): New fuction.
7150         (print_subexp_f): New function.
7151         (op_name_f): New function.
7152         (dump_subexp_body_f): New function.
7153         (operator_check_f): New function.
7154         (exp_descriptor_f): Replace standard expression handling functions
7155         with new functions.
7156         * gdb/fortran-operator.def: New file.
7157         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7158         * gdb/std-operator.def: Remove UNOP_KIND.
7159
7160 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7161
7162         * std-operator.def: Remove unbalanced, stray double quote
7163         character.
7164
7165 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7166             Chris January  <chris.january@arm.com>
7167             Daniel Everett  <daniel.everett@arm.com>
7168             Nick Forrington  <nick.forrington@arm.com>
7169             Richard Bunt  <richard.bunt@arm.com>
7170
7171         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7172         of depth when printing anonymous structs or unions.
7173         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7174         Don't print either the top-level value, or the children if the
7175         max-depth is exceeded.
7176         (ppscm_print_children): When printing the key of a map, allow one
7177         extra level of depth.
7178         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7179         print either the top-level value, or the children if the max-depth
7180         is exceeded.
7181         (print_children): When printing the key of a map, allow one extra
7182         level of depth.
7183         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7184         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7185         (user_print_options): Initialise max_depth field.
7186         (val_print_scalar_or_string_type_p): New function.
7187         (val_print): Check to see if the max depth has been reached.
7188         (val_print_check_max_depth): Define new function.
7189         (show_print_max_depth): New function.
7190         (_initialize_valprint): Add 'print max-depth' option.
7191         * valprint.h (struct value_print_options) <max_depth>: New field.
7192         (val_print_check_max_depth): Declare new function.
7193         * NEWS: Document new feature.
7194
7195 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         * ada-lang.c (ada_language_defn): Initialise new field.
7198         * c-lang.c (c_is_string_type_p): New function.
7199         (c_language_defn): Initialise new field.
7200         (cplus_language_defn): Initialise new field.
7201         (asm_language_defn): Initialise new field.
7202         (minimal_language_defn): Initialise new field.
7203         * c-lang.h (c_is_string_type_p): Declare new function.
7204         * d-lang.c (d_language_defn): Initialise new field.
7205         * f-lang.c (f_is_string_type_p): New function.
7206         (f_language_defn): Initialise new field.
7207         * go-lang.c (go_is_string_type_p): New function.
7208         (go_language_defn): Initialise new field.
7209         * language.c (default_is_string_type_p): New function.
7210         (unknown_language_defn): Initialise new field.
7211         (auto_language_defn): Initialise new field.
7212         * language.h (struct language_defn) <la_is_string_type_p>: New
7213         member variable.
7214         (default_is_string_type_p): Declare new function.
7215         * m2-lang.c (m2_language_defn): Initialise new field.
7216         * objc-lang.c (objc_language_defn): Initialise new field.
7217         * opencl-lang.c (opencl_language_defn): Initialise new field.
7218         * p-lang.c (pascal_is_string_type_p): New function.
7219         (pascal_language_defn): Initialise new field.
7220         * rust-lang.c (rust_is_string_type_p): New function.
7221         (rust_language_defn): Initialise new field.
7222
7223 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7224
7225         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7226         New field.
7227         * ada-lang.c (ada_language_defn): Initialise new field.
7228         * c-lang.c (c_language_defn): Likewise.
7229         (cplus_language_defn): Likewise.
7230         (asm_language_defn): Likewise.
7231         (minimal_language_defn): Likewise.
7232         * d-lang.c (d_language_defn): Likewise.
7233         * f-lang.c (f_language_defn): Likewise.
7234         * go-lang.c (go_language_defn): Likewise.
7235         * language.c (unknown_language_defn): Likewise.
7236         (auto_language_defn): Likewise.
7237         * m2-lang.c (m2_language_defn): Likewise.
7238         * objc-lang.c (objc_language_defn): Likewise.
7239         * opencl-lang.c (opencl_language_defn): Likewise.
7240         * p-lang.c (pascal_language_defn): Likewise.
7241         * rust-lang.c (rust_language_defn): Likewise.
7242
7243 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7244
7245         * ada-lang.c (ada_is_character_type): Change return type to bool.
7246         (ada_is_string_type): Likewise.
7247         * ada-lang.h (ada_is_character_type): Update declaration
7248         (ada_is_string_type): Likewise.
7249
7250 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7251
7252         Support style in 'frame|thread apply'
7253
7254         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7255         * record.c (record_start, record_stop): Update callers of
7256         execute_command_to_string with false.
7257         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7258         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7259         methods.
7260         (class string_file): New constructor with term_out parameter.
7261         Override methods term_out and can_emit_style_escape.  New member
7262         term_out.
7263         (class stdio_file): Override can_emit_style_escape.
7264         (class tee_file): Override term_out and can_emit_style_escape.
7265         * utils.h (can_emit_style_escape): Remove.
7266         * utils.c (can_emit_style_escape): Likewise.
7267         Update all callers of can_emit_style_escape (SOMESTREAM) to
7268         SOMESTREAM->can_emit_style_escape.
7269         * source-cache.c (source_cache::get_source_lines): Likewise.
7270         * stack.c (frame_apply_command_count): Call execute_command_to_string
7271         passing the term_out characteristic of the current gdb_stdout.
7272         * thread.c (thr_try_catch_cmd): Likewise.
7273         * top.c (execute_command_to_string): pass term_out parameter
7274         to construct the string_file for the command output.
7275         * ui-file.c (term_cli_styling): New function (most code moved
7276         from utils.c can_emit_style_escape).
7277         (string_file::string_file, string_file::can_emit_style_escape,
7278         stdio_file::can_emit_style_escape, tee_file::term_out,
7279         tee_file::can_emit_style_escape): New functions.
7280
7281 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7282
7283         * NEWS: Mention the new set|show may-call-functions.
7284         * infcall.c (may_call_functions_p): New variable.
7285         (show_may_call_functions_p): New function.
7286         (call_function_by_hand_dummy): Throws an error if not
7287         may-call-functions.
7288         (_initialize_infcall): Call add_setshow_boolean_cmd for
7289         may-call-functions.
7290
7291 2019-04-25  Keith Seitz  <keiths@redhat.com>
7292
7293         PR c++/24367
7294         * cp-support.c (inspect_type): Don't attempt substitutions
7295         of symbol with the same name.
7296
7297 2019-04-25  Tom Tromey  <tromey@adacore.com>
7298
7299         PR gdb/24475:
7300         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7301         static.
7302
7303 2019-04-25  Tom Tromey  <tromey@adacore.com>
7304
7305         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7306         rvalue reference.
7307         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7308         (gdb_xml_parser::parse): Use std::move.
7309         * python/python-internal.h (gdbpy_convert_exception): Take a const
7310         reference.
7311         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7312         std::move.
7313         * python/py-utils.c (gdbpy_convert_exception): Take a const
7314         reference.
7315         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7316         Use std::move.
7317         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7318         Use std::move.
7319         * mi/mi-main.c (mi_print_exception): Take a const reference.
7320         * main.c (handle_command_errors): Take a const reference.
7321         * linespec.c (parse_linespec): Use std::move.
7322         * infcall.c (run_inferior_call): Use std::move.
7323         (call_function_by_hand_dummy): Use std::move.
7324         * exec.c (try_open_exec_file): Use std::move.
7325         * exceptions.h (exception_print, exception_fprintf)
7326         (exception_print_same): Update.
7327         * exceptions.c (print_exception, exception_print)
7328         (exception_fprintf, exception_print_same): Change parameters to
7329         const reference.
7330         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7331         * common/new-op.c: Use std::move.
7332         * common/common-exceptions.h (struct gdb_exception): Add move
7333         constructor.
7334         (struct gdb_exception_error, struct gdb_exception_quit, struct
7335         gdb_quit_bad_alloc): Change constructor to move constructor.
7336         (throw_exception): Change parameter to rvalue reference.
7337         * common/common-exceptions.c (throw_exception): Take rvalue
7338         reference.
7339         * cli/cli-interp.c (safe_execute_command): Use std::move.
7340         * breakpoint.c (insert_bp_location, location_to_sals): Use
7341         std::move.
7342
7343 2019-04-25  Tom Tromey  <tromey@adacore.com>
7344
7345         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7346         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7347         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7348         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7349         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7350         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7351         guile/scm-value.c: Use unpack.
7352         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7353         gdbscm_gdb_exception.
7354         (gdbscm_throw_gdb_exception): Likewise.
7355         (struct gdbscm_gdb_exception): New.
7356         (unpack): New function.
7357         (gdbscm_wrap): Use unpack.
7358
7359 2019-04-25  Tom Tromey  <tromey@adacore.com>
7360
7361         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7362         (gdb_rl_callback_handler): Use std::move.
7363         * common/common-exceptions.h (struct gdb_exception): Add move
7364         assignment operator.
7365         (throw_exception_sjlj): Change "exception" to const reference.
7366         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7367         (throw_exception_sjlj): Change "exception" to const reference.
7368
7369 2019-04-25  Tom Tromey  <tromey@adacore.com>
7370
7371         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7372         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7373         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7374         Update.
7375         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7376         Update.
7377         * mi/mi-interp.c (mi_interp::exec): Update.
7378         * linespec.c (parse_linespec): Update.
7379         * infcall.c (run_inferior_call): Update.
7380         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7381         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7382         (gdbscm_lookup_global_symbol): Update.
7383         * guile/scm-param.c (gdbscm_parameter_value): Update.
7384         * guile/scm-frame.c (gdbscm_frame_read_register)
7385         (gdbscm_frame_read_var): Update.
7386         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7387         * exec.c (try_open_exec_file): Update.
7388         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7389         (gdb_rl_callback_handler): Update.
7390         * common/common-exceptions.h (exception_none): Don't declare.
7391         * common/common-exceptions.c (exception_none): Don't define.
7392         (struct catcher) <exception>: Update.
7393         * cli/cli-interp.c (safe_execute_command): Update.
7394         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7395
7396 2019-04-25  Ali Tamur  <tamur@google.com>
7397
7398         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7399         (read_attribute_value): Likewise.
7400         (dwarf2_read_addr_index): Update comment.
7401         (read_str_index): Add DW_FORM_strx.
7402         (dwarf2_string_attr): Likewise.
7403         (dwarf2_const_value_attr): Likewise.
7404         (dump_die_shallow): Likewise.
7405         (dwarf2_fetch_constant_bytes): Likewise.
7406         (skip_form_bytes): Likewise.
7407         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7408
7409 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7410
7411         PR corefiles/11608
7412         PR corefiles/18187
7413         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7414         OFFSET.  Verify if current mapping contains an ELF header.
7415         (linux_find_memory_regions_full): Adjust call to
7416         dump_mapping_p.
7417
7418 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7419             Kang Li <kanglictf@gmail.com>
7420
7421         PR gdb/21600
7422
7423         * dwarf2-frame.c (read_initial_length): Be consistent about using
7424         unsigned representation of length.
7425         (decode_frame_entry_1): Likewise.  Check for wraparound of
7426         end pointer as well as buffer overflow.
7427
7428 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7429
7430         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7431         "vq".
7432
7433 2019-04-24  Tom Tromey  <tromey@adacore.com>
7434
7435         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7436
7437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7438
7439         * s12z-tdep.c (s12z_unwind_pc): Delete.
7440         (s12z_unwind_sp): Delete.
7441         (s12z_gdbarch_init): Don't register deleted functions with
7442         gdbarch.
7443
7444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7445
7446         * rl78-tdep.c (rl78_unwind_sp): Delete.
7447         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7448
7449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7450
7451         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7452         (xstormy16_unwind_pc): Delete.
7453         (xstormy16_dummy_id): Delete.
7454         (xstormy16_gdbarch_init): Don't register deleted functions with
7455         gdbarch.
7456
7457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7458
7459         * vax-tdep.c (vax_unwind_pc): Delete.
7460         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7461
7462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7463
7464         * v850-tdep.c (v850_unwind_sp): Delete.
7465         (v850_unwind_pc): Delete.
7466         (v850_dummy_id): Delete.
7467         (v850_gdbarch_init): Don't register deleted functions with
7468         gdbarch.
7469
7470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7471
7472         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7473         (tilegx_unwind_pc): Delete.
7474         (tilegx_unwind_dummy_id): Delete.
7475         (tilegx_gdbarch_init): Don't register deleted functions with
7476         gdbarch.
7477
7478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7479
7480         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7481         (tic6x_dummy_id): Delete.
7482         (tic6x_gdbarch_init): Don't register deleted functions with
7483         gdbarch.
7484
7485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7486
7487         * sparc-tdep.c (sparc_unwind_pc): Delete.
7488         (sparc32_gdbarch_init): Don't register deleted function with
7489         gdbarch.
7490
7491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7492
7493         * sh-tdep.c (sh_unwind_sp): Delete.
7494         (sh_unwind_pc): Delete.
7495         (sh_dummy_id): Delete.
7496         (sh_gdbarch_init): Don't register deleted functions with
7497         gdbarch.
7498
7499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7500
7501         * score-tdep.c (score_unwind_sp): Delete.
7502         (score_unwind_pc): Delete.
7503         (score_dummy_id): Delete.
7504         (score_gdbarch_init): Don't register deleted functions with
7505         gdbarch.
7506
7507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7508
7509         * rx-tdep.c (rx_unwind_pc): Delete.
7510         (rx_unwind_sp): Delete.
7511         (rx_dummy_id): Delete.
7512         (rx_gdbarch_init): Don't register deleted functions with
7513         gdbarch.  Update comment.
7514
7515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7516
7517         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7518         (rs6000_dummy_id): Delete.
7519         (rs6000_gdbarch_init): Don't register deleted functions with
7520         gdbarch.
7521
7522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * or1k-tdep.c (or1k_dummy_id): Delete.
7525         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7526
7527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7528
7529         * nios2-tdep.c (nios2_dummy_id): Delete.
7530         (nios2_unwind_sp): Delete.
7531         (nios2_gdbarch_init): Don't register deleted functions with
7532         gdbarch.
7533
7534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * nds32-tdep.c (nds32_dummy_id): Delete.
7537         (nds32_unwind_pc): Delete.
7538         (nds32_unwind_sp): Delete.
7539         (nds32_gdbarch_init): Don't register deleted functions with
7540         gdbarch.
7541
7542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7543
7544         * msp430-tdep.c (msp430_unwind_pc): Delete.
7545         (msp430_unwind_sp): Delete.
7546         (msp430_dummy_id): Delete.
7547         (msp430_gdbarch_init): Don't register deleted functions with
7548         gdbarch.
7549
7550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7551
7552         * moxie-tdep.c (moxie_unwind_sp): Delete.
7553         (moxie_unwind_pc): Delete.
7554         (moxie_dummy_id): Delete.
7555         (moxie_gdbarch_init): Don't register deleted functions with
7556         gdbarch.
7557
7558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7559
7560         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7561         (mn10300_unwind_pc): Delete.
7562         (mn10300_unwind_sp): Delete.
7563         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7564         mn10300_unwind_sp.
7565         (mn10300_frame_unwind_init): Don't register deleted functions with
7566         gdbarch.
7567
7568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7569
7570         * mep-tdep.c (mep_unwind_pc): Delete.
7571         (mep_unwind_sp): Delete.
7572         (mep_dummy_id): Delete.
7573         (mep_gdbarch_init): Don't register deleted functions with
7574         gdbarch.
7575
7576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7577
7578         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7579         (m68hc11_unwind_sp): Delete.
7580         (m68hc11_gdbarch_init): Don't register deleted functions with
7581         gdbarch.
7582
7583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7584
7585         * m32r-tdep.c (m32r_unwind_sp): Delete.
7586         (m32r_unwind_pc): Delete.
7587         (m32r_dummy_id): Delete.
7588         (m32r_gdbarch_init): Don't register deleted functions with
7589         gdbarch.
7590
7591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7592
7593         * m32c-tdep.c (m32c_unwind_pc): Delete.
7594         (m32c_unwind_sp): Delete.
7595         (m32c_dummy_id): Delete.
7596         (m32c_gdbarch_init): Don't register deleted functions with
7597         gdbarch.
7598
7599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7600
7601         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7602         (lm32_unwind_pc): Delete.
7603         (lm32_dummy_id): Delete.
7604         (lm32_gdbarch_init): Don't register deleted functions with
7605         gdbarch.
7606
7607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7608
7609         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7610         (iq2000_unwind_pc): Delete.
7611         (iq2000_dummy_id): Delete.
7612         (iq2000_gdbarch_init): Don't register deleted functions with
7613         gdbarch.
7614
7615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7616
7617         * nds32-tdep.c (nds32_type_align): Delete.
7618         (nds32_push_dummy_call): Use type_align instead.
7619
7620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7621
7622         * arm-tdep.c (arm_type_align): Only handle vector override case.
7623         (arm_push_dummy_call): Use type_align.
7624         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7625
7626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7627
7628         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7629         case.
7630         (pass_on_stack): Use type_align.
7631         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7632         function.
7633
7634 2019-04-23  Tom Tromey  <tromey@adacore.com>
7635
7636         * dwarf2read.c (line_header::file_name_at): Remove unused
7637         overload.
7638
7639 2019-04-23  Tom de Vries  <tdevries@suse.de>
7640
7641         PR gdb/24438
7642         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7643         invocation.
7644
7645
7646 2019-03-27  Ali Tamur  <tamur@google.com>
7647
7648         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7649         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7650         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7651         (dwarf_expr_context::get_addr_index): Likewise
7652         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7653         (symbol_needs_eval_context::get_addr_index): Likewise
7654         (disassemble_dwarf_expression): Add DW_OP_addrx
7655         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7656         (read_cutu_die_from_dwo): Update comment
7657         (skip_one_die): Add DW_FORM_addrx
7658         (read_attribute_value): Likewise
7659         (var_decode_location): Add DW_OP_addrx
7660         (dwarf2_const_value_attr): Add DW_FORM_addrx
7661         (dump_die_shallow): Likewise
7662         (dwarf2_fetch_constant_bytes): Likewise
7663         (decode_locdesc): Add DW_OP_addrx
7664         (skip_form_bytes): Add DW_FORM_addrx
7665
7666 2019-04-22  Ali Tamur  <tamur@google.com>
7667
7668         * MAINTAINERS (Write After Approval): Add self.
7669
7670 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7671
7672         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7673         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7674         (open_symbol_file_object): Likewise.
7675         (svr4_default_sos): Add info parameter.
7676         (svr4_read_so_list): Likewise.
7677         (svr4_current_sos_direct): Adjust functions calls to pass down
7678         info.
7679         (svr4_current_sos_1): Add info parameter.
7680         (svr4_current_sos): Call get_svr4_info, pass info down to
7681         svr4_current_sos_1.
7682         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7683         get_svr4_info.
7684         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7685         get_svr4_info.
7686         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7687         to get_svr4_info.
7688         (probes_table_remove_objfile_probes): Likewise.
7689         (register_solib_event_probe): Add info parameter.
7690         (solist_update_incremental): Pass info parameter down to
7691         svr4_read_so_list.
7692         (disable_probes_interface): Add info parameter.
7693         (svr4_handle_solib_event): Pass current_program_space to
7694         get_svr4_info.  Adjust disable_probes_interface cleanup.
7695         (svr4_create_probe_breakpoints): Add info parameter, pass it
7696         down to register_solib_event_probe.
7697         (svr4_create_solib_event_breakpoints): Add info parameter,
7698         pass it down to svr4_create_probe_breakpoints.
7699         (enable_break): Pass info down to
7700         svr4_create_solib_event_breakpoints.
7701         (svr4_solib_create_inferior_hook): Pass current_program_space to
7702         get_svr4_info.
7703         (svr4_clear_solib): Likewise.
7704
7705 2019-04-22  Pedro Alves  <palves@redhat.com>
7706
7707         * solib-svr4.c (svr4_free_objfile_observer): New.
7708         (probe_and_action::objfile): New field.
7709         (probes_table_htab_remove_objfile_probes)
7710         (probes_table_remove_objfile_probes): New functions.
7711         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7712         in the new probe_and_action.  Don't store the probe in 'lookup'.
7713         (svr4_create_probe_breakpoints): Pass objfile to
7714         register_solib_event_probe.
7715         (_initialize_svr4_solib): Register a free_objfile observer.
7716
7717 2019-04-19  Tom Tromey  <tom@tromey.com>
7718
7719         * common/queue.h: Remove.
7720
7721 2019-04-19  Tom Tromey  <tom@tromey.com>
7722
7723         * event-loop.c: Don't include "common/queue.h".
7724
7725 2019-04-19  Tom Tromey  <tom@tromey.com>
7726
7727         * remote.c (remote_target): Use delete.
7728         * remote-notif.h: Include <list>, not "common/queue.h".
7729         (notif_client_p): Remove typedef.
7730         (remote_notif_state): Add constructor, destructor, initializer.
7731         <notif_queue>: Now a std::list.
7732         (remote_notif_state_xfree): Don't declare.
7733         * remote-notif.c (remote_notif_process, handle_notification)
7734         (remote_notif_state_allocate): Update.
7735         (~remote_notif_state): Rename from remote_notif_state_xfree.
7736
7737 2019-04-19  Tom Tromey  <tom@tromey.com>
7738
7739         * symfile.c (reread_symbols): Update.
7740         * objfiles.c (objfile_register_static_link)
7741         (objfile_lookup_static_link): Update
7742         (~objfile) Don't delete static_links.
7743         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7744
7745 2019-04-19  Tom Tromey  <tom@tromey.com>
7746
7747         * type-stack.h (struct type_stack) <insert>: Constify string.
7748         * type-stack.c (type_stack::insert): Constify string.
7749         * gdbtypes.h (lookup_template_type): Update.
7750         (address_space_name_to_int): Update.
7751         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7752         const.
7753         (lookup_template_type): Make name const.
7754         * c-exp.y: Update rules.
7755         (lex_one_token, classify_name, classify_inner_name)
7756         (c_print_token): Update.
7757         * p-exp.y: Update rules.
7758         (yylex): Update.
7759         * f-exp.y: Update rules.
7760         (yylex): Update.
7761         * d-exp.y: Update rules.
7762         (lex_one_token, classify_name, classify_inner_name): Update.
7763         * parse.c (write_dollar_variable, copy_name): Return std::string.
7764         * parser-defs.h (copy_name): Change return type.
7765         * m2-exp.y: Update rules.
7766         (yylex): Update.
7767         * go-exp.y (lex_one_token): Update.
7768         Update rules.
7769         (classify_unsafe_function, classify_packaged_name)
7770         (classify_name, yylex): Update.
7771
7772 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7773
7774         * configure.ac: add --enable-source-highlight switch.
7775         * configure: Regenerate.
7776         * top.c (print_gdb_version): plumb --enable-source-highlight
7777         status to "show configuration".
7778
7779 2019-04-19  Tom Tromey  <tromey@adacore.com>
7780
7781         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7782         Check ADA_TYPE_P.
7783         (empty_record, ada_template_to_fixed_record_type_1)
7784         (template_to_static_fixed_type)
7785         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7786         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7787         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7788         macros.
7789
7790 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7791
7792         PR symtab/24423:
7793         * source.c (print_source_lines_base): Advance "iter" when a
7794         control character is seen.
7795
7796 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7797
7798         * inferior.h (struct infcall_suspend_state_deleter):
7799         Catch exception in destructor to avoid crash.
7800
7801 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7802
7803         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7804         close to the add_com "shell".
7805
7806 2019-04-18  Tom Tromey  <tromey@adacore.com>
7807
7808         * process-stratum-target.h (class process_stratum_target)
7809         <stratum>: Add "final".
7810
7811 2019-04-17  Tom Tromey  <tromey@adacore.com>
7812
7813         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7814         against nullptr before use.
7815
7816 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7817
7818         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7819
7820 2019-04-17  Jim Wilson  <jimw@sifive.com>
7821             Andrew Burgess  <andrew.burgess@embecosm.com>
7822
7823         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7824         code read might fail, assume 4-byte breakpoint in that case.
7825
7826 2019-04-15  Leszek Swirski  <leszeks@google.com>
7827
7828         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7829         rather than a hand-rolled POD check when checking for forced MEMORY
7830         classification.
7831
7832 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7833
7834         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7835         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7836         function.
7837         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7838         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7839         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7840         declaration.
7841
7842 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7843
7844         * aarch64-linux-nat.c
7845         (aarch64_linux_nat_target::thread_architecture): Add override.
7846         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7847         each VQ.
7848
7849 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7850
7851         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7852
7853 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7854
7855         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7856         target types of size 96-bits, add some additional comments, and
7857         check that the builtin type we found was the correct size.
7858
7859 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7860
7861         * utils.c (prompt_for_continue): Don't restore the styling at the
7862         end, as applied_style has the wrong value.  This fixes styling in
7863         long lists of file names that are interrupted by the "Continue?"
7864         prompt.
7865
7866 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7869         * c-lang.c (c_language_defn): Likewise.
7870         (cplus_language_defn): Likewise.
7871         (asm_language_defn): Likewise.
7872         (minimal_language_defn): Likewise.
7873         * d-lang.c (d_language_defn): Likewise.
7874         * f-lang.c (f_language_defn): Likewise.
7875         * go-lang.c (go_language_defn): Likewise.
7876         * language.c (unknown_language_defn): Likewise.
7877         (auto_language_defn): Likewise.
7878         * language.h (struct language_defn): Remove la_magic field.
7879         (LANG_MAGIC): Delete.
7880         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7881         * objc-lang.c (objc_language_defn): Likewise.
7882         * opencl-lang.c (opencl_language_defn): Likewise.
7883         * p-lang.c (pascal_language_defn): Likewise.
7884         * rust-lang.c (rust_language_defn): Likewise.
7885
7886 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7887
7888         * riscv-tdep.c (riscv_type_align): New function.
7889         (riscv_type_alignment): Delete.
7890         (riscv_arg_location): Use 'type_align'.
7891         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7892
7893 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         * gdbtypes.c (type_align): A struct with no non-static fields also
7896         has alignment of 1.
7897
7898 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7899
7900         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7901         component to 0.
7902         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7903         member.
7904         (riscv_struct_info::analyse): New implementation using new
7905         analyse_inner member function.
7906         (riscv_struct_info::field_offset): New member function.
7907         (riscv_struct_info::m_offsets): New member variable.
7908         (riscv_struct_info::analyse_inner): New private member function,
7909         takes the old implementation of riscv_struct_info::analyse but
7910         extended to track field offsets.
7911         (riscv_call_arg_struct): Update the struct folding special cases
7912         to handle cases where empty C++ structs, which are non-zero
7913         length, are found.
7914         (riscv_arg_location): Initialise the length of each location, a
7915         non-zero length now indicates the location is in use.
7916         (riscv_push_dummy_call): Allow for the first location having a
7917         non-zero offset when setting up arguments.
7918         (riscv_return_value): Likewise, but for return values.
7919
7920 2019-04-11  Tom Tromey  <tromey@adacore.com>
7921
7922         * utils.c (internal_vproblem): Make "msg" const.
7923
7924 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7925
7926         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7927         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7928         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7929         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7930
7931 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7932
7933         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7934         function.
7935         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7936         of amd64_collect_native_gregset.
7937         (amd64_linux_nat_target::store_registers): Likewise.
7938
7939 2019-04-10  Tom Tromey  <tom@tromey.com>
7940
7941         * symtab.c (lookup_global_symbol_from_objfile)
7942         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7943         * objfiles.h (class separate_debug_iterator): New.
7944         (class separate_debug_range): New.
7945         (struct objfile) <separate_debug_objfiles>: New method.
7946         (objfile_separate_debug_iterate): Don't declare.
7947         * objfiles.c (separate_debug_iterator::operator++): Rename from
7948         objfile_separate_debug_iterate.
7949         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7950         iterator.
7951         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7952         iterator.
7953
7954 2019-04-10  Tom Tromey  <tom@tromey.com>
7955
7956         * symfile.c (reread_symbols): Remove old comment.
7957         * objfiles.c (free_all_objfiles): Fix a typo.
7958
7959 2019-04-10  Tom Tromey  <tom@tromey.com>
7960
7961         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7962         * minsyms.c (lookup_minimal_symbol): Use foreach.
7963         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7964         (lookup_minimal_symbol_solib_trampoline): Likewise.
7965         * symfile.c (reread_symbols): Use foreach.
7966
7967 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7968             Tom Tromey  <tromey@adacore.com>
7969
7970         PR rust/24414:
7971         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7972         (rust_lex_int_test): Change "value" to be LONGEST.
7973         (rust_lex_tests): Add test for long integer literal.
7974
7975 2019-04-09  Tom Tromey  <tromey@adacore.com>
7976
7977         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7978         to bool.
7979         (extended_remote_target::attach): Update.
7980         (remote_target::remote_notice_new_inferior): Update.
7981         (remote_target::add_current_inferior_and_thread): Update.
7982         * inferior.c (exit_inferior_1): Use "false".
7983         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7984
7985 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7986
7987         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7988         the "start" command.
7989
7990 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7991
7992         * python/py-inferior.c (infpy_thread_from_thread_handle):
7993         Adjust comments to reflect renaming of thread_from_thread_handle
7994         to thread_from_handle.  Adjust keywords.  Fix type error message.
7995         (inferior_object_methods): Add thread_from_handle.  Retain
7996         thread_from_thread_handle, but mark it as deprecated.
7997
7998 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7999
8000         * gdbthread.h (find_thread_by_handle): Revise declaration.
8001         * thread.c (find_thread_by_handle): Likewise.  Adjust
8002         implementation too.
8003         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8004         support for buffer objects as handles.
8005
8006 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8007
8008         * python/py-infthread.c (thpy_thread_handle): New function.
8009         (thread_object_methods): Register thpy_thread_handle.
8010
8011 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8012
8013         * gdbthread.h (thread_to_thread_handle): Declare.
8014         * thread.c (gdbtypes.h): Include.
8015         (thread_to_thread_handle): New function.
8016
8017         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8018         (target_thread_info_to_thread_handle): Declare.
8019         * target.c (target_thread_info_to_thread_handle): New function.
8020         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8021         * target-delegates.c: Regenerate.
8022
8023         * linux-thread-db.c (class thread_db_target): Add method
8024         thread_info_to_thread_handle.
8025         (thread_db_target::thread_info_to_thread_handle): Define.
8026         * remote.c (class remote_target): Add new method
8027         thread_info_to_thread_handle.
8028         (remote_target::thread_info_to_thread_handle): Define.
8029
8030 2019-04-08  Pedro Alves  <palves@redhat.com>
8031
8032         * common/common-exceptions.c (throw_exception): Don't create
8033         named object to throw; throw directly.
8034         (throw_it): Likewise.  Don't initialize gdb_exception::message
8035         here, with new; pass FMT and AP to the ctor instead.
8036         * common/common-exceptions.h: Include <string>.
8037         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8038         const char *, va_list)): New ctor.  Use std::make_shared.
8039         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8040         errors)): Delete.
8041         (gdb_exception_error::gdb_exception_error(enum errors, const char
8042         *, va_list)): New.
8043         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8044         Add assertion.
8045         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8046         errors)): Delete.
8047         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8048         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8049         Add assertion.
8050
8051 2019-04-08  Tom Tromey  <tom@tromey.com>
8052
8053         * valops.c (value_rtti_indirect_type): Replace throw_exception
8054         with throw.
8055         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8056         with throw.
8057         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8058         throw.
8059         * target.c (target_translate_tls_address): Replace throw_exception
8060         with throw.
8061         * stack.c (frame_apply_command_count): Replace throw_exception
8062         with throw.
8063         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8064         throw.
8065         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8066         with throw.
8067         * rs6000-tdep.c (rs6000_frame_cache)
8068         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8069         * remote.c: Replace throw_exception with throw.
8070         * record-full.c (record_full_message, record_full_wait_1)
8071         (record_full_restore): Replace throw_exception with throw.
8072         * record-btrace.c:
8073         (get_thread_current_frame_id, record_btrace_start_replaying)
8074         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8075         (cmd_record_btrace_start): Replace throw_exception with throw.
8076         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8077         throw.
8078         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8079         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8080         * linespec.c:
8081         (find_linespec_symbols): Replace throw_exception with throw.
8082         * infrun.c (displaced_step_prepare, resume): Replace
8083         throw_exception with throw.
8084         * infcmd.c (post_create_inferior): Replace throw_exception with
8085         throw.
8086         * inf-loop.c (inferior_event_handler): Replace throw_exception
8087         with throw.
8088         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8089         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8090         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8091         (get_prev_frame_always, get_frame_pc_if_available)
8092         (get_frame_address_in_block_if_available, get_frame_language):
8093         Replace throw_exception with throw.
8094         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8095         throw_exception with throw.
8096         * eval.c (fetch_subexp_value, evaluate_var_value)
8097         (evaluate_funcall, evaluate_subexp_standard): Replace
8098         throw_exception with throw.
8099         * dwarf2loc.c (call_site_find_chain)
8100         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8101         Replace throw_exception with throw.
8102         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8103         with throw.
8104         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8105         throw.
8106         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8107         * completer.c (complete_line_internal): Replace throw_exception
8108         with throw.
8109         * compile/compile-object-run.c (compile_object_run): Replace
8110         throw_exception with throw.
8111         * cli/cli-script.c (process_next_line): Replace throw_exception
8112         with throw.
8113         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8114         (btrace_enable, btrace_maint_update_pt_packets): Replace
8115         throw_exception with throw.
8116         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8117         throw_exception with throw.
8118         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8119         throw_exception with throw.
8120         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8121         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8122         * aarch64-tdep.c (aarch64_make_prologue_cache)
8123         (aarch64_make_stub_cache): Replace throw_exception with throw.
8124
8125 2019-04-08  Tom Tromey  <tom@tromey.com>
8126
8127         * common/common-exceptions.c (throw_exception): Rename from
8128         throw_exception_cxx.  Remove old copy.  Make argument const.
8129         (throw_it): Create and throw exception objects directly.
8130         * common/common-exceptions.h (throw_exception): Make argument
8131         const.
8132         (struct gdb_exception_error): Add constructor.
8133         (struct gdb_exception_quit): Add constructor.
8134
8135 2019-04-08  Tom Tromey  <tom@tromey.com>
8136
8137         * common/common-exceptions.h (exception_rethrow): Don't declare.
8138         (TRY_SJLJ): Update comment.
8139         (TRY, CATCH, END_CATCH): Remove.
8140         * common/common-exceptions.c (exception_rethrow): Remove.
8141
8142 2019-04-08  Tom Tromey  <tom@tromey.com>
8143
8144         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8145         Remove.
8146         (gdb_exception_error): Rename from
8147         gdb_exception_RETURN_MASK_ERROR.
8148         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8149         (gdb_quit_bad_alloc): Update.
8150         * aarch64-tdep.c: Update.
8151         * ada-lang.c: Update.
8152         * ada-typeprint.c: Update.
8153         * ada-valprint.c: Update.
8154         * amd64-tdep.c: Update.
8155         * arch-utils.c: Update.
8156         * break-catch-throw.c: Update.
8157         * breakpoint.c: Update.
8158         * btrace.c: Update.
8159         * c-varobj.c: Update.
8160         * cli/cli-cmds.c: Update.
8161         * cli/cli-interp.c: Update.
8162         * cli/cli-script.c: Update.
8163         * common/common-exceptions.c: Update.
8164         * common/new-op.c: Update.
8165         * common/selftest.c: Update.
8166         * compile/compile-c-symbols.c: Update.
8167         * compile/compile-cplus-symbols.c: Update.
8168         * compile/compile-object-load.c: Update.
8169         * compile/compile-object-run.c: Update.
8170         * completer.c: Update.
8171         * corelow.c: Update.
8172         * cp-abi.c: Update.
8173         * cp-support.c: Update.
8174         * cp-valprint.c: Update.
8175         * darwin-nat.c: Update.
8176         * disasm-selftests.c: Update.
8177         * dtrace-probe.c: Update.
8178         * dwarf-index-cache.c: Update.
8179         * dwarf-index-write.c: Update.
8180         * dwarf2-frame-tailcall.c: Update.
8181         * dwarf2-frame.c: Update.
8182         * dwarf2loc.c: Update.
8183         * dwarf2read.c: Update.
8184         * eval.c: Update.
8185         * event-loop.c: Update.
8186         * event-top.c: Update.
8187         * exec.c: Update.
8188         * f-valprint.c: Update.
8189         * fbsd-tdep.c: Update.
8190         * frame-unwind.c: Update.
8191         * frame.c: Update.
8192         * gdbtypes.c: Update.
8193         * gnu-v3-abi.c: Update.
8194         * guile/guile-internal.h: Update.
8195         * guile/scm-block.c: Update.
8196         * guile/scm-breakpoint.c: Update.
8197         * guile/scm-cmd.c: Update.
8198         * guile/scm-disasm.c: Update.
8199         * guile/scm-frame.c: Update.
8200         * guile/scm-lazy-string.c: Update.
8201         * guile/scm-math.c: Update.
8202         * guile/scm-param.c: Update.
8203         * guile/scm-ports.c: Update.
8204         * guile/scm-pretty-print.c: Update.
8205         * guile/scm-symbol.c: Update.
8206         * guile/scm-symtab.c: Update.
8207         * guile/scm-type.c: Update.
8208         * guile/scm-value.c: Update.
8209         * i386-linux-tdep.c: Update.
8210         * i386-tdep.c: Update.
8211         * inf-loop.c: Update.
8212         * infcall.c: Update.
8213         * infcmd.c: Update.
8214         * infrun.c: Update.
8215         * jit.c: Update.
8216         * language.c: Update.
8217         * linespec.c: Update.
8218         * linux-fork.c: Update.
8219         * linux-nat.c: Update.
8220         * linux-tdep.c: Update.
8221         * linux-thread-db.c: Update.
8222         * main.c: Update.
8223         * mi/mi-cmd-break.c: Update.
8224         * mi/mi-cmd-stack.c: Update.
8225         * mi/mi-interp.c: Update.
8226         * mi/mi-main.c: Update.
8227         * objc-lang.c: Update.
8228         * p-valprint.c: Update.
8229         * parse.c: Update.
8230         * ppc-linux-tdep.c: Update.
8231         * printcmd.c: Update.
8232         * python/py-arch.c: Update.
8233         * python/py-breakpoint.c: Update.
8234         * python/py-cmd.c: Update.
8235         * python/py-finishbreakpoint.c: Update.
8236         * python/py-frame.c: Update.
8237         * python/py-framefilter.c: Update.
8238         * python/py-gdb-readline.c: Update.
8239         * python/py-inferior.c: Update.
8240         * python/py-infthread.c: Update.
8241         * python/py-lazy-string.c: Update.
8242         * python/py-linetable.c: Update.
8243         * python/py-objfile.c: Update.
8244         * python/py-param.c: Update.
8245         * python/py-prettyprint.c: Update.
8246         * python/py-progspace.c: Update.
8247         * python/py-record-btrace.c: Update.
8248         * python/py-record.c: Update.
8249         * python/py-symbol.c: Update.
8250         * python/py-type.c: Update.
8251         * python/py-unwind.c: Update.
8252         * python/py-utils.c: Update.
8253         * python/py-value.c: Update.
8254         * python/python.c: Update.
8255         * record-btrace.c: Update.
8256         * record-full.c: Update.
8257         * remote-fileio.c: Update.
8258         * remote.c: Update.
8259         * riscv-tdep.c: Update.
8260         * rs6000-aix-tdep.c: Update.
8261         * rs6000-tdep.c: Update.
8262         * rust-exp.y: Update.
8263         * rust-lang.c: Update.
8264         * s390-tdep.c: Update.
8265         * selftest-arch.c: Update.
8266         * solib-dsbt.c: Update.
8267         * solib-frv.c: Update.
8268         * solib-spu.c: Update.
8269         * solib-svr4.c: Update.
8270         * solib.c: Update.
8271         * sparc64-linux-tdep.c: Update.
8272         * stack.c: Update.
8273         * symfile-mem.c: Update.
8274         * symmisc.c: Update.
8275         * target.c: Update.
8276         * thread.c: Update.
8277         * top.c: Update.
8278         * tracefile-tfile.c: Update.
8279         * tui/tui.c: Update.
8280         * typeprint.c: Update.
8281         * unittests/cli-utils-selftests.c: Update.
8282         * unittests/parse-connection-spec-selftests.c: Update.
8283         * valops.c: Update.
8284         * valprint.c: Update.
8285         * value.c: Update.
8286         * varobj.c: Update.
8287         * windows-nat.c: Update.
8288         * x86-linux-nat.c: Update.
8289         * xml-support.c: Update.
8290
8291 2019-04-08  Tom Tromey  <tom@tromey.com>
8292
8293         * xml-support.c: Use C++ exception handling.
8294         * x86-linux-nat.c: Use C++ exception handling.
8295         * windows-nat.c: Use C++ exception handling.
8296         * varobj.c: Use C++ exception handling.
8297         * value.c: Use C++ exception handling.
8298         * valprint.c: Use C++ exception handling.
8299         * valops.c: Use C++ exception handling.
8300         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8301         handling.
8302         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8303         * typeprint.c: Use C++ exception handling.
8304         * tui/tui.c: Use C++ exception handling.
8305         * tracefile-tfile.c: Use C++ exception handling.
8306         * top.c: Use C++ exception handling.
8307         * thread.c: Use C++ exception handling.
8308         * target.c: Use C++ exception handling.
8309         * symmisc.c: Use C++ exception handling.
8310         * symfile-mem.c: Use C++ exception handling.
8311         * stack.c: Use C++ exception handling.
8312         * sparc64-linux-tdep.c: Use C++ exception handling.
8313         * solib.c: Use C++ exception handling.
8314         * solib-svr4.c: Use C++ exception handling.
8315         * solib-spu.c: Use C++ exception handling.
8316         * solib-frv.c: Use C++ exception handling.
8317         * solib-dsbt.c: Use C++ exception handling.
8318         * selftest-arch.c: Use C++ exception handling.
8319         * s390-tdep.c: Use C++ exception handling.
8320         * rust-lang.c: Use C++ exception handling.
8321         * rust-exp.y: Use C++ exception handling.
8322         * rs6000-tdep.c: Use C++ exception handling.
8323         * rs6000-aix-tdep.c: Use C++ exception handling.
8324         * riscv-tdep.c: Use C++ exception handling.
8325         * remote.c: Use C++ exception handling.
8326         * remote-fileio.c: Use C++ exception handling.
8327         * record-full.c: Use C++ exception handling.
8328         * record-btrace.c: Use C++ exception handling.
8329         * python/python.c: Use C++ exception handling.
8330         * python/py-value.c: Use C++ exception handling.
8331         * python/py-utils.c: Use C++ exception handling.
8332         * python/py-unwind.c: Use C++ exception handling.
8333         * python/py-type.c: Use C++ exception handling.
8334         * python/py-symbol.c: Use C++ exception handling.
8335         * python/py-record.c: Use C++ exception handling.
8336         * python/py-record-btrace.c: Use C++ exception handling.
8337         * python/py-progspace.c: Use C++ exception handling.
8338         * python/py-prettyprint.c: Use C++ exception handling.
8339         * python/py-param.c: Use C++ exception handling.
8340         * python/py-objfile.c: Use C++ exception handling.
8341         * python/py-linetable.c: Use C++ exception handling.
8342         * python/py-lazy-string.c: Use C++ exception handling.
8343         * python/py-infthread.c: Use C++ exception handling.
8344         * python/py-inferior.c: Use C++ exception handling.
8345         * python/py-gdb-readline.c: Use C++ exception handling.
8346         * python/py-framefilter.c: Use C++ exception handling.
8347         * python/py-frame.c: Use C++ exception handling.
8348         * python/py-finishbreakpoint.c: Use C++ exception handling.
8349         * python/py-cmd.c: Use C++ exception handling.
8350         * python/py-breakpoint.c: Use C++ exception handling.
8351         * python/py-arch.c: Use C++ exception handling.
8352         * printcmd.c: Use C++ exception handling.
8353         * ppc-linux-tdep.c: Use C++ exception handling.
8354         * parse.c: Use C++ exception handling.
8355         * p-valprint.c: Use C++ exception handling.
8356         * objc-lang.c: Use C++ exception handling.
8357         * mi/mi-main.c: Use C++ exception handling.
8358         * mi/mi-interp.c: Use C++ exception handling.
8359         * mi/mi-cmd-stack.c: Use C++ exception handling.
8360         * mi/mi-cmd-break.c: Use C++ exception handling.
8361         * main.c: Use C++ exception handling.
8362         * linux-thread-db.c: Use C++ exception handling.
8363         * linux-tdep.c: Use C++ exception handling.
8364         * linux-nat.c: Use C++ exception handling.
8365         * linux-fork.c: Use C++ exception handling.
8366         * linespec.c: Use C++ exception handling.
8367         * language.c: Use C++ exception handling.
8368         * jit.c: Use C++ exception handling.
8369         * infrun.c: Use C++ exception handling.
8370         * infcmd.c: Use C++ exception handling.
8371         * infcall.c: Use C++ exception handling.
8372         * inf-loop.c: Use C++ exception handling.
8373         * i386-tdep.c: Use C++ exception handling.
8374         * i386-linux-tdep.c: Use C++ exception handling.
8375         * guile/scm-value.c: Use C++ exception handling.
8376         * guile/scm-type.c: Use C++ exception handling.
8377         * guile/scm-symtab.c: Use C++ exception handling.
8378         * guile/scm-symbol.c: Use C++ exception handling.
8379         * guile/scm-pretty-print.c: Use C++ exception handling.
8380         * guile/scm-ports.c: Use C++ exception handling.
8381         * guile/scm-param.c: Use C++ exception handling.
8382         * guile/scm-math.c: Use C++ exception handling.
8383         * guile/scm-lazy-string.c: Use C++ exception handling.
8384         * guile/scm-frame.c: Use C++ exception handling.
8385         * guile/scm-disasm.c: Use C++ exception handling.
8386         * guile/scm-cmd.c: Use C++ exception handling.
8387         * guile/scm-breakpoint.c: Use C++ exception handling.
8388         * guile/scm-block.c: Use C++ exception handling.
8389         * guile/guile-internal.h: Use C++ exception handling.
8390         * gnu-v3-abi.c: Use C++ exception handling.
8391         * gdbtypes.c: Use C++ exception handling.
8392         * frame.c: Use C++ exception handling.
8393         * frame-unwind.c: Use C++ exception handling.
8394         * fbsd-tdep.c: Use C++ exception handling.
8395         * f-valprint.c: Use C++ exception handling.
8396         * exec.c: Use C++ exception handling.
8397         * event-top.c: Use C++ exception handling.
8398         * event-loop.c: Use C++ exception handling.
8399         * eval.c: Use C++ exception handling.
8400         * dwarf2read.c: Use C++ exception handling.
8401         * dwarf2loc.c: Use C++ exception handling.
8402         * dwarf2-frame.c: Use C++ exception handling.
8403         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8404         * dwarf-index-write.c: Use C++ exception handling.
8405         * dwarf-index-cache.c: Use C++ exception handling.
8406         * dtrace-probe.c: Use C++ exception handling.
8407         * disasm-selftests.c: Use C++ exception handling.
8408         * darwin-nat.c: Use C++ exception handling.
8409         * cp-valprint.c: Use C++ exception handling.
8410         * cp-support.c: Use C++ exception handling.
8411         * cp-abi.c: Use C++ exception handling.
8412         * corelow.c: Use C++ exception handling.
8413         * completer.c: Use C++ exception handling.
8414         * compile/compile-object-run.c: Use C++ exception handling.
8415         * compile/compile-object-load.c: Use C++ exception handling.
8416         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8417         * compile/compile-c-symbols.c: Use C++ exception handling.
8418         * common/selftest.c: Use C++ exception handling.
8419         * common/new-op.c: Use C++ exception handling.
8420         * cli/cli-script.c: Use C++ exception handling.
8421         * cli/cli-interp.c: Use C++ exception handling.
8422         * cli/cli-cmds.c: Use C++ exception handling.
8423         * c-varobj.c: Use C++ exception handling.
8424         * btrace.c: Use C++ exception handling.
8425         * breakpoint.c: Use C++ exception handling.
8426         * break-catch-throw.c: Use C++ exception handling.
8427         * arch-utils.c: Use C++ exception handling.
8428         * amd64-tdep.c: Use C++ exception handling.
8429         * ada-valprint.c: Use C++ exception handling.
8430         * ada-typeprint.c: Use C++ exception handling.
8431         * ada-lang.c: Use C++ exception handling.
8432         * aarch64-tdep.c: Use C++ exception handling.
8433
8434 2019-04-08  Tom Tromey  <tom@tromey.com>
8435
8436         * xml-support.c (gdb_xml_parser::parse): Update.
8437         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8438         * value.c (show_convenience): Update.
8439         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8440         (test_parse_flags_qcs): Update.
8441         * thread.c (thr_try_catch_cmd): Update.
8442         * target.c (target_translate_tls_address): Update.
8443         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8444         (info_frame_command_core, frame_apply_command_count): Update.
8445         * rust-exp.y (rust_lex_exception_test): Update.
8446         * riscv-tdep.c (riscv_print_one_register_info): Update.
8447         * remote.c (remote_target::enable_btrace): Update.
8448         * record-btrace.c (record_btrace_enable_warn): Update.
8449         * python/py-utils.c (gdbpy_convert_exception): Update.
8450         * printcmd.c (do_one_display, print_variable_and_value): Update.
8451         * mi/mi-main.c (mi_print_exception): Update.
8452         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8453         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8454         * linux-nat.c (linux_nat_target::attach): Update.
8455         * linux-fork.c (class scoped_switch_fork_info): Update.
8456         * infrun.c (displaced_step_prepare): Update.
8457         * infcall.c (call_function_by_hand_dummy): Update.
8458         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8459         * gnu-v3-abi.c (print_one_vtable): Update.
8460         * frame.c (get_prev_frame_always): Update.
8461         * f-valprint.c (info_common_command_for_block): Update.
8462         * exec.c (try_open_exec_file): Update.
8463         * exceptions.c (print_exception, exception_print)
8464         (exception_fprintf, exception_print_same): Update.
8465         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8466         * dwarf-index-cache.c (index_cache::store)
8467         (index_cache::lookup_gdb_index): Update.
8468         * darwin-nat.c (maybe_cache_shell): Update.
8469         * cp-valprint.c (cp_print_value_fields): Update.
8470         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8471         (gcc_cplus_symbol_address): Update.
8472         * compile/compile-c-symbols.c (gcc_convert_symbol)
8473         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8474         * common/selftest.c: Update.
8475         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8476         a std::string.
8477         (exception_try_scope_entry, exception_try_scope_exit): Don't
8478         declare.
8479         (struct exception_try_scope): Remove.
8480         (TRY): Don't use exception_try_scope.
8481         (struct gdb_exception): Add constructor, operator=.
8482         <what>: New method.
8483         (struct gdb_exception_RETURN_MASK_ALL)
8484         (struct gdb_exception_RETURN_MASK_ERROR)
8485         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8486         (struct gdb_quit_bad_alloc): Update.
8487         * common/common-exceptions.c (exception_none): Change
8488         initializer.
8489         (struct catcher) <state, exception>: Initialize inline.
8490         <prev>: Remove member.
8491         (current_catcher): Remove.
8492         (catchers): New global.
8493         (exceptions_state_mc_init): Simplify.
8494         (catcher_pop): Remove.
8495         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8496         (try_scope_depth, exception_try_scope_entry)
8497         (exception_try_scope_exit): Remove.
8498         (throw_exception_sjlj): Update.
8499         (exception_messages, exception_messages_size): Remove.
8500         (throw_it): Simplify.
8501         (gdb_exception_sliced_copy): Remove.
8502         (throw_exception_cxx): Update.
8503         * cli/cli-script.c (script_from_file): Update.
8504         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8505         Update.
8506         * ada-valprint.c (ada_val_print): Update.
8507         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8508         (create_excep_cond_exprs): Update.
8509
8510 2019-04-08  Tom Tromey  <tom@tromey.com>
8511
8512         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8513         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8514         (TRY, CATCH, END_CATCH): Remove some definitions.
8515         * common/common-exceptions.c: Don't use GDB_XCPT.
8516         (catcher_list_size): Remove.
8517         (throw_exception, throw_it): Simplify.
8518
8519 2019-04-05  Tom Tromey  <tom@tromey.com>
8520
8521         Revert the header-sorting patch.
8522         * ft32-tdep.c: Revert.
8523         * frv-tdep.c: Revert.
8524         * frv-linux-tdep.c: Revert.
8525         * frame.c: Revert.
8526         * frame-unwind.c: Revert.
8527         * frame-base.c: Revert.
8528         * fork-child.c: Revert.
8529         * findvar.c: Revert.
8530         * findcmd.c: Revert.
8531         * filesystem.c: Revert.
8532         * filename-seen-cache.h: Revert.
8533         * filename-seen-cache.c: Revert.
8534         * fbsd-tdep.c: Revert.
8535         * fbsd-nat.h: Revert.
8536         * fbsd-nat.c: Revert.
8537         * f-valprint.c: Revert.
8538         * f-typeprint.c: Revert.
8539         * f-lang.c: Revert.
8540         * extension.h: Revert.
8541         * extension.c: Revert.
8542         * extension-priv.h: Revert.
8543         * expprint.c: Revert.
8544         * exec.h: Revert.
8545         * exec.c: Revert.
8546         * exceptions.c: Revert.
8547         * event-top.c: Revert.
8548         * event-loop.c: Revert.
8549         * eval.c: Revert.
8550         * elfread.c: Revert.
8551         * dwarf2read.h: Revert.
8552         * dwarf2read.c: Revert.
8553         * dwarf2loc.c: Revert.
8554         * dwarf2expr.h: Revert.
8555         * dwarf2expr.c: Revert.
8556         * dwarf2-frame.c: Revert.
8557         * dwarf2-frame-tailcall.c: Revert.
8558         * dwarf-index-write.h: Revert.
8559         * dwarf-index-write.c: Revert.
8560         * dwarf-index-common.c: Revert.
8561         * dwarf-index-cache.h: Revert.
8562         * dwarf-index-cache.c: Revert.
8563         * dummy-frame.c: Revert.
8564         * dtrace-probe.c: Revert.
8565         * disasm.h: Revert.
8566         * disasm.c: Revert.
8567         * disasm-selftests.c: Revert.
8568         * dictionary.c: Revert.
8569         * dicos-tdep.c: Revert.
8570         * demangle.c: Revert.
8571         * dcache.h: Revert.
8572         * dcache.c: Revert.
8573         * darwin-nat.h: Revert.
8574         * darwin-nat.c: Revert.
8575         * darwin-nat-info.c: Revert.
8576         * d-valprint.c: Revert.
8577         * d-namespace.c: Revert.
8578         * d-lang.c: Revert.
8579         * ctf.c: Revert.
8580         * csky-tdep.c: Revert.
8581         * csky-linux-tdep.c: Revert.
8582         * cris-tdep.c: Revert.
8583         * cris-linux-tdep.c: Revert.
8584         * cp-valprint.c: Revert.
8585         * cp-support.c: Revert.
8586         * cp-namespace.c: Revert.
8587         * cp-abi.c: Revert.
8588         * corelow.c: Revert.
8589         * corefile.c: Revert.
8590         * continuations.c: Revert.
8591         * completer.h: Revert.
8592         * completer.c: Revert.
8593         * complaints.c: Revert.
8594         * coffread.c: Revert.
8595         * coff-pe-read.c: Revert.
8596         * cli-out.h: Revert.
8597         * cli-out.c: Revert.
8598         * charset.c: Revert.
8599         * c-varobj.c: Revert.
8600         * c-valprint.c: Revert.
8601         * c-typeprint.c: Revert.
8602         * c-lang.c: Revert.
8603         * buildsym.c: Revert.
8604         * buildsym-legacy.c: Revert.
8605         * build-id.h: Revert.
8606         * build-id.c: Revert.
8607         * btrace.c: Revert.
8608         * bsd-uthread.c: Revert.
8609         * breakpoint.h: Revert.
8610         * breakpoint.c: Revert.
8611         * break-catch-throw.c: Revert.
8612         * break-catch-syscall.c: Revert.
8613         * break-catch-sig.c: Revert.
8614         * blockframe.c: Revert.
8615         * block.c: Revert.
8616         * bfin-tdep.c: Revert.
8617         * bfin-linux-tdep.c: Revert.
8618         * bfd-target.c: Revert.
8619         * bcache.c: Revert.
8620         * ax-general.c: Revert.
8621         * ax-gdb.h: Revert.
8622         * ax-gdb.c: Revert.
8623         * avr-tdep.c: Revert.
8624         * auxv.c: Revert.
8625         * auto-load.c: Revert.
8626         * arm-wince-tdep.c: Revert.
8627         * arm-tdep.c: Revert.
8628         * arm-symbian-tdep.c: Revert.
8629         * arm-pikeos-tdep.c: Revert.
8630         * arm-obsd-tdep.c: Revert.
8631         * arm-nbsd-tdep.c: Revert.
8632         * arm-nbsd-nat.c: Revert.
8633         * arm-linux-tdep.c: Revert.
8634         * arm-linux-nat.c: Revert.
8635         * arm-fbsd-tdep.c: Revert.
8636         * arm-fbsd-nat.c: Revert.
8637         * arm-bsd-tdep.c: Revert.
8638         * arch-utils.c: Revert.
8639         * arc-tdep.c: Revert.
8640         * arc-newlib-tdep.c: Revert.
8641         * annotate.h: Revert.
8642         * annotate.c: Revert.
8643         * amd64-windows-tdep.c: Revert.
8644         * amd64-windows-nat.c: Revert.
8645         * amd64-tdep.c: Revert.
8646         * amd64-sol2-tdep.c: Revert.
8647         * amd64-obsd-tdep.c: Revert.
8648         * amd64-obsd-nat.c: Revert.
8649         * amd64-nbsd-tdep.c: Revert.
8650         * amd64-nbsd-nat.c: Revert.
8651         * amd64-nat.c: Revert.
8652         * amd64-linux-tdep.c: Revert.
8653         * amd64-linux-nat.c: Revert.
8654         * amd64-fbsd-tdep.c: Revert.
8655         * amd64-fbsd-nat.c: Revert.
8656         * amd64-dicos-tdep.c: Revert.
8657         * amd64-darwin-tdep.c: Revert.
8658         * amd64-bsd-nat.c: Revert.
8659         * alpha-tdep.c: Revert.
8660         * alpha-obsd-tdep.c: Revert.
8661         * alpha-nbsd-tdep.c: Revert.
8662         * alpha-mdebug-tdep.c: Revert.
8663         * alpha-linux-tdep.c: Revert.
8664         * alpha-linux-nat.c: Revert.
8665         * alpha-bsd-tdep.c: Revert.
8666         * alpha-bsd-nat.c: Revert.
8667         * aix-thread.c: Revert.
8668         * agent.c: Revert.
8669         * addrmap.c: Revert.
8670         * ada-varobj.c: Revert.
8671         * ada-valprint.c: Revert.
8672         * ada-typeprint.c: Revert.
8673         * ada-tasks.c: Revert.
8674         * ada-lang.c: Revert.
8675         * aarch64-tdep.c: Revert.
8676         * aarch64-ravenscar-thread.c: Revert.
8677         * aarch64-newlib-tdep.c: Revert.
8678         * aarch64-linux-tdep.c: Revert.
8679         * aarch64-linux-nat.c: Revert.
8680         * aarch64-fbsd-tdep.c: Revert.
8681         * aarch64-fbsd-nat.c: Revert.
8682         * aarch32-linux-nat.c: Revert.
8683
8684 2019-04-05  Tom Tromey  <tom@tromey.com>
8685
8686         * ft32-tdep.c: Sort headers.
8687         * frv-tdep.c: Sort headers.
8688         * frv-linux-tdep.c: Sort headers.
8689         * frame.c: Sort headers.
8690         * frame-unwind.c: Sort headers.
8691         * frame-base.c: Sort headers.
8692         * fork-child.c: Sort headers.
8693         * findvar.c: Sort headers.
8694         * findcmd.c: Sort headers.
8695         * filesystem.c: Sort headers.
8696         * filename-seen-cache.h: Sort headers.
8697         * filename-seen-cache.c: Sort headers.
8698         * fbsd-tdep.c: Sort headers.
8699         * fbsd-nat.h: Sort headers.
8700         * fbsd-nat.c: Sort headers.
8701         * f-valprint.c: Sort headers.
8702         * f-typeprint.c: Sort headers.
8703         * f-lang.c: Sort headers.
8704         * extension.h: Sort headers.
8705         * extension.c: Sort headers.
8706         * extension-priv.h: Sort headers.
8707         * expprint.c: Sort headers.
8708         * exec.h: Sort headers.
8709         * exec.c: Sort headers.
8710         * exceptions.c: Sort headers.
8711         * event-top.c: Sort headers.
8712         * event-loop.c: Sort headers.
8713         * eval.c: Sort headers.
8714         * elfread.c: Sort headers.
8715         * dwarf2read.h: Sort headers.
8716         * dwarf2read.c: Sort headers.
8717         * dwarf2loc.c: Sort headers.
8718         * dwarf2expr.h: Sort headers.
8719         * dwarf2expr.c: Sort headers.
8720         * dwarf2-frame.c: Sort headers.
8721         * dwarf2-frame-tailcall.c: Sort headers.
8722         * dwarf-index-write.h: Sort headers.
8723         * dwarf-index-write.c: Sort headers.
8724         * dwarf-index-common.c: Sort headers.
8725         * dwarf-index-cache.h: Sort headers.
8726         * dwarf-index-cache.c: Sort headers.
8727         * dummy-frame.c: Sort headers.
8728         * dtrace-probe.c: Sort headers.
8729         * disasm.h: Sort headers.
8730         * disasm.c: Sort headers.
8731         * disasm-selftests.c: Sort headers.
8732         * dictionary.c: Sort headers.
8733         * dicos-tdep.c: Sort headers.
8734         * demangle.c: Sort headers.
8735         * dcache.h: Sort headers.
8736         * dcache.c: Sort headers.
8737         * darwin-nat.h: Sort headers.
8738         * darwin-nat.c: Sort headers.
8739         * darwin-nat-info.c: Sort headers.
8740         * d-valprint.c: Sort headers.
8741         * d-namespace.c: Sort headers.
8742         * d-lang.c: Sort headers.
8743         * ctf.c: Sort headers.
8744         * csky-tdep.c: Sort headers.
8745         * csky-linux-tdep.c: Sort headers.
8746         * cris-tdep.c: Sort headers.
8747         * cris-linux-tdep.c: Sort headers.
8748         * cp-valprint.c: Sort headers.
8749         * cp-support.c: Sort headers.
8750         * cp-namespace.c: Sort headers.
8751         * cp-abi.c: Sort headers.
8752         * corelow.c: Sort headers.
8753         * corefile.c: Sort headers.
8754         * continuations.c: Sort headers.
8755         * completer.h: Sort headers.
8756         * completer.c: Sort headers.
8757         * complaints.c: Sort headers.
8758         * coffread.c: Sort headers.
8759         * coff-pe-read.c: Sort headers.
8760         * cli-out.h: Sort headers.
8761         * cli-out.c: Sort headers.
8762         * charset.c: Sort headers.
8763         * c-varobj.c: Sort headers.
8764         * c-valprint.c: Sort headers.
8765         * c-typeprint.c: Sort headers.
8766         * c-lang.c: Sort headers.
8767         * buildsym.c: Sort headers.
8768         * buildsym-legacy.c: Sort headers.
8769         * build-id.h: Sort headers.
8770         * build-id.c: Sort headers.
8771         * btrace.c: Sort headers.
8772         * bsd-uthread.c: Sort headers.
8773         * breakpoint.h: Sort headers.
8774         * breakpoint.c: Sort headers.
8775         * break-catch-throw.c: Sort headers.
8776         * break-catch-syscall.c: Sort headers.
8777         * break-catch-sig.c: Sort headers.
8778         * blockframe.c: Sort headers.
8779         * block.c: Sort headers.
8780         * bfin-tdep.c: Sort headers.
8781         * bfin-linux-tdep.c: Sort headers.
8782         * bfd-target.c: Sort headers.
8783         * bcache.c: Sort headers.
8784         * ax-general.c: Sort headers.
8785         * ax-gdb.h: Sort headers.
8786         * ax-gdb.c: Sort headers.
8787         * avr-tdep.c: Sort headers.
8788         * auxv.c: Sort headers.
8789         * auto-load.c: Sort headers.
8790         * arm-wince-tdep.c: Sort headers.
8791         * arm-tdep.c: Sort headers.
8792         * arm-symbian-tdep.c: Sort headers.
8793         * arm-pikeos-tdep.c: Sort headers.
8794         * arm-obsd-tdep.c: Sort headers.
8795         * arm-nbsd-tdep.c: Sort headers.
8796         * arm-nbsd-nat.c: Sort headers.
8797         * arm-linux-tdep.c: Sort headers.
8798         * arm-linux-nat.c: Sort headers.
8799         * arm-fbsd-tdep.c: Sort headers.
8800         * arm-fbsd-nat.c: Sort headers.
8801         * arm-bsd-tdep.c: Sort headers.
8802         * arch-utils.c: Sort headers.
8803         * arc-tdep.c: Sort headers.
8804         * arc-newlib-tdep.c: Sort headers.
8805         * annotate.h: Sort headers.
8806         * annotate.c: Sort headers.
8807         * amd64-windows-tdep.c: Sort headers.
8808         * amd64-windows-nat.c: Sort headers.
8809         * amd64-tdep.c: Sort headers.
8810         * amd64-sol2-tdep.c: Sort headers.
8811         * amd64-obsd-tdep.c: Sort headers.
8812         * amd64-obsd-nat.c: Sort headers.
8813         * amd64-nbsd-tdep.c: Sort headers.
8814         * amd64-nbsd-nat.c: Sort headers.
8815         * amd64-nat.c: Sort headers.
8816         * amd64-linux-tdep.c: Sort headers.
8817         * amd64-linux-nat.c: Sort headers.
8818         * amd64-fbsd-tdep.c: Sort headers.
8819         * amd64-fbsd-nat.c: Sort headers.
8820         * amd64-dicos-tdep.c: Sort headers.
8821         * amd64-darwin-tdep.c: Sort headers.
8822         * amd64-bsd-nat.c: Sort headers.
8823         * alpha-tdep.c: Sort headers.
8824         * alpha-obsd-tdep.c: Sort headers.
8825         * alpha-nbsd-tdep.c: Sort headers.
8826         * alpha-mdebug-tdep.c: Sort headers.
8827         * alpha-linux-tdep.c: Sort headers.
8828         * alpha-linux-nat.c: Sort headers.
8829         * alpha-bsd-tdep.c: Sort headers.
8830         * alpha-bsd-nat.c: Sort headers.
8831         * aix-thread.c: Sort headers.
8832         * agent.c: Sort headers.
8833         * addrmap.c: Sort headers.
8834         * ada-varobj.c: Sort headers.
8835         * ada-valprint.c: Sort headers.
8836         * ada-typeprint.c: Sort headers.
8837         * ada-tasks.c: Sort headers.
8838         * ada-lang.c: Sort headers.
8839         * aarch64-tdep.c: Sort headers.
8840         * aarch64-ravenscar-thread.c: Sort headers.
8841         * aarch64-newlib-tdep.c: Sort headers.
8842         * aarch64-linux-tdep.c: Sort headers.
8843         * aarch64-linux-nat.c: Sort headers.
8844         * aarch64-fbsd-tdep.c: Sort headers.
8845         * aarch64-fbsd-nat.c: Sort headers.
8846         * aarch32-linux-nat.c: Sort headers.
8847
8848 2019-04-04  Tom Tromey  <tom@tromey.com>
8849
8850         * varobj.c (varobj_create): Update.
8851         * rust-exp.y (struct rust_parser) <update_innermost_block,
8852         lookup_symbol>: New methods.
8853         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8854         Rename.
8855         (rust_parser::rust_lookup_type)
8856         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8857         * printcmd.c (display_command, do_one_display): Update.
8858         * parser-defs.h (struct parser_state) <parser_state>: Add
8859         "tracker" parameter.
8860         (block_tracker): New member.
8861         (class innermost_block_tracker) <innermost_block_tracker>: Add
8862         "types" parameter.
8863         <reset>: Remove method.
8864         (innermost_block): Don't declare.
8865         (null_post_parser): Update.
8866         * parse.c (innermost_block): Remove global.
8867         (write_dollar_variable): Update.
8868         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8869         Remove "tracker_types" parameter.
8870         (parse_expression): Add "tracker" parameter.
8871         (parse_expression_for_completion): Update.
8872         (null_post_parser): Add "tracker" parameter.
8873         * p-exp.y: Update rules.
8874         * m2-exp.y: Update rules.
8875         * language.h (struct language_defn) <la_post_parser>: Add
8876         "tracker" parameter.
8877         * go-exp.y: Update rules.
8878         * f-exp.y: Update rules.
8879         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8880         parameter.
8881         * d-exp.y: Update rules.
8882         * c-exp.y: Update rules.
8883         * breakpoint.c (set_breakpoint_condition): Create an
8884         innermost_block_tracker.
8885         (watch_command_1): Likewise.
8886         * ada-lang.c (resolve): Add "tracker" parameter.
8887         (resolve_subexp): Likewise.
8888         * ada-exp.y (write_var_from_sym): Update.
8889
8890 2019-04-04  Tom Tromey  <tom@tromey.com>
8891
8892         * type-stack.h: New file.
8893         * type-stack.c: New file.
8894         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8895         type-stack.h.
8896         (insert_into_type_stack, insert_type, push_type, push_type_int)
8897         (insert_type_address_space, pop_type, pop_type_int)
8898         (pop_typelist, pop_type_stack, append_type_stack)
8899         (push_type_stack, get_type_stack, push_typelist)
8900         (follow_type_instance_flags, follow_types): Don't declare.
8901         * parse.c (type_stack): Remove global.
8902         (parse_exp_in_context): Update.
8903         (insert_into_type_stack, insert_type, push_type, push_type_int)
8904         (insert_type_address_space, pop_type, pop_type_int)
8905         (pop_typelist, pop_type_stack, append_type_stack)
8906         (push_type_stack, get_type_stack, push_typelist)
8907         (follow_type_instance_flags, follow_types): Remove (moved to
8908         type-stack.c).
8909         * f-exp.y (type_stack): New global.
8910         Update rules.
8911         (push_kind_type, f_parse): Update.
8912         * d-exp.y (type_stack): New global.
8913         Update rules.
8914         (d_parse): Update.
8915         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8916         Update rules.
8917         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8918         (HFILES_NO_SRCDIR): Add type-stack.h.
8919
8920 2019-04-04  Tom Tromey  <tom@tromey.com>
8921
8922         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8923         (rust_parser::convert_ast_to_expression, rust_parse)
8924         (rust_lex_test_completion, rust_lex_tests): Update.
8925         * parser-defs.h (struct expr_completion_state): New.
8926         (struct parser_state) <parser_state>: Add completion parameter.
8927         <mark_struct_expression, mark_completion_tag>: New methods.
8928         <parse_completion, m_completion_state>: New members.
8929         (prefixify_expression, null_post_parser): Update.
8930         (mark_struct_expression, mark_completion_tag): Don't declare.
8931         * parse.c (parse_completion, expout_last_struct)
8932         (expout_tag_completion_type, expout_completion_name): Remove
8933         globals.
8934         (parser_state::mark_struct_expression)
8935         (parser_state::mark_completion_tag): Now methods.
8936         (prefixify_expression): Add last_struct parameter.
8937         (prefixify_subexp): Likewise.
8938         (parse_exp_1): Update.
8939         (parse_exp_in_context): Add cstate parameter.  Update.
8940         (parse_expression_for_completion): Create an
8941         expr_completion_state.
8942         (null_post_parser): Add "completion" parameter.
8943         * p-exp.y: Update rules.
8944         (yylex): Update.
8945         * language.h (struct language_defn) <la_post_parser>: Add
8946         "completing" parameter.
8947         * go-exp.y: Update rules.
8948         (lex_one_token): Update.
8949         * expression.h (parse_completion): Don't declare.
8950         * d-exp.y: Update rules.
8951         (lex_one_token): Update rules.
8952         * c-exp.y: Update rules.
8953         (lex_one_token): Update.
8954         * ada-lang.c (resolve): Add "parse_completion" parameter.
8955         (resolve_subexp): Likewise.
8956         (ada_resolve_function): Likewise.
8957
8958 2019-04-04  Tom Tromey  <tom@tromey.com>
8959
8960         * parser-defs.h (struct parser_state) <start_arglist,
8961         end_arglist>: New methods.
8962         <arglist_len, m_funcall_chain>: New members.
8963         (arglist_len, start_arglist, end_arglist): Don't declare.
8964         * parse.c (arglist_len, funcall_chain): Remove global.
8965         (start_arglist, end_arglist): Remove functions.
8966         (parse_exp_in_context): Update.
8967         * p-exp.y: Update rules.
8968         * m2-exp.y: Update rules.
8969         * go-exp.y: Update rules.
8970         * f-exp.y: Update rules.
8971         * d-exp.y: Update rules.
8972         * c-exp.y: Update rules.
8973
8974 2019-04-04  Tom Tromey  <tom@tromey.com>
8975
8976         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8977         lex_operator, push_back>: New methods.
8978         Update all rules.
8979         (rust_parser::lex_hex, lex_escape): Rename and update.
8980         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8981         (rust_parser::lex_operator): Rename and update.
8982         (rust_parser::lex_number, rustyylex, rustyyerror)
8983         (rust_lex_test_init, rust_lex_test_sequence)
8984         (rust_lex_test_push_back, rust_lex_tests): Update.
8985         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8986         parameter.
8987         <lexptr, prev_lexptr>: New members.
8988         (lexptr, prev_lexptr): Don't declare.
8989         * parse.c (lexptr, prev_lexptr): Remove globals.
8990         (parse_exp_in_context): Update.
8991         * p-exp.y (yylex, yyerror): Update.
8992         * m2-exp.y (parse_number, yylex, yyerror): Update.
8993         * go-exp.y (lex_one_token, yyerror): Update.
8994         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8995         * d-exp.y (lex_one_token, yyerror): Update.
8996         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8997         (lex_one_token, yyerror): Update.
8998         * ada-lex.l (YY_INPUT): Update.
8999         (rewind_to_char): Update.
9000         * ada-exp.y (yyerror): Update.
9001
9002 2019-04-04  Tom Tromey  <tom@tromey.com>
9003
9004         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9005         * parser-defs.h (struct parser_state) <parser_state>: Add new
9006         parameter.
9007         <comma_terminates>: New member.
9008         (comma_terminates): Don't declare global.
9009         * parse.c (comma_terminates): Remove global.
9010         (parse_exp_in_context): Update.
9011         * p-exp.y (yylex): Update.
9012         * m2-exp.y (yylex): Update.
9013         * go-exp.y (lex_one_token): Update.
9014         * f-exp.y (yylex): Update.
9015         * d-exp.y (lex_one_token): Update.
9016         * c-exp.y (lex_one_token): Update.
9017         * ada-lex.l: Update.
9018
9019 2019-04-04  Tom Tromey  <tom@tromey.com>
9020
9021         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9022         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9023         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9024         * parser-defs.h (paren_depth): Don't declare.
9025         * parse.c (paren_depth): Remove global.
9026         (parse_exp_in_context): Update.
9027         * p-exp.y (paren_depth): New global.
9028         (pascal_parse): Initialize it.
9029         * m2-exp.y (paren_depth): New global.
9030         (m2_parse): Initialize it.
9031         * go-exp.y (paren_depth): New global.
9032         (go_parse): Initialize it.
9033         * f-exp.y (paren_depth): New global.
9034         (f_parse): Initialize it.
9035         * d-exp.y (paren_depth): New global.
9036         (d_parse): Initialize it.
9037         * c-exp.y (paren_depth): New global.
9038         (c_parse): Initialize it.
9039         * ada-lex.l (paren_depth): New global.
9040         (lexer_init): Initialize it.
9041
9042 2019-04-04  Tom Tromey  <tom@tromey.com>
9043
9044         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9045         (rust_parser::convert_ast_to_type)
9046         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9047         * parser-defs.h (struct parser_state) <parser_state>: Add
9048         parameters.  Initialize new members.
9049         <expression_context_block, expression_context_pc>: New members.
9050         * parse.c (expression_context_block, expression_context_pc):
9051         Remove globals.
9052         (parse_exp_in_context): Update.
9053         * p-exp.y: Update all rules.
9054         (yylex): Update.
9055         * m2-exp.y: Update all rules.
9056         (yylex): Update.
9057         * go-exp.y (yylex): Update.
9058         * f-exp.y (yylex): Update.
9059         * d-exp.y: Update all rules.
9060         (yylex): Update.
9061         * c-exp.y: Update all rules.
9062         (lex_one_token, classify_name, yylex, c_parse): Update.
9063         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9064
9065 2019-04-04  Tom Tromey  <tom@tromey.com>
9066
9067         * gdbarch.h, gdbarch.c: Rebuild.
9068         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9069         * stap-probe.h:
9070         (struct stap_parse_info): Replace "parser_state" with
9071         "expr_builder".
9072         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9073         (parser_state): New class.
9074         * parse.c (expr_builder): Rename.
9075         (expr_builder::release): Rename.
9076         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9077         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9078         (write_exp_elt_longcst, write_exp_elt_floatcst)
9079         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9080         (write_exp_string_vector, write_exp_bitstring)
9081         (write_exp_msymbol, mark_struct_expression)
9082         (write_dollar_variable)
9083         (insert_type_address_space, increase_expout_size): Replace
9084         "parser_state" with "expr_builder".
9085         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9086         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9087         "parser_state" with "expr_builder".
9088
9089 2019-04-04  Tom Tromey  <tom@tromey.com>
9090
9091         * rust-exp.y: Replace "parse_language" with method call.
9092         * p-exp.y:
9093         (yylex): Replace "parse_language" with method call.
9094         * m2-exp.y:
9095         (yylex): Replace "parse_language" with method call.
9096         * go-exp.y (classify_name): Replace "parse_language" with method
9097         call.
9098         * f-exp.y (yylex): Replace "parse_language" with method call.
9099         * d-exp.y (lex_one_token): Replace "parse_language" with method
9100         call.
9101         * c-exp.y:
9102         (lex_one_token, classify_name, yylex): Replace "parse_language"
9103         with method call.
9104         * ada-exp.y (find_primitive_type, type_char)
9105         (type_system_address): Replace "parse_language" with method call.
9106
9107 2019-04-04  Tom Tromey  <tom@tromey.com>
9108
9109         * rust-exp.y: Replace "parse_gdbarch" with method call.
9110         * parse.c (write_dollar_variable, insert_type_address_space):
9111         Replace "parse_gdbarch" with method call.
9112         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9113         call.
9114         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9115         call.
9116         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9117         "parse_gdbarch" with method call.
9118         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9119         with method call.
9120         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9121         "parse_gdbarch" with method call.
9122         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9123         "parse_gdbarch" with method call.
9124         * c-exp.y (parse_type, parse_number, classify_name): Replace
9125         "parse_gdbarch" with method call.
9126         * ada-lex.l: Replace "parse_gdbarch" with method call.
9127         * ada-exp.y (parse_type, find_primitive_type, type_char)
9128         (type_system_address): Replace "parse_gdbarch" with method call.
9129
9130 2019-04-04  Tom Tromey  <tom@tromey.com>
9131
9132         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9133         * stap-probe.c (stap_parse_argument): Update.
9134         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9135         initial_size parameter.
9136         * rust-exp.y (rust_lex_tests): Update.
9137         * parse.c (parser_state): Update.
9138         (parse_exp_in_context): Update.
9139         * parser-defs.h (struct parser_state) <parser_state>: Remove
9140         "initial_size" parameter.
9141
9142 2019-04-04  Tom Tromey  <tom@tromey.com>
9143
9144         * parser-defs.h (increase_expout_size): Don't declare.
9145         * parse.c (increase_expout_size): Now static.
9146
9147 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9148
9149         * gnu-nat.c (gnu_nat_target::wait): Fix
9150         target_waitstatus_to_string call.
9151
9152 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9153
9154         * eval.c (evaluate_subexp_standard): Handle internal functions
9155         during Fortran function call handling.
9156
9157 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9158
9159         * NEWS: Mention new internal functions.
9160         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9161         (read_base_type): Use dwarf2_init_complex_target_type.
9162         * value.c (creal_internal_fn): New function.
9163         (cimag_internal_fn): New function.
9164         (_initialize_values): Register new internal functions.
9165
9166 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9167
9168         * infrun.c (stop_all_threads): If debug_infrun, always
9169         trace the wait status after wait_one, using
9170         target_waitstatus_to_string and target_pid_to_str.
9171         (handle_inferior_event): Replace various trace of
9172         wait status kind by a single trace.
9173         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9174         wait status kind image by target_waitstatus_to_string.
9175         * target/waitstatus.c (target_waitstatus_to_string): Fix
9176         obsolete comment.
9177
9178 2019-04-01  Tom Tromey  <tromey@adacore.com>
9179
9180         PR symtab/23331:
9181         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9182
9183 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9184             Pedro Alves  <palves@redhat.com>
9185
9186         * top.c (quit_force): Call 'finalize_values'.
9187         * value.c (finalize_values): New function.
9188         * value.h (finalize_values): Declare.
9189
9190 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9191
9192         * NEWS: Announce $_gdb_major and $_gdb_minor.
9193
9194         * top.c (init_gdb_version_vars): New function.
9195         (gdb_init): Call init_gdb_version_vars.
9196
9197 2019-03-29  Tom Tromey  <tromey@adacore.com>
9198
9199         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9200         help text.  Remove dead code.
9201
9202 2019-03-29  Keith Seitz  <keiths@redhat.com>
9203
9204         From Siddhesh Poyarekar:
9205         * f-lang.h (f77_get_upperbound): Return LONGEST.
9206         (f77_get_lowerbound): Likewise.
9207         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9208         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9209         print them.
9210         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9211         plongest to format print it.
9212         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9213         (f77_get_upperbound): Likewise.
9214         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9215         LOWER_BOUND to LONGEST.
9216         (f77_create_arrayprint_offset_tbl): Likewise.
9217
9218 2019-03-29  Keith Seitz  <keiths@redhat.com>
9219
9220         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9221         %s/pulongest for TYPE_LENGTH instead of %d in format
9222         strings.
9223         * ada-typerint.c (ada_print_type): Likewise.
9224         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9225         * compile/compile-c-support.c (generate_register_struct): Likewise.
9226         * gdbtypes.c (recursive_dump_type): Likewise.
9227         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9228         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9229         instead of %d in format strings.
9230         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9231         to std::min to ULONGEST.
9232         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9233         instead of %d in format strings.
9234         * tracepoint.c (info_scope_command): Likewise.
9235         * typeprint.c (print_offset_data::update)
9236         (print_offset_data::finish): Likewise.
9237         * xtensa-tdep.c (xtensa_store_return_value)
9238         (xtensa_push_dummy_call): Likewise.
9239
9240 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9241
9242         * windows-nat.c (display_selector): Fixed format specifications
9243         for 64-bit Cygwin.
9244
9245 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9246
9247         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9248
9249 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9250
9251         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9252         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9253         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9254         (nios2_linux_init_abi): Install it.
9255
9256 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9257
9258         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9259
9260 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9261
9262         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9263
9264 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9265             Tom Tromey  <tromey@adacore.com>
9266
9267         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9268
9269 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9270
9271         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9272         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9273         method to compute the bounds of range types. Also print "[evaluated]"
9274         if the bounds' values come from a dynamic evaluation.
9275
9276 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9277
9278         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9279         whitespace when pretty printing is on.
9280
9281 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9282
9283         * ppc-linux-nat.c: Add include.
9284
9285 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9286
9287         * NEWS: Mention AArch64 Pointer Authentication.
9288
9289 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9290
9291         * arm-linux-nat.c: Add include.
9292
9293 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9294
9295         * source-cache.c (source_cache::get_source_lines): Re-read
9296         fullname after calling open_source_file.
9297
9298 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9299
9300         * NEWS: Mention TLS support for FreeBSD.
9301
9302 2019-03-25  Tom Tromey  <tromey@adacore.com>
9303
9304         * minsyms.c (BUNCH_SIZE): Update comment.
9305         (~minimal_symbol_reader): Remove old comment.
9306         (compact_minimal_symbols): Update comment.
9307         (minimal_symbol_reader::install): Remove old comment.  Update
9308         other comments.
9309
9310 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9311
9312         * s390-linux-nat.c: Add include.
9313
9314 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9315
9316         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9317         Call linux_get_hwcap.
9318         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9319         Likewise.
9320         (aarch64_linux_get_hwcap): Remove function.
9321         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9322         declaration.
9323         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9324         linux_get_hwcap.
9325         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9326         * linux-tdep.c (linux_get_hwcap): Add function.
9327         (linux_get_hwcap2): Likewise.
9328         * linux-tdep.h (linux_get_hwcap): Add declaration.
9329         (linux_get_hwcap2): Likewise.
9330         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9331         (ppc_linux_get_hwcap2): Likewise.
9332         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9333         linux_get_hwcap.
9334         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9335         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9336         (ppc_linux_nat_target::read_description): Likewise.
9337         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9338         * s390-linux-nat.c: Likewise.
9339         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9340
9341 2019-03-24  Tom Tromey  <tom@tromey.com>
9342
9343         * ada-lang.c (standard_lookup): Simplify initialization.
9344         (ada_lookup_symbol_nonlocal): Simplify return.
9345         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9346         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9347         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9348         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9349         initialization.
9350         * solib.c (solib_global_lookup): Simplify.
9351         * symtab.c (null_block_symbol): Remove.
9352         (symbol_cache_lookup): Simplify returns.
9353         (lookup_language_this): Simplify returns.
9354         (lookup_symbol_aux): Simplify return.
9355         (lookup_local_symbol): Simplify returns.
9356         (lookup_global_symbol_from_objfile): Simplify return.
9357         (lookup_symbol_in_objfile_symtabs)
9358         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9359         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9360         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9361         * cp-namespace.c (cp_lookup_bare_symbol)
9362         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9363         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9364         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9365         (cp_lookup_symbol_via_imports): Simplify initialization.
9366         (find_symbol_in_baseclass): Likewise.
9367         * symtab.h (null_block_symbol): Remove.
9368         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9369         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9370         (d_lookup_symbol_module): Likewise.
9371         (find_symbol_in_baseclass): Simplify initialization.
9372
9373 2019-03-24  Tom Tromey  <tom@tromey.com>
9374
9375         * expression.h: Don't include symtab.h.
9376         (struct block): Forward declare.
9377
9378 2019-03-24  Tom Tromey  <tom@tromey.com>
9379
9380         * c-exp.y (typebase): Remove casts.
9381         * gdbtypes.c (lookup_unsigned_typename, )
9382         (lookup_signed_typename): Remove cast.
9383         * eval.c (parse_to_comma_and_eval): Remove cast.
9384         * parse.c (write_dollar_variable): Remove cast.
9385         * block.h (struct block) <superblock>: Now const.
9386         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9387         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9388         (map_block): Make "block" const.
9389         * symfile.h (struct quick_symbol_functions)
9390         <map_matching_symbols>: Constify block argument to "callback".
9391         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9392         const.
9393         (find_pc_sect_compunit_symtab): Make "b" const.
9394         (find_symbol_at_address): Likewise.
9395         (search_symbols): Likewise.
9396         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9397         (dw2_debug_names_lookup_symbol): Likewise.
9398         (dw2_map_matching_symbols): Update.
9399         * p-valprint.c (pascal_val_print): Remove "block".
9400         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9401         (aux_add_nonlocal_symbols): Make "block" const.
9402         (resolve_subexp): Remove cast.
9403         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9404         const.
9405         (iterate_over_file_blocks): Likewise.
9406         * f-exp.y (%union) <bval>: Remove.
9407         * coffread.c (patch_opaque_types): Make "b" const.
9408         * spu-tdep.c (spu_catch_start): Make "block" const.
9409         * c-valprint.c (print_unpacked_pointer): Remove "block".
9410         * symmisc.c (dump_symtab_1): Make "b" const.
9411         (block_depth): Make "block" const.
9412         * d-exp.y (%union) <bval>: Remove.
9413         * cp-support.h (cp_lookup_rtti_type): Update.
9414         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9415         * psymtab.c (psym_lookup_symbol): Make "block" const.
9416         (maintenance_check_psymtabs): Make "b" const.
9417         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9418         (enumerate_locals, enumerate_args): Update.
9419         * python/py-symtab.c (stpy_global_block): Make "block" const.
9420         (stpy_static_block): Likewise.
9421         * inline-frame.c (block_starting_point_at): Make "new_block"
9422         const.
9423         * block.c (find_block_in_blockvector): Make return type const.
9424         (blockvector_for_pc_sect): Make "b" const.
9425         (find_block_in_blockvector): Make "b" const.
9426
9427 2019-03-23  Tom Tromey  <tom@tromey.com>
9428
9429         * varobj.c (varobj_create): Update.
9430         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9431         * printcmd.c (display_command, do_one_display): Don't reset
9432         innermost_block.
9433         * parser-defs.h (enum innermost_block_tracker_type): Move to
9434         expression.h.
9435         (innermost_block): Update comment.
9436         * parse.c (parse_exp_1): Add tracker_types parameter.
9437         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9438         tracker_types parameter.  Reset innermost_block.
9439         (parse_exp_in_context): Remove.
9440         (parse_expression_for_completion): Update.
9441         * objfiles.c (~objfile): Don't reset expression_context_block or
9442         innermost_block.
9443         * expression.h (enum innermost_block_tracker_type): Move from
9444         parser-defs.h.
9445         (parse_exp_1): Add tracker_types parameter.
9446         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9447         reset innermost_block.
9448
9449 2019-03-23  Tom Tromey  <tom@tromey.com>
9450
9451         * objfiles.h: Include bcache.h.
9452
9453 2019-03-23  Tom Tromey  <tom@tromey.com>
9454
9455         * linespec.c (get_current_search_block): Use
9456         scoped_restore_current_language.
9457         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9458
9459 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9460             Jiong Wang  <jiong.wang@arm.com>
9461
9462         * aarch64-linux-tdep.c
9463         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9464         section.
9465         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9466
9467 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9468             Jiong Wang  <jiong.wang@arm.com>
9469
9470         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9471         instructions.
9472         (aarch64_analyze_prologue_test): Add PACIASP test.
9473         (aarch64_prologue_prev_register): Unmask PC value.
9474
9475 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9476             Jiong Wang  <jiong.wang@arm.com>
9477
9478         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9479         (aarch64_dwarf2_prev_register): Unmask PC value.
9480         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9481         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9482         DW_CFA_AARCH64_negate_ra_state.
9483         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9484
9485 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9486             Jiong Wang  <jiong.wang@arm.com>
9487
9488         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9489         registers.
9490         (aarch64_pseudo_register_name): Likewise.
9491         (aarch64_pseudo_register_type): Likewise.
9492         (aarch64_pseudo_register_reggroup_p): Likewise.
9493         (aarch64_gdbarch_init): Add pauth registers.
9494         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9495         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9496         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9497         (struct gdbarch_tdep): Add regnum for ra_state.
9498
9499 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9500             Jiong Wang  <jiong.wang@arm.com>
9501
9502         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9503
9504 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9505             Jiong Wang  <jiong.wang@arm.com>
9506
9507         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9508         function.
9509         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9510         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9511         (aarch64_gdbarch_init): Add puth registers.
9512         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9513         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9514         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9515
9516 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9517             Jiong Wang  <jiong.wang@arm.com>
9518
9519         * aarch64-linux-nat.c
9520         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9521         * aarch64-linux-tdep.c
9522         (aarch64_linux_core_read_description): Likewise.
9523         (aarch64_linux_get_hwcap): New function.
9524         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9525         (aarch64_linux_get_hwcap): New declaration.
9526
9527 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9528             Jiong Wang  <jiong.wang@arm.com>
9529
9530         * aarch64-linux-nat.c
9531         (aarch64_linux_nat_target::read_description): Add pauth param.
9532         * aarch64-linux-tdep.c
9533         (aarch64_linux_core_read_description): Likewise.
9534         * aarch64-tdep.c (struct target_desc): Add in pauth.
9535         (aarch64_read_description): Add pauth param.
9536         (aarch64_gdbarch_init): Likewise.
9537         * aarch64-tdep.h (aarch64_read_description): Likewise.
9538         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9539         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9540         * features/Makefile: Add new files.
9541         * features/aarch64-pauth.c: New file.
9542         * features/aarch64-pauth.xml: New file.
9543
9544 2019-03-20  Tom Tromey  <tromey@adacore.com>
9545
9546         * infrun.c (handle_inferior_event): Rename from
9547         handle_inferior_event_1.  Create a scoped_value_mark.
9548         (handle_inferior_event): Remove.
9549
9550 2019-03-19  Tom Tromey  <tromey@adacore.com>
9551
9552         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9553         * infrun.h (print_stop_event): Add "displays" parameter.
9554         * infrun.c (print_stop_event): Add "displays" parameter.
9555
9556 2019-03-19  Pedro Alves  <palves@redhat.com>
9557
9558         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9559         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9560         to -1.  Fix TABs vs spaces.
9561         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9562         * tui/tui-out.h (tui_ui_out) Add intro comments.
9563         <m_line, m_start_of_line>: In-class initialize, and add describing
9564         comment.
9565
9566 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9567
9568         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9569         variable names.
9570         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9571
9572 2019-03-18  Pedro Alves  <palves@redhat.com>
9573             Eli Zaretskii <eliz@gnu.org>
9574
9575         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9576         m_line and m_start_of_line.
9577
9578 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9579
9580         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9581         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9582         it returns a newline.  This fixes a regression in TU mode, whereby
9583         the next line is output on the same screen line as the user input.
9584
9585 2019-03-18  Tom Tromey  <tromey@adacore.com>
9586
9587         * minsyms.c (minimal_symbol_reader::install): Remove call to
9588         obstack_blank.
9589
9590 2019-03-18  Pedro Alves  <palves@redhat.com>
9591
9592         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9593         New globals.
9594         (apply_style): New, factored out from ...
9595         (apply_ansi_escape): ... this.  Handle reverse video mode.
9596         (tui_set_reverse_mode): New function.
9597         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9598         * tui/tui-winsource.c (tui_show_source_line): Use
9599         tui_set_reverse_mode instead of setting A_STANDOUT.
9600         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9601         New setter methods.
9602
9603 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9604
9605         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9606         Handle tabs.
9607
9608 2019-03-18  Tom Tromey  <tromey@adacore.com>
9609
9610         * ada-lang.c (empty_array): Add "high" parameter.
9611         (ada_evaluate_subexp): Update.
9612
9613 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9614
9615         * unittests/string_view-selftests.c: Define
9616         _initialize_string_view_selftests unconditionally.
9617
9618 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9619
9620         PR gdb/24350
9621         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9622
9623 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9624
9625         PR gdb/24351
9626         * windows-nat.c (display_selector): Fix format specifiers.
9627
9628 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9629
9630         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9631         tui_refill_source_window instead of tui_refresh_win, to update the
9632         current execution line.  This fixes redisplay of the current line
9633         when stepping through the code with "next" or "step".
9634
9635 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9636
9637         * source-cache.c (source_cache::get_source_lines): Call
9638         find_source_lines to initialize s->nlines.  This fixes vertical
9639         scrolling of TUI source window when the DOWN arrow is pressed.
9640
9641 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9642
9643         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9644         linux-thread-db.c (_initialize_thread_db): Likewise.
9645
9646 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9647
9648         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9649         wclrtoeol in tui_show_source_line".  This reverts changes made in
9650         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9651
9652 2019-03-15  Tom Tromey  <tom@tromey.com>
9653
9654         * symtab.h (struct minimal_symbol): Derive from
9655         general_symbol_info.
9656         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9657         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9658         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9659         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9660         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9661         (MSYMBOL_SEARCH_NAME): Update.
9662         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9663         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9664         * minsyms.c (minimal_symbol_reader::record_full): Update.
9665
9666 2019-03-15  Tom Tromey  <tom@tromey.com>
9667
9668         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9669
9670 2019-03-15  Tom Tromey  <tom@tromey.com>
9671
9672         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9673         unique_xmalloc_ptr.
9674         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9675         Update.
9676         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9677         (build_minimal_symbol_hash_tables)
9678         (minimal_symbol_reader::install): Update.
9679
9680 2019-03-15  Tom Tromey  <tom@tromey.com>
9681
9682         * symtab.c (create_demangled_names_hash): Update.
9683         (symbol_set_names): Update.
9684         * objfiles.h (struct objfile_per_bfd_storage)
9685         <demangled_names_hash>: Now an htab_up.
9686         * objfiles.c (objfile_per_bfd_storage): Simplify.
9687
9688 2019-03-15  Tom Tromey  <tom@tromey.com>
9689
9690         * objfiles.h (struct objfile_per_bfd_storage): Declare
9691         destructor.
9692         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9693         New.
9694         (get_objfile_bfd_data): Use new.  Don't initialize
9695         language_of_main.
9696         (free_objfile_per_bfd_storage): Remove.
9697         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9698
9699 2019-03-15  Tom Tromey  <tom@tromey.com>
9700
9701         * symfile.c (reread_symbols): Update.
9702         * objfiles.c (objfile::objfile): Update.
9703         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9704         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9705         comment.
9706         (minimal_symbol_reader::install): Update.
9707         (terminate_minimal_symbol_table): Remove.
9708         * jit.c (jit_object_close_impl): Update.
9709
9710 2019-03-15  Tom Tromey  <tom@tromey.com>
9711
9712         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9713         initializations.
9714
9715 2019-03-15  Tom Tromey  <tom@tromey.com>
9716
9717         * objfiles.h (struct objfile_per_bfd_storage)
9718         <demangled_hash_languages>: Now a bitset.
9719         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9720         (lookup_minimal_symbol): Update.
9721
9722 2019-03-15  Tom Tromey  <tom@tromey.com>
9723
9724         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9725         Don't return the symbol.
9726         * coffread.c (record_minimal_symbol): Use record_full.
9727
9728 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9729
9730         The MS-Windows port of ncurses fails to switch to a color pair if
9731         one or both of the colors are the implicit default colors.  This
9732         change records the default colors when TUI is initialized, and
9733         then specifies them explicitly when a color pair uses the default
9734         colors.  This allows color styling in TUI mode on MS-Windows.
9735
9736         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9737         ncurses_norm_attr.
9738         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9739         colors in ncurses_norm_attr.
9740         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9741         "none", replace it with the default color recorded in
9742         ncurses_norm_attr.
9743
9744 2019-03-14  Tom Tromey  <tromey@adacore.com>
9745
9746         * source-cache.h (class source_cache) <get_source_lines>: Return
9747         std::string.
9748         * source-cache.c (source_cache::extract_lines): Handle case where
9749         first_pos==npos.  Return std::string.
9750         (source_cache::get_source_lines): Update.
9751
9752 2019-03-14  Tom Tromey  <tromey@adacore.com>
9753
9754         * NEWS: Add item for "style sources" commands.
9755         * source-cache.c (source_cache::get_source_lines): Check
9756         source_styling.
9757         * cli/cli-style.c (source_styling): New global.
9758         (_initialize_cli_style): Add "style sources" commands.
9759         (show_style_sources): New function.
9760         * cli/cli-style.h (source_styling): Declare.
9761
9762 2019-03-14  Pedro Alves  <palves@redhat.com>
9763             Tom Tromey  <tromey@adacore.com>
9764
9765         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9766         * tui/tui-winsource.c (tui_refill_source_window): New function,
9767         from...
9768         (tui_horizontal_source_scroll): ... here.  Move some logic.
9769         * cli/cli-style.c (set_style_enabled): Notify new observable.
9770         * tui/tui-hooks.c (tui_redisplay_source): New function.
9771         (tui_attach_detach_observers): Attach or detach
9772         tui_redisplay_source.
9773         * observable.h (source_styling_changed): New observable.
9774         * observable.c: Define source_styling_changed observable.
9775
9776 2019-03-13  Tom Tromey  <tromey@adacore.com>
9777
9778         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9779         (i386_gnu_nat_target::store_registers): Update.
9780         * target-debug.h (target_debug_print_std_string): New macro.
9781         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9782         * windows-tdep.c (display_one_tib): Update.
9783         * tui/tui-stack.c (tui_make_status_line): Update.
9784         * top.c (print_inferior_quit_action): Update.
9785         * thread.c (thr_try_catch_cmd): Update.
9786         (add_thread_with_info): Update.
9787         (thread_target_id_str): Update.
9788         (thr_try_catch_cmd): Update.
9789         (thread_command): Update.
9790         (thread_find_command): Update.
9791         * record-btrace.c (record_btrace_target::info_record)
9792         (record_btrace_resume_thread, record_btrace_target::resume)
9793         (record_btrace_cancel_resume, record_btrace_step_thread)
9794         (record_btrace_target::wait, record_btrace_target::wait)
9795         (record_btrace_target::wait, record_btrace_target::stop): Update.
9796         * progspace.c (print_program_space): Update.
9797         * process-stratum-target.c
9798         (process_stratum_target::thread_address_space): Update.
9799         * linux-fork.c (linux_fork_mourn_inferior)
9800         (detach_checkpoint_command, info_checkpoints_command)
9801         (linux_fork_context): Update.
9802         (linux_fork_detach): Update.
9803         (class scoped_switch_fork_info): Update.
9804         (delete_checkpoint_command): Update.
9805         * infrun.c (follow_fork_inferior): Update.
9806         (follow_fork_inferior): Update.
9807         (proceed_after_vfork_done): Update.
9808         (handle_vfork_child_exec_or_exit): Update.
9809         (follow_exec): Update.
9810         (displaced_step_prepare_throw): Update.
9811         (displaced_step_restore): Update.
9812         (start_step_over): Update.
9813         (resume_1): Update.
9814         (clear_proceed_status_thread): Update.
9815         (proceed): Update.
9816         (print_target_wait_results): Update.
9817         (do_target_wait): Update.
9818         (context_switch): Update.
9819         (stop_all_threads): Update.
9820         (restart_threads): Update.
9821         (finish_step_over): Update.
9822         (handle_signal_stop): Update.
9823         (switch_back_to_stepped_thread): Update.
9824         (keep_going_pass_signal): Update.
9825         (print_exited_reason): Update.
9826         (normal_stop): Update.
9827         * inferior.c (inferior_pid_to_str): Change return type.
9828         (print_selected_inferior): Update.
9829         (add_inferior): Update.
9830         (detach_inferior): Update.
9831         * dummy-frame.c (fprint_dummy_frames): Update.
9832         * dcache.c (dcache_info_1): Update.
9833         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9834         (btrace_fetch, btrace_clear): Update.
9835         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9836         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9837         type.
9838         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9839         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9840         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9841         * gdbarch.c, gdbarch.h: Rebuild.
9842         * gdbarch.sh (core_pid_to_str): Change return type.
9843         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9844         return type.
9845         (windows_nat_target::pid_to_str): Change return type.
9846         (windows_delete_thread): Update.
9847         (windows_nat_target::attach): Update.
9848         (windows_nat_target::files_info): Update.
9849         * target-delegates.c: Rebuild.
9850         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9851         return type.
9852         (sol_thread_target::pid_to_str): Change return type.
9853         * remote.c (class remote_target) <pid_to_str>: Change return
9854         type.
9855         (remote_target::pid_to_str): Change return type.
9856         (extended_remote_target::attach, remote_target::remote_stop_ns)
9857         (remote_target::remote_notif_remove_queued_reply)
9858         (remote_target::push_stop_reply, remote_target::disable_btrace):
9859         Update.
9860         (extended_remote_target::attach): Update.
9861         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9862         type.
9863         (gdbsim_target::pid_to_str): Change return type.
9864         * ravenscar-thread.c (struct ravenscar_thread_target)
9865         <pid_to_str>: Change return type.
9866         (ravenscar_thread_target::pid_to_str): Change return type.
9867         * procfs.c (class procfs_target) <pid_to_str>: Change return
9868         type.
9869         (procfs_target::pid_to_str): Change return type.
9870         (procfs_target::attach): Update.
9871         (procfs_target::detach): Update.
9872         (procfs_target::fetch_registers): Update.
9873         (procfs_target::store_registers): Update.
9874         (procfs_target::wait): Update.
9875         (procfs_target::files_info): Update.
9876         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9877         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9878         return type.
9879         (nto_procfs_target::pid_to_str): Change return type.
9880         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9881         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9882         return type.
9883         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9884         (exit_lwp): Update.
9885         (attach_proc_task_lwp_callback, get_detach_signal)
9886         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9887         (linux_nat_target::resume, wait_lwp, stop_callback)
9888         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9889         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9890         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9891         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9892         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9893         type.
9894         (inf_ptrace_target::attach): Update.
9895         (inf_ptrace_target::files_info): Update.
9896         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9897         type.
9898         (go32_nat_target::pid_to_str): Change return type.
9899         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9900         (gnu_nat_target::wait): Update.
9901         (gnu_nat_target::wait): Update.
9902         (gnu_nat_target::resume): Update.
9903         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9904         (fbsd_nat_target::wait): Update.
9905         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9906         type.
9907         (darwin_nat_target::attach): Update.
9908         * corelow.c (class core_target) <pid_to_str>: Change return type.
9909         (core_target::pid_to_str): Change return type.
9910         * target.c (normal_pid_to_str): Change return type.
9911         (default_pid_to_str): Likewise.
9912         (target_pid_to_str): Change return type.
9913         (target_translate_tls_address): Update.
9914         (target_announce_detach): Update.
9915         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9916         return type.
9917         (bsd_uthread_target::pid_to_str): Change return type.
9918         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9919         type.
9920         (bsd_kvm_target::pid_to_str): Change return type.
9921         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9922         return type.
9923         (aix_thread_target::pid_to_str): Change return type.
9924         * target.h (struct target_ops) <pid_to_str>: Change return type.
9925         (target_pid_to_str, normal_pid_to_str): Likewise.
9926         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9927         type.
9928         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9929         type.
9930         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9931         return type.
9932         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9933         type.
9934         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9935         type.
9936         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9937         return type.
9938
9939 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9940
9941         * NEWS: Mention that the new default MI version is 3.  Mention
9942         changes to the output of commands and events that deal with
9943         multi-location breakpoints.
9944         * breakpoint.c: Include "mi/mi-out.h".
9945         (print_one_breakpoint): Change output syntax if using MI version
9946         >= 3.
9947         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9948         New.
9949         (mi_multi_location_breakpoint_output_fixed): New.
9950         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9951         (mi_cmd_fix_multi_location_breakpoint_output): New.
9952         (mi_multi_location_breakpoint_output_fixed): New.
9953         * mi/mi-cmds.c (mi_cmds): Register command
9954         -fix-multi-location-breakpoint-output.
9955         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9956         interpreter "mi".
9957
9958 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9959
9960         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9961         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9962         instantiate mi_ui_out based on interpreter name.
9963         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9964         * mi/mi-main.c (mi_load_progress): Likewise.
9965
9966 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9967
9968         * NEWS: Combine separate "New targets" sections for 8.3.
9969
9970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9971
9972         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9973         (ppcfbsd_init_abi): Install gdbarch
9974         "fetch_tls_load_module_address" and "get_thread_local_address"
9975         methods.
9976
9977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9978
9979         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9980         (riscv_fbsd_init_abi): Install gdbarch
9981         "fetch_tls_load_module_address" and "get_thread_local_address"
9982         methods.
9983
9984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9985
9986         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9987         (i386fbsd_init_abi): Install gdbarch
9988         "fetch_tls_load_module_address" and "get_thread_local_address"
9989         methods.
9990
9991 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9992
9993         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9994         (amd64fbsd_init_abi): Install gdbarch
9995         "fetch_tls_load_module_address" and "get_thread_local_address"
9996         methods.
9997
9998 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9999
10000         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10001         (struct fbsd_pspace_data): New type.
10002         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10003         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10004         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10005         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10006         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10007
10008 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10009
10010         * gdbtypes.c (lookup_struct_elt): New function.
10011         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10012         * gdbtypes.h (struct struct_elt): New type.
10013         (lookup_struct_elt): New prototype.
10014
10015 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10016
10017         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10018         remove disabled code block.
10019
10020 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10021
10022         * gdbarch.sh (get_thread_local_address): New method.
10023         * gdbarch.h, gdbarch.c: Regenerate.
10024         * target.c (target_translate_tls_address): Use
10025         gdbarch_get_thread_local_address if present instead of
10026         target::get_thread_local_address.
10027
10028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10029
10030         * target.h (target::get_thread_local_address): Update comment.
10031
10032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10033
10034         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10035         objfile->separate_debug_objfile_backlink if not NULL.
10036
10037 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10038
10039         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10040         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10041         (amd64bsd_store_inferior_registers): Likewise.
10042         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10043         Enable segment base registers.
10044         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10045         PT_GETFSBASE and PT_GETGSBASE.
10046         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10047         PT_SETGSBASE.
10048         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10049         segment base registers.
10050         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10051
10052 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10053
10054         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10055         Update calls to i386_target_description to add 'segments'
10056         parameter.
10057         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10058         add segment base registers.
10059         * arch/i386.c (i386_create_target_description): Add 'segments'
10060         parameter to enable segment base registers.
10061         * arch/i386.h (i386_create_target_description): Likewise.
10062         * features/i386/32bit-segments.xml: New file.
10063         * features/i386/32bit-segments.c: Generate.
10064         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10065         call to i386_target_description to add 'segments' parameter.
10066         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10067         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10068         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10069         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10070         if feature is present.
10071         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10072         Add 'segments' parameter to call to i386_target_description.
10073         (i386_target_description): Add 'segments' parameter to enable
10074         segment base registers.
10075         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10076         to call to i386_target_description.
10077         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10078         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10079         Define I386_NUM_REGS.
10080         (i386_target_description): Add 'segments' parameter to enable
10081         segment base registers.
10082
10083 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10084
10085         PR/24325
10086         * source-cache.c: #undef open and close, to avoid unresolved
10087         externals during linking.
10088
10089 2019-03-12  Tom Tromey  <tromey@adacore.com>
10090
10091         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10092         const.  Add initializers.
10093         (_initialize_remote): Don't initialize ptid globals.
10094
10095 2019-03-12  Pedro Alves  <palves@redhat.com>
10096
10097         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10098
10099 2019-03-12  Pedro Alves  <palves@redhat.com>
10100
10101         * cp-name-parser.y (main): Remove unused 'len' variable.
10102
10103 2019-03-12  Tom Tromey  <tromey@adacore.com>
10104
10105         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10106         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10107
10108 2019-03-12  Tom Tromey  <tromey@adacore.com>
10109
10110         * linux-nat.c (iterate_over_lwps): Update.
10111         (stop_callback): Remove parameter.
10112         (stop_wait_callback, detach_callback, resume_set_callback)
10113         (select_singlestep_lwp_callback, set_ignore_sigint)
10114         (status_callback, resumed_callback, resume_clear_callback)
10115         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10116         data parameter.
10117         (linux_nat_target::detach, linux_nat_target::resume)
10118         (linux_stop_and_wait_all_lwps, select_event_lwp)
10119         (linux_nat_filter_event, linux_nat_wait_1)
10120         (linux_nat_target::kill, linux_nat_target::stop)
10121         (linux_nat_target::stop): Update.
10122         (linux_nat_resume_callback): Change type.
10123         (resume_stopped_resumed_lwps, count_events_callback)
10124         (select_event_lwp_callback): Likewise.
10125         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10126         * arm-linux-nat.c (struct update_registers_data): Remove.
10127         (update_registers_callback): Change type.
10128         (arm_linux_insert_hw_breakpoint1): Update.
10129         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10130         parameter.
10131         (x86_linux_dr_set_addr): Update.
10132         (x86_linux_dr_set_control): Update.
10133         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10134         (iterate_over_lwps): Use gdb::function_view.
10135         * nat/aarch64-linux-hw-point.c (struct
10136         aarch64_dr_update_callback_param): Remove.
10137         (debug_reg_change_callback): Change type.
10138         (aarch64_notify_debug_reg_change): Update.
10139         * s390-linux-nat.c (s390_refresh_per_info): Update.
10140
10141 2019-03-11  Tom Tromey  <tromey@adacore.com>
10142
10143         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10144         redundant assignment to "this_cu".
10145
10146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10147
10148         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10149
10150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10151
10152         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10153         from...
10154         (rank_one_type): ... this.
10155
10156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10157
10158         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10159         from...
10160         (rank_one_type): ... this.
10161
10162 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10163
10164         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10165         from...
10166         (rank_one_type): ... this.
10167
10168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10169
10170         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10171         from...
10172         (rank_one_type): ... this.
10173
10174 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10175
10176         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10177         from...
10178         (rank_one_type): ... this.
10179
10180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10181
10182         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10183         from...
10184         (rank_one_type): ... this.
10185
10186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10187
10188         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10189         from...
10190         (rank_one_type): ... this.
10191
10192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10193
10194         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10195         from...
10196         (rank_one_type): ... this.
10197
10198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10199
10200         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10201         from...
10202         (rank_one_type): ... this.
10203
10204 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10205
10206         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10207         from...
10208         (rank_one_type): ... this.
10209
10210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10211
10212         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10213         from...
10214         (rank_one_type): ... this.
10215
10216 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10217
10218         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10219         from...
10220         (rank_one_type): ... this.
10221
10222 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10223
10224         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10225         inferior-events' shows the example events.
10226
10227 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10228
10229         Support styling on native MS-Windows console
10230
10231         PR/24315
10232         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10233         on MS-Windows if $TERM is not defined.
10234
10235         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10236
10237         * posix-hdep.c (gdb_console_fputs):
10238         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10239         functions.
10240         * ui-file.h (gdb_console_fputs): Add prototype.
10241
10242         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10243         back to fputs only if the former returns zero.
10244
10245 2019-03-07  Tom Tromey  <tom@tromey.com>
10246
10247         * symmisc.c (print_symbol_bcache_statistics): Update.
10248         (print_objfile_statistics): Update.
10249         * symfile.c (allocate_symtab): Update.
10250         * stabsread.c: Don't include bcache.h.
10251         * psymtab.h (struct psymbol_bcache): Don't declare.
10252         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10253         (psymbol_bcache_init, psymbol_bcache_free)
10254         (psymbol_bcache_get_bcache): Don't declare.
10255         * psymtab.c (struct psymbol_bcache): Remove.
10256         (psymtab_storage::psymtab_storage): Update.
10257         (psymtab_storage::~psymtab_storage): Update.
10258         (psymbol_bcache_init, psymbol_bcache_free)
10259         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10260         (add_psymbol_to_bcache): Update.
10261         (allocate_psymtab): Update.
10262         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10263         macro_cache>: No longer pointers.
10264         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10265         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10266         * macrotab.c (macro_bcache): Update.
10267         * macroexp.c: Don't include bcache.h.
10268         * gdbtypes.c (check_types_worklist): Update.
10269         (types_deeply_equal): Remove TRY/CATCH.  Update.
10270         * elfread.c (elf_symtab_read): Update.
10271         * dwarf2read.c: Don't include bcache.h.
10272         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10273         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10274         (print_bcache_statistics, bcache_memory_used): Don't declare.
10275         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10276         methods.  Rename all data members.
10277         * bcache.c (struct bcache): Move to bcache.h.
10278         (bcache::expand_hash_table): Rename from expand_hash_table.
10279         (bcache): Remove.
10280         (bcache::insert): Rename from bcache_full.
10281         (bcache::compare): Rename from bcache_compare.
10282         (bcache_xmalloc): Remove.
10283         (bcache::~bcache): Rename from bcache_xfree.
10284         (bcache::print_statistics): Rename from print_bcache_statistics.
10285         (bcache::memory_used): Rename from bcache_memory_used.
10286
10287 2019-03-07  Pedro Alves  <palves@redhat.com>
10288
10289         * infrun.c (normal_stop): Also check for
10290         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10291
10292 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10293
10294         * f-lang.c (value_from_host_double): Moved to...
10295         * value.c (value_from_host_double): ...here.
10296         * value.h (value_from_host_double): Declare.
10297         * guile/scm-math.c (vlscm_convert_typed_number): Use
10298         value_from_host_double.
10299         (vlscm_convert_number): Likewise.
10300         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10301         * python/py-value.c (convert_value_from_python): Likewise.
10302
10303 2019-03-06  Tom Tromey  <tom@tromey.com>
10304
10305         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10306
10307 2019-03-06  Tom Tromey  <tom@tromey.com>
10308
10309         * utils.h (free_current_contents): Don't declare.
10310         * utils.c (free_current_contents): Remove.
10311
10312 2019-03-06  Tom Tromey  <tom@tromey.com>
10313
10314         * top.c (quit_force): Update.
10315         * main.c (captured_command_loop): Update.
10316         * common/new-op.c (operator new): Update.
10317         * common/common-exceptions.c (struct catcher)
10318         <save_cleanup_chain>: Remove member.
10319         (exceptions_state_mc_init): Update.
10320         (exception_try_scope_entry): Return nullptr.
10321         (exception_try_scope_exit, exception_rethrow)
10322         (throw_exception_sjlj, throw_exception_cxx): Update.
10323         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10324         (all_cleanups, do_cleanups, discard_cleanups)
10325         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10326         (restore_cleanups, restore_final_cleanups): Don't declare.
10327         (do_final_cleanups): Remove parameter.
10328         * common/cleanups.c (cleanup_chain, make_cleanup)
10329         (make_cleanup_dtor, all_cleanups, do_cleanups)
10330         (discard_my_cleanups, discard_cleanups)
10331         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10332         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10333         (null_cleanup): Remove.
10334         (do_final_cleanups): Remove parameter.
10335
10336 2019-03-06  Tom Tromey  <tom@tromey.com>
10337
10338         * remote.c (remote_target::remote_parse_stop_reply): Use
10339         unique_xmalloc_ptr.
10340
10341 2019-03-06  Tom Tromey  <tom@tromey.com>
10342
10343         * stabsread.c (struct stabs_field_info): Rename from field_info.
10344         <list, fnlist>: Add initializers.
10345         <obstack>: New member.
10346         (read_member_functions, read_struct_fields, read_baseclasses):
10347         Allocate on obstack.  Don't use cleanups.
10348         (read_one_struct_field, read_member_functions, read_struct_fields)
10349         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10350         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10351         (read_struct_type): Update.
10352
10353 2019-03-06  Tom Tromey  <tom@tromey.com>
10354
10355         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10356         * common/filestuff.h (make_cleanup_close): Don't declare.
10357         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10358         Remove.
10359
10360 2019-03-06  Tom Tromey  <tom@tromey.com>
10361
10362         * solib-aix.c: Use make_scope_exit.
10363
10364 2019-03-06  Tom Tromey  <tom@tromey.com>
10365
10366         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10367         Use make_scope_exit.
10368
10369 2019-03-06  Tom Tromey  <tom@tromey.com>
10370
10371         * solib-svr4.c (disable_probes_interface): Remove parameter.
10372         (svr4_handle_solib_event): Use make_scope_exit.
10373
10374 2019-03-06  Tom Tromey  <tom@tromey.com>
10375
10376         * remote.c (struct stop_reply_deleter): Remove.
10377         (stop_reply_up): Update.
10378         (struct stop_reply): Derive from notif_event.  Don't typedef.
10379         <regcache>: Now a std::vector.
10380         (stop_reply_xfree): Remove.
10381         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10382         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10383         (remote_target::discard_pending_stop_replies): Use delete.
10384         (remote_target::remote_parse_stop_reply): Update.
10385         (remote_target::process_stop_reply): Update.
10386         * remote-notif.h (struct notif_event): Add virtual destructor.
10387         Remove "dtr" member.
10388         (struct notif_client) <alloc_event>: Return a unique_ptr.
10389         (notif_event_xfree): Don't declare.
10390         (notif_event_up): New typedef.
10391         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10392         (notif_event_xfree, do_notif_event_xfree): Remove.
10393         (remote_notif_state_xfree): Update.
10394
10395 2019-03-06  Tom Tromey  <tom@tromey.com>
10396
10397         * infrun.c (displaced_step_clear_cleanup): Now a
10398         forward_scope_exit type.
10399         (displaced_step_prepare_throw): Update.
10400         (displaced_step_fixup): Update.
10401
10402 2019-03-06  Tom Tromey  <tom@tromey.com>
10403
10404         * inferior.h (class inferior): Update comment.
10405         * gdbthread.h (class thread_info): Update comment.
10406
10407 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10408             Tom Tromey  <tom@tromey.com>
10409
10410         * stabsread.h (struct stab_section_list): Remove.
10411         (coffstab_build_psymtabs): Update.
10412         * dbxread.c (symbuf_sections): Now a std::vector.
10413         (sect_idx): New global.
10414         (fill_symbuf): Update.
10415         (coffstab_build_psymtabs): Change type of stabsects parameter.
10416         Update.
10417         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10418         std::vector.
10419         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10420         (coff_locate_sections): Update.
10421         (coff_symfile_read): Remove cleanups.  Update.
10422         (init_stringtab): Add storage parameter.
10423         (free_stringtab, free_stringtab_cleanup): Remove.
10424         (init_lineno): Add storage parameter.
10425         (free_linetab, free_linetab_cleanup): Remove.
10426
10427 2019-03-06  Pedro Alves  <palves@redhat.com>
10428
10429         * linux-fork.c (fork_info::clobber_regs): Delete.
10430         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10431         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10432         comment.  Adjust.
10433         (scoped_switch_fork_info::scoped_switch_fork_info)
10434         (checkpoint_command, linux_fork_context): Adjust
10435         fork_save_infrun_state calls.
10436
10437 2019-03-06  Pedro Alves  <palves@redhat.com>
10438
10439         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10440         (inf_has_multiple_threads): Return 'bool' and rewrite using
10441         inferior_info::threads().
10442
10443 2019-03-06  Pedro Alves  <palves@redhat.com>
10444
10445         * linux-fork.c: Include <list>.
10446         (fork_list): Now a std::list instance.
10447         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10448         (forks_exist_p, find_last_fork): Adjust.
10449         (new_fork): Delete.
10450         (one_fork_p): New.
10451         (add_fork): Adjust.
10452         (free_fork): Delete, folded into fork_info::~fork_info().
10453         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10454         Adjust.
10455         (init_fork_list): Delete.
10456         (linux_fork_killall, linux_fork_mourn_inferior)
10457         (linux_fork_detach, info_checkpoints_command): Adjust.
10458         (_initialize_linux_fork): No longer call init_fork_list.
10459
10460 2019-03-06  Pedro Alves  <palves@redhat.com>
10461
10462         * linux-fork.c (new_fork): New, split out of ...
10463         (add_fork): ... this.  Return void.  Move "first fork" special
10464         case from here, to ...
10465         (checkpoint_command): ... here.
10466         * linux-linux.h (add_fork): Return void.
10467
10468 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10469
10470         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10471
10472 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10473             Chris January  <chris.january@arm.com>
10474             David Lecomber  <david.lecomber@arm.com>
10475
10476         * f-exp.y: New token, UNOP_INTRINSIC.
10477         (exp): New pattern using UNOP_INTRINSIC token.
10478         (f77_keywords): Add 'abs' keyword.
10479         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10480         (value_from_host_double): New function.
10481         (evaluate_subexp_f): Support UNOP_ABS.
10482
10483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10484
10485         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10486         types.
10487
10488 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10489
10490         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10491         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10492         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10493
10494 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10495
10496         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10497
10498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10499             Chris January  <chris.january@arm.com>
10500
10501         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10502         * f-exp.y: Define 'KIND' token.
10503         (exp): New pattern for KIND expressions.
10504         (ptype): Handle types with a kind extension.
10505         (direct_abs_decl): Extend to spot kind extensions.
10506         (f77_keywords): Add 'kind' to the list.
10507         (push_kind_type): New function.
10508         (convert_to_kind_type): New function.
10509         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10510         * parse.c (operator_length_standard): Likewise.
10511         * parser-defs.h (enum type_pieces): Add tp_kind.
10512         * std-operator.def: Add UNOP_KIND.
10513
10514 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10515
10516         * f-exp.y (f_parse): Set yydebug.
10517
10518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10519
10520         * f-lang.c (evaluate_subexp_f): New function.
10521         (exp_descriptor_f): New global.
10522         (f_language_defn): Use exp_descriptor_f instead of
10523         exp_descriptor_standard.
10524
10525 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10526
10527         * f-exp.y (struct token): Add comments.
10528         (dot_ops): Remove uppercase versions and the end marker.
10529         (f77_keywords): Likewise.
10530         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10531         entries in the dot_ops array are case insensitive, and use
10532         strncasecmp to compare strings.  Also some whitespace cleanup in
10533         this area.  Similar for the f77_keywords array, except entries in
10534         this list might be case sensitive.
10535
10536 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10537
10538         * f-exp.y (struct f77_boolean_val): Add comments.
10539         (boolean_values): Remove uppercase versions, and end marker.
10540         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10541         and use strncasecmp to achieve case insensitivity.  Additionally,
10542         perform whitespace cleanup around this code.
10543
10544 2019-03-06  Tom Tromey  <tromey@adacore.com>
10545
10546         * remote-sim.c (gdbsim_target_open): Use result of
10547         gdb_argv::release.
10548
10549 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10550         Dirk Schubert  <dirk.schubert@arm.com>
10551         Chris January  <chris.january@arm.com>
10552
10553         * eval.c (evaluate_subexp_standard): Call Fortran argument
10554         wrapping logic.
10555         * f-lang.c (struct value): A value which can be passed into a
10556         Fortran function call.
10557         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10558         where appropriate.
10559         (struct type): Value ready for a Fortran function call.
10560         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10561         is needed.
10562         * f-lang.h (fortran_argument_convert): Declaration.
10563         (fortran_preserve_arg_pointer): Declaration.
10564         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10565
10566 2019-03-05  Tom Tromey  <tromey@adacore.com>
10567
10568         * python/py-prettyprint.c (print_string_repr): Remove #if.
10569         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10570
10571 2019-03-05  Tom Tromey  <tromey@adacore.com>
10572
10573         * target.c (the_dummy_target): Move later.  Change type to
10574         "dummy_target".
10575         (initialize_targets): Don't initialize the_dummy_target.
10576
10577 2019-03-05  Tom Tromey  <tromey@adacore.com>
10578
10579         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10580         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10581
10582 2019-03-05  Tom Tromey  <tromey@adacore.com>
10583
10584         * windows-nat.c (windows_nat_target::attach)
10585         (windows_nat_target::detach): Don't call gdb_flush.
10586         * valprint.c (generic_val_print, val_print, val_print_string):
10587         Don't call gdb_flush.
10588         * utils.c (defaulted_query): Don't call gdb_flush.
10589         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10590         * target.c (target_announce_detach): Don't call gdb_flush.
10591         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10592         * remote.c (extended_remote_target::attach): Don't call
10593         gdb_flush.
10594         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10595         * printcmd.c (do_examine): Don't call gdb_flush.
10596         (info_display_command): Don't call gdb_flush.
10597         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10598         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10599         * memattr.c (info_mem_command): Don't call gdb_flush.
10600         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10601         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10602         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10603         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10604         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10605         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10606         (gnu_nat_target::detach): Don't call gdb_flush.
10607         * f-valprint.c (f_val_print): Don't call gdb_flush.
10608         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10609         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10610         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10611         gdb_flush.
10612         * c-valprint.c (c_val_print): Don't call gdb_flush.
10613         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10614
10615 2019-03-05  Tom Tromey  <tromey@adacore.com>
10616
10617         * varobj.c (update_dynamic_varobj_children): Update.
10618         (install_default_visualizer): Use reset, not release.
10619         * value.c (set_internalvar): Update.
10620         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10621         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10622         ATTRIBUTE_UNUSED_RESULT.
10623
10624 2019-03-05  Tom Tromey  <tromey@adacore.com>
10625
10626         * remote.c (class scoped_remote_fd) <release>: Add
10627         ATTRIBUTE_UNUSED_RESULT.
10628
10629 2019-03-05  Tom Tromey  <tromey@adacore.com>
10630
10631         * macroexp.c (struct macro_buffer) <release>: Add
10632         ATTRIBUTE_UNUSED_RESULT.
10633
10634 2019-03-05  Tom Tromey  <tromey@adacore.com>
10635
10636         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10637         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10638         ATTRIBUTE_UNUSED_RESULT.
10639
10640 2019-03-05  Tom Tromey  <tromey@adacore.com>
10641
10642         * common/scoped_fd.h (class scoped_fd) <release>: Add
10643         ATTRIBUTE_UNUSED_RESULT.
10644
10645 2019-03-05  Tom Tromey  <tromey@adacore.com>
10646
10647         * parser-defs.h (struct parser_state) <release>: Add
10648         ATTRIBUTE_UNUSED_RESULT.
10649
10650 2019-03-05  Tom Tromey  <tromey@adacore.com>
10651
10652         * utils.h (class gdb_argv) <release>: Add
10653         ATTRIBUTE_UNUSED_RESULT.
10654         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10655
10656 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10657
10658         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10659         for-loop range, to avoid compiler warnings.
10660
10661         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10662         avoid compiler warnings about unused variables.
10663
10664         * NEWS: Mention end of support for native debugging on MS-Windows
10665         before XP.
10666
10667         PR gdb/24292
10668         * common/netstuff.c:
10669         * gdbserver/gdbreplay.c
10670         * gdbserver/remote-utils.c:
10671         * ser-tcp.c:
10672         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10673         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10674         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10675         'getaddrinfo' and 'freeaddrinfo' were not available before
10676         Windows XP, and mingw.org's MinGW headers by default define
10677         _WIN32_WINNT to 0x500.
10678
10679 2019-03-01  Gary Benson <gbenson@redhat.com>
10680
10681         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10682
10683 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10684             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10685
10686         PR gdb/8527
10687         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10688         set_sigint_trap, clear_sigint_trap.
10689
10690 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10691
10692         * target.c (target_detach): Clear the regcache and the
10693         frame cache.
10694
10695 2019-02-27  Pedro Alves  <palves@redhat.com>
10696
10697         * utils.c (set_screen_size): When we cap the height/width sizes,
10698         tweak the corresponding command variable to show "unlimited":
10699
10700 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10701             Pedro Alves  <palves@redhat.com>
10702
10703         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10704         before calling rl_set_screen_size.
10705
10706 2019-02-27  Tom Tromey  <tromey@adacore.com>
10707
10708         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10709         define.
10710         * python/py-value.c: Remove Python 2.4 workaround.
10711         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10712         workaround.
10713         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10714         Python 2.4 workaround.
10715         * python/python-internal.h: Remove Python 2.4 comment.
10716         (Py_ssize_t): Don't define.
10717         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10718         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10719         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10720         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10721         * python/python.c (do_start_initialization): Remove Python 2.4
10722         workaround.
10723         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10724         (print_children): Remove Python 2.4 workaround.
10725         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10726         workaround.
10727         (CHARBUFFERPROC_NAME): Remove.
10728         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10729         Python 2.4 workaround.
10730
10731 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10732
10733         * NEWS: Note minimum Python version.
10734
10735 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10736
10737         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10738         code from these functions.  Remove corresponding ifdefs.  Use
10739         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10740         Remove gotos and target of gotos.
10741         (infpy_search_memory): Likewise.
10742
10743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10744
10745         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10746         (hppa_gdbarch_init): Don't register deleted functions with
10747         gdbarch.
10748
10749 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10750
10751         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10752         (h8300_unwind_sp): Delete.
10753         (h8300_dummy_id): Delete.
10754         (h8300_gdbarch_init): Don't register deleted functions with
10755         gdbarch.
10756
10757 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10758
10759         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10760         (ft32_unwind_pc): Delete.
10761         (ft32_unwind_sp): Delete.
10762         (ft32_gdbarch_init): Don't register deleted functions with
10763         gdbarch.
10764
10765 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10766
10767         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10768         (frv_unwind_pc): Delete.
10769         (frv_unwind_sp): Delete.
10770         (frv_gdbarch_init): Don't register deleted functions with
10771         gdbarch.
10772
10773 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10774
10775         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10776         (riscv_unwind_pc): Delete.
10777         (riscv_unwind_sp): Delete.
10778         (riscv_gdbarch_init): Don't register deleted functions with
10779         gdbarch.
10780
10781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10782
10783         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10784         (csky_unwind_pc): Delete.
10785         (csky_unwind_sp): Delete.
10786         (csky_gdbarch_init): Don't register deleted functions with
10787         gdbarch.
10788
10789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10790
10791         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10792         (cris_unwind_pc): Delete.
10793         (cris_unwind_sp): Delete.
10794         (cris_gdbarch_init): Don't register deleted functions with
10795         gdbarch.
10796
10797 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10798
10799         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10800         (bfin_unwind_pc): Delete.
10801         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10802
10803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10804
10805         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10806         (arm_unwind_pc): Delete.
10807         (arm_unwind_sp): Delete.
10808         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10809
10810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10811
10812         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10813         (arc_unwind_pc): Delete.
10814         (arc_unwind_sp): Delete.
10815         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10816
10817 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10818
10819         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10820         (alpha_unwind_pc): Delete.
10821         (alpha_gdbarch_init): Don't register deleted functions with
10822         gdbarch.
10823
10824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10825
10826         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10827         (aarch64_unwind_pc): Delete.
10828         (aarch64_unwind_sp): Delete.
10829         (aarch64_gdbarch_init): Don't register deleted functions with
10830         gdbarch.
10831
10832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10833
10834         * gdbtypes.c (type_align): Don't consider static members when
10835         computing structure alignment.
10836
10837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10838
10839         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10840         return 0 for other types.
10841         * arch-utils.c (default_type_align): Always return 0.
10842         * gdbarch.h: Regenerate.
10843         * gdbarch.sh (type_align): Extend comment.
10844         * gdbtypes.c (type_align): Add additional comments, always call
10845         gdbarch_type_align before applying the default rules.
10846         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10847         generic code will then apply a suitable default.
10848         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10849         types, return 0 for other types.
10850
10851 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10852
10853         * NEWS: Create a new section for the next release branch.
10854         Rename the section of the current branch, now that it has
10855         been cut.
10856
10857 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10858
10859         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10860         * version.in: Bump version to 8.3.50.DATE-git.
10861
10862 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10863
10864         * aix-thread.c (ptid_cmp): Remove unused variable.
10865         (get_signaled_thread): Likewise.
10866         (store_regs_user_thread): Likewise.
10867         (store_regs_kernel_thread): Likewise.
10868         (fetch_regs_kernel_thread): Remove shadowed variable.
10869
10870 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10871
10872         * features/riscv/32bit-cpu.xml: Add register numbers.
10873         * features/riscv/32bit-fpu.c: Regenerate.
10874         * features/riscv/32bit-fpu.xml: Add register numbers.
10875         * features/riscv/64bit-cpu.xml: Add register numbers.
10876         * features/riscv/64bit-fpu.c: Regenerate.
10877         * features/riscv/64bit-fpu.xml: Add register numbers.
10878
10879 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10880
10881         * NEWS: Mention two argument form of gdb.Value constructor.
10882         * python/py-value.c (convert_buffer_and_type_to_value): New
10883         function.
10884         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10885         Add support for handling an optional second argument.  Call
10886         convert_buffer_and_type_to_value as appropriate.
10887         * python/python-internal.h (Py_buffer_deleter): New struct.
10888         (Py_buffer_up): New typedef.
10889
10890 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10891
10892         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10893         instead of releasing ownership.
10894
10895 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10896
10897         * dwarf2read.c (open_and_init_dwp_file): Call
10898         elf_numsections instead of bfd_count_sections to initialize
10899         dwp_file->num_sections.
10900
10901 2019-02-25  Tom Tromey  <tromey@adacore.com>
10902
10903         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10904
10905 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10906
10907         * gcore.in: Add '--readnever' option when invoking GDB.
10908
10909 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10910
10911         * MAINTAINERS: Update my email address.
10912
10913 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10914
10915         * build-id.c (build_id_to_debug_bfd_1): New function.
10916         (build_id_to_debug_bfd): Look for separate debug file in
10917         sysroot.
10918
10919 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10920
10921         * gdbarch.sh: Update the copyright year range that is placed into
10922         generated files.
10923
10924 2019-02-22  Keith Seitz  <keiths@redhat.com>
10925
10926         PR symtab/23853
10927         * linespec.c (create_sals_line_offset): Search for the default
10928         symtab's filename instead of its fullname.
10929
10930 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10931
10932         * NEWS: Update style defaults.
10933
10934 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10935
10936         * main.c (captured_main_1): Disable styling in batch mode.
10937
10938 2019-02-20  Tom Tromey  <tom@tromey.com>
10939
10940         * symtab.c (symtab_symbol_info): Fix typos.
10941
10942 2019-02-20  Tom Tromey  <tromey@adacore.com>
10943
10944         * findcmd.c (_initialize_mem_search): Use upper case for
10945         metasyntactic variables.
10946
10947 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10948
10949         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10950         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10951
10952 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10953
10954         * top.h (source_file_name): Change to std::string.
10955         * top.c (source_file_name): Likewise.
10956         (command_line_input): Adjust.
10957         * cli/cli-script.c (script_from_file): Adjust.
10958
10959 2019-02-19  Tom Tromey  <tromey@adacore.com>
10960
10961         * ravenscar-thread.c
10962         (ravenscar_thread_target::update_thread_list): Don't call
10963         ada_build_task_list.
10964         * ada-lang.h (ada_build_task_list): Don't declare.
10965         * ada-tasks.c (struct ada_tasks_inferior_data)
10966         <task_list_valid_p>: Now bool.
10967         (read_known_tasks, ada_task_list_changed)
10968         (ada_tasks_invalidate_inferior_data): Update.
10969         (read_known_tasks_array): Return bool.
10970         (read_known_tasks_list): Likewise.
10971         (read_known_tasks): Return void.
10972         (ada_build_task_list): Now static.
10973
10974 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10975
10976         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10977         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10978
10979 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10980
10981         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10982         variant for ada_tasks_pspace_data_handle and
10983         ada_tasks_inferior_data_handle.
10984         (ada_tasks_pspace_data_cleanup): New function.
10985         (ada_tasks_inferior_data_cleanup): New function.
10986
10987 2019-02-17  Tom Tromey  <tom@tromey.com>
10988
10989         * macrotab.h (macro_source_fullname): Return a std::string.
10990         * macrotab.c (macro_include, check_for_redefinition)
10991         (macro_undef, macro_lookup_definition, foreach_macro)
10992         (foreach_macro_in_scope): Update.
10993         (macro_source_fullname): Return a std::string.
10994         * macrocmd.c (show_pp_source_pos): Update.
10995
10996 2019-02-17  Tom Tromey  <tom@tromey.com>
10997
10998         * macrocmd.c (show_pp_source_pos): Style the file names.
10999
11000 2019-02-17  Tom Tromey  <tom@tromey.com>
11001
11002         PR tui/24197:
11003         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11004
11005 2019-02-17  Tom Tromey  <tom@tromey.com>
11006
11007         * ada-lang.c (user_select_syms): Use filtered printing.
11008         * utils.c (wrap_style): New global.
11009         (desired_style): Remove.
11010         (emit_style_escape): Add stream parameter.
11011         (set_output_style, reset_terminal_style, prompt_for_continue):
11012         Update.
11013         (flush_wrap_buffer): Only flush gdb_stdout.
11014         (wrap_here): Set wrap_style.
11015         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11016         treat escape sequences as a character.  Change when wrap buffer is
11017         flushed.
11018         (fputs_styled): Do not set the output style when the default is
11019         requested.
11020         * ui-style.h (struct ui_file_style) <is_default>: New method.
11021         * source.c (print_source_lines_base): Emit escape sequences in one
11022         piece.
11023
11024 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11025
11026         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11027         integers and enumeration types.
11028
11029 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11030
11031         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11032         instead of lookup_symbol_in_language
11033         (do_exact_match): New function.
11034         (ada_get_symbol_name_matcher): Return do_exact_match when
11035         doing a verbatim match.
11036
11037 2019-02-15  Tom Tromey  <tromey@adacore.com>
11038
11039         * ravenscar-thread.c (ravenscar_thread_target::resume)
11040         (ravenscar_thread_target::wait): Special case wildcard requests.
11041
11042 2019-02-15  Tom Tromey  <tromey@adacore.com>
11043
11044         * ravenscar-thread.c (base_ptid): Remove.
11045         (struct ravenscar_thread_target) <close>: New method.
11046         <m_base_ptid>: New member.
11047         <update_inferior_ptid, active_task, task_is_currently_active,
11048         runtime_initialized>: Declare methods.
11049         <ravenscar_thread_target>: Add constructor.
11050         (ravenscar_thread_target::task_is_currently_active)
11051         (ravenscar_thread_target::update_inferior_ptid)
11052         (ravenscar_runtime_initialized): Rename.  Now methods.
11053         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11054         (ravenscar_thread_target::update_thread_list): Update.
11055         (ravenscar_thread_target::active_task): Now method.
11056         (ravenscar_thread_target::store_registers)
11057         (ravenscar_thread_target::prepare_to_store)
11058         (ravenscar_thread_target::prepare_to_store)
11059         (ravenscar_thread_target::mourn_inferior): Update.
11060         (ravenscar_inferior_created): Use "new" to create target.
11061         (ravenscar_thread_target::get_ada_task_ptid): Update.
11062         (_initialize_ravenscar): Don't initialize base_ptid.
11063         (ravenscar_ops): Remove global.
11064
11065 2019-02-15  Tom Tromey  <tromey@adacore.com>
11066
11067         * target.h (push_target): Declare new overload.
11068         * target.c (push_target): New overload, taking an rvalue reference.
11069         * remote.c (remote_target::open_1): Use push_target overload.
11070         * corelow.c (core_target_open): Use push_target overload.
11071
11072 2019-02-15  Tom Tromey  <tromey@adacore.com>
11073
11074         * ravenscar-thread.c (is_ravenscar_task)
11075         (ravenscar_task_is_currently_active): Return bool.
11076         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11077         (_initialize_ravenscar): Remove "(void)".
11078         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11079         Return bool.
11080
11081 2019-02-15  Tom Tromey  <tromey@adacore.com>
11082
11083         * ravenscar-thread.c (ravenscar_runtime_initializer)
11084         (has_ravenscar_runtime, get_running_thread_id)
11085         (ravenscar_thread_target::resume): Fix indentation.
11086
11087 2019-02-15  Tom Tromey  <tromey@adacore.com>
11088
11089         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11090         from ravenscar_arch_ops.
11091         (sparc_ravenscar_ops::fetch_registers)
11092         (sparc_ravenscar_ops::store_registers): Now methods.
11093         (sparc_ravenscar_prepare_to_store): Remove.
11094         (sparc_ravenscar_ops): Redefine.
11095         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11096         methods and destructor.  Remove members.
11097         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11098         (ravenscar_thread_target::store_registers)
11099         (ravenscar_thread_target::prepare_to_store): Update.
11100         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11101         Remove.
11102         (struct ppc_ravenscar_powerpc_ops): Derive from
11103         ravenscar_arch_ops.
11104         (ppc_ravenscar_powerpc_ops::fetch_registers)
11105         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11106         (ppc_ravenscar_powerpc_ops): Redefine.
11107         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11108         (ppc_ravenscar_e500_ops::fetch_registers)
11109         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11110         (ppc_ravenscar_e500_ops): Redefine.
11111         * aarch64-ravenscar-thread.c
11112         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11113         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11114         (aarch64_ravenscar_fetch_registers)
11115         (aarch64_ravenscar_store_registers): Now methods.
11116         (aarch64_ravenscar_ops): Redefine.
11117
11118 2019-02-15  Tom Tromey  <tromey@adacore.com>
11119
11120         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11121         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11122         (ravenscar_thread_target::stopped_by_watchpoint)
11123         (ravenscar_thread_target::stopped_data_address)
11124         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11125
11126 2019-02-15  Tom Tromey  <tromey@adacore.com>
11127
11128         * ravenscar-thread.c: Fix some typos.
11129
11130 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11131             Tom Tromey  <tromey@adacore.com>
11132
11133         * ada-lang.c (ada_exception_sal): Change addr_string to a
11134         std::string.
11135         (create_ada_exception_catchpoint): Update.
11136
11137 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11138             Tom Tromey  <tromey@adacore.com>
11139
11140         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11141         (bp_location_ops): Remove.
11142         (base_breakpoint_allocate_location): Update.
11143         (free_bp_location): Update.
11144         * ada-lang.c (class ada_catchpoint_location)
11145         <ada_catchpoint_location>: Remove ops parameter.
11146         (ada_catchpoint_location_dtor): Remove.
11147         (ada_catchpoint_location_ops): Remove.
11148         (allocate_location_exception): Update.
11149         * breakpoint.h (struct bp_location_ops): Remove.
11150         (class bp_location) <bp_location>: Remove bp_location_ops
11151         parameter.
11152         <~bp_location>: Add destructor.
11153         <ops>: Remove.
11154
11155 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11156             Pedro Alves  <palves@redhat.com>
11157
11158         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11159         'PATH_MAX'.
11160
11161 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11162             Samuel Thibault  <samuel.thibault@gnu.org>
11163             Thomas Schwinge  <thomas@codesourcery.com>
11164
11165         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11166         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11167
11168 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11169
11170         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11171         (check_empty): Use "const char *".
11172
11173         * gnu-nat.c (gnu_nat_target::detach): Instead of
11174         'detach_inferior (pid)' call
11175         'detach_inferior (find_inferior_pid (pid))'.
11176
11177         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11178         'nat/fork-inferior.o'.
11179         * gnu-nat.c: #include "nat/fork-inferior.h".
11180
11181         * gnu-nat.c (gnu_nat_target::detach): Instead of
11182         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11183         * gnu-nat.h: #include "inf-child.h".
11184         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11185         'i386_gnu_nat_target::fetch_registers'.
11186         (gnu_store_registers): Rename/move to
11187         'i386_gnu_nat_target::store_registers'.
11188
11189         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11190         * gnu-nat.h (mach_thread_info): New function.
11191         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11192
11193         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11194
11195 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11196
11197         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11198
11199 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11200
11201         * windows-nat.c (windows_add_thread): Add new parameter
11202         "main_thread_p" with default value set to false.  Update
11203         function documentation as well as all callers.
11204         (windows_delete_thread): Likewise.
11205         (fake_create_process): Update call to windows_add_thread.
11206         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11207         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11208         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11209         call to windows_delete_thread.
11210
11211 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11212
11213         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11214
11215 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11216
11217         * symfile.c (find_separate_debug_file): Use canonical path of
11218         sysroot with child_path instead of gdb_sysroot if it is valid.
11219
11220 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11221
11222         * symfile.c (find_separate_debug_file): Use child_path to
11223         determine if an object file is under a sysroot.
11224
11225 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11226
11227         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11228         unittests/child-path-selftests.c.
11229         * common/pathstuff.c (child_path): New function.
11230         * common/pathstuff.h (child_path): New prototype.
11231         * unittests/child-path-selftests.c: New file.
11232
11233 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11234
11235         * symfile.c (find_separate_debug_file): Look for separate debug
11236         files in debug directories under the sysroot.
11237
11238 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11239
11240         * symtab.h (struct minimal_symbol data_p): New const method.
11241         (struct minimal_symbol text_p): Likewise.
11242         * symtab.c (output_source_filename): Use file name style
11243         to print file name.
11244         (print_symbol_info): Likewise.
11245         (print_msymbol_info): Use address style to print addresses.
11246         Use function name style to print executable text symbols.
11247         (expand_symtab_containing_pc): Use data_p.
11248         (find_pc_sect_compunit_symtab): Likewise.
11249
11250 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11251
11252         * breakpoint.c (describe_other_breakpoints): Use address style
11253         to print addresses.
11254         (say_where): Likewise.
11255
11256 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11257
11258         * ada-typeprint.c (print_func_type): Print function name
11259         style to print function name.
11260         * c-typeprint.c (c_print_type_1): Likewise.
11261
11262 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11263
11264         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11265         for execve.
11266
11267 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11268
11269         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11270         type_stack.
11271
11272 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11273
11274         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11275         TYPE_CODE_REF types.
11276
11277 2019-02-08  Jim Wilson  <jimw@sifive.com>
11278
11279         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11280         (riscv_linux_fregset): New.
11281         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11282
11283 2019-02-07  Tom Tromey  <tom@tromey.com>
11284
11285         * thread.c (thread_cancel_execution_command): Update.
11286         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11287         methods.
11288         (struct thread_fsm_ops): Remove.
11289         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11290         (thread_fsm_should_stop, thread_fsm_return_value)
11291         (thread_fsm_set_finished, thread_fsm_finished_p)
11292         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11293         Don't declare.
11294         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11295         * infrun.c (clear_proceed_status_thread)
11296         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11297         (print_stop_event): Update.
11298         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11299         Add constructor.
11300         (step_command_fsm_ops): Remove.
11301         (new_step_command_fsm): Remove.
11302         (step_1): Update.
11303         (step_command_fsm::should_stop): Rename from
11304         step_command_fsm_should_stop.
11305         (step_command_fsm::clean_up): Rename from
11306         step_command_fsm_clean_up.
11307         (step_command_fsm::do_async_reply_reason): Rename from
11308         step_command_fsm_async_reply_reason.
11309         (struct until_next_fsm): Inherit from thread_fsm.  Add
11310         constructor.
11311         (until_next_fsm_ops): Remove.
11312         (new_until_next_fsm): Remove.
11313         (until_next_fsm::should_stop): Rename from
11314         until_next_fsm_should_stop.
11315         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11316         (until_next_fsm::do_async_reply_reason): Rename from
11317         until_next_fsm_async_reply_reason.
11318         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11319         constructor.  Change type of breakpoint.
11320         (finish_command_fsm_ops): Remove.
11321         (new_finish_command_fsm): Remove.
11322         (finish_command_fsm::should_stop): Rename from
11323         finish_command_fsm_should_stop.
11324         (finish_command_fsm::clean_up): Rename from
11325         finish_command_fsm_clean_up.
11326         (finish_command_fsm::return_value): Rename from
11327         finish_command_fsm_return_value.
11328         (finish_command_fsm::do_async_reply_reason): Rename from
11329         finish_command_fsm_async_reply_reason.
11330         (finish_command): Update.
11331         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11332         Add constructor.
11333         (call_thread_fsm_ops): Remove.
11334         (call_thread_fsm::call_thread_fsm): Rename from
11335         new_call_thread_fsm.
11336         (call_thread_fsm::should_stop): Rename from
11337         call_thread_fsm_should_stop.
11338         (call_thread_fsm::should_notify_stop): Rename from
11339         call_thread_fsm_should_notify_stop.
11340         (run_inferior_call, call_function_by_hand_dummy): Update.
11341         * cli/cli-interp.c (should_print_stop_to_console): Update.
11342         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11343         Add constructor.  Change type of location_breakpoint,
11344         caller_breakpoint.
11345         (until_break_fsm_ops): Remove.
11346         (new_until_break_fsm): Remove.
11347         (until_break_fsm::should_stop): Rename from
11348         until_break_fsm_should_stop.
11349         (until_break_fsm::clean_up): Rename from
11350         until_break_fsm_clean_up.
11351         (until_break_fsm::do_async_reply_reason): Rename from
11352         until_break_fsm_async_reply_reason.
11353         (until_break_command): Update.
11354         * thread-fsm.c: Remove.
11355         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11356
11357 2019-02-07  Tom Tromey  <tom@tromey.com>
11358
11359         * yy-remap.h: Add include guard.
11360         * xtensa-tdep.h: Add include guard.
11361         * xcoffread.h: Rename include guard.
11362         * varobj-iter.h: Add include guard.
11363         * tui/tui.h: Rename include guard.
11364         * tui/tui-winsource.h: Rename include guard.
11365         * tui/tui-wingeneral.h: Rename include guard.
11366         * tui/tui-windata.h: Rename include guard.
11367         * tui/tui-win.h: Rename include guard.
11368         * tui/tui-stack.h: Rename include guard.
11369         * tui/tui-source.h: Rename include guard.
11370         * tui/tui-regs.h: Rename include guard.
11371         * tui/tui-out.h: Rename include guard.
11372         * tui/tui-layout.h: Rename include guard.
11373         * tui/tui-io.h: Rename include guard.
11374         * tui/tui-hooks.h: Rename include guard.
11375         * tui/tui-file.h: Rename include guard.
11376         * tui/tui-disasm.h: Rename include guard.
11377         * tui/tui-data.h: Rename include guard.
11378         * tui/tui-command.h: Rename include guard.
11379         * tic6x-tdep.h: Add include guard.
11380         * target/waitstatus.h: Rename include guard.
11381         * target/wait.h: Rename include guard.
11382         * target/target.h: Rename include guard.
11383         * target/resume.h: Rename include guard.
11384         * target-float.h: Rename include guard.
11385         * stabsread.h: Add include guard.
11386         * rs6000-tdep.h: Add include guard.
11387         * riscv-fbsd-tdep.h: Add include guard.
11388         * regformats/regdef.h: Rename include guard.
11389         * record.h: Rename include guard.
11390         * python/python.h: Rename include guard.
11391         * python/python-internal.h: Rename include guard.
11392         * python/py-stopevent.h: Rename include guard.
11393         * python/py-ref.h: Rename include guard.
11394         * python/py-record.h: Rename include guard.
11395         * python/py-record-full.h: Rename include guard.
11396         * python/py-record-btrace.h: Rename include guard.
11397         * python/py-instruction.h: Rename include guard.
11398         * python/py-events.h: Rename include guard.
11399         * python/py-event.h: Rename include guard.
11400         * procfs.h: Add include guard.
11401         * proc-utils.h: Add include guard.
11402         * p-lang.h: Add include guard.
11403         * or1k-tdep.h: Rename include guard.
11404         * observable.h: Rename include guard.
11405         * nto-tdep.h: Rename include guard.
11406         * nat/x86-linux.h: Rename include guard.
11407         * nat/x86-linux-dregs.h: Rename include guard.
11408         * nat/x86-gcc-cpuid.h: Add include guard.
11409         * nat/x86-dregs.h: Rename include guard.
11410         * nat/x86-cpuid.h: Rename include guard.
11411         * nat/ppc-linux.h: Rename include guard.
11412         * nat/mips-linux-watch.h: Rename include guard.
11413         * nat/linux-waitpid.h: Rename include guard.
11414         * nat/linux-ptrace.h: Rename include guard.
11415         * nat/linux-procfs.h: Rename include guard.
11416         * nat/linux-osdata.h: Rename include guard.
11417         * nat/linux-nat.h: Rename include guard.
11418         * nat/linux-namespaces.h: Rename include guard.
11419         * nat/linux-btrace.h: Rename include guard.
11420         * nat/glibc_thread_db.h: Rename include guard.
11421         * nat/gdb_thread_db.h: Rename include guard.
11422         * nat/gdb_ptrace.h: Rename include guard.
11423         * nat/fork-inferior.h: Rename include guard.
11424         * nat/amd64-linux-siginfo.h: Rename include guard.
11425         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11426         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11427         * nat/aarch64-linux.h: Rename include guard.
11428         * nat/aarch64-linux-hw-point.h: Rename include guard.
11429         * mn10300-tdep.h: Add include guard.
11430         * mips-linux-tdep.h: Add include guard.
11431         * mi/mi-parse.h: Rename include guard.
11432         * mi/mi-out.h: Rename include guard.
11433         * mi/mi-main.h: Rename include guard.
11434         * mi/mi-interp.h: Rename include guard.
11435         * mi/mi-getopt.h: Rename include guard.
11436         * mi/mi-console.h: Rename include guard.
11437         * mi/mi-common.h: Rename include guard.
11438         * mi/mi-cmds.h: Rename include guard.
11439         * mi/mi-cmd-break.h: Rename include guard.
11440         * m2-lang.h: Add include guard.
11441         * location.h: Rename include guard.
11442         * linux-record.h: Rename include guard.
11443         * linux-nat.h: Add include guard.
11444         * linux-fork.h: Add include guard.
11445         * i386-darwin-tdep.h: Rename include guard.
11446         * hppa-linux-offsets.h: Add include guard.
11447         * guile/guile.h: Rename include guard.
11448         * guile/guile-internal.h: Rename include guard.
11449         * gnu-nat.h: Rename include guard.
11450         * gdb-stabs.h: Rename include guard.
11451         * frv-tdep.h: Add include guard.
11452         * f-lang.h: Add include guard.
11453         * event-loop.h: Add include guard.
11454         * darwin-nat.h: Rename include guard.
11455         * cp-abi.h: Rename include guard.
11456         * config/sparc/nm-sol2.h: Rename include guard.
11457         * config/nm-nto.h: Rename include guard.
11458         * config/nm-linux.h: Add include guard.
11459         * config/i386/nm-i386gnu.h: Rename include guard.
11460         * config/djgpp/nl_types.h: Rename include guard.
11461         * config/djgpp/langinfo.h: Rename include guard.
11462         * compile/gcc-cp-plugin.h: Add include guard.
11463         * compile/gcc-c-plugin.h: Add include guard.
11464         * compile/compile.h: Rename include guard.
11465         * compile/compile-object-run.h: Rename include guard.
11466         * compile/compile-object-load.h: Rename include guard.
11467         * compile/compile-internal.h: Rename include guard.
11468         * compile/compile-cplus.h: Rename include guard.
11469         * compile/compile-c.h: Rename include guard.
11470         * common/xml-utils.h: Rename include guard.
11471         * common/x86-xstate.h: Rename include guard.
11472         * common/version.h: Rename include guard.
11473         * common/vec.h: Rename include guard.
11474         * common/tdesc.h: Rename include guard.
11475         * common/selftest.h: Rename include guard.
11476         * common/scoped_restore.h: Rename include guard.
11477         * common/scoped_mmap.h: Rename include guard.
11478         * common/scoped_fd.h: Rename include guard.
11479         * common/safe-iterator.h: Rename include guard.
11480         * common/run-time-clock.h: Rename include guard.
11481         * common/refcounted-object.h: Rename include guard.
11482         * common/queue.h: Rename include guard.
11483         * common/ptid.h: Rename include guard.
11484         * common/print-utils.h: Rename include guard.
11485         * common/preprocessor.h: Rename include guard.
11486         * common/pathstuff.h: Rename include guard.
11487         * common/observable.h: Rename include guard.
11488         * common/netstuff.h: Rename include guard.
11489         * common/job-control.h: Rename include guard.
11490         * common/host-defs.h: Rename include guard.
11491         * common/gdb_wait.h: Rename include guard.
11492         * common/gdb_vecs.h: Rename include guard.
11493         * common/gdb_unlinker.h: Rename include guard.
11494         * common/gdb_unique_ptr.h: Rename include guard.
11495         * common/gdb_tilde_expand.h: Rename include guard.
11496         * common/gdb_sys_time.h: Rename include guard.
11497         * common/gdb_string_view.h: Rename include guard.
11498         * common/gdb_splay_tree.h: Rename include guard.
11499         * common/gdb_setjmp.h: Rename include guard.
11500         * common/gdb_ref_ptr.h: Rename include guard.
11501         * common/gdb_optional.h: Rename include guard.
11502         * common/gdb_locale.h: Rename include guard.
11503         * common/gdb_assert.h: Rename include guard.
11504         * common/filtered-iterator.h: Rename include guard.
11505         * common/filestuff.h: Rename include guard.
11506         * common/fileio.h: Rename include guard.
11507         * common/environ.h: Rename include guard.
11508         * common/common-utils.h: Rename include guard.
11509         * common/common-types.h: Rename include guard.
11510         * common/common-regcache.h: Rename include guard.
11511         * common/common-inferior.h: Rename include guard.
11512         * common/common-gdbthread.h: Rename include guard.
11513         * common/common-exceptions.h: Rename include guard.
11514         * common/common-defs.h: Rename include guard.
11515         * common/common-debug.h: Rename include guard.
11516         * common/cleanups.h: Rename include guard.
11517         * common/buffer.h: Rename include guard.
11518         * common/btrace-common.h: Rename include guard.
11519         * common/break-common.h: Rename include guard.
11520         * cli/cli-utils.h: Rename include guard.
11521         * cli/cli-style.h: Rename include guard.
11522         * cli/cli-setshow.h: Rename include guard.
11523         * cli/cli-script.h: Rename include guard.
11524         * cli/cli-interp.h: Rename include guard.
11525         * cli/cli-decode.h: Rename include guard.
11526         * cli/cli-cmds.h: Rename include guard.
11527         * charset-list.h: Add include guard.
11528         * buildsym-legacy.h: Rename include guard.
11529         * bfin-tdep.h: Add include guard.
11530         * ax.h: Rename include guard.
11531         * arm-linux-tdep.h: Add include guard.
11532         * arm-fbsd-tdep.h: Add include guard.
11533         * arch/xtensa.h: Rename include guard.
11534         * arch/tic6x.h: Add include guard.
11535         * arch/i386.h: Add include guard.
11536         * arch/arm.h: Rename include guard.
11537         * arch/arm-linux.h: Rename include guard.
11538         * arch/arm-get-next-pcs.h: Rename include guard.
11539         * arch/amd64.h: Add include guard.
11540         * arch/aarch64-insn.h: Rename include guard.
11541         * arch-utils.h: Rename include guard.
11542         * annotate.h: Add include guard.
11543         * amd64-darwin-tdep.h: Rename include guard.
11544         * aarch64-linux-tdep.h: Add include guard.
11545         * aarch64-fbsd-tdep.h: Add include guard.
11546         * aarch32-linux-nat.h: Add include guard.
11547
11548 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11549
11550         * macrotab.c (macro_define_internal): New function that
11551         factorizes macro_define_object_internal and macro_define_function
11552         code.
11553         (macro_define_object_internal): Use macro_define_internal.
11554         (macro_define_function): Likewise.
11555
11556 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11557
11558         * macrocmd.c (extract_identifier): Return
11559         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11560         callers.
11561
11562 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11563
11564         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11565
11566 2019-02-05  Tom Tromey  <tom@tromey.com>
11567
11568         * target.c (target_stack::unpush): Move assertion earlier.
11569
11570 2019-01-30  Tom Tromey  <tom@tromey.com>
11571
11572         PR python/23615:
11573         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11574         (gdbpy_parse_and_eval): Likewise.
11575         * python/python-internal.h (gdbpy_allow_threads): New class.
11576
11577 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11578
11579         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11580         (aarch64_fbsd_fpregmap): Move earlier.
11581         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11582         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11583         instead of individual calls to trad_frame_set_reg_addr.
11584         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11585         earlier.
11586         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11587         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11588         instead of individual calls to trad_frame_set_reg_addr.
11589
11590 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11591
11592         * CONTRIBUTE: Replace contribution list with wiki link.
11593
11594 2019-01-25  Tom Tromey  <tom@tromey.com>
11595
11596         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11597
11598 2019-01-25  Tom Tromey  <tom@tromey.com>
11599
11600         * xtensa-linux-nat.c: Fix common/ includes.
11601         * xml-support.h: Fix common/ includes.
11602         * xml-support.c: Fix common/ includes.
11603         * x86-linux-nat.c: Fix common/ includes.
11604         * windows-nat.c: Fix common/ includes.
11605         * varobj.h: Fix common/ includes.
11606         * varobj.c: Fix common/ includes.
11607         * value.c: Fix common/ includes.
11608         * valops.c: Fix common/ includes.
11609         * utils.c: Fix common/ includes.
11610         * unittests/xml-utils-selftests.c: Fix common/ includes.
11611         * unittests/utils-selftests.c: Fix common/ includes.
11612         * unittests/unpack-selftests.c: Fix common/ includes.
11613         * unittests/tracepoint-selftests.c: Fix common/ includes.
11614         * unittests/style-selftests.c: Fix common/ includes.
11615         * unittests/string_view-selftests.c: Fix common/ includes.
11616         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11617         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11618         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11619         * unittests/rsp-low-selftests.c: Fix common/ includes.
11620         * unittests/parse-connection-spec-selftests.c: Fix common/
11621         includes.
11622         * unittests/optional-selftests.c: Fix common/ includes.
11623         * unittests/offset-type-selftests.c: Fix common/ includes.
11624         * unittests/observable-selftests.c: Fix common/ includes.
11625         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11626         * unittests/memrange-selftests.c: Fix common/ includes.
11627         * unittests/memory-map-selftests.c: Fix common/ includes.
11628         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11629         * unittests/function-view-selftests.c: Fix common/ includes.
11630         * unittests/environ-selftests.c: Fix common/ includes.
11631         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11632         * unittests/common-utils-selftests.c: Fix common/ includes.
11633         * unittests/cli-utils-selftests.c: Fix common/ includes.
11634         * unittests/array-view-selftests.c: Fix common/ includes.
11635         * ui-file.c: Fix common/ includes.
11636         * tui/tui-io.c: Fix common/ includes.
11637         * tracepoint.h: Fix common/ includes.
11638         * tracepoint.c: Fix common/ includes.
11639         * tracefile-tfile.c: Fix common/ includes.
11640         * top.h: Fix common/ includes.
11641         * top.c: Fix common/ includes.
11642         * thread.c: Fix common/ includes.
11643         * target/waitstatus.h: Fix common/ includes.
11644         * target/waitstatus.c: Fix common/ includes.
11645         * target.h: Fix common/ includes.
11646         * target.c: Fix common/ includes.
11647         * target-memory.c: Fix common/ includes.
11648         * target-descriptions.c: Fix common/ includes.
11649         * symtab.h: Fix common/ includes.
11650         * symfile.c: Fix common/ includes.
11651         * stap-probe.c: Fix common/ includes.
11652         * spu-linux-nat.c: Fix common/ includes.
11653         * sparc-nat.c: Fix common/ includes.
11654         * source.c: Fix common/ includes.
11655         * solib.c: Fix common/ includes.
11656         * solib-target.c: Fix common/ includes.
11657         * ser-unix.c: Fix common/ includes.
11658         * ser-tcp.c: Fix common/ includes.
11659         * ser-pipe.c: Fix common/ includes.
11660         * ser-base.c: Fix common/ includes.
11661         * selftest-arch.c: Fix common/ includes.
11662         * s12z-tdep.c: Fix common/ includes.
11663         * rust-exp.y: Fix common/ includes.
11664         * rs6000-aix-tdep.c: Fix common/ includes.
11665         * riscv-tdep.c: Fix common/ includes.
11666         * remote.c: Fix common/ includes.
11667         * remote-notif.h: Fix common/ includes.
11668         * remote-fileio.h: Fix common/ includes.
11669         * remote-fileio.c: Fix common/ includes.
11670         * regcache.h: Fix common/ includes.
11671         * regcache.c: Fix common/ includes.
11672         * record-btrace.c: Fix common/ includes.
11673         * python/python.c: Fix common/ includes.
11674         * python/py-type.c: Fix common/ includes.
11675         * python/py-inferior.c: Fix common/ includes.
11676         * progspace.h: Fix common/ includes.
11677         * producer.c: Fix common/ includes.
11678         * procfs.c: Fix common/ includes.
11679         * proc-api.c: Fix common/ includes.
11680         * printcmd.c: Fix common/ includes.
11681         * ppc-linux-nat.c: Fix common/ includes.
11682         * parser-defs.h: Fix common/ includes.
11683         * osdata.c: Fix common/ includes.
11684         * obsd-nat.c: Fix common/ includes.
11685         * nat/x86-linux.c: Fix common/ includes.
11686         * nat/x86-linux-dregs.c: Fix common/ includes.
11687         * nat/x86-dregs.h: Fix common/ includes.
11688         * nat/x86-dregs.c: Fix common/ includes.
11689         * nat/ppc-linux.c: Fix common/ includes.
11690         * nat/mips-linux-watch.h: Fix common/ includes.
11691         * nat/mips-linux-watch.c: Fix common/ includes.
11692         * nat/linux-waitpid.c: Fix common/ includes.
11693         * nat/linux-ptrace.h: Fix common/ includes.
11694         * nat/linux-ptrace.c: Fix common/ includes.
11695         * nat/linux-procfs.c: Fix common/ includes.
11696         * nat/linux-personality.c: Fix common/ includes.
11697         * nat/linux-osdata.c: Fix common/ includes.
11698         * nat/linux-namespaces.c: Fix common/ includes.
11699         * nat/linux-btrace.h: Fix common/ includes.
11700         * nat/linux-btrace.c: Fix common/ includes.
11701         * nat/fork-inferior.c: Fix common/ includes.
11702         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11703         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11704         * nat/aarch64-linux.c: Fix common/ includes.
11705         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11706         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11707         * namespace.h: Fix common/ includes.
11708         * mips-linux-tdep.c: Fix common/ includes.
11709         * minsyms.c: Fix common/ includes.
11710         * mi/mi-parse.h: Fix common/ includes.
11711         * mi/mi-main.c: Fix common/ includes.
11712         * mi/mi-cmd-env.c: Fix common/ includes.
11713         * memrange.h: Fix common/ includes.
11714         * memattr.c: Fix common/ includes.
11715         * maint.h: Fix common/ includes.
11716         * maint.c: Fix common/ includes.
11717         * main.c: Fix common/ includes.
11718         * machoread.c: Fix common/ includes.
11719         * location.c: Fix common/ includes.
11720         * linux-thread-db.c: Fix common/ includes.
11721         * linux-nat.c: Fix common/ includes.
11722         * linux-fork.c: Fix common/ includes.
11723         * inline-frame.c: Fix common/ includes.
11724         * infrun.c: Fix common/ includes.
11725         * inflow.c: Fix common/ includes.
11726         * inferior.h: Fix common/ includes.
11727         * inferior.c: Fix common/ includes.
11728         * infcmd.c: Fix common/ includes.
11729         * inf-ptrace.c: Fix common/ includes.
11730         * inf-child.c: Fix common/ includes.
11731         * ia64-linux-nat.c: Fix common/ includes.
11732         * i387-tdep.c: Fix common/ includes.
11733         * i386-tdep.c: Fix common/ includes.
11734         * i386-linux-tdep.c: Fix common/ includes.
11735         * i386-linux-nat.c: Fix common/ includes.
11736         * i386-go32-tdep.c: Fix common/ includes.
11737         * i386-fbsd-tdep.c: Fix common/ includes.
11738         * i386-fbsd-nat.c: Fix common/ includes.
11739         * guile/scm-type.c: Fix common/ includes.
11740         * guile/guile.c: Fix common/ includes.
11741         * go32-nat.c: Fix common/ includes.
11742         * gnu-nat.c: Fix common/ includes.
11743         * gdbthread.h: Fix common/ includes.
11744         * gdbarch-selftests.c: Fix common/ includes.
11745         * gdb_usleep.c: Fix common/ includes.
11746         * gdb_select.h: Fix common/ includes.
11747         * gdb_bfd.c: Fix common/ includes.
11748         * gcore.c: Fix common/ includes.
11749         * fork-child.c: Fix common/ includes.
11750         * findvar.c: Fix common/ includes.
11751         * fbsd-nat.c: Fix common/ includes.
11752         * event-top.c: Fix common/ includes.
11753         * event-loop.c: Fix common/ includes.
11754         * dwarf2read.c: Fix common/ includes.
11755         * dwarf2loc.c: Fix common/ includes.
11756         * dwarf2-frame.c: Fix common/ includes.
11757         * dwarf-index-cache.c: Fix common/ includes.
11758         * dtrace-probe.c: Fix common/ includes.
11759         * disasm-selftests.c: Fix common/ includes.
11760         * defs.h: Fix common/ includes.
11761         * csky-tdep.c: Fix common/ includes.
11762         * cp-valprint.c: Fix common/ includes.
11763         * cp-support.h: Fix common/ includes.
11764         * cp-support.c: Fix common/ includes.
11765         * corelow.c: Fix common/ includes.
11766         * completer.h: Fix common/ includes.
11767         * completer.c: Fix common/ includes.
11768         * compile/compile.c: Fix common/ includes.
11769         * compile/compile-loc2c.c: Fix common/ includes.
11770         * compile/compile-cplus-types.c: Fix common/ includes.
11771         * compile/compile-cplus-symbols.c: Fix common/ includes.
11772         * command.h: Fix common/ includes.
11773         * cli/cli-dump.c: Fix common/ includes.
11774         * cli/cli-cmds.c: Fix common/ includes.
11775         * charset.c: Fix common/ includes.
11776         * build-id.c: Fix common/ includes.
11777         * btrace.h: Fix common/ includes.
11778         * btrace.c: Fix common/ includes.
11779         * breakpoint.h: Fix common/ includes.
11780         * breakpoint.c: Fix common/ includes.
11781         * ax.h:
11782         (enum agent_op): Fix common/ includes.
11783         * ax-general.c (struct aop_map): Fix common/ includes.
11784         * ax-gdb.c: Fix common/ includes.
11785         * auxv.c: Fix common/ includes.
11786         * auto-load.c: Fix common/ includes.
11787         * arm-tdep.c: Fix common/ includes.
11788         * arch/riscv.c: Fix common/ includes.
11789         * arch/ppc-linux-common.c: Fix common/ includes.
11790         * arch/i386.c: Fix common/ includes.
11791         * arch/arm.c: Fix common/ includes.
11792         * arch/arm-linux.c: Fix common/ includes.
11793         * arch/arm-get-next-pcs.c: Fix common/ includes.
11794         * arch/amd64.c: Fix common/ includes.
11795         * arch/aarch64.c: Fix common/ includes.
11796         * arch/aarch64-insn.c: Fix common/ includes.
11797         * arch-utils.c: Fix common/ includes.
11798         * amd64-windows-tdep.c: Fix common/ includes.
11799         * amd64-tdep.c: Fix common/ includes.
11800         * amd64-sol2-tdep.c: Fix common/ includes.
11801         * amd64-obsd-tdep.c: Fix common/ includes.
11802         * amd64-nbsd-tdep.c: Fix common/ includes.
11803         * amd64-linux-tdep.c: Fix common/ includes.
11804         * amd64-linux-nat.c: Fix common/ includes.
11805         * amd64-fbsd-tdep.c: Fix common/ includes.
11806         * amd64-fbsd-nat.c: Fix common/ includes.
11807         * amd64-dicos-tdep.c: Fix common/ includes.
11808         * amd64-darwin-tdep.c: Fix common/ includes.
11809         * agent.c: Fix common/ includes.
11810         * ada-lang.h: Fix common/ includes.
11811         * ada-lang.c: Fix common/ includes.
11812         * aarch64-tdep.c: Fix common/ includes.
11813
11814 2019-01-25  Tom Tromey  <tom@tromey.com>
11815
11816         * common/create-version.sh: Use common/version.h.
11817
11818 2019-01-24  Pedro Alves  <palves@redhat.com>
11819
11820         * infrun.c (signal_stop, signal_print, signal_program)
11821         (signal_catch, signal_pass): Now arrays instead of pointers.
11822         (update_signals_program_target, do_target_resume)
11823         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11824         * linux-nat.c (linux_nat_target::pass_signals)
11825         (linux_nat_target::create_inferior, linux_nat_target::attach):
11826         Adjust.
11827         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11828         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11829         * procfs.c (procfs_target::pass_signals): Adjust.
11830         * record-full.c (record_full_target::resume): Adjust.
11831         * remote.c (remote_target::pass_signals)
11832         (remote_target::program_signals): Adjust.
11833         * target-debug.h (target_debug_print_signals): Now takes a
11834         gdb::array_view as parameter.  Adjust.
11835         * target.h (target_ops) <pass_signals, program_signals>: Replace
11836         pointer and length parameters with gdb::array_view.
11837         (target_pass_signals, target_program_signals): Likewise.
11838         * target-delegates.c: Regenerate.
11839
11840 2019-01-24  Pedro Alves  <palves@redhat.com>
11841
11842         * common/forward-scope-exit.h
11843         (forward_scope_exit::forward_scope_exit): Pass arguments to
11844         m_bind_function directly, instead of creating a std::bind and
11845         copying that.
11846
11847 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11848
11849         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11850         for static members.
11851         (pass_in_v_vfp_candidate): Likewise.
11852
11853 2019-01-23  Tom Tromey  <tom@tromey.com>
11854             Pedro Alves  <palves@redhat.com>
11855
11856         * regcache.c (class regcache_invalidator): Remove.
11857         (regcache::raw_write): Use make_scope_exit.
11858
11859 2019-01-23  Tom Tromey  <tom@tromey.com>
11860
11861         * ui-out.h (class ui_out_emit_type): Update comment.
11862
11863 2019-01-23  Tom Tromey  <tom@tromey.com>
11864
11865         * infrun.c (fetch_inferior_event): Update comment.
11866
11867 2019-01-23  Tom Tromey  <tom@tromey.com>
11868             Pedro Alves  <palves@redhat.com>
11869
11870         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11871         parameter.
11872         (fetch_inferior_event): Use SCOPE_EXIT.
11873
11874
11875 2019-01-23  Tom Tromey  <tom@tromey.com>
11876             Pedro Alves  <palves@redhat.com>
11877
11878         * infrun.c (disable_thread_events): Delete.
11879         (stop_all_threads): Use SCOPE_EXIT.
11880
11881 2019-01-23  Tom Tromey  <tom@tromey.com>
11882             Pedro Alves  <palves@redhat.com>
11883
11884         * symfile.c: Include forward-scope-exit.h.
11885         (clear_symtab_users_cleanup): Replace forward declaration with
11886         a FORWARD_SCOPE_EXIT.
11887         (syms_from_objfile_1): Use the forward_scope_exit and
11888         gdb::optional instead of cleanup_function.
11889         (reread_symbols): Use the forward_scope_exit instead of
11890         cleanup_function.
11891         (clear_symtab_users_cleanup): Remove function.
11892
11893 2019-01-23  Tom Tromey  <tom@tromey.com>
11894             Pedro Alves  <palves@redhat.com>
11895
11896         * linux-nat.c: Include scope-exit.h.
11897         (cleanup_target_stop): Remove.
11898         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11899         SCOPE_EXIT.
11900
11901 2019-01-23  Tom Tromey  <tom@tromey.com>
11902             Pedro Alves  <palves@redhat.com>
11903
11904         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11905         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11906
11907 2019-01-23  Tom Tromey  <tom@tromey.com>
11908             Andrew Burgess  <andrew.burgess@embecosm.com>
11909             Pedro Alves  <palves@redhat.com>
11910
11911         * infrun.c (fetch_inferior_event): Use scope_exit.
11912         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11913         * top.c (execute_command): Use scope_exit.
11914         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11915         * utils.c (do_bpstat_clear_actions_cleanup)
11916         (make_bpstat_clear_actions_cleanup): Remove.
11917
11918 2019-01-23  Tom Tromey  <tom@tromey.com>
11919             Pedro Alves  <palves@redhat.com>
11920
11921         * infrun.c: Include "common/scope-exit.h"
11922         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11923         (wait_for_inferior): Use SCOPE_EXIT.
11924         (fetch_inferior_event): Use scope_exit.
11925
11926 2019-01-23  Tom Tromey  <tom@tromey.com>
11927             Pedro Alves  <palves@redhat.com>
11928
11929         * breakpoint.c (create_breakpoint): Remove cleanup.
11930
11931 2019-01-23  Tom Tromey  <tom@tromey.com>
11932             Andrew Burgess  <andrew.burgess@embecosm.com>
11933             Pedro Alves  <palves@redhat.com>
11934
11935 2019-01-23  Pedro Alves  <palves@redhat.com>
11936
11937         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11938
11939 2019-01-23  Pedro Alves  <palves@redhat.com>
11940             Andrew Burgess  <andrew.burgess@embecosm.com>
11941
11942         * gdbthread.h: Include "common/forward-scope-exit.h".
11943         (scoped_finish_thread_state): Redefine custom class in terms of
11944         forward_scope_exit.
11945
11946 2019-01-23  Pedro Alves  <palves@redhat.com>
11947             Andrew Burgess  <andrew.burgess@embecosm.com>
11948
11949         * common/forward-scope-exit.h: New file.
11950
11951 2019-01-23  Pedro Alves  <palves@redhat.com>
11952             Andrew Burgess  <andrew.burgess@embecosm.com>
11953             Tom Tromey  <tom@tromey.com>
11954
11955         * common/scope-exit.h: New file.
11956
11957 2019-01-23  Pedro Alves  <palves@redhat.com>
11958
11959         * common/preprocessor.h (ESC): Rename to ...
11960         (ESC_PARENS): ... this.
11961         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11962         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11963
11964 2019-01-23  Tom Tromey  <tom@tromey.com>
11965
11966         * language.h (class scoped_switch_to_sym_language_if_auto):
11967         Initialize m_lang in both cases.
11968
11969 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11970
11971         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11972         with XCNEW.
11973
11974 2019-01-22  Tom Tromey  <tom@tromey.com>
11975
11976         * corelow.c: Do not include sys/file.h.
11977
11978 2019-01-22  Tom Tromey  <tom@tromey.com>
11979
11980         * tui/tui-wingeneral.h: Include gdb_curses.h.
11981
11982 2019-01-22  Tom Tromey  <tom@tromey.com>
11983
11984         * source-cache.h (class source_cache) <get_source_lines,
11985         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11986
11987 2019-01-22  Tom Tromey  <tom@tromey.com>
11988
11989         * remote-fileio.h (struct remote_target): Declare.
11990
11991 2019-01-22  Tom Tromey  <tom@tromey.com>
11992
11993         * python/py-arch.c: Do not include py-ref.h.
11994         * python/py-bpevent.c: Do not include py-ref.h.
11995         * python/py-cmd.c: Do not include py-ref.h.
11996         * python/py-continueevent.c: Do not include py-ref.h.
11997         * python/py-event.h: Do not include py-ref.h.
11998         * python/py-evtregistry.c: Do not include py-ref.h.
11999         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12000         * python/py-frame.c: Do not include py-ref.h.
12001         * python/py-framefilter.c: Do not include py-ref.h.
12002         * python/py-function.c: Do not include py-ref.h.
12003         * python/py-infevents.c: Do not include py-ref.h.
12004         * python/py-linetable.c: Do not include py-ref.h.
12005         * python/py-objfile.c: Do not include py-ref.h.
12006         * python/py-param.c: Do not include py-ref.h.
12007         * python/py-prettyprint.c: Do not include py-ref.h.
12008         * python/py-progspace.c: Do not include py-ref.h.
12009         * python/py-symbol.c: Do not include py-ref.h.
12010         * python/py-symtab.c: Do not include py-ref.h.
12011         * python/py-type.c: Do not include py-ref.h.
12012         * python/py-unwind.c: Do not include py-ref.h.
12013         * python/py-utils.c: Do not include py-ref.h.
12014         * python/py-value.c: Do not include py-ref.h.
12015         * python/py-varobj.c: Do not include py-ref.h.
12016         * python/py-xmethods.c: Do not include py-ref.h.
12017         * python/python.c: Do not include py-ref.h.
12018         * varobj.c: Do not include py-ref.h.
12019
12020 2019-01-22  Tom Tromey  <tom@tromey.com>
12021
12022         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12023         keyword for bcache.
12024
12025 2019-01-22  Tom Tromey  <tom@tromey.com>
12026
12027         * compile/compile-cplus-types.c: Remove a comment by #include.
12028
12029 2019-01-22  Tom Tromey  <tom@tromey.com>
12030
12031         * compile/gcc-c-plugin.h: Include compile-internal.h.
12032
12033 2019-01-22  Tom Tromey  <tom@tromey.com>
12034
12035         * stabsread.c (EXTERN): Do not define.
12036         (symnum, next_symbol_text_func, processing_gcc_compilation)
12037         (within_function, global_sym_chain, global_stabs)
12038         (previous_stab_code, this_object_header_files)
12039         (n_this_object_header_files)
12040         (n_allocated_this_object_header_files): Define.
12041         * stabsread.h (EXTERN): Never define.  Use "extern".
12042
12043 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12044
12045         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12046         history_value.
12047
12048 2019-01-21  Tom Tromey  <tom@tromey.com>
12049
12050         * ui-out.c: Fix includes.
12051         * tui/tui-source.c: Fix includes.
12052         * target.c: Fix includes.
12053         * remote.c: Fix includes.
12054         * regcache.c: Fix includes.
12055         * python/py-block.c: Fix includes.
12056         * printcmd.c: Fix includes.
12057         * or1k-tdep.c: Fix includes.
12058         * mi/mi-main.c: Fix includes.
12059         * m32r-tdep.c: Fix includes.
12060         * csky-tdep.c: Fix includes.
12061         * compile/compile-cplus-types.c: Fix includes.
12062         * cli/cli-interp.c: Fix includes.
12063
12064 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12065
12066         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12067         for padding.
12068
12069 2019-01-16  Tom Tromey  <tom@tromey.com>
12070
12071         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12072         earlier.
12073         (struct objfile) <msymbols_range>: Move from top level.
12074         <msymbols>: New method.
12075         (class objfile_msymbols): Remove.
12076         * symtab.c (default_collect_symbol_completion_matches_break_on):
12077         Update.
12078         * symmisc.c (dump_msymbols): Update.
12079         * stabsread.c (scan_file_globals): Update.
12080         * objc-lang.c (info_selectors_command, info_classes_command)
12081         (find_methods): Update.
12082         * minsyms.c (find_solib_trampoline_target): Update.
12083         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12084         * coffread.c (coff_symfile_read): Update.
12085         * ada-lang.c (ada_lookup_simple_minsym)
12086         (ada_collect_symbol_completion_matches): Update.
12087
12088 2019-01-16  Tom Tromey  <tom@tromey.com>
12089
12090         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12091         type.  Remove no-argument constructor.
12092         <iterator::operator++>: Simplify.
12093         <begin>: Update.
12094         <end>: Use minimal_symbol_count.
12095
12096 2019-01-16  Tom Tromey  <tom@tromey.com>
12097
12098         * objfiles.h (struct objfile) <psymtabs>: New method.
12099         (class objfile_psymtabs): Remove.
12100         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12101         typedef.
12102         <range>: New method.
12103         (require_partial_symbols): Change return type.
12104         * psymtab.c (require_partial_symbols)
12105         (psym_expand_symtabs_matching): Update.
12106         * mdebugread.c (parse_partial_symbols): Update.
12107         * dbxread.c (dbx_end_psymtab): Update.
12108
12109 2019-01-15  Tom Tromey  <tom@tromey.com>
12110
12111         * symtab.c (lookup_objfile_from_block)
12112         (lookup_symbol_in_objfile_symtabs)
12113         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12114         (find_line_symtab, info_sources_command)
12115         (default_collect_symbol_completion_matches_break_on)
12116         (make_source_files_completion_list): Update.
12117         * symmisc.c (print_objfile_statistics, dump_objfile)
12118         (maintenance_print_symbols, maintenance_info_symtabs)
12119         (maintenance_check_symtabs, maintenance_info_line_tables):
12120         Update.
12121         * source.c (select_source_symtab)
12122         (forget_cached_source_info_for_objfile): Update.
12123         * objfiles.h (class objfile_compunits): Remove.
12124         (struct objfile) <compunits_range>: New typedef.
12125         (compunits): New method.
12126         * objfiles.c (objfile_relocate1): Update.
12127         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12128         * maint.c (count_symtabs_and_blocks): Update.
12129         * linespec.c (iterate_over_all_matching_symtabs): Update.
12130         * cp-support.c (add_symbol_overload_list_qualified): Update.
12131         * coffread.c (coff_symtab_read): Update.
12132         * ada-lang.c (add_nonlocal_symbols)
12133         (ada_collect_symbol_completion_matches)
12134         (ada_add_global_exceptions): Update.
12135
12136 2019-01-15  Tom Tromey  <tom@tromey.com>
12137
12138         * progspace.h (program_space) <objfiles_safe_range>: New
12139         typedef.
12140         <objfiles_safe>: New method.
12141         * objfiles.h (class all_objfiles_safe): Remove.
12142         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12143         * jit.c (jit_inferior_exit_hook): Update.
12144
12145 2019-01-17  Tom Tromey  <tom@tromey.com>
12146
12147         * progspace.h (program_space) <objfiles_range>: New typedef.
12148         <objfiles>: New method.
12149         <objfiles_head>: Rename from objfiles.
12150         (object_files): Update.
12151         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12152         * guile/scm-pretty-print.c
12153         (ppscm_find_pretty_printer_from_objfiles): Update.
12154         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12155         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12156         Update.
12157         * python/py-progspace.c (pspy_get_objfiles): Update.
12158         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12159         Update.
12160         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12161         (objfpy_lookup_objfile_by_build_id): Update.
12162         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12163         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12164         Update.
12165         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12166         (expand_symtab_containing_pc, lookup_objfile_from_block)
12167         (lookup_static_symbol, basic_lookup_transparent_type)
12168         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12169         (find_line_symtab, info_sources_command)
12170         (default_collect_symbol_completion_matches_break_on)
12171         (make_source_files_completion_list, find_main_name): Update.
12172         * symmisc.c (print_symbol_bcache_statistics)
12173         (print_objfile_statistics, maintenance_print_symbols)
12174         (maintenance_print_msymbols, maintenance_print_objfiles)
12175         (maintenance_info_symtabs, maintenance_check_symtabs)
12176         (maintenance_expand_symtabs, maintenance_info_line_tables):
12177         Update.
12178         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12179         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12180         (map_overlay_command, unmap_overlay_command)
12181         (simple_overlay_update, expand_symtabs_matching)
12182         (map_symbol_filenames): Update.
12183         * symfile-debug.c (set_debug_symfile): Update.
12184         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12185         Update.
12186         * source.c (select_source_symtab, forget_cached_source_info):
12187         Update.
12188         * solib.c (solib_read_symbols): Update.
12189         * solib-spu.c (append_ocl_sos): Update.
12190         * psymtab.c (maintenance_print_psymbols)
12191         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12192         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12193         * printcmd.c (info_symbol_command): Update.
12194         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12195         Update.
12196         * objfiles.h (class all_objfiles): Remove.
12197         * objfiles.c (have_partial_symbols, have_full_symbols)
12198         (have_minimal_symbols, qsort_cmp, update_section_map)
12199         (shared_objfile_contains_address_p)
12200         (default_iterate_over_objfiles_in_search_order): Update.
12201         * objc-lang.c (info_selectors_command, info_classes_command)
12202         (find_methods): Update.
12203         * minsyms.c (find_solib_trampoline_target): Update.
12204         * maint.c (maintenance_info_sections)
12205         (maintenance_translate_address, count_symtabs_and_blocks):
12206         Update.
12207         * main.c (captured_main_1): Update.
12208         * linux-thread-db.c (try_thread_db_load_from_pdir)
12209         (has_libpthread): Update.
12210         * linespec.c (iterate_over_all_matching_symtabs)
12211         (search_minsyms_for_name): Update.
12212         * jit.c (jit_find_objf_with_entry_addr): Update.
12213         * hppa-tdep.c (find_unwind_entry)
12214         (hppa_lookup_stub_minimal_symbol): Update.
12215         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12216         Update.
12217         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12218         (elf_gnu_ifunc_resolve_by_got): Update.
12219         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12220         * dwarf-index-write.c (save_gdb_index_command): Update.
12221         * cp-support.c (add_symbol_overload_list_qualified): Update.
12222         * breakpoint.c (create_overlay_event_breakpoint)
12223         (create_longjmp_master_breakpoint)
12224         (create_std_terminate_master_breakpoint)
12225         (create_exception_master_breakpoint): Update.
12226         * blockframe.c (find_pc_partial_function): Update.
12227         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12228         (ada_collect_symbol_completion_matches)
12229         (ada_add_global_exceptions): Update.
12230
12231 2019-01-17  Tom Tromey  <tom@tromey.com>
12232
12233         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12234         declare VEC.
12235         (solib_target_parse_libraries): Change return type.
12236         (library_list_start_segment, library_list_start_section)
12237         (library_list_end_library, library_list_start_library); Update.
12238         (solib_target_free_library_list): Remove.
12239         (solib_target_parse_libraries): Remove cleanup.  Change return
12240         type.
12241         (solib_target_current_sos): Update.
12242
12243 2019-01-17  Tom Tromey  <tromey@bapiya>
12244
12245         * valprint.c: Replace "the the" with "the".
12246         * symtab.c: Replace "the the" with "the".
12247         * solib.c: Replace "the the" with "the".
12248         * solib-dsbt.c: Replace "the the" with "the".
12249         * linespec.c: Replace "the the" with "the".
12250         * dwarf2loc.h: Replace "the the" with "the".
12251         * amd64-windows-tdep.c: Replace "the the" with "the".
12252         * aarch64-tdep.c: Replace "the the" with "the".
12253
12254 2019-01-16  Keith Seitz  <keiths@redhat.com>
12255
12256         PR gdb/23773
12257         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12258         <builder>: Rename to ..
12259         <m_builder>: ... this and make private.
12260         (dwarf2_cu::get_builder): New method.  Change all users of
12261         `builder' to use this method.
12262         (dwarf2_start_symtab): Move to ...
12263         (dwarf2_cu::start_symtab): ... here.  Update all callers
12264         (setup_type_unit_groups): Move to ...
12265         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12266         callers.
12267         (dwarf2_cu::reset_builder): New method.
12268         (process_full_compunit, process_full_type_unit): Use
12269         dwarf2_cu::reset_builder.
12270         (follow_die_offset): Record the ancestor CU if it is different
12271         from the followed DIE's CU.
12272         (follow_die_sig_1): Likewise.
12273
12274 2019-01-15  Tom Tromey  <tom@tromey.com>
12275
12276         * remote.c (class remote_state) <buf>: Now a char_vector.
12277         <buf_size>: Remove.
12278         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12279         parameter.
12280         (remote_target::getpkt_or_notif_sane_1)
12281         (remote_target::getpkt_sane)
12282         (remote_target::getpkt_or_notif_sane): Likewise.
12283         (class remote_target) <putpkt>: New overload.
12284         (remote_target::read_frame): Change type of "buf_p".  Remove
12285         sizeof_p parameter.
12286         (packet_ok): New overload.
12287         (packet_check_result): New overload.
12288         Update all uses.
12289
12290 2019-01-14  Tom Tromey  <tom@tromey.com>
12291
12292         * remote-notif.c (handle_notification, remote_notif_ack)
12293         (remote_notif_parse): Make "buf" const.
12294         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12295         const.
12296         (remote_notif_parse, remote_notif_ack, handle_notification):
12297         Likewise.
12298         * remote.c (remote_notif_stop_parse): Make "buf" const.
12299         (remote_target::remote_parse_stop_reply): Make "buf" const.
12300         (remote_notif_stop_ack): Make "buf" const.
12301
12302 2019-01-14  Tom Tromey  <tom@tromey.com>
12303
12304         * remote.c (remote_console_output): Make parameter const.
12305
12306 2019-01-14  Tom Tromey  <tom@tromey.com>
12307
12308         * target-debug.h (target_debug_print_signals): Constify.
12309         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12310         * procfs.c (procfs_target::pass_signals): Update.
12311         * linux-nat.c (linux_nat_target::pass_signals): Update.
12312         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12313         * target-delegates.c: Rebuild.
12314         * remote.c (remote_target::program_signals): Update.
12315         (remote_target::pass_signals): Update.
12316         * target.c (target_pass_signals): Constify argument.
12317         (target_program_signals): Likewise.
12318         * target.h (struct target_ops) <pass_signals, program_signals>:
12319         Constify argument.
12320         (target_pass_signals, target_program_signals): Constify argument.
12321
12322 2019-01-14  Tom Tromey  <tom@tromey.com>
12323
12324         PR tui/28819:
12325         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12326
12327 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12328
12329         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12330         field.
12331         * rs6000-tdep.c: Include reggroups.h.
12332         (IS_V_ALIAS_PSEUDOREG): Define.
12333         (rs6000_register_name): Return names for the "vX" aliases.
12334         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12335         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12336         aliases.  Call default_register_reggroup_p for all other
12337         pseudo-registers.
12338         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12339         New functions.
12340         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12341         Handle "vX" aliases.
12342         (v_alias_pseudo_register_collect): New function.
12343         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12344         (rs6000_gdbarch_init): Initialize "vX" aliases as
12345         pseudo-registers.  Restore registration of
12346         rs6000_pseudo_register_reggroup_p with
12347         set_tdesc_pseudo_register_reggroup_p.
12348
12349 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12350
12351         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12352         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12353         set_gdbarch_num_pseudo_regs.
12354
12355 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12356
12357         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12358         Remove arg prefixname, add do_set and do_show.
12359         Add member functions set_list and show_list.
12360         * cli/cli-style.c (class cli_style_option): Update accordingly.
12361         (style_set_list): Move to file scope.
12362         (style_show_list): Likewise.
12363         (set_style): Call help_list.
12364         (show_style): Call cmd_show_list.
12365         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12366         Update to use the new macro.
12367
12368 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12369
12370         * ada-lang.c (_initialize_ada_language): Expand the help text
12371         for the "catch exception" command.
12372
12373 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12374
12375         * symtab.c (matching_obj_sections): Initialize obj,
12376         declare it closer to its usage.
12377
12378 2019-01-10  Tom Tromey  <tom@tromey.com>
12379
12380         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12381         (basic_inf_threads_range): Remove.
12382         (inf_threads_range, inf_non_exited_threads_range)
12383         (safe_inf_threads_range): Use next_adapter.
12384
12385 2019-01-10  Keith Seitz  <keiths@redhat.com>
12386
12387         PR gdb/23712
12388         PR symtab/23010
12389         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12390         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12391
12392 2019-01-10  Keith Seitz  <keiths@redhat.com>
12393
12394         PR gdb/23712
12395         PR symtab/23010
12396         * dictionary.c (pending_to_vector): Remove.
12397         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12398         Remove _1 suffix, replacing functions of the same name.  Update
12399         all callers.
12400         (dict_create_hashed, dict_create_hashed_expandable)
12401         (dict_create_linear, dict_create_linear_expandable, dict_free)
12402         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12403         Make functions static.
12404
12405 2019-01-10  Keith Seitz  <keiths@redhat.com>
12406
12407         PR gdb/23712
12408         PR symtab/23010
12409         * dictionary.h (struct dictionary): Replace declaration with
12410         multidictionary.
12411         (dict_create_hashed, dict_create_hashed_expandable)
12412         (dict_create_linear, dict_create_linear_expandable)
12413         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12414         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12415         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12416         taking multidictionary argument.
12417         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12418         * block.h (struct block) <dict>: Change to multidictionary
12419         and rename `multidict'.
12420         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12421         symmisc.c: Update all dictionary references to multidictionary.
12422
12423 2019-01-10  Keith Seitz  <keiths@redhat.com>
12424
12425         PR gdb/23712
12426         PR symtab/23010
12427         * dictionary.c: Include unordered_map.
12428         (pending_to_vector): New function.
12429         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12430         Rewrite the non-"_1" functions to take vector instead
12431         of linked list.
12432         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12433         "new" _1 versions of the same name.
12434         (multidictionary): Define.
12435         (std::hash<enum language): New definition.
12436         (collate_pending_symbols_by_language, mdict_create_hashed)
12437         (mdict_create_hashed_expandable, mdict_create_linear)
12438         (mdict_create_linear_expandable, mdict_free)
12439         (find_language_dictionary, create_new_language_dictionary)
12440         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12441         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12442         (mdict_size, mdict_empty): New functions.
12443         * dictionary.h (mdict_iterator): Define.
12444
12445 2019-01-10  Pedro Alves  <palves@redhat.com>
12446
12447         * breakpoint.c (read_uploaded_action)
12448         (create_tracepoint_from_upload): Adjust to use
12449         gdb::unique_xmalloc_ptr.
12450         * ctf.c (ctf_write_uploaded_tp):
12451         (SET_ARRAY_FIELD): Use emplace_back.
12452         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12453         * tracefile-tfile.c (tfile_write_uploaded_tp):
12454         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12455         gdb::unique_xmalloc_ptr.
12456         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12457         at_string, cond_string, cmd_strings>: Replace char pointers
12458         with gdb::unique_xmalloc_ptr.
12459
12460 2019-01-10  Pedro Alves  <palves@redhat.com>
12461
12462         * solib-target.c (library_list_start_library): Don't xstrdup name.
12463
12464 2019-01-10  Pedro Alves  <palves@redhat.com>
12465
12466         * mdebugread.c (parse_partial_symbols): Use
12467         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12468
12469 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12470
12471         * linux-fork.c (scoped_switch_fork_info)
12472         <~scoped_switch_fork_info>: Fix incorrect variable name.
12473
12474 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12475
12476         * linux-fork.c (scoped_switch_fork_info)
12477         <scoped_switch_fork_info>: Make explicit.
12478         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12479
12480 2019-01-10  Tom Tromey  <tom@tromey.com>
12481
12482         * objfiles.h (objfile::reset_psymtabs): Update.
12483         * objfiles.c (objfile::objfile): Update.
12484         * psymtab.h (psymtab_storage::obstack): Update.
12485         (psymtab_storage::m_obstack): Use gdb::optional.
12486         (class psymtab_storage): Update comment.  Remove objfile
12487         parameter.
12488         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12489
12490 2019-01-10  Tom Tromey  <tom@tromey.com>
12491
12492         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12493         <free_psymtabs>: Now private.
12494         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12495         (allocate_psymtab): Use new method.
12496
12497 2019-01-10  Tom Tromey  <tom@tromey.com>
12498
12499         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12500         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12501         * mdebugread.c (parse_partial_symbols): Use
12502         allocate_dependencies.
12503         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12504         allocate_dependencies.
12505         (process_psymtab_comp_unit_reader)
12506         (build_type_psymtab_dependencies): Likewise.
12507         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12508
12509 2019-01-10  Tom Tromey  <tom@tromey.com>
12510
12511         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12512         PSYMBOL_SET_LANGUAGE.
12513         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12514
12515 2019-01-10  Tom Tromey  <tom@tromey.com>
12516
12517         * psymtab.h (psymtab_storage::obstack): New method.
12518         <m_obstack>: Rename from obstack; now private.
12519         * psymtab.c (psymtab_storage): Update.
12520         * dwarf2read.c (create_addrmap_from_index)
12521         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12522         Update.
12523
12524 2019-01-10  Tom Tromey  <tom@tromey.com>
12525
12526         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12527         * objfiles.h (objfile::reset_psymtabs): New method.
12528
12529 2019-01-10  Tom Tromey  <tom@tromey.com>
12530
12531         * symmisc.c (print_symbol_bcache_statistics): Update.
12532         (print_objfile_statistics): Update.
12533         * symfile.c (reread_symbols): Update.
12534         * psymtab.h (class psymtab_storage): New.
12535         * psymtab.c (psymtab_storage): New constructor.
12536         (~psymtab_storage): New destructor.
12537         (require_partial_symbols): Update.
12538         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12539         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12540         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12541         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12542         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12543         (start_psymtab_common, end_psymtab_common)
12544         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12545         (allocate_psymtab): Update.
12546         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12547         Update.
12548         (dump_psymtab_addrmap, maintenance_print_psymbols)
12549         (maintenance_check_psymtabs): Update.
12550         (class objfile_psymtabs): Move to objfiles.h.
12551         * psympriv.h (discard_psymtab): Now inline.
12552         (psymtab_discarder::psymtab_discarder): Update.
12553         (psymtab_discarder::~psymtab_discarder): Update.
12554         (ALL_OBJFILE_PSYMTABS): Rewrite.
12555         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12556         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12557         Remove fields.
12558         <partial_symtabs>: New field.
12559         (class objfile_psymtabs): Move from psymtab.h.  Update.
12560         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12561         psymbol_cache.
12562         (objfile::~objfile): Don't destroy psymbol_cache.
12563         * mdebugread.c (parse_partial_symbols): Update.
12564         * dwarf2read.c (create_addrmap_from_index)
12565         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12566         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12567         (add_partial_subprogram, dwarf2_ranges_read): Update.
12568         * dwarf-index-write.c (write_address_map)
12569         (write_one_signatured_type, recursively_write_psymbols)
12570         (class debug_names, class debug_names, write_psymtabs_to_index):
12571         Update.
12572
12573 2019-01-10  Tom Tromey  <tom@tromey.com>
12574
12575         * symtab.h (SYMBOL_SET_NAMES): Update.
12576         (symbol_set_names): Update.
12577         (MSYMBOL_SET_NAMES): Update.
12578         * symtab.c (symbol_set_names): Change argument to be an
12579         objfile_per_bfd_storage.
12580         * psymtab.c (add_psymbol_to_bcache): Update.
12581         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12582
12583 2019-01-10  Tom Tromey  <tom@tromey.com>
12584
12585         * symtab.c (create_demangled_names_hash): Change argument to be an
12586         objfile_per_bfd_storage.
12587         (symbol_set_names): Update.
12588
12589 2019-01-10  Tom Tromey  <tom@tromey.com>
12590
12591         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12592         init_psymbol_list.
12593         * psymtab.c (init_psymbol_list): Do nothing if already called.
12594         * psympriv.h (init_psymbol_list): Add comment.
12595         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12596         init_psymbol_list.
12597         * dbxread.c (dbx_symfile_read): Unconditionally call
12598         init_psymbol_list.
12599
12600 2019-01-10  Tom Tromey  <tom@tromey.com>
12601
12602         * xcoffread.c (scan_xcoff_symtab): Update.
12603         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12604         "where".
12605         * mdebugread.c (parse_partial_symbols)
12606         (handle_psymbol_enumerators): Update.
12607         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12608         * dbxread.c (read_dbx_symtab): Update.
12609         * psympriv.h (psymbol_placement): New enum.
12610         (add_psymbol_to_list): Update.
12611
12612 2019-01-10  Tom Tromey  <tom@tromey.com>
12613
12614         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12615         static_psymbols parameters.
12616         (scan_xcoff_symtab): Update.
12617         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12618         static_psymbols parameters.
12619         * psympriv.h (start_psymtab_common): Update.
12620         * mdebugread.c (parse_partial_symbols): Update.
12621         * dwarf2read.c (create_partial_symtab): Update.
12622         * dbxread.c (read_dbx_symtab): Update.
12623         (start_psymtab): Remove global_psymbols and static_psymbols
12624         parameters.
12625
12626 2019-01-10  Tom Tromey  <tom@tromey.com>
12627
12628         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12629         * psymtab.c (allocate_psymtab): Add comment.
12630         * psympriv.h (allocate_psymtab): Add comment.
12631         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12632         initializations.
12633         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12634
12635 2019-01-10  Tom Tromey  <tom@tromey.com>
12636
12637         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12638         Don't declare.
12639         * mipsread.c: Include mdebugread.h.
12640         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12641         Declare.
12642         * elfread.c: Include mdebugread.h.
12643
12644 2019-01-09  Tom Tromey  <tom@tromey.com>
12645
12646         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12647         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12648         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12649         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12650         (psym_lookup_symbol, psym_find_last_source_symtab)
12651         (psym_forget_cached_source_info, psym_print_stats)
12652         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12653         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12654         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12655         (psym_find_compunit_symtab_by_address)
12656         (maintenance_print_psymbols, maintenance_info_psymtabs)
12657         (maintenance_check_psymtabs): Use ranged for.
12658         * psymtab.h (class objfile_psymtabs): New.
12659         (require_partial_symbols): Return objfile_psymtabs.
12660         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12661
12662 2019-01-09  Tom Tromey  <tom@tromey.com>
12663
12664         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12665         (find_pc_mapped_section, list_overlays_command)
12666         (map_overlay_command, unmap_overlay_command)
12667         (simple_overlay_update): Use all_objfiles.
12668         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12669         * printcmd.c (info_symbol_command): Use all_objfiles.
12670         * objfiles.h (ALL_OBJSECTIONS): Remove.
12671         * maint.c (maintenance_translate_address): Use all_objfiles.
12672         * gcore.c (gcore_create_callback): Use all_objfiles.
12673         (objfile_find_memory_regions): Likewise.
12674
12675 2019-01-09  Tom Tromey  <tom@tromey.com>
12676
12677         * symtab.c (find_line_symtab, info_sources_command)
12678         (make_source_files_completion_list): Use objfile_compunits.
12679         * source.c (select_source_symtab): Use objfile_compunits.
12680         * objfiles.h (struct objfile): Update comment.
12681         (ALL_OBJFILES): Remove.
12682         (ALL_FILETABS): Remove.
12683         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12684         objfile_compunits.
12685
12686 2019-01-09  Tom Tromey  <tom@tromey.com>
12687
12688         * symmisc.c (print_objfile_statistics, dump_objfile)
12689         (maintenance_print_symbols): Use compunit_filetabs.
12690         * source.c (forget_cached_source_info_for_objfile): Use
12691         compunit_filetabs.
12692         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12693         (ALL_FILETABS): Use compunit_filetabs.
12694         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12695         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12696
12697 2019-01-09  Tom Tromey  <tom@tromey.com>
12698
12699         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12700         (compunit_filetabs): New.
12701         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12702         compunit_filetabs.
12703         (info_sources_command, make_source_files_completion_list): Remove
12704         declaration.
12705         * symmisc.c (print_objfile_statistics, dump_objfile)
12706         (maintenance_print_symbols): Remove declaration.
12707         (maintenance_info_symtabs): Use compunit_filetabs.
12708         (maintenance_info_line_tables): Likewise.
12709         * source.c (select_source_symtab): Change local variable name.
12710         (forget_cached_source_info_for_objfile): Remove declaration.
12711         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12712         * objfiles.c (objfile_relocate1): Remove declaration.
12713         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12714         declaration.
12715         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12716         * coffread.c (coff_symtab_read): Remove declaration.
12717         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12718         compunit_filetabs.
12719
12720 2019-01-09  Tom Tromey  <tom@tromey.com>
12721
12722         * symtab.c (lookup_objfile_from_block)
12723         (find_pc_sect_compunit_symtab, search_symbols)
12724         (default_collect_symbol_completion_matches_break_on): Use
12725         objfile_compunits.
12726         * objfiles.h (ALL_COMPUNITS): Remove.
12727         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12728         * cp-support.c (add_symbol_overload_list_qualified): Use
12729         objfile_compunits.
12730         * ada-lang.c (ada_collect_symbol_completion_matches)
12731         (ada_add_global_exceptions): Use objfile_compunits.
12732
12733 2019-01-09  Tom Tromey  <tom@tromey.com>
12734
12735         * source.c (select_source_symtab)
12736         (forget_cached_source_info_for_objfile): Remove declaration.
12737         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12738         declaration.
12739         * maint.c (count_symtabs_and_blocks): Remove declaration.
12740         * cp-support.c (add_symbol_overload_list_qualified): Remove
12741         declaration.
12742         * coffread.c (coff_symtab_read): Remove declaration.
12743         * symtab.c (lookup_symbol_in_objfile_symtabs)
12744         (basic_lookup_transparent_type_1): Use objfile_compunits.
12745         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12746         (info_sources_command, search_symbols)
12747         (default_collect_symbol_completion_matches_break_on)
12748         (make_source_files_completion_list): Remove declaration.
12749         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12750         (ada_collect_symbol_completion_matches)
12751         (ada_add_global_exceptions): Remove declaration.
12752         * linespec.c (iterate_over_all_matching_symtabs): Use
12753         objfile_compunits.
12754         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12755         (class objfile_compunits): New.
12756         (ALL_COMPUNITS): Use objfile_compunits.
12757         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12758         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12759         objfile_compunits.
12760         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12761
12762 2019-01-09  Tom Tromey  <tom@tromey.com>
12763
12764         * symtab.c (search_symbols)
12765         (default_collect_symbol_completion_matches_break_on): Use
12766         objfile_msymbols.
12767         * ada-lang.c (ada_lookup_simple_minsym)
12768         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12769         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12770         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12771         objfile_msymbols.
12772         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12773         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12774         * objc-lang.c (find_methods): Use objfile_msymbols.
12775         (info_selectors_command, info_classes_command): Likewise.
12776         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12777         * objfiles.h (class objfile_msymbols): New.
12778         (ALL_OBJFILE_MSYMBOLS): Remove.
12779         (ALL_MSYMBOLS): Remove.
12780
12781 2019-01-09  Tom Tromey  <tom@tromey.com>
12782
12783         * common/next-iterator.h (next_adapter): Add Iterator template
12784         parameter.
12785         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12786         (class all_objfiles_safe): New.
12787         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12788         * objfiles.c (put_objfile_before): Update comment.
12789         (add_separate_debug_objfile): Likewise.
12790         (free_all_objfiles): Use all_objfiles_safe.
12791         (objfile_purge_solibs): Likewise.
12792
12793 2019-01-09  Tom Tromey  <tom@tromey.com>
12794
12795         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12796         (expand_symtab_containing_pc, lookup_static_symbol)
12797         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12798         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12799         all_objfiles.
12800         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12801         * breakpoint.c (create_overlay_event_breakpoint)
12802         (create_longjmp_master_breakpoint)
12803         (create_std_terminate_master_breakpoint)
12804         (create_exception_master_breakpoint): Use all_objfiles.
12805         * linux-thread-db.c (try_thread_db_load_from_pdir)
12806         (has_libpthread): Use all_objfiles.
12807         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12808         * linespec.c (iterate_over_all_matching_symtabs)
12809         (search_minsyms_for_name): Use all_objfiles.
12810         * maint.c (maintenance_info_sections): Use all_objfiles.
12811         * main.c (captured_main_1): Use all_objfiles.
12812         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12813         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12814         * guile/scm-pretty-print.c
12815         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12816         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12817         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12818         (maintenance_print_msymbols): Use all_objfiles.
12819         * source.c (select_source_symtab): Use all_objfiles.
12820         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12821         * symfile.c (remove_symbol_file_command)
12822         (expand_symtabs_matching, map_symbol_filenames): Use
12823         all_objfiles.
12824         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12825         all_objfiles.
12826         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12827         * objc-lang.c (find_methods): Use all_objfiles.
12828         * objfiles.c (have_partial_symbols, have_full_symbols)
12829         (have_minimal_symbols, qsort_cmp)
12830         (default_iterate_over_objfiles_in_search_order): Use
12831         all_objfiles.
12832         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12833         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12834         (maintenance_check_psymtabs): Use all_objfiles.
12835         (ALL_PSYMTABS): Remove.
12836         * compile/compile-object-run.c (do_module_cleanup): Use
12837         all_objfiles.
12838         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12839         * cp-support.c (add_symbol_overload_list_qualified): Use
12840         all_objfiles.
12841         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12842         Use all_objfiles.
12843         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12844         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12845         all_objfiles.
12846         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12847         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12848         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12849         Uses all_objfiles.
12850         * solib.c (solib_read_symbols): Use all_objfiles
12851
12852 2019-01-09  Tom Tromey  <tom@tromey.com>
12853
12854         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12855         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12856         all_objfiles.
12857         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12858         * symmisc.c (print_symbol_bcache_statistics)
12859         (print_objfile_statistics, maintenance_print_objfiles)
12860         (maintenance_info_symtabs, maintenance_check_symtabs)
12861         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12862         all_objfiles.
12863         * source.c (forget_cached_source_info): Use all_objfiles.
12864         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12865         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12866         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12867         * objfiles.c (update_section_map): Use all_objfiles.
12868         (shared_objfile_contains_address_p): Likewise.
12869         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12870         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12871
12872 2019-01-09  Tom Tromey  <tom@tromey.com>
12873
12874         * common/next-iterator.h: New file.
12875         * objfiles.h (class all_objfiles): New.
12876         (struct objfile_iterator): New.
12877
12878 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12879
12880         * NEWS: Move the description of the changed "frame", "select-frame",
12881          and "info frame" commands to the Changed commands section.
12882
12883 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12884
12885         * gdbtypes.c (check_stub_method_group): Remove handling of old
12886         mangling schemes.
12887         * linespec.c (find_methods): Likewise.
12888         * stabsread.c (read_member_functions): Likewise.
12889         * valops.c (search_struct_method): Likewise.
12890         (value_struct_elt_for_reference): Likewise.
12891         * NEWS: Mention this change.
12892
12893 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12894
12895         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12896         print_source_lines.
12897         * source.c (print_source_lines_base): Update line number check.
12898         (print_source_lines): New function.
12899         (source_lines_range::source_lines_range): New function.
12900         * source.h (class source_lines_range): New class.
12901         (print_source_lines): New declaration.
12902
12903 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12904
12905         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12906
12907 2019-01-08  Tom Tromey  <tom@tromey.com>
12908             Simon Marchi  <simon.marchi@ericsson.com>
12909
12910         PR gdb/24060
12911         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12912         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12913         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12914         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12915         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12916         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12917
12918 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12919
12920         * source.c (select_source_symtab): Move header comment to
12921         declaration in source.h.
12922         (forget_cached_source_info_for_objfile): Likewise.
12923         (forget_cached_source_info): Likewise.
12924         (identify_source_line): Likewise.
12925         * source.h (identify_source_line): Move declaration from symtab.h
12926         and add comment from source.c
12927         (print_source_lines): Likewise.
12928         (forget_cached_source_info_for_objfile): Likewise.
12929         (forget_cached_source_info): Likewise.
12930         (select_source_symtab): Likewise.
12931         (enum print_source_lines_flag): Move definition from symtab.h.
12932         * symtab.h (identify_source_line): Move declaration to source.h.
12933         (print_source_lines): Likewise.
12934         (forget_cached_source_info_for_objfile): Likewise.
12935         (forget_cached_source_info): Likewise.
12936         (select_source_symtab): Likewise.
12937         (enum print_source_lines_flag): Move definition to source.h.
12938         * tui/tui-hooks.c: Add 'source.h' include.
12939
12940 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12941
12942         * source.c (print_source_lines_base): Handle requests to print
12943         reverse line number sequences, and guard against empty lines
12944         string.
12945
12946 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12947
12948         * source.c (print_source_lines_base): Fix skip of '\r' if next
12949         character is '\n'.
12950
12951 2019-01-06  Tom Tromey  <tom@tromey.com>
12952
12953         * c-exp.y (struct c_parse_state) <macro_original_text,
12954         expansion_obstack>: New member.
12955         (macro_original_text, expansion_obstack): Remove globals.
12956         (scan_macro_expansion, scanning_macro_expansion)
12957         (finished_macro_expansion): Update.
12958         (scan_macro_cleanup): Remove.
12959         (yylex, c_parse): Update.
12960
12961 2019-01-06  Tom Tromey  <tom@tromey.com>
12962
12963         * c-exp.y (struct c_parse_state) <strings>: New member.
12964         (operator_stoken): Update.
12965
12966 2019-01-06  Tom Tromey  <tom@tromey.com>
12967
12968         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12969         (union type_stack_elt) <typelist_val>: Now a pointer to
12970         std::vector.
12971         (type_stack_cleanup): Don't declare.
12972         (push_typelist): Update.
12973         * parse.c (pop_typelist): Return a std::vector.
12974         (push_typelist): Take a std::vector.
12975         (follow_types): Update.  Do not free args.
12976         (type_stack_cleanup): Remove.
12977         * c-exp.y (struct c_parse_state): New.
12978         (cpstate): New global.
12979         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12980         (nonempty_typelist): Update.
12981         (func_mod): Create a new vector.
12982         (c_parse): Create a c_parse_state.
12983         (check_parameter_typelist): Do not delete params.
12984         (function_method): Update.  Do not delete type_list.
12985
12986 2019-01-06  Tom Tromey  <tom@tromey.com>
12987
12988         PR gdb/28155:
12989         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12990         check_typedef.
12991         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12992         (print_return_value): Likewise.
12993
12994 2019-01-05  Tom Tromey  <tom@tromey.com>
12995
12996         * contrib/cleanup_check.py: Remove.
12997         * contrib/gcc-with-excheck: Remove.
12998         * contrib/exsummary.py: Remove.
12999         * contrib/excheck.py: Remove.
13000
13001 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13002
13003         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13004         NULL. Initialize tpprev to NULL instead of assigning it
13005         to NULL on the next statement.
13006         * windows-nat.c (windows_delete_thread): Remove check for
13007         main_thread_id before printing thread exit notifications.
13008         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13009         Remove thread ID check against main_thread_id.
13010         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13011         windows_delete_thread.
13012         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13013
13014 2019-01-04  Tom Tromey  <tom@tromey.com>
13015
13016         * compile/compile.c (_initialize_compile): Use upper case for
13017         metasyntactic variables.
13018         * symmisc.c (_initialize_symmisc): Use upper case for
13019         metasyntactic variables.
13020         * psymtab.c (_initialize_psymtab): Use upper case for
13021         metasyntactic variables.
13022         * demangle.c (demangle_command): Use upper case for metasyntactic
13023         variables.
13024         (_initialize_demangler): Likewise.
13025         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13026         variables.
13027
13028 2019-01-03  Tom Tromey  <tom@tromey.com>
13029
13030         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13031
13032 2019-01-03  Tom Tromey  <tom@tromey.com>
13033
13034         * python/py-symtab.c (salpy_str): Update.
13035         (struct salpy_sal_object) <symtab>: Now a PyObject.
13036         (salpy_dealloc): Update.
13037         (del_objfile_sal): Use gdbpy_ref.
13038
13039 2019-01-03  Tom Tromey  <tom@tromey.com>
13040
13041         * python/py-type.c (convert_field): Use new_reference.  Return
13042         gdbpy_ref.
13043         (make_fielditem): Return gdbpy_ref.
13044         (typy_fields): Update.
13045         (typy_getitem): Update.
13046         (field_name): Return gdbpy_ref.  Use new_reference.
13047         (typy_iterator_iternext): Update.
13048
13049 2019-01-03  Tom Tromey  <tom@tromey.com>
13050
13051         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13052
13053 2019-01-03  Tom Tromey  <tom@tromey.com>
13054
13055         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13056         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13057         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13058         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13059         (pspy_set_type_printers): Likewise.
13060         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13061         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13062         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13063         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13064         (objfpy_set_type_printers): Likewise.
13065
13066 2019-01-03  Tom Tromey  <tom@tromey.com>
13067
13068         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13069         (gdbpy_print_stack): Use gdbpy_err_fetch.
13070         * python/python-internal.h (class gdbpy_err_fetch): New class.
13071         (class gdbpy_enter) <m_error_type, m_error_value,
13072         m_error_traceback>: Remove.
13073         <m_error>: New member.
13074         (gdbpy_exception_to_string): Don't declare.
13075         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13076         * python/py-value.c (convert_value_from_python): Use
13077         gdbpy_err_fetch.
13078         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13079         gdbpy_exception_to_string.
13080         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13081         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13082         gdbpy_err_fetch.
13083
13084 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13085
13086         * linux-nat.c (delete_lwp_cleanup): Delete.
13087         (struct lwp_deleter): New struct.
13088         (lwp_info_up): New typedef.
13089         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13090         lwp_info_up.
13091
13092 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13093
13094         * linux-fork.c (class scoped_switch_fork_info): New class.
13095         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13096
13097 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13098
13099         * valops.c (find_overload_match): Remove use of null_cleanup, and
13100         calls to do_cleanups.
13101
13102 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13103
13104         * compile/compile-cplus-types.c
13105         (compile_cplus_instance::decl_name): Handle changes to
13106         cp_func_name.
13107         * cp-support.c (cp_func_name): Update header comment, update
13108         return type.
13109         * cp-support.h (cp_func_name): Update return type in declaration.
13110         * valops.c (find_overload_match): Move temp_func local to top
13111         level of function and change its type.  Use temp_func to hold and
13112         delete temporary string obtained from cp_func_name.
13113
13114 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13115
13116         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13117         gdb::char_vector, remove cleanup, and update uses of `msg`.
13118
13119 2019-01-03  Jim Wilson  <jimw@sifive.com>
13120
13121         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13122
13123 2019-01-02  Tom Tromey  <tom@tromey.com>
13124
13125         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13126         (tdesc_parse_xml): Remove cleanups.
13127         * target-descriptions.h (make_cleanup_free_target_description):
13128         Don't declare.
13129         (target_desc_deleter): New struct.
13130         (target_desc_up): New typedef.
13131         * target-descriptions.c (target_desc_deleter::operator()): Rename
13132         from free_target_description.
13133         (make_cleanup_free_target_description): Remove.
13134
13135 2019-01-02  Tom Tromey  <tom@tromey.com>
13136
13137         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13138         constructor, destructor.
13139         (linespec_parser): Remove typedef.
13140         (~linespec_parser): Rename from linespec_parser_delete.
13141         (linespec_lex_to_end, linespec_complete_label)
13142         (linespec_complete): Update.
13143         (decode_line_full): Remove cleanups.
13144         (decode_line_1): Update.
13145
13146 2019-01-02  Tom Tromey  <tom@tromey.com>
13147
13148         * python/python-internal.h (inferior_to_inferior_object): Change
13149         return type.
13150         * python/py-exitedevent.c (create_exited_event_object): Update.
13151         * python/py-inferior.c (inferior_to_inferior_object): Return
13152         gdbpy_ref.
13153         (python_new_inferior, python_inferior_deleted)
13154         (thread_to_thread_object, delete_thread_object)
13155         (build_inferior_list, gdbpy_selected_inferior): Update.
13156         * python/py-infthread.c (create_thread_object): Update.  Also fail
13157         if inferior_to_inferior_object fails.
13158
13159 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13160
13161         * inferior.h (class inferior) <displaced_step_state>: New field.
13162         * infrun.h (struct displaced_step_state): Move here from
13163         infrun.c.  Initialize fields, add constructor.
13164         <inf>: Remove field.
13165         <reset>: New method.
13166         * infrun.c (struct displaced_step_inferior_state): Move to
13167         infrun.h.
13168         (displaced_step_inferior_states): Remove.
13169         (get_displaced_stepping_state): Adust.
13170         (displaced_step_in_progress_any_inferior): Adjust.
13171         (displaced_step_in_progress_thread): Adjust.
13172         (displaced_step_in_progress): Adjust.
13173         (add_displaced_stepping_state): Remove.
13174         (get_displaced_step_closure_by_addr): Adjust.
13175         (remove_displaced_stepping_state): Remove.
13176         (infrun_inferior_exit): Call displaced_step_state.reset.
13177         (use_displaced_stepping): Don't check for NULL.
13178         (displaced_step_prepare_throw): Call
13179         get_displaced_stepping_state.
13180         (displaced_step_fixup): Don't check for NULL.
13181         (prepare_for_detach): Don't check for NULL.
13182
13183 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13184
13185         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13186          in case of call that did not complete.
13187
13188 2019-01-02  Andrey Utkin  <autkin@undo.io>
13189
13190         * symfile.c (find_separate_debug_file): Fix search of debug files for
13191         remote debuggee.
13192
13193 2019-01-02  Tom Tromey  <tom@tromey.com>
13194
13195         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13196         indentation.
13197         * python/py-frame.c (frapy_older): Remove cast.
13198         (frapy_newer): Likewise.
13199         * python/py-breakpoint.c (local_setattro): Remove cast.
13200         * python/py-arch.c (archpy_name): Remove local variable.
13201         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13202
13203 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13204
13205         * unittests/basic_string_view/element_access/char/empty.cc:
13206         Fix year range in copyright header.
13207
13208 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13209
13210         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13211         Delete.
13212         <operator==>: Update with for removed field.
13213         <hash>: Likewise.
13214         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13215         <isa_features>: ...this.
13216         <abi_features>: New field.
13217         (riscv_isa_flen): Update comment.
13218         (riscv_abi_xlen): New declaration.
13219         (riscv_abi_flen): New declaration.
13220         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13221         isa_features.
13222         (riscv_abi_xlen): New function.
13223         (riscv_isa_flen): Update to get answer from isa_features.
13224         (riscv_abi_flen): New function.
13225         (riscv_has_fp_abi): Update to get answer from abi_features.
13226         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13227         xlen and flen.
13228         (riscv_call_info) <xlen, flen>: Update comment.
13229         (riscv_call_arg_struct): Remove invalid assertions
13230         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13231         is removed.
13232         (riscv_gdbarch_init): Gather isa features and abi features
13233         separately, ensure both match on the gdbarch when reusing an old
13234         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13235         a target with 64-bit float hardware.
13236
13237 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13238
13239         * source.c (search_command_helper): Stop reverse search
13240         when line 1 has been searched.
13241
13242 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13243
13244         * record-full.c (record_full_base_target::close): Rewrite
13245         record_full_core_buf_list free logic.
13246
13247 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13248
13249         * break-catch-syscall.c (print_one_catch_syscall): xfree
13250         the last text.
13251
13252 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13253
13254         * top.c (print_gdb_version): Update Copyright year in version
13255         message.
13256
13257 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13258
13259         Update copyright year range in all GDB files.
13260
13261 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13262
13263         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13264
13265 For older changes see ChangeLog-2018.
13266 \f
13267 Local Variables:
13268 mode: change-log
13269 left-margin: 8
13270 fill-column: 74
13271 version-control: never
13272 coding: utf-8
13273 End:
13274