gdb/ChangeLog

   1 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
   2
   3         * ctfread.c: New file.
   4         * ctfread.h: New file.
   5         * elfread.c: Include ctfread.h.
   6         (struct elfinfo text_p): New member ctfsect.
   7         (elf_locate_sections): Mark CTF section.
   8         (elf_symfile_read): Call elfctf_build_psymtabs.
   9         * Makefile.in (LIBCTF): Add.
  10         (CLIBS): Use it.
  11         (CDEPS): Likewise.
  12         (DIST): Add ctfread.c.
  13         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
  14         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
  15
  16 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
  17
  18         * tracectf.h: Rename, was ctf.h.
  19         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
  20         * tracefile.c: Likewise.
  21         * tracepoint.c: Remove unused include ctf.h.
  22         * mi/mi-main.c: Likewise.
  23         * Makefile.in Replace ctf.c with tracectf.c.
  24
  25 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
  26
  27         * version.in: Change version number to "9.0.50.DATE-git".
  28
  29 2019-10-03  Tom Tromey  <tom@tromey.com>
  30
  31         PR rust/24976:
  32         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
  33
  34 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  35
  36         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
  37         cp_search_name_hash.
  38         * NEWS: Add entry about nested function support.
  39
  40 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
  41             Andrew Burgess  <andrew.burgess@embecosm.com>
  42
  43         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
  44         for nested static variables when searchin VAR_DOMAIN.
  45         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
  46         global scope, update comment.
  47         (add_partial_subprogram): Call add_partial_subprogram recursively
  48         for nested subroutines when processinng Fortran.
  49         (load_partial_dies): Process the child entities of a subprogram
  50         when processing Fortran.
  51         (partial_die_parent_scope): Handle building scope
  52         for Fortran nested functions.
  53         (process_die): Record that nested functions have a scope.
  54         (new_symbol): Always record Fortran subprograms on the global
  55         symbol list.
  56         (determine_prefix): How to build the prefix for Fortran
  57         subprograms.
  58
  59 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  60
  61         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
  62         have just sent the thread a SIGSTOP and are waiting for it to
  63         arrive.
  64
  65 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  66
  67         * btrace.c (btrace_add_pc): Remove whitespace before the template
  68         parameter in 'std::vector <...>'.
  69         (parse_xml_btrace_block): Likewise.
  70         (btrace_maint_decode_pt): Likewise.
  71         (btrace_maint_update_packets): Likewise.
  72         (btrace_maint_print_packets): Likewise.
  73         * btrace.h (struct btrace_maint_info): Likewise.
  74         * dwarf2read.c (struct type_unit_group): Likewise.
  75         (build_type_psymtabs_reader): Likewise.
  76         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
  77         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
  78         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
  79
  80 2019-10-03  Tom de Vries  <tdevries@suse.de>
  81
  82         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
  83         the first line of the help text for set/show style metadata.
  84
  85 2019-10-02  Tom Tromey  <tromey@adacore.com>
  86
  87         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
  88         * gdbsupport/common-inferior.c: New file.
  89         * infcmd.c (startup_with_shell): Don't define.
  90         * nat/fork-inferior.h (startup_with_shell): Don't declare.
  91         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
  92         * inferior.h (startup_with_shell): Don't declare.
  93
  94 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
  95
  96         * gdbsupport/gdb_assert.h: Include errors.h.
  97         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
  98
  99 2019-10-02  Tom Tromey  <tromey@adacore.com>
 100
 101         * NEWS: Add $_ada_exception entry.
 102         * ada-lang.c (struct ada_catchpoint): Add constructor.
 103         <m_kind>: New member.
 104         (allocate_location_exception, re_set_exception): Remove
 105         "ex" parameter.
 106         (should_stop_exception): Compute $_ada_exception.
 107         (check_status_exception, print_it_exception)
 108         (print_one_exception, print_mention_exception): Remove
 109         "ex" parameter.
 110         (allocate_location_catch_exception, re_set_catch_exception)
 111         (check_status_exception, print_it_catch_exception)
 112         (print_one_catch_exception, print_mention_catch_exception)
 113         (print_recreate_catch_exception)
 114         (allocate_location_catch_exception_unhandled)
 115         (re_set_catch_exception_unhandled)
 116         (check_status_exception, print_it_catch_exception_unhandled)
 117         (print_one_catch_exception_unhandled)
 118         (print_mention_catch_exception_unhandled)
 119         (print_recreate_catch_exception_unhandled)
 120         (allocate_location_catch_assert, re_set_catch_assert)
 121         (check_status_assert, print_it_catch_assert)
 122         (print_one_catch_assert, print_mention_catch_assert)
 123         (print_recreate_catch_assert)
 124         (allocate_location_catch_handlers, re_set_catch_handlers)
 125         (check_status_handlers, print_it_catch_handlers)
 126         (print_one_catch_handlers, print_mention_catch_handlers)
 127         (print_recreate_catch_handlers): Remove.
 128         (create_ada_exception_catchpoint): Update.
 129         (initialize_ada_catchpoint_ops): Update.
 130
 131 2019-10-02  Tom Tromey  <tromey@adacore.com>
 132
 133         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 134         (create_excep_cond_exprs): Simplify exception string computation.
 135         (ada_exception_catchpoint_cond_string): Likewise.
 136
 137 2019-10-02  Tom Tromey  <tromey@adacore.com>
 138
 139         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 140         * ada-lang.c (lesseq_defined_than): Handle
 141         LOC_STATIC.
 142         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 143         parameter.
 144         (dwarf2_has_info): Likewise.
 145         (new_symbol): Set maybe_copied on symbol when
 146         appropriate.
 147         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 148         parameter.
 149         <can_copy>: New member.
 150         * elfread.c (record_minimal_symbol): Set maybe_copied
 151         on symbol when appropriate.
 152         (elf_symfile_read): Update call to dwarf2_has_info.
 153         * minsyms.c (lookup_minimal_symbol_linkage): New
 154         function.
 155         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 156         * symtab.c (get_symbol_address, get_msymbol_address):
 157         New functions.
 158         * symtab.h (get_symbol_address, get_msymbol_address):
 159         Declare.
 160         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 161         maybe_copied.
 162         (struct symbol, struct minimal_symbol) <maybe_copied>:
 163         New member.
 164
 165 2019-10-02  Tom Tromey  <tromey@adacore.com>
 166
 167         * source.c (struct current_source_location): New.
 168         (current_source_key): New global.
 169         (current_source_symtab, current_source_line)
 170         (current_source_pspace): Remove.
 171         (get_source_location): New function.
 172         (get_current_source_symtab_and_line)
 173         (set_default_source_symtab_and_line)
 174         (set_current_source_symtab_and_line)
 175         (clear_current_source_symtab_and_line, select_source_symtab)
 176         (info_source_command, print_source_lines_base)
 177         (info_line_command, search_command_helper, _initialize_source):
 178         Update.
 179
 180 2019-10-02  Tom Tromey  <tromey@adacore.com>
 181
 182         * source.c (select_source_symtab): Don't call
 183         decode_line_with_current_source.
 184
 185 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 186
 187         * symtab.c (lookup_global_symbol): Search global block.
 188
 189 2019-10-02  Tom Tromey  <tromey@adacore.com>
 190
 191         * coffread.c (process_coff_symbol): Update.
 192         * dwarf2read.c (var_decode_location, new_symbol): Update.
 193         * mdebugread.c (parse_symbol): Update.
 194         * objfiles.c (relocate_one_symbol): Update.
 195         * stabsread.c (define_symbol, fix_common_block)
 196         (scan_file_globals): Update.
 197         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 198         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 199         * xcoffread.c (process_xcoff_symbol): Update.
 200
 201 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 202
 203         * MAINTAINERS: Update my email address.
 204
 205 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 206
 207         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 208         std::vector.
 209         (build_type_psymtabs_reader): Update for std::vector.
 210         (build_type_psymtab_dependencies): Likewise.
 211         * dwarf2read.h: Remove use of DEF_VEC_P.
 212         (typedef sig_type_ptr): Delete.
 213
 214 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 215
 216         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 217         to std::vector.
 218         (btrace_maint_decode_pt): Likewise, and move allocation of the
 219         vector outside of the loop.
 220         (btrace_maint_update_packets): Update to handle change from VEC to
 221         std::vector.
 222         (btrace_maint_print_packets): Likewise.
 223         (maint_info_btrace_cmd): Likewise.
 224         * btrace.h: Remove use of DEF_VEC_O.
 225         (typedef btrace_pt_packet_s): Delete.
 226         (struct btrace_maint_info) <packets>: Change fromm VEC to
 227         std::vector.
 228         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 229
 230 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 231
 232         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 233         make accesses into the vector constant references.
 234         (btrace_add_pc): Update for std::vector.
 235         (btrace_stitch_bts): Likewise.
 236         (parse_xml_btrace_block): Likewise.
 237         (btrace_maint_update_packets): Likewise.
 238         (btrace_maint_print_packets): Likewise.
 239         (maint_info_btrace_cmd): Likewise.
 240         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 241         std::vector.
 242         (btrace_data::empty): Likewise.
 243         (btrace_data_append): Likewise.
 244         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 245         (typedef btrace_block_s): Delete.
 246         (struct btrace_block): Add constructor.
 247         (struct btrace_data_bts) <blocks>: Change to std::vector.
 248         * nat/linux-btrace.c (perf_event_read_bts): Update for
 249         std::vector.
 250         (linux_read_bts): Likewise.
 251
 252 2019-10-01  Tom Tromey  <tom@tromey.com>
 253
 254         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 255
 256 2019-10-01  Tom Tromey  <tom@tromey.com>
 257
 258         * stack.c (print_frame, info_frame_command_core): Use
 259         styled_string.
 260         * linux-thread-db.c (try_thread_db_load_1)
 261         (try_thread_db_load_from_pdir_1): Use styled_string.
 262         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 263         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 264         (maybe_print_unsupported_script_warning)
 265         (maybe_print_script_not_found_warning): Use styled_string.
 266         * ada-lang.c (user_select_syms): Use styled_string.
 267
 268 2019-10-01  Tom Tromey  <tom@tromey.com>
 269
 270         * p-lang.c (pascal_printstr): Use metadata style.
 271         * value.c (show_convenience): Use metadata style.
 272         * valprint.c (valprint_check_validity, val_print_optimized_out)
 273         (val_print_not_saved, val_print_unavailable)
 274         (val_print_invalid_address, generic_val_print, val_print)
 275         (value_check_printable, val_print_array_elements): Use metadata
 276         style.
 277         * ui-out.h (class ui_out) <field_fmt>: New overload.
 278         <do_field_fmt>: Add style parameter.
 279         * ui-out.c (ui_out::field_fmt): New overload.
 280         * typeprint.c (type_print_unknown_return_type)
 281         (val_print_not_allocated, val_print_not_associated): Use metadata
 282         style.
 283         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 284         parameter.
 285         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 286         * tracepoint.c (tvariables_info_1): Use metadata style.
 287         * stack.c (print_frame_arg, print_frame_info, print_frame)
 288         (info_frame_command_core): Use metadata style.
 289         * skip.c (info_skip_command): Use metadata style.
 290         * rust-lang.c (rust_print_enum): Use metadata style.
 291         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 292         metadata style.
 293         * python/py-framefilter.c (py_print_single_arg): Use metadata
 294         style.
 295         * printcmd.c (do_one_display, print_variable_and_value): Use
 296         metadata style.
 297         * p-valprint.c (pascal_val_print)
 298         (pascal_object_print_value_fields): Use metadata style.
 299         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 300         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 301         parameter.
 302         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 303         * m2-valprint.c (m2_print_long_set): Use metadata style.
 304         * m2-typeprint.c (m2_print_type): Use metadata style.
 305         * infcmd.c (print_return_value_1): Use metadata style.
 306         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 307         * f-valprint.c (info_common_command_for_block): Use metadata
 308         style.
 309         * f-typeprint.c (f_type_print_base): Use metadata style.
 310         * expprint.c (print_subexp_standard): Use metadata style.
 311         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 312         * cli/cli-style.h (class cli_style_option): Add constructor.
 313         (metadata_style): Declare.
 314         * cli/cli-style.c (metadata_style): New global.
 315         (_initialize_cli_style): Register metadata style.
 316         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 317         parameter.
 318         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 319         * c-typeprint.c (c_type_print_base_struct_union)
 320         (c_type_print_base_1): Use metadata style.
 321         * breakpoint.c (watchpoint_value_print)
 322         (print_one_breakpoint_location): Use metadata style.
 323         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 324         style.
 325         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 326         style.
 327         * ada-valprint.c (val_print_packed_array_elements, printstr)
 328         (print_field_values, ada_val_print_ref, ada_val_print): Use
 329         metadata style.
 330         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 331         style.
 332         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 333         style.
 334         * ada-lang.c (user_select_syms): Use metadata style.
 335
 336 2019-10-01  Tom Tromey  <tom@tromey.com>
 337
 338         * cli/cli-cmds.c (pwd_command): Style output.
 339
 340 2019-10-01  Pedro Alves  <palves@redhat.com>
 341             Tom Tromey  <tom@tromey.com>
 342
 343         * symtab.c (print_symbol_info): Use %ps.
 344         (print_msymbol_info): Use %ps.
 345         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 346         * printcmd.c (print_variable_and_value): Use %ps.
 347         * macrocmd.c (show_pp_source_pos): Use %ps.
 348         * infrun.c (print_exited_reason): Use ui_out::message.
 349         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 350         (describe_other_breakpoints): Use ui_out::message and new
 351         formats.
 352         (say_where): Use new formats.
 353         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 354         and new formats.
 355
 356 2019-10-01  Pedro Alves  <palves@redhat.com>
 357             Tom Tromey  <tom@tromey.com>
 358
 359         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 360         (test_gdb_formats): New function.
 361         (run_tests): Call it.
 362         (test_format_specifier): Update.
 363         * utils.h (fputs_filtered): Update comment.
 364         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 365         (fputs_styled_unfiltered): Declare.
 366         * utils.c (fputs_styled_unfiltered): New function.
 367         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 368         (vfprintf_filtered): Update.
 369         (vfprintf_unfiltered, vprintf_filtered): Update.
 370         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 371         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 372         disallow_ui_out_field>: New constants.
 373         (enum class field_kind): New.
 374         (struct base_field_s, struct signed_field_s): New.
 375         (signed_field): New function.
 376         (struct string_field_s): New.
 377         (string_field): New function.
 378         (struct styled_string_s): New.
 379         (styled_string): New function.
 380         (class ui_out) <message>: Add comment.
 381         <vmessage, call_do_message>: New methods.
 382         <do_message>: Add style parameter.
 383         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 384         methods.
 385         (ui_out::message): Rewrite.
 386         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 387         parameter.
 388         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 389         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 390         gdb_extensions parameter.
 391         (class format_piece): Add parameter to constructor.
 392         (n_int_args): New field.
 393         * gdbsupport/format.c (format_pieces::format_pieces): Add
 394         gdb_extensions parameter.  Handle '*'.
 395         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 396         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 397         vfprintf_styled_no_gdbfmt.
 398         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 399         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 400         unfiltered output.
 401         * ui-style.h (struct ui_file_style) <ptr>: New method.
 402
 403 2019-10-01  Tom Tromey  <tom@tromey.com>
 404
 405         * unittests/format_pieces-selftests.c: Update.  Add final format.
 406         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 407         empty literal pieces.
 408
 409 2019-10-01  Tom Tromey  <tom@tromey.com>
 410
 411         * ui-out.h (enum class ui_out_style_kind): Remove.
 412         (class ui_out) <field_string, field_stsream, do_field_string>:
 413         Change type of "style".
 414         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 415         (ui_out::field_string): Update.
 416         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 417         of "style".
 418         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 419         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 420         * stack.c (print_frame_arg, print_frame_info, print_frame):
 421         Update.
 422         * source.c (print_source_lines_base): Update.
 423         * solib.c (info_sharedlibrary_command): Update.
 424         * skip.c (info_skip_command): Update.
 425         * record-btrace.c (btrace_call_history_src_line)
 426         (btrace_call_history): Update.
 427         * python/py-framefilter.c (py_print_frame): Update.
 428         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 429         "style".
 430         * mi/mi-out.c (mi_ui_out::do_table_header)
 431         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 432         (mi_ui_out::do_field_string): Update.
 433         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 434         Update.
 435         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 436         "style".
 437         * cli-out.c (cli_ui_out::do_table_header)
 438         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 439         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 440         (cli_ui_out::do_field_fmt): Update.
 441         * breakpoint.c (print_breakpoint_location): Update.
 442         (update_static_tracepoint): Update.
 443
 444 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 445
 446         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 447         conversion of gdb_datadir.
 448         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 449         remove not needed c_str ().
 450
 451 2019-09-30  Ali Tamur <tamur@google.com>
 452
 453         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 454         (dwarf2_string_attr): Likewise.
 455
 456 2019-09-30  Ali Tamur <tamur@google.com>
 457
 458         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 459         (process_full_type_unit): Likewise.
 460         (dump_die_shallow): Likewise.
 461         (cu_debug_loc_section): Likewise.
 462
 463 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 464
 465         * minsyms.c (compare_minimal_symbols): Rename to...
 466         (minimal_symbol_is_less_than): ...this, and adjust to STL
 467         conventions (return bool, take arguments as references)
 468         (minimal_symbol_reader::install): Call std::sort instead
 469         of qsort.
 470
 471 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 472
 473         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 474         hash and why.
 475         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 476         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 477
 478 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 479
 480         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 481         * psympriv.h (add_psymbol_to_list): Move comment here and update
 482         it.
 483
 484 2019-09-29  Tom de Vries  <tdevries@suse.de>
 485
 486         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 487         Use $tmpdir/$(basename "$output_file").dwz instead of
 488         "${output_file}.dwz".
 489
 490 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 491
 492         PR gdb/25045
 493         * hppa-linux-nat.c: Include gdbarch.h.
 494
 495 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 496
 497         * blockframe.c (find_pc_partial_function): Change return type to bool.
 498         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 499         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 500         (stub_gnu_ifunc_resolve_name): Likewise.
 501         * symtab.c (compare_filenames_for_search): Likewise.
 502         (compare_glob_filenames_for_search): Likewise.
 503         (matching_obj_sections): Likewise.
 504         (symbol_matches_domain): Likewise.
 505         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 506         (find_line_pc): Change return type to bool.
 507         (find_line_pc_range): Likewise.
 508         (producer_is_realview): Likewise.
 509         * symtab.h (symbol_matches_domain): Likewise.
 510         (find_pc_partial_function): Likewise.
 511         (find_pc_line_pc_range): Likewise.
 512         (in_gnu_ifunc_stub): Likewise.
 513         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 514         (find_line_pc): Likewise.
 515         (find_line_pc_range): Likewise.
 516         (matching_obj_sections): Likewise.
 517         (find_line_symtab): Change out parameter to bool.
 518         (producer_is_realview): Change return type to bool.
 519         (compare_filenames_for_search): Likewise.
 520         (compare_glob_filenames_for_search): Likewise.
 521
 522 2019-09-26  Tom Tromey  <tom@tromey.com>
 523
 524         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 525         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 526         * gdb_usleep.h: Remove.
 527         * gdb_usleep.c: Remove.
 528         * utils.c: Don't include gdb_usleep.h.
 529
 530 2019-09-26  Tom Tromey  <tromey@adacore.com>
 531
 532         * python/py-type.c (type_to_type_object): Call check_typedef
 533         for stub types.
 534
 535 2019-09-26  Tom Tromey  <tom@tromey.com>
 536
 537         * utils.h (initialize_utils): Don't declare.
 538         * top.c (gdb_init): Don't call initialize_utils.
 539         * utils.c (initialize_utils): Remove.  Move contents...
 540         (_initialize_utils): ... here.
 541
 542 2019-09-25  Tom Tromey  <tom@tromey.com>
 543
 544         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 545         * utils.h (make_hex_string): Don't declare.
 546         * utils.c (make_hex_string): Remove.
 547
 548 2019-09-24  Tom de Vries  <tdevries@suse.de>
 549
 550         PR gdb/23815
 551         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 552         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 553
 554 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 555
 556         * NEWS: Mention new simulator port for PRU.
 557
 558 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 559
 560         * ada-exp.y (write_object_remaining): Update.
 561         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 562         and eliminate the static buffer.
 563         (ada_decode_symbol): Update.
 564         (ada_la_decode): Update.
 565         (ada_sniff_from_mangled_name): Update.
 566         (is_valid_name_for_wild_match): Update.
 567         (ada_lookup_name_info::matches): Update and simplify.
 568         (name_matches_regex): Update.
 569         (ada_add_global_exceptions): Update.
 570         * ada-lang.h (ada_decode): Update signature.
 571         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 572         * dwarf-index-write.c (debug_names::insert): Update.
 573
 574 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 575
 576         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 577         formatting.
 578
 579 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 580
 581         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 582         Change "nonzero" to "true" in documentation.
 583
 584 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 585
 586         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 587         (_initialize_darwin_solib): Don't set
 588         darwin_so_ops.lookup_lib_global_symbol.
 589         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 590         set_gdbarch_iterate_over_objfiles_in_search_order.
 591         (elf_lookup_lib_symbol): Rename to...
 592         (svr4_iterate_over_objfiles_in_search_order): this, and update
 593         to iterate semantics.
 594         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 595         * solib.c (solib_global_lookup): Remove.
 596         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 597         (solib_global_lookup): Remove.
 598         * symtab.c (lookup_global_or_static_symbol): Remove call to
 599         solib_global_lookup.
 600
 601 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 602
 603         * NEWS: Move entries about default MI version now being
 604         version 3, and about the GDB/MI fix for multi-location
 605         breakpoints to the "since GDB 8.3" section.
 606
 607 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 608
 609         GDB 8.3.1 released.
 610
 611 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 612
 613         * NEWS: Mention that Cell/B.E. debugging support was removed.
 614         * MAINTAINERS: Remove spu target.
 615
 616         * config/djgpp/fnchange.lst: Remove entries for removed files.
 617
 618         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 619         spu-multiarch.o, and spu-tdep.o.
 620         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 621         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 622         spu-multiarch.c, and spu-tdep.c.
 623         * spu-linux-nat.c: Remove file.
 624         * spu-multiarch.c: Remove file.
 625         * spu-tdep.c: Remove file.
 626         * spu-tdep.h: Remove file.
 627         * solib-spu.c: Remove file.
 628         * solib-spu.h: Remove file.
 629
 630         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 631         * configure.nat (spu-linux): Remove.
 632         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 633         solib-multiarch.o from gdb_target_obs.
 634         (spu*-*-*): Remove.
 635
 636         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 637         feature flag.
 638         (ppc_linux_no_features): Update.
 639         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 640         Cell/B.E. support.
 641         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 642         (tdesc_powerpc_cell64l): Likewise.
 643         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 644         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 645         Cell/B.E. support.
 646         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 647         Do not include "features/rs6000/powerpc-cell32l.c" or
 648         "features/rs6000/powerpc-cell64l.c".
 649         (ppc_linux_spu_section): Remove.
 650         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 651         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 652         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 653         (ppc_linux_spe_context_lookup): Remove.
 654         (ppc_linux_spe_context_inferior_created): Remove.
 655         (ppc_linux_spe_context_solib_loaded): Remove.
 656         (ppc_linux_spe_context_solib_unloaded): Remove.
 657         (ppc_linux_spe_context): Remove.
 658         (struct ppu2spu_cache): Remove.
 659         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 660         (struct ppu2spu_data): Remove.
 661         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 662         ppu2spu_unwind): Remove.
 663         (ppc_linux_init_abi): Remove Cell/B.E. support.
 664         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 665
 666         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 667         (rs6000/powerpc-cell64l-expedite): Likewise
 668         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 669         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 670         rs6000/powerpc-cell64l.xml.
 671         * features/rs6000/powerpc-cell32l.xml: Remove.
 672         * features/rs6000/powerpc-cell64l.xml: Likewise.
 673         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 674         * features/rs6000/powerpc-cell64l.c: Likewise.
 675         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 676         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 677         * regformats/reg-spu.dat: Remove.
 678
 679         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 680         * corelow.c (struct spuid_list): Remove.
 681         (add_to_spuid_list): Remove.
 682         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 683         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 684         (remote_protocol_features): Remove associated entries.
 685         (_initialize_remote): No longer initialize them.
 686         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 687         * linux-nat.c (SPUFS_MAGIC): Remove.
 688         (linux_proc_xfer_spu): Remove.
 689         (spu_enumerate_spu_ids): Remove.
 690         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 691         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 692         (linux_make_corefile_notes): No longer call it.
 693
 694         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 695         (cooked_write_test): Likewise.
 696
 697 2019-09-20  Tom Tromey  <tom@tromey.com>
 698
 699         * NEWS: Mention case-sensitivity of TUI commands.
 700         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 701         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 702         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 703
 704 2019-09-20  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-source.c (tui_source_window::set_contents): Use
 707         make_unique_xstrdup.
 708         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 709         make_unique_xstrdup.
 710
 711 2019-09-20  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-data.c: Remove separator comments.
 714         * tui/tui-layout.c: Remove separator comments.
 715         * tui/tui-win.c: Remove separator comments.
 716         * tui/tui-wingeneral.c: Remove separator comments.
 717
 718 2019-09-20  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui.h (strcat_to_buf): Don't declare.
 721         * tui/tui.c (strcat_to_buf): Remove.
 722
 723 2019-09-20  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 726         from "fullname".
 727         * tui/tui-source.c (tui_source_window::set_contents)
 728         (tui_source_window::location_matches_p)
 729         (tui_source_window::maybe_update): Update.
 730
 731 2019-09-20  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 734         Update.
 735         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 736         prefix.
 737         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 738         (tui_data_window::line_from_reg_element_no)
 739         (tui_data_window::first_reg_element_no_inline)
 740         (tui_data_window::show_registers)
 741         (tui_data_window::show_register_group)
 742         (tui_data_window::display_registers_from)
 743         (tui_data_window::display_registers_from_line)
 744         (tui_data_window::first_data_item_displayed)
 745         (tui_data_window::delete_data_content_windows)
 746         (tui_data_window::erase_data_content)
 747         (tui_data_window::do_scroll_vertical)
 748         (tui_data_window::refresh_window)
 749         (tui_data_window::check_register_values): Update.
 750
 751 2019-09-20  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 754         (struct tui_locator_window) <full_name, proc_name>: Now
 755         std::string.
 756         * tui/tui-stack.c (tui_locator_window::make_status_line)
 757         (tui_locator_window::set_locator_fullname)
 758         (tui_locator_window::set_locator_info): Update.
 759         * tui/tui-source.c (tui_source_window::set_contents)
 760         (tui_source_window::showing_source_p): Update.
 761
 762 2019-09-20  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 765         Don't call tui_locator_win_info_ptr.
 766
 767 2019-09-20  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 770
 771 2019-09-20  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 774         height for locator.
 775         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 776         * tui/tui-layout.c (show_source_disasm_command, show_data)
 777         (show_source_or_disasm_and_command): Use 1 as height for locator.
 778
 779 2019-09-20  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui.c (tui_enable): Update.
 782         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 783         Update.
 784         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 785         Update.
 786         * tui/tui-data.c (win_resized): Now bool.
 787         (tui_win_resized): Return bool.
 788         (tui_set_win_resized_to): Accept a bool.
 789
 790 2019-09-20  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 793         Change type of "refresh_values_only".
 794         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 795         type of "refresh_values_only".
 796
 797 2019-09-20  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 800         std::string.
 801         (tui_disassemble): Add "pos" parameter.
 802         (tui_disasm_window::set_contents): Simplify.
 803
 804 2019-09-20  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-winsource.h (struct tui_source_window_base)
 807         <show_source_content>: Now private.
 808         * tui/tui-winsource.c
 809         (tui_source_window_base::show_source_content): Don't handle empty
 810         content case.
 811
 812 2019-09-20  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-layout.c (show_source_disasm_command)
 815         (show_source_or_disasm_and_command): Don't call
 816         show_source_content.
 817
 818 2019-09-20  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 821         Declare.
 822         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 823         from tui_make_status_line.
 824         (tui_locator_window::rerender): Update.
 825
 826 2019-09-20  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 829         (tui_locator_window::rerender): Update.
 830
 831 2019-09-20  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-winsource.h (struct tui_source_window_base)
 834         <~tui_source_window_base>: Don't declare.
 835         <fullname>: Remove.
 836         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 837         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 838         member.
 839         * tui/tui-source.c (tui_source_window::set_contents): Update.
 840         (tui_source_window::location_matches_p)
 841         (tui_source_window::maybe_update): Update.
 842
 843 2019-09-20  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-winsource.h (~tui_source_element): Remove.
 846         (tui_source_element): Update.
 847         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 848         * tui/tui-winsource.c (tui_show_source_line): Update.
 849         * tui/tui-source.c (tui_source_window::set_contents): Update.
 850         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 851
 852 2019-09-20  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 855         declare.
 856         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 857         tui_clear_source_windows_detail.
 858         * tui/tui-winsource.h (struct tui_source_window_base)
 859         <clear_detail>: Don't declare.
 860         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 861         Remove.
 862         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 863
 864 2019-09-20  Tom Tromey  <tromey@adacore.com>
 865
 866         PR ada/24919:
 867         * block.c (contained_in): Fix final return value.
 868
 869 2019-09-20  Alan Modra  <amodra@gmail.com>
 870
 871         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 872         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 873         (read_indirect_string_from_dwz): Use bfd accessor.
 874         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 875         * machoread.c (macho_symfile_read_all_oso): Likewise.
 876         * solib.c (solib_bfd_open): Likewise.
 877
 878 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 879
 880         * eval.c: Move declaration of overload_resolution to...
 881         * value.h: ...here.
 882
 883 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 884
 885         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 886         * arm-linux-tdep.c: Likewise.
 887         * arm-nbsd-nat.c: Likewise.
 888         * arm-tdep.h: Declare arm_apcs_32.
 889         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 890
 891 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 892
 893         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 894         * dwarf2read.h: Declare dwarf_always_disassemble.
 895
 896 2019-09-19  Tom de Vries  <tdevries@suse.de>
 897
 898         PR gdb/25009
 899         * source-cache.c (source_cache::ensure): Catch exception thrown during
 900         construction of the highlighter.
 901
 902 2019-09-18  Alan Modra  <amodra@gmail.com>
 903
 904         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 905         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 906         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 907         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 908         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 909         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 910         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 911         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 912         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 913         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 914         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 915         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 916         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 917         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 918         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 919         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 920         * mi/mi-interp.c: Update throughout for bfd section macro and
 921         function changes.
 922         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 923         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 924
 925 2019-09-18  Tom Tromey  <tom@tromey.com>
 926
 927         * NEWS: Add entry.
 928         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 929         call rl_initialize.
 930         (tui_enable): Do not call rl_initialize.
 931
 932 2019-09-18  Christian Groessler  <chris@groessler.org>
 933
 934         * alpha-linux-nat.c: Include gdbarch.h.
 935
 936 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 937
 938         * ui-file.c: Include cli/cli-style.h.
 939         (term_cli_styling): Remove cli_styling declaration.
 940
 941 2019-09-18  Alan Modra  <amodra@gmail.com>
 942
 943         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 944         to bfd_asymbol_section.
 945
 946 2019-09-18  Alan Modra  <amodra@gmail.com>
 947
 948         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 949         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 950         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 951
 952 2019-09-18  Alan Modra  <amodra@gmail.com>
 953
 954         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 955         * spu-linux-nat.c (spu_bfd_open): Likewise.
 956
 957 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 958
 959         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 960         to bool to match definition in dwarf2read.c.
 961
 962 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 963
 964         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 965         (print_signatures): Likewise.
 966         (trust_pad_over_xvs): Likewise.
 967         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 968         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 969         * arm-linux-nat.c (arm_apcs_32): Likewise.
 970         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 971         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 972         * arm-tdep.c (arm_debug): Likewise.
 973         (arm_apcs_32): Likewise.
 974         * auto-load.c (debug_auto_load): Likewise.
 975         (auto_load_gdb_scripts): Likewise.
 976         (global_auto_load): Likewise.
 977         (auto_load_local_gdbinit): Likewise.
 978         (auto_load_local_gdbinit_loaded): Likewise.
 979         * auto-load.h (global_auto_load): Likewise.
 980         (auto_load_local_gdbinit): Likewise.
 981         (auto_load_local_gdbinit_loaded): Likewise.
 982         * breakpoint.c (disconnected_dprintf): Likewise.
 983         (breakpoint_proceeded): Likewise.
 984         (automatic_hardware_breakpoints): Likewise.
 985         (always_inserted_mode): Likewise.
 986         (target_exact_watchpoints): Likewise.
 987         (_initialize_breakpoint): Update.
 988         * breakpoint.h (target_exact_watchpoints): Change to bool.
 989         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 990         * cli/cli-cmds.c (trace_commands): Likewise.
 991         * cli/cli-cmds.h (trace_commands): Likewise.
 992         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 993         to bool*.
 994         * cli/cli-logging.c (logging_overwrite): Change to bool.
 995         (logging_redirect): Likewise.
 996         (debug_redirect): Likewise.
 997         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 998         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 999         to bool.
1000         <boolean_option_def>: Update.
1001         (struct flag_option_def): Change default type of Context to bool
1002         from int.
1003         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1004         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1005         (get_setshow_command_value_string): Likewise.
1006         * cli/cli-style.c (cli_styling): Change to bool.
1007         (source_styling): Likewise.
1008         * cli/cli-style.h (source_styling): Likewise.
1009         (cli_styling): Likewise.
1010         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1011         to bool.
1012         * command.h (var_types): Update comment.
1013         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1014         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1015         bool.
1016         (debug_compile_cplus_scopes): Likewise.
1017         * compile/compile-internal.h (compile_debug): Likewise.
1018         * compile/compile.c (compile_debug): Likewise.
1019         (struct compile_options) <raw>: Likewise.
1020         * cp-support.c (catch_demangler_crashes): Likewise.
1021         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1022         (usr_cmd_cris_dwarf2_cfi): Likewise.
1023         * csky-tdep.c (csky_debug): Likewise.
1024         * darwin-nat.c (enable_mach_exceptions): Likewise.
1025         * dcache.c (dcache_enabled_p): Likewise.
1026         * defs.h (info_verbose): Likewise.
1027         * demangle.c (demangle): Likewise.
1028         (asm_demangle): Likewise.
1029         * dwarf-index-cache.c (debug_index_cache): Likewise.
1030         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1031         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1032         * dwarf2read.c (check_physname): Likewise.
1033         (use_deprecated_index_sections): Likewise.
1034         (dwarf_always_disassemble): Likewise.
1035         * eval.c (overload_resolution): Likewise.
1036         * event-top.c (set_editing_cmd_var): Likewise.
1037         (exec_done_display_p): Likewise.
1038         * event-top.h (set_editing_cmd_var): Likewise.
1039         (exec_done_display_p): Likewise.
1040         * exec.c (write_files): Likewise.
1041         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1042         (debug_fbsd_nat): Likewise.
1043         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1044         Likewise.
1045         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1046         <backtrace_past_entry> Likewise.
1047         * gdb-demangle.h (demangle): Likewise.
1048         (asm_demangle): Likewise.
1049         * gdb_bfd.c (bfd_sharing): Likewise.
1050         * gdbcore.h (write_files): Likewise.
1051         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1052         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1053         * gdbthread.h (print_thread_events): Likewise.
1054         * gdbtypes.c (opaque_type_resolution): Likewise.
1055         (strict_type_checking): Likewise.
1056         * gnu-nat.c (gnu_debug_flag): Likewise.
1057         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1058         * guile/scm-param.c (pascm_variable): Add boolval.
1059         (add_setshow_generic): Update.
1060         (pascm_param_value): Update.
1061         (pascm_set_param_value_x): Update.
1062         * hppa-tdep.c (hppa_debug): Change to bool..
1063         * infcall.c (may_call_functions_p): Likewise.
1064         (coerce_float_to_double_p): Likewise.
1065         (unwind_on_signal_p): Likewise.
1066         (unwind_on_terminating_exception_p): Likewise.
1067         * infcmd.c (startup_with_shell): Likewise.
1068         * inferior.c (print_inferior_events): Likewise.
1069         * inferior.h (startup_with_shell): Likewise.
1070         (print_inferior_events): Likewise.
1071         * infrun.c (step_stop_if_no_debug): Likewise.
1072         (detach_fork): Likewise.
1073         (debug_displaced): Likewise.
1074         (disable_randomization): Likewise.
1075         (non_stop): Likewise.
1076         (non_stop_1): Likewise.
1077         (observer_mode): Likewise.
1078         (observer_mode_1): Likewise.
1079         (set_observer_mode): Update.
1080         (sched_multi): Change to bool.
1081         * infrun.h (debug_displaced): Likewise.
1082         (sched_multi): Likewise.
1083         (step_stop_if_no_debug): Likewise.
1084         (non_stop): Likewise.
1085         (disable_randomization): Likewise.
1086         * linux-tdep.c (use_coredump_filter): Likewise.
1087         (dump_excluded_mappings): Likewise.
1088         * linux-thread-db.c (auto_load_thread_db): Likewise.
1089         (check_thread_db_on_load): Likewise.
1090         * main.c (captured_main_1): Update.
1091         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1092         xx2_opt, boolean_opt>: Change to bool.
1093         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1094         * maint.c (maintenance_profile_p): Likewise.
1095         (per_command_time): Likewise.
1096         (per_command_space): Likewise.
1097         (per_command_symtab): Likewise.
1098         * memattr.c (inaccessible_by_default): Likewise.
1099         * mi/mi-main.c (mi_async): Likewise.
1100         (mi_async_1): Likewise.
1101         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1102         * nat/fork-inferior.h (startup_with_shell): Likewise.
1103         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1104         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1105         * nios2-tdep.c (nios2_debug): Likewise.
1106         * or1k-tdep.c (or1k_debug): Likewise.
1107         * parse.c (parser_debug): Likewise.
1108         * parser-defs.h (parser_debug): Likewise.
1109         * printcmd.c (print_symbol_filename): Likewise.
1110         * proc-api.c (procfs_trace): Likewise.
1111         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1112         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1113         (set_parameter_value): Update.
1114         (add_setshow_generic): Update.
1115         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1116         to bool*.
1117         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1118         int*.
1119         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1120         * record-btrace.c (record_btrace_target::store_registers): Update.
1121         * record-full.c (record_full_memory_query): Change to bool.
1122         (record_full_stop_at_limit): Likewise.
1123         * record-full.h (record_full_memory_query): Likewise.
1124         * remote-notif.c (notif_debug): Likewise.
1125         * remote-notif.h (notif_debug): Likewise.
1126         * remote.c (use_range_stepping): Likewise.
1127         (interrupt_on_connect): Likewise.
1128         (remote_break): Likewise.
1129         * ser-tcp.c (tcp_auto_retry): Likewise.
1130         * ser-unix.c (serial_hwflow): Likewise.
1131         * skip.c (debug_skip): Likewise.
1132         * solib-aix.c (solib_aix_debug): Likewise.
1133         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1134         (spu_auto_flush_cache_p): Likewise.
1135         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1136         Likewise.
1137         (struct info_print_options) <quiet>: Likewise.
1138         * symfile-debug.c (debug_symfile): Likewise.
1139         * symfile.c (auto_solib_add): Likewise.
1140         (separate_debug_file_debug): Likewise.
1141         * symfile.h (auto_solib_add): Likewise.
1142         (separate_debug_file_debug): Likewise.
1143         * symtab.c (basenames_may_differ): Likewise.
1144         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1145         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1146         (struct info_types_options) <quiet>: Likewise.
1147         * symtab.h (demangle): Likewise.
1148         (basenames_may_differ): Likewise.
1149         * target-dcache.c (stack_cache_enabled_1): Likewise.
1150         (code_cache_enabled_1): Likewise.
1151         * target.c (trust_readonly): Likewise.
1152         (may_write_registers): Likewise.
1153         (may_write_memory): Likewise.
1154         (may_insert_breakpoints): Likewise.
1155         (may_insert_tracepoints): Likewise.
1156         (may_insert_fast_tracepoints): Likewise.
1157         (may_stop): Likewise.
1158         (auto_connect_native_target): Likewise.
1159         (target_stop_and_wait): Update.
1160         (target_async_permitted): Change to bool.
1161         (target_async_permitted_1): Likewise.
1162         (may_write_registers_1): Likewise.
1163         (may_write_memory_1): Likewise.
1164         (may_insert_breakpoints_1): Likewise.
1165         (may_insert_tracepoints_1): Likewise.
1166         (may_insert_fast_tracepoints_1): Likewise.
1167         (may_stop_1): Likewise.
1168         * target.h (target_async_permitted): Likewise.
1169         (may_write_registers): Likewise.
1170         (may_write_memory): Likewise.
1171         (may_insert_breakpoints): Likewise.
1172         (may_insert_tracepoints): Likewise.
1173         (may_insert_fast_tracepoints): Likewise.
1174         (may_stop): Likewise.
1175         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1176         (make_thread_apply_all_options_def_group): Change argument from int*
1177         to bool*.
1178         (thread_apply_all_command): Update.
1179         (print_thread_events): Change to bool.
1180         * top.c (confirm): Likewise.
1181         (command_editing_p): Likewise.
1182         (history_expansion_p): Likewise.
1183         (write_history_p): Likewise.
1184         (info_verbose): Likewise.
1185         * top.h (confirm): Likewise.
1186         (history_expansion_p): Likewise.
1187         * tracepoint.c (disconnected_tracing): Likewise.
1188         (circular_trace_buffer): Likewise.
1189         * typeprint.c (print_methods): Likewise.
1190         (print_typedefs): Likewise.
1191         * utils.c (debug_timestamp): Likewise.
1192         (sevenbit_strings): Likewise.
1193         (pagination_enabled): Likewise.
1194         * utils.h (sevenbit_strings): Likewise.
1195         (pagination_enabled): Likewise.
1196         * valops.c (overload_resolution): Likewise.
1197         * valprint.h (struct value_print_options) <prettyformat_arrays,
1198         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1199         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1200         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1201         Likewise.
1202         * windows-nat.c (new_console): Likewise.
1203         (cygwin_exceptions): Likewise.
1204         (new_group): Likewise.
1205         (debug_exec): Likewise.
1206         (debug_events): Likewise.
1207         (debug_memory): Likewise.
1208         (debug_exceptions): Likewise.
1209         (useshell): Likewise.
1210         * windows-tdep.c (maint_display_all_tib): Likewise.
1211         * xml-support.c (debug_xml): Likewise.
1212
1213 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1214
1215         * source.c (prepare_path_for_appending): New function.
1216         (openp): Make use of new function.
1217         (find_and_open_source): Search for the compilation directory and
1218         source file as a relative path beneath the directory search path.
1219
1220 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * source-cache.c (source_cache::get_line_charpos): Catch
1223         exceptions and return false, this matches the behaviour documented
1224         in the header file.
1225
1226 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1227
1228         * ada-tasks.c (info_task): Remove quoting of the task's name.
1229
1230 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1231
1232         * symfile.c (auto_solib_add): Replace comment with a reference
1233         to the header file.
1234
1235 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1236
1237         * NEWS: Mention that gdb can now be compiled with Python 3
1238         on Windows.
1239
1240 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * maint.c (maint_print_section_data::maint_print_section_data):
1243         Force use of 'float log10 (float)' by casting the argument to
1244         float.
1245
1246 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * maint.c: Add 'cmath' include.
1249         (struct maint_print_section_data): New structure.
1250         (print_section_index): New function.
1251         (print_bfd_section_info): Add header comment, small whitespace
1252         cleanup, and update to call new print_section_index function.
1253         (print_objfile_section_info): Likewise.
1254         (maint_obj_section_from_bfd_section): New function.
1255         (print_bfd_section_info_maybe_relocated): New function.
1256         (maintenance_info_sections): Add header comment, always use
1257         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1258
1259 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1260
1261         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1262         inner scope, add check that the objfile has psymtabs before
1263         checking psymtabs_addrmap.
1264         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1265
1266 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1267
1268         * NEWS: Announce that Ada task names are now shown at more places,
1269         and between quotes (except in info task output).
1270         * gdb/ada-tasks.c (task_to_str): New function.
1271         (display_current_task_id): Call task_to_str.
1272         (task_command_1): Likewise.
1273         (print_ada_task_info): In non-mi mode, Properly align headers and data
1274         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1275
1276 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1277
1278         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1279         prstatus.pr_lwp.pr_info instead of making it up.
1280
1281 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1282
1283         * auto-load.c (auto_load_expand_dir_vars): Update.
1284         * defs.h (gdb_datadir): Change to std::string.
1285         (python_libdir): Likewise.
1286         (relocate_gdb_directory): Change return type to std::string.
1287         * guile/guile.c (gdbscm_data_directory): Update.
1288         (initialize_scheme_side): Update.
1289         * jit.c (jit_reader_dir): Change to std::string.
1290         (jit_reader_load_command): Update.
1291         * main.c (gdb_datadir): Change to std::string.
1292         (python_libdir): Likewise.
1293         (set_gdb_data_directory): Update.
1294         (relocate_path): Change to return std::string.
1295         (relocate_gdb_directory): Change to return std::string.
1296         (relocate_gdbinit_path_maybe_in_datadir): Update.
1297         (captured_main_1): Update.
1298         * python/python.c (do_start_initialization): Update.
1299         * top.c (show_gdb_datadir): Update.
1300         * xml-syscall.c (xml_init_syscalls_info): Update.
1301         (init_syscalls_info): Update.
1302
1303 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1304
1305         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1306         out of get_init_files.
1307         (get_init_files): Update.
1308
1309 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1310
1311         * main.c (get_init_files): Change to use std::string.
1312         (captured_main_1): Update.
1313         (print_gdb_help): Update.
1314
1315 2019-09-11  Ali Tamur  <tamur@google.com>
1316
1317         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1318         implementation.
1319
1320 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1321
1322         * dbxread.c (read_dbx_symtab): Update.
1323         * dwarf2read.c (load_partial_dies): Update.
1324         * mdebugread.c (parse_partial_symbols): Update.
1325         (handle_psymbol_enumerators): Update.
1326         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1327         * psymtab.c (add_psymbol_to_bcache): Likewise.
1328         (add_psymbol_to_list): Likewise.
1329         * symtab.c (symbol_set_names): Likewise.
1330         * symtab.h (symbol_set_names): Likewise.
1331         * xcoffread.c (scan_xcoff_symtab): Update.
1332
1333 2019-09-11  Tom Tromey  <tom@tromey.com>
1334
1335         * symfile-mem.c (symbol_file_add_from_memory): Use
1336         bfd_set_filename.
1337         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1338         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1339
1340 2019-09-10  Tom Tromey  <tromey@adacore.com>
1341
1342         * dwarf-index-write.c (write_psymbols): Extend error message.
1343         (debug_names::insert): Add Ada code.
1344         (debug_names::write_psymbols): Remove Ada check.
1345         (debug_names) <m_string_obstack>: New member.
1346         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1347         (gdb_index_symbol_name_matcher::matches): Remove.
1348         (mapped_index_base::find_name_components_bounds): Add "lang"
1349         parameter.
1350         (mapped_index_base::build_name_components): Also split names
1351         according to Ada syntax.
1352         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1353         type of "match_callback".
1354         (check_match, check_find_bounds_finds)
1355         (dw2_expand_symtabs_matching): Update.
1356         (dw2_debug_names_iterator): Add new constructor.
1357         (dw2_debug_names_map_matching_symbols): New function.
1358         (dw2_debug_names_expand_symtabs_matching): Update.
1359         (dwarf2_debug_names_functions): Use
1360         dw2_debug_names_map_matching_symbols.
1361
1362 2019-09-10  Tom Tromey  <tromey@adacore.com>
1363
1364         * dwarf2read.c (dw2_get_file_names_reader): Add the
1365         CU's file name to the results.
1366
1367 2019-09-10  Tom Tromey  <tromey@adacore.com>
1368
1369         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1370         map_matching_symbols.  Update.
1371         * dwarf2read.c (dw2_map_matching_symbols): Update.
1372         * psymtab.c (match_partial_symbol): Change type; update.
1373         (psym_map_matching_symbols): Likewise.
1374         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1375         type; update.
1376         * symfile.h (struct quick_symbol_functions)
1377         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1378         Remove "match".
1379
1380 2019-09-10  Tom Tromey  <tromey@adacore.com>
1381
1382         * psymtab.c (map_block): Remove.
1383         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1384         * symtab.c (iterate_over_symbols_terminated): New function.
1385         * symtab.c (iterate_over_symbols_terminated): Declare.
1386
1387 2019-09-10  Tom Tromey  <tromey@adacore.com>
1388
1389         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1390         * language.h (struct language_defn) <la_iterate_over_symbols>:
1391         Return bool.
1392         * symtab.c (iterate_over_symbols): Return bool.
1393         * symtab.h (iterate_over_symbols): Return bool.
1394
1395 2019-09-10  Tom Tromey  <tromey@adacore.com>
1396
1397         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1398         (add_nonlocal_symbols): Update.
1399         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1400         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1401         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1402         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1403         Change type of "callback".  Remove "data".
1404
1405
1406 2019-09-09  Ali Tamur  <tamur@google.com>
1407
1408         * dwarf2read.c (comp_unit_head): Update comment.
1409         (dwarf2_dwo_name): New function declaration.
1410         (dwarf_unit_type_name): New function declaration.
1411         (read_comp_unit_head): Add support for new compilation units,
1412         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1413         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1414         (currently named as "signature") in their header. Also clarify error
1415         messages.
1416         (lookup_dwo_id): New function. Returns the dwo id of the given
1417         compile unit.
1418         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1419         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1420         functions.
1421         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1422         (dwarf2_dwo_name): Get the dwo name if present.
1423         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1424         purposes.
1425
1426 2019-09-09  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1429
1430 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1431
1432         * python/python.c (do_start_initialization): Make progname_copy static,
1433         to avoid a leak report.
1434
1435 2019-09-08  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1438
1439 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1440
1441         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1442         Change type to gdb::optional<block_enum>.
1443         (dw2_symtab_iter_init): Change block_index parameter type
1444         to gdb::optional<block_enum>.
1445         (dw2_lookup_symbol): Change block_index parameter
1446         type to block_enum.c
1447         (dw2_debug_names_lookup_symbol): Likewise.
1448         * psymtab.c (psym_lookup_symbol): Likewise.
1449         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1450         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1451         Likewise.
1452
1453 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1454
1455         * defs.h (relocate_gdb_directory): Change int to bool in
1456         signature and rename flag to relocatable.
1457         * main.c (relocate_path): Likewise.
1458         (relocate_gdb_directory): Likewise.
1459
1460 2019-09-06  Alan Modra  <amodra@gmail.com>
1461
1462         * coffread.c (coff_symfile_read): Constify filename variable.
1463         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1464         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1465         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1466         * solib.c (reload_shared_libraries_1): Likewise.
1467         * symfile.c (reread_symbols): Likewise.
1468         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1469         * solib-darwin.c (darwin_bfd_open): Likewise.
1470         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1471
1472 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1475         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1476
1477 2019-09-03  Tom Tromey  <tromey@adacore.com>
1478
1479         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1480         types.
1481         (has_negatives): Unbias a range type bound.
1482         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1483         * gdbtypes.c (operator==): Handle new field.
1484         (create_range_type): Add "bias" parameter.
1485         (create_static_range_type, resolve_dynamic_range): Update.
1486         * gdbtypes.h (struct range_bounds) <bias>: New member.
1487         (create_range_type): Add bias parameter.
1488         * printcmd.c (print_scalar_formatted): Unbias range types.
1489         * value.c (unpack_long): Unbias range types.
1490         (pack_long): Bias range types.
1491
1492 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1493
1494         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1495         probe arguments.
1496
1497 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1498
1499         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1500         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1501         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1502         (compile_probe_arg): Likewise.
1503         * probe.h (get_argument_count): Likewise.
1504         * solib-svr4.c (solib_event_probe_action): Likewise.
1505         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1506
1507 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1508
1509         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1510         code to here...
1511         (svr4_create_solib_event_breakpoints): ...from here.
1512
1513 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1514
1515         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1516         suffix from warning message.
1517
1518 2019-08-30  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-winsource.h (struct tui_source_window_base)
1521         <refresh_all>: Don't declare.
1522         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1523         Remove.
1524         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1525         tui_show_locator_content.
1526         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1527         declare.
1528         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1529         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1530         declare.
1531
1532 2019-08-30  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1535
1536 2019-08-30  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1539         Remove unnecessary forward declarations.
1540
1541 2019-08-30  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1544         rerender.
1545         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1546         tui_show_locator_content.
1547
1548 2019-08-30  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1551         (tui_locator_window::rerender): Rewrite using body of previous
1552         tui_show_locator_content.
1553
1554 2019-08-30  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1557         set_locator_fullname>: New methods.
1558         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1559         Rename from tui_set_locator_fullname.
1560         (tui_locator_window::set_locator_info): Rename from
1561         tui_set_locator_info.  Return bool.
1562         (tui_update_locator_fullname, tui_show_frame_info): Update.
1563
1564 2019-08-30  Tom Tromey  <tom@tromey.com>
1565
1566         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1567
1568 2019-08-30  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1571         call touchwin.
1572
1573 2019-08-30  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-wingeneral.c (box_win): Assume win_info and
1576         win_info->handle cannot be NULL.
1577
1578 2019-08-30  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1581         refresh_window>: Declare.
1582         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1583         resize.
1584         (tui_data_item_window::rerender): Rename from
1585         tui_display_register.
1586         (tui_data_item_window::refresh_window): New method.
1587         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1588         no-op.
1589
1590 2019-08-30  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1593         regs_column_count, current_group>: Move later.  Now private.
1594         <get_current_group>: New method.
1595         * tui/tui-regs.c (tui_reg_command): Update.
1596         * tui/tui-layout.c (tui_set_layout): Update.
1597
1598 2019-08-30  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1601         (tui_data_window::rerender): Don't call
1602         check_and_display_highlight_if_needed.
1603         (tui_data_window::refresh_all): Remove call to
1604         erase_data_content.
1605
1606 2019-08-30  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1609         (tui_data_window::display_registers_from)
1610         (tui_data_window::display_reg_element_at_line)
1611         (tui_data_window::display_registers_from_line): Remove checks of
1612         "empty".
1613
1614 2019-08-30  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1617         Don't declare.
1618         * tui/tui-regs.c (tui_data_window::show_registers): Call
1619         rerender.
1620         (tui_data_window::rerender): Rename from display_all_data.
1621         (tui_data_window::rerender): Remove old implementation.
1622
1623 2019-08-30  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1626         text.
1627         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1628
1629 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1630             Sergio Durigan Junior  <sergiodj@redhat.com>
1631
1632         PR win32/24284
1633         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1634
1635 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1638         when searching for types.
1639
1640 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1641
1642         * f-lang.c (f_language_defn): Use f_print_typedef.
1643         * f-lang.h (f_print_typedef): Declare.
1644         * f-typeprint.c (f_print_typedef): Define.
1645
1646 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1647
1648         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1649
1650 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1651
1652         * cli/cli-utils.c (info_print_options_defs): Delete.
1653         (make_info_print_options_def_group): Delete.
1654         (extract_info_print_options): Delete.
1655         (info_print_command_completer): Delete.
1656         (info_print_args_help): Add extra parameter, and optionally
1657         include text about -n flag.
1658         * cli/cli-utils.h (struct info_print_options): Delete.
1659         (extract_info_print_options): Delete declaration.
1660         (info_print_command_completer): Delete declaration.
1661         (info_print_args_help): Add extra parameter, extend header
1662         comment.
1663         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1664         search_symbols.
1665         * stack.c (struct info_print_options): New type.
1666         (info_print_options_defs): New file scoped variable.
1667         (make_info_print_options_def_group): New static function.
1668         (info_print_command_completer): New static function.
1669         (info_locals_command): Update to use new local functions.
1670         (info_args_command): Likewise.
1671         (_initialize_stack): Add extra parameter to calls to
1672         info_print_args_help.
1673         * symtab.c (search_symbols): Add extra parameter, use this to
1674         possibly excluse non-debug symbols.
1675         (symtab_symbol_info): Add extra parameter, which is passed on to
1676         search_symbols.
1677         (struct info_print_options): New type.
1678         (info_print_options_defs): New file scoped variable.
1679         (make_info_print_options_def_group): New static function.
1680         (info_print_command_completer): New static function.
1681         (info_variables_command): Update to use local functions, and pass
1682         extra parameter through to symtab_symbol_info.
1683         (info_functions_command): Likewise.
1684         (info_types_command): Pass additional argument through to
1685         symtab_symbol_info.
1686         (rbreak_command): Pass extra argument to search_symbols.
1687         (_initialize_symtab): Add extra arguments for calls to
1688         info_print_args_help, and update help text for 'info variables',
1689         'whereis', and 'info functions' commands.
1690         * symtab.h (search_symbols): Add extra argument to declaration.
1691         * NEWS: Mention new flags.
1692
1693 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1694
1695         * symtab.c (lookup_static_symbol): Call the new function (and move
1696         it down to be next to lookup_global_symbol).
1697         (struct global_sym_lookup_data): Add block_enum member and rename to...
1698         (struct global_or_static_sym_lookup_data): ...this.
1699         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1700         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1701         (lookup_symbol_global_or_static_iterator_cb): ...this.
1702         (lookup_global_or_static_symbol): New function.
1703         (lookup_global_symbol): Call new function.
1704
1705 2019-08-26  Tom de Vries  <tdevries@suse.de>
1706
1707         PR c++/24852
1708         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1709         when pc_probe.prob == NULL.
1710
1711 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1712
1713         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1714         variable symbol_linkage to symbol_linkage_.
1715
1716 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1717
1718         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1719         represent whether the symbol is static, dynamic, or we don't
1720         know.
1721
1722 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1723
1724         * gdb/rx-tdep.c (rx_register_names): New.
1725         (rx_register_name): Delete.
1726         (rx_psw_type): Delete.
1727         (rx_fpsw_type): Delete.
1728         (rx_register_type): Delete.
1729         (rx_gdbarch_init): Convert target-descriptions.
1730         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1731         * gdb/features/Makefile: Add rx.xml.
1732         * gdb/features/rx.xml: New.
1733         * gdb/features/rx.c: Generated.
1734         * gdb/NEWS: Mention target description support.
1735
1736 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1737
1738         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1739         *slot_ptr.
1740
1741 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1742
1743         * configure.ac: Don't check for 'dlfcn.h' (moved to
1744         gdbsupport/common.m4).
1745         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1746         'gdbsupport/'.
1747         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1748         * compile/compile-c-support.c: Include
1749         'gdbsupport/gdb-dlfcn.h'.
1750         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1751         * gdb-dlfcn.c: Move to...
1752         * gdbsupport/gdb-dlfcn.c: ... here.
1753         * gdb-dlfcn.h: Move to...
1754         * gdbsupport/gdb-dlfcn.h: ... here.
1755
1756 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1757
1758         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1759         the offset field signed.
1760
1761 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1762
1763         * python/lib/gdb/__init__.py (_execute_file): New function.
1764         * python/python.c (python_run_simple_file): Call gdb._execute_file
1765         on Windows.
1766
1767 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1768
1769         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1770         all uses as this was never set to anything but a zero value.
1771
1772 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1773
1774         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1775
1776 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1777
1778         * tui/tui-data.h (tui_gen_win_info): Add an =default
1779         move constructor, required by some GCC versions.
1780
1781 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1782
1783         * go32-nat.c (go32_sysinfo): Add hygon_p.
1784
1785 2019-08-20  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1788         line_from_reg_element_no, first_reg_element_no_inline,
1789         display_all_data, delete_data_content_windows,
1790         erase_data_content>: Now private.
1791
1792 2019-08-20  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1795         (tui_unhighlight_win, tui_highlight_win)
1796         (tui_win_info::make_window): Update.
1797         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1798
1799 2019-08-20  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1802         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1803         (MAX_PID_WIDTH): Move to tui-stack.c.
1804         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1805         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1806         (MAX_PID_WIDTH): Move from tui-data.h.
1807
1808 2019-08-20  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1811         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1812         (box_win): Update.
1813         (tui_gen_win_info::make_window): Rename from tui_make_window.
1814         (tui_win_info::make_window): New method.
1815         (tui_gen_win_info::make_visible): Update.
1816         * tui/tui-source.c (tui_source_window::set_contents): Update.
1817         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1818         (tui_data_window::display_registers_from): Update.
1819         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1820         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1821         Declare.
1822         <can_box>: Remove.
1823         <title>: Remove.
1824         (struct tui_win_info) <make_window>: Declare.
1825         <can_box>: Now virtual.
1826         <title>: New member.
1827         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1828         * tui/tui-command.c (tui_cmd_window::resize): Update.
1829
1830 2019-08-20  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1833         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1834         (tui_data_window::check_register_values): Update.
1835
1836 2019-08-20  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-regs.h (struct tui_data_window): Use
1839         DISABLE_COPY_AND_ASSIGN.
1840         <regs_content>: Change type, removing unique_ptr.
1841         <tui_data_window>: Add move constructor.
1842         * tui/tui-regs.c (tui_data_window::show_registers)
1843         (tui_data_window::show_register_group)
1844         (tui_data_window::display_registers_from)
1845         (tui_data_window::display_registers_from)
1846         (tui_data_window::first_data_item_displayed)
1847         (tui_data_window::delete_data_content_windows)
1848         (tui_data_window::rerender, tui_data_window::refresh_window)
1849         (tui_data_window::check_register_values): Update.
1850
1851 2019-08-20  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1854         show_register_group>: Declare.
1855         (tui_show_register_group): Don't declare.
1856         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1857         tui_show_registers.
1858         (tui_data_window::show_register_group): Rename from
1859         tui_show_register_group.
1860         (tui_data_window::check_register_values, tui_reg_command):
1861         Update.
1862         * tui/tui-layout.c (tui_set_layout): Update.
1863
1864 2019-08-20  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1867         Declare.
1868         (tui_check_register_values): Don't declare.
1869         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1870         from tui_check_register_values.
1871         * tui/tui-hooks.c (tui_register_changed): Update.
1872
1873 2019-08-20  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-regs.c (tui_reg_layout): Move later.
1876         (tui_show_registers): Don't enable TUI mode or change layout.
1877
1878 2019-08-20  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-regs.h (struct tui_data_item_window)
1881         <~tui_data_item_window>: Remove.
1882         <content>: Now a unique_xmalloc_ptr.
1883         * tui/tui-regs.c (tui_register_format): Return a
1884         unique_xmalloc_ptr.
1885         (tui_get_register): Update.
1886         (~tui_data_item_window): Remove.
1887         (tui_data_window::display_registers_from, tui_display_register):
1888         Update.
1889         * tui/tui-io.h (tui_expand_tabs): Update.
1890         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1891         Remove "col" parameter.
1892
1893 2019-08-20  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1896         field.
1897         * tui/tui-regs.c (~tui_data_item_window): Update.
1898
1899 2019-08-20  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1902         earlier.
1903
1904 2019-08-20  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1907
1908 2019-08-20  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-source.h (struct tui_source_window): Update.
1911         * tui/tui-regs.c (tui_show_registers): Update.
1912         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1913         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1914         (NO_REGS_STRING): Remove defines.
1915
1916 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1917
1918         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1919         unnecessary thread walk if remote doesn't support the packet.
1920
1921 2019-08-19  Tom Tromey  <tromey@adacore.com>
1922
1923         * python/py-value.c (value_has_field): Fix indentation.
1924
1925 2019-08-19  Tom Tromey  <tromey@adacore.com>
1926
1927         * printcmd.c (do_one_display, info_display_command): Update.
1928         * block.h (contained_in): Return bool.  Add allow_nested
1929         parameter.
1930         * block.c (contained_in): Return bool.  Add allow_nested
1931         parameter.
1932
1933 2019-08-19  Tom Tromey  <tom@tromey.com>
1934
1935         * configure: Rebuild.
1936         * configure.ac: Disallow the combination of -static-libstdc++ and
1937         source highlight.
1938         * source-cache.c (get_language_name): Handle rust.
1939         (source_cache::get_source_lines): Ignore highlighting exceptions.
1940
1941 2019-08-16  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1944         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1945         (struct tui_source_window_base) <make_visible, refresh_window,
1946         resize>: Remove methods.
1947         <execution_info>: Remove field.
1948         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1949         (tui_show_source_line, tui_source_window_base)
1950         (~tui_source_window_base): Update.
1951         (tui_source_window_base::resize)
1952         (tui_source_window_base::make_visible)
1953         (tui_source_window_base::refresh_window): Remove.
1954         (tui_source_window_base::update_exec_info): Update.
1955         * tui/tui-source.c (tui_source_window::set_contents): Update.
1956         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1957
1958 2019-08-16  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1961         deprecated_query_hook.
1962
1963 2019-08-16  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1966         (tui_update_source_windows_with_line): Update.
1967         * tui/tui-source.h (struct tui_source_window)
1968         <show_symtab_source>: Declare.
1969         (tui_show_symtab_source): Don't declare.
1970         * tui/tui-source.c (tui_show_symtab_source): Rename from
1971         tui_show_symtab_source.
1972
1973 2019-08-16  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-winsource.h (struct tui_source_window_base)
1976         <set_contents>: Declare.
1977         * tui/tui-winsource.c
1978         (tui_source_window_base::update_source_window_as_is): Update.
1979         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1980         Declare.
1981         (tui_set_source_content): Don't declare.
1982         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1983         tui_set_source_content.
1984         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1985         Declare.
1986         (tui_set_disassem_content): Don't declare.
1987         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1988         tui_set_disassem_content.
1989
1990 2019-08-16  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-winsource.h (struct tui_source_window_base)
1993         <update_breakpoint_info>: Declare.
1994         (tui_update_breakpoint_info): Don't declare.
1995         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1996         (tui_update_all_breakpoint_info): Update.
1997         (tui_source_window_base::update_breakpoint_info): Rename from
1998         tui_update_breakpoint_info.
1999         (tui_source_window_base::update_exec_info): Update.
2000
2001 2019-08-16  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-winsource.h (struct tui_source_window_base)
2004         <update_source_window>: Declare.
2005         (tui_update_source_window): Don't declare.
2006         * tui/tui-winsource.c
2007         (tui_source_window_base::update_source_window): Rename from
2008         tui_update_source_window.
2009         (tui_source_window_base::rerender): Update.
2010         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2011         * tui/tui-disasm.c (tui_show_disassem)
2012         (tui_show_disassem_and_update_source)
2013         (tui_disasm_window::maybe_update): Update.
2014
2015 2019-08-16  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-winsource.h (struct tui_source_window_base)
2018         <update_source_window_as_is>: Declare.
2019         (tui_update_source_window_as_is): Don't declare.
2020         * tui/tui-winsource.c (tui_update_source_window): Update
2021         (tui_source_window_base::update_source_window_as_is): Rename from
2022         tui_update_source_window_as_is.
2023         (tui_source_window_base::refill): Update.
2024         * tui/tui-source.c (tui_show_symtab_source): Update.
2025         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2026         Update.
2027
2028 2019-08-16  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui-winsource.h (tui_update_source_window)
2031         (tui_update_source_window_as_is): Remove "noerror" parameter.
2032         * tui/tui-winsource.c (tui_update_source_window)
2033         (tui_update_source_window_as_is): Remove "noerror" parameter.
2034         (tui_update_source_windows_with_addr)
2035         (tui_update_source_windows_with_line)
2036         (tui_source_window_base::rerender)
2037         (tui_source_window_base::refill): Update.
2038         * tui/tui-source.h (tui_set_source_content)
2039         (tui_show_symtab_source): Remove "noerror" parameter.
2040         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2041         parameter.
2042         (tui_show_symtab_source): Likewise.
2043         (tui_source_window::maybe_update): Update.
2044         * tui/tui-disasm.c (tui_show_disassem)
2045         (tui_show_disassem_and_update_source)
2046         (tui_disasm_window::do_scroll_vertical)
2047         (tui_disasm_window::maybe_update): Update.
2048
2049 2019-08-16  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui.c (tui_is_window_visible): Update.
2052         * tui/tui-wingeneral.c (tui_make_window)
2053         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2054         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2055         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2056         (tui_set_win_height_command, parse_scrolling_args): Update.
2057         * tui/tui-source.c (tui_source_window::style_changed): Update.
2058         * tui/tui-regs.c (tui_show_registers)
2059         (tui_data_window::first_data_item_displayed)
2060         (tui_data_window::delete_data_content_windows)
2061         (tui_check_register_values, tui_reg_command): Update.
2062         * tui/tui-disasm.c (tui_show_disassem): Update.
2063         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2064         method.
2065         <is_visible>: Remove field.
2066         * tui/tui-data.c (tui_next_win, tui_prev_win)
2067         (tui_delete_invisible_windows): Update.
2068
2069 2019-08-16  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-winsource.h (struct tui_source_window_base)
2072         <m_has_locator>: Remove.
2073         * tui/tui-layout.c (show_source_disasm_command, show_data)
2074         (show_source_or_disasm_and_command): Update.
2075
2076 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2077
2078         * NEWS (Other MI changes): New subsection.
2079         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2080         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2081         * arch-utils.c (default_get_pc_address_flags): New function.
2082         * arch-utils.h (default_get_pc_address_flags): New declaration.
2083         * gdbarch.sh: Add get_pc_address_flags.
2084         * gdbarch.c: Regenerate.
2085         * gdbarch.h: Likewise.
2086         * stack.c (print_pc): New function.
2087         (print_frame_info) (print_frame): Call print_pc.
2088
2089 2019-08-16  Tom de Vries  <tdevries@suse.de>
2090
2091         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2092         print_objfile_section_info.
2093
2094 2019-08-15  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2097         calling update_cmdwin_start_line.
2098         * tui/tui-winsource.h (struct tui_source_window_base)
2099         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2100         <rerender>: Declare.
2101         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2102         Call rerender.
2103         (tui_source_window_base::set_new_height): Remove.
2104         (tui_source_window_base::rerender): Rename from
2105         do_make_visible_with_new_height.
2106         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2107         resize method.
2108         (tui_win_info::make_invisible_and_set_new_height)
2109         (tui_win_info::make_visible_with_new_height): Remove.
2110         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2111         Declare.
2112         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2113         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2114         do_make_visible_with_new_height>: Don't declare.
2115         <rerender>: Declare.
2116         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2117         set_new_height.
2118         (tui_data_window::do_make_visible_with_new_height): Remove.
2119         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2120         call tui_show_locator_content.
2121         (tui_gen_win_info::resize): Call rerender.
2122         (show_source_or_disasm_and_command): Don't call
2123         tui_show_locator_content.
2124         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2125         method.
2126         (struct tui_win_info) <rerender>: Declare.
2127         <set_new_height, make_invisible_and_set_new_height,
2128         make_visible_with_new_height>: Don't declare.
2129         * tui/tui-data.c (tui_win_list::rerender): New method.
2130         * tui/tui-command.h (struct tui_cmd_window)
2131         <do_make_visible_with_new_height>: Don't declare.
2132         * tui/tui-command.c
2133         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2134
2135 2019-08-15  Tom Tromey  <tromey@adacore.com>
2136
2137         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2138         * ada-lang.c (ada_enum_name): Likewise.
2139
2140 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2141
2142         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2143         leading underscore.
2144         (GdbOutputErrorFile): Likewise.
2145         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2146         accordingly.
2147         (execute_unwinders): Rename to have a leading underscore.
2148         (auto_load_packages): Likewise.
2149         (global scope): Adjust call to auto_load_packages accordingly.
2150         (GdbSetPythonDirectory): Likewise.
2151         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2152         instead of execute_unwinders.
2153
2154 2019-08-15  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2157         (show_data): Don't change window visibility.
2158         (tui_gen_win_info::resize): Remove special case for command
2159         window.  Use wresize, when available.
2160         (show_source_or_disasm_and_command): Don't change window
2161         visibility.
2162         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2163         <make_visible>: New method.
2164         * tui/tui-command.c (tui_cmd_window::resize): New method.
2165
2166 2019-08-15  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2169         (struct tui_source_windows): New.
2170         * tui/tui-winsource.c (tui_display_main): Update.
2171         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2172         (new_height_ok, parse_scrolling_args): Update.
2173         * tui/tui-layout.c (show_layout, show_data): Update.
2174         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2175         (tui_add_to_source_windows): Don't declare.
2176         * tui/tui-data.c (source_windows, tui_source_windows)
2177         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2178
2179 2019-08-15  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2182         Rename from reset.
2183         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2184         * tui/tui-layout.c (show_source_disasm_command, show_data):
2185         Update.
2186         (tui_gen_win_info::resize): Rename.
2187         (show_source_or_disasm_and_command): Update.
2188         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2189         reset.
2190
2191 2019-08-15  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2194         * tui/tui-interp.c (tui_interp::init): Don't call
2195         tui_initialize_static_data.
2196         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2197
2198 2019-08-15  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2201         examine tui_win_list.
2202
2203 2019-08-15  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2206         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2207         tui_clear_source_content.
2208         (tui_clear_source_content): Remove.
2209         (tui_source_window_base::do_erase_source_content): Hoist call to
2210         content.clear().
2211         * tui/tui-stack.c (tui_show_frame_info): Don't call
2212         tui_clear_source_content.
2213
2214 2019-08-15  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-winsource.h (struct tui_source_window_base)
2217         <do_erase_source_content>: New method.
2218         <erase_source_content>: New method.
2219         (tui_erase_source_content): Don't declare.
2220         * tui/tui-winsource.c (tui_clear_source_content): Update.
2221         (tui_source_window_base::do_erase_source_content): Rename from
2222         tui_erase_source_content.
2223         (tui_source_window_base::show_source_content): Update.
2224         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2225         * tui/tui-source.h (struct tui_source_window)
2226         <erase_source_content>: New method.
2227         * tui/tui-disasm.h (struct tui_disasm_window)
2228         <erase_source_content>: New method.
2229
2230 2019-08-15  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2233         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2234         constructor.
2235         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2236         * tui/tui-source.c (tui_set_source_content): Update.
2237         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2238
2239 2019-08-15  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2242         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2243         tui-source.c.
2244         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2245         Declare.
2246         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2247         method.
2248         (tui_source_window::maybe_update): Update.
2249
2250 2019-08-15  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2253         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2254         tui-disasm.c.
2255         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2256         Declare.
2257         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2258         method.
2259         (tui_disasm_window::maybe_update): Update.
2260
2261 2019-08-15  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-winsource.h (struct tui_source_window_base)
2264         <maybe_update>: Declare.
2265         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2266         method.
2267         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2268         Declare.
2269         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2270         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2271         Declare.
2272         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2273
2274 2019-08-15  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2277
2278 2019-08-15  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-wingeneral.c: Include tui-stack.h.
2281         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2282         (struct tui_locator_window): Move from tui-data.h.
2283         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2284         (tui_initialize_static_data): Move from tui-data.c.
2285         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2286         (struct tui_locator_window): Move to tui-stack.c.
2287         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2288         (tui_initialize_static_data): Move to tui-stack.c.
2289
2290 2019-08-15  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-layout.c (show_source_disasm_command)
2293         (show_source_or_disasm_and_command): Use make_visible method, not
2294         tui_make_window.
2295         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2296         Remove.
2297
2298 2019-08-15  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-wingeneral.h (tui_make_window): Update.
2301         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2302         parameter.
2303         (tui_gen_win_info::make_visible): Update.
2304         * tui/tui-regs.c (tui_data_window::display_registers_from):
2305         Update.
2306         * tui/tui-layout.c (show_source_disasm_command)
2307         (show_source_or_disasm_and_command): Update.
2308         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2309         (enum tui_box): Remove.
2310         (struct tui_win_info) <can_box>: New method.
2311         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2312         method.
2313
2314 2019-08-15  Tom de Vries  <tdevries@suse.de>
2315
2316         * linux-nat-trad.c: Include gdbarch.h.
2317
2318 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2319
2320         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2321         register sizes.
2322
2323 2019-08-14  Tom Tromey  <tromey@adacore.com>
2324
2325         * darwin-nat.c: Include gdbarch.h.
2326         * darwin-nat-info.c: Include gdbarch.h.
2327
2328 2019-08-13  Tom Tromey  <tom@tromey.com>
2329
2330         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2331         Remove.
2332         * tui/tui-data.c (tui_initialize_static_data): Update.
2333
2334 2019-08-13  Tom Tromey  <tom@tromey.com>
2335
2336         * tui/tui-winsource.h (struct tui_exec_info_window)
2337         <~tui_exec_info_window, maybe_allocate_content, get_content,
2338         m_content>: Remove.
2339         (struct tui_source_window_base) <set_exec_info_content,
2340         show_exec_info_content>: Don't declare.
2341         * tui/tui-winsource.c
2342         (tui_exec_info_window::maybe_allocate_content): Remove.
2343         (tui_source_window_base::update_exec_info): Rename from
2344         set_exec_info_content.
2345         (tui_source_window_base::show_exec_info_content)
2346         (tui_source_window_base::update_exec_info): Remove.
2347
2348 2019-08-13  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2351         declare.
2352         * tui/tui-winsource.c (tui_update_source_window_as_is)
2353         (tui_update_source_windows_with_addr, tui_erase_source_content):
2354         Update.
2355         (tui_clear_exec_info_content): Remove.
2356
2357 2019-08-13  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2360         declare.
2361         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2362         call tui_erase_exec_info_content.
2363         (tui_clear_exec_info_content): Rename from
2364         tui_erase_exec_info_content.
2365         (tui_clear_exec_info_content): Delete.
2366
2367 2019-08-13  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-winsource.h (struct tui_source_window_base)
2370         <show_exec_info_content>: Declare.
2371         (tui_show_exec_info_content): Don't declare.
2372         * tui/tui-winsource.c
2373         (tui_source_window_base::show_exec_info_content): Rename from
2374         tui_show_exec_info_content.
2375         (tui_source_window_base::update_exec_info): Update.
2376
2377 2019-08-13  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2380         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2381         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2382         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2383         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2384         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2385         ... here.
2386
2387 2019-08-13  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-winsource.h (struct tui_source_window_base)
2390         <update_exec_info>: Declare.
2391         (tui_update_exec_info): Don't declare.
2392         * tui/tui-winsource.c (tui_update_source_window_as_is)
2393         (tui_source_window_base::refresh_all)
2394         (tui_update_all_breakpoint_info): Update.
2395         (tui_source_window_base::update_exec_info): Rename from
2396         tui_update_exec_info.
2397         * tui/tui-stack.c (tui_show_frame_info): Update.
2398
2399 2019-08-13  Tom Tromey  <tom@tromey.com>
2400
2401         * tui/tui-winsource.h (struct tui_source_window_base)
2402         <set_exec_info_content>: Declare.
2403         (tui_set_exec_info_content): Don't declare.
2404         * tui/tui-winsource.c
2405         (tui_source_window_base::set_exec_info_content): Rename from
2406         tui_set_exec_info_content.
2407         (tui_update_exec_info): Update.
2408
2409 2019-08-13  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-winsource.h (struct tui_source_window_base)
2412         <show_source_content>: Declare.
2413         (tui_show_source_content): Don't declare.
2414         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2415         (tui_source_window_base::show_source_content): Rename from
2416         tui_show_source_content.
2417         (tui_source_window_base::refresh_all): Update.
2418         * tui/tui-layout.c (show_source_disasm_command)
2419         (show_source_or_disasm_and_command): Update.
2420
2421 2019-08-13  Tom Tromey  <tom@tromey.com>
2422
2423         * tui/tui-winsource.c (tui_erase_source_content)
2424         (tui_show_source_content, tui_source_window_base::refresh_all):
2425         Update.
2426         * tui/tui-wingeneral.h
2427         (tui_check_and_display_highlight_if_needed): Don't declare.
2428         * tui/tui-wingeneral.c
2429         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2430         check_and_display_highlight_if_needed.
2431         * tui/tui-win.c (tui_rehighlight_all)
2432         (tui_win_info::make_visible_with_new_height): Update.
2433         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2434         (tui_data_window::erase_data_content)
2435         (tui_data_window::display_all_data): Update.
2436         * tui/tui-data.h (struct tui_win_info)
2437         <check_and_display_highlight_if_needed>: Declare.
2438
2439 2019-08-13  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui-win.c (tui_resize_all): Call
2442         tui_delete_invisible_windows.
2443         * tui/tui-layout.c (show_layout): Call
2444         tui_delete_invisible_windows.
2445         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2446         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2447
2448 2019-08-13  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2451         tui_add_win_to_layout.
2452
2453 2019-08-13  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2456         * tui/tui-layout.c (tui_default_win_height): Now static.
2457
2458 2019-08-13  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2461         single switch.
2462         (show_source_disasm_command, show_source_or_disasm_and_command):
2463         Don't check current layout.
2464
2465 2019-08-13  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-wingeneral.c (make_all_visible): Remove.
2468         (tui_make_all_invisible): Simplify.
2469         * tui/tui-layout.c (tui_make_all_invisible): Move from
2470         tui-wingeneral.c; simplify.
2471         (show_layout): Hoist call to tui_make_all_invisible.
2472         (show_data): Don't call tui_make_all_invisible.
2473
2474 2019-08-13  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2477         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2478
2479 2019-08-13  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2482         tui-data.c.
2483         (show_source_disasm_command, show_data)
2484         (show_source_or_disasm_and_command): Don't use
2485         tui_set_current_layout_to.
2486         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2487         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2488         tui-layout.c.
2489         (tui_set_current_layout_to): Remove.
2490
2491 2019-08-13  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui-layout.c (tui_set_layout): Update.
2494         * tui/tui-data.h (struct tui_layout_def): Remove.
2495         (tui_layout_def): Don't declare.
2496         * tui/tui-data.c (layout_def): Remove.
2497         (tui_layout_def): Remove.
2498
2499 2019-08-13  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-winsource.h (struct tui_source_window_base)
2502         <clear_detail>: No longer "override".
2503         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2504         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2505         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2506         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2507         Remove.
2508         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2509
2510 2019-08-13  Tom Tromey  <tromey@adacore.com>
2511
2512         * tracepoint.c: Don't include readline.h or history.h.
2513
2514 2019-08-12  Tom Tromey  <tom@tromey.com>
2515
2516         * configure: Rebuild.
2517         * configure.ac: Check for readline 7.
2518         * NEWS: Mention readline 7 requirement.
2519         * README: Update.
2520
2521 2019-08-12  Tom Tromey  <tom@tromey.com>
2522
2523         * mingw-hdep.c (gdb_select): Remove readline hack.
2524
2525 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2526
2527         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2528         when the function fails.
2529
2530 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2531
2532         * s390-tdep.c (s390_type_align): New function.
2533         (s390_gdbarch_init): Set it as type_align gdbarch method.
2534
2535 2019-08-09  Tom de Vries  <tdevries@suse.de>
2536
2537         PR gdb/24591
2538         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2539         pc_low with relocation offset.
2540
2541 2019-08-07  Tom Tromey  <tromey@adacore.com>
2542
2543         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2544         (print_frame_args): Update.
2545         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2546         Update.
2547         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2548         * frame.h (struct frame_arg): Add initializers.
2549         <error>: Now a unique_xmalloc_ptr.
2550
2551 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2552
2553         * NEWS: Expand the Pointer Authentication entry.
2554         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2555         (aarch64_frame_unmask_lr): ... to this.
2556         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2557         Call aarch64_frame_unmask_lr.
2558         * frame.c (struct frame_info): Add "masked" variable.
2559         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2560         (fprint_frame): Check for masked pc.
2561         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2562         declarations.
2563         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2564         * stack.c (print_frame): Check for masked pc.
2565
2566 2019-08-06  Tom Tromey  <tom@tromey.com>
2567
2568         * stabsread.c (patch_block_stabs, read_one_struct_field)
2569         (read_enum_type): Use obstack_strndup.
2570         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2571         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2572         * dwarf2read.c (guess_full_die_structure_name)
2573         (anonymous_struct_prefix): Use obstack_strndup.
2574         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2575         * c-exp.y (yylex): Use obstack_strndup.
2576         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2577         (write_var_or_type): Use obstack_strndup.
2578
2579 2019-08-06  Tom Tromey  <tom@tromey.com>
2580
2581         * symfile.c (reread_symbols): Use obstack_strdup.
2582         * stabsread.c (read_type): Use obstack_strdup.
2583         * gdb_obstack.h (obstack_strdup): New overload.
2584         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2585         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2586         (dwarf2_canonicalize_name): Use obstack_strdup.
2587         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2588         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2589         Use obstack_strdup.
2590
2591 2019-08-06  Tom Tromey  <tom@tromey.com>
2592
2593         * gdb_obstack.h (obstack_strdup): Define.
2594         * gdb_obstack.c (obstack_strdup): Don't define.
2595
2596 2019-08-06  Tom Tromey  <tom@tromey.com>
2597
2598         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2599         obstack_strdup.
2600         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2601         obstack_strdup.
2602         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2603         * stabsread.c (common_block_start): Use obstack_strdup.
2604         * objfiles.c (set_objfile_main_name, objfile): Use
2605         obstack_strdup.
2606         * namespace.c (add_using_directive): Use obstack_strdup.
2607         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2608         * jit.c (finalize_symtab): Use obstack_strdup.
2609         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2610         (guess_partial_die_structure_name, partial_die_info::fixup)
2611         (dwarf2_name): Use obstack_strdup.
2612         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2613         obstack_strdup.
2614         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2615         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2616         obstack_strdup.
2617         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2618
2619 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2620
2621         * unittests/help-doc-selftests.c: New file.
2622         * Makefile.in: Add the new file.
2623
2624 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2625
2626         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2627         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2628         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2629         the trailing '.' is not output, and the first character is uppercased.
2630         (print_help_for_command): Update call to print_doc_line.
2631         (print_doc_of_command): Likewise.
2632         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2633         * cli/cli-option.c (append_indented_doc): Do not append newline.
2634         (build_help_option): Append newline after first appended_indented_doc
2635         only if a second call is done.
2636         (build_help): Append 2 new lines before each option, except the first
2637         one.
2638         * compile/compile.c (_initialize_compile): Add new lines after
2639         %OPTIONS%, when not at the end of the help.
2640         Change help doc or code
2641         producing the help doc to respect the invariants.
2642         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2643         Also removed the new line after 'Options:', as all other commands
2644         do not put an empty line between 'Options:' and the first option.
2645         * printcmd.c (_initialize_printcmd): Likewise.
2646         * stack.c (_initialize_stack): Likewise.
2647         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2648         incorrectly telling COMMAND is optional.
2649         * ada-lang.c (_initialize_ada_language): Change help doc or code
2650         producing the help doc to respect the invariants.
2651         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2652         * breakpoint.c (_initialize_breakpoint): Likewise.
2653         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2654         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2655         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2656         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2657         _initialize_cli_style): Likewise.
2658         * corelow.c (core_target_info): Likewise.
2659         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2660         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2661         * filesystem.c (_initialize_filesystem): Likewise.
2662         * frame.c (_initialize_frame): Likewise.
2663         * gnu-nat.c (add_task_commands): Likewise.
2664         * infcall.c (_initialize_infcall): Likewise.
2665         * infcmd.c (_initialize_infcmd): Likewise.
2666         * interps.c (_initialize_interpreter): Likewise.
2667         * language.c (_initialize_language): Likewise.
2668         * linux-fork.c (_initialize_linux_fork): Likewise.
2669         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2670         * maint.c (_initialize_maint_cmds): Likewise.
2671         * memattr.c (_initialize_mem): Likewise.
2672         * printcmd.c (_initialize_printcmd): Likewise.
2673         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2674         _RegEx): Likewise.
2675         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2676         * record-btrace.c (_initialize_record_btrace): Likewise.
2677         * record-full.c (_initialize_record_full): Likewise.
2678         * record.c (_initialize_record): Likewise.
2679         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2680         * regcache.c (_initialize_regcache): Likewise.
2681         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2682         _initialize_remote): Likewise.
2683         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2684         * serial.c (_initialize_serial): Likewise.
2685         * skip.c (_initialize_step_skip): Likewise.
2686         * source.c (_initialize_source): Likewise.
2687         * stack.c (_initialize_stack): Likewise.
2688         * symfile.c (_initialize_symfile): Likewise.
2689         * symtab.c (_initialize_symtab): Likewise.
2690         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2691         * top.c (init_main): Likewise.
2692         * tracefile-tfile.c (tfile_target_info): Likewise.
2693         * tracepoint.c (_initialize_tracepoint): Likewise.
2694         * tui/tui-win.c (_initialize_tui_win): Likewise.
2695         * utils.c (add_internal_problem_command): Likewise.
2696         * valprint.c (value_print_option_defs): Likewise.
2697
2698 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2699
2700         PR build/24886
2701         * configure.ac: Drop enable-libmcheck support.
2702         * configure, config.in: Rebuild.
2703         * libmcheck.m4: Remove.
2704         * acinclude.m4: Don't include it.
2705         * Makefile.in: Don't distribute it.
2706         * top.c (print_gdb_configuration): Don't mention it.
2707
2708 2019-08-06  Tom Tromey  <tom@tromey.com>
2709
2710         * utils.c (set_output_style): Sometimes pass stream to
2711         emit_style_escape.
2712         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2713         * record-btrace.c (btrace_insn_history): Update.
2714         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2715         method.
2716         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2717         Update initializers.
2718         <m_uiout>: New field.
2719         <m_di>: Move lower.
2720         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2721         Remove "uiout" parameter.
2722         (dump_insns): Update.
2723         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2724         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2725
2726 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2727
2728         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2729         (error_in_psymtab_expansion): Likewise.
2730         (lookup_symbol_via_quick_fns): Likewise.
2731         (basic_lookup_transparent_type_quick): Likewise.
2732         (basic_lookup_transparent_type_1): Likewise.
2733
2734 2019-08-06  Tom Tromey  <tromey@adacore.com>
2735
2736         * source.c (last_source_error): Now bool.
2737         (print_source_lines_base): Make "noprint" bool.  Only open
2738         source file when last_source_visited changes.
2739
2740 2019-08-06  Tom Tromey  <tromey@adacore.com>
2741
2742         * annotate.c (annotate_source_line): Use g_source_cache.
2743         * source-cache.c (source_cache::get_plain_source_lines): Change
2744         parameters.  Populate m_offset_cache.
2745         (source_cache::ensure): New method.
2746         (source_cache::get_line_charpos): New method.
2747         (extract_lines): Move lower.  Change parameters.
2748         (source_cache::get_source_lines): Move lower.
2749         * source-cache.h (class source_cache): Update comment.
2750         <get_line_charpos>: New method.
2751         <get_source_lines>: Update comment.
2752         <clear>: Clear m_offset_cache.
2753         <get_plain_source_lines>: Change parameters.
2754         <ensure>: New method
2755         <m_offset_cache>: New member.
2756         * source.c (forget_cached_source_info_for_objfile): Update.
2757         (info_source_command): Use g_source_cache.
2758         (find_source_lines, open_source_file_with_line_charpos): Remove.
2759         (print_source_lines_base, search_command_helper): Use g_source_cache.
2760         * source.h (open_source_file_with_line_charpos): Don't declare.
2761         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2762         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2763         Use g_source_cache.
2764
2765 2019-08-06  Tom Tromey  <tromey@adacore.com>
2766
2767         * source-cache.c (source_cache::get_plain_source_lines):
2768         Remove "first_line" and "last_line" parameters.
2769         (source_cache::get_source_lines): Cache plain text.
2770         * source-cache.h (class source_cache)
2771         <get_plain_source_lines>: Update.
2772
2773 2019-08-06  Tom Tromey  <tromey@adacore.com>
2774
2775         * source-cache.c (extract_lines): No longer a method.
2776         Changed type of parameter.  Include final newline.
2777         (selftests::extract_lines_test): New function.
2778         (_initialize_source_cache): Likewise.
2779         * source-cache.h (class source_cache)
2780         <extract_lines>: Don't declare.
2781
2782 2019-08-06  Tom Tromey  <tromey@adacore.com>
2783
2784         * breakpoint.c (init_breakpoint_sal): Update.
2785         (breakpoint): Update.
2786         * breakpoint.h (struct breakpoint) <filter>: Now a
2787         unique_xmalloc_ptr.
2788
2789 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2790
2791         * NEWS: Mention dictionary access on blocks.
2792         * python/py-block.c (blpy_getitem): New function.
2793         (block_object_as_mapping): New struct.
2794         (block_object_type): Use new struct for tp_as_mapping field.
2795
2796 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2797
2798         * objfiles.h (objfile): Add a comment describing partial symbols.
2799
2800 2019-08-05  Tom Tromey  <tromey@adacore.com>
2801
2802         * compile/compile.c (_initialize_compile): Use _(), not N_().
2803         * thread.c (_initialize_thread): Use _(), not N_().
2804         * stack.c (_initialize_stack): Use _(), not N_().
2805         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2806
2807 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2808
2809         * dwarf2read.c (struct dw2_symtab_iterator):
2810         <want_specific_block>: Remove.
2811         <block_index>: Change type to gdb::optional.
2812         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2813         change type of BLOCK_INDEX parameter to gdb::optional.
2814         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2815         (dw2_lookup_symbol): Don't pass argument for
2816         WANT_SPECIFIC_BLOCK.
2817         (dw2_expand_symtabs_for_function): Don't pass argument for
2818         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2819         (class dw2_debug_names_iterator)
2820         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2821         parameter, change BLOCK_INDEX type to gdb::optional.
2822         <m_want_specific_block>: Remove.
2823         <m_block_index>: Change type to gdb::optional.
2824         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2825         gdb::optional.  Re-write in function of gdb::optional.
2826         (dw2_debug_names_lookup_symbol): Don't pass argument for
2827         WANT_SPECIFIC_BLOCK.
2828         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2829         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2830         BLOCK_INDEX.
2831
2832 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2833
2834         * NEWS: Mention changes to "info sources" command.
2835
2836 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2837
2838         * symtab.c (filename_partial_match_opts): New struct type.
2839         (struct output_source_filename_data): New members
2840         regexp, c_regexp, partial_match.
2841         (output_source_filename): Use new members to decide to print file.
2842         (info_sources_option_defs): New variable.
2843         (make_info_sources_options_def_group, print_info_sources_header,
2844         info_sources_command_completer):
2845         New functions.
2846         (info_sources_command): Read new optional arguments.
2847         (_initialize_symtab): Update info sources help.
2848
2849 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2850
2851         * ada-lang.c (exception_support_info_v0): Renamed from...
2852         (default_exception_support_info): ... this.  Create new
2853         definition for v1.
2854         (ada_has_this_exception_support): Look up catch_handlers_sym.
2855         (ada_exception_support_info_sniffer): Try v0 after default.
2856
2857 2019-08-01  Tom Tromey  <tromey@adacore.com>
2858
2859         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2860         gdbarch.h.
2861
2862 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2863
2864         * s12z-tdep.c: Fix include path for s12z-opc.h.
2865
2866 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2867
2868         * NEWS: Require GNU make 3.82.
2869
2870 2019-07-16  Tom Tromey  <tom@tromey.com>
2871
2872         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2873         declare.
2874
2875 2019-07-30  Tom Tromey  <tromey@adacore.com>
2876
2877         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2878
2879 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2880
2881         * printcmd.c (print_address_symbolic): Print negative offsets.
2882         (build_address_symbolic): Force signed arithmetic when computing
2883         offset.
2884
2885 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2886
2887         PR/24474: Add a function to lookup static variables.
2888         * NEWS: Mention this new function.
2889         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2890         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2891         * python/python.c (python_GdbMethods): Add new function.
2892
2893 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2894
2895         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2896         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2897         (objfpy_lookup_static_symbol): New function.
2898         (objfile_object_methods): Add new functions.
2899
2900 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2901
2902         * NEWS: Mention 'set|show print frame-info'.  Mention new
2903         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2904         backtrace argument.  Mention that python frame filtering code
2905         is now consistent with what 'backtrace' command prints.
2906
2907 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2908
2909         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2910         comments.
2911         (print_frame_info_auto, print_frame_info_source_line,
2912         print_frame_info_location, print_frame_info_source_and_location,
2913         print_frame_info_location_and_address, print_frame_info_short_location):
2914         New declarations.
2915         (struct frame_print_options): New member print_frame_info.
2916         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2917         * stack.h (get_user_print_what_frame_info): New declaration.
2918         (frame_show_address): New declaration.
2919         * stack.c (print_frame_arguments_choices): New value 'presence'.
2920         (print_frame_info_auto, print_frame_info_source_line,
2921         print_frame_info_location, print_frame_info_source_and_location,
2922         print_frame_info_location_and_address, print_frame_info_short_location,
2923         print_frame_info_choices, print_frame_info_print_what): New definitions.
2924         (print_frame_args): Only print dots for args if print frame-arguments
2925         is 'presence'.
2926         (frame_print_option_defs): New element for "frame-info".
2927         (get_user_print_what_frame_info): New function.
2928         (frame_show_address): Make non static.  Move comment to stack.h.
2929         (print_frame_info_to_print_what): New function.
2930         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2931         to decide what to print.
2932         (backtrace_command_1): Handle the new print_frame_arguments_presence
2933         value.
2934         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2935         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2936         (py_print_frame): In non-mi mode, use LOCATION as default for
2937         print_what, similarly to frame information printed directly by
2938         backtrace command. Handle frame-info user option in non MI mode.
2939
2940 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2941
2942         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2943         Add case for debugging 32-bit target on 64-bit host.  Revise
2944         comment.
2945
2946 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2947
2948         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2949         instead of find_function_entry_range_from_pc.
2950
2951 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2952
2953         * stack.c (find_frame_funname): Remove code which preferred
2954         minsym over symtab sym in "certain pathological cases".
2955
2956         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2957         parameter.  Change type of "do_demangle" to bool.
2958         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2959         Pass suitable "prefer_sym_over_minsym" flag to
2960         build_address_symbolic().  Don't output "+" for negative offsets.
2961         * printcmd.c (print_address_symbolic): Update invocation of
2962         build_address_symbolic to include a "prefer_sym_over_minsym"
2963         flag.
2964         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2965         Restrict cases in which use of minimal symbol is preferred to that
2966         of a found symbol.  Update comments.
2967
2968         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2969         for entry pc when entry pc is out of range for that FDE.
2970
2971 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2972
2973         PR gdb/24839:
2974         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2975         type.
2976
2977 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2978
2979         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2980         this function's Python signature.
2981
2982
2983 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2984
2985         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2986         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2987         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2988         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2989         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2990
2991
2992 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2993
2994         * h8300-tdep.c (h8300_register_name_common): New.
2995         h8300_register_name): Use h8300_register_name_common.
2996         (h8300s_register_name): Likewise.
2997         (h8300sx_register_name): Likewise.
2998         (h8300h_register_nam): New.
2999         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3000
3001
3002 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3003
3004         * arm-tdep.c (arm_skip_cmse_entry): New function.
3005         (arm_is_sgstubs_section): New function.
3006         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3007
3008 2019-07-22  Tom Tromey  <tom@tromey.com>
3009
3010         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3011         Don't self-assign.
3012
3013 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3014
3015         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3016         type_print.
3017
3018 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3021         so that GDB doesn't match any msymbols when searching in the
3022         TYPES_DOMAIN.
3023         (print_symbol_info): Print using typedef_print or type_print based
3024         on the type of the symbol.  Add updated FIXME comment moved from...
3025         (_initialize_symtab): ... move and update FIXME comment to above.
3026
3027 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * NEWS: Mention adding -q option to "info types".
3030         * symtab.c (struct info_types_options): New struct.
3031         (info_types_options_defs): New variable.
3032         (make_info_types_options_def_group): New function.
3033         (info_types_command): Use gdb::option framework to parse options.
3034         (info_types_command_completer): New function.
3035         (_initialize_symtab): Extend the help text on "info types" and
3036         register command completer.
3037
3038 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3039
3040         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3041         (lookup_symbol_in_objfile): Change int to block_enum and add a
3042         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3043
3044 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3045
3046         * MAINTAINERS (Write After Approval): Add self.
3047
3048 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3051         instruction to the dummy code region.
3052
3053 2019-07-19  Tom Tromey  <tromey@adacore.com>
3054
3055         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3056         (ARGSUSED, PARAMS, __func__): Remove rules.
3057
3058 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3059
3060         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3061         * features/arm/arm-with-iwmmxt.c: Remove.
3062         * features/arm/arm-with-iwmmxt.xml: Remove.
3063         * features/arm/arm-with-m-fpa-layout.c: Remove.
3064         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3065         * features/arm/arm-with-m-vfp-d16.c: Remove.
3066         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3067         * features/arm/arm-with-m.c: Remove.
3068         * features/arm/arm-with-m.xml: Remove.
3069         * features/arm/arm-with-neon.c: Remove.
3070         * features/arm/arm-with-neon.xml: Remove.
3071         * features/arm/arm-with-vfpv2.c: Remove.
3072         * features/arm/arm-with-vfpv2.xml: Remove.
3073         * features/arm/arm-with-vfpv3.c: Remove.
3074         * features/arm/arm-with-vfpv3.xml: Remove.
3075
3076 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3077
3078         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3079
3080 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3081
3082         * arch/aarch32.c (aarch32_create_target_description): Create
3083         target descriptions using features.
3084         * arch/arm.c (arm_create_target_description)
3085         (arm_create_mprofile_target_description): Likewise.
3086         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3087
3088 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3089
3090         * Makefile.in: Add new files.
3091         * aarch32-tdep.c: New file.
3092         * aarch32-tdep.h: New file.
3093         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3094         Call aarch32_read_description.
3095         * arch/aarch32.c: New file.
3096         * arch/aarch32.h: New file.
3097         * arch/arm.c (arm_create_target_description)
3098         (arm_create_mprofile_target_description): New function.
3099         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3100         (arm_create_target_description)
3101         (arm_create_mprofile_target_description): New declaration.
3102         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3103         read_description functions.
3104         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3105         Likewise.
3106         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3107         * arm-tdep.c (tdesc_arm_list): New variable.
3108         (arm_register_g_packet_guesses): Call create description functions.
3109         (arm_read_description) (arm_read_mprofile_description): New
3110         function.
3111         * arm-tdep.h (arm_read_description)
3112         (arm_read_mprofile_description): Add declaration.
3113         * configure.tgt: Add new files.
3114
3115 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3116
3117         * top.c (new_ui_command): Open specified terminal just once.
3118
3119 2019-07-18  Tom Tromey  <tromey@adacore.com>
3120
3121         * symtab.c (main_name): Constify return type.
3122         * symfile.c (set_initial_language): Update.
3123         * symtab.h (main_name): Constify return type.
3124
3125 2019-07-17  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-winsource.c (tui_update_source_window)
3128         (tui_update_source_window_as_is)
3129         (tui_update_source_windows_with_line): Remove return.
3130         * tui/tui-disasm.c (tui_show_disassem)
3131         (tui_show_disassem_and_update_source): Remove return.
3132         * tui/tui.c (tui_reset): Remove return.
3133         * tui/tui-wingeneral.c
3134         (tui_check_and_display_highlight_if_needed): Remove return.
3135
3136 2019-07-17  Tom Tromey  <tom@tromey.com>
3137
3138         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3139
3140 2019-07-17  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-winsource.h (struct tui_exec_info_window)
3143         (struct tui_source_window_base): Move from tui-data.h.
3144         * tui/tui-winsource.c: Move many method definitions from
3145         elsewhere.  Remove "structuring" comments.
3146         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3147         (tui_source_window_base::refresh_window): Move to
3148         tui-winsource.c.
3149         * tui/tui-win.c (tui_source_window_base::refresh_all)
3150         (tui_source_window_base::update_tab_width)
3151         (tui_source_window_base::set_new_height)
3152         (tui_source_window_base::do_make_visible_with_new_height): Move to
3153         tui-winsource.c.
3154         * tui/tui-source.h: Update.
3155         * tui/tui-source.c (tui_source_window_base::reset): Move to
3156         tui-winsource.c.
3157         * tui/tui-disasm.h: Update.
3158         * tui/tui-data.h (struct tui_exec_info_window): Move to
3159         tui-winsource.h.
3160         (struct tui_source_window_base): Likewise.
3161         * tui/tui-data.c (tui_source_window_base::clear_detail)
3162         (tui_source_window_base, ~tui_source_window_base): Move to
3163         tui-winsource.c.
3164
3165 2019-07-17  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-win.c (tui_resize_all)
3168         (tui_source_window_base::update_tab_width)
3169         (tui_adjust_win_heights): Update.
3170         (tui_win_info::make_invisible_and_set_new_height): Rename from
3171         make_invisible_and_set_new_height.
3172         * tui/tui-data.h (struct tui_win_info)
3173         <make_invisible_and_set_new_height>: New method.
3174
3175 2019-07-17  Tom Tromey  <tom@tromey.com>
3176
3177         * tui/tui.c: Update.
3178         * tui/tui-source.h (struct tui_source_window): Move from
3179         tui-data.h.
3180         * tui/tui-layout.c: Update.
3181         * tui/tui-disasm.c: Update.
3182         * tui/tui-data.h (struct tui_source_window): Move to
3183         tui-source.h.
3184
3185 2019-07-17  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3188         tui-data.h.
3189         * tui/tui-data.h (struct tui_disasm_window): Move to
3190         tui-disasm.h.
3191
3192 2019-07-17  Tom Tromey  <tom@tromey.com>
3193
3194         * tui/tui-regs.h (struct tui_data_item_window): Move from
3195         tui-data.h.
3196         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3197         * tui/tui-data.h (struct tui_data_item_window): Move to
3198         tui-regs.h.
3199         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3200
3201 2019-07-17  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui.c: Update.
3204         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3205         (tui_cmd_window::max_height): Move to tui-command.c.
3206         * tui/tui-layout.c: Update.
3207         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3208         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3209         tui-command.c.
3210         * tui/tui-command.h (struct tui_cmd_window): Move from
3211         tui-data.h.
3212         * tui/tui-command.c: Remove "structuring" comments.
3213         (tui_cmd_window::clear_detail)
3214         (tui_cmd_window::do_make_visible_with_new_height)
3215         (tui_cmd_window::max_height): Move from elsewhere.
3216
3217 2019-07-17  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3220         Now static.
3221         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3222         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3223
3224 2019-07-17  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui.c: Update.
3227         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3228         tui-regs.c.
3229         * tui/tui-windata.h: Remove file.
3230         * tui/tui-windata.c: Remove file.
3231         * tui/tui-win.c (tui_data_window::set_new_height)
3232         (tui_data_window::do_make_visible_with_new_height): Move to
3233         tui-regs.c.
3234         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3235         * tui/tui-regs.c: Remove "structuring" comments.
3236         (tui_data_window::first_data_item_displayed)
3237         (tui_data_window::delete_data_content_windows)
3238         (tui_data_window::erase_data_content)
3239         (tui_data_window::display_all_data)
3240         (tui_data_window::refresh_all)
3241         (tui_data_window::do_scroll_vertical)
3242         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3243         (tui_data_window::do_make_visible_with_new_height)
3244         (tui_data_window::refresh_window): Move from elsewhere.
3245         (_initialize_tui_regs): Move to end of file.
3246         * tui/tui-layout.c: Update.
3247         * tui/tui-hooks.c: Update.
3248         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3249         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3250         tui-regs.c.
3251         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3252
3253 2019-07-17  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3256         seen.
3257
3258 2019-07-17  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-win.c (tui_source_window_base::set_new_height)
3261         (tui_source_window_base::do_make_visible_with_new_height): Use
3262         m_has_locator field directly.
3263         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3264         method.
3265         (struct tui_source_window_base) <has_locator>: Likewise.
3266
3267 2019-07-17  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3270         Don't declare.
3271         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3272         Remove.
3273         * tui/tui-win.c (tui_source_window_base::set_new_height)
3274         (tui_source_window_base::set_new_height)
3275         (make_invisible_and_set_new_height)
3276         (tui_source_window_base::do_make_visible_with_new_height)
3277         (tui_source_window_base::do_make_visible_with_new_height):
3278         Update.
3279         * tui/tui-layout.c (show_source_disasm_command, show_data)
3280         (show_source_or_disasm_and_command): Update.
3281         * tui/tui-layout.c (show_layout): Update.
3282
3283 2019-07-17  Tom Tromey  <tom@tromey.com>
3284
3285         * tui/tui-layout.c (make_data_window): Remove.
3286         (show_data): Unify creation and re-initialization cases.
3287
3288 2019-07-17  Tom Tromey  <tom@tromey.com>
3289
3290         * tui/tui-layout.c (make_source_window, make_disasm_window):
3291         Remove.
3292         (show_data): Unify creation and re-initialization cases.
3293
3294 2019-07-17  Tom Tromey  <tom@tromey.com>
3295
3296         * tui/tui-layout.c (make_command_window): Remove.
3297         (show_source_disasm_command, show_source_or_disasm_and_command):
3298         Unify creation and re-initialization cases.
3299
3300 2019-07-17  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3303         creation and re-initialization cases.
3304
3305 2019-07-17  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-regs.c (tui_get_register): Return void.
3308
3309 2019-07-17  Tom Tromey  <tom@tromey.com>
3310
3311         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3312         Simplify.
3313
3314 2019-07-17  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3317         resetting.
3318
3319 2019-07-17  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3322         * tui/tui-regs.c (tui_reg_layout): New function.
3323         (tui_show_registers, tui_reg_command): Use it.
3324         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3325         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3326         parameters.
3327         (tui_layout_command): Remove.
3328
3329 2019-07-17  Tom Tromey  <tom@tromey.com>
3330
3331         * tui/tui-layout.h (tui/tui-layout): Return void.
3332         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3333
3334 2019-07-17  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-layout.c (show_source_disasm_command, show_data):
3337         Update.
3338         (reset_locator): Remove.
3339         (show_source_or_disasm_and_command): Update.
3340
3341 2019-07-17  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-source.c (tui_source_window_base::reset): Remove
3344         win_type parameter.
3345         * tui/tui-layout.c (make_command_window, make_source_window)
3346         (make_disasm_window, make_data_window)
3347         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3348         (reset_locator, show_source_or_disasm_and_command): Update.
3349         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3350         win_type parameter.
3351         (struct tui_source_window_base) <reset>: Likewise.
3352
3353 2019-07-17  Tom Tromey  <tom@tromey.com>
3354
3355         * tui/tui-layout.c (show_source_disasm_command): Use
3356         reset_locator.
3357         (reset_locator): New function.
3358         (init_and_make_win): Remove.
3359         (show_source_or_disasm_and_command): Use reset_locator.
3360
3361 2019-07-17  Tom Tromey  <tom@tromey.com>
3362
3363         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3364         condition.
3365         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3366         Remove condition.
3367         * tui/tui-source.c (tui_source_window_base::reset): New method.
3368         * tui/tui-layout.c (make_command_window): Don't call
3369         init_and_make_win.
3370         (make_source_window, make_disasm_window): Don't call
3371         make_source_or_disasm_window.
3372         (make_data_window): Don't call init_and_make_win.  Change calling
3373         convention.
3374         (show_source_disasm_command, show_data): Simplify.
3375         (make_source_or_disasm_window): Remove.
3376         (show_source_or_disasm_and_command): Simplify.
3377         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3378         (struct tui_source_window_base) <reset>: Likewise.
3379         <execution_info>: Remove initializer.
3380         * tui/tui-data.c (tui_source_window_base): Initialize
3381         execution_info.
3382
3383 2019-07-17  Tom Tromey  <tom@tromey.com>
3384
3385         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3386         variable.
3387
3388 2019-07-17  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui.c (tui_rl_other_window): Update.
3391         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3392         superclass method first.  Always iterate over regs_content.
3393         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3394         method.
3395         * tui/tui-win.c (tui_set_focus_command): Update.
3396
3397 2019-07-17  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-win.c (tui_set_focus_command): Rename from
3400         tui_set_focus.  Call tui_enable.
3401         (tui_set_focus_command): Remove.
3402
3403 2019-07-17  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3406         refresh_window.
3407         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3408         touchwin.
3409         (tui_data_window::refresh_window): Call refresh_window on data
3410         items.  Always call superclass refresh_window.
3411         (tui_win_info::refresh): Remove.
3412         (tui_source_window_base::refresh_window): Update.
3413         (tui_refresh_all): Update.
3414         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3415         refresh_window.
3416         (show_source_or_disasm_and_command): Likewise.
3417         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3418         (struct tui_source_window_base) <refresh>: Likewise.
3419
3420 2019-07-17  Tom Tromey  <tom@tromey.com>
3421
3422         * tui/tui-winsource.c (tui_clear_source_content)
3423         (tui_show_source_content): Update.
3424         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3425         whether content is empty.
3426         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3427         Remove.
3428
3429 2019-07-17  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3432         window's contents.
3433         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3434         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3435
3436 2019-07-17  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3439         (struct tui_data_item_window): Update.
3440
3441 2019-07-17  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3444         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3445         defines.
3446
3447 2019-07-17  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-winsource.h (tui_erase_source_content)
3450         (tui_clear_source_content): Remove "display_prompt" parameter.
3451         * tui/tui-winsource.c (tui_update_source_window_as_is)
3452         (tui_update_source_windows_with_addr): Update.
3453         (tui_clear_source_content): Remove "display_prompt" parameter.
3454         (tui_erase_source_content): Likewise.  Simplify.
3455         (tui_show_source_content): Update.
3456         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3457         * tui/tui-stack.c (tui_show_frame_info): Update.
3458         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3459         Remove defines.
3460
3461 2019-07-17  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3464         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3465         parameter.
3466         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3467         parameter.
3468
3469 2019-07-17  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-winsource.c (tui_clear_source_content)
3472         (tui_show_source_content, tui_show_exec_info_content)
3473         (tui_clear_exec_info_content): Update.
3474         * tui/tui-stack.c (tui_show_locator_content): Update.
3475         (tui_show_frame_info): Update.
3476         * tui/tui-source.h (tui_source_window): Don't declare.
3477         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3478         from tui_source_is_displayed.
3479         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3480         Remove field.
3481         (struct tui_source_window_base) <content_in_use>: New field.  Now
3482         bool.
3483         (struct tui_source_window) <showing_source_p>: New method.
3484         (TUI_SRC_WIN): Change cast.
3485         * tui/tui-data.c (tui_initialize_static_data): Update.
3486
3487 2019-07-17  Tom Tromey  <tom@tromey.com>
3488
3489         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3490         location_matches_p.
3491         * tui/tui-source.c (tui_source_window::location_matches_p): New
3492         method.
3493         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3494         method.
3495         * tui/tui-data.h (struct tui_source_window_base)
3496         <location_matches_p>: New method.
3497         (struct tui_source_window, struct tui_disasm_window)
3498         <location_matches_p>: Likewise.
3499
3500 2019-07-17  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-win.c (tui_set_win_height_command): Rename from
3503         tui_set_win_height.
3504         (tui_set_win_height_command): Remove.
3505
3506 2019-07-17  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-source.c (tui_source_window): New constructor.  Add
3509         observer.
3510         (~tui_source_window): New destructor.
3511         (tui_source_window::style_changed): New method.
3512         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3513         (tui_attach_detach_observers): Update.
3514         * tui/tui-data.h (struct tui_source_window): Make constructor not
3515         inline.  Add destructor.
3516         (struct tui_source_window) <style_changed>: New method.
3517         <m_observable>: New member.
3518
3519 2019-07-17  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3522         * tui/tui-win.c (tui_resize_all): Fix typo.
3523
3524 2019-07-17  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3527         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3528         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3529         * tui/tui-win.c (window_name_completer): Use foreach.
3530         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3531         (update_tab_width): Likewise.
3532         * tui/tui-layout.c (show_layout): Update.
3533         * tui/tui-data.h (class tui_window_iterator): New.
3534         (struct all_tui_windows): New.
3535         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3536
3537 2019-07-17  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3540         parameter.  Don't reference globals.
3541         (tui_reg_command): Update.
3542
3543 2019-07-17  Tom Tromey  <tom@tromey.com>
3544
3545         * tui/tui-regs.c (tui_show_registers): Simplify.
3546
3547 2019-07-17  Tom Tromey  <tom@tromey.com>
3548
3549         * tui/tui-regs.c (tui_show_registers): Update.
3550         (tui_show_register_group): Add win_info parameter.
3551
3552 2019-07-17  Tom Tromey  <tom@tromey.com>
3553
3554         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3555         Rename from tui_display_reg_element_at_line.
3556         (tui_data_window::display_registers_from_line): Update.
3557         * tui/tui-data.h (struct tui_data_window)
3558         <display_reg_element_at_line>: New method.
3559
3560 2019-07-17  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-regs.h (tui_display_registers_from)
3563         (tui_display_registers_from_line): Don't declare.
3564         * tui/tui-windata.c (tui_data_window::display_all_data)
3565         (tui_data_window::refresh_all)
3566         (tui_data_window::do_scroll_vertical): Update.
3567         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3568         from tui_display_registers_from.
3569         (tui_display_reg_element_at_line): Update.
3570         (tui_data_window::display_registers_from_line): Rename from
3571         tui_display_registers_from_line.
3572         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3573         display_registers_from_line>: New methods.
3574
3575 2019-07-17  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3578         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3579         from tui_erase_data_content.
3580         (tui_data_window::display_all_data)
3581         (tui_data_window::refresh_all)
3582         (tui_data_window::do_scroll_vertical): Update.
3583         * tui/tui-regs.c (tui_show_registers): Update.
3584         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3585         New method.
3586
3587 2019-07-17  Tom Tromey  <tom@tromey.com>
3588
3589         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3590         declare.
3591         * tui/tui-windata.c
3592         (tui_data_window::delete_data_content_windows): Rename from
3593         tui_delete_data_content_windows.
3594         (tui_data_window::display_all_data)
3595         (tui_data_window::do_scroll_vertical): Update.
3596         * tui/tui-data.h (struct tui_data_window)
3597         <delete_data_content_windows>: New method.
3598
3599 2019-07-17  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3602         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3603
3604 2019-07-17  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3607         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3608         from tui_display_all_data.
3609         * tui/tui-win.c
3610         (tui_data_window::do_make_visible_with_new_height): Update.
3611         * tui/tui-regs.c (tui_show_registers): Update.
3612         * tui/tui-layout.c (tui_set_layout): Update.
3613         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3614         method.
3615
3616 2019-07-17  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3619         * tui/tui-windata.c (tui_display_data_from): Remove.
3620         (tui_data_window::refresh_all): Update.
3621
3622 2019-07-17  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3625         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3626         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3627         tui_display_registers_from_line.
3628         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3629         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3630         "force_display" parameter.
3631
3632 2019-07-17  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3635         declare.
3636         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3637         Rename from tui_first_reg_element_no_inline.
3638         (tui_display_reg_element_at_line)
3639         (tui_display_registers_from_line): Update.
3640         * tui/tui-data.h (struct tui_data_window)
3641         <first_reg_element_no_inline>: New method.
3642
3643 2019-07-17  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-windata.c (tui_display_data_from)
3646         (tui_data_window::do_scroll_vertical): Update.
3647         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3648         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3649         Rename from tui_line_from_reg_element_no.
3650         (tui_display_registers_from_line): Update.
3651         * tui/tui-data.h (struct tui_data_window)
3652         <line_from_reg_element_no>: New method.
3653
3654 2019-07-17  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3657         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3658         tui_last_regs_line_no.
3659         (tui_display_reg_element_at_line)
3660         (tui_display_registers_from_line): Update.
3661         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3662         method.
3663
3664 2019-07-17  Tom Tromey  <tom@tromey.com>
3665
3666         PR tui/24722:
3667         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3668         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3669         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3670         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3671         (tui_update_breakpoint_info): Likewise.
3672         * tui/tui-hooks.c (tui_event_create_breakpoint)
3673         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3674         Update.
3675
3676 2019-07-17  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3679
3680 2019-07-17  Tom Tromey  <tom@tromey.com>
3681
3682         * tui/tui-winsource.c (tui_update_source_window_as_is)
3683         (tui_update_source_windows_with_addr): Update.
3684         * tui/tui-source.h (tui_set_source_content)
3685         (tui_show_symtab_source): Add "win_info" parameter.
3686         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3687         parameter.
3688         (tui_show_symtab_source): Likewise.
3689
3690 2019-07-17  Tom Tromey  <tom@tromey.com>
3691
3692         * tui/tui-wingeneral.c
3693         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3694
3695 2019-07-17  Tom Tromey  <tom@tromey.com>
3696
3697         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3698         (struct tui_cmd_window) <can_scroll>: New method.
3699         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3700         method.
3701
3702 2019-07-17  Tom Tromey  <tromey@adacore.com>
3703
3704         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3705         do_field_signed>: Rename.  Change type of "value".
3706         * ui-out.c (ui_out::field_signed): Rename from field_int.
3707         Change type of "value".
3708         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3709         type of "value".
3710         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3711         do_field_int.  Change type of "value".
3712         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3713         do_field_int.  Change type of "value".
3714         * tracepoint.c (trace_status_mi, tfind_1)
3715         (print_one_static_tracepoint_marker): Update.
3716         * thread.c (print_thread_info_1, print_selected_thread_frame):
3717         Update.
3718         * stack.c (print_frame, print_frame_info): Update.
3719         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3720         Update.
3721         * source.c (print_source_lines_base): Update.
3722         * skip.c (info_skip_command): Update.
3723         * record-btrace.c (btrace_ui_out_decode_error)
3724         (btrace_call_history_src_line): Update.
3725         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3726         Update.
3727         * progspace.c (print_program_space): Update.
3728         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3729         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3730         do_field_int.  Change type of "value".
3731         * mi/mi-out.c (mi_ui_out::do_table_begin)
3732         (mi_ui_out::do_table_header): Update.
3733         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3734         type of "value".
3735         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3736         (mi_cmd_data_list_changed_registers, output_register)
3737         (mi_cmd_data_read_memory, mi_load_progress)
3738         (mi_cmd_trace_frame_collected): Update.
3739         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3740         Update.
3741         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3742         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3743         (mi_cmd_var_list_children, varobj_update_one): Update.
3744         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3745         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3746         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3747         * inferior.c (print_inferior): Update.
3748         * gdb_bfd.c (print_one_bfd): Update.
3749         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3750         Update.
3751         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3752         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3753         do_field_int.  Change type of "value".
3754         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3755         do_field_int.  Change type of "value".
3756         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3757         (print_one_breakpoint_location, print_it_catch_fork)
3758         (print_one_catch_fork, print_it_catch_vfork)
3759         (print_one_catch_vfork, print_it_catch_solib)
3760         (print_it_catch_exec, print_it_ranged_breakpoint)
3761         (print_mention_watchpoint, print_mention_masked_watchpoint)
3762         (bkpt_print_it, update_static_tracepoint): Update.
3763         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3764         * break-catch-syscall.c (print_it_catch_syscall): Update.
3765         * ada-tasks.c (print_ada_task_info): Update.
3766         * ada-lang.c (print_it_exception, print_mention_exception):
3767         Update.
3768
3769 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         PR breakpoints/24541
3772         * gdbarch.c: Regenerate.
3773         * gdbarch.h: Regenerate.
3774         * gdbarch.sh: Adjust return type and parameter types for
3775         'stap_adjust_register'.
3776         (i386_stap_adjust_register): Adjust signature and return new
3777         register name.
3778         * stap-probe.c (stap_parse_register_operand): Adjust use of
3779         'gdbarch_stap_adjust_register'.
3780
3781 2019-07-17  Tom Tromey  <tromey@adacore.com>
3782
3783         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3784         declare VEC.
3785         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3786         std::vector.
3787         (struct s390_process_info): Add initializers.
3788         (s390_add_process): Use new.
3789         (s390_linux_nat_target::low_forget_process): Use delete.
3790         (s390_linux_nat_target::low_new_fork)
3791         (s390_linux_nat_target::stopped_by_watchpoint)
3792         (s390_linux_nat_target::low_prepare_to_resume)
3793         (s390_linux_nat_target::insert_watchpoint)
3794         (s390_linux_nat_target::insert_hw_breakpoint)
3795         (s390_linux_nat_target::remove_watchpoint)
3796         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3797
3798 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3799
3800         * aarch64-fbsd-nat.c: Include regcache.h.
3801         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3802         argument.
3803         (aarch64_fbsd_nat_target::fetch_registers)
3804         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3805         variable.
3806         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3807
3808 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3809
3810         * fbsd-nat.c: Include gdbarch.h.
3811
3812 2019-07-15  Tom Tromey  <tromey@adacore.com>
3813
3814         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3815
3816 2019-07-15  Tom Tromey  <tromey@adacore.com>
3817
3818         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3819         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3820         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3821         * cli-out.c (cli_ui_out::do_field_int): New method.
3822         * ui-out.c (ui_out::field_unsigned): New method.
3823         * symfile.c (generic_load): Use field_unsigned.
3824         (print_transfer_performance): Likewise.
3825         * record-btrace.c (ui_out_field_uint): Remove.
3826         (btrace_call_history_insn_range, btrace_call_history): Use
3827         field_unsigned.
3828         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3829         field_unsigned.
3830         * ui-out.h (class ui_out) <field_unsigned>: New method.
3831         <do_field_unsigned>: Likewise.
3832
3833 2019-07-15  Tom Tromey  <tromey@adacore.com>
3834
3835         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3836         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3837         * target.c (flash_erase_command): Use field_string.
3838         * infrun.c (print_signal_received_reason): Use field_string.
3839         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3840         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3841         field_string.
3842         * ada-tasks.c (print_ada_task_info): Use field_string.
3843
3844 2019-07-15  Tom Tromey  <tromey@adacore.com>
3845
3846         * target.c (flash_erase_command): Use field_core_addr.
3847         * symfile.c (generic_load): Use field_core_addr.
3848         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3849         Use field_core_addr.
3850         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3851         field_core_addr.
3852
3853 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3856         value if its desired type is smaller than a CORE_ADDR and signed.
3857
3858 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3861         of changes to field names, and use new is_reference field to
3862         decide if a property is a reference or not.
3863         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3864         field.
3865         (struct dwarf2_property_baton): Update header comment, rename
3866         'referenced_type' to 'property_type' and update comments.
3867         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3868         default property type, store in property baton, update to take
3869         accound of renamed field.
3870         (read_func_scope): Update call to attr_to_dynamic_prop.
3871         (read_array_type): Likewise.
3872         (dwarf2_per_cu_addr_sized_int_type): New function.
3873         (read_subrange_index_type): Move type finding code to
3874         dwarf2_per_cu_addr_sized_int_type.
3875         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3876         (dwarf2_per_cu_addr_type): New function.
3877         (set_die_type): Update calls to attr_to_dynamic_prop.
3878
3879 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3880
3881         * dwarf2read.c (read_subrange_index_type): New function.
3882         (read_subrange_type): Move code into new function and call it.
3883         * gdbtypes.c (create_range_type): Add some asserts.
3884
3885 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3888         update return statements.
3889         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3890         declaration, and update comment to match.
3891         * gdbtypes.c (resolve_dynamic_array): Update call to
3892         dwarf2_evaluate_property to match new return type.
3893
3894 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3895
3896         * valarith.c (value_subscripted_rvalue): Change lowerbound
3897         parameter type from int to LONGEST.
3898         * value.h (value_subscripted_rvalue): Likewise in declaration.
3899
3900 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3901
3902         * cli/cli-utils.c (info_print_command_completer): New function.
3903         * cli/cli-utils.h: Add 'completer.h' include, and forward
3904         declaration for 'struct cmd_list_element'.
3905         (info_print_command_completer): Declare.
3906         * stack.c (_initialize_stack): Add completer for 'info locals' and
3907         'info args'.
3908         * symtab.c (_initialize_symtab): Add completer for 'info
3909         variables' and 'info functions'.
3910         * NEWS: Mention completion for additional info commands.
3911
3912 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3913
3914         * cli/cli-utils.c (extract_info_print_args): Delete.
3915         (extract_arg_maybe_quoted): Delete.
3916         (info_print_options_defs): New variable.
3917         (make_info_print_options_def_group): New function.
3918         (extract_info_print_options): Define new function.
3919         * cli/cli-utils.h (extract_info_print_args): Delete.
3920         (struct info_print_options): New structure.
3921         (extract_info_print_options): Declare new function.
3922         * stack.c (info_locals_command): Update to use new
3923         extract_info_print_options, also add a header comment.
3924         (info_args_command): Likewise.
3925         * symtab.c (info_variables_command): Likewise.
3926         (info_functions_command): Likewise.
3927
3928 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3931         to extract string arguments.
3932         * common/common-utils.c (extract_string_maybe_quoted): New function.
3933         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3934
3935 2019-07-11  Tom Tromey  <tromey@adacore.com>
3936
3937         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3938         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3939         * top.h (gdbinit): Don't declare.
3940         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3941         into...
3942         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3943         * top.c (gdb_init): Don't call init_cli_cmds.
3944         (gdbinit): Remove.
3945         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3946
3947 2019-07-11  Tom Tromey  <tromey@adacore.com>
3948
3949         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3950         after it has been moved.
3951
3952 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3953
3954         * valops.c (value_must_coerce_to_target): Change return type to
3955         bool.
3956         * value.h (value_must_coerce_to_target): Likewise.
3957
3958 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3959
3960         * breakpoint.c (is_hardware_watchpoint): Remove
3961         forward-declaration.
3962         (is_masked_watchpoint): Change return type to bool.
3963         (is_tracepoint): Likewise.
3964         (is_breakpoint): Likewise.
3965         (is_hardware_watchpoint): Likewise.
3966         (is_watchpoint): Likewise.
3967         (is_no_memory_software_watchpoint): Likewise.
3968         (is_catchpoint): Likewise.
3969         (breakpoint_1): Make FILTER parameter's return type bool.
3970         is_masked_watchpoint): Change return type to bool.
3971         (save_breakpoints): Make FILTER parameter's return type bool.
3972         * breakpoint.h (is_breakpoint): Change return type to bool.
3973         (is_watchpoint): Likewise.
3974         (is_catchpoint): Likewise.
3975         (is_tracepoint): Likewise.
3976
3977 2019-07-10  Tom Tromey  <tom@tromey.com>
3978
3979         * defs.h: Don't include gdbarch.h.
3980         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3981         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3982         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3983         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3984         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3985         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3986         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3987         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3988         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3989         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3990         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3991         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3992         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3993         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3994         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3995         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3996         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3997         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3998         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3999         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4000         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4001         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4002         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4003         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4004         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4005         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4006         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4007
4008 2019-07-10  Tom Tromey  <tromey@adacore.com>
4009
4010         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4011         * breakpoint.c (init_ada_exception_breakpoint): Register as
4012         bp_catchpoint.
4013         (print_one_breakpoint_location, print_one_breakpoint): Use
4014         is_ada_exception_catchpoint.
4015         * ada-lang.c (class ada_catchpoint_location): Pass
4016         bp_loc_software_breakpoint to bp_location constructor.
4017         (is_ada_exception_catchpoint): New function.
4018
4019 2019-07-10  Tom Tromey  <tromey@adacore.com>
4020
4021         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4022         VEC.
4023         (struct arm_exidx_entry): New method operator<.
4024         (struct arm_exidx_data) <section_maps>: Change type.
4025         (arm_exidx_data_free): Remove.
4026         (arm_exidx_data_key): Change type.  Move lower.
4027         (arm_exidx_new_objfile): Update.
4028         (arm_compare_exidx_entries): Remove.
4029         (arm_find_exidx_entry, _initialize_arm_tdep)
4030
4031 2019-07-10  Tom Tromey  <tromey@adacore.com>
4032
4033         * solib-spu.c (ocl_program_data_key): Change type.
4034         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4035         Update.
4036
4037 2019-07-10  Tom Tromey  <tromey@adacore.com>
4038
4039         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4040         (struct solib_aix_inferior_data) <library_list>: Change type.
4041         (solib_aix_inferior_data_handle): Change type.
4042         (get_solib_aix_inferior_data): Update.
4043         (solib_aix_free_library_list): Remove.
4044         (library_list_start_library): Update.
4045         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4046         return type.
4047         (solib_aix_get_library_list)
4048         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4049         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4050
4051 2019-07-10  Tom Tromey  <tromey@adacore.com>
4052
4053         * solib-dsbt.c (struct dsbt_info): Add initializers.
4054         (solib_dsbt_pspace_data): Change type.
4055         (dsbt_pspace_data_cleanup): Remove.
4056         (get_dsbt_info, _initialize_dsbt_solib): Update.
4057
4058 2019-07-10  Tom Tromey  <tromey@adacore.com>
4059
4060         * spu-tdep.c (spu_overlay_data): Change type.
4061         (spu_get_overlay_table, spu_overlay_new_objfile)
4062         (_initialize_spu_tdep): Update.
4063
4064 2019-07-10  Tom Tromey  <tromey@adacore.com>
4065
4066         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4067         destructor.
4068         (dbx_objfile_data_key): Change type and declare later.
4069         (DBX_SYMFILE_INFO): Rewrite.
4070         * dbxread.c (dbx_objfile_data_key): Change type.
4071         (dbx_symfile_init): Update.
4072         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4073         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4074         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4075
4076 2019-07-10  Tom Tromey  <tromey@adacore.com>
4077
4078         * jit.c (jit_program_space_key): Change type.  Move lower.
4079         (get_jit_program_space_data): Update.
4080         (jit_program_space_data_cleanup): Remove.
4081         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4082         Update.
4083         (struct jit_program_space_data): Add initializers.
4084
4085 2019-07-10  Tom Tromey  <tromey@adacore.com>
4086
4087         * solib-darwin.c (struct darwin_info): Add initializers.
4088         (solib_darwin_pspace_data): Change type.
4089         (darwin_pspace_data_cleanup): Remove.
4090         (get_darwin_info, _initialize_darwin_solib): Update.
4091
4092 2019-07-10  Tom Tromey  <tromey@adacore.com>
4093
4094         * remote-sim.c (struct sim_inferior_data): Add initializers,
4095         constructor, and destructor.
4096         (sim_inferior_data_key): Change type.  Move lower.
4097         (check_for_duplicate_sim_descriptor): Update.
4098         (get_sim_inferior_data): Use new.  Update.
4099         (~sim_inferior_data_cleanup): Rename from
4100         sim_inferior_data_cleanup.  Simplify.
4101         (gdbsim_close_inferior, simulator_command)
4102         (sim_command_completer, _initialize_remote_sim): Update.
4103         (next_pid, INITIAL_PID): Move earlier.
4104
4105 2019-07-10  Tom Tromey  <tromey@adacore.com>
4106
4107         * python/python-internal.h (create_thread_object): Return
4108         gdbpy_ref.
4109         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4110         * python/py-inferior.c (struct threadlist_entry): Add
4111         constructor.
4112         <thread_obj>: Now a gdbpy_ref.
4113         (thread_to_thread_object): Update.
4114         (add_thread_object): Use new.
4115         (delete_thread_object): Use delete.
4116         (infpy_threads): Update.
4117         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4118         GIL.
4119
4120 2019-07-10  Tom Tromey  <tromey@adacore.com>
4121
4122         * valops.c (value_cast): Specialize error message for Ada.
4123
4124 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4125
4126         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4127
4128 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4129
4130         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4131         bpstat_should_step): Return bool, adjust comments.
4132         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4133         bpstat_should_step): Likewise.
4134
4135 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4136
4137         * features/Makefile: Use feature target descriptions for Arm.
4138         * features/arm/arm-core.c: Generate new file.
4139         * features/arm/arm-fpa.c: Likewise.
4140         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4141         * features/arm/arm-m-profile.c: Likewise.
4142         * features/arm/arm-vfpv2.c: Likewise.
4143         * features/arm/arm-vfpv3.c: Likewise.
4144         * features/arm/xscale-iwmmxt.c: Likewise.
4145         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4146
4147 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4148
4149         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4150         ptrace earlier.
4151
4152 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4153
4154         * features/aarch64-pauth.c: Regenerate.
4155
4156 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4157
4158         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4159         bool.
4160         (bpstat_what): Use false instead of 0.
4161
4162 2019-07-09  Pedro Alves  <palves@redhat.com>
4163
4164         * break-catch-throw.c (is_exception_catchpoint): New.
4165         * breakpoint.c (print_one_breakpoint_location): New parameter
4166         'raw_loc'.  Handle it.  Use
4167         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4168         looking at the breakpoint's type.
4169         (print_one_breakpoint): If handling "maint info breakpoints", also
4170         print locations of exception catchpoints.
4171         * breakpoint.h (is_exception_catchpoint): Declare.
4172
4173 2019-07-09  Pedro Alves  <palves@redhat.com>
4174
4175         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4176         "addr" field.
4177         (allocate_location_exception_catchpoint): New.
4178         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4179         (initialize_throw_catchpoint_ops): Install
4180         allocate_location_exception_catchpoint as allocate_location
4181         method.
4182         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4183         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4184         bp_loc_other.
4185         (breakpoint_address_is_meaningful): Delete.
4186         (bl_address_is_meaningful): New.
4187         (breakpoint_locations_match): Adjust comment.
4188         (bp_location_from_bp_type): New, factored out of...
4189         (bp_location::bp_location(breakpoint *)): ... this.
4190         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4191         factored out of...
4192         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4193         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4194         breakpoint_address_is_meaningful.
4195         (bp_locations_compare): Adjust comment.
4196         (update_global_location_list): Use bl_address_is_meaningful
4197         instead of breakpoint_address_is_meaningful.
4198         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4199         explicit.
4200         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4201         * python/py-breakpoint.c (bppy_get_location): No longer check
4202         whether location is null.
4203
4204 2019-07-09  Pedro Alves  <palves@redhat.com>
4205
4206         PR c++/15468
4207         * breakpoint.c (print_one_breakpoint_location): Remove
4208         single-location assert.
4209
4210 2019-07-09  Tom Tromey  <tom@tromey.com>
4211
4212         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4213         * configure: Rebuild.
4214         * configure.ac: Change common to gdbsupport.
4215         * gdbsupport: Rename from common.
4216         * acinclude.m4: Change common to gdbsupport.
4217         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4218         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4219         gdbsupport.
4220         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4221         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4222         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4223         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4224         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4225         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4226         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4227         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4228         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4229         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4230         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4231         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4232         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4233         coff-pe-read.c, command.h, compile/compile-c-support.c,
4234         compile/compile-c.h, compile/compile-cplus-symbols.c,
4235         compile/compile-cplus-types.c, compile/compile-cplus.h,
4236         compile/compile-loc2c.c, compile/compile.c, completer.c,
4237         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4238         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4239         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4240         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4241         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4242         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4243         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4244         features/aarch64-core.c, features/aarch64-fpu.c,
4245         features/aarch64-pauth.c, features/aarch64-sve.c,
4246         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4247         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4248         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4249         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4250         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4251         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4252         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4253         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4254         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4255         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4256         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4257         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4258         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4259         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4260         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4261         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4262         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4263         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4264         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4265         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4266         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4267         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4268         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4269         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4270         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4271         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4272         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4273         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4274         minsyms.c, mips-linux-tdep.c, namespace.h,
4275         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4276         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4277         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4278         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4279         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4280         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4281         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4282         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4283         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4284         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4285         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4286         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4287         procfs.c, producer.c, progspace.h, psymtab.h,
4288         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4289         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4290         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4291         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4292         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4293         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4294         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4295         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4296         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4297         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4298         target-memory.c, target.c, target.h, target/waitstatus.c,
4299         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4300         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4301         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4302         unittests/array-view-selftests.c,
4303         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4304         unittests/common-utils-selftests.c,
4305         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4306         unittests/format_pieces-selftests.c,
4307         unittests/function-view-selftests.c,
4308         unittests/lookup_name_info-selftests.c,
4309         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4310         unittests/mkdir-recursive-selftests.c,
4311         unittests/observable-selftests.c,
4312         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4313         unittests/parse-connection-spec-selftests.c,
4314         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4315         unittests/scoped_fd-selftests.c,
4316         unittests/scoped_mmap-selftests.c,
4317         unittests/scoped_restore-selftests.c,
4318         unittests/string_view-selftests.c, unittests/style-selftests.c,
4319         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4320         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4321         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4322         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4323         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4324         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4325
4326 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4327
4328         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4329         bool value.
4330         (decode_digits_ordinary): Set explicit_line field in sal.
4331         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4332         symtab_and_line that was set on an explicit line number in
4333         assembler code.  Do always update the recorded symtab and line if
4334         we do skip the prologue.
4335
4336 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * breakpoint.c (set_breakpoint_location_function): Remove
4339         explicit_loc parameter.
4340         (momentary_breakpoint_from_master): Update call to
4341         set_breakpoint_location_function.
4342         (add_location_to_breakpoint): Likewise.
4343
4344 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4345
4346         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4347         required features based on default bfd type when no specific bfd
4348         is present.
4349
4350 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4351
4352         * NEWS: Mention that GDB printf and eval commands can now print
4353         C-style and Ada-style convenience var strings without
4354         calling the inferior.
4355         * printcmd.c (printf_c_string): Locally print GDB internal var
4356         instead of transiting via the inferior.
4357         (printf_wide_c_string): Likewise.
4358
4359 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4360
4361         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4362
4363 2019-07-04  Tom Tromey  <tom@tromey.com>
4364
4365         PR tui/24724:
4366         * tui/tui-winsource.c (tui_clear_source_content): Update.
4367         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4368         (tui_update_breakpoint_info): Update.
4369         (tui_set_exec_info_content): Update.
4370         * tui/tui-source.c (tui_set_source_content_nil): Update.
4371         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4372         has_break.
4373         * tui/tui-data.h (enum tui_bp_flag): New.
4374         (tui_bp_flags): New enum flags type.
4375         (struct tui_source_element) <break_mode>: Change type.  Rename
4376         from has_break.
4377         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4378         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4379         constants.
4380         * tui/tui-winsource.h: Fix comment.
4381
4382 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4383
4384         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4385         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4386         (store_fpregs_to_thread)
4387         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4388         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4389         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4390         (IWMMXT_REGS_SIZE): Add define.
4391         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4392         (fetch_vfp_regs, store_vfp_regs)
4393         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4394         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4395
4396 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4397
4398         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4399         defines.
4400         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4401         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4402         (ARM_INT_REGISTER_SIZE): ...to this.
4403         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4404         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4405         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4406         (arm_linux_collect_gregset, supply_nwfpe_register)
4407         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4408         defines.
4409         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4410         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4411         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4412         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4413         (arm_return_in_memory, arm_store_return_value)
4414         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4415         (arm_record_ld_st_multiple): Likewise.
4416         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4417         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4418
4419 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4420
4421         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4422         AARCH64_DISPLACED_MODIFIED_INSNS.
4423         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4424         (aarch64_displaced_step_copy_insn): Likewise.
4425         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4426         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4427         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4428         ARM_DISPLACED_MODIFIED_INSNS.
4429         * arm-tdep.c (arm_gdbarch_init): Likewise.
4430         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4431         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4432         (struct arm_displaced_step_closure): Use
4433         ARM_DISPLACED_MODIFIED_INSNS.
4434
4435 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4436
4437         * features/Makefile: Remove unused xml files.
4438         * features/aarch64.xml: Remove.
4439         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4440         * features/i386/amd64-avx-avx512.xml: Remove.
4441         * features/i386/amd64-avx-linux.xml: Remove.
4442         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4443         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4444         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4445         * features/i386/amd64-avx-mpx.xml: Remove.
4446         * features/i386/amd64-avx.xml: Remove.
4447         * features/i386/amd64-linux.xml: Remove.
4448         * features/i386/amd64-mpx-linux.xml: Remove.
4449         * features/i386/amd64-mpx.xml: Remove.
4450         * features/i386/amd64.xml: Remove.
4451         * features/i386/i386-avx-avx512-linux.xml: Remove.
4452         * features/i386/i386-avx-avx512.xml: Remove.
4453         * features/i386/i386-avx-linux.xml: Remove.
4454         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4455         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4456         * features/i386/i386-avx-mpx-linux.xml: Remove.
4457         * features/i386/i386-avx-mpx.xml: Remove.
4458         * features/i386/i386-avx.xml: Remove.
4459         * features/i386/i386-linux.xml: Remove.
4460         * features/i386/i386-mmx-linux.xml: Remove.
4461         * features/i386/i386-mmx.xml: Remove.
4462         * features/i386/i386-mpx-linux.xml: Remove.
4463         * features/i386/i386-mpx.xml: Remove.
4464         * features/i386/i386.xml: Remove.
4465         * features/i386/x32-avx-avx512-linux.xml: Remove.
4466         * features/i386/x32-avx-linux.xml: Remove.
4467         * features/i386/x32-linux.xml: Remove.
4468
4469 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4470
4471         * regformats/aarch64.dat: Remove.
4472         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4473         * regformats/i386/amd64-avx-linux.dat: Remove.
4474         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4475         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4476         * regformats/i386/amd64-linux.dat: Remove.
4477         * regformats/i386/amd64-mpx-linux.dat: Remove.
4478         * regformats/i386/amd64.dat: Remove.
4479         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4480         * regformats/i386/i386-avx-linux.dat: Remove.
4481         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4482         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4483         * regformats/i386/i386-linux.dat: Remove.
4484         * regformats/i386/i386-mmx-linux.dat: Remove.
4485         * regformats/i386/i386-mpx-linux.dat: Remove.
4486         * regformats/i386/i386.dat: Remove.
4487         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4488         * regformats/i386/x32-avx-linux.dat: Remove.
4489         * regformats/i386/x32-linux.dat: Remove.
4490
4491 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4492
4493         * aarch64-tdep.c: Remove xml self tests.
4494         * amd64-linux-tdep.c: Likewise.
4495         * amd64-tdep.c: Likewise.
4496         * i386-linux-tdep.c: Likewise.
4497         * i386-tdep.c: Likewise.
4498
4499 2019-07-03  Pedro Alves  <palves@redhat.com>
4500
4501         PR cli/24732
4502         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4503         (pipe_cmd_option_defs): New.
4504         (make_pipe_cmd_options_def_group): New.
4505         (pipe_command): Use gdb::option::process_options.
4506         (pipe_command_completer): New function.
4507         (_initialize_cli_cmds): Install completer for "pipe" command.
4508
4509 2019-07-03  Pedro Alves  <palves@redhat.com>
4510
4511         * cli/cli-option.c (union option_value) <string>: New field.
4512         (struct option_def_and_value): Add ctor, move ctor, dtor and
4513         use DISABLE_COPY_AND_ASSIGN.
4514         (option_def_and_value::clear_value): New.
4515         (parse_option, save_option_value_in_ctx, get_val_type_str)
4516         (add_setshow_cmds_for_options): Handle var_string.
4517         * cli-option.h (union option_def::var_address) <string>: New
4518         field.
4519         (struct string_option_def): New.
4520         * maint-test-options.c (struct test_options_opts): Add default
4521         ctor and use DISABLE_COPY_AND_ASSIGN.
4522         <string_opt>: New field.
4523         (test_options_opts::~test_options_opts): New.
4524         (test_options_opts::dump): Also dump "-string".
4525         (test_options_option_defs): Install "string.
4526
4527 2019-07-03  Pedro Alves  <palves@redhat.com>
4528
4529         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4530         option_value with a null enumeration.
4531         (complete_options): Save the option values in the context.
4532         (save_option_value_in_ctx): New, factored out from ...
4533         (process_options): ... here.
4534         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4535         of the function.
4536         * maint-test-options.c (test_options_opts::dump): New, factored
4537         out from ...
4538         (maintenance_test_options_command_mode): ... here.
4539         (maintenance_test_options_command_completion_result): Delete.
4540         (maintenance_test_options_command_completion_text): Update
4541         comment.
4542         (maintenance_show_test_options_completion_result): Change
4543         prototype.  Just print
4544         maintenance_test_options_command_completion_text.
4545         (save_completion_result): New.
4546         (maintenance_test_options_completer_mode): Pass options context to
4547         complete_options, and then save a dump.
4548         (_initialize_maint_test_options): Use add_cmd to install "maint
4549         show test-options-completion-result".
4550
4551 2019-07-03  Pedro Alves  <palves@redhat.com>
4552
4553         * NEWS (New commands): Mention "with" and "maint with".
4554         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4555         (with_command, with_command_completer): New.
4556         (pipe_command): Adjust to new repeat_previous
4557         interface.
4558         (_initialize_cli_cmds): Install the "with" command and its "w"
4559         alias.
4560         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4561         declarations.
4562         * cli/cli-setshow.c (parse_cli_var_uinteger)
4563         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4564         argument strings for all var_types.
4565         (get_setshow_command_value_string): New, factored out from ...
4566         (do_show_command): ... this.
4567         * cli/cli-setshow.h: Include <string>.
4568         (get_setshow_command_value_string): Declare.
4569         * command.h (repeat_previous): Now returns const char *.  Adjust
4570         comment.
4571         * maint.c: Include "cli/cli-cmds.h".
4572         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4573         (_initialize_maint_cmds): Register the "maintenance with" command.
4574         * top.c (repeat_previous): Move bits from pipe_command here:
4575         Return the saved command line, if any; error out if there's no
4576         command to relaunch.
4577
4578 2019-07-03  Pedro Alves  <palves@redhat.com>
4579
4580         * NEWS (New commands): Mention "maint set/show test-settings"
4581         instead of "maint test-settings".
4582         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4583         (maintenance_test_settings_set_list): Rename to ...
4584         (maintenance_set_test_settings_list): ... this.
4585         (maintenance_test_settings_show_list): Rename to  ...
4586         (maintenance_show_test_settings_list): ... this.
4587         (maintenance_test_settings_cmd): Delete.
4588         (maintenance_test_settings_set_cmd): ...
4589         (maintenance_set_test_settings_cmd): ... this.
4590         (maintenance_test_settings_show_cmd): ...
4591         (maintenance_show_test_settings_cmd): ... this.
4592         (maintenance_test_settings_show_value_cmd):
4593         (maintenance_show_test_settings_value_cmd): ... this.
4594         (_initialize_maint_test_settings): No longer install the "maint
4595         test-settings" prefix command.  Rename "maint test-settings set"
4596         to "maint set test-settings", and "maint test-settings show" to
4597         "maint show test-settings".  Adjust all subcommands.
4598
4599 2019-07-03  Pedro Alves  <palves@redhat.com>
4600
4601         * maint-test-settings.c: Fix file's intro comment.  Replace all
4602         references to "test-options" with references to "test-settings",
4603         in comments.
4604
4605 2019-07-03  Pedro Alves  <palves@redhat.com>
4606
4607         * maint-test-settings.c (maintenance_test_settings_xxx)
4608         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4609         New.
4610         (maintenance_test_settings_enums): Use them.
4611         (maintenance_test_settings_enum): Default to
4612         maintenance_test_settings_xxx.
4613         (_initialize_maint_test_settings): Initialize
4614         MAINTENANCE_TEST_SETTINGS_FILENAME.
4615
4616 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4617
4618         * breakpoint.h (remove_breakpoints_inf): Change return type to
4619         void, move function documentation here.
4620         * breakpoint.c (remove_breakpoints_inf): Change return type to
4621         void, move function documentation to header.
4622
4623 2019-07-02  Pedro Alves  <palves@redhat.com>
4624
4625         * NEWS (Completion improvements): Mention "info threads".
4626         * thread.c (struct info_threads_opts, info_threads_option_defs)
4627         (make_info_threads_options_def_group): New.
4628         (info_threads_command): Use gdb::option::process_options.
4629         (info_threads_command_completer): New.
4630         (_initialize_thread): Use gdb::option::build_help to build the
4631         help text for "info threads".
4632
4633 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4634
4635         * defs.h (generic_load): Move from here...
4636         * symfile.h (generic_load): ... to here.  Rename name parameter
4637         to args.
4638         * symfile.c (generic_load): Add comment.
4639
4640 2019-07-01  Tom Tromey  <tromey@adacore.com>
4641
4642         * dwarf2read.c
4643         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4644         declaration of without_params.  Fix formatting.
4645
4646 2019-07-01  Tom Tromey  <tromey@adacore.com>
4647
4648         * ada-exp.y (find_primitive_type): Update.
4649         * ada-lang.h (ada_lookup_symbol): Update.
4650         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4651         parameter.
4652         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4653
4654 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4655
4656         PR breakpoints/24541
4657         * gdbarch.c: Regenerate.
4658         * gdbarch.h: Regenerate.
4659         * gdbarch.sh: Add 'stap_adjust_register'.
4660         * i386-tdep.c: Include '<unordered_set>'.
4661         (i386_stap_adjust_register): New function.
4662         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4663         * stap-probe.c (stap_parse_register_operand): Call
4664         'gdbarch_stap_adjust_register'.
4665
4666 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4667
4668         PR python/24742
4669         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4670         * python/python.c (do_start_initialization): Use 'xmalloc'
4671         instead of 'PyMem_Malloc'.
4672
4673 2019-06-28  Tom Tromey  <tromey@adacore.com>
4674
4675         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4676         for Ada.
4677
4678 2019-06-27  Tom Tromey  <tromey@adacore.com>
4679
4680         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4681         objfile_key.
4682         (arm_find_mapping_symbol, arm_record_special_symbol)
4683         (_initialize_arm_tdep): Update.
4684         (arm_objfile_data_free): Remove.
4685
4686 2019-06-27  Tom Tromey  <tromey@adacore.com>
4687
4688         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4689         to cp_print_static_field.
4690
4691 2019-06-26  Tom Tromey  <tromey@adacore.com>
4692
4693         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4694         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4695         declare.
4696
4697 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4698
4699         * features/aarch64-core.c (create_feature_aarch64_core):
4700         Regenerate.
4701         * features/aarch64-core.xml: Add cpsr flags.
4702
4703 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4704
4705         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4706         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4707
4708 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4709
4710         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4711         field.
4712         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4713         use.
4714         (arm_record_special_symbol): Don't insert new symbol in sorted
4715         position, push it at the end.
4716
4717 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4718
4719         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4720         (arm_mapping_symbol_s): Remove.
4721         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4722         (arm_mapping_symbol_vec): New typedef.
4723         (struct arm_per_objfile): Add constructor.
4724         <section_maps>: Change type to
4725         std::unique_ptr<arm_mapping_symbol_vec[]>.
4726         (arm_compare_mapping_symbols): Remove.
4727         (arm_find_mapping_symbol): Adjust to section_maps type change.
4728         (arm_objfile_data_free): Call delete on arm_per_objfile.
4729         (arm_record_special_symbol): Adjust to section_maps type change.
4730         Allocate arm_per_objfile with new.
4731
4732 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4733
4734         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4735         with the command prefix.
4736
4737 2019-06-25  Tom Tromey  <tom@tromey.com>
4738
4739         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4740         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4741
4742 2019-06-25  Tom Tromey  <tom@tromey.com>
4743
4744         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4745         type.
4746         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4747         protected.
4748
4749 2019-06-25  Tom Tromey  <tom@tromey.com>
4750
4751         * tui/tui-winsource.c
4752         (tui_source_window_base::set_is_exec_point_at): Add check against
4753         LOA_ADDRESS.
4754
4755 2019-06-25  Tom Tromey  <tom@tromey.com>
4756
4757         * tui/tui-source.c (tui_set_source_content): Don't check before
4758         xfree.
4759         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4760
4761 2019-06-25  Tom Tromey  <tom@tromey.com>
4762
4763         * tui/tui-winsource.h (tui_update_source_window_as_is)
4764         (tui_alloc_source_buffer, tui_line_is_displayed)
4765         (tui_addr_is_displayed): Change type of win_info.
4766         * tui/tui-winsource.c (tui_update_source_window_as_is)
4767         (tui_clear_source_content, tui_show_source_line)
4768         (tui_show_source_content, tui_source_window_base::refill)
4769         (tui_source_window_base::set_is_exec_point_at)
4770         (tui_source_window_base::set_is_exec_point_at)
4771         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4772         (tui_alloc_source_buffer, tui_line_is_displayed)
4773         (tui_addr_is_displayed): Change type of win_info.  Update.
4774         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4775         (tui_source_window_base::do_make_visible_with_new_height):
4776         Update.
4777         * tui/tui-source.c (tui_set_source_content)
4778         (tui_set_source_content_nil)
4779         (tui_source_window::do_scroll_vertical): Update.
4780         * tui/tui-layout.c (show_layout): Update.
4781         * tui/tui-disasm.c (tui_set_disassem_content)
4782         (tui_disasm_window::do_scroll_vertical): Update.
4783         * tui/tui-data.h (tui_win_content): Remove.
4784         (struct tui_gen_win_info) <content, content_size>: Remove.
4785         (struct tui_source_element): Add initializers and destructor.
4786         (union tui_which_element, struct tui_win_element): Remove.
4787         (struct tui_source_window_base) <content>: New field.
4788         (struct tui_data_window): Remove destructor.
4789         (tui_alloc_content, tui_free_win_content)
4790         (tui_free_all_source_wins_content): Don't declare.
4791         * tui/tui-data.c (tui_initialize_static_data): Update.
4792         (init_content_element, tui_alloc_content): Remove.
4793         (~tui_gen_win_info): Update.
4794         (~tui_data_window, tui_free_all_source_wins_content)
4795         (tui_free_win_content, free_content, free_content_elements):
4796         Remove.
4797
4798 2019-06-25  Tom Tromey  <tom@tromey.com>
4799
4800         * tui/tui-winsource.h (tui_clear_source_content)
4801         (tui_erase_source_content, tui_show_source_content): Change type
4802         of win_info.
4803         * tui/tui-winsource.c (tui_clear_source_content)
4804         (tui_erase_source_content, tui_show_source_content): Change type
4805         of win_info.
4806         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4807         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4808         win_info.
4809         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4810         win_info.
4811         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4812
4813 2019-06-25  Tom Tromey  <tom@tromey.com>
4814
4815         * tui/tui-winsource.c (tui_clear_source_content)
4816         (tui_source_window_base::set_is_exec_point_at): Update.
4817         * tui/tui-source.c (tui_set_source_content_nil): Update.
4818         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4819         a bool.
4820         * tui/tui-data.c (init_content_element): Update.
4821
4822 2019-06-25  Tom Tromey  <tom@tromey.com>
4823
4824         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4825         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4826         * tui/tui-layout.c (init_and_make_win): Update.
4827         * tui/tui.h (enum tui_win_type): Update.
4828         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4829         tui_win_is_auxillary.
4830         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4831         tui_win_is_auxillary.
4832
4833 2019-06-25  Tom Tromey  <tom@tromey.com>
4834
4835         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4836         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4837         (tui_delete_data_content_windows, tui_display_all_data)
4838         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4839         Update.
4840         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4841         * tui/tui-regs.c (tui_last_regs_line_no)
4842         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4843         (tui_show_registers): Update.
4844         (tui_show_register_group): Return void.  Update.
4845         (tui_display_registers_from, tui_display_reg_element_at_line)
4846         (tui_display_registers_from_line, tui_check_register_values):
4847         Update.
4848         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4849         member.
4850         (struct tui_data_window) <regs_content>: Now a std::vector.
4851         <regs_content_count>: Remove.
4852         (tui_add_content_elements, tui_free_data_content): Don't declare.
4853         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4854         (init_content_element): Remove DATA_WIN case.  Add assert.
4855         (tui_add_content_elements): Remove.
4856         (tui_data_window): Update.
4857         (tui_free_data_content): Remove.
4858         (free_content_elements): Remove DATA_WIN case.
4859
4860 2019-06-25  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-data.c (tui_data_item_window): Update.
4863         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4864         * tui/tui-windata.c (tui_display_all_data)
4865         (tui_display_data_from_line): Update.
4866         (tui_check_data_values): Remove.
4867         * tui/tui-regs.c (tui_show_register_group)
4868         (tui_display_reg_element_at_line): Update.
4869         * tui/tui-hooks.c (tui_register_changed)
4870         (tui_refresh_frame_and_register_information): Call
4871         tui_check_register_values.
4872         * tui/tui-data.h (struct tui_data_window) <data_content,
4873         data_content_count, data_type>: Remove.
4874         (enum tui_data_type): Remove.
4875
4876         * tui/tui-data.c (tui_data_window::clear_detail)
4877         (~tui_data_window): Update.
4878
4879 2019-06-25  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4882         declare.
4883         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4884         Rename from tui_first_data_item_displayed.  Update.
4885         (tui_data_window::refresh_all)
4886         (tui_data_window::do_scroll_vertical): Update.
4887         * tui/tui-data.h (struct tui_data_window)
4888         <first_data_item_displayed>: Declare new method.
4889
4890 2019-06-25  Tom Tromey  <tom@tromey.com>
4891
4892         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4893         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4894         contents...
4895         (tui_initialize_static_data): ...here.
4896
4897 2019-06-25  Tom Tromey  <tom@tromey.com>
4898
4899         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4900         (tui_display_registers_from, tui_check_register_values): Update.
4901         (tui_display_register): Remove win_info parameter; update.
4902         (tui_get_register): Change type of parameters.
4903         * tui/tui-data.h (struct tui_data_element): Remove.
4904         (union tui_which_element) <data>: Remove.
4905         <data_window>: Change type.
4906         (struct tui_data_item_window): New.
4907         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4908         case.  Add assert.
4909         (~tui_data_item_window): New destructor.
4910         (free_content_elements): Remove DATA_ITEM_WIN case.
4911
4912 2019-06-25  Tom Tromey  <tom@tromey.com>
4913
4914         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4915         Remove.
4916
4917 2019-06-25  Tom Tromey  <tom@tromey.com>
4918
4919         * tui/tui-data.h (struct tui_command_element): Remove.
4920         (union tui_which_element) <command>: Remove.
4921         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4922         assert.
4923         (free_content_elements): Remove CMD_WIN case.
4924
4925 2019-06-25  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui-layout.c (tui_set_layout): Update.
4928         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4929         * tui/tui-data.c (layout_def): Update.
4930
4931 2019-06-25  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4934         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4935         (tui_source_window_base::set_new_height): Update.
4936         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4937         Update.
4938         (tui_set_locator_fullname, tui_set_locator_info)
4939         (tui_show_frame_info): Update.
4940         * tui/tui-source.c (tui_set_source_content)
4941         (tui_source_is_displayed): Update.
4942         * tui/tui-layout.c (show_source_disasm_command, show_data)
4943         (show_source_or_disasm_and_command): Update.
4944         * tui/tui-disasm.c (tui_set_disassem_content)
4945         (tui_get_begin_asm_address): Update.
4946         * tui/tui-data.h (struct tui_locator_element): Remove.
4947         (union tui_which_element) <locator>: Remove.
4948         (struct tui_locator_window): New.
4949         (tui_locator_win_info_ptr): Change return type.
4950         * tui/tui-data.c (_locator): Change type.
4951         (tui_locator_win_info_ptr): Change return type.
4952         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4953         (tui_alloc_content): Add assert.
4954
4955 2019-06-25  Tom Tromey  <tom@tromey.com>
4956
4957         * tui/tui-winsource.c
4958         (tui_exec_info_window::maybe_allocate_content): New method.
4959         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4960         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4961         (make_source_or_disasm_window): Add cast.
4962         * tui/tui-data.h (union tui_which_element) <simple_string>:
4963         Remove.
4964         (struct tui_source_info): New.
4965         (struct tui_source_window_base) <execution_info>: Change type.
4966         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4967         case, and add assert.
4968         (tui_alloc_content): Add assert.
4969
4970 2019-06-25  Tom Tromey  <tom@tromey.com>
4971
4972         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4973         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4974         * tui/tui-data.c (tui_alloc_win_info): Remove.
4975
4976 2019-06-25  Tom Tromey  <tom@tromey.com>
4977
4978         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4979         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4980         can_highlight.
4981
4982 2019-06-25  Tom Tromey  <tom@tromey.com>
4983
4984         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4985         make_visible_with_new_height method.
4986         (tui_win_info::make_visible_with_new_height): New method.
4987         (tui_source_window_base::do_make_visible_with_new_height)
4988         (tui_data_window::do_make_visible_with_new_height)
4989         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4990         (make_visible_with_new_height): Remove.
4991         (tui_resize_all, tui_adjust_win_heights): Use
4992         make_visible_with_new_height method.
4993         * tui/tui-data.h (struct tui_win_info)
4994         <do_make_visible_with_new_height, make_visible_with_new_height>:
4995         New methods.
4996         (struct tui_source_window_base, struct tui_data_window)
4997         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4998         methods.
4999
5000 2019-06-25  Tom Tromey  <tom@tromey.com>
5001
5002         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5003         method.
5004         (update_tab_width): Call update_tab_width method.
5005         * tui/tui-data.h (struct tui_win_info)
5006         (struct tui_source_window_base) <update_tab_width>: New methods.
5007
5008 2019-06-25  Tom Tromey  <tom@tromey.com>
5009
5010         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5011         parameter.
5012         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5013         parameter.
5014         (tui_gen_win_info::make_visible): Update.
5015         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5016         parameter.
5017         * tui/tui-data.h (enum tui_box): New enum.
5018         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5019
5020 2019-06-25  Tom Tromey  <tom@tromey.com>
5021
5022         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5023         init_and_make_win for EXEC_INFO_WIN.
5024         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5025         longer inline.
5026         (struct tui_win_info) <~tui_win_info>: Inline.
5027         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5028         Don't declare.
5029         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5030         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5031         Remove.
5032         (tui_initialize_static_data): Update.
5033         (~tui_gen_win_info): Handle more cleanup here.
5034         (~tui_source_window_base): Delete "execution_info".
5035         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5036
5037 2019-06-25  Tom Tromey  <tom@tromey.com>
5038
5039         * tui/tui-layout.c (make_command_window): Don't set
5040         can_highlight.
5041         (show_source_disasm_command): Call the reset method.
5042         (show_data): Don't set can_highlight.  Call the reset method.
5043         (tui_gen_win_info::reset): Rename from init_gen_win_info
5044         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5045         (show_source_or_disasm_and_command): Call the reset method.
5046         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5047         (struct tui_cmd_window): Set can_highlight.
5048
5049 2019-06-25  Tom Tromey  <tom@tromey.com>
5050
5051         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5052         from make_visible.
5053         (tui_make_visible, tui_make_invisible): Rewrite.
5054         (tui_win_info::make_visible): Remove.
5055         (tui_source_window_base::make_visible): Update.
5056         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5057         method.  Moved from...
5058         (struct tui_win_info) <make_visible>: ...here.
5059
5060 2019-06-25  Tom Tromey  <tom@tromey.com>
5061
5062         * tui/tui-winsource.c
5063         (tui_source_window_base::do_scroll_horizontal): Remove direction
5064         parameter.
5065         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5066         direction parameter.
5067         * tui/tui-win.c (tui_win_info::forward_scroll)
5068         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5069         (tui_win_info::right_scroll): Update.
5070         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5071         direction parameter.
5072         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5073         direction parameter.
5074         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5075         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5076         Remove direction parameter.
5077         (struct tui_source_window_base, struct tui_source_window)
5078         (struct tui_disasm_window, struct tui_data_window)
5079         (struct tui_cmd_window): Update.
5080
5081 2019-06-25  Tom Tromey  <tom@tromey.com>
5082
5083         * tui/tui-winsource.h (tui_set_exec_info_content)
5084         (tui_show_exec_info_content, tui_erase_exec_info_content)
5085         (tui_clear_exec_info_content, tui_update_exec_info): Change
5086         argument to tui_source_window_base.
5087         * tui/tui-winsource.c (tui_set_exec_info_content)
5088         (tui_show_exec_info_content, tui_erase_exec_info_content)
5089         (tui_clear_exec_info_content, tui_update_exec_info): Change
5090         argument to tui_source_window_base.
5091
5092 2019-06-25  Tom Tromey  <tom@tromey.com>
5093
5094         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5095         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5096
5097 2019-06-25  Tom Tromey  <tom@tromey.com>
5098
5099         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5100         check.
5101
5102 2019-06-25  Tom Tromey  <tom@tromey.com>
5103
5104         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5105         type to void.
5106         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5107         type to void.
5108         * tui/tui-source.c (tui_set_source_content): Update.
5109         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5110
5111 2019-06-25  Tom Tromey  <tom@tromey.com>
5112
5113         * tui/tui-win.c (window_name_completer, tui_set_focus)
5114         (tui_all_windows_info): Use name method.
5115         * tui/tui-data.h (struct tui_gen_win_info)
5116         (struct tui_source_window, struct tui_disasm_window)
5117         (struct tui_data_window, struct tui_cmd_window) <name>: New
5118         method.
5119         (tui_win_name): Don't declare.
5120         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5121         (tui_win_name): Remove.
5122
5123 2019-06-25  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-winsource.h (tui_update_source_window)
5126         (tui_update_source_window_as_is): Change parameter type.
5127         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5128         to be a tui_source_window_base.
5129         (tui_update_source_window_as_is): Likewise.
5130         * tui/tui-win.c (make_visible_with_new_height): Update.
5131
5132 2019-06-25  Tom Tromey  <tom@tromey.com>
5133
5134         * tui/tui-winsource.c (tui_erase_source_content)
5135         (tui_show_source_content, tui_show_exec_info_content)
5136         (tui_erase_exec_info_content): Use refresh_window method.
5137         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5138         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5139         from tui_refresh_win.
5140         (tui_data_window::refresh_window): New method.
5141         (tui_win_info::refresh, tui_source_window_base::refresh)
5142         (tui_refresh_all): Use refresh_window method.
5143         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5144         method.
5145         * tui/tui-regs.c (tui_display_register): Call refresh_window
5146         method.
5147         * tui/tui-layout.c (show_source_disasm_command)
5148         (show_source_or_disasm_and_command): Call refresh_window method.
5149         * tui/tui-data.h (struct tui_gen_win_info)
5150         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5151         New method.
5152
5153 2019-06-25  Tom Tromey  <tom@tromey.com>
5154
5155         * tui/tui.c (tui_rl_other_window, tui_enable)
5156         (tui_is_window_visible, tui_get_command_dimension): Update.
5157         * tui/tui-winsource.c (tui_update_source_window_as_is)
5158         (tui_clear_source_content, tui_erase_source_content)
5159         (tui_show_source_line, tui_source_window_base::refill)
5160         (tui_source_window_base::do_scroll_horizontal)
5161         (tui_source_window_base::set_is_exec_point_at)
5162         (tui_update_breakpoint_info, tui_set_exec_info_content)
5163         (tui_alloc_source_buffer, tui_line_is_displayed)
5164         (tui_addr_is_displayed): Update.
5165         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5166         (tui_check_and_display_highlight_if_needed)
5167         (tui_win_info::make_visible, tui_win_info::refresh)
5168         (tui_refresh_all): Update.
5169         * tui/tui-windata.c (tui_first_data_item_displayed)
5170         (tui_delete_data_content_windows, tui_erase_data_content)
5171         (tui_display_all_data, tui_data_window::refresh_all)
5172         (tui_check_data_values): Update.
5173         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5174         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5175         (tui_win_info::backward_scroll, tui_refresh_all_win)
5176         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5177         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5178         (tui_source_window_base::set_new_height)
5179         (tui_data_window::set_new_height)
5180         (make_invisible_and_set_new_height)
5181         (make_visible_with_new_height, new_height_ok)
5182         (parse_scrolling_args): Update.
5183         * tui/tui-stack.c (tui_show_frame_info): Update.
5184         * tui/tui-source.c (tui_set_source_content)
5185         (tui_set_source_content_nil, tui_source_is_displayed)
5186         (tui_source_window::do_scroll_vertical): Update.
5187         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5188         (tui_display_registers_from, tui_display_reg_element_at_line)
5189         (tui_check_register_values, tui_reg_command): Update.
5190         * tui/tui-layout.c (tui_default_win_height)
5191         (show_source_disasm_command, show_data, init_and_make_win)
5192         (show_source_or_disasm_and_command): Update.
5193         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5194         (tui_redisplay_readline, tui_mld_flush)
5195         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5196         (tui_getc): Update.
5197         * tui/tui-disasm.c (tui_set_disassem_content)
5198         (tui_disasm_window::do_scroll_vertical): Update.
5199         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5200         Now virtual.
5201         (struct tui_win_info): Derive from tui_gen_win_info.
5202         <~tui_win_info>: Mark as override.
5203         <generic>: Remove member.
5204         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5205         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5206         (~tui_data_window, ~tui_win_info)
5207         (tui_free_all_source_wins_content): Update.
5208         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5209
5210 2019-06-25  Tom Tromey  <tom@tromey.com>
5211
5212         * tui/tui-layout.c (init_and_make_win): Use new.
5213         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5214         destructor, initializers.
5215         (tui_alloc_generic_win_info): Don't declare.
5216         * tui/tui-data.c (_locator): Add argument to constructor.
5217         (source_win, disasm_win): New globals.
5218         (exec_info): Remove.
5219         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5220         Update.
5221         (tui_alloc_generic_win_info): Remove.
5222         (init_content_element): Use new.
5223         (tui_win_info::tui_win_info): Update.
5224         (free_content_elements) <case DATA_WIN>: Use delete.
5225
5226 2019-06-25  Tom Tromey  <tom@tromey.com>
5227
5228         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5229         * tui/tui-windata.c (tui_first_data_item_displayed)
5230         (tui_delete_data_content_windows): Update.
5231         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5232         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5233         (tui_display_registers_from, tui_check_register_values): Update.
5234         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5235         pointer.
5236         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5237         window.
5238         (tui_free_data_content): Update.
5239         (free_content_elements) <case DATA_WIN>: Free the window.
5240
5241 2019-06-25  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5244         Update.
5245         * tui/tui-layout.c (make_command_window)
5246         (show_source_disasm_command, show_data, init_and_make_win)
5247         (show_source_or_disasm_and_command): Update.
5248         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5249         method.
5250         <can_highight, is_highlighted>: Now bool.
5251         (tui_set_win_highlight): Don't declare.
5252         * tui/tui-data.c (tui_set_win_highlight): Remove.
5253
5254 2019-06-25  Tom Tromey  <tom@tromey.com>
5255
5256         * tui/tui-wingeneral.c (make_visible): Remove check of window
5257         type.
5258
5259 2019-06-25  Tom Tromey  <tom@tromey.com>
5260
5261         * tui/tui-win.c (tui_win_info::max_height)
5262         (tui_cmd_window::max_height): New methods.
5263         (new_height_ok): Call max_height.
5264         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5265         <max_height>: New method.
5266
5267 2019-06-25  Tom Tromey  <tom@tromey.com>
5268
5269         * tui/tui-win.c (tui_source_window_base::set_new_height)
5270         (tui_data_window::set_new_height): New methods.
5271         (make_invisible_and_set_new_height): Call set_new_height method.
5272         * tui/tui-data.h (struct tui_win_info)
5273         (struct tui_source_window_base, struct tui_data_window)
5274         <set_new_height>: New method.
5275
5276 2019-06-25  Tom Tromey  <tom@tromey.com>
5277
5278         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5279         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5280         tui_refresh_data_win.
5281         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5282         method.
5283         (tui_refresh_all_win): Call the refresh_all method.
5284         (tui_set_focus): Likewise.
5285         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5286         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5287         Likewise.
5288
5289 2019-06-25  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-winsource.h (tui_refill_source_window)
5292         (tui_set_is_exec_point_at): Don't declare.
5293         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5294         (tui_source_window_base::refill): Rename from
5295         tui_refill_source_window.
5296         (tui_source_window_base::do_scroll_horizontal): Update.
5297         (tui_source_window_base::set_is_exec_point_at): Rename from
5298         tui_set_is_exec_point_at.
5299         (tui_update_all_breakpoint_info): Update.
5300         * tui/tui-stack.c (tui_show_frame_info): Update.
5301         * tui/tui-layout.c (show_data): Add cast.
5302         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5303         * tui/tui-data.h (struct tui_source_window_base) <refill,
5304         set_is_exec_point_at>: New methods.
5305         (tui_source_windows, tui_add_to_source_windows): Update types.
5306         (tui_add_to_source_windows): Remove redundant declaration.
5307         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5308         (tui_source_windows): Change return type.
5309         (tui_clear_source_windows_detail): Update.
5310         (tui_add_to_source_windows): Change type of parameter.
5311         (tui_free_all_source_wins_content): Update.
5312
5313 2019-06-25  Tom Tromey  <tom@tromey.com>
5314
5315         * tui/tui-wingeneral.c (tui_win_info::refresh)
5316         (tui_source_window_base::refresh): New methods.
5317         (tui_refresh_all): Call the refresh method.
5318         * tui/tui-data.h (struct tui_win_info)
5319         (struct tui_source_window_base) <refresh>: New method.
5320
5321 2019-06-25  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui.h (tui_is_window_visible): Return bool.
5324         * tui/tui.c (tui_is_window_visible): Return bool.
5325         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5326         (tui_make_visible, tui_make_invisible)
5327         (tui_win_info::make_visible)
5328         (tui_source_window_base::make_visible, make_all_visible)
5329         (tui_make_all_visible, tui_make_all_invisible): Update.
5330         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5331         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5332         bool.
5333         (struct tui_win_info, struct tui_source_window_base)
5334         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5335         * tui/tui-data.c (tui_init_generic_part): Update.
5336
5337 2019-06-25  Tom Tromey  <tom@tromey.com>
5338
5339         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5340         (tui_source_window_base::make_visible): New methods.
5341         (make_all_visible): Make method call.
5342         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5343         (struct tui_source_window_base, struct tui_cmd_window): Override
5344         make_visible.
5345         (tui_win_is_source_type): Don't declare.
5346         * tui/tui-data.c (tui_win_is_source_type): Remove.
5347
5348 2019-06-25  Tom Tromey  <tom@tromey.com>
5349
5350         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5351         NULL check.
5352
5353 2019-06-25  Tom Tromey  <tom@tromey.com>
5354
5355         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5356         Inline constructor.  Add initializers for members.
5357         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5358         constructors; now inline in class.
5359
5360 2019-06-25  Tom Tromey  <tom@tromey.com>
5361
5362         * tui/tui-regs.c (tui_show_registers): Update.
5363         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5364         bool.
5365         * tui/tui-data.c (tui_data_window::clear_detail)
5366         (tui_data_window): Update.
5367
5368 2019-06-25  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui-windata.c (tui_display_all_data)
5371         (tui_display_data_from_line, tui_display_data_from)
5372         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5373         Update.
5374         * tui/tui-regs.c (tui_last_regs_line_no)
5375         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5376         (tui_show_registers, tui_show_register_group)
5377         (tui_display_registers_from, tui_display_reg_element_at_line)
5378         (tui_display_registers_from_line, tui_check_register_values)
5379         (tui_reg_next, tui_reg_prev): Update.
5380         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5381         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5382         tui_data_window.
5383         (struct tui_win_info) <detail>: Remove.  Add new fields from
5384         tui_data_info.
5385         (TUI_DATA_WIN): Add cast.
5386         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5387         (~tui_data_window): Simplify.
5388
5389 2019-06-25  Tom Tromey  <tom@tromey.com>
5390
5391         * tui/tui-layout.c (show_source_disasm_command)
5392         (show_source_or_disasm_and_command): Update.
5393         * tui/tui-io.c (update_cmdwin_start_line)
5394         (tui_redisplay_readline): Update.
5395         * tui/tui-data.h (struct tui_command_info): Remove.
5396         (struct tui_win_info) <detail>: Remove command_info member.
5397         (struct tui_data_window) <start_line>: New member, from
5398         tui_command_info.
5399         (TUI_CMD_WIN): Add casts.
5400
5401 2019-06-25  Tom Tromey  <tom@tromey.com>
5402
5403         * tui/tui-winsource.c (tui_update_source_window)
5404         (tui_refill_source_window)
5405         (tui_source_window_base::do_scroll_horizontal)
5406         (tui_update_breakpoint_info, tui_set_exec_info_content)
5407         (tui_show_exec_info_content, tui_erase_exec_info_content)
5408         (tui_clear_exec_info_content): Update.
5409         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5410         Update.
5411         * tui/tui-win.c (make_invisible_and_set_new_height)
5412         (make_visible_with_new_height): Update.
5413         * tui/tui-source.c (tui_set_source_content)
5414         (tui_show_symtab_source): Update.
5415         * tui/tui-layout.c (extract_display_start_addr)
5416         (show_source_disasm_command, show_data)
5417         (make_source_or_disasm_window)
5418         (show_source_or_disasm_and_command): Update.
5419         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5420         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5421         "gdbarch".
5422         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5423         to tui_source_window_base.
5424         (struct tui_win_info) <detail>: Remove source_info member.
5425         (struct tui_source_window_base) <has_locator>: Inline.
5426         Move contents from tui_source_info; rename has_locator member to
5427         m_has_locator.
5428         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5429         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5430         header file.
5431         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5432         Simplify.
5433         (tui_free_all_source_wins_content): Cast to
5434         tui_source_window_base.
5435
5436 2019-06-25  Tom Tromey  <tom@tromey.com>
5437
5438         * tui/tui-win.c (make_invisible_and_set_new_height)
5439         (make_visible_with_new_height): Call has_locator method.
5440         * tui/tui-layout.c (show_source_disasm_command, show_data)
5441         (show_source_or_disasm_and_command): Update for bool change.
5442         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5443         (tui_win_info) <has_locator>: New method.
5444         (struct tui_source_window_base) <has_locator>: New method.
5445         (tui_win_has_locator): Don't declare.
5446         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5447         from tui_win_has_locator.
5448         (tui_source_window_base): Use false, not FALSE.
5449
5450 2019-06-25  Tom Tromey  <tom@tromey.com>
5451
5452         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5453         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5454         clear_detail method directly.
5455         (tui_clear_win_detail): Remove.
5456
5457 2019-06-25  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5460         "this", not TUI_DISASM_WIN.
5461
5462 2019-06-25  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5465         declare.
5466         * tui/tui-winsource.c
5467         (tui_source_window_base::do_scroll_horizontal): Rename from
5468         tui_horizontal_source_scroll.
5469         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5470         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5471         from tui_vertical_data_scroll.
5472         * tui/tui-win.h (tui_scroll): Don't declare.
5473         * tui/tui-win.c (tui_win_info::forward_scroll)
5474         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5475         (tui_win_info::right_scroll): Rename and update.
5476         (tui_scroll_forward_command, tui_scroll_backward_command)
5477         (tui_scroll_left_command, tui_scroll_right_command): Update.
5478         (tui_scroll): Remove.
5479         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5480         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5481         from tui_vertical_source_scroll.
5482         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5483         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5484         from tui_vertical_disassem_scroll.
5485         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5486         do_scroll_horizontal>: New methods.
5487         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5488         Likewise.
5489         (struct tui_source_window_base): Add do_scroll_horizontal.
5490         (struct tui_source_window, struct tui_disasm_window): Add
5491         do_scroll_vertical.
5492         (struct tui_data_window, struct tui_cmd_window): Add
5493         do_scroll_horizontal and do_scroll_vertical.
5494         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5495
5496 2019-06-25  Tom Tromey  <tom@tromey.com>
5497
5498         * tui/tui-data.h (struct tui_source_window_base): New struct.
5499         (struct tui_source_window): Derive from tui_source_window_base.
5500         (struct tui_disasm_window): New struct.
5501         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5502         from tui_source_window::clear_detail.
5503         (tui_source_window_base): Rename from tui_source_window.
5504         (~tui_source_window_base): Rename from ~tui_source_window.
5505         (tui_alloc_win_info): Create a tui_disasm_window.
5506
5507 2019-06-25  Tom Tromey  <tom@tromey.com>
5508
5509         * tui/tui-data.h (struct tui_source_window)
5510         (struct tui_data_window): Declare destructors.
5511         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5512         destructors.
5513         (tui_win_info): Simplify.
5514
5515 2019-06-25  Tom Tromey  <tom@tromey.com>
5516
5517         * tui/tui-winsource.c (tui_display_main)
5518         (tui_update_source_windows_with_addr)
5519         (tui_update_all_breakpoint_info): Update.
5520         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5521         (new_height_ok, parse_scrolling_args): Update.
5522         * tui/tui-stack.c (tui_show_frame_info): Update.
5523         * tui/tui-data.h (struct tui_list): Remove.
5524         (tui_source_windows): Return a reference to a std::vector.
5525         * tui/tui-data.c (source_windows): Now a std::vector.
5526         (tui_source_windows): Change return type.
5527         (tui_clear_source_windows): Rewrite.
5528         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5529         (tui_free_all_source_wins_content): Rewrite.
5530
5531 2019-06-25  Tom Tromey  <tom@tromey.com>
5532
5533         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5534         (struct tui_data_window, struct tui_cmd_window): Declare
5535         clear_detail method.
5536         * tui/tui-data.c (tui_source_window::clear_detail)
5537         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5538         methods.
5539         (tui_clear_win_detail): Simplify.
5540
5541 2019-06-25  Tom Tromey  <tom@tromey.com>
5542
5543         * tui/tui-layout.c (make_source_window, make_disasm_window)
5544         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5545         Return the new window.
5546         (show_source_disasm_command, show_data)
5547         (show_source_or_disasm_and_command): Update.
5548
5549 2019-06-25  Tom Tromey  <tom@tromey.com>
5550
5551         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5552         parameter.  Return the new window.
5553         (show_source_disasm_command): Update and remove NULL check.
5554         (show_source_or_disasm_and_command): Update.
5555
5556 2019-06-25  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5559
5560 2019-06-25  Tom Tromey  <tom@tromey.com>
5561
5562         * tui/tui-data.h (struct tui_win_info): Make constructor
5563         protected.  Make destructor virtual.  Add initializers.
5564         (tui_source_window, tui_data_window, tui_cmd_window): New
5565         classes.
5566         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5567         constructor.  Add "type" parameter.
5568         (tui_source_window, tui_data_window, tui_cmd_window): New
5569         constructors.
5570         (tui_alloc_win_info): Instantiate the appropriate subclass.
5571
5572 2019-06-25  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-win.c (tui_resize_all): Use delete.
5575         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5576         destructor.
5577         (tui_free_window): Don't declare.
5578         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5579         Update.
5580
5581 2019-06-25  Tom Tromey  <tom@tromey.com>
5582
5583         * tui/tui-data.h (struct tui_win_info): Add constructor.
5584         * tui/tui-data.c (tui_alloc_win_info): Use new.
5585         (tui_free_window): Use delete.
5586
5587 2019-06-22  Tom Tromey  <tom@tromey.com>
5588
5589         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5590         declare.
5591         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5592
5593 2019-06-22  Tom Tromey  <tom@tromey.com>
5594
5595         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5596         declare.
5597         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5598
5599 2019-06-22  Tom de Vries  <tdevries@suse.de>
5600
5601         * dwarf2read.c (create_addrmap_from_aranges)
5602         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5603         instead of '%zu'.
5604
5605 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5606
5607         * dwarf2read.h (dwarf2_section_info_def): Remove.
5608         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5609         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5610         std::vector<dwarf2_section_info>.
5611         (struct dwo_file) <~dwo_file>: Remove.
5612         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5613         types field.
5614         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5615         (dwarf2_read_debug_names): Likewise.
5616         (create_debug_types_hash_table): Change parameter type to
5617         array_view, adjust code accordingly.
5618         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5619         (partial_die_info::fixup): Likewise.
5620         (determine_prefix): Likewise.
5621         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5622
5623 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5624
5625         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5626         gdb_bfd_ref_ptr.
5627         <~dwo_file>: Remove call to gdb_bfd_unref.
5628         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5629         gdb_bfd_ref_ptr::get.
5630
5631 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5632
5633         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5634         type to htab_up.
5635         * dwarf2read.c (struct dwo_file): Initialize fields.
5636         <~dwo_file>: New.
5637         (free_dwo_file): Remove, move content to ~dwo_file.
5638         (struct dwo_file_deleter): Remove.
5639         (dwo_file_up>: Remove custom deleter.
5640         (free_dwo_files): Remove.
5641         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5642         dwo_files.
5643         (process_skeletonless_type_units): Call unique_ptr::get.
5644         (allocate_dwo_file_hash_table): Add deleter to created hash
5645         table.  Change return type to htab_up.
5646         (lookup_dwo_file_slot): Don't memset dwo_file, call
5647         unique_ptr::get.
5648         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5649         (create_dwo_unit_in_dwp_v2): Likewise.
5650         (open_and_init_dwo_file): Likewise.
5651         (free_dwo_file_from_slot): Remove.
5652
5653 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5654
5655         * dwarf2read.h (struct dwarf2_section_info) <readin,
5656         is_virtual>: Change type to bool.
5657         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5658         true instead of 1.
5659
5660 2019-06-19  Tom Tromey  <tom@tromey.com>
5661
5662         * tui/tui-data.h (tui_init_content_element): Don't declare.
5663
5664 2019-06-19  Tom Tromey  <tom@tromey.com>
5665
5666         * tui/tui-data.h (tui_init_win_info): Don't declare.
5667
5668 2019-06-19  Tom de Vries  <tdevries@suse.de>
5669
5670         * dwarf2read.h (abstract_to_concrete): Change type to
5671         std::unordered_map<sect_offset, std::vector<sect_offset>,
5672         gdb::hash_enum<sect_offset>>.
5673
5674 2019-06-19  Tom Tromey  <tromey@adacore.com>
5675
5676         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5677         EVAL_AVOID_SIDE_EFFECTS specially.
5678
5679 2019-06-19  Tom Tromey  <tromey@adacore.com>
5680
5681         * source-cache.c (highlighter): New global.
5682         (source_cache::get_source_lines): Create a highlighter on demand.
5683
5684 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5685
5686         * defs.h (deprecated_interactive_hook): Delete declaration.
5687         * interps.c (clear_interpreter_hooks): Remove use of
5688         deprecated_interactive_hook.
5689         * top.c (deprecated_interactive_hook): Delete definition.
5690         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5691
5692 2019-06-18  Tom de Vries  <tdevries@suse.de>
5693
5694         PR gdb/24515
5695         * dwarf2read.h (abstract_to_concrete): Change type from
5696         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5697         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5698         * dwarf2read.c (read_variable): Update.
5699         (dwarf2_fetch_die_loc_sect_off): Update.
5700
5701 2019-06-17  Tom de Vries  <tdevries@suse.de>
5702
5703         PR gdb/24617
5704         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5705         accessing parent[parent_len - 1].
5706
5707 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5708
5709         PR gdb/24364
5710         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5711         call dtrace_process_dof with NULL dof.
5712
5713 2019-06-16  Tom de Vries  <tdevries@suse.de>
5714
5715         PR gdb/24445
5716         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5717
5718 2019-06-16  Tom Tromey  <tom@tromey.com>
5719
5720         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5721         (make_all_visible): Use address of member.
5722
5723 2019-06-16  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5726         (tui_free_window, free_content, free_content_elements): Remove
5727         unnecessary cast.
5728         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5729         cast.
5730         * tui/tui-regs.c (tui_show_register_group)
5731         (tui_display_registers_from, tui_display_reg_element_at_line):
5732         Remove unnecessary cast.
5733
5734 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5735
5736         * linux-nat.c (normal_mask): Delete.
5737         (_initialize_linux_nat): Don't initialise normal_mask.
5738
5739 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5740
5741         PR gdb/24445
5742         * dwarf-index-write.h (write_psymtabs_to_index): Add
5743         dwz_basename parameter.
5744         * dwarf-index-write.c (write_gdbindex): Move file writing to
5745         write_gdbindex_1.  Change return type void.
5746         (assert_file_size): Move up, remove filename parameter.
5747         (write_gdbindex_1): New function.
5748         (write_debug_names): Change return type to void, call
5749         assert_file_size.
5750         (struct index_wip_file): New struct.
5751         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5752         file logic to index_wip_file.  Write index for dwz file if
5753         needed.
5754         (save_gdb_index_command): Pass basename of dwz file, if present.
5755         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5756         build-id of dwz file, if present.
5757         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5758         (dwarf2_get_dwz_file): Likewise.
5759         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5760         (dwarf2_get_dwz_file): Likewise.
5761
5762 2019-06-16  Tom Tromey  <tom@tromey.com>
5763
5764         * coffread.c (process_coff_symbol): Use xstrdup.
5765         * value.c (create_internalvar): Use xstrdup.
5766
5767 2019-06-16  Tom Tromey  <tom@tromey.com>
5768
5769         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5770         * breakpoint.c (stopin_command, stopat_command)
5771         (until_break_command, decode_location_default): Remove unnecessary
5772         cast.
5773         * utils.c (subset_compare): Remove unnecessary cast.
5774         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5775         cast.
5776         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5777         cast.
5778         * infcmd.c (path_command): Remove unnecessary cast.
5779         * coffread.c (decode_type): Remove unnecessary cast.
5780         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5781         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5782         * tui/tui-stack.c (tui_show_locator_content)
5783         (tui_show_frame_info): Remove unnecessary cast.
5784         * tui/tui-win.c (tui_scroll_forward_command)
5785         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5786         (parse_scrolling_args): Remove unnecessary cast.
5787         * tui/tui-data.c (init_win_info, tui_del_window)
5788         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5789         (free_content_elements): Remove unnecessary cast.
5790         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5791         unnecessary cast.
5792         * tui/tui-source.c (tui_set_source_content)
5793         (tui_vertical_source_scroll): Remove unnecessary cast.
5794         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5795         cast.
5796         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5797         * tui/tui-regs.c (tui_display_registers_from)
5798         (tui_display_register): Remove unnecessary cast.
5799         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5800         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5801         (make_visible): Remove unnecessary cast.
5802         * tui/tui-winsource.c (tui_erase_source_content)
5803         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5804         unnecessary cast.
5805         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5806         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5807         * stabsread.c (read_type, read_array_type, read_range_type):
5808         Remove unnecessary cast.
5809         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5810         (parse_symbol, parse_type, upgrade_type, parse_external)
5811         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5812         unnecessary cast.
5813         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5814
5815 2019-06-16  Tom Tromey  <tom@tromey.com>
5816
5817         * tui/tui-data.c (tui_alloc_generic_win_info)
5818         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5819         checks.
5820
5821 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5822             Andrew Burgess  <andrew.burgess@embecosm.com>
5823
5824         * f-typeprint.c (f_print_type): Don't return early for not
5825         associated or not allocated types.
5826         (f_type_print_varspec_suffix): Add print_rank parameter and print
5827         ranks of array types in case they dangling.
5828         (f_type_print_base): Add print_rank parameter.
5829
5830 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5831
5832         * NEWS: Mention new MI commands.
5833         * break-catch-throw.c (enum exception_event_kind): Move to
5834         breakpoint.h.
5835         (print_mention_exception_catchpoint): Output text as a single
5836         message.
5837         (catch_exception_command_1): Rename to...
5838         (catch_exception_event): ...this, make non-static, update header
5839         command, and change some parameter types.
5840         (catch_catch_command): Update for changes to
5841         catch_exception_command_1.
5842         (catch_throw_command): Likewise.
5843         (catch_rethrow_command): Likewise.
5844         * breakpoint.c (enum exception_event_kind): Delete.
5845         * breakpoint.h (enum exception_event_kind): Moved here from
5846         break-catch-throw.c.
5847         (catch_exception_event): Declare.
5848         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5849         (mi_cmd_catch_throw): New function.
5850         (mi_cmd_catch_rethrow): New function.
5851         (mi_cmd_catch_catch): New function.
5852         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5853         'catch-catch' entries.
5854         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5855         (mi_cmd_catch_rethrow): Declare.
5856         (mi_cmd_catch_catch): Declare.
5857
5858 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5859
5860         * annotate.c (annotate_source_line): Change return type to void,
5861         update implementation to match.
5862         * annotate.h (annotate_source_line): Change return type to void,
5863         update header comment.
5864         * stack.c (print_frame_info): Don't change what frame information
5865         is printed based on whether annotations are on or not.
5866
5867 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5868
5869         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5870         (annotate_source): Make static.
5871         (annotate_source_line): Moved from source.c and renamed from
5872         identify_source_line.  Update the return type.
5873         * annotate.h (annotate_source): Delete declaration.
5874         (annotate_source_line): Declaration moved from source.h, and
5875         renamed from identify_source_line.  Return type updated.
5876         * source.c (identify_source_line): Moved to annotate.c and renamed
5877         to annotate_source_line.
5878         (info_line_command): Remove check of annotation_level.
5879         * source.h (identify_source_line): Move declaration to annotate.h
5880         and rename to annotate_source_line.
5881         * stack.c: Add 'annotate.h' include.
5882         (print_frame_info): Remove check of annotation_level before
5883         calling annotate_source_line.
5884
5885 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5886
5887         * source-cache.c (source_cache::get_plain_source_lines): Use
5888         open_source_file_with_line_charpos instead of just
5889         open_source_file, remove call to find_source_lines.
5890         (source_cache::get_source_lines): Likewise.
5891         * source.c (find_source_lines): Make static.
5892         (get_filename_and_charpos): Renamed into...
5893         (open_source_file_with_line_charpos): ..this along with changes to
5894         return a scoped_fd, and some other minor clean ups.
5895         (identify_source_line): Use open_source_file_with_line_charpos.
5896         (search_command_helper): Use open_source_file_with_line_charpos
5897         instead of just open_source_file, remove call to
5898         find_source_lines.
5899         * source.h (open_source_file_with_line_charpos): Declare new
5900         function.
5901         (find_source_lines): Delete declaration.
5902
5903 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * source.c (get_filename_and_charpos): Remove fullname
5906         parameter.
5907         (identify_source_line): Update call to get_filename_and_charpos.
5908
5909 2019-06-14  Tom Tromey  <tromey@adacore.com>
5910
5911         PR gdb/24502:
5912         * ui-style.h (skip_ansi_escape): Update comment.
5913         * ui-file.h (class no_terminal_escape_file): New class.
5914         * ui-file.c (no_terminal_escape_file::write)
5915         (no_terminal_escape_file::puts): New methods.
5916         * cli/cli-logging.c (handle_redirections): Use
5917         no_terminal_escape_file.
5918
5919 2019-06-14  Tom Tromey  <tromey@adacore.com>
5920
5921         * NEWS: Move convenience variable news above Python news.
5922
5923 2019-06-14  Tom Tromey  <tom@tromey.com>
5924
5925         * gnulib: Move directory to top-level.
5926         * configure.ac: Don't configure gnulib.
5927         * configure: Rebuild.
5928         * common/common-defs.h: Use new path to gnulib.
5929         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5930         (GNULIB_H): Remove.
5931         (INCGNU): Look in new gnulib location.
5932         (HFILES_NO_SRCDIR): Remove gnulib files.
5933         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5934         (generated_files): Remove GNULIB_H.
5935         ($(LIBGNU), all-lib): Remove targets.
5936         (distclean): Don't mention GNULIB_BUILDDIR.
5937         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5938
5939 2019-06-14  Tom Tromey  <tromey@adacore.com>
5940
5941         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5942         Warn if symbol file does not provide any symbols.
5943
5944 2019-06-14  Tom Tromey  <tromey@adacore.com>
5945
5946         * source.c (find_and_open_source): Respect basenames_may_differ.
5947
5948 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * annotate.c (annotate_breakpoints_invalid): Make use of
5951         scoped_restore_terminal_state.
5952         (annotate_frames_invalid): Likewise.
5953
5954 2019-06-14  Tom Tromey  <tromey@adacore.com>
5955
5956         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5957         allow assignment to an internalvar.
5958
5959 2019-06-14  Tom Tromey  <tromey@adacore.com>
5960
5961         * ada-lex.l: Allow "_" in attribute names.
5962
5963 2019-06-14  Tom Tromey  <tromey@adacore.com>
5964
5965         PR gdb/24653:
5966         * regcache.c (registers_changed): Don't call alloca.
5967         * top.c (execute_command): Don't call alloca.
5968
5969 2019-06-13  Pedro Alves  <palves@redhat.com>
5970
5971         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5972         'expression'.  When parsing an expression, error out if there's
5973         junk after "unlimited".
5974         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5975         (do_set_command): Adjust calls to is_unlimited_literal.
5976
5977 2019-06-13  Pedro Alves  <palves@redhat.com>
5978
5979         * compile/compile.c (make_compile_options_def_group): Add braces
5980         around array_view initializer.
5981         * thread.c (make_thread_apply_all_options_def_group)
5982         (make_thread_apply_all_options_def_group): Likewise.
5983
5984 2019-06-13  Pedro Alves  <palves@redhat.com>
5985
5986         * NEWS (New commands): Mention "maint test-options
5987         require-delimiter", "maint test-options unknown-is-error", "maint
5988         test-options unknown-is-operand" and "maint show
5989         test-options-completion-result".
5990         (New command options, command completion): New section.
5991         (Completion improvements): New section.
5992         Mention that you can abbreviate "unlimited".
5993
5994 2019-06-13  Pedro Alves  <palves@redhat.com>
5995
5996         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5997         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5998         * unittests/cli-utils-selftests.c (test_parse_flags)
5999         (test_parse_flags_qcs): Delete.
6000         (test_cli_utils): Don't call deleted functions.
6001
6002 2019-06-13  Pedro Alves  <palves@redhat.com>
6003
6004         * thread.c: Include "cli/cli-option.h".
6005         (tp_array_compar_ascending): Global.
6006         (tp_array_compar): Delete function.
6007         (tp_array_compar_ascending, tp_array_compar_descending): New
6008         functions.
6009         (ascending_option_def, qcs_flag_option_def)
6010         (thr_qcs_flags_option_defs)
6011         (make_thread_apply_all_options_def_group)
6012         (make_thread_apply_options_def_group): New.
6013         (thread_apply_all_command): Use gdb::option::process_options.
6014         (thread_apply_command_completer)
6015         (thread_apply_all_command_completer): New.
6016         (thread_apply_command): Use gdb::option::process_options.
6017         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6018         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6019         to generate help text of "thread apply".  Adjust "taas"'s help.
6020         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6021         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6022
6023 2019-06-13  Pedro Alves  <palves@redhat.com>
6024
6025         * thread.c (thread_apply_command): Check for invalid TID with
6026         isdigit instead of !isalpha.
6027
6028 2019-06-13  Pedro Alves  <palves@redhat.com>
6029
6030         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6031         (validate_flags_qcs): New.
6032         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6033         (validate_flags_qcs): Declare.
6034         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6035         (make_frame_apply_options_def_group): New.
6036         (frame_apply_command_count): Process options with
6037         gdb::option::process_options.
6038         (frame_apply_completer): New.
6039         (frame_apply_level_completer, frame_apply_all_completer)
6040         (frame_apply_completer): New.
6041         (_initialize_stack): Update help of "frame apply", "frame apply
6042         level", "frame apply all" and "faas" to mention supported options
6043         and install command completers.
6044         * stack.h (frame_apply_all_completer): Declare.
6045         * thread.c: Include "stack.h".
6046         (tfaas_command): Add "--".
6047         (_initialize_thread): Update help "tfaas" to mention supported
6048         options and install command completer.
6049
6050 2019-06-13  Pedro Alves  <palves@redhat.com>
6051
6052         * completer.c (complete_nested_command_line): New.
6053         (gdb_completion_word_break_characters_throw): Add assertion.
6054         * completer.h (complete_nested_command_line): Declare.
6055
6056 2019-06-13  Pedro Alves  <palves@redhat.com>
6057
6058         * stack.c (parse_backtrace_qualifiers): New.
6059         (backtrace_command): Use it.
6060         (backtrace_command_completer): Complete on qualifiers.
6061
6062 2019-06-13  Pedro Alves  <palves@redhat.com>
6063
6064         * frame.c: Include "cli/cli-option.h.
6065         (user_set_backtrace_options): New.
6066         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6067         Delete.
6068         (get_prev_frame): Adjust.
6069         (boolean_option_def, uinteger_option_def)
6070         (set_backtrace_option_defs): New.
6071         (_initialize_frame): Adjust and use
6072         gdb::option::add_setshow_cmds_for_options to install "set
6073         backtrace past-main" and "set backtrace past-entry".
6074         * frame.h: Include "cli/cli-option.h".
6075         (struct frame_print_options): Forward declare.
6076         (print_frame_arguments_all, print_frame_arguments_scalars)
6077         (print_frame_arguments_none): Declare.
6078         (print_entry_values): Delete declaration.
6079         (struct frame_print_options, user_frame_print_options): New.
6080         (struct set_backtrace_options): New.
6081         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6082         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6083         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6084         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6085         (list_args_or_locals): Add frame_print_options parameter.
6086         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6087         * python/py-framefilter.c (enumerate_args): Pass down
6088         USER_FRAME_PRINT_OPTIONS.
6089         * stack.c: Include "cli/cli-option.h".
6090         (print_frame_arguments_all, print_frame_arguments_scalars)
6091         (print_frame_arguments_none): Declare.
6092         (print_raw_frame_arguments, print_entry_values): Delete.
6093         (user_frame_print_options): New.
6094         (boolean_option_def, enum_option_def, frame_print_option_defs):
6095         New.
6096         (struct backtrace_cmd_options): New.
6097         (bt_flag_option_def): New.
6098         (backtrace_command_option_defs): New.
6099         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6100         (print_frame_arg, read_frame_arg, print_frame_args)
6101         (print_frame_info, print_frame): Add frame_print_options parameter
6102         and use it.
6103         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6104         (backtrace_command_1): Add frame_print_options and
6105         backtrace_cmd_options parameters and use them.
6106         (make_backtrace_options_def_group): New.
6107         (backtrace_command): Process command options with
6108         gdb::option::process_options.
6109         (backtrace_command_completer): New.
6110         (_initialize_stack): Extend "backtrace"'s help to mention
6111         supported options.  Install completer for "backtrace".
6112         Install some settings commands with add_setshow_cmds_for_options.
6113
6114 2019-06-13  Pedro Alves  <palves@redhat.com>
6115
6116         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6117         and that "set/show print raw frame-arguments" are now deprecated.
6118
6119         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6120         command.
6121         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6122         * stack.c (_initialize_stack): Install "set/show print
6123         raw-frame-arguments", and deprecate "set/show print raw
6124         frame-arguments".
6125         * valprint.c (_initialize_valprint): Deprecate "set/show print
6126         raw".
6127
6128 2019-06-13  Pedro Alves  <palves@redhat.com>
6129
6130         * compile/compile.c (struct compile_options): New.
6131         (compile_flag_option_def, compile_command_option_defs)
6132         (make_compile_options_def_group): New.
6133         (compile_file_command): Handle options with
6134         gdb::option::process_options.
6135         (compile_file_command_completer): New function.
6136         (compile_code_command): Handle options with
6137         gdb::option::process_options.
6138         (compile_code_command_completer): New function.
6139         (_initialize_compiler): Install completers for "compile code" and
6140         "compile file".  Mention available options in "compile code" and
6141         "compile code"'s help.
6142         * completer.c (advance_to_completion_word): New, factored out from
6143         ...
6144         (advance_to_expression_complete_word_point): ... this.
6145         (advance_to_filename_complete_word_point): New.
6146         * completer.h (advance_to_filename_complete_word_point): New
6147         declaration.
6148
6149 2019-06-13  Pedro Alves  <palves@redhat.com>
6150
6151         * compile/compile.c: Include "cli/cli-option.h".
6152         (compile_print_value): Scope data pointer is now a
6153         value_print_options pointer; adjust.
6154         (compile_print_command): Process options.  Scope data pointer is
6155         now a value_print_options pointer; adjust.
6156         (_initialize_compile): Update "compile print"'s help to include
6157         supported options.  Install a completer for "compile print".
6158         * cp-valprint.c (show_vtblprint, show_objectprint)
6159         (show_static_field_print): Delete.
6160         (_initialize_cp_valprint): Don't install "set print
6161         static-members", "set print vtbl", "set print object" here.
6162         * printcmd.c: Include "cli/cli-option.h" and
6163         "common/gdb_optional.h".
6164         (print_command_parse_format): Rework to fill in a
6165         value_print_options instead of a format_data.
6166         (print_value): Change parameter type from format_data pointer to
6167         value_print_options reference.  Adjust.
6168         (print_command_1): Process options.  Adjust to pass down a
6169         value_print_options.
6170         (print_command_completer): New.
6171         (_initialize_printcmd): Install print_command_completer as
6172         handle_brkchars completer for the "print" command.  Update
6173         "print"'s help to include supported options.
6174         * valprint.c: Include "cli/cli-option.h".
6175         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6176         here from cp-valprint.c.
6177         (boolean_option_def, uinteger_option_def)
6178         (value_print_option_defs, make_value_print_options_def_group):
6179         New.  Use gdb::option::add_setshow_cmds_for_options to install
6180         "set print elements", "set print null-stop", "set print repeats",
6181         "set print pretty", "set print union", "set print array", "set
6182         print address", "set print symbol", "set print array-indexes".
6183         * valprint.h: Include <string> and "cli/cli-option.h".
6184         (make_value_print_options_def_group): Declare.
6185         (print_value): Change parameter type from format_data pointer to
6186         value_print_options reference.
6187         (print_command_completer): Declare.
6188
6189 2019-06-13  Pedro Alves  <palves@redhat.com>
6190
6191         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6192         (COMMON_SFILES): Add maint-test-settings.c.
6193         * cli/cli-decode.c (boolean_enums): New global, factored out from
6194         ...
6195         (add_setshow_boolean_cmd): ... here.
6196         * cli/cli-decode.h (boolean_enums): Declare.
6197         * cli/cli-option.c: New file.
6198         * cli/cli-option.h: New file.
6199         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6200         factored out from ...
6201         (parse_cli_boolean_value(const char *)): ... this.
6202         (is_unlimited_literal): Change parameter type to pointer to
6203         pointer.  Adjust and advance ARG pointer.
6204         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6205         (parse_cli_var_enum): New, factored out from ...
6206         (do_set_command): ... this.  Adjust.
6207         * cli/cli-setshow.h (parse_cli_boolean_value)
6208         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6209         (parse_cli_var_enum): Declare.
6210         * cli/cli-utils.c: Include "cli/cli-option.h".
6211         (get_ulongest): New.
6212         * cli/cli-utils.h (get_ulongest): Declare.
6213         (check_for_argument): New overloads.
6214         * maint-test-options.c: New file.
6215
6216 2019-06-13  Pedro Alves  <palves@redhat.com>
6217
6218         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6219         parse a range if "-" is at the end of the string.
6220
6221 2019-06-13  Pedro Alves  <palves@redhat.com>
6222
6223         * cli/cli-setshow.c (parse_auto_binary_operation)
6224         (parse_cli_boolean_value): Don't allow "o".
6225
6226 2019-06-13  Pedro Alves  <palves@redhat.com>
6227
6228         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6229         * NEWS: Mention maint test-settings KIND.
6230         * maint-test-settings.c: New file.
6231
6232 2019-06-13  Pedro Alves  <palves@redhat.com>
6233
6234         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6235         completer.
6236         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6237         "set" completers.
6238
6239 2019-06-13  Pedro Alves  <palves@redhat.com>
6240
6241         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6242         after item.
6243
6244 2019-06-13  Pedro Alves  <palves@redhat.com>
6245
6246         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6247
6248 2019-06-13  Pedro Alves <palves@redhat.com>
6249
6250         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6251         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6252         call.
6253         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6254         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6255         calls.
6256         (check_for_argument): Skip spaces after argument.
6257
6258 2019-06-13  Pedro Alves  <palves@redhat.com>
6259
6260         * thread.c (thread_apply_command): Adjust TID parsing.
6261         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6262         detected before end of string.
6263         (tid_is_in_list): Error out if LIST is invalid.
6264
6265 2019-06-13  Pedro Alves  <palves@redhat.com>
6266
6267         * completer.c (complete_line_internal_1): Rewind completion word
6268         point.
6269         (completion_tracker::advance_custom_word_point_by): Change
6270         parameter type to int.
6271         * completer.h (completion_tracker::advance_custom_word_point_by):
6272         Likewise.
6273
6274 2019-06-13  Pedro Alves  <palves@redhat.com>
6275
6276         * completer.c (advance_to_completion_word): Handle delimiters.
6277
6278 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6279
6280         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6281
6282 2019-06-11  Tom Tromey  <tom@tromey.com>
6283
6284         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6285         (xmalloc_failed): Move to alloc.c.
6286         * alloc.c: New file.
6287         * Makefile.in (COMMON_SFILES): Add alloc.c.
6288
6289 2019-06-11  Tom Tromey  <tom@tromey.com>
6290
6291         * nat/linux-waitpid.c: Don't include server.h.
6292         (linux_debug): Remove.
6293         (my_waitpid): Update.
6294
6295 2019-06-11  Tom Tromey  <tromey@adacore.com>
6296
6297         * infcall.c (_initialize_infcall): Remove trailing newline from
6298         help.
6299         * user-regs.c (_initialize_user_regs): Remove trailing newline
6300         from help.
6301         * typeprint.c (_initialize_typeprint): Remove trailing newline
6302         from help.
6303         * reverse.c (_initialize_reverse): Remove trailing newlines from
6304         help.
6305         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6306         from help.
6307         * language.c (add_set_language_command): Remove trailing newline
6308         from help.
6309         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6310         help.
6311         * disasm.c (_initialize_disasm): Remove trailing newline from
6312         help.
6313         * top.c (init_main): Remove trailing newline from help.
6314         * interps.c (_initialize_interpreter): Remove trailing newline
6315         from help.
6316         * btrace.c (_initialize_btrace): Remove trailing newlines from
6317         help.
6318         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6319         from help.
6320         * python/python.c (_initialize_python): Remove trailing newline
6321         from help.
6322         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6323         help.
6324         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6325         from help.  Reformat some text.
6326         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6327         from help.
6328         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6329         newline from help.
6330
6331 2019-06-11  Tom Tromey  <tromey@adacore.com>
6332
6333         * darwin-nat.c (darwin_decode_exception_message)
6334         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6335
6336 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6337
6338         * valops.c (value_slice): Check for not allocated or not
6339         associated values.
6340
6341 2019-06-10  Tom de Vries  <tdevries@suse.de>
6342
6343         PR gdb/24618
6344         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6345         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6346         invalid.
6347
6348 2019-06-10  Tom de Vries  <tdevries@suse.de>
6349
6350         PR gdb/24611
6351         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6352         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6353
6354 2019-06-10  Tom de Vries  <tdevries@suse.de>
6355
6356         PR symtab/24545
6357         * symtab.c (struct demangled_name_entry): Add language field.
6358         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6359         static minimal symbol".  Set and use language field.
6360
6361 2019-06-10  Tom Tromey  <tromey@adacore.com>
6362
6363         * ada-lang.c (_initialize_ada_language): Update help text.
6364
6365 2019-06-10  Tom Tromey  <tromey@adacore.com>
6366
6367         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6368         with a newline.
6369         * guile/guile.c (handle_boot_error): Don't end warning with a
6370         newline.
6371         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6372         warning with a newline.
6373         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6374         newline.
6375         (s12z_frame_cache): Likewise.
6376         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6377         a newline.
6378         * solib-svr4.c (disable_probes_interface): Don't end warning with
6379         a newline.
6380         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6381         newline.
6382         * python/python.c (do_finish_initialization): Don't end warning
6383         with a newline.
6384
6385 2019-06-10  Tom Tromey  <tom@tromey.com>
6386
6387         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6388         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6389         gdbpy_enter.
6390
6391 2019-06-10  Tom Tromey  <tromey@adacore.com>
6392
6393         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6394         data.
6395         (elf_new_init): Don't call stabsread_new_init.
6396         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6397         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6398         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6399
6400 2019-06-10  Tom de Vries  <tdevries@suse.de>
6401
6402         PR symtab/16264
6403         PR symtab/24517
6404         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6405
6406 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6407
6408         * source.c (find_and_open_source): Also rewrite relative file
6409         names.
6410
6411 2019-04-26  Amos Bird  <amosbird@gmail.com>
6412
6413         * annotate.c (annotate_thread_exited): Add "thread-exited"
6414         annotation.
6415
6416 2019-06-06  Tom Tromey  <tromey@adacore.com>
6417
6418         * maint.h (class scoped_command_stats): Use
6419         DISABLE_COPY_AND_ASSIGN.
6420         <print_time>: New method.
6421         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6422         print_time.
6423         (scoped_command_stats::print_time): New method.
6424
6425 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6426
6427         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6428         instructions of lengths 6 or 8 bytes.
6429
6430 2019-06-04  Pedro Alves  <palves@redhat.com>
6431
6432         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6433
6434         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6435         * breakpoint.c (condition_completer): Likewise.
6436         * cli/cli-dump.c (scan_expression): Likewise.
6437         * common/filestuff.c (mkdir_recursive): Likewise.
6438         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6439         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6440         (gdb_abspath): Likewise.
6441         * compile/compile-cplus-types.c
6442         (compile_cplus_instance::decl_name): Likewise.
6443         * completer.c (complete_explicit_location):
6444         (signal_completer, reg_or_group_completer_1): Likewise.
6445         * cp-support.c (cp_remove_params_if_any): Likewise.
6446         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6447         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6448         * infcmd.c (strip_bg_char): Likewise.
6449         * linespec.c (copy_token_string): Likewise.
6450         * mi/mi-main.c (output_cores): Likewise.
6451         * psymtab.c (psymtab_search_name):
6452         * symfile.c (test_set_ext_lang_command): Likewise.
6453         * target.c (target_fileio_read_stralloc): Likewise.
6454         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6455         * value.c (complete_internalvar): Likewise.
6456
6457 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6458
6459         Add objfile property to gdb.Type.
6460         * NEWS: Mention Python API addition.
6461         * python/py-type.c (typy_get_objfile): New method.
6462
6463 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6464
6465         * NEWS: Mention the new set|show style [title|highlight].
6466         Mention changes to "show style", "help" and "apropos".
6467
6468 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6469
6470         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6471         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6472         instead of print_help_for_command.
6473         (print_doc_of_command): New function.
6474         (help_list): Add 'apropos -v word' suggestion.
6475         (print_help_for_command): Style the command name using title style.
6476         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6477         (_initialize_cli_cmds): Describe -v in apropos_command help.
6478
6479 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6480
6481         * cli/cli-style.h (cli_style_option): Add name in constructor,
6482         add m_name class member, add constructor with intensity,
6483         add name class function.
6484         (cli_style_option::add_setshow_commands): Remove name argument.
6485         (highlight_style, title_style): New styles.
6486         * cli/cli-style.c (do_show): New function that shows a style
6487         characteristic styling the style name with itself.
6488         (set_style_name): New function.
6489         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6490         Update all callers according to the changes in cli/cli-style.h.
6491         * utils.h (fputs_highlighted): New function.
6492         * utils.c (fputs_highlighted): Likewise.
6493
6494 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6495
6496         * NEWS: Mention new pipe command and new convenience variables.
6497
6498 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6499
6500         * cli/cli-cmds.c (pipe_command): New function.
6501         (_initialize_cli_cmds): Call add_com for pipe_command.
6502         Define | as an alias for pipe.
6503         (exit_status_set_internal_vars): New function.
6504         (shell_escape): Call exit_status_set_internal_vars.
6505         cli/cli-decode.c (find_command_name_length): Recognize | as
6506         a single character command.
6507
6508 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6509
6510         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6511         top.c (execute_command_to_ui_file): New function, mostly a copy
6512         of execute_command_to_string.
6513         (execute_command_to_string): Implement by calling
6514         execute_command_to_ui_file.
6515
6516 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6517
6518         * top.h (saved_command_line): Remove declaration.
6519         * top.c (previous_saved_command_line, previous_repeat_arguments):
6520         New variables.
6521         (saved_command_line): Make static, define together with other
6522         'repeat variables'.
6523         (dont_repeat): Clear repeat_arguments.
6524         (repeat_previous, get_saved_command_line, save_command_line):
6525         New functions.
6526         (gdb_init): Initialize saved_command_line
6527         and previous_saved_command_line.
6528         * main.c (captured_main_1): Remove saved_command_line initialization.
6529         * event-top.c (handle_line_of_input): Update to use
6530         the new 'repeat' related functions instead of direct access to
6531         saved_command_line.
6532         * command.h (repeat_previous, get_saved_command_line,
6533         save_command_line): New declarations.
6534         (dont_repeat): Add comment.
6535
6536 2019-05-30  Tom Tromey  <tromey@adacore.com>
6537
6538         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6539         Fix comment.
6540         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6541
6542 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6543
6544         PR cli/24587
6545         * completer.c (complete): Initialize variable word.
6546
6547 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6548
6549         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6550         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6551         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6552         'body' is NULL to the outter 'if', protecting the '!is_define'
6553         situation as well.
6554
6555 2019-05-29  Tom Tromey  <tromey@adacore.com>
6556
6557         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6558         (dwarf_unknown): New function.
6559         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6560         (dwarf_type_encoding_name): Use dwarf_unknown.
6561
6562 2019-05-29  Tom Tromey  <tromey@adacore.com>
6563
6564         PR c++/20020:
6565         * cp-valprint.c (cp_print_value_fields): Call
6566         cp_print_static_field inside "try".
6567
6568 2019-05-29  Tom Tromey  <tromey@adacore.com>
6569
6570         * inflow.c (struct terminal_info): Add default operator=.
6571         * configure: Rebuild.
6572         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6573         -Wdeprecated-copy-dtor, -Wredundant-move.
6574
6575 2019-05-29  Tom Tromey  <tromey@adacore.com>
6576
6577         * NEWS: Add entry.
6578         * infcmd.c (print_return_value_1): Handle finish_print
6579         option.
6580         (show_print_finish): New function.
6581         (_initialize_infcmd): Add "set/show print finish" commands.
6582         * valprint.c (user_print_options): Initialize new member.
6583         * valprint.h (struct value_print_options) <finish_print>: New
6584         member.
6585
6586 2019-05-28  Tom Tromey  <tromey@adacore.com>
6587
6588         * ada-lang.c (ada_remove_Xbn_suffix)
6589         (find_old_style_renaming_symbol)
6590         (parse_old_style_renaming): Remove.
6591         (ada_find_renaming_symbol): Don't call
6592         find_old_style_renaming_symbol.
6593         (ada_is_renaming_symbol): Rename from
6594         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6595         bool.  Now static.
6596         (ada_read_var_value): Update and simplify.
6597         * ada-exp.y (write_var_or_type): Remove old code.
6598
6599 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6600
6601         * event-top.c: Remove include comment.
6602         * inflow.c (class scoped_ignore_sigttou): Move from here...
6603         * inflow.h (class scoped_ignore_sigttou): ...to here.
6604         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6605         * top.c:  Remove include comment.
6606
6607 2019-05-27  Tom Tromey  <tom@tromey.com>
6608
6609         * NEWS: Fix typo.
6610
6611 2019-05-22  Tom Tromey  <tromey@adacore.com>
6612
6613         * target.c (target_follow_exec): Constify parameter.
6614         * target-delegates.c: Rebuild.
6615         * remote.c (remote_target::follow_exec): Constify parameter.
6616         * infrun.c (follow_exec): Constify parameter.
6617         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6618         (target_follow_exec): Likewise.
6619
6620 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6621
6622         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6623         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6624
6625 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6626
6627         * NEWS: Add debugredirect and testsuite sections.
6628
6629 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6630
6631         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6632         target descriptions using exclusively floating point register name
6633         aliases.
6634
6635 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6636
6637         PR gdb/18644:
6638         * f-lang.c (build_fortran_types): Handle the case where
6639         gdbarch_floatformat_for_type returns a nullptr.
6640
6641 2019-05-21  Tom de Vries  <tdevries@suse.de>
6642
6643         PR cli/24587
6644         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6645
6646 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6647
6648         PR gdb/18644:
6649         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6650         16-byte floats.
6651         * i386-tdep.c (i386_floatformat_for_type): Use
6652         floatformats_ia64_quad for the 16-byte floating point component
6653         within a fortran 32-byte complex number.
6654
6655 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6656
6657         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6658         delete default constructor.
6659         (find_partial_die): Update to return const struct.
6660         (partial_die_parent_scope): Move variable declaration into scope
6661         of its use and change its type to auto.
6662         (guess_partial_die_structure_name): Likewise.
6663         (partial_die_info::fixup): Likewise.
6664
6665 2019-05-17  Tom Tromey  <tromey@adacore.com>
6666
6667         * source.c (find_and_open_source): Remove cast.
6668
6669 2019-05-17  Tom Tromey  <tromey@adacore.com>
6670
6671         * annotate.c (annotate_source): Make "filename" const.
6672         * annotate.h (annotate_source): Use const.
6673
6674 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6675
6676         * disasm.c (set_disassembler_options): Send errors to stderr.
6677
6678 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6679
6680         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6681         (cli_interp_base::set_logging): Check debug_redirect.
6682         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6683         * cli/cli-logging.c (debug_redirect): Add static variable.
6684         (pop_output_files): Add default param.
6685         (handle_redirections): Print debug setting.
6686         (show_logging_command): Likewise.
6687         (_initialize_cli_logging): Add debugredirect command.
6688         * interps.c (current_interp_set_logging): Add debug_redirect
6689         parameter.
6690         * interps.h (set_logging): Add debug_redirect parameter.
6691         (current_interp_set_logging): Likewise.
6692         * mi/mi-common.h: Likewise.
6693         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6694
6695 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6696             Tom Tromey  <tromey@adacore.com>
6697
6698         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6699         directly.
6700         * cli/cli-interp.h (make_logging_output): Remove declaration.
6701         * cli/cli-logging.c (make_logging_output): Remove function.
6702         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6703         directly.
6704         * ui-file.c (tee_file::tee_file): Remove bools.
6705         (tee_file::~tee_file): Remove deletes.
6706         * ui-file.h (tee_file): Remove bools.
6707
6708 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6709
6710         * mi/mi-cmds.h (mi_cmd_complete): New function.
6711         * mi/mi-main.c (mi_cmd_complete): Likewise.
6712         * mi/mi-cmds.c: Define new MI command -complete.
6713         * NEWS: Mention new -complete command.
6714
6715 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6716
6717         * completer.h (complete): New function.
6718         * completer.c (complete): Likewise.
6719         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6720         function defined in completer.h.
6721
6722 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6723
6724         * MAINTAINERS (Write After Approval): Add myself.
6725
6726 2019-05-17  Tom de Vries  <tdevries@suse.de>
6727
6728         PR gdb/24094
6729         * dwarf2read.c (struct cu_partial_die_info): New struct.
6730         (find_partial_die): Return cu_partial_die_info.
6731         (partial_die_parent_scope, guess_partial_die_structure_name)
6732         (partial_die_info::fixup): Handle new return type of find_partial_die.
6733
6734 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6735
6736         PR breakpoints/24541
6737         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6738         "std::string", simplifying the algorithm.
6739
6740 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6741
6742         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6743         (stap_static_probe_ops::get_probes): Likewise.
6744
6745 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6746
6747         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6748         '-')" and "else if".
6749         (stap_parse_single_operand): Join checks for
6750         "gdbarch_stap_parse_special_token_p" and
6751         "gdbarch_stap_parse_special_token" in the same "if" statement.
6752         Invert check when verifying for operation on register
6753         displacement.
6754
6755 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6756
6757         * stap-probe.c (stap_get_opcode): Update comment.
6758         (stap_get_expected_argument_type): Likewise.
6759         (handle_stap_probe): Likewise.
6760
6761 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6762
6763         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6764         return type to 'bool'.  Adjust comment.  Use 'bool' when
6765         appropriate.
6766         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6767         * stap-probe.c (stap_parse_argument_1): Likewise.
6768         (stap_is_operator): Likewise.
6769         (stap_is_generic_prefix): Likewise.
6770         (stap_is_register_prefix): Likewise.
6771         (stap_is_register_indirection_prefix): Likewise.
6772         (stap_is_integer_prefix): Likewise.
6773         (stap_generic_check_suffix): Likewise.
6774         (stap_check_integer_suffix): Likewise.
6775         (stap_check_register_suffix): Likewise.
6776         (stap_check_register_indirection_suffix): Likewise.
6777         (stap_parse_register_operand): Likewise.
6778         (stap_parse_single_operand): Likewise.
6779         (stap_parse_argument_1): Likewise.
6780         (stap_probe::get_argument_count): Likewise.
6781         (stap_is_operator): Likewise.
6782
6783 2019-05-16  Tom Tromey  <tromey@adacore.com>
6784
6785         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6786         keyword to foreach.
6787
6788 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6789
6790         * linux-thread-db.c (try_thread_db_load_1): Change return type
6791         to bool.
6792         (try_thread_db_load): Likewise.
6793         (try_thread_db_load_from_pdir_1): Likewise.
6794         (try_thread_db_load_from_pdir): Likewise.
6795         (try_thread_db_load_from_sdir): Likewise.
6796         (try_thread_db_load_from_dir): Likewise.
6797         (thread_db_load_search): Likewise.
6798         (has_libpthread): Likewise.
6799         (thread_db_load): Likewise.
6800
6801 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6802
6803         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6804         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6805         NULL, and complain/return if that's the case.
6806
6807 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6808
6809         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6810         (advance, posn, abstract_read_memory): New functions.
6811         [struct mem_read_abstraction]: New struct.
6812         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6813
6814 2019-05-14  Tom Tromey  <tromey@adacore.com>
6815
6816         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6817         value is not lval_memory.
6818
6819 2019-05-14  Tom Tromey  <tromey@adacore.com>
6820
6821         * solib.c (info_sharedlibrary_command): Style the file name.
6822
6823 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6824
6825         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6826         (aarch64_vnv_type): Likewise.
6827         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6828         * common/tdesc.c: Likewise.
6829         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6830         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6831         * features/aarch64-fpu.xml: Add ieee half view.
6832         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6833         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6834         * gdbtypes.h (struct builtin_type): Likewise.
6835         (struct objfile_type): Likewise.
6836
6837 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6838
6839         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6840         typo.
6841         * location.h (string_to_event_location): Likewise.
6842
6843 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6844
6845         GDB 8.3 released.
6846
6847 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6848
6849         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6850         New variable declaration.
6851         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6852         New variable.
6853         (print_one_breakpoint): Use ui_out::test_flags and new global
6854         variable to compute use_fixed_output.
6855         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6856         Remove.
6857         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6858         (mi_multi_location_breakpoint_output_fixed): Remove.
6859         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6860         new variable.
6861         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6862         fix_multi_location_breakpoint_output flag if version >= 3.
6863         * ui-out.h (enum ui_out_flag)
6864         <fix_multi_location_breakpoint_output>: New enumerator.
6865
6866 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6867
6868         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6869
6870 2019-05-10  Tom Tromey  <tromey@adacore.com>
6871
6872         * ada-lang.c (catch_ada_completer): New function.
6873         (_initialize_ada_language): Use it.
6874
6875 2019-05-10  Tom Tromey  <tromey@adacore.com>
6876
6877         * thread.c (print_thread_info): Make "requested_threads" const.
6878         * gdbthread.h (print_thread_info): Make "requested_threads"
6879         const.
6880         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6881         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6882
6883 2019-05-08  Tom Tromey  <tom@tromey.com>
6884
6885         * gdbtypes.c (objfile_type_data): Change type.
6886         (objfile_type, _initialize_gdbtypes): Update.
6887
6888 2019-05-08  Tom Tromey  <tom@tromey.com>
6889
6890         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6891         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6892         (_initialize_dwarf2_frame): Update.
6893
6894 2019-05-08  Tom Tromey  <tom@tromey.com>
6895
6896         * objc-lang.c (objc_objfile_data): Change type.
6897         (find_methods): Update.
6898         (_initialize_objc_lang): Remove.
6899
6900 2019-05-08  Tom Tromey  <tom@tromey.com>
6901
6902         * stabsread.c (rs6000_builtin_type_data): Change type.
6903         (rs6000_builtin_type, _initialize_stabsread): Update.
6904
6905 2019-05-08  Tom Tromey  <tom@tromey.com>
6906
6907         * mips-tdep.c (mips_pdr_data): Remove.
6908         (_initialize_mips_tdep): Update.
6909
6910 2019-05-08  Tom Tromey  <tom@tromey.com>
6911
6912         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6913         (hppa_init_objfile_priv_data, read_unwind_info)
6914         (find_unwind_entry, _initialize_hppa_tdep): Update.
6915
6916 2019-05-08  Tom Tromey  <tom@tromey.com>
6917
6918         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6919         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6920         on obstack.
6921         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6922
6923 2019-05-08  Tom Tromey  <tom@tromey.com>
6924
6925         * mdebugread.c (basic_type_data): Change type.
6926         (basic_type, _initialize_mdebugread): Update.
6927
6928 2019-05-08  Tom Tromey  <tom@tromey.com>
6929
6930         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6931
6932 2019-05-08  Tom Tromey  <tom@tromey.com>
6933
6934         * nto-tdep.c (nto_inferior_data_reg): Change type.
6935         (nto_inferior_data): Update.
6936         (nto_inferior_data_cleanup, nto_new_inferior_data)
6937         (_initialize_nto_tdep): Remove.
6938         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6939
6940 2019-05-08  Tom Tromey  <tom@tromey.com>
6941
6942         * ada-lang.c (struct ada_inferior_data): Add initializers.
6943         (ada_inferior_data): Change type.
6944         (ada_inferior_data_cleanup): Remove.
6945         (get_ada_inferior_data, ada_inferior_exit)
6946         (struct ada_pspace_data): Add initializers, destructor.
6947         (ada_pspace_data_handle): Change type.
6948         (get_ada_pspace_data): Update.
6949         (ada_pspace_data_cleanup): Remove.
6950
6951 2019-05-08  Tom Tromey  <tom@tromey.com>
6952
6953         * coffread.c (struct coff_symfile_info): Add initializers.
6954         (coff_objfile_data_key): Move lower.  Change type.
6955         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6956         Update.
6957         (coff_free_info): Remove.
6958
6959 2019-05-08  Tom Tromey  <tom@tromey.com>
6960
6961         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6962         (fbsd_pspace_data_handle): Move lower.  Change type.
6963         (get_fbsd_pspace_data): Update.
6964         (fbsd_pspace_data_cleanup): Remove.
6965         (_initialize_fbsd_tdep): Update.
6966
6967 2019-05-08  Tom Tromey  <tom@tromey.com>
6968
6969         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6970         (get_ada_tasks_pspace_data): Update.
6971         (ada_tasks_pspace_data_cleanup): Remove.
6972         (_initialize_tasks): Update.
6973         (ada_tasks_inferior_data_handle): Change type.
6974         (get_ada_tasks_inferior_data): Update.
6975         (ada_tasks_inferior_data_cleanup): Remove.
6976         (struct ada_tasks_pspace_data): Add initializers.
6977
6978 2019-05-08  Tom Tromey  <tom@tromey.com>
6979
6980         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6981         * symfile-debug.c (debug_sym_get_probes): Change type.
6982         * stap-probe.c (handle_stap_probe):
6983         (stap_static_probe_ops::get_probes): Change type.
6984         * probe.h (class static_probe_ops) <get_probes>: Change type.
6985         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6986         (parse_probes_in_pspace): Update.
6987         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6988         Update.
6989         (any_static_probe_ops::get_probes): Change type.
6990         * elfread.c (elfread_data): New typedef.
6991         (probe_key): Change type.
6992         (elf_get_probes): Likewise.  Update.
6993         (probe_key_free): Remove.
6994         (_initialize_elfread): Update.
6995         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6996         Change type.
6997         (dtrace_process_dof_probe, dtrace_process_dof)
6998         (dtrace_static_probe_ops::get_probe): Change type.
6999
7000 2019-05-08  Tom Tromey  <tom@tromey.com>
7001
7002         * xcoffread.c (struct xcoff_symfile_info): Rename from
7003         coff_symfile_info.  Add initializers.
7004         (xcoff_objfile_data_key): Move lower.  Change type.
7005         (XCOFF_DATA): Rewrite.
7006         (xcoff_free_info): Remove.
7007         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7008         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7009         (xcoff_initial_scan): Update.
7010
7011 2019-05-08  Tom Tromey  <tom@tromey.com>
7012
7013         * solib-svr4.c (struct svr4_info): Add initializers and
7014         destructor.
7015         <probes_table>: Now an htab_up.
7016         (solib_svr4_pspace_data): Change type.
7017         (free_probes_table): Simplify.
7018         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7019         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7020         (probes_table_remove_objfile_probes, register_solib_event_probe)
7021         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7022         (_initialize_svr4_solib): Update.
7023
7024 2019-05-08  Tom Tromey  <tom@tromey.com>
7025
7026         * remote.c (remote_pspace_data): Change type.
7027         (remote_pspace_data_cleanup): Remove.
7028         (get_remote_exec_file, set_pspace_remote_exec_file)
7029         (_initialize_remote): Update.
7030
7031 2019-05-08  Tom Tromey  <tom@tromey.com>
7032
7033         * breakpoint.c (breakpoint_objfile_key): Change type.
7034         (get_breakpoint_objfile_data): Update.
7035         (free_breakpoint_objfile_data): Remove.
7036         (_initialize_breakpoint): Update.
7037
7038 2019-05-08  Tom Tromey  <tom@tromey.com>
7039
7040         * linux-tdep.c (struct linux_info): Add initializers.
7041         (linux_inferior_data): Move.  Change type.
7042         (invalidate_linux_cache_inf): Update.
7043         (linux_inferior_data_cleanup): Remove.
7044         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7045
7046 2019-05-08  Tom Tromey  <tom@tromey.com>
7047
7048         * auxv.c (auxv_inferior_data): Move.  Change type.
7049         (auxv_inferior_data_cleanup): Remove.
7050         (invalidate_auxv_cache_inf): Rewrite.
7051         (get_auxv_inferior_data, _initialize_auxv): Update.
7052
7053 2019-05-08  Tom Tromey  <tom@tromey.com>
7054
7055         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7056         (symfile_debug_objfile_data_key): Change type.
7057         (symfile_debug_installed, debug_qf_has_symbols)
7058         (debug_qf_find_last_source_symtab)
7059         (debug_qf_forget_cached_source_info)
7060         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7061         (debug_qf_print_stats, debug_qf_dump)
7062         (debug_qf_expand_symtabs_for_function)
7063         (debug_qf_expand_all_symtabs)
7064         (debug_qf_expand_symtabs_with_fullname)
7065         (debug_qf_map_matching_symbols)
7066         (debug_qf_expand_symtabs_matching)
7067         (debug_qf_find_pc_sect_compunit_symtab)
7068         (debug_qf_map_symbol_filenames)
7069         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7070         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7071         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7072         (debug_sym_read_linetable, debug_sym_relocate): Update.
7073         (symfile_debug_free_objfile): Remove.
7074         (install_symfile_debug_logging, _initialize_symfile_debug):
7075         Update.
7076
7077 2019-05-08  Tom Tromey  <tom@tromey.com>
7078
7079         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7080         allocate_on_obstack.
7081         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7082         (get_dwarf2_per_objfile): Update.
7083         (set_dwarf2_per_objfile): Remove.
7084         (dwarf2_has_info, dwarf2_get_section_info): Update.
7085         (dwarf2_free_objfile): Remove.
7086         (_initialize_dwarf2_read): Update.
7087
7088 2019-05-08  Tom Tromey  <tom@tromey.com>
7089
7090         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7091         initializers.
7092         <unsupported_script_warning_printed,
7093         script_not_found_warning_printed>: Now bool.
7094         (auto_load_pspace_data): Change type.
7095         (~auto_load_pspace_info): Rename from
7096         auto_load_pspace_data_cleanup.
7097         (get_auto_load_pspace_data, init_loaded_scripts_info)
7098         (clear_section_scripts, maybe_print_unsupported_script_warning)
7099         (maybe_print_script_not_found_warning, _initialize_auto_load):
7100         Update.
7101
7102 2019-05-08  Tom Tromey  <tom@tromey.com>
7103
7104         * objfiles.c (objfile_pspace_info): Add destructor and
7105         initializers.
7106         (objfiles_pspace_data): Change type.
7107         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7108         (get_objfile_pspace_data): Update.
7109         (objfiles_bfd_data): Change type.
7110         (get_objfile_bfd_data): Update.
7111         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7112
7113 2019-05-08  Tom Tromey  <tom@tromey.com>
7114
7115         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7116         Change type.
7117         (get_catch_syscall_inferior_data): Update.
7118         (catch_syscall_inferior_data_cleanup): Remove.
7119         (_initialize_break_catch_syscall): Update.
7120
7121 2019-05-08  Tom Tromey  <tom@tromey.com>
7122
7123         * inflow.c (struct terminal_info): Add destructor and
7124         initializers.
7125         (inflow_inferior_data): Change type.
7126         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7127         (get_inflow_inferior_data, inflow_inferior_exit)
7128         (swap_terminal_info, _initialize_inflow): Update.
7129
7130 2019-05-08  Tom Tromey  <tom@tromey.com>
7131
7132         * target-dcache.c (target_dcache_cleanup): Remove.
7133         (target_dcache_aspace_key): Change type.
7134         (target_dcache_init_p, target_dcache_invalidate)
7135         (target_dcache_get, target_dcache_get_or_init)
7136         (_initialize_target_dcache): Update.
7137         * dcache.h (struct dcache_deleter): New.
7138
7139 2019-05-08  Tom Tromey  <tom@tromey.com>
7140
7141         * symtab.c (struct symbol_cache): Add destructor and
7142         initializers.
7143         (symbol_cache_key): Move.  Change type.
7144         (make_symbol_cache, free_symbol_cache): Remove.
7145         (get_symbol_cache): Update.
7146         (symbol_cache_cleanup): Remove.
7147         (ALL_PSPACES, symbol_cache_flush)
7148         (maintenance_print_symbol_cache)
7149         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7150         Update.
7151
7152 2019-05-08  Tom Tromey  <tom@tromey.com>
7153
7154         * symtab.c (struct main_info): Add destructor and initializers.
7155         (main_progspace_key): Move.  Change type.
7156         (get_main_info): Update.
7157         (main_info_cleanup): Remove.
7158         (_initialize_symtab): Update.
7159
7160 2019-05-08  Tom Tromey  <tom@tromey.com>
7161
7162         * registry.h (DECLARE_REGISTRY): Define the _key class.
7163
7164 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7165
7166         * NEWS: Merge two 'New commands' sections.
7167
7168 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7169
7170         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7171         parameter and use Ada language definition instead.
7172         (ada_val_print_ptr): Remove unused language parameter.
7173         (ada_val_print_num): Remove language parameter and use Ada language
7174         definition instead.
7175         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7176         parameter.
7177         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7178         parameter and use Ada language definition instead.
7179         (ada_val_print_1): Update all ada_val_print_xxx calls.
7180         Remove language parameter.
7181         (ada_val_print): Update ada_val_print_1 call.
7182
7183 2019-05-08  Tom Tromey  <tromey@adacore.com>
7184
7185         * remote.c (remote_hw_watchpoint_limit)
7186         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7187         Now static.
7188
7189 2019-05-08  Tom Tromey  <tromey@adacore.com>
7190
7191         * maint.c (_initialize_maint_cmds): Move initialization code to
7192         remote.c.
7193         (watchdog, show_watchdog): Move to remote.c.
7194         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7195         "watchdog" static.
7196         (_initialize_remote): Move initialization code from maint.c.
7197         * defs.h (watchdog): Don't declare.
7198
7199 2019-05-08  Tom Tromey  <tromey@adacore.com>
7200
7201         * tui/tui-interp.c: Include main.h.
7202         * interps.c: Include main.h.
7203         * main.h (interpreter_p): Declare.
7204         * defs.h (interpreter_p): Don't declare.
7205
7206 2019-05-08  Tom Tromey  <tromey@adacore.com>
7207
7208         * dwarf2loc.c: Include dwarf2read.h.
7209         * defs.h (read_unsigned_leb128): Don't declare.
7210         * dwarf2read.h (read_unsigned_leb128): Declare.
7211
7212 2019-05-08  Tom Tromey  <tromey@adacore.com>
7213
7214         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7215         method.
7216
7217 2019-05-08  Tom Tromey  <tromey@adacore.com>
7218
7219         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7220         when no wrap column is set.
7221
7222 2019-05-08  Tom Tromey  <tromey@adacore.com>
7223
7224         * c-lang.c (c_get_string): Handle non-C-style arrays.
7225
7226 2019-05-08  Tom Tromey  <tromey@adacore.com>
7227
7228         * typeprint.c (print_offset_data::update): Print the bit offset,
7229         not the number of bits remaining.
7230
7231 2019-05-08  Tom Tromey  <tromey@adacore.com>
7232
7233         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7234         padding at end of comment.
7235
7236 2019-05-08  Tom Tromey  <tromey@adacore.com>
7237
7238         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7239         Compare main types.
7240
7241 2019-05-06  Tom Tromey  <tom@tromey.com>
7242
7243         * common/scoped_mmap.c: Include common-defs.h.
7244         * common/scoped_mmap.h: Don't include config.h.
7245
7246 2019-05-04  Tom Tromey  <tom@tromey.com>
7247
7248         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7249         (struct aarch64_call_info): Add initializers.
7250         <si>: Now a std::vector.
7251         (pass_on_stack, aarch64_push_dummy_call): Update.
7252
7253 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7254             Tom Tromey  <tom@tromey.com>
7255
7256         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7257         (ppc_threads): Now a std::vector.  Now static.
7258         (hwdebug_find_thread_points_by_tid)
7259         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7260         Update.
7261
7262 2019-05-04  Tom Tromey  <tom@tromey.com>
7263
7264         * arc-tdep.c (arc_tdesc_init): Return bool.
7265
7266 2019-05-04  Tom Tromey  <tom@tromey.com>
7267
7268         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7269         Use gdb_assert_not_reached.
7270
7271 2019-05-04  Tom Tromey  <tom@tromey.com>
7272
7273         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7274         "false".
7275
7276 2019-05-04  Tom Tromey  <tom@tromey.com>
7277
7278         * arc-tdep.c (arc_tdesc_init): Use bool.
7279
7280 2019-05-04  Tom Tromey  <tom@tromey.com>
7281
7282         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7283
7284 2019-05-04  Tom Tromey  <tom@tromey.com>
7285
7286         * cli/cli-cmds.c (valid_command_p): Return bool.
7287
7288 2019-05-04  Tom Tromey  <tom@tromey.com>
7289
7290         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7291         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7292
7293 2019-05-04  Raul Tambre  <raul@tambre.ee>
7294
7295         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7296         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7297         operator for comparison.
7298
7299 2019-05-04  Tom Tromey  <tom@tromey.com>
7300
7301         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7302         (lookup_partial_symbol, print_partial_symbols)
7303         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7304         (psymbol_compare): Update.
7305         (add_psymbol_to_bcache): Clear the entire psymbol.
7306         (maintenance_check_psymtabs): Update.
7307         * psympriv.h (struct partial_symbol): Don't derive from
7308         general_symbol_info.
7309         <obj_section, unrelocated_address, address,
7310         set_unrelocated_address>: Update.
7311         <ginfo>: New member.
7312         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7313         (debug_names::write_psymbols): Update.
7314
7315 2019-05-04  Tom de Vries  <tdevries@suse.de>
7316
7317         * contrib/cc-with-tweaks.sh: Support -n arg.
7318
7319 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7320
7321         * corelow.c (core_target::detach): Ensure frame cache and
7322         register caches are cleared.
7323         inferior.c (exit_inferior_1): Likewise.
7324
7325 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7326             Tom Tromey  <tom@tromey.com>
7327
7328         * dictionary.c (collate_pending_symbols_by_language): Remove
7329         "struct" from foreach.
7330         * symtab.c (lookup_global_symbol_from_objfile)
7331         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7332         foreach.
7333         * ser-tcp.c (net_open): Remove "struct" from foreach.
7334         * objfiles.c (objfile_relocate, objfile_rebase)
7335         (objfile_has_symbols): Remove "struct" from foreach.
7336         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7337         from foreach.
7338         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7339         foreach.
7340         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7341         "struct" from foreach.
7342         * ada-lang.c (create_excep_cond_exprs)
7343         (ada_exception_catchpoint_cond_string): Remove "struct" from
7344         foreach.
7345
7346 2019-05-03  Tom Tromey  <tromey@adacore.com>
7347
7348         * ada-exp.y (convert_char_literal): Check suffix of each
7349         enumerator.
7350
7351 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7352
7353         PR ada/21406:
7354         * ada-exp.y (yywrap): Don't define.
7355         * ada-lex.l (%option): Add noyywrap
7356         (yywrap): Remove.
7357
7358 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7359
7360         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7361         _WIN32_WINNT to the XP level, unless already defined to a higher
7362         level.
7363
7364         * unittests/parse-connection-spec-selftests.c:
7365         * ser-tcp.c:
7366         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7367         override.
7368
7369         * symfile.c (find_separate_debug_file): Remove colon from the
7370         drive spec of DOS/Windows file names of the target, so that the
7371         file name produced from DEBUGDIR and the target's directory will
7372         be valid on DOS/Windows systems.
7373
7374 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7375
7376         * rust-lang.c (val_print_struct): Handle printing structures
7377         containing strings.
7378
7379 2019-05-02  Tom Tromey  <tromey@adacore.com>
7380
7381         * valarith.c (_initialize_valarith): Remove.
7382
7383 2019-05-01  Tom Tromey  <tromey@adacore.com>
7384
7385         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7386         bitfields.
7387
7388 2019-05-01  Tom Tromey  <tromey@adacore.com>
7389
7390         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7391         for big-endian copies.
7392
7393 2019-04-30  Ali Tamur  <tamur@google.com>
7394         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7395         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7396         (read_3_bytes): New function.
7397
7398 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7399
7400         * windows-nat.c (main_thread_id): Delete.
7401         (handle_output_debug_string): Replace main_thread_id by
7402         current_event.dwThreadId.
7403         (fake_create_process): Likewise.
7404         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7405         Do not set main_thread_id.
7406         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7407         current_event.dwThreadId.
7408         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7409
7410 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7411
7412         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7413         Use current_event.dwThreadId instead of main_thread_id.
7414
7415 2019-04-30  Tom Tromey  <tromey@adacore.com>
7416
7417         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7418         (create_excep_cond_exprs): Iterate over program spaces.
7419         (ada_exception_catchpoint_cond_string): Examine all minimal
7420         symbols for exception types.
7421
7422 2019-04-30  Tom Tromey  <tromey@adacore.com>
7423
7424         PR c++/24470:
7425         * dwarf2read.c (process_structure_scope): Handle case where type
7426         has template parameters but no symbol was created.
7427
7428 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7429             Chris January  <chris.january@arm.com>
7430
7431         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7432         qualifier.
7433         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7434
7435 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7436
7437         * f-typeprint.c (f_print_type): Update rules for printing
7438         whitespace.
7439         (f_type_print_varspec_suffix): Likewise.
7440
7441 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7442             Chris January  <chris.january@arm.com>
7443
7444         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7445         function arguments.
7446
7447 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7448
7449         * f-lang.c (build_fortran_types): Change name of void type to
7450         lower case.
7451         * f-typeprint.c (f_type_print_base): Print the name of the void
7452         type, rather than a fixed string.
7453         * f-valprint.c (f_decorations): Use lower case void string.
7454
7455 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7456             Chris January  <chris.january@arm.com>
7457
7458         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7459         types for Fortran.
7460
7461 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7462             Chris January  <chris.january@arm.com>
7463             David Lecomber  <david.lecomber@arm.com>
7464
7465         * f-exp.y (BINOP_INTRINSIC): New token.
7466         (exp): New parser rule handling BINOP_INTRINSIC.
7467         (f77_keywords): Add new builtin procedures.
7468         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7469         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7470         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7471         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7472         (print_unop_subexp_f): New function.
7473         (print_binop_subexp_f): New function.
7474         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7475         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7476         (dump_subexp_body_f): Likewise.
7477         (operator_check_f): Likewise.
7478         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7479         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7480
7481 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7484         UNOP_KIND.
7485         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7486         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7487         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7488         (operator_length_f): New fuction.
7489         (print_subexp_f): New function.
7490         (op_name_f): New function.
7491         (dump_subexp_body_f): New function.
7492         (operator_check_f): New function.
7493         (exp_descriptor_f): Replace standard expression handling functions
7494         with new functions.
7495         * gdb/fortran-operator.def: New file.
7496         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7497         * gdb/std-operator.def: Remove UNOP_KIND.
7498
7499 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7500
7501         * std-operator.def: Remove unbalanced, stray double quote
7502         character.
7503
7504 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7505             Chris January  <chris.january@arm.com>
7506             Daniel Everett  <daniel.everett@arm.com>
7507             Nick Forrington  <nick.forrington@arm.com>
7508             Richard Bunt  <richard.bunt@arm.com>
7509
7510         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7511         of depth when printing anonymous structs or unions.
7512         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7513         Don't print either the top-level value, or the children if the
7514         max-depth is exceeded.
7515         (ppscm_print_children): When printing the key of a map, allow one
7516         extra level of depth.
7517         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7518         print either the top-level value, or the children if the max-depth
7519         is exceeded.
7520         (print_children): When printing the key of a map, allow one extra
7521         level of depth.
7522         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7523         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7524         (user_print_options): Initialise max_depth field.
7525         (val_print_scalar_or_string_type_p): New function.
7526         (val_print): Check to see if the max depth has been reached.
7527         (val_print_check_max_depth): Define new function.
7528         (show_print_max_depth): New function.
7529         (_initialize_valprint): Add 'print max-depth' option.
7530         * valprint.h (struct value_print_options) <max_depth>: New field.
7531         (val_print_check_max_depth): Declare new function.
7532         * NEWS: Document new feature.
7533
7534 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * ada-lang.c (ada_language_defn): Initialise new field.
7537         * c-lang.c (c_is_string_type_p): New function.
7538         (c_language_defn): Initialise new field.
7539         (cplus_language_defn): Initialise new field.
7540         (asm_language_defn): Initialise new field.
7541         (minimal_language_defn): Initialise new field.
7542         * c-lang.h (c_is_string_type_p): Declare new function.
7543         * d-lang.c (d_language_defn): Initialise new field.
7544         * f-lang.c (f_is_string_type_p): New function.
7545         (f_language_defn): Initialise new field.
7546         * go-lang.c (go_is_string_type_p): New function.
7547         (go_language_defn): Initialise new field.
7548         * language.c (default_is_string_type_p): New function.
7549         (unknown_language_defn): Initialise new field.
7550         (auto_language_defn): Initialise new field.
7551         * language.h (struct language_defn) <la_is_string_type_p>: New
7552         member variable.
7553         (default_is_string_type_p): Declare new function.
7554         * m2-lang.c (m2_language_defn): Initialise new field.
7555         * objc-lang.c (objc_language_defn): Initialise new field.
7556         * opencl-lang.c (opencl_language_defn): Initialise new field.
7557         * p-lang.c (pascal_is_string_type_p): New function.
7558         (pascal_language_defn): Initialise new field.
7559         * rust-lang.c (rust_is_string_type_p): New function.
7560         (rust_language_defn): Initialise new field.
7561
7562 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7563
7564         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7565         New field.
7566         * ada-lang.c (ada_language_defn): Initialise new field.
7567         * c-lang.c (c_language_defn): Likewise.
7568         (cplus_language_defn): Likewise.
7569         (asm_language_defn): Likewise.
7570         (minimal_language_defn): Likewise.
7571         * d-lang.c (d_language_defn): Likewise.
7572         * f-lang.c (f_language_defn): Likewise.
7573         * go-lang.c (go_language_defn): Likewise.
7574         * language.c (unknown_language_defn): Likewise.
7575         (auto_language_defn): Likewise.
7576         * m2-lang.c (m2_language_defn): Likewise.
7577         * objc-lang.c (objc_language_defn): Likewise.
7578         * opencl-lang.c (opencl_language_defn): Likewise.
7579         * p-lang.c (pascal_language_defn): Likewise.
7580         * rust-lang.c (rust_language_defn): Likewise.
7581
7582 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7583
7584         * ada-lang.c (ada_is_character_type): Change return type to bool.
7585         (ada_is_string_type): Likewise.
7586         * ada-lang.h (ada_is_character_type): Update declaration
7587         (ada_is_string_type): Likewise.
7588
7589 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7590
7591         Support style in 'frame|thread apply'
7592
7593         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7594         * record.c (record_start, record_stop): Update callers of
7595         execute_command_to_string with false.
7596         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7597         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7598         methods.
7599         (class string_file): New constructor with term_out parameter.
7600         Override methods term_out and can_emit_style_escape.  New member
7601         term_out.
7602         (class stdio_file): Override can_emit_style_escape.
7603         (class tee_file): Override term_out and can_emit_style_escape.
7604         * utils.h (can_emit_style_escape): Remove.
7605         * utils.c (can_emit_style_escape): Likewise.
7606         Update all callers of can_emit_style_escape (SOMESTREAM) to
7607         SOMESTREAM->can_emit_style_escape.
7608         * source-cache.c (source_cache::get_source_lines): Likewise.
7609         * stack.c (frame_apply_command_count): Call execute_command_to_string
7610         passing the term_out characteristic of the current gdb_stdout.
7611         * thread.c (thr_try_catch_cmd): Likewise.
7612         * top.c (execute_command_to_string): pass term_out parameter
7613         to construct the string_file for the command output.
7614         * ui-file.c (term_cli_styling): New function (most code moved
7615         from utils.c can_emit_style_escape).
7616         (string_file::string_file, string_file::can_emit_style_escape,
7617         stdio_file::can_emit_style_escape, tee_file::term_out,
7618         tee_file::can_emit_style_escape): New functions.
7619
7620 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7621
7622         * NEWS: Mention the new set|show may-call-functions.
7623         * infcall.c (may_call_functions_p): New variable.
7624         (show_may_call_functions_p): New function.
7625         (call_function_by_hand_dummy): Throws an error if not
7626         may-call-functions.
7627         (_initialize_infcall): Call add_setshow_boolean_cmd for
7628         may-call-functions.
7629
7630 2019-04-25  Keith Seitz  <keiths@redhat.com>
7631
7632         PR c++/24367
7633         * cp-support.c (inspect_type): Don't attempt substitutions
7634         of symbol with the same name.
7635
7636 2019-04-25  Tom Tromey  <tromey@adacore.com>
7637
7638         PR gdb/24475:
7639         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7640         static.
7641
7642 2019-04-25  Tom Tromey  <tromey@adacore.com>
7643
7644         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7645         rvalue reference.
7646         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7647         (gdb_xml_parser::parse): Use std::move.
7648         * python/python-internal.h (gdbpy_convert_exception): Take a const
7649         reference.
7650         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7651         std::move.
7652         * python/py-utils.c (gdbpy_convert_exception): Take a const
7653         reference.
7654         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7655         Use std::move.
7656         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7657         Use std::move.
7658         * mi/mi-main.c (mi_print_exception): Take a const reference.
7659         * main.c (handle_command_errors): Take a const reference.
7660         * linespec.c (parse_linespec): Use std::move.
7661         * infcall.c (run_inferior_call): Use std::move.
7662         (call_function_by_hand_dummy): Use std::move.
7663         * exec.c (try_open_exec_file): Use std::move.
7664         * exceptions.h (exception_print, exception_fprintf)
7665         (exception_print_same): Update.
7666         * exceptions.c (print_exception, exception_print)
7667         (exception_fprintf, exception_print_same): Change parameters to
7668         const reference.
7669         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7670         * common/new-op.c: Use std::move.
7671         * common/common-exceptions.h (struct gdb_exception): Add move
7672         constructor.
7673         (struct gdb_exception_error, struct gdb_exception_quit, struct
7674         gdb_quit_bad_alloc): Change constructor to move constructor.
7675         (throw_exception): Change parameter to rvalue reference.
7676         * common/common-exceptions.c (throw_exception): Take rvalue
7677         reference.
7678         * cli/cli-interp.c (safe_execute_command): Use std::move.
7679         * breakpoint.c (insert_bp_location, location_to_sals): Use
7680         std::move.
7681
7682 2019-04-25  Tom Tromey  <tromey@adacore.com>
7683
7684         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7685         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7686         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7687         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7688         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7689         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7690         guile/scm-value.c: Use unpack.
7691         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7692         gdbscm_gdb_exception.
7693         (gdbscm_throw_gdb_exception): Likewise.
7694         (struct gdbscm_gdb_exception): New.
7695         (unpack): New function.
7696         (gdbscm_wrap): Use unpack.
7697
7698 2019-04-25  Tom Tromey  <tromey@adacore.com>
7699
7700         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7701         (gdb_rl_callback_handler): Use std::move.
7702         * common/common-exceptions.h (struct gdb_exception): Add move
7703         assignment operator.
7704         (throw_exception_sjlj): Change "exception" to const reference.
7705         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7706         (throw_exception_sjlj): Change "exception" to const reference.
7707
7708 2019-04-25  Tom Tromey  <tromey@adacore.com>
7709
7710         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7711         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7712         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7713         Update.
7714         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7715         Update.
7716         * mi/mi-interp.c (mi_interp::exec): Update.
7717         * linespec.c (parse_linespec): Update.
7718         * infcall.c (run_inferior_call): Update.
7719         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7720         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7721         (gdbscm_lookup_global_symbol): Update.
7722         * guile/scm-param.c (gdbscm_parameter_value): Update.
7723         * guile/scm-frame.c (gdbscm_frame_read_register)
7724         (gdbscm_frame_read_var): Update.
7725         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7726         * exec.c (try_open_exec_file): Update.
7727         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7728         (gdb_rl_callback_handler): Update.
7729         * common/common-exceptions.h (exception_none): Don't declare.
7730         * common/common-exceptions.c (exception_none): Don't define.
7731         (struct catcher) <exception>: Update.
7732         * cli/cli-interp.c (safe_execute_command): Update.
7733         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7734
7735 2019-04-25  Ali Tamur  <tamur@google.com>
7736
7737         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7738         (read_attribute_value): Likewise.
7739         (dwarf2_read_addr_index): Update comment.
7740         (read_str_index): Add DW_FORM_strx.
7741         (dwarf2_string_attr): Likewise.
7742         (dwarf2_const_value_attr): Likewise.
7743         (dump_die_shallow): Likewise.
7744         (dwarf2_fetch_constant_bytes): Likewise.
7745         (skip_form_bytes): Likewise.
7746         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7747
7748 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7749
7750         PR corefiles/11608
7751         PR corefiles/18187
7752         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7753         OFFSET.  Verify if current mapping contains an ELF header.
7754         (linux_find_memory_regions_full): Adjust call to
7755         dump_mapping_p.
7756
7757 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7758             Kang Li <kanglictf@gmail.com>
7759
7760         PR gdb/21600
7761
7762         * dwarf2-frame.c (read_initial_length): Be consistent about using
7763         unsigned representation of length.
7764         (decode_frame_entry_1): Likewise.  Check for wraparound of
7765         end pointer as well as buffer overflow.
7766
7767 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7768
7769         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7770         "vq".
7771
7772 2019-04-24  Tom Tromey  <tromey@adacore.com>
7773
7774         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7775
7776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7777
7778         * s12z-tdep.c (s12z_unwind_pc): Delete.
7779         (s12z_unwind_sp): Delete.
7780         (s12z_gdbarch_init): Don't register deleted functions with
7781         gdbarch.
7782
7783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * rl78-tdep.c (rl78_unwind_sp): Delete.
7786         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7787
7788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7791         (xstormy16_unwind_pc): Delete.
7792         (xstormy16_dummy_id): Delete.
7793         (xstormy16_gdbarch_init): Don't register deleted functions with
7794         gdbarch.
7795
7796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7797
7798         * vax-tdep.c (vax_unwind_pc): Delete.
7799         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7800
7801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7802
7803         * v850-tdep.c (v850_unwind_sp): Delete.
7804         (v850_unwind_pc): Delete.
7805         (v850_dummy_id): Delete.
7806         (v850_gdbarch_init): Don't register deleted functions with
7807         gdbarch.
7808
7809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7812         (tilegx_unwind_pc): Delete.
7813         (tilegx_unwind_dummy_id): Delete.
7814         (tilegx_gdbarch_init): Don't register deleted functions with
7815         gdbarch.
7816
7817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7818
7819         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7820         (tic6x_dummy_id): Delete.
7821         (tic6x_gdbarch_init): Don't register deleted functions with
7822         gdbarch.
7823
7824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * sparc-tdep.c (sparc_unwind_pc): Delete.
7827         (sparc32_gdbarch_init): Don't register deleted function with
7828         gdbarch.
7829
7830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * sh-tdep.c (sh_unwind_sp): Delete.
7833         (sh_unwind_pc): Delete.
7834         (sh_dummy_id): Delete.
7835         (sh_gdbarch_init): Don't register deleted functions with
7836         gdbarch.
7837
7838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7839
7840         * score-tdep.c (score_unwind_sp): Delete.
7841         (score_unwind_pc): Delete.
7842         (score_dummy_id): Delete.
7843         (score_gdbarch_init): Don't register deleted functions with
7844         gdbarch.
7845
7846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7847
7848         * rx-tdep.c (rx_unwind_pc): Delete.
7849         (rx_unwind_sp): Delete.
7850         (rx_dummy_id): Delete.
7851         (rx_gdbarch_init): Don't register deleted functions with
7852         gdbarch.  Update comment.
7853
7854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7855
7856         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7857         (rs6000_dummy_id): Delete.
7858         (rs6000_gdbarch_init): Don't register deleted functions with
7859         gdbarch.
7860
7861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7862
7863         * or1k-tdep.c (or1k_dummy_id): Delete.
7864         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7865
7866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * nios2-tdep.c (nios2_dummy_id): Delete.
7869         (nios2_unwind_sp): Delete.
7870         (nios2_gdbarch_init): Don't register deleted functions with
7871         gdbarch.
7872
7873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7874
7875         * nds32-tdep.c (nds32_dummy_id): Delete.
7876         (nds32_unwind_pc): Delete.
7877         (nds32_unwind_sp): Delete.
7878         (nds32_gdbarch_init): Don't register deleted functions with
7879         gdbarch.
7880
7881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7882
7883         * msp430-tdep.c (msp430_unwind_pc): Delete.
7884         (msp430_unwind_sp): Delete.
7885         (msp430_dummy_id): Delete.
7886         (msp430_gdbarch_init): Don't register deleted functions with
7887         gdbarch.
7888
7889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7890
7891         * moxie-tdep.c (moxie_unwind_sp): Delete.
7892         (moxie_unwind_pc): Delete.
7893         (moxie_dummy_id): Delete.
7894         (moxie_gdbarch_init): Don't register deleted functions with
7895         gdbarch.
7896
7897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7898
7899         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7900         (mn10300_unwind_pc): Delete.
7901         (mn10300_unwind_sp): Delete.
7902         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7903         mn10300_unwind_sp.
7904         (mn10300_frame_unwind_init): Don't register deleted functions with
7905         gdbarch.
7906
7907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7908
7909         * mep-tdep.c (mep_unwind_pc): Delete.
7910         (mep_unwind_sp): Delete.
7911         (mep_dummy_id): Delete.
7912         (mep_gdbarch_init): Don't register deleted functions with
7913         gdbarch.
7914
7915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7916
7917         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7918         (m68hc11_unwind_sp): Delete.
7919         (m68hc11_gdbarch_init): Don't register deleted functions with
7920         gdbarch.
7921
7922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7923
7924         * m32r-tdep.c (m32r_unwind_sp): Delete.
7925         (m32r_unwind_pc): Delete.
7926         (m32r_dummy_id): Delete.
7927         (m32r_gdbarch_init): Don't register deleted functions with
7928         gdbarch.
7929
7930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7931
7932         * m32c-tdep.c (m32c_unwind_pc): Delete.
7933         (m32c_unwind_sp): Delete.
7934         (m32c_dummy_id): Delete.
7935         (m32c_gdbarch_init): Don't register deleted functions with
7936         gdbarch.
7937
7938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7939
7940         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7941         (lm32_unwind_pc): Delete.
7942         (lm32_dummy_id): Delete.
7943         (lm32_gdbarch_init): Don't register deleted functions with
7944         gdbarch.
7945
7946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7947
7948         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7949         (iq2000_unwind_pc): Delete.
7950         (iq2000_dummy_id): Delete.
7951         (iq2000_gdbarch_init): Don't register deleted functions with
7952         gdbarch.
7953
7954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7955
7956         * nds32-tdep.c (nds32_type_align): Delete.
7957         (nds32_push_dummy_call): Use type_align instead.
7958
7959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7960
7961         * arm-tdep.c (arm_type_align): Only handle vector override case.
7962         (arm_push_dummy_call): Use type_align.
7963         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7964
7965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7966
7967         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7968         case.
7969         (pass_on_stack): Use type_align.
7970         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7971         function.
7972
7973 2019-04-23  Tom Tromey  <tromey@adacore.com>
7974
7975         * dwarf2read.c (line_header::file_name_at): Remove unused
7976         overload.
7977
7978 2019-04-23  Tom de Vries  <tdevries@suse.de>
7979
7980         PR gdb/24438
7981         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7982         invocation.
7983
7984
7985 2019-03-27  Ali Tamur  <tamur@google.com>
7986
7987         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7988         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7989         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7990         (dwarf_expr_context::get_addr_index): Likewise
7991         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7992         (symbol_needs_eval_context::get_addr_index): Likewise
7993         (disassemble_dwarf_expression): Add DW_OP_addrx
7994         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7995         (read_cutu_die_from_dwo): Update comment
7996         (skip_one_die): Add DW_FORM_addrx
7997         (read_attribute_value): Likewise
7998         (var_decode_location): Add DW_OP_addrx
7999         (dwarf2_const_value_attr): Add DW_FORM_addrx
8000         (dump_die_shallow): Likewise
8001         (dwarf2_fetch_constant_bytes): Likewise
8002         (decode_locdesc): Add DW_OP_addrx
8003         (skip_form_bytes): Add DW_FORM_addrx
8004
8005 2019-04-22  Ali Tamur  <tamur@google.com>
8006
8007         * MAINTAINERS (Write After Approval): Add self.
8008
8009 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8010
8011         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8012         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8013         (open_symbol_file_object): Likewise.
8014         (svr4_default_sos): Add info parameter.
8015         (svr4_read_so_list): Likewise.
8016         (svr4_current_sos_direct): Adjust functions calls to pass down
8017         info.
8018         (svr4_current_sos_1): Add info parameter.
8019         (svr4_current_sos): Call get_svr4_info, pass info down to
8020         svr4_current_sos_1.
8021         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8022         get_svr4_info.
8023         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8024         get_svr4_info.
8025         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8026         to get_svr4_info.
8027         (probes_table_remove_objfile_probes): Likewise.
8028         (register_solib_event_probe): Add info parameter.
8029         (solist_update_incremental): Pass info parameter down to
8030         svr4_read_so_list.
8031         (disable_probes_interface): Add info parameter.
8032         (svr4_handle_solib_event): Pass current_program_space to
8033         get_svr4_info.  Adjust disable_probes_interface cleanup.
8034         (svr4_create_probe_breakpoints): Add info parameter, pass it
8035         down to register_solib_event_probe.
8036         (svr4_create_solib_event_breakpoints): Add info parameter,
8037         pass it down to svr4_create_probe_breakpoints.
8038         (enable_break): Pass info down to
8039         svr4_create_solib_event_breakpoints.
8040         (svr4_solib_create_inferior_hook): Pass current_program_space to
8041         get_svr4_info.
8042         (svr4_clear_solib): Likewise.
8043
8044 2019-04-22  Pedro Alves  <palves@redhat.com>
8045
8046         * solib-svr4.c (svr4_free_objfile_observer): New.
8047         (probe_and_action::objfile): New field.
8048         (probes_table_htab_remove_objfile_probes)
8049         (probes_table_remove_objfile_probes): New functions.
8050         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8051         in the new probe_and_action.  Don't store the probe in 'lookup'.
8052         (svr4_create_probe_breakpoints): Pass objfile to
8053         register_solib_event_probe.
8054         (_initialize_svr4_solib): Register a free_objfile observer.
8055
8056 2019-04-19  Tom Tromey  <tom@tromey.com>
8057
8058         * common/queue.h: Remove.
8059
8060 2019-04-19  Tom Tromey  <tom@tromey.com>
8061
8062         * event-loop.c: Don't include "common/queue.h".
8063
8064 2019-04-19  Tom Tromey  <tom@tromey.com>
8065
8066         * remote.c (remote_target): Use delete.
8067         * remote-notif.h: Include <list>, not "common/queue.h".
8068         (notif_client_p): Remove typedef.
8069         (remote_notif_state): Add constructor, destructor, initializer.
8070         <notif_queue>: Now a std::list.
8071         (remote_notif_state_xfree): Don't declare.
8072         * remote-notif.c (remote_notif_process, handle_notification)
8073         (remote_notif_state_allocate): Update.
8074         (~remote_notif_state): Rename from remote_notif_state_xfree.
8075
8076 2019-04-19  Tom Tromey  <tom@tromey.com>
8077
8078         * symfile.c (reread_symbols): Update.
8079         * objfiles.c (objfile_register_static_link)
8080         (objfile_lookup_static_link): Update
8081         (~objfile) Don't delete static_links.
8082         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8083
8084 2019-04-19  Tom Tromey  <tom@tromey.com>
8085
8086         * type-stack.h (struct type_stack) <insert>: Constify string.
8087         * type-stack.c (type_stack::insert): Constify string.
8088         * gdbtypes.h (lookup_template_type): Update.
8089         (address_space_name_to_int): Update.
8090         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8091         const.
8092         (lookup_template_type): Make name const.
8093         * c-exp.y: Update rules.
8094         (lex_one_token, classify_name, classify_inner_name)
8095         (c_print_token): Update.
8096         * p-exp.y: Update rules.
8097         (yylex): Update.
8098         * f-exp.y: Update rules.
8099         (yylex): Update.
8100         * d-exp.y: Update rules.
8101         (lex_one_token, classify_name, classify_inner_name): Update.
8102         * parse.c (write_dollar_variable, copy_name): Return std::string.
8103         * parser-defs.h (copy_name): Change return type.
8104         * m2-exp.y: Update rules.
8105         (yylex): Update.
8106         * go-exp.y (lex_one_token): Update.
8107         Update rules.
8108         (classify_unsafe_function, classify_packaged_name)
8109         (classify_name, yylex): Update.
8110
8111 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8112
8113         * configure.ac: add --enable-source-highlight switch.
8114         * configure: Regenerate.
8115         * top.c (print_gdb_version): plumb --enable-source-highlight
8116         status to "show configuration".
8117
8118 2019-04-19  Tom Tromey  <tromey@adacore.com>
8119
8120         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8121         Check ADA_TYPE_P.
8122         (empty_record, ada_template_to_fixed_record_type_1)
8123         (template_to_static_fixed_type)
8124         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8125         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8126         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8127         macros.
8128
8129 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8130
8131         PR symtab/24423:
8132         * source.c (print_source_lines_base): Advance "iter" when a
8133         control character is seen.
8134
8135 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8136
8137         * inferior.h (struct infcall_suspend_state_deleter):
8138         Catch exception in destructor to avoid crash.
8139
8140 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8141
8142         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8143         close to the add_com "shell".
8144
8145 2019-04-18  Tom Tromey  <tromey@adacore.com>
8146
8147         * process-stratum-target.h (class process_stratum_target)
8148         <stratum>: Add "final".
8149
8150 2019-04-17  Tom Tromey  <tromey@adacore.com>
8151
8152         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8153         against nullptr before use.
8154
8155 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8156
8157         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8158
8159 2019-04-17  Jim Wilson  <jimw@sifive.com>
8160             Andrew Burgess  <andrew.burgess@embecosm.com>
8161
8162         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8163         code read might fail, assume 4-byte breakpoint in that case.
8164
8165 2019-04-15  Leszek Swirski  <leszeks@google.com>
8166
8167         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8168         rather than a hand-rolled POD check when checking for forced MEMORY
8169         classification.
8170
8171 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8172
8173         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8174         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8175         function.
8176         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8177         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8178         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8179         declaration.
8180
8181 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8182
8183         * aarch64-linux-nat.c
8184         (aarch64_linux_nat_target::thread_architecture): Add override.
8185         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8186         each VQ.
8187
8188 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8189
8190         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8191
8192 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8193
8194         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8195         target types of size 96-bits, add some additional comments, and
8196         check that the builtin type we found was the correct size.
8197
8198 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8199
8200         * utils.c (prompt_for_continue): Don't restore the styling at the
8201         end, as applied_style has the wrong value.  This fixes styling in
8202         long lists of file names that are interrupted by the "Continue?"
8203         prompt.
8204
8205 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8206
8207         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8208         * c-lang.c (c_language_defn): Likewise.
8209         (cplus_language_defn): Likewise.
8210         (asm_language_defn): Likewise.
8211         (minimal_language_defn): Likewise.
8212         * d-lang.c (d_language_defn): Likewise.
8213         * f-lang.c (f_language_defn): Likewise.
8214         * go-lang.c (go_language_defn): Likewise.
8215         * language.c (unknown_language_defn): Likewise.
8216         (auto_language_defn): Likewise.
8217         * language.h (struct language_defn): Remove la_magic field.
8218         (LANG_MAGIC): Delete.
8219         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8220         * objc-lang.c (objc_language_defn): Likewise.
8221         * opencl-lang.c (opencl_language_defn): Likewise.
8222         * p-lang.c (pascal_language_defn): Likewise.
8223         * rust-lang.c (rust_language_defn): Likewise.
8224
8225 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8226
8227         * riscv-tdep.c (riscv_type_align): New function.
8228         (riscv_type_alignment): Delete.
8229         (riscv_arg_location): Use 'type_align'.
8230         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8231
8232 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8233
8234         * gdbtypes.c (type_align): A struct with no non-static fields also
8235         has alignment of 1.
8236
8237 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8238
8239         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8240         component to 0.
8241         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8242         member.
8243         (riscv_struct_info::analyse): New implementation using new
8244         analyse_inner member function.
8245         (riscv_struct_info::field_offset): New member function.
8246         (riscv_struct_info::m_offsets): New member variable.
8247         (riscv_struct_info::analyse_inner): New private member function,
8248         takes the old implementation of riscv_struct_info::analyse but
8249         extended to track field offsets.
8250         (riscv_call_arg_struct): Update the struct folding special cases
8251         to handle cases where empty C++ structs, which are non-zero
8252         length, are found.
8253         (riscv_arg_location): Initialise the length of each location, a
8254         non-zero length now indicates the location is in use.
8255         (riscv_push_dummy_call): Allow for the first location having a
8256         non-zero offset when setting up arguments.
8257         (riscv_return_value): Likewise, but for return values.
8258
8259 2019-04-11  Tom Tromey  <tromey@adacore.com>
8260
8261         * utils.c (internal_vproblem): Make "msg" const.
8262
8263 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8264
8265         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8266         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8267         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8268         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8269
8270 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8271
8272         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8273         function.
8274         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8275         of amd64_collect_native_gregset.
8276         (amd64_linux_nat_target::store_registers): Likewise.
8277
8278 2019-04-10  Tom Tromey  <tom@tromey.com>
8279
8280         * symtab.c (lookup_global_symbol_from_objfile)
8281         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8282         * objfiles.h (class separate_debug_iterator): New.
8283         (class separate_debug_range): New.
8284         (struct objfile) <separate_debug_objfiles>: New method.
8285         (objfile_separate_debug_iterate): Don't declare.
8286         * objfiles.c (separate_debug_iterator::operator++): Rename from
8287         objfile_separate_debug_iterate.
8288         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8289         iterator.
8290         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8291         iterator.
8292
8293 2019-04-10  Tom Tromey  <tom@tromey.com>
8294
8295         * symfile.c (reread_symbols): Remove old comment.
8296         * objfiles.c (free_all_objfiles): Fix a typo.
8297
8298 2019-04-10  Tom Tromey  <tom@tromey.com>
8299
8300         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8301         * minsyms.c (lookup_minimal_symbol): Use foreach.
8302         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8303         (lookup_minimal_symbol_solib_trampoline): Likewise.
8304         * symfile.c (reread_symbols): Use foreach.
8305
8306 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8307             Tom Tromey  <tromey@adacore.com>
8308
8309         PR rust/24414:
8310         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8311         (rust_lex_int_test): Change "value" to be LONGEST.
8312         (rust_lex_tests): Add test for long integer literal.
8313
8314 2019-04-09  Tom Tromey  <tromey@adacore.com>
8315
8316         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8317         to bool.
8318         (extended_remote_target::attach): Update.
8319         (remote_target::remote_notice_new_inferior): Update.
8320         (remote_target::add_current_inferior_and_thread): Update.
8321         * inferior.c (exit_inferior_1): Use "false".
8322         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8323
8324 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8325
8326         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8327         the "start" command.
8328
8329 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8330
8331         * python/py-inferior.c (infpy_thread_from_thread_handle):
8332         Adjust comments to reflect renaming of thread_from_thread_handle
8333         to thread_from_handle.  Adjust keywords.  Fix type error message.
8334         (inferior_object_methods): Add thread_from_handle.  Retain
8335         thread_from_thread_handle, but mark it as deprecated.
8336
8337 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8338
8339         * gdbthread.h (find_thread_by_handle): Revise declaration.
8340         * thread.c (find_thread_by_handle): Likewise.  Adjust
8341         implementation too.
8342         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8343         support for buffer objects as handles.
8344
8345 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8346
8347         * python/py-infthread.c (thpy_thread_handle): New function.
8348         (thread_object_methods): Register thpy_thread_handle.
8349
8350 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8351
8352         * gdbthread.h (thread_to_thread_handle): Declare.
8353         * thread.c (gdbtypes.h): Include.
8354         (thread_to_thread_handle): New function.
8355
8356         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8357         (target_thread_info_to_thread_handle): Declare.
8358         * target.c (target_thread_info_to_thread_handle): New function.
8359         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8360         * target-delegates.c: Regenerate.
8361
8362         * linux-thread-db.c (class thread_db_target): Add method
8363         thread_info_to_thread_handle.
8364         (thread_db_target::thread_info_to_thread_handle): Define.
8365         * remote.c (class remote_target): Add new method
8366         thread_info_to_thread_handle.
8367         (remote_target::thread_info_to_thread_handle): Define.
8368
8369 2019-04-08  Pedro Alves  <palves@redhat.com>
8370
8371         * common/common-exceptions.c (throw_exception): Don't create
8372         named object to throw; throw directly.
8373         (throw_it): Likewise.  Don't initialize gdb_exception::message
8374         here, with new; pass FMT and AP to the ctor instead.
8375         * common/common-exceptions.h: Include <string>.
8376         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8377         const char *, va_list)): New ctor.  Use std::make_shared.
8378         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8379         errors)): Delete.
8380         (gdb_exception_error::gdb_exception_error(enum errors, const char
8381         *, va_list)): New.
8382         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8383         Add assertion.
8384         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8385         errors)): Delete.
8386         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8387         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8388         Add assertion.
8389
8390 2019-04-08  Tom Tromey  <tom@tromey.com>
8391
8392         * valops.c (value_rtti_indirect_type): Replace throw_exception
8393         with throw.
8394         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8395         with throw.
8396         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8397         throw.
8398         * target.c (target_translate_tls_address): Replace throw_exception
8399         with throw.
8400         * stack.c (frame_apply_command_count): Replace throw_exception
8401         with throw.
8402         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8403         throw.
8404         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8405         with throw.
8406         * rs6000-tdep.c (rs6000_frame_cache)
8407         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8408         * remote.c: Replace throw_exception with throw.
8409         * record-full.c (record_full_message, record_full_wait_1)
8410         (record_full_restore): Replace throw_exception with throw.
8411         * record-btrace.c:
8412         (get_thread_current_frame_id, record_btrace_start_replaying)
8413         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8414         (cmd_record_btrace_start): Replace throw_exception with throw.
8415         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8416         throw.
8417         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8418         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8419         * linespec.c:
8420         (find_linespec_symbols): Replace throw_exception with throw.
8421         * infrun.c (displaced_step_prepare, resume): Replace
8422         throw_exception with throw.
8423         * infcmd.c (post_create_inferior): Replace throw_exception with
8424         throw.
8425         * inf-loop.c (inferior_event_handler): Replace throw_exception
8426         with throw.
8427         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8428         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8429         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8430         (get_prev_frame_always, get_frame_pc_if_available)
8431         (get_frame_address_in_block_if_available, get_frame_language):
8432         Replace throw_exception with throw.
8433         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8434         throw_exception with throw.
8435         * eval.c (fetch_subexp_value, evaluate_var_value)
8436         (evaluate_funcall, evaluate_subexp_standard): Replace
8437         throw_exception with throw.
8438         * dwarf2loc.c (call_site_find_chain)
8439         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8440         Replace throw_exception with throw.
8441         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8442         with throw.
8443         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8444         throw.
8445         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8446         * completer.c (complete_line_internal): Replace throw_exception
8447         with throw.
8448         * compile/compile-object-run.c (compile_object_run): Replace
8449         throw_exception with throw.
8450         * cli/cli-script.c (process_next_line): Replace throw_exception
8451         with throw.
8452         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8453         (btrace_enable, btrace_maint_update_pt_packets): Replace
8454         throw_exception with throw.
8455         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8456         throw_exception with throw.
8457         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8458         throw_exception with throw.
8459         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8460         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8461         * aarch64-tdep.c (aarch64_make_prologue_cache)
8462         (aarch64_make_stub_cache): Replace throw_exception with throw.
8463
8464 2019-04-08  Tom Tromey  <tom@tromey.com>
8465
8466         * common/common-exceptions.c (throw_exception): Rename from
8467         throw_exception_cxx.  Remove old copy.  Make argument const.
8468         (throw_it): Create and throw exception objects directly.
8469         * common/common-exceptions.h (throw_exception): Make argument
8470         const.
8471         (struct gdb_exception_error): Add constructor.
8472         (struct gdb_exception_quit): Add constructor.
8473
8474 2019-04-08  Tom Tromey  <tom@tromey.com>
8475
8476         * common/common-exceptions.h (exception_rethrow): Don't declare.
8477         (TRY_SJLJ): Update comment.
8478         (TRY, CATCH, END_CATCH): Remove.
8479         * common/common-exceptions.c (exception_rethrow): Remove.
8480
8481 2019-04-08  Tom Tromey  <tom@tromey.com>
8482
8483         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8484         Remove.
8485         (gdb_exception_error): Rename from
8486         gdb_exception_RETURN_MASK_ERROR.
8487         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8488         (gdb_quit_bad_alloc): Update.
8489         * aarch64-tdep.c: Update.
8490         * ada-lang.c: Update.
8491         * ada-typeprint.c: Update.
8492         * ada-valprint.c: Update.
8493         * amd64-tdep.c: Update.
8494         * arch-utils.c: Update.
8495         * break-catch-throw.c: Update.
8496         * breakpoint.c: Update.
8497         * btrace.c: Update.
8498         * c-varobj.c: Update.
8499         * cli/cli-cmds.c: Update.
8500         * cli/cli-interp.c: Update.
8501         * cli/cli-script.c: Update.
8502         * common/common-exceptions.c: Update.
8503         * common/new-op.c: Update.
8504         * common/selftest.c: Update.
8505         * compile/compile-c-symbols.c: Update.
8506         * compile/compile-cplus-symbols.c: Update.
8507         * compile/compile-object-load.c: Update.
8508         * compile/compile-object-run.c: Update.
8509         * completer.c: Update.
8510         * corelow.c: Update.
8511         * cp-abi.c: Update.
8512         * cp-support.c: Update.
8513         * cp-valprint.c: Update.
8514         * darwin-nat.c: Update.
8515         * disasm-selftests.c: Update.
8516         * dtrace-probe.c: Update.
8517         * dwarf-index-cache.c: Update.
8518         * dwarf-index-write.c: Update.
8519         * dwarf2-frame-tailcall.c: Update.
8520         * dwarf2-frame.c: Update.
8521         * dwarf2loc.c: Update.
8522         * dwarf2read.c: Update.
8523         * eval.c: Update.
8524         * event-loop.c: Update.
8525         * event-top.c: Update.
8526         * exec.c: Update.
8527         * f-valprint.c: Update.
8528         * fbsd-tdep.c: Update.
8529         * frame-unwind.c: Update.
8530         * frame.c: Update.
8531         * gdbtypes.c: Update.
8532         * gnu-v3-abi.c: Update.
8533         * guile/guile-internal.h: Update.
8534         * guile/scm-block.c: Update.
8535         * guile/scm-breakpoint.c: Update.
8536         * guile/scm-cmd.c: Update.
8537         * guile/scm-disasm.c: Update.
8538         * guile/scm-frame.c: Update.
8539         * guile/scm-lazy-string.c: Update.
8540         * guile/scm-math.c: Update.
8541         * guile/scm-param.c: Update.
8542         * guile/scm-ports.c: Update.
8543         * guile/scm-pretty-print.c: Update.
8544         * guile/scm-symbol.c: Update.
8545         * guile/scm-symtab.c: Update.
8546         * guile/scm-type.c: Update.
8547         * guile/scm-value.c: Update.
8548         * i386-linux-tdep.c: Update.
8549         * i386-tdep.c: Update.
8550         * inf-loop.c: Update.
8551         * infcall.c: Update.
8552         * infcmd.c: Update.
8553         * infrun.c: Update.
8554         * jit.c: Update.
8555         * language.c: Update.
8556         * linespec.c: Update.
8557         * linux-fork.c: Update.
8558         * linux-nat.c: Update.
8559         * linux-tdep.c: Update.
8560         * linux-thread-db.c: Update.
8561         * main.c: Update.
8562         * mi/mi-cmd-break.c: Update.
8563         * mi/mi-cmd-stack.c: Update.
8564         * mi/mi-interp.c: Update.
8565         * mi/mi-main.c: Update.
8566         * objc-lang.c: Update.
8567         * p-valprint.c: Update.
8568         * parse.c: Update.
8569         * ppc-linux-tdep.c: Update.
8570         * printcmd.c: Update.
8571         * python/py-arch.c: Update.
8572         * python/py-breakpoint.c: Update.
8573         * python/py-cmd.c: Update.
8574         * python/py-finishbreakpoint.c: Update.
8575         * python/py-frame.c: Update.
8576         * python/py-framefilter.c: Update.
8577         * python/py-gdb-readline.c: Update.
8578         * python/py-inferior.c: Update.
8579         * python/py-infthread.c: Update.
8580         * python/py-lazy-string.c: Update.
8581         * python/py-linetable.c: Update.
8582         * python/py-objfile.c: Update.
8583         * python/py-param.c: Update.
8584         * python/py-prettyprint.c: Update.
8585         * python/py-progspace.c: Update.
8586         * python/py-record-btrace.c: Update.
8587         * python/py-record.c: Update.
8588         * python/py-symbol.c: Update.
8589         * python/py-type.c: Update.
8590         * python/py-unwind.c: Update.
8591         * python/py-utils.c: Update.
8592         * python/py-value.c: Update.
8593         * python/python.c: Update.
8594         * record-btrace.c: Update.
8595         * record-full.c: Update.
8596         * remote-fileio.c: Update.
8597         * remote.c: Update.
8598         * riscv-tdep.c: Update.
8599         * rs6000-aix-tdep.c: Update.
8600         * rs6000-tdep.c: Update.
8601         * rust-exp.y: Update.
8602         * rust-lang.c: Update.
8603         * s390-tdep.c: Update.
8604         * selftest-arch.c: Update.
8605         * solib-dsbt.c: Update.
8606         * solib-frv.c: Update.
8607         * solib-spu.c: Update.
8608         * solib-svr4.c: Update.
8609         * solib.c: Update.
8610         * sparc64-linux-tdep.c: Update.
8611         * stack.c: Update.
8612         * symfile-mem.c: Update.
8613         * symmisc.c: Update.
8614         * target.c: Update.
8615         * thread.c: Update.
8616         * top.c: Update.
8617         * tracefile-tfile.c: Update.
8618         * tui/tui.c: Update.
8619         * typeprint.c: Update.
8620         * unittests/cli-utils-selftests.c: Update.
8621         * unittests/parse-connection-spec-selftests.c: Update.
8622         * valops.c: Update.
8623         * valprint.c: Update.
8624         * value.c: Update.
8625         * varobj.c: Update.
8626         * windows-nat.c: Update.
8627         * x86-linux-nat.c: Update.
8628         * xml-support.c: Update.
8629
8630 2019-04-08  Tom Tromey  <tom@tromey.com>
8631
8632         * xml-support.c: Use C++ exception handling.
8633         * x86-linux-nat.c: Use C++ exception handling.
8634         * windows-nat.c: Use C++ exception handling.
8635         * varobj.c: Use C++ exception handling.
8636         * value.c: Use C++ exception handling.
8637         * valprint.c: Use C++ exception handling.
8638         * valops.c: Use C++ exception handling.
8639         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8640         handling.
8641         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8642         * typeprint.c: Use C++ exception handling.
8643         * tui/tui.c: Use C++ exception handling.
8644         * tracefile-tfile.c: Use C++ exception handling.
8645         * top.c: Use C++ exception handling.
8646         * thread.c: Use C++ exception handling.
8647         * target.c: Use C++ exception handling.
8648         * symmisc.c: Use C++ exception handling.
8649         * symfile-mem.c: Use C++ exception handling.
8650         * stack.c: Use C++ exception handling.
8651         * sparc64-linux-tdep.c: Use C++ exception handling.
8652         * solib.c: Use C++ exception handling.
8653         * solib-svr4.c: Use C++ exception handling.
8654         * solib-spu.c: Use C++ exception handling.
8655         * solib-frv.c: Use C++ exception handling.
8656         * solib-dsbt.c: Use C++ exception handling.
8657         * selftest-arch.c: Use C++ exception handling.
8658         * s390-tdep.c: Use C++ exception handling.
8659         * rust-lang.c: Use C++ exception handling.
8660         * rust-exp.y: Use C++ exception handling.
8661         * rs6000-tdep.c: Use C++ exception handling.
8662         * rs6000-aix-tdep.c: Use C++ exception handling.
8663         * riscv-tdep.c: Use C++ exception handling.
8664         * remote.c: Use C++ exception handling.
8665         * remote-fileio.c: Use C++ exception handling.
8666         * record-full.c: Use C++ exception handling.
8667         * record-btrace.c: Use C++ exception handling.
8668         * python/python.c: Use C++ exception handling.
8669         * python/py-value.c: Use C++ exception handling.
8670         * python/py-utils.c: Use C++ exception handling.
8671         * python/py-unwind.c: Use C++ exception handling.
8672         * python/py-type.c: Use C++ exception handling.
8673         * python/py-symbol.c: Use C++ exception handling.
8674         * python/py-record.c: Use C++ exception handling.
8675         * python/py-record-btrace.c: Use C++ exception handling.
8676         * python/py-progspace.c: Use C++ exception handling.
8677         * python/py-prettyprint.c: Use C++ exception handling.
8678         * python/py-param.c: Use C++ exception handling.
8679         * python/py-objfile.c: Use C++ exception handling.
8680         * python/py-linetable.c: Use C++ exception handling.
8681         * python/py-lazy-string.c: Use C++ exception handling.
8682         * python/py-infthread.c: Use C++ exception handling.
8683         * python/py-inferior.c: Use C++ exception handling.
8684         * python/py-gdb-readline.c: Use C++ exception handling.
8685         * python/py-framefilter.c: Use C++ exception handling.
8686         * python/py-frame.c: Use C++ exception handling.
8687         * python/py-finishbreakpoint.c: Use C++ exception handling.
8688         * python/py-cmd.c: Use C++ exception handling.
8689         * python/py-breakpoint.c: Use C++ exception handling.
8690         * python/py-arch.c: Use C++ exception handling.
8691         * printcmd.c: Use C++ exception handling.
8692         * ppc-linux-tdep.c: Use C++ exception handling.
8693         * parse.c: Use C++ exception handling.
8694         * p-valprint.c: Use C++ exception handling.
8695         * objc-lang.c: Use C++ exception handling.
8696         * mi/mi-main.c: Use C++ exception handling.
8697         * mi/mi-interp.c: Use C++ exception handling.
8698         * mi/mi-cmd-stack.c: Use C++ exception handling.
8699         * mi/mi-cmd-break.c: Use C++ exception handling.
8700         * main.c: Use C++ exception handling.
8701         * linux-thread-db.c: Use C++ exception handling.
8702         * linux-tdep.c: Use C++ exception handling.
8703         * linux-nat.c: Use C++ exception handling.
8704         * linux-fork.c: Use C++ exception handling.
8705         * linespec.c: Use C++ exception handling.
8706         * language.c: Use C++ exception handling.
8707         * jit.c: Use C++ exception handling.
8708         * infrun.c: Use C++ exception handling.
8709         * infcmd.c: Use C++ exception handling.
8710         * infcall.c: Use C++ exception handling.
8711         * inf-loop.c: Use C++ exception handling.
8712         * i386-tdep.c: Use C++ exception handling.
8713         * i386-linux-tdep.c: Use C++ exception handling.
8714         * guile/scm-value.c: Use C++ exception handling.
8715         * guile/scm-type.c: Use C++ exception handling.
8716         * guile/scm-symtab.c: Use C++ exception handling.
8717         * guile/scm-symbol.c: Use C++ exception handling.
8718         * guile/scm-pretty-print.c: Use C++ exception handling.
8719         * guile/scm-ports.c: Use C++ exception handling.
8720         * guile/scm-param.c: Use C++ exception handling.
8721         * guile/scm-math.c: Use C++ exception handling.
8722         * guile/scm-lazy-string.c: Use C++ exception handling.
8723         * guile/scm-frame.c: Use C++ exception handling.
8724         * guile/scm-disasm.c: Use C++ exception handling.
8725         * guile/scm-cmd.c: Use C++ exception handling.
8726         * guile/scm-breakpoint.c: Use C++ exception handling.
8727         * guile/scm-block.c: Use C++ exception handling.
8728         * guile/guile-internal.h: Use C++ exception handling.
8729         * gnu-v3-abi.c: Use C++ exception handling.
8730         * gdbtypes.c: Use C++ exception handling.
8731         * frame.c: Use C++ exception handling.
8732         * frame-unwind.c: Use C++ exception handling.
8733         * fbsd-tdep.c: Use C++ exception handling.
8734         * f-valprint.c: Use C++ exception handling.
8735         * exec.c: Use C++ exception handling.
8736         * event-top.c: Use C++ exception handling.
8737         * event-loop.c: Use C++ exception handling.
8738         * eval.c: Use C++ exception handling.
8739         * dwarf2read.c: Use C++ exception handling.
8740         * dwarf2loc.c: Use C++ exception handling.
8741         * dwarf2-frame.c: Use C++ exception handling.
8742         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8743         * dwarf-index-write.c: Use C++ exception handling.
8744         * dwarf-index-cache.c: Use C++ exception handling.
8745         * dtrace-probe.c: Use C++ exception handling.
8746         * disasm-selftests.c: Use C++ exception handling.
8747         * darwin-nat.c: Use C++ exception handling.
8748         * cp-valprint.c: Use C++ exception handling.
8749         * cp-support.c: Use C++ exception handling.
8750         * cp-abi.c: Use C++ exception handling.
8751         * corelow.c: Use C++ exception handling.
8752         * completer.c: Use C++ exception handling.
8753         * compile/compile-object-run.c: Use C++ exception handling.
8754         * compile/compile-object-load.c: Use C++ exception handling.
8755         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8756         * compile/compile-c-symbols.c: Use C++ exception handling.
8757         * common/selftest.c: Use C++ exception handling.
8758         * common/new-op.c: Use C++ exception handling.
8759         * cli/cli-script.c: Use C++ exception handling.
8760         * cli/cli-interp.c: Use C++ exception handling.
8761         * cli/cli-cmds.c: Use C++ exception handling.
8762         * c-varobj.c: Use C++ exception handling.
8763         * btrace.c: Use C++ exception handling.
8764         * breakpoint.c: Use C++ exception handling.
8765         * break-catch-throw.c: Use C++ exception handling.
8766         * arch-utils.c: Use C++ exception handling.
8767         * amd64-tdep.c: Use C++ exception handling.
8768         * ada-valprint.c: Use C++ exception handling.
8769         * ada-typeprint.c: Use C++ exception handling.
8770         * ada-lang.c: Use C++ exception handling.
8771         * aarch64-tdep.c: Use C++ exception handling.
8772
8773 2019-04-08  Tom Tromey  <tom@tromey.com>
8774
8775         * xml-support.c (gdb_xml_parser::parse): Update.
8776         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8777         * value.c (show_convenience): Update.
8778         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8779         (test_parse_flags_qcs): Update.
8780         * thread.c (thr_try_catch_cmd): Update.
8781         * target.c (target_translate_tls_address): Update.
8782         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8783         (info_frame_command_core, frame_apply_command_count): Update.
8784         * rust-exp.y (rust_lex_exception_test): Update.
8785         * riscv-tdep.c (riscv_print_one_register_info): Update.
8786         * remote.c (remote_target::enable_btrace): Update.
8787         * record-btrace.c (record_btrace_enable_warn): Update.
8788         * python/py-utils.c (gdbpy_convert_exception): Update.
8789         * printcmd.c (do_one_display, print_variable_and_value): Update.
8790         * mi/mi-main.c (mi_print_exception): Update.
8791         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8792         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8793         * linux-nat.c (linux_nat_target::attach): Update.
8794         * linux-fork.c (class scoped_switch_fork_info): Update.
8795         * infrun.c (displaced_step_prepare): Update.
8796         * infcall.c (call_function_by_hand_dummy): Update.
8797         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8798         * gnu-v3-abi.c (print_one_vtable): Update.
8799         * frame.c (get_prev_frame_always): Update.
8800         * f-valprint.c (info_common_command_for_block): Update.
8801         * exec.c (try_open_exec_file): Update.
8802         * exceptions.c (print_exception, exception_print)
8803         (exception_fprintf, exception_print_same): Update.
8804         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8805         * dwarf-index-cache.c (index_cache::store)
8806         (index_cache::lookup_gdb_index): Update.
8807         * darwin-nat.c (maybe_cache_shell): Update.
8808         * cp-valprint.c (cp_print_value_fields): Update.
8809         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8810         (gcc_cplus_symbol_address): Update.
8811         * compile/compile-c-symbols.c (gcc_convert_symbol)
8812         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8813         * common/selftest.c: Update.
8814         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8815         a std::string.
8816         (exception_try_scope_entry, exception_try_scope_exit): Don't
8817         declare.
8818         (struct exception_try_scope): Remove.
8819         (TRY): Don't use exception_try_scope.
8820         (struct gdb_exception): Add constructor, operator=.
8821         <what>: New method.
8822         (struct gdb_exception_RETURN_MASK_ALL)
8823         (struct gdb_exception_RETURN_MASK_ERROR)
8824         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8825         (struct gdb_quit_bad_alloc): Update.
8826         * common/common-exceptions.c (exception_none): Change
8827         initializer.
8828         (struct catcher) <state, exception>: Initialize inline.
8829         <prev>: Remove member.
8830         (current_catcher): Remove.
8831         (catchers): New global.
8832         (exceptions_state_mc_init): Simplify.
8833         (catcher_pop): Remove.
8834         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8835         (try_scope_depth, exception_try_scope_entry)
8836         (exception_try_scope_exit): Remove.
8837         (throw_exception_sjlj): Update.
8838         (exception_messages, exception_messages_size): Remove.
8839         (throw_it): Simplify.
8840         (gdb_exception_sliced_copy): Remove.
8841         (throw_exception_cxx): Update.
8842         * cli/cli-script.c (script_from_file): Update.
8843         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8844         Update.
8845         * ada-valprint.c (ada_val_print): Update.
8846         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8847         (create_excep_cond_exprs): Update.
8848
8849 2019-04-08  Tom Tromey  <tom@tromey.com>
8850
8851         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8852         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8853         (TRY, CATCH, END_CATCH): Remove some definitions.
8854         * common/common-exceptions.c: Don't use GDB_XCPT.
8855         (catcher_list_size): Remove.
8856         (throw_exception, throw_it): Simplify.
8857
8858 2019-04-05  Tom Tromey  <tom@tromey.com>
8859
8860         Revert the header-sorting patch.
8861         * ft32-tdep.c: Revert.
8862         * frv-tdep.c: Revert.
8863         * frv-linux-tdep.c: Revert.
8864         * frame.c: Revert.
8865         * frame-unwind.c: Revert.
8866         * frame-base.c: Revert.
8867         * fork-child.c: Revert.
8868         * findvar.c: Revert.
8869         * findcmd.c: Revert.
8870         * filesystem.c: Revert.
8871         * filename-seen-cache.h: Revert.
8872         * filename-seen-cache.c: Revert.
8873         * fbsd-tdep.c: Revert.
8874         * fbsd-nat.h: Revert.
8875         * fbsd-nat.c: Revert.
8876         * f-valprint.c: Revert.
8877         * f-typeprint.c: Revert.
8878         * f-lang.c: Revert.
8879         * extension.h: Revert.
8880         * extension.c: Revert.
8881         * extension-priv.h: Revert.
8882         * expprint.c: Revert.
8883         * exec.h: Revert.
8884         * exec.c: Revert.
8885         * exceptions.c: Revert.
8886         * event-top.c: Revert.
8887         * event-loop.c: Revert.
8888         * eval.c: Revert.
8889         * elfread.c: Revert.
8890         * dwarf2read.h: Revert.
8891         * dwarf2read.c: Revert.
8892         * dwarf2loc.c: Revert.
8893         * dwarf2expr.h: Revert.
8894         * dwarf2expr.c: Revert.
8895         * dwarf2-frame.c: Revert.
8896         * dwarf2-frame-tailcall.c: Revert.
8897         * dwarf-index-write.h: Revert.
8898         * dwarf-index-write.c: Revert.
8899         * dwarf-index-common.c: Revert.
8900         * dwarf-index-cache.h: Revert.
8901         * dwarf-index-cache.c: Revert.
8902         * dummy-frame.c: Revert.
8903         * dtrace-probe.c: Revert.
8904         * disasm.h: Revert.
8905         * disasm.c: Revert.
8906         * disasm-selftests.c: Revert.
8907         * dictionary.c: Revert.
8908         * dicos-tdep.c: Revert.
8909         * demangle.c: Revert.
8910         * dcache.h: Revert.
8911         * dcache.c: Revert.
8912         * darwin-nat.h: Revert.
8913         * darwin-nat.c: Revert.
8914         * darwin-nat-info.c: Revert.
8915         * d-valprint.c: Revert.
8916         * d-namespace.c: Revert.
8917         * d-lang.c: Revert.
8918         * ctf.c: Revert.
8919         * csky-tdep.c: Revert.
8920         * csky-linux-tdep.c: Revert.
8921         * cris-tdep.c: Revert.
8922         * cris-linux-tdep.c: Revert.
8923         * cp-valprint.c: Revert.
8924         * cp-support.c: Revert.
8925         * cp-namespace.c: Revert.
8926         * cp-abi.c: Revert.
8927         * corelow.c: Revert.
8928         * corefile.c: Revert.
8929         * continuations.c: Revert.
8930         * completer.h: Revert.
8931         * completer.c: Revert.
8932         * complaints.c: Revert.
8933         * coffread.c: Revert.
8934         * coff-pe-read.c: Revert.
8935         * cli-out.h: Revert.
8936         * cli-out.c: Revert.
8937         * charset.c: Revert.
8938         * c-varobj.c: Revert.
8939         * c-valprint.c: Revert.
8940         * c-typeprint.c: Revert.
8941         * c-lang.c: Revert.
8942         * buildsym.c: Revert.
8943         * buildsym-legacy.c: Revert.
8944         * build-id.h: Revert.
8945         * build-id.c: Revert.
8946         * btrace.c: Revert.
8947         * bsd-uthread.c: Revert.
8948         * breakpoint.h: Revert.
8949         * breakpoint.c: Revert.
8950         * break-catch-throw.c: Revert.
8951         * break-catch-syscall.c: Revert.
8952         * break-catch-sig.c: Revert.
8953         * blockframe.c: Revert.
8954         * block.c: Revert.
8955         * bfin-tdep.c: Revert.
8956         * bfin-linux-tdep.c: Revert.
8957         * bfd-target.c: Revert.
8958         * bcache.c: Revert.
8959         * ax-general.c: Revert.
8960         * ax-gdb.h: Revert.
8961         * ax-gdb.c: Revert.
8962         * avr-tdep.c: Revert.
8963         * auxv.c: Revert.
8964         * auto-load.c: Revert.
8965         * arm-wince-tdep.c: Revert.
8966         * arm-tdep.c: Revert.
8967         * arm-symbian-tdep.c: Revert.
8968         * arm-pikeos-tdep.c: Revert.
8969         * arm-obsd-tdep.c: Revert.
8970         * arm-nbsd-tdep.c: Revert.
8971         * arm-nbsd-nat.c: Revert.
8972         * arm-linux-tdep.c: Revert.
8973         * arm-linux-nat.c: Revert.
8974         * arm-fbsd-tdep.c: Revert.
8975         * arm-fbsd-nat.c: Revert.
8976         * arm-bsd-tdep.c: Revert.
8977         * arch-utils.c: Revert.
8978         * arc-tdep.c: Revert.
8979         * arc-newlib-tdep.c: Revert.
8980         * annotate.h: Revert.
8981         * annotate.c: Revert.
8982         * amd64-windows-tdep.c: Revert.
8983         * amd64-windows-nat.c: Revert.
8984         * amd64-tdep.c: Revert.
8985         * amd64-sol2-tdep.c: Revert.
8986         * amd64-obsd-tdep.c: Revert.
8987         * amd64-obsd-nat.c: Revert.
8988         * amd64-nbsd-tdep.c: Revert.
8989         * amd64-nbsd-nat.c: Revert.
8990         * amd64-nat.c: Revert.
8991         * amd64-linux-tdep.c: Revert.
8992         * amd64-linux-nat.c: Revert.
8993         * amd64-fbsd-tdep.c: Revert.
8994         * amd64-fbsd-nat.c: Revert.
8995         * amd64-dicos-tdep.c: Revert.
8996         * amd64-darwin-tdep.c: Revert.
8997         * amd64-bsd-nat.c: Revert.
8998         * alpha-tdep.c: Revert.
8999         * alpha-obsd-tdep.c: Revert.
9000         * alpha-nbsd-tdep.c: Revert.
9001         * alpha-mdebug-tdep.c: Revert.
9002         * alpha-linux-tdep.c: Revert.
9003         * alpha-linux-nat.c: Revert.
9004         * alpha-bsd-tdep.c: Revert.
9005         * alpha-bsd-nat.c: Revert.
9006         * aix-thread.c: Revert.
9007         * agent.c: Revert.
9008         * addrmap.c: Revert.
9009         * ada-varobj.c: Revert.
9010         * ada-valprint.c: Revert.
9011         * ada-typeprint.c: Revert.
9012         * ada-tasks.c: Revert.
9013         * ada-lang.c: Revert.
9014         * aarch64-tdep.c: Revert.
9015         * aarch64-ravenscar-thread.c: Revert.
9016         * aarch64-newlib-tdep.c: Revert.
9017         * aarch64-linux-tdep.c: Revert.
9018         * aarch64-linux-nat.c: Revert.
9019         * aarch64-fbsd-tdep.c: Revert.
9020         * aarch64-fbsd-nat.c: Revert.
9021         * aarch32-linux-nat.c: Revert.
9022
9023 2019-04-05  Tom Tromey  <tom@tromey.com>
9024
9025         * ft32-tdep.c: Sort headers.
9026         * frv-tdep.c: Sort headers.
9027         * frv-linux-tdep.c: Sort headers.
9028         * frame.c: Sort headers.
9029         * frame-unwind.c: Sort headers.
9030         * frame-base.c: Sort headers.
9031         * fork-child.c: Sort headers.
9032         * findvar.c: Sort headers.
9033         * findcmd.c: Sort headers.
9034         * filesystem.c: Sort headers.
9035         * filename-seen-cache.h: Sort headers.
9036         * filename-seen-cache.c: Sort headers.
9037         * fbsd-tdep.c: Sort headers.
9038         * fbsd-nat.h: Sort headers.
9039         * fbsd-nat.c: Sort headers.
9040         * f-valprint.c: Sort headers.
9041         * f-typeprint.c: Sort headers.
9042         * f-lang.c: Sort headers.
9043         * extension.h: Sort headers.
9044         * extension.c: Sort headers.
9045         * extension-priv.h: Sort headers.
9046         * expprint.c: Sort headers.
9047         * exec.h: Sort headers.
9048         * exec.c: Sort headers.
9049         * exceptions.c: Sort headers.
9050         * event-top.c: Sort headers.
9051         * event-loop.c: Sort headers.
9052         * eval.c: Sort headers.
9053         * elfread.c: Sort headers.
9054         * dwarf2read.h: Sort headers.
9055         * dwarf2read.c: Sort headers.
9056         * dwarf2loc.c: Sort headers.
9057         * dwarf2expr.h: Sort headers.
9058         * dwarf2expr.c: Sort headers.
9059         * dwarf2-frame.c: Sort headers.
9060         * dwarf2-frame-tailcall.c: Sort headers.
9061         * dwarf-index-write.h: Sort headers.
9062         * dwarf-index-write.c: Sort headers.
9063         * dwarf-index-common.c: Sort headers.
9064         * dwarf-index-cache.h: Sort headers.
9065         * dwarf-index-cache.c: Sort headers.
9066         * dummy-frame.c: Sort headers.
9067         * dtrace-probe.c: Sort headers.
9068         * disasm.h: Sort headers.
9069         * disasm.c: Sort headers.
9070         * disasm-selftests.c: Sort headers.
9071         * dictionary.c: Sort headers.
9072         * dicos-tdep.c: Sort headers.
9073         * demangle.c: Sort headers.
9074         * dcache.h: Sort headers.
9075         * dcache.c: Sort headers.
9076         * darwin-nat.h: Sort headers.
9077         * darwin-nat.c: Sort headers.
9078         * darwin-nat-info.c: Sort headers.
9079         * d-valprint.c: Sort headers.
9080         * d-namespace.c: Sort headers.
9081         * d-lang.c: Sort headers.
9082         * ctf.c: Sort headers.
9083         * csky-tdep.c: Sort headers.
9084         * csky-linux-tdep.c: Sort headers.
9085         * cris-tdep.c: Sort headers.
9086         * cris-linux-tdep.c: Sort headers.
9087         * cp-valprint.c: Sort headers.
9088         * cp-support.c: Sort headers.
9089         * cp-namespace.c: Sort headers.
9090         * cp-abi.c: Sort headers.
9091         * corelow.c: Sort headers.
9092         * corefile.c: Sort headers.
9093         * continuations.c: Sort headers.
9094         * completer.h: Sort headers.
9095         * completer.c: Sort headers.
9096         * complaints.c: Sort headers.
9097         * coffread.c: Sort headers.
9098         * coff-pe-read.c: Sort headers.
9099         * cli-out.h: Sort headers.
9100         * cli-out.c: Sort headers.
9101         * charset.c: Sort headers.
9102         * c-varobj.c: Sort headers.
9103         * c-valprint.c: Sort headers.
9104         * c-typeprint.c: Sort headers.
9105         * c-lang.c: Sort headers.
9106         * buildsym.c: Sort headers.
9107         * buildsym-legacy.c: Sort headers.
9108         * build-id.h: Sort headers.
9109         * build-id.c: Sort headers.
9110         * btrace.c: Sort headers.
9111         * bsd-uthread.c: Sort headers.
9112         * breakpoint.h: Sort headers.
9113         * breakpoint.c: Sort headers.
9114         * break-catch-throw.c: Sort headers.
9115         * break-catch-syscall.c: Sort headers.
9116         * break-catch-sig.c: Sort headers.
9117         * blockframe.c: Sort headers.
9118         * block.c: Sort headers.
9119         * bfin-tdep.c: Sort headers.
9120         * bfin-linux-tdep.c: Sort headers.
9121         * bfd-target.c: Sort headers.
9122         * bcache.c: Sort headers.
9123         * ax-general.c: Sort headers.
9124         * ax-gdb.h: Sort headers.
9125         * ax-gdb.c: Sort headers.
9126         * avr-tdep.c: Sort headers.
9127         * auxv.c: Sort headers.
9128         * auto-load.c: Sort headers.
9129         * arm-wince-tdep.c: Sort headers.
9130         * arm-tdep.c: Sort headers.
9131         * arm-symbian-tdep.c: Sort headers.
9132         * arm-pikeos-tdep.c: Sort headers.
9133         * arm-obsd-tdep.c: Sort headers.
9134         * arm-nbsd-tdep.c: Sort headers.
9135         * arm-nbsd-nat.c: Sort headers.
9136         * arm-linux-tdep.c: Sort headers.
9137         * arm-linux-nat.c: Sort headers.
9138         * arm-fbsd-tdep.c: Sort headers.
9139         * arm-fbsd-nat.c: Sort headers.
9140         * arm-bsd-tdep.c: Sort headers.
9141         * arch-utils.c: Sort headers.
9142         * arc-tdep.c: Sort headers.
9143         * arc-newlib-tdep.c: Sort headers.
9144         * annotate.h: Sort headers.
9145         * annotate.c: Sort headers.
9146         * amd64-windows-tdep.c: Sort headers.
9147         * amd64-windows-nat.c: Sort headers.
9148         * amd64-tdep.c: Sort headers.
9149         * amd64-sol2-tdep.c: Sort headers.
9150         * amd64-obsd-tdep.c: Sort headers.
9151         * amd64-obsd-nat.c: Sort headers.
9152         * amd64-nbsd-tdep.c: Sort headers.
9153         * amd64-nbsd-nat.c: Sort headers.
9154         * amd64-nat.c: Sort headers.
9155         * amd64-linux-tdep.c: Sort headers.
9156         * amd64-linux-nat.c: Sort headers.
9157         * amd64-fbsd-tdep.c: Sort headers.
9158         * amd64-fbsd-nat.c: Sort headers.
9159         * amd64-dicos-tdep.c: Sort headers.
9160         * amd64-darwin-tdep.c: Sort headers.
9161         * amd64-bsd-nat.c: Sort headers.
9162         * alpha-tdep.c: Sort headers.
9163         * alpha-obsd-tdep.c: Sort headers.
9164         * alpha-nbsd-tdep.c: Sort headers.
9165         * alpha-mdebug-tdep.c: Sort headers.
9166         * alpha-linux-tdep.c: Sort headers.
9167         * alpha-linux-nat.c: Sort headers.
9168         * alpha-bsd-tdep.c: Sort headers.
9169         * alpha-bsd-nat.c: Sort headers.
9170         * aix-thread.c: Sort headers.
9171         * agent.c: Sort headers.
9172         * addrmap.c: Sort headers.
9173         * ada-varobj.c: Sort headers.
9174         * ada-valprint.c: Sort headers.
9175         * ada-typeprint.c: Sort headers.
9176         * ada-tasks.c: Sort headers.
9177         * ada-lang.c: Sort headers.
9178         * aarch64-tdep.c: Sort headers.
9179         * aarch64-ravenscar-thread.c: Sort headers.
9180         * aarch64-newlib-tdep.c: Sort headers.
9181         * aarch64-linux-tdep.c: Sort headers.
9182         * aarch64-linux-nat.c: Sort headers.
9183         * aarch64-fbsd-tdep.c: Sort headers.
9184         * aarch64-fbsd-nat.c: Sort headers.
9185         * aarch32-linux-nat.c: Sort headers.
9186
9187 2019-04-04  Tom Tromey  <tom@tromey.com>
9188
9189         * varobj.c (varobj_create): Update.
9190         * rust-exp.y (struct rust_parser) <update_innermost_block,
9191         lookup_symbol>: New methods.
9192         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9193         Rename.
9194         (rust_parser::rust_lookup_type)
9195         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9196         * printcmd.c (display_command, do_one_display): Update.
9197         * parser-defs.h (struct parser_state) <parser_state>: Add
9198         "tracker" parameter.
9199         (block_tracker): New member.
9200         (class innermost_block_tracker) <innermost_block_tracker>: Add
9201         "types" parameter.
9202         <reset>: Remove method.
9203         (innermost_block): Don't declare.
9204         (null_post_parser): Update.
9205         * parse.c (innermost_block): Remove global.
9206         (write_dollar_variable): Update.
9207         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9208         Remove "tracker_types" parameter.
9209         (parse_expression): Add "tracker" parameter.
9210         (parse_expression_for_completion): Update.
9211         (null_post_parser): Add "tracker" parameter.
9212         * p-exp.y: Update rules.
9213         * m2-exp.y: Update rules.
9214         * language.h (struct language_defn) <la_post_parser>: Add
9215         "tracker" parameter.
9216         * go-exp.y: Update rules.
9217         * f-exp.y: Update rules.
9218         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9219         parameter.
9220         * d-exp.y: Update rules.
9221         * c-exp.y: Update rules.
9222         * breakpoint.c (set_breakpoint_condition): Create an
9223         innermost_block_tracker.
9224         (watch_command_1): Likewise.
9225         * ada-lang.c (resolve): Add "tracker" parameter.
9226         (resolve_subexp): Likewise.
9227         * ada-exp.y (write_var_from_sym): Update.
9228
9229 2019-04-04  Tom Tromey  <tom@tromey.com>
9230
9231         * type-stack.h: New file.
9232         * type-stack.c: New file.
9233         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9234         type-stack.h.
9235         (insert_into_type_stack, insert_type, push_type, push_type_int)
9236         (insert_type_address_space, pop_type, pop_type_int)
9237         (pop_typelist, pop_type_stack, append_type_stack)
9238         (push_type_stack, get_type_stack, push_typelist)
9239         (follow_type_instance_flags, follow_types): Don't declare.
9240         * parse.c (type_stack): Remove global.
9241         (parse_exp_in_context): Update.
9242         (insert_into_type_stack, insert_type, push_type, push_type_int)
9243         (insert_type_address_space, pop_type, pop_type_int)
9244         (pop_typelist, pop_type_stack, append_type_stack)
9245         (push_type_stack, get_type_stack, push_typelist)
9246         (follow_type_instance_flags, follow_types): Remove (moved to
9247         type-stack.c).
9248         * f-exp.y (type_stack): New global.
9249         Update rules.
9250         (push_kind_type, f_parse): Update.
9251         * d-exp.y (type_stack): New global.
9252         Update rules.
9253         (d_parse): Update.
9254         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9255         Update rules.
9256         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9257         (HFILES_NO_SRCDIR): Add type-stack.h.
9258
9259 2019-04-04  Tom Tromey  <tom@tromey.com>
9260
9261         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9262         (rust_parser::convert_ast_to_expression, rust_parse)
9263         (rust_lex_test_completion, rust_lex_tests): Update.
9264         * parser-defs.h (struct expr_completion_state): New.
9265         (struct parser_state) <parser_state>: Add completion parameter.
9266         <mark_struct_expression, mark_completion_tag>: New methods.
9267         <parse_completion, m_completion_state>: New members.
9268         (prefixify_expression, null_post_parser): Update.
9269         (mark_struct_expression, mark_completion_tag): Don't declare.
9270         * parse.c (parse_completion, expout_last_struct)
9271         (expout_tag_completion_type, expout_completion_name): Remove
9272         globals.
9273         (parser_state::mark_struct_expression)
9274         (parser_state::mark_completion_tag): Now methods.
9275         (prefixify_expression): Add last_struct parameter.
9276         (prefixify_subexp): Likewise.
9277         (parse_exp_1): Update.
9278         (parse_exp_in_context): Add cstate parameter.  Update.
9279         (parse_expression_for_completion): Create an
9280         expr_completion_state.
9281         (null_post_parser): Add "completion" parameter.
9282         * p-exp.y: Update rules.
9283         (yylex): Update.
9284         * language.h (struct language_defn) <la_post_parser>: Add
9285         "completing" parameter.
9286         * go-exp.y: Update rules.
9287         (lex_one_token): Update.
9288         * expression.h (parse_completion): Don't declare.
9289         * d-exp.y: Update rules.
9290         (lex_one_token): Update rules.
9291         * c-exp.y: Update rules.
9292         (lex_one_token): Update.
9293         * ada-lang.c (resolve): Add "parse_completion" parameter.
9294         (resolve_subexp): Likewise.
9295         (ada_resolve_function): Likewise.
9296
9297 2019-04-04  Tom Tromey  <tom@tromey.com>
9298
9299         * parser-defs.h (struct parser_state) <start_arglist,
9300         end_arglist>: New methods.
9301         <arglist_len, m_funcall_chain>: New members.
9302         (arglist_len, start_arglist, end_arglist): Don't declare.
9303         * parse.c (arglist_len, funcall_chain): Remove global.
9304         (start_arglist, end_arglist): Remove functions.
9305         (parse_exp_in_context): Update.
9306         * p-exp.y: Update rules.
9307         * m2-exp.y: Update rules.
9308         * go-exp.y: Update rules.
9309         * f-exp.y: Update rules.
9310         * d-exp.y: Update rules.
9311         * c-exp.y: Update rules.
9312
9313 2019-04-04  Tom Tromey  <tom@tromey.com>
9314
9315         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9316         lex_operator, push_back>: New methods.
9317         Update all rules.
9318         (rust_parser::lex_hex, lex_escape): Rename and update.
9319         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9320         (rust_parser::lex_operator): Rename and update.
9321         (rust_parser::lex_number, rustyylex, rustyyerror)
9322         (rust_lex_test_init, rust_lex_test_sequence)
9323         (rust_lex_test_push_back, rust_lex_tests): Update.
9324         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9325         parameter.
9326         <lexptr, prev_lexptr>: New members.
9327         (lexptr, prev_lexptr): Don't declare.
9328         * parse.c (lexptr, prev_lexptr): Remove globals.
9329         (parse_exp_in_context): Update.
9330         * p-exp.y (yylex, yyerror): Update.
9331         * m2-exp.y (parse_number, yylex, yyerror): Update.
9332         * go-exp.y (lex_one_token, yyerror): Update.
9333         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9334         * d-exp.y (lex_one_token, yyerror): Update.
9335         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9336         (lex_one_token, yyerror): Update.
9337         * ada-lex.l (YY_INPUT): Update.
9338         (rewind_to_char): Update.
9339         * ada-exp.y (yyerror): Update.
9340
9341 2019-04-04  Tom Tromey  <tom@tromey.com>
9342
9343         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9344         * parser-defs.h (struct parser_state) <parser_state>: Add new
9345         parameter.
9346         <comma_terminates>: New member.
9347         (comma_terminates): Don't declare global.
9348         * parse.c (comma_terminates): Remove global.
9349         (parse_exp_in_context): Update.
9350         * p-exp.y (yylex): Update.
9351         * m2-exp.y (yylex): Update.
9352         * go-exp.y (lex_one_token): Update.
9353         * f-exp.y (yylex): Update.
9354         * d-exp.y (lex_one_token): Update.
9355         * c-exp.y (lex_one_token): Update.
9356         * ada-lex.l: Update.
9357
9358 2019-04-04  Tom Tromey  <tom@tromey.com>
9359
9360         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9361         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9362         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9363         * parser-defs.h (paren_depth): Don't declare.
9364         * parse.c (paren_depth): Remove global.
9365         (parse_exp_in_context): Update.
9366         * p-exp.y (paren_depth): New global.
9367         (pascal_parse): Initialize it.
9368         * m2-exp.y (paren_depth): New global.
9369         (m2_parse): Initialize it.
9370         * go-exp.y (paren_depth): New global.
9371         (go_parse): Initialize it.
9372         * f-exp.y (paren_depth): New global.
9373         (f_parse): Initialize it.
9374         * d-exp.y (paren_depth): New global.
9375         (d_parse): Initialize it.
9376         * c-exp.y (paren_depth): New global.
9377         (c_parse): Initialize it.
9378         * ada-lex.l (paren_depth): New global.
9379         (lexer_init): Initialize it.
9380
9381 2019-04-04  Tom Tromey  <tom@tromey.com>
9382
9383         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9384         (rust_parser::convert_ast_to_type)
9385         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9386         * parser-defs.h (struct parser_state) <parser_state>: Add
9387         parameters.  Initialize new members.
9388         <expression_context_block, expression_context_pc>: New members.
9389         * parse.c (expression_context_block, expression_context_pc):
9390         Remove globals.
9391         (parse_exp_in_context): Update.
9392         * p-exp.y: Update all rules.
9393         (yylex): Update.
9394         * m2-exp.y: Update all rules.
9395         (yylex): Update.
9396         * go-exp.y (yylex): Update.
9397         * f-exp.y (yylex): Update.
9398         * d-exp.y: Update all rules.
9399         (yylex): Update.
9400         * c-exp.y: Update all rules.
9401         (lex_one_token, classify_name, yylex, c_parse): Update.
9402         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9403
9404 2019-04-04  Tom Tromey  <tom@tromey.com>
9405
9406         * gdbarch.h, gdbarch.c: Rebuild.
9407         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9408         * stap-probe.h:
9409         (struct stap_parse_info): Replace "parser_state" with
9410         "expr_builder".
9411         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9412         (parser_state): New class.
9413         * parse.c (expr_builder): Rename.
9414         (expr_builder::release): Rename.
9415         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9416         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9417         (write_exp_elt_longcst, write_exp_elt_floatcst)
9418         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9419         (write_exp_string_vector, write_exp_bitstring)
9420         (write_exp_msymbol, mark_struct_expression)
9421         (write_dollar_variable)
9422         (insert_type_address_space, increase_expout_size): Replace
9423         "parser_state" with "expr_builder".
9424         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9425         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9426         "parser_state" with "expr_builder".
9427
9428 2019-04-04  Tom Tromey  <tom@tromey.com>
9429
9430         * rust-exp.y: Replace "parse_language" with method call.
9431         * p-exp.y:
9432         (yylex): Replace "parse_language" with method call.
9433         * m2-exp.y:
9434         (yylex): Replace "parse_language" with method call.
9435         * go-exp.y (classify_name): Replace "parse_language" with method
9436         call.
9437         * f-exp.y (yylex): Replace "parse_language" with method call.
9438         * d-exp.y (lex_one_token): Replace "parse_language" with method
9439         call.
9440         * c-exp.y:
9441         (lex_one_token, classify_name, yylex): Replace "parse_language"
9442         with method call.
9443         * ada-exp.y (find_primitive_type, type_char)
9444         (type_system_address): Replace "parse_language" with method call.
9445
9446 2019-04-04  Tom Tromey  <tom@tromey.com>
9447
9448         * rust-exp.y: Replace "parse_gdbarch" with method call.
9449         * parse.c (write_dollar_variable, insert_type_address_space):
9450         Replace "parse_gdbarch" with method call.
9451         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9452         call.
9453         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9454         call.
9455         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9456         "parse_gdbarch" with method call.
9457         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9458         with method call.
9459         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9460         "parse_gdbarch" with method call.
9461         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9462         "parse_gdbarch" with method call.
9463         * c-exp.y (parse_type, parse_number, classify_name): Replace
9464         "parse_gdbarch" with method call.
9465         * ada-lex.l: Replace "parse_gdbarch" with method call.
9466         * ada-exp.y (parse_type, find_primitive_type, type_char)
9467         (type_system_address): Replace "parse_gdbarch" with method call.
9468
9469 2019-04-04  Tom Tromey  <tom@tromey.com>
9470
9471         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9472         * stap-probe.c (stap_parse_argument): Update.
9473         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9474         initial_size parameter.
9475         * rust-exp.y (rust_lex_tests): Update.
9476         * parse.c (parser_state): Update.
9477         (parse_exp_in_context): Update.
9478         * parser-defs.h (struct parser_state) <parser_state>: Remove
9479         "initial_size" parameter.
9480
9481 2019-04-04  Tom Tromey  <tom@tromey.com>
9482
9483         * parser-defs.h (increase_expout_size): Don't declare.
9484         * parse.c (increase_expout_size): Now static.
9485
9486 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9487
9488         * gnu-nat.c (gnu_nat_target::wait): Fix
9489         target_waitstatus_to_string call.
9490
9491 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9492
9493         * eval.c (evaluate_subexp_standard): Handle internal functions
9494         during Fortran function call handling.
9495
9496 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9497
9498         * NEWS: Mention new internal functions.
9499         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9500         (read_base_type): Use dwarf2_init_complex_target_type.
9501         * value.c (creal_internal_fn): New function.
9502         (cimag_internal_fn): New function.
9503         (_initialize_values): Register new internal functions.
9504
9505 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9506
9507         * infrun.c (stop_all_threads): If debug_infrun, always
9508         trace the wait status after wait_one, using
9509         target_waitstatus_to_string and target_pid_to_str.
9510         (handle_inferior_event): Replace various trace of
9511         wait status kind by a single trace.
9512         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9513         wait status kind image by target_waitstatus_to_string.
9514         * target/waitstatus.c (target_waitstatus_to_string): Fix
9515         obsolete comment.
9516
9517 2019-04-01  Tom Tromey  <tromey@adacore.com>
9518
9519         PR symtab/23331:
9520         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9521
9522 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9523             Pedro Alves  <palves@redhat.com>
9524
9525         * top.c (quit_force): Call 'finalize_values'.
9526         * value.c (finalize_values): New function.
9527         * value.h (finalize_values): Declare.
9528
9529 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9530
9531         * NEWS: Announce $_gdb_major and $_gdb_minor.
9532
9533         * top.c (init_gdb_version_vars): New function.
9534         (gdb_init): Call init_gdb_version_vars.
9535
9536 2019-03-29  Tom Tromey  <tromey@adacore.com>
9537
9538         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9539         help text.  Remove dead code.
9540
9541 2019-03-29  Keith Seitz  <keiths@redhat.com>
9542
9543         From Siddhesh Poyarekar:
9544         * f-lang.h (f77_get_upperbound): Return LONGEST.
9545         (f77_get_lowerbound): Likewise.
9546         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9547         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9548         print them.
9549         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9550         plongest to format print it.
9551         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9552         (f77_get_upperbound): Likewise.
9553         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9554         LOWER_BOUND to LONGEST.
9555         (f77_create_arrayprint_offset_tbl): Likewise.
9556
9557 2019-03-29  Keith Seitz  <keiths@redhat.com>
9558
9559         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9560         %s/pulongest for TYPE_LENGTH instead of %d in format
9561         strings.
9562         * ada-typerint.c (ada_print_type): Likewise.
9563         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9564         * compile/compile-c-support.c (generate_register_struct): Likewise.
9565         * gdbtypes.c (recursive_dump_type): Likewise.
9566         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9567         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9568         instead of %d in format strings.
9569         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9570         to std::min to ULONGEST.
9571         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9572         instead of %d in format strings.
9573         * tracepoint.c (info_scope_command): Likewise.
9574         * typeprint.c (print_offset_data::update)
9575         (print_offset_data::finish): Likewise.
9576         * xtensa-tdep.c (xtensa_store_return_value)
9577         (xtensa_push_dummy_call): Likewise.
9578
9579 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9580
9581         * windows-nat.c (display_selector): Fixed format specifications
9582         for 64-bit Cygwin.
9583
9584 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9585
9586         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9587
9588 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9589
9590         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9591         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9592         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9593         (nios2_linux_init_abi): Install it.
9594
9595 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9596
9597         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9598
9599 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9600
9601         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9602
9603 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9604             Tom Tromey  <tromey@adacore.com>
9605
9606         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9607
9608 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9609
9610         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9611         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9612         method to compute the bounds of range types. Also print "[evaluated]"
9613         if the bounds' values come from a dynamic evaluation.
9614
9615 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9616
9617         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9618         whitespace when pretty printing is on.
9619
9620 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9621
9622         * ppc-linux-nat.c: Add include.
9623
9624 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9625
9626         * NEWS: Mention AArch64 Pointer Authentication.
9627
9628 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9629
9630         * arm-linux-nat.c: Add include.
9631
9632 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9633
9634         * source-cache.c (source_cache::get_source_lines): Re-read
9635         fullname after calling open_source_file.
9636
9637 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9638
9639         * NEWS: Mention TLS support for FreeBSD.
9640
9641 2019-03-25  Tom Tromey  <tromey@adacore.com>
9642
9643         * minsyms.c (BUNCH_SIZE): Update comment.
9644         (~minimal_symbol_reader): Remove old comment.
9645         (compact_minimal_symbols): Update comment.
9646         (minimal_symbol_reader::install): Remove old comment.  Update
9647         other comments.
9648
9649 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9650
9651         * s390-linux-nat.c: Add include.
9652
9653 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9654
9655         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9656         Call linux_get_hwcap.
9657         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9658         Likewise.
9659         (aarch64_linux_get_hwcap): Remove function.
9660         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9661         declaration.
9662         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9663         linux_get_hwcap.
9664         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9665         * linux-tdep.c (linux_get_hwcap): Add function.
9666         (linux_get_hwcap2): Likewise.
9667         * linux-tdep.h (linux_get_hwcap): Add declaration.
9668         (linux_get_hwcap2): Likewise.
9669         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9670         (ppc_linux_get_hwcap2): Likewise.
9671         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9672         linux_get_hwcap.
9673         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9674         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9675         (ppc_linux_nat_target::read_description): Likewise.
9676         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9677         * s390-linux-nat.c: Likewise.
9678         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9679
9680 2019-03-24  Tom Tromey  <tom@tromey.com>
9681
9682         * ada-lang.c (standard_lookup): Simplify initialization.
9683         (ada_lookup_symbol_nonlocal): Simplify return.
9684         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9685         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9686         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9687         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9688         initialization.
9689         * solib.c (solib_global_lookup): Simplify.
9690         * symtab.c (null_block_symbol): Remove.
9691         (symbol_cache_lookup): Simplify returns.
9692         (lookup_language_this): Simplify returns.
9693         (lookup_symbol_aux): Simplify return.
9694         (lookup_local_symbol): Simplify returns.
9695         (lookup_global_symbol_from_objfile): Simplify return.
9696         (lookup_symbol_in_objfile_symtabs)
9697         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9698         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9699         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9700         * cp-namespace.c (cp_lookup_bare_symbol)
9701         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9702         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9703         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9704         (cp_lookup_symbol_via_imports): Simplify initialization.
9705         (find_symbol_in_baseclass): Likewise.
9706         * symtab.h (null_block_symbol): Remove.
9707         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9708         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9709         (d_lookup_symbol_module): Likewise.
9710         (find_symbol_in_baseclass): Simplify initialization.
9711
9712 2019-03-24  Tom Tromey  <tom@tromey.com>
9713
9714         * expression.h: Don't include symtab.h.
9715         (struct block): Forward declare.
9716
9717 2019-03-24  Tom Tromey  <tom@tromey.com>
9718
9719         * c-exp.y (typebase): Remove casts.
9720         * gdbtypes.c (lookup_unsigned_typename, )
9721         (lookup_signed_typename): Remove cast.
9722         * eval.c (parse_to_comma_and_eval): Remove cast.
9723         * parse.c (write_dollar_variable): Remove cast.
9724         * block.h (struct block) <superblock>: Now const.
9725         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9726         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9727         (map_block): Make "block" const.
9728         * symfile.h (struct quick_symbol_functions)
9729         <map_matching_symbols>: Constify block argument to "callback".
9730         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9731         const.
9732         (find_pc_sect_compunit_symtab): Make "b" const.
9733         (find_symbol_at_address): Likewise.
9734         (search_symbols): Likewise.
9735         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9736         (dw2_debug_names_lookup_symbol): Likewise.
9737         (dw2_map_matching_symbols): Update.
9738         * p-valprint.c (pascal_val_print): Remove "block".
9739         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9740         (aux_add_nonlocal_symbols): Make "block" const.
9741         (resolve_subexp): Remove cast.
9742         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9743         const.
9744         (iterate_over_file_blocks): Likewise.
9745         * f-exp.y (%union) <bval>: Remove.
9746         * coffread.c (patch_opaque_types): Make "b" const.
9747         * spu-tdep.c (spu_catch_start): Make "block" const.
9748         * c-valprint.c (print_unpacked_pointer): Remove "block".
9749         * symmisc.c (dump_symtab_1): Make "b" const.
9750         (block_depth): Make "block" const.
9751         * d-exp.y (%union) <bval>: Remove.
9752         * cp-support.h (cp_lookup_rtti_type): Update.
9753         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9754         * psymtab.c (psym_lookup_symbol): Make "block" const.
9755         (maintenance_check_psymtabs): Make "b" const.
9756         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9757         (enumerate_locals, enumerate_args): Update.
9758         * python/py-symtab.c (stpy_global_block): Make "block" const.
9759         (stpy_static_block): Likewise.
9760         * inline-frame.c (block_starting_point_at): Make "new_block"
9761         const.
9762         * block.c (find_block_in_blockvector): Make return type const.
9763         (blockvector_for_pc_sect): Make "b" const.
9764         (find_block_in_blockvector): Make "b" const.
9765
9766 2019-03-23  Tom Tromey  <tom@tromey.com>
9767
9768         * varobj.c (varobj_create): Update.
9769         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9770         * printcmd.c (display_command, do_one_display): Don't reset
9771         innermost_block.
9772         * parser-defs.h (enum innermost_block_tracker_type): Move to
9773         expression.h.
9774         (innermost_block): Update comment.
9775         * parse.c (parse_exp_1): Add tracker_types parameter.
9776         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9777         tracker_types parameter.  Reset innermost_block.
9778         (parse_exp_in_context): Remove.
9779         (parse_expression_for_completion): Update.
9780         * objfiles.c (~objfile): Don't reset expression_context_block or
9781         innermost_block.
9782         * expression.h (enum innermost_block_tracker_type): Move from
9783         parser-defs.h.
9784         (parse_exp_1): Add tracker_types parameter.
9785         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9786         reset innermost_block.
9787
9788 2019-03-23  Tom Tromey  <tom@tromey.com>
9789
9790         * objfiles.h: Include bcache.h.
9791
9792 2019-03-23  Tom Tromey  <tom@tromey.com>
9793
9794         * linespec.c (get_current_search_block): Use
9795         scoped_restore_current_language.
9796         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9797
9798 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9799             Jiong Wang  <jiong.wang@arm.com>
9800
9801         * aarch64-linux-tdep.c
9802         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9803         section.
9804         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9805
9806 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9807             Jiong Wang  <jiong.wang@arm.com>
9808
9809         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9810         instructions.
9811         (aarch64_analyze_prologue_test): Add PACIASP test.
9812         (aarch64_prologue_prev_register): Unmask PC value.
9813
9814 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9815             Jiong Wang  <jiong.wang@arm.com>
9816
9817         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9818         (aarch64_dwarf2_prev_register): Unmask PC value.
9819         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9820         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9821         DW_CFA_AARCH64_negate_ra_state.
9822         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9823
9824 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9825             Jiong Wang  <jiong.wang@arm.com>
9826
9827         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9828         registers.
9829         (aarch64_pseudo_register_name): Likewise.
9830         (aarch64_pseudo_register_type): Likewise.
9831         (aarch64_pseudo_register_reggroup_p): Likewise.
9832         (aarch64_gdbarch_init): Add pauth registers.
9833         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9834         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9835         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9836         (struct gdbarch_tdep): Add regnum for ra_state.
9837
9838 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9839             Jiong Wang  <jiong.wang@arm.com>
9840
9841         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9842
9843 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9844             Jiong Wang  <jiong.wang@arm.com>
9845
9846         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9847         function.
9848         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9849         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9850         (aarch64_gdbarch_init): Add puth registers.
9851         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9852         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9853         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9854
9855 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9856             Jiong Wang  <jiong.wang@arm.com>
9857
9858         * aarch64-linux-nat.c
9859         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9860         * aarch64-linux-tdep.c
9861         (aarch64_linux_core_read_description): Likewise.
9862         (aarch64_linux_get_hwcap): New function.
9863         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9864         (aarch64_linux_get_hwcap): New declaration.
9865
9866 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9867             Jiong Wang  <jiong.wang@arm.com>
9868
9869         * aarch64-linux-nat.c
9870         (aarch64_linux_nat_target::read_description): Add pauth param.
9871         * aarch64-linux-tdep.c
9872         (aarch64_linux_core_read_description): Likewise.
9873         * aarch64-tdep.c (struct target_desc): Add in pauth.
9874         (aarch64_read_description): Add pauth param.
9875         (aarch64_gdbarch_init): Likewise.
9876         * aarch64-tdep.h (aarch64_read_description): Likewise.
9877         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9878         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9879         * features/Makefile: Add new files.
9880         * features/aarch64-pauth.c: New file.
9881         * features/aarch64-pauth.xml: New file.
9882
9883 2019-03-20  Tom Tromey  <tromey@adacore.com>
9884
9885         * infrun.c (handle_inferior_event): Rename from
9886         handle_inferior_event_1.  Create a scoped_value_mark.
9887         (handle_inferior_event): Remove.
9888
9889 2019-03-19  Tom Tromey  <tromey@adacore.com>
9890
9891         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9892         * infrun.h (print_stop_event): Add "displays" parameter.
9893         * infrun.c (print_stop_event): Add "displays" parameter.
9894
9895 2019-03-19  Pedro Alves  <palves@redhat.com>
9896
9897         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9898         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9899         to -1.  Fix TABs vs spaces.
9900         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9901         * tui/tui-out.h (tui_ui_out) Add intro comments.
9902         <m_line, m_start_of_line>: In-class initialize, and add describing
9903         comment.
9904
9905 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9906
9907         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9908         variable names.
9909         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9910
9911 2019-03-18  Pedro Alves  <palves@redhat.com>
9912             Eli Zaretskii <eliz@gnu.org>
9913
9914         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9915         m_line and m_start_of_line.
9916
9917 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9918
9919         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9920         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9921         it returns a newline.  This fixes a regression in TU mode, whereby
9922         the next line is output on the same screen line as the user input.
9923
9924 2019-03-18  Tom Tromey  <tromey@adacore.com>
9925
9926         * minsyms.c (minimal_symbol_reader::install): Remove call to
9927         obstack_blank.
9928
9929 2019-03-18  Pedro Alves  <palves@redhat.com>
9930
9931         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9932         New globals.
9933         (apply_style): New, factored out from ...
9934         (apply_ansi_escape): ... this.  Handle reverse video mode.
9935         (tui_set_reverse_mode): New function.
9936         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9937         * tui/tui-winsource.c (tui_show_source_line): Use
9938         tui_set_reverse_mode instead of setting A_STANDOUT.
9939         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9940         New setter methods.
9941
9942 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9943
9944         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9945         Handle tabs.
9946
9947 2019-03-18  Tom Tromey  <tromey@adacore.com>
9948
9949         * ada-lang.c (empty_array): Add "high" parameter.
9950         (ada_evaluate_subexp): Update.
9951
9952 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9953
9954         * unittests/string_view-selftests.c: Define
9955         _initialize_string_view_selftests unconditionally.
9956
9957 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9958
9959         PR gdb/24350
9960         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9961
9962 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9963
9964         PR gdb/24351
9965         * windows-nat.c (display_selector): Fix format specifiers.
9966
9967 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9968
9969         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9970         tui_refill_source_window instead of tui_refresh_win, to update the
9971         current execution line.  This fixes redisplay of the current line
9972         when stepping through the code with "next" or "step".
9973
9974 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9975
9976         * source-cache.c (source_cache::get_source_lines): Call
9977         find_source_lines to initialize s->nlines.  This fixes vertical
9978         scrolling of TUI source window when the DOWN arrow is pressed.
9979
9980 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9981
9982         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9983         linux-thread-db.c (_initialize_thread_db): Likewise.
9984
9985 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9986
9987         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9988         wclrtoeol in tui_show_source_line".  This reverts changes made in
9989         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9990
9991 2019-03-15  Tom Tromey  <tom@tromey.com>
9992
9993         * symtab.h (struct minimal_symbol): Derive from
9994         general_symbol_info.
9995         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9996         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9997         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9998         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9999         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10000         (MSYMBOL_SEARCH_NAME): Update.
10001         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10002         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10003         * minsyms.c (minimal_symbol_reader::record_full): Update.
10004
10005 2019-03-15  Tom Tromey  <tom@tromey.com>
10006
10007         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10008
10009 2019-03-15  Tom Tromey  <tom@tromey.com>
10010
10011         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10012         unique_xmalloc_ptr.
10013         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10014         Update.
10015         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10016         (build_minimal_symbol_hash_tables)
10017         (minimal_symbol_reader::install): Update.
10018
10019 2019-03-15  Tom Tromey  <tom@tromey.com>
10020
10021         * symtab.c (create_demangled_names_hash): Update.
10022         (symbol_set_names): Update.
10023         * objfiles.h (struct objfile_per_bfd_storage)
10024         <demangled_names_hash>: Now an htab_up.
10025         * objfiles.c (objfile_per_bfd_storage): Simplify.
10026
10027 2019-03-15  Tom Tromey  <tom@tromey.com>
10028
10029         * objfiles.h (struct objfile_per_bfd_storage): Declare
10030         destructor.
10031         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10032         New.
10033         (get_objfile_bfd_data): Use new.  Don't initialize
10034         language_of_main.
10035         (free_objfile_per_bfd_storage): Remove.
10036         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10037
10038 2019-03-15  Tom Tromey  <tom@tromey.com>
10039
10040         * symfile.c (reread_symbols): Update.
10041         * objfiles.c (objfile::objfile): Update.
10042         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10043         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10044         comment.
10045         (minimal_symbol_reader::install): Update.
10046         (terminate_minimal_symbol_table): Remove.
10047         * jit.c (jit_object_close_impl): Update.
10048
10049 2019-03-15  Tom Tromey  <tom@tromey.com>
10050
10051         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10052         initializations.
10053
10054 2019-03-15  Tom Tromey  <tom@tromey.com>
10055
10056         * objfiles.h (struct objfile_per_bfd_storage)
10057         <demangled_hash_languages>: Now a bitset.
10058         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10059         (lookup_minimal_symbol): Update.
10060
10061 2019-03-15  Tom Tromey  <tom@tromey.com>
10062
10063         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10064         Don't return the symbol.
10065         * coffread.c (record_minimal_symbol): Use record_full.
10066
10067 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10068
10069         The MS-Windows port of ncurses fails to switch to a color pair if
10070         one or both of the colors are the implicit default colors.  This
10071         change records the default colors when TUI is initialized, and
10072         then specifies them explicitly when a color pair uses the default
10073         colors.  This allows color styling in TUI mode on MS-Windows.
10074
10075         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10076         ncurses_norm_attr.
10077         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10078         colors in ncurses_norm_attr.
10079         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10080         "none", replace it with the default color recorded in
10081         ncurses_norm_attr.
10082
10083 2019-03-14  Tom Tromey  <tromey@adacore.com>
10084
10085         * source-cache.h (class source_cache) <get_source_lines>: Return
10086         std::string.
10087         * source-cache.c (source_cache::extract_lines): Handle case where
10088         first_pos==npos.  Return std::string.
10089         (source_cache::get_source_lines): Update.
10090
10091 2019-03-14  Tom Tromey  <tromey@adacore.com>
10092
10093         * NEWS: Add item for "style sources" commands.
10094         * source-cache.c (source_cache::get_source_lines): Check
10095         source_styling.
10096         * cli/cli-style.c (source_styling): New global.
10097         (_initialize_cli_style): Add "style sources" commands.
10098         (show_style_sources): New function.
10099         * cli/cli-style.h (source_styling): Declare.
10100
10101 2019-03-14  Pedro Alves  <palves@redhat.com>
10102             Tom Tromey  <tromey@adacore.com>
10103
10104         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10105         * tui/tui-winsource.c (tui_refill_source_window): New function,
10106         from...
10107         (tui_horizontal_source_scroll): ... here.  Move some logic.
10108         * cli/cli-style.c (set_style_enabled): Notify new observable.
10109         * tui/tui-hooks.c (tui_redisplay_source): New function.
10110         (tui_attach_detach_observers): Attach or detach
10111         tui_redisplay_source.
10112         * observable.h (source_styling_changed): New observable.
10113         * observable.c: Define source_styling_changed observable.
10114
10115 2019-03-13  Tom Tromey  <tromey@adacore.com>
10116
10117         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10118         (i386_gnu_nat_target::store_registers): Update.
10119         * target-debug.h (target_debug_print_std_string): New macro.
10120         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10121         * windows-tdep.c (display_one_tib): Update.
10122         * tui/tui-stack.c (tui_make_status_line): Update.
10123         * top.c (print_inferior_quit_action): Update.
10124         * thread.c (thr_try_catch_cmd): Update.
10125         (add_thread_with_info): Update.
10126         (thread_target_id_str): Update.
10127         (thr_try_catch_cmd): Update.
10128         (thread_command): Update.
10129         (thread_find_command): Update.
10130         * record-btrace.c (record_btrace_target::info_record)
10131         (record_btrace_resume_thread, record_btrace_target::resume)
10132         (record_btrace_cancel_resume, record_btrace_step_thread)
10133         (record_btrace_target::wait, record_btrace_target::wait)
10134         (record_btrace_target::wait, record_btrace_target::stop): Update.
10135         * progspace.c (print_program_space): Update.
10136         * process-stratum-target.c
10137         (process_stratum_target::thread_address_space): Update.
10138         * linux-fork.c (linux_fork_mourn_inferior)
10139         (detach_checkpoint_command, info_checkpoints_command)
10140         (linux_fork_context): Update.
10141         (linux_fork_detach): Update.
10142         (class scoped_switch_fork_info): Update.
10143         (delete_checkpoint_command): Update.
10144         * infrun.c (follow_fork_inferior): Update.
10145         (follow_fork_inferior): Update.
10146         (proceed_after_vfork_done): Update.
10147         (handle_vfork_child_exec_or_exit): Update.
10148         (follow_exec): Update.
10149         (displaced_step_prepare_throw): Update.
10150         (displaced_step_restore): Update.
10151         (start_step_over): Update.
10152         (resume_1): Update.
10153         (clear_proceed_status_thread): Update.
10154         (proceed): Update.
10155         (print_target_wait_results): Update.
10156         (do_target_wait): Update.
10157         (context_switch): Update.
10158         (stop_all_threads): Update.
10159         (restart_threads): Update.
10160         (finish_step_over): Update.
10161         (handle_signal_stop): Update.
10162         (switch_back_to_stepped_thread): Update.
10163         (keep_going_pass_signal): Update.
10164         (print_exited_reason): Update.
10165         (normal_stop): Update.
10166         * inferior.c (inferior_pid_to_str): Change return type.
10167         (print_selected_inferior): Update.
10168         (add_inferior): Update.
10169         (detach_inferior): Update.
10170         * dummy-frame.c (fprint_dummy_frames): Update.
10171         * dcache.c (dcache_info_1): Update.
10172         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10173         (btrace_fetch, btrace_clear): Update.
10174         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10175         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10176         type.
10177         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10178         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10179         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10180         * gdbarch.c, gdbarch.h: Rebuild.
10181         * gdbarch.sh (core_pid_to_str): Change return type.
10182         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10183         return type.
10184         (windows_nat_target::pid_to_str): Change return type.
10185         (windows_delete_thread): Update.
10186         (windows_nat_target::attach): Update.
10187         (windows_nat_target::files_info): Update.
10188         * target-delegates.c: Rebuild.
10189         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10190         return type.
10191         (sol_thread_target::pid_to_str): Change return type.
10192         * remote.c (class remote_target) <pid_to_str>: Change return
10193         type.
10194         (remote_target::pid_to_str): Change return type.
10195         (extended_remote_target::attach, remote_target::remote_stop_ns)
10196         (remote_target::remote_notif_remove_queued_reply)
10197         (remote_target::push_stop_reply, remote_target::disable_btrace):
10198         Update.
10199         (extended_remote_target::attach): Update.
10200         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10201         type.
10202         (gdbsim_target::pid_to_str): Change return type.
10203         * ravenscar-thread.c (struct ravenscar_thread_target)
10204         <pid_to_str>: Change return type.
10205         (ravenscar_thread_target::pid_to_str): Change return type.
10206         * procfs.c (class procfs_target) <pid_to_str>: Change return
10207         type.
10208         (procfs_target::pid_to_str): Change return type.
10209         (procfs_target::attach): Update.
10210         (procfs_target::detach): Update.
10211         (procfs_target::fetch_registers): Update.
10212         (procfs_target::store_registers): Update.
10213         (procfs_target::wait): Update.
10214         (procfs_target::files_info): Update.
10215         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10216         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10217         return type.
10218         (nto_procfs_target::pid_to_str): Change return type.
10219         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10220         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10221         return type.
10222         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10223         (exit_lwp): Update.
10224         (attach_proc_task_lwp_callback, get_detach_signal)
10225         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10226         (linux_nat_target::resume, wait_lwp, stop_callback)
10227         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10228         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10229         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10230         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10231         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10232         type.
10233         (inf_ptrace_target::attach): Update.
10234         (inf_ptrace_target::files_info): Update.
10235         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10236         type.
10237         (go32_nat_target::pid_to_str): Change return type.
10238         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10239         (gnu_nat_target::wait): Update.
10240         (gnu_nat_target::wait): Update.
10241         (gnu_nat_target::resume): Update.
10242         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10243         (fbsd_nat_target::wait): Update.
10244         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10245         type.
10246         (darwin_nat_target::attach): Update.
10247         * corelow.c (class core_target) <pid_to_str>: Change return type.
10248         (core_target::pid_to_str): Change return type.
10249         * target.c (normal_pid_to_str): Change return type.
10250         (default_pid_to_str): Likewise.
10251         (target_pid_to_str): Change return type.
10252         (target_translate_tls_address): Update.
10253         (target_announce_detach): Update.
10254         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10255         return type.
10256         (bsd_uthread_target::pid_to_str): Change return type.
10257         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10258         type.
10259         (bsd_kvm_target::pid_to_str): Change return type.
10260         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10261         return type.
10262         (aix_thread_target::pid_to_str): Change return type.
10263         * target.h (struct target_ops) <pid_to_str>: Change return type.
10264         (target_pid_to_str, normal_pid_to_str): Likewise.
10265         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10266         type.
10267         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10268         type.
10269         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10270         return type.
10271         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10272         type.
10273         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10274         type.
10275         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10276         return type.
10277
10278 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10279
10280         * NEWS: Mention that the new default MI version is 3.  Mention
10281         changes to the output of commands and events that deal with
10282         multi-location breakpoints.
10283         * breakpoint.c: Include "mi/mi-out.h".
10284         (print_one_breakpoint): Change output syntax if using MI version
10285         >= 3.
10286         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10287         New.
10288         (mi_multi_location_breakpoint_output_fixed): New.
10289         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10290         (mi_cmd_fix_multi_location_breakpoint_output): New.
10291         (mi_multi_location_breakpoint_output_fixed): New.
10292         * mi/mi-cmds.c (mi_cmds): Register command
10293         -fix-multi-location-breakpoint-output.
10294         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10295         interpreter "mi".
10296
10297 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10298
10299         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10300         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10301         instantiate mi_ui_out based on interpreter name.
10302         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10303         * mi/mi-main.c (mi_load_progress): Likewise.
10304
10305 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10306
10307         * NEWS: Combine separate "New targets" sections for 8.3.
10308
10309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10310
10311         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10312         (ppcfbsd_init_abi): Install gdbarch
10313         "fetch_tls_load_module_address" and "get_thread_local_address"
10314         methods.
10315
10316 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10317
10318         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10319         (riscv_fbsd_init_abi): Install gdbarch
10320         "fetch_tls_load_module_address" and "get_thread_local_address"
10321         methods.
10322
10323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10324
10325         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10326         (i386fbsd_init_abi): Install gdbarch
10327         "fetch_tls_load_module_address" and "get_thread_local_address"
10328         methods.
10329
10330 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10331
10332         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10333         (amd64fbsd_init_abi): Install gdbarch
10334         "fetch_tls_load_module_address" and "get_thread_local_address"
10335         methods.
10336
10337 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10338
10339         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10340         (struct fbsd_pspace_data): New type.
10341         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10342         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10343         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10344         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10345         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10346
10347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10348
10349         * gdbtypes.c (lookup_struct_elt): New function.
10350         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10351         * gdbtypes.h (struct struct_elt): New type.
10352         (lookup_struct_elt): New prototype.
10353
10354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10355
10356         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10357         remove disabled code block.
10358
10359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10360
10361         * gdbarch.sh (get_thread_local_address): New method.
10362         * gdbarch.h, gdbarch.c: Regenerate.
10363         * target.c (target_translate_tls_address): Use
10364         gdbarch_get_thread_local_address if present instead of
10365         target::get_thread_local_address.
10366
10367 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10368
10369         * target.h (target::get_thread_local_address): Update comment.
10370
10371 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10372
10373         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10374         objfile->separate_debug_objfile_backlink if not NULL.
10375
10376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10377
10378         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10379         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10380         (amd64bsd_store_inferior_registers): Likewise.
10381         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10382         Enable segment base registers.
10383         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10384         PT_GETFSBASE and PT_GETGSBASE.
10385         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10386         PT_SETGSBASE.
10387         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10388         segment base registers.
10389         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10390
10391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10392
10393         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10394         Update calls to i386_target_description to add 'segments'
10395         parameter.
10396         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10397         add segment base registers.
10398         * arch/i386.c (i386_create_target_description): Add 'segments'
10399         parameter to enable segment base registers.
10400         * arch/i386.h (i386_create_target_description): Likewise.
10401         * features/i386/32bit-segments.xml: New file.
10402         * features/i386/32bit-segments.c: Generate.
10403         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10404         call to i386_target_description to add 'segments' parameter.
10405         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10406         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10407         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10408         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10409         if feature is present.
10410         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10411         Add 'segments' parameter to call to i386_target_description.
10412         (i386_target_description): Add 'segments' parameter to enable
10413         segment base registers.
10414         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10415         to call to i386_target_description.
10416         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10417         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10418         Define I386_NUM_REGS.
10419         (i386_target_description): Add 'segments' parameter to enable
10420         segment base registers.
10421
10422 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10423
10424         PR/24325
10425         * source-cache.c: #undef open and close, to avoid unresolved
10426         externals during linking.
10427
10428 2019-03-12  Tom Tromey  <tromey@adacore.com>
10429
10430         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10431         const.  Add initializers.
10432         (_initialize_remote): Don't initialize ptid globals.
10433
10434 2019-03-12  Pedro Alves  <palves@redhat.com>
10435
10436         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10437
10438 2019-03-12  Pedro Alves  <palves@redhat.com>
10439
10440         * cp-name-parser.y (main): Remove unused 'len' variable.
10441
10442 2019-03-12  Tom Tromey  <tromey@adacore.com>
10443
10444         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10445         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10446
10447 2019-03-12  Tom Tromey  <tromey@adacore.com>
10448
10449         * linux-nat.c (iterate_over_lwps): Update.
10450         (stop_callback): Remove parameter.
10451         (stop_wait_callback, detach_callback, resume_set_callback)
10452         (select_singlestep_lwp_callback, set_ignore_sigint)
10453         (status_callback, resumed_callback, resume_clear_callback)
10454         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10455         data parameter.
10456         (linux_nat_target::detach, linux_nat_target::resume)
10457         (linux_stop_and_wait_all_lwps, select_event_lwp)
10458         (linux_nat_filter_event, linux_nat_wait_1)
10459         (linux_nat_target::kill, linux_nat_target::stop)
10460         (linux_nat_target::stop): Update.
10461         (linux_nat_resume_callback): Change type.
10462         (resume_stopped_resumed_lwps, count_events_callback)
10463         (select_event_lwp_callback): Likewise.
10464         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10465         * arm-linux-nat.c (struct update_registers_data): Remove.
10466         (update_registers_callback): Change type.
10467         (arm_linux_insert_hw_breakpoint1): Update.
10468         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10469         parameter.
10470         (x86_linux_dr_set_addr): Update.
10471         (x86_linux_dr_set_control): Update.
10472         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10473         (iterate_over_lwps): Use gdb::function_view.
10474         * nat/aarch64-linux-hw-point.c (struct
10475         aarch64_dr_update_callback_param): Remove.
10476         (debug_reg_change_callback): Change type.
10477         (aarch64_notify_debug_reg_change): Update.
10478         * s390-linux-nat.c (s390_refresh_per_info): Update.
10479
10480 2019-03-11  Tom Tromey  <tromey@adacore.com>
10481
10482         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10483         redundant assignment to "this_cu".
10484
10485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10486
10487         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10488
10489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10490
10491         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10492         from...
10493         (rank_one_type): ... this.
10494
10495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10496
10497         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10498         from...
10499         (rank_one_type): ... this.
10500
10501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10502
10503         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10504         from...
10505         (rank_one_type): ... this.
10506
10507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10508
10509         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10510         from...
10511         (rank_one_type): ... this.
10512
10513 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10514
10515         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10516         from...
10517         (rank_one_type): ... this.
10518
10519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10520
10521         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10522         from...
10523         (rank_one_type): ... this.
10524
10525 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10526
10527         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10528         from...
10529         (rank_one_type): ... this.
10530
10531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10532
10533         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10534         from...
10535         (rank_one_type): ... this.
10536
10537 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10538
10539         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10540         from...
10541         (rank_one_type): ... this.
10542
10543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10544
10545         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10546         from...
10547         (rank_one_type): ... this.
10548
10549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10550
10551         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10552         from...
10553         (rank_one_type): ... this.
10554
10555 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10556
10557         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10558         from...
10559         (rank_one_type): ... this.
10560
10561 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10562
10563         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10564         inferior-events' shows the example events.
10565
10566 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10567
10568         Support styling on native MS-Windows console
10569
10570         PR/24315
10571         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10572         on MS-Windows if $TERM is not defined.
10573
10574         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10575
10576         * posix-hdep.c (gdb_console_fputs):
10577         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10578         functions.
10579         * ui-file.h (gdb_console_fputs): Add prototype.
10580
10581         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10582         back to fputs only if the former returns zero.
10583
10584 2019-03-07  Tom Tromey  <tom@tromey.com>
10585
10586         * symmisc.c (print_symbol_bcache_statistics): Update.
10587         (print_objfile_statistics): Update.
10588         * symfile.c (allocate_symtab): Update.
10589         * stabsread.c: Don't include bcache.h.
10590         * psymtab.h (struct psymbol_bcache): Don't declare.
10591         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10592         (psymbol_bcache_init, psymbol_bcache_free)
10593         (psymbol_bcache_get_bcache): Don't declare.
10594         * psymtab.c (struct psymbol_bcache): Remove.
10595         (psymtab_storage::psymtab_storage): Update.
10596         (psymtab_storage::~psymtab_storage): Update.
10597         (psymbol_bcache_init, psymbol_bcache_free)
10598         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10599         (add_psymbol_to_bcache): Update.
10600         (allocate_psymtab): Update.
10601         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10602         macro_cache>: No longer pointers.
10603         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10604         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10605         * macrotab.c (macro_bcache): Update.
10606         * macroexp.c: Don't include bcache.h.
10607         * gdbtypes.c (check_types_worklist): Update.
10608         (types_deeply_equal): Remove TRY/CATCH.  Update.
10609         * elfread.c (elf_symtab_read): Update.
10610         * dwarf2read.c: Don't include bcache.h.
10611         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10612         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10613         (print_bcache_statistics, bcache_memory_used): Don't declare.
10614         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10615         methods.  Rename all data members.
10616         * bcache.c (struct bcache): Move to bcache.h.
10617         (bcache::expand_hash_table): Rename from expand_hash_table.
10618         (bcache): Remove.
10619         (bcache::insert): Rename from bcache_full.
10620         (bcache::compare): Rename from bcache_compare.
10621         (bcache_xmalloc): Remove.
10622         (bcache::~bcache): Rename from bcache_xfree.
10623         (bcache::print_statistics): Rename from print_bcache_statistics.
10624         (bcache::memory_used): Rename from bcache_memory_used.
10625
10626 2019-03-07  Pedro Alves  <palves@redhat.com>
10627
10628         * infrun.c (normal_stop): Also check for
10629         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10630
10631 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10632
10633         * f-lang.c (value_from_host_double): Moved to...
10634         * value.c (value_from_host_double): ...here.
10635         * value.h (value_from_host_double): Declare.
10636         * guile/scm-math.c (vlscm_convert_typed_number): Use
10637         value_from_host_double.
10638         (vlscm_convert_number): Likewise.
10639         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10640         * python/py-value.c (convert_value_from_python): Likewise.
10641
10642 2019-03-06  Tom Tromey  <tom@tromey.com>
10643
10644         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10645
10646 2019-03-06  Tom Tromey  <tom@tromey.com>
10647
10648         * utils.h (free_current_contents): Don't declare.
10649         * utils.c (free_current_contents): Remove.
10650
10651 2019-03-06  Tom Tromey  <tom@tromey.com>
10652
10653         * top.c (quit_force): Update.
10654         * main.c (captured_command_loop): Update.
10655         * common/new-op.c (operator new): Update.
10656         * common/common-exceptions.c (struct catcher)
10657         <save_cleanup_chain>: Remove member.
10658         (exceptions_state_mc_init): Update.
10659         (exception_try_scope_entry): Return nullptr.
10660         (exception_try_scope_exit, exception_rethrow)
10661         (throw_exception_sjlj, throw_exception_cxx): Update.
10662         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10663         (all_cleanups, do_cleanups, discard_cleanups)
10664         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10665         (restore_cleanups, restore_final_cleanups): Don't declare.
10666         (do_final_cleanups): Remove parameter.
10667         * common/cleanups.c (cleanup_chain, make_cleanup)
10668         (make_cleanup_dtor, all_cleanups, do_cleanups)
10669         (discard_my_cleanups, discard_cleanups)
10670         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10671         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10672         (null_cleanup): Remove.
10673         (do_final_cleanups): Remove parameter.
10674
10675 2019-03-06  Tom Tromey  <tom@tromey.com>
10676
10677         * remote.c (remote_target::remote_parse_stop_reply): Use
10678         unique_xmalloc_ptr.
10679
10680 2019-03-06  Tom Tromey  <tom@tromey.com>
10681
10682         * stabsread.c (struct stabs_field_info): Rename from field_info.
10683         <list, fnlist>: Add initializers.
10684         <obstack>: New member.
10685         (read_member_functions, read_struct_fields, read_baseclasses):
10686         Allocate on obstack.  Don't use cleanups.
10687         (read_one_struct_field, read_member_functions, read_struct_fields)
10688         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10689         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10690         (read_struct_type): Update.
10691
10692 2019-03-06  Tom Tromey  <tom@tromey.com>
10693
10694         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10695         * common/filestuff.h (make_cleanup_close): Don't declare.
10696         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10697         Remove.
10698
10699 2019-03-06  Tom Tromey  <tom@tromey.com>
10700
10701         * solib-aix.c: Use make_scope_exit.
10702
10703 2019-03-06  Tom Tromey  <tom@tromey.com>
10704
10705         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10706         Use make_scope_exit.
10707
10708 2019-03-06  Tom Tromey  <tom@tromey.com>
10709
10710         * solib-svr4.c (disable_probes_interface): Remove parameter.
10711         (svr4_handle_solib_event): Use make_scope_exit.
10712
10713 2019-03-06  Tom Tromey  <tom@tromey.com>
10714
10715         * remote.c (struct stop_reply_deleter): Remove.
10716         (stop_reply_up): Update.
10717         (struct stop_reply): Derive from notif_event.  Don't typedef.
10718         <regcache>: Now a std::vector.
10719         (stop_reply_xfree): Remove.
10720         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10721         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10722         (remote_target::discard_pending_stop_replies): Use delete.
10723         (remote_target::remote_parse_stop_reply): Update.
10724         (remote_target::process_stop_reply): Update.
10725         * remote-notif.h (struct notif_event): Add virtual destructor.
10726         Remove "dtr" member.
10727         (struct notif_client) <alloc_event>: Return a unique_ptr.
10728         (notif_event_xfree): Don't declare.
10729         (notif_event_up): New typedef.
10730         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10731         (notif_event_xfree, do_notif_event_xfree): Remove.
10732         (remote_notif_state_xfree): Update.
10733
10734 2019-03-06  Tom Tromey  <tom@tromey.com>
10735
10736         * infrun.c (displaced_step_clear_cleanup): Now a
10737         forward_scope_exit type.
10738         (displaced_step_prepare_throw): Update.
10739         (displaced_step_fixup): Update.
10740
10741 2019-03-06  Tom Tromey  <tom@tromey.com>
10742
10743         * inferior.h (class inferior): Update comment.
10744         * gdbthread.h (class thread_info): Update comment.
10745
10746 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10747             Tom Tromey  <tom@tromey.com>
10748
10749         * stabsread.h (struct stab_section_list): Remove.
10750         (coffstab_build_psymtabs): Update.
10751         * dbxread.c (symbuf_sections): Now a std::vector.
10752         (sect_idx): New global.
10753         (fill_symbuf): Update.
10754         (coffstab_build_psymtabs): Change type of stabsects parameter.
10755         Update.
10756         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10757         std::vector.
10758         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10759         (coff_locate_sections): Update.
10760         (coff_symfile_read): Remove cleanups.  Update.
10761         (init_stringtab): Add storage parameter.
10762         (free_stringtab, free_stringtab_cleanup): Remove.
10763         (init_lineno): Add storage parameter.
10764         (free_linetab, free_linetab_cleanup): Remove.
10765
10766 2019-03-06  Pedro Alves  <palves@redhat.com>
10767
10768         * linux-fork.c (fork_info::clobber_regs): Delete.
10769         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10770         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10771         comment.  Adjust.
10772         (scoped_switch_fork_info::scoped_switch_fork_info)
10773         (checkpoint_command, linux_fork_context): Adjust
10774         fork_save_infrun_state calls.
10775
10776 2019-03-06  Pedro Alves  <palves@redhat.com>
10777
10778         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10779         (inf_has_multiple_threads): Return 'bool' and rewrite using
10780         inferior_info::threads().
10781
10782 2019-03-06  Pedro Alves  <palves@redhat.com>
10783
10784         * linux-fork.c: Include <list>.
10785         (fork_list): Now a std::list instance.
10786         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10787         (forks_exist_p, find_last_fork): Adjust.
10788         (new_fork): Delete.
10789         (one_fork_p): New.
10790         (add_fork): Adjust.
10791         (free_fork): Delete, folded into fork_info::~fork_info().
10792         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10793         Adjust.
10794         (init_fork_list): Delete.
10795         (linux_fork_killall, linux_fork_mourn_inferior)
10796         (linux_fork_detach, info_checkpoints_command): Adjust.
10797         (_initialize_linux_fork): No longer call init_fork_list.
10798
10799 2019-03-06  Pedro Alves  <palves@redhat.com>
10800
10801         * linux-fork.c (new_fork): New, split out of ...
10802         (add_fork): ... this.  Return void.  Move "first fork" special
10803         case from here, to ...
10804         (checkpoint_command): ... here.
10805         * linux-linux.h (add_fork): Return void.
10806
10807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10808
10809         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10810
10811 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10812             Chris January  <chris.january@arm.com>
10813             David Lecomber  <david.lecomber@arm.com>
10814
10815         * f-exp.y: New token, UNOP_INTRINSIC.
10816         (exp): New pattern using UNOP_INTRINSIC token.
10817         (f77_keywords): Add 'abs' keyword.
10818         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10819         (value_from_host_double): New function.
10820         (evaluate_subexp_f): Support UNOP_ABS.
10821
10822 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10823
10824         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10825         types.
10826
10827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10828
10829         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10830         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10831         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10832
10833 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10834
10835         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10836
10837 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10838             Chris January  <chris.january@arm.com>
10839
10840         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10841         * f-exp.y: Define 'KIND' token.
10842         (exp): New pattern for KIND expressions.
10843         (ptype): Handle types with a kind extension.
10844         (direct_abs_decl): Extend to spot kind extensions.
10845         (f77_keywords): Add 'kind' to the list.
10846         (push_kind_type): New function.
10847         (convert_to_kind_type): New function.
10848         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10849         * parse.c (operator_length_standard): Likewise.
10850         * parser-defs.h (enum type_pieces): Add tp_kind.
10851         * std-operator.def: Add UNOP_KIND.
10852
10853 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10854
10855         * f-exp.y (f_parse): Set yydebug.
10856
10857 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10858
10859         * f-lang.c (evaluate_subexp_f): New function.
10860         (exp_descriptor_f): New global.
10861         (f_language_defn): Use exp_descriptor_f instead of
10862         exp_descriptor_standard.
10863
10864 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10865
10866         * f-exp.y (struct token): Add comments.
10867         (dot_ops): Remove uppercase versions and the end marker.
10868         (f77_keywords): Likewise.
10869         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10870         entries in the dot_ops array are case insensitive, and use
10871         strncasecmp to compare strings.  Also some whitespace cleanup in
10872         this area.  Similar for the f77_keywords array, except entries in
10873         this list might be case sensitive.
10874
10875 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10876
10877         * f-exp.y (struct f77_boolean_val): Add comments.
10878         (boolean_values): Remove uppercase versions, and end marker.
10879         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10880         and use strncasecmp to achieve case insensitivity.  Additionally,
10881         perform whitespace cleanup around this code.
10882
10883 2019-03-06  Tom Tromey  <tromey@adacore.com>
10884
10885         * remote-sim.c (gdbsim_target_open): Use result of
10886         gdb_argv::release.
10887
10888 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10889         Dirk Schubert  <dirk.schubert@arm.com>
10890         Chris January  <chris.january@arm.com>
10891
10892         * eval.c (evaluate_subexp_standard): Call Fortran argument
10893         wrapping logic.
10894         * f-lang.c (struct value): A value which can be passed into a
10895         Fortran function call.
10896         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10897         where appropriate.
10898         (struct type): Value ready for a Fortran function call.
10899         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10900         is needed.
10901         * f-lang.h (fortran_argument_convert): Declaration.
10902         (fortran_preserve_arg_pointer): Declaration.
10903         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10904
10905 2019-03-05  Tom Tromey  <tromey@adacore.com>
10906
10907         * python/py-prettyprint.c (print_string_repr): Remove #if.
10908         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10909
10910 2019-03-05  Tom Tromey  <tromey@adacore.com>
10911
10912         * target.c (the_dummy_target): Move later.  Change type to
10913         "dummy_target".
10914         (initialize_targets): Don't initialize the_dummy_target.
10915
10916 2019-03-05  Tom Tromey  <tromey@adacore.com>
10917
10918         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10919         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10920
10921 2019-03-05  Tom Tromey  <tromey@adacore.com>
10922
10923         * windows-nat.c (windows_nat_target::attach)
10924         (windows_nat_target::detach): Don't call gdb_flush.
10925         * valprint.c (generic_val_print, val_print, val_print_string):
10926         Don't call gdb_flush.
10927         * utils.c (defaulted_query): Don't call gdb_flush.
10928         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10929         * target.c (target_announce_detach): Don't call gdb_flush.
10930         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10931         * remote.c (extended_remote_target::attach): Don't call
10932         gdb_flush.
10933         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10934         * printcmd.c (do_examine): Don't call gdb_flush.
10935         (info_display_command): Don't call gdb_flush.
10936         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10937         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10938         * memattr.c (info_mem_command): Don't call gdb_flush.
10939         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10940         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10941         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10942         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10943         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10944         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10945         (gnu_nat_target::detach): Don't call gdb_flush.
10946         * f-valprint.c (f_val_print): Don't call gdb_flush.
10947         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10948         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10949         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10950         gdb_flush.
10951         * c-valprint.c (c_val_print): Don't call gdb_flush.
10952         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10953
10954 2019-03-05  Tom Tromey  <tromey@adacore.com>
10955
10956         * varobj.c (update_dynamic_varobj_children): Update.
10957         (install_default_visualizer): Use reset, not release.
10958         * value.c (set_internalvar): Update.
10959         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10960         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10961         ATTRIBUTE_UNUSED_RESULT.
10962
10963 2019-03-05  Tom Tromey  <tromey@adacore.com>
10964
10965         * remote.c (class scoped_remote_fd) <release>: Add
10966         ATTRIBUTE_UNUSED_RESULT.
10967
10968 2019-03-05  Tom Tromey  <tromey@adacore.com>
10969
10970         * macroexp.c (struct macro_buffer) <release>: Add
10971         ATTRIBUTE_UNUSED_RESULT.
10972
10973 2019-03-05  Tom Tromey  <tromey@adacore.com>
10974
10975         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10976         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10977         ATTRIBUTE_UNUSED_RESULT.
10978
10979 2019-03-05  Tom Tromey  <tromey@adacore.com>
10980
10981         * common/scoped_fd.h (class scoped_fd) <release>: Add
10982         ATTRIBUTE_UNUSED_RESULT.
10983
10984 2019-03-05  Tom Tromey  <tromey@adacore.com>
10985
10986         * parser-defs.h (struct parser_state) <release>: Add
10987         ATTRIBUTE_UNUSED_RESULT.
10988
10989 2019-03-05  Tom Tromey  <tromey@adacore.com>
10990
10991         * utils.h (class gdb_argv) <release>: Add
10992         ATTRIBUTE_UNUSED_RESULT.
10993         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10994
10995 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10996
10997         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10998         for-loop range, to avoid compiler warnings.
10999
11000         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11001         avoid compiler warnings about unused variables.
11002
11003         * NEWS: Mention end of support for native debugging on MS-Windows
11004         before XP.
11005
11006         PR gdb/24292
11007         * common/netstuff.c:
11008         * gdbserver/gdbreplay.c
11009         * gdbserver/remote-utils.c:
11010         * ser-tcp.c:
11011         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11012         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11013         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11014         'getaddrinfo' and 'freeaddrinfo' were not available before
11015         Windows XP, and mingw.org's MinGW headers by default define
11016         _WIN32_WINNT to 0x500.
11017
11018 2019-03-01  Gary Benson <gbenson@redhat.com>
11019
11020         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11021
11022 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11023             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11024
11025         PR gdb/8527
11026         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11027         set_sigint_trap, clear_sigint_trap.
11028
11029 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11030
11031         * target.c (target_detach): Clear the regcache and the
11032         frame cache.
11033
11034 2019-02-27  Pedro Alves  <palves@redhat.com>
11035
11036         * utils.c (set_screen_size): When we cap the height/width sizes,
11037         tweak the corresponding command variable to show "unlimited":
11038
11039 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11040             Pedro Alves  <palves@redhat.com>
11041
11042         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11043         before calling rl_set_screen_size.
11044
11045 2019-02-27  Tom Tromey  <tromey@adacore.com>
11046
11047         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11048         define.
11049         * python/py-value.c: Remove Python 2.4 workaround.
11050         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11051         workaround.
11052         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11053         Python 2.4 workaround.
11054         * python/python-internal.h: Remove Python 2.4 comment.
11055         (Py_ssize_t): Don't define.
11056         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11057         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11058         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11059         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11060         * python/python.c (do_start_initialization): Remove Python 2.4
11061         workaround.
11062         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11063         (print_children): Remove Python 2.4 workaround.
11064         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11065         workaround.
11066         (CHARBUFFERPROC_NAME): Remove.
11067         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11068         Python 2.4 workaround.
11069
11070 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11071
11072         * NEWS: Note minimum Python version.
11073
11074 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11075
11076         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11077         code from these functions.  Remove corresponding ifdefs.  Use
11078         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11079         Remove gotos and target of gotos.
11080         (infpy_search_memory): Likewise.
11081
11082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11083
11084         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11085         (hppa_gdbarch_init): Don't register deleted functions with
11086         gdbarch.
11087
11088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11089
11090         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11091         (h8300_unwind_sp): Delete.
11092         (h8300_dummy_id): Delete.
11093         (h8300_gdbarch_init): Don't register deleted functions with
11094         gdbarch.
11095
11096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11097
11098         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11099         (ft32_unwind_pc): Delete.
11100         (ft32_unwind_sp): Delete.
11101         (ft32_gdbarch_init): Don't register deleted functions with
11102         gdbarch.
11103
11104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11105
11106         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11107         (frv_unwind_pc): Delete.
11108         (frv_unwind_sp): Delete.
11109         (frv_gdbarch_init): Don't register deleted functions with
11110         gdbarch.
11111
11112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11113
11114         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11115         (riscv_unwind_pc): Delete.
11116         (riscv_unwind_sp): Delete.
11117         (riscv_gdbarch_init): Don't register deleted functions with
11118         gdbarch.
11119
11120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11121
11122         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11123         (csky_unwind_pc): Delete.
11124         (csky_unwind_sp): Delete.
11125         (csky_gdbarch_init): Don't register deleted functions with
11126         gdbarch.
11127
11128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11129
11130         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11131         (cris_unwind_pc): Delete.
11132         (cris_unwind_sp): Delete.
11133         (cris_gdbarch_init): Don't register deleted functions with
11134         gdbarch.
11135
11136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11137
11138         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11139         (bfin_unwind_pc): Delete.
11140         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11141
11142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11143
11144         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11145         (arm_unwind_pc): Delete.
11146         (arm_unwind_sp): Delete.
11147         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11148
11149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11150
11151         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11152         (arc_unwind_pc): Delete.
11153         (arc_unwind_sp): Delete.
11154         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11155
11156 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11157
11158         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11159         (alpha_unwind_pc): Delete.
11160         (alpha_gdbarch_init): Don't register deleted functions with
11161         gdbarch.
11162
11163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11164
11165         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11166         (aarch64_unwind_pc): Delete.
11167         (aarch64_unwind_sp): Delete.
11168         (aarch64_gdbarch_init): Don't register deleted functions with
11169         gdbarch.
11170
11171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11172
11173         * gdbtypes.c (type_align): Don't consider static members when
11174         computing structure alignment.
11175
11176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11177
11178         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11179         return 0 for other types.
11180         * arch-utils.c (default_type_align): Always return 0.
11181         * gdbarch.h: Regenerate.
11182         * gdbarch.sh (type_align): Extend comment.
11183         * gdbtypes.c (type_align): Add additional comments, always call
11184         gdbarch_type_align before applying the default rules.
11185         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11186         generic code will then apply a suitable default.
11187         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11188         types, return 0 for other types.
11189
11190 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11191
11192         * NEWS: Create a new section for the next release branch.
11193         Rename the section of the current branch, now that it has
11194         been cut.
11195
11196 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11197
11198         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11199         * version.in: Bump version to 8.3.50.DATE-git.
11200
11201 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11202
11203         * aix-thread.c (ptid_cmp): Remove unused variable.
11204         (get_signaled_thread): Likewise.
11205         (store_regs_user_thread): Likewise.
11206         (store_regs_kernel_thread): Likewise.
11207         (fetch_regs_kernel_thread): Remove shadowed variable.
11208
11209 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11210
11211         * features/riscv/32bit-cpu.xml: Add register numbers.
11212         * features/riscv/32bit-fpu.c: Regenerate.
11213         * features/riscv/32bit-fpu.xml: Add register numbers.
11214         * features/riscv/64bit-cpu.xml: Add register numbers.
11215         * features/riscv/64bit-fpu.c: Regenerate.
11216         * features/riscv/64bit-fpu.xml: Add register numbers.
11217
11218 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11219
11220         * NEWS: Mention two argument form of gdb.Value constructor.
11221         * python/py-value.c (convert_buffer_and_type_to_value): New
11222         function.
11223         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11224         Add support for handling an optional second argument.  Call
11225         convert_buffer_and_type_to_value as appropriate.
11226         * python/python-internal.h (Py_buffer_deleter): New struct.
11227         (Py_buffer_up): New typedef.
11228
11229 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11230
11231         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11232         instead of releasing ownership.
11233
11234 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11235
11236         * dwarf2read.c (open_and_init_dwp_file): Call
11237         elf_numsections instead of bfd_count_sections to initialize
11238         dwp_file->num_sections.
11239
11240 2019-02-25  Tom Tromey  <tromey@adacore.com>
11241
11242         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11243
11244 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11245
11246         * gcore.in: Add '--readnever' option when invoking GDB.
11247
11248 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11249
11250         * MAINTAINERS: Update my email address.
11251
11252 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11253
11254         * build-id.c (build_id_to_debug_bfd_1): New function.
11255         (build_id_to_debug_bfd): Look for separate debug file in
11256         sysroot.
11257
11258 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11259
11260         * gdbarch.sh: Update the copyright year range that is placed into
11261         generated files.
11262
11263 2019-02-22  Keith Seitz  <keiths@redhat.com>
11264
11265         PR symtab/23853
11266         * linespec.c (create_sals_line_offset): Search for the default
11267         symtab's filename instead of its fullname.
11268
11269 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11270
11271         * NEWS: Update style defaults.
11272
11273 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11274
11275         * main.c (captured_main_1): Disable styling in batch mode.
11276
11277 2019-02-20  Tom Tromey  <tom@tromey.com>
11278
11279         * symtab.c (symtab_symbol_info): Fix typos.
11280
11281 2019-02-20  Tom Tromey  <tromey@adacore.com>
11282
11283         * findcmd.c (_initialize_mem_search): Use upper case for
11284         metasyntactic variables.
11285
11286 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11287
11288         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11289         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11290
11291 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11292
11293         * top.h (source_file_name): Change to std::string.
11294         * top.c (source_file_name): Likewise.
11295         (command_line_input): Adjust.
11296         * cli/cli-script.c (script_from_file): Adjust.
11297
11298 2019-02-19  Tom Tromey  <tromey@adacore.com>
11299
11300         * ravenscar-thread.c
11301         (ravenscar_thread_target::update_thread_list): Don't call
11302         ada_build_task_list.
11303         * ada-lang.h (ada_build_task_list): Don't declare.
11304         * ada-tasks.c (struct ada_tasks_inferior_data)
11305         <task_list_valid_p>: Now bool.
11306         (read_known_tasks, ada_task_list_changed)
11307         (ada_tasks_invalidate_inferior_data): Update.
11308         (read_known_tasks_array): Return bool.
11309         (read_known_tasks_list): Likewise.
11310         (read_known_tasks): Return void.
11311         (ada_build_task_list): Now static.
11312
11313 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11314
11315         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11316         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11317
11318 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11319
11320         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11321         variant for ada_tasks_pspace_data_handle and
11322         ada_tasks_inferior_data_handle.
11323         (ada_tasks_pspace_data_cleanup): New function.
11324         (ada_tasks_inferior_data_cleanup): New function.
11325
11326 2019-02-17  Tom Tromey  <tom@tromey.com>
11327
11328         * macrotab.h (macro_source_fullname): Return a std::string.
11329         * macrotab.c (macro_include, check_for_redefinition)
11330         (macro_undef, macro_lookup_definition, foreach_macro)
11331         (foreach_macro_in_scope): Update.
11332         (macro_source_fullname): Return a std::string.
11333         * macrocmd.c (show_pp_source_pos): Update.
11334
11335 2019-02-17  Tom Tromey  <tom@tromey.com>
11336
11337         * macrocmd.c (show_pp_source_pos): Style the file names.
11338
11339 2019-02-17  Tom Tromey  <tom@tromey.com>
11340
11341         PR tui/24197:
11342         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11343
11344 2019-02-17  Tom Tromey  <tom@tromey.com>
11345
11346         * ada-lang.c (user_select_syms): Use filtered printing.
11347         * utils.c (wrap_style): New global.
11348         (desired_style): Remove.
11349         (emit_style_escape): Add stream parameter.
11350         (set_output_style, reset_terminal_style, prompt_for_continue):
11351         Update.
11352         (flush_wrap_buffer): Only flush gdb_stdout.
11353         (wrap_here): Set wrap_style.
11354         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11355         treat escape sequences as a character.  Change when wrap buffer is
11356         flushed.
11357         (fputs_styled): Do not set the output style when the default is
11358         requested.
11359         * ui-style.h (struct ui_file_style) <is_default>: New method.
11360         * source.c (print_source_lines_base): Emit escape sequences in one
11361         piece.
11362
11363 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11364
11365         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11366         integers and enumeration types.
11367
11368 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11369
11370         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11371         instead of lookup_symbol_in_language
11372         (do_exact_match): New function.
11373         (ada_get_symbol_name_matcher): Return do_exact_match when
11374         doing a verbatim match.
11375
11376 2019-02-15  Tom Tromey  <tromey@adacore.com>
11377
11378         * ravenscar-thread.c (ravenscar_thread_target::resume)
11379         (ravenscar_thread_target::wait): Special case wildcard requests.
11380
11381 2019-02-15  Tom Tromey  <tromey@adacore.com>
11382
11383         * ravenscar-thread.c (base_ptid): Remove.
11384         (struct ravenscar_thread_target) <close>: New method.
11385         <m_base_ptid>: New member.
11386         <update_inferior_ptid, active_task, task_is_currently_active,
11387         runtime_initialized>: Declare methods.
11388         <ravenscar_thread_target>: Add constructor.
11389         (ravenscar_thread_target::task_is_currently_active)
11390         (ravenscar_thread_target::update_inferior_ptid)
11391         (ravenscar_runtime_initialized): Rename.  Now methods.
11392         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11393         (ravenscar_thread_target::update_thread_list): Update.
11394         (ravenscar_thread_target::active_task): Now method.
11395         (ravenscar_thread_target::store_registers)
11396         (ravenscar_thread_target::prepare_to_store)
11397         (ravenscar_thread_target::prepare_to_store)
11398         (ravenscar_thread_target::mourn_inferior): Update.
11399         (ravenscar_inferior_created): Use "new" to create target.
11400         (ravenscar_thread_target::get_ada_task_ptid): Update.
11401         (_initialize_ravenscar): Don't initialize base_ptid.
11402         (ravenscar_ops): Remove global.
11403
11404 2019-02-15  Tom Tromey  <tromey@adacore.com>
11405
11406         * target.h (push_target): Declare new overload.
11407         * target.c (push_target): New overload, taking an rvalue reference.
11408         * remote.c (remote_target::open_1): Use push_target overload.
11409         * corelow.c (core_target_open): Use push_target overload.
11410
11411 2019-02-15  Tom Tromey  <tromey@adacore.com>
11412
11413         * ravenscar-thread.c (is_ravenscar_task)
11414         (ravenscar_task_is_currently_active): Return bool.
11415         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11416         (_initialize_ravenscar): Remove "(void)".
11417         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11418         Return bool.
11419
11420 2019-02-15  Tom Tromey  <tromey@adacore.com>
11421
11422         * ravenscar-thread.c (ravenscar_runtime_initializer)
11423         (has_ravenscar_runtime, get_running_thread_id)
11424         (ravenscar_thread_target::resume): Fix indentation.
11425
11426 2019-02-15  Tom Tromey  <tromey@adacore.com>
11427
11428         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11429         from ravenscar_arch_ops.
11430         (sparc_ravenscar_ops::fetch_registers)
11431         (sparc_ravenscar_ops::store_registers): Now methods.
11432         (sparc_ravenscar_prepare_to_store): Remove.
11433         (sparc_ravenscar_ops): Redefine.
11434         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11435         methods and destructor.  Remove members.
11436         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11437         (ravenscar_thread_target::store_registers)
11438         (ravenscar_thread_target::prepare_to_store): Update.
11439         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11440         Remove.
11441         (struct ppc_ravenscar_powerpc_ops): Derive from
11442         ravenscar_arch_ops.
11443         (ppc_ravenscar_powerpc_ops::fetch_registers)
11444         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11445         (ppc_ravenscar_powerpc_ops): Redefine.
11446         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11447         (ppc_ravenscar_e500_ops::fetch_registers)
11448         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11449         (ppc_ravenscar_e500_ops): Redefine.
11450         * aarch64-ravenscar-thread.c
11451         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11452         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11453         (aarch64_ravenscar_fetch_registers)
11454         (aarch64_ravenscar_store_registers): Now methods.
11455         (aarch64_ravenscar_ops): Redefine.
11456
11457 2019-02-15  Tom Tromey  <tromey@adacore.com>
11458
11459         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11460         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11461         (ravenscar_thread_target::stopped_by_watchpoint)
11462         (ravenscar_thread_target::stopped_data_address)
11463         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11464
11465 2019-02-15  Tom Tromey  <tromey@adacore.com>
11466
11467         * ravenscar-thread.c: Fix some typos.
11468
11469 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11470             Tom Tromey  <tromey@adacore.com>
11471
11472         * ada-lang.c (ada_exception_sal): Change addr_string to a
11473         std::string.
11474         (create_ada_exception_catchpoint): Update.
11475
11476 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11477             Tom Tromey  <tromey@adacore.com>
11478
11479         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11480         (bp_location_ops): Remove.
11481         (base_breakpoint_allocate_location): Update.
11482         (free_bp_location): Update.
11483         * ada-lang.c (class ada_catchpoint_location)
11484         <ada_catchpoint_location>: Remove ops parameter.
11485         (ada_catchpoint_location_dtor): Remove.
11486         (ada_catchpoint_location_ops): Remove.
11487         (allocate_location_exception): Update.
11488         * breakpoint.h (struct bp_location_ops): Remove.
11489         (class bp_location) <bp_location>: Remove bp_location_ops
11490         parameter.
11491         <~bp_location>: Add destructor.
11492         <ops>: Remove.
11493
11494 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11495             Pedro Alves  <palves@redhat.com>
11496
11497         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11498         'PATH_MAX'.
11499
11500 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11501             Samuel Thibault  <samuel.thibault@gnu.org>
11502             Thomas Schwinge  <thomas@codesourcery.com>
11503
11504         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11505         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11506
11507 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11508
11509         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11510         (check_empty): Use "const char *".
11511
11512         * gnu-nat.c (gnu_nat_target::detach): Instead of
11513         'detach_inferior (pid)' call
11514         'detach_inferior (find_inferior_pid (pid))'.
11515
11516         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11517         'nat/fork-inferior.o'.
11518         * gnu-nat.c: #include "nat/fork-inferior.h".
11519
11520         * gnu-nat.c (gnu_nat_target::detach): Instead of
11521         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11522         * gnu-nat.h: #include "inf-child.h".
11523         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11524         'i386_gnu_nat_target::fetch_registers'.
11525         (gnu_store_registers): Rename/move to
11526         'i386_gnu_nat_target::store_registers'.
11527
11528         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11529         * gnu-nat.h (mach_thread_info): New function.
11530         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11531
11532         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11533
11534 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11535
11536         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11537
11538 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11539
11540         * windows-nat.c (windows_add_thread): Add new parameter
11541         "main_thread_p" with default value set to false.  Update
11542         function documentation as well as all callers.
11543         (windows_delete_thread): Likewise.
11544         (fake_create_process): Update call to windows_add_thread.
11545         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11546         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11547         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11548         call to windows_delete_thread.
11549
11550 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11551
11552         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11553
11554 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11555
11556         * symfile.c (find_separate_debug_file): Use canonical path of
11557         sysroot with child_path instead of gdb_sysroot if it is valid.
11558
11559 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11560
11561         * symfile.c (find_separate_debug_file): Use child_path to
11562         determine if an object file is under a sysroot.
11563
11564 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11565
11566         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11567         unittests/child-path-selftests.c.
11568         * common/pathstuff.c (child_path): New function.
11569         * common/pathstuff.h (child_path): New prototype.
11570         * unittests/child-path-selftests.c: New file.
11571
11572 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11573
11574         * symfile.c (find_separate_debug_file): Look for separate debug
11575         files in debug directories under the sysroot.
11576
11577 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11578
11579         * symtab.h (struct minimal_symbol data_p): New const method.
11580         (struct minimal_symbol text_p): Likewise.
11581         * symtab.c (output_source_filename): Use file name style
11582         to print file name.
11583         (print_symbol_info): Likewise.
11584         (print_msymbol_info): Use address style to print addresses.
11585         Use function name style to print executable text symbols.
11586         (expand_symtab_containing_pc): Use data_p.
11587         (find_pc_sect_compunit_symtab): Likewise.
11588
11589 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11590
11591         * breakpoint.c (describe_other_breakpoints): Use address style
11592         to print addresses.
11593         (say_where): Likewise.
11594
11595 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11596
11597         * ada-typeprint.c (print_func_type): Print function name
11598         style to print function name.
11599         * c-typeprint.c (c_print_type_1): Likewise.
11600
11601 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11602
11603         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11604         for execve.
11605
11606 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11607
11608         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11609         type_stack.
11610
11611 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11612
11613         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11614         TYPE_CODE_REF types.
11615
11616 2019-02-08  Jim Wilson  <jimw@sifive.com>
11617
11618         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11619         (riscv_linux_fregset): New.
11620         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11621
11622 2019-02-07  Tom Tromey  <tom@tromey.com>
11623
11624         * thread.c (thread_cancel_execution_command): Update.
11625         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11626         methods.
11627         (struct thread_fsm_ops): Remove.
11628         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11629         (thread_fsm_should_stop, thread_fsm_return_value)
11630         (thread_fsm_set_finished, thread_fsm_finished_p)
11631         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11632         Don't declare.
11633         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11634         * infrun.c (clear_proceed_status_thread)
11635         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11636         (print_stop_event): Update.
11637         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11638         Add constructor.
11639         (step_command_fsm_ops): Remove.
11640         (new_step_command_fsm): Remove.
11641         (step_1): Update.
11642         (step_command_fsm::should_stop): Rename from
11643         step_command_fsm_should_stop.
11644         (step_command_fsm::clean_up): Rename from
11645         step_command_fsm_clean_up.
11646         (step_command_fsm::do_async_reply_reason): Rename from
11647         step_command_fsm_async_reply_reason.
11648         (struct until_next_fsm): Inherit from thread_fsm.  Add
11649         constructor.
11650         (until_next_fsm_ops): Remove.
11651         (new_until_next_fsm): Remove.
11652         (until_next_fsm::should_stop): Rename from
11653         until_next_fsm_should_stop.
11654         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11655         (until_next_fsm::do_async_reply_reason): Rename from
11656         until_next_fsm_async_reply_reason.
11657         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11658         constructor.  Change type of breakpoint.
11659         (finish_command_fsm_ops): Remove.
11660         (new_finish_command_fsm): Remove.
11661         (finish_command_fsm::should_stop): Rename from
11662         finish_command_fsm_should_stop.
11663         (finish_command_fsm::clean_up): Rename from
11664         finish_command_fsm_clean_up.
11665         (finish_command_fsm::return_value): Rename from
11666         finish_command_fsm_return_value.
11667         (finish_command_fsm::do_async_reply_reason): Rename from
11668         finish_command_fsm_async_reply_reason.
11669         (finish_command): Update.
11670         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11671         Add constructor.
11672         (call_thread_fsm_ops): Remove.
11673         (call_thread_fsm::call_thread_fsm): Rename from
11674         new_call_thread_fsm.
11675         (call_thread_fsm::should_stop): Rename from
11676         call_thread_fsm_should_stop.
11677         (call_thread_fsm::should_notify_stop): Rename from
11678         call_thread_fsm_should_notify_stop.
11679         (run_inferior_call, call_function_by_hand_dummy): Update.
11680         * cli/cli-interp.c (should_print_stop_to_console): Update.
11681         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11682         Add constructor.  Change type of location_breakpoint,
11683         caller_breakpoint.
11684         (until_break_fsm_ops): Remove.
11685         (new_until_break_fsm): Remove.
11686         (until_break_fsm::should_stop): Rename from
11687         until_break_fsm_should_stop.
11688         (until_break_fsm::clean_up): Rename from
11689         until_break_fsm_clean_up.
11690         (until_break_fsm::do_async_reply_reason): Rename from
11691         until_break_fsm_async_reply_reason.
11692         (until_break_command): Update.
11693         * thread-fsm.c: Remove.
11694         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11695
11696 2019-02-07  Tom Tromey  <tom@tromey.com>
11697
11698         * yy-remap.h: Add include guard.
11699         * xtensa-tdep.h: Add include guard.
11700         * xcoffread.h: Rename include guard.
11701         * varobj-iter.h: Add include guard.
11702         * tui/tui.h: Rename include guard.
11703         * tui/tui-winsource.h: Rename include guard.
11704         * tui/tui-wingeneral.h: Rename include guard.
11705         * tui/tui-windata.h: Rename include guard.
11706         * tui/tui-win.h: Rename include guard.
11707         * tui/tui-stack.h: Rename include guard.
11708         * tui/tui-source.h: Rename include guard.
11709         * tui/tui-regs.h: Rename include guard.
11710         * tui/tui-out.h: Rename include guard.
11711         * tui/tui-layout.h: Rename include guard.
11712         * tui/tui-io.h: Rename include guard.
11713         * tui/tui-hooks.h: Rename include guard.
11714         * tui/tui-file.h: Rename include guard.
11715         * tui/tui-disasm.h: Rename include guard.
11716         * tui/tui-data.h: Rename include guard.
11717         * tui/tui-command.h: Rename include guard.
11718         * tic6x-tdep.h: Add include guard.
11719         * target/waitstatus.h: Rename include guard.
11720         * target/wait.h: Rename include guard.
11721         * target/target.h: Rename include guard.
11722         * target/resume.h: Rename include guard.
11723         * target-float.h: Rename include guard.
11724         * stabsread.h: Add include guard.
11725         * rs6000-tdep.h: Add include guard.
11726         * riscv-fbsd-tdep.h: Add include guard.
11727         * regformats/regdef.h: Rename include guard.
11728         * record.h: Rename include guard.
11729         * python/python.h: Rename include guard.
11730         * python/python-internal.h: Rename include guard.
11731         * python/py-stopevent.h: Rename include guard.
11732         * python/py-ref.h: Rename include guard.
11733         * python/py-record.h: Rename include guard.
11734         * python/py-record-full.h: Rename include guard.
11735         * python/py-record-btrace.h: Rename include guard.
11736         * python/py-instruction.h: Rename include guard.
11737         * python/py-events.h: Rename include guard.
11738         * python/py-event.h: Rename include guard.
11739         * procfs.h: Add include guard.
11740         * proc-utils.h: Add include guard.
11741         * p-lang.h: Add include guard.
11742         * or1k-tdep.h: Rename include guard.
11743         * observable.h: Rename include guard.
11744         * nto-tdep.h: Rename include guard.
11745         * nat/x86-linux.h: Rename include guard.
11746         * nat/x86-linux-dregs.h: Rename include guard.
11747         * nat/x86-gcc-cpuid.h: Add include guard.
11748         * nat/x86-dregs.h: Rename include guard.
11749         * nat/x86-cpuid.h: Rename include guard.
11750         * nat/ppc-linux.h: Rename include guard.
11751         * nat/mips-linux-watch.h: Rename include guard.
11752         * nat/linux-waitpid.h: Rename include guard.
11753         * nat/linux-ptrace.h: Rename include guard.
11754         * nat/linux-procfs.h: Rename include guard.
11755         * nat/linux-osdata.h: Rename include guard.
11756         * nat/linux-nat.h: Rename include guard.
11757         * nat/linux-namespaces.h: Rename include guard.
11758         * nat/linux-btrace.h: Rename include guard.
11759         * nat/glibc_thread_db.h: Rename include guard.
11760         * nat/gdb_thread_db.h: Rename include guard.
11761         * nat/gdb_ptrace.h: Rename include guard.
11762         * nat/fork-inferior.h: Rename include guard.
11763         * nat/amd64-linux-siginfo.h: Rename include guard.
11764         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11765         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11766         * nat/aarch64-linux.h: Rename include guard.
11767         * nat/aarch64-linux-hw-point.h: Rename include guard.
11768         * mn10300-tdep.h: Add include guard.
11769         * mips-linux-tdep.h: Add include guard.
11770         * mi/mi-parse.h: Rename include guard.
11771         * mi/mi-out.h: Rename include guard.
11772         * mi/mi-main.h: Rename include guard.
11773         * mi/mi-interp.h: Rename include guard.
11774         * mi/mi-getopt.h: Rename include guard.
11775         * mi/mi-console.h: Rename include guard.
11776         * mi/mi-common.h: Rename include guard.
11777         * mi/mi-cmds.h: Rename include guard.
11778         * mi/mi-cmd-break.h: Rename include guard.
11779         * m2-lang.h: Add include guard.
11780         * location.h: Rename include guard.
11781         * linux-record.h: Rename include guard.
11782         * linux-nat.h: Add include guard.
11783         * linux-fork.h: Add include guard.
11784         * i386-darwin-tdep.h: Rename include guard.
11785         * hppa-linux-offsets.h: Add include guard.
11786         * guile/guile.h: Rename include guard.
11787         * guile/guile-internal.h: Rename include guard.
11788         * gnu-nat.h: Rename include guard.
11789         * gdb-stabs.h: Rename include guard.
11790         * frv-tdep.h: Add include guard.
11791         * f-lang.h: Add include guard.
11792         * event-loop.h: Add include guard.
11793         * darwin-nat.h: Rename include guard.
11794         * cp-abi.h: Rename include guard.
11795         * config/sparc/nm-sol2.h: Rename include guard.
11796         * config/nm-nto.h: Rename include guard.
11797         * config/nm-linux.h: Add include guard.
11798         * config/i386/nm-i386gnu.h: Rename include guard.
11799         * config/djgpp/nl_types.h: Rename include guard.
11800         * config/djgpp/langinfo.h: Rename include guard.
11801         * compile/gcc-cp-plugin.h: Add include guard.
11802         * compile/gcc-c-plugin.h: Add include guard.
11803         * compile/compile.h: Rename include guard.
11804         * compile/compile-object-run.h: Rename include guard.
11805         * compile/compile-object-load.h: Rename include guard.
11806         * compile/compile-internal.h: Rename include guard.
11807         * compile/compile-cplus.h: Rename include guard.
11808         * compile/compile-c.h: Rename include guard.
11809         * common/xml-utils.h: Rename include guard.
11810         * common/x86-xstate.h: Rename include guard.
11811         * common/version.h: Rename include guard.
11812         * common/vec.h: Rename include guard.
11813         * common/tdesc.h: Rename include guard.
11814         * common/selftest.h: Rename include guard.
11815         * common/scoped_restore.h: Rename include guard.
11816         * common/scoped_mmap.h: Rename include guard.
11817         * common/scoped_fd.h: Rename include guard.
11818         * common/safe-iterator.h: Rename include guard.
11819         * common/run-time-clock.h: Rename include guard.
11820         * common/refcounted-object.h: Rename include guard.
11821         * common/queue.h: Rename include guard.
11822         * common/ptid.h: Rename include guard.
11823         * common/print-utils.h: Rename include guard.
11824         * common/preprocessor.h: Rename include guard.
11825         * common/pathstuff.h: Rename include guard.
11826         * common/observable.h: Rename include guard.
11827         * common/netstuff.h: Rename include guard.
11828         * common/job-control.h: Rename include guard.
11829         * common/host-defs.h: Rename include guard.
11830         * common/gdb_wait.h: Rename include guard.
11831         * common/gdb_vecs.h: Rename include guard.
11832         * common/gdb_unlinker.h: Rename include guard.
11833         * common/gdb_unique_ptr.h: Rename include guard.
11834         * common/gdb_tilde_expand.h: Rename include guard.
11835         * common/gdb_sys_time.h: Rename include guard.
11836         * common/gdb_string_view.h: Rename include guard.
11837         * common/gdb_splay_tree.h: Rename include guard.
11838         * common/gdb_setjmp.h: Rename include guard.
11839         * common/gdb_ref_ptr.h: Rename include guard.
11840         * common/gdb_optional.h: Rename include guard.
11841         * common/gdb_locale.h: Rename include guard.
11842         * common/gdb_assert.h: Rename include guard.
11843         * common/filtered-iterator.h: Rename include guard.
11844         * common/filestuff.h: Rename include guard.
11845         * common/fileio.h: Rename include guard.
11846         * common/environ.h: Rename include guard.
11847         * common/common-utils.h: Rename include guard.
11848         * common/common-types.h: Rename include guard.
11849         * common/common-regcache.h: Rename include guard.
11850         * common/common-inferior.h: Rename include guard.
11851         * common/common-gdbthread.h: Rename include guard.
11852         * common/common-exceptions.h: Rename include guard.
11853         * common/common-defs.h: Rename include guard.
11854         * common/common-debug.h: Rename include guard.
11855         * common/cleanups.h: Rename include guard.
11856         * common/buffer.h: Rename include guard.
11857         * common/btrace-common.h: Rename include guard.
11858         * common/break-common.h: Rename include guard.
11859         * cli/cli-utils.h: Rename include guard.
11860         * cli/cli-style.h: Rename include guard.
11861         * cli/cli-setshow.h: Rename include guard.
11862         * cli/cli-script.h: Rename include guard.
11863         * cli/cli-interp.h: Rename include guard.
11864         * cli/cli-decode.h: Rename include guard.
11865         * cli/cli-cmds.h: Rename include guard.
11866         * charset-list.h: Add include guard.
11867         * buildsym-legacy.h: Rename include guard.
11868         * bfin-tdep.h: Add include guard.
11869         * ax.h: Rename include guard.
11870         * arm-linux-tdep.h: Add include guard.
11871         * arm-fbsd-tdep.h: Add include guard.
11872         * arch/xtensa.h: Rename include guard.
11873         * arch/tic6x.h: Add include guard.
11874         * arch/i386.h: Add include guard.
11875         * arch/arm.h: Rename include guard.
11876         * arch/arm-linux.h: Rename include guard.
11877         * arch/arm-get-next-pcs.h: Rename include guard.
11878         * arch/amd64.h: Add include guard.
11879         * arch/aarch64-insn.h: Rename include guard.
11880         * arch-utils.h: Rename include guard.
11881         * annotate.h: Add include guard.
11882         * amd64-darwin-tdep.h: Rename include guard.
11883         * aarch64-linux-tdep.h: Add include guard.
11884         * aarch64-fbsd-tdep.h: Add include guard.
11885         * aarch32-linux-nat.h: Add include guard.
11886
11887 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11888
11889         * macrotab.c (macro_define_internal): New function that
11890         factorizes macro_define_object_internal and macro_define_function
11891         code.
11892         (macro_define_object_internal): Use macro_define_internal.
11893         (macro_define_function): Likewise.
11894
11895 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11896
11897         * macrocmd.c (extract_identifier): Return
11898         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11899         callers.
11900
11901 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11902
11903         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11904
11905 2019-02-05  Tom Tromey  <tom@tromey.com>
11906
11907         * target.c (target_stack::unpush): Move assertion earlier.
11908
11909 2019-01-30  Tom Tromey  <tom@tromey.com>
11910
11911         PR python/23615:
11912         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11913         (gdbpy_parse_and_eval): Likewise.
11914         * python/python-internal.h (gdbpy_allow_threads): New class.
11915
11916 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11917
11918         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11919         (aarch64_fbsd_fpregmap): Move earlier.
11920         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11921         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11922         instead of individual calls to trad_frame_set_reg_addr.
11923         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11924         earlier.
11925         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11926         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11927         instead of individual calls to trad_frame_set_reg_addr.
11928
11929 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11930
11931         * CONTRIBUTE: Replace contribution list with wiki link.
11932
11933 2019-01-25  Tom Tromey  <tom@tromey.com>
11934
11935         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11936
11937 2019-01-25  Tom Tromey  <tom@tromey.com>
11938
11939         * xtensa-linux-nat.c: Fix common/ includes.
11940         * xml-support.h: Fix common/ includes.
11941         * xml-support.c: Fix common/ includes.
11942         * x86-linux-nat.c: Fix common/ includes.
11943         * windows-nat.c: Fix common/ includes.
11944         * varobj.h: Fix common/ includes.
11945         * varobj.c: Fix common/ includes.
11946         * value.c: Fix common/ includes.
11947         * valops.c: Fix common/ includes.
11948         * utils.c: Fix common/ includes.
11949         * unittests/xml-utils-selftests.c: Fix common/ includes.
11950         * unittests/utils-selftests.c: Fix common/ includes.
11951         * unittests/unpack-selftests.c: Fix common/ includes.
11952         * unittests/tracepoint-selftests.c: Fix common/ includes.
11953         * unittests/style-selftests.c: Fix common/ includes.
11954         * unittests/string_view-selftests.c: Fix common/ includes.
11955         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11956         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11957         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11958         * unittests/rsp-low-selftests.c: Fix common/ includes.
11959         * unittests/parse-connection-spec-selftests.c: Fix common/
11960         includes.
11961         * unittests/optional-selftests.c: Fix common/ includes.
11962         * unittests/offset-type-selftests.c: Fix common/ includes.
11963         * unittests/observable-selftests.c: Fix common/ includes.
11964         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11965         * unittests/memrange-selftests.c: Fix common/ includes.
11966         * unittests/memory-map-selftests.c: Fix common/ includes.
11967         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11968         * unittests/function-view-selftests.c: Fix common/ includes.
11969         * unittests/environ-selftests.c: Fix common/ includes.
11970         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11971         * unittests/common-utils-selftests.c: Fix common/ includes.
11972         * unittests/cli-utils-selftests.c: Fix common/ includes.
11973         * unittests/array-view-selftests.c: Fix common/ includes.
11974         * ui-file.c: Fix common/ includes.
11975         * tui/tui-io.c: Fix common/ includes.
11976         * tracepoint.h: Fix common/ includes.
11977         * tracepoint.c: Fix common/ includes.
11978         * tracefile-tfile.c: Fix common/ includes.
11979         * top.h: Fix common/ includes.
11980         * top.c: Fix common/ includes.
11981         * thread.c: Fix common/ includes.
11982         * target/waitstatus.h: Fix common/ includes.
11983         * target/waitstatus.c: Fix common/ includes.
11984         * target.h: Fix common/ includes.
11985         * target.c: Fix common/ includes.
11986         * target-memory.c: Fix common/ includes.
11987         * target-descriptions.c: Fix common/ includes.
11988         * symtab.h: Fix common/ includes.
11989         * symfile.c: Fix common/ includes.
11990         * stap-probe.c: Fix common/ includes.
11991         * spu-linux-nat.c: Fix common/ includes.
11992         * sparc-nat.c: Fix common/ includes.
11993         * source.c: Fix common/ includes.
11994         * solib.c: Fix common/ includes.
11995         * solib-target.c: Fix common/ includes.
11996         * ser-unix.c: Fix common/ includes.
11997         * ser-tcp.c: Fix common/ includes.
11998         * ser-pipe.c: Fix common/ includes.
11999         * ser-base.c: Fix common/ includes.
12000         * selftest-arch.c: Fix common/ includes.
12001         * s12z-tdep.c: Fix common/ includes.
12002         * rust-exp.y: Fix common/ includes.
12003         * rs6000-aix-tdep.c: Fix common/ includes.
12004         * riscv-tdep.c: Fix common/ includes.
12005         * remote.c: Fix common/ includes.
12006         * remote-notif.h: Fix common/ includes.
12007         * remote-fileio.h: Fix common/ includes.
12008         * remote-fileio.c: Fix common/ includes.
12009         * regcache.h: Fix common/ includes.
12010         * regcache.c: Fix common/ includes.
12011         * record-btrace.c: Fix common/ includes.
12012         * python/python.c: Fix common/ includes.
12013         * python/py-type.c: Fix common/ includes.
12014         * python/py-inferior.c: Fix common/ includes.
12015         * progspace.h: Fix common/ includes.
12016         * producer.c: Fix common/ includes.
12017         * procfs.c: Fix common/ includes.
12018         * proc-api.c: Fix common/ includes.
12019         * printcmd.c: Fix common/ includes.
12020         * ppc-linux-nat.c: Fix common/ includes.
12021         * parser-defs.h: Fix common/ includes.
12022         * osdata.c: Fix common/ includes.
12023         * obsd-nat.c: Fix common/ includes.
12024         * nat/x86-linux.c: Fix common/ includes.
12025         * nat/x86-linux-dregs.c: Fix common/ includes.
12026         * nat/x86-dregs.h: Fix common/ includes.
12027         * nat/x86-dregs.c: Fix common/ includes.
12028         * nat/ppc-linux.c: Fix common/ includes.
12029         * nat/mips-linux-watch.h: Fix common/ includes.
12030         * nat/mips-linux-watch.c: Fix common/ includes.
12031         * nat/linux-waitpid.c: Fix common/ includes.
12032         * nat/linux-ptrace.h: Fix common/ includes.
12033         * nat/linux-ptrace.c: Fix common/ includes.
12034         * nat/linux-procfs.c: Fix common/ includes.
12035         * nat/linux-personality.c: Fix common/ includes.
12036         * nat/linux-osdata.c: Fix common/ includes.
12037         * nat/linux-namespaces.c: Fix common/ includes.
12038         * nat/linux-btrace.h: Fix common/ includes.
12039         * nat/linux-btrace.c: Fix common/ includes.
12040         * nat/fork-inferior.c: Fix common/ includes.
12041         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12042         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12043         * nat/aarch64-linux.c: Fix common/ includes.
12044         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12045         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12046         * namespace.h: Fix common/ includes.
12047         * mips-linux-tdep.c: Fix common/ includes.
12048         * minsyms.c: Fix common/ includes.
12049         * mi/mi-parse.h: Fix common/ includes.
12050         * mi/mi-main.c: Fix common/ includes.
12051         * mi/mi-cmd-env.c: Fix common/ includes.
12052         * memrange.h: Fix common/ includes.
12053         * memattr.c: Fix common/ includes.
12054         * maint.h: Fix common/ includes.
12055         * maint.c: Fix common/ includes.
12056         * main.c: Fix common/ includes.
12057         * machoread.c: Fix common/ includes.
12058         * location.c: Fix common/ includes.
12059         * linux-thread-db.c: Fix common/ includes.
12060         * linux-nat.c: Fix common/ includes.
12061         * linux-fork.c: Fix common/ includes.
12062         * inline-frame.c: Fix common/ includes.
12063         * infrun.c: Fix common/ includes.
12064         * inflow.c: Fix common/ includes.
12065         * inferior.h: Fix common/ includes.
12066         * inferior.c: Fix common/ includes.
12067         * infcmd.c: Fix common/ includes.
12068         * inf-ptrace.c: Fix common/ includes.
12069         * inf-child.c: Fix common/ includes.
12070         * ia64-linux-nat.c: Fix common/ includes.
12071         * i387-tdep.c: Fix common/ includes.
12072         * i386-tdep.c: Fix common/ includes.
12073         * i386-linux-tdep.c: Fix common/ includes.
12074         * i386-linux-nat.c: Fix common/ includes.
12075         * i386-go32-tdep.c: Fix common/ includes.
12076         * i386-fbsd-tdep.c: Fix common/ includes.
12077         * i386-fbsd-nat.c: Fix common/ includes.
12078         * guile/scm-type.c: Fix common/ includes.
12079         * guile/guile.c: Fix common/ includes.
12080         * go32-nat.c: Fix common/ includes.
12081         * gnu-nat.c: Fix common/ includes.
12082         * gdbthread.h: Fix common/ includes.
12083         * gdbarch-selftests.c: Fix common/ includes.
12084         * gdb_usleep.c: Fix common/ includes.
12085         * gdb_select.h: Fix common/ includes.
12086         * gdb_bfd.c: Fix common/ includes.
12087         * gcore.c: Fix common/ includes.
12088         * fork-child.c: Fix common/ includes.
12089         * findvar.c: Fix common/ includes.
12090         * fbsd-nat.c: Fix common/ includes.
12091         * event-top.c: Fix common/ includes.
12092         * event-loop.c: Fix common/ includes.
12093         * dwarf2read.c: Fix common/ includes.
12094         * dwarf2loc.c: Fix common/ includes.
12095         * dwarf2-frame.c: Fix common/ includes.
12096         * dwarf-index-cache.c: Fix common/ includes.
12097         * dtrace-probe.c: Fix common/ includes.
12098         * disasm-selftests.c: Fix common/ includes.
12099         * defs.h: Fix common/ includes.
12100         * csky-tdep.c: Fix common/ includes.
12101         * cp-valprint.c: Fix common/ includes.
12102         * cp-support.h: Fix common/ includes.
12103         * cp-support.c: Fix common/ includes.
12104         * corelow.c: Fix common/ includes.
12105         * completer.h: Fix common/ includes.
12106         * completer.c: Fix common/ includes.
12107         * compile/compile.c: Fix common/ includes.
12108         * compile/compile-loc2c.c: Fix common/ includes.
12109         * compile/compile-cplus-types.c: Fix common/ includes.
12110         * compile/compile-cplus-symbols.c: Fix common/ includes.
12111         * command.h: Fix common/ includes.
12112         * cli/cli-dump.c: Fix common/ includes.
12113         * cli/cli-cmds.c: Fix common/ includes.
12114         * charset.c: Fix common/ includes.
12115         * build-id.c: Fix common/ includes.
12116         * btrace.h: Fix common/ includes.
12117         * btrace.c: Fix common/ includes.
12118         * breakpoint.h: Fix common/ includes.
12119         * breakpoint.c: Fix common/ includes.
12120         * ax.h:
12121         (enum agent_op): Fix common/ includes.
12122         * ax-general.c (struct aop_map): Fix common/ includes.
12123         * ax-gdb.c: Fix common/ includes.
12124         * auxv.c: Fix common/ includes.
12125         * auto-load.c: Fix common/ includes.
12126         * arm-tdep.c: Fix common/ includes.
12127         * arch/riscv.c: Fix common/ includes.
12128         * arch/ppc-linux-common.c: Fix common/ includes.
12129         * arch/i386.c: Fix common/ includes.
12130         * arch/arm.c: Fix common/ includes.
12131         * arch/arm-linux.c: Fix common/ includes.
12132         * arch/arm-get-next-pcs.c: Fix common/ includes.
12133         * arch/amd64.c: Fix common/ includes.
12134         * arch/aarch64.c: Fix common/ includes.
12135         * arch/aarch64-insn.c: Fix common/ includes.
12136         * arch-utils.c: Fix common/ includes.
12137         * amd64-windows-tdep.c: Fix common/ includes.
12138         * amd64-tdep.c: Fix common/ includes.
12139         * amd64-sol2-tdep.c: Fix common/ includes.
12140         * amd64-obsd-tdep.c: Fix common/ includes.
12141         * amd64-nbsd-tdep.c: Fix common/ includes.
12142         * amd64-linux-tdep.c: Fix common/ includes.
12143         * amd64-linux-nat.c: Fix common/ includes.
12144         * amd64-fbsd-tdep.c: Fix common/ includes.
12145         * amd64-fbsd-nat.c: Fix common/ includes.
12146         * amd64-dicos-tdep.c: Fix common/ includes.
12147         * amd64-darwin-tdep.c: Fix common/ includes.
12148         * agent.c: Fix common/ includes.
12149         * ada-lang.h: Fix common/ includes.
12150         * ada-lang.c: Fix common/ includes.
12151         * aarch64-tdep.c: Fix common/ includes.
12152
12153 2019-01-25  Tom Tromey  <tom@tromey.com>
12154
12155         * common/create-version.sh: Use common/version.h.
12156
12157 2019-01-24  Pedro Alves  <palves@redhat.com>
12158
12159         * infrun.c (signal_stop, signal_print, signal_program)
12160         (signal_catch, signal_pass): Now arrays instead of pointers.
12161         (update_signals_program_target, do_target_resume)
12162         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12163         * linux-nat.c (linux_nat_target::pass_signals)
12164         (linux_nat_target::create_inferior, linux_nat_target::attach):
12165         Adjust.
12166         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12167         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12168         * procfs.c (procfs_target::pass_signals): Adjust.
12169         * record-full.c (record_full_target::resume): Adjust.
12170         * remote.c (remote_target::pass_signals)
12171         (remote_target::program_signals): Adjust.
12172         * target-debug.h (target_debug_print_signals): Now takes a
12173         gdb::array_view as parameter.  Adjust.
12174         * target.h (target_ops) <pass_signals, program_signals>: Replace
12175         pointer and length parameters with gdb::array_view.
12176         (target_pass_signals, target_program_signals): Likewise.
12177         * target-delegates.c: Regenerate.
12178
12179 2019-01-24  Pedro Alves  <palves@redhat.com>
12180
12181         * common/forward-scope-exit.h
12182         (forward_scope_exit::forward_scope_exit): Pass arguments to
12183         m_bind_function directly, instead of creating a std::bind and
12184         copying that.
12185
12186 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12187
12188         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12189         for static members.
12190         (pass_in_v_vfp_candidate): Likewise.
12191
12192 2019-01-23  Tom Tromey  <tom@tromey.com>
12193             Pedro Alves  <palves@redhat.com>
12194
12195         * regcache.c (class regcache_invalidator): Remove.
12196         (regcache::raw_write): Use make_scope_exit.
12197
12198 2019-01-23  Tom Tromey  <tom@tromey.com>
12199
12200         * ui-out.h (class ui_out_emit_type): Update comment.
12201
12202 2019-01-23  Tom Tromey  <tom@tromey.com>
12203
12204         * infrun.c (fetch_inferior_event): Update comment.
12205
12206 2019-01-23  Tom Tromey  <tom@tromey.com>
12207             Pedro Alves  <palves@redhat.com>
12208
12209         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12210         parameter.
12211         (fetch_inferior_event): Use SCOPE_EXIT.
12212
12213
12214 2019-01-23  Tom Tromey  <tom@tromey.com>
12215             Pedro Alves  <palves@redhat.com>
12216
12217         * infrun.c (disable_thread_events): Delete.
12218         (stop_all_threads): Use SCOPE_EXIT.
12219
12220 2019-01-23  Tom Tromey  <tom@tromey.com>
12221             Pedro Alves  <palves@redhat.com>
12222
12223         * symfile.c: Include forward-scope-exit.h.
12224         (clear_symtab_users_cleanup): Replace forward declaration with
12225         a FORWARD_SCOPE_EXIT.
12226         (syms_from_objfile_1): Use the forward_scope_exit and
12227         gdb::optional instead of cleanup_function.
12228         (reread_symbols): Use the forward_scope_exit instead of
12229         cleanup_function.
12230         (clear_symtab_users_cleanup): Remove function.
12231
12232 2019-01-23  Tom Tromey  <tom@tromey.com>
12233             Pedro Alves  <palves@redhat.com>
12234
12235         * linux-nat.c: Include scope-exit.h.
12236         (cleanup_target_stop): Remove.
12237         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12238         SCOPE_EXIT.
12239
12240 2019-01-23  Tom Tromey  <tom@tromey.com>
12241             Pedro Alves  <palves@redhat.com>
12242
12243         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12244         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12245
12246 2019-01-23  Tom Tromey  <tom@tromey.com>
12247             Andrew Burgess  <andrew.burgess@embecosm.com>
12248             Pedro Alves  <palves@redhat.com>
12249
12250         * infrun.c (fetch_inferior_event): Use scope_exit.
12251         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12252         * top.c (execute_command): Use scope_exit.
12253         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12254         * utils.c (do_bpstat_clear_actions_cleanup)
12255         (make_bpstat_clear_actions_cleanup): Remove.
12256
12257 2019-01-23  Tom Tromey  <tom@tromey.com>
12258             Pedro Alves  <palves@redhat.com>
12259
12260         * infrun.c: Include "common/scope-exit.h"
12261         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12262         (wait_for_inferior): Use SCOPE_EXIT.
12263         (fetch_inferior_event): Use scope_exit.
12264
12265 2019-01-23  Tom Tromey  <tom@tromey.com>
12266             Pedro Alves  <palves@redhat.com>
12267
12268         * breakpoint.c (create_breakpoint): Remove cleanup.
12269
12270 2019-01-23  Tom Tromey  <tom@tromey.com>
12271             Andrew Burgess  <andrew.burgess@embecosm.com>
12272             Pedro Alves  <palves@redhat.com>
12273
12274 2019-01-23  Pedro Alves  <palves@redhat.com>
12275
12276         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12277
12278 2019-01-23  Pedro Alves  <palves@redhat.com>
12279             Andrew Burgess  <andrew.burgess@embecosm.com>
12280
12281         * gdbthread.h: Include "common/forward-scope-exit.h".
12282         (scoped_finish_thread_state): Redefine custom class in terms of
12283         forward_scope_exit.
12284
12285 2019-01-23  Pedro Alves  <palves@redhat.com>
12286             Andrew Burgess  <andrew.burgess@embecosm.com>
12287
12288         * common/forward-scope-exit.h: New file.
12289
12290 2019-01-23  Pedro Alves  <palves@redhat.com>
12291             Andrew Burgess  <andrew.burgess@embecosm.com>
12292             Tom Tromey  <tom@tromey.com>
12293
12294         * common/scope-exit.h: New file.
12295
12296 2019-01-23  Pedro Alves  <palves@redhat.com>
12297
12298         * common/preprocessor.h (ESC): Rename to ...
12299         (ESC_PARENS): ... this.
12300         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12301         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12302
12303 2019-01-23  Tom Tromey  <tom@tromey.com>
12304
12305         * language.h (class scoped_switch_to_sym_language_if_auto):
12306         Initialize m_lang in both cases.
12307
12308 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12309
12310         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12311         with XCNEW.
12312
12313 2019-01-22  Tom Tromey  <tom@tromey.com>
12314
12315         * corelow.c: Do not include sys/file.h.
12316
12317 2019-01-22  Tom Tromey  <tom@tromey.com>
12318
12319         * tui/tui-wingeneral.h: Include gdb_curses.h.
12320
12321 2019-01-22  Tom Tromey  <tom@tromey.com>
12322
12323         * source-cache.h (class source_cache) <get_source_lines,
12324         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12325
12326 2019-01-22  Tom Tromey  <tom@tromey.com>
12327
12328         * remote-fileio.h (struct remote_target): Declare.
12329
12330 2019-01-22  Tom Tromey  <tom@tromey.com>
12331
12332         * python/py-arch.c: Do not include py-ref.h.
12333         * python/py-bpevent.c: Do not include py-ref.h.
12334         * python/py-cmd.c: Do not include py-ref.h.
12335         * python/py-continueevent.c: Do not include py-ref.h.
12336         * python/py-event.h: Do not include py-ref.h.
12337         * python/py-evtregistry.c: Do not include py-ref.h.
12338         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12339         * python/py-frame.c: Do not include py-ref.h.
12340         * python/py-framefilter.c: Do not include py-ref.h.
12341         * python/py-function.c: Do not include py-ref.h.
12342         * python/py-infevents.c: Do not include py-ref.h.
12343         * python/py-linetable.c: Do not include py-ref.h.
12344         * python/py-objfile.c: Do not include py-ref.h.
12345         * python/py-param.c: Do not include py-ref.h.
12346         * python/py-prettyprint.c: Do not include py-ref.h.
12347         * python/py-progspace.c: Do not include py-ref.h.
12348         * python/py-symbol.c: Do not include py-ref.h.
12349         * python/py-symtab.c: Do not include py-ref.h.
12350         * python/py-type.c: Do not include py-ref.h.
12351         * python/py-unwind.c: Do not include py-ref.h.
12352         * python/py-utils.c: Do not include py-ref.h.
12353         * python/py-value.c: Do not include py-ref.h.
12354         * python/py-varobj.c: Do not include py-ref.h.
12355         * python/py-xmethods.c: Do not include py-ref.h.
12356         * python/python.c: Do not include py-ref.h.
12357         * varobj.c: Do not include py-ref.h.
12358
12359 2019-01-22  Tom Tromey  <tom@tromey.com>
12360
12361         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12362         keyword for bcache.
12363
12364 2019-01-22  Tom Tromey  <tom@tromey.com>
12365
12366         * compile/compile-cplus-types.c: Remove a comment by #include.
12367
12368 2019-01-22  Tom Tromey  <tom@tromey.com>
12369
12370         * compile/gcc-c-plugin.h: Include compile-internal.h.
12371
12372 2019-01-22  Tom Tromey  <tom@tromey.com>
12373
12374         * stabsread.c (EXTERN): Do not define.
12375         (symnum, next_symbol_text_func, processing_gcc_compilation)
12376         (within_function, global_sym_chain, global_stabs)
12377         (previous_stab_code, this_object_header_files)
12378         (n_this_object_header_files)
12379         (n_allocated_this_object_header_files): Define.
12380         * stabsread.h (EXTERN): Never define.  Use "extern".
12381
12382 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12383
12384         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12385         history_value.
12386
12387 2019-01-21  Tom Tromey  <tom@tromey.com>
12388
12389         * ui-out.c: Fix includes.
12390         * tui/tui-source.c: Fix includes.
12391         * target.c: Fix includes.
12392         * remote.c: Fix includes.
12393         * regcache.c: Fix includes.
12394         * python/py-block.c: Fix includes.
12395         * printcmd.c: Fix includes.
12396         * or1k-tdep.c: Fix includes.
12397         * mi/mi-main.c: Fix includes.
12398         * m32r-tdep.c: Fix includes.
12399         * csky-tdep.c: Fix includes.
12400         * compile/compile-cplus-types.c: Fix includes.
12401         * cli/cli-interp.c: Fix includes.
12402
12403 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12404
12405         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12406         for padding.
12407
12408 2019-01-16  Tom Tromey  <tom@tromey.com>
12409
12410         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12411         earlier.
12412         (struct objfile) <msymbols_range>: Move from top level.
12413         <msymbols>: New method.
12414         (class objfile_msymbols): Remove.
12415         * symtab.c (default_collect_symbol_completion_matches_break_on):
12416         Update.
12417         * symmisc.c (dump_msymbols): Update.
12418         * stabsread.c (scan_file_globals): Update.
12419         * objc-lang.c (info_selectors_command, info_classes_command)
12420         (find_methods): Update.
12421         * minsyms.c (find_solib_trampoline_target): Update.
12422         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12423         * coffread.c (coff_symfile_read): Update.
12424         * ada-lang.c (ada_lookup_simple_minsym)
12425         (ada_collect_symbol_completion_matches): Update.
12426
12427 2019-01-16  Tom Tromey  <tom@tromey.com>
12428
12429         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12430         type.  Remove no-argument constructor.
12431         <iterator::operator++>: Simplify.
12432         <begin>: Update.
12433         <end>: Use minimal_symbol_count.
12434
12435 2019-01-16  Tom Tromey  <tom@tromey.com>
12436
12437         * objfiles.h (struct objfile) <psymtabs>: New method.
12438         (class objfile_psymtabs): Remove.
12439         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12440         typedef.
12441         <range>: New method.
12442         (require_partial_symbols): Change return type.
12443         * psymtab.c (require_partial_symbols)
12444         (psym_expand_symtabs_matching): Update.
12445         * mdebugread.c (parse_partial_symbols): Update.
12446         * dbxread.c (dbx_end_psymtab): Update.
12447
12448 2019-01-15  Tom Tromey  <tom@tromey.com>
12449
12450         * symtab.c (lookup_objfile_from_block)
12451         (lookup_symbol_in_objfile_symtabs)
12452         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12453         (find_line_symtab, info_sources_command)
12454         (default_collect_symbol_completion_matches_break_on)
12455         (make_source_files_completion_list): Update.
12456         * symmisc.c (print_objfile_statistics, dump_objfile)
12457         (maintenance_print_symbols, maintenance_info_symtabs)
12458         (maintenance_check_symtabs, maintenance_info_line_tables):
12459         Update.
12460         * source.c (select_source_symtab)
12461         (forget_cached_source_info_for_objfile): Update.
12462         * objfiles.h (class objfile_compunits): Remove.
12463         (struct objfile) <compunits_range>: New typedef.
12464         (compunits): New method.
12465         * objfiles.c (objfile_relocate1): Update.
12466         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12467         * maint.c (count_symtabs_and_blocks): Update.
12468         * linespec.c (iterate_over_all_matching_symtabs): Update.
12469         * cp-support.c (add_symbol_overload_list_qualified): Update.
12470         * coffread.c (coff_symtab_read): Update.
12471         * ada-lang.c (add_nonlocal_symbols)
12472         (ada_collect_symbol_completion_matches)
12473         (ada_add_global_exceptions): Update.
12474
12475 2019-01-15  Tom Tromey  <tom@tromey.com>
12476
12477         * progspace.h (program_space) <objfiles_safe_range>: New
12478         typedef.
12479         <objfiles_safe>: New method.
12480         * objfiles.h (class all_objfiles_safe): Remove.
12481         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12482         * jit.c (jit_inferior_exit_hook): Update.
12483
12484 2019-01-17  Tom Tromey  <tom@tromey.com>
12485
12486         * progspace.h (program_space) <objfiles_range>: New typedef.
12487         <objfiles>: New method.
12488         <objfiles_head>: Rename from objfiles.
12489         (object_files): Update.
12490         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12491         * guile/scm-pretty-print.c
12492         (ppscm_find_pretty_printer_from_objfiles): Update.
12493         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12494         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12495         Update.
12496         * python/py-progspace.c (pspy_get_objfiles): Update.
12497         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12498         Update.
12499         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12500         (objfpy_lookup_objfile_by_build_id): Update.
12501         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12502         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12503         Update.
12504         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12505         (expand_symtab_containing_pc, lookup_objfile_from_block)
12506         (lookup_static_symbol, basic_lookup_transparent_type)
12507         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12508         (find_line_symtab, info_sources_command)
12509         (default_collect_symbol_completion_matches_break_on)
12510         (make_source_files_completion_list, find_main_name): Update.
12511         * symmisc.c (print_symbol_bcache_statistics)
12512         (print_objfile_statistics, maintenance_print_symbols)
12513         (maintenance_print_msymbols, maintenance_print_objfiles)
12514         (maintenance_info_symtabs, maintenance_check_symtabs)
12515         (maintenance_expand_symtabs, maintenance_info_line_tables):
12516         Update.
12517         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12518         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12519         (map_overlay_command, unmap_overlay_command)
12520         (simple_overlay_update, expand_symtabs_matching)
12521         (map_symbol_filenames): Update.
12522         * symfile-debug.c (set_debug_symfile): Update.
12523         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12524         Update.
12525         * source.c (select_source_symtab, forget_cached_source_info):
12526         Update.
12527         * solib.c (solib_read_symbols): Update.
12528         * solib-spu.c (append_ocl_sos): Update.
12529         * psymtab.c (maintenance_print_psymbols)
12530         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12531         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12532         * printcmd.c (info_symbol_command): Update.
12533         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12534         Update.
12535         * objfiles.h (class all_objfiles): Remove.
12536         * objfiles.c (have_partial_symbols, have_full_symbols)
12537         (have_minimal_symbols, qsort_cmp, update_section_map)
12538         (shared_objfile_contains_address_p)
12539         (default_iterate_over_objfiles_in_search_order): Update.
12540         * objc-lang.c (info_selectors_command, info_classes_command)
12541         (find_methods): Update.
12542         * minsyms.c (find_solib_trampoline_target): Update.
12543         * maint.c (maintenance_info_sections)
12544         (maintenance_translate_address, count_symtabs_and_blocks):
12545         Update.
12546         * main.c (captured_main_1): Update.
12547         * linux-thread-db.c (try_thread_db_load_from_pdir)
12548         (has_libpthread): Update.
12549         * linespec.c (iterate_over_all_matching_symtabs)
12550         (search_minsyms_for_name): Update.
12551         * jit.c (jit_find_objf_with_entry_addr): Update.
12552         * hppa-tdep.c (find_unwind_entry)
12553         (hppa_lookup_stub_minimal_symbol): Update.
12554         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12555         Update.
12556         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12557         (elf_gnu_ifunc_resolve_by_got): Update.
12558         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12559         * dwarf-index-write.c (save_gdb_index_command): Update.
12560         * cp-support.c (add_symbol_overload_list_qualified): Update.
12561         * breakpoint.c (create_overlay_event_breakpoint)
12562         (create_longjmp_master_breakpoint)
12563         (create_std_terminate_master_breakpoint)
12564         (create_exception_master_breakpoint): Update.
12565         * blockframe.c (find_pc_partial_function): Update.
12566         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12567         (ada_collect_symbol_completion_matches)
12568         (ada_add_global_exceptions): Update.
12569
12570 2019-01-17  Tom Tromey  <tom@tromey.com>
12571
12572         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12573         declare VEC.
12574         (solib_target_parse_libraries): Change return type.
12575         (library_list_start_segment, library_list_start_section)
12576         (library_list_end_library, library_list_start_library); Update.
12577         (solib_target_free_library_list): Remove.
12578         (solib_target_parse_libraries): Remove cleanup.  Change return
12579         type.
12580         (solib_target_current_sos): Update.
12581
12582 2019-01-17  Tom Tromey  <tromey@bapiya>
12583
12584         * valprint.c: Replace "the the" with "the".
12585         * symtab.c: Replace "the the" with "the".
12586         * solib.c: Replace "the the" with "the".
12587         * solib-dsbt.c: Replace "the the" with "the".
12588         * linespec.c: Replace "the the" with "the".
12589         * dwarf2loc.h: Replace "the the" with "the".
12590         * amd64-windows-tdep.c: Replace "the the" with "the".
12591         * aarch64-tdep.c: Replace "the the" with "the".
12592
12593 2019-01-16  Keith Seitz  <keiths@redhat.com>
12594
12595         PR gdb/23773
12596         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12597         <builder>: Rename to ..
12598         <m_builder>: ... this and make private.
12599         (dwarf2_cu::get_builder): New method.  Change all users of
12600         `builder' to use this method.
12601         (dwarf2_start_symtab): Move to ...
12602         (dwarf2_cu::start_symtab): ... here.  Update all callers
12603         (setup_type_unit_groups): Move to ...
12604         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12605         callers.
12606         (dwarf2_cu::reset_builder): New method.
12607         (process_full_compunit, process_full_type_unit): Use
12608         dwarf2_cu::reset_builder.
12609         (follow_die_offset): Record the ancestor CU if it is different
12610         from the followed DIE's CU.
12611         (follow_die_sig_1): Likewise.
12612
12613 2019-01-15  Tom Tromey  <tom@tromey.com>
12614
12615         * remote.c (class remote_state) <buf>: Now a char_vector.
12616         <buf_size>: Remove.
12617         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12618         parameter.
12619         (remote_target::getpkt_or_notif_sane_1)
12620         (remote_target::getpkt_sane)
12621         (remote_target::getpkt_or_notif_sane): Likewise.
12622         (class remote_target) <putpkt>: New overload.
12623         (remote_target::read_frame): Change type of "buf_p".  Remove
12624         sizeof_p parameter.
12625         (packet_ok): New overload.
12626         (packet_check_result): New overload.
12627         Update all uses.
12628
12629 2019-01-14  Tom Tromey  <tom@tromey.com>
12630
12631         * remote-notif.c (handle_notification, remote_notif_ack)
12632         (remote_notif_parse): Make "buf" const.
12633         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12634         const.
12635         (remote_notif_parse, remote_notif_ack, handle_notification):
12636         Likewise.
12637         * remote.c (remote_notif_stop_parse): Make "buf" const.
12638         (remote_target::remote_parse_stop_reply): Make "buf" const.
12639         (remote_notif_stop_ack): Make "buf" const.
12640
12641 2019-01-14  Tom Tromey  <tom@tromey.com>
12642
12643         * remote.c (remote_console_output): Make parameter const.
12644
12645 2019-01-14  Tom Tromey  <tom@tromey.com>
12646
12647         * target-debug.h (target_debug_print_signals): Constify.
12648         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12649         * procfs.c (procfs_target::pass_signals): Update.
12650         * linux-nat.c (linux_nat_target::pass_signals): Update.
12651         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12652         * target-delegates.c: Rebuild.
12653         * remote.c (remote_target::program_signals): Update.
12654         (remote_target::pass_signals): Update.
12655         * target.c (target_pass_signals): Constify argument.
12656         (target_program_signals): Likewise.
12657         * target.h (struct target_ops) <pass_signals, program_signals>:
12658         Constify argument.
12659         (target_pass_signals, target_program_signals): Constify argument.
12660
12661 2019-01-14  Tom Tromey  <tom@tromey.com>
12662
12663         PR tui/28819:
12664         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12665
12666 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12667
12668         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12669         field.
12670         * rs6000-tdep.c: Include reggroups.h.
12671         (IS_V_ALIAS_PSEUDOREG): Define.
12672         (rs6000_register_name): Return names for the "vX" aliases.
12673         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12674         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12675         aliases.  Call default_register_reggroup_p for all other
12676         pseudo-registers.
12677         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12678         New functions.
12679         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12680         Handle "vX" aliases.
12681         (v_alias_pseudo_register_collect): New function.
12682         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12683         (rs6000_gdbarch_init): Initialize "vX" aliases as
12684         pseudo-registers.  Restore registration of
12685         rs6000_pseudo_register_reggroup_p with
12686         set_tdesc_pseudo_register_reggroup_p.
12687
12688 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12689
12690         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12691         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12692         set_gdbarch_num_pseudo_regs.
12693
12694 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12695
12696         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12697         Remove arg prefixname, add do_set and do_show.
12698         Add member functions set_list and show_list.
12699         * cli/cli-style.c (class cli_style_option): Update accordingly.
12700         (style_set_list): Move to file scope.
12701         (style_show_list): Likewise.
12702         (set_style): Call help_list.
12703         (show_style): Call cmd_show_list.
12704         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12705         Update to use the new macro.
12706
12707 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12708
12709         * ada-lang.c (_initialize_ada_language): Expand the help text
12710         for the "catch exception" command.
12711
12712 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12713
12714         * symtab.c (matching_obj_sections): Initialize obj,
12715         declare it closer to its usage.
12716
12717 2019-01-10  Tom Tromey  <tom@tromey.com>
12718
12719         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12720         (basic_inf_threads_range): Remove.
12721         (inf_threads_range, inf_non_exited_threads_range)
12722         (safe_inf_threads_range): Use next_adapter.
12723
12724 2019-01-10  Keith Seitz  <keiths@redhat.com>
12725
12726         PR gdb/23712
12727         PR symtab/23010
12728         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12729         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12730
12731 2019-01-10  Keith Seitz  <keiths@redhat.com>
12732
12733         PR gdb/23712
12734         PR symtab/23010
12735         * dictionary.c (pending_to_vector): Remove.
12736         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12737         Remove _1 suffix, replacing functions of the same name.  Update
12738         all callers.
12739         (dict_create_hashed, dict_create_hashed_expandable)
12740         (dict_create_linear, dict_create_linear_expandable, dict_free)
12741         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12742         Make functions static.
12743
12744 2019-01-10  Keith Seitz  <keiths@redhat.com>
12745
12746         PR gdb/23712
12747         PR symtab/23010
12748         * dictionary.h (struct dictionary): Replace declaration with
12749         multidictionary.
12750         (dict_create_hashed, dict_create_hashed_expandable)
12751         (dict_create_linear, dict_create_linear_expandable)
12752         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12753         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12754         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12755         taking multidictionary argument.
12756         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12757         * block.h (struct block) <dict>: Change to multidictionary
12758         and rename `multidict'.
12759         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12760         symmisc.c: Update all dictionary references to multidictionary.
12761
12762 2019-01-10  Keith Seitz  <keiths@redhat.com>
12763
12764         PR gdb/23712
12765         PR symtab/23010
12766         * dictionary.c: Include unordered_map.
12767         (pending_to_vector): New function.
12768         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12769         Rewrite the non-"_1" functions to take vector instead
12770         of linked list.
12771         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12772         "new" _1 versions of the same name.
12773         (multidictionary): Define.
12774         (std::hash<enum language): New definition.
12775         (collate_pending_symbols_by_language, mdict_create_hashed)
12776         (mdict_create_hashed_expandable, mdict_create_linear)
12777         (mdict_create_linear_expandable, mdict_free)
12778         (find_language_dictionary, create_new_language_dictionary)
12779         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12780         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12781         (mdict_size, mdict_empty): New functions.
12782         * dictionary.h (mdict_iterator): Define.
12783
12784 2019-01-10  Pedro Alves  <palves@redhat.com>
12785
12786         * breakpoint.c (read_uploaded_action)
12787         (create_tracepoint_from_upload): Adjust to use
12788         gdb::unique_xmalloc_ptr.
12789         * ctf.c (ctf_write_uploaded_tp):
12790         (SET_ARRAY_FIELD): Use emplace_back.
12791         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12792         * tracefile-tfile.c (tfile_write_uploaded_tp):
12793         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12794         gdb::unique_xmalloc_ptr.
12795         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12796         at_string, cond_string, cmd_strings>: Replace char pointers
12797         with gdb::unique_xmalloc_ptr.
12798
12799 2019-01-10  Pedro Alves  <palves@redhat.com>
12800
12801         * solib-target.c (library_list_start_library): Don't xstrdup name.
12802
12803 2019-01-10  Pedro Alves  <palves@redhat.com>
12804
12805         * mdebugread.c (parse_partial_symbols): Use
12806         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12807
12808 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12809
12810         * linux-fork.c (scoped_switch_fork_info)
12811         <~scoped_switch_fork_info>: Fix incorrect variable name.
12812
12813 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12814
12815         * linux-fork.c (scoped_switch_fork_info)
12816         <scoped_switch_fork_info>: Make explicit.
12817         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12818
12819 2019-01-10  Tom Tromey  <tom@tromey.com>
12820
12821         * objfiles.h (objfile::reset_psymtabs): Update.
12822         * objfiles.c (objfile::objfile): Update.
12823         * psymtab.h (psymtab_storage::obstack): Update.
12824         (psymtab_storage::m_obstack): Use gdb::optional.
12825         (class psymtab_storage): Update comment.  Remove objfile
12826         parameter.
12827         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12828
12829 2019-01-10  Tom Tromey  <tom@tromey.com>
12830
12831         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12832         <free_psymtabs>: Now private.
12833         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12834         (allocate_psymtab): Use new method.
12835
12836 2019-01-10  Tom Tromey  <tom@tromey.com>
12837
12838         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12839         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12840         * mdebugread.c (parse_partial_symbols): Use
12841         allocate_dependencies.
12842         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12843         allocate_dependencies.
12844         (process_psymtab_comp_unit_reader)
12845         (build_type_psymtab_dependencies): Likewise.
12846         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12847
12848 2019-01-10  Tom Tromey  <tom@tromey.com>
12849
12850         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12851         PSYMBOL_SET_LANGUAGE.
12852         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12853
12854 2019-01-10  Tom Tromey  <tom@tromey.com>
12855
12856         * psymtab.h (psymtab_storage::obstack): New method.
12857         <m_obstack>: Rename from obstack; now private.
12858         * psymtab.c (psymtab_storage): Update.
12859         * dwarf2read.c (create_addrmap_from_index)
12860         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12861         Update.
12862
12863 2019-01-10  Tom Tromey  <tom@tromey.com>
12864
12865         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12866         * objfiles.h (objfile::reset_psymtabs): New method.
12867
12868 2019-01-10  Tom Tromey  <tom@tromey.com>
12869
12870         * symmisc.c (print_symbol_bcache_statistics): Update.
12871         (print_objfile_statistics): Update.
12872         * symfile.c (reread_symbols): Update.
12873         * psymtab.h (class psymtab_storage): New.
12874         * psymtab.c (psymtab_storage): New constructor.
12875         (~psymtab_storage): New destructor.
12876         (require_partial_symbols): Update.
12877         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12878         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12879         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12880         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12881         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12882         (start_psymtab_common, end_psymtab_common)
12883         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12884         (allocate_psymtab): Update.
12885         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12886         Update.
12887         (dump_psymtab_addrmap, maintenance_print_psymbols)
12888         (maintenance_check_psymtabs): Update.
12889         (class objfile_psymtabs): Move to objfiles.h.
12890         * psympriv.h (discard_psymtab): Now inline.
12891         (psymtab_discarder::psymtab_discarder): Update.
12892         (psymtab_discarder::~psymtab_discarder): Update.
12893         (ALL_OBJFILE_PSYMTABS): Rewrite.
12894         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12895         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12896         Remove fields.
12897         <partial_symtabs>: New field.
12898         (class objfile_psymtabs): Move from psymtab.h.  Update.
12899         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12900         psymbol_cache.
12901         (objfile::~objfile): Don't destroy psymbol_cache.
12902         * mdebugread.c (parse_partial_symbols): Update.
12903         * dwarf2read.c (create_addrmap_from_index)
12904         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12905         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12906         (add_partial_subprogram, dwarf2_ranges_read): Update.
12907         * dwarf-index-write.c (write_address_map)
12908         (write_one_signatured_type, recursively_write_psymbols)
12909         (class debug_names, class debug_names, write_psymtabs_to_index):
12910         Update.
12911
12912 2019-01-10  Tom Tromey  <tom@tromey.com>
12913
12914         * symtab.h (SYMBOL_SET_NAMES): Update.
12915         (symbol_set_names): Update.
12916         (MSYMBOL_SET_NAMES): Update.
12917         * symtab.c (symbol_set_names): Change argument to be an
12918         objfile_per_bfd_storage.
12919         * psymtab.c (add_psymbol_to_bcache): Update.
12920         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12921
12922 2019-01-10  Tom Tromey  <tom@tromey.com>
12923
12924         * symtab.c (create_demangled_names_hash): Change argument to be an
12925         objfile_per_bfd_storage.
12926         (symbol_set_names): Update.
12927
12928 2019-01-10  Tom Tromey  <tom@tromey.com>
12929
12930         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12931         init_psymbol_list.
12932         * psymtab.c (init_psymbol_list): Do nothing if already called.
12933         * psympriv.h (init_psymbol_list): Add comment.
12934         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12935         init_psymbol_list.
12936         * dbxread.c (dbx_symfile_read): Unconditionally call
12937         init_psymbol_list.
12938
12939 2019-01-10  Tom Tromey  <tom@tromey.com>
12940
12941         * xcoffread.c (scan_xcoff_symtab): Update.
12942         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12943         "where".
12944         * mdebugread.c (parse_partial_symbols)
12945         (handle_psymbol_enumerators): Update.
12946         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12947         * dbxread.c (read_dbx_symtab): Update.
12948         * psympriv.h (psymbol_placement): New enum.
12949         (add_psymbol_to_list): Update.
12950
12951 2019-01-10  Tom Tromey  <tom@tromey.com>
12952
12953         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12954         static_psymbols parameters.
12955         (scan_xcoff_symtab): Update.
12956         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12957         static_psymbols parameters.
12958         * psympriv.h (start_psymtab_common): Update.
12959         * mdebugread.c (parse_partial_symbols): Update.
12960         * dwarf2read.c (create_partial_symtab): Update.
12961         * dbxread.c (read_dbx_symtab): Update.
12962         (start_psymtab): Remove global_psymbols and static_psymbols
12963         parameters.
12964
12965 2019-01-10  Tom Tromey  <tom@tromey.com>
12966
12967         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12968         * psymtab.c (allocate_psymtab): Add comment.
12969         * psympriv.h (allocate_psymtab): Add comment.
12970         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12971         initializations.
12972         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12973
12974 2019-01-10  Tom Tromey  <tom@tromey.com>
12975
12976         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12977         Don't declare.
12978         * mipsread.c: Include mdebugread.h.
12979         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12980         Declare.
12981         * elfread.c: Include mdebugread.h.
12982
12983 2019-01-09  Tom Tromey  <tom@tromey.com>
12984
12985         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12986         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12987         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12988         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12989         (psym_lookup_symbol, psym_find_last_source_symtab)
12990         (psym_forget_cached_source_info, psym_print_stats)
12991         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12992         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12993         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12994         (psym_find_compunit_symtab_by_address)
12995         (maintenance_print_psymbols, maintenance_info_psymtabs)
12996         (maintenance_check_psymtabs): Use ranged for.
12997         * psymtab.h (class objfile_psymtabs): New.
12998         (require_partial_symbols): Return objfile_psymtabs.
12999         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13000
13001 2019-01-09  Tom Tromey  <tom@tromey.com>
13002
13003         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13004         (find_pc_mapped_section, list_overlays_command)
13005         (map_overlay_command, unmap_overlay_command)
13006         (simple_overlay_update): Use all_objfiles.
13007         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13008         * printcmd.c (info_symbol_command): Use all_objfiles.
13009         * objfiles.h (ALL_OBJSECTIONS): Remove.
13010         * maint.c (maintenance_translate_address): Use all_objfiles.
13011         * gcore.c (gcore_create_callback): Use all_objfiles.
13012         (objfile_find_memory_regions): Likewise.
13013
13014 2019-01-09  Tom Tromey  <tom@tromey.com>
13015
13016         * symtab.c (find_line_symtab, info_sources_command)
13017         (make_source_files_completion_list): Use objfile_compunits.
13018         * source.c (select_source_symtab): Use objfile_compunits.
13019         * objfiles.h (struct objfile): Update comment.
13020         (ALL_OBJFILES): Remove.
13021         (ALL_FILETABS): Remove.
13022         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13023         objfile_compunits.
13024
13025 2019-01-09  Tom Tromey  <tom@tromey.com>
13026
13027         * symmisc.c (print_objfile_statistics, dump_objfile)
13028         (maintenance_print_symbols): Use compunit_filetabs.
13029         * source.c (forget_cached_source_info_for_objfile): Use
13030         compunit_filetabs.
13031         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13032         (ALL_FILETABS): Use compunit_filetabs.
13033         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13034         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13035
13036 2019-01-09  Tom Tromey  <tom@tromey.com>
13037
13038         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13039         (compunit_filetabs): New.
13040         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13041         compunit_filetabs.
13042         (info_sources_command, make_source_files_completion_list): Remove
13043         declaration.
13044         * symmisc.c (print_objfile_statistics, dump_objfile)
13045         (maintenance_print_symbols): Remove declaration.
13046         (maintenance_info_symtabs): Use compunit_filetabs.
13047         (maintenance_info_line_tables): Likewise.
13048         * source.c (select_source_symtab): Change local variable name.
13049         (forget_cached_source_info_for_objfile): Remove declaration.
13050         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13051         * objfiles.c (objfile_relocate1): Remove declaration.
13052         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13053         declaration.
13054         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13055         * coffread.c (coff_symtab_read): Remove declaration.
13056         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13057         compunit_filetabs.
13058
13059 2019-01-09  Tom Tromey  <tom@tromey.com>
13060
13061         * symtab.c (lookup_objfile_from_block)
13062         (find_pc_sect_compunit_symtab, search_symbols)
13063         (default_collect_symbol_completion_matches_break_on): Use
13064         objfile_compunits.
13065         * objfiles.h (ALL_COMPUNITS): Remove.
13066         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13067         * cp-support.c (add_symbol_overload_list_qualified): Use
13068         objfile_compunits.
13069         * ada-lang.c (ada_collect_symbol_completion_matches)
13070         (ada_add_global_exceptions): Use objfile_compunits.
13071
13072 2019-01-09  Tom Tromey  <tom@tromey.com>
13073
13074         * source.c (select_source_symtab)
13075         (forget_cached_source_info_for_objfile): Remove declaration.
13076         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13077         declaration.
13078         * maint.c (count_symtabs_and_blocks): Remove declaration.
13079         * cp-support.c (add_symbol_overload_list_qualified): Remove
13080         declaration.
13081         * coffread.c (coff_symtab_read): Remove declaration.
13082         * symtab.c (lookup_symbol_in_objfile_symtabs)
13083         (basic_lookup_transparent_type_1): Use objfile_compunits.
13084         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13085         (info_sources_command, search_symbols)
13086         (default_collect_symbol_completion_matches_break_on)
13087         (make_source_files_completion_list): Remove declaration.
13088         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13089         (ada_collect_symbol_completion_matches)
13090         (ada_add_global_exceptions): Remove declaration.
13091         * linespec.c (iterate_over_all_matching_symtabs): Use
13092         objfile_compunits.
13093         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13094         (class objfile_compunits): New.
13095         (ALL_COMPUNITS): Use objfile_compunits.
13096         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13097         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13098         objfile_compunits.
13099         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13100
13101 2019-01-09  Tom Tromey  <tom@tromey.com>
13102
13103         * symtab.c (search_symbols)
13104         (default_collect_symbol_completion_matches_break_on): Use
13105         objfile_msymbols.
13106         * ada-lang.c (ada_lookup_simple_minsym)
13107         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13108         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13109         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13110         objfile_msymbols.
13111         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13112         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13113         * objc-lang.c (find_methods): Use objfile_msymbols.
13114         (info_selectors_command, info_classes_command): Likewise.
13115         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13116         * objfiles.h (class objfile_msymbols): New.
13117         (ALL_OBJFILE_MSYMBOLS): Remove.
13118         (ALL_MSYMBOLS): Remove.
13119
13120 2019-01-09  Tom Tromey  <tom@tromey.com>
13121
13122         * common/next-iterator.h (next_adapter): Add Iterator template
13123         parameter.
13124         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13125         (class all_objfiles_safe): New.
13126         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13127         * objfiles.c (put_objfile_before): Update comment.
13128         (add_separate_debug_objfile): Likewise.
13129         (free_all_objfiles): Use all_objfiles_safe.
13130         (objfile_purge_solibs): Likewise.
13131
13132 2019-01-09  Tom Tromey  <tom@tromey.com>
13133
13134         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13135         (expand_symtab_containing_pc, lookup_static_symbol)
13136         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13137         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13138         all_objfiles.
13139         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13140         * breakpoint.c (create_overlay_event_breakpoint)
13141         (create_longjmp_master_breakpoint)
13142         (create_std_terminate_master_breakpoint)
13143         (create_exception_master_breakpoint): Use all_objfiles.
13144         * linux-thread-db.c (try_thread_db_load_from_pdir)
13145         (has_libpthread): Use all_objfiles.
13146         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13147         * linespec.c (iterate_over_all_matching_symtabs)
13148         (search_minsyms_for_name): Use all_objfiles.
13149         * maint.c (maintenance_info_sections): Use all_objfiles.
13150         * main.c (captured_main_1): Use all_objfiles.
13151         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13152         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13153         * guile/scm-pretty-print.c
13154         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13155         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13156         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13157         (maintenance_print_msymbols): Use all_objfiles.
13158         * source.c (select_source_symtab): Use all_objfiles.
13159         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13160         * symfile.c (remove_symbol_file_command)
13161         (expand_symtabs_matching, map_symbol_filenames): Use
13162         all_objfiles.
13163         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13164         all_objfiles.
13165         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13166         * objc-lang.c (find_methods): Use all_objfiles.
13167         * objfiles.c (have_partial_symbols, have_full_symbols)
13168         (have_minimal_symbols, qsort_cmp)
13169         (default_iterate_over_objfiles_in_search_order): Use
13170         all_objfiles.
13171         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13172         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13173         (maintenance_check_psymtabs): Use all_objfiles.
13174         (ALL_PSYMTABS): Remove.
13175         * compile/compile-object-run.c (do_module_cleanup): Use
13176         all_objfiles.
13177         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13178         * cp-support.c (add_symbol_overload_list_qualified): Use
13179         all_objfiles.
13180         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13181         Use all_objfiles.
13182         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13183         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13184         all_objfiles.
13185         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13186         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13187         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13188         Uses all_objfiles.
13189         * solib.c (solib_read_symbols): Use all_objfiles
13190
13191 2019-01-09  Tom Tromey  <tom@tromey.com>
13192
13193         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13194         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13195         all_objfiles.
13196         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13197         * symmisc.c (print_symbol_bcache_statistics)
13198         (print_objfile_statistics, maintenance_print_objfiles)
13199         (maintenance_info_symtabs, maintenance_check_symtabs)
13200         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13201         all_objfiles.
13202         * source.c (forget_cached_source_info): Use all_objfiles.
13203         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13204         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13205         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13206         * objfiles.c (update_section_map): Use all_objfiles.
13207         (shared_objfile_contains_address_p): Likewise.
13208         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13209         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13210
13211 2019-01-09  Tom Tromey  <tom@tromey.com>
13212
13213         * common/next-iterator.h: New file.
13214         * objfiles.h (class all_objfiles): New.
13215         (struct objfile_iterator): New.
13216
13217 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13218
13219         * NEWS: Move the description of the changed "frame", "select-frame",
13220          and "info frame" commands to the Changed commands section.
13221
13222 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13223
13224         * gdbtypes.c (check_stub_method_group): Remove handling of old
13225         mangling schemes.
13226         * linespec.c (find_methods): Likewise.
13227         * stabsread.c (read_member_functions): Likewise.
13228         * valops.c (search_struct_method): Likewise.
13229         (value_struct_elt_for_reference): Likewise.
13230         * NEWS: Mention this change.
13231
13232 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13233
13234         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13235         print_source_lines.
13236         * source.c (print_source_lines_base): Update line number check.
13237         (print_source_lines): New function.
13238         (source_lines_range::source_lines_range): New function.
13239         * source.h (class source_lines_range): New class.
13240         (print_source_lines): New declaration.
13241
13242 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13243
13244         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13245
13246 2019-01-08  Tom Tromey  <tom@tromey.com>
13247             Simon Marchi  <simon.marchi@ericsson.com>
13248
13249         PR gdb/24060
13250         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13251         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13252         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13253         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13254         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13255         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13256
13257 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13258
13259         * source.c (select_source_symtab): Move header comment to
13260         declaration in source.h.
13261         (forget_cached_source_info_for_objfile): Likewise.
13262         (forget_cached_source_info): Likewise.
13263         (identify_source_line): Likewise.
13264         * source.h (identify_source_line): Move declaration from symtab.h
13265         and add comment from source.c
13266         (print_source_lines): Likewise.
13267         (forget_cached_source_info_for_objfile): Likewise.
13268         (forget_cached_source_info): Likewise.
13269         (select_source_symtab): Likewise.
13270         (enum print_source_lines_flag): Move definition from symtab.h.
13271         * symtab.h (identify_source_line): Move declaration to source.h.
13272         (print_source_lines): Likewise.
13273         (forget_cached_source_info_for_objfile): Likewise.
13274         (forget_cached_source_info): Likewise.
13275         (select_source_symtab): Likewise.
13276         (enum print_source_lines_flag): Move definition to source.h.
13277         * tui/tui-hooks.c: Add 'source.h' include.
13278
13279 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13280
13281         * source.c (print_source_lines_base): Handle requests to print
13282         reverse line number sequences, and guard against empty lines
13283         string.
13284
13285 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13286
13287         * source.c (print_source_lines_base): Fix skip of '\r' if next
13288         character is '\n'.
13289
13290 2019-01-06  Tom Tromey  <tom@tromey.com>
13291
13292         * c-exp.y (struct c_parse_state) <macro_original_text,
13293         expansion_obstack>: New member.
13294         (macro_original_text, expansion_obstack): Remove globals.
13295         (scan_macro_expansion, scanning_macro_expansion)
13296         (finished_macro_expansion): Update.
13297         (scan_macro_cleanup): Remove.
13298         (yylex, c_parse): Update.
13299
13300 2019-01-06  Tom Tromey  <tom@tromey.com>
13301
13302         * c-exp.y (struct c_parse_state) <strings>: New member.
13303         (operator_stoken): Update.
13304
13305 2019-01-06  Tom Tromey  <tom@tromey.com>
13306
13307         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13308         (union type_stack_elt) <typelist_val>: Now a pointer to
13309         std::vector.
13310         (type_stack_cleanup): Don't declare.
13311         (push_typelist): Update.
13312         * parse.c (pop_typelist): Return a std::vector.
13313         (push_typelist): Take a std::vector.
13314         (follow_types): Update.  Do not free args.
13315         (type_stack_cleanup): Remove.
13316         * c-exp.y (struct c_parse_state): New.
13317         (cpstate): New global.
13318         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13319         (nonempty_typelist): Update.
13320         (func_mod): Create a new vector.
13321         (c_parse): Create a c_parse_state.
13322         (check_parameter_typelist): Do not delete params.
13323         (function_method): Update.  Do not delete type_list.
13324
13325 2019-01-06  Tom Tromey  <tom@tromey.com>
13326
13327         PR gdb/28155:
13328         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13329         check_typedef.
13330         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13331         (print_return_value): Likewise.
13332
13333 2019-01-05  Tom Tromey  <tom@tromey.com>
13334
13335         * contrib/cleanup_check.py: Remove.
13336         * contrib/gcc-with-excheck: Remove.
13337         * contrib/exsummary.py: Remove.
13338         * contrib/excheck.py: Remove.
13339
13340 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13341
13342         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13343         NULL. Initialize tpprev to NULL instead of assigning it
13344         to NULL on the next statement.
13345         * windows-nat.c (windows_delete_thread): Remove check for
13346         main_thread_id before printing thread exit notifications.
13347         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13348         Remove thread ID check against main_thread_id.
13349         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13350         windows_delete_thread.
13351         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13352
13353 2019-01-04  Tom Tromey  <tom@tromey.com>
13354
13355         * compile/compile.c (_initialize_compile): Use upper case for
13356         metasyntactic variables.
13357         * symmisc.c (_initialize_symmisc): Use upper case for
13358         metasyntactic variables.
13359         * psymtab.c (_initialize_psymtab): Use upper case for
13360         metasyntactic variables.
13361         * demangle.c (demangle_command): Use upper case for metasyntactic
13362         variables.
13363         (_initialize_demangler): Likewise.
13364         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13365         variables.
13366
13367 2019-01-03  Tom Tromey  <tom@tromey.com>
13368
13369         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13370
13371 2019-01-03  Tom Tromey  <tom@tromey.com>
13372
13373         * python/py-symtab.c (salpy_str): Update.
13374         (struct salpy_sal_object) <symtab>: Now a PyObject.
13375         (salpy_dealloc): Update.
13376         (del_objfile_sal): Use gdbpy_ref.
13377
13378 2019-01-03  Tom Tromey  <tom@tromey.com>
13379
13380         * python/py-type.c (convert_field): Use new_reference.  Return
13381         gdbpy_ref.
13382         (make_fielditem): Return gdbpy_ref.
13383         (typy_fields): Update.
13384         (typy_getitem): Update.
13385         (field_name): Return gdbpy_ref.  Use new_reference.
13386         (typy_iterator_iternext): Update.
13387
13388 2019-01-03  Tom Tromey  <tom@tromey.com>
13389
13390         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13391
13392 2019-01-03  Tom Tromey  <tom@tromey.com>
13393
13394         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13395         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13396         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13397         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13398         (pspy_set_type_printers): Likewise.
13399         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13400         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13401         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13402         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13403         (objfpy_set_type_printers): Likewise.
13404
13405 2019-01-03  Tom Tromey  <tom@tromey.com>
13406
13407         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13408         (gdbpy_print_stack): Use gdbpy_err_fetch.
13409         * python/python-internal.h (class gdbpy_err_fetch): New class.
13410         (class gdbpy_enter) <m_error_type, m_error_value,
13411         m_error_traceback>: Remove.
13412         <m_error>: New member.
13413         (gdbpy_exception_to_string): Don't declare.
13414         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13415         * python/py-value.c (convert_value_from_python): Use
13416         gdbpy_err_fetch.
13417         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13418         gdbpy_exception_to_string.
13419         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13420         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13421         gdbpy_err_fetch.
13422
13423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13424
13425         * linux-nat.c (delete_lwp_cleanup): Delete.
13426         (struct lwp_deleter): New struct.
13427         (lwp_info_up): New typedef.
13428         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13429         lwp_info_up.
13430
13431 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13432
13433         * linux-fork.c (class scoped_switch_fork_info): New class.
13434         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13435
13436 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13437
13438         * valops.c (find_overload_match): Remove use of null_cleanup, and
13439         calls to do_cleanups.
13440
13441 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13442
13443         * compile/compile-cplus-types.c
13444         (compile_cplus_instance::decl_name): Handle changes to
13445         cp_func_name.
13446         * cp-support.c (cp_func_name): Update header comment, update
13447         return type.
13448         * cp-support.h (cp_func_name): Update return type in declaration.
13449         * valops.c (find_overload_match): Move temp_func local to top
13450         level of function and change its type.  Use temp_func to hold and
13451         delete temporary string obtained from cp_func_name.
13452
13453 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13454
13455         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13456         gdb::char_vector, remove cleanup, and update uses of `msg`.
13457
13458 2019-01-03  Jim Wilson  <jimw@sifive.com>
13459
13460         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13461
13462 2019-01-02  Tom Tromey  <tom@tromey.com>
13463
13464         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13465         (tdesc_parse_xml): Remove cleanups.
13466         * target-descriptions.h (make_cleanup_free_target_description):
13467         Don't declare.
13468         (target_desc_deleter): New struct.
13469         (target_desc_up): New typedef.
13470         * target-descriptions.c (target_desc_deleter::operator()): Rename
13471         from free_target_description.
13472         (make_cleanup_free_target_description): Remove.
13473
13474 2019-01-02  Tom Tromey  <tom@tromey.com>
13475
13476         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13477         constructor, destructor.
13478         (linespec_parser): Remove typedef.
13479         (~linespec_parser): Rename from linespec_parser_delete.
13480         (linespec_lex_to_end, linespec_complete_label)
13481         (linespec_complete): Update.
13482         (decode_line_full): Remove cleanups.
13483         (decode_line_1): Update.
13484
13485 2019-01-02  Tom Tromey  <tom@tromey.com>
13486
13487         * python/python-internal.h (inferior_to_inferior_object): Change
13488         return type.
13489         * python/py-exitedevent.c (create_exited_event_object): Update.
13490         * python/py-inferior.c (inferior_to_inferior_object): Return
13491         gdbpy_ref.
13492         (python_new_inferior, python_inferior_deleted)
13493         (thread_to_thread_object, delete_thread_object)
13494         (build_inferior_list, gdbpy_selected_inferior): Update.
13495         * python/py-infthread.c (create_thread_object): Update.  Also fail
13496         if inferior_to_inferior_object fails.
13497
13498 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13499
13500         * inferior.h (class inferior) <displaced_step_state>: New field.
13501         * infrun.h (struct displaced_step_state): Move here from
13502         infrun.c.  Initialize fields, add constructor.
13503         <inf>: Remove field.
13504         <reset>: New method.
13505         * infrun.c (struct displaced_step_inferior_state): Move to
13506         infrun.h.
13507         (displaced_step_inferior_states): Remove.
13508         (get_displaced_stepping_state): Adust.
13509         (displaced_step_in_progress_any_inferior): Adjust.
13510         (displaced_step_in_progress_thread): Adjust.
13511         (displaced_step_in_progress): Adjust.
13512         (add_displaced_stepping_state): Remove.
13513         (get_displaced_step_closure_by_addr): Adjust.
13514         (remove_displaced_stepping_state): Remove.
13515         (infrun_inferior_exit): Call displaced_step_state.reset.
13516         (use_displaced_stepping): Don't check for NULL.
13517         (displaced_step_prepare_throw): Call
13518         get_displaced_stepping_state.
13519         (displaced_step_fixup): Don't check for NULL.
13520         (prepare_for_detach): Don't check for NULL.
13521
13522 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13523
13524         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13525          in case of call that did not complete.
13526
13527 2019-01-02  Andrey Utkin  <autkin@undo.io>
13528
13529         * symfile.c (find_separate_debug_file): Fix search of debug files for
13530         remote debuggee.
13531
13532 2019-01-02  Tom Tromey  <tom@tromey.com>
13533
13534         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13535         indentation.
13536         * python/py-frame.c (frapy_older): Remove cast.
13537         (frapy_newer): Likewise.
13538         * python/py-breakpoint.c (local_setattro): Remove cast.
13539         * python/py-arch.c (archpy_name): Remove local variable.
13540         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13541
13542 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13543
13544         * unittests/basic_string_view/element_access/char/empty.cc:
13545         Fix year range in copyright header.
13546
13547 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13548
13549         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13550         Delete.
13551         <operator==>: Update with for removed field.
13552         <hash>: Likewise.
13553         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13554         <isa_features>: ...this.
13555         <abi_features>: New field.
13556         (riscv_isa_flen): Update comment.
13557         (riscv_abi_xlen): New declaration.
13558         (riscv_abi_flen): New declaration.
13559         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13560         isa_features.
13561         (riscv_abi_xlen): New function.
13562         (riscv_isa_flen): Update to get answer from isa_features.
13563         (riscv_abi_flen): New function.
13564         (riscv_has_fp_abi): Update to get answer from abi_features.
13565         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13566         xlen and flen.
13567         (riscv_call_info) <xlen, flen>: Update comment.
13568         (riscv_call_arg_struct): Remove invalid assertions
13569         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13570         is removed.
13571         (riscv_gdbarch_init): Gather isa features and abi features
13572         separately, ensure both match on the gdbarch when reusing an old
13573         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13574         a target with 64-bit float hardware.
13575
13576 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13577
13578         * source.c (search_command_helper): Stop reverse search
13579         when line 1 has been searched.
13580
13581 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13582
13583         * record-full.c (record_full_base_target::close): Rewrite
13584         record_full_core_buf_list free logic.
13585
13586 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13587
13588         * break-catch-syscall.c (print_one_catch_syscall): xfree
13589         the last text.
13590
13591 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13592
13593         * top.c (print_gdb_version): Update Copyright year in version
13594         message.
13595
13596 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13597
13598         Update copyright year range in all GDB files.
13599
13600 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13601
13602         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13603
13604 For older changes see ChangeLog-2018.
13605 \f
13606 Local Variables:
13607 mode: change-log
13608 left-margin: 8
13609 fill-column: 74
13610 version-control: never
13611 coding: utf-8
13612 End:
13613