gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
   4
   5 2019-07-17  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-winsource.h (struct tui_exec_info_window)
   8         (struct tui_source_window_base): Move from tui-data.h.
   9         * tui/tui-winsource.c: Move many method definitions from
  10         elsewhere.  Remove "structuring" comments.
  11         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
  12         (tui_source_window_base::refresh_window): Move to
  13         tui-winsource.c.
  14         * tui/tui-win.c (tui_source_window_base::refresh_all)
  15         (tui_source_window_base::update_tab_width)
  16         (tui_source_window_base::set_new_height)
  17         (tui_source_window_base::do_make_visible_with_new_height): Move to
  18         tui-winsource.c.
  19         * tui/tui-source.h: Update.
  20         * tui/tui-source.c (tui_source_window_base::reset): Move to
  21         tui-winsource.c.
  22         * tui/tui-disasm.h: Update.
  23         * tui/tui-data.h (struct tui_exec_info_window): Move to
  24         tui-winsource.h.
  25         (struct tui_source_window_base): Likewise.
  26         * tui/tui-data.c (tui_source_window_base::clear_detail)
  27         (tui_source_window_base, ~tui_source_window_base): Move to
  28         tui-winsource.c.
  29
  30 2019-07-17  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-win.c (tui_resize_all)
  33         (tui_source_window_base::update_tab_width)
  34         (tui_adjust_win_heights): Update.
  35         (tui_win_info::make_invisible_and_set_new_height): Rename from
  36         make_invisible_and_set_new_height.
  37         * tui/tui-data.h (struct tui_win_info)
  38         <make_invisible_and_set_new_height>: New method.
  39
  40 2019-07-17  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui.c: Update.
  43         * tui/tui-source.h (struct tui_source_window): Move from
  44         tui-data.h.
  45         * tui/tui-layout.c: Update.
  46         * tui/tui-disasm.c: Update.
  47         * tui/tui-data.h (struct tui_source_window): Move to
  48         tui-source.h.
  49
  50 2019-07-17  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-disasm.h (struct tui_disasm_window): Move from
  53         tui-data.h.
  54         * tui/tui-data.h (struct tui_disasm_window): Move to
  55         tui-disasm.h.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-regs.h (struct tui_data_item_window): Move from
  60         tui-data.h.
  61         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
  62         * tui/tui-data.h (struct tui_data_item_window): Move to
  63         tui-regs.h.
  64         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
  65
  66 2019-07-17  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui.c: Update.
  69         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
  70         (tui_cmd_window::max_height): Move to tui-command.c.
  71         * tui/tui-layout.c: Update.
  72         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
  73         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
  74         tui-command.c.
  75         * tui/tui-command.h (struct tui_cmd_window): Move from
  76         tui-data.h.
  77         * tui/tui-command.c: Remove "structuring" comments.
  78         (tui_cmd_window::clear_detail)
  79         (tui_cmd_window::do_make_visible_with_new_height)
  80         (tui_cmd_window::max_height): Move from elsewhere.
  81
  82 2019-07-17  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
  85         Now static.
  86         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
  87         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui.c: Update.
  92         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
  93         tui-regs.c.
  94         * tui/tui-windata.h: Remove file.
  95         * tui/tui-windata.c: Remove file.
  96         * tui/tui-win.c (tui_data_window::set_new_height)
  97         (tui_data_window::do_make_visible_with_new_height): Move to
  98         tui-regs.c.
  99         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 100         * tui/tui-regs.c: Remove "structuring" comments.
 101         (tui_data_window::first_data_item_displayed)
 102         (tui_data_window::delete_data_content_windows)
 103         (tui_data_window::erase_data_content)
 104         (tui_data_window::display_all_data)
 105         (tui_data_window::refresh_all)
 106         (tui_data_window::do_scroll_vertical)
 107         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 108         (tui_data_window::do_make_visible_with_new_height)
 109         (tui_data_window::refresh_window): Move from elsewhere.
 110         (_initialize_tui_regs): Move to end of file.
 111         * tui/tui-layout.c: Update.
 112         * tui/tui-hooks.c: Update.
 113         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 114         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 115         tui-regs.c.
 116         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 121         seen.
 122
 123 2019-07-17  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-win.c (tui_source_window_base::set_new_height)
 126         (tui_source_window_base::do_make_visible_with_new_height): Use
 127         m_has_locator field directly.
 128         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 129         method.
 130         (struct tui_source_window_base) <has_locator>: Likewise.
 131
 132 2019-07-17  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 135         Don't declare.
 136         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 137         Remove.
 138         * tui/tui-win.c (tui_source_window_base::set_new_height)
 139         (tui_source_window_base::set_new_height)
 140         (make_invisible_and_set_new_height)
 141         (tui_source_window_base::do_make_visible_with_new_height)
 142         (tui_source_window_base::do_make_visible_with_new_height):
 143         Update.
 144         * tui/tui-layout.c (show_source_disasm_command, show_data)
 145         (show_source_or_disasm_and_command): Update.
 146         * tui/tui-layout.c (show_layout): Update.
 147
 148 2019-07-17  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-layout.c (make_data_window): Remove.
 151         (show_data): Unify creation and re-initialization cases.
 152
 153 2019-07-17  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-layout.c (make_source_window, make_disasm_window):
 156         Remove.
 157         (show_data): Unify creation and re-initialization cases.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-layout.c (make_command_window): Remove.
 162         (show_source_disasm_command, show_source_or_disasm_and_command):
 163         Unify creation and re-initialization cases.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 168         creation and re-initialization cases.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-regs.c (tui_get_register): Return void.
 173
 174 2019-07-17  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 177         Simplify.
 178
 179 2019-07-17  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 182         resetting.
 183
 184 2019-07-17  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 187         * tui/tui-regs.c (tui_reg_layout): New function.
 188         (tui_show_registers, tui_reg_command): Use it.
 189         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 190         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 191         parameters.
 192         (tui_layout_command): Remove.
 193
 194 2019-07-17  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-layout.h (tui/tui-layout): Return void.
 197         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 198
 199 2019-07-17  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-layout.c (show_source_disasm_command, show_data):
 202         Update.
 203         (reset_locator): Remove.
 204         (show_source_or_disasm_and_command): Update.
 205
 206 2019-07-17  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-source.c (tui_source_window_base::reset): Remove
 209         win_type parameter.
 210         * tui/tui-layout.c (make_command_window, make_source_window)
 211         (make_disasm_window, make_data_window)
 212         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 213         (reset_locator, show_source_or_disasm_and_command): Update.
 214         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 215         win_type parameter.
 216         (struct tui_source_window_base) <reset>: Likewise.
 217
 218 2019-07-17  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-layout.c (show_source_disasm_command): Use
 221         reset_locator.
 222         (reset_locator): New function.
 223         (init_and_make_win): Remove.
 224         (show_source_or_disasm_and_command): Use reset_locator.
 225
 226 2019-07-17  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 229         condition.
 230         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 231         Remove condition.
 232         * tui/tui-source.c (tui_source_window_base::reset): New method.
 233         * tui/tui-layout.c (make_command_window): Don't call
 234         init_and_make_win.
 235         (make_source_window, make_disasm_window): Don't call
 236         make_source_or_disasm_window.
 237         (make_data_window): Don't call init_and_make_win.  Change calling
 238         convention.
 239         (show_source_disasm_command, show_data): Simplify.
 240         (make_source_or_disasm_window): Remove.
 241         (show_source_or_disasm_and_command): Simplify.
 242         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 243         (struct tui_source_window_base) <reset>: Likewise.
 244         <execution_info>: Remove initializer.
 245         * tui/tui-data.c (tui_source_window_base): Initialize
 246         execution_info.
 247
 248 2019-07-17  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 251         variable.
 252
 253 2019-07-17  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui.c (tui_rl_other_window): Update.
 256         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 257         superclass method first.  Always iterate over regs_content.
 258         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 259         method.
 260         * tui/tui-win.c (tui_set_focus_command): Update.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-win.c (tui_set_focus_command): Rename from
 265         tui_set_focus.  Call tui_enable.
 266         (tui_set_focus_command): Remove.
 267
 268 2019-07-17  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 271         refresh_window.
 272         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 273         touchwin.
 274         (tui_data_window::refresh_window): Call refresh_window on data
 275         items.  Always call superclass refresh_window.
 276         (tui_win_info::refresh): Remove.
 277         (tui_source_window_base::refresh_window): Update.
 278         (tui_refresh_all): Update.
 279         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 280         refresh_window.
 281         (show_source_or_disasm_and_command): Likewise.
 282         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 283         (struct tui_source_window_base) <refresh>: Likewise.
 284
 285 2019-07-17  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-winsource.c (tui_clear_source_content)
 288         (tui_show_source_content): Update.
 289         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 290         whether content is empty.
 291         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 292         Remove.
 293
 294 2019-07-17  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 297         window's contents.
 298         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 299         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 300
 301 2019-07-17  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 304         (struct tui_data_item_window): Update.
 305
 306 2019-07-17  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 309         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 310         defines.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-winsource.h (tui_erase_source_content)
 315         (tui_clear_source_content): Remove "display_prompt" parameter.
 316         * tui/tui-winsource.c (tui_update_source_window_as_is)
 317         (tui_update_source_windows_with_addr): Update.
 318         (tui_clear_source_content): Remove "display_prompt" parameter.
 319         (tui_erase_source_content): Likewise.  Simplify.
 320         (tui_show_source_content): Update.
 321         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 322         * tui/tui-stack.c (tui_show_frame_info): Update.
 323         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 324         Remove defines.
 325
 326 2019-07-17  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 329         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 330         parameter.
 331         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 332         parameter.
 333
 334 2019-07-17  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-winsource.c (tui_clear_source_content)
 337         (tui_show_source_content, tui_show_exec_info_content)
 338         (tui_clear_exec_info_content): Update.
 339         * tui/tui-stack.c (tui_show_locator_content): Update.
 340         (tui_show_frame_info): Update.
 341         * tui/tui-source.h (tui_source_window): Don't declare.
 342         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 343         from tui_source_is_displayed.
 344         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 345         Remove field.
 346         (struct tui_source_window_base) <content_in_use>: New field.  Now
 347         bool.
 348         (struct tui_source_window) <showing_source_p>: New method.
 349         (TUI_SRC_WIN): Change cast.
 350         * tui/tui-data.c (tui_initialize_static_data): Update.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 355         location_matches_p.
 356         * tui/tui-source.c (tui_source_window::location_matches_p): New
 357         method.
 358         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 359         method.
 360         * tui/tui-data.h (struct tui_source_window_base)
 361         <location_matches_p>: New method.
 362         (struct tui_source_window, struct tui_disasm_window)
 363         <location_matches_p>: Likewise.
 364
 365 2019-07-17  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-win.c (tui_set_win_height_command): Rename from
 368         tui_set_win_height.
 369         (tui_set_win_height_command): Remove.
 370
 371 2019-07-17  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-source.c (tui_source_window): New constructor.  Add
 374         observer.
 375         (~tui_source_window): New destructor.
 376         (tui_source_window::style_changed): New method.
 377         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 378         (tui_attach_detach_observers): Update.
 379         * tui/tui-data.h (struct tui_source_window): Make constructor not
 380         inline.  Add destructor.
 381         (struct tui_source_window) <style_changed>: New method.
 382         <m_observable>: New member.
 383
 384 2019-07-17  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 387         * tui/tui-win.c (tui_resize_all): Fix typo.
 388
 389 2019-07-17  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 392         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 393         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 394         * tui/tui-win.c (window_name_completer): Use foreach.
 395         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 396         (update_tab_width): Likewise.
 397         * tui/tui-layout.c (show_layout): Update.
 398         * tui/tui-data.h (class tui_window_iterator): New.
 399         (struct all_tui_windows): New.
 400         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 401
 402 2019-07-17  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 405         parameter.  Don't reference globals.
 406         (tui_reg_command): Update.
 407
 408 2019-07-17  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-regs.c (tui_show_registers): Simplify.
 411
 412 2019-07-17  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-regs.c (tui_show_registers): Update.
 415         (tui_show_register_group): Add win_info parameter.
 416
 417 2019-07-17  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 420         Rename from tui_display_reg_element_at_line.
 421         (tui_data_window::display_registers_from_line): Update.
 422         * tui/tui-data.h (struct tui_data_window)
 423         <display_reg_element_at_line>: New method.
 424
 425 2019-07-17  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-regs.h (tui_display_registers_from)
 428         (tui_display_registers_from_line): Don't declare.
 429         * tui/tui-windata.c (tui_data_window::display_all_data)
 430         (tui_data_window::refresh_all)
 431         (tui_data_window::do_scroll_vertical): Update.
 432         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 433         from tui_display_registers_from.
 434         (tui_display_reg_element_at_line): Update.
 435         (tui_data_window::display_registers_from_line): Rename from
 436         tui_display_registers_from_line.
 437         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 438         display_registers_from_line>: New methods.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 443         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 444         from tui_erase_data_content.
 445         (tui_data_window::display_all_data)
 446         (tui_data_window::refresh_all)
 447         (tui_data_window::do_scroll_vertical): Update.
 448         * tui/tui-regs.c (tui_show_registers): Update.
 449         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 450         New method.
 451
 452 2019-07-17  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 455         declare.
 456         * tui/tui-windata.c
 457         (tui_data_window::delete_data_content_windows): Rename from
 458         tui_delete_data_content_windows.
 459         (tui_data_window::display_all_data)
 460         (tui_data_window::do_scroll_vertical): Update.
 461         * tui/tui-data.h (struct tui_data_window)
 462         <delete_data_content_windows>: New method.
 463
 464 2019-07-17  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 467         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 468
 469 2019-07-17  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 472         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 473         from tui_display_all_data.
 474         * tui/tui-win.c
 475         (tui_data_window::do_make_visible_with_new_height): Update.
 476         * tui/tui-regs.c (tui_show_registers): Update.
 477         * tui/tui-layout.c (tui_set_layout): Update.
 478         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 479         method.
 480
 481 2019-07-17  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 484         * tui/tui-windata.c (tui_display_data_from): Remove.
 485         (tui_data_window::refresh_all): Update.
 486
 487 2019-07-17  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 490         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 491         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 492         tui_display_registers_from_line.
 493         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 494         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 495         "force_display" parameter.
 496
 497 2019-07-17  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 500         declare.
 501         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 502         Rename from tui_first_reg_element_no_inline.
 503         (tui_display_reg_element_at_line)
 504         (tui_display_registers_from_line): Update.
 505         * tui/tui-data.h (struct tui_data_window)
 506         <first_reg_element_no_inline>: New method.
 507
 508 2019-07-17  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-windata.c (tui_display_data_from)
 511         (tui_data_window::do_scroll_vertical): Update.
 512         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 513         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 514         Rename from tui_line_from_reg_element_no.
 515         (tui_display_registers_from_line): Update.
 516         * tui/tui-data.h (struct tui_data_window)
 517         <line_from_reg_element_no>: New method.
 518
 519 2019-07-17  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 522         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 523         tui_last_regs_line_no.
 524         (tui_display_reg_element_at_line)
 525         (tui_display_registers_from_line): Update.
 526         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 527         method.
 528
 529 2019-07-17  Tom Tromey  <tom@tromey.com>
 530
 531         PR tui/24722:
 532         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 533         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 534         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 535         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 536         (tui_update_breakpoint_info): Likewise.
 537         * tui/tui-hooks.c (tui_event_create_breakpoint)
 538         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 539         Update.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 544
 545 2019-07-17  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-winsource.c (tui_update_source_window_as_is)
 548         (tui_update_source_windows_with_addr): Update.
 549         * tui/tui-source.h (tui_set_source_content)
 550         (tui_show_symtab_source): Add "win_info" parameter.
 551         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 552         parameter.
 553         (tui_show_symtab_source): Likewise.
 554
 555 2019-07-17  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-wingeneral.c
 558         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 559
 560 2019-07-17  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 563         (struct tui_cmd_window) <can_scroll>: New method.
 564         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 565         method.
 566
 567 2019-07-17  Tom Tromey  <tromey@adacore.com>
 568
 569         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 570         do_field_signed>: Rename.  Change type of "value".
 571         * ui-out.c (ui_out::field_signed): Rename from field_int.
 572         Change type of "value".
 573         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 574         type of "value".
 575         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 576         do_field_int.  Change type of "value".
 577         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 578         do_field_int.  Change type of "value".
 579         * tracepoint.c (trace_status_mi, tfind_1)
 580         (print_one_static_tracepoint_marker): Update.
 581         * thread.c (print_thread_info_1, print_selected_thread_frame):
 582         Update.
 583         * stack.c (print_frame, print_frame_info): Update.
 584         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 585         Update.
 586         * source.c (print_source_lines_base): Update.
 587         * skip.c (info_skip_command): Update.
 588         * record-btrace.c (btrace_ui_out_decode_error)
 589         (btrace_call_history_src_line): Update.
 590         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 591         Update.
 592         * progspace.c (print_program_space): Update.
 593         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 594         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 595         do_field_int.  Change type of "value".
 596         * mi/mi-out.c (mi_ui_out::do_table_begin)
 597         (mi_ui_out::do_table_header): Update.
 598         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 599         type of "value".
 600         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 601         (mi_cmd_data_list_changed_registers, output_register)
 602         (mi_cmd_data_read_memory, mi_load_progress)
 603         (mi_cmd_trace_frame_collected): Update.
 604         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 605         Update.
 606         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 607         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 608         (mi_cmd_var_list_children, varobj_update_one): Update.
 609         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 610         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 611         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 612         * inferior.c (print_inferior): Update.
 613         * gdb_bfd.c (print_one_bfd): Update.
 614         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 615         Update.
 616         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 617         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 618         do_field_int.  Change type of "value".
 619         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 620         do_field_int.  Change type of "value".
 621         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 622         (print_one_breakpoint_location, print_it_catch_fork)
 623         (print_one_catch_fork, print_it_catch_vfork)
 624         (print_one_catch_vfork, print_it_catch_solib)
 625         (print_it_catch_exec, print_it_ranged_breakpoint)
 626         (print_mention_watchpoint, print_mention_masked_watchpoint)
 627         (bkpt_print_it, update_static_tracepoint): Update.
 628         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 629         * break-catch-syscall.c (print_it_catch_syscall): Update.
 630         * ada-tasks.c (print_ada_task_info): Update.
 631         * ada-lang.c (print_it_exception, print_mention_exception):
 632         Update.
 633
 634 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 635
 636         PR breakpoints/24541
 637         * gdbarch.c: Regenerate.
 638         * gdbarch.h: Regenerate.
 639         * gdbarch.sh: Adjust return type and parameter types for
 640         'stap_adjust_register'.
 641         (i386_stap_adjust_register): Adjust signature and return new
 642         register name.
 643         * stap-probe.c (stap_parse_register_operand): Adjust use of
 644         'gdbarch_stap_adjust_register'.
 645
 646 2019-07-17  Tom Tromey  <tromey@adacore.com>
 647
 648         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 649         declare VEC.
 650         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 651         std::vector.
 652         (struct s390_process_info): Add initializers.
 653         (s390_add_process): Use new.
 654         (s390_linux_nat_target::low_forget_process): Use delete.
 655         (s390_linux_nat_target::low_new_fork)
 656         (s390_linux_nat_target::stopped_by_watchpoint)
 657         (s390_linux_nat_target::low_prepare_to_resume)
 658         (s390_linux_nat_target::insert_watchpoint)
 659         (s390_linux_nat_target::insert_hw_breakpoint)
 660         (s390_linux_nat_target::remove_watchpoint)
 661         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 662
 663 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 664
 665         * aarch64-fbsd-nat.c: Include regcache.h.
 666         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 667         argument.
 668         (aarch64_fbsd_nat_target::fetch_registers)
 669         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 670         variable.
 671         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 672
 673 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 674
 675         * fbsd-nat.c: Include gdbarch.h.
 676
 677 2019-07-15  Tom Tromey  <tromey@adacore.com>
 678
 679         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 680
 681 2019-07-15  Tom Tromey  <tromey@adacore.com>
 682
 683         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 684         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 685         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 686         * cli-out.c (cli_ui_out::do_field_int): New method.
 687         * ui-out.c (ui_out::field_unsigned): New method.
 688         * symfile.c (generic_load): Use field_unsigned.
 689         (print_transfer_performance): Likewise.
 690         * record-btrace.c (ui_out_field_uint): Remove.
 691         (btrace_call_history_insn_range, btrace_call_history): Use
 692         field_unsigned.
 693         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 694         field_unsigned.
 695         * ui-out.h (class ui_out) <field_unsigned>: New method.
 696         <do_field_unsigned>: Likewise.
 697
 698 2019-07-15  Tom Tromey  <tromey@adacore.com>
 699
 700         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 701         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 702         * target.c (flash_erase_command): Use field_string.
 703         * infrun.c (print_signal_received_reason): Use field_string.
 704         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 705         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 706         field_string.
 707         * ada-tasks.c (print_ada_task_info): Use field_string.
 708
 709 2019-07-15  Tom Tromey  <tromey@adacore.com>
 710
 711         * target.c (flash_erase_command): Use field_core_addr.
 712         * symfile.c (generic_load): Use field_core_addr.
 713         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 714         Use field_core_addr.
 715         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 716         field_core_addr.
 717
 718 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 719
 720         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 721         value if its desired type is smaller than a CORE_ADDR and signed.
 722
 723 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 724
 725         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 726         of changes to field names, and use new is_reference field to
 727         decide if a property is a reference or not.
 728         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 729         field.
 730         (struct dwarf2_property_baton): Update header comment, rename
 731         'referenced_type' to 'property_type' and update comments.
 732         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 733         default property type, store in property baton, update to take
 734         accound of renamed field.
 735         (read_func_scope): Update call to attr_to_dynamic_prop.
 736         (read_array_type): Likewise.
 737         (dwarf2_per_cu_addr_sized_int_type): New function.
 738         (read_subrange_index_type): Move type finding code to
 739         dwarf2_per_cu_addr_sized_int_type.
 740         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 741         (dwarf2_per_cu_addr_type): New function.
 742         (set_die_type): Update calls to attr_to_dynamic_prop.
 743
 744 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         * dwarf2read.c (read_subrange_index_type): New function.
 747         (read_subrange_type): Move code into new function and call it.
 748         * gdbtypes.c (create_range_type): Add some asserts.
 749
 750 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 753         update return statements.
 754         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 755         declaration, and update comment to match.
 756         * gdbtypes.c (resolve_dynamic_array): Update call to
 757         dwarf2_evaluate_property to match new return type.
 758
 759 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 760
 761         * valarith.c (value_subscripted_rvalue): Change lowerbound
 762         parameter type from int to LONGEST.
 763         * value.h (value_subscripted_rvalue): Likewise in declaration.
 764
 765 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 766
 767         * cli/cli-utils.c (info_print_command_completer): New function.
 768         * cli/cli-utils.h: Add 'completer.h' include, and forward
 769         declaration for 'struct cmd_list_element'.
 770         (info_print_command_completer): Declare.
 771         * stack.c (_initialize_stack): Add completer for 'info locals' and
 772         'info args'.
 773         * symtab.c (_initialize_symtab): Add completer for 'info
 774         variables' and 'info functions'.
 775         * NEWS: Mention completion for additional info commands.
 776
 777 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 778
 779         * cli/cli-utils.c (extract_info_print_args): Delete.
 780         (extract_arg_maybe_quoted): Delete.
 781         (info_print_options_defs): New variable.
 782         (make_info_print_options_def_group): New function.
 783         (extract_info_print_options): Define new function.
 784         * cli/cli-utils.h (extract_info_print_args): Delete.
 785         (struct info_print_options): New structure.
 786         (extract_info_print_options): Declare new function.
 787         * stack.c (info_locals_command): Update to use new
 788         extract_info_print_options, also add a header comment.
 789         (info_args_command): Likewise.
 790         * symtab.c (info_variables_command): Likewise.
 791         (info_functions_command): Likewise.
 792
 793 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 794
 795         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 796         to extract string arguments.
 797         * common/common-utils.c (extract_string_maybe_quoted): New function.
 798         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 799
 800 2019-07-11  Tom Tromey  <tromey@adacore.com>
 801
 802         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 803         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 804         * top.h (gdbinit): Don't declare.
 805         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 806         into...
 807         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 808         * top.c (gdb_init): Don't call init_cli_cmds.
 809         (gdbinit): Remove.
 810         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 811
 812 2019-07-11  Tom Tromey  <tromey@adacore.com>
 813
 814         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 815         after it has been moved.
 816
 817 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 818
 819         * valops.c (value_must_coerce_to_target): Change return type to
 820         bool.
 821         * value.h (value_must_coerce_to_target): Likewise.
 822
 823 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 824
 825         * breakpoint.c (is_hardware_watchpoint): Remove
 826         forward-declaration.
 827         (is_masked_watchpoint): Change return type to bool.
 828         (is_tracepoint): Likewise.
 829         (is_breakpoint): Likewise.
 830         (is_hardware_watchpoint): Likewise.
 831         (is_watchpoint): Likewise.
 832         (is_no_memory_software_watchpoint): Likewise.
 833         (is_catchpoint): Likewise.
 834         (breakpoint_1): Make FILTER parameter's return type bool.
 835         is_masked_watchpoint): Change return type to bool.
 836         (save_breakpoints): Make FILTER parameter's return type bool.
 837         * breakpoint.h (is_breakpoint): Change return type to bool.
 838         (is_watchpoint): Likewise.
 839         (is_catchpoint): Likewise.
 840         (is_tracepoint): Likewise.
 841
 842 2019-07-10  Tom Tromey  <tom@tromey.com>
 843
 844         * defs.h: Don't include gdbarch.h.
 845         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 846         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 847         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 848         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 849         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 850         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 851         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 852         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 853         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 854         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 855         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 856         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 857         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 858         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 859         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 860         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 861         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 862         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 863         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 864         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 865         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 866         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 867         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 868         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 869         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 870         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 871         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 872
 873 2019-07-10  Tom Tromey  <tromey@adacore.com>
 874
 875         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 876         * breakpoint.c (init_ada_exception_breakpoint): Register as
 877         bp_catchpoint.
 878         (print_one_breakpoint_location, print_one_breakpoint): Use
 879         is_ada_exception_catchpoint.
 880         * ada-lang.c (class ada_catchpoint_location): Pass
 881         bp_loc_software_breakpoint to bp_location constructor.
 882         (is_ada_exception_catchpoint): New function.
 883
 884 2019-07-10  Tom Tromey  <tromey@adacore.com>
 885
 886         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 887         VEC.
 888         (struct arm_exidx_entry): New method operator<.
 889         (struct arm_exidx_data) <section_maps>: Change type.
 890         (arm_exidx_data_free): Remove.
 891         (arm_exidx_data_key): Change type.  Move lower.
 892         (arm_exidx_new_objfile): Update.
 893         (arm_compare_exidx_entries): Remove.
 894         (arm_find_exidx_entry, _initialize_arm_tdep)
 895
 896 2019-07-10  Tom Tromey  <tromey@adacore.com>
 897
 898         * solib-spu.c (ocl_program_data_key): Change type.
 899         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 900         Update.
 901
 902 2019-07-10  Tom Tromey  <tromey@adacore.com>
 903
 904         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 905         (struct solib_aix_inferior_data) <library_list>: Change type.
 906         (solib_aix_inferior_data_handle): Change type.
 907         (get_solib_aix_inferior_data): Update.
 908         (solib_aix_free_library_list): Remove.
 909         (library_list_start_library): Update.
 910         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 911         return type.
 912         (solib_aix_get_library_list)
 913         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 914         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 915
 916 2019-07-10  Tom Tromey  <tromey@adacore.com>
 917
 918         * solib-dsbt.c (struct dsbt_info): Add initializers.
 919         (solib_dsbt_pspace_data): Change type.
 920         (dsbt_pspace_data_cleanup): Remove.
 921         (get_dsbt_info, _initialize_dsbt_solib): Update.
 922
 923 2019-07-10  Tom Tromey  <tromey@adacore.com>
 924
 925         * spu-tdep.c (spu_overlay_data): Change type.
 926         (spu_get_overlay_table, spu_overlay_new_objfile)
 927         (_initialize_spu_tdep): Update.
 928
 929 2019-07-10  Tom Tromey  <tromey@adacore.com>
 930
 931         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 932         destructor.
 933         (dbx_objfile_data_key): Change type and declare later.
 934         (DBX_SYMFILE_INFO): Rewrite.
 935         * dbxread.c (dbx_objfile_data_key): Change type.
 936         (dbx_symfile_init): Update.
 937         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 938         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 939         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 940
 941 2019-07-10  Tom Tromey  <tromey@adacore.com>
 942
 943         * jit.c (jit_program_space_key): Change type.  Move lower.
 944         (get_jit_program_space_data): Update.
 945         (jit_program_space_data_cleanup): Remove.
 946         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 947         Update.
 948         (struct jit_program_space_data): Add initializers.
 949
 950 2019-07-10  Tom Tromey  <tromey@adacore.com>
 951
 952         * solib-darwin.c (struct darwin_info): Add initializers.
 953         (solib_darwin_pspace_data): Change type.
 954         (darwin_pspace_data_cleanup): Remove.
 955         (get_darwin_info, _initialize_darwin_solib): Update.
 956
 957 2019-07-10  Tom Tromey  <tromey@adacore.com>
 958
 959         * remote-sim.c (struct sim_inferior_data): Add initializers,
 960         constructor, and destructor.
 961         (sim_inferior_data_key): Change type.  Move lower.
 962         (check_for_duplicate_sim_descriptor): Update.
 963         (get_sim_inferior_data): Use new.  Update.
 964         (~sim_inferior_data_cleanup): Rename from
 965         sim_inferior_data_cleanup.  Simplify.
 966         (gdbsim_close_inferior, simulator_command)
 967         (sim_command_completer, _initialize_remote_sim): Update.
 968         (next_pid, INITIAL_PID): Move earlier.
 969
 970 2019-07-10  Tom Tromey  <tromey@adacore.com>
 971
 972         * python/python-internal.h (create_thread_object): Return
 973         gdbpy_ref.
 974         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 975         * python/py-inferior.c (struct threadlist_entry): Add
 976         constructor.
 977         <thread_obj>: Now a gdbpy_ref.
 978         (thread_to_thread_object): Update.
 979         (add_thread_object): Use new.
 980         (delete_thread_object): Use delete.
 981         (infpy_threads): Update.
 982         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 983         GIL.
 984
 985 2019-07-10  Tom Tromey  <tromey@adacore.com>
 986
 987         * valops.c (value_cast): Specialize error message for Ada.
 988
 989 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 990
 991         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 992
 993 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 994
 995         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 996         bpstat_should_step): Return bool, adjust comments.
 997         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 998         bpstat_should_step): Likewise.
 999
1000 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1001
1002         * features/Makefile: Use feature target descriptions for Arm.
1003         * features/arm/arm-core.c: Generate new file.
1004         * features/arm/arm-fpa.c: Likewise.
1005         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1006         * features/arm/arm-m-profile.c: Likewise.
1007         * features/arm/arm-vfpv2.c: Likewise.
1008         * features/arm/arm-vfpv3.c: Likewise.
1009         * features/arm/xscale-iwmmxt.c: Likewise.
1010         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1011
1012 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1013
1014         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1015         ptrace earlier.
1016
1017 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1018
1019         * features/aarch64-pauth.c: Regenerate.
1020
1021 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1022
1023         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1024         bool.
1025         (bpstat_what): Use false instead of 0.
1026
1027 2019-07-09  Pedro Alves  <palves@redhat.com>
1028
1029         * break-catch-throw.c (is_exception_catchpoint): New.
1030         * breakpoint.c (print_one_breakpoint_location): New parameter
1031         'raw_loc'.  Handle it.  Use
1032         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1033         looking at the breakpoint's type.
1034         (print_one_breakpoint): If handling "maint info breakpoints", also
1035         print locations of exception catchpoints.
1036         * breakpoint.h (is_exception_catchpoint): Declare.
1037
1038 2019-07-09  Pedro Alves  <palves@redhat.com>
1039
1040         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1041         "addr" field.
1042         (allocate_location_exception_catchpoint): New.
1043         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1044         (initialize_throw_catchpoint_ops): Install
1045         allocate_location_exception_catchpoint as allocate_location
1046         method.
1047         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1048         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1049         bp_loc_other.
1050         (breakpoint_address_is_meaningful): Delete.
1051         (bl_address_is_meaningful): New.
1052         (breakpoint_locations_match): Adjust comment.
1053         (bp_location_from_bp_type): New, factored out of...
1054         (bp_location::bp_location(breakpoint *)): ... this.
1055         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1056         factored out of...
1057         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1058         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1059         breakpoint_address_is_meaningful.
1060         (bp_locations_compare): Adjust comment.
1061         (update_global_location_list): Use bl_address_is_meaningful
1062         instead of breakpoint_address_is_meaningful.
1063         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1064         explicit.
1065         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1066         * python/py-breakpoint.c (bppy_get_location): No longer check
1067         whether location is null.
1068
1069 2019-07-09  Pedro Alves  <palves@redhat.com>
1070
1071         PR c++/15468
1072         * breakpoint.c (print_one_breakpoint_location): Remove
1073         single-location assert.
1074
1075 2019-07-09  Tom Tromey  <tom@tromey.com>
1076
1077         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1078         * configure: Rebuild.
1079         * configure.ac: Change common to gdbsupport.
1080         * gdbsupport: Rename from common.
1081         * acinclude.m4: Change common to gdbsupport.
1082         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1083         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1084         gdbsupport.
1085         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1086         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1087         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1088         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1089         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1090         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1091         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1092         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1093         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1094         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1095         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1096         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1097         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1098         coff-pe-read.c, command.h, compile/compile-c-support.c,
1099         compile/compile-c.h, compile/compile-cplus-symbols.c,
1100         compile/compile-cplus-types.c, compile/compile-cplus.h,
1101         compile/compile-loc2c.c, compile/compile.c, completer.c,
1102         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1103         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1104         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1105         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1106         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1107         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1108         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1109         features/aarch64-core.c, features/aarch64-fpu.c,
1110         features/aarch64-pauth.c, features/aarch64-sve.c,
1111         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1112         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1113         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1114         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1115         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1116         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1117         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1118         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1119         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1120         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1121         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1122         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1123         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1124         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1125         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1126         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1127         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1128         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1129         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1130         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1131         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1132         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1133         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1134         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1135         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1136         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1137         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1138         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1139         minsyms.c, mips-linux-tdep.c, namespace.h,
1140         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1141         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1142         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1143         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1144         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1145         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1146         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1147         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1148         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1149         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1150         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1151         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1152         procfs.c, producer.c, progspace.h, psymtab.h,
1153         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1154         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1155         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1156         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1157         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1158         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1159         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1160         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1161         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1162         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1163         target-memory.c, target.c, target.h, target/waitstatus.c,
1164         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1165         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1166         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1167         unittests/array-view-selftests.c,
1168         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1169         unittests/common-utils-selftests.c,
1170         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1171         unittests/format_pieces-selftests.c,
1172         unittests/function-view-selftests.c,
1173         unittests/lookup_name_info-selftests.c,
1174         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1175         unittests/mkdir-recursive-selftests.c,
1176         unittests/observable-selftests.c,
1177         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1178         unittests/parse-connection-spec-selftests.c,
1179         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1180         unittests/scoped_fd-selftests.c,
1181         unittests/scoped_mmap-selftests.c,
1182         unittests/scoped_restore-selftests.c,
1183         unittests/string_view-selftests.c, unittests/style-selftests.c,
1184         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1185         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1186         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1187         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1188         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1189         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1190
1191 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1194         bool value.
1195         (decode_digits_ordinary): Set explicit_line field in sal.
1196         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1197         symtab_and_line that was set on an explicit line number in
1198         assembler code.  Do always update the recorded symtab and line if
1199         we do skip the prologue.
1200
1201 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * breakpoint.c (set_breakpoint_location_function): Remove
1204         explicit_loc parameter.
1205         (momentary_breakpoint_from_master): Update call to
1206         set_breakpoint_location_function.
1207         (add_location_to_breakpoint): Likewise.
1208
1209 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1210
1211         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1212         required features based on default bfd type when no specific bfd
1213         is present.
1214
1215 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1216
1217         * NEWS: Mention that GDB printf and eval commands can now print
1218         C-style and Ada-style convenience var strings without
1219         calling the inferior.
1220         * printcmd.c (printf_c_string): Locally print GDB internal var
1221         instead of transiting via the inferior.
1222         (printf_wide_c_string): Likewise.
1223
1224 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1225
1226         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1227
1228 2019-07-04  Tom Tromey  <tom@tromey.com>
1229
1230         PR tui/24724:
1231         * tui/tui-winsource.c (tui_clear_source_content): Update.
1232         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1233         (tui_update_breakpoint_info): Update.
1234         (tui_set_exec_info_content): Update.
1235         * tui/tui-source.c (tui_set_source_content_nil): Update.
1236         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1237         has_break.
1238         * tui/tui-data.h (enum tui_bp_flag): New.
1239         (tui_bp_flags): New enum flags type.
1240         (struct tui_source_element) <break_mode>: Change type.  Rename
1241         from has_break.
1242         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1243         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1244         constants.
1245         * tui/tui-winsource.h: Fix comment.
1246
1247 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1248
1249         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1250         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1251         (store_fpregs_to_thread)
1252         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1253         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1254         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1255         (IWMMXT_REGS_SIZE): Add define.
1256         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1257         (fetch_vfp_regs, store_vfp_regs)
1258         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1259         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1260
1261 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1262
1263         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1264         defines.
1265         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1266         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1267         (ARM_INT_REGISTER_SIZE): ...to this.
1268         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1269         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1270         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1271         (arm_linux_collect_gregset, supply_nwfpe_register)
1272         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1273         defines.
1274         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1275         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1276         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1277         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1278         (arm_return_in_memory, arm_store_return_value)
1279         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1280         (arm_record_ld_st_multiple): Likewise.
1281         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1282         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1283
1284 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1285
1286         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1287         AARCH64_DISPLACED_MODIFIED_INSNS.
1288         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1289         (aarch64_displaced_step_copy_insn): Likewise.
1290         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1291         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1292         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1293         ARM_DISPLACED_MODIFIED_INSNS.
1294         * arm-tdep.c (arm_gdbarch_init): Likewise.
1295         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1296         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1297         (struct arm_displaced_step_closure): Use
1298         ARM_DISPLACED_MODIFIED_INSNS.
1299
1300 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1301
1302         * features/Makefile: Remove unused xml files.
1303         * features/aarch64.xml: Remove.
1304         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1305         * features/i386/amd64-avx-avx512.xml: Remove.
1306         * features/i386/amd64-avx-linux.xml: Remove.
1307         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1308         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1309         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1310         * features/i386/amd64-avx-mpx.xml: Remove.
1311         * features/i386/amd64-avx.xml: Remove.
1312         * features/i386/amd64-linux.xml: Remove.
1313         * features/i386/amd64-mpx-linux.xml: Remove.
1314         * features/i386/amd64-mpx.xml: Remove.
1315         * features/i386/amd64.xml: Remove.
1316         * features/i386/i386-avx-avx512-linux.xml: Remove.
1317         * features/i386/i386-avx-avx512.xml: Remove.
1318         * features/i386/i386-avx-linux.xml: Remove.
1319         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1320         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1321         * features/i386/i386-avx-mpx-linux.xml: Remove.
1322         * features/i386/i386-avx-mpx.xml: Remove.
1323         * features/i386/i386-avx.xml: Remove.
1324         * features/i386/i386-linux.xml: Remove.
1325         * features/i386/i386-mmx-linux.xml: Remove.
1326         * features/i386/i386-mmx.xml: Remove.
1327         * features/i386/i386-mpx-linux.xml: Remove.
1328         * features/i386/i386-mpx.xml: Remove.
1329         * features/i386/i386.xml: Remove.
1330         * features/i386/x32-avx-avx512-linux.xml: Remove.
1331         * features/i386/x32-avx-linux.xml: Remove.
1332         * features/i386/x32-linux.xml: Remove.
1333
1334 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1335
1336         * regformats/aarch64.dat: Remove.
1337         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1338         * regformats/i386/amd64-avx-linux.dat: Remove.
1339         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1340         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1341         * regformats/i386/amd64-linux.dat: Remove.
1342         * regformats/i386/amd64-mpx-linux.dat: Remove.
1343         * regformats/i386/amd64.dat: Remove.
1344         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1345         * regformats/i386/i386-avx-linux.dat: Remove.
1346         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1347         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1348         * regformats/i386/i386-linux.dat: Remove.
1349         * regformats/i386/i386-mmx-linux.dat: Remove.
1350         * regformats/i386/i386-mpx-linux.dat: Remove.
1351         * regformats/i386/i386.dat: Remove.
1352         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1353         * regformats/i386/x32-avx-linux.dat: Remove.
1354         * regformats/i386/x32-linux.dat: Remove.
1355
1356 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1357
1358         * aarch64-tdep.c: Remove xml self tests.
1359         * amd64-linux-tdep.c: Likewise.
1360         * amd64-tdep.c: Likewise.
1361         * i386-linux-tdep.c: Likewise.
1362         * i386-tdep.c: Likewise.
1363
1364 2019-07-03  Pedro Alves  <palves@redhat.com>
1365
1366         PR cli/24732
1367         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1368         (pipe_cmd_option_defs): New.
1369         (make_pipe_cmd_options_def_group): New.
1370         (pipe_command): Use gdb::option::process_options.
1371         (pipe_command_completer): New function.
1372         (_initialize_cli_cmds): Install completer for "pipe" command.
1373
1374 2019-07-03  Pedro Alves  <palves@redhat.com>
1375
1376         * cli/cli-option.c (union option_value) <string>: New field.
1377         (struct option_def_and_value): Add ctor, move ctor, dtor and
1378         use DISABLE_COPY_AND_ASSIGN.
1379         (option_def_and_value::clear_value): New.
1380         (parse_option, save_option_value_in_ctx, get_val_type_str)
1381         (add_setshow_cmds_for_options): Handle var_string.
1382         * cli-option.h (union option_def::var_address) <string>: New
1383         field.
1384         (struct string_option_def): New.
1385         * maint-test-options.c (struct test_options_opts): Add default
1386         ctor and use DISABLE_COPY_AND_ASSIGN.
1387         <string_opt>: New field.
1388         (test_options_opts::~test_options_opts): New.
1389         (test_options_opts::dump): Also dump "-string".
1390         (test_options_option_defs): Install "string.
1391
1392 2019-07-03  Pedro Alves  <palves@redhat.com>
1393
1394         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1395         option_value with a null enumeration.
1396         (complete_options): Save the option values in the context.
1397         (save_option_value_in_ctx): New, factored out from ...
1398         (process_options): ... here.
1399         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1400         of the function.
1401         * maint-test-options.c (test_options_opts::dump): New, factored
1402         out from ...
1403         (maintenance_test_options_command_mode): ... here.
1404         (maintenance_test_options_command_completion_result): Delete.
1405         (maintenance_test_options_command_completion_text): Update
1406         comment.
1407         (maintenance_show_test_options_completion_result): Change
1408         prototype.  Just print
1409         maintenance_test_options_command_completion_text.
1410         (save_completion_result): New.
1411         (maintenance_test_options_completer_mode): Pass options context to
1412         complete_options, and then save a dump.
1413         (_initialize_maint_test_options): Use add_cmd to install "maint
1414         show test-options-completion-result".
1415
1416 2019-07-03  Pedro Alves  <palves@redhat.com>
1417
1418         * NEWS (New commands): Mention "with" and "maint with".
1419         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1420         (with_command, with_command_completer): New.
1421         (pipe_command): Adjust to new repeat_previous
1422         interface.
1423         (_initialize_cli_cmds): Install the "with" command and its "w"
1424         alias.
1425         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1426         declarations.
1427         * cli/cli-setshow.c (parse_cli_var_uinteger)
1428         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1429         argument strings for all var_types.
1430         (get_setshow_command_value_string): New, factored out from ...
1431         (do_show_command): ... this.
1432         * cli/cli-setshow.h: Include <string>.
1433         (get_setshow_command_value_string): Declare.
1434         * command.h (repeat_previous): Now returns const char *.  Adjust
1435         comment.
1436         * maint.c: Include "cli/cli-cmds.h".
1437         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1438         (_initialize_maint_cmds): Register the "maintenance with" command.
1439         * top.c (repeat_previous): Move bits from pipe_command here:
1440         Return the saved command line, if any; error out if there's no
1441         command to relaunch.
1442
1443 2019-07-03  Pedro Alves  <palves@redhat.com>
1444
1445         * NEWS (New commands): Mention "maint set/show test-settings"
1446         instead of "maint test-settings".
1447         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1448         (maintenance_test_settings_set_list): Rename to ...
1449         (maintenance_set_test_settings_list): ... this.
1450         (maintenance_test_settings_show_list): Rename to  ...
1451         (maintenance_show_test_settings_list): ... this.
1452         (maintenance_test_settings_cmd): Delete.
1453         (maintenance_test_settings_set_cmd): ...
1454         (maintenance_set_test_settings_cmd): ... this.
1455         (maintenance_test_settings_show_cmd): ...
1456         (maintenance_show_test_settings_cmd): ... this.
1457         (maintenance_test_settings_show_value_cmd):
1458         (maintenance_show_test_settings_value_cmd): ... this.
1459         (_initialize_maint_test_settings): No longer install the "maint
1460         test-settings" prefix command.  Rename "maint test-settings set"
1461         to "maint set test-settings", and "maint test-settings show" to
1462         "maint show test-settings".  Adjust all subcommands.
1463
1464 2019-07-03  Pedro Alves  <palves@redhat.com>
1465
1466         * maint-test-settings.c: Fix file's intro comment.  Replace all
1467         references to "test-options" with references to "test-settings",
1468         in comments.
1469
1470 2019-07-03  Pedro Alves  <palves@redhat.com>
1471
1472         * maint-test-settings.c (maintenance_test_settings_xxx)
1473         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1474         New.
1475         (maintenance_test_settings_enums): Use them.
1476         (maintenance_test_settings_enum): Default to
1477         maintenance_test_settings_xxx.
1478         (_initialize_maint_test_settings): Initialize
1479         MAINTENANCE_TEST_SETTINGS_FILENAME.
1480
1481 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1482
1483         * breakpoint.h (remove_breakpoints_inf): Change return type to
1484         void, move function documentation here.
1485         * breakpoint.c (remove_breakpoints_inf): Change return type to
1486         void, move function documentation to header.
1487
1488 2019-07-02  Pedro Alves  <palves@redhat.com>
1489
1490         * NEWS (Completion improvements): Mention "info threads".
1491         * thread.c (struct info_threads_opts, info_threads_option_defs)
1492         (make_info_threads_options_def_group): New.
1493         (info_threads_command): Use gdb::option::process_options.
1494         (info_threads_command_completer): New.
1495         (_initialize_thread): Use gdb::option::build_help to build the
1496         help text for "info threads".
1497
1498 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1499
1500         * defs.h (generic_load): Move from here...
1501         * symfile.h (generic_load): ... to here.  Rename name parameter
1502         to args.
1503         * symfile.c (generic_load): Add comment.
1504
1505 2019-07-01  Tom Tromey  <tromey@adacore.com>
1506
1507         * dwarf2read.c
1508         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1509         declaration of without_params.  Fix formatting.
1510
1511 2019-07-01  Tom Tromey  <tromey@adacore.com>
1512
1513         * ada-exp.y (find_primitive_type): Update.
1514         * ada-lang.h (ada_lookup_symbol): Update.
1515         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1516         parameter.
1517         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1518
1519 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1520
1521         PR breakpoints/24541
1522         * gdbarch.c: Regenerate.
1523         * gdbarch.h: Regenerate.
1524         * gdbarch.sh: Add 'stap_adjust_register'.
1525         * i386-tdep.c: Include '<unordered_set>'.
1526         (i386_stap_adjust_register): New function.
1527         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1528         * stap-probe.c (stap_parse_register_operand): Call
1529         'gdbarch_stap_adjust_register'.
1530
1531 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1532
1533         PR python/24742
1534         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1535         * python/python.c (do_start_initialization): Use 'xmalloc'
1536         instead of 'PyMem_Malloc'.
1537
1538 2019-06-28  Tom Tromey  <tromey@adacore.com>
1539
1540         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1541         for Ada.
1542
1543 2019-06-27  Tom Tromey  <tromey@adacore.com>
1544
1545         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1546         objfile_key.
1547         (arm_find_mapping_symbol, arm_record_special_symbol)
1548         (_initialize_arm_tdep): Update.
1549         (arm_objfile_data_free): Remove.
1550
1551 2019-06-27  Tom Tromey  <tromey@adacore.com>
1552
1553         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1554         to cp_print_static_field.
1555
1556 2019-06-26  Tom Tromey  <tromey@adacore.com>
1557
1558         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1559         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1560         declare.
1561
1562 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1563
1564         * features/aarch64-core.c (create_feature_aarch64_core):
1565         Regenerate.
1566         * features/aarch64-core.xml: Add cpsr flags.
1567
1568 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1569
1570         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1571         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1572
1573 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1574
1575         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1576         field.
1577         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1578         use.
1579         (arm_record_special_symbol): Don't insert new symbol in sorted
1580         position, push it at the end.
1581
1582 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1583
1584         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1585         (arm_mapping_symbol_s): Remove.
1586         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1587         (arm_mapping_symbol_vec): New typedef.
1588         (struct arm_per_objfile): Add constructor.
1589         <section_maps>: Change type to
1590         std::unique_ptr<arm_mapping_symbol_vec[]>.
1591         (arm_compare_mapping_symbols): Remove.
1592         (arm_find_mapping_symbol): Adjust to section_maps type change.
1593         (arm_objfile_data_free): Call delete on arm_per_objfile.
1594         (arm_record_special_symbol): Adjust to section_maps type change.
1595         Allocate arm_per_objfile with new.
1596
1597 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1598
1599         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1600         with the command prefix.
1601
1602 2019-06-25  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1605         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1606
1607 2019-06-25  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1610         type.
1611         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1612         protected.
1613
1614 2019-06-25  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-winsource.c
1617         (tui_source_window_base::set_is_exec_point_at): Add check against
1618         LOA_ADDRESS.
1619
1620 2019-06-25  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-source.c (tui_set_source_content): Don't check before
1623         xfree.
1624         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1625
1626 2019-06-25  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-winsource.h (tui_update_source_window_as_is)
1629         (tui_alloc_source_buffer, tui_line_is_displayed)
1630         (tui_addr_is_displayed): Change type of win_info.
1631         * tui/tui-winsource.c (tui_update_source_window_as_is)
1632         (tui_clear_source_content, tui_show_source_line)
1633         (tui_show_source_content, tui_source_window_base::refill)
1634         (tui_source_window_base::set_is_exec_point_at)
1635         (tui_source_window_base::set_is_exec_point_at)
1636         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1637         (tui_alloc_source_buffer, tui_line_is_displayed)
1638         (tui_addr_is_displayed): Change type of win_info.  Update.
1639         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1640         (tui_source_window_base::do_make_visible_with_new_height):
1641         Update.
1642         * tui/tui-source.c (tui_set_source_content)
1643         (tui_set_source_content_nil)
1644         (tui_source_window::do_scroll_vertical): Update.
1645         * tui/tui-layout.c (show_layout): Update.
1646         * tui/tui-disasm.c (tui_set_disassem_content)
1647         (tui_disasm_window::do_scroll_vertical): Update.
1648         * tui/tui-data.h (tui_win_content): Remove.
1649         (struct tui_gen_win_info) <content, content_size>: Remove.
1650         (struct tui_source_element): Add initializers and destructor.
1651         (union tui_which_element, struct tui_win_element): Remove.
1652         (struct tui_source_window_base) <content>: New field.
1653         (struct tui_data_window): Remove destructor.
1654         (tui_alloc_content, tui_free_win_content)
1655         (tui_free_all_source_wins_content): Don't declare.
1656         * tui/tui-data.c (tui_initialize_static_data): Update.
1657         (init_content_element, tui_alloc_content): Remove.
1658         (~tui_gen_win_info): Update.
1659         (~tui_data_window, tui_free_all_source_wins_content)
1660         (tui_free_win_content, free_content, free_content_elements):
1661         Remove.
1662
1663 2019-06-25  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-winsource.h (tui_clear_source_content)
1666         (tui_erase_source_content, tui_show_source_content): Change type
1667         of win_info.
1668         * tui/tui-winsource.c (tui_clear_source_content)
1669         (tui_erase_source_content, tui_show_source_content): Change type
1670         of win_info.
1671         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1672         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1673         win_info.
1674         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1675         win_info.
1676         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1677
1678 2019-06-25  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-winsource.c (tui_clear_source_content)
1681         (tui_source_window_base::set_is_exec_point_at): Update.
1682         * tui/tui-source.c (tui_set_source_content_nil): Update.
1683         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1684         a bool.
1685         * tui/tui-data.c (init_content_element): Update.
1686
1687 2019-06-25  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1690         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1691         * tui/tui-layout.c (init_and_make_win): Update.
1692         * tui/tui.h (enum tui_win_type): Update.
1693         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1694         tui_win_is_auxillary.
1695         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1696         tui_win_is_auxillary.
1697
1698 2019-06-25  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1701         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1702         (tui_delete_data_content_windows, tui_display_all_data)
1703         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1704         Update.
1705         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1706         * tui/tui-regs.c (tui_last_regs_line_no)
1707         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1708         (tui_show_registers): Update.
1709         (tui_show_register_group): Return void.  Update.
1710         (tui_display_registers_from, tui_display_reg_element_at_line)
1711         (tui_display_registers_from_line, tui_check_register_values):
1712         Update.
1713         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1714         member.
1715         (struct tui_data_window) <regs_content>: Now a std::vector.
1716         <regs_content_count>: Remove.
1717         (tui_add_content_elements, tui_free_data_content): Don't declare.
1718         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1719         (init_content_element): Remove DATA_WIN case.  Add assert.
1720         (tui_add_content_elements): Remove.
1721         (tui_data_window): Update.
1722         (tui_free_data_content): Remove.
1723         (free_content_elements): Remove DATA_WIN case.
1724
1725 2019-06-25  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-data.c (tui_data_item_window): Update.
1728         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1729         * tui/tui-windata.c (tui_display_all_data)
1730         (tui_display_data_from_line): Update.
1731         (tui_check_data_values): Remove.
1732         * tui/tui-regs.c (tui_show_register_group)
1733         (tui_display_reg_element_at_line): Update.
1734         * tui/tui-hooks.c (tui_register_changed)
1735         (tui_refresh_frame_and_register_information): Call
1736         tui_check_register_values.
1737         * tui/tui-data.h (struct tui_data_window) <data_content,
1738         data_content_count, data_type>: Remove.
1739         (enum tui_data_type): Remove.
1740
1741         * tui/tui-data.c (tui_data_window::clear_detail)
1742         (~tui_data_window): Update.
1743
1744 2019-06-25  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1747         declare.
1748         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1749         Rename from tui_first_data_item_displayed.  Update.
1750         (tui_data_window::refresh_all)
1751         (tui_data_window::do_scroll_vertical): Update.
1752         * tui/tui-data.h (struct tui_data_window)
1753         <first_data_item_displayed>: Declare new method.
1754
1755 2019-06-25  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1758         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1759         contents...
1760         (tui_initialize_static_data): ...here.
1761
1762 2019-06-25  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1765         (tui_display_registers_from, tui_check_register_values): Update.
1766         (tui_display_register): Remove win_info parameter; update.
1767         (tui_get_register): Change type of parameters.
1768         * tui/tui-data.h (struct tui_data_element): Remove.
1769         (union tui_which_element) <data>: Remove.
1770         <data_window>: Change type.
1771         (struct tui_data_item_window): New.
1772         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1773         case.  Add assert.
1774         (~tui_data_item_window): New destructor.
1775         (free_content_elements): Remove DATA_ITEM_WIN case.
1776
1777 2019-06-25  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1780         Remove.
1781
1782 2019-06-25  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-data.h (struct tui_command_element): Remove.
1785         (union tui_which_element) <command>: Remove.
1786         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1787         assert.
1788         (free_content_elements): Remove CMD_WIN case.
1789
1790 2019-06-25  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-layout.c (tui_set_layout): Update.
1793         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1794         * tui/tui-data.c (layout_def): Update.
1795
1796 2019-06-25  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1799         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1800         (tui_source_window_base::set_new_height): Update.
1801         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1802         Update.
1803         (tui_set_locator_fullname, tui_set_locator_info)
1804         (tui_show_frame_info): Update.
1805         * tui/tui-source.c (tui_set_source_content)
1806         (tui_source_is_displayed): Update.
1807         * tui/tui-layout.c (show_source_disasm_command, show_data)
1808         (show_source_or_disasm_and_command): Update.
1809         * tui/tui-disasm.c (tui_set_disassem_content)
1810         (tui_get_begin_asm_address): Update.
1811         * tui/tui-data.h (struct tui_locator_element): Remove.
1812         (union tui_which_element) <locator>: Remove.
1813         (struct tui_locator_window): New.
1814         (tui_locator_win_info_ptr): Change return type.
1815         * tui/tui-data.c (_locator): Change type.
1816         (tui_locator_win_info_ptr): Change return type.
1817         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1818         (tui_alloc_content): Add assert.
1819
1820 2019-06-25  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-winsource.c
1823         (tui_exec_info_window::maybe_allocate_content): New method.
1824         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1825         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1826         (make_source_or_disasm_window): Add cast.
1827         * tui/tui-data.h (union tui_which_element) <simple_string>:
1828         Remove.
1829         (struct tui_source_info): New.
1830         (struct tui_source_window_base) <execution_info>: Change type.
1831         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1832         case, and add assert.
1833         (tui_alloc_content): Add assert.
1834
1835 2019-06-25  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1838         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1839         * tui/tui-data.c (tui_alloc_win_info): Remove.
1840
1841 2019-06-25  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1844         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1845         can_highlight.
1846
1847 2019-06-25  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1850         make_visible_with_new_height method.
1851         (tui_win_info::make_visible_with_new_height): New method.
1852         (tui_source_window_base::do_make_visible_with_new_height)
1853         (tui_data_window::do_make_visible_with_new_height)
1854         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1855         (make_visible_with_new_height): Remove.
1856         (tui_resize_all, tui_adjust_win_heights): Use
1857         make_visible_with_new_height method.
1858         * tui/tui-data.h (struct tui_win_info)
1859         <do_make_visible_with_new_height, make_visible_with_new_height>:
1860         New methods.
1861         (struct tui_source_window_base, struct tui_data_window)
1862         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1863         methods.
1864
1865 2019-06-25  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1868         method.
1869         (update_tab_width): Call update_tab_width method.
1870         * tui/tui-data.h (struct tui_win_info)
1871         (struct tui_source_window_base) <update_tab_width>: New methods.
1872
1873 2019-06-25  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1876         parameter.
1877         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1878         parameter.
1879         (tui_gen_win_info::make_visible): Update.
1880         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1881         parameter.
1882         * tui/tui-data.h (enum tui_box): New enum.
1883         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1884
1885 2019-06-25  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1888         init_and_make_win for EXEC_INFO_WIN.
1889         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1890         longer inline.
1891         (struct tui_win_info) <~tui_win_info>: Inline.
1892         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1893         Don't declare.
1894         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1895         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1896         Remove.
1897         (tui_initialize_static_data): Update.
1898         (~tui_gen_win_info): Handle more cleanup here.
1899         (~tui_source_window_base): Delete "execution_info".
1900         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-layout.c (make_command_window): Don't set
1905         can_highlight.
1906         (show_source_disasm_command): Call the reset method.
1907         (show_data): Don't set can_highlight.  Call the reset method.
1908         (tui_gen_win_info::reset): Rename from init_gen_win_info
1909         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1910         (show_source_or_disasm_and_command): Call the reset method.
1911         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1912         (struct tui_cmd_window): Set can_highlight.
1913
1914 2019-06-25  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1917         from make_visible.
1918         (tui_make_visible, tui_make_invisible): Rewrite.
1919         (tui_win_info::make_visible): Remove.
1920         (tui_source_window_base::make_visible): Update.
1921         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1922         method.  Moved from...
1923         (struct tui_win_info) <make_visible>: ...here.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-winsource.c
1928         (tui_source_window_base::do_scroll_horizontal): Remove direction
1929         parameter.
1930         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1931         direction parameter.
1932         * tui/tui-win.c (tui_win_info::forward_scroll)
1933         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1934         (tui_win_info::right_scroll): Update.
1935         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1936         direction parameter.
1937         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1938         direction parameter.
1939         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1940         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1941         Remove direction parameter.
1942         (struct tui_source_window_base, struct tui_source_window)
1943         (struct tui_disasm_window, struct tui_data_window)
1944         (struct tui_cmd_window): Update.
1945
1946 2019-06-25  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-winsource.h (tui_set_exec_info_content)
1949         (tui_show_exec_info_content, tui_erase_exec_info_content)
1950         (tui_clear_exec_info_content, tui_update_exec_info): Change
1951         argument to tui_source_window_base.
1952         * tui/tui-winsource.c (tui_set_exec_info_content)
1953         (tui_show_exec_info_content, tui_erase_exec_info_content)
1954         (tui_clear_exec_info_content, tui_update_exec_info): Change
1955         argument to tui_source_window_base.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1960         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1961
1962 2019-06-25  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1965         check.
1966
1967 2019-06-25  Tom Tromey  <tom@tromey.com>
1968
1969         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1970         type to void.
1971         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1972         type to void.
1973         * tui/tui-source.c (tui_set_source_content): Update.
1974         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1975
1976 2019-06-25  Tom Tromey  <tom@tromey.com>
1977
1978         * tui/tui-win.c (window_name_completer, tui_set_focus)
1979         (tui_all_windows_info): Use name method.
1980         * tui/tui-data.h (struct tui_gen_win_info)
1981         (struct tui_source_window, struct tui_disasm_window)
1982         (struct tui_data_window, struct tui_cmd_window) <name>: New
1983         method.
1984         (tui_win_name): Don't declare.
1985         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1986         (tui_win_name): Remove.
1987
1988 2019-06-25  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-winsource.h (tui_update_source_window)
1991         (tui_update_source_window_as_is): Change parameter type.
1992         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1993         to be a tui_source_window_base.
1994         (tui_update_source_window_as_is): Likewise.
1995         * tui/tui-win.c (make_visible_with_new_height): Update.
1996
1997 2019-06-25  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-winsource.c (tui_erase_source_content)
2000         (tui_show_source_content, tui_show_exec_info_content)
2001         (tui_erase_exec_info_content): Use refresh_window method.
2002         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2003         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2004         from tui_refresh_win.
2005         (tui_data_window::refresh_window): New method.
2006         (tui_win_info::refresh, tui_source_window_base::refresh)
2007         (tui_refresh_all): Use refresh_window method.
2008         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2009         method.
2010         * tui/tui-regs.c (tui_display_register): Call refresh_window
2011         method.
2012         * tui/tui-layout.c (show_source_disasm_command)
2013         (show_source_or_disasm_and_command): Call refresh_window method.
2014         * tui/tui-data.h (struct tui_gen_win_info)
2015         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2016         New method.
2017
2018 2019-06-25  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui.c (tui_rl_other_window, tui_enable)
2021         (tui_is_window_visible, tui_get_command_dimension): Update.
2022         * tui/tui-winsource.c (tui_update_source_window_as_is)
2023         (tui_clear_source_content, tui_erase_source_content)
2024         (tui_show_source_line, tui_source_window_base::refill)
2025         (tui_source_window_base::do_scroll_horizontal)
2026         (tui_source_window_base::set_is_exec_point_at)
2027         (tui_update_breakpoint_info, tui_set_exec_info_content)
2028         (tui_alloc_source_buffer, tui_line_is_displayed)
2029         (tui_addr_is_displayed): Update.
2030         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2031         (tui_check_and_display_highlight_if_needed)
2032         (tui_win_info::make_visible, tui_win_info::refresh)
2033         (tui_refresh_all): Update.
2034         * tui/tui-windata.c (tui_first_data_item_displayed)
2035         (tui_delete_data_content_windows, tui_erase_data_content)
2036         (tui_display_all_data, tui_data_window::refresh_all)
2037         (tui_check_data_values): Update.
2038         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2039         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2040         (tui_win_info::backward_scroll, tui_refresh_all_win)
2041         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2042         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2043         (tui_source_window_base::set_new_height)
2044         (tui_data_window::set_new_height)
2045         (make_invisible_and_set_new_height)
2046         (make_visible_with_new_height, new_height_ok)
2047         (parse_scrolling_args): Update.
2048         * tui/tui-stack.c (tui_show_frame_info): Update.
2049         * tui/tui-source.c (tui_set_source_content)
2050         (tui_set_source_content_nil, tui_source_is_displayed)
2051         (tui_source_window::do_scroll_vertical): Update.
2052         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2053         (tui_display_registers_from, tui_display_reg_element_at_line)
2054         (tui_check_register_values, tui_reg_command): Update.
2055         * tui/tui-layout.c (tui_default_win_height)
2056         (show_source_disasm_command, show_data, init_and_make_win)
2057         (show_source_or_disasm_and_command): Update.
2058         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2059         (tui_redisplay_readline, tui_mld_flush)
2060         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2061         (tui_getc): Update.
2062         * tui/tui-disasm.c (tui_set_disassem_content)
2063         (tui_disasm_window::do_scroll_vertical): Update.
2064         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2065         Now virtual.
2066         (struct tui_win_info): Derive from tui_gen_win_info.
2067         <~tui_win_info>: Mark as override.
2068         <generic>: Remove member.
2069         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2070         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2071         (~tui_data_window, ~tui_win_info)
2072         (tui_free_all_source_wins_content): Update.
2073         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-layout.c (init_and_make_win): Use new.
2078         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2079         destructor, initializers.
2080         (tui_alloc_generic_win_info): Don't declare.
2081         * tui/tui-data.c (_locator): Add argument to constructor.
2082         (source_win, disasm_win): New globals.
2083         (exec_info): Remove.
2084         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2085         Update.
2086         (tui_alloc_generic_win_info): Remove.
2087         (init_content_element): Use new.
2088         (tui_win_info::tui_win_info): Update.
2089         (free_content_elements) <case DATA_WIN>: Use delete.
2090
2091 2019-06-25  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2094         * tui/tui-windata.c (tui_first_data_item_displayed)
2095         (tui_delete_data_content_windows): Update.
2096         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2097         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2098         (tui_display_registers_from, tui_check_register_values): Update.
2099         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2100         pointer.
2101         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2102         window.
2103         (tui_free_data_content): Update.
2104         (free_content_elements) <case DATA_WIN>: Free the window.
2105
2106 2019-06-25  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2109         Update.
2110         * tui/tui-layout.c (make_command_window)
2111         (show_source_disasm_command, show_data, init_and_make_win)
2112         (show_source_or_disasm_and_command): Update.
2113         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2114         method.
2115         <can_highight, is_highlighted>: Now bool.
2116         (tui_set_win_highlight): Don't declare.
2117         * tui/tui-data.c (tui_set_win_highlight): Remove.
2118
2119 2019-06-25  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-wingeneral.c (make_visible): Remove check of window
2122         type.
2123
2124 2019-06-25  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui-win.c (tui_win_info::max_height)
2127         (tui_cmd_window::max_height): New methods.
2128         (new_height_ok): Call max_height.
2129         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2130         <max_height>: New method.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-win.c (tui_source_window_base::set_new_height)
2135         (tui_data_window::set_new_height): New methods.
2136         (make_invisible_and_set_new_height): Call set_new_height method.
2137         * tui/tui-data.h (struct tui_win_info)
2138         (struct tui_source_window_base, struct tui_data_window)
2139         <set_new_height>: New method.
2140
2141 2019-06-25  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2144         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2145         tui_refresh_data_win.
2146         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2147         method.
2148         (tui_refresh_all_win): Call the refresh_all method.
2149         (tui_set_focus): Likewise.
2150         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2151         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2152         Likewise.
2153
2154 2019-06-25  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-winsource.h (tui_refill_source_window)
2157         (tui_set_is_exec_point_at): Don't declare.
2158         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2159         (tui_source_window_base::refill): Rename from
2160         tui_refill_source_window.
2161         (tui_source_window_base::do_scroll_horizontal): Update.
2162         (tui_source_window_base::set_is_exec_point_at): Rename from
2163         tui_set_is_exec_point_at.
2164         (tui_update_all_breakpoint_info): Update.
2165         * tui/tui-stack.c (tui_show_frame_info): Update.
2166         * tui/tui-layout.c (show_data): Add cast.
2167         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2168         * tui/tui-data.h (struct tui_source_window_base) <refill,
2169         set_is_exec_point_at>: New methods.
2170         (tui_source_windows, tui_add_to_source_windows): Update types.
2171         (tui_add_to_source_windows): Remove redundant declaration.
2172         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2173         (tui_source_windows): Change return type.
2174         (tui_clear_source_windows_detail): Update.
2175         (tui_add_to_source_windows): Change type of parameter.
2176         (tui_free_all_source_wins_content): Update.
2177
2178 2019-06-25  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-wingeneral.c (tui_win_info::refresh)
2181         (tui_source_window_base::refresh): New methods.
2182         (tui_refresh_all): Call the refresh method.
2183         * tui/tui-data.h (struct tui_win_info)
2184         (struct tui_source_window_base) <refresh>: New method.
2185
2186 2019-06-25  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui.h (tui_is_window_visible): Return bool.
2189         * tui/tui.c (tui_is_window_visible): Return bool.
2190         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2191         (tui_make_visible, tui_make_invisible)
2192         (tui_win_info::make_visible)
2193         (tui_source_window_base::make_visible, make_all_visible)
2194         (tui_make_all_visible, tui_make_all_invisible): Update.
2195         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2196         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2197         bool.
2198         (struct tui_win_info, struct tui_source_window_base)
2199         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2200         * tui/tui-data.c (tui_init_generic_part): Update.
2201
2202 2019-06-25  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2205         (tui_source_window_base::make_visible): New methods.
2206         (make_all_visible): Make method call.
2207         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2208         (struct tui_source_window_base, struct tui_cmd_window): Override
2209         make_visible.
2210         (tui_win_is_source_type): Don't declare.
2211         * tui/tui-data.c (tui_win_is_source_type): Remove.
2212
2213 2019-06-25  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2216         NULL check.
2217
2218 2019-06-25  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2221         Inline constructor.  Add initializers for members.
2222         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2223         constructors; now inline in class.
2224
2225 2019-06-25  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-regs.c (tui_show_registers): Update.
2228         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2229         bool.
2230         * tui/tui-data.c (tui_data_window::clear_detail)
2231         (tui_data_window): Update.
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-windata.c (tui_display_all_data)
2236         (tui_display_data_from_line, tui_display_data_from)
2237         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2238         Update.
2239         * tui/tui-regs.c (tui_last_regs_line_no)
2240         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2241         (tui_show_registers, tui_show_register_group)
2242         (tui_display_registers_from, tui_display_reg_element_at_line)
2243         (tui_display_registers_from_line, tui_check_register_values)
2244         (tui_reg_next, tui_reg_prev): Update.
2245         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2246         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2247         tui_data_window.
2248         (struct tui_win_info) <detail>: Remove.  Add new fields from
2249         tui_data_info.
2250         (TUI_DATA_WIN): Add cast.
2251         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2252         (~tui_data_window): Simplify.
2253
2254 2019-06-25  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-layout.c (show_source_disasm_command)
2257         (show_source_or_disasm_and_command): Update.
2258         * tui/tui-io.c (update_cmdwin_start_line)
2259         (tui_redisplay_readline): Update.
2260         * tui/tui-data.h (struct tui_command_info): Remove.
2261         (struct tui_win_info) <detail>: Remove command_info member.
2262         (struct tui_data_window) <start_line>: New member, from
2263         tui_command_info.
2264         (TUI_CMD_WIN): Add casts.
2265
2266 2019-06-25  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-winsource.c (tui_update_source_window)
2269         (tui_refill_source_window)
2270         (tui_source_window_base::do_scroll_horizontal)
2271         (tui_update_breakpoint_info, tui_set_exec_info_content)
2272         (tui_show_exec_info_content, tui_erase_exec_info_content)
2273         (tui_clear_exec_info_content): Update.
2274         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2275         Update.
2276         * tui/tui-win.c (make_invisible_and_set_new_height)
2277         (make_visible_with_new_height): Update.
2278         * tui/tui-source.c (tui_set_source_content)
2279         (tui_show_symtab_source): Update.
2280         * tui/tui-layout.c (extract_display_start_addr)
2281         (show_source_disasm_command, show_data)
2282         (make_source_or_disasm_window)
2283         (show_source_or_disasm_and_command): Update.
2284         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2285         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2286         "gdbarch".
2287         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2288         to tui_source_window_base.
2289         (struct tui_win_info) <detail>: Remove source_info member.
2290         (struct tui_source_window_base) <has_locator>: Inline.
2291         Move contents from tui_source_info; rename has_locator member to
2292         m_has_locator.
2293         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2294         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2295         header file.
2296         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2297         Simplify.
2298         (tui_free_all_source_wins_content): Cast to
2299         tui_source_window_base.
2300
2301 2019-06-25  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-win.c (make_invisible_and_set_new_height)
2304         (make_visible_with_new_height): Call has_locator method.
2305         * tui/tui-layout.c (show_source_disasm_command, show_data)
2306         (show_source_or_disasm_and_command): Update for bool change.
2307         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2308         (tui_win_info) <has_locator>: New method.
2309         (struct tui_source_window_base) <has_locator>: New method.
2310         (tui_win_has_locator): Don't declare.
2311         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2312         from tui_win_has_locator.
2313         (tui_source_window_base): Use false, not FALSE.
2314
2315 2019-06-25  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2318         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2319         clear_detail method directly.
2320         (tui_clear_win_detail): Remove.
2321
2322 2019-06-25  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2325         "this", not TUI_DISASM_WIN.
2326
2327 2019-06-25  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2330         declare.
2331         * tui/tui-winsource.c
2332         (tui_source_window_base::do_scroll_horizontal): Rename from
2333         tui_horizontal_source_scroll.
2334         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2335         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2336         from tui_vertical_data_scroll.
2337         * tui/tui-win.h (tui_scroll): Don't declare.
2338         * tui/tui-win.c (tui_win_info::forward_scroll)
2339         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2340         (tui_win_info::right_scroll): Rename and update.
2341         (tui_scroll_forward_command, tui_scroll_backward_command)
2342         (tui_scroll_left_command, tui_scroll_right_command): Update.
2343         (tui_scroll): Remove.
2344         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2345         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2346         from tui_vertical_source_scroll.
2347         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2348         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2349         from tui_vertical_disassem_scroll.
2350         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2351         do_scroll_horizontal>: New methods.
2352         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2353         Likewise.
2354         (struct tui_source_window_base): Add do_scroll_horizontal.
2355         (struct tui_source_window, struct tui_disasm_window): Add
2356         do_scroll_vertical.
2357         (struct tui_data_window, struct tui_cmd_window): Add
2358         do_scroll_horizontal and do_scroll_vertical.
2359         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2360
2361 2019-06-25  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-data.h (struct tui_source_window_base): New struct.
2364         (struct tui_source_window): Derive from tui_source_window_base.
2365         (struct tui_disasm_window): New struct.
2366         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2367         from tui_source_window::clear_detail.
2368         (tui_source_window_base): Rename from tui_source_window.
2369         (~tui_source_window_base): Rename from ~tui_source_window.
2370         (tui_alloc_win_info): Create a tui_disasm_window.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-data.h (struct tui_source_window)
2375         (struct tui_data_window): Declare destructors.
2376         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2377         destructors.
2378         (tui_win_info): Simplify.
2379
2380 2019-06-25  Tom Tromey  <tom@tromey.com>
2381
2382         * tui/tui-winsource.c (tui_display_main)
2383         (tui_update_source_windows_with_addr)
2384         (tui_update_all_breakpoint_info): Update.
2385         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2386         (new_height_ok, parse_scrolling_args): Update.
2387         * tui/tui-stack.c (tui_show_frame_info): Update.
2388         * tui/tui-data.h (struct tui_list): Remove.
2389         (tui_source_windows): Return a reference to a std::vector.
2390         * tui/tui-data.c (source_windows): Now a std::vector.
2391         (tui_source_windows): Change return type.
2392         (tui_clear_source_windows): Rewrite.
2393         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2394         (tui_free_all_source_wins_content): Rewrite.
2395
2396 2019-06-25  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2399         (struct tui_data_window, struct tui_cmd_window): Declare
2400         clear_detail method.
2401         * tui/tui-data.c (tui_source_window::clear_detail)
2402         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2403         methods.
2404         (tui_clear_win_detail): Simplify.
2405
2406 2019-06-25  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-layout.c (make_source_window, make_disasm_window)
2409         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2410         Return the new window.
2411         (show_source_disasm_command, show_data)
2412         (show_source_or_disasm_and_command): Update.
2413
2414 2019-06-25  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2417         parameter.  Return the new window.
2418         (show_source_disasm_command): Update and remove NULL check.
2419         (show_source_or_disasm_and_command): Update.
2420
2421 2019-06-25  Tom Tromey  <tom@tromey.com>
2422
2423         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2424
2425 2019-06-25  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-data.h (struct tui_win_info): Make constructor
2428         protected.  Make destructor virtual.  Add initializers.
2429         (tui_source_window, tui_data_window, tui_cmd_window): New
2430         classes.
2431         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2432         constructor.  Add "type" parameter.
2433         (tui_source_window, tui_data_window, tui_cmd_window): New
2434         constructors.
2435         (tui_alloc_win_info): Instantiate the appropriate subclass.
2436
2437 2019-06-25  Tom Tromey  <tom@tromey.com>
2438
2439         * tui/tui-win.c (tui_resize_all): Use delete.
2440         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2441         destructor.
2442         (tui_free_window): Don't declare.
2443         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2444         Update.
2445
2446 2019-06-25  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-data.h (struct tui_win_info): Add constructor.
2449         * tui/tui-data.c (tui_alloc_win_info): Use new.
2450         (tui_free_window): Use delete.
2451
2452 2019-06-22  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2455         declare.
2456         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2457
2458 2019-06-22  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2461         declare.
2462         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2463
2464 2019-06-22  Tom de Vries  <tdevries@suse.de>
2465
2466         * dwarf2read.c (create_addrmap_from_aranges)
2467         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2468         instead of '%zu'.
2469
2470 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2471
2472         * dwarf2read.h (dwarf2_section_info_def): Remove.
2473         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2474         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2475         std::vector<dwarf2_section_info>.
2476         (struct dwo_file) <~dwo_file>: Remove.
2477         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2478         types field.
2479         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2480         (dwarf2_read_debug_names): Likewise.
2481         (create_debug_types_hash_table): Change parameter type to
2482         array_view, adjust code accordingly.
2483         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2484         (partial_die_info::fixup): Likewise.
2485         (determine_prefix): Likewise.
2486         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2487
2488 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2489
2490         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2491         gdb_bfd_ref_ptr.
2492         <~dwo_file>: Remove call to gdb_bfd_unref.
2493         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2494         gdb_bfd_ref_ptr::get.
2495
2496 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2497
2498         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2499         type to htab_up.
2500         * dwarf2read.c (struct dwo_file): Initialize fields.
2501         <~dwo_file>: New.
2502         (free_dwo_file): Remove, move content to ~dwo_file.
2503         (struct dwo_file_deleter): Remove.
2504         (dwo_file_up>: Remove custom deleter.
2505         (free_dwo_files): Remove.
2506         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2507         dwo_files.
2508         (process_skeletonless_type_units): Call unique_ptr::get.
2509         (allocate_dwo_file_hash_table): Add deleter to created hash
2510         table.  Change return type to htab_up.
2511         (lookup_dwo_file_slot): Don't memset dwo_file, call
2512         unique_ptr::get.
2513         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2514         (create_dwo_unit_in_dwp_v2): Likewise.
2515         (open_and_init_dwo_file): Likewise.
2516         (free_dwo_file_from_slot): Remove.
2517
2518 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2519
2520         * dwarf2read.h (struct dwarf2_section_info) <readin,
2521         is_virtual>: Change type to bool.
2522         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2523         true instead of 1.
2524
2525 2019-06-19  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-data.h (tui_init_content_element): Don't declare.
2528
2529 2019-06-19  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-data.h (tui_init_win_info): Don't declare.
2532
2533 2019-06-19  Tom de Vries  <tdevries@suse.de>
2534
2535         * dwarf2read.h (abstract_to_concrete): Change type to
2536         std::unordered_map<sect_offset, std::vector<sect_offset>,
2537         gdb::hash_enum<sect_offset>>.
2538
2539 2019-06-19  Tom Tromey  <tromey@adacore.com>
2540
2541         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2542         EVAL_AVOID_SIDE_EFFECTS specially.
2543
2544 2019-06-19  Tom Tromey  <tromey@adacore.com>
2545
2546         * source-cache.c (highlighter): New global.
2547         (source_cache::get_source_lines): Create a highlighter on demand.
2548
2549 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * defs.h (deprecated_interactive_hook): Delete declaration.
2552         * interps.c (clear_interpreter_hooks): Remove use of
2553         deprecated_interactive_hook.
2554         * top.c (deprecated_interactive_hook): Delete definition.
2555         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2556
2557 2019-06-18  Tom de Vries  <tdevries@suse.de>
2558
2559         PR gdb/24515
2560         * dwarf2read.h (abstract_to_concrete): Change type from
2561         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2562         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2563         * dwarf2read.c (read_variable): Update.
2564         (dwarf2_fetch_die_loc_sect_off): Update.
2565
2566 2019-06-17  Tom de Vries  <tdevries@suse.de>
2567
2568         PR gdb/24617
2569         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2570         accessing parent[parent_len - 1].
2571
2572 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2573
2574         PR gdb/24364
2575         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2576         call dtrace_process_dof with NULL dof.
2577
2578 2019-06-16  Tom de Vries  <tdevries@suse.de>
2579
2580         PR gdb/24445
2581         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2582
2583 2019-06-16  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2586         (make_all_visible): Use address of member.
2587
2588 2019-06-16  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2591         (tui_free_window, free_content, free_content_elements): Remove
2592         unnecessary cast.
2593         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2594         cast.
2595         * tui/tui-regs.c (tui_show_register_group)
2596         (tui_display_registers_from, tui_display_reg_element_at_line):
2597         Remove unnecessary cast.
2598
2599 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * linux-nat.c (normal_mask): Delete.
2602         (_initialize_linux_nat): Don't initialise normal_mask.
2603
2604 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2605
2606         PR gdb/24445
2607         * dwarf-index-write.h (write_psymtabs_to_index): Add
2608         dwz_basename parameter.
2609         * dwarf-index-write.c (write_gdbindex): Move file writing to
2610         write_gdbindex_1.  Change return type void.
2611         (assert_file_size): Move up, remove filename parameter.
2612         (write_gdbindex_1): New function.
2613         (write_debug_names): Change return type to void, call
2614         assert_file_size.
2615         (struct index_wip_file): New struct.
2616         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2617         file logic to index_wip_file.  Write index for dwz file if
2618         needed.
2619         (save_gdb_index_command): Pass basename of dwz file, if present.
2620         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2621         build-id of dwz file, if present.
2622         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2623         (dwarf2_get_dwz_file): Likewise.
2624         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2625         (dwarf2_get_dwz_file): Likewise.
2626
2627 2019-06-16  Tom Tromey  <tom@tromey.com>
2628
2629         * coffread.c (process_coff_symbol): Use xstrdup.
2630         * value.c (create_internalvar): Use xstrdup.
2631
2632 2019-06-16  Tom Tromey  <tom@tromey.com>
2633
2634         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2635         * breakpoint.c (stopin_command, stopat_command)
2636         (until_break_command, decode_location_default): Remove unnecessary
2637         cast.
2638         * utils.c (subset_compare): Remove unnecessary cast.
2639         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2640         cast.
2641         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2642         cast.
2643         * infcmd.c (path_command): Remove unnecessary cast.
2644         * coffread.c (decode_type): Remove unnecessary cast.
2645         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2646         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2647         * tui/tui-stack.c (tui_show_locator_content)
2648         (tui_show_frame_info): Remove unnecessary cast.
2649         * tui/tui-win.c (tui_scroll_forward_command)
2650         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2651         (parse_scrolling_args): Remove unnecessary cast.
2652         * tui/tui-data.c (init_win_info, tui_del_window)
2653         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2654         (free_content_elements): Remove unnecessary cast.
2655         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2656         unnecessary cast.
2657         * tui/tui-source.c (tui_set_source_content)
2658         (tui_vertical_source_scroll): Remove unnecessary cast.
2659         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2660         cast.
2661         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2662         * tui/tui-regs.c (tui_display_registers_from)
2663         (tui_display_register): Remove unnecessary cast.
2664         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2665         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2666         (make_visible): Remove unnecessary cast.
2667         * tui/tui-winsource.c (tui_erase_source_content)
2668         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2669         unnecessary cast.
2670         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2671         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2672         * stabsread.c (read_type, read_array_type, read_range_type):
2673         Remove unnecessary cast.
2674         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2675         (parse_symbol, parse_type, upgrade_type, parse_external)
2676         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2677         unnecessary cast.
2678         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2679
2680 2019-06-16  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-data.c (tui_alloc_generic_win_info)
2683         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2684         checks.
2685
2686 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2687             Andrew Burgess  <andrew.burgess@embecosm.com>
2688
2689         * f-typeprint.c (f_print_type): Don't return early for not
2690         associated or not allocated types.
2691         (f_type_print_varspec_suffix): Add print_rank parameter and print
2692         ranks of array types in case they dangling.
2693         (f_type_print_base): Add print_rank parameter.
2694
2695 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2696
2697         * NEWS: Mention new MI commands.
2698         * break-catch-throw.c (enum exception_event_kind): Move to
2699         breakpoint.h.
2700         (print_mention_exception_catchpoint): Output text as a single
2701         message.
2702         (catch_exception_command_1): Rename to...
2703         (catch_exception_event): ...this, make non-static, update header
2704         command, and change some parameter types.
2705         (catch_catch_command): Update for changes to
2706         catch_exception_command_1.
2707         (catch_throw_command): Likewise.
2708         (catch_rethrow_command): Likewise.
2709         * breakpoint.c (enum exception_event_kind): Delete.
2710         * breakpoint.h (enum exception_event_kind): Moved here from
2711         break-catch-throw.c.
2712         (catch_exception_event): Declare.
2713         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2714         (mi_cmd_catch_throw): New function.
2715         (mi_cmd_catch_rethrow): New function.
2716         (mi_cmd_catch_catch): New function.
2717         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2718         'catch-catch' entries.
2719         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2720         (mi_cmd_catch_rethrow): Declare.
2721         (mi_cmd_catch_catch): Declare.
2722
2723 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2724
2725         * annotate.c (annotate_source_line): Change return type to void,
2726         update implementation to match.
2727         * annotate.h (annotate_source_line): Change return type to void,
2728         update header comment.
2729         * stack.c (print_frame_info): Don't change what frame information
2730         is printed based on whether annotations are on or not.
2731
2732 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2733
2734         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2735         (annotate_source): Make static.
2736         (annotate_source_line): Moved from source.c and renamed from
2737         identify_source_line.  Update the return type.
2738         * annotate.h (annotate_source): Delete declaration.
2739         (annotate_source_line): Declaration moved from source.h, and
2740         renamed from identify_source_line.  Return type updated.
2741         * source.c (identify_source_line): Moved to annotate.c and renamed
2742         to annotate_source_line.
2743         (info_line_command): Remove check of annotation_level.
2744         * source.h (identify_source_line): Move declaration to annotate.h
2745         and rename to annotate_source_line.
2746         * stack.c: Add 'annotate.h' include.
2747         (print_frame_info): Remove check of annotation_level before
2748         calling annotate_source_line.
2749
2750 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2751
2752         * source-cache.c (source_cache::get_plain_source_lines): Use
2753         open_source_file_with_line_charpos instead of just
2754         open_source_file, remove call to find_source_lines.
2755         (source_cache::get_source_lines): Likewise.
2756         * source.c (find_source_lines): Make static.
2757         (get_filename_and_charpos): Renamed into...
2758         (open_source_file_with_line_charpos): ..this along with changes to
2759         return a scoped_fd, and some other minor clean ups.
2760         (identify_source_line): Use open_source_file_with_line_charpos.
2761         (search_command_helper): Use open_source_file_with_line_charpos
2762         instead of just open_source_file, remove call to
2763         find_source_lines.
2764         * source.h (open_source_file_with_line_charpos): Declare new
2765         function.
2766         (find_source_lines): Delete declaration.
2767
2768 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2769
2770         * source.c (get_filename_and_charpos): Remove fullname
2771         parameter.
2772         (identify_source_line): Update call to get_filename_and_charpos.
2773
2774 2019-06-14  Tom Tromey  <tromey@adacore.com>
2775
2776         PR gdb/24502:
2777         * ui-style.h (skip_ansi_escape): Update comment.
2778         * ui-file.h (class no_terminal_escape_file): New class.
2779         * ui-file.c (no_terminal_escape_file::write)
2780         (no_terminal_escape_file::puts): New methods.
2781         * cli/cli-logging.c (handle_redirections): Use
2782         no_terminal_escape_file.
2783
2784 2019-06-14  Tom Tromey  <tromey@adacore.com>
2785
2786         * NEWS: Move convenience variable news above Python news.
2787
2788 2019-06-14  Tom Tromey  <tom@tromey.com>
2789
2790         * gnulib: Move directory to top-level.
2791         * configure.ac: Don't configure gnulib.
2792         * configure: Rebuild.
2793         * common/common-defs.h: Use new path to gnulib.
2794         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2795         (GNULIB_H): Remove.
2796         (INCGNU): Look in new gnulib location.
2797         (HFILES_NO_SRCDIR): Remove gnulib files.
2798         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2799         (generated_files): Remove GNULIB_H.
2800         ($(LIBGNU), all-lib): Remove targets.
2801         (distclean): Don't mention GNULIB_BUILDDIR.
2802         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2803
2804 2019-06-14  Tom Tromey  <tromey@adacore.com>
2805
2806         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2807         Warn if symbol file does not provide any symbols.
2808
2809 2019-06-14  Tom Tromey  <tromey@adacore.com>
2810
2811         * source.c (find_and_open_source): Respect basenames_may_differ.
2812
2813 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2814
2815         * annotate.c (annotate_breakpoints_invalid): Make use of
2816         scoped_restore_terminal_state.
2817         (annotate_frames_invalid): Likewise.
2818
2819 2019-06-14  Tom Tromey  <tromey@adacore.com>
2820
2821         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2822         allow assignment to an internalvar.
2823
2824 2019-06-14  Tom Tromey  <tromey@adacore.com>
2825
2826         * ada-lex.l: Allow "_" in attribute names.
2827
2828 2019-06-14  Tom Tromey  <tromey@adacore.com>
2829
2830         PR gdb/24653:
2831         * regcache.c (registers_changed): Don't call alloca.
2832         * top.c (execute_command): Don't call alloca.
2833
2834 2019-06-13  Pedro Alves  <palves@redhat.com>
2835
2836         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2837         'expression'.  When parsing an expression, error out if there's
2838         junk after "unlimited".
2839         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2840         (do_set_command): Adjust calls to is_unlimited_literal.
2841
2842 2019-06-13  Pedro Alves  <palves@redhat.com>
2843
2844         * compile/compile.c (make_compile_options_def_group): Add braces
2845         around array_view initializer.
2846         * thread.c (make_thread_apply_all_options_def_group)
2847         (make_thread_apply_all_options_def_group): Likewise.
2848
2849 2019-06-13  Pedro Alves  <palves@redhat.com>
2850
2851         * NEWS (New commands): Mention "maint test-options
2852         require-delimiter", "maint test-options unknown-is-error", "maint
2853         test-options unknown-is-operand" and "maint show
2854         test-options-completion-result".
2855         (New command options, command completion): New section.
2856         (Completion improvements): New section.
2857         Mention that you can abbreviate "unlimited".
2858
2859 2019-06-13  Pedro Alves  <palves@redhat.com>
2860
2861         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2862         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2863         * unittests/cli-utils-selftests.c (test_parse_flags)
2864         (test_parse_flags_qcs): Delete.
2865         (test_cli_utils): Don't call deleted functions.
2866
2867 2019-06-13  Pedro Alves  <palves@redhat.com>
2868
2869         * thread.c: Include "cli/cli-option.h".
2870         (tp_array_compar_ascending): Global.
2871         (tp_array_compar): Delete function.
2872         (tp_array_compar_ascending, tp_array_compar_descending): New
2873         functions.
2874         (ascending_option_def, qcs_flag_option_def)
2875         (thr_qcs_flags_option_defs)
2876         (make_thread_apply_all_options_def_group)
2877         (make_thread_apply_options_def_group): New.
2878         (thread_apply_all_command): Use gdb::option::process_options.
2879         (thread_apply_command_completer)
2880         (thread_apply_all_command_completer): New.
2881         (thread_apply_command): Use gdb::option::process_options.
2882         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2883         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2884         to generate help text of "thread apply".  Adjust "taas"'s help.
2885         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2886         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2887
2888 2019-06-13  Pedro Alves  <palves@redhat.com>
2889
2890         * thread.c (thread_apply_command): Check for invalid TID with
2891         isdigit instead of !isalpha.
2892
2893 2019-06-13  Pedro Alves  <palves@redhat.com>
2894
2895         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2896         (validate_flags_qcs): New.
2897         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2898         (validate_flags_qcs): Declare.
2899         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2900         (make_frame_apply_options_def_group): New.
2901         (frame_apply_command_count): Process options with
2902         gdb::option::process_options.
2903         (frame_apply_completer): New.
2904         (frame_apply_level_completer, frame_apply_all_completer)
2905         (frame_apply_completer): New.
2906         (_initialize_stack): Update help of "frame apply", "frame apply
2907         level", "frame apply all" and "faas" to mention supported options
2908         and install command completers.
2909         * stack.h (frame_apply_all_completer): Declare.
2910         * thread.c: Include "stack.h".
2911         (tfaas_command): Add "--".
2912         (_initialize_thread): Update help "tfaas" to mention supported
2913         options and install command completer.
2914
2915 2019-06-13  Pedro Alves  <palves@redhat.com>
2916
2917         * completer.c (complete_nested_command_line): New.
2918         (gdb_completion_word_break_characters_throw): Add assertion.
2919         * completer.h (complete_nested_command_line): Declare.
2920
2921 2019-06-13  Pedro Alves  <palves@redhat.com>
2922
2923         * stack.c (parse_backtrace_qualifiers): New.
2924         (backtrace_command): Use it.
2925         (backtrace_command_completer): Complete on qualifiers.
2926
2927 2019-06-13  Pedro Alves  <palves@redhat.com>
2928
2929         * frame.c: Include "cli/cli-option.h.
2930         (user_set_backtrace_options): New.
2931         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2932         Delete.
2933         (get_prev_frame): Adjust.
2934         (boolean_option_def, uinteger_option_def)
2935         (set_backtrace_option_defs): New.
2936         (_initialize_frame): Adjust and use
2937         gdb::option::add_setshow_cmds_for_options to install "set
2938         backtrace past-main" and "set backtrace past-entry".
2939         * frame.h: Include "cli/cli-option.h".
2940         (struct frame_print_options): Forward declare.
2941         (print_frame_arguments_all, print_frame_arguments_scalars)
2942         (print_frame_arguments_none): Declare.
2943         (print_entry_values): Delete declaration.
2944         (struct frame_print_options, user_frame_print_options): New.
2945         (struct set_backtrace_options): New.
2946         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2947         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2948         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2949         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2950         (list_args_or_locals): Add frame_print_options parameter.
2951         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2952         * python/py-framefilter.c (enumerate_args): Pass down
2953         USER_FRAME_PRINT_OPTIONS.
2954         * stack.c: Include "cli/cli-option.h".
2955         (print_frame_arguments_all, print_frame_arguments_scalars)
2956         (print_frame_arguments_none): Declare.
2957         (print_raw_frame_arguments, print_entry_values): Delete.
2958         (user_frame_print_options): New.
2959         (boolean_option_def, enum_option_def, frame_print_option_defs):
2960         New.
2961         (struct backtrace_cmd_options): New.
2962         (bt_flag_option_def): New.
2963         (backtrace_command_option_defs): New.
2964         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2965         (print_frame_arg, read_frame_arg, print_frame_args)
2966         (print_frame_info, print_frame): Add frame_print_options parameter
2967         and use it.
2968         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2969         (backtrace_command_1): Add frame_print_options and
2970         backtrace_cmd_options parameters and use them.
2971         (make_backtrace_options_def_group): New.
2972         (backtrace_command): Process command options with
2973         gdb::option::process_options.
2974         (backtrace_command_completer): New.
2975         (_initialize_stack): Extend "backtrace"'s help to mention
2976         supported options.  Install completer for "backtrace".
2977         Install some settings commands with add_setshow_cmds_for_options.
2978
2979 2019-06-13  Pedro Alves  <palves@redhat.com>
2980
2981         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2982         and that "set/show print raw frame-arguments" are now deprecated.
2983
2984         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2985         command.
2986         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2987         * stack.c (_initialize_stack): Install "set/show print
2988         raw-frame-arguments", and deprecate "set/show print raw
2989         frame-arguments".
2990         * valprint.c (_initialize_valprint): Deprecate "set/show print
2991         raw".
2992
2993 2019-06-13  Pedro Alves  <palves@redhat.com>
2994
2995         * compile/compile.c (struct compile_options): New.
2996         (compile_flag_option_def, compile_command_option_defs)
2997         (make_compile_options_def_group): New.
2998         (compile_file_command): Handle options with
2999         gdb::option::process_options.
3000         (compile_file_command_completer): New function.
3001         (compile_code_command): Handle options with
3002         gdb::option::process_options.
3003         (compile_code_command_completer): New function.
3004         (_initialize_compiler): Install completers for "compile code" and
3005         "compile file".  Mention available options in "compile code" and
3006         "compile code"'s help.
3007         * completer.c (advance_to_completion_word): New, factored out from
3008         ...
3009         (advance_to_expression_complete_word_point): ... this.
3010         (advance_to_filename_complete_word_point): New.
3011         * completer.h (advance_to_filename_complete_word_point): New
3012         declaration.
3013
3014 2019-06-13  Pedro Alves  <palves@redhat.com>
3015
3016         * compile/compile.c: Include "cli/cli-option.h".
3017         (compile_print_value): Scope data pointer is now a
3018         value_print_options pointer; adjust.
3019         (compile_print_command): Process options.  Scope data pointer is
3020         now a value_print_options pointer; adjust.
3021         (_initialize_compile): Update "compile print"'s help to include
3022         supported options.  Install a completer for "compile print".
3023         * cp-valprint.c (show_vtblprint, show_objectprint)
3024         (show_static_field_print): Delete.
3025         (_initialize_cp_valprint): Don't install "set print
3026         static-members", "set print vtbl", "set print object" here.
3027         * printcmd.c: Include "cli/cli-option.h" and
3028         "common/gdb_optional.h".
3029         (print_command_parse_format): Rework to fill in a
3030         value_print_options instead of a format_data.
3031         (print_value): Change parameter type from format_data pointer to
3032         value_print_options reference.  Adjust.
3033         (print_command_1): Process options.  Adjust to pass down a
3034         value_print_options.
3035         (print_command_completer): New.
3036         (_initialize_printcmd): Install print_command_completer as
3037         handle_brkchars completer for the "print" command.  Update
3038         "print"'s help to include supported options.
3039         * valprint.c: Include "cli/cli-option.h".
3040         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3041         here from cp-valprint.c.
3042         (boolean_option_def, uinteger_option_def)
3043         (value_print_option_defs, make_value_print_options_def_group):
3044         New.  Use gdb::option::add_setshow_cmds_for_options to install
3045         "set print elements", "set print null-stop", "set print repeats",
3046         "set print pretty", "set print union", "set print array", "set
3047         print address", "set print symbol", "set print array-indexes".
3048         * valprint.h: Include <string> and "cli/cli-option.h".
3049         (make_value_print_options_def_group): Declare.
3050         (print_value): Change parameter type from format_data pointer to
3051         value_print_options reference.
3052         (print_command_completer): Declare.
3053
3054 2019-06-13  Pedro Alves  <palves@redhat.com>
3055
3056         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3057         (COMMON_SFILES): Add maint-test-settings.c.
3058         * cli/cli-decode.c (boolean_enums): New global, factored out from
3059         ...
3060         (add_setshow_boolean_cmd): ... here.
3061         * cli/cli-decode.h (boolean_enums): Declare.
3062         * cli/cli-option.c: New file.
3063         * cli/cli-option.h: New file.
3064         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3065         factored out from ...
3066         (parse_cli_boolean_value(const char *)): ... this.
3067         (is_unlimited_literal): Change parameter type to pointer to
3068         pointer.  Adjust and advance ARG pointer.
3069         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3070         (parse_cli_var_enum): New, factored out from ...
3071         (do_set_command): ... this.  Adjust.
3072         * cli/cli-setshow.h (parse_cli_boolean_value)
3073         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3074         (parse_cli_var_enum): Declare.
3075         * cli/cli-utils.c: Include "cli/cli-option.h".
3076         (get_ulongest): New.
3077         * cli/cli-utils.h (get_ulongest): Declare.
3078         (check_for_argument): New overloads.
3079         * maint-test-options.c: New file.
3080
3081 2019-06-13  Pedro Alves  <palves@redhat.com>
3082
3083         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3084         parse a range if "-" is at the end of the string.
3085
3086 2019-06-13  Pedro Alves  <palves@redhat.com>
3087
3088         * cli/cli-setshow.c (parse_auto_binary_operation)
3089         (parse_cli_boolean_value): Don't allow "o".
3090
3091 2019-06-13  Pedro Alves  <palves@redhat.com>
3092
3093         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3094         * NEWS: Mention maint test-settings KIND.
3095         * maint-test-settings.c: New file.
3096
3097 2019-06-13  Pedro Alves  <palves@redhat.com>
3098
3099         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3100         completer.
3101         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3102         "set" completers.
3103
3104 2019-06-13  Pedro Alves  <palves@redhat.com>
3105
3106         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3107         after item.
3108
3109 2019-06-13  Pedro Alves  <palves@redhat.com>
3110
3111         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3112
3113 2019-06-13  Pedro Alves <palves@redhat.com>
3114
3115         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3116         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3117         call.
3118         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3119         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3120         calls.
3121         (check_for_argument): Skip spaces after argument.
3122
3123 2019-06-13  Pedro Alves  <palves@redhat.com>
3124
3125         * thread.c (thread_apply_command): Adjust TID parsing.
3126         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3127         detected before end of string.
3128         (tid_is_in_list): Error out if LIST is invalid.
3129
3130 2019-06-13  Pedro Alves  <palves@redhat.com>
3131
3132         * completer.c (complete_line_internal_1): Rewind completion word
3133         point.
3134         (completion_tracker::advance_custom_word_point_by): Change
3135         parameter type to int.
3136         * completer.h (completion_tracker::advance_custom_word_point_by):
3137         Likewise.
3138
3139 2019-06-13  Pedro Alves  <palves@redhat.com>
3140
3141         * completer.c (advance_to_completion_word): Handle delimiters.
3142
3143 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3144
3145         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3146
3147 2019-06-11  Tom Tromey  <tom@tromey.com>
3148
3149         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3150         (xmalloc_failed): Move to alloc.c.
3151         * alloc.c: New file.
3152         * Makefile.in (COMMON_SFILES): Add alloc.c.
3153
3154 2019-06-11  Tom Tromey  <tom@tromey.com>
3155
3156         * nat/linux-waitpid.c: Don't include server.h.
3157         (linux_debug): Remove.
3158         (my_waitpid): Update.
3159
3160 2019-06-11  Tom Tromey  <tromey@adacore.com>
3161
3162         * infcall.c (_initialize_infcall): Remove trailing newline from
3163         help.
3164         * user-regs.c (_initialize_user_regs): Remove trailing newline
3165         from help.
3166         * typeprint.c (_initialize_typeprint): Remove trailing newline
3167         from help.
3168         * reverse.c (_initialize_reverse): Remove trailing newlines from
3169         help.
3170         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3171         from help.
3172         * language.c (add_set_language_command): Remove trailing newline
3173         from help.
3174         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3175         help.
3176         * disasm.c (_initialize_disasm): Remove trailing newline from
3177         help.
3178         * top.c (init_main): Remove trailing newline from help.
3179         * interps.c (_initialize_interpreter): Remove trailing newline
3180         from help.
3181         * btrace.c (_initialize_btrace): Remove trailing newlines from
3182         help.
3183         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3184         from help.
3185         * python/python.c (_initialize_python): Remove trailing newline
3186         from help.
3187         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3188         help.
3189         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3190         from help.  Reformat some text.
3191         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3192         from help.
3193         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3194         newline from help.
3195
3196 2019-06-11  Tom Tromey  <tromey@adacore.com>
3197
3198         * darwin-nat.c (darwin_decode_exception_message)
3199         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3200
3201 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3202
3203         * valops.c (value_slice): Check for not allocated or not
3204         associated values.
3205
3206 2019-06-10  Tom de Vries  <tdevries@suse.de>
3207
3208         PR gdb/24618
3209         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3210         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3211         invalid.
3212
3213 2019-06-10  Tom de Vries  <tdevries@suse.de>
3214
3215         PR gdb/24611
3216         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3217         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3218
3219 2019-06-10  Tom de Vries  <tdevries@suse.de>
3220
3221         PR symtab/24545
3222         * symtab.c (struct demangled_name_entry): Add language field.
3223         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3224         static minimal symbol".  Set and use language field.
3225
3226 2019-06-10  Tom Tromey  <tromey@adacore.com>
3227
3228         * ada-lang.c (_initialize_ada_language): Update help text.
3229
3230 2019-06-10  Tom Tromey  <tromey@adacore.com>
3231
3232         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3233         with a newline.
3234         * guile/guile.c (handle_boot_error): Don't end warning with a
3235         newline.
3236         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3237         warning with a newline.
3238         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3239         newline.
3240         (s12z_frame_cache): Likewise.
3241         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3242         a newline.
3243         * solib-svr4.c (disable_probes_interface): Don't end warning with
3244         a newline.
3245         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3246         newline.
3247         * python/python.c (do_finish_initialization): Don't end warning
3248         with a newline.
3249
3250 2019-06-10  Tom Tromey  <tom@tromey.com>
3251
3252         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3253         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3254         gdbpy_enter.
3255
3256 2019-06-10  Tom Tromey  <tromey@adacore.com>
3257
3258         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3259         data.
3260         (elf_new_init): Don't call stabsread_new_init.
3261         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3262         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3263         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3264
3265 2019-06-10  Tom de Vries  <tdevries@suse.de>
3266
3267         PR symtab/16264
3268         PR symtab/24517
3269         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3270
3271 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3272
3273         * source.c (find_and_open_source): Also rewrite relative file
3274         names.
3275
3276 2019-04-26  Amos Bird  <amosbird@gmail.com>
3277
3278         * annotate.c (annotate_thread_exited): Add "thread-exited"
3279         annotation.
3280
3281 2019-06-06  Tom Tromey  <tromey@adacore.com>
3282
3283         * maint.h (class scoped_command_stats): Use
3284         DISABLE_COPY_AND_ASSIGN.
3285         <print_time>: New method.
3286         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3287         print_time.
3288         (scoped_command_stats::print_time): New method.
3289
3290 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3291
3292         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3293         instructions of lengths 6 or 8 bytes.
3294
3295 2019-06-04  Pedro Alves  <palves@redhat.com>
3296
3297         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3298
3299         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3300         * breakpoint.c (condition_completer): Likewise.
3301         * cli/cli-dump.c (scan_expression): Likewise.
3302         * common/filestuff.c (mkdir_recursive): Likewise.
3303         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3304         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3305         (gdb_abspath): Likewise.
3306         * compile/compile-cplus-types.c
3307         (compile_cplus_instance::decl_name): Likewise.
3308         * completer.c (complete_explicit_location):
3309         (signal_completer, reg_or_group_completer_1): Likewise.
3310         * cp-support.c (cp_remove_params_if_any): Likewise.
3311         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3312         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3313         * infcmd.c (strip_bg_char): Likewise.
3314         * linespec.c (copy_token_string): Likewise.
3315         * mi/mi-main.c (output_cores): Likewise.
3316         * psymtab.c (psymtab_search_name):
3317         * symfile.c (test_set_ext_lang_command): Likewise.
3318         * target.c (target_fileio_read_stralloc): Likewise.
3319         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3320         * value.c (complete_internalvar): Likewise.
3321
3322 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3323
3324         Add objfile property to gdb.Type.
3325         * NEWS: Mention Python API addition.
3326         * python/py-type.c (typy_get_objfile): New method.
3327
3328 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3329
3330         * NEWS: Mention the new set|show style [title|highlight].
3331         Mention changes to "show style", "help" and "apropos".
3332
3333 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3334
3335         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3336         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3337         instead of print_help_for_command.
3338         (print_doc_of_command): New function.
3339         (help_list): Add 'apropos -v word' suggestion.
3340         (print_help_for_command): Style the command name using title style.
3341         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3342         (_initialize_cli_cmds): Describe -v in apropos_command help.
3343
3344 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3345
3346         * cli/cli-style.h (cli_style_option): Add name in constructor,
3347         add m_name class member, add constructor with intensity,
3348         add name class function.
3349         (cli_style_option::add_setshow_commands): Remove name argument.
3350         (highlight_style, title_style): New styles.
3351         * cli/cli-style.c (do_show): New function that shows a style
3352         characteristic styling the style name with itself.
3353         (set_style_name): New function.
3354         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3355         Update all callers according to the changes in cli/cli-style.h.
3356         * utils.h (fputs_highlighted): New function.
3357         * utils.c (fputs_highlighted): Likewise.
3358
3359 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3360
3361         * NEWS: Mention new pipe command and new convenience variables.
3362
3363 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3364
3365         * cli/cli-cmds.c (pipe_command): New function.
3366         (_initialize_cli_cmds): Call add_com for pipe_command.
3367         Define | as an alias for pipe.
3368         (exit_status_set_internal_vars): New function.
3369         (shell_escape): Call exit_status_set_internal_vars.
3370         cli/cli-decode.c (find_command_name_length): Recognize | as
3371         a single character command.
3372
3373 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3374
3375         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3376         top.c (execute_command_to_ui_file): New function, mostly a copy
3377         of execute_command_to_string.
3378         (execute_command_to_string): Implement by calling
3379         execute_command_to_ui_file.
3380
3381 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3382
3383         * top.h (saved_command_line): Remove declaration.
3384         * top.c (previous_saved_command_line, previous_repeat_arguments):
3385         New variables.
3386         (saved_command_line): Make static, define together with other
3387         'repeat variables'.
3388         (dont_repeat): Clear repeat_arguments.
3389         (repeat_previous, get_saved_command_line, save_command_line):
3390         New functions.
3391         (gdb_init): Initialize saved_command_line
3392         and previous_saved_command_line.
3393         * main.c (captured_main_1): Remove saved_command_line initialization.
3394         * event-top.c (handle_line_of_input): Update to use
3395         the new 'repeat' related functions instead of direct access to
3396         saved_command_line.
3397         * command.h (repeat_previous, get_saved_command_line,
3398         save_command_line): New declarations.
3399         (dont_repeat): Add comment.
3400
3401 2019-05-30  Tom Tromey  <tromey@adacore.com>
3402
3403         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3404         Fix comment.
3405         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3406
3407 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3408
3409         PR cli/24587
3410         * completer.c (complete): Initialize variable word.
3411
3412 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3413
3414         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3415         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3416         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3417         'body' is NULL to the outter 'if', protecting the '!is_define'
3418         situation as well.
3419
3420 2019-05-29  Tom Tromey  <tromey@adacore.com>
3421
3422         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3423         (dwarf_unknown): New function.
3424         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3425         (dwarf_type_encoding_name): Use dwarf_unknown.
3426
3427 2019-05-29  Tom Tromey  <tromey@adacore.com>
3428
3429         PR c++/20020:
3430         * cp-valprint.c (cp_print_value_fields): Call
3431         cp_print_static_field inside "try".
3432
3433 2019-05-29  Tom Tromey  <tromey@adacore.com>
3434
3435         * inflow.c (struct terminal_info): Add default operator=.
3436         * configure: Rebuild.
3437         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3438         -Wdeprecated-copy-dtor, -Wredundant-move.
3439
3440 2019-05-29  Tom Tromey  <tromey@adacore.com>
3441
3442         * NEWS: Add entry.
3443         * infcmd.c (print_return_value_1): Handle finish_print
3444         option.
3445         (show_print_finish): New function.
3446         (_initialize_infcmd): Add "set/show print finish" commands.
3447         * valprint.c (user_print_options): Initialize new member.
3448         * valprint.h (struct value_print_options) <finish_print>: New
3449         member.
3450
3451 2019-05-28  Tom Tromey  <tromey@adacore.com>
3452
3453         * ada-lang.c (ada_remove_Xbn_suffix)
3454         (find_old_style_renaming_symbol)
3455         (parse_old_style_renaming): Remove.
3456         (ada_find_renaming_symbol): Don't call
3457         find_old_style_renaming_symbol.
3458         (ada_is_renaming_symbol): Rename from
3459         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3460         bool.  Now static.
3461         (ada_read_var_value): Update and simplify.
3462         * ada-exp.y (write_var_or_type): Remove old code.
3463
3464 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3465
3466         * event-top.c: Remove include comment.
3467         * inflow.c (class scoped_ignore_sigttou): Move from here...
3468         * inflow.h (class scoped_ignore_sigttou): ...to here.
3469         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3470         * top.c:  Remove include comment.
3471
3472 2019-05-27  Tom Tromey  <tom@tromey.com>
3473
3474         * NEWS: Fix typo.
3475
3476 2019-05-22  Tom Tromey  <tromey@adacore.com>
3477
3478         * target.c (target_follow_exec): Constify parameter.
3479         * target-delegates.c: Rebuild.
3480         * remote.c (remote_target::follow_exec): Constify parameter.
3481         * infrun.c (follow_exec): Constify parameter.
3482         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3483         (target_follow_exec): Likewise.
3484
3485 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3486
3487         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3488         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3489
3490 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3491
3492         * NEWS: Add debugredirect and testsuite sections.
3493
3494 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3495
3496         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3497         target descriptions using exclusively floating point register name
3498         aliases.
3499
3500 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3501
3502         PR gdb/18644:
3503         * f-lang.c (build_fortran_types): Handle the case where
3504         gdbarch_floatformat_for_type returns a nullptr.
3505
3506 2019-05-21  Tom de Vries  <tdevries@suse.de>
3507
3508         PR cli/24587
3509         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3510
3511 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         PR gdb/18644:
3514         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3515         16-byte floats.
3516         * i386-tdep.c (i386_floatformat_for_type): Use
3517         floatformats_ia64_quad for the 16-byte floating point component
3518         within a fortran 32-byte complex number.
3519
3520 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3521
3522         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3523         delete default constructor.
3524         (find_partial_die): Update to return const struct.
3525         (partial_die_parent_scope): Move variable declaration into scope
3526         of its use and change its type to auto.
3527         (guess_partial_die_structure_name): Likewise.
3528         (partial_die_info::fixup): Likewise.
3529
3530 2019-05-17  Tom Tromey  <tromey@adacore.com>
3531
3532         * source.c (find_and_open_source): Remove cast.
3533
3534 2019-05-17  Tom Tromey  <tromey@adacore.com>
3535
3536         * annotate.c (annotate_source): Make "filename" const.
3537         * annotate.h (annotate_source): Use const.
3538
3539 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3540
3541         * disasm.c (set_disassembler_options): Send errors to stderr.
3542
3543 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3544
3545         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3546         (cli_interp_base::set_logging): Check debug_redirect.
3547         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3548         * cli/cli-logging.c (debug_redirect): Add static variable.
3549         (pop_output_files): Add default param.
3550         (handle_redirections): Print debug setting.
3551         (show_logging_command): Likewise.
3552         (_initialize_cli_logging): Add debugredirect command.
3553         * interps.c (current_interp_set_logging): Add debug_redirect
3554         parameter.
3555         * interps.h (set_logging): Add debug_redirect parameter.
3556         (current_interp_set_logging): Likewise.
3557         * mi/mi-common.h: Likewise.
3558         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3559
3560 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3561             Tom Tromey  <tromey@adacore.com>
3562
3563         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3564         directly.
3565         * cli/cli-interp.h (make_logging_output): Remove declaration.
3566         * cli/cli-logging.c (make_logging_output): Remove function.
3567         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3568         directly.
3569         * ui-file.c (tee_file::tee_file): Remove bools.
3570         (tee_file::~tee_file): Remove deletes.
3571         * ui-file.h (tee_file): Remove bools.
3572
3573 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3574
3575         * mi/mi-cmds.h (mi_cmd_complete): New function.
3576         * mi/mi-main.c (mi_cmd_complete): Likewise.
3577         * mi/mi-cmds.c: Define new MI command -complete.
3578         * NEWS: Mention new -complete command.
3579
3580 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3581
3582         * completer.h (complete): New function.
3583         * completer.c (complete): Likewise.
3584         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3585         function defined in completer.h.
3586
3587 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3588
3589         * MAINTAINERS (Write After Approval): Add myself.
3590
3591 2019-05-17  Tom de Vries  <tdevries@suse.de>
3592
3593         PR gdb/24094
3594         * dwarf2read.c (struct cu_partial_die_info): New struct.
3595         (find_partial_die): Return cu_partial_die_info.
3596         (partial_die_parent_scope, guess_partial_die_structure_name)
3597         (partial_die_info::fixup): Handle new return type of find_partial_die.
3598
3599 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3600
3601         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3602         "std::string", simplifying the algorithm.
3603
3604 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3605
3606         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3607         (stap_static_probe_ops::get_probes): Likewise.
3608
3609 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3610
3611         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3612         '-')" and "else if".
3613         (stap_parse_single_operand): Join checks for
3614         "gdbarch_stap_parse_special_token_p" and
3615         "gdbarch_stap_parse_special_token" in the same "if" statement.
3616         Invert check when verifying for operation on register
3617         displacement.
3618
3619 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3620
3621         * stap-probe.c (stap_get_opcode): Update comment.
3622         (stap_get_expected_argument_type): Likewise.
3623         (handle_stap_probe): Likewise.
3624
3625 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3626
3627         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3628         return type to 'bool'.  Adjust comment.  Use 'bool' when
3629         appropriate.
3630         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3631         * stap-probe.c (stap_parse_argument_1): Likewise.
3632         (stap_is_operator): Likewise.
3633         (stap_is_generic_prefix): Likewise.
3634         (stap_is_register_prefix): Likewise.
3635         (stap_is_register_indirection_prefix): Likewise.
3636         (stap_is_integer_prefix): Likewise.
3637         (stap_generic_check_suffix): Likewise.
3638         (stap_check_integer_suffix): Likewise.
3639         (stap_check_register_suffix): Likewise.
3640         (stap_check_register_indirection_suffix): Likewise.
3641         (stap_parse_register_operand): Likewise.
3642         (stap_parse_single_operand): Likewise.
3643         (stap_parse_argument_1): Likewise.
3644         (stap_probe::get_argument_count): Likewise.
3645         (stap_is_operator): Likewise.
3646
3647 2019-05-16  Tom Tromey  <tromey@adacore.com>
3648
3649         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3650         keyword to foreach.
3651
3652 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3653
3654         * linux-thread-db.c (try_thread_db_load_1): Change return type
3655         to bool.
3656         (try_thread_db_load): Likewise.
3657         (try_thread_db_load_from_pdir_1): Likewise.
3658         (try_thread_db_load_from_pdir): Likewise.
3659         (try_thread_db_load_from_sdir): Likewise.
3660         (try_thread_db_load_from_dir): Likewise.
3661         (thread_db_load_search): Likewise.
3662         (has_libpthread): Likewise.
3663         (thread_db_load): Likewise.
3664
3665 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3666
3667         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3668         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3669         NULL, and complain/return if that's the case.
3670
3671 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3672
3673         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3674         (advance, posn, abstract_read_memory): New functions.
3675         [struct mem_read_abstraction]: New struct.
3676         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3677
3678 2019-05-14  Tom Tromey  <tromey@adacore.com>
3679
3680         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3681         value is not lval_memory.
3682
3683 2019-05-14  Tom Tromey  <tromey@adacore.com>
3684
3685         * solib.c (info_sharedlibrary_command): Style the file name.
3686
3687 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3688
3689         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3690         (aarch64_vnv_type): Likewise.
3691         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3692         * common/tdesc.c: Likewise.
3693         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3694         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3695         * features/aarch64-fpu.xml: Add ieee half view.
3696         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3697         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3698         * gdbtypes.h (struct builtin_type): Likewise.
3699         (struct objfile_type): Likewise.
3700
3701 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3702
3703         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3704         typo.
3705         * location.h (string_to_event_location): Likewise.
3706
3707 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3708
3709         GDB 8.3 released.
3710
3711 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3712
3713         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3714         New variable declaration.
3715         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3716         New variable.
3717         (print_one_breakpoint): Use ui_out::test_flags and new global
3718         variable to compute use_fixed_output.
3719         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3720         Remove.
3721         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3722         (mi_multi_location_breakpoint_output_fixed): Remove.
3723         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3724         new variable.
3725         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3726         fix_multi_location_breakpoint_output flag if version >= 3.
3727         * ui-out.h (enum ui_out_flag)
3728         <fix_multi_location_breakpoint_output>: New enumerator.
3729
3730 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3731
3732         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3733
3734 2019-05-10  Tom Tromey  <tromey@adacore.com>
3735
3736         * ada-lang.c (catch_ada_completer): New function.
3737         (_initialize_ada_language): Use it.
3738
3739 2019-05-10  Tom Tromey  <tromey@adacore.com>
3740
3741         * thread.c (print_thread_info): Make "requested_threads" const.
3742         * gdbthread.h (print_thread_info): Make "requested_threads"
3743         const.
3744         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3745         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3746
3747 2019-05-08  Tom Tromey  <tom@tromey.com>
3748
3749         * gdbtypes.c (objfile_type_data): Change type.
3750         (objfile_type, _initialize_gdbtypes): Update.
3751
3752 2019-05-08  Tom Tromey  <tom@tromey.com>
3753
3754         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3755         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3756         (_initialize_dwarf2_frame): Update.
3757
3758 2019-05-08  Tom Tromey  <tom@tromey.com>
3759
3760         * objc-lang.c (objc_objfile_data): Change type.
3761         (find_methods): Update.
3762         (_initialize_objc_lang): Remove.
3763
3764 2019-05-08  Tom Tromey  <tom@tromey.com>
3765
3766         * stabsread.c (rs6000_builtin_type_data): Change type.
3767         (rs6000_builtin_type, _initialize_stabsread): Update.
3768
3769 2019-05-08  Tom Tromey  <tom@tromey.com>
3770
3771         * mips-tdep.c (mips_pdr_data): Remove.
3772         (_initialize_mips_tdep): Update.
3773
3774 2019-05-08  Tom Tromey  <tom@tromey.com>
3775
3776         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3777         (hppa_init_objfile_priv_data, read_unwind_info)
3778         (find_unwind_entry, _initialize_hppa_tdep): Update.
3779
3780 2019-05-08  Tom Tromey  <tom@tromey.com>
3781
3782         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3783         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3784         on obstack.
3785         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3786
3787 2019-05-08  Tom Tromey  <tom@tromey.com>
3788
3789         * mdebugread.c (basic_type_data): Change type.
3790         (basic_type, _initialize_mdebugread): Update.
3791
3792 2019-05-08  Tom Tromey  <tom@tromey.com>
3793
3794         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3795
3796 2019-05-08  Tom Tromey  <tom@tromey.com>
3797
3798         * nto-tdep.c (nto_inferior_data_reg): Change type.
3799         (nto_inferior_data): Update.
3800         (nto_inferior_data_cleanup, nto_new_inferior_data)
3801         (_initialize_nto_tdep): Remove.
3802         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3803
3804 2019-05-08  Tom Tromey  <tom@tromey.com>
3805
3806         * ada-lang.c (struct ada_inferior_data): Add initializers.
3807         (ada_inferior_data): Change type.
3808         (ada_inferior_data_cleanup): Remove.
3809         (get_ada_inferior_data, ada_inferior_exit)
3810         (struct ada_pspace_data): Add initializers, destructor.
3811         (ada_pspace_data_handle): Change type.
3812         (get_ada_pspace_data): Update.
3813         (ada_pspace_data_cleanup): Remove.
3814
3815 2019-05-08  Tom Tromey  <tom@tromey.com>
3816
3817         * coffread.c (struct coff_symfile_info): Add initializers.
3818         (coff_objfile_data_key): Move lower.  Change type.
3819         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3820         Update.
3821         (coff_free_info): Remove.
3822
3823 2019-05-08  Tom Tromey  <tom@tromey.com>
3824
3825         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3826         (fbsd_pspace_data_handle): Move lower.  Change type.
3827         (get_fbsd_pspace_data): Update.
3828         (fbsd_pspace_data_cleanup): Remove.
3829         (_initialize_fbsd_tdep): Update.
3830
3831 2019-05-08  Tom Tromey  <tom@tromey.com>
3832
3833         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3834         (get_ada_tasks_pspace_data): Update.
3835         (ada_tasks_pspace_data_cleanup): Remove.
3836         (_initialize_tasks): Update.
3837         (ada_tasks_inferior_data_handle): Change type.
3838         (get_ada_tasks_inferior_data): Update.
3839         (ada_tasks_inferior_data_cleanup): Remove.
3840         (struct ada_tasks_pspace_data): Add initializers.
3841
3842 2019-05-08  Tom Tromey  <tom@tromey.com>
3843
3844         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3845         * symfile-debug.c (debug_sym_get_probes): Change type.
3846         * stap-probe.c (handle_stap_probe):
3847         (stap_static_probe_ops::get_probes): Change type.
3848         * probe.h (class static_probe_ops) <get_probes>: Change type.
3849         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3850         (parse_probes_in_pspace): Update.
3851         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3852         Update.
3853         (any_static_probe_ops::get_probes): Change type.
3854         * elfread.c (elfread_data): New typedef.
3855         (probe_key): Change type.
3856         (elf_get_probes): Likewise.  Update.
3857         (probe_key_free): Remove.
3858         (_initialize_elfread): Update.
3859         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3860         Change type.
3861         (dtrace_process_dof_probe, dtrace_process_dof)
3862         (dtrace_static_probe_ops::get_probe): Change type.
3863
3864 2019-05-08  Tom Tromey  <tom@tromey.com>
3865
3866         * xcoffread.c (struct xcoff_symfile_info): Rename from
3867         coff_symfile_info.  Add initializers.
3868         (xcoff_objfile_data_key): Move lower.  Change type.
3869         (XCOFF_DATA): Rewrite.
3870         (xcoff_free_info): Remove.
3871         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3872         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3873         (xcoff_initial_scan): Update.
3874
3875 2019-05-08  Tom Tromey  <tom@tromey.com>
3876
3877         * solib-svr4.c (struct svr4_info): Add initializers and
3878         destructor.
3879         <probes_table>: Now an htab_up.
3880         (solib_svr4_pspace_data): Change type.
3881         (free_probes_table): Simplify.
3882         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3883         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3884         (probes_table_remove_objfile_probes, register_solib_event_probe)
3885         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3886         (_initialize_svr4_solib): Update.
3887
3888 2019-05-08  Tom Tromey  <tom@tromey.com>
3889
3890         * remote.c (remote_pspace_data): Change type.
3891         (remote_pspace_data_cleanup): Remove.
3892         (get_remote_exec_file, set_pspace_remote_exec_file)
3893         (_initialize_remote): Update.
3894
3895 2019-05-08  Tom Tromey  <tom@tromey.com>
3896
3897         * breakpoint.c (breakpoint_objfile_key): Change type.
3898         (get_breakpoint_objfile_data): Update.
3899         (free_breakpoint_objfile_data): Remove.
3900         (_initialize_breakpoint): Update.
3901
3902 2019-05-08  Tom Tromey  <tom@tromey.com>
3903
3904         * linux-tdep.c (struct linux_info): Add initializers.
3905         (linux_inferior_data): Move.  Change type.
3906         (invalidate_linux_cache_inf): Update.
3907         (linux_inferior_data_cleanup): Remove.
3908         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3909
3910 2019-05-08  Tom Tromey  <tom@tromey.com>
3911
3912         * auxv.c (auxv_inferior_data): Move.  Change type.
3913         (auxv_inferior_data_cleanup): Remove.
3914         (invalidate_auxv_cache_inf): Rewrite.
3915         (get_auxv_inferior_data, _initialize_auxv): Update.
3916
3917 2019-05-08  Tom Tromey  <tom@tromey.com>
3918
3919         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3920         (symfile_debug_objfile_data_key): Change type.
3921         (symfile_debug_installed, debug_qf_has_symbols)
3922         (debug_qf_find_last_source_symtab)
3923         (debug_qf_forget_cached_source_info)
3924         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3925         (debug_qf_print_stats, debug_qf_dump)
3926         (debug_qf_expand_symtabs_for_function)
3927         (debug_qf_expand_all_symtabs)
3928         (debug_qf_expand_symtabs_with_fullname)
3929         (debug_qf_map_matching_symbols)
3930         (debug_qf_expand_symtabs_matching)
3931         (debug_qf_find_pc_sect_compunit_symtab)
3932         (debug_qf_map_symbol_filenames)
3933         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3934         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3935         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3936         (debug_sym_read_linetable, debug_sym_relocate): Update.
3937         (symfile_debug_free_objfile): Remove.
3938         (install_symfile_debug_logging, _initialize_symfile_debug):
3939         Update.
3940
3941 2019-05-08  Tom Tromey  <tom@tromey.com>
3942
3943         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3944         allocate_on_obstack.
3945         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3946         (get_dwarf2_per_objfile): Update.
3947         (set_dwarf2_per_objfile): Remove.
3948         (dwarf2_has_info, dwarf2_get_section_info): Update.
3949         (dwarf2_free_objfile): Remove.
3950         (_initialize_dwarf2_read): Update.
3951
3952 2019-05-08  Tom Tromey  <tom@tromey.com>
3953
3954         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3955         initializers.
3956         <unsupported_script_warning_printed,
3957         script_not_found_warning_printed>: Now bool.
3958         (auto_load_pspace_data): Change type.
3959         (~auto_load_pspace_info): Rename from
3960         auto_load_pspace_data_cleanup.
3961         (get_auto_load_pspace_data, init_loaded_scripts_info)
3962         (clear_section_scripts, maybe_print_unsupported_script_warning)
3963         (maybe_print_script_not_found_warning, _initialize_auto_load):
3964         Update.
3965
3966 2019-05-08  Tom Tromey  <tom@tromey.com>
3967
3968         * objfiles.c (objfile_pspace_info): Add destructor and
3969         initializers.
3970         (objfiles_pspace_data): Change type.
3971         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3972         (get_objfile_pspace_data): Update.
3973         (objfiles_bfd_data): Change type.
3974         (get_objfile_bfd_data): Update.
3975         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3976
3977 2019-05-08  Tom Tromey  <tom@tromey.com>
3978
3979         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3980         Change type.
3981         (get_catch_syscall_inferior_data): Update.
3982         (catch_syscall_inferior_data_cleanup): Remove.
3983         (_initialize_break_catch_syscall): Update.
3984
3985 2019-05-08  Tom Tromey  <tom@tromey.com>
3986
3987         * inflow.c (struct terminal_info): Add destructor and
3988         initializers.
3989         (inflow_inferior_data): Change type.
3990         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3991         (get_inflow_inferior_data, inflow_inferior_exit)
3992         (swap_terminal_info, _initialize_inflow): Update.
3993
3994 2019-05-08  Tom Tromey  <tom@tromey.com>
3995
3996         * target-dcache.c (target_dcache_cleanup): Remove.
3997         (target_dcache_aspace_key): Change type.
3998         (target_dcache_init_p, target_dcache_invalidate)
3999         (target_dcache_get, target_dcache_get_or_init)
4000         (_initialize_target_dcache): Update.
4001         * dcache.h (struct dcache_deleter): New.
4002
4003 2019-05-08  Tom Tromey  <tom@tromey.com>
4004
4005         * symtab.c (struct symbol_cache): Add destructor and
4006         initializers.
4007         (symbol_cache_key): Move.  Change type.
4008         (make_symbol_cache, free_symbol_cache): Remove.
4009         (get_symbol_cache): Update.
4010         (symbol_cache_cleanup): Remove.
4011         (ALL_PSPACES, symbol_cache_flush)
4012         (maintenance_print_symbol_cache)
4013         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4014         Update.
4015
4016 2019-05-08  Tom Tromey  <tom@tromey.com>
4017
4018         * symtab.c (struct main_info): Add destructor and initializers.
4019         (main_progspace_key): Move.  Change type.
4020         (get_main_info): Update.
4021         (main_info_cleanup): Remove.
4022         (_initialize_symtab): Update.
4023
4024 2019-05-08  Tom Tromey  <tom@tromey.com>
4025
4026         * registry.h (DECLARE_REGISTRY): Define the _key class.
4027
4028 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         * NEWS: Merge two 'New commands' sections.
4031
4032 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4033
4034         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4035         parameter and use Ada language definition instead.
4036         (ada_val_print_ptr): Remove unused language parameter.
4037         (ada_val_print_num): Remove language parameter and use Ada language
4038         definition instead.
4039         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4040         parameter.
4041         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4042         parameter and use Ada language definition instead.
4043         (ada_val_print_1): Update all ada_val_print_xxx calls.
4044         Remove language parameter.
4045         (ada_val_print): Update ada_val_print_1 call.
4046
4047 2019-05-08  Tom Tromey  <tromey@adacore.com>
4048
4049         * remote.c (remote_hw_watchpoint_limit)
4050         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4051         Now static.
4052
4053 2019-05-08  Tom Tromey  <tromey@adacore.com>
4054
4055         * maint.c (_initialize_maint_cmds): Move initialization code to
4056         remote.c.
4057         (watchdog, show_watchdog): Move to remote.c.
4058         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4059         "watchdog" static.
4060         (_initialize_remote): Move initialization code from maint.c.
4061         * defs.h (watchdog): Don't declare.
4062
4063 2019-05-08  Tom Tromey  <tromey@adacore.com>
4064
4065         * tui/tui-interp.c: Include main.h.
4066         * interps.c: Include main.h.
4067         * main.h (interpreter_p): Declare.
4068         * defs.h (interpreter_p): Don't declare.
4069
4070 2019-05-08  Tom Tromey  <tromey@adacore.com>
4071
4072         * dwarf2loc.c: Include dwarf2read.h.
4073         * defs.h (read_unsigned_leb128): Don't declare.
4074         * dwarf2read.h (read_unsigned_leb128): Declare.
4075
4076 2019-05-08  Tom Tromey  <tromey@adacore.com>
4077
4078         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4079         method.
4080
4081 2019-05-08  Tom Tromey  <tromey@adacore.com>
4082
4083         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4084         when no wrap column is set.
4085
4086 2019-05-08  Tom Tromey  <tromey@adacore.com>
4087
4088         * c-lang.c (c_get_string): Handle non-C-style arrays.
4089
4090 2019-05-08  Tom Tromey  <tromey@adacore.com>
4091
4092         * typeprint.c (print_offset_data::update): Print the bit offset,
4093         not the number of bits remaining.
4094
4095 2019-05-08  Tom Tromey  <tromey@adacore.com>
4096
4097         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4098         padding at end of comment.
4099
4100 2019-05-08  Tom Tromey  <tromey@adacore.com>
4101
4102         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4103         Compare main types.
4104
4105 2019-05-06  Tom Tromey  <tom@tromey.com>
4106
4107         * common/scoped_mmap.c: Include common-defs.h.
4108         * common/scoped_mmap.h: Don't include config.h.
4109
4110 2019-05-04  Tom Tromey  <tom@tromey.com>
4111
4112         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4113         (struct aarch64_call_info): Add initializers.
4114         <si>: Now a std::vector.
4115         (pass_on_stack, aarch64_push_dummy_call): Update.
4116
4117 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4118             Tom Tromey  <tom@tromey.com>
4119
4120         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4121         (ppc_threads): Now a std::vector.  Now static.
4122         (hwdebug_find_thread_points_by_tid)
4123         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4124         Update.
4125
4126 2019-05-04  Tom Tromey  <tom@tromey.com>
4127
4128         * arc-tdep.c (arc_tdesc_init): Return bool.
4129
4130 2019-05-04  Tom Tromey  <tom@tromey.com>
4131
4132         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4133         Use gdb_assert_not_reached.
4134
4135 2019-05-04  Tom Tromey  <tom@tromey.com>
4136
4137         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4138         "false".
4139
4140 2019-05-04  Tom Tromey  <tom@tromey.com>
4141
4142         * arc-tdep.c (arc_tdesc_init): Use bool.
4143
4144 2019-05-04  Tom Tromey  <tom@tromey.com>
4145
4146         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4147
4148 2019-05-04  Tom Tromey  <tom@tromey.com>
4149
4150         * cli/cli-cmds.c (valid_command_p): Return bool.
4151
4152 2019-05-04  Tom Tromey  <tom@tromey.com>
4153
4154         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4155         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4156
4157 2019-05-04  Raul Tambre  <raul@tambre.ee>
4158
4159         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4160         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4161         operator for comparison.
4162
4163 2019-05-04  Tom Tromey  <tom@tromey.com>
4164
4165         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4166         (lookup_partial_symbol, print_partial_symbols)
4167         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4168         (psymbol_compare): Update.
4169         (add_psymbol_to_bcache): Clear the entire psymbol.
4170         (maintenance_check_psymtabs): Update.
4171         * psympriv.h (struct partial_symbol): Don't derive from
4172         general_symbol_info.
4173         <obj_section, unrelocated_address, address,
4174         set_unrelocated_address>: Update.
4175         <ginfo>: New member.
4176         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4177         (debug_names::write_psymbols): Update.
4178
4179 2019-05-04  Tom de Vries  <tdevries@suse.de>
4180
4181         * contrib/cc-with-tweaks.sh: Support -n arg.
4182
4183 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4184
4185         * corelow.c (core_target::detach): Ensure frame cache and
4186         register caches are cleared.
4187         inferior.c (exit_inferior_1): Likewise.
4188
4189 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4190             Tom Tromey  <tom@tromey.com>
4191
4192         * dictionary.c (collate_pending_symbols_by_language): Remove
4193         "struct" from foreach.
4194         * symtab.c (lookup_global_symbol_from_objfile)
4195         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4196         foreach.
4197         * ser-tcp.c (net_open): Remove "struct" from foreach.
4198         * objfiles.c (objfile_relocate, objfile_rebase)
4199         (objfile_has_symbols): Remove "struct" from foreach.
4200         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4201         from foreach.
4202         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4203         foreach.
4204         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4205         "struct" from foreach.
4206         * ada-lang.c (create_excep_cond_exprs)
4207         (ada_exception_catchpoint_cond_string): Remove "struct" from
4208         foreach.
4209
4210 2019-05-03  Tom Tromey  <tromey@adacore.com>
4211
4212         * ada-exp.y (convert_char_literal): Check suffix of each
4213         enumerator.
4214
4215 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4216
4217         PR ada/21406:
4218         * ada-exp.y (yywrap): Don't define.
4219         * ada-lex.l (%option): Add noyywrap
4220         (yywrap): Remove.
4221
4222 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4223
4224         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4225         _WIN32_WINNT to the XP level, unless already defined to a higher
4226         level.
4227
4228         * unittests/parse-connection-spec-selftests.c:
4229         * ser-tcp.c:
4230         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4231         override.
4232
4233         * symfile.c (find_separate_debug_file): Remove colon from the
4234         drive spec of DOS/Windows file names of the target, so that the
4235         file name produced from DEBUGDIR and the target's directory will
4236         be valid on DOS/Windows systems.
4237
4238 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4239
4240         * rust-lang.c (val_print_struct): Handle printing structures
4241         containing strings.
4242
4243 2019-05-02  Tom Tromey  <tromey@adacore.com>
4244
4245         * valarith.c (_initialize_valarith): Remove.
4246
4247 2019-05-01  Tom Tromey  <tromey@adacore.com>
4248
4249         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4250         bitfields.
4251
4252 2019-05-01  Tom Tromey  <tromey@adacore.com>
4253
4254         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4255         for big-endian copies.
4256
4257 2019-04-30  Ali Tamur  <tamur@google.com>
4258         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4259         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4260         (read_3_bytes): New function.
4261
4262 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4263
4264         * windows-nat.c (main_thread_id): Delete.
4265         (handle_output_debug_string): Replace main_thread_id by
4266         current_event.dwThreadId.
4267         (fake_create_process): Likewise.
4268         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4269         Do not set main_thread_id.
4270         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4271         current_event.dwThreadId.
4272         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4273
4274 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4275
4276         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4277         Use current_event.dwThreadId instead of main_thread_id.
4278
4279 2019-04-30  Tom Tromey  <tromey@adacore.com>
4280
4281         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4282         (create_excep_cond_exprs): Iterate over program spaces.
4283         (ada_exception_catchpoint_cond_string): Examine all minimal
4284         symbols for exception types.
4285
4286 2019-04-30  Tom Tromey  <tromey@adacore.com>
4287
4288         PR c++/24470:
4289         * dwarf2read.c (process_structure_scope): Handle case where type
4290         has template parameters but no symbol was created.
4291
4292 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4293             Chris January  <chris.january@arm.com>
4294
4295         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4296         qualifier.
4297         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4298
4299 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4300
4301         * f-typeprint.c (f_print_type): Update rules for printing
4302         whitespace.
4303         (f_type_print_varspec_suffix): Likewise.
4304
4305 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4306             Chris January  <chris.january@arm.com>
4307
4308         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4309         function arguments.
4310
4311 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * f-lang.c (build_fortran_types): Change name of void type to
4314         lower case.
4315         * f-typeprint.c (f_type_print_base): Print the name of the void
4316         type, rather than a fixed string.
4317         * f-valprint.c (f_decorations): Use lower case void string.
4318
4319 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4320             Chris January  <chris.january@arm.com>
4321
4322         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4323         types for Fortran.
4324
4325 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4326             Chris January  <chris.january@arm.com>
4327             David Lecomber  <david.lecomber@arm.com>
4328
4329         * f-exp.y (BINOP_INTRINSIC): New token.
4330         (exp): New parser rule handling BINOP_INTRINSIC.
4331         (f77_keywords): Add new builtin procedures.
4332         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4333         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4334         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4335         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4336         (print_unop_subexp_f): New function.
4337         (print_binop_subexp_f): New function.
4338         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4339         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4340         (dump_subexp_body_f): Likewise.
4341         (operator_check_f): Likewise.
4342         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4343         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4344
4345 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4346
4347         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4348         UNOP_KIND.
4349         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4350         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4351         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4352         (operator_length_f): New fuction.
4353         (print_subexp_f): New function.
4354         (op_name_f): New function.
4355         (dump_subexp_body_f): New function.
4356         (operator_check_f): New function.
4357         (exp_descriptor_f): Replace standard expression handling functions
4358         with new functions.
4359         * gdb/fortran-operator.def: New file.
4360         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4361         * gdb/std-operator.def: Remove UNOP_KIND.
4362
4363 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4364
4365         * std-operator.def: Remove unbalanced, stray double quote
4366         character.
4367
4368 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4369             Chris January  <chris.january@arm.com>
4370             Daniel Everett  <daniel.everett@arm.com>
4371             Nick Forrington  <nick.forrington@arm.com>
4372             Richard Bunt  <richard.bunt@arm.com>
4373
4374         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4375         of depth when printing anonymous structs or unions.
4376         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4377         Don't print either the top-level value, or the children if the
4378         max-depth is exceeded.
4379         (ppscm_print_children): When printing the key of a map, allow one
4380         extra level of depth.
4381         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4382         print either the top-level value, or the children if the max-depth
4383         is exceeded.
4384         (print_children): When printing the key of a map, allow one extra
4385         level of depth.
4386         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4387         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4388         (user_print_options): Initialise max_depth field.
4389         (val_print_scalar_or_string_type_p): New function.
4390         (val_print): Check to see if the max depth has been reached.
4391         (val_print_check_max_depth): Define new function.
4392         (show_print_max_depth): New function.
4393         (_initialize_valprint): Add 'print max-depth' option.
4394         * valprint.h (struct value_print_options) <max_depth>: New field.
4395         (val_print_check_max_depth): Declare new function.
4396         * NEWS: Document new feature.
4397
4398 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4399
4400         * ada-lang.c (ada_language_defn): Initialise new field.
4401         * c-lang.c (c_is_string_type_p): New function.
4402         (c_language_defn): Initialise new field.
4403         (cplus_language_defn): Initialise new field.
4404         (asm_language_defn): Initialise new field.
4405         (minimal_language_defn): Initialise new field.
4406         * c-lang.h (c_is_string_type_p): Declare new function.
4407         * d-lang.c (d_language_defn): Initialise new field.
4408         * f-lang.c (f_is_string_type_p): New function.
4409         (f_language_defn): Initialise new field.
4410         * go-lang.c (go_is_string_type_p): New function.
4411         (go_language_defn): Initialise new field.
4412         * language.c (default_is_string_type_p): New function.
4413         (unknown_language_defn): Initialise new field.
4414         (auto_language_defn): Initialise new field.
4415         * language.h (struct language_defn) <la_is_string_type_p>: New
4416         member variable.
4417         (default_is_string_type_p): Declare new function.
4418         * m2-lang.c (m2_language_defn): Initialise new field.
4419         * objc-lang.c (objc_language_defn): Initialise new field.
4420         * opencl-lang.c (opencl_language_defn): Initialise new field.
4421         * p-lang.c (pascal_is_string_type_p): New function.
4422         (pascal_language_defn): Initialise new field.
4423         * rust-lang.c (rust_is_string_type_p): New function.
4424         (rust_language_defn): Initialise new field.
4425
4426 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4429         New field.
4430         * ada-lang.c (ada_language_defn): Initialise new field.
4431         * c-lang.c (c_language_defn): Likewise.
4432         (cplus_language_defn): Likewise.
4433         (asm_language_defn): Likewise.
4434         (minimal_language_defn): Likewise.
4435         * d-lang.c (d_language_defn): Likewise.
4436         * f-lang.c (f_language_defn): Likewise.
4437         * go-lang.c (go_language_defn): Likewise.
4438         * language.c (unknown_language_defn): Likewise.
4439         (auto_language_defn): Likewise.
4440         * m2-lang.c (m2_language_defn): Likewise.
4441         * objc-lang.c (objc_language_defn): Likewise.
4442         * opencl-lang.c (opencl_language_defn): Likewise.
4443         * p-lang.c (pascal_language_defn): Likewise.
4444         * rust-lang.c (rust_language_defn): Likewise.
4445
4446 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4447
4448         * ada-lang.c (ada_is_character_type): Change return type to bool.
4449         (ada_is_string_type): Likewise.
4450         * ada-lang.h (ada_is_character_type): Update declaration
4451         (ada_is_string_type): Likewise.
4452
4453 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4454
4455         Support style in 'frame|thread apply'
4456
4457         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4458         * record.c (record_start, record_stop): Update callers of
4459         execute_command_to_string with false.
4460         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4461         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4462         methods.
4463         (class string_file): New constructor with term_out parameter.
4464         Override methods term_out and can_emit_style_escape.  New member
4465         term_out.
4466         (class stdio_file): Override can_emit_style_escape.
4467         (class tee_file): Override term_out and can_emit_style_escape.
4468         * utils.h (can_emit_style_escape): Remove.
4469         * utils.c (can_emit_style_escape): Likewise.
4470         Update all callers of can_emit_style_escape (SOMESTREAM) to
4471         SOMESTREAM->can_emit_style_escape.
4472         * source-cache.c (source_cache::get_source_lines): Likewise.
4473         * stack.c (frame_apply_command_count): Call execute_command_to_string
4474         passing the term_out characteristic of the current gdb_stdout.
4475         * thread.c (thr_try_catch_cmd): Likewise.
4476         * top.c (execute_command_to_string): pass term_out parameter
4477         to construct the string_file for the command output.
4478         * ui-file.c (term_cli_styling): New function (most code moved
4479         from utils.c can_emit_style_escape).
4480         (string_file::string_file, string_file::can_emit_style_escape,
4481         stdio_file::can_emit_style_escape, tee_file::term_out,
4482         tee_file::can_emit_style_escape): New functions.
4483
4484 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4485
4486         * NEWS: Mention the new set|show may-call-functions.
4487         * infcall.c (may_call_functions_p): New variable.
4488         (show_may_call_functions_p): New function.
4489         (call_function_by_hand_dummy): Throws an error if not
4490         may-call-functions.
4491         (_initialize_infcall): Call add_setshow_boolean_cmd for
4492         may-call-functions.
4493
4494 2019-04-25  Keith Seitz  <keiths@redhat.com>
4495
4496         PR c++/24367
4497         * cp-support.c (inspect_type): Don't attempt substitutions
4498         of symbol with the same name.
4499
4500 2019-04-25  Tom Tromey  <tromey@adacore.com>
4501
4502         PR gdb/24475:
4503         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4504         static.
4505
4506 2019-04-25  Tom Tromey  <tromey@adacore.com>
4507
4508         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4509         rvalue reference.
4510         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4511         (gdb_xml_parser::parse): Use std::move.
4512         * python/python-internal.h (gdbpy_convert_exception): Take a const
4513         reference.
4514         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4515         std::move.
4516         * python/py-utils.c (gdbpy_convert_exception): Take a const
4517         reference.
4518         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4519         Use std::move.
4520         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4521         Use std::move.
4522         * mi/mi-main.c (mi_print_exception): Take a const reference.
4523         * main.c (handle_command_errors): Take a const reference.
4524         * linespec.c (parse_linespec): Use std::move.
4525         * infcall.c (run_inferior_call): Use std::move.
4526         (call_function_by_hand_dummy): Use std::move.
4527         * exec.c (try_open_exec_file): Use std::move.
4528         * exceptions.h (exception_print, exception_fprintf)
4529         (exception_print_same): Update.
4530         * exceptions.c (print_exception, exception_print)
4531         (exception_fprintf, exception_print_same): Change parameters to
4532         const reference.
4533         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4534         * common/new-op.c: Use std::move.
4535         * common/common-exceptions.h (struct gdb_exception): Add move
4536         constructor.
4537         (struct gdb_exception_error, struct gdb_exception_quit, struct
4538         gdb_quit_bad_alloc): Change constructor to move constructor.
4539         (throw_exception): Change parameter to rvalue reference.
4540         * common/common-exceptions.c (throw_exception): Take rvalue
4541         reference.
4542         * cli/cli-interp.c (safe_execute_command): Use std::move.
4543         * breakpoint.c (insert_bp_location, location_to_sals): Use
4544         std::move.
4545
4546 2019-04-25  Tom Tromey  <tromey@adacore.com>
4547
4548         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4549         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4550         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4551         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4552         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4553         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4554         guile/scm-value.c: Use unpack.
4555         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4556         gdbscm_gdb_exception.
4557         (gdbscm_throw_gdb_exception): Likewise.
4558         (struct gdbscm_gdb_exception): New.
4559         (unpack): New function.
4560         (gdbscm_wrap): Use unpack.
4561
4562 2019-04-25  Tom Tromey  <tromey@adacore.com>
4563
4564         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4565         (gdb_rl_callback_handler): Use std::move.
4566         * common/common-exceptions.h (struct gdb_exception): Add move
4567         assignment operator.
4568         (throw_exception_sjlj): Change "exception" to const reference.
4569         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4570         (throw_exception_sjlj): Change "exception" to const reference.
4571
4572 2019-04-25  Tom Tromey  <tromey@adacore.com>
4573
4574         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4575         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4576         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4577         Update.
4578         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4579         Update.
4580         * mi/mi-interp.c (mi_interp::exec): Update.
4581         * linespec.c (parse_linespec): Update.
4582         * infcall.c (run_inferior_call): Update.
4583         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4584         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4585         (gdbscm_lookup_global_symbol): Update.
4586         * guile/scm-param.c (gdbscm_parameter_value): Update.
4587         * guile/scm-frame.c (gdbscm_frame_read_register)
4588         (gdbscm_frame_read_var): Update.
4589         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4590         * exec.c (try_open_exec_file): Update.
4591         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4592         (gdb_rl_callback_handler): Update.
4593         * common/common-exceptions.h (exception_none): Don't declare.
4594         * common/common-exceptions.c (exception_none): Don't define.
4595         (struct catcher) <exception>: Update.
4596         * cli/cli-interp.c (safe_execute_command): Update.
4597         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4598
4599 2019-04-25  Ali Tamur  <tamur@google.com>
4600
4601         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4602         (read_attribute_value): Likewise.
4603         (dwarf2_read_addr_index): Update comment.
4604         (read_str_index): Add DW_FORM_strx.
4605         (dwarf2_string_attr): Likewise.
4606         (dwarf2_const_value_attr): Likewise.
4607         (dump_die_shallow): Likewise.
4608         (dwarf2_fetch_constant_bytes): Likewise.
4609         (skip_form_bytes): Likewise.
4610         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4611
4612 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4613
4614         PR corefiles/11608
4615         PR corefiles/18187
4616         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4617         OFFSET.  Verify if current mapping contains an ELF header.
4618         (linux_find_memory_regions_full): Adjust call to
4619         dump_mapping_p.
4620
4621 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4622             Kang Li <kanglictf@gmail.com>
4623
4624         PR gdb/21600
4625
4626         * dwarf2-frame.c (read_initial_length): Be consistent about using
4627         unsigned representation of length.
4628         (decode_frame_entry_1): Likewise.  Check for wraparound of
4629         end pointer as well as buffer overflow.
4630
4631 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4632
4633         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4634         "vq".
4635
4636 2019-04-24  Tom Tromey  <tromey@adacore.com>
4637
4638         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4639
4640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * s12z-tdep.c (s12z_unwind_pc): Delete.
4643         (s12z_unwind_sp): Delete.
4644         (s12z_gdbarch_init): Don't register deleted functions with
4645         gdbarch.
4646
4647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4648
4649         * rl78-tdep.c (rl78_unwind_sp): Delete.
4650         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4651
4652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4653
4654         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4655         (xstormy16_unwind_pc): Delete.
4656         (xstormy16_dummy_id): Delete.
4657         (xstormy16_gdbarch_init): Don't register deleted functions with
4658         gdbarch.
4659
4660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4661
4662         * vax-tdep.c (vax_unwind_pc): Delete.
4663         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4664
4665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * v850-tdep.c (v850_unwind_sp): Delete.
4668         (v850_unwind_pc): Delete.
4669         (v850_dummy_id): Delete.
4670         (v850_gdbarch_init): Don't register deleted functions with
4671         gdbarch.
4672
4673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4676         (tilegx_unwind_pc): Delete.
4677         (tilegx_unwind_dummy_id): Delete.
4678         (tilegx_gdbarch_init): Don't register deleted functions with
4679         gdbarch.
4680
4681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4682
4683         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4684         (tic6x_dummy_id): Delete.
4685         (tic6x_gdbarch_init): Don't register deleted functions with
4686         gdbarch.
4687
4688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4689
4690         * sparc-tdep.c (sparc_unwind_pc): Delete.
4691         (sparc32_gdbarch_init): Don't register deleted function with
4692         gdbarch.
4693
4694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4695
4696         * sh-tdep.c (sh_unwind_sp): Delete.
4697         (sh_unwind_pc): Delete.
4698         (sh_dummy_id): Delete.
4699         (sh_gdbarch_init): Don't register deleted functions with
4700         gdbarch.
4701
4702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4703
4704         * score-tdep.c (score_unwind_sp): Delete.
4705         (score_unwind_pc): Delete.
4706         (score_dummy_id): Delete.
4707         (score_gdbarch_init): Don't register deleted functions with
4708         gdbarch.
4709
4710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4711
4712         * rx-tdep.c (rx_unwind_pc): Delete.
4713         (rx_unwind_sp): Delete.
4714         (rx_dummy_id): Delete.
4715         (rx_gdbarch_init): Don't register deleted functions with
4716         gdbarch.  Update comment.
4717
4718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4719
4720         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4721         (rs6000_dummy_id): Delete.
4722         (rs6000_gdbarch_init): Don't register deleted functions with
4723         gdbarch.
4724
4725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4726
4727         * or1k-tdep.c (or1k_dummy_id): Delete.
4728         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4729
4730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * nios2-tdep.c (nios2_dummy_id): Delete.
4733         (nios2_unwind_sp): Delete.
4734         (nios2_gdbarch_init): Don't register deleted functions with
4735         gdbarch.
4736
4737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         * nds32-tdep.c (nds32_dummy_id): Delete.
4740         (nds32_unwind_pc): Delete.
4741         (nds32_unwind_sp): Delete.
4742         (nds32_gdbarch_init): Don't register deleted functions with
4743         gdbarch.
4744
4745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * msp430-tdep.c (msp430_unwind_pc): Delete.
4748         (msp430_unwind_sp): Delete.
4749         (msp430_dummy_id): Delete.
4750         (msp430_gdbarch_init): Don't register deleted functions with
4751         gdbarch.
4752
4753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4754
4755         * moxie-tdep.c (moxie_unwind_sp): Delete.
4756         (moxie_unwind_pc): Delete.
4757         (moxie_dummy_id): Delete.
4758         (moxie_gdbarch_init): Don't register deleted functions with
4759         gdbarch.
4760
4761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4762
4763         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4764         (mn10300_unwind_pc): Delete.
4765         (mn10300_unwind_sp): Delete.
4766         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4767         mn10300_unwind_sp.
4768         (mn10300_frame_unwind_init): Don't register deleted functions with
4769         gdbarch.
4770
4771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4772
4773         * mep-tdep.c (mep_unwind_pc): Delete.
4774         (mep_unwind_sp): Delete.
4775         (mep_dummy_id): Delete.
4776         (mep_gdbarch_init): Don't register deleted functions with
4777         gdbarch.
4778
4779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4780
4781         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4782         (m68hc11_unwind_sp): Delete.
4783         (m68hc11_gdbarch_init): Don't register deleted functions with
4784         gdbarch.
4785
4786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4787
4788         * m32r-tdep.c (m32r_unwind_sp): Delete.
4789         (m32r_unwind_pc): Delete.
4790         (m32r_dummy_id): Delete.
4791         (m32r_gdbarch_init): Don't register deleted functions with
4792         gdbarch.
4793
4794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * m32c-tdep.c (m32c_unwind_pc): Delete.
4797         (m32c_unwind_sp): Delete.
4798         (m32c_dummy_id): Delete.
4799         (m32c_gdbarch_init): Don't register deleted functions with
4800         gdbarch.
4801
4802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4803
4804         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4805         (lm32_unwind_pc): Delete.
4806         (lm32_dummy_id): Delete.
4807         (lm32_gdbarch_init): Don't register deleted functions with
4808         gdbarch.
4809
4810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4811
4812         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4813         (iq2000_unwind_pc): Delete.
4814         (iq2000_dummy_id): Delete.
4815         (iq2000_gdbarch_init): Don't register deleted functions with
4816         gdbarch.
4817
4818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4819
4820         * nds32-tdep.c (nds32_type_align): Delete.
4821         (nds32_push_dummy_call): Use type_align instead.
4822
4823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4824
4825         * arm-tdep.c (arm_type_align): Only handle vector override case.
4826         (arm_push_dummy_call): Use type_align.
4827         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4828
4829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4830
4831         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4832         case.
4833         (pass_on_stack): Use type_align.
4834         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4835         function.
4836
4837 2019-04-23  Tom Tromey  <tromey@adacore.com>
4838
4839         * dwarf2read.c (line_header::file_name_at): Remove unused
4840         overload.
4841
4842 2019-04-23  Tom de Vries  <tdevries@suse.de>
4843
4844         PR gdb/24438
4845         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4846         invocation.
4847
4848
4849 2019-03-27  Ali Tamur  <tamur@google.com>
4850
4851         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4852         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4853         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4854         (dwarf_expr_context::get_addr_index): Likewise
4855         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4856         (symbol_needs_eval_context::get_addr_index): Likewise
4857         (disassemble_dwarf_expression): Add DW_OP_addrx
4858         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4859         (read_cutu_die_from_dwo): Update comment
4860         (skip_one_die): Add DW_FORM_addrx
4861         (read_attribute_value): Likewise
4862         (var_decode_location): Add DW_OP_addrx
4863         (dwarf2_const_value_attr): Add DW_FORM_addrx
4864         (dump_die_shallow): Likewise
4865         (dwarf2_fetch_constant_bytes): Likewise
4866         (decode_locdesc): Add DW_OP_addrx
4867         (skip_form_bytes): Add DW_FORM_addrx
4868
4869 2019-04-22  Ali Tamur  <tamur@google.com>
4870
4871         * MAINTAINERS (Write After Approval): Add self.
4872
4873 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4874
4875         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4876         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4877         (open_symbol_file_object): Likewise.
4878         (svr4_default_sos): Add info parameter.
4879         (svr4_read_so_list): Likewise.
4880         (svr4_current_sos_direct): Adjust functions calls to pass down
4881         info.
4882         (svr4_current_sos_1): Add info parameter.
4883         (svr4_current_sos): Call get_svr4_info, pass info down to
4884         svr4_current_sos_1.
4885         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4886         get_svr4_info.
4887         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4888         get_svr4_info.
4889         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4890         to get_svr4_info.
4891         (probes_table_remove_objfile_probes): Likewise.
4892         (register_solib_event_probe): Add info parameter.
4893         (solist_update_incremental): Pass info parameter down to
4894         svr4_read_so_list.
4895         (disable_probes_interface): Add info parameter.
4896         (svr4_handle_solib_event): Pass current_program_space to
4897         get_svr4_info.  Adjust disable_probes_interface cleanup.
4898         (svr4_create_probe_breakpoints): Add info parameter, pass it
4899         down to register_solib_event_probe.
4900         (svr4_create_solib_event_breakpoints): Add info parameter,
4901         pass it down to svr4_create_probe_breakpoints.
4902         (enable_break): Pass info down to
4903         svr4_create_solib_event_breakpoints.
4904         (svr4_solib_create_inferior_hook): Pass current_program_space to
4905         get_svr4_info.
4906         (svr4_clear_solib): Likewise.
4907
4908 2019-04-22  Pedro Alves  <palves@redhat.com>
4909
4910         * solib-svr4.c (svr4_free_objfile_observer): New.
4911         (probe_and_action::objfile): New field.
4912         (probes_table_htab_remove_objfile_probes)
4913         (probes_table_remove_objfile_probes): New functions.
4914         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4915         in the new probe_and_action.  Don't store the probe in 'lookup'.
4916         (svr4_create_probe_breakpoints): Pass objfile to
4917         register_solib_event_probe.
4918         (_initialize_svr4_solib): Register a free_objfile observer.
4919
4920 2019-04-19  Tom Tromey  <tom@tromey.com>
4921
4922         * common/queue.h: Remove.
4923
4924 2019-04-19  Tom Tromey  <tom@tromey.com>
4925
4926         * event-loop.c: Don't include "common/queue.h".
4927
4928 2019-04-19  Tom Tromey  <tom@tromey.com>
4929
4930         * remote.c (remote_target): Use delete.
4931         * remote-notif.h: Include <list>, not "common/queue.h".
4932         (notif_client_p): Remove typedef.
4933         (remote_notif_state): Add constructor, destructor, initializer.
4934         <notif_queue>: Now a std::list.
4935         (remote_notif_state_xfree): Don't declare.
4936         * remote-notif.c (remote_notif_process, handle_notification)
4937         (remote_notif_state_allocate): Update.
4938         (~remote_notif_state): Rename from remote_notif_state_xfree.
4939
4940 2019-04-19  Tom Tromey  <tom@tromey.com>
4941
4942         * symfile.c (reread_symbols): Update.
4943         * objfiles.c (objfile_register_static_link)
4944         (objfile_lookup_static_link): Update
4945         (~objfile) Don't delete static_links.
4946         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4947
4948 2019-04-19  Tom Tromey  <tom@tromey.com>
4949
4950         * type-stack.h (struct type_stack) <insert>: Constify string.
4951         * type-stack.c (type_stack::insert): Constify string.
4952         * gdbtypes.h (lookup_template_type): Update.
4953         (address_space_name_to_int): Update.
4954         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4955         const.
4956         (lookup_template_type): Make name const.
4957         * c-exp.y: Update rules.
4958         (lex_one_token, classify_name, classify_inner_name)
4959         (c_print_token): Update.
4960         * p-exp.y: Update rules.
4961         (yylex): Update.
4962         * f-exp.y: Update rules.
4963         (yylex): Update.
4964         * d-exp.y: Update rules.
4965         (lex_one_token, classify_name, classify_inner_name): Update.
4966         * parse.c (write_dollar_variable, copy_name): Return std::string.
4967         * parser-defs.h (copy_name): Change return type.
4968         * m2-exp.y: Update rules.
4969         (yylex): Update.
4970         * go-exp.y (lex_one_token): Update.
4971         Update rules.
4972         (classify_unsafe_function, classify_packaged_name)
4973         (classify_name, yylex): Update.
4974
4975 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4976
4977         * configure.ac: add --enable-source-highlight switch.
4978         * configure: Regenerate.
4979         * top.c (print_gdb_version): plumb --enable-source-highlight
4980         status to "show configuration".
4981
4982 2019-04-19  Tom Tromey  <tromey@adacore.com>
4983
4984         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4985         Check ADA_TYPE_P.
4986         (empty_record, ada_template_to_fixed_record_type_1)
4987         (template_to_static_fixed_type)
4988         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4989         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4990         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4991         macros.
4992
4993 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4994
4995         PR symtab/24423:
4996         * source.c (print_source_lines_base): Advance "iter" when a
4997         control character is seen.
4998
4999 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5000
5001         * inferior.h (struct infcall_suspend_state_deleter):
5002         Catch exception in destructor to avoid crash.
5003
5004 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5005
5006         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5007         close to the add_com "shell".
5008
5009 2019-04-18  Tom Tromey  <tromey@adacore.com>
5010
5011         * process-stratum-target.h (class process_stratum_target)
5012         <stratum>: Add "final".
5013
5014 2019-04-17  Tom Tromey  <tromey@adacore.com>
5015
5016         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5017         against nullptr before use.
5018
5019 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5020
5021         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5022
5023 2019-04-17  Jim Wilson  <jimw@sifive.com>
5024             Andrew Burgess  <andrew.burgess@embecosm.com>
5025
5026         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5027         code read might fail, assume 4-byte breakpoint in that case.
5028
5029 2019-04-15  Leszek Swirski  <leszeks@google.com>
5030
5031         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5032         rather than a hand-rolled POD check when checking for forced MEMORY
5033         classification.
5034
5035 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5036
5037         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5038         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5039         function.
5040         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5041         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5042         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5043         declaration.
5044
5045 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5046
5047         * aarch64-linux-nat.c
5048         (aarch64_linux_nat_target::thread_architecture): Add override.
5049         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5050         each VQ.
5051
5052 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5053
5054         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5055
5056 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5057
5058         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5059         target types of size 96-bits, add some additional comments, and
5060         check that the builtin type we found was the correct size.
5061
5062 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5063
5064         * utils.c (prompt_for_continue): Don't restore the styling at the
5065         end, as applied_style has the wrong value.  This fixes styling in
5066         long lists of file names that are interrupted by the "Continue?"
5067         prompt.
5068
5069 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5070
5071         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5072         * c-lang.c (c_language_defn): Likewise.
5073         (cplus_language_defn): Likewise.
5074         (asm_language_defn): Likewise.
5075         (minimal_language_defn): Likewise.
5076         * d-lang.c (d_language_defn): Likewise.
5077         * f-lang.c (f_language_defn): Likewise.
5078         * go-lang.c (go_language_defn): Likewise.
5079         * language.c (unknown_language_defn): Likewise.
5080         (auto_language_defn): Likewise.
5081         * language.h (struct language_defn): Remove la_magic field.
5082         (LANG_MAGIC): Delete.
5083         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5084         * objc-lang.c (objc_language_defn): Likewise.
5085         * opencl-lang.c (opencl_language_defn): Likewise.
5086         * p-lang.c (pascal_language_defn): Likewise.
5087         * rust-lang.c (rust_language_defn): Likewise.
5088
5089 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5090
5091         * riscv-tdep.c (riscv_type_align): New function.
5092         (riscv_type_alignment): Delete.
5093         (riscv_arg_location): Use 'type_align'.
5094         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5095
5096 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5097
5098         * gdbtypes.c (type_align): A struct with no non-static fields also
5099         has alignment of 1.
5100
5101 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5102
5103         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5104         component to 0.
5105         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5106         member.
5107         (riscv_struct_info::analyse): New implementation using new
5108         analyse_inner member function.
5109         (riscv_struct_info::field_offset): New member function.
5110         (riscv_struct_info::m_offsets): New member variable.
5111         (riscv_struct_info::analyse_inner): New private member function,
5112         takes the old implementation of riscv_struct_info::analyse but
5113         extended to track field offsets.
5114         (riscv_call_arg_struct): Update the struct folding special cases
5115         to handle cases where empty C++ structs, which are non-zero
5116         length, are found.
5117         (riscv_arg_location): Initialise the length of each location, a
5118         non-zero length now indicates the location is in use.
5119         (riscv_push_dummy_call): Allow for the first location having a
5120         non-zero offset when setting up arguments.
5121         (riscv_return_value): Likewise, but for return values.
5122
5123 2019-04-11  Tom Tromey  <tromey@adacore.com>
5124
5125         * utils.c (internal_vproblem): Make "msg" const.
5126
5127 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5128
5129         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5130         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5131         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5132         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5133
5134 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5135
5136         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5137         function.
5138         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5139         of amd64_collect_native_gregset.
5140         (amd64_linux_nat_target::store_registers): Likewise.
5141
5142 2019-04-10  Tom Tromey  <tom@tromey.com>
5143
5144         * symtab.c (lookup_global_symbol_from_objfile)
5145         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5146         * objfiles.h (class separate_debug_iterator): New.
5147         (class separate_debug_range): New.
5148         (struct objfile) <separate_debug_objfiles>: New method.
5149         (objfile_separate_debug_iterate): Don't declare.
5150         * objfiles.c (separate_debug_iterator::operator++): Rename from
5151         objfile_separate_debug_iterate.
5152         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5153         iterator.
5154         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5155         iterator.
5156
5157 2019-04-10  Tom Tromey  <tom@tromey.com>
5158
5159         * symfile.c (reread_symbols): Remove old comment.
5160         * objfiles.c (free_all_objfiles): Fix a typo.
5161
5162 2019-04-10  Tom Tromey  <tom@tromey.com>
5163
5164         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5165         * minsyms.c (lookup_minimal_symbol): Use foreach.
5166         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5167         (lookup_minimal_symbol_solib_trampoline): Likewise.
5168         * symfile.c (reread_symbols): Use foreach.
5169
5170 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5171             Tom Tromey  <tromey@adacore.com>
5172
5173         PR rust/24414:
5174         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5175         (rust_lex_int_test): Change "value" to be LONGEST.
5176         (rust_lex_tests): Add test for long integer literal.
5177
5178 2019-04-09  Tom Tromey  <tromey@adacore.com>
5179
5180         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5181         to bool.
5182         (extended_remote_target::attach): Update.
5183         (remote_target::remote_notice_new_inferior): Update.
5184         (remote_target::add_current_inferior_and_thread): Update.
5185         * inferior.c (exit_inferior_1): Use "false".
5186         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5187
5188 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5189
5190         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5191         the "start" command.
5192
5193 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5194
5195         * python/py-inferior.c (infpy_thread_from_thread_handle):
5196         Adjust comments to reflect renaming of thread_from_thread_handle
5197         to thread_from_handle.  Adjust keywords.  Fix type error message.
5198         (inferior_object_methods): Add thread_from_handle.  Retain
5199         thread_from_thread_handle, but mark it as deprecated.
5200
5201 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5202
5203         * gdbthread.h (find_thread_by_handle): Revise declaration.
5204         * thread.c (find_thread_by_handle): Likewise.  Adjust
5205         implementation too.
5206         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5207         support for buffer objects as handles.
5208
5209 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5210
5211         * python/py-infthread.c (thpy_thread_handle): New function.
5212         (thread_object_methods): Register thpy_thread_handle.
5213
5214 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5215
5216         * gdbthread.h (thread_to_thread_handle): Declare.
5217         * thread.c (gdbtypes.h): Include.
5218         (thread_to_thread_handle): New function.
5219
5220         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5221         (target_thread_info_to_thread_handle): Declare.
5222         * target.c (target_thread_info_to_thread_handle): New function.
5223         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5224         * target-delegates.c: Regenerate.
5225
5226         * linux-thread-db.c (class thread_db_target): Add method
5227         thread_info_to_thread_handle.
5228         (thread_db_target::thread_info_to_thread_handle): Define.
5229         * remote.c (class remote_target): Add new method
5230         thread_info_to_thread_handle.
5231         (remote_target::thread_info_to_thread_handle): Define.
5232
5233 2019-04-08  Pedro Alves  <palves@redhat.com>
5234
5235         * common/common-exceptions.c (throw_exception): Don't create
5236         named object to throw; throw directly.
5237         (throw_it): Likewise.  Don't initialize gdb_exception::message
5238         here, with new; pass FMT and AP to the ctor instead.
5239         * common/common-exceptions.h: Include <string>.
5240         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5241         const char *, va_list)): New ctor.  Use std::make_shared.
5242         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5243         errors)): Delete.
5244         (gdb_exception_error::gdb_exception_error(enum errors, const char
5245         *, va_list)): New.
5246         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5247         Add assertion.
5248         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5249         errors)): Delete.
5250         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5251         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5252         Add assertion.
5253
5254 2019-04-08  Tom Tromey  <tom@tromey.com>
5255
5256         * valops.c (value_rtti_indirect_type): Replace throw_exception
5257         with throw.
5258         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5259         with throw.
5260         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5261         throw.
5262         * target.c (target_translate_tls_address): Replace throw_exception
5263         with throw.
5264         * stack.c (frame_apply_command_count): Replace throw_exception
5265         with throw.
5266         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5267         throw.
5268         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5269         with throw.
5270         * rs6000-tdep.c (rs6000_frame_cache)
5271         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5272         * remote.c: Replace throw_exception with throw.
5273         * record-full.c (record_full_message, record_full_wait_1)
5274         (record_full_restore): Replace throw_exception with throw.
5275         * record-btrace.c:
5276         (get_thread_current_frame_id, record_btrace_start_replaying)
5277         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5278         (cmd_record_btrace_start): Replace throw_exception with throw.
5279         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5280         throw.
5281         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5282         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5283         * linespec.c:
5284         (find_linespec_symbols): Replace throw_exception with throw.
5285         * infrun.c (displaced_step_prepare, resume): Replace
5286         throw_exception with throw.
5287         * infcmd.c (post_create_inferior): Replace throw_exception with
5288         throw.
5289         * inf-loop.c (inferior_event_handler): Replace throw_exception
5290         with throw.
5291         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5292         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5293         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5294         (get_prev_frame_always, get_frame_pc_if_available)
5295         (get_frame_address_in_block_if_available, get_frame_language):
5296         Replace throw_exception with throw.
5297         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5298         throw_exception with throw.
5299         * eval.c (fetch_subexp_value, evaluate_var_value)
5300         (evaluate_funcall, evaluate_subexp_standard): Replace
5301         throw_exception with throw.
5302         * dwarf2loc.c (call_site_find_chain)
5303         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5304         Replace throw_exception with throw.
5305         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5306         with throw.
5307         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5308         throw.
5309         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5310         * completer.c (complete_line_internal): Replace throw_exception
5311         with throw.
5312         * compile/compile-object-run.c (compile_object_run): Replace
5313         throw_exception with throw.
5314         * cli/cli-script.c (process_next_line): Replace throw_exception
5315         with throw.
5316         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5317         (btrace_enable, btrace_maint_update_pt_packets): Replace
5318         throw_exception with throw.
5319         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5320         throw_exception with throw.
5321         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5322         throw_exception with throw.
5323         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5324         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5325         * aarch64-tdep.c (aarch64_make_prologue_cache)
5326         (aarch64_make_stub_cache): Replace throw_exception with throw.
5327
5328 2019-04-08  Tom Tromey  <tom@tromey.com>
5329
5330         * common/common-exceptions.c (throw_exception): Rename from
5331         throw_exception_cxx.  Remove old copy.  Make argument const.
5332         (throw_it): Create and throw exception objects directly.
5333         * common/common-exceptions.h (throw_exception): Make argument
5334         const.
5335         (struct gdb_exception_error): Add constructor.
5336         (struct gdb_exception_quit): Add constructor.
5337
5338 2019-04-08  Tom Tromey  <tom@tromey.com>
5339
5340         * common/common-exceptions.h (exception_rethrow): Don't declare.
5341         (TRY_SJLJ): Update comment.
5342         (TRY, CATCH, END_CATCH): Remove.
5343         * common/common-exceptions.c (exception_rethrow): Remove.
5344
5345 2019-04-08  Tom Tromey  <tom@tromey.com>
5346
5347         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5348         Remove.
5349         (gdb_exception_error): Rename from
5350         gdb_exception_RETURN_MASK_ERROR.
5351         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5352         (gdb_quit_bad_alloc): Update.
5353         * aarch64-tdep.c: Update.
5354         * ada-lang.c: Update.
5355         * ada-typeprint.c: Update.
5356         * ada-valprint.c: Update.
5357         * amd64-tdep.c: Update.
5358         * arch-utils.c: Update.
5359         * break-catch-throw.c: Update.
5360         * breakpoint.c: Update.
5361         * btrace.c: Update.
5362         * c-varobj.c: Update.
5363         * cli/cli-cmds.c: Update.
5364         * cli/cli-interp.c: Update.
5365         * cli/cli-script.c: Update.
5366         * common/common-exceptions.c: Update.
5367         * common/new-op.c: Update.
5368         * common/selftest.c: Update.
5369         * compile/compile-c-symbols.c: Update.
5370         * compile/compile-cplus-symbols.c: Update.
5371         * compile/compile-object-load.c: Update.
5372         * compile/compile-object-run.c: Update.
5373         * completer.c: Update.
5374         * corelow.c: Update.
5375         * cp-abi.c: Update.
5376         * cp-support.c: Update.
5377         * cp-valprint.c: Update.
5378         * darwin-nat.c: Update.
5379         * disasm-selftests.c: Update.
5380         * dtrace-probe.c: Update.
5381         * dwarf-index-cache.c: Update.
5382         * dwarf-index-write.c: Update.
5383         * dwarf2-frame-tailcall.c: Update.
5384         * dwarf2-frame.c: Update.
5385         * dwarf2loc.c: Update.
5386         * dwarf2read.c: Update.
5387         * eval.c: Update.
5388         * event-loop.c: Update.
5389         * event-top.c: Update.
5390         * exec.c: Update.
5391         * f-valprint.c: Update.
5392         * fbsd-tdep.c: Update.
5393         * frame-unwind.c: Update.
5394         * frame.c: Update.
5395         * gdbtypes.c: Update.
5396         * gnu-v3-abi.c: Update.
5397         * guile/guile-internal.h: Update.
5398         * guile/scm-block.c: Update.
5399         * guile/scm-breakpoint.c: Update.
5400         * guile/scm-cmd.c: Update.
5401         * guile/scm-disasm.c: Update.
5402         * guile/scm-frame.c: Update.
5403         * guile/scm-lazy-string.c: Update.
5404         * guile/scm-math.c: Update.
5405         * guile/scm-param.c: Update.
5406         * guile/scm-ports.c: Update.
5407         * guile/scm-pretty-print.c: Update.
5408         * guile/scm-symbol.c: Update.
5409         * guile/scm-symtab.c: Update.
5410         * guile/scm-type.c: Update.
5411         * guile/scm-value.c: Update.
5412         * i386-linux-tdep.c: Update.
5413         * i386-tdep.c: Update.
5414         * inf-loop.c: Update.
5415         * infcall.c: Update.
5416         * infcmd.c: Update.
5417         * infrun.c: Update.
5418         * jit.c: Update.
5419         * language.c: Update.
5420         * linespec.c: Update.
5421         * linux-fork.c: Update.
5422         * linux-nat.c: Update.
5423         * linux-tdep.c: Update.
5424         * linux-thread-db.c: Update.
5425         * main.c: Update.
5426         * mi/mi-cmd-break.c: Update.
5427         * mi/mi-cmd-stack.c: Update.
5428         * mi/mi-interp.c: Update.
5429         * mi/mi-main.c: Update.
5430         * objc-lang.c: Update.
5431         * p-valprint.c: Update.
5432         * parse.c: Update.
5433         * ppc-linux-tdep.c: Update.
5434         * printcmd.c: Update.
5435         * python/py-arch.c: Update.
5436         * python/py-breakpoint.c: Update.
5437         * python/py-cmd.c: Update.
5438         * python/py-finishbreakpoint.c: Update.
5439         * python/py-frame.c: Update.
5440         * python/py-framefilter.c: Update.
5441         * python/py-gdb-readline.c: Update.
5442         * python/py-inferior.c: Update.
5443         * python/py-infthread.c: Update.
5444         * python/py-lazy-string.c: Update.
5445         * python/py-linetable.c: Update.
5446         * python/py-objfile.c: Update.
5447         * python/py-param.c: Update.
5448         * python/py-prettyprint.c: Update.
5449         * python/py-progspace.c: Update.
5450         * python/py-record-btrace.c: Update.
5451         * python/py-record.c: Update.
5452         * python/py-symbol.c: Update.
5453         * python/py-type.c: Update.
5454         * python/py-unwind.c: Update.
5455         * python/py-utils.c: Update.
5456         * python/py-value.c: Update.
5457         * python/python.c: Update.
5458         * record-btrace.c: Update.
5459         * record-full.c: Update.
5460         * remote-fileio.c: Update.
5461         * remote.c: Update.
5462         * riscv-tdep.c: Update.
5463         * rs6000-aix-tdep.c: Update.
5464         * rs6000-tdep.c: Update.
5465         * rust-exp.y: Update.
5466         * rust-lang.c: Update.
5467         * s390-tdep.c: Update.
5468         * selftest-arch.c: Update.
5469         * solib-dsbt.c: Update.
5470         * solib-frv.c: Update.
5471         * solib-spu.c: Update.
5472         * solib-svr4.c: Update.
5473         * solib.c: Update.
5474         * sparc64-linux-tdep.c: Update.
5475         * stack.c: Update.
5476         * symfile-mem.c: Update.
5477         * symmisc.c: Update.
5478         * target.c: Update.
5479         * thread.c: Update.
5480         * top.c: Update.
5481         * tracefile-tfile.c: Update.
5482         * tui/tui.c: Update.
5483         * typeprint.c: Update.
5484         * unittests/cli-utils-selftests.c: Update.
5485         * unittests/parse-connection-spec-selftests.c: Update.
5486         * valops.c: Update.
5487         * valprint.c: Update.
5488         * value.c: Update.
5489         * varobj.c: Update.
5490         * windows-nat.c: Update.
5491         * x86-linux-nat.c: Update.
5492         * xml-support.c: Update.
5493
5494 2019-04-08  Tom Tromey  <tom@tromey.com>
5495
5496         * xml-support.c: Use C++ exception handling.
5497         * x86-linux-nat.c: Use C++ exception handling.
5498         * windows-nat.c: Use C++ exception handling.
5499         * varobj.c: Use C++ exception handling.
5500         * value.c: Use C++ exception handling.
5501         * valprint.c: Use C++ exception handling.
5502         * valops.c: Use C++ exception handling.
5503         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5504         handling.
5505         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5506         * typeprint.c: Use C++ exception handling.
5507         * tui/tui.c: Use C++ exception handling.
5508         * tracefile-tfile.c: Use C++ exception handling.
5509         * top.c: Use C++ exception handling.
5510         * thread.c: Use C++ exception handling.
5511         * target.c: Use C++ exception handling.
5512         * symmisc.c: Use C++ exception handling.
5513         * symfile-mem.c: Use C++ exception handling.
5514         * stack.c: Use C++ exception handling.
5515         * sparc64-linux-tdep.c: Use C++ exception handling.
5516         * solib.c: Use C++ exception handling.
5517         * solib-svr4.c: Use C++ exception handling.
5518         * solib-spu.c: Use C++ exception handling.
5519         * solib-frv.c: Use C++ exception handling.
5520         * solib-dsbt.c: Use C++ exception handling.
5521         * selftest-arch.c: Use C++ exception handling.
5522         * s390-tdep.c: Use C++ exception handling.
5523         * rust-lang.c: Use C++ exception handling.
5524         * rust-exp.y: Use C++ exception handling.
5525         * rs6000-tdep.c: Use C++ exception handling.
5526         * rs6000-aix-tdep.c: Use C++ exception handling.
5527         * riscv-tdep.c: Use C++ exception handling.
5528         * remote.c: Use C++ exception handling.
5529         * remote-fileio.c: Use C++ exception handling.
5530         * record-full.c: Use C++ exception handling.
5531         * record-btrace.c: Use C++ exception handling.
5532         * python/python.c: Use C++ exception handling.
5533         * python/py-value.c: Use C++ exception handling.
5534         * python/py-utils.c: Use C++ exception handling.
5535         * python/py-unwind.c: Use C++ exception handling.
5536         * python/py-type.c: Use C++ exception handling.
5537         * python/py-symbol.c: Use C++ exception handling.
5538         * python/py-record.c: Use C++ exception handling.
5539         * python/py-record-btrace.c: Use C++ exception handling.
5540         * python/py-progspace.c: Use C++ exception handling.
5541         * python/py-prettyprint.c: Use C++ exception handling.
5542         * python/py-param.c: Use C++ exception handling.
5543         * python/py-objfile.c: Use C++ exception handling.
5544         * python/py-linetable.c: Use C++ exception handling.
5545         * python/py-lazy-string.c: Use C++ exception handling.
5546         * python/py-infthread.c: Use C++ exception handling.
5547         * python/py-inferior.c: Use C++ exception handling.
5548         * python/py-gdb-readline.c: Use C++ exception handling.
5549         * python/py-framefilter.c: Use C++ exception handling.
5550         * python/py-frame.c: Use C++ exception handling.
5551         * python/py-finishbreakpoint.c: Use C++ exception handling.
5552         * python/py-cmd.c: Use C++ exception handling.
5553         * python/py-breakpoint.c: Use C++ exception handling.
5554         * python/py-arch.c: Use C++ exception handling.
5555         * printcmd.c: Use C++ exception handling.
5556         * ppc-linux-tdep.c: Use C++ exception handling.
5557         * parse.c: Use C++ exception handling.
5558         * p-valprint.c: Use C++ exception handling.
5559         * objc-lang.c: Use C++ exception handling.
5560         * mi/mi-main.c: Use C++ exception handling.
5561         * mi/mi-interp.c: Use C++ exception handling.
5562         * mi/mi-cmd-stack.c: Use C++ exception handling.
5563         * mi/mi-cmd-break.c: Use C++ exception handling.
5564         * main.c: Use C++ exception handling.
5565         * linux-thread-db.c: Use C++ exception handling.
5566         * linux-tdep.c: Use C++ exception handling.
5567         * linux-nat.c: Use C++ exception handling.
5568         * linux-fork.c: Use C++ exception handling.
5569         * linespec.c: Use C++ exception handling.
5570         * language.c: Use C++ exception handling.
5571         * jit.c: Use C++ exception handling.
5572         * infrun.c: Use C++ exception handling.
5573         * infcmd.c: Use C++ exception handling.
5574         * infcall.c: Use C++ exception handling.
5575         * inf-loop.c: Use C++ exception handling.
5576         * i386-tdep.c: Use C++ exception handling.
5577         * i386-linux-tdep.c: Use C++ exception handling.
5578         * guile/scm-value.c: Use C++ exception handling.
5579         * guile/scm-type.c: Use C++ exception handling.
5580         * guile/scm-symtab.c: Use C++ exception handling.
5581         * guile/scm-symbol.c: Use C++ exception handling.
5582         * guile/scm-pretty-print.c: Use C++ exception handling.
5583         * guile/scm-ports.c: Use C++ exception handling.
5584         * guile/scm-param.c: Use C++ exception handling.
5585         * guile/scm-math.c: Use C++ exception handling.
5586         * guile/scm-lazy-string.c: Use C++ exception handling.
5587         * guile/scm-frame.c: Use C++ exception handling.
5588         * guile/scm-disasm.c: Use C++ exception handling.
5589         * guile/scm-cmd.c: Use C++ exception handling.
5590         * guile/scm-breakpoint.c: Use C++ exception handling.
5591         * guile/scm-block.c: Use C++ exception handling.
5592         * guile/guile-internal.h: Use C++ exception handling.
5593         * gnu-v3-abi.c: Use C++ exception handling.
5594         * gdbtypes.c: Use C++ exception handling.
5595         * frame.c: Use C++ exception handling.
5596         * frame-unwind.c: Use C++ exception handling.
5597         * fbsd-tdep.c: Use C++ exception handling.
5598         * f-valprint.c: Use C++ exception handling.
5599         * exec.c: Use C++ exception handling.
5600         * event-top.c: Use C++ exception handling.
5601         * event-loop.c: Use C++ exception handling.
5602         * eval.c: Use C++ exception handling.
5603         * dwarf2read.c: Use C++ exception handling.
5604         * dwarf2loc.c: Use C++ exception handling.
5605         * dwarf2-frame.c: Use C++ exception handling.
5606         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5607         * dwarf-index-write.c: Use C++ exception handling.
5608         * dwarf-index-cache.c: Use C++ exception handling.
5609         * dtrace-probe.c: Use C++ exception handling.
5610         * disasm-selftests.c: Use C++ exception handling.
5611         * darwin-nat.c: Use C++ exception handling.
5612         * cp-valprint.c: Use C++ exception handling.
5613         * cp-support.c: Use C++ exception handling.
5614         * cp-abi.c: Use C++ exception handling.
5615         * corelow.c: Use C++ exception handling.
5616         * completer.c: Use C++ exception handling.
5617         * compile/compile-object-run.c: Use C++ exception handling.
5618         * compile/compile-object-load.c: Use C++ exception handling.
5619         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5620         * compile/compile-c-symbols.c: Use C++ exception handling.
5621         * common/selftest.c: Use C++ exception handling.
5622         * common/new-op.c: Use C++ exception handling.
5623         * cli/cli-script.c: Use C++ exception handling.
5624         * cli/cli-interp.c: Use C++ exception handling.
5625         * cli/cli-cmds.c: Use C++ exception handling.
5626         * c-varobj.c: Use C++ exception handling.
5627         * btrace.c: Use C++ exception handling.
5628         * breakpoint.c: Use C++ exception handling.
5629         * break-catch-throw.c: Use C++ exception handling.
5630         * arch-utils.c: Use C++ exception handling.
5631         * amd64-tdep.c: Use C++ exception handling.
5632         * ada-valprint.c: Use C++ exception handling.
5633         * ada-typeprint.c: Use C++ exception handling.
5634         * ada-lang.c: Use C++ exception handling.
5635         * aarch64-tdep.c: Use C++ exception handling.
5636
5637 2019-04-08  Tom Tromey  <tom@tromey.com>
5638
5639         * xml-support.c (gdb_xml_parser::parse): Update.
5640         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5641         * value.c (show_convenience): Update.
5642         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5643         (test_parse_flags_qcs): Update.
5644         * thread.c (thr_try_catch_cmd): Update.
5645         * target.c (target_translate_tls_address): Update.
5646         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5647         (info_frame_command_core, frame_apply_command_count): Update.
5648         * rust-exp.y (rust_lex_exception_test): Update.
5649         * riscv-tdep.c (riscv_print_one_register_info): Update.
5650         * remote.c (remote_target::enable_btrace): Update.
5651         * record-btrace.c (record_btrace_enable_warn): Update.
5652         * python/py-utils.c (gdbpy_convert_exception): Update.
5653         * printcmd.c (do_one_display, print_variable_and_value): Update.
5654         * mi/mi-main.c (mi_print_exception): Update.
5655         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5656         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5657         * linux-nat.c (linux_nat_target::attach): Update.
5658         * linux-fork.c (class scoped_switch_fork_info): Update.
5659         * infrun.c (displaced_step_prepare): Update.
5660         * infcall.c (call_function_by_hand_dummy): Update.
5661         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5662         * gnu-v3-abi.c (print_one_vtable): Update.
5663         * frame.c (get_prev_frame_always): Update.
5664         * f-valprint.c (info_common_command_for_block): Update.
5665         * exec.c (try_open_exec_file): Update.
5666         * exceptions.c (print_exception, exception_print)
5667         (exception_fprintf, exception_print_same): Update.
5668         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5669         * dwarf-index-cache.c (index_cache::store)
5670         (index_cache::lookup_gdb_index): Update.
5671         * darwin-nat.c (maybe_cache_shell): Update.
5672         * cp-valprint.c (cp_print_value_fields): Update.
5673         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5674         (gcc_cplus_symbol_address): Update.
5675         * compile/compile-c-symbols.c (gcc_convert_symbol)
5676         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5677         * common/selftest.c: Update.
5678         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5679         a std::string.
5680         (exception_try_scope_entry, exception_try_scope_exit): Don't
5681         declare.
5682         (struct exception_try_scope): Remove.
5683         (TRY): Don't use exception_try_scope.
5684         (struct gdb_exception): Add constructor, operator=.
5685         <what>: New method.
5686         (struct gdb_exception_RETURN_MASK_ALL)
5687         (struct gdb_exception_RETURN_MASK_ERROR)
5688         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5689         (struct gdb_quit_bad_alloc): Update.
5690         * common/common-exceptions.c (exception_none): Change
5691         initializer.
5692         (struct catcher) <state, exception>: Initialize inline.
5693         <prev>: Remove member.
5694         (current_catcher): Remove.
5695         (catchers): New global.
5696         (exceptions_state_mc_init): Simplify.
5697         (catcher_pop): Remove.
5698         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5699         (try_scope_depth, exception_try_scope_entry)
5700         (exception_try_scope_exit): Remove.
5701         (throw_exception_sjlj): Update.
5702         (exception_messages, exception_messages_size): Remove.
5703         (throw_it): Simplify.
5704         (gdb_exception_sliced_copy): Remove.
5705         (throw_exception_cxx): Update.
5706         * cli/cli-script.c (script_from_file): Update.
5707         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5708         Update.
5709         * ada-valprint.c (ada_val_print): Update.
5710         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5711         (create_excep_cond_exprs): Update.
5712
5713 2019-04-08  Tom Tromey  <tom@tromey.com>
5714
5715         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5716         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5717         (TRY, CATCH, END_CATCH): Remove some definitions.
5718         * common/common-exceptions.c: Don't use GDB_XCPT.
5719         (catcher_list_size): Remove.
5720         (throw_exception, throw_it): Simplify.
5721
5722 2019-04-05  Tom Tromey  <tom@tromey.com>
5723
5724         Revert the header-sorting patch.
5725         * ft32-tdep.c: Revert.
5726         * frv-tdep.c: Revert.
5727         * frv-linux-tdep.c: Revert.
5728         * frame.c: Revert.
5729         * frame-unwind.c: Revert.
5730         * frame-base.c: Revert.
5731         * fork-child.c: Revert.
5732         * findvar.c: Revert.
5733         * findcmd.c: Revert.
5734         * filesystem.c: Revert.
5735         * filename-seen-cache.h: Revert.
5736         * filename-seen-cache.c: Revert.
5737         * fbsd-tdep.c: Revert.
5738         * fbsd-nat.h: Revert.
5739         * fbsd-nat.c: Revert.
5740         * f-valprint.c: Revert.
5741         * f-typeprint.c: Revert.
5742         * f-lang.c: Revert.
5743         * extension.h: Revert.
5744         * extension.c: Revert.
5745         * extension-priv.h: Revert.
5746         * expprint.c: Revert.
5747         * exec.h: Revert.
5748         * exec.c: Revert.
5749         * exceptions.c: Revert.
5750         * event-top.c: Revert.
5751         * event-loop.c: Revert.
5752         * eval.c: Revert.
5753         * elfread.c: Revert.
5754         * dwarf2read.h: Revert.
5755         * dwarf2read.c: Revert.
5756         * dwarf2loc.c: Revert.
5757         * dwarf2expr.h: Revert.
5758         * dwarf2expr.c: Revert.
5759         * dwarf2-frame.c: Revert.
5760         * dwarf2-frame-tailcall.c: Revert.
5761         * dwarf-index-write.h: Revert.
5762         * dwarf-index-write.c: Revert.
5763         * dwarf-index-common.c: Revert.
5764         * dwarf-index-cache.h: Revert.
5765         * dwarf-index-cache.c: Revert.
5766         * dummy-frame.c: Revert.
5767         * dtrace-probe.c: Revert.
5768         * disasm.h: Revert.
5769         * disasm.c: Revert.
5770         * disasm-selftests.c: Revert.
5771         * dictionary.c: Revert.
5772         * dicos-tdep.c: Revert.
5773         * demangle.c: Revert.
5774         * dcache.h: Revert.
5775         * dcache.c: Revert.
5776         * darwin-nat.h: Revert.
5777         * darwin-nat.c: Revert.
5778         * darwin-nat-info.c: Revert.
5779         * d-valprint.c: Revert.
5780         * d-namespace.c: Revert.
5781         * d-lang.c: Revert.
5782         * ctf.c: Revert.
5783         * csky-tdep.c: Revert.
5784         * csky-linux-tdep.c: Revert.
5785         * cris-tdep.c: Revert.
5786         * cris-linux-tdep.c: Revert.
5787         * cp-valprint.c: Revert.
5788         * cp-support.c: Revert.
5789         * cp-namespace.c: Revert.
5790         * cp-abi.c: Revert.
5791         * corelow.c: Revert.
5792         * corefile.c: Revert.
5793         * continuations.c: Revert.
5794         * completer.h: Revert.
5795         * completer.c: Revert.
5796         * complaints.c: Revert.
5797         * coffread.c: Revert.
5798         * coff-pe-read.c: Revert.
5799         * cli-out.h: Revert.
5800         * cli-out.c: Revert.
5801         * charset.c: Revert.
5802         * c-varobj.c: Revert.
5803         * c-valprint.c: Revert.
5804         * c-typeprint.c: Revert.
5805         * c-lang.c: Revert.
5806         * buildsym.c: Revert.
5807         * buildsym-legacy.c: Revert.
5808         * build-id.h: Revert.
5809         * build-id.c: Revert.
5810         * btrace.c: Revert.
5811         * bsd-uthread.c: Revert.
5812         * breakpoint.h: Revert.
5813         * breakpoint.c: Revert.
5814         * break-catch-throw.c: Revert.
5815         * break-catch-syscall.c: Revert.
5816         * break-catch-sig.c: Revert.
5817         * blockframe.c: Revert.
5818         * block.c: Revert.
5819         * bfin-tdep.c: Revert.
5820         * bfin-linux-tdep.c: Revert.
5821         * bfd-target.c: Revert.
5822         * bcache.c: Revert.
5823         * ax-general.c: Revert.
5824         * ax-gdb.h: Revert.
5825         * ax-gdb.c: Revert.
5826         * avr-tdep.c: Revert.
5827         * auxv.c: Revert.
5828         * auto-load.c: Revert.
5829         * arm-wince-tdep.c: Revert.
5830         * arm-tdep.c: Revert.
5831         * arm-symbian-tdep.c: Revert.
5832         * arm-pikeos-tdep.c: Revert.
5833         * arm-obsd-tdep.c: Revert.
5834         * arm-nbsd-tdep.c: Revert.
5835         * arm-nbsd-nat.c: Revert.
5836         * arm-linux-tdep.c: Revert.
5837         * arm-linux-nat.c: Revert.
5838         * arm-fbsd-tdep.c: Revert.
5839         * arm-fbsd-nat.c: Revert.
5840         * arm-bsd-tdep.c: Revert.
5841         * arch-utils.c: Revert.
5842         * arc-tdep.c: Revert.
5843         * arc-newlib-tdep.c: Revert.
5844         * annotate.h: Revert.
5845         * annotate.c: Revert.
5846         * amd64-windows-tdep.c: Revert.
5847         * amd64-windows-nat.c: Revert.
5848         * amd64-tdep.c: Revert.
5849         * amd64-sol2-tdep.c: Revert.
5850         * amd64-obsd-tdep.c: Revert.
5851         * amd64-obsd-nat.c: Revert.
5852         * amd64-nbsd-tdep.c: Revert.
5853         * amd64-nbsd-nat.c: Revert.
5854         * amd64-nat.c: Revert.
5855         * amd64-linux-tdep.c: Revert.
5856         * amd64-linux-nat.c: Revert.
5857         * amd64-fbsd-tdep.c: Revert.
5858         * amd64-fbsd-nat.c: Revert.
5859         * amd64-dicos-tdep.c: Revert.
5860         * amd64-darwin-tdep.c: Revert.
5861         * amd64-bsd-nat.c: Revert.
5862         * alpha-tdep.c: Revert.
5863         * alpha-obsd-tdep.c: Revert.
5864         * alpha-nbsd-tdep.c: Revert.
5865         * alpha-mdebug-tdep.c: Revert.
5866         * alpha-linux-tdep.c: Revert.
5867         * alpha-linux-nat.c: Revert.
5868         * alpha-bsd-tdep.c: Revert.
5869         * alpha-bsd-nat.c: Revert.
5870         * aix-thread.c: Revert.
5871         * agent.c: Revert.
5872         * addrmap.c: Revert.
5873         * ada-varobj.c: Revert.
5874         * ada-valprint.c: Revert.
5875         * ada-typeprint.c: Revert.
5876         * ada-tasks.c: Revert.
5877         * ada-lang.c: Revert.
5878         * aarch64-tdep.c: Revert.
5879         * aarch64-ravenscar-thread.c: Revert.
5880         * aarch64-newlib-tdep.c: Revert.
5881         * aarch64-linux-tdep.c: Revert.
5882         * aarch64-linux-nat.c: Revert.
5883         * aarch64-fbsd-tdep.c: Revert.
5884         * aarch64-fbsd-nat.c: Revert.
5885         * aarch32-linux-nat.c: Revert.
5886
5887 2019-04-05  Tom Tromey  <tom@tromey.com>
5888
5889         * ft32-tdep.c: Sort headers.
5890         * frv-tdep.c: Sort headers.
5891         * frv-linux-tdep.c: Sort headers.
5892         * frame.c: Sort headers.
5893         * frame-unwind.c: Sort headers.
5894         * frame-base.c: Sort headers.
5895         * fork-child.c: Sort headers.
5896         * findvar.c: Sort headers.
5897         * findcmd.c: Sort headers.
5898         * filesystem.c: Sort headers.
5899         * filename-seen-cache.h: Sort headers.
5900         * filename-seen-cache.c: Sort headers.
5901         * fbsd-tdep.c: Sort headers.
5902         * fbsd-nat.h: Sort headers.
5903         * fbsd-nat.c: Sort headers.
5904         * f-valprint.c: Sort headers.
5905         * f-typeprint.c: Sort headers.
5906         * f-lang.c: Sort headers.
5907         * extension.h: Sort headers.
5908         * extension.c: Sort headers.
5909         * extension-priv.h: Sort headers.
5910         * expprint.c: Sort headers.
5911         * exec.h: Sort headers.
5912         * exec.c: Sort headers.
5913         * exceptions.c: Sort headers.
5914         * event-top.c: Sort headers.
5915         * event-loop.c: Sort headers.
5916         * eval.c: Sort headers.
5917         * elfread.c: Sort headers.
5918         * dwarf2read.h: Sort headers.
5919         * dwarf2read.c: Sort headers.
5920         * dwarf2loc.c: Sort headers.
5921         * dwarf2expr.h: Sort headers.
5922         * dwarf2expr.c: Sort headers.
5923         * dwarf2-frame.c: Sort headers.
5924         * dwarf2-frame-tailcall.c: Sort headers.
5925         * dwarf-index-write.h: Sort headers.
5926         * dwarf-index-write.c: Sort headers.
5927         * dwarf-index-common.c: Sort headers.
5928         * dwarf-index-cache.h: Sort headers.
5929         * dwarf-index-cache.c: Sort headers.
5930         * dummy-frame.c: Sort headers.
5931         * dtrace-probe.c: Sort headers.
5932         * disasm.h: Sort headers.
5933         * disasm.c: Sort headers.
5934         * disasm-selftests.c: Sort headers.
5935         * dictionary.c: Sort headers.
5936         * dicos-tdep.c: Sort headers.
5937         * demangle.c: Sort headers.
5938         * dcache.h: Sort headers.
5939         * dcache.c: Sort headers.
5940         * darwin-nat.h: Sort headers.
5941         * darwin-nat.c: Sort headers.
5942         * darwin-nat-info.c: Sort headers.
5943         * d-valprint.c: Sort headers.
5944         * d-namespace.c: Sort headers.
5945         * d-lang.c: Sort headers.
5946         * ctf.c: Sort headers.
5947         * csky-tdep.c: Sort headers.
5948         * csky-linux-tdep.c: Sort headers.
5949         * cris-tdep.c: Sort headers.
5950         * cris-linux-tdep.c: Sort headers.
5951         * cp-valprint.c: Sort headers.
5952         * cp-support.c: Sort headers.
5953         * cp-namespace.c: Sort headers.
5954         * cp-abi.c: Sort headers.
5955         * corelow.c: Sort headers.
5956         * corefile.c: Sort headers.
5957         * continuations.c: Sort headers.
5958         * completer.h: Sort headers.
5959         * completer.c: Sort headers.
5960         * complaints.c: Sort headers.
5961         * coffread.c: Sort headers.
5962         * coff-pe-read.c: Sort headers.
5963         * cli-out.h: Sort headers.
5964         * cli-out.c: Sort headers.
5965         * charset.c: Sort headers.
5966         * c-varobj.c: Sort headers.
5967         * c-valprint.c: Sort headers.
5968         * c-typeprint.c: Sort headers.
5969         * c-lang.c: Sort headers.
5970         * buildsym.c: Sort headers.
5971         * buildsym-legacy.c: Sort headers.
5972         * build-id.h: Sort headers.
5973         * build-id.c: Sort headers.
5974         * btrace.c: Sort headers.
5975         * bsd-uthread.c: Sort headers.
5976         * breakpoint.h: Sort headers.
5977         * breakpoint.c: Sort headers.
5978         * break-catch-throw.c: Sort headers.
5979         * break-catch-syscall.c: Sort headers.
5980         * break-catch-sig.c: Sort headers.
5981         * blockframe.c: Sort headers.
5982         * block.c: Sort headers.
5983         * bfin-tdep.c: Sort headers.
5984         * bfin-linux-tdep.c: Sort headers.
5985         * bfd-target.c: Sort headers.
5986         * bcache.c: Sort headers.
5987         * ax-general.c: Sort headers.
5988         * ax-gdb.h: Sort headers.
5989         * ax-gdb.c: Sort headers.
5990         * avr-tdep.c: Sort headers.
5991         * auxv.c: Sort headers.
5992         * auto-load.c: Sort headers.
5993         * arm-wince-tdep.c: Sort headers.
5994         * arm-tdep.c: Sort headers.
5995         * arm-symbian-tdep.c: Sort headers.
5996         * arm-pikeos-tdep.c: Sort headers.
5997         * arm-obsd-tdep.c: Sort headers.
5998         * arm-nbsd-tdep.c: Sort headers.
5999         * arm-nbsd-nat.c: Sort headers.
6000         * arm-linux-tdep.c: Sort headers.
6001         * arm-linux-nat.c: Sort headers.
6002         * arm-fbsd-tdep.c: Sort headers.
6003         * arm-fbsd-nat.c: Sort headers.
6004         * arm-bsd-tdep.c: Sort headers.
6005         * arch-utils.c: Sort headers.
6006         * arc-tdep.c: Sort headers.
6007         * arc-newlib-tdep.c: Sort headers.
6008         * annotate.h: Sort headers.
6009         * annotate.c: Sort headers.
6010         * amd64-windows-tdep.c: Sort headers.
6011         * amd64-windows-nat.c: Sort headers.
6012         * amd64-tdep.c: Sort headers.
6013         * amd64-sol2-tdep.c: Sort headers.
6014         * amd64-obsd-tdep.c: Sort headers.
6015         * amd64-obsd-nat.c: Sort headers.
6016         * amd64-nbsd-tdep.c: Sort headers.
6017         * amd64-nbsd-nat.c: Sort headers.
6018         * amd64-nat.c: Sort headers.
6019         * amd64-linux-tdep.c: Sort headers.
6020         * amd64-linux-nat.c: Sort headers.
6021         * amd64-fbsd-tdep.c: Sort headers.
6022         * amd64-fbsd-nat.c: Sort headers.
6023         * amd64-dicos-tdep.c: Sort headers.
6024         * amd64-darwin-tdep.c: Sort headers.
6025         * amd64-bsd-nat.c: Sort headers.
6026         * alpha-tdep.c: Sort headers.
6027         * alpha-obsd-tdep.c: Sort headers.
6028         * alpha-nbsd-tdep.c: Sort headers.
6029         * alpha-mdebug-tdep.c: Sort headers.
6030         * alpha-linux-tdep.c: Sort headers.
6031         * alpha-linux-nat.c: Sort headers.
6032         * alpha-bsd-tdep.c: Sort headers.
6033         * alpha-bsd-nat.c: Sort headers.
6034         * aix-thread.c: Sort headers.
6035         * agent.c: Sort headers.
6036         * addrmap.c: Sort headers.
6037         * ada-varobj.c: Sort headers.
6038         * ada-valprint.c: Sort headers.
6039         * ada-typeprint.c: Sort headers.
6040         * ada-tasks.c: Sort headers.
6041         * ada-lang.c: Sort headers.
6042         * aarch64-tdep.c: Sort headers.
6043         * aarch64-ravenscar-thread.c: Sort headers.
6044         * aarch64-newlib-tdep.c: Sort headers.
6045         * aarch64-linux-tdep.c: Sort headers.
6046         * aarch64-linux-nat.c: Sort headers.
6047         * aarch64-fbsd-tdep.c: Sort headers.
6048         * aarch64-fbsd-nat.c: Sort headers.
6049         * aarch32-linux-nat.c: Sort headers.
6050
6051 2019-04-04  Tom Tromey  <tom@tromey.com>
6052
6053         * varobj.c (varobj_create): Update.
6054         * rust-exp.y (struct rust_parser) <update_innermost_block,
6055         lookup_symbol>: New methods.
6056         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6057         Rename.
6058         (rust_parser::rust_lookup_type)
6059         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6060         * printcmd.c (display_command, do_one_display): Update.
6061         * parser-defs.h (struct parser_state) <parser_state>: Add
6062         "tracker" parameter.
6063         (block_tracker): New member.
6064         (class innermost_block_tracker) <innermost_block_tracker>: Add
6065         "types" parameter.
6066         <reset>: Remove method.
6067         (innermost_block): Don't declare.
6068         (null_post_parser): Update.
6069         * parse.c (innermost_block): Remove global.
6070         (write_dollar_variable): Update.
6071         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6072         Remove "tracker_types" parameter.
6073         (parse_expression): Add "tracker" parameter.
6074         (parse_expression_for_completion): Update.
6075         (null_post_parser): Add "tracker" parameter.
6076         * p-exp.y: Update rules.
6077         * m2-exp.y: Update rules.
6078         * language.h (struct language_defn) <la_post_parser>: Add
6079         "tracker" parameter.
6080         * go-exp.y: Update rules.
6081         * f-exp.y: Update rules.
6082         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6083         parameter.
6084         * d-exp.y: Update rules.
6085         * c-exp.y: Update rules.
6086         * breakpoint.c (set_breakpoint_condition): Create an
6087         innermost_block_tracker.
6088         (watch_command_1): Likewise.
6089         * ada-lang.c (resolve): Add "tracker" parameter.
6090         (resolve_subexp): Likewise.
6091         * ada-exp.y (write_var_from_sym): Update.
6092
6093 2019-04-04  Tom Tromey  <tom@tromey.com>
6094
6095         * type-stack.h: New file.
6096         * type-stack.c: New file.
6097         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6098         type-stack.h.
6099         (insert_into_type_stack, insert_type, push_type, push_type_int)
6100         (insert_type_address_space, pop_type, pop_type_int)
6101         (pop_typelist, pop_type_stack, append_type_stack)
6102         (push_type_stack, get_type_stack, push_typelist)
6103         (follow_type_instance_flags, follow_types): Don't declare.
6104         * parse.c (type_stack): Remove global.
6105         (parse_exp_in_context): Update.
6106         (insert_into_type_stack, insert_type, push_type, push_type_int)
6107         (insert_type_address_space, pop_type, pop_type_int)
6108         (pop_typelist, pop_type_stack, append_type_stack)
6109         (push_type_stack, get_type_stack, push_typelist)
6110         (follow_type_instance_flags, follow_types): Remove (moved to
6111         type-stack.c).
6112         * f-exp.y (type_stack): New global.
6113         Update rules.
6114         (push_kind_type, f_parse): Update.
6115         * d-exp.y (type_stack): New global.
6116         Update rules.
6117         (d_parse): Update.
6118         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6119         Update rules.
6120         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6121         (HFILES_NO_SRCDIR): Add type-stack.h.
6122
6123 2019-04-04  Tom Tromey  <tom@tromey.com>
6124
6125         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6126         (rust_parser::convert_ast_to_expression, rust_parse)
6127         (rust_lex_test_completion, rust_lex_tests): Update.
6128         * parser-defs.h (struct expr_completion_state): New.
6129         (struct parser_state) <parser_state>: Add completion parameter.
6130         <mark_struct_expression, mark_completion_tag>: New methods.
6131         <parse_completion, m_completion_state>: New members.
6132         (prefixify_expression, null_post_parser): Update.
6133         (mark_struct_expression, mark_completion_tag): Don't declare.
6134         * parse.c (parse_completion, expout_last_struct)
6135         (expout_tag_completion_type, expout_completion_name): Remove
6136         globals.
6137         (parser_state::mark_struct_expression)
6138         (parser_state::mark_completion_tag): Now methods.
6139         (prefixify_expression): Add last_struct parameter.
6140         (prefixify_subexp): Likewise.
6141         (parse_exp_1): Update.
6142         (parse_exp_in_context): Add cstate parameter.  Update.
6143         (parse_expression_for_completion): Create an
6144         expr_completion_state.
6145         (null_post_parser): Add "completion" parameter.
6146         * p-exp.y: Update rules.
6147         (yylex): Update.
6148         * language.h (struct language_defn) <la_post_parser>: Add
6149         "completing" parameter.
6150         * go-exp.y: Update rules.
6151         (lex_one_token): Update.
6152         * expression.h (parse_completion): Don't declare.
6153         * d-exp.y: Update rules.
6154         (lex_one_token): Update rules.
6155         * c-exp.y: Update rules.
6156         (lex_one_token): Update.
6157         * ada-lang.c (resolve): Add "parse_completion" parameter.
6158         (resolve_subexp): Likewise.
6159         (ada_resolve_function): Likewise.
6160
6161 2019-04-04  Tom Tromey  <tom@tromey.com>
6162
6163         * parser-defs.h (struct parser_state) <start_arglist,
6164         end_arglist>: New methods.
6165         <arglist_len, m_funcall_chain>: New members.
6166         (arglist_len, start_arglist, end_arglist): Don't declare.
6167         * parse.c (arglist_len, funcall_chain): Remove global.
6168         (start_arglist, end_arglist): Remove functions.
6169         (parse_exp_in_context): Update.
6170         * p-exp.y: Update rules.
6171         * m2-exp.y: Update rules.
6172         * go-exp.y: Update rules.
6173         * f-exp.y: Update rules.
6174         * d-exp.y: Update rules.
6175         * c-exp.y: Update rules.
6176
6177 2019-04-04  Tom Tromey  <tom@tromey.com>
6178
6179         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6180         lex_operator, push_back>: New methods.
6181         Update all rules.
6182         (rust_parser::lex_hex, lex_escape): Rename and update.
6183         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6184         (rust_parser::lex_operator): Rename and update.
6185         (rust_parser::lex_number, rustyylex, rustyyerror)
6186         (rust_lex_test_init, rust_lex_test_sequence)
6187         (rust_lex_test_push_back, rust_lex_tests): Update.
6188         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6189         parameter.
6190         <lexptr, prev_lexptr>: New members.
6191         (lexptr, prev_lexptr): Don't declare.
6192         * parse.c (lexptr, prev_lexptr): Remove globals.
6193         (parse_exp_in_context): Update.
6194         * p-exp.y (yylex, yyerror): Update.
6195         * m2-exp.y (parse_number, yylex, yyerror): Update.
6196         * go-exp.y (lex_one_token, yyerror): Update.
6197         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6198         * d-exp.y (lex_one_token, yyerror): Update.
6199         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6200         (lex_one_token, yyerror): Update.
6201         * ada-lex.l (YY_INPUT): Update.
6202         (rewind_to_char): Update.
6203         * ada-exp.y (yyerror): Update.
6204
6205 2019-04-04  Tom Tromey  <tom@tromey.com>
6206
6207         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6208         * parser-defs.h (struct parser_state) <parser_state>: Add new
6209         parameter.
6210         <comma_terminates>: New member.
6211         (comma_terminates): Don't declare global.
6212         * parse.c (comma_terminates): Remove global.
6213         (parse_exp_in_context): Update.
6214         * p-exp.y (yylex): Update.
6215         * m2-exp.y (yylex): Update.
6216         * go-exp.y (lex_one_token): Update.
6217         * f-exp.y (yylex): Update.
6218         * d-exp.y (lex_one_token): Update.
6219         * c-exp.y (lex_one_token): Update.
6220         * ada-lex.l: Update.
6221
6222 2019-04-04  Tom Tromey  <tom@tromey.com>
6223
6224         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6225         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6226         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6227         * parser-defs.h (paren_depth): Don't declare.
6228         * parse.c (paren_depth): Remove global.
6229         (parse_exp_in_context): Update.
6230         * p-exp.y (paren_depth): New global.
6231         (pascal_parse): Initialize it.
6232         * m2-exp.y (paren_depth): New global.
6233         (m2_parse): Initialize it.
6234         * go-exp.y (paren_depth): New global.
6235         (go_parse): Initialize it.
6236         * f-exp.y (paren_depth): New global.
6237         (f_parse): Initialize it.
6238         * d-exp.y (paren_depth): New global.
6239         (d_parse): Initialize it.
6240         * c-exp.y (paren_depth): New global.
6241         (c_parse): Initialize it.
6242         * ada-lex.l (paren_depth): New global.
6243         (lexer_init): Initialize it.
6244
6245 2019-04-04  Tom Tromey  <tom@tromey.com>
6246
6247         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6248         (rust_parser::convert_ast_to_type)
6249         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6250         * parser-defs.h (struct parser_state) <parser_state>: Add
6251         parameters.  Initialize new members.
6252         <expression_context_block, expression_context_pc>: New members.
6253         * parse.c (expression_context_block, expression_context_pc):
6254         Remove globals.
6255         (parse_exp_in_context): Update.
6256         * p-exp.y: Update all rules.
6257         (yylex): Update.
6258         * m2-exp.y: Update all rules.
6259         (yylex): Update.
6260         * go-exp.y (yylex): Update.
6261         * f-exp.y (yylex): Update.
6262         * d-exp.y: Update all rules.
6263         (yylex): Update.
6264         * c-exp.y: Update all rules.
6265         (lex_one_token, classify_name, yylex, c_parse): Update.
6266         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6267
6268 2019-04-04  Tom Tromey  <tom@tromey.com>
6269
6270         * gdbarch.h, gdbarch.c: Rebuild.
6271         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6272         * stap-probe.h:
6273         (struct stap_parse_info): Replace "parser_state" with
6274         "expr_builder".
6275         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6276         (parser_state): New class.
6277         * parse.c (expr_builder): Rename.
6278         (expr_builder::release): Rename.
6279         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6280         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6281         (write_exp_elt_longcst, write_exp_elt_floatcst)
6282         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6283         (write_exp_string_vector, write_exp_bitstring)
6284         (write_exp_msymbol, mark_struct_expression)
6285         (write_dollar_variable)
6286         (insert_type_address_space, increase_expout_size): Replace
6287         "parser_state" with "expr_builder".
6288         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6289         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6290         "parser_state" with "expr_builder".
6291
6292 2019-04-04  Tom Tromey  <tom@tromey.com>
6293
6294         * rust-exp.y: Replace "parse_language" with method call.
6295         * p-exp.y:
6296         (yylex): Replace "parse_language" with method call.
6297         * m2-exp.y:
6298         (yylex): Replace "parse_language" with method call.
6299         * go-exp.y (classify_name): Replace "parse_language" with method
6300         call.
6301         * f-exp.y (yylex): Replace "parse_language" with method call.
6302         * d-exp.y (lex_one_token): Replace "parse_language" with method
6303         call.
6304         * c-exp.y:
6305         (lex_one_token, classify_name, yylex): Replace "parse_language"
6306         with method call.
6307         * ada-exp.y (find_primitive_type, type_char)
6308         (type_system_address): Replace "parse_language" with method call.
6309
6310 2019-04-04  Tom Tromey  <tom@tromey.com>
6311
6312         * rust-exp.y: Replace "parse_gdbarch" with method call.
6313         * parse.c (write_dollar_variable, insert_type_address_space):
6314         Replace "parse_gdbarch" with method call.
6315         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6316         call.
6317         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6318         call.
6319         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6320         "parse_gdbarch" with method call.
6321         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6322         with method call.
6323         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6324         "parse_gdbarch" with method call.
6325         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6326         "parse_gdbarch" with method call.
6327         * c-exp.y (parse_type, parse_number, classify_name): Replace
6328         "parse_gdbarch" with method call.
6329         * ada-lex.l: Replace "parse_gdbarch" with method call.
6330         * ada-exp.y (parse_type, find_primitive_type, type_char)
6331         (type_system_address): Replace "parse_gdbarch" with method call.
6332
6333 2019-04-04  Tom Tromey  <tom@tromey.com>
6334
6335         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6336         * stap-probe.c (stap_parse_argument): Update.
6337         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6338         initial_size parameter.
6339         * rust-exp.y (rust_lex_tests): Update.
6340         * parse.c (parser_state): Update.
6341         (parse_exp_in_context): Update.
6342         * parser-defs.h (struct parser_state) <parser_state>: Remove
6343         "initial_size" parameter.
6344
6345 2019-04-04  Tom Tromey  <tom@tromey.com>
6346
6347         * parser-defs.h (increase_expout_size): Don't declare.
6348         * parse.c (increase_expout_size): Now static.
6349
6350 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6351
6352         * gnu-nat.c (gnu_nat_target::wait): Fix
6353         target_waitstatus_to_string call.
6354
6355 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6356
6357         * eval.c (evaluate_subexp_standard): Handle internal functions
6358         during Fortran function call handling.
6359
6360 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6361
6362         * NEWS: Mention new internal functions.
6363         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6364         (read_base_type): Use dwarf2_init_complex_target_type.
6365         * value.c (creal_internal_fn): New function.
6366         (cimag_internal_fn): New function.
6367         (_initialize_values): Register new internal functions.
6368
6369 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6370
6371         * infrun.c (stop_all_threads): If debug_infrun, always
6372         trace the wait status after wait_one, using
6373         target_waitstatus_to_string and target_pid_to_str.
6374         (handle_inferior_event): Replace various trace of
6375         wait status kind by a single trace.
6376         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6377         wait status kind image by target_waitstatus_to_string.
6378         * target/waitstatus.c (target_waitstatus_to_string): Fix
6379         obsolete comment.
6380
6381 2019-04-01  Tom Tromey  <tromey@adacore.com>
6382
6383         PR symtab/23331:
6384         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6385
6386 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6387             Pedro Alves  <palves@redhat.com>
6388
6389         * top.c (quit_force): Call 'finalize_values'.
6390         * value.c (finalize_values): New function.
6391         * value.h (finalize_values): Declare.
6392
6393 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6394
6395         * NEWS: Announce $_gdb_major and $_gdb_minor.
6396
6397         * top.c (init_gdb_version_vars): New function.
6398         (gdb_init): Call init_gdb_version_vars.
6399
6400 2019-03-29  Tom Tromey  <tromey@adacore.com>
6401
6402         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6403         help text.  Remove dead code.
6404
6405 2019-03-29  Keith Seitz  <keiths@redhat.com>
6406
6407         From Siddhesh Poyarekar:
6408         * f-lang.h (f77_get_upperbound): Return LONGEST.
6409         (f77_get_lowerbound): Likewise.
6410         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6411         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6412         print them.
6413         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6414         plongest to format print it.
6415         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6416         (f77_get_upperbound): Likewise.
6417         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6418         LOWER_BOUND to LONGEST.
6419         (f77_create_arrayprint_offset_tbl): Likewise.
6420
6421 2019-03-29  Keith Seitz  <keiths@redhat.com>
6422
6423         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6424         %s/pulongest for TYPE_LENGTH instead of %d in format
6425         strings.
6426         * ada-typerint.c (ada_print_type): Likewise.
6427         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6428         * compile/compile-c-support.c (generate_register_struct): Likewise.
6429         * gdbtypes.c (recursive_dump_type): Likewise.
6430         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6431         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6432         instead of %d in format strings.
6433         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6434         to std::min to ULONGEST.
6435         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6436         instead of %d in format strings.
6437         * tracepoint.c (info_scope_command): Likewise.
6438         * typeprint.c (print_offset_data::update)
6439         (print_offset_data::finish): Likewise.
6440         * xtensa-tdep.c (xtensa_store_return_value)
6441         (xtensa_push_dummy_call): Likewise.
6442
6443 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6444
6445         * windows-nat.c (display_selector): Fixed format specifications
6446         for 64-bit Cygwin.
6447
6448 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6449
6450         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6451
6452 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6453
6454         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6455         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6456         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6457         (nios2_linux_init_abi): Install it.
6458
6459 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6460
6461         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6462
6463 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6464
6465         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6466
6467 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6468             Tom Tromey  <tromey@adacore.com>
6469
6470         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6471
6472 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6473
6474         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6475         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6476         method to compute the bounds of range types. Also print "[evaluated]"
6477         if the bounds' values come from a dynamic evaluation.
6478
6479 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6480
6481         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6482         whitespace when pretty printing is on.
6483
6484 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6485
6486         * ppc-linux-nat.c: Add include.
6487
6488 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6489
6490         * NEWS: Mention AArch64 Pointer Authentication.
6491
6492 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6493
6494         * arm-linux-nat.c: Add include.
6495
6496 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6497
6498         * source-cache.c (source_cache::get_source_lines): Re-read
6499         fullname after calling open_source_file.
6500
6501 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6502
6503         * NEWS: Mention TLS support for FreeBSD.
6504
6505 2019-03-25  Tom Tromey  <tromey@adacore.com>
6506
6507         * minsyms.c (BUNCH_SIZE): Update comment.
6508         (~minimal_symbol_reader): Remove old comment.
6509         (compact_minimal_symbols): Update comment.
6510         (minimal_symbol_reader::install): Remove old comment.  Update
6511         other comments.
6512
6513 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6514
6515         * s390-linux-nat.c: Add include.
6516
6517 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6518
6519         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6520         Call linux_get_hwcap.
6521         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6522         Likewise.
6523         (aarch64_linux_get_hwcap): Remove function.
6524         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6525         declaration.
6526         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6527         linux_get_hwcap.
6528         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6529         * linux-tdep.c (linux_get_hwcap): Add function.
6530         (linux_get_hwcap2): Likewise.
6531         * linux-tdep.h (linux_get_hwcap): Add declaration.
6532         (linux_get_hwcap2): Likewise.
6533         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6534         (ppc_linux_get_hwcap2): Likewise.
6535         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6536         linux_get_hwcap.
6537         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6538         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6539         (ppc_linux_nat_target::read_description): Likewise.
6540         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6541         * s390-linux-nat.c: Likewise.
6542         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6543
6544 2019-03-24  Tom Tromey  <tom@tromey.com>
6545
6546         * ada-lang.c (standard_lookup): Simplify initialization.
6547         (ada_lookup_symbol_nonlocal): Simplify return.
6548         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6549         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6550         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6551         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6552         initialization.
6553         * solib.c (solib_global_lookup): Simplify.
6554         * symtab.c (null_block_symbol): Remove.
6555         (symbol_cache_lookup): Simplify returns.
6556         (lookup_language_this): Simplify returns.
6557         (lookup_symbol_aux): Simplify return.
6558         (lookup_local_symbol): Simplify returns.
6559         (lookup_global_symbol_from_objfile): Simplify return.
6560         (lookup_symbol_in_objfile_symtabs)
6561         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6562         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6563         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6564         * cp-namespace.c (cp_lookup_bare_symbol)
6565         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6566         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6567         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6568         (cp_lookup_symbol_via_imports): Simplify initialization.
6569         (find_symbol_in_baseclass): Likewise.
6570         * symtab.h (null_block_symbol): Remove.
6571         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6572         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6573         (d_lookup_symbol_module): Likewise.
6574         (find_symbol_in_baseclass): Simplify initialization.
6575
6576 2019-03-24  Tom Tromey  <tom@tromey.com>
6577
6578         * expression.h: Don't include symtab.h.
6579         (struct block): Forward declare.
6580
6581 2019-03-24  Tom Tromey  <tom@tromey.com>
6582
6583         * c-exp.y (typebase): Remove casts.
6584         * gdbtypes.c (lookup_unsigned_typename, )
6585         (lookup_signed_typename): Remove cast.
6586         * eval.c (parse_to_comma_and_eval): Remove cast.
6587         * parse.c (write_dollar_variable): Remove cast.
6588         * block.h (struct block) <superblock>: Now const.
6589         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6590         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6591         (map_block): Make "block" const.
6592         * symfile.h (struct quick_symbol_functions)
6593         <map_matching_symbols>: Constify block argument to "callback".
6594         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6595         const.
6596         (find_pc_sect_compunit_symtab): Make "b" const.
6597         (find_symbol_at_address): Likewise.
6598         (search_symbols): Likewise.
6599         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6600         (dw2_debug_names_lookup_symbol): Likewise.
6601         (dw2_map_matching_symbols): Update.
6602         * p-valprint.c (pascal_val_print): Remove "block".
6603         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6604         (aux_add_nonlocal_symbols): Make "block" const.
6605         (resolve_subexp): Remove cast.
6606         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6607         const.
6608         (iterate_over_file_blocks): Likewise.
6609         * f-exp.y (%union) <bval>: Remove.
6610         * coffread.c (patch_opaque_types): Make "b" const.
6611         * spu-tdep.c (spu_catch_start): Make "block" const.
6612         * c-valprint.c (print_unpacked_pointer): Remove "block".
6613         * symmisc.c (dump_symtab_1): Make "b" const.
6614         (block_depth): Make "block" const.
6615         * d-exp.y (%union) <bval>: Remove.
6616         * cp-support.h (cp_lookup_rtti_type): Update.
6617         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6618         * psymtab.c (psym_lookup_symbol): Make "block" const.
6619         (maintenance_check_psymtabs): Make "b" const.
6620         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6621         (enumerate_locals, enumerate_args): Update.
6622         * python/py-symtab.c (stpy_global_block): Make "block" const.
6623         (stpy_static_block): Likewise.
6624         * inline-frame.c (block_starting_point_at): Make "new_block"
6625         const.
6626         * block.c (find_block_in_blockvector): Make return type const.
6627         (blockvector_for_pc_sect): Make "b" const.
6628         (find_block_in_blockvector): Make "b" const.
6629
6630 2019-03-23  Tom Tromey  <tom@tromey.com>
6631
6632         * varobj.c (varobj_create): Update.
6633         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6634         * printcmd.c (display_command, do_one_display): Don't reset
6635         innermost_block.
6636         * parser-defs.h (enum innermost_block_tracker_type): Move to
6637         expression.h.
6638         (innermost_block): Update comment.
6639         * parse.c (parse_exp_1): Add tracker_types parameter.
6640         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6641         tracker_types parameter.  Reset innermost_block.
6642         (parse_exp_in_context): Remove.
6643         (parse_expression_for_completion): Update.
6644         * objfiles.c (~objfile): Don't reset expression_context_block or
6645         innermost_block.
6646         * expression.h (enum innermost_block_tracker_type): Move from
6647         parser-defs.h.
6648         (parse_exp_1): Add tracker_types parameter.
6649         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6650         reset innermost_block.
6651
6652 2019-03-23  Tom Tromey  <tom@tromey.com>
6653
6654         * objfiles.h: Include bcache.h.
6655
6656 2019-03-23  Tom Tromey  <tom@tromey.com>
6657
6658         * linespec.c (get_current_search_block): Use
6659         scoped_restore_current_language.
6660         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6661
6662 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6663             Jiong Wang  <jiong.wang@arm.com>
6664
6665         * aarch64-linux-tdep.c
6666         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6667         section.
6668         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6669
6670 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6671             Jiong Wang  <jiong.wang@arm.com>
6672
6673         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6674         instructions.
6675         (aarch64_analyze_prologue_test): Add PACIASP test.
6676         (aarch64_prologue_prev_register): Unmask PC value.
6677
6678 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6679             Jiong Wang  <jiong.wang@arm.com>
6680
6681         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6682         (aarch64_dwarf2_prev_register): Unmask PC value.
6683         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6684         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6685         DW_CFA_AARCH64_negate_ra_state.
6686         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6687
6688 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6689             Jiong Wang  <jiong.wang@arm.com>
6690
6691         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6692         registers.
6693         (aarch64_pseudo_register_name): Likewise.
6694         (aarch64_pseudo_register_type): Likewise.
6695         (aarch64_pseudo_register_reggroup_p): Likewise.
6696         (aarch64_gdbarch_init): Add pauth registers.
6697         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6698         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6699         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6700         (struct gdbarch_tdep): Add regnum for ra_state.
6701
6702 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6703             Jiong Wang  <jiong.wang@arm.com>
6704
6705         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6706
6707 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6708             Jiong Wang  <jiong.wang@arm.com>
6709
6710         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6711         function.
6712         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6713         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6714         (aarch64_gdbarch_init): Add puth registers.
6715         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6716         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6717         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6718
6719 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6720             Jiong Wang  <jiong.wang@arm.com>
6721
6722         * aarch64-linux-nat.c
6723         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6724         * aarch64-linux-tdep.c
6725         (aarch64_linux_core_read_description): Likewise.
6726         (aarch64_linux_get_hwcap): New function.
6727         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6728         (aarch64_linux_get_hwcap): New declaration.
6729
6730 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6731             Jiong Wang  <jiong.wang@arm.com>
6732
6733         * aarch64-linux-nat.c
6734         (aarch64_linux_nat_target::read_description): Add pauth param.
6735         * aarch64-linux-tdep.c
6736         (aarch64_linux_core_read_description): Likewise.
6737         * aarch64-tdep.c (struct target_desc): Add in pauth.
6738         (aarch64_read_description): Add pauth param.
6739         (aarch64_gdbarch_init): Likewise.
6740         * aarch64-tdep.h (aarch64_read_description): Likewise.
6741         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6742         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6743         * features/Makefile: Add new files.
6744         * features/aarch64-pauth.c: New file.
6745         * features/aarch64-pauth.xml: New file.
6746
6747 2019-03-20  Tom Tromey  <tromey@adacore.com>
6748
6749         * infrun.c (handle_inferior_event): Rename from
6750         handle_inferior_event_1.  Create a scoped_value_mark.
6751         (handle_inferior_event): Remove.
6752
6753 2019-03-19  Tom Tromey  <tromey@adacore.com>
6754
6755         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6756         * infrun.h (print_stop_event): Add "displays" parameter.
6757         * infrun.c (print_stop_event): Add "displays" parameter.
6758
6759 2019-03-19  Pedro Alves  <palves@redhat.com>
6760
6761         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6762         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6763         to -1.  Fix TABs vs spaces.
6764         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6765         * tui/tui-out.h (tui_ui_out) Add intro comments.
6766         <m_line, m_start_of_line>: In-class initialize, and add describing
6767         comment.
6768
6769 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6770
6771         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6772         variable names.
6773         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6774
6775 2019-03-18  Pedro Alves  <palves@redhat.com>
6776             Eli Zaretskii <eliz@gnu.org>
6777
6778         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6779         m_line and m_start_of_line.
6780
6781 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6782
6783         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6784         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6785         it returns a newline.  This fixes a regression in TU mode, whereby
6786         the next line is output on the same screen line as the user input.
6787
6788 2019-03-18  Tom Tromey  <tromey@adacore.com>
6789
6790         * minsyms.c (minimal_symbol_reader::install): Remove call to
6791         obstack_blank.
6792
6793 2019-03-18  Pedro Alves  <palves@redhat.com>
6794
6795         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6796         New globals.
6797         (apply_style): New, factored out from ...
6798         (apply_ansi_escape): ... this.  Handle reverse video mode.
6799         (tui_set_reverse_mode): New function.
6800         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6801         * tui/tui-winsource.c (tui_show_source_line): Use
6802         tui_set_reverse_mode instead of setting A_STANDOUT.
6803         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6804         New setter methods.
6805
6806 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6807
6808         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6809         Handle tabs.
6810
6811 2019-03-18  Tom Tromey  <tromey@adacore.com>
6812
6813         * ada-lang.c (empty_array): Add "high" parameter.
6814         (ada_evaluate_subexp): Update.
6815
6816 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6817
6818         * unittests/string_view-selftests.c: Define
6819         _initialize_string_view_selftests unconditionally.
6820
6821 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6822
6823         PR gdb/24350
6824         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6825
6826 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6827
6828         PR gdb/24351
6829         * windows-nat.c (display_selector): Fix format specifiers.
6830
6831 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6832
6833         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6834         tui_refill_source_window instead of tui_refresh_win, to update the
6835         current execution line.  This fixes redisplay of the current line
6836         when stepping through the code with "next" or "step".
6837
6838 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6839
6840         * source-cache.c (source_cache::get_source_lines): Call
6841         find_source_lines to initialize s->nlines.  This fixes vertical
6842         scrolling of TUI source window when the DOWN arrow is pressed.
6843
6844 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6845
6846         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6847         linux-thread-db.c (_initialize_thread_db): Likewise.
6848
6849 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6850
6851         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6852         wclrtoeol in tui_show_source_line".  This reverts changes made in
6853         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6854
6855 2019-03-15  Tom Tromey  <tom@tromey.com>
6856
6857         * symtab.h (struct minimal_symbol): Derive from
6858         general_symbol_info.
6859         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6860         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6861         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6862         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6863         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6864         (MSYMBOL_SEARCH_NAME): Update.
6865         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6866         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6867         * minsyms.c (minimal_symbol_reader::record_full): Update.
6868
6869 2019-03-15  Tom Tromey  <tom@tromey.com>
6870
6871         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6872
6873 2019-03-15  Tom Tromey  <tom@tromey.com>
6874
6875         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6876         unique_xmalloc_ptr.
6877         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6878         Update.
6879         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6880         (build_minimal_symbol_hash_tables)
6881         (minimal_symbol_reader::install): Update.
6882
6883 2019-03-15  Tom Tromey  <tom@tromey.com>
6884
6885         * symtab.c (create_demangled_names_hash): Update.
6886         (symbol_set_names): Update.
6887         * objfiles.h (struct objfile_per_bfd_storage)
6888         <demangled_names_hash>: Now an htab_up.
6889         * objfiles.c (objfile_per_bfd_storage): Simplify.
6890
6891 2019-03-15  Tom Tromey  <tom@tromey.com>
6892
6893         * objfiles.h (struct objfile_per_bfd_storage): Declare
6894         destructor.
6895         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6896         New.
6897         (get_objfile_bfd_data): Use new.  Don't initialize
6898         language_of_main.
6899         (free_objfile_per_bfd_storage): Remove.
6900         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6901
6902 2019-03-15  Tom Tromey  <tom@tromey.com>
6903
6904         * symfile.c (reread_symbols): Update.
6905         * objfiles.c (objfile::objfile): Update.
6906         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6907         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6908         comment.
6909         (minimal_symbol_reader::install): Update.
6910         (terminate_minimal_symbol_table): Remove.
6911         * jit.c (jit_object_close_impl): Update.
6912
6913 2019-03-15  Tom Tromey  <tom@tromey.com>
6914
6915         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6916         initializations.
6917
6918 2019-03-15  Tom Tromey  <tom@tromey.com>
6919
6920         * objfiles.h (struct objfile_per_bfd_storage)
6921         <demangled_hash_languages>: Now a bitset.
6922         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6923         (lookup_minimal_symbol): Update.
6924
6925 2019-03-15  Tom Tromey  <tom@tromey.com>
6926
6927         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6928         Don't return the symbol.
6929         * coffread.c (record_minimal_symbol): Use record_full.
6930
6931 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6932
6933         The MS-Windows port of ncurses fails to switch to a color pair if
6934         one or both of the colors are the implicit default colors.  This
6935         change records the default colors when TUI is initialized, and
6936         then specifies them explicitly when a color pair uses the default
6937         colors.  This allows color styling in TUI mode on MS-Windows.
6938
6939         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6940         ncurses_norm_attr.
6941         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6942         colors in ncurses_norm_attr.
6943         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6944         "none", replace it with the default color recorded in
6945         ncurses_norm_attr.
6946
6947 2019-03-14  Tom Tromey  <tromey@adacore.com>
6948
6949         * source-cache.h (class source_cache) <get_source_lines>: Return
6950         std::string.
6951         * source-cache.c (source_cache::extract_lines): Handle case where
6952         first_pos==npos.  Return std::string.
6953         (source_cache::get_source_lines): Update.
6954
6955 2019-03-14  Tom Tromey  <tromey@adacore.com>
6956
6957         * NEWS: Add item for "style sources" commands.
6958         * source-cache.c (source_cache::get_source_lines): Check
6959         source_styling.
6960         * cli/cli-style.c (source_styling): New global.
6961         (_initialize_cli_style): Add "style sources" commands.
6962         (show_style_sources): New function.
6963         * cli/cli-style.h (source_styling): Declare.
6964
6965 2019-03-14  Pedro Alves  <palves@redhat.com>
6966             Tom Tromey  <tromey@adacore.com>
6967
6968         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6969         * tui/tui-winsource.c (tui_refill_source_window): New function,
6970         from...
6971         (tui_horizontal_source_scroll): ... here.  Move some logic.
6972         * cli/cli-style.c (set_style_enabled): Notify new observable.
6973         * tui/tui-hooks.c (tui_redisplay_source): New function.
6974         (tui_attach_detach_observers): Attach or detach
6975         tui_redisplay_source.
6976         * observable.h (source_styling_changed): New observable.
6977         * observable.c: Define source_styling_changed observable.
6978
6979 2019-03-13  Tom Tromey  <tromey@adacore.com>
6980
6981         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6982         (i386_gnu_nat_target::store_registers): Update.
6983         * target-debug.h (target_debug_print_std_string): New macro.
6984         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6985         * windows-tdep.c (display_one_tib): Update.
6986         * tui/tui-stack.c (tui_make_status_line): Update.
6987         * top.c (print_inferior_quit_action): Update.
6988         * thread.c (thr_try_catch_cmd): Update.
6989         (add_thread_with_info): Update.
6990         (thread_target_id_str): Update.
6991         (thr_try_catch_cmd): Update.
6992         (thread_command): Update.
6993         (thread_find_command): Update.
6994         * record-btrace.c (record_btrace_target::info_record)
6995         (record_btrace_resume_thread, record_btrace_target::resume)
6996         (record_btrace_cancel_resume, record_btrace_step_thread)
6997         (record_btrace_target::wait, record_btrace_target::wait)
6998         (record_btrace_target::wait, record_btrace_target::stop): Update.
6999         * progspace.c (print_program_space): Update.
7000         * process-stratum-target.c
7001         (process_stratum_target::thread_address_space): Update.
7002         * linux-fork.c (linux_fork_mourn_inferior)
7003         (detach_checkpoint_command, info_checkpoints_command)
7004         (linux_fork_context): Update.
7005         (linux_fork_detach): Update.
7006         (class scoped_switch_fork_info): Update.
7007         (delete_checkpoint_command): Update.
7008         * infrun.c (follow_fork_inferior): Update.
7009         (follow_fork_inferior): Update.
7010         (proceed_after_vfork_done): Update.
7011         (handle_vfork_child_exec_or_exit): Update.
7012         (follow_exec): Update.
7013         (displaced_step_prepare_throw): Update.
7014         (displaced_step_restore): Update.
7015         (start_step_over): Update.
7016         (resume_1): Update.
7017         (clear_proceed_status_thread): Update.
7018         (proceed): Update.
7019         (print_target_wait_results): Update.
7020         (do_target_wait): Update.
7021         (context_switch): Update.
7022         (stop_all_threads): Update.
7023         (restart_threads): Update.
7024         (finish_step_over): Update.
7025         (handle_signal_stop): Update.
7026         (switch_back_to_stepped_thread): Update.
7027         (keep_going_pass_signal): Update.
7028         (print_exited_reason): Update.
7029         (normal_stop): Update.
7030         * inferior.c (inferior_pid_to_str): Change return type.
7031         (print_selected_inferior): Update.
7032         (add_inferior): Update.
7033         (detach_inferior): Update.
7034         * dummy-frame.c (fprint_dummy_frames): Update.
7035         * dcache.c (dcache_info_1): Update.
7036         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7037         (btrace_fetch, btrace_clear): Update.
7038         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7039         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7040         type.
7041         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7042         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7043         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7044         * gdbarch.c, gdbarch.h: Rebuild.
7045         * gdbarch.sh (core_pid_to_str): Change return type.
7046         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7047         return type.
7048         (windows_nat_target::pid_to_str): Change return type.
7049         (windows_delete_thread): Update.
7050         (windows_nat_target::attach): Update.
7051         (windows_nat_target::files_info): Update.
7052         * target-delegates.c: Rebuild.
7053         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7054         return type.
7055         (sol_thread_target::pid_to_str): Change return type.
7056         * remote.c (class remote_target) <pid_to_str>: Change return
7057         type.
7058         (remote_target::pid_to_str): Change return type.
7059         (extended_remote_target::attach, remote_target::remote_stop_ns)
7060         (remote_target::remote_notif_remove_queued_reply)
7061         (remote_target::push_stop_reply, remote_target::disable_btrace):
7062         Update.
7063         (extended_remote_target::attach): Update.
7064         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7065         type.
7066         (gdbsim_target::pid_to_str): Change return type.
7067         * ravenscar-thread.c (struct ravenscar_thread_target)
7068         <pid_to_str>: Change return type.
7069         (ravenscar_thread_target::pid_to_str): Change return type.
7070         * procfs.c (class procfs_target) <pid_to_str>: Change return
7071         type.
7072         (procfs_target::pid_to_str): Change return type.
7073         (procfs_target::attach): Update.
7074         (procfs_target::detach): Update.
7075         (procfs_target::fetch_registers): Update.
7076         (procfs_target::store_registers): Update.
7077         (procfs_target::wait): Update.
7078         (procfs_target::files_info): Update.
7079         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7080         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7081         return type.
7082         (nto_procfs_target::pid_to_str): Change return type.
7083         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7084         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7085         return type.
7086         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7087         (exit_lwp): Update.
7088         (attach_proc_task_lwp_callback, get_detach_signal)
7089         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7090         (linux_nat_target::resume, wait_lwp, stop_callback)
7091         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7092         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7093         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7094         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7095         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7096         type.
7097         (inf_ptrace_target::attach): Update.
7098         (inf_ptrace_target::files_info): Update.
7099         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7100         type.
7101         (go32_nat_target::pid_to_str): Change return type.
7102         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7103         (gnu_nat_target::wait): Update.
7104         (gnu_nat_target::wait): Update.
7105         (gnu_nat_target::resume): Update.
7106         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7107         (fbsd_nat_target::wait): Update.
7108         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7109         type.
7110         (darwin_nat_target::attach): Update.
7111         * corelow.c (class core_target) <pid_to_str>: Change return type.
7112         (core_target::pid_to_str): Change return type.
7113         * target.c (normal_pid_to_str): Change return type.
7114         (default_pid_to_str): Likewise.
7115         (target_pid_to_str): Change return type.
7116         (target_translate_tls_address): Update.
7117         (target_announce_detach): Update.
7118         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7119         return type.
7120         (bsd_uthread_target::pid_to_str): Change return type.
7121         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7122         type.
7123         (bsd_kvm_target::pid_to_str): Change return type.
7124         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7125         return type.
7126         (aix_thread_target::pid_to_str): Change return type.
7127         * target.h (struct target_ops) <pid_to_str>: Change return type.
7128         (target_pid_to_str, normal_pid_to_str): Likewise.
7129         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7130         type.
7131         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7132         type.
7133         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7134         return type.
7135         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7136         type.
7137         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7138         type.
7139         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7140         return type.
7141
7142 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7143
7144         * NEWS: Mention that the new default MI version is 3.  Mention
7145         changes to the output of commands and events that deal with
7146         multi-location breakpoints.
7147         * breakpoint.c: Include "mi/mi-out.h".
7148         (print_one_breakpoint): Change output syntax if using MI version
7149         >= 3.
7150         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7151         New.
7152         (mi_multi_location_breakpoint_output_fixed): New.
7153         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7154         (mi_cmd_fix_multi_location_breakpoint_output): New.
7155         (mi_multi_location_breakpoint_output_fixed): New.
7156         * mi/mi-cmds.c (mi_cmds): Register command
7157         -fix-multi-location-breakpoint-output.
7158         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7159         interpreter "mi".
7160
7161 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7162
7163         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7164         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7165         instantiate mi_ui_out based on interpreter name.
7166         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7167         * mi/mi-main.c (mi_load_progress): Likewise.
7168
7169 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7170
7171         * NEWS: Combine separate "New targets" sections for 8.3.
7172
7173 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7174
7175         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7176         (ppcfbsd_init_abi): Install gdbarch
7177         "fetch_tls_load_module_address" and "get_thread_local_address"
7178         methods.
7179
7180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7181
7182         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7183         (riscv_fbsd_init_abi): Install gdbarch
7184         "fetch_tls_load_module_address" and "get_thread_local_address"
7185         methods.
7186
7187 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7188
7189         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7190         (i386fbsd_init_abi): Install gdbarch
7191         "fetch_tls_load_module_address" and "get_thread_local_address"
7192         methods.
7193
7194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7195
7196         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7197         (amd64fbsd_init_abi): Install gdbarch
7198         "fetch_tls_load_module_address" and "get_thread_local_address"
7199         methods.
7200
7201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7202
7203         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7204         (struct fbsd_pspace_data): New type.
7205         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7206         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7207         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7208         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7209         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7210
7211 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7212
7213         * gdbtypes.c (lookup_struct_elt): New function.
7214         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7215         * gdbtypes.h (struct struct_elt): New type.
7216         (lookup_struct_elt): New prototype.
7217
7218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7219
7220         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7221         remove disabled code block.
7222
7223 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7224
7225         * gdbarch.sh (get_thread_local_address): New method.
7226         * gdbarch.h, gdbarch.c: Regenerate.
7227         * target.c (target_translate_tls_address): Use
7228         gdbarch_get_thread_local_address if present instead of
7229         target::get_thread_local_address.
7230
7231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7232
7233         * target.h (target::get_thread_local_address): Update comment.
7234
7235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7236
7237         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7238         objfile->separate_debug_objfile_backlink if not NULL.
7239
7240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7241
7242         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7243         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7244         (amd64bsd_store_inferior_registers): Likewise.
7245         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7246         Enable segment base registers.
7247         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7248         PT_GETFSBASE and PT_GETGSBASE.
7249         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7250         PT_SETGSBASE.
7251         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7252         segment base registers.
7253         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7254
7255 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7256
7257         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7258         Update calls to i386_target_description to add 'segments'
7259         parameter.
7260         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7261         add segment base registers.
7262         * arch/i386.c (i386_create_target_description): Add 'segments'
7263         parameter to enable segment base registers.
7264         * arch/i386.h (i386_create_target_description): Likewise.
7265         * features/i386/32bit-segments.xml: New file.
7266         * features/i386/32bit-segments.c: Generate.
7267         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7268         call to i386_target_description to add 'segments' parameter.
7269         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7270         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7271         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7272         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7273         if feature is present.
7274         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7275         Add 'segments' parameter to call to i386_target_description.
7276         (i386_target_description): Add 'segments' parameter to enable
7277         segment base registers.
7278         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7279         to call to i386_target_description.
7280         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7281         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7282         Define I386_NUM_REGS.
7283         (i386_target_description): Add 'segments' parameter to enable
7284         segment base registers.
7285
7286 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7287
7288         PR/24325
7289         * source-cache.c: #undef open and close, to avoid unresolved
7290         externals during linking.
7291
7292 2019-03-12  Tom Tromey  <tromey@adacore.com>
7293
7294         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7295         const.  Add initializers.
7296         (_initialize_remote): Don't initialize ptid globals.
7297
7298 2019-03-12  Pedro Alves  <palves@redhat.com>
7299
7300         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7301
7302 2019-03-12  Pedro Alves  <palves@redhat.com>
7303
7304         * cp-name-parser.y (main): Remove unused 'len' variable.
7305
7306 2019-03-12  Tom Tromey  <tromey@adacore.com>
7307
7308         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7309         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7310
7311 2019-03-12  Tom Tromey  <tromey@adacore.com>
7312
7313         * linux-nat.c (iterate_over_lwps): Update.
7314         (stop_callback): Remove parameter.
7315         (stop_wait_callback, detach_callback, resume_set_callback)
7316         (select_singlestep_lwp_callback, set_ignore_sigint)
7317         (status_callback, resumed_callback, resume_clear_callback)
7318         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7319         data parameter.
7320         (linux_nat_target::detach, linux_nat_target::resume)
7321         (linux_stop_and_wait_all_lwps, select_event_lwp)
7322         (linux_nat_filter_event, linux_nat_wait_1)
7323         (linux_nat_target::kill, linux_nat_target::stop)
7324         (linux_nat_target::stop): Update.
7325         (linux_nat_resume_callback): Change type.
7326         (resume_stopped_resumed_lwps, count_events_callback)
7327         (select_event_lwp_callback): Likewise.
7328         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7329         * arm-linux-nat.c (struct update_registers_data): Remove.
7330         (update_registers_callback): Change type.
7331         (arm_linux_insert_hw_breakpoint1): Update.
7332         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7333         parameter.
7334         (x86_linux_dr_set_addr): Update.
7335         (x86_linux_dr_set_control): Update.
7336         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7337         (iterate_over_lwps): Use gdb::function_view.
7338         * nat/aarch64-linux-hw-point.c (struct
7339         aarch64_dr_update_callback_param): Remove.
7340         (debug_reg_change_callback): Change type.
7341         (aarch64_notify_debug_reg_change): Update.
7342         * s390-linux-nat.c (s390_refresh_per_info): Update.
7343
7344 2019-03-11  Tom Tromey  <tromey@adacore.com>
7345
7346         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7347         redundant assignment to "this_cu".
7348
7349 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7350
7351         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7352
7353 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7354
7355         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7356         from...
7357         (rank_one_type): ... this.
7358
7359 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7360
7361         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7362         from...
7363         (rank_one_type): ... this.
7364
7365 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7366
7367         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7368         from...
7369         (rank_one_type): ... this.
7370
7371 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7372
7373         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7374         from...
7375         (rank_one_type): ... this.
7376
7377 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7378
7379         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7380         from...
7381         (rank_one_type): ... this.
7382
7383 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7384
7385         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7386         from...
7387         (rank_one_type): ... this.
7388
7389 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7390
7391         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7392         from...
7393         (rank_one_type): ... this.
7394
7395 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7396
7397         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7398         from...
7399         (rank_one_type): ... this.
7400
7401 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7402
7403         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7404         from...
7405         (rank_one_type): ... this.
7406
7407 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7408
7409         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7410         from...
7411         (rank_one_type): ... this.
7412
7413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7414
7415         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7416         from...
7417         (rank_one_type): ... this.
7418
7419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7420
7421         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7422         from...
7423         (rank_one_type): ... this.
7424
7425 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7426
7427         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7428         inferior-events' shows the example events.
7429
7430 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7431
7432         Support styling on native MS-Windows console
7433
7434         PR/24315
7435         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7436         on MS-Windows if $TERM is not defined.
7437
7438         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7439
7440         * posix-hdep.c (gdb_console_fputs):
7441         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7442         functions.
7443         * ui-file.h (gdb_console_fputs): Add prototype.
7444
7445         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7446         back to fputs only if the former returns zero.
7447
7448 2019-03-07  Tom Tromey  <tom@tromey.com>
7449
7450         * symmisc.c (print_symbol_bcache_statistics): Update.
7451         (print_objfile_statistics): Update.
7452         * symfile.c (allocate_symtab): Update.
7453         * stabsread.c: Don't include bcache.h.
7454         * psymtab.h (struct psymbol_bcache): Don't declare.
7455         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7456         (psymbol_bcache_init, psymbol_bcache_free)
7457         (psymbol_bcache_get_bcache): Don't declare.
7458         * psymtab.c (struct psymbol_bcache): Remove.
7459         (psymtab_storage::psymtab_storage): Update.
7460         (psymtab_storage::~psymtab_storage): Update.
7461         (psymbol_bcache_init, psymbol_bcache_free)
7462         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7463         (add_psymbol_to_bcache): Update.
7464         (allocate_psymtab): Update.
7465         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7466         macro_cache>: No longer pointers.
7467         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7468         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7469         * macrotab.c (macro_bcache): Update.
7470         * macroexp.c: Don't include bcache.h.
7471         * gdbtypes.c (check_types_worklist): Update.
7472         (types_deeply_equal): Remove TRY/CATCH.  Update.
7473         * elfread.c (elf_symtab_read): Update.
7474         * dwarf2read.c: Don't include bcache.h.
7475         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7476         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7477         (print_bcache_statistics, bcache_memory_used): Don't declare.
7478         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7479         methods.  Rename all data members.
7480         * bcache.c (struct bcache): Move to bcache.h.
7481         (bcache::expand_hash_table): Rename from expand_hash_table.
7482         (bcache): Remove.
7483         (bcache::insert): Rename from bcache_full.
7484         (bcache::compare): Rename from bcache_compare.
7485         (bcache_xmalloc): Remove.
7486         (bcache::~bcache): Rename from bcache_xfree.
7487         (bcache::print_statistics): Rename from print_bcache_statistics.
7488         (bcache::memory_used): Rename from bcache_memory_used.
7489
7490 2019-03-07  Pedro Alves  <palves@redhat.com>
7491
7492         * infrun.c (normal_stop): Also check for
7493         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7494
7495 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * f-lang.c (value_from_host_double): Moved to...
7498         * value.c (value_from_host_double): ...here.
7499         * value.h (value_from_host_double): Declare.
7500         * guile/scm-math.c (vlscm_convert_typed_number): Use
7501         value_from_host_double.
7502         (vlscm_convert_number): Likewise.
7503         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7504         * python/py-value.c (convert_value_from_python): Likewise.
7505
7506 2019-03-06  Tom Tromey  <tom@tromey.com>
7507
7508         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7509
7510 2019-03-06  Tom Tromey  <tom@tromey.com>
7511
7512         * utils.h (free_current_contents): Don't declare.
7513         * utils.c (free_current_contents): Remove.
7514
7515 2019-03-06  Tom Tromey  <tom@tromey.com>
7516
7517         * top.c (quit_force): Update.
7518         * main.c (captured_command_loop): Update.
7519         * common/new-op.c (operator new): Update.
7520         * common/common-exceptions.c (struct catcher)
7521         <save_cleanup_chain>: Remove member.
7522         (exceptions_state_mc_init): Update.
7523         (exception_try_scope_entry): Return nullptr.
7524         (exception_try_scope_exit, exception_rethrow)
7525         (throw_exception_sjlj, throw_exception_cxx): Update.
7526         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7527         (all_cleanups, do_cleanups, discard_cleanups)
7528         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7529         (restore_cleanups, restore_final_cleanups): Don't declare.
7530         (do_final_cleanups): Remove parameter.
7531         * common/cleanups.c (cleanup_chain, make_cleanup)
7532         (make_cleanup_dtor, all_cleanups, do_cleanups)
7533         (discard_my_cleanups, discard_cleanups)
7534         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7535         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7536         (null_cleanup): Remove.
7537         (do_final_cleanups): Remove parameter.
7538
7539 2019-03-06  Tom Tromey  <tom@tromey.com>
7540
7541         * remote.c (remote_target::remote_parse_stop_reply): Use
7542         unique_xmalloc_ptr.
7543
7544 2019-03-06  Tom Tromey  <tom@tromey.com>
7545
7546         * stabsread.c (struct stabs_field_info): Rename from field_info.
7547         <list, fnlist>: Add initializers.
7548         <obstack>: New member.
7549         (read_member_functions, read_struct_fields, read_baseclasses):
7550         Allocate on obstack.  Don't use cleanups.
7551         (read_one_struct_field, read_member_functions, read_struct_fields)
7552         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7553         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7554         (read_struct_type): Update.
7555
7556 2019-03-06  Tom Tromey  <tom@tromey.com>
7557
7558         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7559         * common/filestuff.h (make_cleanup_close): Don't declare.
7560         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7561         Remove.
7562
7563 2019-03-06  Tom Tromey  <tom@tromey.com>
7564
7565         * solib-aix.c: Use make_scope_exit.
7566
7567 2019-03-06  Tom Tromey  <tom@tromey.com>
7568
7569         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7570         Use make_scope_exit.
7571
7572 2019-03-06  Tom Tromey  <tom@tromey.com>
7573
7574         * solib-svr4.c (disable_probes_interface): Remove parameter.
7575         (svr4_handle_solib_event): Use make_scope_exit.
7576
7577 2019-03-06  Tom Tromey  <tom@tromey.com>
7578
7579         * remote.c (struct stop_reply_deleter): Remove.
7580         (stop_reply_up): Update.
7581         (struct stop_reply): Derive from notif_event.  Don't typedef.
7582         <regcache>: Now a std::vector.
7583         (stop_reply_xfree): Remove.
7584         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7585         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7586         (remote_target::discard_pending_stop_replies): Use delete.
7587         (remote_target::remote_parse_stop_reply): Update.
7588         (remote_target::process_stop_reply): Update.
7589         * remote-notif.h (struct notif_event): Add virtual destructor.
7590         Remove "dtr" member.
7591         (struct notif_client) <alloc_event>: Return a unique_ptr.
7592         (notif_event_xfree): Don't declare.
7593         (notif_event_up): New typedef.
7594         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7595         (notif_event_xfree, do_notif_event_xfree): Remove.
7596         (remote_notif_state_xfree): Update.
7597
7598 2019-03-06  Tom Tromey  <tom@tromey.com>
7599
7600         * infrun.c (displaced_step_clear_cleanup): Now a
7601         forward_scope_exit type.
7602         (displaced_step_prepare_throw): Update.
7603         (displaced_step_fixup): Update.
7604
7605 2019-03-06  Tom Tromey  <tom@tromey.com>
7606
7607         * inferior.h (class inferior): Update comment.
7608         * gdbthread.h (class thread_info): Update comment.
7609
7610 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7611             Tom Tromey  <tom@tromey.com>
7612
7613         * stabsread.h (struct stab_section_list): Remove.
7614         (coffstab_build_psymtabs): Update.
7615         * dbxread.c (symbuf_sections): Now a std::vector.
7616         (sect_idx): New global.
7617         (fill_symbuf): Update.
7618         (coffstab_build_psymtabs): Change type of stabsects parameter.
7619         Update.
7620         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7621         std::vector.
7622         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7623         (coff_locate_sections): Update.
7624         (coff_symfile_read): Remove cleanups.  Update.
7625         (init_stringtab): Add storage parameter.
7626         (free_stringtab, free_stringtab_cleanup): Remove.
7627         (init_lineno): Add storage parameter.
7628         (free_linetab, free_linetab_cleanup): Remove.
7629
7630 2019-03-06  Pedro Alves  <palves@redhat.com>
7631
7632         * linux-fork.c (fork_info::clobber_regs): Delete.
7633         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7634         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7635         comment.  Adjust.
7636         (scoped_switch_fork_info::scoped_switch_fork_info)
7637         (checkpoint_command, linux_fork_context): Adjust
7638         fork_save_infrun_state calls.
7639
7640 2019-03-06  Pedro Alves  <palves@redhat.com>
7641
7642         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7643         (inf_has_multiple_threads): Return 'bool' and rewrite using
7644         inferior_info::threads().
7645
7646 2019-03-06  Pedro Alves  <palves@redhat.com>
7647
7648         * linux-fork.c: Include <list>.
7649         (fork_list): Now a std::list instance.
7650         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7651         (forks_exist_p, find_last_fork): Adjust.
7652         (new_fork): Delete.
7653         (one_fork_p): New.
7654         (add_fork): Adjust.
7655         (free_fork): Delete, folded into fork_info::~fork_info().
7656         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7657         Adjust.
7658         (init_fork_list): Delete.
7659         (linux_fork_killall, linux_fork_mourn_inferior)
7660         (linux_fork_detach, info_checkpoints_command): Adjust.
7661         (_initialize_linux_fork): No longer call init_fork_list.
7662
7663 2019-03-06  Pedro Alves  <palves@redhat.com>
7664
7665         * linux-fork.c (new_fork): New, split out of ...
7666         (add_fork): ... this.  Return void.  Move "first fork" special
7667         case from here, to ...
7668         (checkpoint_command): ... here.
7669         * linux-linux.h (add_fork): Return void.
7670
7671 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7672
7673         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7674
7675 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7676             Chris January  <chris.january@arm.com>
7677             David Lecomber  <david.lecomber@arm.com>
7678
7679         * f-exp.y: New token, UNOP_INTRINSIC.
7680         (exp): New pattern using UNOP_INTRINSIC token.
7681         (f77_keywords): Add 'abs' keyword.
7682         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7683         (value_from_host_double): New function.
7684         (evaluate_subexp_f): Support UNOP_ABS.
7685
7686 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7687
7688         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7689         types.
7690
7691 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7692
7693         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7694         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7695         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7696
7697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7700
7701 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7702             Chris January  <chris.january@arm.com>
7703
7704         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7705         * f-exp.y: Define 'KIND' token.
7706         (exp): New pattern for KIND expressions.
7707         (ptype): Handle types with a kind extension.
7708         (direct_abs_decl): Extend to spot kind extensions.
7709         (f77_keywords): Add 'kind' to the list.
7710         (push_kind_type): New function.
7711         (convert_to_kind_type): New function.
7712         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7713         * parse.c (operator_length_standard): Likewise.
7714         * parser-defs.h (enum type_pieces): Add tp_kind.
7715         * std-operator.def: Add UNOP_KIND.
7716
7717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7718
7719         * f-exp.y (f_parse): Set yydebug.
7720
7721 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         * f-lang.c (evaluate_subexp_f): New function.
7724         (exp_descriptor_f): New global.
7725         (f_language_defn): Use exp_descriptor_f instead of
7726         exp_descriptor_standard.
7727
7728 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7729
7730         * f-exp.y (struct token): Add comments.
7731         (dot_ops): Remove uppercase versions and the end marker.
7732         (f77_keywords): Likewise.
7733         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7734         entries in the dot_ops array are case insensitive, and use
7735         strncasecmp to compare strings.  Also some whitespace cleanup in
7736         this area.  Similar for the f77_keywords array, except entries in
7737         this list might be case sensitive.
7738
7739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * f-exp.y (struct f77_boolean_val): Add comments.
7742         (boolean_values): Remove uppercase versions, and end marker.
7743         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7744         and use strncasecmp to achieve case insensitivity.  Additionally,
7745         perform whitespace cleanup around this code.
7746
7747 2019-03-06  Tom Tromey  <tromey@adacore.com>
7748
7749         * remote-sim.c (gdbsim_target_open): Use result of
7750         gdb_argv::release.
7751
7752 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7753         Dirk Schubert  <dirk.schubert@arm.com>
7754         Chris January  <chris.january@arm.com>
7755
7756         * eval.c (evaluate_subexp_standard): Call Fortran argument
7757         wrapping logic.
7758         * f-lang.c (struct value): A value which can be passed into a
7759         Fortran function call.
7760         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7761         where appropriate.
7762         (struct type): Value ready for a Fortran function call.
7763         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7764         is needed.
7765         * f-lang.h (fortran_argument_convert): Declaration.
7766         (fortran_preserve_arg_pointer): Declaration.
7767         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7768
7769 2019-03-05  Tom Tromey  <tromey@adacore.com>
7770
7771         * python/py-prettyprint.c (print_string_repr): Remove #if.
7772         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7773
7774 2019-03-05  Tom Tromey  <tromey@adacore.com>
7775
7776         * target.c (the_dummy_target): Move later.  Change type to
7777         "dummy_target".
7778         (initialize_targets): Don't initialize the_dummy_target.
7779
7780 2019-03-05  Tom Tromey  <tromey@adacore.com>
7781
7782         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7783         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7784
7785 2019-03-05  Tom Tromey  <tromey@adacore.com>
7786
7787         * windows-nat.c (windows_nat_target::attach)
7788         (windows_nat_target::detach): Don't call gdb_flush.
7789         * valprint.c (generic_val_print, val_print, val_print_string):
7790         Don't call gdb_flush.
7791         * utils.c (defaulted_query): Don't call gdb_flush.
7792         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7793         * target.c (target_announce_detach): Don't call gdb_flush.
7794         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7795         * remote.c (extended_remote_target::attach): Don't call
7796         gdb_flush.
7797         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7798         * printcmd.c (do_examine): Don't call gdb_flush.
7799         (info_display_command): Don't call gdb_flush.
7800         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7801         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7802         * memattr.c (info_mem_command): Don't call gdb_flush.
7803         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7804         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7805         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7806         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7807         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7808         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7809         (gnu_nat_target::detach): Don't call gdb_flush.
7810         * f-valprint.c (f_val_print): Don't call gdb_flush.
7811         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7812         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7813         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7814         gdb_flush.
7815         * c-valprint.c (c_val_print): Don't call gdb_flush.
7816         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7817
7818 2019-03-05  Tom Tromey  <tromey@adacore.com>
7819
7820         * varobj.c (update_dynamic_varobj_children): Update.
7821         (install_default_visualizer): Use reset, not release.
7822         * value.c (set_internalvar): Update.
7823         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7824         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7825         ATTRIBUTE_UNUSED_RESULT.
7826
7827 2019-03-05  Tom Tromey  <tromey@adacore.com>
7828
7829         * remote.c (class scoped_remote_fd) <release>: Add
7830         ATTRIBUTE_UNUSED_RESULT.
7831
7832 2019-03-05  Tom Tromey  <tromey@adacore.com>
7833
7834         * macroexp.c (struct macro_buffer) <release>: Add
7835         ATTRIBUTE_UNUSED_RESULT.
7836
7837 2019-03-05  Tom Tromey  <tromey@adacore.com>
7838
7839         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7840         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7841         ATTRIBUTE_UNUSED_RESULT.
7842
7843 2019-03-05  Tom Tromey  <tromey@adacore.com>
7844
7845         * common/scoped_fd.h (class scoped_fd) <release>: Add
7846         ATTRIBUTE_UNUSED_RESULT.
7847
7848 2019-03-05  Tom Tromey  <tromey@adacore.com>
7849
7850         * parser-defs.h (struct parser_state) <release>: Add
7851         ATTRIBUTE_UNUSED_RESULT.
7852
7853 2019-03-05  Tom Tromey  <tromey@adacore.com>
7854
7855         * utils.h (class gdb_argv) <release>: Add
7856         ATTRIBUTE_UNUSED_RESULT.
7857         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7858
7859 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7860
7861         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7862         for-loop range, to avoid compiler warnings.
7863
7864         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7865         avoid compiler warnings about unused variables.
7866
7867         * NEWS: Mention end of support for native debugging on MS-Windows
7868         before XP.
7869
7870         PR gdb/24292
7871         * common/netstuff.c:
7872         * gdbserver/gdbreplay.c
7873         * gdbserver/remote-utils.c:
7874         * ser-tcp.c:
7875         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7876         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7877         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7878         'getaddrinfo' and 'freeaddrinfo' were not available before
7879         Windows XP, and mingw.org's MinGW headers by default define
7880         _WIN32_WINNT to 0x500.
7881
7882 2019-03-01  Gary Benson <gbenson@redhat.com>
7883
7884         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7885
7886 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7887             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7888
7889         PR gdb/8527
7890         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7891         set_sigint_trap, clear_sigint_trap.
7892
7893 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7894
7895         * target.c (target_detach): Clear the regcache and the
7896         frame cache.
7897
7898 2019-02-27  Pedro Alves  <palves@redhat.com>
7899
7900         * utils.c (set_screen_size): When we cap the height/width sizes,
7901         tweak the corresponding command variable to show "unlimited":
7902
7903 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7904             Pedro Alves  <palves@redhat.com>
7905
7906         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7907         before calling rl_set_screen_size.
7908
7909 2019-02-27  Tom Tromey  <tromey@adacore.com>
7910
7911         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7912         define.
7913         * python/py-value.c: Remove Python 2.4 workaround.
7914         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7915         workaround.
7916         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7917         Python 2.4 workaround.
7918         * python/python-internal.h: Remove Python 2.4 comment.
7919         (Py_ssize_t): Don't define.
7920         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7921         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7922         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7923         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7924         * python/python.c (do_start_initialization): Remove Python 2.4
7925         workaround.
7926         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7927         (print_children): Remove Python 2.4 workaround.
7928         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7929         workaround.
7930         (CHARBUFFERPROC_NAME): Remove.
7931         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7932         Python 2.4 workaround.
7933
7934 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7935
7936         * NEWS: Note minimum Python version.
7937
7938 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7939
7940         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7941         code from these functions.  Remove corresponding ifdefs.  Use
7942         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7943         Remove gotos and target of gotos.
7944         (infpy_search_memory): Likewise.
7945
7946 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7947
7948         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7949         (hppa_gdbarch_init): Don't register deleted functions with
7950         gdbarch.
7951
7952 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7953
7954         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7955         (h8300_unwind_sp): Delete.
7956         (h8300_dummy_id): Delete.
7957         (h8300_gdbarch_init): Don't register deleted functions with
7958         gdbarch.
7959
7960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7961
7962         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7963         (ft32_unwind_pc): Delete.
7964         (ft32_unwind_sp): Delete.
7965         (ft32_gdbarch_init): Don't register deleted functions with
7966         gdbarch.
7967
7968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7969
7970         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7971         (frv_unwind_pc): Delete.
7972         (frv_unwind_sp): Delete.
7973         (frv_gdbarch_init): Don't register deleted functions with
7974         gdbarch.
7975
7976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7977
7978         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7979         (riscv_unwind_pc): Delete.
7980         (riscv_unwind_sp): Delete.
7981         (riscv_gdbarch_init): Don't register deleted functions with
7982         gdbarch.
7983
7984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7985
7986         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7987         (csky_unwind_pc): Delete.
7988         (csky_unwind_sp): Delete.
7989         (csky_gdbarch_init): Don't register deleted functions with
7990         gdbarch.
7991
7992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7993
7994         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7995         (cris_unwind_pc): Delete.
7996         (cris_unwind_sp): Delete.
7997         (cris_gdbarch_init): Don't register deleted functions with
7998         gdbarch.
7999
8000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8001
8002         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8003         (bfin_unwind_pc): Delete.
8004         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8005
8006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8007
8008         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8009         (arm_unwind_pc): Delete.
8010         (arm_unwind_sp): Delete.
8011         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8012
8013 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8014
8015         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8016         (arc_unwind_pc): Delete.
8017         (arc_unwind_sp): Delete.
8018         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8019
8020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8021
8022         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8023         (alpha_unwind_pc): Delete.
8024         (alpha_gdbarch_init): Don't register deleted functions with
8025         gdbarch.
8026
8027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8028
8029         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8030         (aarch64_unwind_pc): Delete.
8031         (aarch64_unwind_sp): Delete.
8032         (aarch64_gdbarch_init): Don't register deleted functions with
8033         gdbarch.
8034
8035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8036
8037         * gdbtypes.c (type_align): Don't consider static members when
8038         computing structure alignment.
8039
8040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8043         return 0 for other types.
8044         * arch-utils.c (default_type_align): Always return 0.
8045         * gdbarch.h: Regenerate.
8046         * gdbarch.sh (type_align): Extend comment.
8047         * gdbtypes.c (type_align): Add additional comments, always call
8048         gdbarch_type_align before applying the default rules.
8049         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8050         generic code will then apply a suitable default.
8051         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8052         types, return 0 for other types.
8053
8054 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8055
8056         * NEWS: Create a new section for the next release branch.
8057         Rename the section of the current branch, now that it has
8058         been cut.
8059
8060 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8061
8062         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8063         * version.in: Bump version to 8.3.50.DATE-git.
8064
8065 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8066
8067         * aix-thread.c (ptid_cmp): Remove unused variable.
8068         (get_signaled_thread): Likewise.
8069         (store_regs_user_thread): Likewise.
8070         (store_regs_kernel_thread): Likewise.
8071         (fetch_regs_kernel_thread): Remove shadowed variable.
8072
8073 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8074
8075         * features/riscv/32bit-cpu.xml: Add register numbers.
8076         * features/riscv/32bit-fpu.c: Regenerate.
8077         * features/riscv/32bit-fpu.xml: Add register numbers.
8078         * features/riscv/64bit-cpu.xml: Add register numbers.
8079         * features/riscv/64bit-fpu.c: Regenerate.
8080         * features/riscv/64bit-fpu.xml: Add register numbers.
8081
8082 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8083
8084         * NEWS: Mention two argument form of gdb.Value constructor.
8085         * python/py-value.c (convert_buffer_and_type_to_value): New
8086         function.
8087         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8088         Add support for handling an optional second argument.  Call
8089         convert_buffer_and_type_to_value as appropriate.
8090         * python/python-internal.h (Py_buffer_deleter): New struct.
8091         (Py_buffer_up): New typedef.
8092
8093 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8094
8095         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8096         instead of releasing ownership.
8097
8098 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8099
8100         * dwarf2read.c (open_and_init_dwp_file): Call
8101         elf_numsections instead of bfd_count_sections to initialize
8102         dwp_file->num_sections.
8103
8104 2019-02-25  Tom Tromey  <tromey@adacore.com>
8105
8106         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8107
8108 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8109
8110         * gcore.in: Add '--readnever' option when invoking GDB.
8111
8112 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8113
8114         * MAINTAINERS: Update my email address.
8115
8116 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8117
8118         * build-id.c (build_id_to_debug_bfd_1): New function.
8119         (build_id_to_debug_bfd): Look for separate debug file in
8120         sysroot.
8121
8122 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8123
8124         * gdbarch.sh: Update the copyright year range that is placed into
8125         generated files.
8126
8127 2019-02-22  Keith Seitz  <keiths@redhat.com>
8128
8129         PR symtab/23853
8130         * linespec.c (create_sals_line_offset): Search for the default
8131         symtab's filename instead of its fullname.
8132
8133 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8134
8135         * NEWS: Update style defaults.
8136
8137 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8138
8139         * main.c (captured_main_1): Disable styling in batch mode.
8140
8141 2019-02-20  Tom Tromey  <tom@tromey.com>
8142
8143         * symtab.c (symtab_symbol_info): Fix typos.
8144
8145 2019-02-20  Tom Tromey  <tromey@adacore.com>
8146
8147         * findcmd.c (_initialize_mem_search): Use upper case for
8148         metasyntactic variables.
8149
8150 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8151
8152         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8153         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8154
8155 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8156
8157         * top.h (source_file_name): Change to std::string.
8158         * top.c (source_file_name): Likewise.
8159         (command_line_input): Adjust.
8160         * cli/cli-script.c (script_from_file): Adjust.
8161
8162 2019-02-19  Tom Tromey  <tromey@adacore.com>
8163
8164         * ravenscar-thread.c
8165         (ravenscar_thread_target::update_thread_list): Don't call
8166         ada_build_task_list.
8167         * ada-lang.h (ada_build_task_list): Don't declare.
8168         * ada-tasks.c (struct ada_tasks_inferior_data)
8169         <task_list_valid_p>: Now bool.
8170         (read_known_tasks, ada_task_list_changed)
8171         (ada_tasks_invalidate_inferior_data): Update.
8172         (read_known_tasks_array): Return bool.
8173         (read_known_tasks_list): Likewise.
8174         (read_known_tasks): Return void.
8175         (ada_build_task_list): Now static.
8176
8177 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8178
8179         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8180         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8181
8182 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8183
8184         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8185         variant for ada_tasks_pspace_data_handle and
8186         ada_tasks_inferior_data_handle.
8187         (ada_tasks_pspace_data_cleanup): New function.
8188         (ada_tasks_inferior_data_cleanup): New function.
8189
8190 2019-02-17  Tom Tromey  <tom@tromey.com>
8191
8192         * macrotab.h (macro_source_fullname): Return a std::string.
8193         * macrotab.c (macro_include, check_for_redefinition)
8194         (macro_undef, macro_lookup_definition, foreach_macro)
8195         (foreach_macro_in_scope): Update.
8196         (macro_source_fullname): Return a std::string.
8197         * macrocmd.c (show_pp_source_pos): Update.
8198
8199 2019-02-17  Tom Tromey  <tom@tromey.com>
8200
8201         * macrocmd.c (show_pp_source_pos): Style the file names.
8202
8203 2019-02-17  Tom Tromey  <tom@tromey.com>
8204
8205         PR tui/24197:
8206         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8207
8208 2019-02-17  Tom Tromey  <tom@tromey.com>
8209
8210         * ada-lang.c (user_select_syms): Use filtered printing.
8211         * utils.c (wrap_style): New global.
8212         (desired_style): Remove.
8213         (emit_style_escape): Add stream parameter.
8214         (set_output_style, reset_terminal_style, prompt_for_continue):
8215         Update.
8216         (flush_wrap_buffer): Only flush gdb_stdout.
8217         (wrap_here): Set wrap_style.
8218         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8219         treat escape sequences as a character.  Change when wrap buffer is
8220         flushed.
8221         (fputs_styled): Do not set the output style when the default is
8222         requested.
8223         * ui-style.h (struct ui_file_style) <is_default>: New method.
8224         * source.c (print_source_lines_base): Emit escape sequences in one
8225         piece.
8226
8227 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8228
8229         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8230         integers and enumeration types.
8231
8232 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8233
8234         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8235         instead of lookup_symbol_in_language
8236         (do_exact_match): New function.
8237         (ada_get_symbol_name_matcher): Return do_exact_match when
8238         doing a verbatim match.
8239
8240 2019-02-15  Tom Tromey  <tromey@adacore.com>
8241
8242         * ravenscar-thread.c (ravenscar_thread_target::resume)
8243         (ravenscar_thread_target::wait): Special case wildcard requests.
8244
8245 2019-02-15  Tom Tromey  <tromey@adacore.com>
8246
8247         * ravenscar-thread.c (base_ptid): Remove.
8248         (struct ravenscar_thread_target) <close>: New method.
8249         <m_base_ptid>: New member.
8250         <update_inferior_ptid, active_task, task_is_currently_active,
8251         runtime_initialized>: Declare methods.
8252         <ravenscar_thread_target>: Add constructor.
8253         (ravenscar_thread_target::task_is_currently_active)
8254         (ravenscar_thread_target::update_inferior_ptid)
8255         (ravenscar_runtime_initialized): Rename.  Now methods.
8256         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8257         (ravenscar_thread_target::update_thread_list): Update.
8258         (ravenscar_thread_target::active_task): Now method.
8259         (ravenscar_thread_target::store_registers)
8260         (ravenscar_thread_target::prepare_to_store)
8261         (ravenscar_thread_target::prepare_to_store)
8262         (ravenscar_thread_target::mourn_inferior): Update.
8263         (ravenscar_inferior_created): Use "new" to create target.
8264         (ravenscar_thread_target::get_ada_task_ptid): Update.
8265         (_initialize_ravenscar): Don't initialize base_ptid.
8266         (ravenscar_ops): Remove global.
8267
8268 2019-02-15  Tom Tromey  <tromey@adacore.com>
8269
8270         * target.h (push_target): Declare new overload.
8271         * target.c (push_target): New overload, taking an rvalue reference.
8272         * remote.c (remote_target::open_1): Use push_target overload.
8273         * corelow.c (core_target_open): Use push_target overload.
8274
8275 2019-02-15  Tom Tromey  <tromey@adacore.com>
8276
8277         * ravenscar-thread.c (is_ravenscar_task)
8278         (ravenscar_task_is_currently_active): Return bool.
8279         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8280         (_initialize_ravenscar): Remove "(void)".
8281         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8282         Return bool.
8283
8284 2019-02-15  Tom Tromey  <tromey@adacore.com>
8285
8286         * ravenscar-thread.c (ravenscar_runtime_initializer)
8287         (has_ravenscar_runtime, get_running_thread_id)
8288         (ravenscar_thread_target::resume): Fix indentation.
8289
8290 2019-02-15  Tom Tromey  <tromey@adacore.com>
8291
8292         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8293         from ravenscar_arch_ops.
8294         (sparc_ravenscar_ops::fetch_registers)
8295         (sparc_ravenscar_ops::store_registers): Now methods.
8296         (sparc_ravenscar_prepare_to_store): Remove.
8297         (sparc_ravenscar_ops): Redefine.
8298         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8299         methods and destructor.  Remove members.
8300         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8301         (ravenscar_thread_target::store_registers)
8302         (ravenscar_thread_target::prepare_to_store): Update.
8303         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8304         Remove.
8305         (struct ppc_ravenscar_powerpc_ops): Derive from
8306         ravenscar_arch_ops.
8307         (ppc_ravenscar_powerpc_ops::fetch_registers)
8308         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8309         (ppc_ravenscar_powerpc_ops): Redefine.
8310         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8311         (ppc_ravenscar_e500_ops::fetch_registers)
8312         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8313         (ppc_ravenscar_e500_ops): Redefine.
8314         * aarch64-ravenscar-thread.c
8315         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8316         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8317         (aarch64_ravenscar_fetch_registers)
8318         (aarch64_ravenscar_store_registers): Now methods.
8319         (aarch64_ravenscar_ops): Redefine.
8320
8321 2019-02-15  Tom Tromey  <tromey@adacore.com>
8322
8323         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8324         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8325         (ravenscar_thread_target::stopped_by_watchpoint)
8326         (ravenscar_thread_target::stopped_data_address)
8327         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8328
8329 2019-02-15  Tom Tromey  <tromey@adacore.com>
8330
8331         * ravenscar-thread.c: Fix some typos.
8332
8333 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8334             Tom Tromey  <tromey@adacore.com>
8335
8336         * ada-lang.c (ada_exception_sal): Change addr_string to a
8337         std::string.
8338         (create_ada_exception_catchpoint): Update.
8339
8340 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8341             Tom Tromey  <tromey@adacore.com>
8342
8343         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8344         (bp_location_ops): Remove.
8345         (base_breakpoint_allocate_location): Update.
8346         (free_bp_location): Update.
8347         * ada-lang.c (class ada_catchpoint_location)
8348         <ada_catchpoint_location>: Remove ops parameter.
8349         (ada_catchpoint_location_dtor): Remove.
8350         (ada_catchpoint_location_ops): Remove.
8351         (allocate_location_exception): Update.
8352         * breakpoint.h (struct bp_location_ops): Remove.
8353         (class bp_location) <bp_location>: Remove bp_location_ops
8354         parameter.
8355         <~bp_location>: Add destructor.
8356         <ops>: Remove.
8357
8358 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8359             Pedro Alves  <palves@redhat.com>
8360
8361         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8362         'PATH_MAX'.
8363
8364 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8365             Samuel Thibault  <samuel.thibault@gnu.org>
8366             Thomas Schwinge  <thomas@codesourcery.com>
8367
8368         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8369         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8370
8371 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8372
8373         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8374         (check_empty): Use "const char *".
8375
8376         * gnu-nat.c (gnu_nat_target::detach): Instead of
8377         'detach_inferior (pid)' call
8378         'detach_inferior (find_inferior_pid (pid))'.
8379
8380         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8381         'nat/fork-inferior.o'.
8382         * gnu-nat.c: #include "nat/fork-inferior.h".
8383
8384         * gnu-nat.c (gnu_nat_target::detach): Instead of
8385         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8386         * gnu-nat.h: #include "inf-child.h".
8387         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8388         'i386_gnu_nat_target::fetch_registers'.
8389         (gnu_store_registers): Rename/move to
8390         'i386_gnu_nat_target::store_registers'.
8391
8392         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8393         * gnu-nat.h (mach_thread_info): New function.
8394         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8395
8396         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8397
8398 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8399
8400         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8401
8402 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8403
8404         * windows-nat.c (windows_add_thread): Add new parameter
8405         "main_thread_p" with default value set to false.  Update
8406         function documentation as well as all callers.
8407         (windows_delete_thread): Likewise.
8408         (fake_create_process): Update call to windows_add_thread.
8409         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8410         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8411         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8412         call to windows_delete_thread.
8413
8414 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8415
8416         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8417
8418 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8419
8420         * symfile.c (find_separate_debug_file): Use canonical path of
8421         sysroot with child_path instead of gdb_sysroot if it is valid.
8422
8423 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8424
8425         * symfile.c (find_separate_debug_file): Use child_path to
8426         determine if an object file is under a sysroot.
8427
8428 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8429
8430         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8431         unittests/child-path-selftests.c.
8432         * common/pathstuff.c (child_path): New function.
8433         * common/pathstuff.h (child_path): New prototype.
8434         * unittests/child-path-selftests.c: New file.
8435
8436 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8437
8438         * symfile.c (find_separate_debug_file): Look for separate debug
8439         files in debug directories under the sysroot.
8440
8441 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8442
8443         * symtab.h (struct minimal_symbol data_p): New const method.
8444         (struct minimal_symbol text_p): Likewise.
8445         * symtab.c (output_source_filename): Use file name style
8446         to print file name.
8447         (print_symbol_info): Likewise.
8448         (print_msymbol_info): Use address style to print addresses.
8449         Use function name style to print executable text symbols.
8450         (expand_symtab_containing_pc): Use data_p.
8451         (find_pc_sect_compunit_symtab): Likewise.
8452
8453 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8454
8455         * breakpoint.c (describe_other_breakpoints): Use address style
8456         to print addresses.
8457         (say_where): Likewise.
8458
8459 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8460
8461         * ada-typeprint.c (print_func_type): Print function name
8462         style to print function name.
8463         * c-typeprint.c (c_print_type_1): Likewise.
8464
8465 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8466
8467         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8468         for execve.
8469
8470 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8471
8472         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8473         type_stack.
8474
8475 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8476
8477         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8478         TYPE_CODE_REF types.
8479
8480 2019-02-08  Jim Wilson  <jimw@sifive.com>
8481
8482         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8483         (riscv_linux_fregset): New.
8484         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8485
8486 2019-02-07  Tom Tromey  <tom@tromey.com>
8487
8488         * thread.c (thread_cancel_execution_command): Update.
8489         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8490         methods.
8491         (struct thread_fsm_ops): Remove.
8492         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8493         (thread_fsm_should_stop, thread_fsm_return_value)
8494         (thread_fsm_set_finished, thread_fsm_finished_p)
8495         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8496         Don't declare.
8497         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8498         * infrun.c (clear_proceed_status_thread)
8499         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8500         (print_stop_event): Update.
8501         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8502         Add constructor.
8503         (step_command_fsm_ops): Remove.
8504         (new_step_command_fsm): Remove.
8505         (step_1): Update.
8506         (step_command_fsm::should_stop): Rename from
8507         step_command_fsm_should_stop.
8508         (step_command_fsm::clean_up): Rename from
8509         step_command_fsm_clean_up.
8510         (step_command_fsm::do_async_reply_reason): Rename from
8511         step_command_fsm_async_reply_reason.
8512         (struct until_next_fsm): Inherit from thread_fsm.  Add
8513         constructor.
8514         (until_next_fsm_ops): Remove.
8515         (new_until_next_fsm): Remove.
8516         (until_next_fsm::should_stop): Rename from
8517         until_next_fsm_should_stop.
8518         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8519         (until_next_fsm::do_async_reply_reason): Rename from
8520         until_next_fsm_async_reply_reason.
8521         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8522         constructor.  Change type of breakpoint.
8523         (finish_command_fsm_ops): Remove.
8524         (new_finish_command_fsm): Remove.
8525         (finish_command_fsm::should_stop): Rename from
8526         finish_command_fsm_should_stop.
8527         (finish_command_fsm::clean_up): Rename from
8528         finish_command_fsm_clean_up.
8529         (finish_command_fsm::return_value): Rename from
8530         finish_command_fsm_return_value.
8531         (finish_command_fsm::do_async_reply_reason): Rename from
8532         finish_command_fsm_async_reply_reason.
8533         (finish_command): Update.
8534         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8535         Add constructor.
8536         (call_thread_fsm_ops): Remove.
8537         (call_thread_fsm::call_thread_fsm): Rename from
8538         new_call_thread_fsm.
8539         (call_thread_fsm::should_stop): Rename from
8540         call_thread_fsm_should_stop.
8541         (call_thread_fsm::should_notify_stop): Rename from
8542         call_thread_fsm_should_notify_stop.
8543         (run_inferior_call, call_function_by_hand_dummy): Update.
8544         * cli/cli-interp.c (should_print_stop_to_console): Update.
8545         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8546         Add constructor.  Change type of location_breakpoint,
8547         caller_breakpoint.
8548         (until_break_fsm_ops): Remove.
8549         (new_until_break_fsm): Remove.
8550         (until_break_fsm::should_stop): Rename from
8551         until_break_fsm_should_stop.
8552         (until_break_fsm::clean_up): Rename from
8553         until_break_fsm_clean_up.
8554         (until_break_fsm::do_async_reply_reason): Rename from
8555         until_break_fsm_async_reply_reason.
8556         (until_break_command): Update.
8557         * thread-fsm.c: Remove.
8558         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8559
8560 2019-02-07  Tom Tromey  <tom@tromey.com>
8561
8562         * yy-remap.h: Add include guard.
8563         * xtensa-tdep.h: Add include guard.
8564         * xcoffread.h: Rename include guard.
8565         * varobj-iter.h: Add include guard.
8566         * tui/tui.h: Rename include guard.
8567         * tui/tui-winsource.h: Rename include guard.
8568         * tui/tui-wingeneral.h: Rename include guard.
8569         * tui/tui-windata.h: Rename include guard.
8570         * tui/tui-win.h: Rename include guard.
8571         * tui/tui-stack.h: Rename include guard.
8572         * tui/tui-source.h: Rename include guard.
8573         * tui/tui-regs.h: Rename include guard.
8574         * tui/tui-out.h: Rename include guard.
8575         * tui/tui-layout.h: Rename include guard.
8576         * tui/tui-io.h: Rename include guard.
8577         * tui/tui-hooks.h: Rename include guard.
8578         * tui/tui-file.h: Rename include guard.
8579         * tui/tui-disasm.h: Rename include guard.
8580         * tui/tui-data.h: Rename include guard.
8581         * tui/tui-command.h: Rename include guard.
8582         * tic6x-tdep.h: Add include guard.
8583         * target/waitstatus.h: Rename include guard.
8584         * target/wait.h: Rename include guard.
8585         * target/target.h: Rename include guard.
8586         * target/resume.h: Rename include guard.
8587         * target-float.h: Rename include guard.
8588         * stabsread.h: Add include guard.
8589         * rs6000-tdep.h: Add include guard.
8590         * riscv-fbsd-tdep.h: Add include guard.
8591         * regformats/regdef.h: Rename include guard.
8592         * record.h: Rename include guard.
8593         * python/python.h: Rename include guard.
8594         * python/python-internal.h: Rename include guard.
8595         * python/py-stopevent.h: Rename include guard.
8596         * python/py-ref.h: Rename include guard.
8597         * python/py-record.h: Rename include guard.
8598         * python/py-record-full.h: Rename include guard.
8599         * python/py-record-btrace.h: Rename include guard.
8600         * python/py-instruction.h: Rename include guard.
8601         * python/py-events.h: Rename include guard.
8602         * python/py-event.h: Rename include guard.
8603         * procfs.h: Add include guard.
8604         * proc-utils.h: Add include guard.
8605         * p-lang.h: Add include guard.
8606         * or1k-tdep.h: Rename include guard.
8607         * observable.h: Rename include guard.
8608         * nto-tdep.h: Rename include guard.
8609         * nat/x86-linux.h: Rename include guard.
8610         * nat/x86-linux-dregs.h: Rename include guard.
8611         * nat/x86-gcc-cpuid.h: Add include guard.
8612         * nat/x86-dregs.h: Rename include guard.
8613         * nat/x86-cpuid.h: Rename include guard.
8614         * nat/ppc-linux.h: Rename include guard.
8615         * nat/mips-linux-watch.h: Rename include guard.
8616         * nat/linux-waitpid.h: Rename include guard.
8617         * nat/linux-ptrace.h: Rename include guard.
8618         * nat/linux-procfs.h: Rename include guard.
8619         * nat/linux-osdata.h: Rename include guard.
8620         * nat/linux-nat.h: Rename include guard.
8621         * nat/linux-namespaces.h: Rename include guard.
8622         * nat/linux-btrace.h: Rename include guard.
8623         * nat/glibc_thread_db.h: Rename include guard.
8624         * nat/gdb_thread_db.h: Rename include guard.
8625         * nat/gdb_ptrace.h: Rename include guard.
8626         * nat/fork-inferior.h: Rename include guard.
8627         * nat/amd64-linux-siginfo.h: Rename include guard.
8628         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8629         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8630         * nat/aarch64-linux.h: Rename include guard.
8631         * nat/aarch64-linux-hw-point.h: Rename include guard.
8632         * mn10300-tdep.h: Add include guard.
8633         * mips-linux-tdep.h: Add include guard.
8634         * mi/mi-parse.h: Rename include guard.
8635         * mi/mi-out.h: Rename include guard.
8636         * mi/mi-main.h: Rename include guard.
8637         * mi/mi-interp.h: Rename include guard.
8638         * mi/mi-getopt.h: Rename include guard.
8639         * mi/mi-console.h: Rename include guard.
8640         * mi/mi-common.h: Rename include guard.
8641         * mi/mi-cmds.h: Rename include guard.
8642         * mi/mi-cmd-break.h: Rename include guard.
8643         * m2-lang.h: Add include guard.
8644         * location.h: Rename include guard.
8645         * linux-record.h: Rename include guard.
8646         * linux-nat.h: Add include guard.
8647         * linux-fork.h: Add include guard.
8648         * i386-darwin-tdep.h: Rename include guard.
8649         * hppa-linux-offsets.h: Add include guard.
8650         * guile/guile.h: Rename include guard.
8651         * guile/guile-internal.h: Rename include guard.
8652         * gnu-nat.h: Rename include guard.
8653         * gdb-stabs.h: Rename include guard.
8654         * frv-tdep.h: Add include guard.
8655         * f-lang.h: Add include guard.
8656         * event-loop.h: Add include guard.
8657         * darwin-nat.h: Rename include guard.
8658         * cp-abi.h: Rename include guard.
8659         * config/sparc/nm-sol2.h: Rename include guard.
8660         * config/nm-nto.h: Rename include guard.
8661         * config/nm-linux.h: Add include guard.
8662         * config/i386/nm-i386gnu.h: Rename include guard.
8663         * config/djgpp/nl_types.h: Rename include guard.
8664         * config/djgpp/langinfo.h: Rename include guard.
8665         * compile/gcc-cp-plugin.h: Add include guard.
8666         * compile/gcc-c-plugin.h: Add include guard.
8667         * compile/compile.h: Rename include guard.
8668         * compile/compile-object-run.h: Rename include guard.
8669         * compile/compile-object-load.h: Rename include guard.
8670         * compile/compile-internal.h: Rename include guard.
8671         * compile/compile-cplus.h: Rename include guard.
8672         * compile/compile-c.h: Rename include guard.
8673         * common/xml-utils.h: Rename include guard.
8674         * common/x86-xstate.h: Rename include guard.
8675         * common/version.h: Rename include guard.
8676         * common/vec.h: Rename include guard.
8677         * common/tdesc.h: Rename include guard.
8678         * common/selftest.h: Rename include guard.
8679         * common/scoped_restore.h: Rename include guard.
8680         * common/scoped_mmap.h: Rename include guard.
8681         * common/scoped_fd.h: Rename include guard.
8682         * common/safe-iterator.h: Rename include guard.
8683         * common/run-time-clock.h: Rename include guard.
8684         * common/refcounted-object.h: Rename include guard.
8685         * common/queue.h: Rename include guard.
8686         * common/ptid.h: Rename include guard.
8687         * common/print-utils.h: Rename include guard.
8688         * common/preprocessor.h: Rename include guard.
8689         * common/pathstuff.h: Rename include guard.
8690         * common/observable.h: Rename include guard.
8691         * common/netstuff.h: Rename include guard.
8692         * common/job-control.h: Rename include guard.
8693         * common/host-defs.h: Rename include guard.
8694         * common/gdb_wait.h: Rename include guard.
8695         * common/gdb_vecs.h: Rename include guard.
8696         * common/gdb_unlinker.h: Rename include guard.
8697         * common/gdb_unique_ptr.h: Rename include guard.
8698         * common/gdb_tilde_expand.h: Rename include guard.
8699         * common/gdb_sys_time.h: Rename include guard.
8700         * common/gdb_string_view.h: Rename include guard.
8701         * common/gdb_splay_tree.h: Rename include guard.
8702         * common/gdb_setjmp.h: Rename include guard.
8703         * common/gdb_ref_ptr.h: Rename include guard.
8704         * common/gdb_optional.h: Rename include guard.
8705         * common/gdb_locale.h: Rename include guard.
8706         * common/gdb_assert.h: Rename include guard.
8707         * common/filtered-iterator.h: Rename include guard.
8708         * common/filestuff.h: Rename include guard.
8709         * common/fileio.h: Rename include guard.
8710         * common/environ.h: Rename include guard.
8711         * common/common-utils.h: Rename include guard.
8712         * common/common-types.h: Rename include guard.
8713         * common/common-regcache.h: Rename include guard.
8714         * common/common-inferior.h: Rename include guard.
8715         * common/common-gdbthread.h: Rename include guard.
8716         * common/common-exceptions.h: Rename include guard.
8717         * common/common-defs.h: Rename include guard.
8718         * common/common-debug.h: Rename include guard.
8719         * common/cleanups.h: Rename include guard.
8720         * common/buffer.h: Rename include guard.
8721         * common/btrace-common.h: Rename include guard.
8722         * common/break-common.h: Rename include guard.
8723         * cli/cli-utils.h: Rename include guard.
8724         * cli/cli-style.h: Rename include guard.
8725         * cli/cli-setshow.h: Rename include guard.
8726         * cli/cli-script.h: Rename include guard.
8727         * cli/cli-interp.h: Rename include guard.
8728         * cli/cli-decode.h: Rename include guard.
8729         * cli/cli-cmds.h: Rename include guard.
8730         * charset-list.h: Add include guard.
8731         * buildsym-legacy.h: Rename include guard.
8732         * bfin-tdep.h: Add include guard.
8733         * ax.h: Rename include guard.
8734         * arm-linux-tdep.h: Add include guard.
8735         * arm-fbsd-tdep.h: Add include guard.
8736         * arch/xtensa.h: Rename include guard.
8737         * arch/tic6x.h: Add include guard.
8738         * arch/i386.h: Add include guard.
8739         * arch/arm.h: Rename include guard.
8740         * arch/arm-linux.h: Rename include guard.
8741         * arch/arm-get-next-pcs.h: Rename include guard.
8742         * arch/amd64.h: Add include guard.
8743         * arch/aarch64-insn.h: Rename include guard.
8744         * arch-utils.h: Rename include guard.
8745         * annotate.h: Add include guard.
8746         * amd64-darwin-tdep.h: Rename include guard.
8747         * aarch64-linux-tdep.h: Add include guard.
8748         * aarch64-fbsd-tdep.h: Add include guard.
8749         * aarch32-linux-nat.h: Add include guard.
8750
8751 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8752
8753         * macrotab.c (macro_define_internal): New function that
8754         factorizes macro_define_object_internal and macro_define_function
8755         code.
8756         (macro_define_object_internal): Use macro_define_internal.
8757         (macro_define_function): Likewise.
8758
8759 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8760
8761         * macrocmd.c (extract_identifier): Return
8762         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8763         callers.
8764
8765 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8766
8767         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8768
8769 2019-02-05  Tom Tromey  <tom@tromey.com>
8770
8771         * target.c (target_stack::unpush): Move assertion earlier.
8772
8773 2019-01-30  Tom Tromey  <tom@tromey.com>
8774
8775         PR python/23615:
8776         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8777         (gdbpy_parse_and_eval): Likewise.
8778         * python/python-internal.h (gdbpy_allow_threads): New class.
8779
8780 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8781
8782         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8783         (aarch64_fbsd_fpregmap): Move earlier.
8784         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8785         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8786         instead of individual calls to trad_frame_set_reg_addr.
8787         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8788         earlier.
8789         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8790         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8791         instead of individual calls to trad_frame_set_reg_addr.
8792
8793 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8794
8795         * CONTRIBUTE: Replace contribution list with wiki link.
8796
8797 2019-01-25  Tom Tromey  <tom@tromey.com>
8798
8799         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8800
8801 2019-01-25  Tom Tromey  <tom@tromey.com>
8802
8803         * xtensa-linux-nat.c: Fix common/ includes.
8804         * xml-support.h: Fix common/ includes.
8805         * xml-support.c: Fix common/ includes.
8806         * x86-linux-nat.c: Fix common/ includes.
8807         * windows-nat.c: Fix common/ includes.
8808         * varobj.h: Fix common/ includes.
8809         * varobj.c: Fix common/ includes.
8810         * value.c: Fix common/ includes.
8811         * valops.c: Fix common/ includes.
8812         * utils.c: Fix common/ includes.
8813         * unittests/xml-utils-selftests.c: Fix common/ includes.
8814         * unittests/utils-selftests.c: Fix common/ includes.
8815         * unittests/unpack-selftests.c: Fix common/ includes.
8816         * unittests/tracepoint-selftests.c: Fix common/ includes.
8817         * unittests/style-selftests.c: Fix common/ includes.
8818         * unittests/string_view-selftests.c: Fix common/ includes.
8819         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8820         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8821         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8822         * unittests/rsp-low-selftests.c: Fix common/ includes.
8823         * unittests/parse-connection-spec-selftests.c: Fix common/
8824         includes.
8825         * unittests/optional-selftests.c: Fix common/ includes.
8826         * unittests/offset-type-selftests.c: Fix common/ includes.
8827         * unittests/observable-selftests.c: Fix common/ includes.
8828         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8829         * unittests/memrange-selftests.c: Fix common/ includes.
8830         * unittests/memory-map-selftests.c: Fix common/ includes.
8831         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8832         * unittests/function-view-selftests.c: Fix common/ includes.
8833         * unittests/environ-selftests.c: Fix common/ includes.
8834         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8835         * unittests/common-utils-selftests.c: Fix common/ includes.
8836         * unittests/cli-utils-selftests.c: Fix common/ includes.
8837         * unittests/array-view-selftests.c: Fix common/ includes.
8838         * ui-file.c: Fix common/ includes.
8839         * tui/tui-io.c: Fix common/ includes.
8840         * tracepoint.h: Fix common/ includes.
8841         * tracepoint.c: Fix common/ includes.
8842         * tracefile-tfile.c: Fix common/ includes.
8843         * top.h: Fix common/ includes.
8844         * top.c: Fix common/ includes.
8845         * thread.c: Fix common/ includes.
8846         * target/waitstatus.h: Fix common/ includes.
8847         * target/waitstatus.c: Fix common/ includes.
8848         * target.h: Fix common/ includes.
8849         * target.c: Fix common/ includes.
8850         * target-memory.c: Fix common/ includes.
8851         * target-descriptions.c: Fix common/ includes.
8852         * symtab.h: Fix common/ includes.
8853         * symfile.c: Fix common/ includes.
8854         * stap-probe.c: Fix common/ includes.
8855         * spu-linux-nat.c: Fix common/ includes.
8856         * sparc-nat.c: Fix common/ includes.
8857         * source.c: Fix common/ includes.
8858         * solib.c: Fix common/ includes.
8859         * solib-target.c: Fix common/ includes.
8860         * ser-unix.c: Fix common/ includes.
8861         * ser-tcp.c: Fix common/ includes.
8862         * ser-pipe.c: Fix common/ includes.
8863         * ser-base.c: Fix common/ includes.
8864         * selftest-arch.c: Fix common/ includes.
8865         * s12z-tdep.c: Fix common/ includes.
8866         * rust-exp.y: Fix common/ includes.
8867         * rs6000-aix-tdep.c: Fix common/ includes.
8868         * riscv-tdep.c: Fix common/ includes.
8869         * remote.c: Fix common/ includes.
8870         * remote-notif.h: Fix common/ includes.
8871         * remote-fileio.h: Fix common/ includes.
8872         * remote-fileio.c: Fix common/ includes.
8873         * regcache.h: Fix common/ includes.
8874         * regcache.c: Fix common/ includes.
8875         * record-btrace.c: Fix common/ includes.
8876         * python/python.c: Fix common/ includes.
8877         * python/py-type.c: Fix common/ includes.
8878         * python/py-inferior.c: Fix common/ includes.
8879         * progspace.h: Fix common/ includes.
8880         * producer.c: Fix common/ includes.
8881         * procfs.c: Fix common/ includes.
8882         * proc-api.c: Fix common/ includes.
8883         * printcmd.c: Fix common/ includes.
8884         * ppc-linux-nat.c: Fix common/ includes.
8885         * parser-defs.h: Fix common/ includes.
8886         * osdata.c: Fix common/ includes.
8887         * obsd-nat.c: Fix common/ includes.
8888         * nat/x86-linux.c: Fix common/ includes.
8889         * nat/x86-linux-dregs.c: Fix common/ includes.
8890         * nat/x86-dregs.h: Fix common/ includes.
8891         * nat/x86-dregs.c: Fix common/ includes.
8892         * nat/ppc-linux.c: Fix common/ includes.
8893         * nat/mips-linux-watch.h: Fix common/ includes.
8894         * nat/mips-linux-watch.c: Fix common/ includes.
8895         * nat/linux-waitpid.c: Fix common/ includes.
8896         * nat/linux-ptrace.h: Fix common/ includes.
8897         * nat/linux-ptrace.c: Fix common/ includes.
8898         * nat/linux-procfs.c: Fix common/ includes.
8899         * nat/linux-personality.c: Fix common/ includes.
8900         * nat/linux-osdata.c: Fix common/ includes.
8901         * nat/linux-namespaces.c: Fix common/ includes.
8902         * nat/linux-btrace.h: Fix common/ includes.
8903         * nat/linux-btrace.c: Fix common/ includes.
8904         * nat/fork-inferior.c: Fix common/ includes.
8905         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8906         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8907         * nat/aarch64-linux.c: Fix common/ includes.
8908         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8909         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8910         * namespace.h: Fix common/ includes.
8911         * mips-linux-tdep.c: Fix common/ includes.
8912         * minsyms.c: Fix common/ includes.
8913         * mi/mi-parse.h: Fix common/ includes.
8914         * mi/mi-main.c: Fix common/ includes.
8915         * mi/mi-cmd-env.c: Fix common/ includes.
8916         * memrange.h: Fix common/ includes.
8917         * memattr.c: Fix common/ includes.
8918         * maint.h: Fix common/ includes.
8919         * maint.c: Fix common/ includes.
8920         * main.c: Fix common/ includes.
8921         * machoread.c: Fix common/ includes.
8922         * location.c: Fix common/ includes.
8923         * linux-thread-db.c: Fix common/ includes.
8924         * linux-nat.c: Fix common/ includes.
8925         * linux-fork.c: Fix common/ includes.
8926         * inline-frame.c: Fix common/ includes.
8927         * infrun.c: Fix common/ includes.
8928         * inflow.c: Fix common/ includes.
8929         * inferior.h: Fix common/ includes.
8930         * inferior.c: Fix common/ includes.
8931         * infcmd.c: Fix common/ includes.
8932         * inf-ptrace.c: Fix common/ includes.
8933         * inf-child.c: Fix common/ includes.
8934         * ia64-linux-nat.c: Fix common/ includes.
8935         * i387-tdep.c: Fix common/ includes.
8936         * i386-tdep.c: Fix common/ includes.
8937         * i386-linux-tdep.c: Fix common/ includes.
8938         * i386-linux-nat.c: Fix common/ includes.
8939         * i386-go32-tdep.c: Fix common/ includes.
8940         * i386-fbsd-tdep.c: Fix common/ includes.
8941         * i386-fbsd-nat.c: Fix common/ includes.
8942         * guile/scm-type.c: Fix common/ includes.
8943         * guile/guile.c: Fix common/ includes.
8944         * go32-nat.c: Fix common/ includes.
8945         * gnu-nat.c: Fix common/ includes.
8946         * gdbthread.h: Fix common/ includes.
8947         * gdbarch-selftests.c: Fix common/ includes.
8948         * gdb_usleep.c: Fix common/ includes.
8949         * gdb_select.h: Fix common/ includes.
8950         * gdb_bfd.c: Fix common/ includes.
8951         * gcore.c: Fix common/ includes.
8952         * fork-child.c: Fix common/ includes.
8953         * findvar.c: Fix common/ includes.
8954         * fbsd-nat.c: Fix common/ includes.
8955         * event-top.c: Fix common/ includes.
8956         * event-loop.c: Fix common/ includes.
8957         * dwarf2read.c: Fix common/ includes.
8958         * dwarf2loc.c: Fix common/ includes.
8959         * dwarf2-frame.c: Fix common/ includes.
8960         * dwarf-index-cache.c: Fix common/ includes.
8961         * dtrace-probe.c: Fix common/ includes.
8962         * disasm-selftests.c: Fix common/ includes.
8963         * defs.h: Fix common/ includes.
8964         * csky-tdep.c: Fix common/ includes.
8965         * cp-valprint.c: Fix common/ includes.
8966         * cp-support.h: Fix common/ includes.
8967         * cp-support.c: Fix common/ includes.
8968         * corelow.c: Fix common/ includes.
8969         * completer.h: Fix common/ includes.
8970         * completer.c: Fix common/ includes.
8971         * compile/compile.c: Fix common/ includes.
8972         * compile/compile-loc2c.c: Fix common/ includes.
8973         * compile/compile-cplus-types.c: Fix common/ includes.
8974         * compile/compile-cplus-symbols.c: Fix common/ includes.
8975         * command.h: Fix common/ includes.
8976         * cli/cli-dump.c: Fix common/ includes.
8977         * cli/cli-cmds.c: Fix common/ includes.
8978         * charset.c: Fix common/ includes.
8979         * build-id.c: Fix common/ includes.
8980         * btrace.h: Fix common/ includes.
8981         * btrace.c: Fix common/ includes.
8982         * breakpoint.h: Fix common/ includes.
8983         * breakpoint.c: Fix common/ includes.
8984         * ax.h:
8985         (enum agent_op): Fix common/ includes.
8986         * ax-general.c (struct aop_map): Fix common/ includes.
8987         * ax-gdb.c: Fix common/ includes.
8988         * auxv.c: Fix common/ includes.
8989         * auto-load.c: Fix common/ includes.
8990         * arm-tdep.c: Fix common/ includes.
8991         * arch/riscv.c: Fix common/ includes.
8992         * arch/ppc-linux-common.c: Fix common/ includes.
8993         * arch/i386.c: Fix common/ includes.
8994         * arch/arm.c: Fix common/ includes.
8995         * arch/arm-linux.c: Fix common/ includes.
8996         * arch/arm-get-next-pcs.c: Fix common/ includes.
8997         * arch/amd64.c: Fix common/ includes.
8998         * arch/aarch64.c: Fix common/ includes.
8999         * arch/aarch64-insn.c: Fix common/ includes.
9000         * arch-utils.c: Fix common/ includes.
9001         * amd64-windows-tdep.c: Fix common/ includes.
9002         * amd64-tdep.c: Fix common/ includes.
9003         * amd64-sol2-tdep.c: Fix common/ includes.
9004         * amd64-obsd-tdep.c: Fix common/ includes.
9005         * amd64-nbsd-tdep.c: Fix common/ includes.
9006         * amd64-linux-tdep.c: Fix common/ includes.
9007         * amd64-linux-nat.c: Fix common/ includes.
9008         * amd64-fbsd-tdep.c: Fix common/ includes.
9009         * amd64-fbsd-nat.c: Fix common/ includes.
9010         * amd64-dicos-tdep.c: Fix common/ includes.
9011         * amd64-darwin-tdep.c: Fix common/ includes.
9012         * agent.c: Fix common/ includes.
9013         * ada-lang.h: Fix common/ includes.
9014         * ada-lang.c: Fix common/ includes.
9015         * aarch64-tdep.c: Fix common/ includes.
9016
9017 2019-01-25  Tom Tromey  <tom@tromey.com>
9018
9019         * common/create-version.sh: Use common/version.h.
9020
9021 2019-01-24  Pedro Alves  <palves@redhat.com>
9022
9023         * infrun.c (signal_stop, signal_print, signal_program)
9024         (signal_catch, signal_pass): Now arrays instead of pointers.
9025         (update_signals_program_target, do_target_resume)
9026         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9027         * linux-nat.c (linux_nat_target::pass_signals)
9028         (linux_nat_target::create_inferior, linux_nat_target::attach):
9029         Adjust.
9030         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9031         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9032         * procfs.c (procfs_target::pass_signals): Adjust.
9033         * record-full.c (record_full_target::resume): Adjust.
9034         * remote.c (remote_target::pass_signals)
9035         (remote_target::program_signals): Adjust.
9036         * target-debug.h (target_debug_print_signals): Now takes a
9037         gdb::array_view as parameter.  Adjust.
9038         * target.h (target_ops) <pass_signals, program_signals>: Replace
9039         pointer and length parameters with gdb::array_view.
9040         (target_pass_signals, target_program_signals): Likewise.
9041         * target-delegates.c: Regenerate.
9042
9043 2019-01-24  Pedro Alves  <palves@redhat.com>
9044
9045         * common/forward-scope-exit.h
9046         (forward_scope_exit::forward_scope_exit): Pass arguments to
9047         m_bind_function directly, instead of creating a std::bind and
9048         copying that.
9049
9050 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9051
9052         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9053         for static members.
9054         (pass_in_v_vfp_candidate): Likewise.
9055
9056 2019-01-23  Tom Tromey  <tom@tromey.com>
9057             Pedro Alves  <palves@redhat.com>
9058
9059         * regcache.c (class regcache_invalidator): Remove.
9060         (regcache::raw_write): Use make_scope_exit.
9061
9062 2019-01-23  Tom Tromey  <tom@tromey.com>
9063
9064         * ui-out.h (class ui_out_emit_type): Update comment.
9065
9066 2019-01-23  Tom Tromey  <tom@tromey.com>
9067
9068         * infrun.c (fetch_inferior_event): Update comment.
9069
9070 2019-01-23  Tom Tromey  <tom@tromey.com>
9071             Pedro Alves  <palves@redhat.com>
9072
9073         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9074         parameter.
9075         (fetch_inferior_event): Use SCOPE_EXIT.
9076
9077
9078 2019-01-23  Tom Tromey  <tom@tromey.com>
9079             Pedro Alves  <palves@redhat.com>
9080
9081         * infrun.c (disable_thread_events): Delete.
9082         (stop_all_threads): Use SCOPE_EXIT.
9083
9084 2019-01-23  Tom Tromey  <tom@tromey.com>
9085             Pedro Alves  <palves@redhat.com>
9086
9087         * symfile.c: Include forward-scope-exit.h.
9088         (clear_symtab_users_cleanup): Replace forward declaration with
9089         a FORWARD_SCOPE_EXIT.
9090         (syms_from_objfile_1): Use the forward_scope_exit and
9091         gdb::optional instead of cleanup_function.
9092         (reread_symbols): Use the forward_scope_exit instead of
9093         cleanup_function.
9094         (clear_symtab_users_cleanup): Remove function.
9095
9096 2019-01-23  Tom Tromey  <tom@tromey.com>
9097             Pedro Alves  <palves@redhat.com>
9098
9099         * linux-nat.c: Include scope-exit.h.
9100         (cleanup_target_stop): Remove.
9101         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9102         SCOPE_EXIT.
9103
9104 2019-01-23  Tom Tromey  <tom@tromey.com>
9105             Pedro Alves  <palves@redhat.com>
9106
9107         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9108         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9109
9110 2019-01-23  Tom Tromey  <tom@tromey.com>
9111             Andrew Burgess  <andrew.burgess@embecosm.com>
9112             Pedro Alves  <palves@redhat.com>
9113
9114         * infrun.c (fetch_inferior_event): Use scope_exit.
9115         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9116         * top.c (execute_command): Use scope_exit.
9117         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9118         * utils.c (do_bpstat_clear_actions_cleanup)
9119         (make_bpstat_clear_actions_cleanup): Remove.
9120
9121 2019-01-23  Tom Tromey  <tom@tromey.com>
9122             Pedro Alves  <palves@redhat.com>
9123
9124         * infrun.c: Include "common/scope-exit.h"
9125         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9126         (wait_for_inferior): Use SCOPE_EXIT.
9127         (fetch_inferior_event): Use scope_exit.
9128
9129 2019-01-23  Tom Tromey  <tom@tromey.com>
9130             Pedro Alves  <palves@redhat.com>
9131
9132         * breakpoint.c (create_breakpoint): Remove cleanup.
9133
9134 2019-01-23  Tom Tromey  <tom@tromey.com>
9135             Andrew Burgess  <andrew.burgess@embecosm.com>
9136             Pedro Alves  <palves@redhat.com>
9137
9138 2019-01-23  Pedro Alves  <palves@redhat.com>
9139
9140         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9141
9142 2019-01-23  Pedro Alves  <palves@redhat.com>
9143             Andrew Burgess  <andrew.burgess@embecosm.com>
9144
9145         * gdbthread.h: Include "common/forward-scope-exit.h".
9146         (scoped_finish_thread_state): Redefine custom class in terms of
9147         forward_scope_exit.
9148
9149 2019-01-23  Pedro Alves  <palves@redhat.com>
9150             Andrew Burgess  <andrew.burgess@embecosm.com>
9151
9152         * common/forward-scope-exit.h: New file.
9153
9154 2019-01-23  Pedro Alves  <palves@redhat.com>
9155             Andrew Burgess  <andrew.burgess@embecosm.com>
9156             Tom Tromey  <tom@tromey.com>
9157
9158         * common/scope-exit.h: New file.
9159
9160 2019-01-23  Pedro Alves  <palves@redhat.com>
9161
9162         * common/preprocessor.h (ESC): Rename to ...
9163         (ESC_PARENS): ... this.
9164         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9165         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9166
9167 2019-01-23  Tom Tromey  <tom@tromey.com>
9168
9169         * language.h (class scoped_switch_to_sym_language_if_auto):
9170         Initialize m_lang in both cases.
9171
9172 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9173
9174         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9175         with XCNEW.
9176
9177 2019-01-22  Tom Tromey  <tom@tromey.com>
9178
9179         * corelow.c: Do not include sys/file.h.
9180
9181 2019-01-22  Tom Tromey  <tom@tromey.com>
9182
9183         * tui/tui-wingeneral.h: Include gdb_curses.h.
9184
9185 2019-01-22  Tom Tromey  <tom@tromey.com>
9186
9187         * source-cache.h (class source_cache) <get_source_lines,
9188         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9189
9190 2019-01-22  Tom Tromey  <tom@tromey.com>
9191
9192         * remote-fileio.h (struct remote_target): Declare.
9193
9194 2019-01-22  Tom Tromey  <tom@tromey.com>
9195
9196         * python/py-arch.c: Do not include py-ref.h.
9197         * python/py-bpevent.c: Do not include py-ref.h.
9198         * python/py-cmd.c: Do not include py-ref.h.
9199         * python/py-continueevent.c: Do not include py-ref.h.
9200         * python/py-event.h: Do not include py-ref.h.
9201         * python/py-evtregistry.c: Do not include py-ref.h.
9202         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9203         * python/py-frame.c: Do not include py-ref.h.
9204         * python/py-framefilter.c: Do not include py-ref.h.
9205         * python/py-function.c: Do not include py-ref.h.
9206         * python/py-infevents.c: Do not include py-ref.h.
9207         * python/py-linetable.c: Do not include py-ref.h.
9208         * python/py-objfile.c: Do not include py-ref.h.
9209         * python/py-param.c: Do not include py-ref.h.
9210         * python/py-prettyprint.c: Do not include py-ref.h.
9211         * python/py-progspace.c: Do not include py-ref.h.
9212         * python/py-symbol.c: Do not include py-ref.h.
9213         * python/py-symtab.c: Do not include py-ref.h.
9214         * python/py-type.c: Do not include py-ref.h.
9215         * python/py-unwind.c: Do not include py-ref.h.
9216         * python/py-utils.c: Do not include py-ref.h.
9217         * python/py-value.c: Do not include py-ref.h.
9218         * python/py-varobj.c: Do not include py-ref.h.
9219         * python/py-xmethods.c: Do not include py-ref.h.
9220         * python/python.c: Do not include py-ref.h.
9221         * varobj.c: Do not include py-ref.h.
9222
9223 2019-01-22  Tom Tromey  <tom@tromey.com>
9224
9225         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9226         keyword for bcache.
9227
9228 2019-01-22  Tom Tromey  <tom@tromey.com>
9229
9230         * compile/compile-cplus-types.c: Remove a comment by #include.
9231
9232 2019-01-22  Tom Tromey  <tom@tromey.com>
9233
9234         * compile/gcc-c-plugin.h: Include compile-internal.h.
9235
9236 2019-01-22  Tom Tromey  <tom@tromey.com>
9237
9238         * stabsread.c (EXTERN): Do not define.
9239         (symnum, next_symbol_text_func, processing_gcc_compilation)
9240         (within_function, global_sym_chain, global_stabs)
9241         (previous_stab_code, this_object_header_files)
9242         (n_this_object_header_files)
9243         (n_allocated_this_object_header_files): Define.
9244         * stabsread.h (EXTERN): Never define.  Use "extern".
9245
9246 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9247
9248         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9249         history_value.
9250
9251 2019-01-21  Tom Tromey  <tom@tromey.com>
9252
9253         * ui-out.c: Fix includes.
9254         * tui/tui-source.c: Fix includes.
9255         * target.c: Fix includes.
9256         * remote.c: Fix includes.
9257         * regcache.c: Fix includes.
9258         * python/py-block.c: Fix includes.
9259         * printcmd.c: Fix includes.
9260         * or1k-tdep.c: Fix includes.
9261         * mi/mi-main.c: Fix includes.
9262         * m32r-tdep.c: Fix includes.
9263         * csky-tdep.c: Fix includes.
9264         * compile/compile-cplus-types.c: Fix includes.
9265         * cli/cli-interp.c: Fix includes.
9266
9267 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9268
9269         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9270         for padding.
9271
9272 2019-01-16  Tom Tromey  <tom@tromey.com>
9273
9274         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9275         earlier.
9276         (struct objfile) <msymbols_range>: Move from top level.
9277         <msymbols>: New method.
9278         (class objfile_msymbols): Remove.
9279         * symtab.c (default_collect_symbol_completion_matches_break_on):
9280         Update.
9281         * symmisc.c (dump_msymbols): Update.
9282         * stabsread.c (scan_file_globals): Update.
9283         * objc-lang.c (info_selectors_command, info_classes_command)
9284         (find_methods): Update.
9285         * minsyms.c (find_solib_trampoline_target): Update.
9286         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9287         * coffread.c (coff_symfile_read): Update.
9288         * ada-lang.c (ada_lookup_simple_minsym)
9289         (ada_collect_symbol_completion_matches): Update.
9290
9291 2019-01-16  Tom Tromey  <tom@tromey.com>
9292
9293         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9294         type.  Remove no-argument constructor.
9295         <iterator::operator++>: Simplify.
9296         <begin>: Update.
9297         <end>: Use minimal_symbol_count.
9298
9299 2019-01-16  Tom Tromey  <tom@tromey.com>
9300
9301         * objfiles.h (struct objfile) <psymtabs>: New method.
9302         (class objfile_psymtabs): Remove.
9303         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9304         typedef.
9305         <range>: New method.
9306         (require_partial_symbols): Change return type.
9307         * psymtab.c (require_partial_symbols)
9308         (psym_expand_symtabs_matching): Update.
9309         * mdebugread.c (parse_partial_symbols): Update.
9310         * dbxread.c (dbx_end_psymtab): Update.
9311
9312 2019-01-15  Tom Tromey  <tom@tromey.com>
9313
9314         * symtab.c (lookup_objfile_from_block)
9315         (lookup_symbol_in_objfile_symtabs)
9316         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9317         (find_line_symtab, info_sources_command)
9318         (default_collect_symbol_completion_matches_break_on)
9319         (make_source_files_completion_list): Update.
9320         * symmisc.c (print_objfile_statistics, dump_objfile)
9321         (maintenance_print_symbols, maintenance_info_symtabs)
9322         (maintenance_check_symtabs, maintenance_info_line_tables):
9323         Update.
9324         * source.c (select_source_symtab)
9325         (forget_cached_source_info_for_objfile): Update.
9326         * objfiles.h (class objfile_compunits): Remove.
9327         (struct objfile) <compunits_range>: New typedef.
9328         (compunits): New method.
9329         * objfiles.c (objfile_relocate1): Update.
9330         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9331         * maint.c (count_symtabs_and_blocks): Update.
9332         * linespec.c (iterate_over_all_matching_symtabs): Update.
9333         * cp-support.c (add_symbol_overload_list_qualified): Update.
9334         * coffread.c (coff_symtab_read): Update.
9335         * ada-lang.c (add_nonlocal_symbols)
9336         (ada_collect_symbol_completion_matches)
9337         (ada_add_global_exceptions): Update.
9338
9339 2019-01-15  Tom Tromey  <tom@tromey.com>
9340
9341         * progspace.h (program_space) <objfiles_safe_range>: New
9342         typedef.
9343         <objfiles_safe>: New method.
9344         * objfiles.h (class all_objfiles_safe): Remove.
9345         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9346         * jit.c (jit_inferior_exit_hook): Update.
9347
9348 2019-01-17  Tom Tromey  <tom@tromey.com>
9349
9350         * progspace.h (program_space) <objfiles_range>: New typedef.
9351         <objfiles>: New method.
9352         <objfiles_head>: Rename from objfiles.
9353         (object_files): Update.
9354         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9355         * guile/scm-pretty-print.c
9356         (ppscm_find_pretty_printer_from_objfiles): Update.
9357         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9358         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9359         Update.
9360         * python/py-progspace.c (pspy_get_objfiles): Update.
9361         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9362         Update.
9363         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9364         (objfpy_lookup_objfile_by_build_id): Update.
9365         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9366         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9367         Update.
9368         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9369         (expand_symtab_containing_pc, lookup_objfile_from_block)
9370         (lookup_static_symbol, basic_lookup_transparent_type)
9371         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9372         (find_line_symtab, info_sources_command)
9373         (default_collect_symbol_completion_matches_break_on)
9374         (make_source_files_completion_list, find_main_name): Update.
9375         * symmisc.c (print_symbol_bcache_statistics)
9376         (print_objfile_statistics, maintenance_print_symbols)
9377         (maintenance_print_msymbols, maintenance_print_objfiles)
9378         (maintenance_info_symtabs, maintenance_check_symtabs)
9379         (maintenance_expand_symtabs, maintenance_info_line_tables):
9380         Update.
9381         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9382         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9383         (map_overlay_command, unmap_overlay_command)
9384         (simple_overlay_update, expand_symtabs_matching)
9385         (map_symbol_filenames): Update.
9386         * symfile-debug.c (set_debug_symfile): Update.
9387         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9388         Update.
9389         * source.c (select_source_symtab, forget_cached_source_info):
9390         Update.
9391         * solib.c (solib_read_symbols): Update.
9392         * solib-spu.c (append_ocl_sos): Update.
9393         * psymtab.c (maintenance_print_psymbols)
9394         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9395         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9396         * printcmd.c (info_symbol_command): Update.
9397         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9398         Update.
9399         * objfiles.h (class all_objfiles): Remove.
9400         * objfiles.c (have_partial_symbols, have_full_symbols)
9401         (have_minimal_symbols, qsort_cmp, update_section_map)
9402         (shared_objfile_contains_address_p)
9403         (default_iterate_over_objfiles_in_search_order): Update.
9404         * objc-lang.c (info_selectors_command, info_classes_command)
9405         (find_methods): Update.
9406         * minsyms.c (find_solib_trampoline_target): Update.
9407         * maint.c (maintenance_info_sections)
9408         (maintenance_translate_address, count_symtabs_and_blocks):
9409         Update.
9410         * main.c (captured_main_1): Update.
9411         * linux-thread-db.c (try_thread_db_load_from_pdir)
9412         (has_libpthread): Update.
9413         * linespec.c (iterate_over_all_matching_symtabs)
9414         (search_minsyms_for_name): Update.
9415         * jit.c (jit_find_objf_with_entry_addr): Update.
9416         * hppa-tdep.c (find_unwind_entry)
9417         (hppa_lookup_stub_minimal_symbol): Update.
9418         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9419         Update.
9420         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9421         (elf_gnu_ifunc_resolve_by_got): Update.
9422         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9423         * dwarf-index-write.c (save_gdb_index_command): Update.
9424         * cp-support.c (add_symbol_overload_list_qualified): Update.
9425         * breakpoint.c (create_overlay_event_breakpoint)
9426         (create_longjmp_master_breakpoint)
9427         (create_std_terminate_master_breakpoint)
9428         (create_exception_master_breakpoint): Update.
9429         * blockframe.c (find_pc_partial_function): Update.
9430         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9431         (ada_collect_symbol_completion_matches)
9432         (ada_add_global_exceptions): Update.
9433
9434 2019-01-17  Tom Tromey  <tom@tromey.com>
9435
9436         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9437         declare VEC.
9438         (solib_target_parse_libraries): Change return type.
9439         (library_list_start_segment, library_list_start_section)
9440         (library_list_end_library, library_list_start_library); Update.
9441         (solib_target_free_library_list): Remove.
9442         (solib_target_parse_libraries): Remove cleanup.  Change return
9443         type.
9444         (solib_target_current_sos): Update.
9445
9446 2019-01-17  Tom Tromey  <tromey@bapiya>
9447
9448         * valprint.c: Replace "the the" with "the".
9449         * symtab.c: Replace "the the" with "the".
9450         * solib.c: Replace "the the" with "the".
9451         * solib-dsbt.c: Replace "the the" with "the".
9452         * linespec.c: Replace "the the" with "the".
9453         * dwarf2loc.h: Replace "the the" with "the".
9454         * amd64-windows-tdep.c: Replace "the the" with "the".
9455         * aarch64-tdep.c: Replace "the the" with "the".
9456
9457 2019-01-16  Keith Seitz  <keiths@redhat.com>
9458
9459         PR gdb/23773
9460         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9461         <builder>: Rename to ..
9462         <m_builder>: ... this and make private.
9463         (dwarf2_cu::get_builder): New method.  Change all users of
9464         `builder' to use this method.
9465         (dwarf2_start_symtab): Move to ...
9466         (dwarf2_cu::start_symtab): ... here.  Update all callers
9467         (setup_type_unit_groups): Move to ...
9468         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9469         callers.
9470         (dwarf2_cu::reset_builder): New method.
9471         (process_full_compunit, process_full_type_unit): Use
9472         dwarf2_cu::reset_builder.
9473         (follow_die_offset): Record the ancestor CU if it is different
9474         from the followed DIE's CU.
9475         (follow_die_sig_1): Likewise.
9476
9477 2019-01-15  Tom Tromey  <tom@tromey.com>
9478
9479         * remote.c (class remote_state) <buf>: Now a char_vector.
9480         <buf_size>: Remove.
9481         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9482         parameter.
9483         (remote_target::getpkt_or_notif_sane_1)
9484         (remote_target::getpkt_sane)
9485         (remote_target::getpkt_or_notif_sane): Likewise.
9486         (class remote_target) <putpkt>: New overload.
9487         (remote_target::read_frame): Change type of "buf_p".  Remove
9488         sizeof_p parameter.
9489         (packet_ok): New overload.
9490         (packet_check_result): New overload.
9491         Update all uses.
9492
9493 2019-01-14  Tom Tromey  <tom@tromey.com>
9494
9495         * remote-notif.c (handle_notification, remote_notif_ack)
9496         (remote_notif_parse): Make "buf" const.
9497         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9498         const.
9499         (remote_notif_parse, remote_notif_ack, handle_notification):
9500         Likewise.
9501         * remote.c (remote_notif_stop_parse): Make "buf" const.
9502         (remote_target::remote_parse_stop_reply): Make "buf" const.
9503         (remote_notif_stop_ack): Make "buf" const.
9504
9505 2019-01-14  Tom Tromey  <tom@tromey.com>
9506
9507         * remote.c (remote_console_output): Make parameter const.
9508
9509 2019-01-14  Tom Tromey  <tom@tromey.com>
9510
9511         * target-debug.h (target_debug_print_signals): Constify.
9512         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9513         * procfs.c (procfs_target::pass_signals): Update.
9514         * linux-nat.c (linux_nat_target::pass_signals): Update.
9515         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9516         * target-delegates.c: Rebuild.
9517         * remote.c (remote_target::program_signals): Update.
9518         (remote_target::pass_signals): Update.
9519         * target.c (target_pass_signals): Constify argument.
9520         (target_program_signals): Likewise.
9521         * target.h (struct target_ops) <pass_signals, program_signals>:
9522         Constify argument.
9523         (target_pass_signals, target_program_signals): Constify argument.
9524
9525 2019-01-14  Tom Tromey  <tom@tromey.com>
9526
9527         PR tui/28819:
9528         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9529
9530 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9531
9532         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9533         field.
9534         * rs6000-tdep.c: Include reggroups.h.
9535         (IS_V_ALIAS_PSEUDOREG): Define.
9536         (rs6000_register_name): Return names for the "vX" aliases.
9537         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9538         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9539         aliases.  Call default_register_reggroup_p for all other
9540         pseudo-registers.
9541         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9542         New functions.
9543         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9544         Handle "vX" aliases.
9545         (v_alias_pseudo_register_collect): New function.
9546         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9547         (rs6000_gdbarch_init): Initialize "vX" aliases as
9548         pseudo-registers.  Restore registration of
9549         rs6000_pseudo_register_reggroup_p with
9550         set_tdesc_pseudo_register_reggroup_p.
9551
9552 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9553
9554         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9555         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9556         set_gdbarch_num_pseudo_regs.
9557
9558 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9559
9560         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9561         Remove arg prefixname, add do_set and do_show.
9562         Add member functions set_list and show_list.
9563         * cli/cli-style.c (class cli_style_option): Update accordingly.
9564         (style_set_list): Move to file scope.
9565         (style_show_list): Likewise.
9566         (set_style): Call help_list.
9567         (show_style): Call cmd_show_list.
9568         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9569         Update to use the new macro.
9570
9571 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9572
9573         * ada-lang.c (_initialize_ada_language): Expand the help text
9574         for the "catch exception" command.
9575
9576 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9577
9578         * symtab.c (matching_obj_sections): Initialize obj,
9579         declare it closer to its usage.
9580
9581 2019-01-10  Tom Tromey  <tom@tromey.com>
9582
9583         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9584         (basic_inf_threads_range): Remove.
9585         (inf_threads_range, inf_non_exited_threads_range)
9586         (safe_inf_threads_range): Use next_adapter.
9587
9588 2019-01-10  Keith Seitz  <keiths@redhat.com>
9589
9590         PR gdb/23712
9591         PR symtab/23010
9592         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9593         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9594
9595 2019-01-10  Keith Seitz  <keiths@redhat.com>
9596
9597         PR gdb/23712
9598         PR symtab/23010
9599         * dictionary.c (pending_to_vector): Remove.
9600         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9601         Remove _1 suffix, replacing functions of the same name.  Update
9602         all callers.
9603         (dict_create_hashed, dict_create_hashed_expandable)
9604         (dict_create_linear, dict_create_linear_expandable, dict_free)
9605         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9606         Make functions static.
9607
9608 2019-01-10  Keith Seitz  <keiths@redhat.com>
9609
9610         PR gdb/23712
9611         PR symtab/23010
9612         * dictionary.h (struct dictionary): Replace declaration with
9613         multidictionary.
9614         (dict_create_hashed, dict_create_hashed_expandable)
9615         (dict_create_linear, dict_create_linear_expandable)
9616         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9617         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9618         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9619         taking multidictionary argument.
9620         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9621         * block.h (struct block) <dict>: Change to multidictionary
9622         and rename `multidict'.
9623         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9624         symmisc.c: Update all dictionary references to multidictionary.
9625
9626 2019-01-10  Keith Seitz  <keiths@redhat.com>
9627
9628         PR gdb/23712
9629         PR symtab/23010
9630         * dictionary.c: Include unordered_map.
9631         (pending_to_vector): New function.
9632         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9633         Rewrite the non-"_1" functions to take vector instead
9634         of linked list.
9635         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9636         "new" _1 versions of the same name.
9637         (multidictionary): Define.
9638         (std::hash<enum language): New definition.
9639         (collate_pending_symbols_by_language, mdict_create_hashed)
9640         (mdict_create_hashed_expandable, mdict_create_linear)
9641         (mdict_create_linear_expandable, mdict_free)
9642         (find_language_dictionary, create_new_language_dictionary)
9643         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9644         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9645         (mdict_size, mdict_empty): New functions.
9646         * dictionary.h (mdict_iterator): Define.
9647
9648 2019-01-10  Pedro Alves  <palves@redhat.com>
9649
9650         * breakpoint.c (read_uploaded_action)
9651         (create_tracepoint_from_upload): Adjust to use
9652         gdb::unique_xmalloc_ptr.
9653         * ctf.c (ctf_write_uploaded_tp):
9654         (SET_ARRAY_FIELD): Use emplace_back.
9655         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9656         * tracefile-tfile.c (tfile_write_uploaded_tp):
9657         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9658         gdb::unique_xmalloc_ptr.
9659         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9660         at_string, cond_string, cmd_strings>: Replace char pointers
9661         with gdb::unique_xmalloc_ptr.
9662
9663 2019-01-10  Pedro Alves  <palves@redhat.com>
9664
9665         * solib-target.c (library_list_start_library): Don't xstrdup name.
9666
9667 2019-01-10  Pedro Alves  <palves@redhat.com>
9668
9669         * mdebugread.c (parse_partial_symbols): Use
9670         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9671
9672 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9673
9674         * linux-fork.c (scoped_switch_fork_info)
9675         <~scoped_switch_fork_info>: Fix incorrect variable name.
9676
9677 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9678
9679         * linux-fork.c (scoped_switch_fork_info)
9680         <scoped_switch_fork_info>: Make explicit.
9681         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9682
9683 2019-01-10  Tom Tromey  <tom@tromey.com>
9684
9685         * objfiles.h (objfile::reset_psymtabs): Update.
9686         * objfiles.c (objfile::objfile): Update.
9687         * psymtab.h (psymtab_storage::obstack): Update.
9688         (psymtab_storage::m_obstack): Use gdb::optional.
9689         (class psymtab_storage): Update comment.  Remove objfile
9690         parameter.
9691         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9692
9693 2019-01-10  Tom Tromey  <tom@tromey.com>
9694
9695         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9696         <free_psymtabs>: Now private.
9697         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9698         (allocate_psymtab): Use new method.
9699
9700 2019-01-10  Tom Tromey  <tom@tromey.com>
9701
9702         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9703         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9704         * mdebugread.c (parse_partial_symbols): Use
9705         allocate_dependencies.
9706         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9707         allocate_dependencies.
9708         (process_psymtab_comp_unit_reader)
9709         (build_type_psymtab_dependencies): Likewise.
9710         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9711
9712 2019-01-10  Tom Tromey  <tom@tromey.com>
9713
9714         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9715         PSYMBOL_SET_LANGUAGE.
9716         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9717
9718 2019-01-10  Tom Tromey  <tom@tromey.com>
9719
9720         * psymtab.h (psymtab_storage::obstack): New method.
9721         <m_obstack>: Rename from obstack; now private.
9722         * psymtab.c (psymtab_storage): Update.
9723         * dwarf2read.c (create_addrmap_from_index)
9724         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9725         Update.
9726
9727 2019-01-10  Tom Tromey  <tom@tromey.com>
9728
9729         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9730         * objfiles.h (objfile::reset_psymtabs): New method.
9731
9732 2019-01-10  Tom Tromey  <tom@tromey.com>
9733
9734         * symmisc.c (print_symbol_bcache_statistics): Update.
9735         (print_objfile_statistics): Update.
9736         * symfile.c (reread_symbols): Update.
9737         * psymtab.h (class psymtab_storage): New.
9738         * psymtab.c (psymtab_storage): New constructor.
9739         (~psymtab_storage): New destructor.
9740         (require_partial_symbols): Update.
9741         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9742         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9743         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9744         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9745         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9746         (start_psymtab_common, end_psymtab_common)
9747         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9748         (allocate_psymtab): Update.
9749         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9750         Update.
9751         (dump_psymtab_addrmap, maintenance_print_psymbols)
9752         (maintenance_check_psymtabs): Update.
9753         (class objfile_psymtabs): Move to objfiles.h.
9754         * psympriv.h (discard_psymtab): Now inline.
9755         (psymtab_discarder::psymtab_discarder): Update.
9756         (psymtab_discarder::~psymtab_discarder): Update.
9757         (ALL_OBJFILE_PSYMTABS): Rewrite.
9758         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9759         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9760         Remove fields.
9761         <partial_symtabs>: New field.
9762         (class objfile_psymtabs): Move from psymtab.h.  Update.
9763         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9764         psymbol_cache.
9765         (objfile::~objfile): Don't destroy psymbol_cache.
9766         * mdebugread.c (parse_partial_symbols): Update.
9767         * dwarf2read.c (create_addrmap_from_index)
9768         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9769         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9770         (add_partial_subprogram, dwarf2_ranges_read): Update.
9771         * dwarf-index-write.c (write_address_map)
9772         (write_one_signatured_type, recursively_write_psymbols)
9773         (class debug_names, class debug_names, write_psymtabs_to_index):
9774         Update.
9775
9776 2019-01-10  Tom Tromey  <tom@tromey.com>
9777
9778         * symtab.h (SYMBOL_SET_NAMES): Update.
9779         (symbol_set_names): Update.
9780         (MSYMBOL_SET_NAMES): Update.
9781         * symtab.c (symbol_set_names): Change argument to be an
9782         objfile_per_bfd_storage.
9783         * psymtab.c (add_psymbol_to_bcache): Update.
9784         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9785
9786 2019-01-10  Tom Tromey  <tom@tromey.com>
9787
9788         * symtab.c (create_demangled_names_hash): Change argument to be an
9789         objfile_per_bfd_storage.
9790         (symbol_set_names): Update.
9791
9792 2019-01-10  Tom Tromey  <tom@tromey.com>
9793
9794         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9795         init_psymbol_list.
9796         * psymtab.c (init_psymbol_list): Do nothing if already called.
9797         * psympriv.h (init_psymbol_list): Add comment.
9798         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9799         init_psymbol_list.
9800         * dbxread.c (dbx_symfile_read): Unconditionally call
9801         init_psymbol_list.
9802
9803 2019-01-10  Tom Tromey  <tom@tromey.com>
9804
9805         * xcoffread.c (scan_xcoff_symtab): Update.
9806         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9807         "where".
9808         * mdebugread.c (parse_partial_symbols)
9809         (handle_psymbol_enumerators): Update.
9810         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9811         * dbxread.c (read_dbx_symtab): Update.
9812         * psympriv.h (psymbol_placement): New enum.
9813         (add_psymbol_to_list): Update.
9814
9815 2019-01-10  Tom Tromey  <tom@tromey.com>
9816
9817         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9818         static_psymbols parameters.
9819         (scan_xcoff_symtab): Update.
9820         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9821         static_psymbols parameters.
9822         * psympriv.h (start_psymtab_common): Update.
9823         * mdebugread.c (parse_partial_symbols): Update.
9824         * dwarf2read.c (create_partial_symtab): Update.
9825         * dbxread.c (read_dbx_symtab): Update.
9826         (start_psymtab): Remove global_psymbols and static_psymbols
9827         parameters.
9828
9829 2019-01-10  Tom Tromey  <tom@tromey.com>
9830
9831         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9832         * psymtab.c (allocate_psymtab): Add comment.
9833         * psympriv.h (allocate_psymtab): Add comment.
9834         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9835         initializations.
9836         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9837
9838 2019-01-10  Tom Tromey  <tom@tromey.com>
9839
9840         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9841         Don't declare.
9842         * mipsread.c: Include mdebugread.h.
9843         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9844         Declare.
9845         * elfread.c: Include mdebugread.h.
9846
9847 2019-01-09  Tom Tromey  <tom@tromey.com>
9848
9849         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9850         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9851         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9852         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9853         (psym_lookup_symbol, psym_find_last_source_symtab)
9854         (psym_forget_cached_source_info, psym_print_stats)
9855         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9856         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9857         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9858         (psym_find_compunit_symtab_by_address)
9859         (maintenance_print_psymbols, maintenance_info_psymtabs)
9860         (maintenance_check_psymtabs): Use ranged for.
9861         * psymtab.h (class objfile_psymtabs): New.
9862         (require_partial_symbols): Return objfile_psymtabs.
9863         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9864
9865 2019-01-09  Tom Tromey  <tom@tromey.com>
9866
9867         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9868         (find_pc_mapped_section, list_overlays_command)
9869         (map_overlay_command, unmap_overlay_command)
9870         (simple_overlay_update): Use all_objfiles.
9871         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9872         * printcmd.c (info_symbol_command): Use all_objfiles.
9873         * objfiles.h (ALL_OBJSECTIONS): Remove.
9874         * maint.c (maintenance_translate_address): Use all_objfiles.
9875         * gcore.c (gcore_create_callback): Use all_objfiles.
9876         (objfile_find_memory_regions): Likewise.
9877
9878 2019-01-09  Tom Tromey  <tom@tromey.com>
9879
9880         * symtab.c (find_line_symtab, info_sources_command)
9881         (make_source_files_completion_list): Use objfile_compunits.
9882         * source.c (select_source_symtab): Use objfile_compunits.
9883         * objfiles.h (struct objfile): Update comment.
9884         (ALL_OBJFILES): Remove.
9885         (ALL_FILETABS): Remove.
9886         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9887         objfile_compunits.
9888
9889 2019-01-09  Tom Tromey  <tom@tromey.com>
9890
9891         * symmisc.c (print_objfile_statistics, dump_objfile)
9892         (maintenance_print_symbols): Use compunit_filetabs.
9893         * source.c (forget_cached_source_info_for_objfile): Use
9894         compunit_filetabs.
9895         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9896         (ALL_FILETABS): Use compunit_filetabs.
9897         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9898         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9899
9900 2019-01-09  Tom Tromey  <tom@tromey.com>
9901
9902         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9903         (compunit_filetabs): New.
9904         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9905         compunit_filetabs.
9906         (info_sources_command, make_source_files_completion_list): Remove
9907         declaration.
9908         * symmisc.c (print_objfile_statistics, dump_objfile)
9909         (maintenance_print_symbols): Remove declaration.
9910         (maintenance_info_symtabs): Use compunit_filetabs.
9911         (maintenance_info_line_tables): Likewise.
9912         * source.c (select_source_symtab): Change local variable name.
9913         (forget_cached_source_info_for_objfile): Remove declaration.
9914         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9915         * objfiles.c (objfile_relocate1): Remove declaration.
9916         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9917         declaration.
9918         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9919         * coffread.c (coff_symtab_read): Remove declaration.
9920         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9921         compunit_filetabs.
9922
9923 2019-01-09  Tom Tromey  <tom@tromey.com>
9924
9925         * symtab.c (lookup_objfile_from_block)
9926         (find_pc_sect_compunit_symtab, search_symbols)
9927         (default_collect_symbol_completion_matches_break_on): Use
9928         objfile_compunits.
9929         * objfiles.h (ALL_COMPUNITS): Remove.
9930         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9931         * cp-support.c (add_symbol_overload_list_qualified): Use
9932         objfile_compunits.
9933         * ada-lang.c (ada_collect_symbol_completion_matches)
9934         (ada_add_global_exceptions): Use objfile_compunits.
9935
9936 2019-01-09  Tom Tromey  <tom@tromey.com>
9937
9938         * source.c (select_source_symtab)
9939         (forget_cached_source_info_for_objfile): Remove declaration.
9940         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9941         declaration.
9942         * maint.c (count_symtabs_and_blocks): Remove declaration.
9943         * cp-support.c (add_symbol_overload_list_qualified): Remove
9944         declaration.
9945         * coffread.c (coff_symtab_read): Remove declaration.
9946         * symtab.c (lookup_symbol_in_objfile_symtabs)
9947         (basic_lookup_transparent_type_1): Use objfile_compunits.
9948         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9949         (info_sources_command, search_symbols)
9950         (default_collect_symbol_completion_matches_break_on)
9951         (make_source_files_completion_list): Remove declaration.
9952         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9953         (ada_collect_symbol_completion_matches)
9954         (ada_add_global_exceptions): Remove declaration.
9955         * linespec.c (iterate_over_all_matching_symtabs): Use
9956         objfile_compunits.
9957         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9958         (class objfile_compunits): New.
9959         (ALL_COMPUNITS): Use objfile_compunits.
9960         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9961         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9962         objfile_compunits.
9963         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9964
9965 2019-01-09  Tom Tromey  <tom@tromey.com>
9966
9967         * symtab.c (search_symbols)
9968         (default_collect_symbol_completion_matches_break_on): Use
9969         objfile_msymbols.
9970         * ada-lang.c (ada_lookup_simple_minsym)
9971         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9972         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9973         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9974         objfile_msymbols.
9975         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9976         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9977         * objc-lang.c (find_methods): Use objfile_msymbols.
9978         (info_selectors_command, info_classes_command): Likewise.
9979         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9980         * objfiles.h (class objfile_msymbols): New.
9981         (ALL_OBJFILE_MSYMBOLS): Remove.
9982         (ALL_MSYMBOLS): Remove.
9983
9984 2019-01-09  Tom Tromey  <tom@tromey.com>
9985
9986         * common/next-iterator.h (next_adapter): Add Iterator template
9987         parameter.
9988         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9989         (class all_objfiles_safe): New.
9990         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9991         * objfiles.c (put_objfile_before): Update comment.
9992         (add_separate_debug_objfile): Likewise.
9993         (free_all_objfiles): Use all_objfiles_safe.
9994         (objfile_purge_solibs): Likewise.
9995
9996 2019-01-09  Tom Tromey  <tom@tromey.com>
9997
9998         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9999         (expand_symtab_containing_pc, lookup_static_symbol)
10000         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10001         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10002         all_objfiles.
10003         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10004         * breakpoint.c (create_overlay_event_breakpoint)
10005         (create_longjmp_master_breakpoint)
10006         (create_std_terminate_master_breakpoint)
10007         (create_exception_master_breakpoint): Use all_objfiles.
10008         * linux-thread-db.c (try_thread_db_load_from_pdir)
10009         (has_libpthread): Use all_objfiles.
10010         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10011         * linespec.c (iterate_over_all_matching_symtabs)
10012         (search_minsyms_for_name): Use all_objfiles.
10013         * maint.c (maintenance_info_sections): Use all_objfiles.
10014         * main.c (captured_main_1): Use all_objfiles.
10015         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10016         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10017         * guile/scm-pretty-print.c
10018         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10019         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10020         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10021         (maintenance_print_msymbols): Use all_objfiles.
10022         * source.c (select_source_symtab): Use all_objfiles.
10023         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10024         * symfile.c (remove_symbol_file_command)
10025         (expand_symtabs_matching, map_symbol_filenames): Use
10026         all_objfiles.
10027         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10028         all_objfiles.
10029         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10030         * objc-lang.c (find_methods): Use all_objfiles.
10031         * objfiles.c (have_partial_symbols, have_full_symbols)
10032         (have_minimal_symbols, qsort_cmp)
10033         (default_iterate_over_objfiles_in_search_order): Use
10034         all_objfiles.
10035         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10036         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10037         (maintenance_check_psymtabs): Use all_objfiles.
10038         (ALL_PSYMTABS): Remove.
10039         * compile/compile-object-run.c (do_module_cleanup): Use
10040         all_objfiles.
10041         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10042         * cp-support.c (add_symbol_overload_list_qualified): Use
10043         all_objfiles.
10044         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10045         Use all_objfiles.
10046         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10047         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10048         all_objfiles.
10049         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10050         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10051         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10052         Uses all_objfiles.
10053         * solib.c (solib_read_symbols): Use all_objfiles
10054
10055 2019-01-09  Tom Tromey  <tom@tromey.com>
10056
10057         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10058         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10059         all_objfiles.
10060         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10061         * symmisc.c (print_symbol_bcache_statistics)
10062         (print_objfile_statistics, maintenance_print_objfiles)
10063         (maintenance_info_symtabs, maintenance_check_symtabs)
10064         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10065         all_objfiles.
10066         * source.c (forget_cached_source_info): Use all_objfiles.
10067         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10068         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10069         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10070         * objfiles.c (update_section_map): Use all_objfiles.
10071         (shared_objfile_contains_address_p): Likewise.
10072         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10073         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10074
10075 2019-01-09  Tom Tromey  <tom@tromey.com>
10076
10077         * common/next-iterator.h: New file.
10078         * objfiles.h (class all_objfiles): New.
10079         (struct objfile_iterator): New.
10080
10081 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10082
10083         * NEWS: Move the description of the changed "frame", "select-frame",
10084          and "info frame" commands to the Changed commands section.
10085
10086 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10087
10088         * gdbtypes.c (check_stub_method_group): Remove handling of old
10089         mangling schemes.
10090         * linespec.c (find_methods): Likewise.
10091         * stabsread.c (read_member_functions): Likewise.
10092         * valops.c (search_struct_method): Likewise.
10093         (value_struct_elt_for_reference): Likewise.
10094         * NEWS: Mention this change.
10095
10096 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10097
10098         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10099         print_source_lines.
10100         * source.c (print_source_lines_base): Update line number check.
10101         (print_source_lines): New function.
10102         (source_lines_range::source_lines_range): New function.
10103         * source.h (class source_lines_range): New class.
10104         (print_source_lines): New declaration.
10105
10106 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10107
10108         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10109
10110 2019-01-08  Tom Tromey  <tom@tromey.com>
10111             Simon Marchi  <simon.marchi@ericsson.com>
10112
10113         PR gdb/24060
10114         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10115         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10116         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10117         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10118         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10119         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10120
10121 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10122
10123         * source.c (select_source_symtab): Move header comment to
10124         declaration in source.h.
10125         (forget_cached_source_info_for_objfile): Likewise.
10126         (forget_cached_source_info): Likewise.
10127         (identify_source_line): Likewise.
10128         * source.h (identify_source_line): Move declaration from symtab.h
10129         and add comment from source.c
10130         (print_source_lines): Likewise.
10131         (forget_cached_source_info_for_objfile): Likewise.
10132         (forget_cached_source_info): Likewise.
10133         (select_source_symtab): Likewise.
10134         (enum print_source_lines_flag): Move definition from symtab.h.
10135         * symtab.h (identify_source_line): Move declaration to source.h.
10136         (print_source_lines): Likewise.
10137         (forget_cached_source_info_for_objfile): Likewise.
10138         (forget_cached_source_info): Likewise.
10139         (select_source_symtab): Likewise.
10140         (enum print_source_lines_flag): Move definition to source.h.
10141         * tui/tui-hooks.c: Add 'source.h' include.
10142
10143 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10144
10145         * source.c (print_source_lines_base): Handle requests to print
10146         reverse line number sequences, and guard against empty lines
10147         string.
10148
10149 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10150
10151         * source.c (print_source_lines_base): Fix skip of '\r' if next
10152         character is '\n'.
10153
10154 2019-01-06  Tom Tromey  <tom@tromey.com>
10155
10156         * c-exp.y (struct c_parse_state) <macro_original_text,
10157         expansion_obstack>: New member.
10158         (macro_original_text, expansion_obstack): Remove globals.
10159         (scan_macro_expansion, scanning_macro_expansion)
10160         (finished_macro_expansion): Update.
10161         (scan_macro_cleanup): Remove.
10162         (yylex, c_parse): Update.
10163
10164 2019-01-06  Tom Tromey  <tom@tromey.com>
10165
10166         * c-exp.y (struct c_parse_state) <strings>: New member.
10167         (operator_stoken): Update.
10168
10169 2019-01-06  Tom Tromey  <tom@tromey.com>
10170
10171         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10172         (union type_stack_elt) <typelist_val>: Now a pointer to
10173         std::vector.
10174         (type_stack_cleanup): Don't declare.
10175         (push_typelist): Update.
10176         * parse.c (pop_typelist): Return a std::vector.
10177         (push_typelist): Take a std::vector.
10178         (follow_types): Update.  Do not free args.
10179         (type_stack_cleanup): Remove.
10180         * c-exp.y (struct c_parse_state): New.
10181         (cpstate): New global.
10182         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10183         (nonempty_typelist): Update.
10184         (func_mod): Create a new vector.
10185         (c_parse): Create a c_parse_state.
10186         (check_parameter_typelist): Do not delete params.
10187         (function_method): Update.  Do not delete type_list.
10188
10189 2019-01-06  Tom Tromey  <tom@tromey.com>
10190
10191         PR gdb/28155:
10192         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10193         check_typedef.
10194         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10195         (print_return_value): Likewise.
10196
10197 2019-01-05  Tom Tromey  <tom@tromey.com>
10198
10199         * contrib/cleanup_check.py: Remove.
10200         * contrib/gcc-with-excheck: Remove.
10201         * contrib/exsummary.py: Remove.
10202         * contrib/excheck.py: Remove.
10203
10204 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10205
10206         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10207         NULL. Initialize tpprev to NULL instead of assigning it
10208         to NULL on the next statement.
10209         * windows-nat.c (windows_delete_thread): Remove check for
10210         main_thread_id before printing thread exit notifications.
10211         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10212         Remove thread ID check against main_thread_id.
10213         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10214         windows_delete_thread.
10215         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10216
10217 2019-01-04  Tom Tromey  <tom@tromey.com>
10218
10219         * compile/compile.c (_initialize_compile): Use upper case for
10220         metasyntactic variables.
10221         * symmisc.c (_initialize_symmisc): Use upper case for
10222         metasyntactic variables.
10223         * psymtab.c (_initialize_psymtab): Use upper case for
10224         metasyntactic variables.
10225         * demangle.c (demangle_command): Use upper case for metasyntactic
10226         variables.
10227         (_initialize_demangler): Likewise.
10228         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10229         variables.
10230
10231 2019-01-03  Tom Tromey  <tom@tromey.com>
10232
10233         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10234
10235 2019-01-03  Tom Tromey  <tom@tromey.com>
10236
10237         * python/py-symtab.c (salpy_str): Update.
10238         (struct salpy_sal_object) <symtab>: Now a PyObject.
10239         (salpy_dealloc): Update.
10240         (del_objfile_sal): Use gdbpy_ref.
10241
10242 2019-01-03  Tom Tromey  <tom@tromey.com>
10243
10244         * python/py-type.c (convert_field): Use new_reference.  Return
10245         gdbpy_ref.
10246         (make_fielditem): Return gdbpy_ref.
10247         (typy_fields): Update.
10248         (typy_getitem): Update.
10249         (field_name): Return gdbpy_ref.  Use new_reference.
10250         (typy_iterator_iternext): Update.
10251
10252 2019-01-03  Tom Tromey  <tom@tromey.com>
10253
10254         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10255
10256 2019-01-03  Tom Tromey  <tom@tromey.com>
10257
10258         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10259         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10260         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10261         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10262         (pspy_set_type_printers): Likewise.
10263         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10264         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10265         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10266         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10267         (objfpy_set_type_printers): Likewise.
10268
10269 2019-01-03  Tom Tromey  <tom@tromey.com>
10270
10271         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10272         (gdbpy_print_stack): Use gdbpy_err_fetch.
10273         * python/python-internal.h (class gdbpy_err_fetch): New class.
10274         (class gdbpy_enter) <m_error_type, m_error_value,
10275         m_error_traceback>: Remove.
10276         <m_error>: New member.
10277         (gdbpy_exception_to_string): Don't declare.
10278         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10279         * python/py-value.c (convert_value_from_python): Use
10280         gdbpy_err_fetch.
10281         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10282         gdbpy_exception_to_string.
10283         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10284         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10285         gdbpy_err_fetch.
10286
10287 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10288
10289         * linux-nat.c (delete_lwp_cleanup): Delete.
10290         (struct lwp_deleter): New struct.
10291         (lwp_info_up): New typedef.
10292         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10293         lwp_info_up.
10294
10295 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10296
10297         * linux-fork.c (class scoped_switch_fork_info): New class.
10298         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10299
10300 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10301
10302         * valops.c (find_overload_match): Remove use of null_cleanup, and
10303         calls to do_cleanups.
10304
10305 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10306
10307         * compile/compile-cplus-types.c
10308         (compile_cplus_instance::decl_name): Handle changes to
10309         cp_func_name.
10310         * cp-support.c (cp_func_name): Update header comment, update
10311         return type.
10312         * cp-support.h (cp_func_name): Update return type in declaration.
10313         * valops.c (find_overload_match): Move temp_func local to top
10314         level of function and change its type.  Use temp_func to hold and
10315         delete temporary string obtained from cp_func_name.
10316
10317 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10318
10319         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10320         gdb::char_vector, remove cleanup, and update uses of `msg`.
10321
10322 2019-01-03  Jim Wilson  <jimw@sifive.com>
10323
10324         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10325
10326 2019-01-02  Tom Tromey  <tom@tromey.com>
10327
10328         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10329         (tdesc_parse_xml): Remove cleanups.
10330         * target-descriptions.h (make_cleanup_free_target_description):
10331         Don't declare.
10332         (target_desc_deleter): New struct.
10333         (target_desc_up): New typedef.
10334         * target-descriptions.c (target_desc_deleter::operator()): Rename
10335         from free_target_description.
10336         (make_cleanup_free_target_description): Remove.
10337
10338 2019-01-02  Tom Tromey  <tom@tromey.com>
10339
10340         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10341         constructor, destructor.
10342         (linespec_parser): Remove typedef.
10343         (~linespec_parser): Rename from linespec_parser_delete.
10344         (linespec_lex_to_end, linespec_complete_label)
10345         (linespec_complete): Update.
10346         (decode_line_full): Remove cleanups.
10347         (decode_line_1): Update.
10348
10349 2019-01-02  Tom Tromey  <tom@tromey.com>
10350
10351         * python/python-internal.h (inferior_to_inferior_object): Change
10352         return type.
10353         * python/py-exitedevent.c (create_exited_event_object): Update.
10354         * python/py-inferior.c (inferior_to_inferior_object): Return
10355         gdbpy_ref.
10356         (python_new_inferior, python_inferior_deleted)
10357         (thread_to_thread_object, delete_thread_object)
10358         (build_inferior_list, gdbpy_selected_inferior): Update.
10359         * python/py-infthread.c (create_thread_object): Update.  Also fail
10360         if inferior_to_inferior_object fails.
10361
10362 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10363
10364         * inferior.h (class inferior) <displaced_step_state>: New field.
10365         * infrun.h (struct displaced_step_state): Move here from
10366         infrun.c.  Initialize fields, add constructor.
10367         <inf>: Remove field.
10368         <reset>: New method.
10369         * infrun.c (struct displaced_step_inferior_state): Move to
10370         infrun.h.
10371         (displaced_step_inferior_states): Remove.
10372         (get_displaced_stepping_state): Adust.
10373         (displaced_step_in_progress_any_inferior): Adjust.
10374         (displaced_step_in_progress_thread): Adjust.
10375         (displaced_step_in_progress): Adjust.
10376         (add_displaced_stepping_state): Remove.
10377         (get_displaced_step_closure_by_addr): Adjust.
10378         (remove_displaced_stepping_state): Remove.
10379         (infrun_inferior_exit): Call displaced_step_state.reset.
10380         (use_displaced_stepping): Don't check for NULL.
10381         (displaced_step_prepare_throw): Call
10382         get_displaced_stepping_state.
10383         (displaced_step_fixup): Don't check for NULL.
10384         (prepare_for_detach): Don't check for NULL.
10385
10386 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10387
10388         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10389          in case of call that did not complete.
10390
10391 2019-01-02  Andrey Utkin  <autkin@undo.io>
10392
10393         * symfile.c (find_separate_debug_file): Fix search of debug files for
10394         remote debuggee.
10395
10396 2019-01-02  Tom Tromey  <tom@tromey.com>
10397
10398         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10399         indentation.
10400         * python/py-frame.c (frapy_older): Remove cast.
10401         (frapy_newer): Likewise.
10402         * python/py-breakpoint.c (local_setattro): Remove cast.
10403         * python/py-arch.c (archpy_name): Remove local variable.
10404         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10405
10406 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10407
10408         * unittests/basic_string_view/element_access/char/empty.cc:
10409         Fix year range in copyright header.
10410
10411 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10412
10413         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10414         Delete.
10415         <operator==>: Update with for removed field.
10416         <hash>: Likewise.
10417         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10418         <isa_features>: ...this.
10419         <abi_features>: New field.
10420         (riscv_isa_flen): Update comment.
10421         (riscv_abi_xlen): New declaration.
10422         (riscv_abi_flen): New declaration.
10423         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10424         isa_features.
10425         (riscv_abi_xlen): New function.
10426         (riscv_isa_flen): Update to get answer from isa_features.
10427         (riscv_abi_flen): New function.
10428         (riscv_has_fp_abi): Update to get answer from abi_features.
10429         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10430         xlen and flen.
10431         (riscv_call_info) <xlen, flen>: Update comment.
10432         (riscv_call_arg_struct): Remove invalid assertions
10433         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10434         is removed.
10435         (riscv_gdbarch_init): Gather isa features and abi features
10436         separately, ensure both match on the gdbarch when reusing an old
10437         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10438         a target with 64-bit float hardware.
10439
10440 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10441
10442         * source.c (search_command_helper): Stop reverse search
10443         when line 1 has been searched.
10444
10445 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10446
10447         * record-full.c (record_full_base_target::close): Rewrite
10448         record_full_core_buf_list free logic.
10449
10450 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10451
10452         * break-catch-syscall.c (print_one_catch_syscall): xfree
10453         the last text.
10454
10455 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10456
10457         * top.c (print_gdb_version): Update Copyright year in version
10458         message.
10459
10460 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10461
10462         Update copyright year range in all GDB files.
10463
10464 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10465
10466         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10467
10468 For older changes see ChangeLog-2018.
10469 \f
10470 Local Variables:
10471 mode: change-log
10472 left-margin: 8
10473 fill-column: 74
10474 version-control: never
10475 coding: utf-8
10476 End:
10477