gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
   4         * symfile-debug.c (debug_sym_get_probes): Change type.
   5         * stap-probe.c (handle_stap_probe):
   6         (stap_static_probe_ops::get_probes): Change type.
   7         * probe.h (class static_probe_ops) <get_probes>: Change type.
   8         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
   9         (parse_probes_in_pspace): Update.
  10         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  11         Update.
  12         (any_static_probe_ops::get_probes): Change type.
  13         * elfread.c (elfread_data): New typedef.
  14         (probe_key): Change type.
  15         (elf_get_probes): Likewise.  Update.
  16         (probe_key_free): Remove.
  17         (_initialize_elfread): Update.
  18         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
  19         Change type.
  20         (dtrace_process_dof_probe, dtrace_process_dof)
  21         (dtrace_static_probe_ops::get_probe): Change type.
  22
  23 2019-05-08  Tom Tromey  <tom@tromey.com>
  24
  25         * xcoffread.c (struct xcoff_symfile_info): Rename from
  26         coff_symfile_info.  Add initializers.
  27         (xcoff_objfile_data_key): Move lower.  Change type.
  28         (XCOFF_DATA): Rewrite.
  29         (xcoff_free_info): Remove.
  30         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
  31         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
  32         (xcoff_initial_scan): Update.
  33
  34 2019-05-08  Tom Tromey  <tom@tromey.com>
  35
  36         * solib-svr4.c (struct svr4_info): Add initializers and
  37         destructor.
  38         <probes_table>: Now an htab_up.
  39         (solib_svr4_pspace_data): Change type.
  40         (free_probes_table): Simplify.
  41         (~svr4_info): Rename from svr4_pspace_data_cleanup.
  42         (get_svr4_info, probes_table_htab_remove_objfile_probes)
  43         (probes_table_remove_objfile_probes, register_solib_event_probe)
  44         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
  45         (_initialize_svr4_solib): Update.
  46
  47 2019-05-08  Tom Tromey  <tom@tromey.com>
  48
  49         * remote.c (remote_pspace_data): Change type.
  50         (remote_pspace_data_cleanup): Remove.
  51         (get_remote_exec_file, set_pspace_remote_exec_file)
  52         (_initialize_remote): Update.
  53
  54 2019-05-08  Tom Tromey  <tom@tromey.com>
  55
  56         * breakpoint.c (breakpoint_objfile_key): Change type.
  57         (get_breakpoint_objfile_data): Update.
  58         (free_breakpoint_objfile_data): Remove.
  59         (_initialize_breakpoint): Update.
  60
  61 2019-05-08  Tom Tromey  <tom@tromey.com>
  62
  63         * linux-tdep.c (struct linux_info): Add initializers.
  64         (linux_inferior_data): Move.  Change type.
  65         (invalidate_linux_cache_inf): Update.
  66         (linux_inferior_data_cleanup): Remove.
  67         (get_linux_inferior_data, _initialize_linux_tdep): Update.
  68
  69 2019-05-08  Tom Tromey  <tom@tromey.com>
  70
  71         * auxv.c (auxv_inferior_data): Move.  Change type.
  72         (auxv_inferior_data_cleanup): Remove.
  73         (invalidate_auxv_cache_inf): Rewrite.
  74         (get_auxv_inferior_data, _initialize_auxv): Update.
  75
  76 2019-05-08  Tom Tromey  <tom@tromey.com>
  77
  78         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
  79         (symfile_debug_objfile_data_key): Change type.
  80         (symfile_debug_installed, debug_qf_has_symbols)
  81         (debug_qf_find_last_source_symtab)
  82         (debug_qf_forget_cached_source_info)
  83         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
  84         (debug_qf_print_stats, debug_qf_dump)
  85         (debug_qf_expand_symtabs_for_function)
  86         (debug_qf_expand_all_symtabs)
  87         (debug_qf_expand_symtabs_with_fullname)
  88         (debug_qf_map_matching_symbols)
  89         (debug_qf_expand_symtabs_matching)
  90         (debug_qf_find_pc_sect_compunit_symtab)
  91         (debug_qf_map_symbol_filenames)
  92         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
  93         (debug_sym_new_init, debug_sym_init, debug_sym_read)
  94         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
  95         (debug_sym_read_linetable, debug_sym_relocate): Update.
  96         (symfile_debug_free_objfile): Remove.
  97         (install_symfile_debug_logging, _initialize_symfile_debug):
  98         Update.
  99
 100 2019-05-08  Tom Tromey  <tom@tromey.com>
 101
 102         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 103         allocate_on_obstack.
 104         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 105         (get_dwarf2_per_objfile): Update.
 106         (set_dwarf2_per_objfile): Remove.
 107         (dwarf2_has_info, dwarf2_get_section_info): Update.
 108         (dwarf2_free_objfile): Remove.
 109         (_initialize_dwarf2_read): Update.
 110
 111 2019-05-08  Tom Tromey  <tom@tromey.com>
 112
 113         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 114         initializers.
 115         <unsupported_script_warning_printed,
 116         script_not_found_warning_printed>: Now bool.
 117         (auto_load_pspace_data): Change type.
 118         (~auto_load_pspace_info): Rename from
 119         auto_load_pspace_data_cleanup.
 120         (get_auto_load_pspace_data, init_loaded_scripts_info)
 121         (clear_section_scripts, maybe_print_unsupported_script_warning)
 122         (maybe_print_script_not_found_warning, _initialize_auto_load):
 123         Update.
 124
 125 2019-05-08  Tom Tromey  <tom@tromey.com>
 126
 127         * objfiles.c (objfile_pspace_info): Add destructor and
 128         initializers.
 129         (objfiles_pspace_data): Change type.
 130         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 131         (get_objfile_pspace_data): Update.
 132         (objfiles_bfd_data): Change type.
 133         (get_objfile_bfd_data): Update.
 134         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 135
 136 2019-05-08  Tom Tromey  <tom@tromey.com>
 137
 138         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 139         Change type.
 140         (get_catch_syscall_inferior_data): Update.
 141         (catch_syscall_inferior_data_cleanup): Remove.
 142         (_initialize_break_catch_syscall): Update.
 143
 144 2019-05-08  Tom Tromey  <tom@tromey.com>
 145
 146         * inflow.c (struct terminal_info): Add destructor and
 147         initializers.
 148         (inflow_inferior_data): Change type.
 149         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 150         (get_inflow_inferior_data, inflow_inferior_exit)
 151         (swap_terminal_info, _initialize_inflow): Update.
 152
 153 2019-05-08  Tom Tromey  <tom@tromey.com>
 154
 155         * target-dcache.c (target_dcache_cleanup): Remove.
 156         (target_dcache_aspace_key): Change type.
 157         (target_dcache_init_p, target_dcache_invalidate)
 158         (target_dcache_get, target_dcache_get_or_init)
 159         (_initialize_target_dcache): Update.
 160         * dcache.h (struct dcache_deleter): New.
 161
 162 2019-05-08  Tom Tromey  <tom@tromey.com>
 163
 164         * symtab.c (struct symbol_cache): Add destructor and
 165         initializers.
 166         (symbol_cache_key): Move.  Change type.
 167         (make_symbol_cache, free_symbol_cache): Remove.
 168         (get_symbol_cache): Update.
 169         (symbol_cache_cleanup): Remove.
 170         (ALL_PSPACES, symbol_cache_flush)
 171         (maintenance_print_symbol_cache)
 172         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 173         Update.
 174
 175 2019-05-08  Tom Tromey  <tom@tromey.com>
 176
 177         * symtab.c (struct main_info): Add destructor and initializers.
 178         (main_progspace_key): Move.  Change type.
 179         (get_main_info): Update.
 180         (main_info_cleanup): Remove.
 181         (_initialize_symtab): Update.
 182
 183 2019-05-08  Tom Tromey  <tom@tromey.com>
 184
 185         * registry.h (DECLARE_REGISTRY): Define the _key class.
 186
 187 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 188
 189         * NEWS: Merge two 'New commands' sections.
 190
 191 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 192
 193         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 194         parameter and use Ada language definition instead.
 195         (ada_val_print_ptr): Remove unused language parameter.
 196         (ada_val_print_num): Remove language parameter and use Ada language
 197         definition instead.
 198         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 199         parameter.
 200         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 201         parameter and use Ada language definition instead.
 202         (ada_val_print_1): Update all ada_val_print_xxx calls.
 203         Remove language parameter.
 204         (ada_val_print): Update ada_val_print_1 call.
 205
 206 2019-05-08  Tom Tromey  <tromey@adacore.com>
 207
 208         * remote.c (remote_hw_watchpoint_limit)
 209         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 210         Now static.
 211
 212 2019-05-08  Tom Tromey  <tromey@adacore.com>
 213
 214         * maint.c (_initialize_maint_cmds): Move initialization code to
 215         remote.c.
 216         (watchdog, show_watchdog): Move to remote.c.
 217         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 218         "watchdog" static.
 219         (_initialize_remote): Move initialization code from maint.c.
 220         * defs.h (watchdog): Don't declare.
 221
 222 2019-05-08  Tom Tromey  <tromey@adacore.com>
 223
 224         * tui/tui-interp.c: Include main.h.
 225         * interps.c: Include main.h.
 226         * main.h (interpreter_p): Declare.
 227         * defs.h (interpreter_p): Don't declare.
 228
 229 2019-05-08  Tom Tromey  <tromey@adacore.com>
 230
 231         * dwarf2loc.c: Include dwarf2read.h.
 232         * defs.h (read_unsigned_leb128): Don't declare.
 233         * dwarf2read.h (read_unsigned_leb128): Declare.
 234
 235 2019-05-08  Tom Tromey  <tromey@adacore.com>
 236
 237         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 238         method.
 239
 240 2019-05-08  Tom Tromey  <tromey@adacore.com>
 241
 242         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 243         when no wrap column is set.
 244
 245 2019-05-08  Tom Tromey  <tromey@adacore.com>
 246
 247         * c-lang.c (c_get_string): Handle non-C-style arrays.
 248
 249 2019-05-08  Tom Tromey  <tromey@adacore.com>
 250
 251         * typeprint.c (print_offset_data::update): Print the bit offset,
 252         not the number of bits remaining.
 253
 254 2019-05-08  Tom Tromey  <tromey@adacore.com>
 255
 256         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 257         padding at end of comment.
 258
 259 2019-05-08  Tom Tromey  <tromey@adacore.com>
 260
 261         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 262         Compare main types.
 263
 264 2019-05-06  Tom Tromey  <tom@tromey.com>
 265
 266         * common/scoped_mmap.c: Include common-defs.h.
 267         * common/scoped_mmap.h: Don't include config.h.
 268
 269 2019-05-04  Tom Tromey  <tom@tromey.com>
 270
 271         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 272         (struct aarch64_call_info): Add initializers.
 273         <si>: Now a std::vector.
 274         (pass_on_stack, aarch64_push_dummy_call): Update.
 275
 276 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 277             Tom Tromey  <tom@tromey.com>
 278
 279         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 280         (ppc_threads): Now a std::vector.  Now static.
 281         (hwdebug_find_thread_points_by_tid)
 282         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 283         Update.
 284
 285 2019-05-04  Tom Tromey  <tom@tromey.com>
 286
 287         * arc-tdep.c (arc_tdesc_init): Return bool.
 288
 289 2019-05-04  Tom Tromey  <tom@tromey.com>
 290
 291         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 292         Use gdb_assert_not_reached.
 293
 294 2019-05-04  Tom Tromey  <tom@tromey.com>
 295
 296         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 297         "false".
 298
 299 2019-05-04  Tom Tromey  <tom@tromey.com>
 300
 301         * arc-tdep.c (arc_tdesc_init): Use bool.
 302
 303 2019-05-04  Tom Tromey  <tom@tromey.com>
 304
 305         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 306
 307 2019-05-04  Tom Tromey  <tom@tromey.com>
 308
 309         * cli/cli-cmds.c (valid_command_p): Return bool.
 310
 311 2019-05-04  Tom Tromey  <tom@tromey.com>
 312
 313         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 314         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 315
 316 2019-05-04  Raul Tambre  <raul@tambre.ee>
 317
 318         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 319         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 320         operator for comparison.
 321
 322 2019-05-04  Tom Tromey  <tom@tromey.com>
 323
 324         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 325         (lookup_partial_symbol, print_partial_symbols)
 326         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 327         (psymbol_compare): Update.
 328         (add_psymbol_to_bcache): Clear the entire psymbol.
 329         (maintenance_check_psymtabs): Update.
 330         * psympriv.h (struct partial_symbol): Don't derive from
 331         general_symbol_info.
 332         <obj_section, unrelocated_address, address,
 333         set_unrelocated_address>: Update.
 334         <ginfo>: New member.
 335         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 336         (debug_names::write_psymbols): Update.
 337
 338 2019-05-04  Tom de Vries  <tdevries@suse.de>
 339
 340         * contrib/cc-with-tweaks.sh: Support -n arg.
 341
 342 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 343
 344         * corelow.c (core_target::detach): Ensure frame cache and
 345         register caches are cleared.
 346         inferior.c (exit_inferior_1): Likewise.
 347
 348 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 349             Tom Tromey  <tom@tromey.com>
 350
 351         * dictionary.c (collate_pending_symbols_by_language): Remove
 352         "struct" from foreach.
 353         * symtab.c (lookup_global_symbol_from_objfile)
 354         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 355         foreach.
 356         * ser-tcp.c (net_open): Remove "struct" from foreach.
 357         * objfiles.c (objfile_relocate, objfile_rebase)
 358         (objfile_has_symbols): Remove "struct" from foreach.
 359         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 360         from foreach.
 361         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 362         foreach.
 363         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 364         "struct" from foreach.
 365         * ada-lang.c (create_excep_cond_exprs)
 366         (ada_exception_catchpoint_cond_string): Remove "struct" from
 367         foreach.
 368
 369 2019-05-03  Tom Tromey  <tromey@adacore.com>
 370
 371         * ada-exp.y (convert_char_literal): Check suffix of each
 372         enumerator.
 373
 374 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 375
 376         PR ada/21406:
 377         * ada-exp.y (yywrap): Don't define.
 378         * ada-lex.l (%option): Add noyywrap
 379         (yywrap): Remove.
 380
 381 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 382
 383         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 384         _WIN32_WINNT to the XP level, unless already defined to a higher
 385         level.
 386
 387         * unittests/parse-connection-spec-selftests.c:
 388         * ser-tcp.c:
 389         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 390         override.
 391
 392         * symfile.c (find_separate_debug_file): Remove colon from the
 393         drive spec of DOS/Windows file names of the target, so that the
 394         file name produced from DEBUGDIR and the target's directory will
 395         be valid on DOS/Windows systems.
 396
 397 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 398
 399         * rust-lang.c (val_print_struct): Handle printing structures
 400         containing strings.
 401
 402 2019-05-02  Tom Tromey  <tromey@adacore.com>
 403
 404         * valarith.c (_initialize_valarith): Remove.
 405
 406 2019-05-01  Tom Tromey  <tromey@adacore.com>
 407
 408         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 409         bitfields.
 410
 411 2019-05-01  Tom Tromey  <tromey@adacore.com>
 412
 413         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 414         for big-endian copies.
 415
 416 2019-04-30  Ali Tamur  <tamur@google.com>
 417         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 418         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 419         (read_3_bytes): New function.
 420
 421 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 422
 423         * windows-nat.c (main_thread_id): Delete.
 424         (handle_output_debug_string): Replace main_thread_id by
 425         current_event.dwThreadId.
 426         (fake_create_process): Likewise.
 427         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 428         Do not set main_thread_id.
 429         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 430         current_event.dwThreadId.
 431         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 432
 433 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 434
 435         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 436         Use current_event.dwThreadId instead of main_thread_id.
 437
 438 2019-04-30  Tom Tromey  <tromey@adacore.com>
 439
 440         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 441         (create_excep_cond_exprs): Iterate over program spaces.
 442         (ada_exception_catchpoint_cond_string): Examine all minimal
 443         symbols for exception types.
 444
 445 2019-04-30  Tom Tromey  <tromey@adacore.com>
 446
 447         PR c++/24470:
 448         * dwarf2read.c (process_structure_scope): Handle case where type
 449         has template parameters but no symbol was created.
 450
 451 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 452             Chris January  <chris.january@arm.com>
 453
 454         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 455         qualifier.
 456         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 457
 458 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 459
 460         * f-typeprint.c (f_print_type): Update rules for printing
 461         whitespace.
 462         (f_type_print_varspec_suffix): Likewise.
 463
 464 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 465             Chris January  <chris.january@arm.com>
 466
 467         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 468         function arguments.
 469
 470 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 471
 472         * f-lang.c (build_fortran_types): Change name of void type to
 473         lower case.
 474         * f-typeprint.c (f_type_print_base): Print the name of the void
 475         type, rather than a fixed string.
 476         * f-valprint.c (f_decorations): Use lower case void string.
 477
 478 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 479             Chris January  <chris.january@arm.com>
 480
 481         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 482         types for Fortran.
 483
 484 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 485             Chris January  <chris.january@arm.com>
 486             David Lecomber  <david.lecomber@arm.com>
 487
 488         * f-exp.y (BINOP_INTRINSIC): New token.
 489         (exp): New parser rule handling BINOP_INTRINSIC.
 490         (f77_keywords): Add new builtin procedures.
 491         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 492         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 493         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 494         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 495         (print_unop_subexp_f): New function.
 496         (print_binop_subexp_f): New function.
 497         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 498         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 499         (dump_subexp_body_f): Likewise.
 500         (operator_check_f): Likewise.
 501         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 502         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 503
 504 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 507         UNOP_KIND.
 508         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 509         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 510         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 511         (operator_length_f): New fuction.
 512         (print_subexp_f): New function.
 513         (op_name_f): New function.
 514         (dump_subexp_body_f): New function.
 515         (operator_check_f): New function.
 516         (exp_descriptor_f): Replace standard expression handling functions
 517         with new functions.
 518         * gdb/fortran-operator.def: New file.
 519         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 520         * gdb/std-operator.def: Remove UNOP_KIND.
 521
 522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 523
 524         * std-operator.def: Remove unbalanced, stray double quote
 525         character.
 526
 527 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 528             Chris January  <chris.january@arm.com>
 529             Daniel Everett  <daniel.everett@arm.com>
 530             Nick Forrington  <nick.forrington@arm.com>
 531             Richard Bunt  <richard.bunt@arm.com>
 532
 533         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 534         of depth when printing anonymous structs or unions.
 535         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 536         Don't print either the top-level value, or the children if the
 537         max-depth is exceeded.
 538         (ppscm_print_children): When printing the key of a map, allow one
 539         extra level of depth.
 540         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 541         print either the top-level value, or the children if the max-depth
 542         is exceeded.
 543         (print_children): When printing the key of a map, allow one extra
 544         level of depth.
 545         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 546         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 547         (user_print_options): Initialise max_depth field.
 548         (val_print_scalar_or_string_type_p): New function.
 549         (val_print): Check to see if the max depth has been reached.
 550         (val_print_check_max_depth): Define new function.
 551         (show_print_max_depth): New function.
 552         (_initialize_valprint): Add 'print max-depth' option.
 553         * valprint.h (struct value_print_options) <max_depth>: New field.
 554         (val_print_check_max_depth): Declare new function.
 555         * NEWS: Document new feature.
 556
 557 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * ada-lang.c (ada_language_defn): Initialise new field.
 560         * c-lang.c (c_is_string_type_p): New function.
 561         (c_language_defn): Initialise new field.
 562         (cplus_language_defn): Initialise new field.
 563         (asm_language_defn): Initialise new field.
 564         (minimal_language_defn): Initialise new field.
 565         * c-lang.h (c_is_string_type_p): Declare new function.
 566         * d-lang.c (d_language_defn): Initialise new field.
 567         * f-lang.c (f_is_string_type_p): New function.
 568         (f_language_defn): Initialise new field.
 569         * go-lang.c (go_is_string_type_p): New function.
 570         (go_language_defn): Initialise new field.
 571         * language.c (default_is_string_type_p): New function.
 572         (unknown_language_defn): Initialise new field.
 573         (auto_language_defn): Initialise new field.
 574         * language.h (struct language_defn) <la_is_string_type_p>: New
 575         member variable.
 576         (default_is_string_type_p): Declare new function.
 577         * m2-lang.c (m2_language_defn): Initialise new field.
 578         * objc-lang.c (objc_language_defn): Initialise new field.
 579         * opencl-lang.c (opencl_language_defn): Initialise new field.
 580         * p-lang.c (pascal_is_string_type_p): New function.
 581         (pascal_language_defn): Initialise new field.
 582         * rust-lang.c (rust_is_string_type_p): New function.
 583         (rust_language_defn): Initialise new field.
 584
 585 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 586
 587         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 588         New field.
 589         * ada-lang.c (ada_language_defn): Initialise new field.
 590         * c-lang.c (c_language_defn): Likewise.
 591         (cplus_language_defn): Likewise.
 592         (asm_language_defn): Likewise.
 593         (minimal_language_defn): Likewise.
 594         * d-lang.c (d_language_defn): Likewise.
 595         * f-lang.c (f_language_defn): Likewise.
 596         * go-lang.c (go_language_defn): Likewise.
 597         * language.c (unknown_language_defn): Likewise.
 598         (auto_language_defn): Likewise.
 599         * m2-lang.c (m2_language_defn): Likewise.
 600         * objc-lang.c (objc_language_defn): Likewise.
 601         * opencl-lang.c (opencl_language_defn): Likewise.
 602         * p-lang.c (pascal_language_defn): Likewise.
 603         * rust-lang.c (rust_language_defn): Likewise.
 604
 605 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 606
 607         * ada-lang.c (ada_is_character_type): Change return type to bool.
 608         (ada_is_string_type): Likewise.
 609         * ada-lang.h (ada_is_character_type): Update declaration
 610         (ada_is_string_type): Likewise.
 611
 612 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 613
 614         Support style in 'frame|thread apply'
 615
 616         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 617         * record.c (record_start, record_stop): Update callers of
 618         execute_command_to_string with false.
 619         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 620         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 621         methods.
 622         (class string_file): New constructor with term_out parameter.
 623         Override methods term_out and can_emit_style_escape.  New member
 624         term_out.
 625         (class stdio_file): Override can_emit_style_escape.
 626         (class tee_file): Override term_out and can_emit_style_escape.
 627         * utils.h (can_emit_style_escape): Remove.
 628         * utils.c (can_emit_style_escape): Likewise.
 629         Update all callers of can_emit_style_escape (SOMESTREAM) to
 630         SOMESTREAM->can_emit_style_escape.
 631         * source-cache.c (source_cache::get_source_lines): Likewise.
 632         * stack.c (frame_apply_command_count): Call execute_command_to_string
 633         passing the term_out characteristic of the current gdb_stdout.
 634         * thread.c (thr_try_catch_cmd): Likewise.
 635         * top.c (execute_command_to_string): pass term_out parameter
 636         to construct the string_file for the command output.
 637         * ui-file.c (term_cli_styling): New function (most code moved
 638         from utils.c can_emit_style_escape).
 639         (string_file::string_file, string_file::can_emit_style_escape,
 640         stdio_file::can_emit_style_escape, tee_file::term_out,
 641         tee_file::can_emit_style_escape): New functions.
 642
 643 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 644
 645         * NEWS: Mention the new set|show may-call-functions.
 646         * infcall.c (may_call_functions_p): New variable.
 647         (show_may_call_functions_p): New function.
 648         (call_function_by_hand_dummy): Throws an error if not
 649         may-call-functions.
 650         (_initialize_infcall): Call add_setshow_boolean_cmd for
 651         may-call-functions.
 652
 653 2019-04-25  Keith Seitz  <keiths@redhat.com>
 654
 655         PR c++/24367
 656         * cp-support.c (inspect_type): Don't attempt substitutions
 657         of symbol with the same name.
 658
 659 2019-04-25  Tom Tromey  <tromey@adacore.com>
 660
 661         PR gdb/24475:
 662         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 663         static.
 664
 665 2019-04-25  Tom Tromey  <tromey@adacore.com>
 666
 667         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 668         rvalue reference.
 669         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 670         (gdb_xml_parser::parse): Use std::move.
 671         * python/python-internal.h (gdbpy_convert_exception): Take a const
 672         reference.
 673         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 674         std::move.
 675         * python/py-utils.c (gdbpy_convert_exception): Take a const
 676         reference.
 677         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 678         Use std::move.
 679         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 680         Use std::move.
 681         * mi/mi-main.c (mi_print_exception): Take a const reference.
 682         * main.c (handle_command_errors): Take a const reference.
 683         * linespec.c (parse_linespec): Use std::move.
 684         * infcall.c (run_inferior_call): Use std::move.
 685         (call_function_by_hand_dummy): Use std::move.
 686         * exec.c (try_open_exec_file): Use std::move.
 687         * exceptions.h (exception_print, exception_fprintf)
 688         (exception_print_same): Update.
 689         * exceptions.c (print_exception, exception_print)
 690         (exception_fprintf, exception_print_same): Change parameters to
 691         const reference.
 692         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 693         * common/new-op.c: Use std::move.
 694         * common/common-exceptions.h (struct gdb_exception): Add move
 695         constructor.
 696         (struct gdb_exception_error, struct gdb_exception_quit, struct
 697         gdb_quit_bad_alloc): Change constructor to move constructor.
 698         (throw_exception): Change parameter to rvalue reference.
 699         * common/common-exceptions.c (throw_exception): Take rvalue
 700         reference.
 701         * cli/cli-interp.c (safe_execute_command): Use std::move.
 702         * breakpoint.c (insert_bp_location, location_to_sals): Use
 703         std::move.
 704
 705 2019-04-25  Tom Tromey  <tromey@adacore.com>
 706
 707         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 708         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 709         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 710         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 711         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 712         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 713         guile/scm-value.c: Use unpack.
 714         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 715         gdbscm_gdb_exception.
 716         (gdbscm_throw_gdb_exception): Likewise.
 717         (struct gdbscm_gdb_exception): New.
 718         (unpack): New function.
 719         (gdbscm_wrap): Use unpack.
 720
 721 2019-04-25  Tom Tromey  <tromey@adacore.com>
 722
 723         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 724         (gdb_rl_callback_handler): Use std::move.
 725         * common/common-exceptions.h (struct gdb_exception): Add move
 726         assignment operator.
 727         (throw_exception_sjlj): Change "exception" to const reference.
 728         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 729         (throw_exception_sjlj): Change "exception" to const reference.
 730
 731 2019-04-25  Tom Tromey  <tromey@adacore.com>
 732
 733         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 734         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 735         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 736         Update.
 737         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 738         Update.
 739         * mi/mi-interp.c (mi_interp::exec): Update.
 740         * linespec.c (parse_linespec): Update.
 741         * infcall.c (run_inferior_call): Update.
 742         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 743         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 744         (gdbscm_lookup_global_symbol): Update.
 745         * guile/scm-param.c (gdbscm_parameter_value): Update.
 746         * guile/scm-frame.c (gdbscm_frame_read_register)
 747         (gdbscm_frame_read_var): Update.
 748         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 749         * exec.c (try_open_exec_file): Update.
 750         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 751         (gdb_rl_callback_handler): Update.
 752         * common/common-exceptions.h (exception_none): Don't declare.
 753         * common/common-exceptions.c (exception_none): Don't define.
 754         (struct catcher) <exception>: Update.
 755         * cli/cli-interp.c (safe_execute_command): Update.
 756         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 757
 758 2019-04-25  Ali Tamur  <tamur@google.com>
 759
 760         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 761         (read_attribute_value): Likewise.
 762         (dwarf2_read_addr_index): Update comment.
 763         (read_str_index): Add DW_FORM_strx.
 764         (dwarf2_string_attr): Likewise.
 765         (dwarf2_const_value_attr): Likewise.
 766         (dump_die_shallow): Likewise.
 767         (dwarf2_fetch_constant_bytes): Likewise.
 768         (skip_form_bytes): Likewise.
 769         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 770
 771 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 772
 773         PR corefiles/11608
 774         PR corefiles/18187
 775         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 776         OFFSET.  Verify if current mapping contains an ELF header.
 777         (linux_find_memory_regions_full): Adjust call to
 778         dump_mapping_p.
 779
 780 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 781             Kang Li <kanglictf@gmail.com>
 782
 783         PR gdb/21600
 784
 785         * dwarf2-frame.c (read_initial_length): Be consistent about using
 786         unsigned representation of length.
 787         (decode_frame_entry_1): Likewise.  Check for wraparound of
 788         end pointer as well as buffer overflow.
 789
 790 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 791
 792         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 793         "vq".
 794
 795 2019-04-24  Tom Tromey  <tromey@adacore.com>
 796
 797         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 798
 799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 800
 801         * s12z-tdep.c (s12z_unwind_pc): Delete.
 802         (s12z_unwind_sp): Delete.
 803         (s12z_gdbarch_init): Don't register deleted functions with
 804         gdbarch.
 805
 806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * rl78-tdep.c (rl78_unwind_sp): Delete.
 809         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 810
 811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 814         (xstormy16_unwind_pc): Delete.
 815         (xstormy16_dummy_id): Delete.
 816         (xstormy16_gdbarch_init): Don't register deleted functions with
 817         gdbarch.
 818
 819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 820
 821         * vax-tdep.c (vax_unwind_pc): Delete.
 822         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 823
 824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 825
 826         * v850-tdep.c (v850_unwind_sp): Delete.
 827         (v850_unwind_pc): Delete.
 828         (v850_dummy_id): Delete.
 829         (v850_gdbarch_init): Don't register deleted functions with
 830         gdbarch.
 831
 832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 835         (tilegx_unwind_pc): Delete.
 836         (tilegx_unwind_dummy_id): Delete.
 837         (tilegx_gdbarch_init): Don't register deleted functions with
 838         gdbarch.
 839
 840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 843         (tic6x_dummy_id): Delete.
 844         (tic6x_gdbarch_init): Don't register deleted functions with
 845         gdbarch.
 846
 847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 848
 849         * sparc-tdep.c (sparc_unwind_pc): Delete.
 850         (sparc32_gdbarch_init): Don't register deleted function with
 851         gdbarch.
 852
 853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * sh-tdep.c (sh_unwind_sp): Delete.
 856         (sh_unwind_pc): Delete.
 857         (sh_dummy_id): Delete.
 858         (sh_gdbarch_init): Don't register deleted functions with
 859         gdbarch.
 860
 861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 862
 863         * score-tdep.c (score_unwind_sp): Delete.
 864         (score_unwind_pc): Delete.
 865         (score_dummy_id): Delete.
 866         (score_gdbarch_init): Don't register deleted functions with
 867         gdbarch.
 868
 869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 870
 871         * rx-tdep.c (rx_unwind_pc): Delete.
 872         (rx_unwind_sp): Delete.
 873         (rx_dummy_id): Delete.
 874         (rx_gdbarch_init): Don't register deleted functions with
 875         gdbarch.  Update comment.
 876
 877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 878
 879         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 880         (rs6000_dummy_id): Delete.
 881         (rs6000_gdbarch_init): Don't register deleted functions with
 882         gdbarch.
 883
 884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 885
 886         * or1k-tdep.c (or1k_dummy_id): Delete.
 887         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 888
 889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 890
 891         * nios2-tdep.c (nios2_dummy_id): Delete.
 892         (nios2_unwind_sp): Delete.
 893         (nios2_gdbarch_init): Don't register deleted functions with
 894         gdbarch.
 895
 896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 897
 898         * nds32-tdep.c (nds32_dummy_id): Delete.
 899         (nds32_unwind_pc): Delete.
 900         (nds32_unwind_sp): Delete.
 901         (nds32_gdbarch_init): Don't register deleted functions with
 902         gdbarch.
 903
 904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * msp430-tdep.c (msp430_unwind_pc): Delete.
 907         (msp430_unwind_sp): Delete.
 908         (msp430_dummy_id): Delete.
 909         (msp430_gdbarch_init): Don't register deleted functions with
 910         gdbarch.
 911
 912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * moxie-tdep.c (moxie_unwind_sp): Delete.
 915         (moxie_unwind_pc): Delete.
 916         (moxie_dummy_id): Delete.
 917         (moxie_gdbarch_init): Don't register deleted functions with
 918         gdbarch.
 919
 920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 921
 922         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 923         (mn10300_unwind_pc): Delete.
 924         (mn10300_unwind_sp): Delete.
 925         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 926         mn10300_unwind_sp.
 927         (mn10300_frame_unwind_init): Don't register deleted functions with
 928         gdbarch.
 929
 930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * mep-tdep.c (mep_unwind_pc): Delete.
 933         (mep_unwind_sp): Delete.
 934         (mep_dummy_id): Delete.
 935         (mep_gdbarch_init): Don't register deleted functions with
 936         gdbarch.
 937
 938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 939
 940         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 941         (m68hc11_unwind_sp): Delete.
 942         (m68hc11_gdbarch_init): Don't register deleted functions with
 943         gdbarch.
 944
 945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 946
 947         * m32r-tdep.c (m32r_unwind_sp): Delete.
 948         (m32r_unwind_pc): Delete.
 949         (m32r_dummy_id): Delete.
 950         (m32r_gdbarch_init): Don't register deleted functions with
 951         gdbarch.
 952
 953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * m32c-tdep.c (m32c_unwind_pc): Delete.
 956         (m32c_unwind_sp): Delete.
 957         (m32c_dummy_id): Delete.
 958         (m32c_gdbarch_init): Don't register deleted functions with
 959         gdbarch.
 960
 961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 962
 963         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 964         (lm32_unwind_pc): Delete.
 965         (lm32_dummy_id): Delete.
 966         (lm32_gdbarch_init): Don't register deleted functions with
 967         gdbarch.
 968
 969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 970
 971         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 972         (iq2000_unwind_pc): Delete.
 973         (iq2000_dummy_id): Delete.
 974         (iq2000_gdbarch_init): Don't register deleted functions with
 975         gdbarch.
 976
 977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * nds32-tdep.c (nds32_type_align): Delete.
 980         (nds32_push_dummy_call): Use type_align instead.
 981
 982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 983
 984         * arm-tdep.c (arm_type_align): Only handle vector override case.
 985         (arm_push_dummy_call): Use type_align.
 986         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 987
 988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 991         case.
 992         (pass_on_stack): Use type_align.
 993         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 994         function.
 995
 996 2019-04-23  Tom Tromey  <tromey@adacore.com>
 997
 998         * dwarf2read.c (line_header::file_name_at): Remove unused
 999         overload.
1000
1001 2019-04-23  Tom de Vries  <tdevries@suse.de>
1002
1003         PR gdb/24438
1004         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1005         invocation.
1006
1007
1008 2019-03-27  Ali Tamur  <tamur@google.com>
1009
1010         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1011         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1012         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1013         (dwarf_expr_context::get_addr_index): Likewise
1014         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1015         (symbol_needs_eval_context::get_addr_index): Likewise
1016         (disassemble_dwarf_expression): Add DW_OP_addrx
1017         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1018         (read_cutu_die_from_dwo): Update comment
1019         (skip_one_die): Add DW_FORM_addrx
1020         (read_attribute_value): Likewise
1021         (var_decode_location): Add DW_OP_addrx
1022         (dwarf2_const_value_attr): Add DW_FORM_addrx
1023         (dump_die_shallow): Likewise
1024         (dwarf2_fetch_constant_bytes): Likewise
1025         (decode_locdesc): Add DW_OP_addrx
1026         (skip_form_bytes): Add DW_FORM_addrx
1027
1028 2019-04-22  Ali Tamur  <tamur@google.com>
1029
1030         * MAINTAINERS (Write After Approval): Add self.
1031
1032 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1033
1034         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1035         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1036         (open_symbol_file_object): Likewise.
1037         (svr4_default_sos): Add info parameter.
1038         (svr4_read_so_list): Likewise.
1039         (svr4_current_sos_direct): Adjust functions calls to pass down
1040         info.
1041         (svr4_current_sos_1): Add info parameter.
1042         (svr4_current_sos): Call get_svr4_info, pass info down to
1043         svr4_current_sos_1.
1044         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1045         get_svr4_info.
1046         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1047         get_svr4_info.
1048         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1049         to get_svr4_info.
1050         (probes_table_remove_objfile_probes): Likewise.
1051         (register_solib_event_probe): Add info parameter.
1052         (solist_update_incremental): Pass info parameter down to
1053         svr4_read_so_list.
1054         (disable_probes_interface): Add info parameter.
1055         (svr4_handle_solib_event): Pass current_program_space to
1056         get_svr4_info.  Adjust disable_probes_interface cleanup.
1057         (svr4_create_probe_breakpoints): Add info parameter, pass it
1058         down to register_solib_event_probe.
1059         (svr4_create_solib_event_breakpoints): Add info parameter,
1060         pass it down to svr4_create_probe_breakpoints.
1061         (enable_break): Pass info down to
1062         svr4_create_solib_event_breakpoints.
1063         (svr4_solib_create_inferior_hook): Pass current_program_space to
1064         get_svr4_info.
1065         (svr4_clear_solib): Likewise.
1066
1067 2019-04-22  Pedro Alves  <palves@redhat.com>
1068
1069         * solib-svr4.c (svr4_free_objfile_observer): New.
1070         (probe_and_action::objfile): New field.
1071         (probes_table_htab_remove_objfile_probes)
1072         (probes_table_remove_objfile_probes): New functions.
1073         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1074         in the new probe_and_action.  Don't store the probe in 'lookup'.
1075         (svr4_create_probe_breakpoints): Pass objfile to
1076         register_solib_event_probe.
1077         (_initialize_svr4_solib): Register a free_objfile observer.
1078
1079 2019-04-19  Tom Tromey  <tom@tromey.com>
1080
1081         * common/queue.h: Remove.
1082
1083 2019-04-19  Tom Tromey  <tom@tromey.com>
1084
1085         * event-loop.c: Don't include "common/queue.h".
1086
1087 2019-04-19  Tom Tromey  <tom@tromey.com>
1088
1089         * remote.c (remote_target): Use delete.
1090         * remote-notif.h: Include <list>, not "common/queue.h".
1091         (notif_client_p): Remove typedef.
1092         (remote_notif_state): Add constructor, destructor, initializer.
1093         <notif_queue>: Now a std::list.
1094         (remote_notif_state_xfree): Don't declare.
1095         * remote-notif.c (remote_notif_process, handle_notification)
1096         (remote_notif_state_allocate): Update.
1097         (~remote_notif_state): Rename from remote_notif_state_xfree.
1098
1099 2019-04-19  Tom Tromey  <tom@tromey.com>
1100
1101         * symfile.c (reread_symbols): Update.
1102         * objfiles.c (objfile_register_static_link)
1103         (objfile_lookup_static_link): Update
1104         (~objfile) Don't delete static_links.
1105         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1106
1107 2019-04-19  Tom Tromey  <tom@tromey.com>
1108
1109         * type-stack.h (struct type_stack) <insert>: Constify string.
1110         * type-stack.c (type_stack::insert): Constify string.
1111         * gdbtypes.h (lookup_template_type): Update.
1112         (address_space_name_to_int): Update.
1113         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1114         const.
1115         (lookup_template_type): Make name const.
1116         * c-exp.y: Update rules.
1117         (lex_one_token, classify_name, classify_inner_name)
1118         (c_print_token): Update.
1119         * p-exp.y: Update rules.
1120         (yylex): Update.
1121         * f-exp.y: Update rules.
1122         (yylex): Update.
1123         * d-exp.y: Update rules.
1124         (lex_one_token, classify_name, classify_inner_name): Update.
1125         * parse.c (write_dollar_variable, copy_name): Return std::string.
1126         * parser-defs.h (copy_name): Change return type.
1127         * m2-exp.y: Update rules.
1128         (yylex): Update.
1129         * go-exp.y (lex_one_token): Update.
1130         Update rules.
1131         (classify_unsafe_function, classify_packaged_name)
1132         (classify_name, yylex): Update.
1133
1134 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1135
1136         * configure.ac: add --enable-source-highlight switch.
1137         * configure: Regenerate.
1138         * top.c (print_gdb_version): plumb --enable-source-highlight
1139         status to "show configuration".
1140
1141 2019-04-19  Tom Tromey  <tromey@adacore.com>
1142
1143         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1144         Check ADA_TYPE_P.
1145         (empty_record, ada_template_to_fixed_record_type_1)
1146         (template_to_static_fixed_type)
1147         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1148         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1149         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1150         macros.
1151
1152 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1153
1154         PR symtab/24423:
1155         * source.c (print_source_lines_base): Advance "iter" when a
1156         control character is seen.
1157
1158 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1159
1160         * inferior.h (struct infcall_suspend_state_deleter):
1161         Catch exception in destructor to avoid crash.
1162
1163 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1164
1165         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1166         close to the add_com "shell".
1167
1168 2019-04-18  Tom Tromey  <tromey@adacore.com>
1169
1170         * process-stratum-target.h (class process_stratum_target)
1171         <stratum>: Add "final".
1172
1173 2019-04-17  Tom Tromey  <tromey@adacore.com>
1174
1175         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1176         against nullptr before use.
1177
1178 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1179
1180         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1181
1182 2019-04-17  Jim Wilson  <jimw@sifive.com>
1183             Andrew Burgess  <andrew.burgess@embecosm.com>
1184
1185         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1186         code read might fail, assume 4-byte breakpoint in that case.
1187
1188 2019-04-15  Leszek Swirski  <leszeks@google.com>
1189
1190         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1191         rather than a hand-rolled POD check when checking for forced MEMORY
1192         classification.
1193
1194 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1195
1196         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1197         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1198         function.
1199         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1200         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1201         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1202         declaration.
1203
1204 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1205
1206         * aarch64-linux-nat.c
1207         (aarch64_linux_nat_target::thread_architecture): Add override.
1208         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1209         each VQ.
1210
1211 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1212
1213         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1214
1215 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1218         target types of size 96-bits, add some additional comments, and
1219         check that the builtin type we found was the correct size.
1220
1221 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1222
1223         * utils.c (prompt_for_continue): Don't restore the styling at the
1224         end, as applied_style has the wrong value.  This fixes styling in
1225         long lists of file names that are interrupted by the "Continue?"
1226         prompt.
1227
1228 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1229
1230         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1231         * c-lang.c (c_language_defn): Likewise.
1232         (cplus_language_defn): Likewise.
1233         (asm_language_defn): Likewise.
1234         (minimal_language_defn): Likewise.
1235         * d-lang.c (d_language_defn): Likewise.
1236         * f-lang.c (f_language_defn): Likewise.
1237         * go-lang.c (go_language_defn): Likewise.
1238         * language.c (unknown_language_defn): Likewise.
1239         (auto_language_defn): Likewise.
1240         * language.h (struct language_defn): Remove la_magic field.
1241         (LANG_MAGIC): Delete.
1242         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1243         * objc-lang.c (objc_language_defn): Likewise.
1244         * opencl-lang.c (opencl_language_defn): Likewise.
1245         * p-lang.c (pascal_language_defn): Likewise.
1246         * rust-lang.c (rust_language_defn): Likewise.
1247
1248 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * riscv-tdep.c (riscv_type_align): New function.
1251         (riscv_type_alignment): Delete.
1252         (riscv_arg_location): Use 'type_align'.
1253         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1254
1255 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * gdbtypes.c (type_align): A struct with no non-static fields also
1258         has alignment of 1.
1259
1260 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1263         component to 0.
1264         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1265         member.
1266         (riscv_struct_info::analyse): New implementation using new
1267         analyse_inner member function.
1268         (riscv_struct_info::field_offset): New member function.
1269         (riscv_struct_info::m_offsets): New member variable.
1270         (riscv_struct_info::analyse_inner): New private member function,
1271         takes the old implementation of riscv_struct_info::analyse but
1272         extended to track field offsets.
1273         (riscv_call_arg_struct): Update the struct folding special cases
1274         to handle cases where empty C++ structs, which are non-zero
1275         length, are found.
1276         (riscv_arg_location): Initialise the length of each location, a
1277         non-zero length now indicates the location is in use.
1278         (riscv_push_dummy_call): Allow for the first location having a
1279         non-zero offset when setting up arguments.
1280         (riscv_return_value): Likewise, but for return values.
1281
1282 2019-04-11  Tom Tromey  <tromey@adacore.com>
1283
1284         * utils.c (internal_vproblem): Make "msg" const.
1285
1286 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1287
1288         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1289         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1290         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1291         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1292
1293 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1294
1295         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1296         function.
1297         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1298         of amd64_collect_native_gregset.
1299         (amd64_linux_nat_target::store_registers): Likewise.
1300
1301 2019-04-10  Tom Tromey  <tom@tromey.com>
1302
1303         * symtab.c (lookup_global_symbol_from_objfile)
1304         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1305         * objfiles.h (class separate_debug_iterator): New.
1306         (class separate_debug_range): New.
1307         (struct objfile) <separate_debug_objfiles>: New method.
1308         (objfile_separate_debug_iterate): Don't declare.
1309         * objfiles.c (separate_debug_iterator::operator++): Rename from
1310         objfile_separate_debug_iterate.
1311         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1312         iterator.
1313         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1314         iterator.
1315
1316 2019-04-10  Tom Tromey  <tom@tromey.com>
1317
1318         * symfile.c (reread_symbols): Remove old comment.
1319         * objfiles.c (free_all_objfiles): Fix a typo.
1320
1321 2019-04-10  Tom Tromey  <tom@tromey.com>
1322
1323         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1324         * minsyms.c (lookup_minimal_symbol): Use foreach.
1325         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1326         (lookup_minimal_symbol_solib_trampoline): Likewise.
1327         * symfile.c (reread_symbols): Use foreach.
1328
1329 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1330             Tom Tromey  <tromey@adacore.com>
1331
1332         PR rust/24414:
1333         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1334         (rust_lex_int_test): Change "value" to be LONGEST.
1335         (rust_lex_tests): Add test for long integer literal.
1336
1337 2019-04-09  Tom Tromey  <tromey@adacore.com>
1338
1339         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1340         to bool.
1341         (extended_remote_target::attach): Update.
1342         (remote_target::remote_notice_new_inferior): Update.
1343         (remote_target::add_current_inferior_and_thread): Update.
1344         * inferior.c (exit_inferior_1): Use "false".
1345         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1346
1347 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1348
1349         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1350         the "start" command.
1351
1352 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1353
1354         * python/py-inferior.c (infpy_thread_from_thread_handle):
1355         Adjust comments to reflect renaming of thread_from_thread_handle
1356         to thread_from_handle.  Adjust keywords.  Fix type error message.
1357         (inferior_object_methods): Add thread_from_handle.  Retain
1358         thread_from_thread_handle, but mark it as deprecated.
1359
1360 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1361
1362         * gdbthread.h (find_thread_by_handle): Revise declaration.
1363         * thread.c (find_thread_by_handle): Likewise.  Adjust
1364         implementation too.
1365         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1366         support for buffer objects as handles.
1367
1368 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1369
1370         * python/py-infthread.c (thpy_thread_handle): New function.
1371         (thread_object_methods): Register thpy_thread_handle.
1372
1373 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1374
1375         * gdbthread.h (thread_to_thread_handle): Declare.
1376         * thread.c (gdbtypes.h): Include.
1377         (thread_to_thread_handle): New function.
1378
1379         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1380         (target_thread_info_to_thread_handle): Declare.
1381         * target.c (target_thread_info_to_thread_handle): New function.
1382         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1383         * target-delegates.c: Regenerate.
1384
1385         * linux-thread-db.c (class thread_db_target): Add method
1386         thread_info_to_thread_handle.
1387         (thread_db_target::thread_info_to_thread_handle): Define.
1388         * remote.c (class remote_target): Add new method
1389         thread_info_to_thread_handle.
1390         (remote_target::thread_info_to_thread_handle): Define.
1391
1392 2019-04-08  Pedro Alves  <palves@redhat.com>
1393
1394         * common/common-exceptions.c (throw_exception): Don't create
1395         named object to throw; throw directly.
1396         (throw_it): Likewise.  Don't initialize gdb_exception::message
1397         here, with new; pass FMT and AP to the ctor instead.
1398         * common/common-exceptions.h: Include <string>.
1399         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1400         const char *, va_list)): New ctor.  Use std::make_shared.
1401         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1402         errors)): Delete.
1403         (gdb_exception_error::gdb_exception_error(enum errors, const char
1404         *, va_list)): New.
1405         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1406         Add assertion.
1407         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1408         errors)): Delete.
1409         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1410         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1411         Add assertion.
1412
1413 2019-04-08  Tom Tromey  <tom@tromey.com>
1414
1415         * valops.c (value_rtti_indirect_type): Replace throw_exception
1416         with throw.
1417         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1418         with throw.
1419         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1420         throw.
1421         * target.c (target_translate_tls_address): Replace throw_exception
1422         with throw.
1423         * stack.c (frame_apply_command_count): Replace throw_exception
1424         with throw.
1425         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1426         throw.
1427         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1428         with throw.
1429         * rs6000-tdep.c (rs6000_frame_cache)
1430         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1431         * remote.c: Replace throw_exception with throw.
1432         * record-full.c (record_full_message, record_full_wait_1)
1433         (record_full_restore): Replace throw_exception with throw.
1434         * record-btrace.c:
1435         (get_thread_current_frame_id, record_btrace_start_replaying)
1436         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1437         (cmd_record_btrace_start): Replace throw_exception with throw.
1438         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1439         throw.
1440         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1441         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1442         * linespec.c:
1443         (find_linespec_symbols): Replace throw_exception with throw.
1444         * infrun.c (displaced_step_prepare, resume): Replace
1445         throw_exception with throw.
1446         * infcmd.c (post_create_inferior): Replace throw_exception with
1447         throw.
1448         * inf-loop.c (inferior_event_handler): Replace throw_exception
1449         with throw.
1450         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1451         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1452         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1453         (get_prev_frame_always, get_frame_pc_if_available)
1454         (get_frame_address_in_block_if_available, get_frame_language):
1455         Replace throw_exception with throw.
1456         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1457         throw_exception with throw.
1458         * eval.c (fetch_subexp_value, evaluate_var_value)
1459         (evaluate_funcall, evaluate_subexp_standard): Replace
1460         throw_exception with throw.
1461         * dwarf2loc.c (call_site_find_chain)
1462         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1463         Replace throw_exception with throw.
1464         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1465         with throw.
1466         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1467         throw.
1468         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1469         * completer.c (complete_line_internal): Replace throw_exception
1470         with throw.
1471         * compile/compile-object-run.c (compile_object_run): Replace
1472         throw_exception with throw.
1473         * cli/cli-script.c (process_next_line): Replace throw_exception
1474         with throw.
1475         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1476         (btrace_enable, btrace_maint_update_pt_packets): Replace
1477         throw_exception with throw.
1478         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1479         throw_exception with throw.
1480         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1481         throw_exception with throw.
1482         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1483         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1484         * aarch64-tdep.c (aarch64_make_prologue_cache)
1485         (aarch64_make_stub_cache): Replace throw_exception with throw.
1486
1487 2019-04-08  Tom Tromey  <tom@tromey.com>
1488
1489         * common/common-exceptions.c (throw_exception): Rename from
1490         throw_exception_cxx.  Remove old copy.  Make argument const.
1491         (throw_it): Create and throw exception objects directly.
1492         * common/common-exceptions.h (throw_exception): Make argument
1493         const.
1494         (struct gdb_exception_error): Add constructor.
1495         (struct gdb_exception_quit): Add constructor.
1496
1497 2019-04-08  Tom Tromey  <tom@tromey.com>
1498
1499         * common/common-exceptions.h (exception_rethrow): Don't declare.
1500         (TRY_SJLJ): Update comment.
1501         (TRY, CATCH, END_CATCH): Remove.
1502         * common/common-exceptions.c (exception_rethrow): Remove.
1503
1504 2019-04-08  Tom Tromey  <tom@tromey.com>
1505
1506         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1507         Remove.
1508         (gdb_exception_error): Rename from
1509         gdb_exception_RETURN_MASK_ERROR.
1510         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1511         (gdb_quit_bad_alloc): Update.
1512         * aarch64-tdep.c: Update.
1513         * ada-lang.c: Update.
1514         * ada-typeprint.c: Update.
1515         * ada-valprint.c: Update.
1516         * amd64-tdep.c: Update.
1517         * arch-utils.c: Update.
1518         * break-catch-throw.c: Update.
1519         * breakpoint.c: Update.
1520         * btrace.c: Update.
1521         * c-varobj.c: Update.
1522         * cli/cli-cmds.c: Update.
1523         * cli/cli-interp.c: Update.
1524         * cli/cli-script.c: Update.
1525         * common/common-exceptions.c: Update.
1526         * common/new-op.c: Update.
1527         * common/selftest.c: Update.
1528         * compile/compile-c-symbols.c: Update.
1529         * compile/compile-cplus-symbols.c: Update.
1530         * compile/compile-object-load.c: Update.
1531         * compile/compile-object-run.c: Update.
1532         * completer.c: Update.
1533         * corelow.c: Update.
1534         * cp-abi.c: Update.
1535         * cp-support.c: Update.
1536         * cp-valprint.c: Update.
1537         * darwin-nat.c: Update.
1538         * disasm-selftests.c: Update.
1539         * dtrace-probe.c: Update.
1540         * dwarf-index-cache.c: Update.
1541         * dwarf-index-write.c: Update.
1542         * dwarf2-frame-tailcall.c: Update.
1543         * dwarf2-frame.c: Update.
1544         * dwarf2loc.c: Update.
1545         * dwarf2read.c: Update.
1546         * eval.c: Update.
1547         * event-loop.c: Update.
1548         * event-top.c: Update.
1549         * exec.c: Update.
1550         * f-valprint.c: Update.
1551         * fbsd-tdep.c: Update.
1552         * frame-unwind.c: Update.
1553         * frame.c: Update.
1554         * gdbtypes.c: Update.
1555         * gnu-v3-abi.c: Update.
1556         * guile/guile-internal.h: Update.
1557         * guile/scm-block.c: Update.
1558         * guile/scm-breakpoint.c: Update.
1559         * guile/scm-cmd.c: Update.
1560         * guile/scm-disasm.c: Update.
1561         * guile/scm-frame.c: Update.
1562         * guile/scm-lazy-string.c: Update.
1563         * guile/scm-math.c: Update.
1564         * guile/scm-param.c: Update.
1565         * guile/scm-ports.c: Update.
1566         * guile/scm-pretty-print.c: Update.
1567         * guile/scm-symbol.c: Update.
1568         * guile/scm-symtab.c: Update.
1569         * guile/scm-type.c: Update.
1570         * guile/scm-value.c: Update.
1571         * i386-linux-tdep.c: Update.
1572         * i386-tdep.c: Update.
1573         * inf-loop.c: Update.
1574         * infcall.c: Update.
1575         * infcmd.c: Update.
1576         * infrun.c: Update.
1577         * jit.c: Update.
1578         * language.c: Update.
1579         * linespec.c: Update.
1580         * linux-fork.c: Update.
1581         * linux-nat.c: Update.
1582         * linux-tdep.c: Update.
1583         * linux-thread-db.c: Update.
1584         * main.c: Update.
1585         * mi/mi-cmd-break.c: Update.
1586         * mi/mi-cmd-stack.c: Update.
1587         * mi/mi-interp.c: Update.
1588         * mi/mi-main.c: Update.
1589         * objc-lang.c: Update.
1590         * p-valprint.c: Update.
1591         * parse.c: Update.
1592         * ppc-linux-tdep.c: Update.
1593         * printcmd.c: Update.
1594         * python/py-arch.c: Update.
1595         * python/py-breakpoint.c: Update.
1596         * python/py-cmd.c: Update.
1597         * python/py-finishbreakpoint.c: Update.
1598         * python/py-frame.c: Update.
1599         * python/py-framefilter.c: Update.
1600         * python/py-gdb-readline.c: Update.
1601         * python/py-inferior.c: Update.
1602         * python/py-infthread.c: Update.
1603         * python/py-lazy-string.c: Update.
1604         * python/py-linetable.c: Update.
1605         * python/py-objfile.c: Update.
1606         * python/py-param.c: Update.
1607         * python/py-prettyprint.c: Update.
1608         * python/py-progspace.c: Update.
1609         * python/py-record-btrace.c: Update.
1610         * python/py-record.c: Update.
1611         * python/py-symbol.c: Update.
1612         * python/py-type.c: Update.
1613         * python/py-unwind.c: Update.
1614         * python/py-utils.c: Update.
1615         * python/py-value.c: Update.
1616         * python/python.c: Update.
1617         * record-btrace.c: Update.
1618         * record-full.c: Update.
1619         * remote-fileio.c: Update.
1620         * remote.c: Update.
1621         * riscv-tdep.c: Update.
1622         * rs6000-aix-tdep.c: Update.
1623         * rs6000-tdep.c: Update.
1624         * rust-exp.y: Update.
1625         * rust-lang.c: Update.
1626         * s390-tdep.c: Update.
1627         * selftest-arch.c: Update.
1628         * solib-dsbt.c: Update.
1629         * solib-frv.c: Update.
1630         * solib-spu.c: Update.
1631         * solib-svr4.c: Update.
1632         * solib.c: Update.
1633         * sparc64-linux-tdep.c: Update.
1634         * stack.c: Update.
1635         * symfile-mem.c: Update.
1636         * symmisc.c: Update.
1637         * target.c: Update.
1638         * thread.c: Update.
1639         * top.c: Update.
1640         * tracefile-tfile.c: Update.
1641         * tui/tui.c: Update.
1642         * typeprint.c: Update.
1643         * unittests/cli-utils-selftests.c: Update.
1644         * unittests/parse-connection-spec-selftests.c: Update.
1645         * valops.c: Update.
1646         * valprint.c: Update.
1647         * value.c: Update.
1648         * varobj.c: Update.
1649         * windows-nat.c: Update.
1650         * x86-linux-nat.c: Update.
1651         * xml-support.c: Update.
1652
1653 2019-04-08  Tom Tromey  <tom@tromey.com>
1654
1655         * xml-support.c: Use C++ exception handling.
1656         * x86-linux-nat.c: Use C++ exception handling.
1657         * windows-nat.c: Use C++ exception handling.
1658         * varobj.c: Use C++ exception handling.
1659         * value.c: Use C++ exception handling.
1660         * valprint.c: Use C++ exception handling.
1661         * valops.c: Use C++ exception handling.
1662         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1663         handling.
1664         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1665         * typeprint.c: Use C++ exception handling.
1666         * tui/tui.c: Use C++ exception handling.
1667         * tracefile-tfile.c: Use C++ exception handling.
1668         * top.c: Use C++ exception handling.
1669         * thread.c: Use C++ exception handling.
1670         * target.c: Use C++ exception handling.
1671         * symmisc.c: Use C++ exception handling.
1672         * symfile-mem.c: Use C++ exception handling.
1673         * stack.c: Use C++ exception handling.
1674         * sparc64-linux-tdep.c: Use C++ exception handling.
1675         * solib.c: Use C++ exception handling.
1676         * solib-svr4.c: Use C++ exception handling.
1677         * solib-spu.c: Use C++ exception handling.
1678         * solib-frv.c: Use C++ exception handling.
1679         * solib-dsbt.c: Use C++ exception handling.
1680         * selftest-arch.c: Use C++ exception handling.
1681         * s390-tdep.c: Use C++ exception handling.
1682         * rust-lang.c: Use C++ exception handling.
1683         * rust-exp.y: Use C++ exception handling.
1684         * rs6000-tdep.c: Use C++ exception handling.
1685         * rs6000-aix-tdep.c: Use C++ exception handling.
1686         * riscv-tdep.c: Use C++ exception handling.
1687         * remote.c: Use C++ exception handling.
1688         * remote-fileio.c: Use C++ exception handling.
1689         * record-full.c: Use C++ exception handling.
1690         * record-btrace.c: Use C++ exception handling.
1691         * python/python.c: Use C++ exception handling.
1692         * python/py-value.c: Use C++ exception handling.
1693         * python/py-utils.c: Use C++ exception handling.
1694         * python/py-unwind.c: Use C++ exception handling.
1695         * python/py-type.c: Use C++ exception handling.
1696         * python/py-symbol.c: Use C++ exception handling.
1697         * python/py-record.c: Use C++ exception handling.
1698         * python/py-record-btrace.c: Use C++ exception handling.
1699         * python/py-progspace.c: Use C++ exception handling.
1700         * python/py-prettyprint.c: Use C++ exception handling.
1701         * python/py-param.c: Use C++ exception handling.
1702         * python/py-objfile.c: Use C++ exception handling.
1703         * python/py-linetable.c: Use C++ exception handling.
1704         * python/py-lazy-string.c: Use C++ exception handling.
1705         * python/py-infthread.c: Use C++ exception handling.
1706         * python/py-inferior.c: Use C++ exception handling.
1707         * python/py-gdb-readline.c: Use C++ exception handling.
1708         * python/py-framefilter.c: Use C++ exception handling.
1709         * python/py-frame.c: Use C++ exception handling.
1710         * python/py-finishbreakpoint.c: Use C++ exception handling.
1711         * python/py-cmd.c: Use C++ exception handling.
1712         * python/py-breakpoint.c: Use C++ exception handling.
1713         * python/py-arch.c: Use C++ exception handling.
1714         * printcmd.c: Use C++ exception handling.
1715         * ppc-linux-tdep.c: Use C++ exception handling.
1716         * parse.c: Use C++ exception handling.
1717         * p-valprint.c: Use C++ exception handling.
1718         * objc-lang.c: Use C++ exception handling.
1719         * mi/mi-main.c: Use C++ exception handling.
1720         * mi/mi-interp.c: Use C++ exception handling.
1721         * mi/mi-cmd-stack.c: Use C++ exception handling.
1722         * mi/mi-cmd-break.c: Use C++ exception handling.
1723         * main.c: Use C++ exception handling.
1724         * linux-thread-db.c: Use C++ exception handling.
1725         * linux-tdep.c: Use C++ exception handling.
1726         * linux-nat.c: Use C++ exception handling.
1727         * linux-fork.c: Use C++ exception handling.
1728         * linespec.c: Use C++ exception handling.
1729         * language.c: Use C++ exception handling.
1730         * jit.c: Use C++ exception handling.
1731         * infrun.c: Use C++ exception handling.
1732         * infcmd.c: Use C++ exception handling.
1733         * infcall.c: Use C++ exception handling.
1734         * inf-loop.c: Use C++ exception handling.
1735         * i386-tdep.c: Use C++ exception handling.
1736         * i386-linux-tdep.c: Use C++ exception handling.
1737         * guile/scm-value.c: Use C++ exception handling.
1738         * guile/scm-type.c: Use C++ exception handling.
1739         * guile/scm-symtab.c: Use C++ exception handling.
1740         * guile/scm-symbol.c: Use C++ exception handling.
1741         * guile/scm-pretty-print.c: Use C++ exception handling.
1742         * guile/scm-ports.c: Use C++ exception handling.
1743         * guile/scm-param.c: Use C++ exception handling.
1744         * guile/scm-math.c: Use C++ exception handling.
1745         * guile/scm-lazy-string.c: Use C++ exception handling.
1746         * guile/scm-frame.c: Use C++ exception handling.
1747         * guile/scm-disasm.c: Use C++ exception handling.
1748         * guile/scm-cmd.c: Use C++ exception handling.
1749         * guile/scm-breakpoint.c: Use C++ exception handling.
1750         * guile/scm-block.c: Use C++ exception handling.
1751         * guile/guile-internal.h: Use C++ exception handling.
1752         * gnu-v3-abi.c: Use C++ exception handling.
1753         * gdbtypes.c: Use C++ exception handling.
1754         * frame.c: Use C++ exception handling.
1755         * frame-unwind.c: Use C++ exception handling.
1756         * fbsd-tdep.c: Use C++ exception handling.
1757         * f-valprint.c: Use C++ exception handling.
1758         * exec.c: Use C++ exception handling.
1759         * event-top.c: Use C++ exception handling.
1760         * event-loop.c: Use C++ exception handling.
1761         * eval.c: Use C++ exception handling.
1762         * dwarf2read.c: Use C++ exception handling.
1763         * dwarf2loc.c: Use C++ exception handling.
1764         * dwarf2-frame.c: Use C++ exception handling.
1765         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1766         * dwarf-index-write.c: Use C++ exception handling.
1767         * dwarf-index-cache.c: Use C++ exception handling.
1768         * dtrace-probe.c: Use C++ exception handling.
1769         * disasm-selftests.c: Use C++ exception handling.
1770         * darwin-nat.c: Use C++ exception handling.
1771         * cp-valprint.c: Use C++ exception handling.
1772         * cp-support.c: Use C++ exception handling.
1773         * cp-abi.c: Use C++ exception handling.
1774         * corelow.c: Use C++ exception handling.
1775         * completer.c: Use C++ exception handling.
1776         * compile/compile-object-run.c: Use C++ exception handling.
1777         * compile/compile-object-load.c: Use C++ exception handling.
1778         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1779         * compile/compile-c-symbols.c: Use C++ exception handling.
1780         * common/selftest.c: Use C++ exception handling.
1781         * common/new-op.c: Use C++ exception handling.
1782         * cli/cli-script.c: Use C++ exception handling.
1783         * cli/cli-interp.c: Use C++ exception handling.
1784         * cli/cli-cmds.c: Use C++ exception handling.
1785         * c-varobj.c: Use C++ exception handling.
1786         * btrace.c: Use C++ exception handling.
1787         * breakpoint.c: Use C++ exception handling.
1788         * break-catch-throw.c: Use C++ exception handling.
1789         * arch-utils.c: Use C++ exception handling.
1790         * amd64-tdep.c: Use C++ exception handling.
1791         * ada-valprint.c: Use C++ exception handling.
1792         * ada-typeprint.c: Use C++ exception handling.
1793         * ada-lang.c: Use C++ exception handling.
1794         * aarch64-tdep.c: Use C++ exception handling.
1795
1796 2019-04-08  Tom Tromey  <tom@tromey.com>
1797
1798         * xml-support.c (gdb_xml_parser::parse): Update.
1799         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1800         * value.c (show_convenience): Update.
1801         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1802         (test_parse_flags_qcs): Update.
1803         * thread.c (thr_try_catch_cmd): Update.
1804         * target.c (target_translate_tls_address): Update.
1805         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1806         (info_frame_command_core, frame_apply_command_count): Update.
1807         * rust-exp.y (rust_lex_exception_test): Update.
1808         * riscv-tdep.c (riscv_print_one_register_info): Update.
1809         * remote.c (remote_target::enable_btrace): Update.
1810         * record-btrace.c (record_btrace_enable_warn): Update.
1811         * python/py-utils.c (gdbpy_convert_exception): Update.
1812         * printcmd.c (do_one_display, print_variable_and_value): Update.
1813         * mi/mi-main.c (mi_print_exception): Update.
1814         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1815         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1816         * linux-nat.c (linux_nat_target::attach): Update.
1817         * linux-fork.c (class scoped_switch_fork_info): Update.
1818         * infrun.c (displaced_step_prepare): Update.
1819         * infcall.c (call_function_by_hand_dummy): Update.
1820         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1821         * gnu-v3-abi.c (print_one_vtable): Update.
1822         * frame.c (get_prev_frame_always): Update.
1823         * f-valprint.c (info_common_command_for_block): Update.
1824         * exec.c (try_open_exec_file): Update.
1825         * exceptions.c (print_exception, exception_print)
1826         (exception_fprintf, exception_print_same): Update.
1827         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1828         * dwarf-index-cache.c (index_cache::store)
1829         (index_cache::lookup_gdb_index): Update.
1830         * darwin-nat.c (maybe_cache_shell): Update.
1831         * cp-valprint.c (cp_print_value_fields): Update.
1832         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1833         (gcc_cplus_symbol_address): Update.
1834         * compile/compile-c-symbols.c (gcc_convert_symbol)
1835         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1836         * common/selftest.c: Update.
1837         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1838         a std::string.
1839         (exception_try_scope_entry, exception_try_scope_exit): Don't
1840         declare.
1841         (struct exception_try_scope): Remove.
1842         (TRY): Don't use exception_try_scope.
1843         (struct gdb_exception): Add constructor, operator=.
1844         <what>: New method.
1845         (struct gdb_exception_RETURN_MASK_ALL)
1846         (struct gdb_exception_RETURN_MASK_ERROR)
1847         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1848         (struct gdb_quit_bad_alloc): Update.
1849         * common/common-exceptions.c (exception_none): Change
1850         initializer.
1851         (struct catcher) <state, exception>: Initialize inline.
1852         <prev>: Remove member.
1853         (current_catcher): Remove.
1854         (catchers): New global.
1855         (exceptions_state_mc_init): Simplify.
1856         (catcher_pop): Remove.
1857         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1858         (try_scope_depth, exception_try_scope_entry)
1859         (exception_try_scope_exit): Remove.
1860         (throw_exception_sjlj): Update.
1861         (exception_messages, exception_messages_size): Remove.
1862         (throw_it): Simplify.
1863         (gdb_exception_sliced_copy): Remove.
1864         (throw_exception_cxx): Update.
1865         * cli/cli-script.c (script_from_file): Update.
1866         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1867         Update.
1868         * ada-valprint.c (ada_val_print): Update.
1869         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1870         (create_excep_cond_exprs): Update.
1871
1872 2019-04-08  Tom Tromey  <tom@tromey.com>
1873
1874         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1875         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1876         (TRY, CATCH, END_CATCH): Remove some definitions.
1877         * common/common-exceptions.c: Don't use GDB_XCPT.
1878         (catcher_list_size): Remove.
1879         (throw_exception, throw_it): Simplify.
1880
1881 2019-04-05  Tom Tromey  <tom@tromey.com>
1882
1883         Revert the header-sorting patch.
1884         * ft32-tdep.c: Revert.
1885         * frv-tdep.c: Revert.
1886         * frv-linux-tdep.c: Revert.
1887         * frame.c: Revert.
1888         * frame-unwind.c: Revert.
1889         * frame-base.c: Revert.
1890         * fork-child.c: Revert.
1891         * findvar.c: Revert.
1892         * findcmd.c: Revert.
1893         * filesystem.c: Revert.
1894         * filename-seen-cache.h: Revert.
1895         * filename-seen-cache.c: Revert.
1896         * fbsd-tdep.c: Revert.
1897         * fbsd-nat.h: Revert.
1898         * fbsd-nat.c: Revert.
1899         * f-valprint.c: Revert.
1900         * f-typeprint.c: Revert.
1901         * f-lang.c: Revert.
1902         * extension.h: Revert.
1903         * extension.c: Revert.
1904         * extension-priv.h: Revert.
1905         * expprint.c: Revert.
1906         * exec.h: Revert.
1907         * exec.c: Revert.
1908         * exceptions.c: Revert.
1909         * event-top.c: Revert.
1910         * event-loop.c: Revert.
1911         * eval.c: Revert.
1912         * elfread.c: Revert.
1913         * dwarf2read.h: Revert.
1914         * dwarf2read.c: Revert.
1915         * dwarf2loc.c: Revert.
1916         * dwarf2expr.h: Revert.
1917         * dwarf2expr.c: Revert.
1918         * dwarf2-frame.c: Revert.
1919         * dwarf2-frame-tailcall.c: Revert.
1920         * dwarf-index-write.h: Revert.
1921         * dwarf-index-write.c: Revert.
1922         * dwarf-index-common.c: Revert.
1923         * dwarf-index-cache.h: Revert.
1924         * dwarf-index-cache.c: Revert.
1925         * dummy-frame.c: Revert.
1926         * dtrace-probe.c: Revert.
1927         * disasm.h: Revert.
1928         * disasm.c: Revert.
1929         * disasm-selftests.c: Revert.
1930         * dictionary.c: Revert.
1931         * dicos-tdep.c: Revert.
1932         * demangle.c: Revert.
1933         * dcache.h: Revert.
1934         * dcache.c: Revert.
1935         * darwin-nat.h: Revert.
1936         * darwin-nat.c: Revert.
1937         * darwin-nat-info.c: Revert.
1938         * d-valprint.c: Revert.
1939         * d-namespace.c: Revert.
1940         * d-lang.c: Revert.
1941         * ctf.c: Revert.
1942         * csky-tdep.c: Revert.
1943         * csky-linux-tdep.c: Revert.
1944         * cris-tdep.c: Revert.
1945         * cris-linux-tdep.c: Revert.
1946         * cp-valprint.c: Revert.
1947         * cp-support.c: Revert.
1948         * cp-namespace.c: Revert.
1949         * cp-abi.c: Revert.
1950         * corelow.c: Revert.
1951         * corefile.c: Revert.
1952         * continuations.c: Revert.
1953         * completer.h: Revert.
1954         * completer.c: Revert.
1955         * complaints.c: Revert.
1956         * coffread.c: Revert.
1957         * coff-pe-read.c: Revert.
1958         * cli-out.h: Revert.
1959         * cli-out.c: Revert.
1960         * charset.c: Revert.
1961         * c-varobj.c: Revert.
1962         * c-valprint.c: Revert.
1963         * c-typeprint.c: Revert.
1964         * c-lang.c: Revert.
1965         * buildsym.c: Revert.
1966         * buildsym-legacy.c: Revert.
1967         * build-id.h: Revert.
1968         * build-id.c: Revert.
1969         * btrace.c: Revert.
1970         * bsd-uthread.c: Revert.
1971         * breakpoint.h: Revert.
1972         * breakpoint.c: Revert.
1973         * break-catch-throw.c: Revert.
1974         * break-catch-syscall.c: Revert.
1975         * break-catch-sig.c: Revert.
1976         * blockframe.c: Revert.
1977         * block.c: Revert.
1978         * bfin-tdep.c: Revert.
1979         * bfin-linux-tdep.c: Revert.
1980         * bfd-target.c: Revert.
1981         * bcache.c: Revert.
1982         * ax-general.c: Revert.
1983         * ax-gdb.h: Revert.
1984         * ax-gdb.c: Revert.
1985         * avr-tdep.c: Revert.
1986         * auxv.c: Revert.
1987         * auto-load.c: Revert.
1988         * arm-wince-tdep.c: Revert.
1989         * arm-tdep.c: Revert.
1990         * arm-symbian-tdep.c: Revert.
1991         * arm-pikeos-tdep.c: Revert.
1992         * arm-obsd-tdep.c: Revert.
1993         * arm-nbsd-tdep.c: Revert.
1994         * arm-nbsd-nat.c: Revert.
1995         * arm-linux-tdep.c: Revert.
1996         * arm-linux-nat.c: Revert.
1997         * arm-fbsd-tdep.c: Revert.
1998         * arm-fbsd-nat.c: Revert.
1999         * arm-bsd-tdep.c: Revert.
2000         * arch-utils.c: Revert.
2001         * arc-tdep.c: Revert.
2002         * arc-newlib-tdep.c: Revert.
2003         * annotate.h: Revert.
2004         * annotate.c: Revert.
2005         * amd64-windows-tdep.c: Revert.
2006         * amd64-windows-nat.c: Revert.
2007         * amd64-tdep.c: Revert.
2008         * amd64-sol2-tdep.c: Revert.
2009         * amd64-obsd-tdep.c: Revert.
2010         * amd64-obsd-nat.c: Revert.
2011         * amd64-nbsd-tdep.c: Revert.
2012         * amd64-nbsd-nat.c: Revert.
2013         * amd64-nat.c: Revert.
2014         * amd64-linux-tdep.c: Revert.
2015         * amd64-linux-nat.c: Revert.
2016         * amd64-fbsd-tdep.c: Revert.
2017         * amd64-fbsd-nat.c: Revert.
2018         * amd64-dicos-tdep.c: Revert.
2019         * amd64-darwin-tdep.c: Revert.
2020         * amd64-bsd-nat.c: Revert.
2021         * alpha-tdep.c: Revert.
2022         * alpha-obsd-tdep.c: Revert.
2023         * alpha-nbsd-tdep.c: Revert.
2024         * alpha-mdebug-tdep.c: Revert.
2025         * alpha-linux-tdep.c: Revert.
2026         * alpha-linux-nat.c: Revert.
2027         * alpha-bsd-tdep.c: Revert.
2028         * alpha-bsd-nat.c: Revert.
2029         * aix-thread.c: Revert.
2030         * agent.c: Revert.
2031         * addrmap.c: Revert.
2032         * ada-varobj.c: Revert.
2033         * ada-valprint.c: Revert.
2034         * ada-typeprint.c: Revert.
2035         * ada-tasks.c: Revert.
2036         * ada-lang.c: Revert.
2037         * aarch64-tdep.c: Revert.
2038         * aarch64-ravenscar-thread.c: Revert.
2039         * aarch64-newlib-tdep.c: Revert.
2040         * aarch64-linux-tdep.c: Revert.
2041         * aarch64-linux-nat.c: Revert.
2042         * aarch64-fbsd-tdep.c: Revert.
2043         * aarch64-fbsd-nat.c: Revert.
2044         * aarch32-linux-nat.c: Revert.
2045
2046 2019-04-05  Tom Tromey  <tom@tromey.com>
2047
2048         * ft32-tdep.c: Sort headers.
2049         * frv-tdep.c: Sort headers.
2050         * frv-linux-tdep.c: Sort headers.
2051         * frame.c: Sort headers.
2052         * frame-unwind.c: Sort headers.
2053         * frame-base.c: Sort headers.
2054         * fork-child.c: Sort headers.
2055         * findvar.c: Sort headers.
2056         * findcmd.c: Sort headers.
2057         * filesystem.c: Sort headers.
2058         * filename-seen-cache.h: Sort headers.
2059         * filename-seen-cache.c: Sort headers.
2060         * fbsd-tdep.c: Sort headers.
2061         * fbsd-nat.h: Sort headers.
2062         * fbsd-nat.c: Sort headers.
2063         * f-valprint.c: Sort headers.
2064         * f-typeprint.c: Sort headers.
2065         * f-lang.c: Sort headers.
2066         * extension.h: Sort headers.
2067         * extension.c: Sort headers.
2068         * extension-priv.h: Sort headers.
2069         * expprint.c: Sort headers.
2070         * exec.h: Sort headers.
2071         * exec.c: Sort headers.
2072         * exceptions.c: Sort headers.
2073         * event-top.c: Sort headers.
2074         * event-loop.c: Sort headers.
2075         * eval.c: Sort headers.
2076         * elfread.c: Sort headers.
2077         * dwarf2read.h: Sort headers.
2078         * dwarf2read.c: Sort headers.
2079         * dwarf2loc.c: Sort headers.
2080         * dwarf2expr.h: Sort headers.
2081         * dwarf2expr.c: Sort headers.
2082         * dwarf2-frame.c: Sort headers.
2083         * dwarf2-frame-tailcall.c: Sort headers.
2084         * dwarf-index-write.h: Sort headers.
2085         * dwarf-index-write.c: Sort headers.
2086         * dwarf-index-common.c: Sort headers.
2087         * dwarf-index-cache.h: Sort headers.
2088         * dwarf-index-cache.c: Sort headers.
2089         * dummy-frame.c: Sort headers.
2090         * dtrace-probe.c: Sort headers.
2091         * disasm.h: Sort headers.
2092         * disasm.c: Sort headers.
2093         * disasm-selftests.c: Sort headers.
2094         * dictionary.c: Sort headers.
2095         * dicos-tdep.c: Sort headers.
2096         * demangle.c: Sort headers.
2097         * dcache.h: Sort headers.
2098         * dcache.c: Sort headers.
2099         * darwin-nat.h: Sort headers.
2100         * darwin-nat.c: Sort headers.
2101         * darwin-nat-info.c: Sort headers.
2102         * d-valprint.c: Sort headers.
2103         * d-namespace.c: Sort headers.
2104         * d-lang.c: Sort headers.
2105         * ctf.c: Sort headers.
2106         * csky-tdep.c: Sort headers.
2107         * csky-linux-tdep.c: Sort headers.
2108         * cris-tdep.c: Sort headers.
2109         * cris-linux-tdep.c: Sort headers.
2110         * cp-valprint.c: Sort headers.
2111         * cp-support.c: Sort headers.
2112         * cp-namespace.c: Sort headers.
2113         * cp-abi.c: Sort headers.
2114         * corelow.c: Sort headers.
2115         * corefile.c: Sort headers.
2116         * continuations.c: Sort headers.
2117         * completer.h: Sort headers.
2118         * completer.c: Sort headers.
2119         * complaints.c: Sort headers.
2120         * coffread.c: Sort headers.
2121         * coff-pe-read.c: Sort headers.
2122         * cli-out.h: Sort headers.
2123         * cli-out.c: Sort headers.
2124         * charset.c: Sort headers.
2125         * c-varobj.c: Sort headers.
2126         * c-valprint.c: Sort headers.
2127         * c-typeprint.c: Sort headers.
2128         * c-lang.c: Sort headers.
2129         * buildsym.c: Sort headers.
2130         * buildsym-legacy.c: Sort headers.
2131         * build-id.h: Sort headers.
2132         * build-id.c: Sort headers.
2133         * btrace.c: Sort headers.
2134         * bsd-uthread.c: Sort headers.
2135         * breakpoint.h: Sort headers.
2136         * breakpoint.c: Sort headers.
2137         * break-catch-throw.c: Sort headers.
2138         * break-catch-syscall.c: Sort headers.
2139         * break-catch-sig.c: Sort headers.
2140         * blockframe.c: Sort headers.
2141         * block.c: Sort headers.
2142         * bfin-tdep.c: Sort headers.
2143         * bfin-linux-tdep.c: Sort headers.
2144         * bfd-target.c: Sort headers.
2145         * bcache.c: Sort headers.
2146         * ax-general.c: Sort headers.
2147         * ax-gdb.h: Sort headers.
2148         * ax-gdb.c: Sort headers.
2149         * avr-tdep.c: Sort headers.
2150         * auxv.c: Sort headers.
2151         * auto-load.c: Sort headers.
2152         * arm-wince-tdep.c: Sort headers.
2153         * arm-tdep.c: Sort headers.
2154         * arm-symbian-tdep.c: Sort headers.
2155         * arm-pikeos-tdep.c: Sort headers.
2156         * arm-obsd-tdep.c: Sort headers.
2157         * arm-nbsd-tdep.c: Sort headers.
2158         * arm-nbsd-nat.c: Sort headers.
2159         * arm-linux-tdep.c: Sort headers.
2160         * arm-linux-nat.c: Sort headers.
2161         * arm-fbsd-tdep.c: Sort headers.
2162         * arm-fbsd-nat.c: Sort headers.
2163         * arm-bsd-tdep.c: Sort headers.
2164         * arch-utils.c: Sort headers.
2165         * arc-tdep.c: Sort headers.
2166         * arc-newlib-tdep.c: Sort headers.
2167         * annotate.h: Sort headers.
2168         * annotate.c: Sort headers.
2169         * amd64-windows-tdep.c: Sort headers.
2170         * amd64-windows-nat.c: Sort headers.
2171         * amd64-tdep.c: Sort headers.
2172         * amd64-sol2-tdep.c: Sort headers.
2173         * amd64-obsd-tdep.c: Sort headers.
2174         * amd64-obsd-nat.c: Sort headers.
2175         * amd64-nbsd-tdep.c: Sort headers.
2176         * amd64-nbsd-nat.c: Sort headers.
2177         * amd64-nat.c: Sort headers.
2178         * amd64-linux-tdep.c: Sort headers.
2179         * amd64-linux-nat.c: Sort headers.
2180         * amd64-fbsd-tdep.c: Sort headers.
2181         * amd64-fbsd-nat.c: Sort headers.
2182         * amd64-dicos-tdep.c: Sort headers.
2183         * amd64-darwin-tdep.c: Sort headers.
2184         * amd64-bsd-nat.c: Sort headers.
2185         * alpha-tdep.c: Sort headers.
2186         * alpha-obsd-tdep.c: Sort headers.
2187         * alpha-nbsd-tdep.c: Sort headers.
2188         * alpha-mdebug-tdep.c: Sort headers.
2189         * alpha-linux-tdep.c: Sort headers.
2190         * alpha-linux-nat.c: Sort headers.
2191         * alpha-bsd-tdep.c: Sort headers.
2192         * alpha-bsd-nat.c: Sort headers.
2193         * aix-thread.c: Sort headers.
2194         * agent.c: Sort headers.
2195         * addrmap.c: Sort headers.
2196         * ada-varobj.c: Sort headers.
2197         * ada-valprint.c: Sort headers.
2198         * ada-typeprint.c: Sort headers.
2199         * ada-tasks.c: Sort headers.
2200         * ada-lang.c: Sort headers.
2201         * aarch64-tdep.c: Sort headers.
2202         * aarch64-ravenscar-thread.c: Sort headers.
2203         * aarch64-newlib-tdep.c: Sort headers.
2204         * aarch64-linux-tdep.c: Sort headers.
2205         * aarch64-linux-nat.c: Sort headers.
2206         * aarch64-fbsd-tdep.c: Sort headers.
2207         * aarch64-fbsd-nat.c: Sort headers.
2208         * aarch32-linux-nat.c: Sort headers.
2209
2210 2019-04-04  Tom Tromey  <tom@tromey.com>
2211
2212         * varobj.c (varobj_create): Update.
2213         * rust-exp.y (struct rust_parser) <update_innermost_block,
2214         lookup_symbol>: New methods.
2215         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2216         Rename.
2217         (rust_parser::rust_lookup_type)
2218         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2219         * printcmd.c (display_command, do_one_display): Update.
2220         * parser-defs.h (struct parser_state) <parser_state>: Add
2221         "tracker" parameter.
2222         (block_tracker): New member.
2223         (class innermost_block_tracker) <innermost_block_tracker>: Add
2224         "types" parameter.
2225         <reset>: Remove method.
2226         (innermost_block): Don't declare.
2227         (null_post_parser): Update.
2228         * parse.c (innermost_block): Remove global.
2229         (write_dollar_variable): Update.
2230         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2231         Remove "tracker_types" parameter.
2232         (parse_expression): Add "tracker" parameter.
2233         (parse_expression_for_completion): Update.
2234         (null_post_parser): Add "tracker" parameter.
2235         * p-exp.y: Update rules.
2236         * m2-exp.y: Update rules.
2237         * language.h (struct language_defn) <la_post_parser>: Add
2238         "tracker" parameter.
2239         * go-exp.y: Update rules.
2240         * f-exp.y: Update rules.
2241         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2242         parameter.
2243         * d-exp.y: Update rules.
2244         * c-exp.y: Update rules.
2245         * breakpoint.c (set_breakpoint_condition): Create an
2246         innermost_block_tracker.
2247         (watch_command_1): Likewise.
2248         * ada-lang.c (resolve): Add "tracker" parameter.
2249         (resolve_subexp): Likewise.
2250         * ada-exp.y (write_var_from_sym): Update.
2251
2252 2019-04-04  Tom Tromey  <tom@tromey.com>
2253
2254         * type-stack.h: New file.
2255         * type-stack.c: New file.
2256         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2257         type-stack.h.
2258         (insert_into_type_stack, insert_type, push_type, push_type_int)
2259         (insert_type_address_space, pop_type, pop_type_int)
2260         (pop_typelist, pop_type_stack, append_type_stack)
2261         (push_type_stack, get_type_stack, push_typelist)
2262         (follow_type_instance_flags, follow_types): Don't declare.
2263         * parse.c (type_stack): Remove global.
2264         (parse_exp_in_context): Update.
2265         (insert_into_type_stack, insert_type, push_type, push_type_int)
2266         (insert_type_address_space, pop_type, pop_type_int)
2267         (pop_typelist, pop_type_stack, append_type_stack)
2268         (push_type_stack, get_type_stack, push_typelist)
2269         (follow_type_instance_flags, follow_types): Remove (moved to
2270         type-stack.c).
2271         * f-exp.y (type_stack): New global.
2272         Update rules.
2273         (push_kind_type, f_parse): Update.
2274         * d-exp.y (type_stack): New global.
2275         Update rules.
2276         (d_parse): Update.
2277         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2278         Update rules.
2279         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2280         (HFILES_NO_SRCDIR): Add type-stack.h.
2281
2282 2019-04-04  Tom Tromey  <tom@tromey.com>
2283
2284         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2285         (rust_parser::convert_ast_to_expression, rust_parse)
2286         (rust_lex_test_completion, rust_lex_tests): Update.
2287         * parser-defs.h (struct expr_completion_state): New.
2288         (struct parser_state) <parser_state>: Add completion parameter.
2289         <mark_struct_expression, mark_completion_tag>: New methods.
2290         <parse_completion, m_completion_state>: New members.
2291         (prefixify_expression, null_post_parser): Update.
2292         (mark_struct_expression, mark_completion_tag): Don't declare.
2293         * parse.c (parse_completion, expout_last_struct)
2294         (expout_tag_completion_type, expout_completion_name): Remove
2295         globals.
2296         (parser_state::mark_struct_expression)
2297         (parser_state::mark_completion_tag): Now methods.
2298         (prefixify_expression): Add last_struct parameter.
2299         (prefixify_subexp): Likewise.
2300         (parse_exp_1): Update.
2301         (parse_exp_in_context): Add cstate parameter.  Update.
2302         (parse_expression_for_completion): Create an
2303         expr_completion_state.
2304         (null_post_parser): Add "completion" parameter.
2305         * p-exp.y: Update rules.
2306         (yylex): Update.
2307         * language.h (struct language_defn) <la_post_parser>: Add
2308         "completing" parameter.
2309         * go-exp.y: Update rules.
2310         (lex_one_token): Update.
2311         * expression.h (parse_completion): Don't declare.
2312         * d-exp.y: Update rules.
2313         (lex_one_token): Update rules.
2314         * c-exp.y: Update rules.
2315         (lex_one_token): Update.
2316         * ada-lang.c (resolve): Add "parse_completion" parameter.
2317         (resolve_subexp): Likewise.
2318         (ada_resolve_function): Likewise.
2319
2320 2019-04-04  Tom Tromey  <tom@tromey.com>
2321
2322         * parser-defs.h (struct parser_state) <start_arglist,
2323         end_arglist>: New methods.
2324         <arglist_len, m_funcall_chain>: New members.
2325         (arglist_len, start_arglist, end_arglist): Don't declare.
2326         * parse.c (arglist_len, funcall_chain): Remove global.
2327         (start_arglist, end_arglist): Remove functions.
2328         (parse_exp_in_context): Update.
2329         * p-exp.y: Update rules.
2330         * m2-exp.y: Update rules.
2331         * go-exp.y: Update rules.
2332         * f-exp.y: Update rules.
2333         * d-exp.y: Update rules.
2334         * c-exp.y: Update rules.
2335
2336 2019-04-04  Tom Tromey  <tom@tromey.com>
2337
2338         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2339         lex_operator, push_back>: New methods.
2340         Update all rules.
2341         (rust_parser::lex_hex, lex_escape): Rename and update.
2342         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2343         (rust_parser::lex_operator): Rename and update.
2344         (rust_parser::lex_number, rustyylex, rustyyerror)
2345         (rust_lex_test_init, rust_lex_test_sequence)
2346         (rust_lex_test_push_back, rust_lex_tests): Update.
2347         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2348         parameter.
2349         <lexptr, prev_lexptr>: New members.
2350         (lexptr, prev_lexptr): Don't declare.
2351         * parse.c (lexptr, prev_lexptr): Remove globals.
2352         (parse_exp_in_context): Update.
2353         * p-exp.y (yylex, yyerror): Update.
2354         * m2-exp.y (parse_number, yylex, yyerror): Update.
2355         * go-exp.y (lex_one_token, yyerror): Update.
2356         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2357         * d-exp.y (lex_one_token, yyerror): Update.
2358         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2359         (lex_one_token, yyerror): Update.
2360         * ada-lex.l (YY_INPUT): Update.
2361         (rewind_to_char): Update.
2362         * ada-exp.y (yyerror): Update.
2363
2364 2019-04-04  Tom Tromey  <tom@tromey.com>
2365
2366         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2367         * parser-defs.h (struct parser_state) <parser_state>: Add new
2368         parameter.
2369         <comma_terminates>: New member.
2370         (comma_terminates): Don't declare global.
2371         * parse.c (comma_terminates): Remove global.
2372         (parse_exp_in_context): Update.
2373         * p-exp.y (yylex): Update.
2374         * m2-exp.y (yylex): Update.
2375         * go-exp.y (lex_one_token): Update.
2376         * f-exp.y (yylex): Update.
2377         * d-exp.y (lex_one_token): Update.
2378         * c-exp.y (lex_one_token): Update.
2379         * ada-lex.l: Update.
2380
2381 2019-04-04  Tom Tromey  <tom@tromey.com>
2382
2383         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2384         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2385         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2386         * parser-defs.h (paren_depth): Don't declare.
2387         * parse.c (paren_depth): Remove global.
2388         (parse_exp_in_context): Update.
2389         * p-exp.y (paren_depth): New global.
2390         (pascal_parse): Initialize it.
2391         * m2-exp.y (paren_depth): New global.
2392         (m2_parse): Initialize it.
2393         * go-exp.y (paren_depth): New global.
2394         (go_parse): Initialize it.
2395         * f-exp.y (paren_depth): New global.
2396         (f_parse): Initialize it.
2397         * d-exp.y (paren_depth): New global.
2398         (d_parse): Initialize it.
2399         * c-exp.y (paren_depth): New global.
2400         (c_parse): Initialize it.
2401         * ada-lex.l (paren_depth): New global.
2402         (lexer_init): Initialize it.
2403
2404 2019-04-04  Tom Tromey  <tom@tromey.com>
2405
2406         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2407         (rust_parser::convert_ast_to_type)
2408         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2409         * parser-defs.h (struct parser_state) <parser_state>: Add
2410         parameters.  Initialize new members.
2411         <expression_context_block, expression_context_pc>: New members.
2412         * parse.c (expression_context_block, expression_context_pc):
2413         Remove globals.
2414         (parse_exp_in_context): Update.
2415         * p-exp.y: Update all rules.
2416         (yylex): Update.
2417         * m2-exp.y: Update all rules.
2418         (yylex): Update.
2419         * go-exp.y (yylex): Update.
2420         * f-exp.y (yylex): Update.
2421         * d-exp.y: Update all rules.
2422         (yylex): Update.
2423         * c-exp.y: Update all rules.
2424         (lex_one_token, classify_name, yylex, c_parse): Update.
2425         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2426
2427 2019-04-04  Tom Tromey  <tom@tromey.com>
2428
2429         * gdbarch.h, gdbarch.c: Rebuild.
2430         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2431         * stap-probe.h:
2432         (struct stap_parse_info): Replace "parser_state" with
2433         "expr_builder".
2434         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2435         (parser_state): New class.
2436         * parse.c (expr_builder): Rename.
2437         (expr_builder::release): Rename.
2438         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2439         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2440         (write_exp_elt_longcst, write_exp_elt_floatcst)
2441         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2442         (write_exp_string_vector, write_exp_bitstring)
2443         (write_exp_msymbol, mark_struct_expression)
2444         (write_dollar_variable)
2445         (insert_type_address_space, increase_expout_size): Replace
2446         "parser_state" with "expr_builder".
2447         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2448         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2449         "parser_state" with "expr_builder".
2450
2451 2019-04-04  Tom Tromey  <tom@tromey.com>
2452
2453         * rust-exp.y: Replace "parse_language" with method call.
2454         * p-exp.y:
2455         (yylex): Replace "parse_language" with method call.
2456         * m2-exp.y:
2457         (yylex): Replace "parse_language" with method call.
2458         * go-exp.y (classify_name): Replace "parse_language" with method
2459         call.
2460         * f-exp.y (yylex): Replace "parse_language" with method call.
2461         * d-exp.y (lex_one_token): Replace "parse_language" with method
2462         call.
2463         * c-exp.y:
2464         (lex_one_token, classify_name, yylex): Replace "parse_language"
2465         with method call.
2466         * ada-exp.y (find_primitive_type, type_char)
2467         (type_system_address): Replace "parse_language" with method call.
2468
2469 2019-04-04  Tom Tromey  <tom@tromey.com>
2470
2471         * rust-exp.y: Replace "parse_gdbarch" with method call.
2472         * parse.c (write_dollar_variable, insert_type_address_space):
2473         Replace "parse_gdbarch" with method call.
2474         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2475         call.
2476         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2477         call.
2478         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2479         "parse_gdbarch" with method call.
2480         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2481         with method call.
2482         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2483         "parse_gdbarch" with method call.
2484         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2485         "parse_gdbarch" with method call.
2486         * c-exp.y (parse_type, parse_number, classify_name): Replace
2487         "parse_gdbarch" with method call.
2488         * ada-lex.l: Replace "parse_gdbarch" with method call.
2489         * ada-exp.y (parse_type, find_primitive_type, type_char)
2490         (type_system_address): Replace "parse_gdbarch" with method call.
2491
2492 2019-04-04  Tom Tromey  <tom@tromey.com>
2493
2494         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2495         * stap-probe.c (stap_parse_argument): Update.
2496         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2497         initial_size parameter.
2498         * rust-exp.y (rust_lex_tests): Update.
2499         * parse.c (parser_state): Update.
2500         (parse_exp_in_context): Update.
2501         * parser-defs.h (struct parser_state) <parser_state>: Remove
2502         "initial_size" parameter.
2503
2504 2019-04-04  Tom Tromey  <tom@tromey.com>
2505
2506         * parser-defs.h (increase_expout_size): Don't declare.
2507         * parse.c (increase_expout_size): Now static.
2508
2509 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2510
2511         * gnu-nat.c (gnu_nat_target::wait): Fix
2512         target_waitstatus_to_string call.
2513
2514 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * eval.c (evaluate_subexp_standard): Handle internal functions
2517         during Fortran function call handling.
2518
2519 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2520
2521         * NEWS: Mention new internal functions.
2522         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2523         (read_base_type): Use dwarf2_init_complex_target_type.
2524         * value.c (creal_internal_fn): New function.
2525         (cimag_internal_fn): New function.
2526         (_initialize_values): Register new internal functions.
2527
2528 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2529
2530         * infrun.c (stop_all_threads): If debug_infrun, always
2531         trace the wait status after wait_one, using
2532         target_waitstatus_to_string and target_pid_to_str.
2533         (handle_inferior_event): Replace various trace of
2534         wait status kind by a single trace.
2535         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2536         wait status kind image by target_waitstatus_to_string.
2537         * target/waitstatus.c (target_waitstatus_to_string): Fix
2538         obsolete comment.
2539
2540 2019-04-01  Tom Tromey  <tromey@adacore.com>
2541
2542         PR symtab/23331:
2543         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2544
2545 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2546             Pedro Alves  <palves@redhat.com>
2547
2548         * top.c (quit_force): Call 'finalize_values'.
2549         * value.c (finalize_values): New function.
2550         * value.h (finalize_values): Declare.
2551
2552 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2553
2554         * NEWS: Announce $_gdb_major and $_gdb_minor.
2555
2556         * top.c (init_gdb_version_vars): New function.
2557         (gdb_init): Call init_gdb_version_vars.
2558
2559 2019-03-29  Tom Tromey  <tromey@adacore.com>
2560
2561         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2562         help text.  Remove dead code.
2563
2564 2019-03-29  Keith Seitz  <keiths@redhat.com>
2565
2566         From Siddhesh Poyarekar:
2567         * f-lang.h (f77_get_upperbound): Return LONGEST.
2568         (f77_get_lowerbound): Likewise.
2569         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2570         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2571         print them.
2572         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2573         plongest to format print it.
2574         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2575         (f77_get_upperbound): Likewise.
2576         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2577         LOWER_BOUND to LONGEST.
2578         (f77_create_arrayprint_offset_tbl): Likewise.
2579
2580 2019-03-29  Keith Seitz  <keiths@redhat.com>
2581
2582         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2583         %s/pulongest for TYPE_LENGTH instead of %d in format
2584         strings.
2585         * ada-typerint.c (ada_print_type): Likewise.
2586         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2587         * compile/compile-c-support.c (generate_register_struct): Likewise.
2588         * gdbtypes.c (recursive_dump_type): Likewise.
2589         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2590         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2591         instead of %d in format strings.
2592         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2593         to std::min to ULONGEST.
2594         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2595         instead of %d in format strings.
2596         * tracepoint.c (info_scope_command): Likewise.
2597         * typeprint.c (print_offset_data::update)
2598         (print_offset_data::finish): Likewise.
2599         * xtensa-tdep.c (xtensa_store_return_value)
2600         (xtensa_push_dummy_call): Likewise.
2601
2602 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2603
2604         * windows-nat.c (display_selector): Fixed format specifications
2605         for 64-bit Cygwin.
2606
2607 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2608
2609         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2610
2611 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2612
2613         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2614         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2615         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2616         (nios2_linux_init_abi): Install it.
2617
2618 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2619
2620         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2621
2622 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2623
2624         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2625
2626 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2627             Tom Tromey  <tromey@adacore.com>
2628
2629         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2630
2631 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2632
2633         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2634         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2635         method to compute the bounds of range types. Also print "[evaluated]"
2636         if the bounds' values come from a dynamic evaluation.
2637
2638 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2639
2640         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2641         whitespace when pretty printing is on.
2642
2643 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2644
2645         * ppc-linux-nat.c: Add include.
2646
2647 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2648
2649         * NEWS: Mention AArch64 Pointer Authentication.
2650
2651 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2652
2653         * arm-linux-nat.c: Add include.
2654
2655 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2656
2657         * source-cache.c (source_cache::get_source_lines): Re-read
2658         fullname after calling open_source_file.
2659
2660 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2661
2662         * NEWS: Mention TLS support for FreeBSD.
2663
2664 2019-03-25  Tom Tromey  <tromey@adacore.com>
2665
2666         * minsyms.c (BUNCH_SIZE): Update comment.
2667         (~minimal_symbol_reader): Remove old comment.
2668         (compact_minimal_symbols): Update comment.
2669         (minimal_symbol_reader::install): Remove old comment.  Update
2670         other comments.
2671
2672 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2673
2674         * s390-linux-nat.c: Add include.
2675
2676 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2677
2678         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2679         Call linux_get_hwcap.
2680         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2681         Likewise.
2682         (aarch64_linux_get_hwcap): Remove function.
2683         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2684         declaration.
2685         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2686         linux_get_hwcap.
2687         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2688         * linux-tdep.c (linux_get_hwcap): Add function.
2689         (linux_get_hwcap2): Likewise.
2690         * linux-tdep.h (linux_get_hwcap): Add declaration.
2691         (linux_get_hwcap2): Likewise.
2692         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2693         (ppc_linux_get_hwcap2): Likewise.
2694         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2695         linux_get_hwcap.
2696         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2697         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2698         (ppc_linux_nat_target::read_description): Likewise.
2699         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2700         * s390-linux-nat.c: Likewise.
2701         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2702
2703 2019-03-24  Tom Tromey  <tom@tromey.com>
2704
2705         * ada-lang.c (standard_lookup): Simplify initialization.
2706         (ada_lookup_symbol_nonlocal): Simplify return.
2707         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2708         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2709         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2710         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2711         initialization.
2712         * solib.c (solib_global_lookup): Simplify.
2713         * symtab.c (null_block_symbol): Remove.
2714         (symbol_cache_lookup): Simplify returns.
2715         (lookup_language_this): Simplify returns.
2716         (lookup_symbol_aux): Simplify return.
2717         (lookup_local_symbol): Simplify returns.
2718         (lookup_global_symbol_from_objfile): Simplify return.
2719         (lookup_symbol_in_objfile_symtabs)
2720         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2721         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2722         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2723         * cp-namespace.c (cp_lookup_bare_symbol)
2724         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2725         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2726         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2727         (cp_lookup_symbol_via_imports): Simplify initialization.
2728         (find_symbol_in_baseclass): Likewise.
2729         * symtab.h (null_block_symbol): Remove.
2730         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2731         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2732         (d_lookup_symbol_module): Likewise.
2733         (find_symbol_in_baseclass): Simplify initialization.
2734
2735 2019-03-24  Tom Tromey  <tom@tromey.com>
2736
2737         * expression.h: Don't include symtab.h.
2738         (struct block): Forward declare.
2739
2740 2019-03-24  Tom Tromey  <tom@tromey.com>
2741
2742         * c-exp.y (typebase): Remove casts.
2743         * gdbtypes.c (lookup_unsigned_typename, )
2744         (lookup_signed_typename): Remove cast.
2745         * eval.c (parse_to_comma_and_eval): Remove cast.
2746         * parse.c (write_dollar_variable): Remove cast.
2747         * block.h (struct block) <superblock>: Now const.
2748         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2749         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2750         (map_block): Make "block" const.
2751         * symfile.h (struct quick_symbol_functions)
2752         <map_matching_symbols>: Constify block argument to "callback".
2753         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2754         const.
2755         (find_pc_sect_compunit_symtab): Make "b" const.
2756         (find_symbol_at_address): Likewise.
2757         (search_symbols): Likewise.
2758         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2759         (dw2_debug_names_lookup_symbol): Likewise.
2760         (dw2_map_matching_symbols): Update.
2761         * p-valprint.c (pascal_val_print): Remove "block".
2762         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2763         (aux_add_nonlocal_symbols): Make "block" const.
2764         (resolve_subexp): Remove cast.
2765         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2766         const.
2767         (iterate_over_file_blocks): Likewise.
2768         * f-exp.y (%union) <bval>: Remove.
2769         * coffread.c (patch_opaque_types): Make "b" const.
2770         * spu-tdep.c (spu_catch_start): Make "block" const.
2771         * c-valprint.c (print_unpacked_pointer): Remove "block".
2772         * symmisc.c (dump_symtab_1): Make "b" const.
2773         (block_depth): Make "block" const.
2774         * d-exp.y (%union) <bval>: Remove.
2775         * cp-support.h (cp_lookup_rtti_type): Update.
2776         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2777         * psymtab.c (psym_lookup_symbol): Make "block" const.
2778         (maintenance_check_psymtabs): Make "b" const.
2779         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2780         (enumerate_locals, enumerate_args): Update.
2781         * python/py-symtab.c (stpy_global_block): Make "block" const.
2782         (stpy_static_block): Likewise.
2783         * inline-frame.c (block_starting_point_at): Make "new_block"
2784         const.
2785         * block.c (find_block_in_blockvector): Make return type const.
2786         (blockvector_for_pc_sect): Make "b" const.
2787         (find_block_in_blockvector): Make "b" const.
2788
2789 2019-03-23  Tom Tromey  <tom@tromey.com>
2790
2791         * varobj.c (varobj_create): Update.
2792         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2793         * printcmd.c (display_command, do_one_display): Don't reset
2794         innermost_block.
2795         * parser-defs.h (enum innermost_block_tracker_type): Move to
2796         expression.h.
2797         (innermost_block): Update comment.
2798         * parse.c (parse_exp_1): Add tracker_types parameter.
2799         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2800         tracker_types parameter.  Reset innermost_block.
2801         (parse_exp_in_context): Remove.
2802         (parse_expression_for_completion): Update.
2803         * objfiles.c (~objfile): Don't reset expression_context_block or
2804         innermost_block.
2805         * expression.h (enum innermost_block_tracker_type): Move from
2806         parser-defs.h.
2807         (parse_exp_1): Add tracker_types parameter.
2808         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2809         reset innermost_block.
2810
2811 2019-03-23  Tom Tromey  <tom@tromey.com>
2812
2813         * objfiles.h: Include bcache.h.
2814
2815 2019-03-23  Tom Tromey  <tom@tromey.com>
2816
2817         * linespec.c (get_current_search_block): Use
2818         scoped_restore_current_language.
2819         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2820
2821 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2822             Jiong Wang  <jiong.wang@arm.com>
2823
2824         * aarch64-linux-tdep.c
2825         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2826         section.
2827         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2828
2829 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2830             Jiong Wang  <jiong.wang@arm.com>
2831
2832         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2833         instructions.
2834         (aarch64_analyze_prologue_test): Add PACIASP test.
2835         (aarch64_prologue_prev_register): Unmask PC value.
2836
2837 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2838             Jiong Wang  <jiong.wang@arm.com>
2839
2840         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2841         (aarch64_dwarf2_prev_register): Unmask PC value.
2842         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2843         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2844         DW_CFA_AARCH64_negate_ra_state.
2845         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2846
2847 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2848             Jiong Wang  <jiong.wang@arm.com>
2849
2850         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2851         registers.
2852         (aarch64_pseudo_register_name): Likewise.
2853         (aarch64_pseudo_register_type): Likewise.
2854         (aarch64_pseudo_register_reggroup_p): Likewise.
2855         (aarch64_gdbarch_init): Add pauth registers.
2856         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2857         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2858         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2859         (struct gdbarch_tdep): Add regnum for ra_state.
2860
2861 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2862             Jiong Wang  <jiong.wang@arm.com>
2863
2864         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2865
2866 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2867             Jiong Wang  <jiong.wang@arm.com>
2868
2869         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2870         function.
2871         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2872         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2873         (aarch64_gdbarch_init): Add puth registers.
2874         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2875         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2876         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2877
2878 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2879             Jiong Wang  <jiong.wang@arm.com>
2880
2881         * aarch64-linux-nat.c
2882         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2883         * aarch64-linux-tdep.c
2884         (aarch64_linux_core_read_description): Likewise.
2885         (aarch64_linux_get_hwcap): New function.
2886         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2887         (aarch64_linux_get_hwcap): New declaration.
2888
2889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2890             Jiong Wang  <jiong.wang@arm.com>
2891
2892         * aarch64-linux-nat.c
2893         (aarch64_linux_nat_target::read_description): Add pauth param.
2894         * aarch64-linux-tdep.c
2895         (aarch64_linux_core_read_description): Likewise.
2896         * aarch64-tdep.c (struct target_desc): Add in pauth.
2897         (aarch64_read_description): Add pauth param.
2898         (aarch64_gdbarch_init): Likewise.
2899         * aarch64-tdep.h (aarch64_read_description): Likewise.
2900         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2901         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2902         * features/Makefile: Add new files.
2903         * features/aarch64-pauth.c: New file.
2904         * features/aarch64-pauth.xml: New file.
2905
2906 2019-03-20  Tom Tromey  <tromey@adacore.com>
2907
2908         * infrun.c (handle_inferior_event): Rename from
2909         handle_inferior_event_1.  Create a scoped_value_mark.
2910         (handle_inferior_event): Remove.
2911
2912 2019-03-19  Tom Tromey  <tromey@adacore.com>
2913
2914         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2915         * infrun.h (print_stop_event): Add "displays" parameter.
2916         * infrun.c (print_stop_event): Add "displays" parameter.
2917
2918 2019-03-19  Pedro Alves  <palves@redhat.com>
2919
2920         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2921         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2922         to -1.  Fix TABs vs spaces.
2923         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2924         * tui/tui-out.h (tui_ui_out) Add intro comments.
2925         <m_line, m_start_of_line>: In-class initialize, and add describing
2926         comment.
2927
2928 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2929
2930         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2931         variable names.
2932         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2933
2934 2019-03-18  Pedro Alves  <palves@redhat.com>
2935             Eli Zaretskii <eliz@gnu.org>
2936
2937         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2938         m_line and m_start_of_line.
2939
2940 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2941
2942         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2943         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2944         it returns a newline.  This fixes a regression in TU mode, whereby
2945         the next line is output on the same screen line as the user input.
2946
2947 2019-03-18  Tom Tromey  <tromey@adacore.com>
2948
2949         * minsyms.c (minimal_symbol_reader::install): Remove call to
2950         obstack_blank.
2951
2952 2019-03-18  Pedro Alves  <palves@redhat.com>
2953
2954         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2955         New globals.
2956         (apply_style): New, factored out from ...
2957         (apply_ansi_escape): ... this.  Handle reverse video mode.
2958         (tui_set_reverse_mode): New function.
2959         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2960         * tui/tui-winsource.c (tui_show_source_line): Use
2961         tui_set_reverse_mode instead of setting A_STANDOUT.
2962         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2963         New setter methods.
2964
2965 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2966
2967         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2968         Handle tabs.
2969
2970 2019-03-18  Tom Tromey  <tromey@adacore.com>
2971
2972         * ada-lang.c (empty_array): Add "high" parameter.
2973         (ada_evaluate_subexp): Update.
2974
2975 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2976
2977         * unittests/string_view-selftests.c: Define
2978         _initialize_string_view_selftests unconditionally.
2979
2980 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2981
2982         PR gdb/24350
2983         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2984
2985 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2986
2987         PR gdb/24351
2988         * windows-nat.c (display_selector): Fix format specifiers.
2989
2990 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2991
2992         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2993         tui_refill_source_window instead of tui_refresh_win, to update the
2994         current execution line.  This fixes redisplay of the current line
2995         when stepping through the code with "next" or "step".
2996
2997 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2998
2999         * source-cache.c (source_cache::get_source_lines): Call
3000         find_source_lines to initialize s->nlines.  This fixes vertical
3001         scrolling of TUI source window when the DOWN arrow is pressed.
3002
3003 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3004
3005         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3006         linux-thread-db.c (_initialize_thread_db): Likewise.
3007
3008 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3009
3010         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3011         wclrtoeol in tui_show_source_line".  This reverts changes made in
3012         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3013
3014 2019-03-15  Tom Tromey  <tom@tromey.com>
3015
3016         * symtab.h (struct minimal_symbol): Derive from
3017         general_symbol_info.
3018         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3019         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3020         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3021         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3022         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3023         (MSYMBOL_SEARCH_NAME): Update.
3024         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3025         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3026         * minsyms.c (minimal_symbol_reader::record_full): Update.
3027
3028 2019-03-15  Tom Tromey  <tom@tromey.com>
3029
3030         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3031
3032 2019-03-15  Tom Tromey  <tom@tromey.com>
3033
3034         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3035         unique_xmalloc_ptr.
3036         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3037         Update.
3038         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3039         (build_minimal_symbol_hash_tables)
3040         (minimal_symbol_reader::install): Update.
3041
3042 2019-03-15  Tom Tromey  <tom@tromey.com>
3043
3044         * symtab.c (create_demangled_names_hash): Update.
3045         (symbol_set_names): Update.
3046         * objfiles.h (struct objfile_per_bfd_storage)
3047         <demangled_names_hash>: Now an htab_up.
3048         * objfiles.c (objfile_per_bfd_storage): Simplify.
3049
3050 2019-03-15  Tom Tromey  <tom@tromey.com>
3051
3052         * objfiles.h (struct objfile_per_bfd_storage): Declare
3053         destructor.
3054         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3055         New.
3056         (get_objfile_bfd_data): Use new.  Don't initialize
3057         language_of_main.
3058         (free_objfile_per_bfd_storage): Remove.
3059         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3060
3061 2019-03-15  Tom Tromey  <tom@tromey.com>
3062
3063         * symfile.c (reread_symbols): Update.
3064         * objfiles.c (objfile::objfile): Update.
3065         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3066         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3067         comment.
3068         (minimal_symbol_reader::install): Update.
3069         (terminate_minimal_symbol_table): Remove.
3070         * jit.c (jit_object_close_impl): Update.
3071
3072 2019-03-15  Tom Tromey  <tom@tromey.com>
3073
3074         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3075         initializations.
3076
3077 2019-03-15  Tom Tromey  <tom@tromey.com>
3078
3079         * objfiles.h (struct objfile_per_bfd_storage)
3080         <demangled_hash_languages>: Now a bitset.
3081         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3082         (lookup_minimal_symbol): Update.
3083
3084 2019-03-15  Tom Tromey  <tom@tromey.com>
3085
3086         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3087         Don't return the symbol.
3088         * coffread.c (record_minimal_symbol): Use record_full.
3089
3090 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3091
3092         The MS-Windows port of ncurses fails to switch to a color pair if
3093         one or both of the colors are the implicit default colors.  This
3094         change records the default colors when TUI is initialized, and
3095         then specifies them explicitly when a color pair uses the default
3096         colors.  This allows color styling in TUI mode on MS-Windows.
3097
3098         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3099         ncurses_norm_attr.
3100         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3101         colors in ncurses_norm_attr.
3102         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3103         "none", replace it with the default color recorded in
3104         ncurses_norm_attr.
3105
3106 2019-03-14  Tom Tromey  <tromey@adacore.com>
3107
3108         * source-cache.h (class source_cache) <get_source_lines>: Return
3109         std::string.
3110         * source-cache.c (source_cache::extract_lines): Handle case where
3111         first_pos==npos.  Return std::string.
3112         (source_cache::get_source_lines): Update.
3113
3114 2019-03-14  Tom Tromey  <tromey@adacore.com>
3115
3116         * NEWS: Add item for "style sources" commands.
3117         * source-cache.c (source_cache::get_source_lines): Check
3118         source_styling.
3119         * cli/cli-style.c (source_styling): New global.
3120         (_initialize_cli_style): Add "style sources" commands.
3121         (show_style_sources): New function.
3122         * cli/cli-style.h (source_styling): Declare.
3123
3124 2019-03-14  Pedro Alves  <palves@redhat.com>
3125             Tom Tromey  <tromey@adacore.com>
3126
3127         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3128         * tui/tui-winsource.c (tui_refill_source_window): New function,
3129         from...
3130         (tui_horizontal_source_scroll): ... here.  Move some logic.
3131         * cli/cli-style.c (set_style_enabled): Notify new observable.
3132         * tui/tui-hooks.c (tui_redisplay_source): New function.
3133         (tui_attach_detach_observers): Attach or detach
3134         tui_redisplay_source.
3135         * observable.h (source_styling_changed): New observable.
3136         * observable.c: Define source_styling_changed observable.
3137
3138 2019-03-13  Tom Tromey  <tromey@adacore.com>
3139
3140         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3141         (i386_gnu_nat_target::store_registers): Update.
3142         * target-debug.h (target_debug_print_std_string): New macro.
3143         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3144         * windows-tdep.c (display_one_tib): Update.
3145         * tui/tui-stack.c (tui_make_status_line): Update.
3146         * top.c (print_inferior_quit_action): Update.
3147         * thread.c (thr_try_catch_cmd): Update.
3148         (add_thread_with_info): Update.
3149         (thread_target_id_str): Update.
3150         (thr_try_catch_cmd): Update.
3151         (thread_command): Update.
3152         (thread_find_command): Update.
3153         * record-btrace.c (record_btrace_target::info_record)
3154         (record_btrace_resume_thread, record_btrace_target::resume)
3155         (record_btrace_cancel_resume, record_btrace_step_thread)
3156         (record_btrace_target::wait, record_btrace_target::wait)
3157         (record_btrace_target::wait, record_btrace_target::stop): Update.
3158         * progspace.c (print_program_space): Update.
3159         * process-stratum-target.c
3160         (process_stratum_target::thread_address_space): Update.
3161         * linux-fork.c (linux_fork_mourn_inferior)
3162         (detach_checkpoint_command, info_checkpoints_command)
3163         (linux_fork_context): Update.
3164         (linux_fork_detach): Update.
3165         (class scoped_switch_fork_info): Update.
3166         (delete_checkpoint_command): Update.
3167         * infrun.c (follow_fork_inferior): Update.
3168         (follow_fork_inferior): Update.
3169         (proceed_after_vfork_done): Update.
3170         (handle_vfork_child_exec_or_exit): Update.
3171         (follow_exec): Update.
3172         (displaced_step_prepare_throw): Update.
3173         (displaced_step_restore): Update.
3174         (start_step_over): Update.
3175         (resume_1): Update.
3176         (clear_proceed_status_thread): Update.
3177         (proceed): Update.
3178         (print_target_wait_results): Update.
3179         (do_target_wait): Update.
3180         (context_switch): Update.
3181         (stop_all_threads): Update.
3182         (restart_threads): Update.
3183         (finish_step_over): Update.
3184         (handle_signal_stop): Update.
3185         (switch_back_to_stepped_thread): Update.
3186         (keep_going_pass_signal): Update.
3187         (print_exited_reason): Update.
3188         (normal_stop): Update.
3189         * inferior.c (inferior_pid_to_str): Change return type.
3190         (print_selected_inferior): Update.
3191         (add_inferior): Update.
3192         (detach_inferior): Update.
3193         * dummy-frame.c (fprint_dummy_frames): Update.
3194         * dcache.c (dcache_info_1): Update.
3195         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3196         (btrace_fetch, btrace_clear): Update.
3197         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3198         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3199         type.
3200         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3201         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3202         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3203         * gdbarch.c, gdbarch.h: Rebuild.
3204         * gdbarch.sh (core_pid_to_str): Change return type.
3205         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3206         return type.
3207         (windows_nat_target::pid_to_str): Change return type.
3208         (windows_delete_thread): Update.
3209         (windows_nat_target::attach): Update.
3210         (windows_nat_target::files_info): Update.
3211         * target-delegates.c: Rebuild.
3212         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3213         return type.
3214         (sol_thread_target::pid_to_str): Change return type.
3215         * remote.c (class remote_target) <pid_to_str>: Change return
3216         type.
3217         (remote_target::pid_to_str): Change return type.
3218         (extended_remote_target::attach, remote_target::remote_stop_ns)
3219         (remote_target::remote_notif_remove_queued_reply)
3220         (remote_target::push_stop_reply, remote_target::disable_btrace):
3221         Update.
3222         (extended_remote_target::attach): Update.
3223         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3224         type.
3225         (gdbsim_target::pid_to_str): Change return type.
3226         * ravenscar-thread.c (struct ravenscar_thread_target)
3227         <pid_to_str>: Change return type.
3228         (ravenscar_thread_target::pid_to_str): Change return type.
3229         * procfs.c (class procfs_target) <pid_to_str>: Change return
3230         type.
3231         (procfs_target::pid_to_str): Change return type.
3232         (procfs_target::attach): Update.
3233         (procfs_target::detach): Update.
3234         (procfs_target::fetch_registers): Update.
3235         (procfs_target::store_registers): Update.
3236         (procfs_target::wait): Update.
3237         (procfs_target::files_info): Update.
3238         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3239         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3240         return type.
3241         (nto_procfs_target::pid_to_str): Change return type.
3242         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3243         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3244         return type.
3245         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3246         (exit_lwp): Update.
3247         (attach_proc_task_lwp_callback, get_detach_signal)
3248         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3249         (linux_nat_target::resume, wait_lwp, stop_callback)
3250         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3251         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3252         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3253         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3254         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3255         type.
3256         (inf_ptrace_target::attach): Update.
3257         (inf_ptrace_target::files_info): Update.
3258         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3259         type.
3260         (go32_nat_target::pid_to_str): Change return type.
3261         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3262         (gnu_nat_target::wait): Update.
3263         (gnu_nat_target::wait): Update.
3264         (gnu_nat_target::resume): Update.
3265         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3266         (fbsd_nat_target::wait): Update.
3267         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3268         type.
3269         (darwin_nat_target::attach): Update.
3270         * corelow.c (class core_target) <pid_to_str>: Change return type.
3271         (core_target::pid_to_str): Change return type.
3272         * target.c (normal_pid_to_str): Change return type.
3273         (default_pid_to_str): Likewise.
3274         (target_pid_to_str): Change return type.
3275         (target_translate_tls_address): Update.
3276         (target_announce_detach): Update.
3277         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3278         return type.
3279         (bsd_uthread_target::pid_to_str): Change return type.
3280         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3281         type.
3282         (bsd_kvm_target::pid_to_str): Change return type.
3283         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3284         return type.
3285         (aix_thread_target::pid_to_str): Change return type.
3286         * target.h (struct target_ops) <pid_to_str>: Change return type.
3287         (target_pid_to_str, normal_pid_to_str): Likewise.
3288         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3289         type.
3290         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3291         type.
3292         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3293         return type.
3294         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3295         type.
3296         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3297         type.
3298         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3299         return type.
3300
3301 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3302
3303         * NEWS: Mention that the new default MI version is 3.  Mention
3304         changes to the output of commands and events that deal with
3305         multi-location breakpoints.
3306         * breakpoint.c: Include "mi/mi-out.h".
3307         (print_one_breakpoint): Change output syntax if using MI version
3308         >= 3.
3309         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3310         New.
3311         (mi_multi_location_breakpoint_output_fixed): New.
3312         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3313         (mi_cmd_fix_multi_location_breakpoint_output): New.
3314         (mi_multi_location_breakpoint_output_fixed): New.
3315         * mi/mi-cmds.c (mi_cmds): Register command
3316         -fix-multi-location-breakpoint-output.
3317         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3318         interpreter "mi".
3319
3320 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3321
3322         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3323         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3324         instantiate mi_ui_out based on interpreter name.
3325         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3326         * mi/mi-main.c (mi_load_progress): Likewise.
3327
3328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3329
3330         * NEWS: Combine separate "New targets" sections for 8.3.
3331
3332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3333
3334         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3335         (ppcfbsd_init_abi): Install gdbarch
3336         "fetch_tls_load_module_address" and "get_thread_local_address"
3337         methods.
3338
3339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3340
3341         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3342         (riscv_fbsd_init_abi): Install gdbarch
3343         "fetch_tls_load_module_address" and "get_thread_local_address"
3344         methods.
3345
3346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3347
3348         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3349         (i386fbsd_init_abi): Install gdbarch
3350         "fetch_tls_load_module_address" and "get_thread_local_address"
3351         methods.
3352
3353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3354
3355         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3356         (amd64fbsd_init_abi): Install gdbarch
3357         "fetch_tls_load_module_address" and "get_thread_local_address"
3358         methods.
3359
3360 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3361
3362         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3363         (struct fbsd_pspace_data): New type.
3364         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3365         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3366         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3367         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3368         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3369
3370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3371
3372         * gdbtypes.c (lookup_struct_elt): New function.
3373         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3374         * gdbtypes.h (struct struct_elt): New type.
3375         (lookup_struct_elt): New prototype.
3376
3377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3378
3379         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3380         remove disabled code block.
3381
3382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3383
3384         * gdbarch.sh (get_thread_local_address): New method.
3385         * gdbarch.h, gdbarch.c: Regenerate.
3386         * target.c (target_translate_tls_address): Use
3387         gdbarch_get_thread_local_address if present instead of
3388         target::get_thread_local_address.
3389
3390 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3391
3392         * target.h (target::get_thread_local_address): Update comment.
3393
3394 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3395
3396         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3397         objfile->separate_debug_objfile_backlink if not NULL.
3398
3399 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3400
3401         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3402         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3403         (amd64bsd_store_inferior_registers): Likewise.
3404         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3405         Enable segment base registers.
3406         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3407         PT_GETFSBASE and PT_GETGSBASE.
3408         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3409         PT_SETGSBASE.
3410         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3411         segment base registers.
3412         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3413
3414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3415
3416         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3417         Update calls to i386_target_description to add 'segments'
3418         parameter.
3419         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3420         add segment base registers.
3421         * arch/i386.c (i386_create_target_description): Add 'segments'
3422         parameter to enable segment base registers.
3423         * arch/i386.h (i386_create_target_description): Likewise.
3424         * features/i386/32bit-segments.xml: New file.
3425         * features/i386/32bit-segments.c: Generate.
3426         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3427         call to i386_target_description to add 'segments' parameter.
3428         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3429         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3430         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3431         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3432         if feature is present.
3433         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3434         Add 'segments' parameter to call to i386_target_description.
3435         (i386_target_description): Add 'segments' parameter to enable
3436         segment base registers.
3437         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3438         to call to i386_target_description.
3439         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3440         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3441         Define I386_NUM_REGS.
3442         (i386_target_description): Add 'segments' parameter to enable
3443         segment base registers.
3444
3445 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3446
3447         PR/24325
3448         * source-cache.c: #undef open and close, to avoid unresolved
3449         externals during linking.
3450
3451 2019-03-12  Tom Tromey  <tromey@adacore.com>
3452
3453         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3454         const.  Add initializers.
3455         (_initialize_remote): Don't initialize ptid globals.
3456
3457 2019-03-12  Pedro Alves  <palves@redhat.com>
3458
3459         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3460
3461 2019-03-12  Pedro Alves  <palves@redhat.com>
3462
3463         * cp-name-parser.y (main): Remove unused 'len' variable.
3464
3465 2019-03-12  Tom Tromey  <tromey@adacore.com>
3466
3467         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3468         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3469
3470 2019-03-12  Tom Tromey  <tromey@adacore.com>
3471
3472         * linux-nat.c (iterate_over_lwps): Update.
3473         (stop_callback): Remove parameter.
3474         (stop_wait_callback, detach_callback, resume_set_callback)
3475         (select_singlestep_lwp_callback, set_ignore_sigint)
3476         (status_callback, resumed_callback, resume_clear_callback)
3477         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3478         data parameter.
3479         (linux_nat_target::detach, linux_nat_target::resume)
3480         (linux_stop_and_wait_all_lwps, select_event_lwp)
3481         (linux_nat_filter_event, linux_nat_wait_1)
3482         (linux_nat_target::kill, linux_nat_target::stop)
3483         (linux_nat_target::stop): Update.
3484         (linux_nat_resume_callback): Change type.
3485         (resume_stopped_resumed_lwps, count_events_callback)
3486         (select_event_lwp_callback): Likewise.
3487         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3488         * arm-linux-nat.c (struct update_registers_data): Remove.
3489         (update_registers_callback): Change type.
3490         (arm_linux_insert_hw_breakpoint1): Update.
3491         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3492         parameter.
3493         (x86_linux_dr_set_addr): Update.
3494         (x86_linux_dr_set_control): Update.
3495         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3496         (iterate_over_lwps): Use gdb::function_view.
3497         * nat/aarch64-linux-hw-point.c (struct
3498         aarch64_dr_update_callback_param): Remove.
3499         (debug_reg_change_callback): Change type.
3500         (aarch64_notify_debug_reg_change): Update.
3501         * s390-linux-nat.c (s390_refresh_per_info): Update.
3502
3503 2019-03-11  Tom Tromey  <tromey@adacore.com>
3504
3505         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3506         redundant assignment to "this_cu".
3507
3508 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3509
3510         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3511
3512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3513
3514         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3515         from...
3516         (rank_one_type): ... this.
3517
3518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3519
3520         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3521         from...
3522         (rank_one_type): ... this.
3523
3524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3525
3526         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3527         from...
3528         (rank_one_type): ... this.
3529
3530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3531
3532         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3533         from...
3534         (rank_one_type): ... this.
3535
3536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3537
3538         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3539         from...
3540         (rank_one_type): ... this.
3541
3542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3543
3544         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3545         from...
3546         (rank_one_type): ... this.
3547
3548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3549
3550         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3551         from...
3552         (rank_one_type): ... this.
3553
3554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3555
3556         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3557         from...
3558         (rank_one_type): ... this.
3559
3560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3561
3562         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3563         from...
3564         (rank_one_type): ... this.
3565
3566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3567
3568         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3569         from...
3570         (rank_one_type): ... this.
3571
3572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3573
3574         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3575         from...
3576         (rank_one_type): ... this.
3577
3578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3579
3580         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3581         from...
3582         (rank_one_type): ... this.
3583
3584 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3585
3586         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3587         inferior-events' shows the example events.
3588
3589 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3590
3591         Support styling on native MS-Windows console
3592
3593         PR/24315
3594         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3595         on MS-Windows if $TERM is not defined.
3596
3597         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3598
3599         * posix-hdep.c (gdb_console_fputs):
3600         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3601         functions.
3602         * ui-file.h (gdb_console_fputs): Add prototype.
3603
3604         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3605         back to fputs only if the former returns zero.
3606
3607 2019-03-07  Tom Tromey  <tom@tromey.com>
3608
3609         * symmisc.c (print_symbol_bcache_statistics): Update.
3610         (print_objfile_statistics): Update.
3611         * symfile.c (allocate_symtab): Update.
3612         * stabsread.c: Don't include bcache.h.
3613         * psymtab.h (struct psymbol_bcache): Don't declare.
3614         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3615         (psymbol_bcache_init, psymbol_bcache_free)
3616         (psymbol_bcache_get_bcache): Don't declare.
3617         * psymtab.c (struct psymbol_bcache): Remove.
3618         (psymtab_storage::psymtab_storage): Update.
3619         (psymtab_storage::~psymtab_storage): Update.
3620         (psymbol_bcache_init, psymbol_bcache_free)
3621         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3622         (add_psymbol_to_bcache): Update.
3623         (allocate_psymtab): Update.
3624         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3625         macro_cache>: No longer pointers.
3626         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3627         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3628         * macrotab.c (macro_bcache): Update.
3629         * macroexp.c: Don't include bcache.h.
3630         * gdbtypes.c (check_types_worklist): Update.
3631         (types_deeply_equal): Remove TRY/CATCH.  Update.
3632         * elfread.c (elf_symtab_read): Update.
3633         * dwarf2read.c: Don't include bcache.h.
3634         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3635         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3636         (print_bcache_statistics, bcache_memory_used): Don't declare.
3637         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3638         methods.  Rename all data members.
3639         * bcache.c (struct bcache): Move to bcache.h.
3640         (bcache::expand_hash_table): Rename from expand_hash_table.
3641         (bcache): Remove.
3642         (bcache::insert): Rename from bcache_full.
3643         (bcache::compare): Rename from bcache_compare.
3644         (bcache_xmalloc): Remove.
3645         (bcache::~bcache): Rename from bcache_xfree.
3646         (bcache::print_statistics): Rename from print_bcache_statistics.
3647         (bcache::memory_used): Rename from bcache_memory_used.
3648
3649 2019-03-07  Pedro Alves  <palves@redhat.com>
3650
3651         * infrun.c (normal_stop): Also check for
3652         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3653
3654 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * f-lang.c (value_from_host_double): Moved to...
3657         * value.c (value_from_host_double): ...here.
3658         * value.h (value_from_host_double): Declare.
3659         * guile/scm-math.c (vlscm_convert_typed_number): Use
3660         value_from_host_double.
3661         (vlscm_convert_number): Likewise.
3662         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3663         * python/py-value.c (convert_value_from_python): Likewise.
3664
3665 2019-03-06  Tom Tromey  <tom@tromey.com>
3666
3667         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3668
3669 2019-03-06  Tom Tromey  <tom@tromey.com>
3670
3671         * utils.h (free_current_contents): Don't declare.
3672         * utils.c (free_current_contents): Remove.
3673
3674 2019-03-06  Tom Tromey  <tom@tromey.com>
3675
3676         * top.c (quit_force): Update.
3677         * main.c (captured_command_loop): Update.
3678         * common/new-op.c (operator new): Update.
3679         * common/common-exceptions.c (struct catcher)
3680         <save_cleanup_chain>: Remove member.
3681         (exceptions_state_mc_init): Update.
3682         (exception_try_scope_entry): Return nullptr.
3683         (exception_try_scope_exit, exception_rethrow)
3684         (throw_exception_sjlj, throw_exception_cxx): Update.
3685         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3686         (all_cleanups, do_cleanups, discard_cleanups)
3687         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3688         (restore_cleanups, restore_final_cleanups): Don't declare.
3689         (do_final_cleanups): Remove parameter.
3690         * common/cleanups.c (cleanup_chain, make_cleanup)
3691         (make_cleanup_dtor, all_cleanups, do_cleanups)
3692         (discard_my_cleanups, discard_cleanups)
3693         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3694         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3695         (null_cleanup): Remove.
3696         (do_final_cleanups): Remove parameter.
3697
3698 2019-03-06  Tom Tromey  <tom@tromey.com>
3699
3700         * remote.c (remote_target::remote_parse_stop_reply): Use
3701         unique_xmalloc_ptr.
3702
3703 2019-03-06  Tom Tromey  <tom@tromey.com>
3704
3705         * stabsread.c (struct stabs_field_info): Rename from field_info.
3706         <list, fnlist>: Add initializers.
3707         <obstack>: New member.
3708         (read_member_functions, read_struct_fields, read_baseclasses):
3709         Allocate on obstack.  Don't use cleanups.
3710         (read_one_struct_field, read_member_functions, read_struct_fields)
3711         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3712         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3713         (read_struct_type): Update.
3714
3715 2019-03-06  Tom Tromey  <tom@tromey.com>
3716
3717         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3718         * common/filestuff.h (make_cleanup_close): Don't declare.
3719         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3720         Remove.
3721
3722 2019-03-06  Tom Tromey  <tom@tromey.com>
3723
3724         * solib-aix.c: Use make_scope_exit.
3725
3726 2019-03-06  Tom Tromey  <tom@tromey.com>
3727
3728         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3729         Use make_scope_exit.
3730
3731 2019-03-06  Tom Tromey  <tom@tromey.com>
3732
3733         * solib-svr4.c (disable_probes_interface): Remove parameter.
3734         (svr4_handle_solib_event): Use make_scope_exit.
3735
3736 2019-03-06  Tom Tromey  <tom@tromey.com>
3737
3738         * remote.c (struct stop_reply_deleter): Remove.
3739         (stop_reply_up): Update.
3740         (struct stop_reply): Derive from notif_event.  Don't typedef.
3741         <regcache>: Now a std::vector.
3742         (stop_reply_xfree): Remove.
3743         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3744         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3745         (remote_target::discard_pending_stop_replies): Use delete.
3746         (remote_target::remote_parse_stop_reply): Update.
3747         (remote_target::process_stop_reply): Update.
3748         * remote-notif.h (struct notif_event): Add virtual destructor.
3749         Remove "dtr" member.
3750         (struct notif_client) <alloc_event>: Return a unique_ptr.
3751         (notif_event_xfree): Don't declare.
3752         (notif_event_up): New typedef.
3753         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3754         (notif_event_xfree, do_notif_event_xfree): Remove.
3755         (remote_notif_state_xfree): Update.
3756
3757 2019-03-06  Tom Tromey  <tom@tromey.com>
3758
3759         * infrun.c (displaced_step_clear_cleanup): Now a
3760         forward_scope_exit type.
3761         (displaced_step_prepare_throw): Update.
3762         (displaced_step_fixup): Update.
3763
3764 2019-03-06  Tom Tromey  <tom@tromey.com>
3765
3766         * inferior.h (class inferior): Update comment.
3767         * gdbthread.h (class thread_info): Update comment.
3768
3769 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3770             Tom Tromey  <tom@tromey.com>
3771
3772         * stabsread.h (struct stab_section_list): Remove.
3773         (coffstab_build_psymtabs): Update.
3774         * dbxread.c (symbuf_sections): Now a std::vector.
3775         (sect_idx): New global.
3776         (fill_symbuf): Update.
3777         (coffstab_build_psymtabs): Change type of stabsects parameter.
3778         Update.
3779         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3780         std::vector.
3781         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3782         (coff_locate_sections): Update.
3783         (coff_symfile_read): Remove cleanups.  Update.
3784         (init_stringtab): Add storage parameter.
3785         (free_stringtab, free_stringtab_cleanup): Remove.
3786         (init_lineno): Add storage parameter.
3787         (free_linetab, free_linetab_cleanup): Remove.
3788
3789 2019-03-06  Pedro Alves  <palves@redhat.com>
3790
3791         * linux-fork.c (fork_info::clobber_regs): Delete.
3792         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3793         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3794         comment.  Adjust.
3795         (scoped_switch_fork_info::scoped_switch_fork_info)
3796         (checkpoint_command, linux_fork_context): Adjust
3797         fork_save_infrun_state calls.
3798
3799 2019-03-06  Pedro Alves  <palves@redhat.com>
3800
3801         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3802         (inf_has_multiple_threads): Return 'bool' and rewrite using
3803         inferior_info::threads().
3804
3805 2019-03-06  Pedro Alves  <palves@redhat.com>
3806
3807         * linux-fork.c: Include <list>.
3808         (fork_list): Now a std::list instance.
3809         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3810         (forks_exist_p, find_last_fork): Adjust.
3811         (new_fork): Delete.
3812         (one_fork_p): New.
3813         (add_fork): Adjust.
3814         (free_fork): Delete, folded into fork_info::~fork_info().
3815         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3816         Adjust.
3817         (init_fork_list): Delete.
3818         (linux_fork_killall, linux_fork_mourn_inferior)
3819         (linux_fork_detach, info_checkpoints_command): Adjust.
3820         (_initialize_linux_fork): No longer call init_fork_list.
3821
3822 2019-03-06  Pedro Alves  <palves@redhat.com>
3823
3824         * linux-fork.c (new_fork): New, split out of ...
3825         (add_fork): ... this.  Return void.  Move "first fork" special
3826         case from here, to ...
3827         (checkpoint_command): ... here.
3828         * linux-linux.h (add_fork): Return void.
3829
3830 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3833
3834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3835             Chris January  <chris.january@arm.com>
3836             David Lecomber  <david.lecomber@arm.com>
3837
3838         * f-exp.y: New token, UNOP_INTRINSIC.
3839         (exp): New pattern using UNOP_INTRINSIC token.
3840         (f77_keywords): Add 'abs' keyword.
3841         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3842         (value_from_host_double): New function.
3843         (evaluate_subexp_f): Support UNOP_ABS.
3844
3845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3846
3847         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3848         types.
3849
3850 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3851
3852         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3853         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3854         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3855
3856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3857
3858         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3859
3860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3861             Chris January  <chris.january@arm.com>
3862
3863         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3864         * f-exp.y: Define 'KIND' token.
3865         (exp): New pattern for KIND expressions.
3866         (ptype): Handle types with a kind extension.
3867         (direct_abs_decl): Extend to spot kind extensions.
3868         (f77_keywords): Add 'kind' to the list.
3869         (push_kind_type): New function.
3870         (convert_to_kind_type): New function.
3871         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3872         * parse.c (operator_length_standard): Likewise.
3873         * parser-defs.h (enum type_pieces): Add tp_kind.
3874         * std-operator.def: Add UNOP_KIND.
3875
3876 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * f-exp.y (f_parse): Set yydebug.
3879
3880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * f-lang.c (evaluate_subexp_f): New function.
3883         (exp_descriptor_f): New global.
3884         (f_language_defn): Use exp_descriptor_f instead of
3885         exp_descriptor_standard.
3886
3887 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3888
3889         * f-exp.y (struct token): Add comments.
3890         (dot_ops): Remove uppercase versions and the end marker.
3891         (f77_keywords): Likewise.
3892         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3893         entries in the dot_ops array are case insensitive, and use
3894         strncasecmp to compare strings.  Also some whitespace cleanup in
3895         this area.  Similar for the f77_keywords array, except entries in
3896         this list might be case sensitive.
3897
3898 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * f-exp.y (struct f77_boolean_val): Add comments.
3901         (boolean_values): Remove uppercase versions, and end marker.
3902         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3903         and use strncasecmp to achieve case insensitivity.  Additionally,
3904         perform whitespace cleanup around this code.
3905
3906 2019-03-06  Tom Tromey  <tromey@adacore.com>
3907
3908         * remote-sim.c (gdbsim_target_open): Use result of
3909         gdb_argv::release.
3910
3911 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3912         Dirk Schubert  <dirk.schubert@arm.com>
3913         Chris January  <chris.january@arm.com>
3914
3915         * eval.c (evaluate_subexp_standard): Call Fortran argument
3916         wrapping logic.
3917         * f-lang.c (struct value): A value which can be passed into a
3918         Fortran function call.
3919         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3920         where appropriate.
3921         (struct type): Value ready for a Fortran function call.
3922         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3923         is needed.
3924         * f-lang.h (fortran_argument_convert): Declaration.
3925         (fortran_preserve_arg_pointer): Declaration.
3926         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3927
3928 2019-03-05  Tom Tromey  <tromey@adacore.com>
3929
3930         * python/py-prettyprint.c (print_string_repr): Remove #if.
3931         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3932
3933 2019-03-05  Tom Tromey  <tromey@adacore.com>
3934
3935         * target.c (the_dummy_target): Move later.  Change type to
3936         "dummy_target".
3937         (initialize_targets): Don't initialize the_dummy_target.
3938
3939 2019-03-05  Tom Tromey  <tromey@adacore.com>
3940
3941         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3942         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3943
3944 2019-03-05  Tom Tromey  <tromey@adacore.com>
3945
3946         * windows-nat.c (windows_nat_target::attach)
3947         (windows_nat_target::detach): Don't call gdb_flush.
3948         * valprint.c (generic_val_print, val_print, val_print_string):
3949         Don't call gdb_flush.
3950         * utils.c (defaulted_query): Don't call gdb_flush.
3951         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3952         * target.c (target_announce_detach): Don't call gdb_flush.
3953         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3954         * remote.c (extended_remote_target::attach): Don't call
3955         gdb_flush.
3956         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3957         * printcmd.c (do_examine): Don't call gdb_flush.
3958         (info_display_command): Don't call gdb_flush.
3959         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3960         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3961         * memattr.c (info_mem_command): Don't call gdb_flush.
3962         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3963         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3964         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3965         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3966         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3967         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3968         (gnu_nat_target::detach): Don't call gdb_flush.
3969         * f-valprint.c (f_val_print): Don't call gdb_flush.
3970         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3971         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3972         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3973         gdb_flush.
3974         * c-valprint.c (c_val_print): Don't call gdb_flush.
3975         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3976
3977 2019-03-05  Tom Tromey  <tromey@adacore.com>
3978
3979         * varobj.c (update_dynamic_varobj_children): Update.
3980         (install_default_visualizer): Use reset, not release.
3981         * value.c (set_internalvar): Update.
3982         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3983         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3984         ATTRIBUTE_UNUSED_RESULT.
3985
3986 2019-03-05  Tom Tromey  <tromey@adacore.com>
3987
3988         * remote.c (class scoped_remote_fd) <release>: Add
3989         ATTRIBUTE_UNUSED_RESULT.
3990
3991 2019-03-05  Tom Tromey  <tromey@adacore.com>
3992
3993         * macroexp.c (struct macro_buffer) <release>: Add
3994         ATTRIBUTE_UNUSED_RESULT.
3995
3996 2019-03-05  Tom Tromey  <tromey@adacore.com>
3997
3998         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3999         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4000         ATTRIBUTE_UNUSED_RESULT.
4001
4002 2019-03-05  Tom Tromey  <tromey@adacore.com>
4003
4004         * common/scoped_fd.h (class scoped_fd) <release>: Add
4005         ATTRIBUTE_UNUSED_RESULT.
4006
4007 2019-03-05  Tom Tromey  <tromey@adacore.com>
4008
4009         * parser-defs.h (struct parser_state) <release>: Add
4010         ATTRIBUTE_UNUSED_RESULT.
4011
4012 2019-03-05  Tom Tromey  <tromey@adacore.com>
4013
4014         * utils.h (class gdb_argv) <release>: Add
4015         ATTRIBUTE_UNUSED_RESULT.
4016         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4017
4018 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4019
4020         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4021         for-loop range, to avoid compiler warnings.
4022
4023         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4024         avoid compiler warnings about unused variables.
4025
4026         * NEWS: Mention end of support for native debugging on MS-Windows
4027         before XP.
4028
4029         PR gdb/24292
4030         * common/netstuff.c:
4031         * gdbserver/gdbreplay.c
4032         * gdbserver/remote-utils.c:
4033         * ser-tcp.c:
4034         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4035         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4036         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4037         'getaddrinfo' and 'freeaddrinfo' were not available before
4038         Windows XP, and mingw.org's MinGW headers by default define
4039         _WIN32_WINNT to 0x500.
4040
4041 2019-03-01  Gary Benson <gbenson@redhat.com>
4042
4043         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4044
4045 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4046             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4047
4048         PR gdb/8527
4049         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4050         set_sigint_trap, clear_sigint_trap.
4051
4052 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4053
4054         * target.c (target_detach): Clear the regcache and the
4055         frame cache.
4056
4057 2019-02-27  Pedro Alves  <palves@redhat.com>
4058
4059         * utils.c (set_screen_size): When we cap the height/width sizes,
4060         tweak the corresponding command variable to show "unlimited":
4061
4062 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4063             Pedro Alves  <palves@redhat.com>
4064
4065         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4066         before calling rl_set_screen_size.
4067
4068 2019-02-27  Tom Tromey  <tromey@adacore.com>
4069
4070         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4071         define.
4072         * python/py-value.c: Remove Python 2.4 workaround.
4073         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4074         workaround.
4075         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4076         Python 2.4 workaround.
4077         * python/python-internal.h: Remove Python 2.4 comment.
4078         (Py_ssize_t): Don't define.
4079         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4080         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4081         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4082         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4083         * python/python.c (do_start_initialization): Remove Python 2.4
4084         workaround.
4085         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4086         (print_children): Remove Python 2.4 workaround.
4087         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4088         workaround.
4089         (CHARBUFFERPROC_NAME): Remove.
4090         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4091         Python 2.4 workaround.
4092
4093 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4094
4095         * NEWS: Note minimum Python version.
4096
4097 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4098
4099         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4100         code from these functions.  Remove corresponding ifdefs.  Use
4101         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4102         Remove gotos and target of gotos.
4103         (infpy_search_memory): Likewise.
4104
4105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4108         (hppa_gdbarch_init): Don't register deleted functions with
4109         gdbarch.
4110
4111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4112
4113         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4114         (h8300_unwind_sp): Delete.
4115         (h8300_dummy_id): Delete.
4116         (h8300_gdbarch_init): Don't register deleted functions with
4117         gdbarch.
4118
4119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4122         (ft32_unwind_pc): Delete.
4123         (ft32_unwind_sp): Delete.
4124         (ft32_gdbarch_init): Don't register deleted functions with
4125         gdbarch.
4126
4127 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4128
4129         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4130         (frv_unwind_pc): Delete.
4131         (frv_unwind_sp): Delete.
4132         (frv_gdbarch_init): Don't register deleted functions with
4133         gdbarch.
4134
4135 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4136
4137         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4138         (riscv_unwind_pc): Delete.
4139         (riscv_unwind_sp): Delete.
4140         (riscv_gdbarch_init): Don't register deleted functions with
4141         gdbarch.
4142
4143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4144
4145         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4146         (csky_unwind_pc): Delete.
4147         (csky_unwind_sp): Delete.
4148         (csky_gdbarch_init): Don't register deleted functions with
4149         gdbarch.
4150
4151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4152
4153         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4154         (cris_unwind_pc): Delete.
4155         (cris_unwind_sp): Delete.
4156         (cris_gdbarch_init): Don't register deleted functions with
4157         gdbarch.
4158
4159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4160
4161         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4162         (bfin_unwind_pc): Delete.
4163         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4164
4165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4166
4167         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4168         (arm_unwind_pc): Delete.
4169         (arm_unwind_sp): Delete.
4170         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4171
4172 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4175         (arc_unwind_pc): Delete.
4176         (arc_unwind_sp): Delete.
4177         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4178
4179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4182         (alpha_unwind_pc): Delete.
4183         (alpha_gdbarch_init): Don't register deleted functions with
4184         gdbarch.
4185
4186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4187
4188         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4189         (aarch64_unwind_pc): Delete.
4190         (aarch64_unwind_sp): Delete.
4191         (aarch64_gdbarch_init): Don't register deleted functions with
4192         gdbarch.
4193
4194 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * gdbtypes.c (type_align): Don't consider static members when
4197         computing structure alignment.
4198
4199 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4202         return 0 for other types.
4203         * arch-utils.c (default_type_align): Always return 0.
4204         * gdbarch.h: Regenerate.
4205         * gdbarch.sh (type_align): Extend comment.
4206         * gdbtypes.c (type_align): Add additional comments, always call
4207         gdbarch_type_align before applying the default rules.
4208         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4209         generic code will then apply a suitable default.
4210         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4211         types, return 0 for other types.
4212
4213 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4214
4215         * NEWS: Create a new section for the next release branch.
4216         Rename the section of the current branch, now that it has
4217         been cut.
4218
4219 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4220
4221         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4222         * version.in: Bump version to 8.3.50.DATE-git.
4223
4224 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4225
4226         * aix-thread.c (ptid_cmp): Remove unused variable.
4227         (get_signaled_thread): Likewise.
4228         (store_regs_user_thread): Likewise.
4229         (store_regs_kernel_thread): Likewise.
4230         (fetch_regs_kernel_thread): Remove shadowed variable.
4231
4232 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * features/riscv/32bit-cpu.xml: Add register numbers.
4235         * features/riscv/32bit-fpu.c: Regenerate.
4236         * features/riscv/32bit-fpu.xml: Add register numbers.
4237         * features/riscv/64bit-cpu.xml: Add register numbers.
4238         * features/riscv/64bit-fpu.c: Regenerate.
4239         * features/riscv/64bit-fpu.xml: Add register numbers.
4240
4241 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4242
4243         * NEWS: Mention two argument form of gdb.Value constructor.
4244         * python/py-value.c (convert_buffer_and_type_to_value): New
4245         function.
4246         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4247         Add support for handling an optional second argument.  Call
4248         convert_buffer_and_type_to_value as appropriate.
4249         * python/python-internal.h (Py_buffer_deleter): New struct.
4250         (Py_buffer_up): New typedef.
4251
4252 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4253
4254         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4255         instead of releasing ownership.
4256
4257 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4258
4259         * dwarf2read.c (open_and_init_dwp_file): Call
4260         elf_numsections instead of bfd_count_sections to initialize
4261         dwp_file->num_sections.
4262
4263 2019-02-25  Tom Tromey  <tromey@adacore.com>
4264
4265         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4266
4267 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4268
4269         * gcore.in: Add '--readnever' option when invoking GDB.
4270
4271 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4272
4273         * MAINTAINERS: Update my email address.
4274
4275 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4276
4277         * build-id.c (build_id_to_debug_bfd_1): New function.
4278         (build_id_to_debug_bfd): Look for separate debug file in
4279         sysroot.
4280
4281 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4282
4283         * gdbarch.sh: Update the copyright year range that is placed into
4284         generated files.
4285
4286 2019-02-22  Keith Seitz  <keiths@redhat.com>
4287
4288         PR symtab/23853
4289         * linespec.c (create_sals_line_offset): Search for the default
4290         symtab's filename instead of its fullname.
4291
4292 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4293
4294         * NEWS: Update style defaults.
4295
4296 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4297
4298         * main.c (captured_main_1): Disable styling in batch mode.
4299
4300 2019-02-20  Tom Tromey  <tom@tromey.com>
4301
4302         * symtab.c (symtab_symbol_info): Fix typos.
4303
4304 2019-02-20  Tom Tromey  <tromey@adacore.com>
4305
4306         * findcmd.c (_initialize_mem_search): Use upper case for
4307         metasyntactic variables.
4308
4309 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4310
4311         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4312         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4313
4314 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4315
4316         * top.h (source_file_name): Change to std::string.
4317         * top.c (source_file_name): Likewise.
4318         (command_line_input): Adjust.
4319         * cli/cli-script.c (script_from_file): Adjust.
4320
4321 2019-02-19  Tom Tromey  <tromey@adacore.com>
4322
4323         * ravenscar-thread.c
4324         (ravenscar_thread_target::update_thread_list): Don't call
4325         ada_build_task_list.
4326         * ada-lang.h (ada_build_task_list): Don't declare.
4327         * ada-tasks.c (struct ada_tasks_inferior_data)
4328         <task_list_valid_p>: Now bool.
4329         (read_known_tasks, ada_task_list_changed)
4330         (ada_tasks_invalidate_inferior_data): Update.
4331         (read_known_tasks_array): Return bool.
4332         (read_known_tasks_list): Likewise.
4333         (read_known_tasks): Return void.
4334         (ada_build_task_list): Now static.
4335
4336 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4339         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4340
4341 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4342
4343         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4344         variant for ada_tasks_pspace_data_handle and
4345         ada_tasks_inferior_data_handle.
4346         (ada_tasks_pspace_data_cleanup): New function.
4347         (ada_tasks_inferior_data_cleanup): New function.
4348
4349 2019-02-17  Tom Tromey  <tom@tromey.com>
4350
4351         * macrotab.h (macro_source_fullname): Return a std::string.
4352         * macrotab.c (macro_include, check_for_redefinition)
4353         (macro_undef, macro_lookup_definition, foreach_macro)
4354         (foreach_macro_in_scope): Update.
4355         (macro_source_fullname): Return a std::string.
4356         * macrocmd.c (show_pp_source_pos): Update.
4357
4358 2019-02-17  Tom Tromey  <tom@tromey.com>
4359
4360         * macrocmd.c (show_pp_source_pos): Style the file names.
4361
4362 2019-02-17  Tom Tromey  <tom@tromey.com>
4363
4364         PR tui/24197:
4365         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4366
4367 2019-02-17  Tom Tromey  <tom@tromey.com>
4368
4369         * ada-lang.c (user_select_syms): Use filtered printing.
4370         * utils.c (wrap_style): New global.
4371         (desired_style): Remove.
4372         (emit_style_escape): Add stream parameter.
4373         (set_output_style, reset_terminal_style, prompt_for_continue):
4374         Update.
4375         (flush_wrap_buffer): Only flush gdb_stdout.
4376         (wrap_here): Set wrap_style.
4377         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4378         treat escape sequences as a character.  Change when wrap buffer is
4379         flushed.
4380         (fputs_styled): Do not set the output style when the default is
4381         requested.
4382         * ui-style.h (struct ui_file_style) <is_default>: New method.
4383         * source.c (print_source_lines_base): Emit escape sequences in one
4384         piece.
4385
4386 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4387
4388         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4389         integers and enumeration types.
4390
4391 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4392
4393         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4394         instead of lookup_symbol_in_language
4395         (do_exact_match): New function.
4396         (ada_get_symbol_name_matcher): Return do_exact_match when
4397         doing a verbatim match.
4398
4399 2019-02-15  Tom Tromey  <tromey@adacore.com>
4400
4401         * ravenscar-thread.c (ravenscar_thread_target::resume)
4402         (ravenscar_thread_target::wait): Special case wildcard requests.
4403
4404 2019-02-15  Tom Tromey  <tromey@adacore.com>
4405
4406         * ravenscar-thread.c (base_ptid): Remove.
4407         (struct ravenscar_thread_target) <close>: New method.
4408         <m_base_ptid>: New member.
4409         <update_inferior_ptid, active_task, task_is_currently_active,
4410         runtime_initialized>: Declare methods.
4411         <ravenscar_thread_target>: Add constructor.
4412         (ravenscar_thread_target::task_is_currently_active)
4413         (ravenscar_thread_target::update_inferior_ptid)
4414         (ravenscar_runtime_initialized): Rename.  Now methods.
4415         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4416         (ravenscar_thread_target::update_thread_list): Update.
4417         (ravenscar_thread_target::active_task): Now method.
4418         (ravenscar_thread_target::store_registers)
4419         (ravenscar_thread_target::prepare_to_store)
4420         (ravenscar_thread_target::prepare_to_store)
4421         (ravenscar_thread_target::mourn_inferior): Update.
4422         (ravenscar_inferior_created): Use "new" to create target.
4423         (ravenscar_thread_target::get_ada_task_ptid): Update.
4424         (_initialize_ravenscar): Don't initialize base_ptid.
4425         (ravenscar_ops): Remove global.
4426
4427 2019-02-15  Tom Tromey  <tromey@adacore.com>
4428
4429         * target.h (push_target): Declare new overload.
4430         * target.c (push_target): New overload, taking an rvalue reference.
4431         * remote.c (remote_target::open_1): Use push_target overload.
4432         * corelow.c (core_target_open): Use push_target overload.
4433
4434 2019-02-15  Tom Tromey  <tromey@adacore.com>
4435
4436         * ravenscar-thread.c (is_ravenscar_task)
4437         (ravenscar_task_is_currently_active): Return bool.
4438         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4439         (_initialize_ravenscar): Remove "(void)".
4440         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4441         Return bool.
4442
4443 2019-02-15  Tom Tromey  <tromey@adacore.com>
4444
4445         * ravenscar-thread.c (ravenscar_runtime_initializer)
4446         (has_ravenscar_runtime, get_running_thread_id)
4447         (ravenscar_thread_target::resume): Fix indentation.
4448
4449 2019-02-15  Tom Tromey  <tromey@adacore.com>
4450
4451         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4452         from ravenscar_arch_ops.
4453         (sparc_ravenscar_ops::fetch_registers)
4454         (sparc_ravenscar_ops::store_registers): Now methods.
4455         (sparc_ravenscar_prepare_to_store): Remove.
4456         (sparc_ravenscar_ops): Redefine.
4457         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4458         methods and destructor.  Remove members.
4459         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4460         (ravenscar_thread_target::store_registers)
4461         (ravenscar_thread_target::prepare_to_store): Update.
4462         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4463         Remove.
4464         (struct ppc_ravenscar_powerpc_ops): Derive from
4465         ravenscar_arch_ops.
4466         (ppc_ravenscar_powerpc_ops::fetch_registers)
4467         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4468         (ppc_ravenscar_powerpc_ops): Redefine.
4469         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4470         (ppc_ravenscar_e500_ops::fetch_registers)
4471         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4472         (ppc_ravenscar_e500_ops): Redefine.
4473         * aarch64-ravenscar-thread.c
4474         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4475         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4476         (aarch64_ravenscar_fetch_registers)
4477         (aarch64_ravenscar_store_registers): Now methods.
4478         (aarch64_ravenscar_ops): Redefine.
4479
4480 2019-02-15  Tom Tromey  <tromey@adacore.com>
4481
4482         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4483         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4484         (ravenscar_thread_target::stopped_by_watchpoint)
4485         (ravenscar_thread_target::stopped_data_address)
4486         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4487
4488 2019-02-15  Tom Tromey  <tromey@adacore.com>
4489
4490         * ravenscar-thread.c: Fix some typos.
4491
4492 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4493             Tom Tromey  <tromey@adacore.com>
4494
4495         * ada-lang.c (ada_exception_sal): Change addr_string to a
4496         std::string.
4497         (create_ada_exception_catchpoint): Update.
4498
4499 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4500             Tom Tromey  <tromey@adacore.com>
4501
4502         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4503         (bp_location_ops): Remove.
4504         (base_breakpoint_allocate_location): Update.
4505         (free_bp_location): Update.
4506         * ada-lang.c (class ada_catchpoint_location)
4507         <ada_catchpoint_location>: Remove ops parameter.
4508         (ada_catchpoint_location_dtor): Remove.
4509         (ada_catchpoint_location_ops): Remove.
4510         (allocate_location_exception): Update.
4511         * breakpoint.h (struct bp_location_ops): Remove.
4512         (class bp_location) <bp_location>: Remove bp_location_ops
4513         parameter.
4514         <~bp_location>: Add destructor.
4515         <ops>: Remove.
4516
4517 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4518             Pedro Alves  <palves@redhat.com>
4519
4520         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4521         'PATH_MAX'.
4522
4523 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4524             Samuel Thibault  <samuel.thibault@gnu.org>
4525             Thomas Schwinge  <thomas@codesourcery.com>
4526
4527         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4528         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4529
4530 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4531
4532         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4533         (check_empty): Use "const char *".
4534
4535         * gnu-nat.c (gnu_nat_target::detach): Instead of
4536         'detach_inferior (pid)' call
4537         'detach_inferior (find_inferior_pid (pid))'.
4538
4539         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4540         'nat/fork-inferior.o'.
4541         * gnu-nat.c: #include "nat/fork-inferior.h".
4542
4543         * gnu-nat.c (gnu_nat_target::detach): Instead of
4544         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4545         * gnu-nat.h: #include "inf-child.h".
4546         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4547         'i386_gnu_nat_target::fetch_registers'.
4548         (gnu_store_registers): Rename/move to
4549         'i386_gnu_nat_target::store_registers'.
4550
4551         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4552         * gnu-nat.h (mach_thread_info): New function.
4553         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4554
4555         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4556
4557 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4558
4559         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4560
4561 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4562
4563         * windows-nat.c (windows_add_thread): Add new parameter
4564         "main_thread_p" with default value set to false.  Update
4565         function documentation as well as all callers.
4566         (windows_delete_thread): Likewise.
4567         (fake_create_process): Update call to windows_add_thread.
4568         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4569         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4570         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4571         call to windows_delete_thread.
4572
4573 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4574
4575         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4576
4577 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4578
4579         * symfile.c (find_separate_debug_file): Use canonical path of
4580         sysroot with child_path instead of gdb_sysroot if it is valid.
4581
4582 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4583
4584         * symfile.c (find_separate_debug_file): Use child_path to
4585         determine if an object file is under a sysroot.
4586
4587 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4588
4589         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4590         unittests/child-path-selftests.c.
4591         * common/pathstuff.c (child_path): New function.
4592         * common/pathstuff.h (child_path): New prototype.
4593         * unittests/child-path-selftests.c: New file.
4594
4595 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4596
4597         * symfile.c (find_separate_debug_file): Look for separate debug
4598         files in debug directories under the sysroot.
4599
4600 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4601
4602         * symtab.h (struct minimal_symbol data_p): New const method.
4603         (struct minimal_symbol text_p): Likewise.
4604         * symtab.c (output_source_filename): Use file name style
4605         to print file name.
4606         (print_symbol_info): Likewise.
4607         (print_msymbol_info): Use address style to print addresses.
4608         Use function name style to print executable text symbols.
4609         (expand_symtab_containing_pc): Use data_p.
4610         (find_pc_sect_compunit_symtab): Likewise.
4611
4612 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4613
4614         * breakpoint.c (describe_other_breakpoints): Use address style
4615         to print addresses.
4616         (say_where): Likewise.
4617
4618 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4619
4620         * ada-typeprint.c (print_func_type): Print function name
4621         style to print function name.
4622         * c-typeprint.c (c_print_type_1): Likewise.
4623
4624 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4625
4626         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4627         for execve.
4628
4629 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4630
4631         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4632         type_stack.
4633
4634 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4635
4636         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4637         TYPE_CODE_REF types.
4638
4639 2019-02-08  Jim Wilson  <jimw@sifive.com>
4640
4641         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4642         (riscv_linux_fregset): New.
4643         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4644
4645 2019-02-07  Tom Tromey  <tom@tromey.com>
4646
4647         * thread.c (thread_cancel_execution_command): Update.
4648         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4649         methods.
4650         (struct thread_fsm_ops): Remove.
4651         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4652         (thread_fsm_should_stop, thread_fsm_return_value)
4653         (thread_fsm_set_finished, thread_fsm_finished_p)
4654         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4655         Don't declare.
4656         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4657         * infrun.c (clear_proceed_status_thread)
4658         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4659         (print_stop_event): Update.
4660         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4661         Add constructor.
4662         (step_command_fsm_ops): Remove.
4663         (new_step_command_fsm): Remove.
4664         (step_1): Update.
4665         (step_command_fsm::should_stop): Rename from
4666         step_command_fsm_should_stop.
4667         (step_command_fsm::clean_up): Rename from
4668         step_command_fsm_clean_up.
4669         (step_command_fsm::do_async_reply_reason): Rename from
4670         step_command_fsm_async_reply_reason.
4671         (struct until_next_fsm): Inherit from thread_fsm.  Add
4672         constructor.
4673         (until_next_fsm_ops): Remove.
4674         (new_until_next_fsm): Remove.
4675         (until_next_fsm::should_stop): Rename from
4676         until_next_fsm_should_stop.
4677         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4678         (until_next_fsm::do_async_reply_reason): Rename from
4679         until_next_fsm_async_reply_reason.
4680         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4681         constructor.  Change type of breakpoint.
4682         (finish_command_fsm_ops): Remove.
4683         (new_finish_command_fsm): Remove.
4684         (finish_command_fsm::should_stop): Rename from
4685         finish_command_fsm_should_stop.
4686         (finish_command_fsm::clean_up): Rename from
4687         finish_command_fsm_clean_up.
4688         (finish_command_fsm::return_value): Rename from
4689         finish_command_fsm_return_value.
4690         (finish_command_fsm::do_async_reply_reason): Rename from
4691         finish_command_fsm_async_reply_reason.
4692         (finish_command): Update.
4693         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4694         Add constructor.
4695         (call_thread_fsm_ops): Remove.
4696         (call_thread_fsm::call_thread_fsm): Rename from
4697         new_call_thread_fsm.
4698         (call_thread_fsm::should_stop): Rename from
4699         call_thread_fsm_should_stop.
4700         (call_thread_fsm::should_notify_stop): Rename from
4701         call_thread_fsm_should_notify_stop.
4702         (run_inferior_call, call_function_by_hand_dummy): Update.
4703         * cli/cli-interp.c (should_print_stop_to_console): Update.
4704         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4705         Add constructor.  Change type of location_breakpoint,
4706         caller_breakpoint.
4707         (until_break_fsm_ops): Remove.
4708         (new_until_break_fsm): Remove.
4709         (until_break_fsm::should_stop): Rename from
4710         until_break_fsm_should_stop.
4711         (until_break_fsm::clean_up): Rename from
4712         until_break_fsm_clean_up.
4713         (until_break_fsm::do_async_reply_reason): Rename from
4714         until_break_fsm_async_reply_reason.
4715         (until_break_command): Update.
4716         * thread-fsm.c: Remove.
4717         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4718
4719 2019-02-07  Tom Tromey  <tom@tromey.com>
4720
4721         * yy-remap.h: Add include guard.
4722         * xtensa-tdep.h: Add include guard.
4723         * xcoffread.h: Rename include guard.
4724         * varobj-iter.h: Add include guard.
4725         * tui/tui.h: Rename include guard.
4726         * tui/tui-winsource.h: Rename include guard.
4727         * tui/tui-wingeneral.h: Rename include guard.
4728         * tui/tui-windata.h: Rename include guard.
4729         * tui/tui-win.h: Rename include guard.
4730         * tui/tui-stack.h: Rename include guard.
4731         * tui/tui-source.h: Rename include guard.
4732         * tui/tui-regs.h: Rename include guard.
4733         * tui/tui-out.h: Rename include guard.
4734         * tui/tui-layout.h: Rename include guard.
4735         * tui/tui-io.h: Rename include guard.
4736         * tui/tui-hooks.h: Rename include guard.
4737         * tui/tui-file.h: Rename include guard.
4738         * tui/tui-disasm.h: Rename include guard.
4739         * tui/tui-data.h: Rename include guard.
4740         * tui/tui-command.h: Rename include guard.
4741         * tic6x-tdep.h: Add include guard.
4742         * target/waitstatus.h: Rename include guard.
4743         * target/wait.h: Rename include guard.
4744         * target/target.h: Rename include guard.
4745         * target/resume.h: Rename include guard.
4746         * target-float.h: Rename include guard.
4747         * stabsread.h: Add include guard.
4748         * rs6000-tdep.h: Add include guard.
4749         * riscv-fbsd-tdep.h: Add include guard.
4750         * regformats/regdef.h: Rename include guard.
4751         * record.h: Rename include guard.
4752         * python/python.h: Rename include guard.
4753         * python/python-internal.h: Rename include guard.
4754         * python/py-stopevent.h: Rename include guard.
4755         * python/py-ref.h: Rename include guard.
4756         * python/py-record.h: Rename include guard.
4757         * python/py-record-full.h: Rename include guard.
4758         * python/py-record-btrace.h: Rename include guard.
4759         * python/py-instruction.h: Rename include guard.
4760         * python/py-events.h: Rename include guard.
4761         * python/py-event.h: Rename include guard.
4762         * procfs.h: Add include guard.
4763         * proc-utils.h: Add include guard.
4764         * p-lang.h: Add include guard.
4765         * or1k-tdep.h: Rename include guard.
4766         * observable.h: Rename include guard.
4767         * nto-tdep.h: Rename include guard.
4768         * nat/x86-linux.h: Rename include guard.
4769         * nat/x86-linux-dregs.h: Rename include guard.
4770         * nat/x86-gcc-cpuid.h: Add include guard.
4771         * nat/x86-dregs.h: Rename include guard.
4772         * nat/x86-cpuid.h: Rename include guard.
4773         * nat/ppc-linux.h: Rename include guard.
4774         * nat/mips-linux-watch.h: Rename include guard.
4775         * nat/linux-waitpid.h: Rename include guard.
4776         * nat/linux-ptrace.h: Rename include guard.
4777         * nat/linux-procfs.h: Rename include guard.
4778         * nat/linux-osdata.h: Rename include guard.
4779         * nat/linux-nat.h: Rename include guard.
4780         * nat/linux-namespaces.h: Rename include guard.
4781         * nat/linux-btrace.h: Rename include guard.
4782         * nat/glibc_thread_db.h: Rename include guard.
4783         * nat/gdb_thread_db.h: Rename include guard.
4784         * nat/gdb_ptrace.h: Rename include guard.
4785         * nat/fork-inferior.h: Rename include guard.
4786         * nat/amd64-linux-siginfo.h: Rename include guard.
4787         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4788         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4789         * nat/aarch64-linux.h: Rename include guard.
4790         * nat/aarch64-linux-hw-point.h: Rename include guard.
4791         * mn10300-tdep.h: Add include guard.
4792         * mips-linux-tdep.h: Add include guard.
4793         * mi/mi-parse.h: Rename include guard.
4794         * mi/mi-out.h: Rename include guard.
4795         * mi/mi-main.h: Rename include guard.
4796         * mi/mi-interp.h: Rename include guard.
4797         * mi/mi-getopt.h: Rename include guard.
4798         * mi/mi-console.h: Rename include guard.
4799         * mi/mi-common.h: Rename include guard.
4800         * mi/mi-cmds.h: Rename include guard.
4801         * mi/mi-cmd-break.h: Rename include guard.
4802         * m2-lang.h: Add include guard.
4803         * location.h: Rename include guard.
4804         * linux-record.h: Rename include guard.
4805         * linux-nat.h: Add include guard.
4806         * linux-fork.h: Add include guard.
4807         * i386-darwin-tdep.h: Rename include guard.
4808         * hppa-linux-offsets.h: Add include guard.
4809         * guile/guile.h: Rename include guard.
4810         * guile/guile-internal.h: Rename include guard.
4811         * gnu-nat.h: Rename include guard.
4812         * gdb-stabs.h: Rename include guard.
4813         * frv-tdep.h: Add include guard.
4814         * f-lang.h: Add include guard.
4815         * event-loop.h: Add include guard.
4816         * darwin-nat.h: Rename include guard.
4817         * cp-abi.h: Rename include guard.
4818         * config/sparc/nm-sol2.h: Rename include guard.
4819         * config/nm-nto.h: Rename include guard.
4820         * config/nm-linux.h: Add include guard.
4821         * config/i386/nm-i386gnu.h: Rename include guard.
4822         * config/djgpp/nl_types.h: Rename include guard.
4823         * config/djgpp/langinfo.h: Rename include guard.
4824         * compile/gcc-cp-plugin.h: Add include guard.
4825         * compile/gcc-c-plugin.h: Add include guard.
4826         * compile/compile.h: Rename include guard.
4827         * compile/compile-object-run.h: Rename include guard.
4828         * compile/compile-object-load.h: Rename include guard.
4829         * compile/compile-internal.h: Rename include guard.
4830         * compile/compile-cplus.h: Rename include guard.
4831         * compile/compile-c.h: Rename include guard.
4832         * common/xml-utils.h: Rename include guard.
4833         * common/x86-xstate.h: Rename include guard.
4834         * common/version.h: Rename include guard.
4835         * common/vec.h: Rename include guard.
4836         * common/tdesc.h: Rename include guard.
4837         * common/selftest.h: Rename include guard.
4838         * common/scoped_restore.h: Rename include guard.
4839         * common/scoped_mmap.h: Rename include guard.
4840         * common/scoped_fd.h: Rename include guard.
4841         * common/safe-iterator.h: Rename include guard.
4842         * common/run-time-clock.h: Rename include guard.
4843         * common/refcounted-object.h: Rename include guard.
4844         * common/queue.h: Rename include guard.
4845         * common/ptid.h: Rename include guard.
4846         * common/print-utils.h: Rename include guard.
4847         * common/preprocessor.h: Rename include guard.
4848         * common/pathstuff.h: Rename include guard.
4849         * common/observable.h: Rename include guard.
4850         * common/netstuff.h: Rename include guard.
4851         * common/job-control.h: Rename include guard.
4852         * common/host-defs.h: Rename include guard.
4853         * common/gdb_wait.h: Rename include guard.
4854         * common/gdb_vecs.h: Rename include guard.
4855         * common/gdb_unlinker.h: Rename include guard.
4856         * common/gdb_unique_ptr.h: Rename include guard.
4857         * common/gdb_tilde_expand.h: Rename include guard.
4858         * common/gdb_sys_time.h: Rename include guard.
4859         * common/gdb_string_view.h: Rename include guard.
4860         * common/gdb_splay_tree.h: Rename include guard.
4861         * common/gdb_setjmp.h: Rename include guard.
4862         * common/gdb_ref_ptr.h: Rename include guard.
4863         * common/gdb_optional.h: Rename include guard.
4864         * common/gdb_locale.h: Rename include guard.
4865         * common/gdb_assert.h: Rename include guard.
4866         * common/filtered-iterator.h: Rename include guard.
4867         * common/filestuff.h: Rename include guard.
4868         * common/fileio.h: Rename include guard.
4869         * common/environ.h: Rename include guard.
4870         * common/common-utils.h: Rename include guard.
4871         * common/common-types.h: Rename include guard.
4872         * common/common-regcache.h: Rename include guard.
4873         * common/common-inferior.h: Rename include guard.
4874         * common/common-gdbthread.h: Rename include guard.
4875         * common/common-exceptions.h: Rename include guard.
4876         * common/common-defs.h: Rename include guard.
4877         * common/common-debug.h: Rename include guard.
4878         * common/cleanups.h: Rename include guard.
4879         * common/buffer.h: Rename include guard.
4880         * common/btrace-common.h: Rename include guard.
4881         * common/break-common.h: Rename include guard.
4882         * cli/cli-utils.h: Rename include guard.
4883         * cli/cli-style.h: Rename include guard.
4884         * cli/cli-setshow.h: Rename include guard.
4885         * cli/cli-script.h: Rename include guard.
4886         * cli/cli-interp.h: Rename include guard.
4887         * cli/cli-decode.h: Rename include guard.
4888         * cli/cli-cmds.h: Rename include guard.
4889         * charset-list.h: Add include guard.
4890         * buildsym-legacy.h: Rename include guard.
4891         * bfin-tdep.h: Add include guard.
4892         * ax.h: Rename include guard.
4893         * arm-linux-tdep.h: Add include guard.
4894         * arm-fbsd-tdep.h: Add include guard.
4895         * arch/xtensa.h: Rename include guard.
4896         * arch/tic6x.h: Add include guard.
4897         * arch/i386.h: Add include guard.
4898         * arch/arm.h: Rename include guard.
4899         * arch/arm-linux.h: Rename include guard.
4900         * arch/arm-get-next-pcs.h: Rename include guard.
4901         * arch/amd64.h: Add include guard.
4902         * arch/aarch64-insn.h: Rename include guard.
4903         * arch-utils.h: Rename include guard.
4904         * annotate.h: Add include guard.
4905         * amd64-darwin-tdep.h: Rename include guard.
4906         * aarch64-linux-tdep.h: Add include guard.
4907         * aarch64-fbsd-tdep.h: Add include guard.
4908         * aarch32-linux-nat.h: Add include guard.
4909
4910 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4911
4912         * macrotab.c (macro_define_internal): New function that
4913         factorizes macro_define_object_internal and macro_define_function
4914         code.
4915         (macro_define_object_internal): Use macro_define_internal.
4916         (macro_define_function): Likewise.
4917
4918 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4919
4920         * macrocmd.c (extract_identifier): Return
4921         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4922         callers.
4923
4924 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4925
4926         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4927
4928 2019-02-05  Tom Tromey  <tom@tromey.com>
4929
4930         * target.c (target_stack::unpush): Move assertion earlier.
4931
4932 2019-01-30  Tom Tromey  <tom@tromey.com>
4933
4934         PR python/23615:
4935         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4936         (gdbpy_parse_and_eval): Likewise.
4937         * python/python-internal.h (gdbpy_allow_threads): New class.
4938
4939 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4940
4941         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4942         (aarch64_fbsd_fpregmap): Move earlier.
4943         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4944         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4945         instead of individual calls to trad_frame_set_reg_addr.
4946         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4947         earlier.
4948         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4949         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4950         instead of individual calls to trad_frame_set_reg_addr.
4951
4952 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4953
4954         * CONTRIBUTE: Replace contribution list with wiki link.
4955
4956 2019-01-25  Tom Tromey  <tom@tromey.com>
4957
4958         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4959
4960 2019-01-25  Tom Tromey  <tom@tromey.com>
4961
4962         * xtensa-linux-nat.c: Fix common/ includes.
4963         * xml-support.h: Fix common/ includes.
4964         * xml-support.c: Fix common/ includes.
4965         * x86-linux-nat.c: Fix common/ includes.
4966         * windows-nat.c: Fix common/ includes.
4967         * varobj.h: Fix common/ includes.
4968         * varobj.c: Fix common/ includes.
4969         * value.c: Fix common/ includes.
4970         * valops.c: Fix common/ includes.
4971         * utils.c: Fix common/ includes.
4972         * unittests/xml-utils-selftests.c: Fix common/ includes.
4973         * unittests/utils-selftests.c: Fix common/ includes.
4974         * unittests/unpack-selftests.c: Fix common/ includes.
4975         * unittests/tracepoint-selftests.c: Fix common/ includes.
4976         * unittests/style-selftests.c: Fix common/ includes.
4977         * unittests/string_view-selftests.c: Fix common/ includes.
4978         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4979         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4980         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4981         * unittests/rsp-low-selftests.c: Fix common/ includes.
4982         * unittests/parse-connection-spec-selftests.c: Fix common/
4983         includes.
4984         * unittests/optional-selftests.c: Fix common/ includes.
4985         * unittests/offset-type-selftests.c: Fix common/ includes.
4986         * unittests/observable-selftests.c: Fix common/ includes.
4987         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4988         * unittests/memrange-selftests.c: Fix common/ includes.
4989         * unittests/memory-map-selftests.c: Fix common/ includes.
4990         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4991         * unittests/function-view-selftests.c: Fix common/ includes.
4992         * unittests/environ-selftests.c: Fix common/ includes.
4993         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4994         * unittests/common-utils-selftests.c: Fix common/ includes.
4995         * unittests/cli-utils-selftests.c: Fix common/ includes.
4996         * unittests/array-view-selftests.c: Fix common/ includes.
4997         * ui-file.c: Fix common/ includes.
4998         * tui/tui-io.c: Fix common/ includes.
4999         * tracepoint.h: Fix common/ includes.
5000         * tracepoint.c: Fix common/ includes.
5001         * tracefile-tfile.c: Fix common/ includes.
5002         * top.h: Fix common/ includes.
5003         * top.c: Fix common/ includes.
5004         * thread.c: Fix common/ includes.
5005         * target/waitstatus.h: Fix common/ includes.
5006         * target/waitstatus.c: Fix common/ includes.
5007         * target.h: Fix common/ includes.
5008         * target.c: Fix common/ includes.
5009         * target-memory.c: Fix common/ includes.
5010         * target-descriptions.c: Fix common/ includes.
5011         * symtab.h: Fix common/ includes.
5012         * symfile.c: Fix common/ includes.
5013         * stap-probe.c: Fix common/ includes.
5014         * spu-linux-nat.c: Fix common/ includes.
5015         * sparc-nat.c: Fix common/ includes.
5016         * source.c: Fix common/ includes.
5017         * solib.c: Fix common/ includes.
5018         * solib-target.c: Fix common/ includes.
5019         * ser-unix.c: Fix common/ includes.
5020         * ser-tcp.c: Fix common/ includes.
5021         * ser-pipe.c: Fix common/ includes.
5022         * ser-base.c: Fix common/ includes.
5023         * selftest-arch.c: Fix common/ includes.
5024         * s12z-tdep.c: Fix common/ includes.
5025         * rust-exp.y: Fix common/ includes.
5026         * rs6000-aix-tdep.c: Fix common/ includes.
5027         * riscv-tdep.c: Fix common/ includes.
5028         * remote.c: Fix common/ includes.
5029         * remote-notif.h: Fix common/ includes.
5030         * remote-fileio.h: Fix common/ includes.
5031         * remote-fileio.c: Fix common/ includes.
5032         * regcache.h: Fix common/ includes.
5033         * regcache.c: Fix common/ includes.
5034         * record-btrace.c: Fix common/ includes.
5035         * python/python.c: Fix common/ includes.
5036         * python/py-type.c: Fix common/ includes.
5037         * python/py-inferior.c: Fix common/ includes.
5038         * progspace.h: Fix common/ includes.
5039         * producer.c: Fix common/ includes.
5040         * procfs.c: Fix common/ includes.
5041         * proc-api.c: Fix common/ includes.
5042         * printcmd.c: Fix common/ includes.
5043         * ppc-linux-nat.c: Fix common/ includes.
5044         * parser-defs.h: Fix common/ includes.
5045         * osdata.c: Fix common/ includes.
5046         * obsd-nat.c: Fix common/ includes.
5047         * nat/x86-linux.c: Fix common/ includes.
5048         * nat/x86-linux-dregs.c: Fix common/ includes.
5049         * nat/x86-dregs.h: Fix common/ includes.
5050         * nat/x86-dregs.c: Fix common/ includes.
5051         * nat/ppc-linux.c: Fix common/ includes.
5052         * nat/mips-linux-watch.h: Fix common/ includes.
5053         * nat/mips-linux-watch.c: Fix common/ includes.
5054         * nat/linux-waitpid.c: Fix common/ includes.
5055         * nat/linux-ptrace.h: Fix common/ includes.
5056         * nat/linux-ptrace.c: Fix common/ includes.
5057         * nat/linux-procfs.c: Fix common/ includes.
5058         * nat/linux-personality.c: Fix common/ includes.
5059         * nat/linux-osdata.c: Fix common/ includes.
5060         * nat/linux-namespaces.c: Fix common/ includes.
5061         * nat/linux-btrace.h: Fix common/ includes.
5062         * nat/linux-btrace.c: Fix common/ includes.
5063         * nat/fork-inferior.c: Fix common/ includes.
5064         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5065         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5066         * nat/aarch64-linux.c: Fix common/ includes.
5067         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5068         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5069         * namespace.h: Fix common/ includes.
5070         * mips-linux-tdep.c: Fix common/ includes.
5071         * minsyms.c: Fix common/ includes.
5072         * mi/mi-parse.h: Fix common/ includes.
5073         * mi/mi-main.c: Fix common/ includes.
5074         * mi/mi-cmd-env.c: Fix common/ includes.
5075         * memrange.h: Fix common/ includes.
5076         * memattr.c: Fix common/ includes.
5077         * maint.h: Fix common/ includes.
5078         * maint.c: Fix common/ includes.
5079         * main.c: Fix common/ includes.
5080         * machoread.c: Fix common/ includes.
5081         * location.c: Fix common/ includes.
5082         * linux-thread-db.c: Fix common/ includes.
5083         * linux-nat.c: Fix common/ includes.
5084         * linux-fork.c: Fix common/ includes.
5085         * inline-frame.c: Fix common/ includes.
5086         * infrun.c: Fix common/ includes.
5087         * inflow.c: Fix common/ includes.
5088         * inferior.h: Fix common/ includes.
5089         * inferior.c: Fix common/ includes.
5090         * infcmd.c: Fix common/ includes.
5091         * inf-ptrace.c: Fix common/ includes.
5092         * inf-child.c: Fix common/ includes.
5093         * ia64-linux-nat.c: Fix common/ includes.
5094         * i387-tdep.c: Fix common/ includes.
5095         * i386-tdep.c: Fix common/ includes.
5096         * i386-linux-tdep.c: Fix common/ includes.
5097         * i386-linux-nat.c: Fix common/ includes.
5098         * i386-go32-tdep.c: Fix common/ includes.
5099         * i386-fbsd-tdep.c: Fix common/ includes.
5100         * i386-fbsd-nat.c: Fix common/ includes.
5101         * guile/scm-type.c: Fix common/ includes.
5102         * guile/guile.c: Fix common/ includes.
5103         * go32-nat.c: Fix common/ includes.
5104         * gnu-nat.c: Fix common/ includes.
5105         * gdbthread.h: Fix common/ includes.
5106         * gdbarch-selftests.c: Fix common/ includes.
5107         * gdb_usleep.c: Fix common/ includes.
5108         * gdb_select.h: Fix common/ includes.
5109         * gdb_bfd.c: Fix common/ includes.
5110         * gcore.c: Fix common/ includes.
5111         * fork-child.c: Fix common/ includes.
5112         * findvar.c: Fix common/ includes.
5113         * fbsd-nat.c: Fix common/ includes.
5114         * event-top.c: Fix common/ includes.
5115         * event-loop.c: Fix common/ includes.
5116         * dwarf2read.c: Fix common/ includes.
5117         * dwarf2loc.c: Fix common/ includes.
5118         * dwarf2-frame.c: Fix common/ includes.
5119         * dwarf-index-cache.c: Fix common/ includes.
5120         * dtrace-probe.c: Fix common/ includes.
5121         * disasm-selftests.c: Fix common/ includes.
5122         * defs.h: Fix common/ includes.
5123         * csky-tdep.c: Fix common/ includes.
5124         * cp-valprint.c: Fix common/ includes.
5125         * cp-support.h: Fix common/ includes.
5126         * cp-support.c: Fix common/ includes.
5127         * corelow.c: Fix common/ includes.
5128         * completer.h: Fix common/ includes.
5129         * completer.c: Fix common/ includes.
5130         * compile/compile.c: Fix common/ includes.
5131         * compile/compile-loc2c.c: Fix common/ includes.
5132         * compile/compile-cplus-types.c: Fix common/ includes.
5133         * compile/compile-cplus-symbols.c: Fix common/ includes.
5134         * command.h: Fix common/ includes.
5135         * cli/cli-dump.c: Fix common/ includes.
5136         * cli/cli-cmds.c: Fix common/ includes.
5137         * charset.c: Fix common/ includes.
5138         * build-id.c: Fix common/ includes.
5139         * btrace.h: Fix common/ includes.
5140         * btrace.c: Fix common/ includes.
5141         * breakpoint.h: Fix common/ includes.
5142         * breakpoint.c: Fix common/ includes.
5143         * ax.h:
5144         (enum agent_op): Fix common/ includes.
5145         * ax-general.c (struct aop_map): Fix common/ includes.
5146         * ax-gdb.c: Fix common/ includes.
5147         * auxv.c: Fix common/ includes.
5148         * auto-load.c: Fix common/ includes.
5149         * arm-tdep.c: Fix common/ includes.
5150         * arch/riscv.c: Fix common/ includes.
5151         * arch/ppc-linux-common.c: Fix common/ includes.
5152         * arch/i386.c: Fix common/ includes.
5153         * arch/arm.c: Fix common/ includes.
5154         * arch/arm-linux.c: Fix common/ includes.
5155         * arch/arm-get-next-pcs.c: Fix common/ includes.
5156         * arch/amd64.c: Fix common/ includes.
5157         * arch/aarch64.c: Fix common/ includes.
5158         * arch/aarch64-insn.c: Fix common/ includes.
5159         * arch-utils.c: Fix common/ includes.
5160         * amd64-windows-tdep.c: Fix common/ includes.
5161         * amd64-tdep.c: Fix common/ includes.
5162         * amd64-sol2-tdep.c: Fix common/ includes.
5163         * amd64-obsd-tdep.c: Fix common/ includes.
5164         * amd64-nbsd-tdep.c: Fix common/ includes.
5165         * amd64-linux-tdep.c: Fix common/ includes.
5166         * amd64-linux-nat.c: Fix common/ includes.
5167         * amd64-fbsd-tdep.c: Fix common/ includes.
5168         * amd64-fbsd-nat.c: Fix common/ includes.
5169         * amd64-dicos-tdep.c: Fix common/ includes.
5170         * amd64-darwin-tdep.c: Fix common/ includes.
5171         * agent.c: Fix common/ includes.
5172         * ada-lang.h: Fix common/ includes.
5173         * ada-lang.c: Fix common/ includes.
5174         * aarch64-tdep.c: Fix common/ includes.
5175
5176 2019-01-25  Tom Tromey  <tom@tromey.com>
5177
5178         * common/create-version.sh: Use common/version.h.
5179
5180 2019-01-24  Pedro Alves  <palves@redhat.com>
5181
5182         * infrun.c (signal_stop, signal_print, signal_program)
5183         (signal_catch, signal_pass): Now arrays instead of pointers.
5184         (update_signals_program_target, do_target_resume)
5185         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5186         * linux-nat.c (linux_nat_target::pass_signals)
5187         (linux_nat_target::create_inferior, linux_nat_target::attach):
5188         Adjust.
5189         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5190         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5191         * procfs.c (procfs_target::pass_signals): Adjust.
5192         * record-full.c (record_full_target::resume): Adjust.
5193         * remote.c (remote_target::pass_signals)
5194         (remote_target::program_signals): Adjust.
5195         * target-debug.h (target_debug_print_signals): Now takes a
5196         gdb::array_view as parameter.  Adjust.
5197         * target.h (target_ops) <pass_signals, program_signals>: Replace
5198         pointer and length parameters with gdb::array_view.
5199         (target_pass_signals, target_program_signals): Likewise.
5200         * target-delegates.c: Regenerate.
5201
5202 2019-01-24  Pedro Alves  <palves@redhat.com>
5203
5204         * common/forward-scope-exit.h
5205         (forward_scope_exit::forward_scope_exit): Pass arguments to
5206         m_bind_function directly, instead of creating a std::bind and
5207         copying that.
5208
5209 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5210
5211         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5212         for static members.
5213         (pass_in_v_vfp_candidate): Likewise.
5214
5215 2019-01-23  Tom Tromey  <tom@tromey.com>
5216             Pedro Alves  <palves@redhat.com>
5217
5218         * regcache.c (class regcache_invalidator): Remove.
5219         (regcache::raw_write): Use make_scope_exit.
5220
5221 2019-01-23  Tom Tromey  <tom@tromey.com>
5222
5223         * ui-out.h (class ui_out_emit_type): Update comment.
5224
5225 2019-01-23  Tom Tromey  <tom@tromey.com>
5226
5227         * infrun.c (fetch_inferior_event): Update comment.
5228
5229 2019-01-23  Tom Tromey  <tom@tromey.com>
5230             Pedro Alves  <palves@redhat.com>
5231
5232         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5233         parameter.
5234         (fetch_inferior_event): Use SCOPE_EXIT.
5235
5236
5237 2019-01-23  Tom Tromey  <tom@tromey.com>
5238             Pedro Alves  <palves@redhat.com>
5239
5240         * infrun.c (disable_thread_events): Delete.
5241         (stop_all_threads): Use SCOPE_EXIT.
5242
5243 2019-01-23  Tom Tromey  <tom@tromey.com>
5244             Pedro Alves  <palves@redhat.com>
5245
5246         * symfile.c: Include forward-scope-exit.h.
5247         (clear_symtab_users_cleanup): Replace forward declaration with
5248         a FORWARD_SCOPE_EXIT.
5249         (syms_from_objfile_1): Use the forward_scope_exit and
5250         gdb::optional instead of cleanup_function.
5251         (reread_symbols): Use the forward_scope_exit instead of
5252         cleanup_function.
5253         (clear_symtab_users_cleanup): Remove function.
5254
5255 2019-01-23  Tom Tromey  <tom@tromey.com>
5256             Pedro Alves  <palves@redhat.com>
5257
5258         * linux-nat.c: Include scope-exit.h.
5259         (cleanup_target_stop): Remove.
5260         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5261         SCOPE_EXIT.
5262
5263 2019-01-23  Tom Tromey  <tom@tromey.com>
5264             Pedro Alves  <palves@redhat.com>
5265
5266         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5267         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5268
5269 2019-01-23  Tom Tromey  <tom@tromey.com>
5270             Andrew Burgess  <andrew.burgess@embecosm.com>
5271             Pedro Alves  <palves@redhat.com>
5272
5273         * infrun.c (fetch_inferior_event): Use scope_exit.
5274         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5275         * top.c (execute_command): Use scope_exit.
5276         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5277         * utils.c (do_bpstat_clear_actions_cleanup)
5278         (make_bpstat_clear_actions_cleanup): Remove.
5279
5280 2019-01-23  Tom Tromey  <tom@tromey.com>
5281             Pedro Alves  <palves@redhat.com>
5282
5283         * infrun.c: Include "common/scope-exit.h"
5284         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5285         (wait_for_inferior): Use SCOPE_EXIT.
5286         (fetch_inferior_event): Use scope_exit.
5287
5288 2019-01-23  Tom Tromey  <tom@tromey.com>
5289             Pedro Alves  <palves@redhat.com>
5290
5291         * breakpoint.c (create_breakpoint): Remove cleanup.
5292
5293 2019-01-23  Tom Tromey  <tom@tromey.com>
5294             Andrew Burgess  <andrew.burgess@embecosm.com>
5295             Pedro Alves  <palves@redhat.com>
5296
5297 2019-01-23  Pedro Alves  <palves@redhat.com>
5298
5299         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5300
5301 2019-01-23  Pedro Alves  <palves@redhat.com>
5302             Andrew Burgess  <andrew.burgess@embecosm.com>
5303
5304         * gdbthread.h: Include "common/forward-scope-exit.h".
5305         (scoped_finish_thread_state): Redefine custom class in terms of
5306         forward_scope_exit.
5307
5308 2019-01-23  Pedro Alves  <palves@redhat.com>
5309             Andrew Burgess  <andrew.burgess@embecosm.com>
5310
5311         * common/forward-scope-exit.h: New file.
5312
5313 2019-01-23  Pedro Alves  <palves@redhat.com>
5314             Andrew Burgess  <andrew.burgess@embecosm.com>
5315             Tom Tromey  <tom@tromey.com>
5316
5317         * common/scope-exit.h: New file.
5318
5319 2019-01-23  Pedro Alves  <palves@redhat.com>
5320
5321         * common/preprocessor.h (ESC): Rename to ...
5322         (ESC_PARENS): ... this.
5323         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5324         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5325
5326 2019-01-23  Tom Tromey  <tom@tromey.com>
5327
5328         * language.h (class scoped_switch_to_sym_language_if_auto):
5329         Initialize m_lang in both cases.
5330
5331 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5332
5333         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5334         with XCNEW.
5335
5336 2019-01-22  Tom Tromey  <tom@tromey.com>
5337
5338         * corelow.c: Do not include sys/file.h.
5339
5340 2019-01-22  Tom Tromey  <tom@tromey.com>
5341
5342         * tui/tui-wingeneral.h: Include gdb_curses.h.
5343
5344 2019-01-22  Tom Tromey  <tom@tromey.com>
5345
5346         * source-cache.h (class source_cache) <get_source_lines,
5347         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5348
5349 2019-01-22  Tom Tromey  <tom@tromey.com>
5350
5351         * remote-fileio.h (struct remote_target): Declare.
5352
5353 2019-01-22  Tom Tromey  <tom@tromey.com>
5354
5355         * python/py-arch.c: Do not include py-ref.h.
5356         * python/py-bpevent.c: Do not include py-ref.h.
5357         * python/py-cmd.c: Do not include py-ref.h.
5358         * python/py-continueevent.c: Do not include py-ref.h.
5359         * python/py-event.h: Do not include py-ref.h.
5360         * python/py-evtregistry.c: Do not include py-ref.h.
5361         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5362         * python/py-frame.c: Do not include py-ref.h.
5363         * python/py-framefilter.c: Do not include py-ref.h.
5364         * python/py-function.c: Do not include py-ref.h.
5365         * python/py-infevents.c: Do not include py-ref.h.
5366         * python/py-linetable.c: Do not include py-ref.h.
5367         * python/py-objfile.c: Do not include py-ref.h.
5368         * python/py-param.c: Do not include py-ref.h.
5369         * python/py-prettyprint.c: Do not include py-ref.h.
5370         * python/py-progspace.c: Do not include py-ref.h.
5371         * python/py-symbol.c: Do not include py-ref.h.
5372         * python/py-symtab.c: Do not include py-ref.h.
5373         * python/py-type.c: Do not include py-ref.h.
5374         * python/py-unwind.c: Do not include py-ref.h.
5375         * python/py-utils.c: Do not include py-ref.h.
5376         * python/py-value.c: Do not include py-ref.h.
5377         * python/py-varobj.c: Do not include py-ref.h.
5378         * python/py-xmethods.c: Do not include py-ref.h.
5379         * python/python.c: Do not include py-ref.h.
5380         * varobj.c: Do not include py-ref.h.
5381
5382 2019-01-22  Tom Tromey  <tom@tromey.com>
5383
5384         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5385         keyword for bcache.
5386
5387 2019-01-22  Tom Tromey  <tom@tromey.com>
5388
5389         * compile/compile-cplus-types.c: Remove a comment by #include.
5390
5391 2019-01-22  Tom Tromey  <tom@tromey.com>
5392
5393         * compile/gcc-c-plugin.h: Include compile-internal.h.
5394
5395 2019-01-22  Tom Tromey  <tom@tromey.com>
5396
5397         * stabsread.c (EXTERN): Do not define.
5398         (symnum, next_symbol_text_func, processing_gcc_compilation)
5399         (within_function, global_sym_chain, global_stabs)
5400         (previous_stab_code, this_object_header_files)
5401         (n_this_object_header_files)
5402         (n_allocated_this_object_header_files): Define.
5403         * stabsread.h (EXTERN): Never define.  Use "extern".
5404
5405 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5406
5407         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5408         history_value.
5409
5410 2019-01-21  Tom Tromey  <tom@tromey.com>
5411
5412         * ui-out.c: Fix includes.
5413         * tui/tui-source.c: Fix includes.
5414         * target.c: Fix includes.
5415         * remote.c: Fix includes.
5416         * regcache.c: Fix includes.
5417         * python/py-block.c: Fix includes.
5418         * printcmd.c: Fix includes.
5419         * or1k-tdep.c: Fix includes.
5420         * mi/mi-main.c: Fix includes.
5421         * m32r-tdep.c: Fix includes.
5422         * csky-tdep.c: Fix includes.
5423         * compile/compile-cplus-types.c: Fix includes.
5424         * cli/cli-interp.c: Fix includes.
5425
5426 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5427
5428         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5429         for padding.
5430
5431 2019-01-16  Tom Tromey  <tom@tromey.com>
5432
5433         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5434         earlier.
5435         (struct objfile) <msymbols_range>: Move from top level.
5436         <msymbols>: New method.
5437         (class objfile_msymbols): Remove.
5438         * symtab.c (default_collect_symbol_completion_matches_break_on):
5439         Update.
5440         * symmisc.c (dump_msymbols): Update.
5441         * stabsread.c (scan_file_globals): Update.
5442         * objc-lang.c (info_selectors_command, info_classes_command)
5443         (find_methods): Update.
5444         * minsyms.c (find_solib_trampoline_target): Update.
5445         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5446         * coffread.c (coff_symfile_read): Update.
5447         * ada-lang.c (ada_lookup_simple_minsym)
5448         (ada_collect_symbol_completion_matches): Update.
5449
5450 2019-01-16  Tom Tromey  <tom@tromey.com>
5451
5452         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5453         type.  Remove no-argument constructor.
5454         <iterator::operator++>: Simplify.
5455         <begin>: Update.
5456         <end>: Use minimal_symbol_count.
5457
5458 2019-01-16  Tom Tromey  <tom@tromey.com>
5459
5460         * objfiles.h (struct objfile) <psymtabs>: New method.
5461         (class objfile_psymtabs): Remove.
5462         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5463         typedef.
5464         <range>: New method.
5465         (require_partial_symbols): Change return type.
5466         * psymtab.c (require_partial_symbols)
5467         (psym_expand_symtabs_matching): Update.
5468         * mdebugread.c (parse_partial_symbols): Update.
5469         * dbxread.c (dbx_end_psymtab): Update.
5470
5471 2019-01-15  Tom Tromey  <tom@tromey.com>
5472
5473         * symtab.c (lookup_objfile_from_block)
5474         (lookup_symbol_in_objfile_symtabs)
5475         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5476         (find_line_symtab, info_sources_command)
5477         (default_collect_symbol_completion_matches_break_on)
5478         (make_source_files_completion_list): Update.
5479         * symmisc.c (print_objfile_statistics, dump_objfile)
5480         (maintenance_print_symbols, maintenance_info_symtabs)
5481         (maintenance_check_symtabs, maintenance_info_line_tables):
5482         Update.
5483         * source.c (select_source_symtab)
5484         (forget_cached_source_info_for_objfile): Update.
5485         * objfiles.h (class objfile_compunits): Remove.
5486         (struct objfile) <compunits_range>: New typedef.
5487         (compunits): New method.
5488         * objfiles.c (objfile_relocate1): Update.
5489         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5490         * maint.c (count_symtabs_and_blocks): Update.
5491         * linespec.c (iterate_over_all_matching_symtabs): Update.
5492         * cp-support.c (add_symbol_overload_list_qualified): Update.
5493         * coffread.c (coff_symtab_read): Update.
5494         * ada-lang.c (add_nonlocal_symbols)
5495         (ada_collect_symbol_completion_matches)
5496         (ada_add_global_exceptions): Update.
5497
5498 2019-01-15  Tom Tromey  <tom@tromey.com>
5499
5500         * progspace.h (program_space) <objfiles_safe_range>: New
5501         typedef.
5502         <objfiles_safe>: New method.
5503         * objfiles.h (class all_objfiles_safe): Remove.
5504         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5505         * jit.c (jit_inferior_exit_hook): Update.
5506
5507 2019-01-17  Tom Tromey  <tom@tromey.com>
5508
5509         * progspace.h (program_space) <objfiles_range>: New typedef.
5510         <objfiles>: New method.
5511         <objfiles_head>: Rename from objfiles.
5512         (object_files): Update.
5513         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5514         * guile/scm-pretty-print.c
5515         (ppscm_find_pretty_printer_from_objfiles): Update.
5516         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5517         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5518         Update.
5519         * python/py-progspace.c (pspy_get_objfiles): Update.
5520         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5521         Update.
5522         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5523         (objfpy_lookup_objfile_by_build_id): Update.
5524         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5525         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5526         Update.
5527         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5528         (expand_symtab_containing_pc, lookup_objfile_from_block)
5529         (lookup_static_symbol, basic_lookup_transparent_type)
5530         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5531         (find_line_symtab, info_sources_command)
5532         (default_collect_symbol_completion_matches_break_on)
5533         (make_source_files_completion_list, find_main_name): Update.
5534         * symmisc.c (print_symbol_bcache_statistics)
5535         (print_objfile_statistics, maintenance_print_symbols)
5536         (maintenance_print_msymbols, maintenance_print_objfiles)
5537         (maintenance_info_symtabs, maintenance_check_symtabs)
5538         (maintenance_expand_symtabs, maintenance_info_line_tables):
5539         Update.
5540         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5541         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5542         (map_overlay_command, unmap_overlay_command)
5543         (simple_overlay_update, expand_symtabs_matching)
5544         (map_symbol_filenames): Update.
5545         * symfile-debug.c (set_debug_symfile): Update.
5546         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5547         Update.
5548         * source.c (select_source_symtab, forget_cached_source_info):
5549         Update.
5550         * solib.c (solib_read_symbols): Update.
5551         * solib-spu.c (append_ocl_sos): Update.
5552         * psymtab.c (maintenance_print_psymbols)
5553         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5554         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5555         * printcmd.c (info_symbol_command): Update.
5556         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5557         Update.
5558         * objfiles.h (class all_objfiles): Remove.
5559         * objfiles.c (have_partial_symbols, have_full_symbols)
5560         (have_minimal_symbols, qsort_cmp, update_section_map)
5561         (shared_objfile_contains_address_p)
5562         (default_iterate_over_objfiles_in_search_order): Update.
5563         * objc-lang.c (info_selectors_command, info_classes_command)
5564         (find_methods): Update.
5565         * minsyms.c (find_solib_trampoline_target): Update.
5566         * maint.c (maintenance_info_sections)
5567         (maintenance_translate_address, count_symtabs_and_blocks):
5568         Update.
5569         * main.c (captured_main_1): Update.
5570         * linux-thread-db.c (try_thread_db_load_from_pdir)
5571         (has_libpthread): Update.
5572         * linespec.c (iterate_over_all_matching_symtabs)
5573         (search_minsyms_for_name): Update.
5574         * jit.c (jit_find_objf_with_entry_addr): Update.
5575         * hppa-tdep.c (find_unwind_entry)
5576         (hppa_lookup_stub_minimal_symbol): Update.
5577         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5578         Update.
5579         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5580         (elf_gnu_ifunc_resolve_by_got): Update.
5581         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5582         * dwarf-index-write.c (save_gdb_index_command): Update.
5583         * cp-support.c (add_symbol_overload_list_qualified): Update.
5584         * breakpoint.c (create_overlay_event_breakpoint)
5585         (create_longjmp_master_breakpoint)
5586         (create_std_terminate_master_breakpoint)
5587         (create_exception_master_breakpoint): Update.
5588         * blockframe.c (find_pc_partial_function): Update.
5589         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5590         (ada_collect_symbol_completion_matches)
5591         (ada_add_global_exceptions): Update.
5592
5593 2019-01-17  Tom Tromey  <tom@tromey.com>
5594
5595         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5596         declare VEC.
5597         (solib_target_parse_libraries): Change return type.
5598         (library_list_start_segment, library_list_start_section)
5599         (library_list_end_library, library_list_start_library); Update.
5600         (solib_target_free_library_list): Remove.
5601         (solib_target_parse_libraries): Remove cleanup.  Change return
5602         type.
5603         (solib_target_current_sos): Update.
5604
5605 2019-01-17  Tom Tromey  <tromey@bapiya>
5606
5607         * valprint.c: Replace "the the" with "the".
5608         * symtab.c: Replace "the the" with "the".
5609         * solib.c: Replace "the the" with "the".
5610         * solib-dsbt.c: Replace "the the" with "the".
5611         * linespec.c: Replace "the the" with "the".
5612         * dwarf2loc.h: Replace "the the" with "the".
5613         * amd64-windows-tdep.c: Replace "the the" with "the".
5614         * aarch64-tdep.c: Replace "the the" with "the".
5615
5616 2019-01-16  Keith Seitz  <keiths@redhat.com>
5617
5618         PR gdb/23773
5619         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5620         <builder>: Rename to ..
5621         <m_builder>: ... this and make private.
5622         (dwarf2_cu::get_builder): New method.  Change all users of
5623         `builder' to use this method.
5624         (dwarf2_start_symtab): Move to ...
5625         (dwarf2_cu::start_symtab): ... here.  Update all callers
5626         (setup_type_unit_groups): Move to ...
5627         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5628         callers.
5629         (dwarf2_cu::reset_builder): New method.
5630         (process_full_compunit, process_full_type_unit): Use
5631         dwarf2_cu::reset_builder.
5632         (follow_die_offset): Record the ancestor CU if it is different
5633         from the followed DIE's CU.
5634         (follow_die_sig_1): Likewise.
5635
5636 2019-01-15  Tom Tromey  <tom@tromey.com>
5637
5638         * remote.c (class remote_state) <buf>: Now a char_vector.
5639         <buf_size>: Remove.
5640         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5641         parameter.
5642         (remote_target::getpkt_or_notif_sane_1)
5643         (remote_target::getpkt_sane)
5644         (remote_target::getpkt_or_notif_sane): Likewise.
5645         (class remote_target) <putpkt>: New overload.
5646         (remote_target::read_frame): Change type of "buf_p".  Remove
5647         sizeof_p parameter.
5648         (packet_ok): New overload.
5649         (packet_check_result): New overload.
5650         Update all uses.
5651
5652 2019-01-14  Tom Tromey  <tom@tromey.com>
5653
5654         * remote-notif.c (handle_notification, remote_notif_ack)
5655         (remote_notif_parse): Make "buf" const.
5656         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5657         const.
5658         (remote_notif_parse, remote_notif_ack, handle_notification):
5659         Likewise.
5660         * remote.c (remote_notif_stop_parse): Make "buf" const.
5661         (remote_target::remote_parse_stop_reply): Make "buf" const.
5662         (remote_notif_stop_ack): Make "buf" const.
5663
5664 2019-01-14  Tom Tromey  <tom@tromey.com>
5665
5666         * remote.c (remote_console_output): Make parameter const.
5667
5668 2019-01-14  Tom Tromey  <tom@tromey.com>
5669
5670         * target-debug.h (target_debug_print_signals): Constify.
5671         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5672         * procfs.c (procfs_target::pass_signals): Update.
5673         * linux-nat.c (linux_nat_target::pass_signals): Update.
5674         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5675         * target-delegates.c: Rebuild.
5676         * remote.c (remote_target::program_signals): Update.
5677         (remote_target::pass_signals): Update.
5678         * target.c (target_pass_signals): Constify argument.
5679         (target_program_signals): Likewise.
5680         * target.h (struct target_ops) <pass_signals, program_signals>:
5681         Constify argument.
5682         (target_pass_signals, target_program_signals): Constify argument.
5683
5684 2019-01-14  Tom Tromey  <tom@tromey.com>
5685
5686         PR tui/28819:
5687         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5688
5689 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5690
5691         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5692         field.
5693         * rs6000-tdep.c: Include reggroups.h.
5694         (IS_V_ALIAS_PSEUDOREG): Define.
5695         (rs6000_register_name): Return names for the "vX" aliases.
5696         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5697         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5698         aliases.  Call default_register_reggroup_p for all other
5699         pseudo-registers.
5700         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5701         New functions.
5702         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5703         Handle "vX" aliases.
5704         (v_alias_pseudo_register_collect): New function.
5705         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5706         (rs6000_gdbarch_init): Initialize "vX" aliases as
5707         pseudo-registers.  Restore registration of
5708         rs6000_pseudo_register_reggroup_p with
5709         set_tdesc_pseudo_register_reggroup_p.
5710
5711 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5712
5713         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5714         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5715         set_gdbarch_num_pseudo_regs.
5716
5717 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5718
5719         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5720         Remove arg prefixname, add do_set and do_show.
5721         Add member functions set_list and show_list.
5722         * cli/cli-style.c (class cli_style_option): Update accordingly.
5723         (style_set_list): Move to file scope.
5724         (style_show_list): Likewise.
5725         (set_style): Call help_list.
5726         (show_style): Call cmd_show_list.
5727         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5728         Update to use the new macro.
5729
5730 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5731
5732         * ada-lang.c (_initialize_ada_language): Expand the help text
5733         for the "catch exception" command.
5734
5735 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5736
5737         * symtab.c (matching_obj_sections): Initialize obj,
5738         declare it closer to its usage.
5739
5740 2019-01-10  Tom Tromey  <tom@tromey.com>
5741
5742         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5743         (basic_inf_threads_range): Remove.
5744         (inf_threads_range, inf_non_exited_threads_range)
5745         (safe_inf_threads_range): Use next_adapter.
5746
5747 2019-01-10  Keith Seitz  <keiths@redhat.com>
5748
5749         PR gdb/23712
5750         PR symtab/23010
5751         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5752         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5753
5754 2019-01-10  Keith Seitz  <keiths@redhat.com>
5755
5756         PR gdb/23712
5757         PR symtab/23010
5758         * dictionary.c (pending_to_vector): Remove.
5759         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5760         Remove _1 suffix, replacing functions of the same name.  Update
5761         all callers.
5762         (dict_create_hashed, dict_create_hashed_expandable)
5763         (dict_create_linear, dict_create_linear_expandable, dict_free)
5764         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5765         Make functions static.
5766
5767 2019-01-10  Keith Seitz  <keiths@redhat.com>
5768
5769         PR gdb/23712
5770         PR symtab/23010
5771         * dictionary.h (struct dictionary): Replace declaration with
5772         multidictionary.
5773         (dict_create_hashed, dict_create_hashed_expandable)
5774         (dict_create_linear, dict_create_linear_expandable)
5775         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5776         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5777         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5778         taking multidictionary argument.
5779         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5780         * block.h (struct block) <dict>: Change to multidictionary
5781         and rename `multidict'.
5782         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5783         symmisc.c: Update all dictionary references to multidictionary.
5784
5785 2019-01-10  Keith Seitz  <keiths@redhat.com>
5786
5787         PR gdb/23712
5788         PR symtab/23010
5789         * dictionary.c: Include unordered_map.
5790         (pending_to_vector): New function.
5791         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5792         Rewrite the non-"_1" functions to take vector instead
5793         of linked list.
5794         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5795         "new" _1 versions of the same name.
5796         (multidictionary): Define.
5797         (std::hash<enum language): New definition.
5798         (collate_pending_symbols_by_language, mdict_create_hashed)
5799         (mdict_create_hashed_expandable, mdict_create_linear)
5800         (mdict_create_linear_expandable, mdict_free)
5801         (find_language_dictionary, create_new_language_dictionary)
5802         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5803         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5804         (mdict_size, mdict_empty): New functions.
5805         * dictionary.h (mdict_iterator): Define.
5806
5807 2019-01-10  Pedro Alves  <palves@redhat.com>
5808
5809         * breakpoint.c (read_uploaded_action)
5810         (create_tracepoint_from_upload): Adjust to use
5811         gdb::unique_xmalloc_ptr.
5812         * ctf.c (ctf_write_uploaded_tp):
5813         (SET_ARRAY_FIELD): Use emplace_back.
5814         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5815         * tracefile-tfile.c (tfile_write_uploaded_tp):
5816         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5817         gdb::unique_xmalloc_ptr.
5818         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5819         at_string, cond_string, cmd_strings>: Replace char pointers
5820         with gdb::unique_xmalloc_ptr.
5821
5822 2019-01-10  Pedro Alves  <palves@redhat.com>
5823
5824         * solib-target.c (library_list_start_library): Don't xstrdup name.
5825
5826 2019-01-10  Pedro Alves  <palves@redhat.com>
5827
5828         * mdebugread.c (parse_partial_symbols): Use
5829         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5830
5831 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5832
5833         * linux-fork.c (scoped_switch_fork_info)
5834         <~scoped_switch_fork_info>: Fix incorrect variable name.
5835
5836 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5837
5838         * linux-fork.c (scoped_switch_fork_info)
5839         <scoped_switch_fork_info>: Make explicit.
5840         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5841
5842 2019-01-10  Tom Tromey  <tom@tromey.com>
5843
5844         * objfiles.h (objfile::reset_psymtabs): Update.
5845         * objfiles.c (objfile::objfile): Update.
5846         * psymtab.h (psymtab_storage::obstack): Update.
5847         (psymtab_storage::m_obstack): Use gdb::optional.
5848         (class psymtab_storage): Update comment.  Remove objfile
5849         parameter.
5850         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5851
5852 2019-01-10  Tom Tromey  <tom@tromey.com>
5853
5854         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5855         <free_psymtabs>: Now private.
5856         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5857         (allocate_psymtab): Use new method.
5858
5859 2019-01-10  Tom Tromey  <tom@tromey.com>
5860
5861         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5862         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5863         * mdebugread.c (parse_partial_symbols): Use
5864         allocate_dependencies.
5865         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5866         allocate_dependencies.
5867         (process_psymtab_comp_unit_reader)
5868         (build_type_psymtab_dependencies): Likewise.
5869         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5870
5871 2019-01-10  Tom Tromey  <tom@tromey.com>
5872
5873         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5874         PSYMBOL_SET_LANGUAGE.
5875         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5876
5877 2019-01-10  Tom Tromey  <tom@tromey.com>
5878
5879         * psymtab.h (psymtab_storage::obstack): New method.
5880         <m_obstack>: Rename from obstack; now private.
5881         * psymtab.c (psymtab_storage): Update.
5882         * dwarf2read.c (create_addrmap_from_index)
5883         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5884         Update.
5885
5886 2019-01-10  Tom Tromey  <tom@tromey.com>
5887
5888         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5889         * objfiles.h (objfile::reset_psymtabs): New method.
5890
5891 2019-01-10  Tom Tromey  <tom@tromey.com>
5892
5893         * symmisc.c (print_symbol_bcache_statistics): Update.
5894         (print_objfile_statistics): Update.
5895         * symfile.c (reread_symbols): Update.
5896         * psymtab.h (class psymtab_storage): New.
5897         * psymtab.c (psymtab_storage): New constructor.
5898         (~psymtab_storage): New destructor.
5899         (require_partial_symbols): Update.
5900         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5901         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5902         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5903         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5904         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5905         (start_psymtab_common, end_psymtab_common)
5906         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5907         (allocate_psymtab): Update.
5908         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5909         Update.
5910         (dump_psymtab_addrmap, maintenance_print_psymbols)
5911         (maintenance_check_psymtabs): Update.
5912         (class objfile_psymtabs): Move to objfiles.h.
5913         * psympriv.h (discard_psymtab): Now inline.
5914         (psymtab_discarder::psymtab_discarder): Update.
5915         (psymtab_discarder::~psymtab_discarder): Update.
5916         (ALL_OBJFILE_PSYMTABS): Rewrite.
5917         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5918         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5919         Remove fields.
5920         <partial_symtabs>: New field.
5921         (class objfile_psymtabs): Move from psymtab.h.  Update.
5922         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5923         psymbol_cache.
5924         (objfile::~objfile): Don't destroy psymbol_cache.
5925         * mdebugread.c (parse_partial_symbols): Update.
5926         * dwarf2read.c (create_addrmap_from_index)
5927         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5928         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5929         (add_partial_subprogram, dwarf2_ranges_read): Update.
5930         * dwarf-index-write.c (write_address_map)
5931         (write_one_signatured_type, recursively_write_psymbols)
5932         (class debug_names, class debug_names, write_psymtabs_to_index):
5933         Update.
5934
5935 2019-01-10  Tom Tromey  <tom@tromey.com>
5936
5937         * symtab.h (SYMBOL_SET_NAMES): Update.
5938         (symbol_set_names): Update.
5939         (MSYMBOL_SET_NAMES): Update.
5940         * symtab.c (symbol_set_names): Change argument to be an
5941         objfile_per_bfd_storage.
5942         * psymtab.c (add_psymbol_to_bcache): Update.
5943         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5944
5945 2019-01-10  Tom Tromey  <tom@tromey.com>
5946
5947         * symtab.c (create_demangled_names_hash): Change argument to be an
5948         objfile_per_bfd_storage.
5949         (symbol_set_names): Update.
5950
5951 2019-01-10  Tom Tromey  <tom@tromey.com>
5952
5953         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5954         init_psymbol_list.
5955         * psymtab.c (init_psymbol_list): Do nothing if already called.
5956         * psympriv.h (init_psymbol_list): Add comment.
5957         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5958         init_psymbol_list.
5959         * dbxread.c (dbx_symfile_read): Unconditionally call
5960         init_psymbol_list.
5961
5962 2019-01-10  Tom Tromey  <tom@tromey.com>
5963
5964         * xcoffread.c (scan_xcoff_symtab): Update.
5965         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5966         "where".
5967         * mdebugread.c (parse_partial_symbols)
5968         (handle_psymbol_enumerators): Update.
5969         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5970         * dbxread.c (read_dbx_symtab): Update.
5971         * psympriv.h (psymbol_placement): New enum.
5972         (add_psymbol_to_list): Update.
5973
5974 2019-01-10  Tom Tromey  <tom@tromey.com>
5975
5976         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5977         static_psymbols parameters.
5978         (scan_xcoff_symtab): Update.
5979         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5980         static_psymbols parameters.
5981         * psympriv.h (start_psymtab_common): Update.
5982         * mdebugread.c (parse_partial_symbols): Update.
5983         * dwarf2read.c (create_partial_symtab): Update.
5984         * dbxread.c (read_dbx_symtab): Update.
5985         (start_psymtab): Remove global_psymbols and static_psymbols
5986         parameters.
5987
5988 2019-01-10  Tom Tromey  <tom@tromey.com>
5989
5990         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5991         * psymtab.c (allocate_psymtab): Add comment.
5992         * psympriv.h (allocate_psymtab): Add comment.
5993         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5994         initializations.
5995         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5996
5997 2019-01-10  Tom Tromey  <tom@tromey.com>
5998
5999         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6000         Don't declare.
6001         * mipsread.c: Include mdebugread.h.
6002         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6003         Declare.
6004         * elfread.c: Include mdebugread.h.
6005
6006 2019-01-09  Tom Tromey  <tom@tromey.com>
6007
6008         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6009         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6010         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6011         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6012         (psym_lookup_symbol, psym_find_last_source_symtab)
6013         (psym_forget_cached_source_info, psym_print_stats)
6014         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6015         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6016         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6017         (psym_find_compunit_symtab_by_address)
6018         (maintenance_print_psymbols, maintenance_info_psymtabs)
6019         (maintenance_check_psymtabs): Use ranged for.
6020         * psymtab.h (class objfile_psymtabs): New.
6021         (require_partial_symbols): Return objfile_psymtabs.
6022         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6023
6024 2019-01-09  Tom Tromey  <tom@tromey.com>
6025
6026         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6027         (find_pc_mapped_section, list_overlays_command)
6028         (map_overlay_command, unmap_overlay_command)
6029         (simple_overlay_update): Use all_objfiles.
6030         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6031         * printcmd.c (info_symbol_command): Use all_objfiles.
6032         * objfiles.h (ALL_OBJSECTIONS): Remove.
6033         * maint.c (maintenance_translate_address): Use all_objfiles.
6034         * gcore.c (gcore_create_callback): Use all_objfiles.
6035         (objfile_find_memory_regions): Likewise.
6036
6037 2019-01-09  Tom Tromey  <tom@tromey.com>
6038
6039         * symtab.c (find_line_symtab, info_sources_command)
6040         (make_source_files_completion_list): Use objfile_compunits.
6041         * source.c (select_source_symtab): Use objfile_compunits.
6042         * objfiles.h (struct objfile): Update comment.
6043         (ALL_OBJFILES): Remove.
6044         (ALL_FILETABS): Remove.
6045         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6046         objfile_compunits.
6047
6048 2019-01-09  Tom Tromey  <tom@tromey.com>
6049
6050         * symmisc.c (print_objfile_statistics, dump_objfile)
6051         (maintenance_print_symbols): Use compunit_filetabs.
6052         * source.c (forget_cached_source_info_for_objfile): Use
6053         compunit_filetabs.
6054         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6055         (ALL_FILETABS): Use compunit_filetabs.
6056         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6057         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6058
6059 2019-01-09  Tom Tromey  <tom@tromey.com>
6060
6061         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6062         (compunit_filetabs): New.
6063         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6064         compunit_filetabs.
6065         (info_sources_command, make_source_files_completion_list): Remove
6066         declaration.
6067         * symmisc.c (print_objfile_statistics, dump_objfile)
6068         (maintenance_print_symbols): Remove declaration.
6069         (maintenance_info_symtabs): Use compunit_filetabs.
6070         (maintenance_info_line_tables): Likewise.
6071         * source.c (select_source_symtab): Change local variable name.
6072         (forget_cached_source_info_for_objfile): Remove declaration.
6073         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6074         * objfiles.c (objfile_relocate1): Remove declaration.
6075         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6076         declaration.
6077         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6078         * coffread.c (coff_symtab_read): Remove declaration.
6079         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6080         compunit_filetabs.
6081
6082 2019-01-09  Tom Tromey  <tom@tromey.com>
6083
6084         * symtab.c (lookup_objfile_from_block)
6085         (find_pc_sect_compunit_symtab, search_symbols)
6086         (default_collect_symbol_completion_matches_break_on): Use
6087         objfile_compunits.
6088         * objfiles.h (ALL_COMPUNITS): Remove.
6089         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6090         * cp-support.c (add_symbol_overload_list_qualified): Use
6091         objfile_compunits.
6092         * ada-lang.c (ada_collect_symbol_completion_matches)
6093         (ada_add_global_exceptions): Use objfile_compunits.
6094
6095 2019-01-09  Tom Tromey  <tom@tromey.com>
6096
6097         * source.c (select_source_symtab)
6098         (forget_cached_source_info_for_objfile): Remove declaration.
6099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6100         declaration.
6101         * maint.c (count_symtabs_and_blocks): Remove declaration.
6102         * cp-support.c (add_symbol_overload_list_qualified): Remove
6103         declaration.
6104         * coffread.c (coff_symtab_read): Remove declaration.
6105         * symtab.c (lookup_symbol_in_objfile_symtabs)
6106         (basic_lookup_transparent_type_1): Use objfile_compunits.
6107         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6108         (info_sources_command, search_symbols)
6109         (default_collect_symbol_completion_matches_break_on)
6110         (make_source_files_completion_list): Remove declaration.
6111         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6112         (ada_collect_symbol_completion_matches)
6113         (ada_add_global_exceptions): Remove declaration.
6114         * linespec.c (iterate_over_all_matching_symtabs): Use
6115         objfile_compunits.
6116         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6117         (class objfile_compunits): New.
6118         (ALL_COMPUNITS): Use objfile_compunits.
6119         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6120         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6121         objfile_compunits.
6122         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6123
6124 2019-01-09  Tom Tromey  <tom@tromey.com>
6125
6126         * symtab.c (search_symbols)
6127         (default_collect_symbol_completion_matches_break_on): Use
6128         objfile_msymbols.
6129         * ada-lang.c (ada_lookup_simple_minsym)
6130         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6131         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6132         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6133         objfile_msymbols.
6134         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6135         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6136         * objc-lang.c (find_methods): Use objfile_msymbols.
6137         (info_selectors_command, info_classes_command): Likewise.
6138         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6139         * objfiles.h (class objfile_msymbols): New.
6140         (ALL_OBJFILE_MSYMBOLS): Remove.
6141         (ALL_MSYMBOLS): Remove.
6142
6143 2019-01-09  Tom Tromey  <tom@tromey.com>
6144
6145         * common/next-iterator.h (next_adapter): Add Iterator template
6146         parameter.
6147         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6148         (class all_objfiles_safe): New.
6149         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6150         * objfiles.c (put_objfile_before): Update comment.
6151         (add_separate_debug_objfile): Likewise.
6152         (free_all_objfiles): Use all_objfiles_safe.
6153         (objfile_purge_solibs): Likewise.
6154
6155 2019-01-09  Tom Tromey  <tom@tromey.com>
6156
6157         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6158         (expand_symtab_containing_pc, lookup_static_symbol)
6159         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6160         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6161         all_objfiles.
6162         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6163         * breakpoint.c (create_overlay_event_breakpoint)
6164         (create_longjmp_master_breakpoint)
6165         (create_std_terminate_master_breakpoint)
6166         (create_exception_master_breakpoint): Use all_objfiles.
6167         * linux-thread-db.c (try_thread_db_load_from_pdir)
6168         (has_libpthread): Use all_objfiles.
6169         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6170         * linespec.c (iterate_over_all_matching_symtabs)
6171         (search_minsyms_for_name): Use all_objfiles.
6172         * maint.c (maintenance_info_sections): Use all_objfiles.
6173         * main.c (captured_main_1): Use all_objfiles.
6174         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6175         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6176         * guile/scm-pretty-print.c
6177         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6178         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6179         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6180         (maintenance_print_msymbols): Use all_objfiles.
6181         * source.c (select_source_symtab): Use all_objfiles.
6182         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6183         * symfile.c (remove_symbol_file_command)
6184         (expand_symtabs_matching, map_symbol_filenames): Use
6185         all_objfiles.
6186         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6187         all_objfiles.
6188         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6189         * objc-lang.c (find_methods): Use all_objfiles.
6190         * objfiles.c (have_partial_symbols, have_full_symbols)
6191         (have_minimal_symbols, qsort_cmp)
6192         (default_iterate_over_objfiles_in_search_order): Use
6193         all_objfiles.
6194         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6195         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6196         (maintenance_check_psymtabs): Use all_objfiles.
6197         (ALL_PSYMTABS): Remove.
6198         * compile/compile-object-run.c (do_module_cleanup): Use
6199         all_objfiles.
6200         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6201         * cp-support.c (add_symbol_overload_list_qualified): Use
6202         all_objfiles.
6203         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6204         Use all_objfiles.
6205         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6206         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6207         all_objfiles.
6208         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6209         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6210         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6211         Uses all_objfiles.
6212         * solib.c (solib_read_symbols): Use all_objfiles
6213
6214 2019-01-09  Tom Tromey  <tom@tromey.com>
6215
6216         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6217         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6218         all_objfiles.
6219         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6220         * symmisc.c (print_symbol_bcache_statistics)
6221         (print_objfile_statistics, maintenance_print_objfiles)
6222         (maintenance_info_symtabs, maintenance_check_symtabs)
6223         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6224         all_objfiles.
6225         * source.c (forget_cached_source_info): Use all_objfiles.
6226         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6227         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6228         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6229         * objfiles.c (update_section_map): Use all_objfiles.
6230         (shared_objfile_contains_address_p): Likewise.
6231         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6232         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6233
6234 2019-01-09  Tom Tromey  <tom@tromey.com>
6235
6236         * common/next-iterator.h: New file.
6237         * objfiles.h (class all_objfiles): New.
6238         (struct objfile_iterator): New.
6239
6240 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6241
6242         * NEWS: Move the description of the changed "frame", "select-frame",
6243          and "info frame" commands to the Changed commands section.
6244
6245 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6246
6247         * gdbtypes.c (check_stub_method_group): Remove handling of old
6248         mangling schemes.
6249         * linespec.c (find_methods): Likewise.
6250         * stabsread.c (read_member_functions): Likewise.
6251         * valops.c (search_struct_method): Likewise.
6252         (value_struct_elt_for_reference): Likewise.
6253         * NEWS: Mention this change.
6254
6255 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6256
6257         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6258         print_source_lines.
6259         * source.c (print_source_lines_base): Update line number check.
6260         (print_source_lines): New function.
6261         (source_lines_range::source_lines_range): New function.
6262         * source.h (class source_lines_range): New class.
6263         (print_source_lines): New declaration.
6264
6265 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6266
6267         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6268
6269 2019-01-08  Tom Tromey  <tom@tromey.com>
6270             Simon Marchi  <simon.marchi@ericsson.com>
6271
6272         PR gdb/24060
6273         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6274         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6275         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6276         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6277         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6278         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6279
6280 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6281
6282         * source.c (select_source_symtab): Move header comment to
6283         declaration in source.h.
6284         (forget_cached_source_info_for_objfile): Likewise.
6285         (forget_cached_source_info): Likewise.
6286         (identify_source_line): Likewise.
6287         * source.h (identify_source_line): Move declaration from symtab.h
6288         and add comment from source.c
6289         (print_source_lines): Likewise.
6290         (forget_cached_source_info_for_objfile): Likewise.
6291         (forget_cached_source_info): Likewise.
6292         (select_source_symtab): Likewise.
6293         (enum print_source_lines_flag): Move definition from symtab.h.
6294         * symtab.h (identify_source_line): Move declaration to source.h.
6295         (print_source_lines): Likewise.
6296         (forget_cached_source_info_for_objfile): Likewise.
6297         (forget_cached_source_info): Likewise.
6298         (select_source_symtab): Likewise.
6299         (enum print_source_lines_flag): Move definition to source.h.
6300         * tui/tui-hooks.c: Add 'source.h' include.
6301
6302 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6303
6304         * source.c (print_source_lines_base): Handle requests to print
6305         reverse line number sequences, and guard against empty lines
6306         string.
6307
6308 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6309
6310         * source.c (print_source_lines_base): Fix skip of '\r' if next
6311         character is '\n'.
6312
6313 2019-01-06  Tom Tromey  <tom@tromey.com>
6314
6315         * c-exp.y (struct c_parse_state) <macro_original_text,
6316         expansion_obstack>: New member.
6317         (macro_original_text, expansion_obstack): Remove globals.
6318         (scan_macro_expansion, scanning_macro_expansion)
6319         (finished_macro_expansion): Update.
6320         (scan_macro_cleanup): Remove.
6321         (yylex, c_parse): Update.
6322
6323 2019-01-06  Tom Tromey  <tom@tromey.com>
6324
6325         * c-exp.y (struct c_parse_state) <strings>: New member.
6326         (operator_stoken): Update.
6327
6328 2019-01-06  Tom Tromey  <tom@tromey.com>
6329
6330         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6331         (union type_stack_elt) <typelist_val>: Now a pointer to
6332         std::vector.
6333         (type_stack_cleanup): Don't declare.
6334         (push_typelist): Update.
6335         * parse.c (pop_typelist): Return a std::vector.
6336         (push_typelist): Take a std::vector.
6337         (follow_types): Update.  Do not free args.
6338         (type_stack_cleanup): Remove.
6339         * c-exp.y (struct c_parse_state): New.
6340         (cpstate): New global.
6341         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6342         (nonempty_typelist): Update.
6343         (func_mod): Create a new vector.
6344         (c_parse): Create a c_parse_state.
6345         (check_parameter_typelist): Do not delete params.
6346         (function_method): Update.  Do not delete type_list.
6347
6348 2019-01-06  Tom Tromey  <tom@tromey.com>
6349
6350         PR gdb/28155:
6351         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6352         check_typedef.
6353         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6354         (print_return_value): Likewise.
6355
6356 2019-01-05  Tom Tromey  <tom@tromey.com>
6357
6358         * contrib/cleanup_check.py: Remove.
6359         * contrib/gcc-with-excheck: Remove.
6360         * contrib/exsummary.py: Remove.
6361         * contrib/excheck.py: Remove.
6362
6363 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6364
6365         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6366         NULL. Initialize tpprev to NULL instead of assigning it
6367         to NULL on the next statement.
6368         * windows-nat.c (windows_delete_thread): Remove check for
6369         main_thread_id before printing thread exit notifications.
6370         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6371         Remove thread ID check against main_thread_id.
6372         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6373         windows_delete_thread.
6374         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6375
6376 2019-01-04  Tom Tromey  <tom@tromey.com>
6377
6378         * compile/compile.c (_initialize_compile): Use upper case for
6379         metasyntactic variables.
6380         * symmisc.c (_initialize_symmisc): Use upper case for
6381         metasyntactic variables.
6382         * psymtab.c (_initialize_psymtab): Use upper case for
6383         metasyntactic variables.
6384         * demangle.c (demangle_command): Use upper case for metasyntactic
6385         variables.
6386         (_initialize_demangler): Likewise.
6387         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6388         variables.
6389
6390 2019-01-03  Tom Tromey  <tom@tromey.com>
6391
6392         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6393
6394 2019-01-03  Tom Tromey  <tom@tromey.com>
6395
6396         * python/py-symtab.c (salpy_str): Update.
6397         (struct salpy_sal_object) <symtab>: Now a PyObject.
6398         (salpy_dealloc): Update.
6399         (del_objfile_sal): Use gdbpy_ref.
6400
6401 2019-01-03  Tom Tromey  <tom@tromey.com>
6402
6403         * python/py-type.c (convert_field): Use new_reference.  Return
6404         gdbpy_ref.
6405         (make_fielditem): Return gdbpy_ref.
6406         (typy_fields): Update.
6407         (typy_getitem): Update.
6408         (field_name): Return gdbpy_ref.  Use new_reference.
6409         (typy_iterator_iternext): Update.
6410
6411 2019-01-03  Tom Tromey  <tom@tromey.com>
6412
6413         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6414
6415 2019-01-03  Tom Tromey  <tom@tromey.com>
6416
6417         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6418         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6419         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6420         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6421         (pspy_set_type_printers): Likewise.
6422         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6423         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6424         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6425         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6426         (objfpy_set_type_printers): Likewise.
6427
6428 2019-01-03  Tom Tromey  <tom@tromey.com>
6429
6430         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6431         (gdbpy_print_stack): Use gdbpy_err_fetch.
6432         * python/python-internal.h (class gdbpy_err_fetch): New class.
6433         (class gdbpy_enter) <m_error_type, m_error_value,
6434         m_error_traceback>: Remove.
6435         <m_error>: New member.
6436         (gdbpy_exception_to_string): Don't declare.
6437         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6438         * python/py-value.c (convert_value_from_python): Use
6439         gdbpy_err_fetch.
6440         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6441         gdbpy_exception_to_string.
6442         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6443         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6444         gdbpy_err_fetch.
6445
6446 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6447
6448         * linux-nat.c (delete_lwp_cleanup): Delete.
6449         (struct lwp_deleter): New struct.
6450         (lwp_info_up): New typedef.
6451         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6452         lwp_info_up.
6453
6454 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         * linux-fork.c (class scoped_switch_fork_info): New class.
6457         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6458
6459 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * valops.c (find_overload_match): Remove use of null_cleanup, and
6462         calls to do_cleanups.
6463
6464 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6465
6466         * compile/compile-cplus-types.c
6467         (compile_cplus_instance::decl_name): Handle changes to
6468         cp_func_name.
6469         * cp-support.c (cp_func_name): Update header comment, update
6470         return type.
6471         * cp-support.h (cp_func_name): Update return type in declaration.
6472         * valops.c (find_overload_match): Move temp_func local to top
6473         level of function and change its type.  Use temp_func to hold and
6474         delete temporary string obtained from cp_func_name.
6475
6476 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6477
6478         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6479         gdb::char_vector, remove cleanup, and update uses of `msg`.
6480
6481 2019-01-03  Jim Wilson  <jimw@sifive.com>
6482
6483         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6484
6485 2019-01-02  Tom Tromey  <tom@tromey.com>
6486
6487         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6488         (tdesc_parse_xml): Remove cleanups.
6489         * target-descriptions.h (make_cleanup_free_target_description):
6490         Don't declare.
6491         (target_desc_deleter): New struct.
6492         (target_desc_up): New typedef.
6493         * target-descriptions.c (target_desc_deleter::operator()): Rename
6494         from free_target_description.
6495         (make_cleanup_free_target_description): Remove.
6496
6497 2019-01-02  Tom Tromey  <tom@tromey.com>
6498
6499         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6500         constructor, destructor.
6501         (linespec_parser): Remove typedef.
6502         (~linespec_parser): Rename from linespec_parser_delete.
6503         (linespec_lex_to_end, linespec_complete_label)
6504         (linespec_complete): Update.
6505         (decode_line_full): Remove cleanups.
6506         (decode_line_1): Update.
6507
6508 2019-01-02  Tom Tromey  <tom@tromey.com>
6509
6510         * python/python-internal.h (inferior_to_inferior_object): Change
6511         return type.
6512         * python/py-exitedevent.c (create_exited_event_object): Update.
6513         * python/py-inferior.c (inferior_to_inferior_object): Return
6514         gdbpy_ref.
6515         (python_new_inferior, python_inferior_deleted)
6516         (thread_to_thread_object, delete_thread_object)
6517         (build_inferior_list, gdbpy_selected_inferior): Update.
6518         * python/py-infthread.c (create_thread_object): Update.  Also fail
6519         if inferior_to_inferior_object fails.
6520
6521 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6522
6523         * inferior.h (class inferior) <displaced_step_state>: New field.
6524         * infrun.h (struct displaced_step_state): Move here from
6525         infrun.c.  Initialize fields, add constructor.
6526         <inf>: Remove field.
6527         <reset>: New method.
6528         * infrun.c (struct displaced_step_inferior_state): Move to
6529         infrun.h.
6530         (displaced_step_inferior_states): Remove.
6531         (get_displaced_stepping_state): Adust.
6532         (displaced_step_in_progress_any_inferior): Adjust.
6533         (displaced_step_in_progress_thread): Adjust.
6534         (displaced_step_in_progress): Adjust.
6535         (add_displaced_stepping_state): Remove.
6536         (get_displaced_step_closure_by_addr): Adjust.
6537         (remove_displaced_stepping_state): Remove.
6538         (infrun_inferior_exit): Call displaced_step_state.reset.
6539         (use_displaced_stepping): Don't check for NULL.
6540         (displaced_step_prepare_throw): Call
6541         get_displaced_stepping_state.
6542         (displaced_step_fixup): Don't check for NULL.
6543         (prepare_for_detach): Don't check for NULL.
6544
6545 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6546
6547         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6548          in case of call that did not complete.
6549
6550 2019-01-02  Andrey Utkin  <autkin@undo.io>
6551
6552         * symfile.c (find_separate_debug_file): Fix search of debug files for
6553         remote debuggee.
6554
6555 2019-01-02  Tom Tromey  <tom@tromey.com>
6556
6557         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6558         indentation.
6559         * python/py-frame.c (frapy_older): Remove cast.
6560         (frapy_newer): Likewise.
6561         * python/py-breakpoint.c (local_setattro): Remove cast.
6562         * python/py-arch.c (archpy_name): Remove local variable.
6563         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6564
6565 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6566
6567         * unittests/basic_string_view/element_access/char/empty.cc:
6568         Fix year range in copyright header.
6569
6570 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6571
6572         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6573         Delete.
6574         <operator==>: Update with for removed field.
6575         <hash>: Likewise.
6576         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6577         <isa_features>: ...this.
6578         <abi_features>: New field.
6579         (riscv_isa_flen): Update comment.
6580         (riscv_abi_xlen): New declaration.
6581         (riscv_abi_flen): New declaration.
6582         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6583         isa_features.
6584         (riscv_abi_xlen): New function.
6585         (riscv_isa_flen): Update to get answer from isa_features.
6586         (riscv_abi_flen): New function.
6587         (riscv_has_fp_abi): Update to get answer from abi_features.
6588         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6589         xlen and flen.
6590         (riscv_call_info) <xlen, flen>: Update comment.
6591         (riscv_call_arg_struct): Remove invalid assertions
6592         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6593         is removed.
6594         (riscv_gdbarch_init): Gather isa features and abi features
6595         separately, ensure both match on the gdbarch when reusing an old
6596         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6597         a target with 64-bit float hardware.
6598
6599 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6600
6601         * source.c (search_command_helper): Stop reverse search
6602         when line 1 has been searched.
6603
6604 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6605
6606         * record-full.c (record_full_base_target::close): Rewrite
6607         record_full_core_buf_list free logic.
6608
6609 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6610
6611         * break-catch-syscall.c (print_one_catch_syscall): xfree
6612         the last text.
6613
6614 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6615
6616         * top.c (print_gdb_version): Update Copyright year in version
6617         message.
6618
6619 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6620
6621         Update copyright year range in all GDB files.
6622
6623 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6624
6625         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6626
6627 For older changes see ChangeLog-2018.
6628 \f
6629 Local Variables:
6630 mode: change-log
6631 left-margin: 8
6632 fill-column: 74
6633 version-control: never
6634 coding: utf-8
6635 End:
6636